1 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
3 * keyboard.c (kbd_buffer_get_event): Read special events also in
4 batch mode. (Bug#11415)
6 2012-05-12 Glenn Morris <rgm@gnu.org>
8 * ns.mk: Update for ns_appbindir no longer having trailing "/".
10 2012-05-12 Eli Zaretskii <eliz@gnu.org>
12 * lisp.mk (lisp): Add newcomment.elc.
14 2012-05-12 Glenn Morris <rgm@gnu.org>
16 * Makefile.in (MKDIR_P): New, set by configure.
17 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
19 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
21 Remove unused function hourglass_started.
22 * dispextern.h (hourglass_started):
23 * w32fns.c (hourglass_started):
24 * xdisp.c (hourglass_started): Remove.
26 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
28 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
31 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
33 * xgselect.c (xg_select): Put maxfds+1 into a var.
34 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
36 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
38 2012-05-10 Dave Abrahams <dave@boostpro.com>
40 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
41 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
43 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
45 * dbusbind.c (xd_registered_buses): New internal Lisp object.
46 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
47 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
48 Initialize xd_registered_buses.
50 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
52 Untag more efficiently if USE_LSB_TAG.
53 This is based on a proposal by YAMAMOTO Mitsuharu in
54 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
55 For an admittedly artificial (nth 8000 longlist) benchmark on
56 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
57 Emacs's overall text size by 1%.
58 * lisp.h (XUNTAG): New macro.
59 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
60 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
61 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
63 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
64 * frame.h (XFRAME): Use XUNTAG.
66 Port recent dbusbind.c changes to 32-bit --with-wide-int.
67 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
68 Remove unportable assumptions about print widths of types like
70 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
71 intptr_t when converting between pointer and integer, to avoid GCC
72 warnings about wrong width.
74 2012-05-09 Eli Zaretskii <eliz@gnu.org>
76 * w32proc.c (new_child): Force Windows to reserve only 64KB of
77 stack for each reader_thread, instead of defaulting to 8MB
78 determined by the linker. This avoids failures in creating
79 subprocesses on Windows 7, see the discussion in this thread:
80 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
82 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
84 Fix up display of the *Minibuf-0* buffer in the mini window.
85 * keyboard.c (read_char): Don't clear the echo area if there's no
87 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
88 contents of *Minibuf-0*) if there's no message displayed in its stead.
90 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
92 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
95 2012-05-06 Chong Yidong <cyd@gnu.org>
97 * lisp.mk (lisp): Update.
99 2012-05-05 Jim Meyering <meyering@redhat.com>
101 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
103 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
105 * data.c (PUT_ERROR): New macro.
106 (syms_of_data): Use it. Add new error type `user-error'.
107 * undo.c (user_error): New function.
108 (Fprimitive_undo): Use it.
109 * print.c (print_error_message): Adjust print style for `user-error'.
110 * keyboard.c (user_error): New function.
111 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
113 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
115 Do not limit current-time-string to years 1000..9999.
116 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
117 (Fcurrent_time_string): Support any year that is supported by the
118 underlying localtime representation. Don't use asctime, as it
119 has undefined behavior for years outside the range -999..9999.
121 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
123 Fix race conditions involving setenv, gmtime, localtime, asctime.
124 Without this fix, interrupts could mess up code that uses these
125 nonreentrant functions, since setting TZ invalidates existing
126 tm_zone or tzname values, and since most of these functions return
127 pointers to static storage.
128 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
129 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
130 Grow the critical sections to include not just invoking
131 localtime/gmtime, but also accessing these functions' results
132 including their tm_zone values if any, and any related TZ setting.
133 (format_time_string): Last arg is now struct tm *, not struct tm **,
134 so that the struct tm is saved in the critical section.
135 All callers changed. Simplify allocation of initial buffer, partly
136 motivated by the fact that memory allocation needs to be outside
137 the critical section.
139 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
141 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
144 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
145 Remove duplicated buffer name initialization.
147 2012-05-02 Jim Meyering <jim@meyering.net>
149 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
151 * xfns.c (x_window): Use xstrdup (Bug#11375).
153 2012-05-02 Eli Zaretskii <eliz@gnu.org>
155 * xdisp.c (pos_visible_p): If already at a newline from the
156 display string before the 'while' loop, don't walk back the glyphs
157 from it3.glyph_row. Solves assertion violation when the display
158 string begins with a newline (egg.el). (Bug#11367)
160 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
162 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
165 2012-05-01 Glenn Morris <rgm@gnu.org>
167 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
168 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
169 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
170 All were removed before 23.1.
172 * dispnew.c: Remove HAVE_LIBNCURSES test;
173 it is always true on relevant platforms.
175 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
176 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
178 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
180 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
182 * .gdbinit (xpr): Remove checks for no longer existing misc types.
183 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
186 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
188 Do not avoid creating empty evaporating overlays (Bug#9642).
189 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
190 That is, do not delete an evaporating overlay if it becomes
191 empty after its bounds are adjusted to fit within its buffer.
192 This fix caused other problems, and I'm reverting it until we get
193 to the bottom of them.
195 2012-04-27 Chong Yidong <cyd@gnu.org>
197 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
199 2012-04-27 Eli Zaretskii <eliz@gnu.org>
201 * xdisp.c (pos_visible_p): If the window start position is beyond
202 ZV, start the display from buffer beginning. Prevents assertion
203 violation in init_iterator when the minibuffer window is scrolled
206 * window.c (window_scroll_pixel_based): Likewise.
208 2012-04-27 Chong Yidong <cyd@gnu.org>
210 * keymap.c (where_is_internal): Doc fix (Bug#10872).
212 2012-04-27 Glenn Morris <rgm@gnu.org>
214 * fileio.c (Fcopy_file, Fset_file_selinux_context):
215 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
217 2012-04-27 Eli Zaretskii <eliz@gnu.org>
219 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
220 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
222 2012-04-26 Eli Zaretskii <eliz@gnu.org>
224 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
225 display element, check also the underlying string or buffer
226 character. (Bug#11341)
228 * w32menu.c: Include w32heap.h.
229 (add_menu_item): If the call to AppendMenuW (via
230 unicode_append_menu) fails, disable Unicode menus only if we are
231 running on Windows 9X/Me.
233 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
235 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
236 (xgetint): Add missing shift for LSB tags.
238 2012-04-24 Martin Rudalics <rudalics@gmx.at>
240 * keyboard.c (read_char): Don't wipe echo area for select window
241 events: These might get delayed via `mouse-autoselect-window'
244 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
246 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
247 manipulation of :loaded-from data.
249 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
251 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
252 now a cons (bug#11311).
254 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
256 Do not create empty overlays with the evaporate property (Bug#9642).
257 * buffer.c (Fmove_overlay): Delete an evaporating overlay
258 if it becomes empty after its bounds are adjusted to fit within
259 its buffer. Without this fix, in a nonempty buffer (let ((o
260 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
261 yields an empty overlay that has the evaporate property, which is
262 not supposed to happen.
264 Fix minor GTK3 problems found by static checking.
265 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
266 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
267 (struct _EmacsFixedClass, emacs_fixed_get_type):
268 Move decls here from emacsgtkfixed.h, since they needn't be public.
269 (emacs_fixed_get_type): Now static.
270 (emacs_fixed_class_init): Omit unused local.
271 (emacs_fixed_child_type): Remove; unused.
272 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
273 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
274 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
275 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
276 (EMACS_FIXED_GET_CLASS): Remove; unused.
277 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
279 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
280 Problem reported by Juanma Barranquero for Windows -Wunused-function.
282 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
284 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
285 * gmalloc.c: (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
286 (__malloc_size_t, __malloc_ptrdiff_t):
287 Remove. All uses removed, replaced by the definiens if needed,
288 since we can assume C89 or better now.
289 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
290 (protect_malloc_state, align, get_contiguous_space)
291 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
292 (malloc_atfork_handler_child, malloc_enable_thread)
293 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
294 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
295 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
296 (special_realloc, _realloc_internal_nolock, _realloc_internal)
297 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
298 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
299 Define using prototypes, not old style.
300 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
301 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
302 (align): Don't assume that signed integer overflow wraps around.
303 Omit unused local var.
304 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
305 (_free_internal_nolock, memalign, mallochook, reallochook):
306 Omit no-longer-needed casts.
307 (valloc): Use getpagesize, not __getpagesize.
308 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
309 (struct hdr): The 'magic' member is now size_t, not unsigned long.
311 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
313 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
315 Move functions from C to Lisp. Make non-blocking method calls
316 the default. Implement further D-Bus standard interfaces.
318 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
319 (QCdbus_request_name_allow_replacement)
320 (QCdbus_request_name_replace_existing)
321 (QCdbus_request_name_do_not_queue)
322 (QCdbus_request_name_reply_primary_owner)
323 (QCdbus_request_name_reply_in_queue)
324 (QCdbus_request_name_reply_exists)
325 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
326 (QCdbus_registered_serial, QCdbus_registered_method)
327 (QCdbus_registered_signal): New Lisp objects.
328 (XD_DEBUG_MESSAGE): Use sizeof.
329 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
330 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
331 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
332 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
333 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
334 (xd_signature, xd_append_arg): Allow float for integer types.
335 (xd_get_connection_references): New function.
336 (xd_get_connection_address): Rename from xd_initialize.
337 Return cached address.
338 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
339 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
341 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
342 Return number of refcounts.
343 (Fdbus_get_unique_name): Make stronger parameter check.
344 (Fdbus_message_internal): New defun.
345 (Fdbus_call_method, Fdbus_call_method_asynchronously)
346 (Fdbus_method_return_internal, Fdbus_method_error_internal)
347 (Fdbus_send_signal, Fdbus_register_service)
348 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
349 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
350 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
351 (Vdbus_compiled_version, Vdbus_runtime_version)
352 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
353 (Vdbus_message_type_method_return, Vdbus_message_type_error)
354 (Vdbus_message_type_signal): New defvars.
355 (Vdbus_registered_buses, Vdbus_registered_objects_table):
358 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
360 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
361 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
362 Do not assume ptrdiff_t is the same width as 'int'.
364 * alloc.c: Handle unusual debugging option combinations.
365 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
366 since the two debugging options are incompatible.
367 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
369 (mem_init, mem_insert, mem_insert_fixup):
370 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
371 (NEED_MEM_INSERT): Remove; no longer needed.
373 2012-04-22 Leo Liu <sdl.web@gmail.com>
375 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
377 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
379 * sysdep.c [__FreeBSD__]: Minor cleanups.
380 (list_system_processes, system_process_attributes) [__FreeBSD__]:
381 Use Emacs indenting style more consistently. Avoid some casts.
382 Use 'double' consistently rather than mixing 'float' and 'double'.
384 2012-04-21 Eduard Wiebe <usenet@pusto.de>
386 * sysdep.c (list_system_processes, system_process_attributes):
387 Add implementation for FreeBSD (Bug#5243).
389 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
391 * lisp.mk (lisp): Update.
393 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
395 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
396 It is never used otherwise.
398 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
400 * print.c (print_preprocess): Only check print_depth if print-circle
402 (print_object): Check for cycles even when print-circle is nil and
403 print-gensym is t, but only check print_depth if print-circle is nil.
405 2012-04-20 Chong Yidong <cyd@gnu.org>
407 * process.c (wait_reading_process_output): If EIO occurs on a pty,
408 set the status to "failed" and ensure that sentinel is run.
410 2012-04-20 Glenn Morris <rgm@gnu.org>
412 * process.c (Fset_process_inherit_coding_system_flag)
413 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
414 (Fmake_network_process, Fmake_serial_process): Doc fix.
416 2012-04-20 Eli Zaretskii <eliz@gnu.org>
418 * xdisp.c (string_buffer_position_lim): Limit starting position to
420 (set_cursor_from_row): If called for a mode-line or header-line
421 row, return zero immediately.
422 (try_cursor_movement): If inside continuation line, don't back up
423 farther than the first row after the header line, if any.
424 Don't consider the header-line row as "partially visible", even if
425 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
427 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
429 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
432 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
433 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
435 configure: new option --enable-gcc-warnings (Bug#11207)
436 * Makefile.in (C_WARNINGS_SWITCH): Remove.
437 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
438 (ALL_CFLAGS): Use new macros rather than old.
439 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
440 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
441 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
442 -Wunused-result, -Wunused-variable. This should go away once
443 the Emacs and Gnulib regex code is merged.
444 (xmalloc, xrealloc): Now static.
446 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
448 * dired.c (Fsystem_groups): Remove unused local.
450 2012-04-17 Glenn Morris <rgm@gnu.org>
452 * dired.c (Fsystem_users): Doc fix.
454 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
456 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
457 (syms_of_dired): Add them.
459 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
461 Fix minor alloc.c problems found by static checking.
462 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
463 New extern decls, to avoid calling undeclared functions.
464 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
465 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
466 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
467 (NEED_MEM_INSERT): New macro.
468 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
469 Remove one incorrect comment and fix another.
471 Fix minor ralloc.c problems found by static checking.
472 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
473 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
474 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
475 (r_alloc_sbrk): Now static.
477 Improve ralloc.c interface checking.
478 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
479 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
480 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
481 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
482 [REL_ALLOC]: ... to here, to check interface.
483 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
484 Remove decls. This fixes an "It stinks!".
486 * alloc.c (which_symbols): Fix alignment issue / type clash.
488 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
490 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
491 (struct Lisp_Misc_Any): Likewise.
492 (struct Lisp_Free): Likewise.
493 * alloc.c (union aligned_Lisp_Symbol): Define.
494 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
495 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
496 (union aligned_Lisp_Misc): Define.
497 (MARKER_BLOCK_SIZE, struct marker_block): Use union
498 aligned_Lisp_Misc instead of union Lisp_Misc.
499 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
501 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
503 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
504 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
505 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
506 * s/netbsd.h, s/sol2-6.h:
507 Remove definition of GC_MARK_STACK, since the default now works.
508 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
509 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
510 no longer the default.
511 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
513 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
515 * lread.c (lisp_file_lexically_bound_p):
516 Fix hang at ";-*-\n" (bug#11238).
518 2012-04-14 Eli Zaretskii <eliz@gnu.org>
520 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
521 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
523 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
525 * nsterm.m (constrainFrameRect): Always constrain when there is only
526 one screen (Bug#10962).
528 2012-04-13 Ken Brown <kbrown@cornell.edu>
530 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
532 2012-04-13 Reuben Thomas <rrt@sc3d.org>
534 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
536 2012-04-11 Daniel Colascione <dancol@dancol.org>
538 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
539 against is gone. It's better to use vfork now so that when Cygwin
540 gains a new, working vfork, we use it automatically (bug#10398).
542 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
544 * window.c (save_window_save): Obey window-point-insertion-type.
546 2012-04-11 Glenn Morris <rgm@gnu.org>
548 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
550 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
552 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
554 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
556 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
557 (force_quit_count): New var.
558 (handle_interrupt): Use it.
560 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
562 * w32.c (w32_delayed_load): Record the full path of the library
563 being loaded (bug#10424).
565 2012-04-09 Glenn Morris <rgm@gnu.org>
567 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
568 not just in the obarray, before snarfing them. (Bug#11036)
570 * Makefile.in ($(leimdir)/leim-list.el):
571 Pass EMACS rather than BUILT_EMACS.
573 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
575 * process.c (make_process):
576 * process.h: Add integer `gnutls_handshakes_tried' member to
579 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
580 Add convenience `GNUTLS_LOG2i' macro.
582 * gnutls.c (gnutls_log_function2i): Convenience log function.
583 (emacs_gnutls_read): Use new log functions,
584 `gnutls_handshakes_tried' process member, and
585 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
586 attempts per process (connection).
588 2012-04-09 Chong Yidong <cyd@gnu.org>
590 * eval.c (Fuser_variable_p, user_variable_p_eh)
591 (lisp_indirect_variable): Functions deleted.
592 (Fdefvar): Caller changed.
594 * callint.c (Finteractive, Fcall_interactively):
595 * minibuf.c (Fread_variable): Callers changed.
597 2012-04-09 Eli Zaretskii <eliz@gnu.org>
599 * xdisp.c (set_cursor_from_row): If the display string appears in
600 the buffer at position that is closer to point than the position
601 after the display string, display the cursor on the first glyph of
602 the display string. Fixes cursor display when a 'display' text
603 property immediately follows invisible text. (Bug#11094)
605 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
607 composite.c: use 'double' consistently
608 * composite.c (get_composition_id): Use 'double' consistently
609 instead of converting 'float' to 'double' and vice versa; this is
610 easier to understand and avoids a GCC warning.
612 2012-04-09 Glenn Morris <rgm@gnu.org>
614 * Makefile.in: Generate leim-list with bootstrap-emacs, in
615 preparation for dumping it with emacs. (Bug#4789)
616 (leimdir): New variable.
617 ($(leimdir)/leim-list.el): New rule.
618 (emacs$(EXEEXT)): Depend on leim-list.el.
620 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
621 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
622 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
624 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
626 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
629 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
631 * xml.c (init_libxml2_functions) [WINDOWSNT]:
632 Remove unused local variable.
634 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
636 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
637 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
638 (mark_memory): Mark Lisp_Objects only if pointers might hide in
639 objects, as mark_maybe_pointer will catch them otherwise.
640 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
641 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
643 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
645 Fix typo that broke non-Windows builds.
646 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
648 2012-04-07 Eli Zaretskii <eliz@gnu.org>
650 Support building on MS-Windows with libxml2.
652 * makefile.w32-in (OBJ2): Add xml.$(O).
653 (GLOBAL_SOURCES): Add xml.c.
654 ($(BLD)/xml.$(O)): New dependency list.
656 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
657 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
658 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
659 [!WINDOWSNT]: New macros.
660 (init_libxml2_functions, libxml2_loaded_p): New functions.
661 (parse_region): Call fn_xmlCheckVersion instead of using the macro
662 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
663 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
664 Calls xmlCleanupParser only if libxml2 was loaded (or statically
666 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
667 Call init_libxml2_functions before calling libxml2 functions.
668 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
670 * emacs.c: Don't include libxml/parser.h.
671 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
672 xmlCleanupParser directly.
674 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
676 2012-04-07 Eli Zaretskii <eliz@gnu.org>
678 * indent.c (Fvertical_motion): If there is a display string at
679 point, use it.vpos to compute how many lines to backtrack after
680 move_it_to point. (Bug#11133)
682 2012-04-06 Eli Zaretskii <eliz@gnu.org>
684 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
685 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
686 about subtle differences between FETCH_CHAR* and STRING_CHAR*
687 macros related to unification of CJK characters. For the details,
688 see the discussion following the message here:
689 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
691 2012-04-04 Chong Yidong <cyd@gnu.org>
693 * keyboard.c (Vdelayed_warnings_list): Doc fix.
695 2012-04-01 Eli Zaretskii <eliz@gnu.org>
697 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
698 instead of alloca. (Bug#11138)
700 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
702 * w32menu.c (is_simple_dialog): Properly check lisp types.
705 2012-03-31 Eli Zaretskii <eliz@gnu.org>
707 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
708 position we get to after a call to move_it_to fails the
709 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
710 only if we wind up in a string from display property. (Bug#11063)
712 * window.c (Fdelete_other_windows_internal): Invalidate the row
713 and column information about mouse highlight, so that redisplay
714 restores it after reallocating the glyph matrices. (Bug#7464)
716 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
717 string comes from a `display' text property, use the buffer
718 position of that property as if we actually saw that position in
720 (move_it_by_lines): Remove the assertion that
721 "it->current_x == 0 && it->hpos == 0" which can be legitimately
722 violated when there's a before-string at the beginning of a line.
725 2012-03-30 Eli Zaretskii <eliz@gnu.org>
727 * xdisp.c (append_space_for_newline): If the default face was
728 remapped, use the remapped face for the appended newline.
729 (extend_face_to_end_of_line): Use the remapped default face for
730 extending the face to the end of the line.
731 (display_line): Call extend_face_to_end_of_line when the default
732 face was remapped. (Bug#11068)
734 2012-03-29 Eli Zaretskii <eliz@gnu.org>
736 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
738 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
740 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
742 2012-03-27 Glenn Morris <rgm@gnu.org>
744 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
747 2012-03-26 Kenichi Handa <handa@m17n.org>
749 * dispextern.h (struct glyph): Fix previous change. Change the
750 bit length of glyphless.ch to 25 (Bug#11082).
752 2012-03-26 Chong Yidong <cyd@gnu.org>
754 * keyboard.c (Vselection_inhibit_update_commands): New variable.
755 (command_loop_1): Use it; inhibit selection update for
756 handle-select-window too (Bug#8996).
758 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
760 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
762 2012-03-25 Kenichi Handa <handa@m17n.org>
764 * dispextern.h (struct glyph): Change the bit length of
765 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
767 2012-03-24 Eli Zaretskii <eliz@gnu.org>
769 * s/ms-w32.h (tzname): Include time.h before redirecting to
770 _tzname. Fixes the MSVC build. (Bug#9960)
772 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
774 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
777 * xterm.c (XTread_socket): Only modify handling_signal if
778 !SYNC_INPUT. (Bug#11080)
780 2012-03-23 Eli Zaretskii <eliz@gnu.org>
782 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
783 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
784 when fetching a multibyte character consumes more bytes than
785 CHAR_BYTES returns, due to unification of CJK characters in
786 string_char. (Bug#11073)
788 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
790 * process.c (wait_reading_process_output): Handle pty disconnect
791 by refraining from sending oneself a SIGCHLD (bug#10933).
793 2012-03-22 Chong Yidong <cyd@gnu.org>
795 * dispextern.h (struct it): New member string_from_prefix_prop_p.
797 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
798 Mark string as coming from a prefix property.
799 (handle_face_prop): Use default face for prefix strings (Bug#4281).
800 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
802 2012-03-21 Chong Yidong <cyd@gnu.org>
804 * xfaces.c (Vface_remapping_alist): Doc fix.
806 2012-03-20 Eli Zaretskii <eliz@gnu.org>
808 * w32proc.c (Fw32_set_console_codepage)
809 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
812 2012-03-20 Chong Yidong <cyd@gnu.org>
814 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
815 to reflect default non-nil value of redisplay-dont-pause.
817 2012-03-19 Kenichi Handa <handa@m17n.org>
819 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
820 it fit in a valid range (Bug#11003).
822 2012-03-18 Eli Zaretskii <eliz@gnu.org>
824 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
825 that is not from display property, accept the row as a "cursor
826 row" if one of the string's character has a non-nil `cursor'
827 property. Fixes cursor positioning when there are newlines in
828 overlay strings, e.g. in icomplete.el. (Bug#11035)
830 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
832 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
834 2012-03-12 Chong Yidong <cyd@gnu.org>
836 * eval.c (inhibit_lisp_code): Rename from
837 inhibit_window_configuration_change_hook; move from window.c.
839 * xfns.c (unwind_create_frame_1, Fx_create_frame):
840 * window.c (run_window_configuration_change_hook)
841 (syms_of_window): Callers changed.
843 2012-03-11 Chong Yidong <cyd@gnu.org>
845 * keymap.c (Fkey_description): Doc fix (Bug#9700).
847 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
849 2012-03-10 Chong Yidong <cyd@gnu.org>
851 * frame.c (other_visible_frames): Don't assume the selected frame
852 is visible (Bug#10955).
854 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
856 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
858 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
860 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
861 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
864 2012-03-03 Glenn Morris <rgm@gnu.org>
866 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
868 2012-03-02 Eli Zaretskii <eliz@gnu.org>
870 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
871 position past the first glyph_row that ends at ZV. (Bug#10902)
872 (redisplay_window, next_element_from_string): Fix typos in
874 (redisplay_window): Pass to move_it_vertically the margin in
875 pixels, not in screen lines.
877 2012-03-02 Glenn Morris <rgm@gnu.org>
879 * buffer.c (buffer-list-update-hook): Doc fix.
881 2012-02-29 Eli Zaretskii <eliz@gnu.org>
883 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
884 push_it before setting up the iterator for the first overlay
885 string, even if we have an empty string loaded.
886 (next_overlay_string): If there's an empty string on the iterator
887 stack, pop the stack. (Bug#10903)
889 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
891 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
892 Suggested by Stefan Monnier in
893 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
894 * alloc.c (widen_to_Lisp_Object): New static function.
895 (mark_memory): Also mark Lisp_Objects by fetching pointer words
896 and widening them to Lisp_Objects. This would work even if
897 USE_LSB_TAG is defined and wide integers are used, which might
898 happen in a future version of Emacs.
900 2012-02-25 Chong Yidong <cyd@gnu.org>
902 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
905 * xselect.c (Fx_selection_exists_p): Doc fix.
906 (x_clipboard_manager_save_all): Print an informative message
907 before saving to clipboard manager.
909 2012-02-24 Chong Yidong <cyd@gnu.org>
911 * keyboard.c (process_special_events): Handle all X selection
912 requests in kbd_buffer, not just the next one (Bug#8869).
914 2012-02-23 Chong Yidong <cyd@gnu.org>
916 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
917 call when setting menu-bar-lines and tool-bar-lines parameters.
918 (unwind_create_frame_1): New helper function.
920 * window.c (inhibit_window_configuration_change_hook): New var.
921 (run_window_configuration_change_hook): Obey it.
922 (syms_of_window): Initialize it.
924 2012-02-22 Chong Yidong <cyd@gnu.org>
926 * xterm.c (x_draw_image_relief): Add missing type check for
927 Vtool_bar_button_margin (Bug#10743).
929 2012-02-21 Chong Yidong <cyd@gnu.org>
931 * fileio.c (Vfile_name_handler_alist): Doc fix.
933 * buffer.c (Fget_file_buffer): Protect against invalid file
934 handler return value.
936 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
938 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
939 when computing $valmask.
941 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
942 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
943 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
944 It's useless in that case, and it can cause problems on hosts
945 that allocate halves of EMACS_INT values separately.
946 Reported by Dan Horák. Diagnosed by Andreas Schwab in
947 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
948 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
949 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
950 it avoids undefined behavior on hosts where shifting right by more
951 than the word width has undefined behavior.
953 2012-02-19 Chong Yidong <cyd@gnu.org>
955 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
956 (Funhandled_file_name_directory, Ffile_name_as_directory)
957 (Fdirectory_file_name, Fexpand_file_name)
958 (Fsubstitute_in_file_name): Protect against invalid file handler
959 return values (Bug#10845).
961 2012-02-18 Eli Zaretskii <eliz@gnu.org>
963 * .gdbinit (pitx): Fix incorrect references to fields of the
966 2012-02-17 Chong Yidong <cyd@gnu.org>
968 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
970 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
972 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
973 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
975 2012-02-15 Chong Yidong <cyd@gnu.org>
977 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
978 marked as special. Also, starting docstrings with * is obsolete.
980 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
982 * gnutls.c (emacs_gnutls_write): Fix last change.
984 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
986 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
989 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
991 * keymap.c (Fsingle_key_description): Handle char ranges.
993 2012-02-12 Chong Yidong <cyd@gnu.org>
995 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
996 as that creates a dangerous corner case.
998 * window.c (Fdelete_window_internal): Invalidate the mouse
999 highlight (Bug#9904).
1001 2012-02-12 Glenn Morris <rgm@gnu.org>
1003 * xselect.c (Fx_own_selection_internal)
1004 (Fx_get_selection_internal, Fx_disown_selection_internal)
1005 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
1006 * nsselect.m (Fx_own_selection_internal)
1007 (Fx_disown_selection_internal, Fx_selection_exists_p)
1008 (Fx_selection_owner_p, Fx_get_selection_internal):
1009 Sync docs and argument specs with the xselect.c versions.
1011 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
1013 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
1015 2012-02-11 Eli Zaretskii <eliz@gnu.org>
1017 * w32select.c (Fx_selection_exists_p): Sync doc string and
1018 argument list with xselect.c. (Bug#10783)
1020 * w16select.c (Fx_selection_exists_p): Sync doc string and
1021 argument list with xselect.c. (Bug#10783)
1023 2012-02-10 Glenn Morris <rgm@gnu.org>
1025 * fns.c (Fsecure_hash): Doc fix.
1027 2012-02-09 Kenichi Handa <handa@m17n.org>
1029 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
1031 2012-02-07 Chong Yidong <cyd@gnu.org>
1033 * buffer.c (Fbuffer_local_variables)
1034 (buffer_lisp_local_variables): Handle unbound vars correctly;
1035 don't let Qunbound leak into Lisp.
1037 2012-02-07 Glenn Morris <rgm@gnu.org>
1039 * image.c (Fimagemagick_types): Doc fix.
1041 * image.c (imagemagick-render-type): Change it from a lisp object
1042 to an integer. Move the doc here from the lisp manual.
1043 Treat all values not equal to 0 the same.
1045 2012-02-06 Chong Yidong <cyd@gnu.org>
1047 * doc.c (store_function_docstring): Avoid applying docstring of
1048 alias to base function (Bug#2603).
1050 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
1052 * .gdbinit (pp1, pv1): Remove redundant defines.
1055 2012-02-04 Chong Yidong <cyd@gnu.org>
1057 * nsterm.m: Declare a global (Bug#10694).
1059 2012-02-04 Eli Zaretskii <eliz@gnu.org>
1061 * w32.c (get_emacs_configuration_options):
1062 Include --enable-checking, if specified, in the return value.
1064 2012-02-04 Martin Rudalics <rudalics@gmx.at>
1066 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
1067 after rounding frame sizes. (Bug#9723)
1069 2012-02-04 Eli Zaretskii <eliz@gnu.org>
1071 * keyboard.c (adjust_point_for_property): Don't position point
1072 before BEGV. (Bug#10696)
1074 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
1076 Handle overflow when computing char display width (Bug#9496).
1077 * character.c (char_width): Return EMACS_INT, not int.
1078 (char_width, c_string_width): Check for overflow when
1079 computing the width; this is possible now that individual
1080 characters can have unbounded width. Problem introduced
1081 by merge from Emacs 23 on 2012-01-19.
1083 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
1085 * dbusbind.c (Fdbus_register_method): Mention the return value
1086 :ignore in the docstring.
1088 2012-02-02 Glenn Morris <rgm@gnu.org>
1090 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
1092 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1093 Unconditionally set to t. (Bug#10673)
1094 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1095 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
1096 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
1098 2012-02-02 Kenichi Handa <handa@m17n.org>
1100 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
1101 0, do not call append_composite_glyph.
1103 2012-02-02 Kenichi Handa <handa@m17n.org>
1105 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
1107 (x_produce_glyphs): If the component of a composition is a null
1108 string, set it->pixel_width to 1 to avoid zero-width glyph.
1110 2012-02-01 Eli Zaretskii <eliz@gnu.org>
1112 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
1113 first 2 arguments are identical. This makes inserting large
1114 output from a subprocess an order of magnitude faster on
1115 MS-Windows, where all sbrk'ed memory is always contiguous.
1117 2012-01-31 Glenn Morris <rgm@gnu.org>
1119 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1120 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
1121 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
1123 2012-01-29 Glenn Morris <rgm@gnu.org>
1125 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
1127 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
1129 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
1131 2012-01-28 Chong Yidong <cyd@gnu.org>
1133 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
1135 2012-01-26 Chong Yidong <cyd@gnu.org>
1137 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
1139 * search.c (Fsearch_forward, Fsearch_backward): Document negative
1140 repeat counts (Bug#10507).
1142 2012-01-26 Glenn Morris <rgm@gnu.org>
1144 * lread.c (syms_of_lread): Doc fix.
1146 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
1148 * coding.c (encode_designation_at_bol): Change return value to
1151 2012-01-25 Chong Yidong <cyd@gnu.org>
1153 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
1155 2012-01-21 Chong Yidong <cyd@gnu.org>
1157 * floatfns.c (Fcopysign): Make the second argument non-optional,
1158 since nil is not allowed anyway.
1160 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
1162 * process.c (read_process_output): Use p instead of XPROCESS (proc).
1163 (send_process): Likewise.
1165 2012-01-19 Martin Rudalics <rudalics@gmx.at>
1167 * window.c (save_window_save, Fcurrent_window_configuration)
1168 (Vwindow_persistent_parameters): Do not use Qstate.
1169 Rewrite doc-strings.
1171 2012-01-19 Kenichi Handa <handa@m17n.org>
1173 * character.c (char_width): New function.
1174 (Fchar_width, c_string_width, lisp_string_width):
1175 Use char_width (Bug#9496).
1177 2012-01-16 Martin Rudalics <rudalics@gmx.at>
1179 * window.c (Vwindow_persistent_parameters): New variable.
1180 (Fset_window_configuration, save_window_save): Handle persistent
1183 2012-01-14 Eli Zaretskii <eliz@gnu.org>
1185 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
1186 thrashing the stack of the thread. (Bug#9087)
1188 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
1190 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
1192 2012-01-11 Eli Zaretskii <eliz@gnu.org>
1194 * xdisp.c (rows_from_pos_range): Handle the case where the
1195 highlight ends on a newline. (Bug#10464)
1196 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
1197 he end column for display of highlight that ends on a newline
1200 2012-01-11 Glenn Morris <rgm@gnu.org>
1202 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
1203 from load-path also when installation-directory is nil. (Bug#10208)
1205 2012-01-10 Glenn Morris <rgm@gnu.org>
1207 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
1209 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
1210 Update template values to be closer to their typical values these days.
1212 2012-01-09 Eli Zaretskii <eliz@gnu.org>
1214 * xdisp.c (rows_from_pos_range): Accept additional argument
1215 DISP_STRING, and accept any glyph in a row whose object is that
1216 string as eligible for mouse highlight. Fixes mouse highlight of
1217 display strings from overlays. (Bug#10464)
1219 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
1221 emacs: fix an auto-save permissions race condition (Bug#10400)
1222 * fileio.c (auto_saving_dir_umask): New static var.
1223 (Fmake_directory_internal): Use it.
1224 (do_auto_save_make_dir): Set it, instead of invoking chmod after
1225 creating the directory. The old code temporarily assigns
1226 too-generous permissions to the directory.
1227 (do_auto_save_eh): Clear it.
1228 (Fdo_auto_save): Catch all errors, not just file errors, so
1229 that the var is always cleared.
1231 2012-01-07 Eli Zaretskii <eliz@gnu.org>
1233 * search.c (scan_buffer): Pass character positions to
1234 know_region_cache, not byte positions. (Bug#6540)
1236 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
1238 * w32.c (sys_rename): Report EXDEV when rename of a directory
1239 fails because the target is on another logical disk. (Bug#10284)
1241 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
1243 * xterm.c (x_embed_request_focus): New function.
1245 * xterm.h: Add prototype.
1247 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
1249 2012-01-05 Glenn Morris <rgm@gnu.org>
1251 * emacs.c (emacs_copyright): Update short copyright year to 2012.
1253 2012-01-01 Eli Zaretskii <eliz@gnu.org>
1255 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
1256 Load gnutls_transport_set_lowat only if GnuTLS version is below
1258 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
1259 GnuTLS versions below 2.11.1.
1261 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
1263 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
1264 to the doc string advising against its use for altering the way
1265 windows are scrolled.
1267 2011-12-28 Kenichi Handa <handa@m17n.org>
1269 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
1270 coding-system ASCII compatible only when it does not produce BOM
1271 on encoding (Bug#10383).
1273 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
1275 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
1277 (create_and_show_popup_menu): Always use menu_position_func for
1280 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
1282 * callint.c (Fcall_interactively): Don't truncate prompt string.
1284 2011-12-23 Eli Zaretskii <eliz@gnu.org>
1286 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
1287 property that ends at ZV, so that the bidi iteration could be
1288 resumed from there (after widening). (Bug#10360)
1290 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
1292 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
1294 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
1296 * nsterm.m (x_free_frame_resources):
1297 Release f->output_data.ns->miniimage.
1298 (ns_index_color): Fix indentation. Do not retain
1299 color_table->colors[i].
1301 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
1304 * nsfns.m (x_set_background_color): Assign return value from
1305 ns_index_color to face-background instead of NSColor*.
1306 (ns_implicitly_set_icon_type): Fix indentation.
1307 Change assignment in for loop to comparison.
1309 * emacs.c (ns_pool): New variable.
1310 (main): Assign ns_pool.
1311 (Fkill_emacs): Call ns_release_autorelease_pool.
1313 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
1314 autorelease fdesc, release fdAttrs and tdict.
1315 (ns_get_covering_families): Release charset.
1316 (ns_findfonts): Release NSFontDescriptor created with new.
1317 (ns_uni_to_glyphs): Fix indentation.
1318 (setString): Release attrStr before assigning new value.
1320 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1322 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1324 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1325 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1327 2011-12-18 David Reitter <reitter@cmu.edu>
1329 * nsterm.m (ns_term_init): Subscribe for notifications
1330 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1331 to method trackingNotification in EmacsMenu.
1333 * nsmenu.m (trackingMenu): New variable.
1334 (trackingNotification): New method (from Aquamacs).
1335 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
1336 from Aquamacs (Bug#7030).
1338 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1340 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1341 (symbol_to_nsstring): Fix indentation.
1342 (ns_symbol_to_pb): New function.
1343 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1344 (Fns_rotate_cut_buffers_internal): Remove.
1345 (Fns_store_selection_internal): Rename from
1346 Fns_store_cut_buffer_internal.
1347 (ns_get_foreign_selection, Fx_own_selection_internal)
1348 (Fx_disown_selection_internal, Fx_selection_exists_p)
1349 (Fns_get_selection_internal, Fns_store_selection_internal):
1350 Use ns_symbol_to_pb and check if return value is nil.
1351 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1352 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
1353 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1354 renamed to Sns_store_selection_internal.
1355 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1356 and remove this function.
1357 (ns_handle_selection_clear): Remove, never used.
1358 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1361 2011-12-17 Ken Brown <kbrown@cornell.edu>
1363 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1364 GID is unknown (Bug#10257).
1366 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1368 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1369 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1370 which caused a build failure on GNU/Linux IA-64. This problem was
1371 introduced by my 2011-10-07 patch.
1373 2011-12-15 Juri Linkov <juri@jurta.org>
1375 * image.c (imagemagick_error): New function. (Bug#10112)
1376 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1377 Use `imagemagick_error' where ImageMagick functions return
1379 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1382 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1384 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1385 fill background (Bug#8992).
1387 2011-12-13 Martin Rudalics <rudalics@gmx.at>
1389 * window.c (Vwindow_combination_resize)
1390 (Vwindow_combination_limit): Use t instead of non-nil in
1392 (Vrecenter_redisplay): Add first sentence of doc-string on
1394 (Frecenter): Fix doc-string typo.
1396 2011-12-11 Kenichi Handa <handa@m17n.org>
1398 * coding.c (Funencodable_char_position): Pay attention to the
1399 buffer text relocation (Bug#9389).
1401 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1403 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1404 gtk_init (Bug#10100).
1406 2011-12-10 Eli Zaretskii <eliz@gnu.org>
1408 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1409 IT->string is nil. (Bug#10263)
1411 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1413 * nsterm.h (x_free_frame_resources): Declare.
1415 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1416 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1418 * nsterm.h (ns_get_defaults_value): Declare.
1420 * nsterm.m (ns_default): Call ns_get_defaults_value.
1422 2011-12-09 Eli Zaretskii <eliz@gnu.org>
1424 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1427 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1429 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1430 that where the value of an _OBJC_* symbol points to is in the .bss
1431 section (Bug#10240).
1433 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1435 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
1436 after the loop to call ccl_driver at least once (Bug#8619).
1438 2011-12-08 Kenichi Handa <handa@m17n.org>
1440 * ftfont.c (get_adstyle_property): Fix previous change
1443 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
1445 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1446 dirs from the default value of EMACSLOADPATH (bug#10208).
1448 2011-12-07 Glenn Morris <rgm@gnu.org>
1450 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1451 installation and source directories as well. (Bug#10208)
1453 2011-12-06 Chong Yidong <cyd@gnu.org>
1455 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1457 2011-12-06 Glenn Morris <rgm@gnu.org>
1459 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1460 as an error, not just -1. (Bug#10217)
1462 2011-12-05 Chong Yidong <cyd@gnu.org>
1464 * keyboard.c (process_special_events): New function.
1465 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1467 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1469 * coding.c (encode_designation_at_bol): Don't use uninitialized
1470 local variable (Bug#9318).
1472 2011-12-05 Kenichi Handa <handa@m17n.org>
1474 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1475 return Qnil (Bug#8046, Bug#10193).
1477 2011-12-05 Kenichi Handa <handa@m17n.org>
1479 * coding.c (encode_designation_at_bol): New args charbuf_end and
1480 dst. Return the number of produced bytes. Callers changed.
1481 (coding_set_source): Return how many bytes coding->source was
1483 (coding_set_destination): Return how many bytes
1484 coding->destination was relocated.
1485 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1486 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1488 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1490 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1491 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1494 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1496 The following changes are to fix Bug#9318.
1498 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1499 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1500 (encode_coding_iso_2022, encode_coding_sjis)
1501 (encode_coding_big5, encode_coding_charset): Use the above macros.
1503 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1505 * lisp.h (process_quit_flag): Fix external declaration.
1507 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1509 Don't macro-inline non-performance-critical code.
1510 * eval.c (process_quit_flag): New function.
1511 * lisp.h (QUIT): Use it.
1513 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1515 * nsfns.m (get_geometry_from_preferences): New function.
1516 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1518 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1520 * emacs.c (Qkill_emacs): Define.
1521 (syms_of_emacs): Initialize it.
1522 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1523 Qquit_flag to `kill-emacs' instead.
1524 (quit_throw_to_read_char): Add parameter `from_signal'.
1525 All callers changed. Call Fkill_emacs if requested and safe.
1526 * lisp.h (QUIT): Call Fkill_emacs if requested.
1528 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1530 * widget.c (update_wm_hints): Return if wmshell is null.
1531 (widget_update_wm_size_hints): New function.
1533 * widget.h (widget_update_wm_size_hints): Declare.
1535 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1536 widget_update_wm_size_hints (Bug#10104).
1538 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1540 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1541 before a newline, prepare the bidi iterator for consuming the
1542 newline, and keep the current paragraph direction. (Bug#10183)
1543 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1545 2011-12-02 Juri Linkov <juri@jurta.org>
1547 * search.c (Fword_search_regexp): New Lisp function created from
1548 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1549 (Fword_search_backward, Fword_search_forward)
1550 (Fword_search_backward_lax, Fword_search_forward_lax):
1551 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1552 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1554 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1556 * fileio.c (Finsert_file_contents): Move after-change-function call
1557 to before the "handled:" label, since all "goto handled" appear in
1558 cases where the *-change-functions have already been properly called
1561 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1563 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1564 waiting for input. (Bug#10169)
1566 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1568 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1569 verifies glyph row's hash code--we have just reallocated the
1570 glyphs, so their contents can be complete garbage. (Bug#10164)
1572 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1574 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1576 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1578 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1579 attributes are tested _before_ calling verify_row_hash, to protect
1580 against GCC re-ordering of the tests. (Bug#10164)
1582 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1584 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1586 * xterm.c (handle_one_xevent): Only set async_visible and friends
1587 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1588 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1589 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1591 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1593 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1594 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1595 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1596 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1597 All uses changed to use GCPRO1 etc.
1598 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1599 Revert to old implementation (i.e., before 2011-03-11).
1601 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1603 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1604 of scroll runs so as to avoid assigning disabled bogus rows and
1605 unnecessary graphics copy operations.
1607 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1609 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1610 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1611 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1612 (malloc, free, realloc, calloc): Redirect to e_* only when
1615 * lisp.h (GCTYPEBITS): Move before first use.
1616 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1617 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1618 this macro definition.
1620 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1623 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1625 * gtkutil.c (xg_create_frame_widgets):
1626 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1627 present with Gtk+ 2.0.
1629 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1631 * fileio.c (Finsert_file_contents): Undo previous change; see
1632 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1634 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1636 Rename locals to avoid shadowing.
1637 * fileio.c (Finsert_file_contents):
1638 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1639 * process.c (wait_reading_process_output):
1640 Rename inner 'proc' to 'p' to avoid shadowing.
1641 Indent for consistency with usual Emacs style.
1643 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1645 * xdisp.c (redisplay_window): If cursor row is not fully visible
1646 after recentering, and scroll-conservatively is set to a large
1647 number, scroll window by a few more lines to make the cursor fully
1648 visible and out of scroll-margin. (Bug#10105)
1649 (start_display): Don't move to the next line if the display should
1650 start at a newline that is part of a display vector or an overlay
1653 2011-11-24 Juri Linkov <juri@jurta.org>
1655 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1656 after the `MagickPingImage' call. (Bug#10112)
1658 2011-11-23 Chong Yidong <cyd@gnu.org>
1660 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1662 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1664 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1665 making another buffer current. (Bug#10114)
1667 2011-11-23 Glenn Morris <rgm@gnu.org>
1669 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1671 2011-11-23 Chong Yidong <cyd@gnu.org>
1673 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1674 using it (Bug#5984).
1676 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1678 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1679 and header-lines, as they don't have one computed for them.
1682 * .gdbinit (prow): Make displayed values more self-explaining.
1683 Add row's hash code.
1685 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1687 * process.c (wait_reading_process_output): Fix asynchrounous
1688 GnuTLS socket handling on some versions of the GnuTLS library.
1689 (wait_reading_process_output): Add comment and URL.
1691 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1693 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1695 2011-11-21 Chong Yidong <cyd@gnu.org>
1697 * window.c (Fnext_window, Fprevious_window): Doc fix.
1699 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1701 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1703 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1705 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1707 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1709 * window.c (Fset_window_combination_limit): Rename argument
1711 (Vwindow_combination_limit): Remove "status" from doc-string.
1713 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1715 * m/ibms390.h: Remove.
1716 * m/ibms390x.h: Don't include "ibms390.h".
1718 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1720 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1721 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1723 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1725 * casetab.c (Fset_case_table):
1726 * charset.c (Fcharset_after): Fix typos.
1728 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1730 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1731 Otherwise, valgrind does not work on some platforms.
1732 Problem reported by Andreas Schwab in
1733 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1734 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1735 is set, removing the need for VIRT_ADDRESS_VARIES.
1736 (PURE_P): Use a more-efficient implementation that needs just one
1737 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1738 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1739 to 4 (xorl, subq, cmpq, setbe).
1740 * alloc.c (pure): Always extern now, since that's the
1741 VIRT_ADDR_VARIES behavior.
1742 (PURE_POINTER_P): Use a single comparison, not two, for
1743 consistency with the new puresize.h.
1744 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1745 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1746 Remove VIRT_ADDR_VARIES no longer needed.
1748 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1750 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1751 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1752 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1753 behave as if the cursor position were at the window margin.
1755 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1756 and the cursor position is out of bounds, behave as if the cursor
1757 position were at the window margin. (Bug#10075)
1759 2011-11-18 Chong Yidong <cyd@gnu.org>
1761 * window.c (Fwindow_combination_limit): Make first argument
1762 non-optional, since it is meaningless for live windows like the
1765 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1767 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1769 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1771 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1772 (graft_intervals_into_buffer): Simplify.
1774 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1776 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1777 hash values of the two rows.
1778 (copy_row_except_pointers): Preserve the used[] arrays and the
1779 hash values of the two rows. (Bug#10035)
1780 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1782 * xdisp.c (row_hash): New function, body extracted from
1783 compute_line_metrics.
1784 (compute_line_metrics): Call row_hash, instead of computing the
1787 * dispnew.c (verify_row_hash): Call row_hash for computing the
1788 hash code of a row, instead of duplicating code from xdisp.c.
1790 * dispextern.h (row_hash): Add prototype.
1792 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1794 * frame.c (delete_frame): Don't delete the terminal when the last
1795 X frame is closed if emacs is built with GTK toolkit.
1797 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1799 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1801 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1803 * window.c (Vwindow_splits): Rename to
1804 Vwindow_combination_resize. Suggested by Juri Linkov.
1805 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1808 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1810 * nsfns.m (Fns_font_name):
1811 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1813 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1815 * window.h (window): Rename slot "nest" to "combination_limit".
1816 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1817 (Fset_window_nest): Rename to Fset_window_combination_limit.
1818 (Vwindow_nest): Rename to Vwindow_combination_limit.
1819 (recombine_windows, make_parent_window, make_window)
1820 (Fsplit_window_internal, saved_window)
1821 (Fset_window_configuration, save_window_save): Rename all
1822 occurrences of window_nest to window_combination_limit.
1824 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1826 * image.c (imagemagick_load_image): Fix typo.
1828 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1830 * xdisp.c (display_line): Move the call to
1831 highlight_trailing_whitespace before the call to
1832 compute_line_metrics, since the latter needs to see the final
1833 faces of all the glyphs to compute ROW's hash value.
1834 Fixes assertion violations in row_equal_p. (Bug#10035)
1836 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1838 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1839 just return (bug#10044).
1841 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1843 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1844 with user-defined heap size. Bump the default size of the temacs
1845 heap to 27MB, to avoid memory warning when running temacs.
1846 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1848 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1849 current_matrix and desired_matrix. (Bug#9990)
1850 (verify_row_hash) [XASSERTS]: New function.
1851 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1852 that the hash value of glyph rows is correct.
1854 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1856 * window.h (window): Remove splits slot.
1857 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1858 (Fdelete_other_windows_internal, make_parent_window)
1859 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1860 (Fset_window_configuration, save_window_save): Don't deal with
1861 split status of windows.
1862 (saved_window): Remove splits slot.
1863 (Vwindow_splits): Rewrite doc-string.
1865 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1867 * xfns.c (unwind_create_frame):
1868 * nsfns.m (unwind_create_frame):
1869 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1870 Vframe_list (Bug#9999).
1872 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1874 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1876 2011-11-11 Kenichi Handa <handa@m17n.org>
1878 * callproc.c (Fcall_process): Set the member dst_multibyte of
1881 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1883 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1884 avoid a crash (bug#9496).
1886 2011-11-09 Chong Yidong <cyd@gnu.org>
1888 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1889 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1891 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1893 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1895 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1897 Avoid some portability problems by eschewing 'extern inline' functions.
1898 The trivial performance wins aren't worth the portability hassles; see
1899 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1901 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1902 (window_box_width, window_box_left, window_box_left_offset)
1903 (window_box_right, window_box_right_offset): Undo previous change,
1904 by removing the "extern"s.
1905 * intervals.c (adjust_intervals_for_insertion)
1906 (adjust_intervals_for_deletion): Undo previous change,
1907 making these static again.
1908 (offset_intervals, temp_set_point_both, temp_set_point)
1909 (copy_intervals_to_string): No longer inline.
1910 * xdisp.c (window_text_bottom_y, window_box_width)
1911 (window_box_height, window_box_left_offset)
1912 (window_box_right_offset, window_box_left, window_box_right)
1913 (window_box): No longer inline.
1915 2011-11-08 Chong Yidong <cyd@gnu.org>
1917 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1918 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1919 Signal an error if not a live window.
1920 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1921 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1923 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1925 * lisp.h (syms_of_abbrev): Remove declaration.
1926 Reported by CHENG Gao <chenggao@royau.me>.
1928 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1930 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1931 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1932 of temacs in GUI mode.
1934 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1936 * window.h: Declare delete_all_child_windows instead of
1937 delete_all_subwindows.
1938 * window.c (Fwindow_nest, Fset_window_nest)
1939 (Fset_window_new_total, Fset_window_new_normal)
1940 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1941 (delete_all_subwindows): Rename to delete_all_child_windows.
1942 (Fdelete_other_windows_internal, Fset_window_configuration):
1943 Call delete_all_child_windows instead of delete_all_subwindows.
1944 * frame.c (delete_frame): Call delete_all_child_windows instead
1945 of delete_all_subwindows.
1947 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1949 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1950 This is also needed for porting to any host where GC_MARK_STACK is
1951 not GC_MAKE_GCPROS_NOOPS.
1952 (which_symbols): Use it.
1954 2011-11-07 Kenichi Handa <handa@m17n.org>
1956 * coding.c (coding_set_destination): Check coding->src_pos only
1957 when coding->src_object is a buffer (bug#9910).
1959 * process.c (send_process): Set the member src_multibyte of coding
1960 to 0 (bug#9911) when sending a unibyte text.
1962 * callproc.c (Fcall_process): Set the member src_multibyte of
1963 process_coding to 0 (bug#9912).
1965 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1967 * xmenu.c (cleanup_widget_value_tree): New function.
1968 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1969 calling free_menubar_widget_value_tree directly (Bug#9830).
1971 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1973 Fix some portability problems with 'inline'.
1974 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1975 (window_box_width, window_box_left, window_box_left_offset)
1976 (window_box_right, window_box_right_offset): Declare extern.
1977 Otherwise, these inline functions do not conform to C99 and
1978 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1979 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1980 * intervals.c (adjust_intervals_for_insertion)
1981 (adjust_intervals_for_deletion): Now extern, because otherwise the
1982 extern inline functions 'offset_intervals' couldn't refer to it.
1983 (static_offset_intervals): Remove.
1984 (offset_intervals): Rewrite using the old contents of
1985 static_offset_intervals. The old version didn't conform to C99
1986 because an extern inline function contained a reference to an
1987 identifier with static linkage.
1989 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1991 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1994 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1996 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1997 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1998 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1999 return Qleft_to_right.
2001 2011-11-06 Chong Yidong <cyd@gnu.org>
2003 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
2004 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
2005 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
2006 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
2007 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
2008 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
2009 (Fwindow_vscroll): Doc fix.
2010 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
2011 argument, since it makes no sense to pass a live window and for
2012 consistency with window-child.
2014 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
2016 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
2019 2011-11-05 Jason Rumney <jasonr@gnu.org>
2021 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
2022 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
2024 (add_font_entity_to_list): Fix logic errors in mixed boolean and
2025 bitwise arithmetic preventing use of unicode-sip and non-truetype
2028 2011-11-05 Eli Zaretskii <eliz@gnu.org>
2030 * s/ms-w32.h (fstat, stat, utime): Move redirections to
2033 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
2034 initialization code to keep similarity to xfns.c after changes
2037 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
2039 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
2040 (unwind_create_frame): New function (Bug#9943).
2041 (Fx_create_frame): Restructure code to be more similar to the one in
2042 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
2043 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
2044 Move terminal->reference_count++ just before making the frame official
2047 * nsterm.m (x_free_frame_resources): New function.
2048 (x_destroy_window): Move code to x_free_frame_resources.
2050 * xfns.c (unwind_create_frame): Fix comment.
2051 (Fx_create_frame, x_create_tip_frame):
2052 Move terminal->reference_count++ just before making the frame
2053 official. Move initialization of image_cache_refcount and
2054 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
2056 2011-11-05 Eli Zaretskii <eliz@gnu.org>
2058 Support MSVC build with newer versions of Visual Studio.
2059 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
2060 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
2063 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
2064 which are not supported by MSVC.
2065 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
2066 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
2068 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
2070 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
2072 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
2074 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
2076 Support MSVC build with newer versions of Visual Studio.
2077 * w32.c: Don't include w32api.h for MSVC.
2078 (init_environment) [_MSC_VER]: Call sys_access, not _access.
2080 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
2081 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
2082 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
2083 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
2085 (alloca) [_MSC_VER]: Define to _alloca.
2087 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
2089 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
2091 2011-11-04 Eli Zaretskii <eliz@gnu.org>
2093 * xdisp.c (note_mouse_highlight): If either of
2094 previous/next-single-property-change returns nil, treat that as
2095 the beginning or the end of the buffer. (Bug#9955)
2097 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
2099 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
2100 label is not null (Bug#9951).
2101 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
2104 2011-11-04 Eli Zaretskii <eliz@gnu.org>
2106 * window.c (Fwindow_body_size): Mention in the doc string that the
2107 return value is in frame's canonical units. (Bug#9949)
2109 2011-11-03 Eli Zaretskii <eliz@gnu.org>
2111 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
2113 * w32fns.c (unwind_create_frame): If needed, free the glyph
2114 matrices of the partially constructed frame. (Bug#9943)
2115 * xfns.c (unwind_create_frame): Likewise.
2117 2011-11-01 Eli Zaretskii <eliz@gnu.org>
2119 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
2120 Don't stop backward scan on the continuation glyph, even though
2121 its CHARPOS is positive.
2122 (mouse_face_from_buffer_pos, note_mouse_highlight):
2123 Rename cover_string to disp_string.
2125 2011-11-01 Martin Rudalics <rudalics@gmx.at>
2127 * window.c (temp_output_buffer_show): Don't use
2128 Vtemp_buffer_show_specifiers.
2129 (Vtemp_buffer_show_specifiers): Remove unused variable.
2131 2011-10-30 Eli Zaretskii <eliz@gnu.org>
2133 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
2134 past the beginning of the current glyph matrix.
2136 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
2138 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
2139 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
2140 HAVE_GTK3 (Bug#9869).
2142 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
2143 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
2145 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
2147 * xterm.c: Declare x_handle_net_wm_state to return int.
2148 (handle_one_xevent): Check if we are iconified but don't have
2149 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
2150 (get_current_wm_state): Return non-zero if not hidden,
2151 check for _NET_WM_STATE_HIDDEN (Bug#9893).
2152 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
2153 (x_handle_net_wm_state): Return what get_current_wm_state returns.
2154 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
2156 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
2158 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
2159 so that this new function doesn't get optimized away by a
2160 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
2162 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2164 * frame.h (MOUSE_HL_INFO): Remove excess parens.
2166 2011-10-29 Eli Zaretskii <eliz@gnu.org>
2168 Fix the `xbytecode' command.
2169 * .gdbinit (xprintbytestr): New command.
2170 (xwhichsymbols): Rename from `which'; all callers changed.
2171 (xbytecode): Print the byte-code string as well.
2173 2011-10-29 Kim Storm <storm@cua.dk>
2175 * alloc.c (which_symbols): New function.
2177 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2179 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
2182 2011-10-29 Glenn Morris <rgm@gnu.org>
2184 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
2185 Not clear what it was for, and it causes various bugs. (Bug#9839)
2187 2011-10-28 Eli Zaretskii <eliz@gnu.org>
2189 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
2190 possible random value that matches one of those tested as
2191 condition to clear the mouse face.
2193 2011-10-28 Chong Yidong <cyd@gnu.org>
2195 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
2197 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
2199 * window.c (make_window): Initialize phys_cursor_on_p.
2201 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
2203 * lisp.h (struct Lisp_Symbol): Update comments.
2205 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
2207 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
2209 2011-10-28 Eli Zaretskii <eliz@gnu.org>
2211 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
2212 <oslsachem@gmail.com> for helping to debug this.
2214 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
2215 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
2216 (g_b_init_get_glyph_outline_w): New static variables.
2217 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
2218 (GetGlyphOutlineW_Proc): New typedefs.
2219 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
2220 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
2222 (w32font_open_internal, compute_metrics):
2223 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
2224 instead of calling the "wide" APIs directly.
2226 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
2228 * w32.h (syms_of_w32font): Add prototype.
2230 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
2232 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
2233 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
2234 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
2235 (Fmove_to_window_line): Doc fix.
2237 2011-10-27 Chong Yidong <cyd@gnu.org>
2239 * process.c (make_process): Set gnutls_state to NULL.
2241 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
2242 non-NULL, regardless of GNUTLS_INITSTAGE.
2243 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
2244 an error. Set process slots as soon as we allocate them.
2246 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
2248 2011-10-27 Chong Yidong <cyd@gnu.org>
2250 * gnutls.c (emacs_gnutls_deinit): New function.
2251 Deallocate credentials structures as well as calling gnutls_deinit.
2252 (Fgnutls_deinit, Fgnutls_boot): Use it.
2254 * process.c (make_process): Initialize GnuTLS credentials to NULL.
2255 (deactivate_process): Call emacs_gnutls_deinit.
2257 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
2259 * image.c (x_create_x_image_and_pixmap):
2260 * w32.c (sys_rename, w32_delayed_load):
2261 * w32font.c (fill_in_logfont):
2262 * w32reg.c (x_get_string_resource): Silence compiler warnings.
2264 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
2266 * w32fns.c (w32_default_color_map): New function,
2267 extracted from Fw32_default_color_map.
2268 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
2270 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
2272 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
2274 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
2276 * keyboard.c (test_undefined): New function (bug#9751).
2277 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
2279 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
2281 * sysdep.c (init_sys_modes): Fix the check for the controlling
2282 terminal (Bug#6649).
2284 2011-10-20 Eli Zaretskii <eliz@gnu.org>
2286 * dispextern.h (struct bidi_it): New member next_en_type.
2288 * bidi.c (bidi_line_init): Initialize the next_en_type member.
2289 (bidi_resolve_explicit_1): When next_en_pos is valid for the
2290 current character, check also for next_en_type being WEAK_EN.
2291 (bidi_resolve_weak): Don't enter the expensive loop if the current
2292 position is before next_en_pos. Record the bidi type of the first
2293 non-ET, non-BN character we find, in addition to its position.
2294 (bidi_level_of_next_char): Invalidate next_en_type when
2295 next_en_pos is over-stepped.
2297 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
2299 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
2300 * editfns.c: Rewrite current-time-zone so that it invokes
2301 the equivalent of (format-time-string "%Z") to get the time zone name.
2302 This fixes a bug when the time zone name contains characters that
2303 need converting from the system time locale to Emacs internal format.
2304 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
2305 that patch fixed format-time-string to do the conversion, but
2306 I forgot to fix current-time-zone.
2307 (format_time_string): New function, containing most of
2308 what Fformat_time_string used to contain.
2309 (Fformat_time_string): Rewrite in terms of format_time_string.
2310 This doesn't change this function's behavior.
2311 (current-time-zone): Rewrite to use format_time_string.
2312 This fixes the bug reported by Michael Schierl in
2313 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
2314 Jason Rumney's 2007-06-07 change worked around this bug, but
2316 * systime.h (tzname, timezone): Remove no-longer-used declarations.
2318 2011-10-19 Eli Zaretskii <eliz@gnu.org>
2320 * xdisp.c (start_display): If the character at POS is displayed
2321 via a display vector, reset IT->current.dpvec_index to zero.
2322 (try_window_reusing_current_matrix): If a line ends in a display
2323 vector or the next line starts in a display vector, continue
2324 redrawing the window even though the character position of
2325 start_row was reached.
2328 2011-10-18 Chong Yidong <cyd@gnu.org>
2330 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2331 with nobreak-char-display too.
2333 2011-10-18 Eli Zaretskii <eliz@gnu.org>
2335 Fix part 3 of bug#9771.
2336 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2337 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2338 non-neutral characters if the current character is a paragraph
2339 separator (a.k.a. Newline). This avoids running the same
2340 expensive loop twice, once when we consume the preceding newline
2341 and the other time when the line actually needs to be displayed.
2342 Avoid the loop when we see neutrals on the base embedding level
2343 following a character whose directionality is the same as the
2344 paragraph's. This avoids running the expensive loop when a line
2345 ends in a long sequence of neutrals, like control characters.
2346 Add assertion against STRONG_AL type. Slightly rearrange code
2347 that determines the type of a neutral given the first non-neutral
2349 (bidi_level_of_next_char): Set next_en_pos to zero when
2350 invalidating its info.
2352 2011-10-17 Eli Zaretskii <eliz@gnu.org>
2354 * xdisp.c (push_display_prop): Determine whether to record string
2355 or buffer position by IT->string, not by IT->method. Allow
2356 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
2357 (move_it_vertically_backward): Don't look for character position
2358 immediately after the newline when in a continuation line.
2361 2011-10-15 Martin Rudalics <rudalics@gmx.at>
2363 * window.c (coordinates_in_window): Rewrite and delabelize
2364 vertical border check. (Bug#5357) (Bug#9618)
2366 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2368 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2369 errors in XSetWindowBorder (bug#9310).
2371 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2373 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2374 avoid crash when xmalloc overrun checking is enabled.
2376 2011-10-13 Eli Zaretskii <eliz@gnu.org>
2378 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2379 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2380 cursor motion with <left> and <right> arrow keys.
2382 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2383 some callers set that themselves.
2385 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2387 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2388 display string and the previous row comes from the same string and
2389 is empty. (Bug#9739) (Bug#9738)
2391 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2393 * doc.c (get_doc_string): Encode file name (bug#9735).
2395 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2397 * bidi.c (bidi_level_of_next_char):
2398 * xdisp.c (get_visually_first_element): Remove old incorrect
2399 comments regarding the Unicode Line Separator character.
2401 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2403 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2405 * alloc.c (Fgc_status): Do not access beyond zombies array
2406 boundary if nzombies > MAX_ZOMBIES.
2407 * alloc.c (dump_zombies): Add missing format specifier.
2409 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2411 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2412 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2414 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2415 Some packages use them to denote characters with modifiers.
2417 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2419 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2420 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2421 matching a pp-number. Rename parameter var to var1.
2423 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2425 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2427 2011-10-08 Glenn Morris <rgm@gnu.org>
2429 * callint.c (Fcall_interactively): Give a more explicit error for the
2430 'c' case with a non-character input. (Bug#8479)
2432 2011-10-08 Eli Zaretskii <eliz@gnu.org>
2434 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2436 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2437 lines that are hscrolled on the left.
2439 * dispnew.c (buffer_posn_from_coords): Account for a possible
2440 presence of header-line. (Bug#4426)
2442 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2444 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2445 Don't advertise functionality which we discourage or doesn't work.
2447 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2449 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2450 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2451 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2452 this makes Emacs dump core during garbage collection on rare
2453 occasions. sizeof is obviously inferior to offsetof here, so
2454 stick with offsetof.
2455 (GC_POINTER_ALIGNMENT): New macro.
2456 (mark_memory): Omit 3rd (offset) arg; caller changed.
2457 Don't assume EMACS_INT alignment is the same as pointer alignment.
2459 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2461 * keyboard.c (read_key_sequence_remapped): New var.
2462 (read_key_sequence): Compute remapping in the right buffer.
2463 (command_loop_1): Use read_key_sequence's remapping directly.
2465 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2467 * dired.c (file_name_completion): Don't expand file name.
2468 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2469 before checking file name handler.
2471 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2472 they've been requested explicitly (bug#9591).
2474 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
2476 * keymap.c (Fsingle_key_description): Use make_specified_string
2477 instead of build_string to build string from push_key_description.
2480 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2482 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2483 This fixes a Y2038 bug on 64-bit hosts.
2484 * buffer.c (reset_buffer):
2485 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2486 (Fclear_buffer_auto_save_failure):
2487 Use 0, not -1, to represent an unset failure time, since time_t
2488 might not be signed.
2490 Remove dependency on glibc malloc internals.
2491 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2492 Move back here from lisp.h, but with their new implementations.
2493 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2494 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2495 * charset.c (charset_table_init): New static var.
2496 (syms_of_charset): Use it instead of xmalloc. This removes a
2497 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2498 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2499 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2500 Move back to alloc.c.
2501 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2502 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2504 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2506 * nsterm.m (windowDidResize): Call x_set_window_size only when
2507 ns_in_resize is true. Otherwise set pixelwidth/height and
2508 call change_frame_size (Bug#9628).
2510 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2512 Port --enable-checking=all to Fedora 14 x86-64.
2513 * charset.c (syms_of_charset): Also account for glibc malloc's
2514 internal overhead when calculating the initial malloc maximum.
2516 Port --enable-checking=all to Fedora 14 x86.
2517 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2519 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2520 (overrun_check_realloc, overrun_check_free):
2521 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2522 That way, xmalloc returns a properly-aligned pointer even if
2523 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2524 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2525 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2526 into account when calculating the initial malloc maximum.
2527 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2528 Move here from alloc.c, so that charset.c can use it too.
2529 Properly align; the old code wasn't right for common 32-bit hosts
2530 when configured with --enable-checking=all.
2531 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2532 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2534 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2536 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2539 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2541 * xdisp.c (compute_display_string_end): If there's no display
2542 string at CHARPOS, return -1.
2544 * bidi.c (bidi_fetch_char): When compute_display_string_end
2545 returns a negative value, treat the character as a normal
2546 character not covered by a display string. (Bug#9624)
2548 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2550 * lread.c (Fread_from_string): Fix typo in docstring.
2552 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2554 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2555 newline, reseat the iterator instead of bidi-iterating there one
2556 character at a time. (Bug#9610)
2557 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2558 TO_CHARPOS if the bidi iterator is at base embedding level.
2560 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2562 * lread.c (readevalloop): Use correct code for NBSP.
2563 (read1): Likewise. (Bug#9608)
2565 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2567 * dbusbind.c (Fdbus_register_signal): When service is not
2568 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2570 2011-09-25 Glenn Morris <rgm@gnu.org>
2572 * buffer.c (truncate-lines): Doc fix.
2574 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2576 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2577 (Fset_window_next_buffers): Doc fix.
2579 2011-09-24 Glenn Morris <rgm@gnu.org>
2581 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2583 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2585 Fix minor problems found by static checking.
2586 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2587 * indent.c (Fvertical_motion): Fix == vs = typo.
2589 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2591 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2592 Default value is now t. Doc fix.
2594 * indent.c (Fvertical_motion): Compute and apply the overshoot
2595 logic when moving up, not only when moving down. Fix the
2596 confusing name and values of the it_overshoot_expected variable;
2597 logic changes accordingly. (Bug#9254) (Bug#9549)
2599 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2600 CHARPOS is covered by a display string which includes newlines.
2601 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2602 is covered by a display string with embedded newlines.
2604 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2606 * dbusbind.c (Fdbus_register_signal): Add match rule to
2607 Vdbus_registered_objects_table. (Bug#9581)
2608 (Fdbus_register_method, Vdbus_registered_objects_table):
2611 2011-09-24 Jim Meyering <meyering@redhat.com>
2613 do not ignore write error for any output size
2614 The previous change was incomplete.
2615 While it makes emacs --batch detect the vast majority of stdout
2616 write failures, errors were still ignored whenever the output size is
2617 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2618 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2619 && echo FAIL: ignored write error
2620 FAIL: ignored write error
2621 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2622 && echo FAIL: ignored write error
2623 FAIL: ignored write error
2624 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2626 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2628 * emacs.c (Fkill_emacs): In noninteractive mode exit
2629 non-successfully if a write error occurred on stdout. (Bug#9574)
2631 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2633 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2636 * dispextern.h (struct it): Update the comment documenting what
2639 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2641 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2642 a display string, extend search for cursor position to end of row.
2643 (find_row_edges): If the row ends in a newline from a display
2644 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2645 Handle the case of a display string with multiple newlines.
2646 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2647 non-empty line. Fixes confusing cursor motion with arrow keys at
2648 the beginning of a line that starts with whitespace.
2650 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2652 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2655 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2657 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2660 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2662 * xdisp.c (display_line): Record maximum and minimum buffer
2663 positions even if no glyphs were produced (e.g., by a zero-width
2664 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2665 buffer positions that will be removed from the glyph row because
2667 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2668 column is beyond frame width: don't subtract 1 "pixel" when
2669 computing width of the stretch.
2670 (reseat_at_next_visible_line_start): Undo the change made on
2671 2011-09-17 that saved paragraph information and restored it after
2672 the call to `reseat'. (Bug#9545)
2674 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2676 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2677 and turn window cursor on if cleared (Bug#9415).
2679 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2681 * search.c (boyer_moore): Take unibyte characters from pattern
2682 literally. (Bug#9458)
2684 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2686 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2688 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2690 Fix minor problem found by static checking.
2691 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2692 initialized, to pacify gcc -Wuninitialized.
2694 * fileio.c: Report proper errno when syscall falls.
2695 (Finsert_file_contents): Save and restore errno,
2696 so that report_file_error outputs the correct diagnostic.
2697 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2699 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2701 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2703 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2705 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2706 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2708 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2710 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2711 about the current paragraph and restore it after the call to reseat.
2713 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2714 (bidi_find_paragraph_start): Search back for paragraph beginning
2715 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2716 (bidi_move_to_visually_next): Only trigger paragraph-related
2717 computations when the last character is a newline or at EOB, not
2718 just any NEUTRAL_B. (Bug#9470)
2720 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2721 truncated lines if point is covered by a display string. (Bug#9524)
2723 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2725 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2726 (cons_to_x_long): New function.
2727 (lisp_data_to_selection_data): Use it. Correct the test for
2728 short-versus-long data; it was negated. Break out of vector
2729 loop, for efficiency, when a long datum is discovered.
2731 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2733 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2735 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2737 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2738 GCC PR/17406) by declaring this function with external scope.
2740 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2742 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2743 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2745 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2747 * editfns.c (Fformat): Correctly handle text properties on "%%".
2749 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2751 * xterm.c (x_draw_composite_glyph_string_foreground):
2752 * w32term.c (x_draw_composite_glyph_string_foreground):
2753 * term.c (encode_terminal_code):
2754 * composite.c (composition_update_it, get_composition_id):
2755 * xdisp.c (get_next_display_element)
2756 (fill_composite_glyph_string): Add comments about special meaning
2757 of TAB characters in a composition.
2759 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2761 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2762 This occurs when processing a multibyte format.
2763 Problem reported by Wolfgang Jenker.
2765 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2767 * xdisp.c (try_cursor_movement): Only check for exact match if
2768 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2770 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2772 Remove unused external symbols.
2773 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2774 * xdisp.c (calc_pixel_width_or_height): Now static.
2775 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2776 * indent.c (check_display_width):
2777 * w32term.c: Fix comment to match code.
2778 * xterm.c, xterm.h (x_catching_errors): Remove.
2780 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2782 * xselect.c: Use signed conversions more consistently (Bug#9498).
2783 (selection_data_to_lisp_data): Assume incoming selection data are
2784 signed integers, not unsigned. This is to be consistent with
2785 outgoing selection data, which was modified to use signed integers
2786 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2787 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2788 expects long, not unsigned long.
2790 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2792 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2793 computation of loop end. Reported by Johan Bockgård
2796 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2798 * frame.c (Fother_visible_frames_p): Function deleted.
2800 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2802 * indent.c (compute_motion): Process display vector front to back
2803 rather than the other way around. (Bug#2496)
2805 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2807 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2809 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2811 * minibuf.c (Fread_from_minibuffer): Doc fix.
2813 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2815 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2816 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2818 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2820 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2821 value for non-existent files.
2823 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2825 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2826 set its "size" to -1. This will set the modtime_size field of
2827 the corresponding buffer to -1, which is what
2828 verify-visited-file-modtime expects for files that do not exist.
2831 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2833 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2835 * lisp.h: ... from here. push_key_description is no longer
2836 defined in keyboard.c, so its declaration should not be in
2837 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2838 logically belongs with push_key_description.
2840 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2842 * buffer.h: Include <sys/types.h> instead of <time.h>.
2843 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2844 Problem reported by Herbert J. Skuhra.
2846 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2848 * xml.c (parse_region): Make the parsing work for
2849 non-comment-starting XML files again (bug#9144).
2851 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2853 * image.c (gif_load): Fix calculation of bottom and right corner.
2856 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2858 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2859 redisplay in small windows.
2861 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2863 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2865 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2867 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2868 Operate on live windows only.
2870 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2872 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2874 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2876 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2877 only under bidi iteration.
2879 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2881 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2883 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2885 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2886 Without this fix, the command to link temacs failed due to an
2887 undefined symbol __builtin_isnan. This is because
2888 /usr/include/iso/math_c99.h #defines isnan(x) to
2889 __builtin_isnan(x), but the bundled gcc, which identifies itself
2890 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2892 * floatfns.c (isnan): #undef, and then #define to a clone of
2894 (Fisnan): Always define, since it's always available now.
2895 (syms_of_floatfns): Always define isnan at the Lisp level.
2897 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2899 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2901 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2903 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2904 The previous code assumed that file offsets (off_t values) fit in
2905 EMACS_INT variables, which is not true on typical 32-bit hosts.
2906 The code messed up by falsely reporting buffer overflow in cases
2907 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2908 when "big" contains more than 2**29 bytes, even though this
2909 inserts just one byte and does not overflow the buffer.
2910 (Finsert_file_contents): Store file offsets as off_t
2911 values, not as EMACS_INT values. Check for overflow when
2912 converting between EMACS_INT and off_t. When checking for
2913 buffer overflow or for overlap, take the offsets into account.
2914 Don't use EMACS_INT for small values where int suffices.
2915 When checking for overlap, fix a typo: ZV was used where
2916 ZV_BYTE was intended.
2917 (Fwrite_region): Don't assume off_t fits into 'long'.
2918 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2920 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2922 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2924 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2926 sprintf-related integer and memory overflow issues (Bug#9412).
2928 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2929 (esprintf, exprintf, evxprintf): New functions.
2930 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2931 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2932 (modify_event_symbol): Do not assume that the length of
2933 name_alist_or_stem is safe to alloca and fits in int.
2934 (Fexecute_extended_command): Likewise for function name and binding.
2935 (Frecursion_depth): Wrap around reliably on integer overflow.
2936 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2937 since some callers pass EMACS_INT values.
2938 (Fsingle_key_description): Don't crash if symbol name contains more
2939 than MAX_ALLOCA bytes.
2940 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2941 (get_minibuffer): Arg is now EMACS_INT, not int.
2942 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2943 (esprintf, exprintf, evxprintf): New decls.
2944 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2946 * dbusbind.c (signature_cat): New function.
2947 (xd_signature, Fdbus_register_signal):
2948 Do not overrun buffer; instead, report string overflow.
2950 * dispnew.c (add_window_display_history): Don't overrun buffer.
2951 Truncate instead; this is OK since it's just a log.
2953 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2954 even if the time zone offset is outlandishly large.
2955 Don't mishandle offset == INT_MIN.
2957 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2958 when creating daemon; the previous buffer-overflow check was incorrect.
2960 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2961 which has the guts of the old verror function.
2963 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2964 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2966 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2967 (font_unparse_xlfd): Don't blindly alloca long strings.
2968 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2969 fits in int, when using sprintf. Use single snprintf to count
2970 length of string rather than counting it via multiple sprintfs;
2971 that's simpler and more reliable.
2972 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2973 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2974 sprintf, in case result does not fit in int.
2976 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2977 (fontset_from_font): Print it.
2979 * frame.c (tty_frame_count): Now printmax_t, not int.
2980 (make_terminal_frame, set_term_frame_name): Print it.
2981 (x_report_frame_params): In X, window IDs are unsigned long,
2982 not signed long, so print them as unsigned.
2983 (validate_x_resource_name): Check for implausibly long names,
2984 and don't assume name length fits in 'int'.
2985 (x_get_resource_string): Don't blindly alloca invocation name;
2986 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2989 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2990 (xg_check_special_colors, xg_set_geometry):
2991 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2993 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2994 Use esprintf, not sprintf, in case result does not fit in int.
2996 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2997 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2998 it as a large positive number.
2999 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
3000 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
3002 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
3003 in case result does not fit in int.
3005 * print.c (float_to_string): Detect width overflow more reliably.
3006 (print_object): Make sprintf buffer a bit bigger, to avoid potential
3007 buffer overrun. Don't assume list length fits in 'int'. Treat
3008 print length of 0 as 0, not as infinity; to be consistent with other
3009 uses of print length in this function. Don't overflow print length
3010 index. Don't assume hash table size fits in 'long', or that
3011 vectorlike size fits in 'unsigned long'.
3013 * process.c (make_process): Use printmax_t, not int, to format
3014 process-name gensyms.
3016 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
3018 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
3019 to avoid potential buffer overrun.
3021 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
3022 if X resource line is longer than 512 bytes.
3024 * xfns.c (x_window): Make sprintf buffer a bit bigger
3025 to avoid potential buffer overrun.
3027 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
3029 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
3031 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
3033 Integer overflow fixes for scrolling, etc.
3034 Without these, Emacs silently mishandles large integers sometimes.
3035 For example, "C-u 4294967297 M-x recenter" was treated as if
3036 it were "C-u 1 M-x recenter" on a typical 64-bit host.
3038 * xdisp.c (try_window_id): Check Emacs fixnum range before
3039 converting to 'int'.
3041 * window.c (window_scroll_line_based, Frecenter):
3042 Check that an Emacs fixnum is in range before assigning it to 'int'.
3043 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
3044 values converted from Emacs fixnums.
3045 (Frecenter): Don't wrap around a line count if it is out of 'int'
3046 range; instead, treat it as an extreme value.
3047 (Fset_window_configuration, compare_window_configurations):
3048 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
3050 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
3051 that can exceed INT_MAX. Check that EMACS_INT value is in range
3052 before assigning it to the (possibly-narrower) index.
3053 (match_limit): Don't assume that a fixnum can fit in 'int'.
3055 * print.c (print_object): Use ptrdiff_t, not int, for index that can
3058 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3059 (Fvertical_motion): Don't wrap around LINES values that don't fit
3060 in 'int'. Instead, treat them as extreme values. This is good
3061 enough for windows, which can't have more than INT_MAX lines anyway.
3063 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3065 * Require libxml/parser.h to avoid compilation warning.
3067 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
3069 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
3070 since this reportedly can destroy thread storage.
3072 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
3074 * syntax.c (find_defun_start): Update all cache variables if
3075 exiting early (Bug#9401).
3077 2011-08-30 Eli Zaretskii <eliz@gnu.org>
3079 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
3081 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
3082 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
3083 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
3085 * term.c (tty_append_glyph): New function.
3086 (produce_stretch_glyph): Static function and its prototype deleted.
3088 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
3091 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
3093 * image.c (parse_image_spec): Check for nonnegative, not for positive,
3094 when checking :margin (Bug#9390).
3095 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
3096 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
3097 so that the name doesn't mislead. All uses changed.
3099 2011-08-28 Johan Bockgård <bojohan@gnu.org>
3101 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
3104 2011-08-27 Eli Zaretskii <eliz@gnu.org>
3106 * xdisp.c (move_it_to): Don't bail out early when reaching
3107 position beyond to_charpos, if we are scanning backwards.
3108 (move_it_vertically_backward): When DY == 0, make sure we get to
3109 the first character in the line after the newline.
3111 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
3113 * ccl.c: Improve and simplify overflow checking (Bug#9196).
3114 (ccl_driver): Do not generate an out-of-range pointer.
3115 (Fccl_execute_on_string): Remove unnecessary check for
3116 integer overflow, noted by Stefan Monnier in
3117 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
3118 Remove a FIXME that didn't need fixing.
3119 Simplify the newly-introduced buffer reallocation code.
3121 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
3123 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
3125 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
3127 Integer and memory overflow issues (Bug#9196).
3129 * doc.c (get_doc_string): Rework so that
3130 get_doc_string_buffer_size is the actual buffer size, rather than
3131 being 1 less than the actual buffer size; this makes xpalloc more
3134 * image.c (x_allocate_bitmap_record, cache_image):
3135 * xselect.c (Fx_register_dnd_atom):
3136 Simplify previous changes by using xpalloc.
3138 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
3139 since either will do and ptrdiff_t is convenient with xpalloc.
3141 * charset.c (charset_table_size)
3142 (struct charset_sort_data.priority): Now ptrdiff_t.
3143 (charset_compare): Don't overflow if priorities differ greatly.
3144 (Fsort_charsets): Don't assume list length fits in int.
3145 Check for size-calculation overflow when allocating sort data.
3146 (syms_of_charset): Allocate an initial charset table that is
3147 just under 64 KiB, to avoid problems with glibc malloc and mmap.
3149 * cmds.c (internal_self_insert): Check for size-calculation overflow.
3151 * composite.h (struct composition.glyph_len): Now int, not unsigned.
3152 The actual value is always <= INT_MAX, and leaving it unsigned made
3153 overflow checking harder.
3155 * dispextern.h (struct glyph_matrix.rows_allocated)
3156 (struct face_cache.size): Now ptrdiff_t, for convenience in use
3157 with xpalloc. The values are still always <= INT_MAX.
3159 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
3161 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
3162 (SAFE_NALLOCA): New macro.
3164 * region-cache.c (struct boundary.pos, find_cache_boundary)
3165 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
3166 (set_cache_region, invalidate_region_cache)
3167 (revalidate_region_cache, know_region_cache, region_cache_forward)
3168 (region_cache_backward, pp_cache):
3169 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
3170 so that ptrdiff_t * can be passed to xpalloc.
3171 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
3172 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
3173 (pp_cache): Don't assume cache_len fits in int.
3174 * region-cache.h: Adjust extern decls to match.
3176 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
3177 EMACS_INT, since either will do, for xpalloc.
3179 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
3180 (xnmalloc, xnrealloc, xpalloc): New functions.
3182 * bidi.c (bidi_shelve_header_size): New constant.
3183 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
3184 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
3186 * bidi.c (bidi_cache_shrink):
3187 * buffer.c (overlays_at, overlays_in, record_overlay_string)
3189 Don't update size of array until after memory allocation succeeds,
3190 because xmalloc/xrealloc may not return.
3191 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
3192 now that we have proper integer overflow checking.
3193 (record_overlay_string, overlay_strings): Catch overflows when
3194 calculating size of overlay_str_buf.
3196 * callproc.c (Fcall_process): Check for size overflow when
3197 calculating size of args2.
3198 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
3199 Normally we prefer signed values, but sticking with ptrdiff_t would
3200 require adding more-complicated checks.
3202 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
3203 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
3204 Redo buffer-overflow calculations to avoid integer overflow.
3205 Add a FIXME comment where memory seems to be over-allocated.
3207 * character.c (Fstring): Check for size-calculation overflow.
3209 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
3210 unnecessary integer overflow. Check for size overflow.
3211 (encode_coding_object): Don't update size until xmalloc succeeds.
3213 * composite.c (get_composition_id): Check for overflow in glyph
3214 length calculations.
3216 Integer and memory overflow fixes for display code.
3217 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
3218 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
3219 (scrolling_window): Check for overflow in size calculations.
3220 (line_draw_cost, realloc_glyph_pool, add_row_entry):
3221 Don't assume glyph table len fits in int.
3222 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
3223 (row_table_size): Now ptrdiff_t, not int.
3224 (scrolling_window): Avoid overflow in size calculations.
3225 Don't update size until allocation succeeds.
3226 * fns.c (concat): Check for overflow in size calculations.
3227 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
3228 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3229 (NEXT_ALMOST_PRIME_LIMIT): New constant.
3231 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
3232 (get_doc_string): Check for size calculation overflow.
3233 Don't update size until allocation succeeds.
3234 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
3235 EMACS_INT, where ptrdiff_t will do.
3236 (Fsubstitute_command_keys): Check for string overflow.
3238 * editfns.c (set_time_zone_rule): Don't assume environment length
3240 (message_length): Now ptrdiff_t, not int.
3241 (Fmessage_box): Don't update size until allocation succeeds.
3242 Don't assume message length fits in int.
3243 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
3245 * emacs.c (main): Do not reallocate argv, since there is a null at
3246 the end that can be overwritten, and this way there's no need to
3247 worry about size-calculation overflow.
3248 (sort_args): Check for size-calculation overflow.
3250 * eval.c (init_eval_once, grow_specpdl): Don't update size until
3252 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
3254 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
3255 (x_set_scroll_bar_width, x_figure_window_size):
3256 Check for integer overflow.
3257 (x_set_alpha): Do not assume XINT fits in int.
3259 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
3260 This is for the members text_lines, text_cols, total_lines, total_cols,
3261 where the system imposes an 'int' limit.
3263 * fringe.c (Fdefine_fringe_bitmap):
3264 Don't update size until alloc works.
3266 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
3267 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
3269 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
3270 Check for size-calculation overflow.
3271 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
3272 do, as we prefer signed integers.
3273 (id_to_widget.max_size, id_to_widget.used)
3274 (xg_store_widget_in_map, xg_remove_widget_from_map)
3275 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
3276 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
3277 Use and return ptrdiff_t, not int.
3278 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
3279 * gtkutil.h: Change prototypes to match the above.
3281 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
3282 are duplicate now that they've been promoted to lisp.h.
3283 (x_allocate_bitmap_record, x_alloc_image_color)
3284 (make_image_cache, cache_image, xpm_load):
3285 Don't update size until alloc is done.
3286 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
3288 Check for size calculation overflow.
3289 (ct_colors_allocated_max): New constant.
3290 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
3293 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
3294 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
3295 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
3296 Use ptrdiff_t, not int, to count maps.
3297 (read_char_minibuf_menu_prompt): Check for overflow in size
3298 calculations. Don't update size until allocation succeeds.
3299 Redo calculations to avoid overflow.
3300 * keyboard.h: Change prototypes to match the above.
3302 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
3304 (current_minor_maps): Check for size calculation overflow.
3305 * keymap.h: Change prototypes to match the above.
3307 * lread.c (read1, init_obarray): Don't update size until alloc done.
3309 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
3310 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
3312 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
3313 Now ptrdiff_t, not int.
3314 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
3315 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
3317 * process.c (Fnetwork_interface_list): Check for overflow
3318 in size calculation.
3320 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3322 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3323 overflow. Don't bother calling xmalloc when xrealloc will do.
3325 * search.c (Freplace_match): Check for size calculation overflow.
3326 (Fset_match_data): Don't assume list lengths fit in 'int'.
3328 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3329 for command line length. Do not attempt to address one before the
3330 beginning of an array, as that's not portable.
3332 * term.c (max_frame_lines): Remove; unused.
3333 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3335 (encode_terminal_code, calculate_costs): Check for size
3336 calculation overflow.
3337 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3338 table lengths and related sizes. Don't update size until alloc
3339 done. Redo calculations to avoid overflow.
3340 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3342 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3343 subtracting pointers.
3344 (gobble_line): Check for overflow more carefully. Don't update size
3347 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3348 Don't update size until alloc done.
3349 Redo size calculations to avoid overflow.
3350 Check for size calculation overflow.
3351 (main) [DEBUG]: Fix typo in invoking tparam1.
3353 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3354 Use ptrdiff_t, not int, for sizes.
3355 (store_mode_line_noprop_char): Don't update size until alloc done.
3357 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3358 Use ptrdiff_t, not int, for sizes.
3359 (Finternal_make_lisp_face, cache_face):
3360 Check for size calculation overflow.
3361 (cache_face): Treat size calculation overflows as if they were
3362 memory exhaustion (the usual treatment), rather than aborting.
3364 * xfns.c (x_encode_text, x_set_name_internal)
3365 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3366 sizes, since they can exceed INT_MAX in size. Check for size
3367 calculation overflow.
3369 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3370 (xg_select): Check for size calculation overflow.
3371 Don't update size until alloc done.
3373 * xrdb.c (get_environ_db): Don't assume path length fits in int,
3374 as sprintf is limited to int lengths.
3376 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3377 (X_LONG_MIN): New macros.
3378 Use them to make the following changes clearer.
3379 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3380 This change doesn't affect the value now, but it may help remind
3381 future maintainers not to raise the value too much later.
3382 (SELECTION_QUANTUM): Remove, replacing with ...
3383 (selection_quantum): ... new function, which avoids overflow.
3385 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3386 assumption that selection length fits in 'int'.
3387 (x_reply_selection_request, x_handle_selection_request)
3388 (x_get_window_property, receive_incremental_selection)
3389 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3390 (lisp_data_to_selection_data, clean_local_selection_data):
3391 Use ptrdiff_t, not int, to record length of selection.
3392 (x_reply_selection_request, x_get_window_property)
3393 (receive_incremental_selection, x_property_data_to_lisp):
3394 Redo calculations to avoid overflow.
3395 (x_reply_selection_request): When sending hint, ceiling it at
3396 X_LONG_MAX rather than relying on wraparound overflow to send
3398 (x_get_window_property, receive_incremental_selection)
3399 (lisp_data_to_selection_data, x_property_data_to_lisp):
3400 Check for size-calculation overflow.
3401 (x_get_window_property, receive_incremental_selection)
3402 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3403 Don't store size until memory allocation succeeds.
3404 (x_get_window_property): Plug memory leak on memory exhaustion.
3405 Don't double-block input; malloc is safe here. Don't assume 2**34
3406 - 4 fits in unsigned long. Add an xassert to check
3407 XGetWindowProperty overflow. Be more careful about overflow
3408 calculations, and distinguish size from memory overflow better.
3409 (receive_incremental_selection): When tracing, don't assume
3410 unsigned int is less than INT_MAX.
3411 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3412 harmful) conversions of unsigned short to int.
3413 (lisp_data_to_selection_data): Don't assume that integers
3414 in the range -65535 through -1 fit in an X unsigned short.
3415 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3416 result parameters unless successful. Rely on cons_to_unsigned
3417 to report problems with elements; the old code wasn't right anyway.
3418 (x_check_property_data): Check for int overflow; we cannot use
3419 a wider type due to X limits.
3420 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3422 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
3424 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3425 (x_term_init): Check for size calculation overflow.
3426 (x_color_cells): Don't store size until memory allocation succeeds.
3427 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
3428 Don't assume alloca size is less than MAX_ALLOCA.
3429 (x_term_init): Don't assume length fits in int (sprintf is limited
3432 Use ptrdiff_t for composition IDs.
3433 * character.c (lisp_string_width):
3434 * composite.c (composition_table_size, n_compositions)
3435 (get_composition_id, composition_gstring_from_id):
3436 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3437 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3438 * window.c (Frecenter):
3439 Use ptrdiff_t, not int, for composition IDs.
3440 * composite.c (get_composition_id): Check for integer overflow.
3441 * composite.h: Adjust prototypes to match the above changes.
3443 Use ptrdiff_t for hash table indexes.
3444 * category.c (hash_get_category_set):
3445 * ccl.c (ccl_driver):
3446 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3447 * coding.c (coding_system_charset_list, detect_coding_system):
3448 * coding.h (struct coding_system.id):
3449 * composite.c (get_composition_id, gstring_lookup_cache):
3450 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3451 * image.c (xpm_get_color_table_h):
3452 * lisp.h (hash_lookup, hash_put):
3453 * minibuf.c (Ftest_completion):
3454 Use ptrdiff_t for hash table indexes, not int (which is too
3455 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3456 32-bit --with-wide-int hosts).
3458 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3459 Add a FIXME comment about memory leaks.
3460 (syms_of_charset): Don't assume xmalloc returns.
3462 Don't assume that stated character widths fit in int.
3463 * character.c (Fchar_width, c_string_width, lisp_string_width):
3464 * character.h (CHAR_WIDTH):
3465 * indent.c (MULTIBYTE_BYTES_WIDTH):
3466 Use sanitize_char_width to avoid undefined and/or bad behavior
3467 with outlandish widths.
3468 * character.h (sanitize_tab_width): Rename from sanitize_width,
3469 now that we have two such functions. All uses changed.
3470 (sanitize_char_width): New inline function.
3472 Don't assume that tab-width fits in int.
3473 * character.h (sanitize_width): New inline function.
3474 (SANE_TAB_WIDTH): New macro.
3475 (ASCII_CHAR_WIDTH): Use it.
3476 * indent.c (sane_tab_width): Remove. All uses replaced by
3477 SANE_TAB_WIDTH (current_buffer).
3478 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3480 * fileio.c: Integer overflow issues with file modes.
3481 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3483 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3484 Remove unreachable code.
3485 (read_hex, load_charset_map_from_file): Check for integer overflow.
3487 * xterm.c: Don't go over XClientMessageEvent limit.
3488 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3489 (x_send_scroll_bar_event): Likewise. Check that the size does not
3490 exceed limits imposed by XClientMessageEvent, as well as the usual
3491 ptrdiff_t and size_t limits.
3493 * keyboard.c: Overflow, signedness and related fixes.
3494 (make_lispy_movement): Use same integer type in forward decl
3495 that is used in the definition.
3496 (read_key_sequence, keyremap_step):
3497 Change bufsize argument back to int, undoing my 2011-03-30 change.
3498 We prefer signed types, and int is wide enough here.
3499 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3500 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3501 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3502 length, not size_t. Use ptrdiff_t for index, not int.
3503 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3504 possibility of integer overflow.
3506 Overflow, signedness and related fixes for images.
3508 * dispextern.h (struct it.stack[0].u.image.image_id)
3509 (struct_it.image_id, struct image.id, struct image_cache.size)
3510 (struct image_cache.used, struct image_cache.ref_count):
3511 * gtkutil.c (update_frame_tool_bar):
3512 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3513 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3514 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3515 * nsmenu.m (update_frame_tool_bar):
3516 * xdisp.c (calc_pixel_width_or_height):
3517 * xfns.c (image_cache_refcount):
3518 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3519 on typical 64-bit hosts.
3521 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3522 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3523 Omit unnecessary casts to int.
3524 (parse_image_spec): Check that integers fall into 'int' range
3525 when the callers expect that.
3526 (image_ascent): Redo ascent calculation to avoid int overflow.
3527 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3528 (lookup_image): Remove unnecessary tests.
3529 (xbm_image_p): Locals are now of int, not EMACS_INT,
3530 since parse_image_check makes sure they fit into int.
3531 (png_load, gif_load, svg_load_image):
3532 Prefer int to unsigned where either will do.
3533 (tiff_handler): New function, combining the cores of the
3534 old tiff_error_handler and tiff_warning_handler.
3535 This function is rewritten to use vsnprintf and thereby avoid
3536 stack buffer overflows. It uses only the features of vsnprintf
3537 that are common to both POSIX and native Microsoft.
3538 (tiff_error_handler, tiff_warning_handler): Use it.
3539 (tiff_load, gif_load, imagemagick_load_image):
3540 Don't assume :index value fits in 'int'.
3541 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3542 (imagemagick_load_image): Check that crop parameters fit into
3543 the integer types that MagickCropImage accepts. Don't assume
3544 Vimagemagick_render_type has a nonnegative value. Don't assume
3545 size_t fits in 'long'.
3546 (gs_load): Use printmax_t to print the widest integers possible.
3547 Check for integer overflow when computing image height and width.
3549 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3551 * xdisp.c (redisplay_window): Don't force window start if point
3552 will be invisible in the resulting window. (Bug#9324)
3554 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3556 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3557 the display spec is of the form `(space ...)'.
3558 (handle_display_spec): Return the value returned by
3559 handle_single_display_spec, not just 1 or zero.
3560 (handle_single_display_spec): If the display spec is of the form
3561 `(space ...)', and specifies display in the text area, return 2
3563 (try_cursor_movement): Check for the need to scroll more
3564 accurately, and prefer exact match for point under bidi.
3565 Don't advance `row' beyond the last row of the window.
3567 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3568 into disp_prop; all users changed.
3570 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3571 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3572 for the text covered by the display property.
3574 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3576 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3577 Change return value to nil.
3578 (Frecord_buffer): Delete unused function.
3580 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3582 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3583 buffers, return left-to-right.
3584 (set_cursor_from_row): Consider candidate row a win if its glyph
3585 represents a newline and point is on that newline. Fixes cursor
3586 positioning on the newline at EOL of R2L text within L2R
3587 paragraph, and vice versa.
3588 (try_cursor_movement): Check continued rows, in addition to
3589 continuation rows. Fixes unwarranted scroll when point enters a
3590 continued line of R2L text within an L2R paragraph, or vice versa.
3591 (cursor_row_p): Consider the case of point being equal to
3592 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3593 from the end of a short line to the beginning of a continued line
3594 of R2L text within L2R paragraph.
3595 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3596 composed characters.
3598 * bidi.c (bidi_check_type): Use xassert.
3599 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3602 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3604 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3607 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3609 * nsfont.m (ns_otf_to_script): Fix typo.
3611 2011-08-22 Kenichi Handa <handa@m17n.org>
3613 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3614 extra slot even if the purpose is char-code-property-table.
3616 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3618 * xdisp.c (redisplay_window): When computing centering_position,
3619 account for the height of the header line. (Bug#8874)
3621 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3622 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3623 candidate is selected by the mouse, and that candidate has a
3624 composed character under the mouse.
3626 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3627 coordinates reported by pos-visible-in-window-p for a composed
3628 character in column zero.
3630 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3632 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3634 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3636 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3637 consider it a hit if to_charpos is anywhere in the range of the
3638 composed buffer positions.
3640 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3642 * image.c (gif_load): Don't assume that each subimage has the same
3643 dimensions as the base image. Handle disposal method that is
3644 "undefined" by the gif spec (Bug#9335).
3646 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3648 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3649 (Fcondition_case): Document `debug' symbol in error handler.
3651 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3653 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3654 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3655 from an Org mode buffer to a Speedbar frame.
3657 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3658 a composition, take its buffer position from IT->cmp_it.charpos.
3659 Fixes cursor positioning at the beginning of a line that begins
3660 with a composed character.
3662 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3664 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3665 character bidirectional type, use STRONG_L instead. Fixes crashes
3666 in a buffer produced by `describe-categories'.
3668 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3669 members before the level stack, so they would be saved and
3670 restored when copying iterator state. Fixes incorrect reordering
3671 around TABs covered by display properties.
3673 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3675 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3677 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3679 * eval.c (internal_condition_case, internal_condition_case_1)
3680 (internal_condition_case_2, internal_condition_case_n):
3681 Remove unnecessary aborts (Bug#9081).
3683 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3685 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3686 has no `load' handler, try opening the file locally. (Bug#9311)
3688 2011-08-16 Ken Brown <kbrown@cornell.edu>
3690 * gmalloc.c: Expand comment.
3692 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3694 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3695 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3697 2011-08-16 Ken Brown <kbrown@cornell.edu>
3699 Fix memory allocation problems in Cygwin build (Bug#9273).
3701 * unexcw.c ( __malloc_initialized): Declare external variable.
3702 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3704 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3706 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3708 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3710 [CYGWIN] (special_realloc): New function.
3711 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3712 requests to realloc storage in the static heap.
3714 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3716 * bidi.c (bidi_initialize): Remove unused local.
3718 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3721 * biditype.h: Remove file.
3722 * makefile.w32-in ($(BLD)/bidi.$(O)):
3723 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3725 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3727 * chartab.c: Improve commentary for the uniprop_table API.
3729 * bidi.c (bidi_paragraph_init): Support zero value of
3730 bidi_ignore_explicit_marks_for_paragraph_level.
3731 (bidi_initialize): Use uniprop_table instead of including
3732 biditype.h and bidimirror.h.
3734 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3735 coordinates of the iterator when restoring from ppos_it.
3738 2011-08-14 Kenichi Handa <handa@m17n.org>
3740 * process.c (create_process): Call setup_process_coding_systems
3741 after the pid of the process is set to -1 (Bug#8162).
3743 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3745 * xdisp.c (move_it_in_display_line_to): Don't invoke
3746 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3747 ppos_it. Fixes vertical cursor motion when line beginning is
3748 covered by an image. (Bug#9296)
3750 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3752 * nsterm.h (ns_run_ascript): Declare.
3753 (NSAPP_DATA2_RUNASSCRIPT): Define.
3755 * nsfns.m (as_script, as_result, as_status): New static variables.
3756 (ns_run_ascript): New function.
3757 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3758 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3759 the event loop. Get status from as_status (Bug#7276).
3761 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3762 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3763 the event loop (Bug#7276).
3765 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3767 * gnutls.c (QCgnutls_bootprop_priority)
3768 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3769 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3770 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3771 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3772 (QCgnutls_bootprop_verify_hostname_error)
3773 (QCgnutls_bootprop_callbacks_verify): Rename from
3774 Qgnutls_bootprop_..., all uses changed.
3776 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3779 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3781 * xfaces.c (Qframe_set_background_mode): Now static.
3782 * dispextern.h (Qframe_set_background_mode): Remove decl.
3784 * process.c (Fnetwork_interface_info): Declare local only if needed.
3786 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3788 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3789 (Fnetwork_interface_list): Allocate in increments of bytes instead
3790 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3791 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3793 (struct ifflag_def): notrailers is smart on OSX.
3794 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3795 Get hardware address with getifaddrs if available.
3797 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3799 * xdisp.c (iterate_out_of_display_property): xassert that
3800 IT->position is set to within IT->object's boundaries. Break from
3801 the loop as soon as EOB is reached; avoids infloops in redisplay
3802 when IT->position is set up wrongly due to some bug.
3803 Set IT->current to match the bidi iterator unconditionally.
3804 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3805 entry. Force push_it to save on the stack the current
3806 buffer/string position, to be restored by pop_it. Fix flags in
3807 the iterator structure wrt the object coming from a display
3808 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3809 properties. (Bug#9284)
3811 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3813 * fontset.c (fontset_get_font_group): Add proper type checks.
3816 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3818 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3819 and LC_VERSION_MIN_MACOSX.
3820 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3821 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3823 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3825 * xdisp.c (forward_to_next_line_start): Allow to use the
3826 no-display-properties-and-no-overlays under bidi display.
3827 Set disp_pos in the bidi iterator to avoid searches for display
3828 properties and overlays.
3830 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3832 * editfns.c (Fset_time_zone_rule): Document relationship with the
3835 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3836 the font entity extracted from the cache (Bug#8109).
3838 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3840 * composite.c (autocmp_chars): Don't reset point. That is done by
3841 restore_point_unwind (Bug#5984).
3843 2011-08-07 Juri Linkov <juri@jurta.org>
3845 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3846 to show the arg `TIME' instead of `TIMEVAL'.
3848 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3850 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3851 display property strides EOL and includes a newline, as in
3852 longlines-mode. (Bug#9254)
3853 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3854 word-wrap under bidirectional display. (Bug#9224)
3856 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3857 is non-zero, even if the data buffer is NULL. Fixes a crash in
3858 vertical-motion with longlines-mode. (Bug#9254)
3860 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3862 * bidi.c <bidi_cache_total_alloc>: Now static.
3863 (bidi_initialize): Initialize bidi_cache_total_alloc.
3865 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3868 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3869 amount allocated this far in `bidi_cache_total_alloc'.
3870 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3871 non-zero, only free the data buffer without restoring the cache
3872 contents. All callers changed.
3874 * dispextern.h (bidi_unshelve_cache): Update prototype.
3876 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3877 (move_it_in_display_line, move_it_to)
3878 (move_it_vertically_backward, move_it_by_lines): Replace the call
3879 to xfree to an equivalent call to bidi_unshelve_cache.
3880 (move_it_in_display_line_to): Fix logic of returning
3881 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3883 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3885 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3886 came from a string character with a `cursor' property. (Bug#9229)
3888 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3890 * Makefile.in (LIB_PTHREAD): New variable.
3891 (LIBES): Add LIB_PTHREAD (Bug#9216).
3893 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3894 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3896 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3898 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3900 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3902 * xterm.c (x_find_topmost_parent): New function.
3903 (x_set_frame_alpha): Find topmost parent window with
3904 x_find_topmost_parent and set the property there also (bug#9181).
3905 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3907 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3909 * callproc.c (Fcall_process): Avoid vfork clobbering
3910 the local vars buffer, coding_systems, current_dir.
3912 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3914 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3916 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3918 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3919 so that it is not optimized away.
3921 * xdisp.c (compute_display_string_pos): Remove unused local.
3923 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3925 Fix slow cursor motion and scrolling in large buffers with
3926 selective display, like Org Mode buffers. (Bug#9218)
3928 * dispextern.h (struct bidi_it): New member disp_prop_p.
3930 * xdisp.c: Remove one-slot cache of display string positions.
3931 (compute_display_string_pos): Accept an additional argument
3932 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3933 for a display string or property. If found, set DISP_PROP_P
3936 * bidi.c (bidi_fetch_char): Accept an additional argument
3937 DISP_PROP_P, and pass it to compute_display_string_pos.
3938 Only handle text covered by a display string if DISP_PROP_P is returned
3939 non-zero. All callers of bidi_fetch_char changed.
3941 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3943 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3945 2010-12-03 Don March <don@ohspite.net>
3947 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3948 last character M-[char] is translated to ESC [char] (bug#7541).
3950 2011-08-02 Kenichi Handa <handa@m17n.org>
3952 * lisp.h (uniprop_table): Extern it.
3954 * chartab.c (uniprop_table): Make it non-static.
3956 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3958 * xdisp.c (forward_to_next_line_start): Accept additional argument
3959 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3961 (reseat_at_next_visible_line_start): Use the bidi iterator state
3962 returned by forward_to_next_line_start to restore the state of
3963 it->bidi_it after backing up to previous newline. (Bug#9212)
3965 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3967 * regex.c (re_comp): Protoize.
3968 (re_exec): Fix return type.
3969 (regexec): Fix type of `ret'. (Bug#9203)
3971 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3973 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3974 This is needed if max-image-size is a floating-point number.
3976 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3978 * print.c (print_object): Print empty symbol as ##.
3980 * lread.c (read1): Read ## as empty symbol.
3982 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3984 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3985 setting frame foreground color (Bug#9175).
3986 (x_set_background_color): Likewise.
3988 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3989 contents (Bug#9176).
3990 (EmacsTooltip -init): Remove bezels and add shadows to
3993 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3994 or scroll bar (Bug#8470).
3996 * nsfont.m (nsfont_open): Remove assignment to voffset and
3997 unnecessary vars hshink, expand, hd, full_height, min_height.
3998 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
4000 * nsterm.h (nsfont_info): Remove voffset field.
4002 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4004 Implement strike-through and overline on NextStep (Bug#8863).
4006 * nsfont.m (nsfont_open): Use underline position provided by font,
4007 instead of hard-coded value of 2.
4008 (nsfont_draw): Call ns_draw_text_decoration instead.
4010 * nsterm.h: Add declaration for ns_draw_text_decoration.
4012 * nsterm.m (ns_draw_text_decoration): New function for drawing
4013 underline, overline, and strike-through.
4014 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
4015 ns_draw_text_decoration. Change treatment of cursor drawing to
4016 accommodate underlining, etc.
4018 2011-07-28 Eli Zaretskii <eliz@gnu.org>
4020 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
4023 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4025 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
4026 Without this fix, if a signal arrives just after memory fills up,
4027 'malloc' might be invoked reentrantly.
4029 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
4030 In other words, assume that every image size is allowed, on non-X
4031 hosts. This assumption is probably wrong, but it lets Emacs compile.
4033 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
4035 * regex.c (re_iswctype): Convert return values to boolean.
4037 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
4039 * xdisp.c (compute_display_string_pos): Don't use cached display
4040 string position if the buffer had its restriction changed.
4043 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4045 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4047 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4049 Integer signedness and overflow and related fixes. (Bug#9079)
4051 * bidi.c: Integer size and overflow fixes.
4052 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
4053 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
4054 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4055 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
4056 (bidi_find_other_level_edge):
4057 Use ptrdiff_t instead of EMACS_INT where either will do.
4058 This works better on 32-bit hosts configured --with-wide-int.
4059 (bidi_cache_ensure_space): Check for size-calculation overflow.
4060 Use % rather than repeated addition, for better worst-case speed.
4061 Don't set bidi_cache_size until after xrealloc returns, because it
4063 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
4064 (bidi_cache_ensure_space): Also check that the bidi cache size
4065 does not exceed that of the largest Lisp string or buffer. See Eli
4066 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
4068 * alloc.c (__malloc_size_t): Remove.
4069 All uses replaced by size_t. See Andreas Schwab's note
4070 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
4072 * image.c: Improve checking for integer overflow.
4073 (check_image_size): Assume that f is nonnull, since
4074 it is always nonnull in practice. This is one less thing to
4075 worry about when checking for integer overflow later.
4076 (x_check_image_size): New function, which checks for integer
4077 overflow issues inside X.
4078 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
4079 This removes the need for a memory_full check.
4080 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
4081 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
4082 (xbm_read_bitmap_data): Change locals back to 'int', since
4083 their values must fit in 'int'.
4084 (xpm_load_image, png_load, tiff_load):
4085 Invoke x_create_x_image_and_pixmap earlier,
4086 to avoid much needless work if the image is too large.
4087 (tiff_load): Treat overly large images as if
4088 x_create_x_image_and_pixmap failed, not as malloc failures.
4089 (gs_load): Use x_check_image_size.
4091 * gtkutil.c: Omit integer casts.
4092 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
4093 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
4095 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
4097 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
4098 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
4099 would wrongly return t on a 64-bit host.
4101 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
4102 The plain *_OVERFLOW macros run afoul of GCC bug 49705
4103 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
4104 and therefore cause GCC to emit a bogus diagnostic in some cases.
4106 * image.c: Integer signedness and overflow and related fixes.
4107 This is not an exhaustive set of fixes, but it's time to
4108 record what I've got.
4109 (lookup_pixel_color, check_image_size): Remove redundant decls.
4110 (check_image_size): Don't assume that arbitrary EMACS_INT values
4111 fit in 'int', or that arbitrary 'double' values fit in 'int'.
4112 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
4113 (tiff_load, imagemagick_load_image):
4114 Check for overflow in size calculations.
4115 (x_create_x_image_and_pixmap): Remove unnecessary test for
4116 xmalloc returning NULL; that can't happen.
4117 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
4118 (xpm_color_bucket): Use better integer hashing function.
4119 (xpm_cache_color): Don't possibly over-allocate memory.
4120 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
4121 (gif_memory_source):
4122 Use ptrdiff_t, not int or size_t, to record sizes.
4123 (png_load): Don't assume values greater than 2**31 fit in 'int'.
4124 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
4125 either works, as we prefer signed integers.
4126 (tiff_read_from_memory, tiff_write_from_memory):
4127 Return tsize_t, not size_t, since that's what the TIFF API wants.
4128 (tiff_read_from_memory): Don't fail simply because the read would
4129 go past EOF; instead, return a short read.
4130 (tiff_load): Omit no-longer-needed casts.
4131 (Fimagemagick_types): Don't assume size fits into 'int'.
4133 Improve hashing quality when configured --with-wide-int.
4134 * fns.c (hash_string): New function, taken from sxhash_string.
4135 Do not discard information about ASCII character case; this
4136 discarding is no longer needed.
4137 (sxhash-string): Use it. Change sig to match it. Caller changed.
4138 * lisp.h: Declare it.
4139 * lread.c (hash_string): Remove, since we now use fns.c's version.
4140 The fns.c version returns a wider integer if --with-wide-int is
4141 specified, so this should help the quality of the hashing a bit.
4143 * emacs.c: Integer overflow minor fix.
4144 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
4145 Define only if GNU_LINUX.
4146 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
4148 * dispnew.c: Integer signedness and overflow fixes.
4149 Remove unnecessary forward decls, that were a maintenance hassle.
4150 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
4152 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
4153 (scrolling_window): Use ptrdiff_t, not int, for byte count.
4154 (prepare_desired_row, line_draw_cost):
4155 Use int, not unsigned, where either works.
4156 (save_current_matrix, restore_current_matrix):
4157 Use ptrdiff_t, not size_t, where either works.
4158 (init_display): Check for overflow more accurately, and without
4159 relying on undefined behavior.
4161 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
4162 Remove, replacing with the new symbols in lisp.h. All uses changed.
4163 * fileio.c (make_temp_name):
4164 * filelock.c (lock_file_1, lock_file):
4165 * xdisp.c (message_dolog):
4166 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
4167 Use pMd etc. instead.
4168 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
4169 replacing the pWIDE etc. symbols removed from editfns.c.
4171 * keyboard.h (num_input_events): Now uintmax_t.
4172 This is (very slightly) less likely to mess up due to wraparound.
4175 * buffer.c: Integer signedness fixes.
4176 (alloc_buffer_text, enlarge_buffer_text):
4177 Use ptrdiff_t rather than size_t when either will do, as we prefer
4180 * alloc.c: Integer signedness and overflow fixes.
4181 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
4182 (__malloc_size_t): Default to size_t, not to int.
4183 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
4184 (Fgarbage_collect, mark_object_loop_halt, mark_object):
4185 Prefer ptrdiff_t to size_t when either would do, as we prefer
4187 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
4188 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
4189 Now const. Initialize with values that are in range even if char
4191 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
4192 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
4193 These functions do the right thing with sizes > 2**32.
4194 (check_depth): Now ptrdiff_t, not int.
4195 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
4196 Adjust to new way of storing sizes. Check for size overflow bugs
4198 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
4199 slightly wrong anyway, as it missed one instance of
4200 XMALLOC_OVERRUN_CHECK_OVERHEAD.
4201 (refill_memory_reserve): Omit needless cast to size_t.
4202 (mark_object_loop_halt): Mark as externally visible.
4204 * xselect.c: Integer signedness and overflow fixes.
4205 (Fx_register_dnd_atom, x_handle_dnd_message):
4206 Use ptrdiff_t, not size_t, since we prefer signed.
4207 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
4208 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
4209 x_dnd_atoms_size and x_dnd_atoms_length.
4211 * doprnt.c: Prefer signed to unsigned when either works.
4213 * doprnt.c (doprnt):
4215 * xdisp.c (vmessage):
4216 Use ptrdiff_t, not size_t, when using or implementing doprnt,
4217 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
4218 prefer signed arithmetic to avoid comparison confusion.
4219 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
4220 but is a bit tricky.
4222 Assume freestanding C89 headers, string.h, stdlib.h.
4223 * data.c, doprnt.c, floatfns.c, print.c:
4224 Include float.h unconditionally.
4225 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
4226 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
4227 * regex.c: Likewise for stddef.h, string.h.
4228 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
4229 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
4230 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
4231 (STDC_HEADERS): Remove obsolete defines.
4232 * sysdep.c: Include limits.h unconditionally.
4234 Assume support for memcmp, memcpy, memmove, memset.
4235 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
4236 * regex.c (memcmp, memcpy):
4237 Remove; we assume C89 now.
4239 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
4240 (__malloc_safe_bcopy): Remove; no longer needed.
4242 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
4243 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
4244 well either way, and we prefer signed to unsigned.
4246 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
4248 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
4249 closes the connection while we're reading (bug#9182).
4251 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
4253 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
4254 are specified (Bug#9168).
4256 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
4258 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
4259 Found by GCC static checking and --with-wide-int on a 32-bit host.
4261 2011-07-25 Eli Zaretskii <eliz@gnu.org>
4263 * xdisp.c (compute_display_string_pos): Fix logic of caching
4264 previous display string position. Initialize cached_prev_pos to
4265 -1. Fixes slow-down at the beginning of a buffer.
4267 2011-07-24 Eli Zaretskii <eliz@gnu.org>
4269 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
4270 for attrs[LFACE_FONTSET_INDEX].
4272 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
4274 * xml.c (parse_region): Remove unused local
4275 that was recently introduced.
4277 2011-07-23 Eli Zaretskii <eliz@gnu.org>
4279 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
4280 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
4282 * xdisp.c (move_it_in_display_line_to): Record the best matching
4283 position for TO_CHARPOS while scanning the line, and restore it on
4284 exit if none of the characters scanned was an exact match.
4285 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
4286 when exact match is impossible due to invisible text, and the
4287 lines are truncated.
4289 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
4291 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
4294 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4296 Fix a significant slow-down of cursor motion with C-n, C-p,
4297 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
4298 auto-repeat under bidi redisplay in fontified buffers.
4299 * xdisp.c (compute_stop_pos_backwards): New function.
4300 (next_element_from_buffer): Call compute_stop_pos_backwards to
4301 find a suitable prev_stop when we find ourselves before
4303 (reseat): Don't look for prev_stop, as that could mean a very long
4305 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
4306 <cached_disp_overlay_modiff>: Cache for last found display string
4308 (compute_display_string_pos): Return the cached position if asked
4309 about the same buffer in the same area of character positions, and
4310 the buffer wasn't changed since the time the display string
4311 position was cached.
4313 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4315 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4316 is an integer, which is important for empty lines. (Bug#9149)
4318 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
4320 * frame.c (Fmodify_frame_parameters): In tty case, update the
4321 default face if necessary (Bug#4238).
4323 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
4325 * editfns.c (Fstring_to_char): No need to explain what a character
4326 is in the docstring (Bug#6576).
4328 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4330 * xml.c (parse_region): Make sure we always return a tree.
4332 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4334 * xml.c (parse_region): If a document contains only comments,
4337 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4339 * xml.c (make_dom): Return comments, too.
4341 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4344 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4345 and the surrounding thread.
4346 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4347 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4348 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4350 * s/openbsd.h (BROKEN_SIGIO): Define.
4351 * unexelf.c (unexec) [__OpenBSD__]:
4352 Don't update the .mdebug section of the Alpha COFF symbol table.
4354 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4356 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4359 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4361 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4362 This fixes some race conditions on the permissions of any newly
4365 * alloc.c (valid_pointer_p): Use pipe, not open.
4366 This fixes some permissions issues when debugging.
4368 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4369 If fchown fails to set both uid and gid, try to set just gid,
4370 as that is sometimes allowed. Adjust the file's mode to eliminate
4371 setuid or setgid bits that are inappropriate if fchown fails.
4373 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4375 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4376 to compare Lisp_Objects.
4377 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4378 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4379 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4381 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4383 * lread.c (read_integer): Unread even EOF character.
4384 (read1): Likewise. Properly record start position of symbol.
4386 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4387 symbol character follows.
4389 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4391 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4392 This works around a problem with the previous change to Fcopy_file.
4393 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4394 and without this change, GCC might complain about discarding
4395 fchown's return value.
4397 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
4399 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4401 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4403 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4405 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4407 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4408 it's used from the C level.
4410 * process.c: Use the same condition for POLL_FOR_INPUT in both
4411 keyboard.c and process.c (bug#1858).
4413 2011-07-09 Lawrence Mitchell <wence@gmx.li>
4415 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4416 (Fgnutls_boot): Use it.
4418 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4420 * doc.c (Fsubstitute_command_keys): Revert last change.
4422 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4424 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4425 quotes the next character, and doesn't affect other longer
4426 sequences (bug#8935).
4428 * lread.c (syms_of_lread): Clarify that is isn't only
4429 `eval-buffer' and `eval-defun' that's affected by
4430 `lexical-binding' (bug#8460).
4432 2011-07-15 Eli Zaretskii <eliz@gnu.org>
4434 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
4435 bidi redisplay when a line includes both an image and is truncated.
4437 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4439 Fix minor problems found by static checking.
4440 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4441 (elsz): Now a signed constant, not a size_t var. We prefer signed
4442 types to unsigned, to avoid integer comparison confusion. Without
4443 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4444 "cannot optimize loop, the loop counter may overflow", a symptom
4446 * indent.c (Fvertical_motion): Mark locals as initialized.
4447 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4449 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4451 * search.c (Fre_search_backward): Mention `case-fold-search' in
4452 all the re_search_* functions (bug#8138).
4454 * keyboard.c (Fopen_dribble_file): Document when the file is
4457 2011-07-14 Eli Zaretskii <eliz@gnu.org>
4459 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4462 Support bidi reordering of display and overlay strings.
4463 * xdisp.c (compute_display_string_pos)
4464 (compute_display_string_end): Accept additional argument STRING.
4465 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4466 (reseat_to_string): Initialize bidi_it->string.s and
4467 bidi_it->string.schars.
4468 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
4469 NULL (avoids a crash in bidi_paragraph_init).
4470 Initialize itb.string.lstring.
4471 (init_iterator): Call bidi_init_it only of a valid
4472 buffer position was specified. Initialize paragraph_embedding to
4474 (reseat_to_string): Initialize the bidi iterator.
4475 (display_string): If we need to ignore text properties of
4476 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4477 original value of -1 will not work with bidi.)
4478 (compute_display_string_pos): First arg is now struct
4479 `text_pos *'; all callers changed. Support display properties on
4481 (compute_display_string_end): Support display properties on Lisp
4483 (init_iterator, reseat_1, reseat_to_string): Initialize the
4484 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4485 when iterating on a string not from display properties).
4486 (compute_display_string_pos, compute_display_string_end):
4487 Fix calculation of the object to scan. Fixes an error when using
4489 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4490 base_level_stop; instead, set base_level_stop to BEGV.
4491 Fixes crashes in vertical-motion.
4492 (next_element_from_buffer): Improve commentary for when
4493 the iterator is before prev_stop.
4494 (init_iterator): Initialize bidi_p from the default value of
4495 bidi-display-reordering, not from buffer-local value. Use the
4496 buffer-local value only if initializing for buffer iteration.
4497 (handle_invisible_prop): Support invisible properties on strings
4498 that are being bidi-reordered.
4499 (set_iterator_to_next): Support bidi reordering of C strings and
4501 (next_element_from_string): Support bidi reordering of Lisp
4503 (handle_stop_backwards): Support Lisp strings as well.
4504 (display_string): Support display of R2L glyph rows.
4505 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4506 (init_iterator): Don't initialize it->bidi_p for strings
4508 (reseat_to_string): Initialize it->bidi_p for strings here.
4509 (next_element_from_string, next_element_from_c_string)
4510 (next_element_from_buffer): Add xassert's for correspondence
4511 between IT's object being iterated and it->bidi_it.string
4513 (face_before_or_after_it_pos): Support bidi iteration.
4514 (next_element_from_c_string): Handle the case of the first string
4515 character that is not the first one in the visual order.
4516 (get_visually_first_element): New function, refactored from common
4517 parts of next_element_from_buffer, next_element_from_string, and
4518 next_element_from_c_string.
4519 (tool_bar_lines_needed, redisplay_tool_bar)
4520 (display_menu_bar): Force left-to-right direction. Add a FIXME
4521 comment for making that be controlled by a user option.
4522 (push_it, pop_it): Save and restore the state of the
4523 bidi iterator. Save and restore the bidi_p flag.
4524 (pop_it): Iterate out of display property for string iteration as
4526 (iterate_out_of_display_property): Support iteration over strings.
4527 (handle_single_display_spec): Set up it->bidi_it for iteration
4528 over a display string, and call bidi_init_it.
4529 (handle_single_display_spec, next_overlay_string)
4530 (get_overlay_strings_1, push_display_prop): Set up the bidi
4531 iterator for displaying display or overlay strings.
4532 (forward_to_next_line_start): Don't use the shortcut if
4534 (back_to_previous_visible_line_start): If handle_display_prop
4535 pushed the iterator stack, restore the internal state of the bidi
4536 iterator by calling bidi_pop_it same number of times.
4537 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4538 and we are bidi-iterating, don't decrement the iterator position;
4539 instead, set the first_elt flag in the bidi iterator, to produce
4541 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4542 (push_display_prop): xassert that we are iterating a buffer.
4543 (push_it, pop_it): Save and restore paragraph_embedding member.
4544 (handle_single_display_spec, next_overlay_string)
4545 (get_overlay_strings_1, reseat_1, reseat_to_string)
4546 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4547 correctly. Don't assume unibyte strings are not bidi-reordered.
4548 (compute_display_string_pos)
4549 (compute_display_string_end): Fix handling the case of C string.
4550 (push_it, pop_it): Save and restore from_disp_prop_p.
4551 (handle_single_display_spec, push_display_prop): Set the
4552 from_disp_prop_p flag.
4553 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4554 (pop_it): Call iterate_out_of_display_property only if we are
4555 popping after iteration over a string that came from a display
4556 property. Fix a typo in popping stretch info. Add an assertion
4557 for verifying that the iterator position is in sync with the bidi
4559 (handle_single_display_spec, get_overlay_strings_1)
4560 (push_display_prop): Fix initialization of paragraph direction for
4561 string when that of the parent object is not yet determined.
4562 (reseat_1): Call bidi_init_it to resync the bidi
4563 iterator with IT's position. (Bug#7616)
4564 (find_row_edges): If ROW->start.pos gives position
4565 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4566 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4567 Reset the from_disp_prop_p flag.
4568 (SAVE_IT, RESTORE_IT): New macros.
4569 (pos_visible_p, face_before_or_after_it_pos)
4570 (back_to_previous_visible_line_start)
4571 (move_it_in_display_line_to, move_it_in_display_line)
4572 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4573 (try_scrolling, redisplay_window, display_line): Use them when
4574 saving a temporary copy of the iterator and restoring it back.
4575 (back_to_previous_visible_line_start, reseat_1)
4576 (init_iterator): Empty the bidi cache "stack".
4577 (move_it_in_display_line_to): If iterator ended up at
4578 EOL, but we never saw any buffer positions smaller than
4579 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4580 motion in bidi-reordered lines.
4581 (move_it_in_display_line_to): Record prev_method and prev_pos
4582 immediately before the call to set_iterator_to_next. Fixes cursor
4583 motion in bidi-reordered lines with stretch glyphs and strings
4584 displayed in margins. (Bug#8133) (Bug#8867)
4585 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4587 (pos_visible_p): Support positions in bidi-reordered lines.
4588 Save and restore bidi cache.
4590 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4591 (bidi_paragraph_info): Delete unused struct.
4592 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4593 (bidi_cache_start): New variable.
4594 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4596 (bidi_cache_fetch_state, bidi_cache_search)
4597 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4598 (bidi_cache_find, bidi_peek_at_next_level)
4599 (bidi_level_of_next_char, bidi_find_other_level_edge)
4600 (bidi_move_to_visually_next): Compare cache index with
4601 bidi_cache_start rather than with zero.
4602 (bidi_fetch_char): Accept new argument STRING; all callers
4603 changed. Support iteration over a string. Support strings with
4604 display properties. Support unibyte strings. Fix the type of
4605 `len' according to what STRING_CHAR_AND_LENGTH expects.
4606 (bidi_paragraph_init, bidi_resolve_explicit_1)
4607 (bidi_resolve_explicit, bidi_resolve_weak)
4608 (bidi_level_of_next_char, bidi_move_to_visually_next):
4609 Support iteration over a string.
4610 (bidi_set_sor_type, bidi_resolve_explicit_1)
4611 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4612 can now be zero (for strings); special values 0 and -1 were
4613 changed to -1 and -2, respectively.
4614 (bidi_char_at_pos): New function.
4615 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4616 Call it instead of FETCH_MULTIBYTE_CHAR.
4617 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4618 initialized to valid values.
4619 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4621 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4622 the test for valid cached positions. Fix the logic for looking up
4623 the sentinel state in the cache. GCPRO the Lisp string we are
4625 (bidi_push_it, bidi_pop_it): New functions.
4626 (bidi_initialize): Initialize the bidi cache start stack pointer.
4627 (bidi_cache_ensure_space): New function, refactored from part of
4628 bidi_cache_iterator_state. Don't assume the required size is just
4629 one BIDI_CACHE_CHUNK away.
4630 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4631 (bidi_count_bytes, bidi_char_at_pos): New functions.
4632 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4633 always valid if bidi_cache_idx is valid.
4634 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4635 is valid if it's going to be used.
4636 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4637 (bidi_cache_fetch_state, bidi_cache_search)
4638 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4639 (bidi_cache_iterator_state, bidi_cache_find)
4640 (bidi_find_other_level_edge, bidi_cache_start_stack):
4641 All variables related to cache indices are now EMACS_INT.
4643 * dispextern.h (struct bidi_string_data): New structure.
4644 (struct bidi_it): New member `string'. Make flag members be 1-bit
4645 fields, and put them last in the struct.
4646 (compute_display_string_pos, compute_display_string_end):
4648 (bidi_push_it, bidi_pop_it): Add prototypes.
4649 (struct iterator_stack_entry): New members bidi_p,
4650 paragraph_embedding, and from_disp_prop_p.
4651 (struct it): Member bidi_p is now a bit field 1 bit wide.
4652 (bidi_shelve_cache, bidi_unshelve_cache):
4655 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4656 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4657 and vector-like objects.
4659 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4660 cache around display iteration.
4662 * window.c (Fwindow_end, window_scroll_pixel_based)
4663 (displayed_window_lines, Frecenter): Save and restore the bidi
4664 cache around display iteration.
4666 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4668 * editfns.c (Fdelete_region): Clarify the use of the named
4669 parameters (bug#6788).
4671 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4673 * indent.c (Fvertical_motion): Set and restore w->pointm when
4674 saving and restoring the window's buffer (Bug#9006).
4676 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4678 * editfns.c (Fstring_to_char): Clarify just what is returned
4679 (bug#6576). Text by Eli Zaretskii.
4681 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4683 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4685 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4687 * buffer.c (mmap_find): Fix a typo.
4689 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4691 Fix execution of x selection hooks.
4692 * xselect.c (Qx_lost_selection_functions)
4693 (Qx_sent_selection_functions): New vars.
4694 (syms_of_xselect): DEFSYM them.
4695 (x_handle_selection_request): Pass Qx_sent_selection_functions
4696 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4697 (x_handle_selection_clear,x_clear_frame_selections):
4698 Pass Qx_lost_selection_functions rather than
4699 Vx_lost_selection_functions to Frun_hook_with_args.
4701 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4703 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4704 The old code sometimes used this field without initializing it.
4706 * alloc.c (gc_sweep): Don't read past end of array.
4707 In theory, the old code could also have corrupted Emacs internals,
4708 though it'd be very unlikely.
4710 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4712 * character.c (Fcharacterp): Don't advertise optional ignored
4713 argument. (Bug#4026)
4715 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4717 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4720 * window.c (Fset_window_start): Doc fix (bug#4199).
4721 (Fset_window_hscroll): Ditto.
4723 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4725 Fix minor new problems caught by GCC 4.6.1.
4726 * term.c (init_tty): Remove unused local.
4727 * xsettings.c (store_monospaced_changed): Define this function only
4728 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4731 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4733 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4735 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4737 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4738 are the mini-buffer and the echo area (bug#3320).
4740 * term.c (init_tty): Remove support for supdup, c10 and perq
4741 terminals, which are no longer supported (bug#1482).
4743 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4745 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4747 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4749 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4750 for non-popups (Bug#3642).
4752 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4754 * alloc.c (reset_malloc_hooks): Protoize.
4755 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4756 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4757 * cm.c (losecursor): Likewise.
4758 * data.c (fmod): Likewise.
4759 * dispnew.c (swap_glyphs_in_rows): Likewise.
4760 * emacs.c (memory_warning_signal): Likewise.
4761 * floatfns.c (float_error): Likewise.
4762 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4763 (otf_open, font_otf_capability, generate_otf_features)
4764 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4766 * image.c (pbm_read_file): Likewise.
4767 * indent.c (string_display_width): Likewise.
4768 * intervals.c (check_for_interval, search_for_interval)
4769 (inc_interval_count, count_intervals, root_interval)
4770 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4771 * lread.c (defalias): Likewise.
4772 * ralloc.c (r_alloc_check): Likewise.
4773 * regex.c (set_image_of_range_1, set_image_of_range)
4774 (regex_grow_registers): Likewise.
4775 * sysdep.c (strerror): Likewise.
4776 * termcap.c (valid_filename_p, tprint, main): Likewise.
4777 * tparam.c (main): Likewise.
4778 * unexhp9k800.c (run_time_remap, save_data_space)
4779 (update_file_ptrs, read_header, write_header, calculate_checksum)
4780 (copy_file, copy_rest, display_header): Likewise.
4781 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4783 * xdisp.c (check_it): Likewise.
4784 * xfaces.c (register_color, unregister_color, unregister_colors):
4786 * xfns.c (print_fontset_result): Likewise.
4787 * xrdb.c (member, fatal, main): Likewise.
4789 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4791 Fix minor problems found by static checking (Bug#9031).
4792 * chartab.c (char_table_set_range, map_sub_char_table):
4793 Remove unused locals.
4794 (uniprop_table): Now static.
4795 * composite.c (_work_char): Remove unused static var.
4797 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4799 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4801 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4803 * gtkutil.c (qttip_cb): Remove code without function.
4805 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4807 * w32.c (pthread_sigmask): New stub.
4809 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4811 Use pthread_sigmask, not sigprocmask (Bug#9010).
4812 sigprocmask is portable only for single-threaded applications, and
4813 Emacs can be multi-threaded when it uses GTK.
4814 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4816 * callproc.c (Fcall_process):
4817 * process.c (create_process):
4818 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4819 Use pthread_sigmask, not sigprocmask.
4821 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4823 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4824 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4827 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4829 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4830 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4831 (xg_hide_tooltip): Fix comment.
4833 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4834 in registerServicesMenuSendTypes.
4835 (validRequestorForSendType): Don't check ns_return_types.
4837 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4840 2011-07-08 Jason Rumney <jasonr@gnu.org>
4842 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4843 SH_SHOW for hidden windows (Bug#5482).
4845 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4846 frame struct members of non-existent frames (Bug#6284).
4848 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4850 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4851 variable firstTime not needed on OSX >= 10.6.
4852 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4853 >= 10.5. Use setKnobProportion, setDoubleValue.
4855 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4856 (MAC_OS_X_VERSION_10_5): Define if not defined.
4857 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4858 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4859 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4861 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4862 cString and lossyCString on OSX >= 10.4
4864 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4865 sizeToFit on OSX >= 10.2.
4867 * nsimage.m (allocInitFromFile): Don't use deprecated method
4868 bestRepresentationForDevice on OSX >= 10.6.
4870 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4873 * emacs.c: Declare unexec_init_emacs_zone.
4875 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4877 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4879 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4880 on svcsMenu (Bug#8842).
4882 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4884 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4886 * nsterm.m (QUTF8_STRING): Declare.
4887 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4888 (validRequestorForSendType): Return type is (id).
4889 Change indexOfObjectIdenticalTo to indexOfObject.
4890 Check if we have local selection before returning self (Bug#8842).
4891 (writeSelectionToPasteboard): Put local selection into paste board
4892 if we have a local selection (Bug#8842).
4893 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4895 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4896 (ns_get_local_selection): Declare.
4898 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4900 * keymap.c (describe_map_tree): Don't insert a double newline at
4901 the end of the buffer (bug#1169) and return whether we inserted
4904 * callint.c (Fcall_interactively): Change "reading args" to
4905 "providing args" to try to clarify what it does (bug#1010).
4907 2011-07-07 Kenichi Handa <handa@m17n.org>
4909 * composite.c (composition_compute_stop_pos): Ignore a static
4910 composition starting before CHARPOS (Bug#8915).
4912 * xdisp.c (handle_composition_prop): Likewise.
4914 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4916 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4919 2011-07-07 Kenichi Handa <handa@m17n.org>
4921 * character.h (unicode_category_t): New enum type.
4923 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4924 (Qchar_code_property_table): New variable.
4925 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4926 (UNIPROP_COMPRESSED_FORM_P): New macros.
4927 (char_table_ascii): Uncompress the compressed values.
4928 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4929 Uncompress the compressed values.
4930 (sub_char_table_ref_and_range): Likewise.
4931 (char_table_ref_and_range): Uncompress the compressed values.
4932 (sub_char_table_set): New arg is_uniprop. Callers changed.
4933 Uncompress the compressed values.
4934 (sub_char_table_set_range): Args changed. Callers changed.
4935 (char_table_set_range): Adjuted for the above change.
4936 (map_sub_char_table): Delete args default_val and parent. Add arg
4937 top. Give decoded values to a Lisp function.
4938 (map_char_table): Adjust for the above change. Give decoded
4939 values to a Lisp function. Gcpro more variables.
4940 (uniprop_table_uncompress)
4941 (uniprop_decode_value_run_length): New functions.
4942 (uniprop_decoder, uniprop_decoder_count): New variables.
4943 (uniprop_get_decoder, uniprop_encode_value_character)
4944 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4946 (uniprop_encoder, uniprop_encoder_count): New variables.
4947 (uniprop_get_encoder, uniprop_table)
4948 (Funicode_property_table_internal, Fget_unicode_property_internal)
4949 (Fput_unicode_property_internal): New functions.
4950 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4951 Sunicode_property_table_internal, Sget_unicode_property_internal,
4952 and Sput_unicode_property_internal. Defvar_lisp
4953 char-code-property-alist.
4955 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4956 Vunicode_category_table.
4958 * font.c (font_range): Adjust for the change of
4959 Vunicode_category_table.
4961 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4963 * m/iris4d.h: Remove file, move contents ...
4964 * s/irix6-5.h: ... here.
4966 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4968 Remove unportable assumption about struct layout (Bug#8884).
4969 * alloc.c (mark_buffer):
4970 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4971 (clone_per_buffer_values): Don't assume that
4972 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4973 This isn't true in general, and it's particularly not true
4974 if Emacs is configured with --with-wide-int.
4975 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4976 New macros, used in the buffer.c change.
4978 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4980 * xsettings.c: Use both GConf and GSettings if both are available.
4981 (store_config_changed_event): Add comment.
4982 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4983 (store_tool_bar_style_changed): New functions.
4984 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4985 (struct xsettings): Move font inside HAVE_XFT.
4986 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4987 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4988 Move inside HAVE_XFT.
4989 (something_changed_gsettingsCB): Rename from something_changedCB.
4990 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4992 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4993 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4994 (something_changed_gconfCB): Rename from something_changedCB.
4995 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4996 (parse_settings): Move check for font inside HAVE_XFT.
4997 (read_settings, apply_xft_settings): Add comment.
4998 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4999 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
5000 call store_font_name_changed.
5001 (xft_settings_event): Add comment.
5002 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
5003 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
5004 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
5005 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
5006 (xsettings_initialize): Call init_gsettings last.
5007 (xsettings_get_system_font, xsettings_get_system_normal_font):
5010 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
5012 Random fixes. E.g., (random) never returned negative values.
5013 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
5014 subseconds part to the entropy, as that's a bit more random.
5015 Prefer signed to unsigned, since the signedness doesn't matter and
5016 in general we prefer signed. When given a limit, use a
5017 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
5018 latter isn't right if USE_2_TAGS_FOR_INTS.
5019 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
5020 not 0..VALMASK. Don't discard "excess" bits that random () returns.
5022 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
5024 * textprop.c (text_property_stickiness):
5025 Obey Vtext_property_default_nonsticky.
5026 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
5027 * w32fns.c (syms_of_w32fns):
5028 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
5030 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
5032 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
5033 This is more efficient than Ffile_directory_p and avoids a minor race.
5035 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
5037 * buffer.c (Foverlay_put): Say what the return value is
5040 * fileio.c (barf_or_query_if_file_exists): Check first if the file
5041 is a directory before asking whether to use the file name
5043 (barf_or_query_if_file_exists): Make the "File is a directory"
5044 error be more correct.
5046 * fns.c (Frequire): Remove the mention of the .gz files, since
5047 that's installation-specific, but keep the mention of
5048 `get-load-suffixes'.
5050 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
5052 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
5053 Report string overflow if the output is too long.
5055 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
5057 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
5058 (syms_of_gnutls): Remove duplicate DEFSYM for
5059 Qgnutls_bootprop_verify_hostname_error, an error for
5060 Qgnutls_bootprop_verify_error (which is no longer used).
5062 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
5063 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
5064 Also (re)move comments that are misplaced or no longer relevant.
5066 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5068 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
5070 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
5072 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
5073 and background color parameters if they have been changed.
5075 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5077 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
5079 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
5081 * xsettings.c (SYSTEM_FONT): Define only when used.
5082 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
5084 * keymap.c (access_keymap_1): Now static.
5086 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
5088 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
5089 leave any prefix arg for the up event (Bug#1586).
5091 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
5093 * lread.c (syms_of_lread): Mention single symbols defined by
5094 `defvar' or `defconst' (bug#7154).
5096 * fns.c (Frequire): Mention .el.gz files (bug#7314).
5097 (Frequire): Mention get-load-suffixes.
5099 2011-07-02 Martin Rudalics <rudalics@gmx.at>
5101 * window.h (window): Remove clone_number slot.
5102 * window.c (Fwindow_clone_number, Fset_window_clone_number):
5104 (make_parent_window, make_window, saved_window)
5105 (Fset_window_configuration, save_window_save): Don't deal with
5107 * buffer.c (Qclone_number): Remove declaration.
5108 (sort_overlays, overlay_strings): Don't deal with clone numbers.
5110 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
5112 Add multiple inheritance to keymaps.
5113 * keymap.c (Fmake_composed_keymap): New function.
5114 (Fset_keymap_parent): Simplify.
5115 (fix_submap_inheritance): Remove.
5116 (access_keymap_1): New function extracted from access_keymap to handle
5117 embedded parents and handle lists of maps.
5118 (access_keymap): Use it.
5119 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
5120 (Fcopy_keymap): Handle embedded parents.
5121 (Fcommand_remapping, define_as_prefix): Simplify.
5122 (Fkey_binding): Simplify.
5123 (syms_of_keymap): Move minibuffer-local-completion-map,
5124 minibuffer-local-filename-completion-map,
5125 minibuffer-local-must-match-map, and
5126 minibuffer-local-filename-must-match-map to Elisp.
5127 (syms_of_keymap): Defsubr make-composed-keymap.
5128 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
5129 (parse_menu_item): Trivial simplification.
5131 2011-07-01 Glenn Morris <rgm@gnu.org>
5133 * Makefile.in (SETTINGS_LIBS): Fix typo.
5135 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
5137 * coding.c (Fencode_coding_string): Record the last coding system
5138 used, as the function doc string says (bug#8738).
5140 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
5142 * xsettings.c (store_monospaced_changed): Take new font as arg and
5143 check for change against current_mono_font.
5144 (EMACS_TYPE_SETTINGS): Remove this and related defines.
5145 (emacs_settings_constructor, emacs_settings_get_property)
5146 (emacs_settings_set_property, emacs_settings_class_init)
5147 (emacs_settings_init, gsettings_obj): Remove.
5148 (something_changedCB): New function for HAVE_GSETTINGS.
5149 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
5150 with value as argument.
5151 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
5152 g_settings_new (Bug#8967). Do not create gsettings_obj.
5153 Remove calls to g_settings_bind. Connect something_changedCB to
5156 * xgselect.c: Add defined (HAVE_GSETTINGS).
5157 (xgselect_initialize): Ditto.
5159 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
5160 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
5163 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
5165 * eval.c (struct backtrace): Simplify and port the data structure.
5166 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
5167 signed bit field, as this assumption is not portable and it makes
5168 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
5169 "char debug_on_exit : 1" as this is not portable either; instead,
5170 use the portable "unsigned int debug_on_exit : 1". Remove unused
5171 member evalargs. Remove obsolete comments about cc bombing out.
5173 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
5175 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
5176 Let HAVE_GSETTINGS override HAVE_GCONF.
5177 (store_monospaced_changed): New function.
5178 (EMACS_SETTINGS): A new type derived from GObject to handle
5179 GSettings notifications.
5180 (emacs_settings_constructor, emacs_settings_get_property)
5181 (emacs_settings_set_property, emacs_settings_class_init):
5183 (gsettings_client, gsettings_obj): New variables.
5184 (GSETTINGS_SCHEMA): New define.
5185 (something_changedCB): Call store_monospaced_changed.
5186 (init_gsettings): New function.
5187 (xsettings_initialize): Call init_gsettings.
5188 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
5191 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
5194 2011-06-29 Martin Rudalics <rudalics@gmx.at>
5196 * window.c (resize_root_window, grow_mini_window)
5197 (shrink_mini_window): Rename Qresize_root_window to
5198 Qwindow_resize_root_window and Qresize_root_window_vertically to
5199 Qwindow_resize_root_window_vertically.
5201 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
5203 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
5205 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
5207 * makefile.w32-in: Redesign dependencies so they reflect more
5208 clearly which files are directly included by each source file,
5209 and not through other includes.
5211 2011-06-27 Martin Rudalics <rudalics@gmx.at>
5213 * buffer.c (Qclone_number): Declare static and DEFSYM it.
5214 (sort_overlays, overlay_strings): When an overlay's clone number
5215 matches the window's clone number process the overlay even if
5216 the overlay's window property doesn't match the current window.
5218 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
5219 (Fwindow_hchild): Rename to Fwindow_left_child.
5220 (Fwindow_next): Rename to Fwindow_next_sibling.
5221 (Fwindow_prev): Rename to Fwindow_prev_sibling.
5222 (resize_window_check): Rename to window_resize_check.
5223 (resize_window_apply): Rename to window_resize_apply.
5224 (Fresize_window_apply): Rename to Fwindow_resize_apply.
5225 (Fdelete_other_windows_internal, resize_frame_windows)
5226 (Fsplit_window_internal, Fdelete_window_internal)
5227 (grow_mini_window, shrink_mini_window)
5228 (Fresize_mini_window_internal): Fix callers accordingly.
5230 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
5232 * emacsgtkfixed.h: State that this is only used with Gtk+3.
5233 (emacs_fixed_set_min_size): Remove.
5234 (emacs_fixed_new): Take frame as argument.
5236 * emacsgtkfixed.c: State that this is only used with Gtk+3.
5237 (_EmacsFixedPrivate): Remove minwidth/height.
5238 Add struct frame *f.
5239 (emacs_fixed_init): Initialize priv->f.
5240 (get_parent_class, emacs_fixed_set_min_size): Remove.
5241 (emacs_fixed_new): Set priv->f to argument.
5242 (emacs_fixed_get_preferred_width)
5243 (emacs_fixed_get_preferred_height): Use min_width/height from
5244 frames size_hint to set minimum and natural (Bug#8919).
5245 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
5246 and use min_width/height from frames size_hint to set
5247 min_width/height (Bug#8919).
5249 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
5250 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
5253 2011-06-26 Eli Zaretskii <eliz@gnu.org>
5255 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
5256 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
5259 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
5261 * process.c (wait_reading_process_output): Bypass select if
5262 waiting for a cell while ignoring keyboard input, and input is
5263 pending. Suggested by Jan Djärv (Bug#8869).
5265 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
5267 Use gnulib's dup2 module instead of rolling our own.
5268 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
5270 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5272 * dispnew.c (scrolling_window): Before scrolling, turn off a
5273 mouse-highlight in the window being scrolled.
5275 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
5277 Move DEFSYM to lisp.h and use everywhere.
5279 * character.h (DEFSYM): Move declaration...
5280 * lisp.h (DEFSYM): ...here.
5286 * w32select.c: Don't include character.h.
5288 * alloc.c (syms_of_alloc):
5289 * buffer.c (syms_of_buffer):
5290 * bytecode.c (syms_of_bytecode):
5291 * callint.c (syms_of_callint):
5292 * casefiddle.c (syms_of_casefiddle):
5293 * casetab.c (init_casetab_once):
5294 * category.c (init_category_once, syms_of_category):
5295 * ccl.c (syms_of_ccl):
5296 * cmds.c (syms_of_cmds):
5297 * composite.c (syms_of_composite):
5298 * dbusbind.c (syms_of_dbusbind):
5299 * dired.c (syms_of_dired):
5300 * dispnew.c (syms_of_display):
5301 * doc.c (syms_of_doc):
5302 * editfns.c (syms_of_editfns):
5303 * emacs.c (syms_of_emacs):
5304 * eval.c (syms_of_eval):
5305 * fileio.c (syms_of_fileio):
5306 * fns.c (syms_of_fns):
5307 * frame.c (syms_of_frame):
5308 * fringe.c (syms_of_fringe):
5309 * insdel.c (syms_of_insdel):
5310 * keymap.c (syms_of_keymap):
5311 * lread.c (init_obarray, syms_of_lread):
5312 * macros.c (syms_of_macros):
5313 * msdos.c (syms_of_msdos):
5314 * print.c (syms_of_print):
5315 * process.c (syms_of_process):
5316 * search.c (syms_of_search):
5317 * sound.c (syms_of_sound):
5318 * syntax.c (init_syntax_once, syms_of_syntax):
5319 * terminal.c (syms_of_terminal):
5320 * textprop.c (syms_of_textprop):
5321 * undo.c (syms_of_undo):
5322 * w32.c (globals_of_w32):
5323 * window.c (syms_of_window):
5324 * xdisp.c (syms_of_xdisp):
5325 * xfaces.c (syms_of_xfaces):
5326 * xfns.c (syms_of_xfns):
5327 * xmenu.c (syms_of_xmenu):
5328 * xsettings.c (syms_of_xsettings):
5329 * xterm.c (syms_of_xterm): Use DEFSYM.
5331 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5333 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
5335 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5337 Integer and buffer overflow fixes (Bug#8873).
5339 * print.c (printchar, strout): Check for string overflow.
5340 (PRINTPREPARE, printchar, strout):
5341 Don't set size unless allocation succeeds.
5343 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5344 for sizes. Check for string overflow more accurately.
5345 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5347 * macros.c: Integer and buffer overflow fixes.
5348 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5349 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5350 Use ptrdiff_t, not int, for sizes.
5351 Don't increment bufsize until after realloc succeeds.
5352 Check for size-calculation overflow.
5353 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5355 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5357 * lread.c: Integer overflow fixes.
5358 (read_integer): Radix is now EMACS_INT, not int,
5359 to improve quality of diagnostics for out-of-range radices.
5360 Calculate buffer size correctly for out-of-range radices.
5361 (read1): Check for integer overflow in radices, and in
5362 read-circle numbers.
5363 (read_escape): Avoid int overflow.
5364 (Fload, openp, read_buffer_size, read1)
5365 (substitute_object_recurse, read_vector, read_list, map_obarray):
5366 Use ptrdiff_t, not int, for sizes.
5367 (read1): Use EMACS_INT, not int, for sizes.
5368 Check for size overflow.
5370 * image.c (cache_image): Check for size arithmetic overflow.
5372 * lread.c: Integer overflow issues.
5373 (saved_doc_string_size, saved_doc_string_length)
5374 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5375 Now ptrdiff_t, not int.
5376 (read1): Don't assume doc string length fits in int. Check for
5377 out-of-range doc string lengths.
5378 (read_list): Don't assume file position fits in int.
5379 (read_escape): Check for hex character overflow.
5381 2011-06-22 Leo Liu <sdl.web@gmail.com>
5383 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5384 Move to minibuffer.el.
5386 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5388 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
5389 The following patches are for when GLYPH_DEBUG && !XASSERT.
5390 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5391 * dispnew.c (flush_stdout):
5392 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5393 Mark as externally visible.
5394 * dispnew.c (check_window_matrix_pointers): Now static.
5395 * dispnew.c (window_to_frame_vpos):
5396 * xfns.c (unwind_create_frame):
5397 * xterm.c (x_check_font): Remove unused local.
5398 * scroll.c (CHECK_BOUNDS):
5399 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5400 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5401 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5402 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5403 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5405 (debug_method_add): Use va_list and vsprintf rather than relying
5406 on undefined behavior with wrong number of arguments.
5407 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5408 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5409 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5410 since we're not interested in debugging glyphs with old libraries.
5411 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5412 GCC 4.6.0's static checking.
5414 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5416 Integer overflow and signedness fixes (Bug#8873).
5417 A few related buffer overrun fixes, too.
5419 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5421 * dispextern.h (struct face.stipple):
5422 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5423 (x_bitmap_mask, x_allocate_bitmap_record)
5424 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5425 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5426 (x_create_bitmap_from_xpm_data):
5427 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5428 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5430 * xfaces.c (load_pixmap):
5431 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5432 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5433 (.bitmaps_last, struct x_output.icon_bitmap):
5434 Use ptrdiff_t, not int, for bitmap indexes.
5435 (x_allocate_bitmap_record): Check for size overflow.
5436 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5438 Use ptrdiff_t, not int, for overlay counts.
5439 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5440 * editfns.c (overlays_around, get_pos_property):
5441 * textprop.c (get_char_property_and_overlay):
5442 * xdisp.c (next_overlay_change, note_mouse_highlight):
5443 * xfaces.c (face_at_buffer_position):
5444 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5445 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5446 (Fnext_overlay_change, Fprevious_overlay_change)
5447 (mouse_face_overlay_overlaps, Foverlays_in):
5448 Use ptrdiff_t, not int, for sizes.
5449 (overlays_at, overlays_in): Check for size-calculation overflow.
5451 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5453 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5454 (x_session_initialize): Do not assume string length fits in int.
5456 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5457 This is unlikely, but can occur if DPI is outlandish.
5459 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
5460 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5462 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5463 * xrdb.c (magic_file_p, search_magic_path):
5464 Omit last arg SUFFIX; it was always 0. All callers changed.
5465 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5467 * xfont.c (xfont_match): Avoid need for strlen.
5469 * xfns.c: Don't assume strlen fits in int.
5470 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5472 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5473 not unsigned long, as we prefer signed integers. All callers changed.
5474 Detect integer overflow in repeat count.
5475 (message_dolog): Don't assume print length fits in 39 bytes.
5476 (display_mode_element): Don't assume strlen fits in int.
5478 * termcap.c: Don't assume sizes fit in int and never overflow.
5479 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5480 (gobble_line): Check for size-calculation overflow.
5482 * minibuf.c (Fread_buffer):
5483 * lread.c (intern, intern_c_string):
5484 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5485 Don't assume string length fits in int.
5487 * keyboard.c (parse_tool_bar_item):
5488 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5490 * font.c: Don't assume string length fits in int.
5491 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5492 Use ptrdiff_t, not int.
5493 (font_intern_prop): Don't assume string length fits in int.
5494 Don't assume integer property fits in fixnum.
5495 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5497 * filelock.c: Fix some buffer overrun and integer overflow issues.
5498 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5499 Reformulate so as not to need the command string.
5500 Invoke gzip -cd rather than gunzip, as it's more portable.
5501 (lock_info_type, lock_file_1, lock_file):
5502 Don't assume pid_t and time_t fit in unsigned long.
5503 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5504 (current_lock_owner): Prefer signed type for sizes.
5505 Use memcpy, not strncpy, where memcpy is what is really wanted.
5506 Don't assume (via atoi) that time_t and pid_t fit in int.
5507 Check for time_t and/or pid_t out of range, e.g., via a network share.
5508 Don't alloca where an auto var works fine.
5510 * fileio.c: Fix some integer overflow issues.
5511 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5512 Don't assume string length fits in int.
5513 (directory_file_name): Don't assume string length fits in long.
5514 (make_temp_name): Don't assume pid fits in int, or that its print
5515 length is less than 20.
5517 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5519 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5521 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5523 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5524 We prefer signed integers, even for size calculations.
5526 * emacs.c: Don't assume string length fits in 'int'.
5527 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5528 (main): Don't invoke strlen when not needed.
5530 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5531 (XD_DEBUG_MESSAGE): Don't waste a byte.
5533 * callproc.c (getenv_internal_1, getenv_internal)
5535 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5537 * lread.c (invalid_syntax): Omit length argument.
5538 All uses changed. This doesn't fix a bug, but it simplifies the
5539 code away from its former Hollerith-constant appearance, and it's
5540 one less 'int' to worry about when looking at integer-overflow issues.
5541 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5543 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5544 This didn't break anything, but it didn't help either.
5545 It's confusing to put a bogus integer in a place where the actual
5546 value does not matter.
5547 (LIST_END_P): Remove unused macro and its bogus comment.
5548 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5550 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5551 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5553 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5554 We prefer signed types, and the value cannot exceed the EMACS_INT
5555 range anyway (because otherwise the length would not be representable).
5556 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5557 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5558 This avoids a GCC warning when WIDE_EMACS_INT.
5560 * indent.c (sane_tab_width): New function.
5561 (current_column, scan_for_column, Findent_to, position_indentation)
5562 (compute_motion): Use it. This is just for clarity.
5563 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5565 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5567 * lisp.h (lint_assume): New macro.
5568 * composite.c (composition_gstring_put_cache):
5569 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5571 * editfns.c, insdel.c:
5572 Omit unnecessary forward decls, to simplify future changes.
5574 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5576 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5578 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5579 Use much-faster test for byte-length change.
5580 Don't assume string byte-length fits in 'int'.
5581 Check that character arg fits in 'int'.
5582 (mapcar1): Declare byte as byte, for clarity.
5584 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5586 * fns.c (concat): Catch string overflow earlier.
5587 Do not rely on integer wraparound.
5589 * dispextern.h (struct it.overlay_strings_charpos)
5590 (struct it.selective): Now EMACS_INT, not int.
5591 * xdisp.c (forward_to_next_line_start)
5592 (back_to_previous_visible_line_start)
5593 (reseat_at_next_visible_line_start, next_element_from_buffer):
5594 Don't arbitrarily truncate the value of 'selective' to int.
5596 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5598 * composite.c: Don't truncate sizes to 'int'.
5599 (composition_gstring_p, composition_reseat_it)
5600 (composition_adjust_point): Use EMACS_INT, not int.
5601 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5602 not EMACS_UINT, for indexes.
5604 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5606 * buffer.c: Include <verify.h>.
5607 (struct sortvec.priority, struct sortstr.priority):
5608 Now EMACS_INT, not int.
5609 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5610 (struct sortstr.size, record_overlay_string)
5611 (struct sortstrlist.size, struct sortlist.used):
5612 Don't truncate size to int.
5613 (record_overlay_string): Check for size-calculation overflow.
5614 (init_buffer_once): Check at compile-time, not run-time.
5616 2011-06-22 Jim Meyering <meyering@redhat.com>
5618 Don't leak an XBM-image-sized buffer
5619 * image.c (xbm_load): Free the image buffer after using it.
5621 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5624 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5625 that Sun C diagnosed.
5626 * fns.c (secure_hash): Fix pointer signedness issue.
5627 * intervals.c (static_offset_intervals): New function.
5628 (offset_intervals): Use it.
5630 2011-06-21 Leo Liu <sdl.web@gmail.com>
5633 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5636 * fns.c (secure_hash): Rename from crypto_hash_function and change
5637 the first arg to accept symbols.
5638 (Fsecure_hash): New primitive.
5639 (syms_of_fns): New symbols.
5641 2011-06-20 Deniz Dogan <deniz@dogan.se>
5643 * process.c (Fset_process_buffer): Clarify return value in
5646 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5648 * dispnew.c (add_window_display_history): Use BVAR.
5650 * xdisp.c (debug_method_add): Use BVAR.
5651 (check_window_end, dump_glyph_matrix, dump_glyph)
5652 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5654 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5657 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5658 check till after the cache is created in init_frame_faces.
5660 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5662 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5664 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5666 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5667 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5668 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5670 Improve buffer-overflow checking (Bug#8873).
5671 * fileio.c (Finsert_file_contents):
5672 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5673 Remove the old (too-loose) buffer overflow checks.
5674 They weren't needed, since make_gap checks for buffer overflow.
5675 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5676 The old code merely checked for Emacs fixnum overflow, and relied
5677 on undefined (wraparound) behavior. The new code avoids undefined
5678 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5680 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5681 Tune. Don't use wider integers than needed. Don't use alloca.
5682 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5684 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5686 * insdel.c, lisp.h (buffer_overflow): New function.
5687 (insert_from_buffer_1, replace_range, replace_range_2):
5688 * insdel.c (make_gap_larger):
5689 * editfns.c (Finsert_char):
5690 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5692 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5694 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5696 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5698 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5699 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5701 * fileio.c: Don't assume EMACS_INT fits in off_t.
5702 (emacs_lseek): New static function.
5703 (Finsert_file_contents, Fwrite_region): Use it.
5704 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5706 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5708 * fns.c: Don't overflow int when computing a list length.
5709 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5710 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5711 truncation on 64-bit hosts. Check for QUIT every
5712 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5713 faster and is responsive enough.
5714 (Flength): Report an error instead of overflowing an integer.
5715 (Fsafe_length): Return a float if the value is not representable
5716 as a fixnum. This shouldn't happen except in contrived situations.
5717 (Fnthcdr, Fsort): Don't assume list length fits in int.
5718 (Fcopy_sequence): Don't assume vector length fits in int.
5720 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5721 (header_size, word_size): New constants.
5722 (allocate_vectorlike): Don't check size overflow here.
5723 (allocate_vector): Check it here instead, since this is the only
5724 caller of allocate_vectorlike that could cause overflow.
5725 Check that the new vector's length is representable as a fixnum.
5727 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5728 The previous code was bogus. For example, next_almost_prime (32)
5729 returned 39, which is undesirable as it is a multiple of 3; and
5730 next_almost_prime (24) returned 25, which is a multiple of 5 so
5731 why was the code bothering to check for multiples of 7?
5733 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5735 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5737 Variadic C functions now count arguments with ptrdiff_t.
5738 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5739 Back then I didn't know that the Emacs coding style prefers signed int.
5740 Also, in the meantime I found a few more instances where arguments
5741 were being counted with int, which may truncate counts on 64-bit
5742 machines, or EMACS_INT, which may be unnecessarily wide.
5743 * lisp.h (struct Lisp_Subr.function.aMANY)
5744 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5745 Arg counts are now ptrdiff_t, not size_t.
5746 All variadic functions and their callers changed accordingly.
5747 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5748 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5749 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5750 * callint.c (Fcall_interactively): Check arg count for overflow,
5751 to avoid potential buffer overrun. Use signed char, not 'int',
5752 for 'varies' array, so that we needn't bother to check its size
5753 calculation for overflow.
5754 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5755 * eval.c (apply_lambda):
5756 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5757 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5758 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5760 * callint.c (Fcall_interactively): Don't use index var as event count.
5762 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5763 * mem-limits.h (SIZE): Remove; no longer used.
5765 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5767 Remove unnecessary casts.
5768 * xterm.c (x_term_init):
5769 * xfns.c (x_set_border_pixel):
5770 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5771 These aren't needed now that we assume ANSI C.
5773 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5774 It's more likely to cause problems (due to unsigned overflow)
5777 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5779 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5781 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5783 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5785 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5787 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5789 GLYPH_CODE_FACE returns EMACS_INT, not int.
5790 * dispextern.h (merge_faces):
5791 * xfaces.c (merge_faces):
5792 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5793 Don't assume EMACS_INT fits in int.
5795 * character.h (CHAR_VALID_P): Remove unused parameter.
5796 * fontset.c, lisp.h, xdisp.c: All uses changed.
5798 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5800 * fns.c (concat): Minor tuning based on overflow analysis.
5801 This doesn't fix any bugs. Use int to hold character, instead
5802 of constantly refetching from Emacs object. Use XFASTINT, not
5803 XINT, for value known to be a character. Don't bother comparing
5804 a single byte to 0400, as it's always less.
5806 * floatfns.c (Fexpt):
5807 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5809 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5812 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5814 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5815 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5816 incorrectly succeed when S was a string, because 4294967386 was
5817 truncated before it was used.
5819 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5820 Otherwise, an out-of-range integer could cause undefined behavior
5823 * composite.c: Use int, not EMACS_INT, for characters.
5824 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5825 EMACS_INT, for values that are known to be in character range.
5826 This doesn't fix any bugs but is the usual style inside Emacs and
5827 may generate better code on 32-bit machines.
5829 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5830 This is for reasons similar to the recent CHAR_STRING fix.
5831 * charset.c (Fencode_char): Check that character arg is actually
5832 a character. Pass an int to ENCODE_CHAR.
5833 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5834 wider than 'int', as a compile-time check to prevent future regressions
5837 * character.c (char_string): Remove unnecessary casts.
5839 Make sure a 64-bit char is never passed to CHAR_STRING.
5840 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5841 by silently ignoring the top 32 bits, allowing some values
5842 that were far too large to be valid characters.
5843 * character.h: Include <verify.h>.
5844 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5845 arguments are no wider than unsigned, as a compile-time check
5846 to prevent future regressions in this area.
5848 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5849 (Fsubst_char_in_region):
5851 * xdisp.c (decode_mode_spec_coding):
5852 Adjust to CHAR_STRING's new requirement.
5853 * editfns.c (Finsert_char, Fsubst_char_in_region):
5854 * fns.c (concat): Check that character args are actually
5855 characters. Without this test, these functions did the wrong
5856 thing with wildly out-of-range values on 64-bit hosts.
5858 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5859 These casts should not be needed on 32-bit hosts, either.
5860 * keyboard.c (read_char):
5861 * lread.c (Fload): Remove casts to unsigned.
5863 * lisp.h (UNSIGNED_CMP): New macro.
5864 This fixes comparison bugs on 64-bit hosts.
5865 (ASCII_CHAR_P): Use it.
5866 * casefiddle.c (casify_object):
5867 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5868 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5869 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5870 * dispextern.h (FACE_FROM_ID):
5871 * keyboard.c (read_char): Use UNSIGNED_CMP.
5873 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5874 not to EMACS_INT, to avoid GCC warning.
5876 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5878 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5879 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5880 isn't needed on 32-bit machines.
5882 * buffer.c (Fgenerate_new_buffer_name):
5883 Use EMACS_INT for count, not int.
5884 (advance_to_char_boundary): Return EMACS_INT, not int.
5886 * data.c (Qcompiled_function): Now static.
5888 * window.c (window_body_lines): Now static.
5890 * image.c (gif_load): Rename local to avoid shadowing.
5892 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5893 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5894 * alloc.c (make_save_value): Integer argument is now of type
5896 (mark_object): Use ptrdiff_t, not int.
5897 * lisp.h (pD): New macro.
5898 * print.c (print_object): Use it.
5900 * alloc.c: Use EMACS_INT, not int, to count objects.
5901 (total_conses, total_markers, total_symbols, total_vector_size)
5902 (total_free_conses, total_free_markers, total_free_symbols)
5903 (total_free_floats, total_floats, total_free_intervals)
5904 (total_intervals, total_strings, total_free_strings):
5905 Now EMACS_INT, not int. All uses changed.
5906 (Fgarbage_collect): Compute overall total using a double, so that
5907 integer overflow is less likely to be a problem. Check for overflow
5908 when converting back to an integer.
5909 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5910 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5911 These were 'int' variables that could overflow on 64-bit hosts;
5912 they were never used, so remove them instead of repairing them.
5913 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5914 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5915 Previously, this ceilinged at INT_MAX, but that doesn't work on
5917 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5919 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5920 (allocate_vectorlike): Check for ptrdiff_t overflow.
5921 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5922 when a (possibly-narrower) signed value would do just as well.
5923 We prefer using signed arithmetic, to avoid comparison confusion.
5925 * alloc.c: Catch some string size overflows that we were missing.
5926 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5927 for convenience in STRING_BYTES_MAX.
5928 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5929 The definition here is exact; the one in lisp.h was approximate.
5930 (allocate_string_data): Check for string overflow. This catches
5931 some instances we weren't catching before. Also, it catches
5932 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5933 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5934 and ptrdiff_t and EMACS_INT are both 64 bits.
5936 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5937 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5938 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5940 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5942 * alloc.c (Fmake_string): Check for out-of-range init.
5944 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5946 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5948 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5950 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5951 xg_get_default_scrollbar_width.
5953 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5954 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5955 (style_changed_cb): Call update_theme_scrollbar_width and call
5956 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5957 all frames (Bug#8505).
5958 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5959 Call gtk_window_set_resizable if HAVE_GTK3.
5960 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5961 and height if HAVE_GTK3 (Bug#8505).
5962 (scroll_bar_width_for_theme): New variable.
5963 (update_theme_scrollbar_width): New function.
5964 (xg_get_default_scrollbar_width): Move code to
5965 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5966 (xg_initialize): Call update_theme_scrollbar_width.
5968 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5970 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5972 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5974 * frame.c (make_frame): Call other_buffer_safely instead of
5977 * window.c (temp_output_buffer_show): Call display_buffer with
5978 second argument Vtemp_buffer_show_specifiers and reset latter
5979 immediately after the call.
5980 (Vtemp_buffer_show_specifiers): New variable.
5981 (auto_window_vscroll_p, next_screen_context_lines)
5982 (Vscroll_preserve_screen_position): Remove leading asterisks from
5985 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5987 Fix minor problems found by GCC 4.6.0 static checking.
5988 * buffer.c (Qclone_number): Remove for now, as it's unused.
5989 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5990 (record_buffer): Remove unused local.
5991 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5992 (set_frame_buffer_list): Remove; unused.
5993 * frame.h (other_visible_frames): Remove decl.
5994 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5995 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5996 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5998 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5999 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
6000 Define only if HAVE_GPM.
6001 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
6002 (update_hints_inhibit): Remove; never set. All uses removed.
6003 * widgetprv.h (emacsFrameClassRec): Remove decl.
6004 * window.c (delete_deletable_window): Now returns void, since it
6005 wasn't returning anything.
6006 (compare_window_configurations): Remove unused locals.
6007 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
6008 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
6009 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
6010 the same widths as pointers. This follows up on the 2011-05-06 patch.
6011 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
6012 * xterm.h: Likewise.
6013 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
6015 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
6017 * makefile.w32-in: Update dependencies.
6018 (LISP_H): Add lib/intprops.h.
6020 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
6022 * image.c (gif_load): Add animation frame delay to the metadata.
6023 (syms_of_image): Use DEFSYM. New symbol `delay'.
6025 2011-06-11 Martin Rudalics <rudalics@gmx.at>
6027 * window.c (delete_deletable_window): Re-add.
6028 (Fset_window_configuration): Rewrite to handle dead buffers and
6029 consequently deletable windows.
6030 (window_tree, Fwindow_tree): Remove. Supply functionality in
6032 (compare_window_configurations): Simplify code.
6034 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
6036 * image.c (imagemagick_load_image): Fix type mismatch.
6037 (Fimagemagick_types): Likewise.
6039 * window.h (replace_buffer_in_windows): Declare.
6041 2011-06-11 Martin Rudalics <rudalics@gmx.at>
6043 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
6044 Qclone_number. Remove external declaration of Qdelete_window.
6045 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
6047 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
6048 Run Qbuffer_list_update_hook if allowed.
6049 (Fother_buffer): Rewrite doc-string. Major rewrite for new
6050 buffer list implementation.
6051 (other_buffer_safely): New function.
6052 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
6053 calls to replace_buffer_in_windows and
6054 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
6056 (record_buffer): Inhibit quitting and rewrite using quittable
6057 functions. Run Qbuffer_list_update_hook if allowed.
6058 (Frecord_buffer, Funrecord_buffer): New functions.
6059 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
6060 Move switch-to-buffer to window.el.
6061 (bury-buffer): Move to window.el.
6062 (Vbuffer_list_update_hook): New variable.
6064 * lisp.h (other_buffer_safely): Add prototype in buffer.c
6067 * window.h (resize_frame_windows): Move up in code.
6068 (Fwindow_frame): Remove EXFUN.
6069 (replace_buffer_in_all_windows): Remove prototype.
6070 (replace_buffer_in_windows_safely): Add prototype.
6072 * window.c: Declare Qdelete_window static again. Move down
6073 declaration of select_count.
6074 (Fnext_window, Fprevious_window): Rewrite doc-strings.
6075 (Fother_window): Move to window.el.
6076 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
6077 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
6078 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
6080 (replace_buffer_in_windows): Implement by calling
6081 Qreplace_buffer_in_windows.
6082 (replace_buffer_in_all_windows): Remove with some functionality
6083 moved into replace_buffer_in_windows_safely.
6084 (replace_buffer_in_windows_safely): New function.
6085 (select_window_norecord, select_frame_norecord): Move in front
6086 of run_window_configuration_change_hook. Remove now obsolete
6088 (Fset_window_buffer): Rewrite doc-string.
6089 Call Qrecord_window_buffer.
6090 (keys_of_window): Move binding for other-window to window.el.
6092 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
6094 * dispextern.h (struct image): Replace data member, whose int_val
6095 and ptr_val fields were not used by anything, with a single
6098 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
6099 (gif_clear_image, gif_load, imagemagick_load_image)
6100 (gs_clear_image, gs_load): Callers changed.
6102 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
6104 * buffer.h: Include <time.h>, for time_t.
6105 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
6107 Fix minor problems found by static checking.
6109 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
6111 Make identifiers static if they are not used in other modules.
6112 * data.c (Qcompiled_function, Qframe, Qvector):
6113 * image.c (QimageMagick, Qsvg):
6114 * minibuf.c (Qmetadata):
6115 * window.c (resize_window_check, resize_root_window): Now static.
6116 * window.h (resize_window_check, resize_root_window): Remove decls.
6118 * window.c (window_deletion_count, delete_deletable_window):
6120 (window_body_lines): Now static.
6121 (Fdelete_other_windows_internal): Mark vars as initialized.
6122 Make sure 'resize_failed' is initialized.
6123 (run_window_configuration_change_hook): Rename local to avoid shadowing.
6124 (resize_window_apply): Remove unused local.
6125 * window.h (delete_deletable_window): Remove decl.
6127 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
6128 (imagemagick_load_image): Fix pointer signedness problem by changing
6129 last arg from unsigned char * to char *. All uses changed.
6130 Also, fix a local for similar reasons.
6131 Remove unused locals. Remove locals to avoid shadowing.
6132 (fn_rsvg_handle_free): Remove; unused.
6133 (svg_load, svg_load_image): Fix pointer signedness problem.
6134 (imagemagick_load_image): Don't use garbage pointer image_wand.
6136 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
6138 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
6140 * image.c (gif_load): Fix omitted cast error introduced by
6143 2011-06-10 Martin Rudalics <rudalics@gmx.at>
6145 * window.h (resize_proportionally, orig_total_lines)
6146 (orig_top_line): Remove from window structure.
6147 (set_window_height, set_window_width, change_window_heights)
6148 (Fdelete_window): Remove prototypes.
6149 (resize_frame_windows): Remove duplicate declaration.
6151 2011-06-10 Eli Zaretskii <eliz@gnu.org>
6153 * window.h (resize_frame_windows, resize_window_check)
6154 (delete_deletable_window, resize_root_window)
6155 (resize_frame_windows): Declare prototypes.
6157 * window.c (resize_window_apply): Make definition be "static" to
6158 match the prototype.
6160 2011-06-10 Martin Rudalics <rudalics@gmx.at>
6162 * window.c: Remove declarations of Qwindow_size_fixed,
6163 window_min_size_1, window_min_size_2, window_min_size,
6164 size_window, window_fixed_size_p, enlarge_window, delete_window.
6165 Remove static from declaration of Qdelete_window, it's
6166 temporarily needed by Fbury_buffer.
6167 (replace_window): Don't assign orig_top_line and
6169 (Fdelete_window, delete_window): Remove. Window deletion is
6170 handled by window.el.
6171 (window_loop): Remove DELETE_OTHER_WINDOWS case.
6172 Replace Fdelete_window calls with calls to Qdelete_window.
6173 (Fdelete_other_windows): Remove. Deleting other windows is
6174 handled by window.el.
6175 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
6176 handled in window.el.
6177 (window_min_size_2, window_min_size_1, window_min_size): Remove.
6178 Window minimum sizes are handled in window.el.
6179 (shrink_windows, size_window, set_window_height)
6180 (set_window_width, change_window_heights, window_height)
6181 (window_width, CURBEG, CURSIZE, enlarge_window)
6182 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
6183 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
6184 handled in window.el.
6185 (make_dummy_parent): Rename to make_parent_window and give it a
6186 second argument horflag.
6187 (make_window): Don't set resize_proportionally any more.
6188 (Fsplit_window): Remove. Windows are split in window.el.
6189 (save_restore_action, save_restore_orig_size)
6190 (shrink_window_lowest_first, save_restore_orig_size): Remove.
6191 Resize mini windows in window.el.
6192 (grow_mini_window, shrink_mini_window): Implement by calling
6193 Qresize_root_window_vertically, resize_window_check and
6194 resize_window_apply.
6195 (saved_window, Fset_window_configuration, save_window_save):
6196 Do not handle orig_top_line, orig_total_lines, and
6197 resize_proportionally.
6198 (window_min_height, window_min_width): Move to window.el.
6199 (keys_of_window): Move bindings for delete-other-windows,
6200 split-window, delete-window and enlarge-window to window.el.
6202 * buffer.c: Temporarily extern Qdelete_window.
6203 (Fbury_buffer): Temporarily call Qdelete_window instead of
6204 Fdelete_window (Fbury_buffer will move to window.el soon).
6206 * frame.c (set_menu_bar_lines_1): Remove code handling
6207 orig_top_line and orig_total_lines.
6209 * dispnew.c (adjust_frame_glyphs_initially): Don't use
6210 set_window_height but set heights directly.
6211 (change_frame_size_1): Use resize_frame_windows.
6213 * xdisp.c (init_xdisp): Don't use set_window_height but set
6216 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
6217 Use resize_frame_windows instead of change_window_heights and run
6218 run_window_configuration_change_hook.
6220 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
6221 instead of change_window_heights and run
6222 run_window_configuration_change_hook.
6224 2011-06-09 Martin Rudalics <rudalics@gmx.at>
6226 * window.c (replace_window): Rename second argument REPLACEMENT to
6227 NEW. New third argument SETFLAG. Rewrite.
6228 (delete_window, make_dummy_parent): Call replace_window with
6230 (window_list_1): Move down in code.
6231 (run_window_configuration_change_hook): Move set_buffer part
6232 before select_frame_norecord part in order to unwind correctly.
6233 Rename count1 to count.
6234 (recombine_windows, delete_deletable_window, resize_root_window)
6235 (Fdelete_other_windows_internal)
6236 (Frun_window_configuration_change_hook, make_parent_window)
6237 (resize_window_check, resize_window_apply, Fresize_window_apply)
6238 (resize_frame_windows, Fsplit_window_internal)
6239 (Fdelete_window_internal, Fresize_mini_window_internal):
6241 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
6243 2011-06-08 Martin Rudalics <rudalics@gmx.at>
6245 * window.h (window): Add some new members to window structure -
6246 normal_lines, normal_cols, new_total, new_normal, clone_number,
6247 splits, nest, prev_buffers, next_buffers.
6248 (WINDOW_TOTAL_SIZE): Move here from window.c.
6249 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
6251 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
6253 (make_dummy_parent): Set new members of windows structure.
6254 (make_window): Move down in code. Handle new members of window
6256 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
6257 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
6258 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
6259 (Fset_window_prev_buffers, Fwindow_next_buffers)
6260 (Fset_window_next_buffers, Fset_window_clone_number):
6262 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
6263 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
6265 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
6266 Argument WINDOW can be now internal window too.
6267 (Fwindow_use_time): Move up in code.
6268 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
6270 (Fset_window_configuration, saved_window)
6271 (Fcurrent_window_configuration, save_window_save): Handle new
6272 members of window structure.
6273 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
6274 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
6275 (syms_of_window): New Lisp objects Qrecord_window_buffer,
6276 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
6277 Qget_mru_window, Qresize_root_window,
6278 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
6279 Qauto_buffer_name; staticpro them.
6281 2011-06-07 Martin Rudalics <rudalics@gmx.at>
6283 * window.c (Fwindow_total_size, Fwindow_left_column)
6284 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
6285 (Fwindow_list_1): New functions.
6286 (window_box_text_cols): Replace with window_body_cols.
6287 (Fwindow_width, Fscroll_left, Fscroll_right):
6288 Use window_body_cols instead of window_box_text_cols.
6289 (delete_window, Fset_window_configuration):
6290 Call delete_all_subwindows with window as argument.
6291 (delete_all_subwindows): Take a window as argument and not a
6293 (window_loop): Remove handling of GET_LRU_WINDOW and
6295 (Fget_lru_window, Fget_largest_window): Move to window.el.
6297 * window.h: Extern window_body_cols instead of
6298 window_box_text_cols. delete_all_subwindows now takes a
6299 Lisp_Object as argument.
6301 * indent.c (compute_motion, Fcompute_motion):
6302 Use window_body_cols instead of window_box_text_cols.
6304 * frame.c (delete_frame): Call delete_all_subwindows with root
6307 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
6309 * fns.c (Fputhash): Document return value.
6311 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
6313 * image.c (gif_load): Implement gif89a spec "no disposal" method.
6315 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6317 Cons<->int and similar integer overflow fixes (Bug#8794).
6319 Check for overflow when converting integer to cons and back.
6320 * charset.c (Fdefine_charset_internal, Fdecode_char):
6321 Use cons_to_unsigned to catch overflow.
6322 (Fencode_char): Use INTEGER_TO_CONS.
6323 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6324 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6325 * data.c (long_to_cons, cons_to_long): Remove.
6326 (cons_to_unsigned, cons_to_signed): New functions.
6327 These signal an error for invalid or out-of-range values.
6328 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6329 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6330 * font.c (Ffont_variation_glyphs):
6331 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6332 * lisp.h: Include <intprops.h>.
6333 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6334 (cons_to_signed, cons_to_unsigned): New decls.
6335 (long_to_cons, cons_to_long): Remove decls.
6336 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6337 (Fprimitive_undo): Use CONS_TO_INTEGER.
6338 * xfns.c (Fx_window_property): Likewise.
6339 * xselect.c: Include <limits.h>.
6340 (x_own_selection, selection_data_to_lisp_data):
6341 Use INTEGER_TO_CONS.
6342 (x_handle_selection_request, x_handle_selection_clear)
6343 (x_get_foreign_selection, Fx_disown_selection_internal)
6344 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6345 (lisp_data_to_selection_data): Use cons_to_unsigned.
6346 (x_fill_property_data): Use cons_to_signed.
6347 Report values out of range.
6349 Check for buffer and string overflow more precisely.
6350 * buffer.h (BUF_BYTES_MAX): New macro.
6351 * lisp.h (STRING_BYTES_MAX): New macro.
6352 * alloc.c (Fmake_string):
6353 * character.c (string_escape_byte8):
6354 * coding.c (coding_alloc_by_realloc):
6355 * doprnt.c (doprnt):
6356 * editfns.c (Fformat):
6358 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6359 since they may not be the same number.
6360 * editfns.c (Finsert_char):
6361 * fileio.c (Finsert_file_contents):
6362 Likewise for BUF_BYTES_MAX.
6364 * image.c: Use ptrdiff_t, not int, for sizes.
6365 (slurp_file): Switch from int to ptrdiff_t.
6367 (slurp_file): Check that file size fits in both size_t (for
6368 malloc) and ptrdiff_t (for sanity and safety).
6370 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6371 if b->modtime has its maximal value.
6373 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6375 Don't assume time_t can fit into int.
6376 * buffer.h (struct buffer.modtime): Now time_t, not int.
6377 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6378 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6380 Minor fixes for signed vs unsigned integers.
6381 * character.h (MAYBE_UNIFY_CHAR):
6382 * charset.c (maybe_unify_char):
6383 * keyboard.c (read_char, reorder_modifiers):
6384 XINT -> XFASTINT, since the integer must be nonnegative.
6385 * ftfont.c (ftfont_spec_pattern):
6386 * keymap.c (access_keymap, silly_event_symbol_error):
6387 XUINT -> XFASTINT, since the integer must be nonnegative.
6388 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6389 since it makes no difference and we prefer signed.
6390 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6391 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6394 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6396 * window.h (Fwindow_frame): Declare.
6398 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6400 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6401 (SPARE_MEMORY): Always define.
6402 (LARGE_REQUEST): Remove.
6403 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6405 2011-06-06 Martin Rudalics <rudalics@gmx.at>
6407 * lisp.h: Move EXFUNS for Fframe_root_window,
6408 Fframe_first_window and Fset_frame_selected_window to window.h.
6410 * window.h: Move EXFUNS for Fframe_root_window,
6411 Fframe_first_window and Fset_frame_selected_window here from
6414 * frame.c (Fwindow_frame, Fframe_first_window)
6415 (Fframe_root_window, Fframe_selected_window)
6416 (Fset_frame_selected_window): Move to window.c.
6417 (Factive_minibuffer_window): Move to minibuf.c.
6418 (Fother_visible_frames_p): New function.
6420 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6422 * window.c (decode_window, decode_any_window): Move up in code.
6423 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6424 (inhibit_frame_unsplittable): Remove unused variable.
6425 (Fwindow_buffer): Move up and rewrite doc-string.
6426 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6427 (Fwindow_prev): New functions.
6428 (Fwindow_frame): Move here from frame.c. Accept any window as
6430 (Fframe_root_window, Fframe_first_window)
6431 (Fframe_selected_window): Move here from frame.c. Accept frame
6432 or arbitrary window as argument. Update doc-strings.
6433 (Fminibuffer_window): Move up in code.
6434 (Fwindow_minibuffer_p): Move up in code and simplify.
6435 (Fset_frame_selected_window): Move here from frame.c.
6437 (Fselected_window, select_window, Fselect_window): Move up in
6438 code. Minor doc-string fixes.
6440 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6442 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6443 Do not assume that spare memory exists; that assumption is valid
6444 only if SYSTEM_MALLOC.
6445 (LARGE_REQUEST): New macro, so that the issue of large requests
6446 is separated from the issue of spare memory.
6448 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6450 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6453 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6455 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6458 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6460 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6462 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6464 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6465 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6467 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
6469 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6471 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
6473 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6474 (x_clipboard_manager_save): Add return value.
6475 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6477 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6478 Obey Vx_select_enable_clipboard_manager. Catch errors in
6479 x_clipboard_manager_save (Bug#8779).
6480 (Vx_select_enable_clipboard_manager): New variable.
6481 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
6483 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
6485 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6487 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6489 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6490 in the current matrix if keep_current_p is non-zero.
6492 2011-06-04 Eli Zaretskii <eliz@gnu.org>
6494 * bidi.c (bidi_level_of_next_char): Fix last change.
6496 2011-06-03 Eli Zaretskii <eliz@gnu.org>
6498 Support bidi reordering of text covered by display properties.
6500 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6501 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6502 (bidi_cache_search, bidi_cache_iterator_state)
6503 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6504 (bidi_level_of_next_char, bidi_move_to_visually_next):
6505 Support character positions inside a run of characters covered by a
6507 (bidi_paragraph_init, bidi_resolve_explicit_1)
6508 (bidi_level_of_next_char): Call bidi_fetch_char and
6509 bidi_fetch_char_advance instead of FETCH_CHAR and
6511 (bidi_init_it): Initialize new members.
6512 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6514 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6515 instead of using explicit *_CHAR codes.
6516 (bidi_resolve_explicit, bidi_resolve_weak):
6517 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6518 bidirectional text is supported only in multibyte buffers.
6519 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6520 it to initialize the frame_window_p member of struct bidi_it.
6521 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6522 (bidi_resolve_explicit, bidi_resolve_weak)
6523 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6524 bidi_it->nchars is non-positive.
6525 (bidi_level_of_next_char): Don't try to lookup the cache for the
6526 next/previous character if nothing is cached there yet, or if we
6527 were just reseat()'ed to a new position.
6529 * xdisp.c (set_cursor_from_row): Set start and stop points
6530 according to the row's direction when priming the loop that looks
6531 for the glyph on which to display cursor.
6532 (single_display_spec_intangible_p): Function deleted.
6533 (display_prop_intangible_p): Reimplement to call
6534 handle_display_spec instead of single_display_spec_intangible_p.
6535 Accept 3 additional arguments needed by handle_display_spec.
6536 This fixes incorrect cursor motion across display property with complex
6537 values: lists, `(when COND...)' forms, etc.
6538 (single_display_spec_string_p): Support property values that are
6539 lists with the argument STRING its top-level element.
6540 (display_prop_string_p): Fix the condition for processing a
6541 property that is a list to be consistent with handle_display_spec.
6542 (handle_display_spec): New function, refactored from the
6543 last portion of handle_display_prop.
6544 (compute_display_string_pos): Accept additional argument
6545 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6546 value of a `display' property is a "replacing spec".
6547 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6548 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6549 the display property, but just return a value indicating whether
6550 the display property will replace the characters it covers.
6551 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6552 frame_window_p members of struct bidi_it.
6553 (compute_display_string_pos, compute_display_string_end):
6555 (push_it): Accept second argument POSITION, where pop_it should
6556 jump to continue iteration.
6557 (reseat_1): Initialize bidi_it.disp_pos.
6559 * keyboard.c (adjust_point_for_property): Adjust the call to
6560 display_prop_intangible_p to its new signature.
6562 * dispextern.h (struct bidi_it): New member frame_window_p.
6563 (bidi_init_it): Update prototypes.
6564 (display_prop_intangible_p): Update prototype.
6565 (compute_display_string_pos, compute_display_string_end):
6567 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6570 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6572 Malloc failure behavior now depends on size of allocation.
6573 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6574 * lisp.h: Change signatures accordingly.
6575 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6576 All callers changed. (Bug#8762)
6578 * gnutls.c: Use Emacs's memory allocators.
6579 Without this change, the gnutls library would invoke malloc etc.
6580 directly, which causes problems on non-SYNC_INPUT hosts, and which
6581 runs afoul of improving memory_full behavior. (Bug#8761)
6582 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6583 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6584 xfree instead of the default malloc, realloc, free.
6585 (Fgnutls_boot): No need to check for memory allocation failure,
6586 since xmalloc does that for us.
6588 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6589 * category.c (hash_get_category_set):
6590 * ccl.c (ccl_driver):
6591 * charset.c (Fdefine_charset_internal):
6592 * charset.h (struct charset.hash_index):
6593 * composite.c (get_composition_id, gstring_lookup_cache)
6594 (composition_gstring_put_cache):
6595 * composite.h (struct composition.hash_index):
6596 * dispextern.h (struct image.hash):
6597 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6598 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6599 (hashfn_equal, hashfn_user_defined, make_hash_table)
6600 (maybe_resize_hash_table, hash_lookup, hash_put)
6601 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6602 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6603 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6604 * image.c (make_image, search_image_cache, lookup_image)
6605 (xpm_put_color_table_h):
6606 * lisp.h (struct Lisp_Hash_Table):
6607 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6608 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6609 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6610 * alloc.c (allocate_vectorlike):
6611 Check for overflow in vector size calculations.
6612 * ccl.c (ccl_driver):
6613 Check for overflow when converting EMACS_INT to int.
6614 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6615 need to be updated by these changes.
6616 * fns.c (make_hash_table, maybe_resize_hash_table):
6617 Check for integer overflow with large hash tables.
6618 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6619 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6620 (SXHASH_REDUCE): New macro.
6621 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6622 Use it instead of discarding useful hash info with large hash values.
6623 (sxhash_float): New function.
6624 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6625 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6626 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6627 Rewrite to use FIXNUM_BITS, as this simplifies things.
6628 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6629 Adjust signatures to match updated version of code.
6630 (consing_since_gc): Now EMACS_INT, since a single hash table can
6631 use more than INT_MAX bytes.
6633 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6635 Make it possible to build with GCC-4.6+ -O2 -flto.
6637 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6639 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6641 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6642 Call minibuffer-inactive-mode.
6644 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6646 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6647 Update dependencies.
6649 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6651 * data.c (init_data): Remove code for UTS, this system is not
6654 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6656 Don't force ./temacs to start in terminal mode.
6658 * frame.c (make_initial_frame): Initialize faces in all cases, not
6659 only when CANNOT_DUMP is defined.
6660 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6662 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6664 * dispnew.c (add_window_display_history): Use const for the string
6665 pointer. Remove declaration, not needed.
6667 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6669 Use 'inline', not 'INLINE'.
6670 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6671 * alloc.c, fontset.c (INLINE): Remove.
6672 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6673 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6674 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6675 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6676 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6678 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6680 Make it possible to run ./temacs.
6682 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6683 syms_of_callproc does the same thing. Remove test for
6684 "initialized", do it in the caller.
6685 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6687 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6689 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6690 (read_minibuf): Use get_minibuffer.
6691 (syms_of_minibuf): Use DEFSYM.
6692 (Qmetadata): New var.
6693 * data.c (Qbuffer): Don't make it static.
6694 (syms_of_data): Use DEFSYM.
6696 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6698 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6699 (CCL_CODE_MIN): New macro.
6701 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6703 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6705 * eval.c (Qdebug): Now static.
6706 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6707 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6708 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6710 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6712 * image.c: Various fixes to ImageMagick code comments.
6713 (Fimagemagick_types): Doc fix.
6715 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6717 Minor fixes prompted by GCC 4.6.0 warnings.
6719 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6721 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6722 (x_clipboard_manager_save_all): Move extern decl to ...
6723 * xterm.h: ... here, so that it can be checked for consistency.
6725 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6727 * xselect.c (x_clipboard_manager_save_frame)
6728 (x_clipboard_manager_save_all): New functions.
6729 (Fx_clipboard_manager_save): Lisp function deleted.
6731 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6732 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6734 * xterm.h: Update prototype.
6736 2011-05-28 William Xu <william.xwl@gmail.com>
6738 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6741 2011-05-28 Jim Meyering <meyering@redhat.com>
6743 Avoid a sign-extension bug in crypto_hash_function.
6744 * fns.c (to_uchar): Define.
6745 (crypto_hash_function): Use it to convert some newly-signed
6746 variables to unsigned, to avoid sign-extension bugs. For example,
6747 without this change, (md5 "truc") would evaluate to
6748 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6749 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6750 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6752 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6754 Integer overflow fixes.
6756 * dbusbind.c: Serial number integer overflow fixes.
6757 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6758 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6759 to hold a serial number that is too large for a fixnum.
6760 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6761 Check for serial numbers out of range. Decode any serial number
6762 that was so large that it became a float. (Bug#8722)
6764 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6765 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6766 Use XFASTINT rather than XUINT when numbers are nonnegative.
6767 (xd_append_arg, Fdbus_method_return_internal):
6768 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6769 arguments, check that Lisp number is nonnegative, rather than
6770 silently wrapping negative numbers around. (Bug#8722)
6771 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6774 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6776 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6778 ccl: Add integer overflow checks.
6779 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6780 (IN_INT_RANGE): New macros.
6781 (ccl_driver): Use them to check for integer overflow when
6782 decoding a CCL program. Many of the new checks are whether XINT (x)
6783 fits in int; it doesn't always, on 64-bit hosts. The new version
6784 doesn't catch all possible integer overflows, but it's an
6785 improvement. (Bug#8719)
6787 * alloc.c (make_event_array): Use XINT, not XUINT.
6788 There's no need for unsigned here.
6790 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6791 This follows up to the 2011-05-06 change that substituted uintptr_t
6792 for EMACS_INT. This case wasn't caught back then.
6794 Rework Fformat to avoid integer overflow issues.
6795 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6796 now (part of C89). Include <verify.h>.
6797 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6798 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6799 (Fformat): Avoid the prepass trying to compute sizes; it was only
6800 approximate and thus did not catch overflow reliably. Instead, walk
6801 through the format just once, formatting and computing sizes as we go,
6802 checking for integer overflow at every step, and allocating a larger
6803 buffer as needed. Keep track separately whether the format is
6804 multibyte. Keep only the most-recently calculated precision, rather
6805 than them all. Record whether each argument has been converted to
6806 string. Use EMACS_INT, not int, for byte and char and arg counts.
6807 Support field widths and precisions larger than INT_MAX. Avoid
6808 sprintf's undefined behavior with conversion specifications such as %#d
6809 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6810 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6811 formatting out-of-range floating point numbers with int
6814 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6816 * data.c: Avoid integer truncation in expressions involving floats.
6817 * data.c: Include <intprops.h>.
6818 (arith_driver): When there's an integer overflow in an expression
6819 involving floating point, convert the integers to floating point
6820 so that the resulting value does not suffer from catastrophic
6821 integer truncation. For example, on a 64-bit host (* 4
6822 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6823 Do not rely on undefined behavior after integer overflow.
6825 merge count_size_as_multibyte, parse_str_to_multibyte
6826 * character.c, character.h (count_size_as_multibyte):
6827 Rename from parse_str_to_multibyte; all uses changed.
6828 Check for integer overflow.
6829 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6830 since it's now a duplicate of the other. This is more of
6831 a character than a buffer op, so better that it's in character.c.
6832 * fns.c, print.c: Adjust to above changes.
6834 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6836 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6838 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6840 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6841 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6842 (x_clipboard_manager_save): Now static.
6843 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6845 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6846 (crypto_hash_function): Now static.
6847 Fix pointer signedness problems. Avoid unnecessary initializations.
6849 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6851 * termhooks.h (Vselection_alist): Make it terminal-local.
6853 * terminal.c (create_terminal): Initialize it.
6855 * xselect.c: Support for clipboard managers.
6856 (Vselection_alist): Move to termhooks.h as terminal-local var.
6857 (LOCAL_SELECTION): New macro.
6858 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6859 (symbol_to_x_atom): Remove gratuitous arg.
6860 (x_handle_selection_request, lisp_data_to_selection_data)
6861 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6862 (x_own_selection, x_get_local_selection, x_convert_selection):
6863 New arg, specifying work frame. Use terminal-local Vselection_alist.
6864 (some_frame_on_display): Delete unused function.
6865 (Fx_own_selection_internal, Fx_get_selection_internal)
6866 (Fx_disown_selection_internal, Fx_selection_owner_p)
6867 (Fx_selection_exists_p): New optional frame arg.
6868 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6869 (x_handle_selection_clear): Don't treat other terminals with the
6870 same keyboard specially. Use the terminal-local Vselection_alist.
6871 (x_clear_frame_selections): Use Frun_hook_with_args.
6873 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6875 * xterm.h: Add support for those atoms.
6877 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6879 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6880 (converted_selections, conversion_fail_tag): New global variables.
6881 (x_selection_request_lisp_error): Free the above.
6882 (x_get_local_selection): Remove unnecessary code.
6883 (x_reply_selection_request): Args changed; handle arbitrary array
6884 of converted selections stored in converted_selections.
6885 Separate the XChangeProperty and SelectionNotify steps.
6886 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6887 (x_convert_selection): New function.
6888 (x_handle_selection_event): Simplify.
6889 (x_get_foreign_selection): Don't ignore incoming requests while
6890 waiting for an answer; this will fail when we implement
6891 SAVE_TARGETS, and seems unnecessary anyway.
6892 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6893 (Vx_sent_selection_functions): Doc fix.
6895 2011-05-26 Leo Liu <sdl.web@gmail.com>
6897 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6899 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6901 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6903 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6904 for fringe update if it has periodic bitmap.
6905 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6906 and fringe_bitmap_periodic_p.
6908 * fringe.c (get_fringe_bitmap_data): New function.
6909 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6910 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6911 row. Mark glyph row for fringe update if periodicity changed.
6913 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6914 for fringe update unless it has periodic bitmap.
6916 2011-05-25 Kenichi Handa <handa@m17n.org>
6918 * xdisp.c (get_next_display_element): Set correct it->face_id for
6919 a static composition.
6921 2011-05-24 Leo Liu <sdl.web@gmail.com>
6924 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6926 * fns.c (crypto_hash_function, Fsha1): New function.
6927 (Fmd5): Use crypto_hash_function.
6928 (syms_of_fns): Add Ssha1.
6930 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6932 * gnutls.c: Remove unused macros.
6933 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6934 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6935 Remove macros that are defined and never used.
6936 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6938 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6940 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6941 (Fx_get_selection_internal): Minor cleanup.
6942 (Fx_own_selection_internal): Rename arguments for consistency with
6945 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6947 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6949 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6951 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6953 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6955 * dispnew.c (scrolling_window): Don't exclude the case that the
6956 last enabled row in the desired matrix touches the bottom boundary.
6958 2011-05-21 Glenn Morris <rgm@gnu.org>
6960 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6961 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6962 and add some more files.
6964 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6966 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6967 report_file_error introduced by the change from 2011-05-07.
6969 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6971 * systime.h (Time): Define only if emacs is defined.
6972 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6973 where the include path doesn't have X11/X.h by default. See
6974 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6976 2011-05-20 Kenichi Handa <handa@m17n.org>
6978 * composite.c (find_automatic_composition): Fix previous change.
6980 2011-05-20 Glenn Morris <rgm@gnu.org>
6982 * lisp.mk: New file, split from Makefile.in.
6983 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6984 (shortlisp): Remove.
6985 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6987 2011-05-19 Glenn Morris <rgm@gnu.org>
6989 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6990 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6991 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6992 (lisp): Set the order to that of loadup.el.
6993 (shortlisp): Make it a copy of $lisp.
6994 (SOME_MACHINE_LISP): Remove.
6995 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6996 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6998 2011-05-18 Kenichi Handa <handa@m17n.org>
7000 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
7001 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
7002 (find_automatic_composition): Mostly rewrite for efficiency.
7004 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
7006 * makefile.w32-in: Update dependencies.
7008 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
7010 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7011 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
7013 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
7015 Fix some integer overflow issues, such as string length overflow.
7017 * insdel.c (count_size_as_multibyte): Check for string overflow.
7019 * character.c (lisp_string_width): Check for string overflow.
7020 Use EMACS_INT, not int, for string indexes and lengths; in
7021 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
7022 the resulting string length overflows an EMACS_INT; instead,
7023 report a string overflow if no precision given. When checking for
7024 precision exhaustion, use a check that cannot possibly have
7025 integer overflow. (Bug#8675)
7026 * character.h (lisp_string_width): Adjust to new signature.
7028 * alloc.c (string_overflow): New function.
7029 (Fmake_string): Use it. This doesn't change behavior, but saves
7030 a few bytes and will simplify future changes.
7031 * character.c (string_escape_byte8): Likewise.
7032 * lisp.h (string_overflow): New decl.
7034 Fixups, following up to the user-interface timestamp change.
7035 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
7036 for UI timestamps, instead of unsigned long.
7037 * msdos.c (mouse_get_pos): Likewise.
7038 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
7039 * w32gui.h (Time): Define by including "systime.h" rather than by
7040 declaring it ourselves. (Bug#8664)
7042 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
7043 * image.c (clear_image_cache): Likewise.
7045 * term.c (term_mouse_position): Don't assume time_t wraparound.
7047 Be more systematic about user-interface timestamps.
7048 Before, the code sometimes used 'Time', sometimes 'unsigned long',
7049 and sometimes 'EMACS_UINT', to represent these timestamps.
7050 This change causes it to use 'Time' uniformly, as that's what X uses.
7051 This makes the code easier to follow, and makes it easier to catch
7052 integer overflow bugs such as Bug#8664.
7053 * frame.c (Fmouse_position, Fmouse_pixel_position):
7054 Use Time, not unsigned long, for user-interface timestamps.
7055 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
7056 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
7057 * keyboard.h (last_event_timestamp): Likewise.
7058 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
7059 * menu.h (xmenu_show): Likewise.
7060 * term.c (term_mouse_position): Likewise.
7061 * termhooks.h (struct input_event.timestamp): Likewise.
7062 (struct terminal.mouse_position_hook): Likewise.
7063 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
7064 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
7065 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
7066 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
7068 * menu.h, termhooks.h: Include "systime.h", for Time.
7070 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
7071 Don't assume that the difference between two unsigned long values
7072 can fit into an integer. At this point, we know button_down_time
7073 <= event->timestamp, so the difference must be nonnegative, so
7074 there's no need to cast the result if double-click-time is
7075 nonnegative, as it should be; check that it's nonnegative, just in
7076 case. This bug is triggered when events are more than 2**31 ms
7077 apart (about 25 days). (Bug#8664)
7079 * xselect.c (last_event_timestamp): Remove duplicate decl.
7080 (x_own_selection): Remove needless cast to unsigned long.
7082 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
7083 that always fit in int. Use a sentinel instead of a counter, to
7084 avoid a temp and to allay GCC's concerns about possible int overflow.
7085 * frame.h (struct frame): Use int for menu_bar_items_used
7086 instead of EMACS_INT, since it always fits in int.
7088 * menu.c (grow_menu_items): Check for int overflow.
7090 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
7092 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
7093 Before, the code was not consistent. These values cannot exceed
7094 2**31 - 1 so there's no need to make them unsigned.
7095 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
7096 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
7097 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
7099 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
7101 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
7102 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
7103 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
7104 presumably because the widths might not match.
7106 * window.c (size_window): Avoid needless test at loop start.
7108 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
7110 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
7112 2011-05-12 Drew Adams <drew.adams@oracle.com>
7114 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
7116 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7118 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
7119 `width' to `bar_area_x' and `bar_area_width', respectively.
7120 (x_scroll_run): Take account of fringe background extension.
7122 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
7123 Rename local vars `left' and `width' to `bar_area_x' and
7124 `bar_area_width', respectively.
7125 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
7126 background extension.
7128 2011-05-10 Jim Meyering <meyering@redhat.com>
7130 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
7132 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
7134 * image.c (Finit_image_library): Return t for built-in image types,
7135 like pbm and xbm. (Bug#8640)
7137 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
7139 * w32menu.c (set_frame_menubar): Fix submenu allocation.
7141 2011-05-07 Eli Zaretskii <eliz@gnu.org>
7143 * w32console.c (Fset_screen_color): Doc fix.
7144 (Fget_screen_color): New function.
7145 (syms_of_ntterm): Defsubr it.
7147 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
7148 unlink the temporary file if Fcall_process didn't create it in the
7150 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
7151 child process will be redirected to a file specified with `:file'.
7152 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
7153 cue to call_process_cleanup not to close that handle.
7155 2011-05-07 Ben Key <bkey76@gmail.com>
7157 * makefile.w32-in: The bootstrap-temacs rule now makes use of
7158 one of two shell specific rules, either bootstrap-temacs-CMD or
7159 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
7160 to the previous implementation of the bootstrap-temacs rule.
7161 The bootstrap-temacs-CMD rule is similar to the previous
7162 implementation of the bootstrap-temacs rule except that it
7163 makes use of the ESC_CFLAGS variable instead of the CFLAGS
7166 These changes, along with some changes to nt/configure.bat,
7167 nt/gmake.defs, and nt/nmake.defs, are required to extend my
7168 earlier fix to add support for --cflags and --ldflags options
7169 that include quotes so that it works whether make uses cmd or
7172 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
7174 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
7175 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
7177 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
7178 a string. Handle both cases.
7179 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
7180 (Fdbus_register_method): Use Qinvalid_function.
7182 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
7184 * makefile.w32-in: Update dependencies.
7185 (LISP_H): Add inttypes.h and stdin.h.
7186 (PROCESS_H): Add unistd.h.
7188 2011-05-06 Eli Zaretskii <eliz@gnu.org>
7190 * lread.c: Include limits.h (fixes the MS-Windows build broken by
7191 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
7193 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
7195 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
7197 * term.c (vfatal): Remove stray call to va_end.
7198 It's not needed and the C Standard doesn't allow it here anyway.
7200 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
7201 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
7203 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
7206 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
7208 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7210 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
7212 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
7214 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
7216 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
7217 * charset.c (Fdefine_charset_internal): Don't initialize
7218 charset.code_space[15]. The value was garbage, on hosts with
7219 32-bit int (Bug#8600).
7221 * lread.c (read_integer): Be more consistent with string-to-number.
7222 Use string_to_number to do the actual conversion; this avoids
7223 rounding errors and fixes some other screwups. Without this fix,
7224 for example, #x1fffffffffffffff was misread as -2305843009213693952.
7225 (digit_to_number): Move earlier, for benefit of read_integer.
7226 Return -1 if the digit is out of range for the base, -2 if it is
7227 not a digit in any supported base. (Bug#8602)
7229 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
7231 * dispnew.c (scrolling_window): Return 1 if we scrolled,
7232 to match comment at start of function. This also removes a
7233 GCC warning about overflow in a 32+64-bit port.
7235 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
7237 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
7238 Reported by Stefan Monnier in
7239 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
7240 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7241 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
7243 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
7244 (EMACS_UINTPTR): Likewise, with uintptr_t.
7246 * lisp.h: Prefer 64-bit EMACS_INT if available.
7247 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
7248 on 32-bit hosts that have 64-bit int, so that they can access
7250 However, temporarily disable this change unless the temporary
7251 symbol WIDE_EMACS_INT is defined.
7253 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
7255 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
7256 This removes an assumption that EMACS_INT and long are the same
7257 width as pointers. The assumption is true for Emacs porting targets
7258 now, but we want to make other targets possible.
7259 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
7260 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
7261 In the rest of the code, change types of integers that hold casted
7262 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
7263 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
7264 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
7265 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
7266 No need to cast type when ORing.
7267 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
7268 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
7269 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
7270 assume EMACS_INT is the same width as char *.
7271 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
7272 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
7273 Remove no-longer-needed casts.
7274 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
7275 (xg_tool_bar_help_callback, xg_make_tool_item):
7276 Use EMACS_INTPTR to hold an integer
7277 that will be cast to void *; this can avoid a GCC warning
7278 if EMACS_INT is not the same width as void *.
7279 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
7280 * xdisp.c (display_echo_area_1, resize_mini_window_1):
7281 (current_message_1, set_message_1):
7282 Use a local to convert to proper width without a cast.
7283 * xmenu.c (dialog_selection_callback): Likewise.
7285 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
7286 Also, don't assume VALBITS / RAND_BITS is less than 5,
7287 and don't rely on undefined behavior when shifting a 1 left into
7289 * lisp.h (get_random): Change signature to match.
7291 * lread.c (hash_string): Use size_t, not int, for hash computation.
7292 Normally we prefer signed values; but hashing is special, because
7293 it's better to use unsigned division on hash table sizes so that
7294 the remainder is nonnegative. Also, size_t is the natural width
7295 for hashing into memory. The previous code used 'int', which doesn't
7296 retain enough info to hash well into very large tables.
7297 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
7299 * dbusbind.c: Don't possibly lose pointer info when converting.
7300 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7301 Use XPNTR rather than XHASH, so that the high-order bits of
7302 the pointer aren't lost when converting through void *.
7304 * eval.c (Fautoload): Don't double-shift a pointer.
7306 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
7308 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
7310 * gnutls.c (DEF_GNUTLS_FN):
7311 * image.c (DEF_IMGLIB_FN): Make function pointers static.
7313 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7315 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
7318 2011-05-05 Eli Zaretskii <eliz@gnu.org>
7320 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
7321 New version that can reserve upto 2GB of heap space.
7323 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
7325 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7327 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7329 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7330 `gnutls_certificate_set_x509_key_file'.
7332 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
7334 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7335 Update dependencies.
7337 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7339 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7340 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7341 Remove unused parameter `fildes'.
7342 * process.c (read_process_output, send_process): Don't pass it.
7344 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7346 Fix previous change: the library cache is defined in w32.c.
7347 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7348 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7350 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7352 Implement dynamic loading of GnuTLS on Windows.
7354 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7355 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7356 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7359 * gnutls.c (Qgnutls_dll): Define.
7360 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7361 (gnutls_*): Declare function pointers.
7362 (init_gnutls_functions): New function to initialize function pointers.
7363 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7364 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7365 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7366 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7367 (emacs_gnutls_write, emacs_gnutls_read)
7368 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7369 (Fgnutls_available_p): New function.
7370 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7371 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7372 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7374 * image.c: Include w32.h.
7375 (Vimage_type_cache): Delete.
7376 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7377 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7378 (w32_delayed_load): Move to w32.c.
7380 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7382 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7383 (w32_delayed_load): Move from image.c. When loading a library, record
7384 its filename in the :loaded-from property of the library id.
7385 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7386 Initialize and staticpro them.
7387 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7389 * process.c: Include lisp.h before w32.h, not after.
7390 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7391 instead of gnutls_record_check_pending.
7393 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7395 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7397 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7398 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7401 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7403 * xterm.c (x_set_frame_alpha): Do not set property on anything
7404 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7406 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7408 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7410 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7412 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7413 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7414 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7415 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7416 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7417 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7418 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7419 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7420 (Qgnutls_bootprop_callbacks_verify): Make static.
7422 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7424 * callproc.c: Indentation fixup.
7426 * sysdep.c (wait_for_termination_1): Make static.
7427 (wait_for_termination, interruptible_wait_for_termination):
7428 Move after wait_for_termination_1.
7430 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7432 * sysdep.c (interruptible_wait_for_termination): New function
7433 which is like wait_for_termination, but allows keyboard
7436 * callproc.c (Fcall_process): Add (:file "file") as an option for
7438 (Fcall_process_region): Ditto.
7440 2011-04-30 Eli Zaretskii <eliz@gnu.org>
7442 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7443 rather than `XVECTOR (FOO)->size'.
7445 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7446 inttypes.h, as a gnulib replacement is used if it not available in
7449 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7451 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7452 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7453 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7455 * coding.c (coding_alloc_by_realloc): Error out if destination
7456 will grow beyond MOST_POSITIVE_FIXNUM.
7457 (decode_coding_emacs_mule): Abort if there isn't enough place in
7458 charbuf for the composition carryover bytes. Reserve an extra
7459 space for up to 2 characters produced in a loop.
7460 (decode_coding_iso_2022): Abort if there isn't enough place in
7461 charbuf for the composition carryover bytes.
7463 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7465 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7466 aborting when %lld or %lll format is passed.
7467 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7468 %llo or %llx format is passed. (Bug#8545)
7470 * window.c (window_scroll_line_based): Use a marker instead of
7471 simple variables to record original value of point. (Bug#7952)
7473 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7474 produced by %s or %c overflows available buffer space. (Bug#8545)
7476 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7478 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
7479 (SIZE_MAX): Move defn after all includes, as they might #define it.
7481 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7483 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7485 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7487 * keyboard.c (Qdelayed_warnings_hook): Define.
7488 (command_loop_1): Run `delayed-warnings-hook'
7489 if Vdelayed_warnings_list is non-nil.
7490 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7491 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7493 2011-04-28 Eli Zaretskii <eliz@gnu.org>
7495 * doprnt.c (doprnt): Don't return value smaller than the buffer
7496 size if the message was truncated. (Bug#8545).
7498 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7500 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7501 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7503 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7505 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7507 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7509 * makefile.w32-in: Update dependencies.
7511 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7513 Improve `doprnt' and its usage. (Bug#8545)
7514 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7515 `format_end'. Remove support for %l as a conversion specifier.
7516 Don't use xrealloc. Improve diagnostics when the %l size modifier
7517 is used. Update the commentary.
7519 * eval.c (verror): Simplify calculation of size_t.
7521 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7524 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7526 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7529 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7531 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7532 This makes this file independent of the recent pseudovector change.
7534 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7536 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7538 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7539 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7540 Remove unused local.
7541 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7543 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7544 GCC 4.6.0 optimizes based on type-based alias analysis.
7545 For example, if b is of type struct buffer * and v of type struct
7546 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7547 != &v->size, and therefore "v->size = 1; b->size = 2; return
7548 v->size;" must therefore return 1. This assumption is incorrect
7549 for Emacs, since it type-puns struct Lisp_Vector * with many other
7550 types. To fix this problem, this patch adds a new type struct
7551 vectorlike_header that documents the constraints on layout of vectors
7552 and pseudovectors, and helps optimizing compilers not get fooled
7553 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7554 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7555 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7557 (XSETPVECTYPE): Rewrite in terms of new macro.
7558 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7559 This is a bit clearer, and further avoids the possibility of
7560 undesirable aliasing.
7561 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7562 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7563 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7564 since Lisp_Subr is a special case (no "next" field).
7565 (ASIZE): Now uses header.size rather than size.
7566 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7567 to avoid the hassle of writing XVECTOR (foo)->header.size.
7568 (struct vectorlike_header): New type.
7569 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7570 object, to help avoid aliasing.
7571 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7572 (SUBRP): Likewise, since Lisp_Subr is a special case.
7573 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7574 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7575 (struct Lisp_Hash_Table): Combine first two members into a single
7576 struct vectorlike_header member. All uses of "size" and "next" members
7577 changed to be "header.size" and "header.next".
7578 * buffer.h (struct buffer): Likewise.
7579 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7580 * frame.h (struct frame): Likewise.
7581 * process.h (struct Lisp_Process): Likewise.
7582 * termhooks.h (struct terminal): Likewise.
7583 * window.c (struct save_window_data, struct saved_window): Likewise.
7584 * window.h (struct window): Likewise.
7585 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7586 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7587 * buffer.c (init_buffer_once): Likewise.
7588 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7590 * process.c (Fformat_network_address): Use local var for size,
7593 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7595 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7596 * data.c (atof): Remove decl; no longer used or needed.
7597 (digit_to_number): Move to lread.c.
7598 (Fstring_to_number): Use new string_to_number function, to be
7599 consistent with how the Lisp reader treats infinities and NaNs.
7600 Do not assume that floating-point numbers represent EMACS_INT
7601 without losing information; this is not true on most 64-bit hosts.
7602 Avoid double-rounding errors, by insisting on integers when
7603 parsing non-base-10 numbers, as the documentation specifies.
7604 * lisp.h (string_to_number): New decl, replacing ...
7605 (isfloat_string): Remove.
7606 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7607 (read1): Do not accept +. and -. as integers; this
7608 appears to have been a coding error. Similarly, do not accept
7609 strings like +-1e0 as floating point numbers. Do not report
7610 overflow for integer overflows unless the base is not 10 which
7611 means we have no simple and reliable way to continue.
7612 Break out the floating-point parsing into a new
7613 function string_to_number, so that Fstring_to_number parses
7614 floating point numbers consistently with the Lisp reader.
7615 (digit_to_number): Move here from data.c. Make it static inline.
7616 (E_CHAR, EXP_INT): Remove, replacing with ...
7617 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7618 (string_to_number): New function, replacing isfloat_string.
7619 This function checks for valid syntax and produces the resulting
7620 Lisp float number too. Rework it so that string-to-number
7621 no longer mishandles examples like "1.0e+". Use strtoumax,
7622 so that overflow for non-base-10 numbers is reported only when
7623 there's no portable and simple way to convert to floating point.
7625 * textprop.c (set_text_properties_1): Rewrite for clarity,
7626 and to avoid GCC warning about integer overflow.
7628 * intervals.h (struct interval): Use EMACS_INT for members
7629 where EMACS_UINT might cause problems. See
7630 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7631 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7632 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7634 (offset_intervals): Tell GCC not to worry about length overflow
7635 when negating a negative length.
7637 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7638 (overrun_check_free): Likewise.
7640 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7641 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7644 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7645 (gnutls_make_error): Rename local to avoid shadowing.
7646 (gnutls_emacs_global_deinit): ifdef out; not used.
7647 (Fgnutls_boot): Use const for pointer to readonly storage.
7648 Comment out unused local. Fix pointer signedness problems.
7650 * lread.c (openp): Don't stuff size_t into an 'int'.
7651 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7652 about possible signed overflow.
7654 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7655 (GDK_KEY_g): Don't define if already defined.
7656 (xg_prepare_tooltip): Avoid pointer signedness problem.
7657 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7659 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7660 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7662 * xfns.c (Fx_window_property): Simplify a bit,
7663 to make a bit faster and to avoid GCC 4.6.0 warning.
7664 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7666 * fns.c (internal_equal): Don't assume size_t fits in int.
7668 * alloc.c (compact_small_strings): Tighten assertion a little.
7670 Replace pEd with more-general pI, and fix some printf arg casts.
7671 * lisp.h (pI): New macro, generalizing old pEd macro to other
7672 conversion specifiers. For example, use "...%"pI"d..." rather
7673 than "...%"pEd"...".
7674 (pEd): Remove. All uses replaced with similar uses of pI.
7675 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7676 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7677 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7678 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7679 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7680 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7681 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7683 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7684 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7685 * print.c (safe_debug_print, print_object): Likewise.
7686 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7688 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7689 avoiding the 0 flag, which is not portable.
7690 * process.c (Fmake_network_process): Use pI to avoid cast.
7691 * region-cache.c (pp_cache): Likewise.
7692 * xdisp.c (decode_mode_spec): Likewise.
7693 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7694 behavior on 64-bit hosts with printf arg.
7695 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7696 (x_stop_queuing_selection_requests): Likewise.
7697 (x_get_window_property): Don't truncate byte count to an 'int'
7700 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7701 here, since it parses constructs like leading '-' and spaces,
7702 which are not wanted; and it overflows with large numbers.
7703 Instead, simply match F[0-9]+, which is what is wanted anyway.
7705 * alloc.c: Remove unportable assumptions about struct layout.
7706 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7707 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7708 (allocate_vectorlike, make_pure_vector): Use the new macros,
7709 plus offsetof, to remove unportable assumptions about struct layout.
7710 These assumptions hold on all porting targets that I know of, but
7711 they are not guaranteed, they're easy to remove, and removing them
7712 makes further changes easier.
7714 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7715 This doesn't fix a bug but makes the code clearer.
7716 (string_overrun_cookie): Now const. Use initializers that
7717 don't formally overflow signed char, to avoid warnings.
7718 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7719 can cause Emacs to crash when string overrun checking is enabled.
7720 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7721 multiple of sizeof (EMACS_INT); it need not be, if
7722 alignof(EMACS_INT) < sizeof (EMACS_INT).
7723 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7725 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7727 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7729 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7731 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7732 supposed to be handshaking. (Bug#8556)
7733 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7735 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7737 * lisp.h (Qdebug): List symbol.
7738 * eval.c (Qdebug): Restore global linkage.
7739 * keyboard.c (debug-on-event): New variable.
7740 (handle_user_signal): Break into debugger when debug-on-event
7741 matches the current signal symbol.
7743 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7745 * alloc.c (check_sblock, check_string_bytes)
7746 (check_string_free_list): Convert to standard C.
7748 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7750 * w32.c (emacs_gnutls_push): Fix typo.
7752 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7754 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7755 "cast to pointer from integer of different size".
7757 Improve doprnt and its use in verror. (Bug#8545)
7758 * doprnt.c (doprnt): Document the set of format control sequences
7759 supported by the function. Use SAFE_ALLOCA instead of always
7762 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7763 is one byte too soon. Don't use xrealloc; instead xfree and
7766 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7768 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7771 * gnutls.c: Renamed global_initialized to
7772 gnutls_global_initialized. Added internals for the
7773 :verify-hostname-error, :verify-error, and :verify-flags
7774 parameters of `gnutls-boot' and documented those parameters in the
7775 docstring. Start callback support.
7776 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7777 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7778 on error. Return error code.
7779 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7780 (emacs_gnutls_read): Likewise.
7781 (Fgnutls_boot): Return handshake error code.
7782 (emacs_gnutls_handle_error): New function.
7783 (wsaerror_to_errno): Likewise.
7785 * w32.h (emacs_gnutls_pull): Add prototype.
7786 (emacs_gnutls_push): Likewise.
7788 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7789 (emacs_gnutls_push): Likewise.
7791 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7793 * process.c (wait_reading_process_output): Check if GnuTLS
7794 buffered some data internally if no FDs are set for TLS
7797 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7798 (LIBS): Link to USER_LIBS.
7799 ($(BLD)/gnutls.$(0)): New target.
7801 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7803 * xdisp.c (handle_single_display_spec): Rename the
7804 display_replaced_before_p argument into display_replaced_p, to
7805 make it consistent with the commentary. Fix typos in the
7808 * textprop.c (syms_of_textprop): Remove dead code.
7809 (copy_text_properties): Delete obsolete commentary about an
7810 interface that was deleted long ago. Fix typos in the description
7813 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7814 to changes in oldXMenu/XMenu.h from 2011-04-16.
7815 <menu_help_message, prev_menu_help_message>: Constify.
7816 (IT_menu_make_room): menu->help_text is now `const char **';
7819 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7820 to changes in oldXMenu/XMenu.h from 2011-04-16.
7821 (struct XMenu): Declare `help_text' `const char **'.
7823 * xfaces.c <Qunspecified>: Make extern again.
7825 * syntax.c: Include sys/types.h before including regex.h, as
7828 * doc.c (get_doc_string): Improve the format passed to `error'.
7830 * doprnt.c (doprnt): Improve commentary.
7832 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7834 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7837 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7838 changes in globals.h immediately force recompilation.
7839 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7840 $(CURDIR)/s/ms-w32.h.
7841 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7843 * character.c (Fchar_direction): Function deleted.
7844 (syms_of_character): Don't defsubr it.
7845 <char-direction-table>: Deleted.
7847 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7849 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7850 * doprnt.c: Include limits.h.
7851 (SIZE_MAX): New macro.
7852 (doprnt): Return a size_t value. 2nd arg is now size_t.
7853 Many local variables are now size_t instead of int or unsigned.
7854 Improve overflow protection. Support `l' modifier for integer
7855 conversions. Support %l conversion. Don't assume an EMACS_INT
7856 argument for integer conversions and for %c.
7858 * lisp.h (doprnt): Restore prototype.
7860 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7863 * Makefile.in (base_obj): Add back doprnt.o.
7865 * deps.mk (doprnt.o): Add back prerequisites.
7866 (callint.o): Depend on character.h.
7868 * eval.c (internal_lisp_condition_case): Include the handler
7869 representation in the error message.
7870 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7871 when breaking from the loop.
7873 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7875 * callint.c (Fcall_interactively): When displaying error message
7876 about invalid control letter, pass the character's codepoint, not
7877 a pointer to its multibyte form. Improve display of the character
7878 in octal and display also its hex code.
7880 * character.c (char_string): Use %x to display the (unsigned)
7881 codepoint of an invalid character, to avoid displaying a bogus
7884 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7885 `error', not SYMBOL_NAME itself.
7887 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7888 character arguments to `error'.
7890 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7891 to `error' in error message about FINAL_CHAR argument. Make sure
7892 FINAL_CHAR is a character, and use %c when it is passed as
7893 argument to `error'.
7895 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7897 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7899 * w32.c: Include <time.h>.
7900 (sys_localtime): New function.
7902 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7904 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7906 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7908 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7910 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7913 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7915 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7916 gl_state.e_property when gl_state.object is Qt.
7918 * insdel.c (make_gap_larger): Remove limitation of buffer size
7921 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7923 * xdisp.c (lookup_glyphless_char_display)
7924 (produce_glyphless_glyph): Handle cons cell entry in
7925 glyphless-char-display.
7926 (Vglyphless_char_display): Document it.
7928 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7929 glyphless-char-display.
7931 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7933 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7935 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7937 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7938 definition for no-X builds.
7940 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7942 Static checks with GCC 4.6.0 and non-default toolkits.
7944 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7946 * process.c (keyboard_bit_set): Define only if SIGIO.
7947 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7948 (send_process): Repair possible setjmp clobbering.
7950 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7952 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7954 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7956 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7957 Define only if needed.
7959 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7960 by pacifying GCC about it. Maybe it's time to retire it?
7961 * xfaces.c (USG, __TIMEVAL__): Likewise.
7963 * dispextern.h (struct redisplay_interface): Rename param
7965 * termhooks.h (struct terminal): Likewise.
7966 * xterm.c (xembed_send_message): Likewise.
7968 * insdel.c (make_gap_smaller): Define only if
7969 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7971 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7974 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7975 so that we aren't warned about unused symbols.
7977 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7979 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7981 * xfns.c (x_real_positions): Mark locals as initialized.
7983 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7985 * xterm.c: Fix problems found by static analysis with other toolkits.
7986 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7987 (x_dispatch_event): Declare static if USE_GTK, and
7988 define if USE_GTK || USE_X_TOOLKIT.
7989 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7990 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7991 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7992 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7994 * xmenu.c (menu_help_callback): Pointer type fixes.
7995 Use const pointers when pointing at readonly data. Avoid pointer
7997 (FALSE): Remove unused macro.
7998 (update_frame_menubar): Remove unused decl.
8000 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
8002 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
8003 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
8004 (single_menu_item): Rename local to avoid shadowing.
8006 * keyboard.c (make_lispy_event): Remove unused local var.
8008 * frame.c, frame.h (x_get_resource_string): Bring this back, but
8009 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
8011 * bitmaps: Change bitmaps from unsigned char back to the X11
8012 compatible char. Avoid the old compiler warnings about
8013 out-of-range initializers by using, for example, '\xab' rather
8016 * xgselect.c (xgselect_initialize): Check vs interface
8017 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
8019 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
8021 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
8022 to read-only memory.
8024 * fns.c (vector): Remove; this old hack is no longer needed.
8026 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
8028 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
8030 * xrdb.c (x_load_resources): Omit unused local.
8032 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8033 (x_window): Rename locals to avoid shadowing.
8034 (USG): Use the kludged USG macro, to pacify gcc.
8036 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
8037 (x_term_init): Remove local to avoid shadowing.
8039 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
8041 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
8042 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
8044 2011-04-16 Eli Zaretskii <eliz@gnu.org>
8046 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
8048 Fix regex.c, syntax.c and friends for buffers > 2GB.
8049 * syntax.h (struct gl_state_s): Declare character position members
8052 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
8054 * textprop.c (verify_interval_modification, interval_of):
8055 Declare arguments EMACS_INT.
8057 * intervals.c (adjust_intervals_for_insertion): Declare arguments
8060 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
8062 * indent.c (Fvertical_motion): Local variable it_start is now
8065 * regex.c (re_match, re_match_2, re_match_2_internal)
8066 (bcmp_translate, regcomp, regexec, print_double_string)
8067 (group_in_compile_stack, re_search, re_search_2, regex_compile)
8068 (re_compile_pattern, re_exec): Declare arguments and local
8069 variables `size_t' and `ssize_t' and return values `regoff_t', as
8071 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
8072 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
8073 <compile_stack_type>: `size' and `avail' are now `size_t'.
8075 * regex.h <regoff_t>: Use ssize_t, not int.
8076 (re_search, re_search_2, re_match, re_match_2): Arguments that
8077 specify buffer/string position and length are now ssize_t and
8078 size_t. Return type is regoff_t.
8080 2011-04-16 Ben Key <bkey76@gmail.com>
8082 * nsfont.m: Fixed bugs in ns_get_family and
8083 ns_descriptor_to_entity that were caused by using free to
8084 deallocate memory blocks that were allocated by xmalloc (via
8085 xstrdup). This caused Emacs to crash when compiled with
8086 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
8087 --enable-checking=xmallocoverrun). xfree is now used to
8088 deallocate these memory blocks.
8090 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
8092 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
8094 emacs_write: Accept and return EMACS_INT for sizes.
8095 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
8097 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
8098 Accept and return EMACS_INT.
8099 (emacs_gnutls_write): Return the number of bytes written on
8101 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
8102 (emacs_read, emacs_write): Remove check for negative size, as the
8103 Emacs source code has been audited now.
8104 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
8105 (emacs_read, emacs_write): Use it.
8106 * process.c (send_process): Adjust to the new signatures of
8107 emacs_write and emacs_gnutls_write. Do not attempt to store
8108 a byte offset into an 'int'; it might overflow.
8109 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
8111 * sound.c: Don't assume sizes fit in 'int'.
8112 (struct sound_device.period_size, alsa_period_size):
8113 Return EMACS_INT, not int.
8114 (struct sound_device.write, vox_write, alsa_write):
8115 Accept EMACS_INT, not int.
8116 (wav_play, au_play): Use EMACS_INT to store sizes and to
8117 record read return values.
8119 2011-04-15 Ben Key <bkey76@gmail.com>
8121 * keyboard.c (Qundefined): Don't declare static since it is used
8123 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
8124 static since they are used in nsfont.m.
8126 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
8128 * process.c (Qprocessp): Don't declare static.
8129 * lisp.h (Qprocessp): Declare again.
8131 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
8133 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
8135 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
8137 Improve C-level modularity by making more things 'static'.
8139 Don't publish debugger-only interfaces to other modules.
8140 * lisp.h (safe_debug_print, debug_output_compilation_hack):
8141 (verify_bytepos, count_markers): Move decls to the only modules
8143 * region-cache.h (pp_cache): Likewise.
8144 * window.h (check_all_windows): Likewise.
8145 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
8147 * sysdep.c (croak): Now static, if
8148 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
8149 * syssignal.h (croak): Declare only if not static.
8151 * alloc.c (refill_memory_reserve): Now static if
8152 !defined REL_ALLOC || defined SYSTEM_MALLOC.
8153 * lisp.h (refill_memory_reserve): Declare only if not static.
8155 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
8156 Define only if USE_LUCID.
8158 * xrdb.c (x_customization_string, x_rm_string): Now static.
8160 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
8161 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
8163 * xdisp.c (draw_row_with_mouse_face): Now static.
8164 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
8166 * window.h (check_all_windows): Mark externally visible.
8168 * window.c (window_deletion_count): Now static.
8170 * undo.c: Make symbols static if they're not exported.
8171 (last_undo_buffer, last_boundary_position, pending_boundary):
8174 * textprop.c (interval_insert_behind_hooks): Now static.
8175 (interval_insert_in_front_hooks): Likewise.
8177 * term.c: Make symbols static if they're not exported.
8178 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
8179 (max_frame_lines, tty_set_terminal_modes):
8180 (tty_reset_terminal_modes, tty_turn_off_highlight):
8181 (get_tty_terminal): Now static.
8182 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
8183 * termhooks.h (term_mouse_moveto): Do not declare if
8185 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
8186 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
8188 * sysdep.c: Make symbols static if they're not exported.
8189 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
8191 (sigprocmask_set, full_mask): Remove; unused.
8192 (wait_debugging): Mark as visible.
8193 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
8194 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
8196 * syntax.c (syntax_temp): Define only if !__GNUC__.
8198 * sound.c (current_sound_device, current_sound): Now static.
8200 * search.c (searchbufs, searchbuf_head): Now static.
8202 * scroll.c (scroll_cost): Remove; unused.
8203 * dispextern.h (scroll_cost): Remove decl.
8205 * region-cache.h (pp_cache): Mark as externally visible.
8207 * process.c: Make symbols static if they're not exported.
8208 (process_tick, update_tick, create_process, chan_process):
8209 (Vprocess_alist, proc_buffered_char, datagram_access):
8210 (fd_callback_data, send_process_frame, process_sent_to): Now static.
8211 (deactivate_process): Mark defn as static, as well as decl.
8212 * lisp.h (create_process): Remove decl.
8213 * process.h (chan_process, Vprocess_alist): Remove decls.
8215 * print.c: Make symbols static if they're not exported.
8216 (print_depth, new_backquote_output, being_printed, print_buffer):
8217 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
8218 (print_interval, print_number_index, initial_stderr_stream):
8220 * lisp.h (Fprinc): Remove decl.
8221 (debug_output_compilation_hack): Mark as externally visible.
8223 * sysdep.c (croak): Move decl from here to syssignal.h.
8224 * syssignal.h (croak): Put it here, so the API can be checked when
8225 'croak' is called from dissociate_if_controlling_tty.
8227 * minibuf.c: Make symbols static if they're not exported.
8228 (minibuf_save_list, choose_minibuf_frame): Now static.
8229 * lisp.h (choose_minibuf_frame): Remove decl.
8231 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
8233 * lread.c: Make symbols static if they're not exported.
8234 (read_objects, initial_obarray, oblookup_last_bucket_number):
8236 (make_symbol): Remove; unused.
8237 * lisp.h (initial_obarray, make_symbol): Remove decls.
8239 * keyboard.c: Make symbols static if they're not exported.
8240 (single_kboard, recent_keys_index, total_keys, recent_keys):
8241 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
8242 (this_single_command_key_start, echoing, last_auto_save):
8243 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
8244 (command_loop, echo_now, keyboard_init_hook, help_char_p):
8245 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
8246 (Vlispy_mouse_stem, double_click_count):
8248 (force_auto_save_soon): Define only if SIGDANGER.
8249 (ignore_mouse_drag_p): Now static if
8250 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
8251 (print_help): Remove; unused.
8252 (stop_character, last_timer_event): Mark as externally visible.
8253 * keyboard.h (ignore_mouse_drag_p): Declare only if
8254 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
8255 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
8256 * lisp.h (echoing): Remove decl.
8257 (force_auto_save_soon): Declare only if SIGDANGER.
8258 * xdisp.c (redisplay_window): Simplify code, to make it more
8259 obvious that ignore_mouse_drag_p is not accessed if !defined
8260 USE_GTK && !defined HAVE_NS.
8262 * intervals.c: Make symbols static if they're not exported.
8263 (merge_properties_sticky, merge_interval_right, delete_interval):
8265 * intervals.h (merge_interval_right, delete_interval): Remove decls.
8267 * insdel.c: Make symbols static if they're not exported.
8268 However, leave prepare_to_modify_buffer alone. It's never
8269 called from outside this function, but that appears to be a bug.
8270 (combine_after_change_list, combine_after_change_buffer):
8271 (adjust_after_replace, signal_before_change): Now static.
8272 (adjust_after_replace_noundo): Remove; unused.
8273 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
8274 (signal_before_change): Remove decls.
8276 * indent.c (val_compute_motion, val_vmotion): Now static.
8278 * image.c: Make symbols static if they're not exported.
8279 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
8281 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
8282 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
8284 * fringe.c (standard_bitmaps): Now static.
8285 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
8287 * frame.c: Make symbols static if they're not exported.
8288 (x_report_frame_params, make_terminal_frame): Now static.
8289 (get_frame_param): Now static, unless HAVE_NS.
8290 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
8291 (x_get_resource_string): Remove; not used.
8292 * frame.h (make_terminal_frame, x_report_frame_params):
8293 (x_get_resource_string); Remove decls.
8294 (x_fullscreen_adjust): Declare only if WINDOWSNT.
8295 * lisp.h (get_frame_param): Declare only if HAVE_NS.
8297 * font.c, fontset.c: Make symbols static if they're not exported.
8298 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
8299 (FACE_SUITABLE_FOR_CHAR_P): Use it.
8300 * font.c (font_close_object): Now static.
8301 * font.h (font_close_object): Remove.
8302 * fontset.c (FONTSET_OBJLIST): Remove.
8303 (free_realized_fontset) #if-0 the body, which does nothing.
8304 (face_suitable_for_char_p): #if-0, as it's never called.
8305 * fontset.h (face_suitable_for_char_p): Remove decl.
8306 * xfaces.c (face_at_string_position):
8307 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
8308 since 0 is always ASCII.
8310 * fns.c (weak_hash_tables): Now static.
8312 * fileio.c: Make symbols static if they're not exported.
8313 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
8314 (Vwrite_region_annotation_buffers): Now static.
8316 * eval.c: Make symbols static if they're not exported.
8317 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
8318 * lisp.h (backtrace_list): Remove decl.
8320 * emacs.c: Make symbols static if they're not exported.
8321 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8322 (fatal_error_code, fatal_error_signal_hook, standard_args):
8324 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8325 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8326 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8327 * lisp.h (fatal_error_signal_hook): Remove decl.
8328 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8330 * editfns.c: Move a (normally-unused) function to its only use.
8331 * editfns.c, lisp.h (get_operating_system_release): Remove.
8332 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8333 worth the hassle of breaking this out.
8335 * xterm.c: Make symbols static if they're not exported.
8336 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8337 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8338 (x_destroy_window, x_delete_display):
8340 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8341 (x_mouse_leave): Remove; unused.
8342 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8343 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8344 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8346 (x_mouse_leave): Declare only if WINDOWSNT.
8347 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8348 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8351 * ftxfont.c: Make symbols static if they're not exported.
8352 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8354 * font.h (ftxfont_driver): Likewise.
8356 * xfns.c: Make symbols static if they're not exported.
8357 (x_last_font_name, x_display_info_for_name):
8358 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8359 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8360 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8361 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8362 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8363 (last_show_tip_args): Now static.
8364 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8365 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8366 (x_screen_planes): Remove; unused.
8367 * dispextern.h (x_screen_planes): Remove decl.
8369 * dispnew.c: Make symbols static if they're not exported.
8370 * dispextern.h (redraw_garbaged_frames, scrolling):
8371 (increment_row_positions): Remove.
8372 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8373 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8375 (redraw_garbaged_frames): Remove; unused.
8377 * xfaces.c: Make symbols static if they're not exported.
8378 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8380 * xterm.h (defined_color): Remove decls.
8381 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8382 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8383 (menu_face_changed_default, defined_color, free_realized_face):
8384 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8385 (ascii_face_of_lisp_face): Remove; unused.
8387 * xdisp.c: Make symbols static if they're not exported.
8388 * dispextern.h (scratch_glyph_row, window_box_edges):
8389 (glyph_to_pixel_coords, set_cursor_from_row):
8390 (get_next_display_element, set_iterator_to_next):
8391 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8392 (show_mouse_face): Remove decls
8393 * frame.h (message_buf_print): Likewise.
8394 * lisp.h (pop_message, set_message, check_point_in_composition):
8396 * xterm.h (set_vertical_scroll_bar): Likewise.
8397 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8398 (message_buf_print, scratch_glyph_row, displayed_buffer):
8399 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8400 (get_next_display_element, show_mouse_face, window_box_edges):
8401 (frame_to_window_pixel_xy, check_point_in_composition):
8402 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8403 (glyph_to_pixel_coords): Remove; unused.
8405 * dired.c (file_name_completion): Now static.
8407 * dbusbind.c (xd_in_read_queued_messages): Now static.
8409 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8410 * data.c (circular_list_error): Remove.
8412 * commands.h (last_point_position, last_point_position_buffer):
8413 (last_point_position_window): Remove decls.
8414 * keyboard.c: Make these variables static.
8416 * coding.h (coding, code_convert_region, encode_coding_gap):
8418 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8419 (iso_code_class, detect_coding, code_convert_region): Now static.
8420 (encode_coding_gap): Remove; unused.
8422 * chartab.c (chartab_chars, chartab_bits): Now static.
8424 * charset.h (charset_iso_8859_1): Remove decl.
8425 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8428 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8429 * ccl.c (Vccl_program_table): Now static.
8430 (check_ccl_update): Remove; unused.
8432 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8433 * category.h: ... from here.
8434 * category.c (check_category_table, set_category_set): Now static.
8436 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8437 * lisp.h: Remove these decls.
8439 * buffer.c (buffer_count): Remove unused var.
8441 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8442 so that it's not optimized away.
8443 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8444 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8445 exported only to the debugger.
8447 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
8448 * atimer.h (run_all_atimers): Remove; not exported.
8450 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8451 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8452 was inaccessible from Lisp.
8453 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8454 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8456 alloc.c: Import and export fewer symbols, and remove unused items.
8457 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8459 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8460 it's not optimized away by whole-program optimization.
8461 (message_enable_multibyte, free_misc): Remove.
8462 (catchlist, handlerlist, mark_backtrace):
8463 Declare only if BYTE_MARK_STACK.
8464 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8465 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8466 (message_enable_multibyte): Remove decl.
8467 (free_misc, interval_free_list, float_block, float_block_index):
8468 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8469 (cons_free_list, last_marked_index):
8471 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8472 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8473 (mark_backtrace): Define only if BYTE_MARK_STACK.
8474 * xdisp.c (message_enable_multibyte): Now static.
8476 Declare Lisp_Object Q* variables to be 'static' if not exported.
8477 This makes it easier for human readers (and static analyzers)
8478 to see whether these variables are used from other modules.
8479 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8480 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8481 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8482 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8483 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8484 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8485 * xmenu.c, xselect.c:
8486 Declare Q* vars static if they are not used in other modules.
8487 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8488 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8489 Remove decls of unexported vars.
8490 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8492 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8494 Make Emacs functions such as Fatom 'static' by default.
8495 This makes it easier for human readers (and static analyzers)
8496 to see whether these functions can be called from other modules.
8497 DEFUN now defines a static function. To make the function external
8498 so that it can be used in other C modules, use the new macro DEFUE.
8499 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8500 (Finit_image_library):
8501 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8502 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8503 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8504 Remove decls, since these functions are now static.
8505 (Funintern, Fget_internal_run_time): New decls, since these functions
8506 were already external.
8508 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8509 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8510 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8511 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8512 * keyboard.c, keymap.c, lread.c:
8513 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8514 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8515 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8516 Mark functions with DEFUE instead of DEFUN,
8517 if they are used in other modules.
8518 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8519 decls for now-static functions.
8520 * buffer.h (Fdelete_overlay): Remove decl.
8521 * callproc.c (Fgetenv_internal): Mark as internal.
8522 * composite.c (Fremove_list_of_text_properties): Remove decl.
8523 (Fcomposition_get_gstring): New forward static decl.
8524 * composite.h (Fcomposite_get_gstring): Remove decl.
8525 * dired.c (Ffile_attributes): New forward static decl.
8526 * doc.c (Fdocumntation_property): New forward static decl.
8527 * eval.c (Ffetch_bytecode): New forward static decl.
8528 (Funintern): Remove extern decl; now in .h file where it belongs.
8529 * fileio.c (Fmake_symbolic_link): New forward static decl.
8530 * image.c (Finit_image_library): New forward static decl.
8531 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8532 * intervals.h (Fprevious_property_change):
8533 (Fremove_list_of_text_properties): Remove decls.
8534 * keyboard.c (Fthis_command_keys): Remove decl.
8535 (Fcommand_execute): New forward static decl.
8536 * keymap.c (Flookup_key): New forward static decl.
8537 (Fcopy_keymap): Now static.
8538 * keymap.h (Flookup_key): Remove decl.
8539 * process.c (Fget_process): New forward static decl.
8540 (Fprocess_datagram_address): Mark as internal.
8541 * syntax.c (Fsyntax_table_p): New forward static decl.
8542 (skip_chars): Remove duplicate decl.
8543 * textprop.c (Fprevious_property_change): New forward static decl.
8544 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8546 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8547 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8549 * editfns.c (Fformat): Remove unreachable code.
8551 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8553 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8556 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8558 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8559 when at ZV. (Bug#8487)
8561 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8563 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8565 * keyboard.c (parse_tool_bar_item): Likewise.
8566 * sound.c (sound_cleanup, alsa_close): Likewise.
8567 * termcap.c (tgetent): Likewise.
8568 * xfns.c (x_default_font_parameter): Likewise.
8569 * xsettings.c (read_and_apply_settings): Likewise.
8571 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8572 (overrun_check_free): Protoize.
8574 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8576 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8577 since callers should never pass a negative size.
8578 Change the signature to match that of plain 'read' and 'write'; see
8579 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8580 * lisp.h: Update prototypes of emacs_write and emacs_read.
8582 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8584 * xdisp.c (redisplay_window): Don't try to determine the character
8585 position of the scroll margin if the window start point w->startp
8586 is outside the buffer's accessible region. (Bug#8468)
8588 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8590 Fix write-region and its subroutines for buffers > 2GB.
8591 * fileio.c (a_write, e_write): Modify declaration of arguments and
8592 local variables to support buffers larger than 2GB.
8593 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8595 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8596 argument, local variables, and return value.
8598 * lisp.h: Update prototypes of emacs_write and emacs_read.
8600 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8602 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8604 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8606 Fix more problems found by GCC 4.6.0's static checks.
8608 * xdisp.c (vmessage): Use a better test for character truncation.
8610 * charset.c (load_charset_map): <, not <=, for optimization,
8611 and to avoid potential problems with integer overflow.
8612 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8613 * casetab.c (set_identity, shuffle): Likewise.
8614 * editfns.c (Fformat): Likewise.
8615 * syntax.c (skip_chars): Likewise.
8617 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8618 This also lets GCC 4.6.0 generate slightly better loop code.
8620 * callint.c (Fcall_interactively): <, not <=, for optimization.
8621 (Fcall_interactively): Count the number of arguments produced,
8622 not the number of arguments given. This is simpler and lets GCC
8623 4.6.0 generate slightly better code.
8625 * ftfont.c: Distingish more carefully between FcChar8 and char.
8626 The previous code passed unsigned char * to a functions like
8627 strlen and xstrcasecmp that expect char *, which does not
8628 conform to the C standard.
8629 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8630 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8631 char * when the C standard requires it.
8633 * keyboard.c (read_char): Remove unused var.
8635 * eval.c: Port to Windows vsnprintf (Bug#8435).
8637 (SIZE_MAX): Define if the headers do not.
8638 (verror): Do not give up if vsnprintf returns a negative count.
8639 Instead, grow the buffer. This ports to Windows vsnprintf, which
8640 does not conform to C99. Problem reported by Eli Zaretskii.
8641 Also, simplify the allocation scheme, by avoiding the need for
8642 calling realloc, and removing the ALLOCATED variable.
8644 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8646 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8647 But keep the doprint source code for now, as we might revamp it
8648 and use it again (Bug#8435).
8649 * lisp.h (doprnt): Remove.
8650 * Makefile.in (base_obj): Remove doprnt.o.
8651 * deps.mk (doprnt.o): Remove.
8653 error: Print 32- and 64-bit integers portably (Bug#8435).
8654 Without this change, on typical 64-bit hosts error ("...%d...", N)
8655 was used to print both 32- and 64-bit integers N, which relied on
8657 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8658 * lisp.h (error, verror): Mark as printf-like functions.
8659 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8660 Report overflow in size calculations when allocating printf buffer.
8661 Do not truncate output string at its first null byte.
8662 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8663 Truncate the output at a character boundary, since vsnprintf does not
8665 * charset.c (check_iso_charset_parameter): Convert internal
8666 character to string before calling 'error', since %c now has the
8668 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8669 overflow when computing char to be passed to 'error'. Do not
8670 pass Lisp_Object to 'error'; pass the integer instead.
8671 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8672 formatted with plain %d.
8674 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8676 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8678 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8680 * xterm.c (x_catch_errors): Remove duplicate declaration.
8682 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8684 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8686 2011-04-10 Jim Meyering <meyering@redhat.com>
8688 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8689 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8690 return ssize_t not "int", and use size_t as the buffer length.
8691 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8692 * gnutls.h: Update declarations.
8693 * process.c (read_process_output): Use ssize_t, to match.
8694 (send_process): Likewise.
8696 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8698 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8700 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8702 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8703 Use unsigned char, to match FcChar8 type definition.
8705 * xterm.c (handle_one_xevent):
8706 * xmenu.c (create_and_show_popup_menu):
8707 * xselect.c (x_decline_selection_request)
8708 (x_reply_selection_request): Avoid type-punned deref of X events.
8710 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8712 Fix some uses of `int' instead of EMACS_INT.
8713 * search.c (string_match_1, fast_string_match)
8714 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8715 (scan_buffer, find_next_newline_no_quit)
8716 (find_before_next_newline, search_command, Freplace_match)
8717 (Fmatch_data): Make some `int' variables be EMACS_INT.
8719 * xdisp.c (display_count_lines): 3rd argument and return value now
8720 EMACS_INT. All callers changed.
8721 (pint2hrstr): Last argument is now EMACS_INT.
8723 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8724 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8725 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8726 (decode_coding_utf_16, decode_coding_emacs_mule)
8727 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8728 (decode_coding_ccl, decode_coding_charset)
8729 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8730 (decode_coding_iso_2022, decode_coding_emacs_mule)
8731 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8732 <char_offset, last_offset>: Declare EMACS_INT.
8733 (encode_coding_utf_8, encode_coding_utf_16)
8734 (encode_coding_emacs_mule, encode_invocation_designation)
8735 (encode_designation_at_bol, encode_coding_iso_2022)
8736 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8737 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8739 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8740 (encode_invocation_designation): Last argument P_NCHARS is now
8742 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8743 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8745 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8748 * ccl.c (Fccl_execute_on_string): Declare some variables
8751 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8753 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8755 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8757 * process.c (Fformat_network_address): Doc fix.
8759 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8761 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8763 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8765 * keyboard.c (read_char): Call Lisp function help-form-show,
8766 instead of using internal_with_output_to_temp_buffer.
8767 (Qhelp_form_show): New var.
8768 (syms_of_keyboard): Use DEFSYM macro.
8770 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8772 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8774 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8776 * process.c (Flist_processes): Remove to Lisp.
8777 (list_processes_1): Delete.
8779 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8781 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8783 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8785 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8787 Fix more problems found by GCC 4.6.0's static checks.
8789 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8791 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8793 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8795 * xdisp.c (vmessage): Mark as a printf-like function.
8797 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8799 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8801 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8802 printf-like functions.
8803 (tiff_load): Add casts to remove these marks before passing them
8804 to system-supplied API.
8806 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8808 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8809 This avoids several warnings with gcc -Wstrict-overflow.
8810 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8811 directly, rather than having caller test rule sign. This avoids
8812 some unnecessary tests.
8813 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8814 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8815 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8817 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8818 (xfont_open): Avoid unnecessary tests.
8820 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8822 * composite.h, composite.c (composition_gstring_put_cache):
8823 Use EMACS_INT, not int, for length.
8825 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8826 breaking out part of COMPOSITION_DECODE_RULE.
8827 (COMPOSITION_DECODE_RULE): Use it.
8828 * composite.c (get_composition_id): Remove unused local vars,
8829 by using the new macro.
8831 * textprop.c (set_text_properties_1): Change while to do-while,
8832 since the condition is always true at first.
8834 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8835 (interval_deletion_adjustment): Return unsigned value.
8838 * process.c (list_processes_1, create_pty, read_process_output):
8839 (exec_sentinel): Remove vars that were set but not used.
8840 (create_pty): Remove unnecessary "volatile"s.
8841 (Fnetwork_interface_info): Avoid possibility of int overflow.
8842 (read_process_output): Do adaptive read buffering even if carryover.
8843 (read_process_output): Simplify nbytes computation if buffered.
8845 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8847 * syntax.c (scan_words): Remove var that was set but not used.
8848 (update_syntax_table): Use unsigned instead of int.
8850 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8851 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8852 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8854 * print.c (print_error_message): Avoid int overflow.
8856 * font.c (font_list_entities): Redo for clarity,
8857 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8859 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8860 (font_score): Avoid potential overflow in diff calculation.
8862 * fns.c (substring_both): Remove var that is set but not used.
8863 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8865 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8867 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8868 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8869 can always succeed if overflow has undefined behavior.
8871 * search.c (boyer_moore, wordify): Remove vars set but not used.
8872 (wordify): Omit three unnecessary tests.
8874 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8875 All callers changed. This avoids the need for an unused var.
8877 * casefiddle.c (casify_region): Remove var that is set but not used.
8879 * dired.c (file_name_completion): Remove var that is set but not used.
8881 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8883 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8884 (Finsert_file_contents): Remove unnecessary code checking fd.
8886 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8887 Check for integer overflow on size calculations.
8889 * buffer.c (Fprevious_overlay_change): Remove var that is set
8892 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8893 Remove vars that are set but not used.
8894 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8895 (timer_check_2): Mark vars as initialized.
8897 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8899 * image.c (lookup_image): Remove var that is set but not used.
8900 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8902 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8903 that are set but not used.
8905 * xfns.c (make_invisible_cursor): Don't return garbage
8906 if XCreateBitmapFromData fails (Bug#8410).
8908 * xselect.c (x_get_local_selection, x_handle_property_notify):
8909 Remove vars that are set but not used.
8911 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8912 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8914 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8915 Remove var that is set but not used.
8916 (scroll_bar_windows_size): Now size_t, not int.
8917 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8920 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8921 (map_tty_color) [!defined MSDOS]: Likewise.
8923 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8925 * coding.c: Remove vars that are set but not used.
8926 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8927 All callers changed.
8928 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8929 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8930 (decode_coding_charset): Remove vars that are set but not used.
8932 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8933 that is set but not used.
8935 * print.c (print_object): Remove var that is set but not used.
8937 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8938 The gnulib version avoids calling malloc in the usual case,
8939 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8940 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8941 * filelock.c (current_lock_owner): Likewise.
8942 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8943 * sysdep.c: Include allocator.h, careadlinkat.h.
8944 (emacs_no_realloc_allocator): New static constant.
8945 (emacs_readlink): New function.
8946 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8947 ../lib/careadlinkat.h.
8949 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8951 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8952 first non-nil return value).
8954 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8956 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8957 if not defined (Bug#8403).
8959 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8961 * xdisp.c (display_count_lines): Remove parameter `start',
8962 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8963 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8964 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8965 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8966 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8967 and thereabouts. All callers changed.
8968 (get_per_char_metric): Remove parameter `f', unused since
8969 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8971 2011-04-02 Jim Meyering <meyering@redhat.com>
8973 do not dereference NULL upon failed strdup
8974 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8975 (ns_get_family): Likewise.
8977 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8979 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8981 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8983 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8986 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8988 Add lexical binding.
8990 * window.c (Ftemp_output_buffer_show): New fun.
8991 (Fsave_window_excursion):
8992 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8994 * lread.c (lisp_file_lexically_bound_p): New function.
8995 (Fload): Bind Qlexical_binding.
8996 (readevalloop): Remove `evalfun' arg.
8997 Bind Qinternal_interpreter_environment.
8998 (Feval_buffer): Bind Qlexical_binding.
8999 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
9001 (syms_of_lread): Declare `lexical-binding'.
9003 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
9005 * keyboard.c (eval_dyn): New fun.
9006 (menu_item_eval_property): Use it.
9008 * image.c (parse_image_spec): Use Ffunctionp.
9010 * fns.c (concat, mapcar1): Accept byte-code-functions.
9012 * eval.c (Fsetq): Handle lexical vars.
9013 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
9014 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
9015 (FletX, Flet): Obey lexical binding.
9016 (Fcommandp): Handle closures.
9017 (Feval): New `lexical' arg.
9018 (eval_sub): New function extracted from Feval. Use it almost
9019 everywhere where Feval was used. Look up vars in lexical env.
9021 (Ffunctionp): Move from subr.el.
9022 (Ffuncall): Handle closures.
9023 (apply_lambda): Remove `eval_flags'.
9024 (funcall_lambda): Handle closures and new byte-code-functions.
9025 (Fspecial_variable_p): New function.
9026 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
9027 but without exporting it to Lisp.
9029 * doc.c (Fdocumentation, store_function_docstring):
9030 * data.c (Finteractive_form): Handle closures.
9032 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
9035 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
9037 (exec_byte_code): New function extracted from Fbyte_code to handle new
9038 calling convention for byte-code-functions. Add new byte-codes.
9040 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
9042 * alloc.c (Fmake_symbol): Init new `declared_special' field.
9044 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
9046 * xdisp.c (redisplay_internal): Fix prototype.
9048 2011-03-31 Eli Zaretskii <eliz@gnu.org>
9050 * xdisp.c (SCROLL_LIMIT): New macro.
9051 (try_scrolling): Use it when setting scroll_limit.
9052 Limit scrolling to 100 screen lines.
9053 (redisplay_window): Even when falling back on "recentering",
9054 position point in the window according to scroll-conservatively,
9055 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
9057 (try_scrolling): When point is above the window, allow searching
9058 as far as scroll_max, or one screenful, to compute vertical
9059 distance from PT to the scroll margin position. This prevents
9060 try_scrolling from unnecessarily failing when
9061 scroll-conservatively is set to a value slightly larger than the
9062 window height. Clean up the case of PT below the margin at bottom
9063 of window: scroll_max can no longer be INT_MAX. When aggressive
9064 scrolling is in use, don't let point enter the opposite scroll
9065 margin as result of the scroll.
9066 (syms_of_xdisp) <scroll-conservatively>: Document the
9067 threshold of 100 lines for never-recentering scrolling.
9069 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
9071 * dispextern.h (move_it_by_lines):
9072 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
9073 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
9074 (message_log_check_duplicate): Remove parameters `prev_bol' and
9075 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
9076 (redisplay_internal): Remove parameter `preserve_echo_area',
9077 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
9079 * indent.c (Fvertical_motion):
9080 * window.c (window_scroll_pixel_based, Frecenter):
9081 Don't pass `need_y_p' to `move_it_by_lines'.
9083 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
9085 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
9086 steal a few bits to be more compact.
9087 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
9088 Remove unneeded casts.
9090 * bytecode.c (Fbyte_code): CAR and CDR can GC.
9092 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
9094 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
9095 binding" message (bug#7967).
9097 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
9099 Fix more problems found by GCC 4.6.0's static checks.
9101 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
9102 Remove unused local var.
9104 * editfns.c (Fmessage_box): Remove unused local var.
9106 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
9107 (note_mode_line_or_margin_highlight, note_mouse_highlight):
9108 Omit unused local vars.
9109 * window.c (shrink_windows): Omit unused local var.
9110 * menu.c (digest_single_submenu): Omit unused local var.
9111 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
9112 Omit unused local var.
9114 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
9115 Don't assume string length fits in int.
9116 (keyremap_step, read_key_sequence): Use size_t for sizes.
9117 (read_key_sequence): Don't check last_real_key_start redundantly.
9119 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
9120 instead of alloca (Bug#8344).
9122 * eval.c (Fbacktrace): Don't assume nargs fits in int.
9123 (Fbacktrace_frame): Don't assume nframes fits in int.
9125 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
9127 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
9130 * term.c (produce_glyphless_glyph): Remove unnecessary test.
9132 * cm.c (calccost): Turn while-do into do-while, for clarity.
9134 * keyboard.c (syms_of_keyboard): Use the same style as later
9135 in this function when indexing through an array. This also
9136 works around GCC bug 48267.
9138 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
9140 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
9142 * chartab.c (sub_char_table_ref_and_range): Redo for slight
9143 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
9145 * keyboard.c, keyboard.h (num_input_events): Now size_t.
9146 This avoids undefined behavior on integer overflow, and is a bit
9147 more convenient anyway since it is compared to a size_t variable.
9149 Variadic C functions now count arguments with size_t, not int.
9150 This avoids an unnecessary limitation on 64-bit machines, which
9151 caused (substring ...) to crash on large vectors (Bug#8344).
9152 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
9153 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
9154 All variadic functions and their callers changed accordingly.
9155 (struct gcpro.nvars): Now size_t, not int. All uses changed.
9156 * data.c (arith_driver, float_arith_driver): Likewise.
9157 * editfns.c (general_insert_function): Likewise.
9158 * eval.c (struct backtrace.nargs, interactive_p)
9159 (internal_condition_case_n, run_hook_with_args, apply_lambda)
9160 (funcall_lambda, mark_backtrace): Likewise.
9161 * fns.c (concat): Likewise.
9162 * frame.c (x_set_frame_parameters): Likewise.
9163 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
9164 0 if not found, not -1. All callers changed.
9166 * alloc.c (garbage_collect): Don't assume stack size fits in int.
9167 (stack_copy_size): Now size_t, not int.
9168 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
9170 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
9172 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
9173 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9174 All callers changed.
9176 * lisp.h (multibyte_char_to_unibyte):
9177 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
9178 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9179 * character.h (CHAR_TO_BYTE8):
9180 * cmds.c (internal_self_insert):
9181 * editfns.c (general_insert_function):
9182 * keymap.c (push_key_description):
9183 * search.c (Freplace_match):
9184 * xdisp.c (message_dolog, set_message_1): All callers changed.
9186 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
9188 * keyboard.c (safe_run_hook_funcall): New function.
9189 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
9190 don't set the hook to nil, but remove the offending function instead.
9191 (Qcommand_hook_internal): Remove, unused.
9192 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
9193 Vcommand_hook_internal.
9195 * eval.c (enum run_hooks_condition): Remove.
9196 (funcall_nil, funcall_not): New functions.
9197 (run_hook_with_args): Call each function through a `funcall' argument.
9198 Remove `cond' argument, now redundant.
9199 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
9200 (Frun_hook_with_args_until_failure): Adjust accordingly.
9201 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
9203 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
9205 * dispextern.h (string_buffer_position): Remove declaration.
9207 * print.c (strout): Remove parameter `multibyte', unused since
9208 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
9210 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
9211 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
9212 All callers changed.
9214 * w32.c (_wsa_errlist): Use braces for struct initializers.
9216 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
9217 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
9218 All callers changed.
9219 (string_buffer_position): Likewise. Also, make static (it's never
9220 used outside xdisp.c).
9221 (cursor_row_p): Remove parameter `w', unused since
9222 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
9223 (decode_mode_spec): Remove parameter `precision', introduced during
9224 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
9225 All callers changed.
9227 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9229 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
9231 2011-03-27 Anders Lindgren <andlind@gmail.com>
9233 * nsterm.m (ns_menu_bar_is_hidden): New variable.
9234 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
9235 (ns_update_auto_hide_menu_bar): New functions.
9236 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
9237 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
9238 ns_constrain_all_frames.
9239 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
9240 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
9242 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9244 * nsmenu.m (runDialogAt): Remove argument to timer_check.
9246 2011-03-27 Glenn Morris <rgm@gnu.org>
9248 * syssignal.h: Replace RETSIGTYPE with void.
9249 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
9250 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
9251 Replace SIGTYPE with void everywhere.
9252 * s/usg5-4-common.h (SIGTYPE): Remove definition.
9253 * s/template.h (SIGTYPE): Remove commented out definition.
9255 2011-03-26 Eli Zaretskii <eliz@gnu.org>
9257 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
9258 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
9260 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
9262 * w32.c (read_unc_volume): Use parameter `henum', instead of
9263 global variable `wget_enum_handle'.
9265 * keymap.c (describe_vector): Remove parameters `indices' and
9266 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
9267 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
9269 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
9271 * keyboard.c (timer_check): Remove parameter `do_it_now',
9272 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
9273 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
9274 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
9276 * keyboard.c (read_char):
9277 * w32menu.c (w32_menu_display_help):
9278 * xmenu.c (show_help_event, menu_help_callback):
9279 Adjust calls to `show_help_echo'.
9281 * gtkutil.c (xg_maybe_add_timer):
9282 * keyboard.c (readable_events):
9283 * process.c (wait_reading_process_output):
9284 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
9286 * insdel.c (adjust_markers_gap_motion):
9287 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
9288 (gap_left, gap_right): Don't call it.
9290 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
9292 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
9293 incurred during fontification.
9295 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9297 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
9298 (DEFVAR_PER_BUFFER): Don't pass it.
9300 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
9301 (scrolling_window): Don't pass it.
9303 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9305 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
9307 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
9309 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
9310 of variables specific to SELinux and computation of `encoded_absname'.
9312 * image.c (XPutPixel): Remove unused variable `height'.
9314 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
9316 * unexw32.c (get_section_info): Remove unused variable `section'.
9318 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
9319 (system_process_attributes): Remove unused variable `sess'.
9320 (sys_read): Remove unused variable `err'.
9322 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9323 (w32_wnd_proc): Remove unused variable `isdead'.
9324 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9325 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9326 (x_create_tip_frame): Remove unused variable `tem'.
9328 * w32inevt.c (w32_console_read_socket):
9329 Remove unused variable `no_events'.
9331 * w32term.c (x_draw_composite_glyph_string_foreground):
9332 Remove unused variable `width'.
9334 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
9336 * w32term.c (x_set_glyph_string_clipping):
9337 Don't pass uninitialized region to CombineRgn.
9339 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
9341 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9342 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9343 (Fx_close_connection): Remove unused variable `i'.
9345 * w32font.c (w32font_draw): Return number of glyphs.
9346 (w32font_open_internal): Remove unused variable `i'.
9347 (w32font_driver): Add missing initializer.
9349 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9350 (fill_in_menu): Remove unused variable `items_added'.
9352 * w32term.c (last_mouse_press_frame): Remove static global variable.
9353 (w32_clip_to_row): Remove unused variable `f'.
9354 (x_delete_terminal): Remove unused variable `i'.
9356 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9357 (NOTHING): Remove unused static global variable.
9358 (uniscribe_check_otf): Remove unused variable `table'.
9359 (uniscribe_font_driver): Add missing initializers.
9361 2011-03-23 Julien Danjou <julien@danjou.info>
9363 * term.c (Fsuspend_tty, Fresume_tty):
9364 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9365 * window.c (temp_output_buffer_show):
9366 * insdel.c (signal_before_change):
9367 * frame.c (Fhandle_switch_frame):
9368 * fileio.c (Fdo_auto_save):
9369 * emacs.c (Fkill_emacs):
9370 * editfns.c (save_excursion_restore):
9371 * cmds.c (internal_self_insert):
9372 * callint.c (Fcall_interactively):
9373 * buffer.c (Fkill_all_local_variables):
9374 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9376 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
9377 unconditionally since it does the check itself.
9379 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
9381 Fix more problems found by GCC 4.5.2's static checks.
9383 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9384 the first time through the loop, since we know p0 < p1 then.
9385 This also avoids a gcc -Wstrict-overflow warning.
9387 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9388 leading to a memory leak, possible in functions like
9389 load_charset_map_from_file that can allocate an unbounded number
9390 of objects (Bug#8318).
9392 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9393 that could (at least in theory) be that large.
9395 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9396 This is less likely to overflow, and avoids undefined behavior if
9397 overflow does occur. All callers changed. Use strtoul to scan
9398 for the unsigned long integer.
9399 (pint2hrstr): Simplify and tune code slightly.
9400 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
9402 * scroll.c (do_scrolling): Work around GCC bug 48228.
9403 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9405 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9406 This also avoids a warning with gcc -Wstrict-overflow.
9407 (validate_x_resource_name): Simplify count usage.
9408 This also avoids a warning with gcc -Wstrict-overflow.
9410 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9413 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
9415 * process.c (Fmake_network_process): Use socklen_t, not int,
9416 where POSIX says socklen_t is required in portable programs.
9417 This fixes a porting bug on hosts like 64-bit HP-UX, where
9418 socklen_t is wider than int (Bug#8277).
9419 (Fmake_network_process, server_accept_connection):
9420 (wait_reading_process_output, read_process_output):
9423 * process.c: Rename or move locals to avoid shadowing.
9424 (list_processes_1, Fmake_network_process):
9425 (read_process_output_error_handler, exec_sentinel_error_handler):
9426 Rename or move locals.
9427 (Fmake_network_process): Define label "retry_connect" only if needed.
9428 (Fnetwork_interface_info): Fix pointer signedness.
9429 (process_send_signal): Add cast to avoid pointer signedness problem.
9430 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
9431 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
9433 Make tparam.h and terminfo.c consistent.
9434 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9435 Include tparam.h instead, since it declares them.
9436 * cm.h (PC): Remove extern decl; tparam.h now does this.
9437 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9438 * terminfo.c: Include tparam.h, to check interfaces.
9439 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9440 (tparam): Adjust signature to match interface in tparam.h;
9441 this removes some undefined behavior. Check that outstring and len
9442 are zero, which they always are with Emacs.
9443 * tparam.h (PC, BC, UP): New extern decls.
9445 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
9446 (xftfont_open): Rename locals to avoid shadowing.
9448 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
9449 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9450 (OTF_TAG_SYM): Omit macro if not needed.
9451 (ftfont_list): Remove unused local.
9452 (get_adstyle_property, ftfont_pattern_entity):
9453 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9454 Rename locals to avoid shadowing.
9456 * xfont.c (xfont_list_family): Mark var as initialized.
9458 * xml.c (make_dom): Now static.
9460 * composite.c (composition_compute_stop_pos): Rename local to
9462 (composition_reseat_it): Remove unused locals.
9463 (find_automatic_composition, composition_adjust_point): Likewise.
9464 (composition_update_it): Mark var as initialized.
9465 (find_automatic_composition): Mark vars as initialized,
9466 with a FIXME (Bug#8290).
9468 character.h: Rename locals to avoid shadowing.
9469 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9470 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9471 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9472 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9475 * textprop.c (property_change_between_p): Remove; unused.
9477 * intervals.c (interval_start_pos): Now static.
9479 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9481 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9482 Rename locals to avoid shadowing.
9484 * sound.c (wav_play, au_play, Fplay_sound_internal):
9485 Fix pointer signedness.
9486 (alsa_choose_format): Remove unused local var.
9487 (wav_play): Initialize a variable to 0, to prevent undefined
9488 behavior (Bug#8278).
9490 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9492 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9494 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9495 clobbering (Bug#8298).
9496 * sysdep.c (sys_subshell): Likewise.
9497 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9499 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9500 This should get cleaned up, so that child_setup has the
9501 same signature on all platforms.
9503 * callproc.c (call_process_cleanup): Now static.
9504 (relocate_fd): Rename locals to avoid shadowing.
9506 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9508 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9509 not to be necessary, and produces flickering.
9511 2011-03-20 Glenn Morris <rgm@gnu.org>
9513 * config.in: Remove file.
9515 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9517 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9518 are now in src/globals.h.
9519 (syms_of_minibuf): Remove spurious & from previous change.
9521 2011-03-20 Leo Liu <sdl.web@gmail.com>
9523 * minibuf.c (completing-read-function): New variable.
9524 (completing-read-default): Rename from completing-read.
9525 (completing-read): Call completing-read-function.
9527 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9529 * xfaces.c (Fx_load_color_file):
9530 Read color file from absolute filename (bug#8250).
9532 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9534 * makefile.w32-in: Update dependencies.
9536 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9538 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9540 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9542 Fix more problems found by GCC 4.5.2's static checks.
9544 * process.c (make_serial_process_unwind, send_process_trap):
9545 (sigchld_handler): Now static.
9547 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9548 That way, the code declares only the vars that it needs.
9549 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9550 * s/cygwin.h (PTY_ITERATION): Likewise.
9551 * s/darwin.h (PTY_ITERATION): Likewise.
9552 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9554 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9555 * process.c (allocate_pty): Don't declare stb unless it's needed.
9557 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9558 (CONSTANTLIM): Remove; unused.
9559 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9560 Define only if needed.
9562 * unexelf.c (unexec): Name an expression,
9563 to avoid gcc -Wbad-function-cast warning.
9564 Use a different way to cause a compilation error if anyone uses
9565 n rather than nn, a way that does not involve shadowing.
9566 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9568 * deps.mk (unexalpha.o): Remove; unused.
9570 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9571 * unexec.h: New file.
9572 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9573 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9575 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9576 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9577 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9578 Change as necessary to match prototype in unexec.h.
9580 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9582 (back_comment, skip_chars): Mark vars as initialized.
9584 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9585 Rename locals to avoid shadowing.
9587 * lread.c (read1): Rewrite so as not to use empty "else".
9588 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9590 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9592 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9593 warning when compiling print.c.
9595 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9596 instead of using an uninitialized var.
9597 (font_sort_entities): Mark var as initialized.
9599 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9601 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9602 pointers to constants.
9603 (font_parse_fcname): Remove unused vars.
9604 (font_delete_unmatched): Now static.
9605 (font_get_spec): Remove; unused.
9606 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9607 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9608 Rename or move locals to avoid shadowing.
9610 * fns.c (require_nesting_list, require_unwind): Now static.
9611 (Ffillarray): Rename locals to avoid shadowing.
9613 * floatfns.c (domain_error2): Define only if needed.
9614 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9616 * alloc.c (mark_backtrace): Move decl from here ...
9617 * lisp.h: ... to here, so that it can be checked.
9619 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9620 (Fdefvar): Rewrite so as not to use empty "else".
9621 (lisp_indirect_variable): Name an expression,
9622 to avoid gcc -Wbad-function-cast warning.
9623 (Fdefvar): Rename locals to avoid shadowing.
9625 * callint.c (quotify_arg, quotify_args): Now static.
9626 (Fcall_interactively): Rename locals to avoid shadowing.
9627 Use const pointer when appropriate.
9629 * lisp.h (get_system_name, get_operating_system_release):
9630 Move decls here, to check interfaces.
9631 * process.c (get_operating_system_release): Move decl to lisp.h.
9632 * xrdb.c (get_system_name): Likewise.
9633 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9634 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9635 some of which prompt warnings from gcc -Wbad-function-cast.
9636 (Fformat_time_string, Fencode_time, Finsert_char):
9637 (Ftranslate_region_internal, Fformat):
9638 Rename or remove local vars to avoid shadowing.
9639 (Ftranslate_region_internal): Mark var as initialized.
9641 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9644 * lisp.h (eassert): Check that the argument compiles, even if
9645 ENABLE_CHECKING is not defined.
9647 * data.c (Findirect_variable): Name an expression, to avoid
9648 gcc -Wbad-function-cast warning.
9649 (default_value, arithcompare, arith_driver, arith_error): Now static.
9650 (store_symval_forwarding): Rename local to avoid shadowing.
9651 (Fmake_variable_buffer_local, Fmake_local_variable):
9652 Mark variables as initialized.
9653 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9655 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9656 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9657 Rename locals to avoid shadowing.
9658 (mark_stack): Move local variables into the #ifdef region where
9660 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9661 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9663 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9664 (GC_STRING_CHARS): Remove; not used.
9665 (Fmemory_limit): Cast sbrk's returned value to char *.
9667 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9668 avoids undefined behavior in theory.
9670 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9672 Use functions, not macros, for up- and down-casing (Bug#8254).
9673 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9674 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9675 to use the following functions instead of these macros.
9676 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9677 EMACS_INT, since callers assume the returned value fits in int.
9678 (upcase1): Likewise, for UPCASE_TABLE.
9679 (uppercasep, lowercasep, upcase): New static inline functions.
9680 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9681 the race-condition problem in the old DOWNCASE.
9683 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9684 Rename locals to avoid shadowing.
9685 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9686 (regex_compile, re_search_2, re_match_2_internal):
9687 Remove unused local vars.
9688 (FREE_VAR): Rewrite so as not to use empty "else",
9689 which gcc can warn about.
9690 (regex_compile, re_match_2_internal): Mark locals as initialized.
9691 (RETALLOC_IF): Define only if needed.
9692 (WORDCHAR_P): Likewise. This one is never needed, but is used
9693 only in a comment talking about a compiler bug, so put inside
9694 the #if 0 of that comment.
9695 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9696 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9699 * search.c (boyer_moore): Rename locals to avoid shadowing.
9700 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9701 (PREV_CHAR_BOUNDARY): Likewise.
9703 * search.c (simple_search): Remove unused var.
9705 * dired.c (compile_pattern): Move decl from here ...
9706 * lisp.h: ... to here, so that it can be checked.
9707 (struct re_registers): New forward decl.
9709 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9711 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9713 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9714 Rename locals to avoid shadowing.
9715 (Fvertical_motion): Mark locals as initialized.
9717 * casefiddle.c (casify_object, casify_region): Now static.
9718 (casify_region): Mark local as initialized.
9720 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9722 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9723 New macros, so that the caller can use some names other than
9724 gcpro1, gcpro2, etc.
9725 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9727 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9728 argument, for consistency with GCPRO2_VAR, etc: it is now the
9729 prefix of the variable, not the variable itself. All uses
9731 * dired.c (directory_files_internal, file_name_completion):
9732 Rename locals to avoid shadowing.
9734 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9735 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9736 dired.c's scmp function, had undefined behavior.
9737 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9738 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9739 * buffer.h: ... to here, because these macros use current_buffer,
9740 and the new implementation with inline functions needs to have
9741 current_buffer in scope now, rather than later when the macros
9743 (downcase, upcase1): New static inline functions.
9744 (DOWNCASE, UPCASE1): Reimplement using these functions.
9745 This avoids undefined behavior in expressions like
9746 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9747 from race conditions in accessing the global variables
9748 case_temp1 and case_temp2.
9749 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9750 * lisp.h (case_temp1, case_temp2): Remove their decls.
9751 * character.h (ASCII_CHAR_P): Move from here ...
9752 * lisp.h: ... to here, so that the inline functions mentioned
9755 * dired.c (directory_files_internal_unwind): Now static.
9757 * fileio.c (file_name_as_directory, directory_file_name):
9758 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9760 (file_name_as_directory): Use const pointers when appropriate.
9761 (Fexpand_file_name): Likewise. In particular, newdir might
9762 point at constant storage, so make it a const pointer.
9763 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9764 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9766 (Fset_file_times, Finsert_file_contents, auto_save_error):
9767 Rename locals to avoid shadowing.
9769 * minibuf.c (choose_minibuf_frame_1): Now static.
9770 (Ftry_completion, Fall_completions): Rename or remove locals
9773 * marker.c (bytepos_to_charpos): Remove; unused.
9775 * lisp.h (verify_bytepos, count_markers): New decls,
9776 so that gcc does not warn that these functions aren't declared.
9778 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9779 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9780 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9781 (copy_text): Remove unused local var.
9783 * filelock.c (within_one_second): Now static.
9784 (lock_file_1): Rename local to avoid shadowing.
9786 * buffer.c (fix_overlays_before): Mark locals as initialized.
9787 (fix_start_end_in_overlays): Likewise. This function should be
9788 simplified by using pointers-to-pointers, but that's a different
9790 (switch_to_buffer_1): Now static.
9791 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9792 (report_overlay_modification): Rename locals to avoid shadowing.
9794 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9795 Fix pointer signedness issue.
9796 (sys_subshell): Mark local as volatile if checking for lint,
9797 to suppress a gcc -Wclobbered warning that does not seem to be right.
9798 (MAXPATHLEN): Define only if needed.
9800 * process.c (serial_open, serial_configure): Move decls from here ...
9801 * systty.h: ... to here, so that they can be checked.
9803 * fns.c (get_random, seed_random): Move extern decls from here ...
9804 * lisp.h: ... to here, so that they can be checked.
9806 * sysdep.c (reset_io): Now static.
9807 (wait_for_termination_signal): Remove; unused.
9809 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9810 (copy_keymap_item, append_key, push_text_char_description):
9812 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9813 (DENSE_TABLE_SIZE): Remove; unused.
9814 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9815 (describe_map_tree):
9816 Rename locals to avoid shadowing.
9818 * keyboard.c: Declare functions static if they are not used elsewhere.
9819 (echo_char, echo_dash, cmd_error, top_level_2):
9820 (poll_for_input, handle_async_input): Now static.
9821 (read_char, kbd_buffer_get_event, make_lispy_position):
9822 (make_lispy_event, make_lispy_movement, apply_modifiers):
9823 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9824 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9825 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9826 (read_key_sequence, read_char): Mark locals as initialized.
9827 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9829 * keyboard.h (make_ctrl_char): New decl.
9830 (mark_kboards): Move decl here ...
9831 * alloc.c (mark_kboards): ... from here.
9833 * lisp.h (force_auto_save_soon): New decl.
9835 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9836 (DEFINE_DUMMY_FUNCTION): New macro.
9837 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9839 (main): Add casts to avoid warnings
9840 if GCC considers string literals to be constants.
9842 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9844 * dbusbind.c: Pointer signedness fixes.
9845 (xd_signature, xd_append_arg, xd_initialize):
9846 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9847 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9848 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9849 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9851 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9852 if GCC considers string literals to be constants.
9853 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9855 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9857 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9858 (print_preprocess, print_object): New macro to fix last change.
9860 * print.c (print_preprocess): Don't forget font objects.
9862 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9864 * emacs.c (USAGE3): Doc fixes.
9866 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9868 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9871 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9873 * lisp.h (VWindow_system, Qfile_name_history):
9874 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9875 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9876 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9878 * w32select.c: Don't #include "keyboard.h".
9879 (run_protected): Add extern declaration for waiting_for_input.
9881 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9882 * w32console.c (detect_input_pending, read_input_pending)
9883 (encode_terminal_code):
9884 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9885 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9886 (w32_system_caret_y, Qfile_name_history):
9887 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9888 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9889 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9890 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9891 * w32proc.c (Qlocal, report_file_error):
9892 * w32term.c (Vwindow_system, updating_frame):
9893 * w32uniscribe.c (initialized, uniscribe_font_driver):
9894 Remove unneeded extern declarations.
9896 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9898 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9900 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9902 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9903 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9904 These macros can no longer be used for assignment.
9906 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9907 Assign struct members directly, instead of using BUF_BEGV etc.
9908 (record_buffer_markers, fetch_buffer_markers): New functions for
9909 recording and fetching special buffer markers.
9910 (set_buffer_internal_1, set_buffer_temp): Use them.
9912 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9914 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9916 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9917 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9919 * xdisp.c (hscroll_window_tree):
9920 (reconsider_clip_changes): Use PT instead of BUF_PT.
9922 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9924 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9925 $(EMACS_ROOT)/lib/intprops.h.
9927 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9929 Fix more problems found by GCC 4.5.2's static checks.
9931 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9932 to unsigned char * to avoid compiler diagnostic.
9933 (xg_free_frame_widgets): Make it clear that a local variable is
9934 needed only if USE_GTK_TOOLTIP.
9935 (gdk_window_get_screen): Make it clear that this macro is needed
9936 only if USE_GTK_TOOLTIP.
9937 (int_gtk_range_get_value): New function, which avoids a diagnostic
9938 from gcc -Wbad-function-cast.
9939 (xg_set_toolkit_scroll_bar_thumb): Use it.
9940 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9941 diagnostic from gcc -Wbad-function-cast.
9942 (get_utf8_string, xg_get_file_with_chooser):
9943 Rename locals to avoid shadowing.
9944 (create_dialog): Move locals to avoid shadowing.
9946 * xgselect.c (xg_select): Remove unused var.
9948 * image.c (four_corners_best): Mark locals as initialized.
9949 (gif_load): Initialize transparent_p to zero (Bug#8238).
9950 Mark another local as initialized.
9951 (my_png_error, my_error_exit): Mark with NO_RETURN.
9953 * image.c (clear_image_cache): Now static.
9954 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9955 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9956 (x_edge_detection): Remove unnecessary cast that
9957 gcc -Wbad-function-cast diagnoses.
9958 (gif_load): Fix pointer signedness.
9959 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9960 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9962 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9964 Improve quality of tests for time stamp overflow.
9965 For example, without this patch (encode-time 0 0 0 1 1
9966 1152921504606846976) returns the obviously-bogus value (-948597
9967 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9968 reports time overflow. See
9969 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9970 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9971 * editfns.c: Include limits.h and intprops.h.
9972 (TIME_T_MIN, TIME_T_MAX): New macros.
9973 (time_overflow): Move earlier, to before first use.
9974 (hi_time, lo_time): New functions, for an accurate test for
9976 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9977 (Fget_internal_run_time): Don't assume time_t fits in int.
9978 (make_time): Use list2 instead of Fcons twice.
9979 (Fdecode_time): More accurate test for out-of-range times.
9980 (check_tm_member): New function.
9981 (Fencode_time): Use it, to test for out-of-range times.
9982 (lisp_time_argument): Don't rely on undefined left-shift and
9983 right-shift behavior when checking for time stamp overflow.
9985 * editfns.c (time_overflow): New function, refactoring common code.
9986 (Fformat_time_string, Fdecode_time, Fencode_time):
9987 (Fcurrent_time_string): Use it.
9989 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9990 * dired.c (make_time): Move to ...
9991 * editfns.c (make_time): ... here.
9992 * systime.h: Note the move.
9994 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9996 * fringe.c (update_window_fringes): Remove unused variables.
9998 * unexmacosx.c (copy_data_segment): Also copy __got section.
10001 2011-03-12 Eli Zaretskii <eliz@gnu.org>
10003 * termcap.c [MSDOS]: Include "msdos.h".
10004 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
10005 Constify `char *' arguments and their references according to
10006 prototypes in tparam.h.
10008 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
10010 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
10011 Adapt all references accordingly.
10013 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
10015 2011-03-11 Tom Tromey <tromey@redhat.com>
10017 * buffer.c (syms_of_buffer): Remove obsolete comment.
10019 2011-03-11 Eli Zaretskii <eliz@gnu.org>
10021 * termhooks.h (encode_terminal_code): Declare prototype.
10023 * msdos.c (encode_terminal_code): Don't declare prototype.
10025 * term.c (encode_terminal_code): Now external again, used by
10026 w32console.c and msdos.c.
10028 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
10029 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
10031 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
10033 Fix some minor problems found by GCC 4.5.2's static checks.
10035 * fringe.c (update_window_fringes): Mark locals as initialized
10037 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
10039 * alloc.c (mark_fringe_data): Move decl from here ...
10040 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
10041 to check its interface.
10042 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
10044 * fontset.c (free_realized_fontset): Now static.
10045 (Fset_fontset_font): Rename local to avoid shadowing.
10046 (fontset_font): Mark local as initialized.
10047 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
10049 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
10051 * xselect.c (x_disown_buffer_selections): Remove; not used.
10052 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
10053 (x_own_selection, Fx_disown_selection_internal): Rename locals
10054 to avoid shadowing.
10055 (x_handle_dnd_message): Remove local to avoid shadowing.
10057 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
10058 so that the caller can use some name other than gcpro1.
10059 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
10060 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
10061 (Fx_backspace_delete_keys_p):
10062 Use them to avoid shadowing, and rename vars to avoid shadowing.
10063 (x_decode_color, x_set_name, x_window): Now static.
10064 (Fx_create_frame): Add braces to silence GCC warning.
10065 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
10066 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
10067 Remove unused locals.
10068 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
10069 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
10070 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
10073 * xterm.h (x_mouse_leave): New decl.
10075 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
10076 Remove unused functions.
10077 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
10078 (x_calc_absolute_position): Now static.
10079 (XTread_socket): Don't define label "out" unless it's used.
10080 Don't declare local "event" unless it's used.
10081 (x_iconify_frame, x_free_frame_resources): Don't declare locals
10082 unless they are used.
10083 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
10084 (x_fatal_error_signal): Remove; not used.
10085 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
10086 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
10087 (x_error_catcher, x_connection_closed, x_error_handler):
10088 (x_error_quitter, xembed_send_message, x_iconify_frame):
10089 (my_log_handler): Rename locals to avoid shadowing.
10090 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
10091 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
10093 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
10094 Rename or move locals to avoid shadowing.
10095 (tty_defined_color, merge_face_heights): Now static.
10096 (free_realized_faces_for_fontset): Remove; not used.
10097 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
10098 does not deduce is never used uninitialized.
10099 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
10100 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
10102 * terminal.c (store_terminal_param): Now static.
10104 * xmenu.c (menu_highlight_callback): Now static.
10105 (set_frame_menubar): Remove unused local.
10106 (xmenu_show): Rename parameter to avoid shadowing.
10107 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
10108 since they might point to immutable storage.
10109 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
10110 since it's unused otherwise.
10112 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
10113 Add a FIXME, since the code still doesn't look right. (Bug#8215)
10114 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
10115 avoids a gcc -Wuninitialized diagnostic.
10116 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
10117 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
10118 does not deduce are never used uninitialized.
10120 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
10122 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
10123 * window.c (window_loop, size_window):
10124 (run_window_configuration_change_hook, enlarge_window): Likewise.
10126 * window.c (display_buffer): Now static.
10127 (size_window): Mark variables that gcc -Wuninitialized
10128 does not deduce are never used uninitialized.
10129 * window.h (check_all_windows): New decl, to forestall
10130 gcc -Wmissing-prototypes diagnostic.
10131 * dispextern.h (bidi_dump_cached_states): Likewise.
10133 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
10135 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
10136 Include <limits.h>.
10137 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
10138 and to avoid gcc -Wuninitialized warning.
10139 (load_charset_map): Mark variables that gcc -Wuninitialized
10140 does not deduce are never used uninitialized.
10141 (load_charset): Abort instead of using uninitialized var (Bug#8229).
10143 * coding.c (coding_set_source, coding_set_destination):
10144 Use "else { /* comment */ }" rather than "else /* comment */;"
10145 for clarity, and to avoid gcc -Wempty-body warning.
10146 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
10147 a block, when the outer 'i' will do.
10148 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
10149 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
10150 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
10151 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
10152 (Fdecode_sjis_char, Fdefine_coding_system_internal):
10153 Rename locals to avoid shadowing.
10154 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
10155 * coding.c (emacs_mule_char, encode_invocation_designation):
10156 Now static, since they're not used elsewhere.
10157 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
10158 (decode_coding_object, encode_coding_object, detect_coding_system):
10159 (decode_coding_emacs_mule): Mark variables that gcc
10160 -Wuninitialized does not deduce are never used uninitialized.
10161 (detect_coding_iso_2022): Initialize a local variable that might
10162 be used uninitialized. Leave a FIXME because it's not clear that
10163 this initialization is needed. (Bug#8211)
10164 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
10165 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
10166 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
10167 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
10168 Remove unused macros.
10170 * category.c (hash_get_category_set): Remove unused local var.
10171 (copy_category_table): Now static, since it's not used elsewhere.
10172 * character.c (string_count_byte8): Likewise.
10174 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
10175 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
10177 * chartab.c (copy_sub_char_table): Now static, since it's not used
10179 (sub_char_table_ref_and_range, char_table_ref_and_range):
10180 Rename locals to avoid shadowing.
10181 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
10183 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
10184 (BIDI_BOB): Remove unused macro.
10186 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
10187 deduce are never used uninitialized.
10188 * term.c (encode_terminal_code): Likewise.
10190 * term.c (encode_terminal_code): Now static. Remove unused local.
10192 * tparam.h: New file.
10193 * term.c, tparam.h: Include it.
10194 * deps.mk (term.o, tparam.o): Depend on tparam.h.
10195 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
10196 Move these decls to tparam.h, and make them agree with what
10197 is actually in tparam.c. The previous trick of using incompatible
10198 decls in different modules does not conform to the C standard.
10199 All callers of tparam changed to use tparam's actual API.
10200 * tparam.c (tparam1, tparam, tgoto):
10201 Use const pointers where appropriate.
10203 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
10204 * cm.h (struct cm): Likewise.
10205 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
10206 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
10207 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
10208 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
10209 (turn_on_face, init_tty): Likewise.
10210 * termchar.h (struct tty_display_info): Likewise.
10212 * term.c (term_mouse_position): Rename local to avoid shadowing.
10214 * alloc.c (mark_ttys): Move decl from here ...
10215 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
10217 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
10219 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
10221 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
10223 * search.c (compile_pattern_1): Remove argument regp, unused since
10224 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
10225 (compile_pattern): Don't pass it.
10227 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
10229 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
10230 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
10232 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
10234 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
10236 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
10237 gdk_window_get_screen, gdk_window_get_geometry,
10238 gdk_x11_window_lookup_for_display and GDK_KEY_g.
10239 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
10240 (xg_get_pixbuf_from_pixmap): New function.
10241 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
10242 to Pixmap, take frame as parameter, remove GdkColormap parameter.
10243 Call xg_get_pixbuf_from_pixmap instead of
10244 gdk_pixbuf_get_from_drawable.
10245 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
10246 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
10247 (xg_check_special_colors): Use GtkStyleContext and its functions
10249 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
10250 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
10251 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
10252 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
10253 Call gtk_widget_get_preferred_size.
10254 (xg_frame_resized): gdk_window_get_geometry only takes 5
10256 (xg_win_to_widget, xg_event_is_for_menubar):
10257 Call gdk_x11_window_lookup_for_display.
10258 (xg_set_widget_bg): New function.
10259 (delete_cb): New function.
10260 (xg_create_frame_widgets): Connect delete-event to delete_cb.
10261 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
10262 (xg_set_background_color): Call xg_set_widget_bg.
10263 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
10264 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
10265 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
10266 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
10268 (update_frame_tool_bar): Call gtk_widget_hide.
10269 (xg_initialize): Use GDK_KEY_g.
10271 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
10273 (x_session_initialize): Call gdk_x11_set_sm_client_id.
10275 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
10276 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
10277 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
10279 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
10281 * w32xfns.c (select_palette): Check success of RealizePalette against
10282 GDI_ERROR, not zero.
10284 See ChangeLog.11 for earlier changes.
10286 ;; Local Variables:
10290 Copyright (C) 2011-2012 Free Software Foundation, Inc.
10292 This file is part of GNU Emacs.
10294 GNU Emacs is free software: you can redistribute it and/or modify
10295 it under the terms of the GNU General Public License as published by
10296 the Free Software Foundation, either version 3 of the License, or
10297 (at your option) any later version.
10299 GNU Emacs is distributed in the hope that it will be useful,
10300 but WITHOUT ANY WARRANTY; without even the implied warranty of
10301 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10302 GNU General Public License for more details.
10304 You should have received a copy of the GNU General Public License
10305 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.