1 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
3 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
6 2012-05-06 Chong Yidong <cyd@gnu.org>
8 * lisp.mk (lisp): Update.
10 2012-05-05 Jim Meyering <meyering@redhat.com>
12 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
14 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
16 * data.c (PUT_ERROR): New macro.
17 (syms_of_data): Use it. Add new error type `user-error'.
18 * undo.c (user_error): New function.
19 (Fprimitive_undo): Use it.
20 * print.c (print_error_message): Adjust print style for `user-error'.
21 * keyboard.c (user_error): New function.
22 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
24 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
26 Do not limit current-time-string to years 1000..9999.
27 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
28 (Fcurrent_time_string): Support any year that is supported by the
29 underlying localtime representation. Don't use asctime, as it
30 has undefined behavior for years outside the range -999..9999.
32 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
34 Fix race conditions involving setenv, gmtime, localtime, asctime.
35 Without this fix, interrupts could mess up code that uses these
36 nonreentrant functions, since setting TZ invalidates existing
37 tm_zone or tzname values, and since most of these functions return
38 pointers to static storage.
39 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
40 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
41 Grow the critical sections to include not just invoking
42 localtime/gmtime, but also accessing these functions' results
43 including their tm_zone values if any, and any related TZ setting.
44 (format_time_string): Last arg is now struct tm *, not struct tm **,
45 so that the struct tm is saved in the critical section.
46 All callers changed. Simplify allocation of initial buffer, partly
47 motivated by the fact that memory allocation needs to be outside
50 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
52 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
55 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
56 Remove duplicated buffer name initialization.
58 2012-05-02 Jim Meyering <jim@meyering.net>
60 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
62 * xfns.c (x_window): Use xstrdup (Bug#11375).
64 2012-05-02 Eli Zaretskii <eliz@gnu.org>
66 * xdisp.c (pos_visible_p): If already at a newline from the
67 display string before the 'while' loop, don't walk back the glyphs
68 from it3.glyph_row. Solves assertion violation when the display
69 string begins with a newline (egg.el). (Bug#11367)
71 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
73 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
76 2012-05-01 Glenn Morris <rgm@gnu.org>
78 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
79 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
80 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
81 All were removed before 23.1.
83 * dispnew.c: Remove HAVE_LIBNCURSES test;
84 it is always true on relevant platforms.
86 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
87 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
89 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
91 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
93 * .gdbinit (xpr): Remove checks for no longer existing misc types.
94 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
97 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
99 Do not avoid creating empty evaporating overlays (Bug#9642).
100 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
101 That is, do not delete an evaporating overlay if it becomes
102 empty after its bounds are adjusted to fit within its buffer.
103 This fix caused other problems, and I'm reverting it until we get
104 to the bottom of them.
106 2012-04-27 Chong Yidong <cyd@gnu.org>
108 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
110 2012-04-27 Eli Zaretskii <eliz@gnu.org>
112 * xdisp.c (pos_visible_p): If the window start position is beyond
113 ZV, start the display from buffer beginning. Prevents assertion
114 violation in init_iterator when the minibuffer window is scrolled
117 * window.c (window_scroll_pixel_based): Likewise.
119 2012-04-27 Chong Yidong <cyd@gnu.org>
121 * keymap.c (where_is_internal): Doc fix (Bug#10872).
123 2012-04-27 Glenn Morris <rgm@gnu.org>
125 * fileio.c (Fcopy_file, Fset_file_selinux_context):
126 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
128 2012-04-27 Eli Zaretskii <eliz@gnu.org>
130 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
131 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
133 2012-04-26 Eli Zaretskii <eliz@gnu.org>
135 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
136 display element, check also the underlying string or buffer
137 character. (Bug#11341)
139 * w32menu.c: Include w32heap.h.
140 (add_menu_item): If the call to AppendMenuW (via
141 unicode_append_menu) fails, disable Unicode menus only if we are
142 running on Windows 9X/Me.
144 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
146 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
147 (xgetint): Add missing shift for LSB tags.
149 2012-04-24 Martin Rudalics <rudalics@gmx.at>
151 * keyboard.c (read_char): Don't wipe echo area for select window
152 events: These might get delayed via `mouse-autoselect-window'
155 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
157 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
158 manipulation of :loaded-from data.
160 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
162 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
163 now a cons (bug#11311).
165 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
167 Do not create empty overlays with the evaporate property (Bug#9642).
168 * buffer.c (Fmove_overlay): Delete an evaporating overlay
169 if it becomes empty after its bounds are adjusted to fit within
170 its buffer. Without this fix, in a nonempty buffer (let ((o
171 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
172 yields an empty overlay that has the evaporate property, which is
173 not supposed to happen.
175 Fix minor GTK3 problems found by static checking.
176 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
177 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
178 (struct _EmacsFixedClass, emacs_fixed_get_type):
179 Move decls here from emacsgtkfixed.h, since they needn't be public.
180 (emacs_fixed_get_type): Now static.
181 (emacs_fixed_class_init): Omit unused local.
182 (emacs_fixed_child_type): Remove; unused.
183 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
184 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
185 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
186 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
187 (EMACS_FIXED_GET_CLASS): Remove; unused.
188 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
190 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
191 Problem reported by Juanma Barranquero for Windows -Wunused-function.
193 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
195 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
196 * gmalloc.c: (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
197 (__malloc_size_t, __malloc_ptrdiff_t):
198 Remove. All uses removed, replaced by the definiens if needed,
199 since we can assume C89 or better now.
200 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
201 (protect_malloc_state, align, get_contiguous_space)
202 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
203 (malloc_atfork_handler_child, malloc_enable_thread)
204 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
205 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
206 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
207 (special_realloc, _realloc_internal_nolock, _realloc_internal)
208 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
209 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
210 Define using prototypes, not old style.
211 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
212 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
213 (align): Don't assume that signed integer overflow wraps around.
214 Omit unused local var.
215 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
216 (_free_internal_nolock, memalign, mallochook, reallochook):
217 Omit no-longer-needed casts.
218 (valloc): Use getpagesize, not __getpagesize.
219 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
220 (struct hdr): The 'magic' member is now size_t, not unsigned long.
222 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
224 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
226 Move functions from C to Lisp. Make non-blocking method calls
227 the default. Implement further D-Bus standard interfaces.
229 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
230 (QCdbus_request_name_allow_replacement)
231 (QCdbus_request_name_replace_existing)
232 (QCdbus_request_name_do_not_queue)
233 (QCdbus_request_name_reply_primary_owner)
234 (QCdbus_request_name_reply_in_queue)
235 (QCdbus_request_name_reply_exists)
236 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
237 (QCdbus_registered_serial, QCdbus_registered_method)
238 (QCdbus_registered_signal): New Lisp objects.
239 (XD_DEBUG_MESSAGE): Use sizeof.
240 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
241 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
242 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
243 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
244 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
245 (xd_signature, xd_append_arg): Allow float for integer types.
246 (xd_get_connection_references): New function.
247 (xd_get_connection_address): Rename from xd_initialize.
248 Return cached address.
249 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
250 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
252 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
253 Return number of refcounts.
254 (Fdbus_get_unique_name): Make stronger parameter check.
255 (Fdbus_message_internal): New defun.
256 (Fdbus_call_method, Fdbus_call_method_asynchronously)
257 (Fdbus_method_return_internal, Fdbus_method_error_internal)
258 (Fdbus_send_signal, Fdbus_register_service)
259 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
260 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
261 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
262 (Vdbus_compiled_version, Vdbus_runtime_version)
263 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
264 (Vdbus_message_type_method_return, Vdbus_message_type_error)
265 (Vdbus_message_type_signal): New defvars.
266 (Vdbus_registered_buses, Vdbus_registered_objects_table):
269 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
271 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
272 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
273 Do not assume ptrdiff_t is the same width as 'int'.
275 * alloc.c: Handle unusual debugging option combinations.
276 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
277 since the two debugging options are incompatible.
278 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
280 (mem_init, mem_insert, mem_insert_fixup):
281 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
282 (NEED_MEM_INSERT): Remove; no longer needed.
284 2012-04-22 Leo Liu <sdl.web@gmail.com>
286 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
288 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
290 * sysdep.c [__FreeBSD__]: Minor cleanups.
291 (list_system_processes, system_process_attributes) [__FreeBSD__]:
292 Use Emacs indenting style more consistently. Avoid some casts.
293 Use 'double' consistently rather than mixing 'float' and 'double'.
295 2012-04-21 Eduard Wiebe <usenet@pusto.de>
297 * sysdep.c (list_system_processes, system_process_attributes):
298 Add implementation for FreeBSD (Bug#5243).
300 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
302 * lisp.mk (lisp): Update.
304 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
306 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
307 It is never used otherwise.
309 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
311 * print.c (print_preprocess): Only check print_depth if print-circle
313 (print_object): Check for cycles even when print-circle is nil and
314 print-gensym is t, but only check print_depth if print-circle is nil.
316 2012-04-20 Chong Yidong <cyd@gnu.org>
318 * process.c (wait_reading_process_output): If EIO occurs on a pty,
319 set the status to "failed" and ensure that sentinel is run.
321 2012-04-20 Glenn Morris <rgm@gnu.org>
323 * process.c (Fset_process_inherit_coding_system_flag)
324 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
325 (Fmake_network_process, Fmake_serial_process): Doc fix.
327 2012-04-20 Eli Zaretskii <eliz@gnu.org>
329 * xdisp.c (string_buffer_position_lim): Limit starting position to
331 (set_cursor_from_row): If called for a mode-line or header-line
332 row, return zero immediately.
333 (try_cursor_movement): If inside continuation line, don't back up
334 farther than the first row after the header line, if any.
335 Don't consider the header-line row as "partially visible", even if
336 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
338 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
340 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
343 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
344 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
346 configure: new option --enable-gcc-warnings (Bug#11207)
347 * Makefile.in (C_WARNINGS_SWITCH): Remove.
348 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
349 (ALL_CFLAGS): Use new macros rather than old.
350 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
351 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
352 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
353 -Wunused-result, -Wunused-variable. This should go away once
354 the Emacs and Gnulib regex code is merged.
355 (xmalloc, xrealloc): Now static.
357 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
359 * dired.c (Fsystem_groups): Remove unused local.
361 2012-04-17 Glenn Morris <rgm@gnu.org>
363 * dired.c (Fsystem_users): Doc fix.
365 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
367 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
368 (syms_of_dired): Add them.
370 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
372 Fix minor alloc.c problems found by static checking.
373 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
374 New extern decls, to avoid calling undeclared functions.
375 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
376 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
377 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
378 (NEED_MEM_INSERT): New macro.
379 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
380 Remove one incorrect comment and fix another.
382 Fix minor ralloc.c problems found by static checking.
383 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
384 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
385 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
386 (r_alloc_sbrk): Now static.
388 Improve ralloc.c interface checking.
389 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
390 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
391 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
392 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
393 [REL_ALLOC]: ... to here, to check interface.
394 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
395 Remove decls. This fixes an "It stinks!".
397 * alloc.c (which_symbols): Fix alignment issue / type clash.
399 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
401 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
402 (struct Lisp_Misc_Any): Likewise.
403 (struct Lisp_Free): Likewise.
404 * alloc.c (union aligned_Lisp_Symbol): Define.
405 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
406 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
407 (union aligned_Lisp_Misc): Define.
408 (MARKER_BLOCK_SIZE, struct marker_block): Use union
409 aligned_Lisp_Misc instead of union Lisp_Misc.
410 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
412 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
414 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
415 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
416 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
417 * s/netbsd.h, s/sol2-6.h:
418 Remove definition of GC_MARK_STACK, since the default now works.
419 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
420 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
421 no longer the default.
422 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
424 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
426 * lread.c (lisp_file_lexically_bound_p):
427 Fix hang at ";-*-\n" (bug#11238).
429 2012-04-14 Eli Zaretskii <eliz@gnu.org>
431 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
432 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
434 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
436 * nsterm.m (constrainFrameRect): Always constrain when there is only
437 one screen (Bug#10962).
439 2012-04-13 Ken Brown <kbrown@cornell.edu>
441 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
443 2012-04-13 Reuben Thomas <rrt@sc3d.org>
445 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
447 2012-04-11 Daniel Colascione <dancol@dancol.org>
449 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
450 against is gone. It's better to use vfork now so that when Cygwin
451 gains a new, working vfork, we use it automatically (bug#10398).
453 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
455 * window.c (save_window_save): Obey window-point-insertion-type.
457 2012-04-11 Glenn Morris <rgm@gnu.org>
459 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
461 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
463 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
465 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
467 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
468 (force_quit_count): New var.
469 (handle_interrupt): Use it.
471 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
473 * w32.c (w32_delayed_load): Record the full path of the library
474 being loaded (bug#10424).
476 2012-04-09 Glenn Morris <rgm@gnu.org>
478 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
479 not just in the obarray, before snarfing them. (Bug#11036)
481 * Makefile.in ($(leimdir)/leim-list.el):
482 Pass EMACS rather than BUILT_EMACS.
484 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
486 * process.c (make_process):
487 * process.h: Add integer `gnutls_handshakes_tried' member to
490 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
491 Add convenience `GNUTLS_LOG2i' macro.
493 * gnutls.c (gnutls_log_function2i): Convenience log function.
494 (emacs_gnutls_read): Use new log functions,
495 `gnutls_handshakes_tried' process member, and
496 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
497 attempts per process (connection).
499 2012-04-09 Chong Yidong <cyd@gnu.org>
501 * eval.c (Fuser_variable_p, user_variable_p_eh)
502 (lisp_indirect_variable): Functions deleted.
503 (Fdefvar): Caller changed.
505 * callint.c (Finteractive, Fcall_interactively):
506 * minibuf.c (Fread_variable): Callers changed.
508 2012-04-09 Eli Zaretskii <eliz@gnu.org>
510 * xdisp.c (set_cursor_from_row): If the display string appears in
511 the buffer at position that is closer to point than the position
512 after the display string, display the cursor on the first glyph of
513 the display string. Fixes cursor display when a 'display' text
514 property immediately follows invisible text. (Bug#11094)
516 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
518 composite.c: use 'double' consistently
519 * composite.c (get_composition_id): Use 'double' consistently
520 instead of converting 'float' to 'double' and vice versa; this is
521 easier to understand and avoids a GCC warning.
523 2012-04-09 Glenn Morris <rgm@gnu.org>
525 * Makefile.in: Generate leim-list with bootstrap-emacs, in
526 preparation for dumping it with emacs. (Bug#4789)
527 (leimdir): New variable.
528 ($(leimdir)/leim-list.el): New rule.
529 (emacs$(EXEEXT)): Depend on leim-list.el.
531 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
532 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
533 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
535 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
537 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
540 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
542 * xml.c (init_libxml2_functions) [WINDOWSNT]:
543 Remove unused local variable.
545 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
547 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
548 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
549 (mark_memory): Mark Lisp_Objects only if pointers might hide in
550 objects, as mark_maybe_pointer will catch them otherwise.
551 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
552 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
554 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
556 Fix typo that broke non-Windows builds.
557 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
559 2012-04-07 Eli Zaretskii <eliz@gnu.org>
561 Support building on MS-Windows with libxml2.
563 * makefile.w32-in (OBJ2): Add xml.$(O).
564 (GLOBAL_SOURCES): Add xml.c.
565 ($(BLD)/xml.$(O)): New dependency list.
567 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
568 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
569 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
570 [!WINDOWSNT]: New macros.
571 (init_libxml2_functions, libxml2_loaded_p): New functions.
572 (parse_region): Call fn_xmlCheckVersion instead of using the macro
573 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
574 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
575 Calls xmlCleanupParser only if libxml2 was loaded (or statically
577 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
578 Call init_libxml2_functions before calling libxml2 functions.
579 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
581 * emacs.c: Don't include libxml/parser.h.
582 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
583 xmlCleanupParser directly.
585 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
587 2012-04-07 Eli Zaretskii <eliz@gnu.org>
589 * indent.c (Fvertical_motion): If there is a display string at
590 point, use it.vpos to compute how many lines to backtrack after
591 move_it_to point. (Bug#11133)
593 2012-04-06 Eli Zaretskii <eliz@gnu.org>
595 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
596 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
597 about subtle differences between FETCH_CHAR* and STRING_CHAR*
598 macros related to unification of CJK characters. For the details,
599 see the discussion following the message here:
600 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
602 2012-04-04 Chong Yidong <cyd@gnu.org>
604 * keyboard.c (Vdelayed_warnings_list): Doc fix.
606 2012-04-01 Eli Zaretskii <eliz@gnu.org>
608 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
609 instead of alloca. (Bug#11138)
611 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
613 * w32menu.c (is_simple_dialog): Properly check lisp types.
616 2012-03-31 Eli Zaretskii <eliz@gnu.org>
618 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
619 position we get to after a call to move_it_to fails the
620 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
621 only if we wind up in a string from display property. (Bug#11063)
623 * window.c (Fdelete_other_windows_internal): Invalidate the row
624 and column information about mouse highlight, so that redisplay
625 restores it after reallocating the glyph matrices. (Bug#7464)
627 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
628 string comes from a `display' text property, use the buffer
629 position of that property as if we actually saw that position in
631 (move_it_by_lines): Remove the assertion that
632 "it->current_x == 0 && it->hpos == 0" which can be legitimately
633 violated when there's a before-string at the beginning of a line.
636 2012-03-30 Eli Zaretskii <eliz@gnu.org>
638 * xdisp.c (append_space_for_newline): If the default face was
639 remapped, use the remapped face for the appended newline.
640 (extend_face_to_end_of_line): Use the remapped default face for
641 extending the face to the end of the line.
642 (display_line): Call extend_face_to_end_of_line when the default
643 face was remapped. (Bug#11068)
645 2012-03-29 Eli Zaretskii <eliz@gnu.org>
647 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
649 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
651 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
653 2012-03-27 Glenn Morris <rgm@gnu.org>
655 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
658 2012-03-26 Kenichi Handa <handa@m17n.org>
660 * dispextern.h (struct glyph): Fix previous change. Change the
661 bit length of glyphless.ch to 25 (Bug#11082).
663 2012-03-26 Chong Yidong <cyd@gnu.org>
665 * keyboard.c (Vselection_inhibit_update_commands): New variable.
666 (command_loop_1): Use it; inhibit selection update for
667 handle-select-window too (Bug#8996).
669 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
671 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
673 2012-03-25 Kenichi Handa <handa@m17n.org>
675 * dispextern.h (struct glyph): Change the bit length of
676 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
678 2012-03-24 Eli Zaretskii <eliz@gnu.org>
680 * s/ms-w32.h (tzname): Include time.h before redirecting to
681 _tzname. Fixes the MSVC build. (Bug#9960)
683 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
685 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
688 * xterm.c (XTread_socket): Only modify handling_signal if
689 !SYNC_INPUT. (Bug#11080)
691 2012-03-23 Eli Zaretskii <eliz@gnu.org>
693 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
694 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
695 when fetching a multibyte character consumes more bytes than
696 CHAR_BYTES returns, due to unification of CJK characters in
697 string_char. (Bug#11073)
699 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
701 * process.c (wait_reading_process_output): Handle pty disconnect
702 by refraining from sending oneself a SIGCHLD (bug#10933).
704 2012-03-22 Chong Yidong <cyd@gnu.org>
706 * dispextern.h (struct it): New member string_from_prefix_prop_p.
708 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
709 Mark string as coming from a prefix property.
710 (handle_face_prop): Use default face for prefix strings (Bug#4281).
711 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
713 2012-03-21 Chong Yidong <cyd@gnu.org>
715 * xfaces.c (Vface_remapping_alist): Doc fix.
717 2012-03-20 Eli Zaretskii <eliz@gnu.org>
719 * w32proc.c (Fw32_set_console_codepage)
720 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
723 2012-03-20 Chong Yidong <cyd@gnu.org>
725 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
726 to reflect default non-nil value of redisplay-dont-pause.
728 2012-03-19 Kenichi Handa <handa@m17n.org>
730 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
731 it fit in a valid range (Bug#11003).
733 2012-03-18 Eli Zaretskii <eliz@gnu.org>
735 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
736 that is not from display property, accept the row as a "cursor
737 row" if one of the string's character has a non-nil `cursor'
738 property. Fixes cursor positioning when there are newlines in
739 overlay strings, e.g. in icomplete.el. (Bug#11035)
741 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
743 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
745 2012-03-12 Chong Yidong <cyd@gnu.org>
747 * eval.c (inhibit_lisp_code): Rename from
748 inhibit_window_configuration_change_hook; move from window.c.
750 * xfns.c (unwind_create_frame_1, Fx_create_frame):
751 * window.c (run_window_configuration_change_hook)
752 (syms_of_window): Callers changed.
754 2012-03-11 Chong Yidong <cyd@gnu.org>
756 * keymap.c (Fkey_description): Doc fix (Bug#9700).
758 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
760 2012-03-10 Chong Yidong <cyd@gnu.org>
762 * frame.c (other_visible_frames): Don't assume the selected frame
763 is visible (Bug#10955).
765 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
767 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
769 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
771 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
772 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
775 2012-03-03 Glenn Morris <rgm@gnu.org>
777 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
779 2012-03-02 Eli Zaretskii <eliz@gnu.org>
781 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
782 position past the first glyph_row that ends at ZV. (Bug#10902)
783 (redisplay_window, next_element_from_string): Fix typos in
785 (redisplay_window): Pass to move_it_vertically the margin in
786 pixels, not in screen lines.
788 2012-03-02 Glenn Morris <rgm@gnu.org>
790 * buffer.c (buffer-list-update-hook): Doc fix.
792 2012-02-29 Eli Zaretskii <eliz@gnu.org>
794 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
795 push_it before setting up the iterator for the first overlay
796 string, even if we have an empty string loaded.
797 (next_overlay_string): If there's an empty string on the iterator
798 stack, pop the stack. (Bug#10903)
800 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
802 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
803 Suggested by Stefan Monnier in
804 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
805 * alloc.c (widen_to_Lisp_Object): New static function.
806 (mark_memory): Also mark Lisp_Objects by fetching pointer words
807 and widening them to Lisp_Objects. This would work even if
808 USE_LSB_TAG is defined and wide integers are used, which might
809 happen in a future version of Emacs.
811 2012-02-25 Chong Yidong <cyd@gnu.org>
813 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
816 * xselect.c (Fx_selection_exists_p): Doc fix.
817 (x_clipboard_manager_save_all): Print an informative message
818 before saving to clipboard manager.
820 2012-02-24 Chong Yidong <cyd@gnu.org>
822 * keyboard.c (process_special_events): Handle all X selection
823 requests in kbd_buffer, not just the next one (Bug#8869).
825 2012-02-23 Chong Yidong <cyd@gnu.org>
827 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
828 call when setting menu-bar-lines and tool-bar-lines parameters.
829 (unwind_create_frame_1): New helper function.
831 * window.c (inhibit_window_configuration_change_hook): New var.
832 (run_window_configuration_change_hook): Obey it.
833 (syms_of_window): Initialize it.
835 2012-02-22 Chong Yidong <cyd@gnu.org>
837 * xterm.c (x_draw_image_relief): Add missing type check for
838 Vtool_bar_button_margin (Bug#10743).
840 2012-02-21 Chong Yidong <cyd@gnu.org>
842 * fileio.c (Vfile_name_handler_alist): Doc fix.
844 * buffer.c (Fget_file_buffer): Protect against invalid file
845 handler return value.
847 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
849 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
850 when computing $valmask.
852 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
853 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
854 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
855 It's useless in that case, and it can cause problems on hosts
856 that allocate halves of EMACS_INT values separately.
857 Reported by Dan Horák. Diagnosed by Andreas Schwab in
858 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
859 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
860 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
861 it avoids undefined behavior on hosts where shifting right by more
862 than the word width has undefined behavior.
864 2012-02-19 Chong Yidong <cyd@gnu.org>
866 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
867 (Funhandled_file_name_directory, Ffile_name_as_directory)
868 (Fdirectory_file_name, Fexpand_file_name)
869 (Fsubstitute_in_file_name): Protect against invalid file handler
870 return values (Bug#10845).
872 2012-02-18 Eli Zaretskii <eliz@gnu.org>
874 * .gdbinit (pitx): Fix incorrect references to fields of the
877 2012-02-17 Chong Yidong <cyd@gnu.org>
879 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
881 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
883 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
884 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
886 2012-02-15 Chong Yidong <cyd@gnu.org>
888 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
889 marked as special. Also, starting docstrings with * is obsolete.
891 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
893 * gnutls.c (emacs_gnutls_write): Fix last change.
895 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
897 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
900 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
902 * keymap.c (Fsingle_key_description): Handle char ranges.
904 2012-02-12 Chong Yidong <cyd@gnu.org>
906 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
907 as that creates a dangerous corner case.
909 * window.c (Fdelete_window_internal): Invalidate the mouse
910 highlight (Bug#9904).
912 2012-02-12 Glenn Morris <rgm@gnu.org>
914 * xselect.c (Fx_own_selection_internal)
915 (Fx_get_selection_internal, Fx_disown_selection_internal)
916 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
917 * nsselect.m (Fx_own_selection_internal)
918 (Fx_disown_selection_internal, Fx_selection_exists_p)
919 (Fx_selection_owner_p, Fx_get_selection_internal):
920 Sync docs and argument specs with the xselect.c versions.
922 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
924 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
926 2012-02-11 Eli Zaretskii <eliz@gnu.org>
928 * w32select.c (Fx_selection_exists_p): Sync doc string and
929 argument list with xselect.c. (Bug#10783)
931 * w16select.c (Fx_selection_exists_p): Sync doc string and
932 argument list with xselect.c. (Bug#10783)
934 2012-02-10 Glenn Morris <rgm@gnu.org>
936 * fns.c (Fsecure_hash): Doc fix.
938 2012-02-09 Kenichi Handa <handa@m17n.org>
940 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
942 2012-02-07 Chong Yidong <cyd@gnu.org>
944 * buffer.c (Fbuffer_local_variables)
945 (buffer_lisp_local_variables): Handle unbound vars correctly;
946 don't let Qunbound leak into Lisp.
948 2012-02-07 Glenn Morris <rgm@gnu.org>
950 * image.c (Fimagemagick_types): Doc fix.
952 * image.c (imagemagick-render-type): Change it from a lisp object
953 to an integer. Move the doc here from the lisp manual.
954 Treat all values not equal to 0 the same.
956 2012-02-06 Chong Yidong <cyd@gnu.org>
958 * doc.c (store_function_docstring): Avoid applying docstring of
959 alias to base function (Bug#2603).
961 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
963 * .gdbinit (pp1, pv1): Remove redundant defines.
966 2012-02-04 Chong Yidong <cyd@gnu.org>
968 * nsterm.m: Declare a global (Bug#10694).
970 2012-02-04 Eli Zaretskii <eliz@gnu.org>
972 * w32.c (get_emacs_configuration_options):
973 Include --enable-checking, if specified, in the return value.
975 2012-02-04 Martin Rudalics <rudalics@gmx.at>
977 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
978 after rounding frame sizes. (Bug#9723)
980 2012-02-04 Eli Zaretskii <eliz@gnu.org>
982 * keyboard.c (adjust_point_for_property): Don't position point
983 before BEGV. (Bug#10696)
985 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
987 Handle overflow when computing char display width (Bug#9496).
988 * character.c (char_width): Return EMACS_INT, not int.
989 (char_width, c_string_width): Check for overflow when
990 computing the width; this is possible now that individual
991 characters can have unbounded width. Problem introduced
992 by merge from Emacs 23 on 2012-01-19.
994 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
996 * dbusbind.c (Fdbus_register_method): Mention the return value
997 :ignore in the docstring.
999 2012-02-02 Glenn Morris <rgm@gnu.org>
1001 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
1003 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1004 Unconditionally set to t. (Bug#10673)
1005 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1006 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
1007 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
1009 2012-02-02 Kenichi Handa <handa@m17n.org>
1011 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
1012 0, do not call append_composite_glyph.
1014 2012-02-02 Kenichi Handa <handa@m17n.org>
1016 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
1018 (x_produce_glyphs): If the component of a composition is a null
1019 string, set it->pixel_width to 1 to avoid zero-width glyph.
1021 2012-02-01 Eli Zaretskii <eliz@gnu.org>
1023 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
1024 first 2 arguments are identical. This makes inserting large
1025 output from a subprocess an order of magnitude faster on
1026 MS-Windows, where all sbrk'ed memory is always contiguous.
1028 2012-01-31 Glenn Morris <rgm@gnu.org>
1030 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1031 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
1032 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
1034 2012-01-29 Glenn Morris <rgm@gnu.org>
1036 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
1038 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
1040 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
1042 2012-01-28 Chong Yidong <cyd@gnu.org>
1044 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
1046 2012-01-26 Chong Yidong <cyd@gnu.org>
1048 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
1050 * search.c (Fsearch_forward, Fsearch_backward): Document negative
1051 repeat counts (Bug#10507).
1053 2012-01-26 Glenn Morris <rgm@gnu.org>
1055 * lread.c (syms_of_lread): Doc fix.
1057 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
1059 * coding.c (encode_designation_at_bol): Change return value to
1062 2012-01-25 Chong Yidong <cyd@gnu.org>
1064 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
1066 2012-01-21 Chong Yidong <cyd@gnu.org>
1068 * floatfns.c (Fcopysign): Make the second argument non-optional,
1069 since nil is not allowed anyway.
1071 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
1073 * process.c (read_process_output): Use p instead of XPROCESS (proc).
1074 (send_process): Likewise.
1076 2012-01-19 Martin Rudalics <rudalics@gmx.at>
1078 * window.c (save_window_save, Fcurrent_window_configuration)
1079 (Vwindow_persistent_parameters): Do not use Qstate.
1080 Rewrite doc-strings.
1082 2012-01-19 Kenichi Handa <handa@m17n.org>
1084 * character.c (char_width): New function.
1085 (Fchar_width, c_string_width, lisp_string_width):
1086 Use char_width (Bug#9496).
1088 2012-01-16 Martin Rudalics <rudalics@gmx.at>
1090 * window.c (Vwindow_persistent_parameters): New variable.
1091 (Fset_window_configuration, save_window_save): Handle persistent
1094 2012-01-14 Eli Zaretskii <eliz@gnu.org>
1096 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
1097 thrashing the stack of the thread. (Bug#9087)
1099 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
1101 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
1103 2012-01-11 Eli Zaretskii <eliz@gnu.org>
1105 * xdisp.c (rows_from_pos_range): Handle the case where the
1106 highlight ends on a newline. (Bug#10464)
1107 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
1108 he end column for display of highlight that ends on a newline
1111 2012-01-11 Glenn Morris <rgm@gnu.org>
1113 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
1114 from load-path also when installation-directory is nil. (Bug#10208)
1116 2012-01-10 Glenn Morris <rgm@gnu.org>
1118 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
1120 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
1121 Update template values to be closer to their typical values these days.
1123 2012-01-09 Eli Zaretskii <eliz@gnu.org>
1125 * xdisp.c (rows_from_pos_range): Accept additional argument
1126 DISP_STRING, and accept any glyph in a row whose object is that
1127 string as eligible for mouse highlight. Fixes mouse highlight of
1128 display strings from overlays. (Bug#10464)
1130 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
1132 emacs: fix an auto-save permissions race condition (Bug#10400)
1133 * fileio.c (auto_saving_dir_umask): New static var.
1134 (Fmake_directory_internal): Use it.
1135 (do_auto_save_make_dir): Set it, instead of invoking chmod after
1136 creating the directory. The old code temporarily assigns
1137 too-generous permissions to the directory.
1138 (do_auto_save_eh): Clear it.
1139 (Fdo_auto_save): Catch all errors, not just file errors, so
1140 that the var is always cleared.
1142 2012-01-07 Eli Zaretskii <eliz@gnu.org>
1144 * search.c (scan_buffer): Pass character positions to
1145 know_region_cache, not byte positions. (Bug#6540)
1147 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
1149 * w32.c (sys_rename): Report EXDEV when rename of a directory
1150 fails because the target is on another logical disk. (Bug#10284)
1152 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
1154 * xterm.c (x_embed_request_focus): New function.
1156 * xterm.h: Add prototype.
1158 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
1160 2012-01-05 Glenn Morris <rgm@gnu.org>
1162 * emacs.c (emacs_copyright): Update short copyright year to 2012.
1164 2012-01-01 Eli Zaretskii <eliz@gnu.org>
1166 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
1167 Load gnutls_transport_set_lowat only if GnuTLS version is below
1169 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
1170 GnuTLS versions below 2.11.1.
1172 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
1174 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
1175 to the doc string advising against its use for altering the way
1176 windows are scrolled.
1178 2011-12-28 Kenichi Handa <handa@m17n.org>
1180 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
1181 coding-system ASCII compatible only when it does not produce BOM
1182 on encoding (Bug#10383).
1184 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
1186 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
1188 (create_and_show_popup_menu): Always use menu_position_func for
1191 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
1193 * callint.c (Fcall_interactively): Don't truncate prompt string.
1195 2011-12-23 Eli Zaretskii <eliz@gnu.org>
1197 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
1198 property that ends at ZV, so that the bidi iteration could be
1199 resumed from there (after widening). (Bug#10360)
1201 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
1203 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
1205 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
1207 * nsterm.m (x_free_frame_resources):
1208 Release f->output_data.ns->miniimage.
1209 (ns_index_color): Fix indentation. Do not retain
1210 color_table->colors[i].
1212 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
1215 * nsfns.m (x_set_background_color): Assign return value from
1216 ns_index_color to face-background instead of NSColor*.
1217 (ns_implicitly_set_icon_type): Fix indentation.
1218 Change assignment in for loop to comparison.
1220 * emacs.c (ns_pool): New variable.
1221 (main): Assign ns_pool.
1222 (Fkill_emacs): Call ns_release_autorelease_pool.
1224 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
1225 autorelease fdesc, release fdAttrs and tdict.
1226 (ns_get_covering_families): Release charset.
1227 (ns_findfonts): Release NSFontDescriptor created with new.
1228 (ns_uni_to_glyphs): Fix indentation.
1229 (setString): Release attrStr before assigning new value.
1231 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1233 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1235 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1236 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1238 2011-12-18 David Reitter <reitter@cmu.edu>
1240 * nsterm.m (ns_term_init): Subscribe for notifications
1241 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1242 to method trackingNotification in EmacsMenu.
1244 * nsmenu.m (trackingMenu): New variable.
1245 (trackingNotification): New method (from Aquamacs).
1246 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
1247 from Aquamacs (Bug#7030).
1249 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1251 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1252 (symbol_to_nsstring): Fix indentation.
1253 (ns_symbol_to_pb): New function.
1254 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1255 (Fns_rotate_cut_buffers_internal): Remove.
1256 (Fns_store_selection_internal): Rename from
1257 Fns_store_cut_buffer_internal.
1258 (ns_get_foreign_selection, Fx_own_selection_internal)
1259 (Fx_disown_selection_internal, Fx_selection_exists_p)
1260 (Fns_get_selection_internal, Fns_store_selection_internal):
1261 Use ns_symbol_to_pb and check if return value is nil.
1262 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1263 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
1264 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1265 renamed to Sns_store_selection_internal.
1266 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1267 and remove this function.
1268 (ns_handle_selection_clear): Remove, never used.
1269 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1272 2011-12-17 Ken Brown <kbrown@cornell.edu>
1274 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1275 GID is unknown (Bug#10257).
1277 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1279 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1280 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1281 which caused a build failure on GNU/Linux IA-64. This problem was
1282 introduced by my 2011-10-07 patch.
1284 2011-12-15 Juri Linkov <juri@jurta.org>
1286 * image.c (imagemagick_error): New function. (Bug#10112)
1287 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1288 Use `imagemagick_error' where ImageMagick functions return
1290 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1293 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1295 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1296 fill background (Bug#8992).
1298 2011-12-13 Martin Rudalics <rudalics@gmx.at>
1300 * window.c (Vwindow_combination_resize)
1301 (Vwindow_combination_limit): Use t instead of non-nil in
1303 (Vrecenter_redisplay): Add first sentence of doc-string on
1305 (Frecenter): Fix doc-string typo.
1307 2011-12-11 Kenichi Handa <handa@m17n.org>
1309 * coding.c (Funencodable_char_position): Pay attention to the
1310 buffer text relocation (Bug#9389).
1312 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1314 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1315 gtk_init (Bug#10100).
1317 2011-12-10 Eli Zaretskii <eliz@gnu.org>
1319 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1320 IT->string is nil. (Bug#10263)
1322 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1324 * nsterm.h (x_free_frame_resources): Declare.
1326 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1327 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1329 * nsterm.h (ns_get_defaults_value): Declare.
1331 * nsterm.m (ns_default): Call ns_get_defaults_value.
1333 2011-12-09 Eli Zaretskii <eliz@gnu.org>
1335 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1338 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1340 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1341 that where the value of an _OBJC_* symbol points to is in the .bss
1342 section (Bug#10240).
1344 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1346 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
1347 after the loop to call ccl_driver at least once (Bug#8619).
1349 2011-12-08 Kenichi Handa <handa@m17n.org>
1351 * ftfont.c (get_adstyle_property): Fix previous change
1354 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
1356 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1357 dirs from the default value of EMACSLOADPATH (bug#10208).
1359 2011-12-07 Glenn Morris <rgm@gnu.org>
1361 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1362 installation and source directories as well. (Bug#10208)
1364 2011-12-06 Chong Yidong <cyd@gnu.org>
1366 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1368 2011-12-06 Glenn Morris <rgm@gnu.org>
1370 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1371 as an error, not just -1. (Bug#10217)
1373 2011-12-05 Chong Yidong <cyd@gnu.org>
1375 * keyboard.c (process_special_events): New function.
1376 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1378 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1380 * coding.c (encode_designation_at_bol): Don't use uninitialized
1381 local variable (Bug#9318).
1383 2011-12-05 Kenichi Handa <handa@m17n.org>
1385 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1386 return Qnil (Bug#8046, Bug#10193).
1388 2011-12-05 Kenichi Handa <handa@m17n.org>
1390 * coding.c (encode_designation_at_bol): New args charbuf_end and
1391 dst. Return the number of produced bytes. Callers changed.
1392 (coding_set_source): Return how many bytes coding->source was
1394 (coding_set_destination): Return how many bytes
1395 coding->destination was relocated.
1396 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1397 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1399 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1401 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1402 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1405 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1407 The following changes are to fix Bug#9318.
1409 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1410 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1411 (encode_coding_iso_2022, encode_coding_sjis)
1412 (encode_coding_big5, encode_coding_charset): Use the above macros.
1414 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1416 * lisp.h (process_quit_flag): Fix external declaration.
1418 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1420 Don't macro-inline non-performance-critical code.
1421 * eval.c (process_quit_flag): New function.
1422 * lisp.h (QUIT): Use it.
1424 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1426 * nsfns.m (get_geometry_from_preferences): New function.
1427 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1429 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1431 * emacs.c (Qkill_emacs): Define.
1432 (syms_of_emacs): Initialize it.
1433 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1434 Qquit_flag to `kill-emacs' instead.
1435 (quit_throw_to_read_char): Add parameter `from_signal'.
1436 All callers changed. Call Fkill_emacs if requested and safe.
1437 * lisp.h (QUIT): Call Fkill_emacs if requested.
1439 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1441 * widget.c (update_wm_hints): Return if wmshell is null.
1442 (widget_update_wm_size_hints): New function.
1444 * widget.h (widget_update_wm_size_hints): Declare.
1446 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1447 widget_update_wm_size_hints (Bug#10104).
1449 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1451 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1452 before a newline, prepare the bidi iterator for consuming the
1453 newline, and keep the current paragraph direction. (Bug#10183)
1454 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1456 2011-12-02 Juri Linkov <juri@jurta.org>
1458 * search.c (Fword_search_regexp): New Lisp function created from
1459 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1460 (Fword_search_backward, Fword_search_forward)
1461 (Fword_search_backward_lax, Fword_search_forward_lax):
1462 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1463 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1465 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1467 * fileio.c (Finsert_file_contents): Move after-change-function call
1468 to before the "handled:" label, since all "goto handled" appear in
1469 cases where the *-change-functions have already been properly called
1472 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1474 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1475 waiting for input. (Bug#10169)
1477 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1479 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1480 verifies glyph row's hash code--we have just reallocated the
1481 glyphs, so their contents can be complete garbage. (Bug#10164)
1483 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1485 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1487 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1489 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1490 attributes are tested _before_ calling verify_row_hash, to protect
1491 against GCC re-ordering of the tests. (Bug#10164)
1493 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1495 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1497 * xterm.c (handle_one_xevent): Only set async_visible and friends
1498 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1499 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1500 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1502 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1504 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1505 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1506 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1507 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1508 All uses changed to use GCPRO1 etc.
1509 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1510 Revert to old implementation (i.e., before 2011-03-11).
1512 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1514 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1515 of scroll runs so as to avoid assigning disabled bogus rows and
1516 unnecessary graphics copy operations.
1518 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1520 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1521 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1522 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1523 (malloc, free, realloc, calloc): Redirect to e_* only when
1526 * lisp.h (GCTYPEBITS): Move before first use.
1527 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1528 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1529 this macro definition.
1531 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1534 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1536 * gtkutil.c (xg_create_frame_widgets):
1537 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1538 present with Gtk+ 2.0.
1540 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1542 * fileio.c (Finsert_file_contents): Undo previous change; see
1543 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1545 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1547 Rename locals to avoid shadowing.
1548 * fileio.c (Finsert_file_contents):
1549 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1550 * process.c (wait_reading_process_output):
1551 Rename inner 'proc' to 'p' to avoid shadowing.
1552 Indent for consistency with usual Emacs style.
1554 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1556 * xdisp.c (redisplay_window): If cursor row is not fully visible
1557 after recentering, and scroll-conservatively is set to a large
1558 number, scroll window by a few more lines to make the cursor fully
1559 visible and out of scroll-margin. (Bug#10105)
1560 (start_display): Don't move to the next line if the display should
1561 start at a newline that is part of a display vector or an overlay
1564 2011-11-24 Juri Linkov <juri@jurta.org>
1566 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1567 after the `MagickPingImage' call. (Bug#10112)
1569 2011-11-23 Chong Yidong <cyd@gnu.org>
1571 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1573 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1575 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1576 making another buffer current. (Bug#10114)
1578 2011-11-23 Glenn Morris <rgm@gnu.org>
1580 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1582 2011-11-23 Chong Yidong <cyd@gnu.org>
1584 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1585 using it (Bug#5984).
1587 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1589 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1590 and header-lines, as they don't have one computed for them.
1593 * .gdbinit (prow): Make displayed values more self-explaining.
1594 Add row's hash code.
1596 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1598 * process.c (wait_reading_process_output): Fix asynchrounous
1599 GnuTLS socket handling on some versions of the GnuTLS library.
1600 (wait_reading_process_output): Add comment and URL.
1602 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1604 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1606 2011-11-21 Chong Yidong <cyd@gnu.org>
1608 * window.c (Fnext_window, Fprevious_window): Doc fix.
1610 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1612 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1614 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1616 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1618 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1620 * window.c (Fset_window_combination_limit): Rename argument
1622 (Vwindow_combination_limit): Remove "status" from doc-string.
1624 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1626 * m/ibms390.h: Remove.
1627 * m/ibms390x.h: Don't include "ibms390.h".
1629 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1631 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1632 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1634 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1636 * casetab.c (Fset_case_table):
1637 * charset.c (Fcharset_after): Fix typos.
1639 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1641 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1642 Otherwise, valgrind does not work on some platforms.
1643 Problem reported by Andreas Schwab in
1644 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1645 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1646 is set, removing the need for VIRT_ADDRESS_VARIES.
1647 (PURE_P): Use a more-efficient implementation that needs just one
1648 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1649 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1650 to 4 (xorl, subq, cmpq, setbe).
1651 * alloc.c (pure): Always extern now, since that's the
1652 VIRT_ADDR_VARIES behavior.
1653 (PURE_POINTER_P): Use a single comparison, not two, for
1654 consistency with the new puresize.h.
1655 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1656 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1657 Remove VIRT_ADDR_VARIES no longer needed.
1659 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1661 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1662 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1663 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1664 behave as if the cursor position were at the window margin.
1666 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1667 and the cursor position is out of bounds, behave as if the cursor
1668 position were at the window margin. (Bug#10075)
1670 2011-11-18 Chong Yidong <cyd@gnu.org>
1672 * window.c (Fwindow_combination_limit): Make first argument
1673 non-optional, since it is meaningless for live windows like the
1676 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1678 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1680 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1682 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1683 (graft_intervals_into_buffer): Simplify.
1685 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1687 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1688 hash values of the two rows.
1689 (copy_row_except_pointers): Preserve the used[] arrays and the
1690 hash values of the two rows. (Bug#10035)
1691 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1693 * xdisp.c (row_hash): New function, body extracted from
1694 compute_line_metrics.
1695 (compute_line_metrics): Call row_hash, instead of computing the
1698 * dispnew.c (verify_row_hash): Call row_hash for computing the
1699 hash code of a row, instead of duplicating code from xdisp.c.
1701 * dispextern.h (row_hash): Add prototype.
1703 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1705 * frame.c (delete_frame): Don't delete the terminal when the last
1706 X frame is closed if emacs is built with GTK toolkit.
1708 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1710 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1712 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1714 * window.c (Vwindow_splits): Rename to
1715 Vwindow_combination_resize. Suggested by Juri Linkov.
1716 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1719 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1721 * nsfns.m (Fns_font_name):
1722 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1724 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1726 * window.h (window): Rename slot "nest" to "combination_limit".
1727 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1728 (Fset_window_nest): Rename to Fset_window_combination_limit.
1729 (Vwindow_nest): Rename to Vwindow_combination_limit.
1730 (recombine_windows, make_parent_window, make_window)
1731 (Fsplit_window_internal, saved_window)
1732 (Fset_window_configuration, save_window_save): Rename all
1733 occurrences of window_nest to window_combination_limit.
1735 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1737 * image.c (imagemagick_load_image): Fix typo.
1739 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1741 * xdisp.c (display_line): Move the call to
1742 highlight_trailing_whitespace before the call to
1743 compute_line_metrics, since the latter needs to see the final
1744 faces of all the glyphs to compute ROW's hash value.
1745 Fixes assertion violations in row_equal_p. (Bug#10035)
1747 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1749 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1750 just return (bug#10044).
1752 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1754 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1755 with user-defined heap size. Bump the default size of the temacs
1756 heap to 27MB, to avoid memory warning when running temacs.
1757 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1759 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1760 current_matrix and desired_matrix. (Bug#9990)
1761 (verify_row_hash) [XASSERTS]: New function.
1762 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1763 that the hash value of glyph rows is correct.
1765 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1767 * window.h (window): Remove splits slot.
1768 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1769 (Fdelete_other_windows_internal, make_parent_window)
1770 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1771 (Fset_window_configuration, save_window_save): Don't deal with
1772 split status of windows.
1773 (saved_window): Remove splits slot.
1774 (Vwindow_splits): Rewrite doc-string.
1776 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1778 * xfns.c (unwind_create_frame):
1779 * nsfns.m (unwind_create_frame):
1780 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1781 Vframe_list (Bug#9999).
1783 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1785 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1787 2011-11-11 Kenichi Handa <handa@m17n.org>
1789 * callproc.c (Fcall_process): Set the member dst_multibyte of
1792 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1794 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1795 avoid a crash (bug#9496).
1797 2011-11-09 Chong Yidong <cyd@gnu.org>
1799 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1800 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1802 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1804 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1806 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1808 Avoid some portability problems by eschewing 'extern inline' functions.
1809 The trivial performance wins aren't worth the portability hassles; see
1810 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1812 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1813 (window_box_width, window_box_left, window_box_left_offset)
1814 (window_box_right, window_box_right_offset): Undo previous change,
1815 by removing the "extern"s.
1816 * intervals.c (adjust_intervals_for_insertion)
1817 (adjust_intervals_for_deletion): Undo previous change,
1818 making these static again.
1819 (offset_intervals, temp_set_point_both, temp_set_point)
1820 (copy_intervals_to_string): No longer inline.
1821 * xdisp.c (window_text_bottom_y, window_box_width)
1822 (window_box_height, window_box_left_offset)
1823 (window_box_right_offset, window_box_left, window_box_right)
1824 (window_box): No longer inline.
1826 2011-11-08 Chong Yidong <cyd@gnu.org>
1828 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1829 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1830 Signal an error if not a live window.
1831 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1832 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1834 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1836 * lisp.h (syms_of_abbrev): Remove declaration.
1837 Reported by CHENG Gao <chenggao@royau.me>.
1839 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1841 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1842 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1843 of temacs in GUI mode.
1845 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1847 * window.h: Declare delete_all_child_windows instead of
1848 delete_all_subwindows.
1849 * window.c (Fwindow_nest, Fset_window_nest)
1850 (Fset_window_new_total, Fset_window_new_normal)
1851 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1852 (delete_all_subwindows): Rename to delete_all_child_windows.
1853 (Fdelete_other_windows_internal, Fset_window_configuration):
1854 Call delete_all_child_windows instead of delete_all_subwindows.
1855 * frame.c (delete_frame): Call delete_all_child_windows instead
1856 of delete_all_subwindows.
1858 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1860 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1861 This is also needed for porting to any host where GC_MARK_STACK is
1862 not GC_MAKE_GCPROS_NOOPS.
1863 (which_symbols): Use it.
1865 2011-11-07 Kenichi Handa <handa@m17n.org>
1867 * coding.c (coding_set_destination): Check coding->src_pos only
1868 when coding->src_object is a buffer (bug#9910).
1870 * process.c (send_process): Set the member src_multibyte of coding
1871 to 0 (bug#9911) when sending a unibyte text.
1873 * callproc.c (Fcall_process): Set the member src_multibyte of
1874 process_coding to 0 (bug#9912).
1876 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1878 * xmenu.c (cleanup_widget_value_tree): New function.
1879 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1880 calling free_menubar_widget_value_tree directly (Bug#9830).
1882 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1884 Fix some portability problems with 'inline'.
1885 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1886 (window_box_width, window_box_left, window_box_left_offset)
1887 (window_box_right, window_box_right_offset): Declare extern.
1888 Otherwise, these inline functions do not conform to C99 and
1889 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1890 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1891 * intervals.c (adjust_intervals_for_insertion)
1892 (adjust_intervals_for_deletion): Now extern, because otherwise the
1893 extern inline functions 'offset_intervals' couldn't refer to it.
1894 (static_offset_intervals): Remove.
1895 (offset_intervals): Rewrite using the old contents of
1896 static_offset_intervals. The old version didn't conform to C99
1897 because an extern inline function contained a reference to an
1898 identifier with static linkage.
1900 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1902 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1905 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1907 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1908 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1909 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1910 return Qleft_to_right.
1912 2011-11-06 Chong Yidong <cyd@gnu.org>
1914 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1915 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1916 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1917 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1918 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1919 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1920 (Fwindow_vscroll): Doc fix.
1921 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1922 argument, since it makes no sense to pass a live window and for
1923 consistency with window-child.
1925 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1927 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1930 2011-11-05 Jason Rumney <jasonr@gnu.org>
1932 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1933 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1935 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1936 bitwise arithmetic preventing use of unicode-sip and non-truetype
1939 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1941 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1944 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1945 initialization code to keep similarity to xfns.c after changes
1948 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1950 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1951 (unwind_create_frame): New function (Bug#9943).
1952 (Fx_create_frame): Restructure code to be more similar to the one in
1953 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1954 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1955 Move terminal->reference_count++ just before making the frame official
1958 * nsterm.m (x_free_frame_resources): New function.
1959 (x_destroy_window): Move code to x_free_frame_resources.
1961 * xfns.c (unwind_create_frame): Fix comment.
1962 (Fx_create_frame, x_create_tip_frame):
1963 Move terminal->reference_count++ just before making the frame
1964 official. Move initialization of image_cache_refcount and
1965 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1967 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1969 Support MSVC build with newer versions of Visual Studio.
1970 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1971 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1974 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1975 which are not supported by MSVC.
1976 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1977 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1979 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1981 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1983 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1985 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1987 Support MSVC build with newer versions of Visual Studio.
1988 * w32.c: Don't include w32api.h for MSVC.
1989 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1991 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1992 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1993 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1994 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1996 (alloca) [_MSC_VER]: Define to _alloca.
1998 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
2000 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
2002 2011-11-04 Eli Zaretskii <eliz@gnu.org>
2004 * xdisp.c (note_mouse_highlight): If either of
2005 previous/next-single-property-change returns nil, treat that as
2006 the beginning or the end of the buffer. (Bug#9955)
2008 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
2010 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
2011 label is not null (Bug#9951).
2012 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
2015 2011-11-04 Eli Zaretskii <eliz@gnu.org>
2017 * window.c (Fwindow_body_size): Mention in the doc string that the
2018 return value is in frame's canonical units. (Bug#9949)
2020 2011-11-03 Eli Zaretskii <eliz@gnu.org>
2022 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
2024 * w32fns.c (unwind_create_frame): If needed, free the glyph
2025 matrices of the partially constructed frame. (Bug#9943)
2026 * xfns.c (unwind_create_frame): Likewise.
2028 2011-11-01 Eli Zaretskii <eliz@gnu.org>
2030 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
2031 Don't stop backward scan on the continuation glyph, even though
2032 its CHARPOS is positive.
2033 (mouse_face_from_buffer_pos, note_mouse_highlight):
2034 Rename cover_string to disp_string.
2036 2011-11-01 Martin Rudalics <rudalics@gmx.at>
2038 * window.c (temp_output_buffer_show): Don't use
2039 Vtemp_buffer_show_specifiers.
2040 (Vtemp_buffer_show_specifiers): Remove unused variable.
2042 2011-10-30 Eli Zaretskii <eliz@gnu.org>
2044 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
2045 past the beginning of the current glyph matrix.
2047 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
2049 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
2050 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
2051 HAVE_GTK3 (Bug#9869).
2053 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
2054 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
2056 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
2058 * xterm.c: Declare x_handle_net_wm_state to return int.
2059 (handle_one_xevent): Check if we are iconified but don't have
2060 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
2061 (get_current_wm_state): Return non-zero if not hidden,
2062 check for _NET_WM_STATE_HIDDEN (Bug#9893).
2063 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
2064 (x_handle_net_wm_state): Return what get_current_wm_state returns.
2065 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
2067 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
2069 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
2070 so that this new function doesn't get optimized away by a
2071 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
2073 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2075 * frame.h (MOUSE_HL_INFO): Remove excess parens.
2077 2011-10-29 Eli Zaretskii <eliz@gnu.org>
2079 Fix the `xbytecode' command.
2080 * .gdbinit (xprintbytestr): New command.
2081 (xwhichsymbols): Rename from `which'; all callers changed.
2082 (xbytecode): Print the byte-code string as well.
2084 2011-10-29 Kim Storm <storm@cua.dk>
2086 * alloc.c (which_symbols): New function.
2088 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2090 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
2093 2011-10-29 Glenn Morris <rgm@gnu.org>
2095 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
2096 Not clear what it was for, and it causes various bugs. (Bug#9839)
2098 2011-10-28 Eli Zaretskii <eliz@gnu.org>
2100 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
2101 possible random value that matches one of those tested as
2102 condition to clear the mouse face.
2104 2011-10-28 Chong Yidong <cyd@gnu.org>
2106 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
2108 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
2110 * window.c (make_window): Initialize phys_cursor_on_p.
2112 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
2114 * lisp.h (struct Lisp_Symbol): Update comments.
2116 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
2118 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
2120 2011-10-28 Eli Zaretskii <eliz@gnu.org>
2122 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
2123 <oslsachem@gmail.com> for helping to debug this.
2125 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
2126 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
2127 (g_b_init_get_glyph_outline_w): New static variables.
2128 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
2129 (GetGlyphOutlineW_Proc): New typedefs.
2130 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
2131 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
2133 (w32font_open_internal, compute_metrics):
2134 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
2135 instead of calling the "wide" APIs directly.
2137 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
2139 * w32.h (syms_of_w32font): Add prototype.
2141 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
2143 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
2144 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
2145 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
2146 (Fmove_to_window_line): Doc fix.
2148 2011-10-27 Chong Yidong <cyd@gnu.org>
2150 * process.c (make_process): Set gnutls_state to NULL.
2152 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
2153 non-NULL, regardless of GNUTLS_INITSTAGE.
2154 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
2155 an error. Set process slots as soon as we allocate them.
2157 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
2159 2011-10-27 Chong Yidong <cyd@gnu.org>
2161 * gnutls.c (emacs_gnutls_deinit): New function.
2162 Deallocate credentials structures as well as calling gnutls_deinit.
2163 (Fgnutls_deinit, Fgnutls_boot): Use it.
2165 * process.c (make_process): Initialize GnuTLS credentials to NULL.
2166 (deactivate_process): Call emacs_gnutls_deinit.
2168 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
2170 * image.c (x_create_x_image_and_pixmap):
2171 * w32.c (sys_rename, w32_delayed_load):
2172 * w32font.c (fill_in_logfont):
2173 * w32reg.c (x_get_string_resource): Silence compiler warnings.
2175 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
2177 * w32fns.c (w32_default_color_map): New function,
2178 extracted from Fw32_default_color_map.
2179 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
2181 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
2183 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
2185 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
2187 * keyboard.c (test_undefined): New function (bug#9751).
2188 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
2190 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
2192 * sysdep.c (init_sys_modes): Fix the check for the controlling
2193 terminal (Bug#6649).
2195 2011-10-20 Eli Zaretskii <eliz@gnu.org>
2197 * dispextern.h (struct bidi_it): New member next_en_type.
2199 * bidi.c (bidi_line_init): Initialize the next_en_type member.
2200 (bidi_resolve_explicit_1): When next_en_pos is valid for the
2201 current character, check also for next_en_type being WEAK_EN.
2202 (bidi_resolve_weak): Don't enter the expensive loop if the current
2203 position is before next_en_pos. Record the bidi type of the first
2204 non-ET, non-BN character we find, in addition to its position.
2205 (bidi_level_of_next_char): Invalidate next_en_type when
2206 next_en_pos is over-stepped.
2208 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
2210 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
2211 * editfns.c: Rewrite current-time-zone so that it invokes
2212 the equivalent of (format-time-string "%Z") to get the time zone name.
2213 This fixes a bug when the time zone name contains characters that
2214 need converting from the system time locale to Emacs internal format.
2215 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
2216 that patch fixed format-time-string to do the conversion, but
2217 I forgot to fix current-time-zone.
2218 (format_time_string): New function, containing most of
2219 what Fformat_time_string used to contain.
2220 (Fformat_time_string): Rewrite in terms of format_time_string.
2221 This doesn't change this function's behavior.
2222 (current-time-zone): Rewrite to use format_time_string.
2223 This fixes the bug reported by Michael Schierl in
2224 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
2225 Jason Rumney's 2007-06-07 change worked around this bug, but
2227 * systime.h (tzname, timezone): Remove no-longer-used declarations.
2229 2011-10-19 Eli Zaretskii <eliz@gnu.org>
2231 * xdisp.c (start_display): If the character at POS is displayed
2232 via a display vector, reset IT->current.dpvec_index to zero.
2233 (try_window_reusing_current_matrix): If a line ends in a display
2234 vector or the next line starts in a display vector, continue
2235 redrawing the window even though the character position of
2236 start_row was reached.
2239 2011-10-18 Chong Yidong <cyd@gnu.org>
2241 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2242 with nobreak-char-display too.
2244 2011-10-18 Eli Zaretskii <eliz@gnu.org>
2246 Fix part 3 of bug#9771.
2247 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2248 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2249 non-neutral characters if the current character is a paragraph
2250 separator (a.k.a. Newline). This avoids running the same
2251 expensive loop twice, once when we consume the preceding newline
2252 and the other time when the line actually needs to be displayed.
2253 Avoid the loop when we see neutrals on the base embedding level
2254 following a character whose directionality is the same as the
2255 paragraph's. This avoids running the expensive loop when a line
2256 ends in a long sequence of neutrals, like control characters.
2257 Add assertion against STRONG_AL type. Slightly rearrange code
2258 that determines the type of a neutral given the first non-neutral
2260 (bidi_level_of_next_char): Set next_en_pos to zero when
2261 invalidating its info.
2263 2011-10-17 Eli Zaretskii <eliz@gnu.org>
2265 * xdisp.c (push_display_prop): Determine whether to record string
2266 or buffer position by IT->string, not by IT->method. Allow
2267 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
2268 (move_it_vertically_backward): Don't look for character position
2269 immediately after the newline when in a continuation line.
2272 2011-10-15 Martin Rudalics <rudalics@gmx.at>
2274 * window.c (coordinates_in_window): Rewrite and delabelize
2275 vertical border check. (Bug#5357) (Bug#9618)
2277 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2279 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2280 errors in XSetWindowBorder (bug#9310).
2282 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2284 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2285 avoid crash when xmalloc overrun checking is enabled.
2287 2011-10-13 Eli Zaretskii <eliz@gnu.org>
2289 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2290 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2291 cursor motion with <left> and <right> arrow keys.
2293 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2294 some callers set that themselves.
2296 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2298 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2299 display string and the previous row comes from the same string and
2300 is empty. (Bug#9739) (Bug#9738)
2302 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2304 * doc.c (get_doc_string): Encode file name (bug#9735).
2306 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2308 * bidi.c (bidi_level_of_next_char):
2309 * xdisp.c (get_visually_first_element): Remove old incorrect
2310 comments regarding the Unicode Line Separator character.
2312 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2314 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2316 * alloc.c (Fgc_status): Do not access beyond zombies array
2317 boundary if nzombies > MAX_ZOMBIES.
2318 * alloc.c (dump_zombies): Add missing format specifier.
2320 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2322 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2323 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2325 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2326 Some packages use them to denote characters with modifiers.
2328 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2330 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2331 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2332 matching a pp-number. Rename parameter var to var1.
2334 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2336 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2338 2011-10-08 Glenn Morris <rgm@gnu.org>
2340 * callint.c (Fcall_interactively): Give a more explicit error for the
2341 'c' case with a non-character input. (Bug#8479)
2343 2011-10-08 Eli Zaretskii <eliz@gnu.org>
2345 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2347 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2348 lines that are hscrolled on the left.
2350 * dispnew.c (buffer_posn_from_coords): Account for a possible
2351 presence of header-line. (Bug#4426)
2353 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2355 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2356 Don't advertise functionality which we discourage or doesn't work.
2358 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2360 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2361 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2362 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2363 this makes Emacs dump core during garbage collection on rare
2364 occasions. sizeof is obviously inferior to offsetof here, so
2365 stick with offsetof.
2366 (GC_POINTER_ALIGNMENT): New macro.
2367 (mark_memory): Omit 3rd (offset) arg; caller changed.
2368 Don't assume EMACS_INT alignment is the same as pointer alignment.
2370 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2372 * keyboard.c (read_key_sequence_remapped): New var.
2373 (read_key_sequence): Compute remapping in the right buffer.
2374 (command_loop_1): Use read_key_sequence's remapping directly.
2376 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2378 * dired.c (file_name_completion): Don't expand file name.
2379 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2380 before checking file name handler.
2382 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2383 they've been requested explicitly (bug#9591).
2385 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
2387 * keymap.c (Fsingle_key_description): Use make_specified_string
2388 instead of build_string to build string from push_key_description.
2391 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2393 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2394 This fixes a Y2038 bug on 64-bit hosts.
2395 * buffer.c (reset_buffer):
2396 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2397 (Fclear_buffer_auto_save_failure):
2398 Use 0, not -1, to represent an unset failure time, since time_t
2399 might not be signed.
2401 Remove dependency on glibc malloc internals.
2402 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2403 Move back here from lisp.h, but with their new implementations.
2404 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2405 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2406 * charset.c (charset_table_init): New static var.
2407 (syms_of_charset): Use it instead of xmalloc. This removes a
2408 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2409 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2410 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2411 Move back to alloc.c.
2412 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2413 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2415 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2417 * nsterm.m (windowDidResize): Call x_set_window_size only when
2418 ns_in_resize is true. Otherwise set pixelwidth/height and
2419 call change_frame_size (Bug#9628).
2421 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2423 Port --enable-checking=all to Fedora 14 x86-64.
2424 * charset.c (syms_of_charset): Also account for glibc malloc's
2425 internal overhead when calculating the initial malloc maximum.
2427 Port --enable-checking=all to Fedora 14 x86.
2428 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2430 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2431 (overrun_check_realloc, overrun_check_free):
2432 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2433 That way, xmalloc returns a properly-aligned pointer even if
2434 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2435 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2436 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2437 into account when calculating the initial malloc maximum.
2438 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2439 Move here from alloc.c, so that charset.c can use it too.
2440 Properly align; the old code wasn't right for common 32-bit hosts
2441 when configured with --enable-checking=all.
2442 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2443 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2445 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2447 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2450 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2452 * xdisp.c (compute_display_string_end): If there's no display
2453 string at CHARPOS, return -1.
2455 * bidi.c (bidi_fetch_char): When compute_display_string_end
2456 returns a negative value, treat the character as a normal
2457 character not covered by a display string. (Bug#9624)
2459 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2461 * lread.c (Fread_from_string): Fix typo in docstring.
2463 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2465 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2466 newline, reseat the iterator instead of bidi-iterating there one
2467 character at a time. (Bug#9610)
2468 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2469 TO_CHARPOS if the bidi iterator is at base embedding level.
2471 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2473 * lread.c (readevalloop): Use correct code for NBSP.
2474 (read1): Likewise. (Bug#9608)
2476 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2478 * dbusbind.c (Fdbus_register_signal): When service is not
2479 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2481 2011-09-25 Glenn Morris <rgm@gnu.org>
2483 * buffer.c (truncate-lines): Doc fix.
2485 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2487 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2488 (Fset_window_next_buffers): Doc fix.
2490 2011-09-24 Glenn Morris <rgm@gnu.org>
2492 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2494 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2496 Fix minor problems found by static checking.
2497 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2498 * indent.c (Fvertical_motion): Fix == vs = typo.
2500 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2502 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2503 Default value is now t. Doc fix.
2505 * indent.c (Fvertical_motion): Compute and apply the overshoot
2506 logic when moving up, not only when moving down. Fix the
2507 confusing name and values of the it_overshoot_expected variable;
2508 logic changes accordingly. (Bug#9254) (Bug#9549)
2510 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2511 CHARPOS is covered by a display string which includes newlines.
2512 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2513 is covered by a display string with embedded newlines.
2515 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2517 * dbusbind.c (Fdbus_register_signal): Add match rule to
2518 Vdbus_registered_objects_table. (Bug#9581)
2519 (Fdbus_register_method, Vdbus_registered_objects_table):
2522 2011-09-24 Jim Meyering <meyering@redhat.com>
2524 do not ignore write error for any output size
2525 The previous change was incomplete.
2526 While it makes emacs --batch detect the vast majority of stdout
2527 write failures, errors were still ignored whenever the output size is
2528 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2529 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2530 && echo FAIL: ignored write error
2531 FAIL: ignored write error
2532 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2533 && echo FAIL: ignored write error
2534 FAIL: ignored write error
2535 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2537 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2539 * emacs.c (Fkill_emacs): In noninteractive mode exit
2540 non-successfully if a write error occurred on stdout. (Bug#9574)
2542 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2544 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2547 * dispextern.h (struct it): Update the comment documenting what
2550 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2552 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2553 a display string, extend search for cursor position to end of row.
2554 (find_row_edges): If the row ends in a newline from a display
2555 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2556 Handle the case of a display string with multiple newlines.
2557 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2558 non-empty line. Fixes confusing cursor motion with arrow keys at
2559 the beginning of a line that starts with whitespace.
2561 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2563 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2566 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2568 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2571 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2573 * xdisp.c (display_line): Record maximum and minimum buffer
2574 positions even if no glyphs were produced (e.g., by a zero-width
2575 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2576 buffer positions that will be removed from the glyph row because
2578 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2579 column is beyond frame width: don't subtract 1 "pixel" when
2580 computing width of the stretch.
2581 (reseat_at_next_visible_line_start): Undo the change made on
2582 2011-09-17 that saved paragraph information and restored it after
2583 the call to `reseat'. (Bug#9545)
2585 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2587 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2588 and turn window cursor on if cleared (Bug#9415).
2590 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2592 * search.c (boyer_moore): Take unibyte characters from pattern
2593 literally. (Bug#9458)
2595 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2597 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2599 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2601 Fix minor problem found by static checking.
2602 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2603 initialized, to pacify gcc -Wuninitialized.
2605 * fileio.c: Report proper errno when syscall falls.
2606 (Finsert_file_contents): Save and restore errno,
2607 so that report_file_error outputs the correct diagnostic.
2608 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2610 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2612 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2614 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2616 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2617 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2619 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2621 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2622 about the current paragraph and restore it after the call to reseat.
2624 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2625 (bidi_find_paragraph_start): Search back for paragraph beginning
2626 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2627 (bidi_move_to_visually_next): Only trigger paragraph-related
2628 computations when the last character is a newline or at EOB, not
2629 just any NEUTRAL_B. (Bug#9470)
2631 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2632 truncated lines if point is covered by a display string. (Bug#9524)
2634 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2636 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2637 (cons_to_x_long): New function.
2638 (lisp_data_to_selection_data): Use it. Correct the test for
2639 short-versus-long data; it was negated. Break out of vector
2640 loop, for efficiency, when a long datum is discovered.
2642 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2644 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2646 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2648 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2649 GCC PR/17406) by declaring this function with external scope.
2651 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2653 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2654 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2656 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2658 * editfns.c (Fformat): Correctly handle text properties on "%%".
2660 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2662 * xterm.c (x_draw_composite_glyph_string_foreground):
2663 * w32term.c (x_draw_composite_glyph_string_foreground):
2664 * term.c (encode_terminal_code):
2665 * composite.c (composition_update_it, get_composition_id):
2666 * xdisp.c (get_next_display_element)
2667 (fill_composite_glyph_string): Add comments about special meaning
2668 of TAB characters in a composition.
2670 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2672 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2673 This occurs when processing a multibyte format.
2674 Problem reported by Wolfgang Jenker.
2676 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2678 * xdisp.c (try_cursor_movement): Only check for exact match if
2679 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2681 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2683 Remove unused external symbols.
2684 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2685 * xdisp.c (calc_pixel_width_or_height): Now static.
2686 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2687 * indent.c (check_display_width):
2688 * w32term.c: Fix comment to match code.
2689 * xterm.c, xterm.h (x_catching_errors): Remove.
2691 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2693 * xselect.c: Use signed conversions more consistently (Bug#9498).
2694 (selection_data_to_lisp_data): Assume incoming selection data are
2695 signed integers, not unsigned. This is to be consistent with
2696 outgoing selection data, which was modified to use signed integers
2697 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2698 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2699 expects long, not unsigned long.
2701 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2703 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2704 computation of loop end. Reported by Johan Bockgård
2707 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2709 * frame.c (Fother_visible_frames_p): Function deleted.
2711 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2713 * indent.c (compute_motion): Process display vector front to back
2714 rather than the other way around. (Bug#2496)
2716 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2718 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2720 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2722 * minibuf.c (Fread_from_minibuffer): Doc fix.
2724 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2726 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2727 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2729 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2731 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2732 value for non-existent files.
2734 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2736 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2737 set its "size" to -1. This will set the modtime_size field of
2738 the corresponding buffer to -1, which is what
2739 verify-visited-file-modtime expects for files that do not exist.
2742 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2744 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2746 * lisp.h: ... from here. push_key_description is no longer
2747 defined in keyboard.c, so its declaration should not be in
2748 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2749 logically belongs with push_key_description.
2751 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2753 * buffer.h: Include <sys/types.h> instead of <time.h>.
2754 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2755 Problem reported by Herbert J. Skuhra.
2757 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2759 * xml.c (parse_region): Make the parsing work for
2760 non-comment-starting XML files again (bug#9144).
2762 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2764 * image.c (gif_load): Fix calculation of bottom and right corner.
2767 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2769 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2770 redisplay in small windows.
2772 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2774 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2776 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2778 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2779 Operate on live windows only.
2781 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2783 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2785 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2787 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2788 only under bidi iteration.
2790 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2792 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2794 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2796 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2797 Without this fix, the command to link temacs failed due to an
2798 undefined symbol __builtin_isnan. This is because
2799 /usr/include/iso/math_c99.h #defines isnan(x) to
2800 __builtin_isnan(x), but the bundled gcc, which identifies itself
2801 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2803 * floatfns.c (isnan): #undef, and then #define to a clone of
2805 (Fisnan): Always define, since it's always available now.
2806 (syms_of_floatfns): Always define isnan at the Lisp level.
2808 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2810 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2812 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2814 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2815 The previous code assumed that file offsets (off_t values) fit in
2816 EMACS_INT variables, which is not true on typical 32-bit hosts.
2817 The code messed up by falsely reporting buffer overflow in cases
2818 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2819 when "big" contains more than 2**29 bytes, even though this
2820 inserts just one byte and does not overflow the buffer.
2821 (Finsert_file_contents): Store file offsets as off_t
2822 values, not as EMACS_INT values. Check for overflow when
2823 converting between EMACS_INT and off_t. When checking for
2824 buffer overflow or for overlap, take the offsets into account.
2825 Don't use EMACS_INT for small values where int suffices.
2826 When checking for overlap, fix a typo: ZV was used where
2827 ZV_BYTE was intended.
2828 (Fwrite_region): Don't assume off_t fits into 'long'.
2829 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2831 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2833 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2835 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2837 sprintf-related integer and memory overflow issues (Bug#9412).
2839 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2840 (esprintf, exprintf, evxprintf): New functions.
2841 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2842 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2843 (modify_event_symbol): Do not assume that the length of
2844 name_alist_or_stem is safe to alloca and fits in int.
2845 (Fexecute_extended_command): Likewise for function name and binding.
2846 (Frecursion_depth): Wrap around reliably on integer overflow.
2847 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2848 since some callers pass EMACS_INT values.
2849 (Fsingle_key_description): Don't crash if symbol name contains more
2850 than MAX_ALLOCA bytes.
2851 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2852 (get_minibuffer): Arg is now EMACS_INT, not int.
2853 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2854 (esprintf, exprintf, evxprintf): New decls.
2855 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2857 * dbusbind.c (signature_cat): New function.
2858 (xd_signature, Fdbus_register_signal):
2859 Do not overrun buffer; instead, report string overflow.
2861 * dispnew.c (add_window_display_history): Don't overrun buffer.
2862 Truncate instead; this is OK since it's just a log.
2864 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2865 even if the time zone offset is outlandishly large.
2866 Don't mishandle offset == INT_MIN.
2868 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2869 when creating daemon; the previous buffer-overflow check was incorrect.
2871 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2872 which has the guts of the old verror function.
2874 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2875 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2877 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2878 (font_unparse_xlfd): Don't blindly alloca long strings.
2879 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2880 fits in int, when using sprintf. Use single snprintf to count
2881 length of string rather than counting it via multiple sprintfs;
2882 that's simpler and more reliable.
2883 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2884 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2885 sprintf, in case result does not fit in int.
2887 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2888 (fontset_from_font): Print it.
2890 * frame.c (tty_frame_count): Now printmax_t, not int.
2891 (make_terminal_frame, set_term_frame_name): Print it.
2892 (x_report_frame_params): In X, window IDs are unsigned long,
2893 not signed long, so print them as unsigned.
2894 (validate_x_resource_name): Check for implausibly long names,
2895 and don't assume name length fits in 'int'.
2896 (x_get_resource_string): Don't blindly alloca invocation name;
2897 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2900 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2901 (xg_check_special_colors, xg_set_geometry):
2902 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2904 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2905 Use esprintf, not sprintf, in case result does not fit in int.
2907 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2908 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2909 it as a large positive number.
2910 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2911 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2913 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2914 in case result does not fit in int.
2916 * print.c (float_to_string): Detect width overflow more reliably.
2917 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2918 buffer overrun. Don't assume list length fits in 'int'. Treat
2919 print length of 0 as 0, not as infinity; to be consistent with other
2920 uses of print length in this function. Don't overflow print length
2921 index. Don't assume hash table size fits in 'long', or that
2922 vectorlike size fits in 'unsigned long'.
2924 * process.c (make_process): Use printmax_t, not int, to format
2925 process-name gensyms.
2927 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2929 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2930 to avoid potential buffer overrun.
2932 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2933 if X resource line is longer than 512 bytes.
2935 * xfns.c (x_window): Make sprintf buffer a bit bigger
2936 to avoid potential buffer overrun.
2938 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2940 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2942 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2944 Integer overflow fixes for scrolling, etc.
2945 Without these, Emacs silently mishandles large integers sometimes.
2946 For example, "C-u 4294967297 M-x recenter" was treated as if
2947 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2949 * xdisp.c (try_window_id): Check Emacs fixnum range before
2950 converting to 'int'.
2952 * window.c (window_scroll_line_based, Frecenter):
2953 Check that an Emacs fixnum is in range before assigning it to 'int'.
2954 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2955 values converted from Emacs fixnums.
2956 (Frecenter): Don't wrap around a line count if it is out of 'int'
2957 range; instead, treat it as an extreme value.
2958 (Fset_window_configuration, compare_window_configurations):
2959 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2961 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2962 that can exceed INT_MAX. Check that EMACS_INT value is in range
2963 before assigning it to the (possibly-narrower) index.
2964 (match_limit): Don't assume that a fixnum can fit in 'int'.
2966 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2969 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2970 (Fvertical_motion): Don't wrap around LINES values that don't fit
2971 in 'int'. Instead, treat them as extreme values. This is good
2972 enough for windows, which can't have more than INT_MAX lines anyway.
2974 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2976 * Require libxml/parser.h to avoid compilation warning.
2978 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2980 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2981 since this reportedly can destroy thread storage.
2983 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2985 * syntax.c (find_defun_start): Update all cache variables if
2986 exiting early (Bug#9401).
2988 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2990 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2992 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2993 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2994 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2996 * term.c (tty_append_glyph): New function.
2997 (produce_stretch_glyph): Static function and its prototype deleted.
2999 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
3002 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
3004 * image.c (parse_image_spec): Check for nonnegative, not for positive,
3005 when checking :margin (Bug#9390).
3006 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
3007 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
3008 so that the name doesn't mislead. All uses changed.
3010 2011-08-28 Johan Bockgård <bojohan@gnu.org>
3012 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
3015 2011-08-27 Eli Zaretskii <eliz@gnu.org>
3017 * xdisp.c (move_it_to): Don't bail out early when reaching
3018 position beyond to_charpos, if we are scanning backwards.
3019 (move_it_vertically_backward): When DY == 0, make sure we get to
3020 the first character in the line after the newline.
3022 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
3024 * ccl.c: Improve and simplify overflow checking (Bug#9196).
3025 (ccl_driver): Do not generate an out-of-range pointer.
3026 (Fccl_execute_on_string): Remove unnecessary check for
3027 integer overflow, noted by Stefan Monnier in
3028 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
3029 Remove a FIXME that didn't need fixing.
3030 Simplify the newly-introduced buffer reallocation code.
3032 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
3034 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
3036 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
3038 Integer and memory overflow issues (Bug#9196).
3040 * doc.c (get_doc_string): Rework so that
3041 get_doc_string_buffer_size is the actual buffer size, rather than
3042 being 1 less than the actual buffer size; this makes xpalloc more
3045 * image.c (x_allocate_bitmap_record, cache_image):
3046 * xselect.c (Fx_register_dnd_atom):
3047 Simplify previous changes by using xpalloc.
3049 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
3050 since either will do and ptrdiff_t is convenient with xpalloc.
3052 * charset.c (charset_table_size)
3053 (struct charset_sort_data.priority): Now ptrdiff_t.
3054 (charset_compare): Don't overflow if priorities differ greatly.
3055 (Fsort_charsets): Don't assume list length fits in int.
3056 Check for size-calculation overflow when allocating sort data.
3057 (syms_of_charset): Allocate an initial charset table that is
3058 just under 64 KiB, to avoid problems with glibc malloc and mmap.
3060 * cmds.c (internal_self_insert): Check for size-calculation overflow.
3062 * composite.h (struct composition.glyph_len): Now int, not unsigned.
3063 The actual value is always <= INT_MAX, and leaving it unsigned made
3064 overflow checking harder.
3066 * dispextern.h (struct glyph_matrix.rows_allocated)
3067 (struct face_cache.size): Now ptrdiff_t, for convenience in use
3068 with xpalloc. The values are still always <= INT_MAX.
3070 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
3072 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
3073 (SAFE_NALLOCA): New macro.
3075 * region-cache.c (struct boundary.pos, find_cache_boundary)
3076 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
3077 (set_cache_region, invalidate_region_cache)
3078 (revalidate_region_cache, know_region_cache, region_cache_forward)
3079 (region_cache_backward, pp_cache):
3080 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
3081 so that ptrdiff_t * can be passed to xpalloc.
3082 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
3083 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
3084 (pp_cache): Don't assume cache_len fits in int.
3085 * region-cache.h: Adjust extern decls to match.
3087 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
3088 EMACS_INT, since either will do, for xpalloc.
3090 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
3091 (xnmalloc, xnrealloc, xpalloc): New functions.
3093 * bidi.c (bidi_shelve_header_size): New constant.
3094 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
3095 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
3097 * bidi.c (bidi_cache_shrink):
3098 * buffer.c (overlays_at, overlays_in, record_overlay_string)
3100 Don't update size of array until after memory allocation succeeds,
3101 because xmalloc/xrealloc may not return.
3102 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
3103 now that we have proper integer overflow checking.
3104 (record_overlay_string, overlay_strings): Catch overflows when
3105 calculating size of overlay_str_buf.
3107 * callproc.c (Fcall_process): Check for size overflow when
3108 calculating size of args2.
3109 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
3110 Normally we prefer signed values, but sticking with ptrdiff_t would
3111 require adding more-complicated checks.
3113 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
3114 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
3115 Redo buffer-overflow calculations to avoid integer overflow.
3116 Add a FIXME comment where memory seems to be over-allocated.
3118 * character.c (Fstring): Check for size-calculation overflow.
3120 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
3121 unnecessary integer overflow. Check for size overflow.
3122 (encode_coding_object): Don't update size until xmalloc succeeds.
3124 * composite.c (get_composition_id): Check for overflow in glyph
3125 length calculations.
3127 Integer and memory overflow fixes for display code.
3128 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
3129 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
3130 (scrolling_window): Check for overflow in size calculations.
3131 (line_draw_cost, realloc_glyph_pool, add_row_entry):
3132 Don't assume glyph table len fits in int.
3133 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
3134 (row_table_size): Now ptrdiff_t, not int.
3135 (scrolling_window): Avoid overflow in size calculations.
3136 Don't update size until allocation succeeds.
3137 * fns.c (concat): Check for overflow in size calculations.
3138 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
3139 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3140 (NEXT_ALMOST_PRIME_LIMIT): New constant.
3142 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
3143 (get_doc_string): Check for size calculation overflow.
3144 Don't update size until allocation succeeds.
3145 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
3146 EMACS_INT, where ptrdiff_t will do.
3147 (Fsubstitute_command_keys): Check for string overflow.
3149 * editfns.c (set_time_zone_rule): Don't assume environment length
3151 (message_length): Now ptrdiff_t, not int.
3152 (Fmessage_box): Don't update size until allocation succeeds.
3153 Don't assume message length fits in int.
3154 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
3156 * emacs.c (main): Do not reallocate argv, since there is a null at
3157 the end that can be overwritten, and this way there's no need to
3158 worry about size-calculation overflow.
3159 (sort_args): Check for size-calculation overflow.
3161 * eval.c (init_eval_once, grow_specpdl): Don't update size until
3163 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
3165 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
3166 (x_set_scroll_bar_width, x_figure_window_size):
3167 Check for integer overflow.
3168 (x_set_alpha): Do not assume XINT fits in int.
3170 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
3171 This is for the members text_lines, text_cols, total_lines, total_cols,
3172 where the system imposes an 'int' limit.
3174 * fringe.c (Fdefine_fringe_bitmap):
3175 Don't update size until alloc works.
3177 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
3178 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
3180 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
3181 Check for size-calculation overflow.
3182 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
3183 do, as we prefer signed integers.
3184 (id_to_widget.max_size, id_to_widget.used)
3185 (xg_store_widget_in_map, xg_remove_widget_from_map)
3186 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
3187 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
3188 Use and return ptrdiff_t, not int.
3189 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
3190 * gtkutil.h: Change prototypes to match the above.
3192 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
3193 are duplicate now that they've been promoted to lisp.h.
3194 (x_allocate_bitmap_record, x_alloc_image_color)
3195 (make_image_cache, cache_image, xpm_load):
3196 Don't update size until alloc is done.
3197 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
3199 Check for size calculation overflow.
3200 (ct_colors_allocated_max): New constant.
3201 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
3204 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
3205 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
3206 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
3207 Use ptrdiff_t, not int, to count maps.
3208 (read_char_minibuf_menu_prompt): Check for overflow in size
3209 calculations. Don't update size until allocation succeeds.
3210 Redo calculations to avoid overflow.
3211 * keyboard.h: Change prototypes to match the above.
3213 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
3215 (current_minor_maps): Check for size calculation overflow.
3216 * keymap.h: Change prototypes to match the above.
3218 * lread.c (read1, init_obarray): Don't update size until alloc done.
3220 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
3221 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
3223 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
3224 Now ptrdiff_t, not int.
3225 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
3226 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
3228 * process.c (Fnetwork_interface_list): Check for overflow
3229 in size calculation.
3231 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3233 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3234 overflow. Don't bother calling xmalloc when xrealloc will do.
3236 * search.c (Freplace_match): Check for size calculation overflow.
3237 (Fset_match_data): Don't assume list lengths fit in 'int'.
3239 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3240 for command line length. Do not attempt to address one before the
3241 beginning of an array, as that's not portable.
3243 * term.c (max_frame_lines): Remove; unused.
3244 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3246 (encode_terminal_code, calculate_costs): Check for size
3247 calculation overflow.
3248 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3249 table lengths and related sizes. Don't update size until alloc
3250 done. Redo calculations to avoid overflow.
3251 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3253 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3254 subtracting pointers.
3255 (gobble_line): Check for overflow more carefully. Don't update size
3258 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3259 Don't update size until alloc done.
3260 Redo size calculations to avoid overflow.
3261 Check for size calculation overflow.
3262 (main) [DEBUG]: Fix typo in invoking tparam1.
3264 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3265 Use ptrdiff_t, not int, for sizes.
3266 (store_mode_line_noprop_char): Don't update size until alloc done.
3268 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3269 Use ptrdiff_t, not int, for sizes.
3270 (Finternal_make_lisp_face, cache_face):
3271 Check for size calculation overflow.
3272 (cache_face): Treat size calculation overflows as if they were
3273 memory exhaustion (the usual treatment), rather than aborting.
3275 * xfns.c (x_encode_text, x_set_name_internal)
3276 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3277 sizes, since they can exceed INT_MAX in size. Check for size
3278 calculation overflow.
3280 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3281 (xg_select): Check for size calculation overflow.
3282 Don't update size until alloc done.
3284 * xrdb.c (get_environ_db): Don't assume path length fits in int,
3285 as sprintf is limited to int lengths.
3287 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3288 (X_LONG_MIN): New macros.
3289 Use them to make the following changes clearer.
3290 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3291 This change doesn't affect the value now, but it may help remind
3292 future maintainers not to raise the value too much later.
3293 (SELECTION_QUANTUM): Remove, replacing with ...
3294 (selection_quantum): ... new function, which avoids overflow.
3296 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3297 assumption that selection length fits in 'int'.
3298 (x_reply_selection_request, x_handle_selection_request)
3299 (x_get_window_property, receive_incremental_selection)
3300 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3301 (lisp_data_to_selection_data, clean_local_selection_data):
3302 Use ptrdiff_t, not int, to record length of selection.
3303 (x_reply_selection_request, x_get_window_property)
3304 (receive_incremental_selection, x_property_data_to_lisp):
3305 Redo calculations to avoid overflow.
3306 (x_reply_selection_request): When sending hint, ceiling it at
3307 X_LONG_MAX rather than relying on wraparound overflow to send
3309 (x_get_window_property, receive_incremental_selection)
3310 (lisp_data_to_selection_data, x_property_data_to_lisp):
3311 Check for size-calculation overflow.
3312 (x_get_window_property, receive_incremental_selection)
3313 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3314 Don't store size until memory allocation succeeds.
3315 (x_get_window_property): Plug memory leak on memory exhaustion.
3316 Don't double-block input; malloc is safe here. Don't assume 2**34
3317 - 4 fits in unsigned long. Add an xassert to check
3318 XGetWindowProperty overflow. Be more careful about overflow
3319 calculations, and distinguish size from memory overflow better.
3320 (receive_incremental_selection): When tracing, don't assume
3321 unsigned int is less than INT_MAX.
3322 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3323 harmful) conversions of unsigned short to int.
3324 (lisp_data_to_selection_data): Don't assume that integers
3325 in the range -65535 through -1 fit in an X unsigned short.
3326 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3327 result parameters unless successful. Rely on cons_to_unsigned
3328 to report problems with elements; the old code wasn't right anyway.
3329 (x_check_property_data): Check for int overflow; we cannot use
3330 a wider type due to X limits.
3331 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3333 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
3335 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3336 (x_term_init): Check for size calculation overflow.
3337 (x_color_cells): Don't store size until memory allocation succeeds.
3338 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
3339 Don't assume alloca size is less than MAX_ALLOCA.
3340 (x_term_init): Don't assume length fits in int (sprintf is limited
3343 Use ptrdiff_t for composition IDs.
3344 * character.c (lisp_string_width):
3345 * composite.c (composition_table_size, n_compositions)
3346 (get_composition_id, composition_gstring_from_id):
3347 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3348 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3349 * window.c (Frecenter):
3350 Use ptrdiff_t, not int, for composition IDs.
3351 * composite.c (get_composition_id): Check for integer overflow.
3352 * composite.h: Adjust prototypes to match the above changes.
3354 Use ptrdiff_t for hash table indexes.
3355 * category.c (hash_get_category_set):
3356 * ccl.c (ccl_driver):
3357 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3358 * coding.c (coding_system_charset_list, detect_coding_system):
3359 * coding.h (struct coding_system.id):
3360 * composite.c (get_composition_id, gstring_lookup_cache):
3361 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3362 * image.c (xpm_get_color_table_h):
3363 * lisp.h (hash_lookup, hash_put):
3364 * minibuf.c (Ftest_completion):
3365 Use ptrdiff_t for hash table indexes, not int (which is too
3366 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3367 32-bit --with-wide-int hosts).
3369 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3370 Add a FIXME comment about memory leaks.
3371 (syms_of_charset): Don't assume xmalloc returns.
3373 Don't assume that stated character widths fit in int.
3374 * character.c (Fchar_width, c_string_width, lisp_string_width):
3375 * character.h (CHAR_WIDTH):
3376 * indent.c (MULTIBYTE_BYTES_WIDTH):
3377 Use sanitize_char_width to avoid undefined and/or bad behavior
3378 with outlandish widths.
3379 * character.h (sanitize_tab_width): Rename from sanitize_width,
3380 now that we have two such functions. All uses changed.
3381 (sanitize_char_width): New inline function.
3383 Don't assume that tab-width fits in int.
3384 * character.h (sanitize_width): New inline function.
3385 (SANE_TAB_WIDTH): New macro.
3386 (ASCII_CHAR_WIDTH): Use it.
3387 * indent.c (sane_tab_width): Remove. All uses replaced by
3388 SANE_TAB_WIDTH (current_buffer).
3389 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3391 * fileio.c: Integer overflow issues with file modes.
3392 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3394 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3395 Remove unreachable code.
3396 (read_hex, load_charset_map_from_file): Check for integer overflow.
3398 * xterm.c: Don't go over XClientMessageEvent limit.
3399 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3400 (x_send_scroll_bar_event): Likewise. Check that the size does not
3401 exceed limits imposed by XClientMessageEvent, as well as the usual
3402 ptrdiff_t and size_t limits.
3404 * keyboard.c: Overflow, signedness and related fixes.
3405 (make_lispy_movement): Use same integer type in forward decl
3406 that is used in the definition.
3407 (read_key_sequence, keyremap_step):
3408 Change bufsize argument back to int, undoing my 2011-03-30 change.
3409 We prefer signed types, and int is wide enough here.
3410 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3411 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3412 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3413 length, not size_t. Use ptrdiff_t for index, not int.
3414 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3415 possibility of integer overflow.
3417 Overflow, signedness and related fixes for images.
3419 * dispextern.h (struct it.stack[0].u.image.image_id)
3420 (struct_it.image_id, struct image.id, struct image_cache.size)
3421 (struct image_cache.used, struct image_cache.ref_count):
3422 * gtkutil.c (update_frame_tool_bar):
3423 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3424 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3425 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3426 * nsmenu.m (update_frame_tool_bar):
3427 * xdisp.c (calc_pixel_width_or_height):
3428 * xfns.c (image_cache_refcount):
3429 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3430 on typical 64-bit hosts.
3432 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3433 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3434 Omit unnecessary casts to int.
3435 (parse_image_spec): Check that integers fall into 'int' range
3436 when the callers expect that.
3437 (image_ascent): Redo ascent calculation to avoid int overflow.
3438 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3439 (lookup_image): Remove unnecessary tests.
3440 (xbm_image_p): Locals are now of int, not EMACS_INT,
3441 since parse_image_check makes sure they fit into int.
3442 (png_load, gif_load, svg_load_image):
3443 Prefer int to unsigned where either will do.
3444 (tiff_handler): New function, combining the cores of the
3445 old tiff_error_handler and tiff_warning_handler.
3446 This function is rewritten to use vsnprintf and thereby avoid
3447 stack buffer overflows. It uses only the features of vsnprintf
3448 that are common to both POSIX and native Microsoft.
3449 (tiff_error_handler, tiff_warning_handler): Use it.
3450 (tiff_load, gif_load, imagemagick_load_image):
3451 Don't assume :index value fits in 'int'.
3452 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3453 (imagemagick_load_image): Check that crop parameters fit into
3454 the integer types that MagickCropImage accepts. Don't assume
3455 Vimagemagick_render_type has a nonnegative value. Don't assume
3456 size_t fits in 'long'.
3457 (gs_load): Use printmax_t to print the widest integers possible.
3458 Check for integer overflow when computing image height and width.
3460 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3462 * xdisp.c (redisplay_window): Don't force window start if point
3463 will be invisible in the resulting window. (Bug#9324)
3465 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3467 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3468 the display spec is of the form `(space ...)'.
3469 (handle_display_spec): Return the value returned by
3470 handle_single_display_spec, not just 1 or zero.
3471 (handle_single_display_spec): If the display spec is of the form
3472 `(space ...)', and specifies display in the text area, return 2
3474 (try_cursor_movement): Check for the need to scroll more
3475 accurately, and prefer exact match for point under bidi.
3476 Don't advance `row' beyond the last row of the window.
3478 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3479 into disp_prop; all users changed.
3481 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3482 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3483 for the text covered by the display property.
3485 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3487 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3488 Change return value to nil.
3489 (Frecord_buffer): Delete unused function.
3491 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3493 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3494 buffers, return left-to-right.
3495 (set_cursor_from_row): Consider candidate row a win if its glyph
3496 represents a newline and point is on that newline. Fixes cursor
3497 positioning on the newline at EOL of R2L text within L2R
3498 paragraph, and vice versa.
3499 (try_cursor_movement): Check continued rows, in addition to
3500 continuation rows. Fixes unwarranted scroll when point enters a
3501 continued line of R2L text within an L2R paragraph, or vice versa.
3502 (cursor_row_p): Consider the case of point being equal to
3503 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3504 from the end of a short line to the beginning of a continued line
3505 of R2L text within L2R paragraph.
3506 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3507 composed characters.
3509 * bidi.c (bidi_check_type): Use xassert.
3510 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3513 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3515 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3518 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3520 * nsfont.m (ns_otf_to_script): Fix typo.
3522 2011-08-22 Kenichi Handa <handa@m17n.org>
3524 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3525 extra slot even if the purpose is char-code-property-table.
3527 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3529 * xdisp.c (redisplay_window): When computing centering_position,
3530 account for the height of the header line. (Bug#8874)
3532 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3533 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3534 candidate is selected by the mouse, and that candidate has a
3535 composed character under the mouse.
3537 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3538 coordinates reported by pos-visible-in-window-p for a composed
3539 character in column zero.
3541 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3543 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3545 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3547 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3548 consider it a hit if to_charpos is anywhere in the range of the
3549 composed buffer positions.
3551 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3553 * image.c (gif_load): Don't assume that each subimage has the same
3554 dimensions as the base image. Handle disposal method that is
3555 "undefined" by the gif spec (Bug#9335).
3557 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3559 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3560 (Fcondition_case): Document `debug' symbol in error handler.
3562 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3564 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3565 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3566 from an Org mode buffer to a Speedbar frame.
3568 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3569 a composition, take its buffer position from IT->cmp_it.charpos.
3570 Fixes cursor positioning at the beginning of a line that begins
3571 with a composed character.
3573 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3575 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3576 character bidirectional type, use STRONG_L instead. Fixes crashes
3577 in a buffer produced by `describe-categories'.
3579 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3580 members before the level stack, so they would be saved and
3581 restored when copying iterator state. Fixes incorrect reordering
3582 around TABs covered by display properties.
3584 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3586 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3588 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3590 * eval.c (internal_condition_case, internal_condition_case_1)
3591 (internal_condition_case_2, internal_condition_case_n):
3592 Remove unnecessary aborts (Bug#9081).
3594 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3596 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3597 has no `load' handler, try opening the file locally. (Bug#9311)
3599 2011-08-16 Ken Brown <kbrown@cornell.edu>
3601 * gmalloc.c: Expand comment.
3603 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3605 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3606 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3608 2011-08-16 Ken Brown <kbrown@cornell.edu>
3610 Fix memory allocation problems in Cygwin build (Bug#9273).
3612 * unexcw.c ( __malloc_initialized): Declare external variable.
3613 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3615 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3617 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3619 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3621 [CYGWIN] (special_realloc): New function.
3622 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3623 requests to realloc storage in the static heap.
3625 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3627 * bidi.c (bidi_initialize): Remove unused local.
3629 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3632 * biditype.h: Remove file.
3633 * makefile.w32-in ($(BLD)/bidi.$(O)):
3634 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3636 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3638 * chartab.c: Improve commentary for the uniprop_table API.
3640 * bidi.c (bidi_paragraph_init): Support zero value of
3641 bidi_ignore_explicit_marks_for_paragraph_level.
3642 (bidi_initialize): Use uniprop_table instead of including
3643 biditype.h and bidimirror.h.
3645 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3646 coordinates of the iterator when restoring from ppos_it.
3649 2011-08-14 Kenichi Handa <handa@m17n.org>
3651 * process.c (create_process): Call setup_process_coding_systems
3652 after the pid of the process is set to -1 (Bug#8162).
3654 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3656 * xdisp.c (move_it_in_display_line_to): Don't invoke
3657 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3658 ppos_it. Fixes vertical cursor motion when line beginning is
3659 covered by an image. (Bug#9296)
3661 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3663 * nsterm.h (ns_run_ascript): Declare.
3664 (NSAPP_DATA2_RUNASSCRIPT): Define.
3666 * nsfns.m (as_script, as_result, as_status): New static variables.
3667 (ns_run_ascript): New function.
3668 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3669 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3670 the event loop. Get status from as_status (Bug#7276).
3672 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3673 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3674 the event loop (Bug#7276).
3676 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3678 * gnutls.c (QCgnutls_bootprop_priority)
3679 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3680 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3681 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3682 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3683 (QCgnutls_bootprop_verify_hostname_error)
3684 (QCgnutls_bootprop_callbacks_verify): Rename from
3685 Qgnutls_bootprop_..., all uses changed.
3687 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3690 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3692 * xfaces.c (Qframe_set_background_mode): Now static.
3693 * dispextern.h (Qframe_set_background_mode): Remove decl.
3695 * process.c (Fnetwork_interface_info): Declare local only if needed.
3697 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3699 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3700 (Fnetwork_interface_list): Allocate in increments of bytes instead
3701 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3702 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3704 (struct ifflag_def): notrailers is smart on OSX.
3705 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3706 Get hardware address with getifaddrs if available.
3708 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3710 * xdisp.c (iterate_out_of_display_property): xassert that
3711 IT->position is set to within IT->object's boundaries. Break from
3712 the loop as soon as EOB is reached; avoids infloops in redisplay
3713 when IT->position is set up wrongly due to some bug.
3714 Set IT->current to match the bidi iterator unconditionally.
3715 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3716 entry. Force push_it to save on the stack the current
3717 buffer/string position, to be restored by pop_it. Fix flags in
3718 the iterator structure wrt the object coming from a display
3719 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3720 properties. (Bug#9284)
3722 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3724 * fontset.c (fontset_get_font_group): Add proper type checks.
3727 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3729 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3730 and LC_VERSION_MIN_MACOSX.
3731 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3732 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3734 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3736 * xdisp.c (forward_to_next_line_start): Allow to use the
3737 no-display-properties-and-no-overlays under bidi display.
3738 Set disp_pos in the bidi iterator to avoid searches for display
3739 properties and overlays.
3741 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3743 * editfns.c (Fset_time_zone_rule): Document relationship with the
3746 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3747 the font entity extracted from the cache (Bug#8109).
3749 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3751 * composite.c (autocmp_chars): Don't reset point. That is done by
3752 restore_point_unwind (Bug#5984).
3754 2011-08-07 Juri Linkov <juri@jurta.org>
3756 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3757 to show the arg `TIME' instead of `TIMEVAL'.
3759 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3761 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3762 display property strides EOL and includes a newline, as in
3763 longlines-mode. (Bug#9254)
3764 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3765 word-wrap under bidirectional display. (Bug#9224)
3767 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3768 is non-zero, even if the data buffer is NULL. Fixes a crash in
3769 vertical-motion with longlines-mode. (Bug#9254)
3771 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3773 * bidi.c <bidi_cache_total_alloc>: Now static.
3774 (bidi_initialize): Initialize bidi_cache_total_alloc.
3776 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3779 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3780 amount allocated this far in `bidi_cache_total_alloc'.
3781 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3782 non-zero, only free the data buffer without restoring the cache
3783 contents. All callers changed.
3785 * dispextern.h (bidi_unshelve_cache): Update prototype.
3787 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3788 (move_it_in_display_line, move_it_to)
3789 (move_it_vertically_backward, move_it_by_lines): Replace the call
3790 to xfree to an equivalent call to bidi_unshelve_cache.
3791 (move_it_in_display_line_to): Fix logic of returning
3792 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3794 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3796 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3797 came from a string character with a `cursor' property. (Bug#9229)
3799 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3801 * Makefile.in (LIB_PTHREAD): New variable.
3802 (LIBES): Add LIB_PTHREAD (Bug#9216).
3804 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3805 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3807 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3809 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3811 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3813 * xterm.c (x_find_topmost_parent): New function.
3814 (x_set_frame_alpha): Find topmost parent window with
3815 x_find_topmost_parent and set the property there also (bug#9181).
3816 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3818 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3820 * callproc.c (Fcall_process): Avoid vfork clobbering
3821 the local vars buffer, coding_systems, current_dir.
3823 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3825 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3827 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3829 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3830 so that it is not optimized away.
3832 * xdisp.c (compute_display_string_pos): Remove unused local.
3834 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3836 Fix slow cursor motion and scrolling in large buffers with
3837 selective display, like Org Mode buffers. (Bug#9218)
3839 * dispextern.h (struct bidi_it): New member disp_prop_p.
3841 * xdisp.c: Remove one-slot cache of display string positions.
3842 (compute_display_string_pos): Accept an additional argument
3843 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3844 for a display string or property. If found, set DISP_PROP_P
3847 * bidi.c (bidi_fetch_char): Accept an additional argument
3848 DISP_PROP_P, and pass it to compute_display_string_pos.
3849 Only handle text covered by a display string if DISP_PROP_P is returned
3850 non-zero. All callers of bidi_fetch_char changed.
3852 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3854 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3856 2010-12-03 Don March <don@ohspite.net>
3858 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3859 last character M-[char] is translated to ESC [char] (bug#7541).
3861 2011-08-02 Kenichi Handa <handa@m17n.org>
3863 * lisp.h (uniprop_table): Extern it.
3865 * chartab.c (uniprop_table): Make it non-static.
3867 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3869 * xdisp.c (forward_to_next_line_start): Accept additional argument
3870 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3872 (reseat_at_next_visible_line_start): Use the bidi iterator state
3873 returned by forward_to_next_line_start to restore the state of
3874 it->bidi_it after backing up to previous newline. (Bug#9212)
3876 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3878 * regex.c (re_comp): Protoize.
3879 (re_exec): Fix return type.
3880 (regexec): Fix type of `ret'. (Bug#9203)
3882 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3884 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3885 This is needed if max-image-size is a floating-point number.
3887 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3889 * print.c (print_object): Print empty symbol as ##.
3891 * lread.c (read1): Read ## as empty symbol.
3893 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3895 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3896 setting frame foreground color (Bug#9175).
3897 (x_set_background_color): Likewise.
3899 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3900 contents (Bug#9176).
3901 (EmacsTooltip -init): Remove bezels and add shadows to
3904 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3905 or scroll bar (Bug#8470).
3907 * nsfont.m (nsfont_open): Remove assignment to voffset and
3908 unnecessary vars hshink, expand, hd, full_height, min_height.
3909 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3911 * nsterm.h (nsfont_info): Remove voffset field.
3913 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3915 Implement strike-through and overline on NextStep (Bug#8863).
3917 * nsfont.m (nsfont_open): Use underline position provided by font,
3918 instead of hard-coded value of 2.
3919 (nsfont_draw): Call ns_draw_text_decoration instead.
3921 * nsterm.h: Add declaration for ns_draw_text_decoration.
3923 * nsterm.m (ns_draw_text_decoration): New function for drawing
3924 underline, overline, and strike-through.
3925 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3926 ns_draw_text_decoration. Change treatment of cursor drawing to
3927 accommodate underlining, etc.
3929 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3931 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3934 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3936 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3937 Without this fix, if a signal arrives just after memory fills up,
3938 'malloc' might be invoked reentrantly.
3940 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3941 In other words, assume that every image size is allowed, on non-X
3942 hosts. This assumption is probably wrong, but it lets Emacs compile.
3944 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3946 * regex.c (re_iswctype): Convert return values to boolean.
3948 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3950 * xdisp.c (compute_display_string_pos): Don't use cached display
3951 string position if the buffer had its restriction changed.
3954 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3956 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3958 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3960 Integer signedness and overflow and related fixes. (Bug#9079)
3962 * bidi.c: Integer size and overflow fixes.
3963 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3964 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3965 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3966 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3967 (bidi_find_other_level_edge):
3968 Use ptrdiff_t instead of EMACS_INT where either will do.
3969 This works better on 32-bit hosts configured --with-wide-int.
3970 (bidi_cache_ensure_space): Check for size-calculation overflow.
3971 Use % rather than repeated addition, for better worst-case speed.
3972 Don't set bidi_cache_size until after xrealloc returns, because it
3974 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3975 (bidi_cache_ensure_space): Also check that the bidi cache size
3976 does not exceed that of the largest Lisp string or buffer. See Eli
3977 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3979 * alloc.c (__malloc_size_t): Remove.
3980 All uses replaced by size_t. See Andreas Schwab's note
3981 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3983 * image.c: Improve checking for integer overflow.
3984 (check_image_size): Assume that f is nonnull, since
3985 it is always nonnull in practice. This is one less thing to
3986 worry about when checking for integer overflow later.
3987 (x_check_image_size): New function, which checks for integer
3988 overflow issues inside X.
3989 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3990 This removes the need for a memory_full check.
3991 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3992 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3993 (xbm_read_bitmap_data): Change locals back to 'int', since
3994 their values must fit in 'int'.
3995 (xpm_load_image, png_load, tiff_load):
3996 Invoke x_create_x_image_and_pixmap earlier,
3997 to avoid much needless work if the image is too large.
3998 (tiff_load): Treat overly large images as if
3999 x_create_x_image_and_pixmap failed, not as malloc failures.
4000 (gs_load): Use x_check_image_size.
4002 * gtkutil.c: Omit integer casts.
4003 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
4004 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
4006 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
4008 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
4009 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
4010 would wrongly return t on a 64-bit host.
4012 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
4013 The plain *_OVERFLOW macros run afoul of GCC bug 49705
4014 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
4015 and therefore cause GCC to emit a bogus diagnostic in some cases.
4017 * image.c: Integer signedness and overflow and related fixes.
4018 This is not an exhaustive set of fixes, but it's time to
4019 record what I've got.
4020 (lookup_pixel_color, check_image_size): Remove redundant decls.
4021 (check_image_size): Don't assume that arbitrary EMACS_INT values
4022 fit in 'int', or that arbitrary 'double' values fit in 'int'.
4023 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
4024 (tiff_load, imagemagick_load_image):
4025 Check for overflow in size calculations.
4026 (x_create_x_image_and_pixmap): Remove unnecessary test for
4027 xmalloc returning NULL; that can't happen.
4028 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
4029 (xpm_color_bucket): Use better integer hashing function.
4030 (xpm_cache_color): Don't possibly over-allocate memory.
4031 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
4032 (gif_memory_source):
4033 Use ptrdiff_t, not int or size_t, to record sizes.
4034 (png_load): Don't assume values greater than 2**31 fit in 'int'.
4035 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
4036 either works, as we prefer signed integers.
4037 (tiff_read_from_memory, tiff_write_from_memory):
4038 Return tsize_t, not size_t, since that's what the TIFF API wants.
4039 (tiff_read_from_memory): Don't fail simply because the read would
4040 go past EOF; instead, return a short read.
4041 (tiff_load): Omit no-longer-needed casts.
4042 (Fimagemagick_types): Don't assume size fits into 'int'.
4044 Improve hashing quality when configured --with-wide-int.
4045 * fns.c (hash_string): New function, taken from sxhash_string.
4046 Do not discard information about ASCII character case; this
4047 discarding is no longer needed.
4048 (sxhash-string): Use it. Change sig to match it. Caller changed.
4049 * lisp.h: Declare it.
4050 * lread.c (hash_string): Remove, since we now use fns.c's version.
4051 The fns.c version returns a wider integer if --with-wide-int is
4052 specified, so this should help the quality of the hashing a bit.
4054 * emacs.c: Integer overflow minor fix.
4055 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
4056 Define only if GNU_LINUX.
4057 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
4059 * dispnew.c: Integer signedness and overflow fixes.
4060 Remove unnecessary forward decls, that were a maintenance hassle.
4061 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
4063 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
4064 (scrolling_window): Use ptrdiff_t, not int, for byte count.
4065 (prepare_desired_row, line_draw_cost):
4066 Use int, not unsigned, where either works.
4067 (save_current_matrix, restore_current_matrix):
4068 Use ptrdiff_t, not size_t, where either works.
4069 (init_display): Check for overflow more accurately, and without
4070 relying on undefined behavior.
4072 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
4073 Remove, replacing with the new symbols in lisp.h. All uses changed.
4074 * fileio.c (make_temp_name):
4075 * filelock.c (lock_file_1, lock_file):
4076 * xdisp.c (message_dolog):
4077 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
4078 Use pMd etc. instead.
4079 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
4080 replacing the pWIDE etc. symbols removed from editfns.c.
4082 * keyboard.h (num_input_events): Now uintmax_t.
4083 This is (very slightly) less likely to mess up due to wraparound.
4086 * buffer.c: Integer signedness fixes.
4087 (alloc_buffer_text, enlarge_buffer_text):
4088 Use ptrdiff_t rather than size_t when either will do, as we prefer
4091 * alloc.c: Integer signedness and overflow fixes.
4092 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
4093 (__malloc_size_t): Default to size_t, not to int.
4094 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
4095 (Fgarbage_collect, mark_object_loop_halt, mark_object):
4096 Prefer ptrdiff_t to size_t when either would do, as we prefer
4098 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
4099 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
4100 Now const. Initialize with values that are in range even if char
4102 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
4103 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
4104 These functions do the right thing with sizes > 2**32.
4105 (check_depth): Now ptrdiff_t, not int.
4106 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
4107 Adjust to new way of storing sizes. Check for size overflow bugs
4109 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
4110 slightly wrong anyway, as it missed one instance of
4111 XMALLOC_OVERRUN_CHECK_OVERHEAD.
4112 (refill_memory_reserve): Omit needless cast to size_t.
4113 (mark_object_loop_halt): Mark as externally visible.
4115 * xselect.c: Integer signedness and overflow fixes.
4116 (Fx_register_dnd_atom, x_handle_dnd_message):
4117 Use ptrdiff_t, not size_t, since we prefer signed.
4118 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
4119 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
4120 x_dnd_atoms_size and x_dnd_atoms_length.
4122 * doprnt.c: Prefer signed to unsigned when either works.
4124 * doprnt.c (doprnt):
4126 * xdisp.c (vmessage):
4127 Use ptrdiff_t, not size_t, when using or implementing doprnt,
4128 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
4129 prefer signed arithmetic to avoid comparison confusion.
4130 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
4131 but is a bit tricky.
4133 Assume freestanding C89 headers, string.h, stdlib.h.
4134 * data.c, doprnt.c, floatfns.c, print.c:
4135 Include float.h unconditionally.
4136 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
4137 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
4138 * regex.c: Likewise for stddef.h, string.h.
4139 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
4140 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
4141 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
4142 (STDC_HEADERS): Remove obsolete defines.
4143 * sysdep.c: Include limits.h unconditionally.
4145 Assume support for memcmp, memcpy, memmove, memset.
4146 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
4147 * regex.c (memcmp, memcpy):
4148 Remove; we assume C89 now.
4150 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
4151 (__malloc_safe_bcopy): Remove; no longer needed.
4153 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
4154 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
4155 well either way, and we prefer signed to unsigned.
4157 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
4159 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
4160 closes the connection while we're reading (bug#9182).
4162 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
4164 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
4165 are specified (Bug#9168).
4167 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
4169 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
4170 Found by GCC static checking and --with-wide-int on a 32-bit host.
4172 2011-07-25 Eli Zaretskii <eliz@gnu.org>
4174 * xdisp.c (compute_display_string_pos): Fix logic of caching
4175 previous display string position. Initialize cached_prev_pos to
4176 -1. Fixes slow-down at the beginning of a buffer.
4178 2011-07-24 Eli Zaretskii <eliz@gnu.org>
4180 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
4181 for attrs[LFACE_FONTSET_INDEX].
4183 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
4185 * xml.c (parse_region): Remove unused local
4186 that was recently introduced.
4188 2011-07-23 Eli Zaretskii <eliz@gnu.org>
4190 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
4191 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
4193 * xdisp.c (move_it_in_display_line_to): Record the best matching
4194 position for TO_CHARPOS while scanning the line, and restore it on
4195 exit if none of the characters scanned was an exact match.
4196 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
4197 when exact match is impossible due to invisible text, and the
4198 lines are truncated.
4200 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
4202 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
4205 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4207 Fix a significant slow-down of cursor motion with C-n, C-p,
4208 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
4209 auto-repeat under bidi redisplay in fontified buffers.
4210 * xdisp.c (compute_stop_pos_backwards): New function.
4211 (next_element_from_buffer): Call compute_stop_pos_backwards to
4212 find a suitable prev_stop when we find ourselves before
4214 (reseat): Don't look for prev_stop, as that could mean a very long
4216 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
4217 <cached_disp_overlay_modiff>: Cache for last found display string
4219 (compute_display_string_pos): Return the cached position if asked
4220 about the same buffer in the same area of character positions, and
4221 the buffer wasn't changed since the time the display string
4222 position was cached.
4224 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4226 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4227 is an integer, which is important for empty lines. (Bug#9149)
4229 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
4231 * frame.c (Fmodify_frame_parameters): In tty case, update the
4232 default face if necessary (Bug#4238).
4234 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
4236 * editfns.c (Fstring_to_char): No need to explain what a character
4237 is in the docstring (Bug#6576).
4239 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4241 * xml.c (parse_region): Make sure we always return a tree.
4243 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4245 * xml.c (parse_region): If a document contains only comments,
4248 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4250 * xml.c (make_dom): Return comments, too.
4252 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4255 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4256 and the surrounding thread.
4257 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4258 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4259 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4261 * s/openbsd.h (BROKEN_SIGIO): Define.
4262 * unexelf.c (unexec) [__OpenBSD__]:
4263 Don't update the .mdebug section of the Alpha COFF symbol table.
4265 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4267 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4270 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4272 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4273 This fixes some race conditions on the permissions of any newly
4276 * alloc.c (valid_pointer_p): Use pipe, not open.
4277 This fixes some permissions issues when debugging.
4279 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4280 If fchown fails to set both uid and gid, try to set just gid,
4281 as that is sometimes allowed. Adjust the file's mode to eliminate
4282 setuid or setgid bits that are inappropriate if fchown fails.
4284 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4286 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4287 to compare Lisp_Objects.
4288 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4289 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4290 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4292 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4294 * lread.c (read_integer): Unread even EOF character.
4295 (read1): Likewise. Properly record start position of symbol.
4297 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4298 symbol character follows.
4300 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4302 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4303 This works around a problem with the previous change to Fcopy_file.
4304 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4305 and without this change, GCC might complain about discarding
4306 fchown's return value.
4308 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
4310 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4312 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4314 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4316 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4318 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4319 it's used from the C level.
4321 * process.c: Use the same condition for POLL_FOR_INPUT in both
4322 keyboard.c and process.c (bug#1858).
4324 2011-07-09 Lawrence Mitchell <wence@gmx.li>
4326 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4327 (Fgnutls_boot): Use it.
4329 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4331 * doc.c (Fsubstitute_command_keys): Revert last change.
4333 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4335 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4336 quotes the next character, and doesn't affect other longer
4337 sequences (bug#8935).
4339 * lread.c (syms_of_lread): Clarify that is isn't only
4340 `eval-buffer' and `eval-defun' that's affected by
4341 `lexical-binding' (bug#8460).
4343 2011-07-15 Eli Zaretskii <eliz@gnu.org>
4345 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
4346 bidi redisplay when a line includes both an image and is truncated.
4348 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4350 Fix minor problems found by static checking.
4351 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4352 (elsz): Now a signed constant, not a size_t var. We prefer signed
4353 types to unsigned, to avoid integer comparison confusion. Without
4354 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4355 "cannot optimize loop, the loop counter may overflow", a symptom
4357 * indent.c (Fvertical_motion): Mark locals as initialized.
4358 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4360 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4362 * search.c (Fre_search_backward): Mention `case-fold-search' in
4363 all the re_search_* functions (bug#8138).
4365 * keyboard.c (Fopen_dribble_file): Document when the file is
4368 2011-07-14 Eli Zaretskii <eliz@gnu.org>
4370 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4373 Support bidi reordering of display and overlay strings.
4374 * xdisp.c (compute_display_string_pos)
4375 (compute_display_string_end): Accept additional argument STRING.
4376 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4377 (reseat_to_string): Initialize bidi_it->string.s and
4378 bidi_it->string.schars.
4379 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
4380 NULL (avoids a crash in bidi_paragraph_init).
4381 Initialize itb.string.lstring.
4382 (init_iterator): Call bidi_init_it only of a valid
4383 buffer position was specified. Initialize paragraph_embedding to
4385 (reseat_to_string): Initialize the bidi iterator.
4386 (display_string): If we need to ignore text properties of
4387 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4388 original value of -1 will not work with bidi.)
4389 (compute_display_string_pos): First arg is now struct
4390 `text_pos *'; all callers changed. Support display properties on
4392 (compute_display_string_end): Support display properties on Lisp
4394 (init_iterator, reseat_1, reseat_to_string): Initialize the
4395 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4396 when iterating on a string not from display properties).
4397 (compute_display_string_pos, compute_display_string_end):
4398 Fix calculation of the object to scan. Fixes an error when using
4400 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4401 base_level_stop; instead, set base_level_stop to BEGV.
4402 Fixes crashes in vertical-motion.
4403 (next_element_from_buffer): Improve commentary for when
4404 the iterator is before prev_stop.
4405 (init_iterator): Initialize bidi_p from the default value of
4406 bidi-display-reordering, not from buffer-local value. Use the
4407 buffer-local value only if initializing for buffer iteration.
4408 (handle_invisible_prop): Support invisible properties on strings
4409 that are being bidi-reordered.
4410 (set_iterator_to_next): Support bidi reordering of C strings and
4412 (next_element_from_string): Support bidi reordering of Lisp
4414 (handle_stop_backwards): Support Lisp strings as well.
4415 (display_string): Support display of R2L glyph rows.
4416 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4417 (init_iterator): Don't initialize it->bidi_p for strings
4419 (reseat_to_string): Initialize it->bidi_p for strings here.
4420 (next_element_from_string, next_element_from_c_string)
4421 (next_element_from_buffer): Add xassert's for correspondence
4422 between IT's object being iterated and it->bidi_it.string
4424 (face_before_or_after_it_pos): Support bidi iteration.
4425 (next_element_from_c_string): Handle the case of the first string
4426 character that is not the first one in the visual order.
4427 (get_visually_first_element): New function, refactored from common
4428 parts of next_element_from_buffer, next_element_from_string, and
4429 next_element_from_c_string.
4430 (tool_bar_lines_needed, redisplay_tool_bar)
4431 (display_menu_bar): Force left-to-right direction. Add a FIXME
4432 comment for making that be controlled by a user option.
4433 (push_it, pop_it): Save and restore the state of the
4434 bidi iterator. Save and restore the bidi_p flag.
4435 (pop_it): Iterate out of display property for string iteration as
4437 (iterate_out_of_display_property): Support iteration over strings.
4438 (handle_single_display_spec): Set up it->bidi_it for iteration
4439 over a display string, and call bidi_init_it.
4440 (handle_single_display_spec, next_overlay_string)
4441 (get_overlay_strings_1, push_display_prop): Set up the bidi
4442 iterator for displaying display or overlay strings.
4443 (forward_to_next_line_start): Don't use the shortcut if
4445 (back_to_previous_visible_line_start): If handle_display_prop
4446 pushed the iterator stack, restore the internal state of the bidi
4447 iterator by calling bidi_pop_it same number of times.
4448 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4449 and we are bidi-iterating, don't decrement the iterator position;
4450 instead, set the first_elt flag in the bidi iterator, to produce
4452 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4453 (push_display_prop): xassert that we are iterating a buffer.
4454 (push_it, pop_it): Save and restore paragraph_embedding member.
4455 (handle_single_display_spec, next_overlay_string)
4456 (get_overlay_strings_1, reseat_1, reseat_to_string)
4457 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4458 correctly. Don't assume unibyte strings are not bidi-reordered.
4459 (compute_display_string_pos)
4460 (compute_display_string_end): Fix handling the case of C string.
4461 (push_it, pop_it): Save and restore from_disp_prop_p.
4462 (handle_single_display_spec, push_display_prop): Set the
4463 from_disp_prop_p flag.
4464 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4465 (pop_it): Call iterate_out_of_display_property only if we are
4466 popping after iteration over a string that came from a display
4467 property. Fix a typo in popping stretch info. Add an assertion
4468 for verifying that the iterator position is in sync with the bidi
4470 (handle_single_display_spec, get_overlay_strings_1)
4471 (push_display_prop): Fix initialization of paragraph direction for
4472 string when that of the parent object is not yet determined.
4473 (reseat_1): Call bidi_init_it to resync the bidi
4474 iterator with IT's position. (Bug#7616)
4475 (find_row_edges): If ROW->start.pos gives position
4476 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4477 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4478 Reset the from_disp_prop_p flag.
4479 (SAVE_IT, RESTORE_IT): New macros.
4480 (pos_visible_p, face_before_or_after_it_pos)
4481 (back_to_previous_visible_line_start)
4482 (move_it_in_display_line_to, move_it_in_display_line)
4483 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4484 (try_scrolling, redisplay_window, display_line): Use them when
4485 saving a temporary copy of the iterator and restoring it back.
4486 (back_to_previous_visible_line_start, reseat_1)
4487 (init_iterator): Empty the bidi cache "stack".
4488 (move_it_in_display_line_to): If iterator ended up at
4489 EOL, but we never saw any buffer positions smaller than
4490 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4491 motion in bidi-reordered lines.
4492 (move_it_in_display_line_to): Record prev_method and prev_pos
4493 immediately before the call to set_iterator_to_next. Fixes cursor
4494 motion in bidi-reordered lines with stretch glyphs and strings
4495 displayed in margins. (Bug#8133) (Bug#8867)
4496 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4498 (pos_visible_p): Support positions in bidi-reordered lines.
4499 Save and restore bidi cache.
4501 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4502 (bidi_paragraph_info): Delete unused struct.
4503 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4504 (bidi_cache_start): New variable.
4505 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4507 (bidi_cache_fetch_state, bidi_cache_search)
4508 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4509 (bidi_cache_find, bidi_peek_at_next_level)
4510 (bidi_level_of_next_char, bidi_find_other_level_edge)
4511 (bidi_move_to_visually_next): Compare cache index with
4512 bidi_cache_start rather than with zero.
4513 (bidi_fetch_char): Accept new argument STRING; all callers
4514 changed. Support iteration over a string. Support strings with
4515 display properties. Support unibyte strings. Fix the type of
4516 `len' according to what STRING_CHAR_AND_LENGTH expects.
4517 (bidi_paragraph_init, bidi_resolve_explicit_1)
4518 (bidi_resolve_explicit, bidi_resolve_weak)
4519 (bidi_level_of_next_char, bidi_move_to_visually_next):
4520 Support iteration over a string.
4521 (bidi_set_sor_type, bidi_resolve_explicit_1)
4522 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4523 can now be zero (for strings); special values 0 and -1 were
4524 changed to -1 and -2, respectively.
4525 (bidi_char_at_pos): New function.
4526 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4527 Call it instead of FETCH_MULTIBYTE_CHAR.
4528 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4529 initialized to valid values.
4530 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4532 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4533 the test for valid cached positions. Fix the logic for looking up
4534 the sentinel state in the cache. GCPRO the Lisp string we are
4536 (bidi_push_it, bidi_pop_it): New functions.
4537 (bidi_initialize): Initialize the bidi cache start stack pointer.
4538 (bidi_cache_ensure_space): New function, refactored from part of
4539 bidi_cache_iterator_state. Don't assume the required size is just
4540 one BIDI_CACHE_CHUNK away.
4541 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4542 (bidi_count_bytes, bidi_char_at_pos): New functions.
4543 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4544 always valid if bidi_cache_idx is valid.
4545 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4546 is valid if it's going to be used.
4547 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4548 (bidi_cache_fetch_state, bidi_cache_search)
4549 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4550 (bidi_cache_iterator_state, bidi_cache_find)
4551 (bidi_find_other_level_edge, bidi_cache_start_stack):
4552 All variables related to cache indices are now EMACS_INT.
4554 * dispextern.h (struct bidi_string_data): New structure.
4555 (struct bidi_it): New member `string'. Make flag members be 1-bit
4556 fields, and put them last in the struct.
4557 (compute_display_string_pos, compute_display_string_end):
4559 (bidi_push_it, bidi_pop_it): Add prototypes.
4560 (struct iterator_stack_entry): New members bidi_p,
4561 paragraph_embedding, and from_disp_prop_p.
4562 (struct it): Member bidi_p is now a bit field 1 bit wide.
4563 (bidi_shelve_cache, bidi_unshelve_cache):
4566 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4567 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4568 and vector-like objects.
4570 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4571 cache around display iteration.
4573 * window.c (Fwindow_end, window_scroll_pixel_based)
4574 (displayed_window_lines, Frecenter): Save and restore the bidi
4575 cache around display iteration.
4577 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4579 * editfns.c (Fdelete_region): Clarify the use of the named
4580 parameters (bug#6788).
4582 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4584 * indent.c (Fvertical_motion): Set and restore w->pointm when
4585 saving and restoring the window's buffer (Bug#9006).
4587 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4589 * editfns.c (Fstring_to_char): Clarify just what is returned
4590 (bug#6576). Text by Eli Zaretskii.
4592 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4594 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4596 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4598 * buffer.c (mmap_find): Fix a typo.
4600 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4602 Fix execution of x selection hooks.
4603 * xselect.c (Qx_lost_selection_functions)
4604 (Qx_sent_selection_functions): New vars.
4605 (syms_of_xselect): DEFSYM them.
4606 (x_handle_selection_request): Pass Qx_sent_selection_functions
4607 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4608 (x_handle_selection_clear,x_clear_frame_selections):
4609 Pass Qx_lost_selection_functions rather than
4610 Vx_lost_selection_functions to Frun_hook_with_args.
4612 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4614 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4615 The old code sometimes used this field without initializing it.
4617 * alloc.c (gc_sweep): Don't read past end of array.
4618 In theory, the old code could also have corrupted Emacs internals,
4619 though it'd be very unlikely.
4621 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4623 * character.c (Fcharacterp): Don't advertise optional ignored
4624 argument. (Bug#4026)
4626 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4628 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4631 * window.c (Fset_window_start): Doc fix (bug#4199).
4632 (Fset_window_hscroll): Ditto.
4634 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4636 Fix minor new problems caught by GCC 4.6.1.
4637 * term.c (init_tty): Remove unused local.
4638 * xsettings.c (store_monospaced_changed): Define this function only
4639 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4642 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4644 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4646 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4648 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4649 are the mini-buffer and the echo area (bug#3320).
4651 * term.c (init_tty): Remove support for supdup, c10 and perq
4652 terminals, which are no longer supported (bug#1482).
4654 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4656 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4658 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4660 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4661 for non-popups (Bug#3642).
4663 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4665 * alloc.c (reset_malloc_hooks): Protoize.
4666 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4667 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4668 * cm.c (losecursor): Likewise.
4669 * data.c (fmod): Likewise.
4670 * dispnew.c (swap_glyphs_in_rows): Likewise.
4671 * emacs.c (memory_warning_signal): Likewise.
4672 * floatfns.c (float_error): Likewise.
4673 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4674 (otf_open, font_otf_capability, generate_otf_features)
4675 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4677 * image.c (pbm_read_file): Likewise.
4678 * indent.c (string_display_width): Likewise.
4679 * intervals.c (check_for_interval, search_for_interval)
4680 (inc_interval_count, count_intervals, root_interval)
4681 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4682 * lread.c (defalias): Likewise.
4683 * ralloc.c (r_alloc_check): Likewise.
4684 * regex.c (set_image_of_range_1, set_image_of_range)
4685 (regex_grow_registers): Likewise.
4686 * sysdep.c (strerror): Likewise.
4687 * termcap.c (valid_filename_p, tprint, main): Likewise.
4688 * tparam.c (main): Likewise.
4689 * unexhp9k800.c (run_time_remap, save_data_space)
4690 (update_file_ptrs, read_header, write_header, calculate_checksum)
4691 (copy_file, copy_rest, display_header): Likewise.
4692 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4694 * xdisp.c (check_it): Likewise.
4695 * xfaces.c (register_color, unregister_color, unregister_colors):
4697 * xfns.c (print_fontset_result): Likewise.
4698 * xrdb.c (member, fatal, main): Likewise.
4700 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4702 Fix minor problems found by static checking (Bug#9031).
4703 * chartab.c (char_table_set_range, map_sub_char_table):
4704 Remove unused locals.
4705 (uniprop_table): Now static.
4706 * composite.c (_work_char): Remove unused static var.
4708 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4710 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4712 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4714 * gtkutil.c (qttip_cb): Remove code without function.
4716 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4718 * w32.c (pthread_sigmask): New stub.
4720 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4722 Use pthread_sigmask, not sigprocmask (Bug#9010).
4723 sigprocmask is portable only for single-threaded applications, and
4724 Emacs can be multi-threaded when it uses GTK.
4725 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4727 * callproc.c (Fcall_process):
4728 * process.c (create_process):
4729 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4730 Use pthread_sigmask, not sigprocmask.
4732 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4734 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4735 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4738 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4740 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4741 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4742 (xg_hide_tooltip): Fix comment.
4744 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4745 in registerServicesMenuSendTypes.
4746 (validRequestorForSendType): Don't check ns_return_types.
4748 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4751 2011-07-08 Jason Rumney <jasonr@gnu.org>
4753 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4754 SH_SHOW for hidden windows (Bug#5482).
4756 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4757 frame struct members of non-existent frames (Bug#6284).
4759 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4761 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4762 variable firstTime not needed on OSX >= 10.6.
4763 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4764 >= 10.5. Use setKnobProportion, setDoubleValue.
4766 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4767 (MAC_OS_X_VERSION_10_5): Define if not defined.
4768 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4769 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4770 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4772 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4773 cString and lossyCString on OSX >= 10.4
4775 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4776 sizeToFit on OSX >= 10.2.
4778 * nsimage.m (allocInitFromFile): Don't use deprecated method
4779 bestRepresentationForDevice on OSX >= 10.6.
4781 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4784 * emacs.c: Declare unexec_init_emacs_zone.
4786 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4788 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4790 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4791 on svcsMenu (Bug#8842).
4793 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4795 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4797 * nsterm.m (QUTF8_STRING): Declare.
4798 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4799 (validRequestorForSendType): Return type is (id).
4800 Change indexOfObjectIdenticalTo to indexOfObject.
4801 Check if we have local selection before returning self (Bug#8842).
4802 (writeSelectionToPasteboard): Put local selection into paste board
4803 if we have a local selection (Bug#8842).
4804 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4806 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4807 (ns_get_local_selection): Declare.
4809 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4811 * keymap.c (describe_map_tree): Don't insert a double newline at
4812 the end of the buffer (bug#1169) and return whether we inserted
4815 * callint.c (Fcall_interactively): Change "reading args" to
4816 "providing args" to try to clarify what it does (bug#1010).
4818 2011-07-07 Kenichi Handa <handa@m17n.org>
4820 * composite.c (composition_compute_stop_pos): Ignore a static
4821 composition starting before CHARPOS (Bug#8915).
4823 * xdisp.c (handle_composition_prop): Likewise.
4825 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4827 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4830 2011-07-07 Kenichi Handa <handa@m17n.org>
4832 * character.h (unicode_category_t): New enum type.
4834 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4835 (Qchar_code_property_table): New variable.
4836 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4837 (UNIPROP_COMPRESSED_FORM_P): New macros.
4838 (char_table_ascii): Uncompress the compressed values.
4839 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4840 Uncompress the compressed values.
4841 (sub_char_table_ref_and_range): Likewise.
4842 (char_table_ref_and_range): Uncompress the compressed values.
4843 (sub_char_table_set): New arg is_uniprop. Callers changed.
4844 Uncompress the compressed values.
4845 (sub_char_table_set_range): Args changed. Callers changed.
4846 (char_table_set_range): Adjuted for the above change.
4847 (map_sub_char_table): Delete args default_val and parent. Add arg
4848 top. Give decoded values to a Lisp function.
4849 (map_char_table): Adjust for the above change. Give decoded
4850 values to a Lisp function. Gcpro more variables.
4851 (uniprop_table_uncompress)
4852 (uniprop_decode_value_run_length): New functions.
4853 (uniprop_decoder, uniprop_decoder_count): New variables.
4854 (uniprop_get_decoder, uniprop_encode_value_character)
4855 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4857 (uniprop_encoder, uniprop_encoder_count): New variables.
4858 (uniprop_get_encoder, uniprop_table)
4859 (Funicode_property_table_internal, Fget_unicode_property_internal)
4860 (Fput_unicode_property_internal): New functions.
4861 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4862 Sunicode_property_table_internal, Sget_unicode_property_internal,
4863 and Sput_unicode_property_internal. Defvar_lisp
4864 char-code-property-alist.
4866 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4867 Vunicode_category_table.
4869 * font.c (font_range): Adjust for the change of
4870 Vunicode_category_table.
4872 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4874 * m/iris4d.h: Remove file, move contents ...
4875 * s/irix6-5.h: ... here.
4877 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4879 Remove unportable assumption about struct layout (Bug#8884).
4880 * alloc.c (mark_buffer):
4881 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4882 (clone_per_buffer_values): Don't assume that
4883 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4884 This isn't true in general, and it's particularly not true
4885 if Emacs is configured with --with-wide-int.
4886 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4887 New macros, used in the buffer.c change.
4889 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4891 * xsettings.c: Use both GConf and GSettings if both are available.
4892 (store_config_changed_event): Add comment.
4893 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4894 (store_tool_bar_style_changed): New functions.
4895 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4896 (struct xsettings): Move font inside HAVE_XFT.
4897 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4898 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4899 Move inside HAVE_XFT.
4900 (something_changed_gsettingsCB): Rename from something_changedCB.
4901 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4903 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4904 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4905 (something_changed_gconfCB): Rename from something_changedCB.
4906 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4907 (parse_settings): Move check for font inside HAVE_XFT.
4908 (read_settings, apply_xft_settings): Add comment.
4909 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4910 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4911 call store_font_name_changed.
4912 (xft_settings_event): Add comment.
4913 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4914 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4915 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4916 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4917 (xsettings_initialize): Call init_gsettings last.
4918 (xsettings_get_system_font, xsettings_get_system_normal_font):
4921 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4923 Random fixes. E.g., (random) never returned negative values.
4924 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4925 subseconds part to the entropy, as that's a bit more random.
4926 Prefer signed to unsigned, since the signedness doesn't matter and
4927 in general we prefer signed. When given a limit, use a
4928 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4929 latter isn't right if USE_2_TAGS_FOR_INTS.
4930 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4931 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4933 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4935 * textprop.c (text_property_stickiness):
4936 Obey Vtext_property_default_nonsticky.
4937 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4938 * w32fns.c (syms_of_w32fns):
4939 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4941 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4943 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4944 This is more efficient than Ffile_directory_p and avoids a minor race.
4946 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4948 * buffer.c (Foverlay_put): Say what the return value is
4951 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4952 is a directory before asking whether to use the file name
4954 (barf_or_query_if_file_exists): Make the "File is a directory"
4955 error be more correct.
4957 * fns.c (Frequire): Remove the mention of the .gz files, since
4958 that's installation-specific, but keep the mention of
4959 `get-load-suffixes'.
4961 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4963 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4964 Report string overflow if the output is too long.
4966 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4968 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4969 (syms_of_gnutls): Remove duplicate DEFSYM for
4970 Qgnutls_bootprop_verify_hostname_error, an error for
4971 Qgnutls_bootprop_verify_error (which is no longer used).
4973 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4974 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4975 Also (re)move comments that are misplaced or no longer relevant.
4977 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4979 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4981 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4983 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4984 and background color parameters if they have been changed.
4986 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4988 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4990 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4992 * xsettings.c (SYSTEM_FONT): Define only when used.
4993 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4995 * keymap.c (access_keymap_1): Now static.
4997 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4999 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
5000 leave any prefix arg for the up event (Bug#1586).
5002 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
5004 * lread.c (syms_of_lread): Mention single symbols defined by
5005 `defvar' or `defconst' (bug#7154).
5007 * fns.c (Frequire): Mention .el.gz files (bug#7314).
5008 (Frequire): Mention get-load-suffixes.
5010 2011-07-02 Martin Rudalics <rudalics@gmx.at>
5012 * window.h (window): Remove clone_number slot.
5013 * window.c (Fwindow_clone_number, Fset_window_clone_number):
5015 (make_parent_window, make_window, saved_window)
5016 (Fset_window_configuration, save_window_save): Don't deal with
5018 * buffer.c (Qclone_number): Remove declaration.
5019 (sort_overlays, overlay_strings): Don't deal with clone numbers.
5021 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
5023 Add multiple inheritance to keymaps.
5024 * keymap.c (Fmake_composed_keymap): New function.
5025 (Fset_keymap_parent): Simplify.
5026 (fix_submap_inheritance): Remove.
5027 (access_keymap_1): New function extracted from access_keymap to handle
5028 embedded parents and handle lists of maps.
5029 (access_keymap): Use it.
5030 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
5031 (Fcopy_keymap): Handle embedded parents.
5032 (Fcommand_remapping, define_as_prefix): Simplify.
5033 (Fkey_binding): Simplify.
5034 (syms_of_keymap): Move minibuffer-local-completion-map,
5035 minibuffer-local-filename-completion-map,
5036 minibuffer-local-must-match-map, and
5037 minibuffer-local-filename-must-match-map to Elisp.
5038 (syms_of_keymap): Defsubr make-composed-keymap.
5039 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
5040 (parse_menu_item): Trivial simplification.
5042 2011-07-01 Glenn Morris <rgm@gnu.org>
5044 * Makefile.in (SETTINGS_LIBS): Fix typo.
5046 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
5048 * coding.c (Fencode_coding_string): Record the last coding system
5049 used, as the function doc string says (bug#8738).
5051 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
5053 * xsettings.c (store_monospaced_changed): Take new font as arg and
5054 check for change against current_mono_font.
5055 (EMACS_TYPE_SETTINGS): Remove this and related defines.
5056 (emacs_settings_constructor, emacs_settings_get_property)
5057 (emacs_settings_set_property, emacs_settings_class_init)
5058 (emacs_settings_init, gsettings_obj): Remove.
5059 (something_changedCB): New function for HAVE_GSETTINGS.
5060 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
5061 with value as argument.
5062 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
5063 g_settings_new (Bug#8967). Do not create gsettings_obj.
5064 Remove calls to g_settings_bind. Connect something_changedCB to
5067 * xgselect.c: Add defined (HAVE_GSETTINGS).
5068 (xgselect_initialize): Ditto.
5070 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
5071 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
5074 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
5076 * eval.c (struct backtrace): Simplify and port the data structure.
5077 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
5078 signed bit field, as this assumption is not portable and it makes
5079 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
5080 "char debug_on_exit : 1" as this is not portable either; instead,
5081 use the portable "unsigned int debug_on_exit : 1". Remove unused
5082 member evalargs. Remove obsolete comments about cc bombing out.
5084 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
5086 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
5087 Let HAVE_GSETTINGS override HAVE_GCONF.
5088 (store_monospaced_changed): New function.
5089 (EMACS_SETTINGS): A new type derived from GObject to handle
5090 GSettings notifications.
5091 (emacs_settings_constructor, emacs_settings_get_property)
5092 (emacs_settings_set_property, emacs_settings_class_init):
5094 (gsettings_client, gsettings_obj): New variables.
5095 (GSETTINGS_SCHEMA): New define.
5096 (something_changedCB): Call store_monospaced_changed.
5097 (init_gsettings): New function.
5098 (xsettings_initialize): Call init_gsettings.
5099 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
5102 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
5105 2011-06-29 Martin Rudalics <rudalics@gmx.at>
5107 * window.c (resize_root_window, grow_mini_window)
5108 (shrink_mini_window): Rename Qresize_root_window to
5109 Qwindow_resize_root_window and Qresize_root_window_vertically to
5110 Qwindow_resize_root_window_vertically.
5112 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
5114 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
5116 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
5118 * makefile.w32-in: Redesign dependencies so they reflect more
5119 clearly which files are directly included by each source file,
5120 and not through other includes.
5122 2011-06-27 Martin Rudalics <rudalics@gmx.at>
5124 * buffer.c (Qclone_number): Declare static and DEFSYM it.
5125 (sort_overlays, overlay_strings): When an overlay's clone number
5126 matches the window's clone number process the overlay even if
5127 the overlay's window property doesn't match the current window.
5129 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
5130 (Fwindow_hchild): Rename to Fwindow_left_child.
5131 (Fwindow_next): Rename to Fwindow_next_sibling.
5132 (Fwindow_prev): Rename to Fwindow_prev_sibling.
5133 (resize_window_check): Rename to window_resize_check.
5134 (resize_window_apply): Rename to window_resize_apply.
5135 (Fresize_window_apply): Rename to Fwindow_resize_apply.
5136 (Fdelete_other_windows_internal, resize_frame_windows)
5137 (Fsplit_window_internal, Fdelete_window_internal)
5138 (grow_mini_window, shrink_mini_window)
5139 (Fresize_mini_window_internal): Fix callers accordingly.
5141 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
5143 * emacsgtkfixed.h: State that this is only used with Gtk+3.
5144 (emacs_fixed_set_min_size): Remove.
5145 (emacs_fixed_new): Take frame as argument.
5147 * emacsgtkfixed.c: State that this is only used with Gtk+3.
5148 (_EmacsFixedPrivate): Remove minwidth/height.
5149 Add struct frame *f.
5150 (emacs_fixed_init): Initialize priv->f.
5151 (get_parent_class, emacs_fixed_set_min_size): Remove.
5152 (emacs_fixed_new): Set priv->f to argument.
5153 (emacs_fixed_get_preferred_width)
5154 (emacs_fixed_get_preferred_height): Use min_width/height from
5155 frames size_hint to set minimum and natural (Bug#8919).
5156 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
5157 and use min_width/height from frames size_hint to set
5158 min_width/height (Bug#8919).
5160 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
5161 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
5164 2011-06-26 Eli Zaretskii <eliz@gnu.org>
5166 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
5167 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
5170 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
5172 * process.c (wait_reading_process_output): Bypass select if
5173 waiting for a cell while ignoring keyboard input, and input is
5174 pending. Suggested by Jan Djärv (Bug#8869).
5176 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
5178 Use gnulib's dup2 module instead of rolling our own.
5179 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
5181 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5183 * dispnew.c (scrolling_window): Before scrolling, turn off a
5184 mouse-highlight in the window being scrolled.
5186 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
5188 Move DEFSYM to lisp.h and use everywhere.
5190 * character.h (DEFSYM): Move declaration...
5191 * lisp.h (DEFSYM): ...here.
5197 * w32select.c: Don't include character.h.
5199 * alloc.c (syms_of_alloc):
5200 * buffer.c (syms_of_buffer):
5201 * bytecode.c (syms_of_bytecode):
5202 * callint.c (syms_of_callint):
5203 * casefiddle.c (syms_of_casefiddle):
5204 * casetab.c (init_casetab_once):
5205 * category.c (init_category_once, syms_of_category):
5206 * ccl.c (syms_of_ccl):
5207 * cmds.c (syms_of_cmds):
5208 * composite.c (syms_of_composite):
5209 * dbusbind.c (syms_of_dbusbind):
5210 * dired.c (syms_of_dired):
5211 * dispnew.c (syms_of_display):
5212 * doc.c (syms_of_doc):
5213 * editfns.c (syms_of_editfns):
5214 * emacs.c (syms_of_emacs):
5215 * eval.c (syms_of_eval):
5216 * fileio.c (syms_of_fileio):
5217 * fns.c (syms_of_fns):
5218 * frame.c (syms_of_frame):
5219 * fringe.c (syms_of_fringe):
5220 * insdel.c (syms_of_insdel):
5221 * keymap.c (syms_of_keymap):
5222 * lread.c (init_obarray, syms_of_lread):
5223 * macros.c (syms_of_macros):
5224 * msdos.c (syms_of_msdos):
5225 * print.c (syms_of_print):
5226 * process.c (syms_of_process):
5227 * search.c (syms_of_search):
5228 * sound.c (syms_of_sound):
5229 * syntax.c (init_syntax_once, syms_of_syntax):
5230 * terminal.c (syms_of_terminal):
5231 * textprop.c (syms_of_textprop):
5232 * undo.c (syms_of_undo):
5233 * w32.c (globals_of_w32):
5234 * window.c (syms_of_window):
5235 * xdisp.c (syms_of_xdisp):
5236 * xfaces.c (syms_of_xfaces):
5237 * xfns.c (syms_of_xfns):
5238 * xmenu.c (syms_of_xmenu):
5239 * xsettings.c (syms_of_xsettings):
5240 * xterm.c (syms_of_xterm): Use DEFSYM.
5242 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5244 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
5246 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5248 Integer and buffer overflow fixes (Bug#8873).
5250 * print.c (printchar, strout): Check for string overflow.
5251 (PRINTPREPARE, printchar, strout):
5252 Don't set size unless allocation succeeds.
5254 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5255 for sizes. Check for string overflow more accurately.
5256 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5258 * macros.c: Integer and buffer overflow fixes.
5259 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5260 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5261 Use ptrdiff_t, not int, for sizes.
5262 Don't increment bufsize until after realloc succeeds.
5263 Check for size-calculation overflow.
5264 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5266 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5268 * lread.c: Integer overflow fixes.
5269 (read_integer): Radix is now EMACS_INT, not int,
5270 to improve quality of diagnostics for out-of-range radices.
5271 Calculate buffer size correctly for out-of-range radices.
5272 (read1): Check for integer overflow in radices, and in
5273 read-circle numbers.
5274 (read_escape): Avoid int overflow.
5275 (Fload, openp, read_buffer_size, read1)
5276 (substitute_object_recurse, read_vector, read_list, map_obarray):
5277 Use ptrdiff_t, not int, for sizes.
5278 (read1): Use EMACS_INT, not int, for sizes.
5279 Check for size overflow.
5281 * image.c (cache_image): Check for size arithmetic overflow.
5283 * lread.c: Integer overflow issues.
5284 (saved_doc_string_size, saved_doc_string_length)
5285 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5286 Now ptrdiff_t, not int.
5287 (read1): Don't assume doc string length fits in int. Check for
5288 out-of-range doc string lengths.
5289 (read_list): Don't assume file position fits in int.
5290 (read_escape): Check for hex character overflow.
5292 2011-06-22 Leo Liu <sdl.web@gmail.com>
5294 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5295 Move to minibuffer.el.
5297 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5299 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
5300 The following patches are for when GLYPH_DEBUG && !XASSERT.
5301 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5302 * dispnew.c (flush_stdout):
5303 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5304 Mark as externally visible.
5305 * dispnew.c (check_window_matrix_pointers): Now static.
5306 * dispnew.c (window_to_frame_vpos):
5307 * xfns.c (unwind_create_frame):
5308 * xterm.c (x_check_font): Remove unused local.
5309 * scroll.c (CHECK_BOUNDS):
5310 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5311 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5312 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5313 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5314 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5316 (debug_method_add): Use va_list and vsprintf rather than relying
5317 on undefined behavior with wrong number of arguments.
5318 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5319 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5320 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5321 since we're not interested in debugging glyphs with old libraries.
5322 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5323 GCC 4.6.0's static checking.
5325 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5327 Integer overflow and signedness fixes (Bug#8873).
5328 A few related buffer overrun fixes, too.
5330 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5332 * dispextern.h (struct face.stipple):
5333 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5334 (x_bitmap_mask, x_allocate_bitmap_record)
5335 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5336 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5337 (x_create_bitmap_from_xpm_data):
5338 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5339 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5341 * xfaces.c (load_pixmap):
5342 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5343 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5344 (.bitmaps_last, struct x_output.icon_bitmap):
5345 Use ptrdiff_t, not int, for bitmap indexes.
5346 (x_allocate_bitmap_record): Check for size overflow.
5347 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5349 Use ptrdiff_t, not int, for overlay counts.
5350 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5351 * editfns.c (overlays_around, get_pos_property):
5352 * textprop.c (get_char_property_and_overlay):
5353 * xdisp.c (next_overlay_change, note_mouse_highlight):
5354 * xfaces.c (face_at_buffer_position):
5355 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5356 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5357 (Fnext_overlay_change, Fprevious_overlay_change)
5358 (mouse_face_overlay_overlaps, Foverlays_in):
5359 Use ptrdiff_t, not int, for sizes.
5360 (overlays_at, overlays_in): Check for size-calculation overflow.
5362 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5364 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5365 (x_session_initialize): Do not assume string length fits in int.
5367 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5368 This is unlikely, but can occur if DPI is outlandish.
5370 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
5371 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5373 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5374 * xrdb.c (magic_file_p, search_magic_path):
5375 Omit last arg SUFFIX; it was always 0. All callers changed.
5376 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5378 * xfont.c (xfont_match): Avoid need for strlen.
5380 * xfns.c: Don't assume strlen fits in int.
5381 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5383 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5384 not unsigned long, as we prefer signed integers. All callers changed.
5385 Detect integer overflow in repeat count.
5386 (message_dolog): Don't assume print length fits in 39 bytes.
5387 (display_mode_element): Don't assume strlen fits in int.
5389 * termcap.c: Don't assume sizes fit in int and never overflow.
5390 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5391 (gobble_line): Check for size-calculation overflow.
5393 * minibuf.c (Fread_buffer):
5394 * lread.c (intern, intern_c_string):
5395 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5396 Don't assume string length fits in int.
5398 * keyboard.c (parse_tool_bar_item):
5399 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5401 * font.c: Don't assume string length fits in int.
5402 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5403 Use ptrdiff_t, not int.
5404 (font_intern_prop): Don't assume string length fits in int.
5405 Don't assume integer property fits in fixnum.
5406 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5408 * filelock.c: Fix some buffer overrun and integer overflow issues.
5409 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5410 Reformulate so as not to need the command string.
5411 Invoke gzip -cd rather than gunzip, as it's more portable.
5412 (lock_info_type, lock_file_1, lock_file):
5413 Don't assume pid_t and time_t fit in unsigned long.
5414 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5415 (current_lock_owner): Prefer signed type for sizes.
5416 Use memcpy, not strncpy, where memcpy is what is really wanted.
5417 Don't assume (via atoi) that time_t and pid_t fit in int.
5418 Check for time_t and/or pid_t out of range, e.g., via a network share.
5419 Don't alloca where an auto var works fine.
5421 * fileio.c: Fix some integer overflow issues.
5422 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5423 Don't assume string length fits in int.
5424 (directory_file_name): Don't assume string length fits in long.
5425 (make_temp_name): Don't assume pid fits in int, or that its print
5426 length is less than 20.
5428 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5430 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5432 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5434 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5435 We prefer signed integers, even for size calculations.
5437 * emacs.c: Don't assume string length fits in 'int'.
5438 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5439 (main): Don't invoke strlen when not needed.
5441 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5442 (XD_DEBUG_MESSAGE): Don't waste a byte.
5444 * callproc.c (getenv_internal_1, getenv_internal)
5446 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5448 * lread.c (invalid_syntax): Omit length argument.
5449 All uses changed. This doesn't fix a bug, but it simplifies the
5450 code away from its former Hollerith-constant appearance, and it's
5451 one less 'int' to worry about when looking at integer-overflow issues.
5452 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5454 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5455 This didn't break anything, but it didn't help either.
5456 It's confusing to put a bogus integer in a place where the actual
5457 value does not matter.
5458 (LIST_END_P): Remove unused macro and its bogus comment.
5459 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5461 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5462 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5464 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5465 We prefer signed types, and the value cannot exceed the EMACS_INT
5466 range anyway (because otherwise the length would not be representable).
5467 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5468 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5469 This avoids a GCC warning when WIDE_EMACS_INT.
5471 * indent.c (sane_tab_width): New function.
5472 (current_column, scan_for_column, Findent_to, position_indentation)
5473 (compute_motion): Use it. This is just for clarity.
5474 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5476 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5478 * lisp.h (lint_assume): New macro.
5479 * composite.c (composition_gstring_put_cache):
5480 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5482 * editfns.c, insdel.c:
5483 Omit unnecessary forward decls, to simplify future changes.
5485 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5487 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5489 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5490 Use much-faster test for byte-length change.
5491 Don't assume string byte-length fits in 'int'.
5492 Check that character arg fits in 'int'.
5493 (mapcar1): Declare byte as byte, for clarity.
5495 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5497 * fns.c (concat): Catch string overflow earlier.
5498 Do not rely on integer wraparound.
5500 * dispextern.h (struct it.overlay_strings_charpos)
5501 (struct it.selective): Now EMACS_INT, not int.
5502 * xdisp.c (forward_to_next_line_start)
5503 (back_to_previous_visible_line_start)
5504 (reseat_at_next_visible_line_start, next_element_from_buffer):
5505 Don't arbitrarily truncate the value of 'selective' to int.
5507 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5509 * composite.c: Don't truncate sizes to 'int'.
5510 (composition_gstring_p, composition_reseat_it)
5511 (composition_adjust_point): Use EMACS_INT, not int.
5512 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5513 not EMACS_UINT, for indexes.
5515 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5517 * buffer.c: Include <verify.h>.
5518 (struct sortvec.priority, struct sortstr.priority):
5519 Now EMACS_INT, not int.
5520 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5521 (struct sortstr.size, record_overlay_string)
5522 (struct sortstrlist.size, struct sortlist.used):
5523 Don't truncate size to int.
5524 (record_overlay_string): Check for size-calculation overflow.
5525 (init_buffer_once): Check at compile-time, not run-time.
5527 2011-06-22 Jim Meyering <meyering@redhat.com>
5529 Don't leak an XBM-image-sized buffer
5530 * image.c (xbm_load): Free the image buffer after using it.
5532 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5535 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5536 that Sun C diagnosed.
5537 * fns.c (secure_hash): Fix pointer signedness issue.
5538 * intervals.c (static_offset_intervals): New function.
5539 (offset_intervals): Use it.
5541 2011-06-21 Leo Liu <sdl.web@gmail.com>
5544 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5547 * fns.c (secure_hash): Rename from crypto_hash_function and change
5548 the first arg to accept symbols.
5549 (Fsecure_hash): New primitive.
5550 (syms_of_fns): New symbols.
5552 2011-06-20 Deniz Dogan <deniz@dogan.se>
5554 * process.c (Fset_process_buffer): Clarify return value in
5557 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5559 * dispnew.c (add_window_display_history): Use BVAR.
5561 * xdisp.c (debug_method_add): Use BVAR.
5562 (check_window_end, dump_glyph_matrix, dump_glyph)
5563 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5565 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5568 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5569 check till after the cache is created in init_frame_faces.
5571 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5573 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5575 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5577 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5578 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5579 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5581 Improve buffer-overflow checking (Bug#8873).
5582 * fileio.c (Finsert_file_contents):
5583 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5584 Remove the old (too-loose) buffer overflow checks.
5585 They weren't needed, since make_gap checks for buffer overflow.
5586 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5587 The old code merely checked for Emacs fixnum overflow, and relied
5588 on undefined (wraparound) behavior. The new code avoids undefined
5589 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5591 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5592 Tune. Don't use wider integers than needed. Don't use alloca.
5593 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5595 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5597 * insdel.c, lisp.h (buffer_overflow): New function.
5598 (insert_from_buffer_1, replace_range, replace_range_2):
5599 * insdel.c (make_gap_larger):
5600 * editfns.c (Finsert_char):
5601 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5603 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5605 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5607 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5609 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5610 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5612 * fileio.c: Don't assume EMACS_INT fits in off_t.
5613 (emacs_lseek): New static function.
5614 (Finsert_file_contents, Fwrite_region): Use it.
5615 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5617 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5619 * fns.c: Don't overflow int when computing a list length.
5620 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5621 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5622 truncation on 64-bit hosts. Check for QUIT every
5623 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5624 faster and is responsive enough.
5625 (Flength): Report an error instead of overflowing an integer.
5626 (Fsafe_length): Return a float if the value is not representable
5627 as a fixnum. This shouldn't happen except in contrived situations.
5628 (Fnthcdr, Fsort): Don't assume list length fits in int.
5629 (Fcopy_sequence): Don't assume vector length fits in int.
5631 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5632 (header_size, word_size): New constants.
5633 (allocate_vectorlike): Don't check size overflow here.
5634 (allocate_vector): Check it here instead, since this is the only
5635 caller of allocate_vectorlike that could cause overflow.
5636 Check that the new vector's length is representable as a fixnum.
5638 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5639 The previous code was bogus. For example, next_almost_prime (32)
5640 returned 39, which is undesirable as it is a multiple of 3; and
5641 next_almost_prime (24) returned 25, which is a multiple of 5 so
5642 why was the code bothering to check for multiples of 7?
5644 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5646 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5648 Variadic C functions now count arguments with ptrdiff_t.
5649 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5650 Back then I didn't know that the Emacs coding style prefers signed int.
5651 Also, in the meantime I found a few more instances where arguments
5652 were being counted with int, which may truncate counts on 64-bit
5653 machines, or EMACS_INT, which may be unnecessarily wide.
5654 * lisp.h (struct Lisp_Subr.function.aMANY)
5655 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5656 Arg counts are now ptrdiff_t, not size_t.
5657 All variadic functions and their callers changed accordingly.
5658 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5659 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5660 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5661 * callint.c (Fcall_interactively): Check arg count for overflow,
5662 to avoid potential buffer overrun. Use signed char, not 'int',
5663 for 'varies' array, so that we needn't bother to check its size
5664 calculation for overflow.
5665 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5666 * eval.c (apply_lambda):
5667 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5668 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5669 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5671 * callint.c (Fcall_interactively): Don't use index var as event count.
5673 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5674 * mem-limits.h (SIZE): Remove; no longer used.
5676 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5678 Remove unnecessary casts.
5679 * xterm.c (x_term_init):
5680 * xfns.c (x_set_border_pixel):
5681 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5682 These aren't needed now that we assume ANSI C.
5684 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5685 It's more likely to cause problems (due to unsigned overflow)
5688 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5690 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5692 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5694 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5696 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5698 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5700 GLYPH_CODE_FACE returns EMACS_INT, not int.
5701 * dispextern.h (merge_faces):
5702 * xfaces.c (merge_faces):
5703 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5704 Don't assume EMACS_INT fits in int.
5706 * character.h (CHAR_VALID_P): Remove unused parameter.
5707 * fontset.c, lisp.h, xdisp.c: All uses changed.
5709 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5711 * fns.c (concat): Minor tuning based on overflow analysis.
5712 This doesn't fix any bugs. Use int to hold character, instead
5713 of constantly refetching from Emacs object. Use XFASTINT, not
5714 XINT, for value known to be a character. Don't bother comparing
5715 a single byte to 0400, as it's always less.
5717 * floatfns.c (Fexpt):
5718 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5720 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5723 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5725 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5726 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5727 incorrectly succeed when S was a string, because 4294967386 was
5728 truncated before it was used.
5730 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5731 Otherwise, an out-of-range integer could cause undefined behavior
5734 * composite.c: Use int, not EMACS_INT, for characters.
5735 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5736 EMACS_INT, for values that are known to be in character range.
5737 This doesn't fix any bugs but is the usual style inside Emacs and
5738 may generate better code on 32-bit machines.
5740 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5741 This is for reasons similar to the recent CHAR_STRING fix.
5742 * charset.c (Fencode_char): Check that character arg is actually
5743 a character. Pass an int to ENCODE_CHAR.
5744 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5745 wider than 'int', as a compile-time check to prevent future regressions
5748 * character.c (char_string): Remove unnecessary casts.
5750 Make sure a 64-bit char is never passed to CHAR_STRING.
5751 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5752 by silently ignoring the top 32 bits, allowing some values
5753 that were far too large to be valid characters.
5754 * character.h: Include <verify.h>.
5755 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5756 arguments are no wider than unsigned, as a compile-time check
5757 to prevent future regressions in this area.
5759 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5760 (Fsubst_char_in_region):
5762 * xdisp.c (decode_mode_spec_coding):
5763 Adjust to CHAR_STRING's new requirement.
5764 * editfns.c (Finsert_char, Fsubst_char_in_region):
5765 * fns.c (concat): Check that character args are actually
5766 characters. Without this test, these functions did the wrong
5767 thing with wildly out-of-range values on 64-bit hosts.
5769 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5770 These casts should not be needed on 32-bit hosts, either.
5771 * keyboard.c (read_char):
5772 * lread.c (Fload): Remove casts to unsigned.
5774 * lisp.h (UNSIGNED_CMP): New macro.
5775 This fixes comparison bugs on 64-bit hosts.
5776 (ASCII_CHAR_P): Use it.
5777 * casefiddle.c (casify_object):
5778 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5779 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5780 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5781 * dispextern.h (FACE_FROM_ID):
5782 * keyboard.c (read_char): Use UNSIGNED_CMP.
5784 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5785 not to EMACS_INT, to avoid GCC warning.
5787 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5789 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5790 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5791 isn't needed on 32-bit machines.
5793 * buffer.c (Fgenerate_new_buffer_name):
5794 Use EMACS_INT for count, not int.
5795 (advance_to_char_boundary): Return EMACS_INT, not int.
5797 * data.c (Qcompiled_function): Now static.
5799 * window.c (window_body_lines): Now static.
5801 * image.c (gif_load): Rename local to avoid shadowing.
5803 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5804 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5805 * alloc.c (make_save_value): Integer argument is now of type
5807 (mark_object): Use ptrdiff_t, not int.
5808 * lisp.h (pD): New macro.
5809 * print.c (print_object): Use it.
5811 * alloc.c: Use EMACS_INT, not int, to count objects.
5812 (total_conses, total_markers, total_symbols, total_vector_size)
5813 (total_free_conses, total_free_markers, total_free_symbols)
5814 (total_free_floats, total_floats, total_free_intervals)
5815 (total_intervals, total_strings, total_free_strings):
5816 Now EMACS_INT, not int. All uses changed.
5817 (Fgarbage_collect): Compute overall total using a double, so that
5818 integer overflow is less likely to be a problem. Check for overflow
5819 when converting back to an integer.
5820 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5821 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5822 These were 'int' variables that could overflow on 64-bit hosts;
5823 they were never used, so remove them instead of repairing them.
5824 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5825 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5826 Previously, this ceilinged at INT_MAX, but that doesn't work on
5828 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5830 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5831 (allocate_vectorlike): Check for ptrdiff_t overflow.
5832 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5833 when a (possibly-narrower) signed value would do just as well.
5834 We prefer using signed arithmetic, to avoid comparison confusion.
5836 * alloc.c: Catch some string size overflows that we were missing.
5837 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5838 for convenience in STRING_BYTES_MAX.
5839 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5840 The definition here is exact; the one in lisp.h was approximate.
5841 (allocate_string_data): Check for string overflow. This catches
5842 some instances we weren't catching before. Also, it catches
5843 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5844 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5845 and ptrdiff_t and EMACS_INT are both 64 bits.
5847 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5848 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5849 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5851 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5853 * alloc.c (Fmake_string): Check for out-of-range init.
5855 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5857 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5859 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5861 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5862 xg_get_default_scrollbar_width.
5864 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5865 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5866 (style_changed_cb): Call update_theme_scrollbar_width and call
5867 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5868 all frames (Bug#8505).
5869 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5870 Call gtk_window_set_resizable if HAVE_GTK3.
5871 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5872 and height if HAVE_GTK3 (Bug#8505).
5873 (scroll_bar_width_for_theme): New variable.
5874 (update_theme_scrollbar_width): New function.
5875 (xg_get_default_scrollbar_width): Move code to
5876 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5877 (xg_initialize): Call update_theme_scrollbar_width.
5879 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5881 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5883 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5885 * frame.c (make_frame): Call other_buffer_safely instead of
5888 * window.c (temp_output_buffer_show): Call display_buffer with
5889 second argument Vtemp_buffer_show_specifiers and reset latter
5890 immediately after the call.
5891 (Vtemp_buffer_show_specifiers): New variable.
5892 (auto_window_vscroll_p, next_screen_context_lines)
5893 (Vscroll_preserve_screen_position): Remove leading asterisks from
5896 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5898 Fix minor problems found by GCC 4.6.0 static checking.
5899 * buffer.c (Qclone_number): Remove for now, as it's unused.
5900 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5901 (record_buffer): Remove unused local.
5902 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5903 (set_frame_buffer_list): Remove; unused.
5904 * frame.h (other_visible_frames): Remove decl.
5905 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5906 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5907 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5909 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5910 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5911 Define only if HAVE_GPM.
5912 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5913 (update_hints_inhibit): Remove; never set. All uses removed.
5914 * widgetprv.h (emacsFrameClassRec): Remove decl.
5915 * window.c (delete_deletable_window): Now returns void, since it
5916 wasn't returning anything.
5917 (compare_window_configurations): Remove unused locals.
5918 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5919 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5920 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5921 the same widths as pointers. This follows up on the 2011-05-06 patch.
5922 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5923 * xterm.h: Likewise.
5924 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5926 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5928 * makefile.w32-in: Update dependencies.
5929 (LISP_H): Add lib/intprops.h.
5931 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5933 * image.c (gif_load): Add animation frame delay to the metadata.
5934 (syms_of_image): Use DEFSYM. New symbol `delay'.
5936 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5938 * window.c (delete_deletable_window): Re-add.
5939 (Fset_window_configuration): Rewrite to handle dead buffers and
5940 consequently deletable windows.
5941 (window_tree, Fwindow_tree): Remove. Supply functionality in
5943 (compare_window_configurations): Simplify code.
5945 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5947 * image.c (imagemagick_load_image): Fix type mismatch.
5948 (Fimagemagick_types): Likewise.
5950 * window.h (replace_buffer_in_windows): Declare.
5952 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5954 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5955 Qclone_number. Remove external declaration of Qdelete_window.
5956 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5958 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5959 Run Qbuffer_list_update_hook if allowed.
5960 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5961 buffer list implementation.
5962 (other_buffer_safely): New function.
5963 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5964 calls to replace_buffer_in_windows and
5965 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5967 (record_buffer): Inhibit quitting and rewrite using quittable
5968 functions. Run Qbuffer_list_update_hook if allowed.
5969 (Frecord_buffer, Funrecord_buffer): New functions.
5970 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5971 Move switch-to-buffer to window.el.
5972 (bury-buffer): Move to window.el.
5973 (Vbuffer_list_update_hook): New variable.
5975 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5978 * window.h (resize_frame_windows): Move up in code.
5979 (Fwindow_frame): Remove EXFUN.
5980 (replace_buffer_in_all_windows): Remove prototype.
5981 (replace_buffer_in_windows_safely): Add prototype.
5983 * window.c: Declare Qdelete_window static again. Move down
5984 declaration of select_count.
5985 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5986 (Fother_window): Move to window.el.
5987 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5988 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5989 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5991 (replace_buffer_in_windows): Implement by calling
5992 Qreplace_buffer_in_windows.
5993 (replace_buffer_in_all_windows): Remove with some functionality
5994 moved into replace_buffer_in_windows_safely.
5995 (replace_buffer_in_windows_safely): New function.
5996 (select_window_norecord, select_frame_norecord): Move in front
5997 of run_window_configuration_change_hook. Remove now obsolete
5999 (Fset_window_buffer): Rewrite doc-string.
6000 Call Qrecord_window_buffer.
6001 (keys_of_window): Move binding for other-window to window.el.
6003 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
6005 * dispextern.h (struct image): Replace data member, whose int_val
6006 and ptr_val fields were not used by anything, with a single
6009 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
6010 (gif_clear_image, gif_load, imagemagick_load_image)
6011 (gs_clear_image, gs_load): Callers changed.
6013 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
6015 * buffer.h: Include <time.h>, for time_t.
6016 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
6018 Fix minor problems found by static checking.
6020 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
6022 Make identifiers static if they are not used in other modules.
6023 * data.c (Qcompiled_function, Qframe, Qvector):
6024 * image.c (QimageMagick, Qsvg):
6025 * minibuf.c (Qmetadata):
6026 * window.c (resize_window_check, resize_root_window): Now static.
6027 * window.h (resize_window_check, resize_root_window): Remove decls.
6029 * window.c (window_deletion_count, delete_deletable_window):
6031 (window_body_lines): Now static.
6032 (Fdelete_other_windows_internal): Mark vars as initialized.
6033 Make sure 'resize_failed' is initialized.
6034 (run_window_configuration_change_hook): Rename local to avoid shadowing.
6035 (resize_window_apply): Remove unused local.
6036 * window.h (delete_deletable_window): Remove decl.
6038 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
6039 (imagemagick_load_image): Fix pointer signedness problem by changing
6040 last arg from unsigned char * to char *. All uses changed.
6041 Also, fix a local for similar reasons.
6042 Remove unused locals. Remove locals to avoid shadowing.
6043 (fn_rsvg_handle_free): Remove; unused.
6044 (svg_load, svg_load_image): Fix pointer signedness problem.
6045 (imagemagick_load_image): Don't use garbage pointer image_wand.
6047 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
6049 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
6051 * image.c (gif_load): Fix omitted cast error introduced by
6054 2011-06-10 Martin Rudalics <rudalics@gmx.at>
6056 * window.h (resize_proportionally, orig_total_lines)
6057 (orig_top_line): Remove from window structure.
6058 (set_window_height, set_window_width, change_window_heights)
6059 (Fdelete_window): Remove prototypes.
6060 (resize_frame_windows): Remove duplicate declaration.
6062 2011-06-10 Eli Zaretskii <eliz@gnu.org>
6064 * window.h (resize_frame_windows, resize_window_check)
6065 (delete_deletable_window, resize_root_window)
6066 (resize_frame_windows): Declare prototypes.
6068 * window.c (resize_window_apply): Make definition be "static" to
6069 match the prototype.
6071 2011-06-10 Martin Rudalics <rudalics@gmx.at>
6073 * window.c: Remove declarations of Qwindow_size_fixed,
6074 window_min_size_1, window_min_size_2, window_min_size,
6075 size_window, window_fixed_size_p, enlarge_window, delete_window.
6076 Remove static from declaration of Qdelete_window, it's
6077 temporarily needed by Fbury_buffer.
6078 (replace_window): Don't assign orig_top_line and
6080 (Fdelete_window, delete_window): Remove. Window deletion is
6081 handled by window.el.
6082 (window_loop): Remove DELETE_OTHER_WINDOWS case.
6083 Replace Fdelete_window calls with calls to Qdelete_window.
6084 (Fdelete_other_windows): Remove. Deleting other windows is
6085 handled by window.el.
6086 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
6087 handled in window.el.
6088 (window_min_size_2, window_min_size_1, window_min_size): Remove.
6089 Window minimum sizes are handled in window.el.
6090 (shrink_windows, size_window, set_window_height)
6091 (set_window_width, change_window_heights, window_height)
6092 (window_width, CURBEG, CURSIZE, enlarge_window)
6093 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
6094 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
6095 handled in window.el.
6096 (make_dummy_parent): Rename to make_parent_window and give it a
6097 second argument horflag.
6098 (make_window): Don't set resize_proportionally any more.
6099 (Fsplit_window): Remove. Windows are split in window.el.
6100 (save_restore_action, save_restore_orig_size)
6101 (shrink_window_lowest_first, save_restore_orig_size): Remove.
6102 Resize mini windows in window.el.
6103 (grow_mini_window, shrink_mini_window): Implement by calling
6104 Qresize_root_window_vertically, resize_window_check and
6105 resize_window_apply.
6106 (saved_window, Fset_window_configuration, save_window_save):
6107 Do not handle orig_top_line, orig_total_lines, and
6108 resize_proportionally.
6109 (window_min_height, window_min_width): Move to window.el.
6110 (keys_of_window): Move bindings for delete-other-windows,
6111 split-window, delete-window and enlarge-window to window.el.
6113 * buffer.c: Temporarily extern Qdelete_window.
6114 (Fbury_buffer): Temporarily call Qdelete_window instead of
6115 Fdelete_window (Fbury_buffer will move to window.el soon).
6117 * frame.c (set_menu_bar_lines_1): Remove code handling
6118 orig_top_line and orig_total_lines.
6120 * dispnew.c (adjust_frame_glyphs_initially): Don't use
6121 set_window_height but set heights directly.
6122 (change_frame_size_1): Use resize_frame_windows.
6124 * xdisp.c (init_xdisp): Don't use set_window_height but set
6127 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
6128 Use resize_frame_windows instead of change_window_heights and run
6129 run_window_configuration_change_hook.
6131 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
6132 instead of change_window_heights and run
6133 run_window_configuration_change_hook.
6135 2011-06-09 Martin Rudalics <rudalics@gmx.at>
6137 * window.c (replace_window): Rename second argument REPLACEMENT to
6138 NEW. New third argument SETFLAG. Rewrite.
6139 (delete_window, make_dummy_parent): Call replace_window with
6141 (window_list_1): Move down in code.
6142 (run_window_configuration_change_hook): Move set_buffer part
6143 before select_frame_norecord part in order to unwind correctly.
6144 Rename count1 to count.
6145 (recombine_windows, delete_deletable_window, resize_root_window)
6146 (Fdelete_other_windows_internal)
6147 (Frun_window_configuration_change_hook, make_parent_window)
6148 (resize_window_check, resize_window_apply, Fresize_window_apply)
6149 (resize_frame_windows, Fsplit_window_internal)
6150 (Fdelete_window_internal, Fresize_mini_window_internal):
6152 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
6154 2011-06-08 Martin Rudalics <rudalics@gmx.at>
6156 * window.h (window): Add some new members to window structure -
6157 normal_lines, normal_cols, new_total, new_normal, clone_number,
6158 splits, nest, prev_buffers, next_buffers.
6159 (WINDOW_TOTAL_SIZE): Move here from window.c.
6160 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
6162 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
6164 (make_dummy_parent): Set new members of windows structure.
6165 (make_window): Move down in code. Handle new members of window
6167 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
6168 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
6169 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
6170 (Fset_window_prev_buffers, Fwindow_next_buffers)
6171 (Fset_window_next_buffers, Fset_window_clone_number):
6173 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
6174 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
6176 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
6177 Argument WINDOW can be now internal window too.
6178 (Fwindow_use_time): Move up in code.
6179 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
6181 (Fset_window_configuration, saved_window)
6182 (Fcurrent_window_configuration, save_window_save): Handle new
6183 members of window structure.
6184 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
6185 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
6186 (syms_of_window): New Lisp objects Qrecord_window_buffer,
6187 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
6188 Qget_mru_window, Qresize_root_window,
6189 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
6190 Qauto_buffer_name; staticpro them.
6192 2011-06-07 Martin Rudalics <rudalics@gmx.at>
6194 * window.c (Fwindow_total_size, Fwindow_left_column)
6195 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
6196 (Fwindow_list_1): New functions.
6197 (window_box_text_cols): Replace with window_body_cols.
6198 (Fwindow_width, Fscroll_left, Fscroll_right):
6199 Use window_body_cols instead of window_box_text_cols.
6200 (delete_window, Fset_window_configuration):
6201 Call delete_all_subwindows with window as argument.
6202 (delete_all_subwindows): Take a window as argument and not a
6204 (window_loop): Remove handling of GET_LRU_WINDOW and
6206 (Fget_lru_window, Fget_largest_window): Move to window.el.
6208 * window.h: Extern window_body_cols instead of
6209 window_box_text_cols. delete_all_subwindows now takes a
6210 Lisp_Object as argument.
6212 * indent.c (compute_motion, Fcompute_motion):
6213 Use window_body_cols instead of window_box_text_cols.
6215 * frame.c (delete_frame): Call delete_all_subwindows with root
6218 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
6220 * fns.c (Fputhash): Document return value.
6222 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
6224 * image.c (gif_load): Implement gif89a spec "no disposal" method.
6226 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6228 Cons<->int and similar integer overflow fixes (Bug#8794).
6230 Check for overflow when converting integer to cons and back.
6231 * charset.c (Fdefine_charset_internal, Fdecode_char):
6232 Use cons_to_unsigned to catch overflow.
6233 (Fencode_char): Use INTEGER_TO_CONS.
6234 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6235 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6236 * data.c (long_to_cons, cons_to_long): Remove.
6237 (cons_to_unsigned, cons_to_signed): New functions.
6238 These signal an error for invalid or out-of-range values.
6239 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6240 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6241 * font.c (Ffont_variation_glyphs):
6242 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6243 * lisp.h: Include <intprops.h>.
6244 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6245 (cons_to_signed, cons_to_unsigned): New decls.
6246 (long_to_cons, cons_to_long): Remove decls.
6247 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6248 (Fprimitive_undo): Use CONS_TO_INTEGER.
6249 * xfns.c (Fx_window_property): Likewise.
6250 * xselect.c: Include <limits.h>.
6251 (x_own_selection, selection_data_to_lisp_data):
6252 Use INTEGER_TO_CONS.
6253 (x_handle_selection_request, x_handle_selection_clear)
6254 (x_get_foreign_selection, Fx_disown_selection_internal)
6255 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6256 (lisp_data_to_selection_data): Use cons_to_unsigned.
6257 (x_fill_property_data): Use cons_to_signed.
6258 Report values out of range.
6260 Check for buffer and string overflow more precisely.
6261 * buffer.h (BUF_BYTES_MAX): New macro.
6262 * lisp.h (STRING_BYTES_MAX): New macro.
6263 * alloc.c (Fmake_string):
6264 * character.c (string_escape_byte8):
6265 * coding.c (coding_alloc_by_realloc):
6266 * doprnt.c (doprnt):
6267 * editfns.c (Fformat):
6269 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6270 since they may not be the same number.
6271 * editfns.c (Finsert_char):
6272 * fileio.c (Finsert_file_contents):
6273 Likewise for BUF_BYTES_MAX.
6275 * image.c: Use ptrdiff_t, not int, for sizes.
6276 (slurp_file): Switch from int to ptrdiff_t.
6278 (slurp_file): Check that file size fits in both size_t (for
6279 malloc) and ptrdiff_t (for sanity and safety).
6281 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6282 if b->modtime has its maximal value.
6284 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6286 Don't assume time_t can fit into int.
6287 * buffer.h (struct buffer.modtime): Now time_t, not int.
6288 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6289 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6291 Minor fixes for signed vs unsigned integers.
6292 * character.h (MAYBE_UNIFY_CHAR):
6293 * charset.c (maybe_unify_char):
6294 * keyboard.c (read_char, reorder_modifiers):
6295 XINT -> XFASTINT, since the integer must be nonnegative.
6296 * ftfont.c (ftfont_spec_pattern):
6297 * keymap.c (access_keymap, silly_event_symbol_error):
6298 XUINT -> XFASTINT, since the integer must be nonnegative.
6299 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6300 since it makes no difference and we prefer signed.
6301 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6302 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6305 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6307 * window.h (Fwindow_frame): Declare.
6309 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6311 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6312 (SPARE_MEMORY): Always define.
6313 (LARGE_REQUEST): Remove.
6314 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6316 2011-06-06 Martin Rudalics <rudalics@gmx.at>
6318 * lisp.h: Move EXFUNS for Fframe_root_window,
6319 Fframe_first_window and Fset_frame_selected_window to window.h.
6321 * window.h: Move EXFUNS for Fframe_root_window,
6322 Fframe_first_window and Fset_frame_selected_window here from
6325 * frame.c (Fwindow_frame, Fframe_first_window)
6326 (Fframe_root_window, Fframe_selected_window)
6327 (Fset_frame_selected_window): Move to window.c.
6328 (Factive_minibuffer_window): Move to minibuf.c.
6329 (Fother_visible_frames_p): New function.
6331 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6333 * window.c (decode_window, decode_any_window): Move up in code.
6334 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6335 (inhibit_frame_unsplittable): Remove unused variable.
6336 (Fwindow_buffer): Move up and rewrite doc-string.
6337 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6338 (Fwindow_prev): New functions.
6339 (Fwindow_frame): Move here from frame.c. Accept any window as
6341 (Fframe_root_window, Fframe_first_window)
6342 (Fframe_selected_window): Move here from frame.c. Accept frame
6343 or arbitrary window as argument. Update doc-strings.
6344 (Fminibuffer_window): Move up in code.
6345 (Fwindow_minibuffer_p): Move up in code and simplify.
6346 (Fset_frame_selected_window): Move here from frame.c.
6348 (Fselected_window, select_window, Fselect_window): Move up in
6349 code. Minor doc-string fixes.
6351 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6353 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6354 Do not assume that spare memory exists; that assumption is valid
6355 only if SYSTEM_MALLOC.
6356 (LARGE_REQUEST): New macro, so that the issue of large requests
6357 is separated from the issue of spare memory.
6359 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6361 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6364 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6366 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6369 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6371 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6373 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6375 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6376 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6378 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
6380 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6382 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
6384 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6385 (x_clipboard_manager_save): Add return value.
6386 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6388 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6389 Obey Vx_select_enable_clipboard_manager. Catch errors in
6390 x_clipboard_manager_save (Bug#8779).
6391 (Vx_select_enable_clipboard_manager): New variable.
6392 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
6394 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
6396 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6398 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6400 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6401 in the current matrix if keep_current_p is non-zero.
6403 2011-06-04 Eli Zaretskii <eliz@gnu.org>
6405 * bidi.c (bidi_level_of_next_char): Fix last change.
6407 2011-06-03 Eli Zaretskii <eliz@gnu.org>
6409 Support bidi reordering of text covered by display properties.
6411 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6412 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6413 (bidi_cache_search, bidi_cache_iterator_state)
6414 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6415 (bidi_level_of_next_char, bidi_move_to_visually_next):
6416 Support character positions inside a run of characters covered by a
6418 (bidi_paragraph_init, bidi_resolve_explicit_1)
6419 (bidi_level_of_next_char): Call bidi_fetch_char and
6420 bidi_fetch_char_advance instead of FETCH_CHAR and
6422 (bidi_init_it): Initialize new members.
6423 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6425 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6426 instead of using explicit *_CHAR codes.
6427 (bidi_resolve_explicit, bidi_resolve_weak):
6428 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6429 bidirectional text is supported only in multibyte buffers.
6430 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6431 it to initialize the frame_window_p member of struct bidi_it.
6432 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6433 (bidi_resolve_explicit, bidi_resolve_weak)
6434 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6435 bidi_it->nchars is non-positive.
6436 (bidi_level_of_next_char): Don't try to lookup the cache for the
6437 next/previous character if nothing is cached there yet, or if we
6438 were just reseat()'ed to a new position.
6440 * xdisp.c (set_cursor_from_row): Set start and stop points
6441 according to the row's direction when priming the loop that looks
6442 for the glyph on which to display cursor.
6443 (single_display_spec_intangible_p): Function deleted.
6444 (display_prop_intangible_p): Reimplement to call
6445 handle_display_spec instead of single_display_spec_intangible_p.
6446 Accept 3 additional arguments needed by handle_display_spec.
6447 This fixes incorrect cursor motion across display property with complex
6448 values: lists, `(when COND...)' forms, etc.
6449 (single_display_spec_string_p): Support property values that are
6450 lists with the argument STRING its top-level element.
6451 (display_prop_string_p): Fix the condition for processing a
6452 property that is a list to be consistent with handle_display_spec.
6453 (handle_display_spec): New function, refactored from the
6454 last portion of handle_display_prop.
6455 (compute_display_string_pos): Accept additional argument
6456 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6457 value of a `display' property is a "replacing spec".
6458 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6459 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6460 the display property, but just return a value indicating whether
6461 the display property will replace the characters it covers.
6462 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6463 frame_window_p members of struct bidi_it.
6464 (compute_display_string_pos, compute_display_string_end):
6466 (push_it): Accept second argument POSITION, where pop_it should
6467 jump to continue iteration.
6468 (reseat_1): Initialize bidi_it.disp_pos.
6470 * keyboard.c (adjust_point_for_property): Adjust the call to
6471 display_prop_intangible_p to its new signature.
6473 * dispextern.h (struct bidi_it): New member frame_window_p.
6474 (bidi_init_it): Update prototypes.
6475 (display_prop_intangible_p): Update prototype.
6476 (compute_display_string_pos, compute_display_string_end):
6478 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6481 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6483 Malloc failure behavior now depends on size of allocation.
6484 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6485 * lisp.h: Change signatures accordingly.
6486 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6487 All callers changed. (Bug#8762)
6489 * gnutls.c: Use Emacs's memory allocators.
6490 Without this change, the gnutls library would invoke malloc etc.
6491 directly, which causes problems on non-SYNC_INPUT hosts, and which
6492 runs afoul of improving memory_full behavior. (Bug#8761)
6493 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6494 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6495 xfree instead of the default malloc, realloc, free.
6496 (Fgnutls_boot): No need to check for memory allocation failure,
6497 since xmalloc does that for us.
6499 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6500 * category.c (hash_get_category_set):
6501 * ccl.c (ccl_driver):
6502 * charset.c (Fdefine_charset_internal):
6503 * charset.h (struct charset.hash_index):
6504 * composite.c (get_composition_id, gstring_lookup_cache)
6505 (composition_gstring_put_cache):
6506 * composite.h (struct composition.hash_index):
6507 * dispextern.h (struct image.hash):
6508 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6509 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6510 (hashfn_equal, hashfn_user_defined, make_hash_table)
6511 (maybe_resize_hash_table, hash_lookup, hash_put)
6512 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6513 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6514 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6515 * image.c (make_image, search_image_cache, lookup_image)
6516 (xpm_put_color_table_h):
6517 * lisp.h (struct Lisp_Hash_Table):
6518 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6519 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6520 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6521 * alloc.c (allocate_vectorlike):
6522 Check for overflow in vector size calculations.
6523 * ccl.c (ccl_driver):
6524 Check for overflow when converting EMACS_INT to int.
6525 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6526 need to be updated by these changes.
6527 * fns.c (make_hash_table, maybe_resize_hash_table):
6528 Check for integer overflow with large hash tables.
6529 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6530 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6531 (SXHASH_REDUCE): New macro.
6532 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6533 Use it instead of discarding useful hash info with large hash values.
6534 (sxhash_float): New function.
6535 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6536 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6537 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6538 Rewrite to use FIXNUM_BITS, as this simplifies things.
6539 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6540 Adjust signatures to match updated version of code.
6541 (consing_since_gc): Now EMACS_INT, since a single hash table can
6542 use more than INT_MAX bytes.
6544 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6546 Make it possible to build with GCC-4.6+ -O2 -flto.
6548 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6550 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6552 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6553 Call minibuffer-inactive-mode.
6555 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6557 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6558 Update dependencies.
6560 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6562 * data.c (init_data): Remove code for UTS, this system is not
6565 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6567 Don't force ./temacs to start in terminal mode.
6569 * frame.c (make_initial_frame): Initialize faces in all cases, not
6570 only when CANNOT_DUMP is defined.
6571 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6573 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6575 * dispnew.c (add_window_display_history): Use const for the string
6576 pointer. Remove declaration, not needed.
6578 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6580 Use 'inline', not 'INLINE'.
6581 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6582 * alloc.c, fontset.c (INLINE): Remove.
6583 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6584 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6585 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6586 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6587 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6589 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6591 Make it possible to run ./temacs.
6593 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6594 syms_of_callproc does the same thing. Remove test for
6595 "initialized", do it in the caller.
6596 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6598 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6600 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6601 (read_minibuf): Use get_minibuffer.
6602 (syms_of_minibuf): Use DEFSYM.
6603 (Qmetadata): New var.
6604 * data.c (Qbuffer): Don't make it static.
6605 (syms_of_data): Use DEFSYM.
6607 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6609 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6610 (CCL_CODE_MIN): New macro.
6612 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6614 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6616 * eval.c (Qdebug): Now static.
6617 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6618 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6619 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6621 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6623 * image.c: Various fixes to ImageMagick code comments.
6624 (Fimagemagick_types): Doc fix.
6626 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6628 Minor fixes prompted by GCC 4.6.0 warnings.
6630 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6632 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6633 (x_clipboard_manager_save_all): Move extern decl to ...
6634 * xterm.h: ... here, so that it can be checked for consistency.
6636 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6638 * xselect.c (x_clipboard_manager_save_frame)
6639 (x_clipboard_manager_save_all): New functions.
6640 (Fx_clipboard_manager_save): Lisp function deleted.
6642 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6643 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6645 * xterm.h: Update prototype.
6647 2011-05-28 William Xu <william.xwl@gmail.com>
6649 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6652 2011-05-28 Jim Meyering <meyering@redhat.com>
6654 Avoid a sign-extension bug in crypto_hash_function.
6655 * fns.c (to_uchar): Define.
6656 (crypto_hash_function): Use it to convert some newly-signed
6657 variables to unsigned, to avoid sign-extension bugs. For example,
6658 without this change, (md5 "truc") would evaluate to
6659 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6660 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6661 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6663 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6665 Integer overflow fixes.
6667 * dbusbind.c: Serial number integer overflow fixes.
6668 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6669 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6670 to hold a serial number that is too large for a fixnum.
6671 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6672 Check for serial numbers out of range. Decode any serial number
6673 that was so large that it became a float. (Bug#8722)
6675 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6676 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6677 Use XFASTINT rather than XUINT when numbers are nonnegative.
6678 (xd_append_arg, Fdbus_method_return_internal):
6679 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6680 arguments, check that Lisp number is nonnegative, rather than
6681 silently wrapping negative numbers around. (Bug#8722)
6682 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6685 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6687 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6689 ccl: Add integer overflow checks.
6690 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6691 (IN_INT_RANGE): New macros.
6692 (ccl_driver): Use them to check for integer overflow when
6693 decoding a CCL program. Many of the new checks are whether XINT (x)
6694 fits in int; it doesn't always, on 64-bit hosts. The new version
6695 doesn't catch all possible integer overflows, but it's an
6696 improvement. (Bug#8719)
6698 * alloc.c (make_event_array): Use XINT, not XUINT.
6699 There's no need for unsigned here.
6701 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6702 This follows up to the 2011-05-06 change that substituted uintptr_t
6703 for EMACS_INT. This case wasn't caught back then.
6705 Rework Fformat to avoid integer overflow issues.
6706 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6707 now (part of C89). Include <verify.h>.
6708 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6709 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6710 (Fformat): Avoid the prepass trying to compute sizes; it was only
6711 approximate and thus did not catch overflow reliably. Instead, walk
6712 through the format just once, formatting and computing sizes as we go,
6713 checking for integer overflow at every step, and allocating a larger
6714 buffer as needed. Keep track separately whether the format is
6715 multibyte. Keep only the most-recently calculated precision, rather
6716 than them all. Record whether each argument has been converted to
6717 string. Use EMACS_INT, not int, for byte and char and arg counts.
6718 Support field widths and precisions larger than INT_MAX. Avoid
6719 sprintf's undefined behavior with conversion specifications such as %#d
6720 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6721 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6722 formatting out-of-range floating point numbers with int
6725 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6727 * data.c: Avoid integer truncation in expressions involving floats.
6728 * data.c: Include <intprops.h>.
6729 (arith_driver): When there's an integer overflow in an expression
6730 involving floating point, convert the integers to floating point
6731 so that the resulting value does not suffer from catastrophic
6732 integer truncation. For example, on a 64-bit host (* 4
6733 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6734 Do not rely on undefined behavior after integer overflow.
6736 merge count_size_as_multibyte, parse_str_to_multibyte
6737 * character.c, character.h (count_size_as_multibyte):
6738 Rename from parse_str_to_multibyte; all uses changed.
6739 Check for integer overflow.
6740 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6741 since it's now a duplicate of the other. This is more of
6742 a character than a buffer op, so better that it's in character.c.
6743 * fns.c, print.c: Adjust to above changes.
6745 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6747 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6749 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6751 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6752 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6753 (x_clipboard_manager_save): Now static.
6754 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6756 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6757 (crypto_hash_function): Now static.
6758 Fix pointer signedness problems. Avoid unnecessary initializations.
6760 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6762 * termhooks.h (Vselection_alist): Make it terminal-local.
6764 * terminal.c (create_terminal): Initialize it.
6766 * xselect.c: Support for clipboard managers.
6767 (Vselection_alist): Move to termhooks.h as terminal-local var.
6768 (LOCAL_SELECTION): New macro.
6769 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6770 (symbol_to_x_atom): Remove gratuitous arg.
6771 (x_handle_selection_request, lisp_data_to_selection_data)
6772 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6773 (x_own_selection, x_get_local_selection, x_convert_selection):
6774 New arg, specifying work frame. Use terminal-local Vselection_alist.
6775 (some_frame_on_display): Delete unused function.
6776 (Fx_own_selection_internal, Fx_get_selection_internal)
6777 (Fx_disown_selection_internal, Fx_selection_owner_p)
6778 (Fx_selection_exists_p): New optional frame arg.
6779 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6780 (x_handle_selection_clear): Don't treat other terminals with the
6781 same keyboard specially. Use the terminal-local Vselection_alist.
6782 (x_clear_frame_selections): Use Frun_hook_with_args.
6784 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6786 * xterm.h: Add support for those atoms.
6788 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6790 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6791 (converted_selections, conversion_fail_tag): New global variables.
6792 (x_selection_request_lisp_error): Free the above.
6793 (x_get_local_selection): Remove unnecessary code.
6794 (x_reply_selection_request): Args changed; handle arbitrary array
6795 of converted selections stored in converted_selections.
6796 Separate the XChangeProperty and SelectionNotify steps.
6797 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6798 (x_convert_selection): New function.
6799 (x_handle_selection_event): Simplify.
6800 (x_get_foreign_selection): Don't ignore incoming requests while
6801 waiting for an answer; this will fail when we implement
6802 SAVE_TARGETS, and seems unnecessary anyway.
6803 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6804 (Vx_sent_selection_functions): Doc fix.
6806 2011-05-26 Leo Liu <sdl.web@gmail.com>
6808 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6810 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6812 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6814 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6815 for fringe update if it has periodic bitmap.
6816 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6817 and fringe_bitmap_periodic_p.
6819 * fringe.c (get_fringe_bitmap_data): New function.
6820 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6821 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6822 row. Mark glyph row for fringe update if periodicity changed.
6824 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6825 for fringe update unless it has periodic bitmap.
6827 2011-05-25 Kenichi Handa <handa@m17n.org>
6829 * xdisp.c (get_next_display_element): Set correct it->face_id for
6830 a static composition.
6832 2011-05-24 Leo Liu <sdl.web@gmail.com>
6835 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6837 * fns.c (crypto_hash_function, Fsha1): New function.
6838 (Fmd5): Use crypto_hash_function.
6839 (syms_of_fns): Add Ssha1.
6841 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6843 * gnutls.c: Remove unused macros.
6844 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6845 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6846 Remove macros that are defined and never used.
6847 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6849 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6851 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6852 (Fx_get_selection_internal): Minor cleanup.
6853 (Fx_own_selection_internal): Rename arguments for consistency with
6856 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6858 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6860 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6862 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6864 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6866 * dispnew.c (scrolling_window): Don't exclude the case that the
6867 last enabled row in the desired matrix touches the bottom boundary.
6869 2011-05-21 Glenn Morris <rgm@gnu.org>
6871 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6872 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6873 and add some more files.
6875 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6877 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6878 report_file_error introduced by the change from 2011-05-07.
6880 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6882 * systime.h (Time): Define only if emacs is defined.
6883 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6884 where the include path doesn't have X11/X.h by default. See
6885 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6887 2011-05-20 Kenichi Handa <handa@m17n.org>
6889 * composite.c (find_automatic_composition): Fix previous change.
6891 2011-05-20 Glenn Morris <rgm@gnu.org>
6893 * lisp.mk: New file, split from Makefile.in.
6894 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6895 (shortlisp): Remove.
6896 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6898 2011-05-19 Glenn Morris <rgm@gnu.org>
6900 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6901 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6902 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6903 (lisp): Set the order to that of loadup.el.
6904 (shortlisp): Make it a copy of $lisp.
6905 (SOME_MACHINE_LISP): Remove.
6906 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6907 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6909 2011-05-18 Kenichi Handa <handa@m17n.org>
6911 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6912 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6913 (find_automatic_composition): Mostly rewrite for efficiency.
6915 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6917 * makefile.w32-in: Update dependencies.
6919 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6921 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6922 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6924 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6926 Fix some integer overflow issues, such as string length overflow.
6928 * insdel.c (count_size_as_multibyte): Check for string overflow.
6930 * character.c (lisp_string_width): Check for string overflow.
6931 Use EMACS_INT, not int, for string indexes and lengths; in
6932 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6933 the resulting string length overflows an EMACS_INT; instead,
6934 report a string overflow if no precision given. When checking for
6935 precision exhaustion, use a check that cannot possibly have
6936 integer overflow. (Bug#8675)
6937 * character.h (lisp_string_width): Adjust to new signature.
6939 * alloc.c (string_overflow): New function.
6940 (Fmake_string): Use it. This doesn't change behavior, but saves
6941 a few bytes and will simplify future changes.
6942 * character.c (string_escape_byte8): Likewise.
6943 * lisp.h (string_overflow): New decl.
6945 Fixups, following up to the user-interface timestamp change.
6946 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6947 for UI timestamps, instead of unsigned long.
6948 * msdos.c (mouse_get_pos): Likewise.
6949 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6950 * w32gui.h (Time): Define by including "systime.h" rather than by
6951 declaring it ourselves. (Bug#8664)
6953 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6954 * image.c (clear_image_cache): Likewise.
6956 * term.c (term_mouse_position): Don't assume time_t wraparound.
6958 Be more systematic about user-interface timestamps.
6959 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6960 and sometimes 'EMACS_UINT', to represent these timestamps.
6961 This change causes it to use 'Time' uniformly, as that's what X uses.
6962 This makes the code easier to follow, and makes it easier to catch
6963 integer overflow bugs such as Bug#8664.
6964 * frame.c (Fmouse_position, Fmouse_pixel_position):
6965 Use Time, not unsigned long, for user-interface timestamps.
6966 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6967 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6968 * keyboard.h (last_event_timestamp): Likewise.
6969 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6970 * menu.h (xmenu_show): Likewise.
6971 * term.c (term_mouse_position): Likewise.
6972 * termhooks.h (struct input_event.timestamp): Likewise.
6973 (struct terminal.mouse_position_hook): Likewise.
6974 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6975 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6976 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6977 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6979 * menu.h, termhooks.h: Include "systime.h", for Time.
6981 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6982 Don't assume that the difference between two unsigned long values
6983 can fit into an integer. At this point, we know button_down_time
6984 <= event->timestamp, so the difference must be nonnegative, so
6985 there's no need to cast the result if double-click-time is
6986 nonnegative, as it should be; check that it's nonnegative, just in
6987 case. This bug is triggered when events are more than 2**31 ms
6988 apart (about 25 days). (Bug#8664)
6990 * xselect.c (last_event_timestamp): Remove duplicate decl.
6991 (x_own_selection): Remove needless cast to unsigned long.
6993 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6994 that always fit in int. Use a sentinel instead of a counter, to
6995 avoid a temp and to allay GCC's concerns about possible int overflow.
6996 * frame.h (struct frame): Use int for menu_bar_items_used
6997 instead of EMACS_INT, since it always fits in int.
6999 * menu.c (grow_menu_items): Check for int overflow.
7001 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
7003 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
7004 Before, the code was not consistent. These values cannot exceed
7005 2**31 - 1 so there's no need to make them unsigned.
7006 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
7007 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
7008 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
7010 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
7012 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
7013 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
7014 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
7015 presumably because the widths might not match.
7017 * window.c (size_window): Avoid needless test at loop start.
7019 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
7021 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
7023 2011-05-12 Drew Adams <drew.adams@oracle.com>
7025 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
7027 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7029 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
7030 `width' to `bar_area_x' and `bar_area_width', respectively.
7031 (x_scroll_run): Take account of fringe background extension.
7033 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
7034 Rename local vars `left' and `width' to `bar_area_x' and
7035 `bar_area_width', respectively.
7036 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
7037 background extension.
7039 2011-05-10 Jim Meyering <meyering@redhat.com>
7041 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
7043 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
7045 * image.c (Finit_image_library): Return t for built-in image types,
7046 like pbm and xbm. (Bug#8640)
7048 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
7050 * w32menu.c (set_frame_menubar): Fix submenu allocation.
7052 2011-05-07 Eli Zaretskii <eliz@gnu.org>
7054 * w32console.c (Fset_screen_color): Doc fix.
7055 (Fget_screen_color): New function.
7056 (syms_of_ntterm): Defsubr it.
7058 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
7059 unlink the temporary file if Fcall_process didn't create it in the
7061 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
7062 child process will be redirected to a file specified with `:file'.
7063 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
7064 cue to call_process_cleanup not to close that handle.
7066 2011-05-07 Ben Key <bkey76@gmail.com>
7068 * makefile.w32-in: The bootstrap-temacs rule now makes use of
7069 one of two shell specific rules, either bootstrap-temacs-CMD or
7070 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
7071 to the previous implementation of the bootstrap-temacs rule.
7072 The bootstrap-temacs-CMD rule is similar to the previous
7073 implementation of the bootstrap-temacs rule except that it
7074 makes use of the ESC_CFLAGS variable instead of the CFLAGS
7077 These changes, along with some changes to nt/configure.bat,
7078 nt/gmake.defs, and nt/nmake.defs, are required to extend my
7079 earlier fix to add support for --cflags and --ldflags options
7080 that include quotes so that it works whether make uses cmd or
7083 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
7085 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
7086 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
7088 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
7089 a string. Handle both cases.
7090 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
7091 (Fdbus_register_method): Use Qinvalid_function.
7093 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
7095 * makefile.w32-in: Update dependencies.
7096 (LISP_H): Add inttypes.h and stdin.h.
7097 (PROCESS_H): Add unistd.h.
7099 2011-05-06 Eli Zaretskii <eliz@gnu.org>
7101 * lread.c: Include limits.h (fixes the MS-Windows build broken by
7102 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
7104 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
7106 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
7108 * term.c (vfatal): Remove stray call to va_end.
7109 It's not needed and the C Standard doesn't allow it here anyway.
7111 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
7112 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
7114 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
7117 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
7119 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7121 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
7123 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
7125 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
7127 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
7128 * charset.c (Fdefine_charset_internal): Don't initialize
7129 charset.code_space[15]. The value was garbage, on hosts with
7130 32-bit int (Bug#8600).
7132 * lread.c (read_integer): Be more consistent with string-to-number.
7133 Use string_to_number to do the actual conversion; this avoids
7134 rounding errors and fixes some other screwups. Without this fix,
7135 for example, #x1fffffffffffffff was misread as -2305843009213693952.
7136 (digit_to_number): Move earlier, for benefit of read_integer.
7137 Return -1 if the digit is out of range for the base, -2 if it is
7138 not a digit in any supported base. (Bug#8602)
7140 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
7142 * dispnew.c (scrolling_window): Return 1 if we scrolled,
7143 to match comment at start of function. This also removes a
7144 GCC warning about overflow in a 32+64-bit port.
7146 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
7148 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
7149 Reported by Stefan Monnier in
7150 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
7151 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7152 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
7154 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
7155 (EMACS_UINTPTR): Likewise, with uintptr_t.
7157 * lisp.h: Prefer 64-bit EMACS_INT if available.
7158 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
7159 on 32-bit hosts that have 64-bit int, so that they can access
7161 However, temporarily disable this change unless the temporary
7162 symbol WIDE_EMACS_INT is defined.
7164 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
7166 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
7167 This removes an assumption that EMACS_INT and long are the same
7168 width as pointers. The assumption is true for Emacs porting targets
7169 now, but we want to make other targets possible.
7170 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
7171 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
7172 In the rest of the code, change types of integers that hold casted
7173 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
7174 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
7175 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
7176 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
7177 No need to cast type when ORing.
7178 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
7179 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
7180 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
7181 assume EMACS_INT is the same width as char *.
7182 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
7183 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
7184 Remove no-longer-needed casts.
7185 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
7186 (xg_tool_bar_help_callback, xg_make_tool_item):
7187 Use EMACS_INTPTR to hold an integer
7188 that will be cast to void *; this can avoid a GCC warning
7189 if EMACS_INT is not the same width as void *.
7190 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
7191 * xdisp.c (display_echo_area_1, resize_mini_window_1):
7192 (current_message_1, set_message_1):
7193 Use a local to convert to proper width without a cast.
7194 * xmenu.c (dialog_selection_callback): Likewise.
7196 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
7197 Also, don't assume VALBITS / RAND_BITS is less than 5,
7198 and don't rely on undefined behavior when shifting a 1 left into
7200 * lisp.h (get_random): Change signature to match.
7202 * lread.c (hash_string): Use size_t, not int, for hash computation.
7203 Normally we prefer signed values; but hashing is special, because
7204 it's better to use unsigned division on hash table sizes so that
7205 the remainder is nonnegative. Also, size_t is the natural width
7206 for hashing into memory. The previous code used 'int', which doesn't
7207 retain enough info to hash well into very large tables.
7208 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
7210 * dbusbind.c: Don't possibly lose pointer info when converting.
7211 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7212 Use XPNTR rather than XHASH, so that the high-order bits of
7213 the pointer aren't lost when converting through void *.
7215 * eval.c (Fautoload): Don't double-shift a pointer.
7217 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
7219 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
7221 * gnutls.c (DEF_GNUTLS_FN):
7222 * image.c (DEF_IMGLIB_FN): Make function pointers static.
7224 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7226 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
7229 2011-05-05 Eli Zaretskii <eliz@gnu.org>
7231 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
7232 New version that can reserve upto 2GB of heap space.
7234 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
7236 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7238 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7240 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7241 `gnutls_certificate_set_x509_key_file'.
7243 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
7245 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7246 Update dependencies.
7248 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7250 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7251 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7252 Remove unused parameter `fildes'.
7253 * process.c (read_process_output, send_process): Don't pass it.
7255 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7257 Fix previous change: the library cache is defined in w32.c.
7258 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7259 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7261 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7263 Implement dynamic loading of GnuTLS on Windows.
7265 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7266 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7267 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7270 * gnutls.c (Qgnutls_dll): Define.
7271 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7272 (gnutls_*): Declare function pointers.
7273 (init_gnutls_functions): New function to initialize function pointers.
7274 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7275 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7276 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7277 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7278 (emacs_gnutls_write, emacs_gnutls_read)
7279 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7280 (Fgnutls_available_p): New function.
7281 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7282 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7283 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7285 * image.c: Include w32.h.
7286 (Vimage_type_cache): Delete.
7287 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7288 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7289 (w32_delayed_load): Move to w32.c.
7291 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7293 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7294 (w32_delayed_load): Move from image.c. When loading a library, record
7295 its filename in the :loaded-from property of the library id.
7296 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7297 Initialize and staticpro them.
7298 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7300 * process.c: Include lisp.h before w32.h, not after.
7301 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7302 instead of gnutls_record_check_pending.
7304 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7306 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7308 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7309 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7312 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7314 * xterm.c (x_set_frame_alpha): Do not set property on anything
7315 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7317 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7319 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7321 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7323 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7324 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7325 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7326 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7327 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7328 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7329 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7330 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7331 (Qgnutls_bootprop_callbacks_verify): Make static.
7333 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7335 * callproc.c: Indentation fixup.
7337 * sysdep.c (wait_for_termination_1): Make static.
7338 (wait_for_termination, interruptible_wait_for_termination):
7339 Move after wait_for_termination_1.
7341 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7343 * sysdep.c (interruptible_wait_for_termination): New function
7344 which is like wait_for_termination, but allows keyboard
7347 * callproc.c (Fcall_process): Add (:file "file") as an option for
7349 (Fcall_process_region): Ditto.
7351 2011-04-30 Eli Zaretskii <eliz@gnu.org>
7353 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7354 rather than `XVECTOR (FOO)->size'.
7356 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7357 inttypes.h, as a gnulib replacement is used if it not available in
7360 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7362 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7363 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7364 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7366 * coding.c (coding_alloc_by_realloc): Error out if destination
7367 will grow beyond MOST_POSITIVE_FIXNUM.
7368 (decode_coding_emacs_mule): Abort if there isn't enough place in
7369 charbuf for the composition carryover bytes. Reserve an extra
7370 space for up to 2 characters produced in a loop.
7371 (decode_coding_iso_2022): Abort if there isn't enough place in
7372 charbuf for the composition carryover bytes.
7374 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7376 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7377 aborting when %lld or %lll format is passed.
7378 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7379 %llo or %llx format is passed. (Bug#8545)
7381 * window.c (window_scroll_line_based): Use a marker instead of
7382 simple variables to record original value of point. (Bug#7952)
7384 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7385 produced by %s or %c overflows available buffer space. (Bug#8545)
7387 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7389 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
7390 (SIZE_MAX): Move defn after all includes, as they might #define it.
7392 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7394 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7396 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7398 * keyboard.c (Qdelayed_warnings_hook): Define.
7399 (command_loop_1): Run `delayed-warnings-hook'
7400 if Vdelayed_warnings_list is non-nil.
7401 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7402 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7404 2011-04-28 Eli Zaretskii <eliz@gnu.org>
7406 * doprnt.c (doprnt): Don't return value smaller than the buffer
7407 size if the message was truncated. (Bug#8545).
7409 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7411 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7412 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7414 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7416 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7418 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7420 * makefile.w32-in: Update dependencies.
7422 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7424 Improve `doprnt' and its usage. (Bug#8545)
7425 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7426 `format_end'. Remove support for %l as a conversion specifier.
7427 Don't use xrealloc. Improve diagnostics when the %l size modifier
7428 is used. Update the commentary.
7430 * eval.c (verror): Simplify calculation of size_t.
7432 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7435 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7437 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7440 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7442 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7443 This makes this file independent of the recent pseudovector change.
7445 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7447 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7449 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7450 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7451 Remove unused local.
7452 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7454 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7455 GCC 4.6.0 optimizes based on type-based alias analysis.
7456 For example, if b is of type struct buffer * and v of type struct
7457 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7458 != &v->size, and therefore "v->size = 1; b->size = 2; return
7459 v->size;" must therefore return 1. This assumption is incorrect
7460 for Emacs, since it type-puns struct Lisp_Vector * with many other
7461 types. To fix this problem, this patch adds a new type struct
7462 vectorlike_header that documents the constraints on layout of vectors
7463 and pseudovectors, and helps optimizing compilers not get fooled
7464 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7465 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7466 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7468 (XSETPVECTYPE): Rewrite in terms of new macro.
7469 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7470 This is a bit clearer, and further avoids the possibility of
7471 undesirable aliasing.
7472 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7473 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7474 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7475 since Lisp_Subr is a special case (no "next" field).
7476 (ASIZE): Now uses header.size rather than size.
7477 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7478 to avoid the hassle of writing XVECTOR (foo)->header.size.
7479 (struct vectorlike_header): New type.
7480 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7481 object, to help avoid aliasing.
7482 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7483 (SUBRP): Likewise, since Lisp_Subr is a special case.
7484 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7485 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7486 (struct Lisp_Hash_Table): Combine first two members into a single
7487 struct vectorlike_header member. All uses of "size" and "next" members
7488 changed to be "header.size" and "header.next".
7489 * buffer.h (struct buffer): Likewise.
7490 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7491 * frame.h (struct frame): Likewise.
7492 * process.h (struct Lisp_Process): Likewise.
7493 * termhooks.h (struct terminal): Likewise.
7494 * window.c (struct save_window_data, struct saved_window): Likewise.
7495 * window.h (struct window): Likewise.
7496 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7497 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7498 * buffer.c (init_buffer_once): Likewise.
7499 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7501 * process.c (Fformat_network_address): Use local var for size,
7504 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7506 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7507 * data.c (atof): Remove decl; no longer used or needed.
7508 (digit_to_number): Move to lread.c.
7509 (Fstring_to_number): Use new string_to_number function, to be
7510 consistent with how the Lisp reader treats infinities and NaNs.
7511 Do not assume that floating-point numbers represent EMACS_INT
7512 without losing information; this is not true on most 64-bit hosts.
7513 Avoid double-rounding errors, by insisting on integers when
7514 parsing non-base-10 numbers, as the documentation specifies.
7515 * lisp.h (string_to_number): New decl, replacing ...
7516 (isfloat_string): Remove.
7517 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7518 (read1): Do not accept +. and -. as integers; this
7519 appears to have been a coding error. Similarly, do not accept
7520 strings like +-1e0 as floating point numbers. Do not report
7521 overflow for integer overflows unless the base is not 10 which
7522 means we have no simple and reliable way to continue.
7523 Break out the floating-point parsing into a new
7524 function string_to_number, so that Fstring_to_number parses
7525 floating point numbers consistently with the Lisp reader.
7526 (digit_to_number): Move here from data.c. Make it static inline.
7527 (E_CHAR, EXP_INT): Remove, replacing with ...
7528 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7529 (string_to_number): New function, replacing isfloat_string.
7530 This function checks for valid syntax and produces the resulting
7531 Lisp float number too. Rework it so that string-to-number
7532 no longer mishandles examples like "1.0e+". Use strtoumax,
7533 so that overflow for non-base-10 numbers is reported only when
7534 there's no portable and simple way to convert to floating point.
7536 * textprop.c (set_text_properties_1): Rewrite for clarity,
7537 and to avoid GCC warning about integer overflow.
7539 * intervals.h (struct interval): Use EMACS_INT for members
7540 where EMACS_UINT might cause problems. See
7541 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7542 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7543 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7545 (offset_intervals): Tell GCC not to worry about length overflow
7546 when negating a negative length.
7548 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7549 (overrun_check_free): Likewise.
7551 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7552 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7555 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7556 (gnutls_make_error): Rename local to avoid shadowing.
7557 (gnutls_emacs_global_deinit): ifdef out; not used.
7558 (Fgnutls_boot): Use const for pointer to readonly storage.
7559 Comment out unused local. Fix pointer signedness problems.
7561 * lread.c (openp): Don't stuff size_t into an 'int'.
7562 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7563 about possible signed overflow.
7565 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7566 (GDK_KEY_g): Don't define if already defined.
7567 (xg_prepare_tooltip): Avoid pointer signedness problem.
7568 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7570 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7571 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7573 * xfns.c (Fx_window_property): Simplify a bit,
7574 to make a bit faster and to avoid GCC 4.6.0 warning.
7575 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7577 * fns.c (internal_equal): Don't assume size_t fits in int.
7579 * alloc.c (compact_small_strings): Tighten assertion a little.
7581 Replace pEd with more-general pI, and fix some printf arg casts.
7582 * lisp.h (pI): New macro, generalizing old pEd macro to other
7583 conversion specifiers. For example, use "...%"pI"d..." rather
7584 than "...%"pEd"...".
7585 (pEd): Remove. All uses replaced with similar uses of pI.
7586 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7587 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7588 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7589 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7590 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7591 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7592 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7594 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7595 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7596 * print.c (safe_debug_print, print_object): Likewise.
7597 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7599 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7600 avoiding the 0 flag, which is not portable.
7601 * process.c (Fmake_network_process): Use pI to avoid cast.
7602 * region-cache.c (pp_cache): Likewise.
7603 * xdisp.c (decode_mode_spec): Likewise.
7604 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7605 behavior on 64-bit hosts with printf arg.
7606 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7607 (x_stop_queuing_selection_requests): Likewise.
7608 (x_get_window_property): Don't truncate byte count to an 'int'
7611 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7612 here, since it parses constructs like leading '-' and spaces,
7613 which are not wanted; and it overflows with large numbers.
7614 Instead, simply match F[0-9]+, which is what is wanted anyway.
7616 * alloc.c: Remove unportable assumptions about struct layout.
7617 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7618 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7619 (allocate_vectorlike, make_pure_vector): Use the new macros,
7620 plus offsetof, to remove unportable assumptions about struct layout.
7621 These assumptions hold on all porting targets that I know of, but
7622 they are not guaranteed, they're easy to remove, and removing them
7623 makes further changes easier.
7625 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7626 This doesn't fix a bug but makes the code clearer.
7627 (string_overrun_cookie): Now const. Use initializers that
7628 don't formally overflow signed char, to avoid warnings.
7629 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7630 can cause Emacs to crash when string overrun checking is enabled.
7631 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7632 multiple of sizeof (EMACS_INT); it need not be, if
7633 alignof(EMACS_INT) < sizeof (EMACS_INT).
7634 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7636 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7638 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7640 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7642 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7643 supposed to be handshaking. (Bug#8556)
7644 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7646 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7648 * lisp.h (Qdebug): List symbol.
7649 * eval.c (Qdebug): Restore global linkage.
7650 * keyboard.c (debug-on-event): New variable.
7651 (handle_user_signal): Break into debugger when debug-on-event
7652 matches the current signal symbol.
7654 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7656 * alloc.c (check_sblock, check_string_bytes)
7657 (check_string_free_list): Convert to standard C.
7659 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7661 * w32.c (emacs_gnutls_push): Fix typo.
7663 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7665 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7666 "cast to pointer from integer of different size".
7668 Improve doprnt and its use in verror. (Bug#8545)
7669 * doprnt.c (doprnt): Document the set of format control sequences
7670 supported by the function. Use SAFE_ALLOCA instead of always
7673 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7674 is one byte too soon. Don't use xrealloc; instead xfree and
7677 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7679 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7682 * gnutls.c: Renamed global_initialized to
7683 gnutls_global_initialized. Added internals for the
7684 :verify-hostname-error, :verify-error, and :verify-flags
7685 parameters of `gnutls-boot' and documented those parameters in the
7686 docstring. Start callback support.
7687 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7688 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7689 on error. Return error code.
7690 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7691 (emacs_gnutls_read): Likewise.
7692 (Fgnutls_boot): Return handshake error code.
7693 (emacs_gnutls_handle_error): New function.
7694 (wsaerror_to_errno): Likewise.
7696 * w32.h (emacs_gnutls_pull): Add prototype.
7697 (emacs_gnutls_push): Likewise.
7699 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7700 (emacs_gnutls_push): Likewise.
7702 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7704 * process.c (wait_reading_process_output): Check if GnuTLS
7705 buffered some data internally if no FDs are set for TLS
7708 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7709 (LIBS): Link to USER_LIBS.
7710 ($(BLD)/gnutls.$(0)): New target.
7712 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7714 * xdisp.c (handle_single_display_spec): Rename the
7715 display_replaced_before_p argument into display_replaced_p, to
7716 make it consistent with the commentary. Fix typos in the
7719 * textprop.c (syms_of_textprop): Remove dead code.
7720 (copy_text_properties): Delete obsolete commentary about an
7721 interface that was deleted long ago. Fix typos in the description
7724 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7725 to changes in oldXMenu/XMenu.h from 2011-04-16.
7726 <menu_help_message, prev_menu_help_message>: Constify.
7727 (IT_menu_make_room): menu->help_text is now `const char **';
7730 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7731 to changes in oldXMenu/XMenu.h from 2011-04-16.
7732 (struct XMenu): Declare `help_text' `const char **'.
7734 * xfaces.c <Qunspecified>: Make extern again.
7736 * syntax.c: Include sys/types.h before including regex.h, as
7739 * doc.c (get_doc_string): Improve the format passed to `error'.
7741 * doprnt.c (doprnt): Improve commentary.
7743 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7745 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7748 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7749 changes in globals.h immediately force recompilation.
7750 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7751 $(CURDIR)/s/ms-w32.h.
7752 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7754 * character.c (Fchar_direction): Function deleted.
7755 (syms_of_character): Don't defsubr it.
7756 <char-direction-table>: Deleted.
7758 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7760 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7761 * doprnt.c: Include limits.h.
7762 (SIZE_MAX): New macro.
7763 (doprnt): Return a size_t value. 2nd arg is now size_t.
7764 Many local variables are now size_t instead of int or unsigned.
7765 Improve overflow protection. Support `l' modifier for integer
7766 conversions. Support %l conversion. Don't assume an EMACS_INT
7767 argument for integer conversions and for %c.
7769 * lisp.h (doprnt): Restore prototype.
7771 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7774 * Makefile.in (base_obj): Add back doprnt.o.
7776 * deps.mk (doprnt.o): Add back prerequisites.
7777 (callint.o): Depend on character.h.
7779 * eval.c (internal_lisp_condition_case): Include the handler
7780 representation in the error message.
7781 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7782 when breaking from the loop.
7784 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7786 * callint.c (Fcall_interactively): When displaying error message
7787 about invalid control letter, pass the character's codepoint, not
7788 a pointer to its multibyte form. Improve display of the character
7789 in octal and display also its hex code.
7791 * character.c (char_string): Use %x to display the (unsigned)
7792 codepoint of an invalid character, to avoid displaying a bogus
7795 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7796 `error', not SYMBOL_NAME itself.
7798 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7799 character arguments to `error'.
7801 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7802 to `error' in error message about FINAL_CHAR argument. Make sure
7803 FINAL_CHAR is a character, and use %c when it is passed as
7804 argument to `error'.
7806 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7808 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7810 * w32.c: Include <time.h>.
7811 (sys_localtime): New function.
7813 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7815 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7817 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7819 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7821 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7824 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7826 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7827 gl_state.e_property when gl_state.object is Qt.
7829 * insdel.c (make_gap_larger): Remove limitation of buffer size
7832 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7834 * xdisp.c (lookup_glyphless_char_display)
7835 (produce_glyphless_glyph): Handle cons cell entry in
7836 glyphless-char-display.
7837 (Vglyphless_char_display): Document it.
7839 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7840 glyphless-char-display.
7842 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7844 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7846 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7848 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7849 definition for no-X builds.
7851 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7853 Static checks with GCC 4.6.0 and non-default toolkits.
7855 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7857 * process.c (keyboard_bit_set): Define only if SIGIO.
7858 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7859 (send_process): Repair possible setjmp clobbering.
7861 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7863 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7865 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7867 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7868 Define only if needed.
7870 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7871 by pacifying GCC about it. Maybe it's time to retire it?
7872 * xfaces.c (USG, __TIMEVAL__): Likewise.
7874 * dispextern.h (struct redisplay_interface): Rename param
7876 * termhooks.h (struct terminal): Likewise.
7877 * xterm.c (xembed_send_message): Likewise.
7879 * insdel.c (make_gap_smaller): Define only if
7880 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7882 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7885 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7886 so that we aren't warned about unused symbols.
7888 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7890 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7892 * xfns.c (x_real_positions): Mark locals as initialized.
7894 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7896 * xterm.c: Fix problems found by static analysis with other toolkits.
7897 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7898 (x_dispatch_event): Declare static if USE_GTK, and
7899 define if USE_GTK || USE_X_TOOLKIT.
7900 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7901 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7902 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7903 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7905 * xmenu.c (menu_help_callback): Pointer type fixes.
7906 Use const pointers when pointing at readonly data. Avoid pointer
7908 (FALSE): Remove unused macro.
7909 (update_frame_menubar): Remove unused decl.
7911 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7913 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7914 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7915 (single_menu_item): Rename local to avoid shadowing.
7917 * keyboard.c (make_lispy_event): Remove unused local var.
7919 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7920 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7922 * bitmaps: Change bitmaps from unsigned char back to the X11
7923 compatible char. Avoid the old compiler warnings about
7924 out-of-range initializers by using, for example, '\xab' rather
7927 * xgselect.c (xgselect_initialize): Check vs interface
7928 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7930 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7932 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7933 to read-only memory.
7935 * fns.c (vector): Remove; this old hack is no longer needed.
7937 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7939 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7941 * xrdb.c (x_load_resources): Omit unused local.
7943 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7944 (x_window): Rename locals to avoid shadowing.
7945 (USG): Use the kludged USG macro, to pacify gcc.
7947 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7948 (x_term_init): Remove local to avoid shadowing.
7950 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7952 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7953 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7955 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7957 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7959 Fix regex.c, syntax.c and friends for buffers > 2GB.
7960 * syntax.h (struct gl_state_s): Declare character position members
7963 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7965 * textprop.c (verify_interval_modification, interval_of):
7966 Declare arguments EMACS_INT.
7968 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7971 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7973 * indent.c (Fvertical_motion): Local variable it_start is now
7976 * regex.c (re_match, re_match_2, re_match_2_internal)
7977 (bcmp_translate, regcomp, regexec, print_double_string)
7978 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7979 (re_compile_pattern, re_exec): Declare arguments and local
7980 variables `size_t' and `ssize_t' and return values `regoff_t', as
7982 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7983 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7984 <compile_stack_type>: `size' and `avail' are now `size_t'.
7986 * regex.h <regoff_t>: Use ssize_t, not int.
7987 (re_search, re_search_2, re_match, re_match_2): Arguments that
7988 specify buffer/string position and length are now ssize_t and
7989 size_t. Return type is regoff_t.
7991 2011-04-16 Ben Key <bkey76@gmail.com>
7993 * nsfont.m: Fixed bugs in ns_get_family and
7994 ns_descriptor_to_entity that were caused by using free to
7995 deallocate memory blocks that were allocated by xmalloc (via
7996 xstrdup). This caused Emacs to crash when compiled with
7997 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7998 --enable-checking=xmallocoverrun). xfree is now used to
7999 deallocate these memory blocks.
8001 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
8003 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
8005 emacs_write: Accept and return EMACS_INT for sizes.
8006 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
8008 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
8009 Accept and return EMACS_INT.
8010 (emacs_gnutls_write): Return the number of bytes written on
8012 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
8013 (emacs_read, emacs_write): Remove check for negative size, as the
8014 Emacs source code has been audited now.
8015 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
8016 (emacs_read, emacs_write): Use it.
8017 * process.c (send_process): Adjust to the new signatures of
8018 emacs_write and emacs_gnutls_write. Do not attempt to store
8019 a byte offset into an 'int'; it might overflow.
8020 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
8022 * sound.c: Don't assume sizes fit in 'int'.
8023 (struct sound_device.period_size, alsa_period_size):
8024 Return EMACS_INT, not int.
8025 (struct sound_device.write, vox_write, alsa_write):
8026 Accept EMACS_INT, not int.
8027 (wav_play, au_play): Use EMACS_INT to store sizes and to
8028 record read return values.
8030 2011-04-15 Ben Key <bkey76@gmail.com>
8032 * keyboard.c (Qundefined): Don't declare static since it is used
8034 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
8035 static since they are used in nsfont.m.
8037 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
8039 * process.c (Qprocessp): Don't declare static.
8040 * lisp.h (Qprocessp): Declare again.
8042 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
8044 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
8046 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
8048 Improve C-level modularity by making more things 'static'.
8050 Don't publish debugger-only interfaces to other modules.
8051 * lisp.h (safe_debug_print, debug_output_compilation_hack):
8052 (verify_bytepos, count_markers): Move decls to the only modules
8054 * region-cache.h (pp_cache): Likewise.
8055 * window.h (check_all_windows): Likewise.
8056 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
8058 * sysdep.c (croak): Now static, if
8059 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
8060 * syssignal.h (croak): Declare only if not static.
8062 * alloc.c (refill_memory_reserve): Now static if
8063 !defined REL_ALLOC || defined SYSTEM_MALLOC.
8064 * lisp.h (refill_memory_reserve): Declare only if not static.
8066 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
8067 Define only if USE_LUCID.
8069 * xrdb.c (x_customization_string, x_rm_string): Now static.
8071 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
8072 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
8074 * xdisp.c (draw_row_with_mouse_face): Now static.
8075 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
8077 * window.h (check_all_windows): Mark externally visible.
8079 * window.c (window_deletion_count): Now static.
8081 * undo.c: Make symbols static if they're not exported.
8082 (last_undo_buffer, last_boundary_position, pending_boundary):
8085 * textprop.c (interval_insert_behind_hooks): Now static.
8086 (interval_insert_in_front_hooks): Likewise.
8088 * term.c: Make symbols static if they're not exported.
8089 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
8090 (max_frame_lines, tty_set_terminal_modes):
8091 (tty_reset_terminal_modes, tty_turn_off_highlight):
8092 (get_tty_terminal): Now static.
8093 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
8094 * termhooks.h (term_mouse_moveto): Do not declare if
8096 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
8097 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
8099 * sysdep.c: Make symbols static if they're not exported.
8100 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
8102 (sigprocmask_set, full_mask): Remove; unused.
8103 (wait_debugging): Mark as visible.
8104 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
8105 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
8107 * syntax.c (syntax_temp): Define only if !__GNUC__.
8109 * sound.c (current_sound_device, current_sound): Now static.
8111 * search.c (searchbufs, searchbuf_head): Now static.
8113 * scroll.c (scroll_cost): Remove; unused.
8114 * dispextern.h (scroll_cost): Remove decl.
8116 * region-cache.h (pp_cache): Mark as externally visible.
8118 * process.c: Make symbols static if they're not exported.
8119 (process_tick, update_tick, create_process, chan_process):
8120 (Vprocess_alist, proc_buffered_char, datagram_access):
8121 (fd_callback_data, send_process_frame, process_sent_to): Now static.
8122 (deactivate_process): Mark defn as static, as well as decl.
8123 * lisp.h (create_process): Remove decl.
8124 * process.h (chan_process, Vprocess_alist): Remove decls.
8126 * print.c: Make symbols static if they're not exported.
8127 (print_depth, new_backquote_output, being_printed, print_buffer):
8128 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
8129 (print_interval, print_number_index, initial_stderr_stream):
8131 * lisp.h (Fprinc): Remove decl.
8132 (debug_output_compilation_hack): Mark as externally visible.
8134 * sysdep.c (croak): Move decl from here to syssignal.h.
8135 * syssignal.h (croak): Put it here, so the API can be checked when
8136 'croak' is called from dissociate_if_controlling_tty.
8138 * minibuf.c: Make symbols static if they're not exported.
8139 (minibuf_save_list, choose_minibuf_frame): Now static.
8140 * lisp.h (choose_minibuf_frame): Remove decl.
8142 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
8144 * lread.c: Make symbols static if they're not exported.
8145 (read_objects, initial_obarray, oblookup_last_bucket_number):
8147 (make_symbol): Remove; unused.
8148 * lisp.h (initial_obarray, make_symbol): Remove decls.
8150 * keyboard.c: Make symbols static if they're not exported.
8151 (single_kboard, recent_keys_index, total_keys, recent_keys):
8152 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
8153 (this_single_command_key_start, echoing, last_auto_save):
8154 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
8155 (command_loop, echo_now, keyboard_init_hook, help_char_p):
8156 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
8157 (Vlispy_mouse_stem, double_click_count):
8159 (force_auto_save_soon): Define only if SIGDANGER.
8160 (ignore_mouse_drag_p): Now static if
8161 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
8162 (print_help): Remove; unused.
8163 (stop_character, last_timer_event): Mark as externally visible.
8164 * keyboard.h (ignore_mouse_drag_p): Declare only if
8165 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
8166 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
8167 * lisp.h (echoing): Remove decl.
8168 (force_auto_save_soon): Declare only if SIGDANGER.
8169 * xdisp.c (redisplay_window): Simplify code, to make it more
8170 obvious that ignore_mouse_drag_p is not accessed if !defined
8171 USE_GTK && !defined HAVE_NS.
8173 * intervals.c: Make symbols static if they're not exported.
8174 (merge_properties_sticky, merge_interval_right, delete_interval):
8176 * intervals.h (merge_interval_right, delete_interval): Remove decls.
8178 * insdel.c: Make symbols static if they're not exported.
8179 However, leave prepare_to_modify_buffer alone. It's never
8180 called from outside this function, but that appears to be a bug.
8181 (combine_after_change_list, combine_after_change_buffer):
8182 (adjust_after_replace, signal_before_change): Now static.
8183 (adjust_after_replace_noundo): Remove; unused.
8184 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
8185 (signal_before_change): Remove decls.
8187 * indent.c (val_compute_motion, val_vmotion): Now static.
8189 * image.c: Make symbols static if they're not exported.
8190 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
8192 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
8193 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
8195 * fringe.c (standard_bitmaps): Now static.
8196 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
8198 * frame.c: Make symbols static if they're not exported.
8199 (x_report_frame_params, make_terminal_frame): Now static.
8200 (get_frame_param): Now static, unless HAVE_NS.
8201 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
8202 (x_get_resource_string): Remove; not used.
8203 * frame.h (make_terminal_frame, x_report_frame_params):
8204 (x_get_resource_string); Remove decls.
8205 (x_fullscreen_adjust): Declare only if WINDOWSNT.
8206 * lisp.h (get_frame_param): Declare only if HAVE_NS.
8208 * font.c, fontset.c: Make symbols static if they're not exported.
8209 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
8210 (FACE_SUITABLE_FOR_CHAR_P): Use it.
8211 * font.c (font_close_object): Now static.
8212 * font.h (font_close_object): Remove.
8213 * fontset.c (FONTSET_OBJLIST): Remove.
8214 (free_realized_fontset) #if-0 the body, which does nothing.
8215 (face_suitable_for_char_p): #if-0, as it's never called.
8216 * fontset.h (face_suitable_for_char_p): Remove decl.
8217 * xfaces.c (face_at_string_position):
8218 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
8219 since 0 is always ASCII.
8221 * fns.c (weak_hash_tables): Now static.
8223 * fileio.c: Make symbols static if they're not exported.
8224 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
8225 (Vwrite_region_annotation_buffers): Now static.
8227 * eval.c: Make symbols static if they're not exported.
8228 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
8229 * lisp.h (backtrace_list): Remove decl.
8231 * emacs.c: Make symbols static if they're not exported.
8232 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8233 (fatal_error_code, fatal_error_signal_hook, standard_args):
8235 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8236 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8237 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8238 * lisp.h (fatal_error_signal_hook): Remove decl.
8239 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8241 * editfns.c: Move a (normally-unused) function to its only use.
8242 * editfns.c, lisp.h (get_operating_system_release): Remove.
8243 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8244 worth the hassle of breaking this out.
8246 * xterm.c: Make symbols static if they're not exported.
8247 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8248 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8249 (x_destroy_window, x_delete_display):
8251 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8252 (x_mouse_leave): Remove; unused.
8253 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8254 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8255 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8257 (x_mouse_leave): Declare only if WINDOWSNT.
8258 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8259 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8262 * ftxfont.c: Make symbols static if they're not exported.
8263 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8265 * font.h (ftxfont_driver): Likewise.
8267 * xfns.c: Make symbols static if they're not exported.
8268 (x_last_font_name, x_display_info_for_name):
8269 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8270 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8271 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8272 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8273 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8274 (last_show_tip_args): Now static.
8275 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8276 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8277 (x_screen_planes): Remove; unused.
8278 * dispextern.h (x_screen_planes): Remove decl.
8280 * dispnew.c: Make symbols static if they're not exported.
8281 * dispextern.h (redraw_garbaged_frames, scrolling):
8282 (increment_row_positions): Remove.
8283 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8284 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8286 (redraw_garbaged_frames): Remove; unused.
8288 * xfaces.c: Make symbols static if they're not exported.
8289 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8291 * xterm.h (defined_color): Remove decls.
8292 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8293 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8294 (menu_face_changed_default, defined_color, free_realized_face):
8295 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8296 (ascii_face_of_lisp_face): Remove; unused.
8298 * xdisp.c: Make symbols static if they're not exported.
8299 * dispextern.h (scratch_glyph_row, window_box_edges):
8300 (glyph_to_pixel_coords, set_cursor_from_row):
8301 (get_next_display_element, set_iterator_to_next):
8302 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8303 (show_mouse_face): Remove decls
8304 * frame.h (message_buf_print): Likewise.
8305 * lisp.h (pop_message, set_message, check_point_in_composition):
8307 * xterm.h (set_vertical_scroll_bar): Likewise.
8308 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8309 (message_buf_print, scratch_glyph_row, displayed_buffer):
8310 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8311 (get_next_display_element, show_mouse_face, window_box_edges):
8312 (frame_to_window_pixel_xy, check_point_in_composition):
8313 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8314 (glyph_to_pixel_coords): Remove; unused.
8316 * dired.c (file_name_completion): Now static.
8318 * dbusbind.c (xd_in_read_queued_messages): Now static.
8320 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8321 * data.c (circular_list_error): Remove.
8323 * commands.h (last_point_position, last_point_position_buffer):
8324 (last_point_position_window): Remove decls.
8325 * keyboard.c: Make these variables static.
8327 * coding.h (coding, code_convert_region, encode_coding_gap):
8329 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8330 (iso_code_class, detect_coding, code_convert_region): Now static.
8331 (encode_coding_gap): Remove; unused.
8333 * chartab.c (chartab_chars, chartab_bits): Now static.
8335 * charset.h (charset_iso_8859_1): Remove decl.
8336 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8339 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8340 * ccl.c (Vccl_program_table): Now static.
8341 (check_ccl_update): Remove; unused.
8343 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8344 * category.h: ... from here.
8345 * category.c (check_category_table, set_category_set): Now static.
8347 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8348 * lisp.h: Remove these decls.
8350 * buffer.c (buffer_count): Remove unused var.
8352 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8353 so that it's not optimized away.
8354 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8355 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8356 exported only to the debugger.
8358 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
8359 * atimer.h (run_all_atimers): Remove; not exported.
8361 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8362 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8363 was inaccessible from Lisp.
8364 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8365 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8367 alloc.c: Import and export fewer symbols, and remove unused items.
8368 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8370 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8371 it's not optimized away by whole-program optimization.
8372 (message_enable_multibyte, free_misc): Remove.
8373 (catchlist, handlerlist, mark_backtrace):
8374 Declare only if BYTE_MARK_STACK.
8375 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8376 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8377 (message_enable_multibyte): Remove decl.
8378 (free_misc, interval_free_list, float_block, float_block_index):
8379 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8380 (cons_free_list, last_marked_index):
8382 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8383 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8384 (mark_backtrace): Define only if BYTE_MARK_STACK.
8385 * xdisp.c (message_enable_multibyte): Now static.
8387 Declare Lisp_Object Q* variables to be 'static' if not exported.
8388 This makes it easier for human readers (and static analyzers)
8389 to see whether these variables are used from other modules.
8390 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8391 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8392 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8393 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8394 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8395 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8396 * xmenu.c, xselect.c:
8397 Declare Q* vars static if they are not used in other modules.
8398 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8399 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8400 Remove decls of unexported vars.
8401 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8403 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8405 Make Emacs functions such as Fatom 'static' by default.
8406 This makes it easier for human readers (and static analyzers)
8407 to see whether these functions can be called from other modules.
8408 DEFUN now defines a static function. To make the function external
8409 so that it can be used in other C modules, use the new macro DEFUE.
8410 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8411 (Finit_image_library):
8412 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8413 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8414 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8415 Remove decls, since these functions are now static.
8416 (Funintern, Fget_internal_run_time): New decls, since these functions
8417 were already external.
8419 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8420 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8421 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8422 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8423 * keyboard.c, keymap.c, lread.c:
8424 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8425 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8426 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8427 Mark functions with DEFUE instead of DEFUN,
8428 if they are used in other modules.
8429 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8430 decls for now-static functions.
8431 * buffer.h (Fdelete_overlay): Remove decl.
8432 * callproc.c (Fgetenv_internal): Mark as internal.
8433 * composite.c (Fremove_list_of_text_properties): Remove decl.
8434 (Fcomposition_get_gstring): New forward static decl.
8435 * composite.h (Fcomposite_get_gstring): Remove decl.
8436 * dired.c (Ffile_attributes): New forward static decl.
8437 * doc.c (Fdocumntation_property): New forward static decl.
8438 * eval.c (Ffetch_bytecode): New forward static decl.
8439 (Funintern): Remove extern decl; now in .h file where it belongs.
8440 * fileio.c (Fmake_symbolic_link): New forward static decl.
8441 * image.c (Finit_image_library): New forward static decl.
8442 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8443 * intervals.h (Fprevious_property_change):
8444 (Fremove_list_of_text_properties): Remove decls.
8445 * keyboard.c (Fthis_command_keys): Remove decl.
8446 (Fcommand_execute): New forward static decl.
8447 * keymap.c (Flookup_key): New forward static decl.
8448 (Fcopy_keymap): Now static.
8449 * keymap.h (Flookup_key): Remove decl.
8450 * process.c (Fget_process): New forward static decl.
8451 (Fprocess_datagram_address): Mark as internal.
8452 * syntax.c (Fsyntax_table_p): New forward static decl.
8453 (skip_chars): Remove duplicate decl.
8454 * textprop.c (Fprevious_property_change): New forward static decl.
8455 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8457 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8458 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8460 * editfns.c (Fformat): Remove unreachable code.
8462 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8464 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8467 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8469 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8470 when at ZV. (Bug#8487)
8472 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8474 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8476 * keyboard.c (parse_tool_bar_item): Likewise.
8477 * sound.c (sound_cleanup, alsa_close): Likewise.
8478 * termcap.c (tgetent): Likewise.
8479 * xfns.c (x_default_font_parameter): Likewise.
8480 * xsettings.c (read_and_apply_settings): Likewise.
8482 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8483 (overrun_check_free): Protoize.
8485 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8487 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8488 since callers should never pass a negative size.
8489 Change the signature to match that of plain 'read' and 'write'; see
8490 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8491 * lisp.h: Update prototypes of emacs_write and emacs_read.
8493 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8495 * xdisp.c (redisplay_window): Don't try to determine the character
8496 position of the scroll margin if the window start point w->startp
8497 is outside the buffer's accessible region. (Bug#8468)
8499 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8501 Fix write-region and its subroutines for buffers > 2GB.
8502 * fileio.c (a_write, e_write): Modify declaration of arguments and
8503 local variables to support buffers larger than 2GB.
8504 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8506 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8507 argument, local variables, and return value.
8509 * lisp.h: Update prototypes of emacs_write and emacs_read.
8511 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8513 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8515 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8517 Fix more problems found by GCC 4.6.0's static checks.
8519 * xdisp.c (vmessage): Use a better test for character truncation.
8521 * charset.c (load_charset_map): <, not <=, for optimization,
8522 and to avoid potential problems with integer overflow.
8523 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8524 * casetab.c (set_identity, shuffle): Likewise.
8525 * editfns.c (Fformat): Likewise.
8526 * syntax.c (skip_chars): Likewise.
8528 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8529 This also lets GCC 4.6.0 generate slightly better loop code.
8531 * callint.c (Fcall_interactively): <, not <=, for optimization.
8532 (Fcall_interactively): Count the number of arguments produced,
8533 not the number of arguments given. This is simpler and lets GCC
8534 4.6.0 generate slightly better code.
8536 * ftfont.c: Distingish more carefully between FcChar8 and char.
8537 The previous code passed unsigned char * to a functions like
8538 strlen and xstrcasecmp that expect char *, which does not
8539 conform to the C standard.
8540 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8541 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8542 char * when the C standard requires it.
8544 * keyboard.c (read_char): Remove unused var.
8546 * eval.c: Port to Windows vsnprintf (Bug#8435).
8548 (SIZE_MAX): Define if the headers do not.
8549 (verror): Do not give up if vsnprintf returns a negative count.
8550 Instead, grow the buffer. This ports to Windows vsnprintf, which
8551 does not conform to C99. Problem reported by Eli Zaretskii.
8552 Also, simplify the allocation scheme, by avoiding the need for
8553 calling realloc, and removing the ALLOCATED variable.
8555 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8557 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8558 But keep the doprint source code for now, as we might revamp it
8559 and use it again (Bug#8435).
8560 * lisp.h (doprnt): Remove.
8561 * Makefile.in (base_obj): Remove doprnt.o.
8562 * deps.mk (doprnt.o): Remove.
8564 error: Print 32- and 64-bit integers portably (Bug#8435).
8565 Without this change, on typical 64-bit hosts error ("...%d...", N)
8566 was used to print both 32- and 64-bit integers N, which relied on
8568 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8569 * lisp.h (error, verror): Mark as printf-like functions.
8570 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8571 Report overflow in size calculations when allocating printf buffer.
8572 Do not truncate output string at its first null byte.
8573 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8574 Truncate the output at a character boundary, since vsnprintf does not
8576 * charset.c (check_iso_charset_parameter): Convert internal
8577 character to string before calling 'error', since %c now has the
8579 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8580 overflow when computing char to be passed to 'error'. Do not
8581 pass Lisp_Object to 'error'; pass the integer instead.
8582 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8583 formatted with plain %d.
8585 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8587 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8589 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8591 * xterm.c (x_catch_errors): Remove duplicate declaration.
8593 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8595 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8597 2011-04-10 Jim Meyering <meyering@redhat.com>
8599 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8600 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8601 return ssize_t not "int", and use size_t as the buffer length.
8602 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8603 * gnutls.h: Update declarations.
8604 * process.c (read_process_output): Use ssize_t, to match.
8605 (send_process): Likewise.
8607 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8609 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8611 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8613 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8614 Use unsigned char, to match FcChar8 type definition.
8616 * xterm.c (handle_one_xevent):
8617 * xmenu.c (create_and_show_popup_menu):
8618 * xselect.c (x_decline_selection_request)
8619 (x_reply_selection_request): Avoid type-punned deref of X events.
8621 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8623 Fix some uses of `int' instead of EMACS_INT.
8624 * search.c (string_match_1, fast_string_match)
8625 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8626 (scan_buffer, find_next_newline_no_quit)
8627 (find_before_next_newline, search_command, Freplace_match)
8628 (Fmatch_data): Make some `int' variables be EMACS_INT.
8630 * xdisp.c (display_count_lines): 3rd argument and return value now
8631 EMACS_INT. All callers changed.
8632 (pint2hrstr): Last argument is now EMACS_INT.
8634 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8635 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8636 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8637 (decode_coding_utf_16, decode_coding_emacs_mule)
8638 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8639 (decode_coding_ccl, decode_coding_charset)
8640 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8641 (decode_coding_iso_2022, decode_coding_emacs_mule)
8642 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8643 <char_offset, last_offset>: Declare EMACS_INT.
8644 (encode_coding_utf_8, encode_coding_utf_16)
8645 (encode_coding_emacs_mule, encode_invocation_designation)
8646 (encode_designation_at_bol, encode_coding_iso_2022)
8647 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8648 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8650 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8651 (encode_invocation_designation): Last argument P_NCHARS is now
8653 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8654 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8656 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8659 * ccl.c (Fccl_execute_on_string): Declare some variables
8662 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8664 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8666 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8668 * process.c (Fformat_network_address): Doc fix.
8670 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8672 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8674 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8676 * keyboard.c (read_char): Call Lisp function help-form-show,
8677 instead of using internal_with_output_to_temp_buffer.
8678 (Qhelp_form_show): New var.
8679 (syms_of_keyboard): Use DEFSYM macro.
8681 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8683 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8685 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8687 * process.c (Flist_processes): Remove to Lisp.
8688 (list_processes_1): Delete.
8690 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8692 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8694 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8696 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8698 Fix more problems found by GCC 4.6.0's static checks.
8700 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8702 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8704 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8706 * xdisp.c (vmessage): Mark as a printf-like function.
8708 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8710 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8712 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8713 printf-like functions.
8714 (tiff_load): Add casts to remove these marks before passing them
8715 to system-supplied API.
8717 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8719 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8720 This avoids several warnings with gcc -Wstrict-overflow.
8721 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8722 directly, rather than having caller test rule sign. This avoids
8723 some unnecessary tests.
8724 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8725 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8726 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8728 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8729 (xfont_open): Avoid unnecessary tests.
8731 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8733 * composite.h, composite.c (composition_gstring_put_cache):
8734 Use EMACS_INT, not int, for length.
8736 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8737 breaking out part of COMPOSITION_DECODE_RULE.
8738 (COMPOSITION_DECODE_RULE): Use it.
8739 * composite.c (get_composition_id): Remove unused local vars,
8740 by using the new macro.
8742 * textprop.c (set_text_properties_1): Change while to do-while,
8743 since the condition is always true at first.
8745 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8746 (interval_deletion_adjustment): Return unsigned value.
8749 * process.c (list_processes_1, create_pty, read_process_output):
8750 (exec_sentinel): Remove vars that were set but not used.
8751 (create_pty): Remove unnecessary "volatile"s.
8752 (Fnetwork_interface_info): Avoid possibility of int overflow.
8753 (read_process_output): Do adaptive read buffering even if carryover.
8754 (read_process_output): Simplify nbytes computation if buffered.
8756 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8758 * syntax.c (scan_words): Remove var that was set but not used.
8759 (update_syntax_table): Use unsigned instead of int.
8761 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8762 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8763 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8765 * print.c (print_error_message): Avoid int overflow.
8767 * font.c (font_list_entities): Redo for clarity,
8768 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8770 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8771 (font_score): Avoid potential overflow in diff calculation.
8773 * fns.c (substring_both): Remove var that is set but not used.
8774 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8776 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8778 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8779 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8780 can always succeed if overflow has undefined behavior.
8782 * search.c (boyer_moore, wordify): Remove vars set but not used.
8783 (wordify): Omit three unnecessary tests.
8785 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8786 All callers changed. This avoids the need for an unused var.
8788 * casefiddle.c (casify_region): Remove var that is set but not used.
8790 * dired.c (file_name_completion): Remove var that is set but not used.
8792 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8794 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8795 (Finsert_file_contents): Remove unnecessary code checking fd.
8797 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8798 Check for integer overflow on size calculations.
8800 * buffer.c (Fprevious_overlay_change): Remove var that is set
8803 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8804 Remove vars that are set but not used.
8805 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8806 (timer_check_2): Mark vars as initialized.
8808 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8810 * image.c (lookup_image): Remove var that is set but not used.
8811 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8813 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8814 that are set but not used.
8816 * xfns.c (make_invisible_cursor): Don't return garbage
8817 if XCreateBitmapFromData fails (Bug#8410).
8819 * xselect.c (x_get_local_selection, x_handle_property_notify):
8820 Remove vars that are set but not used.
8822 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8823 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8825 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8826 Remove var that is set but not used.
8827 (scroll_bar_windows_size): Now size_t, not int.
8828 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8831 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8832 (map_tty_color) [!defined MSDOS]: Likewise.
8834 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8836 * coding.c: Remove vars that are set but not used.
8837 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8838 All callers changed.
8839 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8840 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8841 (decode_coding_charset): Remove vars that are set but not used.
8843 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8844 that is set but not used.
8846 * print.c (print_object): Remove var that is set but not used.
8848 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8849 The gnulib version avoids calling malloc in the usual case,
8850 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8851 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8852 * filelock.c (current_lock_owner): Likewise.
8853 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8854 * sysdep.c: Include allocator.h, careadlinkat.h.
8855 (emacs_no_realloc_allocator): New static constant.
8856 (emacs_readlink): New function.
8857 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8858 ../lib/careadlinkat.h.
8860 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8862 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8863 first non-nil return value).
8865 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8867 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8868 if not defined (Bug#8403).
8870 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8872 * xdisp.c (display_count_lines): Remove parameter `start',
8873 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8874 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8875 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8876 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8877 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8878 and thereabouts. All callers changed.
8879 (get_per_char_metric): Remove parameter `f', unused since
8880 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8882 2011-04-02 Jim Meyering <meyering@redhat.com>
8884 do not dereference NULL upon failed strdup
8885 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8886 (ns_get_family): Likewise.
8888 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8890 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8892 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8894 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8897 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8899 Add lexical binding.
8901 * window.c (Ftemp_output_buffer_show): New fun.
8902 (Fsave_window_excursion):
8903 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8905 * lread.c (lisp_file_lexically_bound_p): New function.
8906 (Fload): Bind Qlexical_binding.
8907 (readevalloop): Remove `evalfun' arg.
8908 Bind Qinternal_interpreter_environment.
8909 (Feval_buffer): Bind Qlexical_binding.
8910 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8912 (syms_of_lread): Declare `lexical-binding'.
8914 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8916 * keyboard.c (eval_dyn): New fun.
8917 (menu_item_eval_property): Use it.
8919 * image.c (parse_image_spec): Use Ffunctionp.
8921 * fns.c (concat, mapcar1): Accept byte-code-functions.
8923 * eval.c (Fsetq): Handle lexical vars.
8924 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8925 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8926 (FletX, Flet): Obey lexical binding.
8927 (Fcommandp): Handle closures.
8928 (Feval): New `lexical' arg.
8929 (eval_sub): New function extracted from Feval. Use it almost
8930 everywhere where Feval was used. Look up vars in lexical env.
8932 (Ffunctionp): Move from subr.el.
8933 (Ffuncall): Handle closures.
8934 (apply_lambda): Remove `eval_flags'.
8935 (funcall_lambda): Handle closures and new byte-code-functions.
8936 (Fspecial_variable_p): New function.
8937 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8938 but without exporting it to Lisp.
8940 * doc.c (Fdocumentation, store_function_docstring):
8941 * data.c (Finteractive_form): Handle closures.
8943 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8946 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8948 (exec_byte_code): New function extracted from Fbyte_code to handle new
8949 calling convention for byte-code-functions. Add new byte-codes.
8951 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8953 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8955 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8957 * xdisp.c (redisplay_internal): Fix prototype.
8959 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8961 * xdisp.c (SCROLL_LIMIT): New macro.
8962 (try_scrolling): Use it when setting scroll_limit.
8963 Limit scrolling to 100 screen lines.
8964 (redisplay_window): Even when falling back on "recentering",
8965 position point in the window according to scroll-conservatively,
8966 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8968 (try_scrolling): When point is above the window, allow searching
8969 as far as scroll_max, or one screenful, to compute vertical
8970 distance from PT to the scroll margin position. This prevents
8971 try_scrolling from unnecessarily failing when
8972 scroll-conservatively is set to a value slightly larger than the
8973 window height. Clean up the case of PT below the margin at bottom
8974 of window: scroll_max can no longer be INT_MAX. When aggressive
8975 scrolling is in use, don't let point enter the opposite scroll
8976 margin as result of the scroll.
8977 (syms_of_xdisp) <scroll-conservatively>: Document the
8978 threshold of 100 lines for never-recentering scrolling.
8980 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8982 * dispextern.h (move_it_by_lines):
8983 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8984 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8985 (message_log_check_duplicate): Remove parameters `prev_bol' and
8986 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8987 (redisplay_internal): Remove parameter `preserve_echo_area',
8988 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8990 * indent.c (Fvertical_motion):
8991 * window.c (window_scroll_pixel_based, Frecenter):
8992 Don't pass `need_y_p' to `move_it_by_lines'.
8994 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8996 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8997 steal a few bits to be more compact.
8998 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8999 Remove unneeded casts.
9001 * bytecode.c (Fbyte_code): CAR and CDR can GC.
9003 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
9005 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
9006 binding" message (bug#7967).
9008 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
9010 Fix more problems found by GCC 4.6.0's static checks.
9012 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
9013 Remove unused local var.
9015 * editfns.c (Fmessage_box): Remove unused local var.
9017 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
9018 (note_mode_line_or_margin_highlight, note_mouse_highlight):
9019 Omit unused local vars.
9020 * window.c (shrink_windows): Omit unused local var.
9021 * menu.c (digest_single_submenu): Omit unused local var.
9022 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
9023 Omit unused local var.
9025 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
9026 Don't assume string length fits in int.
9027 (keyremap_step, read_key_sequence): Use size_t for sizes.
9028 (read_key_sequence): Don't check last_real_key_start redundantly.
9030 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
9031 instead of alloca (Bug#8344).
9033 * eval.c (Fbacktrace): Don't assume nargs fits in int.
9034 (Fbacktrace_frame): Don't assume nframes fits in int.
9036 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
9038 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
9041 * term.c (produce_glyphless_glyph): Remove unnecessary test.
9043 * cm.c (calccost): Turn while-do into do-while, for clarity.
9045 * keyboard.c (syms_of_keyboard): Use the same style as later
9046 in this function when indexing through an array. This also
9047 works around GCC bug 48267.
9049 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
9051 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
9053 * chartab.c (sub_char_table_ref_and_range): Redo for slight
9054 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
9056 * keyboard.c, keyboard.h (num_input_events): Now size_t.
9057 This avoids undefined behavior on integer overflow, and is a bit
9058 more convenient anyway since it is compared to a size_t variable.
9060 Variadic C functions now count arguments with size_t, not int.
9061 This avoids an unnecessary limitation on 64-bit machines, which
9062 caused (substring ...) to crash on large vectors (Bug#8344).
9063 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
9064 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
9065 All variadic functions and their callers changed accordingly.
9066 (struct gcpro.nvars): Now size_t, not int. All uses changed.
9067 * data.c (arith_driver, float_arith_driver): Likewise.
9068 * editfns.c (general_insert_function): Likewise.
9069 * eval.c (struct backtrace.nargs, interactive_p)
9070 (internal_condition_case_n, run_hook_with_args, apply_lambda)
9071 (funcall_lambda, mark_backtrace): Likewise.
9072 * fns.c (concat): Likewise.
9073 * frame.c (x_set_frame_parameters): Likewise.
9074 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
9075 0 if not found, not -1. All callers changed.
9077 * alloc.c (garbage_collect): Don't assume stack size fits in int.
9078 (stack_copy_size): Now size_t, not int.
9079 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
9081 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
9083 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
9084 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9085 All callers changed.
9087 * lisp.h (multibyte_char_to_unibyte):
9088 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
9089 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9090 * character.h (CHAR_TO_BYTE8):
9091 * cmds.c (internal_self_insert):
9092 * editfns.c (general_insert_function):
9093 * keymap.c (push_key_description):
9094 * search.c (Freplace_match):
9095 * xdisp.c (message_dolog, set_message_1): All callers changed.
9097 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
9099 * keyboard.c (safe_run_hook_funcall): New function.
9100 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
9101 don't set the hook to nil, but remove the offending function instead.
9102 (Qcommand_hook_internal): Remove, unused.
9103 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
9104 Vcommand_hook_internal.
9106 * eval.c (enum run_hooks_condition): Remove.
9107 (funcall_nil, funcall_not): New functions.
9108 (run_hook_with_args): Call each function through a `funcall' argument.
9109 Remove `cond' argument, now redundant.
9110 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
9111 (Frun_hook_with_args_until_failure): Adjust accordingly.
9112 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
9114 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
9116 * dispextern.h (string_buffer_position): Remove declaration.
9118 * print.c (strout): Remove parameter `multibyte', unused since
9119 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
9121 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
9122 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
9123 All callers changed.
9125 * w32.c (_wsa_errlist): Use braces for struct initializers.
9127 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
9128 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
9129 All callers changed.
9130 (string_buffer_position): Likewise. Also, make static (it's never
9131 used outside xdisp.c).
9132 (cursor_row_p): Remove parameter `w', unused since
9133 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
9134 (decode_mode_spec): Remove parameter `precision', introduced during
9135 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
9136 All callers changed.
9138 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9140 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
9142 2011-03-27 Anders Lindgren <andlind@gmail.com>
9144 * nsterm.m (ns_menu_bar_is_hidden): New variable.
9145 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
9146 (ns_update_auto_hide_menu_bar): New functions.
9147 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
9148 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
9149 ns_constrain_all_frames.
9150 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
9151 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
9153 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9155 * nsmenu.m (runDialogAt): Remove argument to timer_check.
9157 2011-03-27 Glenn Morris <rgm@gnu.org>
9159 * syssignal.h: Replace RETSIGTYPE with void.
9160 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
9161 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
9162 Replace SIGTYPE with void everywhere.
9163 * s/usg5-4-common.h (SIGTYPE): Remove definition.
9164 * s/template.h (SIGTYPE): Remove commented out definition.
9166 2011-03-26 Eli Zaretskii <eliz@gnu.org>
9168 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
9169 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
9171 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
9173 * w32.c (read_unc_volume): Use parameter `henum', instead of
9174 global variable `wget_enum_handle'.
9176 * keymap.c (describe_vector): Remove parameters `indices' and
9177 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
9178 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
9180 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
9182 * keyboard.c (timer_check): Remove parameter `do_it_now',
9183 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
9184 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
9185 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
9187 * keyboard.c (read_char):
9188 * w32menu.c (w32_menu_display_help):
9189 * xmenu.c (show_help_event, menu_help_callback):
9190 Adjust calls to `show_help_echo'.
9192 * gtkutil.c (xg_maybe_add_timer):
9193 * keyboard.c (readable_events):
9194 * process.c (wait_reading_process_output):
9195 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
9197 * insdel.c (adjust_markers_gap_motion):
9198 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
9199 (gap_left, gap_right): Don't call it.
9201 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
9203 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
9204 incurred during fontification.
9206 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9208 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
9209 (DEFVAR_PER_BUFFER): Don't pass it.
9211 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
9212 (scrolling_window): Don't pass it.
9214 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9216 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
9218 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
9220 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
9221 of variables specific to SELinux and computation of `encoded_absname'.
9223 * image.c (XPutPixel): Remove unused variable `height'.
9225 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
9227 * unexw32.c (get_section_info): Remove unused variable `section'.
9229 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
9230 (system_process_attributes): Remove unused variable `sess'.
9231 (sys_read): Remove unused variable `err'.
9233 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9234 (w32_wnd_proc): Remove unused variable `isdead'.
9235 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9236 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9237 (x_create_tip_frame): Remove unused variable `tem'.
9239 * w32inevt.c (w32_console_read_socket):
9240 Remove unused variable `no_events'.
9242 * w32term.c (x_draw_composite_glyph_string_foreground):
9243 Remove unused variable `width'.
9245 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
9247 * w32term.c (x_set_glyph_string_clipping):
9248 Don't pass uninitialized region to CombineRgn.
9250 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
9252 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9253 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9254 (Fx_close_connection): Remove unused variable `i'.
9256 * w32font.c (w32font_draw): Return number of glyphs.
9257 (w32font_open_internal): Remove unused variable `i'.
9258 (w32font_driver): Add missing initializer.
9260 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9261 (fill_in_menu): Remove unused variable `items_added'.
9263 * w32term.c (last_mouse_press_frame): Remove static global variable.
9264 (w32_clip_to_row): Remove unused variable `f'.
9265 (x_delete_terminal): Remove unused variable `i'.
9267 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9268 (NOTHING): Remove unused static global variable.
9269 (uniscribe_check_otf): Remove unused variable `table'.
9270 (uniscribe_font_driver): Add missing initializers.
9272 2011-03-23 Julien Danjou <julien@danjou.info>
9274 * term.c (Fsuspend_tty, Fresume_tty):
9275 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9276 * window.c (temp_output_buffer_show):
9277 * insdel.c (signal_before_change):
9278 * frame.c (Fhandle_switch_frame):
9279 * fileio.c (Fdo_auto_save):
9280 * emacs.c (Fkill_emacs):
9281 * editfns.c (save_excursion_restore):
9282 * cmds.c (internal_self_insert):
9283 * callint.c (Fcall_interactively):
9284 * buffer.c (Fkill_all_local_variables):
9285 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9287 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
9288 unconditionally since it does the check itself.
9290 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
9292 Fix more problems found by GCC 4.5.2's static checks.
9294 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9295 the first time through the loop, since we know p0 < p1 then.
9296 This also avoids a gcc -Wstrict-overflow warning.
9298 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9299 leading to a memory leak, possible in functions like
9300 load_charset_map_from_file that can allocate an unbounded number
9301 of objects (Bug#8318).
9303 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9304 that could (at least in theory) be that large.
9306 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9307 This is less likely to overflow, and avoids undefined behavior if
9308 overflow does occur. All callers changed. Use strtoul to scan
9309 for the unsigned long integer.
9310 (pint2hrstr): Simplify and tune code slightly.
9311 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
9313 * scroll.c (do_scrolling): Work around GCC bug 48228.
9314 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9316 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9317 This also avoids a warning with gcc -Wstrict-overflow.
9318 (validate_x_resource_name): Simplify count usage.
9319 This also avoids a warning with gcc -Wstrict-overflow.
9321 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9324 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
9326 * process.c (Fmake_network_process): Use socklen_t, not int,
9327 where POSIX says socklen_t is required in portable programs.
9328 This fixes a porting bug on hosts like 64-bit HP-UX, where
9329 socklen_t is wider than int (Bug#8277).
9330 (Fmake_network_process, server_accept_connection):
9331 (wait_reading_process_output, read_process_output):
9334 * process.c: Rename or move locals to avoid shadowing.
9335 (list_processes_1, Fmake_network_process):
9336 (read_process_output_error_handler, exec_sentinel_error_handler):
9337 Rename or move locals.
9338 (Fmake_network_process): Define label "retry_connect" only if needed.
9339 (Fnetwork_interface_info): Fix pointer signedness.
9340 (process_send_signal): Add cast to avoid pointer signedness problem.
9341 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
9342 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
9344 Make tparam.h and terminfo.c consistent.
9345 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9346 Include tparam.h instead, since it declares them.
9347 * cm.h (PC): Remove extern decl; tparam.h now does this.
9348 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9349 * terminfo.c: Include tparam.h, to check interfaces.
9350 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9351 (tparam): Adjust signature to match interface in tparam.h;
9352 this removes some undefined behavior. Check that outstring and len
9353 are zero, which they always are with Emacs.
9354 * tparam.h (PC, BC, UP): New extern decls.
9356 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
9357 (xftfont_open): Rename locals to avoid shadowing.
9359 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
9360 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9361 (OTF_TAG_SYM): Omit macro if not needed.
9362 (ftfont_list): Remove unused local.
9363 (get_adstyle_property, ftfont_pattern_entity):
9364 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9365 Rename locals to avoid shadowing.
9367 * xfont.c (xfont_list_family): Mark var as initialized.
9369 * xml.c (make_dom): Now static.
9371 * composite.c (composition_compute_stop_pos): Rename local to
9373 (composition_reseat_it): Remove unused locals.
9374 (find_automatic_composition, composition_adjust_point): Likewise.
9375 (composition_update_it): Mark var as initialized.
9376 (find_automatic_composition): Mark vars as initialized,
9377 with a FIXME (Bug#8290).
9379 character.h: Rename locals to avoid shadowing.
9380 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9381 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9382 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9383 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9386 * textprop.c (property_change_between_p): Remove; unused.
9388 * intervals.c (interval_start_pos): Now static.
9390 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9392 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9393 Rename locals to avoid shadowing.
9395 * sound.c (wav_play, au_play, Fplay_sound_internal):
9396 Fix pointer signedness.
9397 (alsa_choose_format): Remove unused local var.
9398 (wav_play): Initialize a variable to 0, to prevent undefined
9399 behavior (Bug#8278).
9401 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9403 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9405 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9406 clobbering (Bug#8298).
9407 * sysdep.c (sys_subshell): Likewise.
9408 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9410 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9411 This should get cleaned up, so that child_setup has the
9412 same signature on all platforms.
9414 * callproc.c (call_process_cleanup): Now static.
9415 (relocate_fd): Rename locals to avoid shadowing.
9417 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9419 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9420 not to be necessary, and produces flickering.
9422 2011-03-20 Glenn Morris <rgm@gnu.org>
9424 * config.in: Remove file.
9426 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9428 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9429 are now in src/globals.h.
9430 (syms_of_minibuf): Remove spurious & from previous change.
9432 2011-03-20 Leo Liu <sdl.web@gmail.com>
9434 * minibuf.c (completing-read-function): New variable.
9435 (completing-read-default): Rename from completing-read.
9436 (completing-read): Call completing-read-function.
9438 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9440 * xfaces.c (Fx_load_color_file):
9441 Read color file from absolute filename (bug#8250).
9443 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9445 * makefile.w32-in: Update dependencies.
9447 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9449 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9451 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9453 Fix more problems found by GCC 4.5.2's static checks.
9455 * process.c (make_serial_process_unwind, send_process_trap):
9456 (sigchld_handler): Now static.
9458 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9459 That way, the code declares only the vars that it needs.
9460 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9461 * s/cygwin.h (PTY_ITERATION): Likewise.
9462 * s/darwin.h (PTY_ITERATION): Likewise.
9463 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9465 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9466 * process.c (allocate_pty): Don't declare stb unless it's needed.
9468 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9469 (CONSTANTLIM): Remove; unused.
9470 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9471 Define only if needed.
9473 * unexelf.c (unexec): Name an expression,
9474 to avoid gcc -Wbad-function-cast warning.
9475 Use a different way to cause a compilation error if anyone uses
9476 n rather than nn, a way that does not involve shadowing.
9477 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9479 * deps.mk (unexalpha.o): Remove; unused.
9481 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9482 * unexec.h: New file.
9483 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9484 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9486 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9487 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9488 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9489 Change as necessary to match prototype in unexec.h.
9491 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9493 (back_comment, skip_chars): Mark vars as initialized.
9495 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9496 Rename locals to avoid shadowing.
9498 * lread.c (read1): Rewrite so as not to use empty "else".
9499 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9501 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9503 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9504 warning when compiling print.c.
9506 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9507 instead of using an uninitialized var.
9508 (font_sort_entities): Mark var as initialized.
9510 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9512 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9513 pointers to constants.
9514 (font_parse_fcname): Remove unused vars.
9515 (font_delete_unmatched): Now static.
9516 (font_get_spec): Remove; unused.
9517 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9518 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9519 Rename or move locals to avoid shadowing.
9521 * fns.c (require_nesting_list, require_unwind): Now static.
9522 (Ffillarray): Rename locals to avoid shadowing.
9524 * floatfns.c (domain_error2): Define only if needed.
9525 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9527 * alloc.c (mark_backtrace): Move decl from here ...
9528 * lisp.h: ... to here, so that it can be checked.
9530 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9531 (Fdefvar): Rewrite so as not to use empty "else".
9532 (lisp_indirect_variable): Name an expression,
9533 to avoid gcc -Wbad-function-cast warning.
9534 (Fdefvar): Rename locals to avoid shadowing.
9536 * callint.c (quotify_arg, quotify_args): Now static.
9537 (Fcall_interactively): Rename locals to avoid shadowing.
9538 Use const pointer when appropriate.
9540 * lisp.h (get_system_name, get_operating_system_release):
9541 Move decls here, to check interfaces.
9542 * process.c (get_operating_system_release): Move decl to lisp.h.
9543 * xrdb.c (get_system_name): Likewise.
9544 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9545 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9546 some of which prompt warnings from gcc -Wbad-function-cast.
9547 (Fformat_time_string, Fencode_time, Finsert_char):
9548 (Ftranslate_region_internal, Fformat):
9549 Rename or remove local vars to avoid shadowing.
9550 (Ftranslate_region_internal): Mark var as initialized.
9552 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9555 * lisp.h (eassert): Check that the argument compiles, even if
9556 ENABLE_CHECKING is not defined.
9558 * data.c (Findirect_variable): Name an expression, to avoid
9559 gcc -Wbad-function-cast warning.
9560 (default_value, arithcompare, arith_driver, arith_error): Now static.
9561 (store_symval_forwarding): Rename local to avoid shadowing.
9562 (Fmake_variable_buffer_local, Fmake_local_variable):
9563 Mark variables as initialized.
9564 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9566 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9567 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9568 Rename locals to avoid shadowing.
9569 (mark_stack): Move local variables into the #ifdef region where
9571 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9572 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9574 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9575 (GC_STRING_CHARS): Remove; not used.
9576 (Fmemory_limit): Cast sbrk's returned value to char *.
9578 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9579 avoids undefined behavior in theory.
9581 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9583 Use functions, not macros, for up- and down-casing (Bug#8254).
9584 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9585 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9586 to use the following functions instead of these macros.
9587 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9588 EMACS_INT, since callers assume the returned value fits in int.
9589 (upcase1): Likewise, for UPCASE_TABLE.
9590 (uppercasep, lowercasep, upcase): New static inline functions.
9591 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9592 the race-condition problem in the old DOWNCASE.
9594 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9595 Rename locals to avoid shadowing.
9596 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9597 (regex_compile, re_search_2, re_match_2_internal):
9598 Remove unused local vars.
9599 (FREE_VAR): Rewrite so as not to use empty "else",
9600 which gcc can warn about.
9601 (regex_compile, re_match_2_internal): Mark locals as initialized.
9602 (RETALLOC_IF): Define only if needed.
9603 (WORDCHAR_P): Likewise. This one is never needed, but is used
9604 only in a comment talking about a compiler bug, so put inside
9605 the #if 0 of that comment.
9606 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9607 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9610 * search.c (boyer_moore): Rename locals to avoid shadowing.
9611 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9612 (PREV_CHAR_BOUNDARY): Likewise.
9614 * search.c (simple_search): Remove unused var.
9616 * dired.c (compile_pattern): Move decl from here ...
9617 * lisp.h: ... to here, so that it can be checked.
9618 (struct re_registers): New forward decl.
9620 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9622 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9624 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9625 Rename locals to avoid shadowing.
9626 (Fvertical_motion): Mark locals as initialized.
9628 * casefiddle.c (casify_object, casify_region): Now static.
9629 (casify_region): Mark local as initialized.
9631 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9633 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9634 New macros, so that the caller can use some names other than
9635 gcpro1, gcpro2, etc.
9636 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9638 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9639 argument, for consistency with GCPRO2_VAR, etc: it is now the
9640 prefix of the variable, not the variable itself. All uses
9642 * dired.c (directory_files_internal, file_name_completion):
9643 Rename locals to avoid shadowing.
9645 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9646 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9647 dired.c's scmp function, had undefined behavior.
9648 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9649 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9650 * buffer.h: ... to here, because these macros use current_buffer,
9651 and the new implementation with inline functions needs to have
9652 current_buffer in scope now, rather than later when the macros
9654 (downcase, upcase1): New static inline functions.
9655 (DOWNCASE, UPCASE1): Reimplement using these functions.
9656 This avoids undefined behavior in expressions like
9657 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9658 from race conditions in accessing the global variables
9659 case_temp1 and case_temp2.
9660 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9661 * lisp.h (case_temp1, case_temp2): Remove their decls.
9662 * character.h (ASCII_CHAR_P): Move from here ...
9663 * lisp.h: ... to here, so that the inline functions mentioned
9666 * dired.c (directory_files_internal_unwind): Now static.
9668 * fileio.c (file_name_as_directory, directory_file_name):
9669 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9671 (file_name_as_directory): Use const pointers when appropriate.
9672 (Fexpand_file_name): Likewise. In particular, newdir might
9673 point at constant storage, so make it a const pointer.
9674 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9675 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9677 (Fset_file_times, Finsert_file_contents, auto_save_error):
9678 Rename locals to avoid shadowing.
9680 * minibuf.c (choose_minibuf_frame_1): Now static.
9681 (Ftry_completion, Fall_completions): Rename or remove locals
9684 * marker.c (bytepos_to_charpos): Remove; unused.
9686 * lisp.h (verify_bytepos, count_markers): New decls,
9687 so that gcc does not warn that these functions aren't declared.
9689 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9690 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9691 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9692 (copy_text): Remove unused local var.
9694 * filelock.c (within_one_second): Now static.
9695 (lock_file_1): Rename local to avoid shadowing.
9697 * buffer.c (fix_overlays_before): Mark locals as initialized.
9698 (fix_start_end_in_overlays): Likewise. This function should be
9699 simplified by using pointers-to-pointers, but that's a different
9701 (switch_to_buffer_1): Now static.
9702 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9703 (report_overlay_modification): Rename locals to avoid shadowing.
9705 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9706 Fix pointer signedness issue.
9707 (sys_subshell): Mark local as volatile if checking for lint,
9708 to suppress a gcc -Wclobbered warning that does not seem to be right.
9709 (MAXPATHLEN): Define only if needed.
9711 * process.c (serial_open, serial_configure): Move decls from here ...
9712 * systty.h: ... to here, so that they can be checked.
9714 * fns.c (get_random, seed_random): Move extern decls from here ...
9715 * lisp.h: ... to here, so that they can be checked.
9717 * sysdep.c (reset_io): Now static.
9718 (wait_for_termination_signal): Remove; unused.
9720 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9721 (copy_keymap_item, append_key, push_text_char_description):
9723 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9724 (DENSE_TABLE_SIZE): Remove; unused.
9725 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9726 (describe_map_tree):
9727 Rename locals to avoid shadowing.
9729 * keyboard.c: Declare functions static if they are not used elsewhere.
9730 (echo_char, echo_dash, cmd_error, top_level_2):
9731 (poll_for_input, handle_async_input): Now static.
9732 (read_char, kbd_buffer_get_event, make_lispy_position):
9733 (make_lispy_event, make_lispy_movement, apply_modifiers):
9734 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9735 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9736 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9737 (read_key_sequence, read_char): Mark locals as initialized.
9738 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9740 * keyboard.h (make_ctrl_char): New decl.
9741 (mark_kboards): Move decl here ...
9742 * alloc.c (mark_kboards): ... from here.
9744 * lisp.h (force_auto_save_soon): New decl.
9746 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9747 (DEFINE_DUMMY_FUNCTION): New macro.
9748 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9750 (main): Add casts to avoid warnings
9751 if GCC considers string literals to be constants.
9753 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9755 * dbusbind.c: Pointer signedness fixes.
9756 (xd_signature, xd_append_arg, xd_initialize):
9757 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9758 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9759 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9760 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9762 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9763 if GCC considers string literals to be constants.
9764 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9766 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9768 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9769 (print_preprocess, print_object): New macro to fix last change.
9771 * print.c (print_preprocess): Don't forget font objects.
9773 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9775 * emacs.c (USAGE3): Doc fixes.
9777 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9779 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9782 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9784 * lisp.h (VWindow_system, Qfile_name_history):
9785 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9786 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9787 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9789 * w32select.c: Don't #include "keyboard.h".
9790 (run_protected): Add extern declaration for waiting_for_input.
9792 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9793 * w32console.c (detect_input_pending, read_input_pending)
9794 (encode_terminal_code):
9795 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9796 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9797 (w32_system_caret_y, Qfile_name_history):
9798 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9799 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9800 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9801 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9802 * w32proc.c (Qlocal, report_file_error):
9803 * w32term.c (Vwindow_system, updating_frame):
9804 * w32uniscribe.c (initialized, uniscribe_font_driver):
9805 Remove unneeded extern declarations.
9807 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9809 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9811 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9813 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9814 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9815 These macros can no longer be used for assignment.
9817 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9818 Assign struct members directly, instead of using BUF_BEGV etc.
9819 (record_buffer_markers, fetch_buffer_markers): New functions for
9820 recording and fetching special buffer markers.
9821 (set_buffer_internal_1, set_buffer_temp): Use them.
9823 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9825 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9827 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9828 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9830 * xdisp.c (hscroll_window_tree):
9831 (reconsider_clip_changes): Use PT instead of BUF_PT.
9833 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9835 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9836 $(EMACS_ROOT)/lib/intprops.h.
9838 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9840 Fix more problems found by GCC 4.5.2's static checks.
9842 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9843 to unsigned char * to avoid compiler diagnostic.
9844 (xg_free_frame_widgets): Make it clear that a local variable is
9845 needed only if USE_GTK_TOOLTIP.
9846 (gdk_window_get_screen): Make it clear that this macro is needed
9847 only if USE_GTK_TOOLTIP.
9848 (int_gtk_range_get_value): New function, which avoids a diagnostic
9849 from gcc -Wbad-function-cast.
9850 (xg_set_toolkit_scroll_bar_thumb): Use it.
9851 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9852 diagnostic from gcc -Wbad-function-cast.
9853 (get_utf8_string, xg_get_file_with_chooser):
9854 Rename locals to avoid shadowing.
9855 (create_dialog): Move locals to avoid shadowing.
9857 * xgselect.c (xg_select): Remove unused var.
9859 * image.c (four_corners_best): Mark locals as initialized.
9860 (gif_load): Initialize transparent_p to zero (Bug#8238).
9861 Mark another local as initialized.
9862 (my_png_error, my_error_exit): Mark with NO_RETURN.
9864 * image.c (clear_image_cache): Now static.
9865 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9866 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9867 (x_edge_detection): Remove unnecessary cast that
9868 gcc -Wbad-function-cast diagnoses.
9869 (gif_load): Fix pointer signedness.
9870 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9871 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9873 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9875 Improve quality of tests for time stamp overflow.
9876 For example, without this patch (encode-time 0 0 0 1 1
9877 1152921504606846976) returns the obviously-bogus value (-948597
9878 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9879 reports time overflow. See
9880 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9881 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9882 * editfns.c: Include limits.h and intprops.h.
9883 (TIME_T_MIN, TIME_T_MAX): New macros.
9884 (time_overflow): Move earlier, to before first use.
9885 (hi_time, lo_time): New functions, for an accurate test for
9887 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9888 (Fget_internal_run_time): Don't assume time_t fits in int.
9889 (make_time): Use list2 instead of Fcons twice.
9890 (Fdecode_time): More accurate test for out-of-range times.
9891 (check_tm_member): New function.
9892 (Fencode_time): Use it, to test for out-of-range times.
9893 (lisp_time_argument): Don't rely on undefined left-shift and
9894 right-shift behavior when checking for time stamp overflow.
9896 * editfns.c (time_overflow): New function, refactoring common code.
9897 (Fformat_time_string, Fdecode_time, Fencode_time):
9898 (Fcurrent_time_string): Use it.
9900 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9901 * dired.c (make_time): Move to ...
9902 * editfns.c (make_time): ... here.
9903 * systime.h: Note the move.
9905 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9907 * fringe.c (update_window_fringes): Remove unused variables.
9909 * unexmacosx.c (copy_data_segment): Also copy __got section.
9912 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9914 * termcap.c [MSDOS]: Include "msdos.h".
9915 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9916 Constify `char *' arguments and their references according to
9917 prototypes in tparam.h.
9919 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9921 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9922 Adapt all references accordingly.
9924 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9926 2011-03-11 Tom Tromey <tromey@redhat.com>
9928 * buffer.c (syms_of_buffer): Remove obsolete comment.
9930 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9932 * termhooks.h (encode_terminal_code): Declare prototype.
9934 * msdos.c (encode_terminal_code): Don't declare prototype.
9936 * term.c (encode_terminal_code): Now external again, used by
9937 w32console.c and msdos.c.
9939 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9940 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9942 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9944 Fix some minor problems found by GCC 4.5.2's static checks.
9946 * fringe.c (update_window_fringes): Mark locals as initialized
9948 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9950 * alloc.c (mark_fringe_data): Move decl from here ...
9951 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9952 to check its interface.
9953 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9955 * fontset.c (free_realized_fontset): Now static.
9956 (Fset_fontset_font): Rename local to avoid shadowing.
9957 (fontset_font): Mark local as initialized.
9958 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9960 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9962 * xselect.c (x_disown_buffer_selections): Remove; not used.
9963 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9964 (x_own_selection, Fx_disown_selection_internal): Rename locals
9966 (x_handle_dnd_message): Remove local to avoid shadowing.
9968 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9969 so that the caller can use some name other than gcpro1.
9970 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9971 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9972 (Fx_backspace_delete_keys_p):
9973 Use them to avoid shadowing, and rename vars to avoid shadowing.
9974 (x_decode_color, x_set_name, x_window): Now static.
9975 (Fx_create_frame): Add braces to silence GCC warning.
9976 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9977 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9978 Remove unused locals.
9979 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9980 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9981 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9984 * xterm.h (x_mouse_leave): New decl.
9986 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9987 Remove unused functions.
9988 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9989 (x_calc_absolute_position): Now static.
9990 (XTread_socket): Don't define label "out" unless it's used.
9991 Don't declare local "event" unless it's used.
9992 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9993 unless they are used.
9994 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9995 (x_fatal_error_signal): Remove; not used.
9996 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9997 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9998 (x_error_catcher, x_connection_closed, x_error_handler):
9999 (x_error_quitter, xembed_send_message, x_iconify_frame):
10000 (my_log_handler): Rename locals to avoid shadowing.
10001 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
10002 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
10004 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
10005 Rename or move locals to avoid shadowing.
10006 (tty_defined_color, merge_face_heights): Now static.
10007 (free_realized_faces_for_fontset): Remove; not used.
10008 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
10009 does not deduce is never used uninitialized.
10010 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
10011 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
10013 * terminal.c (store_terminal_param): Now static.
10015 * xmenu.c (menu_highlight_callback): Now static.
10016 (set_frame_menubar): Remove unused local.
10017 (xmenu_show): Rename parameter to avoid shadowing.
10018 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
10019 since they might point to immutable storage.
10020 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
10021 since it's unused otherwise.
10023 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
10024 Add a FIXME, since the code still doesn't look right. (Bug#8215)
10025 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
10026 avoids a gcc -Wuninitialized diagnostic.
10027 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
10028 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
10029 does not deduce are never used uninitialized.
10031 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
10033 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
10034 * window.c (window_loop, size_window):
10035 (run_window_configuration_change_hook, enlarge_window): Likewise.
10037 * window.c (display_buffer): Now static.
10038 (size_window): Mark variables that gcc -Wuninitialized
10039 does not deduce are never used uninitialized.
10040 * window.h (check_all_windows): New decl, to forestall
10041 gcc -Wmissing-prototypes diagnostic.
10042 * dispextern.h (bidi_dump_cached_states): Likewise.
10044 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
10046 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
10047 Include <limits.h>.
10048 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
10049 and to avoid gcc -Wuninitialized warning.
10050 (load_charset_map): Mark variables that gcc -Wuninitialized
10051 does not deduce are never used uninitialized.
10052 (load_charset): Abort instead of using uninitialized var (Bug#8229).
10054 * coding.c (coding_set_source, coding_set_destination):
10055 Use "else { /* comment */ }" rather than "else /* comment */;"
10056 for clarity, and to avoid gcc -Wempty-body warning.
10057 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
10058 a block, when the outer 'i' will do.
10059 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
10060 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
10061 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
10062 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
10063 (Fdecode_sjis_char, Fdefine_coding_system_internal):
10064 Rename locals to avoid shadowing.
10065 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
10066 * coding.c (emacs_mule_char, encode_invocation_designation):
10067 Now static, since they're not used elsewhere.
10068 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
10069 (decode_coding_object, encode_coding_object, detect_coding_system):
10070 (decode_coding_emacs_mule): Mark variables that gcc
10071 -Wuninitialized does not deduce are never used uninitialized.
10072 (detect_coding_iso_2022): Initialize a local variable that might
10073 be used uninitialized. Leave a FIXME because it's not clear that
10074 this initialization is needed. (Bug#8211)
10075 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
10076 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
10077 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
10078 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
10079 Remove unused macros.
10081 * category.c (hash_get_category_set): Remove unused local var.
10082 (copy_category_table): Now static, since it's not used elsewhere.
10083 * character.c (string_count_byte8): Likewise.
10085 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
10086 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
10088 * chartab.c (copy_sub_char_table): Now static, since it's not used
10090 (sub_char_table_ref_and_range, char_table_ref_and_range):
10091 Rename locals to avoid shadowing.
10092 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
10094 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
10095 (BIDI_BOB): Remove unused macro.
10097 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
10098 deduce are never used uninitialized.
10099 * term.c (encode_terminal_code): Likewise.
10101 * term.c (encode_terminal_code): Now static. Remove unused local.
10103 * tparam.h: New file.
10104 * term.c, tparam.h: Include it.
10105 * deps.mk (term.o, tparam.o): Depend on tparam.h.
10106 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
10107 Move these decls to tparam.h, and make them agree with what
10108 is actually in tparam.c. The previous trick of using incompatible
10109 decls in different modules does not conform to the C standard.
10110 All callers of tparam changed to use tparam's actual API.
10111 * tparam.c (tparam1, tparam, tgoto):
10112 Use const pointers where appropriate.
10114 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
10115 * cm.h (struct cm): Likewise.
10116 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
10117 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
10118 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
10119 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
10120 (turn_on_face, init_tty): Likewise.
10121 * termchar.h (struct tty_display_info): Likewise.
10123 * term.c (term_mouse_position): Rename local to avoid shadowing.
10125 * alloc.c (mark_ttys): Move decl from here ...
10126 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
10128 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
10130 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
10132 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
10134 * search.c (compile_pattern_1): Remove argument regp, unused since
10135 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
10136 (compile_pattern): Don't pass it.
10138 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
10140 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
10141 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
10143 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
10145 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
10147 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
10148 gdk_window_get_screen, gdk_window_get_geometry,
10149 gdk_x11_window_lookup_for_display and GDK_KEY_g.
10150 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
10151 (xg_get_pixbuf_from_pixmap): New function.
10152 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
10153 to Pixmap, take frame as parameter, remove GdkColormap parameter.
10154 Call xg_get_pixbuf_from_pixmap instead of
10155 gdk_pixbuf_get_from_drawable.
10156 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
10157 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
10158 (xg_check_special_colors): Use GtkStyleContext and its functions
10160 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
10161 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
10162 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
10163 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
10164 Call gtk_widget_get_preferred_size.
10165 (xg_frame_resized): gdk_window_get_geometry only takes 5
10167 (xg_win_to_widget, xg_event_is_for_menubar):
10168 Call gdk_x11_window_lookup_for_display.
10169 (xg_set_widget_bg): New function.
10170 (delete_cb): New function.
10171 (xg_create_frame_widgets): Connect delete-event to delete_cb.
10172 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
10173 (xg_set_background_color): Call xg_set_widget_bg.
10174 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
10175 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
10176 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
10177 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
10179 (update_frame_tool_bar): Call gtk_widget_hide.
10180 (xg_initialize): Use GDK_KEY_g.
10182 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
10184 (x_session_initialize): Call gdk_x11_set_sm_client_id.
10186 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
10187 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
10188 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
10190 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
10192 * w32xfns.c (select_palette): Check success of RealizePalette against
10193 GDI_ERROR, not zero.
10195 See ChangeLog.11 for earlier changes.
10197 ;; Local Variables:
10201 Copyright (C) 2011-2012 Free Software Foundation, Inc.
10203 This file is part of GNU Emacs.
10205 GNU Emacs is free software: you can redistribute it and/or modify
10206 it under the terms of the GNU General Public License as published by
10207 the Free Software Foundation, either version 3 of the License, or
10208 (at your option) any later version.
10210 GNU Emacs is distributed in the hope that it will be useful,
10211 but WITHOUT ANY WARRANTY; without even the implied warranty of
10212 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10213 GNU General Public License for more details.
10215 You should have received a copy of the GNU General Public License
10216 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.