1 2012-02-29 Eli Zaretskii <eliz@gnu.org>
3 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4 push_it before setting up the iterator for the first overlay
5 string, even if we have an empty string loaded.
6 (next_overlay_string): If there's an empty string on the iterator
7 stack, pop the stack. (Bug#10903)
9 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
11 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
12 Suggested by Stefan Monnier in
13 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
14 * alloc.c (widen_to_Lisp_Object): New static function.
15 (mark_memory): Also mark Lisp_Objects by fetching pointer words
16 and widening them to Lisp_Objects. This would work even if
17 USE_LSB_TAG is defined and wide integers are used, which might
18 happen in a future version of Emacs.
20 2012-02-25 Chong Yidong <cyd@gnu.org>
22 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
25 * xselect.c (Fx_selection_exists_p): Doc fix.
26 (x_clipboard_manager_save_all): Print an informative message
27 before saving to clipboard manager.
29 2012-02-24 Chong Yidong <cyd@gnu.org>
31 * keyboard.c (process_special_events): Handle all X selection
32 requests in kbd_buffer, not just the next one (Bug#8869).
34 2012-02-23 Chong Yidong <cyd@gnu.org>
36 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
37 call when setting menu-bar-lines and tool-bar-lines parameters.
38 (unwind_create_frame_1): New helper function.
40 * window.c (inhibit_window_configuration_change_hook): New var.
41 (run_window_configuration_change_hook): Obey it.
42 (syms_of_window): Initialize it.
44 2012-02-22 Chong Yidong <cyd@gnu.org>
46 * xterm.c (x_draw_image_relief): Add missing type check for
47 Vtool_bar_button_margin (Bug#10743).
49 2012-02-21 Chong Yidong <cyd@gnu.org>
51 * fileio.c (Vfile_name_handler_alist): Doc fix.
53 * buffer.c (Fget_file_buffer): Protect against invalid file
56 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
58 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
59 when computing $valmask.
61 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
62 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
63 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
64 It's useless in that case, and it can cause problems on hosts
65 that allocate halves of EMACS_INT values separately.
66 Reported by Dan Horák. Diagnosed by Andreas Schwab in
67 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
68 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
69 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
70 it avoids undefined behavior on hosts where shifting right by more
71 than the word width has undefined behavior.
73 2012-02-19 Chong Yidong <cyd@gnu.org>
75 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
76 (Funhandled_file_name_directory, Ffile_name_as_directory)
77 (Fdirectory_file_name, Fexpand_file_name)
78 (Fsubstitute_in_file_name): Protect against invalid file handler
79 return values (Bug#10845).
81 2012-02-18 Eli Zaretskii <eliz@gnu.org>
83 * .gdbinit (pitx): Fix incorrect references to fields of the
86 2012-02-17 Chong Yidong <cyd@gnu.org>
88 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
90 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
92 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
93 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
95 2012-02-15 Chong Yidong <cyd@gnu.org>
97 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
98 marked as special. Also, starting docstrings with * is obsolete.
100 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
102 * gnutls.c (emacs_gnutls_write): Fix last change.
104 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
106 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
109 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
111 * keymap.c (Fsingle_key_description): Handle char ranges.
113 2012-02-12 Chong Yidong <cyd@gnu.org>
115 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
116 as that creates a dangerous corner case.
118 * window.c (Fdelete_window_internal): Invalidate the mouse
119 highlight (Bug#9904).
121 2012-02-12 Glenn Morris <rgm@gnu.org>
123 * xselect.c (Fx_own_selection_internal)
124 (Fx_get_selection_internal, Fx_disown_selection_internal)
125 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
126 * nsselect.m (Fx_own_selection_internal)
127 (Fx_disown_selection_internal, Fx_selection_exists_p)
128 (Fx_selection_owner_p, Fx_get_selection_internal):
129 Sync docs and argument specs with the xselect.c versions.
131 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
133 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
135 2012-02-11 Eli Zaretskii <eliz@gnu.org>
137 * w32select.c (Fx_selection_exists_p): Sync doc string and
138 argument list with xselect.c. (Bug#10783)
140 * w16select.c (Fx_selection_exists_p): Sync doc string and
141 argument list with xselect.c. (Bug#10783)
143 2012-02-10 Glenn Morris <rgm@gnu.org>
145 * fns.c (Fsecure_hash): Doc fix.
147 2012-02-09 Kenichi Handa <handa@m17n.org>
149 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
151 2012-02-07 Chong Yidong <cyd@gnu.org>
153 * buffer.c (Fbuffer_local_variables)
154 (buffer_lisp_local_variables): Handle unbound vars correctly;
155 don't let Qunbound leak into Lisp.
157 2012-02-07 Glenn Morris <rgm@gnu.org>
159 * image.c (Fimagemagick_types): Doc fix.
161 * image.c (imagemagick-render-type): Change it from a lisp object
162 to an integer. Move the doc here from the lisp manual.
163 Treat all values not equal to 0 the same.
165 2012-02-06 Chong Yidong <cyd@gnu.org>
167 * doc.c (store_function_docstring): Avoid applying docstring of
168 alias to base function (Bug#2603).
170 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
172 * .gdbinit (pp1, pv1): Remove redundant defines.
175 2012-02-04 Chong Yidong <cyd@gnu.org>
177 * nsterm.m: Declare a global (Bug#10694).
179 2012-02-04 Eli Zaretskii <eliz@gnu.org>
181 * w32.c (get_emacs_configuration_options): Include
182 --enable-checking, if specified, in the return value.
184 2012-02-04 Martin Rudalics <rudalics@gmx.at>
186 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
187 after rounding frame sizes. (Bug#9723)
189 2012-02-04 Eli Zaretskii <eliz@gnu.org>
191 * keyboard.c (adjust_point_for_property): Don't position point
192 before BEGV. (Bug#10696)
194 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
196 Handle overflow when computing char display width (Bug#9496).
197 * character.c (char_width): Return EMACS_INT, not int.
198 (char_width, c_string_width): Check for overflow when
199 computing the width; this is possible now that individual
200 characters can have unbounded width. Problem introduced
201 by merge from Emacs 23 on 2012-01-19.
203 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
205 * dbusbind.c (Fdbus_register_method): Mention the return value
206 :ignore in the docstring.
208 2012-02-02 Glenn Morris <rgm@gnu.org>
210 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
212 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
213 Unconditionally set to t. (Bug#10673)
214 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
215 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
216 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
218 2012-02-02 Kenichi Handa <handa@m17n.org>
220 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
221 0, do not call append_composite_glyph.
223 2012-02-02 Kenichi Handa <handa@m17n.org>
225 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
227 (x_produce_glyphs): If the component of a composition is a null
228 string, set it->pixel_width to 1 to avoid zero-width glyph.
230 2012-02-01 Eli Zaretskii <eliz@gnu.org>
232 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
233 first 2 arguments are identical. This makes inserting large
234 output from a subprocess an order of magnitude faster on
235 MS-Windows, where all sbrk'ed memory is always contiguous.
237 2012-01-31 Glenn Morris <rgm@gnu.org>
239 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
240 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
241 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
243 2012-01-29 Glenn Morris <rgm@gnu.org>
245 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
247 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
249 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
251 2012-01-28 Chong Yidong <cyd@gnu.org>
253 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
255 2012-01-26 Chong Yidong <cyd@gnu.org>
257 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
259 * search.c (Fsearch_forward, Fsearch_backward): Document negative
260 repeat counts (Bug#10507).
262 2012-01-26 Glenn Morris <rgm@gnu.org>
264 * lread.c (syms_of_lread): Doc fix.
266 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
268 * coding.c (encode_designation_at_bol): Change return value to
271 2012-01-25 Chong Yidong <cyd@gnu.org>
273 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
275 2012-01-21 Chong Yidong <cyd@gnu.org>
277 * floatfns.c (Fcopysign): Make the second argument non-optional,
278 since nil is not allowed anyway.
280 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
282 * process.c (read_process_output): Use p instead of XPROCESS (proc).
283 (send_process): Likewise.
285 2012-01-19 Martin Rudalics <rudalics@gmx.at>
287 * window.c (save_window_save, Fcurrent_window_configuration)
288 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
291 2012-01-19 Kenichi Handa <handa@m17n.org>
293 * character.c (char_width): New function.
294 (Fchar_width, c_string_width, lisp_string_width):
295 Use char_width (Bug#9496).
297 2012-01-16 Martin Rudalics <rudalics@gmx.at>
299 * window.c (Vwindow_persistent_parameters): New variable.
300 (Fset_window_configuration, save_window_save): Handle persistent
303 2012-01-14 Eli Zaretskii <eliz@gnu.org>
305 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
306 thrashing the stack of the thread. (Bug#9087)
308 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
310 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
312 2012-01-11 Eli Zaretskii <eliz@gnu.org>
314 * xdisp.c (rows_from_pos_range): Handle the case where the
315 highlight ends on a newline. (Bug#10464)
316 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
317 he end column for display of highlight that ends on a newline
320 2012-01-11 Glenn Morris <rgm@gnu.org>
322 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
323 from load-path also when installation-directory is nil. (Bug#10208)
325 2012-01-10 Glenn Morris <rgm@gnu.org>
327 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
329 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
330 Update template values to be closer to their typical values these days.
332 2012-01-09 Eli Zaretskii <eliz@gnu.org>
334 * xdisp.c (rows_from_pos_range): Accept additional argument
335 DISP_STRING, and accept any glyph in a row whose object is that
336 string as eligible for mouse highlight. Fixes mouse highlight of
337 display strings from overlays. (Bug#10464)
339 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
341 emacs: fix an auto-save permissions race condition (Bug#10400)
342 * fileio.c (auto_saving_dir_umask): New static var.
343 (Fmake_directory_internal): Use it.
344 (do_auto_save_make_dir): Set it, instead of invoking chmod after
345 creating the directory. The old code temporarily assigns
346 too-generous permissions to the directory.
347 (do_auto_save_eh): Clear it.
348 (Fdo_auto_save): Catch all errors, not just file errors, so
349 that the var is always cleared.
351 2012-01-07 Eli Zaretskii <eliz@gnu.org>
353 * search.c (scan_buffer): Pass character positions to
354 know_region_cache, not byte positions. (Bug#6540)
356 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
358 * w32.c (sys_rename): Report EXDEV when rename of a directory
359 fails because the target is on another logical disk. (Bug#10284)
361 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
363 * xterm.c (x_embed_request_focus): New function.
365 * xterm.h: Add prototype.
367 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
369 2012-01-05 Glenn Morris <rgm@gnu.org>
371 * emacs.c (emacs_copyright): Update short copyright year to 2012.
373 2012-01-01 Eli Zaretskii <eliz@gnu.org>
375 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
376 Load gnutls_transport_set_lowat only if GnuTLS version is below
378 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
379 GnuTLS versions below 2.11.1.
381 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
383 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
384 to the doc string advising against its use for altering the way
385 windows are scrolled.
387 2011-12-28 Kenichi Handa <handa@m17n.org>
389 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
390 coding-system ASCII compatible only when it does not produce BOM
391 on encoding (Bug#10383).
393 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
395 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
397 (create_and_show_popup_menu): Always use menu_position_func for
400 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
402 * callint.c (Fcall_interactively): Don't truncate prompt string.
404 2011-12-23 Eli Zaretskii <eliz@gnu.org>
406 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
407 property that ends at ZV, so that the bidi iteration could be
408 resumed from there (after widening). (Bug#10360)
410 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
412 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
414 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
416 * nsterm.m (x_free_frame_resources):
417 Release f->output_data.ns->miniimage.
418 (ns_index_color): Fix indentation. Do not retain
419 color_table->colors[i].
421 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
424 * nsfns.m (x_set_background_color): Assign return value from
425 ns_index_color to face-background instead of NSColor*.
426 (ns_implicitly_set_icon_type): Fix indentation.
427 Change assignment in for loop to comparison.
429 * emacs.c (ns_pool): New variable.
430 (main): Assign ns_pool.
431 (Fkill_emacs): Call ns_release_autorelease_pool.
433 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
434 autorelease fdesc, release fdAttrs and tdict.
435 (ns_get_covering_families): Release charset.
436 (ns_findfonts): Release NSFontDescriptor created with new.
437 (ns_uni_to_glyphs): Fix indentation.
438 (setString): Release attrStr before assigning new value.
440 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
442 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
444 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
445 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
447 2011-12-18 David Reitter <reitter@cmu.edu>
449 * nsterm.m (ns_term_init): Subscribe for notifications
450 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
451 to method trackingNotification in EmacsMenu.
453 * nsmenu.m (trackingMenu): New variable.
454 (trackingNotification): New method (from Aquamacs).
455 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
456 from Aquamacs (Bug#7030).
458 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
460 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
461 (symbol_to_nsstring): Fix indentation.
462 (ns_symbol_to_pb): New function.
463 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
464 (Fns_rotate_cut_buffers_internal): Removed.
465 (Fns_store_selection_internal): Renamed from
466 Fns_store_cut_buffer_internal.
467 (ns_get_foreign_selection, Fx_own_selection_internal)
468 (Fx_disown_selection_internal, Fx_selection_exists_p)
469 (Fns_get_selection_internal, Fns_store_selection_internal):
470 Use ns_symbol_to_pb and check if return value is nil.
471 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
472 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
473 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
474 renamed to Sns_store_selection_internal.
475 (ns_handle_selection_request): Move code to Fx_own_selection_internal
476 and remove this function.
477 (ns_handle_selection_clear): Remove, never used.
478 (Fx_own_selection_internal): Move code from ns_handle_selection_request
481 2011-12-17 Ken Brown <kbrown@cornell.edu>
483 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
484 GID is unknown (Bug#10257).
486 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
488 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
489 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
490 which caused a build failure on GNU/Linux IA-64. This problem was
491 introduced by my 2011-10-07 patch.
493 2011-12-15 Juri Linkov <juri@jurta.org>
495 * image.c (imagemagick_error): New function. (Bug#10112)
496 (imagemagick_load_image): Comment out `MagickSetResolution' call.
497 Use `imagemagick_error' where ImageMagick functions return
499 (Fimagemagick_types): Add `Fnreverse' to return the list in the
502 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
504 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
505 fill background (Bug#8992).
507 2011-12-13 Martin Rudalics <rudalics@gmx.at>
509 * window.c (Vwindow_combination_resize)
510 (Vwindow_combination_limit): Use t instead of non-nil in
512 (Vrecenter_redisplay): Add first sentence of doc-string on
514 (Frecenter): Fix doc-string typo.
516 2011-12-11 Kenichi Handa <handa@m17n.org>
518 * coding.c (Funencodable_char_position): Pay attention to the
519 buffer text relocation (Bug#9389).
521 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
523 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
524 gtk_init (Bug#10100).
526 2011-12-10 Eli Zaretskii <eliz@gnu.org>
528 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
529 IT->string is nil. (Bug#10263)
531 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
533 * nsterm.h (x_free_frame_resources): Declare.
535 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
536 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
538 * nsterm.h (ns_get_defaults_value): Declare.
540 * nsterm.m (ns_default): Call ns_get_defaults_value.
542 2011-12-09 Eli Zaretskii <eliz@gnu.org>
544 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
547 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
549 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
550 that where the value of an _OBJC_* symbol points to is in the .bss
553 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
555 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
556 after the loop to call ccl_driver at least once (Bug#8619).
558 2011-12-08 Kenichi Handa <handa@m17n.org>
560 * ftfont.c (get_adstyle_property): Fix previous change
563 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
565 * w32.c (init_environment): If no_site_lisp, remove site-lisp
566 dirs from the default value of EMACSLOADPATH (bug#10208).
568 2011-12-07 Glenn Morris <rgm@gnu.org>
570 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
571 installation and source directories as well. (Bug#10208)
573 2011-12-06 Chong Yidong <cyd@gnu.org>
575 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
577 2011-12-06 Glenn Morris <rgm@gnu.org>
579 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
580 as an error, not just -1. (Bug#10217)
582 2011-12-05 Chong Yidong <cyd@gnu.org>
584 * keyboard.c (process_special_events): New function.
585 (swallow_events, Finput_pending_p): Use it (Bug#10195).
587 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
589 * coding.c (encode_designation_at_bol): Don't use uninitialized
590 local variable (Bug#9318).
592 2011-12-05 Kenichi Handa <handa@m17n.org>
594 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
595 return Qnil (Bug#8046, Bug#10193).
597 2011-12-05 Kenichi Handa <handa@m17n.org>
599 * coding.c (encode_designation_at_bol): New args charbuf_end and
600 dst. Return the number of produced bytes. Callers changed.
601 (coding_set_source): Return how many bytes coding->source was
603 (coding_set_destination): Return how many bytes
604 coding->destination was relocated.
605 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
606 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
608 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
610 * coding.c (CODING_CHAR_CHARSET_P): New macro.
611 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
614 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
616 The following changes are to fix Bug#9318.
618 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
619 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
620 (encode_coding_iso_2022, encode_coding_sjis)
621 (encode_coding_big5, encode_coding_charset): Use the above macros.
623 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
625 * lisp.h (process_quit_flag): Fix external declaration.
627 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
629 Don't macro-inline non-performance-critical code.
630 * eval.c (process_quit_flag): New function.
631 * lisp.h (QUIT): Use it.
633 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
635 * nsfns.m (get_geometry_from_preferences): New function.
636 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
638 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
640 * emacs.c (Qkill_emacs): Define.
641 (syms_of_emacs): Initialize it.
642 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
643 Qquit_flag to `kill-emacs' instead.
644 (quit_throw_to_read_char): Add parameter `from_signal'.
645 All callers changed. Call Fkill_emacs if requested and safe.
646 * lisp.h (QUIT): Call Fkill_emacs if requested.
648 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
650 * widget.c (update_wm_hints): Return if wmshell is null.
651 (widget_update_wm_size_hints): New function.
653 * widget.h (widget_update_wm_size_hints): Declare.
655 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
656 widget_update_wm_size_hints (Bug#10104).
658 2011-12-03 Eli Zaretskii <eliz@gnu.org>
660 * xdisp.c (handle_invisible_prop): If the invisible text ends just
661 before a newline, prepare the bidi iterator for consuming the
662 newline, and keep the current paragraph direction. (Bug#10183)
663 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
665 2011-12-02 Juri Linkov <juri@jurta.org>
667 * search.c (Fword_search_regexp): New Lisp function created from
668 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
669 (Fword_search_backward, Fword_search_forward)
670 (Fword_search_backward_lax, Fword_search_forward_lax):
671 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
672 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
674 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
676 * fileio.c (Finsert_file_contents): Move after-change-function call
677 to before the "handled:" label, since all "goto handled" appear in
678 cases where the *-change-functions have already been properly called
681 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
683 * keyboard.c (interrupt_signal): Don't call kill-emacs when
684 waiting for input. (Bug#10169)
686 2011-11-30 Eli Zaretskii <eliz@gnu.org>
688 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
689 verifies glyph row's hash code--we have just reallocated the
690 glyphs, so their contents can be complete garbage. (Bug#10164)
692 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
694 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
696 2011-11-30 Eli Zaretskii <eliz@gnu.org>
698 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
699 attributes are tested _before_ calling verify_row_hash, to protect
700 against GCC re-ordering of the tests. (Bug#10164)
702 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
704 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
706 * xterm.c (handle_one_xevent): Only set async_visible and friends
707 if net_wm_state_hidden_seen is non-zero (Bug#10002)
708 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
709 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
711 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
713 Remove GCPRO-related macros that exist only to avoid shadowing locals.
714 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
715 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
716 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
717 All uses changed to use GCPRO1 etc.
718 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
719 Revert to old implementation (i.e., before 2011-03-11).
721 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
723 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
724 of scroll runs so as to avoid assigning disabled bogus rows and
725 unnecessary graphics copy operations.
727 2011-11-27 Eli Zaretskii <eliz@gnu.org>
729 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
730 (snprintf) [_MSC_VER]: Redirect to _snprintf.
731 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
732 (malloc, free, realloc, calloc): Redirect to e_* only when
735 * lisp.h (GCTYPEBITS): Move before first use.
736 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
737 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
738 this macro definition.
740 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
743 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
745 * gtkutil.c (xg_create_frame_widgets):
746 Call gtk_window_set_has_resize_grip (FALSE) if that function is
747 present with Gtk+ 2.0.
749 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
751 * fileio.c (Finsert_file_contents): Undo previous change; see
752 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
754 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
756 Rename locals to avoid shadowing.
757 * fileio.c (Finsert_file_contents):
758 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
759 * process.c (wait_reading_process_output):
760 Rename inner 'proc' to 'p' to avoid shadowing.
761 Indent for consistency with usual Emacs style.
763 2011-11-25 Eli Zaretskii <eliz@gnu.org>
765 * xdisp.c (redisplay_window): If cursor row is not fully visible
766 after recentering, and scroll-conservatively is set to a large
767 number, scroll window by a few more lines to make the cursor fully
768 visible and out of scroll-margin. (Bug#10105)
769 (start_display): Don't move to the next line if the display should
770 start at a newline that is part of a display vector or an overlay
773 2011-11-24 Juri Linkov <juri@jurta.org>
775 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
776 after the `MagickPingImage' call. (Bug#10112)
778 2011-11-23 Chong Yidong <cyd@gnu.org>
780 * window.c (Fcoordinates_in_window_p): Accept only live windows.
782 2011-11-23 Martin Rudalics <rudalics@gmx.at>
784 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
785 making another buffer current. (Bug#10114)
787 2011-11-23 Glenn Morris <rgm@gnu.org>
789 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
791 2011-11-23 Chong Yidong <cyd@gnu.org>
793 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
796 2011-11-22 Eli Zaretskii <eliz@gnu.org>
798 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
799 and header-lines, as they don't have one computed for them.
802 * .gdbinit (prow): Make displayed values more self-explaining.
805 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
807 * process.c (wait_reading_process_output): Fix asynchrounous
808 GnuTLS socket handling on some versions of the GnuTLS library.
809 (wait_reading_process_output): Add comment and URL.
811 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
813 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
815 2011-11-21 Chong Yidong <cyd@gnu.org>
817 * window.c (Fnext_window, Fprevious_window): Doc fix.
819 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
821 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
823 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
825 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
827 2011-11-20 Martin Rudalics <rudalics@gmx.at>
829 * window.c (Fset_window_combination_limit): Rename argument
831 (Vwindow_combination_limit): Remove "status" from doc-string.
833 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
835 * m/ibms390.h: Remove.
836 * m/ibms390x.h: Don't include "ibms390.h".
838 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
840 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
841 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
843 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
845 * casetab.c (Fset_case_table):
846 * charset.c (Fcharset_after): Fix typos.
848 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
850 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
851 Otherwise, valgrind does not work on some platforms.
852 Problem reported by Andreas Schwab in
853 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
854 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
855 is set, removing the need for VIRT_ADDRESS_VARIES.
856 (PURE_P): Use a more-efficient implementation that needs just one
857 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
858 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
859 to 4 (xorl, subq, cmpq, setbe).
860 * alloc.c (pure): Always extern now, since that's the
861 VIRT_ADDR_VARIES behavior.
862 (PURE_POINTER_P): Use a single comparison, not two, for
863 consistency with the new puresize.h.
864 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
865 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
866 Remove VIRT_ADDR_VARIES no longer needed.
868 2011-11-19 Eli Zaretskii <eliz@gnu.org>
870 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
871 (erase_phys_cursor, update_window_cursor, show_mouse_face)
872 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
873 behave as if the cursor position were at the window margin.
875 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
876 and the cursor position is out of bounds, behave as if the cursor
877 position were at the window margin. (Bug#10075)
879 2011-11-18 Chong Yidong <cyd@gnu.org>
881 * window.c (Fwindow_combination_limit): Make first argument
882 non-optional, since it is meaningless for live windows like the
885 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
887 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
889 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
891 * intervals.c: Fix grafting over the whole buffer (bug#10071).
892 (graft_intervals_into_buffer): Simplify.
894 2011-11-18 Eli Zaretskii <eliz@gnu.org>
896 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
897 hash values of the two rows.
898 (copy_row_except_pointers): Preserve the used[] arrays and the
899 hash values of the two rows. (Bug#10035)
900 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
902 * xdisp.c (row_hash): New function, body extracted from
903 compute_line_metrics.
904 (compute_line_metrics): Call row_hash, instead of computing the
907 * dispnew.c (verify_row_hash): Call row_hash for computing the
908 hash code of a row, instead of duplicating code from xdisp.c.
910 * dispextern.h (row_hash): Add prototype.
912 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
914 * frame.c (delete_frame): Don't delete the terminal when the last
915 X frame is closed if emacs is built with GTK toolkit.
917 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
919 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
921 2011-11-17 Martin Rudalics <rudalics@gmx.at>
923 * window.c (Vwindow_splits): Rename to
924 Vwindow_combination_resize. Suggested by Juri Linkov.
925 (Fsplit_window_internal): Use Vwindow_combination_resize instead
928 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
930 * nsfns.m (Fns_font_name):
931 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
933 2011-11-16 Martin Rudalics <rudalics@gmx.at>
935 * window.h (window): Rename slot "nest" to "combination_limit".
936 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
937 (Fset_window_nest): Rename to Fset_window_combination_limit.
938 (Vwindow_nest): Rename to Vwindow_combination_limit.
939 (recombine_windows, make_parent_window, make_window)
940 (Fsplit_window_internal, saved_window)
941 (Fset_window_configuration, save_window_save): Rename all
942 occurrences of window_nest to window_combination_limit.
944 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
946 * image.c (imagemagick_load_image): Fix typo.
948 2011-11-14 Eli Zaretskii <eliz@gnu.org>
950 * xdisp.c (display_line): Move the call to
951 highlight_trailing_whitespace before the call to
952 compute_line_metrics, since the latter needs to see the final
953 faces of all the glyphs to compute ROW's hash value.
954 Fixes assertion violations in row_equal_p. (Bug#10035)
956 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
958 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
959 just return (bug#10044).
961 2011-11-12 Eli Zaretskii <eliz@gnu.org>
963 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
964 with user-defined heap size. Bump the default size of the temacs
965 heap to 27MB, to avoid memory warning when running temacs.
966 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
968 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
969 current_matrix and desired_matrix. (Bug#9990)
970 (verify_row_hash) [XASSERTS]: New function.
971 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
972 that the hash value of glyph rows is correct.
974 2011-11-12 Martin Rudalics <rudalics@gmx.at>
976 * window.h (window): Remove splits slot.
977 * window.c (Fwindow_splits, Fset_window_splits): Remove.
978 (Fdelete_other_windows_internal, make_parent_window)
979 (make_window, Fsplit_window_internal, Fdelete_window_internal)
980 (Fset_window_configuration, save_window_save): Don't deal with
981 split status of windows.
982 (saved_window): Remove splits slot.
983 (Vwindow_splits): Rewrite doc-string.
985 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
987 * xfns.c (unwind_create_frame):
988 * nsfns.m (unwind_create_frame):
989 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
990 Vframe_list (Bug#9999).
992 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
994 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
996 2011-11-11 Kenichi Handa <handa@m17n.org>
998 * callproc.c (Fcall_process): Set the member dst_multibyte of
1001 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1003 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1004 avoid a crash (bug#9496).
1006 2011-11-09 Chong Yidong <cyd@gnu.org>
1008 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1009 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1011 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1013 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1015 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1017 Avoid some portability problems by eschewing 'extern inline' functions.
1018 The trivial performance wins aren't worth the portability hassles; see
1019 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1021 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1022 (window_box_width, window_box_left, window_box_left_offset)
1023 (window_box_right, window_box_right_offset): Undo previous change,
1024 by removing the "extern"s.
1025 * intervals.c (adjust_intervals_for_insertion)
1026 (adjust_intervals_for_deletion): Undo previous change,
1027 making these static again.
1028 (offset_intervals, temp_set_point_both, temp_set_point)
1029 (copy_intervals_to_string): No longer inline.
1030 * xdisp.c (window_text_bottom_y, window_box_width)
1031 (window_box_height, window_box_left_offset)
1032 (window_box_right_offset, window_box_left, window_box_right)
1033 (window_box): No longer inline.
1035 2011-11-08 Chong Yidong <cyd@gnu.org>
1037 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1038 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1039 Signal an error if not a live window.
1040 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1041 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1043 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1045 * lisp.h (syms_of_abbrev): Remove declaration.
1046 Reported by CHENG Gao <chenggao@royau.me>.
1048 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1050 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1051 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1052 of temacs in GUI mode.
1054 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1056 * window.h: Declare delete_all_child_windows instead of
1057 delete_all_subwindows.
1058 * window.c (Fwindow_nest, Fset_window_nest)
1059 (Fset_window_new_total, Fset_window_new_normal)
1060 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1061 (delete_all_subwindows): Rename to delete_all_child_windows.
1062 (Fdelete_other_windows_internal, Fset_window_configuration):
1063 Call delete_all_child_windows instead of delete_all_subwindows.
1064 * frame.c (delete_frame): Call delete_all_child_windows instead
1065 of delete_all_subwindows.
1067 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1069 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1070 This is also needed for porting to any host where GC_MARK_STACK is
1071 not GC_MAKE_GCPROS_NOOPS.
1072 (which_symbols): Use it.
1074 2011-11-07 Kenichi Handa <handa@m17n.org>
1076 * coding.c (coding_set_destination): Check coding->src_pos only
1077 when coding->src_object is a buffer (bug#9910).
1079 * process.c (send_process): Set the member src_multibyte of coding
1080 to 0 (bug#9911) when sending a unibyte text.
1082 * callproc.c (Fcall_process): Set the member src_multibyte of
1083 process_coding to 0 (bug#9912).
1085 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1087 * xmenu.c (cleanup_widget_value_tree): New function.
1088 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1089 calling free_menubar_widget_value_tree directly (Bug#9830).
1091 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1093 Fix some portability problems with 'inline'.
1094 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1095 (window_box_width, window_box_left, window_box_left_offset)
1096 (window_box_right, window_box_right_offset): Declare extern.
1097 Otherwise, these inline functions do not conform to C99 and
1098 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1099 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1100 * intervals.c (adjust_intervals_for_insertion)
1101 (adjust_intervals_for_deletion): Now extern, because otherwise the
1102 extern inline functions 'offset_intervals' couldn't refer to it.
1103 (static_offset_intervals): Remove.
1104 (offset_intervals): Rewrite using the old contents of
1105 static_offset_intervals. The old version didn't conform to C99
1106 because an extern inline function contained a reference to an
1107 identifier with static linkage.
1109 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1111 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1114 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1116 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1117 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1118 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1119 return Qleft_to_right.
1121 2011-11-06 Chong Yidong <cyd@gnu.org>
1123 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1124 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1125 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1126 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1127 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1128 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1129 (Fwindow_vscroll): Doc fix.
1130 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1131 argument, since it makes no sense to pass a live window and for
1132 consistency with window-child.
1134 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1136 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1139 2011-11-05 Jason Rumney <jasonr@gnu.org>
1141 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1142 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1144 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1145 bitwise arithmetic preventing use of unicode-sip and non-truetype
1148 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1150 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1153 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1154 initialization code to keep similarity to xfns.c after changes
1157 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1159 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1160 (unwind_create_frame): New function (Bug#9943).
1161 (Fx_create_frame): Restructure code to be more similar to the one in
1162 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1163 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1164 Move terminal->reference_count++ just before making the frame official
1167 * nsterm.m (x_free_frame_resources): New function.
1168 (x_destroy_window): Move code to x_free_frame_resources.
1170 * xfns.c (unwind_create_frame): Fix comment.
1171 (Fx_create_frame, x_create_tip_frame):
1172 Move terminal->reference_count++ just before making the frame
1173 official. Move initialization of image_cache_refcount and
1174 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1176 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1178 Support MSVC build with newer versions of Visual Studio.
1179 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1180 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1183 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1184 which are not supported by MSVC.
1185 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1186 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1188 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1190 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1192 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1194 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1196 Support MSVC build with newer versions of Visual Studio.
1197 * w32.c: Don't include w32api.h for MSVC.
1198 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1200 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1201 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1202 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1203 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1205 (alloca) [_MSC_VER]: Define to _alloca.
1207 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1209 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1211 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1213 * xdisp.c (note_mouse_highlight): If either of
1214 previous/next-single-property-change returns nil, treat that as
1215 the beginning or the end of the buffer. (Bug#9955)
1217 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1219 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1220 label is not null (Bug#9951).
1221 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1224 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1226 * window.c (Fwindow_body_size): Mention in the doc string that the
1227 return value is in frame's canonical units. (Bug#9949)
1229 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1231 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1233 * w32fns.c (unwind_create_frame): If needed, free the glyph
1234 matrices of the partially constructed frame. (Bug#9943)
1235 * xfns.c (unwind_create_frame): Likewise.
1237 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1239 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1240 Don't stop backward scan on the continuation glyph, even though
1241 its CHARPOS is positive.
1242 (mouse_face_from_buffer_pos, note_mouse_highlight):
1243 Rename cover_string to disp_string.
1245 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1247 * window.c (temp_output_buffer_show): Don't use
1248 Vtemp_buffer_show_specifiers.
1249 (Vtemp_buffer_show_specifiers): Remove unused variable.
1251 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1253 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1254 past the beginning of the current glyph matrix.
1256 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1258 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1259 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1260 HAVE_GTK3 (Bug#9869).
1262 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1263 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1265 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1267 * xterm.c: Declare x_handle_net_wm_state to return int.
1268 (handle_one_xevent): Check if we are iconified but don't have
1269 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1270 (get_current_wm_state): Return non-zero if not hidden,
1271 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1272 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1273 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1274 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1276 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1278 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1279 so that this new function doesn't get optimized away by a
1280 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1282 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1284 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1286 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1288 Fix the `xbytecode' command.
1289 * .gdbinit (xprintbytestr): New command.
1290 (xwhichsymbols): Rename from `which'; all callers changed.
1291 (xbytecode): Print the byte-code string as well.
1293 2011-10-29 Kim Storm <storm@cua.dk>
1295 * alloc.c (which_symbols): New function.
1297 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1299 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1302 2011-10-29 Glenn Morris <rgm@gnu.org>
1304 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1305 Not clear what it was for, and it causes various bugs. (Bug#9839)
1307 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1309 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1310 possible random value that matches one of those tested as
1311 condition to clear the mouse face.
1313 2011-10-28 Chong Yidong <cyd@gnu.org>
1315 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1317 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1319 * window.c (make_window): Initialize phys_cursor_on_p.
1321 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1323 * lisp.h (struct Lisp_Symbol): Update comments.
1325 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1327 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1329 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1331 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1332 <oslsachem@gmail.com> for helping to debug this.
1334 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1335 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1336 (g_b_init_get_glyph_outline_w): New static variables.
1337 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1338 (GetGlyphOutlineW_Proc): New typedefs.
1339 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1340 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1342 (w32font_open_internal, compute_metrics):
1343 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1344 instead of calling the "wide" APIs directly.
1346 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1348 * w32.h (syms_of_w32font): Add prototype.
1350 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1352 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1353 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1354 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1355 (Fmove_to_window_line): Doc fix.
1357 2011-10-27 Chong Yidong <cyd@gnu.org>
1359 * process.c (make_process): Set gnutls_state to NULL.
1361 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1362 non-NULL, regardless of GNUTLS_INITSTAGE.
1363 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1364 an error. Set process slots as soon as we allocate them.
1366 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1368 2011-10-27 Chong Yidong <cyd@gnu.org>
1370 * gnutls.c (emacs_gnutls_deinit): New function.
1371 Deallocate credentials structures as well as calling gnutls_deinit.
1372 (Fgnutls_deinit, Fgnutls_boot): Use it.
1374 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1375 (deactivate_process): Call emacs_gnutls_deinit.
1377 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1379 * image.c (x_create_x_image_and_pixmap):
1380 * w32.c (sys_rename, w32_delayed_load):
1381 * w32font.c (fill_in_logfont):
1382 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1384 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1386 * w32fns.c (w32_default_color_map): New function,
1387 extracted from Fw32_default_color_map.
1388 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1390 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1392 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1394 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1396 * keyboard.c (test_undefined): New function (bug#9751).
1397 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1399 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1401 * sysdep.c (init_sys_modes): Fix the check for the controlling
1402 terminal (Bug#6649).
1404 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1406 * dispextern.h (struct bidi_it): New member next_en_type.
1408 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1409 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1410 current character, check also for next_en_type being WEAK_EN.
1411 (bidi_resolve_weak): Don't enter the expensive loop if the current
1412 position is before next_en_pos. Record the bidi type of the first
1413 non-ET, non-BN character we find, in addition to its position.
1414 (bidi_level_of_next_char): Invalidate next_en_type when
1415 next_en_pos is over-stepped.
1417 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1419 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1420 * editfns.c: Rewrite current-time-zone so that it invokes
1421 the equivalent of (format-time-string "%Z") to get the time zone name.
1422 This fixes a bug when the time zone name contains characters that
1423 need converting from the system time locale to Emacs internal format.
1424 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1425 that patch fixed format-time-string to do the conversion, but
1426 I forgot to fix current-time-zone.
1427 (format_time_string): New function, containing most of
1428 what Fformat_time_string used to contain.
1429 (Fformat_time_string): Rewrite in terms of format_time_string.
1430 This doesn't change this function's behavior.
1431 (current-time-zone): Rewrite to use format_time_string.
1432 This fixes the bug reported by Michael Schierl in
1433 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1434 Jason Rumney's 2007-06-07 change worked around this bug, but
1436 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1438 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1440 * xdisp.c (start_display): If the character at POS is displayed
1441 via a display vector, reset IT->current.dpvec_index to zero.
1442 (try_window_reusing_current_matrix): If a line ends in a display
1443 vector or the next line starts in a display vector, continue
1444 redrawing the window even though the character position of
1445 start_row was reached.
1448 2011-10-18 Chong Yidong <cyd@gnu.org>
1450 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1451 with nobreak-char-display too.
1453 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1455 Fix part 3 of bug#9771.
1456 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1457 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1458 non-neutral characters if the current character is a paragraph
1459 separator (a.k.a. Newline). This avoids running the same
1460 expensive loop twice, once when we consume the preceding newline
1461 and the other time when the line actually needs to be displayed.
1462 Avoid the loop when we see neutrals on the base embedding level
1463 following a character whose directionality is the same as the
1464 paragraph's. This avoids running the expensive loop when a line
1465 ends in a long sequence of neutrals, like control characters.
1466 Add assertion against STRONG_AL type. Slightly rearrange code
1467 that determines the type of a neutral given the first non-neutral
1469 (bidi_level_of_next_char): Set next_en_pos to zero when
1470 invalidating its info.
1472 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1474 * xdisp.c (push_display_prop): Determine whether to record string
1475 or buffer position by IT->string, not by IT->method. Allow
1476 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1477 (move_it_vertically_backward): Don't look for character position
1478 immediately after the newline when in a continuation line.
1481 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1483 * window.c (coordinates_in_window): Rewrite and delabelize
1484 vertical border check. (Bug#5357) (Bug#9618)
1486 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1488 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1489 errors in XSetWindowBorder (bug#9310).
1491 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1493 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1494 avoid crash when xmalloc overrun checking is enabled.
1496 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1498 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1499 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1500 cursor motion with <left> and <right> arrow keys.
1502 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1503 some callers set that themselves.
1505 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1507 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1508 display string and the previous row comes from the same string and
1509 is empty. (Bug#9739) (Bug#9738)
1511 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1513 * doc.c (get_doc_string): Encode file name (bug#9735).
1515 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1517 * bidi.c (bidi_level_of_next_char):
1518 * xdisp.c (get_visually_first_element): Remove old incorrect
1519 comments regarding the Unicode Line Separator character.
1521 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1523 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1525 * alloc.c (Fgc_status): Do not access beyond zombies array
1526 boundary if nzombies > MAX_ZOMBIES.
1527 * alloc.c (dump_zombies): Add missing format specifier.
1529 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1531 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1532 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1534 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1535 Some packages use them to denote characters with modifiers.
1537 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1539 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1540 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1541 matching a pp-number. Rename parameter var to var1.
1543 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1545 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1547 2011-10-08 Glenn Morris <rgm@gnu.org>
1549 * callint.c (Fcall_interactively): Give a more explicit error for the
1550 'c' case with a non-character input. (Bug#8479)
1552 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1554 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1556 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1557 lines that are hscrolled on the left.
1559 * dispnew.c (buffer_posn_from_coords): Account for a possible
1560 presence of header-line. (Bug#4426)
1562 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1564 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1565 Don't advertise functionality which we discourage or doesn't work.
1567 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1569 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1570 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1571 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1572 this makes Emacs dump core during garbage collection on rare
1573 occasions. sizeof is obviously inferior to offsetof here, so
1574 stick with offsetof.
1575 (GC_POINTER_ALIGNMENT): New macro.
1576 (mark_memory): Omit 3rd (offset) arg; caller changed.
1577 Don't assume EMACS_INT alignment is the same as pointer alignment.
1579 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1581 * keyboard.c (read_key_sequence_remapped): New var.
1582 (read_key_sequence): Compute remapping in the right buffer.
1583 (command_loop_1): Use read_key_sequence's remapping directly.
1585 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1587 * dired.c (file_name_completion): Don't expand file name.
1588 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1589 before checking file name handler.
1591 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1592 they've been requested explicitly (bug#9591).
1594 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1596 * keymap.c (Fsingle_key_description): Use make_specified_string
1597 instead of build_string to build string from push_key_description.
1600 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1602 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1603 This fixes a Y2038 bug on 64-bit hosts.
1604 * buffer.c (reset_buffer):
1605 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1606 (Fclear_buffer_auto_save_failure):
1607 Use 0, not -1, to represent an unset failure time, since time_t
1608 might not be signed.
1610 Remove dependency on glibc malloc internals.
1611 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1612 Move back here from lisp.h, but with their new implementations.
1613 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1614 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1615 * charset.c (charset_table_init): New static var.
1616 (syms_of_charset): Use it instead of xmalloc. This removes a
1617 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1618 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1619 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1620 Move back to alloc.c.
1621 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1622 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1624 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1626 * nsterm.m (windowDidResize): Call x_set_window_size only when
1627 ns_in_resize is true. Otherwise set pixelwidth/height and
1628 call change_frame_size (Bug#9628).
1630 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1632 Port --enable-checking=all to Fedora 14 x86-64.
1633 * charset.c (syms_of_charset): Also account for glibc malloc's
1634 internal overhead when calculating the initial malloc maximum.
1636 Port --enable-checking=all to Fedora 14 x86.
1637 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1639 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1640 (overrun_check_realloc, overrun_check_free):
1641 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1642 That way, xmalloc returns a properly-aligned pointer even if
1643 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1644 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1645 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1646 into account when calculating the initial malloc maximum.
1647 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1648 Move here from alloc.c, so that charset.c can use it too.
1649 Properly align; the old code wasn't right for common 32-bit hosts
1650 when configured with --enable-checking=all.
1651 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1652 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1654 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1656 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1659 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1661 * xdisp.c (compute_display_string_end): If there's no display
1662 string at CHARPOS, return -1.
1664 * bidi.c (bidi_fetch_char): When compute_display_string_end
1665 returns a negative value, treat the character as a normal
1666 character not covered by a display string. (Bug#9624)
1668 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1670 * lread.c (Fread_from_string): Fix typo in docstring.
1672 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1674 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1675 newline, reseat the iterator instead of bidi-iterating there one
1676 character at a time. (Bug#9610)
1677 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1678 TO_CHARPOS if the bidi iterator is at base embedding level.
1680 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1682 * lread.c (readevalloop): Use correct code for NBSP.
1683 (read1): Likewise. (Bug#9608)
1685 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1687 * dbusbind.c (Fdbus_register_signal): When service is not
1688 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1690 2011-09-25 Glenn Morris <rgm@gnu.org>
1692 * buffer.c (truncate-lines): Doc fix.
1694 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1696 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1697 (Fset_window_next_buffers): Doc fix.
1699 2011-09-24 Glenn Morris <rgm@gnu.org>
1701 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1703 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1705 Fix minor problems found by static checking.
1706 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1707 * indent.c (Fvertical_motion): Fix == vs = typo.
1709 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1711 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1712 Default value is now t. Doc fix.
1714 * indent.c (Fvertical_motion): Compute and apply the overshoot
1715 logic when moving up, not only when moving down. Fix the
1716 confusing name and values of the it_overshoot_expected variable;
1717 logic changes accordingly. (Bug#9254) (Bug#9549)
1719 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1720 CHARPOS is covered by a display string which includes newlines.
1721 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1722 is covered by a display string with embedded newlines.
1724 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1726 * dbusbind.c (Fdbus_register_signal): Add match rule to
1727 Vdbus_registered_objects_table. (Bug#9581)
1728 (Fdbus_register_method, Vdbus_registered_objects_table):
1731 2011-09-24 Jim Meyering <meyering@redhat.com>
1733 do not ignore write error for any output size
1734 The previous change was incomplete.
1735 While it makes emacs --batch detect the vast majority of stdout
1736 write failures, errors were still ignored whenever the output size is
1737 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1738 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1739 && echo FAIL: ignored write error
1740 FAIL: ignored write error
1741 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1742 && echo FAIL: ignored write error
1743 FAIL: ignored write error
1744 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1746 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1748 * emacs.c (Fkill_emacs): In noninteractive mode exit
1749 non-successfully if a write error occurred on stdout. (Bug#9574)
1751 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1753 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1756 * dispextern.h (struct it): Update the comment documenting what
1759 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1761 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1762 a display string, extend search for cursor position to end of row.
1763 (find_row_edges): If the row ends in a newline from a display
1764 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1765 Handle the case of a display string with multiple newlines.
1766 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1767 non-empty line. Fixes confusing cursor motion with arrow keys at
1768 the beginning of a line that starts with whitespace.
1770 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1772 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1775 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1777 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1780 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1782 * xdisp.c (display_line): Record maximum and minimum buffer
1783 positions even if no glyphs were produced (e.g., by a zero-width
1784 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1785 buffer positions that will be removed from the glyph row because
1787 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1788 column is beyond frame width: don't subtract 1 "pixel" when
1789 computing width of the stretch.
1790 (reseat_at_next_visible_line_start): Undo the change made on
1791 2011-09-17 that saved paragraph information and restored it after
1792 the call to `reseat'. (Bug#9545)
1794 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1796 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1797 and turn window cursor on if cleared (Bug#9415).
1799 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1801 * search.c (boyer_moore): Take unibyte characters from pattern
1802 literally. (Bug#9458)
1804 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1806 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1808 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1810 Fix minor problem found by static checking.
1811 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1812 initialized, to pacify gcc -Wuninitialized.
1814 * fileio.c: Report proper errno when syscall falls.
1815 (Finsert_file_contents): Save and restore errno,
1816 so that report_file_error outputs the correct diagnostic.
1817 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1819 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1821 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1823 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1825 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1826 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1828 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1830 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1831 about the current paragraph and restore it after the call to reseat.
1833 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1834 (bidi_find_paragraph_start): Search back for paragraph beginning
1835 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1836 (bidi_move_to_visually_next): Only trigger paragraph-related
1837 computations when the last character is a newline or at EOB, not
1838 just any NEUTRAL_B. (Bug#9470)
1840 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1841 truncated lines if point is covered by a display string. (Bug#9524)
1843 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1845 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1846 (cons_to_x_long): New function.
1847 (lisp_data_to_selection_data): Use it. Correct the test for
1848 short-versus-long data; it was negated. Break out of vector
1849 loop, for efficiency, when a long datum is discovered.
1851 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1853 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1855 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1857 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1858 GCC PR/17406) by declaring this function with external scope.
1860 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1862 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1863 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1865 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1867 * editfns.c (Fformat): Correctly handle text properties on "%%".
1869 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1871 * xterm.c (x_draw_composite_glyph_string_foreground):
1872 * w32term.c (x_draw_composite_glyph_string_foreground):
1873 * term.c (encode_terminal_code):
1874 * composite.c (composition_update_it, get_composition_id):
1875 * xdisp.c (get_next_display_element)
1876 (fill_composite_glyph_string): Add comments about special meaning
1877 of TAB characters in a composition.
1879 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1881 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1882 This occurs when processing a multibyte format.
1883 Problem reported by Wolfgang Jenker.
1885 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1887 * xdisp.c (try_cursor_movement): Only check for exact match if
1888 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1890 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1892 Remove unused external symbols.
1893 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1894 * xdisp.c (calc_pixel_width_or_height): Now static.
1895 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1896 * indent.c (check_display_width):
1897 * w32term.c: Fix comment to match code.
1898 * xterm.c, xterm.h (x_catching_errors): Remove.
1900 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1902 * xselect.c: Use signed conversions more consistently (Bug#9498).
1903 (selection_data_to_lisp_data): Assume incoming selection data are
1904 signed integers, not unsigned. This is to be consistent with
1905 outgoing selection data, which was modified to use signed integers
1906 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1907 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1908 expects long, not unsigned long.
1910 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1912 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1913 computation of loop end. Reported by Johan Bockgård
1916 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1918 * frame.c (Fother_visible_frames_p): Function deleted.
1920 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1922 * indent.c (compute_motion): Process display vector front to back
1923 rather than the other way around. (Bug#2496)
1925 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1927 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1929 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1931 * minibuf.c (Fread_from_minibuffer): Doc fix.
1933 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1935 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1936 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1938 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1940 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1941 value for non-existent files.
1943 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1945 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1946 set its "size" to -1. This will set the modtime_size field of
1947 the corresponding buffer to -1, which is what
1948 verify-visited-file-modtime expects for files that do not exist.
1951 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1953 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1955 * lisp.h: ... from here. push_key_description is no longer
1956 defined in keyboard.c, so its declaration should not be in
1957 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1958 logically belongs with push_key_description.
1960 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1962 * buffer.h: Include <sys/types.h> instead of <time.h>.
1963 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1964 Problem reported by Herbert J. Skuhra.
1966 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1968 * xml.c (parse_region): Make the parsing work for
1969 non-comment-starting XML files again (bug#9144).
1971 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1973 * image.c (gif_load): Fix calculation of bottom and right corner.
1976 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1978 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1979 redisplay in small windows.
1981 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1983 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1985 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1987 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1988 Operate on live windows only.
1990 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1992 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1994 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1996 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1997 only under bidi iteration.
1999 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2001 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2003 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2005 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2006 Without this fix, the command to link temacs failed due to an
2007 undefined symbol __builtin_isnan. This is because
2008 /usr/include/iso/math_c99.h #defines isnan(x) to
2009 __builtin_isnan(x), but the bundled gcc, which identifies itself
2010 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2012 * floatfns.c (isnan): #undef, and then #define to a clone of
2014 (Fisnan): Always define, since it's always available now.
2015 (syms_of_floatfns): Always define isnan at the Lisp level.
2017 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2019 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2021 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2023 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2024 The previous code assumed that file offsets (off_t values) fit in
2025 EMACS_INT variables, which is not true on typical 32-bit hosts.
2026 The code messed up by falsely reporting buffer overflow in cases
2027 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2028 when "big" contains more than 2**29 bytes, even though this
2029 inserts just one byte and does not overflow the buffer.
2030 (Finsert_file_contents): Store file offsets as off_t
2031 values, not as EMACS_INT values. Check for overflow when
2032 converting between EMACS_INT and off_t. When checking for
2033 buffer overflow or for overlap, take the offsets into account.
2034 Don't use EMACS_INT for small values where int suffices.
2035 When checking for overlap, fix a typo: ZV was used where
2036 ZV_BYTE was intended.
2037 (Fwrite_region): Don't assume off_t fits into 'long'.
2038 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2040 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2042 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2044 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2046 sprintf-related integer and memory overflow issues (Bug#9412).
2048 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2049 (esprintf, exprintf, evxprintf): New functions.
2050 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2051 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2052 (modify_event_symbol): Do not assume that the length of
2053 name_alist_or_stem is safe to alloca and fits in int.
2054 (Fexecute_extended_command): Likewise for function name and binding.
2055 (Frecursion_depth): Wrap around reliably on integer overflow.
2056 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2057 since some callers pass EMACS_INT values.
2058 (Fsingle_key_description): Don't crash if symbol name contains more
2059 than MAX_ALLOCA bytes.
2060 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2061 (get_minibuffer): Arg is now EMACS_INT, not int.
2062 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2063 (esprintf, exprintf, evxprintf): New decls.
2064 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2066 * dbusbind.c (signature_cat): New function.
2067 (xd_signature, Fdbus_register_signal):
2068 Do not overrun buffer; instead, report string overflow.
2070 * dispnew.c (add_window_display_history): Don't overrun buffer.
2071 Truncate instead; this is OK since it's just a log.
2073 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2074 even if the time zone offset is outlandishly large.
2075 Don't mishandle offset == INT_MIN.
2077 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2078 when creating daemon; the previous buffer-overflow check was incorrect.
2080 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2081 which has the guts of the old verror function.
2083 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2084 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2086 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2087 (font_unparse_xlfd): Don't blindly alloca long strings.
2088 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2089 fits in int, when using sprintf. Use single snprintf to count
2090 length of string rather than counting it via multiple sprintfs;
2091 that's simpler and more reliable.
2092 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2093 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2094 sprintf, in case result does not fit in int.
2096 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2097 (fontset_from_font): Print it.
2099 * frame.c (tty_frame_count): Now printmax_t, not int.
2100 (make_terminal_frame, set_term_frame_name): Print it.
2101 (x_report_frame_params): In X, window IDs are unsigned long,
2102 not signed long, so print them as unsigned.
2103 (validate_x_resource_name): Check for implausibly long names,
2104 and don't assume name length fits in 'int'.
2105 (x_get_resource_string): Don't blindly alloca invocation name;
2106 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2109 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2110 (xg_check_special_colors, xg_set_geometry):
2111 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2113 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2114 Use esprintf, not sprintf, in case result does not fit in int.
2116 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2117 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2118 it as a large positive number.
2119 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2120 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2122 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2123 in case result does not fit in int.
2125 * print.c (float_to_string): Detect width overflow more reliably.
2126 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2127 buffer overrun. Don't assume list length fits in 'int'. Treat
2128 print length of 0 as 0, not as infinity; to be consistent with other
2129 uses of print length in this function. Don't overflow print length
2130 index. Don't assume hash table size fits in 'long', or that
2131 vectorlike size fits in 'unsigned long'.
2133 * process.c (make_process): Use printmax_t, not int, to format
2134 process-name gensyms.
2136 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2138 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2139 to avoid potential buffer overrun.
2141 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2142 if X resource line is longer than 512 bytes.
2144 * xfns.c (x_window): Make sprintf buffer a bit bigger
2145 to avoid potential buffer overrun.
2147 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2149 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2151 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2153 Integer overflow fixes for scrolling, etc.
2154 Without these, Emacs silently mishandles large integers sometimes.
2155 For example, "C-u 4294967297 M-x recenter" was treated as if
2156 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2158 * xdisp.c (try_window_id): Check Emacs fixnum range before
2159 converting to 'int'.
2161 * window.c (window_scroll_line_based, Frecenter):
2162 Check that an Emacs fixnum is in range before assigning it to 'int'.
2163 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2164 values converted from Emacs fixnums.
2165 (Frecenter): Don't wrap around a line count if it is out of 'int'
2166 range; instead, treat it as an extreme value.
2167 (Fset_window_configuration, compare_window_configurations):
2168 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2170 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2171 that can exceed INT_MAX. Check that EMACS_INT value is in range
2172 before assigning it to the (possibly-narrower) index.
2173 (match_limit): Don't assume that a fixnum can fit in 'int'.
2175 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2178 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2179 (Fvertical_motion): Don't wrap around LINES values that don't fit
2180 in 'int'. Instead, treat them as extreme values. This is good
2181 enough for windows, which can't have more than INT_MAX lines anyway.
2183 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2185 * Require libxml/parser.h to avoid compilation warning.
2187 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2189 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2190 since this reportedly can destroy thread storage.
2192 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2194 * syntax.c (find_defun_start): Update all cache variables if
2195 exiting early (Bug#9401).
2197 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2199 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2201 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2202 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2203 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2205 * term.c (tty_append_glyph): New function.
2206 (produce_stretch_glyph): Static function and its prototype deleted.
2208 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2211 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2213 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2214 when checking :margin (Bug#9390).
2215 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2216 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2217 so that the name doesn't mislead. All uses changed.
2219 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2221 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2224 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2226 * xdisp.c (move_it_to): Don't bail out early when reaching
2227 position beyond to_charpos, if we are scanning backwards.
2228 (move_it_vertically_backward): When DY == 0, make sure we get to
2229 the first character in the line after the newline.
2231 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2233 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2234 (ccl_driver): Do not generate an out-of-range pointer.
2235 (Fccl_execute_on_string): Remove unnecessary check for
2236 integer overflow, noted by Stefan Monnier in
2237 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2238 Remove a FIXME that didn't need fixing.
2239 Simplify the newly-introduced buffer reallocation code.
2241 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2243 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2245 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2247 Integer and memory overflow issues (Bug#9196).
2249 * doc.c (get_doc_string): Rework so that
2250 get_doc_string_buffer_size is the actual buffer size, rather than
2251 being 1 less than the actual buffer size; this makes xpalloc more
2254 * image.c (x_allocate_bitmap_record, cache_image):
2255 * xselect.c (Fx_register_dnd_atom):
2256 Simplify previous changes by using xpalloc.
2258 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2259 since either will do and ptrdiff_t is convenient with xpalloc.
2261 * charset.c (charset_table_size)
2262 (struct charset_sort_data.priority): Now ptrdiff_t.
2263 (charset_compare): Don't overflow if priorities differ greatly.
2264 (Fsort_charsets): Don't assume list length fits in int.
2265 Check for size-calculation overflow when allocating sort data.
2266 (syms_of_charset): Allocate an initial charset table that is
2267 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2269 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2271 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2272 The actual value is always <= INT_MAX, and leaving it unsigned made
2273 overflow checking harder.
2275 * dispextern.h (struct glyph_matrix.rows_allocated)
2276 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2277 with xpalloc. The values are still always <= INT_MAX.
2279 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2281 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2282 (SAFE_NALLOCA): New macro.
2284 * region-cache.c (struct boundary.pos, find_cache_boundary)
2285 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2286 (set_cache_region, invalidate_region_cache)
2287 (revalidate_region_cache, know_region_cache, region_cache_forward)
2288 (region_cache_backward, pp_cache):
2289 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2290 so that ptrdiff_t * can be passed to xpalloc.
2291 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2292 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2293 (pp_cache): Don't assume cache_len fits in int.
2294 * region-cache.h: Adjust extern decls to match.
2296 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2297 EMACS_INT, since either will do, for xpalloc.
2299 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2300 (xnmalloc, xnrealloc, xpalloc): New functions.
2302 * bidi.c (bidi_shelve_header_size): New constant.
2303 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2304 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2306 * bidi.c (bidi_cache_shrink):
2307 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2309 Don't update size of array until after memory allocation succeeds,
2310 because xmalloc/xrealloc may not return.
2311 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2312 now that we have proper integer overflow checking.
2313 (record_overlay_string, overlay_strings): Catch overflows when
2314 calculating size of overlay_str_buf.
2316 * callproc.c (Fcall_process): Check for size overflow when
2317 calculating size of args2.
2318 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2319 Normally we prefer signed values, but sticking with ptrdiff_t would
2320 require adding more-complicated checks.
2322 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2323 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2324 Redo buffer-overflow calculations to avoid integer overflow.
2325 Add a FIXME comment where memory seems to be over-allocated.
2327 * character.c (Fstring): Check for size-calculation overflow.
2329 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2330 unnecessary integer overflow. Check for size overflow.
2331 (encode_coding_object): Don't update size until xmalloc succeeds.
2333 * composite.c (get_composition_id): Check for overflow in glyph
2334 length calculations.
2336 Integer and memory overflow fixes for display code.
2337 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2338 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2339 (scrolling_window): Check for overflow in size calculations.
2340 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2341 Don't assume glyph table len fits in int.
2342 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2343 (row_table_size): Now ptrdiff_t, not int.
2344 (scrolling_window): Avoid overflow in size calculations.
2345 Don't update size until allocation succeeds.
2346 * fns.c (concat): Check for overflow in size calculations.
2347 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2348 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2349 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2351 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2352 (get_doc_string): Check for size calculation overflow.
2353 Don't update size until allocation succeeds.
2354 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2355 EMACS_INT, where ptrdiff_t will do.
2356 (Fsubstitute_command_keys): Check for string overflow.
2358 * editfns.c (set_time_zone_rule): Don't assume environment length
2360 (message_length): Now ptrdiff_t, not int.
2361 (Fmessage_box): Don't update size until allocation succeeds.
2362 Don't assume message length fits in int.
2363 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2365 * emacs.c (main): Do not reallocate argv, since there is a null at
2366 the end that can be overwritten, and this way there's no need to
2367 worry about size-calculation overflow.
2368 (sort_args): Check for size-calculation overflow.
2370 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2372 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2374 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2375 (x_set_scroll_bar_width, x_figure_window_size):
2376 Check for integer overflow.
2377 (x_set_alpha): Do not assume XINT fits in int.
2379 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2380 This is for the members text_lines, text_cols, total_lines, total_cols,
2381 where the system imposes an 'int' limit.
2383 * fringe.c (Fdefine_fringe_bitmap):
2384 Don't update size until alloc works.
2386 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2387 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2389 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2390 Check for size-calculation overflow.
2391 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2392 do, as we prefer signed integers.
2393 (id_to_widget.max_size, id_to_widget.used)
2394 (xg_store_widget_in_map, xg_remove_widget_from_map)
2395 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2396 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2397 Use and return ptrdiff_t, not int.
2398 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2399 * gtkutil.h: Change prototypes to match the above.
2401 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2402 are duplicate now that they've been promoted to lisp.h.
2403 (x_allocate_bitmap_record, x_alloc_image_color)
2404 (make_image_cache, cache_image, xpm_load):
2405 Don't update size until alloc is done.
2406 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2408 Check for size calculation overflow.
2409 (ct_colors_allocated_max): New constant.
2410 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2413 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2414 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2415 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2416 Use ptrdiff_t, not int, to count maps.
2417 (read_char_minibuf_menu_prompt): Check for overflow in size
2418 calculations. Don't update size until allocation succeeds.
2419 Redo calculations to avoid overflow.
2420 * keyboard.h: Change prototypes to match the above.
2422 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2424 (current_minor_maps): Check for size calculation overflow.
2425 * keymap.h: Change prototypes to match the above.
2427 * lread.c (read1, init_obarray): Don't update size until alloc done.
2429 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2430 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2432 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2433 Now ptrdiff_t, not int.
2434 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2435 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2437 * process.c (Fnetwork_interface_list): Check for overflow
2438 in size calculation.
2440 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2442 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2443 overflow. Don't bother calling xmalloc when xrealloc will do.
2445 * search.c (Freplace_match): Check for size calculation overflow.
2446 (Fset_match_data): Don't assume list lengths fit in 'int'.
2448 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2449 for command line length. Do not attempt to address one before the
2450 beginning of an array, as that's not portable.
2452 * term.c (max_frame_lines): Remove; unused.
2453 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2455 (encode_terminal_code, calculate_costs): Check for size
2456 calculation overflow.
2457 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2458 table lengths and related sizes. Don't update size until alloc
2459 done. Redo calculations to avoid overflow.
2460 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2462 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2463 subtracting pointers.
2464 (gobble_line): Check for overflow more carefully. Don't update size
2467 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2468 Don't update size until alloc done.
2469 Redo size calculations to avoid overflow.
2470 Check for size calculation overflow.
2471 (main) [DEBUG]: Fix typo in invoking tparam1.
2473 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2474 Use ptrdiff_t, not int, for sizes.
2475 (store_mode_line_noprop_char): Don't update size until alloc done.
2477 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2478 Use ptrdiff_t, not int, for sizes.
2479 (Finternal_make_lisp_face, cache_face):
2480 Check for size calculation overflow.
2481 (cache_face): Treat size calculation overflows as if they were
2482 memory exhaustion (the usual treatment), rather than aborting.
2484 * xfns.c (x_encode_text, x_set_name_internal)
2485 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2486 sizes, since they can exceed INT_MAX in size. Check for size
2487 calculation overflow.
2489 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2490 (xg_select): Check for size calculation overflow.
2491 Don't update size until alloc done.
2493 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2494 as sprintf is limited to int lengths.
2496 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2497 (X_LONG_MIN): New macros.
2498 Use them to make the following changes clearer.
2499 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2500 This change doesn't affect the value now, but it may help remind
2501 future maintainers not to raise the value too much later.
2502 (SELECTION_QUANTUM): Remove, replacing with ...
2503 (selection_quantum): ... new function, which avoids overflow.
2505 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2506 assumption that selection length fits in 'int'.
2507 (x_reply_selection_request, x_handle_selection_request)
2508 (x_get_window_property, receive_incremental_selection)
2509 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2510 (lisp_data_to_selection_data, clean_local_selection_data):
2511 Use ptrdiff_t, not int, to record length of selection.
2512 (x_reply_selection_request, x_get_window_property)
2513 (receive_incremental_selection, x_property_data_to_lisp):
2514 Redo calculations to avoid overflow.
2515 (x_reply_selection_request): When sending hint, ceiling it at
2516 X_LONG_MAX rather than relying on wraparound overflow to send
2518 (x_get_window_property, receive_incremental_selection)
2519 (lisp_data_to_selection_data, x_property_data_to_lisp):
2520 Check for size-calculation overflow.
2521 (x_get_window_property, receive_incremental_selection)
2522 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2523 Don't store size until memory allocation succeeds.
2524 (x_get_window_property): Plug memory leak on memory exhaustion.
2525 Don't double-block input; malloc is safe here. Don't assume 2**34
2526 - 4 fits in unsigned long. Add an xassert to check
2527 XGetWindowProperty overflow. Be more careful about overflow
2528 calculations, and distinguish size from memory overflow better.
2529 (receive_incremental_selection): When tracing, don't assume
2530 unsigned int is less than INT_MAX.
2531 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2532 harmful) conversions of unsigned short to int.
2533 (lisp_data_to_selection_data): Don't assume that integers
2534 in the range -65535 through -1 fit in an X unsigned short.
2535 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2536 result parameters unless successful. Rely on cons_to_unsigned
2537 to report problems with elements; the old code wasn't right anyway.
2538 (x_check_property_data): Check for int overflow; we cannot use
2539 a wider type due to X limits.
2540 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2542 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2544 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2545 (x_term_init): Check for size calculation overflow.
2546 (x_color_cells): Don't store size until memory allocation succeeds.
2547 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2548 Don't assume alloca size is less than MAX_ALLOCA.
2549 (x_term_init): Don't assume length fits in int (sprintf is limited
2552 Use ptrdiff_t for composition IDs.
2553 * character.c (lisp_string_width):
2554 * composite.c (composition_table_size, n_compositions)
2555 (get_composition_id, composition_gstring_from_id):
2556 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2557 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2558 * window.c (Frecenter):
2559 Use ptrdiff_t, not int, for composition IDs.
2560 * composite.c (get_composition_id): Check for integer overflow.
2561 * composite.h: Adjust prototypes to match the above changes.
2563 Use ptrdiff_t for hash table indexes.
2564 * category.c (hash_get_category_set):
2565 * ccl.c (ccl_driver):
2566 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2567 * coding.c (coding_system_charset_list, detect_coding_system):
2568 * coding.h (struct coding_system.id):
2569 * composite.c (get_composition_id, gstring_lookup_cache):
2570 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2571 * image.c (xpm_get_color_table_h):
2572 * lisp.h (hash_lookup, hash_put):
2573 * minibuf.c (Ftest_completion):
2574 Use ptrdiff_t for hash table indexes, not int (which is too
2575 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2576 32-bit --with-wide-int hosts).
2578 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2579 Add a FIXME comment about memory leaks.
2580 (syms_of_charset): Don't assume xmalloc returns.
2582 Don't assume that stated character widths fit in int.
2583 * character.c (Fchar_width, c_string_width, lisp_string_width):
2584 * character.h (CHAR_WIDTH):
2585 * indent.c (MULTIBYTE_BYTES_WIDTH):
2586 Use sanitize_char_width to avoid undefined and/or bad behavior
2587 with outlandish widths.
2588 * character.h (sanitize_tab_width): Rename from sanitize_width,
2589 now that we have two such functions. All uses changed.
2590 (sanitize_char_width): New inline function.
2592 Don't assume that tab-width fits in int.
2593 * character.h (sanitize_width): New inline function.
2594 (SANE_TAB_WIDTH): New macro.
2595 (ASCII_CHAR_WIDTH): Use it.
2596 * indent.c (sane_tab_width): Remove. All uses replaced by
2597 SANE_TAB_WIDTH (current_buffer).
2598 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2600 * fileio.c: Integer overflow issues with file modes.
2601 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2603 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2604 Remove unreachable code.
2605 (read_hex, load_charset_map_from_file): Check for integer overflow.
2607 * xterm.c: Don't go over XClientMessageEvent limit.
2608 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2609 (x_send_scroll_bar_event): Likewise. Check that the size does not
2610 exceed limits imposed by XClientMessageEvent, as well as the usual
2611 ptrdiff_t and size_t limits.
2613 * keyboard.c: Overflow, signedness and related fixes.
2614 (make_lispy_movement): Use same integer type in forward decl
2615 that is used in the definition.
2616 (read_key_sequence, keyremap_step):
2617 Change bufsize argument back to int, undoing my 2011-03-30 change.
2618 We prefer signed types, and int is wide enough here.
2619 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2620 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2621 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2622 length, not size_t. Use ptrdiff_t for index, not int.
2623 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2624 possibility of integer overflow.
2626 Overflow, signedness and related fixes for images.
2628 * dispextern.h (struct it.stack[0].u.image.image_id)
2629 (struct_it.image_id, struct image.id, struct image_cache.size)
2630 (struct image_cache.used, struct image_cache.ref_count):
2631 * gtkutil.c (update_frame_tool_bar):
2632 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2633 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2634 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2635 * nsmenu.m (update_frame_tool_bar):
2636 * xdisp.c (calc_pixel_width_or_height):
2637 * xfns.c (image_cache_refcount):
2638 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2639 on typical 64-bit hosts.
2641 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2642 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2643 Omit unnecessary casts to int.
2644 (parse_image_spec): Check that integers fall into 'int' range
2645 when the callers expect that.
2646 (image_ascent): Redo ascent calculation to avoid int overflow.
2647 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2648 (lookup_image): Remove unnecessary tests.
2649 (xbm_image_p): Locals are now of int, not EMACS_INT,
2650 since parse_image_check makes sure they fit into int.
2651 (png_load, gif_load, svg_load_image):
2652 Prefer int to unsigned where either will do.
2653 (tiff_handler): New function, combining the cores of the
2654 old tiff_error_handler and tiff_warning_handler.
2655 This function is rewritten to use vsnprintf and thereby avoid
2656 stack buffer overflows. It uses only the features of vsnprintf
2657 that are common to both POSIX and native Microsoft.
2658 (tiff_error_handler, tiff_warning_handler): Use it.
2659 (tiff_load, gif_load, imagemagick_load_image):
2660 Don't assume :index value fits in 'int'.
2661 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2662 (imagemagick_load_image): Check that crop parameters fit into
2663 the integer types that MagickCropImage accepts. Don't assume
2664 Vimagemagick_render_type has a nonnegative value. Don't assume
2665 size_t fits in 'long'.
2666 (gs_load): Use printmax_t to print the widest integers possible.
2667 Check for integer overflow when computing image height and width.
2669 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2671 * xdisp.c (redisplay_window): Don't force window start if point
2672 will be invisible in the resulting window. (Bug#9324)
2674 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2676 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2677 the display spec is of the form `(space ...)'.
2678 (handle_display_spec): Return the value returned by
2679 handle_single_display_spec, not just 1 or zero.
2680 (handle_single_display_spec): If the display spec is of the form
2681 `(space ...)', and specifies display in the text area, return 2
2683 (try_cursor_movement): Check for the need to scroll more
2684 accurately, and prefer exact match for point under bidi.
2685 Don't advance `row' beyond the last row of the window.
2687 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2688 into disp_prop; all users changed.
2690 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2691 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2692 for the text covered by the display property.
2694 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2696 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2697 Change return value to nil.
2698 (Frecord_buffer): Delete unused function.
2700 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2702 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2703 buffers, return left-to-right.
2704 (set_cursor_from_row): Consider candidate row a win if its glyph
2705 represents a newline and point is on that newline. Fixes cursor
2706 positioning on the newline at EOL of R2L text within L2R
2707 paragraph, and vice versa.
2708 (try_cursor_movement): Check continued rows, in addition to
2709 continuation rows. Fixes unwarranted scroll when point enters a
2710 continued line of R2L text within an L2R paragraph, or vice versa.
2711 (cursor_row_p): Consider the case of point being equal to
2712 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2713 from the end of a short line to the beginning of a continued line
2714 of R2L text within L2R paragraph.
2715 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2716 composed characters.
2718 * bidi.c (bidi_check_type): Use xassert.
2719 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2722 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2724 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2727 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2729 * nsfont.m (ns_otf_to_script): Fix typo.
2731 2011-08-22 Kenichi Handa <handa@m17n.org>
2733 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2734 extra slot even if the purpose is char-code-property-table.
2736 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2738 * xdisp.c (redisplay_window): When computing centering_position,
2739 account for the height of the header line. (Bug#8874)
2741 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2742 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2743 candidate is selected by the mouse, and that candidate has a
2744 composed character under the mouse.
2746 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2747 coordinates reported by pos-visible-in-window-p for a composed
2748 character in column zero.
2750 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2752 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2754 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2756 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2757 consider it a hit if to_charpos is anywhere in the range of the
2758 composed buffer positions.
2760 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2762 * image.c (gif_load): Don't assume that each subimage has the same
2763 dimensions as the base image. Handle disposal method that is
2764 "undefined" by the gif spec (Bug#9335).
2766 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2768 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2769 (Fcondition_case): Document `debug' symbol in error handler.
2771 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2773 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2774 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2775 from an Org mode buffer to a Speedbar frame.
2777 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2778 a composition, take its buffer position from IT->cmp_it.charpos.
2779 Fixes cursor positioning at the beginning of a line that begins
2780 with a composed character.
2782 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2784 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2785 character bidirectional type, use STRONG_L instead. Fixes crashes
2786 in a buffer produced by `describe-categories'.
2788 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2789 members before the level stack, so they would be saved and
2790 restored when copying iterator state. Fixes incorrect reordering
2791 around TABs covered by display properties.
2793 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2795 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2797 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2799 * eval.c (internal_condition_case, internal_condition_case_1)
2800 (internal_condition_case_2, internal_condition_case_n):
2801 Remove unnecessary aborts (Bug#9081).
2803 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2805 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2806 has no `load' handler, try opening the file locally. (Bug#9311)
2808 2011-08-16 Ken Brown <kbrown@cornell.edu>
2810 * gmalloc.c: Expand comment.
2812 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2814 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2815 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2817 2011-08-16 Ken Brown <kbrown@cornell.edu>
2819 Fix memory allocation problems in Cygwin build (Bug#9273).
2821 * unexcw.c ( __malloc_initialized): Declare external variable.
2822 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2824 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2826 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2828 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2830 [CYGWIN] (special_realloc): New function.
2831 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2832 requests to realloc storage in the static heap.
2834 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2836 * bidi.c (bidi_initialize): Remove unused local.
2838 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2841 * biditype.h: Remove file.
2842 * makefile.w32-in ($(BLD)/bidi.$(O)):
2843 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2845 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2847 * chartab.c: Improve commentary for the uniprop_table API.
2849 * bidi.c (bidi_paragraph_init): Support zero value of
2850 bidi_ignore_explicit_marks_for_paragraph_level.
2851 (bidi_initialize): Use uniprop_table instead of including
2852 biditype.h and bidimirror.h.
2854 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2855 coordinates of the iterator when restoring from ppos_it.
2858 2011-08-14 Kenichi Handa <handa@m17n.org>
2860 * process.c (create_process): Call setup_process_coding_systems
2861 after the pid of the process is set to -1 (Bug#8162).
2863 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2865 * xdisp.c (move_it_in_display_line_to): Don't invoke
2866 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2867 ppos_it. Fixes vertical cursor motion when line beginning is
2868 covered by an image. (Bug#9296)
2870 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2872 * nsterm.h (ns_run_ascript): Declare.
2873 (NSAPP_DATA2_RUNASSCRIPT): Define.
2875 * nsfns.m (as_script, as_result, as_status): New static variables.
2876 (ns_run_ascript): New function.
2877 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2878 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2879 the event loop. Get status from as_status (Bug#7276).
2881 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2882 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2883 the event loop (Bug#7276).
2885 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2887 * gnutls.c (QCgnutls_bootprop_priority)
2888 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2889 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2890 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2891 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2892 (QCgnutls_bootprop_verify_hostname_error)
2893 (QCgnutls_bootprop_callbacks_verify): Rename from
2894 Qgnutls_bootprop_..., all uses changed.
2896 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2899 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2901 * xfaces.c (Qframe_set_background_mode): Now static.
2902 * dispextern.h (Qframe_set_background_mode): Remove decl.
2904 * process.c (Fnetwork_interface_info): Declare local only if needed.
2906 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2908 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2909 (Fnetwork_interface_list): Allocate in increments of bytes instead
2910 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2911 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2913 (struct ifflag_def): notrailers is smart on OSX.
2914 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2915 Get hardware address with getifaddrs if available.
2917 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2919 * xdisp.c (iterate_out_of_display_property): xassert that
2920 IT->position is set to within IT->object's boundaries. Break from
2921 the loop as soon as EOB is reached; avoids infloops in redisplay
2922 when IT->position is set up wrongly due to some bug.
2923 Set IT->current to match the bidi iterator unconditionally.
2924 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2925 entry. Force push_it to save on the stack the current
2926 buffer/string position, to be restored by pop_it. Fix flags in
2927 the iterator structure wrt the object coming from a display
2928 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2929 properties. (Bug#9284)
2931 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2933 * fontset.c (fontset_get_font_group): Add proper type checks.
2936 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2938 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2939 and LC_VERSION_MIN_MACOSX.
2940 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2941 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2943 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2945 * xdisp.c (forward_to_next_line_start): Allow to use the
2946 no-display-properties-and-no-overlays under bidi display.
2947 Set disp_pos in the bidi iterator to avoid searches for display
2948 properties and overlays.
2950 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2952 * editfns.c (Fset_time_zone_rule): Document relationship with the
2955 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2956 the font entity extracted from the cache (Bug#8109).
2958 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2960 * composite.c (autocmp_chars): Don't reset point. That is done by
2961 restore_point_unwind (Bug#5984).
2963 2011-08-07 Juri Linkov <juri@jurta.org>
2965 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2966 to show the arg `TIME' instead of `TIMEVAL'.
2968 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2970 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2971 display property strides EOL and includes a newline, as in
2972 longlines-mode. (Bug#9254)
2973 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2974 word-wrap under bidirectional display. (Bug#9224)
2976 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2977 is non-zero, even if the data buffer is NULL. Fixes a crash in
2978 vertical-motion with longlines-mode. (Bug#9254)
2980 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2982 * bidi.c <bidi_cache_total_alloc>: Now static.
2983 (bidi_initialize): Initialize bidi_cache_total_alloc.
2985 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2988 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2989 amount allocated this far in `bidi_cache_total_alloc'.
2990 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2991 non-zero, only free the data buffer without restoring the cache
2992 contents. All callers changed.
2994 * dispextern.h (bidi_unshelve_cache): Update prototype.
2996 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2997 (move_it_in_display_line, move_it_to)
2998 (move_it_vertically_backward, move_it_by_lines): Replace the call
2999 to xfree to an equivalent call to bidi_unshelve_cache.
3000 (move_it_in_display_line_to): Fix logic of returning
3001 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3003 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3005 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3006 came from a string character with a `cursor' property. (Bug#9229)
3008 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3010 * Makefile.in (LIB_PTHREAD): New variable.
3011 (LIBES): Add LIB_PTHREAD (Bug#9216).
3013 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3014 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3016 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3018 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3020 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3022 * xterm.c (x_find_topmost_parent): New function.
3023 (x_set_frame_alpha): Find topmost parent window with
3024 x_find_topmost_parent and set the property there also (bug#9181).
3025 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3027 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3029 * callproc.c (Fcall_process): Avoid vfork clobbering
3030 the local vars buffer, coding_systems, current_dir.
3032 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3034 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3036 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3038 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3039 so that it is not optimized away.
3041 * xdisp.c (compute_display_string_pos): Remove unused local.
3043 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3045 Fix slow cursor motion and scrolling in large buffers with
3046 selective display, like Org Mode buffers. (Bug#9218)
3048 * dispextern.h (struct bidi_it): New member disp_prop_p.
3050 * xdisp.c: Remove one-slot cache of display string positions.
3051 (compute_display_string_pos): Accept an additional argument
3052 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3053 for a display string or property. If found, set DISP_PROP_P
3056 * bidi.c (bidi_fetch_char): Accept an additional argument
3057 DISP_PROP_P, and pass it to compute_display_string_pos.
3058 Only handle text covered by a display string if DISP_PROP_P is returned
3059 non-zero. All callers of bidi_fetch_char changed.
3061 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3063 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3065 2010-12-03 Don March <don@ohspite.net>
3067 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3068 last character M-[char] is translated to ESC [char] (bug#7541).
3070 2011-08-02 Kenichi Handa <handa@m17n.org>
3072 * lisp.h (uniprop_table): Extern it.
3074 * chartab.c (uniprop_table): Make it non-static.
3076 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3078 * xdisp.c (forward_to_next_line_start): Accept additional argument
3079 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3081 (reseat_at_next_visible_line_start): Use the bidi iterator state
3082 returned by forward_to_next_line_start to restore the state of
3083 it->bidi_it after backing up to previous newline. (Bug#9212)
3085 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3087 * regex.c (re_comp): Protoize.
3088 (re_exec): Fix return type.
3089 (regexec): Fix type of `ret'. (Bug#9203)
3091 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3093 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3094 This is needed if max-image-size is a floating-point number.
3096 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3098 * print.c (print_object): Print empty symbol as ##.
3100 * lread.c (read1): Read ## as empty symbol.
3102 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3104 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3105 setting frame foreground color (Bug#9175).
3106 (x_set_background_color): Likewise.
3108 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3109 contents (Bug#9176).
3110 (EmacsTooltip -init): Remove bezels and add shadows to
3113 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3114 or scroll bar (Bug#8470).
3116 * nsfont.m (nsfont_open): Remove assignment to voffset and
3117 unnecessary vars hshink, expand, hd, full_height, min_height.
3118 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3120 * nsterm.h (nsfont_info): Remove voffset field.
3122 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3124 Implement strike-through and overline on NextStep (Bug#8863).
3126 * nsfont.m (nsfont_open): Use underline position provided by font,
3127 instead of hard-coded value of 2.
3128 (nsfont_draw): Call ns_draw_text_decoration instead.
3130 * nsterm.h: Add declaration for ns_draw_text_decoration.
3132 * nsterm.m (ns_draw_text_decoration): New function for drawing
3133 underline, overline, and strike-through.
3134 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3135 ns_draw_text_decoration. Change treatment of cursor drawing to
3136 accommodate underlining, etc.
3138 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3140 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3143 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3145 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3146 Without this fix, if a signal arrives just after memory fills up,
3147 'malloc' might be invoked reentrantly.
3149 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3150 In other words, assume that every image size is allowed, on non-X
3151 hosts. This assumption is probably wrong, but it lets Emacs compile.
3153 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3155 * regex.c (re_iswctype): Convert return values to boolean.
3157 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3159 * xdisp.c (compute_display_string_pos): Don't use cached display
3160 string position if the buffer had its restriction changed.
3163 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3165 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3167 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3169 Integer signedness and overflow and related fixes. (Bug#9079)
3171 * bidi.c: Integer size and overflow fixes.
3172 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3173 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3174 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3175 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3176 (bidi_find_other_level_edge):
3177 Use ptrdiff_t instead of EMACS_INT where either will do.
3178 This works better on 32-bit hosts configured --with-wide-int.
3179 (bidi_cache_ensure_space): Check for size-calculation overflow.
3180 Use % rather than repeated addition, for better worst-case speed.
3181 Don't set bidi_cache_size until after xrealloc returns, because it
3183 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3184 (bidi_cache_ensure_space): Also check that the bidi cache size
3185 does not exceed that of the largest Lisp string or buffer. See Eli
3186 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3188 * alloc.c (__malloc_size_t): Remove.
3189 All uses replaced by size_t. See Andreas Schwab's note
3190 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3192 * image.c: Improve checking for integer overflow.
3193 (check_image_size): Assume that f is nonnull, since
3194 it is always nonnull in practice. This is one less thing to
3195 worry about when checking for integer overflow later.
3196 (x_check_image_size): New function, which checks for integer
3197 overflow issues inside X.
3198 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3199 This removes the need for a memory_full check.
3200 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3201 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3202 (xbm_read_bitmap_data): Change locals back to 'int', since
3203 their values must fit in 'int'.
3204 (xpm_load_image, png_load, tiff_load):
3205 Invoke x_create_x_image_and_pixmap earlier,
3206 to avoid much needless work if the image is too large.
3207 (tiff_load): Treat overly large images as if
3208 x_create_x_image_and_pixmap failed, not as malloc failures.
3209 (gs_load): Use x_check_image_size.
3211 * gtkutil.c: Omit integer casts.
3212 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3213 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3215 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3217 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3218 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3219 would wrongly return t on a 64-bit host.
3221 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3222 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3223 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3224 and therefore cause GCC to emit a bogus diagnostic in some cases.
3226 * image.c: Integer signedness and overflow and related fixes.
3227 This is not an exhaustive set of fixes, but it's time to
3228 record what I've got.
3229 (lookup_pixel_color, check_image_size): Remove redundant decls.
3230 (check_image_size): Don't assume that arbitrary EMACS_INT values
3231 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3232 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3233 (tiff_load, imagemagick_load_image):
3234 Check for overflow in size calculations.
3235 (x_create_x_image_and_pixmap): Remove unnecessary test for
3236 xmalloc returning NULL; that can't happen.
3237 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3238 (xpm_color_bucket): Use better integer hashing function.
3239 (xpm_cache_color): Don't possibly over-allocate memory.
3240 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3241 (gif_memory_source):
3242 Use ptrdiff_t, not int or size_t, to record sizes.
3243 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3244 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3245 either works, as we prefer signed integers.
3246 (tiff_read_from_memory, tiff_write_from_memory):
3247 Return tsize_t, not size_t, since that's what the TIFF API wants.
3248 (tiff_read_from_memory): Don't fail simply because the read would
3249 go past EOF; instead, return a short read.
3250 (tiff_load): Omit no-longer-needed casts.
3251 (Fimagemagick_types): Don't assume size fits into 'int'.
3253 Improve hashing quality when configured --with-wide-int.
3254 * fns.c (hash_string): New function, taken from sxhash_string.
3255 Do not discard information about ASCII character case; this
3256 discarding is no longer needed.
3257 (sxhash-string): Use it. Change sig to match it. Caller changed.
3258 * lisp.h: Declare it.
3259 * lread.c (hash_string): Remove, since we now use fns.c's version.
3260 The fns.c version returns a wider integer if --with-wide-int is
3261 specified, so this should help the quality of the hashing a bit.
3263 * emacs.c: Integer overflow minor fix.
3264 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3265 Define only if GNU_LINUX.
3266 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3268 * dispnew.c: Integer signedness and overflow fixes.
3269 Remove unnecessary forward decls, that were a maintenance hassle.
3270 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3272 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3273 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3274 (prepare_desired_row, line_draw_cost):
3275 Use int, not unsigned, where either works.
3276 (save_current_matrix, restore_current_matrix):
3277 Use ptrdiff_t, not size_t, where either works.
3278 (init_display): Check for overflow more accurately, and without
3279 relying on undefined behavior.
3281 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3282 Remove, replacing with the new symbols in lisp.h. All uses changed.
3283 * fileio.c (make_temp_name):
3284 * filelock.c (lock_file_1, lock_file):
3285 * xdisp.c (message_dolog):
3286 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3287 Use pMd etc. instead.
3288 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3289 replacing the pWIDE etc. symbols removed from editfns.c.
3291 * keyboard.h (num_input_events): Now uintmax_t.
3292 This is (very slightly) less likely to mess up due to wraparound.
3295 * buffer.c: Integer signedness fixes.
3296 (alloc_buffer_text, enlarge_buffer_text):
3297 Use ptrdiff_t rather than size_t when either will do, as we prefer
3300 * alloc.c: Integer signedness and overflow fixes.
3301 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3302 (__malloc_size_t): Default to size_t, not to int.
3303 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3304 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3305 Prefer ptrdiff_t to size_t when either would do, as we prefer
3307 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3308 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3309 Now const. Initialize with values that are in range even if char
3311 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3312 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3313 These functions do the right thing with sizes > 2**32.
3314 (check_depth): Now ptrdiff_t, not int.
3315 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3316 Adjust to new way of storing sizes. Check for size overflow bugs
3318 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3319 slightly wrong anyway, as it missed one instance of
3320 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3321 (refill_memory_reserve): Omit needless cast to size_t.
3322 (mark_object_loop_halt): Mark as externally visible.
3324 * xselect.c: Integer signedness and overflow fixes.
3325 (Fx_register_dnd_atom, x_handle_dnd_message):
3326 Use ptrdiff_t, not size_t, since we prefer signed.
3327 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3328 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3329 x_dnd_atoms_size and x_dnd_atoms_length.
3331 * doprnt.c: Prefer signed to unsigned when either works.
3333 * doprnt.c (doprnt):
3335 * xdisp.c (vmessage):
3336 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3337 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3338 prefer signed arithmetic to avoid comparison confusion.
3339 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3340 but is a bit tricky.
3342 Assume freestanding C89 headers, string.h, stdlib.h.
3343 * data.c, doprnt.c, floatfns.c, print.c:
3344 Include float.h unconditionally.
3345 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3346 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3347 * regex.c: Likewise for stddef.h, string.h.
3348 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3349 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3350 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3351 (STDC_HEADERS): Remove obsolete defines.
3352 * sysdep.c: Include limits.h unconditionally.
3354 Assume support for memcmp, memcpy, memmove, memset.
3355 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3356 * regex.c (memcmp, memcpy):
3357 Remove; we assume C89 now.
3359 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3360 (__malloc_safe_bcopy): Remove; no longer needed.
3362 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3363 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3364 well either way, and we prefer signed to unsigned.
3366 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3368 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3369 closes the connection while we're reading (bug#9182).
3371 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3373 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3374 are specified (Bug#9168).
3376 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3378 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3379 Found by GCC static checking and --with-wide-int on a 32-bit host.
3381 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3383 * xdisp.c (compute_display_string_pos): Fix logic of caching
3384 previous display string position. Initialize cached_prev_pos to
3385 -1. Fixes slow-down at the beginning of a buffer.
3387 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3389 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3390 for attrs[LFACE_FONTSET_INDEX].
3392 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3394 * xml.c (parse_region): Remove unused local
3395 that was recently introduced.
3397 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3399 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3400 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3402 * xdisp.c (move_it_in_display_line_to): Record the best matching
3403 position for TO_CHARPOS while scanning the line, and restore it on
3404 exit if none of the characters scanned was an exact match.
3405 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3406 when exact match is impossible due to invisible text, and the
3407 lines are truncated.
3409 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3411 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3414 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3416 Fix a significant slow-down of cursor motion with C-n, C-p,
3417 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3418 auto-repeat under bidi redisplay in fontified buffers.
3419 * xdisp.c (compute_stop_pos_backwards): New function.
3420 (next_element_from_buffer): Call compute_stop_pos_backwards to
3421 find a suitable prev_stop when we find ourselves before
3423 (reseat): Don't look for prev_stop, as that could mean a very long
3425 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3426 <cached_disp_overlay_modiff>: Cache for last found display string
3428 (compute_display_string_pos): Return the cached position if asked
3429 about the same buffer in the same area of character positions, and
3430 the buffer wasn't changed since the time the display string
3431 position was cached.
3433 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3435 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3436 is an integer, which is important for empty lines. (Bug#9149)
3438 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3440 * frame.c (Fmodify_frame_parameters): In tty case, update the
3441 default face if necessary (Bug#4238).
3443 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3445 * editfns.c (Fstring_to_char): No need to explain what a character
3446 is in the docstring (Bug#6576).
3448 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3450 * xml.c (parse_region): Make sure we always return a tree.
3452 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3454 * xml.c (parse_region): If a document contains only comments,
3457 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3459 * xml.c (make_dom): Return comments, too.
3461 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3464 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3465 and the surrounding thread.
3466 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3467 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3468 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3470 * s/openbsd.h (BROKEN_SIGIO): Define.
3471 * unexelf.c (unexec) [__OpenBSD__]:
3472 Don't update the .mdebug section of the Alpha COFF symbol table.
3474 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3476 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3479 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3481 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3482 This fixes some race conditions on the permissions of any newly
3485 * alloc.c (valid_pointer_p): Use pipe, not open.
3486 This fixes some permissions issues when debugging.
3488 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3489 If fchown fails to set both uid and gid, try to set just gid,
3490 as that is sometimes allowed. Adjust the file's mode to eliminate
3491 setuid or setgid bits that are inappropriate if fchown fails.
3493 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3495 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3496 to compare Lisp_Objects.
3497 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3498 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3499 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3501 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3503 * lread.c (read_integer): Unread even EOF character.
3504 (read1): Likewise. Properly record start position of symbol.
3506 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3507 symbol character follows.
3509 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3511 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3512 This works around a problem with the previous change to Fcopy_file.
3513 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3514 and without this change, GCC might complain about discarding
3515 fchown's return value.
3517 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3519 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3521 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3523 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3525 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3527 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3528 it's used from the C level.
3530 * process.c: Use the same condition for POLL_FOR_INPUT in both
3531 keyboard.c and process.c (bug#1858).
3533 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3535 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3536 (Fgnutls_boot): Use it.
3538 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3540 * doc.c (Fsubstitute_command_keys): Revert last change.
3542 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3544 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3545 quotes the next character, and doesn't affect other longer
3546 sequences (bug#8935).
3548 * lread.c (syms_of_lread): Clarify that is isn't only
3549 `eval-buffer' and `eval-defun' that's affected by
3550 `lexical-binding' (bug#8460).
3552 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3554 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3555 bidi redisplay when a line includes both an image and is truncated.
3557 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3559 Fix minor problems found by static checking.
3560 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3561 (elsz): Now a signed constant, not a size_t var. We prefer signed
3562 types to unsigned, to avoid integer comparison confusion. Without
3563 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3564 "cannot optimize loop, the loop counter may overflow", a symptom
3566 * indent.c (Fvertical_motion): Mark locals as initialized.
3567 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3569 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3571 * search.c (Fre_search_backward): Mention `case-fold-search' in
3572 all the re_search_* functions (bug#8138).
3574 * keyboard.c (Fopen_dribble_file): Document when the file is
3577 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3579 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3582 Support bidi reordering of display and overlay strings.
3583 * xdisp.c (compute_display_string_pos)
3584 (compute_display_string_end): Accept additional argument STRING.
3585 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3586 (reseat_to_string): Initialize bidi_it->string.s and
3587 bidi_it->string.schars.
3588 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3589 NULL (avoids a crash in bidi_paragraph_init).
3590 Initialize itb.string.lstring.
3591 (init_iterator): Call bidi_init_it only of a valid
3592 buffer position was specified. Initialize paragraph_embedding to
3594 (reseat_to_string): Initialize the bidi iterator.
3595 (display_string): If we need to ignore text properties of
3596 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3597 original value of -1 will not work with bidi.)
3598 (compute_display_string_pos): First arg is now struct
3599 `text_pos *'; all callers changed. Support display properties on
3601 (compute_display_string_end): Support display properties on Lisp
3603 (init_iterator, reseat_1, reseat_to_string): Initialize the
3604 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3605 when iterating on a string not from display properties).
3606 (compute_display_string_pos, compute_display_string_end):
3607 Fix calculation of the object to scan. Fixes an error when using
3609 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3610 base_level_stop; instead, set base_level_stop to BEGV.
3611 Fixes crashes in vertical-motion.
3612 (next_element_from_buffer): Improve commentary for when
3613 the iterator is before prev_stop.
3614 (init_iterator): Initialize bidi_p from the default value of
3615 bidi-display-reordering, not from buffer-local value. Use the
3616 buffer-local value only if initializing for buffer iteration.
3617 (handle_invisible_prop): Support invisible properties on strings
3618 that are being bidi-reordered.
3619 (set_iterator_to_next): Support bidi reordering of C strings and
3621 (next_element_from_string): Support bidi reordering of Lisp
3623 (handle_stop_backwards): Support Lisp strings as well.
3624 (display_string): Support display of R2L glyph rows.
3625 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3626 (init_iterator): Don't initialize it->bidi_p for strings
3628 (reseat_to_string): Initialize it->bidi_p for strings here.
3629 (next_element_from_string, next_element_from_c_string)
3630 (next_element_from_buffer): Add xassert's for correspondence
3631 between IT's object being iterated and it->bidi_it.string
3633 (face_before_or_after_it_pos): Support bidi iteration.
3634 (next_element_from_c_string): Handle the case of the first string
3635 character that is not the first one in the visual order.
3636 (get_visually_first_element): New function, refactored from common
3637 parts of next_element_from_buffer, next_element_from_string, and
3638 next_element_from_c_string.
3639 (tool_bar_lines_needed, redisplay_tool_bar)
3640 (display_menu_bar): Force left-to-right direction. Add a FIXME
3641 comment for making that be controlled by a user option.
3642 (push_it, pop_it): Save and restore the state of the
3643 bidi iterator. Save and restore the bidi_p flag.
3644 (pop_it): Iterate out of display property for string iteration as
3646 (iterate_out_of_display_property): Support iteration over strings.
3647 (handle_single_display_spec): Set up it->bidi_it for iteration
3648 over a display string, and call bidi_init_it.
3649 (handle_single_display_spec, next_overlay_string)
3650 (get_overlay_strings_1, push_display_prop): Set up the bidi
3651 iterator for displaying display or overlay strings.
3652 (forward_to_next_line_start): Don't use the shortcut if
3654 (back_to_previous_visible_line_start): If handle_display_prop
3655 pushed the iterator stack, restore the internal state of the bidi
3656 iterator by calling bidi_pop_it same number of times.
3657 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3658 and we are bidi-iterating, don't decrement the iterator position;
3659 instead, set the first_elt flag in the bidi iterator, to produce
3661 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3662 (push_display_prop): xassert that we are iterating a buffer.
3663 (push_it, pop_it): Save and restore paragraph_embedding member.
3664 (handle_single_display_spec, next_overlay_string)
3665 (get_overlay_strings_1, reseat_1, reseat_to_string)
3666 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3667 correctly. Don't assume unibyte strings are not bidi-reordered.
3668 (compute_display_string_pos)
3669 (compute_display_string_end): Fix handling the case of C string.
3670 (push_it, pop_it): Save and restore from_disp_prop_p.
3671 (handle_single_display_spec, push_display_prop): Set the
3672 from_disp_prop_p flag.
3673 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3674 (pop_it): Call iterate_out_of_display_property only if we are
3675 popping after iteration over a string that came from a display
3676 property. Fix a typo in popping stretch info. Add an assertion
3677 for verifying that the iterator position is in sync with the bidi
3679 (handle_single_display_spec, get_overlay_strings_1)
3680 (push_display_prop): Fix initialization of paragraph direction for
3681 string when that of the parent object is not yet determined.
3682 (reseat_1): Call bidi_init_it to resync the bidi
3683 iterator with IT's position. (Bug#7616)
3684 (find_row_edges): If ROW->start.pos gives position
3685 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3686 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3687 Reset the from_disp_prop_p flag.
3688 (SAVE_IT, RESTORE_IT): New macros.
3689 (pos_visible_p, face_before_or_after_it_pos)
3690 (back_to_previous_visible_line_start)
3691 (move_it_in_display_line_to, move_it_in_display_line)
3692 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3693 (try_scrolling, redisplay_window, display_line): Use them when
3694 saving a temporary copy of the iterator and restoring it back.
3695 (back_to_previous_visible_line_start, reseat_1)
3696 (init_iterator): Empty the bidi cache "stack".
3697 (move_it_in_display_line_to): If iterator ended up at
3698 EOL, but we never saw any buffer positions smaller than
3699 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3700 motion in bidi-reordered lines.
3701 (move_it_in_display_line_to): Record prev_method and prev_pos
3702 immediately before the call to set_iterator_to_next. Fixes cursor
3703 motion in bidi-reordered lines with stretch glyphs and strings
3704 displayed in margins. (Bug#8133) (Bug#8867)
3705 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3707 (pos_visible_p): Support positions in bidi-reordered lines.
3708 Save and restore bidi cache.
3710 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3711 (bidi_paragraph_info): Delete unused struct.
3712 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3713 (bidi_cache_start): New variable.
3714 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3716 (bidi_cache_fetch_state, bidi_cache_search)
3717 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3718 (bidi_cache_find, bidi_peek_at_next_level)
3719 (bidi_level_of_next_char, bidi_find_other_level_edge)
3720 (bidi_move_to_visually_next): Compare cache index with
3721 bidi_cache_start rather than with zero.
3722 (bidi_fetch_char): Accept new argument STRING; all callers
3723 changed. Support iteration over a string. Support strings with
3724 display properties. Support unibyte strings. Fix the type of
3725 `len' according to what STRING_CHAR_AND_LENGTH expects.
3726 (bidi_paragraph_init, bidi_resolve_explicit_1)
3727 (bidi_resolve_explicit, bidi_resolve_weak)
3728 (bidi_level_of_next_char, bidi_move_to_visually_next):
3729 Support iteration over a string.
3730 (bidi_set_sor_type, bidi_resolve_explicit_1)
3731 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3732 can now be zero (for strings); special values 0 and -1 were
3733 changed to -1 and -2, respectively.
3734 (bidi_char_at_pos): New function.
3735 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3736 Call it instead of FETCH_MULTIBYTE_CHAR.
3737 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3738 initialized to valid values.
3739 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3741 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3742 the test for valid cached positions. Fix the logic for looking up
3743 the sentinel state in the cache. GCPRO the Lisp string we are
3745 (bidi_push_it, bidi_pop_it): New functions.
3746 (bidi_initialize): Initialize the bidi cache start stack pointer.
3747 (bidi_cache_ensure_space): New function, refactored from part of
3748 bidi_cache_iterator_state. Don't assume the required size is just
3749 one BIDI_CACHE_CHUNK away.
3750 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3751 (bidi_count_bytes, bidi_char_at_pos): New functions.
3752 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3753 always valid if bidi_cache_idx is valid.
3754 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3755 is valid if it's going to be used.
3756 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3757 (bidi_cache_fetch_state, bidi_cache_search)
3758 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3759 (bidi_cache_iterator_state, bidi_cache_find)
3760 (bidi_find_other_level_edge, bidi_cache_start_stack):
3761 All variables related to cache indices are now EMACS_INT.
3763 * dispextern.h (struct bidi_string_data): New structure.
3764 (struct bidi_it): New member `string'. Make flag members be 1-bit
3765 fields, and put them last in the struct.
3766 (compute_display_string_pos, compute_display_string_end):
3768 (bidi_push_it, bidi_pop_it): Add prototypes.
3769 (struct iterator_stack_entry): New members bidi_p,
3770 paragraph_embedding, and from_disp_prop_p.
3771 (struct it): Member bidi_p is now a bit field 1 bit wide.
3772 (bidi_shelve_cache, bidi_unshelve_cache):
3775 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3776 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3777 and vector-like objects.
3779 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3780 cache around display iteration.
3782 * window.c (Fwindow_end, window_scroll_pixel_based)
3783 (displayed_window_lines, Frecenter): Save and restore the bidi
3784 cache around display iteration.
3786 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3788 * editfns.c (Fdelete_region): Clarify the use of the named
3789 parameters (bug#6788).
3791 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3793 * indent.c (Fvertical_motion): Set and restore w->pointm when
3794 saving and restoring the window's buffer (Bug#9006).
3796 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3798 * editfns.c (Fstring_to_char): Clarify just what is returned
3799 (bug#6576). Text by Eli Zaretskii.
3801 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3803 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3805 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3807 * buffer.c (mmap_find): Fix a typo.
3809 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3811 Fix execution of x selection hooks.
3812 * xselect.c (Qx_lost_selection_functions)
3813 (Qx_sent_selection_functions): New vars.
3814 (syms_of_xselect): DEFSYM them.
3815 (x_handle_selection_request): Pass Qx_sent_selection_functions
3816 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3817 (x_handle_selection_clear,x_clear_frame_selections):
3818 Pass Qx_lost_selection_functions rather than
3819 Vx_lost_selection_functions to Frun_hook_with_args.
3821 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3823 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3824 The old code sometimes used this field without initializing it.
3826 * alloc.c (gc_sweep): Don't read past end of array.
3827 In theory, the old code could also have corrupted Emacs internals,
3828 though it'd be very unlikely.
3830 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3832 * character.c (Fcharacterp): Don't advertise optional ignored
3833 argument. (Bug#4026)
3835 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3837 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3840 * window.c (Fset_window_start): Doc fix (bug#4199).
3841 (Fset_window_hscroll): Ditto.
3843 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3845 Fix minor new problems caught by GCC 4.6.1.
3846 * term.c (init_tty): Remove unused local.
3847 * xsettings.c (store_monospaced_changed): Define this function only
3848 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3851 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3853 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3855 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3857 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3858 are the mini-buffer and the echo area (bug#3320).
3860 * term.c (init_tty): Remove support for supdup, c10 and perq
3861 terminals, which are no longer supported (bug#1482).
3863 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3865 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3867 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3869 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3870 for non-popups (Bug#3642).
3872 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3874 * alloc.c (reset_malloc_hooks): Protoize.
3875 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3876 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3877 * cm.c (losecursor): Likewise.
3878 * data.c (fmod): Likewise.
3879 * dispnew.c (swap_glyphs_in_rows): Likewise.
3880 * emacs.c (memory_warning_signal): Likewise.
3881 * floatfns.c (float_error): Likewise.
3882 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3883 (otf_open, font_otf_capability, generate_otf_features)
3884 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3886 * image.c (pbm_read_file): Likewise.
3887 * indent.c (string_display_width): Likewise.
3888 * intervals.c (check_for_interval, search_for_interval)
3889 (inc_interval_count, count_intervals, root_interval)
3890 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3891 * lread.c (defalias): Likewise.
3892 * ralloc.c (r_alloc_check): Likewise.
3893 * regex.c (set_image_of_range_1, set_image_of_range)
3894 (regex_grow_registers): Likewise.
3895 * sysdep.c (strerror): Likewise.
3896 * termcap.c (valid_filename_p, tprint, main): Likewise.
3897 * tparam.c (main): Likewise.
3898 * unexhp9k800.c (run_time_remap, save_data_space)
3899 (update_file_ptrs, read_header, write_header, calculate_checksum)
3900 (copy_file, copy_rest, display_header): Likewise.
3901 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3903 * xdisp.c (check_it): Likewise.
3904 * xfaces.c (register_color, unregister_color, unregister_colors):
3906 * xfns.c (print_fontset_result): Likewise.
3907 * xrdb.c (member, fatal, main): Likewise.
3909 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3911 Fix minor problems found by static checking (Bug#9031).
3912 * chartab.c (char_table_set_range, map_sub_char_table):
3913 Remove unused locals.
3914 (uniprop_table): Now static.
3915 * composite.c (_work_char): Remove unused static var.
3917 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3919 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3921 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3923 * gtkutil.c (qttip_cb): Remove code without function.
3925 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3927 * w32.c (pthread_sigmask): New stub.
3929 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3931 Use pthread_sigmask, not sigprocmask (Bug#9010).
3932 sigprocmask is portable only for single-threaded applications, and
3933 Emacs can be multi-threaded when it uses GTK.
3934 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3936 * callproc.c (Fcall_process):
3937 * process.c (create_process):
3938 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3939 Use pthread_sigmask, not sigprocmask.
3941 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3943 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3944 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3947 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3949 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3950 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3951 (xg_hide_tooltip): Fix comment.
3953 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3954 in registerServicesMenuSendTypes.
3955 (validRequestorForSendType): Don't check ns_return_types.
3957 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3960 2011-07-08 Jason Rumney <jasonr@gnu.org>
3962 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3963 SH_SHOW for hidden windows (Bug#5482).
3965 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3966 frame struct members of non-existent frames (Bug#6284).
3968 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3970 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3971 variable firstTime not needed on OSX >= 10.6.
3972 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3973 >= 10.5. Use setKnobProportion, setDoubleValue.
3975 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3976 (MAC_OS_X_VERSION_10_5): Define if not defined.
3977 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3978 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3979 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3981 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3982 cString and lossyCString on OSX >= 10.4
3984 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3985 sizeToFit on OSX >= 10.2.
3987 * nsimage.m (allocInitFromFile): Don't use deprecated method
3988 bestRepresentationForDevice on OSX >= 10.6.
3990 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3993 * emacs.c: Declare unexec_init_emacs_zone.
3995 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3997 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3999 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4000 on svcsMenu (Bug#8842).
4002 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4004 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4006 * nsterm.m (QUTF8_STRING): Declare.
4007 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4008 (validRequestorForSendType): Return type is (id).
4009 Change indexOfObjectIdenticalTo to indexOfObject.
4010 Check if we have local selection before returning self (Bug#8842).
4011 (writeSelectionToPasteboard): Put local selection into paste board
4012 if we have a local selection (Bug#8842).
4013 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4015 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4016 (ns_get_local_selection): Declare.
4018 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4020 * keymap.c (describe_map_tree): Don't insert a double newline at
4021 the end of the buffer (bug#1169) and return whether we inserted
4024 * callint.c (Fcall_interactively): Change "reading args" to
4025 "providing args" to try to clarify what it does (bug#1010).
4027 2011-07-07 Kenichi Handa <handa@m17n.org>
4029 * composite.c (composition_compute_stop_pos): Ignore a static
4030 composition starting before CHARPOS (Bug#8915).
4032 * xdisp.c (handle_composition_prop): Likewise.
4034 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4036 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4039 2011-07-07 Kenichi Handa <handa@m17n.org>
4041 * character.h (unicode_category_t): New enum type.
4043 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4044 (Qchar_code_property_table): New variable.
4045 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4046 (UNIPROP_COMPRESSED_FORM_P): New macros.
4047 (char_table_ascii): Uncompress the compressed values.
4048 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4049 Uncompress the compressed values.
4050 (sub_char_table_ref_and_range): Likewise.
4051 (char_table_ref_and_range): Uncompress the compressed values.
4052 (sub_char_table_set): New arg is_uniprop. Callers changed.
4053 Uncompress the compressed values.
4054 (sub_char_table_set_range): Args changed. Callers changed.
4055 (char_table_set_range): Adjuted for the above change.
4056 (map_sub_char_table): Delete args default_val and parent. Add arg
4057 top. Give decoded values to a Lisp function.
4058 (map_char_table): Adjust for the above change. Give decoded
4059 values to a Lisp function. Gcpro more variables.
4060 (uniprop_table_uncompress)
4061 (uniprop_decode_value_run_length): New functions.
4062 (uniprop_decoder, uniprop_decoder_count): New variables.
4063 (uniprop_get_decoder, uniprop_encode_value_character)
4064 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4066 (uniprop_encoder, uniprop_encoder_count): New variables.
4067 (uniprop_get_encoder, uniprop_table)
4068 (Funicode_property_table_internal, Fget_unicode_property_internal)
4069 (Fput_unicode_property_internal): New functions.
4070 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4071 Sunicode_property_table_internal, Sget_unicode_property_internal,
4072 and Sput_unicode_property_internal. Defvar_lisp
4073 char-code-property-alist.
4075 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4076 Vunicode_category_table.
4078 * font.c (font_range): Adjust for the change of
4079 Vunicode_category_table.
4081 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4083 * m/iris4d.h: Remove file, move contents ...
4084 * s/irix6-5.h: ... here.
4086 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4088 Remove unportable assumption about struct layout (Bug#8884).
4089 * alloc.c (mark_buffer):
4090 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4091 (clone_per_buffer_values): Don't assume that
4092 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4093 This isn't true in general, and it's particularly not true
4094 if Emacs is configured with --with-wide-int.
4095 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4096 New macros, used in the buffer.c change.
4098 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4100 * xsettings.c: Use both GConf and GSettings if both are available.
4101 (store_config_changed_event): Add comment.
4102 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4103 (store_tool_bar_style_changed): New functions.
4104 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4105 (struct xsettings): Move font inside HAVE_XFT.
4106 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4107 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4108 Move inside HAVE_XFT.
4109 (something_changed_gsettingsCB): Rename from something_changedCB.
4110 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4112 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4113 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4114 (something_changed_gconfCB): Rename from something_changedCB.
4115 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4116 (parse_settings): Move check for font inside HAVE_XFT.
4117 (read_settings, apply_xft_settings): Add comment.
4118 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4119 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4120 call store_font_name_changed.
4121 (xft_settings_event): Add comment.
4122 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4123 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4124 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4125 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4126 (xsettings_initialize): Call init_gsettings last.
4127 (xsettings_get_system_font, xsettings_get_system_normal_font):
4130 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4132 Random fixes. E.g., (random) never returned negative values.
4133 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4134 subseconds part to the entropy, as that's a bit more random.
4135 Prefer signed to unsigned, since the signedness doesn't matter and
4136 in general we prefer signed. When given a limit, use a
4137 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4138 latter isn't right if USE_2_TAGS_FOR_INTS.
4139 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4140 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4142 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4144 * textprop.c (text_property_stickiness):
4145 Obey Vtext_property_default_nonsticky.
4146 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4147 * w32fns.c (syms_of_w32fns):
4148 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4150 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4152 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4153 This is more efficient than Ffile_directory_p and avoids a minor race.
4155 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4157 * buffer.c (Foverlay_put): Say what the return value is
4160 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4161 is a directory before asking whether to use the file name
4163 (barf_or_query_if_file_exists): Make the "File is a directory"
4164 error be more correct.
4166 * fns.c (Frequire): Remove the mention of the .gz files, since
4167 that's installation-specific, but keep the mention of
4168 `get-load-suffixes'.
4170 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4172 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4173 Report string overflow if the output is too long.
4175 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4177 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4178 (syms_of_gnutls): Remove duplicate DEFSYM for
4179 Qgnutls_bootprop_verify_hostname_error, an error for
4180 Qgnutls_bootprop_verify_error (which is no longer used).
4182 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4183 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4184 Also (re)move comments that are misplaced or no longer relevant.
4186 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4188 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4190 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4192 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4193 and background color parameters if they have been changed.
4195 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4197 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4199 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4201 * xsettings.c (SYSTEM_FONT): Define only when used.
4202 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4204 * keymap.c (access_keymap_1): Now static.
4206 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4208 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4209 leave any prefix arg for the up event (Bug#1586).
4211 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4213 * lread.c (syms_of_lread): Mention single symbols defined by
4214 `defvar' or `defconst' (bug#7154).
4216 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4217 (Frequire): Mention get-load-suffixes.
4219 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4221 * window.h (window): Remove clone_number slot.
4222 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4224 (make_parent_window, make_window, saved_window)
4225 (Fset_window_configuration, save_window_save): Don't deal with
4227 * buffer.c (Qclone_number): Remove declaration.
4228 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4230 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4232 Add multiple inheritance to keymaps.
4233 * keymap.c (Fmake_composed_keymap): New function.
4234 (Fset_keymap_parent): Simplify.
4235 (fix_submap_inheritance): Remove.
4236 (access_keymap_1): New function extracted from access_keymap to handle
4237 embedded parents and handle lists of maps.
4238 (access_keymap): Use it.
4239 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4240 (Fcopy_keymap): Handle embedded parents.
4241 (Fcommand_remapping, define_as_prefix): Simplify.
4242 (Fkey_binding): Simplify.
4243 (syms_of_keymap): Move minibuffer-local-completion-map,
4244 minibuffer-local-filename-completion-map,
4245 minibuffer-local-must-match-map, and
4246 minibuffer-local-filename-must-match-map to Elisp.
4247 (syms_of_keymap): Defsubr make-composed-keymap.
4248 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4249 (parse_menu_item): Trivial simplification.
4251 2011-07-01 Glenn Morris <rgm@gnu.org>
4253 * Makefile.in (SETTINGS_LIBS): Fix typo.
4255 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4257 * coding.c (Fencode_coding_string): Record the last coding system
4258 used, as the function doc string says (bug#8738).
4260 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4262 * xsettings.c (store_monospaced_changed): Take new font as arg and
4263 check for change against current_mono_font.
4264 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4265 (emacs_settings_constructor, emacs_settings_get_property)
4266 (emacs_settings_set_property, emacs_settings_class_init)
4267 (emacs_settings_init, gsettings_obj): Remove.
4268 (something_changedCB): New function for HAVE_GSETTINGS.
4269 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4270 with value as argument.
4271 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4272 g_settings_new (Bug#8967). Do not create gsettings_obj.
4273 Remove calls to g_settings_bind. Connect something_changedCB to
4276 * xgselect.c: Add defined (HAVE_GSETTINGS).
4277 (xgselect_initialize): Ditto.
4279 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4280 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4283 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4285 * eval.c (struct backtrace): Simplify and port the data structure.
4286 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4287 signed bit field, as this assumption is not portable and it makes
4288 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4289 "char debug_on_exit : 1" as this is not portable either; instead,
4290 use the portable "unsigned int debug_on_exit : 1". Remove unused
4291 member evalargs. Remove obsolete comments about cc bombing out.
4293 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4295 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4296 Let HAVE_GSETTINGS override HAVE_GCONF.
4297 (store_monospaced_changed): New function.
4298 (EMACS_SETTINGS): A new type derived from GObject to handle
4299 GSettings notifications.
4300 (emacs_settings_constructor, emacs_settings_get_property)
4301 (emacs_settings_set_property, emacs_settings_class_init):
4303 (gsettings_client, gsettings_obj): New variables.
4304 (GSETTINGS_SCHEMA): New define.
4305 (something_changedCB): Call store_monospaced_changed.
4306 (init_gsettings): New function.
4307 (xsettings_initialize): Call init_gsettings.
4308 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4311 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4314 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4316 * window.c (resize_root_window, grow_mini_window)
4317 (shrink_mini_window): Rename Qresize_root_window to
4318 Qwindow_resize_root_window and Qresize_root_window_vertically to
4319 Qwindow_resize_root_window_vertically.
4321 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4323 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4325 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4327 * makefile.w32-in: Redesign dependencies so they reflect more
4328 clearly which files are directly included by each source file,
4329 and not through other includes.
4331 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4333 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4334 (sort_overlays, overlay_strings): When an overlay's clone number
4335 matches the window's clone number process the overlay even if
4336 the overlay's window property doesn't match the current window.
4338 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4339 (Fwindow_hchild): Rename to Fwindow_left_child.
4340 (Fwindow_next): Rename to Fwindow_next_sibling.
4341 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4342 (resize_window_check): Rename to window_resize_check.
4343 (resize_window_apply): Rename to window_resize_apply.
4344 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4345 (Fdelete_other_windows_internal, resize_frame_windows)
4346 (Fsplit_window_internal, Fdelete_window_internal)
4347 (grow_mini_window, shrink_mini_window)
4348 (Fresize_mini_window_internal): Fix callers accordingly.
4350 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4352 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4353 (emacs_fixed_set_min_size): Remove.
4354 (emacs_fixed_new): Take frame as argument.
4356 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4357 (_EmacsFixedPrivate): Remove minwidth/height.
4358 Add struct frame *f.
4359 (emacs_fixed_init): Initialize priv->f.
4360 (get_parent_class, emacs_fixed_set_min_size): Remove.
4361 (emacs_fixed_new): Set priv->f to argument.
4362 (emacs_fixed_get_preferred_width)
4363 (emacs_fixed_get_preferred_height): Use min_width/height from
4364 frames size_hint to set minimum and natural (Bug#8919).
4365 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4366 and use min_width/height from frames size_hint to set
4367 min_width/height (Bug#8919).
4369 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4370 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4373 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4375 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4376 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4379 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4381 * process.c (wait_reading_process_output): Bypass select if
4382 waiting for a cell while ignoring keyboard input, and input is
4383 pending. Suggested by Jan Djärv (Bug#8869).
4385 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4387 Use gnulib's dup2 module instead of rolling our own.
4388 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4390 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4392 * dispnew.c (scrolling_window): Before scrolling, turn off a
4393 mouse-highlight in the window being scrolled.
4395 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4397 Move DEFSYM to lisp.h and use everywhere.
4399 * character.h (DEFSYM): Move declaration...
4400 * lisp.h (DEFSYM): ...here.
4406 * w32select.c: Don't include character.h.
4408 * alloc.c (syms_of_alloc):
4409 * buffer.c (syms_of_buffer):
4410 * bytecode.c (syms_of_bytecode):
4411 * callint.c (syms_of_callint):
4412 * casefiddle.c (syms_of_casefiddle):
4413 * casetab.c (init_casetab_once):
4414 * category.c (init_category_once, syms_of_category):
4415 * ccl.c (syms_of_ccl):
4416 * cmds.c (syms_of_cmds):
4417 * composite.c (syms_of_composite):
4418 * dbusbind.c (syms_of_dbusbind):
4419 * dired.c (syms_of_dired):
4420 * dispnew.c (syms_of_display):
4421 * doc.c (syms_of_doc):
4422 * editfns.c (syms_of_editfns):
4423 * emacs.c (syms_of_emacs):
4424 * eval.c (syms_of_eval):
4425 * fileio.c (syms_of_fileio):
4426 * fns.c (syms_of_fns):
4427 * frame.c (syms_of_frame):
4428 * fringe.c (syms_of_fringe):
4429 * insdel.c (syms_of_insdel):
4430 * keymap.c (syms_of_keymap):
4431 * lread.c (init_obarray, syms_of_lread):
4432 * macros.c (syms_of_macros):
4433 * msdos.c (syms_of_msdos):
4434 * print.c (syms_of_print):
4435 * process.c (syms_of_process):
4436 * search.c (syms_of_search):
4437 * sound.c (syms_of_sound):
4438 * syntax.c (init_syntax_once, syms_of_syntax):
4439 * terminal.c (syms_of_terminal):
4440 * textprop.c (syms_of_textprop):
4441 * undo.c (syms_of_undo):
4442 * w32.c (globals_of_w32):
4443 * window.c (syms_of_window):
4444 * xdisp.c (syms_of_xdisp):
4445 * xfaces.c (syms_of_xfaces):
4446 * xfns.c (syms_of_xfns):
4447 * xmenu.c (syms_of_xmenu):
4448 * xsettings.c (syms_of_xsettings):
4449 * xterm.c (syms_of_xterm): Use DEFSYM.
4451 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4453 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4455 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4457 Integer and buffer overflow fixes (Bug#8873).
4459 * print.c (printchar, strout): Check for string overflow.
4460 (PRINTPREPARE, printchar, strout):
4461 Don't set size unless allocation succeeds.
4463 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4464 for sizes. Check for string overflow more accurately.
4465 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4467 * macros.c: Integer and buffer overflow fixes.
4468 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4469 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4470 Use ptrdiff_t, not int, for sizes.
4471 Don't increment bufsize until after realloc succeeds.
4472 Check for size-calculation overflow.
4473 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4475 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4477 * lread.c: Integer overflow fixes.
4478 (read_integer): Radix is now EMACS_INT, not int,
4479 to improve quality of diagnostics for out-of-range radices.
4480 Calculate buffer size correctly for out-of-range radices.
4481 (read1): Check for integer overflow in radices, and in
4482 read-circle numbers.
4483 (read_escape): Avoid int overflow.
4484 (Fload, openp, read_buffer_size, read1)
4485 (substitute_object_recurse, read_vector, read_list, map_obarray):
4486 Use ptrdiff_t, not int, for sizes.
4487 (read1): Use EMACS_INT, not int, for sizes.
4488 Check for size overflow.
4490 * image.c (cache_image): Check for size arithmetic overflow.
4492 * lread.c: Integer overflow issues.
4493 (saved_doc_string_size, saved_doc_string_length)
4494 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4495 Now ptrdiff_t, not int.
4496 (read1): Don't assume doc string length fits in int. Check for
4497 out-of-range doc string lengths.
4498 (read_list): Don't assume file position fits in int.
4499 (read_escape): Check for hex character overflow.
4501 2011-06-22 Leo Liu <sdl.web@gmail.com>
4503 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4504 Move to minibuffer.el.
4506 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4508 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4509 The following patches are for when GLYPH_DEBUG && !XASSERT.
4510 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4511 * dispnew.c (flush_stdout):
4512 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4513 Mark as externally visible.
4514 * dispnew.c (check_window_matrix_pointers): Now static.
4515 * dispnew.c (window_to_frame_vpos):
4516 * xfns.c (unwind_create_frame):
4517 * xterm.c (x_check_font): Remove unused local.
4518 * scroll.c (CHECK_BOUNDS):
4519 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4520 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4521 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4522 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4523 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4525 (debug_method_add): Use va_list and vsprintf rather than relying
4526 on undefined behavior with wrong number of arguments.
4527 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4528 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4529 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4530 since we're not interested in debugging glyphs with old libraries.
4531 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4532 GCC 4.6.0's static checking.
4534 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4536 Integer overflow and signedness fixes (Bug#8873).
4537 A few related buffer overrun fixes, too.
4539 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4541 * dispextern.h (struct face.stipple):
4542 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4543 (x_bitmap_mask, x_allocate_bitmap_record)
4544 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4545 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4546 (x_create_bitmap_from_xpm_data):
4547 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4548 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4550 * xfaces.c (load_pixmap):
4551 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4552 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4553 (.bitmaps_last, struct x_output.icon_bitmap):
4554 Use ptrdiff_t, not int, for bitmap indexes.
4555 (x_allocate_bitmap_record): Check for size overflow.
4556 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4558 Use ptrdiff_t, not int, for overlay counts.
4559 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4560 * editfns.c (overlays_around, get_pos_property):
4561 * textprop.c (get_char_property_and_overlay):
4562 * xdisp.c (next_overlay_change, note_mouse_highlight):
4563 * xfaces.c (face_at_buffer_position):
4564 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4565 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4566 (Fnext_overlay_change, Fprevious_overlay_change)
4567 (mouse_face_overlay_overlaps, Foverlays_in):
4568 Use ptrdiff_t, not int, for sizes.
4569 (overlays_at, overlays_in): Check for size-calculation overflow.
4571 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4573 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4574 (x_session_initialize): Do not assume string length fits in int.
4576 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4577 This is unlikely, but can occur if DPI is outlandish.
4579 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4580 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4582 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4583 * xrdb.c (magic_file_p, search_magic_path):
4584 Omit last arg SUFFIX; it was always 0. All callers changed.
4585 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4587 * xfont.c (xfont_match): Avoid need for strlen.
4589 * xfns.c: Don't assume strlen fits in int.
4590 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4592 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4593 not unsigned long, as we prefer signed integers. All callers changed.
4594 Detect integer overflow in repeat count.
4595 (message_dolog): Don't assume print length fits in 39 bytes.
4596 (display_mode_element): Don't assume strlen fits in int.
4598 * termcap.c: Don't assume sizes fit in int and never overflow.
4599 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4600 (gobble_line): Check for size-calculation overflow.
4602 * minibuf.c (Fread_buffer):
4603 * lread.c (intern, intern_c_string):
4604 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4605 Don't assume string length fits in int.
4607 * keyboard.c (parse_tool_bar_item):
4608 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4610 * font.c: Don't assume string length fits in int.
4611 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4612 Use ptrdiff_t, not int.
4613 (font_intern_prop): Don't assume string length fits in int.
4614 Don't assume integer property fits in fixnum.
4615 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4617 * filelock.c: Fix some buffer overrun and integer overflow issues.
4618 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4619 Reformulate so as not to need the command string.
4620 Invoke gzip -cd rather than gunzip, as it's more portable.
4621 (lock_info_type, lock_file_1, lock_file):
4622 Don't assume pid_t and time_t fit in unsigned long.
4623 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4624 (current_lock_owner): Prefer signed type for sizes.
4625 Use memcpy, not strncpy, where memcpy is what is really wanted.
4626 Don't assume (via atoi) that time_t and pid_t fit in int.
4627 Check for time_t and/or pid_t out of range, e.g., via a network share.
4628 Don't alloca where an auto var works fine.
4630 * fileio.c: Fix some integer overflow issues.
4631 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4632 Don't assume string length fits in int.
4633 (directory_file_name): Don't assume string length fits in long.
4634 (make_temp_name): Don't assume pid fits in int, or that its print
4635 length is less than 20.
4637 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4639 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4641 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4643 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4644 We prefer signed integers, even for size calculations.
4646 * emacs.c: Don't assume string length fits in 'int'.
4647 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4648 (main): Don't invoke strlen when not needed.
4650 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4651 (XD_DEBUG_MESSAGE): Don't waste a byte.
4653 * callproc.c (getenv_internal_1, getenv_internal)
4655 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4657 * lread.c (invalid_syntax): Omit length argument.
4658 All uses changed. This doesn't fix a bug, but it simplifies the
4659 code away from its former Hollerith-constant appearance, and it's
4660 one less 'int' to worry about when looking at integer-overflow issues.
4661 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4663 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4664 This didn't break anything, but it didn't help either.
4665 It's confusing to put a bogus integer in a place where the actual
4666 value does not matter.
4667 (LIST_END_P): Remove unused macro and its bogus comment.
4668 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4670 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4671 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4673 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4674 We prefer signed types, and the value cannot exceed the EMACS_INT
4675 range anyway (because otherwise the length would not be representable).
4676 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4677 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4678 This avoids a GCC warning when WIDE_EMACS_INT.
4680 * indent.c (sane_tab_width): New function.
4681 (current_column, scan_for_column, Findent_to, position_indentation)
4682 (compute_motion): Use it. This is just for clarity.
4683 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4685 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4687 * lisp.h (lint_assume): New macro.
4688 * composite.c (composition_gstring_put_cache):
4689 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4691 * editfns.c, insdel.c:
4692 Omit unnecessary forward decls, to simplify future changes.
4694 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4696 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4698 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4699 Use much-faster test for byte-length change.
4700 Don't assume string byte-length fits in 'int'.
4701 Check that character arg fits in 'int'.
4702 (mapcar1): Declare byte as byte, for clarity.
4704 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4706 * fns.c (concat): Catch string overflow earlier.
4707 Do not rely on integer wraparound.
4709 * dispextern.h (struct it.overlay_strings_charpos)
4710 (struct it.selective): Now EMACS_INT, not int.
4711 * xdisp.c (forward_to_next_line_start)
4712 (back_to_previous_visible_line_start)
4713 (reseat_at_next_visible_line_start, next_element_from_buffer):
4714 Don't arbitrarily truncate the value of 'selective' to int.
4716 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4718 * composite.c: Don't truncate sizes to 'int'.
4719 (composition_gstring_p, composition_reseat_it)
4720 (composition_adjust_point): Use EMACS_INT, not int.
4721 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4722 not EMACS_UINT, for indexes.
4724 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4726 * buffer.c: Include <verify.h>.
4727 (struct sortvec.priority, struct sortstr.priority):
4728 Now EMACS_INT, not int.
4729 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4730 (struct sortstr.size, record_overlay_string)
4731 (struct sortstrlist.size, struct sortlist.used):
4732 Don't truncate size to int.
4733 (record_overlay_string): Check for size-calculation overflow.
4734 (init_buffer_once): Check at compile-time, not run-time.
4736 2011-06-22 Jim Meyering <meyering@redhat.com>
4738 Don't leak an XBM-image-sized buffer
4739 * image.c (xbm_load): Free the image buffer after using it.
4741 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4744 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4745 that Sun C diagnosed.
4746 * fns.c (secure_hash): Fix pointer signedness issue.
4747 * intervals.c (static_offset_intervals): New function.
4748 (offset_intervals): Use it.
4750 2011-06-21 Leo Liu <sdl.web@gmail.com>
4753 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4756 * fns.c (secure_hash): Rename from crypto_hash_function and change
4757 the first arg to accept symbols.
4758 (Fsecure_hash): New primitive.
4759 (syms_of_fns): New symbols.
4761 2011-06-20 Deniz Dogan <deniz@dogan.se>
4763 * process.c (Fset_process_buffer): Clarify return value in
4766 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4768 * dispnew.c (add_window_display_history): Use BVAR.
4770 * xdisp.c (debug_method_add): Use BVAR.
4771 (check_window_end, dump_glyph_matrix, dump_glyph)
4772 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4774 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4777 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4778 check till after the cache is created in init_frame_faces.
4780 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4782 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4784 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4786 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4787 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4788 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4790 Improve buffer-overflow checking (Bug#8873).
4791 * fileio.c (Finsert_file_contents):
4792 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4793 Remove the old (too-loose) buffer overflow checks.
4794 They weren't needed, since make_gap checks for buffer overflow.
4795 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4796 The old code merely checked for Emacs fixnum overflow, and relied
4797 on undefined (wraparound) behavior. The new code avoids undefined
4798 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4800 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4801 Tune. Don't use wider integers than needed. Don't use alloca.
4802 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4804 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4806 * insdel.c, lisp.h (buffer_overflow): New function.
4807 (insert_from_buffer_1, replace_range, replace_range_2):
4808 * insdel.c (make_gap_larger):
4809 * editfns.c (Finsert_char):
4810 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4812 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4814 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4816 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4818 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4819 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4821 * fileio.c: Don't assume EMACS_INT fits in off_t.
4822 (emacs_lseek): New static function.
4823 (Finsert_file_contents, Fwrite_region): Use it.
4824 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4826 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4828 * fns.c: Don't overflow int when computing a list length.
4829 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4830 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4831 truncation on 64-bit hosts. Check for QUIT every
4832 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4833 faster and is responsive enough.
4834 (Flength): Report an error instead of overflowing an integer.
4835 (Fsafe_length): Return a float if the value is not representable
4836 as a fixnum. This shouldn't happen except in contrived situations.
4837 (Fnthcdr, Fsort): Don't assume list length fits in int.
4838 (Fcopy_sequence): Don't assume vector length fits in int.
4840 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4841 (header_size, word_size): New constants.
4842 (allocate_vectorlike): Don't check size overflow here.
4843 (allocate_vector): Check it here instead, since this is the only
4844 caller of allocate_vectorlike that could cause overflow.
4845 Check that the new vector's length is representable as a fixnum.
4847 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4848 The previous code was bogus. For example, next_almost_prime (32)
4849 returned 39, which is undesirable as it is a multiple of 3; and
4850 next_almost_prime (24) returned 25, which is a multiple of 5 so
4851 why was the code bothering to check for multiples of 7?
4853 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4855 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4857 Variadic C functions now count arguments with ptrdiff_t.
4858 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4859 Back then I didn't know that the Emacs coding style prefers signed int.
4860 Also, in the meantime I found a few more instances where arguments
4861 were being counted with int, which may truncate counts on 64-bit
4862 machines, or EMACS_INT, which may be unnecessarily wide.
4863 * lisp.h (struct Lisp_Subr.function.aMANY)
4864 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4865 Arg counts are now ptrdiff_t, not size_t.
4866 All variadic functions and their callers changed accordingly.
4867 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4868 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4869 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4870 * callint.c (Fcall_interactively): Check arg count for overflow,
4871 to avoid potential buffer overrun. Use signed char, not 'int',
4872 for 'varies' array, so that we needn't bother to check its size
4873 calculation for overflow.
4874 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4875 * eval.c (apply_lambda):
4876 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4877 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4878 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4880 * callint.c (Fcall_interactively): Don't use index var as event count.
4882 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4883 * mem-limits.h (SIZE): Remove; no longer used.
4885 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4887 Remove unnecessary casts.
4888 * xterm.c (x_term_init):
4889 * xfns.c (x_set_border_pixel):
4890 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4891 These aren't needed now that we assume ANSI C.
4893 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4894 It's more likely to cause problems (due to unsigned overflow)
4897 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4899 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4901 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4903 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4905 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4907 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4909 GLYPH_CODE_FACE returns EMACS_INT, not int.
4910 * dispextern.h (merge_faces):
4911 * xfaces.c (merge_faces):
4912 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4913 Don't assume EMACS_INT fits in int.
4915 * character.h (CHAR_VALID_P): Remove unused parameter.
4916 * fontset.c, lisp.h, xdisp.c: All uses changed.
4918 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4920 * fns.c (concat): Minor tuning based on overflow analysis.
4921 This doesn't fix any bugs. Use int to hold character, instead
4922 of constantly refetching from Emacs object. Use XFASTINT, not
4923 XINT, for value known to be a character. Don't bother comparing
4924 a single byte to 0400, as it's always less.
4926 * floatfns.c (Fexpt):
4927 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4929 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4932 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4934 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4935 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4936 incorrectly succeed when S was a string, because 4294967386 was
4937 truncated before it was used.
4939 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4940 Otherwise, an out-of-range integer could cause undefined behavior
4943 * composite.c: Use int, not EMACS_INT, for characters.
4944 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4945 EMACS_INT, for values that are known to be in character range.
4946 This doesn't fix any bugs but is the usual style inside Emacs and
4947 may generate better code on 32-bit machines.
4949 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4950 This is for reasons similar to the recent CHAR_STRING fix.
4951 * charset.c (Fencode_char): Check that character arg is actually
4952 a character. Pass an int to ENCODE_CHAR.
4953 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4954 wider than 'int', as a compile-time check to prevent future regressions
4957 * character.c (char_string): Remove unnecessary casts.
4959 Make sure a 64-bit char is never passed to CHAR_STRING.
4960 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4961 by silently ignoring the top 32 bits, allowing some values
4962 that were far too large to be valid characters.
4963 * character.h: Include <verify.h>.
4964 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4965 arguments are no wider than unsigned, as a compile-time check
4966 to prevent future regressions in this area.
4968 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4969 (Fsubst_char_in_region):
4971 * xdisp.c (decode_mode_spec_coding):
4972 Adjust to CHAR_STRING's new requirement.
4973 * editfns.c (Finsert_char, Fsubst_char_in_region):
4974 * fns.c (concat): Check that character args are actually
4975 characters. Without this test, these functions did the wrong
4976 thing with wildly out-of-range values on 64-bit hosts.
4978 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4979 These casts should not be needed on 32-bit hosts, either.
4980 * keyboard.c (read_char):
4981 * lread.c (Fload): Remove casts to unsigned.
4983 * lisp.h (UNSIGNED_CMP): New macro.
4984 This fixes comparison bugs on 64-bit hosts.
4985 (ASCII_CHAR_P): Use it.
4986 * casefiddle.c (casify_object):
4987 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4988 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4989 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4990 * dispextern.h (FACE_FROM_ID):
4991 * keyboard.c (read_char): Use UNSIGNED_CMP.
4993 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4994 not to EMACS_INT, to avoid GCC warning.
4996 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4998 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4999 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5000 isn't needed on 32-bit machines.
5002 * buffer.c (Fgenerate_new_buffer_name):
5003 Use EMACS_INT for count, not int.
5004 (advance_to_char_boundary): Return EMACS_INT, not int.
5006 * data.c (Qcompiled_function): Now static.
5008 * window.c (window_body_lines): Now static.
5010 * image.c (gif_load): Rename local to avoid shadowing.
5012 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5013 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5014 * alloc.c (make_save_value): Integer argument is now of type
5016 (mark_object): Use ptrdiff_t, not int.
5017 * lisp.h (pD): New macro.
5018 * print.c (print_object): Use it.
5020 * alloc.c: Use EMACS_INT, not int, to count objects.
5021 (total_conses, total_markers, total_symbols, total_vector_size)
5022 (total_free_conses, total_free_markers, total_free_symbols)
5023 (total_free_floats, total_floats, total_free_intervals)
5024 (total_intervals, total_strings, total_free_strings):
5025 Now EMACS_INT, not int. All uses changed.
5026 (Fgarbage_collect): Compute overall total using a double, so that
5027 integer overflow is less likely to be a problem. Check for overflow
5028 when converting back to an integer.
5029 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5030 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5031 These were 'int' variables that could overflow on 64-bit hosts;
5032 they were never used, so remove them instead of repairing them.
5033 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5034 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5035 Previously, this ceilinged at INT_MAX, but that doesn't work on
5037 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5039 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5040 (allocate_vectorlike): Check for ptrdiff_t overflow.
5041 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5042 when a (possibly-narrower) signed value would do just as well.
5043 We prefer using signed arithmetic, to avoid comparison confusion.
5045 * alloc.c: Catch some string size overflows that we were missing.
5046 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5047 for convenience in STRING_BYTES_MAX.
5048 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5049 The definition here is exact; the one in lisp.h was approximate.
5050 (allocate_string_data): Check for string overflow. This catches
5051 some instances we weren't catching before. Also, it catches
5052 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5053 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5054 and ptrdiff_t and EMACS_INT are both 64 bits.
5056 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5057 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5058 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5060 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5062 * alloc.c (Fmake_string): Check for out-of-range init.
5064 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5066 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5068 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5070 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5071 xg_get_default_scrollbar_width.
5073 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5074 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5075 (style_changed_cb): Call update_theme_scrollbar_width and call
5076 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5077 all frames (Bug#8505).
5078 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5079 Call gtk_window_set_resizable if HAVE_GTK3.
5080 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5081 and height if HAVE_GTK3 (Bug#8505).
5082 (scroll_bar_width_for_theme): New variable.
5083 (update_theme_scrollbar_width): New function.
5084 (xg_get_default_scrollbar_width): Move code to
5085 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5086 (xg_initialize): Call update_theme_scrollbar_width.
5088 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5090 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5092 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5094 * frame.c (make_frame): Call other_buffer_safely instead of
5097 * window.c (temp_output_buffer_show): Call display_buffer with
5098 second argument Vtemp_buffer_show_specifiers and reset latter
5099 immediately after the call.
5100 (Vtemp_buffer_show_specifiers): New variable.
5101 (auto_window_vscroll_p, next_screen_context_lines)
5102 (Vscroll_preserve_screen_position): Remove leading asterisks from
5105 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5107 Fix minor problems found by GCC 4.6.0 static checking.
5108 * buffer.c (Qclone_number): Remove for now, as it's unused.
5109 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5110 (record_buffer): Remove unused local.
5111 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5112 (set_frame_buffer_list): Remove; unused.
5113 * frame.h (other_visible_frames): Remove decl.
5114 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5115 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5116 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5118 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5119 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5120 Define only if HAVE_GPM.
5121 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5122 (update_hints_inhibit): Remove; never set. All uses removed.
5123 * widgetprv.h (emacsFrameClassRec): Remove decl.
5124 * window.c (delete_deletable_window): Now returns void, since it
5125 wasn't returning anything.
5126 (compare_window_configurations): Remove unused locals.
5127 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5128 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5129 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5130 the same widths as pointers. This follows up on the 2011-05-06 patch.
5131 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5132 * xterm.h: Likewise.
5133 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5135 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5137 * makefile.w32-in: Update dependencies.
5138 (LISP_H): Add lib/intprops.h.
5140 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5142 * image.c (gif_load): Add animation frame delay to the metadata.
5143 (syms_of_image): Use DEFSYM. New symbol `delay'.
5145 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5147 * window.c (delete_deletable_window): Re-add.
5148 (Fset_window_configuration): Rewrite to handle dead buffers and
5149 consequently deletable windows.
5150 (window_tree, Fwindow_tree): Remove. Supply functionality in
5152 (compare_window_configurations): Simplify code.
5154 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5156 * image.c (imagemagick_load_image): Fix type mismatch.
5157 (Fimagemagick_types): Likewise.
5159 * window.h (replace_buffer_in_windows): Declare.
5161 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5163 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5164 Qclone_number. Remove external declaration of Qdelete_window.
5165 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5167 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5168 Run Qbuffer_list_update_hook if allowed.
5169 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5170 buffer list implementation.
5171 (other_buffer_safely): New function.
5172 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5173 calls to replace_buffer_in_windows and
5174 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5176 (record_buffer): Inhibit quitting and rewrite using quittable
5177 functions. Run Qbuffer_list_update_hook if allowed.
5178 (Frecord_buffer, Funrecord_buffer): New functions.
5179 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5180 Move switch-to-buffer to window.el.
5181 (bury-buffer): Move to window.el.
5182 (Vbuffer_list_update_hook): New variable.
5184 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5187 * window.h (resize_frame_windows): Move up in code.
5188 (Fwindow_frame): Remove EXFUN.
5189 (replace_buffer_in_all_windows): Remove prototype.
5190 (replace_buffer_in_windows_safely): Add prototype.
5192 * window.c: Declare Qdelete_window static again. Move down
5193 declaration of select_count.
5194 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5195 (Fother_window): Move to window.el.
5196 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5197 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5198 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5200 (replace_buffer_in_windows): Implement by calling
5201 Qreplace_buffer_in_windows.
5202 (replace_buffer_in_all_windows): Remove with some functionality
5203 moved into replace_buffer_in_windows_safely.
5204 (replace_buffer_in_windows_safely): New function.
5205 (select_window_norecord, select_frame_norecord): Move in front
5206 of run_window_configuration_change_hook. Remove now obsolete
5208 (Fset_window_buffer): Rewrite doc-string.
5209 Call Qrecord_window_buffer.
5210 (keys_of_window): Move binding for other-window to window.el.
5212 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5214 * dispextern.h (struct image): Replace data member, whose int_val
5215 and ptr_val fields were not used by anything, with a single
5218 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5219 (gif_clear_image, gif_load, imagemagick_load_image)
5220 (gs_clear_image, gs_load): Callers changed.
5222 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5224 * buffer.h: Include <time.h>, for time_t.
5225 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5227 Fix minor problems found by static checking.
5229 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5231 Make identifiers static if they are not used in other modules.
5232 * data.c (Qcompiled_function, Qframe, Qvector):
5233 * image.c (QimageMagick, Qsvg):
5234 * minibuf.c (Qmetadata):
5235 * window.c (resize_window_check, resize_root_window): Now static.
5236 * window.h (resize_window_check, resize_root_window): Remove decls.
5238 * window.c (window_deletion_count, delete_deletable_window):
5240 (window_body_lines): Now static.
5241 (Fdelete_other_windows_internal): Mark vars as initialized.
5242 Make sure 'resize_failed' is initialized.
5243 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5244 (resize_window_apply): Remove unused local.
5245 * window.h (delete_deletable_window): Remove decl.
5247 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5248 (imagemagick_load_image): Fix pointer signedness problem by changing
5249 last arg from unsigned char * to char *. All uses changed.
5250 Also, fix a local for similar reasons.
5251 Remove unused locals. Remove locals to avoid shadowing.
5252 (fn_rsvg_handle_free): Remove; unused.
5253 (svg_load, svg_load_image): Fix pointer signedness problem.
5254 (imagemagick_load_image): Don't use garbage pointer image_wand.
5256 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5258 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5260 * image.c (gif_load): Fix omitted cast error introduced by
5263 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5265 * window.h (resize_proportionally, orig_total_lines)
5266 (orig_top_line): Remove from window structure.
5267 (set_window_height, set_window_width, change_window_heights)
5268 (Fdelete_window): Remove prototypes.
5269 (resize_frame_windows): Remove duplicate declaration.
5271 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5273 * window.h (resize_frame_windows, resize_window_check)
5274 (delete_deletable_window, resize_root_window)
5275 (resize_frame_windows): Declare prototypes.
5277 * window.c (resize_window_apply): Make definition be "static" to
5278 match the prototype.
5280 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5282 * window.c: Remove declarations of Qwindow_size_fixed,
5283 window_min_size_1, window_min_size_2, window_min_size,
5284 size_window, window_fixed_size_p, enlarge_window, delete_window.
5285 Remove static from declaration of Qdelete_window, it's
5286 temporarily needed by Fbury_buffer.
5287 (replace_window): Don't assign orig_top_line and
5289 (Fdelete_window, delete_window): Remove. Window deletion is
5290 handled by window.el.
5291 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5292 Replace Fdelete_window calls with calls to Qdelete_window.
5293 (Fdelete_other_windows): Remove. Deleting other windows is
5294 handled by window.el.
5295 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5296 handled in window.el.
5297 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5298 Window minimum sizes are handled in window.el.
5299 (shrink_windows, size_window, set_window_height)
5300 (set_window_width, change_window_heights, window_height)
5301 (window_width, CURBEG, CURSIZE, enlarge_window)
5302 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5303 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5304 handled in window.el.
5305 (make_dummy_parent): Rename to make_parent_window and give it a
5306 second argument horflag.
5307 (make_window): Don't set resize_proportionally any more.
5308 (Fsplit_window): Remove. Windows are split in window.el.
5309 (save_restore_action, save_restore_orig_size)
5310 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5311 Resize mini windows in window.el.
5312 (grow_mini_window, shrink_mini_window): Implement by calling
5313 Qresize_root_window_vertically, resize_window_check and
5314 resize_window_apply.
5315 (saved_window, Fset_window_configuration, save_window_save):
5316 Do not handle orig_top_line, orig_total_lines, and
5317 resize_proportionally.
5318 (window_min_height, window_min_width): Move to window.el.
5319 (keys_of_window): Move bindings for delete-other-windows,
5320 split-window, delete-window and enlarge-window to window.el.
5322 * buffer.c: Temporarily extern Qdelete_window.
5323 (Fbury_buffer): Temporarily call Qdelete_window instead of
5324 Fdelete_window (Fbury_buffer will move to window.el soon).
5326 * frame.c (set_menu_bar_lines_1): Remove code handling
5327 orig_top_line and orig_total_lines.
5329 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5330 set_window_height but set heights directly.
5331 (change_frame_size_1): Use resize_frame_windows.
5333 * xdisp.c (init_xdisp): Don't use set_window_height but set
5336 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5337 Use resize_frame_windows instead of change_window_heights and run
5338 run_window_configuration_change_hook.
5340 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5341 instead of change_window_heights and run
5342 run_window_configuration_change_hook.
5344 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5346 * window.c (replace_window): Rename second argument REPLACEMENT to
5347 NEW. New third argument SETFLAG. Rewrite.
5348 (delete_window, make_dummy_parent): Call replace_window with
5350 (window_list_1): Move down in code.
5351 (run_window_configuration_change_hook): Move set_buffer part
5352 before select_frame_norecord part in order to unwind correctly.
5353 Rename count1 to count.
5354 (recombine_windows, delete_deletable_window, resize_root_window)
5355 (Fdelete_other_windows_internal)
5356 (Frun_window_configuration_change_hook, make_parent_window)
5357 (resize_window_check, resize_window_apply, Fresize_window_apply)
5358 (resize_frame_windows, Fsplit_window_internal)
5359 (Fdelete_window_internal, Fresize_mini_window_internal):
5361 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5363 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5365 * window.h (window): Add some new members to window structure -
5366 normal_lines, normal_cols, new_total, new_normal, clone_number,
5367 splits, nest, prev_buffers, next_buffers.
5368 (WINDOW_TOTAL_SIZE): Move here from window.c.
5369 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5371 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5373 (make_dummy_parent): Set new members of windows structure.
5374 (make_window): Move down in code. Handle new members of window
5376 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5377 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5378 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5379 (Fset_window_prev_buffers, Fwindow_next_buffers)
5380 (Fset_window_next_buffers, Fset_window_clone_number):
5382 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5383 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5385 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5386 Argument WINDOW can be now internal window too.
5387 (Fwindow_use_time): Move up in code.
5388 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5390 (Fset_window_configuration, saved_window)
5391 (Fcurrent_window_configuration, save_window_save): Handle new
5392 members of window structure.
5393 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5394 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5395 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5396 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5397 Qget_mru_window, Qresize_root_window,
5398 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5399 Qauto_buffer_name; staticpro them.
5401 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5403 * window.c (Fwindow_total_size, Fwindow_left_column)
5404 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5405 (Fwindow_list_1): New functions.
5406 (window_box_text_cols): Replace with window_body_cols.
5407 (Fwindow_width, Fscroll_left, Fscroll_right):
5408 Use window_body_cols instead of window_box_text_cols.
5409 (delete_window, Fset_window_configuration):
5410 Call delete_all_subwindows with window as argument.
5411 (delete_all_subwindows): Take a window as argument and not a
5413 (window_loop): Remove handling of GET_LRU_WINDOW and
5415 (Fget_lru_window, Fget_largest_window): Move to window.el.
5417 * window.h: Extern window_body_cols instead of
5418 window_box_text_cols. delete_all_subwindows now takes a
5419 Lisp_Object as argument.
5421 * indent.c (compute_motion, Fcompute_motion):
5422 Use window_body_cols instead of window_box_text_cols.
5424 * frame.c (delete_frame): Call delete_all_subwindows with root
5427 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5429 * fns.c (Fputhash): Document return value.
5431 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5433 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5435 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5437 Cons<->int and similar integer overflow fixes (Bug#8794).
5439 Check for overflow when converting integer to cons and back.
5440 * charset.c (Fdefine_charset_internal, Fdecode_char):
5441 Use cons_to_unsigned to catch overflow.
5442 (Fencode_char): Use INTEGER_TO_CONS.
5443 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5444 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5445 * data.c (long_to_cons, cons_to_long): Remove.
5446 (cons_to_unsigned, cons_to_signed): New functions.
5447 These signal an error for invalid or out-of-range values.
5448 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5449 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5450 * font.c (Ffont_variation_glyphs):
5451 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5452 * lisp.h: Include <intprops.h>.
5453 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5454 (cons_to_signed, cons_to_unsigned): New decls.
5455 (long_to_cons, cons_to_long): Remove decls.
5456 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5457 (Fprimitive_undo): Use CONS_TO_INTEGER.
5458 * xfns.c (Fx_window_property): Likewise.
5459 * xselect.c: Include <limits.h>.
5460 (x_own_selection, selection_data_to_lisp_data):
5461 Use INTEGER_TO_CONS.
5462 (x_handle_selection_request, x_handle_selection_clear)
5463 (x_get_foreign_selection, Fx_disown_selection_internal)
5464 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5465 (lisp_data_to_selection_data): Use cons_to_unsigned.
5466 (x_fill_property_data): Use cons_to_signed.
5467 Report values out of range.
5469 Check for buffer and string overflow more precisely.
5470 * buffer.h (BUF_BYTES_MAX): New macro.
5471 * lisp.h (STRING_BYTES_MAX): New macro.
5472 * alloc.c (Fmake_string):
5473 * character.c (string_escape_byte8):
5474 * coding.c (coding_alloc_by_realloc):
5475 * doprnt.c (doprnt):
5476 * editfns.c (Fformat):
5478 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5479 since they may not be the same number.
5480 * editfns.c (Finsert_char):
5481 * fileio.c (Finsert_file_contents):
5482 Likewise for BUF_BYTES_MAX.
5484 * image.c: Use ptrdiff_t, not int, for sizes.
5485 (slurp_file): Switch from int to ptrdiff_t.
5487 (slurp_file): Check that file size fits in both size_t (for
5488 malloc) and ptrdiff_t (for sanity and safety).
5490 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5491 if b->modtime has its maximal value.
5493 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5495 Don't assume time_t can fit into int.
5496 * buffer.h (struct buffer.modtime): Now time_t, not int.
5497 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5498 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5500 Minor fixes for signed vs unsigned integers.
5501 * character.h (MAYBE_UNIFY_CHAR):
5502 * charset.c (maybe_unify_char):
5503 * keyboard.c (read_char, reorder_modifiers):
5504 XINT -> XFASTINT, since the integer must be nonnegative.
5505 * ftfont.c (ftfont_spec_pattern):
5506 * keymap.c (access_keymap, silly_event_symbol_error):
5507 XUINT -> XFASTINT, since the integer must be nonnegative.
5508 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5509 since it makes no difference and we prefer signed.
5510 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5511 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5514 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5516 * window.h (Fwindow_frame): Declare.
5518 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5520 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5521 (SPARE_MEMORY): Always define.
5522 (LARGE_REQUEST): Remove.
5523 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5525 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5527 * lisp.h: Move EXFUNS for Fframe_root_window,
5528 Fframe_first_window and Fset_frame_selected_window to window.h.
5530 * window.h: Move EXFUNS for Fframe_root_window,
5531 Fframe_first_window and Fset_frame_selected_window here from
5534 * frame.c (Fwindow_frame, Fframe_first_window)
5535 (Fframe_root_window, Fframe_selected_window)
5536 (Fset_frame_selected_window): Move to window.c.
5537 (Factive_minibuffer_window): Move to minibuf.c.
5538 (Fother_visible_frames_p): New function.
5540 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5542 * window.c (decode_window, decode_any_window): Move up in code.
5543 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5544 (inhibit_frame_unsplittable): Remove unused variable.
5545 (Fwindow_buffer): Move up and rewrite doc-string.
5546 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5547 (Fwindow_prev): New functions.
5548 (Fwindow_frame): Move here from frame.c. Accept any window as
5550 (Fframe_root_window, Fframe_first_window)
5551 (Fframe_selected_window): Move here from frame.c. Accept frame
5552 or arbitrary window as argument. Update doc-strings.
5553 (Fminibuffer_window): Move up in code.
5554 (Fwindow_minibuffer_p): Move up in code and simplify.
5555 (Fset_frame_selected_window): Move here from frame.c.
5557 (Fselected_window, select_window, Fselect_window): Move up in
5558 code. Minor doc-string fixes.
5560 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5562 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5563 Do not assume that spare memory exists; that assumption is valid
5564 only if SYSTEM_MALLOC.
5565 (LARGE_REQUEST): New macro, so that the issue of large requests
5566 is separated from the issue of spare memory.
5568 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5570 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5573 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5575 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5578 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5580 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5582 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5584 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5585 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5587 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5589 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5591 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5593 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5594 (x_clipboard_manager_save): Add return value.
5595 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5597 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5598 Obey Vx_select_enable_clipboard_manager. Catch errors in
5599 x_clipboard_manager_save (Bug#8779).
5600 (Vx_select_enable_clipboard_manager): New variable.
5601 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5603 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5605 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5607 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5609 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5610 in the current matrix if keep_current_p is non-zero.
5612 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5614 * bidi.c (bidi_level_of_next_char): Fix last change.
5616 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5618 Support bidi reordering of text covered by display properties.
5620 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5621 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5622 (bidi_cache_search, bidi_cache_iterator_state)
5623 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5624 (bidi_level_of_next_char, bidi_move_to_visually_next):
5625 Support character positions inside a run of characters covered by a
5627 (bidi_paragraph_init, bidi_resolve_explicit_1)
5628 (bidi_level_of_next_char): Call bidi_fetch_char and
5629 bidi_fetch_char_advance instead of FETCH_CHAR and
5631 (bidi_init_it): Initialize new members.
5632 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5634 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5635 instead of using explicit *_CHAR codes.
5636 (bidi_resolve_explicit, bidi_resolve_weak):
5637 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5638 bidirectional text is supported only in multibyte buffers.
5639 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5640 it to initialize the frame_window_p member of struct bidi_it.
5641 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5642 (bidi_resolve_explicit, bidi_resolve_weak)
5643 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5644 bidi_it->nchars is non-positive.
5645 (bidi_level_of_next_char): Don't try to lookup the cache for the
5646 next/previous character if nothing is cached there yet, or if we
5647 were just reseat()'ed to a new position.
5649 * xdisp.c (set_cursor_from_row): Set start and stop points
5650 according to the row's direction when priming the loop that looks
5651 for the glyph on which to display cursor.
5652 (single_display_spec_intangible_p): Function deleted.
5653 (display_prop_intangible_p): Reimplement to call
5654 handle_display_spec instead of single_display_spec_intangible_p.
5655 Accept 3 additional arguments needed by handle_display_spec.
5656 This fixes incorrect cursor motion across display property with complex
5657 values: lists, `(when COND...)' forms, etc.
5658 (single_display_spec_string_p): Support property values that are
5659 lists with the argument STRING its top-level element.
5660 (display_prop_string_p): Fix the condition for processing a
5661 property that is a list to be consistent with handle_display_spec.
5662 (handle_display_spec): New function, refactored from the
5663 last portion of handle_display_prop.
5664 (compute_display_string_pos): Accept additional argument
5665 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5666 value of a `display' property is a "replacing spec".
5667 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5668 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5669 the display property, but just return a value indicating whether
5670 the display property will replace the characters it covers.
5671 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5672 frame_window_p members of struct bidi_it.
5673 (compute_display_string_pos, compute_display_string_end):
5675 (push_it): Accept second argument POSITION, where pop_it should
5676 jump to continue iteration.
5677 (reseat_1): Initialize bidi_it.disp_pos.
5679 * keyboard.c (adjust_point_for_property): Adjust the call to
5680 display_prop_intangible_p to its new signature.
5682 * dispextern.h (struct bidi_it): New member frame_window_p.
5683 (bidi_init_it): Update prototypes.
5684 (display_prop_intangible_p): Update prototype.
5685 (compute_display_string_pos, compute_display_string_end):
5687 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5690 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5692 Malloc failure behavior now depends on size of allocation.
5693 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5694 * lisp.h: Change signatures accordingly.
5695 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5696 All callers changed. (Bug#8762)
5698 * gnutls.c: Use Emacs's memory allocators.
5699 Without this change, the gnutls library would invoke malloc etc.
5700 directly, which causes problems on non-SYNC_INPUT hosts, and which
5701 runs afoul of improving memory_full behavior. (Bug#8761)
5702 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5703 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5704 xfree instead of the default malloc, realloc, free.
5705 (Fgnutls_boot): No need to check for memory allocation failure,
5706 since xmalloc does that for us.
5708 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5709 * category.c (hash_get_category_set):
5710 * ccl.c (ccl_driver):
5711 * charset.c (Fdefine_charset_internal):
5712 * charset.h (struct charset.hash_index):
5713 * composite.c (get_composition_id, gstring_lookup_cache)
5714 (composition_gstring_put_cache):
5715 * composite.h (struct composition.hash_index):
5716 * dispextern.h (struct image.hash):
5717 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5718 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5719 (hashfn_equal, hashfn_user_defined, make_hash_table)
5720 (maybe_resize_hash_table, hash_lookup, hash_put)
5721 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5722 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5723 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5724 * image.c (make_image, search_image_cache, lookup_image)
5725 (xpm_put_color_table_h):
5726 * lisp.h (struct Lisp_Hash_Table):
5727 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5728 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5729 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5730 * alloc.c (allocate_vectorlike):
5731 Check for overflow in vector size calculations.
5732 * ccl.c (ccl_driver):
5733 Check for overflow when converting EMACS_INT to int.
5734 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5735 need to be updated by these changes.
5736 * fns.c (make_hash_table, maybe_resize_hash_table):
5737 Check for integer overflow with large hash tables.
5738 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5739 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5740 (SXHASH_REDUCE): New macro.
5741 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5742 Use it instead of discarding useful hash info with large hash values.
5743 (sxhash_float): New function.
5744 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5745 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5746 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5747 Rewrite to use FIXNUM_BITS, as this simplifies things.
5748 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5749 Adjust signatures to match updated version of code.
5750 (consing_since_gc): Now EMACS_INT, since a single hash table can
5751 use more than INT_MAX bytes.
5753 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5755 Make it possible to build with GCC-4.6+ -O2 -flto.
5757 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5759 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5761 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5762 Call minibuffer-inactive-mode.
5764 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5766 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5767 Update dependencies.
5769 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5771 * data.c (init_data): Remove code for UTS, this system is not
5774 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5776 Don't force ./temacs to start in terminal mode.
5778 * frame.c (make_initial_frame): Initialize faces in all cases, not
5779 only when CANNOT_DUMP is defined.
5780 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5782 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5784 * dispnew.c (add_window_display_history): Use const for the string
5785 pointer. Remove declaration, not needed.
5787 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5789 Use 'inline', not 'INLINE'.
5790 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5791 * alloc.c, fontset.c (INLINE): Remove.
5792 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5793 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5794 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5795 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5796 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5798 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5800 Make it possible to run ./temacs.
5802 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5803 syms_of_callproc does the same thing. Remove test for
5804 "initialized", do it in the caller.
5805 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5807 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5809 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5810 (read_minibuf): Use get_minibuffer.
5811 (syms_of_minibuf): Use DEFSYM.
5812 (Qmetadata): New var.
5813 * data.c (Qbuffer): Don't make it static.
5814 (syms_of_data): Use DEFSYM.
5816 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5818 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5819 (CCL_CODE_MIN): New macro.
5821 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5823 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5825 * eval.c (Qdebug): Now static.
5826 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5827 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5828 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5830 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5832 * image.c: Various fixes to ImageMagick code comments.
5833 (Fimagemagick_types): Doc fix.
5835 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5837 Minor fixes prompted by GCC 4.6.0 warnings.
5839 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5841 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5842 (x_clipboard_manager_save_all): Move extern decl to ...
5843 * xterm.h: ... here, so that it can be checked for consistency.
5845 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5847 * xselect.c (x_clipboard_manager_save_frame)
5848 (x_clipboard_manager_save_all): New functions.
5849 (Fx_clipboard_manager_save): Lisp function deleted.
5851 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5852 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5854 * xterm.h: Update prototype.
5856 2011-05-28 William Xu <william.xwl@gmail.com>
5858 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5861 2011-05-28 Jim Meyering <meyering@redhat.com>
5863 Avoid a sign-extension bug in crypto_hash_function.
5864 * fns.c (to_uchar): Define.
5865 (crypto_hash_function): Use it to convert some newly-signed
5866 variables to unsigned, to avoid sign-extension bugs. For example,
5867 without this change, (md5 "truc") would evaluate to
5868 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5869 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5870 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5872 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5874 Integer overflow fixes.
5876 * dbusbind.c: Serial number integer overflow fixes.
5877 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5878 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5879 to hold a serial number that is too large for a fixnum.
5880 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5881 Check for serial numbers out of range. Decode any serial number
5882 that was so large that it became a float. (Bug#8722)
5884 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5885 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5886 Use XFASTINT rather than XUINT when numbers are nonnegative.
5887 (xd_append_arg, Fdbus_method_return_internal):
5888 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5889 arguments, check that Lisp number is nonnegative, rather than
5890 silently wrapping negative numbers around. (Bug#8722)
5891 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5894 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5896 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5898 ccl: Add integer overflow checks.
5899 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5900 (IN_INT_RANGE): New macros.
5901 (ccl_driver): Use them to check for integer overflow when
5902 decoding a CCL program. Many of the new checks are whether XINT (x)
5903 fits in int; it doesn't always, on 64-bit hosts. The new version
5904 doesn't catch all possible integer overflows, but it's an
5905 improvement. (Bug#8719)
5907 * alloc.c (make_event_array): Use XINT, not XUINT.
5908 There's no need for unsigned here.
5910 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5911 This follows up to the 2011-05-06 change that substituted uintptr_t
5912 for EMACS_INT. This case wasn't caught back then.
5914 Rework Fformat to avoid integer overflow issues.
5915 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5916 now (part of C89). Include <verify.h>.
5917 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5918 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5919 (Fformat): Avoid the prepass trying to compute sizes; it was only
5920 approximate and thus did not catch overflow reliably. Instead, walk
5921 through the format just once, formatting and computing sizes as we go,
5922 checking for integer overflow at every step, and allocating a larger
5923 buffer as needed. Keep track separately whether the format is
5924 multibyte. Keep only the most-recently calculated precision, rather
5925 than them all. Record whether each argument has been converted to
5926 string. Use EMACS_INT, not int, for byte and char and arg counts.
5927 Support field widths and precisions larger than INT_MAX. Avoid
5928 sprintf's undefined behavior with conversion specifications such as %#d
5929 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5930 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5931 formatting out-of-range floating point numbers with int
5934 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5936 * data.c: Avoid integer truncation in expressions involving floats.
5937 * data.c: Include <intprops.h>.
5938 (arith_driver): When there's an integer overflow in an expression
5939 involving floating point, convert the integers to floating point
5940 so that the resulting value does not suffer from catastrophic
5941 integer truncation. For example, on a 64-bit host (* 4
5942 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5943 Do not rely on undefined behavior after integer overflow.
5945 merge count_size_as_multibyte, parse_str_to_multibyte
5946 * character.c, character.h (count_size_as_multibyte):
5947 Rename from parse_str_to_multibyte; all uses changed.
5948 Check for integer overflow.
5949 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5950 since it's now a duplicate of the other. This is more of
5951 a character than a buffer op, so better that it's in character.c.
5952 * fns.c, print.c: Adjust to above changes.
5954 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5956 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5958 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5960 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5961 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5962 (x_clipboard_manager_save): Now static.
5963 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5965 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5966 (crypto_hash_function): Now static.
5967 Fix pointer signedness problems. Avoid unnecessary initializations.
5969 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5971 * termhooks.h (Vselection_alist): Make it terminal-local.
5973 * terminal.c (create_terminal): Initialize it.
5975 * xselect.c: Support for clipboard managers.
5976 (Vselection_alist): Move to termhooks.h as terminal-local var.
5977 (LOCAL_SELECTION): New macro.
5978 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5979 (symbol_to_x_atom): Remove gratuitous arg.
5980 (x_handle_selection_request, lisp_data_to_selection_data)
5981 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5982 (x_own_selection, x_get_local_selection, x_convert_selection):
5983 New arg, specifying work frame. Use terminal-local Vselection_alist.
5984 (some_frame_on_display): Delete unused function.
5985 (Fx_own_selection_internal, Fx_get_selection_internal)
5986 (Fx_disown_selection_internal, Fx_selection_owner_p)
5987 (Fx_selection_exists_p): New optional frame arg.
5988 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5989 (x_handle_selection_clear): Don't treat other terminals with the
5990 same keyboard specially. Use the terminal-local Vselection_alist.
5991 (x_clear_frame_selections): Use Frun_hook_with_args.
5993 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5995 * xterm.h: Add support for those atoms.
5997 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5999 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6000 (converted_selections, conversion_fail_tag): New global variables.
6001 (x_selection_request_lisp_error): Free the above.
6002 (x_get_local_selection): Remove unnecessary code.
6003 (x_reply_selection_request): Args changed; handle arbitrary array
6004 of converted selections stored in converted_selections.
6005 Separate the XChangeProperty and SelectionNotify steps.
6006 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6007 (x_convert_selection): New function.
6008 (x_handle_selection_event): Simplify.
6009 (x_get_foreign_selection): Don't ignore incoming requests while
6010 waiting for an answer; this will fail when we implement
6011 SAVE_TARGETS, and seems unnecessary anyway.
6012 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6013 (Vx_sent_selection_functions): Doc fix.
6015 2011-05-26 Leo Liu <sdl.web@gmail.com>
6017 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6019 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6021 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6023 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6024 for fringe update if it has periodic bitmap.
6025 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6026 and fringe_bitmap_periodic_p.
6028 * fringe.c (get_fringe_bitmap_data): New function.
6029 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6030 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6031 row. Mark glyph row for fringe update if periodicity changed.
6033 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6034 for fringe update unless it has periodic bitmap.
6036 2011-05-25 Kenichi Handa <handa@m17n.org>
6038 * xdisp.c (get_next_display_element): Set correct it->face_id for
6039 a static composition.
6041 2011-05-24 Leo Liu <sdl.web@gmail.com>
6044 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6046 * fns.c (crypto_hash_function, Fsha1): New function.
6047 (Fmd5): Use crypto_hash_function.
6048 (syms_of_fns): Add Ssha1.
6050 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6052 * gnutls.c: Remove unused macros.
6053 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6054 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6055 Remove macros that are defined and never used.
6056 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6058 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6060 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6061 (Fx_get_selection_internal): Minor cleanup.
6062 (Fx_own_selection_internal): Rename arguments for consistency with
6065 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6067 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6069 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6071 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6073 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6075 * dispnew.c (scrolling_window): Don't exclude the case that the
6076 last enabled row in the desired matrix touches the bottom boundary.
6078 2011-05-21 Glenn Morris <rgm@gnu.org>
6080 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6081 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6082 and add some more files.
6084 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6086 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6087 report_file_error introduced by the change from 2011-05-07.
6089 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6091 * systime.h (Time): Define only if emacs is defined.
6092 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6093 where the include path doesn't have X11/X.h by default. See
6094 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6096 2011-05-20 Kenichi Handa <handa@m17n.org>
6098 * composite.c (find_automatic_composition): Fix previous change.
6100 2011-05-20 Glenn Morris <rgm@gnu.org>
6102 * lisp.mk: New file, split from Makefile.in.
6103 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6104 (shortlisp): Remove.
6105 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6107 2011-05-19 Glenn Morris <rgm@gnu.org>
6109 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6110 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6111 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6112 (lisp): Set the order to that of loadup.el.
6113 (shortlisp): Make it a copy of $lisp.
6114 (SOME_MACHINE_LISP): Remove.
6115 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6116 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6118 2011-05-18 Kenichi Handa <handa@m17n.org>
6120 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6121 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6122 (find_automatic_composition): Mostly rewrite for efficiency.
6124 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6126 * makefile.w32-in: Update dependencies.
6128 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6130 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6131 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6133 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6135 Fix some integer overflow issues, such as string length overflow.
6137 * insdel.c (count_size_as_multibyte): Check for string overflow.
6139 * character.c (lisp_string_width): Check for string overflow.
6140 Use EMACS_INT, not int, for string indexes and lengths; in
6141 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6142 the resulting string length overflows an EMACS_INT; instead,
6143 report a string overflow if no precision given. When checking for
6144 precision exhaustion, use a check that cannot possibly have
6145 integer overflow. (Bug#8675)
6146 * character.h (lisp_string_width): Adjust to new signature.
6148 * alloc.c (string_overflow): New function.
6149 (Fmake_string): Use it. This doesn't change behavior, but saves
6150 a few bytes and will simplify future changes.
6151 * character.c (string_escape_byte8): Likewise.
6152 * lisp.h (string_overflow): New decl.
6154 Fixups, following up to the user-interface timestamp change.
6155 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6156 for UI timestamps, instead of unsigned long.
6157 * msdos.c (mouse_get_pos): Likewise.
6158 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6159 * w32gui.h (Time): Define by including "systime.h" rather than by
6160 declaring it ourselves. (Bug#8664)
6162 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6163 * image.c (clear_image_cache): Likewise.
6165 * term.c (term_mouse_position): Don't assume time_t wraparound.
6167 Be more systematic about user-interface timestamps.
6168 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6169 and sometimes 'EMACS_UINT', to represent these timestamps.
6170 This change causes it to use 'Time' uniformly, as that's what X uses.
6171 This makes the code easier to follow, and makes it easier to catch
6172 integer overflow bugs such as Bug#8664.
6173 * frame.c (Fmouse_position, Fmouse_pixel_position):
6174 Use Time, not unsigned long, for user-interface timestamps.
6175 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6176 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6177 * keyboard.h (last_event_timestamp): Likewise.
6178 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6179 * menu.h (xmenu_show): Likewise.
6180 * term.c (term_mouse_position): Likewise.
6181 * termhooks.h (struct input_event.timestamp): Likewise.
6182 (struct terminal.mouse_position_hook): Likewise.
6183 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6184 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6185 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6186 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6188 * menu.h, termhooks.h: Include "systime.h", for Time.
6190 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6191 Don't assume that the difference between two unsigned long values
6192 can fit into an integer. At this point, we know button_down_time
6193 <= event->timestamp, so the difference must be nonnegative, so
6194 there's no need to cast the result if double-click-time is
6195 nonnegative, as it should be; check that it's nonnegative, just in
6196 case. This bug is triggered when events are more than 2**31 ms
6197 apart (about 25 days). (Bug#8664)
6199 * xselect.c (last_event_timestamp): Remove duplicate decl.
6200 (x_own_selection): Remove needless cast to unsigned long.
6202 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6203 that always fit in int. Use a sentinel instead of a counter, to
6204 avoid a temp and to allay GCC's concerns about possible int overflow.
6205 * frame.h (struct frame): Use int for menu_bar_items_used
6206 instead of EMACS_INT, since it always fits in int.
6208 * menu.c (grow_menu_items): Check for int overflow.
6210 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6212 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6213 Before, the code was not consistent. These values cannot exceed
6214 2**31 - 1 so there's no need to make them unsigned.
6215 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6216 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6217 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6219 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6221 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6222 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6223 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6224 presumably because the widths might not match.
6226 * window.c (size_window): Avoid needless test at loop start.
6228 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6230 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6232 2011-05-12 Drew Adams <drew.adams@oracle.com>
6234 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6236 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6238 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6239 `width' to `bar_area_x' and `bar_area_width', respectively.
6240 (x_scroll_run): Take account of fringe background extension.
6242 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6243 Rename local vars `left' and `width' to `bar_area_x' and
6244 `bar_area_width', respectively.
6245 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6246 background extension.
6248 2011-05-10 Jim Meyering <meyering@redhat.com>
6250 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6252 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6254 * image.c (Finit_image_library): Return t for built-in image types,
6255 like pbm and xbm. (Bug#8640)
6257 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6259 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6261 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6263 * w32console.c (Fset_screen_color): Doc fix.
6264 (Fget_screen_color): New function.
6265 (syms_of_ntterm): Defsubr it.
6267 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6268 unlink the temporary file if Fcall_process didn't create it in the
6270 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6271 child process will be redirected to a file specified with `:file'.
6272 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6273 cue to call_process_cleanup not to close that handle.
6275 2011-05-07 Ben Key <bkey76@gmail.com>
6277 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6278 one of two shell specific rules, either bootstrap-temacs-CMD or
6279 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6280 to the previous implementation of the bootstrap-temacs rule.
6281 The bootstrap-temacs-CMD rule is similar to the previous
6282 implementation of the bootstrap-temacs rule except that it
6283 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6286 These changes, along with some changes to nt/configure.bat,
6287 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6288 earlier fix to add support for --cflags and --ldflags options
6289 that include quotes so that it works whether make uses cmd or
6292 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6294 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6295 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6297 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6298 a string. Handle both cases.
6299 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6300 (Fdbus_register_method): Use Qinvalid_function.
6302 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6304 * makefile.w32-in: Update dependencies.
6305 (LISP_H): Add inttypes.h and stdin.h.
6306 (PROCESS_H): Add unistd.h.
6308 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6310 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6311 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6313 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6315 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6317 * term.c (vfatal): Remove stray call to va_end.
6318 It's not needed and the C Standard doesn't allow it here anyway.
6320 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6321 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6323 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6326 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6328 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6330 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6332 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6334 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6336 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6337 * charset.c (Fdefine_charset_internal): Don't initialize
6338 charset.code_space[15]. The value was garbage, on hosts with
6339 32-bit int (Bug#8600).
6341 * lread.c (read_integer): Be more consistent with string-to-number.
6342 Use string_to_number to do the actual conversion; this avoids
6343 rounding errors and fixes some other screwups. Without this fix,
6344 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6345 (digit_to_number): Move earlier, for benefit of read_integer.
6346 Return -1 if the digit is out of range for the base, -2 if it is
6347 not a digit in any supported base. (Bug#8602)
6349 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6351 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6352 to match comment at start of function. This also removes a
6353 GCC warning about overflow in a 32+64-bit port.
6355 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6357 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6358 Reported by Stefan Monnier in
6359 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6360 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6361 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6363 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6364 (EMACS_UINTPTR): Likewise, with uintptr_t.
6366 * lisp.h: Prefer 64-bit EMACS_INT if available.
6367 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6368 on 32-bit hosts that have 64-bit int, so that they can access
6370 However, temporarily disable this change unless the temporary
6371 symbol WIDE_EMACS_INT is defined.
6373 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6375 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6376 This removes an assumption that EMACS_INT and long are the same
6377 width as pointers. The assumption is true for Emacs porting targets
6378 now, but we want to make other targets possible.
6379 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6380 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6381 In the rest of the code, change types of integers that hold casted
6382 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6383 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6384 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6385 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6386 No need to cast type when ORing.
6387 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6388 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6389 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6390 assume EMACS_INT is the same width as char *.
6391 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6392 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6393 Remove no-longer-needed casts.
6394 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6395 (xg_tool_bar_help_callback, xg_make_tool_item):
6396 Use EMACS_INTPTR to hold an integer
6397 that will be cast to void *; this can avoid a GCC warning
6398 if EMACS_INT is not the same width as void *.
6399 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6400 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6401 (current_message_1, set_message_1):
6402 Use a local to convert to proper width without a cast.
6403 * xmenu.c (dialog_selection_callback): Likewise.
6405 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6406 Also, don't assume VALBITS / RAND_BITS is less than 5,
6407 and don't rely on undefined behavior when shifting a 1 left into
6409 * lisp.h (get_random): Change signature to match.
6411 * lread.c (hash_string): Use size_t, not int, for hash computation.
6412 Normally we prefer signed values; but hashing is special, because
6413 it's better to use unsigned division on hash table sizes so that
6414 the remainder is nonnegative. Also, size_t is the natural width
6415 for hashing into memory. The previous code used 'int', which doesn't
6416 retain enough info to hash well into very large tables.
6417 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6419 * dbusbind.c: Don't possibly lose pointer info when converting.
6420 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6421 Use XPNTR rather than XHASH, so that the high-order bits of
6422 the pointer aren't lost when converting through void *.
6424 * eval.c (Fautoload): Don't double-shift a pointer.
6426 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6428 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6430 * gnutls.c (DEF_GNUTLS_FN):
6431 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6433 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6435 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6438 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6440 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6441 New version that can reserve upto 2GB of heap space.
6443 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6445 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6447 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6449 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6450 `gnutls_certificate_set_x509_key_file'.
6452 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6454 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6455 Update dependencies.
6457 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6459 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6460 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6461 Remove unused parameter `fildes'.
6462 * process.c (read_process_output, send_process): Don't pass it.
6464 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6466 Fix previous change: the library cache is defined in w32.c.
6467 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6468 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6470 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6472 Implement dynamic loading of GnuTLS on Windows.
6474 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6475 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6476 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6479 * gnutls.c (Qgnutls_dll): Define.
6480 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6481 (gnutls_*): Declare function pointers.
6482 (init_gnutls_functions): New function to initialize function pointers.
6483 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6484 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6485 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6486 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6487 (emacs_gnutls_write, emacs_gnutls_read)
6488 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6489 (Fgnutls_available_p): New function.
6490 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6491 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6492 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6494 * image.c: Include w32.h.
6495 (Vimage_type_cache): Delete.
6496 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6497 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6498 (w32_delayed_load): Move to w32.c.
6500 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6502 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6503 (w32_delayed_load): Move from image.c. When loading a library, record
6504 its filename in the :loaded-from property of the library id.
6505 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6506 Initialize and staticpro them.
6507 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6509 * process.c: Include lisp.h before w32.h, not after.
6510 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6511 instead of gnutls_record_check_pending.
6513 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6515 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6517 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6518 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6521 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6523 * xterm.c (x_set_frame_alpha): Do not set property on anything
6524 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6526 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6528 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6530 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6532 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6533 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6534 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6535 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6536 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6537 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6538 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6539 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6540 (Qgnutls_bootprop_callbacks_verify): Make static.
6542 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6544 * callproc.c: Indentation fixup.
6546 * sysdep.c (wait_for_termination_1): Make static.
6547 (wait_for_termination, interruptible_wait_for_termination):
6548 Move after wait_for_termination_1.
6550 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6552 * sysdep.c (interruptible_wait_for_termination): New function
6553 which is like wait_for_termination, but allows keyboard
6556 * callproc.c (Fcall_process): Add (:file "file") as an option for
6558 (Fcall_process_region): Ditto.
6560 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6562 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6563 rather than `XVECTOR (FOO)->size'.
6565 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6566 inttypes.h, as a gnulib replacement is used if it not available in
6569 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6571 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6572 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6573 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6575 * coding.c (coding_alloc_by_realloc): Error out if destination
6576 will grow beyond MOST_POSITIVE_FIXNUM.
6577 (decode_coding_emacs_mule): Abort if there isn't enough place in
6578 charbuf for the composition carryover bytes. Reserve an extra
6579 space for up to 2 characters produced in a loop.
6580 (decode_coding_iso_2022): Abort if there isn't enough place in
6581 charbuf for the composition carryover bytes.
6583 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6585 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6586 aborting when %lld or %lll format is passed.
6587 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6588 %llo or %llx format is passed. (Bug#8545)
6590 * window.c (window_scroll_line_based): Use a marker instead of
6591 simple variables to record original value of point. (Bug#7952)
6593 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6594 produced by %s or %c overflows available buffer space. (Bug#8545)
6596 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6598 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6599 (SIZE_MAX): Move defn after all includes, as they might #define it.
6601 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6603 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6605 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6607 * keyboard.c (Qdelayed_warnings_hook): Define.
6608 (command_loop_1): Run `delayed-warnings-hook'
6609 if Vdelayed_warnings_list is non-nil.
6610 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6611 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6613 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6615 * doprnt.c (doprnt): Don't return value smaller than the buffer
6616 size if the message was truncated. (Bug#8545).
6618 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6620 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6621 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6623 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6625 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6627 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6629 * makefile.w32-in: Update dependencies.
6631 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6633 Improve `doprnt' and its usage. (Bug#8545)
6634 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6635 `format_end'. Remove support for %l as a conversion specifier.
6636 Don't use xrealloc. Improve diagnostics when the %l size modifier
6637 is used. Update the commentary.
6639 * eval.c (verror): Simplify calculation of size_t.
6641 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6644 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6646 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6649 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6651 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6652 This makes this file independent of the recent pseudovector change.
6654 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6656 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6658 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6659 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6660 Remove unused local.
6661 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6663 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6664 GCC 4.6.0 optimizes based on type-based alias analysis.
6665 For example, if b is of type struct buffer * and v of type struct
6666 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6667 != &v->size, and therefore "v->size = 1; b->size = 2; return
6668 v->size;" must therefore return 1. This assumption is incorrect
6669 for Emacs, since it type-puns struct Lisp_Vector * with many other
6670 types. To fix this problem, this patch adds a new type struct
6671 vectorlike_header that documents the constraints on layout of vectors
6672 and pseudovectors, and helps optimizing compilers not get fooled
6673 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6674 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6675 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6677 (XSETPVECTYPE): Rewrite in terms of new macro.
6678 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6679 This is a bit clearer, and further avoids the possibility of
6680 undesirable aliasing.
6681 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6682 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6683 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6684 since Lisp_Subr is a special case (no "next" field).
6685 (ASIZE): Now uses header.size rather than size.
6686 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6687 to avoid the hassle of writing XVECTOR (foo)->header.size.
6688 (struct vectorlike_header): New type.
6689 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6690 object, to help avoid aliasing.
6691 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6692 (SUBRP): Likewise, since Lisp_Subr is a special case.
6693 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6694 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6695 (struct Lisp_Hash_Table): Combine first two members into a single
6696 struct vectorlike_header member. All uses of "size" and "next" members
6697 changed to be "header.size" and "header.next".
6698 * buffer.h (struct buffer): Likewise.
6699 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6700 * frame.h (struct frame): Likewise.
6701 * process.h (struct Lisp_Process): Likewise.
6702 * termhooks.h (struct terminal): Likewise.
6703 * window.c (struct save_window_data, struct saved_window): Likewise.
6704 * window.h (struct window): Likewise.
6705 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6706 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6707 * buffer.c (init_buffer_once): Likewise.
6708 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6710 * process.c (Fformat_network_address): Use local var for size,
6713 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6715 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6716 * data.c (atof): Remove decl; no longer used or needed.
6717 (digit_to_number): Move to lread.c.
6718 (Fstring_to_number): Use new string_to_number function, to be
6719 consistent with how the Lisp reader treats infinities and NaNs.
6720 Do not assume that floating-point numbers represent EMACS_INT
6721 without losing information; this is not true on most 64-bit hosts.
6722 Avoid double-rounding errors, by insisting on integers when
6723 parsing non-base-10 numbers, as the documentation specifies.
6724 * lisp.h (string_to_number): New decl, replacing ...
6725 (isfloat_string): Remove.
6726 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6727 (read1): Do not accept +. and -. as integers; this
6728 appears to have been a coding error. Similarly, do not accept
6729 strings like +-1e0 as floating point numbers. Do not report
6730 overflow for integer overflows unless the base is not 10 which
6731 means we have no simple and reliable way to continue.
6732 Break out the floating-point parsing into a new
6733 function string_to_number, so that Fstring_to_number parses
6734 floating point numbers consistently with the Lisp reader.
6735 (digit_to_number): Move here from data.c. Make it static inline.
6736 (E_CHAR, EXP_INT): Remove, replacing with ...
6737 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6738 (string_to_number): New function, replacing isfloat_string.
6739 This function checks for valid syntax and produces the resulting
6740 Lisp float number too. Rework it so that string-to-number
6741 no longer mishandles examples like "1.0e+". Use strtoumax,
6742 so that overflow for non-base-10 numbers is reported only when
6743 there's no portable and simple way to convert to floating point.
6745 * textprop.c (set_text_properties_1): Rewrite for clarity,
6746 and to avoid GCC warning about integer overflow.
6748 * intervals.h (struct interval): Use EMACS_INT for members
6749 where EMACS_UINT might cause problems. See
6750 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6751 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6752 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6754 (offset_intervals): Tell GCC not to worry about length overflow
6755 when negating a negative length.
6757 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6758 (overrun_check_free): Likewise.
6760 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6761 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6764 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6765 (gnutls_make_error): Rename local to avoid shadowing.
6766 (gnutls_emacs_global_deinit): ifdef out; not used.
6767 (Fgnutls_boot): Use const for pointer to readonly storage.
6768 Comment out unused local. Fix pointer signedness problems.
6770 * lread.c (openp): Don't stuff size_t into an 'int'.
6771 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6772 about possible signed overflow.
6774 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6775 (GDK_KEY_g): Don't define if already defined.
6776 (xg_prepare_tooltip): Avoid pointer signedness problem.
6777 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6779 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6780 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6782 * xfns.c (Fx_window_property): Simplify a bit,
6783 to make a bit faster and to avoid GCC 4.6.0 warning.
6784 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6786 * fns.c (internal_equal): Don't assume size_t fits in int.
6788 * alloc.c (compact_small_strings): Tighten assertion a little.
6790 Replace pEd with more-general pI, and fix some printf arg casts.
6791 * lisp.h (pI): New macro, generalizing old pEd macro to other
6792 conversion specifiers. For example, use "...%"pI"d..." rather
6793 than "...%"pEd"...".
6794 (pEd): Remove. All uses replaced with similar uses of pI.
6795 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
6796 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6797 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6798 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6799 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6800 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6801 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6803 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6804 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6805 * print.c (safe_debug_print, print_object): Likewise.
6806 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6808 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6809 avoiding the 0 flag, which is not portable.
6810 * process.c (Fmake_network_process): Use pI to avoid cast.
6811 * region-cache.c (pp_cache): Likewise.
6812 * xdisp.c (decode_mode_spec): Likewise.
6813 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6814 behavior on 64-bit hosts with printf arg.
6815 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6816 (x_stop_queuing_selection_requests): Likewise.
6817 (x_get_window_property): Don't truncate byte count to an 'int'
6820 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6821 here, since it parses constructs like leading '-' and spaces,
6822 which are not wanted; and it overflows with large numbers.
6823 Instead, simply match F[0-9]+, which is what is wanted anyway.
6825 * alloc.c: Remove unportable assumptions about struct layout.
6826 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6827 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6828 (allocate_vectorlike, make_pure_vector): Use the new macros,
6829 plus offsetof, to remove unportable assumptions about struct layout.
6830 These assumptions hold on all porting targets that I know of, but
6831 they are not guaranteed, they're easy to remove, and removing them
6832 makes further changes easier.
6834 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6835 This doesn't fix a bug but makes the code clearer.
6836 (string_overrun_cookie): Now const. Use initializers that
6837 don't formally overflow signed char, to avoid warnings.
6838 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6839 can cause Emacs to crash when string overrun checking is enabled.
6840 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6841 multiple of sizeof (EMACS_INT); it need not be, if
6842 alignof(EMACS_INT) < sizeof (EMACS_INT).
6843 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6845 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6847 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6849 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6851 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6852 supposed to be handshaking. (Bug#8556)
6853 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6855 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6857 * lisp.h (Qdebug): List symbol.
6858 * eval.c (Qdebug): Restore global linkage.
6859 * keyboard.c (debug-on-event): New variable.
6860 (handle_user_signal): Break into debugger when debug-on-event
6861 matches the current signal symbol.
6863 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6865 * alloc.c (check_sblock, check_string_bytes)
6866 (check_string_free_list): Convert to standard C.
6868 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6870 * w32.c (emacs_gnutls_push): Fix typo.
6872 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6874 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6875 "cast to pointer from integer of different size".
6877 Improve doprnt and its use in verror. (Bug#8545)
6878 * doprnt.c (doprnt): Document the set of format control sequences
6879 supported by the function. Use SAFE_ALLOCA instead of always
6882 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6883 is one byte too soon. Don't use xrealloc; instead xfree and
6886 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6888 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6891 * gnutls.c: Renamed global_initialized to
6892 gnutls_global_initialized. Added internals for the
6893 :verify-hostname-error, :verify-error, and :verify-flags
6894 parameters of `gnutls-boot' and documented those parameters in the
6895 docstring. Start callback support.
6896 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6897 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6898 on error. Return error code.
6899 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6900 (emacs_gnutls_read): Likewise.
6901 (Fgnutls_boot): Return handshake error code.
6902 (emacs_gnutls_handle_error): New function.
6903 (wsaerror_to_errno): Likewise.
6905 * w32.h (emacs_gnutls_pull): Add prototype.
6906 (emacs_gnutls_push): Likewise.
6908 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6909 (emacs_gnutls_push): Likewise.
6911 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6913 * process.c (wait_reading_process_output): Check if GnuTLS
6914 buffered some data internally if no FDs are set for TLS
6917 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6918 (LIBS): Link to USER_LIBS.
6919 ($(BLD)/gnutls.$(0)): New target.
6921 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6923 * xdisp.c (handle_single_display_spec): Rename the
6924 display_replaced_before_p argument into display_replaced_p, to
6925 make it consistent with the commentary. Fix typos in the
6928 * textprop.c (syms_of_textprop): Remove dead code.
6929 (copy_text_properties): Delete obsolete commentary about an
6930 interface that was deleted long ago. Fix typos in the description
6933 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6934 to changes in oldXMenu/XMenu.h from 2011-04-16.
6935 <menu_help_message, prev_menu_help_message>: Constify.
6936 (IT_menu_make_room): menu->help_text is now `const char **';
6939 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6940 to changes in oldXMenu/XMenu.h from 2011-04-16.
6941 (struct XMenu): Declare `help_text' `const char **'.
6943 * xfaces.c <Qunspecified>: Make extern again.
6945 * syntax.c: Include sys/types.h before including regex.h, as
6948 * doc.c (get_doc_string): Improve the format passed to `error'.
6950 * doprnt.c (doprnt): Improve commentary.
6952 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6954 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6957 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6958 changes in globals.h immediately force recompilation.
6959 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6960 $(CURDIR)/s/ms-w32.h.
6961 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6963 * character.c (Fchar_direction): Function deleted.
6964 (syms_of_character): Don't defsubr it.
6965 <char-direction-table>: Deleted.
6967 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6969 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6970 * doprnt.c: Include limits.h.
6971 (SIZE_MAX): New macro.
6972 (doprnt): Return a size_t value. 2nd arg is now size_t.
6973 Many local variables are now size_t instead of int or unsigned.
6974 Improve overflow protection. Support `l' modifier for integer
6975 conversions. Support %l conversion. Don't assume an EMACS_INT
6976 argument for integer conversions and for %c.
6978 * lisp.h (doprnt): Restore prototype.
6980 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6983 * Makefile.in (base_obj): Add back doprnt.o.
6985 * deps.mk (doprnt.o): Add back prerequisites.
6986 (callint.o): Depend on character.h.
6988 * eval.c (internal_lisp_condition_case): Include the handler
6989 representation in the error message.
6990 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6991 when breaking from the loop.
6993 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6995 * callint.c (Fcall_interactively): When displaying error message
6996 about invalid control letter, pass the character's codepoint, not
6997 a pointer to its multibyte form. Improve display of the character
6998 in octal and display also its hex code.
7000 * character.c (char_string): Use %x to display the (unsigned)
7001 codepoint of an invalid character, to avoid displaying a bogus
7004 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7005 `error', not SYMBOL_NAME itself.
7007 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7008 character arguments to `error'.
7010 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7011 to `error' in error message about FINAL_CHAR argument. Make sure
7012 FINAL_CHAR is a character, and use %c when it is passed as
7013 argument to `error'.
7015 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7017 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7019 * w32.c: Include <time.h>.
7020 (sys_localtime): New function.
7022 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7024 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7026 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7028 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7030 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7033 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7035 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7036 gl_state.e_property when gl_state.object is Qt.
7038 * insdel.c (make_gap_larger): Remove limitation of buffer size
7041 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7043 * xdisp.c (lookup_glyphless_char_display)
7044 (produce_glyphless_glyph): Handle cons cell entry in
7045 glyphless-char-display.
7046 (Vglyphless_char_display): Document it.
7048 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7049 glyphless-char-display.
7051 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7053 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7055 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7057 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7058 definition for no-X builds.
7060 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7062 Static checks with GCC 4.6.0 and non-default toolkits.
7064 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7066 * process.c (keyboard_bit_set): Define only if SIGIO.
7067 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7068 (send_process): Repair possible setjmp clobbering.
7070 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7072 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7074 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7076 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7077 Define only if needed.
7079 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7080 by pacifying GCC about it. Maybe it's time to retire it?
7081 * xfaces.c (USG, __TIMEVAL__): Likewise.
7083 * dispextern.h (struct redisplay_interface): Rename param
7085 * termhooks.h (struct terminal): Likewise.
7086 * xterm.c (xembed_send_message): Likewise.
7088 * insdel.c (make_gap_smaller): Define only if
7089 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7091 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7094 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7095 so that we aren't warned about unused symbols.
7097 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7099 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7101 * xfns.c (x_real_positions): Mark locals as initialized.
7103 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7105 * xterm.c: Fix problems found by static analysis with other toolkits.
7106 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7107 (x_dispatch_event): Declare static if USE_GTK, and
7108 define if USE_GTK || USE_X_TOOLKIT.
7109 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7110 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7111 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7112 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7114 * xmenu.c (menu_help_callback): Pointer type fixes.
7115 Use const pointers when pointing at readonly data. Avoid pointer
7117 (FALSE): Remove unused macro.
7118 (update_frame_menubar): Remove unused decl.
7120 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7122 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7123 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7124 (single_menu_item): Rename local to avoid shadowing.
7126 * keyboard.c (make_lispy_event): Remove unused local var.
7128 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7129 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7131 * bitmaps: Change bitmaps from unsigned char back to the X11
7132 compatible char. Avoid the old compiler warnings about
7133 out-of-range initializers by using, for example, '\xab' rather
7136 * xgselect.c (xgselect_initialize): Check vs interface
7137 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7139 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7141 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7142 to read-only memory.
7144 * fns.c (vector): Remove; this old hack is no longer needed.
7146 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7148 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7150 * xrdb.c (x_load_resources): Omit unused local.
7152 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7153 (x_window): Rename locals to avoid shadowing.
7154 (USG): Use the kludged USG macro, to pacify gcc.
7156 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7157 (x_term_init): Remove local to avoid shadowing.
7159 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7161 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7162 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7164 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7166 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7168 Fix regex.c, syntax.c and friends for buffers > 2GB.
7169 * syntax.h (struct gl_state_s): Declare character position members
7172 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7174 * textprop.c (verify_interval_modification, interval_of):
7175 Declare arguments EMACS_INT.
7177 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7180 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7182 * indent.c (Fvertical_motion): Local variable it_start is now
7185 * regex.c (re_match, re_match_2, re_match_2_internal)
7186 (bcmp_translate, regcomp, regexec, print_double_string)
7187 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7188 (re_compile_pattern, re_exec): Declare arguments and local
7189 variables `size_t' and `ssize_t' and return values `regoff_t', as
7191 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7192 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7193 <compile_stack_type>: `size' and `avail' are now `size_t'.
7195 * regex.h <regoff_t>: Use ssize_t, not int.
7196 (re_search, re_search_2, re_match, re_match_2): Arguments that
7197 specify buffer/string position and length are now ssize_t and
7198 size_t. Return type is regoff_t.
7200 2011-04-16 Ben Key <bkey76@gmail.com>
7202 * nsfont.m: Fixed bugs in ns_get_family and
7203 ns_descriptor_to_entity that were caused by using free to
7204 deallocate memory blocks that were allocated by xmalloc (via
7205 xstrdup). This caused Emacs to crash when compiled with
7206 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7207 --enable-checking=xmallocoverrun). xfree is now used to
7208 deallocate these memory blocks.
7210 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7212 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7214 emacs_write: Accept and return EMACS_INT for sizes.
7215 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7217 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7218 Accept and return EMACS_INT.
7219 (emacs_gnutls_write): Return the number of bytes written on
7221 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7222 (emacs_read, emacs_write): Remove check for negative size, as the
7223 Emacs source code has been audited now.
7224 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7225 (emacs_read, emacs_write): Use it.
7226 * process.c (send_process): Adjust to the new signatures of
7227 emacs_write and emacs_gnutls_write. Do not attempt to store
7228 a byte offset into an 'int'; it might overflow.
7229 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7231 * sound.c: Don't assume sizes fit in 'int'.
7232 (struct sound_device.period_size, alsa_period_size):
7233 Return EMACS_INT, not int.
7234 (struct sound_device.write, vox_write, alsa_write):
7235 Accept EMACS_INT, not int.
7236 (wav_play, au_play): Use EMACS_INT to store sizes and to
7237 record read return values.
7239 2011-04-15 Ben Key <bkey76@gmail.com>
7241 * keyboard.c (Qundefined): Don't declare static since it is used
7243 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7244 static since they are used in nsfont.m.
7246 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7248 * process.c (Qprocessp): Don't declare static.
7249 * lisp.h (Qprocessp): Declare again.
7251 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7253 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7255 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7257 Improve C-level modularity by making more things 'static'.
7259 Don't publish debugger-only interfaces to other modules.
7260 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7261 (verify_bytepos, count_markers): Move decls to the only modules
7263 * region-cache.h (pp_cache): Likewise.
7264 * window.h (check_all_windows): Likewise.
7265 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7267 * sysdep.c (croak): Now static, if
7268 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7269 * syssignal.h (croak): Declare only if not static.
7271 * alloc.c (refill_memory_reserve): Now static if
7272 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7273 * lisp.h (refill_memory_reserve): Declare only if not static.
7275 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7276 Define only if USE_LUCID.
7278 * xrdb.c (x_customization_string, x_rm_string): Now static.
7280 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7281 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7283 * xdisp.c (draw_row_with_mouse_face): Now static.
7284 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7286 * window.h (check_all_windows): Mark externally visible.
7288 * window.c (window_deletion_count): Now static.
7290 * undo.c: Make symbols static if they're not exported.
7291 (last_undo_buffer, last_boundary_position, pending_boundary):
7294 * textprop.c (interval_insert_behind_hooks): Now static.
7295 (interval_insert_in_front_hooks): Likewise.
7297 * term.c: Make symbols static if they're not exported.
7298 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7299 (max_frame_lines, tty_set_terminal_modes):
7300 (tty_reset_terminal_modes, tty_turn_off_highlight):
7301 (get_tty_terminal): Now static.
7302 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7303 * termhooks.h (term_mouse_moveto): Do not declare if
7305 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7306 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7308 * sysdep.c: Make symbols static if they're not exported.
7309 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7311 (sigprocmask_set, full_mask): Remove; unused.
7312 (wait_debugging): Mark as visible.
7313 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7314 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7316 * syntax.c (syntax_temp): Define only if !__GNUC__.
7318 * sound.c (current_sound_device, current_sound): Now static.
7320 * search.c (searchbufs, searchbuf_head): Now static.
7322 * scroll.c (scroll_cost): Remove; unused.
7323 * dispextern.h (scroll_cost): Remove decl.
7325 * region-cache.h (pp_cache): Mark as externally visible.
7327 * process.c: Make symbols static if they're not exported.
7328 (process_tick, update_tick, create_process, chan_process):
7329 (Vprocess_alist, proc_buffered_char, datagram_access):
7330 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7331 (deactivate_process): Mark defn as static, as well as decl.
7332 * lisp.h (create_process): Remove decl.
7333 * process.h (chan_process, Vprocess_alist): Remove decls.
7335 * print.c: Make symbols static if they're not exported.
7336 (print_depth, new_backquote_output, being_printed, print_buffer):
7337 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7338 (print_interval, print_number_index, initial_stderr_stream):
7340 * lisp.h (Fprinc): Remove decl.
7341 (debug_output_compilation_hack): Mark as externally visible.
7343 * sysdep.c (croak): Move decl from here to syssignal.h.
7344 * syssignal.h (croak): Put it here, so the API can be checked when
7345 'croak' is called from dissociate_if_controlling_tty.
7347 * minibuf.c: Make symbols static if they're not exported.
7348 (minibuf_save_list, choose_minibuf_frame): Now static.
7349 * lisp.h (choose_minibuf_frame): Remove decl.
7351 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7353 * lread.c: Make symbols static if they're not exported.
7354 (read_objects, initial_obarray, oblookup_last_bucket_number):
7356 (make_symbol): Remove; unused.
7357 * lisp.h (initial_obarray, make_symbol): Remove decls.
7359 * keyboard.c: Make symbols static if they're not exported.
7360 (single_kboard, recent_keys_index, total_keys, recent_keys):
7361 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7362 (this_single_command_key_start, echoing, last_auto_save):
7363 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7364 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7365 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7366 (Vlispy_mouse_stem, double_click_count):
7368 (force_auto_save_soon): Define only if SIGDANGER.
7369 (ignore_mouse_drag_p): Now static if
7370 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7371 (print_help): Remove; unused.
7372 (stop_character, last_timer_event): Mark as externally visible.
7373 * keyboard.h (ignore_mouse_drag_p): Declare only if
7374 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7375 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7376 * lisp.h (echoing): Remove decl.
7377 (force_auto_save_soon): Declare only if SIGDANGER.
7378 * xdisp.c (redisplay_window): Simplify code, to make it more
7379 obvious that ignore_mouse_drag_p is not accessed if !defined
7380 USE_GTK && !defined HAVE_NS.
7382 * intervals.c: Make symbols static if they're not exported.
7383 (merge_properties_sticky, merge_interval_right, delete_interval):
7385 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7387 * insdel.c: Make symbols static if they're not exported.
7388 However, leave prepare_to_modify_buffer alone. It's never
7389 called from outside this function, but that appears to be a bug.
7390 (combine_after_change_list, combine_after_change_buffer):
7391 (adjust_after_replace, signal_before_change): Now static.
7392 (adjust_after_replace_noundo): Remove; unused.
7393 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7394 (signal_before_change): Remove decls.
7396 * indent.c (val_compute_motion, val_vmotion): Now static.
7398 * image.c: Make symbols static if they're not exported.
7399 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7401 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7402 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7404 * fringe.c (standard_bitmaps): Now static.
7405 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7407 * frame.c: Make symbols static if they're not exported.
7408 (x_report_frame_params, make_terminal_frame): Now static.
7409 (get_frame_param): Now static, unless HAVE_NS.
7410 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7411 (x_get_resource_string): Remove; not used.
7412 * frame.h (make_terminal_frame, x_report_frame_params):
7413 (x_get_resource_string); Remove decls.
7414 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7415 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7417 * font.c, fontset.c: Make symbols static if they're not exported.
7418 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7419 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7420 * font.c (font_close_object): Now static.
7421 * font.h (font_close_object): Remove.
7422 * fontset.c (FONTSET_OBJLIST): Remove.
7423 (free_realized_fontset) #if-0 the body, which does nothing.
7424 (face_suitable_for_char_p): #if-0, as it's never called.
7425 * fontset.h (face_suitable_for_char_p): Remove decl.
7426 * xfaces.c (face_at_string_position):
7427 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7428 since 0 is always ASCII.
7430 * fns.c (weak_hash_tables): Now static.
7432 * fileio.c: Make symbols static if they're not exported.
7433 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7434 (Vwrite_region_annotation_buffers): Now static.
7436 * eval.c: Make symbols static if they're not exported.
7437 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7438 * lisp.h (backtrace_list): Remove decl.
7440 * emacs.c: Make symbols static if they're not exported.
7441 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7442 (fatal_error_code, fatal_error_signal_hook, standard_args):
7444 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7445 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7446 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7447 * lisp.h (fatal_error_signal_hook): Remove decl.
7448 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7450 * editfns.c: Move a (normally-unused) function to its only use.
7451 * editfns.c, lisp.h (get_operating_system_release): Remove.
7452 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7453 worth the hassle of breaking this out.
7455 * xterm.c: Make symbols static if they're not exported.
7456 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7457 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7458 (x_destroy_window, x_delete_display):
7460 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7461 (x_mouse_leave): Remove; unused.
7462 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7463 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7464 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7466 (x_mouse_leave): Declare only if WINDOWSNT.
7467 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7468 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7471 * ftxfont.c: Make symbols static if they're not exported.
7472 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7474 * font.h (ftxfont_driver): Likewise.
7476 * xfns.c: Make symbols static if they're not exported.
7477 (x_last_font_name, x_display_info_for_name):
7478 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7479 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7480 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7481 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7482 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7483 (last_show_tip_args): Now static.
7484 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7485 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7486 (x_screen_planes): Remove; unused.
7487 * dispextern.h (x_screen_planes): Remove decl.
7489 * dispnew.c: Make symbols static if they're not exported.
7490 * dispextern.h (redraw_garbaged_frames, scrolling):
7491 (increment_row_positions): Remove.
7492 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7493 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7495 (redraw_garbaged_frames): Remove; unused.
7497 * xfaces.c: Make symbols static if they're not exported.
7498 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7500 * xterm.h (defined_color): Remove decls.
7501 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7502 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7503 (menu_face_changed_default, defined_color, free_realized_face):
7504 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7505 (ascii_face_of_lisp_face): Remove; unused.
7507 * xdisp.c: Make symbols static if they're not exported.
7508 * dispextern.h (scratch_glyph_row, window_box_edges):
7509 (glyph_to_pixel_coords, set_cursor_from_row):
7510 (get_next_display_element, set_iterator_to_next):
7511 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7512 (show_mouse_face): Remove decls
7513 * frame.h (message_buf_print): Likewise.
7514 * lisp.h (pop_message, set_message, check_point_in_composition):
7516 * xterm.h (set_vertical_scroll_bar): Likewise.
7517 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7518 (message_buf_print, scratch_glyph_row, displayed_buffer):
7519 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7520 (get_next_display_element, show_mouse_face, window_box_edges):
7521 (frame_to_window_pixel_xy, check_point_in_composition):
7522 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7523 (glyph_to_pixel_coords): Remove; unused.
7525 * dired.c (file_name_completion): Now static.
7527 * dbusbind.c (xd_in_read_queued_messages): Now static.
7529 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7530 * data.c (circular_list_error): Remove.
7532 * commands.h (last_point_position, last_point_position_buffer):
7533 (last_point_position_window): Remove decls.
7534 * keyboard.c: Make these variables static.
7536 * coding.h (coding, code_convert_region, encode_coding_gap):
7538 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7539 (iso_code_class, detect_coding, code_convert_region): Now static.
7540 (encode_coding_gap): Remove; unused.
7542 * chartab.c (chartab_chars, chartab_bits): Now static.
7544 * charset.h (charset_iso_8859_1): Remove decl.
7545 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7548 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7549 * ccl.c (Vccl_program_table): Now static.
7550 (check_ccl_update): Remove; unused.
7552 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7553 * category.h: ... from here.
7554 * category.c (check_category_table, set_category_set): Now static.
7556 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7557 * lisp.h: Remove these decls.
7559 * buffer.c (buffer_count): Remove unused var.
7561 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7562 so that it's not optimized away.
7563 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7564 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7565 exported only to the debugger.
7567 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7568 * atimer.h (run_all_atimers): Remove; not exported.
7570 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7571 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7572 was inaccessible from Lisp.
7573 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7574 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7576 alloc.c: Import and export fewer symbols, and remove unused items.
7577 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7579 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7580 it's not optimized away by whole-program optimization.
7581 (message_enable_multibyte, free_misc): Remove.
7582 (catchlist, handlerlist, mark_backtrace):
7583 Declare only if BYTE_MARK_STACK.
7584 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7585 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7586 (message_enable_multibyte): Remove decl.
7587 (free_misc, interval_free_list, float_block, float_block_index):
7588 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7589 (cons_free_list, last_marked_index):
7591 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7592 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7593 (mark_backtrace): Define only if BYTE_MARK_STACK.
7594 * xdisp.c (message_enable_multibyte): Now static.
7596 Declare Lisp_Object Q* variables to be 'static' if not exported.
7597 This makes it easier for human readers (and static analyzers)
7598 to see whether these variables are used from other modules.
7599 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7600 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7601 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7602 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7603 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7604 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7605 * xmenu.c, xselect.c:
7606 Declare Q* vars static if they are not used in other modules.
7607 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7608 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7609 Remove decls of unexported vars.
7610 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7612 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7614 Make Emacs functions such as Fatom 'static' by default.
7615 This makes it easier for human readers (and static analyzers)
7616 to see whether these functions can be called from other modules.
7617 DEFUN now defines a static function. To make the function external
7618 so that it can be used in other C modules, use the new macro DEFUE.
7619 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7620 (Finit_image_library):
7621 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7622 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7623 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7624 Remove decls, since these functions are now static.
7625 (Funintern, Fget_internal_run_time): New decls, since these functions
7626 were already external.
7628 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7629 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7630 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7631 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7632 * keyboard.c, keymap.c, lread.c:
7633 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7634 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7635 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7636 Mark functions with DEFUE instead of DEFUN,
7637 if they are used in other modules.
7638 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7639 decls for now-static functions.
7640 * buffer.h (Fdelete_overlay): Remove decl.
7641 * callproc.c (Fgetenv_internal): Mark as internal.
7642 * composite.c (Fremove_list_of_text_properties): Remove decl.
7643 (Fcomposition_get_gstring): New forward static decl.
7644 * composite.h (Fcomposite_get_gstring): Remove decl.
7645 * dired.c (Ffile_attributes): New forward static decl.
7646 * doc.c (Fdocumntation_property): New forward static decl.
7647 * eval.c (Ffetch_bytecode): New forward static decl.
7648 (Funintern): Remove extern decl; now in .h file where it belongs.
7649 * fileio.c (Fmake_symbolic_link): New forward static decl.
7650 * image.c (Finit_image_library): New forward static decl.
7651 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7652 * intervals.h (Fprevious_property_change):
7653 (Fremove_list_of_text_properties): Remove decls.
7654 * keyboard.c (Fthis_command_keys): Remove decl.
7655 (Fcommand_execute): New forward static decl.
7656 * keymap.c (Flookup_key): New forward static decl.
7657 (Fcopy_keymap): Now static.
7658 * keymap.h (Flookup_key): Remove decl.
7659 * process.c (Fget_process): New forward static decl.
7660 (Fprocess_datagram_address): Mark as internal.
7661 * syntax.c (Fsyntax_table_p): New forward static decl.
7662 (skip_chars): Remove duplicate decl.
7663 * textprop.c (Fprevious_property_change): New forward static decl.
7664 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7666 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7667 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7669 * editfns.c (Fformat): Remove unreachable code.
7671 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7673 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7676 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7678 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7679 when at ZV. (Bug#8487)
7681 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7683 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7685 * keyboard.c (parse_tool_bar_item): Likewise.
7686 * sound.c (sound_cleanup, alsa_close): Likewise.
7687 * termcap.c (tgetent): Likewise.
7688 * xfns.c (x_default_font_parameter): Likewise.
7689 * xsettings.c (read_and_apply_settings): Likewise.
7691 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7692 (overrun_check_free): Protoize.
7694 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7696 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7697 since callers should never pass a negative size.
7698 Change the signature to match that of plain 'read' and 'write'; see
7699 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7700 * lisp.h: Update prototypes of emacs_write and emacs_read.
7702 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7704 * xdisp.c (redisplay_window): Don't try to determine the character
7705 position of the scroll margin if the window start point w->startp
7706 is outside the buffer's accessible region. (Bug#8468)
7708 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7710 Fix write-region and its subroutines for buffers > 2GB.
7711 * fileio.c (a_write, e_write): Modify declaration of arguments and
7712 local variables to support buffers larger than 2GB.
7713 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7715 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7716 argument, local variables, and return value.
7718 * lisp.h: Update prototypes of emacs_write and emacs_read.
7720 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7722 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7724 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7726 Fix more problems found by GCC 4.6.0's static checks.
7728 * xdisp.c (vmessage): Use a better test for character truncation.
7730 * charset.c (load_charset_map): <, not <=, for optimization,
7731 and to avoid potential problems with integer overflow.
7732 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7733 * casetab.c (set_identity, shuffle): Likewise.
7734 * editfns.c (Fformat): Likewise.
7735 * syntax.c (skip_chars): Likewise.
7737 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7738 This also lets GCC 4.6.0 generate slightly better loop code.
7740 * callint.c (Fcall_interactively): <, not <=, for optimization.
7741 (Fcall_interactively): Count the number of arguments produced,
7742 not the number of arguments given. This is simpler and lets GCC
7743 4.6.0 generate slightly better code.
7745 * ftfont.c: Distingish more carefully between FcChar8 and char.
7746 The previous code passed unsigned char * to a functions like
7747 strlen and xstrcasecmp that expect char *, which does not
7748 conform to the C standard.
7749 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7750 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7751 char * when the C standard requires it.
7753 * keyboard.c (read_char): Remove unused var.
7755 * eval.c: Port to Windows vsnprintf (Bug#8435).
7757 (SIZE_MAX): Define if the headers do not.
7758 (verror): Do not give up if vsnprintf returns a negative count.
7759 Instead, grow the buffer. This ports to Windows vsnprintf, which
7760 does not conform to C99. Problem reported by Eli Zaretskii.
7761 Also, simplify the allocation scheme, by avoiding the need for
7762 calling realloc, and removing the ALLOCATED variable.
7764 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7766 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7767 But keep the doprint source code for now, as we might revamp it
7768 and use it again (Bug#8435).
7769 * lisp.h (doprnt): Remove.
7770 * Makefile.in (base_obj): Remove doprnt.o.
7771 * deps.mk (doprnt.o): Remove.
7773 error: Print 32- and 64-bit integers portably (Bug#8435).
7774 Without this change, on typical 64-bit hosts error ("...%d...", N)
7775 was used to print both 32- and 64-bit integers N, which relied on
7777 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
7778 * lisp.h (error, verror): Mark as printf-like functions.
7779 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7780 Report overflow in size calculations when allocating printf buffer.
7781 Do not truncate output string at its first null byte.
7782 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7783 Truncate the output at a character boundary, since vsnprintf does not
7785 * charset.c (check_iso_charset_parameter): Convert internal
7786 character to string before calling 'error', since %c now has the
7788 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7789 overflow when computing char to be passed to 'error'. Do not
7790 pass Lisp_Object to 'error'; pass the integer instead.
7791 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7792 formatted with plain %d.
7794 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7796 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7798 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7800 * xterm.c (x_catch_errors): Remove duplicate declaration.
7802 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7804 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7806 2011-04-10 Jim Meyering <meyering@redhat.com>
7808 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7809 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7810 return ssize_t not "int", and use size_t as the buffer length.
7811 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7812 * gnutls.h: Update declarations.
7813 * process.c (read_process_output): Use ssize_t, to match.
7814 (send_process): Likewise.
7816 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7818 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7820 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7822 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7823 Use unsigned char, to match FcChar8 type definition.
7825 * xterm.c (handle_one_xevent):
7826 * xmenu.c (create_and_show_popup_menu):
7827 * xselect.c (x_decline_selection_request)
7828 (x_reply_selection_request): Avoid type-punned deref of X events.
7830 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7832 Fix some uses of `int' instead of EMACS_INT.
7833 * search.c (string_match_1, fast_string_match)
7834 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7835 (scan_buffer, find_next_newline_no_quit)
7836 (find_before_next_newline, search_command, Freplace_match)
7837 (Fmatch_data): Make some `int' variables be EMACS_INT.
7839 * xdisp.c (display_count_lines): 3rd argument and return value now
7840 EMACS_INT. All callers changed.
7841 (pint2hrstr): Last argument is now EMACS_INT.
7843 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7844 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7845 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7846 (decode_coding_utf_16, decode_coding_emacs_mule)
7847 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7848 (decode_coding_ccl, decode_coding_charset)
7849 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7850 (decode_coding_iso_2022, decode_coding_emacs_mule)
7851 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7852 <char_offset, last_offset>: Declare EMACS_INT.
7853 (encode_coding_utf_8, encode_coding_utf_16)
7854 (encode_coding_emacs_mule, encode_invocation_designation)
7855 (encode_designation_at_bol, encode_coding_iso_2022)
7856 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7857 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7859 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7860 (encode_invocation_designation): Last argument P_NCHARS is now
7862 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7863 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7865 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7868 * ccl.c (Fccl_execute_on_string): Declare some variables
7871 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7873 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7875 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7877 * process.c (Fformat_network_address): Doc fix.
7879 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7881 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7883 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7885 * keyboard.c (read_char): Call Lisp function help-form-show,
7886 instead of using internal_with_output_to_temp_buffer.
7887 (Qhelp_form_show): New var.
7888 (syms_of_keyboard): Use DEFSYM macro.
7890 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7892 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7894 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7896 * process.c (Flist_processes): Remove to Lisp.
7897 (list_processes_1): Delete.
7899 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7901 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7903 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7905 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7907 Fix more problems found by GCC 4.6.0's static checks.
7909 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7911 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7913 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7915 * xdisp.c (vmessage): Mark as a printf-like function.
7917 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7919 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7921 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7922 printf-like functions.
7923 (tiff_load): Add casts to remove these marks before passing them
7924 to system-supplied API.
7926 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7928 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7929 This avoids several warnings with gcc -Wstrict-overflow.
7930 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7931 directly, rather than having caller test rule sign. This avoids
7932 some unnecessary tests.
7933 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7934 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7935 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7937 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7938 (xfont_open): Avoid unnecessary tests.
7940 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7942 * composite.h, composite.c (composition_gstring_put_cache):
7943 Use EMACS_INT, not int, for length.
7945 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7946 breaking out part of COMPOSITION_DECODE_RULE.
7947 (COMPOSITION_DECODE_RULE): Use it.
7948 * composite.c (get_composition_id): Remove unused local vars,
7949 by using the new macro.
7951 * textprop.c (set_text_properties_1): Change while to do-while,
7952 since the condition is always true at first.
7954 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7955 (interval_deletion_adjustment): Return unsigned value.
7958 * process.c (list_processes_1, create_pty, read_process_output):
7959 (exec_sentinel): Remove vars that were set but not used.
7960 (create_pty): Remove unnecessary "volatile"s.
7961 (Fnetwork_interface_info): Avoid possibility of int overflow.
7962 (read_process_output): Do adaptive read buffering even if carryover.
7963 (read_process_output): Simplify nbytes computation if buffered.
7965 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7967 * syntax.c (scan_words): Remove var that was set but not used.
7968 (update_syntax_table): Use unsigned instead of int.
7970 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7971 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7972 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7974 * print.c (print_error_message): Avoid int overflow.
7976 * font.c (font_list_entities): Redo for clarity,
7977 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7979 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7980 (font_score): Avoid potential overflow in diff calculation.
7982 * fns.c (substring_both): Remove var that is set but not used.
7983 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7985 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7987 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7988 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7989 can always succeed if overflow has undefined behavior.
7991 * search.c (boyer_moore, wordify): Remove vars set but not used.
7992 (wordify): Omit three unnecessary tests.
7994 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7995 All callers changed. This avoids the need for an unused var.
7997 * casefiddle.c (casify_region): Remove var that is set but not used.
7999 * dired.c (file_name_completion): Remove var that is set but not used.
8001 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8003 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8004 (Finsert_file_contents): Remove unnecessary code checking fd.
8006 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8007 Check for integer overflow on size calculations.
8009 * buffer.c (Fprevious_overlay_change): Remove var that is set
8012 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8013 Remove vars that are set but not used.
8014 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8015 (timer_check_2): Mark vars as initialized.
8017 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8019 * image.c (lookup_image): Remove var that is set but not used.
8020 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8022 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8023 that are set but not used.
8025 * xfns.c (make_invisible_cursor): Don't return garbage
8026 if XCreateBitmapFromData fails (Bug#8410).
8028 * xselect.c (x_get_local_selection, x_handle_property_notify):
8029 Remove vars that are set but not used.
8031 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8032 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8034 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8035 Remove var that is set but not used.
8036 (scroll_bar_windows_size): Now size_t, not int.
8037 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8040 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8041 (map_tty_color) [!defined MSDOS]: Likewise.
8043 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8045 * coding.c: Remove vars that are set but not used.
8046 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8047 All callers changed.
8048 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8049 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8050 (decode_coding_charset): Remove vars that are set but not used.
8052 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8053 that is set but not used.
8055 * print.c (print_object): Remove var that is set but not used.
8057 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8058 The gnulib version avoids calling malloc in the usual case,
8059 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8060 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8061 * filelock.c (current_lock_owner): Likewise.
8062 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8063 * sysdep.c: Include allocator.h, careadlinkat.h.
8064 (emacs_no_realloc_allocator): New static constant.
8065 (emacs_readlink): New function.
8066 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8067 ../lib/careadlinkat.h.
8069 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8071 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8072 first non-nil return value).
8074 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8076 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8077 if not defined (Bug#8403).
8079 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8081 * xdisp.c (display_count_lines): Remove parameter `start',
8082 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8083 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8084 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8085 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8086 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8087 and thereabouts. All callers changed.
8088 (get_per_char_metric): Remove parameter `f', unused since
8089 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8091 2011-04-02 Jim Meyering <meyering@redhat.com>
8093 do not dereference NULL upon failed strdup
8094 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8095 (ns_get_family): Likewise.
8097 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8099 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8101 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8103 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8106 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8108 Add lexical binding.
8110 * window.c (Ftemp_output_buffer_show): New fun.
8111 (Fsave_window_excursion):
8112 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8114 * lread.c (lisp_file_lexically_bound_p): New function.
8115 (Fload): Bind Qlexical_binding.
8116 (readevalloop): Remove `evalfun' arg.
8117 Bind Qinternal_interpreter_environment.
8118 (Feval_buffer): Bind Qlexical_binding.
8119 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8121 (syms_of_lread): Declare `lexical-binding'.
8123 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8125 * keyboard.c (eval_dyn): New fun.
8126 (menu_item_eval_property): Use it.
8128 * image.c (parse_image_spec): Use Ffunctionp.
8130 * fns.c (concat, mapcar1): Accept byte-code-functions.
8132 * eval.c (Fsetq): Handle lexical vars.
8133 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8134 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8135 (FletX, Flet): Obey lexical binding.
8136 (Fcommandp): Handle closures.
8137 (Feval): New `lexical' arg.
8138 (eval_sub): New function extracted from Feval. Use it almost
8139 everywhere where Feval was used. Look up vars in lexical env.
8141 (Ffunctionp): Move from subr.el.
8142 (Ffuncall): Handle closures.
8143 (apply_lambda): Remove `eval_flags'.
8144 (funcall_lambda): Handle closures and new byte-code-functions.
8145 (Fspecial_variable_p): New function.
8146 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8147 but without exporting it to Lisp.
8149 * doc.c (Fdocumentation, store_function_docstring):
8150 * data.c (Finteractive_form): Handle closures.
8152 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8155 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8157 (exec_byte_code): New function extracted from Fbyte_code to handle new
8158 calling convention for byte-code-functions. Add new byte-codes.
8160 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8162 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8164 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8166 * xdisp.c (redisplay_internal): Fix prototype.
8168 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8170 * xdisp.c (SCROLL_LIMIT): New macro.
8171 (try_scrolling): Use it when setting scroll_limit.
8172 Limit scrolling to 100 screen lines.
8173 (redisplay_window): Even when falling back on "recentering",
8174 position point in the window according to scroll-conservatively,
8175 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8177 (try_scrolling): When point is above the window, allow searching
8178 as far as scroll_max, or one screenful, to compute vertical
8179 distance from PT to the scroll margin position. This prevents
8180 try_scrolling from unnecessarily failing when
8181 scroll-conservatively is set to a value slightly larger than the
8182 window height. Clean up the case of PT below the margin at bottom
8183 of window: scroll_max can no longer be INT_MAX. When aggressive
8184 scrolling is in use, don't let point enter the opposite scroll
8185 margin as result of the scroll.
8186 (syms_of_xdisp) <scroll-conservatively>: Document the
8187 threshold of 100 lines for never-recentering scrolling.
8189 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8191 * dispextern.h (move_it_by_lines):
8192 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8193 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8194 (message_log_check_duplicate): Remove parameters `prev_bol' and
8195 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8196 (redisplay_internal): Remove parameter `preserve_echo_area',
8197 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8199 * indent.c (Fvertical_motion):
8200 * window.c (window_scroll_pixel_based, Frecenter):
8201 Don't pass `need_y_p' to `move_it_by_lines'.
8203 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8205 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8206 steal a few bits to be more compact.
8207 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8208 Remove unneeded casts.
8210 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8212 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8214 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8215 binding" message (bug#7967).
8217 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8219 Fix more problems found by GCC 4.6.0's static checks.
8221 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8222 Remove unused local var.
8224 * editfns.c (Fmessage_box): Remove unused local var.
8226 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8227 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8228 Omit unused local vars.
8229 * window.c (shrink_windows): Omit unused local var.
8230 * menu.c (digest_single_submenu): Omit unused local var.
8231 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8232 Omit unused local var.
8234 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8235 Don't assume string length fits in int.
8236 (keyremap_step, read_key_sequence): Use size_t for sizes.
8237 (read_key_sequence): Don't check last_real_key_start redundantly.
8239 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8240 instead of alloca (Bug#8344).
8242 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8243 (Fbacktrace_frame): Don't assume nframes fits in int.
8245 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8247 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8250 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8252 * cm.c (calccost): Turn while-do into do-while, for clarity.
8254 * keyboard.c (syms_of_keyboard): Use the same style as later
8255 in this function when indexing through an array. This also
8256 works around GCC bug 48267.
8258 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8260 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8262 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8263 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8265 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8266 This avoids undefined behavior on integer overflow, and is a bit
8267 more convenient anyway since it is compared to a size_t variable.
8269 Variadic C functions now count arguments with size_t, not int.
8270 This avoids an unnecessary limitation on 64-bit machines, which
8271 caused (substring ...) to crash on large vectors (Bug#8344).
8272 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8273 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8274 All variadic functions and their callers changed accordingly.
8275 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8276 * data.c (arith_driver, float_arith_driver): Likewise.
8277 * editfns.c (general_insert_function): Likewise.
8278 * eval.c (struct backtrace.nargs, interactive_p)
8279 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8280 (funcall_lambda, mark_backtrace): Likewise.
8281 * fns.c (concat): Likewise.
8282 * frame.c (x_set_frame_parameters): Likewise.
8283 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8284 0 if not found, not -1. All callers changed.
8286 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8287 (stack_copy_size): Now size_t, not int.
8288 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8290 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8292 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8293 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8294 All callers changed.
8296 * lisp.h (multibyte_char_to_unibyte):
8297 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8298 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8299 * character.h (CHAR_TO_BYTE8):
8300 * cmds.c (internal_self_insert):
8301 * editfns.c (general_insert_function):
8302 * keymap.c (push_key_description):
8303 * search.c (Freplace_match):
8304 * xdisp.c (message_dolog, set_message_1): All callers changed.
8306 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8308 * keyboard.c (safe_run_hook_funcall): New function.
8309 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8310 don't set the hook to nil, but remove the offending function instead.
8311 (Qcommand_hook_internal): Remove, unused.
8312 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8313 Vcommand_hook_internal.
8315 * eval.c (enum run_hooks_condition): Remove.
8316 (funcall_nil, funcall_not): New functions.
8317 (run_hook_with_args): Call each function through a `funcall' argument.
8318 Remove `cond' argument, now redundant.
8319 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8320 (Frun_hook_with_args_until_failure): Adjust accordingly.
8321 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8323 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8325 * dispextern.h (string_buffer_position): Remove declaration.
8327 * print.c (strout): Remove parameter `multibyte', unused since
8328 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8330 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8331 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8332 All callers changed.
8334 * w32.c (_wsa_errlist): Use braces for struct initializers.
8336 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8337 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8338 All callers changed.
8339 (string_buffer_position): Likewise. Also, make static (it's never
8340 used outside xdisp.c).
8341 (cursor_row_p): Remove parameter `w', unused since
8342 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8343 (decode_mode_spec): Remove parameter `precision', introduced during
8344 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8345 All callers changed.
8347 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8349 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8351 2011-03-27 Anders Lindgren <andlind@gmail.com>
8353 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8354 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8355 (ns_update_auto_hide_menu_bar): New functions.
8356 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8357 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8358 ns_constrain_all_frames.
8359 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8360 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8362 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8364 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8366 2011-03-27 Glenn Morris <rgm@gnu.org>
8368 * syssignal.h: Replace RETSIGTYPE with void.
8369 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8370 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8371 Replace SIGTYPE with void everywhere.
8372 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8373 * s/template.h (SIGTYPE): Remove commented out definition.
8375 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8377 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8378 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8380 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8382 * w32.c (read_unc_volume): Use parameter `henum', instead of
8383 global variable `wget_enum_handle'.
8385 * keymap.c (describe_vector): Remove parameters `indices' and
8386 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8387 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8389 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8391 * keyboard.c (timer_check): Remove parameter `do_it_now',
8392 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8393 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8394 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8396 * keyboard.c (read_char):
8397 * w32menu.c (w32_menu_display_help):
8398 * xmenu.c (show_help_event, menu_help_callback):
8399 Adjust calls to `show_help_echo'.
8401 * gtkutil.c (xg_maybe_add_timer):
8402 * keyboard.c (readable_events):
8403 * process.c (wait_reading_process_output):
8404 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8406 * insdel.c (adjust_markers_gap_motion):
8407 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8408 (gap_left, gap_right): Don't call it.
8410 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8412 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8413 incurred during fontification.
8415 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8417 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8418 (DEFVAR_PER_BUFFER): Don't pass it.
8420 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8421 (scrolling_window): Don't pass it.
8423 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8425 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8427 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8429 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8430 of variables specific to SELinux and computation of `encoded_absname'.
8432 * image.c (XPutPixel): Remove unused variable `height'.
8434 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8436 * unexw32.c (get_section_info): Remove unused variable `section'.
8438 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8439 (system_process_attributes): Remove unused variable `sess'.
8440 (sys_read): Remove unused variable `err'.
8442 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8443 (w32_wnd_proc): Remove unused variable `isdead'.
8444 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8445 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8446 (x_create_tip_frame): Remove unused variable `tem'.
8448 * w32inevt.c (w32_console_read_socket):
8449 Remove unused variable `no_events'.
8451 * w32term.c (x_draw_composite_glyph_string_foreground):
8452 Remove unused variable `width'.
8454 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8456 * w32term.c (x_set_glyph_string_clipping):
8457 Don't pass uninitialized region to CombineRgn.
8459 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8461 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8462 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8463 (Fx_close_connection): Remove unused variable `i'.
8465 * w32font.c (w32font_draw): Return number of glyphs.
8466 (w32font_open_internal): Remove unused variable `i'.
8467 (w32font_driver): Add missing initializer.
8469 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8470 (fill_in_menu): Remove unused variable `items_added'.
8472 * w32term.c (last_mouse_press_frame): Remove static global variable.
8473 (w32_clip_to_row): Remove unused variable `f'.
8474 (x_delete_terminal): Remove unused variable `i'.
8476 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8477 (NOTHING): Remove unused static global variable.
8478 (uniscribe_check_otf): Remove unused variable `table'.
8479 (uniscribe_font_driver): Add missing initializers.
8481 2011-03-23 Julien Danjou <julien@danjou.info>
8483 * term.c (Fsuspend_tty, Fresume_tty):
8484 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8485 * window.c (temp_output_buffer_show):
8486 * insdel.c (signal_before_change):
8487 * frame.c (Fhandle_switch_frame):
8488 * fileio.c (Fdo_auto_save):
8489 * emacs.c (Fkill_emacs):
8490 * editfns.c (save_excursion_restore):
8491 * cmds.c (internal_self_insert):
8492 * callint.c (Fcall_interactively):
8493 * buffer.c (Fkill_all_local_variables):
8494 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8496 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8497 unconditionally since it does the check itself.
8499 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8501 Fix more problems found by GCC 4.5.2's static checks.
8503 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8504 the first time through the loop, since we know p0 < p1 then.
8505 This also avoids a gcc -Wstrict-overflow warning.
8507 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8508 leading to a memory leak, possible in functions like
8509 load_charset_map_from_file that can allocate an unbounded number
8510 of objects (Bug#8318).
8512 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8513 that could (at least in theory) be that large.
8515 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8516 This is less likely to overflow, and avoids undefined behavior if
8517 overflow does occur. All callers changed. Use strtoul to scan
8518 for the unsigned long integer.
8519 (pint2hrstr): Simplify and tune code slightly.
8520 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8522 * scroll.c (do_scrolling): Work around GCC bug 48228.
8523 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8525 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8526 This also avoids a warning with gcc -Wstrict-overflow.
8527 (validate_x_resource_name): Simplify count usage.
8528 This also avoids a warning with gcc -Wstrict-overflow.
8530 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8533 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8535 * process.c (Fmake_network_process): Use socklen_t, not int,
8536 where POSIX says socklen_t is required in portable programs.
8537 This fixes a porting bug on hosts like 64-bit HP-UX, where
8538 socklen_t is wider than int (Bug#8277).
8539 (Fmake_network_process, server_accept_connection):
8540 (wait_reading_process_output, read_process_output):
8543 * process.c: Rename or move locals to avoid shadowing.
8544 (list_processes_1, Fmake_network_process):
8545 (read_process_output_error_handler, exec_sentinel_error_handler):
8546 Rename or move locals.
8547 (Fmake_network_process): Define label "retry_connect" only if needed.
8548 (Fnetwork_interface_info): Fix pointer signedness.
8549 (process_send_signal): Add cast to avoid pointer signedness problem.
8550 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8551 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8553 Make tparam.h and terminfo.c consistent.
8554 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8555 Include tparam.h instead, since it declares them.
8556 * cm.h (PC): Remove extern decl; tparam.h now does this.
8557 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8558 * terminfo.c: Include tparam.h, to check interfaces.
8559 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8560 (tparam): Adjust signature to match interface in tparam.h;
8561 this removes some undefined behavior. Check that outstring and len
8562 are zero, which they always are with Emacs.
8563 * tparam.h (PC, BC, UP): New extern decls.
8565 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8566 (xftfont_open): Rename locals to avoid shadowing.
8568 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8569 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8570 (OTF_TAG_SYM): Omit macro if not needed.
8571 (ftfont_list): Remove unused local.
8572 (get_adstyle_property, ftfont_pattern_entity):
8573 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8574 Rename locals to avoid shadowing.
8576 * xfont.c (xfont_list_family): Mark var as initialized.
8578 * xml.c (make_dom): Now static.
8580 * composite.c (composition_compute_stop_pos): Rename local to
8582 (composition_reseat_it): Remove unused locals.
8583 (find_automatic_composition, composition_adjust_point): Likewise.
8584 (composition_update_it): Mark var as initialized.
8585 (find_automatic_composition): Mark vars as initialized,
8586 with a FIXME (Bug#8290).
8588 character.h: Rename locals to avoid shadowing.
8589 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8590 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8591 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8592 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8595 * textprop.c (property_change_between_p): Remove; unused.
8597 * intervals.c (interval_start_pos): Now static.
8599 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8601 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8602 Rename locals to avoid shadowing.
8604 * sound.c (wav_play, au_play, Fplay_sound_internal):
8605 Fix pointer signedness.
8606 (alsa_choose_format): Remove unused local var.
8607 (wav_play): Initialize a variable to 0, to prevent undefined
8608 behavior (Bug#8278).
8610 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8612 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8614 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8615 clobbering (Bug#8298).
8616 * sysdep.c (sys_subshell): Likewise.
8617 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8619 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8620 This should get cleaned up, so that child_setup has the
8621 same signature on all platforms.
8623 * callproc.c (call_process_cleanup): Now static.
8624 (relocate_fd): Rename locals to avoid shadowing.
8626 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8628 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8629 not to be necessary, and produces flickering.
8631 2011-03-20 Glenn Morris <rgm@gnu.org>
8633 * config.in: Remove file.
8635 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8637 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8638 are now in src/globals.h.
8639 (syms_of_minibuf): Remove spurious & from previous change.
8641 2011-03-20 Leo Liu <sdl.web@gmail.com>
8643 * minibuf.c (completing-read-function): New variable.
8644 (completing-read-default): Rename from completing-read.
8645 (completing-read): Call completing-read-function.
8647 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8649 * xfaces.c (Fx_load_color_file):
8650 Read color file from absolute filename (bug#8250).
8652 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8654 * makefile.w32-in: Update dependencies.
8656 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8658 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8660 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8662 Fix more problems found by GCC 4.5.2's static checks.
8664 * process.c (make_serial_process_unwind, send_process_trap):
8665 (sigchld_handler): Now static.
8667 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8668 That way, the code declares only the vars that it needs.
8669 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8670 * s/cygwin.h (PTY_ITERATION): Likewise.
8671 * s/darwin.h (PTY_ITERATION): Likewise.
8672 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8674 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8675 * process.c (allocate_pty): Don't declare stb unless it's needed.
8677 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8678 (CONSTANTLIM): Remove; unused.
8679 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8680 Define only if needed.
8682 * unexelf.c (unexec): Name an expression,
8683 to avoid gcc -Wbad-function-cast warning.
8684 Use a different way to cause a compilation error if anyone uses
8685 n rather than nn, a way that does not involve shadowing.
8686 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8688 * deps.mk (unexalpha.o): Remove; unused.
8690 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8691 * unexec.h: New file.
8692 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8693 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8695 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8696 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8697 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8698 Change as necessary to match prototype in unexec.h.
8700 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8702 (back_comment, skip_chars): Mark vars as initialized.
8704 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8705 Rename locals to avoid shadowing.
8707 * lread.c (read1): Rewrite so as not to use empty "else".
8708 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8710 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8712 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8713 warning when compiling print.c.
8715 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8716 instead of using an uninitialized var.
8717 (font_sort_entities): Mark var as initialized.
8719 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8721 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8722 pointers to constants.
8723 (font_parse_fcname): Remove unused vars.
8724 (font_delete_unmatched): Now static.
8725 (font_get_spec): Remove; unused.
8726 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8727 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8728 Rename or move locals to avoid shadowing.
8730 * fns.c (require_nesting_list, require_unwind): Now static.
8731 (Ffillarray): Rename locals to avoid shadowing.
8733 * floatfns.c (domain_error2): Define only if needed.
8734 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8736 * alloc.c (mark_backtrace): Move decl from here ...
8737 * lisp.h: ... to here, so that it can be checked.
8739 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8740 (Fdefvar): Rewrite so as not to use empty "else".
8741 (lisp_indirect_variable): Name an expression,
8742 to avoid gcc -Wbad-function-cast warning.
8743 (Fdefvar): Rename locals to avoid shadowing.
8745 * callint.c (quotify_arg, quotify_args): Now static.
8746 (Fcall_interactively): Rename locals to avoid shadowing.
8747 Use const pointer when appropriate.
8749 * lisp.h (get_system_name, get_operating_system_release):
8750 Move decls here, to check interfaces.
8751 * process.c (get_operating_system_release): Move decl to lisp.h.
8752 * xrdb.c (get_system_name): Likewise.
8753 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8754 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8755 some of which prompt warnings from gcc -Wbad-function-cast.
8756 (Fformat_time_string, Fencode_time, Finsert_char):
8757 (Ftranslate_region_internal, Fformat):
8758 Rename or remove local vars to avoid shadowing.
8759 (Ftranslate_region_internal): Mark var as initialized.
8761 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8764 * lisp.h (eassert): Check that the argument compiles, even if
8765 ENABLE_CHECKING is not defined.
8767 * data.c (Findirect_variable): Name an expression, to avoid
8768 gcc -Wbad-function-cast warning.
8769 (default_value, arithcompare, arith_driver, arith_error): Now static.
8770 (store_symval_forwarding): Rename local to avoid shadowing.
8771 (Fmake_variable_buffer_local, Fmake_local_variable):
8772 Mark variables as initialized.
8773 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8775 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8776 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8777 Rename locals to avoid shadowing.
8778 (mark_stack): Move local variables into the #ifdef region where
8780 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8781 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8783 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8784 (GC_STRING_CHARS): Remove; not used.
8785 (Fmemory_limit): Cast sbrk's returned value to char *.
8787 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8788 avoids undefined behavior in theory.
8790 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8792 Use functions, not macros, for up- and down-casing (Bug#8254).
8793 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8794 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8795 to use the following functions instead of these macros.
8796 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8797 EMACS_INT, since callers assume the returned value fits in int.
8798 (upcase1): Likewise, for UPCASE_TABLE.
8799 (uppercasep, lowercasep, upcase): New static inline functions.
8800 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8801 the race-condition problem in the old DOWNCASE.
8803 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8804 Rename locals to avoid shadowing.
8805 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8806 (regex_compile, re_search_2, re_match_2_internal):
8807 Remove unused local vars.
8808 (FREE_VAR): Rewrite so as not to use empty "else",
8809 which gcc can warn about.
8810 (regex_compile, re_match_2_internal): Mark locals as initialized.
8811 (RETALLOC_IF): Define only if needed.
8812 (WORDCHAR_P): Likewise. This one is never needed, but is used
8813 only in a comment talking about a compiler bug, so put inside
8814 the #if 0 of that comment.
8815 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8816 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8819 * search.c (boyer_moore): Rename locals to avoid shadowing.
8820 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8821 (PREV_CHAR_BOUNDARY): Likewise.
8823 * search.c (simple_search): Remove unused var.
8825 * dired.c (compile_pattern): Move decl from here ...
8826 * lisp.h: ... to here, so that it can be checked.
8827 (struct re_registers): New forward decl.
8829 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8831 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8833 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8834 Rename locals to avoid shadowing.
8835 (Fvertical_motion): Mark locals as initialized.
8837 * casefiddle.c (casify_object, casify_region): Now static.
8838 (casify_region): Mark local as initialized.
8840 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8842 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8843 New macros, so that the caller can use some names other than
8844 gcpro1, gcpro2, etc.
8845 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8847 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8848 argument, for consistency with GCPRO2_VAR, etc: it is now the
8849 prefix of the variable, not the variable itself. All uses
8851 * dired.c (directory_files_internal, file_name_completion):
8852 Rename locals to avoid shadowing.
8854 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8855 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8856 dired.c's scmp function, had undefined behavior.
8857 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8858 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8859 * buffer.h: ... to here, because these macros use current_buffer,
8860 and the new implementation with inline functions needs to have
8861 current_buffer in scope now, rather than later when the macros
8863 (downcase, upcase1): New static inline functions.
8864 (DOWNCASE, UPCASE1): Reimplement using these functions.
8865 This avoids undefined behavior in expressions like
8866 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8867 from race conditions in accessing the global variables
8868 case_temp1 and case_temp2.
8869 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8870 * lisp.h (case_temp1, case_temp2): Remove their decls.
8871 * character.h (ASCII_CHAR_P): Move from here ...
8872 * lisp.h: ... to here, so that the inline functions mentioned
8875 * dired.c (directory_files_internal_unwind): Now static.
8877 * fileio.c (file_name_as_directory, directory_file_name):
8878 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8880 (file_name_as_directory): Use const pointers when appropriate.
8881 (Fexpand_file_name): Likewise. In particular, newdir might
8882 point at constant storage, so make it a const pointer.
8883 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8884 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8886 (Fset_file_times, Finsert_file_contents, auto_save_error):
8887 Rename locals to avoid shadowing.
8889 * minibuf.c (choose_minibuf_frame_1): Now static.
8890 (Ftry_completion, Fall_completions): Rename or remove locals
8893 * marker.c (bytepos_to_charpos): Remove; unused.
8895 * lisp.h (verify_bytepos, count_markers): New decls,
8896 so that gcc does not warn that these functions aren't declared.
8898 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8899 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8900 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8901 (copy_text): Remove unused local var.
8903 * filelock.c (within_one_second): Now static.
8904 (lock_file_1): Rename local to avoid shadowing.
8906 * buffer.c (fix_overlays_before): Mark locals as initialized.
8907 (fix_start_end_in_overlays): Likewise. This function should be
8908 simplified by using pointers-to-pointers, but that's a different
8910 (switch_to_buffer_1): Now static.
8911 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8912 (report_overlay_modification): Rename locals to avoid shadowing.
8914 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8915 Fix pointer signedness issue.
8916 (sys_subshell): Mark local as volatile if checking for lint,
8917 to suppress a gcc -Wclobbered warning that does not seem to be right.
8918 (MAXPATHLEN): Define only if needed.
8920 * process.c (serial_open, serial_configure): Move decls from here ...
8921 * systty.h: ... to here, so that they can be checked.
8923 * fns.c (get_random, seed_random): Move extern decls from here ...
8924 * lisp.h: ... to here, so that they can be checked.
8926 * sysdep.c (reset_io): Now static.
8927 (wait_for_termination_signal): Remove; unused.
8929 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8930 (copy_keymap_item, append_key, push_text_char_description):
8932 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8933 (DENSE_TABLE_SIZE): Remove; unused.
8934 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8935 (describe_map_tree):
8936 Rename locals to avoid shadowing.
8938 * keyboard.c: Declare functions static if they are not used elsewhere.
8939 (echo_char, echo_dash, cmd_error, top_level_2):
8940 (poll_for_input, handle_async_input): Now static.
8941 (read_char, kbd_buffer_get_event, make_lispy_position):
8942 (make_lispy_event, make_lispy_movement, apply_modifiers):
8943 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8944 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8945 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8946 (read_key_sequence, read_char): Mark locals as initialized.
8947 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8949 * keyboard.h (make_ctrl_char): New decl.
8950 (mark_kboards): Move decl here ...
8951 * alloc.c (mark_kboards): ... from here.
8953 * lisp.h (force_auto_save_soon): New decl.
8955 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8956 (DEFINE_DUMMY_FUNCTION): New macro.
8957 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8959 (main): Add casts to avoid warnings
8960 if GCC considers string literals to be constants.
8962 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8964 * dbusbind.c: Pointer signedness fixes.
8965 (xd_signature, xd_append_arg, xd_initialize):
8966 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8967 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8968 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8969 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8971 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8972 if GCC considers string literals to be constants.
8973 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8975 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8977 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8978 (print_preprocess, print_object): New macro to fix last change.
8980 * print.c (print_preprocess): Don't forget font objects.
8982 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8984 * emacs.c (USAGE3): Doc fixes.
8986 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8988 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8991 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8993 * lisp.h (VWindow_system, Qfile_name_history):
8994 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8995 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8996 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8998 * w32select.c: Don't #include "keyboard.h".
8999 (run_protected): Add extern declaration for waiting_for_input.
9001 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9002 * w32console.c (detect_input_pending, read_input_pending)
9003 (encode_terminal_code):
9004 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9005 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9006 (w32_system_caret_y, Qfile_name_history):
9007 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9008 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9009 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9010 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9011 * w32proc.c (Qlocal, report_file_error):
9012 * w32term.c (Vwindow_system, updating_frame):
9013 * w32uniscribe.c (initialized, uniscribe_font_driver):
9014 Remove unneeded extern declarations.
9016 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9018 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9020 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9022 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9023 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9024 These macros can no longer be used for assignment.
9026 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9027 Assign struct members directly, instead of using BUF_BEGV etc.
9028 (record_buffer_markers, fetch_buffer_markers): New functions for
9029 recording and fetching special buffer markers.
9030 (set_buffer_internal_1, set_buffer_temp): Use them.
9032 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9034 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9036 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9037 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9039 * xdisp.c (hscroll_window_tree):
9040 (reconsider_clip_changes): Use PT instead of BUF_PT.
9042 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9044 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9045 $(EMACS_ROOT)/lib/intprops.h.
9047 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9049 Fix more problems found by GCC 4.5.2's static checks.
9051 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9052 to unsigned char * to avoid compiler diagnostic.
9053 (xg_free_frame_widgets): Make it clear that a local variable is
9054 needed only if USE_GTK_TOOLTIP.
9055 (gdk_window_get_screen): Make it clear that this macro is needed
9056 only if USE_GTK_TOOLTIP.
9057 (int_gtk_range_get_value): New function, which avoids a diagnostic
9058 from gcc -Wbad-function-cast.
9059 (xg_set_toolkit_scroll_bar_thumb): Use it.
9060 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9061 diagnostic from gcc -Wbad-function-cast.
9062 (get_utf8_string, xg_get_file_with_chooser):
9063 Rename locals to avoid shadowing.
9064 (create_dialog): Move locals to avoid shadowing.
9066 * xgselect.c (xg_select): Remove unused var.
9068 * image.c (four_corners_best): Mark locals as initialized.
9069 (gif_load): Initialize transparent_p to zero (Bug#8238).
9070 Mark another local as initialized.
9071 (my_png_error, my_error_exit): Mark with NO_RETURN.
9073 * image.c (clear_image_cache): Now static.
9074 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9075 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9076 (x_edge_detection): Remove unnecessary cast that
9077 gcc -Wbad-function-cast diagnoses.
9078 (gif_load): Fix pointer signedness.
9079 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9080 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9082 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9084 Improve quality of tests for time stamp overflow.
9085 For example, without this patch (encode-time 0 0 0 1 1
9086 1152921504606846976) returns the obviously-bogus value (-948597
9087 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9088 reports time overflow. See
9089 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9090 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9091 * editfns.c: Include limits.h and intprops.h.
9092 (TIME_T_MIN, TIME_T_MAX): New macros.
9093 (time_overflow): Move earlier, to before first use.
9094 (hi_time, lo_time): New functions, for an accurate test for
9096 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9097 (Fget_internal_run_time): Don't assume time_t fits in int.
9098 (make_time): Use list2 instead of Fcons twice.
9099 (Fdecode_time): More accurate test for out-of-range times.
9100 (check_tm_member): New function.
9101 (Fencode_time): Use it, to test for out-of-range times.
9102 (lisp_time_argument): Don't rely on undefined left-shift and
9103 right-shift behavior when checking for time stamp overflow.
9105 * editfns.c (time_overflow): New function, refactoring common code.
9106 (Fformat_time_string, Fdecode_time, Fencode_time):
9107 (Fcurrent_time_string): Use it.
9109 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9110 * dired.c (make_time): Move to ...
9111 * editfns.c (make_time): ... here.
9112 * systime.h: Note the move.
9114 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9116 * fringe.c (update_window_fringes): Remove unused variables.
9118 * unexmacosx.c (copy_data_segment): Also copy __got section.
9121 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9123 * termcap.c [MSDOS]: Include "msdos.h".
9124 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9125 Constify `char *' arguments and their references according to
9126 prototypes in tparam.h.
9128 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9130 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9131 Adapt all references accordingly.
9133 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9135 2011-03-11 Tom Tromey <tromey@redhat.com>
9137 * buffer.c (syms_of_buffer): Remove obsolete comment.
9139 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9141 * termhooks.h (encode_terminal_code): Declare prototype.
9143 * msdos.c (encode_terminal_code): Don't declare prototype.
9145 * term.c (encode_terminal_code): Now external again, used by
9146 w32console.c and msdos.c.
9148 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9149 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9151 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9153 Fix some minor problems found by GCC 4.5.2's static checks.
9155 * fringe.c (update_window_fringes): Mark locals as initialized
9157 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9159 * alloc.c (mark_fringe_data): Move decl from here ...
9160 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9161 to check its interface.
9162 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9164 * fontset.c (free_realized_fontset): Now static.
9165 (Fset_fontset_font): Rename local to avoid shadowing.
9166 (fontset_font): Mark local as initialized.
9167 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9169 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9171 * xselect.c (x_disown_buffer_selections): Remove; not used.
9172 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9173 (x_own_selection, Fx_disown_selection_internal): Rename locals
9175 (x_handle_dnd_message): Remove local to avoid shadowing.
9177 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9178 so that the caller can use some name other than gcpro1.
9179 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9180 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9181 (Fx_backspace_delete_keys_p):
9182 Use them to avoid shadowing, and rename vars to avoid shadowing.
9183 (x_decode_color, x_set_name, x_window): Now static.
9184 (Fx_create_frame): Add braces to silence GCC warning.
9185 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9186 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9187 Remove unused locals.
9188 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9189 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9190 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9193 * xterm.h (x_mouse_leave): New decl.
9195 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9196 Remove unused functions.
9197 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9198 (x_calc_absolute_position): Now static.
9199 (XTread_socket): Don't define label "out" unless it's used.
9200 Don't declare local "event" unless it's used.
9201 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9202 unless they are used.
9203 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9204 (x_fatal_error_signal): Remove; not used.
9205 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9206 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9207 (x_error_catcher, x_connection_closed, x_error_handler):
9208 (x_error_quitter, xembed_send_message, x_iconify_frame):
9209 (my_log_handler): Rename locals to avoid shadowing.
9210 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9211 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9213 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9214 Rename or move locals to avoid shadowing.
9215 (tty_defined_color, merge_face_heights): Now static.
9216 (free_realized_faces_for_fontset): Remove; not used.
9217 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9218 does not deduce is never used uninitialized.
9219 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9220 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9222 * terminal.c (store_terminal_param): Now static.
9224 * xmenu.c (menu_highlight_callback): Now static.
9225 (set_frame_menubar): Remove unused local.
9226 (xmenu_show): Rename parameter to avoid shadowing.
9227 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9228 since they might point to immutable storage.
9229 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9230 since it's unused otherwise.
9232 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9233 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9234 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9235 avoids a gcc -Wuninitialized diagnostic.
9236 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9237 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9238 does not deduce are never used uninitialized.
9240 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9242 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9243 * window.c (window_loop, size_window):
9244 (run_window_configuration_change_hook, enlarge_window): Likewise.
9246 * window.c (display_buffer): Now static.
9247 (size_window): Mark variables that gcc -Wuninitialized
9248 does not deduce are never used uninitialized.
9249 * window.h (check_all_windows): New decl, to forestall
9250 gcc -Wmissing-prototypes diagnostic.
9251 * dispextern.h (bidi_dump_cached_states): Likewise.
9253 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9255 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9257 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9258 and to avoid gcc -Wuninitialized warning.
9259 (load_charset_map): Mark variables that gcc -Wuninitialized
9260 does not deduce are never used uninitialized.
9261 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9263 * coding.c (coding_set_source, coding_set_destination):
9264 Use "else { /* comment */ }" rather than "else /* comment */;"
9265 for clarity, and to avoid gcc -Wempty-body warning.
9266 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9267 a block, when the outer 'i' will do.
9268 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9269 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9270 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9271 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9272 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9273 Rename locals to avoid shadowing.
9274 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9275 * coding.c (emacs_mule_char, encode_invocation_designation):
9276 Now static, since they're not used elsewhere.
9277 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9278 (decode_coding_object, encode_coding_object, detect_coding_system):
9279 (decode_coding_emacs_mule): Mark variables that gcc
9280 -Wuninitialized does not deduce are never used uninitialized.
9281 (detect_coding_iso_2022): Initialize a local variable that might
9282 be used uninitialized. Leave a FIXME because it's not clear that
9283 this initialization is needed. (Bug#8211)
9284 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9285 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9286 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9287 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9288 Remove unused macros.
9290 * category.c (hash_get_category_set): Remove unused local var.
9291 (copy_category_table): Now static, since it's not used elsewhere.
9292 * character.c (string_count_byte8): Likewise.
9294 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9295 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9297 * chartab.c (copy_sub_char_table): Now static, since it's not used
9299 (sub_char_table_ref_and_range, char_table_ref_and_range):
9300 Rename locals to avoid shadowing.
9301 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9303 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9304 (BIDI_BOB): Remove unused macro.
9306 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9307 deduce are never used uninitialized.
9308 * term.c (encode_terminal_code): Likewise.
9310 * term.c (encode_terminal_code): Now static. Remove unused local.
9312 * tparam.h: New file.
9313 * term.c, tparam.h: Include it.
9314 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9315 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9316 Move these decls to tparam.h, and make them agree with what
9317 is actually in tparam.c. The previous trick of using incompatible
9318 decls in different modules does not conform to the C standard.
9319 All callers of tparam changed to use tparam's actual API.
9320 * tparam.c (tparam1, tparam, tgoto):
9321 Use const pointers where appropriate.
9323 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9324 * cm.h (struct cm): Likewise.
9325 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9326 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9327 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9328 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9329 (turn_on_face, init_tty): Likewise.
9330 * termchar.h (struct tty_display_info): Likewise.
9332 * term.c (term_mouse_position): Rename local to avoid shadowing.
9334 * alloc.c (mark_ttys): Move decl from here ...
9335 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9337 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9339 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9341 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9343 * search.c (compile_pattern_1): Remove argument regp, unused since
9344 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9345 (compile_pattern): Don't pass it.
9347 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9349 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9350 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9352 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9354 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9356 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9357 gdk_window_get_screen, gdk_window_get_geometry,
9358 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9359 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9360 (xg_get_pixbuf_from_pixmap): New function.
9361 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9362 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9363 Call xg_get_pixbuf_from_pixmap instead of
9364 gdk_pixbuf_get_from_drawable.
9365 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9366 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9367 (xg_check_special_colors): Use GtkStyleContext and its functions
9369 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9370 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9371 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9372 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9373 Call gtk_widget_get_preferred_size.
9374 (xg_frame_resized): gdk_window_get_geometry only takes 5
9376 (xg_win_to_widget, xg_event_is_for_menubar):
9377 Call gdk_x11_window_lookup_for_display.
9378 (xg_set_widget_bg): New function.
9379 (delete_cb): New function.
9380 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9381 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9382 (xg_set_background_color): Call xg_set_widget_bg.
9383 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9384 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9385 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9386 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9388 (update_frame_tool_bar): Call gtk_widget_hide.
9389 (xg_initialize): Use GDK_KEY_g.
9391 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9393 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9395 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9396 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9397 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9399 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9401 * w32xfns.c (select_palette): Check success of RealizePalette against
9402 GDI_ERROR, not zero.
9404 See ChangeLog.11 for earlier changes.
9410 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9412 This file is part of GNU Emacs.
9414 GNU Emacs is free software: you can redistribute it and/or modify
9415 it under the terms of the GNU General Public License as published by
9416 the Free Software Foundation, either version 3 of the License, or
9417 (at your option) any later version.
9419 GNU Emacs is distributed in the hope that it will be useful,
9420 but WITHOUT ANY WARRANTY; without even the implied warranty of
9421 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9422 GNU General Public License for more details.
9424 You should have received a copy of the GNU General Public License
9425 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.