1 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3 * search.c (searchbufs, searchbuf_head): Now static.
5 * scroll.c (scroll_cost): Remove; unused.
6 * dispextern.h (scroll_cost): Remove decl.
8 * region-cache.h (pp_cache): Mark as externally visible.
10 * process.c: Make symbols static if they're not exported.
11 (process_tick, update_tick, create_process, chan_process):
12 (Vprocess_alist, proc_buffered_char, datagram_access):
13 (fd_callback_data, send_process_frame, process_sent_to): Now static.
14 (deactivate_process): Mark defn as static, as well as decl.
15 * lisp.h (create_process): Remove decl.
16 * process.h (chan_process, Vprocess_alist): Remove decls.
18 * print.c: Make symbols static if they're not exported.
19 (print_depth, new_backquote_output, being_printed, print_buffer):
20 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
21 (print_interval, print_number_index, initial_stderr_stream):
23 * lisp.h (Fprinc): Remove decl.
24 (debug_output_compilation_hack): Mark as externally visible.
26 * sysdep.c (croak): Move decl from here to syssignal.h.
27 * syssignal.h (croak): Put it here, so the API can be checked when
28 'croak' is called from dissociate_if_controlling_tty.
30 * minibuf.c: Make symbols static if they're not exported.
31 (minibuf_save_list, choose_minibuf_frame): Now static.
32 * lisp.h (choose_minibuf_frame): Remove decl.
34 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
36 * lread.c: Make symbols static if they're not exported.
37 (read_objects, initial_obarray, oblookup_last_bucket_number):
39 (make_symbol): Remove; unused.
40 * lisp.h (initial_obarray, make_symbol): Remove decls.
42 * keyboard.c: Make symbols static if they're not exported.
43 (single_kboard, recent_keys_index, total_keys, recent_keys):
44 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
45 (this_single_command_key_start, echoing, last_auto_save):
46 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
47 (command_loop, echo_now, keyboard_init_hook, help_char_p):
48 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
49 (Vlispy_mouse_stem, double_click_count):
51 (force_auto_save_soon): Define only if SIGDANGER.
52 (ignore_mouse_drag_p): Now static if
53 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
54 (print_help): Remove; unused.
55 (stop_character, last_timer_event): Mark as externally visible.
56 * keyboard.h (ignore_mouse_drag_p): Declare only if
57 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
58 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
59 * lisp.h (echoing): Remove decl.
60 (force_auto_save_soon): Declare only if SIGDANGER.
61 * xdisp.c (redisplay_window): Simplify code, to make it more
62 obvious that ignore_mouse_drag_p is not accessed if !defined
63 USE_GTK && !defined HAVE_NS.
65 * intervals.c: Make symbols static if they're not exported.
66 (merge_properties_sticky, merge_interval_right, delete_interval):
68 * intervals.h (merge_interval_right, delete_interval): Remove decls.
70 2011-04-13 Paul Eggert <eggert@cs.ucla.edu>
72 * insdel.c: Make symbols static if they're not exported.
73 However, leave prepare_to_modify_buffer alone. It's never
74 called from outside this function, but that appears to be a bug.
75 (combine_after_change_list, combine_after_change_buffer):
76 (adjust_after_replace, signal_before_change): Now static.
77 (adjust_after_replace_noundo): Remove; unused.
78 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
79 (signal_before_change): Remove decls.
81 * indent.c (val_compute_motion, val_vmotion): Now static.
83 * image.c: Make symbols static if they're not exported.
84 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
86 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
87 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
89 * fringe.c (standard_bitmaps): Now static.
90 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
92 * frame.c: Make symbols static if they're not exported.
93 (x_report_frame_params, make_terminal_frame): Now static.
94 (get_frame_param): Now static, unless HAVE_NS.
95 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
96 (x_get_resource_string): Remove; not used.
97 * frame.h (make_terminal_frame, x_report_frame_params):
98 (x_get_resource_string); Remove decls.
99 (x_fullscreen_adjust): Declare only if WINDOWSNT.
100 * lisp.h (get_frame_param): Declare only if HAVE_NS.
102 * font.c, fontset.c: Make symbols static if they're not exported.
103 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
104 (FACE_SUITABLE_FOR_CHAR_P): Use it.
105 * font.c (font_close_object): Now static.
106 * font.h (font_close_object): Remove.
107 * fontset.c (FONTSET_OBJLIST): Remove.
108 (free_realized_fontset) #if-0 the body, which does nothing.
109 (face_suitable_for_char_p): #if-0, as it's never called.
110 * fontset.h (face_suitable_for_char_p): Remove decl.
111 * xfaces.c (face_at_string_position): Use
112 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
113 since 0 is always ASCII.
115 * fns.c (weak_hash_tables): Now static.
117 * fileio.c: Make symbols static if they're not exported.
118 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
119 (Vwrite_region_annotation_buffers): Now static.
121 * eval.c: Make symbols static if they're not exported.
122 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
123 * lisp.h (backtrace_list): Remove decl.
125 * emacs.c: Make symbols static if they're not exported.
126 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
127 (fatal_error_code, fatal_error_signal_hook, standard_args):
129 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
130 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
131 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
132 * lisp.h (fatal_error_signal_hook): Remove decl.
133 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
135 * editfns.c: Move a (normally-unused) function to its only use.
136 * editfns.c, lisp.h (get_operating_system_release): Remove.
137 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
138 worth the hassle of breaking this out.
140 * xterm.c: Make symbols static if they're not exported.
141 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
142 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
143 (x_destroy_window, x_delete_display):
145 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
146 (x_mouse_leave): Remove; unused.
147 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
148 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
149 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
151 (x_mouse_leave): Declare only if WINDOWSNT.
152 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
153 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
156 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
158 * ftxfont.c: Make symbols static if they're not exported.
159 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
161 * font.h (ftxfont_driver): Likewise.
163 * xfns.c: Make symbols static if they're not exported.
164 (x_last_font_name, x_display_info_for_name):
165 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
166 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
167 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
168 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
169 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
170 (last_show_tip_args): Now static.
171 (xic_defaut_fontset, xic_create_fontsetname): Define only if
172 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
173 (x_screen_planes): Remove; unused.
174 * dispextern.h (x_screen_planes): Remove decl.
176 * dispnew.c: Make symbols static if they're not exported.
177 * dispextern.h (redraw_garbaged_frames, scrolling):
178 (increment_row_positions): Remove.
179 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
180 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
182 (redraw_garbaged_frames): Remove; unused.
184 * xfaces.c: Make symbols static if they're not exported.
185 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
187 * xterm.h (defined_color): Remove decls.
188 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
189 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
190 (menu_face_changed_default, defined_color, free_realized_face):
191 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
192 (ascii_face_of_lisp_face): Remove; unused.
194 * xdisp.c: Make symbols static if they're not exported.
195 * dispextern.h (scratch_glyph_row, window_box_edges):
196 (glyph_to_pixel_coords, set_cursor_from_row):
197 (get_next_display_element, set_iterator_to_next):
198 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
199 (show_mouse_face): Remove decls
200 * frame.h (message_buf_print): Likewise.
201 * lisp.h (pop_message, set_message, check_point_in_composition):
203 * xterm.h (set_vertical_scroll_bar): Likewise.
204 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
205 (message_buf_print, scratch_glyph_row, displayed_buffer):
206 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
207 (get_next_display_element, show_mouse_face, window_box_edges):
208 (frame_to_window_pixel_xy, check_point_in_composition):
209 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
210 (glyph_to_pixel_coords): Remove; unused.
212 * dired.c (file_name_completion): Now static.
214 * dbusbind.c (xd_in_read_queued_messages): Now static.
216 * lisp.h (circular_list_error, FOREACH): Remove; unused.
217 * data.c (circular_list_error): Remove.
219 2011-04-11 Paul Eggert <eggert@cs.ucla.edu>
221 * commands.h (last_point_position, last_point_position_buffer):
222 (last_point_position_window): Remove decls.
223 * keyboard.c: Make these variables static.
225 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
227 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
228 (iso_code_class, detect_coding, code_convert_region): Now static.
229 (encode_coding_gap): Remove; unused.
231 * chartab.c (chartab_chars, chartab_bits): Now static.
233 * charset.h (charset_iso_8859_1): Remove decl.
234 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
237 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
238 * ccl.c (Vccl_program_table): Now static.
239 (check_ccl_update): Remove; unused.
241 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
242 * category.h: ... from here.
243 * category.c (check_category_table, set_category_set): Now static.
245 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
246 * lisp.h: Remove these decls.
248 * buffer.c (buffer_count): Remove unused var.
250 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
251 so that it's not optimized away.
252 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
253 * dispextern.h (bidi_dump_cached_states): Remove, since it's
254 exported only to the debugger.
256 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
257 * atimer.h (run_all_atimers): Removed; not exported.
259 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
260 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
261 was inaccessible from Lisp.
262 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
263 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
265 alloc.c: Import and export fewer symbols, and remove unused items.
266 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
268 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
269 it's not optimized away by whole-program optimization.
270 (message_enable_multibyte, free_misc): Remove.
271 (catchlist, handlerlist, mark_backtrace):
272 Declare only if BYTE_MARK_STACK.
273 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
274 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
275 (message_enable_multibyte): Remove decl.
276 (free_misc, interval_free_list, float_block, float_block_index):
277 (n_float_blocks, float_free_list, cons_block, cons_block_index):
278 (cons_free_list, last_marked_index):
280 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
281 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
282 (mark_backtrace): Define only if BYTE_MARK_STACK.
283 * xdisp.c (message_enable_multibyte): Now static.
285 Declare Lisp_Object Q* variables to be 'static' if not exproted.
286 This makes it easier for human readers (and static analyzers)
287 to see whether these variables are used from other modules.
288 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
289 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
290 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
291 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
292 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
293 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
294 * xmenu.c, xselect.c:
295 Declare Q* vars static if they are not used in other modules.
296 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
297 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
298 Remove decls of unexported vars.
299 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
301 * lisp.h (DEFINE_FUNC): Make sname 'static'.
303 Make Emacs functions such as Fatom 'static' by default.
304 This makes it easier for human readers (and static analyzers)
305 to see whether these functions can be called from other modules.
306 DEFUN now defines a static function. To make the function external
307 so that it can be used in other C modules, use the new macro DEFUE.
308 * lisp.h (DEFINE_FUNC): New macro, with the old contents of DEFUN.
309 (DEFUN): Rewrite in terms of DEFINE_FUNC. It now generates a
310 static function definition. Use DEFUE if you want an extern one.
311 (DEFUE, INFUN): New macros.
312 (Funibyte_char_to_multibyte, Fsyntax_table_p, Finit_image_library):
313 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
314 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
315 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
316 Remove decls, since these functions are now static.
317 (Funintern, Fget_internal_run_time): New decls, since these functions
318 were already external.
320 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
321 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
322 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
323 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
324 * keyboard.c, keymap.c, lread.c:
325 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
326 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
327 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
328 Mark functions with DEFUE instead of DEFUN,
329 if they are used in other modules.
330 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
331 decls for now-static functions.
332 * buffer.h (Fdelete_overlay): Remove decl.
333 * callproc.c (Fgetenv_internal): Mark as internal.
334 * composite.c (Fremove_list_of_text_properties): Remove decl.
335 (Fcomposition_get_gstring): New forward static decl.
336 * composite.h (Fcomposite_get_gstring): Remove decl.
337 * dired.c (Ffile_attributes): New forward static decl.
338 * doc.c (Fdocumntation_property): New forward static decl.
339 * eval.c (Ffetch_bytecode): New forward static decl.
340 (Funintern): Remove extern decl; now in .h file where it belongs.
341 * fileio.c (Fmake_symbolic_link): New forward static decl.
342 * image.c (Finit_image_library): New forward static decl.
343 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
344 * intervals.h (Fprevious_property_change):
345 (Fremove_list_of_text_properties): Remove decls.
346 * keyboard.c (Fthis_command_keys): Remove decl.
347 (Fcommand_execute): New forward static decl.
348 * keymap.c (Flookup_key): New forward static decl.
349 (Fcopy_keymap): Now static.
350 * keymap.h (Flookup_key): Remove decl.
351 * process.c (Fget_process): New forward static decl.
352 (Fprocess_datagram_address): Mark as internal.
353 * syntax.c (Fsyntax_table_p): New forward static decl.
354 (skip_chars): Remove duplicate decl.
355 * textprop.c (Fprevious_property_change): New forward static decl.
356 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
358 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
359 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
361 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
363 * editfns.c (Fformat): Remove unreachable code.
365 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
367 Fix more problems found by GCC 4.6.0's static checks.
369 * xdisp.c (vmessage): Use a better test for character truncation.
371 * charset.c (load_charset_map): <, not <=, for optimization,
372 and to avoid potential problems with integer overflow.
373 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
374 * casetab.c (set_identity, shuffle): Likewise.
375 * editfns.c (Fformat): Likewise.
376 * syntax.c (skip_chars): Likewise.
378 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
379 This also lets GCC 4.6.0 generate slightly better loop code.
381 * callint.c (Fcall_interactively): <, not <=, for optimization.
382 (Fcall_interactively): Count the number of arguments produced,
383 not the number of arguments given. This is simpler and lets GCC
384 4.6.0 generate slightly better code.
386 * ftfont.c: Distingish more carefully between FcChar8 and char.
387 The previous code passed unsigned char * to a functions like
388 strlen and xstrcasecmp that expect char *, which does not
389 conform to the C standard.
390 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
391 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
392 char * when the C standard requires it.
394 * keyboard.c (read_char): Remove unused var.
396 * eval.c: Port to Windows vsnprintf (Bug#8435).
398 (SIZE_MAX): Define if the headers do not.
399 (verror): Do not give up if vsnprintf returns a negative count.
400 Instead, grow the buffer. This ports to Windows vsnprintf, which
401 does not conform to C99. Problem reported by Eli Zaretskii.
402 Also, simplify the allocation scheme, by avoiding the need for
403 calling realloc, and removing the ALLOCATED variable.
405 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
407 Remove invocations of doprnt, as Emacs now uses vsnprintf.
408 But keep the doprint source code for now, as we might revamp it
409 and use it again (Bug#8435).
410 * lisp.h (doprnt): Remove.
411 * Makefile.in (base_obj): Remove doprnt.o.
412 * deps.mk (doprnt.o): Remove.
414 error: Print 32- and 64-bit integers portably (Bug#8435).
415 Without this change, on typical 64-bit hosts error ("...%d...", N)
416 was used to print both 32- and 64-bit integers N, which relied on
418 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
420 * lisp.h (error, verror): Mark as printf-like functions.
421 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
422 Report overflow in size calculations when allocating printf buffer.
423 Do not truncate output string at its first null byte.
424 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
425 Truncate the output at a character boundary, since vsnprintf does not
427 * charset.c (check_iso_charset_parameter): Convert internal
428 character to string before calling 'error', since %c now has the
430 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
431 overflow when computing char to be passed to 'error'. Do not
432 pass Lisp_Object to 'error'; pass the integer instead.
433 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
434 formatted with plain %d.
436 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
438 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
440 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
442 * xterm.c (x_catch_errors): Remove duplicate declaration.
444 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
446 * xdisp.c, lisp.h (message_nolog): Remove; unused.
448 2011-04-10 Jim Meyering <meyering@redhat.com>
450 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
451 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
452 return ssize_t not "int", and use size_t as the buffer length.
453 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
454 * gnutls.h: Update declarations.
455 * process.c (read_process_output): Use ssize_t, to match.
456 (send_process): Likewise.
458 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
460 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
462 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
464 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
465 unsigned char, to match FcChar8 type definition.
467 * xterm.c (handle_one_xevent):
468 * xmenu.c (create_and_show_popup_menu):
469 * xselect.c (x_decline_selection_request)
470 (x_reply_selection_request): Avoid type-punned deref of X events.
472 2011-04-09 Eli Zaretskii <eliz@emacstest.gnu.org>
474 Fix some uses of `int' instead of EMACS_INT.
475 * search.c (string_match_1, fast_string_match)
476 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
477 (scan_buffer, find_next_newline_no_quit)
478 (find_before_next_newline, search_command, Freplace_match)
479 (Fmatch_data): Make some `int' variables be EMACS_INT.
481 * xdisp.c (display_count_lines): 3rd argument and return value now
482 EMACS_INT. All callers changed.
483 (pint2hrstr): Last argument is now EMACS_INT.
485 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
486 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
487 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
488 (decode_coding_utf_16, decode_coding_emacs_mule)
489 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
490 (decode_coding_ccl, decode_coding_charset)
491 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
492 (decode_coding_iso_2022, decode_coding_emacs_mule)
493 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
494 <char_offset, last_offset>: Declare EMACS_INT.
495 (encode_coding_utf_8, encode_coding_utf_16)
496 (encode_coding_emacs_mule, encode_invocation_designation)
497 (encode_designation_at_bol, encode_coding_iso_2022)
498 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
499 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
501 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
502 (encode_invocation_designation): Last argument P_NCHARS is now
504 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
505 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
507 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
510 * ccl.c (Fccl_execute_on_string): Declare some variables
513 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
515 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
517 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
519 * process.c (Fformat_network_address): Doc fix.
521 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
523 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
525 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
527 * keyboard.c (read_char): Call Lisp function help-form-show,
528 instead of using internal_with_output_to_temp_buffer.
529 (Qhelp_form_show): New var.
530 (syms_of_keyboard): Use DEFSYM macro.
532 * print.c (internal_with_output_to_temp_buffer): Function deleted.
534 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
536 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
538 * process.c (Flist_processes): Removed to Lisp.
539 (list_processes_1): Deleted.
541 2011-04-06 Eli Zaretskii <eliz@gnu.org>
543 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
545 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
547 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
549 Fix more problems found by GCC 4.6.0's static checks.
551 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
553 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
555 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
557 * xdisp.c (vmessage): Mark as a printf-like function.
559 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
561 * sound.c (sound_warning): Don't crash if arg contains a printf format.
563 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
564 printf-like functions.
565 (tiff_load): Add casts to remove these marks before passing them
566 to system-supplied API.
568 * eval.c (Fsignal): Remove excess argument to 'fatal'.
570 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
571 This avoids several warnings with gcc -Wstrict-overflow.
572 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
573 directly, rather than having caller test rule sign. This avoids
574 some unnecessary tests.
575 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
576 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
577 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
579 * xfont.c (xfont_text_extents): Remove var that was set but not used.
580 (xfont_open): Avoid unnecessary tests.
582 * composite.c (composition_gstring_put_cache): Use unsigned integer.
584 * composite.h, composite.c (composition_gstring_put_cache):
585 Use EMACS_INT, not int, for length.
587 * composite.h (COMPOSITION_DECODE_REFS): New macro,
588 breaking out part of COMPOSITION_DECODE_RULE.
589 (COMPOSITION_DECODE_RULE): Use it.
590 * composite.c (get_composition_id): Remove unused local vars,
591 by using the new macro.
593 * textprop.c (set_text_properties_1): Change while to do-while,
594 since the condition is always true at first.
596 * intervals.c (graft_intervals_into_buffer): Mark var as used.
597 (interval_deletion_adjustment): Return unsigned value.
600 * process.c (list_processes_1, create_pty, read_process_output):
601 (exec_sentinel): Remove vars that were set but not used.
602 (create_pty): Remove unnecessary "volatile"s.
603 (Fnetwork_interface_info): Avoid possibility of int overflow.
604 (read_process_output): Do adaptive read buffering even if carryover.
605 (read_process_output): Simplify nbytes computation if buffered.
607 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
609 * syntax.c (scan_words): Remove var that was set but not used.
610 (update_syntax_table): Use unsigned instead of int.
612 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
613 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
614 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
616 * print.c (print_error_message): Avoid int overflow.
618 * font.c (font_list_entities): Redo for clarity,
619 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
621 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
622 (font_score): Avoid potential overflow in diff calculation.
624 * fns.c (substring_both): Remove var that is set but not used.
625 (sxhash): Redo loop for clarity and to avoid wraparound warning.
627 * eval.c (funcall_lambda): Rename local to avoid shadowing.
629 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
630 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
631 can always succeed if overflow has undefined behavior.
633 * search.c (boyer_moore, wordify): Remove vars set but not used.
634 (wordify): Omit three unnecessary tests.
636 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
637 All callers changed. This avoids the need for an unused var.
639 * casefiddle.c (casify_region): Remove var that is set but not used.
641 * dired.c (file_name_completion): Remove var that is set but not used.
643 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
645 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
646 (Finsert_file_contents): Remove unnecessary code checking fd.
648 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
649 Check for integer overflow on size calculations.
651 * buffer.c (Fprevious_overlay_change): Remove var that is set
654 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
655 Remove vars that are set but not used.
656 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
657 (timer_check_2): Mark vars as initialized.
659 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
661 * image.c (lookup_image): Remove var that is set but not used.
662 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
664 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
665 that are set but not used.
667 * xfns.c (make_invisible_cursor): Don't return garbage
668 if XCreateBitmapFromData fails (Bug#8410).
670 * xselect.c (x_get_local_selection, x_handle_property_notify):
671 Remove vars that are set but not used.
673 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
674 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
676 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
677 Remove var that is set but not used.
678 (scroll_bar_windows_size): Now size_t, not int.
679 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
682 * xfaces.c (realize_named_face): Remove vars that are set but not used.
683 (map_tty_color) [!defined MSDOS]: Likewise.
685 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
687 * coding.c: Remove vars that are set but not used.
688 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
690 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
691 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
692 (decode_coding_charset): Remove vars that are set but not used.
694 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
695 that is set but not used.
697 * print.c (print_object): Remove var that is set but not used.
699 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
700 The gnulib version avoids calling malloc in the usual case,
701 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
702 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
703 * filelock.c (current_lock_owner): Likewise.
704 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
705 * sysdep.c: Include allocator.h, careadlinkat.h.
706 (emacs_no_realloc_allocator): New static constant.
707 (emacs_readlink): New function.
708 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
709 ../lib/careadlinkat.h.
711 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
713 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
714 first non-nil return value).
716 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
718 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
719 if not defined (Bug#8403).
721 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
723 * xdisp.c (display_count_lines): Remove parameter `start',
724 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
725 (get_char_face_and_encoding): Remove parameter `multibyte_p',
726 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
727 (fill_stretch_glyph_string): Remove parameters `row' and `area',
728 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
729 and thereabouts. All callers changed.
730 (get_per_char_metric): Remove parameter `f', unused since
731 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
733 2011-04-02 Jim Meyering <meyering@redhat.com>
735 do not dereference NULL upon failed strdup
736 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
737 (ns_get_family): Likewise.
739 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
741 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
743 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
745 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
748 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
752 * window.c (Ftemp_output_buffer_show): New fun.
753 (Fsave_window_excursion):
754 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
756 * lread.c (lisp_file_lexically_bound_p): New function.
757 (Fload): Bind Qlexical_binding.
758 (readevalloop): Remove `evalfun' arg.
759 Bind Qinternal_interpreter_environment.
760 (Feval_buffer): Bind Qlexical_binding.
761 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
763 (syms_of_lread): Declare `lexical-binding'.
765 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
767 * keyboard.c (eval_dyn): New fun.
768 (menu_item_eval_property): Use it.
770 * image.c (parse_image_spec): Use Ffunctionp.
772 * fns.c (concat, mapcar1): Accept byte-code-functions.
774 * eval.c (Fsetq): Handle lexical vars.
775 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
776 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
777 (FletX, Flet): Obey lexical binding.
778 (Fcommandp): Handle closures.
779 (Feval): New `lexical' arg.
780 (eval_sub): New function extracted from Feval. Use it almost
781 everywhere where Feval was used. Look up vars in lexical env.
783 (Ffunctionp): Move from subr.el.
784 (Ffuncall): Handle closures.
785 (apply_lambda): Remove `eval_flags'.
786 (funcall_lambda): Handle closures and new byte-code-functions.
787 (Fspecial_variable_p): New function.
788 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
789 but without exporting it to Lisp.
791 * doc.c (Fdocumentation, store_function_docstring):
792 * data.c (Finteractive_form): Handle closures.
794 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
797 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
799 (exec_byte_code): New function extracted from Fbyte_code to handle new
800 calling convention for byte-code-functions. Add new byte-codes.
802 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
804 * alloc.c (Fmake_symbol): Init new `declared_special' field.
806 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
808 * xdisp.c (redisplay_internal): Fix prototype.
810 2011-03-31 Eli Zaretskii <eliz@gnu.org>
812 * xdisp.c (SCROLL_LIMIT): New macro.
813 (try_scrolling): Use it when setting scroll_limit. Limit
814 scrolling to 100 screen lines.
815 (redisplay_window): Even when falling back on "recentering",
816 position point in the window according to scroll-conservatively,
817 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
819 (try_scrolling): When point is above the window, allow searching
820 as far as scroll_max, or one screenful, to compute vertical
821 distance from PT to the scroll margin position. This prevents
822 try_scrolling from unnecessarily failing when
823 scroll-conservatively is set to a value slightly larger than the
824 window height. Clean up the case of PT below the margin at bottom
825 of window: scroll_max can no longer be INT_MAX. When aggressive
826 scrolling is in use, don't let point enter the opposite scroll
827 margin as result of the scroll.
828 (syms_of_xdisp) <scroll-conservatively>: Document the
829 threshold of 100 lines for never-recentering scrolling.
831 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
833 * dispextern.h (move_it_by_lines):
834 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
835 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
836 (message_log_check_duplicate): Remove parameters `prev_bol' and
837 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
838 (redisplay_internal): Remove parameter `preserve_echo_area',
839 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
841 * indent.c (Fvertical_motion):
842 * window.c (window_scroll_pixel_based, Frecenter):
843 Don't pass `need_y_p' to `move_it_by_lines'.
845 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
847 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
848 steal a few bits to be more compact.
849 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
850 Remove unneeded casts.
852 * bytecode.c (Fbyte_code): CAR and CDR can GC.
854 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
856 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
857 binding" message (bug#7967).
859 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
861 Fix more problems found by GCC 4.6.0's static checks.
863 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
864 Remove unused local var.
866 * editfns.c (Fmessage_box): Remove unused local var.
868 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
869 (note_mode_line_or_margin_highlight, note_mouse_highlight):
870 Omit unused local vars.
871 * window.c (shrink_windows): Omit unused local var.
872 * menu.c (digest_single_submenu): Omit unused local var.
873 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
874 Omit unused local var.
876 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
877 Don't assume string length fits in int.
878 (keyremap_step, read_key_sequence): Use size_t for sizes.
879 (read_key_sequence): Don't check last_real_key_start redundantly.
881 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
882 instead of alloca (Bug#8344).
884 * eval.c (Fbacktrace): Don't assume nargs fits in int.
885 (Fbacktrace_frame): Don't assume nframes fits in int.
887 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
889 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
892 * term.c (produce_glyphless_glyph): Remove unnecessary test.
894 * cm.c (calccost): Turn while-do into do-while, for clarity.
896 * keyboard.c (syms_of_keyboard): Use the same style as later
897 in this function when indexing through an array. This also
898 works around GCC bug 48267.
900 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
902 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
904 * chartab.c (sub_char_table_ref_and_range): Redo for slight
905 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
907 * keyboard.c, keyboard.h (num_input_events): Now size_t.
908 This avoids undefined behavior on integer overflow, and is a bit
909 more convenient anyway since it is compared to a size_t variable.
911 Variadic C functions now count arguments with size_t, not int.
912 This avoids an unnecessary limitation on 64-bit machines, which
913 caused (substring ...) to crash on large vectors (Bug#8344).
914 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
915 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
916 All variadic functions and their callers changed accordingly.
917 (struct gcpro.nvars): Now size_t, not int. All uses changed.
918 * data.c (arith_driver, float_arith_driver): Likewise.
919 * editfns.c (general_insert_function): Likewise.
920 * eval.c (struct backtrace.nargs, interactive_p)
921 (internal_condition_case_n, run_hook_with_args, apply_lambda)
922 (funcall_lambda, mark_backtrace): Likewise.
923 * fns.c (concat): Likewise.
924 * frame.c (x_set_frame_parameters): Likewise.
925 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
926 0 if not found, not -1. All callers changed.
928 * alloc.c (garbage_collect): Don't assume stack size fits in int.
929 (stack_copy_size): Now size_t, not int.
930 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
932 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
934 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
935 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
938 * lisp.h (multibyte_char_to_unibyte):
939 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
940 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
941 * character.h (CHAR_TO_BYTE8):
942 * cmds.c (internal_self_insert):
943 * editfns.c (general_insert_function):
944 * keymap.c (push_key_description):
945 * search.c (Freplace_match):
946 * xdisp.c (message_dolog, set_message_1): All callers changed.
948 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
950 * keyboard.c (safe_run_hook_funcall): New function.
951 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
952 don't set the hook to nil, but remove the offending function instead.
953 (Qcommand_hook_internal): Remove, unused.
954 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
955 Vcommand_hook_internal.
957 * eval.c (enum run_hooks_condition): Remove.
958 (funcall_nil, funcall_not): New functions.
959 (run_hook_with_args): Call each function through a `funcall' argument.
960 Remove `cond' argument, now redundant.
961 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
962 (Frun_hook_with_args_until_failure): Adjust accordingly.
963 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
965 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
967 * dispextern.h (string_buffer_position): Remove declaration.
969 * print.c (strout): Remove parameter `multibyte', unused since
970 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
972 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
973 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
976 * w32.c (_wsa_errlist): Use braces for struct initializers.
978 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
979 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
981 (string_buffer_position): Likewise. Also, make static (it's never
982 used outside xdisp.c).
983 (cursor_row_p): Remove parameter `w', unused since
984 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
985 (decode_mode_spec): Remove parameter `precision', introduced during
986 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
989 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
991 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
993 2011-03-27 Anders Lindgren <andlind@gmail.com>
995 * nsterm.m (ns_menu_bar_is_hidden): New variable.
996 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
997 (ns_update_auto_hide_menu_bar): New functions.
998 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
999 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1000 ns_constrain_all_frames.
1001 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1002 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1004 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1006 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1008 2011-03-27 Glenn Morris <rgm@gnu.org>
1010 * syssignal.h: Replace RETSIGTYPE with void.
1011 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1012 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1013 Replace SIGTYPE with void everywhere.
1014 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1015 * s/template.h (SIGTYPE): Remove commented out definition.
1017 2011-03-26 Eli Zaretskii <eliz@gnu.org>
1019 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1020 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1022 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
1024 * w32.c (read_unc_volume): Use parameter `henum', instead of
1025 global variable `wget_enum_handle'.
1027 * keymap.c (describe_vector): Remove parameters `indices' and
1028 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1029 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1031 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1033 * keyboard.c (timer_check): Remove parameter `do_it_now',
1034 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1035 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1036 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1038 * keyboard.c (read_char):
1039 * w32menu.c (w32_menu_display_help):
1040 * xmenu.c (show_help_event, menu_help_callback):
1041 Adjust calls to `show_help_echo'.
1043 * gtkutil.c (xg_maybe_add_timer):
1044 * keyboard.c (readable_events):
1045 * process.c (wait_reading_process_output):
1046 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1048 * insdel.c (adjust_markers_gap_motion):
1049 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1050 (gap_left, gap_right): Don't call it.
1052 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
1054 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1055 incurred during fontification.
1057 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1059 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1060 (DEFVAR_PER_BUFFER): Don't pass it.
1062 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1063 (scrolling_window): Don't pass it.
1065 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1067 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1069 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1071 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1072 of variables specific to SELinux and computation of `encoded_absname'.
1074 * image.c (XPutPixel): Remove unused variable `height'.
1076 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1078 * unexw32.c (get_section_info): Remove unused variable `section'.
1080 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1081 (system_process_attributes): Remove unused variable `sess'.
1082 (sys_read): Remove unused variable `err'.
1084 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1085 (w32_wnd_proc): Remove unused variable `isdead'.
1086 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1087 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1088 (x_create_tip_frame): Remove unused variable `tem'.
1090 * w32inevt.c (w32_console_read_socket):
1091 Remove unused variable `no_events'.
1093 * w32term.c (x_draw_composite_glyph_string_foreground):
1094 Remove unused variable `width'.
1096 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
1098 * w32term.c (x_set_glyph_string_clipping):
1099 Don't pass uninitialized region to CombineRgn.
1101 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
1103 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1104 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1105 (Fx_close_connection): Remove unused variable `i'.
1107 * w32font.c (w32font_draw): Return number of glyphs.
1108 (w32font_open_internal): Remove unused variable `i'.
1109 (w32font_driver): Add missing initializer.
1111 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1112 (fill_in_menu): Remove unused variable `items_added'.
1114 * w32term.c (last_mouse_press_frame): Remove static global variable.
1115 (w32_clip_to_row): Remove unused variable `f'.
1116 (x_delete_terminal): Remove unused variable `i'.
1118 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1119 (NOTHING): Remove unused static global variable.
1120 (uniscribe_check_otf): Remove unused variable `table'.
1121 (uniscribe_font_driver): Add missing initializers.
1123 2011-03-23 Julien Danjou <julien@danjou.info>
1125 * term.c (Fsuspend_tty, Fresume_tty):
1126 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1127 * window.c (temp_output_buffer_show):
1128 * insdel.c (signal_before_change):
1129 * frame.c (Fhandle_switch_frame):
1130 * fileio.c (Fdo_auto_save):
1131 * emacs.c (Fkill_emacs):
1132 * editfns.c (save_excursion_restore):
1133 * cmds.c (internal_self_insert):
1134 * callint.c (Fcall_interactively):
1135 * buffer.c (Fkill_all_local_variables):
1136 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1138 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
1139 unconditionnaly since it does the check itself.
1141 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
1143 Fix more problems found by GCC 4.5.2's static checks.
1145 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1146 the first time through the loop, since we know p0 < p1 then.
1147 This also avoids a gcc -Wstrict-overflow warning.
1149 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1150 leading to a memory leak, possible in functions like
1151 load_charset_map_from_file that can allocate an unbounded number
1152 of objects (Bug#8318).
1154 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1155 that could (at least in theory) be that large.
1157 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1158 This is less likely to overflow, and avoids undefined behavior if
1159 overflow does occur. All callers changed. Use strtoul to scan
1160 for the unsigned long integer.
1161 (pint2hrstr): Simplify and tune code slightly.
1162 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
1164 * scroll.c (do_scrolling): Work around GCC bug 48228.
1165 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1167 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1168 This also avoids a warning with gcc -Wstrict-overflow.
1169 (validate_x_resource_name): Simplify count usage.
1170 This also avoids a warning with gcc -Wstrict-overflow.
1172 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1175 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
1177 * process.c (Fmake_network_process): Use socklen_t, not int,
1178 where POSIX says socklen_t is required in portable programs.
1179 This fixes a porting bug on hosts like 64-bit HP-UX, where
1180 socklen_t is wider than int (Bug#8277).
1181 (Fmake_network_process, server_accept_connection):
1182 (wait_reading_process_output, read_process_output):
1185 * process.c: Rename or move locals to avoid shadowing.
1186 (list_processes_1, Fmake_network_process):
1187 (read_process_output_error_handler, exec_sentinel_error_handler):
1188 Rename or move locals.
1189 (Fmake_network_process): Define label "retry_connect" only if needed.
1190 (Fnetwork_interface_info): Fix pointer signedness.
1191 (process_send_signal): Add cast to avoid pointer signedness problem.
1192 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
1193 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
1195 Make tparam.h and terminfo.c consistent.
1196 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1197 Include tparam.h instead, since it declares them.
1198 * cm.h (PC): Remove extern decl; tparam.h now does this.
1199 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1200 * terminfo.c: Include tparam.h, to check interfaces.
1201 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1202 (tparam): Adjust signature to match interface in tparam.h;
1203 this removes some undefined behavior. Check that outstring and len
1204 are zero, which they always are with Emacs.
1205 * tparam.h (PC, BC, UP): New extern decls.
1207 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
1208 (xftfont_open): Rename locals to avoid shadowing.
1210 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
1211 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1212 (OTF_TAG_SYM): Omit macro if not needed.
1213 (ftfont_list): Remove unused local.
1214 (get_adstyle_property, ftfont_pattern_entity):
1215 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1216 Rename locals to avoid shadowing.
1218 * xfont.c (xfont_list_family): Mark var as initialized.
1220 * xml.c (make_dom): Now static.
1222 * composite.c (composition_compute_stop_pos): Rename local to
1224 (composition_reseat_it): Remove unused locals.
1225 (find_automatic_composition, composition_adjust_point): Likewise.
1226 (composition_update_it): Mark var as initialized.
1227 (find_automatic_composition): Mark vars as initialized,
1228 with a FIXME (Bug#8290).
1230 character.h: Rename locals to avoid shadowing.
1231 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1232 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1233 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1234 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1237 * textprop.c (property_change_between_p): Remove; unused.
1239 * intervals.c (interval_start_pos): Now static.
1241 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1243 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1244 Rename locals to avoid shadowing.
1246 * sound.c (wav_play, au_play, Fplay_sound_internal):
1247 Fix pointer signedness.
1248 (alsa_choose_format): Remove unused local var.
1249 (wav_play): Initialize a variable to 0, to prevent undefined
1250 behavior (Bug#8278).
1252 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1254 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1256 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1257 clobbering (Bug#8298).
1258 * sysdep.c (sys_subshell): Likewise.
1259 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
1261 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1262 This should get cleaned up, so that child_setup has the
1263 same signature on all platforms.
1265 * callproc.c (call_process_cleanup): Now static.
1266 (relocate_fd): Rename locals to avoid shadowing.
1268 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
1270 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1271 not to be necessary, and produces flickering.
1273 2011-03-20 Glenn Morris <rgm@gnu.org>
1275 * config.in: Remove file.
1277 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
1279 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1280 are now in src/globals.h.
1281 (syms_of_minibuf): Remove spurious & from previous change.
1283 2011-03-20 Leo <sdl.web@gmail.com>
1285 * minibuf.c (completing-read-function): New variable.
1286 (completing-read-default): Rename from completing-read.
1287 (completing-read): Call completing-read-function.
1289 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
1291 * xfaces.c (Fx_load_color_file):
1292 Read color file from absolute filename (bug#8250).
1294 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
1296 * makefile.w32-in: Update dependencies.
1298 2011-03-17 Eli Zaretskii <eliz@gnu.org>
1300 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1302 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1304 Fix more problems found by GCC 4.5.2's static checks.
1306 * process.c (make_serial_process_unwind, send_process_trap):
1307 (sigchld_handler): Now static.
1309 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1310 That way, the code declares only the vars that it needs.
1311 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1312 * s/cygwin.h (PTY_ITERATION): Likewise.
1313 * s/darwin.h (PTY_ITERATION): Likewise.
1314 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1316 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1317 * process.c (allocate_pty): Don't declare stb unless it's needed.
1319 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
1320 (CONSTANTLIM): Remove; unused.
1321 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1322 Define only if needed.
1324 * unexelf.c (unexec): Name an expression,
1325 to avoid gcc -Wbad-function-cast warning.
1326 Use a different way to cause a compilation error if anyone uses
1327 n rather than nn, a way that does not involve shadowing.
1328 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
1330 * deps.mk (unexalpha.o): Remove; unused.
1332 New file unexec.h, the (simple) interface for unexec (Bug#8267).
1333 * unexec.h: New file.
1334 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1335 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1337 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1338 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1339 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
1340 Change as necessary to match prototype in unexec.h.
1342 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1344 (back_comment, skip_chars): Mark vars as initialized.
1346 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1347 Rename locals to avoid shadowing.
1349 * lread.c (read1): Rewrite so as not to use empty "else".
1350 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
1352 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1354 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1355 warning when compiling print.c.
1357 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1358 instead of using an uninitialized var.
1359 (font_sort_entities): Mark var as initialized.
1361 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1363 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1364 pointers to constants.
1365 (font_parse_fcname): Remove unused vars.
1366 (font_delete_unmatched): Now static.
1367 (font_get_spec): Remove; unused.
1368 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1369 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1370 Rename or move locals to avoid shadowing.
1372 * fns.c (require_nesting_list, require_unwind): Now static.
1373 (Ffillarray): Rename locals to avoid shadowing.
1375 * floatfns.c (domain_error2): Define only if needed.
1376 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1378 * alloc.c (mark_backtrace): Move decl from here ...
1379 * lisp.h: ... to here, so that it can be checked.
1381 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
1382 (Fdefvar): Rewrite so as not to use empty "else".
1383 (lisp_indirect_variable): Name an expression,
1384 to avoid gcc -Wbad-function-cast warning.
1385 (Fdefvar): Rename locals to avoid shadowing.
1387 * callint.c (quotify_arg, quotify_args): Now static.
1388 (Fcall_interactively): Rename locals to avoid shadowing.
1389 Use const pointer when appropriate.
1391 * lisp.h (get_system_name, get_operating_system_release):
1392 Move decls here, to check interfaces.
1393 * process.c (get_operating_system_release): Move decl to lisp.h.
1394 * xrdb.c (get_system_name): Likewise.
1395 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1396 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1397 some of which prompt warnings from gcc -Wbad-function-cast.
1398 (Fformat_time_string, Fencode_time, Finsert_char):
1399 (Ftranslate_region_internal, Fformat):
1400 Rename or remove local vars to avoid shadowing.
1401 (Ftranslate_region_internal): Mark var as initialized.
1403 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1406 * lisp.h (eassert): Check that the argument compiles, even if
1407 ENABLE_CHECKING is not defined.
1409 * data.c (Findirect_variable): Name an expression, to avoid
1410 gcc -Wbad-function-cast warning.
1411 (default_value, arithcompare, arith_driver, arith_error): Now static.
1412 (store_symval_forwarding): Rename local to avoid shadowing.
1413 (Fmake_variable_buffer_local, Fmake_local_variable):
1414 Mark variables as initialized.
1415 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
1417 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
1418 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1419 Rename locals to avoid shadowing.
1420 (mark_stack): Move local variables into the #ifdef region where
1422 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1423 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1425 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1426 (GC_STRING_CHARS): Remove; not used.
1427 (Fmemory_limit): Cast sbrk's returned value to char *.
1429 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1430 avoids undefined behavior in theory.
1432 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1434 Use functions, not macros, for up- and down-casing (Bug#8254).
1435 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1436 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1437 to use the following functions instead of these macros.
1438 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1439 EMACS_INT, since callers assume the returned value fits in int.
1440 (upcase1): Likewise, for UPCASE_TABLE.
1441 (uppercasep, lowercasep, upcase): New static inline functions.
1442 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
1443 the race-condition problem in the old DOWNCASE.
1445 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1446 Rename locals to avoid shadowing.
1447 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
1448 (regex_compile, re_search_2, re_match_2_internal):
1449 Remove unused local vars.
1450 (FREE_VAR): Rewrite so as not to use empty "else",
1451 which gcc can warn about.
1452 (regex_compile, re_match_2_internal): Mark locals as initialized.
1453 (RETALLOC_IF): Define only if needed.
1454 (WORDCHAR_P): Likewise. This one is never needed, but is used
1455 only in a comment talking about a compiler bug, so put inside
1456 the #if 0 of that comment.
1457 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1458 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1461 * search.c (boyer_moore): Rename locals to avoid shadowing.
1462 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1463 (PREV_CHAR_BOUNDARY): Likewise.
1465 * search.c (simple_search): Remove unused var.
1467 * dired.c (compile_pattern): Move decl from here ...
1468 * lisp.h: ... to here, so that it can be checked.
1469 (struct re_registers): New forward decl.
1471 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1473 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1475 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1476 Rename locals to avoid shadowing.
1477 (Fvertical_motion): Mark locals as initialized.
1479 * casefiddle.c (casify_object, casify_region): Now static.
1480 (casify_region): Mark local as initialized.
1482 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1484 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1485 New macros, so that the caller can use some names other than
1486 gcpro1, gcpro2, etc.
1487 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1489 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1490 argument, for consistency with GCPRO2_VAR, etc: it is now the
1491 prefix of the variable, not the variable itself. All uses
1493 * dired.c (directory_files_internal, file_name_completion):
1494 Rename locals to avoid shadowing.
1496 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1497 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1498 dired.c's scmp function, had undefined behavior.
1499 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1500 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1501 * buffer.h: ... to here, because these macros use current_buffer,
1502 and the new implementation with inline functions needs to have
1503 current_buffer in scope now, rather than later when the macros
1505 (downcase, upcase1): New static inline functions.
1506 (DOWNCASE, UPCASE1): Reimplement using these functions.
1507 This avoids undefined behavior in expressions like
1508 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1509 from race conditions in accessing the global variables
1510 case_temp1 and case_temp2.
1511 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1512 * lisp.h (case_temp1, case_temp2): Remove their decls.
1513 * character.h (ASCII_CHAR_P): Move from here ...
1514 * lisp.h: ... to here, so that the inline functions mentioned
1517 * dired.c (directory_files_internal_unwind): Now static.
1519 * fileio.c (file_name_as_directory, directory_file_name):
1520 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1522 (file_name_as_directory): Use const pointers when appropriate.
1523 (Fexpand_file_name): Likewise. In particular, newdir might
1524 point at constant storage, so make it a const pointer.
1525 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
1526 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1528 (Fset_file_times, Finsert_file_contents, auto_save_error):
1529 Rename locals to avoid shadowing.
1531 * minibuf.c (choose_minibuf_frame_1): Now static.
1532 (Ftry_completion, Fall_completions): Rename or remove locals
1535 * marker.c (bytepos_to_charpos): Remove; unused.
1537 * lisp.h (verify_bytepos, count_markers): New decls,
1538 so that gcc does not warn that these functions aren't declared.
1540 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1541 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
1542 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
1543 (copy_text): Remove unused local var.
1545 * filelock.c (within_one_second): Now static.
1546 (lock_file_1): Rename local to avoid shadowing.
1548 * buffer.c (fix_overlays_before): Mark locals as initialized.
1549 (fix_start_end_in_overlays): Likewise. This function should be
1550 simplified by using pointers-to-pointers, but that's a different
1552 (switch_to_buffer_1): Now static.
1553 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1554 (report_overlay_modification): Rename locals to avoid shadowing.
1556 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
1557 Fix pointer signedness issue.
1558 (sys_subshell): Mark local as volatile if checking for lint,
1559 to suppress a gcc -Wclobbered warning that does not seem to be right.
1560 (MAXPATHLEN): Define only if needed.
1562 * process.c (serial_open, serial_configure): Move decls from here ...
1563 * systty.h: ... to here, so that they can be checked.
1565 * fns.c (get_random, seed_random): Move extern decls from here ...
1566 * lisp.h: ... to here, so that they can be checked.
1568 * sysdep.c (reset_io): Now static.
1569 (wait_for_termination_signal): Remove; unused.
1571 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1572 (copy_keymap_item, append_key, push_text_char_description):
1574 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
1575 (DENSE_TABLE_SIZE): Remove; unused.
1576 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1577 (describe_map_tree):
1578 Rename locals to avoid shadowing.
1580 * keyboard.c: Declare functions static if they are not used elsewhere.
1581 (echo_char, echo_dash, cmd_error, top_level_2):
1582 (poll_for_input, handle_async_input): Now static.
1583 (read_char, kbd_buffer_get_event, make_lispy_position):
1584 (make_lispy_event, make_lispy_movement, apply_modifiers):
1585 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1586 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1587 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
1588 (read_key_sequence, read_char): Mark locals as initialized.
1589 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
1591 * keyboard.h (make_ctrl_char): New decl.
1592 (mark_kboards): Move decl here ...
1593 * alloc.c (mark_kboards): ... from here.
1595 * lisp.h (force_auto_save_soon): New decl.
1597 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
1598 (DEFINE_DUMMY_FUNCTION): New macro.
1599 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1601 (main): Add casts to avoid warnings
1602 if GCC considers string literals to be constants.
1604 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1606 * dbusbind.c: Pointer signedness fixes.
1607 (xd_signature, xd_append_arg, xd_initialize):
1608 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1609 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1610 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1611 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1613 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1614 if GCC considers string literals to be constants.
1615 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
1617 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1619 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1620 (print_preprocess, print_object): New macro to fix last change.
1622 * print.c (print_preprocess): Don't forget font objects.
1624 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
1626 * emacs.c (USAGE3): Doc fixes.
1628 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1630 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1633 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
1635 * lisp.h (VWindow_system, Qfile_name_history):
1636 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1637 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1638 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1640 * w32select.c: Don't #include "keyboard.h".
1641 (run_protected): Add extern declaration for waiting_for_input.
1643 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1644 * w32console.c (detect_input_pending, read_input_pending)
1645 (encode_terminal_code):
1646 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1647 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1648 (w32_system_caret_y, Qfile_name_history):
1649 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1650 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1651 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1652 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1653 * w32proc.c (Qlocal, report_file_error):
1654 * w32term.c (Vwindow_system, updating_frame):
1655 * w32uniscribe.c (initialized, uniscribe_font_driver):
1656 Remove unneeded extern declarations.
1658 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
1660 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
1662 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
1664 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1665 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1666 These macros can no longer be used for assignment.
1668 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1669 Assign struct members directly, instead of using BUF_BEGV etc.
1670 (record_buffer_markers, fetch_buffer_markers): New functions for
1671 recording and fetching special buffer markers.
1672 (set_buffer_internal_1, set_buffer_temp): Use them.
1674 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1676 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1678 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1679 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1681 * xdisp.c (hscroll_window_tree):
1682 (reconsider_clip_changes): Use PT instead of BUF_PT.
1684 2011-03-13 Eli Zaretskii <eliz@gnu.org>
1686 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1687 $(EMACS_ROOT)/lib/intprops.h.
1689 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1691 Fix more problems found by GCC 4.5.2's static checks.
1693 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1694 to unsigned char * to avoid compiler diagnostic.
1695 (xg_free_frame_widgets): Make it clear that a local variable is
1696 needed only if USE_GTK_TOOLTIP.
1697 (gdk_window_get_screen): Make it clear that this macro is needed
1698 only if USE_GTK_TOOLTIP.
1699 (int_gtk_range_get_value): New function, which avoids a diagnostic
1700 from gcc -Wbad-function-cast.
1701 (xg_set_toolkit_scroll_bar_thumb): Use it.
1702 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1703 diagnostic from gcc -Wbad-function-cast.
1704 (get_utf8_string, xg_get_file_with_chooser):
1705 Rename locals to avoid shadowing.
1706 (create_dialog): Move locals to avoid shadowing.
1708 * xgselect.c (xg_select): Remove unused var.
1710 * image.c (four_corners_best): Mark locals as initialized.
1711 (gif_load): Initialize transparent_p to zero (Bug#8238).
1712 Mark another local as initialized.
1713 (my_png_error, my_error_exit): Mark with NO_RETURN.
1715 * image.c (clear_image_cache): Now static.
1716 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
1717 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
1718 (x_edge_detection): Remove unnecessary cast that
1719 gcc -Wbad-function-cast diagnoses.
1720 (gif_load): Fix pointer signedness.
1721 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1722 (jpeg_load, gif_load): Rename locals to avoid shadowing.
1724 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
1726 Improve quality of tests for time stamp overflow.
1727 For example, without this patch (encode-time 0 0 0 1 1
1728 1152921504606846976) returns the obviously-bogus value (-948597
1729 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1730 reports time overflow. See
1731 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
1732 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1733 * editfns.c: Include limits.h and intprops.h.
1734 (TIME_T_MIN, TIME_T_MAX): New macros.
1735 (time_overflow): Move earlier, to before first use.
1736 (hi_time, lo_time): New functions, for an accurate test for
1738 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1739 (Fget_internal_run_time): Don't assume time_t fits in int.
1740 (make_time): Use list2 instead of Fcons twice.
1741 (Fdecode_time): More accurate test for out-of-range times.
1742 (check_tm_member): New function.
1743 (Fencode_time): Use it, to test for out-of-range times.
1744 (lisp_time_argument): Don't rely on undefined left-shift and
1745 right-shift behavior when checking for time stamp overflow.
1747 * editfns.c (time_overflow): New function, refactoring common code.
1748 (Fformat_time_string, Fdecode_time, Fencode_time):
1749 (Fcurrent_time_string): Use it.
1751 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1752 * dired.c (make_time): Move to ...
1753 * editfns.c (make_time): ... here.
1754 * systime.h: Note the move.
1756 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1758 * fringe.c (update_window_fringes): Remove unused variables.
1760 * unexmacosx.c (copy_data_segment): Also copy __got section.
1763 2011-03-12 Eli Zaretskii <eliz@gnu.org>
1765 * termcap.c [MSDOS]: Include "msdos.h".
1766 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1767 Constify `char *' arguments and their references according to
1768 prototypes in tparam.h.
1770 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
1772 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1773 Adapt all references accordingly.
1775 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1777 2011-03-11 Tom Tromey <tromey@redhat.com>
1779 * buffer.c (syms_of_buffer): Remove obsolete comment.
1781 2011-03-11 Eli Zaretskii <eliz@gnu.org>
1783 * termhooks.h (encode_terminal_code): Declare prototype.
1785 * msdos.c (encode_terminal_code): Don't declare prototype.
1787 * term.c (encode_terminal_code): Now external again, used by
1788 w32console.c and msdos.c.
1790 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1791 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
1793 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
1795 Fix some minor problems found by GCC 4.5.2's static checks.
1797 * fringe.c (update_window_fringes): Mark locals as initialized
1799 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
1801 * alloc.c (mark_fringe_data): Move decl from here ...
1802 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1803 to check its interface.
1804 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1806 * fontset.c (free_realized_fontset): Now static.
1807 (Fset_fontset_font): Rename local to avoid shadowing.
1808 (fontset_font): Mark local as initialized.
1809 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
1811 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1813 * xselect.c (x_disown_buffer_selections): Remove; not used.
1814 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
1815 (x_own_selection, Fx_disown_selection_internal): Rename locals
1817 (x_handle_dnd_message): Remove local to avoid shadowing.
1819 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1820 so that the caller can use some name other than gcpro1.
1821 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
1822 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1823 (Fx_backspace_delete_keys_p):
1824 Use them to avoid shadowing, and rename vars to avoid shadowing.
1825 (x_decode_color, x_set_name, x_window): Now static.
1826 (Fx_create_frame): Add braces to silence GCC warning.
1827 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
1828 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1829 Remove unused locals.
1830 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1831 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1832 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1835 * xterm.h (x_mouse_leave): New decl.
1837 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
1838 Remove unused functions.
1839 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
1840 (x_calc_absolute_position): Now static.
1841 (XTread_socket): Don't define label "out" unless it's used.
1842 Don't declare local "event" unless it's used.
1843 (x_iconify_frame, x_free_frame_resources): Don't declare locals
1844 unless they are used.
1845 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
1846 (x_fatal_error_signal): Remove; not used.
1847 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
1848 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
1849 (x_error_catcher, x_connection_closed, x_error_handler):
1850 (x_error_quitter, xembed_send_message, x_iconify_frame):
1851 (my_log_handler): Rename locals to avoid shadowing.
1852 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
1853 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
1855 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
1856 Rename or move locals to avoid shadowing.
1857 (tty_defined_color, merge_face_heights): Now static.
1858 (free_realized_faces_for_fontset): Remove; not used.
1859 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
1860 does not deduce is never used uninitialized.
1861 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
1862 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
1864 * terminal.c (store_terminal_param): Now static.
1866 * xmenu.c (menu_highlight_callback): Now static.
1867 (set_frame_menubar): Remove unused local.
1868 (xmenu_show): Rename parameter to avoid shadowing.
1869 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
1870 since they might point to immutable storage.
1871 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
1872 since it's unused otherwise.
1874 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
1875 Add a FIXME, since the code still doesn't look right. (Bug#8215)
1876 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
1877 avoids a gcc -Wuninitialized diagnostic.
1878 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
1879 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
1880 does not deduce are never used uninitialized.
1882 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
1884 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
1885 * window.c (window_loop, size_window):
1886 (run_window_configuration_change_hook, enlarge_window): Likewise.
1888 * window.c (display_buffer): Now static.
1889 (size_window): Mark variables that gcc -Wuninitialized
1890 does not deduce are never used uninitialized.
1891 * window.h (check_all_windows): New decl, to forestall
1892 gcc -Wmissing-prototypes diagnostic.
1893 * dispextern.h (bidi_dump_cached_states): Likewise.
1895 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
1897 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
1899 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
1900 and to avoid gcc -Wuninitialized warning.
1901 (load_charset_map): Mark variables that gcc -Wuninitialized
1902 does not deduce are never used uninitialized.
1903 (load_charset): Abort instead of using uninitialized var (Bug#8229).
1905 * coding.c (coding_set_source, coding_set_destination):
1906 Use "else { /* comment */ }" rather than "else /* comment */;"
1907 for clarity, and to avoid gcc -Wempty-body warning.
1908 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
1909 a block, when the outer 'i' will do.
1910 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
1911 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
1912 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
1913 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
1914 (Fdecode_sjis_char, Fdefine_coding_system_internal):
1915 Rename locals to avoid shadowing.
1916 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
1917 * coding.c (emacs_mule_char, encode_invocation_designation):
1918 Now static, since they're not used elsewhere.
1919 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
1920 (decode_coding_object, encode_coding_object, detect_coding_system):
1921 (decode_coding_emacs_mule): Mark variables that gcc
1922 -Wuninitialized does not deduce are never used uninitialized.
1923 (detect_coding_iso_2022): Initialize a local variable that might
1924 be used uninitialized. Leave a FIXME because it's not clear that
1925 this initialization is needed. (Bug#8211)
1926 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
1927 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
1928 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
1929 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
1930 Remove unused macros.
1932 * category.c (hash_get_category_set): Remove unused local var.
1933 (copy_category_table): Now static, since it's not used elsewhere.
1934 * character.c (string_count_byte8): Likewise.
1936 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
1937 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
1939 * chartab.c (copy_sub_char_table): Now static, since it's not used
1941 (sub_char_table_ref_and_range, char_table_ref_and_range):
1942 Rename locals to avoid shadowing.
1943 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
1945 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
1946 (BIDI_BOB): Remove unused macro.
1948 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
1949 deduce are never used uninitialized.
1950 * term.c (encode_terminal_code): Likewise.
1952 * term.c (encode_terminal_code): Now static. Remove unused local.
1954 * tparam.h: New file.
1955 * term.c, tparam.h: Include it.
1956 * deps.mk (term.o, tparam.o): Depend on tparam.h.
1957 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
1958 Move these decls to tparam.h, and make them agree with what
1959 is actually in tparam.c. The previous trick of using incompatible
1960 decls in different modules does not conform to the C standard.
1961 All callers of tparam changed to use tparam's actual API.
1962 * tparam.c (tparam1, tparam, tgoto):
1963 Use const pointers where appropriate.
1965 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
1966 * cm.h (struct cm): Likewise.
1967 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
1968 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
1969 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
1970 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
1971 (turn_on_face, init_tty): Likewise.
1972 * termchar.h (struct tty_display_info): Likewise.
1974 * term.c (term_mouse_position): Rename local to avoid shadowing.
1976 * alloc.c (mark_ttys): Move decl from here ...
1977 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
1979 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
1981 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
1983 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
1985 * search.c (compile_pattern_1): Remove argument regp, unused since
1986 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
1987 (compile_pattern): Don't pass it.
1989 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
1991 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
1992 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
1994 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
1996 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
1998 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
1999 gdk_window_get_screen, gdk_window_get_geometry,
2000 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2001 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2002 (xg_get_pixbuf_from_pixmap): New function.
2003 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2004 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2005 Call xg_get_pixbuf_from_pixmap instead of
2006 gdk_pixbuf_get_from_drawable.
2007 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2008 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2009 (xg_check_special_colors): Use GtkStyleContext and its functions
2011 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2012 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2013 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
2014 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2015 Call gtk_widget_get_preferred_size.
2016 (xg_frame_resized): gdk_window_get_geometry only takes 5
2018 (xg_win_to_widget, xg_event_is_for_menubar):
2019 Call gdk_x11_window_lookup_for_display.
2020 (xg_set_widget_bg): New function.
2021 (delete_cb): New function.
2022 (xg_create_frame_widgets): connect delete-event to delete_cb.
2023 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2024 (xg_set_background_color): Call xg_set_widget_bg.
2025 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2026 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2027 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2028 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2030 (update_frame_tool_bar): Call gtk_widget_hide.
2031 (xg_initialize): Use GDK_KEY_g.
2033 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2035 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2037 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2038 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2039 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2041 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
2043 * w32xfns.c (select_palette): Check success of RealizePalette against
2044 GDI_ERROR, not zero.
2046 See ChangeLog.11 for earlier changes.
2052 Copyright (C) 2011 Free Software Foundation, Inc.
2054 This file is part of GNU Emacs.
2056 GNU Emacs is free software: you can redistribute it and/or modify
2057 it under the terms of the GNU General Public License as published by
2058 the Free Software Foundation, either version 3 of the License, or
2059 (at your option) any later version.
2061 GNU Emacs is distributed in the hope that it will be useful,
2062 but WITHOUT ANY WARRANTY; without even the implied warranty of
2063 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2064 GNU General Public License for more details.
2066 You should have received a copy of the GNU General Public License
2067 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.