1 2012-02-11 Eli Zaretskii <eliz@gnu.org>
3 * w16select.c (Fx_selection_exists_p): Sync doc string with
6 2012-02-10 Glenn Morris <rgm@gnu.org>
8 * fns.c (Fsecure_hash): Doc fix.
10 2012-02-09 Kenichi Handa <handa@m17n.org>
12 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
14 2012-02-07 Chong Yidong <cyd@gnu.org>
16 * buffer.c (Fbuffer_local_variables)
17 (buffer_lisp_local_variables): Handle unbound vars correctly;
18 don't let Qunbound leak into Lisp.
20 2012-02-07 Glenn Morris <rgm@gnu.org>
22 * image.c (Fimagemagick_types): Doc fix.
24 * image.c (imagemagick-render-type): Change it from a lisp object
25 to an integer. Move the doc here from the lisp manual.
26 Treat all values not equal to 0 the same.
28 2012-02-06 Chong Yidong <cyd@gnu.org>
30 * doc.c (store_function_docstring): Avoid applying docstring of
31 alias to base function (Bug#2603).
33 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
35 * .gdbinit (pp1, pv1): Remove redundant defines.
38 2012-02-04 Chong Yidong <cyd@gnu.org>
40 * nsterm.m: Declare a global (Bug#10694).
42 2012-02-04 Eli Zaretskii <eliz@gnu.org>
44 * w32.c (get_emacs_configuration_options): Include
45 --enable-checking, if specified, in the return value.
47 2012-02-04 Martin Rudalics <rudalics@gmx.at>
49 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
50 after rounding frame sizes. (Bug#9723)
52 2012-02-04 Eli Zaretskii <eliz@gnu.org>
54 * keyboard.c (adjust_point_for_property): Don't position point
55 before BEGV. (Bug#10696)
57 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
59 Handle overflow when computing char display width (Bug#9496).
60 * character.c (char_width): Return EMACS_INT, not int.
61 (char_width, c_string_width): Check for overflow when
62 computing the width; this is possible now that individual
63 characters can have unbounded width. Problem introduced
64 by merge from Emacs 23 on 2012-01-19.
66 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
68 * dbusbind.c (Fdbus_register_method): Mention the return value
69 :ignore in the docstring.
71 2012-02-02 Glenn Morris <rgm@gnu.org>
73 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
75 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
76 Unconditionally set to t. (Bug#10673)
77 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
78 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
79 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
81 2012-02-02 Kenichi Handa <handa@m17n.org>
83 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
84 0, do not call append_composite_glyph.
86 2012-02-02 Kenichi Handa <handa@m17n.org>
88 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
90 (x_produce_glyphs): If the component of a composition is a null
91 string, set it->pixel_width to 1 to avoid zero-width glyph.
93 2012-02-01 Eli Zaretskii <eliz@gnu.org>
95 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
96 first 2 arguments are identical. This makes inserting large
97 output from a subprocess an order of magnitude faster on
98 MS-Windows, where all sbrk'ed memory is always contiguous.
100 2012-01-31 Glenn Morris <rgm@gnu.org>
102 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
103 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
104 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
106 2012-01-29 Glenn Morris <rgm@gnu.org>
108 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
110 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
112 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
114 2012-01-28 Chong Yidong <cyd@gnu.org>
116 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
118 2012-01-26 Chong Yidong <cyd@gnu.org>
120 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
122 * search.c (Fsearch_forward, Fsearch_backward): Document negative
123 repeat counts (Bug#10507).
125 2012-01-26 Glenn Morris <rgm@gnu.org>
127 * lread.c (syms_of_lread): Doc fix.
129 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
131 * coding.c (encode_designation_at_bol): Change return value to
134 2012-01-25 Chong Yidong <cyd@gnu.org>
136 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
138 2012-01-21 Chong Yidong <cyd@gnu.org>
140 * floatfns.c (Fcopysign): Make the second argument non-optional,
141 since nil is not allowed anyway.
143 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
145 * process.c (read_process_output): Use p instead of XPROCESS (proc).
146 (send_process): Likewise.
148 2012-01-19 Martin Rudalics <rudalics@gmx.at>
150 * window.c (save_window_save, Fcurrent_window_configuration)
151 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
154 2012-01-19 Kenichi Handa <handa@m17n.org>
156 * character.c (char_width): New function.
157 (Fchar_width, c_string_width, lisp_string_width):
158 Use char_width (Bug#9496).
160 2012-01-16 Martin Rudalics <rudalics@gmx.at>
162 * window.c (Vwindow_persistent_parameters): New variable.
163 (Fset_window_configuration, save_window_save): Handle persistent
166 2012-01-14 Eli Zaretskii <eliz@gnu.org>
168 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
169 thrashing the stack of the thread. (Bug#9087)
171 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
173 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
175 2012-01-11 Eli Zaretskii <eliz@gnu.org>
177 * xdisp.c (rows_from_pos_range): Handle the case where the
178 highlight ends on a newline. (Bug#10464)
179 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
180 he end column for display of highlight that ends on a newline
183 2012-01-11 Glenn Morris <rgm@gnu.org>
185 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
186 from load-path also when installation-directory is nil. (Bug#10208)
188 2012-01-10 Glenn Morris <rgm@gnu.org>
190 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
192 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
193 Update template values to be closer to their typical values these days.
195 2012-01-09 Eli Zaretskii <eliz@gnu.org>
197 * xdisp.c (rows_from_pos_range): Accept additional argument
198 DISP_STRING, and accept any glyph in a row whose object is that
199 string as eligible for mouse highlight. Fixes mouse highlight of
200 display strings from overlays. (Bug#10464)
202 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
204 emacs: fix an auto-save permissions race condition (Bug#10400)
205 * fileio.c (auto_saving_dir_umask): New static var.
206 (Fmake_directory_internal): Use it.
207 (do_auto_save_make_dir): Set it, instead of invoking chmod after
208 creating the directory. The old code temporarily assigns
209 too-generous permissions to the directory.
210 (do_auto_save_eh): Clear it.
211 (Fdo_auto_save): Catch all errors, not just file errors, so
212 that the var is always cleared.
214 2012-01-07 Eli Zaretskii <eliz@gnu.org>
216 * search.c (scan_buffer): Pass character positions to
217 know_region_cache, not byte positions. (Bug#6540)
219 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
221 * w32.c (sys_rename): Report EXDEV when rename of a directory
222 fails because the target is on another logical disk. (Bug#10284)
224 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
226 * xterm.c (x_embed_request_focus): New function.
228 * xterm.h: Add prototype.
230 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
232 2012-01-05 Glenn Morris <rgm@gnu.org>
234 * emacs.c (emacs_copyright): Update short copyright year to 2012.
236 2012-01-01 Eli Zaretskii <eliz@gnu.org>
238 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
239 Load gnutls_transport_set_lowat only if GnuTLS version is below
241 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
242 GnuTLS versions below 2.11.1.
244 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
246 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
247 to the doc string advising against its use for altering the way
248 windows are scrolled.
250 2011-12-28 Kenichi Handa <handa@m17n.org>
252 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
253 coding-system ASCII compatible only when it does not produce BOM
254 on encoding (Bug#10383).
256 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
258 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
260 (create_and_show_popup_menu): Always use menu_position_func for
263 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
265 * callint.c (Fcall_interactively): Don't truncate prompt string.
267 2011-12-23 Eli Zaretskii <eliz@gnu.org>
269 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
270 property that ends at ZV, so that the bidi iteration could be
271 resumed from there (after widening). (Bug#10360)
273 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
275 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
277 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
279 * nsterm.m (x_free_frame_resources):
280 Release f->output_data.ns->miniimage.
281 (ns_index_color): Fix indentation. Do not retain
282 color_table->colors[i].
284 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
287 * nsfns.m (x_set_background_color): Assign return value from
288 ns_index_color to face-background instead of NSColor*.
289 (ns_implicitly_set_icon_type): Fix indentation.
290 Change assignment in for loop to comparison.
292 * emacs.c (ns_pool): New variable.
293 (main): Assign ns_pool.
294 (Fkill_emacs): Call ns_release_autorelease_pool.
296 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
297 autorelease fdesc, release fdAttrs and tdict.
298 (ns_get_covering_families): Release charset.
299 (ns_findfonts): Release NSFontDescriptor created with new.
300 (ns_uni_to_glyphs): Fix indentation.
301 (setString): Release attrStr before assigning new value.
303 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
305 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
307 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
308 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
310 2011-12-18 David Reitter <reitter@cmu.edu>
312 * nsterm.m (ns_term_init): Subscribe for notifications
313 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
314 to method trackingNotification in EmacsMenu.
316 * nsmenu.m (trackingMenu): New variable.
317 (trackingNotification): New method (from Aquamacs).
318 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
319 from Aquamacs (Bug#7030).
321 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
323 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
324 (symbol_to_nsstring): Fix indentation.
325 (ns_symbol_to_pb): New function.
326 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
327 (Fns_rotate_cut_buffers_internal): Removed.
328 (Fns_store_selection_internal): Renamed from
329 Fns_store_cut_buffer_internal.
330 (ns_get_foreign_selection, Fx_own_selection_internal)
331 (Fx_disown_selection_internal, Fx_selection_exists_p)
332 (Fns_get_selection_internal, Fns_store_selection_internal):
333 Use ns_symbol_to_pb and check if return value is nil.
334 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
335 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
336 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
337 renamed to Sns_store_selection_internal.
338 (ns_handle_selection_request): Move code to Fx_own_selection_internal
339 and remove this function.
340 (ns_handle_selection_clear): Remove, never used.
341 (Fx_own_selection_internal): Move code from ns_handle_selection_request
344 2011-12-17 Ken Brown <kbrown@cornell.edu>
346 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
347 GID is unknown (Bug#10257).
349 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
351 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
352 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
353 which caused a build failure on GNU/Linux IA-64. This problem was
354 introduced by my 2011-10-07 patch.
356 2011-12-15 Juri Linkov <juri@jurta.org>
358 * image.c (imagemagick_error): New function. (Bug#10112)
359 (imagemagick_load_image): Comment out `MagickSetResolution' call.
360 Use `imagemagick_error' where ImageMagick functions return
362 (Fimagemagick_types): Add `Fnreverse' to return the list in the
365 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
367 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
368 fill background (Bug#8992).
370 2011-12-13 Martin Rudalics <rudalics@gmx.at>
372 * window.c (Vwindow_combination_resize)
373 (Vwindow_combination_limit): Use t instead of non-nil in
375 (Vrecenter_redisplay): Add first sentence of doc-string on
377 (Frecenter): Fix doc-string typo.
379 2011-12-11 Kenichi Handa <handa@m17n.org>
381 * coding.c (Funencodable_char_position): Pay attention to the
382 buffer text relocation (Bug#9389).
384 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
386 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
387 gtk_init (Bug#10100).
389 2011-12-10 Eli Zaretskii <eliz@gnu.org>
391 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
392 IT->string is nil. (Bug#10263)
394 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
396 * nsterm.h (x_free_frame_resources): Declare.
398 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
399 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
401 * nsterm.h (ns_get_defaults_value): Declare.
403 * nsterm.m (ns_default): Call ns_get_defaults_value.
405 2011-12-09 Eli Zaretskii <eliz@gnu.org>
407 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
410 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
412 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
413 that where the value of an _OBJC_* symbol points to is in the .bss
416 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
418 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
419 after the loop to call ccl_driver at least once (Bug#8619).
421 2011-12-08 Kenichi Handa <handa@m17n.org>
423 * ftfont.c (get_adstyle_property): Fix previous change
426 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
428 * w32.c (init_environment): If no_site_lisp, remove site-lisp
429 dirs from the default value of EMACSLOADPATH (bug#10208).
431 2011-12-07 Glenn Morris <rgm@gnu.org>
433 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
434 installation and source directories as well. (Bug#10208)
436 2011-12-06 Chong Yidong <cyd@gnu.org>
438 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
440 2011-12-06 Glenn Morris <rgm@gnu.org>
442 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
443 as an error, not just -1. (Bug#10217)
445 2011-12-05 Chong Yidong <cyd@gnu.org>
447 * keyboard.c (process_special_events): New function.
448 (swallow_events, Finput_pending_p): Use it (Bug#10195).
450 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
452 * coding.c (encode_designation_at_bol): Don't use uninitialized
453 local variable (Bug#9318).
455 2011-12-05 Kenichi Handa <handa@m17n.org>
457 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
458 return Qnil (Bug#8046, Bug#10193).
460 2011-12-05 Kenichi Handa <handa@m17n.org>
462 * coding.c (encode_designation_at_bol): New args charbuf_end and
463 dst. Return the number of produced bytes. Callers changed.
464 (coding_set_source): Return how many bytes coding->source was
466 (coding_set_destination): Return how many bytes
467 coding->destination was relocated.
468 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
469 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
471 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
473 * coding.c (CODING_CHAR_CHARSET_P): New macro.
474 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
477 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
479 The following changes are to fix Bug#9318.
481 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
482 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
483 (encode_coding_iso_2022, encode_coding_sjis)
484 (encode_coding_big5, encode_coding_charset): Use the above macros.
486 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
488 * lisp.h (process_quit_flag): Fix external declaration.
490 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
492 Don't macro-inline non-performance-critical code.
493 * eval.c (process_quit_flag): New function.
494 * lisp.h (QUIT): Use it.
496 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
498 * nsfns.m (get_geometry_from_preferences): New function.
499 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
501 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
503 * emacs.c (Qkill_emacs): Define.
504 (syms_of_emacs): Initialize it.
505 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
506 Qquit_flag to `kill-emacs' instead.
507 (quit_throw_to_read_char): Add parameter `from_signal'.
508 All callers changed. Call Fkill_emacs if requested and safe.
509 * lisp.h (QUIT): Call Fkill_emacs if requested.
511 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
513 * widget.c (update_wm_hints): Return if wmshell is null.
514 (widget_update_wm_size_hints): New function.
516 * widget.h (widget_update_wm_size_hints): Declare.
518 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
519 widget_update_wm_size_hints (Bug#10104).
521 2011-12-03 Eli Zaretskii <eliz@gnu.org>
523 * xdisp.c (handle_invisible_prop): If the invisible text ends just
524 before a newline, prepare the bidi iterator for consuming the
525 newline, and keep the current paragraph direction. (Bug#10183)
526 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
528 2011-12-02 Juri Linkov <juri@jurta.org>
530 * search.c (Fword_search_regexp): New Lisp function created from
531 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
532 (Fword_search_backward, Fword_search_forward)
533 (Fword_search_backward_lax, Fword_search_forward_lax):
534 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
535 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
537 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
539 * fileio.c (Finsert_file_contents): Move after-change-function call
540 to before the "handled:" label, since all "goto handled" appear in
541 cases where the *-change-functions have already been properly called
544 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
546 * keyboard.c (interrupt_signal): Don't call kill-emacs when
547 waiting for input. (Bug#10169)
549 2011-11-30 Eli Zaretskii <eliz@gnu.org>
551 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
552 verifies glyph row's hash code--we have just reallocated the
553 glyphs, so their contents can be complete garbage. (Bug#10164)
555 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
557 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
559 2011-11-30 Eli Zaretskii <eliz@gnu.org>
561 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
562 attributes are tested _before_ calling verify_row_hash, to protect
563 against GCC re-ordering of the tests. (Bug#10164)
565 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
567 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
569 * xterm.c (handle_one_xevent): Only set async_visible and friends
570 if net_wm_state_hidden_seen is non-zero (Bug#10002)
571 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
572 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
574 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
576 Remove GCPRO-related macros that exist only to avoid shadowing locals.
577 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
578 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
579 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
580 All uses changed to use GCPRO1 etc.
581 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
582 Revert to old implementation (i.e., before 2011-03-11).
584 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
586 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
587 of scroll runs so as to avoid assigning disabled bogus rows and
588 unnecessary graphics copy operations.
590 2011-11-27 Eli Zaretskii <eliz@gnu.org>
592 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
593 (snprintf) [_MSC_VER]: Redirect to _snprintf.
594 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
595 (malloc, free, realloc, calloc): Redirect to e_* only when
598 * lisp.h (GCTYPEBITS): Move before first use.
599 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
600 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
601 this macro definition.
603 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
606 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
608 * gtkutil.c (xg_create_frame_widgets):
609 Call gtk_window_set_has_resize_grip (FALSE) if that function is
610 present with Gtk+ 2.0.
612 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
614 * fileio.c (Finsert_file_contents): Undo previous change; see
615 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
617 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
619 Rename locals to avoid shadowing.
620 * fileio.c (Finsert_file_contents):
621 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
622 * process.c (wait_reading_process_output):
623 Rename inner 'proc' to 'p' to avoid shadowing.
624 Indent for consistency with usual Emacs style.
626 2011-11-25 Eli Zaretskii <eliz@gnu.org>
628 * xdisp.c (redisplay_window): If cursor row is not fully visible
629 after recentering, and scroll-conservatively is set to a large
630 number, scroll window by a few more lines to make the cursor fully
631 visible and out of scroll-margin. (Bug#10105)
632 (start_display): Don't move to the next line if the display should
633 start at a newline that is part of a display vector or an overlay
636 2011-11-24 Juri Linkov <juri@jurta.org>
638 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
639 after the `MagickPingImage' call. (Bug#10112)
641 2011-11-23 Chong Yidong <cyd@gnu.org>
643 * window.c (Fcoordinates_in_window_p): Accept only live windows.
645 2011-11-23 Martin Rudalics <rudalics@gmx.at>
647 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
648 making another buffer current. (Bug#10114)
650 2011-11-23 Glenn Morris <rgm@gnu.org>
652 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
654 2011-11-23 Chong Yidong <cyd@gnu.org>
656 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
659 2011-11-22 Eli Zaretskii <eliz@gnu.org>
661 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
662 and header-lines, as they don't have one computed for them.
665 * .gdbinit (prow): Make displayed values more self-explaining.
668 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
670 * process.c (wait_reading_process_output): Fix asynchrounous
671 GnuTLS socket handling on some versions of the GnuTLS library.
672 (wait_reading_process_output): Add comment and URL.
674 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
676 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
678 2011-11-21 Chong Yidong <cyd@gnu.org>
680 * window.c (Fnext_window, Fprevious_window): Doc fix.
682 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
684 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
686 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
688 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
690 2011-11-20 Martin Rudalics <rudalics@gmx.at>
692 * window.c (Fset_window_combination_limit): Rename argument
694 (Vwindow_combination_limit): Remove "status" from doc-string.
696 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
698 * m/ibms390.h: Remove.
699 * m/ibms390x.h: Don't include "ibms390.h".
701 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
703 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
704 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
706 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
708 * casetab.c (Fset_case_table):
709 * charset.c (Fcharset_after): Fix typos.
711 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
713 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
714 Otherwise, valgrind does not work on some platforms.
715 Problem reported by Andreas Schwab in
716 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
717 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
718 is set, removing the need for VIRT_ADDRESS_VARIES.
719 (PURE_P): Use a more-efficient implementation that needs just one
720 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
721 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
722 to 4 (xorl, subq, cmpq, setbe).
723 * alloc.c (pure): Always extern now, since that's the
724 VIRT_ADDR_VARIES behavior.
725 (PURE_POINTER_P): Use a single comparison, not two, for
726 consistency with the new puresize.h.
727 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
728 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
729 Remove VIRT_ADDR_VARIES no longer needed.
731 2011-11-19 Eli Zaretskii <eliz@gnu.org>
733 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
734 (erase_phys_cursor, update_window_cursor, show_mouse_face)
735 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
736 behave as if the cursor position were at the window margin.
738 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
739 and the cursor position is out of bounds, behave as if the cursor
740 position were at the window margin. (Bug#10075)
742 2011-11-18 Chong Yidong <cyd@gnu.org>
744 * window.c (Fwindow_combination_limit): Make first argument
745 non-optional, since it is meaningless for live windows like the
748 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
750 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
752 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
754 * intervals.c: Fix grafting over the whole buffer (bug#10071).
755 (graft_intervals_into_buffer): Simplify.
757 2011-11-18 Eli Zaretskii <eliz@gnu.org>
759 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
760 hash values of the two rows.
761 (copy_row_except_pointers): Preserve the used[] arrays and the
762 hash values of the two rows. (Bug#10035)
763 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
765 * xdisp.c (row_hash): New function, body extracted from
766 compute_line_metrics.
767 (compute_line_metrics): Call row_hash, instead of computing the
770 * dispnew.c (verify_row_hash): Call row_hash for computing the
771 hash code of a row, instead of duplicating code from xdisp.c.
773 * dispextern.h (row_hash): Add prototype.
775 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
777 * frame.c (delete_frame): Don't delete the terminal when the last
778 X frame is closed if emacs is built with GTK toolkit.
780 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
782 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
784 2011-11-17 Martin Rudalics <rudalics@gmx.at>
786 * window.c (Vwindow_splits): Rename to
787 Vwindow_combination_resize. Suggested by Juri Linkov.
788 (Fsplit_window_internal): Use Vwindow_combination_resize instead
791 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
793 * nsfns.m (Fns_font_name):
794 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
796 2011-11-16 Martin Rudalics <rudalics@gmx.at>
798 * window.h (window): Rename slot "nest" to "combination_limit".
799 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
800 (Fset_window_nest): Rename to Fset_window_combination_limit.
801 (Vwindow_nest): Rename to Vwindow_combination_limit.
802 (recombine_windows, make_parent_window, make_window)
803 (Fsplit_window_internal, saved_window)
804 (Fset_window_configuration, save_window_save): Rename all
805 occurrences of window_nest to window_combination_limit.
807 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
809 * image.c (imagemagick_load_image): Fix typo.
811 2011-11-14 Eli Zaretskii <eliz@gnu.org>
813 * xdisp.c (display_line): Move the call to
814 highlight_trailing_whitespace before the call to
815 compute_line_metrics, since the latter needs to see the final
816 faces of all the glyphs to compute ROW's hash value.
817 Fixes assertion violations in row_equal_p. (Bug#10035)
819 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
821 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
822 just return (bug#10044).
824 2011-11-12 Eli Zaretskii <eliz@gnu.org>
826 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
827 with user-defined heap size. Bump the default size of the temacs
828 heap to 27MB, to avoid memory warning when running temacs.
829 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
831 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
832 current_matrix and desired_matrix. (Bug#9990)
833 (verify_row_hash) [XASSERTS]: New function.
834 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
835 that the hash value of glyph rows is correct.
837 2011-11-12 Martin Rudalics <rudalics@gmx.at>
839 * window.h (window): Remove splits slot.
840 * window.c (Fwindow_splits, Fset_window_splits): Remove.
841 (Fdelete_other_windows_internal, make_parent_window)
842 (make_window, Fsplit_window_internal, Fdelete_window_internal)
843 (Fset_window_configuration, save_window_save): Don't deal with
844 split status of windows.
845 (saved_window): Remove splits slot.
846 (Vwindow_splits): Rewrite doc-string.
848 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
850 * xfns.c (unwind_create_frame):
851 * nsfns.m (unwind_create_frame):
852 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
853 Vframe_list (Bug#9999).
855 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
857 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
859 2011-11-11 Kenichi Handa <handa@m17n.org>
861 * callproc.c (Fcall_process): Set the member dst_multibyte of
864 2011-11-11 Johan Bockgård <bojohan@gnu.org>
866 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
867 avoid a crash (bug#9496).
869 2011-11-09 Chong Yidong <cyd@gnu.org>
871 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
872 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
874 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
876 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
878 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
880 Avoid some portability problems by eschewing 'extern inline' functions.
881 The trivial performance wins aren't worth the portability hassles; see
882 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
884 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
885 (window_box_width, window_box_left, window_box_left_offset)
886 (window_box_right, window_box_right_offset): Undo previous change,
887 by removing the "extern"s.
888 * intervals.c (adjust_intervals_for_insertion)
889 (adjust_intervals_for_deletion): Undo previous change,
890 making these static again.
891 (offset_intervals, temp_set_point_both, temp_set_point)
892 (copy_intervals_to_string): No longer inline.
893 * xdisp.c (window_text_bottom_y, window_box_width)
894 (window_box_height, window_box_left_offset)
895 (window_box_right_offset, window_box_left, window_box_right)
896 (window_box): No longer inline.
898 2011-11-08 Chong Yidong <cyd@gnu.org>
900 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
901 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
902 Signal an error if not a live window.
903 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
904 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
906 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
908 * lisp.h (syms_of_abbrev): Remove declaration.
909 Reported by CHENG Gao <chenggao@royau.me>.
911 2011-11-07 Eli Zaretskii <eliz@gnu.org>
913 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
914 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
915 of temacs in GUI mode.
917 2011-11-07 Martin Rudalics <rudalics@gmx.at>
919 * window.h: Declare delete_all_child_windows instead of
920 delete_all_subwindows.
921 * window.c (Fwindow_nest, Fset_window_nest)
922 (Fset_window_new_total, Fset_window_new_normal)
923 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
924 (delete_all_subwindows): Rename to delete_all_child_windows.
925 (Fdelete_other_windows_internal, Fset_window_configuration):
926 Call delete_all_child_windows instead of delete_all_subwindows.
927 * frame.c (delete_frame): Call delete_all_child_windows instead
928 of delete_all_subwindows.
930 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
932 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
933 This is also needed for porting to any host where GC_MARK_STACK is
934 not GC_MAKE_GCPROS_NOOPS.
935 (which_symbols): Use it.
937 2011-11-07 Kenichi Handa <handa@m17n.org>
939 * coding.c (coding_set_destination): Check coding->src_pos only
940 when coding->src_object is a buffer (bug#9910).
942 * process.c (send_process): Set the member src_multibyte of coding
943 to 0 (bug#9911) when sending a unibyte text.
945 * callproc.c (Fcall_process): Set the member src_multibyte of
946 process_coding to 0 (bug#9912).
948 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
950 * xmenu.c (cleanup_widget_value_tree): New function.
951 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
952 calling free_menubar_widget_value_tree directly (Bug#9830).
954 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
956 Fix some portability problems with 'inline'.
957 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
958 (window_box_width, window_box_left, window_box_left_offset)
959 (window_box_right, window_box_right_offset): Declare extern.
960 Otherwise, these inline functions do not conform to C99 and
961 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
962 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
963 * intervals.c (adjust_intervals_for_insertion)
964 (adjust_intervals_for_deletion): Now extern, because otherwise the
965 extern inline functions 'offset_intervals' couldn't refer to it.
966 (static_offset_intervals): Remove.
967 (offset_intervals): Rewrite using the old contents of
968 static_offset_intervals. The old version didn't conform to C99
969 because an extern inline function contained a reference to an
970 identifier with static linkage.
972 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
974 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
977 2011-11-06 Eli Zaretskii <eliz@gnu.org>
979 * xdisp.c (init_iterator, reseat_to_string): Don't set the
980 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
981 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
982 return Qleft_to_right.
984 2011-11-06 Chong Yidong <cyd@gnu.org>
986 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
987 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
988 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
989 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
990 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
991 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
992 (Fwindow_vscroll): Doc fix.
993 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
994 argument, since it makes no sense to pass a live window and for
995 consistency with window-child.
997 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
999 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1002 2011-11-05 Jason Rumney <jasonr@gnu.org>
1004 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1005 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1007 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1008 bitwise arithmetic preventing use of unicode-sip and non-truetype
1011 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1013 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1016 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1017 initialization code to keep similarity to xfns.c after changes
1020 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1022 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1023 (unwind_create_frame): New function (Bug#9943).
1024 (Fx_create_frame): Restructure code to be more similar to the one in
1025 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1026 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1027 Move terminal->reference_count++ just before making the frame official
1030 * nsterm.m (x_free_frame_resources): New function.
1031 (x_destroy_window): Move code to x_free_frame_resources.
1033 * xfns.c (unwind_create_frame): Fix comment.
1034 (Fx_create_frame, x_create_tip_frame):
1035 Move terminal->reference_count++ just before making the frame
1036 official. Move initialization of image_cache_refcount and
1037 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1039 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1041 Support MSVC build with newer versions of Visual Studio.
1042 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1043 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1046 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1047 which are not supported by MSVC.
1048 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1049 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1051 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1053 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1055 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1057 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1059 Support MSVC build with newer versions of Visual Studio.
1060 * w32.c: Don't include w32api.h for MSVC.
1061 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1063 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1064 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1065 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1066 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1068 (alloca) [_MSC_VER]: Define to _alloca.
1070 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1072 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1074 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1076 * xdisp.c (note_mouse_highlight): If either of
1077 previous/next-single-property-change returns nil, treat that as
1078 the beginning or the end of the buffer. (Bug#9955)
1080 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1082 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1083 label is not null (Bug#9951).
1084 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1087 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1089 * window.c (Fwindow_body_size): Mention in the doc string that the
1090 return value is in frame's canonical units. (Bug#9949)
1092 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1094 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1096 * w32fns.c (unwind_create_frame): If needed, free the glyph
1097 matrices of the partially constructed frame. (Bug#9943)
1098 * xfns.c (unwind_create_frame): Likewise.
1100 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1102 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1103 Don't stop backward scan on the continuation glyph, even though
1104 its CHARPOS is positive.
1105 (mouse_face_from_buffer_pos, note_mouse_highlight):
1106 Rename cover_string to disp_string.
1108 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1110 * window.c (temp_output_buffer_show): Don't use
1111 Vtemp_buffer_show_specifiers.
1112 (Vtemp_buffer_show_specifiers): Remove unused variable.
1114 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1116 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1117 past the beginning of the current glyph matrix.
1119 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1121 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1122 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1123 HAVE_GTK3 (Bug#9869).
1125 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1126 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1128 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1130 * xterm.c: Declare x_handle_net_wm_state to return int.
1131 (handle_one_xevent): Check if we are iconified but don't have
1132 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1133 (get_current_wm_state): Return non-zero if not hidden,
1134 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1135 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1136 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1137 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1139 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1141 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1142 so that this new function doesn't get optimized away by a
1143 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1145 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1147 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1149 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1151 Fix the `xbytecode' command.
1152 * .gdbinit (xprintbytestr): New command.
1153 (xwhichsymbols): Rename from `which'; all callers changed.
1154 (xbytecode): Print the byte-code string as well.
1156 2011-10-29 Kim Storm <storm@cua.dk>
1158 * alloc.c (which_symbols): New function.
1160 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1162 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1165 2011-10-29 Glenn Morris <rgm@gnu.org>
1167 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1168 Not clear what it was for, and it causes various bugs. (Bug#9839)
1170 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1172 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1173 possible random value that matches one of those tested as
1174 condition to clear the mouse face.
1176 2011-10-28 Chong Yidong <cyd@gnu.org>
1178 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1180 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1182 * window.c (make_window): Initialize phys_cursor_on_p.
1184 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1186 * lisp.h (struct Lisp_Symbol): Update comments.
1188 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1190 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1192 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1194 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1195 <oslsachem@gmail.com> for helping to debug this.
1197 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1198 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1199 (g_b_init_get_glyph_outline_w): New static variables.
1200 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1201 (GetGlyphOutlineW_Proc): New typedefs.
1202 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1203 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1205 (w32font_open_internal, compute_metrics):
1206 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1207 instead of calling the "wide" APIs directly.
1209 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1211 * w32.h (syms_of_w32font): Add prototype.
1213 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1215 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1216 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1217 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1218 (Fmove_to_window_line): Doc fix.
1220 2011-10-27 Chong Yidong <cyd@gnu.org>
1222 * process.c (make_process): Set gnutls_state to NULL.
1224 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1225 non-NULL, regardless of GNUTLS_INITSTAGE.
1226 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1227 an error. Set process slots as soon as we allocate them.
1229 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1231 2011-10-27 Chong Yidong <cyd@gnu.org>
1233 * gnutls.c (emacs_gnutls_deinit): New function.
1234 Deallocate credentials structures as well as calling gnutls_deinit.
1235 (Fgnutls_deinit, Fgnutls_boot): Use it.
1237 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1238 (deactivate_process): Call emacs_gnutls_deinit.
1240 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1242 * image.c (x_create_x_image_and_pixmap):
1243 * w32.c (sys_rename, w32_delayed_load):
1244 * w32font.c (fill_in_logfont):
1245 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1247 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1249 * w32fns.c (w32_default_color_map): New function,
1250 extracted from Fw32_default_color_map.
1251 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1253 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1255 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1257 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1259 * keyboard.c (test_undefined): New function (bug#9751).
1260 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1262 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1264 * sysdep.c (init_sys_modes): Fix the check for the controlling
1265 terminal (Bug#6649).
1267 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1269 * dispextern.h (struct bidi_it): New member next_en_type.
1271 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1272 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1273 current character, check also for next_en_type being WEAK_EN.
1274 (bidi_resolve_weak): Don't enter the expensive loop if the current
1275 position is before next_en_pos. Record the bidi type of the first
1276 non-ET, non-BN character we find, in addition to its position.
1277 (bidi_level_of_next_char): Invalidate next_en_type when
1278 next_en_pos is over-stepped.
1280 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1282 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1283 * editfns.c: Rewrite current-time-zone so that it invokes
1284 the equivalent of (format-time-string "%Z") to get the time zone name.
1285 This fixes a bug when the time zone name contains characters that
1286 need converting from the system time locale to Emacs internal format.
1287 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1288 that patch fixed format-time-string to do the conversion, but
1289 I forgot to fix current-time-zone.
1290 (format_time_string): New function, containing most of
1291 what Fformat_time_string used to contain.
1292 (Fformat_time_string): Rewrite in terms of format_time_string.
1293 This doesn't change this function's behavior.
1294 (current-time-zone): Rewrite to use format_time_string.
1295 This fixes the bug reported by Michael Schierl in
1296 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1297 Jason Rumney's 2007-06-07 change worked around this bug, but
1299 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1301 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1303 * xdisp.c (start_display): If the character at POS is displayed
1304 via a display vector, reset IT->current.dpvec_index to zero.
1305 (try_window_reusing_current_matrix): If a line ends in a display
1306 vector or the next line starts in a display vector, continue
1307 redrawing the window even though the character position of
1308 start_row was reached.
1311 2011-10-18 Chong Yidong <cyd@gnu.org>
1313 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1314 with nobreak-char-display too.
1316 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1318 Fix part 3 of bug#9771.
1319 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1320 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1321 non-neutral characters if the current character is a paragraph
1322 separator (a.k.a. Newline). This avoids running the same
1323 expensive loop twice, once when we consume the preceding newline
1324 and the other time when the line actually needs to be displayed.
1325 Avoid the loop when we see neutrals on the base embedding level
1326 following a character whose directionality is the same as the
1327 paragraph's. This avoids running the expensive loop when a line
1328 ends in a long sequence of neutrals, like control characters.
1329 Add assertion against STRONG_AL type. Slightly rearrange code
1330 that determines the type of a neutral given the first non-neutral
1332 (bidi_level_of_next_char): Set next_en_pos to zero when
1333 invalidating its info.
1335 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1337 * xdisp.c (push_display_prop): Determine whether to record string
1338 or buffer position by IT->string, not by IT->method. Allow
1339 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1340 (move_it_vertically_backward): Don't look for character position
1341 immediately after the newline when in a continuation line.
1344 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1346 * window.c (coordinates_in_window): Rewrite and delabelize
1347 vertical border check. (Bug#5357) (Bug#9618)
1349 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1351 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1352 errors in XSetWindowBorder (bug#9310).
1354 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1356 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1357 avoid crash when xmalloc overrun checking is enabled.
1359 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1361 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1362 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1363 cursor motion with <left> and <right> arrow keys.
1365 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1366 some callers set that themselves.
1368 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1370 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1371 display string and the previous row comes from the same string and
1372 is empty. (Bug#9739) (Bug#9738)
1374 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1376 * doc.c (get_doc_string): Encode file name (bug#9735).
1378 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1380 * bidi.c (bidi_level_of_next_char):
1381 * xdisp.c (get_visually_first_element): Remove old incorrect
1382 comments regarding the Unicode Line Separator character.
1384 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1386 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1388 * alloc.c (Fgc_status): Do not access beyond zombies array
1389 boundary if nzombies > MAX_ZOMBIES.
1390 * alloc.c (dump_zombies): Add missing format specifier.
1392 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1394 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1395 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1397 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1398 Some packages use them to denote characters with modifiers.
1400 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1402 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1403 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1404 matching a pp-number. Rename parameter var to var1.
1406 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1408 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1410 2011-10-08 Glenn Morris <rgm@gnu.org>
1412 * callint.c (Fcall_interactively): Give a more explicit error for the
1413 'c' case with a non-character input. (Bug#8479)
1415 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1417 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1419 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1420 lines that are hscrolled on the left.
1422 * dispnew.c (buffer_posn_from_coords): Account for a possible
1423 presence of header-line. (Bug#4426)
1425 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1427 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1428 Don't advertise functionality which we discourage or doesn't work.
1430 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1432 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1433 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1434 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1435 this makes Emacs dump core during garbage collection on rare
1436 occasions. sizeof is obviously inferior to offsetof here, so
1437 stick with offsetof.
1438 (GC_POINTER_ALIGNMENT): New macro.
1439 (mark_memory): Omit 3rd (offset) arg; caller changed.
1440 Don't assume EMACS_INT alignment is the same as pointer alignment.
1442 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1444 * keyboard.c (read_key_sequence_remapped): New var.
1445 (read_key_sequence): Compute remapping in the right buffer.
1446 (command_loop_1): Use read_key_sequence's remapping directly.
1448 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1450 * dired.c (file_name_completion): Don't expand file name.
1451 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1452 before checking file name handler.
1454 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1455 they've been requested explicitly (bug#9591).
1457 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1459 * keymap.c (Fsingle_key_description): Use make_specified_string
1460 instead of build_string to build string from push_key_description.
1463 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1465 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1466 This fixes a Y2038 bug on 64-bit hosts.
1467 * buffer.c (reset_buffer):
1468 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1469 (Fclear_buffer_auto_save_failure):
1470 Use 0, not -1, to represent an unset failure time, since time_t
1471 might not be signed.
1473 Remove dependency on glibc malloc internals.
1474 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1475 Move back here from lisp.h, but with their new implementations.
1476 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1477 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1478 * charset.c (charset_table_init): New static var.
1479 (syms_of_charset): Use it instead of xmalloc. This removes a
1480 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1481 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1482 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1483 Move back to alloc.c.
1484 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1485 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1487 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1489 * nsterm.m (windowDidResize): Call x_set_window_size only when
1490 ns_in_resize is true. Otherwise set pixelwidth/height and
1491 call change_frame_size (Bug#9628).
1493 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1495 Port --enable-checking=all to Fedora 14 x86-64.
1496 * charset.c (syms_of_charset): Also account for glibc malloc's
1497 internal overhead when calculating the initial malloc maximum.
1499 Port --enable-checking=all to Fedora 14 x86.
1500 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1502 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1503 (overrun_check_realloc, overrun_check_free):
1504 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1505 That way, xmalloc returns a properly-aligned pointer even if
1506 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1507 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1508 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1509 into account when calculating the initial malloc maximum.
1510 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1511 Move here from alloc.c, so that charset.c can use it too.
1512 Properly align; the old code wasn't right for common 32-bit hosts
1513 when configured with --enable-checking=all.
1514 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1515 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1517 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1519 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1522 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1524 * xdisp.c (compute_display_string_end): If there's no display
1525 string at CHARPOS, return -1.
1527 * bidi.c (bidi_fetch_char): When compute_display_string_end
1528 returns a negative value, treat the character as a normal
1529 character not covered by a display string. (Bug#9624)
1531 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1533 * lread.c (Fread_from_string): Fix typo in docstring.
1535 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1537 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1538 newline, reseat the iterator instead of bidi-iterating there one
1539 character at a time. (Bug#9610)
1540 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1541 TO_CHARPOS if the bidi iterator is at base embedding level.
1543 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1545 * lread.c (readevalloop): Use correct code for NBSP.
1546 (read1): Likewise. (Bug#9608)
1548 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1550 * dbusbind.c (Fdbus_register_signal): When service is not
1551 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1553 2011-09-25 Glenn Morris <rgm@gnu.org>
1555 * buffer.c (truncate-lines): Doc fix.
1557 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1559 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1560 (Fset_window_next_buffers): Doc fix.
1562 2011-09-24 Glenn Morris <rgm@gnu.org>
1564 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1566 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1568 Fix minor problems found by static checking.
1569 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1570 * indent.c (Fvertical_motion): Fix == vs = typo.
1572 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1574 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1575 Default value is now t. Doc fix.
1577 * indent.c (Fvertical_motion): Compute and apply the overshoot
1578 logic when moving up, not only when moving down. Fix the
1579 confusing name and values of the it_overshoot_expected variable;
1580 logic changes accordingly. (Bug#9254) (Bug#9549)
1582 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1583 CHARPOS is covered by a display string which includes newlines.
1584 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1585 is covered by a display string with embedded newlines.
1587 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1589 * dbusbind.c (Fdbus_register_signal): Add match rule to
1590 Vdbus_registered_objects_table. (Bug#9581)
1591 (Fdbus_register_method, Vdbus_registered_objects_table):
1594 2011-09-24 Jim Meyering <meyering@redhat.com>
1596 do not ignore write error for any output size
1597 The previous change was incomplete.
1598 While it makes emacs --batch detect the vast majority of stdout
1599 write failures, errors were still ignored whenever the output size is
1600 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1601 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1602 && echo FAIL: ignored write error
1603 FAIL: ignored write error
1604 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1605 && echo FAIL: ignored write error
1606 FAIL: ignored write error
1607 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1609 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1611 * emacs.c (Fkill_emacs): In noninteractive mode exit
1612 non-successfully if a write error occurred on stdout. (Bug#9574)
1614 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1616 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1619 * dispextern.h (struct it): Update the comment documenting what
1622 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1624 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1625 a display string, extend search for cursor position to end of row.
1626 (find_row_edges): If the row ends in a newline from a display
1627 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1628 Handle the case of a display string with multiple newlines.
1629 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1630 non-empty line. Fixes confusing cursor motion with arrow keys at
1631 the beginning of a line that starts with whitespace.
1633 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1635 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1638 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1640 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1643 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1645 * xdisp.c (display_line): Record maximum and minimum buffer
1646 positions even if no glyphs were produced (e.g., by a zero-width
1647 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1648 buffer positions that will be removed from the glyph row because
1650 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1651 column is beyond frame width: don't subtract 1 "pixel" when
1652 computing width of the stretch.
1653 (reseat_at_next_visible_line_start): Undo the change made on
1654 2011-09-17 that saved paragraph information and restored it after
1655 the call to `reseat'. (Bug#9545)
1657 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1659 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1660 and turn window cursor on if cleared (Bug#9415).
1662 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1664 * search.c (boyer_moore): Take unibyte characters from pattern
1665 literally. (Bug#9458)
1667 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1669 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1671 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1673 Fix minor problem found by static checking.
1674 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1675 initialized, to pacify gcc -Wuninitialized.
1677 * fileio.c: Report proper errno when syscall falls.
1678 (Finsert_file_contents): Save and restore errno,
1679 so that report_file_error outputs the correct diagnostic.
1680 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1682 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1684 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1686 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1688 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1689 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1691 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1693 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1694 about the current paragraph and restore it after the call to reseat.
1696 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1697 (bidi_find_paragraph_start): Search back for paragraph beginning
1698 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1699 (bidi_move_to_visually_next): Only trigger paragraph-related
1700 computations when the last character is a newline or at EOB, not
1701 just any NEUTRAL_B. (Bug#9470)
1703 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1704 truncated lines if point is covered by a display string. (Bug#9524)
1706 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1708 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1709 (cons_to_x_long): New function.
1710 (lisp_data_to_selection_data): Use it. Correct the test for
1711 short-versus-long data; it was negated. Break out of vector
1712 loop, for efficiency, when a long datum is discovered.
1714 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1716 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1718 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1720 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1721 GCC PR/17406) by declaring this function with external scope.
1723 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1725 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1726 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1728 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1730 * editfns.c (Fformat): Correctly handle text properties on "%%".
1732 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1734 * xterm.c (x_draw_composite_glyph_string_foreground):
1735 * w32term.c (x_draw_composite_glyph_string_foreground):
1736 * term.c (encode_terminal_code):
1737 * composite.c (composition_update_it, get_composition_id):
1738 * xdisp.c (get_next_display_element)
1739 (fill_composite_glyph_string): Add comments about special meaning
1740 of TAB characters in a composition.
1742 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1744 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1745 This occurs when processing a multibyte format.
1746 Problem reported by Wolfgang Jenker.
1748 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1750 * xdisp.c (try_cursor_movement): Only check for exact match if
1751 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1753 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1755 Remove unused external symbols.
1756 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1757 * xdisp.c (calc_pixel_width_or_height): Now static.
1758 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1759 * indent.c (check_display_width):
1760 * w32term.c: Fix comment to match code.
1761 * xterm.c, xterm.h (x_catching_errors): Remove.
1763 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1765 * xselect.c: Use signed conversions more consistently (Bug#9498).
1766 (selection_data_to_lisp_data): Assume incoming selection data are
1767 signed integers, not unsigned. This is to be consistent with
1768 outgoing selection data, which was modified to use signed integers
1769 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1770 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1771 expects long, not unsigned long.
1773 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1775 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1776 computation of loop end. Reported by Johan Bockgård
1779 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1781 * frame.c (Fother_visible_frames_p): Function deleted.
1783 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1785 * indent.c (compute_motion): Process display vector front to back
1786 rather than the other way around. (Bug#2496)
1788 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1790 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1792 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1794 * minibuf.c (Fread_from_minibuffer): Doc fix.
1796 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1798 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1799 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1801 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1803 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1804 value for non-existent files.
1806 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1808 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1809 set its "size" to -1. This will set the modtime_size field of
1810 the corresponding buffer to -1, which is what
1811 verify-visited-file-modtime expects for files that do not exist.
1814 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1816 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1818 * lisp.h: ... from here. push_key_description is no longer
1819 defined in keyboard.c, so its declaration should not be in
1820 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1821 logically belongs with push_key_description.
1823 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1825 * buffer.h: Include <sys/types.h> instead of <time.h>.
1826 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1827 Problem reported by Herbert J. Skuhra.
1829 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1831 * xml.c (parse_region): Make the parsing work for
1832 non-comment-starting XML files again (bug#9144).
1834 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1836 * image.c (gif_load): Fix calculation of bottom and right corner.
1839 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1841 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1842 redisplay in small windows.
1844 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1846 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1848 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1850 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1851 Operate on live windows only.
1853 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1855 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1857 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1859 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1860 only under bidi iteration.
1862 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1864 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1866 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1868 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1869 Without this fix, the command to link temacs failed due to an
1870 undefined symbol __builtin_isnan. This is because
1871 /usr/include/iso/math_c99.h #defines isnan(x) to
1872 __builtin_isnan(x), but the bundled gcc, which identifies itself
1873 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1875 * floatfns.c (isnan): #undef, and then #define to a clone of
1877 (Fisnan): Always define, since it's always available now.
1878 (syms_of_floatfns): Always define isnan at the Lisp level.
1880 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1882 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1884 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1886 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1887 The previous code assumed that file offsets (off_t values) fit in
1888 EMACS_INT variables, which is not true on typical 32-bit hosts.
1889 The code messed up by falsely reporting buffer overflow in cases
1890 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1891 when "big" contains more than 2**29 bytes, even though this
1892 inserts just one byte and does not overflow the buffer.
1893 (Finsert_file_contents): Store file offsets as off_t
1894 values, not as EMACS_INT values. Check for overflow when
1895 converting between EMACS_INT and off_t. When checking for
1896 buffer overflow or for overlap, take the offsets into account.
1897 Don't use EMACS_INT for small values where int suffices.
1898 When checking for overlap, fix a typo: ZV was used where
1899 ZV_BYTE was intended.
1900 (Fwrite_region): Don't assume off_t fits into 'long'.
1901 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1903 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1905 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1907 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1909 sprintf-related integer and memory overflow issues (Bug#9412).
1911 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1912 (esprintf, exprintf, evxprintf): New functions.
1913 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1914 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1915 (modify_event_symbol): Do not assume that the length of
1916 name_alist_or_stem is safe to alloca and fits in int.
1917 (Fexecute_extended_command): Likewise for function name and binding.
1918 (Frecursion_depth): Wrap around reliably on integer overflow.
1919 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1920 since some callers pass EMACS_INT values.
1921 (Fsingle_key_description): Don't crash if symbol name contains more
1922 than MAX_ALLOCA bytes.
1923 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1924 (get_minibuffer): Arg is now EMACS_INT, not int.
1925 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1926 (esprintf, exprintf, evxprintf): New decls.
1927 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1929 * dbusbind.c (signature_cat): New function.
1930 (xd_signature, Fdbus_register_signal):
1931 Do not overrun buffer; instead, report string overflow.
1933 * dispnew.c (add_window_display_history): Don't overrun buffer.
1934 Truncate instead; this is OK since it's just a log.
1936 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1937 even if the time zone offset is outlandishly large.
1938 Don't mishandle offset == INT_MIN.
1940 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1941 when creating daemon; the previous buffer-overflow check was incorrect.
1943 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1944 which has the guts of the old verror function.
1946 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1947 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1949 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1950 (font_unparse_xlfd): Don't blindly alloca long strings.
1951 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1952 fits in int, when using sprintf. Use single snprintf to count
1953 length of string rather than counting it via multiple sprintfs;
1954 that's simpler and more reliable.
1955 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1956 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1957 sprintf, in case result does not fit in int.
1959 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1960 (fontset_from_font): Print it.
1962 * frame.c (tty_frame_count): Now printmax_t, not int.
1963 (make_terminal_frame, set_term_frame_name): Print it.
1964 (x_report_frame_params): In X, window IDs are unsigned long,
1965 not signed long, so print them as unsigned.
1966 (validate_x_resource_name): Check for implausibly long names,
1967 and don't assume name length fits in 'int'.
1968 (x_get_resource_string): Don't blindly alloca invocation name;
1969 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1972 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1973 (xg_check_special_colors, xg_set_geometry):
1974 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1976 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1977 Use esprintf, not sprintf, in case result does not fit in int.
1979 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1980 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1981 it as a large positive number.
1982 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1983 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1985 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1986 in case result does not fit in int.
1988 * print.c (float_to_string): Detect width overflow more reliably.
1989 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1990 buffer overrun. Don't assume list length fits in 'int'. Treat
1991 print length of 0 as 0, not as infinity; to be consistent with other
1992 uses of print length in this function. Don't overflow print length
1993 index. Don't assume hash table size fits in 'long', or that
1994 vectorlike size fits in 'unsigned long'.
1996 * process.c (make_process): Use printmax_t, not int, to format
1997 process-name gensyms.
1999 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2001 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2002 to avoid potential buffer overrun.
2004 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2005 if X resource line is longer than 512 bytes.
2007 * xfns.c (x_window): Make sprintf buffer a bit bigger
2008 to avoid potential buffer overrun.
2010 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2012 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2014 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2016 Integer overflow fixes for scrolling, etc.
2017 Without these, Emacs silently mishandles large integers sometimes.
2018 For example, "C-u 4294967297 M-x recenter" was treated as if
2019 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2021 * xdisp.c (try_window_id): Check Emacs fixnum range before
2022 converting to 'int'.
2024 * window.c (window_scroll_line_based, Frecenter):
2025 Check that an Emacs fixnum is in range before assigning it to 'int'.
2026 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2027 values converted from Emacs fixnums.
2028 (Frecenter): Don't wrap around a line count if it is out of 'int'
2029 range; instead, treat it as an extreme value.
2030 (Fset_window_configuration, compare_window_configurations):
2031 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2033 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2034 that can exceed INT_MAX. Check that EMACS_INT value is in range
2035 before assigning it to the (possibly-narrower) index.
2036 (match_limit): Don't assume that a fixnum can fit in 'int'.
2038 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2041 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2042 (Fvertical_motion): Don't wrap around LINES values that don't fit
2043 in 'int'. Instead, treat them as extreme values. This is good
2044 enough for windows, which can't have more than INT_MAX lines anyway.
2046 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2048 * Require libxml/parser.h to avoid compilation warning.
2050 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2052 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2053 since this reportedly can destroy thread storage.
2055 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2057 * syntax.c (find_defun_start): Update all cache variables if
2058 exiting early (Bug#9401).
2060 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2062 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2064 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2065 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2066 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2068 * term.c (tty_append_glyph): New function.
2069 (produce_stretch_glyph): Static function and its prototype deleted.
2071 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2074 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2076 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2077 when checking :margin (Bug#9390).
2078 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2079 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2080 so that the name doesn't mislead. All uses changed.
2082 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2084 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2087 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2089 * xdisp.c (move_it_to): Don't bail out early when reaching
2090 position beyond to_charpos, if we are scanning backwards.
2091 (move_it_vertically_backward): When DY == 0, make sure we get to
2092 the first character in the line after the newline.
2094 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2096 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2097 (ccl_driver): Do not generate an out-of-range pointer.
2098 (Fccl_execute_on_string): Remove unnecessary check for
2099 integer overflow, noted by Stefan Monnier in
2100 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2101 Remove a FIXME that didn't need fixing.
2102 Simplify the newly-introduced buffer reallocation code.
2104 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2106 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2108 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2110 Integer and memory overflow issues (Bug#9196).
2112 * doc.c (get_doc_string): Rework so that
2113 get_doc_string_buffer_size is the actual buffer size, rather than
2114 being 1 less than the actual buffer size; this makes xpalloc more
2117 * image.c (x_allocate_bitmap_record, cache_image):
2118 * xselect.c (Fx_register_dnd_atom):
2119 Simplify previous changes by using xpalloc.
2121 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2122 since either will do and ptrdiff_t is convenient with xpalloc.
2124 * charset.c (charset_table_size)
2125 (struct charset_sort_data.priority): Now ptrdiff_t.
2126 (charset_compare): Don't overflow if priorities differ greatly.
2127 (Fsort_charsets): Don't assume list length fits in int.
2128 Check for size-calculation overflow when allocating sort data.
2129 (syms_of_charset): Allocate an initial charset table that is
2130 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2132 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2134 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2135 The actual value is always <= INT_MAX, and leaving it unsigned made
2136 overflow checking harder.
2138 * dispextern.h (struct glyph_matrix.rows_allocated)
2139 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2140 with xpalloc. The values are still always <= INT_MAX.
2142 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2144 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2145 (SAFE_NALLOCA): New macro.
2147 * region-cache.c (struct boundary.pos, find_cache_boundary)
2148 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2149 (set_cache_region, invalidate_region_cache)
2150 (revalidate_region_cache, know_region_cache, region_cache_forward)
2151 (region_cache_backward, pp_cache):
2152 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2153 so that ptrdiff_t * can be passed to xpalloc.
2154 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2155 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2156 (pp_cache): Don't assume cache_len fits in int.
2157 * region-cache.h: Adjust extern decls to match.
2159 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2160 EMACS_INT, since either will do, for xpalloc.
2162 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2163 (xnmalloc, xnrealloc, xpalloc): New functions.
2165 * bidi.c (bidi_shelve_header_size): New constant.
2166 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2167 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2169 * bidi.c (bidi_cache_shrink):
2170 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2172 Don't update size of array until after memory allocation succeeds,
2173 because xmalloc/xrealloc may not return.
2174 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2175 now that we have proper integer overflow checking.
2176 (record_overlay_string, overlay_strings): Catch overflows when
2177 calculating size of overlay_str_buf.
2179 * callproc.c (Fcall_process): Check for size overflow when
2180 calculating size of args2.
2181 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2182 Normally we prefer signed values, but sticking with ptrdiff_t would
2183 require adding more-complicated checks.
2185 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2186 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2187 Redo buffer-overflow calculations to avoid integer overflow.
2188 Add a FIXME comment where memory seems to be over-allocated.
2190 * character.c (Fstring): Check for size-calculation overflow.
2192 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2193 unnecessary integer overflow. Check for size overflow.
2194 (encode_coding_object): Don't update size until xmalloc succeeds.
2196 * composite.c (get_composition_id): Check for overflow in glyph
2197 length calculations.
2199 Integer and memory overflow fixes for display code.
2200 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2201 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2202 (scrolling_window): Check for overflow in size calculations.
2203 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2204 Don't assume glyph table len fits in int.
2205 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2206 (row_table_size): Now ptrdiff_t, not int.
2207 (scrolling_window): Avoid overflow in size calculations.
2208 Don't update size until allocation succeeds.
2209 * fns.c (concat): Check for overflow in size calculations.
2210 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2211 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2212 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2214 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2215 (get_doc_string): Check for size calculation overflow.
2216 Don't update size until allocation succeeds.
2217 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2218 EMACS_INT, where ptrdiff_t will do.
2219 (Fsubstitute_command_keys): Check for string overflow.
2221 * editfns.c (set_time_zone_rule): Don't assume environment length
2223 (message_length): Now ptrdiff_t, not int.
2224 (Fmessage_box): Don't update size until allocation succeeds.
2225 Don't assume message length fits in int.
2226 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2228 * emacs.c (main): Do not reallocate argv, since there is a null at
2229 the end that can be overwritten, and this way there's no need to
2230 worry about size-calculation overflow.
2231 (sort_args): Check for size-calculation overflow.
2233 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2235 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2237 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2238 (x_set_scroll_bar_width, x_figure_window_size):
2239 Check for integer overflow.
2240 (x_set_alpha): Do not assume XINT fits in int.
2242 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2243 This is for the members text_lines, text_cols, total_lines, total_cols,
2244 where the system imposes an 'int' limit.
2246 * fringe.c (Fdefine_fringe_bitmap):
2247 Don't update size until alloc works.
2249 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2250 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2252 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2253 Check for size-calculation overflow.
2254 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2255 do, as we prefer signed integers.
2256 (id_to_widget.max_size, id_to_widget.used)
2257 (xg_store_widget_in_map, xg_remove_widget_from_map)
2258 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2259 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2260 Use and return ptrdiff_t, not int.
2261 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2262 * gtkutil.h: Change prototypes to match the above.
2264 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2265 are duplicate now that they've been promoted to lisp.h.
2266 (x_allocate_bitmap_record, x_alloc_image_color)
2267 (make_image_cache, cache_image, xpm_load):
2268 Don't update size until alloc is done.
2269 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2271 Check for size calculation overflow.
2272 (ct_colors_allocated_max): New constant.
2273 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2276 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2277 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2278 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2279 Use ptrdiff_t, not int, to count maps.
2280 (read_char_minibuf_menu_prompt): Check for overflow in size
2281 calculations. Don't update size until allocation succeeds.
2282 Redo calculations to avoid overflow.
2283 * keyboard.h: Change prototypes to match the above.
2285 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2287 (current_minor_maps): Check for size calculation overflow.
2288 * keymap.h: Change prototypes to match the above.
2290 * lread.c (read1, init_obarray): Don't update size until alloc done.
2292 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2293 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2295 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2296 Now ptrdiff_t, not int.
2297 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2298 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2300 * process.c (Fnetwork_interface_list): Check for overflow
2301 in size calculation.
2303 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2305 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2306 overflow. Don't bother calling xmalloc when xrealloc will do.
2308 * search.c (Freplace_match): Check for size calculation overflow.
2309 (Fset_match_data): Don't assume list lengths fit in 'int'.
2311 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2312 for command line length. Do not attempt to address one before the
2313 beginning of an array, as that's not portable.
2315 * term.c (max_frame_lines): Remove; unused.
2316 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2318 (encode_terminal_code, calculate_costs): Check for size
2319 calculation overflow.
2320 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2321 table lengths and related sizes. Don't update size until alloc
2322 done. Redo calculations to avoid overflow.
2323 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2325 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2326 subtracting pointers.
2327 (gobble_line): Check for overflow more carefully. Don't update size
2330 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2331 Don't update size until alloc done.
2332 Redo size calculations to avoid overflow.
2333 Check for size calculation overflow.
2334 (main) [DEBUG]: Fix typo in invoking tparam1.
2336 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2337 Use ptrdiff_t, not int, for sizes.
2338 (store_mode_line_noprop_char): Don't update size until alloc done.
2340 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2341 Use ptrdiff_t, not int, for sizes.
2342 (Finternal_make_lisp_face, cache_face):
2343 Check for size calculation overflow.
2344 (cache_face): Treat size calculation overflows as if they were
2345 memory exhaustion (the usual treatment), rather than aborting.
2347 * xfns.c (x_encode_text, x_set_name_internal)
2348 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2349 sizes, since they can exceed INT_MAX in size. Check for size
2350 calculation overflow.
2352 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2353 (xg_select): Check for size calculation overflow.
2354 Don't update size until alloc done.
2356 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2357 as sprintf is limited to int lengths.
2359 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2360 (X_LONG_MIN): New macros.
2361 Use them to make the following changes clearer.
2362 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2363 This change doesn't affect the value now, but it may help remind
2364 future maintainers not to raise the value too much later.
2365 (SELECTION_QUANTUM): Remove, replacing with ...
2366 (selection_quantum): ... new function, which avoids overflow.
2368 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2369 assumption that selection length fits in 'int'.
2370 (x_reply_selection_request, x_handle_selection_request)
2371 (x_get_window_property, receive_incremental_selection)
2372 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2373 (lisp_data_to_selection_data, clean_local_selection_data):
2374 Use ptrdiff_t, not int, to record length of selection.
2375 (x_reply_selection_request, x_get_window_property)
2376 (receive_incremental_selection, x_property_data_to_lisp):
2377 Redo calculations to avoid overflow.
2378 (x_reply_selection_request): When sending hint, ceiling it at
2379 X_LONG_MAX rather than relying on wraparound overflow to send
2381 (x_get_window_property, receive_incremental_selection)
2382 (lisp_data_to_selection_data, x_property_data_to_lisp):
2383 Check for size-calculation overflow.
2384 (x_get_window_property, receive_incremental_selection)
2385 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2386 Don't store size until memory allocation succeeds.
2387 (x_get_window_property): Plug memory leak on memory exhaustion.
2388 Don't double-block input; malloc is safe here. Don't assume 2**34
2389 - 4 fits in unsigned long. Add an xassert to check
2390 XGetWindowProperty overflow. Be more careful about overflow
2391 calculations, and distinguish size from memory overflow better.
2392 (receive_incremental_selection): When tracing, don't assume
2393 unsigned int is less than INT_MAX.
2394 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2395 harmful) conversions of unsigned short to int.
2396 (lisp_data_to_selection_data): Don't assume that integers
2397 in the range -65535 through -1 fit in an X unsigned short.
2398 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2399 result parameters unless successful. Rely on cons_to_unsigned
2400 to report problems with elements; the old code wasn't right anyway.
2401 (x_check_property_data): Check for int overflow; we cannot use
2402 a wider type due to X limits.
2403 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2405 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2407 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2408 (x_term_init): Check for size calculation overflow.
2409 (x_color_cells): Don't store size until memory allocation succeeds.
2410 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2411 Don't assume alloca size is less than MAX_ALLOCA.
2412 (x_term_init): Don't assume length fits in int (sprintf is limited
2415 Use ptrdiff_t for composition IDs.
2416 * character.c (lisp_string_width):
2417 * composite.c (composition_table_size, n_compositions)
2418 (get_composition_id, composition_gstring_from_id):
2419 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2420 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2421 * window.c (Frecenter):
2422 Use ptrdiff_t, not int, for composition IDs.
2423 * composite.c (get_composition_id): Check for integer overflow.
2424 * composite.h: Adjust prototypes to match the above changes.
2426 Use ptrdiff_t for hash table indexes.
2427 * category.c (hash_get_category_set):
2428 * ccl.c (ccl_driver):
2429 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2430 * coding.c (coding_system_charset_list, detect_coding_system):
2431 * coding.h (struct coding_system.id):
2432 * composite.c (get_composition_id, gstring_lookup_cache):
2433 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2434 * image.c (xpm_get_color_table_h):
2435 * lisp.h (hash_lookup, hash_put):
2436 * minibuf.c (Ftest_completion):
2437 Use ptrdiff_t for hash table indexes, not int (which is too
2438 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2439 32-bit --with-wide-int hosts).
2441 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2442 Add a FIXME comment about memory leaks.
2443 (syms_of_charset): Don't assume xmalloc returns.
2445 Don't assume that stated character widths fit in int.
2446 * character.c (Fchar_width, c_string_width, lisp_string_width):
2447 * character.h (CHAR_WIDTH):
2448 * indent.c (MULTIBYTE_BYTES_WIDTH):
2449 Use sanitize_char_width to avoid undefined and/or bad behavior
2450 with outlandish widths.
2451 * character.h (sanitize_tab_width): Rename from sanitize_width,
2452 now that we have two such functions. All uses changed.
2453 (sanitize_char_width): New inline function.
2455 Don't assume that tab-width fits in int.
2456 * character.h (sanitize_width): New inline function.
2457 (SANE_TAB_WIDTH): New macro.
2458 (ASCII_CHAR_WIDTH): Use it.
2459 * indent.c (sane_tab_width): Remove. All uses replaced by
2460 SANE_TAB_WIDTH (current_buffer).
2461 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2463 * fileio.c: Integer overflow issues with file modes.
2464 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2466 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2467 Remove unreachable code.
2468 (read_hex, load_charset_map_from_file): Check for integer overflow.
2470 * xterm.c: Don't go over XClientMessageEvent limit.
2471 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2472 (x_send_scroll_bar_event): Likewise. Check that the size does not
2473 exceed limits imposed by XClientMessageEvent, as well as the usual
2474 ptrdiff_t and size_t limits.
2476 * keyboard.c: Overflow, signedness and related fixes.
2477 (make_lispy_movement): Use same integer type in forward decl
2478 that is used in the definition.
2479 (read_key_sequence, keyremap_step):
2480 Change bufsize argument back to int, undoing my 2011-03-30 change.
2481 We prefer signed types, and int is wide enough here.
2482 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2483 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2484 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2485 length, not size_t. Use ptrdiff_t for index, not int.
2486 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2487 possibility of integer overflow.
2489 Overflow, signedness and related fixes for images.
2491 * dispextern.h (struct it.stack[0].u.image.image_id)
2492 (struct_it.image_id, struct image.id, struct image_cache.size)
2493 (struct image_cache.used, struct image_cache.ref_count):
2494 * gtkutil.c (update_frame_tool_bar):
2495 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2496 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2497 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2498 * nsmenu.m (update_frame_tool_bar):
2499 * xdisp.c (calc_pixel_width_or_height):
2500 * xfns.c (image_cache_refcount):
2501 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2502 on typical 64-bit hosts.
2504 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2505 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2506 Omit unnecessary casts to int.
2507 (parse_image_spec): Check that integers fall into 'int' range
2508 when the callers expect that.
2509 (image_ascent): Redo ascent calculation to avoid int overflow.
2510 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2511 (lookup_image): Remove unnecessary tests.
2512 (xbm_image_p): Locals are now of int, not EMACS_INT,
2513 since parse_image_check makes sure they fit into int.
2514 (png_load, gif_load, svg_load_image):
2515 Prefer int to unsigned where either will do.
2516 (tiff_handler): New function, combining the cores of the
2517 old tiff_error_handler and tiff_warning_handler.
2518 This function is rewritten to use vsnprintf and thereby avoid
2519 stack buffer overflows. It uses only the features of vsnprintf
2520 that are common to both POSIX and native Microsoft.
2521 (tiff_error_handler, tiff_warning_handler): Use it.
2522 (tiff_load, gif_load, imagemagick_load_image):
2523 Don't assume :index value fits in 'int'.
2524 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2525 (imagemagick_load_image): Check that crop parameters fit into
2526 the integer types that MagickCropImage accepts. Don't assume
2527 Vimagemagick_render_type has a nonnegative value. Don't assume
2528 size_t fits in 'long'.
2529 (gs_load): Use printmax_t to print the widest integers possible.
2530 Check for integer overflow when computing image height and width.
2532 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2534 * xdisp.c (redisplay_window): Don't force window start if point
2535 will be invisible in the resulting window. (Bug#9324)
2537 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2539 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2540 the display spec is of the form `(space ...)'.
2541 (handle_display_spec): Return the value returned by
2542 handle_single_display_spec, not just 1 or zero.
2543 (handle_single_display_spec): If the display spec is of the form
2544 `(space ...)', and specifies display in the text area, return 2
2546 (try_cursor_movement): Check for the need to scroll more
2547 accurately, and prefer exact match for point under bidi.
2548 Don't advance `row' beyond the last row of the window.
2550 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2551 into disp_prop; all users changed.
2553 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2554 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2555 for the text covered by the display property.
2557 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2559 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2560 Change return value to nil.
2561 (Frecord_buffer): Delete unused function.
2563 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2565 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2566 buffers, return left-to-right.
2567 (set_cursor_from_row): Consider candidate row a win if its glyph
2568 represents a newline and point is on that newline. Fixes cursor
2569 positioning on the newline at EOL of R2L text within L2R
2570 paragraph, and vice versa.
2571 (try_cursor_movement): Check continued rows, in addition to
2572 continuation rows. Fixes unwarranted scroll when point enters a
2573 continued line of R2L text within an L2R paragraph, or vice versa.
2574 (cursor_row_p): Consider the case of point being equal to
2575 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2576 from the end of a short line to the beginning of a continued line
2577 of R2L text within L2R paragraph.
2578 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2579 composed characters.
2581 * bidi.c (bidi_check_type): Use xassert.
2582 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2585 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2587 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2590 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2592 * nsfont.m (ns_otf_to_script): Fix typo.
2594 2011-08-22 Kenichi Handa <handa@m17n.org>
2596 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2597 extra slot even if the purpose is char-code-property-table.
2599 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2601 * xdisp.c (redisplay_window): When computing centering_position,
2602 account for the height of the header line. (Bug#8874)
2604 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2605 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2606 candidate is selected by the mouse, and that candidate has a
2607 composed character under the mouse.
2609 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2610 coordinates reported by pos-visible-in-window-p for a composed
2611 character in column zero.
2613 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2615 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2617 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2619 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2620 consider it a hit if to_charpos is anywhere in the range of the
2621 composed buffer positions.
2623 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2625 * image.c (gif_load): Don't assume that each subimage has the same
2626 dimensions as the base image. Handle disposal method that is
2627 "undefined" by the gif spec (Bug#9335).
2629 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2631 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2632 (Fcondition_case): Document `debug' symbol in error handler.
2634 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2636 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2637 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2638 from an Org mode buffer to a Speedbar frame.
2640 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2641 a composition, take its buffer position from IT->cmp_it.charpos.
2642 Fixes cursor positioning at the beginning of a line that begins
2643 with a composed character.
2645 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2647 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2648 character bidirectional type, use STRONG_L instead. Fixes crashes
2649 in a buffer produced by `describe-categories'.
2651 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2652 members before the level stack, so they would be saved and
2653 restored when copying iterator state. Fixes incorrect reordering
2654 around TABs covered by display properties.
2656 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2658 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2660 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2662 * eval.c (internal_condition_case, internal_condition_case_1)
2663 (internal_condition_case_2, internal_condition_case_n):
2664 Remove unnecessary aborts (Bug#9081).
2666 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2668 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2669 has no `load' handler, try opening the file locally. (Bug#9311)
2671 2011-08-16 Ken Brown <kbrown@cornell.edu>
2673 * gmalloc.c: Expand comment.
2675 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2677 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2678 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2680 2011-08-16 Ken Brown <kbrown@cornell.edu>
2682 Fix memory allocation problems in Cygwin build (Bug#9273).
2684 * unexcw.c ( __malloc_initialized): Declare external variable.
2685 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2687 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2689 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2691 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2693 [CYGWIN] (special_realloc): New function.
2694 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2695 requests to realloc storage in the static heap.
2697 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2699 * bidi.c (bidi_initialize): Remove unused local.
2701 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2704 * biditype.h: Remove file.
2705 * makefile.w32-in ($(BLD)/bidi.$(O)):
2706 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2708 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2710 * chartab.c: Improve commentary for the uniprop_table API.
2712 * bidi.c (bidi_paragraph_init): Support zero value of
2713 bidi_ignore_explicit_marks_for_paragraph_level.
2714 (bidi_initialize): Use uniprop_table instead of including
2715 biditype.h and bidimirror.h.
2717 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2718 coordinates of the iterator when restoring from ppos_it.
2721 2011-08-14 Kenichi Handa <handa@m17n.org>
2723 * process.c (create_process): Call setup_process_coding_systems
2724 after the pid of the process is set to -1 (Bug#8162).
2726 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2728 * xdisp.c (move_it_in_display_line_to): Don't invoke
2729 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2730 ppos_it. Fixes vertical cursor motion when line beginning is
2731 covered by an image. (Bug#9296)
2733 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2735 * nsterm.h (ns_run_ascript): Declare.
2736 (NSAPP_DATA2_RUNASSCRIPT): Define.
2738 * nsfns.m (as_script, as_result, as_status): New static variables.
2739 (ns_run_ascript): New function.
2740 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2741 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2742 the event loop. Get status from as_status (Bug#7276).
2744 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2745 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2746 the event loop (Bug#7276).
2748 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2750 * gnutls.c (QCgnutls_bootprop_priority)
2751 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2752 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2753 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2754 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2755 (QCgnutls_bootprop_verify_hostname_error)
2756 (QCgnutls_bootprop_callbacks_verify): Rename from
2757 Qgnutls_bootprop_..., all uses changed.
2759 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2762 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2764 * xfaces.c (Qframe_set_background_mode): Now static.
2765 * dispextern.h (Qframe_set_background_mode): Remove decl.
2767 * process.c (Fnetwork_interface_info): Declare local only if needed.
2769 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2771 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2772 (Fnetwork_interface_list): Allocate in increments of bytes instead
2773 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2774 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2776 (struct ifflag_def): notrailers is smart on OSX.
2777 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2778 Get hardware address with getifaddrs if available.
2780 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2782 * xdisp.c (iterate_out_of_display_property): xassert that
2783 IT->position is set to within IT->object's boundaries. Break from
2784 the loop as soon as EOB is reached; avoids infloops in redisplay
2785 when IT->position is set up wrongly due to some bug.
2786 Set IT->current to match the bidi iterator unconditionally.
2787 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2788 entry. Force push_it to save on the stack the current
2789 buffer/string position, to be restored by pop_it. Fix flags in
2790 the iterator structure wrt the object coming from a display
2791 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2792 properties. (Bug#9284)
2794 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2796 * fontset.c (fontset_get_font_group): Add proper type checks.
2799 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2801 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2802 and LC_VERSION_MIN_MACOSX.
2803 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2804 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2806 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2808 * xdisp.c (forward_to_next_line_start): Allow to use the
2809 no-display-properties-and-no-overlays under bidi display.
2810 Set disp_pos in the bidi iterator to avoid searches for display
2811 properties and overlays.
2813 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2815 * editfns.c (Fset_time_zone_rule): Document relationship with the
2818 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2819 the font entity extracted from the cache (Bug#8109).
2821 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2823 * composite.c (autocmp_chars): Don't reset point. That is done by
2824 restore_point_unwind (Bug#5984).
2826 2011-08-07 Juri Linkov <juri@jurta.org>
2828 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2829 to show the arg `TIME' instead of `TIMEVAL'.
2831 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2833 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2834 display property strides EOL and includes a newline, as in
2835 longlines-mode. (Bug#9254)
2836 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2837 word-wrap under bidirectional display. (Bug#9224)
2839 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2840 is non-zero, even if the data buffer is NULL. Fixes a crash in
2841 vertical-motion with longlines-mode. (Bug#9254)
2843 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2845 * bidi.c <bidi_cache_total_alloc>: Now static.
2846 (bidi_initialize): Initialize bidi_cache_total_alloc.
2848 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2851 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2852 amount allocated this far in `bidi_cache_total_alloc'.
2853 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2854 non-zero, only free the data buffer without restoring the cache
2855 contents. All callers changed.
2857 * dispextern.h (bidi_unshelve_cache): Update prototype.
2859 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2860 (move_it_in_display_line, move_it_to)
2861 (move_it_vertically_backward, move_it_by_lines): Replace the call
2862 to xfree to an equivalent call to bidi_unshelve_cache.
2863 (move_it_in_display_line_to): Fix logic of returning
2864 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2866 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2868 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2869 came from a string character with a `cursor' property. (Bug#9229)
2871 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2873 * Makefile.in (LIB_PTHREAD): New variable.
2874 (LIBES): Add LIB_PTHREAD (Bug#9216).
2876 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2877 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2879 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2881 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2883 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2885 * xterm.c (x_find_topmost_parent): New function.
2886 (x_set_frame_alpha): Find topmost parent window with
2887 x_find_topmost_parent and set the property there also (bug#9181).
2888 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2890 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2892 * callproc.c (Fcall_process): Avoid vfork clobbering
2893 the local vars buffer, coding_systems, current_dir.
2895 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2897 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2899 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2901 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2902 so that it is not optimized away.
2904 * xdisp.c (compute_display_string_pos): Remove unused local.
2906 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2908 Fix slow cursor motion and scrolling in large buffers with
2909 selective display, like Org Mode buffers. (Bug#9218)
2911 * dispextern.h (struct bidi_it): New member disp_prop_p.
2913 * xdisp.c: Remove one-slot cache of display string positions.
2914 (compute_display_string_pos): Accept an additional argument
2915 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2916 for a display string or property. If found, set DISP_PROP_P
2919 * bidi.c (bidi_fetch_char): Accept an additional argument
2920 DISP_PROP_P, and pass it to compute_display_string_pos.
2921 Only handle text covered by a display string if DISP_PROP_P is returned
2922 non-zero. All callers of bidi_fetch_char changed.
2924 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2926 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2928 2010-12-03 Don March <don@ohspite.net>
2930 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2931 last character M-[char] is translated to ESC [char] (bug#7541).
2933 2011-08-02 Kenichi Handa <handa@m17n.org>
2935 * lisp.h (uniprop_table): Extern it.
2937 * chartab.c (uniprop_table): Make it non-static.
2939 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2941 * xdisp.c (forward_to_next_line_start): Accept additional argument
2942 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2944 (reseat_at_next_visible_line_start): Use the bidi iterator state
2945 returned by forward_to_next_line_start to restore the state of
2946 it->bidi_it after backing up to previous newline. (Bug#9212)
2948 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2950 * regex.c (re_comp): Protoize.
2951 (re_exec): Fix return type.
2952 (regexec): Fix type of `ret'. (Bug#9203)
2954 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2956 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2957 This is needed if max-image-size is a floating-point number.
2959 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2961 * print.c (print_object): Print empty symbol as ##.
2963 * lread.c (read1): Read ## as empty symbol.
2965 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2967 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2968 setting frame foreground color (Bug#9175).
2969 (x_set_background_color): Likewise.
2971 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2972 contents (Bug#9176).
2973 (EmacsTooltip -init): Remove bezels and add shadows to
2976 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2977 or scroll bar (Bug#8470).
2979 * nsfont.m (nsfont_open): Remove assignment to voffset and
2980 unnecessary vars hshink, expand, hd, full_height, min_height.
2981 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2983 * nsterm.h (nsfont_info): Remove voffset field.
2985 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2987 Implement strike-through and overline on NextStep (Bug#8863).
2989 * nsfont.m (nsfont_open): Use underline position provided by font,
2990 instead of hard-coded value of 2.
2991 (nsfont_draw): Call ns_draw_text_decoration instead.
2993 * nsterm.h: Add declaration for ns_draw_text_decoration.
2995 * nsterm.m (ns_draw_text_decoration): New function for drawing
2996 underline, overline, and strike-through.
2997 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2998 ns_draw_text_decoration. Change treatment of cursor drawing to
2999 accommodate underlining, etc.
3001 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3003 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3006 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3008 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3009 Without this fix, if a signal arrives just after memory fills up,
3010 'malloc' might be invoked reentrantly.
3012 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3013 In other words, assume that every image size is allowed, on non-X
3014 hosts. This assumption is probably wrong, but it lets Emacs compile.
3016 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3018 * regex.c (re_iswctype): Convert return values to boolean.
3020 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3022 * xdisp.c (compute_display_string_pos): Don't use cached display
3023 string position if the buffer had its restriction changed.
3026 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3028 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3030 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3032 Integer signedness and overflow and related fixes. (Bug#9079)
3034 * bidi.c: Integer size and overflow fixes.
3035 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3036 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3037 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3038 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3039 (bidi_find_other_level_edge):
3040 Use ptrdiff_t instead of EMACS_INT where either will do.
3041 This works better on 32-bit hosts configured --with-wide-int.
3042 (bidi_cache_ensure_space): Check for size-calculation overflow.
3043 Use % rather than repeated addition, for better worst-case speed.
3044 Don't set bidi_cache_size until after xrealloc returns, because it
3046 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3047 (bidi_cache_ensure_space): Also check that the bidi cache size
3048 does not exceed that of the largest Lisp string or buffer. See Eli
3049 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3051 * alloc.c (__malloc_size_t): Remove.
3052 All uses replaced by size_t. See Andreas Schwab's note
3053 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3055 * image.c: Improve checking for integer overflow.
3056 (check_image_size): Assume that f is nonnull, since
3057 it is always nonnull in practice. This is one less thing to
3058 worry about when checking for integer overflow later.
3059 (x_check_image_size): New function, which checks for integer
3060 overflow issues inside X.
3061 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3062 This removes the need for a memory_full check.
3063 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3064 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3065 (xbm_read_bitmap_data): Change locals back to 'int', since
3066 their values must fit in 'int'.
3067 (xpm_load_image, png_load, tiff_load):
3068 Invoke x_create_x_image_and_pixmap earlier,
3069 to avoid much needless work if the image is too large.
3070 (tiff_load): Treat overly large images as if
3071 x_create_x_image_and_pixmap failed, not as malloc failures.
3072 (gs_load): Use x_check_image_size.
3074 * gtkutil.c: Omit integer casts.
3075 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3076 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3078 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3080 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3081 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3082 would wrongly return t on a 64-bit host.
3084 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3085 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3086 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3087 and therefore cause GCC to emit a bogus diagnostic in some cases.
3089 * image.c: Integer signedness and overflow and related fixes.
3090 This is not an exhaustive set of fixes, but it's time to
3091 record what I've got.
3092 (lookup_pixel_color, check_image_size): Remove redundant decls.
3093 (check_image_size): Don't assume that arbitrary EMACS_INT values
3094 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3095 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3096 (tiff_load, imagemagick_load_image):
3097 Check for overflow in size calculations.
3098 (x_create_x_image_and_pixmap): Remove unnecessary test for
3099 xmalloc returning NULL; that can't happen.
3100 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3101 (xpm_color_bucket): Use better integer hashing function.
3102 (xpm_cache_color): Don't possibly over-allocate memory.
3103 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3104 (gif_memory_source):
3105 Use ptrdiff_t, not int or size_t, to record sizes.
3106 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3107 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3108 either works, as we prefer signed integers.
3109 (tiff_read_from_memory, tiff_write_from_memory):
3110 Return tsize_t, not size_t, since that's what the TIFF API wants.
3111 (tiff_read_from_memory): Don't fail simply because the read would
3112 go past EOF; instead, return a short read.
3113 (tiff_load): Omit no-longer-needed casts.
3114 (Fimagemagick_types): Don't assume size fits into 'int'.
3116 Improve hashing quality when configured --with-wide-int.
3117 * fns.c (hash_string): New function, taken from sxhash_string.
3118 Do not discard information about ASCII character case; this
3119 discarding is no longer needed.
3120 (sxhash-string): Use it. Change sig to match it. Caller changed.
3121 * lisp.h: Declare it.
3122 * lread.c (hash_string): Remove, since we now use fns.c's version.
3123 The fns.c version returns a wider integer if --with-wide-int is
3124 specified, so this should help the quality of the hashing a bit.
3126 * emacs.c: Integer overflow minor fix.
3127 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3128 Define only if GNU_LINUX.
3129 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3131 * dispnew.c: Integer signedness and overflow fixes.
3132 Remove unnecessary forward decls, that were a maintenance hassle.
3133 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3135 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3136 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3137 (prepare_desired_row, line_draw_cost):
3138 Use int, not unsigned, where either works.
3139 (save_current_matrix, restore_current_matrix):
3140 Use ptrdiff_t, not size_t, where either works.
3141 (init_display): Check for overflow more accurately, and without
3142 relying on undefined behavior.
3144 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3145 Remove, replacing with the new symbols in lisp.h. All uses changed.
3146 * fileio.c (make_temp_name):
3147 * filelock.c (lock_file_1, lock_file):
3148 * xdisp.c (message_dolog):
3149 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3150 Use pMd etc. instead.
3151 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3152 replacing the pWIDE etc. symbols removed from editfns.c.
3154 * keyboard.h (num_input_events): Now uintmax_t.
3155 This is (very slightly) less likely to mess up due to wraparound.
3158 * buffer.c: Integer signedness fixes.
3159 (alloc_buffer_text, enlarge_buffer_text):
3160 Use ptrdiff_t rather than size_t when either will do, as we prefer
3163 * alloc.c: Integer signedness and overflow fixes.
3164 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3165 (__malloc_size_t): Default to size_t, not to int.
3166 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3167 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3168 Prefer ptrdiff_t to size_t when either would do, as we prefer
3170 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3171 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3172 Now const. Initialize with values that are in range even if char
3174 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3175 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3176 These functions do the right thing with sizes > 2**32.
3177 (check_depth): Now ptrdiff_t, not int.
3178 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3179 Adjust to new way of storing sizes. Check for size overflow bugs
3181 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3182 slightly wrong anyway, as it missed one instance of
3183 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3184 (refill_memory_reserve): Omit needless cast to size_t.
3185 (mark_object_loop_halt): Mark as externally visible.
3187 * xselect.c: Integer signedness and overflow fixes.
3188 (Fx_register_dnd_atom, x_handle_dnd_message):
3189 Use ptrdiff_t, not size_t, since we prefer signed.
3190 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3191 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3192 x_dnd_atoms_size and x_dnd_atoms_length.
3194 * doprnt.c: Prefer signed to unsigned when either works.
3196 * doprnt.c (doprnt):
3198 * xdisp.c (vmessage):
3199 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3200 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3201 prefer signed arithmetic to avoid comparison confusion.
3202 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3203 but is a bit tricky.
3205 Assume freestanding C89 headers, string.h, stdlib.h.
3206 * data.c, doprnt.c, floatfns.c, print.c:
3207 Include float.h unconditionally.
3208 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3209 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3210 * regex.c: Likewise for stddef.h, string.h.
3211 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3212 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3213 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3214 (STDC_HEADERS): Remove obsolete defines.
3215 * sysdep.c: Include limits.h unconditionally.
3217 Assume support for memcmp, memcpy, memmove, memset.
3218 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3219 * regex.c (memcmp, memcpy):
3220 Remove; we assume C89 now.
3222 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3223 (__malloc_safe_bcopy): Remove; no longer needed.
3225 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3226 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3227 well either way, and we prefer signed to unsigned.
3229 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3231 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3232 closes the connection while we're reading (bug#9182).
3234 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3236 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3237 are specified (Bug#9168).
3239 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3241 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3242 Found by GCC static checking and --with-wide-int on a 32-bit host.
3244 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3246 * xdisp.c (compute_display_string_pos): Fix logic of caching
3247 previous display string position. Initialize cached_prev_pos to
3248 -1. Fixes slow-down at the beginning of a buffer.
3250 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3252 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3253 for attrs[LFACE_FONTSET_INDEX].
3255 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3257 * xml.c (parse_region): Remove unused local
3258 that was recently introduced.
3260 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3262 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3263 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3265 * xdisp.c (move_it_in_display_line_to): Record the best matching
3266 position for TO_CHARPOS while scanning the line, and restore it on
3267 exit if none of the characters scanned was an exact match.
3268 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3269 when exact match is impossible due to invisible text, and the
3270 lines are truncated.
3272 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3274 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3277 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3279 Fix a significant slow-down of cursor motion with C-n, C-p,
3280 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3281 auto-repeat under bidi redisplay in fontified buffers.
3282 * xdisp.c (compute_stop_pos_backwards): New function.
3283 (next_element_from_buffer): Call compute_stop_pos_backwards to
3284 find a suitable prev_stop when we find ourselves before
3286 (reseat): Don't look for prev_stop, as that could mean a very long
3288 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3289 <cached_disp_overlay_modiff>: Cache for last found display string
3291 (compute_display_string_pos): Return the cached position if asked
3292 about the same buffer in the same area of character positions, and
3293 the buffer wasn't changed since the time the display string
3294 position was cached.
3296 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3298 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3299 is an integer, which is important for empty lines. (Bug#9149)
3301 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3303 * frame.c (Fmodify_frame_parameters): In tty case, update the
3304 default face if necessary (Bug#4238).
3306 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3308 * editfns.c (Fstring_to_char): No need to explain what a character
3309 is in the docstring (Bug#6576).
3311 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3313 * xml.c (parse_region): Make sure we always return a tree.
3315 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3317 * xml.c (parse_region): If a document contains only comments,
3320 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3322 * xml.c (make_dom): Return comments, too.
3324 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3327 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3328 and the surrounding thread.
3329 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3330 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3331 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3333 * s/openbsd.h (BROKEN_SIGIO): Define.
3334 * unexelf.c (unexec) [__OpenBSD__]:
3335 Don't update the .mdebug section of the Alpha COFF symbol table.
3337 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3339 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3342 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3344 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3345 This fixes some race conditions on the permissions of any newly
3348 * alloc.c (valid_pointer_p): Use pipe, not open.
3349 This fixes some permissions issues when debugging.
3351 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3352 If fchown fails to set both uid and gid, try to set just gid,
3353 as that is sometimes allowed. Adjust the file's mode to eliminate
3354 setuid or setgid bits that are inappropriate if fchown fails.
3356 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3358 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3359 to compare Lisp_Objects.
3360 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3361 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3362 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3364 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3366 * lread.c (read_integer): Unread even EOF character.
3367 (read1): Likewise. Properly record start position of symbol.
3369 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3370 symbol character follows.
3372 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3374 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3375 This works around a problem with the previous change to Fcopy_file.
3376 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3377 and without this change, GCC might complain about discarding
3378 fchown's return value.
3380 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3382 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3384 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3386 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3388 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3390 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3391 it's used from the C level.
3393 * process.c: Use the same condition for POLL_FOR_INPUT in both
3394 keyboard.c and process.c (bug#1858).
3396 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3398 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3399 (Fgnutls_boot): Use it.
3401 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3403 * doc.c (Fsubstitute_command_keys): Revert last change.
3405 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3407 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3408 quotes the next character, and doesn't affect other longer
3409 sequences (bug#8935).
3411 * lread.c (syms_of_lread): Clarify that is isn't only
3412 `eval-buffer' and `eval-defun' that's affected by
3413 `lexical-binding' (bug#8460).
3415 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3417 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3418 bidi redisplay when a line includes both an image and is truncated.
3420 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3422 Fix minor problems found by static checking.
3423 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3424 (elsz): Now a signed constant, not a size_t var. We prefer signed
3425 types to unsigned, to avoid integer comparison confusion. Without
3426 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3427 "cannot optimize loop, the loop counter may overflow", a symptom
3429 * indent.c (Fvertical_motion): Mark locals as initialized.
3430 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3432 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3434 * search.c (Fre_search_backward): Mention `case-fold-search' in
3435 all the re_search_* functions (bug#8138).
3437 * keyboard.c (Fopen_dribble_file): Document when the file is
3440 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3442 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3445 Support bidi reordering of display and overlay strings.
3446 * xdisp.c (compute_display_string_pos)
3447 (compute_display_string_end): Accept additional argument STRING.
3448 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3449 (reseat_to_string): Initialize bidi_it->string.s and
3450 bidi_it->string.schars.
3451 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3452 NULL (avoids a crash in bidi_paragraph_init).
3453 Initialize itb.string.lstring.
3454 (init_iterator): Call bidi_init_it only of a valid
3455 buffer position was specified. Initialize paragraph_embedding to
3457 (reseat_to_string): Initialize the bidi iterator.
3458 (display_string): If we need to ignore text properties of
3459 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3460 original value of -1 will not work with bidi.)
3461 (compute_display_string_pos): First arg is now struct
3462 `text_pos *'; all callers changed. Support display properties on
3464 (compute_display_string_end): Support display properties on Lisp
3466 (init_iterator, reseat_1, reseat_to_string): Initialize the
3467 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3468 when iterating on a string not from display properties).
3469 (compute_display_string_pos, compute_display_string_end):
3470 Fix calculation of the object to scan. Fixes an error when using
3472 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3473 base_level_stop; instead, set base_level_stop to BEGV.
3474 Fixes crashes in vertical-motion.
3475 (next_element_from_buffer): Improve commentary for when
3476 the iterator is before prev_stop.
3477 (init_iterator): Initialize bidi_p from the default value of
3478 bidi-display-reordering, not from buffer-local value. Use the
3479 buffer-local value only if initializing for buffer iteration.
3480 (handle_invisible_prop): Support invisible properties on strings
3481 that are being bidi-reordered.
3482 (set_iterator_to_next): Support bidi reordering of C strings and
3484 (next_element_from_string): Support bidi reordering of Lisp
3486 (handle_stop_backwards): Support Lisp strings as well.
3487 (display_string): Support display of R2L glyph rows.
3488 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3489 (init_iterator): Don't initialize it->bidi_p for strings
3491 (reseat_to_string): Initialize it->bidi_p for strings here.
3492 (next_element_from_string, next_element_from_c_string)
3493 (next_element_from_buffer): Add xassert's for correspondence
3494 between IT's object being iterated and it->bidi_it.string
3496 (face_before_or_after_it_pos): Support bidi iteration.
3497 (next_element_from_c_string): Handle the case of the first string
3498 character that is not the first one in the visual order.
3499 (get_visually_first_element): New function, refactored from common
3500 parts of next_element_from_buffer, next_element_from_string, and
3501 next_element_from_c_string.
3502 (tool_bar_lines_needed, redisplay_tool_bar)
3503 (display_menu_bar): Force left-to-right direction. Add a FIXME
3504 comment for making that be controlled by a user option.
3505 (push_it, pop_it): Save and restore the state of the
3506 bidi iterator. Save and restore the bidi_p flag.
3507 (pop_it): Iterate out of display property for string iteration as
3509 (iterate_out_of_display_property): Support iteration over strings.
3510 (handle_single_display_spec): Set up it->bidi_it for iteration
3511 over a display string, and call bidi_init_it.
3512 (handle_single_display_spec, next_overlay_string)
3513 (get_overlay_strings_1, push_display_prop): Set up the bidi
3514 iterator for displaying display or overlay strings.
3515 (forward_to_next_line_start): Don't use the shortcut if
3517 (back_to_previous_visible_line_start): If handle_display_prop
3518 pushed the iterator stack, restore the internal state of the bidi
3519 iterator by calling bidi_pop_it same number of times.
3520 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3521 and we are bidi-iterating, don't decrement the iterator position;
3522 instead, set the first_elt flag in the bidi iterator, to produce
3524 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3525 (push_display_prop): xassert that we are iterating a buffer.
3526 (push_it, pop_it): Save and restore paragraph_embedding member.
3527 (handle_single_display_spec, next_overlay_string)
3528 (get_overlay_strings_1, reseat_1, reseat_to_string)
3529 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3530 correctly. Don't assume unibyte strings are not bidi-reordered.
3531 (compute_display_string_pos)
3532 (compute_display_string_end): Fix handling the case of C string.
3533 (push_it, pop_it): Save and restore from_disp_prop_p.
3534 (handle_single_display_spec, push_display_prop): Set the
3535 from_disp_prop_p flag.
3536 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3537 (pop_it): Call iterate_out_of_display_property only if we are
3538 popping after iteration over a string that came from a display
3539 property. Fix a typo in popping stretch info. Add an assertion
3540 for verifying that the iterator position is in sync with the bidi
3542 (handle_single_display_spec, get_overlay_strings_1)
3543 (push_display_prop): Fix initialization of paragraph direction for
3544 string when that of the parent object is not yet determined.
3545 (reseat_1): Call bidi_init_it to resync the bidi
3546 iterator with IT's position. (Bug#7616)
3547 (find_row_edges): If ROW->start.pos gives position
3548 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3549 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3550 Reset the from_disp_prop_p flag.
3551 (SAVE_IT, RESTORE_IT): New macros.
3552 (pos_visible_p, face_before_or_after_it_pos)
3553 (back_to_previous_visible_line_start)
3554 (move_it_in_display_line_to, move_it_in_display_line)
3555 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3556 (try_scrolling, redisplay_window, display_line): Use them when
3557 saving a temporary copy of the iterator and restoring it back.
3558 (back_to_previous_visible_line_start, reseat_1)
3559 (init_iterator): Empty the bidi cache "stack".
3560 (move_it_in_display_line_to): If iterator ended up at
3561 EOL, but we never saw any buffer positions smaller than
3562 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3563 motion in bidi-reordered lines.
3564 (move_it_in_display_line_to): Record prev_method and prev_pos
3565 immediately before the call to set_iterator_to_next. Fixes cursor
3566 motion in bidi-reordered lines with stretch glyphs and strings
3567 displayed in margins. (Bug#8133) (Bug#8867)
3568 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3570 (pos_visible_p): Support positions in bidi-reordered lines.
3571 Save and restore bidi cache.
3573 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3574 (bidi_paragraph_info): Delete unused struct.
3575 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3576 (bidi_cache_start): New variable.
3577 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3579 (bidi_cache_fetch_state, bidi_cache_search)
3580 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3581 (bidi_cache_find, bidi_peek_at_next_level)
3582 (bidi_level_of_next_char, bidi_find_other_level_edge)
3583 (bidi_move_to_visually_next): Compare cache index with
3584 bidi_cache_start rather than with zero.
3585 (bidi_fetch_char): Accept new argument STRING; all callers
3586 changed. Support iteration over a string. Support strings with
3587 display properties. Support unibyte strings. Fix the type of
3588 `len' according to what STRING_CHAR_AND_LENGTH expects.
3589 (bidi_paragraph_init, bidi_resolve_explicit_1)
3590 (bidi_resolve_explicit, bidi_resolve_weak)
3591 (bidi_level_of_next_char, bidi_move_to_visually_next):
3592 Support iteration over a string.
3593 (bidi_set_sor_type, bidi_resolve_explicit_1)
3594 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3595 can now be zero (for strings); special values 0 and -1 were
3596 changed to -1 and -2, respectively.
3597 (bidi_char_at_pos): New function.
3598 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3599 Call it instead of FETCH_MULTIBYTE_CHAR.
3600 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3601 initialized to valid values.
3602 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3604 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3605 the test for valid cached positions. Fix the logic for looking up
3606 the sentinel state in the cache. GCPRO the Lisp string we are
3608 (bidi_push_it, bidi_pop_it): New functions.
3609 (bidi_initialize): Initialize the bidi cache start stack pointer.
3610 (bidi_cache_ensure_space): New function, refactored from part of
3611 bidi_cache_iterator_state. Don't assume the required size is just
3612 one BIDI_CACHE_CHUNK away.
3613 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3614 (bidi_count_bytes, bidi_char_at_pos): New functions.
3615 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3616 always valid if bidi_cache_idx is valid.
3617 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3618 is valid if it's going to be used.
3619 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3620 (bidi_cache_fetch_state, bidi_cache_search)
3621 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3622 (bidi_cache_iterator_state, bidi_cache_find)
3623 (bidi_find_other_level_edge, bidi_cache_start_stack):
3624 All variables related to cache indices are now EMACS_INT.
3626 * dispextern.h (struct bidi_string_data): New structure.
3627 (struct bidi_it): New member `string'. Make flag members be 1-bit
3628 fields, and put them last in the struct.
3629 (compute_display_string_pos, compute_display_string_end):
3631 (bidi_push_it, bidi_pop_it): Add prototypes.
3632 (struct iterator_stack_entry): New members bidi_p,
3633 paragraph_embedding, and from_disp_prop_p.
3634 (struct it): Member bidi_p is now a bit field 1 bit wide.
3635 (bidi_shelve_cache, bidi_unshelve_cache):
3638 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3639 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3640 and vector-like objects.
3642 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3643 cache around display iteration.
3645 * window.c (Fwindow_end, window_scroll_pixel_based)
3646 (displayed_window_lines, Frecenter): Save and restore the bidi
3647 cache around display iteration.
3649 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3651 * editfns.c (Fdelete_region): Clarify the use of the named
3652 parameters (bug#6788).
3654 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3656 * indent.c (Fvertical_motion): Set and restore w->pointm when
3657 saving and restoring the window's buffer (Bug#9006).
3659 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3661 * editfns.c (Fstring_to_char): Clarify just what is returned
3662 (bug#6576). Text by Eli Zaretskii.
3664 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3666 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3668 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3670 * buffer.c (mmap_find): Fix a typo.
3672 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3674 Fix execution of x selection hooks.
3675 * xselect.c (Qx_lost_selection_functions)
3676 (Qx_sent_selection_functions): New vars.
3677 (syms_of_xselect): DEFSYM them.
3678 (x_handle_selection_request): Pass Qx_sent_selection_functions
3679 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3680 (x_handle_selection_clear,x_clear_frame_selections):
3681 Pass Qx_lost_selection_functions rather than
3682 Vx_lost_selection_functions to Frun_hook_with_args.
3684 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3686 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3687 The old code sometimes used this field without initializing it.
3689 * alloc.c (gc_sweep): Don't read past end of array.
3690 In theory, the old code could also have corrupted Emacs internals,
3691 though it'd be very unlikely.
3693 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3695 * character.c (Fcharacterp): Don't advertise optional ignored
3696 argument. (Bug#4026)
3698 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3700 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3703 * window.c (Fset_window_start): Doc fix (bug#4199).
3704 (Fset_window_hscroll): Ditto.
3706 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3708 Fix minor new problems caught by GCC 4.6.1.
3709 * term.c (init_tty): Remove unused local.
3710 * xsettings.c (store_monospaced_changed): Define this function only
3711 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3714 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3716 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3718 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3720 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3721 are the mini-buffer and the echo area (bug#3320).
3723 * term.c (init_tty): Remove support for supdup, c10 and perq
3724 terminals, which are no longer supported (bug#1482).
3726 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3728 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3730 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3732 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3733 for non-popups (Bug#3642).
3735 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3737 * alloc.c (reset_malloc_hooks): Protoize.
3738 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3739 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3740 * cm.c (losecursor): Likewise.
3741 * data.c (fmod): Likewise.
3742 * dispnew.c (swap_glyphs_in_rows): Likewise.
3743 * emacs.c (memory_warning_signal): Likewise.
3744 * floatfns.c (float_error): Likewise.
3745 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3746 (otf_open, font_otf_capability, generate_otf_features)
3747 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3749 * image.c (pbm_read_file): Likewise.
3750 * indent.c (string_display_width): Likewise.
3751 * intervals.c (check_for_interval, search_for_interval)
3752 (inc_interval_count, count_intervals, root_interval)
3753 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3754 * lread.c (defalias): Likewise.
3755 * ralloc.c (r_alloc_check): Likewise.
3756 * regex.c (set_image_of_range_1, set_image_of_range)
3757 (regex_grow_registers): Likewise.
3758 * sysdep.c (strerror): Likewise.
3759 * termcap.c (valid_filename_p, tprint, main): Likewise.
3760 * tparam.c (main): Likewise.
3761 * unexhp9k800.c (run_time_remap, save_data_space)
3762 (update_file_ptrs, read_header, write_header, calculate_checksum)
3763 (copy_file, copy_rest, display_header): Likewise.
3764 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3766 * xdisp.c (check_it): Likewise.
3767 * xfaces.c (register_color, unregister_color, unregister_colors):
3769 * xfns.c (print_fontset_result): Likewise.
3770 * xrdb.c (member, fatal, main): Likewise.
3772 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3774 Fix minor problems found by static checking (Bug#9031).
3775 * chartab.c (char_table_set_range, map_sub_char_table):
3776 Remove unused locals.
3777 (uniprop_table): Now static.
3778 * composite.c (_work_char): Remove unused static var.
3780 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3782 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3784 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3786 * gtkutil.c (qttip_cb): Remove code without function.
3788 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3790 * w32.c (pthread_sigmask): New stub.
3792 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3794 Use pthread_sigmask, not sigprocmask (Bug#9010).
3795 sigprocmask is portable only for single-threaded applications, and
3796 Emacs can be multi-threaded when it uses GTK.
3797 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3799 * callproc.c (Fcall_process):
3800 * process.c (create_process):
3801 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3802 Use pthread_sigmask, not sigprocmask.
3804 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3806 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3807 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3810 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3812 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3813 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3814 (xg_hide_tooltip): Fix comment.
3816 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3817 in registerServicesMenuSendTypes.
3818 (validRequestorForSendType): Don't check ns_return_types.
3820 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3823 2011-07-08 Jason Rumney <jasonr@gnu.org>
3825 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3826 SH_SHOW for hidden windows (Bug#5482).
3828 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3829 frame struct members of non-existent frames (Bug#6284).
3831 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3833 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3834 variable firstTime not needed on OSX >= 10.6.
3835 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3836 >= 10.5. Use setKnobProportion, setDoubleValue.
3838 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3839 (MAC_OS_X_VERSION_10_5): Define if not defined.
3840 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3841 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3842 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3844 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3845 cString and lossyCString on OSX >= 10.4
3847 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3848 sizeToFit on OSX >= 10.2.
3850 * nsimage.m (allocInitFromFile): Don't use deprecated method
3851 bestRepresentationForDevice on OSX >= 10.6.
3853 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3856 * emacs.c: Declare unexec_init_emacs_zone.
3858 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3860 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3862 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3863 on svcsMenu (Bug#8842).
3865 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3867 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3869 * nsterm.m (QUTF8_STRING): Declare.
3870 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3871 (validRequestorForSendType): Return type is (id).
3872 Change indexOfObjectIdenticalTo to indexOfObject.
3873 Check if we have local selection before returning self (Bug#8842).
3874 (writeSelectionToPasteboard): Put local selection into paste board
3875 if we have a local selection (Bug#8842).
3876 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3878 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3879 (ns_get_local_selection): Declare.
3881 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3883 * keymap.c (describe_map_tree): Don't insert a double newline at
3884 the end of the buffer (bug#1169) and return whether we inserted
3887 * callint.c (Fcall_interactively): Change "reading args" to
3888 "providing args" to try to clarify what it does (bug#1010).
3890 2011-07-07 Kenichi Handa <handa@m17n.org>
3892 * composite.c (composition_compute_stop_pos): Ignore a static
3893 composition starting before CHARPOS (Bug#8915).
3895 * xdisp.c (handle_composition_prop): Likewise.
3897 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3899 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3902 2011-07-07 Kenichi Handa <handa@m17n.org>
3904 * character.h (unicode_category_t): New enum type.
3906 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3907 (Qchar_code_property_table): New variable.
3908 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3909 (UNIPROP_COMPRESSED_FORM_P): New macros.
3910 (char_table_ascii): Uncompress the compressed values.
3911 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3912 Uncompress the compressed values.
3913 (sub_char_table_ref_and_range): Likewise.
3914 (char_table_ref_and_range): Uncompress the compressed values.
3915 (sub_char_table_set): New arg is_uniprop. Callers changed.
3916 Uncompress the compressed values.
3917 (sub_char_table_set_range): Args changed. Callers changed.
3918 (char_table_set_range): Adjuted for the above change.
3919 (map_sub_char_table): Delete args default_val and parent. Add arg
3920 top. Give decoded values to a Lisp function.
3921 (map_char_table): Adjust for the above change. Give decoded
3922 values to a Lisp function. Gcpro more variables.
3923 (uniprop_table_uncompress)
3924 (uniprop_decode_value_run_length): New functions.
3925 (uniprop_decoder, uniprop_decoder_count): New variables.
3926 (uniprop_get_decoder, uniprop_encode_value_character)
3927 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3929 (uniprop_encoder, uniprop_encoder_count): New variables.
3930 (uniprop_get_encoder, uniprop_table)
3931 (Funicode_property_table_internal, Fget_unicode_property_internal)
3932 (Fput_unicode_property_internal): New functions.
3933 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3934 Sunicode_property_table_internal, Sget_unicode_property_internal,
3935 and Sput_unicode_property_internal. Defvar_lisp
3936 char-code-property-alist.
3938 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3939 Vunicode_category_table.
3941 * font.c (font_range): Adjust for the change of
3942 Vunicode_category_table.
3944 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3946 * m/iris4d.h: Remove file, move contents ...
3947 * s/irix6-5.h: ... here.
3949 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3951 Remove unportable assumption about struct layout (Bug#8884).
3952 * alloc.c (mark_buffer):
3953 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3954 (clone_per_buffer_values): Don't assume that
3955 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3956 This isn't true in general, and it's particularly not true
3957 if Emacs is configured with --with-wide-int.
3958 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3959 New macros, used in the buffer.c change.
3961 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3963 * xsettings.c: Use both GConf and GSettings if both are available.
3964 (store_config_changed_event): Add comment.
3965 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3966 (store_tool_bar_style_changed): New functions.
3967 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3968 (struct xsettings): Move font inside HAVE_XFT.
3969 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3970 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3971 Move inside HAVE_XFT.
3972 (something_changed_gsettingsCB): Rename from something_changedCB.
3973 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3975 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3976 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3977 (something_changed_gconfCB): Rename from something_changedCB.
3978 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3979 (parse_settings): Move check for font inside HAVE_XFT.
3980 (read_settings, apply_xft_settings): Add comment.
3981 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3982 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3983 call store_font_name_changed.
3984 (xft_settings_event): Add comment.
3985 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3986 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3987 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3988 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3989 (xsettings_initialize): Call init_gsettings last.
3990 (xsettings_get_system_font, xsettings_get_system_normal_font):
3993 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3995 Random fixes. E.g., (random) never returned negative values.
3996 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3997 subseconds part to the entropy, as that's a bit more random.
3998 Prefer signed to unsigned, since the signedness doesn't matter and
3999 in general we prefer signed. When given a limit, use a
4000 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4001 latter isn't right if USE_2_TAGS_FOR_INTS.
4002 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4003 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4005 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4007 * textprop.c (text_property_stickiness):
4008 Obey Vtext_property_default_nonsticky.
4009 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4010 * w32fns.c (syms_of_w32fns):
4011 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4013 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4015 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4016 This is more efficient than Ffile_directory_p and avoids a minor race.
4018 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4020 * buffer.c (Foverlay_put): Say what the return value is
4023 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4024 is a directory before asking whether to use the file name
4026 (barf_or_query_if_file_exists): Make the "File is a directory"
4027 error be more correct.
4029 * fns.c (Frequire): Remove the mention of the .gz files, since
4030 that's installation-specific, but keep the mention of
4031 `get-load-suffixes'.
4033 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4035 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4036 Report string overflow if the output is too long.
4038 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4040 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4041 (syms_of_gnutls): Remove duplicate DEFSYM for
4042 Qgnutls_bootprop_verify_hostname_error, an error for
4043 Qgnutls_bootprop_verify_error (which is no longer used).
4045 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4046 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4047 Also (re)move comments that are misplaced or no longer relevant.
4049 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4051 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4053 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4055 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4056 and background color parameters if they have been changed.
4058 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4060 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4062 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4064 * xsettings.c (SYSTEM_FONT): Define only when used.
4065 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4067 * keymap.c (access_keymap_1): Now static.
4069 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4071 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4072 leave any prefix arg for the up event (Bug#1586).
4074 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4076 * lread.c (syms_of_lread): Mention single symbols defined by
4077 `defvar' or `defconst' (bug#7154).
4079 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4080 (Frequire): Mention get-load-suffixes.
4082 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4084 * window.h (window): Remove clone_number slot.
4085 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4087 (make_parent_window, make_window, saved_window)
4088 (Fset_window_configuration, save_window_save): Don't deal with
4090 * buffer.c (Qclone_number): Remove declaration.
4091 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4093 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4095 Add multiple inheritance to keymaps.
4096 * keymap.c (Fmake_composed_keymap): New function.
4097 (Fset_keymap_parent): Simplify.
4098 (fix_submap_inheritance): Remove.
4099 (access_keymap_1): New function extracted from access_keymap to handle
4100 embedded parents and handle lists of maps.
4101 (access_keymap): Use it.
4102 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4103 (Fcopy_keymap): Handle embedded parents.
4104 (Fcommand_remapping, define_as_prefix): Simplify.
4105 (Fkey_binding): Simplify.
4106 (syms_of_keymap): Move minibuffer-local-completion-map,
4107 minibuffer-local-filename-completion-map,
4108 minibuffer-local-must-match-map, and
4109 minibuffer-local-filename-must-match-map to Elisp.
4110 (syms_of_keymap): Defsubr make-composed-keymap.
4111 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4112 (parse_menu_item): Trivial simplification.
4114 2011-07-01 Glenn Morris <rgm@gnu.org>
4116 * Makefile.in (SETTINGS_LIBS): Fix typo.
4118 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4120 * coding.c (Fencode_coding_string): Record the last coding system
4121 used, as the function doc string says (bug#8738).
4123 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4125 * xsettings.c (store_monospaced_changed): Take new font as arg and
4126 check for change against current_mono_font.
4127 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4128 (emacs_settings_constructor, emacs_settings_get_property)
4129 (emacs_settings_set_property, emacs_settings_class_init)
4130 (emacs_settings_init, gsettings_obj): Remove.
4131 (something_changedCB): New function for HAVE_GSETTINGS.
4132 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4133 with value as argument.
4134 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4135 g_settings_new (Bug#8967). Do not create gsettings_obj.
4136 Remove calls to g_settings_bind. Connect something_changedCB to
4139 * xgselect.c: Add defined (HAVE_GSETTINGS).
4140 (xgselect_initialize): Ditto.
4142 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4143 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4146 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4148 * eval.c (struct backtrace): Simplify and port the data structure.
4149 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4150 signed bit field, as this assumption is not portable and it makes
4151 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4152 "char debug_on_exit : 1" as this is not portable either; instead,
4153 use the portable "unsigned int debug_on_exit : 1". Remove unused
4154 member evalargs. Remove obsolete comments about cc bombing out.
4156 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4158 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4159 Let HAVE_GSETTINGS override HAVE_GCONF.
4160 (store_monospaced_changed): New function.
4161 (EMACS_SETTINGS): A new type derived from GObject to handle
4162 GSettings notifications.
4163 (emacs_settings_constructor, emacs_settings_get_property)
4164 (emacs_settings_set_property, emacs_settings_class_init):
4166 (gsettings_client, gsettings_obj): New variables.
4167 (GSETTINGS_SCHEMA): New define.
4168 (something_changedCB): Call store_monospaced_changed.
4169 (init_gsettings): New function.
4170 (xsettings_initialize): Call init_gsettings.
4171 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4174 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4177 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4179 * window.c (resize_root_window, grow_mini_window)
4180 (shrink_mini_window): Rename Qresize_root_window to
4181 Qwindow_resize_root_window and Qresize_root_window_vertically to
4182 Qwindow_resize_root_window_vertically.
4184 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4186 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4188 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4190 * makefile.w32-in: Redesign dependencies so they reflect more
4191 clearly which files are directly included by each source file,
4192 and not through other includes.
4194 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4196 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4197 (sort_overlays, overlay_strings): When an overlay's clone number
4198 matches the window's clone number process the overlay even if
4199 the overlay's window property doesn't match the current window.
4201 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4202 (Fwindow_hchild): Rename to Fwindow_left_child.
4203 (Fwindow_next): Rename to Fwindow_next_sibling.
4204 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4205 (resize_window_check): Rename to window_resize_check.
4206 (resize_window_apply): Rename to window_resize_apply.
4207 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4208 (Fdelete_other_windows_internal, resize_frame_windows)
4209 (Fsplit_window_internal, Fdelete_window_internal)
4210 (grow_mini_window, shrink_mini_window)
4211 (Fresize_mini_window_internal): Fix callers accordingly.
4213 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4215 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4216 (emacs_fixed_set_min_size): Remove.
4217 (emacs_fixed_new): Take frame as argument.
4219 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4220 (_EmacsFixedPrivate): Remove minwidth/height.
4221 Add struct frame *f.
4222 (emacs_fixed_init): Initialize priv->f.
4223 (get_parent_class, emacs_fixed_set_min_size): Remove.
4224 (emacs_fixed_new): Set priv->f to argument.
4225 (emacs_fixed_get_preferred_width)
4226 (emacs_fixed_get_preferred_height): Use min_width/height from
4227 frames size_hint to set minimum and natural (Bug#8919).
4228 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4229 and use min_width/height from frames size_hint to set
4230 min_width/height (Bug#8919).
4232 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4233 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4236 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4238 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4239 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4242 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4244 * process.c (wait_reading_process_output): Bypass select if
4245 waiting for a cell while ignoring keyboard input, and input is
4246 pending. Suggested by Jan Djärv (Bug#8869).
4248 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4250 Use gnulib's dup2 module instead of rolling our own.
4251 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4253 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4255 * dispnew.c (scrolling_window): Before scrolling, turn off a
4256 mouse-highlight in the window being scrolled.
4258 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4260 Move DEFSYM to lisp.h and use everywhere.
4262 * character.h (DEFSYM): Move declaration...
4263 * lisp.h (DEFSYM): ...here.
4269 * w32select.c: Don't include character.h.
4271 * alloc.c (syms_of_alloc):
4272 * buffer.c (syms_of_buffer):
4273 * bytecode.c (syms_of_bytecode):
4274 * callint.c (syms_of_callint):
4275 * casefiddle.c (syms_of_casefiddle):
4276 * casetab.c (init_casetab_once):
4277 * category.c (init_category_once, syms_of_category):
4278 * ccl.c (syms_of_ccl):
4279 * cmds.c (syms_of_cmds):
4280 * composite.c (syms_of_composite):
4281 * dbusbind.c (syms_of_dbusbind):
4282 * dired.c (syms_of_dired):
4283 * dispnew.c (syms_of_display):
4284 * doc.c (syms_of_doc):
4285 * editfns.c (syms_of_editfns):
4286 * emacs.c (syms_of_emacs):
4287 * eval.c (syms_of_eval):
4288 * fileio.c (syms_of_fileio):
4289 * fns.c (syms_of_fns):
4290 * frame.c (syms_of_frame):
4291 * fringe.c (syms_of_fringe):
4292 * insdel.c (syms_of_insdel):
4293 * keymap.c (syms_of_keymap):
4294 * lread.c (init_obarray, syms_of_lread):
4295 * macros.c (syms_of_macros):
4296 * msdos.c (syms_of_msdos):
4297 * print.c (syms_of_print):
4298 * process.c (syms_of_process):
4299 * search.c (syms_of_search):
4300 * sound.c (syms_of_sound):
4301 * syntax.c (init_syntax_once, syms_of_syntax):
4302 * terminal.c (syms_of_terminal):
4303 * textprop.c (syms_of_textprop):
4304 * undo.c (syms_of_undo):
4305 * w32.c (globals_of_w32):
4306 * window.c (syms_of_window):
4307 * xdisp.c (syms_of_xdisp):
4308 * xfaces.c (syms_of_xfaces):
4309 * xfns.c (syms_of_xfns):
4310 * xmenu.c (syms_of_xmenu):
4311 * xsettings.c (syms_of_xsettings):
4312 * xterm.c (syms_of_xterm): Use DEFSYM.
4314 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4316 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4318 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4320 Integer and buffer overflow fixes (Bug#8873).
4322 * print.c (printchar, strout): Check for string overflow.
4323 (PRINTPREPARE, printchar, strout):
4324 Don't set size unless allocation succeeds.
4326 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4327 for sizes. Check for string overflow more accurately.
4328 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4330 * macros.c: Integer and buffer overflow fixes.
4331 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4332 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4333 Use ptrdiff_t, not int, for sizes.
4334 Don't increment bufsize until after realloc succeeds.
4335 Check for size-calculation overflow.
4336 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4338 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4340 * lread.c: Integer overflow fixes.
4341 (read_integer): Radix is now EMACS_INT, not int,
4342 to improve quality of diagnostics for out-of-range radices.
4343 Calculate buffer size correctly for out-of-range radices.
4344 (read1): Check for integer overflow in radices, and in
4345 read-circle numbers.
4346 (read_escape): Avoid int overflow.
4347 (Fload, openp, read_buffer_size, read1)
4348 (substitute_object_recurse, read_vector, read_list, map_obarray):
4349 Use ptrdiff_t, not int, for sizes.
4350 (read1): Use EMACS_INT, not int, for sizes.
4351 Check for size overflow.
4353 * image.c (cache_image): Check for size arithmetic overflow.
4355 * lread.c: Integer overflow issues.
4356 (saved_doc_string_size, saved_doc_string_length)
4357 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4358 Now ptrdiff_t, not int.
4359 (read1): Don't assume doc string length fits in int. Check for
4360 out-of-range doc string lengths.
4361 (read_list): Don't assume file position fits in int.
4362 (read_escape): Check for hex character overflow.
4364 2011-06-22 Leo Liu <sdl.web@gmail.com>
4366 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4367 Move to minibuffer.el.
4369 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4371 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4372 The following patches are for when GLYPH_DEBUG && !XASSERT.
4373 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4374 * dispnew.c (flush_stdout):
4375 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4376 Mark as externally visible.
4377 * dispnew.c (check_window_matrix_pointers): Now static.
4378 * dispnew.c (window_to_frame_vpos):
4379 * xfns.c (unwind_create_frame):
4380 * xterm.c (x_check_font): Remove unused local.
4381 * scroll.c (CHECK_BOUNDS):
4382 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4383 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4384 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4385 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4386 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4388 (debug_method_add): Use va_list and vsprintf rather than relying
4389 on undefined behavior with wrong number of arguments.
4390 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4391 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4392 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4393 since we're not interested in debugging glyphs with old libraries.
4394 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4395 GCC 4.6.0's static checking.
4397 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4399 Integer overflow and signedness fixes (Bug#8873).
4400 A few related buffer overrun fixes, too.
4402 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4404 * dispextern.h (struct face.stipple):
4405 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4406 (x_bitmap_mask, x_allocate_bitmap_record)
4407 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4408 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4409 (x_create_bitmap_from_xpm_data):
4410 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4411 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4413 * xfaces.c (load_pixmap):
4414 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4415 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4416 (.bitmaps_last, struct x_output.icon_bitmap):
4417 Use ptrdiff_t, not int, for bitmap indexes.
4418 (x_allocate_bitmap_record): Check for size overflow.
4419 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4421 Use ptrdiff_t, not int, for overlay counts.
4422 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4423 * editfns.c (overlays_around, get_pos_property):
4424 * textprop.c (get_char_property_and_overlay):
4425 * xdisp.c (next_overlay_change, note_mouse_highlight):
4426 * xfaces.c (face_at_buffer_position):
4427 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4428 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4429 (Fnext_overlay_change, Fprevious_overlay_change)
4430 (mouse_face_overlay_overlaps, Foverlays_in):
4431 Use ptrdiff_t, not int, for sizes.
4432 (overlays_at, overlays_in): Check for size-calculation overflow.
4434 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4436 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4437 (x_session_initialize): Do not assume string length fits in int.
4439 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4440 This is unlikely, but can occur if DPI is outlandish.
4442 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4443 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4445 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4446 * xrdb.c (magic_file_p, search_magic_path):
4447 Omit last arg SUFFIX; it was always 0. All callers changed.
4448 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4450 * xfont.c (xfont_match): Avoid need for strlen.
4452 * xfns.c: Don't assume strlen fits in int.
4453 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4455 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4456 not unsigned long, as we prefer signed integers. All callers changed.
4457 Detect integer overflow in repeat count.
4458 (message_dolog): Don't assume print length fits in 39 bytes.
4459 (display_mode_element): Don't assume strlen fits in int.
4461 * termcap.c: Don't assume sizes fit in int and never overflow.
4462 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4463 (gobble_line): Check for size-calculation overflow.
4465 * minibuf.c (Fread_buffer):
4466 * lread.c (intern, intern_c_string):
4467 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4468 Don't assume string length fits in int.
4470 * keyboard.c (parse_tool_bar_item):
4471 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4473 * font.c: Don't assume string length fits in int.
4474 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4475 Use ptrdiff_t, not int.
4476 (font_intern_prop): Don't assume string length fits in int.
4477 Don't assume integer property fits in fixnum.
4478 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4480 * filelock.c: Fix some buffer overrun and integer overflow issues.
4481 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4482 Reformulate so as not to need the command string.
4483 Invoke gzip -cd rather than gunzip, as it's more portable.
4484 (lock_info_type, lock_file_1, lock_file):
4485 Don't assume pid_t and time_t fit in unsigned long.
4486 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4487 (current_lock_owner): Prefer signed type for sizes.
4488 Use memcpy, not strncpy, where memcpy is what is really wanted.
4489 Don't assume (via atoi) that time_t and pid_t fit in int.
4490 Check for time_t and/or pid_t out of range, e.g., via a network share.
4491 Don't alloca where an auto var works fine.
4493 * fileio.c: Fix some integer overflow issues.
4494 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4495 Don't assume string length fits in int.
4496 (directory_file_name): Don't assume string length fits in long.
4497 (make_temp_name): Don't assume pid fits in int, or that its print
4498 length is less than 20.
4500 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4502 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4504 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4506 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4507 We prefer signed integers, even for size calculations.
4509 * emacs.c: Don't assume string length fits in 'int'.
4510 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4511 (main): Don't invoke strlen when not needed.
4513 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4514 (XD_DEBUG_MESSAGE): Don't waste a byte.
4516 * callproc.c (getenv_internal_1, getenv_internal)
4518 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4520 * lread.c (invalid_syntax): Omit length argument.
4521 All uses changed. This doesn't fix a bug, but it simplifies the
4522 code away from its former Hollerith-constant appearance, and it's
4523 one less 'int' to worry about when looking at integer-overflow issues.
4524 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4526 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4527 This didn't break anything, but it didn't help either.
4528 It's confusing to put a bogus integer in a place where the actual
4529 value does not matter.
4530 (LIST_END_P): Remove unused macro and its bogus comment.
4531 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4533 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4534 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4536 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4537 We prefer signed types, and the value cannot exceed the EMACS_INT
4538 range anyway (because otherwise the length would not be representable).
4539 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4540 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4541 This avoids a GCC warning when WIDE_EMACS_INT.
4543 * indent.c (sane_tab_width): New function.
4544 (current_column, scan_for_column, Findent_to, position_indentation)
4545 (compute_motion): Use it. This is just for clarity.
4546 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4548 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4550 * lisp.h (lint_assume): New macro.
4551 * composite.c (composition_gstring_put_cache):
4552 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4554 * editfns.c, insdel.c:
4555 Omit unnecessary forward decls, to simplify future changes.
4557 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4559 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4561 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4562 Use much-faster test for byte-length change.
4563 Don't assume string byte-length fits in 'int'.
4564 Check that character arg fits in 'int'.
4565 (mapcar1): Declare byte as byte, for clarity.
4567 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4569 * fns.c (concat): Catch string overflow earlier.
4570 Do not rely on integer wraparound.
4572 * dispextern.h (struct it.overlay_strings_charpos)
4573 (struct it.selective): Now EMACS_INT, not int.
4574 * xdisp.c (forward_to_next_line_start)
4575 (back_to_previous_visible_line_start)
4576 (reseat_at_next_visible_line_start, next_element_from_buffer):
4577 Don't arbitrarily truncate the value of 'selective' to int.
4579 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4581 * composite.c: Don't truncate sizes to 'int'.
4582 (composition_gstring_p, composition_reseat_it)
4583 (composition_adjust_point): Use EMACS_INT, not int.
4584 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4585 not EMACS_UINT, for indexes.
4587 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4589 * buffer.c: Include <verify.h>.
4590 (struct sortvec.priority, struct sortstr.priority):
4591 Now EMACS_INT, not int.
4592 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4593 (struct sortstr.size, record_overlay_string)
4594 (struct sortstrlist.size, struct sortlist.used):
4595 Don't truncate size to int.
4596 (record_overlay_string): Check for size-calculation overflow.
4597 (init_buffer_once): Check at compile-time, not run-time.
4599 2011-06-22 Jim Meyering <meyering@redhat.com>
4601 Don't leak an XBM-image-sized buffer
4602 * image.c (xbm_load): Free the image buffer after using it.
4604 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4607 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4608 that Sun C diagnosed.
4609 * fns.c (secure_hash): Fix pointer signedness issue.
4610 * intervals.c (static_offset_intervals): New function.
4611 (offset_intervals): Use it.
4613 2011-06-21 Leo Liu <sdl.web@gmail.com>
4616 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4619 * fns.c (secure_hash): Rename from crypto_hash_function and change
4620 the first arg to accept symbols.
4621 (Fsecure_hash): New primitive.
4622 (syms_of_fns): New symbols.
4624 2011-06-20 Deniz Dogan <deniz@dogan.se>
4626 * process.c (Fset_process_buffer): Clarify return value in
4629 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4631 * dispnew.c (add_window_display_history): Use BVAR.
4633 * xdisp.c (debug_method_add): Use BVAR.
4634 (check_window_end, dump_glyph_matrix, dump_glyph)
4635 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4637 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4640 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4641 check till after the cache is created in init_frame_faces.
4643 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4645 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4647 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4649 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4650 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4651 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4653 Improve buffer-overflow checking (Bug#8873).
4654 * fileio.c (Finsert_file_contents):
4655 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4656 Remove the old (too-loose) buffer overflow checks.
4657 They weren't needed, since make_gap checks for buffer overflow.
4658 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4659 The old code merely checked for Emacs fixnum overflow, and relied
4660 on undefined (wraparound) behavior. The new code avoids undefined
4661 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4663 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4664 Tune. Don't use wider integers than needed. Don't use alloca.
4665 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4667 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4669 * insdel.c, lisp.h (buffer_overflow): New function.
4670 (insert_from_buffer_1, replace_range, replace_range_2):
4671 * insdel.c (make_gap_larger):
4672 * editfns.c (Finsert_char):
4673 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4675 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4677 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4679 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4681 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4682 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4684 * fileio.c: Don't assume EMACS_INT fits in off_t.
4685 (emacs_lseek): New static function.
4686 (Finsert_file_contents, Fwrite_region): Use it.
4687 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4689 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4691 * fns.c: Don't overflow int when computing a list length.
4692 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4693 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4694 truncation on 64-bit hosts. Check for QUIT every
4695 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4696 faster and is responsive enough.
4697 (Flength): Report an error instead of overflowing an integer.
4698 (Fsafe_length): Return a float if the value is not representable
4699 as a fixnum. This shouldn't happen except in contrived situations.
4700 (Fnthcdr, Fsort): Don't assume list length fits in int.
4701 (Fcopy_sequence): Don't assume vector length fits in int.
4703 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4704 (header_size, word_size): New constants.
4705 (allocate_vectorlike): Don't check size overflow here.
4706 (allocate_vector): Check it here instead, since this is the only
4707 caller of allocate_vectorlike that could cause overflow.
4708 Check that the new vector's length is representable as a fixnum.
4710 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4711 The previous code was bogus. For example, next_almost_prime (32)
4712 returned 39, which is undesirable as it is a multiple of 3; and
4713 next_almost_prime (24) returned 25, which is a multiple of 5 so
4714 why was the code bothering to check for multiples of 7?
4716 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4718 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4720 Variadic C functions now count arguments with ptrdiff_t.
4721 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4722 Back then I didn't know that the Emacs coding style prefers signed int.
4723 Also, in the meantime I found a few more instances where arguments
4724 were being counted with int, which may truncate counts on 64-bit
4725 machines, or EMACS_INT, which may be unnecessarily wide.
4726 * lisp.h (struct Lisp_Subr.function.aMANY)
4727 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4728 Arg counts are now ptrdiff_t, not size_t.
4729 All variadic functions and their callers changed accordingly.
4730 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4731 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4732 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4733 * callint.c (Fcall_interactively): Check arg count for overflow,
4734 to avoid potential buffer overrun. Use signed char, not 'int',
4735 for 'varies' array, so that we needn't bother to check its size
4736 calculation for overflow.
4737 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4738 * eval.c (apply_lambda):
4739 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4740 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4741 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4743 * callint.c (Fcall_interactively): Don't use index var as event count.
4745 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4746 * mem-limits.h (SIZE): Remove; no longer used.
4748 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4750 Remove unnecessary casts.
4751 * xterm.c (x_term_init):
4752 * xfns.c (x_set_border_pixel):
4753 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4754 These aren't needed now that we assume ANSI C.
4756 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4757 It's more likely to cause problems (due to unsigned overflow)
4760 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4762 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4764 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4766 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4768 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4770 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4772 GLYPH_CODE_FACE returns EMACS_INT, not int.
4773 * dispextern.h (merge_faces):
4774 * xfaces.c (merge_faces):
4775 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4776 Don't assume EMACS_INT fits in int.
4778 * character.h (CHAR_VALID_P): Remove unused parameter.
4779 * fontset.c, lisp.h, xdisp.c: All uses changed.
4781 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4783 * fns.c (concat): Minor tuning based on overflow analysis.
4784 This doesn't fix any bugs. Use int to hold character, instead
4785 of constantly refetching from Emacs object. Use XFASTINT, not
4786 XINT, for value known to be a character. Don't bother comparing
4787 a single byte to 0400, as it's always less.
4789 * floatfns.c (Fexpt):
4790 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4792 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4795 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4797 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4798 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4799 incorrectly succeed when S was a string, because 4294967386 was
4800 truncated before it was used.
4802 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4803 Otherwise, an out-of-range integer could cause undefined behavior
4806 * composite.c: Use int, not EMACS_INT, for characters.
4807 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4808 EMACS_INT, for values that are known to be in character range.
4809 This doesn't fix any bugs but is the usual style inside Emacs and
4810 may generate better code on 32-bit machines.
4812 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4813 This is for reasons similar to the recent CHAR_STRING fix.
4814 * charset.c (Fencode_char): Check that character arg is actually
4815 a character. Pass an int to ENCODE_CHAR.
4816 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4817 wider than 'int', as a compile-time check to prevent future regressions
4820 * character.c (char_string): Remove unnecessary casts.
4822 Make sure a 64-bit char is never passed to CHAR_STRING.
4823 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4824 by silently ignoring the top 32 bits, allowing some values
4825 that were far too large to be valid characters.
4826 * character.h: Include <verify.h>.
4827 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4828 arguments are no wider than unsigned, as a compile-time check
4829 to prevent future regressions in this area.
4831 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4832 (Fsubst_char_in_region):
4834 * xdisp.c (decode_mode_spec_coding):
4835 Adjust to CHAR_STRING's new requirement.
4836 * editfns.c (Finsert_char, Fsubst_char_in_region):
4837 * fns.c (concat): Check that character args are actually
4838 characters. Without this test, these functions did the wrong
4839 thing with wildly out-of-range values on 64-bit hosts.
4841 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4842 These casts should not be needed on 32-bit hosts, either.
4843 * keyboard.c (read_char):
4844 * lread.c (Fload): Remove casts to unsigned.
4846 * lisp.h (UNSIGNED_CMP): New macro.
4847 This fixes comparison bugs on 64-bit hosts.
4848 (ASCII_CHAR_P): Use it.
4849 * casefiddle.c (casify_object):
4850 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4851 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4852 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4853 * dispextern.h (FACE_FROM_ID):
4854 * keyboard.c (read_char): Use UNSIGNED_CMP.
4856 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4857 not to EMACS_INT, to avoid GCC warning.
4859 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4861 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4862 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4863 isn't needed on 32-bit machines.
4865 * buffer.c (Fgenerate_new_buffer_name):
4866 Use EMACS_INT for count, not int.
4867 (advance_to_char_boundary): Return EMACS_INT, not int.
4869 * data.c (Qcompiled_function): Now static.
4871 * window.c (window_body_lines): Now static.
4873 * image.c (gif_load): Rename local to avoid shadowing.
4875 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4876 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4877 * alloc.c (make_save_value): Integer argument is now of type
4879 (mark_object): Use ptrdiff_t, not int.
4880 * lisp.h (pD): New macro.
4881 * print.c (print_object): Use it.
4883 * alloc.c: Use EMACS_INT, not int, to count objects.
4884 (total_conses, total_markers, total_symbols, total_vector_size)
4885 (total_free_conses, total_free_markers, total_free_symbols)
4886 (total_free_floats, total_floats, total_free_intervals)
4887 (total_intervals, total_strings, total_free_strings):
4888 Now EMACS_INT, not int. All uses changed.
4889 (Fgarbage_collect): Compute overall total using a double, so that
4890 integer overflow is less likely to be a problem. Check for overflow
4891 when converting back to an integer.
4892 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4893 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4894 These were 'int' variables that could overflow on 64-bit hosts;
4895 they were never used, so remove them instead of repairing them.
4896 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4897 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4898 Previously, this ceilinged at INT_MAX, but that doesn't work on
4900 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4902 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4903 (allocate_vectorlike): Check for ptrdiff_t overflow.
4904 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4905 when a (possibly-narrower) signed value would do just as well.
4906 We prefer using signed arithmetic, to avoid comparison confusion.
4908 * alloc.c: Catch some string size overflows that we were missing.
4909 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4910 for convenience in STRING_BYTES_MAX.
4911 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4912 The definition here is exact; the one in lisp.h was approximate.
4913 (allocate_string_data): Check for string overflow. This catches
4914 some instances we weren't catching before. Also, it catches
4915 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4916 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4917 and ptrdiff_t and EMACS_INT are both 64 bits.
4919 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4920 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4921 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4923 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4925 * alloc.c (Fmake_string): Check for out-of-range init.
4927 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4929 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4931 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4933 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4934 xg_get_default_scrollbar_width.
4936 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4937 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4938 (style_changed_cb): Call update_theme_scrollbar_width and call
4939 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4940 all frames (Bug#8505).
4941 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4942 Call gtk_window_set_resizable if HAVE_GTK3.
4943 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4944 and height if HAVE_GTK3 (Bug#8505).
4945 (scroll_bar_width_for_theme): New variable.
4946 (update_theme_scrollbar_width): New function.
4947 (xg_get_default_scrollbar_width): Move code to
4948 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4949 (xg_initialize): Call update_theme_scrollbar_width.
4951 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4953 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4955 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4957 * frame.c (make_frame): Call other_buffer_safely instead of
4960 * window.c (temp_output_buffer_show): Call display_buffer with
4961 second argument Vtemp_buffer_show_specifiers and reset latter
4962 immediately after the call.
4963 (Vtemp_buffer_show_specifiers): New variable.
4964 (auto_window_vscroll_p, next_screen_context_lines)
4965 (Vscroll_preserve_screen_position): Remove leading asterisks from
4968 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4970 Fix minor problems found by GCC 4.6.0 static checking.
4971 * buffer.c (Qclone_number): Remove for now, as it's unused.
4972 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4973 (record_buffer): Remove unused local.
4974 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4975 (set_frame_buffer_list): Remove; unused.
4976 * frame.h (other_visible_frames): Remove decl.
4977 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4978 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4979 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4981 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4982 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4983 Define only if HAVE_GPM.
4984 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4985 (update_hints_inhibit): Remove; never set. All uses removed.
4986 * widgetprv.h (emacsFrameClassRec): Remove decl.
4987 * window.c (delete_deletable_window): Now returns void, since it
4988 wasn't returning anything.
4989 (compare_window_configurations): Remove unused locals.
4990 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4991 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4992 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4993 the same widths as pointers. This follows up on the 2011-05-06 patch.
4994 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4995 * xterm.h: Likewise.
4996 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4998 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5000 * makefile.w32-in: Update dependencies.
5001 (LISP_H): Add lib/intprops.h.
5003 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5005 * image.c (gif_load): Add animation frame delay to the metadata.
5006 (syms_of_image): Use DEFSYM. New symbol `delay'.
5008 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5010 * window.c (delete_deletable_window): Re-add.
5011 (Fset_window_configuration): Rewrite to handle dead buffers and
5012 consequently deletable windows.
5013 (window_tree, Fwindow_tree): Remove. Supply functionality in
5015 (compare_window_configurations): Simplify code.
5017 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5019 * image.c (imagemagick_load_image): Fix type mismatch.
5020 (Fimagemagick_types): Likewise.
5022 * window.h (replace_buffer_in_windows): Declare.
5024 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5026 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5027 Qclone_number. Remove external declaration of Qdelete_window.
5028 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5030 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5031 Run Qbuffer_list_update_hook if allowed.
5032 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5033 buffer list implementation.
5034 (other_buffer_safely): New function.
5035 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5036 calls to replace_buffer_in_windows and
5037 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5039 (record_buffer): Inhibit quitting and rewrite using quittable
5040 functions. Run Qbuffer_list_update_hook if allowed.
5041 (Frecord_buffer, Funrecord_buffer): New functions.
5042 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5043 Move switch-to-buffer to window.el.
5044 (bury-buffer): Move to window.el.
5045 (Vbuffer_list_update_hook): New variable.
5047 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5050 * window.h (resize_frame_windows): Move up in code.
5051 (Fwindow_frame): Remove EXFUN.
5052 (replace_buffer_in_all_windows): Remove prototype.
5053 (replace_buffer_in_windows_safely): Add prototype.
5055 * window.c: Declare Qdelete_window static again. Move down
5056 declaration of select_count.
5057 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5058 (Fother_window): Move to window.el.
5059 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5060 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5061 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5063 (replace_buffer_in_windows): Implement by calling
5064 Qreplace_buffer_in_windows.
5065 (replace_buffer_in_all_windows): Remove with some functionality
5066 moved into replace_buffer_in_windows_safely.
5067 (replace_buffer_in_windows_safely): New function.
5068 (select_window_norecord, select_frame_norecord): Move in front
5069 of run_window_configuration_change_hook. Remove now obsolete
5071 (Fset_window_buffer): Rewrite doc-string.
5072 Call Qrecord_window_buffer.
5073 (keys_of_window): Move binding for other-window to window.el.
5075 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5077 * dispextern.h (struct image): Replace data member, whose int_val
5078 and ptr_val fields were not used by anything, with a single
5081 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5082 (gif_clear_image, gif_load, imagemagick_load_image)
5083 (gs_clear_image, gs_load): Callers changed.
5085 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5087 * buffer.h: Include <time.h>, for time_t.
5088 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5090 Fix minor problems found by static checking.
5092 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5094 Make identifiers static if they are not used in other modules.
5095 * data.c (Qcompiled_function, Qframe, Qvector):
5096 * image.c (QimageMagick, Qsvg):
5097 * minibuf.c (Qmetadata):
5098 * window.c (resize_window_check, resize_root_window): Now static.
5099 * window.h (resize_window_check, resize_root_window): Remove decls.
5101 * window.c (window_deletion_count, delete_deletable_window):
5103 (window_body_lines): Now static.
5104 (Fdelete_other_windows_internal): Mark vars as initialized.
5105 Make sure 'resize_failed' is initialized.
5106 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5107 (resize_window_apply): Remove unused local.
5108 * window.h (delete_deletable_window): Remove decl.
5110 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5111 (imagemagick_load_image): Fix pointer signedness problem by changing
5112 last arg from unsigned char * to char *. All uses changed.
5113 Also, fix a local for similar reasons.
5114 Remove unused locals. Remove locals to avoid shadowing.
5115 (fn_rsvg_handle_free): Remove; unused.
5116 (svg_load, svg_load_image): Fix pointer signedness problem.
5117 (imagemagick_load_image): Don't use garbage pointer image_wand.
5119 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5121 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5123 * image.c (gif_load): Fix omitted cast error introduced by
5126 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5128 * window.h (resize_proportionally, orig_total_lines)
5129 (orig_top_line): Remove from window structure.
5130 (set_window_height, set_window_width, change_window_heights)
5131 (Fdelete_window): Remove prototypes.
5132 (resize_frame_windows): Remove duplicate declaration.
5134 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5136 * window.h (resize_frame_windows, resize_window_check)
5137 (delete_deletable_window, resize_root_window)
5138 (resize_frame_windows): Declare prototypes.
5140 * window.c (resize_window_apply): Make definition be "static" to
5141 match the prototype.
5143 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5145 * window.c: Remove declarations of Qwindow_size_fixed,
5146 window_min_size_1, window_min_size_2, window_min_size,
5147 size_window, window_fixed_size_p, enlarge_window, delete_window.
5148 Remove static from declaration of Qdelete_window, it's
5149 temporarily needed by Fbury_buffer.
5150 (replace_window): Don't assign orig_top_line and
5152 (Fdelete_window, delete_window): Remove. Window deletion is
5153 handled by window.el.
5154 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5155 Replace Fdelete_window calls with calls to Qdelete_window.
5156 (Fdelete_other_windows): Remove. Deleting other windows is
5157 handled by window.el.
5158 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5159 handled in window.el.
5160 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5161 Window minimum sizes are handled in window.el.
5162 (shrink_windows, size_window, set_window_height)
5163 (set_window_width, change_window_heights, window_height)
5164 (window_width, CURBEG, CURSIZE, enlarge_window)
5165 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5166 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5167 handled in window.el.
5168 (make_dummy_parent): Rename to make_parent_window and give it a
5169 second argument horflag.
5170 (make_window): Don't set resize_proportionally any more.
5171 (Fsplit_window): Remove. Windows are split in window.el.
5172 (save_restore_action, save_restore_orig_size)
5173 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5174 Resize mini windows in window.el.
5175 (grow_mini_window, shrink_mini_window): Implement by calling
5176 Qresize_root_window_vertically, resize_window_check and
5177 resize_window_apply.
5178 (saved_window, Fset_window_configuration, save_window_save):
5179 Do not handle orig_top_line, orig_total_lines, and
5180 resize_proportionally.
5181 (window_min_height, window_min_width): Move to window.el.
5182 (keys_of_window): Move bindings for delete-other-windows,
5183 split-window, delete-window and enlarge-window to window.el.
5185 * buffer.c: Temporarily extern Qdelete_window.
5186 (Fbury_buffer): Temporarily call Qdelete_window instead of
5187 Fdelete_window (Fbury_buffer will move to window.el soon).
5189 * frame.c (set_menu_bar_lines_1): Remove code handling
5190 orig_top_line and orig_total_lines.
5192 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5193 set_window_height but set heights directly.
5194 (change_frame_size_1): Use resize_frame_windows.
5196 * xdisp.c (init_xdisp): Don't use set_window_height but set
5199 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5200 Use resize_frame_windows instead of change_window_heights and run
5201 run_window_configuration_change_hook.
5203 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5204 instead of change_window_heights and run
5205 run_window_configuration_change_hook.
5207 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5209 * window.c (replace_window): Rename second argument REPLACEMENT to
5210 NEW. New third argument SETFLAG. Rewrite.
5211 (delete_window, make_dummy_parent): Call replace_window with
5213 (window_list_1): Move down in code.
5214 (run_window_configuration_change_hook): Move set_buffer part
5215 before select_frame_norecord part in order to unwind correctly.
5216 Rename count1 to count.
5217 (recombine_windows, delete_deletable_window, resize_root_window)
5218 (Fdelete_other_windows_internal)
5219 (Frun_window_configuration_change_hook, make_parent_window)
5220 (resize_window_check, resize_window_apply, Fresize_window_apply)
5221 (resize_frame_windows, Fsplit_window_internal)
5222 (Fdelete_window_internal, Fresize_mini_window_internal):
5224 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5226 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5228 * window.h (window): Add some new members to window structure -
5229 normal_lines, normal_cols, new_total, new_normal, clone_number,
5230 splits, nest, prev_buffers, next_buffers.
5231 (WINDOW_TOTAL_SIZE): Move here from window.c.
5232 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5234 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5236 (make_dummy_parent): Set new members of windows structure.
5237 (make_window): Move down in code. Handle new members of window
5239 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5240 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5241 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5242 (Fset_window_prev_buffers, Fwindow_next_buffers)
5243 (Fset_window_next_buffers, Fset_window_clone_number):
5245 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5246 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5248 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5249 Argument WINDOW can be now internal window too.
5250 (Fwindow_use_time): Move up in code.
5251 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5253 (Fset_window_configuration, saved_window)
5254 (Fcurrent_window_configuration, save_window_save): Handle new
5255 members of window structure.
5256 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5257 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5258 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5259 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5260 Qget_mru_window, Qresize_root_window,
5261 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5262 Qauto_buffer_name; staticpro them.
5264 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5266 * window.c (Fwindow_total_size, Fwindow_left_column)
5267 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5268 (Fwindow_list_1): New functions.
5269 (window_box_text_cols): Replace with window_body_cols.
5270 (Fwindow_width, Fscroll_left, Fscroll_right):
5271 Use window_body_cols instead of window_box_text_cols.
5272 (delete_window, Fset_window_configuration):
5273 Call delete_all_subwindows with window as argument.
5274 (delete_all_subwindows): Take a window as argument and not a
5276 (window_loop): Remove handling of GET_LRU_WINDOW and
5278 (Fget_lru_window, Fget_largest_window): Move to window.el.
5280 * window.h: Extern window_body_cols instead of
5281 window_box_text_cols. delete_all_subwindows now takes a
5282 Lisp_Object as argument.
5284 * indent.c (compute_motion, Fcompute_motion):
5285 Use window_body_cols instead of window_box_text_cols.
5287 * frame.c (delete_frame): Call delete_all_subwindows with root
5290 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5292 * fns.c (Fputhash): Document return value.
5294 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5296 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5298 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5300 Cons<->int and similar integer overflow fixes (Bug#8794).
5302 Check for overflow when converting integer to cons and back.
5303 * charset.c (Fdefine_charset_internal, Fdecode_char):
5304 Use cons_to_unsigned to catch overflow.
5305 (Fencode_char): Use INTEGER_TO_CONS.
5306 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5307 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5308 * data.c (long_to_cons, cons_to_long): Remove.
5309 (cons_to_unsigned, cons_to_signed): New functions.
5310 These signal an error for invalid or out-of-range values.
5311 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5312 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5313 * font.c (Ffont_variation_glyphs):
5314 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5315 * lisp.h: Include <intprops.h>.
5316 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5317 (cons_to_signed, cons_to_unsigned): New decls.
5318 (long_to_cons, cons_to_long): Remove decls.
5319 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5320 (Fprimitive_undo): Use CONS_TO_INTEGER.
5321 * xfns.c (Fx_window_property): Likewise.
5322 * xselect.c: Include <limits.h>.
5323 (x_own_selection, selection_data_to_lisp_data):
5324 Use INTEGER_TO_CONS.
5325 (x_handle_selection_request, x_handle_selection_clear)
5326 (x_get_foreign_selection, Fx_disown_selection_internal)
5327 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5328 (lisp_data_to_selection_data): Use cons_to_unsigned.
5329 (x_fill_property_data): Use cons_to_signed.
5330 Report values out of range.
5332 Check for buffer and string overflow more precisely.
5333 * buffer.h (BUF_BYTES_MAX): New macro.
5334 * lisp.h (STRING_BYTES_MAX): New macro.
5335 * alloc.c (Fmake_string):
5336 * character.c (string_escape_byte8):
5337 * coding.c (coding_alloc_by_realloc):
5338 * doprnt.c (doprnt):
5339 * editfns.c (Fformat):
5341 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5342 since they may not be the same number.
5343 * editfns.c (Finsert_char):
5344 * fileio.c (Finsert_file_contents):
5345 Likewise for BUF_BYTES_MAX.
5347 * image.c: Use ptrdiff_t, not int, for sizes.
5348 (slurp_file): Switch from int to ptrdiff_t.
5350 (slurp_file): Check that file size fits in both size_t (for
5351 malloc) and ptrdiff_t (for sanity and safety).
5353 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5354 if b->modtime has its maximal value.
5356 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5358 Don't assume time_t can fit into int.
5359 * buffer.h (struct buffer.modtime): Now time_t, not int.
5360 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5361 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5363 Minor fixes for signed vs unsigned integers.
5364 * character.h (MAYBE_UNIFY_CHAR):
5365 * charset.c (maybe_unify_char):
5366 * keyboard.c (read_char, reorder_modifiers):
5367 XINT -> XFASTINT, since the integer must be nonnegative.
5368 * ftfont.c (ftfont_spec_pattern):
5369 * keymap.c (access_keymap, silly_event_symbol_error):
5370 XUINT -> XFASTINT, since the integer must be nonnegative.
5371 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5372 since it makes no difference and we prefer signed.
5373 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5374 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5377 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5379 * window.h (Fwindow_frame): Declare.
5381 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5383 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5384 (SPARE_MEMORY): Always define.
5385 (LARGE_REQUEST): Remove.
5386 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5388 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5390 * lisp.h: Move EXFUNS for Fframe_root_window,
5391 Fframe_first_window and Fset_frame_selected_window to window.h.
5393 * window.h: Move EXFUNS for Fframe_root_window,
5394 Fframe_first_window and Fset_frame_selected_window here from
5397 * frame.c (Fwindow_frame, Fframe_first_window)
5398 (Fframe_root_window, Fframe_selected_window)
5399 (Fset_frame_selected_window): Move to window.c.
5400 (Factive_minibuffer_window): Move to minibuf.c.
5401 (Fother_visible_frames_p): New function.
5403 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5405 * window.c (decode_window, decode_any_window): Move up in code.
5406 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5407 (inhibit_frame_unsplittable): Remove unused variable.
5408 (Fwindow_buffer): Move up and rewrite doc-string.
5409 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5410 (Fwindow_prev): New functions.
5411 (Fwindow_frame): Move here from frame.c. Accept any window as
5413 (Fframe_root_window, Fframe_first_window)
5414 (Fframe_selected_window): Move here from frame.c. Accept frame
5415 or arbitrary window as argument. Update doc-strings.
5416 (Fminibuffer_window): Move up in code.
5417 (Fwindow_minibuffer_p): Move up in code and simplify.
5418 (Fset_frame_selected_window): Move here from frame.c.
5420 (Fselected_window, select_window, Fselect_window): Move up in
5421 code. Minor doc-string fixes.
5423 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5425 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5426 Do not assume that spare memory exists; that assumption is valid
5427 only if SYSTEM_MALLOC.
5428 (LARGE_REQUEST): New macro, so that the issue of large requests
5429 is separated from the issue of spare memory.
5431 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5433 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5436 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5438 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5441 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5443 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5445 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5447 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5448 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5450 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5452 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5454 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5456 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5457 (x_clipboard_manager_save): Add return value.
5458 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5460 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5461 Obey Vx_select_enable_clipboard_manager. Catch errors in
5462 x_clipboard_manager_save (Bug#8779).
5463 (Vx_select_enable_clipboard_manager): New variable.
5464 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5466 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5468 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5470 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5472 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5473 in the current matrix if keep_current_p is non-zero.
5475 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5477 * bidi.c (bidi_level_of_next_char): Fix last change.
5479 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5481 Support bidi reordering of text covered by display properties.
5483 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5484 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5485 (bidi_cache_search, bidi_cache_iterator_state)
5486 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5487 (bidi_level_of_next_char, bidi_move_to_visually_next):
5488 Support character positions inside a run of characters covered by a
5490 (bidi_paragraph_init, bidi_resolve_explicit_1)
5491 (bidi_level_of_next_char): Call bidi_fetch_char and
5492 bidi_fetch_char_advance instead of FETCH_CHAR and
5494 (bidi_init_it): Initialize new members.
5495 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5497 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5498 instead of using explicit *_CHAR codes.
5499 (bidi_resolve_explicit, bidi_resolve_weak):
5500 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5501 bidirectional text is supported only in multibyte buffers.
5502 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5503 it to initialize the frame_window_p member of struct bidi_it.
5504 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5505 (bidi_resolve_explicit, bidi_resolve_weak)
5506 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5507 bidi_it->nchars is non-positive.
5508 (bidi_level_of_next_char): Don't try to lookup the cache for the
5509 next/previous character if nothing is cached there yet, or if we
5510 were just reseat()'ed to a new position.
5512 * xdisp.c (set_cursor_from_row): Set start and stop points
5513 according to the row's direction when priming the loop that looks
5514 for the glyph on which to display cursor.
5515 (single_display_spec_intangible_p): Function deleted.
5516 (display_prop_intangible_p): Reimplement to call
5517 handle_display_spec instead of single_display_spec_intangible_p.
5518 Accept 3 additional arguments needed by handle_display_spec.
5519 This fixes incorrect cursor motion across display property with complex
5520 values: lists, `(when COND...)' forms, etc.
5521 (single_display_spec_string_p): Support property values that are
5522 lists with the argument STRING its top-level element.
5523 (display_prop_string_p): Fix the condition for processing a
5524 property that is a list to be consistent with handle_display_spec.
5525 (handle_display_spec): New function, refactored from the
5526 last portion of handle_display_prop.
5527 (compute_display_string_pos): Accept additional argument
5528 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5529 value of a `display' property is a "replacing spec".
5530 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5531 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5532 the display property, but just return a value indicating whether
5533 the display property will replace the characters it covers.
5534 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5535 frame_window_p members of struct bidi_it.
5536 (compute_display_string_pos, compute_display_string_end):
5538 (push_it): Accept second argument POSITION, where pop_it should
5539 jump to continue iteration.
5540 (reseat_1): Initialize bidi_it.disp_pos.
5542 * keyboard.c (adjust_point_for_property): Adjust the call to
5543 display_prop_intangible_p to its new signature.
5545 * dispextern.h (struct bidi_it): New member frame_window_p.
5546 (bidi_init_it): Update prototypes.
5547 (display_prop_intangible_p): Update prototype.
5548 (compute_display_string_pos, compute_display_string_end):
5550 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5553 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5555 Malloc failure behavior now depends on size of allocation.
5556 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5557 * lisp.h: Change signatures accordingly.
5558 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5559 All callers changed. (Bug#8762)
5561 * gnutls.c: Use Emacs's memory allocators.
5562 Without this change, the gnutls library would invoke malloc etc.
5563 directly, which causes problems on non-SYNC_INPUT hosts, and which
5564 runs afoul of improving memory_full behavior. (Bug#8761)
5565 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5566 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5567 xfree instead of the default malloc, realloc, free.
5568 (Fgnutls_boot): No need to check for memory allocation failure,
5569 since xmalloc does that for us.
5571 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5572 * category.c (hash_get_category_set):
5573 * ccl.c (ccl_driver):
5574 * charset.c (Fdefine_charset_internal):
5575 * charset.h (struct charset.hash_index):
5576 * composite.c (get_composition_id, gstring_lookup_cache)
5577 (composition_gstring_put_cache):
5578 * composite.h (struct composition.hash_index):
5579 * dispextern.h (struct image.hash):
5580 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5581 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5582 (hashfn_equal, hashfn_user_defined, make_hash_table)
5583 (maybe_resize_hash_table, hash_lookup, hash_put)
5584 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5585 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5586 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5587 * image.c (make_image, search_image_cache, lookup_image)
5588 (xpm_put_color_table_h):
5589 * lisp.h (struct Lisp_Hash_Table):
5590 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5591 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5592 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5593 * alloc.c (allocate_vectorlike):
5594 Check for overflow in vector size calculations.
5595 * ccl.c (ccl_driver):
5596 Check for overflow when converting EMACS_INT to int.
5597 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5598 need to be updated by these changes.
5599 * fns.c (make_hash_table, maybe_resize_hash_table):
5600 Check for integer overflow with large hash tables.
5601 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5602 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5603 (SXHASH_REDUCE): New macro.
5604 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5605 Use it instead of discarding useful hash info with large hash values.
5606 (sxhash_float): New function.
5607 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5608 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5609 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5610 Rewrite to use FIXNUM_BITS, as this simplifies things.
5611 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5612 Adjust signatures to match updated version of code.
5613 (consing_since_gc): Now EMACS_INT, since a single hash table can
5614 use more than INT_MAX bytes.
5616 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5618 Make it possible to build with GCC-4.6+ -O2 -flto.
5620 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5622 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5624 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5625 Call minibuffer-inactive-mode.
5627 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5629 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5630 Update dependencies.
5632 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5634 * data.c (init_data): Remove code for UTS, this system is not
5637 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5639 Don't force ./temacs to start in terminal mode.
5641 * frame.c (make_initial_frame): Initialize faces in all cases, not
5642 only when CANNOT_DUMP is defined.
5643 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5645 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5647 * dispnew.c (add_window_display_history): Use const for the string
5648 pointer. Remove declaration, not needed.
5650 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5652 Use 'inline', not 'INLINE'.
5653 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5654 * alloc.c, fontset.c (INLINE): Remove.
5655 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5656 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5657 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5658 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5659 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5661 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5663 Make it possible to run ./temacs.
5665 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5666 syms_of_callproc does the same thing. Remove test for
5667 "initialized", do it in the caller.
5668 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5670 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5672 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5673 (read_minibuf): Use get_minibuffer.
5674 (syms_of_minibuf): Use DEFSYM.
5675 (Qmetadata): New var.
5676 * data.c (Qbuffer): Don't make it static.
5677 (syms_of_data): Use DEFSYM.
5679 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5681 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5682 (CCL_CODE_MIN): New macro.
5684 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5686 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5688 * eval.c (Qdebug): Now static.
5689 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5690 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5691 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5693 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5695 * image.c: Various fixes to ImageMagick code comments.
5696 (Fimagemagick_types): Doc fix.
5698 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5700 Minor fixes prompted by GCC 4.6.0 warnings.
5702 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5704 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5705 (x_clipboard_manager_save_all): Move extern decl to ...
5706 * xterm.h: ... here, so that it can be checked for consistency.
5708 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5710 * xselect.c (x_clipboard_manager_save_frame)
5711 (x_clipboard_manager_save_all): New functions.
5712 (Fx_clipboard_manager_save): Lisp function deleted.
5714 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5715 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5717 * xterm.h: Update prototype.
5719 2011-05-28 William Xu <william.xwl@gmail.com>
5721 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5724 2011-05-28 Jim Meyering <meyering@redhat.com>
5726 Avoid a sign-extension bug in crypto_hash_function.
5727 * fns.c (to_uchar): Define.
5728 (crypto_hash_function): Use it to convert some newly-signed
5729 variables to unsigned, to avoid sign-extension bugs. For example,
5730 without this change, (md5 "truc") would evaluate to
5731 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5732 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5733 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5735 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5737 Integer overflow fixes.
5739 * dbusbind.c: Serial number integer overflow fixes.
5740 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5741 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5742 to hold a serial number that is too large for a fixnum.
5743 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5744 Check for serial numbers out of range. Decode any serial number
5745 that was so large that it became a float. (Bug#8722)
5747 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5748 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5749 Use XFASTINT rather than XUINT when numbers are nonnegative.
5750 (xd_append_arg, Fdbus_method_return_internal):
5751 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5752 arguments, check that Lisp number is nonnegative, rather than
5753 silently wrapping negative numbers around. (Bug#8722)
5754 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5757 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5759 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5761 ccl: Add integer overflow checks.
5762 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5763 (IN_INT_RANGE): New macros.
5764 (ccl_driver): Use them to check for integer overflow when
5765 decoding a CCL program. Many of the new checks are whether XINT (x)
5766 fits in int; it doesn't always, on 64-bit hosts. The new version
5767 doesn't catch all possible integer overflows, but it's an
5768 improvement. (Bug#8719)
5770 * alloc.c (make_event_array): Use XINT, not XUINT.
5771 There's no need for unsigned here.
5773 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5774 This follows up to the 2011-05-06 change that substituted uintptr_t
5775 for EMACS_INT. This case wasn't caught back then.
5777 Rework Fformat to avoid integer overflow issues.
5778 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5779 now (part of C89). Include <verify.h>.
5780 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5781 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5782 (Fformat): Avoid the prepass trying to compute sizes; it was only
5783 approximate and thus did not catch overflow reliably. Instead, walk
5784 through the format just once, formatting and computing sizes as we go,
5785 checking for integer overflow at every step, and allocating a larger
5786 buffer as needed. Keep track separately whether the format is
5787 multibyte. Keep only the most-recently calculated precision, rather
5788 than them all. Record whether each argument has been converted to
5789 string. Use EMACS_INT, not int, for byte and char and arg counts.
5790 Support field widths and precisions larger than INT_MAX. Avoid
5791 sprintf's undefined behavior with conversion specifications such as %#d
5792 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5793 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5794 formatting out-of-range floating point numbers with int
5797 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5799 * data.c: Avoid integer truncation in expressions involving floats.
5800 * data.c: Include <intprops.h>.
5801 (arith_driver): When there's an integer overflow in an expression
5802 involving floating point, convert the integers to floating point
5803 so that the resulting value does not suffer from catastrophic
5804 integer truncation. For example, on a 64-bit host (* 4
5805 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5806 Do not rely on undefined behavior after integer overflow.
5808 merge count_size_as_multibyte, parse_str_to_multibyte
5809 * character.c, character.h (count_size_as_multibyte):
5810 Rename from parse_str_to_multibyte; all uses changed.
5811 Check for integer overflow.
5812 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5813 since it's now a duplicate of the other. This is more of
5814 a character than a buffer op, so better that it's in character.c.
5815 * fns.c, print.c: Adjust to above changes.
5817 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5819 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5821 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5823 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5824 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5825 (x_clipboard_manager_save): Now static.
5826 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5828 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5829 (crypto_hash_function): Now static.
5830 Fix pointer signedness problems. Avoid unnecessary initializations.
5832 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5834 * termhooks.h (Vselection_alist): Make it terminal-local.
5836 * terminal.c (create_terminal): Initialize it.
5838 * xselect.c: Support for clipboard managers.
5839 (Vselection_alist): Move to termhooks.h as terminal-local var.
5840 (LOCAL_SELECTION): New macro.
5841 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5842 (symbol_to_x_atom): Remove gratuitous arg.
5843 (x_handle_selection_request, lisp_data_to_selection_data)
5844 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5845 (x_own_selection, x_get_local_selection, x_convert_selection):
5846 New arg, specifying work frame. Use terminal-local Vselection_alist.
5847 (some_frame_on_display): Delete unused function.
5848 (Fx_own_selection_internal, Fx_get_selection_internal)
5849 (Fx_disown_selection_internal, Fx_selection_owner_p)
5850 (Fx_selection_exists_p): New optional frame arg.
5851 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5852 (x_handle_selection_clear): Don't treat other terminals with the
5853 same keyboard specially. Use the terminal-local Vselection_alist.
5854 (x_clear_frame_selections): Use Frun_hook_with_args.
5856 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5858 * xterm.h: Add support for those atoms.
5860 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5862 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5863 (converted_selections, conversion_fail_tag): New global variables.
5864 (x_selection_request_lisp_error): Free the above.
5865 (x_get_local_selection): Remove unnecessary code.
5866 (x_reply_selection_request): Args changed; handle arbitrary array
5867 of converted selections stored in converted_selections.
5868 Separate the XChangeProperty and SelectionNotify steps.
5869 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5870 (x_convert_selection): New function.
5871 (x_handle_selection_event): Simplify.
5872 (x_get_foreign_selection): Don't ignore incoming requests while
5873 waiting for an answer; this will fail when we implement
5874 SAVE_TARGETS, and seems unnecessary anyway.
5875 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5876 (Vx_sent_selection_functions): Doc fix.
5878 2011-05-26 Leo Liu <sdl.web@gmail.com>
5880 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5882 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5884 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5886 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5887 for fringe update if it has periodic bitmap.
5888 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5889 and fringe_bitmap_periodic_p.
5891 * fringe.c (get_fringe_bitmap_data): New function.
5892 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5893 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5894 row. Mark glyph row for fringe update if periodicity changed.
5896 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5897 for fringe update unless it has periodic bitmap.
5899 2011-05-25 Kenichi Handa <handa@m17n.org>
5901 * xdisp.c (get_next_display_element): Set correct it->face_id for
5902 a static composition.
5904 2011-05-24 Leo Liu <sdl.web@gmail.com>
5907 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5909 * fns.c (crypto_hash_function, Fsha1): New function.
5910 (Fmd5): Use crypto_hash_function.
5911 (syms_of_fns): Add Ssha1.
5913 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5915 * gnutls.c: Remove unused macros.
5916 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5917 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5918 Remove macros that are defined and never used.
5919 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5921 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5923 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5924 (Fx_get_selection_internal): Minor cleanup.
5925 (Fx_own_selection_internal): Rename arguments for consistency with
5928 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5930 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5932 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5934 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5936 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5938 * dispnew.c (scrolling_window): Don't exclude the case that the
5939 last enabled row in the desired matrix touches the bottom boundary.
5941 2011-05-21 Glenn Morris <rgm@gnu.org>
5943 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5944 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5945 and add some more files.
5947 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5949 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5950 report_file_error introduced by the change from 2011-05-07.
5952 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5954 * systime.h (Time): Define only if emacs is defined.
5955 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5956 where the include path doesn't have X11/X.h by default. See
5957 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5959 2011-05-20 Kenichi Handa <handa@m17n.org>
5961 * composite.c (find_automatic_composition): Fix previous change.
5963 2011-05-20 Glenn Morris <rgm@gnu.org>
5965 * lisp.mk: New file, split from Makefile.in.
5966 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5967 (shortlisp): Remove.
5968 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5970 2011-05-19 Glenn Morris <rgm@gnu.org>
5972 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5973 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5974 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5975 (lisp): Set the order to that of loadup.el.
5976 (shortlisp): Make it a copy of $lisp.
5977 (SOME_MACHINE_LISP): Remove.
5978 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5979 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5981 2011-05-18 Kenichi Handa <handa@m17n.org>
5983 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5984 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5985 (find_automatic_composition): Mostly rewrite for efficiency.
5987 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5989 * makefile.w32-in: Update dependencies.
5991 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5993 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5994 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5996 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5998 Fix some integer overflow issues, such as string length overflow.
6000 * insdel.c (count_size_as_multibyte): Check for string overflow.
6002 * character.c (lisp_string_width): Check for string overflow.
6003 Use EMACS_INT, not int, for string indexes and lengths; in
6004 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6005 the resulting string length overflows an EMACS_INT; instead,
6006 report a string overflow if no precision given. When checking for
6007 precision exhaustion, use a check that cannot possibly have
6008 integer overflow. (Bug#8675)
6009 * character.h (lisp_string_width): Adjust to new signature.
6011 * alloc.c (string_overflow): New function.
6012 (Fmake_string): Use it. This doesn't change behavior, but saves
6013 a few bytes and will simplify future changes.
6014 * character.c (string_escape_byte8): Likewise.
6015 * lisp.h (string_overflow): New decl.
6017 Fixups, following up to the user-interface timestamp change.
6018 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6019 for UI timestamps, instead of unsigned long.
6020 * msdos.c (mouse_get_pos): Likewise.
6021 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6022 * w32gui.h (Time): Define by including "systime.h" rather than by
6023 declaring it ourselves. (Bug#8664)
6025 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6026 * image.c (clear_image_cache): Likewise.
6028 * term.c (term_mouse_position): Don't assume time_t wraparound.
6030 Be more systematic about user-interface timestamps.
6031 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6032 and sometimes 'EMACS_UINT', to represent these timestamps.
6033 This change causes it to use 'Time' uniformly, as that's what X uses.
6034 This makes the code easier to follow, and makes it easier to catch
6035 integer overflow bugs such as Bug#8664.
6036 * frame.c (Fmouse_position, Fmouse_pixel_position):
6037 Use Time, not unsigned long, for user-interface timestamps.
6038 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6039 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6040 * keyboard.h (last_event_timestamp): Likewise.
6041 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6042 * menu.h (xmenu_show): Likewise.
6043 * term.c (term_mouse_position): Likewise.
6044 * termhooks.h (struct input_event.timestamp): Likewise.
6045 (struct terminal.mouse_position_hook): Likewise.
6046 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6047 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6048 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6049 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6051 * menu.h, termhooks.h: Include "systime.h", for Time.
6053 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6054 Don't assume that the difference between two unsigned long values
6055 can fit into an integer. At this point, we know button_down_time
6056 <= event->timestamp, so the difference must be nonnegative, so
6057 there's no need to cast the result if double-click-time is
6058 nonnegative, as it should be; check that it's nonnegative, just in
6059 case. This bug is triggered when events are more than 2**31 ms
6060 apart (about 25 days). (Bug#8664)
6062 * xselect.c (last_event_timestamp): Remove duplicate decl.
6063 (x_own_selection): Remove needless cast to unsigned long.
6065 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6066 that always fit in int. Use a sentinel instead of a counter, to
6067 avoid a temp and to allay GCC's concerns about possible int overflow.
6068 * frame.h (struct frame): Use int for menu_bar_items_used
6069 instead of EMACS_INT, since it always fits in int.
6071 * menu.c (grow_menu_items): Check for int overflow.
6073 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6075 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6076 Before, the code was not consistent. These values cannot exceed
6077 2**31 - 1 so there's no need to make them unsigned.
6078 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6079 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6080 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6082 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6084 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6085 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6086 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6087 presumably because the widths might not match.
6089 * window.c (size_window): Avoid needless test at loop start.
6091 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6093 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6095 2011-05-12 Drew Adams <drew.adams@oracle.com>
6097 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6099 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6101 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6102 `width' to `bar_area_x' and `bar_area_width', respectively.
6103 (x_scroll_run): Take account of fringe background extension.
6105 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6106 Rename local vars `left' and `width' to `bar_area_x' and
6107 `bar_area_width', respectively.
6108 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6109 background extension.
6111 2011-05-10 Jim Meyering <meyering@redhat.com>
6113 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6115 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6117 * image.c (Finit_image_library): Return t for built-in image types,
6118 like pbm and xbm. (Bug#8640)
6120 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6122 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6124 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6126 * w32console.c (Fset_screen_color): Doc fix.
6127 (Fget_screen_color): New function.
6128 (syms_of_ntterm): Defsubr it.
6130 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6131 unlink the temporary file if Fcall_process didn't create it in the
6133 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6134 child process will be redirected to a file specified with `:file'.
6135 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6136 cue to call_process_cleanup not to close that handle.
6138 2011-05-07 Ben Key <bkey76@gmail.com>
6140 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6141 one of two shell specific rules, either bootstrap-temacs-CMD or
6142 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6143 to the previous implementation of the bootstrap-temacs rule.
6144 The bootstrap-temacs-CMD rule is similar to the previous
6145 implementation of the bootstrap-temacs rule except that it
6146 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6149 These changes, along with some changes to nt/configure.bat,
6150 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6151 earlier fix to add support for --cflags and --ldflags options
6152 that include quotes so that it works whether make uses cmd or
6155 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6157 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6158 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6160 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6161 a string. Handle both cases.
6162 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6163 (Fdbus_register_method): Use Qinvalid_function.
6165 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6167 * makefile.w32-in: Update dependencies.
6168 (LISP_H): Add inttypes.h and stdin.h.
6169 (PROCESS_H): Add unistd.h.
6171 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6173 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6174 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6176 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6178 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6180 * term.c (vfatal): Remove stray call to va_end.
6181 It's not needed and the C Standard doesn't allow it here anyway.
6183 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6184 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6186 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6189 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6191 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6193 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6195 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6197 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6199 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6200 * charset.c (Fdefine_charset_internal): Don't initialize
6201 charset.code_space[15]. The value was garbage, on hosts with
6202 32-bit int (Bug#8600).
6204 * lread.c (read_integer): Be more consistent with string-to-number.
6205 Use string_to_number to do the actual conversion; this avoids
6206 rounding errors and fixes some other screwups. Without this fix,
6207 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6208 (digit_to_number): Move earlier, for benefit of read_integer.
6209 Return -1 if the digit is out of range for the base, -2 if it is
6210 not a digit in any supported base. (Bug#8602)
6212 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6214 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6215 to match comment at start of function. This also removes a
6216 GCC warning about overflow in a 32+64-bit port.
6218 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6220 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6221 Reported by Stefan Monnier in
6222 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6223 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6224 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6226 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6227 (EMACS_UINTPTR): Likewise, with uintptr_t.
6229 * lisp.h: Prefer 64-bit EMACS_INT if available.
6230 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6231 on 32-bit hosts that have 64-bit int, so that they can access
6233 However, temporarily disable this change unless the temporary
6234 symbol WIDE_EMACS_INT is defined.
6236 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6238 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6239 This removes an assumption that EMACS_INT and long are the same
6240 width as pointers. The assumption is true for Emacs porting targets
6241 now, but we want to make other targets possible.
6242 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6243 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6244 In the rest of the code, change types of integers that hold casted
6245 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6246 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6247 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6248 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6249 No need to cast type when ORing.
6250 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6251 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6252 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6253 assume EMACS_INT is the same width as char *.
6254 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6255 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6256 Remove no-longer-needed casts.
6257 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6258 (xg_tool_bar_help_callback, xg_make_tool_item):
6259 Use EMACS_INTPTR to hold an integer
6260 that will be cast to void *; this can avoid a GCC warning
6261 if EMACS_INT is not the same width as void *.
6262 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6263 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6264 (current_message_1, set_message_1):
6265 Use a local to convert to proper width without a cast.
6266 * xmenu.c (dialog_selection_callback): Likewise.
6268 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6269 Also, don't assume VALBITS / RAND_BITS is less than 5,
6270 and don't rely on undefined behavior when shifting a 1 left into
6272 * lisp.h (get_random): Change signature to match.
6274 * lread.c (hash_string): Use size_t, not int, for hash computation.
6275 Normally we prefer signed values; but hashing is special, because
6276 it's better to use unsigned division on hash table sizes so that
6277 the remainder is nonnegative. Also, size_t is the natural width
6278 for hashing into memory. The previous code used 'int', which doesn't
6279 retain enough info to hash well into very large tables.
6280 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6282 * dbusbind.c: Don't possibly lose pointer info when converting.
6283 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6284 Use XPNTR rather than XHASH, so that the high-order bits of
6285 the pointer aren't lost when converting through void *.
6287 * eval.c (Fautoload): Don't double-shift a pointer.
6289 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6291 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6293 * gnutls.c (DEF_GNUTLS_FN):
6294 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6296 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6298 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6301 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6303 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6304 New version that can reserve upto 2GB of heap space.
6306 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6308 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6310 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6312 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6313 `gnutls_certificate_set_x509_key_file'.
6315 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6317 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6318 Update dependencies.
6320 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6322 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6323 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6324 Remove unused parameter `fildes'.
6325 * process.c (read_process_output, send_process): Don't pass it.
6327 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6329 Fix previous change: the library cache is defined in w32.c.
6330 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6331 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6333 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6335 Implement dynamic loading of GnuTLS on Windows.
6337 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6338 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6339 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6342 * gnutls.c (Qgnutls_dll): Define.
6343 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6344 (gnutls_*): Declare function pointers.
6345 (init_gnutls_functions): New function to initialize function pointers.
6346 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6347 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6348 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6349 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6350 (emacs_gnutls_write, emacs_gnutls_read)
6351 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6352 (Fgnutls_available_p): New function.
6353 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6354 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6355 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6357 * image.c: Include w32.h.
6358 (Vimage_type_cache): Delete.
6359 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6360 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6361 (w32_delayed_load): Move to w32.c.
6363 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6365 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6366 (w32_delayed_load): Move from image.c. When loading a library, record
6367 its filename in the :loaded-from property of the library id.
6368 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6369 Initialize and staticpro them.
6370 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6372 * process.c: Include lisp.h before w32.h, not after.
6373 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6374 instead of gnutls_record_check_pending.
6376 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6378 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6380 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6381 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6384 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6386 * xterm.c (x_set_frame_alpha): Do not set property on anything
6387 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6389 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6391 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6393 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6395 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6396 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6397 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6398 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6399 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6400 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6401 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6402 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6403 (Qgnutls_bootprop_callbacks_verify): Make static.
6405 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6407 * callproc.c: Indentation fixup.
6409 * sysdep.c (wait_for_termination_1): Make static.
6410 (wait_for_termination, interruptible_wait_for_termination):
6411 Move after wait_for_termination_1.
6413 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6415 * sysdep.c (interruptible_wait_for_termination): New function
6416 which is like wait_for_termination, but allows keyboard
6419 * callproc.c (Fcall_process): Add (:file "file") as an option for
6421 (Fcall_process_region): Ditto.
6423 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6425 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6426 rather than `XVECTOR (FOO)->size'.
6428 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6429 inttypes.h, as a gnulib replacement is used if it not available in
6432 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6434 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6435 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6436 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6438 * coding.c (coding_alloc_by_realloc): Error out if destination
6439 will grow beyond MOST_POSITIVE_FIXNUM.
6440 (decode_coding_emacs_mule): Abort if there isn't enough place in
6441 charbuf for the composition carryover bytes. Reserve an extra
6442 space for up to 2 characters produced in a loop.
6443 (decode_coding_iso_2022): Abort if there isn't enough place in
6444 charbuf for the composition carryover bytes.
6446 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6448 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6449 aborting when %lld or %lll format is passed.
6450 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6451 %llo or %llx format is passed. (Bug#8545)
6453 * window.c (window_scroll_line_based): Use a marker instead of
6454 simple variables to record original value of point. (Bug#7952)
6456 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6457 produced by %s or %c overflows available buffer space. (Bug#8545)
6459 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6461 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6462 (SIZE_MAX): Move defn after all includes, as they might #define it.
6464 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6466 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6468 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6470 * keyboard.c (Qdelayed_warnings_hook): Define.
6471 (command_loop_1): Run `delayed-warnings-hook'
6472 if Vdelayed_warnings_list is non-nil.
6473 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6474 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6476 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6478 * doprnt.c (doprnt): Don't return value smaller than the buffer
6479 size if the message was truncated. (Bug#8545).
6481 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6483 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6484 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6486 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6488 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6490 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6492 * makefile.w32-in: Update dependencies.
6494 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6496 Improve `doprnt' and its usage. (Bug#8545)
6497 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6498 `format_end'. Remove support for %l as a conversion specifier.
6499 Don't use xrealloc. Improve diagnostics when the %l size modifier
6500 is used. Update the commentary.
6502 * eval.c (verror): Simplify calculation of size_t.
6504 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6507 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6509 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6512 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6514 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6515 This makes this file independent of the recent pseudovector change.
6517 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6519 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6521 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6522 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6523 Remove unused local.
6524 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6526 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6527 GCC 4.6.0 optimizes based on type-based alias analysis.
6528 For example, if b is of type struct buffer * and v of type struct
6529 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6530 != &v->size, and therefore "v->size = 1; b->size = 2; return
6531 v->size;" must therefore return 1. This assumption is incorrect
6532 for Emacs, since it type-puns struct Lisp_Vector * with many other
6533 types. To fix this problem, this patch adds a new type struct
6534 vectorlike_header that documents the constraints on layout of vectors
6535 and pseudovectors, and helps optimizing compilers not get fooled
6536 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6537 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6538 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6540 (XSETPVECTYPE): Rewrite in terms of new macro.
6541 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6542 This is a bit clearer, and further avoids the possibility of
6543 undesirable aliasing.
6544 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6545 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6546 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6547 since Lisp_Subr is a special case (no "next" field).
6548 (ASIZE): Now uses header.size rather than size.
6549 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6550 to avoid the hassle of writing XVECTOR (foo)->header.size.
6551 (struct vectorlike_header): New type.
6552 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6553 object, to help avoid aliasing.
6554 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6555 (SUBRP): Likewise, since Lisp_Subr is a special case.
6556 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6557 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6558 (struct Lisp_Hash_Table): Combine first two members into a single
6559 struct vectorlike_header member. All uses of "size" and "next" members
6560 changed to be "header.size" and "header.next".
6561 * buffer.h (struct buffer): Likewise.
6562 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6563 * frame.h (struct frame): Likewise.
6564 * process.h (struct Lisp_Process): Likewise.
6565 * termhooks.h (struct terminal): Likewise.
6566 * window.c (struct save_window_data, struct saved_window): Likewise.
6567 * window.h (struct window): Likewise.
6568 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6569 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6570 * buffer.c (init_buffer_once): Likewise.
6571 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6573 * process.c (Fformat_network_address): Use local var for size,
6576 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6578 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6579 * data.c (atof): Remove decl; no longer used or needed.
6580 (digit_to_number): Move to lread.c.
6581 (Fstring_to_number): Use new string_to_number function, to be
6582 consistent with how the Lisp reader treats infinities and NaNs.
6583 Do not assume that floating-point numbers represent EMACS_INT
6584 without losing information; this is not true on most 64-bit hosts.
6585 Avoid double-rounding errors, by insisting on integers when
6586 parsing non-base-10 numbers, as the documentation specifies.
6587 * lisp.h (string_to_number): New decl, replacing ...
6588 (isfloat_string): Remove.
6589 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6590 (read1): Do not accept +. and -. as integers; this
6591 appears to have been a coding error. Similarly, do not accept
6592 strings like +-1e0 as floating point numbers. Do not report
6593 overflow for integer overflows unless the base is not 10 which
6594 means we have no simple and reliable way to continue.
6595 Break out the floating-point parsing into a new
6596 function string_to_number, so that Fstring_to_number parses
6597 floating point numbers consistently with the Lisp reader.
6598 (digit_to_number): Move here from data.c. Make it static inline.
6599 (E_CHAR, EXP_INT): Remove, replacing with ...
6600 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6601 (string_to_number): New function, replacing isfloat_string.
6602 This function checks for valid syntax and produces the resulting
6603 Lisp float number too. Rework it so that string-to-number
6604 no longer mishandles examples like "1.0e+". Use strtoumax,
6605 so that overflow for non-base-10 numbers is reported only when
6606 there's no portable and simple way to convert to floating point.
6608 * textprop.c (set_text_properties_1): Rewrite for clarity,
6609 and to avoid GCC warning about integer overflow.
6611 * intervals.h (struct interval): Use EMACS_INT for members
6612 where EMACS_UINT might cause problems. See
6613 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6614 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6615 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6617 (offset_intervals): Tell GCC not to worry about length overflow
6618 when negating a negative length.
6620 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6621 (overrun_check_free): Likewise.
6623 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6624 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6627 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6628 (gnutls_make_error): Rename local to avoid shadowing.
6629 (gnutls_emacs_global_deinit): ifdef out; not used.
6630 (Fgnutls_boot): Use const for pointer to readonly storage.
6631 Comment out unused local. Fix pointer signedness problems.
6633 * lread.c (openp): Don't stuff size_t into an 'int'.
6634 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6635 about possible signed overflow.
6637 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6638 (GDK_KEY_g): Don't define if already defined.
6639 (xg_prepare_tooltip): Avoid pointer signedness problem.
6640 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6642 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6643 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6645 * xfns.c (Fx_window_property): Simplify a bit,
6646 to make a bit faster and to avoid GCC 4.6.0 warning.
6647 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6649 * fns.c (internal_equal): Don't assume size_t fits in int.
6651 * alloc.c (compact_small_strings): Tighten assertion a little.
6653 Replace pEd with more-general pI, and fix some printf arg casts.
6654 * lisp.h (pI): New macro, generalizing old pEd macro to other
6655 conversion specifiers. For example, use "...%"pI"d..." rather
6656 than "...%"pEd"...".
6657 (pEd): Remove. All uses replaced with similar uses of pI.
6658 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6659 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6660 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6661 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6662 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6663 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6664 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6666 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6667 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6668 * print.c (safe_debug_print, print_object): Likewise.
6669 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6671 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6672 avoiding the 0 flag, which is not portable.
6673 * process.c (Fmake_network_process): Use pI to avoid cast.
6674 * region-cache.c (pp_cache): Likewise.
6675 * xdisp.c (decode_mode_spec): Likewise.
6676 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6677 behavior on 64-bit hosts with printf arg.
6678 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6679 (x_stop_queuing_selection_requests): Likewise.
6680 (x_get_window_property): Don't truncate byte count to an 'int'
6683 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6684 here, since it parses constructs like leading '-' and spaces,
6685 which are not wanted; and it overflows with large numbers.
6686 Instead, simply match F[0-9]+, which is what is wanted anyway.
6688 * alloc.c: Remove unportable assumptions about struct layout.
6689 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6690 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6691 (allocate_vectorlike, make_pure_vector): Use the new macros,
6692 plus offsetof, to remove unportable assumptions about struct layout.
6693 These assumptions hold on all porting targets that I know of, but
6694 they are not guaranteed, they're easy to remove, and removing them
6695 makes further changes easier.
6697 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6698 This doesn't fix a bug but makes the code clearer.
6699 (string_overrun_cookie): Now const. Use initializers that
6700 don't formally overflow signed char, to avoid warnings.
6701 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6702 can cause Emacs to crash when string overrun checking is enabled.
6703 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6704 multiple of sizeof (EMACS_INT); it need not be, if
6705 alignof(EMACS_INT) < sizeof (EMACS_INT).
6706 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6708 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6710 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6712 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6714 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6715 supposed to be handshaking. (Bug#8556)
6716 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6718 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6720 * lisp.h (Qdebug): List symbol.
6721 * eval.c (Qdebug): Restore global linkage.
6722 * keyboard.c (debug-on-event): New variable.
6723 (handle_user_signal): Break into debugger when debug-on-event
6724 matches the current signal symbol.
6726 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6728 * alloc.c (check_sblock, check_string_bytes)
6729 (check_string_free_list): Convert to standard C.
6731 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6733 * w32.c (emacs_gnutls_push): Fix typo.
6735 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6737 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6738 "cast to pointer from integer of different size".
6740 Improve doprnt and its use in verror. (Bug#8545)
6741 * doprnt.c (doprnt): Document the set of format control sequences
6742 supported by the function. Use SAFE_ALLOCA instead of always
6745 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6746 is one byte too soon. Don't use xrealloc; instead xfree and
6749 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6751 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6754 * gnutls.c: Renamed global_initialized to
6755 gnutls_global_initialized. Added internals for the
6756 :verify-hostname-error, :verify-error, and :verify-flags
6757 parameters of `gnutls-boot' and documented those parameters in the
6758 docstring. Start callback support.
6759 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6760 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6761 on error. Return error code.
6762 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6763 (emacs_gnutls_read): Likewise.
6764 (Fgnutls_boot): Return handshake error code.
6765 (emacs_gnutls_handle_error): New function.
6766 (wsaerror_to_errno): Likewise.
6768 * w32.h (emacs_gnutls_pull): Add prototype.
6769 (emacs_gnutls_push): Likewise.
6771 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6772 (emacs_gnutls_push): Likewise.
6774 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6776 * process.c (wait_reading_process_output): Check if GnuTLS
6777 buffered some data internally if no FDs are set for TLS
6780 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6781 (LIBS): Link to USER_LIBS.
6782 ($(BLD)/gnutls.$(0)): New target.
6784 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6786 * xdisp.c (handle_single_display_spec): Rename the
6787 display_replaced_before_p argument into display_replaced_p, to
6788 make it consistent with the commentary. Fix typos in the
6791 * textprop.c (syms_of_textprop): Remove dead code.
6792 (copy_text_properties): Delete obsolete commentary about an
6793 interface that was deleted long ago. Fix typos in the description
6796 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6797 to changes in oldXMenu/XMenu.h from 2011-04-16.
6798 <menu_help_message, prev_menu_help_message>: Constify.
6799 (IT_menu_make_room): menu->help_text is now `const char **';
6802 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6803 to changes in oldXMenu/XMenu.h from 2011-04-16.
6804 (struct XMenu): Declare `help_text' `const char **'.
6806 * xfaces.c <Qunspecified>: Make extern again.
6808 * syntax.c: Include sys/types.h before including regex.h, as
6811 * doc.c (get_doc_string): Improve the format passed to `error'.
6813 * doprnt.c (doprnt): Improve commentary.
6815 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6817 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6820 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6821 changes in globals.h immediately force recompilation.
6822 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6823 $(CURDIR)/s/ms-w32.h.
6824 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6826 * character.c (Fchar_direction): Function deleted.
6827 (syms_of_character): Don't defsubr it.
6828 <char-direction-table>: Deleted.
6830 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6832 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6833 * doprnt.c: Include limits.h.
6834 (SIZE_MAX): New macro.
6835 (doprnt): Return a size_t value. 2nd arg is now size_t.
6836 Many local variables are now size_t instead of int or unsigned.
6837 Improve overflow protection. Support `l' modifier for integer
6838 conversions. Support %l conversion. Don't assume an EMACS_INT
6839 argument for integer conversions and for %c.
6841 * lisp.h (doprnt): Restore prototype.
6843 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6846 * Makefile.in (base_obj): Add back doprnt.o.
6848 * deps.mk (doprnt.o): Add back prerequisites.
6849 (callint.o): Depend on character.h.
6851 * eval.c (internal_lisp_condition_case): Include the handler
6852 representation in the error message.
6853 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6854 when breaking from the loop.
6856 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6858 * callint.c (Fcall_interactively): When displaying error message
6859 about invalid control letter, pass the character's codepoint, not
6860 a pointer to its multibyte form. Improve display of the character
6861 in octal and display also its hex code.
6863 * character.c (char_string): Use %x to display the (unsigned)
6864 codepoint of an invalid character, to avoid displaying a bogus
6867 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6868 `error', not SYMBOL_NAME itself.
6870 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6871 character arguments to `error'.
6873 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6874 to `error' in error message about FINAL_CHAR argument. Make sure
6875 FINAL_CHAR is a character, and use %c when it is passed as
6876 argument to `error'.
6878 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6880 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6882 * w32.c: Include <time.h>.
6883 (sys_localtime): New function.
6885 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6887 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6889 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6891 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6893 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6896 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6898 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6899 gl_state.e_property when gl_state.object is Qt.
6901 * insdel.c (make_gap_larger): Remove limitation of buffer size
6904 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6906 * xdisp.c (lookup_glyphless_char_display)
6907 (produce_glyphless_glyph): Handle cons cell entry in
6908 glyphless-char-display.
6909 (Vglyphless_char_display): Document it.
6911 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6912 glyphless-char-display.
6914 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6916 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6918 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6920 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6921 definition for no-X builds.
6923 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6925 Static checks with GCC 4.6.0 and non-default toolkits.
6927 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6929 * process.c (keyboard_bit_set): Define only if SIGIO.
6930 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6931 (send_process): Repair possible setjmp clobbering.
6933 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6935 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6937 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6939 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6940 Define only if needed.
6942 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6943 by pacifying GCC about it. Maybe it's time to retire it?
6944 * xfaces.c (USG, __TIMEVAL__): Likewise.
6946 * dispextern.h (struct redisplay_interface): Rename param
6948 * termhooks.h (struct terminal): Likewise.
6949 * xterm.c (xembed_send_message): Likewise.
6951 * insdel.c (make_gap_smaller): Define only if
6952 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6954 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6957 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6958 so that we aren't warned about unused symbols.
6960 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6962 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6964 * xfns.c (x_real_positions): Mark locals as initialized.
6966 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6968 * xterm.c: Fix problems found by static analysis with other toolkits.
6969 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6970 (x_dispatch_event): Declare static if USE_GTK, and
6971 define if USE_GTK || USE_X_TOOLKIT.
6972 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6973 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6974 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6975 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6977 * xmenu.c (menu_help_callback): Pointer type fixes.
6978 Use const pointers when pointing at readonly data. Avoid pointer
6980 (FALSE): Remove unused macro.
6981 (update_frame_menubar): Remove unused decl.
6983 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6985 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6986 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6987 (single_menu_item): Rename local to avoid shadowing.
6989 * keyboard.c (make_lispy_event): Remove unused local var.
6991 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6992 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6994 * bitmaps: Change bitmaps from unsigned char back to the X11
6995 compatible char. Avoid the old compiler warnings about
6996 out-of-range initializers by using, for example, '\xab' rather
6999 * xgselect.c (xgselect_initialize): Check vs interface
7000 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7002 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7004 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7005 to read-only memory.
7007 * fns.c (vector): Remove; this old hack is no longer needed.
7009 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7011 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7013 * xrdb.c (x_load_resources): Omit unused local.
7015 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7016 (x_window): Rename locals to avoid shadowing.
7017 (USG): Use the kludged USG macro, to pacify gcc.
7019 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7020 (x_term_init): Remove local to avoid shadowing.
7022 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7024 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7025 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7027 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7029 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7031 Fix regex.c, syntax.c and friends for buffers > 2GB.
7032 * syntax.h (struct gl_state_s): Declare character position members
7035 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7037 * textprop.c (verify_interval_modification, interval_of):
7038 Declare arguments EMACS_INT.
7040 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7043 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7045 * indent.c (Fvertical_motion): Local variable it_start is now
7048 * regex.c (re_match, re_match_2, re_match_2_internal)
7049 (bcmp_translate, regcomp, regexec, print_double_string)
7050 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7051 (re_compile_pattern, re_exec): Declare arguments and local
7052 variables `size_t' and `ssize_t' and return values `regoff_t', as
7054 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7055 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7056 <compile_stack_type>: `size' and `avail' are now `size_t'.
7058 * regex.h <regoff_t>: Use ssize_t, not int.
7059 (re_search, re_search_2, re_match, re_match_2): Arguments that
7060 specify buffer/string position and length are now ssize_t and
7061 size_t. Return type is regoff_t.
7063 2011-04-16 Ben Key <bkey76@gmail.com>
7065 * nsfont.m: Fixed bugs in ns_get_family and
7066 ns_descriptor_to_entity that were caused by using free to
7067 deallocate memory blocks that were allocated by xmalloc (via
7068 xstrdup). This caused Emacs to crash when compiled with
7069 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7070 --enable-checking=xmallocoverrun). xfree is now used to
7071 deallocate these memory blocks.
7073 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7075 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7077 emacs_write: Accept and return EMACS_INT for sizes.
7078 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7080 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7081 Accept and return EMACS_INT.
7082 (emacs_gnutls_write): Return the number of bytes written on
7084 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7085 (emacs_read, emacs_write): Remove check for negative size, as the
7086 Emacs source code has been audited now.
7087 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7088 (emacs_read, emacs_write): Use it.
7089 * process.c (send_process): Adjust to the new signatures of
7090 emacs_write and emacs_gnutls_write. Do not attempt to store
7091 a byte offset into an 'int'; it might overflow.
7092 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7094 * sound.c: Don't assume sizes fit in 'int'.
7095 (struct sound_device.period_size, alsa_period_size):
7096 Return EMACS_INT, not int.
7097 (struct sound_device.write, vox_write, alsa_write):
7098 Accept EMACS_INT, not int.
7099 (wav_play, au_play): Use EMACS_INT to store sizes and to
7100 record read return values.
7102 2011-04-15 Ben Key <bkey76@gmail.com>
7104 * keyboard.c (Qundefined): Don't declare static since it is used
7106 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7107 static since they are used in nsfont.m.
7109 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7111 * process.c (Qprocessp): Don't declare static.
7112 * lisp.h (Qprocessp): Declare again.
7114 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7116 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7118 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7120 Improve C-level modularity by making more things 'static'.
7122 Don't publish debugger-only interfaces to other modules.
7123 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7124 (verify_bytepos, count_markers): Move decls to the only modules
7126 * region-cache.h (pp_cache): Likewise.
7127 * window.h (check_all_windows): Likewise.
7128 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7130 * sysdep.c (croak): Now static, if
7131 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7132 * syssignal.h (croak): Declare only if not static.
7134 * alloc.c (refill_memory_reserve): Now static if
7135 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7136 * lisp.h (refill_memory_reserve): Declare only if not static.
7138 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7139 Define only if USE_LUCID.
7141 * xrdb.c (x_customization_string, x_rm_string): Now static.
7143 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7144 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7146 * xdisp.c (draw_row_with_mouse_face): Now static.
7147 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7149 * window.h (check_all_windows): Mark externally visible.
7151 * window.c (window_deletion_count): Now static.
7153 * undo.c: Make symbols static if they're not exported.
7154 (last_undo_buffer, last_boundary_position, pending_boundary):
7157 * textprop.c (interval_insert_behind_hooks): Now static.
7158 (interval_insert_in_front_hooks): Likewise.
7160 * term.c: Make symbols static if they're not exported.
7161 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7162 (max_frame_lines, tty_set_terminal_modes):
7163 (tty_reset_terminal_modes, tty_turn_off_highlight):
7164 (get_tty_terminal): Now static.
7165 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7166 * termhooks.h (term_mouse_moveto): Do not declare if
7168 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7169 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7171 * sysdep.c: Make symbols static if they're not exported.
7172 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7174 (sigprocmask_set, full_mask): Remove; unused.
7175 (wait_debugging): Mark as visible.
7176 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7177 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7179 * syntax.c (syntax_temp): Define only if !__GNUC__.
7181 * sound.c (current_sound_device, current_sound): Now static.
7183 * search.c (searchbufs, searchbuf_head): Now static.
7185 * scroll.c (scroll_cost): Remove; unused.
7186 * dispextern.h (scroll_cost): Remove decl.
7188 * region-cache.h (pp_cache): Mark as externally visible.
7190 * process.c: Make symbols static if they're not exported.
7191 (process_tick, update_tick, create_process, chan_process):
7192 (Vprocess_alist, proc_buffered_char, datagram_access):
7193 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7194 (deactivate_process): Mark defn as static, as well as decl.
7195 * lisp.h (create_process): Remove decl.
7196 * process.h (chan_process, Vprocess_alist): Remove decls.
7198 * print.c: Make symbols static if they're not exported.
7199 (print_depth, new_backquote_output, being_printed, print_buffer):
7200 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7201 (print_interval, print_number_index, initial_stderr_stream):
7203 * lisp.h (Fprinc): Remove decl.
7204 (debug_output_compilation_hack): Mark as externally visible.
7206 * sysdep.c (croak): Move decl from here to syssignal.h.
7207 * syssignal.h (croak): Put it here, so the API can be checked when
7208 'croak' is called from dissociate_if_controlling_tty.
7210 * minibuf.c: Make symbols static if they're not exported.
7211 (minibuf_save_list, choose_minibuf_frame): Now static.
7212 * lisp.h (choose_minibuf_frame): Remove decl.
7214 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7216 * lread.c: Make symbols static if they're not exported.
7217 (read_objects, initial_obarray, oblookup_last_bucket_number):
7219 (make_symbol): Remove; unused.
7220 * lisp.h (initial_obarray, make_symbol): Remove decls.
7222 * keyboard.c: Make symbols static if they're not exported.
7223 (single_kboard, recent_keys_index, total_keys, recent_keys):
7224 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7225 (this_single_command_key_start, echoing, last_auto_save):
7226 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7227 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7228 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7229 (Vlispy_mouse_stem, double_click_count):
7231 (force_auto_save_soon): Define only if SIGDANGER.
7232 (ignore_mouse_drag_p): Now static if
7233 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7234 (print_help): Remove; unused.
7235 (stop_character, last_timer_event): Mark as externally visible.
7236 * keyboard.h (ignore_mouse_drag_p): Declare only if
7237 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7238 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7239 * lisp.h (echoing): Remove decl.
7240 (force_auto_save_soon): Declare only if SIGDANGER.
7241 * xdisp.c (redisplay_window): Simplify code, to make it more
7242 obvious that ignore_mouse_drag_p is not accessed if !defined
7243 USE_GTK && !defined HAVE_NS.
7245 * intervals.c: Make symbols static if they're not exported.
7246 (merge_properties_sticky, merge_interval_right, delete_interval):
7248 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7250 * insdel.c: Make symbols static if they're not exported.
7251 However, leave prepare_to_modify_buffer alone. It's never
7252 called from outside this function, but that appears to be a bug.
7253 (combine_after_change_list, combine_after_change_buffer):
7254 (adjust_after_replace, signal_before_change): Now static.
7255 (adjust_after_replace_noundo): Remove; unused.
7256 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7257 (signal_before_change): Remove decls.
7259 * indent.c (val_compute_motion, val_vmotion): Now static.
7261 * image.c: Make symbols static if they're not exported.
7262 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7264 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7265 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7267 * fringe.c (standard_bitmaps): Now static.
7268 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7270 * frame.c: Make symbols static if they're not exported.
7271 (x_report_frame_params, make_terminal_frame): Now static.
7272 (get_frame_param): Now static, unless HAVE_NS.
7273 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7274 (x_get_resource_string): Remove; not used.
7275 * frame.h (make_terminal_frame, x_report_frame_params):
7276 (x_get_resource_string); Remove decls.
7277 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7278 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7280 * font.c, fontset.c: Make symbols static if they're not exported.
7281 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7282 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7283 * font.c (font_close_object): Now static.
7284 * font.h (font_close_object): Remove.
7285 * fontset.c (FONTSET_OBJLIST): Remove.
7286 (free_realized_fontset) #if-0 the body, which does nothing.
7287 (face_suitable_for_char_p): #if-0, as it's never called.
7288 * fontset.h (face_suitable_for_char_p): Remove decl.
7289 * xfaces.c (face_at_string_position):
7290 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7291 since 0 is always ASCII.
7293 * fns.c (weak_hash_tables): Now static.
7295 * fileio.c: Make symbols static if they're not exported.
7296 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7297 (Vwrite_region_annotation_buffers): Now static.
7299 * eval.c: Make symbols static if they're not exported.
7300 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7301 * lisp.h (backtrace_list): Remove decl.
7303 * emacs.c: Make symbols static if they're not exported.
7304 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7305 (fatal_error_code, fatal_error_signal_hook, standard_args):
7307 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7308 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7309 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7310 * lisp.h (fatal_error_signal_hook): Remove decl.
7311 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7313 * editfns.c: Move a (normally-unused) function to its only use.
7314 * editfns.c, lisp.h (get_operating_system_release): Remove.
7315 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7316 worth the hassle of breaking this out.
7318 * xterm.c: Make symbols static if they're not exported.
7319 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7320 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7321 (x_destroy_window, x_delete_display):
7323 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7324 (x_mouse_leave): Remove; unused.
7325 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7326 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7327 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7329 (x_mouse_leave): Declare only if WINDOWSNT.
7330 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7331 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7334 * ftxfont.c: Make symbols static if they're not exported.
7335 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7337 * font.h (ftxfont_driver): Likewise.
7339 * xfns.c: Make symbols static if they're not exported.
7340 (x_last_font_name, x_display_info_for_name):
7341 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7342 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7343 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7344 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7345 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7346 (last_show_tip_args): Now static.
7347 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7348 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7349 (x_screen_planes): Remove; unused.
7350 * dispextern.h (x_screen_planes): Remove decl.
7352 * dispnew.c: Make symbols static if they're not exported.
7353 * dispextern.h (redraw_garbaged_frames, scrolling):
7354 (increment_row_positions): Remove.
7355 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7356 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7358 (redraw_garbaged_frames): Remove; unused.
7360 * xfaces.c: Make symbols static if they're not exported.
7361 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7363 * xterm.h (defined_color): Remove decls.
7364 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7365 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7366 (menu_face_changed_default, defined_color, free_realized_face):
7367 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7368 (ascii_face_of_lisp_face): Remove; unused.
7370 * xdisp.c: Make symbols static if they're not exported.
7371 * dispextern.h (scratch_glyph_row, window_box_edges):
7372 (glyph_to_pixel_coords, set_cursor_from_row):
7373 (get_next_display_element, set_iterator_to_next):
7374 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7375 (show_mouse_face): Remove decls
7376 * frame.h (message_buf_print): Likewise.
7377 * lisp.h (pop_message, set_message, check_point_in_composition):
7379 * xterm.h (set_vertical_scroll_bar): Likewise.
7380 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7381 (message_buf_print, scratch_glyph_row, displayed_buffer):
7382 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7383 (get_next_display_element, show_mouse_face, window_box_edges):
7384 (frame_to_window_pixel_xy, check_point_in_composition):
7385 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7386 (glyph_to_pixel_coords): Remove; unused.
7388 * dired.c (file_name_completion): Now static.
7390 * dbusbind.c (xd_in_read_queued_messages): Now static.
7392 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7393 * data.c (circular_list_error): Remove.
7395 * commands.h (last_point_position, last_point_position_buffer):
7396 (last_point_position_window): Remove decls.
7397 * keyboard.c: Make these variables static.
7399 * coding.h (coding, code_convert_region, encode_coding_gap):
7401 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7402 (iso_code_class, detect_coding, code_convert_region): Now static.
7403 (encode_coding_gap): Remove; unused.
7405 * chartab.c (chartab_chars, chartab_bits): Now static.
7407 * charset.h (charset_iso_8859_1): Remove decl.
7408 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7411 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7412 * ccl.c (Vccl_program_table): Now static.
7413 (check_ccl_update): Remove; unused.
7415 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7416 * category.h: ... from here.
7417 * category.c (check_category_table, set_category_set): Now static.
7419 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7420 * lisp.h: Remove these decls.
7422 * buffer.c (buffer_count): Remove unused var.
7424 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7425 so that it's not optimized away.
7426 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7427 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7428 exported only to the debugger.
7430 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7431 * atimer.h (run_all_atimers): Remove; not exported.
7433 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7434 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7435 was inaccessible from Lisp.
7436 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7437 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7439 alloc.c: Import and export fewer symbols, and remove unused items.
7440 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7442 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7443 it's not optimized away by whole-program optimization.
7444 (message_enable_multibyte, free_misc): Remove.
7445 (catchlist, handlerlist, mark_backtrace):
7446 Declare only if BYTE_MARK_STACK.
7447 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7448 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7449 (message_enable_multibyte): Remove decl.
7450 (free_misc, interval_free_list, float_block, float_block_index):
7451 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7452 (cons_free_list, last_marked_index):
7454 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7455 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7456 (mark_backtrace): Define only if BYTE_MARK_STACK.
7457 * xdisp.c (message_enable_multibyte): Now static.
7459 Declare Lisp_Object Q* variables to be 'static' if not exported.
7460 This makes it easier for human readers (and static analyzers)
7461 to see whether these variables are used from other modules.
7462 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7463 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7464 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7465 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7466 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7467 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7468 * xmenu.c, xselect.c:
7469 Declare Q* vars static if they are not used in other modules.
7470 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7471 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7472 Remove decls of unexported vars.
7473 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7475 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7477 Make Emacs functions such as Fatom 'static' by default.
7478 This makes it easier for human readers (and static analyzers)
7479 to see whether these functions can be called from other modules.
7480 DEFUN now defines a static function. To make the function external
7481 so that it can be used in other C modules, use the new macro DEFUE.
7482 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7483 (Finit_image_library):
7484 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7485 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7486 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7487 Remove decls, since these functions are now static.
7488 (Funintern, Fget_internal_run_time): New decls, since these functions
7489 were already external.
7491 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7492 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7493 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7494 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7495 * keyboard.c, keymap.c, lread.c:
7496 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7497 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7498 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7499 Mark functions with DEFUE instead of DEFUN,
7500 if they are used in other modules.
7501 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7502 decls for now-static functions.
7503 * buffer.h (Fdelete_overlay): Remove decl.
7504 * callproc.c (Fgetenv_internal): Mark as internal.
7505 * composite.c (Fremove_list_of_text_properties): Remove decl.
7506 (Fcomposition_get_gstring): New forward static decl.
7507 * composite.h (Fcomposite_get_gstring): Remove decl.
7508 * dired.c (Ffile_attributes): New forward static decl.
7509 * doc.c (Fdocumntation_property): New forward static decl.
7510 * eval.c (Ffetch_bytecode): New forward static decl.
7511 (Funintern): Remove extern decl; now in .h file where it belongs.
7512 * fileio.c (Fmake_symbolic_link): New forward static decl.
7513 * image.c (Finit_image_library): New forward static decl.
7514 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7515 * intervals.h (Fprevious_property_change):
7516 (Fremove_list_of_text_properties): Remove decls.
7517 * keyboard.c (Fthis_command_keys): Remove decl.
7518 (Fcommand_execute): New forward static decl.
7519 * keymap.c (Flookup_key): New forward static decl.
7520 (Fcopy_keymap): Now static.
7521 * keymap.h (Flookup_key): Remove decl.
7522 * process.c (Fget_process): New forward static decl.
7523 (Fprocess_datagram_address): Mark as internal.
7524 * syntax.c (Fsyntax_table_p): New forward static decl.
7525 (skip_chars): Remove duplicate decl.
7526 * textprop.c (Fprevious_property_change): New forward static decl.
7527 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7529 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7530 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7532 * editfns.c (Fformat): Remove unreachable code.
7534 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7536 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7539 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7541 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7542 when at ZV. (Bug#8487)
7544 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7546 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7548 * keyboard.c (parse_tool_bar_item): Likewise.
7549 * sound.c (sound_cleanup, alsa_close): Likewise.
7550 * termcap.c (tgetent): Likewise.
7551 * xfns.c (x_default_font_parameter): Likewise.
7552 * xsettings.c (read_and_apply_settings): Likewise.
7554 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7555 (overrun_check_free): Protoize.
7557 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7559 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7560 since callers should never pass a negative size.
7561 Change the signature to match that of plain 'read' and 'write'; see
7562 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7563 * lisp.h: Update prototypes of emacs_write and emacs_read.
7565 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7567 * xdisp.c (redisplay_window): Don't try to determine the character
7568 position of the scroll margin if the window start point w->startp
7569 is outside the buffer's accessible region. (Bug#8468)
7571 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7573 Fix write-region and its subroutines for buffers > 2GB.
7574 * fileio.c (a_write, e_write): Modify declaration of arguments and
7575 local variables to support buffers larger than 2GB.
7576 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7578 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7579 argument, local variables, and return value.
7581 * lisp.h: Update prototypes of emacs_write and emacs_read.
7583 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7585 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7587 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7589 Fix more problems found by GCC 4.6.0's static checks.
7591 * xdisp.c (vmessage): Use a better test for character truncation.
7593 * charset.c (load_charset_map): <, not <=, for optimization,
7594 and to avoid potential problems with integer overflow.
7595 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7596 * casetab.c (set_identity, shuffle): Likewise.
7597 * editfns.c (Fformat): Likewise.
7598 * syntax.c (skip_chars): Likewise.
7600 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7601 This also lets GCC 4.6.0 generate slightly better loop code.
7603 * callint.c (Fcall_interactively): <, not <=, for optimization.
7604 (Fcall_interactively): Count the number of arguments produced,
7605 not the number of arguments given. This is simpler and lets GCC
7606 4.6.0 generate slightly better code.
7608 * ftfont.c: Distingish more carefully between FcChar8 and char.
7609 The previous code passed unsigned char * to a functions like
7610 strlen and xstrcasecmp that expect char *, which does not
7611 conform to the C standard.
7612 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7613 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7614 char * when the C standard requires it.
7616 * keyboard.c (read_char): Remove unused var.
7618 * eval.c: Port to Windows vsnprintf (Bug#8435).
7620 (SIZE_MAX): Define if the headers do not.
7621 (verror): Do not give up if vsnprintf returns a negative count.
7622 Instead, grow the buffer. This ports to Windows vsnprintf, which
7623 does not conform to C99. Problem reported by Eli Zaretskii.
7624 Also, simplify the allocation scheme, by avoiding the need for
7625 calling realloc, and removing the ALLOCATED variable.
7627 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7629 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7630 But keep the doprint source code for now, as we might revamp it
7631 and use it again (Bug#8435).
7632 * lisp.h (doprnt): Remove.
7633 * Makefile.in (base_obj): Remove doprnt.o.
7634 * deps.mk (doprnt.o): Remove.
7636 error: Print 32- and 64-bit integers portably (Bug#8435).
7637 Without this change, on typical 64-bit hosts error ("...%d...", N)
7638 was used to print both 32- and 64-bit integers N, which relied on
7640 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7642 * lisp.h (error, verror): Mark as printf-like functions.
7643 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7644 Report overflow in size calculations when allocating printf buffer.
7645 Do not truncate output string at its first null byte.
7646 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7647 Truncate the output at a character boundary, since vsnprintf does not
7649 * charset.c (check_iso_charset_parameter): Convert internal
7650 character to string before calling 'error', since %c now has the
7652 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7653 overflow when computing char to be passed to 'error'. Do not
7654 pass Lisp_Object to 'error'; pass the integer instead.
7655 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7656 formatted with plain %d.
7658 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7660 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7662 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7664 * xterm.c (x_catch_errors): Remove duplicate declaration.
7666 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7668 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7670 2011-04-10 Jim Meyering <meyering@redhat.com>
7672 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7673 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7674 return ssize_t not "int", and use size_t as the buffer length.
7675 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7676 * gnutls.h: Update declarations.
7677 * process.c (read_process_output): Use ssize_t, to match.
7678 (send_process): Likewise.
7680 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7682 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7684 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7686 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7687 Use unsigned char, to match FcChar8 type definition.
7689 * xterm.c (handle_one_xevent):
7690 * xmenu.c (create_and_show_popup_menu):
7691 * xselect.c (x_decline_selection_request)
7692 (x_reply_selection_request): Avoid type-punned deref of X events.
7694 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7696 Fix some uses of `int' instead of EMACS_INT.
7697 * search.c (string_match_1, fast_string_match)
7698 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7699 (scan_buffer, find_next_newline_no_quit)
7700 (find_before_next_newline, search_command, Freplace_match)
7701 (Fmatch_data): Make some `int' variables be EMACS_INT.
7703 * xdisp.c (display_count_lines): 3rd argument and return value now
7704 EMACS_INT. All callers changed.
7705 (pint2hrstr): Last argument is now EMACS_INT.
7707 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7708 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7709 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7710 (decode_coding_utf_16, decode_coding_emacs_mule)
7711 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7712 (decode_coding_ccl, decode_coding_charset)
7713 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7714 (decode_coding_iso_2022, decode_coding_emacs_mule)
7715 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7716 <char_offset, last_offset>: Declare EMACS_INT.
7717 (encode_coding_utf_8, encode_coding_utf_16)
7718 (encode_coding_emacs_mule, encode_invocation_designation)
7719 (encode_designation_at_bol, encode_coding_iso_2022)
7720 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7721 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7723 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7724 (encode_invocation_designation): Last argument P_NCHARS is now
7726 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7727 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7729 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7732 * ccl.c (Fccl_execute_on_string): Declare some variables
7735 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7737 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7739 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7741 * process.c (Fformat_network_address): Doc fix.
7743 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7745 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7747 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7749 * keyboard.c (read_char): Call Lisp function help-form-show,
7750 instead of using internal_with_output_to_temp_buffer.
7751 (Qhelp_form_show): New var.
7752 (syms_of_keyboard): Use DEFSYM macro.
7754 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7756 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7758 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7760 * process.c (Flist_processes): Remove to Lisp.
7761 (list_processes_1): Delete.
7763 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7765 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7767 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7769 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7771 Fix more problems found by GCC 4.6.0's static checks.
7773 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7775 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7777 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7779 * xdisp.c (vmessage): Mark as a printf-like function.
7781 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7783 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7785 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7786 printf-like functions.
7787 (tiff_load): Add casts to remove these marks before passing them
7788 to system-supplied API.
7790 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7792 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7793 This avoids several warnings with gcc -Wstrict-overflow.
7794 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7795 directly, rather than having caller test rule sign. This avoids
7796 some unnecessary tests.
7797 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7798 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7799 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7801 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7802 (xfont_open): Avoid unnecessary tests.
7804 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7806 * composite.h, composite.c (composition_gstring_put_cache):
7807 Use EMACS_INT, not int, for length.
7809 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7810 breaking out part of COMPOSITION_DECODE_RULE.
7811 (COMPOSITION_DECODE_RULE): Use it.
7812 * composite.c (get_composition_id): Remove unused local vars,
7813 by using the new macro.
7815 * textprop.c (set_text_properties_1): Change while to do-while,
7816 since the condition is always true at first.
7818 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7819 (interval_deletion_adjustment): Return unsigned value.
7822 * process.c (list_processes_1, create_pty, read_process_output):
7823 (exec_sentinel): Remove vars that were set but not used.
7824 (create_pty): Remove unnecessary "volatile"s.
7825 (Fnetwork_interface_info): Avoid possibility of int overflow.
7826 (read_process_output): Do adaptive read buffering even if carryover.
7827 (read_process_output): Simplify nbytes computation if buffered.
7829 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7831 * syntax.c (scan_words): Remove var that was set but not used.
7832 (update_syntax_table): Use unsigned instead of int.
7834 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7835 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7836 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7838 * print.c (print_error_message): Avoid int overflow.
7840 * font.c (font_list_entities): Redo for clarity,
7841 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7843 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7844 (font_score): Avoid potential overflow in diff calculation.
7846 * fns.c (substring_both): Remove var that is set but not used.
7847 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7849 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7851 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7852 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7853 can always succeed if overflow has undefined behavior.
7855 * search.c (boyer_moore, wordify): Remove vars set but not used.
7856 (wordify): Omit three unnecessary tests.
7858 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7859 All callers changed. This avoids the need for an unused var.
7861 * casefiddle.c (casify_region): Remove var that is set but not used.
7863 * dired.c (file_name_completion): Remove var that is set but not used.
7865 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7867 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7868 (Finsert_file_contents): Remove unnecessary code checking fd.
7870 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7871 Check for integer overflow on size calculations.
7873 * buffer.c (Fprevious_overlay_change): Remove var that is set
7876 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7877 Remove vars that are set but not used.
7878 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7879 (timer_check_2): Mark vars as initialized.
7881 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7883 * image.c (lookup_image): Remove var that is set but not used.
7884 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7886 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7887 that are set but not used.
7889 * xfns.c (make_invisible_cursor): Don't return garbage
7890 if XCreateBitmapFromData fails (Bug#8410).
7892 * xselect.c (x_get_local_selection, x_handle_property_notify):
7893 Remove vars that are set but not used.
7895 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7896 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7898 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7899 Remove var that is set but not used.
7900 (scroll_bar_windows_size): Now size_t, not int.
7901 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7904 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7905 (map_tty_color) [!defined MSDOS]: Likewise.
7907 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7909 * coding.c: Remove vars that are set but not used.
7910 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7911 All callers changed.
7912 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7913 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7914 (decode_coding_charset): Remove vars that are set but not used.
7916 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7917 that is set but not used.
7919 * print.c (print_object): Remove var that is set but not used.
7921 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7922 The gnulib version avoids calling malloc in the usual case,
7923 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7924 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7925 * filelock.c (current_lock_owner): Likewise.
7926 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7927 * sysdep.c: Include allocator.h, careadlinkat.h.
7928 (emacs_no_realloc_allocator): New static constant.
7929 (emacs_readlink): New function.
7930 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7931 ../lib/careadlinkat.h.
7933 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7935 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7936 first non-nil return value).
7938 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7940 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7941 if not defined (Bug#8403).
7943 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7945 * xdisp.c (display_count_lines): Remove parameter `start',
7946 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7947 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7948 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7949 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7950 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7951 and thereabouts. All callers changed.
7952 (get_per_char_metric): Remove parameter `f', unused since
7953 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7955 2011-04-02 Jim Meyering <meyering@redhat.com>
7957 do not dereference NULL upon failed strdup
7958 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7959 (ns_get_family): Likewise.
7961 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7963 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7965 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7967 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7970 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7972 Add lexical binding.
7974 * window.c (Ftemp_output_buffer_show): New fun.
7975 (Fsave_window_excursion):
7976 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7978 * lread.c (lisp_file_lexically_bound_p): New function.
7979 (Fload): Bind Qlexical_binding.
7980 (readevalloop): Remove `evalfun' arg.
7981 Bind Qinternal_interpreter_environment.
7982 (Feval_buffer): Bind Qlexical_binding.
7983 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7985 (syms_of_lread): Declare `lexical-binding'.
7987 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7989 * keyboard.c (eval_dyn): New fun.
7990 (menu_item_eval_property): Use it.
7992 * image.c (parse_image_spec): Use Ffunctionp.
7994 * fns.c (concat, mapcar1): Accept byte-code-functions.
7996 * eval.c (Fsetq): Handle lexical vars.
7997 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7998 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7999 (FletX, Flet): Obey lexical binding.
8000 (Fcommandp): Handle closures.
8001 (Feval): New `lexical' arg.
8002 (eval_sub): New function extracted from Feval. Use it almost
8003 everywhere where Feval was used. Look up vars in lexical env.
8005 (Ffunctionp): Move from subr.el.
8006 (Ffuncall): Handle closures.
8007 (apply_lambda): Remove `eval_flags'.
8008 (funcall_lambda): Handle closures and new byte-code-functions.
8009 (Fspecial_variable_p): New function.
8010 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8011 but without exporting it to Lisp.
8013 * doc.c (Fdocumentation, store_function_docstring):
8014 * data.c (Finteractive_form): Handle closures.
8016 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8019 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8021 (exec_byte_code): New function extracted from Fbyte_code to handle new
8022 calling convention for byte-code-functions. Add new byte-codes.
8024 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8026 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8028 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8030 * xdisp.c (redisplay_internal): Fix prototype.
8032 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8034 * xdisp.c (SCROLL_LIMIT): New macro.
8035 (try_scrolling): Use it when setting scroll_limit.
8036 Limit scrolling to 100 screen lines.
8037 (redisplay_window): Even when falling back on "recentering",
8038 position point in the window according to scroll-conservatively,
8039 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8041 (try_scrolling): When point is above the window, allow searching
8042 as far as scroll_max, or one screenful, to compute vertical
8043 distance from PT to the scroll margin position. This prevents
8044 try_scrolling from unnecessarily failing when
8045 scroll-conservatively is set to a value slightly larger than the
8046 window height. Clean up the case of PT below the margin at bottom
8047 of window: scroll_max can no longer be INT_MAX. When aggressive
8048 scrolling is in use, don't let point enter the opposite scroll
8049 margin as result of the scroll.
8050 (syms_of_xdisp) <scroll-conservatively>: Document the
8051 threshold of 100 lines for never-recentering scrolling.
8053 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8055 * dispextern.h (move_it_by_lines):
8056 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8057 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8058 (message_log_check_duplicate): Remove parameters `prev_bol' and
8059 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8060 (redisplay_internal): Remove parameter `preserve_echo_area',
8061 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8063 * indent.c (Fvertical_motion):
8064 * window.c (window_scroll_pixel_based, Frecenter):
8065 Don't pass `need_y_p' to `move_it_by_lines'.
8067 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8069 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8070 steal a few bits to be more compact.
8071 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8072 Remove unneeded casts.
8074 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8076 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8078 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8079 binding" message (bug#7967).
8081 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8083 Fix more problems found by GCC 4.6.0's static checks.
8085 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8086 Remove unused local var.
8088 * editfns.c (Fmessage_box): Remove unused local var.
8090 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8091 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8092 Omit unused local vars.
8093 * window.c (shrink_windows): Omit unused local var.
8094 * menu.c (digest_single_submenu): Omit unused local var.
8095 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8096 Omit unused local var.
8098 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8099 Don't assume string length fits in int.
8100 (keyremap_step, read_key_sequence): Use size_t for sizes.
8101 (read_key_sequence): Don't check last_real_key_start redundantly.
8103 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8104 instead of alloca (Bug#8344).
8106 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8107 (Fbacktrace_frame): Don't assume nframes fits in int.
8109 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8111 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8114 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8116 * cm.c (calccost): Turn while-do into do-while, for clarity.
8118 * keyboard.c (syms_of_keyboard): Use the same style as later
8119 in this function when indexing through an array. This also
8120 works around GCC bug 48267.
8122 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8124 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8126 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8127 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8129 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8130 This avoids undefined behavior on integer overflow, and is a bit
8131 more convenient anyway since it is compared to a size_t variable.
8133 Variadic C functions now count arguments with size_t, not int.
8134 This avoids an unnecessary limitation on 64-bit machines, which
8135 caused (substring ...) to crash on large vectors (Bug#8344).
8136 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8137 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8138 All variadic functions and their callers changed accordingly.
8139 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8140 * data.c (arith_driver, float_arith_driver): Likewise.
8141 * editfns.c (general_insert_function): Likewise.
8142 * eval.c (struct backtrace.nargs, interactive_p)
8143 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8144 (funcall_lambda, mark_backtrace): Likewise.
8145 * fns.c (concat): Likewise.
8146 * frame.c (x_set_frame_parameters): Likewise.
8147 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8148 0 if not found, not -1. All callers changed.
8150 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8151 (stack_copy_size): Now size_t, not int.
8152 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8154 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8156 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8157 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8158 All callers changed.
8160 * lisp.h (multibyte_char_to_unibyte):
8161 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8162 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8163 * character.h (CHAR_TO_BYTE8):
8164 * cmds.c (internal_self_insert):
8165 * editfns.c (general_insert_function):
8166 * keymap.c (push_key_description):
8167 * search.c (Freplace_match):
8168 * xdisp.c (message_dolog, set_message_1): All callers changed.
8170 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8172 * keyboard.c (safe_run_hook_funcall): New function.
8173 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8174 don't set the hook to nil, but remove the offending function instead.
8175 (Qcommand_hook_internal): Remove, unused.
8176 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8177 Vcommand_hook_internal.
8179 * eval.c (enum run_hooks_condition): Remove.
8180 (funcall_nil, funcall_not): New functions.
8181 (run_hook_with_args): Call each function through a `funcall' argument.
8182 Remove `cond' argument, now redundant.
8183 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8184 (Frun_hook_with_args_until_failure): Adjust accordingly.
8185 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8187 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8189 * dispextern.h (string_buffer_position): Remove declaration.
8191 * print.c (strout): Remove parameter `multibyte', unused since
8192 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8194 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8195 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8196 All callers changed.
8198 * w32.c (_wsa_errlist): Use braces for struct initializers.
8200 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8201 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8202 All callers changed.
8203 (string_buffer_position): Likewise. Also, make static (it's never
8204 used outside xdisp.c).
8205 (cursor_row_p): Remove parameter `w', unused since
8206 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8207 (decode_mode_spec): Remove parameter `precision', introduced during
8208 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8209 All callers changed.
8211 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8213 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8215 2011-03-27 Anders Lindgren <andlind@gmail.com>
8217 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8218 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8219 (ns_update_auto_hide_menu_bar): New functions.
8220 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8221 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8222 ns_constrain_all_frames.
8223 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8224 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8226 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8228 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8230 2011-03-27 Glenn Morris <rgm@gnu.org>
8232 * syssignal.h: Replace RETSIGTYPE with void.
8233 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8234 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8235 Replace SIGTYPE with void everywhere.
8236 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8237 * s/template.h (SIGTYPE): Remove commented out definition.
8239 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8241 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8242 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8244 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8246 * w32.c (read_unc_volume): Use parameter `henum', instead of
8247 global variable `wget_enum_handle'.
8249 * keymap.c (describe_vector): Remove parameters `indices' and
8250 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8251 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8253 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8255 * keyboard.c (timer_check): Remove parameter `do_it_now',
8256 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8257 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8258 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8260 * keyboard.c (read_char):
8261 * w32menu.c (w32_menu_display_help):
8262 * xmenu.c (show_help_event, menu_help_callback):
8263 Adjust calls to `show_help_echo'.
8265 * gtkutil.c (xg_maybe_add_timer):
8266 * keyboard.c (readable_events):
8267 * process.c (wait_reading_process_output):
8268 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8270 * insdel.c (adjust_markers_gap_motion):
8271 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8272 (gap_left, gap_right): Don't call it.
8274 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8276 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8277 incurred during fontification.
8279 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8281 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8282 (DEFVAR_PER_BUFFER): Don't pass it.
8284 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8285 (scrolling_window): Don't pass it.
8287 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8289 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8291 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8293 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8294 of variables specific to SELinux and computation of `encoded_absname'.
8296 * image.c (XPutPixel): Remove unused variable `height'.
8298 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8300 * unexw32.c (get_section_info): Remove unused variable `section'.
8302 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8303 (system_process_attributes): Remove unused variable `sess'.
8304 (sys_read): Remove unused variable `err'.
8306 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8307 (w32_wnd_proc): Remove unused variable `isdead'.
8308 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8309 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8310 (x_create_tip_frame): Remove unused variable `tem'.
8312 * w32inevt.c (w32_console_read_socket):
8313 Remove unused variable `no_events'.
8315 * w32term.c (x_draw_composite_glyph_string_foreground):
8316 Remove unused variable `width'.
8318 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8320 * w32term.c (x_set_glyph_string_clipping):
8321 Don't pass uninitialized region to CombineRgn.
8323 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8325 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8326 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8327 (Fx_close_connection): Remove unused variable `i'.
8329 * w32font.c (w32font_draw): Return number of glyphs.
8330 (w32font_open_internal): Remove unused variable `i'.
8331 (w32font_driver): Add missing initializer.
8333 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8334 (fill_in_menu): Remove unused variable `items_added'.
8336 * w32term.c (last_mouse_press_frame): Remove static global variable.
8337 (w32_clip_to_row): Remove unused variable `f'.
8338 (x_delete_terminal): Remove unused variable `i'.
8340 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8341 (NOTHING): Remove unused static global variable.
8342 (uniscribe_check_otf): Remove unused variable `table'.
8343 (uniscribe_font_driver): Add missing initializers.
8345 2011-03-23 Julien Danjou <julien@danjou.info>
8347 * term.c (Fsuspend_tty, Fresume_tty):
8348 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8349 * window.c (temp_output_buffer_show):
8350 * insdel.c (signal_before_change):
8351 * frame.c (Fhandle_switch_frame):
8352 * fileio.c (Fdo_auto_save):
8353 * emacs.c (Fkill_emacs):
8354 * editfns.c (save_excursion_restore):
8355 * cmds.c (internal_self_insert):
8356 * callint.c (Fcall_interactively):
8357 * buffer.c (Fkill_all_local_variables):
8358 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8360 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8361 unconditionally since it does the check itself.
8363 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8365 Fix more problems found by GCC 4.5.2's static checks.
8367 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8368 the first time through the loop, since we know p0 < p1 then.
8369 This also avoids a gcc -Wstrict-overflow warning.
8371 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8372 leading to a memory leak, possible in functions like
8373 load_charset_map_from_file that can allocate an unbounded number
8374 of objects (Bug#8318).
8376 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8377 that could (at least in theory) be that large.
8379 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8380 This is less likely to overflow, and avoids undefined behavior if
8381 overflow does occur. All callers changed. Use strtoul to scan
8382 for the unsigned long integer.
8383 (pint2hrstr): Simplify and tune code slightly.
8384 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8386 * scroll.c (do_scrolling): Work around GCC bug 48228.
8387 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8389 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8390 This also avoids a warning with gcc -Wstrict-overflow.
8391 (validate_x_resource_name): Simplify count usage.
8392 This also avoids a warning with gcc -Wstrict-overflow.
8394 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8397 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8399 * process.c (Fmake_network_process): Use socklen_t, not int,
8400 where POSIX says socklen_t is required in portable programs.
8401 This fixes a porting bug on hosts like 64-bit HP-UX, where
8402 socklen_t is wider than int (Bug#8277).
8403 (Fmake_network_process, server_accept_connection):
8404 (wait_reading_process_output, read_process_output):
8407 * process.c: Rename or move locals to avoid shadowing.
8408 (list_processes_1, Fmake_network_process):
8409 (read_process_output_error_handler, exec_sentinel_error_handler):
8410 Rename or move locals.
8411 (Fmake_network_process): Define label "retry_connect" only if needed.
8412 (Fnetwork_interface_info): Fix pointer signedness.
8413 (process_send_signal): Add cast to avoid pointer signedness problem.
8414 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8415 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8417 Make tparam.h and terminfo.c consistent.
8418 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8419 Include tparam.h instead, since it declares them.
8420 * cm.h (PC): Remove extern decl; tparam.h now does this.
8421 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8422 * terminfo.c: Include tparam.h, to check interfaces.
8423 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8424 (tparam): Adjust signature to match interface in tparam.h;
8425 this removes some undefined behavior. Check that outstring and len
8426 are zero, which they always are with Emacs.
8427 * tparam.h (PC, BC, UP): New extern decls.
8429 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8430 (xftfont_open): Rename locals to avoid shadowing.
8432 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8433 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8434 (OTF_TAG_SYM): Omit macro if not needed.
8435 (ftfont_list): Remove unused local.
8436 (get_adstyle_property, ftfont_pattern_entity):
8437 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8438 Rename locals to avoid shadowing.
8440 * xfont.c (xfont_list_family): Mark var as initialized.
8442 * xml.c (make_dom): Now static.
8444 * composite.c (composition_compute_stop_pos): Rename local to
8446 (composition_reseat_it): Remove unused locals.
8447 (find_automatic_composition, composition_adjust_point): Likewise.
8448 (composition_update_it): Mark var as initialized.
8449 (find_automatic_composition): Mark vars as initialized,
8450 with a FIXME (Bug#8290).
8452 character.h: Rename locals to avoid shadowing.
8453 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8454 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8455 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8456 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8459 * textprop.c (property_change_between_p): Remove; unused.
8461 * intervals.c (interval_start_pos): Now static.
8463 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8465 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8466 Rename locals to avoid shadowing.
8468 * sound.c (wav_play, au_play, Fplay_sound_internal):
8469 Fix pointer signedness.
8470 (alsa_choose_format): Remove unused local var.
8471 (wav_play): Initialize a variable to 0, to prevent undefined
8472 behavior (Bug#8278).
8474 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8476 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8478 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8479 clobbering (Bug#8298).
8480 * sysdep.c (sys_subshell): Likewise.
8481 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8483 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8484 This should get cleaned up, so that child_setup has the
8485 same signature on all platforms.
8487 * callproc.c (call_process_cleanup): Now static.
8488 (relocate_fd): Rename locals to avoid shadowing.
8490 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8492 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8493 not to be necessary, and produces flickering.
8495 2011-03-20 Glenn Morris <rgm@gnu.org>
8497 * config.in: Remove file.
8499 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8501 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8502 are now in src/globals.h.
8503 (syms_of_minibuf): Remove spurious & from previous change.
8505 2011-03-20 Leo Liu <sdl.web@gmail.com>
8507 * minibuf.c (completing-read-function): New variable.
8508 (completing-read-default): Rename from completing-read.
8509 (completing-read): Call completing-read-function.
8511 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8513 * xfaces.c (Fx_load_color_file):
8514 Read color file from absolute filename (bug#8250).
8516 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8518 * makefile.w32-in: Update dependencies.
8520 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8522 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8524 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8526 Fix more problems found by GCC 4.5.2's static checks.
8528 * process.c (make_serial_process_unwind, send_process_trap):
8529 (sigchld_handler): Now static.
8531 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8532 That way, the code declares only the vars that it needs.
8533 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8534 * s/cygwin.h (PTY_ITERATION): Likewise.
8535 * s/darwin.h (PTY_ITERATION): Likewise.
8536 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8538 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8539 * process.c (allocate_pty): Don't declare stb unless it's needed.
8541 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8542 (CONSTANTLIM): Remove; unused.
8543 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8544 Define only if needed.
8546 * unexelf.c (unexec): Name an expression,
8547 to avoid gcc -Wbad-function-cast warning.
8548 Use a different way to cause a compilation error if anyone uses
8549 n rather than nn, a way that does not involve shadowing.
8550 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8552 * deps.mk (unexalpha.o): Remove; unused.
8554 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8555 * unexec.h: New file.
8556 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8557 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8559 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8560 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8561 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8562 Change as necessary to match prototype in unexec.h.
8564 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8566 (back_comment, skip_chars): Mark vars as initialized.
8568 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8569 Rename locals to avoid shadowing.
8571 * lread.c (read1): Rewrite so as not to use empty "else".
8572 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8574 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8576 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8577 warning when compiling print.c.
8579 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8580 instead of using an uninitialized var.
8581 (font_sort_entities): Mark var as initialized.
8583 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8585 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8586 pointers to constants.
8587 (font_parse_fcname): Remove unused vars.
8588 (font_delete_unmatched): Now static.
8589 (font_get_spec): Remove; unused.
8590 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8591 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8592 Rename or move locals to avoid shadowing.
8594 * fns.c (require_nesting_list, require_unwind): Now static.
8595 (Ffillarray): Rename locals to avoid shadowing.
8597 * floatfns.c (domain_error2): Define only if needed.
8598 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8600 * alloc.c (mark_backtrace): Move decl from here ...
8601 * lisp.h: ... to here, so that it can be checked.
8603 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8604 (Fdefvar): Rewrite so as not to use empty "else".
8605 (lisp_indirect_variable): Name an expression,
8606 to avoid gcc -Wbad-function-cast warning.
8607 (Fdefvar): Rename locals to avoid shadowing.
8609 * callint.c (quotify_arg, quotify_args): Now static.
8610 (Fcall_interactively): Rename locals to avoid shadowing.
8611 Use const pointer when appropriate.
8613 * lisp.h (get_system_name, get_operating_system_release):
8614 Move decls here, to check interfaces.
8615 * process.c (get_operating_system_release): Move decl to lisp.h.
8616 * xrdb.c (get_system_name): Likewise.
8617 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8618 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8619 some of which prompt warnings from gcc -Wbad-function-cast.
8620 (Fformat_time_string, Fencode_time, Finsert_char):
8621 (Ftranslate_region_internal, Fformat):
8622 Rename or remove local vars to avoid shadowing.
8623 (Ftranslate_region_internal): Mark var as initialized.
8625 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8628 * lisp.h (eassert): Check that the argument compiles, even if
8629 ENABLE_CHECKING is not defined.
8631 * data.c (Findirect_variable): Name an expression, to avoid
8632 gcc -Wbad-function-cast warning.
8633 (default_value, arithcompare, arith_driver, arith_error): Now static.
8634 (store_symval_forwarding): Rename local to avoid shadowing.
8635 (Fmake_variable_buffer_local, Fmake_local_variable):
8636 Mark variables as initialized.
8637 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8639 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8640 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8641 Rename locals to avoid shadowing.
8642 (mark_stack): Move local variables into the #ifdef region where
8644 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8645 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8647 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8648 (GC_STRING_CHARS): Remove; not used.
8649 (Fmemory_limit): Cast sbrk's returned value to char *.
8651 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8652 avoids undefined behavior in theory.
8654 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8656 Use functions, not macros, for up- and down-casing (Bug#8254).
8657 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8658 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8659 to use the following functions instead of these macros.
8660 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8661 EMACS_INT, since callers assume the returned value fits in int.
8662 (upcase1): Likewise, for UPCASE_TABLE.
8663 (uppercasep, lowercasep, upcase): New static inline functions.
8664 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8665 the race-condition problem in the old DOWNCASE.
8667 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8668 Rename locals to avoid shadowing.
8669 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8670 (regex_compile, re_search_2, re_match_2_internal):
8671 Remove unused local vars.
8672 (FREE_VAR): Rewrite so as not to use empty "else",
8673 which gcc can warn about.
8674 (regex_compile, re_match_2_internal): Mark locals as initialized.
8675 (RETALLOC_IF): Define only if needed.
8676 (WORDCHAR_P): Likewise. This one is never needed, but is used
8677 only in a comment talking about a compiler bug, so put inside
8678 the #if 0 of that comment.
8679 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8680 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8683 * search.c (boyer_moore): Rename locals to avoid shadowing.
8684 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8685 (PREV_CHAR_BOUNDARY): Likewise.
8687 * search.c (simple_search): Remove unused var.
8689 * dired.c (compile_pattern): Move decl from here ...
8690 * lisp.h: ... to here, so that it can be checked.
8691 (struct re_registers): New forward decl.
8693 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8695 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8697 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8698 Rename locals to avoid shadowing.
8699 (Fvertical_motion): Mark locals as initialized.
8701 * casefiddle.c (casify_object, casify_region): Now static.
8702 (casify_region): Mark local as initialized.
8704 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8706 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8707 New macros, so that the caller can use some names other than
8708 gcpro1, gcpro2, etc.
8709 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8711 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8712 argument, for consistency with GCPRO2_VAR, etc: it is now the
8713 prefix of the variable, not the variable itself. All uses
8715 * dired.c (directory_files_internal, file_name_completion):
8716 Rename locals to avoid shadowing.
8718 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8719 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8720 dired.c's scmp function, had undefined behavior.
8721 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8722 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8723 * buffer.h: ... to here, because these macros use current_buffer,
8724 and the new implementation with inline functions needs to have
8725 current_buffer in scope now, rather than later when the macros
8727 (downcase, upcase1): New static inline functions.
8728 (DOWNCASE, UPCASE1): Reimplement using these functions.
8729 This avoids undefined behavior in expressions like
8730 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8731 from race conditions in accessing the global variables
8732 case_temp1 and case_temp2.
8733 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8734 * lisp.h (case_temp1, case_temp2): Remove their decls.
8735 * character.h (ASCII_CHAR_P): Move from here ...
8736 * lisp.h: ... to here, so that the inline functions mentioned
8739 * dired.c (directory_files_internal_unwind): Now static.
8741 * fileio.c (file_name_as_directory, directory_file_name):
8742 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8744 (file_name_as_directory): Use const pointers when appropriate.
8745 (Fexpand_file_name): Likewise. In particular, newdir might
8746 point at constant storage, so make it a const pointer.
8747 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8748 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8750 (Fset_file_times, Finsert_file_contents, auto_save_error):
8751 Rename locals to avoid shadowing.
8753 * minibuf.c (choose_minibuf_frame_1): Now static.
8754 (Ftry_completion, Fall_completions): Rename or remove locals
8757 * marker.c (bytepos_to_charpos): Remove; unused.
8759 * lisp.h (verify_bytepos, count_markers): New decls,
8760 so that gcc does not warn that these functions aren't declared.
8762 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8763 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8764 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8765 (copy_text): Remove unused local var.
8767 * filelock.c (within_one_second): Now static.
8768 (lock_file_1): Rename local to avoid shadowing.
8770 * buffer.c (fix_overlays_before): Mark locals as initialized.
8771 (fix_start_end_in_overlays): Likewise. This function should be
8772 simplified by using pointers-to-pointers, but that's a different
8774 (switch_to_buffer_1): Now static.
8775 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8776 (report_overlay_modification): Rename locals to avoid shadowing.
8778 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8779 Fix pointer signedness issue.
8780 (sys_subshell): Mark local as volatile if checking for lint,
8781 to suppress a gcc -Wclobbered warning that does not seem to be right.
8782 (MAXPATHLEN): Define only if needed.
8784 * process.c (serial_open, serial_configure): Move decls from here ...
8785 * systty.h: ... to here, so that they can be checked.
8787 * fns.c (get_random, seed_random): Move extern decls from here ...
8788 * lisp.h: ... to here, so that they can be checked.
8790 * sysdep.c (reset_io): Now static.
8791 (wait_for_termination_signal): Remove; unused.
8793 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8794 (copy_keymap_item, append_key, push_text_char_description):
8796 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8797 (DENSE_TABLE_SIZE): Remove; unused.
8798 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8799 (describe_map_tree):
8800 Rename locals to avoid shadowing.
8802 * keyboard.c: Declare functions static if they are not used elsewhere.
8803 (echo_char, echo_dash, cmd_error, top_level_2):
8804 (poll_for_input, handle_async_input): Now static.
8805 (read_char, kbd_buffer_get_event, make_lispy_position):
8806 (make_lispy_event, make_lispy_movement, apply_modifiers):
8807 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8808 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8809 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8810 (read_key_sequence, read_char): Mark locals as initialized.
8811 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8813 * keyboard.h (make_ctrl_char): New decl.
8814 (mark_kboards): Move decl here ...
8815 * alloc.c (mark_kboards): ... from here.
8817 * lisp.h (force_auto_save_soon): New decl.
8819 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8820 (DEFINE_DUMMY_FUNCTION): New macro.
8821 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8823 (main): Add casts to avoid warnings
8824 if GCC considers string literals to be constants.
8826 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8828 * dbusbind.c: Pointer signedness fixes.
8829 (xd_signature, xd_append_arg, xd_initialize):
8830 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8831 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8832 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8833 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8835 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8836 if GCC considers string literals to be constants.
8837 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8839 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8841 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8842 (print_preprocess, print_object): New macro to fix last change.
8844 * print.c (print_preprocess): Don't forget font objects.
8846 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8848 * emacs.c (USAGE3): Doc fixes.
8850 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8852 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8855 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8857 * lisp.h (VWindow_system, Qfile_name_history):
8858 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8859 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8860 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8862 * w32select.c: Don't #include "keyboard.h".
8863 (run_protected): Add extern declaration for waiting_for_input.
8865 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8866 * w32console.c (detect_input_pending, read_input_pending)
8867 (encode_terminal_code):
8868 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8869 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8870 (w32_system_caret_y, Qfile_name_history):
8871 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8872 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8873 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8874 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8875 * w32proc.c (Qlocal, report_file_error):
8876 * w32term.c (Vwindow_system, updating_frame):
8877 * w32uniscribe.c (initialized, uniscribe_font_driver):
8878 Remove unneeded extern declarations.
8880 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8882 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8884 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8886 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8887 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8888 These macros can no longer be used for assignment.
8890 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8891 Assign struct members directly, instead of using BUF_BEGV etc.
8892 (record_buffer_markers, fetch_buffer_markers): New functions for
8893 recording and fetching special buffer markers.
8894 (set_buffer_internal_1, set_buffer_temp): Use them.
8896 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8898 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8900 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8901 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8903 * xdisp.c (hscroll_window_tree):
8904 (reconsider_clip_changes): Use PT instead of BUF_PT.
8906 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8908 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8909 $(EMACS_ROOT)/lib/intprops.h.
8911 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8913 Fix more problems found by GCC 4.5.2's static checks.
8915 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8916 to unsigned char * to avoid compiler diagnostic.
8917 (xg_free_frame_widgets): Make it clear that a local variable is
8918 needed only if USE_GTK_TOOLTIP.
8919 (gdk_window_get_screen): Make it clear that this macro is needed
8920 only if USE_GTK_TOOLTIP.
8921 (int_gtk_range_get_value): New function, which avoids a diagnostic
8922 from gcc -Wbad-function-cast.
8923 (xg_set_toolkit_scroll_bar_thumb): Use it.
8924 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8925 diagnostic from gcc -Wbad-function-cast.
8926 (get_utf8_string, xg_get_file_with_chooser):
8927 Rename locals to avoid shadowing.
8928 (create_dialog): Move locals to avoid shadowing.
8930 * xgselect.c (xg_select): Remove unused var.
8932 * image.c (four_corners_best): Mark locals as initialized.
8933 (gif_load): Initialize transparent_p to zero (Bug#8238).
8934 Mark another local as initialized.
8935 (my_png_error, my_error_exit): Mark with NO_RETURN.
8937 * image.c (clear_image_cache): Now static.
8938 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8939 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8940 (x_edge_detection): Remove unnecessary cast that
8941 gcc -Wbad-function-cast diagnoses.
8942 (gif_load): Fix pointer signedness.
8943 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8944 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8946 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8948 Improve quality of tests for time stamp overflow.
8949 For example, without this patch (encode-time 0 0 0 1 1
8950 1152921504606846976) returns the obviously-bogus value (-948597
8951 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8952 reports time overflow. See
8953 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8954 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8955 * editfns.c: Include limits.h and intprops.h.
8956 (TIME_T_MIN, TIME_T_MAX): New macros.
8957 (time_overflow): Move earlier, to before first use.
8958 (hi_time, lo_time): New functions, for an accurate test for
8960 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8961 (Fget_internal_run_time): Don't assume time_t fits in int.
8962 (make_time): Use list2 instead of Fcons twice.
8963 (Fdecode_time): More accurate test for out-of-range times.
8964 (check_tm_member): New function.
8965 (Fencode_time): Use it, to test for out-of-range times.
8966 (lisp_time_argument): Don't rely on undefined left-shift and
8967 right-shift behavior when checking for time stamp overflow.
8969 * editfns.c (time_overflow): New function, refactoring common code.
8970 (Fformat_time_string, Fdecode_time, Fencode_time):
8971 (Fcurrent_time_string): Use it.
8973 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8974 * dired.c (make_time): Move to ...
8975 * editfns.c (make_time): ... here.
8976 * systime.h: Note the move.
8978 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8980 * fringe.c (update_window_fringes): Remove unused variables.
8982 * unexmacosx.c (copy_data_segment): Also copy __got section.
8985 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8987 * termcap.c [MSDOS]: Include "msdos.h".
8988 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8989 Constify `char *' arguments and their references according to
8990 prototypes in tparam.h.
8992 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8994 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8995 Adapt all references accordingly.
8997 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8999 2011-03-11 Tom Tromey <tromey@redhat.com>
9001 * buffer.c (syms_of_buffer): Remove obsolete comment.
9003 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9005 * termhooks.h (encode_terminal_code): Declare prototype.
9007 * msdos.c (encode_terminal_code): Don't declare prototype.
9009 * term.c (encode_terminal_code): Now external again, used by
9010 w32console.c and msdos.c.
9012 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9013 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9015 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9017 Fix some minor problems found by GCC 4.5.2's static checks.
9019 * fringe.c (update_window_fringes): Mark locals as initialized
9021 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9023 * alloc.c (mark_fringe_data): Move decl from here ...
9024 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9025 to check its interface.
9026 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9028 * fontset.c (free_realized_fontset): Now static.
9029 (Fset_fontset_font): Rename local to avoid shadowing.
9030 (fontset_font): Mark local as initialized.
9031 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9033 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9035 * xselect.c (x_disown_buffer_selections): Remove; not used.
9036 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9037 (x_own_selection, Fx_disown_selection_internal): Rename locals
9039 (x_handle_dnd_message): Remove local to avoid shadowing.
9041 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9042 so that the caller can use some name other than gcpro1.
9043 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9044 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9045 (Fx_backspace_delete_keys_p):
9046 Use them to avoid shadowing, and rename vars to avoid shadowing.
9047 (x_decode_color, x_set_name, x_window): Now static.
9048 (Fx_create_frame): Add braces to silence GCC warning.
9049 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9050 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9051 Remove unused locals.
9052 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9053 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9054 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9057 * xterm.h (x_mouse_leave): New decl.
9059 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9060 Remove unused functions.
9061 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9062 (x_calc_absolute_position): Now static.
9063 (XTread_socket): Don't define label "out" unless it's used.
9064 Don't declare local "event" unless it's used.
9065 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9066 unless they are used.
9067 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9068 (x_fatal_error_signal): Remove; not used.
9069 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9070 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9071 (x_error_catcher, x_connection_closed, x_error_handler):
9072 (x_error_quitter, xembed_send_message, x_iconify_frame):
9073 (my_log_handler): Rename locals to avoid shadowing.
9074 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9075 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9077 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9078 Rename or move locals to avoid shadowing.
9079 (tty_defined_color, merge_face_heights): Now static.
9080 (free_realized_faces_for_fontset): Remove; not used.
9081 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9082 does not deduce is never used uninitialized.
9083 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9084 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9086 * terminal.c (store_terminal_param): Now static.
9088 * xmenu.c (menu_highlight_callback): Now static.
9089 (set_frame_menubar): Remove unused local.
9090 (xmenu_show): Rename parameter to avoid shadowing.
9091 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9092 since they might point to immutable storage.
9093 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9094 since it's unused otherwise.
9096 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9097 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9098 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9099 avoids a gcc -Wuninitialized diagnostic.
9100 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9101 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9102 does not deduce are never used uninitialized.
9104 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9106 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9107 * window.c (window_loop, size_window):
9108 (run_window_configuration_change_hook, enlarge_window): Likewise.
9110 * window.c (display_buffer): Now static.
9111 (size_window): Mark variables that gcc -Wuninitialized
9112 does not deduce are never used uninitialized.
9113 * window.h (check_all_windows): New decl, to forestall
9114 gcc -Wmissing-prototypes diagnostic.
9115 * dispextern.h (bidi_dump_cached_states): Likewise.
9117 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9119 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9121 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9122 and to avoid gcc -Wuninitialized warning.
9123 (load_charset_map): Mark variables that gcc -Wuninitialized
9124 does not deduce are never used uninitialized.
9125 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9127 * coding.c (coding_set_source, coding_set_destination):
9128 Use "else { /* comment */ }" rather than "else /* comment */;"
9129 for clarity, and to avoid gcc -Wempty-body warning.
9130 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9131 a block, when the outer 'i' will do.
9132 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9133 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9134 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9135 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9136 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9137 Rename locals to avoid shadowing.
9138 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9139 * coding.c (emacs_mule_char, encode_invocation_designation):
9140 Now static, since they're not used elsewhere.
9141 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9142 (decode_coding_object, encode_coding_object, detect_coding_system):
9143 (decode_coding_emacs_mule): Mark variables that gcc
9144 -Wuninitialized does not deduce are never used uninitialized.
9145 (detect_coding_iso_2022): Initialize a local variable that might
9146 be used uninitialized. Leave a FIXME because it's not clear that
9147 this initialization is needed. (Bug#8211)
9148 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9149 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9150 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9151 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9152 Remove unused macros.
9154 * category.c (hash_get_category_set): Remove unused local var.
9155 (copy_category_table): Now static, since it's not used elsewhere.
9156 * character.c (string_count_byte8): Likewise.
9158 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9159 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9161 * chartab.c (copy_sub_char_table): Now static, since it's not used
9163 (sub_char_table_ref_and_range, char_table_ref_and_range):
9164 Rename locals to avoid shadowing.
9165 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9167 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9168 (BIDI_BOB): Remove unused macro.
9170 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9171 deduce are never used uninitialized.
9172 * term.c (encode_terminal_code): Likewise.
9174 * term.c (encode_terminal_code): Now static. Remove unused local.
9176 * tparam.h: New file.
9177 * term.c, tparam.h: Include it.
9178 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9179 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9180 Move these decls to tparam.h, and make them agree with what
9181 is actually in tparam.c. The previous trick of using incompatible
9182 decls in different modules does not conform to the C standard.
9183 All callers of tparam changed to use tparam's actual API.
9184 * tparam.c (tparam1, tparam, tgoto):
9185 Use const pointers where appropriate.
9187 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9188 * cm.h (struct cm): Likewise.
9189 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9190 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9191 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9192 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9193 (turn_on_face, init_tty): Likewise.
9194 * termchar.h (struct tty_display_info): Likewise.
9196 * term.c (term_mouse_position): Rename local to avoid shadowing.
9198 * alloc.c (mark_ttys): Move decl from here ...
9199 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9201 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9203 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9205 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9207 * search.c (compile_pattern_1): Remove argument regp, unused since
9208 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9209 (compile_pattern): Don't pass it.
9211 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9213 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9214 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9216 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9218 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9220 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9221 gdk_window_get_screen, gdk_window_get_geometry,
9222 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9223 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9224 (xg_get_pixbuf_from_pixmap): New function.
9225 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9226 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9227 Call xg_get_pixbuf_from_pixmap instead of
9228 gdk_pixbuf_get_from_drawable.
9229 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9230 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9231 (xg_check_special_colors): Use GtkStyleContext and its functions
9233 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9234 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9235 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9236 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9237 Call gtk_widget_get_preferred_size.
9238 (xg_frame_resized): gdk_window_get_geometry only takes 5
9240 (xg_win_to_widget, xg_event_is_for_menubar):
9241 Call gdk_x11_window_lookup_for_display.
9242 (xg_set_widget_bg): New function.
9243 (delete_cb): New function.
9244 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9245 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9246 (xg_set_background_color): Call xg_set_widget_bg.
9247 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9248 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9249 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9250 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9252 (update_frame_tool_bar): Call gtk_widget_hide.
9253 (xg_initialize): Use GDK_KEY_g.
9255 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9257 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9259 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9260 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9261 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9263 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9265 * w32xfns.c (select_palette): Check success of RealizePalette against
9266 GDI_ERROR, not zero.
9268 See ChangeLog.11 for earlier changes.
9274 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9276 This file is part of GNU Emacs.
9278 GNU Emacs is free software: you can redistribute it and/or modify
9279 it under the terms of the GNU General Public License as published by
9280 the Free Software Foundation, either version 3 of the License, or
9281 (at your option) any later version.
9283 GNU Emacs is distributed in the hope that it will be useful,
9284 but WITHOUT ANY WARRANTY; without even the implied warranty of
9285 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9286 GNU General Public License for more details.
9288 You should have received a copy of the GNU General Public License
9289 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.