1 2012-02-22 Chong Yidong <cyd@gnu.org>
3 * xterm.c (x_draw_image_relief): Add missing type check for
4 Vtool_bar_button_margin (Bug#10743).
6 2012-02-21 Chong Yidong <cyd@gnu.org>
8 * fileio.c (Vfile_name_handler_alist): Doc fix.
10 * buffer.c (Fget_file_buffer): Protect against invalid file
13 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
15 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
16 when computing $valmask.
18 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
19 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
20 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
21 It's useless in that case, and it can cause problems on hosts
22 that allocate halves of EMACS_INT values separately.
23 Reported by Dan Horák. Diagnosed by Andreas Schwab in
24 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
25 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
26 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
27 it avoids undefined behavior on hosts where shifting right by more
28 than the word width has undefined behavior.
30 2012-02-19 Chong Yidong <cyd@gnu.org>
32 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
33 (Funhandled_file_name_directory, Ffile_name_as_directory)
34 (Fdirectory_file_name, Fexpand_file_name)
35 (Fsubstitute_in_file_name): Protect against invalid file handler
36 return values (Bug#10845).
38 2012-02-18 Eli Zaretskii <eliz@gnu.org>
40 * .gdbinit (pitx): Fix incorrect references to fields of the
43 2012-02-17 Chong Yidong <cyd@gnu.org>
45 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
47 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
49 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
50 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
52 2012-02-15 Chong Yidong <cyd@gnu.org>
54 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
55 marked as special. Also, starting docstrings with * is obsolete.
57 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
59 * gnutls.c (emacs_gnutls_write): Fix last change.
61 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
63 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
66 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
68 * keymap.c (Fsingle_key_description): Handle char ranges.
70 2012-02-12 Chong Yidong <cyd@gnu.org>
72 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
73 as that creates a dangerous corner case.
75 * window.c (Fdelete_window_internal): Invalidate the mouse
78 2012-02-12 Glenn Morris <rgm@gnu.org>
80 * xselect.c (Fx_own_selection_internal)
81 (Fx_get_selection_internal, Fx_disown_selection_internal)
82 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
83 * nsselect.m (Fx_own_selection_internal)
84 (Fx_disown_selection_internal, Fx_selection_exists_p)
85 (Fx_selection_owner_p, Fx_get_selection_internal):
86 Sync docs and argument specs with the xselect.c versions.
88 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
90 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
92 2012-02-11 Eli Zaretskii <eliz@gnu.org>
94 * w32select.c (Fx_selection_exists_p): Sync doc string and
95 argument list with xselect.c. (Bug#10783)
97 * w16select.c (Fx_selection_exists_p): Sync doc string and
98 argument list with xselect.c. (Bug#10783)
100 2012-02-10 Glenn Morris <rgm@gnu.org>
102 * fns.c (Fsecure_hash): Doc fix.
104 2012-02-09 Kenichi Handa <handa@m17n.org>
106 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
108 2012-02-07 Chong Yidong <cyd@gnu.org>
110 * buffer.c (Fbuffer_local_variables)
111 (buffer_lisp_local_variables): Handle unbound vars correctly;
112 don't let Qunbound leak into Lisp.
114 2012-02-07 Glenn Morris <rgm@gnu.org>
116 * image.c (Fimagemagick_types): Doc fix.
118 * image.c (imagemagick-render-type): Change it from a lisp object
119 to an integer. Move the doc here from the lisp manual.
120 Treat all values not equal to 0 the same.
122 2012-02-06 Chong Yidong <cyd@gnu.org>
124 * doc.c (store_function_docstring): Avoid applying docstring of
125 alias to base function (Bug#2603).
127 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
129 * .gdbinit (pp1, pv1): Remove redundant defines.
132 2012-02-04 Chong Yidong <cyd@gnu.org>
134 * nsterm.m: Declare a global (Bug#10694).
136 2012-02-04 Eli Zaretskii <eliz@gnu.org>
138 * w32.c (get_emacs_configuration_options): Include
139 --enable-checking, if specified, in the return value.
141 2012-02-04 Martin Rudalics <rudalics@gmx.at>
143 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
144 after rounding frame sizes. (Bug#9723)
146 2012-02-04 Eli Zaretskii <eliz@gnu.org>
148 * keyboard.c (adjust_point_for_property): Don't position point
149 before BEGV. (Bug#10696)
151 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
153 Handle overflow when computing char display width (Bug#9496).
154 * character.c (char_width): Return EMACS_INT, not int.
155 (char_width, c_string_width): Check for overflow when
156 computing the width; this is possible now that individual
157 characters can have unbounded width. Problem introduced
158 by merge from Emacs 23 on 2012-01-19.
160 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
162 * dbusbind.c (Fdbus_register_method): Mention the return value
163 :ignore in the docstring.
165 2012-02-02 Glenn Morris <rgm@gnu.org>
167 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
169 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
170 Unconditionally set to t. (Bug#10673)
171 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
172 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
173 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
175 2012-02-02 Kenichi Handa <handa@m17n.org>
177 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
178 0, do not call append_composite_glyph.
180 2012-02-02 Kenichi Handa <handa@m17n.org>
182 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
184 (x_produce_glyphs): If the component of a composition is a null
185 string, set it->pixel_width to 1 to avoid zero-width glyph.
187 2012-02-01 Eli Zaretskii <eliz@gnu.org>
189 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
190 first 2 arguments are identical. This makes inserting large
191 output from a subprocess an order of magnitude faster on
192 MS-Windows, where all sbrk'ed memory is always contiguous.
194 2012-01-31 Glenn Morris <rgm@gnu.org>
196 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
197 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
198 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
200 2012-01-29 Glenn Morris <rgm@gnu.org>
202 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
204 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
206 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
208 2012-01-28 Chong Yidong <cyd@gnu.org>
210 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
212 2012-01-26 Chong Yidong <cyd@gnu.org>
214 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
216 * search.c (Fsearch_forward, Fsearch_backward): Document negative
217 repeat counts (Bug#10507).
219 2012-01-26 Glenn Morris <rgm@gnu.org>
221 * lread.c (syms_of_lread): Doc fix.
223 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
225 * coding.c (encode_designation_at_bol): Change return value to
228 2012-01-25 Chong Yidong <cyd@gnu.org>
230 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
232 2012-01-21 Chong Yidong <cyd@gnu.org>
234 * floatfns.c (Fcopysign): Make the second argument non-optional,
235 since nil is not allowed anyway.
237 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
239 * process.c (read_process_output): Use p instead of XPROCESS (proc).
240 (send_process): Likewise.
242 2012-01-19 Martin Rudalics <rudalics@gmx.at>
244 * window.c (save_window_save, Fcurrent_window_configuration)
245 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
248 2012-01-19 Kenichi Handa <handa@m17n.org>
250 * character.c (char_width): New function.
251 (Fchar_width, c_string_width, lisp_string_width):
252 Use char_width (Bug#9496).
254 2012-01-16 Martin Rudalics <rudalics@gmx.at>
256 * window.c (Vwindow_persistent_parameters): New variable.
257 (Fset_window_configuration, save_window_save): Handle persistent
260 2012-01-14 Eli Zaretskii <eliz@gnu.org>
262 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
263 thrashing the stack of the thread. (Bug#9087)
265 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
267 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
269 2012-01-11 Eli Zaretskii <eliz@gnu.org>
271 * xdisp.c (rows_from_pos_range): Handle the case where the
272 highlight ends on a newline. (Bug#10464)
273 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
274 he end column for display of highlight that ends on a newline
277 2012-01-11 Glenn Morris <rgm@gnu.org>
279 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
280 from load-path also when installation-directory is nil. (Bug#10208)
282 2012-01-10 Glenn Morris <rgm@gnu.org>
284 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
286 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
287 Update template values to be closer to their typical values these days.
289 2012-01-09 Eli Zaretskii <eliz@gnu.org>
291 * xdisp.c (rows_from_pos_range): Accept additional argument
292 DISP_STRING, and accept any glyph in a row whose object is that
293 string as eligible for mouse highlight. Fixes mouse highlight of
294 display strings from overlays. (Bug#10464)
296 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
298 emacs: fix an auto-save permissions race condition (Bug#10400)
299 * fileio.c (auto_saving_dir_umask): New static var.
300 (Fmake_directory_internal): Use it.
301 (do_auto_save_make_dir): Set it, instead of invoking chmod after
302 creating the directory. The old code temporarily assigns
303 too-generous permissions to the directory.
304 (do_auto_save_eh): Clear it.
305 (Fdo_auto_save): Catch all errors, not just file errors, so
306 that the var is always cleared.
308 2012-01-07 Eli Zaretskii <eliz@gnu.org>
310 * search.c (scan_buffer): Pass character positions to
311 know_region_cache, not byte positions. (Bug#6540)
313 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
315 * w32.c (sys_rename): Report EXDEV when rename of a directory
316 fails because the target is on another logical disk. (Bug#10284)
318 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
320 * xterm.c (x_embed_request_focus): New function.
322 * xterm.h: Add prototype.
324 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
326 2012-01-05 Glenn Morris <rgm@gnu.org>
328 * emacs.c (emacs_copyright): Update short copyright year to 2012.
330 2012-01-01 Eli Zaretskii <eliz@gnu.org>
332 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
333 Load gnutls_transport_set_lowat only if GnuTLS version is below
335 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
336 GnuTLS versions below 2.11.1.
338 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
340 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
341 to the doc string advising against its use for altering the way
342 windows are scrolled.
344 2011-12-28 Kenichi Handa <handa@m17n.org>
346 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
347 coding-system ASCII compatible only when it does not produce BOM
348 on encoding (Bug#10383).
350 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
352 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
354 (create_and_show_popup_menu): Always use menu_position_func for
357 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
359 * callint.c (Fcall_interactively): Don't truncate prompt string.
361 2011-12-23 Eli Zaretskii <eliz@gnu.org>
363 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
364 property that ends at ZV, so that the bidi iteration could be
365 resumed from there (after widening). (Bug#10360)
367 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
369 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
371 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
373 * nsterm.m (x_free_frame_resources):
374 Release f->output_data.ns->miniimage.
375 (ns_index_color): Fix indentation. Do not retain
376 color_table->colors[i].
378 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
381 * nsfns.m (x_set_background_color): Assign return value from
382 ns_index_color to face-background instead of NSColor*.
383 (ns_implicitly_set_icon_type): Fix indentation.
384 Change assignment in for loop to comparison.
386 * emacs.c (ns_pool): New variable.
387 (main): Assign ns_pool.
388 (Fkill_emacs): Call ns_release_autorelease_pool.
390 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
391 autorelease fdesc, release fdAttrs and tdict.
392 (ns_get_covering_families): Release charset.
393 (ns_findfonts): Release NSFontDescriptor created with new.
394 (ns_uni_to_glyphs): Fix indentation.
395 (setString): Release attrStr before assigning new value.
397 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
399 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
401 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
402 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
404 2011-12-18 David Reitter <reitter@cmu.edu>
406 * nsterm.m (ns_term_init): Subscribe for notifications
407 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
408 to method trackingNotification in EmacsMenu.
410 * nsmenu.m (trackingMenu): New variable.
411 (trackingNotification): New method (from Aquamacs).
412 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
413 from Aquamacs (Bug#7030).
415 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
417 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
418 (symbol_to_nsstring): Fix indentation.
419 (ns_symbol_to_pb): New function.
420 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
421 (Fns_rotate_cut_buffers_internal): Removed.
422 (Fns_store_selection_internal): Renamed from
423 Fns_store_cut_buffer_internal.
424 (ns_get_foreign_selection, Fx_own_selection_internal)
425 (Fx_disown_selection_internal, Fx_selection_exists_p)
426 (Fns_get_selection_internal, Fns_store_selection_internal):
427 Use ns_symbol_to_pb and check if return value is nil.
428 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
429 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
430 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
431 renamed to Sns_store_selection_internal.
432 (ns_handle_selection_request): Move code to Fx_own_selection_internal
433 and remove this function.
434 (ns_handle_selection_clear): Remove, never used.
435 (Fx_own_selection_internal): Move code from ns_handle_selection_request
438 2011-12-17 Ken Brown <kbrown@cornell.edu>
440 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
441 GID is unknown (Bug#10257).
443 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
445 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
446 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
447 which caused a build failure on GNU/Linux IA-64. This problem was
448 introduced by my 2011-10-07 patch.
450 2011-12-15 Juri Linkov <juri@jurta.org>
452 * image.c (imagemagick_error): New function. (Bug#10112)
453 (imagemagick_load_image): Comment out `MagickSetResolution' call.
454 Use `imagemagick_error' where ImageMagick functions return
456 (Fimagemagick_types): Add `Fnreverse' to return the list in the
459 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
461 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
462 fill background (Bug#8992).
464 2011-12-13 Martin Rudalics <rudalics@gmx.at>
466 * window.c (Vwindow_combination_resize)
467 (Vwindow_combination_limit): Use t instead of non-nil in
469 (Vrecenter_redisplay): Add first sentence of doc-string on
471 (Frecenter): Fix doc-string typo.
473 2011-12-11 Kenichi Handa <handa@m17n.org>
475 * coding.c (Funencodable_char_position): Pay attention to the
476 buffer text relocation (Bug#9389).
478 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
480 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
481 gtk_init (Bug#10100).
483 2011-12-10 Eli Zaretskii <eliz@gnu.org>
485 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
486 IT->string is nil. (Bug#10263)
488 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
490 * nsterm.h (x_free_frame_resources): Declare.
492 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
493 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
495 * nsterm.h (ns_get_defaults_value): Declare.
497 * nsterm.m (ns_default): Call ns_get_defaults_value.
499 2011-12-09 Eli Zaretskii <eliz@gnu.org>
501 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
504 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
506 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
507 that where the value of an _OBJC_* symbol points to is in the .bss
510 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
512 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
513 after the loop to call ccl_driver at least once (Bug#8619).
515 2011-12-08 Kenichi Handa <handa@m17n.org>
517 * ftfont.c (get_adstyle_property): Fix previous change
520 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
522 * w32.c (init_environment): If no_site_lisp, remove site-lisp
523 dirs from the default value of EMACSLOADPATH (bug#10208).
525 2011-12-07 Glenn Morris <rgm@gnu.org>
527 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
528 installation and source directories as well. (Bug#10208)
530 2011-12-06 Chong Yidong <cyd@gnu.org>
532 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
534 2011-12-06 Glenn Morris <rgm@gnu.org>
536 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
537 as an error, not just -1. (Bug#10217)
539 2011-12-05 Chong Yidong <cyd@gnu.org>
541 * keyboard.c (process_special_events): New function.
542 (swallow_events, Finput_pending_p): Use it (Bug#10195).
544 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
546 * coding.c (encode_designation_at_bol): Don't use uninitialized
547 local variable (Bug#9318).
549 2011-12-05 Kenichi Handa <handa@m17n.org>
551 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
552 return Qnil (Bug#8046, Bug#10193).
554 2011-12-05 Kenichi Handa <handa@m17n.org>
556 * coding.c (encode_designation_at_bol): New args charbuf_end and
557 dst. Return the number of produced bytes. Callers changed.
558 (coding_set_source): Return how many bytes coding->source was
560 (coding_set_destination): Return how many bytes
561 coding->destination was relocated.
562 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
563 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
565 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
567 * coding.c (CODING_CHAR_CHARSET_P): New macro.
568 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
571 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
573 The following changes are to fix Bug#9318.
575 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
576 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
577 (encode_coding_iso_2022, encode_coding_sjis)
578 (encode_coding_big5, encode_coding_charset): Use the above macros.
580 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
582 * lisp.h (process_quit_flag): Fix external declaration.
584 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
586 Don't macro-inline non-performance-critical code.
587 * eval.c (process_quit_flag): New function.
588 * lisp.h (QUIT): Use it.
590 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
592 * nsfns.m (get_geometry_from_preferences): New function.
593 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
595 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
597 * emacs.c (Qkill_emacs): Define.
598 (syms_of_emacs): Initialize it.
599 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
600 Qquit_flag to `kill-emacs' instead.
601 (quit_throw_to_read_char): Add parameter `from_signal'.
602 All callers changed. Call Fkill_emacs if requested and safe.
603 * lisp.h (QUIT): Call Fkill_emacs if requested.
605 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
607 * widget.c (update_wm_hints): Return if wmshell is null.
608 (widget_update_wm_size_hints): New function.
610 * widget.h (widget_update_wm_size_hints): Declare.
612 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
613 widget_update_wm_size_hints (Bug#10104).
615 2011-12-03 Eli Zaretskii <eliz@gnu.org>
617 * xdisp.c (handle_invisible_prop): If the invisible text ends just
618 before a newline, prepare the bidi iterator for consuming the
619 newline, and keep the current paragraph direction. (Bug#10183)
620 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
622 2011-12-02 Juri Linkov <juri@jurta.org>
624 * search.c (Fword_search_regexp): New Lisp function created from
625 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
626 (Fword_search_backward, Fword_search_forward)
627 (Fword_search_backward_lax, Fword_search_forward_lax):
628 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
629 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
631 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
633 * fileio.c (Finsert_file_contents): Move after-change-function call
634 to before the "handled:" label, since all "goto handled" appear in
635 cases where the *-change-functions have already been properly called
638 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
640 * keyboard.c (interrupt_signal): Don't call kill-emacs when
641 waiting for input. (Bug#10169)
643 2011-11-30 Eli Zaretskii <eliz@gnu.org>
645 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
646 verifies glyph row's hash code--we have just reallocated the
647 glyphs, so their contents can be complete garbage. (Bug#10164)
649 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
651 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
653 2011-11-30 Eli Zaretskii <eliz@gnu.org>
655 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
656 attributes are tested _before_ calling verify_row_hash, to protect
657 against GCC re-ordering of the tests. (Bug#10164)
659 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
661 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
663 * xterm.c (handle_one_xevent): Only set async_visible and friends
664 if net_wm_state_hidden_seen is non-zero (Bug#10002)
665 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
666 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
668 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
670 Remove GCPRO-related macros that exist only to avoid shadowing locals.
671 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
672 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
673 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
674 All uses changed to use GCPRO1 etc.
675 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
676 Revert to old implementation (i.e., before 2011-03-11).
678 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
680 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
681 of scroll runs so as to avoid assigning disabled bogus rows and
682 unnecessary graphics copy operations.
684 2011-11-27 Eli Zaretskii <eliz@gnu.org>
686 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
687 (snprintf) [_MSC_VER]: Redirect to _snprintf.
688 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
689 (malloc, free, realloc, calloc): Redirect to e_* only when
692 * lisp.h (GCTYPEBITS): Move before first use.
693 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
694 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
695 this macro definition.
697 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
700 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
702 * gtkutil.c (xg_create_frame_widgets):
703 Call gtk_window_set_has_resize_grip (FALSE) if that function is
704 present with Gtk+ 2.0.
706 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
708 * fileio.c (Finsert_file_contents): Undo previous change; see
709 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
711 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
713 Rename locals to avoid shadowing.
714 * fileio.c (Finsert_file_contents):
715 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
716 * process.c (wait_reading_process_output):
717 Rename inner 'proc' to 'p' to avoid shadowing.
718 Indent for consistency with usual Emacs style.
720 2011-11-25 Eli Zaretskii <eliz@gnu.org>
722 * xdisp.c (redisplay_window): If cursor row is not fully visible
723 after recentering, and scroll-conservatively is set to a large
724 number, scroll window by a few more lines to make the cursor fully
725 visible and out of scroll-margin. (Bug#10105)
726 (start_display): Don't move to the next line if the display should
727 start at a newline that is part of a display vector or an overlay
730 2011-11-24 Juri Linkov <juri@jurta.org>
732 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
733 after the `MagickPingImage' call. (Bug#10112)
735 2011-11-23 Chong Yidong <cyd@gnu.org>
737 * window.c (Fcoordinates_in_window_p): Accept only live windows.
739 2011-11-23 Martin Rudalics <rudalics@gmx.at>
741 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
742 making another buffer current. (Bug#10114)
744 2011-11-23 Glenn Morris <rgm@gnu.org>
746 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
748 2011-11-23 Chong Yidong <cyd@gnu.org>
750 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
753 2011-11-22 Eli Zaretskii <eliz@gnu.org>
755 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
756 and header-lines, as they don't have one computed for them.
759 * .gdbinit (prow): Make displayed values more self-explaining.
762 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
764 * process.c (wait_reading_process_output): Fix asynchrounous
765 GnuTLS socket handling on some versions of the GnuTLS library.
766 (wait_reading_process_output): Add comment and URL.
768 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
770 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
772 2011-11-21 Chong Yidong <cyd@gnu.org>
774 * window.c (Fnext_window, Fprevious_window): Doc fix.
776 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
778 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
780 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
782 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
784 2011-11-20 Martin Rudalics <rudalics@gmx.at>
786 * window.c (Fset_window_combination_limit): Rename argument
788 (Vwindow_combination_limit): Remove "status" from doc-string.
790 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
792 * m/ibms390.h: Remove.
793 * m/ibms390x.h: Don't include "ibms390.h".
795 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
797 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
798 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
800 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
802 * casetab.c (Fset_case_table):
803 * charset.c (Fcharset_after): Fix typos.
805 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
807 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
808 Otherwise, valgrind does not work on some platforms.
809 Problem reported by Andreas Schwab in
810 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
811 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
812 is set, removing the need for VIRT_ADDRESS_VARIES.
813 (PURE_P): Use a more-efficient implementation that needs just one
814 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
815 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
816 to 4 (xorl, subq, cmpq, setbe).
817 * alloc.c (pure): Always extern now, since that's the
818 VIRT_ADDR_VARIES behavior.
819 (PURE_POINTER_P): Use a single comparison, not two, for
820 consistency with the new puresize.h.
821 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
822 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
823 Remove VIRT_ADDR_VARIES no longer needed.
825 2011-11-19 Eli Zaretskii <eliz@gnu.org>
827 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
828 (erase_phys_cursor, update_window_cursor, show_mouse_face)
829 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
830 behave as if the cursor position were at the window margin.
832 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
833 and the cursor position is out of bounds, behave as if the cursor
834 position were at the window margin. (Bug#10075)
836 2011-11-18 Chong Yidong <cyd@gnu.org>
838 * window.c (Fwindow_combination_limit): Make first argument
839 non-optional, since it is meaningless for live windows like the
842 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
844 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
846 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
848 * intervals.c: Fix grafting over the whole buffer (bug#10071).
849 (graft_intervals_into_buffer): Simplify.
851 2011-11-18 Eli Zaretskii <eliz@gnu.org>
853 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
854 hash values of the two rows.
855 (copy_row_except_pointers): Preserve the used[] arrays and the
856 hash values of the two rows. (Bug#10035)
857 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
859 * xdisp.c (row_hash): New function, body extracted from
860 compute_line_metrics.
861 (compute_line_metrics): Call row_hash, instead of computing the
864 * dispnew.c (verify_row_hash): Call row_hash for computing the
865 hash code of a row, instead of duplicating code from xdisp.c.
867 * dispextern.h (row_hash): Add prototype.
869 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
871 * frame.c (delete_frame): Don't delete the terminal when the last
872 X frame is closed if emacs is built with GTK toolkit.
874 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
876 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
878 2011-11-17 Martin Rudalics <rudalics@gmx.at>
880 * window.c (Vwindow_splits): Rename to
881 Vwindow_combination_resize. Suggested by Juri Linkov.
882 (Fsplit_window_internal): Use Vwindow_combination_resize instead
885 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
887 * nsfns.m (Fns_font_name):
888 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
890 2011-11-16 Martin Rudalics <rudalics@gmx.at>
892 * window.h (window): Rename slot "nest" to "combination_limit".
893 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
894 (Fset_window_nest): Rename to Fset_window_combination_limit.
895 (Vwindow_nest): Rename to Vwindow_combination_limit.
896 (recombine_windows, make_parent_window, make_window)
897 (Fsplit_window_internal, saved_window)
898 (Fset_window_configuration, save_window_save): Rename all
899 occurrences of window_nest to window_combination_limit.
901 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
903 * image.c (imagemagick_load_image): Fix typo.
905 2011-11-14 Eli Zaretskii <eliz@gnu.org>
907 * xdisp.c (display_line): Move the call to
908 highlight_trailing_whitespace before the call to
909 compute_line_metrics, since the latter needs to see the final
910 faces of all the glyphs to compute ROW's hash value.
911 Fixes assertion violations in row_equal_p. (Bug#10035)
913 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
915 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
916 just return (bug#10044).
918 2011-11-12 Eli Zaretskii <eliz@gnu.org>
920 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
921 with user-defined heap size. Bump the default size of the temacs
922 heap to 27MB, to avoid memory warning when running temacs.
923 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
925 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
926 current_matrix and desired_matrix. (Bug#9990)
927 (verify_row_hash) [XASSERTS]: New function.
928 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
929 that the hash value of glyph rows is correct.
931 2011-11-12 Martin Rudalics <rudalics@gmx.at>
933 * window.h (window): Remove splits slot.
934 * window.c (Fwindow_splits, Fset_window_splits): Remove.
935 (Fdelete_other_windows_internal, make_parent_window)
936 (make_window, Fsplit_window_internal, Fdelete_window_internal)
937 (Fset_window_configuration, save_window_save): Don't deal with
938 split status of windows.
939 (saved_window): Remove splits slot.
940 (Vwindow_splits): Rewrite doc-string.
942 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
944 * xfns.c (unwind_create_frame):
945 * nsfns.m (unwind_create_frame):
946 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
947 Vframe_list (Bug#9999).
949 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
951 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
953 2011-11-11 Kenichi Handa <handa@m17n.org>
955 * callproc.c (Fcall_process): Set the member dst_multibyte of
958 2011-11-11 Johan Bockgård <bojohan@gnu.org>
960 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
961 avoid a crash (bug#9496).
963 2011-11-09 Chong Yidong <cyd@gnu.org>
965 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
966 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
968 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
970 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
972 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
974 Avoid some portability problems by eschewing 'extern inline' functions.
975 The trivial performance wins aren't worth the portability hassles; see
976 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
978 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
979 (window_box_width, window_box_left, window_box_left_offset)
980 (window_box_right, window_box_right_offset): Undo previous change,
981 by removing the "extern"s.
982 * intervals.c (adjust_intervals_for_insertion)
983 (adjust_intervals_for_deletion): Undo previous change,
984 making these static again.
985 (offset_intervals, temp_set_point_both, temp_set_point)
986 (copy_intervals_to_string): No longer inline.
987 * xdisp.c (window_text_bottom_y, window_box_width)
988 (window_box_height, window_box_left_offset)
989 (window_box_right_offset, window_box_left, window_box_right)
990 (window_box): No longer inline.
992 2011-11-08 Chong Yidong <cyd@gnu.org>
994 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
995 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
996 Signal an error if not a live window.
997 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
998 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1000 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1002 * lisp.h (syms_of_abbrev): Remove declaration.
1003 Reported by CHENG Gao <chenggao@royau.me>.
1005 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1007 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1008 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1009 of temacs in GUI mode.
1011 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1013 * window.h: Declare delete_all_child_windows instead of
1014 delete_all_subwindows.
1015 * window.c (Fwindow_nest, Fset_window_nest)
1016 (Fset_window_new_total, Fset_window_new_normal)
1017 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1018 (delete_all_subwindows): Rename to delete_all_child_windows.
1019 (Fdelete_other_windows_internal, Fset_window_configuration):
1020 Call delete_all_child_windows instead of delete_all_subwindows.
1021 * frame.c (delete_frame): Call delete_all_child_windows instead
1022 of delete_all_subwindows.
1024 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1026 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1027 This is also needed for porting to any host where GC_MARK_STACK is
1028 not GC_MAKE_GCPROS_NOOPS.
1029 (which_symbols): Use it.
1031 2011-11-07 Kenichi Handa <handa@m17n.org>
1033 * coding.c (coding_set_destination): Check coding->src_pos only
1034 when coding->src_object is a buffer (bug#9910).
1036 * process.c (send_process): Set the member src_multibyte of coding
1037 to 0 (bug#9911) when sending a unibyte text.
1039 * callproc.c (Fcall_process): Set the member src_multibyte of
1040 process_coding to 0 (bug#9912).
1042 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1044 * xmenu.c (cleanup_widget_value_tree): New function.
1045 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1046 calling free_menubar_widget_value_tree directly (Bug#9830).
1048 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1050 Fix some portability problems with 'inline'.
1051 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1052 (window_box_width, window_box_left, window_box_left_offset)
1053 (window_box_right, window_box_right_offset): Declare extern.
1054 Otherwise, these inline functions do not conform to C99 and
1055 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1056 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1057 * intervals.c (adjust_intervals_for_insertion)
1058 (adjust_intervals_for_deletion): Now extern, because otherwise the
1059 extern inline functions 'offset_intervals' couldn't refer to it.
1060 (static_offset_intervals): Remove.
1061 (offset_intervals): Rewrite using the old contents of
1062 static_offset_intervals. The old version didn't conform to C99
1063 because an extern inline function contained a reference to an
1064 identifier with static linkage.
1066 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1068 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1071 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1073 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1074 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1075 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1076 return Qleft_to_right.
1078 2011-11-06 Chong Yidong <cyd@gnu.org>
1080 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1081 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1082 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1083 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1084 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1085 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1086 (Fwindow_vscroll): Doc fix.
1087 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1088 argument, since it makes no sense to pass a live window and for
1089 consistency with window-child.
1091 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1093 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1096 2011-11-05 Jason Rumney <jasonr@gnu.org>
1098 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1099 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1101 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1102 bitwise arithmetic preventing use of unicode-sip and non-truetype
1105 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1107 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1110 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1111 initialization code to keep similarity to xfns.c after changes
1114 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1116 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1117 (unwind_create_frame): New function (Bug#9943).
1118 (Fx_create_frame): Restructure code to be more similar to the one in
1119 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1120 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1121 Move terminal->reference_count++ just before making the frame official
1124 * nsterm.m (x_free_frame_resources): New function.
1125 (x_destroy_window): Move code to x_free_frame_resources.
1127 * xfns.c (unwind_create_frame): Fix comment.
1128 (Fx_create_frame, x_create_tip_frame):
1129 Move terminal->reference_count++ just before making the frame
1130 official. Move initialization of image_cache_refcount and
1131 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1133 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1135 Support MSVC build with newer versions of Visual Studio.
1136 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1137 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1140 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1141 which are not supported by MSVC.
1142 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1143 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1145 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1147 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1149 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1151 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1153 Support MSVC build with newer versions of Visual Studio.
1154 * w32.c: Don't include w32api.h for MSVC.
1155 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1157 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1158 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1159 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1160 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1162 (alloca) [_MSC_VER]: Define to _alloca.
1164 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1166 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1168 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1170 * xdisp.c (note_mouse_highlight): If either of
1171 previous/next-single-property-change returns nil, treat that as
1172 the beginning or the end of the buffer. (Bug#9955)
1174 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1176 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1177 label is not null (Bug#9951).
1178 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1181 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1183 * window.c (Fwindow_body_size): Mention in the doc string that the
1184 return value is in frame's canonical units. (Bug#9949)
1186 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1188 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1190 * w32fns.c (unwind_create_frame): If needed, free the glyph
1191 matrices of the partially constructed frame. (Bug#9943)
1192 * xfns.c (unwind_create_frame): Likewise.
1194 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1196 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1197 Don't stop backward scan on the continuation glyph, even though
1198 its CHARPOS is positive.
1199 (mouse_face_from_buffer_pos, note_mouse_highlight):
1200 Rename cover_string to disp_string.
1202 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1204 * window.c (temp_output_buffer_show): Don't use
1205 Vtemp_buffer_show_specifiers.
1206 (Vtemp_buffer_show_specifiers): Remove unused variable.
1208 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1210 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1211 past the beginning of the current glyph matrix.
1213 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1215 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1216 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1217 HAVE_GTK3 (Bug#9869).
1219 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1220 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1222 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1224 * xterm.c: Declare x_handle_net_wm_state to return int.
1225 (handle_one_xevent): Check if we are iconified but don't have
1226 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1227 (get_current_wm_state): Return non-zero if not hidden,
1228 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1229 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1230 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1231 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1233 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1235 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1236 so that this new function doesn't get optimized away by a
1237 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1239 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1241 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1243 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1245 Fix the `xbytecode' command.
1246 * .gdbinit (xprintbytestr): New command.
1247 (xwhichsymbols): Rename from `which'; all callers changed.
1248 (xbytecode): Print the byte-code string as well.
1250 2011-10-29 Kim Storm <storm@cua.dk>
1252 * alloc.c (which_symbols): New function.
1254 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1256 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1259 2011-10-29 Glenn Morris <rgm@gnu.org>
1261 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1262 Not clear what it was for, and it causes various bugs. (Bug#9839)
1264 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1266 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1267 possible random value that matches one of those tested as
1268 condition to clear the mouse face.
1270 2011-10-28 Chong Yidong <cyd@gnu.org>
1272 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1274 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1276 * window.c (make_window): Initialize phys_cursor_on_p.
1278 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1280 * lisp.h (struct Lisp_Symbol): Update comments.
1282 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1284 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1286 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1288 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1289 <oslsachem@gmail.com> for helping to debug this.
1291 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1292 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1293 (g_b_init_get_glyph_outline_w): New static variables.
1294 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1295 (GetGlyphOutlineW_Proc): New typedefs.
1296 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1297 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1299 (w32font_open_internal, compute_metrics):
1300 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1301 instead of calling the "wide" APIs directly.
1303 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1305 * w32.h (syms_of_w32font): Add prototype.
1307 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1309 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1310 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1311 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1312 (Fmove_to_window_line): Doc fix.
1314 2011-10-27 Chong Yidong <cyd@gnu.org>
1316 * process.c (make_process): Set gnutls_state to NULL.
1318 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1319 non-NULL, regardless of GNUTLS_INITSTAGE.
1320 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1321 an error. Set process slots as soon as we allocate them.
1323 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1325 2011-10-27 Chong Yidong <cyd@gnu.org>
1327 * gnutls.c (emacs_gnutls_deinit): New function.
1328 Deallocate credentials structures as well as calling gnutls_deinit.
1329 (Fgnutls_deinit, Fgnutls_boot): Use it.
1331 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1332 (deactivate_process): Call emacs_gnutls_deinit.
1334 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1336 * image.c (x_create_x_image_and_pixmap):
1337 * w32.c (sys_rename, w32_delayed_load):
1338 * w32font.c (fill_in_logfont):
1339 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1341 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1343 * w32fns.c (w32_default_color_map): New function,
1344 extracted from Fw32_default_color_map.
1345 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1347 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1349 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1351 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1353 * keyboard.c (test_undefined): New function (bug#9751).
1354 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1356 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1358 * sysdep.c (init_sys_modes): Fix the check for the controlling
1359 terminal (Bug#6649).
1361 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1363 * dispextern.h (struct bidi_it): New member next_en_type.
1365 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1366 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1367 current character, check also for next_en_type being WEAK_EN.
1368 (bidi_resolve_weak): Don't enter the expensive loop if the current
1369 position is before next_en_pos. Record the bidi type of the first
1370 non-ET, non-BN character we find, in addition to its position.
1371 (bidi_level_of_next_char): Invalidate next_en_type when
1372 next_en_pos is over-stepped.
1374 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1376 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1377 * editfns.c: Rewrite current-time-zone so that it invokes
1378 the equivalent of (format-time-string "%Z") to get the time zone name.
1379 This fixes a bug when the time zone name contains characters that
1380 need converting from the system time locale to Emacs internal format.
1381 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1382 that patch fixed format-time-string to do the conversion, but
1383 I forgot to fix current-time-zone.
1384 (format_time_string): New function, containing most of
1385 what Fformat_time_string used to contain.
1386 (Fformat_time_string): Rewrite in terms of format_time_string.
1387 This doesn't change this function's behavior.
1388 (current-time-zone): Rewrite to use format_time_string.
1389 This fixes the bug reported by Michael Schierl in
1390 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1391 Jason Rumney's 2007-06-07 change worked around this bug, but
1393 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1395 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1397 * xdisp.c (start_display): If the character at POS is displayed
1398 via a display vector, reset IT->current.dpvec_index to zero.
1399 (try_window_reusing_current_matrix): If a line ends in a display
1400 vector or the next line starts in a display vector, continue
1401 redrawing the window even though the character position of
1402 start_row was reached.
1405 2011-10-18 Chong Yidong <cyd@gnu.org>
1407 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1408 with nobreak-char-display too.
1410 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1412 Fix part 3 of bug#9771.
1413 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1414 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1415 non-neutral characters if the current character is a paragraph
1416 separator (a.k.a. Newline). This avoids running the same
1417 expensive loop twice, once when we consume the preceding newline
1418 and the other time when the line actually needs to be displayed.
1419 Avoid the loop when we see neutrals on the base embedding level
1420 following a character whose directionality is the same as the
1421 paragraph's. This avoids running the expensive loop when a line
1422 ends in a long sequence of neutrals, like control characters.
1423 Add assertion against STRONG_AL type. Slightly rearrange code
1424 that determines the type of a neutral given the first non-neutral
1426 (bidi_level_of_next_char): Set next_en_pos to zero when
1427 invalidating its info.
1429 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1431 * xdisp.c (push_display_prop): Determine whether to record string
1432 or buffer position by IT->string, not by IT->method. Allow
1433 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1434 (move_it_vertically_backward): Don't look for character position
1435 immediately after the newline when in a continuation line.
1438 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1440 * window.c (coordinates_in_window): Rewrite and delabelize
1441 vertical border check. (Bug#5357) (Bug#9618)
1443 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1445 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1446 errors in XSetWindowBorder (bug#9310).
1448 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1450 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1451 avoid crash when xmalloc overrun checking is enabled.
1453 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1455 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1456 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1457 cursor motion with <left> and <right> arrow keys.
1459 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1460 some callers set that themselves.
1462 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1464 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1465 display string and the previous row comes from the same string and
1466 is empty. (Bug#9739) (Bug#9738)
1468 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1470 * doc.c (get_doc_string): Encode file name (bug#9735).
1472 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1474 * bidi.c (bidi_level_of_next_char):
1475 * xdisp.c (get_visually_first_element): Remove old incorrect
1476 comments regarding the Unicode Line Separator character.
1478 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1480 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1482 * alloc.c (Fgc_status): Do not access beyond zombies array
1483 boundary if nzombies > MAX_ZOMBIES.
1484 * alloc.c (dump_zombies): Add missing format specifier.
1486 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1488 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1489 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1491 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1492 Some packages use them to denote characters with modifiers.
1494 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1496 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1497 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1498 matching a pp-number. Rename parameter var to var1.
1500 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1502 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1504 2011-10-08 Glenn Morris <rgm@gnu.org>
1506 * callint.c (Fcall_interactively): Give a more explicit error for the
1507 'c' case with a non-character input. (Bug#8479)
1509 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1511 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1513 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1514 lines that are hscrolled on the left.
1516 * dispnew.c (buffer_posn_from_coords): Account for a possible
1517 presence of header-line. (Bug#4426)
1519 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1521 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1522 Don't advertise functionality which we discourage or doesn't work.
1524 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1526 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1527 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1528 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1529 this makes Emacs dump core during garbage collection on rare
1530 occasions. sizeof is obviously inferior to offsetof here, so
1531 stick with offsetof.
1532 (GC_POINTER_ALIGNMENT): New macro.
1533 (mark_memory): Omit 3rd (offset) arg; caller changed.
1534 Don't assume EMACS_INT alignment is the same as pointer alignment.
1536 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1538 * keyboard.c (read_key_sequence_remapped): New var.
1539 (read_key_sequence): Compute remapping in the right buffer.
1540 (command_loop_1): Use read_key_sequence's remapping directly.
1542 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1544 * dired.c (file_name_completion): Don't expand file name.
1545 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1546 before checking file name handler.
1548 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1549 they've been requested explicitly (bug#9591).
1551 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1553 * keymap.c (Fsingle_key_description): Use make_specified_string
1554 instead of build_string to build string from push_key_description.
1557 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1559 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1560 This fixes a Y2038 bug on 64-bit hosts.
1561 * buffer.c (reset_buffer):
1562 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1563 (Fclear_buffer_auto_save_failure):
1564 Use 0, not -1, to represent an unset failure time, since time_t
1565 might not be signed.
1567 Remove dependency on glibc malloc internals.
1568 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1569 Move back here from lisp.h, but with their new implementations.
1570 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1571 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1572 * charset.c (charset_table_init): New static var.
1573 (syms_of_charset): Use it instead of xmalloc. This removes a
1574 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1575 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1576 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1577 Move back to alloc.c.
1578 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1579 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1581 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1583 * nsterm.m (windowDidResize): Call x_set_window_size only when
1584 ns_in_resize is true. Otherwise set pixelwidth/height and
1585 call change_frame_size (Bug#9628).
1587 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1589 Port --enable-checking=all to Fedora 14 x86-64.
1590 * charset.c (syms_of_charset): Also account for glibc malloc's
1591 internal overhead when calculating the initial malloc maximum.
1593 Port --enable-checking=all to Fedora 14 x86.
1594 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1596 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1597 (overrun_check_realloc, overrun_check_free):
1598 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1599 That way, xmalloc returns a properly-aligned pointer even if
1600 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1601 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1602 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1603 into account when calculating the initial malloc maximum.
1604 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1605 Move here from alloc.c, so that charset.c can use it too.
1606 Properly align; the old code wasn't right for common 32-bit hosts
1607 when configured with --enable-checking=all.
1608 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1609 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1611 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1613 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1616 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1618 * xdisp.c (compute_display_string_end): If there's no display
1619 string at CHARPOS, return -1.
1621 * bidi.c (bidi_fetch_char): When compute_display_string_end
1622 returns a negative value, treat the character as a normal
1623 character not covered by a display string. (Bug#9624)
1625 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1627 * lread.c (Fread_from_string): Fix typo in docstring.
1629 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1631 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1632 newline, reseat the iterator instead of bidi-iterating there one
1633 character at a time. (Bug#9610)
1634 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1635 TO_CHARPOS if the bidi iterator is at base embedding level.
1637 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1639 * lread.c (readevalloop): Use correct code for NBSP.
1640 (read1): Likewise. (Bug#9608)
1642 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1644 * dbusbind.c (Fdbus_register_signal): When service is not
1645 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1647 2011-09-25 Glenn Morris <rgm@gnu.org>
1649 * buffer.c (truncate-lines): Doc fix.
1651 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1653 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1654 (Fset_window_next_buffers): Doc fix.
1656 2011-09-24 Glenn Morris <rgm@gnu.org>
1658 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1660 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1662 Fix minor problems found by static checking.
1663 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1664 * indent.c (Fvertical_motion): Fix == vs = typo.
1666 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1668 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1669 Default value is now t. Doc fix.
1671 * indent.c (Fvertical_motion): Compute and apply the overshoot
1672 logic when moving up, not only when moving down. Fix the
1673 confusing name and values of the it_overshoot_expected variable;
1674 logic changes accordingly. (Bug#9254) (Bug#9549)
1676 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1677 CHARPOS is covered by a display string which includes newlines.
1678 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1679 is covered by a display string with embedded newlines.
1681 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1683 * dbusbind.c (Fdbus_register_signal): Add match rule to
1684 Vdbus_registered_objects_table. (Bug#9581)
1685 (Fdbus_register_method, Vdbus_registered_objects_table):
1688 2011-09-24 Jim Meyering <meyering@redhat.com>
1690 do not ignore write error for any output size
1691 The previous change was incomplete.
1692 While it makes emacs --batch detect the vast majority of stdout
1693 write failures, errors were still ignored whenever the output size is
1694 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1695 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1696 && echo FAIL: ignored write error
1697 FAIL: ignored write error
1698 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1699 && echo FAIL: ignored write error
1700 FAIL: ignored write error
1701 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1703 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1705 * emacs.c (Fkill_emacs): In noninteractive mode exit
1706 non-successfully if a write error occurred on stdout. (Bug#9574)
1708 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1710 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1713 * dispextern.h (struct it): Update the comment documenting what
1716 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1718 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1719 a display string, extend search for cursor position to end of row.
1720 (find_row_edges): If the row ends in a newline from a display
1721 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1722 Handle the case of a display string with multiple newlines.
1723 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1724 non-empty line. Fixes confusing cursor motion with arrow keys at
1725 the beginning of a line that starts with whitespace.
1727 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1729 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1732 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1734 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1737 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1739 * xdisp.c (display_line): Record maximum and minimum buffer
1740 positions even if no glyphs were produced (e.g., by a zero-width
1741 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1742 buffer positions that will be removed from the glyph row because
1744 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1745 column is beyond frame width: don't subtract 1 "pixel" when
1746 computing width of the stretch.
1747 (reseat_at_next_visible_line_start): Undo the change made on
1748 2011-09-17 that saved paragraph information and restored it after
1749 the call to `reseat'. (Bug#9545)
1751 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1753 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1754 and turn window cursor on if cleared (Bug#9415).
1756 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1758 * search.c (boyer_moore): Take unibyte characters from pattern
1759 literally. (Bug#9458)
1761 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1763 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1765 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1767 Fix minor problem found by static checking.
1768 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1769 initialized, to pacify gcc -Wuninitialized.
1771 * fileio.c: Report proper errno when syscall falls.
1772 (Finsert_file_contents): Save and restore errno,
1773 so that report_file_error outputs the correct diagnostic.
1774 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1776 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1778 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1780 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1782 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1783 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1785 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1787 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1788 about the current paragraph and restore it after the call to reseat.
1790 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1791 (bidi_find_paragraph_start): Search back for paragraph beginning
1792 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1793 (bidi_move_to_visually_next): Only trigger paragraph-related
1794 computations when the last character is a newline or at EOB, not
1795 just any NEUTRAL_B. (Bug#9470)
1797 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1798 truncated lines if point is covered by a display string. (Bug#9524)
1800 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1802 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1803 (cons_to_x_long): New function.
1804 (lisp_data_to_selection_data): Use it. Correct the test for
1805 short-versus-long data; it was negated. Break out of vector
1806 loop, for efficiency, when a long datum is discovered.
1808 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1810 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1812 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1814 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1815 GCC PR/17406) by declaring this function with external scope.
1817 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1819 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1820 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1822 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1824 * editfns.c (Fformat): Correctly handle text properties on "%%".
1826 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1828 * xterm.c (x_draw_composite_glyph_string_foreground):
1829 * w32term.c (x_draw_composite_glyph_string_foreground):
1830 * term.c (encode_terminal_code):
1831 * composite.c (composition_update_it, get_composition_id):
1832 * xdisp.c (get_next_display_element)
1833 (fill_composite_glyph_string): Add comments about special meaning
1834 of TAB characters in a composition.
1836 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1838 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1839 This occurs when processing a multibyte format.
1840 Problem reported by Wolfgang Jenker.
1842 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1844 * xdisp.c (try_cursor_movement): Only check for exact match if
1845 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1847 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1849 Remove unused external symbols.
1850 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1851 * xdisp.c (calc_pixel_width_or_height): Now static.
1852 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1853 * indent.c (check_display_width):
1854 * w32term.c: Fix comment to match code.
1855 * xterm.c, xterm.h (x_catching_errors): Remove.
1857 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1859 * xselect.c: Use signed conversions more consistently (Bug#9498).
1860 (selection_data_to_lisp_data): Assume incoming selection data are
1861 signed integers, not unsigned. This is to be consistent with
1862 outgoing selection data, which was modified to use signed integers
1863 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1864 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1865 expects long, not unsigned long.
1867 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1869 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1870 computation of loop end. Reported by Johan Bockgård
1873 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1875 * frame.c (Fother_visible_frames_p): Function deleted.
1877 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1879 * indent.c (compute_motion): Process display vector front to back
1880 rather than the other way around. (Bug#2496)
1882 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1884 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1886 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1888 * minibuf.c (Fread_from_minibuffer): Doc fix.
1890 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1892 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1893 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1895 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1897 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1898 value for non-existent files.
1900 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1902 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1903 set its "size" to -1. This will set the modtime_size field of
1904 the corresponding buffer to -1, which is what
1905 verify-visited-file-modtime expects for files that do not exist.
1908 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1910 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1912 * lisp.h: ... from here. push_key_description is no longer
1913 defined in keyboard.c, so its declaration should not be in
1914 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1915 logically belongs with push_key_description.
1917 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1919 * buffer.h: Include <sys/types.h> instead of <time.h>.
1920 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1921 Problem reported by Herbert J. Skuhra.
1923 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1925 * xml.c (parse_region): Make the parsing work for
1926 non-comment-starting XML files again (bug#9144).
1928 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1930 * image.c (gif_load): Fix calculation of bottom and right corner.
1933 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1935 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1936 redisplay in small windows.
1938 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1940 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1942 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1944 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1945 Operate on live windows only.
1947 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1949 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1951 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1953 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1954 only under bidi iteration.
1956 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1958 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1960 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1962 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1963 Without this fix, the command to link temacs failed due to an
1964 undefined symbol __builtin_isnan. This is because
1965 /usr/include/iso/math_c99.h #defines isnan(x) to
1966 __builtin_isnan(x), but the bundled gcc, which identifies itself
1967 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1969 * floatfns.c (isnan): #undef, and then #define to a clone of
1971 (Fisnan): Always define, since it's always available now.
1972 (syms_of_floatfns): Always define isnan at the Lisp level.
1974 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1976 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1978 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1980 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1981 The previous code assumed that file offsets (off_t values) fit in
1982 EMACS_INT variables, which is not true on typical 32-bit hosts.
1983 The code messed up by falsely reporting buffer overflow in cases
1984 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1985 when "big" contains more than 2**29 bytes, even though this
1986 inserts just one byte and does not overflow the buffer.
1987 (Finsert_file_contents): Store file offsets as off_t
1988 values, not as EMACS_INT values. Check for overflow when
1989 converting between EMACS_INT and off_t. When checking for
1990 buffer overflow or for overlap, take the offsets into account.
1991 Don't use EMACS_INT for small values where int suffices.
1992 When checking for overlap, fix a typo: ZV was used where
1993 ZV_BYTE was intended.
1994 (Fwrite_region): Don't assume off_t fits into 'long'.
1995 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1997 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1999 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2001 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2003 sprintf-related integer and memory overflow issues (Bug#9412).
2005 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2006 (esprintf, exprintf, evxprintf): New functions.
2007 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2008 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2009 (modify_event_symbol): Do not assume that the length of
2010 name_alist_or_stem is safe to alloca and fits in int.
2011 (Fexecute_extended_command): Likewise for function name and binding.
2012 (Frecursion_depth): Wrap around reliably on integer overflow.
2013 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2014 since some callers pass EMACS_INT values.
2015 (Fsingle_key_description): Don't crash if symbol name contains more
2016 than MAX_ALLOCA bytes.
2017 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2018 (get_minibuffer): Arg is now EMACS_INT, not int.
2019 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2020 (esprintf, exprintf, evxprintf): New decls.
2021 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2023 * dbusbind.c (signature_cat): New function.
2024 (xd_signature, Fdbus_register_signal):
2025 Do not overrun buffer; instead, report string overflow.
2027 * dispnew.c (add_window_display_history): Don't overrun buffer.
2028 Truncate instead; this is OK since it's just a log.
2030 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2031 even if the time zone offset is outlandishly large.
2032 Don't mishandle offset == INT_MIN.
2034 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2035 when creating daemon; the previous buffer-overflow check was incorrect.
2037 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2038 which has the guts of the old verror function.
2040 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2041 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2043 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2044 (font_unparse_xlfd): Don't blindly alloca long strings.
2045 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2046 fits in int, when using sprintf. Use single snprintf to count
2047 length of string rather than counting it via multiple sprintfs;
2048 that's simpler and more reliable.
2049 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2050 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2051 sprintf, in case result does not fit in int.
2053 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2054 (fontset_from_font): Print it.
2056 * frame.c (tty_frame_count): Now printmax_t, not int.
2057 (make_terminal_frame, set_term_frame_name): Print it.
2058 (x_report_frame_params): In X, window IDs are unsigned long,
2059 not signed long, so print them as unsigned.
2060 (validate_x_resource_name): Check for implausibly long names,
2061 and don't assume name length fits in 'int'.
2062 (x_get_resource_string): Don't blindly alloca invocation name;
2063 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2066 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2067 (xg_check_special_colors, xg_set_geometry):
2068 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2070 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2071 Use esprintf, not sprintf, in case result does not fit in int.
2073 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2074 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2075 it as a large positive number.
2076 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2077 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2079 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2080 in case result does not fit in int.
2082 * print.c (float_to_string): Detect width overflow more reliably.
2083 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2084 buffer overrun. Don't assume list length fits in 'int'. Treat
2085 print length of 0 as 0, not as infinity; to be consistent with other
2086 uses of print length in this function. Don't overflow print length
2087 index. Don't assume hash table size fits in 'long', or that
2088 vectorlike size fits in 'unsigned long'.
2090 * process.c (make_process): Use printmax_t, not int, to format
2091 process-name gensyms.
2093 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2095 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2096 to avoid potential buffer overrun.
2098 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2099 if X resource line is longer than 512 bytes.
2101 * xfns.c (x_window): Make sprintf buffer a bit bigger
2102 to avoid potential buffer overrun.
2104 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2106 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2108 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2110 Integer overflow fixes for scrolling, etc.
2111 Without these, Emacs silently mishandles large integers sometimes.
2112 For example, "C-u 4294967297 M-x recenter" was treated as if
2113 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2115 * xdisp.c (try_window_id): Check Emacs fixnum range before
2116 converting to 'int'.
2118 * window.c (window_scroll_line_based, Frecenter):
2119 Check that an Emacs fixnum is in range before assigning it to 'int'.
2120 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2121 values converted from Emacs fixnums.
2122 (Frecenter): Don't wrap around a line count if it is out of 'int'
2123 range; instead, treat it as an extreme value.
2124 (Fset_window_configuration, compare_window_configurations):
2125 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2127 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2128 that can exceed INT_MAX. Check that EMACS_INT value is in range
2129 before assigning it to the (possibly-narrower) index.
2130 (match_limit): Don't assume that a fixnum can fit in 'int'.
2132 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2135 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2136 (Fvertical_motion): Don't wrap around LINES values that don't fit
2137 in 'int'. Instead, treat them as extreme values. This is good
2138 enough for windows, which can't have more than INT_MAX lines anyway.
2140 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2142 * Require libxml/parser.h to avoid compilation warning.
2144 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2146 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2147 since this reportedly can destroy thread storage.
2149 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2151 * syntax.c (find_defun_start): Update all cache variables if
2152 exiting early (Bug#9401).
2154 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2156 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2158 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2159 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2160 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2162 * term.c (tty_append_glyph): New function.
2163 (produce_stretch_glyph): Static function and its prototype deleted.
2165 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2168 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2170 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2171 when checking :margin (Bug#9390).
2172 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2173 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2174 so that the name doesn't mislead. All uses changed.
2176 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2178 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2181 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2183 * xdisp.c (move_it_to): Don't bail out early when reaching
2184 position beyond to_charpos, if we are scanning backwards.
2185 (move_it_vertically_backward): When DY == 0, make sure we get to
2186 the first character in the line after the newline.
2188 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2190 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2191 (ccl_driver): Do not generate an out-of-range pointer.
2192 (Fccl_execute_on_string): Remove unnecessary check for
2193 integer overflow, noted by Stefan Monnier in
2194 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2195 Remove a FIXME that didn't need fixing.
2196 Simplify the newly-introduced buffer reallocation code.
2198 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2200 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2202 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2204 Integer and memory overflow issues (Bug#9196).
2206 * doc.c (get_doc_string): Rework so that
2207 get_doc_string_buffer_size is the actual buffer size, rather than
2208 being 1 less than the actual buffer size; this makes xpalloc more
2211 * image.c (x_allocate_bitmap_record, cache_image):
2212 * xselect.c (Fx_register_dnd_atom):
2213 Simplify previous changes by using xpalloc.
2215 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2216 since either will do and ptrdiff_t is convenient with xpalloc.
2218 * charset.c (charset_table_size)
2219 (struct charset_sort_data.priority): Now ptrdiff_t.
2220 (charset_compare): Don't overflow if priorities differ greatly.
2221 (Fsort_charsets): Don't assume list length fits in int.
2222 Check for size-calculation overflow when allocating sort data.
2223 (syms_of_charset): Allocate an initial charset table that is
2224 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2226 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2228 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2229 The actual value is always <= INT_MAX, and leaving it unsigned made
2230 overflow checking harder.
2232 * dispextern.h (struct glyph_matrix.rows_allocated)
2233 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2234 with xpalloc. The values are still always <= INT_MAX.
2236 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2238 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2239 (SAFE_NALLOCA): New macro.
2241 * region-cache.c (struct boundary.pos, find_cache_boundary)
2242 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2243 (set_cache_region, invalidate_region_cache)
2244 (revalidate_region_cache, know_region_cache, region_cache_forward)
2245 (region_cache_backward, pp_cache):
2246 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2247 so that ptrdiff_t * can be passed to xpalloc.
2248 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2249 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2250 (pp_cache): Don't assume cache_len fits in int.
2251 * region-cache.h: Adjust extern decls to match.
2253 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2254 EMACS_INT, since either will do, for xpalloc.
2256 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2257 (xnmalloc, xnrealloc, xpalloc): New functions.
2259 * bidi.c (bidi_shelve_header_size): New constant.
2260 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2261 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2263 * bidi.c (bidi_cache_shrink):
2264 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2266 Don't update size of array until after memory allocation succeeds,
2267 because xmalloc/xrealloc may not return.
2268 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2269 now that we have proper integer overflow checking.
2270 (record_overlay_string, overlay_strings): Catch overflows when
2271 calculating size of overlay_str_buf.
2273 * callproc.c (Fcall_process): Check for size overflow when
2274 calculating size of args2.
2275 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2276 Normally we prefer signed values, but sticking with ptrdiff_t would
2277 require adding more-complicated checks.
2279 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2280 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2281 Redo buffer-overflow calculations to avoid integer overflow.
2282 Add a FIXME comment where memory seems to be over-allocated.
2284 * character.c (Fstring): Check for size-calculation overflow.
2286 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2287 unnecessary integer overflow. Check for size overflow.
2288 (encode_coding_object): Don't update size until xmalloc succeeds.
2290 * composite.c (get_composition_id): Check for overflow in glyph
2291 length calculations.
2293 Integer and memory overflow fixes for display code.
2294 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2295 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2296 (scrolling_window): Check for overflow in size calculations.
2297 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2298 Don't assume glyph table len fits in int.
2299 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2300 (row_table_size): Now ptrdiff_t, not int.
2301 (scrolling_window): Avoid overflow in size calculations.
2302 Don't update size until allocation succeeds.
2303 * fns.c (concat): Check for overflow in size calculations.
2304 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2305 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2306 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2308 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2309 (get_doc_string): Check for size calculation overflow.
2310 Don't update size until allocation succeeds.
2311 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2312 EMACS_INT, where ptrdiff_t will do.
2313 (Fsubstitute_command_keys): Check for string overflow.
2315 * editfns.c (set_time_zone_rule): Don't assume environment length
2317 (message_length): Now ptrdiff_t, not int.
2318 (Fmessage_box): Don't update size until allocation succeeds.
2319 Don't assume message length fits in int.
2320 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2322 * emacs.c (main): Do not reallocate argv, since there is a null at
2323 the end that can be overwritten, and this way there's no need to
2324 worry about size-calculation overflow.
2325 (sort_args): Check for size-calculation overflow.
2327 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2329 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2331 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2332 (x_set_scroll_bar_width, x_figure_window_size):
2333 Check for integer overflow.
2334 (x_set_alpha): Do not assume XINT fits in int.
2336 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2337 This is for the members text_lines, text_cols, total_lines, total_cols,
2338 where the system imposes an 'int' limit.
2340 * fringe.c (Fdefine_fringe_bitmap):
2341 Don't update size until alloc works.
2343 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2344 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2346 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2347 Check for size-calculation overflow.
2348 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2349 do, as we prefer signed integers.
2350 (id_to_widget.max_size, id_to_widget.used)
2351 (xg_store_widget_in_map, xg_remove_widget_from_map)
2352 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2353 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2354 Use and return ptrdiff_t, not int.
2355 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2356 * gtkutil.h: Change prototypes to match the above.
2358 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2359 are duplicate now that they've been promoted to lisp.h.
2360 (x_allocate_bitmap_record, x_alloc_image_color)
2361 (make_image_cache, cache_image, xpm_load):
2362 Don't update size until alloc is done.
2363 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2365 Check for size calculation overflow.
2366 (ct_colors_allocated_max): New constant.
2367 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2370 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2371 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2372 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2373 Use ptrdiff_t, not int, to count maps.
2374 (read_char_minibuf_menu_prompt): Check for overflow in size
2375 calculations. Don't update size until allocation succeeds.
2376 Redo calculations to avoid overflow.
2377 * keyboard.h: Change prototypes to match the above.
2379 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2381 (current_minor_maps): Check for size calculation overflow.
2382 * keymap.h: Change prototypes to match the above.
2384 * lread.c (read1, init_obarray): Don't update size until alloc done.
2386 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2387 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2389 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2390 Now ptrdiff_t, not int.
2391 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2392 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2394 * process.c (Fnetwork_interface_list): Check for overflow
2395 in size calculation.
2397 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2399 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2400 overflow. Don't bother calling xmalloc when xrealloc will do.
2402 * search.c (Freplace_match): Check for size calculation overflow.
2403 (Fset_match_data): Don't assume list lengths fit in 'int'.
2405 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2406 for command line length. Do not attempt to address one before the
2407 beginning of an array, as that's not portable.
2409 * term.c (max_frame_lines): Remove; unused.
2410 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2412 (encode_terminal_code, calculate_costs): Check for size
2413 calculation overflow.
2414 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2415 table lengths and related sizes. Don't update size until alloc
2416 done. Redo calculations to avoid overflow.
2417 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2419 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2420 subtracting pointers.
2421 (gobble_line): Check for overflow more carefully. Don't update size
2424 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2425 Don't update size until alloc done.
2426 Redo size calculations to avoid overflow.
2427 Check for size calculation overflow.
2428 (main) [DEBUG]: Fix typo in invoking tparam1.
2430 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2431 Use ptrdiff_t, not int, for sizes.
2432 (store_mode_line_noprop_char): Don't update size until alloc done.
2434 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2435 Use ptrdiff_t, not int, for sizes.
2436 (Finternal_make_lisp_face, cache_face):
2437 Check for size calculation overflow.
2438 (cache_face): Treat size calculation overflows as if they were
2439 memory exhaustion (the usual treatment), rather than aborting.
2441 * xfns.c (x_encode_text, x_set_name_internal)
2442 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2443 sizes, since they can exceed INT_MAX in size. Check for size
2444 calculation overflow.
2446 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2447 (xg_select): Check for size calculation overflow.
2448 Don't update size until alloc done.
2450 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2451 as sprintf is limited to int lengths.
2453 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2454 (X_LONG_MIN): New macros.
2455 Use them to make the following changes clearer.
2456 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2457 This change doesn't affect the value now, but it may help remind
2458 future maintainers not to raise the value too much later.
2459 (SELECTION_QUANTUM): Remove, replacing with ...
2460 (selection_quantum): ... new function, which avoids overflow.
2462 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2463 assumption that selection length fits in 'int'.
2464 (x_reply_selection_request, x_handle_selection_request)
2465 (x_get_window_property, receive_incremental_selection)
2466 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2467 (lisp_data_to_selection_data, clean_local_selection_data):
2468 Use ptrdiff_t, not int, to record length of selection.
2469 (x_reply_selection_request, x_get_window_property)
2470 (receive_incremental_selection, x_property_data_to_lisp):
2471 Redo calculations to avoid overflow.
2472 (x_reply_selection_request): When sending hint, ceiling it at
2473 X_LONG_MAX rather than relying on wraparound overflow to send
2475 (x_get_window_property, receive_incremental_selection)
2476 (lisp_data_to_selection_data, x_property_data_to_lisp):
2477 Check for size-calculation overflow.
2478 (x_get_window_property, receive_incremental_selection)
2479 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2480 Don't store size until memory allocation succeeds.
2481 (x_get_window_property): Plug memory leak on memory exhaustion.
2482 Don't double-block input; malloc is safe here. Don't assume 2**34
2483 - 4 fits in unsigned long. Add an xassert to check
2484 XGetWindowProperty overflow. Be more careful about overflow
2485 calculations, and distinguish size from memory overflow better.
2486 (receive_incremental_selection): When tracing, don't assume
2487 unsigned int is less than INT_MAX.
2488 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2489 harmful) conversions of unsigned short to int.
2490 (lisp_data_to_selection_data): Don't assume that integers
2491 in the range -65535 through -1 fit in an X unsigned short.
2492 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2493 result parameters unless successful. Rely on cons_to_unsigned
2494 to report problems with elements; the old code wasn't right anyway.
2495 (x_check_property_data): Check for int overflow; we cannot use
2496 a wider type due to X limits.
2497 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2499 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2501 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2502 (x_term_init): Check for size calculation overflow.
2503 (x_color_cells): Don't store size until memory allocation succeeds.
2504 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2505 Don't assume alloca size is less than MAX_ALLOCA.
2506 (x_term_init): Don't assume length fits in int (sprintf is limited
2509 Use ptrdiff_t for composition IDs.
2510 * character.c (lisp_string_width):
2511 * composite.c (composition_table_size, n_compositions)
2512 (get_composition_id, composition_gstring_from_id):
2513 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2514 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2515 * window.c (Frecenter):
2516 Use ptrdiff_t, not int, for composition IDs.
2517 * composite.c (get_composition_id): Check for integer overflow.
2518 * composite.h: Adjust prototypes to match the above changes.
2520 Use ptrdiff_t for hash table indexes.
2521 * category.c (hash_get_category_set):
2522 * ccl.c (ccl_driver):
2523 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2524 * coding.c (coding_system_charset_list, detect_coding_system):
2525 * coding.h (struct coding_system.id):
2526 * composite.c (get_composition_id, gstring_lookup_cache):
2527 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2528 * image.c (xpm_get_color_table_h):
2529 * lisp.h (hash_lookup, hash_put):
2530 * minibuf.c (Ftest_completion):
2531 Use ptrdiff_t for hash table indexes, not int (which is too
2532 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2533 32-bit --with-wide-int hosts).
2535 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2536 Add a FIXME comment about memory leaks.
2537 (syms_of_charset): Don't assume xmalloc returns.
2539 Don't assume that stated character widths fit in int.
2540 * character.c (Fchar_width, c_string_width, lisp_string_width):
2541 * character.h (CHAR_WIDTH):
2542 * indent.c (MULTIBYTE_BYTES_WIDTH):
2543 Use sanitize_char_width to avoid undefined and/or bad behavior
2544 with outlandish widths.
2545 * character.h (sanitize_tab_width): Rename from sanitize_width,
2546 now that we have two such functions. All uses changed.
2547 (sanitize_char_width): New inline function.
2549 Don't assume that tab-width fits in int.
2550 * character.h (sanitize_width): New inline function.
2551 (SANE_TAB_WIDTH): New macro.
2552 (ASCII_CHAR_WIDTH): Use it.
2553 * indent.c (sane_tab_width): Remove. All uses replaced by
2554 SANE_TAB_WIDTH (current_buffer).
2555 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2557 * fileio.c: Integer overflow issues with file modes.
2558 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2560 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2561 Remove unreachable code.
2562 (read_hex, load_charset_map_from_file): Check for integer overflow.
2564 * xterm.c: Don't go over XClientMessageEvent limit.
2565 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2566 (x_send_scroll_bar_event): Likewise. Check that the size does not
2567 exceed limits imposed by XClientMessageEvent, as well as the usual
2568 ptrdiff_t and size_t limits.
2570 * keyboard.c: Overflow, signedness and related fixes.
2571 (make_lispy_movement): Use same integer type in forward decl
2572 that is used in the definition.
2573 (read_key_sequence, keyremap_step):
2574 Change bufsize argument back to int, undoing my 2011-03-30 change.
2575 We prefer signed types, and int is wide enough here.
2576 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2577 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2578 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2579 length, not size_t. Use ptrdiff_t for index, not int.
2580 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2581 possibility of integer overflow.
2583 Overflow, signedness and related fixes for images.
2585 * dispextern.h (struct it.stack[0].u.image.image_id)
2586 (struct_it.image_id, struct image.id, struct image_cache.size)
2587 (struct image_cache.used, struct image_cache.ref_count):
2588 * gtkutil.c (update_frame_tool_bar):
2589 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2590 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2591 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2592 * nsmenu.m (update_frame_tool_bar):
2593 * xdisp.c (calc_pixel_width_or_height):
2594 * xfns.c (image_cache_refcount):
2595 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2596 on typical 64-bit hosts.
2598 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2599 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2600 Omit unnecessary casts to int.
2601 (parse_image_spec): Check that integers fall into 'int' range
2602 when the callers expect that.
2603 (image_ascent): Redo ascent calculation to avoid int overflow.
2604 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2605 (lookup_image): Remove unnecessary tests.
2606 (xbm_image_p): Locals are now of int, not EMACS_INT,
2607 since parse_image_check makes sure they fit into int.
2608 (png_load, gif_load, svg_load_image):
2609 Prefer int to unsigned where either will do.
2610 (tiff_handler): New function, combining the cores of the
2611 old tiff_error_handler and tiff_warning_handler.
2612 This function is rewritten to use vsnprintf and thereby avoid
2613 stack buffer overflows. It uses only the features of vsnprintf
2614 that are common to both POSIX and native Microsoft.
2615 (tiff_error_handler, tiff_warning_handler): Use it.
2616 (tiff_load, gif_load, imagemagick_load_image):
2617 Don't assume :index value fits in 'int'.
2618 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2619 (imagemagick_load_image): Check that crop parameters fit into
2620 the integer types that MagickCropImage accepts. Don't assume
2621 Vimagemagick_render_type has a nonnegative value. Don't assume
2622 size_t fits in 'long'.
2623 (gs_load): Use printmax_t to print the widest integers possible.
2624 Check for integer overflow when computing image height and width.
2626 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2628 * xdisp.c (redisplay_window): Don't force window start if point
2629 will be invisible in the resulting window. (Bug#9324)
2631 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2633 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2634 the display spec is of the form `(space ...)'.
2635 (handle_display_spec): Return the value returned by
2636 handle_single_display_spec, not just 1 or zero.
2637 (handle_single_display_spec): If the display spec is of the form
2638 `(space ...)', and specifies display in the text area, return 2
2640 (try_cursor_movement): Check for the need to scroll more
2641 accurately, and prefer exact match for point under bidi.
2642 Don't advance `row' beyond the last row of the window.
2644 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2645 into disp_prop; all users changed.
2647 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2648 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2649 for the text covered by the display property.
2651 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2653 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2654 Change return value to nil.
2655 (Frecord_buffer): Delete unused function.
2657 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2659 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2660 buffers, return left-to-right.
2661 (set_cursor_from_row): Consider candidate row a win if its glyph
2662 represents a newline and point is on that newline. Fixes cursor
2663 positioning on the newline at EOL of R2L text within L2R
2664 paragraph, and vice versa.
2665 (try_cursor_movement): Check continued rows, in addition to
2666 continuation rows. Fixes unwarranted scroll when point enters a
2667 continued line of R2L text within an L2R paragraph, or vice versa.
2668 (cursor_row_p): Consider the case of point being equal to
2669 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2670 from the end of a short line to the beginning of a continued line
2671 of R2L text within L2R paragraph.
2672 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2673 composed characters.
2675 * bidi.c (bidi_check_type): Use xassert.
2676 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2679 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2681 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2684 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2686 * nsfont.m (ns_otf_to_script): Fix typo.
2688 2011-08-22 Kenichi Handa <handa@m17n.org>
2690 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2691 extra slot even if the purpose is char-code-property-table.
2693 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2695 * xdisp.c (redisplay_window): When computing centering_position,
2696 account for the height of the header line. (Bug#8874)
2698 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2699 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2700 candidate is selected by the mouse, and that candidate has a
2701 composed character under the mouse.
2703 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2704 coordinates reported by pos-visible-in-window-p for a composed
2705 character in column zero.
2707 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2709 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2711 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2713 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2714 consider it a hit if to_charpos is anywhere in the range of the
2715 composed buffer positions.
2717 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2719 * image.c (gif_load): Don't assume that each subimage has the same
2720 dimensions as the base image. Handle disposal method that is
2721 "undefined" by the gif spec (Bug#9335).
2723 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2725 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2726 (Fcondition_case): Document `debug' symbol in error handler.
2728 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2730 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2731 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2732 from an Org mode buffer to a Speedbar frame.
2734 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2735 a composition, take its buffer position from IT->cmp_it.charpos.
2736 Fixes cursor positioning at the beginning of a line that begins
2737 with a composed character.
2739 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2741 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2742 character bidirectional type, use STRONG_L instead. Fixes crashes
2743 in a buffer produced by `describe-categories'.
2745 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2746 members before the level stack, so they would be saved and
2747 restored when copying iterator state. Fixes incorrect reordering
2748 around TABs covered by display properties.
2750 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2752 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2754 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2756 * eval.c (internal_condition_case, internal_condition_case_1)
2757 (internal_condition_case_2, internal_condition_case_n):
2758 Remove unnecessary aborts (Bug#9081).
2760 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2762 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2763 has no `load' handler, try opening the file locally. (Bug#9311)
2765 2011-08-16 Ken Brown <kbrown@cornell.edu>
2767 * gmalloc.c: Expand comment.
2769 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2771 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2772 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2774 2011-08-16 Ken Brown <kbrown@cornell.edu>
2776 Fix memory allocation problems in Cygwin build (Bug#9273).
2778 * unexcw.c ( __malloc_initialized): Declare external variable.
2779 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2781 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2783 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2785 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2787 [CYGWIN] (special_realloc): New function.
2788 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2789 requests to realloc storage in the static heap.
2791 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2793 * bidi.c (bidi_initialize): Remove unused local.
2795 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2798 * biditype.h: Remove file.
2799 * makefile.w32-in ($(BLD)/bidi.$(O)):
2800 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2802 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2804 * chartab.c: Improve commentary for the uniprop_table API.
2806 * bidi.c (bidi_paragraph_init): Support zero value of
2807 bidi_ignore_explicit_marks_for_paragraph_level.
2808 (bidi_initialize): Use uniprop_table instead of including
2809 biditype.h and bidimirror.h.
2811 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2812 coordinates of the iterator when restoring from ppos_it.
2815 2011-08-14 Kenichi Handa <handa@m17n.org>
2817 * process.c (create_process): Call setup_process_coding_systems
2818 after the pid of the process is set to -1 (Bug#8162).
2820 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2822 * xdisp.c (move_it_in_display_line_to): Don't invoke
2823 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2824 ppos_it. Fixes vertical cursor motion when line beginning is
2825 covered by an image. (Bug#9296)
2827 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2829 * nsterm.h (ns_run_ascript): Declare.
2830 (NSAPP_DATA2_RUNASSCRIPT): Define.
2832 * nsfns.m (as_script, as_result, as_status): New static variables.
2833 (ns_run_ascript): New function.
2834 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2835 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2836 the event loop. Get status from as_status (Bug#7276).
2838 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2839 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2840 the event loop (Bug#7276).
2842 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2844 * gnutls.c (QCgnutls_bootprop_priority)
2845 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2846 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2847 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2848 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2849 (QCgnutls_bootprop_verify_hostname_error)
2850 (QCgnutls_bootprop_callbacks_verify): Rename from
2851 Qgnutls_bootprop_..., all uses changed.
2853 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2856 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2858 * xfaces.c (Qframe_set_background_mode): Now static.
2859 * dispextern.h (Qframe_set_background_mode): Remove decl.
2861 * process.c (Fnetwork_interface_info): Declare local only if needed.
2863 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2865 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2866 (Fnetwork_interface_list): Allocate in increments of bytes instead
2867 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2868 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2870 (struct ifflag_def): notrailers is smart on OSX.
2871 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2872 Get hardware address with getifaddrs if available.
2874 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2876 * xdisp.c (iterate_out_of_display_property): xassert that
2877 IT->position is set to within IT->object's boundaries. Break from
2878 the loop as soon as EOB is reached; avoids infloops in redisplay
2879 when IT->position is set up wrongly due to some bug.
2880 Set IT->current to match the bidi iterator unconditionally.
2881 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2882 entry. Force push_it to save on the stack the current
2883 buffer/string position, to be restored by pop_it. Fix flags in
2884 the iterator structure wrt the object coming from a display
2885 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2886 properties. (Bug#9284)
2888 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2890 * fontset.c (fontset_get_font_group): Add proper type checks.
2893 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2895 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2896 and LC_VERSION_MIN_MACOSX.
2897 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2898 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2900 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2902 * xdisp.c (forward_to_next_line_start): Allow to use the
2903 no-display-properties-and-no-overlays under bidi display.
2904 Set disp_pos in the bidi iterator to avoid searches for display
2905 properties and overlays.
2907 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2909 * editfns.c (Fset_time_zone_rule): Document relationship with the
2912 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2913 the font entity extracted from the cache (Bug#8109).
2915 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2917 * composite.c (autocmp_chars): Don't reset point. That is done by
2918 restore_point_unwind (Bug#5984).
2920 2011-08-07 Juri Linkov <juri@jurta.org>
2922 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2923 to show the arg `TIME' instead of `TIMEVAL'.
2925 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2927 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2928 display property strides EOL and includes a newline, as in
2929 longlines-mode. (Bug#9254)
2930 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2931 word-wrap under bidirectional display. (Bug#9224)
2933 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2934 is non-zero, even if the data buffer is NULL. Fixes a crash in
2935 vertical-motion with longlines-mode. (Bug#9254)
2937 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2939 * bidi.c <bidi_cache_total_alloc>: Now static.
2940 (bidi_initialize): Initialize bidi_cache_total_alloc.
2942 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2945 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2946 amount allocated this far in `bidi_cache_total_alloc'.
2947 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2948 non-zero, only free the data buffer without restoring the cache
2949 contents. All callers changed.
2951 * dispextern.h (bidi_unshelve_cache): Update prototype.
2953 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2954 (move_it_in_display_line, move_it_to)
2955 (move_it_vertically_backward, move_it_by_lines): Replace the call
2956 to xfree to an equivalent call to bidi_unshelve_cache.
2957 (move_it_in_display_line_to): Fix logic of returning
2958 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2960 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2962 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2963 came from a string character with a `cursor' property. (Bug#9229)
2965 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2967 * Makefile.in (LIB_PTHREAD): New variable.
2968 (LIBES): Add LIB_PTHREAD (Bug#9216).
2970 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2971 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2973 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2975 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2977 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2979 * xterm.c (x_find_topmost_parent): New function.
2980 (x_set_frame_alpha): Find topmost parent window with
2981 x_find_topmost_parent and set the property there also (bug#9181).
2982 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2984 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2986 * callproc.c (Fcall_process): Avoid vfork clobbering
2987 the local vars buffer, coding_systems, current_dir.
2989 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2991 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2993 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2995 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2996 so that it is not optimized away.
2998 * xdisp.c (compute_display_string_pos): Remove unused local.
3000 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3002 Fix slow cursor motion and scrolling in large buffers with
3003 selective display, like Org Mode buffers. (Bug#9218)
3005 * dispextern.h (struct bidi_it): New member disp_prop_p.
3007 * xdisp.c: Remove one-slot cache of display string positions.
3008 (compute_display_string_pos): Accept an additional argument
3009 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3010 for a display string or property. If found, set DISP_PROP_P
3013 * bidi.c (bidi_fetch_char): Accept an additional argument
3014 DISP_PROP_P, and pass it to compute_display_string_pos.
3015 Only handle text covered by a display string if DISP_PROP_P is returned
3016 non-zero. All callers of bidi_fetch_char changed.
3018 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3020 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3022 2010-12-03 Don March <don@ohspite.net>
3024 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3025 last character M-[char] is translated to ESC [char] (bug#7541).
3027 2011-08-02 Kenichi Handa <handa@m17n.org>
3029 * lisp.h (uniprop_table): Extern it.
3031 * chartab.c (uniprop_table): Make it non-static.
3033 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3035 * xdisp.c (forward_to_next_line_start): Accept additional argument
3036 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3038 (reseat_at_next_visible_line_start): Use the bidi iterator state
3039 returned by forward_to_next_line_start to restore the state of
3040 it->bidi_it after backing up to previous newline. (Bug#9212)
3042 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3044 * regex.c (re_comp): Protoize.
3045 (re_exec): Fix return type.
3046 (regexec): Fix type of `ret'. (Bug#9203)
3048 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3050 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3051 This is needed if max-image-size is a floating-point number.
3053 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3055 * print.c (print_object): Print empty symbol as ##.
3057 * lread.c (read1): Read ## as empty symbol.
3059 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3061 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3062 setting frame foreground color (Bug#9175).
3063 (x_set_background_color): Likewise.
3065 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3066 contents (Bug#9176).
3067 (EmacsTooltip -init): Remove bezels and add shadows to
3070 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3071 or scroll bar (Bug#8470).
3073 * nsfont.m (nsfont_open): Remove assignment to voffset and
3074 unnecessary vars hshink, expand, hd, full_height, min_height.
3075 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3077 * nsterm.h (nsfont_info): Remove voffset field.
3079 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3081 Implement strike-through and overline on NextStep (Bug#8863).
3083 * nsfont.m (nsfont_open): Use underline position provided by font,
3084 instead of hard-coded value of 2.
3085 (nsfont_draw): Call ns_draw_text_decoration instead.
3087 * nsterm.h: Add declaration for ns_draw_text_decoration.
3089 * nsterm.m (ns_draw_text_decoration): New function for drawing
3090 underline, overline, and strike-through.
3091 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3092 ns_draw_text_decoration. Change treatment of cursor drawing to
3093 accommodate underlining, etc.
3095 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3097 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3100 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3102 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3103 Without this fix, if a signal arrives just after memory fills up,
3104 'malloc' might be invoked reentrantly.
3106 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3107 In other words, assume that every image size is allowed, on non-X
3108 hosts. This assumption is probably wrong, but it lets Emacs compile.
3110 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3112 * regex.c (re_iswctype): Convert return values to boolean.
3114 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3116 * xdisp.c (compute_display_string_pos): Don't use cached display
3117 string position if the buffer had its restriction changed.
3120 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3122 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3124 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3126 Integer signedness and overflow and related fixes. (Bug#9079)
3128 * bidi.c: Integer size and overflow fixes.
3129 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3130 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3131 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3132 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3133 (bidi_find_other_level_edge):
3134 Use ptrdiff_t instead of EMACS_INT where either will do.
3135 This works better on 32-bit hosts configured --with-wide-int.
3136 (bidi_cache_ensure_space): Check for size-calculation overflow.
3137 Use % rather than repeated addition, for better worst-case speed.
3138 Don't set bidi_cache_size until after xrealloc returns, because it
3140 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3141 (bidi_cache_ensure_space): Also check that the bidi cache size
3142 does not exceed that of the largest Lisp string or buffer. See Eli
3143 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3145 * alloc.c (__malloc_size_t): Remove.
3146 All uses replaced by size_t. See Andreas Schwab's note
3147 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3149 * image.c: Improve checking for integer overflow.
3150 (check_image_size): Assume that f is nonnull, since
3151 it is always nonnull in practice. This is one less thing to
3152 worry about when checking for integer overflow later.
3153 (x_check_image_size): New function, which checks for integer
3154 overflow issues inside X.
3155 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3156 This removes the need for a memory_full check.
3157 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3158 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3159 (xbm_read_bitmap_data): Change locals back to 'int', since
3160 their values must fit in 'int'.
3161 (xpm_load_image, png_load, tiff_load):
3162 Invoke x_create_x_image_and_pixmap earlier,
3163 to avoid much needless work if the image is too large.
3164 (tiff_load): Treat overly large images as if
3165 x_create_x_image_and_pixmap failed, not as malloc failures.
3166 (gs_load): Use x_check_image_size.
3168 * gtkutil.c: Omit integer casts.
3169 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3170 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3172 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3174 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3175 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3176 would wrongly return t on a 64-bit host.
3178 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3179 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3180 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3181 and therefore cause GCC to emit a bogus diagnostic in some cases.
3183 * image.c: Integer signedness and overflow and related fixes.
3184 This is not an exhaustive set of fixes, but it's time to
3185 record what I've got.
3186 (lookup_pixel_color, check_image_size): Remove redundant decls.
3187 (check_image_size): Don't assume that arbitrary EMACS_INT values
3188 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3189 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3190 (tiff_load, imagemagick_load_image):
3191 Check for overflow in size calculations.
3192 (x_create_x_image_and_pixmap): Remove unnecessary test for
3193 xmalloc returning NULL; that can't happen.
3194 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3195 (xpm_color_bucket): Use better integer hashing function.
3196 (xpm_cache_color): Don't possibly over-allocate memory.
3197 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3198 (gif_memory_source):
3199 Use ptrdiff_t, not int or size_t, to record sizes.
3200 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3201 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3202 either works, as we prefer signed integers.
3203 (tiff_read_from_memory, tiff_write_from_memory):
3204 Return tsize_t, not size_t, since that's what the TIFF API wants.
3205 (tiff_read_from_memory): Don't fail simply because the read would
3206 go past EOF; instead, return a short read.
3207 (tiff_load): Omit no-longer-needed casts.
3208 (Fimagemagick_types): Don't assume size fits into 'int'.
3210 Improve hashing quality when configured --with-wide-int.
3211 * fns.c (hash_string): New function, taken from sxhash_string.
3212 Do not discard information about ASCII character case; this
3213 discarding is no longer needed.
3214 (sxhash-string): Use it. Change sig to match it. Caller changed.
3215 * lisp.h: Declare it.
3216 * lread.c (hash_string): Remove, since we now use fns.c's version.
3217 The fns.c version returns a wider integer if --with-wide-int is
3218 specified, so this should help the quality of the hashing a bit.
3220 * emacs.c: Integer overflow minor fix.
3221 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3222 Define only if GNU_LINUX.
3223 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3225 * dispnew.c: Integer signedness and overflow fixes.
3226 Remove unnecessary forward decls, that were a maintenance hassle.
3227 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3229 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3230 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3231 (prepare_desired_row, line_draw_cost):
3232 Use int, not unsigned, where either works.
3233 (save_current_matrix, restore_current_matrix):
3234 Use ptrdiff_t, not size_t, where either works.
3235 (init_display): Check for overflow more accurately, and without
3236 relying on undefined behavior.
3238 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3239 Remove, replacing with the new symbols in lisp.h. All uses changed.
3240 * fileio.c (make_temp_name):
3241 * filelock.c (lock_file_1, lock_file):
3242 * xdisp.c (message_dolog):
3243 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3244 Use pMd etc. instead.
3245 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3246 replacing the pWIDE etc. symbols removed from editfns.c.
3248 * keyboard.h (num_input_events): Now uintmax_t.
3249 This is (very slightly) less likely to mess up due to wraparound.
3252 * buffer.c: Integer signedness fixes.
3253 (alloc_buffer_text, enlarge_buffer_text):
3254 Use ptrdiff_t rather than size_t when either will do, as we prefer
3257 * alloc.c: Integer signedness and overflow fixes.
3258 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3259 (__malloc_size_t): Default to size_t, not to int.
3260 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3261 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3262 Prefer ptrdiff_t to size_t when either would do, as we prefer
3264 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3265 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3266 Now const. Initialize with values that are in range even if char
3268 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3269 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3270 These functions do the right thing with sizes > 2**32.
3271 (check_depth): Now ptrdiff_t, not int.
3272 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3273 Adjust to new way of storing sizes. Check for size overflow bugs
3275 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3276 slightly wrong anyway, as it missed one instance of
3277 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3278 (refill_memory_reserve): Omit needless cast to size_t.
3279 (mark_object_loop_halt): Mark as externally visible.
3281 * xselect.c: Integer signedness and overflow fixes.
3282 (Fx_register_dnd_atom, x_handle_dnd_message):
3283 Use ptrdiff_t, not size_t, since we prefer signed.
3284 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3285 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3286 x_dnd_atoms_size and x_dnd_atoms_length.
3288 * doprnt.c: Prefer signed to unsigned when either works.
3290 * doprnt.c (doprnt):
3292 * xdisp.c (vmessage):
3293 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3294 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3295 prefer signed arithmetic to avoid comparison confusion.
3296 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3297 but is a bit tricky.
3299 Assume freestanding C89 headers, string.h, stdlib.h.
3300 * data.c, doprnt.c, floatfns.c, print.c:
3301 Include float.h unconditionally.
3302 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3303 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3304 * regex.c: Likewise for stddef.h, string.h.
3305 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3306 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3307 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3308 (STDC_HEADERS): Remove obsolete defines.
3309 * sysdep.c: Include limits.h unconditionally.
3311 Assume support for memcmp, memcpy, memmove, memset.
3312 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3313 * regex.c (memcmp, memcpy):
3314 Remove; we assume C89 now.
3316 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3317 (__malloc_safe_bcopy): Remove; no longer needed.
3319 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3320 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3321 well either way, and we prefer signed to unsigned.
3323 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3325 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3326 closes the connection while we're reading (bug#9182).
3328 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3330 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3331 are specified (Bug#9168).
3333 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3335 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3336 Found by GCC static checking and --with-wide-int on a 32-bit host.
3338 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3340 * xdisp.c (compute_display_string_pos): Fix logic of caching
3341 previous display string position. Initialize cached_prev_pos to
3342 -1. Fixes slow-down at the beginning of a buffer.
3344 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3346 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3347 for attrs[LFACE_FONTSET_INDEX].
3349 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3351 * xml.c (parse_region): Remove unused local
3352 that was recently introduced.
3354 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3356 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3357 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3359 * xdisp.c (move_it_in_display_line_to): Record the best matching
3360 position for TO_CHARPOS while scanning the line, and restore it on
3361 exit if none of the characters scanned was an exact match.
3362 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3363 when exact match is impossible due to invisible text, and the
3364 lines are truncated.
3366 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3368 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3371 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3373 Fix a significant slow-down of cursor motion with C-n, C-p,
3374 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3375 auto-repeat under bidi redisplay in fontified buffers.
3376 * xdisp.c (compute_stop_pos_backwards): New function.
3377 (next_element_from_buffer): Call compute_stop_pos_backwards to
3378 find a suitable prev_stop when we find ourselves before
3380 (reseat): Don't look for prev_stop, as that could mean a very long
3382 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3383 <cached_disp_overlay_modiff>: Cache for last found display string
3385 (compute_display_string_pos): Return the cached position if asked
3386 about the same buffer in the same area of character positions, and
3387 the buffer wasn't changed since the time the display string
3388 position was cached.
3390 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3392 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3393 is an integer, which is important for empty lines. (Bug#9149)
3395 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3397 * frame.c (Fmodify_frame_parameters): In tty case, update the
3398 default face if necessary (Bug#4238).
3400 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3402 * editfns.c (Fstring_to_char): No need to explain what a character
3403 is in the docstring (Bug#6576).
3405 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3407 * xml.c (parse_region): Make sure we always return a tree.
3409 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3411 * xml.c (parse_region): If a document contains only comments,
3414 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3416 * xml.c (make_dom): Return comments, too.
3418 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3421 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3422 and the surrounding thread.
3423 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3424 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3425 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3427 * s/openbsd.h (BROKEN_SIGIO): Define.
3428 * unexelf.c (unexec) [__OpenBSD__]:
3429 Don't update the .mdebug section of the Alpha COFF symbol table.
3431 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3433 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3436 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3438 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3439 This fixes some race conditions on the permissions of any newly
3442 * alloc.c (valid_pointer_p): Use pipe, not open.
3443 This fixes some permissions issues when debugging.
3445 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3446 If fchown fails to set both uid and gid, try to set just gid,
3447 as that is sometimes allowed. Adjust the file's mode to eliminate
3448 setuid or setgid bits that are inappropriate if fchown fails.
3450 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3452 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3453 to compare Lisp_Objects.
3454 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3455 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3456 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3458 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3460 * lread.c (read_integer): Unread even EOF character.
3461 (read1): Likewise. Properly record start position of symbol.
3463 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3464 symbol character follows.
3466 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3468 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3469 This works around a problem with the previous change to Fcopy_file.
3470 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3471 and without this change, GCC might complain about discarding
3472 fchown's return value.
3474 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3476 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3478 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3480 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3482 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3484 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3485 it's used from the C level.
3487 * process.c: Use the same condition for POLL_FOR_INPUT in both
3488 keyboard.c and process.c (bug#1858).
3490 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3492 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3493 (Fgnutls_boot): Use it.
3495 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3497 * doc.c (Fsubstitute_command_keys): Revert last change.
3499 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3501 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3502 quotes the next character, and doesn't affect other longer
3503 sequences (bug#8935).
3505 * lread.c (syms_of_lread): Clarify that is isn't only
3506 `eval-buffer' and `eval-defun' that's affected by
3507 `lexical-binding' (bug#8460).
3509 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3511 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3512 bidi redisplay when a line includes both an image and is truncated.
3514 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3516 Fix minor problems found by static checking.
3517 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3518 (elsz): Now a signed constant, not a size_t var. We prefer signed
3519 types to unsigned, to avoid integer comparison confusion. Without
3520 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3521 "cannot optimize loop, the loop counter may overflow", a symptom
3523 * indent.c (Fvertical_motion): Mark locals as initialized.
3524 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3526 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3528 * search.c (Fre_search_backward): Mention `case-fold-search' in
3529 all the re_search_* functions (bug#8138).
3531 * keyboard.c (Fopen_dribble_file): Document when the file is
3534 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3536 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3539 Support bidi reordering of display and overlay strings.
3540 * xdisp.c (compute_display_string_pos)
3541 (compute_display_string_end): Accept additional argument STRING.
3542 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3543 (reseat_to_string): Initialize bidi_it->string.s and
3544 bidi_it->string.schars.
3545 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3546 NULL (avoids a crash in bidi_paragraph_init).
3547 Initialize itb.string.lstring.
3548 (init_iterator): Call bidi_init_it only of a valid
3549 buffer position was specified. Initialize paragraph_embedding to
3551 (reseat_to_string): Initialize the bidi iterator.
3552 (display_string): If we need to ignore text properties of
3553 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3554 original value of -1 will not work with bidi.)
3555 (compute_display_string_pos): First arg is now struct
3556 `text_pos *'; all callers changed. Support display properties on
3558 (compute_display_string_end): Support display properties on Lisp
3560 (init_iterator, reseat_1, reseat_to_string): Initialize the
3561 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3562 when iterating on a string not from display properties).
3563 (compute_display_string_pos, compute_display_string_end):
3564 Fix calculation of the object to scan. Fixes an error when using
3566 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3567 base_level_stop; instead, set base_level_stop to BEGV.
3568 Fixes crashes in vertical-motion.
3569 (next_element_from_buffer): Improve commentary for when
3570 the iterator is before prev_stop.
3571 (init_iterator): Initialize bidi_p from the default value of
3572 bidi-display-reordering, not from buffer-local value. Use the
3573 buffer-local value only if initializing for buffer iteration.
3574 (handle_invisible_prop): Support invisible properties on strings
3575 that are being bidi-reordered.
3576 (set_iterator_to_next): Support bidi reordering of C strings and
3578 (next_element_from_string): Support bidi reordering of Lisp
3580 (handle_stop_backwards): Support Lisp strings as well.
3581 (display_string): Support display of R2L glyph rows.
3582 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3583 (init_iterator): Don't initialize it->bidi_p for strings
3585 (reseat_to_string): Initialize it->bidi_p for strings here.
3586 (next_element_from_string, next_element_from_c_string)
3587 (next_element_from_buffer): Add xassert's for correspondence
3588 between IT's object being iterated and it->bidi_it.string
3590 (face_before_or_after_it_pos): Support bidi iteration.
3591 (next_element_from_c_string): Handle the case of the first string
3592 character that is not the first one in the visual order.
3593 (get_visually_first_element): New function, refactored from common
3594 parts of next_element_from_buffer, next_element_from_string, and
3595 next_element_from_c_string.
3596 (tool_bar_lines_needed, redisplay_tool_bar)
3597 (display_menu_bar): Force left-to-right direction. Add a FIXME
3598 comment for making that be controlled by a user option.
3599 (push_it, pop_it): Save and restore the state of the
3600 bidi iterator. Save and restore the bidi_p flag.
3601 (pop_it): Iterate out of display property for string iteration as
3603 (iterate_out_of_display_property): Support iteration over strings.
3604 (handle_single_display_spec): Set up it->bidi_it for iteration
3605 over a display string, and call bidi_init_it.
3606 (handle_single_display_spec, next_overlay_string)
3607 (get_overlay_strings_1, push_display_prop): Set up the bidi
3608 iterator for displaying display or overlay strings.
3609 (forward_to_next_line_start): Don't use the shortcut if
3611 (back_to_previous_visible_line_start): If handle_display_prop
3612 pushed the iterator stack, restore the internal state of the bidi
3613 iterator by calling bidi_pop_it same number of times.
3614 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3615 and we are bidi-iterating, don't decrement the iterator position;
3616 instead, set the first_elt flag in the bidi iterator, to produce
3618 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3619 (push_display_prop): xassert that we are iterating a buffer.
3620 (push_it, pop_it): Save and restore paragraph_embedding member.
3621 (handle_single_display_spec, next_overlay_string)
3622 (get_overlay_strings_1, reseat_1, reseat_to_string)
3623 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3624 correctly. Don't assume unibyte strings are not bidi-reordered.
3625 (compute_display_string_pos)
3626 (compute_display_string_end): Fix handling the case of C string.
3627 (push_it, pop_it): Save and restore from_disp_prop_p.
3628 (handle_single_display_spec, push_display_prop): Set the
3629 from_disp_prop_p flag.
3630 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3631 (pop_it): Call iterate_out_of_display_property only if we are
3632 popping after iteration over a string that came from a display
3633 property. Fix a typo in popping stretch info. Add an assertion
3634 for verifying that the iterator position is in sync with the bidi
3636 (handle_single_display_spec, get_overlay_strings_1)
3637 (push_display_prop): Fix initialization of paragraph direction for
3638 string when that of the parent object is not yet determined.
3639 (reseat_1): Call bidi_init_it to resync the bidi
3640 iterator with IT's position. (Bug#7616)
3641 (find_row_edges): If ROW->start.pos gives position
3642 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3643 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3644 Reset the from_disp_prop_p flag.
3645 (SAVE_IT, RESTORE_IT): New macros.
3646 (pos_visible_p, face_before_or_after_it_pos)
3647 (back_to_previous_visible_line_start)
3648 (move_it_in_display_line_to, move_it_in_display_line)
3649 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3650 (try_scrolling, redisplay_window, display_line): Use them when
3651 saving a temporary copy of the iterator and restoring it back.
3652 (back_to_previous_visible_line_start, reseat_1)
3653 (init_iterator): Empty the bidi cache "stack".
3654 (move_it_in_display_line_to): If iterator ended up at
3655 EOL, but we never saw any buffer positions smaller than
3656 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3657 motion in bidi-reordered lines.
3658 (move_it_in_display_line_to): Record prev_method and prev_pos
3659 immediately before the call to set_iterator_to_next. Fixes cursor
3660 motion in bidi-reordered lines with stretch glyphs and strings
3661 displayed in margins. (Bug#8133) (Bug#8867)
3662 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3664 (pos_visible_p): Support positions in bidi-reordered lines.
3665 Save and restore bidi cache.
3667 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3668 (bidi_paragraph_info): Delete unused struct.
3669 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3670 (bidi_cache_start): New variable.
3671 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3673 (bidi_cache_fetch_state, bidi_cache_search)
3674 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3675 (bidi_cache_find, bidi_peek_at_next_level)
3676 (bidi_level_of_next_char, bidi_find_other_level_edge)
3677 (bidi_move_to_visually_next): Compare cache index with
3678 bidi_cache_start rather than with zero.
3679 (bidi_fetch_char): Accept new argument STRING; all callers
3680 changed. Support iteration over a string. Support strings with
3681 display properties. Support unibyte strings. Fix the type of
3682 `len' according to what STRING_CHAR_AND_LENGTH expects.
3683 (bidi_paragraph_init, bidi_resolve_explicit_1)
3684 (bidi_resolve_explicit, bidi_resolve_weak)
3685 (bidi_level_of_next_char, bidi_move_to_visually_next):
3686 Support iteration over a string.
3687 (bidi_set_sor_type, bidi_resolve_explicit_1)
3688 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3689 can now be zero (for strings); special values 0 and -1 were
3690 changed to -1 and -2, respectively.
3691 (bidi_char_at_pos): New function.
3692 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3693 Call it instead of FETCH_MULTIBYTE_CHAR.
3694 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3695 initialized to valid values.
3696 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3698 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3699 the test for valid cached positions. Fix the logic for looking up
3700 the sentinel state in the cache. GCPRO the Lisp string we are
3702 (bidi_push_it, bidi_pop_it): New functions.
3703 (bidi_initialize): Initialize the bidi cache start stack pointer.
3704 (bidi_cache_ensure_space): New function, refactored from part of
3705 bidi_cache_iterator_state. Don't assume the required size is just
3706 one BIDI_CACHE_CHUNK away.
3707 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3708 (bidi_count_bytes, bidi_char_at_pos): New functions.
3709 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3710 always valid if bidi_cache_idx is valid.
3711 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3712 is valid if it's going to be used.
3713 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3714 (bidi_cache_fetch_state, bidi_cache_search)
3715 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3716 (bidi_cache_iterator_state, bidi_cache_find)
3717 (bidi_find_other_level_edge, bidi_cache_start_stack):
3718 All variables related to cache indices are now EMACS_INT.
3720 * dispextern.h (struct bidi_string_data): New structure.
3721 (struct bidi_it): New member `string'. Make flag members be 1-bit
3722 fields, and put them last in the struct.
3723 (compute_display_string_pos, compute_display_string_end):
3725 (bidi_push_it, bidi_pop_it): Add prototypes.
3726 (struct iterator_stack_entry): New members bidi_p,
3727 paragraph_embedding, and from_disp_prop_p.
3728 (struct it): Member bidi_p is now a bit field 1 bit wide.
3729 (bidi_shelve_cache, bidi_unshelve_cache):
3732 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3733 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3734 and vector-like objects.
3736 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3737 cache around display iteration.
3739 * window.c (Fwindow_end, window_scroll_pixel_based)
3740 (displayed_window_lines, Frecenter): Save and restore the bidi
3741 cache around display iteration.
3743 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3745 * editfns.c (Fdelete_region): Clarify the use of the named
3746 parameters (bug#6788).
3748 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3750 * indent.c (Fvertical_motion): Set and restore w->pointm when
3751 saving and restoring the window's buffer (Bug#9006).
3753 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3755 * editfns.c (Fstring_to_char): Clarify just what is returned
3756 (bug#6576). Text by Eli Zaretskii.
3758 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3760 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3762 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3764 * buffer.c (mmap_find): Fix a typo.
3766 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3768 Fix execution of x selection hooks.
3769 * xselect.c (Qx_lost_selection_functions)
3770 (Qx_sent_selection_functions): New vars.
3771 (syms_of_xselect): DEFSYM them.
3772 (x_handle_selection_request): Pass Qx_sent_selection_functions
3773 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3774 (x_handle_selection_clear,x_clear_frame_selections):
3775 Pass Qx_lost_selection_functions rather than
3776 Vx_lost_selection_functions to Frun_hook_with_args.
3778 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3780 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3781 The old code sometimes used this field without initializing it.
3783 * alloc.c (gc_sweep): Don't read past end of array.
3784 In theory, the old code could also have corrupted Emacs internals,
3785 though it'd be very unlikely.
3787 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3789 * character.c (Fcharacterp): Don't advertise optional ignored
3790 argument. (Bug#4026)
3792 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3794 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3797 * window.c (Fset_window_start): Doc fix (bug#4199).
3798 (Fset_window_hscroll): Ditto.
3800 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3802 Fix minor new problems caught by GCC 4.6.1.
3803 * term.c (init_tty): Remove unused local.
3804 * xsettings.c (store_monospaced_changed): Define this function only
3805 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3808 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3810 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3812 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3814 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3815 are the mini-buffer and the echo area (bug#3320).
3817 * term.c (init_tty): Remove support for supdup, c10 and perq
3818 terminals, which are no longer supported (bug#1482).
3820 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3822 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3824 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3826 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3827 for non-popups (Bug#3642).
3829 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3831 * alloc.c (reset_malloc_hooks): Protoize.
3832 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3833 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3834 * cm.c (losecursor): Likewise.
3835 * data.c (fmod): Likewise.
3836 * dispnew.c (swap_glyphs_in_rows): Likewise.
3837 * emacs.c (memory_warning_signal): Likewise.
3838 * floatfns.c (float_error): Likewise.
3839 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3840 (otf_open, font_otf_capability, generate_otf_features)
3841 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3843 * image.c (pbm_read_file): Likewise.
3844 * indent.c (string_display_width): Likewise.
3845 * intervals.c (check_for_interval, search_for_interval)
3846 (inc_interval_count, count_intervals, root_interval)
3847 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3848 * lread.c (defalias): Likewise.
3849 * ralloc.c (r_alloc_check): Likewise.
3850 * regex.c (set_image_of_range_1, set_image_of_range)
3851 (regex_grow_registers): Likewise.
3852 * sysdep.c (strerror): Likewise.
3853 * termcap.c (valid_filename_p, tprint, main): Likewise.
3854 * tparam.c (main): Likewise.
3855 * unexhp9k800.c (run_time_remap, save_data_space)
3856 (update_file_ptrs, read_header, write_header, calculate_checksum)
3857 (copy_file, copy_rest, display_header): Likewise.
3858 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3860 * xdisp.c (check_it): Likewise.
3861 * xfaces.c (register_color, unregister_color, unregister_colors):
3863 * xfns.c (print_fontset_result): Likewise.
3864 * xrdb.c (member, fatal, main): Likewise.
3866 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3868 Fix minor problems found by static checking (Bug#9031).
3869 * chartab.c (char_table_set_range, map_sub_char_table):
3870 Remove unused locals.
3871 (uniprop_table): Now static.
3872 * composite.c (_work_char): Remove unused static var.
3874 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3876 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3878 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3880 * gtkutil.c (qttip_cb): Remove code without function.
3882 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3884 * w32.c (pthread_sigmask): New stub.
3886 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3888 Use pthread_sigmask, not sigprocmask (Bug#9010).
3889 sigprocmask is portable only for single-threaded applications, and
3890 Emacs can be multi-threaded when it uses GTK.
3891 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3893 * callproc.c (Fcall_process):
3894 * process.c (create_process):
3895 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3896 Use pthread_sigmask, not sigprocmask.
3898 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3900 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3901 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3904 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3906 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3907 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3908 (xg_hide_tooltip): Fix comment.
3910 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3911 in registerServicesMenuSendTypes.
3912 (validRequestorForSendType): Don't check ns_return_types.
3914 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3917 2011-07-08 Jason Rumney <jasonr@gnu.org>
3919 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3920 SH_SHOW for hidden windows (Bug#5482).
3922 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3923 frame struct members of non-existent frames (Bug#6284).
3925 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3927 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3928 variable firstTime not needed on OSX >= 10.6.
3929 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3930 >= 10.5. Use setKnobProportion, setDoubleValue.
3932 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3933 (MAC_OS_X_VERSION_10_5): Define if not defined.
3934 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3935 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3936 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3938 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3939 cString and lossyCString on OSX >= 10.4
3941 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3942 sizeToFit on OSX >= 10.2.
3944 * nsimage.m (allocInitFromFile): Don't use deprecated method
3945 bestRepresentationForDevice on OSX >= 10.6.
3947 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3950 * emacs.c: Declare unexec_init_emacs_zone.
3952 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3954 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3956 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3957 on svcsMenu (Bug#8842).
3959 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3961 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3963 * nsterm.m (QUTF8_STRING): Declare.
3964 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3965 (validRequestorForSendType): Return type is (id).
3966 Change indexOfObjectIdenticalTo to indexOfObject.
3967 Check if we have local selection before returning self (Bug#8842).
3968 (writeSelectionToPasteboard): Put local selection into paste board
3969 if we have a local selection (Bug#8842).
3970 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3972 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3973 (ns_get_local_selection): Declare.
3975 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3977 * keymap.c (describe_map_tree): Don't insert a double newline at
3978 the end of the buffer (bug#1169) and return whether we inserted
3981 * callint.c (Fcall_interactively): Change "reading args" to
3982 "providing args" to try to clarify what it does (bug#1010).
3984 2011-07-07 Kenichi Handa <handa@m17n.org>
3986 * composite.c (composition_compute_stop_pos): Ignore a static
3987 composition starting before CHARPOS (Bug#8915).
3989 * xdisp.c (handle_composition_prop): Likewise.
3991 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3993 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3996 2011-07-07 Kenichi Handa <handa@m17n.org>
3998 * character.h (unicode_category_t): New enum type.
4000 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4001 (Qchar_code_property_table): New variable.
4002 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4003 (UNIPROP_COMPRESSED_FORM_P): New macros.
4004 (char_table_ascii): Uncompress the compressed values.
4005 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4006 Uncompress the compressed values.
4007 (sub_char_table_ref_and_range): Likewise.
4008 (char_table_ref_and_range): Uncompress the compressed values.
4009 (sub_char_table_set): New arg is_uniprop. Callers changed.
4010 Uncompress the compressed values.
4011 (sub_char_table_set_range): Args changed. Callers changed.
4012 (char_table_set_range): Adjuted for the above change.
4013 (map_sub_char_table): Delete args default_val and parent. Add arg
4014 top. Give decoded values to a Lisp function.
4015 (map_char_table): Adjust for the above change. Give decoded
4016 values to a Lisp function. Gcpro more variables.
4017 (uniprop_table_uncompress)
4018 (uniprop_decode_value_run_length): New functions.
4019 (uniprop_decoder, uniprop_decoder_count): New variables.
4020 (uniprop_get_decoder, uniprop_encode_value_character)
4021 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4023 (uniprop_encoder, uniprop_encoder_count): New variables.
4024 (uniprop_get_encoder, uniprop_table)
4025 (Funicode_property_table_internal, Fget_unicode_property_internal)
4026 (Fput_unicode_property_internal): New functions.
4027 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4028 Sunicode_property_table_internal, Sget_unicode_property_internal,
4029 and Sput_unicode_property_internal. Defvar_lisp
4030 char-code-property-alist.
4032 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4033 Vunicode_category_table.
4035 * font.c (font_range): Adjust for the change of
4036 Vunicode_category_table.
4038 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4040 * m/iris4d.h: Remove file, move contents ...
4041 * s/irix6-5.h: ... here.
4043 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4045 Remove unportable assumption about struct layout (Bug#8884).
4046 * alloc.c (mark_buffer):
4047 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4048 (clone_per_buffer_values): Don't assume that
4049 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4050 This isn't true in general, and it's particularly not true
4051 if Emacs is configured with --with-wide-int.
4052 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4053 New macros, used in the buffer.c change.
4055 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4057 * xsettings.c: Use both GConf and GSettings if both are available.
4058 (store_config_changed_event): Add comment.
4059 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4060 (store_tool_bar_style_changed): New functions.
4061 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4062 (struct xsettings): Move font inside HAVE_XFT.
4063 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4064 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4065 Move inside HAVE_XFT.
4066 (something_changed_gsettingsCB): Rename from something_changedCB.
4067 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4069 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4070 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4071 (something_changed_gconfCB): Rename from something_changedCB.
4072 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4073 (parse_settings): Move check for font inside HAVE_XFT.
4074 (read_settings, apply_xft_settings): Add comment.
4075 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4076 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4077 call store_font_name_changed.
4078 (xft_settings_event): Add comment.
4079 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4080 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4081 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4082 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4083 (xsettings_initialize): Call init_gsettings last.
4084 (xsettings_get_system_font, xsettings_get_system_normal_font):
4087 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4089 Random fixes. E.g., (random) never returned negative values.
4090 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4091 subseconds part to the entropy, as that's a bit more random.
4092 Prefer signed to unsigned, since the signedness doesn't matter and
4093 in general we prefer signed. When given a limit, use a
4094 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4095 latter isn't right if USE_2_TAGS_FOR_INTS.
4096 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4097 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4099 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4101 * textprop.c (text_property_stickiness):
4102 Obey Vtext_property_default_nonsticky.
4103 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4104 * w32fns.c (syms_of_w32fns):
4105 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4107 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4109 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4110 This is more efficient than Ffile_directory_p and avoids a minor race.
4112 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4114 * buffer.c (Foverlay_put): Say what the return value is
4117 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4118 is a directory before asking whether to use the file name
4120 (barf_or_query_if_file_exists): Make the "File is a directory"
4121 error be more correct.
4123 * fns.c (Frequire): Remove the mention of the .gz files, since
4124 that's installation-specific, but keep the mention of
4125 `get-load-suffixes'.
4127 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4129 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4130 Report string overflow if the output is too long.
4132 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4134 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4135 (syms_of_gnutls): Remove duplicate DEFSYM for
4136 Qgnutls_bootprop_verify_hostname_error, an error for
4137 Qgnutls_bootprop_verify_error (which is no longer used).
4139 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4140 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4141 Also (re)move comments that are misplaced or no longer relevant.
4143 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4145 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4147 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4149 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4150 and background color parameters if they have been changed.
4152 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4154 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4156 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4158 * xsettings.c (SYSTEM_FONT): Define only when used.
4159 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4161 * keymap.c (access_keymap_1): Now static.
4163 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4165 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4166 leave any prefix arg for the up event (Bug#1586).
4168 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4170 * lread.c (syms_of_lread): Mention single symbols defined by
4171 `defvar' or `defconst' (bug#7154).
4173 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4174 (Frequire): Mention get-load-suffixes.
4176 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4178 * window.h (window): Remove clone_number slot.
4179 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4181 (make_parent_window, make_window, saved_window)
4182 (Fset_window_configuration, save_window_save): Don't deal with
4184 * buffer.c (Qclone_number): Remove declaration.
4185 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4187 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4189 Add multiple inheritance to keymaps.
4190 * keymap.c (Fmake_composed_keymap): New function.
4191 (Fset_keymap_parent): Simplify.
4192 (fix_submap_inheritance): Remove.
4193 (access_keymap_1): New function extracted from access_keymap to handle
4194 embedded parents and handle lists of maps.
4195 (access_keymap): Use it.
4196 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4197 (Fcopy_keymap): Handle embedded parents.
4198 (Fcommand_remapping, define_as_prefix): Simplify.
4199 (Fkey_binding): Simplify.
4200 (syms_of_keymap): Move minibuffer-local-completion-map,
4201 minibuffer-local-filename-completion-map,
4202 minibuffer-local-must-match-map, and
4203 minibuffer-local-filename-must-match-map to Elisp.
4204 (syms_of_keymap): Defsubr make-composed-keymap.
4205 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4206 (parse_menu_item): Trivial simplification.
4208 2011-07-01 Glenn Morris <rgm@gnu.org>
4210 * Makefile.in (SETTINGS_LIBS): Fix typo.
4212 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4214 * coding.c (Fencode_coding_string): Record the last coding system
4215 used, as the function doc string says (bug#8738).
4217 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4219 * xsettings.c (store_monospaced_changed): Take new font as arg and
4220 check for change against current_mono_font.
4221 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4222 (emacs_settings_constructor, emacs_settings_get_property)
4223 (emacs_settings_set_property, emacs_settings_class_init)
4224 (emacs_settings_init, gsettings_obj): Remove.
4225 (something_changedCB): New function for HAVE_GSETTINGS.
4226 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4227 with value as argument.
4228 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4229 g_settings_new (Bug#8967). Do not create gsettings_obj.
4230 Remove calls to g_settings_bind. Connect something_changedCB to
4233 * xgselect.c: Add defined (HAVE_GSETTINGS).
4234 (xgselect_initialize): Ditto.
4236 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4237 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4240 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4242 * eval.c (struct backtrace): Simplify and port the data structure.
4243 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4244 signed bit field, as this assumption is not portable and it makes
4245 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4246 "char debug_on_exit : 1" as this is not portable either; instead,
4247 use the portable "unsigned int debug_on_exit : 1". Remove unused
4248 member evalargs. Remove obsolete comments about cc bombing out.
4250 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4252 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4253 Let HAVE_GSETTINGS override HAVE_GCONF.
4254 (store_monospaced_changed): New function.
4255 (EMACS_SETTINGS): A new type derived from GObject to handle
4256 GSettings notifications.
4257 (emacs_settings_constructor, emacs_settings_get_property)
4258 (emacs_settings_set_property, emacs_settings_class_init):
4260 (gsettings_client, gsettings_obj): New variables.
4261 (GSETTINGS_SCHEMA): New define.
4262 (something_changedCB): Call store_monospaced_changed.
4263 (init_gsettings): New function.
4264 (xsettings_initialize): Call init_gsettings.
4265 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4268 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4271 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4273 * window.c (resize_root_window, grow_mini_window)
4274 (shrink_mini_window): Rename Qresize_root_window to
4275 Qwindow_resize_root_window and Qresize_root_window_vertically to
4276 Qwindow_resize_root_window_vertically.
4278 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4280 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4282 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4284 * makefile.w32-in: Redesign dependencies so they reflect more
4285 clearly which files are directly included by each source file,
4286 and not through other includes.
4288 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4290 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4291 (sort_overlays, overlay_strings): When an overlay's clone number
4292 matches the window's clone number process the overlay even if
4293 the overlay's window property doesn't match the current window.
4295 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4296 (Fwindow_hchild): Rename to Fwindow_left_child.
4297 (Fwindow_next): Rename to Fwindow_next_sibling.
4298 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4299 (resize_window_check): Rename to window_resize_check.
4300 (resize_window_apply): Rename to window_resize_apply.
4301 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4302 (Fdelete_other_windows_internal, resize_frame_windows)
4303 (Fsplit_window_internal, Fdelete_window_internal)
4304 (grow_mini_window, shrink_mini_window)
4305 (Fresize_mini_window_internal): Fix callers accordingly.
4307 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4309 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4310 (emacs_fixed_set_min_size): Remove.
4311 (emacs_fixed_new): Take frame as argument.
4313 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4314 (_EmacsFixedPrivate): Remove minwidth/height.
4315 Add struct frame *f.
4316 (emacs_fixed_init): Initialize priv->f.
4317 (get_parent_class, emacs_fixed_set_min_size): Remove.
4318 (emacs_fixed_new): Set priv->f to argument.
4319 (emacs_fixed_get_preferred_width)
4320 (emacs_fixed_get_preferred_height): Use min_width/height from
4321 frames size_hint to set minimum and natural (Bug#8919).
4322 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4323 and use min_width/height from frames size_hint to set
4324 min_width/height (Bug#8919).
4326 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4327 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4330 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4332 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4333 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4336 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4338 * process.c (wait_reading_process_output): Bypass select if
4339 waiting for a cell while ignoring keyboard input, and input is
4340 pending. Suggested by Jan Djärv (Bug#8869).
4342 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4344 Use gnulib's dup2 module instead of rolling our own.
4345 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4347 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4349 * dispnew.c (scrolling_window): Before scrolling, turn off a
4350 mouse-highlight in the window being scrolled.
4352 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4354 Move DEFSYM to lisp.h and use everywhere.
4356 * character.h (DEFSYM): Move declaration...
4357 * lisp.h (DEFSYM): ...here.
4363 * w32select.c: Don't include character.h.
4365 * alloc.c (syms_of_alloc):
4366 * buffer.c (syms_of_buffer):
4367 * bytecode.c (syms_of_bytecode):
4368 * callint.c (syms_of_callint):
4369 * casefiddle.c (syms_of_casefiddle):
4370 * casetab.c (init_casetab_once):
4371 * category.c (init_category_once, syms_of_category):
4372 * ccl.c (syms_of_ccl):
4373 * cmds.c (syms_of_cmds):
4374 * composite.c (syms_of_composite):
4375 * dbusbind.c (syms_of_dbusbind):
4376 * dired.c (syms_of_dired):
4377 * dispnew.c (syms_of_display):
4378 * doc.c (syms_of_doc):
4379 * editfns.c (syms_of_editfns):
4380 * emacs.c (syms_of_emacs):
4381 * eval.c (syms_of_eval):
4382 * fileio.c (syms_of_fileio):
4383 * fns.c (syms_of_fns):
4384 * frame.c (syms_of_frame):
4385 * fringe.c (syms_of_fringe):
4386 * insdel.c (syms_of_insdel):
4387 * keymap.c (syms_of_keymap):
4388 * lread.c (init_obarray, syms_of_lread):
4389 * macros.c (syms_of_macros):
4390 * msdos.c (syms_of_msdos):
4391 * print.c (syms_of_print):
4392 * process.c (syms_of_process):
4393 * search.c (syms_of_search):
4394 * sound.c (syms_of_sound):
4395 * syntax.c (init_syntax_once, syms_of_syntax):
4396 * terminal.c (syms_of_terminal):
4397 * textprop.c (syms_of_textprop):
4398 * undo.c (syms_of_undo):
4399 * w32.c (globals_of_w32):
4400 * window.c (syms_of_window):
4401 * xdisp.c (syms_of_xdisp):
4402 * xfaces.c (syms_of_xfaces):
4403 * xfns.c (syms_of_xfns):
4404 * xmenu.c (syms_of_xmenu):
4405 * xsettings.c (syms_of_xsettings):
4406 * xterm.c (syms_of_xterm): Use DEFSYM.
4408 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4410 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4412 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4414 Integer and buffer overflow fixes (Bug#8873).
4416 * print.c (printchar, strout): Check for string overflow.
4417 (PRINTPREPARE, printchar, strout):
4418 Don't set size unless allocation succeeds.
4420 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4421 for sizes. Check for string overflow more accurately.
4422 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4424 * macros.c: Integer and buffer overflow fixes.
4425 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4426 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4427 Use ptrdiff_t, not int, for sizes.
4428 Don't increment bufsize until after realloc succeeds.
4429 Check for size-calculation overflow.
4430 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4432 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4434 * lread.c: Integer overflow fixes.
4435 (read_integer): Radix is now EMACS_INT, not int,
4436 to improve quality of diagnostics for out-of-range radices.
4437 Calculate buffer size correctly for out-of-range radices.
4438 (read1): Check for integer overflow in radices, and in
4439 read-circle numbers.
4440 (read_escape): Avoid int overflow.
4441 (Fload, openp, read_buffer_size, read1)
4442 (substitute_object_recurse, read_vector, read_list, map_obarray):
4443 Use ptrdiff_t, not int, for sizes.
4444 (read1): Use EMACS_INT, not int, for sizes.
4445 Check for size overflow.
4447 * image.c (cache_image): Check for size arithmetic overflow.
4449 * lread.c: Integer overflow issues.
4450 (saved_doc_string_size, saved_doc_string_length)
4451 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4452 Now ptrdiff_t, not int.
4453 (read1): Don't assume doc string length fits in int. Check for
4454 out-of-range doc string lengths.
4455 (read_list): Don't assume file position fits in int.
4456 (read_escape): Check for hex character overflow.
4458 2011-06-22 Leo Liu <sdl.web@gmail.com>
4460 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4461 Move to minibuffer.el.
4463 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4465 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4466 The following patches are for when GLYPH_DEBUG && !XASSERT.
4467 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4468 * dispnew.c (flush_stdout):
4469 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4470 Mark as externally visible.
4471 * dispnew.c (check_window_matrix_pointers): Now static.
4472 * dispnew.c (window_to_frame_vpos):
4473 * xfns.c (unwind_create_frame):
4474 * xterm.c (x_check_font): Remove unused local.
4475 * scroll.c (CHECK_BOUNDS):
4476 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4477 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4478 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4479 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4480 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4482 (debug_method_add): Use va_list and vsprintf rather than relying
4483 on undefined behavior with wrong number of arguments.
4484 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4485 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4486 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4487 since we're not interested in debugging glyphs with old libraries.
4488 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4489 GCC 4.6.0's static checking.
4491 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4493 Integer overflow and signedness fixes (Bug#8873).
4494 A few related buffer overrun fixes, too.
4496 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4498 * dispextern.h (struct face.stipple):
4499 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4500 (x_bitmap_mask, x_allocate_bitmap_record)
4501 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4502 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4503 (x_create_bitmap_from_xpm_data):
4504 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4505 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4507 * xfaces.c (load_pixmap):
4508 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4509 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4510 (.bitmaps_last, struct x_output.icon_bitmap):
4511 Use ptrdiff_t, not int, for bitmap indexes.
4512 (x_allocate_bitmap_record): Check for size overflow.
4513 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4515 Use ptrdiff_t, not int, for overlay counts.
4516 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4517 * editfns.c (overlays_around, get_pos_property):
4518 * textprop.c (get_char_property_and_overlay):
4519 * xdisp.c (next_overlay_change, note_mouse_highlight):
4520 * xfaces.c (face_at_buffer_position):
4521 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4522 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4523 (Fnext_overlay_change, Fprevious_overlay_change)
4524 (mouse_face_overlay_overlaps, Foverlays_in):
4525 Use ptrdiff_t, not int, for sizes.
4526 (overlays_at, overlays_in): Check for size-calculation overflow.
4528 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4530 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4531 (x_session_initialize): Do not assume string length fits in int.
4533 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4534 This is unlikely, but can occur if DPI is outlandish.
4536 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4537 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4539 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4540 * xrdb.c (magic_file_p, search_magic_path):
4541 Omit last arg SUFFIX; it was always 0. All callers changed.
4542 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4544 * xfont.c (xfont_match): Avoid need for strlen.
4546 * xfns.c: Don't assume strlen fits in int.
4547 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4549 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4550 not unsigned long, as we prefer signed integers. All callers changed.
4551 Detect integer overflow in repeat count.
4552 (message_dolog): Don't assume print length fits in 39 bytes.
4553 (display_mode_element): Don't assume strlen fits in int.
4555 * termcap.c: Don't assume sizes fit in int and never overflow.
4556 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4557 (gobble_line): Check for size-calculation overflow.
4559 * minibuf.c (Fread_buffer):
4560 * lread.c (intern, intern_c_string):
4561 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4562 Don't assume string length fits in int.
4564 * keyboard.c (parse_tool_bar_item):
4565 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4567 * font.c: Don't assume string length fits in int.
4568 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4569 Use ptrdiff_t, not int.
4570 (font_intern_prop): Don't assume string length fits in int.
4571 Don't assume integer property fits in fixnum.
4572 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4574 * filelock.c: Fix some buffer overrun and integer overflow issues.
4575 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4576 Reformulate so as not to need the command string.
4577 Invoke gzip -cd rather than gunzip, as it's more portable.
4578 (lock_info_type, lock_file_1, lock_file):
4579 Don't assume pid_t and time_t fit in unsigned long.
4580 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4581 (current_lock_owner): Prefer signed type for sizes.
4582 Use memcpy, not strncpy, where memcpy is what is really wanted.
4583 Don't assume (via atoi) that time_t and pid_t fit in int.
4584 Check for time_t and/or pid_t out of range, e.g., via a network share.
4585 Don't alloca where an auto var works fine.
4587 * fileio.c: Fix some integer overflow issues.
4588 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4589 Don't assume string length fits in int.
4590 (directory_file_name): Don't assume string length fits in long.
4591 (make_temp_name): Don't assume pid fits in int, or that its print
4592 length is less than 20.
4594 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4596 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4598 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4600 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4601 We prefer signed integers, even for size calculations.
4603 * emacs.c: Don't assume string length fits in 'int'.
4604 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4605 (main): Don't invoke strlen when not needed.
4607 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4608 (XD_DEBUG_MESSAGE): Don't waste a byte.
4610 * callproc.c (getenv_internal_1, getenv_internal)
4612 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4614 * lread.c (invalid_syntax): Omit length argument.
4615 All uses changed. This doesn't fix a bug, but it simplifies the
4616 code away from its former Hollerith-constant appearance, and it's
4617 one less 'int' to worry about when looking at integer-overflow issues.
4618 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4620 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4621 This didn't break anything, but it didn't help either.
4622 It's confusing to put a bogus integer in a place where the actual
4623 value does not matter.
4624 (LIST_END_P): Remove unused macro and its bogus comment.
4625 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4627 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4628 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4630 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4631 We prefer signed types, and the value cannot exceed the EMACS_INT
4632 range anyway (because otherwise the length would not be representable).
4633 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4634 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4635 This avoids a GCC warning when WIDE_EMACS_INT.
4637 * indent.c (sane_tab_width): New function.
4638 (current_column, scan_for_column, Findent_to, position_indentation)
4639 (compute_motion): Use it. This is just for clarity.
4640 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4642 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4644 * lisp.h (lint_assume): New macro.
4645 * composite.c (composition_gstring_put_cache):
4646 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4648 * editfns.c, insdel.c:
4649 Omit unnecessary forward decls, to simplify future changes.
4651 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4653 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4655 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4656 Use much-faster test for byte-length change.
4657 Don't assume string byte-length fits in 'int'.
4658 Check that character arg fits in 'int'.
4659 (mapcar1): Declare byte as byte, for clarity.
4661 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4663 * fns.c (concat): Catch string overflow earlier.
4664 Do not rely on integer wraparound.
4666 * dispextern.h (struct it.overlay_strings_charpos)
4667 (struct it.selective): Now EMACS_INT, not int.
4668 * xdisp.c (forward_to_next_line_start)
4669 (back_to_previous_visible_line_start)
4670 (reseat_at_next_visible_line_start, next_element_from_buffer):
4671 Don't arbitrarily truncate the value of 'selective' to int.
4673 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4675 * composite.c: Don't truncate sizes to 'int'.
4676 (composition_gstring_p, composition_reseat_it)
4677 (composition_adjust_point): Use EMACS_INT, not int.
4678 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4679 not EMACS_UINT, for indexes.
4681 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4683 * buffer.c: Include <verify.h>.
4684 (struct sortvec.priority, struct sortstr.priority):
4685 Now EMACS_INT, not int.
4686 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4687 (struct sortstr.size, record_overlay_string)
4688 (struct sortstrlist.size, struct sortlist.used):
4689 Don't truncate size to int.
4690 (record_overlay_string): Check for size-calculation overflow.
4691 (init_buffer_once): Check at compile-time, not run-time.
4693 2011-06-22 Jim Meyering <meyering@redhat.com>
4695 Don't leak an XBM-image-sized buffer
4696 * image.c (xbm_load): Free the image buffer after using it.
4698 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4701 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4702 that Sun C diagnosed.
4703 * fns.c (secure_hash): Fix pointer signedness issue.
4704 * intervals.c (static_offset_intervals): New function.
4705 (offset_intervals): Use it.
4707 2011-06-21 Leo Liu <sdl.web@gmail.com>
4710 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4713 * fns.c (secure_hash): Rename from crypto_hash_function and change
4714 the first arg to accept symbols.
4715 (Fsecure_hash): New primitive.
4716 (syms_of_fns): New symbols.
4718 2011-06-20 Deniz Dogan <deniz@dogan.se>
4720 * process.c (Fset_process_buffer): Clarify return value in
4723 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4725 * dispnew.c (add_window_display_history): Use BVAR.
4727 * xdisp.c (debug_method_add): Use BVAR.
4728 (check_window_end, dump_glyph_matrix, dump_glyph)
4729 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4731 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4734 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4735 check till after the cache is created in init_frame_faces.
4737 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4739 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4741 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4743 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4744 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4745 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4747 Improve buffer-overflow checking (Bug#8873).
4748 * fileio.c (Finsert_file_contents):
4749 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4750 Remove the old (too-loose) buffer overflow checks.
4751 They weren't needed, since make_gap checks for buffer overflow.
4752 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4753 The old code merely checked for Emacs fixnum overflow, and relied
4754 on undefined (wraparound) behavior. The new code avoids undefined
4755 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4757 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4758 Tune. Don't use wider integers than needed. Don't use alloca.
4759 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4761 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4763 * insdel.c, lisp.h (buffer_overflow): New function.
4764 (insert_from_buffer_1, replace_range, replace_range_2):
4765 * insdel.c (make_gap_larger):
4766 * editfns.c (Finsert_char):
4767 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4769 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4771 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4773 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4775 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4776 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4778 * fileio.c: Don't assume EMACS_INT fits in off_t.
4779 (emacs_lseek): New static function.
4780 (Finsert_file_contents, Fwrite_region): Use it.
4781 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4783 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4785 * fns.c: Don't overflow int when computing a list length.
4786 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4787 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4788 truncation on 64-bit hosts. Check for QUIT every
4789 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4790 faster and is responsive enough.
4791 (Flength): Report an error instead of overflowing an integer.
4792 (Fsafe_length): Return a float if the value is not representable
4793 as a fixnum. This shouldn't happen except in contrived situations.
4794 (Fnthcdr, Fsort): Don't assume list length fits in int.
4795 (Fcopy_sequence): Don't assume vector length fits in int.
4797 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4798 (header_size, word_size): New constants.
4799 (allocate_vectorlike): Don't check size overflow here.
4800 (allocate_vector): Check it here instead, since this is the only
4801 caller of allocate_vectorlike that could cause overflow.
4802 Check that the new vector's length is representable as a fixnum.
4804 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4805 The previous code was bogus. For example, next_almost_prime (32)
4806 returned 39, which is undesirable as it is a multiple of 3; and
4807 next_almost_prime (24) returned 25, which is a multiple of 5 so
4808 why was the code bothering to check for multiples of 7?
4810 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4812 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4814 Variadic C functions now count arguments with ptrdiff_t.
4815 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4816 Back then I didn't know that the Emacs coding style prefers signed int.
4817 Also, in the meantime I found a few more instances where arguments
4818 were being counted with int, which may truncate counts on 64-bit
4819 machines, or EMACS_INT, which may be unnecessarily wide.
4820 * lisp.h (struct Lisp_Subr.function.aMANY)
4821 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4822 Arg counts are now ptrdiff_t, not size_t.
4823 All variadic functions and their callers changed accordingly.
4824 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4825 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4826 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4827 * callint.c (Fcall_interactively): Check arg count for overflow,
4828 to avoid potential buffer overrun. Use signed char, not 'int',
4829 for 'varies' array, so that we needn't bother to check its size
4830 calculation for overflow.
4831 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4832 * eval.c (apply_lambda):
4833 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4834 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4835 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4837 * callint.c (Fcall_interactively): Don't use index var as event count.
4839 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4840 * mem-limits.h (SIZE): Remove; no longer used.
4842 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4844 Remove unnecessary casts.
4845 * xterm.c (x_term_init):
4846 * xfns.c (x_set_border_pixel):
4847 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4848 These aren't needed now that we assume ANSI C.
4850 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4851 It's more likely to cause problems (due to unsigned overflow)
4854 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4856 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4858 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4860 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4862 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4864 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4866 GLYPH_CODE_FACE returns EMACS_INT, not int.
4867 * dispextern.h (merge_faces):
4868 * xfaces.c (merge_faces):
4869 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4870 Don't assume EMACS_INT fits in int.
4872 * character.h (CHAR_VALID_P): Remove unused parameter.
4873 * fontset.c, lisp.h, xdisp.c: All uses changed.
4875 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4877 * fns.c (concat): Minor tuning based on overflow analysis.
4878 This doesn't fix any bugs. Use int to hold character, instead
4879 of constantly refetching from Emacs object. Use XFASTINT, not
4880 XINT, for value known to be a character. Don't bother comparing
4881 a single byte to 0400, as it's always less.
4883 * floatfns.c (Fexpt):
4884 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4886 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4889 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4891 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4892 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4893 incorrectly succeed when S was a string, because 4294967386 was
4894 truncated before it was used.
4896 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4897 Otherwise, an out-of-range integer could cause undefined behavior
4900 * composite.c: Use int, not EMACS_INT, for characters.
4901 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4902 EMACS_INT, for values that are known to be in character range.
4903 This doesn't fix any bugs but is the usual style inside Emacs and
4904 may generate better code on 32-bit machines.
4906 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4907 This is for reasons similar to the recent CHAR_STRING fix.
4908 * charset.c (Fencode_char): Check that character arg is actually
4909 a character. Pass an int to ENCODE_CHAR.
4910 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4911 wider than 'int', as a compile-time check to prevent future regressions
4914 * character.c (char_string): Remove unnecessary casts.
4916 Make sure a 64-bit char is never passed to CHAR_STRING.
4917 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4918 by silently ignoring the top 32 bits, allowing some values
4919 that were far too large to be valid characters.
4920 * character.h: Include <verify.h>.
4921 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4922 arguments are no wider than unsigned, as a compile-time check
4923 to prevent future regressions in this area.
4925 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4926 (Fsubst_char_in_region):
4928 * xdisp.c (decode_mode_spec_coding):
4929 Adjust to CHAR_STRING's new requirement.
4930 * editfns.c (Finsert_char, Fsubst_char_in_region):
4931 * fns.c (concat): Check that character args are actually
4932 characters. Without this test, these functions did the wrong
4933 thing with wildly out-of-range values on 64-bit hosts.
4935 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4936 These casts should not be needed on 32-bit hosts, either.
4937 * keyboard.c (read_char):
4938 * lread.c (Fload): Remove casts to unsigned.
4940 * lisp.h (UNSIGNED_CMP): New macro.
4941 This fixes comparison bugs on 64-bit hosts.
4942 (ASCII_CHAR_P): Use it.
4943 * casefiddle.c (casify_object):
4944 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4945 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4946 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4947 * dispextern.h (FACE_FROM_ID):
4948 * keyboard.c (read_char): Use UNSIGNED_CMP.
4950 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4951 not to EMACS_INT, to avoid GCC warning.
4953 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4955 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4956 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4957 isn't needed on 32-bit machines.
4959 * buffer.c (Fgenerate_new_buffer_name):
4960 Use EMACS_INT for count, not int.
4961 (advance_to_char_boundary): Return EMACS_INT, not int.
4963 * data.c (Qcompiled_function): Now static.
4965 * window.c (window_body_lines): Now static.
4967 * image.c (gif_load): Rename local to avoid shadowing.
4969 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4970 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4971 * alloc.c (make_save_value): Integer argument is now of type
4973 (mark_object): Use ptrdiff_t, not int.
4974 * lisp.h (pD): New macro.
4975 * print.c (print_object): Use it.
4977 * alloc.c: Use EMACS_INT, not int, to count objects.
4978 (total_conses, total_markers, total_symbols, total_vector_size)
4979 (total_free_conses, total_free_markers, total_free_symbols)
4980 (total_free_floats, total_floats, total_free_intervals)
4981 (total_intervals, total_strings, total_free_strings):
4982 Now EMACS_INT, not int. All uses changed.
4983 (Fgarbage_collect): Compute overall total using a double, so that
4984 integer overflow is less likely to be a problem. Check for overflow
4985 when converting back to an integer.
4986 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4987 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4988 These were 'int' variables that could overflow on 64-bit hosts;
4989 they were never used, so remove them instead of repairing them.
4990 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4991 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4992 Previously, this ceilinged at INT_MAX, but that doesn't work on
4994 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4996 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4997 (allocate_vectorlike): Check for ptrdiff_t overflow.
4998 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4999 when a (possibly-narrower) signed value would do just as well.
5000 We prefer using signed arithmetic, to avoid comparison confusion.
5002 * alloc.c: Catch some string size overflows that we were missing.
5003 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5004 for convenience in STRING_BYTES_MAX.
5005 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5006 The definition here is exact; the one in lisp.h was approximate.
5007 (allocate_string_data): Check for string overflow. This catches
5008 some instances we weren't catching before. Also, it catches
5009 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5010 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5011 and ptrdiff_t and EMACS_INT are both 64 bits.
5013 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5014 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5015 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5017 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5019 * alloc.c (Fmake_string): Check for out-of-range init.
5021 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5023 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5025 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5027 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5028 xg_get_default_scrollbar_width.
5030 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5031 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5032 (style_changed_cb): Call update_theme_scrollbar_width and call
5033 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5034 all frames (Bug#8505).
5035 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5036 Call gtk_window_set_resizable if HAVE_GTK3.
5037 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5038 and height if HAVE_GTK3 (Bug#8505).
5039 (scroll_bar_width_for_theme): New variable.
5040 (update_theme_scrollbar_width): New function.
5041 (xg_get_default_scrollbar_width): Move code to
5042 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5043 (xg_initialize): Call update_theme_scrollbar_width.
5045 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5047 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5049 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5051 * frame.c (make_frame): Call other_buffer_safely instead of
5054 * window.c (temp_output_buffer_show): Call display_buffer with
5055 second argument Vtemp_buffer_show_specifiers and reset latter
5056 immediately after the call.
5057 (Vtemp_buffer_show_specifiers): New variable.
5058 (auto_window_vscroll_p, next_screen_context_lines)
5059 (Vscroll_preserve_screen_position): Remove leading asterisks from
5062 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5064 Fix minor problems found by GCC 4.6.0 static checking.
5065 * buffer.c (Qclone_number): Remove for now, as it's unused.
5066 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5067 (record_buffer): Remove unused local.
5068 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5069 (set_frame_buffer_list): Remove; unused.
5070 * frame.h (other_visible_frames): Remove decl.
5071 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5072 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5073 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5075 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5076 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5077 Define only if HAVE_GPM.
5078 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5079 (update_hints_inhibit): Remove; never set. All uses removed.
5080 * widgetprv.h (emacsFrameClassRec): Remove decl.
5081 * window.c (delete_deletable_window): Now returns void, since it
5082 wasn't returning anything.
5083 (compare_window_configurations): Remove unused locals.
5084 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5085 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5086 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5087 the same widths as pointers. This follows up on the 2011-05-06 patch.
5088 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5089 * xterm.h: Likewise.
5090 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5092 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5094 * makefile.w32-in: Update dependencies.
5095 (LISP_H): Add lib/intprops.h.
5097 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5099 * image.c (gif_load): Add animation frame delay to the metadata.
5100 (syms_of_image): Use DEFSYM. New symbol `delay'.
5102 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5104 * window.c (delete_deletable_window): Re-add.
5105 (Fset_window_configuration): Rewrite to handle dead buffers and
5106 consequently deletable windows.
5107 (window_tree, Fwindow_tree): Remove. Supply functionality in
5109 (compare_window_configurations): Simplify code.
5111 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5113 * image.c (imagemagick_load_image): Fix type mismatch.
5114 (Fimagemagick_types): Likewise.
5116 * window.h (replace_buffer_in_windows): Declare.
5118 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5120 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5121 Qclone_number. Remove external declaration of Qdelete_window.
5122 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5124 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5125 Run Qbuffer_list_update_hook if allowed.
5126 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5127 buffer list implementation.
5128 (other_buffer_safely): New function.
5129 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5130 calls to replace_buffer_in_windows and
5131 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5133 (record_buffer): Inhibit quitting and rewrite using quittable
5134 functions. Run Qbuffer_list_update_hook if allowed.
5135 (Frecord_buffer, Funrecord_buffer): New functions.
5136 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5137 Move switch-to-buffer to window.el.
5138 (bury-buffer): Move to window.el.
5139 (Vbuffer_list_update_hook): New variable.
5141 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5144 * window.h (resize_frame_windows): Move up in code.
5145 (Fwindow_frame): Remove EXFUN.
5146 (replace_buffer_in_all_windows): Remove prototype.
5147 (replace_buffer_in_windows_safely): Add prototype.
5149 * window.c: Declare Qdelete_window static again. Move down
5150 declaration of select_count.
5151 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5152 (Fother_window): Move to window.el.
5153 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5154 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5155 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5157 (replace_buffer_in_windows): Implement by calling
5158 Qreplace_buffer_in_windows.
5159 (replace_buffer_in_all_windows): Remove with some functionality
5160 moved into replace_buffer_in_windows_safely.
5161 (replace_buffer_in_windows_safely): New function.
5162 (select_window_norecord, select_frame_norecord): Move in front
5163 of run_window_configuration_change_hook. Remove now obsolete
5165 (Fset_window_buffer): Rewrite doc-string.
5166 Call Qrecord_window_buffer.
5167 (keys_of_window): Move binding for other-window to window.el.
5169 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5171 * dispextern.h (struct image): Replace data member, whose int_val
5172 and ptr_val fields were not used by anything, with a single
5175 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5176 (gif_clear_image, gif_load, imagemagick_load_image)
5177 (gs_clear_image, gs_load): Callers changed.
5179 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5181 * buffer.h: Include <time.h>, for time_t.
5182 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5184 Fix minor problems found by static checking.
5186 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5188 Make identifiers static if they are not used in other modules.
5189 * data.c (Qcompiled_function, Qframe, Qvector):
5190 * image.c (QimageMagick, Qsvg):
5191 * minibuf.c (Qmetadata):
5192 * window.c (resize_window_check, resize_root_window): Now static.
5193 * window.h (resize_window_check, resize_root_window): Remove decls.
5195 * window.c (window_deletion_count, delete_deletable_window):
5197 (window_body_lines): Now static.
5198 (Fdelete_other_windows_internal): Mark vars as initialized.
5199 Make sure 'resize_failed' is initialized.
5200 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5201 (resize_window_apply): Remove unused local.
5202 * window.h (delete_deletable_window): Remove decl.
5204 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5205 (imagemagick_load_image): Fix pointer signedness problem by changing
5206 last arg from unsigned char * to char *. All uses changed.
5207 Also, fix a local for similar reasons.
5208 Remove unused locals. Remove locals to avoid shadowing.
5209 (fn_rsvg_handle_free): Remove; unused.
5210 (svg_load, svg_load_image): Fix pointer signedness problem.
5211 (imagemagick_load_image): Don't use garbage pointer image_wand.
5213 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5215 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5217 * image.c (gif_load): Fix omitted cast error introduced by
5220 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5222 * window.h (resize_proportionally, orig_total_lines)
5223 (orig_top_line): Remove from window structure.
5224 (set_window_height, set_window_width, change_window_heights)
5225 (Fdelete_window): Remove prototypes.
5226 (resize_frame_windows): Remove duplicate declaration.
5228 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5230 * window.h (resize_frame_windows, resize_window_check)
5231 (delete_deletable_window, resize_root_window)
5232 (resize_frame_windows): Declare prototypes.
5234 * window.c (resize_window_apply): Make definition be "static" to
5235 match the prototype.
5237 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5239 * window.c: Remove declarations of Qwindow_size_fixed,
5240 window_min_size_1, window_min_size_2, window_min_size,
5241 size_window, window_fixed_size_p, enlarge_window, delete_window.
5242 Remove static from declaration of Qdelete_window, it's
5243 temporarily needed by Fbury_buffer.
5244 (replace_window): Don't assign orig_top_line and
5246 (Fdelete_window, delete_window): Remove. Window deletion is
5247 handled by window.el.
5248 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5249 Replace Fdelete_window calls with calls to Qdelete_window.
5250 (Fdelete_other_windows): Remove. Deleting other windows is
5251 handled by window.el.
5252 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5253 handled in window.el.
5254 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5255 Window minimum sizes are handled in window.el.
5256 (shrink_windows, size_window, set_window_height)
5257 (set_window_width, change_window_heights, window_height)
5258 (window_width, CURBEG, CURSIZE, enlarge_window)
5259 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5260 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5261 handled in window.el.
5262 (make_dummy_parent): Rename to make_parent_window and give it a
5263 second argument horflag.
5264 (make_window): Don't set resize_proportionally any more.
5265 (Fsplit_window): Remove. Windows are split in window.el.
5266 (save_restore_action, save_restore_orig_size)
5267 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5268 Resize mini windows in window.el.
5269 (grow_mini_window, shrink_mini_window): Implement by calling
5270 Qresize_root_window_vertically, resize_window_check and
5271 resize_window_apply.
5272 (saved_window, Fset_window_configuration, save_window_save):
5273 Do not handle orig_top_line, orig_total_lines, and
5274 resize_proportionally.
5275 (window_min_height, window_min_width): Move to window.el.
5276 (keys_of_window): Move bindings for delete-other-windows,
5277 split-window, delete-window and enlarge-window to window.el.
5279 * buffer.c: Temporarily extern Qdelete_window.
5280 (Fbury_buffer): Temporarily call Qdelete_window instead of
5281 Fdelete_window (Fbury_buffer will move to window.el soon).
5283 * frame.c (set_menu_bar_lines_1): Remove code handling
5284 orig_top_line and orig_total_lines.
5286 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5287 set_window_height but set heights directly.
5288 (change_frame_size_1): Use resize_frame_windows.
5290 * xdisp.c (init_xdisp): Don't use set_window_height but set
5293 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5294 Use resize_frame_windows instead of change_window_heights and run
5295 run_window_configuration_change_hook.
5297 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5298 instead of change_window_heights and run
5299 run_window_configuration_change_hook.
5301 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5303 * window.c (replace_window): Rename second argument REPLACEMENT to
5304 NEW. New third argument SETFLAG. Rewrite.
5305 (delete_window, make_dummy_parent): Call replace_window with
5307 (window_list_1): Move down in code.
5308 (run_window_configuration_change_hook): Move set_buffer part
5309 before select_frame_norecord part in order to unwind correctly.
5310 Rename count1 to count.
5311 (recombine_windows, delete_deletable_window, resize_root_window)
5312 (Fdelete_other_windows_internal)
5313 (Frun_window_configuration_change_hook, make_parent_window)
5314 (resize_window_check, resize_window_apply, Fresize_window_apply)
5315 (resize_frame_windows, Fsplit_window_internal)
5316 (Fdelete_window_internal, Fresize_mini_window_internal):
5318 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5320 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5322 * window.h (window): Add some new members to window structure -
5323 normal_lines, normal_cols, new_total, new_normal, clone_number,
5324 splits, nest, prev_buffers, next_buffers.
5325 (WINDOW_TOTAL_SIZE): Move here from window.c.
5326 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5328 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5330 (make_dummy_parent): Set new members of windows structure.
5331 (make_window): Move down in code. Handle new members of window
5333 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5334 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5335 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5336 (Fset_window_prev_buffers, Fwindow_next_buffers)
5337 (Fset_window_next_buffers, Fset_window_clone_number):
5339 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5340 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5342 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5343 Argument WINDOW can be now internal window too.
5344 (Fwindow_use_time): Move up in code.
5345 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5347 (Fset_window_configuration, saved_window)
5348 (Fcurrent_window_configuration, save_window_save): Handle new
5349 members of window structure.
5350 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5351 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5352 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5353 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5354 Qget_mru_window, Qresize_root_window,
5355 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5356 Qauto_buffer_name; staticpro them.
5358 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5360 * window.c (Fwindow_total_size, Fwindow_left_column)
5361 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5362 (Fwindow_list_1): New functions.
5363 (window_box_text_cols): Replace with window_body_cols.
5364 (Fwindow_width, Fscroll_left, Fscroll_right):
5365 Use window_body_cols instead of window_box_text_cols.
5366 (delete_window, Fset_window_configuration):
5367 Call delete_all_subwindows with window as argument.
5368 (delete_all_subwindows): Take a window as argument and not a
5370 (window_loop): Remove handling of GET_LRU_WINDOW and
5372 (Fget_lru_window, Fget_largest_window): Move to window.el.
5374 * window.h: Extern window_body_cols instead of
5375 window_box_text_cols. delete_all_subwindows now takes a
5376 Lisp_Object as argument.
5378 * indent.c (compute_motion, Fcompute_motion):
5379 Use window_body_cols instead of window_box_text_cols.
5381 * frame.c (delete_frame): Call delete_all_subwindows with root
5384 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5386 * fns.c (Fputhash): Document return value.
5388 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5390 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5392 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5394 Cons<->int and similar integer overflow fixes (Bug#8794).
5396 Check for overflow when converting integer to cons and back.
5397 * charset.c (Fdefine_charset_internal, Fdecode_char):
5398 Use cons_to_unsigned to catch overflow.
5399 (Fencode_char): Use INTEGER_TO_CONS.
5400 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5401 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5402 * data.c (long_to_cons, cons_to_long): Remove.
5403 (cons_to_unsigned, cons_to_signed): New functions.
5404 These signal an error for invalid or out-of-range values.
5405 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5406 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5407 * font.c (Ffont_variation_glyphs):
5408 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5409 * lisp.h: Include <intprops.h>.
5410 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5411 (cons_to_signed, cons_to_unsigned): New decls.
5412 (long_to_cons, cons_to_long): Remove decls.
5413 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5414 (Fprimitive_undo): Use CONS_TO_INTEGER.
5415 * xfns.c (Fx_window_property): Likewise.
5416 * xselect.c: Include <limits.h>.
5417 (x_own_selection, selection_data_to_lisp_data):
5418 Use INTEGER_TO_CONS.
5419 (x_handle_selection_request, x_handle_selection_clear)
5420 (x_get_foreign_selection, Fx_disown_selection_internal)
5421 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5422 (lisp_data_to_selection_data): Use cons_to_unsigned.
5423 (x_fill_property_data): Use cons_to_signed.
5424 Report values out of range.
5426 Check for buffer and string overflow more precisely.
5427 * buffer.h (BUF_BYTES_MAX): New macro.
5428 * lisp.h (STRING_BYTES_MAX): New macro.
5429 * alloc.c (Fmake_string):
5430 * character.c (string_escape_byte8):
5431 * coding.c (coding_alloc_by_realloc):
5432 * doprnt.c (doprnt):
5433 * editfns.c (Fformat):
5435 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5436 since they may not be the same number.
5437 * editfns.c (Finsert_char):
5438 * fileio.c (Finsert_file_contents):
5439 Likewise for BUF_BYTES_MAX.
5441 * image.c: Use ptrdiff_t, not int, for sizes.
5442 (slurp_file): Switch from int to ptrdiff_t.
5444 (slurp_file): Check that file size fits in both size_t (for
5445 malloc) and ptrdiff_t (for sanity and safety).
5447 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5448 if b->modtime has its maximal value.
5450 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5452 Don't assume time_t can fit into int.
5453 * buffer.h (struct buffer.modtime): Now time_t, not int.
5454 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5455 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5457 Minor fixes for signed vs unsigned integers.
5458 * character.h (MAYBE_UNIFY_CHAR):
5459 * charset.c (maybe_unify_char):
5460 * keyboard.c (read_char, reorder_modifiers):
5461 XINT -> XFASTINT, since the integer must be nonnegative.
5462 * ftfont.c (ftfont_spec_pattern):
5463 * keymap.c (access_keymap, silly_event_symbol_error):
5464 XUINT -> XFASTINT, since the integer must be nonnegative.
5465 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5466 since it makes no difference and we prefer signed.
5467 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5468 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5471 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5473 * window.h (Fwindow_frame): Declare.
5475 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5477 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5478 (SPARE_MEMORY): Always define.
5479 (LARGE_REQUEST): Remove.
5480 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5482 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5484 * lisp.h: Move EXFUNS for Fframe_root_window,
5485 Fframe_first_window and Fset_frame_selected_window to window.h.
5487 * window.h: Move EXFUNS for Fframe_root_window,
5488 Fframe_first_window and Fset_frame_selected_window here from
5491 * frame.c (Fwindow_frame, Fframe_first_window)
5492 (Fframe_root_window, Fframe_selected_window)
5493 (Fset_frame_selected_window): Move to window.c.
5494 (Factive_minibuffer_window): Move to minibuf.c.
5495 (Fother_visible_frames_p): New function.
5497 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5499 * window.c (decode_window, decode_any_window): Move up in code.
5500 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5501 (inhibit_frame_unsplittable): Remove unused variable.
5502 (Fwindow_buffer): Move up and rewrite doc-string.
5503 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5504 (Fwindow_prev): New functions.
5505 (Fwindow_frame): Move here from frame.c. Accept any window as
5507 (Fframe_root_window, Fframe_first_window)
5508 (Fframe_selected_window): Move here from frame.c. Accept frame
5509 or arbitrary window as argument. Update doc-strings.
5510 (Fminibuffer_window): Move up in code.
5511 (Fwindow_minibuffer_p): Move up in code and simplify.
5512 (Fset_frame_selected_window): Move here from frame.c.
5514 (Fselected_window, select_window, Fselect_window): Move up in
5515 code. Minor doc-string fixes.
5517 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5519 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5520 Do not assume that spare memory exists; that assumption is valid
5521 only if SYSTEM_MALLOC.
5522 (LARGE_REQUEST): New macro, so that the issue of large requests
5523 is separated from the issue of spare memory.
5525 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5527 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5530 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5532 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5535 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5537 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5539 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5541 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5542 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5544 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5546 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5548 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5550 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5551 (x_clipboard_manager_save): Add return value.
5552 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5554 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5555 Obey Vx_select_enable_clipboard_manager. Catch errors in
5556 x_clipboard_manager_save (Bug#8779).
5557 (Vx_select_enable_clipboard_manager): New variable.
5558 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5560 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5562 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5564 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5566 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5567 in the current matrix if keep_current_p is non-zero.
5569 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5571 * bidi.c (bidi_level_of_next_char): Fix last change.
5573 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5575 Support bidi reordering of text covered by display properties.
5577 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5578 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5579 (bidi_cache_search, bidi_cache_iterator_state)
5580 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5581 (bidi_level_of_next_char, bidi_move_to_visually_next):
5582 Support character positions inside a run of characters covered by a
5584 (bidi_paragraph_init, bidi_resolve_explicit_1)
5585 (bidi_level_of_next_char): Call bidi_fetch_char and
5586 bidi_fetch_char_advance instead of FETCH_CHAR and
5588 (bidi_init_it): Initialize new members.
5589 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5591 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5592 instead of using explicit *_CHAR codes.
5593 (bidi_resolve_explicit, bidi_resolve_weak):
5594 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5595 bidirectional text is supported only in multibyte buffers.
5596 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5597 it to initialize the frame_window_p member of struct bidi_it.
5598 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5599 (bidi_resolve_explicit, bidi_resolve_weak)
5600 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5601 bidi_it->nchars is non-positive.
5602 (bidi_level_of_next_char): Don't try to lookup the cache for the
5603 next/previous character if nothing is cached there yet, or if we
5604 were just reseat()'ed to a new position.
5606 * xdisp.c (set_cursor_from_row): Set start and stop points
5607 according to the row's direction when priming the loop that looks
5608 for the glyph on which to display cursor.
5609 (single_display_spec_intangible_p): Function deleted.
5610 (display_prop_intangible_p): Reimplement to call
5611 handle_display_spec instead of single_display_spec_intangible_p.
5612 Accept 3 additional arguments needed by handle_display_spec.
5613 This fixes incorrect cursor motion across display property with complex
5614 values: lists, `(when COND...)' forms, etc.
5615 (single_display_spec_string_p): Support property values that are
5616 lists with the argument STRING its top-level element.
5617 (display_prop_string_p): Fix the condition for processing a
5618 property that is a list to be consistent with handle_display_spec.
5619 (handle_display_spec): New function, refactored from the
5620 last portion of handle_display_prop.
5621 (compute_display_string_pos): Accept additional argument
5622 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5623 value of a `display' property is a "replacing spec".
5624 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5625 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5626 the display property, but just return a value indicating whether
5627 the display property will replace the characters it covers.
5628 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5629 frame_window_p members of struct bidi_it.
5630 (compute_display_string_pos, compute_display_string_end):
5632 (push_it): Accept second argument POSITION, where pop_it should
5633 jump to continue iteration.
5634 (reseat_1): Initialize bidi_it.disp_pos.
5636 * keyboard.c (adjust_point_for_property): Adjust the call to
5637 display_prop_intangible_p to its new signature.
5639 * dispextern.h (struct bidi_it): New member frame_window_p.
5640 (bidi_init_it): Update prototypes.
5641 (display_prop_intangible_p): Update prototype.
5642 (compute_display_string_pos, compute_display_string_end):
5644 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5647 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5649 Malloc failure behavior now depends on size of allocation.
5650 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5651 * lisp.h: Change signatures accordingly.
5652 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5653 All callers changed. (Bug#8762)
5655 * gnutls.c: Use Emacs's memory allocators.
5656 Without this change, the gnutls library would invoke malloc etc.
5657 directly, which causes problems on non-SYNC_INPUT hosts, and which
5658 runs afoul of improving memory_full behavior. (Bug#8761)
5659 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5660 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5661 xfree instead of the default malloc, realloc, free.
5662 (Fgnutls_boot): No need to check for memory allocation failure,
5663 since xmalloc does that for us.
5665 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5666 * category.c (hash_get_category_set):
5667 * ccl.c (ccl_driver):
5668 * charset.c (Fdefine_charset_internal):
5669 * charset.h (struct charset.hash_index):
5670 * composite.c (get_composition_id, gstring_lookup_cache)
5671 (composition_gstring_put_cache):
5672 * composite.h (struct composition.hash_index):
5673 * dispextern.h (struct image.hash):
5674 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5675 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5676 (hashfn_equal, hashfn_user_defined, make_hash_table)
5677 (maybe_resize_hash_table, hash_lookup, hash_put)
5678 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5679 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5680 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5681 * image.c (make_image, search_image_cache, lookup_image)
5682 (xpm_put_color_table_h):
5683 * lisp.h (struct Lisp_Hash_Table):
5684 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5685 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5686 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5687 * alloc.c (allocate_vectorlike):
5688 Check for overflow in vector size calculations.
5689 * ccl.c (ccl_driver):
5690 Check for overflow when converting EMACS_INT to int.
5691 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5692 need to be updated by these changes.
5693 * fns.c (make_hash_table, maybe_resize_hash_table):
5694 Check for integer overflow with large hash tables.
5695 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5696 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5697 (SXHASH_REDUCE): New macro.
5698 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5699 Use it instead of discarding useful hash info with large hash values.
5700 (sxhash_float): New function.
5701 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5702 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5703 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5704 Rewrite to use FIXNUM_BITS, as this simplifies things.
5705 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5706 Adjust signatures to match updated version of code.
5707 (consing_since_gc): Now EMACS_INT, since a single hash table can
5708 use more than INT_MAX bytes.
5710 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5712 Make it possible to build with GCC-4.6+ -O2 -flto.
5714 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5716 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5718 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5719 Call minibuffer-inactive-mode.
5721 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5723 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5724 Update dependencies.
5726 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5728 * data.c (init_data): Remove code for UTS, this system is not
5731 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5733 Don't force ./temacs to start in terminal mode.
5735 * frame.c (make_initial_frame): Initialize faces in all cases, not
5736 only when CANNOT_DUMP is defined.
5737 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5739 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5741 * dispnew.c (add_window_display_history): Use const for the string
5742 pointer. Remove declaration, not needed.
5744 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5746 Use 'inline', not 'INLINE'.
5747 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5748 * alloc.c, fontset.c (INLINE): Remove.
5749 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5750 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5751 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5752 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5753 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5755 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5757 Make it possible to run ./temacs.
5759 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5760 syms_of_callproc does the same thing. Remove test for
5761 "initialized", do it in the caller.
5762 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5764 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5766 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5767 (read_minibuf): Use get_minibuffer.
5768 (syms_of_minibuf): Use DEFSYM.
5769 (Qmetadata): New var.
5770 * data.c (Qbuffer): Don't make it static.
5771 (syms_of_data): Use DEFSYM.
5773 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5775 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5776 (CCL_CODE_MIN): New macro.
5778 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5780 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5782 * eval.c (Qdebug): Now static.
5783 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5784 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5785 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5787 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5789 * image.c: Various fixes to ImageMagick code comments.
5790 (Fimagemagick_types): Doc fix.
5792 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5794 Minor fixes prompted by GCC 4.6.0 warnings.
5796 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5798 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5799 (x_clipboard_manager_save_all): Move extern decl to ...
5800 * xterm.h: ... here, so that it can be checked for consistency.
5802 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5804 * xselect.c (x_clipboard_manager_save_frame)
5805 (x_clipboard_manager_save_all): New functions.
5806 (Fx_clipboard_manager_save): Lisp function deleted.
5808 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5809 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5811 * xterm.h: Update prototype.
5813 2011-05-28 William Xu <william.xwl@gmail.com>
5815 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5818 2011-05-28 Jim Meyering <meyering@redhat.com>
5820 Avoid a sign-extension bug in crypto_hash_function.
5821 * fns.c (to_uchar): Define.
5822 (crypto_hash_function): Use it to convert some newly-signed
5823 variables to unsigned, to avoid sign-extension bugs. For example,
5824 without this change, (md5 "truc") would evaluate to
5825 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5826 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5827 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5829 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5831 Integer overflow fixes.
5833 * dbusbind.c: Serial number integer overflow fixes.
5834 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5835 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5836 to hold a serial number that is too large for a fixnum.
5837 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5838 Check for serial numbers out of range. Decode any serial number
5839 that was so large that it became a float. (Bug#8722)
5841 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5842 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5843 Use XFASTINT rather than XUINT when numbers are nonnegative.
5844 (xd_append_arg, Fdbus_method_return_internal):
5845 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5846 arguments, check that Lisp number is nonnegative, rather than
5847 silently wrapping negative numbers around. (Bug#8722)
5848 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5851 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5853 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5855 ccl: Add integer overflow checks.
5856 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5857 (IN_INT_RANGE): New macros.
5858 (ccl_driver): Use them to check for integer overflow when
5859 decoding a CCL program. Many of the new checks are whether XINT (x)
5860 fits in int; it doesn't always, on 64-bit hosts. The new version
5861 doesn't catch all possible integer overflows, but it's an
5862 improvement. (Bug#8719)
5864 * alloc.c (make_event_array): Use XINT, not XUINT.
5865 There's no need for unsigned here.
5867 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5868 This follows up to the 2011-05-06 change that substituted uintptr_t
5869 for EMACS_INT. This case wasn't caught back then.
5871 Rework Fformat to avoid integer overflow issues.
5872 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5873 now (part of C89). Include <verify.h>.
5874 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5875 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5876 (Fformat): Avoid the prepass trying to compute sizes; it was only
5877 approximate and thus did not catch overflow reliably. Instead, walk
5878 through the format just once, formatting and computing sizes as we go,
5879 checking for integer overflow at every step, and allocating a larger
5880 buffer as needed. Keep track separately whether the format is
5881 multibyte. Keep only the most-recently calculated precision, rather
5882 than them all. Record whether each argument has been converted to
5883 string. Use EMACS_INT, not int, for byte and char and arg counts.
5884 Support field widths and precisions larger than INT_MAX. Avoid
5885 sprintf's undefined behavior with conversion specifications such as %#d
5886 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5887 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5888 formatting out-of-range floating point numbers with int
5891 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5893 * data.c: Avoid integer truncation in expressions involving floats.
5894 * data.c: Include <intprops.h>.
5895 (arith_driver): When there's an integer overflow in an expression
5896 involving floating point, convert the integers to floating point
5897 so that the resulting value does not suffer from catastrophic
5898 integer truncation. For example, on a 64-bit host (* 4
5899 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5900 Do not rely on undefined behavior after integer overflow.
5902 merge count_size_as_multibyte, parse_str_to_multibyte
5903 * character.c, character.h (count_size_as_multibyte):
5904 Rename from parse_str_to_multibyte; all uses changed.
5905 Check for integer overflow.
5906 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5907 since it's now a duplicate of the other. This is more of
5908 a character than a buffer op, so better that it's in character.c.
5909 * fns.c, print.c: Adjust to above changes.
5911 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5913 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5915 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5917 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5918 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5919 (x_clipboard_manager_save): Now static.
5920 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5922 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5923 (crypto_hash_function): Now static.
5924 Fix pointer signedness problems. Avoid unnecessary initializations.
5926 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5928 * termhooks.h (Vselection_alist): Make it terminal-local.
5930 * terminal.c (create_terminal): Initialize it.
5932 * xselect.c: Support for clipboard managers.
5933 (Vselection_alist): Move to termhooks.h as terminal-local var.
5934 (LOCAL_SELECTION): New macro.
5935 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5936 (symbol_to_x_atom): Remove gratuitous arg.
5937 (x_handle_selection_request, lisp_data_to_selection_data)
5938 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5939 (x_own_selection, x_get_local_selection, x_convert_selection):
5940 New arg, specifying work frame. Use terminal-local Vselection_alist.
5941 (some_frame_on_display): Delete unused function.
5942 (Fx_own_selection_internal, Fx_get_selection_internal)
5943 (Fx_disown_selection_internal, Fx_selection_owner_p)
5944 (Fx_selection_exists_p): New optional frame arg.
5945 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5946 (x_handle_selection_clear): Don't treat other terminals with the
5947 same keyboard specially. Use the terminal-local Vselection_alist.
5948 (x_clear_frame_selections): Use Frun_hook_with_args.
5950 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5952 * xterm.h: Add support for those atoms.
5954 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5956 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5957 (converted_selections, conversion_fail_tag): New global variables.
5958 (x_selection_request_lisp_error): Free the above.
5959 (x_get_local_selection): Remove unnecessary code.
5960 (x_reply_selection_request): Args changed; handle arbitrary array
5961 of converted selections stored in converted_selections.
5962 Separate the XChangeProperty and SelectionNotify steps.
5963 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5964 (x_convert_selection): New function.
5965 (x_handle_selection_event): Simplify.
5966 (x_get_foreign_selection): Don't ignore incoming requests while
5967 waiting for an answer; this will fail when we implement
5968 SAVE_TARGETS, and seems unnecessary anyway.
5969 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5970 (Vx_sent_selection_functions): Doc fix.
5972 2011-05-26 Leo Liu <sdl.web@gmail.com>
5974 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5976 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5978 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5980 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5981 for fringe update if it has periodic bitmap.
5982 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5983 and fringe_bitmap_periodic_p.
5985 * fringe.c (get_fringe_bitmap_data): New function.
5986 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5987 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5988 row. Mark glyph row for fringe update if periodicity changed.
5990 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5991 for fringe update unless it has periodic bitmap.
5993 2011-05-25 Kenichi Handa <handa@m17n.org>
5995 * xdisp.c (get_next_display_element): Set correct it->face_id for
5996 a static composition.
5998 2011-05-24 Leo Liu <sdl.web@gmail.com>
6001 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6003 * fns.c (crypto_hash_function, Fsha1): New function.
6004 (Fmd5): Use crypto_hash_function.
6005 (syms_of_fns): Add Ssha1.
6007 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6009 * gnutls.c: Remove unused macros.
6010 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6011 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6012 Remove macros that are defined and never used.
6013 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6015 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6017 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6018 (Fx_get_selection_internal): Minor cleanup.
6019 (Fx_own_selection_internal): Rename arguments for consistency with
6022 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6024 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6026 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6028 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6030 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6032 * dispnew.c (scrolling_window): Don't exclude the case that the
6033 last enabled row in the desired matrix touches the bottom boundary.
6035 2011-05-21 Glenn Morris <rgm@gnu.org>
6037 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6038 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6039 and add some more files.
6041 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6043 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6044 report_file_error introduced by the change from 2011-05-07.
6046 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6048 * systime.h (Time): Define only if emacs is defined.
6049 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6050 where the include path doesn't have X11/X.h by default. See
6051 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6053 2011-05-20 Kenichi Handa <handa@m17n.org>
6055 * composite.c (find_automatic_composition): Fix previous change.
6057 2011-05-20 Glenn Morris <rgm@gnu.org>
6059 * lisp.mk: New file, split from Makefile.in.
6060 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6061 (shortlisp): Remove.
6062 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6064 2011-05-19 Glenn Morris <rgm@gnu.org>
6066 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6067 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6068 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6069 (lisp): Set the order to that of loadup.el.
6070 (shortlisp): Make it a copy of $lisp.
6071 (SOME_MACHINE_LISP): Remove.
6072 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6073 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6075 2011-05-18 Kenichi Handa <handa@m17n.org>
6077 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6078 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6079 (find_automatic_composition): Mostly rewrite for efficiency.
6081 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6083 * makefile.w32-in: Update dependencies.
6085 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6087 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6088 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6090 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6092 Fix some integer overflow issues, such as string length overflow.
6094 * insdel.c (count_size_as_multibyte): Check for string overflow.
6096 * character.c (lisp_string_width): Check for string overflow.
6097 Use EMACS_INT, not int, for string indexes and lengths; in
6098 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6099 the resulting string length overflows an EMACS_INT; instead,
6100 report a string overflow if no precision given. When checking for
6101 precision exhaustion, use a check that cannot possibly have
6102 integer overflow. (Bug#8675)
6103 * character.h (lisp_string_width): Adjust to new signature.
6105 * alloc.c (string_overflow): New function.
6106 (Fmake_string): Use it. This doesn't change behavior, but saves
6107 a few bytes and will simplify future changes.
6108 * character.c (string_escape_byte8): Likewise.
6109 * lisp.h (string_overflow): New decl.
6111 Fixups, following up to the user-interface timestamp change.
6112 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6113 for UI timestamps, instead of unsigned long.
6114 * msdos.c (mouse_get_pos): Likewise.
6115 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6116 * w32gui.h (Time): Define by including "systime.h" rather than by
6117 declaring it ourselves. (Bug#8664)
6119 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6120 * image.c (clear_image_cache): Likewise.
6122 * term.c (term_mouse_position): Don't assume time_t wraparound.
6124 Be more systematic about user-interface timestamps.
6125 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6126 and sometimes 'EMACS_UINT', to represent these timestamps.
6127 This change causes it to use 'Time' uniformly, as that's what X uses.
6128 This makes the code easier to follow, and makes it easier to catch
6129 integer overflow bugs such as Bug#8664.
6130 * frame.c (Fmouse_position, Fmouse_pixel_position):
6131 Use Time, not unsigned long, for user-interface timestamps.
6132 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6133 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6134 * keyboard.h (last_event_timestamp): Likewise.
6135 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6136 * menu.h (xmenu_show): Likewise.
6137 * term.c (term_mouse_position): Likewise.
6138 * termhooks.h (struct input_event.timestamp): Likewise.
6139 (struct terminal.mouse_position_hook): Likewise.
6140 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6141 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6142 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6143 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6145 * menu.h, termhooks.h: Include "systime.h", for Time.
6147 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6148 Don't assume that the difference between two unsigned long values
6149 can fit into an integer. At this point, we know button_down_time
6150 <= event->timestamp, so the difference must be nonnegative, so
6151 there's no need to cast the result if double-click-time is
6152 nonnegative, as it should be; check that it's nonnegative, just in
6153 case. This bug is triggered when events are more than 2**31 ms
6154 apart (about 25 days). (Bug#8664)
6156 * xselect.c (last_event_timestamp): Remove duplicate decl.
6157 (x_own_selection): Remove needless cast to unsigned long.
6159 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6160 that always fit in int. Use a sentinel instead of a counter, to
6161 avoid a temp and to allay GCC's concerns about possible int overflow.
6162 * frame.h (struct frame): Use int for menu_bar_items_used
6163 instead of EMACS_INT, since it always fits in int.
6165 * menu.c (grow_menu_items): Check for int overflow.
6167 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6169 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6170 Before, the code was not consistent. These values cannot exceed
6171 2**31 - 1 so there's no need to make them unsigned.
6172 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6173 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6174 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6176 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6178 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6179 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6180 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6181 presumably because the widths might not match.
6183 * window.c (size_window): Avoid needless test at loop start.
6185 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6187 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6189 2011-05-12 Drew Adams <drew.adams@oracle.com>
6191 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6193 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6195 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6196 `width' to `bar_area_x' and `bar_area_width', respectively.
6197 (x_scroll_run): Take account of fringe background extension.
6199 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6200 Rename local vars `left' and `width' to `bar_area_x' and
6201 `bar_area_width', respectively.
6202 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6203 background extension.
6205 2011-05-10 Jim Meyering <meyering@redhat.com>
6207 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6209 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6211 * image.c (Finit_image_library): Return t for built-in image types,
6212 like pbm and xbm. (Bug#8640)
6214 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6216 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6218 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6220 * w32console.c (Fset_screen_color): Doc fix.
6221 (Fget_screen_color): New function.
6222 (syms_of_ntterm): Defsubr it.
6224 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6225 unlink the temporary file if Fcall_process didn't create it in the
6227 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6228 child process will be redirected to a file specified with `:file'.
6229 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6230 cue to call_process_cleanup not to close that handle.
6232 2011-05-07 Ben Key <bkey76@gmail.com>
6234 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6235 one of two shell specific rules, either bootstrap-temacs-CMD or
6236 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6237 to the previous implementation of the bootstrap-temacs rule.
6238 The bootstrap-temacs-CMD rule is similar to the previous
6239 implementation of the bootstrap-temacs rule except that it
6240 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6243 These changes, along with some changes to nt/configure.bat,
6244 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6245 earlier fix to add support for --cflags and --ldflags options
6246 that include quotes so that it works whether make uses cmd or
6249 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6251 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6252 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6254 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6255 a string. Handle both cases.
6256 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6257 (Fdbus_register_method): Use Qinvalid_function.
6259 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6261 * makefile.w32-in: Update dependencies.
6262 (LISP_H): Add inttypes.h and stdin.h.
6263 (PROCESS_H): Add unistd.h.
6265 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6267 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6268 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6270 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6272 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6274 * term.c (vfatal): Remove stray call to va_end.
6275 It's not needed and the C Standard doesn't allow it here anyway.
6277 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6278 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6280 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6283 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6285 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6287 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6289 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6291 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6293 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6294 * charset.c (Fdefine_charset_internal): Don't initialize
6295 charset.code_space[15]. The value was garbage, on hosts with
6296 32-bit int (Bug#8600).
6298 * lread.c (read_integer): Be more consistent with string-to-number.
6299 Use string_to_number to do the actual conversion; this avoids
6300 rounding errors and fixes some other screwups. Without this fix,
6301 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6302 (digit_to_number): Move earlier, for benefit of read_integer.
6303 Return -1 if the digit is out of range for the base, -2 if it is
6304 not a digit in any supported base. (Bug#8602)
6306 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6308 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6309 to match comment at start of function. This also removes a
6310 GCC warning about overflow in a 32+64-bit port.
6312 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6314 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6315 Reported by Stefan Monnier in
6316 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6317 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6318 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6320 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6321 (EMACS_UINTPTR): Likewise, with uintptr_t.
6323 * lisp.h: Prefer 64-bit EMACS_INT if available.
6324 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6325 on 32-bit hosts that have 64-bit int, so that they can access
6327 However, temporarily disable this change unless the temporary
6328 symbol WIDE_EMACS_INT is defined.
6330 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6332 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6333 This removes an assumption that EMACS_INT and long are the same
6334 width as pointers. The assumption is true for Emacs porting targets
6335 now, but we want to make other targets possible.
6336 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6337 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6338 In the rest of the code, change types of integers that hold casted
6339 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6340 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6341 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6342 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6343 No need to cast type when ORing.
6344 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6345 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6346 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6347 assume EMACS_INT is the same width as char *.
6348 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6349 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6350 Remove no-longer-needed casts.
6351 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6352 (xg_tool_bar_help_callback, xg_make_tool_item):
6353 Use EMACS_INTPTR to hold an integer
6354 that will be cast to void *; this can avoid a GCC warning
6355 if EMACS_INT is not the same width as void *.
6356 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6357 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6358 (current_message_1, set_message_1):
6359 Use a local to convert to proper width without a cast.
6360 * xmenu.c (dialog_selection_callback): Likewise.
6362 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6363 Also, don't assume VALBITS / RAND_BITS is less than 5,
6364 and don't rely on undefined behavior when shifting a 1 left into
6366 * lisp.h (get_random): Change signature to match.
6368 * lread.c (hash_string): Use size_t, not int, for hash computation.
6369 Normally we prefer signed values; but hashing is special, because
6370 it's better to use unsigned division on hash table sizes so that
6371 the remainder is nonnegative. Also, size_t is the natural width
6372 for hashing into memory. The previous code used 'int', which doesn't
6373 retain enough info to hash well into very large tables.
6374 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6376 * dbusbind.c: Don't possibly lose pointer info when converting.
6377 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6378 Use XPNTR rather than XHASH, so that the high-order bits of
6379 the pointer aren't lost when converting through void *.
6381 * eval.c (Fautoload): Don't double-shift a pointer.
6383 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6385 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6387 * gnutls.c (DEF_GNUTLS_FN):
6388 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6390 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6392 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6395 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6397 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6398 New version that can reserve upto 2GB of heap space.
6400 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6402 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6404 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6406 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6407 `gnutls_certificate_set_x509_key_file'.
6409 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6411 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6412 Update dependencies.
6414 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6416 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6417 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6418 Remove unused parameter `fildes'.
6419 * process.c (read_process_output, send_process): Don't pass it.
6421 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6423 Fix previous change: the library cache is defined in w32.c.
6424 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6425 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6427 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6429 Implement dynamic loading of GnuTLS on Windows.
6431 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6432 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6433 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6436 * gnutls.c (Qgnutls_dll): Define.
6437 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6438 (gnutls_*): Declare function pointers.
6439 (init_gnutls_functions): New function to initialize function pointers.
6440 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6441 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6442 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6443 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6444 (emacs_gnutls_write, emacs_gnutls_read)
6445 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6446 (Fgnutls_available_p): New function.
6447 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6448 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6449 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6451 * image.c: Include w32.h.
6452 (Vimage_type_cache): Delete.
6453 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6454 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6455 (w32_delayed_load): Move to w32.c.
6457 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6459 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6460 (w32_delayed_load): Move from image.c. When loading a library, record
6461 its filename in the :loaded-from property of the library id.
6462 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6463 Initialize and staticpro them.
6464 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6466 * process.c: Include lisp.h before w32.h, not after.
6467 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6468 instead of gnutls_record_check_pending.
6470 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6472 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6474 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6475 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6478 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6480 * xterm.c (x_set_frame_alpha): Do not set property on anything
6481 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6483 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6485 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6487 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6489 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6490 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6491 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6492 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6493 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6494 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6495 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6496 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6497 (Qgnutls_bootprop_callbacks_verify): Make static.
6499 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6501 * callproc.c: Indentation fixup.
6503 * sysdep.c (wait_for_termination_1): Make static.
6504 (wait_for_termination, interruptible_wait_for_termination):
6505 Move after wait_for_termination_1.
6507 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6509 * sysdep.c (interruptible_wait_for_termination): New function
6510 which is like wait_for_termination, but allows keyboard
6513 * callproc.c (Fcall_process): Add (:file "file") as an option for
6515 (Fcall_process_region): Ditto.
6517 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6519 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6520 rather than `XVECTOR (FOO)->size'.
6522 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6523 inttypes.h, as a gnulib replacement is used if it not available in
6526 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6528 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6529 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6530 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6532 * coding.c (coding_alloc_by_realloc): Error out if destination
6533 will grow beyond MOST_POSITIVE_FIXNUM.
6534 (decode_coding_emacs_mule): Abort if there isn't enough place in
6535 charbuf for the composition carryover bytes. Reserve an extra
6536 space for up to 2 characters produced in a loop.
6537 (decode_coding_iso_2022): Abort if there isn't enough place in
6538 charbuf for the composition carryover bytes.
6540 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6542 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6543 aborting when %lld or %lll format is passed.
6544 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6545 %llo or %llx format is passed. (Bug#8545)
6547 * window.c (window_scroll_line_based): Use a marker instead of
6548 simple variables to record original value of point. (Bug#7952)
6550 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6551 produced by %s or %c overflows available buffer space. (Bug#8545)
6553 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6555 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6556 (SIZE_MAX): Move defn after all includes, as they might #define it.
6558 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6560 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6562 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6564 * keyboard.c (Qdelayed_warnings_hook): Define.
6565 (command_loop_1): Run `delayed-warnings-hook'
6566 if Vdelayed_warnings_list is non-nil.
6567 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6568 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6570 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6572 * doprnt.c (doprnt): Don't return value smaller than the buffer
6573 size if the message was truncated. (Bug#8545).
6575 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6577 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6578 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6580 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6582 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6584 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6586 * makefile.w32-in: Update dependencies.
6588 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6590 Improve `doprnt' and its usage. (Bug#8545)
6591 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6592 `format_end'. Remove support for %l as a conversion specifier.
6593 Don't use xrealloc. Improve diagnostics when the %l size modifier
6594 is used. Update the commentary.
6596 * eval.c (verror): Simplify calculation of size_t.
6598 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6601 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6603 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6606 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6608 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6609 This makes this file independent of the recent pseudovector change.
6611 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6613 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6615 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6616 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6617 Remove unused local.
6618 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6620 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6621 GCC 4.6.0 optimizes based on type-based alias analysis.
6622 For example, if b is of type struct buffer * and v of type struct
6623 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6624 != &v->size, and therefore "v->size = 1; b->size = 2; return
6625 v->size;" must therefore return 1. This assumption is incorrect
6626 for Emacs, since it type-puns struct Lisp_Vector * with many other
6627 types. To fix this problem, this patch adds a new type struct
6628 vectorlike_header that documents the constraints on layout of vectors
6629 and pseudovectors, and helps optimizing compilers not get fooled
6630 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6631 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6632 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6634 (XSETPVECTYPE): Rewrite in terms of new macro.
6635 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6636 This is a bit clearer, and further avoids the possibility of
6637 undesirable aliasing.
6638 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6639 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6640 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6641 since Lisp_Subr is a special case (no "next" field).
6642 (ASIZE): Now uses header.size rather than size.
6643 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6644 to avoid the hassle of writing XVECTOR (foo)->header.size.
6645 (struct vectorlike_header): New type.
6646 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6647 object, to help avoid aliasing.
6648 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6649 (SUBRP): Likewise, since Lisp_Subr is a special case.
6650 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6651 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6652 (struct Lisp_Hash_Table): Combine first two members into a single
6653 struct vectorlike_header member. All uses of "size" and "next" members
6654 changed to be "header.size" and "header.next".
6655 * buffer.h (struct buffer): Likewise.
6656 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6657 * frame.h (struct frame): Likewise.
6658 * process.h (struct Lisp_Process): Likewise.
6659 * termhooks.h (struct terminal): Likewise.
6660 * window.c (struct save_window_data, struct saved_window): Likewise.
6661 * window.h (struct window): Likewise.
6662 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6663 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6664 * buffer.c (init_buffer_once): Likewise.
6665 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6667 * process.c (Fformat_network_address): Use local var for size,
6670 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6672 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6673 * data.c (atof): Remove decl; no longer used or needed.
6674 (digit_to_number): Move to lread.c.
6675 (Fstring_to_number): Use new string_to_number function, to be
6676 consistent with how the Lisp reader treats infinities and NaNs.
6677 Do not assume that floating-point numbers represent EMACS_INT
6678 without losing information; this is not true on most 64-bit hosts.
6679 Avoid double-rounding errors, by insisting on integers when
6680 parsing non-base-10 numbers, as the documentation specifies.
6681 * lisp.h (string_to_number): New decl, replacing ...
6682 (isfloat_string): Remove.
6683 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6684 (read1): Do not accept +. and -. as integers; this
6685 appears to have been a coding error. Similarly, do not accept
6686 strings like +-1e0 as floating point numbers. Do not report
6687 overflow for integer overflows unless the base is not 10 which
6688 means we have no simple and reliable way to continue.
6689 Break out the floating-point parsing into a new
6690 function string_to_number, so that Fstring_to_number parses
6691 floating point numbers consistently with the Lisp reader.
6692 (digit_to_number): Move here from data.c. Make it static inline.
6693 (E_CHAR, EXP_INT): Remove, replacing with ...
6694 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6695 (string_to_number): New function, replacing isfloat_string.
6696 This function checks for valid syntax and produces the resulting
6697 Lisp float number too. Rework it so that string-to-number
6698 no longer mishandles examples like "1.0e+". Use strtoumax,
6699 so that overflow for non-base-10 numbers is reported only when
6700 there's no portable and simple way to convert to floating point.
6702 * textprop.c (set_text_properties_1): Rewrite for clarity,
6703 and to avoid GCC warning about integer overflow.
6705 * intervals.h (struct interval): Use EMACS_INT for members
6706 where EMACS_UINT might cause problems. See
6707 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6708 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6709 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6711 (offset_intervals): Tell GCC not to worry about length overflow
6712 when negating a negative length.
6714 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6715 (overrun_check_free): Likewise.
6717 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6718 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6721 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6722 (gnutls_make_error): Rename local to avoid shadowing.
6723 (gnutls_emacs_global_deinit): ifdef out; not used.
6724 (Fgnutls_boot): Use const for pointer to readonly storage.
6725 Comment out unused local. Fix pointer signedness problems.
6727 * lread.c (openp): Don't stuff size_t into an 'int'.
6728 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6729 about possible signed overflow.
6731 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6732 (GDK_KEY_g): Don't define if already defined.
6733 (xg_prepare_tooltip): Avoid pointer signedness problem.
6734 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6736 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6737 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6739 * xfns.c (Fx_window_property): Simplify a bit,
6740 to make a bit faster and to avoid GCC 4.6.0 warning.
6741 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6743 * fns.c (internal_equal): Don't assume size_t fits in int.
6745 * alloc.c (compact_small_strings): Tighten assertion a little.
6747 Replace pEd with more-general pI, and fix some printf arg casts.
6748 * lisp.h (pI): New macro, generalizing old pEd macro to other
6749 conversion specifiers. For example, use "...%"pI"d..." rather
6750 than "...%"pEd"...".
6751 (pEd): Remove. All uses replaced with similar uses of pI.
6752 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6753 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6754 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6755 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6756 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6757 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6758 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6760 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6761 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6762 * print.c (safe_debug_print, print_object): Likewise.
6763 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6765 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6766 avoiding the 0 flag, which is not portable.
6767 * process.c (Fmake_network_process): Use pI to avoid cast.
6768 * region-cache.c (pp_cache): Likewise.
6769 * xdisp.c (decode_mode_spec): Likewise.
6770 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6771 behavior on 64-bit hosts with printf arg.
6772 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6773 (x_stop_queuing_selection_requests): Likewise.
6774 (x_get_window_property): Don't truncate byte count to an 'int'
6777 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6778 here, since it parses constructs like leading '-' and spaces,
6779 which are not wanted; and it overflows with large numbers.
6780 Instead, simply match F[0-9]+, which is what is wanted anyway.
6782 * alloc.c: Remove unportable assumptions about struct layout.
6783 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6784 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6785 (allocate_vectorlike, make_pure_vector): Use the new macros,
6786 plus offsetof, to remove unportable assumptions about struct layout.
6787 These assumptions hold on all porting targets that I know of, but
6788 they are not guaranteed, they're easy to remove, and removing them
6789 makes further changes easier.
6791 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6792 This doesn't fix a bug but makes the code clearer.
6793 (string_overrun_cookie): Now const. Use initializers that
6794 don't formally overflow signed char, to avoid warnings.
6795 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6796 can cause Emacs to crash when string overrun checking is enabled.
6797 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6798 multiple of sizeof (EMACS_INT); it need not be, if
6799 alignof(EMACS_INT) < sizeof (EMACS_INT).
6800 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6802 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6804 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6806 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6808 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6809 supposed to be handshaking. (Bug#8556)
6810 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6812 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6814 * lisp.h (Qdebug): List symbol.
6815 * eval.c (Qdebug): Restore global linkage.
6816 * keyboard.c (debug-on-event): New variable.
6817 (handle_user_signal): Break into debugger when debug-on-event
6818 matches the current signal symbol.
6820 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6822 * alloc.c (check_sblock, check_string_bytes)
6823 (check_string_free_list): Convert to standard C.
6825 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6827 * w32.c (emacs_gnutls_push): Fix typo.
6829 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6831 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6832 "cast to pointer from integer of different size".
6834 Improve doprnt and its use in verror. (Bug#8545)
6835 * doprnt.c (doprnt): Document the set of format control sequences
6836 supported by the function. Use SAFE_ALLOCA instead of always
6839 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6840 is one byte too soon. Don't use xrealloc; instead xfree and
6843 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6845 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6848 * gnutls.c: Renamed global_initialized to
6849 gnutls_global_initialized. Added internals for the
6850 :verify-hostname-error, :verify-error, and :verify-flags
6851 parameters of `gnutls-boot' and documented those parameters in the
6852 docstring. Start callback support.
6853 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6854 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6855 on error. Return error code.
6856 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6857 (emacs_gnutls_read): Likewise.
6858 (Fgnutls_boot): Return handshake error code.
6859 (emacs_gnutls_handle_error): New function.
6860 (wsaerror_to_errno): Likewise.
6862 * w32.h (emacs_gnutls_pull): Add prototype.
6863 (emacs_gnutls_push): Likewise.
6865 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6866 (emacs_gnutls_push): Likewise.
6868 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6870 * process.c (wait_reading_process_output): Check if GnuTLS
6871 buffered some data internally if no FDs are set for TLS
6874 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6875 (LIBS): Link to USER_LIBS.
6876 ($(BLD)/gnutls.$(0)): New target.
6878 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6880 * xdisp.c (handle_single_display_spec): Rename the
6881 display_replaced_before_p argument into display_replaced_p, to
6882 make it consistent with the commentary. Fix typos in the
6885 * textprop.c (syms_of_textprop): Remove dead code.
6886 (copy_text_properties): Delete obsolete commentary about an
6887 interface that was deleted long ago. Fix typos in the description
6890 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6891 to changes in oldXMenu/XMenu.h from 2011-04-16.
6892 <menu_help_message, prev_menu_help_message>: Constify.
6893 (IT_menu_make_room): menu->help_text is now `const char **';
6896 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6897 to changes in oldXMenu/XMenu.h from 2011-04-16.
6898 (struct XMenu): Declare `help_text' `const char **'.
6900 * xfaces.c <Qunspecified>: Make extern again.
6902 * syntax.c: Include sys/types.h before including regex.h, as
6905 * doc.c (get_doc_string): Improve the format passed to `error'.
6907 * doprnt.c (doprnt): Improve commentary.
6909 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6911 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6914 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6915 changes in globals.h immediately force recompilation.
6916 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6917 $(CURDIR)/s/ms-w32.h.
6918 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6920 * character.c (Fchar_direction): Function deleted.
6921 (syms_of_character): Don't defsubr it.
6922 <char-direction-table>: Deleted.
6924 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6926 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6927 * doprnt.c: Include limits.h.
6928 (SIZE_MAX): New macro.
6929 (doprnt): Return a size_t value. 2nd arg is now size_t.
6930 Many local variables are now size_t instead of int or unsigned.
6931 Improve overflow protection. Support `l' modifier for integer
6932 conversions. Support %l conversion. Don't assume an EMACS_INT
6933 argument for integer conversions and for %c.
6935 * lisp.h (doprnt): Restore prototype.
6937 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6940 * Makefile.in (base_obj): Add back doprnt.o.
6942 * deps.mk (doprnt.o): Add back prerequisites.
6943 (callint.o): Depend on character.h.
6945 * eval.c (internal_lisp_condition_case): Include the handler
6946 representation in the error message.
6947 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6948 when breaking from the loop.
6950 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6952 * callint.c (Fcall_interactively): When displaying error message
6953 about invalid control letter, pass the character's codepoint, not
6954 a pointer to its multibyte form. Improve display of the character
6955 in octal and display also its hex code.
6957 * character.c (char_string): Use %x to display the (unsigned)
6958 codepoint of an invalid character, to avoid displaying a bogus
6961 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6962 `error', not SYMBOL_NAME itself.
6964 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6965 character arguments to `error'.
6967 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6968 to `error' in error message about FINAL_CHAR argument. Make sure
6969 FINAL_CHAR is a character, and use %c when it is passed as
6970 argument to `error'.
6972 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6974 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6976 * w32.c: Include <time.h>.
6977 (sys_localtime): New function.
6979 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6981 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6983 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6985 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6987 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6990 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6992 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6993 gl_state.e_property when gl_state.object is Qt.
6995 * insdel.c (make_gap_larger): Remove limitation of buffer size
6998 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7000 * xdisp.c (lookup_glyphless_char_display)
7001 (produce_glyphless_glyph): Handle cons cell entry in
7002 glyphless-char-display.
7003 (Vglyphless_char_display): Document it.
7005 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7006 glyphless-char-display.
7008 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7010 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7012 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7014 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7015 definition for no-X builds.
7017 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7019 Static checks with GCC 4.6.0 and non-default toolkits.
7021 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7023 * process.c (keyboard_bit_set): Define only if SIGIO.
7024 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7025 (send_process): Repair possible setjmp clobbering.
7027 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7029 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7031 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7033 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7034 Define only if needed.
7036 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7037 by pacifying GCC about it. Maybe it's time to retire it?
7038 * xfaces.c (USG, __TIMEVAL__): Likewise.
7040 * dispextern.h (struct redisplay_interface): Rename param
7042 * termhooks.h (struct terminal): Likewise.
7043 * xterm.c (xembed_send_message): Likewise.
7045 * insdel.c (make_gap_smaller): Define only if
7046 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7048 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7051 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7052 so that we aren't warned about unused symbols.
7054 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7056 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7058 * xfns.c (x_real_positions): Mark locals as initialized.
7060 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7062 * xterm.c: Fix problems found by static analysis with other toolkits.
7063 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7064 (x_dispatch_event): Declare static if USE_GTK, and
7065 define if USE_GTK || USE_X_TOOLKIT.
7066 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7067 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7068 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7069 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7071 * xmenu.c (menu_help_callback): Pointer type fixes.
7072 Use const pointers when pointing at readonly data. Avoid pointer
7074 (FALSE): Remove unused macro.
7075 (update_frame_menubar): Remove unused decl.
7077 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7079 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7080 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7081 (single_menu_item): Rename local to avoid shadowing.
7083 * keyboard.c (make_lispy_event): Remove unused local var.
7085 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7086 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7088 * bitmaps: Change bitmaps from unsigned char back to the X11
7089 compatible char. Avoid the old compiler warnings about
7090 out-of-range initializers by using, for example, '\xab' rather
7093 * xgselect.c (xgselect_initialize): Check vs interface
7094 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7096 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7098 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7099 to read-only memory.
7101 * fns.c (vector): Remove; this old hack is no longer needed.
7103 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7105 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7107 * xrdb.c (x_load_resources): Omit unused local.
7109 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7110 (x_window): Rename locals to avoid shadowing.
7111 (USG): Use the kludged USG macro, to pacify gcc.
7113 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7114 (x_term_init): Remove local to avoid shadowing.
7116 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7118 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7119 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7121 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7123 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7125 Fix regex.c, syntax.c and friends for buffers > 2GB.
7126 * syntax.h (struct gl_state_s): Declare character position members
7129 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7131 * textprop.c (verify_interval_modification, interval_of):
7132 Declare arguments EMACS_INT.
7134 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7137 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7139 * indent.c (Fvertical_motion): Local variable it_start is now
7142 * regex.c (re_match, re_match_2, re_match_2_internal)
7143 (bcmp_translate, regcomp, regexec, print_double_string)
7144 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7145 (re_compile_pattern, re_exec): Declare arguments and local
7146 variables `size_t' and `ssize_t' and return values `regoff_t', as
7148 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7149 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7150 <compile_stack_type>: `size' and `avail' are now `size_t'.
7152 * regex.h <regoff_t>: Use ssize_t, not int.
7153 (re_search, re_search_2, re_match, re_match_2): Arguments that
7154 specify buffer/string position and length are now ssize_t and
7155 size_t. Return type is regoff_t.
7157 2011-04-16 Ben Key <bkey76@gmail.com>
7159 * nsfont.m: Fixed bugs in ns_get_family and
7160 ns_descriptor_to_entity that were caused by using free to
7161 deallocate memory blocks that were allocated by xmalloc (via
7162 xstrdup). This caused Emacs to crash when compiled with
7163 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7164 --enable-checking=xmallocoverrun). xfree is now used to
7165 deallocate these memory blocks.
7167 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7169 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7171 emacs_write: Accept and return EMACS_INT for sizes.
7172 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7174 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7175 Accept and return EMACS_INT.
7176 (emacs_gnutls_write): Return the number of bytes written on
7178 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7179 (emacs_read, emacs_write): Remove check for negative size, as the
7180 Emacs source code has been audited now.
7181 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7182 (emacs_read, emacs_write): Use it.
7183 * process.c (send_process): Adjust to the new signatures of
7184 emacs_write and emacs_gnutls_write. Do not attempt to store
7185 a byte offset into an 'int'; it might overflow.
7186 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7188 * sound.c: Don't assume sizes fit in 'int'.
7189 (struct sound_device.period_size, alsa_period_size):
7190 Return EMACS_INT, not int.
7191 (struct sound_device.write, vox_write, alsa_write):
7192 Accept EMACS_INT, not int.
7193 (wav_play, au_play): Use EMACS_INT to store sizes and to
7194 record read return values.
7196 2011-04-15 Ben Key <bkey76@gmail.com>
7198 * keyboard.c (Qundefined): Don't declare static since it is used
7200 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7201 static since they are used in nsfont.m.
7203 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7205 * process.c (Qprocessp): Don't declare static.
7206 * lisp.h (Qprocessp): Declare again.
7208 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7210 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7212 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7214 Improve C-level modularity by making more things 'static'.
7216 Don't publish debugger-only interfaces to other modules.
7217 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7218 (verify_bytepos, count_markers): Move decls to the only modules
7220 * region-cache.h (pp_cache): Likewise.
7221 * window.h (check_all_windows): Likewise.
7222 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7224 * sysdep.c (croak): Now static, if
7225 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7226 * syssignal.h (croak): Declare only if not static.
7228 * alloc.c (refill_memory_reserve): Now static if
7229 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7230 * lisp.h (refill_memory_reserve): Declare only if not static.
7232 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7233 Define only if USE_LUCID.
7235 * xrdb.c (x_customization_string, x_rm_string): Now static.
7237 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7238 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7240 * xdisp.c (draw_row_with_mouse_face): Now static.
7241 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7243 * window.h (check_all_windows): Mark externally visible.
7245 * window.c (window_deletion_count): Now static.
7247 * undo.c: Make symbols static if they're not exported.
7248 (last_undo_buffer, last_boundary_position, pending_boundary):
7251 * textprop.c (interval_insert_behind_hooks): Now static.
7252 (interval_insert_in_front_hooks): Likewise.
7254 * term.c: Make symbols static if they're not exported.
7255 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7256 (max_frame_lines, tty_set_terminal_modes):
7257 (tty_reset_terminal_modes, tty_turn_off_highlight):
7258 (get_tty_terminal): Now static.
7259 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7260 * termhooks.h (term_mouse_moveto): Do not declare if
7262 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7263 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7265 * sysdep.c: Make symbols static if they're not exported.
7266 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7268 (sigprocmask_set, full_mask): Remove; unused.
7269 (wait_debugging): Mark as visible.
7270 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7271 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7273 * syntax.c (syntax_temp): Define only if !__GNUC__.
7275 * sound.c (current_sound_device, current_sound): Now static.
7277 * search.c (searchbufs, searchbuf_head): Now static.
7279 * scroll.c (scroll_cost): Remove; unused.
7280 * dispextern.h (scroll_cost): Remove decl.
7282 * region-cache.h (pp_cache): Mark as externally visible.
7284 * process.c: Make symbols static if they're not exported.
7285 (process_tick, update_tick, create_process, chan_process):
7286 (Vprocess_alist, proc_buffered_char, datagram_access):
7287 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7288 (deactivate_process): Mark defn as static, as well as decl.
7289 * lisp.h (create_process): Remove decl.
7290 * process.h (chan_process, Vprocess_alist): Remove decls.
7292 * print.c: Make symbols static if they're not exported.
7293 (print_depth, new_backquote_output, being_printed, print_buffer):
7294 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7295 (print_interval, print_number_index, initial_stderr_stream):
7297 * lisp.h (Fprinc): Remove decl.
7298 (debug_output_compilation_hack): Mark as externally visible.
7300 * sysdep.c (croak): Move decl from here to syssignal.h.
7301 * syssignal.h (croak): Put it here, so the API can be checked when
7302 'croak' is called from dissociate_if_controlling_tty.
7304 * minibuf.c: Make symbols static if they're not exported.
7305 (minibuf_save_list, choose_minibuf_frame): Now static.
7306 * lisp.h (choose_minibuf_frame): Remove decl.
7308 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7310 * lread.c: Make symbols static if they're not exported.
7311 (read_objects, initial_obarray, oblookup_last_bucket_number):
7313 (make_symbol): Remove; unused.
7314 * lisp.h (initial_obarray, make_symbol): Remove decls.
7316 * keyboard.c: Make symbols static if they're not exported.
7317 (single_kboard, recent_keys_index, total_keys, recent_keys):
7318 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7319 (this_single_command_key_start, echoing, last_auto_save):
7320 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7321 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7322 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7323 (Vlispy_mouse_stem, double_click_count):
7325 (force_auto_save_soon): Define only if SIGDANGER.
7326 (ignore_mouse_drag_p): Now static if
7327 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7328 (print_help): Remove; unused.
7329 (stop_character, last_timer_event): Mark as externally visible.
7330 * keyboard.h (ignore_mouse_drag_p): Declare only if
7331 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7332 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7333 * lisp.h (echoing): Remove decl.
7334 (force_auto_save_soon): Declare only if SIGDANGER.
7335 * xdisp.c (redisplay_window): Simplify code, to make it more
7336 obvious that ignore_mouse_drag_p is not accessed if !defined
7337 USE_GTK && !defined HAVE_NS.
7339 * intervals.c: Make symbols static if they're not exported.
7340 (merge_properties_sticky, merge_interval_right, delete_interval):
7342 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7344 * insdel.c: Make symbols static if they're not exported.
7345 However, leave prepare_to_modify_buffer alone. It's never
7346 called from outside this function, but that appears to be a bug.
7347 (combine_after_change_list, combine_after_change_buffer):
7348 (adjust_after_replace, signal_before_change): Now static.
7349 (adjust_after_replace_noundo): Remove; unused.
7350 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7351 (signal_before_change): Remove decls.
7353 * indent.c (val_compute_motion, val_vmotion): Now static.
7355 * image.c: Make symbols static if they're not exported.
7356 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7358 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7359 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7361 * fringe.c (standard_bitmaps): Now static.
7362 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7364 * frame.c: Make symbols static if they're not exported.
7365 (x_report_frame_params, make_terminal_frame): Now static.
7366 (get_frame_param): Now static, unless HAVE_NS.
7367 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7368 (x_get_resource_string): Remove; not used.
7369 * frame.h (make_terminal_frame, x_report_frame_params):
7370 (x_get_resource_string); Remove decls.
7371 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7372 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7374 * font.c, fontset.c: Make symbols static if they're not exported.
7375 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7376 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7377 * font.c (font_close_object): Now static.
7378 * font.h (font_close_object): Remove.
7379 * fontset.c (FONTSET_OBJLIST): Remove.
7380 (free_realized_fontset) #if-0 the body, which does nothing.
7381 (face_suitable_for_char_p): #if-0, as it's never called.
7382 * fontset.h (face_suitable_for_char_p): Remove decl.
7383 * xfaces.c (face_at_string_position):
7384 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7385 since 0 is always ASCII.
7387 * fns.c (weak_hash_tables): Now static.
7389 * fileio.c: Make symbols static if they're not exported.
7390 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7391 (Vwrite_region_annotation_buffers): Now static.
7393 * eval.c: Make symbols static if they're not exported.
7394 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7395 * lisp.h (backtrace_list): Remove decl.
7397 * emacs.c: Make symbols static if they're not exported.
7398 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7399 (fatal_error_code, fatal_error_signal_hook, standard_args):
7401 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7402 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7403 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7404 * lisp.h (fatal_error_signal_hook): Remove decl.
7405 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7407 * editfns.c: Move a (normally-unused) function to its only use.
7408 * editfns.c, lisp.h (get_operating_system_release): Remove.
7409 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7410 worth the hassle of breaking this out.
7412 * xterm.c: Make symbols static if they're not exported.
7413 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7414 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7415 (x_destroy_window, x_delete_display):
7417 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7418 (x_mouse_leave): Remove; unused.
7419 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7420 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7421 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7423 (x_mouse_leave): Declare only if WINDOWSNT.
7424 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7425 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7428 * ftxfont.c: Make symbols static if they're not exported.
7429 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7431 * font.h (ftxfont_driver): Likewise.
7433 * xfns.c: Make symbols static if they're not exported.
7434 (x_last_font_name, x_display_info_for_name):
7435 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7436 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7437 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7438 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7439 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7440 (last_show_tip_args): Now static.
7441 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7442 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7443 (x_screen_planes): Remove; unused.
7444 * dispextern.h (x_screen_planes): Remove decl.
7446 * dispnew.c: Make symbols static if they're not exported.
7447 * dispextern.h (redraw_garbaged_frames, scrolling):
7448 (increment_row_positions): Remove.
7449 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7450 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7452 (redraw_garbaged_frames): Remove; unused.
7454 * xfaces.c: Make symbols static if they're not exported.
7455 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7457 * xterm.h (defined_color): Remove decls.
7458 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7459 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7460 (menu_face_changed_default, defined_color, free_realized_face):
7461 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7462 (ascii_face_of_lisp_face): Remove; unused.
7464 * xdisp.c: Make symbols static if they're not exported.
7465 * dispextern.h (scratch_glyph_row, window_box_edges):
7466 (glyph_to_pixel_coords, set_cursor_from_row):
7467 (get_next_display_element, set_iterator_to_next):
7468 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7469 (show_mouse_face): Remove decls
7470 * frame.h (message_buf_print): Likewise.
7471 * lisp.h (pop_message, set_message, check_point_in_composition):
7473 * xterm.h (set_vertical_scroll_bar): Likewise.
7474 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7475 (message_buf_print, scratch_glyph_row, displayed_buffer):
7476 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7477 (get_next_display_element, show_mouse_face, window_box_edges):
7478 (frame_to_window_pixel_xy, check_point_in_composition):
7479 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7480 (glyph_to_pixel_coords): Remove; unused.
7482 * dired.c (file_name_completion): Now static.
7484 * dbusbind.c (xd_in_read_queued_messages): Now static.
7486 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7487 * data.c (circular_list_error): Remove.
7489 * commands.h (last_point_position, last_point_position_buffer):
7490 (last_point_position_window): Remove decls.
7491 * keyboard.c: Make these variables static.
7493 * coding.h (coding, code_convert_region, encode_coding_gap):
7495 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7496 (iso_code_class, detect_coding, code_convert_region): Now static.
7497 (encode_coding_gap): Remove; unused.
7499 * chartab.c (chartab_chars, chartab_bits): Now static.
7501 * charset.h (charset_iso_8859_1): Remove decl.
7502 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7505 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7506 * ccl.c (Vccl_program_table): Now static.
7507 (check_ccl_update): Remove; unused.
7509 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7510 * category.h: ... from here.
7511 * category.c (check_category_table, set_category_set): Now static.
7513 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7514 * lisp.h: Remove these decls.
7516 * buffer.c (buffer_count): Remove unused var.
7518 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7519 so that it's not optimized away.
7520 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7521 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7522 exported only to the debugger.
7524 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7525 * atimer.h (run_all_atimers): Remove; not exported.
7527 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7528 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7529 was inaccessible from Lisp.
7530 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7531 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7533 alloc.c: Import and export fewer symbols, and remove unused items.
7534 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7536 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7537 it's not optimized away by whole-program optimization.
7538 (message_enable_multibyte, free_misc): Remove.
7539 (catchlist, handlerlist, mark_backtrace):
7540 Declare only if BYTE_MARK_STACK.
7541 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7542 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7543 (message_enable_multibyte): Remove decl.
7544 (free_misc, interval_free_list, float_block, float_block_index):
7545 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7546 (cons_free_list, last_marked_index):
7548 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7549 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7550 (mark_backtrace): Define only if BYTE_MARK_STACK.
7551 * xdisp.c (message_enable_multibyte): Now static.
7553 Declare Lisp_Object Q* variables to be 'static' if not exported.
7554 This makes it easier for human readers (and static analyzers)
7555 to see whether these variables are used from other modules.
7556 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7557 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7558 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7559 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7560 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7561 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7562 * xmenu.c, xselect.c:
7563 Declare Q* vars static if they are not used in other modules.
7564 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7565 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7566 Remove decls of unexported vars.
7567 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7569 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7571 Make Emacs functions such as Fatom 'static' by default.
7572 This makes it easier for human readers (and static analyzers)
7573 to see whether these functions can be called from other modules.
7574 DEFUN now defines a static function. To make the function external
7575 so that it can be used in other C modules, use the new macro DEFUE.
7576 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7577 (Finit_image_library):
7578 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7579 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7580 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7581 Remove decls, since these functions are now static.
7582 (Funintern, Fget_internal_run_time): New decls, since these functions
7583 were already external.
7585 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7586 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7587 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7588 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7589 * keyboard.c, keymap.c, lread.c:
7590 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7591 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7592 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7593 Mark functions with DEFUE instead of DEFUN,
7594 if they are used in other modules.
7595 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7596 decls for now-static functions.
7597 * buffer.h (Fdelete_overlay): Remove decl.
7598 * callproc.c (Fgetenv_internal): Mark as internal.
7599 * composite.c (Fremove_list_of_text_properties): Remove decl.
7600 (Fcomposition_get_gstring): New forward static decl.
7601 * composite.h (Fcomposite_get_gstring): Remove decl.
7602 * dired.c (Ffile_attributes): New forward static decl.
7603 * doc.c (Fdocumntation_property): New forward static decl.
7604 * eval.c (Ffetch_bytecode): New forward static decl.
7605 (Funintern): Remove extern decl; now in .h file where it belongs.
7606 * fileio.c (Fmake_symbolic_link): New forward static decl.
7607 * image.c (Finit_image_library): New forward static decl.
7608 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7609 * intervals.h (Fprevious_property_change):
7610 (Fremove_list_of_text_properties): Remove decls.
7611 * keyboard.c (Fthis_command_keys): Remove decl.
7612 (Fcommand_execute): New forward static decl.
7613 * keymap.c (Flookup_key): New forward static decl.
7614 (Fcopy_keymap): Now static.
7615 * keymap.h (Flookup_key): Remove decl.
7616 * process.c (Fget_process): New forward static decl.
7617 (Fprocess_datagram_address): Mark as internal.
7618 * syntax.c (Fsyntax_table_p): New forward static decl.
7619 (skip_chars): Remove duplicate decl.
7620 * textprop.c (Fprevious_property_change): New forward static decl.
7621 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7623 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7624 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7626 * editfns.c (Fformat): Remove unreachable code.
7628 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7630 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7633 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7635 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7636 when at ZV. (Bug#8487)
7638 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7640 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7642 * keyboard.c (parse_tool_bar_item): Likewise.
7643 * sound.c (sound_cleanup, alsa_close): Likewise.
7644 * termcap.c (tgetent): Likewise.
7645 * xfns.c (x_default_font_parameter): Likewise.
7646 * xsettings.c (read_and_apply_settings): Likewise.
7648 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7649 (overrun_check_free): Protoize.
7651 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7653 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7654 since callers should never pass a negative size.
7655 Change the signature to match that of plain 'read' and 'write'; see
7656 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7657 * lisp.h: Update prototypes of emacs_write and emacs_read.
7659 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7661 * xdisp.c (redisplay_window): Don't try to determine the character
7662 position of the scroll margin if the window start point w->startp
7663 is outside the buffer's accessible region. (Bug#8468)
7665 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7667 Fix write-region and its subroutines for buffers > 2GB.
7668 * fileio.c (a_write, e_write): Modify declaration of arguments and
7669 local variables to support buffers larger than 2GB.
7670 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7672 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7673 argument, local variables, and return value.
7675 * lisp.h: Update prototypes of emacs_write and emacs_read.
7677 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7679 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7681 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7683 Fix more problems found by GCC 4.6.0's static checks.
7685 * xdisp.c (vmessage): Use a better test for character truncation.
7687 * charset.c (load_charset_map): <, not <=, for optimization,
7688 and to avoid potential problems with integer overflow.
7689 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7690 * casetab.c (set_identity, shuffle): Likewise.
7691 * editfns.c (Fformat): Likewise.
7692 * syntax.c (skip_chars): Likewise.
7694 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7695 This also lets GCC 4.6.0 generate slightly better loop code.
7697 * callint.c (Fcall_interactively): <, not <=, for optimization.
7698 (Fcall_interactively): Count the number of arguments produced,
7699 not the number of arguments given. This is simpler and lets GCC
7700 4.6.0 generate slightly better code.
7702 * ftfont.c: Distingish more carefully between FcChar8 and char.
7703 The previous code passed unsigned char * to a functions like
7704 strlen and xstrcasecmp that expect char *, which does not
7705 conform to the C standard.
7706 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7707 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7708 char * when the C standard requires it.
7710 * keyboard.c (read_char): Remove unused var.
7712 * eval.c: Port to Windows vsnprintf (Bug#8435).
7714 (SIZE_MAX): Define if the headers do not.
7715 (verror): Do not give up if vsnprintf returns a negative count.
7716 Instead, grow the buffer. This ports to Windows vsnprintf, which
7717 does not conform to C99. Problem reported by Eli Zaretskii.
7718 Also, simplify the allocation scheme, by avoiding the need for
7719 calling realloc, and removing the ALLOCATED variable.
7721 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7723 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7724 But keep the doprint source code for now, as we might revamp it
7725 and use it again (Bug#8435).
7726 * lisp.h (doprnt): Remove.
7727 * Makefile.in (base_obj): Remove doprnt.o.
7728 * deps.mk (doprnt.o): Remove.
7730 error: Print 32- and 64-bit integers portably (Bug#8435).
7731 Without this change, on typical 64-bit hosts error ("...%d...", N)
7732 was used to print both 32- and 64-bit integers N, which relied on
7734 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7736 * lisp.h (error, verror): Mark as printf-like functions.
7737 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7738 Report overflow in size calculations when allocating printf buffer.
7739 Do not truncate output string at its first null byte.
7740 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7741 Truncate the output at a character boundary, since vsnprintf does not
7743 * charset.c (check_iso_charset_parameter): Convert internal
7744 character to string before calling 'error', since %c now has the
7746 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7747 overflow when computing char to be passed to 'error'. Do not
7748 pass Lisp_Object to 'error'; pass the integer instead.
7749 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7750 formatted with plain %d.
7752 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7754 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7756 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7758 * xterm.c (x_catch_errors): Remove duplicate declaration.
7760 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7762 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7764 2011-04-10 Jim Meyering <meyering@redhat.com>
7766 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7767 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7768 return ssize_t not "int", and use size_t as the buffer length.
7769 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7770 * gnutls.h: Update declarations.
7771 * process.c (read_process_output): Use ssize_t, to match.
7772 (send_process): Likewise.
7774 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7776 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7778 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7780 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7781 Use unsigned char, to match FcChar8 type definition.
7783 * xterm.c (handle_one_xevent):
7784 * xmenu.c (create_and_show_popup_menu):
7785 * xselect.c (x_decline_selection_request)
7786 (x_reply_selection_request): Avoid type-punned deref of X events.
7788 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7790 Fix some uses of `int' instead of EMACS_INT.
7791 * search.c (string_match_1, fast_string_match)
7792 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7793 (scan_buffer, find_next_newline_no_quit)
7794 (find_before_next_newline, search_command, Freplace_match)
7795 (Fmatch_data): Make some `int' variables be EMACS_INT.
7797 * xdisp.c (display_count_lines): 3rd argument and return value now
7798 EMACS_INT. All callers changed.
7799 (pint2hrstr): Last argument is now EMACS_INT.
7801 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7802 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7803 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7804 (decode_coding_utf_16, decode_coding_emacs_mule)
7805 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7806 (decode_coding_ccl, decode_coding_charset)
7807 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7808 (decode_coding_iso_2022, decode_coding_emacs_mule)
7809 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7810 <char_offset, last_offset>: Declare EMACS_INT.
7811 (encode_coding_utf_8, encode_coding_utf_16)
7812 (encode_coding_emacs_mule, encode_invocation_designation)
7813 (encode_designation_at_bol, encode_coding_iso_2022)
7814 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7815 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7817 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7818 (encode_invocation_designation): Last argument P_NCHARS is now
7820 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7821 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7823 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7826 * ccl.c (Fccl_execute_on_string): Declare some variables
7829 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7831 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7833 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7835 * process.c (Fformat_network_address): Doc fix.
7837 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7839 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7841 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7843 * keyboard.c (read_char): Call Lisp function help-form-show,
7844 instead of using internal_with_output_to_temp_buffer.
7845 (Qhelp_form_show): New var.
7846 (syms_of_keyboard): Use DEFSYM macro.
7848 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7850 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7852 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7854 * process.c (Flist_processes): Remove to Lisp.
7855 (list_processes_1): Delete.
7857 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7859 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7861 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7863 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7865 Fix more problems found by GCC 4.6.0's static checks.
7867 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7869 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7871 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7873 * xdisp.c (vmessage): Mark as a printf-like function.
7875 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7877 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7879 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7880 printf-like functions.
7881 (tiff_load): Add casts to remove these marks before passing them
7882 to system-supplied API.
7884 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7886 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7887 This avoids several warnings with gcc -Wstrict-overflow.
7888 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7889 directly, rather than having caller test rule sign. This avoids
7890 some unnecessary tests.
7891 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7892 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7893 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7895 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7896 (xfont_open): Avoid unnecessary tests.
7898 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7900 * composite.h, composite.c (composition_gstring_put_cache):
7901 Use EMACS_INT, not int, for length.
7903 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7904 breaking out part of COMPOSITION_DECODE_RULE.
7905 (COMPOSITION_DECODE_RULE): Use it.
7906 * composite.c (get_composition_id): Remove unused local vars,
7907 by using the new macro.
7909 * textprop.c (set_text_properties_1): Change while to do-while,
7910 since the condition is always true at first.
7912 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7913 (interval_deletion_adjustment): Return unsigned value.
7916 * process.c (list_processes_1, create_pty, read_process_output):
7917 (exec_sentinel): Remove vars that were set but not used.
7918 (create_pty): Remove unnecessary "volatile"s.
7919 (Fnetwork_interface_info): Avoid possibility of int overflow.
7920 (read_process_output): Do adaptive read buffering even if carryover.
7921 (read_process_output): Simplify nbytes computation if buffered.
7923 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7925 * syntax.c (scan_words): Remove var that was set but not used.
7926 (update_syntax_table): Use unsigned instead of int.
7928 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7929 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7930 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7932 * print.c (print_error_message): Avoid int overflow.
7934 * font.c (font_list_entities): Redo for clarity,
7935 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7937 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7938 (font_score): Avoid potential overflow in diff calculation.
7940 * fns.c (substring_both): Remove var that is set but not used.
7941 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7943 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7945 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7946 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7947 can always succeed if overflow has undefined behavior.
7949 * search.c (boyer_moore, wordify): Remove vars set but not used.
7950 (wordify): Omit three unnecessary tests.
7952 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7953 All callers changed. This avoids the need for an unused var.
7955 * casefiddle.c (casify_region): Remove var that is set but not used.
7957 * dired.c (file_name_completion): Remove var that is set but not used.
7959 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7961 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7962 (Finsert_file_contents): Remove unnecessary code checking fd.
7964 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7965 Check for integer overflow on size calculations.
7967 * buffer.c (Fprevious_overlay_change): Remove var that is set
7970 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7971 Remove vars that are set but not used.
7972 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7973 (timer_check_2): Mark vars as initialized.
7975 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7977 * image.c (lookup_image): Remove var that is set but not used.
7978 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7980 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7981 that are set but not used.
7983 * xfns.c (make_invisible_cursor): Don't return garbage
7984 if XCreateBitmapFromData fails (Bug#8410).
7986 * xselect.c (x_get_local_selection, x_handle_property_notify):
7987 Remove vars that are set but not used.
7989 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7990 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7992 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7993 Remove var that is set but not used.
7994 (scroll_bar_windows_size): Now size_t, not int.
7995 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7998 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7999 (map_tty_color) [!defined MSDOS]: Likewise.
8001 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8003 * coding.c: Remove vars that are set but not used.
8004 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8005 All callers changed.
8006 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8007 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8008 (decode_coding_charset): Remove vars that are set but not used.
8010 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8011 that is set but not used.
8013 * print.c (print_object): Remove var that is set but not used.
8015 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8016 The gnulib version avoids calling malloc in the usual case,
8017 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8018 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8019 * filelock.c (current_lock_owner): Likewise.
8020 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8021 * sysdep.c: Include allocator.h, careadlinkat.h.
8022 (emacs_no_realloc_allocator): New static constant.
8023 (emacs_readlink): New function.
8024 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8025 ../lib/careadlinkat.h.
8027 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8029 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8030 first non-nil return value).
8032 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8034 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8035 if not defined (Bug#8403).
8037 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8039 * xdisp.c (display_count_lines): Remove parameter `start',
8040 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8041 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8042 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8043 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8044 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8045 and thereabouts. All callers changed.
8046 (get_per_char_metric): Remove parameter `f', unused since
8047 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8049 2011-04-02 Jim Meyering <meyering@redhat.com>
8051 do not dereference NULL upon failed strdup
8052 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8053 (ns_get_family): Likewise.
8055 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8057 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8059 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8061 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8064 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8066 Add lexical binding.
8068 * window.c (Ftemp_output_buffer_show): New fun.
8069 (Fsave_window_excursion):
8070 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8072 * lread.c (lisp_file_lexically_bound_p): New function.
8073 (Fload): Bind Qlexical_binding.
8074 (readevalloop): Remove `evalfun' arg.
8075 Bind Qinternal_interpreter_environment.
8076 (Feval_buffer): Bind Qlexical_binding.
8077 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8079 (syms_of_lread): Declare `lexical-binding'.
8081 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8083 * keyboard.c (eval_dyn): New fun.
8084 (menu_item_eval_property): Use it.
8086 * image.c (parse_image_spec): Use Ffunctionp.
8088 * fns.c (concat, mapcar1): Accept byte-code-functions.
8090 * eval.c (Fsetq): Handle lexical vars.
8091 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8092 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8093 (FletX, Flet): Obey lexical binding.
8094 (Fcommandp): Handle closures.
8095 (Feval): New `lexical' arg.
8096 (eval_sub): New function extracted from Feval. Use it almost
8097 everywhere where Feval was used. Look up vars in lexical env.
8099 (Ffunctionp): Move from subr.el.
8100 (Ffuncall): Handle closures.
8101 (apply_lambda): Remove `eval_flags'.
8102 (funcall_lambda): Handle closures and new byte-code-functions.
8103 (Fspecial_variable_p): New function.
8104 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8105 but without exporting it to Lisp.
8107 * doc.c (Fdocumentation, store_function_docstring):
8108 * data.c (Finteractive_form): Handle closures.
8110 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8113 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8115 (exec_byte_code): New function extracted from Fbyte_code to handle new
8116 calling convention for byte-code-functions. Add new byte-codes.
8118 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8120 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8122 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8124 * xdisp.c (redisplay_internal): Fix prototype.
8126 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8128 * xdisp.c (SCROLL_LIMIT): New macro.
8129 (try_scrolling): Use it when setting scroll_limit.
8130 Limit scrolling to 100 screen lines.
8131 (redisplay_window): Even when falling back on "recentering",
8132 position point in the window according to scroll-conservatively,
8133 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8135 (try_scrolling): When point is above the window, allow searching
8136 as far as scroll_max, or one screenful, to compute vertical
8137 distance from PT to the scroll margin position. This prevents
8138 try_scrolling from unnecessarily failing when
8139 scroll-conservatively is set to a value slightly larger than the
8140 window height. Clean up the case of PT below the margin at bottom
8141 of window: scroll_max can no longer be INT_MAX. When aggressive
8142 scrolling is in use, don't let point enter the opposite scroll
8143 margin as result of the scroll.
8144 (syms_of_xdisp) <scroll-conservatively>: Document the
8145 threshold of 100 lines for never-recentering scrolling.
8147 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8149 * dispextern.h (move_it_by_lines):
8150 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8151 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8152 (message_log_check_duplicate): Remove parameters `prev_bol' and
8153 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8154 (redisplay_internal): Remove parameter `preserve_echo_area',
8155 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8157 * indent.c (Fvertical_motion):
8158 * window.c (window_scroll_pixel_based, Frecenter):
8159 Don't pass `need_y_p' to `move_it_by_lines'.
8161 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8163 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8164 steal a few bits to be more compact.
8165 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8166 Remove unneeded casts.
8168 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8170 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8172 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8173 binding" message (bug#7967).
8175 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8177 Fix more problems found by GCC 4.6.0's static checks.
8179 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8180 Remove unused local var.
8182 * editfns.c (Fmessage_box): Remove unused local var.
8184 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8185 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8186 Omit unused local vars.
8187 * window.c (shrink_windows): Omit unused local var.
8188 * menu.c (digest_single_submenu): Omit unused local var.
8189 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8190 Omit unused local var.
8192 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8193 Don't assume string length fits in int.
8194 (keyremap_step, read_key_sequence): Use size_t for sizes.
8195 (read_key_sequence): Don't check last_real_key_start redundantly.
8197 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8198 instead of alloca (Bug#8344).
8200 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8201 (Fbacktrace_frame): Don't assume nframes fits in int.
8203 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8205 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8208 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8210 * cm.c (calccost): Turn while-do into do-while, for clarity.
8212 * keyboard.c (syms_of_keyboard): Use the same style as later
8213 in this function when indexing through an array. This also
8214 works around GCC bug 48267.
8216 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8218 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8220 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8221 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8223 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8224 This avoids undefined behavior on integer overflow, and is a bit
8225 more convenient anyway since it is compared to a size_t variable.
8227 Variadic C functions now count arguments with size_t, not int.
8228 This avoids an unnecessary limitation on 64-bit machines, which
8229 caused (substring ...) to crash on large vectors (Bug#8344).
8230 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8231 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8232 All variadic functions and their callers changed accordingly.
8233 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8234 * data.c (arith_driver, float_arith_driver): Likewise.
8235 * editfns.c (general_insert_function): Likewise.
8236 * eval.c (struct backtrace.nargs, interactive_p)
8237 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8238 (funcall_lambda, mark_backtrace): Likewise.
8239 * fns.c (concat): Likewise.
8240 * frame.c (x_set_frame_parameters): Likewise.
8241 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8242 0 if not found, not -1. All callers changed.
8244 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8245 (stack_copy_size): Now size_t, not int.
8246 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8248 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8250 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8251 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8252 All callers changed.
8254 * lisp.h (multibyte_char_to_unibyte):
8255 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8256 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8257 * character.h (CHAR_TO_BYTE8):
8258 * cmds.c (internal_self_insert):
8259 * editfns.c (general_insert_function):
8260 * keymap.c (push_key_description):
8261 * search.c (Freplace_match):
8262 * xdisp.c (message_dolog, set_message_1): All callers changed.
8264 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8266 * keyboard.c (safe_run_hook_funcall): New function.
8267 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8268 don't set the hook to nil, but remove the offending function instead.
8269 (Qcommand_hook_internal): Remove, unused.
8270 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8271 Vcommand_hook_internal.
8273 * eval.c (enum run_hooks_condition): Remove.
8274 (funcall_nil, funcall_not): New functions.
8275 (run_hook_with_args): Call each function through a `funcall' argument.
8276 Remove `cond' argument, now redundant.
8277 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8278 (Frun_hook_with_args_until_failure): Adjust accordingly.
8279 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8281 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8283 * dispextern.h (string_buffer_position): Remove declaration.
8285 * print.c (strout): Remove parameter `multibyte', unused since
8286 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8288 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8289 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8290 All callers changed.
8292 * w32.c (_wsa_errlist): Use braces for struct initializers.
8294 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8295 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8296 All callers changed.
8297 (string_buffer_position): Likewise. Also, make static (it's never
8298 used outside xdisp.c).
8299 (cursor_row_p): Remove parameter `w', unused since
8300 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8301 (decode_mode_spec): Remove parameter `precision', introduced during
8302 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8303 All callers changed.
8305 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8307 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8309 2011-03-27 Anders Lindgren <andlind@gmail.com>
8311 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8312 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8313 (ns_update_auto_hide_menu_bar): New functions.
8314 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8315 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8316 ns_constrain_all_frames.
8317 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8318 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8320 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8322 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8324 2011-03-27 Glenn Morris <rgm@gnu.org>
8326 * syssignal.h: Replace RETSIGTYPE with void.
8327 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8328 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8329 Replace SIGTYPE with void everywhere.
8330 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8331 * s/template.h (SIGTYPE): Remove commented out definition.
8333 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8335 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8336 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8338 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8340 * w32.c (read_unc_volume): Use parameter `henum', instead of
8341 global variable `wget_enum_handle'.
8343 * keymap.c (describe_vector): Remove parameters `indices' and
8344 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8345 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8347 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8349 * keyboard.c (timer_check): Remove parameter `do_it_now',
8350 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8351 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8352 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8354 * keyboard.c (read_char):
8355 * w32menu.c (w32_menu_display_help):
8356 * xmenu.c (show_help_event, menu_help_callback):
8357 Adjust calls to `show_help_echo'.
8359 * gtkutil.c (xg_maybe_add_timer):
8360 * keyboard.c (readable_events):
8361 * process.c (wait_reading_process_output):
8362 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8364 * insdel.c (adjust_markers_gap_motion):
8365 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8366 (gap_left, gap_right): Don't call it.
8368 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8370 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8371 incurred during fontification.
8373 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8375 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8376 (DEFVAR_PER_BUFFER): Don't pass it.
8378 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8379 (scrolling_window): Don't pass it.
8381 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8383 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8385 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8387 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8388 of variables specific to SELinux and computation of `encoded_absname'.
8390 * image.c (XPutPixel): Remove unused variable `height'.
8392 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8394 * unexw32.c (get_section_info): Remove unused variable `section'.
8396 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8397 (system_process_attributes): Remove unused variable `sess'.
8398 (sys_read): Remove unused variable `err'.
8400 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8401 (w32_wnd_proc): Remove unused variable `isdead'.
8402 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8403 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8404 (x_create_tip_frame): Remove unused variable `tem'.
8406 * w32inevt.c (w32_console_read_socket):
8407 Remove unused variable `no_events'.
8409 * w32term.c (x_draw_composite_glyph_string_foreground):
8410 Remove unused variable `width'.
8412 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8414 * w32term.c (x_set_glyph_string_clipping):
8415 Don't pass uninitialized region to CombineRgn.
8417 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8419 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8420 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8421 (Fx_close_connection): Remove unused variable `i'.
8423 * w32font.c (w32font_draw): Return number of glyphs.
8424 (w32font_open_internal): Remove unused variable `i'.
8425 (w32font_driver): Add missing initializer.
8427 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8428 (fill_in_menu): Remove unused variable `items_added'.
8430 * w32term.c (last_mouse_press_frame): Remove static global variable.
8431 (w32_clip_to_row): Remove unused variable `f'.
8432 (x_delete_terminal): Remove unused variable `i'.
8434 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8435 (NOTHING): Remove unused static global variable.
8436 (uniscribe_check_otf): Remove unused variable `table'.
8437 (uniscribe_font_driver): Add missing initializers.
8439 2011-03-23 Julien Danjou <julien@danjou.info>
8441 * term.c (Fsuspend_tty, Fresume_tty):
8442 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8443 * window.c (temp_output_buffer_show):
8444 * insdel.c (signal_before_change):
8445 * frame.c (Fhandle_switch_frame):
8446 * fileio.c (Fdo_auto_save):
8447 * emacs.c (Fkill_emacs):
8448 * editfns.c (save_excursion_restore):
8449 * cmds.c (internal_self_insert):
8450 * callint.c (Fcall_interactively):
8451 * buffer.c (Fkill_all_local_variables):
8452 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8454 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8455 unconditionally since it does the check itself.
8457 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8459 Fix more problems found by GCC 4.5.2's static checks.
8461 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8462 the first time through the loop, since we know p0 < p1 then.
8463 This also avoids a gcc -Wstrict-overflow warning.
8465 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8466 leading to a memory leak, possible in functions like
8467 load_charset_map_from_file that can allocate an unbounded number
8468 of objects (Bug#8318).
8470 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8471 that could (at least in theory) be that large.
8473 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8474 This is less likely to overflow, and avoids undefined behavior if
8475 overflow does occur. All callers changed. Use strtoul to scan
8476 for the unsigned long integer.
8477 (pint2hrstr): Simplify and tune code slightly.
8478 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8480 * scroll.c (do_scrolling): Work around GCC bug 48228.
8481 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8483 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8484 This also avoids a warning with gcc -Wstrict-overflow.
8485 (validate_x_resource_name): Simplify count usage.
8486 This also avoids a warning with gcc -Wstrict-overflow.
8488 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8491 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8493 * process.c (Fmake_network_process): Use socklen_t, not int,
8494 where POSIX says socklen_t is required in portable programs.
8495 This fixes a porting bug on hosts like 64-bit HP-UX, where
8496 socklen_t is wider than int (Bug#8277).
8497 (Fmake_network_process, server_accept_connection):
8498 (wait_reading_process_output, read_process_output):
8501 * process.c: Rename or move locals to avoid shadowing.
8502 (list_processes_1, Fmake_network_process):
8503 (read_process_output_error_handler, exec_sentinel_error_handler):
8504 Rename or move locals.
8505 (Fmake_network_process): Define label "retry_connect" only if needed.
8506 (Fnetwork_interface_info): Fix pointer signedness.
8507 (process_send_signal): Add cast to avoid pointer signedness problem.
8508 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8509 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8511 Make tparam.h and terminfo.c consistent.
8512 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8513 Include tparam.h instead, since it declares them.
8514 * cm.h (PC): Remove extern decl; tparam.h now does this.
8515 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8516 * terminfo.c: Include tparam.h, to check interfaces.
8517 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8518 (tparam): Adjust signature to match interface in tparam.h;
8519 this removes some undefined behavior. Check that outstring and len
8520 are zero, which they always are with Emacs.
8521 * tparam.h (PC, BC, UP): New extern decls.
8523 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8524 (xftfont_open): Rename locals to avoid shadowing.
8526 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8527 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8528 (OTF_TAG_SYM): Omit macro if not needed.
8529 (ftfont_list): Remove unused local.
8530 (get_adstyle_property, ftfont_pattern_entity):
8531 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8532 Rename locals to avoid shadowing.
8534 * xfont.c (xfont_list_family): Mark var as initialized.
8536 * xml.c (make_dom): Now static.
8538 * composite.c (composition_compute_stop_pos): Rename local to
8540 (composition_reseat_it): Remove unused locals.
8541 (find_automatic_composition, composition_adjust_point): Likewise.
8542 (composition_update_it): Mark var as initialized.
8543 (find_automatic_composition): Mark vars as initialized,
8544 with a FIXME (Bug#8290).
8546 character.h: Rename locals to avoid shadowing.
8547 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8548 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8549 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8550 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8553 * textprop.c (property_change_between_p): Remove; unused.
8555 * intervals.c (interval_start_pos): Now static.
8557 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8559 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8560 Rename locals to avoid shadowing.
8562 * sound.c (wav_play, au_play, Fplay_sound_internal):
8563 Fix pointer signedness.
8564 (alsa_choose_format): Remove unused local var.
8565 (wav_play): Initialize a variable to 0, to prevent undefined
8566 behavior (Bug#8278).
8568 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8570 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8572 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8573 clobbering (Bug#8298).
8574 * sysdep.c (sys_subshell): Likewise.
8575 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8577 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8578 This should get cleaned up, so that child_setup has the
8579 same signature on all platforms.
8581 * callproc.c (call_process_cleanup): Now static.
8582 (relocate_fd): Rename locals to avoid shadowing.
8584 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8586 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8587 not to be necessary, and produces flickering.
8589 2011-03-20 Glenn Morris <rgm@gnu.org>
8591 * config.in: Remove file.
8593 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8595 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8596 are now in src/globals.h.
8597 (syms_of_minibuf): Remove spurious & from previous change.
8599 2011-03-20 Leo Liu <sdl.web@gmail.com>
8601 * minibuf.c (completing-read-function): New variable.
8602 (completing-read-default): Rename from completing-read.
8603 (completing-read): Call completing-read-function.
8605 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8607 * xfaces.c (Fx_load_color_file):
8608 Read color file from absolute filename (bug#8250).
8610 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8612 * makefile.w32-in: Update dependencies.
8614 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8616 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8618 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8620 Fix more problems found by GCC 4.5.2's static checks.
8622 * process.c (make_serial_process_unwind, send_process_trap):
8623 (sigchld_handler): Now static.
8625 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8626 That way, the code declares only the vars that it needs.
8627 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8628 * s/cygwin.h (PTY_ITERATION): Likewise.
8629 * s/darwin.h (PTY_ITERATION): Likewise.
8630 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8632 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8633 * process.c (allocate_pty): Don't declare stb unless it's needed.
8635 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8636 (CONSTANTLIM): Remove; unused.
8637 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8638 Define only if needed.
8640 * unexelf.c (unexec): Name an expression,
8641 to avoid gcc -Wbad-function-cast warning.
8642 Use a different way to cause a compilation error if anyone uses
8643 n rather than nn, a way that does not involve shadowing.
8644 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8646 * deps.mk (unexalpha.o): Remove; unused.
8648 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8649 * unexec.h: New file.
8650 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8651 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8653 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8654 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8655 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8656 Change as necessary to match prototype in unexec.h.
8658 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8660 (back_comment, skip_chars): Mark vars as initialized.
8662 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8663 Rename locals to avoid shadowing.
8665 * lread.c (read1): Rewrite so as not to use empty "else".
8666 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8668 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8670 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8671 warning when compiling print.c.
8673 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8674 instead of using an uninitialized var.
8675 (font_sort_entities): Mark var as initialized.
8677 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8679 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8680 pointers to constants.
8681 (font_parse_fcname): Remove unused vars.
8682 (font_delete_unmatched): Now static.
8683 (font_get_spec): Remove; unused.
8684 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8685 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8686 Rename or move locals to avoid shadowing.
8688 * fns.c (require_nesting_list, require_unwind): Now static.
8689 (Ffillarray): Rename locals to avoid shadowing.
8691 * floatfns.c (domain_error2): Define only if needed.
8692 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8694 * alloc.c (mark_backtrace): Move decl from here ...
8695 * lisp.h: ... to here, so that it can be checked.
8697 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8698 (Fdefvar): Rewrite so as not to use empty "else".
8699 (lisp_indirect_variable): Name an expression,
8700 to avoid gcc -Wbad-function-cast warning.
8701 (Fdefvar): Rename locals to avoid shadowing.
8703 * callint.c (quotify_arg, quotify_args): Now static.
8704 (Fcall_interactively): Rename locals to avoid shadowing.
8705 Use const pointer when appropriate.
8707 * lisp.h (get_system_name, get_operating_system_release):
8708 Move decls here, to check interfaces.
8709 * process.c (get_operating_system_release): Move decl to lisp.h.
8710 * xrdb.c (get_system_name): Likewise.
8711 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8712 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8713 some of which prompt warnings from gcc -Wbad-function-cast.
8714 (Fformat_time_string, Fencode_time, Finsert_char):
8715 (Ftranslate_region_internal, Fformat):
8716 Rename or remove local vars to avoid shadowing.
8717 (Ftranslate_region_internal): Mark var as initialized.
8719 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8722 * lisp.h (eassert): Check that the argument compiles, even if
8723 ENABLE_CHECKING is not defined.
8725 * data.c (Findirect_variable): Name an expression, to avoid
8726 gcc -Wbad-function-cast warning.
8727 (default_value, arithcompare, arith_driver, arith_error): Now static.
8728 (store_symval_forwarding): Rename local to avoid shadowing.
8729 (Fmake_variable_buffer_local, Fmake_local_variable):
8730 Mark variables as initialized.
8731 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8733 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8734 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8735 Rename locals to avoid shadowing.
8736 (mark_stack): Move local variables into the #ifdef region where
8738 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8739 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8741 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8742 (GC_STRING_CHARS): Remove; not used.
8743 (Fmemory_limit): Cast sbrk's returned value to char *.
8745 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8746 avoids undefined behavior in theory.
8748 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8750 Use functions, not macros, for up- and down-casing (Bug#8254).
8751 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8752 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8753 to use the following functions instead of these macros.
8754 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8755 EMACS_INT, since callers assume the returned value fits in int.
8756 (upcase1): Likewise, for UPCASE_TABLE.
8757 (uppercasep, lowercasep, upcase): New static inline functions.
8758 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8759 the race-condition problem in the old DOWNCASE.
8761 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8762 Rename locals to avoid shadowing.
8763 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8764 (regex_compile, re_search_2, re_match_2_internal):
8765 Remove unused local vars.
8766 (FREE_VAR): Rewrite so as not to use empty "else",
8767 which gcc can warn about.
8768 (regex_compile, re_match_2_internal): Mark locals as initialized.
8769 (RETALLOC_IF): Define only if needed.
8770 (WORDCHAR_P): Likewise. This one is never needed, but is used
8771 only in a comment talking about a compiler bug, so put inside
8772 the #if 0 of that comment.
8773 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8774 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8777 * search.c (boyer_moore): Rename locals to avoid shadowing.
8778 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8779 (PREV_CHAR_BOUNDARY): Likewise.
8781 * search.c (simple_search): Remove unused var.
8783 * dired.c (compile_pattern): Move decl from here ...
8784 * lisp.h: ... to here, so that it can be checked.
8785 (struct re_registers): New forward decl.
8787 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8789 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8791 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8792 Rename locals to avoid shadowing.
8793 (Fvertical_motion): Mark locals as initialized.
8795 * casefiddle.c (casify_object, casify_region): Now static.
8796 (casify_region): Mark local as initialized.
8798 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8800 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8801 New macros, so that the caller can use some names other than
8802 gcpro1, gcpro2, etc.
8803 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8805 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8806 argument, for consistency with GCPRO2_VAR, etc: it is now the
8807 prefix of the variable, not the variable itself. All uses
8809 * dired.c (directory_files_internal, file_name_completion):
8810 Rename locals to avoid shadowing.
8812 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8813 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8814 dired.c's scmp function, had undefined behavior.
8815 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8816 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8817 * buffer.h: ... to here, because these macros use current_buffer,
8818 and the new implementation with inline functions needs to have
8819 current_buffer in scope now, rather than later when the macros
8821 (downcase, upcase1): New static inline functions.
8822 (DOWNCASE, UPCASE1): Reimplement using these functions.
8823 This avoids undefined behavior in expressions like
8824 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8825 from race conditions in accessing the global variables
8826 case_temp1 and case_temp2.
8827 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8828 * lisp.h (case_temp1, case_temp2): Remove their decls.
8829 * character.h (ASCII_CHAR_P): Move from here ...
8830 * lisp.h: ... to here, so that the inline functions mentioned
8833 * dired.c (directory_files_internal_unwind): Now static.
8835 * fileio.c (file_name_as_directory, directory_file_name):
8836 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8838 (file_name_as_directory): Use const pointers when appropriate.
8839 (Fexpand_file_name): Likewise. In particular, newdir might
8840 point at constant storage, so make it a const pointer.
8841 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8842 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8844 (Fset_file_times, Finsert_file_contents, auto_save_error):
8845 Rename locals to avoid shadowing.
8847 * minibuf.c (choose_minibuf_frame_1): Now static.
8848 (Ftry_completion, Fall_completions): Rename or remove locals
8851 * marker.c (bytepos_to_charpos): Remove; unused.
8853 * lisp.h (verify_bytepos, count_markers): New decls,
8854 so that gcc does not warn that these functions aren't declared.
8856 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8857 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8858 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8859 (copy_text): Remove unused local var.
8861 * filelock.c (within_one_second): Now static.
8862 (lock_file_1): Rename local to avoid shadowing.
8864 * buffer.c (fix_overlays_before): Mark locals as initialized.
8865 (fix_start_end_in_overlays): Likewise. This function should be
8866 simplified by using pointers-to-pointers, but that's a different
8868 (switch_to_buffer_1): Now static.
8869 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8870 (report_overlay_modification): Rename locals to avoid shadowing.
8872 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8873 Fix pointer signedness issue.
8874 (sys_subshell): Mark local as volatile if checking for lint,
8875 to suppress a gcc -Wclobbered warning that does not seem to be right.
8876 (MAXPATHLEN): Define only if needed.
8878 * process.c (serial_open, serial_configure): Move decls from here ...
8879 * systty.h: ... to here, so that they can be checked.
8881 * fns.c (get_random, seed_random): Move extern decls from here ...
8882 * lisp.h: ... to here, so that they can be checked.
8884 * sysdep.c (reset_io): Now static.
8885 (wait_for_termination_signal): Remove; unused.
8887 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8888 (copy_keymap_item, append_key, push_text_char_description):
8890 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8891 (DENSE_TABLE_SIZE): Remove; unused.
8892 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8893 (describe_map_tree):
8894 Rename locals to avoid shadowing.
8896 * keyboard.c: Declare functions static if they are not used elsewhere.
8897 (echo_char, echo_dash, cmd_error, top_level_2):
8898 (poll_for_input, handle_async_input): Now static.
8899 (read_char, kbd_buffer_get_event, make_lispy_position):
8900 (make_lispy_event, make_lispy_movement, apply_modifiers):
8901 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8902 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8903 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8904 (read_key_sequence, read_char): Mark locals as initialized.
8905 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8907 * keyboard.h (make_ctrl_char): New decl.
8908 (mark_kboards): Move decl here ...
8909 * alloc.c (mark_kboards): ... from here.
8911 * lisp.h (force_auto_save_soon): New decl.
8913 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8914 (DEFINE_DUMMY_FUNCTION): New macro.
8915 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8917 (main): Add casts to avoid warnings
8918 if GCC considers string literals to be constants.
8920 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8922 * dbusbind.c: Pointer signedness fixes.
8923 (xd_signature, xd_append_arg, xd_initialize):
8924 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8925 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8926 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8927 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8929 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8930 if GCC considers string literals to be constants.
8931 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8933 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8935 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8936 (print_preprocess, print_object): New macro to fix last change.
8938 * print.c (print_preprocess): Don't forget font objects.
8940 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8942 * emacs.c (USAGE3): Doc fixes.
8944 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8946 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8949 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8951 * lisp.h (VWindow_system, Qfile_name_history):
8952 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8953 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8954 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8956 * w32select.c: Don't #include "keyboard.h".
8957 (run_protected): Add extern declaration for waiting_for_input.
8959 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8960 * w32console.c (detect_input_pending, read_input_pending)
8961 (encode_terminal_code):
8962 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8963 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8964 (w32_system_caret_y, Qfile_name_history):
8965 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8966 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8967 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8968 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8969 * w32proc.c (Qlocal, report_file_error):
8970 * w32term.c (Vwindow_system, updating_frame):
8971 * w32uniscribe.c (initialized, uniscribe_font_driver):
8972 Remove unneeded extern declarations.
8974 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8976 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8978 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8980 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8981 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8982 These macros can no longer be used for assignment.
8984 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8985 Assign struct members directly, instead of using BUF_BEGV etc.
8986 (record_buffer_markers, fetch_buffer_markers): New functions for
8987 recording and fetching special buffer markers.
8988 (set_buffer_internal_1, set_buffer_temp): Use them.
8990 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8992 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8994 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8995 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8997 * xdisp.c (hscroll_window_tree):
8998 (reconsider_clip_changes): Use PT instead of BUF_PT.
9000 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9002 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9003 $(EMACS_ROOT)/lib/intprops.h.
9005 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9007 Fix more problems found by GCC 4.5.2's static checks.
9009 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9010 to unsigned char * to avoid compiler diagnostic.
9011 (xg_free_frame_widgets): Make it clear that a local variable is
9012 needed only if USE_GTK_TOOLTIP.
9013 (gdk_window_get_screen): Make it clear that this macro is needed
9014 only if USE_GTK_TOOLTIP.
9015 (int_gtk_range_get_value): New function, which avoids a diagnostic
9016 from gcc -Wbad-function-cast.
9017 (xg_set_toolkit_scroll_bar_thumb): Use it.
9018 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9019 diagnostic from gcc -Wbad-function-cast.
9020 (get_utf8_string, xg_get_file_with_chooser):
9021 Rename locals to avoid shadowing.
9022 (create_dialog): Move locals to avoid shadowing.
9024 * xgselect.c (xg_select): Remove unused var.
9026 * image.c (four_corners_best): Mark locals as initialized.
9027 (gif_load): Initialize transparent_p to zero (Bug#8238).
9028 Mark another local as initialized.
9029 (my_png_error, my_error_exit): Mark with NO_RETURN.
9031 * image.c (clear_image_cache): Now static.
9032 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9033 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9034 (x_edge_detection): Remove unnecessary cast that
9035 gcc -Wbad-function-cast diagnoses.
9036 (gif_load): Fix pointer signedness.
9037 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9038 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9040 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9042 Improve quality of tests for time stamp overflow.
9043 For example, without this patch (encode-time 0 0 0 1 1
9044 1152921504606846976) returns the obviously-bogus value (-948597
9045 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9046 reports time overflow. See
9047 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9048 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9049 * editfns.c: Include limits.h and intprops.h.
9050 (TIME_T_MIN, TIME_T_MAX): New macros.
9051 (time_overflow): Move earlier, to before first use.
9052 (hi_time, lo_time): New functions, for an accurate test for
9054 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9055 (Fget_internal_run_time): Don't assume time_t fits in int.
9056 (make_time): Use list2 instead of Fcons twice.
9057 (Fdecode_time): More accurate test for out-of-range times.
9058 (check_tm_member): New function.
9059 (Fencode_time): Use it, to test for out-of-range times.
9060 (lisp_time_argument): Don't rely on undefined left-shift and
9061 right-shift behavior when checking for time stamp overflow.
9063 * editfns.c (time_overflow): New function, refactoring common code.
9064 (Fformat_time_string, Fdecode_time, Fencode_time):
9065 (Fcurrent_time_string): Use it.
9067 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9068 * dired.c (make_time): Move to ...
9069 * editfns.c (make_time): ... here.
9070 * systime.h: Note the move.
9072 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9074 * fringe.c (update_window_fringes): Remove unused variables.
9076 * unexmacosx.c (copy_data_segment): Also copy __got section.
9079 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9081 * termcap.c [MSDOS]: Include "msdos.h".
9082 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9083 Constify `char *' arguments and their references according to
9084 prototypes in tparam.h.
9086 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9088 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9089 Adapt all references accordingly.
9091 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9093 2011-03-11 Tom Tromey <tromey@redhat.com>
9095 * buffer.c (syms_of_buffer): Remove obsolete comment.
9097 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9099 * termhooks.h (encode_terminal_code): Declare prototype.
9101 * msdos.c (encode_terminal_code): Don't declare prototype.
9103 * term.c (encode_terminal_code): Now external again, used by
9104 w32console.c and msdos.c.
9106 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9107 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9109 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9111 Fix some minor problems found by GCC 4.5.2's static checks.
9113 * fringe.c (update_window_fringes): Mark locals as initialized
9115 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9117 * alloc.c (mark_fringe_data): Move decl from here ...
9118 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9119 to check its interface.
9120 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9122 * fontset.c (free_realized_fontset): Now static.
9123 (Fset_fontset_font): Rename local to avoid shadowing.
9124 (fontset_font): Mark local as initialized.
9125 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9127 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9129 * xselect.c (x_disown_buffer_selections): Remove; not used.
9130 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9131 (x_own_selection, Fx_disown_selection_internal): Rename locals
9133 (x_handle_dnd_message): Remove local to avoid shadowing.
9135 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9136 so that the caller can use some name other than gcpro1.
9137 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9138 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9139 (Fx_backspace_delete_keys_p):
9140 Use them to avoid shadowing, and rename vars to avoid shadowing.
9141 (x_decode_color, x_set_name, x_window): Now static.
9142 (Fx_create_frame): Add braces to silence GCC warning.
9143 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9144 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9145 Remove unused locals.
9146 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9147 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9148 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9151 * xterm.h (x_mouse_leave): New decl.
9153 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9154 Remove unused functions.
9155 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9156 (x_calc_absolute_position): Now static.
9157 (XTread_socket): Don't define label "out" unless it's used.
9158 Don't declare local "event" unless it's used.
9159 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9160 unless they are used.
9161 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9162 (x_fatal_error_signal): Remove; not used.
9163 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9164 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9165 (x_error_catcher, x_connection_closed, x_error_handler):
9166 (x_error_quitter, xembed_send_message, x_iconify_frame):
9167 (my_log_handler): Rename locals to avoid shadowing.
9168 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9169 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9171 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9172 Rename or move locals to avoid shadowing.
9173 (tty_defined_color, merge_face_heights): Now static.
9174 (free_realized_faces_for_fontset): Remove; not used.
9175 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9176 does not deduce is never used uninitialized.
9177 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9178 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9180 * terminal.c (store_terminal_param): Now static.
9182 * xmenu.c (menu_highlight_callback): Now static.
9183 (set_frame_menubar): Remove unused local.
9184 (xmenu_show): Rename parameter to avoid shadowing.
9185 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9186 since they might point to immutable storage.
9187 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9188 since it's unused otherwise.
9190 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9191 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9192 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9193 avoids a gcc -Wuninitialized diagnostic.
9194 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9195 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9196 does not deduce are never used uninitialized.
9198 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9200 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9201 * window.c (window_loop, size_window):
9202 (run_window_configuration_change_hook, enlarge_window): Likewise.
9204 * window.c (display_buffer): Now static.
9205 (size_window): Mark variables that gcc -Wuninitialized
9206 does not deduce are never used uninitialized.
9207 * window.h (check_all_windows): New decl, to forestall
9208 gcc -Wmissing-prototypes diagnostic.
9209 * dispextern.h (bidi_dump_cached_states): Likewise.
9211 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9213 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9215 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9216 and to avoid gcc -Wuninitialized warning.
9217 (load_charset_map): Mark variables that gcc -Wuninitialized
9218 does not deduce are never used uninitialized.
9219 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9221 * coding.c (coding_set_source, coding_set_destination):
9222 Use "else { /* comment */ }" rather than "else /* comment */;"
9223 for clarity, and to avoid gcc -Wempty-body warning.
9224 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9225 a block, when the outer 'i' will do.
9226 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9227 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9228 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9229 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9230 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9231 Rename locals to avoid shadowing.
9232 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9233 * coding.c (emacs_mule_char, encode_invocation_designation):
9234 Now static, since they're not used elsewhere.
9235 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9236 (decode_coding_object, encode_coding_object, detect_coding_system):
9237 (decode_coding_emacs_mule): Mark variables that gcc
9238 -Wuninitialized does not deduce are never used uninitialized.
9239 (detect_coding_iso_2022): Initialize a local variable that might
9240 be used uninitialized. Leave a FIXME because it's not clear that
9241 this initialization is needed. (Bug#8211)
9242 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9243 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9244 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9245 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9246 Remove unused macros.
9248 * category.c (hash_get_category_set): Remove unused local var.
9249 (copy_category_table): Now static, since it's not used elsewhere.
9250 * character.c (string_count_byte8): Likewise.
9252 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9253 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9255 * chartab.c (copy_sub_char_table): Now static, since it's not used
9257 (sub_char_table_ref_and_range, char_table_ref_and_range):
9258 Rename locals to avoid shadowing.
9259 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9261 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9262 (BIDI_BOB): Remove unused macro.
9264 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9265 deduce are never used uninitialized.
9266 * term.c (encode_terminal_code): Likewise.
9268 * term.c (encode_terminal_code): Now static. Remove unused local.
9270 * tparam.h: New file.
9271 * term.c, tparam.h: Include it.
9272 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9273 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9274 Move these decls to tparam.h, and make them agree with what
9275 is actually in tparam.c. The previous trick of using incompatible
9276 decls in different modules does not conform to the C standard.
9277 All callers of tparam changed to use tparam's actual API.
9278 * tparam.c (tparam1, tparam, tgoto):
9279 Use const pointers where appropriate.
9281 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9282 * cm.h (struct cm): Likewise.
9283 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9284 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9285 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9286 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9287 (turn_on_face, init_tty): Likewise.
9288 * termchar.h (struct tty_display_info): Likewise.
9290 * term.c (term_mouse_position): Rename local to avoid shadowing.
9292 * alloc.c (mark_ttys): Move decl from here ...
9293 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9295 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9297 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9299 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9301 * search.c (compile_pattern_1): Remove argument regp, unused since
9302 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9303 (compile_pattern): Don't pass it.
9305 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9307 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9308 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9310 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9312 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9314 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9315 gdk_window_get_screen, gdk_window_get_geometry,
9316 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9317 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9318 (xg_get_pixbuf_from_pixmap): New function.
9319 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9320 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9321 Call xg_get_pixbuf_from_pixmap instead of
9322 gdk_pixbuf_get_from_drawable.
9323 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9324 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9325 (xg_check_special_colors): Use GtkStyleContext and its functions
9327 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9328 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9329 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9330 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9331 Call gtk_widget_get_preferred_size.
9332 (xg_frame_resized): gdk_window_get_geometry only takes 5
9334 (xg_win_to_widget, xg_event_is_for_menubar):
9335 Call gdk_x11_window_lookup_for_display.
9336 (xg_set_widget_bg): New function.
9337 (delete_cb): New function.
9338 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9339 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9340 (xg_set_background_color): Call xg_set_widget_bg.
9341 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9342 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9343 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9344 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9346 (update_frame_tool_bar): Call gtk_widget_hide.
9347 (xg_initialize): Use GDK_KEY_g.
9349 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9351 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9353 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9354 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9355 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9357 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9359 * w32xfns.c (select_palette): Check success of RealizePalette against
9360 GDI_ERROR, not zero.
9362 See ChangeLog.11 for earlier changes.
9368 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9370 This file is part of GNU Emacs.
9372 GNU Emacs is free software: you can redistribute it and/or modify
9373 it under the terms of the GNU General Public License as published by
9374 the Free Software Foundation, either version 3 of the License, or
9375 (at your option) any later version.
9377 GNU Emacs is distributed in the hope that it will be useful,
9378 but WITHOUT ANY WARRANTY; without even the implied warranty of
9379 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9380 GNU General Public License for more details.
9382 You should have received a copy of the GNU General Public License
9383 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.