1 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3 Improve C-level modularity by making more things 'static'.
5 Don't publish debugger-only interfaces to other modules.
6 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7 (verify_bytepos, count_markers): Move decls to the only modules
9 * region-cache.h (pp_cache): Likewise.
10 * window.h (check_all_windows): Likewise.
11 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
13 * sysdep.c (croak): Now static, if
14 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
15 * syssignal.h (croak): Declare only if not static.
17 * alloc.c (refill_memory_reserve): Now static if
18 !defined REL_ALLOC || defined SYSTEM_MALLOC.
19 * lisp.h (refill_memory_reserve): Declare only if not static.
21 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
22 Define only if USE_LUCID.
24 * xrdb.c (x_customization_string, x_rm_string): Now static.
26 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
27 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
29 * xdisp.c (draw_row_with_mouse_face): Now static.
30 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
32 * window.h (check_all_windows): Mark externally visible.
34 * window.c (window_deletion_count): Now static.
36 * undo.c: Make symbols static if they're not exported.
37 (last_undo_buffer, last_boundary_position, pending_boundary):
40 * textprop.c (interval_insert_behind_hooks): Now static.
41 (interval_insert_in_front_hooks): Likewise.
43 * term.c: Make symbols static if they're not exported.
44 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
45 (max_frame_lines, tty_set_terminal_modes):
46 (tty_reset_terminal_modes, tty_turn_off_highlight):
47 (get_tty_terminal): Now static.
48 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
49 * termhooks.h (term_mouse_moveto): Do not declare if
51 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
52 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
54 * sysdep.c: Make symbols static if they're not exported.
55 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
57 (sigprocmask_set, full_mask): Remove; unused.
58 (wait_debugging): Mark as visible.
59 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
60 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
62 * syntax.c (syntax_temp): Define only if !__GNUC__.
64 * sound.c (current_sound_device, current_sound): Now static.
66 * search.c (searchbufs, searchbuf_head): Now static.
68 * scroll.c (scroll_cost): Remove; unused.
69 * dispextern.h (scroll_cost): Remove decl.
71 * region-cache.h (pp_cache): Mark as externally visible.
73 * process.c: Make symbols static if they're not exported.
74 (process_tick, update_tick, create_process, chan_process):
75 (Vprocess_alist, proc_buffered_char, datagram_access):
76 (fd_callback_data, send_process_frame, process_sent_to): Now static.
77 (deactivate_process): Mark defn as static, as well as decl.
78 * lisp.h (create_process): Remove decl.
79 * process.h (chan_process, Vprocess_alist): Remove decls.
81 * print.c: Make symbols static if they're not exported.
82 (print_depth, new_backquote_output, being_printed, print_buffer):
83 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
84 (print_interval, print_number_index, initial_stderr_stream):
86 * lisp.h (Fprinc): Remove decl.
87 (debug_output_compilation_hack): Mark as externally visible.
89 * sysdep.c (croak): Move decl from here to syssignal.h.
90 * syssignal.h (croak): Put it here, so the API can be checked when
91 'croak' is called from dissociate_if_controlling_tty.
93 * minibuf.c: Make symbols static if they're not exported.
94 (minibuf_save_list, choose_minibuf_frame): Now static.
95 * lisp.h (choose_minibuf_frame): Remove decl.
97 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
99 * lread.c: Make symbols static if they're not exported.
100 (read_objects, initial_obarray, oblookup_last_bucket_number):
102 (make_symbol): Remove; unused.
103 * lisp.h (initial_obarray, make_symbol): Remove decls.
105 * keyboard.c: Make symbols static if they're not exported.
106 (single_kboard, recent_keys_index, total_keys, recent_keys):
107 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
108 (this_single_command_key_start, echoing, last_auto_save):
109 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
110 (command_loop, echo_now, keyboard_init_hook, help_char_p):
111 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
112 (Vlispy_mouse_stem, double_click_count):
114 (force_auto_save_soon): Define only if SIGDANGER.
115 (ignore_mouse_drag_p): Now static if
116 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
117 (print_help): Remove; unused.
118 (stop_character, last_timer_event): Mark as externally visible.
119 * keyboard.h (ignore_mouse_drag_p): Declare only if
120 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
121 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
122 * lisp.h (echoing): Remove decl.
123 (force_auto_save_soon): Declare only if SIGDANGER.
124 * xdisp.c (redisplay_window): Simplify code, to make it more
125 obvious that ignore_mouse_drag_p is not accessed if !defined
126 USE_GTK && !defined HAVE_NS.
128 * intervals.c: Make symbols static if they're not exported.
129 (merge_properties_sticky, merge_interval_right, delete_interval):
131 * intervals.h (merge_interval_right, delete_interval): Remove decls.
133 * insdel.c: Make symbols static if they're not exported.
134 However, leave prepare_to_modify_buffer alone. It's never
135 called from outside this function, but that appears to be a bug.
136 (combine_after_change_list, combine_after_change_buffer):
137 (adjust_after_replace, signal_before_change): Now static.
138 (adjust_after_replace_noundo): Remove; unused.
139 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
140 (signal_before_change): Remove decls.
142 * indent.c (val_compute_motion, val_vmotion): Now static.
144 * image.c: Make symbols static if they're not exported.
145 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
147 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
148 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
150 * fringe.c (standard_bitmaps): Now static.
151 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
153 * frame.c: Make symbols static if they're not exported.
154 (x_report_frame_params, make_terminal_frame): Now static.
155 (get_frame_param): Now static, unless HAVE_NS.
156 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
157 (x_get_resource_string): Remove; not used.
158 * frame.h (make_terminal_frame, x_report_frame_params):
159 (x_get_resource_string); Remove decls.
160 (x_fullscreen_adjust): Declare only if WINDOWSNT.
161 * lisp.h (get_frame_param): Declare only if HAVE_NS.
163 * font.c, fontset.c: Make symbols static if they're not exported.
164 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
165 (FACE_SUITABLE_FOR_CHAR_P): Use it.
166 * font.c (font_close_object): Now static.
167 * font.h (font_close_object): Remove.
168 * fontset.c (FONTSET_OBJLIST): Remove.
169 (free_realized_fontset) #if-0 the body, which does nothing.
170 (face_suitable_for_char_p): #if-0, as it's never called.
171 * fontset.h (face_suitable_for_char_p): Remove decl.
172 * xfaces.c (face_at_string_position): Use
173 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
174 since 0 is always ASCII.
176 * fns.c (weak_hash_tables): Now static.
178 * fileio.c: Make symbols static if they're not exported.
179 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
180 (Vwrite_region_annotation_buffers): Now static.
182 * eval.c: Make symbols static if they're not exported.
183 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
184 * lisp.h (backtrace_list): Remove decl.
186 * emacs.c: Make symbols static if they're not exported.
187 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
188 (fatal_error_code, fatal_error_signal_hook, standard_args):
190 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
191 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
192 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
193 * lisp.h (fatal_error_signal_hook): Remove decl.
194 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
196 * editfns.c: Move a (normally-unused) function to its only use.
197 * editfns.c, lisp.h (get_operating_system_release): Remove.
198 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
199 worth the hassle of breaking this out.
201 * xterm.c: Make symbols static if they're not exported.
202 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
203 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
204 (x_destroy_window, x_delete_display):
206 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
207 (x_mouse_leave): Remove; unused.
208 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
209 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
210 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
212 (x_mouse_leave): Declare only if WINDOWSNT.
213 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
214 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
217 * ftxfont.c: Make symbols static if they're not exported.
218 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
220 * font.h (ftxfont_driver): Likewise.
222 * xfns.c: Make symbols static if they're not exported.
223 (x_last_font_name, x_display_info_for_name):
224 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
225 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
226 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
227 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
228 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
229 (last_show_tip_args): Now static.
230 (xic_defaut_fontset, xic_create_fontsetname): Define only if
231 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
232 (x_screen_planes): Remove; unused.
233 * dispextern.h (x_screen_planes): Remove decl.
235 * dispnew.c: Make symbols static if they're not exported.
236 * dispextern.h (redraw_garbaged_frames, scrolling):
237 (increment_row_positions): Remove.
238 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
239 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
241 (redraw_garbaged_frames): Remove; unused.
243 * xfaces.c: Make symbols static if they're not exported.
244 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
246 * xterm.h (defined_color): Remove decls.
247 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
248 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
249 (menu_face_changed_default, defined_color, free_realized_face):
250 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
251 (ascii_face_of_lisp_face): Remove; unused.
253 * xdisp.c: Make symbols static if they're not exported.
254 * dispextern.h (scratch_glyph_row, window_box_edges):
255 (glyph_to_pixel_coords, set_cursor_from_row):
256 (get_next_display_element, set_iterator_to_next):
257 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
258 (show_mouse_face): Remove decls
259 * frame.h (message_buf_print): Likewise.
260 * lisp.h (pop_message, set_message, check_point_in_composition):
262 * xterm.h (set_vertical_scroll_bar): Likewise.
263 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
264 (message_buf_print, scratch_glyph_row, displayed_buffer):
265 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
266 (get_next_display_element, show_mouse_face, window_box_edges):
267 (frame_to_window_pixel_xy, check_point_in_composition):
268 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
269 (glyph_to_pixel_coords): Remove; unused.
271 * dired.c (file_name_completion): Now static.
273 * dbusbind.c (xd_in_read_queued_messages): Now static.
275 * lisp.h (circular_list_error, FOREACH): Remove; unused.
276 * data.c (circular_list_error): Remove.
278 * commands.h (last_point_position, last_point_position_buffer):
279 (last_point_position_window): Remove decls.
280 * keyboard.c: Make these variables static.
282 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
284 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
285 (iso_code_class, detect_coding, code_convert_region): Now static.
286 (encode_coding_gap): Remove; unused.
288 * chartab.c (chartab_chars, chartab_bits): Now static.
290 * charset.h (charset_iso_8859_1): Remove decl.
291 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
294 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
295 * ccl.c (Vccl_program_table): Now static.
296 (check_ccl_update): Remove; unused.
298 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
299 * category.h: ... from here.
300 * category.c (check_category_table, set_category_set): Now static.
302 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
303 * lisp.h: Remove these decls.
305 * buffer.c (buffer_count): Remove unused var.
307 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
308 so that it's not optimized away.
309 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
310 * dispextern.h (bidi_dump_cached_states): Remove, since it's
311 exported only to the debugger.
313 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
314 * atimer.h (run_all_atimers): Removed; not exported.
316 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
317 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
318 was inaccessible from Lisp.
319 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
320 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
322 alloc.c: Import and export fewer symbols, and remove unused items.
323 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
325 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
326 it's not optimized away by whole-program optimization.
327 (message_enable_multibyte, free_misc): Remove.
328 (catchlist, handlerlist, mark_backtrace):
329 Declare only if BYTE_MARK_STACK.
330 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
331 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
332 (message_enable_multibyte): Remove decl.
333 (free_misc, interval_free_list, float_block, float_block_index):
334 (n_float_blocks, float_free_list, cons_block, cons_block_index):
335 (cons_free_list, last_marked_index):
337 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
338 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
339 (mark_backtrace): Define only if BYTE_MARK_STACK.
340 * xdisp.c (message_enable_multibyte): Now static.
342 Declare Lisp_Object Q* variables to be 'static' if not exproted.
343 This makes it easier for human readers (and static analyzers)
344 to see whether these variables are used from other modules.
345 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
346 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
347 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
348 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
349 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
350 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
351 * xmenu.c, xselect.c:
352 Declare Q* vars static if they are not used in other modules.
353 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
354 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
355 Remove decls of unexported vars.
356 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
358 * lisp.h (DEFINE_FUNC): Make sname 'static'.
360 Make Emacs functions such as Fatom 'static' by default.
361 This makes it easier for human readers (and static analyzers)
362 to see whether these functions can be called from other modules.
363 DEFUN now defines a static function. To make the function external
364 so that it can be used in other C modules, use the new macro DEFUE.
365 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
366 (Finit_image_library):
367 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
368 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
369 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
370 Remove decls, since these functions are now static.
371 (Funintern, Fget_internal_run_time): New decls, since these functions
372 were already external.
374 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
375 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
376 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
377 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
378 * keyboard.c, keymap.c, lread.c:
379 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
380 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
381 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
382 Mark functions with DEFUE instead of DEFUN,
383 if they are used in other modules.
384 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
385 decls for now-static functions.
386 * buffer.h (Fdelete_overlay): Remove decl.
387 * callproc.c (Fgetenv_internal): Mark as internal.
388 * composite.c (Fremove_list_of_text_properties): Remove decl.
389 (Fcomposition_get_gstring): New forward static decl.
390 * composite.h (Fcomposite_get_gstring): Remove decl.
391 * dired.c (Ffile_attributes): New forward static decl.
392 * doc.c (Fdocumntation_property): New forward static decl.
393 * eval.c (Ffetch_bytecode): New forward static decl.
394 (Funintern): Remove extern decl; now in .h file where it belongs.
395 * fileio.c (Fmake_symbolic_link): New forward static decl.
396 * image.c (Finit_image_library): New forward static decl.
397 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
398 * intervals.h (Fprevious_property_change):
399 (Fremove_list_of_text_properties): Remove decls.
400 * keyboard.c (Fthis_command_keys): Remove decl.
401 (Fcommand_execute): New forward static decl.
402 * keymap.c (Flookup_key): New forward static decl.
403 (Fcopy_keymap): Now static.
404 * keymap.h (Flookup_key): Remove decl.
405 * process.c (Fget_process): New forward static decl.
406 (Fprocess_datagram_address): Mark as internal.
407 * syntax.c (Fsyntax_table_p): New forward static decl.
408 (skip_chars): Remove duplicate decl.
409 * textprop.c (Fprevious_property_change): New forward static decl.
410 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
412 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
413 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
415 * editfns.c (Fformat): Remove unreachable code.
417 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
419 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
422 2011-04-13 Eli Zaretskii <eliz@gnu.org>
424 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
425 when at ZV. (Bug#8487)
427 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
429 * charset.c (Fclear_charset_maps): Use xfree instead of free.
431 * keyboard.c (parse_tool_bar_item): Likewise.
432 * sound.c (sound_cleanup, alsa_close): Likewise.
433 * termcap.c (tgetent): Likewise.
434 * xfns.c (x_default_font_parameter): Likewise.
435 * xsettings.c (read_and_apply_settings): Likewise.
437 * alloc.c (overrun_check_malloc, overrun_check_realloc)
438 (overrun_check_free): Protoize.
440 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
442 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
443 since callers should never pass a negative size.
444 Change the signature to match that of plain 'read' and 'write'; see
445 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
446 * lisp.h: Update prototypes of emacs_write and emacs_read.
448 2011-04-11 Eli Zaretskii <eliz@gnu.org>
450 * xdisp.c (redisplay_window): Don't try to determine the character
451 position of the scroll margin if the window start point w->startp
452 is outside the buffer's accessible region. (Bug#8468)
454 2011-04-10 Eli Zaretskii <eliz@gnu.org>
456 Fix write-region and its subroutines for buffers > 2GB.
457 * fileio.c (a_write, e_write): Modify declaration of arguments and
458 local variables to support buffers larger than 2GB.
459 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
461 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
462 argument, local variables, and return value.
464 * lisp.h: Update prototypes of emacs_write and emacs_read.
466 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
468 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
470 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
472 Fix more problems found by GCC 4.6.0's static checks.
474 * xdisp.c (vmessage): Use a better test for character truncation.
476 * charset.c (load_charset_map): <, not <=, for optimization,
477 and to avoid potential problems with integer overflow.
478 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
479 * casetab.c (set_identity, shuffle): Likewise.
480 * editfns.c (Fformat): Likewise.
481 * syntax.c (skip_chars): Likewise.
483 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
484 This also lets GCC 4.6.0 generate slightly better loop code.
486 * callint.c (Fcall_interactively): <, not <=, for optimization.
487 (Fcall_interactively): Count the number of arguments produced,
488 not the number of arguments given. This is simpler and lets GCC
489 4.6.0 generate slightly better code.
491 * ftfont.c: Distingish more carefully between FcChar8 and char.
492 The previous code passed unsigned char * to a functions like
493 strlen and xstrcasecmp that expect char *, which does not
494 conform to the C standard.
495 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
496 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
497 char * when the C standard requires it.
499 * keyboard.c (read_char): Remove unused var.
501 * eval.c: Port to Windows vsnprintf (Bug#8435).
503 (SIZE_MAX): Define if the headers do not.
504 (verror): Do not give up if vsnprintf returns a negative count.
505 Instead, grow the buffer. This ports to Windows vsnprintf, which
506 does not conform to C99. Problem reported by Eli Zaretskii.
507 Also, simplify the allocation scheme, by avoiding the need for
508 calling realloc, and removing the ALLOCATED variable.
510 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
512 Remove invocations of doprnt, as Emacs now uses vsnprintf.
513 But keep the doprint source code for now, as we might revamp it
514 and use it again (Bug#8435).
515 * lisp.h (doprnt): Remove.
516 * Makefile.in (base_obj): Remove doprnt.o.
517 * deps.mk (doprnt.o): Remove.
519 error: Print 32- and 64-bit integers portably (Bug#8435).
520 Without this change, on typical 64-bit hosts error ("...%d...", N)
521 was used to print both 32- and 64-bit integers N, which relied on
523 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
525 * lisp.h (error, verror): Mark as printf-like functions.
526 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
527 Report overflow in size calculations when allocating printf buffer.
528 Do not truncate output string at its first null byte.
529 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
530 Truncate the output at a character boundary, since vsnprintf does not
532 * charset.c (check_iso_charset_parameter): Convert internal
533 character to string before calling 'error', since %c now has the
535 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
536 overflow when computing char to be passed to 'error'. Do not
537 pass Lisp_Object to 'error'; pass the integer instead.
538 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
539 formatted with plain %d.
541 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
543 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
545 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
547 * xterm.c (x_catch_errors): Remove duplicate declaration.
549 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
551 * xdisp.c, lisp.h (message_nolog): Remove; unused.
553 2011-04-10 Jim Meyering <meyering@redhat.com>
555 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
556 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
557 return ssize_t not "int", and use size_t as the buffer length.
558 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
559 * gnutls.h: Update declarations.
560 * process.c (read_process_output): Use ssize_t, to match.
561 (send_process): Likewise.
563 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
565 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
567 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
569 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
570 unsigned char, to match FcChar8 type definition.
572 * xterm.c (handle_one_xevent):
573 * xmenu.c (create_and_show_popup_menu):
574 * xselect.c (x_decline_selection_request)
575 (x_reply_selection_request): Avoid type-punned deref of X events.
577 2011-04-09 Eli Zaretskii <eliz@gnu.org>
579 Fix some uses of `int' instead of EMACS_INT.
580 * search.c (string_match_1, fast_string_match)
581 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
582 (scan_buffer, find_next_newline_no_quit)
583 (find_before_next_newline, search_command, Freplace_match)
584 (Fmatch_data): Make some `int' variables be EMACS_INT.
586 * xdisp.c (display_count_lines): 3rd argument and return value now
587 EMACS_INT. All callers changed.
588 (pint2hrstr): Last argument is now EMACS_INT.
590 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
591 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
592 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
593 (decode_coding_utf_16, decode_coding_emacs_mule)
594 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
595 (decode_coding_ccl, decode_coding_charset)
596 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
597 (decode_coding_iso_2022, decode_coding_emacs_mule)
598 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
599 <char_offset, last_offset>: Declare EMACS_INT.
600 (encode_coding_utf_8, encode_coding_utf_16)
601 (encode_coding_emacs_mule, encode_invocation_designation)
602 (encode_designation_at_bol, encode_coding_iso_2022)
603 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
604 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
606 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
607 (encode_invocation_designation): Last argument P_NCHARS is now
609 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
610 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
612 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
615 * ccl.c (Fccl_execute_on_string): Declare some variables
618 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
620 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
622 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
624 * process.c (Fformat_network_address): Doc fix.
626 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
628 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
630 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
632 * keyboard.c (read_char): Call Lisp function help-form-show,
633 instead of using internal_with_output_to_temp_buffer.
634 (Qhelp_form_show): New var.
635 (syms_of_keyboard): Use DEFSYM macro.
637 * print.c (internal_with_output_to_temp_buffer): Function deleted.
639 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
641 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
643 * process.c (Flist_processes): Removed to Lisp.
644 (list_processes_1): Deleted.
646 2011-04-06 Eli Zaretskii <eliz@gnu.org>
648 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
650 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
652 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
654 Fix more problems found by GCC 4.6.0's static checks.
656 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
658 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
660 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
662 * xdisp.c (vmessage): Mark as a printf-like function.
664 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
666 * sound.c (sound_warning): Don't crash if arg contains a printf format.
668 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
669 printf-like functions.
670 (tiff_load): Add casts to remove these marks before passing them
671 to system-supplied API.
673 * eval.c (Fsignal): Remove excess argument to 'fatal'.
675 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
676 This avoids several warnings with gcc -Wstrict-overflow.
677 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
678 directly, rather than having caller test rule sign. This avoids
679 some unnecessary tests.
680 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
681 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
682 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
684 * xfont.c (xfont_text_extents): Remove var that was set but not used.
685 (xfont_open): Avoid unnecessary tests.
687 * composite.c (composition_gstring_put_cache): Use unsigned integer.
689 * composite.h, composite.c (composition_gstring_put_cache):
690 Use EMACS_INT, not int, for length.
692 * composite.h (COMPOSITION_DECODE_REFS): New macro,
693 breaking out part of COMPOSITION_DECODE_RULE.
694 (COMPOSITION_DECODE_RULE): Use it.
695 * composite.c (get_composition_id): Remove unused local vars,
696 by using the new macro.
698 * textprop.c (set_text_properties_1): Change while to do-while,
699 since the condition is always true at first.
701 * intervals.c (graft_intervals_into_buffer): Mark var as used.
702 (interval_deletion_adjustment): Return unsigned value.
705 * process.c (list_processes_1, create_pty, read_process_output):
706 (exec_sentinel): Remove vars that were set but not used.
707 (create_pty): Remove unnecessary "volatile"s.
708 (Fnetwork_interface_info): Avoid possibility of int overflow.
709 (read_process_output): Do adaptive read buffering even if carryover.
710 (read_process_output): Simplify nbytes computation if buffered.
712 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
714 * syntax.c (scan_words): Remove var that was set but not used.
715 (update_syntax_table): Use unsigned instead of int.
717 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
718 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
719 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
721 * print.c (print_error_message): Avoid int overflow.
723 * font.c (font_list_entities): Redo for clarity,
724 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
726 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
727 (font_score): Avoid potential overflow in diff calculation.
729 * fns.c (substring_both): Remove var that is set but not used.
730 (sxhash): Redo loop for clarity and to avoid wraparound warning.
732 * eval.c (funcall_lambda): Rename local to avoid shadowing.
734 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
735 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
736 can always succeed if overflow has undefined behavior.
738 * search.c (boyer_moore, wordify): Remove vars set but not used.
739 (wordify): Omit three unnecessary tests.
741 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
742 All callers changed. This avoids the need for an unused var.
744 * casefiddle.c (casify_region): Remove var that is set but not used.
746 * dired.c (file_name_completion): Remove var that is set but not used.
748 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
750 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
751 (Finsert_file_contents): Remove unnecessary code checking fd.
753 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
754 Check for integer overflow on size calculations.
756 * buffer.c (Fprevious_overlay_change): Remove var that is set
759 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
760 Remove vars that are set but not used.
761 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
762 (timer_check_2): Mark vars as initialized.
764 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
766 * image.c (lookup_image): Remove var that is set but not used.
767 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
769 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
770 that are set but not used.
772 * xfns.c (make_invisible_cursor): Don't return garbage
773 if XCreateBitmapFromData fails (Bug#8410).
775 * xselect.c (x_get_local_selection, x_handle_property_notify):
776 Remove vars that are set but not used.
778 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
779 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
781 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
782 Remove var that is set but not used.
783 (scroll_bar_windows_size): Now size_t, not int.
784 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
787 * xfaces.c (realize_named_face): Remove vars that are set but not used.
788 (map_tty_color) [!defined MSDOS]: Likewise.
790 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
792 * coding.c: Remove vars that are set but not used.
793 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
795 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
796 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
797 (decode_coding_charset): Remove vars that are set but not used.
799 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
800 that is set but not used.
802 * print.c (print_object): Remove var that is set but not used.
804 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
805 The gnulib version avoids calling malloc in the usual case,
806 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
807 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
808 * filelock.c (current_lock_owner): Likewise.
809 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
810 * sysdep.c: Include allocator.h, careadlinkat.h.
811 (emacs_no_realloc_allocator): New static constant.
812 (emacs_readlink): New function.
813 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
814 ../lib/careadlinkat.h.
816 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
818 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
819 first non-nil return value).
821 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
823 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
824 if not defined (Bug#8403).
826 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
828 * xdisp.c (display_count_lines): Remove parameter `start',
829 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
830 (get_char_face_and_encoding): Remove parameter `multibyte_p',
831 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
832 (fill_stretch_glyph_string): Remove parameters `row' and `area',
833 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
834 and thereabouts. All callers changed.
835 (get_per_char_metric): Remove parameter `f', unused since
836 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
838 2011-04-02 Jim Meyering <meyering@redhat.com>
840 do not dereference NULL upon failed strdup
841 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
842 (ns_get_family): Likewise.
844 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
846 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
848 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
850 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
853 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
857 * window.c (Ftemp_output_buffer_show): New fun.
858 (Fsave_window_excursion):
859 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
861 * lread.c (lisp_file_lexically_bound_p): New function.
862 (Fload): Bind Qlexical_binding.
863 (readevalloop): Remove `evalfun' arg.
864 Bind Qinternal_interpreter_environment.
865 (Feval_buffer): Bind Qlexical_binding.
866 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
868 (syms_of_lread): Declare `lexical-binding'.
870 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
872 * keyboard.c (eval_dyn): New fun.
873 (menu_item_eval_property): Use it.
875 * image.c (parse_image_spec): Use Ffunctionp.
877 * fns.c (concat, mapcar1): Accept byte-code-functions.
879 * eval.c (Fsetq): Handle lexical vars.
880 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
881 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
882 (FletX, Flet): Obey lexical binding.
883 (Fcommandp): Handle closures.
884 (Feval): New `lexical' arg.
885 (eval_sub): New function extracted from Feval. Use it almost
886 everywhere where Feval was used. Look up vars in lexical env.
888 (Ffunctionp): Move from subr.el.
889 (Ffuncall): Handle closures.
890 (apply_lambda): Remove `eval_flags'.
891 (funcall_lambda): Handle closures and new byte-code-functions.
892 (Fspecial_variable_p): New function.
893 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
894 but without exporting it to Lisp.
896 * doc.c (Fdocumentation, store_function_docstring):
897 * data.c (Finteractive_form): Handle closures.
899 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
902 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
904 (exec_byte_code): New function extracted from Fbyte_code to handle new
905 calling convention for byte-code-functions. Add new byte-codes.
907 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
909 * alloc.c (Fmake_symbol): Init new `declared_special' field.
911 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
913 * xdisp.c (redisplay_internal): Fix prototype.
915 2011-03-31 Eli Zaretskii <eliz@gnu.org>
917 * xdisp.c (SCROLL_LIMIT): New macro.
918 (try_scrolling): Use it when setting scroll_limit. Limit
919 scrolling to 100 screen lines.
920 (redisplay_window): Even when falling back on "recentering",
921 position point in the window according to scroll-conservatively,
922 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
924 (try_scrolling): When point is above the window, allow searching
925 as far as scroll_max, or one screenful, to compute vertical
926 distance from PT to the scroll margin position. This prevents
927 try_scrolling from unnecessarily failing when
928 scroll-conservatively is set to a value slightly larger than the
929 window height. Clean up the case of PT below the margin at bottom
930 of window: scroll_max can no longer be INT_MAX. When aggressive
931 scrolling is in use, don't let point enter the opposite scroll
932 margin as result of the scroll.
933 (syms_of_xdisp) <scroll-conservatively>: Document the
934 threshold of 100 lines for never-recentering scrolling.
936 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
938 * dispextern.h (move_it_by_lines):
939 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
940 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
941 (message_log_check_duplicate): Remove parameters `prev_bol' and
942 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
943 (redisplay_internal): Remove parameter `preserve_echo_area',
944 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
946 * indent.c (Fvertical_motion):
947 * window.c (window_scroll_pixel_based, Frecenter):
948 Don't pass `need_y_p' to `move_it_by_lines'.
950 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
952 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
953 steal a few bits to be more compact.
954 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
955 Remove unneeded casts.
957 * bytecode.c (Fbyte_code): CAR and CDR can GC.
959 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
961 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
962 binding" message (bug#7967).
964 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
966 Fix more problems found by GCC 4.6.0's static checks.
968 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
969 Remove unused local var.
971 * editfns.c (Fmessage_box): Remove unused local var.
973 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
974 (note_mode_line_or_margin_highlight, note_mouse_highlight):
975 Omit unused local vars.
976 * window.c (shrink_windows): Omit unused local var.
977 * menu.c (digest_single_submenu): Omit unused local var.
978 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
979 Omit unused local var.
981 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
982 Don't assume string length fits in int.
983 (keyremap_step, read_key_sequence): Use size_t for sizes.
984 (read_key_sequence): Don't check last_real_key_start redundantly.
986 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
987 instead of alloca (Bug#8344).
989 * eval.c (Fbacktrace): Don't assume nargs fits in int.
990 (Fbacktrace_frame): Don't assume nframes fits in int.
992 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
994 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
997 * term.c (produce_glyphless_glyph): Remove unnecessary test.
999 * cm.c (calccost): Turn while-do into do-while, for clarity.
1001 * keyboard.c (syms_of_keyboard): Use the same style as later
1002 in this function when indexing through an array. This also
1003 works around GCC bug 48267.
1005 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1007 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1009 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1010 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1012 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1013 This avoids undefined behavior on integer overflow, and is a bit
1014 more convenient anyway since it is compared to a size_t variable.
1016 Variadic C functions now count arguments with size_t, not int.
1017 This avoids an unnecessary limitation on 64-bit machines, which
1018 caused (substring ...) to crash on large vectors (Bug#8344).
1019 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1020 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
1021 All variadic functions and their callers changed accordingly.
1022 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1023 * data.c (arith_driver, float_arith_driver): Likewise.
1024 * editfns.c (general_insert_function): Likewise.
1025 * eval.c (struct backtrace.nargs, interactive_p)
1026 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1027 (funcall_lambda, mark_backtrace): Likewise.
1028 * fns.c (concat): Likewise.
1029 * frame.c (x_set_frame_parameters): Likewise.
1030 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1031 0 if not found, not -1. All callers changed.
1033 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1034 (stack_copy_size): Now size_t, not int.
1035 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1037 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1039 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1040 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1041 All callers changed.
1043 * lisp.h (multibyte_char_to_unibyte):
1044 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1045 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1046 * character.h (CHAR_TO_BYTE8):
1047 * cmds.c (internal_self_insert):
1048 * editfns.c (general_insert_function):
1049 * keymap.c (push_key_description):
1050 * search.c (Freplace_match):
1051 * xdisp.c (message_dolog, set_message_1): All callers changed.
1053 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1055 * keyboard.c (safe_run_hook_funcall): New function.
1056 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1057 don't set the hook to nil, but remove the offending function instead.
1058 (Qcommand_hook_internal): Remove, unused.
1059 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1060 Vcommand_hook_internal.
1062 * eval.c (enum run_hooks_condition): Remove.
1063 (funcall_nil, funcall_not): New functions.
1064 (run_hook_with_args): Call each function through a `funcall' argument.
1065 Remove `cond' argument, now redundant.
1066 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1067 (Frun_hook_with_args_until_failure): Adjust accordingly.
1068 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1070 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1072 * dispextern.h (string_buffer_position): Remove declaration.
1074 * print.c (strout): Remove parameter `multibyte', unused since
1075 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1077 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1078 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1079 All callers changed.
1081 * w32.c (_wsa_errlist): Use braces for struct initializers.
1083 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1084 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1085 All callers changed.
1086 (string_buffer_position): Likewise. Also, make static (it's never
1087 used outside xdisp.c).
1088 (cursor_row_p): Remove parameter `w', unused since
1089 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1090 (decode_mode_spec): Remove parameter `precision', introduced during
1091 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1092 All callers changed.
1094 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1096 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1098 2011-03-27 Anders Lindgren <andlind@gmail.com>
1100 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1101 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1102 (ns_update_auto_hide_menu_bar): New functions.
1103 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1104 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1105 ns_constrain_all_frames.
1106 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1107 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1109 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1111 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1113 2011-03-27 Glenn Morris <rgm@gnu.org>
1115 * syssignal.h: Replace RETSIGTYPE with void.
1116 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1117 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1118 Replace SIGTYPE with void everywhere.
1119 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1120 * s/template.h (SIGTYPE): Remove commented out definition.
1122 2011-03-26 Eli Zaretskii <eliz@gnu.org>
1124 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1125 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1127 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
1129 * w32.c (read_unc_volume): Use parameter `henum', instead of
1130 global variable `wget_enum_handle'.
1132 * keymap.c (describe_vector): Remove parameters `indices' and
1133 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1134 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1136 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1138 * keyboard.c (timer_check): Remove parameter `do_it_now',
1139 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1140 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1141 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1143 * keyboard.c (read_char):
1144 * w32menu.c (w32_menu_display_help):
1145 * xmenu.c (show_help_event, menu_help_callback):
1146 Adjust calls to `show_help_echo'.
1148 * gtkutil.c (xg_maybe_add_timer):
1149 * keyboard.c (readable_events):
1150 * process.c (wait_reading_process_output):
1151 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1153 * insdel.c (adjust_markers_gap_motion):
1154 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1155 (gap_left, gap_right): Don't call it.
1157 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
1159 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1160 incurred during fontification.
1162 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1164 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1165 (DEFVAR_PER_BUFFER): Don't pass it.
1167 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1168 (scrolling_window): Don't pass it.
1170 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1172 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1174 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1176 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1177 of variables specific to SELinux and computation of `encoded_absname'.
1179 * image.c (XPutPixel): Remove unused variable `height'.
1181 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1183 * unexw32.c (get_section_info): Remove unused variable `section'.
1185 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1186 (system_process_attributes): Remove unused variable `sess'.
1187 (sys_read): Remove unused variable `err'.
1189 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1190 (w32_wnd_proc): Remove unused variable `isdead'.
1191 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1192 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1193 (x_create_tip_frame): Remove unused variable `tem'.
1195 * w32inevt.c (w32_console_read_socket):
1196 Remove unused variable `no_events'.
1198 * w32term.c (x_draw_composite_glyph_string_foreground):
1199 Remove unused variable `width'.
1201 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
1203 * w32term.c (x_set_glyph_string_clipping):
1204 Don't pass uninitialized region to CombineRgn.
1206 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
1208 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1209 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1210 (Fx_close_connection): Remove unused variable `i'.
1212 * w32font.c (w32font_draw): Return number of glyphs.
1213 (w32font_open_internal): Remove unused variable `i'.
1214 (w32font_driver): Add missing initializer.
1216 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1217 (fill_in_menu): Remove unused variable `items_added'.
1219 * w32term.c (last_mouse_press_frame): Remove static global variable.
1220 (w32_clip_to_row): Remove unused variable `f'.
1221 (x_delete_terminal): Remove unused variable `i'.
1223 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1224 (NOTHING): Remove unused static global variable.
1225 (uniscribe_check_otf): Remove unused variable `table'.
1226 (uniscribe_font_driver): Add missing initializers.
1228 2011-03-23 Julien Danjou <julien@danjou.info>
1230 * term.c (Fsuspend_tty, Fresume_tty):
1231 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1232 * window.c (temp_output_buffer_show):
1233 * insdel.c (signal_before_change):
1234 * frame.c (Fhandle_switch_frame):
1235 * fileio.c (Fdo_auto_save):
1236 * emacs.c (Fkill_emacs):
1237 * editfns.c (save_excursion_restore):
1238 * cmds.c (internal_self_insert):
1239 * callint.c (Fcall_interactively):
1240 * buffer.c (Fkill_all_local_variables):
1241 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1243 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
1244 unconditionnaly since it does the check itself.
1246 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
1248 Fix more problems found by GCC 4.5.2's static checks.
1250 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1251 the first time through the loop, since we know p0 < p1 then.
1252 This also avoids a gcc -Wstrict-overflow warning.
1254 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1255 leading to a memory leak, possible in functions like
1256 load_charset_map_from_file that can allocate an unbounded number
1257 of objects (Bug#8318).
1259 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1260 that could (at least in theory) be that large.
1262 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1263 This is less likely to overflow, and avoids undefined behavior if
1264 overflow does occur. All callers changed. Use strtoul to scan
1265 for the unsigned long integer.
1266 (pint2hrstr): Simplify and tune code slightly.
1267 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
1269 * scroll.c (do_scrolling): Work around GCC bug 48228.
1270 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1272 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1273 This also avoids a warning with gcc -Wstrict-overflow.
1274 (validate_x_resource_name): Simplify count usage.
1275 This also avoids a warning with gcc -Wstrict-overflow.
1277 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1280 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
1282 * process.c (Fmake_network_process): Use socklen_t, not int,
1283 where POSIX says socklen_t is required in portable programs.
1284 This fixes a porting bug on hosts like 64-bit HP-UX, where
1285 socklen_t is wider than int (Bug#8277).
1286 (Fmake_network_process, server_accept_connection):
1287 (wait_reading_process_output, read_process_output):
1290 * process.c: Rename or move locals to avoid shadowing.
1291 (list_processes_1, Fmake_network_process):
1292 (read_process_output_error_handler, exec_sentinel_error_handler):
1293 Rename or move locals.
1294 (Fmake_network_process): Define label "retry_connect" only if needed.
1295 (Fnetwork_interface_info): Fix pointer signedness.
1296 (process_send_signal): Add cast to avoid pointer signedness problem.
1297 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
1298 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
1300 Make tparam.h and terminfo.c consistent.
1301 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1302 Include tparam.h instead, since it declares them.
1303 * cm.h (PC): Remove extern decl; tparam.h now does this.
1304 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1305 * terminfo.c: Include tparam.h, to check interfaces.
1306 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1307 (tparam): Adjust signature to match interface in tparam.h;
1308 this removes some undefined behavior. Check that outstring and len
1309 are zero, which they always are with Emacs.
1310 * tparam.h (PC, BC, UP): New extern decls.
1312 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
1313 (xftfont_open): Rename locals to avoid shadowing.
1315 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
1316 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1317 (OTF_TAG_SYM): Omit macro if not needed.
1318 (ftfont_list): Remove unused local.
1319 (get_adstyle_property, ftfont_pattern_entity):
1320 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1321 Rename locals to avoid shadowing.
1323 * xfont.c (xfont_list_family): Mark var as initialized.
1325 * xml.c (make_dom): Now static.
1327 * composite.c (composition_compute_stop_pos): Rename local to
1329 (composition_reseat_it): Remove unused locals.
1330 (find_automatic_composition, composition_adjust_point): Likewise.
1331 (composition_update_it): Mark var as initialized.
1332 (find_automatic_composition): Mark vars as initialized,
1333 with a FIXME (Bug#8290).
1335 character.h: Rename locals to avoid shadowing.
1336 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1337 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1338 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1339 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1342 * textprop.c (property_change_between_p): Remove; unused.
1344 * intervals.c (interval_start_pos): Now static.
1346 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1348 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1349 Rename locals to avoid shadowing.
1351 * sound.c (wav_play, au_play, Fplay_sound_internal):
1352 Fix pointer signedness.
1353 (alsa_choose_format): Remove unused local var.
1354 (wav_play): Initialize a variable to 0, to prevent undefined
1355 behavior (Bug#8278).
1357 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1359 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1361 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1362 clobbering (Bug#8298).
1363 * sysdep.c (sys_subshell): Likewise.
1364 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
1366 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1367 This should get cleaned up, so that child_setup has the
1368 same signature on all platforms.
1370 * callproc.c (call_process_cleanup): Now static.
1371 (relocate_fd): Rename locals to avoid shadowing.
1373 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
1375 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1376 not to be necessary, and produces flickering.
1378 2011-03-20 Glenn Morris <rgm@gnu.org>
1380 * config.in: Remove file.
1382 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
1384 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1385 are now in src/globals.h.
1386 (syms_of_minibuf): Remove spurious & from previous change.
1388 2011-03-20 Leo <sdl.web@gmail.com>
1390 * minibuf.c (completing-read-function): New variable.
1391 (completing-read-default): Rename from completing-read.
1392 (completing-read): Call completing-read-function.
1394 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
1396 * xfaces.c (Fx_load_color_file):
1397 Read color file from absolute filename (bug#8250).
1399 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
1401 * makefile.w32-in: Update dependencies.
1403 2011-03-17 Eli Zaretskii <eliz@gnu.org>
1405 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1407 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1409 Fix more problems found by GCC 4.5.2's static checks.
1411 * process.c (make_serial_process_unwind, send_process_trap):
1412 (sigchld_handler): Now static.
1414 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1415 That way, the code declares only the vars that it needs.
1416 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1417 * s/cygwin.h (PTY_ITERATION): Likewise.
1418 * s/darwin.h (PTY_ITERATION): Likewise.
1419 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1421 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1422 * process.c (allocate_pty): Don't declare stb unless it's needed.
1424 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
1425 (CONSTANTLIM): Remove; unused.
1426 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1427 Define only if needed.
1429 * unexelf.c (unexec): Name an expression,
1430 to avoid gcc -Wbad-function-cast warning.
1431 Use a different way to cause a compilation error if anyone uses
1432 n rather than nn, a way that does not involve shadowing.
1433 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
1435 * deps.mk (unexalpha.o): Remove; unused.
1437 New file unexec.h, the (simple) interface for unexec (Bug#8267).
1438 * unexec.h: New file.
1439 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1440 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1442 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1443 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1444 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
1445 Change as necessary to match prototype in unexec.h.
1447 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1449 (back_comment, skip_chars): Mark vars as initialized.
1451 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1452 Rename locals to avoid shadowing.
1454 * lread.c (read1): Rewrite so as not to use empty "else".
1455 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
1457 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1459 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1460 warning when compiling print.c.
1462 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1463 instead of using an uninitialized var.
1464 (font_sort_entities): Mark var as initialized.
1466 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1468 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1469 pointers to constants.
1470 (font_parse_fcname): Remove unused vars.
1471 (font_delete_unmatched): Now static.
1472 (font_get_spec): Remove; unused.
1473 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1474 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1475 Rename or move locals to avoid shadowing.
1477 * fns.c (require_nesting_list, require_unwind): Now static.
1478 (Ffillarray): Rename locals to avoid shadowing.
1480 * floatfns.c (domain_error2): Define only if needed.
1481 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1483 * alloc.c (mark_backtrace): Move decl from here ...
1484 * lisp.h: ... to here, so that it can be checked.
1486 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
1487 (Fdefvar): Rewrite so as not to use empty "else".
1488 (lisp_indirect_variable): Name an expression,
1489 to avoid gcc -Wbad-function-cast warning.
1490 (Fdefvar): Rename locals to avoid shadowing.
1492 * callint.c (quotify_arg, quotify_args): Now static.
1493 (Fcall_interactively): Rename locals to avoid shadowing.
1494 Use const pointer when appropriate.
1496 * lisp.h (get_system_name, get_operating_system_release):
1497 Move decls here, to check interfaces.
1498 * process.c (get_operating_system_release): Move decl to lisp.h.
1499 * xrdb.c (get_system_name): Likewise.
1500 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1501 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1502 some of which prompt warnings from gcc -Wbad-function-cast.
1503 (Fformat_time_string, Fencode_time, Finsert_char):
1504 (Ftranslate_region_internal, Fformat):
1505 Rename or remove local vars to avoid shadowing.
1506 (Ftranslate_region_internal): Mark var as initialized.
1508 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1511 * lisp.h (eassert): Check that the argument compiles, even if
1512 ENABLE_CHECKING is not defined.
1514 * data.c (Findirect_variable): Name an expression, to avoid
1515 gcc -Wbad-function-cast warning.
1516 (default_value, arithcompare, arith_driver, arith_error): Now static.
1517 (store_symval_forwarding): Rename local to avoid shadowing.
1518 (Fmake_variable_buffer_local, Fmake_local_variable):
1519 Mark variables as initialized.
1520 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
1522 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
1523 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1524 Rename locals to avoid shadowing.
1525 (mark_stack): Move local variables into the #ifdef region where
1527 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1528 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1530 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1531 (GC_STRING_CHARS): Remove; not used.
1532 (Fmemory_limit): Cast sbrk's returned value to char *.
1534 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1535 avoids undefined behavior in theory.
1537 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1539 Use functions, not macros, for up- and down-casing (Bug#8254).
1540 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1541 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1542 to use the following functions instead of these macros.
1543 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1544 EMACS_INT, since callers assume the returned value fits in int.
1545 (upcase1): Likewise, for UPCASE_TABLE.
1546 (uppercasep, lowercasep, upcase): New static inline functions.
1547 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
1548 the race-condition problem in the old DOWNCASE.
1550 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1551 Rename locals to avoid shadowing.
1552 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
1553 (regex_compile, re_search_2, re_match_2_internal):
1554 Remove unused local vars.
1555 (FREE_VAR): Rewrite so as not to use empty "else",
1556 which gcc can warn about.
1557 (regex_compile, re_match_2_internal): Mark locals as initialized.
1558 (RETALLOC_IF): Define only if needed.
1559 (WORDCHAR_P): Likewise. This one is never needed, but is used
1560 only in a comment talking about a compiler bug, so put inside
1561 the #if 0 of that comment.
1562 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1563 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1566 * search.c (boyer_moore): Rename locals to avoid shadowing.
1567 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1568 (PREV_CHAR_BOUNDARY): Likewise.
1570 * search.c (simple_search): Remove unused var.
1572 * dired.c (compile_pattern): Move decl from here ...
1573 * lisp.h: ... to here, so that it can be checked.
1574 (struct re_registers): New forward decl.
1576 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1578 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1580 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1581 Rename locals to avoid shadowing.
1582 (Fvertical_motion): Mark locals as initialized.
1584 * casefiddle.c (casify_object, casify_region): Now static.
1585 (casify_region): Mark local as initialized.
1587 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1589 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1590 New macros, so that the caller can use some names other than
1591 gcpro1, gcpro2, etc.
1592 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1594 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1595 argument, for consistency with GCPRO2_VAR, etc: it is now the
1596 prefix of the variable, not the variable itself. All uses
1598 * dired.c (directory_files_internal, file_name_completion):
1599 Rename locals to avoid shadowing.
1601 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1602 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1603 dired.c's scmp function, had undefined behavior.
1604 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1605 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1606 * buffer.h: ... to here, because these macros use current_buffer,
1607 and the new implementation with inline functions needs to have
1608 current_buffer in scope now, rather than later when the macros
1610 (downcase, upcase1): New static inline functions.
1611 (DOWNCASE, UPCASE1): Reimplement using these functions.
1612 This avoids undefined behavior in expressions like
1613 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1614 from race conditions in accessing the global variables
1615 case_temp1 and case_temp2.
1616 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1617 * lisp.h (case_temp1, case_temp2): Remove their decls.
1618 * character.h (ASCII_CHAR_P): Move from here ...
1619 * lisp.h: ... to here, so that the inline functions mentioned
1622 * dired.c (directory_files_internal_unwind): Now static.
1624 * fileio.c (file_name_as_directory, directory_file_name):
1625 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1627 (file_name_as_directory): Use const pointers when appropriate.
1628 (Fexpand_file_name): Likewise. In particular, newdir might
1629 point at constant storage, so make it a const pointer.
1630 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
1631 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1633 (Fset_file_times, Finsert_file_contents, auto_save_error):
1634 Rename locals to avoid shadowing.
1636 * minibuf.c (choose_minibuf_frame_1): Now static.
1637 (Ftry_completion, Fall_completions): Rename or remove locals
1640 * marker.c (bytepos_to_charpos): Remove; unused.
1642 * lisp.h (verify_bytepos, count_markers): New decls,
1643 so that gcc does not warn that these functions aren't declared.
1645 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1646 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
1647 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
1648 (copy_text): Remove unused local var.
1650 * filelock.c (within_one_second): Now static.
1651 (lock_file_1): Rename local to avoid shadowing.
1653 * buffer.c (fix_overlays_before): Mark locals as initialized.
1654 (fix_start_end_in_overlays): Likewise. This function should be
1655 simplified by using pointers-to-pointers, but that's a different
1657 (switch_to_buffer_1): Now static.
1658 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1659 (report_overlay_modification): Rename locals to avoid shadowing.
1661 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
1662 Fix pointer signedness issue.
1663 (sys_subshell): Mark local as volatile if checking for lint,
1664 to suppress a gcc -Wclobbered warning that does not seem to be right.
1665 (MAXPATHLEN): Define only if needed.
1667 * process.c (serial_open, serial_configure): Move decls from here ...
1668 * systty.h: ... to here, so that they can be checked.
1670 * fns.c (get_random, seed_random): Move extern decls from here ...
1671 * lisp.h: ... to here, so that they can be checked.
1673 * sysdep.c (reset_io): Now static.
1674 (wait_for_termination_signal): Remove; unused.
1676 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1677 (copy_keymap_item, append_key, push_text_char_description):
1679 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
1680 (DENSE_TABLE_SIZE): Remove; unused.
1681 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1682 (describe_map_tree):
1683 Rename locals to avoid shadowing.
1685 * keyboard.c: Declare functions static if they are not used elsewhere.
1686 (echo_char, echo_dash, cmd_error, top_level_2):
1687 (poll_for_input, handle_async_input): Now static.
1688 (read_char, kbd_buffer_get_event, make_lispy_position):
1689 (make_lispy_event, make_lispy_movement, apply_modifiers):
1690 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1691 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1692 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
1693 (read_key_sequence, read_char): Mark locals as initialized.
1694 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
1696 * keyboard.h (make_ctrl_char): New decl.
1697 (mark_kboards): Move decl here ...
1698 * alloc.c (mark_kboards): ... from here.
1700 * lisp.h (force_auto_save_soon): New decl.
1702 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
1703 (DEFINE_DUMMY_FUNCTION): New macro.
1704 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1706 (main): Add casts to avoid warnings
1707 if GCC considers string literals to be constants.
1709 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1711 * dbusbind.c: Pointer signedness fixes.
1712 (xd_signature, xd_append_arg, xd_initialize):
1713 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1714 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1715 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1716 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1718 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1719 if GCC considers string literals to be constants.
1720 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
1722 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1724 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1725 (print_preprocess, print_object): New macro to fix last change.
1727 * print.c (print_preprocess): Don't forget font objects.
1729 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
1731 * emacs.c (USAGE3): Doc fixes.
1733 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1735 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1738 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
1740 * lisp.h (VWindow_system, Qfile_name_history):
1741 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1742 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1743 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1745 * w32select.c: Don't #include "keyboard.h".
1746 (run_protected): Add extern declaration for waiting_for_input.
1748 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1749 * w32console.c (detect_input_pending, read_input_pending)
1750 (encode_terminal_code):
1751 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1752 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1753 (w32_system_caret_y, Qfile_name_history):
1754 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1755 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1756 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1757 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1758 * w32proc.c (Qlocal, report_file_error):
1759 * w32term.c (Vwindow_system, updating_frame):
1760 * w32uniscribe.c (initialized, uniscribe_font_driver):
1761 Remove unneeded extern declarations.
1763 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
1765 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
1767 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
1769 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1770 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1771 These macros can no longer be used for assignment.
1773 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1774 Assign struct members directly, instead of using BUF_BEGV etc.
1775 (record_buffer_markers, fetch_buffer_markers): New functions for
1776 recording and fetching special buffer markers.
1777 (set_buffer_internal_1, set_buffer_temp): Use them.
1779 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1781 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1783 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1784 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1786 * xdisp.c (hscroll_window_tree):
1787 (reconsider_clip_changes): Use PT instead of BUF_PT.
1789 2011-03-13 Eli Zaretskii <eliz@gnu.org>
1791 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1792 $(EMACS_ROOT)/lib/intprops.h.
1794 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1796 Fix more problems found by GCC 4.5.2's static checks.
1798 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1799 to unsigned char * to avoid compiler diagnostic.
1800 (xg_free_frame_widgets): Make it clear that a local variable is
1801 needed only if USE_GTK_TOOLTIP.
1802 (gdk_window_get_screen): Make it clear that this macro is needed
1803 only if USE_GTK_TOOLTIP.
1804 (int_gtk_range_get_value): New function, which avoids a diagnostic
1805 from gcc -Wbad-function-cast.
1806 (xg_set_toolkit_scroll_bar_thumb): Use it.
1807 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1808 diagnostic from gcc -Wbad-function-cast.
1809 (get_utf8_string, xg_get_file_with_chooser):
1810 Rename locals to avoid shadowing.
1811 (create_dialog): Move locals to avoid shadowing.
1813 * xgselect.c (xg_select): Remove unused var.
1815 * image.c (four_corners_best): Mark locals as initialized.
1816 (gif_load): Initialize transparent_p to zero (Bug#8238).
1817 Mark another local as initialized.
1818 (my_png_error, my_error_exit): Mark with NO_RETURN.
1820 * image.c (clear_image_cache): Now static.
1821 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
1822 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
1823 (x_edge_detection): Remove unnecessary cast that
1824 gcc -Wbad-function-cast diagnoses.
1825 (gif_load): Fix pointer signedness.
1826 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1827 (jpeg_load, gif_load): Rename locals to avoid shadowing.
1829 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
1831 Improve quality of tests for time stamp overflow.
1832 For example, without this patch (encode-time 0 0 0 1 1
1833 1152921504606846976) returns the obviously-bogus value (-948597
1834 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1835 reports time overflow. See
1836 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
1837 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1838 * editfns.c: Include limits.h and intprops.h.
1839 (TIME_T_MIN, TIME_T_MAX): New macros.
1840 (time_overflow): Move earlier, to before first use.
1841 (hi_time, lo_time): New functions, for an accurate test for
1843 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1844 (Fget_internal_run_time): Don't assume time_t fits in int.
1845 (make_time): Use list2 instead of Fcons twice.
1846 (Fdecode_time): More accurate test for out-of-range times.
1847 (check_tm_member): New function.
1848 (Fencode_time): Use it, to test for out-of-range times.
1849 (lisp_time_argument): Don't rely on undefined left-shift and
1850 right-shift behavior when checking for time stamp overflow.
1852 * editfns.c (time_overflow): New function, refactoring common code.
1853 (Fformat_time_string, Fdecode_time, Fencode_time):
1854 (Fcurrent_time_string): Use it.
1856 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1857 * dired.c (make_time): Move to ...
1858 * editfns.c (make_time): ... here.
1859 * systime.h: Note the move.
1861 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1863 * fringe.c (update_window_fringes): Remove unused variables.
1865 * unexmacosx.c (copy_data_segment): Also copy __got section.
1868 2011-03-12 Eli Zaretskii <eliz@gnu.org>
1870 * termcap.c [MSDOS]: Include "msdos.h".
1871 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1872 Constify `char *' arguments and their references according to
1873 prototypes in tparam.h.
1875 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
1877 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1878 Adapt all references accordingly.
1880 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1882 2011-03-11 Tom Tromey <tromey@redhat.com>
1884 * buffer.c (syms_of_buffer): Remove obsolete comment.
1886 2011-03-11 Eli Zaretskii <eliz@gnu.org>
1888 * termhooks.h (encode_terminal_code): Declare prototype.
1890 * msdos.c (encode_terminal_code): Don't declare prototype.
1892 * term.c (encode_terminal_code): Now external again, used by
1893 w32console.c and msdos.c.
1895 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1896 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
1898 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
1900 Fix some minor problems found by GCC 4.5.2's static checks.
1902 * fringe.c (update_window_fringes): Mark locals as initialized
1904 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
1906 * alloc.c (mark_fringe_data): Move decl from here ...
1907 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1908 to check its interface.
1909 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1911 * fontset.c (free_realized_fontset): Now static.
1912 (Fset_fontset_font): Rename local to avoid shadowing.
1913 (fontset_font): Mark local as initialized.
1914 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
1916 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1918 * xselect.c (x_disown_buffer_selections): Remove; not used.
1919 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
1920 (x_own_selection, Fx_disown_selection_internal): Rename locals
1922 (x_handle_dnd_message): Remove local to avoid shadowing.
1924 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1925 so that the caller can use some name other than gcpro1.
1926 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
1927 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1928 (Fx_backspace_delete_keys_p):
1929 Use them to avoid shadowing, and rename vars to avoid shadowing.
1930 (x_decode_color, x_set_name, x_window): Now static.
1931 (Fx_create_frame): Add braces to silence GCC warning.
1932 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
1933 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1934 Remove unused locals.
1935 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1936 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1937 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1940 * xterm.h (x_mouse_leave): New decl.
1942 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
1943 Remove unused functions.
1944 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
1945 (x_calc_absolute_position): Now static.
1946 (XTread_socket): Don't define label "out" unless it's used.
1947 Don't declare local "event" unless it's used.
1948 (x_iconify_frame, x_free_frame_resources): Don't declare locals
1949 unless they are used.
1950 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
1951 (x_fatal_error_signal): Remove; not used.
1952 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
1953 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
1954 (x_error_catcher, x_connection_closed, x_error_handler):
1955 (x_error_quitter, xembed_send_message, x_iconify_frame):
1956 (my_log_handler): Rename locals to avoid shadowing.
1957 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
1958 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
1960 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
1961 Rename or move locals to avoid shadowing.
1962 (tty_defined_color, merge_face_heights): Now static.
1963 (free_realized_faces_for_fontset): Remove; not used.
1964 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
1965 does not deduce is never used uninitialized.
1966 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
1967 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
1969 * terminal.c (store_terminal_param): Now static.
1971 * xmenu.c (menu_highlight_callback): Now static.
1972 (set_frame_menubar): Remove unused local.
1973 (xmenu_show): Rename parameter to avoid shadowing.
1974 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
1975 since they might point to immutable storage.
1976 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
1977 since it's unused otherwise.
1979 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
1980 Add a FIXME, since the code still doesn't look right. (Bug#8215)
1981 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
1982 avoids a gcc -Wuninitialized diagnostic.
1983 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
1984 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
1985 does not deduce are never used uninitialized.
1987 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
1989 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
1990 * window.c (window_loop, size_window):
1991 (run_window_configuration_change_hook, enlarge_window): Likewise.
1993 * window.c (display_buffer): Now static.
1994 (size_window): Mark variables that gcc -Wuninitialized
1995 does not deduce are never used uninitialized.
1996 * window.h (check_all_windows): New decl, to forestall
1997 gcc -Wmissing-prototypes diagnostic.
1998 * dispextern.h (bidi_dump_cached_states): Likewise.
2000 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2002 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
2004 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2005 and to avoid gcc -Wuninitialized warning.
2006 (load_charset_map): Mark variables that gcc -Wuninitialized
2007 does not deduce are never used uninitialized.
2008 (load_charset): Abort instead of using uninitialized var (Bug#8229).
2010 * coding.c (coding_set_source, coding_set_destination):
2011 Use "else { /* comment */ }" rather than "else /* comment */;"
2012 for clarity, and to avoid gcc -Wempty-body warning.
2013 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2014 a block, when the outer 'i' will do.
2015 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2016 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2017 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2018 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2019 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2020 Rename locals to avoid shadowing.
2021 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
2022 * coding.c (emacs_mule_char, encode_invocation_designation):
2023 Now static, since they're not used elsewhere.
2024 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
2025 (decode_coding_object, encode_coding_object, detect_coding_system):
2026 (decode_coding_emacs_mule): Mark variables that gcc
2027 -Wuninitialized does not deduce are never used uninitialized.
2028 (detect_coding_iso_2022): Initialize a local variable that might
2029 be used uninitialized. Leave a FIXME because it's not clear that
2030 this initialization is needed. (Bug#8211)
2031 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2032 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2033 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2034 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2035 Remove unused macros.
2037 * category.c (hash_get_category_set): Remove unused local var.
2038 (copy_category_table): Now static, since it's not used elsewhere.
2039 * character.c (string_count_byte8): Likewise.
2041 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2042 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2044 * chartab.c (copy_sub_char_table): Now static, since it's not used
2046 (sub_char_table_ref_and_range, char_table_ref_and_range):
2047 Rename locals to avoid shadowing.
2048 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
2050 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
2051 (BIDI_BOB): Remove unused macro.
2053 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2054 deduce are never used uninitialized.
2055 * term.c (encode_terminal_code): Likewise.
2057 * term.c (encode_terminal_code): Now static. Remove unused local.
2059 * tparam.h: New file.
2060 * term.c, tparam.h: Include it.
2061 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2062 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2063 Move these decls to tparam.h, and make them agree with what
2064 is actually in tparam.c. The previous trick of using incompatible
2065 decls in different modules does not conform to the C standard.
2066 All callers of tparam changed to use tparam's actual API.
2067 * tparam.c (tparam1, tparam, tgoto):
2068 Use const pointers where appropriate.
2070 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2071 * cm.h (struct cm): Likewise.
2072 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2073 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2074 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2075 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2076 (turn_on_face, init_tty): Likewise.
2077 * termchar.h (struct tty_display_info): Likewise.
2079 * term.c (term_mouse_position): Rename local to avoid shadowing.
2081 * alloc.c (mark_ttys): Move decl from here ...
2082 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2084 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2086 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2088 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
2090 * search.c (compile_pattern_1): Remove argument regp, unused since
2091 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2092 (compile_pattern): Don't pass it.
2094 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2096 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2097 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2099 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2101 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2103 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2104 gdk_window_get_screen, gdk_window_get_geometry,
2105 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2106 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2107 (xg_get_pixbuf_from_pixmap): New function.
2108 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2109 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2110 Call xg_get_pixbuf_from_pixmap instead of
2111 gdk_pixbuf_get_from_drawable.
2112 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2113 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2114 (xg_check_special_colors): Use GtkStyleContext and its functions
2116 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2117 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2118 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
2119 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2120 Call gtk_widget_get_preferred_size.
2121 (xg_frame_resized): gdk_window_get_geometry only takes 5
2123 (xg_win_to_widget, xg_event_is_for_menubar):
2124 Call gdk_x11_window_lookup_for_display.
2125 (xg_set_widget_bg): New function.
2126 (delete_cb): New function.
2127 (xg_create_frame_widgets): connect delete-event to delete_cb.
2128 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2129 (xg_set_background_color): Call xg_set_widget_bg.
2130 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2131 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2132 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2133 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2135 (update_frame_tool_bar): Call gtk_widget_hide.
2136 (xg_initialize): Use GDK_KEY_g.
2138 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2140 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2142 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2143 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2144 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2146 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
2148 * w32xfns.c (select_palette): Check success of RealizePalette against
2149 GDI_ERROR, not zero.
2151 See ChangeLog.11 for earlier changes.
2157 Copyright (C) 2011 Free Software Foundation, Inc.
2159 This file is part of GNU Emacs.
2161 GNU Emacs is free software: you can redistribute it and/or modify
2162 it under the terms of the GNU General Public License as published by
2163 the Free Software Foundation, either version 3 of the License, or
2164 (at your option) any later version.
2166 GNU Emacs is distributed in the hope that it will be useful,
2167 but WITHOUT ANY WARRANTY; without even the implied warranty of
2168 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2169 GNU General Public License for more details.
2171 You should have received a copy of the GNU General Public License
2172 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.