1 2011-10-29 Eli Zaretskii <eliz@gnu.org>
3 Fix the `xbytecode' command.
4 * .gdbinit (xprintbytestr): New command.
5 (xwhichsymbols): Renamed from `which'; all callers changed.
6 (xbytecode): Print the byte-code string as well.
8 * alloc.c (which_symbols): New function.
10 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
12 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
15 2011-10-29 Glenn Morris <rgm@gnu.org>
17 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
18 Not clear what it was for, and it causes various bugs. (Bug#9839)
20 2011-10-28 Eli Zaretskii <eliz@gnu.org>
22 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
23 possible random value that matches one of those tested as
24 condition to clear the mouse face.
26 2011-10-28 Chong Yidong <cyd@gnu.org>
28 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
30 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
32 * window.c (make_window): Initialize phys_cursor_on_p.
34 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
36 * lisp.h (struct Lisp_Symbol): Update comments.
38 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
40 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
42 2011-10-28 Eli Zaretskii <eliz@gnu.org>
44 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
45 <oslsachem@gmail.com> for helping to debug this.
47 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
48 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
49 (g_b_init_get_glyph_outline_w): New static variables.
50 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
51 (GetGlyphOutlineW_Proc): New typedefs.
52 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
53 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
55 (w32font_open_internal, compute_metrics):
56 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
57 instead of calling the "wide" APIs directly.
59 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
61 * w32.h (syms_of_w32font): Add prototype.
63 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
65 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
66 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
67 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
68 (Fmove_to_window_line): Doc fix.
70 2011-10-27 Chong Yidong <cyd@gnu.org>
72 * process.c (make_process): Set gnutls_state to NULL.
74 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
75 non-NULL, regardless of GNUTLS_INITSTAGE.
76 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
77 an error. Set process slots as soon as we allocate them.
79 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
81 2011-10-27 Chong Yidong <cyd@gnu.org>
83 * gnutls.c (emacs_gnutls_deinit): New function.
84 Deallocate credentials structures as well as calling gnutls_deinit.
85 (Fgnutls_deinit, Fgnutls_boot): Use it.
87 * process.c (make_process): Initialize GnuTLS credentials to NULL.
88 (deactivate_process): Call emacs_gnutls_deinit.
90 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
92 * image.c (x_create_x_image_and_pixmap):
93 * w32.c (sys_rename, w32_delayed_load):
94 * w32font.c (fill_in_logfont):
95 * w32reg.c (x_get_string_resource): Silence compiler warnings.
97 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
99 * w32fns.c (w32_default_color_map): New function,
100 extracted from Fw32_default_color_map.
101 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
103 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
105 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
107 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
109 * keyboard.c (test_undefined): New function (bug#9751).
110 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
112 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
114 * sysdep.c (init_sys_modes): Fix the check for the controlling
117 2011-10-20 Eli Zaretskii <eliz@gnu.org>
119 * dispextern.h (struct bidi_it): New member next_en_type.
121 * bidi.c (bidi_line_init): Initialize the next_en_type member.
122 (bidi_resolve_explicit_1): When next_en_pos is valid for the
123 current character, check also for next_en_type being WEAK_EN.
124 (bidi_resolve_weak): Don't enter the expensive loop if the current
125 position is before next_en_pos. Record the bidi type of the first
126 non-ET, non-BN character we find, in addition to its position.
127 (bidi_level_of_next_char): Invalidate next_en_type when
128 next_en_pos is over-stepped.
130 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
132 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
133 * editfns.c: Rewrite current-time-zone so that it invokes
134 the equivalent of (format-time-string "%Z") to get the time zone name.
135 This fixes a bug when the time zone name contains characters that
136 need converting from the system time locale to Emacs internal format.
137 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
138 that patch fixed format-time-string to do the conversion, but
139 I forgot to fix current-time-zone.
140 (format_time_string): New function, containing most of
141 what Fformat_time_string used to contain.
142 (Fformat_time_string): Rewrite in terms of format_time_string.
143 This doesn't change this function's behavior.
144 (current-time-zone): Rewrite to use format_time_string.
145 This fixes the bug reported by Michael Schierl in
146 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
147 Jason Rumney's 2007-06-07 change worked around this bug, but
149 * systime.h (tzname, timezone): Remove no-longer-used declarations.
151 2011-10-19 Eli Zaretskii <eliz@gnu.org>
153 * xdisp.c (start_display): If the character at POS is displayed
154 via a display vector, reset IT->current.dpvec_index to zero.
155 (try_window_reusing_current_matrix): If a line ends in a display
156 vector or the next line starts in a display vector, continue
157 redrawing the window even though the character position of
158 start_row was reached.
161 2011-10-18 Chong Yidong <cyd@gnu.org>
163 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
164 with nobreak-char-display too.
166 2011-10-18 Eli Zaretskii <eliz@gnu.org>
168 Fix part 3 of bug#9771.
169 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
170 (bidi_resolve_neutral): Don't enter the expensive loop looking for
171 non-neutral characters if the current character is a paragraph
172 separator (a.k.a. Newline). This avoids running the same
173 expensive loop twice, once when we consume the preceding newline
174 and the other time when the line actually needs to be displayed.
175 Avoid the loop when we see neutrals on the base embedding level
176 following a character whose directionality is the same as the
177 paragraph's. This avoids running the expensive loop when a line
178 ends in a long sequence of neutrals, like control characters.
179 Add assertion against STRONG_AL type. Slightly rearrange code
180 that determines the type of a neutral given the first non-neutral
182 (bidi_level_of_next_char): Set next_en_pos to zero when
183 invalidating its info.
185 2011-10-17 Eli Zaretskii <eliz@gnu.org>
187 * xdisp.c (push_display_prop): Determine whether to record string
188 or buffer position by IT->string, not by IT->method. Allow
189 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
190 (move_it_vertically_backward): Don't look for character position
191 immediately after the newline when in a continuation line.
194 2011-10-15 Martin Rudalics <rudalics@gmx.at>
196 * window.c (coordinates_in_window): Rewrite and delabelize
197 vertical border check. (Bug#5357) (Bug#9618)
199 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
201 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
202 errors in XSetWindowBorder (bug#9310).
204 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
206 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
207 avoid crash when xmalloc overrun checking is enabled.
209 2011-10-13 Eli Zaretskii <eliz@gnu.org>
211 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
212 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
213 cursor motion with <left> and <right> arrow keys.
215 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
216 some callers set that themselves.
218 2011-10-12 Eli Zaretskii <eliz@gnu.org>
220 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
221 display string and the previous row comes from the same string and
222 is empty. (Bug#9739) (Bug#9738)
224 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
226 * doc.c (get_doc_string): Encode file name (bug#9735).
228 2011-10-12 Eli Zaretskii <eliz@gnu.org>
230 * bidi.c (bidi_level_of_next_char):
231 * xdisp.c (get_visually_first_element): Remove old incorrect
232 comments regarding the Unicode Line Separator character.
234 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
236 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
238 * alloc.c (Fgc_status): Do not access beyond zombies array
239 boundary if nzombies > MAX_ZOMBIES.
240 * alloc.c (dump_zombies): Add missing format specifier.
242 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
244 * xdisp.c (set_cursor_from_row): Simplify conditionals,
245 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
247 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
248 Some packages use them to denote characters with modifiers.
250 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
252 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
253 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
254 matching a pp-number. Rename parameter var to var1.
256 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
258 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
260 2011-10-08 Glenn Morris <rgm@gnu.org>
262 * callint.c (Fcall_interactively): Give a more explicit error for the
263 'c' case with a non-character input. (Bug#8479)
265 2011-10-08 Eli Zaretskii <eliz@gnu.org>
267 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
269 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
270 lines that are hscrolled on the left.
272 * dispnew.c (buffer_posn_from_coords): Account for a possible
273 presence of header-line. (Bug#4426)
275 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
277 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
278 Don't advertise functionality which we discourage or doesn't work.
280 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
282 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
283 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
284 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
285 this makes Emacs dump core during garbage collection on rare
286 occasions. sizeof is obviously inferior to offsetof here, so
288 (GC_POINTER_ALIGNMENT): New macro.
289 (mark_memory): Omit 3rd (offset) arg; caller changed.
290 Don't assume EMACS_INT alignment is the same as pointer alignment.
292 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
294 * keyboard.c (read_key_sequence_remapped): New var.
295 (read_key_sequence): Compute remapping in the right buffer.
296 (command_loop_1): Use read_key_sequence's remapping directly.
298 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
300 * dired.c (file_name_completion): Don't expand file name.
301 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
302 before checking file name handler.
304 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
305 they've been requested explicitly (bug#9591).
307 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
309 * keymap.c (Fsingle_key_description): Use make_specified_string
310 instead of build_string to build string from push_key_description.
313 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
315 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
316 This fixes a Y2038 bug on 64-bit hosts.
317 * buffer.c (reset_buffer):
318 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
319 (Fclear_buffer_auto_save_failure):
320 Use 0, not -1, to represent an unset failure time, since time_t
323 Remove dependency on glibc malloc internals.
324 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
325 Move back here from lisp.h, but with their new implementations.
326 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
327 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
328 * charset.c (charset_table_init): New static var.
329 (syms_of_charset): Use it instead of xmalloc. This removes a
330 dependency on glibc malloc internals. See Eli Zaretskii's comment in
331 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
332 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
333 Move back to alloc.c.
334 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
335 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
337 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
339 * nsterm.m (windowDidResize): Call x_set_window_size only when
340 ns_in_resize is true. Otherwise set pixelwidth/height and
341 call change_frame_size (Bug#9628).
343 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
345 Port --enable-checking=all to Fedora 14 x86-64.
346 * charset.c (syms_of_charset): Also account for glibc malloc's
347 internal overhead when calculating the initial malloc maximum.
349 Port --enable-checking=all to Fedora 14 x86.
350 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
352 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
353 (overrun_check_realloc, overrun_check_free):
354 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
355 That way, xmalloc returns a properly-aligned pointer even if
356 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
357 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
358 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
359 into account when calculating the initial malloc maximum.
360 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
361 Move here from alloc.c, so that charset.c can use it too.
362 Properly align; the old code wasn't right for common 32-bit hosts
363 when configured with --enable-checking=all.
364 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
365 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
367 2011-09-29 Eli Zaretskii <eliz@gnu.org>
369 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
372 2011-09-28 Eli Zaretskii <eliz@gnu.org>
374 * xdisp.c (compute_display_string_end): If there's no display
375 string at CHARPOS, return -1.
377 * bidi.c (bidi_fetch_char): When compute_display_string_end
378 returns a negative value, treat the character as a normal
379 character not covered by a display string. (Bug#9624)
381 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
383 * lread.c (Fread_from_string): Fix typo in docstring.
385 2011-09-27 Eli Zaretskii <eliz@gnu.org>
387 * xdisp.c (handle_invisible_prop): If invisible text ends on a
388 newline, reseat the iterator instead of bidi-iterating there one
389 character at a time. (Bug#9610)
390 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
391 TO_CHARPOS if the bidi iterator is at base embedding level.
393 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
395 * lread.c (readevalloop): Use correct code for NBSP.
396 (read1): Likewise. (Bug#9608)
398 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
400 * dbusbind.c (Fdbus_register_signal): When service is not
401 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
403 2011-09-25 Glenn Morris <rgm@gnu.org>
405 * buffer.c (truncate-lines): Doc fix.
407 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
409 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
410 (Fset_window_next_buffers): Doc fix.
412 2011-09-24 Glenn Morris <rgm@gnu.org>
414 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
416 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
418 Fix minor problems found by static checking.
419 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
420 * indent.c (Fvertical_motion): Fix == vs = typo.
422 2011-09-24 Eli Zaretskii <eliz@gnu.org>
424 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
425 Default value is now t. Doc fix.
427 * indent.c (Fvertical_motion): Compute and apply the overshoot
428 logic when moving up, not only when moving down. Fix the
429 confusing name and values of the it_overshoot_expected variable;
430 logic changes accordingly. (Bug#9254) (Bug#9549)
432 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
433 CHARPOS is covered by a display string which includes newlines.
434 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
435 is covered by a display string with embedded newlines.
437 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
439 * dbusbind.c (Fdbus_register_signal): Add match rule to
440 Vdbus_registered_objects_table. (Bug#9581)
441 (Fdbus_register_method, Vdbus_registered_objects_table):
444 2011-09-24 Jim Meyering <meyering@redhat.com>
446 do not ignore write error for any output size
447 The previous change was incomplete.
448 While it makes emacs --batch detect the vast majority of stdout
449 write failures, errors were still ignored whenever the output size is
450 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
451 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
452 && echo FAIL: ignored write error
453 FAIL: ignored write error
454 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
455 && echo FAIL: ignored write error
456 FAIL: ignored write error
457 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
459 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
461 * emacs.c (Fkill_emacs): In noninteractive mode exit
462 non-successfully if a write error occurred on stdout. (Bug#9574)
464 2011-09-21 Eli Zaretskii <eliz@gnu.org>
466 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
469 * dispextern.h (struct it): Update the comment documenting what
472 2011-09-20 Eli Zaretskii <eliz@gnu.org>
474 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
475 a display string, extend search for cursor position to end of row.
476 (find_row_edges): If the row ends in a newline from a display
477 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
478 Handle the case of a display string with multiple newlines.
479 (Fcurrent_bidi_paragraph_direction): Fix search for previous
480 non-empty line. Fixes confusing cursor motion with arrow keys at
481 the beginning of a line that starts with whitespace.
483 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
485 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
488 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
490 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
493 2011-09-18 Eli Zaretskii <eliz@gnu.org>
495 * xdisp.c (display_line): Record maximum and minimum buffer
496 positions even if no glyphs were produced (e.g., by a zero-width
497 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
498 buffer positions that will be removed from the glyph row because
500 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
501 column is beyond frame width: don't subtract 1 "pixel" when
502 computing width of the stretch.
503 (reseat_at_next_visible_line_start): Undo the change made on
504 2011-09-17 that saved paragraph information and restored it after
505 the call to `reseat'. (Bug#9545)
507 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
509 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
510 and turn window cursor on if cleared (Bug#9415).
512 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
514 * search.c (boyer_moore): Take unibyte characters from pattern
515 literally. (Bug#9458)
517 2011-09-18 Eli Zaretskii <eliz@gnu.org>
519 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
521 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
523 Fix minor problem found by static checking.
524 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
525 initialized, to pacify gcc -Wuninitialized.
527 * fileio.c: Report proper errno when syscall falls.
528 (Finsert_file_contents): Save and restore errno,
529 so that report_file_error outputs the correct diagnostic.
530 (Fwrite_region) [CLASH_DETECTION]: Likewise.
532 2011-09-18 Eli Zaretskii <eliz@gnu.org>
534 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
536 2011-09-17 Eli Zaretskii <eliz@gnu.org>
538 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
539 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
541 2011-09-17 Eli Zaretskii <eliz@gnu.org>
543 * xdisp.c (reseat_at_next_visible_line_start): Keep information
544 about the current paragraph and restore it after the call to reseat.
546 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
547 (bidi_find_paragraph_start): Search back for paragraph beginning
548 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
549 (bidi_move_to_visually_next): Only trigger paragraph-related
550 computations when the last character is a newline or at EOB, not
551 just any NEUTRAL_B. (Bug#9470)
553 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
554 truncated lines if point is covered by a display string. (Bug#9524)
556 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
558 * xselect.c: Relax test for outgoing X longs (Bug#9498).
559 (cons_to_x_long): New function.
560 (lisp_data_to_selection_data): Use it. Correct the test for
561 short-versus-long data; it was negated. Break out of vector
562 loop, for efficiency, when a long datum is discovered.
564 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
566 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
568 2011-09-16 Eli Zaretskii <eliz@gnu.org>
570 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
571 GCC PR/17406) by declaring this function with external scope.
573 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
575 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
576 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
578 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
580 * editfns.c (Fformat): Correctly handle text properties on "%%".
582 2011-09-15 Eli Zaretskii <eliz@gnu.org>
584 * xterm.c (x_draw_composite_glyph_string_foreground):
585 * w32term.c (x_draw_composite_glyph_string_foreground):
586 * term.c (encode_terminal_code):
587 * composite.c (composition_update_it, get_composition_id):
588 * xdisp.c (get_next_display_element)
589 (fill_composite_glyph_string): Add comments about special meaning
590 of TAB characters in a composition.
592 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
594 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
595 This occurs when processing a multibyte format.
596 Problem reported by Wolfgang Jenker.
598 2011-09-15 Johan Bockgård <bojohan@gnu.org>
600 * xdisp.c (try_cursor_movement): Only check for exact match if
601 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
603 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
605 Remove unused external symbols.
606 * dispextern.h (calc_pixel_width_or_height): Remove decl.
607 * xdisp.c (calc_pixel_width_or_height): Now static.
608 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
609 * indent.c (check_display_width):
610 * w32term.c: Fix comment to match code.
611 * xterm.c, xterm.h (x_catching_errors): Remove.
613 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
615 * xselect.c: Use signed conversions more consistently (Bug#9498).
616 (selection_data_to_lisp_data): Assume incoming selection data are
617 signed integers, not unsigned. This is to be consistent with
618 outgoing selection data, which was modified to use signed integers
619 in as part of the fix to Bug#9196 in response to Jan D.'s comment
620 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
621 expects long, not unsigned long.
623 2011-09-14 Eli Zaretskii <eliz@gnu.org>
625 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
626 computation of loop end. Reported by Johan Bockgård
629 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
631 * frame.c (Fother_visible_frames_p): Function deleted.
633 2011-09-12 Eli Zaretskii <eliz@gnu.org>
635 * indent.c (compute_motion): Process display vector front to back
636 rather than the other way around. (Bug#2496)
638 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
640 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
642 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
644 * minibuf.c (Fread_from_minibuffer): Doc fix.
646 2011-09-11 Eli Zaretskii <eliz@gnu.org>
648 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
649 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
651 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
653 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
654 value for non-existent files.
656 2011-09-11 Eli Zaretskii <eliz@gnu.org>
658 * fileio.c (Finsert_file_contents): If the file cannot be opened,
659 set its "size" to -1. This will set the modtime_size field of
660 the corresponding buffer to -1, which is what
661 verify-visited-file-modtime expects for files that do not exist.
664 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
666 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
668 * lisp.h: ... from here. push_key_description is no longer
669 defined in keyboard.c, so its declaration should not be in
670 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
671 logically belongs with push_key_description.
673 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
675 * buffer.h: Include <sys/types.h> instead of <time.h>.
676 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
677 Problem reported by Herbert J. Skuhra.
679 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
681 * xml.c (parse_region): Make the parsing work for
682 non-comment-starting XML files again (bug#9144).
684 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
686 * image.c (gif_load): Fix calculation of bottom and right corner.
689 2011-09-10 Eli Zaretskii <eliz@gnu.org>
691 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
692 redisplay in small windows.
694 2011-09-09 Eli Zaretskii <eliz@gnu.org>
696 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
698 2011-09-08 Martin Rudalics <rudalics@gmx.at>
700 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
701 Operate on live windows only.
703 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
705 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
707 2011-09-07 Eli Zaretskii <eliz@gnu.org>
709 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
710 only under bidi iteration.
712 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
714 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
716 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
718 isnan: Fix porting problem to Solaris 10 with bundled gcc.
719 Without this fix, the command to link temacs failed due to an
720 undefined symbol __builtin_isnan. This is because
721 /usr/include/iso/math_c99.h #defines isnan(x) to
722 __builtin_isnan(x), but the bundled gcc, which identifies itself
723 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
725 * floatfns.c (isnan): #undef, and then #define to a clone of
727 (Fisnan): Always define, since it's always available now.
728 (syms_of_floatfns): Always define isnan at the Lisp level.
730 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
732 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
734 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
736 * fileio.c: Fix bugs with large file offsets (Bug#9428).
737 The previous code assumed that file offsets (off_t values) fit in
738 EMACS_INT variables, which is not true on typical 32-bit hosts.
739 The code messed up by falsely reporting buffer overflow in cases
740 such as (insert-file-contents "big" nil 1 2) into an empty buffer
741 when "big" contains more than 2**29 bytes, even though this
742 inserts just one byte and does not overflow the buffer.
743 (Finsert_file_contents): Store file offsets as off_t
744 values, not as EMACS_INT values. Check for overflow when
745 converting between EMACS_INT and off_t. When checking for
746 buffer overflow or for overlap, take the offsets into account.
747 Don't use EMACS_INT for small values where int suffices.
748 When checking for overlap, fix a typo: ZV was used where
749 ZV_BYTE was intended.
750 (Fwrite_region): Don't assume off_t fits into 'long'.
751 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
753 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
755 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
757 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
759 sprintf-related integer and memory overflow issues (Bug#9412).
761 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
762 (esprintf, exprintf, evxprintf): New functions.
763 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
764 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
765 (modify_event_symbol): Do not assume that the length of
766 name_alist_or_stem is safe to alloca and fits in int.
767 (Fexecute_extended_command): Likewise for function name and binding.
768 (Frecursion_depth): Wrap around reliably on integer overflow.
769 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
770 since some callers pass EMACS_INT values.
771 (Fsingle_key_description): Don't crash if symbol name contains more
772 than MAX_ALLOCA bytes.
773 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
774 (get_minibuffer): Arg is now EMACS_INT, not int.
775 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
776 (esprintf, exprintf, evxprintf): New decls.
777 * window.h (command_loop_level, minibuf_level): Reflect API changes.
779 * dbusbind.c (signature_cat): New function.
780 (xd_signature, Fdbus_register_signal):
781 Do not overrun buffer; instead, report string overflow.
783 * dispnew.c (add_window_display_history): Don't overrun buffer.
784 Truncate instead; this is OK since it's just a log.
786 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
787 even if the time zone offset is outlandishly large.
788 Don't mishandle offset == INT_MIN.
790 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
791 when creating daemon; the previous buffer-overflow check was incorrect.
793 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
794 which has the guts of the old verror function.
796 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
797 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
799 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
800 (font_unparse_xlfd): Don't blindly alloca long strings.
801 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
802 fits in int, when using sprintf. Use single snprintf to count
803 length of string rather than counting it via multiple sprintfs;
804 that's simpler and more reliable.
805 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
806 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
807 sprintf, in case result does not fit in int.
809 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
810 (fontset_from_font): Print it.
812 * frame.c (tty_frame_count): Now printmax_t, not int.
813 (make_terminal_frame, set_term_frame_name): Print it.
814 (x_report_frame_params): In X, window IDs are unsigned long,
815 not signed long, so print them as unsigned.
816 (validate_x_resource_name): Check for implausibly long names,
817 and don't assume name length fits in 'int'.
818 (x_get_resource_string): Don't blindly alloca invocation name;
819 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
822 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
823 (xg_check_special_colors, xg_set_geometry):
824 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
826 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
827 Use esprintf, not sprintf, in case result does not fit in int.
829 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
830 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
831 it as a large positive number.
832 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
833 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
835 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
836 in case result does not fit in int.
838 * print.c (float_to_string): Detect width overflow more reliably.
839 (print_object): Make sprintf buffer a bit bigger, to avoid potential
840 buffer overrun. Don't assume list length fits in 'int'. Treat
841 print length of 0 as 0, not as infinity; to be consistent with other
842 uses of print length in this function. Don't overflow print length
843 index. Don't assume hash table size fits in 'long', or that
844 vectorlike size fits in 'unsigned long'.
846 * process.c (make_process): Use printmax_t, not int, to format
847 process-name gensyms.
849 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
851 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
852 to avoid potential buffer overrun.
854 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
855 if X resource line is longer than 512 bytes.
857 * xfns.c (x_window): Make sprintf buffer a bit bigger
858 to avoid potential buffer overrun.
860 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
862 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
864 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
866 Integer overflow fixes for scrolling, etc.
867 Without these, Emacs silently mishandles large integers sometimes.
868 For example, "C-u 4294967297 M-x recenter" was treated as if
869 it were "C-u 1 M-x recenter" on a typical 64-bit host.
871 * xdisp.c (try_window_id): Check Emacs fixnum range before
874 * window.c (window_scroll_line_based, Frecenter):
875 Check that an Emacs fixnum is in range before assigning it to 'int'.
876 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
877 values converted from Emacs fixnums.
878 (Frecenter): Don't wrap around a line count if it is out of 'int'
879 range; instead, treat it as an extreme value.
880 (Fset_window_configuration, compare_window_configurations):
881 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
883 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
884 that can exceed INT_MAX. Check that EMACS_INT value is in range
885 before assigning it to the (possibly-narrower) index.
886 (match_limit): Don't assume that a fixnum can fit in 'int'.
888 * print.c (print_object): Use ptrdiff_t, not int, for index that can
891 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
892 (Fvertical_motion): Don't wrap around LINES values that don't fit
893 in 'int'. Instead, treat them as extreme values. This is good
894 enough for windows, which can't have more than INT_MAX lines anyway.
896 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
898 * Require libxml/parser.h to avoid compilation warning.
900 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
902 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
903 since this reportedly can destroy thread storage.
905 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
907 * syntax.c (find_defun_start): Update all cache variables if
908 exiting early (Bug#9401).
910 2011-08-30 Eli Zaretskii <eliz@gnu.org>
912 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
914 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
915 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
916 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
918 * term.c (tty_append_glyph): New function.
919 (produce_stretch_glyph): Static function and its prototype deleted.
921 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
924 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
926 * image.c (parse_image_spec): Check for nonnegative, not for positive,
927 when checking :margin (Bug#9390).
928 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
929 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
930 so that the name doesn't mislead. All uses changed.
932 2011-08-28 Johan Bockgård <bojohan@gnu.org>
934 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
937 2011-08-27 Eli Zaretskii <eliz@gnu.org>
939 * xdisp.c (move_it_to): Don't bail out early when reaching
940 position beyond to_charpos, if we are scanning backwards.
941 (move_it_vertically_backward): When DY == 0, make sure we get to
942 the first character in the line after the newline.
944 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
946 * ccl.c: Improve and simplify overflow checking (Bug#9196).
947 (ccl_driver): Do not generate an out-of-range pointer.
948 (Fccl_execute_on_string): Remove unnecessary check for
949 integer overflow, noted by Stefan Monnier in
950 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
951 Remove a FIXME that didn't need fixing.
952 Simplify the newly-introduced buffer reallocation code.
954 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
956 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
958 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
960 Integer and memory overflow issues (Bug#9196).
962 * doc.c (get_doc_string): Rework so that
963 get_doc_string_buffer_size is the actual buffer size, rather than
964 being 1 less than the actual buffer size; this makes xpalloc more
967 * image.c (x_allocate_bitmap_record, cache_image):
968 * xselect.c (Fx_register_dnd_atom):
969 Simplify previous changes by using xpalloc.
971 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
972 since either will do and ptrdiff_t is convenient with xpalloc.
974 * charset.c (charset_table_size)
975 (struct charset_sort_data.priority): Now ptrdiff_t.
976 (charset_compare): Don't overflow if priorities differ greatly.
977 (Fsort_charsets): Don't assume list length fits in int.
978 Check for size-calculation overflow when allocating sort data.
979 (syms_of_charset): Allocate an initial charset table that is
980 just under 64 KiB, to avoid problems with glibc malloc and mmap.
982 * cmds.c (internal_self_insert): Check for size-calculation overflow.
984 * composite.h (struct composition.glyph_len): Now int, not unsigned.
985 The actual value is always <= INT_MAX, and leaving it unsigned made
986 overflow checking harder.
988 * dispextern.h (struct glyph_matrix.rows_allocated)
989 (struct face_cache.size): Now ptrdiff_t, for convenience in use
990 with xpalloc. The values are still always <= INT_MAX.
992 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
994 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
995 (SAFE_NALLOCA): New macro.
997 * region-cache.c (struct boundary.pos, find_cache_boundary)
998 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
999 (set_cache_region, invalidate_region_cache)
1000 (revalidate_region_cache, know_region_cache, region_cache_forward)
1001 (region_cache_backward, pp_cache):
1002 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1003 so that ptrdiff_t * can be passed to xpalloc.
1004 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1005 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1006 (pp_cache): Don't assume cache_len fits in int.
1007 * region-cache.h: Adjust extern decls to match.
1009 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1010 EMACS_INT, since either will do, for xpalloc.
1012 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1013 (xnmalloc, xnrealloc, xpalloc): New functions.
1015 * bidi.c (bidi_shelve_header_size): New constant.
1016 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1017 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1019 * bidi.c (bidi_cache_shrink):
1020 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1022 Don't update size of array until after memory allocation succeeds,
1023 because xmalloc/xrealloc may not return.
1024 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1025 now that we have proper integer overflow checking.
1026 (record_overlay_string, overlay_strings): Catch overflows when
1027 calculating size of overlay_str_buf.
1029 * callproc.c (Fcall_process): Check for size overflow when
1030 calculating size of args2.
1031 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1032 Normally we prefer signed values, but sticking with ptrdiff_t would
1033 require adding more-complicated checks.
1035 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1036 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1037 Redo buffer-overflow calculations to avoid integer overflow.
1038 Add a FIXME comment where memory seems to be over-allocated.
1040 * character.c (Fstring): Check for size-calculation overflow.
1042 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1043 unnecessary integer overflow. Check for size overflow.
1044 (encode_coding_object): Don't update size until xmalloc succeeds.
1046 * composite.c (get_composition_id): Check for overflow in glyph
1047 length calculations.
1049 Integer and memory overflow fixes for display code.
1050 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1051 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1052 (scrolling_window): Check for overflow in size calculations.
1053 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1054 Don't assume glyph table len fits in int.
1055 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1056 (row_table_size): Now ptrdiff_t, not int.
1057 (scrolling_window): Avoid overflow in size calculations.
1058 Don't update size until allocation succeeds.
1059 * fns.c (concat): Check for overflow in size calculations.
1060 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1061 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1062 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1064 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1065 (get_doc_string): Check for size calculation overflow.
1066 Don't update size until allocation succeeds.
1067 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1068 EMACS_INT, where ptrdiff_t will do.
1069 (Fsubstitute_command_keys): Check for string overflow.
1071 * editfns.c (set_time_zone_rule): Don't assume environment length
1073 (message_length): Now ptrdiff_t, not int.
1074 (Fmessage_box): Don't update size until allocation succeeds.
1075 Don't assume message length fits in int.
1076 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1078 * emacs.c (main): Do not reallocate argv, since there is a null at
1079 the end that can be overwritten, and this way there's no need to
1080 worry about size-calculation overflow.
1081 (sort_args): Check for size-calculation overflow.
1083 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1085 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1087 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1088 (x_set_scroll_bar_width, x_figure_window_size):
1089 Check for integer overflow.
1090 (x_set_alpha): Do not assume XINT fits in int.
1092 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1093 This is for the members text_lines, text_cols, total_lines, total_cols,
1094 where the system imposes an 'int' limit.
1096 * fringe.c (Fdefine_fringe_bitmap):
1097 Don't update size until alloc works.
1099 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1100 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1102 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1103 Check for size-calculation overflow.
1104 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1105 do, as we prefer signed integers.
1106 (id_to_widget.max_size, id_to_widget.used)
1107 (xg_store_widget_in_map, xg_remove_widget_from_map)
1108 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1109 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1110 Use and return ptrdiff_t, not int.
1111 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1112 * gtkutil.h: Change prototypes to match the above.
1114 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1115 are duplicate now that they've been promoted to lisp.h.
1116 (x_allocate_bitmap_record, x_alloc_image_color)
1117 (make_image_cache, cache_image, xpm_load):
1118 Don't update size until alloc is done.
1119 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1121 Check for size calculation overflow.
1122 (ct_colors_allocated_max): New constant.
1123 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1126 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1127 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1128 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1129 Use ptrdiff_t, not int, to count maps.
1130 (read_char_minibuf_menu_prompt): Check for overflow in size
1131 calculations. Don't update size until allocation succeeds.
1132 Redo calculations to avoid overflow.
1133 * keyboard.h: Change prototypes to match the above.
1135 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1137 (current_minor_maps): Check for size calculation overflow.
1138 * keymap.h: Change prototypes to match the above.
1140 * lread.c (read1, init_obarray): Don't update size until alloc done.
1142 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1143 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1145 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1146 Now ptrdiff_t, not int.
1147 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1148 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1150 * process.c (Fnetwork_interface_list): Check for overflow
1151 in size calculation.
1153 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1155 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1156 overflow. Don't bother calling xmalloc when xrealloc will do.
1158 * search.c (Freplace_match): Check for size calculation overflow.
1159 (Fset_match_data): Don't assume list lengths fit in 'int'.
1161 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1162 for command line length. Do not attempt to address one before the
1163 beginning of an array, as that's not portable.
1165 * term.c (max_frame_lines): Remove; unused.
1166 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1168 (encode_terminal_code, calculate_costs): Check for size
1169 calculation overflow.
1170 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1171 table lengths and related sizes. Don't update size until alloc
1172 done. Redo calculations to avoid overflow.
1173 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1175 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1176 subtracting pointers.
1177 (gobble_line): Check for overflow more carefully. Don't update size
1180 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1181 Don't update size until alloc done.
1182 Redo size calculations to avoid overflow.
1183 Check for size calculation overflow.
1184 (main) [DEBUG]: Fix typo in invoking tparam1.
1186 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1187 Use ptrdiff_t, not int, for sizes.
1188 (store_mode_line_noprop_char): Don't update size until alloc done.
1190 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1191 Use ptrdiff_t, not int, for sizes.
1192 (Finternal_make_lisp_face, cache_face):
1193 Check for size calculation overflow.
1194 (cache_face): Treat size calculation overflows as if they were
1195 memory exhaustion (the usual treatment), rather than aborting.
1197 * xfns.c (x_encode_text, x_set_name_internal)
1198 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1199 sizes, since they can exceed INT_MAX in size. Check for size
1200 calculation overflow.
1202 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1203 (xg_select): Check for size calculation overflow.
1204 Don't update size until alloc done.
1206 * xrdb.c (get_environ_db): Don't assume path length fits in int,
1207 as sprintf is limited to int lengths.
1209 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1210 (X_LONG_MIN): New macros.
1211 Use them to make the following changes clearer.
1212 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1213 This change doesn't affect the value now, but it may help remind
1214 future maintainers not to raise the value too much later.
1215 (SELECTION_QUANTUM): Remove, replacing with ...
1216 (selection_quantum): ... new function, which avoids overflow.
1218 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1219 assumption that selection length fits in 'int'.
1220 (x_reply_selection_request, x_handle_selection_request)
1221 (x_get_window_property, receive_incremental_selection)
1222 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1223 (lisp_data_to_selection_data, clean_local_selection_data):
1224 Use ptrdiff_t, not int, to record length of selection.
1225 (x_reply_selection_request, x_get_window_property)
1226 (receive_incremental_selection, x_property_data_to_lisp):
1227 Redo calculations to avoid overflow.
1228 (x_reply_selection_request): When sending hint, ceiling it at
1229 X_LONG_MAX rather than relying on wraparound overflow to send
1231 (x_get_window_property, receive_incremental_selection)
1232 (lisp_data_to_selection_data, x_property_data_to_lisp):
1233 Check for size-calculation overflow.
1234 (x_get_window_property, receive_incremental_selection)
1235 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1236 Don't store size until memory allocation succeeds.
1237 (x_get_window_property): Plug memory leak on memory exhaustion.
1238 Don't double-block input; malloc is safe here. Don't assume 2**34
1239 - 4 fits in unsigned long. Add an xassert to check
1240 XGetWindowProperty overflow. Be more careful about overflow
1241 calculations, and distinguish size from memory overflow better.
1242 (receive_incremental_selection): When tracing, don't assume
1243 unsigned int is less than INT_MAX.
1244 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1245 harmful) conversions of unsigned short to int.
1246 (lisp_data_to_selection_data): Don't assume that integers
1247 in the range -65535 through -1 fit in an X unsigned short.
1248 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1249 result parameters unless successful. Rely on cons_to_unsigned
1250 to report problems with elements; the old code wasn't right anyway.
1251 (x_check_property_data): Check for int overflow; we cannot use
1252 a wider type due to X limits.
1253 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1255 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
1257 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1258 (x_term_init): Check for size calculation overflow.
1259 (x_color_cells): Don't store size until memory allocation succeeds.
1260 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
1261 Don't assume alloca size is less than MAX_ALLOCA.
1262 (x_term_init): Don't assume length fits in int (sprintf is limited
1265 Use ptrdiff_t for composition IDs.
1266 * character.c (lisp_string_width):
1267 * composite.c (composition_table_size, n_compositions)
1268 (get_composition_id, composition_gstring_from_id):
1269 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1270 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1271 * window.c (Frecenter):
1272 Use ptrdiff_t, not int, for composition IDs.
1273 * composite.c (get_composition_id): Check for integer overflow.
1274 * composite.h: Adjust prototypes to match the above changes.
1276 Use ptrdiff_t for hash table indexes.
1277 * category.c (hash_get_category_set):
1278 * ccl.c (ccl_driver):
1279 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1280 * coding.c (coding_system_charset_list, detect_coding_system):
1281 * coding.h (struct coding_system.id):
1282 * composite.c (get_composition_id, gstring_lookup_cache):
1283 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1284 * image.c (xpm_get_color_table_h):
1285 * lisp.h (hash_lookup, hash_put):
1286 * minibuf.c (Ftest_completion):
1287 Use ptrdiff_t for hash table indexes, not int (which is too
1288 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1289 32-bit --with-wide-int hosts).
1291 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1292 Add a FIXME comment about memory leaks.
1293 (syms_of_charset): Don't assume xmalloc returns.
1295 Don't assume that stated character widths fit in int.
1296 * character.c (Fchar_width, c_string_width, lisp_string_width):
1297 * character.h (CHAR_WIDTH):
1298 * indent.c (MULTIBYTE_BYTES_WIDTH):
1299 Use sanitize_char_width to avoid undefined and/or bad behavior
1300 with outlandish widths.
1301 * character.h (sanitize_tab_width): Rename from sanitize_width,
1302 now that we have two such functions. All uses changed.
1303 (sanitize_char_width): New inline function.
1305 Don't assume that tab-width fits in int.
1306 * character.h (sanitize_width): New inline function.
1307 (SANE_TAB_WIDTH): New macro.
1308 (ASCII_CHAR_WIDTH): Use it.
1309 * indent.c (sane_tab_width): Remove. All uses replaced by
1310 SANE_TAB_WIDTH (current_buffer).
1311 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1313 * fileio.c: Integer overflow issues with file modes.
1314 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1316 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1317 Remove unreachable code.
1318 (read_hex, load_charset_map_from_file): Check for integer overflow.
1320 * xterm.c: don't go over XClientMessageEvent limit
1321 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1322 (x_send_scroll_bar_event): Likewise. Check that the size does not
1323 exceed limits imposed by XClientMessageEvent, as well as the usual
1324 ptrdiff_t and size_t limits.
1326 * keyboard.c: Overflow, signedness and related fixes.
1327 (make_lispy_movement): Use same integer type in forward decl
1328 that is used in the definition.
1329 (read_key_sequence, keyremap_step):
1330 Change bufsize argument back to int, undoing my 2011-03-30 change.
1331 We prefer signed types, and int is wide enough here.
1332 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1333 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1334 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1335 length, not size_t. Use ptrdiff_t for index, not int.
1336 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1337 possibility of integer overflow.
1339 Overflow, signedness and related fixes for images.
1341 * dispextern.h (struct it.stack[0].u.image.image_id)
1342 (struct_it.image_id, struct image.id, struct image_cache.size)
1343 (struct image_cache.used, struct image_cache.ref_count):
1344 * gtkutil.c (update_frame_tool_bar):
1345 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1346 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1347 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1348 * nsmenu.m (update_frame_tool_bar):
1349 * xdisp.c (calc_pixel_width_or_height):
1350 * xfns.c (image_cache_refcount):
1351 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1352 on typical 64-bit hosts.
1354 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1355 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1356 Omit unnecessary casts to int.
1357 (parse_image_spec): Check that integers fall into 'int' range
1358 when the callers expect that.
1359 (image_ascent): Redo ascent calculation to avoid int overflow.
1360 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1361 (lookup_image): Remove unnecessary tests.
1362 (xbm_image_p): Locals are now of int, not EMACS_INT,
1363 since parse_image_check makes sure they fit into int.
1364 (png_load, gif_load, svg_load_image):
1365 Prefer int to unsigned where either will do.
1366 (tiff_handler): New function, combining the cores of the
1367 old tiff_error_handler and tiff_warning_handler.
1368 This function is rewritten to use vsnprintf and thereby avoid
1369 stack buffer overflows. It uses only the features of vsnprintf
1370 that are common to both POSIX and native Microsoft.
1371 (tiff_error_handler, tiff_warning_handler): Use it.
1372 (tiff_load, gif_load, imagemagick_load_image):
1373 Don't assume :index value fits in 'int'.
1374 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1375 (imagemagick_load_image): Check that crop parameters fit into
1376 the integer types that MagickCropImage accepts. Don't assume
1377 Vimagemagick_render_type has a nonnegative value. Don't assume
1378 size_t fits in 'long'.
1379 (gs_load): Use printmax_t to print the widest integers possible.
1380 Check for integer overflow when computing image height and width.
1382 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1384 * xdisp.c (redisplay_window): Don't force window start if point
1385 will be invisible in the resulting window. (Bug#9324)
1387 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1389 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1390 the display spec is of the form `(space ...)'.
1391 (handle_display_spec): Return the value returned by
1392 handle_single_display_spec, not just 1 or zero.
1393 (handle_single_display_spec): If the display spec is of the form
1394 `(space ...)', and specifies display in the text area, return 2
1396 (try_cursor_movement): Check for the need to scroll more
1397 accurately, and prefer exact match for point under bidi.
1398 Don't advance `row' beyond the last row of the window.
1400 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1401 into disp_prop; all users changed.
1403 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1404 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1405 for the text covered by the display property.
1407 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1409 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1410 Change return value to nil.
1411 (Frecord_buffer): Delete unused function.
1413 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1415 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1416 buffers, return left-to-right.
1417 (set_cursor_from_row): Consider candidate row a win if its glyph
1418 represents a newline and point is on that newline. Fixes cursor
1419 positioning on the newline at EOL of R2L text within L2R
1420 paragraph, and vice versa.
1421 (try_cursor_movement): Check continued rows, in addition to
1422 continuation rows. Fixes unwarranted scroll when point enters a
1423 continued line of R2L text within an L2R paragraph, or vice versa.
1424 (cursor_row_p): Consider the case of point being equal to
1425 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1426 from the end of a short line to the beginning of a continued line
1427 of R2L text within L2R paragraph.
1428 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1429 composed characters.
1431 * bidi.c (bidi_check_type): Use xassert.
1432 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1435 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1437 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1440 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1442 * nsfont.m (ns_otf_to_script): Fix typo.
1444 2011-08-22 Kenichi Handa <handa@m17n.org>
1446 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1447 extra slot even if the purpose is char-code-property-table.
1449 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1451 * xdisp.c (redisplay_window): When computing centering_position,
1452 account for the height of the header line. (Bug#8874)
1454 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1455 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1456 candidate is selected by the mouse, and that candidate has a
1457 composed character under the mouse.
1459 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1460 coordinates reported by pos-visible-in-window-p for a composed
1461 character in column zero.
1463 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1465 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1467 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1469 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1470 consider it a hit if to_charpos is anywhere in the range of the
1471 composed buffer positions.
1473 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1475 * image.c (gif_load): Don't assume that each subimage has the same
1476 dimensions as the base image. Handle disposal method that is
1477 "undefined" by the gif spec (Bug#9335).
1479 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1481 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1482 (Fcondition_case): Document `debug' symbol in error handler.
1484 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1486 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1487 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1488 from an Org mode buffer to a Speedbar frame.
1490 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1491 a composition, take its buffer position from IT->cmp_it.charpos.
1492 Fixes cursor positioning at the beginning of a line that begins
1493 with a composed character.
1495 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1497 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1498 character bidirectional type, use STRONG_L instead. Fixes crashes
1499 in a buffer produced by `describe-categories'.
1501 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1502 members before the level stack, so they would be saved and
1503 restored when copying iterator state. Fixes incorrect reordering
1504 around TABs covered by display properties.
1506 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1508 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
1510 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1512 * eval.c (internal_condition_case, internal_condition_case_1)
1513 (internal_condition_case_2, internal_condition_case_n):
1514 Remove unnecessary aborts (Bug#9081).
1516 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1518 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1519 has no `load' handler, try opening the file locally. (Bug#9311)
1521 2011-08-16 Ken Brown <kbrown@cornell.edu>
1523 * gmalloc.c: Expand comment.
1525 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1527 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1528 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1530 2011-08-16 Ken Brown <kbrown@cornell.edu>
1532 Fix memory allocation problems in Cygwin build (Bug#9273).
1534 * unexcw.c ( __malloc_initialized): Declare external variable.
1535 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1537 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1539 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1541 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1543 [CYGWIN] (special_realloc): New function.
1544 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1545 requests to realloc storage in the static heap.
1547 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1549 * bidi.c (bidi_initialize): Remove unused local.
1551 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1554 * biditype.h: Remove file.
1555 * makefile.w32-in ($(BLD)/bidi.$(O)):
1556 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
1558 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1560 * chartab.c: Improve commentary for the uniprop_table API.
1562 * bidi.c (bidi_paragraph_init): Support zero value of
1563 bidi_ignore_explicit_marks_for_paragraph_level.
1564 (bidi_initialize): Use uniprop_table instead of including
1565 biditype.h and bidimirror.h.
1567 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1568 coordinates of the iterator when restoring from ppos_it.
1571 2011-08-14 Kenichi Handa <handa@m17n.org>
1573 * process.c (create_process): Call setup_process_coding_systems
1574 after the pid of the process is set to -1 (Bug#8162).
1576 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1578 * xdisp.c (move_it_in_display_line_to): Don't invoke
1579 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1580 ppos_it. Fixes vertical cursor motion when line beginning is
1581 covered by an image. (Bug#9296)
1583 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1585 * nsterm.h (ns_run_ascript): Declare.
1586 (NSAPP_DATA2_RUNASSCRIPT): Define.
1588 * nsfns.m (as_script, as_result, as_status): New static variables.
1589 (ns_run_ascript): New function.
1590 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1591 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1592 the event loop. Get status from as_status (Bug#7276).
1594 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1595 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1596 the event loop (Bug#7276).
1598 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1600 * gnutls.c (QCgnutls_bootprop_priority)
1601 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1602 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1603 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1604 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1605 (QCgnutls_bootprop_verify_hostname_error)
1606 (QCgnutls_bootprop_callbacks_verify): Rename from
1607 Qgnutls_bootprop_..., all uses changed.
1609 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1612 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1614 * xfaces.c (Qframe_set_background_mode): Now static.
1615 * dispextern.h (Qframe_set_background_mode): Remove decl.
1617 * process.c (Fnetwork_interface_info): Declare local only if needed.
1619 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1621 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1622 (Fnetwork_interface_list): Allocate in increments of bytes instead
1623 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1624 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1626 (struct ifflag_def): notrailers is smart on OSX.
1627 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1628 Get hardware address with getifaddrs if available.
1630 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1632 * xdisp.c (iterate_out_of_display_property): xassert that
1633 IT->position is set to within IT->object's boundaries. Break from
1634 the loop as soon as EOB is reached; avoids infloops in redisplay
1635 when IT->position is set up wrongly due to some bug.
1636 Set IT->current to match the bidi iterator unconditionally.
1637 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1638 entry. Force push_it to save on the stack the current
1639 buffer/string position, to be restored by pop_it. Fix flags in
1640 the iterator structure wrt the object coming from a display
1641 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1642 properties. (Bug#9284)
1644 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1646 * fontset.c (fontset_get_font_group): Add proper type checks.
1649 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1651 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1652 and LC_VERSION_MIN_MACOSX.
1653 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1654 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1656 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1658 * xdisp.c (forward_to_next_line_start): Allow to use the
1659 no-display-properties-and-no-overlays under bidi display.
1660 Set disp_pos in the bidi iterator to avoid searches for display
1661 properties and overlays.
1663 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1665 * editfns.c (Fset_time_zone_rule): Document relationship with the
1668 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1669 the font entity extracted from the cache (Bug#8109).
1671 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1673 * composite.c (autocmp_chars): Don't reset point. That is done by
1674 restore_point_unwind (Bug#5984).
1676 2011-08-07 Juri Linkov <juri@jurta.org>
1678 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1679 to show the arg `TIME' instead of `TIMEVAL'.
1681 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1683 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1684 display property strides EOL and includes a newline, as in
1685 longlines-mode. (Bug#9254)
1686 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1687 word-wrap under bidirectional display. (Bug#9224)
1689 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1690 is non-zero, even if the data buffer is NULL. Fixes a crash in
1691 vertical-motion with longlines-mode. (Bug#9254)
1693 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1695 * bidi.c <bidi_cache_total_alloc>: Now static.
1696 (bidi_initialize): Initialize bidi_cache_total_alloc.
1698 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1701 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1702 amount allocated this far in `bidi_cache_total_alloc'.
1703 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1704 non-zero, only free the data buffer without restoring the cache
1705 contents. All callers changed.
1707 * dispextern.h (bidi_unshelve_cache): Update prototype.
1709 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1710 (move_it_in_display_line, move_it_to)
1711 (move_it_vertically_backward, move_it_by_lines): Replace the call
1712 to xfree to an equivalent call to bidi_unshelve_cache.
1713 (move_it_in_display_line_to): Fix logic of returning
1714 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1716 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1718 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1719 came from a string character with a `cursor' property. (Bug#9229)
1721 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1723 * Makefile.in (LIB_PTHREAD): New variable.
1724 (LIBES): Add LIB_PTHREAD (Bug#9216).
1726 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1727 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1729 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1731 * regex.c (re_iswctype): Remove some redundant boolean conversions.
1733 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1735 * xterm.c (x_find_topmost_parent): New function.
1736 (x_set_frame_alpha): Find topmost parent window with
1737 x_find_topmost_parent and set the property there also (bug#9181).
1738 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1740 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1742 * callproc.c (Fcall_process): Avoid vfork clobbering
1743 the local vars buffer, coding_systems, current_dir.
1745 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1747 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1749 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1751 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1752 so that it is not optimized away.
1754 * xdisp.c (compute_display_string_pos): Remove unused local.
1756 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1758 Fix slow cursor motion and scrolling in large buffers with
1759 selective display, like Org Mode buffers. (Bug#9218)
1761 * dispextern.h (struct bidi_it): New member disp_prop_p.
1763 * xdisp.c: Remove one-slot cache of display string positions.
1764 (compute_display_string_pos): Accept an additional argument
1765 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1766 for a display string or property. If found, set DISP_PROP_P
1769 * bidi.c (bidi_fetch_char): Accept an additional argument
1770 DISP_PROP_P, and pass it to compute_display_string_pos.
1771 Only handle text covered by a display string if DISP_PROP_P is returned
1772 non-zero. All callers of bidi_fetch_char changed.
1774 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1776 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1778 2010-12-03 Don March <don@ohspite.net>
1780 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1781 last character M-[char] is translated to ESC [char] (bug#7541).
1783 2011-08-02 Kenichi Handa <handa@m17n.org>
1785 * lisp.h (uniprop_table): Extern it.
1787 * chartab.c (uniprop_table): Make it non-static.
1789 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1791 * xdisp.c (forward_to_next_line_start): Accept additional argument
1792 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1794 (reseat_at_next_visible_line_start): Use the bidi iterator state
1795 returned by forward_to_next_line_start to restore the state of
1796 it->bidi_it after backing up to previous newline. (Bug#9212)
1798 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1800 * regex.c (re_comp): Protoize.
1801 (re_exec): Fix return type.
1802 (regexec): Fix type of `ret'. (Bug#9203)
1804 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1806 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1807 This is needed if max-image-size is a floating-point number.
1809 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1811 * print.c (print_object): Print empty symbol as ##.
1813 * lread.c (read1): Read ## as empty symbol.
1815 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1817 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1818 setting frame foreground color (Bug#9175).
1819 (x_set_background_color): Likewise.
1821 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1822 contents (Bug#9176).
1823 (EmacsTooltip -init): Remove bezels and add shadows to
1826 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1827 or scroll bar (Bug#8470).
1829 * nsfont.m (nsfont_open): Remove assignment to voffset and
1830 unnecessary vars hshink, expand, hd, full_height, min_height.
1831 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1833 * nsterm.h (nsfont_info): Remove voffset field.
1835 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1837 Implement strike-through and overline on NextStep (Bug#8863).
1839 * nsfont.m (nsfont_open): Use underline position provided by font,
1840 instead of hard-coded value of 2.
1841 (nsfont_draw): Call ns_draw_text_decoration instead.
1843 * nsterm.h: Add declaration for ns_draw_text_decoration.
1845 * nsterm.m (ns_draw_text_decoration): New function for drawing
1846 underline, overline, and strike-through.
1847 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1848 ns_draw_text_decoration. Change treatment of cursor drawing to
1849 accommodate underlining, etc.
1851 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1853 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1856 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1858 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1859 Without this fix, if a signal arrives just after memory fills up,
1860 'malloc' might be invoked reentrantly.
1862 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1863 In other words, assume that every image size is allowed, on non-X
1864 hosts. This assumption is probably wrong, but it lets Emacs compile.
1866 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1868 * regex.c (re_iswctype): Convert return values to boolean.
1870 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1872 * xdisp.c (compute_display_string_pos): Don't use cached display
1873 string position if the buffer had its restriction changed.
1876 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1878 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1880 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1882 Integer signedness and overflow and related fixes. (Bug#9079)
1884 * bidi.c: Integer size and overflow fixes.
1885 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1886 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1887 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1888 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1889 (bidi_find_other_level_edge):
1890 Use ptrdiff_t instead of EMACS_INT where either will do.
1891 This works better on 32-bit hosts configured --with-wide-int.
1892 (bidi_cache_ensure_space): Check for size-calculation overflow.
1893 Use % rather than repeated addition, for better worst-case speed.
1894 Don't set bidi_cache_size until after xrealloc returns, because it
1896 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1897 (bidi_cache_ensure_space): Also check that the bidi cache size
1898 does not exceed that of the largest Lisp string or buffer. See Eli
1899 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1901 * alloc.c (__malloc_size_t): Remove.
1902 All uses replaced by size_t. See Andreas Schwab's note
1903 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1905 * image.c: Improve checking for integer overflow.
1906 (check_image_size): Assume that f is nonnull, since
1907 it is always nonnull in practice. This is one less thing to
1908 worry about when checking for integer overflow later.
1909 (x_check_image_size): New function, which checks for integer
1910 overflow issues inside X.
1911 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1912 This removes the need for a memory_full check.
1913 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1914 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1915 (xbm_read_bitmap_data): Change locals back to 'int', since
1916 their values must fit in 'int'.
1917 (xpm_load_image, png_load, tiff_load):
1918 Invoke x_create_x_image_and_pixmap earlier,
1919 to avoid much needless work if the image is too large.
1920 (tiff_load): Treat overly large images as if
1921 x_create_x_image_and_pixmap failed, not as malloc failures.
1922 (gs_load): Use x_check_image_size.
1924 * gtkutil.c: Omit integer casts.
1925 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1926 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1928 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1930 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1931 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1932 would wrongly return t on a 64-bit host.
1934 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1935 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1936 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1937 and therefore cause GCC to emit a bogus diagnostic in some cases.
1939 * image.c: Integer signedness and overflow and related fixes.
1940 This is not an exhaustive set of fixes, but it's time to
1941 record what I've got.
1942 (lookup_pixel_color, check_image_size): Remove redundant decls.
1943 (check_image_size): Don't assume that arbitrary EMACS_INT values
1944 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1945 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1946 (tiff_load, imagemagick_load_image):
1947 Check for overflow in size calculations.
1948 (x_create_x_image_and_pixmap): Remove unnecessary test for
1949 xmalloc returning NULL; that can't happen.
1950 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1951 (xpm_color_bucket): Use better integer hashing function.
1952 (xpm_cache_color): Don't possibly over-allocate memory.
1953 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1954 (gif_memory_source):
1955 Use ptrdiff_t, not int or size_t, to record sizes.
1956 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1957 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1958 either works, as we prefer signed integers.
1959 (tiff_read_from_memory, tiff_write_from_memory):
1960 Return tsize_t, not size_t, since that's what the TIFF API wants.
1961 (tiff_read_from_memory): Don't fail simply because the read would
1962 go past EOF; instead, return a short read.
1963 (tiff_load): Omit no-longer-needed casts.
1964 (Fimagemagick_types): Don't assume size fits into 'int'.
1966 Improve hashing quality when configured --with-wide-int.
1967 * fns.c (hash_string): New function, taken from sxhash_string.
1968 Do not discard information about ASCII character case; this
1969 discarding is no longer needed.
1970 (sxhash-string): Use it. Change sig to match it. Caller changed.
1971 * lisp.h: Declare it.
1972 * lread.c (hash_string): Remove, since we now use fns.c's version.
1973 The fns.c version returns a wider integer if --with-wide-int is
1974 specified, so this should help the quality of the hashing a bit.
1976 * emacs.c: Integer overflow minor fix.
1977 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1978 Define only if GNU_LINUX.
1979 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1981 * dispnew.c: Integer signedness and overflow fixes.
1982 Remove unnecessary forward decls, that were a maintenance hassle.
1983 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1985 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1986 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1987 (prepare_desired_row, line_draw_cost):
1988 Use int, not unsigned, where either works.
1989 (save_current_matrix, restore_current_matrix):
1990 Use ptrdiff_t, not size_t, where either works.
1991 (init_display): Check for overflow more accurately, and without
1992 relying on undefined behavior.
1994 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1995 Remove, replacing with the new symbols in lisp.h. All uses changed.
1996 * fileio.c (make_temp_name):
1997 * filelock.c (lock_file_1, lock_file):
1998 * xdisp.c (message_dolog):
1999 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2000 Use pMd etc. instead.
2001 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2002 replacing the pWIDE etc. symbols removed from editfns.c.
2004 * keyboard.h (num_input_events): Now uintmax_t.
2005 This is (very slightly) less likely to mess up due to wraparound.
2008 * buffer.c: Integer signedness fixes.
2009 (alloc_buffer_text, enlarge_buffer_text):
2010 Use ptrdiff_t rather than size_t when either will do, as we prefer
2013 * alloc.c: Integer signedness and overflow fixes.
2014 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2015 (__malloc_size_t): Default to size_t, not to int.
2016 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2017 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2018 Prefer ptrdiff_t to size_t when either would do, as we prefer
2020 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2021 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2022 Now const. Initialize with values that are in range even if char
2024 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2025 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2026 These functions do the right thing with sizes > 2**32.
2027 (check_depth): Now ptrdiff_t, not int.
2028 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2029 Adjust to new way of storing sizes. Check for size overflow bugs
2031 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2032 slightly wrong anyway, as it missed one instance of
2033 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2034 (refill_memory_reserve): Omit needless cast to size_t.
2035 (mark_object_loop_halt): Mark as externally visible.
2037 * xselect.c: Integer signedness and overflow fixes.
2038 (Fx_register_dnd_atom, x_handle_dnd_message):
2039 Use ptrdiff_t, not size_t, since we prefer signed.
2040 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2041 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2042 x_dnd_atoms_size and x_dnd_atoms_length.
2044 * doprnt.c: Prefer signed to unsigned when either works.
2046 * doprnt.c (doprnt):
2048 * xdisp.c (vmessage):
2049 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2050 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2051 prefer signed arithmetic to avoid comparison confusion.
2052 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2053 but is a bit tricky.
2055 Assume freestanding C89 headers, string.h, stdlib.h.
2056 * data.c, doprnt.c, floatfns.c, print.c:
2057 Include float.h unconditionally.
2058 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2059 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2060 * regex.c: Likewise for stddef.h, string.h.
2061 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2062 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2063 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2064 (STDC_HEADERS): Remove obsolete defines.
2065 * sysdep.c: Include limits.h unconditionally.
2067 Assume support for memcmp, memcpy, memmove, memset.
2068 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2069 * regex.c (memcmp, memcpy):
2070 Remove; we assume C89 now.
2072 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2073 (__malloc_safe_bcopy): Remove; no longer needed.
2075 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
2076 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2077 well either way, and we prefer signed to unsigned.
2079 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2081 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2082 closes the connection while we're reading (bug#9182).
2084 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
2086 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2087 are specified (Bug#9168).
2089 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2091 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2092 Found by GCC static checking and --with-wide-int on a 32-bit host.
2094 2011-07-25 Eli Zaretskii <eliz@gnu.org>
2096 * xdisp.c (compute_display_string_pos): Fix logic of caching
2097 previous display string position. Initialize cached_prev_pos to
2098 -1. Fixes slow-down at the beginning of a buffer.
2100 2011-07-24 Eli Zaretskii <eliz@gnu.org>
2102 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2103 for attrs[LFACE_FONTSET_INDEX].
2105 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2107 * xml.c (parse_region): Remove unused local
2108 that was recently introduced.
2110 2011-07-23 Eli Zaretskii <eliz@gnu.org>
2112 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2113 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2115 * xdisp.c (move_it_in_display_line_to): Record the best matching
2116 position for TO_CHARPOS while scanning the line, and restore it on
2117 exit if none of the characters scanned was an exact match.
2118 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
2119 when exact match is impossible due to invisible text, and the
2120 lines are truncated.
2122 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2124 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2127 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2129 Fix a significant slow-down of cursor motion with C-n, C-p,
2130 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2131 auto-repeat under bidi redisplay in fontified buffers.
2132 * xdisp.c (compute_stop_pos_backwards): New function.
2133 (next_element_from_buffer): Call compute_stop_pos_backwards to
2134 find a suitable prev_stop when we find ourselves before
2136 (reseat): Don't look for prev_stop, as that could mean a very long
2138 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2139 <cached_disp_overlay_modiff>: Cache for last found display string
2141 (compute_display_string_pos): Return the cached position if asked
2142 about the same buffer in the same area of character positions, and
2143 the buffer wasn't changed since the time the display string
2144 position was cached.
2146 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2148 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2149 is an integer, which is important for empty lines. (Bug#9149)
2151 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
2153 * frame.c (Fmodify_frame_parameters): In tty case, update the
2154 default face if necessary (Bug#4238).
2156 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
2158 * editfns.c (Fstring_to_char): No need to explain what a character
2159 is in the docstring (Bug#6576).
2161 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2163 * xml.c (parse_region): Make sure we always return a tree.
2165 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2167 * xml.c (parse_region): If a document contains only comments,
2170 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2172 * xml.c (make_dom): Return comments, too.
2174 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2177 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2178 and the surrounding thread.
2179 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2180 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2181 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2183 * s/openbsd.h (BROKEN_SIGIO): Define.
2184 * unexelf.c (unexec) [__OpenBSD__]:
2185 Don't update the .mdebug section of the Alpha COFF symbol table.
2187 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2189 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2192 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2194 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2195 This fixes some race conditions on the permissions of any newly
2198 * alloc.c (valid_pointer_p): Use pipe, not open.
2199 This fixes some permissions issues when debugging.
2201 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2202 If fchown fails to set both uid and gid, try to set just gid,
2203 as that is sometimes allowed. Adjust the file's mode to eliminate
2204 setuid or setgid bits that are inappropriate if fchown fails.
2206 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2208 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2209 to compare Lisp_Objects.
2210 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2211 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2212 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2214 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2216 * lread.c (read_integer): Unread even EOF character.
2217 (read1): Likewise. Properly record start position of symbol.
2219 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2220 symbol character follows.
2222 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2224 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2225 This works around a problem with the previous change to Fcopy_file.
2226 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2227 and without this change, GCC might complain about discarding
2228 fchown's return value.
2230 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
2232 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2234 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2236 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2238 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2240 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2241 it's used from the C level.
2243 * process.c: Use the same condition for POLL_FOR_INPUT in both
2244 keyboard.c and process.c (bug#1858).
2246 2011-07-09 Lawrence Mitchell <wence@gmx.li>
2248 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2249 (Fgnutls_boot): Use it.
2251 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2253 * doc.c (Fsubstitute_command_keys): Revert last change.
2255 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2257 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2258 quotes the next character, and doesn't affect other longer
2259 sequences (bug#8935).
2261 * lread.c (syms_of_lread): Clarify that is isn't only
2262 `eval-buffer' and `eval-defun' that's affected by
2263 `lexical-binding' (bug#8460).
2265 2011-07-15 Eli Zaretskii <eliz@gnu.org>
2267 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2268 bidi redisplay when a line includes both an image and is truncated.
2270 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2272 Fix minor problems found by static checking.
2273 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2274 (elsz): Now a signed constant, not a size_t var. We prefer signed
2275 types to unsigned, to avoid integer comparison confusion. Without
2276 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2277 "cannot optimize loop, the loop counter may overflow", a symptom
2279 * indent.c (Fvertical_motion): Mark locals as initialized.
2280 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2282 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2284 * search.c (Fre_search_backward): Mention `case-fold-search' in
2285 all the re_search_* functions (bug#8138).
2287 * keyboard.c (Fopen_dribble_file): Document when the file is
2290 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2292 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2295 Support bidi reordering of display and overlay strings.
2296 * xdisp.c (compute_display_string_pos)
2297 (compute_display_string_end): Accept additional argument STRING.
2298 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2299 (reseat_to_string): Initialize bidi_it->string.s and
2300 bidi_it->string.schars.
2301 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2302 NULL (avoids a crash in bidi_paragraph_init).
2303 Initialize itb.string.lstring.
2304 (init_iterator): Call bidi_init_it only of a valid
2305 buffer position was specified. Initialize paragraph_embedding to
2307 (reseat_to_string): Initialize the bidi iterator.
2308 (display_string): If we need to ignore text properties of
2309 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2310 original value of -1 will not work with bidi.)
2311 (compute_display_string_pos): First arg is now struct
2312 `text_pos *'; all callers changed. Support display properties on
2314 (compute_display_string_end): Support display properties on Lisp
2316 (init_iterator, reseat_1, reseat_to_string): Initialize the
2317 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2318 when iterating on a string not from display properties).
2319 (compute_display_string_pos, compute_display_string_end):
2320 Fix calculation of the object to scan. Fixes an error when using
2322 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2323 base_level_stop; instead, set base_level_stop to BEGV.
2324 Fixes crashes in vertical-motion.
2325 (next_element_from_buffer): Improve commentary for when
2326 the iterator is before prev_stop.
2327 (init_iterator): Initialize bidi_p from the default value of
2328 bidi-display-reordering, not from buffer-local value. Use the
2329 buffer-local value only if initializing for buffer iteration.
2330 (handle_invisible_prop): Support invisible properties on strings
2331 that are being bidi-reordered.
2332 (set_iterator_to_next): Support bidi reordering of C strings and
2334 (next_element_from_string): Support bidi reordering of Lisp
2336 (handle_stop_backwards): Support Lisp strings as well.
2337 (display_string): Support display of R2L glyph rows.
2338 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2339 (init_iterator): Don't initialize it->bidi_p for strings
2341 (reseat_to_string): Initialize it->bidi_p for strings here.
2342 (next_element_from_string, next_element_from_c_string)
2343 (next_element_from_buffer): Add xassert's for correspondence
2344 between IT's object being iterated and it->bidi_it.string
2346 (face_before_or_after_it_pos): Support bidi iteration.
2347 (next_element_from_c_string): Handle the case of the first string
2348 character that is not the first one in the visual order.
2349 (get_visually_first_element): New function, refactored from common
2350 parts of next_element_from_buffer, next_element_from_string, and
2351 next_element_from_c_string.
2352 (tool_bar_lines_needed, redisplay_tool_bar)
2353 (display_menu_bar): Force left-to-right direction. Add a FIXME
2354 comment for making that be controlled by a user option.
2355 (push_it, pop_it): Save and restore the state of the
2356 bidi iterator. Save and restore the bidi_p flag.
2357 (pop_it): Iterate out of display property for string iteration as
2359 (iterate_out_of_display_property): Support iteration over strings.
2360 (handle_single_display_spec): Set up it->bidi_it for iteration
2361 over a display string, and call bidi_init_it.
2362 (handle_single_display_spec, next_overlay_string)
2363 (get_overlay_strings_1, push_display_prop): Set up the bidi
2364 iterator for displaying display or overlay strings.
2365 (forward_to_next_line_start): Don't use the shortcut if
2367 (back_to_previous_visible_line_start): If handle_display_prop
2368 pushed the iterator stack, restore the internal state of the bidi
2369 iterator by calling bidi_pop_it same number of times.
2370 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2371 and we are bidi-iterating, don't decrement the iterator position;
2372 instead, set the first_elt flag in the bidi iterator, to produce
2374 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2375 (push_display_prop): xassert that we are iterating a buffer.
2376 (push_it, pop_it): Save and restore paragraph_embedding member.
2377 (handle_single_display_spec, next_overlay_string)
2378 (get_overlay_strings_1, reseat_1, reseat_to_string)
2379 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2380 correctly. Don't assume unibyte strings are not bidi-reordered.
2381 (compute_display_string_pos)
2382 (compute_display_string_end): Fix handling the case of C string.
2383 (push_it, pop_it): Save and restore from_disp_prop_p.
2384 (handle_single_display_spec, push_display_prop): Set the
2385 from_disp_prop_p flag.
2386 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2387 (pop_it): Call iterate_out_of_display_property only if we are
2388 popping after iteration over a string that came from a display
2389 property. Fix a typo in popping stretch info. Add an assertion
2390 for verifying that the iterator position is in sync with the bidi
2392 (handle_single_display_spec, get_overlay_strings_1)
2393 (push_display_prop): Fix initialization of paragraph direction for
2394 string when that of the parent object is not yet determined.
2395 (reseat_1): Call bidi_init_it to resync the bidi
2396 iterator with IT's position. (Bug#7616)
2397 (find_row_edges): If ROW->start.pos gives position
2398 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2399 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2400 Reset the from_disp_prop_p flag.
2401 (SAVE_IT, RESTORE_IT): New macros.
2402 (pos_visible_p, face_before_or_after_it_pos)
2403 (back_to_previous_visible_line_start)
2404 (move_it_in_display_line_to, move_it_in_display_line)
2405 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2406 (try_scrolling, redisplay_window, display_line): Use them when
2407 saving a temporary copy of the iterator and restoring it back.
2408 (back_to_previous_visible_line_start, reseat_1)
2409 (init_iterator): Empty the bidi cache "stack".
2410 (move_it_in_display_line_to): If iterator ended up at
2411 EOL, but we never saw any buffer positions smaller than
2412 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2413 motion in bidi-reordered lines.
2414 (move_it_in_display_line_to): Record prev_method and prev_pos
2415 immediately before the call to set_iterator_to_next. Fixes cursor
2416 motion in bidi-reordered lines with stretch glyphs and strings
2417 displayed in margins. (Bug#8133) (Bug#8867)
2418 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2420 (pos_visible_p): Support positions in bidi-reordered lines.
2421 Save and restore bidi cache.
2423 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2424 (bidi_paragraph_info): Delete unused struct.
2425 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2426 (bidi_cache_start): New variable.
2427 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2429 (bidi_cache_fetch_state, bidi_cache_search)
2430 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2431 (bidi_cache_find, bidi_peek_at_next_level)
2432 (bidi_level_of_next_char, bidi_find_other_level_edge)
2433 (bidi_move_to_visually_next): Compare cache index with
2434 bidi_cache_start rather than with zero.
2435 (bidi_fetch_char): Accept new argument STRING; all callers
2436 changed. Support iteration over a string. Support strings with
2437 display properties. Support unibyte strings. Fix the type of
2438 `len' according to what STRING_CHAR_AND_LENGTH expects.
2439 (bidi_paragraph_init, bidi_resolve_explicit_1)
2440 (bidi_resolve_explicit, bidi_resolve_weak)
2441 (bidi_level_of_next_char, bidi_move_to_visually_next):
2442 Support iteration over a string.
2443 (bidi_set_sor_type, bidi_resolve_explicit_1)
2444 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2445 can now be zero (for strings); special values 0 and -1 were
2446 changed to -1 and -2, respectively.
2447 (bidi_char_at_pos): New function.
2448 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2449 Call it instead of FETCH_MULTIBYTE_CHAR.
2450 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2451 initialized to valid values.
2452 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2454 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2455 the test for valid cached positions. Fix the logic for looking up
2456 the sentinel state in the cache. GCPRO the Lisp string we are
2458 (bidi_push_it, bidi_pop_it): New functions.
2459 (bidi_initialize): Initialize the bidi cache start stack pointer.
2460 (bidi_cache_ensure_space): New function, refactored from part of
2461 bidi_cache_iterator_state. Don't assume the required size is just
2462 one BIDI_CACHE_CHUNK away.
2463 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2464 (bidi_count_bytes, bidi_char_at_pos): New functions.
2465 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2466 always valid if bidi_cache_idx is valid.
2467 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2468 is valid if it's going to be used.
2469 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2470 (bidi_cache_fetch_state, bidi_cache_search)
2471 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2472 (bidi_cache_iterator_state, bidi_cache_find)
2473 (bidi_find_other_level_edge, bidi_cache_start_stack):
2474 All variables related to cache indices are now EMACS_INT.
2476 * dispextern.h (struct bidi_string_data): New structure.
2477 (struct bidi_it): New member `string'. Make flag members be 1-bit
2478 fields, and put them last in the struct.
2479 (compute_display_string_pos, compute_display_string_end):
2481 (bidi_push_it, bidi_pop_it): Add prototypes.
2482 (struct iterator_stack_entry): New members bidi_p,
2483 paragraph_embedding, and from_disp_prop_p.
2484 (struct it): Member bidi_p is now a bit field 1 bit wide.
2485 (bidi_shelve_cache, bidi_unshelve_cache):
2488 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2489 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2490 and vector-like objects.
2492 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2493 cache around display iteration.
2495 * window.c (Fwindow_end, window_scroll_pixel_based)
2496 (displayed_window_lines, Frecenter): Save and restore the bidi
2497 cache around display iteration.
2499 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2501 * editfns.c (Fdelete_region): Clarify the use of the named
2502 parameters (bug#6788).
2504 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2506 * indent.c (Fvertical_motion): Set and restore w->pointm when
2507 saving and restoring the window's buffer (Bug#9006).
2509 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2511 * editfns.c (Fstring_to_char): Clarify just what is returned
2512 (bug#6576). Text by Eli Zaretskii.
2514 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2516 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2518 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2520 * buffer.c (mmap_find): Fix a typo.
2522 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2524 Fix execution of x selection hooks.
2525 * xselect.c (Qx_lost_selection_functions)
2526 (Qx_sent_selection_functions): New vars.
2527 (syms_of_xselect): DEFSYM them.
2528 (x_handle_selection_request): Pass Qx_sent_selection_functions
2529 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2530 (x_handle_selection_clear,x_clear_frame_selections):
2531 Pass Qx_lost_selection_functions rather than
2532 Vx_lost_selection_functions to Frun_hook_with_args.
2534 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2536 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2537 The old code sometimes used this field without initializing it.
2539 * alloc.c (gc_sweep): Don't read past end of array.
2540 In theory, the old code could also have corrupted Emacs internals,
2541 though it'd be very unlikely.
2543 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2545 * character.c (Fcharacterp): Don't advertise optional ignored
2546 argument. (Bug#4026)
2548 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2550 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2553 * window.c (Fset_window_start): Doc fix (bug#4199).
2554 (Fset_window_hscroll): Ditto.
2556 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2558 Fix minor new problems caught by GCC 4.6.1.
2559 * term.c (init_tty): Remove unused local.
2560 * xsettings.c (store_monospaced_changed): Define this function only
2561 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2564 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2566 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2568 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2570 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2571 are the mini-buffer and the echo area (bug#3320).
2573 * term.c (init_tty): Remove support for supdup, c10 and perq
2574 terminals, which are no longer supported (bug#1482).
2576 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2578 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2580 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2582 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2583 for non-popups (Bug#3642).
2585 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2587 * alloc.c (reset_malloc_hooks): Protoize.
2588 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2589 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2590 * cm.c (losecursor): Likewise.
2591 * data.c (fmod): Likewise.
2592 * dispnew.c (swap_glyphs_in_rows): Likewise.
2593 * emacs.c (memory_warning_signal): Likewise.
2594 * floatfns.c (float_error): Likewise.
2595 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2596 (otf_open, font_otf_capability, generate_otf_features)
2597 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2599 * image.c (pbm_read_file): Likewise.
2600 * indent.c (string_display_width): Likewise.
2601 * intervals.c (check_for_interval, search_for_interval)
2602 (inc_interval_count, count_intervals, root_interval)
2603 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2604 * lread.c (defalias): Likewise.
2605 * ralloc.c (r_alloc_check): Likewise.
2606 * regex.c (set_image_of_range_1, set_image_of_range)
2607 (regex_grow_registers): Likewise.
2608 * sysdep.c (strerror): Likewise.
2609 * termcap.c (valid_filename_p, tprint, main): Likewise.
2610 * tparam.c (main): Likewise.
2611 * unexhp9k800.c (run_time_remap, save_data_space)
2612 (update_file_ptrs, read_header, write_header, calculate_checksum)
2613 (copy_file, copy_rest, display_header): Likewise.
2614 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2616 * xdisp.c (check_it): Likewise.
2617 * xfaces.c (register_color, unregister_color, unregister_colors):
2619 * xfns.c (print_fontset_result): Likewise.
2620 * xrdb.c (member, fatal, main): Likewise.
2622 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2624 Fix minor problems found by static checking (Bug#9031).
2625 * chartab.c (char_table_set_range, map_sub_char_table):
2626 Remove unused locals.
2627 (uniprop_table): Now static.
2628 * composite.c (_work_char): Remove unused static var.
2630 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2632 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2634 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2636 * gtkutil.c (qttip_cb): Remove code without function.
2638 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2640 * w32.c (pthread_sigmask): New stub.
2642 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2644 Use pthread_sigmask, not sigprocmask (Bug#9010).
2645 sigprocmask is portable only for single-threaded applications, and
2646 Emacs can be multi-threaded when it uses GTK.
2647 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2649 * callproc.c (Fcall_process):
2650 * process.c (create_process):
2651 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2652 Use pthread_sigmask, not sigprocmask.
2654 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2656 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2657 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2660 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2662 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2663 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2664 (xg_hide_tooltip): Fix comment.
2666 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2667 in registerServicesMenuSendTypes.
2668 (validRequestorForSendType): Don't check ns_return_types.
2670 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2673 2011-07-08 Jason Rumney <jasonr@gnu.org>
2675 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2676 frame struct members of non-existent frames (Bug#6284).
2678 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2680 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2681 variable firstTime not needed on OSX >= 10.6.
2682 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2683 >= 10.5. Use setKnobProportion, setDoubleValue.
2685 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2686 (MAC_OS_X_VERSION_10_5): Define if not defined.
2687 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2688 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2689 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2691 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2692 cString and lossyCString on OSX >= 10.4
2694 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2695 sizeToFit on OSX >= 10.2.
2697 * nsimage.m (allocInitFromFile): Don't use deprecated method
2698 bestRepresentationForDevice on OSX >= 10.6.
2700 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2703 * emacs.c: Declare unexec_init_emacs_zone.
2705 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2707 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2709 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2710 on svcsMenu (Bug#8842).
2712 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2714 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2716 * nsterm.m (QUTF8_STRING): Declare.
2717 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2718 (validRequestorForSendType): Return type is (id).
2719 Change indexOfObjectIdenticalTo to indexOfObject.
2720 Check if we have local selection before returning self (Bug#8842).
2721 (writeSelectionToPasteboard): Put local selection into paste board
2722 if we have a local selection (Bug#8842).
2723 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2725 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2726 (ns_get_local_selection): Declare.
2728 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2730 * keymap.c (describe_map_tree): Don't insert a double newline at
2731 the end of the buffer (bug#1169) and return whether we inserted
2734 * callint.c (Fcall_interactively): Change "reading args" to
2735 "providing args" to try to clarify what it does (bug#1010).
2737 2011-07-07 Kenichi Handa <handa@m17n.org>
2739 * composite.c (composition_compute_stop_pos): Ignore a static
2740 composition starting before CHARPOS (Bug#8915).
2742 * xdisp.c (handle_composition_prop): Likewise.
2744 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2746 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2749 2011-07-07 Kenichi Handa <handa@m17n.org>
2751 * character.h (unicode_category_t): New enum type.
2753 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2754 (Qchar_code_property_table): New variable.
2755 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2756 (UNIPROP_COMPRESSED_FORM_P): New macros.
2757 (char_table_ascii): Uncompress the compressed values.
2758 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2759 Uncompress the compressed values.
2760 (sub_char_table_ref_and_range): Likewise.
2761 (char_table_ref_and_range): Uncompress the compressed values.
2762 (sub_char_table_set): New arg is_uniprop. Callers changed.
2763 Uncompress the compressed values.
2764 (sub_char_table_set_range): Args changed. Callers changed.
2765 (char_table_set_range): Adjuted for the above change.
2766 (map_sub_char_table): Delete args default_val and parent. Add arg
2767 top. Give decoded values to a Lisp function.
2768 (map_char_table): Adjust for the above change. Give decoded
2769 values to a Lisp function. Gcpro more variables.
2770 (uniprop_table_uncompress)
2771 (uniprop_decode_value_run_length): New functions.
2772 (uniprop_decoder, uniprop_decoder_count): New variables.
2773 (uniprop_get_decoder, uniprop_encode_value_character)
2774 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2776 (uniprop_encoder, uniprop_encoder_count): New variables.
2777 (uniprop_get_encoder, uniprop_table)
2778 (Funicode_property_table_internal, Fget_unicode_property_internal)
2779 (Fput_unicode_property_internal): New functions.
2780 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2781 Sunicode_property_table_internal, Sget_unicode_property_internal,
2782 and Sput_unicode_property_internal. Defvar_lisp
2783 char-code-property-alist.
2785 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2786 Vunicode_category_table.
2788 * font.c (font_range): Adjust for the change of
2789 Vunicode_category_table.
2791 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2793 * m/iris4d.h: Remove file, move contents ...
2794 * s/irix6-5.h: ... here.
2796 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2798 Remove unportable assumption about struct layout (Bug#8884).
2799 * alloc.c (mark_buffer):
2800 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2801 (clone_per_buffer_values): Don't assume that
2802 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2803 This isn't true in general, and it's particularly not true
2804 if Emacs is configured with --with-wide-int.
2805 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2806 New macros, used in the buffer.c change.
2808 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2810 * xsettings.c: Use both GConf and GSettings if both are available.
2811 (store_config_changed_event): Add comment.
2812 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2813 (store_tool_bar_style_changed): New functions.
2814 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2815 (struct xsettings): Move font inside HAVE_XFT.
2816 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2817 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2818 Move inside HAVE_XFT.
2819 (something_changed_gsettingsCB): Rename from something_changedCB.
2820 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2822 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2823 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2824 (something_changed_gconfCB): Rename from something_changedCB.
2825 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2826 (parse_settings): Move check for font inside HAVE_XFT.
2827 (read_settings, apply_xft_settings): Add comment.
2828 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2829 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2830 call store_font_name_changed.
2831 (xft_settings_event): Add comment.
2832 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2833 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2834 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2835 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2836 (xsettings_initialize): Call init_gsettings last.
2837 (xsettings_get_system_font, xsettings_get_system_normal_font):
2840 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2842 Random fixes. E.g., (random) never returned negative values.
2843 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2844 subseconds part to the entropy, as that's a bit more random.
2845 Prefer signed to unsigned, since the signedness doesn't matter and
2846 in general we prefer signed. When given a limit, use a
2847 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2848 latter isn't right if USE_2_TAGS_FOR_INTS.
2849 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2850 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2852 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2854 * textprop.c (text_property_stickiness):
2855 Obey Vtext_property_default_nonsticky.
2856 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2857 * w32fns.c (syms_of_w32fns):
2858 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2860 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2862 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2863 This is more efficient than Ffile_directory_p and avoids a minor race.
2865 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2867 * buffer.c (Foverlay_put): Say what the return value is
2870 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2871 is a directory before asking whether to use the file name
2873 (barf_or_query_if_file_exists): Make the "File is a directory"
2874 error be more correct.
2876 * fns.c (Frequire): Remove the mention of the .gz files, since
2877 that's installation-specific, but keep the mention of
2878 `get-load-suffixes'.
2880 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2882 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2883 Report string overflow if the output is too long.
2885 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2887 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2888 (syms_of_gnutls): Remove duplicate DEFSYM for
2889 Qgnutls_bootprop_verify_hostname_error, an error for
2890 Qgnutls_bootprop_verify_error (which is no longer used).
2892 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2893 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2894 Also (re)move comments that are misplaced or no longer relevant.
2896 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2898 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2900 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2902 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2903 and background color parameters if they have been changed.
2905 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2907 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2909 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2911 * xsettings.c (SYSTEM_FONT): Define only when used.
2912 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2914 * keymap.c (access_keymap_1): Now static.
2916 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2918 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2919 leave any prefix arg for the up event (Bug#1586).
2921 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2923 * lread.c (syms_of_lread): Mention single symbols defined by
2924 `defvar' or `defconst' (bug#7154).
2926 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2927 (Frequire): Mention get-load-suffixes.
2929 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2931 * window.h (window): Remove clone_number slot.
2932 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2934 (make_parent_window, make_window, saved_window)
2935 (Fset_window_configuration, save_window_save): Don't deal with
2937 * buffer.c (Qclone_number): Remove declaration.
2938 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2940 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2942 Add multiple inheritance to keymaps.
2943 * keymap.c (Fmake_composed_keymap): New function.
2944 (Fset_keymap_parent): Simplify.
2945 (fix_submap_inheritance): Remove.
2946 (access_keymap_1): New function extracted from access_keymap to handle
2947 embedded parents and handle lists of maps.
2948 (access_keymap): Use it.
2949 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2950 (Fcopy_keymap): Handle embedded parents.
2951 (Fcommand_remapping, define_as_prefix): Simplify.
2952 (Fkey_binding): Simplify.
2953 (syms_of_keymap): Move minibuffer-local-completion-map,
2954 minibuffer-local-filename-completion-map,
2955 minibuffer-local-must-match-map, and
2956 minibuffer-local-filename-must-match-map to Elisp.
2957 (syms_of_keymap): Defsubr make-composed-keymap.
2958 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2959 (parse_menu_item): Trivial simplification.
2961 2011-07-01 Glenn Morris <rgm@gnu.org>
2963 * Makefile.in (SETTINGS_LIBS): Fix typo.
2965 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2967 * coding.c (Fencode_coding_string): Record the last coding system
2968 used, as the function doc string says (bug#8738).
2970 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2972 * xsettings.c (store_monospaced_changed): Take new font as arg and
2973 check for change against current_mono_font.
2974 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2975 (emacs_settings_constructor, emacs_settings_get_property)
2976 (emacs_settings_set_property, emacs_settings_class_init)
2977 (emacs_settings_init, gsettings_obj): Remove.
2978 (something_changedCB): New function for HAVE_GSETTINGS.
2979 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2980 with value as argument.
2981 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2982 g_settings_new (Bug#8967). Do not create gsettings_obj.
2983 Remove calls to g_settings_bind. Connect something_changedCB to
2986 * xgselect.c: Add defined (HAVE_GSETTINGS).
2987 (xgselect_initialize): Ditto.
2989 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2990 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2993 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2995 * eval.c (struct backtrace): Simplify and port the data structure.
2996 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2997 signed bit field, as this assumption is not portable and it makes
2998 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2999 "char debug_on_exit : 1" as this is not portable either; instead,
3000 use the portable "unsigned int debug_on_exit : 1". Remove unused
3001 member evalargs. Remove obsolete comments about cc bombing out.
3003 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3005 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3006 Let HAVE_GSETTINGS override HAVE_GCONF.
3007 (store_monospaced_changed): New function.
3008 (EMACS_SETTINGS): A new type derived from GObject to handle
3009 GSettings notifications.
3010 (emacs_settings_constructor, emacs_settings_get_property)
3011 (emacs_settings_set_property, emacs_settings_class_init):
3013 (gsettings_client, gsettings_obj): New variables.
3014 (GSETTINGS_SCHEMA): New define.
3015 (something_changedCB): Call store_monospaced_changed.
3016 (init_gsettings): New function.
3017 (xsettings_initialize): Call init_gsettings.
3018 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3021 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
3024 2011-06-29 Martin Rudalics <rudalics@gmx.at>
3026 * window.c (resize_root_window, grow_mini_window)
3027 (shrink_mini_window): Rename Qresize_root_window to
3028 Qwindow_resize_root_window and Qresize_root_window_vertically to
3029 Qwindow_resize_root_window_vertically.
3031 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3033 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3035 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
3037 * makefile.w32-in: Redesign dependencies so they reflect more
3038 clearly which files are directly included by each source file,
3039 and not through other includes.
3041 2011-06-27 Martin Rudalics <rudalics@gmx.at>
3043 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3044 (sort_overlays, overlay_strings): When an overlay's clone number
3045 matches the window's clone number process the overlay even if
3046 the overlay's window property doesn't match the current window.
3048 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3049 (Fwindow_hchild): Rename to Fwindow_left_child.
3050 (Fwindow_next): Rename to Fwindow_next_sibling.
3051 (Fwindow_prev): Rename to Fwindow_prev_sibling.
3052 (resize_window_check): Rename to window_resize_check.
3053 (resize_window_apply): Rename to window_resize_apply.
3054 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3055 (Fdelete_other_windows_internal, resize_frame_windows)
3056 (Fsplit_window_internal, Fdelete_window_internal)
3057 (grow_mini_window, shrink_mini_window)
3058 (Fresize_mini_window_internal): Fix callers accordingly.
3060 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3062 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3063 (emacs_fixed_set_min_size): Remove.
3064 (emacs_fixed_new): Take frame as argument.
3066 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3067 (_EmacsFixedPrivate): Remove minwidth/height.
3068 Add struct frame *f.
3069 (emacs_fixed_init): Initialize priv->f.
3070 (get_parent_class, emacs_fixed_set_min_size): Remove.
3071 (emacs_fixed_new): Set priv->f to argument.
3072 (emacs_fixed_get_preferred_width)
3073 (emacs_fixed_get_preferred_height): Use min_width/height from
3074 frames size_hint to set minimum and natural (Bug#8919).
3075 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3076 and use min_width/height from frames size_hint to set
3077 min_width/height (Bug#8919).
3079 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
3080 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3083 2011-06-26 Eli Zaretskii <eliz@gnu.org>
3085 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3086 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3089 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
3091 * process.c (wait_reading_process_output): Bypass select if
3092 waiting for a cell while ignoring keyboard input, and input is
3093 pending. Suggested by Jan Djärv (Bug#8869).
3095 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3097 Use gnulib's dup2 module instead of rolling our own.
3098 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3100 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3102 * dispnew.c (scrolling_window): Before scrolling, turn off a
3103 mouse-highlight in the window being scrolled.
3105 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
3107 Move DEFSYM to lisp.h and use everywhere.
3109 * character.h (DEFSYM): Move declaration...
3110 * lisp.h (DEFSYM): ...here.
3116 * w32select.c: Don't include character.h.
3118 * alloc.c (syms_of_alloc):
3119 * buffer.c (syms_of_buffer):
3120 * bytecode.c (syms_of_bytecode):
3121 * callint.c (syms_of_callint):
3122 * casefiddle.c (syms_of_casefiddle):
3123 * casetab.c (init_casetab_once):
3124 * category.c (init_category_once, syms_of_category):
3125 * ccl.c (syms_of_ccl):
3126 * cmds.c (syms_of_cmds):
3127 * composite.c (syms_of_composite):
3128 * dbusbind.c (syms_of_dbusbind):
3129 * dired.c (syms_of_dired):
3130 * dispnew.c (syms_of_display):
3131 * doc.c (syms_of_doc):
3132 * editfns.c (syms_of_editfns):
3133 * emacs.c (syms_of_emacs):
3134 * eval.c (syms_of_eval):
3135 * fileio.c (syms_of_fileio):
3136 * fns.c (syms_of_fns):
3137 * frame.c (syms_of_frame):
3138 * fringe.c (syms_of_fringe):
3139 * insdel.c (syms_of_insdel):
3140 * keymap.c (syms_of_keymap):
3141 * lread.c (init_obarray, syms_of_lread):
3142 * macros.c (syms_of_macros):
3143 * msdos.c (syms_of_msdos):
3144 * print.c (syms_of_print):
3145 * process.c (syms_of_process):
3146 * search.c (syms_of_search):
3147 * sound.c (syms_of_sound):
3148 * syntax.c (init_syntax_once, syms_of_syntax):
3149 * terminal.c (syms_of_terminal):
3150 * textprop.c (syms_of_textprop):
3151 * undo.c (syms_of_undo):
3152 * w32.c (globals_of_w32):
3153 * window.c (syms_of_window):
3154 * xdisp.c (syms_of_xdisp):
3155 * xfaces.c (syms_of_xfaces):
3156 * xfns.c (syms_of_xfns):
3157 * xmenu.c (syms_of_xmenu):
3158 * xsettings.c (syms_of_xsettings):
3159 * xterm.c (syms_of_xterm): Use DEFSYM.
3161 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3163 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
3165 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3167 Integer and buffer overflow fixes (Bug#8873).
3169 * print.c (printchar, strout): Check for string overflow.
3170 (PRINTPREPARE, printchar, strout):
3171 Don't set size unless allocation succeeds.
3173 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3174 for sizes. Check for string overflow more accurately.
3175 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3177 * macros.c: Integer and buffer overflow fixes.
3178 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3179 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3180 Use ptrdiff_t, not int, for sizes.
3181 Don't increment bufsize until after realloc succeeds.
3182 Check for size-calculation overflow.
3183 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3185 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3187 * lread.c: Integer overflow fixes.
3188 (read_integer): Radix is now EMACS_INT, not int,
3189 to improve quality of diagnostics for out-of-range radices.
3190 Calculate buffer size correctly for out-of-range radices.
3191 (read1): Check for integer overflow in radices, and in
3192 read-circle numbers.
3193 (read_escape): Avoid int overflow.
3194 (Fload, openp, read_buffer_size, read1)
3195 (substitute_object_recurse, read_vector, read_list, map_obarray):
3196 Use ptrdiff_t, not int, for sizes.
3197 (read1): Use EMACS_INT, not int, for sizes.
3198 Check for size overflow.
3200 * image.c (cache_image): Check for size arithmetic overflow.
3202 * lread.c: Integer overflow issues.
3203 (saved_doc_string_size, saved_doc_string_length)
3204 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3205 Now ptrdiff_t, not int.
3206 (read1): Don't assume doc string length fits in int. Check for
3207 out-of-range doc string lengths.
3208 (read_list): Don't assume file position fits in int.
3209 (read_escape): Check for hex character overflow.
3211 2011-06-22 Leo Liu <sdl.web@gmail.com>
3213 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3214 Move to minibuffer.el.
3216 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3218 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
3219 The following patches are for when GLYPH_DEBUG && !XASSERT.
3220 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3221 * dispnew.c (flush_stdout):
3222 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3223 Mark as externally visible.
3224 * dispnew.c (check_window_matrix_pointers): Now static.
3225 * dispnew.c (window_to_frame_vpos):
3226 * xfns.c (unwind_create_frame):
3227 * xterm.c (x_check_font): Remove unused local.
3228 * scroll.c (CHECK_BOUNDS):
3229 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3230 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3231 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3232 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3233 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3235 (debug_method_add): Use va_list and vsprintf rather than relying
3236 on undefined behavior with wrong number of arguments.
3237 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3238 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3239 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3240 since we're not interested in debugging glyphs with old libraries.
3241 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3242 GCC 4.6.0's static checking.
3244 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3246 Integer overflow and signedness fixes (Bug#8873).
3247 A few related buffer overrun fixes, too.
3249 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3251 * dispextern.h (struct face.stipple):
3252 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3253 (x_bitmap_mask, x_allocate_bitmap_record)
3254 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3255 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3256 (x_create_bitmap_from_xpm_data):
3257 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3258 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3260 * xfaces.c (load_pixmap):
3261 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3262 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3263 (.bitmaps_last, struct x_output.icon_bitmap):
3264 Use ptrdiff_t, not int, for bitmap indexes.
3265 (x_allocate_bitmap_record): Check for size overflow.
3266 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3268 Use ptrdiff_t, not int, for overlay counts.
3269 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3270 * editfns.c (overlays_around, get_pos_property):
3271 * textprop.c (get_char_property_and_overlay):
3272 * xdisp.c (next_overlay_change, note_mouse_highlight):
3273 * xfaces.c (face_at_buffer_position):
3274 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3275 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3276 (Fnext_overlay_change, Fprevious_overlay_change)
3277 (mouse_face_overlay_overlaps, Foverlays_in):
3278 Use ptrdiff_t, not int, for sizes.
3279 (overlays_at, overlays_in): Check for size-calculation overflow.
3281 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3283 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3284 (x_session_initialize): Do not assume string length fits in int.
3286 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3287 This is unlikely, but can occur if DPI is outlandish.
3289 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3290 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3292 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3293 * xrdb.c (magic_file_p, search_magic_path):
3294 Omit last arg SUFFIX; it was always 0. All callers changed.
3295 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3297 * xfont.c (xfont_match): Avoid need for strlen.
3299 * xfns.c: Don't assume strlen fits in int.
3300 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3302 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3303 not unsigned long, as we prefer signed integers. All callers changed.
3304 Detect integer overflow in repeat count.
3305 (message_dolog): Don't assume print length fits in 39 bytes.
3306 (display_mode_element): Don't assume strlen fits in int.
3308 * termcap.c: Don't assume sizes fit in int and never overflow.
3309 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3310 (gobble_line): Check for size-calculation overflow.
3312 * minibuf.c (Fread_buffer):
3313 * lread.c (intern, intern_c_string):
3314 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3315 Don't assume string length fits in int.
3317 * keyboard.c (parse_tool_bar_item):
3318 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3320 * font.c: Don't assume string length fits in int.
3321 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3322 Use ptrdiff_t, not int.
3323 (font_intern_prop): Don't assume string length fits in int.
3324 Don't assume integer property fits in fixnum.
3325 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3327 * filelock.c: Fix some buffer overrun and integer overflow issues.
3328 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3329 Reformulate so as not to need the command string.
3330 Invoke gzip -cd rather than gunzip, as it's more portable.
3331 (lock_info_type, lock_file_1, lock_file):
3332 Don't assume pid_t and time_t fit in unsigned long.
3333 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3334 (current_lock_owner): Prefer signed type for sizes.
3335 Use memcpy, not strncpy, where memcpy is what is really wanted.
3336 Don't assume (via atoi) that time_t and pid_t fit in int.
3337 Check for time_t and/or pid_t out of range, e.g., via a network share.
3338 Don't alloca where an auto var works fine.
3340 * fileio.c: Fix some integer overflow issues.
3341 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3342 Don't assume string length fits in int.
3343 (directory_file_name): Don't assume string length fits in long.
3344 (make_temp_name): Don't assume pid fits in int, or that its print
3345 length is less than 20.
3347 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3349 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3351 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3353 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3354 We prefer signed integers, even for size calculations.
3356 * emacs.c: Don't assume string length fits in 'int'.
3357 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3358 (main): Don't invoke strlen when not needed.
3360 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3361 (XD_DEBUG_MESSAGE): Don't waste a byte.
3363 * callproc.c (getenv_internal_1, getenv_internal)
3365 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3367 * lread.c (invalid_syntax): Omit length argument.
3368 All uses changed. This doesn't fix a bug, but it simplifies the
3369 code away from its former Hollerith-constant appearance, and it's
3370 one less 'int' to worry about when looking at integer-overflow issues.
3371 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3373 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3374 This didn't break anything, but it didn't help either.
3375 It's confusing to put a bogus integer in a place where the actual
3376 value does not matter.
3377 (LIST_END_P): Remove unused macro and its bogus comment.
3378 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3380 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3381 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3383 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3384 We prefer signed types, and the value cannot exceed the EMACS_INT
3385 range anyway (because otherwise the length would not be representable).
3386 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3387 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3388 This avoids a GCC warning when WIDE_EMACS_INT.
3390 * indent.c (sane_tab_width): New function.
3391 (current_column, scan_for_column, Findent_to, position_indentation)
3392 (compute_motion): Use it. This is just for clarity.
3393 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3395 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3397 * lisp.h (lint_assume): New macro.
3398 * composite.c (composition_gstring_put_cache):
3399 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3401 * editfns.c, insdel.c:
3402 Omit unnecessary forward decls, to simplify future changes.
3404 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3406 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3408 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3409 Use much-faster test for byte-length change.
3410 Don't assume string byte-length fits in 'int'.
3411 Check that character arg fits in 'int'.
3412 (mapcar1): Declare byte as byte, for clarity.
3414 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3416 * fns.c (concat): Catch string overflow earlier.
3417 Do not rely on integer wraparound.
3419 * dispextern.h (struct it.overlay_strings_charpos)
3420 (struct it.selective): Now EMACS_INT, not int.
3421 * xdisp.c (forward_to_next_line_start)
3422 (back_to_previous_visible_line_start)
3423 (reseat_at_next_visible_line_start, next_element_from_buffer):
3424 Don't arbitrarily truncate the value of 'selective' to int.
3426 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3428 * composite.c: Don't truncate sizes to 'int'.
3429 (composition_gstring_p, composition_reseat_it)
3430 (composition_adjust_point): Use EMACS_INT, not int.
3431 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3432 not EMACS_UINT, for indexes.
3434 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3436 * buffer.c: Include <verify.h>.
3437 (struct sortvec.priority, struct sortstr.priority):
3438 Now EMACS_INT, not int.
3439 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3440 (struct sortstr.size, record_overlay_string)
3441 (struct sortstrlist.size, struct sortlist.used):
3442 Don't truncate size to int.
3443 (record_overlay_string): Check for size-calculation overflow.
3444 (init_buffer_once): Check at compile-time, not run-time.
3446 2011-06-22 Jim Meyering <meyering@redhat.com>
3448 Don't leak an XBM-image-sized buffer
3449 * image.c (xbm_load): Free the image buffer after using it.
3451 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3454 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3455 that Sun C diagnosed.
3456 * fns.c (secure_hash): Fix pointer signedness issue.
3457 * intervals.c (static_offset_intervals): New function.
3458 (offset_intervals): Use it.
3460 2011-06-21 Leo Liu <sdl.web@gmail.com>
3463 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3466 * fns.c (secure_hash): Rename from crypto_hash_function and change
3467 the first arg to accept symbols.
3468 (Fsecure_hash): New primitive.
3469 (syms_of_fns): New symbols.
3471 2011-06-20 Deniz Dogan <deniz@dogan.se>
3473 * process.c (Fset_process_buffer): Clarify return value in
3476 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3478 * dispnew.c (add_window_display_history): Use BVAR.
3480 * xdisp.c (debug_method_add): Use BVAR.
3481 (check_window_end, dump_glyph_matrix, dump_glyph)
3482 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3484 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3487 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3488 check till after the cache is created in init_frame_faces.
3490 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3492 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3494 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3496 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3497 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3498 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3500 Improve buffer-overflow checking (Bug#8873).
3501 * fileio.c (Finsert_file_contents):
3502 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3503 Remove the old (too-loose) buffer overflow checks.
3504 They weren't needed, since make_gap checks for buffer overflow.
3505 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3506 The old code merely checked for Emacs fixnum overflow, and relied
3507 on undefined (wraparound) behavior. The new code avoids undefined
3508 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3510 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3511 Tune. Don't use wider integers than needed. Don't use alloca.
3512 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3514 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3516 * insdel.c, lisp.h (buffer_overflow): New function.
3517 (insert_from_buffer_1, replace_range, replace_range_2):
3518 * insdel.c (make_gap_larger):
3519 * editfns.c (Finsert_char):
3520 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3522 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3524 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3526 Integer overflow and signedness fixes (Bug#8873).
3528 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3529 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3531 * fileio.c: Don't assume EMACS_INT fits in off_t.
3532 (emacs_lseek): New static function.
3533 (Finsert_file_contents, Fwrite_region): Use it.
3534 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3536 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3538 * fns.c: Don't overflow int when computing a list length.
3539 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3540 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3541 truncation on 64-bit hosts. Check for QUIT every
3542 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3543 faster and is responsive enough.
3544 (Flength): Report an error instead of overflowing an integer.
3545 (Fsafe_length): Return a float if the value is not representable
3546 as a fixnum. This shouldn't happen except in contrived situations.
3547 (Fnthcdr, Fsort): Don't assume list length fits in int.
3548 (Fcopy_sequence): Don't assume vector length fits in int.
3550 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3551 (header_size, word_size): New constants.
3552 (allocate_vectorlike): Don't check size overflow here.
3553 (allocate_vector): Check it here instead, since this is the only
3554 caller of allocate_vectorlike that could cause overflow.
3555 Check that the new vector's length is representable as a fixnum.
3557 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3558 The previous code was bogus. For example, next_almost_prime (32)
3559 returned 39, which is undesirable as it is a multiple of 3; and
3560 next_almost_prime (24) returned 25, which is a multiple of 5 so
3561 why was the code bothering to check for multiples of 7?
3563 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3565 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3567 Variadic C functions now count arguments with ptrdiff_t.
3568 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3569 Back then I didn't know that the Emacs coding style prefers signed int.
3570 Also, in the meantime I found a few more instances where arguments
3571 were being counted with int, which may truncate counts on 64-bit
3572 machines, or EMACS_INT, which may be unnecessarily wide.
3573 * lisp.h (struct Lisp_Subr.function.aMANY)
3574 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3575 Arg counts are now ptrdiff_t, not size_t.
3576 All variadic functions and their callers changed accordingly.
3577 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3578 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3579 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3580 * callint.c (Fcall_interactively): Check arg count for overflow,
3581 to avoid potential buffer overrun. Use signed char, not 'int',
3582 for 'varies' array, so that we needn't bother to check its size
3583 calculation for overflow.
3584 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3585 * eval.c (apply_lambda):
3586 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3587 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3588 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3590 * callint.c (Fcall_interactively): Don't use index var as event count.
3592 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3593 * mem-limits.h (SIZE): Remove; no longer used.
3595 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3597 Remove unnecessary casts.
3598 * xterm.c (x_term_init):
3599 * xfns.c (x_set_border_pixel):
3600 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3601 These aren't needed now that we assume ANSI C.
3603 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3604 It's more likely to cause problems (due to unsigned overflow)
3607 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3609 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3611 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3613 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3615 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3617 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3619 GLYPH_CODE_FACE returns EMACS_INT, not int.
3620 * dispextern.h (merge_faces):
3621 * xfaces.c (merge_faces):
3622 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3623 Don't assume EMACS_INT fits in int.
3625 * character.h (CHAR_VALID_P): Remove unused parameter.
3626 * fontset.c, lisp.h, xdisp.c: All uses changed.
3628 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3630 * fns.c (concat): Minor tuning based on overflow analysis.
3631 This doesn't fix any bugs. Use int to hold character, instead
3632 of constantly refetching from Emacs object. Use XFASTINT, not
3633 XINT, for value known to be a character. Don't bother comparing
3634 a single byte to 0400, as it's always less.
3636 * floatfns.c (Fexpt):
3637 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3639 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3642 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3644 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3645 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3646 incorrectly succeed when S was a string, because 4294967386 was
3647 truncated before it was used.
3649 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3650 Otherwise, an out-of-range integer could cause undefined behavior
3653 * composite.c: Use int, not EMACS_INT, for characters.
3654 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3655 EMACS_INT, for values that are known to be in character range.
3656 This doesn't fix any bugs but is the usual style inside Emacs and
3657 may generate better code on 32-bit machines.
3659 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3660 This is for reasons similar to the recent CHAR_STRING fix.
3661 * charset.c (Fencode_char): Check that character arg is actually
3662 a character. Pass an int to ENCODE_CHAR.
3663 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3664 wider than 'int', as a compile-time check to prevent future regressions
3667 * character.c (char_string): Remove unnecessary casts.
3669 Make sure a 64-bit char is never passed to CHAR_STRING.
3670 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3671 by silently ignoring the top 32 bits, allowing some values
3672 that were far too large to be valid characters.
3673 * character.h: Include <verify.h>.
3674 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3675 arguments are no wider than unsigned, as a compile-time check
3676 to prevent future regressions in this area.
3678 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3679 (Fsubst_char_in_region):
3681 * xdisp.c (decode_mode_spec_coding):
3682 Adjust to CHAR_STRING's new requirement.
3683 * editfns.c (Finsert_char, Fsubst_char_in_region):
3684 * fns.c (concat): Check that character args are actually
3685 characters. Without this test, these functions did the wrong
3686 thing with wildly out-of-range values on 64-bit hosts.
3688 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3689 These casts should not be needed on 32-bit hosts, either.
3690 * keyboard.c (read_char):
3691 * lread.c (Fload): Remove casts to unsigned.
3693 * lisp.h (UNSIGNED_CMP): New macro.
3694 This fixes comparison bugs on 64-bit hosts.
3695 (ASCII_CHAR_P): Use it.
3696 * casefiddle.c (casify_object):
3697 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3698 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3699 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3700 * dispextern.h (FACE_FROM_ID):
3701 * keyboard.c (read_char): Use UNSIGNED_CMP.
3703 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3704 not to EMACS_INT, to avoid GCC warning.
3706 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3708 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3709 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3710 isn't needed on 32-bit machines.
3712 * buffer.c (Fgenerate_new_buffer_name):
3713 Use EMACS_INT for count, not int.
3714 (advance_to_char_boundary): Return EMACS_INT, not int.
3716 * data.c (Qcompiled_function): Now static.
3718 * window.c (window_body_lines): Now static.
3720 * image.c (gif_load): Rename local to avoid shadowing.
3722 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3723 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3724 * alloc.c (make_save_value): Integer argument is now of type
3726 (mark_object): Use ptrdiff_t, not int.
3727 * lisp.h (pD): New macro.
3728 * print.c (print_object): Use it.
3730 * alloc.c: Use EMACS_INT, not int, to count objects.
3731 (total_conses, total_markers, total_symbols, total_vector_size)
3732 (total_free_conses, total_free_markers, total_free_symbols)
3733 (total_free_floats, total_floats, total_free_intervals)
3734 (total_intervals, total_strings, total_free_strings):
3735 Now EMACS_INT, not int. All uses changed.
3736 (Fgarbage_collect): Compute overall total using a double, so that
3737 integer overflow is less likely to be a problem. Check for overflow
3738 when converting back to an integer.
3739 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3740 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3741 These were 'int' variables that could overflow on 64-bit hosts;
3742 they were never used, so remove them instead of repairing them.
3743 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3744 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3745 Previously, this ceilinged at INT_MAX, but that doesn't work on
3747 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3749 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3750 (allocate_vectorlike): Check for ptrdiff_t overflow.
3751 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3752 when a (possibly-narrower) signed value would do just as well.
3753 We prefer using signed arithmetic, to avoid comparison confusion.
3755 * alloc.c: Catch some string size overflows that we were missing.
3756 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3757 for convenience in STRING_BYTES_MAX.
3758 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3759 The definition here is exact; the one in lisp.h was approximate.
3760 (allocate_string_data): Check for string overflow. This catches
3761 some instances we weren't catching before. Also, it catches
3762 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3763 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3764 and ptrdiff_t and EMACS_INT are both 64 bits.
3766 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3767 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3768 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3770 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3772 * alloc.c (Fmake_string): Check for out-of-range init.
3774 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3776 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3778 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3780 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3781 xg_get_default_scrollbar_width.
3783 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3784 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3785 (style_changed_cb): Call update_theme_scrollbar_width and call
3786 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3787 all frames (Bug#8505).
3788 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3789 Call gtk_window_set_resizable if HAVE_GTK3.
3790 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3791 and height if HAVE_GTK3 (Bug#8505).
3792 (scroll_bar_width_for_theme): New variable.
3793 (update_theme_scrollbar_width): New function.
3794 (xg_get_default_scrollbar_width): Move code to
3795 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3796 (xg_initialize): Call update_theme_scrollbar_width.
3798 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3800 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3802 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3804 * frame.c (make_frame): Call other_buffer_safely instead of
3807 * window.c (temp_output_buffer_show): Call display_buffer with
3808 second argument Vtemp_buffer_show_specifiers and reset latter
3809 immediately after the call.
3810 (Vtemp_buffer_show_specifiers): New variable.
3811 (auto_window_vscroll_p, next_screen_context_lines)
3812 (Vscroll_preserve_screen_position): Remove leading asterisks from
3815 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3817 Fix minor problems found by GCC 4.6.0 static checking.
3818 * buffer.c (Qclone_number): Remove for now, as it's unused.
3819 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3820 (record_buffer): Remove unused local.
3821 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3822 (set_frame_buffer_list): Remove; unused.
3823 * frame.h (other_visible_frames): Remove decl.
3824 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3825 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3826 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3828 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3829 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3830 Define only if HAVE_GPM.
3831 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3832 (update_hints_inhibit): Remove; never set. All uses removed.
3833 * widgetprv.h (emacsFrameClassRec): Remove decl.
3834 * window.c (delete_deletable_window): Now returns void, since it
3835 wasn't returning anything.
3836 (compare_window_configurations): Remove unused locals.
3837 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3838 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3839 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3840 the same widths as pointers. This follows up on the 2011-05-06 patch.
3841 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3842 * xterm.h: Likewise.
3843 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3845 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3847 * makefile.w32-in: Update dependencies.
3848 (LISP_H): Add lib/intprops.h.
3850 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3852 * image.c (gif_load): Add animation frame delay to the metadata.
3853 (syms_of_image): Use DEFSYM. New symbol `delay'.
3855 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3857 * window.c (delete_deletable_window): Re-add.
3858 (Fset_window_configuration): Rewrite to handle dead buffers and
3859 consequently deletable windows.
3860 (window_tree, Fwindow_tree): Remove. Supply functionality in
3862 (compare_window_configurations): Simplify code.
3864 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3866 * image.c (imagemagick_load_image): Fix type mismatch.
3867 (Fimagemagick_types): Likewise.
3869 * window.h (replace_buffer_in_windows): Declare.
3871 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3873 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3874 Qclone_number. Remove external declaration of Qdelete_window.
3875 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3877 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3878 Run Qbuffer_list_update_hook if allowed.
3879 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3880 buffer list implementation.
3881 (other_buffer_safely): New function.
3882 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3883 calls to replace_buffer_in_windows and
3884 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3886 (record_buffer): Inhibit quitting and rewrite using quittable
3887 functions. Run Qbuffer_list_update_hook if allowed.
3888 (Frecord_buffer, Funrecord_buffer): New functions.
3889 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3890 Move switch-to-buffer to window.el.
3891 (bury-buffer): Move to window.el.
3892 (Vbuffer_list_update_hook): New variable.
3894 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3897 * window.h (resize_frame_windows): Move up in code.
3898 (Fwindow_frame): Remove EXFUN.
3899 (replace_buffer_in_all_windows): Remove prototype.
3900 (replace_buffer_in_windows_safely): Add prototype.
3902 * window.c: Declare Qdelete_window static again. Move down
3903 declaration of select_count.
3904 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3905 (Fother_window): Move to window.el.
3906 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3907 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3908 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3910 (replace_buffer_in_windows): Implement by calling
3911 Qreplace_buffer_in_windows.
3912 (replace_buffer_in_all_windows): Remove with some functionality
3913 moved into replace_buffer_in_windows_safely.
3914 (replace_buffer_in_windows_safely): New function.
3915 (select_window_norecord, select_frame_norecord): Move in front
3916 of run_window_configuration_change_hook. Remove now obsolete
3918 (Fset_window_buffer): Rewrite doc-string.
3919 Call Qrecord_window_buffer.
3920 (keys_of_window): Move binding for other-window to window.el.
3922 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3924 * dispextern.h (struct image): Replace data member, whose int_val
3925 and ptr_val fields were not used by anything, with a single
3928 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3929 (gif_clear_image, gif_load, imagemagick_load_image)
3930 (gs_clear_image, gs_load): Callers changed.
3932 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3934 * buffer.h: Include <time.h>, for time_t.
3935 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3937 Fix minor problems found by static checking.
3939 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3941 Make identifiers static if they are not used in other modules.
3942 * data.c (Qcompiled_function, Qframe, Qvector):
3943 * image.c (QimageMagick, Qsvg):
3944 * minibuf.c (Qmetadata):
3945 * window.c (resize_window_check, resize_root_window): Now static.
3946 * window.h (resize_window_check, resize_root_window): Remove decls.
3948 * window.c (window_deletion_count, delete_deletable_window):
3950 (window_body_lines): Now static.
3951 (Fdelete_other_windows_internal): Mark vars as initialized.
3952 Make sure 'resize_failed' is initialized.
3953 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3954 (resize_window_apply): Remove unused local.
3955 * window.h (delete_deletable_window): Remove decl.
3957 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3958 (imagemagick_load_image): Fix pointer signedness problem by changing
3959 last arg from unsigned char * to char *. All uses changed.
3960 Also, fix a local for similar reasons.
3961 Remove unused locals. Remove locals to avoid shadowing.
3962 (fn_rsvg_handle_free): Remove; unused.
3963 (svg_load, svg_load_image): Fix pointer signedness problem.
3964 (imagemagick_load_image): Don't use garbage pointer image_wand.
3966 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3968 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3970 * image.c (gif_load): Fix omitted cast error introduced by
3973 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3975 * window.h (resize_proportionally, orig_total_lines)
3976 (orig_top_line): Remove from window structure.
3977 (set_window_height, set_window_width, change_window_heights)
3978 (Fdelete_window): Remove prototypes.
3979 (resize_frame_windows): Remove duplicate declaration.
3981 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3983 * window.h (resize_frame_windows, resize_window_check)
3984 (delete_deletable_window, resize_root_window)
3985 (resize_frame_windows): Declare prototypes.
3987 * window.c (resize_window_apply): Make definition be "static" to
3988 match the prototype.
3990 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3992 * window.c: Remove declarations of Qwindow_size_fixed,
3993 window_min_size_1, window_min_size_2, window_min_size,
3994 size_window, window_fixed_size_p, enlarge_window, delete_window.
3995 Remove static from declaration of Qdelete_window, it's
3996 temporarily needed by Fbury_buffer.
3997 (replace_window): Don't assign orig_top_line and
3999 (Fdelete_window, delete_window): Remove. Window deletion is
4000 handled by window.el.
4001 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4002 Replace Fdelete_window calls with calls to Qdelete_window.
4003 (Fdelete_other_windows): Remove. Deleting other windows is
4004 handled by window.el.
4005 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4006 handled in window.el.
4007 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4008 Window minimum sizes are handled in window.el.
4009 (shrink_windows, size_window, set_window_height)
4010 (set_window_width, change_window_heights, window_height)
4011 (window_width, CURBEG, CURSIZE, enlarge_window)
4012 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4013 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4014 handled in window.el.
4015 (make_dummy_parent): Rename to make_parent_window and give it a
4016 second argument horflag.
4017 (make_window): Don't set resize_proportionally any more.
4018 (Fsplit_window): Remove. Windows are split in window.el.
4019 (save_restore_action, save_restore_orig_size)
4020 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4021 Resize mini windows in window.el.
4022 (grow_mini_window, shrink_mini_window): Implement by calling
4023 Qresize_root_window_vertically, resize_window_check and
4024 resize_window_apply.
4025 (saved_window, Fset_window_configuration, save_window_save):
4026 Do not handle orig_top_line, orig_total_lines, and
4027 resize_proportionally.
4028 (window_min_height, window_min_width): Move to window.el.
4029 (keys_of_window): Move bindings for delete-other-windows,
4030 split-window, delete-window and enlarge-window to window.el.
4032 * buffer.c: Temporarily extern Qdelete_window.
4033 (Fbury_buffer): Temporarily call Qdelete_window instead of
4034 Fdelete_window (Fbury_buffer will move to window.el soon).
4036 * frame.c (set_menu_bar_lines_1): Remove code handling
4037 orig_top_line and orig_total_lines.
4039 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4040 set_window_height but set heights directly.
4041 (change_frame_size_1): Use resize_frame_windows.
4043 * xdisp.c (init_xdisp): Don't use set_window_height but set
4046 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4047 Use resize_frame_windows instead of change_window_heights and run
4048 run_window_configuration_change_hook.
4050 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4051 instead of change_window_heights and run
4052 run_window_configuration_change_hook.
4054 2011-06-09 Martin Rudalics <rudalics@gmx.at>
4056 * window.c (replace_window): Rename second argument REPLACEMENT to
4057 NEW. New third argument SETFLAG. Rewrite.
4058 (delete_window, make_dummy_parent): Call replace_window with
4060 (window_list_1): Move down in code.
4061 (run_window_configuration_change_hook): Move set_buffer part
4062 before select_frame_norecord part in order to unwind correctly.
4063 Rename count1 to count.
4064 (recombine_windows, delete_deletable_window, resize_root_window)
4065 (Fdelete_other_windows_internal)
4066 (Frun_window_configuration_change_hook, make_parent_window)
4067 (resize_window_check, resize_window_apply, Fresize_window_apply)
4068 (resize_frame_windows, Fsplit_window_internal)
4069 (Fdelete_window_internal, Fresize_mini_window_internal):
4071 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4073 2011-06-08 Martin Rudalics <rudalics@gmx.at>
4075 * window.h (window): Add some new members to window structure -
4076 normal_lines, normal_cols, new_total, new_normal, clone_number,
4077 splits, nest, prev_buffers, next_buffers.
4078 (WINDOW_TOTAL_SIZE): Move here from window.c.
4079 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
4081 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4083 (make_dummy_parent): Set new members of windows structure.
4084 (make_window): Move down in code. Handle new members of window
4086 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4087 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4088 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4089 (Fset_window_prev_buffers, Fwindow_next_buffers)
4090 (Fset_window_next_buffers, Fset_window_clone_number):
4092 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4093 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4095 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4096 Argument WINDOW can be now internal window too.
4097 (Fwindow_use_time): Move up in code.
4098 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4100 (Fset_window_configuration, saved_window)
4101 (Fcurrent_window_configuration, save_window_save): Handle new
4102 members of window structure.
4103 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4104 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4105 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4106 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4107 Qget_mru_window, Qresize_root_window,
4108 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4109 Qauto_buffer_name; staticpro them.
4111 2011-06-07 Martin Rudalics <rudalics@gmx.at>
4113 * window.c (Fwindow_total_size, Fwindow_left_column)
4114 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4115 (Fwindow_list_1): New functions.
4116 (window_box_text_cols): Replace with window_body_cols.
4117 (Fwindow_width, Fscroll_left, Fscroll_right):
4118 Use window_body_cols instead of window_box_text_cols.
4119 (delete_window, Fset_window_configuration):
4120 Call delete_all_subwindows with window as argument.
4121 (delete_all_subwindows): Take a window as argument and not a
4123 (window_loop): Remove handling of GET_LRU_WINDOW and
4125 (Fget_lru_window, Fget_largest_window): Move to window.el.
4127 * window.h: Extern window_body_cols instead of
4128 window_box_text_cols. delete_all_subwindows now takes a
4129 Lisp_Object as argument.
4131 * indent.c (compute_motion, Fcompute_motion):
4132 Use window_body_cols instead of window_box_text_cols.
4134 * frame.c (delete_frame): Call delete_all_subwindows with root
4137 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4139 * fns.c (Fputhash): Document return value.
4141 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
4143 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4145 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4147 Cons<->int and similar integer overflow fixes (Bug#8794).
4149 Check for overflow when converting integer to cons and back.
4150 * charset.c (Fdefine_charset_internal, Fdecode_char):
4151 Use cons_to_unsigned to catch overflow.
4152 (Fencode_char): Use INTEGER_TO_CONS.
4153 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4154 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4155 * data.c (long_to_cons, cons_to_long): Remove.
4156 (cons_to_unsigned, cons_to_signed): New functions.
4157 These signal an error for invalid or out-of-range values.
4158 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4159 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4160 * font.c (Ffont_variation_glyphs):
4161 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4162 * lisp.h: Include <intprops.h>.
4163 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4164 (cons_to_signed, cons_to_unsigned): New decls.
4165 (long_to_cons, cons_to_long): Remove decls.
4166 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4167 (Fprimitive_undo): Use CONS_TO_INTEGER.
4168 * xfns.c (Fx_window_property): Likewise.
4169 * xselect.c: Include <limits.h>.
4170 (x_own_selection, selection_data_to_lisp_data):
4171 Use INTEGER_TO_CONS.
4172 (x_handle_selection_request, x_handle_selection_clear)
4173 (x_get_foreign_selection, Fx_disown_selection_internal)
4174 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4175 (lisp_data_to_selection_data): Use cons_to_unsigned.
4176 (x_fill_property_data): Use cons_to_signed.
4177 Report values out of range.
4179 Check for buffer and string overflow more precisely.
4180 * buffer.h (BUF_BYTES_MAX): New macro.
4181 * lisp.h (STRING_BYTES_MAX): New macro.
4182 * alloc.c (Fmake_string):
4183 * character.c (string_escape_byte8):
4184 * coding.c (coding_alloc_by_realloc):
4185 * doprnt.c (doprnt):
4186 * editfns.c (Fformat):
4188 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4189 since they may not be the same number.
4190 * editfns.c (Finsert_char):
4191 * fileio.c (Finsert_file_contents):
4192 Likewise for BUF_BYTES_MAX.
4194 * image.c: Use ptrdiff_t, not int, for sizes.
4195 (slurp_file): Switch from int to ptrdiff_t.
4197 (slurp_file): Check that file size fits in both size_t (for
4198 malloc) and ptrdiff_t (for sanity and safety).
4200 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4201 if b->modtime has its maximal value.
4203 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4205 Don't assume time_t can fit into int.
4206 * buffer.h (struct buffer.modtime): Now time_t, not int.
4207 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4208 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4210 Minor fixes for signed vs unsigned integers.
4211 * character.h (MAYBE_UNIFY_CHAR):
4212 * charset.c (maybe_unify_char):
4213 * keyboard.c (read_char, reorder_modifiers):
4214 XINT -> XFASTINT, since the integer must be nonnegative.
4215 * ftfont.c (ftfont_spec_pattern):
4216 * keymap.c (access_keymap, silly_event_symbol_error):
4217 XUINT -> XFASTINT, since the integer must be nonnegative.
4218 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4219 since it makes no difference and we prefer signed.
4220 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4221 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4224 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4226 * window.h (Fwindow_frame): Declare.
4228 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4230 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4231 (SPARE_MEMORY): Always define.
4232 (LARGE_REQUEST): Remove.
4233 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4235 2011-06-06 Martin Rudalics <rudalics@gmx.at>
4237 * lisp.h: Move EXFUNS for Fframe_root_window,
4238 Fframe_first_window and Fset_frame_selected_window to window.h.
4240 * window.h: Move EXFUNS for Fframe_root_window,
4241 Fframe_first_window and Fset_frame_selected_window here from
4244 * frame.c (Fwindow_frame, Fframe_first_window)
4245 (Fframe_root_window, Fframe_selected_window)
4246 (Fset_frame_selected_window): Move to window.c.
4247 (Factive_minibuffer_window): Move to minibuf.c.
4248 (Fother_visible_frames_p): New function.
4250 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4252 * window.c (decode_window, decode_any_window): Move up in code.
4253 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4254 (inhibit_frame_unsplittable): Remove unused variable.
4255 (Fwindow_buffer): Move up and rewrite doc-string.
4256 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4257 (Fwindow_prev): New functions.
4258 (Fwindow_frame): Move here from frame.c. Accept any window as
4260 (Fframe_root_window, Fframe_first_window)
4261 (Fframe_selected_window): Move here from frame.c. Accept frame
4262 or arbitrary window as argument. Update doc-strings.
4263 (Fminibuffer_window): Move up in code.
4264 (Fwindow_minibuffer_p): Move up in code and simplify.
4265 (Fset_frame_selected_window): Move here from frame.c.
4267 (Fselected_window, select_window, Fselect_window): Move up in
4268 code. Minor doc-string fixes.
4270 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4272 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4273 Do not assume that spare memory exists; that assumption is valid
4274 only if SYSTEM_MALLOC.
4275 (LARGE_REQUEST): New macro, so that the issue of large requests
4276 is separated from the issue of spare memory.
4278 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4280 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4283 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4285 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4288 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4290 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4292 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4294 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4295 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4297 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
4299 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4301 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
4303 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4304 (x_clipboard_manager_save): Add return value.
4305 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4307 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4308 Obey Vx_select_enable_clipboard_manager. Catch errors in
4309 x_clipboard_manager_save (Bug#8779).
4310 (Vx_select_enable_clipboard_manager): New variable.
4311 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4313 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4315 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4317 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4319 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4320 in the current matrix if keep_current_p is non-zero.
4322 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4324 * bidi.c (bidi_level_of_next_char): Fix last change.
4326 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4328 Support bidi reordering of text covered by display properties.
4330 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4331 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4332 (bidi_cache_search, bidi_cache_iterator_state)
4333 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4334 (bidi_level_of_next_char, bidi_move_to_visually_next):
4335 Support character positions inside a run of characters covered by a
4337 (bidi_paragraph_init, bidi_resolve_explicit_1)
4338 (bidi_level_of_next_char): Call bidi_fetch_char and
4339 bidi_fetch_char_advance instead of FETCH_CHAR and
4341 (bidi_init_it): Initialize new members.
4342 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4344 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4345 instead of using explicit *_CHAR codes.
4346 (bidi_resolve_explicit, bidi_resolve_weak):
4347 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4348 bidirectional text is supported only in multibyte buffers.
4349 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4350 it to initialize the frame_window_p member of struct bidi_it.
4351 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4352 (bidi_resolve_explicit, bidi_resolve_weak)
4353 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4354 bidi_it->nchars is non-positive.
4355 (bidi_level_of_next_char): Don't try to lookup the cache for the
4356 next/previous character if nothing is cached there yet, or if we
4357 were just reseat()'ed to a new position.
4359 * xdisp.c (set_cursor_from_row): Set start and stop points
4360 according to the row's direction when priming the loop that looks
4361 for the glyph on which to display cursor.
4362 (single_display_spec_intangible_p): Function deleted.
4363 (display_prop_intangible_p): Reimplement to call
4364 handle_display_spec instead of single_display_spec_intangible_p.
4365 Accept 3 additional arguments needed by handle_display_spec.
4366 This fixes incorrect cursor motion across display property with complex
4367 values: lists, `(when COND...)' forms, etc.
4368 (single_display_spec_string_p): Support property values that are
4369 lists with the argument STRING its top-level element.
4370 (display_prop_string_p): Fix the condition for processing a
4371 property that is a list to be consistent with handle_display_spec.
4372 (handle_display_spec): New function, refactored from the
4373 last portion of handle_display_prop.
4374 (compute_display_string_pos): Accept additional argument
4375 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4376 value of a `display' property is a "replacing spec".
4377 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4378 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4379 the display property, but just return a value indicating whether
4380 the display property will replace the characters it covers.
4381 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4382 frame_window_p members of struct bidi_it.
4383 (compute_display_string_pos, compute_display_string_end):
4385 (push_it): Accept second argument POSITION, where pop_it should
4386 jump to continue iteration.
4387 (reseat_1): Initialize bidi_it.disp_pos.
4389 * keyboard.c (adjust_point_for_property): Adjust the call to
4390 display_prop_intangible_p to its new signature.
4392 * dispextern.h (struct bidi_it): New member frame_window_p.
4393 (bidi_init_it): Update prototypes.
4394 (display_prop_intangible_p): Update prototype.
4395 (compute_display_string_pos, compute_display_string_end):
4397 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4400 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4402 Malloc failure behavior now depends on size of allocation.
4403 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4404 * lisp.h: Change signatures accordingly.
4405 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4406 All callers changed. (Bug#8762)
4408 * gnutls.c: Use Emacs's memory allocators.
4409 Without this change, the gnutls library would invoke malloc etc.
4410 directly, which causes problems on non-SYNC_INPUT hosts, and which
4411 runs afoul of improving memory_full behavior. (Bug#8761)
4412 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4413 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4414 xfree instead of the default malloc, realloc, free.
4415 (Fgnutls_boot): No need to check for memory allocation failure,
4416 since xmalloc does that for us.
4418 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4419 * category.c (hash_get_category_set):
4420 * ccl.c (ccl_driver):
4421 * charset.c (Fdefine_charset_internal):
4422 * charset.h (struct charset.hash_index):
4423 * composite.c (get_composition_id, gstring_lookup_cache)
4424 (composition_gstring_put_cache):
4425 * composite.h (struct composition.hash_index):
4426 * dispextern.h (struct image.hash):
4427 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4428 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4429 (hashfn_equal, hashfn_user_defined, make_hash_table)
4430 (maybe_resize_hash_table, hash_lookup, hash_put)
4431 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4432 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4433 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4434 * image.c (make_image, search_image_cache, lookup_image)
4435 (xpm_put_color_table_h):
4436 * lisp.h (struct Lisp_Hash_Table):
4437 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4438 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4439 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4440 * alloc.c (allocate_vectorlike):
4441 Check for overflow in vector size calculations.
4442 * ccl.c (ccl_driver):
4443 Check for overflow when converting EMACS_INT to int.
4444 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4445 need to be updated by these changes.
4446 * fns.c (make_hash_table, maybe_resize_hash_table):
4447 Check for integer overflow with large hash tables.
4448 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4449 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4450 (SXHASH_REDUCE): New macro.
4451 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4452 Use it instead of discarding useful hash info with large hash values.
4453 (sxhash_float): New function.
4454 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4455 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4456 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4457 Rewrite to use FIXNUM_BITS, as this simplifies things.
4458 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4459 Adjust signatures to match updated version of code.
4460 (consing_since_gc): Now EMACS_INT, since a single hash table can
4461 use more than INT_MAX bytes.
4463 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4465 Make it possible to build with GCC-4.6+ -O2 -flto.
4467 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4469 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4471 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4472 Call minibuffer-inactive-mode.
4474 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4476 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4477 Update dependencies.
4479 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4481 * data.c (init_data): Remove code for UTS, this system is not
4484 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4486 Don't force ./temacs to start in terminal mode.
4488 * frame.c (make_initial_frame): Initialize faces in all cases, not
4489 only when CANNOT_DUMP is defined.
4490 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4492 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4494 * dispnew.c (add_window_display_history): Use const for the string
4495 pointer. Remove declaration, not needed.
4497 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4499 Use 'inline', not 'INLINE'.
4500 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4501 * alloc.c, fontset.c (INLINE): Remove.
4502 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4503 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4504 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4505 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4506 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4508 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4510 Make it possible to run ./temacs.
4512 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4513 syms_of_callproc does the same thing. Remove test for
4514 "initialized", do it in the caller.
4515 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4517 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4519 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4520 (read_minibuf): Use get_minibuffer.
4521 (syms_of_minibuf): Use DEFSYM.
4522 (Qmetadata): New var.
4523 * data.c (Qbuffer): Don't make it static.
4524 (syms_of_data): Use DEFSYM.
4526 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4528 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4529 (CCL_CODE_MIN): New macro.
4531 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4533 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4535 * eval.c (Qdebug): Now static.
4536 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4537 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4538 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4540 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4542 * image.c: Various fixes to ImageMagick code comments.
4543 (Fimagemagick_types): Doc fix.
4545 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4547 Minor fixes prompted by GCC 4.6.0 warnings.
4549 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4551 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4552 (x_clipboard_manager_save_all): Move extern decl to ...
4553 * xterm.h: ... here, so that it can be checked for consistency.
4555 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4557 * xselect.c (x_clipboard_manager_save_frame)
4558 (x_clipboard_manager_save_all): New functions.
4559 (Fx_clipboard_manager_save): Lisp function deleted.
4561 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4562 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4564 * xterm.h: Update prototype.
4566 2011-05-28 William Xu <william.xwl@gmail.com>
4568 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4571 2011-05-28 Jim Meyering <meyering@redhat.com>
4573 Avoid a sign-extension bug in crypto_hash_function.
4574 * fns.c (to_uchar): Define.
4575 (crypto_hash_function): Use it to convert some newly-signed
4576 variables to unsigned, to avoid sign-extension bugs. For example,
4577 without this change, (md5 "truc") would evaluate to
4578 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4579 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4580 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4582 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4584 Integer overflow fixes.
4586 * dbusbind.c: Serial number integer overflow fixes.
4587 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4588 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4589 to hold a serial number that is too large for a fixnum.
4590 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4591 Check for serial numbers out of range. Decode any serial number
4592 that was so large that it became a float. (Bug#8722)
4594 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4595 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4596 Use XFASTINT rather than XUINT when numbers are nonnegative.
4597 (xd_append_arg, Fdbus_method_return_internal):
4598 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4599 arguments, check that Lisp number is nonnegative, rather than
4600 silently wrapping negative numbers around. (Bug#8722)
4601 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4604 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4606 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4608 ccl: add integer overflow checks
4609 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4610 (IN_INT_RANGE): New macros.
4611 (ccl_driver): Use them to check for integer overflow when
4612 decoding a CCL program. Many of the new checks are whether XINT (x)
4613 fits in int; it doesn't always, on 64-bit hosts. The new version
4614 doesn't catch all possible integer overflows, but it's an
4615 improvement. (Bug#8719)
4617 * alloc.c (make_event_array): Use XINT, not XUINT.
4618 There's no need for unsigned here.
4620 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4621 This follows up to the 2011-05-06 change that substituted uintptr_t
4622 for EMACS_INT. This case wasn't caught back then.
4624 Rework Fformat to avoid integer overflow issues.
4625 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4626 now (part of C89). Include <verify.h>.
4627 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4628 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4629 (Fformat): Avoid the prepass trying to compute sizes; it was only
4630 approximate and thus did not catch overflow reliably. Instead, walk
4631 through the format just once, formatting and computing sizes as we go,
4632 checking for integer overflow at every step, and allocating a larger
4633 buffer as needed. Keep track separately whether the format is
4634 multibyte. Keep only the most-recently calculated precision, rather
4635 than them all. Record whether each argument has been converted to
4636 string. Use EMACS_INT, not int, for byte and char and arg counts.
4637 Support field widths and precisions larger than INT_MAX. Avoid
4638 sprintf's undefined behavior with conversion specifications such as %#d
4639 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4640 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4641 formatting out-of-range floating point numbers with int
4644 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4646 * data.c: Avoid integer truncation in expressions involving floats.
4647 * data.c: Include <intprops.h>.
4648 (arith_driver): When there's an integer overflow in an expression
4649 involving floating point, convert the integers to floating point
4650 so that the resulting value does not suffer from catastrophic
4651 integer truncation. For example, on a 64-bit host (* 4
4652 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4653 Do not rely on undefined behavior after integer overflow.
4655 merge count_size_as_multibyte, parse_str_to_multibyte
4656 * character.c, character.h (count_size_as_multibyte):
4657 Rename from parse_str_to_multibyte; all uses changed.
4658 Check for integer overflow.
4659 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4660 since it's now a duplicate of the other. This is more of
4661 a character than a buffer op, so better that it's in character.c.
4662 * fns.c, print.c: Adjust to above changes.
4664 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4666 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4668 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4670 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4671 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4672 (x_clipboard_manager_save): Now static.
4673 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4675 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4676 (crypto_hash_function): Now static.
4677 Fix pointer signedness problems. Avoid unnecessary initializations.
4679 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4681 * termhooks.h (Vselection_alist): Make it terminal-local.
4683 * terminal.c (create_terminal): Initialize it.
4685 * xselect.c: Support for clipboard managers.
4686 (Vselection_alist): Move to termhooks.h as terminal-local var.
4687 (LOCAL_SELECTION): New macro.
4688 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4689 (symbol_to_x_atom): Remove gratuitous arg.
4690 (x_handle_selection_request, lisp_data_to_selection_data)
4691 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4692 (x_own_selection, x_get_local_selection, x_convert_selection):
4693 New arg, specifying work frame. Use terminal-local Vselection_alist.
4694 (some_frame_on_display): Delete unused function.
4695 (Fx_own_selection_internal, Fx_get_selection_internal)
4696 (Fx_disown_selection_internal, Fx_selection_owner_p)
4697 (Fx_selection_exists_p): New optional frame arg.
4698 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4699 (x_handle_selection_clear): Don't treat other terminals with the
4700 same keyboard specially. Use the terminal-local Vselection_alist.
4701 (x_clear_frame_selections): Use Frun_hook_with_args.
4703 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4705 * xterm.h: Add support for those atoms.
4707 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4709 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4710 (converted_selections, conversion_fail_tag): New global variables.
4711 (x_selection_request_lisp_error): Free the above.
4712 (x_get_local_selection): Remove unnecessary code.
4713 (x_reply_selection_request): Args changed; handle arbitrary array
4714 of converted selections stored in converted_selections.
4715 Separate the XChangeProperty and SelectionNotify steps.
4716 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4717 (x_convert_selection): New function.
4718 (x_handle_selection_event): Simplify.
4719 (x_get_foreign_selection): Don't ignore incoming requests while
4720 waiting for an answer; this will fail when we implement
4721 SAVE_TARGETS, and seems unnecessary anyway.
4722 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4723 (Vx_sent_selection_functions): Doc fix.
4725 2011-05-26 Leo Liu <sdl.web@gmail.com>
4727 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4729 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4731 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4733 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4734 for fringe update if it has periodic bitmap.
4735 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4736 and fringe_bitmap_periodic_p.
4738 * fringe.c (get_fringe_bitmap_data): New function.
4739 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4740 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4741 row. Mark glyph row for fringe update if periodicity changed.
4743 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4744 for fringe update unless it has periodic bitmap.
4746 2011-05-25 Kenichi Handa <handa@m17n.org>
4748 * xdisp.c (get_next_display_element): Set correct it->face_id for
4749 a static composition.
4751 2011-05-24 Leo Liu <sdl.web@gmail.com>
4754 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4756 * fns.c (crypto_hash_function, Fsha1): New function.
4757 (Fmd5): Use crypto_hash_function.
4758 (syms_of_fns): Add Ssha1.
4760 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4762 * gnutls.c: Remove unused macros.
4763 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4764 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4765 Remove macros that are defined and never used.
4766 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4768 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4770 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4771 (Fx_get_selection_internal): Minor cleanup.
4772 (Fx_own_selection_internal): Rename arguments for consistency with
4775 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4777 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4779 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4781 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4783 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4785 * dispnew.c (scrolling_window): Don't exclude the case that the
4786 last enabled row in the desired matrix touches the bottom boundary.
4788 2011-05-21 Glenn Morris <rgm@gnu.org>
4790 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4791 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4792 and add some more files.
4794 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4796 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4797 report_file_error introduced by the change from 2011-05-07.
4799 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4801 * systime.h (Time): Define only if emacs is defined.
4802 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4803 where the include path doesn't have X11/X.h by default. See
4804 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4806 2011-05-20 Kenichi Handa <handa@m17n.org>
4808 * composite.c (find_automatic_composition): Fix previous change.
4810 2011-05-20 Glenn Morris <rgm@gnu.org>
4812 * lisp.mk: New file, split from Makefile.in.
4813 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4814 (shortlisp): Remove.
4815 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4817 2011-05-19 Glenn Morris <rgm@gnu.org>
4819 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4820 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4821 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4822 (lisp): Set the order to that of loadup.el.
4823 (shortlisp): Make it a copy of $lisp.
4824 (SOME_MACHINE_LISP): Remove.
4825 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4826 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4828 2011-05-18 Kenichi Handa <handa@m17n.org>
4830 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4831 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4832 (find_automatic_composition): Mostly rewrite for efficiency.
4834 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4836 * makefile.w32-in: Update dependencies.
4838 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4840 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4841 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4843 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4845 Fix some integer overflow issues, such as string length overflow.
4847 * insdel.c (count_size_as_multibyte): Check for string overflow.
4849 * character.c (lisp_string_width): Check for string overflow.
4850 Use EMACS_INT, not int, for string indexes and lengths; in
4851 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4852 the resulting string length overflows an EMACS_INT; instead,
4853 report a string overflow if no precision given. When checking for
4854 precision exhaustion, use a check that cannot possibly have
4855 integer overflow. (Bug#8675)
4856 * character.h (lisp_string_width): Adjust to new signature.
4858 * alloc.c (string_overflow): New function.
4859 (Fmake_string): Use it. This doesn't change behavior, but saves
4860 a few bytes and will simplify future changes.
4861 * character.c (string_escape_byte8): Likewise.
4862 * lisp.h (string_overflow): New decl.
4864 Fixups, following up to the user-interface timestamp change.
4865 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4866 for UI timestamps, instead of unsigned long.
4867 * msdos.c (mouse_get_pos): Likewise.
4868 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4869 * w32gui.h (Time): Define by including "systime.h" rather than by
4870 declaring it ourselves. (Bug#8664)
4872 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4873 * image.c (clear_image_cache): Likewise.
4875 * term.c (term_mouse_position): Don't assume time_t wraparound.
4877 Be more systematic about user-interface timestamps.
4878 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4879 and sometimes 'EMACS_UINT', to represent these timestamps.
4880 This change causes it to use 'Time' uniformly, as that's what X uses.
4881 This makes the code easier to follow, and makes it easier to catch
4882 integer overflow bugs such as Bug#8664.
4883 * frame.c (Fmouse_position, Fmouse_pixel_position):
4884 Use Time, not unsigned long, for user-interface timestamps.
4885 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4886 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4887 * keyboard.h (last_event_timestamp): Likewise.
4888 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4889 * menu.h (xmenu_show): Likewise.
4890 * term.c (term_mouse_position): Likewise.
4891 * termhooks.h (struct input_event.timestamp): Likewise.
4892 (struct terminal.mouse_position_hook): Likewise.
4893 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4894 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4895 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4896 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4898 * menu.h, termhooks.h: Include "systime.h", for Time.
4900 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4901 Don't assume that the difference between two unsigned long values
4902 can fit into an integer. At this point, we know button_down_time
4903 <= event->timestamp, so the difference must be nonnegative, so
4904 there's no need to cast the result if double-click-time is
4905 nonnegative, as it should be; check that it's nonnegative, just in
4906 case. This bug is triggered when events are more than 2**31 ms
4907 apart (about 25 days). (Bug#8664)
4909 * xselect.c (last_event_timestamp): Remove duplicate decl.
4910 (x_own_selection): Remove needless cast to unsigned long.
4912 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4913 that always fit in int. Use a sentinel instead of a counter, to
4914 avoid a temp and to allay GCC's concerns about possible int overflow.
4915 * frame.h (struct frame): Use int for menu_bar_items_used
4916 instead of EMACS_INT, since it always fits in int.
4918 * menu.c (grow_menu_items): Check for int overflow.
4920 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4922 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4923 Before, the code was not consistent. These values cannot exceed
4924 2**31 - 1 so there's no need to make them unsigned.
4925 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4926 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4927 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4929 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4931 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4932 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4933 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4934 presumably because the widths might not match.
4936 * window.c (size_window): Avoid needless test at loop start.
4938 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4940 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4942 2011-05-12 Drew Adams <drew.adams@oracle.com>
4944 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4946 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4948 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4949 `width' to `bar_area_x' and `bar_area_width', respectively.
4950 (x_scroll_run): Take account of fringe background extension.
4952 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4953 Rename local vars `left' and `width' to `bar_area_x' and
4954 `bar_area_width', respectively.
4955 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4956 background extension.
4958 2011-05-10 Jim Meyering <meyering@redhat.com>
4960 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4962 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4964 * image.c (Finit_image_library): Return t for built-in image types,
4965 like pbm and xbm. (Bug#8640)
4967 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4969 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4971 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4973 * w32console.c (Fset_screen_color): Doc fix.
4974 (Fget_screen_color): New function.
4975 (syms_of_ntterm): Defsubr it.
4977 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4978 unlink the temporary file if Fcall_process didn't create it in the
4980 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4981 child process will be redirected to a file specified with `:file'.
4982 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4983 cue to call_process_cleanup not to close that handle.
4985 2011-05-07 Ben Key <bkey76@gmail.com>
4987 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4988 one of two shell specific rules, either bootstrap-temacs-CMD or
4989 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4990 to the previous implementation of the bootstrap-temacs rule.
4991 The bootstrap-temacs-CMD rule is similar to the previous
4992 implementation of the bootstrap-temacs rule except that it
4993 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4996 These changes, along with some changes to nt/configure.bat,
4997 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4998 earlier fix to add support for --cflags and --ldflags options
4999 that include quotes so that it works whether make uses cmd or
5002 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
5004 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5005 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5007 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5008 a string. Handle both cases.
5009 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5010 (Fdbus_register_method): Use Qinvalid_function.
5012 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5014 * makefile.w32-in: Update dependencies.
5015 (LISP_H): Add inttypes.h and stdin.h.
5016 (PROCESS_H): Add unistd.h.
5018 2011-05-06 Eli Zaretskii <eliz@gnu.org>
5020 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5021 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5023 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
5025 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5027 * term.c (vfatal): Remove stray call to va_end.
5028 It's not needed and the C Standard doesn't allow it here anyway.
5030 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5031 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5033 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5036 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5038 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5040 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5042 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5044 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5046 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5047 * charset.c (Fdefine_charset_internal): Don't initialize
5048 charset.code_space[15]. The value was garbage, on hosts with
5049 32-bit int (Bug#8600).
5051 * lread.c (read_integer): Be more consistent with string-to-number.
5052 Use string_to_number to do the actual conversion; this avoids
5053 rounding errors and fixes some other screwups. Without this fix,
5054 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5055 (digit_to_number): Move earlier, for benefit of read_integer.
5056 Return -1 if the digit is out of range for the base, -2 if it is
5057 not a digit in any supported base. (Bug#8602)
5059 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5061 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5062 to match comment at start of function. This also removes a
5063 GCC warning about overflow in a 32+64-bit port.
5065 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5067 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5068 Reported by Stefan Monnier in
5069 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
5070 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5071 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
5073 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5074 (EMACS_UINTPTR): Likewise, with uintptr_t.
5076 * lisp.h: Prefer 64-bit EMACS_INT if available.
5077 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5078 on 32-bit hosts that have 64-bit int, so that they can access
5080 However, temporarily disable this change unless the temporary
5081 symbol WIDE_EMACS_INT is defined.
5083 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5085 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5086 This removes an assumption that EMACS_INT and long are the same
5087 width as pointers. The assumption is true for Emacs porting targets
5088 now, but we want to make other targets possible.
5089 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5090 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5091 In the rest of the code, change types of integers that hold casted
5092 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5093 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5094 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5095 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5096 No need to cast type when ORing.
5097 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5098 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5099 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5100 assume EMACS_INT is the same width as char *.
5101 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5102 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5103 Remove no-longer-needed casts.
5104 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5105 (xg_tool_bar_help_callback, xg_make_tool_item):
5106 Use EMACS_INTPTR to hold an integer
5107 that will be cast to void *; this can avoid a GCC warning
5108 if EMACS_INT is not the same width as void *.
5109 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5110 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5111 (current_message_1, set_message_1):
5112 Use a local to convert to proper width without a cast.
5113 * xmenu.c (dialog_selection_callback): Likewise.
5115 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5116 Also, don't assume VALBITS / RAND_BITS is less than 5,
5117 and don't rely on undefined behavior when shifting a 1 left into
5119 * lisp.h (get_random): Change signature to match.
5121 * lread.c (hash_string): Use size_t, not int, for hash computation.
5122 Normally we prefer signed values; but hashing is special, because
5123 it's better to use unsigned division on hash table sizes so that
5124 the remainder is nonnegative. Also, size_t is the natural width
5125 for hashing into memory. The previous code used 'int', which doesn't
5126 retain enough info to hash well into very large tables.
5127 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5129 * dbusbind.c: Don't possibly lose pointer info when converting.
5130 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5131 Use XPNTR rather than XHASH, so that the high-order bits of
5132 the pointer aren't lost when converting through void *.
5134 * eval.c (Fautoload): Don't double-shift a pointer.
5136 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5138 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5140 * gnutls.c (DEF_GNUTLS_FN):
5141 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5143 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5145 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5148 2011-05-05 Eli Zaretskii <eliz@gnu.org>
5150 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5151 New version that can reserve upto 2GB of heap space.
5153 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
5155 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5157 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5159 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5160 `gnutls_certificate_set_x509_key_file'.
5162 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
5164 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5165 Update dependencies.
5167 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5169 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5170 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5171 Remove unused parameter `fildes'.
5172 * process.c (read_process_output, send_process): Don't pass it.
5174 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5176 Fix previous change: the library cache is defined in w32.c.
5177 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5178 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5180 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5182 Implement dynamic loading of GnuTLS on Windows.
5184 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5185 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5186 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5189 * gnutls.c (Qgnutls_dll): Define.
5190 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5191 (gnutls_*): Declare function pointers.
5192 (init_gnutls_functions): New function to initialize function pointers.
5193 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5194 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5195 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5196 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5197 (emacs_gnutls_write, emacs_gnutls_read)
5198 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5199 (Fgnutls_available_p): New function.
5200 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5201 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5202 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5204 * image.c: Include w32.h.
5205 (Vimage_type_cache): Delete.
5206 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5207 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5208 (w32_delayed_load): Move to w32.c.
5210 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5212 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5213 (w32_delayed_load): Move from image.c. When loading a library, record
5214 its filename in the :loaded-from property of the library id.
5215 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5216 Initialize and staticpro them.
5217 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5219 * process.c: Include lisp.h before w32.h, not after.
5220 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5221 instead of gnutls_record_check_pending.
5223 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5225 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5227 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5228 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5231 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5233 * xterm.c (x_set_frame_alpha): Do not set property on anything
5234 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5236 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5238 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5240 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5242 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5243 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5244 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5245 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5246 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5247 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5248 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5249 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5250 (Qgnutls_bootprop_callbacks_verify): Make static.
5252 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5254 * callproc.c: Indentation fixup.
5256 * sysdep.c (wait_for_termination_1): Make static.
5257 (wait_for_termination, interruptible_wait_for_termination):
5258 Move after wait_for_termination_1.
5260 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5262 * sysdep.c (interruptible_wait_for_termination): New function
5263 which is like wait_for_termination, but allows keyboard
5266 * callproc.c (Fcall_process): Add (:file "file") as an option for
5268 (Fcall_process_region): Ditto.
5270 2011-04-30 Eli Zaretskii <eliz@gnu.org>
5272 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5273 rather than `XVECTOR (FOO)->size'.
5275 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5276 inttypes.h, as a gnulib replacement is used if it not available in
5279 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5281 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5282 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5283 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5285 * coding.c (coding_alloc_by_realloc): Error out if destination
5286 will grow beyond MOST_POSITIVE_FIXNUM.
5287 (decode_coding_emacs_mule): Abort if there isn't enough place in
5288 charbuf for the composition carryover bytes. Reserve an extra
5289 space for up to 2 characters produced in a loop.
5290 (decode_coding_iso_2022): Abort if there isn't enough place in
5291 charbuf for the composition carryover bytes.
5293 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5295 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5296 aborting when %lld or %lll format is passed.
5297 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5298 %llo or %llx format is passed. (Bug#8545)
5300 * window.c (window_scroll_line_based): Use a marker instead of
5301 simple variables to record original value of point. (Bug#7952)
5303 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5304 produced by %s or %c overflows available buffer space. (Bug#8545)
5306 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5308 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5309 (SIZE_MAX): Move defn after all includes, as they might #define it.
5311 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5313 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5315 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5317 * keyboard.c (Qdelayed_warnings_hook): Define.
5318 (command_loop_1): Run `delayed-warnings-hook'
5319 if Vdelayed_warnings_list is non-nil.
5320 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5321 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5323 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5325 * doprnt.c (doprnt): Don't return value smaller than the buffer
5326 size if the message was truncated. (Bug#8545).
5328 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5330 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5331 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5333 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5335 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5337 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5339 * makefile.w32-in: Update dependencies.
5341 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5343 Improve `doprnt' and its usage. (Bug#8545)
5344 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5345 `format_end'. Remove support for %l as a conversion specifier.
5346 Don't use xrealloc. Improve diagnostics when the %l size modifier
5347 is used. Update the commentary.
5349 * eval.c (verror): Simplify calculation of size_t.
5351 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5354 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5356 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5359 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5361 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5362 This makes this file independent of the recent pseudovector change.
5364 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5366 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5368 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5369 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5370 Remove unused local.
5371 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5373 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5374 GCC 4.6.0 optimizes based on type-based alias analysis.
5375 For example, if b is of type struct buffer * and v of type struct
5376 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5377 != &v->size, and therefore "v->size = 1; b->size = 2; return
5378 v->size;" must therefore return 1. This assumption is incorrect
5379 for Emacs, since it type-puns struct Lisp_Vector * with many other
5380 types. To fix this problem, this patch adds a new type struct
5381 vectorlike_header that documents the constraints on layout of vectors
5382 and pseudovectors, and helps optimizing compilers not get fooled
5383 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5384 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5385 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5387 (XSETPVECTYPE): Rewrite in terms of new macro.
5388 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5389 This is a bit clearer, and further avoids the possibility of
5390 undesirable aliasing.
5391 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5392 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5393 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5394 since Lisp_Subr is a special case (no "next" field).
5395 (ASIZE): Now uses header.size rather than size.
5396 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5397 to avoid the hassle of writing XVECTOR (foo)->header.size.
5398 (struct vectorlike_header): New type.
5399 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5400 object, to help avoid aliasing.
5401 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5402 (SUBRP): Likewise, since Lisp_Subr is a special case.
5403 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5404 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5405 (struct Lisp_Hash_Table): Combine first two members into a single
5406 struct vectorlike_header member. All uses of "size" and "next" members
5407 changed to be "header.size" and "header.next".
5408 * buffer.h (struct buffer): Likewise.
5409 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5410 * frame.h (struct frame): Likewise.
5411 * process.h (struct Lisp_Process): Likewise.
5412 * termhooks.h (struct terminal): Likewise.
5413 * window.c (struct save_window_data, struct saved_window): Likewise.
5414 * window.h (struct window): Likewise.
5415 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5416 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5417 * buffer.c (init_buffer_once): Likewise.
5418 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5420 * process.c (Fformat_network_address): Use local var for size,
5423 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5425 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5426 * data.c (atof): Remove decl; no longer used or needed.
5427 (digit_to_number): Move to lread.c.
5428 (Fstring_to_number): Use new string_to_number function, to be
5429 consistent with how the Lisp reader treats infinities and NaNs.
5430 Do not assume that floating-point numbers represent EMACS_INT
5431 without losing information; this is not true on most 64-bit hosts.
5432 Avoid double-rounding errors, by insisting on integers when
5433 parsing non-base-10 numbers, as the documentation specifies.
5434 * lisp.h (string_to_number): New decl, replacing ...
5435 (isfloat_string): Remove.
5436 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5437 (read1): Do not accept +. and -. as integers; this
5438 appears to have been a coding error. Similarly, do not accept
5439 strings like +-1e0 as floating point numbers. Do not report
5440 overflow for integer overflows unless the base is not 10 which
5441 means we have no simple and reliable way to continue.
5442 Break out the floating-point parsing into a new
5443 function string_to_number, so that Fstring_to_number parses
5444 floating point numbers consistently with the Lisp reader.
5445 (digit_to_number): Move here from data.c. Make it static inline.
5446 (E_CHAR, EXP_INT): Remove, replacing with ...
5447 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5448 (string_to_number): New function, replacing isfloat_string.
5449 This function checks for valid syntax and produces the resulting
5450 Lisp float number too. Rework it so that string-to-number
5451 no longer mishandles examples like "1.0e+". Use strtoumax,
5452 so that overflow for non-base-10 numbers is reported only when
5453 there's no portable and simple way to convert to floating point.
5455 * textprop.c (set_text_properties_1): Rewrite for clarity,
5456 and to avoid GCC warning about integer overflow.
5458 * intervals.h (struct interval): Use EMACS_INT for members
5459 where EMACS_UINT might cause problems. See
5460 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5461 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5462 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5464 (offset_intervals): Tell GCC not to worry about length overflow
5465 when negating a negative length.
5467 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5468 (overrun_check_free): Likewise.
5470 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5471 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5474 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5475 (gnutls_make_error): Rename local to avoid shadowing.
5476 (gnutls_emacs_global_deinit): ifdef out; not used.
5477 (Fgnutls_boot): Use const for pointer to readonly storage.
5478 Comment out unused local. Fix pointer signedness problems.
5480 * lread.c (openp): Don't stuff size_t into an 'int'.
5481 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5482 about possible signed overflow.
5484 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5485 (GDK_KEY_g): Don't define if already defined.
5486 (xg_prepare_tooltip): Avoid pointer signedness problem.
5487 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5489 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5490 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5492 * xfns.c (Fx_window_property): Simplify a bit,
5493 to make a bit faster and to avoid GCC 4.6.0 warning.
5494 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5496 * fns.c (internal_equal): Don't assume size_t fits in int.
5498 * alloc.c (compact_small_strings): Tighten assertion a little.
5500 Replace pEd with more-general pI, and fix some printf arg casts.
5501 * lisp.h (pI): New macro, generalizing old pEd macro to other
5502 conversion specifiers. For example, use "...%"pI"d..." rather
5503 than "...%"pEd"...".
5504 (pEd): Remove. All uses replaced with similar uses of pI.
5505 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5506 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5507 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5508 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5509 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5510 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5511 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5513 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5514 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5515 * print.c (safe_debug_print, print_object): Likewise.
5516 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5518 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5519 avoiding the 0 flag, which is not portable.
5520 * process.c (Fmake_network_process): Use pI to avoid cast.
5521 * region-cache.c (pp_cache): Likewise.
5522 * xdisp.c (decode_mode_spec): Likewise.
5523 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5524 behavior on 64-bit hosts with printf arg.
5525 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5526 (x_stop_queuing_selection_requests): Likewise.
5527 (x_get_window_property): Don't truncate byte count to an 'int'
5530 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5531 here, since it parses constructs like leading '-' and spaces,
5532 which are not wanted; and it overflows with large numbers.
5533 Instead, simply match F[0-9]+, which is what is wanted anyway.
5535 * alloc.c: Remove unportable assumptions about struct layout.
5536 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5537 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5538 (allocate_vectorlike, make_pure_vector): Use the new macros,
5539 plus offsetof, to remove unportable assumptions about struct layout.
5540 These assumptions hold on all porting targets that I know of, but
5541 they are not guaranteed, they're easy to remove, and removing them
5542 makes further changes easier.
5544 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5545 This doesn't fix a bug but makes the code clearer.
5546 (string_overrun_cookie): Now const. Use initializers that
5547 don't formally overflow signed char, to avoid warnings.
5548 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5549 can cause Emacs to crash when string overrun checking is enabled.
5550 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5551 multiple of sizeof (EMACS_INT); it need not be, if
5552 alignof(EMACS_INT) < sizeof (EMACS_INT).
5553 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5555 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5557 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5559 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5561 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5562 supposed to be handshaking. (Bug#8556)
5563 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5565 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5567 * lisp.h (Qdebug): List symbol.
5568 * eval.c (Qdebug): Restore global linkage.
5569 * keyboard.c (debug-on-event): New variable.
5570 (handle_user_signal): Break into debugger when debug-on-event
5571 matches the current signal symbol.
5573 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5575 * alloc.c (check_sblock, check_string_bytes)
5576 (check_string_free_list): Convert to standard C.
5578 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5580 * w32.c (emacs_gnutls_push): Fix typo.
5582 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5584 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5585 "cast to pointer from integer of different size".
5587 Improve doprnt and its use in verror. (Bug#8545)
5588 * doprnt.c (doprnt): Document the set of format control sequences
5589 supported by the function. Use SAFE_ALLOCA instead of always
5592 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5593 is one byte too soon. Don't use xrealloc; instead xfree and
5596 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5598 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5601 * gnutls.c: Renamed global_initialized to
5602 gnutls_global_initialized. Added internals for the
5603 :verify-hostname-error, :verify-error, and :verify-flags
5604 parameters of `gnutls-boot' and documented those parameters in the
5605 docstring. Start callback support.
5606 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5607 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5608 on error. Return error code.
5609 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5610 (emacs_gnutls_read): Likewise.
5611 (Fgnutls_boot): Return handshake error code.
5612 (emacs_gnutls_handle_error): New function.
5613 (wsaerror_to_errno): Likewise.
5615 * w32.h (emacs_gnutls_pull): Add prototype.
5616 (emacs_gnutls_push): Likewise.
5618 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5619 (emacs_gnutls_push): Likewise.
5621 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5623 * process.c (wait_reading_process_output): Check if GnuTLS
5624 buffered some data internally if no FDs are set for TLS
5627 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5628 (LIBS): Link to USER_LIBS.
5629 ($(BLD)/gnutls.$(0)): New target.
5631 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5633 * xdisp.c (handle_single_display_spec): Rename the
5634 display_replaced_before_p argument into display_replaced_p, to
5635 make it consistent with the commentary. Fix typos in the
5638 * textprop.c (syms_of_textprop): Remove dead code.
5639 (copy_text_properties): Delete obsolete commentary about an
5640 interface that was deleted long ago. Fix typos in the description
5643 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5644 to changes in oldXMenu/XMenu.h from 2011-04-16.
5645 <menu_help_message, prev_menu_help_message>: Constify.
5646 (IT_menu_make_room): menu->help_text is now `const char **';
5649 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5650 to changes in oldXMenu/XMenu.h from 2011-04-16.
5651 (struct XMenu): Declare `help_text' `const char **'.
5653 * xfaces.c <Qunspecified>: Make extern again.
5655 * syntax.c: Include sys/types.h before including regex.h, as
5658 * doc.c (get_doc_string): Improve the format passed to `error'.
5660 * doprnt.c (doprnt): Improve commentary.
5662 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5664 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5667 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5668 changes in globals.h immediately force recompilation.
5669 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5670 $(CURDIR)/s/ms-w32.h.
5671 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5673 * character.c (Fchar_direction): Function deleted.
5674 (syms_of_character): Don't defsubr it.
5675 <char-direction-table>: Deleted.
5677 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5679 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5680 * doprnt.c: Include limits.h.
5681 (SIZE_MAX): New macro.
5682 (doprnt): Return a size_t value. 2nd arg is now size_t.
5683 Many local variables are now size_t instead of int or unsigned.
5684 Improve overflow protection. Support `l' modifier for integer
5685 conversions. Support %l conversion. Don't assume an EMACS_INT
5686 argument for integer conversions and for %c.
5688 * lisp.h (doprnt): Restore prototype.
5690 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5693 * Makefile.in (base_obj): Add back doprnt.o.
5695 * deps.mk (doprnt.o): Add back prerequisites.
5696 (callint.o): Depend on character.h.
5698 * eval.c (internal_lisp_condition_case): Include the handler
5699 representation in the error message.
5700 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5701 when breaking from the loop.
5703 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5705 * callint.c (Fcall_interactively): When displaying error message
5706 about invalid control letter, pass the character's codepoint, not
5707 a pointer to its multibyte form. Improve display of the character
5708 in octal and display also its hex code.
5710 * character.c (char_string): Use %x to display the (unsigned)
5711 codepoint of an invalid character, to avoid displaying a bogus
5714 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5715 `error', not SYMBOL_NAME itself.
5717 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5718 character arguments to `error'.
5720 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5721 to `error' in error message about FINAL_CHAR argument. Make sure
5722 FINAL_CHAR is a character, and use %c when it is passed as
5723 argument to `error'.
5725 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5727 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5729 * w32.c: Include <time.h>.
5730 (sys_localtime): New function.
5732 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5734 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5736 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5738 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5740 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5743 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5745 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5746 gl_state.e_property when gl_state.object is Qt.
5748 * insdel.c (make_gap_larger): Remove limitation of buffer size
5751 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5753 * xdisp.c (lookup_glyphless_char_display)
5754 (produce_glyphless_glyph): Handle cons cell entry in
5755 glyphless-char-display.
5756 (Vglyphless_char_display): Document it.
5758 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5759 glyphless-char-display.
5761 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5763 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5765 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5767 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5768 definition for no-X builds.
5770 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5772 Static checks with GCC 4.6.0 and non-default toolkits.
5774 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5776 * process.c (keyboard_bit_set): Define only if SIGIO.
5777 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5778 (send_process): Repair possible setjmp clobbering.
5780 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5782 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5784 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5786 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5787 Define only if needed.
5789 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5790 by pacifying GCC about it. Maybe it's time to retire it?
5791 * xfaces.c (USG, __TIMEVAL__): Likewise.
5793 * dispextern.h (struct redisplay_interface): Rename param
5795 * termhooks.h (struct terminal): Likewise.
5796 * xterm.c (xembed_send_message): Likewise.
5798 * insdel.c (make_gap_smaller): Define only if
5799 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5801 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5804 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5805 so that we aren't warned about unused symbols.
5807 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5809 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5811 * xfns.c (x_real_positions): Mark locals as initialized.
5813 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5815 * xterm.c: Fix problems found by static analysis with other toolkits.
5816 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5817 (x_dispatch_event): Declare static if USE_GTK, and
5818 define if USE_GTK || USE_X_TOOLKIT.
5819 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5820 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5821 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5822 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5824 * xmenu.c (menu_help_callback): Pointer type fixes.
5825 Use const pointers when pointing at readonly data. Avoid pointer
5827 (FALSE): Remove unused macro.
5828 (update_frame_menubar): Remove unused decl.
5830 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5832 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5833 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5834 (single_menu_item): Rename local to avoid shadowing.
5836 * keyboard.c (make_lispy_event): Remove unused local var.
5838 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5839 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5841 * bitmaps: Change bitmaps from unsigned char back to the X11
5842 compatible char. Avoid the old compiler warnings about
5843 out-of-range initializers by using, for example, '\xab' rather
5846 * xgselect.c (xgselect_initialize): Check vs interface
5847 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5849 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5851 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5852 to read-only memory.
5854 * fns.c (vector): Remove; this old hack is no longer needed.
5856 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5858 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5860 * xrdb.c (x_load_resources): Omit unused local.
5862 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5863 (x_window): Rename locals to avoid shadowing.
5864 (USG): Use the kludged USG macro, to pacify gcc.
5866 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5867 (x_term_init): Remove local to avoid shadowing.
5869 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5871 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5872 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5874 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5876 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5878 Fix regex.c, syntax.c and friends for buffers > 2GB.
5879 * syntax.h (struct gl_state_s): Declare character position members
5882 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5884 * textprop.c (verify_interval_modification, interval_of):
5885 Declare arguments EMACS_INT.
5887 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5890 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5892 * indent.c (Fvertical_motion): Local variable it_start is now
5895 * regex.c (re_match, re_match_2, re_match_2_internal)
5896 (bcmp_translate, regcomp, regexec, print_double_string)
5897 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5898 (re_compile_pattern, re_exec): Declare arguments and local
5899 variables `size_t' and `ssize_t' and return values `regoff_t', as
5901 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5902 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5903 <compile_stack_type>: `size' and `avail' are now `size_t'.
5905 * regex.h <regoff_t>: Use ssize_t, not int.
5906 (re_search, re_search_2, re_match, re_match_2): Arguments that
5907 specify buffer/string position and length are now ssize_t and
5908 size_t. Return type is regoff_t.
5910 2011-04-16 Ben Key <bkey76@gmail.com>
5912 * nsfont.m: Fixed bugs in ns_get_family and
5913 ns_descriptor_to_entity that were caused by using free to
5914 deallocate memory blocks that were allocated by xmalloc (via
5915 xstrdup). This caused Emacs to crash when compiled with
5916 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5917 --enable-checking=xmallocoverrun). xfree is now used to
5918 deallocate these memory blocks.
5920 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5922 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5924 emacs_write: Accept and return EMACS_INT for sizes.
5925 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5927 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5928 Accept and return EMACS_INT.
5929 (emacs_gnutls_write): Return the number of bytes written on
5931 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5932 (emacs_read, emacs_write): Remove check for negative size, as the
5933 Emacs source code has been audited now.
5934 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5935 (emacs_read, emacs_write): Use it.
5936 * process.c (send_process): Adjust to the new signatures of
5937 emacs_write and emacs_gnutls_write. Do not attempt to store
5938 a byte offset into an 'int'; it might overflow.
5939 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5941 * sound.c: Don't assume sizes fit in 'int'.
5942 (struct sound_device.period_size, alsa_period_size):
5943 Return EMACS_INT, not int.
5944 (struct sound_device.write, vox_write, alsa_write):
5945 Accept EMACS_INT, not int.
5946 (wav_play, au_play): Use EMACS_INT to store sizes and to
5947 record read return values.
5949 2011-04-15 Ben Key <bkey76@gmail.com>
5951 * keyboard.c (Qundefined): Don't declare static since it is used
5953 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5954 static since they are used in nsfont.m.
5956 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5958 * process.c (Qprocessp): Don't declare static.
5959 * lisp.h (Qprocessp): Declare again.
5961 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5963 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5965 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5967 Improve C-level modularity by making more things 'static'.
5969 Don't publish debugger-only interfaces to other modules.
5970 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5971 (verify_bytepos, count_markers): Move decls to the only modules
5973 * region-cache.h (pp_cache): Likewise.
5974 * window.h (check_all_windows): Likewise.
5975 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5977 * sysdep.c (croak): Now static, if
5978 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5979 * syssignal.h (croak): Declare only if not static.
5981 * alloc.c (refill_memory_reserve): Now static if
5982 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5983 * lisp.h (refill_memory_reserve): Declare only if not static.
5985 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5986 Define only if USE_LUCID.
5988 * xrdb.c (x_customization_string, x_rm_string): Now static.
5990 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5991 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5993 * xdisp.c (draw_row_with_mouse_face): Now static.
5994 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5996 * window.h (check_all_windows): Mark externally visible.
5998 * window.c (window_deletion_count): Now static.
6000 * undo.c: Make symbols static if they're not exported.
6001 (last_undo_buffer, last_boundary_position, pending_boundary):
6004 * textprop.c (interval_insert_behind_hooks): Now static.
6005 (interval_insert_in_front_hooks): Likewise.
6007 * term.c: Make symbols static if they're not exported.
6008 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6009 (max_frame_lines, tty_set_terminal_modes):
6010 (tty_reset_terminal_modes, tty_turn_off_highlight):
6011 (get_tty_terminal): Now static.
6012 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6013 * termhooks.h (term_mouse_moveto): Do not declare if
6015 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6016 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6018 * sysdep.c: Make symbols static if they're not exported.
6019 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6021 (sigprocmask_set, full_mask): Remove; unused.
6022 (wait_debugging): Mark as visible.
6023 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6024 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6026 * syntax.c (syntax_temp): Define only if !__GNUC__.
6028 * sound.c (current_sound_device, current_sound): Now static.
6030 * search.c (searchbufs, searchbuf_head): Now static.
6032 * scroll.c (scroll_cost): Remove; unused.
6033 * dispextern.h (scroll_cost): Remove decl.
6035 * region-cache.h (pp_cache): Mark as externally visible.
6037 * process.c: Make symbols static if they're not exported.
6038 (process_tick, update_tick, create_process, chan_process):
6039 (Vprocess_alist, proc_buffered_char, datagram_access):
6040 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6041 (deactivate_process): Mark defn as static, as well as decl.
6042 * lisp.h (create_process): Remove decl.
6043 * process.h (chan_process, Vprocess_alist): Remove decls.
6045 * print.c: Make symbols static if they're not exported.
6046 (print_depth, new_backquote_output, being_printed, print_buffer):
6047 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6048 (print_interval, print_number_index, initial_stderr_stream):
6050 * lisp.h (Fprinc): Remove decl.
6051 (debug_output_compilation_hack): Mark as externally visible.
6053 * sysdep.c (croak): Move decl from here to syssignal.h.
6054 * syssignal.h (croak): Put it here, so the API can be checked when
6055 'croak' is called from dissociate_if_controlling_tty.
6057 * minibuf.c: Make symbols static if they're not exported.
6058 (minibuf_save_list, choose_minibuf_frame): Now static.
6059 * lisp.h (choose_minibuf_frame): Remove decl.
6061 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6063 * lread.c: Make symbols static if they're not exported.
6064 (read_objects, initial_obarray, oblookup_last_bucket_number):
6066 (make_symbol): Remove; unused.
6067 * lisp.h (initial_obarray, make_symbol): Remove decls.
6069 * keyboard.c: Make symbols static if they're not exported.
6070 (single_kboard, recent_keys_index, total_keys, recent_keys):
6071 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6072 (this_single_command_key_start, echoing, last_auto_save):
6073 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6074 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6075 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6076 (Vlispy_mouse_stem, double_click_count):
6078 (force_auto_save_soon): Define only if SIGDANGER.
6079 (ignore_mouse_drag_p): Now static if
6080 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6081 (print_help): Remove; unused.
6082 (stop_character, last_timer_event): Mark as externally visible.
6083 * keyboard.h (ignore_mouse_drag_p): Declare only if
6084 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6085 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6086 * lisp.h (echoing): Remove decl.
6087 (force_auto_save_soon): Declare only if SIGDANGER.
6088 * xdisp.c (redisplay_window): Simplify code, to make it more
6089 obvious that ignore_mouse_drag_p is not accessed if !defined
6090 USE_GTK && !defined HAVE_NS.
6092 * intervals.c: Make symbols static if they're not exported.
6093 (merge_properties_sticky, merge_interval_right, delete_interval):
6095 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6097 * insdel.c: Make symbols static if they're not exported.
6098 However, leave prepare_to_modify_buffer alone. It's never
6099 called from outside this function, but that appears to be a bug.
6100 (combine_after_change_list, combine_after_change_buffer):
6101 (adjust_after_replace, signal_before_change): Now static.
6102 (adjust_after_replace_noundo): Remove; unused.
6103 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
6104 (signal_before_change): Remove decls.
6106 * indent.c (val_compute_motion, val_vmotion): Now static.
6108 * image.c: Make symbols static if they're not exported.
6109 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6111 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6112 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6114 * fringe.c (standard_bitmaps): Now static.
6115 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6117 * frame.c: Make symbols static if they're not exported.
6118 (x_report_frame_params, make_terminal_frame): Now static.
6119 (get_frame_param): Now static, unless HAVE_NS.
6120 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6121 (x_get_resource_string): Remove; not used.
6122 * frame.h (make_terminal_frame, x_report_frame_params):
6123 (x_get_resource_string); Remove decls.
6124 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6125 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6127 * font.c, fontset.c: Make symbols static if they're not exported.
6128 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6129 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6130 * font.c (font_close_object): Now static.
6131 * font.h (font_close_object): Remove.
6132 * fontset.c (FONTSET_OBJLIST): Remove.
6133 (free_realized_fontset) #if-0 the body, which does nothing.
6134 (face_suitable_for_char_p): #if-0, as it's never called.
6135 * fontset.h (face_suitable_for_char_p): Remove decl.
6136 * xfaces.c (face_at_string_position):
6137 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
6138 since 0 is always ASCII.
6140 * fns.c (weak_hash_tables): Now static.
6142 * fileio.c: Make symbols static if they're not exported.
6143 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6144 (Vwrite_region_annotation_buffers): Now static.
6146 * eval.c: Make symbols static if they're not exported.
6147 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6148 * lisp.h (backtrace_list): Remove decl.
6150 * emacs.c: Make symbols static if they're not exported.
6151 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6152 (fatal_error_code, fatal_error_signal_hook, standard_args):
6154 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6155 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6156 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6157 * lisp.h (fatal_error_signal_hook): Remove decl.
6158 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6160 * editfns.c: Move a (normally-unused) function to its only use.
6161 * editfns.c, lisp.h (get_operating_system_release): Remove.
6162 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6163 worth the hassle of breaking this out.
6165 * xterm.c: Make symbols static if they're not exported.
6166 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6167 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6168 (x_destroy_window, x_delete_display):
6170 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6171 (x_mouse_leave): Remove; unused.
6172 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6173 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6174 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6176 (x_mouse_leave): Declare only if WINDOWSNT.
6177 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6178 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6181 * ftxfont.c: Make symbols static if they're not exported.
6182 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6184 * font.h (ftxfont_driver): Likewise.
6186 * xfns.c: Make symbols static if they're not exported.
6187 (x_last_font_name, x_display_info_for_name):
6188 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6189 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6190 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6191 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6192 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6193 (last_show_tip_args): Now static.
6194 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6195 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6196 (x_screen_planes): Remove; unused.
6197 * dispextern.h (x_screen_planes): Remove decl.
6199 * dispnew.c: Make symbols static if they're not exported.
6200 * dispextern.h (redraw_garbaged_frames, scrolling):
6201 (increment_row_positions): Remove.
6202 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6203 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6205 (redraw_garbaged_frames): Remove; unused.
6207 * xfaces.c: Make symbols static if they're not exported.
6208 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6210 * xterm.h (defined_color): Remove decls.
6211 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6212 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6213 (menu_face_changed_default, defined_color, free_realized_face):
6214 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6215 (ascii_face_of_lisp_face): Remove; unused.
6217 * xdisp.c: Make symbols static if they're not exported.
6218 * dispextern.h (scratch_glyph_row, window_box_edges):
6219 (glyph_to_pixel_coords, set_cursor_from_row):
6220 (get_next_display_element, set_iterator_to_next):
6221 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6222 (show_mouse_face): Remove decls
6223 * frame.h (message_buf_print): Likewise.
6224 * lisp.h (pop_message, set_message, check_point_in_composition):
6226 * xterm.h (set_vertical_scroll_bar): Likewise.
6227 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6228 (message_buf_print, scratch_glyph_row, displayed_buffer):
6229 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6230 (get_next_display_element, show_mouse_face, window_box_edges):
6231 (frame_to_window_pixel_xy, check_point_in_composition):
6232 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6233 (glyph_to_pixel_coords): Remove; unused.
6235 * dired.c (file_name_completion): Now static.
6237 * dbusbind.c (xd_in_read_queued_messages): Now static.
6239 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6240 * data.c (circular_list_error): Remove.
6242 * commands.h (last_point_position, last_point_position_buffer):
6243 (last_point_position_window): Remove decls.
6244 * keyboard.c: Make these variables static.
6246 * coding.h (coding, code_convert_region, encode_coding_gap):
6248 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6249 (iso_code_class, detect_coding, code_convert_region): Now static.
6250 (encode_coding_gap): Remove; unused.
6252 * chartab.c (chartab_chars, chartab_bits): Now static.
6254 * charset.h (charset_iso_8859_1): Remove decl.
6255 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6258 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6259 * ccl.c (Vccl_program_table): Now static.
6260 (check_ccl_update): Remove; unused.
6262 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6263 * category.h: ... from here.
6264 * category.c (check_category_table, set_category_set): Now static.
6266 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6267 * lisp.h: Remove these decls.
6269 * buffer.c (buffer_count): Remove unused var.
6271 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6272 so that it's not optimized away.
6273 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6274 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6275 exported only to the debugger.
6277 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
6278 * atimer.h (run_all_atimers): Remove; not exported.
6280 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6281 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6282 was inaccessible from Lisp.
6283 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6284 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6286 alloc.c: Import and export fewer symbols, and remove unused items.
6287 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6289 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6290 it's not optimized away by whole-program optimization.
6291 (message_enable_multibyte, free_misc): Remove.
6292 (catchlist, handlerlist, mark_backtrace):
6293 Declare only if BYTE_MARK_STACK.
6294 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6295 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6296 (message_enable_multibyte): Remove decl.
6297 (free_misc, interval_free_list, float_block, float_block_index):
6298 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6299 (cons_free_list, last_marked_index):
6301 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6302 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6303 (mark_backtrace): Define only if BYTE_MARK_STACK.
6304 * xdisp.c (message_enable_multibyte): Now static.
6306 Declare Lisp_Object Q* variables to be 'static' if not exported.
6307 This makes it easier for human readers (and static analyzers)
6308 to see whether these variables are used from other modules.
6309 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6310 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6311 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6312 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6313 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6314 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6315 * xmenu.c, xselect.c:
6316 Declare Q* vars static if they are not used in other modules.
6317 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6318 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6319 Remove decls of unexported vars.
6320 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6322 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6324 Make Emacs functions such as Fatom 'static' by default.
6325 This makes it easier for human readers (and static analyzers)
6326 to see whether these functions can be called from other modules.
6327 DEFUN now defines a static function. To make the function external
6328 so that it can be used in other C modules, use the new macro DEFUE.
6329 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6330 (Finit_image_library):
6331 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6332 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6333 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6334 Remove decls, since these functions are now static.
6335 (Funintern, Fget_internal_run_time): New decls, since these functions
6336 were already external.
6338 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6339 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6340 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6341 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6342 * keyboard.c, keymap.c, lread.c:
6343 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6344 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6345 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6346 Mark functions with DEFUE instead of DEFUN,
6347 if they are used in other modules.
6348 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6349 decls for now-static functions.
6350 * buffer.h (Fdelete_overlay): Remove decl.
6351 * callproc.c (Fgetenv_internal): Mark as internal.
6352 * composite.c (Fremove_list_of_text_properties): Remove decl.
6353 (Fcomposition_get_gstring): New forward static decl.
6354 * composite.h (Fcomposite_get_gstring): Remove decl.
6355 * dired.c (Ffile_attributes): New forward static decl.
6356 * doc.c (Fdocumntation_property): New forward static decl.
6357 * eval.c (Ffetch_bytecode): New forward static decl.
6358 (Funintern): Remove extern decl; now in .h file where it belongs.
6359 * fileio.c (Fmake_symbolic_link): New forward static decl.
6360 * image.c (Finit_image_library): New forward static decl.
6361 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6362 * intervals.h (Fprevious_property_change):
6363 (Fremove_list_of_text_properties): Remove decls.
6364 * keyboard.c (Fthis_command_keys): Remove decl.
6365 (Fcommand_execute): New forward static decl.
6366 * keymap.c (Flookup_key): New forward static decl.
6367 (Fcopy_keymap): Now static.
6368 * keymap.h (Flookup_key): Remove decl.
6369 * process.c (Fget_process): New forward static decl.
6370 (Fprocess_datagram_address): Mark as internal.
6371 * syntax.c (Fsyntax_table_p): New forward static decl.
6372 (skip_chars): Remove duplicate decl.
6373 * textprop.c (Fprevious_property_change): New forward static decl.
6374 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6376 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6377 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6379 * editfns.c (Fformat): Remove unreachable code.
6381 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6383 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6386 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6388 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6389 when at ZV. (Bug#8487)
6391 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6393 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6395 * keyboard.c (parse_tool_bar_item): Likewise.
6396 * sound.c (sound_cleanup, alsa_close): Likewise.
6397 * termcap.c (tgetent): Likewise.
6398 * xfns.c (x_default_font_parameter): Likewise.
6399 * xsettings.c (read_and_apply_settings): Likewise.
6401 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6402 (overrun_check_free): Protoize.
6404 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6406 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6407 since callers should never pass a negative size.
6408 Change the signature to match that of plain 'read' and 'write'; see
6409 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6410 * lisp.h: Update prototypes of emacs_write and emacs_read.
6412 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6414 * xdisp.c (redisplay_window): Don't try to determine the character
6415 position of the scroll margin if the window start point w->startp
6416 is outside the buffer's accessible region. (Bug#8468)
6418 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6420 Fix write-region and its subroutines for buffers > 2GB.
6421 * fileio.c (a_write, e_write): Modify declaration of arguments and
6422 local variables to support buffers larger than 2GB.
6423 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6425 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6426 argument, local variables, and return value.
6428 * lisp.h: Update prototypes of emacs_write and emacs_read.
6430 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6432 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6434 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6436 Fix more problems found by GCC 4.6.0's static checks.
6438 * xdisp.c (vmessage): Use a better test for character truncation.
6440 * charset.c (load_charset_map): <, not <=, for optimization,
6441 and to avoid potential problems with integer overflow.
6442 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6443 * casetab.c (set_identity, shuffle): Likewise.
6444 * editfns.c (Fformat): Likewise.
6445 * syntax.c (skip_chars): Likewise.
6447 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6448 This also lets GCC 4.6.0 generate slightly better loop code.
6450 * callint.c (Fcall_interactively): <, not <=, for optimization.
6451 (Fcall_interactively): Count the number of arguments produced,
6452 not the number of arguments given. This is simpler and lets GCC
6453 4.6.0 generate slightly better code.
6455 * ftfont.c: Distingish more carefully between FcChar8 and char.
6456 The previous code passed unsigned char * to a functions like
6457 strlen and xstrcasecmp that expect char *, which does not
6458 conform to the C standard.
6459 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6460 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6461 char * when the C standard requires it.
6463 * keyboard.c (read_char): Remove unused var.
6465 * eval.c: Port to Windows vsnprintf (Bug#8435).
6467 (SIZE_MAX): Define if the headers do not.
6468 (verror): Do not give up if vsnprintf returns a negative count.
6469 Instead, grow the buffer. This ports to Windows vsnprintf, which
6470 does not conform to C99. Problem reported by Eli Zaretskii.
6471 Also, simplify the allocation scheme, by avoiding the need for
6472 calling realloc, and removing the ALLOCATED variable.
6474 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6476 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6477 But keep the doprint source code for now, as we might revamp it
6478 and use it again (Bug#8435).
6479 * lisp.h (doprnt): Remove.
6480 * Makefile.in (base_obj): Remove doprnt.o.
6481 * deps.mk (doprnt.o): Remove.
6483 error: Print 32- and 64-bit integers portably (Bug#8435).
6484 Without this change, on typical 64-bit hosts error ("...%d...", N)
6485 was used to print both 32- and 64-bit integers N, which relied on
6487 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6489 * lisp.h (error, verror): Mark as printf-like functions.
6490 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6491 Report overflow in size calculations when allocating printf buffer.
6492 Do not truncate output string at its first null byte.
6493 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6494 Truncate the output at a character boundary, since vsnprintf does not
6496 * charset.c (check_iso_charset_parameter): Convert internal
6497 character to string before calling 'error', since %c now has the
6499 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6500 overflow when computing char to be passed to 'error'. Do not
6501 pass Lisp_Object to 'error'; pass the integer instead.
6502 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6503 formatted with plain %d.
6505 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6507 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6509 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6511 * xterm.c (x_catch_errors): Remove duplicate declaration.
6513 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6515 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6517 2011-04-10 Jim Meyering <meyering@redhat.com>
6519 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6520 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6521 return ssize_t not "int", and use size_t as the buffer length.
6522 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6523 * gnutls.h: Update declarations.
6524 * process.c (read_process_output): Use ssize_t, to match.
6525 (send_process): Likewise.
6527 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6529 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6531 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6533 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6534 Use unsigned char, to match FcChar8 type definition.
6536 * xterm.c (handle_one_xevent):
6537 * xmenu.c (create_and_show_popup_menu):
6538 * xselect.c (x_decline_selection_request)
6539 (x_reply_selection_request): Avoid type-punned deref of X events.
6541 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6543 Fix some uses of `int' instead of EMACS_INT.
6544 * search.c (string_match_1, fast_string_match)
6545 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6546 (scan_buffer, find_next_newline_no_quit)
6547 (find_before_next_newline, search_command, Freplace_match)
6548 (Fmatch_data): Make some `int' variables be EMACS_INT.
6550 * xdisp.c (display_count_lines): 3rd argument and return value now
6551 EMACS_INT. All callers changed.
6552 (pint2hrstr): Last argument is now EMACS_INT.
6554 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6555 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6556 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6557 (decode_coding_utf_16, decode_coding_emacs_mule)
6558 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6559 (decode_coding_ccl, decode_coding_charset)
6560 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6561 (decode_coding_iso_2022, decode_coding_emacs_mule)
6562 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6563 <char_offset, last_offset>: Declare EMACS_INT.
6564 (encode_coding_utf_8, encode_coding_utf_16)
6565 (encode_coding_emacs_mule, encode_invocation_designation)
6566 (encode_designation_at_bol, encode_coding_iso_2022)
6567 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6568 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6570 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6571 (encode_invocation_designation): Last argument P_NCHARS is now
6573 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6574 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6576 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6579 * ccl.c (Fccl_execute_on_string): Declare some variables
6582 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6584 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6586 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6588 * process.c (Fformat_network_address): Doc fix.
6590 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6592 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6594 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6596 * keyboard.c (read_char): Call Lisp function help-form-show,
6597 instead of using internal_with_output_to_temp_buffer.
6598 (Qhelp_form_show): New var.
6599 (syms_of_keyboard): Use DEFSYM macro.
6601 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6603 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6605 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6607 * process.c (Flist_processes): Remove to Lisp.
6608 (list_processes_1): Delete.
6610 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6612 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6614 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6616 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6618 Fix more problems found by GCC 4.6.0's static checks.
6620 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6622 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6624 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6626 * xdisp.c (vmessage): Mark as a printf-like function.
6628 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6630 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6632 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6633 printf-like functions.
6634 (tiff_load): Add casts to remove these marks before passing them
6635 to system-supplied API.
6637 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6639 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6640 This avoids several warnings with gcc -Wstrict-overflow.
6641 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6642 directly, rather than having caller test rule sign. This avoids
6643 some unnecessary tests.
6644 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6645 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6646 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6648 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6649 (xfont_open): Avoid unnecessary tests.
6651 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6653 * composite.h, composite.c (composition_gstring_put_cache):
6654 Use EMACS_INT, not int, for length.
6656 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6657 breaking out part of COMPOSITION_DECODE_RULE.
6658 (COMPOSITION_DECODE_RULE): Use it.
6659 * composite.c (get_composition_id): Remove unused local vars,
6660 by using the new macro.
6662 * textprop.c (set_text_properties_1): Change while to do-while,
6663 since the condition is always true at first.
6665 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6666 (interval_deletion_adjustment): Return unsigned value.
6669 * process.c (list_processes_1, create_pty, read_process_output):
6670 (exec_sentinel): Remove vars that were set but not used.
6671 (create_pty): Remove unnecessary "volatile"s.
6672 (Fnetwork_interface_info): Avoid possibility of int overflow.
6673 (read_process_output): Do adaptive read buffering even if carryover.
6674 (read_process_output): Simplify nbytes computation if buffered.
6676 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6678 * syntax.c (scan_words): Remove var that was set but not used.
6679 (update_syntax_table): Use unsigned instead of int.
6681 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6682 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6683 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6685 * print.c (print_error_message): Avoid int overflow.
6687 * font.c (font_list_entities): Redo for clarity,
6688 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6690 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6691 (font_score): Avoid potential overflow in diff calculation.
6693 * fns.c (substring_both): Remove var that is set but not used.
6694 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6696 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6698 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6699 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6700 can always succeed if overflow has undefined behavior.
6702 * search.c (boyer_moore, wordify): Remove vars set but not used.
6703 (wordify): Omit three unnecessary tests.
6705 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6706 All callers changed. This avoids the need for an unused var.
6708 * casefiddle.c (casify_region): Remove var that is set but not used.
6710 * dired.c (file_name_completion): Remove var that is set but not used.
6712 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6714 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6715 (Finsert_file_contents): Remove unnecessary code checking fd.
6717 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6718 Check for integer overflow on size calculations.
6720 * buffer.c (Fprevious_overlay_change): Remove var that is set
6723 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6724 Remove vars that are set but not used.
6725 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6726 (timer_check_2): Mark vars as initialized.
6728 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6730 * image.c (lookup_image): Remove var that is set but not used.
6731 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6733 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6734 that are set but not used.
6736 * xfns.c (make_invisible_cursor): Don't return garbage
6737 if XCreateBitmapFromData fails (Bug#8410).
6739 * xselect.c (x_get_local_selection, x_handle_property_notify):
6740 Remove vars that are set but not used.
6742 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6743 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6745 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6746 Remove var that is set but not used.
6747 (scroll_bar_windows_size): Now size_t, not int.
6748 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6751 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6752 (map_tty_color) [!defined MSDOS]: Likewise.
6754 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6756 * coding.c: Remove vars that are set but not used.
6757 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6758 All callers changed.
6759 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6760 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6761 (decode_coding_charset): Remove vars that are set but not used.
6763 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6764 that is set but not used.
6766 * print.c (print_object): Remove var that is set but not used.
6768 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6769 The gnulib version avoids calling malloc in the usual case,
6770 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6771 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6772 * filelock.c (current_lock_owner): Likewise.
6773 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6774 * sysdep.c: Include allocator.h, careadlinkat.h.
6775 (emacs_no_realloc_allocator): New static constant.
6776 (emacs_readlink): New function.
6777 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6778 ../lib/careadlinkat.h.
6780 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6782 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6783 first non-nil return value).
6785 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6787 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6788 if not defined (Bug#8403).
6790 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6792 * xdisp.c (display_count_lines): Remove parameter `start',
6793 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6794 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6795 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6796 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6797 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6798 and thereabouts. All callers changed.
6799 (get_per_char_metric): Remove parameter `f', unused since
6800 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6802 2011-04-02 Jim Meyering <meyering@redhat.com>
6804 do not dereference NULL upon failed strdup
6805 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6806 (ns_get_family): Likewise.
6808 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6810 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6812 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6814 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6817 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6819 Add lexical binding.
6821 * window.c (Ftemp_output_buffer_show): New fun.
6822 (Fsave_window_excursion):
6823 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6825 * lread.c (lisp_file_lexically_bound_p): New function.
6826 (Fload): Bind Qlexical_binding.
6827 (readevalloop): Remove `evalfun' arg.
6828 Bind Qinternal_interpreter_environment.
6829 (Feval_buffer): Bind Qlexical_binding.
6830 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6832 (syms_of_lread): Declare `lexical-binding'.
6834 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6836 * keyboard.c (eval_dyn): New fun.
6837 (menu_item_eval_property): Use it.
6839 * image.c (parse_image_spec): Use Ffunctionp.
6841 * fns.c (concat, mapcar1): Accept byte-code-functions.
6843 * eval.c (Fsetq): Handle lexical vars.
6844 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6845 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6846 (FletX, Flet): Obey lexical binding.
6847 (Fcommandp): Handle closures.
6848 (Feval): New `lexical' arg.
6849 (eval_sub): New function extracted from Feval. Use it almost
6850 everywhere where Feval was used. Look up vars in lexical env.
6852 (Ffunctionp): Move from subr.el.
6853 (Ffuncall): Handle closures.
6854 (apply_lambda): Remove `eval_flags'.
6855 (funcall_lambda): Handle closures and new byte-code-functions.
6856 (Fspecial_variable_p): New function.
6857 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6858 but without exporting it to Lisp.
6860 * doc.c (Fdocumentation, store_function_docstring):
6861 * data.c (Finteractive_form): Handle closures.
6863 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6866 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6868 (exec_byte_code): New function extracted from Fbyte_code to handle new
6869 calling convention for byte-code-functions. Add new byte-codes.
6871 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6873 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6875 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6877 * xdisp.c (redisplay_internal): Fix prototype.
6879 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6881 * xdisp.c (SCROLL_LIMIT): New macro.
6882 (try_scrolling): Use it when setting scroll_limit.
6883 Limit scrolling to 100 screen lines.
6884 (redisplay_window): Even when falling back on "recentering",
6885 position point in the window according to scroll-conservatively,
6886 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6888 (try_scrolling): When point is above the window, allow searching
6889 as far as scroll_max, or one screenful, to compute vertical
6890 distance from PT to the scroll margin position. This prevents
6891 try_scrolling from unnecessarily failing when
6892 scroll-conservatively is set to a value slightly larger than the
6893 window height. Clean up the case of PT below the margin at bottom
6894 of window: scroll_max can no longer be INT_MAX. When aggressive
6895 scrolling is in use, don't let point enter the opposite scroll
6896 margin as result of the scroll.
6897 (syms_of_xdisp) <scroll-conservatively>: Document the
6898 threshold of 100 lines for never-recentering scrolling.
6900 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6902 * dispextern.h (move_it_by_lines):
6903 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6904 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6905 (message_log_check_duplicate): Remove parameters `prev_bol' and
6906 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6907 (redisplay_internal): Remove parameter `preserve_echo_area',
6908 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6910 * indent.c (Fvertical_motion):
6911 * window.c (window_scroll_pixel_based, Frecenter):
6912 Don't pass `need_y_p' to `move_it_by_lines'.
6914 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6916 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6917 steal a few bits to be more compact.
6918 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6919 Remove unneeded casts.
6921 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6923 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6925 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6926 binding" message (bug#7967).
6928 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6930 Fix more problems found by GCC 4.6.0's static checks.
6932 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6933 Remove unused local var.
6935 * editfns.c (Fmessage_box): Remove unused local var.
6937 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6938 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6939 Omit unused local vars.
6940 * window.c (shrink_windows): Omit unused local var.
6941 * menu.c (digest_single_submenu): Omit unused local var.
6942 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6943 Omit unused local var.
6945 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6946 Don't assume string length fits in int.
6947 (keyremap_step, read_key_sequence): Use size_t for sizes.
6948 (read_key_sequence): Don't check last_real_key_start redundantly.
6950 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6951 instead of alloca (Bug#8344).
6953 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6954 (Fbacktrace_frame): Don't assume nframes fits in int.
6956 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6958 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6961 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6963 * cm.c (calccost): Turn while-do into do-while, for clarity.
6965 * keyboard.c (syms_of_keyboard): Use the same style as later
6966 in this function when indexing through an array. This also
6967 works around GCC bug 48267.
6969 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6971 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6973 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6974 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6976 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6977 This avoids undefined behavior on integer overflow, and is a bit
6978 more convenient anyway since it is compared to a size_t variable.
6980 Variadic C functions now count arguments with size_t, not int.
6981 This avoids an unnecessary limitation on 64-bit machines, which
6982 caused (substring ...) to crash on large vectors (Bug#8344).
6983 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6984 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6985 All variadic functions and their callers changed accordingly.
6986 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6987 * data.c (arith_driver, float_arith_driver): Likewise.
6988 * editfns.c (general_insert_function): Likewise.
6989 * eval.c (struct backtrace.nargs, interactive_p)
6990 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6991 (funcall_lambda, mark_backtrace): Likewise.
6992 * fns.c (concat): Likewise.
6993 * frame.c (x_set_frame_parameters): Likewise.
6994 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6995 0 if not found, not -1. All callers changed.
6997 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6998 (stack_copy_size): Now size_t, not int.
6999 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7001 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7003 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7004 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7005 All callers changed.
7007 * lisp.h (multibyte_char_to_unibyte):
7008 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7009 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7010 * character.h (CHAR_TO_BYTE8):
7011 * cmds.c (internal_self_insert):
7012 * editfns.c (general_insert_function):
7013 * keymap.c (push_key_description):
7014 * search.c (Freplace_match):
7015 * xdisp.c (message_dolog, set_message_1): All callers changed.
7017 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7019 * keyboard.c (safe_run_hook_funcall): New function.
7020 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7021 don't set the hook to nil, but remove the offending function instead.
7022 (Qcommand_hook_internal): Remove, unused.
7023 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7024 Vcommand_hook_internal.
7026 * eval.c (enum run_hooks_condition): Remove.
7027 (funcall_nil, funcall_not): New functions.
7028 (run_hook_with_args): Call each function through a `funcall' argument.
7029 Remove `cond' argument, now redundant.
7030 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7031 (Frun_hook_with_args_until_failure): Adjust accordingly.
7032 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7034 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7036 * dispextern.h (string_buffer_position): Remove declaration.
7038 * print.c (strout): Remove parameter `multibyte', unused since
7039 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7041 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7042 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7043 All callers changed.
7045 * w32.c (_wsa_errlist): Use braces for struct initializers.
7047 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7048 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7049 All callers changed.
7050 (string_buffer_position): Likewise. Also, make static (it's never
7051 used outside xdisp.c).
7052 (cursor_row_p): Remove parameter `w', unused since
7053 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7054 (decode_mode_spec): Remove parameter `precision', introduced during
7055 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7056 All callers changed.
7058 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7060 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7062 2011-03-27 Anders Lindgren <andlind@gmail.com>
7064 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7065 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7066 (ns_update_auto_hide_menu_bar): New functions.
7067 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7068 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7069 ns_constrain_all_frames.
7070 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7071 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7073 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7075 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7077 2011-03-27 Glenn Morris <rgm@gnu.org>
7079 * syssignal.h: Replace RETSIGTYPE with void.
7080 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7081 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7082 Replace SIGTYPE with void everywhere.
7083 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7084 * s/template.h (SIGTYPE): Remove commented out definition.
7086 2011-03-26 Eli Zaretskii <eliz@gnu.org>
7088 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7089 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7091 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
7093 * w32.c (read_unc_volume): Use parameter `henum', instead of
7094 global variable `wget_enum_handle'.
7096 * keymap.c (describe_vector): Remove parameters `indices' and
7097 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7098 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7100 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7102 * keyboard.c (timer_check): Remove parameter `do_it_now',
7103 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7104 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7105 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7107 * keyboard.c (read_char):
7108 * w32menu.c (w32_menu_display_help):
7109 * xmenu.c (show_help_event, menu_help_callback):
7110 Adjust calls to `show_help_echo'.
7112 * gtkutil.c (xg_maybe_add_timer):
7113 * keyboard.c (readable_events):
7114 * process.c (wait_reading_process_output):
7115 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7117 * insdel.c (adjust_markers_gap_motion):
7118 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7119 (gap_left, gap_right): Don't call it.
7121 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
7123 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7124 incurred during fontification.
7126 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7128 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7129 (DEFVAR_PER_BUFFER): Don't pass it.
7131 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7132 (scrolling_window): Don't pass it.
7134 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7136 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7138 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7140 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7141 of variables specific to SELinux and computation of `encoded_absname'.
7143 * image.c (XPutPixel): Remove unused variable `height'.
7145 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7147 * unexw32.c (get_section_info): Remove unused variable `section'.
7149 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7150 (system_process_attributes): Remove unused variable `sess'.
7151 (sys_read): Remove unused variable `err'.
7153 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7154 (w32_wnd_proc): Remove unused variable `isdead'.
7155 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7156 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7157 (x_create_tip_frame): Remove unused variable `tem'.
7159 * w32inevt.c (w32_console_read_socket):
7160 Remove unused variable `no_events'.
7162 * w32term.c (x_draw_composite_glyph_string_foreground):
7163 Remove unused variable `width'.
7165 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
7167 * w32term.c (x_set_glyph_string_clipping):
7168 Don't pass uninitialized region to CombineRgn.
7170 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
7172 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7173 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7174 (Fx_close_connection): Remove unused variable `i'.
7176 * w32font.c (w32font_draw): Return number of glyphs.
7177 (w32font_open_internal): Remove unused variable `i'.
7178 (w32font_driver): Add missing initializer.
7180 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7181 (fill_in_menu): Remove unused variable `items_added'.
7183 * w32term.c (last_mouse_press_frame): Remove static global variable.
7184 (w32_clip_to_row): Remove unused variable `f'.
7185 (x_delete_terminal): Remove unused variable `i'.
7187 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7188 (NOTHING): Remove unused static global variable.
7189 (uniscribe_check_otf): Remove unused variable `table'.
7190 (uniscribe_font_driver): Add missing initializers.
7192 2011-03-23 Julien Danjou <julien@danjou.info>
7194 * term.c (Fsuspend_tty, Fresume_tty):
7195 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7196 * window.c (temp_output_buffer_show):
7197 * insdel.c (signal_before_change):
7198 * frame.c (Fhandle_switch_frame):
7199 * fileio.c (Fdo_auto_save):
7200 * emacs.c (Fkill_emacs):
7201 * editfns.c (save_excursion_restore):
7202 * cmds.c (internal_self_insert):
7203 * callint.c (Fcall_interactively):
7204 * buffer.c (Fkill_all_local_variables):
7205 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7207 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
7208 unconditionnaly since it does the check itself.
7210 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
7212 Fix more problems found by GCC 4.5.2's static checks.
7214 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7215 the first time through the loop, since we know p0 < p1 then.
7216 This also avoids a gcc -Wstrict-overflow warning.
7218 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7219 leading to a memory leak, possible in functions like
7220 load_charset_map_from_file that can allocate an unbounded number
7221 of objects (Bug#8318).
7223 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7224 that could (at least in theory) be that large.
7226 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7227 This is less likely to overflow, and avoids undefined behavior if
7228 overflow does occur. All callers changed. Use strtoul to scan
7229 for the unsigned long integer.
7230 (pint2hrstr): Simplify and tune code slightly.
7231 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
7233 * scroll.c (do_scrolling): Work around GCC bug 48228.
7234 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7236 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7237 This also avoids a warning with gcc -Wstrict-overflow.
7238 (validate_x_resource_name): Simplify count usage.
7239 This also avoids a warning with gcc -Wstrict-overflow.
7241 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7244 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
7246 * process.c (Fmake_network_process): Use socklen_t, not int,
7247 where POSIX says socklen_t is required in portable programs.
7248 This fixes a porting bug on hosts like 64-bit HP-UX, where
7249 socklen_t is wider than int (Bug#8277).
7250 (Fmake_network_process, server_accept_connection):
7251 (wait_reading_process_output, read_process_output):
7254 * process.c: Rename or move locals to avoid shadowing.
7255 (list_processes_1, Fmake_network_process):
7256 (read_process_output_error_handler, exec_sentinel_error_handler):
7257 Rename or move locals.
7258 (Fmake_network_process): Define label "retry_connect" only if needed.
7259 (Fnetwork_interface_info): Fix pointer signedness.
7260 (process_send_signal): Add cast to avoid pointer signedness problem.
7261 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7262 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7264 Make tparam.h and terminfo.c consistent.
7265 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7266 Include tparam.h instead, since it declares them.
7267 * cm.h (PC): Remove extern decl; tparam.h now does this.
7268 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7269 * terminfo.c: Include tparam.h, to check interfaces.
7270 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7271 (tparam): Adjust signature to match interface in tparam.h;
7272 this removes some undefined behavior. Check that outstring and len
7273 are zero, which they always are with Emacs.
7274 * tparam.h (PC, BC, UP): New extern decls.
7276 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
7277 (xftfont_open): Rename locals to avoid shadowing.
7279 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
7280 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7281 (OTF_TAG_SYM): Omit macro if not needed.
7282 (ftfont_list): Remove unused local.
7283 (get_adstyle_property, ftfont_pattern_entity):
7284 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7285 Rename locals to avoid shadowing.
7287 * xfont.c (xfont_list_family): Mark var as initialized.
7289 * xml.c (make_dom): Now static.
7291 * composite.c (composition_compute_stop_pos): Rename local to
7293 (composition_reseat_it): Remove unused locals.
7294 (find_automatic_composition, composition_adjust_point): Likewise.
7295 (composition_update_it): Mark var as initialized.
7296 (find_automatic_composition): Mark vars as initialized,
7297 with a FIXME (Bug#8290).
7299 character.h: Rename locals to avoid shadowing.
7300 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7301 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7302 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7303 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7306 * textprop.c (property_change_between_p): Remove; unused.
7308 * intervals.c (interval_start_pos): Now static.
7310 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7312 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7313 Rename locals to avoid shadowing.
7315 * sound.c (wav_play, au_play, Fplay_sound_internal):
7316 Fix pointer signedness.
7317 (alsa_choose_format): Remove unused local var.
7318 (wav_play): Initialize a variable to 0, to prevent undefined
7319 behavior (Bug#8278).
7321 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7323 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7325 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7326 clobbering (Bug#8298).
7327 * sysdep.c (sys_subshell): Likewise.
7328 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7330 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7331 This should get cleaned up, so that child_setup has the
7332 same signature on all platforms.
7334 * callproc.c (call_process_cleanup): Now static.
7335 (relocate_fd): Rename locals to avoid shadowing.
7337 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7339 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7340 not to be necessary, and produces flickering.
7342 2011-03-20 Glenn Morris <rgm@gnu.org>
7344 * config.in: Remove file.
7346 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7348 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7349 are now in src/globals.h.
7350 (syms_of_minibuf): Remove spurious & from previous change.
7352 2011-03-20 Leo <sdl.web@gmail.com>
7354 * minibuf.c (completing-read-function): New variable.
7355 (completing-read-default): Rename from completing-read.
7356 (completing-read): Call completing-read-function.
7358 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7360 * xfaces.c (Fx_load_color_file):
7361 Read color file from absolute filename (bug#8250).
7363 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7365 * makefile.w32-in: Update dependencies.
7367 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7369 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7371 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7373 Fix more problems found by GCC 4.5.2's static checks.
7375 * process.c (make_serial_process_unwind, send_process_trap):
7376 (sigchld_handler): Now static.
7378 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7379 That way, the code declares only the vars that it needs.
7380 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7381 * s/cygwin.h (PTY_ITERATION): Likewise.
7382 * s/darwin.h (PTY_ITERATION): Likewise.
7383 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7385 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7386 * process.c (allocate_pty): Don't declare stb unless it's needed.
7388 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7389 (CONSTANTLIM): Remove; unused.
7390 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7391 Define only if needed.
7393 * unexelf.c (unexec): Name an expression,
7394 to avoid gcc -Wbad-function-cast warning.
7395 Use a different way to cause a compilation error if anyone uses
7396 n rather than nn, a way that does not involve shadowing.
7397 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7399 * deps.mk (unexalpha.o): Remove; unused.
7401 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7402 * unexec.h: New file.
7403 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7404 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7406 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7407 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7408 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7409 Change as necessary to match prototype in unexec.h.
7411 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7413 (back_comment, skip_chars): Mark vars as initialized.
7415 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7416 Rename locals to avoid shadowing.
7418 * lread.c (read1): Rewrite so as not to use empty "else".
7419 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7421 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7423 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7424 warning when compiling print.c.
7426 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7427 instead of using an uninitialized var.
7428 (font_sort_entities): Mark var as initialized.
7430 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7432 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7433 pointers to constants.
7434 (font_parse_fcname): Remove unused vars.
7435 (font_delete_unmatched): Now static.
7436 (font_get_spec): Remove; unused.
7437 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7438 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7439 Rename or move locals to avoid shadowing.
7441 * fns.c (require_nesting_list, require_unwind): Now static.
7442 (Ffillarray): Rename locals to avoid shadowing.
7444 * floatfns.c (domain_error2): Define only if needed.
7445 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7447 * alloc.c (mark_backtrace): Move decl from here ...
7448 * lisp.h: ... to here, so that it can be checked.
7450 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7451 (Fdefvar): Rewrite so as not to use empty "else".
7452 (lisp_indirect_variable): Name an expression,
7453 to avoid gcc -Wbad-function-cast warning.
7454 (Fdefvar): Rename locals to avoid shadowing.
7456 * callint.c (quotify_arg, quotify_args): Now static.
7457 (Fcall_interactively): Rename locals to avoid shadowing.
7458 Use const pointer when appropriate.
7460 * lisp.h (get_system_name, get_operating_system_release):
7461 Move decls here, to check interfaces.
7462 * process.c (get_operating_system_release): Move decl to lisp.h.
7463 * xrdb.c (get_system_name): Likewise.
7464 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7465 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7466 some of which prompt warnings from gcc -Wbad-function-cast.
7467 (Fformat_time_string, Fencode_time, Finsert_char):
7468 (Ftranslate_region_internal, Fformat):
7469 Rename or remove local vars to avoid shadowing.
7470 (Ftranslate_region_internal): Mark var as initialized.
7472 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7475 * lisp.h (eassert): Check that the argument compiles, even if
7476 ENABLE_CHECKING is not defined.
7478 * data.c (Findirect_variable): Name an expression, to avoid
7479 gcc -Wbad-function-cast warning.
7480 (default_value, arithcompare, arith_driver, arith_error): Now static.
7481 (store_symval_forwarding): Rename local to avoid shadowing.
7482 (Fmake_variable_buffer_local, Fmake_local_variable):
7483 Mark variables as initialized.
7484 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7486 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7487 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7488 Rename locals to avoid shadowing.
7489 (mark_stack): Move local variables into the #ifdef region where
7491 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7492 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7494 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7495 (GC_STRING_CHARS): Remove; not used.
7496 (Fmemory_limit): Cast sbrk's returned value to char *.
7498 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7499 avoids undefined behavior in theory.
7501 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7503 Use functions, not macros, for up- and down-casing (Bug#8254).
7504 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7505 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7506 to use the following functions instead of these macros.
7507 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7508 EMACS_INT, since callers assume the returned value fits in int.
7509 (upcase1): Likewise, for UPCASE_TABLE.
7510 (uppercasep, lowercasep, upcase): New static inline functions.
7511 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7512 the race-condition problem in the old DOWNCASE.
7514 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7515 Rename locals to avoid shadowing.
7516 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7517 (regex_compile, re_search_2, re_match_2_internal):
7518 Remove unused local vars.
7519 (FREE_VAR): Rewrite so as not to use empty "else",
7520 which gcc can warn about.
7521 (regex_compile, re_match_2_internal): Mark locals as initialized.
7522 (RETALLOC_IF): Define only if needed.
7523 (WORDCHAR_P): Likewise. This one is never needed, but is used
7524 only in a comment talking about a compiler bug, so put inside
7525 the #if 0 of that comment.
7526 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7527 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7530 * search.c (boyer_moore): Rename locals to avoid shadowing.
7531 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7532 (PREV_CHAR_BOUNDARY): Likewise.
7534 * search.c (simple_search): Remove unused var.
7536 * dired.c (compile_pattern): Move decl from here ...
7537 * lisp.h: ... to here, so that it can be checked.
7538 (struct re_registers): New forward decl.
7540 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7542 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7544 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7545 Rename locals to avoid shadowing.
7546 (Fvertical_motion): Mark locals as initialized.
7548 * casefiddle.c (casify_object, casify_region): Now static.
7549 (casify_region): Mark local as initialized.
7551 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7553 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7554 New macros, so that the caller can use some names other than
7555 gcpro1, gcpro2, etc.
7556 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7558 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7559 argument, for consistency with GCPRO2_VAR, etc: it is now the
7560 prefix of the variable, not the variable itself. All uses
7562 * dired.c (directory_files_internal, file_name_completion):
7563 Rename locals to avoid shadowing.
7565 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7566 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7567 dired.c's scmp function, had undefined behavior.
7568 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7569 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7570 * buffer.h: ... to here, because these macros use current_buffer,
7571 and the new implementation with inline functions needs to have
7572 current_buffer in scope now, rather than later when the macros
7574 (downcase, upcase1): New static inline functions.
7575 (DOWNCASE, UPCASE1): Reimplement using these functions.
7576 This avoids undefined behavior in expressions like
7577 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7578 from race conditions in accessing the global variables
7579 case_temp1 and case_temp2.
7580 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7581 * lisp.h (case_temp1, case_temp2): Remove their decls.
7582 * character.h (ASCII_CHAR_P): Move from here ...
7583 * lisp.h: ... to here, so that the inline functions mentioned
7586 * dired.c (directory_files_internal_unwind): Now static.
7588 * fileio.c (file_name_as_directory, directory_file_name):
7589 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7591 (file_name_as_directory): Use const pointers when appropriate.
7592 (Fexpand_file_name): Likewise. In particular, newdir might
7593 point at constant storage, so make it a const pointer.
7594 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7595 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7597 (Fset_file_times, Finsert_file_contents, auto_save_error):
7598 Rename locals to avoid shadowing.
7600 * minibuf.c (choose_minibuf_frame_1): Now static.
7601 (Ftry_completion, Fall_completions): Rename or remove locals
7604 * marker.c (bytepos_to_charpos): Remove; unused.
7606 * lisp.h (verify_bytepos, count_markers): New decls,
7607 so that gcc does not warn that these functions aren't declared.
7609 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7610 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7611 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7612 (copy_text): Remove unused local var.
7614 * filelock.c (within_one_second): Now static.
7615 (lock_file_1): Rename local to avoid shadowing.
7617 * buffer.c (fix_overlays_before): Mark locals as initialized.
7618 (fix_start_end_in_overlays): Likewise. This function should be
7619 simplified by using pointers-to-pointers, but that's a different
7621 (switch_to_buffer_1): Now static.
7622 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7623 (report_overlay_modification): Rename locals to avoid shadowing.
7625 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7626 Fix pointer signedness issue.
7627 (sys_subshell): Mark local as volatile if checking for lint,
7628 to suppress a gcc -Wclobbered warning that does not seem to be right.
7629 (MAXPATHLEN): Define only if needed.
7631 * process.c (serial_open, serial_configure): Move decls from here ...
7632 * systty.h: ... to here, so that they can be checked.
7634 * fns.c (get_random, seed_random): Move extern decls from here ...
7635 * lisp.h: ... to here, so that they can be checked.
7637 * sysdep.c (reset_io): Now static.
7638 (wait_for_termination_signal): Remove; unused.
7640 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7641 (copy_keymap_item, append_key, push_text_char_description):
7643 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7644 (DENSE_TABLE_SIZE): Remove; unused.
7645 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7646 (describe_map_tree):
7647 Rename locals to avoid shadowing.
7649 * keyboard.c: Declare functions static if they are not used elsewhere.
7650 (echo_char, echo_dash, cmd_error, top_level_2):
7651 (poll_for_input, handle_async_input): Now static.
7652 (read_char, kbd_buffer_get_event, make_lispy_position):
7653 (make_lispy_event, make_lispy_movement, apply_modifiers):
7654 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7655 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7656 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7657 (read_key_sequence, read_char): Mark locals as initialized.
7658 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7660 * keyboard.h (make_ctrl_char): New decl.
7661 (mark_kboards): Move decl here ...
7662 * alloc.c (mark_kboards): ... from here.
7664 * lisp.h (force_auto_save_soon): New decl.
7666 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7667 (DEFINE_DUMMY_FUNCTION): New macro.
7668 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7670 (main): Add casts to avoid warnings
7671 if GCC considers string literals to be constants.
7673 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7675 * dbusbind.c: Pointer signedness fixes.
7676 (xd_signature, xd_append_arg, xd_initialize):
7677 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7678 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7679 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7680 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7682 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7683 if GCC considers string literals to be constants.
7684 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7686 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7688 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7689 (print_preprocess, print_object): New macro to fix last change.
7691 * print.c (print_preprocess): Don't forget font objects.
7693 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7695 * emacs.c (USAGE3): Doc fixes.
7697 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7699 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7702 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7704 * lisp.h (VWindow_system, Qfile_name_history):
7705 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7706 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7707 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7709 * w32select.c: Don't #include "keyboard.h".
7710 (run_protected): Add extern declaration for waiting_for_input.
7712 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7713 * w32console.c (detect_input_pending, read_input_pending)
7714 (encode_terminal_code):
7715 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7716 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7717 (w32_system_caret_y, Qfile_name_history):
7718 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7719 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7720 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7721 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7722 * w32proc.c (Qlocal, report_file_error):
7723 * w32term.c (Vwindow_system, updating_frame):
7724 * w32uniscribe.c (initialized, uniscribe_font_driver):
7725 Remove unneeded extern declarations.
7727 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7729 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7731 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7733 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7734 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7735 These macros can no longer be used for assignment.
7737 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7738 Assign struct members directly, instead of using BUF_BEGV etc.
7739 (record_buffer_markers, fetch_buffer_markers): New functions for
7740 recording and fetching special buffer markers.
7741 (set_buffer_internal_1, set_buffer_temp): Use them.
7743 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7745 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7747 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7748 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7750 * xdisp.c (hscroll_window_tree):
7751 (reconsider_clip_changes): Use PT instead of BUF_PT.
7753 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7755 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7756 $(EMACS_ROOT)/lib/intprops.h.
7758 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7760 Fix more problems found by GCC 4.5.2's static checks.
7762 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7763 to unsigned char * to avoid compiler diagnostic.
7764 (xg_free_frame_widgets): Make it clear that a local variable is
7765 needed only if USE_GTK_TOOLTIP.
7766 (gdk_window_get_screen): Make it clear that this macro is needed
7767 only if USE_GTK_TOOLTIP.
7768 (int_gtk_range_get_value): New function, which avoids a diagnostic
7769 from gcc -Wbad-function-cast.
7770 (xg_set_toolkit_scroll_bar_thumb): Use it.
7771 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7772 diagnostic from gcc -Wbad-function-cast.
7773 (get_utf8_string, xg_get_file_with_chooser):
7774 Rename locals to avoid shadowing.
7775 (create_dialog): Move locals to avoid shadowing.
7777 * xgselect.c (xg_select): Remove unused var.
7779 * image.c (four_corners_best): Mark locals as initialized.
7780 (gif_load): Initialize transparent_p to zero (Bug#8238).
7781 Mark another local as initialized.
7782 (my_png_error, my_error_exit): Mark with NO_RETURN.
7784 * image.c (clear_image_cache): Now static.
7785 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7786 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7787 (x_edge_detection): Remove unnecessary cast that
7788 gcc -Wbad-function-cast diagnoses.
7789 (gif_load): Fix pointer signedness.
7790 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7791 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7793 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7795 Improve quality of tests for time stamp overflow.
7796 For example, without this patch (encode-time 0 0 0 1 1
7797 1152921504606846976) returns the obviously-bogus value (-948597
7798 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7799 reports time overflow. See
7800 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7801 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7802 * editfns.c: Include limits.h and intprops.h.
7803 (TIME_T_MIN, TIME_T_MAX): New macros.
7804 (time_overflow): Move earlier, to before first use.
7805 (hi_time, lo_time): New functions, for an accurate test for
7807 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7808 (Fget_internal_run_time): Don't assume time_t fits in int.
7809 (make_time): Use list2 instead of Fcons twice.
7810 (Fdecode_time): More accurate test for out-of-range times.
7811 (check_tm_member): New function.
7812 (Fencode_time): Use it, to test for out-of-range times.
7813 (lisp_time_argument): Don't rely on undefined left-shift and
7814 right-shift behavior when checking for time stamp overflow.
7816 * editfns.c (time_overflow): New function, refactoring common code.
7817 (Fformat_time_string, Fdecode_time, Fencode_time):
7818 (Fcurrent_time_string): Use it.
7820 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7821 * dired.c (make_time): Move to ...
7822 * editfns.c (make_time): ... here.
7823 * systime.h: Note the move.
7825 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7827 * fringe.c (update_window_fringes): Remove unused variables.
7829 * unexmacosx.c (copy_data_segment): Also copy __got section.
7832 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7834 * termcap.c [MSDOS]: Include "msdos.h".
7835 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7836 Constify `char *' arguments and their references according to
7837 prototypes in tparam.h.
7839 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7841 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7842 Adapt all references accordingly.
7844 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7846 2011-03-11 Tom Tromey <tromey@redhat.com>
7848 * buffer.c (syms_of_buffer): Remove obsolete comment.
7850 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7852 * termhooks.h (encode_terminal_code): Declare prototype.
7854 * msdos.c (encode_terminal_code): Don't declare prototype.
7856 * term.c (encode_terminal_code): Now external again, used by
7857 w32console.c and msdos.c.
7859 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7860 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7862 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7864 Fix some minor problems found by GCC 4.5.2's static checks.
7866 * fringe.c (update_window_fringes): Mark locals as initialized
7868 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7870 * alloc.c (mark_fringe_data): Move decl from here ...
7871 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7872 to check its interface.
7873 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7875 * fontset.c (free_realized_fontset): Now static.
7876 (Fset_fontset_font): Rename local to avoid shadowing.
7877 (fontset_font): Mark local as initialized.
7878 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7880 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7882 * xselect.c (x_disown_buffer_selections): Remove; not used.
7883 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7884 (x_own_selection, Fx_disown_selection_internal): Rename locals
7886 (x_handle_dnd_message): Remove local to avoid shadowing.
7888 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7889 so that the caller can use some name other than gcpro1.
7890 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7891 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7892 (Fx_backspace_delete_keys_p):
7893 Use them to avoid shadowing, and rename vars to avoid shadowing.
7894 (x_decode_color, x_set_name, x_window): Now static.
7895 (Fx_create_frame): Add braces to silence GCC warning.
7896 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7897 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7898 Remove unused locals.
7899 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7900 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7901 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7904 * xterm.h (x_mouse_leave): New decl.
7906 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7907 Remove unused functions.
7908 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7909 (x_calc_absolute_position): Now static.
7910 (XTread_socket): Don't define label "out" unless it's used.
7911 Don't declare local "event" unless it's used.
7912 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7913 unless they are used.
7914 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7915 (x_fatal_error_signal): Remove; not used.
7916 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7917 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7918 (x_error_catcher, x_connection_closed, x_error_handler):
7919 (x_error_quitter, xembed_send_message, x_iconify_frame):
7920 (my_log_handler): Rename locals to avoid shadowing.
7921 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7922 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7924 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7925 Rename or move locals to avoid shadowing.
7926 (tty_defined_color, merge_face_heights): Now static.
7927 (free_realized_faces_for_fontset): Remove; not used.
7928 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7929 does not deduce is never used uninitialized.
7930 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7931 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7933 * terminal.c (store_terminal_param): Now static.
7935 * xmenu.c (menu_highlight_callback): Now static.
7936 (set_frame_menubar): Remove unused local.
7937 (xmenu_show): Rename parameter to avoid shadowing.
7938 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7939 since they might point to immutable storage.
7940 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7941 since it's unused otherwise.
7943 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7944 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7945 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7946 avoids a gcc -Wuninitialized diagnostic.
7947 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7948 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7949 does not deduce are never used uninitialized.
7951 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7953 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7954 * window.c (window_loop, size_window):
7955 (run_window_configuration_change_hook, enlarge_window): Likewise.
7957 * window.c (display_buffer): Now static.
7958 (size_window): Mark variables that gcc -Wuninitialized
7959 does not deduce are never used uninitialized.
7960 * window.h (check_all_windows): New decl, to forestall
7961 gcc -Wmissing-prototypes diagnostic.
7962 * dispextern.h (bidi_dump_cached_states): Likewise.
7964 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7966 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7968 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7969 and to avoid gcc -Wuninitialized warning.
7970 (load_charset_map): Mark variables that gcc -Wuninitialized
7971 does not deduce are never used uninitialized.
7972 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7974 * coding.c (coding_set_source, coding_set_destination):
7975 Use "else { /* comment */ }" rather than "else /* comment */;"
7976 for clarity, and to avoid gcc -Wempty-body warning.
7977 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7978 a block, when the outer 'i' will do.
7979 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7980 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7981 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7982 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7983 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7984 Rename locals to avoid shadowing.
7985 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7986 * coding.c (emacs_mule_char, encode_invocation_designation):
7987 Now static, since they're not used elsewhere.
7988 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7989 (decode_coding_object, encode_coding_object, detect_coding_system):
7990 (decode_coding_emacs_mule): Mark variables that gcc
7991 -Wuninitialized does not deduce are never used uninitialized.
7992 (detect_coding_iso_2022): Initialize a local variable that might
7993 be used uninitialized. Leave a FIXME because it's not clear that
7994 this initialization is needed. (Bug#8211)
7995 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7996 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7997 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7998 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7999 Remove unused macros.
8001 * category.c (hash_get_category_set): Remove unused local var.
8002 (copy_category_table): Now static, since it's not used elsewhere.
8003 * character.c (string_count_byte8): Likewise.
8005 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8006 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8008 * chartab.c (copy_sub_char_table): Now static, since it's not used
8010 (sub_char_table_ref_and_range, char_table_ref_and_range):
8011 Rename locals to avoid shadowing.
8012 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8014 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8015 (BIDI_BOB): Remove unused macro.
8017 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8018 deduce are never used uninitialized.
8019 * term.c (encode_terminal_code): Likewise.
8021 * term.c (encode_terminal_code): Now static. Remove unused local.
8023 * tparam.h: New file.
8024 * term.c, tparam.h: Include it.
8025 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8026 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8027 Move these decls to tparam.h, and make them agree with what
8028 is actually in tparam.c. The previous trick of using incompatible
8029 decls in different modules does not conform to the C standard.
8030 All callers of tparam changed to use tparam's actual API.
8031 * tparam.c (tparam1, tparam, tgoto):
8032 Use const pointers where appropriate.
8034 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8035 * cm.h (struct cm): Likewise.
8036 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8037 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8038 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8039 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8040 (turn_on_face, init_tty): Likewise.
8041 * termchar.h (struct tty_display_info): Likewise.
8043 * term.c (term_mouse_position): Rename local to avoid shadowing.
8045 * alloc.c (mark_ttys): Move decl from here ...
8046 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8048 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8050 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8052 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
8054 * search.c (compile_pattern_1): Remove argument regp, unused since
8055 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8056 (compile_pattern): Don't pass it.
8058 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8060 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8061 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8063 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8065 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8067 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8068 gdk_window_get_screen, gdk_window_get_geometry,
8069 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8070 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8071 (xg_get_pixbuf_from_pixmap): New function.
8072 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8073 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8074 Call xg_get_pixbuf_from_pixmap instead of
8075 gdk_pixbuf_get_from_drawable.
8076 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8077 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8078 (xg_check_special_colors): Use GtkStyleContext and its functions
8080 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8081 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8082 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
8083 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8084 Call gtk_widget_get_preferred_size.
8085 (xg_frame_resized): gdk_window_get_geometry only takes 5
8087 (xg_win_to_widget, xg_event_is_for_menubar):
8088 Call gdk_x11_window_lookup_for_display.
8089 (xg_set_widget_bg): New function.
8090 (delete_cb): New function.
8091 (xg_create_frame_widgets): Connect delete-event to delete_cb.
8092 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8093 (xg_set_background_color): Call xg_set_widget_bg.
8094 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8095 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8096 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8097 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8099 (update_frame_tool_bar): Call gtk_widget_hide.
8100 (xg_initialize): Use GDK_KEY_g.
8102 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8104 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8106 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8107 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8108 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8110 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
8112 * w32xfns.c (select_palette): Check success of RealizePalette against
8113 GDI_ERROR, not zero.
8115 See ChangeLog.11 for earlier changes.
8121 Copyright (C) 2011 Free Software Foundation, Inc.
8123 This file is part of GNU Emacs.
8125 GNU Emacs is free software: you can redistribute it and/or modify
8126 it under the terms of the GNU General Public License as published by
8127 the Free Software Foundation, either version 3 of the License, or
8128 (at your option) any later version.
8130 GNU Emacs is distributed in the hope that it will be useful,
8131 but WITHOUT ANY WARRANTY; without even the implied warranty of
8132 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8133 GNU General Public License for more details.
8135 You should have received a copy of the GNU General Public License
8136 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.