1 2011-09-28 Eli Zaretskii <eliz@gnu.org>
3 * xdisp.c (compute_display_string_end): If there's no display
4 string at CHARPOS, return -1.
6 * bidi.c (bidi_fetch_char): When compute_display_string_end
7 returns a negative value, treat the character as a normal
8 character not covered by a display string. (Bug#9624)
10 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
12 * lread.c (Fread_from_string): Fix typo in docstring.
14 2011-09-27 Eli Zaretskii <eliz@gnu.org>
16 * xdisp.c (handle_invisible_prop): If invisible text ends on a
17 newline, reseat the iterator instead of bidi-iterating there one
18 character at a time. (Bug#9610)
19 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
20 TO_CHARPOS if the bidi iterator is at base embedding level.
22 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
24 * lread.c (readevalloop): Use correct code for NBSP.
25 (read1): Likewise. (Bug#9608)
27 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
29 * dbusbind.c (Fdbus_register_signal): When service is not
30 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
32 2011-09-25 Glenn Morris <rgm@gnu.org>
34 * buffer.c (truncate-lines): Doc fix.
36 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
38 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
39 (Fset_window_next_buffers): Doc fix.
41 2011-09-24 Glenn Morris <rgm@gnu.org>
43 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
45 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
47 Fix minor problems found by static checking.
48 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
49 * indent.c (Fvertical_motion): Fix == vs = typo.
51 2011-09-24 Eli Zaretskii <eliz@gnu.org>
53 * dispnew.c (syms_of_display) <redisplay-dont-pause>: Default
54 value is now t. Doc fix.
56 * indent.c (Fvertical_motion): Compute and apply the overshoot
57 logic when moving up, not only when moving down. Fix the
58 confusing name and values of the it_overshoot_expected variable;
59 logic changes accordingly. (Bug#9254) (Bug#9549)
61 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
62 CHARPOS is covered by a display string which includes newlines.
63 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
64 is covered by a display string with embedded newlines.
66 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
68 * dbusbind.c (Fdbus_register_signal): Add match rule to
69 Vdbus_registered_objects_table. (Bug#9581)
70 (Fdbus_register_method, Vdbus_registered_objects_table): Fix
73 2011-09-24 Jim Meyering <meyering@redhat.com>
75 do not ignore write error for any output size
76 The previous change was incomplete.
77 While it makes emacs --batch detect the vast majority of stdout
78 write failures, errors were still ignored whenever the output size is
79 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
80 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
81 && echo FAIL: ignored write error
82 FAIL: ignored write error
83 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
84 && echo FAIL: ignored write error
85 FAIL: ignored write error
86 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
88 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
90 * emacs.c (Fkill_emacs): In noninteractive mode exit
91 non-successfully if a write error occurred on stdout. (Bug#9574)
93 2011-09-21 Eli Zaretskii <eliz@gnu.org>
95 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
98 * dispextern.h (struct it): Update the comment documenting what
101 2011-09-20 Eli Zaretskii <eliz@gnu.org>
103 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
104 a display string, extend search for cursor position to end of row.
105 (find_row_edges): If the row ends in a newline from a display
106 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
107 Handle the case of a display string with multiple newlines.
108 (Fcurrent_bidi_paragraph_direction): Fix search for previous
109 non-empty line. Fixes confusing cursor motion with arrow keys at
110 the beginning of a line that starts with whitespace.
112 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
114 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
117 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
119 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
122 2011-09-18 Eli Zaretskii <eliz@gnu.org>
124 * xdisp.c (display_line): Record maximum and minimum buffer
125 positions even if no glyphs were produced (e.g., by a zero-width
126 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
127 buffer positions that will be removed from the glyph row because
129 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
130 column is beyond frame width: don't subtract 1 "pixel" when
131 computing width of the stretch.
132 (reseat_at_next_visible_line_start): Undo the change made on
133 2011-09-17 that saved paragraph information and restored it after
134 the call to `reseat'. (Bug#9545)
136 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
138 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
139 and turn window cursor on if cleared (Bug#9415).
141 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
143 * search.c (boyer_moore): Take unibyte characters from pattern
144 literally. (Bug#9458)
146 2011-09-18 Eli Zaretskii <eliz@gnu.org>
148 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
150 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
152 Fix minor problem found by static checking.
153 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
154 initialized, to pacify gcc -Wuninitialized.
156 * fileio.c: Report proper errno when syscall falls.
157 (Finsert_file_contents): Save and restore errno,
158 so that report_file_error outputs the correct diagnostic.
159 (Fwrite_region) [CLASH_DETECTION]: Likewise.
161 2011-09-18 Eli Zaretskii <eliz@gnu.org>
163 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
165 2011-09-17 Eli Zaretskii <eliz@gnu.org>
167 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
168 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
170 2011-09-17 Eli Zaretskii <eliz@gnu.org>
172 * xdisp.c (reseat_at_next_visible_line_start): Keep information
173 about the current paragraph and restore it after the call to
176 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
177 (bidi_find_paragraph_start): Search back for paragraph beginning
178 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
179 (bidi_move_to_visually_next): Only trigger paragraph-related
180 computations when the last character is a newline or at EOB, not
181 just any NEUTRAL_B. (Bug#9470)
183 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
184 truncated lines if point is covered by a display string. (Bug#9524)
186 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
188 * xselect.c: Relax test for outgoing X longs (Bug#9498).
189 (cons_to_x_long): New function.
190 (lisp_data_to_selection_data): Use it. Correct the test for
191 short-versus-long data; it was negated. Break out of vector
192 loop, for efficiency, when a long datum is discovered.
194 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
196 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
198 2011-09-16 Eli Zaretskii <eliz@gnu.org>
200 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
201 GCC PR/17406) by declaring this function with external scope.
203 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
205 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
206 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
208 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
210 * editfns.c (Fformat): Correctly handle text properties on "%%".
212 2011-09-15 Eli Zaretskii <eliz@gnu.org>
214 * xterm.c (x_draw_composite_glyph_string_foreground):
215 * w32term.c (x_draw_composite_glyph_string_foreground):
216 * term.c (encode_terminal_code):
217 * composite.c (composition_update_it, get_composition_id):
218 * xdisp.c (get_next_display_element)
219 (fill_composite_glyph_string): Add comments about special meaning
220 of TAB characters in a composition.
222 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
224 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
225 This occurs when processing a multibyte format.
226 Problem reported by Wolfgang Jenker.
228 2011-09-15 Johan Bockgård <bojohan@gnu.org>
230 * xdisp.c (try_cursor_movement): Only check for exact match if
231 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
233 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
235 Remove unused external symbols.
236 * dispextern.h (calc_pixel_width_or_height): Remove decl.
237 * xdisp.c (calc_pixel_width_or_height): Now static.
238 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
239 * indent.c (check_display_width):
240 * w32term.c: Fix comment to match code.
241 * xterm.c, xterm.h (x_catching_errors): Remove.
243 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
245 * xselect.c: Use signed conversions more consistently (Bug#9498).
246 (selection_data_to_lisp_data): Assume incoming selection data are
247 signed integers, not unsigned. This is to be consistent with
248 outgoing selection data, which was modified to use signed integers
249 in as part of the fix to Bug#9196 in response to Jan D.'s comment
250 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
251 expects long, not unsigned long.
253 2011-09-14 Eli Zaretskii <eliz@gnu.org>
255 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
256 computation of loop end. Reported by Johan Bockgård
259 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
261 * frame.c (Fother_visible_frames_p): Function deleted.
263 2011-09-12 Eli Zaretskii <eliz@gnu.org>
265 * indent.c (compute_motion): Process display vector front to back
266 rather than the other way around. (Bug#2496)
268 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
270 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
272 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
274 * minibuf.c (Fread_from_minibuffer): Doc fix.
276 2011-09-11 Eli Zaretskii <eliz@gnu.org>
278 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
279 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
281 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
283 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
284 value for non-existent files.
286 2011-09-11 Eli Zaretskii <eliz@gnu.org>
288 * fileio.c (Finsert_file_contents): If the file cannot be opened,
289 set its "size" to -1. This will set the modtime_size field of
290 the corresponding buffer to -1, which is what
291 verify-visited-file-modtime expects for files that do not exist.
294 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
296 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
298 * lisp.h: ... from here. push_key_description is no longer
299 defined in keyboard.c, so its declaration should not be in
300 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
301 logically belongs with push_key_description.
303 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
305 * buffer.h: Include <sys/types.h> instead of <time.h>.
306 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
307 Problem reported by Herbert J. Skuhra.
309 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
311 * xml.c (parse_region): Make the parsing work for
312 non-comment-starting XML files again (bug#9144).
314 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
316 * image.c (gif_load): Fix calculation of bottom and right corner.
319 2011-09-10 Eli Zaretskii <eliz@gnu.org>
321 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
322 redisplay in small windows.
324 2011-09-09 Eli Zaretskii <eliz@gnu.org>
326 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
328 2011-09-08 Martin Rudalics <rudalics@gmx.at>
330 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
331 Operate on live windows only.
333 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
335 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
337 2011-09-07 Eli Zaretskii <eliz@gnu.org>
339 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
340 only under bidi iteration.
342 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
344 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
346 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
348 isnan: Fix porting problem to Solaris 10 with bundled gcc.
349 Without this fix, the command to link temacs failed due to an
350 undefined symbol __builtin_isnan. This is because
351 /usr/include/iso/math_c99.h #defines isnan(x) to
352 __builtin_isnan(x), but the bundled gcc, which identifies itself
353 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
355 * floatfns.c (isnan): #undef, and then #define to a clone of
357 (Fisnan): Always define, since it's always available now.
358 (syms_of_floatfns): Always define isnan at the Lisp level.
360 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
362 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
364 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
366 * fileio.c: Fix bugs with large file offsets (Bug#9428).
367 The previous code assumed that file offsets (off_t values) fit in
368 EMACS_INT variables, which is not true on typical 32-bit hosts.
369 The code messed up by falsely reporting buffer overflow in cases
370 such as (insert-file-contents "big" nil 1 2) into an empty buffer
371 when "big" contains more than 2**29 bytes, even though this
372 inserts just one byte and does not overflow the buffer.
373 (Finsert_file_contents): Store file offsets as off_t
374 values, not as EMACS_INT values. Check for overflow when
375 converting between EMACS_INT and off_t. When checking for
376 buffer overflow or for overlap, take the offsets into account.
377 Don't use EMACS_INT for small values where int suffices.
378 When checking for overlap, fix a typo: ZV was used where
379 ZV_BYTE was intended.
380 (Fwrite_region): Don't assume off_t fits into 'long'.
381 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
383 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
385 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
387 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
389 sprintf-related integer and memory overflow issues (Bug#9412).
391 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
392 (esprintf, exprintf, evxprintf): New functions.
393 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
394 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
395 (modify_event_symbol): Do not assume that the length of
396 name_alist_or_stem is safe to alloca and fits in int.
397 (Fexecute_extended_command): Likewise for function name and binding.
398 (Frecursion_depth): Wrap around reliably on integer overflow.
399 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
400 since some callers pass EMACS_INT values.
401 (Fsingle_key_description): Don't crash if symbol name contains more
402 than MAX_ALLOCA bytes.
403 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
404 (get_minibuffer): Arg is now EMACS_INT, not int.
405 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
406 (esprintf, exprintf, evxprintf): New decls.
407 * window.h (command_loop_level, minibuf_level): Reflect API changes.
409 * dbusbind.c (signature_cat): New function.
410 (xd_signature, Fdbus_register_signal):
411 Do not overrun buffer; instead, report string overflow.
413 * dispnew.c (add_window_display_history): Don't overrun buffer.
414 Truncate instead; this is OK since it's just a log.
416 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
417 even if the time zone offset is outlandishly large.
418 Don't mishandle offset == INT_MIN.
420 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
421 when creating daemon; the previous buffer-overflow check was incorrect.
423 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
424 which has the guts of the old verror function.
426 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
427 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
429 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
430 (font_unparse_xlfd): Don't blindly alloca long strings.
431 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
432 fits in int, when using sprintf. Use single snprintf to count
433 length of string rather than counting it via multiple sprintfs;
434 that's simpler and more reliable.
435 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
436 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
437 sprintf, in case result does not fit in int.
439 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
440 (fontset_from_font): Print it.
442 * frame.c (tty_frame_count): Now printmax_t, not int.
443 (make_terminal_frame, set_term_frame_name): Print it.
444 (x_report_frame_params): In X, window IDs are unsigned long,
445 not signed long, so print them as unsigned.
446 (validate_x_resource_name): Check for implausibly long names,
447 and don't assume name length fits in 'int'.
448 (x_get_resource_string): Don't blindly alloca invocation name;
449 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
452 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
453 (xg_check_special_colors, xg_set_geometry):
454 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
456 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
457 Use esprintf, not sprintf, in case result does not fit in int.
459 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
460 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
461 it as a large positive number.
462 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
463 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
465 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
466 in case result does not fit in int.
468 * print.c (float_to_string): Detect width overflow more reliably.
469 (print_object): Make sprintf buffer a bit bigger, to avoid potential
470 buffer overrun. Don't assume list length fits in 'int'. Treat
471 print length of 0 as 0, not as infinity; to be consistent with other
472 uses of print length in this function. Don't overflow print length
473 index. Don't assume hash table size fits in 'long', or that
474 vectorlike size fits in 'unsigned long'.
476 * process.c (make_process): Use printmax_t, not int, to format
477 process-name gensyms.
479 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
481 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
482 to avoid potential buffer overrun.
484 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
485 if X resource line is longer than 512 bytes.
487 * xfns.c (x_window): Make sprintf buffer a bit bigger
488 to avoid potential buffer overrun.
490 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
492 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
494 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
496 Integer overflow fixes for scrolling, etc.
497 Without these, Emacs silently mishandles large integers sometimes.
498 For example, "C-u 4294967297 M-x recenter" was treated as if
499 it were "C-u 1 M-x recenter" on a typical 64-bit host.
501 * xdisp.c (try_window_id): Check Emacs fixnum range before
504 * window.c (window_scroll_line_based, Frecenter):
505 Check that an Emacs fixnum is in range before assigning it to 'int'.
506 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
507 values converted from Emacs fixnums.
508 (Frecenter): Don't wrap around a line count if it is out of 'int'
509 range; instead, treat it as an extreme value.
510 (Fset_window_configuration, compare_window_configurations):
511 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
513 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
514 that can exceed INT_MAX. Check that EMACS_INT value is in range
515 before assigning it to the (possibly-narrower) index.
516 (match_limit): Don't assume that a fixnum can fit in 'int'.
518 * print.c (print_object): Use ptrdiff_t, not int, for index that can
521 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
522 (Fvertical_motion): Don't wrap around LINES values that don't fit
523 in 'int'. Instead, treat them as extreme values. This is good
524 enough for windows, which can't have more than INT_MAX lines anyway.
526 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
528 * Require libxml/parser.h to avoid compilation warning.
530 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
532 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
533 since this reportedly can destroy thread storage.
535 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
537 * syntax.c (find_defun_start): Update all cache variables if
538 exiting early (Bug#9401).
540 2011-08-30 Eli Zaretskii <eliz@gnu.org>
542 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
544 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
545 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
546 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
548 * term.c (tty_append_glyph): New function.
549 (produce_stretch_glyph): Static function and its prototype deleted.
551 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
554 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
556 * image.c (parse_image_spec): Check for nonnegative, not for positive,
557 when checking :margin (Bug#9390).
558 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
559 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
560 so that the name doesn't mislead. All uses changed.
562 2011-08-28 Johan Bockgård <bojohan@gnu.org>
564 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
567 2011-08-27 Eli Zaretskii <eliz@gnu.org>
569 * xdisp.c (move_it_to): Don't bail out early when reaching
570 position beyond to_charpos, if we are scanning backwards.
571 (move_it_vertically_backward): When DY == 0, make sure we get to
572 the first character in the line after the newline.
574 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
576 * ccl.c: Improve and simplify overflow checking (Bug#9196).
577 (ccl_driver): Do not generate an out-of-range pointer.
578 (Fccl_execute_on_string): Remove unnecessary check for
579 integer overflow, noted by Stefan Monnier in
580 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
581 Remove a FIXME that didn't need fixing.
582 Simplify the newly-introduced buffer reallocation code.
584 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
586 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
588 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
590 Integer and memory overflow issues (Bug#9196).
592 * doc.c (get_doc_string): Rework so that
593 get_doc_string_buffer_size is the actual buffer size, rather than
594 being 1 less than the actual buffer size; this makes xpalloc more
597 * image.c (x_allocate_bitmap_record, cache_image):
598 * xselect.c (Fx_register_dnd_atom):
599 Simplify previous changes by using xpalloc.
601 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
602 since either will do and ptrdiff_t is convenient with xpalloc.
604 * charset.c (charset_table_size)
605 (struct charset_sort_data.priority): Now ptrdiff_t.
606 (charset_compare): Don't overflow if priorities differ greatly.
607 (Fsort_charsets): Don't assume list length fits in int.
608 Check for size-calculation overflow when allocating sort data.
609 (syms_of_charset): Allocate an initial charset table that is
610 just under 64 KiB, to avoid problems with glibc malloc and mmap.
612 * cmds.c (internal_self_insert): Check for size-calculation overflow.
614 * composite.h (struct composition.glyph_len): Now int, not unsigned.
615 The actual value is always <= INT_MAX, and leaving it unsigned made
616 overflow checking harder.
618 * dispextern.h (struct glyph_matrix.rows_allocated)
619 (struct face_cache.size): Now ptrdiff_t, for convenience in use
620 with xpalloc. The values are still always <= INT_MAX.
622 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
624 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
625 (SAFE_NALLOCA): New macro.
627 * region-cache.c (struct boundary.pos, find_cache_boundary)
628 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
629 (set_cache_region, invalidate_region_cache)
630 (revalidate_region_cache, know_region_cache, region_cache_forward)
631 (region_cache_backward, pp_cache):
632 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
633 so that ptrdiff_t * can be passed to xpalloc.
634 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
635 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
636 (pp_cache): Don't assume cache_len fits in int.
637 * region-cache.h: Adjust extern decls to match.
639 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
640 EMACS_INT, since either will do, for xpalloc.
642 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
643 (xnmalloc, xnrealloc, xpalloc): New functions.
645 * bidi.c (bidi_shelve_header_size): New constant.
646 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
647 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
649 * bidi.c (bidi_cache_shrink):
650 * buffer.c (overlays_at, overlays_in, record_overlay_string)
652 Don't update size of array until after memory allocation succeeds,
653 because xmalloc/xrealloc may not return.
654 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
655 now that we have proper integer overflow checking.
656 (record_overlay_string, overlay_strings): Catch overflows when
657 calculating size of overlay_str_buf.
659 * callproc.c (Fcall_process): Check for size overflow when
660 calculating size of args2.
661 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
662 Normally we prefer signed values, but sticking with ptrdiff_t would
663 require adding more-complicated checks.
665 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
666 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
667 Redo buffer-overflow calculations to avoid integer overflow.
668 Add a FIXME comment where memory seems to be over-allocated.
670 * character.c (Fstring): Check for size-calculation overflow.
672 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
673 unnecessary integer overflow. Check for size overflow.
674 (encode_coding_object): Don't update size until xmalloc succeeds.
676 * composite.c (get_composition_id): Check for overflow in glyph
679 Integer and memory overflow fixes for display code.
680 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
681 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
682 (scrolling_window): Check for overflow in size calculations.
683 (line_draw_cost, realloc_glyph_pool, add_row_entry):
684 Don't assume glyph table len fits in int.
685 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
686 (row_table_size): Now ptrdiff_t, not int.
687 (scrolling_window): Avoid overflow in size calculations.
688 Don't update size until allocation succeeds.
689 * fns.c (concat): Check for overflow in size calculations.
690 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
691 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
692 (NEXT_ALMOST_PRIME_LIMIT): New constant.
694 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
695 (get_doc_string): Check for size calculation overflow.
696 Don't update size until allocation succeeds.
697 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
698 EMACS_INT, where ptrdiff_t will do.
699 (Fsubstitute_command_keys): Check for string overflow.
701 * editfns.c (set_time_zone_rule): Don't assume environment length
703 (message_length): Now ptrdiff_t, not int.
704 (Fmessage_box): Don't update size until allocation succeeds.
705 Don't assume message length fits in int.
706 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
708 * emacs.c (main): Do not reallocate argv, since there is a null at
709 the end that can be overwritten, and this way there's no need to
710 worry about size-calculation overflow.
711 (sort_args): Check for size-calculation overflow.
713 * eval.c (init_eval_once, grow_specpdl): Don't update size until
715 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
717 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
718 (x_set_scroll_bar_width, x_figure_window_size):
719 Check for integer overflow.
720 (x_set_alpha): Do not assume XINT fits in int.
722 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
723 This is for the members text_lines, text_cols, total_lines, total_cols,
724 where the system imposes an 'int' limit.
726 * fringe.c (Fdefine_fringe_bitmap):
727 Don't update size until alloc works.
729 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
730 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
732 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
733 Check for size-calculation overflow.
734 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
735 do, as we prefer signed integers.
736 (id_to_widget.max_size, id_to_widget.used)
737 (xg_store_widget_in_map, xg_remove_widget_from_map)
738 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
739 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
740 Use and return ptrdiff_t, not int.
741 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
742 * gtkutil.h: Change prototypes to match the above.
744 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
745 are duplicate now that they've been promoted to lisp.h.
746 (x_allocate_bitmap_record, x_alloc_image_color)
747 (make_image_cache, cache_image, xpm_load):
748 Don't update size until alloc is done.
749 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
751 Check for size calculation overflow.
752 (ct_colors_allocated_max): New constant.
753 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
756 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
757 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
758 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
759 Use ptrdiff_t, not int, to count maps.
760 (read_char_minibuf_menu_prompt): Check for overflow in size
761 calculations. Don't update size until allocation succeeds. Redo
762 calculations to avoid overflow.
763 * keyboard.h: Change prototypes to match the above.
765 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
767 (current_minor_maps): Check for size calculation overflow.
768 * keymap.h: Change prototypes to match the above.
770 * lread.c (read1, init_obarray): Don't update size until alloc done.
772 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
773 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
775 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
776 Now ptrdiff_t, not int.
777 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
778 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
780 * process.c (Fnetwork_interface_list): Check for overflow
783 * region-cache.c (move_cache_gap): Check for size calculation overflow.
785 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
786 overflow. Don't bother calling xmalloc when xrealloc will do.
788 * search.c (Freplace_match): Check for size calculation overflow.
789 (Fset_match_data): Don't assume list lengths fit in 'int'.
791 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
792 for command line length. Do not attempt to address one before the
793 beginning of an array, as that's not portable.
795 * term.c (max_frame_lines): Remove; unused.
796 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
798 (encode_terminal_code, calculate_costs): Check for size
799 calculation overflow.
800 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
801 table lengths and related sizes. Don't update size until alloc
802 done. Redo calculations to avoid overflow.
803 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
805 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
806 subtracting pointers.
807 (gobble_line): Check for overflow more carefully. Don't update size
810 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
811 Don't update size until alloc done.
812 Redo size calculations to avoid overflow.
813 Check for size calculation overflow.
814 (main) [DEBUG]: Fix typo in invoking tparam1.
816 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
817 Use ptrdiff_t, not int, for sizes.
818 (store_mode_line_noprop_char): Don't update size until alloc done.
820 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
821 Use ptrdiff_t, not int, for sizes.
822 (Finternal_make_lisp_face, cache_face):
823 Check for size calculation overflow.
824 (cache_face): Treat size calculation overflows as if they were
825 memory exhaustion (the usual treatment), rather than aborting.
827 * xfns.c (x_encode_text, x_set_name_internal)
828 (Fx_change_window_property): Use ptrdiff_t, not int, to count
829 sizes, since they can exceed INT_MAX in size. Check for size
830 calculation overflow.
832 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
833 (xg_select): Check for size calculation overflow.
834 Don't update size until alloc done.
836 * xrdb.c (get_environ_db): Don't assume path length fits in int,
837 as sprintf is limited to int lengths.
839 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
840 (X_LONG_MIN): New macros.
841 Use them to make the following changes clearer.
842 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
843 This change doesn't affect the value now, but it may help remind
844 future maintainers not to raise the value too much later.
845 (SELECTION_QUANTUM): Remove, replacing with ...
846 (selection_quantum): ... new function, which avoids overflow.
848 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
849 assumption that selection length fits in 'int'.
850 (x_reply_selection_request, x_handle_selection_request)
851 (x_get_window_property, receive_incremental_selection)
852 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
853 (lisp_data_to_selection_data, clean_local_selection_data):
854 Use ptrdiff_t, not int, to record length of selection.
855 (x_reply_selection_request, x_get_window_property)
856 (receive_incremental_selection, x_property_data_to_lisp):
857 Redo calculations to avoid overflow.
858 (x_reply_selection_request): When sending hint, ceiling it at
859 X_LONG_MAX rather than relying on wraparound overflow to send
861 (x_get_window_property, receive_incremental_selection)
862 (lisp_data_to_selection_data, x_property_data_to_lisp):
863 Check for size-calculation overflow.
864 (x_get_window_property, receive_incremental_selection)
865 (lisp_data_to_selection_data, Fx_register_dnd_atom):
866 Don't store size until memory allocation succeeds.
867 (x_get_window_property): Plug memory leak on memory exhaustion.
868 Don't double-block input; malloc is safe here. Don't assume 2**34
869 - 4 fits in unsigned long. Add an xassert to check
870 XGetWindowProperty overflow. Be more careful about overflow
871 calculations, and distinguish size from memory overflow better.
872 (receive_incremental_selection): When tracing, don't assume
873 unsigned int is less than INT_MAX.
874 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
875 harmful) conversions of unsigned short to int.
876 (lisp_data_to_selection_data): Don't assume that integers
877 in the range -65535 through -1 fit in an X unsigned short.
878 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
879 result parameters unless successful. Rely on cons_to_unsigned
880 to report problems with elements; the old code wasn't right anyway.
881 (x_check_property_data): Check for int overflow; we cannot use
882 a wider type due to X limits.
883 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
885 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
887 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
888 (x_term_init): Check for size calculation overflow.
889 (x_color_cells): Don't store size until memory allocation succeeds.
890 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
891 Don't assume alloca size is less than MAX_ALLOCA.
892 (x_term_init): Don't assume length fits in int (sprintf is limited
895 Use ptrdiff_t for composition IDs.
896 * character.c (lisp_string_width):
897 * composite.c (composition_table_size, n_compositions)
898 (get_composition_id, composition_gstring_from_id):
899 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
900 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
901 * window.c (Frecenter):
902 Use ptrdiff_t, not int, for composition IDs.
903 * composite.c (get_composition_id): Check for integer overflow.
904 * composite.h: Adjust prototypes to match the above changes.
906 Use ptrdiff_t for hash table indexes.
907 * category.c (hash_get_category_set):
908 * ccl.c (ccl_driver):
909 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
910 * coding.c (coding_system_charset_list, detect_coding_system):
911 * coding.h (struct coding_system.id):
912 * composite.c (get_composition_id, gstring_lookup_cache):
913 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
914 * image.c (xpm_get_color_table_h):
915 * lisp.h (hash_lookup, hash_put):
916 * minibuf.c (Ftest_completion):
917 Use ptrdiff_t for hash table indexes, not int (which is too
918 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
919 32-bit --with-wide-int hosts).
921 * charset.c (Fdefine_charset_internal): Check for integer overflow.
922 Add a FIXME comment about memory leaks.
923 (syms_of_charset): Don't assume xmalloc returns.
925 Don't assume that stated character widths fit in int.
926 * character.c (Fchar_width, c_string_width, lisp_string_width):
927 * character.h (CHAR_WIDTH):
928 * indent.c (MULTIBYTE_BYTES_WIDTH):
929 Use sanitize_char_width to avoid undefined and/or bad behavior
930 with outlandish widths.
931 * character.h (sanitize_tab_width): Renamed from sanitize_width,
932 now that we have two such functions. All uses changed.
933 (sanitize_char_width): New inline function.
935 Don't assume that tab-width fits in int.
936 * character.h (sanitize_width): New inline function.
937 (SANE_TAB_WIDTH): New macro.
938 (ASCII_CHAR_WIDTH): Use it.
939 * indent.c (sane_tab_width): Remove. All uses replaced by
940 SANE_TAB_WIDTH (current_buffer).
941 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
943 * fileio.c: Integer overflow issues with file modes.
944 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
946 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
947 Remove unreachable code.
948 (read_hex, load_charset_map_from_file): Check for integer overflow.
950 * xterm.c: don't go over XClientMessageEvent limit
951 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
952 (x_send_scroll_bar_event): Likewise. Check that the size does not
953 exceed limits imposed by XClientMessageEvent, as well as the usual
954 ptrdiff_t and size_t limits.
956 * keyboard.c: Overflow, signedness and related fixes.
957 (make_lispy_movement): Use same integer type in forward decl
958 that is used in the definition.
959 (read_key_sequence, keyremap_step):
960 Change bufsize argument back to int, undoing my 2011-03-30 change.
961 We prefer signed types, and int is wide enough here.
962 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
963 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
964 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
965 length, not size_t. Use ptrdiff_t for index, not int.
966 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
967 possibility of integer overflow.
969 Overflow, signedness and related fixes for images.
971 * dispextern.h (struct it.stack[0].u.image.image_id)
972 (struct_it.image_id, struct image.id, struct image_cache.size)
973 (struct image_cache.used, struct image_cache.ref_count):
974 * gtkutil.c (update_frame_tool_bar):
975 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
976 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
977 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
978 * nsmenu.m (update_frame_tool_bar):
979 * xdisp.c (calc_pixel_width_or_height):
980 * xfns.c (image_cache_refcount):
981 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
982 on typical 64-bit hosts.
984 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
985 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
986 Omit unnecessary casts to int.
987 (parse_image_spec): Check that integers fall into 'int' range
988 when the callers expect that.
989 (image_ascent): Redo ascent calculation to avoid int overflow.
990 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
991 (lookup_image): Remove unnecessary tests.
992 (xbm_image_p): Locals are now of int, not EMACS_INT,
993 since parse_image_check makes sure they fit into int.
994 (png_load, gif_load, svg_load_image):
995 Prefer int to unsigned where either will do.
996 (tiff_handler): New function, combining the cores of the
997 old tiff_error_handler and tiff_warning_handler. This
998 function is rewritten to use vsnprintf and thereby avoid
999 stack buffer overflows. It uses only the features of vsnprintf
1000 that are common to both POSIX and native Microsoft.
1001 (tiff_error_handler, tiff_warning_handler): Use it.
1002 (tiff_load, gif_load, imagemagick_load_image):
1003 Don't assume :index value fits in 'int'.
1004 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1005 (imagemagick_load_image): Check that crop parameters fit into
1006 the integer types that MagickCropImage accepts. Don't assume
1007 Vimagemagick_render_type has a nonnegative value. Don't assume
1008 size_t fits in 'long'.
1009 (gs_load): Use printmax_t to print the widest integers possible.
1010 Check for integer overflow when computing image height and width.
1012 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1014 * xdisp.c (redisplay_window): Don't force window start if point
1015 will be invisible in the resulting window. (Bug#9324)
1017 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1019 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1020 the display spec is of the form `(space ...)'.
1021 (handle_display_spec): Return the value returned by
1022 handle_single_display_spec, not just 1 or zero.
1023 (handle_single_display_spec): If the display spec is of the form
1024 `(space ...)', and specifies display in the text area, return 2
1026 (try_cursor_movement): Check for the need to scroll more
1027 accurately, and prefer exact match for point under bidi. Don't
1028 advance `row' beyond the last row of the window.
1030 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1031 into disp_prop; all users changed.
1033 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1034 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1035 for the text covered by the display property.
1037 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1039 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1040 Change return value to nil.
1041 (Frecord_buffer): Delete unused function.
1043 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1045 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1046 buffers, return left-to-right.
1047 (set_cursor_from_row): Consider candidate row a win if its glyph
1048 represents a newline and point is on that newline. Fixes cursor
1049 positioning on the newline at EOL of R2L text within L2R
1050 paragraph, and vice versa.
1051 (try_cursor_movement): Check continued rows, in addition to
1052 continuation rows. Fixes unwarranted scroll when point enters a
1053 continued line of R2L text within an L2R paragraph, or vice versa.
1054 (cursor_row_p): Consider the case of point being equal to
1055 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1056 from the end of a short line to the beginning of a continued line
1057 of R2L text within L2R paragraph.
1058 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1059 composed characters.
1061 * bidi.c (bidi_check_type): Use xassert.
1062 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1065 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1067 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1070 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1072 * nsfont.m (ns_otf_to_script): Fix typo.
1074 2011-08-22 Kenichi Handa <handa@m17n.org>
1076 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1077 extra slot even if the purpose is char-code-property-table.
1079 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1081 * xdisp.c (redisplay_window): When computing centering_position,
1082 account for the height of the header line. (Bug#8874)
1084 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1085 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1086 candidate is selected by the mouse, and that candidate has a
1087 composed character under the mouse.
1089 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1090 coordinates reported by pos-visible-in-window-p for a composed
1091 character in column zero.
1093 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1095 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1097 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1099 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1100 consider it a hit if to_charpos is anywhere in the range of the
1101 composed buffer positions.
1103 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1105 * image.c (gif_load): Don't assume that each subimage has the same
1106 dimensions as the base image. Handle disposal method that is
1107 "undefined" by the gif spec (Bug#9335).
1109 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1111 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1112 (Fcondition_case): Document `debug' symbol in error handler.
1114 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1116 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1117 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1118 from an Org mode buffer to a Speedbar frame.
1120 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1121 a composition, take its buffer position from IT->cmp_it.charpos.
1122 Fixes cursor positioning at the beginning of a line that begins
1123 with a composed character.
1125 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1127 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1128 character bidirectional type, use STRONG_L instead. Fixes crashes
1129 in a buffer produced by `describe-categories'.
1131 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1132 members before the level stack, so they would be saved and
1133 restored when copying iterator state. Fixes incorrect reordering
1134 around TABs covered by display properties.
1136 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1138 * process.c (Fnetwork_interface_list): Correctly determine buffer
1141 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1143 * eval.c (internal_condition_case, internal_condition_case_1)
1144 (internal_condition_case_2, internal_condition_case_n):
1145 Remove unnecessary aborts (Bug#9081).
1147 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1149 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1150 has no `load' handler, try opening the file locally. (Bug#9311)
1152 2011-08-16 Ken Brown <kbrown@cornell.edu>
1154 * gmalloc.c: Expand comment.
1156 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1158 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1159 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1161 2011-08-16 Ken Brown <kbrown@cornell.edu>
1163 Fix memory allocation problems in Cygwin build (Bug#9273).
1165 * unexcw.c ( __malloc_initialized): Declare external variable.
1166 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1168 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1170 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1172 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1174 [CYGWIN] (special_realloc): New function.
1175 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1176 requests to realloc storage in the static heap.
1178 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1180 * bidi.c (bidi_initialize): Remove unused local.
1182 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1184 * biditype.h: File removed.
1186 * bidimirror.h: File removed.
1188 * deps.mk (bidi.o): Remove biditype.h and
1191 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1194 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1196 * chartab.c: Improve commentary for the uniprop_table API.
1198 * bidi.c (bidi_paragraph_init): Support zero value of
1199 bidi_ignore_explicit_marks_for_paragraph_level.
1200 (bidi_initialize): Use uniprop_table instead of including
1201 biditype.h and bidimirror.h.
1203 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1204 coordinates of the iterator when restoring from ppos_it.
1207 2011-08-14 Kenichi Handa <handa@m17n.org>
1209 * process.c (create_process): Call setup_process_coding_systems
1210 after the pid of the process is set to -1 (Bug#8162).
1212 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1214 * xdisp.c (move_it_in_display_line_to): Don't invoke
1215 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1216 ppos_it. Fixes vertical cursor motion when line beginning is
1217 covered by an image. (Bug#9296)
1219 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1221 * nsterm.h (ns_run_ascript): Declare.
1222 (NSAPP_DATA2_RUNASSCRIPT): Define.
1224 * nsfns.m (as_script, as_result, as_status): New static variables.
1225 (ns_run_ascript): New function.
1226 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1227 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1228 the event loop. Get status from as_status (Bug#7276).
1230 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1231 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1232 the event loop (Bug#7276).
1234 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1236 * gnutls.c (QCgnutls_bootprop_priority)
1237 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1238 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1239 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1240 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1241 (QCgnutls_bootprop_verify_hostname_error)
1242 (QCgnutls_bootprop_callbacks_verify): Rename from
1243 Qgnutls_bootprop_..., all uses changed.
1245 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1248 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1250 * xfaces.c (Qframe_set_background_mode): Now static.
1251 * dispextern.h (Qframe_set_background_mode): Remove decl.
1253 * process.c (Fnetwork_interface_info): Declare local only if needed.
1255 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1257 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1258 (Fnetwork_interface_list): Allocate in increments of bytes instead
1259 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1260 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1262 (struct ifflag_def): notrailers is smart on OSX.
1263 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1264 Get hardware address with getifaddrs if available.
1266 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1268 * xdisp.c (iterate_out_of_display_property): xassert that
1269 IT->position is set to within IT->object's boundaries. Break from
1270 the loop as soon as EOB is reached; avoids infloops in redisplay
1271 when IT->position is set up wrongly due to some bug.
1272 Set IT->current to match the bidi iterator unconditionally.
1273 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1274 entry. Force push_it to save on the stack the current
1275 buffer/string position, to be restored by pop_it. Fix flags in
1276 the iterator structure wrt the object coming from a display
1277 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1278 properties. (Bug#9284)
1280 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1282 * fontset.c (fontset_get_font_group): Add proper type checks.
1285 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1287 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1288 and LC_VERSION_MIN_MACOSX.
1289 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1290 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1292 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1294 * xdisp.c (forward_to_next_line_start): Allow to use the
1295 no-display-properties-and-no-overlays under bidi display.
1296 Set disp_pos in the bidi iterator to avoid searches for display
1297 properties and overlays.
1299 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1301 * editfns.c (Fset_time_zone_rule): Document relationship with the
1304 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1305 the font entity extracted from the cache (Bug#8109).
1307 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1309 * composite.c (autocmp_chars): Don't reset point. That is done by
1310 restore_point_unwind (Bug#5984).
1312 2011-08-07 Juri Linkov <juri@jurta.org>
1314 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1315 to show the arg `TIME' instead of `TIMEVAL'.
1317 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1319 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1320 display property strides EOL and includes a newline, as in
1321 longlines-mode. (Bug#9254)
1322 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1323 word-wrap under bidirectional display. (Bug#9224)
1325 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1326 is non-zero, even if the data buffer is NULL. Fixes a crash in
1327 vertical-motion with longlines-mode. (Bug#9254)
1329 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1331 * bidi.c <bidi_cache_total_alloc>: Now static.
1332 (bidi_initialize): Initialize bidi_cache_total_alloc.
1334 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1337 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1338 amount allocated this far in `bidi_cache_total_alloc'.
1339 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1340 non-zero, only free the data buffer without restoring the cache
1341 contents. All callers changed.
1343 * dispextern.h (bidi_unshelve_cache): Update prototype.
1345 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1346 (move_it_in_display_line, move_it_to)
1347 (move_it_vertically_backward, move_it_by_lines): Replace the call
1348 to xfree to an equivalent call to bidi_unshelve_cache.
1349 (move_it_in_display_line_to): Fix logic of returning
1350 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1352 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1354 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1355 came from a string character with a `cursor' property. (Bug#9229)
1357 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1359 * Makefile.in (LIB_PTHREAD): New variable.
1360 (LIBES): Add LIB_PTHREAD (Bug#9216).
1362 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1363 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1365 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1367 * regex.c (re_iswctype): Remove some redundant boolean
1370 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1372 * xterm.c (x_find_topmost_parent): New function.
1373 (x_set_frame_alpha): Find topmost parent window with
1374 x_find_topmost_parent and set the property there also (bug#9181).
1375 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1377 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1379 * callproc.c (Fcall_process): Avoid vfork clobbering
1380 the local vars buffer, coding_systems, current_dir.
1382 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1384 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1386 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1388 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1389 so that it is not optimized away.
1391 * xdisp.c (compute_display_string_pos): Remove unused local.
1393 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1395 Fix slow cursor motion and scrolling in large buffers with
1396 selective display, like Org Mode buffers. (Bug#9218)
1398 * dispextern.h (struct bidi_it): New member disp_prop_p.
1400 * xdisp.c: Remove one-slot cache of display string positions.
1401 (compute_display_string_pos): Accept an additional argument
1402 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1403 for a display string or property. If found, set DISP_PROP_P
1406 * bidi.c (bidi_fetch_char): Accept an additional argument
1407 DISP_PROP_P, and pass it to compute_display_string_pos.
1408 Only handle text covered by a display string if DISP_PROP_P is returned
1409 non-zero. All callers of bidi_fetch_char changed.
1411 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1413 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1415 2010-12-03 Don March <don@ohspite.net>
1417 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1418 last character M-[char] is translated to ESC [char] (bug#7541).
1420 2011-08-02 Kenichi Handa <handa@m17n.org>
1422 * lisp.h (uniprop_table): Extern it.
1424 * chartab.c (uniprop_table): Make it non-static.
1426 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1428 * xdisp.c (forward_to_next_line_start): Accept additional argument
1429 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1431 (reseat_at_next_visible_line_start): Use the bidi iterator state
1432 returned by forward_to_next_line_start to restore the state of
1433 it->bidi_it after backing up to previous newline. (Bug#9212)
1435 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1437 * regex.c (re_comp): Protoize.
1438 (re_exec): Fix return type.
1439 (regexec): Fix type of `ret'. (Bug#9203)
1441 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1443 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1444 This is needed if max-image-size is a floating-point number.
1446 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1448 * print.c (print_object): Print empty symbol as ##.
1450 * lread.c (read1): Read ## as empty symbol.
1452 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1454 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1455 setting frame foreground color (Bug#9175).
1456 (x_set_background_color): Likewise.
1458 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1459 contents (Bug#9176).
1460 (EmacsTooltip -init): Remove bezels and add shadows to
1463 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1464 or scroll bar (Bug#8470).
1466 * nsfont.m (nsfont_open): Remove assignment to voffset and
1467 unnecessary vars hshink, expand, hd, full_height, min_height.
1468 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1470 * nsterm.h (nsfont_info): Remove voffset field.
1472 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1474 Implement strike-through and overline on NextStep (Bug#8863).
1476 * nsfont.m (nsfont_open): Use underline position provided by font,
1477 instead of hard-coded value of 2.
1478 (nsfont_draw): Call ns_draw_text_decoration instead.
1480 * nsterm.h: Add declaration for ns_draw_text_decoration.
1482 * nsterm.m (ns_draw_text_decoration): New function for drawing
1483 underline, overline, and strike-through.
1484 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1485 ns_draw_text_decoration. Change treatment of cursor drawing to
1486 accommodate underlining, etc.
1488 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1490 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1493 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1495 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1496 Without this fix, if a signal arrives just after memory fills up,
1497 'malloc' might be invoked reentrantly.
1499 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1500 In other words, assume that every image size is allowed, on non-X
1501 hosts. This assumption is probably wrong, but it lets Emacs compile.
1503 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1505 * regex.c (re_iswctype): Convert return values to boolean.
1507 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1509 * xdisp.c (compute_display_string_pos): Don't use cached display
1510 string position if the buffer had its restriction changed.
1513 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1515 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1517 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1519 Integer signedness and overflow and related fixes. (Bug#9079)
1521 * bidi.c: Integer size and overflow fixes.
1522 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1523 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1524 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1525 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1526 (bidi_find_other_level_edge):
1527 Use ptrdiff_t instead of EMACS_INT where either will do.
1528 This works better on 32-bit hosts configured --with-wide-int.
1529 (bidi_cache_ensure_space): Check for size-calculation overflow.
1530 Use % rather than repeated addition, for better worst-case speed.
1531 Don't set bidi_cache_size until after xrealloc returns, because it
1533 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1534 (bidi_cache_ensure_space): Also check that the bidi cache size
1535 does not exceed that of the largest Lisp string or buffer. See Eli
1536 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1538 * alloc.c (__malloc_size_t): Remove.
1539 All uses replaced by size_t. See Andreas Schwab's note
1540 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1542 * image.c: Improve checking for integer overflow.
1543 (check_image_size): Assume that f is nonnull, since
1544 it is always nonnull in practice. This is one less thing to
1545 worry about when checking for integer overflow later.
1546 (x_check_image_size): New function, which checks for integer
1547 overflow issues inside X.
1548 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1549 This removes the need for a memory_full check.
1550 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1551 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1552 (xbm_read_bitmap_data): Change locals back to 'int', since
1553 their values must fit in 'int'.
1554 (xpm_load_image, png_load, tiff_load):
1555 Invoke x_create_x_image_and_pixmap earlier,
1556 to avoid much needless work if the image is too large.
1557 (tiff_load): Treat overly large images as if
1558 x_create_x_image_and_pixmap failed, not as malloc failures.
1559 (gs_load): Use x_check_image_size.
1561 * gtkutil.c: Omit integer casts.
1562 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1563 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1565 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1567 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1568 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1569 would wrongly return t on a 64-bit host.
1571 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1572 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1573 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1574 and therefore cause GCC to emit a bogus diagnostic in some cases.
1576 * image.c: Integer signedness and overflow and related fixes.
1577 This is not an exhaustive set of fixes, but it's time to
1578 record what I've got.
1579 (lookup_pixel_color, check_image_size): Remove redundant decls.
1580 (check_image_size): Don't assume that arbitrary EMACS_INT values
1581 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1582 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1583 (tiff_load, imagemagick_load_image):
1584 Check for overflow in size calculations.
1585 (x_create_x_image_and_pixmap): Remove unnecessary test for
1586 xmalloc returning NULL; that can't happen.
1587 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1588 (xpm_color_bucket): Use better integer hashing function.
1589 (xpm_cache_color): Don't possibly over-allocate memory.
1590 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1591 (gif_memory_source):
1592 Use ptrdiff_t, not int or size_t, to record sizes.
1593 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1594 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1595 either works, as we prefer signed integers.
1596 (tiff_read_from_memory, tiff_write_from_memory):
1597 Return tsize_t, not size_t, since that's what the TIFF API wants.
1598 (tiff_read_from_memory): Don't fail simply because the read would
1599 go past EOF; instead, return a short read.
1600 (tiff_load): Omit no-longer-needed casts.
1601 (Fimagemagick_types): Don't assume size fits into 'int'.
1603 Improve hashing quality when configured --with-wide-int.
1604 * fns.c (hash_string): New function, taken from sxhash_string.
1605 Do not discard information about ASCII character case; this
1606 discarding is no longer needed.
1607 (sxhash-string): Use it. Change sig to match it. Caller changed.
1608 * lisp.h: Declare it.
1609 * lread.c (hash_string): Remove, since we now use fns.c's version.
1610 The fns.c version returns a wider integer if --with-wide-int is
1611 specified, so this should help the quality of the hashing a bit.
1613 * emacs.c: Integer overflow minor fix.
1614 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1615 Define only if GNU_LINUX.
1616 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1618 * dispnew.c: Integer signedness and overflow fixes.
1619 Remove unnecessary forward decls, that were a maintenance hassle.
1620 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1622 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1623 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1624 (prepare_desired_row, line_draw_cost):
1625 Use int, not unsigned, where either works.
1626 (save_current_matrix, restore_current_matrix):
1627 Use ptrdiff_t, not size_t, where either works.
1628 (init_display): Check for overflow more accurately, and without
1629 relying on undefined behavior.
1631 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1632 Remove, replacing with the new symbols in lisp.h. All uses changed.
1633 * fileio.c (make_temp_name):
1634 * filelock.c (lock_file_1, lock_file):
1635 * xdisp.c (message_dolog):
1636 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1637 Use pMd etc. instead.
1638 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1639 replacing the pWIDE etc. symbols removed from editfns.c.
1641 * keyboard.h (num_input_events): Now uintmax_t.
1642 This is (very slightly) less likely to mess up due to wraparound.
1645 * buffer.c: Integer signedness fixes.
1646 (alloc_buffer_text, enlarge_buffer_text):
1647 Use ptrdiff_t rather than size_t when either will do, as we prefer
1650 * alloc.c: Integer signedness and overflow fixes.
1651 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1652 (__malloc_size_t): Default to size_t, not to int.
1653 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1654 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1655 Prefer ptrdiff_t to size_t when either would do, as we prefer
1657 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1658 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1659 Now const. Initialize with values that are in range even if char
1661 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1662 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1663 These functions do the right thing with sizes > 2**32.
1664 (check_depth): Now ptrdiff_t, not int.
1665 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1666 Adjust to new way of storing sizes. Check for size overflow bugs
1668 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1669 slightly wrong anyway, as it missed one instance of
1670 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1671 (refill_memory_reserve): Omit needless cast to size_t.
1672 (mark_object_loop_halt): Mark as externally visible.
1674 * xselect.c: Integer signedness and overflow fixes.
1675 (Fx_register_dnd_atom, x_handle_dnd_message):
1676 Use ptrdiff_t, not size_t, since we prefer signed.
1677 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1678 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1679 x_dnd_atoms_size and x_dnd_atoms_length.
1681 * doprnt.c: Prefer signed to unsigned when either works.
1683 * doprnt.c (doprnt):
1685 * xdisp.c (vmessage):
1686 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1687 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1688 prefer signed arithmetic to avoid comparison confusion.
1689 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1690 but is a bit tricky.
1692 Assume freestanding C89 headers, string.h, stdlib.h.
1693 * data.c, doprnt.c, floatfns.c, print.c:
1694 Include float.h unconditionally.
1695 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1696 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1697 * regex.c: Likewise for stddef.h, string.h.
1698 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1699 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1700 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1701 (STDC_HEADERS): Remove obsolete defines.
1702 * sysdep.c: Include limits.h unconditionally.
1704 Assume support for memcmp, memcpy, memmove, memset.
1705 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1706 * regex.c (memcmp, memcpy):
1707 Remove; we assume C89 now.
1709 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1710 (__malloc_safe_bcopy): Remove; no longer needed.
1712 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1713 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1714 well either way, and we prefer signed to unsigned.
1716 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1718 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1719 closes the connection while we're reading (bug#9182).
1721 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1723 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1724 are specified (Bug#9168).
1726 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1728 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1729 Found by GCC static checking and --with-wide-int on a 32-bit host.
1731 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1733 * xdisp.c (compute_display_string_pos): Fix logic of caching
1734 previous display string position. Initialize cached_prev_pos to
1735 -1. Fixes slow-down at the beginning of a buffer.
1737 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1739 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1740 for attrs[LFACE_FONTSET_INDEX].
1742 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1744 * xml.c (parse_region): Remove unused local
1745 that was recently introduced.
1747 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1749 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1750 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1752 * xdisp.c (move_it_in_display_line_to): Record the best matching
1753 position for TO_CHARPOS while scanning the line, and restore it on
1754 exit if none of the characters scanned was an exact match.
1755 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1756 when exact match is impossible due to invisible text, and the
1757 lines are truncated.
1759 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1761 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1764 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1766 Fix a significant slow-down of cursor motion with C-n, C-p,
1767 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1768 auto-repeat under bidi redisplay in fontified buffers.
1769 * xdisp.c (compute_stop_pos_backwards): New function.
1770 (next_element_from_buffer): Call compute_stop_pos_backwards to
1771 find a suitable prev_stop when we find ourselves before
1773 (reseat): Don't look for prev_stop, as that could mean a very long
1775 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1776 <cached_disp_overlay_modiff>: Cache for last found display string
1778 (compute_display_string_pos): Return the cached position if asked
1779 about the same buffer in the same area of character positions, and
1780 the buffer wasn't changed since the time the display string
1781 position was cached.
1783 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1785 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1786 is an integer, which is important for empty lines. (Bug#9149)
1788 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1790 * frame.c (Fmodify_frame_parameters): In tty case, update the
1791 default face if necessary (Bug#4238).
1793 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1795 * editfns.c (Fstring_to_char): No need to explain what a character
1796 is in the docstring (Bug#6576).
1798 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1800 * xml.c (parse_region): Make sure we always return a tree.
1802 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1804 * xml.c (parse_region): If a document contains only comments,
1807 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1809 * xml.c (make_dom): Return comments, too.
1811 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1814 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1815 and the surrounding thread.
1816 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1817 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1818 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1820 * s/openbsd.h (BROKEN_SIGIO): Define.
1821 * unexelf.c (unexec) [__OpenBSD__]:
1822 Don't update the .mdebug section of the Alpha COFF symbol table.
1824 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1826 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1829 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1831 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1832 This fixes some race conditions on the permissions of any newly
1835 * alloc.c (valid_pointer_p): Use pipe, not open.
1836 This fixes some permissions issues when debugging.
1838 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1839 If fchown fails to set both uid and gid, try to set just gid,
1840 as that is sometimes allowed. Adjust the file's mode to eliminate
1841 setuid or setgid bits that are inappropriate if fchown fails.
1843 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1845 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1846 to compare Lisp_Objects.
1847 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1848 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1849 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1851 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1853 * lread.c (read_integer): Unread even EOF character.
1854 (read1): Likewise. Properly record start position of symbol.
1856 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1857 symbol character follows.
1859 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1861 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1862 This works around a problem with the previous change to Fcopy_file.
1863 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1864 and without this change, GCC might complain about discarding
1865 fchown's return value.
1867 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1869 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1871 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1873 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1875 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1877 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1878 it's used from the C level.
1880 * process.c: Use the same condition for POLL_FOR_INPUT in both
1881 keyboard.c and process.c (bug#1858).
1883 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1885 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1886 (Fgnutls_boot): Use it.
1888 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1890 * doc.c (Fsubstitute_command_keys): Revert last change.
1892 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1894 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1895 quotes the next character, and doesn't affect other longer
1896 sequences (bug#8935).
1898 * lread.c (syms_of_lread): Clarify that is isn't only
1899 `eval-buffer' and `eval-defun' that's affected by
1900 `lexical-binding' (bug#8460).
1902 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1904 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1905 bidi redisplay when a line includes both an image and is
1908 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1910 Fix minor problems found by static checking.
1911 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1912 (elsz): Now a signed constant, not a size_t var. We prefer signed
1913 types to unsigned, to avoid integer comparison confusion. Without
1914 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1915 "cannot optimize loop, the loop counter may overflow", a symptom
1917 * indent.c (Fvertical_motion): Mark locals as initialized.
1918 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1920 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1922 * search.c (Fre_search_backward): Mention `case-fold-search' in
1923 all the re_search_* functions (bug#8138).
1925 * keyboard.c (Fopen_dribble_file): Document when the file is
1928 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1930 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1933 Support bidi reordering of display and overlay strings.
1934 * xdisp.c (compute_display_string_pos)
1935 (compute_display_string_end): Accept additional argument STRING.
1936 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1937 (reseat_to_string): Initialize bidi_it->string.s and
1938 bidi_it->string.schars.
1939 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1940 NULL (avoids a crash in bidi_paragraph_init).
1941 Initialize itb.string.lstring.
1942 (init_iterator): Call bidi_init_it only of a valid
1943 buffer position was specified. Initialize paragraph_embedding to
1945 (reseat_to_string): Initialize the bidi iterator.
1946 (display_string): If we need to ignore text properties of
1947 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1948 original value of -1 will not work with bidi.)
1949 (compute_display_string_pos): First arg is now struct
1950 `text_pos *'; all callers changed. Support display properties on
1952 (compute_display_string_end): Support display properties on Lisp
1954 (init_iterator, reseat_1, reseat_to_string): Initialize the
1955 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1956 when iterating on a string not from display properties).
1957 (compute_display_string_pos, compute_display_string_end):
1958 Fix calculation of the object to scan. Fixes an error when using
1960 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1961 base_level_stop; instead, set base_level_stop to BEGV.
1962 Fixes crashes in vertical-motion.
1963 (next_element_from_buffer): Improve commentary for when
1964 the iterator is before prev_stop.
1965 (init_iterator): Initialize bidi_p from the default value of
1966 bidi-display-reordering, not from buffer-local value. Use the
1967 buffer-local value only if initializing for buffer iteration.
1968 (handle_invisible_prop): Support invisible properties on strings
1969 that are being bidi-reordered.
1970 (set_iterator_to_next): Support bidi reordering of C strings and
1972 (next_element_from_string): Support bidi reordering of Lisp
1974 (handle_stop_backwards): Support Lisp strings as well.
1975 (display_string): Support display of R2L glyph rows.
1976 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1977 (init_iterator): Don't initialize it->bidi_p for strings
1979 (reseat_to_string): Initialize it->bidi_p for strings here.
1980 (next_element_from_string, next_element_from_c_string)
1981 (next_element_from_buffer): Add xassert's for correspondence
1982 between IT's object being iterated and it->bidi_it.string
1984 (face_before_or_after_it_pos): Support bidi iteration.
1985 (next_element_from_c_string): Handle the case of the first string
1986 character that is not the first one in the visual order.
1987 (get_visually_first_element): New function, refactored from common
1988 parts of next_element_from_buffer, next_element_from_string, and
1989 next_element_from_c_string.
1990 (tool_bar_lines_needed, redisplay_tool_bar)
1991 (display_menu_bar): Force left-to-right direction. Add a FIXME
1992 comment for making that be controlled by a user option.
1993 (push_it, pop_it): Save and restore the state of the
1994 bidi iterator. Save and restore the bidi_p flag.
1995 (pop_it): Iterate out of display property for string iteration as
1997 (iterate_out_of_display_property): Support iteration over strings.
1998 (handle_single_display_spec): Set up it->bidi_it for iteration
1999 over a display string, and call bidi_init_it.
2000 (handle_single_display_spec, next_overlay_string)
2001 (get_overlay_strings_1, push_display_prop): Set up the bidi
2002 iterator for displaying display or overlay strings.
2003 (forward_to_next_line_start): Don't use the shortcut if
2005 (back_to_previous_visible_line_start): If handle_display_prop
2006 pushed the iterator stack, restore the internal state of the bidi
2007 iterator by calling bidi_pop_it same number of times.
2008 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2009 and we are bidi-iterating, don't decrement the iterator position;
2010 instead, set the first_elt flag in the bidi iterator, to produce
2012 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2013 (push_display_prop): xassert that we are iterating a buffer.
2014 (push_it, pop_it): Save and restore paragraph_embedding member.
2015 (handle_single_display_spec, next_overlay_string)
2016 (get_overlay_strings_1, reseat_1, reseat_to_string)
2017 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2018 correctly. Don't assume unibyte strings are not bidi-reordered.
2019 (compute_display_string_pos)
2020 (compute_display_string_end): Fix handling the case of C string.
2021 (push_it, pop_it): Save and restore from_disp_prop_p.
2022 (handle_single_display_spec, push_display_prop): Set the
2023 from_disp_prop_p flag.
2024 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2025 (pop_it): Call iterate_out_of_display_property only if we are
2026 popping after iteration over a string that came from a display
2027 property. Fix a typo in popping stretch info. Add an assertion
2028 for verifying that the iterator position is in sync with the bidi
2030 (handle_single_display_spec, get_overlay_strings_1)
2031 (push_display_prop): Fix initialization of paragraph direction for
2032 string when that of the parent object is not yet determined.
2033 (reseat_1): Call bidi_init_it to resync the bidi
2034 iterator with IT's position. (Bug#7616)
2035 (find_row_edges): If ROW->start.pos gives position
2036 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2037 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2038 Reset the from_disp_prop_p flag.
2039 (SAVE_IT, RESTORE_IT): New macros.
2040 (pos_visible_p, face_before_or_after_it_pos)
2041 (back_to_previous_visible_line_start)
2042 (move_it_in_display_line_to, move_it_in_display_line)
2043 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2044 (try_scrolling, redisplay_window, display_line): Use them when
2045 saving a temporary copy of the iterator and restoring it back.
2046 (back_to_previous_visible_line_start, reseat_1)
2047 (init_iterator): Empty the bidi cache "stack".
2048 (move_it_in_display_line_to): If iterator ended up at
2049 EOL, but we never saw any buffer positions smaller than
2050 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2051 motion in bidi-reordered lines.
2052 (move_it_in_display_line_to): Record prev_method and prev_pos
2053 immediately before the call to set_iterator_to_next. Fixes cursor
2054 motion in bidi-reordered lines with stretch glyphs and strings
2055 displayed in margins. (Bug#8133) (Bug#8867)
2056 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2058 (pos_visible_p): Support positions in bidi-reordered lines.
2059 Save and restore bidi cache.
2061 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2062 (bidi_paragraph_info): Delete unused struct.
2063 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2064 (bidi_cache_start): New variable.
2065 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2067 (bidi_cache_fetch_state, bidi_cache_search)
2068 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2069 (bidi_cache_find, bidi_peek_at_next_level)
2070 (bidi_level_of_next_char, bidi_find_other_level_edge)
2071 (bidi_move_to_visually_next): Compare cache index with
2072 bidi_cache_start rather than with zero.
2073 (bidi_fetch_char): Accept new argument STRING; all callers
2074 changed. Support iteration over a string. Support strings with
2075 display properties. Support unibyte strings. Fix the type of
2076 `len' according to what STRING_CHAR_AND_LENGTH expects.
2077 (bidi_paragraph_init, bidi_resolve_explicit_1)
2078 (bidi_resolve_explicit, bidi_resolve_weak)
2079 (bidi_level_of_next_char, bidi_move_to_visually_next):
2080 Support iteration over a string.
2081 (bidi_set_sor_type, bidi_resolve_explicit_1)
2082 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2083 can now be zero (for strings); special values 0 and -1 were
2084 changed to -1 and -2, respectively.
2085 (bidi_char_at_pos): New function.
2086 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2087 Call it instead of FETCH_MULTIBYTE_CHAR.
2088 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2089 initialized to valid values.
2090 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2092 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2093 the test for valid cached positions. Fix the logic for looking up
2094 the sentinel state in the cache. GCPRO the Lisp string we are
2096 (bidi_push_it, bidi_pop_it): New functions.
2097 (bidi_initialize): Initialize the bidi cache start stack pointer.
2098 (bidi_cache_ensure_space): New function, refactored from part of
2099 bidi_cache_iterator_state. Don't assume the required size is just
2100 one BIDI_CACHE_CHUNK away.
2101 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2102 (bidi_count_bytes, bidi_char_at_pos): New functions.
2103 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2104 always valid if bidi_cache_idx is valid.
2105 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2106 is valid if it's going to be used.
2107 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2108 (bidi_cache_fetch_state, bidi_cache_search)
2109 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2110 (bidi_cache_iterator_state, bidi_cache_find)
2111 (bidi_find_other_level_edge, bidi_cache_start_stack):
2112 All variables related to cache indices are now EMACS_INT.
2114 * dispextern.h (struct bidi_string_data): New structure.
2115 (struct bidi_it): New member `string'. Make flag members be 1-bit
2116 fields, and put them last in the struct.
2117 (compute_display_string_pos, compute_display_string_end):
2119 (bidi_push_it, bidi_pop_it): Add prototypes.
2120 (struct iterator_stack_entry): New members bidi_p,
2121 paragraph_embedding, and from_disp_prop_p.
2122 (struct it): Member bidi_p is now a bit field 1 bit wide.
2123 (bidi_shelve_cache, bidi_unshelve_cache):
2126 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2127 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2128 and vector-like objects.
2130 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2131 cache around display iteration.
2133 * window.c (Fwindow_end, window_scroll_pixel_based)
2134 (displayed_window_lines, Frecenter): Save and restore the bidi
2135 cache around display iteration.
2137 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2139 * editfns.c (Fdelete_region): Clarify the use of the named
2140 parameters (bug#6788).
2142 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2144 * indent.c (Fvertical_motion): Set and restore w->pointm when
2145 saving and restoring the window's buffer (Bug#9006).
2147 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2149 * editfns.c (Fstring_to_char): Clarify just what is returned
2150 (bug#6576). Text by Eli Zaretskii.
2152 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2154 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2156 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2158 * buffer.c (mmap_find): Fix a typo.
2160 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2162 Fix execution of x selection hooks.
2163 * xselect.c (Qx_lost_selection_functions)
2164 (Qx_sent_selection_functions): New vars.
2165 (syms_of_xselect): DEFSYM them.
2166 (x_handle_selection_request): Pass Qx_sent_selection_functions
2167 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2168 (x_handle_selection_clear,x_clear_frame_selections):
2169 Pass Qx_lost_selection_functions rather than
2170 Vx_lost_selection_functions to Frun_hook_with_args.
2172 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2174 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2175 The old code sometimes used this field without initializing it.
2177 * alloc.c (gc_sweep): Don't read past end of array.
2178 In theory, the old code could also have corrupted Emacs internals,
2179 though it'd be very unlikely.
2181 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2183 * character.c (Fcharacterp): Don't advertise optional ignored
2184 argument. (Bug#4026)
2186 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2188 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2191 * window.c (Fset_window_start): Doc fix (bug#4199).
2192 (Fset_window_hscroll): Ditto.
2194 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2196 Fix minor new problems caught by GCC 4.6.1.
2197 * term.c (init_tty): Remove unused local.
2198 * xsettings.c (store_monospaced_changed): Define this function only
2199 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2202 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2204 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2206 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2208 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2209 are the mini-buffer and the echo area (bug#3320).
2211 * term.c (init_tty): Remove support for supdup, c10 and perq
2212 terminals, which are no longer supported (bug#1482).
2214 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2216 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2218 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2220 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2221 for non-popups (Bug#3642).
2223 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2225 * alloc.c (reset_malloc_hooks): Protoize.
2226 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2227 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2228 * cm.c (losecursor): Likewise.
2229 * data.c (fmod): Likewise.
2230 * dispnew.c (swap_glyphs_in_rows): Likewise.
2231 * emacs.c (memory_warning_signal): Likewise.
2232 * floatfns.c (float_error): Likewise.
2233 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2234 (otf_open, font_otf_capability, generate_otf_features)
2235 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2237 * image.c (pbm_read_file): Likewise.
2238 * indent.c (string_display_width): Likewise.
2239 * intervals.c (check_for_interval, search_for_interval)
2240 (inc_interval_count, count_intervals, root_interval)
2241 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2242 * lread.c (defalias): Likewise.
2243 * ralloc.c (r_alloc_check): Likewise.
2244 * regex.c (set_image_of_range_1, set_image_of_range)
2245 (regex_grow_registers): Likewise.
2246 * sysdep.c (strerror): Likewise.
2247 * termcap.c (valid_filename_p, tprint, main): Likewise.
2248 * tparam.c (main): Likewise.
2249 * unexhp9k800.c (run_time_remap, save_data_space)
2250 (update_file_ptrs, read_header, write_header, calculate_checksum)
2251 (copy_file, copy_rest, display_header): Likewise.
2252 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2254 * xdisp.c (check_it): Likewise.
2255 * xfaces.c (register_color, unregister_color, unregister_colors):
2257 * xfns.c (print_fontset_result): Likewise.
2258 * xrdb.c (member, fatal, main): Likewise.
2260 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2262 Fix minor problems found by static checking (Bug#9031).
2263 * chartab.c (char_table_set_range, map_sub_char_table):
2264 Remove unused locals.
2265 (uniprop_table): Now static.
2266 * composite.c (_work_char): Remove unused static var.
2268 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2270 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2272 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2274 * gtkutil.c (qttip_cb): Remove code without function.
2276 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2278 * w32.c (pthread_sigmask): New stub.
2280 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2282 Use pthread_sigmask, not sigprocmask (Bug#9010).
2283 sigprocmask is portable only for single-threaded applications, and
2284 Emacs can be multi-threaded when it uses GTK.
2285 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2287 * callproc.c (Fcall_process):
2288 * process.c (create_process):
2289 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2290 Use pthread_sigmask, not sigprocmask.
2292 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2294 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2295 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2298 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2300 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2301 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2302 (xg_hide_tooltip): Fix comment.
2304 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2305 in registerServicesMenuSendTypes.
2306 (validRequestorForSendType): Don't check ns_return_types.
2308 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2311 2011-07-08 Jason Rumney <jasonr@gnu.org>
2313 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2314 frame struct members of non-existent frames (Bug#6284).
2316 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2318 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2319 variable firstTime not needed on OSX >= 10.6.
2320 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2321 >= 10.5. Use setKnobProportion, setDoubleValue.
2323 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2324 (MAC_OS_X_VERSION_10_5): Define if not defined.
2325 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2326 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2327 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2329 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2330 cString and lossyCString on OSX >= 10.4
2332 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2333 sizeToFit on OSX >= 10.2.
2335 * nsimage.m (allocInitFromFile): Don't use deprecated method
2336 bestRepresentationForDevice on OSX >= 10.6.
2338 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2341 * emacs.c: Declare unexec_init_emacs_zone.
2343 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2345 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2347 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2348 on svcsMenu (Bug#8842).
2350 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2352 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2354 * nsterm.m (QUTF8_STRING): Declare.
2355 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2356 (validRequestorForSendType): Return type is (id).
2357 Change indexOfObjectIdenticalTo to indexOfObject.
2358 Check if we have local selection before returning self (Bug#8842).
2359 (writeSelectionToPasteboard): Put local selection into paste board
2360 if we have a local selection (Bug#8842).
2361 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2363 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2364 (ns_get_local_selection): Declare.
2366 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2368 * keymap.c (describe_map_tree): Don't insert a double newline at
2369 the end of the buffer (bug#1169) and return whether we inserted
2372 * callint.c (Fcall_interactively): Change "reading args" to
2373 "providing args" to try to clarify what it does (bug#1010).
2375 2011-07-07 Kenichi Handa <handa@m17n.org>
2377 * composite.c (composition_compute_stop_pos): Ignore a static
2378 composition starting before CHARPOS (Bug#8915).
2380 * xdisp.c (handle_composition_prop): Likewise.
2382 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2384 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2387 2011-07-07 Kenichi Handa <handa@m17n.org>
2389 * character.h (unicode_category_t): New enum type.
2391 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2392 (Qchar_code_property_table): New variable.
2393 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2394 (UNIPROP_COMPRESSED_FORM_P): New macros.
2395 (char_table_ascii): Uncompress the compressed values.
2396 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2397 Uncompress the compressed values.
2398 (sub_char_table_ref_and_range): Likewise.
2399 (char_table_ref_and_range): Uncompress the compressed values.
2400 (sub_char_table_set): New arg is_uniprop. Callers changed.
2401 Uncompress the compressed values.
2402 (sub_char_table_set_range): Args changed. Callers changed.
2403 (char_table_set_range): Adjuted for the above change.
2404 (map_sub_char_table): Delete args default_val and parent. Add arg
2405 top. Give decoded values to a Lisp function.
2406 (map_char_table): Adjust for the above change. Give decoded
2407 values to a Lisp function. Gcpro more variables.
2408 (uniprop_table_uncompress)
2409 (uniprop_decode_value_run_length): New functions.
2410 (uniprop_decoder, uniprop_decoder_count): New variables.
2411 (uniprop_get_decoder, uniprop_encode_value_character)
2412 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2414 (uniprop_encoder, uniprop_encoder_count): New variables.
2415 (uniprop_get_encoder, uniprop_table)
2416 (Funicode_property_table_internal, Fget_unicode_property_internal)
2417 (Fput_unicode_property_internal): New functions.
2418 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2419 Sunicode_property_table_internal, Sget_unicode_property_internal,
2420 and Sput_unicode_property_internal. Defvar_lisp
2421 char-code-property-alist.
2423 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2424 Vunicode_category_table.
2426 * font.c (font_range): Adjust for the change of
2427 Vunicode_category_table.
2429 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2431 * m/iris4d.h: Remove file, move contents ...
2432 * s/irix6-5.h: ... here.
2434 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2436 Remove unportable assumption about struct layout (Bug#8884).
2437 * alloc.c (mark_buffer):
2438 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2439 (clone_per_buffer_values): Don't assume that
2440 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2441 This isn't true in general, and it's particularly not true
2442 if Emacs is configured with --with-wide-int.
2443 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2444 New macros, used in the buffer.c change.
2446 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2448 * xsettings.c: Use both GConf and GSettings if both are available.
2449 (store_config_changed_event): Add comment.
2450 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2451 (store_tool_bar_style_changed): New functions.
2452 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2453 (struct xsettings): Move font inside HAVE_XFT.
2454 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2455 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2456 Move inside HAVE_XFT.
2457 (something_changed_gsettingsCB): Rename from something_changedCB.
2458 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2460 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2461 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2462 (something_changed_gconfCB): Rename from something_changedCB.
2463 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2464 (parse_settings): Move check for font inside HAVE_XFT.
2465 (read_settings, apply_xft_settings): Add comment.
2466 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2467 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2468 call store_font_name_changed.
2469 (xft_settings_event): Add comment.
2470 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2471 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2472 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2473 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2474 (xsettings_initialize): Call init_gsettings last.
2475 (xsettings_get_system_font, xsettings_get_system_normal_font):
2478 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2480 Random fixes. E.g., (random) never returned negative values.
2481 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2482 subseconds part to the entropy, as that's a bit more random.
2483 Prefer signed to unsigned, since the signedness doesn't matter and
2484 in general we prefer signed. When given a limit, use a
2485 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2486 latter isn't right if USE_2_TAGS_FOR_INTS.
2487 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2488 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2490 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2492 * textprop.c (text_property_stickiness):
2493 Obey Vtext_property_default_nonsticky.
2494 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2495 * w32fns.c (syms_of_w32fns):
2496 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2498 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2500 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2501 This is more efficient than Ffile_directory_p and avoids a minor race.
2503 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2505 * buffer.c (Foverlay_put): Say what the return value is
2508 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2509 is a directory before asking whether to use the file name
2511 (barf_or_query_if_file_exists): Make the "File is a directory"
2512 error be more correct.
2514 * fns.c (Frequire): Remove the mention of the .gz files, since
2515 that's installation-specific, but keep the mention of
2516 `get-load-suffixes'.
2518 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2520 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2521 Report string overflow if the output is too long.
2523 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2525 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2526 (syms_of_gnutls): Remove duplicate DEFSYM for
2527 Qgnutls_bootprop_verify_hostname_error, an error for
2528 Qgnutls_bootprop_verify_error (which is no longer used).
2530 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2531 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2532 Also (re)move comments that are misplaced or no longer relevant.
2534 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2536 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2538 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2540 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2541 and background color parameters if they have been changed.
2543 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2545 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2547 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2549 * xsettings.c (SYSTEM_FONT): Define only when used.
2550 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2552 * keymap.c (access_keymap_1): Now static.
2554 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2556 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2557 leave any prefix arg for the up event (Bug#1586).
2559 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2561 * lread.c (syms_of_lread): Mention single symbols defined by
2562 `defvar' or `defconst' (bug#7154).
2564 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2565 (Frequire): Mention get-load-suffixes.
2567 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2569 * window.h (window): Remove clone_number slot.
2570 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2572 (make_parent_window, make_window, saved_window)
2573 (Fset_window_configuration, save_window_save): Don't deal with
2575 * buffer.c (Qclone_number): Remove declaration.
2576 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2578 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2580 Add multiple inheritance to keymaps.
2581 * keymap.c (Fmake_composed_keymap): New function.
2582 (Fset_keymap_parent): Simplify.
2583 (fix_submap_inheritance): Remove.
2584 (access_keymap_1): New function extracted from access_keymap to handle
2585 embedded parents and handle lists of maps.
2586 (access_keymap): Use it.
2587 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2588 (Fcopy_keymap): Handle embedded parents.
2589 (Fcommand_remapping, define_as_prefix): Simplify.
2590 (Fkey_binding): Simplify.
2591 (syms_of_keymap): Move minibuffer-local-completion-map,
2592 minibuffer-local-filename-completion-map,
2593 minibuffer-local-must-match-map, and
2594 minibuffer-local-filename-must-match-map to Elisp.
2595 (syms_of_keymap): Defsubr make-composed-keymap.
2596 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2597 (parse_menu_item): Trivial simplification.
2599 2011-07-01 Glenn Morris <rgm@gnu.org>
2601 * Makefile.in (SETTINGS_LIBS): Fix typo.
2603 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2605 * coding.c (Fencode_coding_string): Record the last coding system
2606 used, as the function doc string says (bug#8738).
2608 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2610 * xsettings.c (store_monospaced_changed): Take new font as arg and
2611 check for change against current_mono_font.
2612 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2613 (emacs_settings_constructor, emacs_settings_get_property)
2614 (emacs_settings_set_property, emacs_settings_class_init)
2615 (emacs_settings_init, gsettings_obj): Remove.
2616 (something_changedCB): New function for HAVE_GSETTINGS.
2617 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2618 with value as argument.
2619 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2620 g_settings_new (Bug#8967). Do not create gsettings_obj.
2621 Remove calls to g_settings_bind. Connect something_changedCB to
2624 * xgselect.c: Add defined (HAVE_GSETTINGS).
2625 (xgselect_initialize): Ditto.
2627 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2628 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2631 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2633 * eval.c (struct backtrace): Simplify and port the data structure.
2634 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2635 signed bit field, as this assumption is not portable and it makes
2636 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2637 "char debug_on_exit : 1" as this is not portable either; instead,
2638 use the portable "unsigned int debug_on_exit : 1". Remove unused
2639 member evalargs. Remove obsolete comments about cc bombing out.
2641 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2643 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2644 Let HAVE_GSETTINGS override HAVE_GCONF.
2645 (store_monospaced_changed): New function.
2646 (EMACS_SETTINGS): A new type derived from GObject to handle
2647 GSettings notifications.
2648 (emacs_settings_constructor, emacs_settings_get_property)
2649 (emacs_settings_set_property, emacs_settings_class_init):
2651 (gsettings_client, gsettings_obj): New variables.
2652 (GSETTINGS_SCHEMA): New define.
2653 (something_changedCB): Call store_monospaced_changed.
2654 (init_gsettings): New function.
2655 (xsettings_initialize): Call init_gsettings.
2656 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2659 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2662 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2664 * window.c (resize_root_window, grow_mini_window)
2665 (shrink_mini_window): Rename Qresize_root_window to
2666 Qwindow_resize_root_window and Qresize_root_window_vertically to
2667 Qwindow_resize_root_window_vertically.
2669 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2671 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2673 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2675 * makefile.w32-in: Redesign dependencies so they reflect more
2676 clearly which files are directly included by each source file,
2677 and not through other includes.
2679 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2681 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2682 (sort_overlays, overlay_strings): When an overlay's clone number
2683 matches the window's clone number process the overlay even if
2684 the overlay's window property doesn't match the current window.
2686 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2687 (Fwindow_hchild): Rename to Fwindow_left_child.
2688 (Fwindow_next): Rename to Fwindow_next_sibling.
2689 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2690 (resize_window_check): Rename to window_resize_check.
2691 (resize_window_apply): Rename to window_resize_apply.
2692 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2693 (Fdelete_other_windows_internal, resize_frame_windows)
2694 (Fsplit_window_internal, Fdelete_window_internal)
2695 (grow_mini_window, shrink_mini_window)
2696 (Fresize_mini_window_internal): Fix callers accordingly.
2698 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2700 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2701 (emacs_fixed_set_min_size): Remove.
2702 (emacs_fixed_new): Take frame as argument.
2704 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2705 (_EmacsFixedPrivate): Remove minwidth/height.
2706 Add struct frame *f.
2707 (emacs_fixed_init): Initialize priv->f.
2708 (get_parent_class, emacs_fixed_set_min_size): Remove.
2709 (emacs_fixed_new): Set priv->f to argument.
2710 (emacs_fixed_get_preferred_width)
2711 (emacs_fixed_get_preferred_height): Use min_width/height from
2712 frames size_hint to set minimum and natural (Bug#8919).
2713 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2714 and use min_width/height from frames size_hint to set
2715 min_width/height (Bug#8919).
2717 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2718 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2721 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2723 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2724 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2727 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2729 * process.c (wait_reading_process_output): Bypass select if
2730 waiting for a cell while ignoring keyboard input, and input is
2731 pending. Suggested by Jan Djärv (Bug#8869).
2733 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2735 Use gnulib's dup2 module instead of rolling our own.
2736 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2738 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2740 * dispnew.c (scrolling_window): Before scrolling, turn off a
2741 mouse-highlight in the window being scrolled.
2743 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2745 Move DEFSYM to lisp.h and use everywhere.
2747 * character.h (DEFSYM): Move declaration...
2748 * lisp.h (DEFSYM): ...here.
2754 * w32select.c: Don't include character.h.
2756 * alloc.c (syms_of_alloc):
2757 * buffer.c (syms_of_buffer):
2758 * bytecode.c (syms_of_bytecode):
2759 * callint.c (syms_of_callint):
2760 * casefiddle.c (syms_of_casefiddle):
2761 * casetab.c (init_casetab_once):
2762 * category.c (init_category_once, syms_of_category):
2763 * ccl.c (syms_of_ccl):
2764 * cmds.c (syms_of_cmds):
2765 * composite.c (syms_of_composite):
2766 * dbusbind.c (syms_of_dbusbind):
2767 * dired.c (syms_of_dired):
2768 * dispnew.c (syms_of_display):
2769 * doc.c (syms_of_doc):
2770 * editfns.c (syms_of_editfns):
2771 * emacs.c (syms_of_emacs):
2772 * eval.c (syms_of_eval):
2773 * fileio.c (syms_of_fileio):
2774 * fns.c (syms_of_fns):
2775 * frame.c (syms_of_frame):
2776 * fringe.c (syms_of_fringe):
2777 * insdel.c (syms_of_insdel):
2778 * keymap.c (syms_of_keymap):
2779 * lread.c (init_obarray, syms_of_lread):
2780 * macros.c (syms_of_macros):
2781 * msdos.c (syms_of_msdos):
2782 * print.c (syms_of_print):
2783 * process.c (syms_of_process):
2784 * search.c (syms_of_search):
2785 * sound.c (syms_of_sound):
2786 * syntax.c (init_syntax_once, syms_of_syntax):
2787 * terminal.c (syms_of_terminal):
2788 * textprop.c (syms_of_textprop):
2789 * undo.c (syms_of_undo):
2790 * w32.c (globals_of_w32):
2791 * window.c (syms_of_window):
2792 * xdisp.c (syms_of_xdisp):
2793 * xfaces.c (syms_of_xfaces):
2794 * xfns.c (syms_of_xfns):
2795 * xmenu.c (syms_of_xmenu):
2796 * xsettings.c (syms_of_xsettings):
2797 * xterm.c (syms_of_xterm): Use DEFSYM.
2799 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2801 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2803 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2805 Integer and buffer overflow fixes (Bug#8873).
2807 * print.c (printchar, strout): Check for string overflow.
2808 (PRINTPREPARE, printchar, strout):
2809 Don't set size unless allocation succeeds.
2811 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2812 for sizes. Check for string overflow more accurately.
2813 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2815 * macros.c: Integer and buffer overflow fixes.
2816 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2817 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2818 Use ptrdiff_t, not int, for sizes.
2819 Don't increment bufsize until after realloc succeeds.
2820 Check for size-calculation overflow.
2821 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2823 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2825 * lread.c: Integer overflow fixes.
2826 (read_integer): Radix is now EMACS_INT, not int,
2827 to improve quality of diagnostics for out-of-range radices.
2828 Calculate buffer size correctly for out-of-range radices.
2829 (read1): Check for integer overflow in radices, and in
2830 read-circle numbers.
2831 (read_escape): Avoid int overflow.
2832 (Fload, openp, read_buffer_size, read1)
2833 (substitute_object_recurse, read_vector, read_list, map_obarray):
2834 Use ptrdiff_t, not int, for sizes.
2835 (read1): Use EMACS_INT, not int, for sizes.
2836 Check for size overflow.
2838 * image.c (cache_image): Check for size arithmetic overflow.
2840 * lread.c: Integer overflow issues.
2841 (saved_doc_string_size, saved_doc_string_length)
2842 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2843 Now ptrdiff_t, not int.
2844 (read1): Don't assume doc string length fits in int. Check for
2845 out-of-range doc string lengths.
2846 (read_list): Don't assume file position fits in int.
2847 (read_escape): Check for hex character overflow.
2849 2011-06-22 Leo Liu <sdl.web@gmail.com>
2851 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2852 Move to minibuffer.el.
2854 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2856 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2857 The following patches are for when GLYPH_DEBUG && !XASSERT.
2858 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2859 * dispnew.c (flush_stdout):
2860 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2861 Mark as externally visible.
2862 * dispnew.c (check_window_matrix_pointers): Now static.
2863 * dispnew.c (window_to_frame_vpos):
2864 * xfns.c (unwind_create_frame):
2865 * xterm.c (x_check_font): Remove unused local.
2866 * scroll.c (CHECK_BOUNDS):
2867 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2868 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2869 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2870 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2871 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2873 (debug_method_add): Use va_list and vsprintf rather than relying
2874 on undefined behavior with wrong number of arguments.
2875 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2876 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2877 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2878 since we're not interested in debugging glyphs with old libraries.
2879 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2880 GCC 4.6.0's static checking.
2882 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2884 Integer overflow and signedness fixes (Bug#8873).
2885 A few related buffer overrun fixes, too.
2887 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2889 * dispextern.h (struct face.stipple):
2890 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2891 (x_bitmap_mask, x_allocate_bitmap_record)
2892 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2893 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2894 (x_create_bitmap_from_xpm_data):
2895 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2896 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2898 * xfaces.c (load_pixmap):
2899 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2900 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2901 (.bitmaps_last, struct x_output.icon_bitmap):
2902 Use ptrdiff_t, not int, for bitmap indexes.
2903 (x_allocate_bitmap_record): Check for size overflow.
2904 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2906 Use ptrdiff_t, not int, for overlay counts.
2907 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2908 * editfns.c (overlays_around, get_pos_property):
2909 * textprop.c (get_char_property_and_overlay):
2910 * xdisp.c (next_overlay_change, note_mouse_highlight):
2911 * xfaces.c (face_at_buffer_position):
2912 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2913 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2914 (Fnext_overlay_change, Fprevious_overlay_change)
2915 (mouse_face_overlay_overlaps, Foverlays_in):
2916 Use ptrdiff_t, not int, for sizes.
2917 (overlays_at, overlays_in): Check for size-calculation overflow.
2919 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2921 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2922 (x_session_initialize): Do not assume string length fits in int.
2924 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2925 This is unlikely, but can occur if DPI is outlandish.
2927 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2928 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2930 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2931 * xrdb.c (magic_file_p, search_magic_path):
2932 Omit last arg SUFFIX; it was always 0. All callers changed.
2933 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2935 * xfont.c (xfont_match): Avoid need for strlen.
2937 * xfns.c: Don't assume strlen fits in int.
2938 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2940 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2941 not unsigned long, as we prefer signed integers. All callers changed.
2942 Detect integer overflow in repeat count.
2943 (message_dolog): Don't assume print length fits in 39 bytes.
2944 (display_mode_element): Don't assume strlen fits in int.
2946 * termcap.c: Don't assume sizes fit in int and never overflow.
2947 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2948 (gobble_line): Check for size-calculation overflow.
2950 * minibuf.c (Fread_buffer):
2951 * lread.c (intern, intern_c_string):
2952 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2953 Don't assume string length fits in int.
2955 * keyboard.c (parse_tool_bar_item):
2956 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2958 * font.c: Don't assume string length fits in int.
2959 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2960 Use ptrdiff_t, not int.
2961 (font_intern_prop): Don't assume string length fits in int.
2962 Don't assume integer property fits in fixnum.
2963 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2965 * filelock.c: Fix some buffer overrun and integer overflow issues.
2966 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2967 Reformulate so as not to need the command string.
2968 Invoke gzip -cd rather than gunzip, as it's more portable.
2969 (lock_info_type, lock_file_1, lock_file):
2970 Don't assume pid_t and time_t fit in unsigned long.
2971 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2972 (current_lock_owner): Prefer signed type for sizes.
2973 Use memcpy, not strncpy, where memcpy is what is really wanted.
2974 Don't assume (via atoi) that time_t and pid_t fit in int.
2975 Check for time_t and/or pid_t out of range, e.g., via a network share.
2976 Don't alloca where an auto var works fine.
2978 * fileio.c: Fix some integer overflow issues.
2979 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2980 Don't assume string length fits in int.
2981 (directory_file_name): Don't assume string length fits in long.
2982 (make_temp_name): Don't assume pid fits in int, or that its print
2983 length is less than 20.
2985 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2987 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2989 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2991 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2992 We prefer signed integers, even for size calculations.
2994 * emacs.c: Don't assume string length fits in 'int'.
2995 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2996 (main): Don't invoke strlen when not needed.
2998 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2999 (XD_DEBUG_MESSAGE): Don't waste a byte.
3001 * callproc.c (getenv_internal_1, getenv_internal)
3003 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3005 * lread.c (invalid_syntax): Omit length argument.
3006 All uses changed. This doesn't fix a bug, but it simplifies the
3007 code away from its former Hollerith-constant appearance, and it's
3008 one less 'int' to worry about when looking at integer-overflow issues.
3009 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3011 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3012 This didn't break anything, but it didn't help either.
3013 It's confusing to put a bogus integer in a place where the actual
3014 value does not matter.
3015 (LIST_END_P): Remove unused macro and its bogus comment.
3016 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3018 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3019 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3021 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3022 We prefer signed types, and the value cannot exceed the EMACS_INT
3023 range anyway (because otherwise the length would not be representable).
3024 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3025 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3026 This avoids a GCC warning when WIDE_EMACS_INT.
3028 * indent.c (sane_tab_width): New function.
3029 (current_column, scan_for_column, Findent_to, position_indentation)
3030 (compute_motion): Use it. This is just for clarity.
3031 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3033 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3035 * lisp.h (lint_assume): New macro.
3036 * composite.c (composition_gstring_put_cache):
3037 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3039 * editfns.c, insdel.c:
3040 Omit unnecessary forward decls, to simplify future changes.
3042 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3044 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3046 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3047 Use much-faster test for byte-length change.
3048 Don't assume string byte-length fits in 'int'.
3049 Check that character arg fits in 'int'.
3050 (mapcar1): Declare byte as byte, for clarity.
3052 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3054 * fns.c (concat): Catch string overflow earlier.
3055 Do not rely on integer wraparound.
3057 * dispextern.h (struct it.overlay_strings_charpos)
3058 (struct it.selective): Now EMACS_INT, not int.
3059 * xdisp.c (forward_to_next_line_start)
3060 (back_to_previous_visible_line_start)
3061 (reseat_at_next_visible_line_start, next_element_from_buffer):
3062 Don't arbitrarily truncate the value of 'selective' to int.
3064 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3066 * composite.c: Don't truncate sizes to 'int'.
3067 (composition_gstring_p, composition_reseat_it)
3068 (composition_adjust_point): Use EMACS_INT, not int.
3069 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3070 not EMACS_UINT, for indexes.
3072 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3074 * buffer.c: Include <verify.h>.
3075 (struct sortvec.priority, struct sortstr.priority):
3076 Now EMACS_INT, not int.
3077 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3078 (struct sortstr.size, record_overlay_string)
3079 (struct sortstrlist.size, struct sortlist.used):
3080 Don't truncate size to int.
3081 (record_overlay_string): Check for size-calculation overflow.
3082 (init_buffer_once): Check at compile-time, not run-time.
3084 2011-06-22 Jim Meyering <meyering@redhat.com>
3086 Don't leak an XBM-image-sized buffer
3087 * image.c (xbm_load): Free the image buffer after using it.
3089 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3092 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3093 that Sun C diagnosed.
3094 * fns.c (secure_hash): Fix pointer signedness issue.
3095 * intervals.c (static_offset_intervals): New function.
3096 (offset_intervals): Use it.
3098 2011-06-21 Leo Liu <sdl.web@gmail.com>
3101 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3104 * fns.c (secure_hash): Rename from crypto_hash_function and change
3105 the first arg to accept symbols.
3106 (Fsecure_hash): New primitive.
3107 (syms_of_fns): New symbols.
3109 2011-06-20 Deniz Dogan <deniz@dogan.se>
3111 * process.c (Fset_process_buffer): Clarify return value in
3114 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3116 * dispnew.c (add_window_display_history): Use BVAR.
3118 * xdisp.c (debug_method_add): Use BVAR.
3119 (check_window_end, dump_glyph_matrix, dump_glyph)
3120 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3122 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3125 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3126 check till after the cache is created in init_frame_faces.
3128 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3130 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3132 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3134 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3135 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3136 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3138 Improve buffer-overflow checking (Bug#8873).
3139 * fileio.c (Finsert_file_contents):
3140 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3141 Remove the old (too-loose) buffer overflow checks.
3142 They weren't needed, since make_gap checks for buffer overflow.
3143 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3144 The old code merely checked for Emacs fixnum overflow, and relied
3145 on undefined (wraparound) behavior. The new code avoids undefined
3146 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3148 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3149 Tune. Don't use wider integers than needed. Don't use alloca.
3150 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3152 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3154 * insdel.c, lisp.h (buffer_overflow): New function.
3155 (insert_from_buffer_1, replace_range, replace_range_2):
3156 * insdel.c (make_gap_larger):
3157 * editfns.c (Finsert_char):
3158 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3160 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3162 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3164 Integer overflow and signedness fixes (Bug#8873).
3166 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3167 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3169 * fileio.c: Don't assume EMACS_INT fits in off_t.
3170 (emacs_lseek): New static function.
3171 (Finsert_file_contents, Fwrite_region): Use it.
3172 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3174 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3176 * fns.c: Don't overflow int when computing a list length.
3177 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3178 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3179 truncation on 64-bit hosts. Check for QUIT every
3180 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3181 faster and is responsive enough.
3182 (Flength): Report an error instead of overflowing an integer.
3183 (Fsafe_length): Return a float if the value is not representable
3184 as a fixnum. This shouldn't happen except in contrived situations.
3185 (Fnthcdr, Fsort): Don't assume list length fits in int.
3186 (Fcopy_sequence): Don't assume vector length fits in int.
3188 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3189 (header_size, word_size): New constants.
3190 (allocate_vectorlike): Don't check size overflow here.
3191 (allocate_vector): Check it here instead, since this is the only
3192 caller of allocate_vectorlike that could cause overflow.
3193 Check that the new vector's length is representable as a fixnum.
3195 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3196 The previous code was bogus. For example, next_almost_prime (32)
3197 returned 39, which is undesirable as it is a multiple of 3; and
3198 next_almost_prime (24) returned 25, which is a multiple of 5 so
3199 why was the code bothering to check for multiples of 7?
3201 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3203 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3205 Variadic C functions now count arguments with ptrdiff_t.
3206 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3207 Back then I didn't know that the Emacs coding style prefers signed int.
3208 Also, in the meantime I found a few more instances where arguments
3209 were being counted with int, which may truncate counts on 64-bit
3210 machines, or EMACS_INT, which may be unnecessarily wide.
3211 * lisp.h (struct Lisp_Subr.function.aMANY)
3212 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3213 Arg counts are now ptrdiff_t, not size_t.
3214 All variadic functions and their callers changed accordingly.
3215 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3216 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3217 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3218 * callint.c (Fcall_interactively): Check arg count for overflow,
3219 to avoid potential buffer overrun. Use signed char, not 'int',
3220 for 'varies' array, so that we needn't bother to check its size
3221 calculation for overflow.
3222 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3223 * eval.c (apply_lambda):
3224 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3225 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3226 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3228 * callint.c (Fcall_interactively): Don't use index var as event count.
3230 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3231 * mem-limits.h (SIZE): Remove; no longer used.
3233 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3235 Remove unnecessary casts.
3236 * xterm.c (x_term_init):
3237 * xfns.c (x_set_border_pixel):
3238 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3239 These aren't needed now that we assume ANSI C.
3241 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3242 It's more likely to cause problems (due to unsigned overflow)
3245 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3247 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3249 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3251 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3253 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3255 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3257 GLYPH_CODE_FACE returns EMACS_INT, not int.
3258 * dispextern.h (merge_faces):
3259 * xfaces.c (merge_faces):
3260 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3261 Don't assume EMACS_INT fits in int.
3263 * character.h (CHAR_VALID_P): Remove unused parameter.
3264 * fontset.c, lisp.h, xdisp.c: All uses changed.
3266 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3268 * fns.c (concat): Minor tuning based on overflow analysis.
3269 This doesn't fix any bugs. Use int to hold character, instead
3270 of constantly refetching from Emacs object. Use XFASTINT, not
3271 XINT, for value known to be a character. Don't bother comparing
3272 a single byte to 0400, as it's always less.
3274 * floatfns.c (Fexpt):
3275 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3277 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3280 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3282 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3283 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3284 incorrectly succeed when S was a string, because 4294967386 was
3285 truncated before it was used.
3287 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3288 Otherwise, an out-of-range integer could cause undefined behavior
3291 * composite.c: Use int, not EMACS_INT, for characters.
3292 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3293 EMACS_INT, for values that are known to be in character range.
3294 This doesn't fix any bugs but is the usual style inside Emacs and
3295 may generate better code on 32-bit machines.
3297 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3298 This is for reasons similar to the recent CHAR_STRING fix.
3299 * charset.c (Fencode_char): Check that character arg is actually
3300 a character. Pass an int to ENCODE_CHAR.
3301 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3302 wider than 'int', as a compile-time check to prevent future regressions
3305 * character.c (char_string): Remove unnecessary casts.
3307 Make sure a 64-bit char is never passed to CHAR_STRING.
3308 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3309 by silently ignoring the top 32 bits, allowing some values
3310 that were far too large to be valid characters.
3311 * character.h: Include <verify.h>.
3312 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3313 arguments are no wider than unsigned, as a compile-time check
3314 to prevent future regressions in this area.
3316 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3317 (Fsubst_char_in_region):
3319 * xdisp.c (decode_mode_spec_coding):
3320 Adjust to CHAR_STRING's new requirement.
3321 * editfns.c (Finsert_char, Fsubst_char_in_region):
3322 * fns.c (concat): Check that character args are actually
3323 characters. Without this test, these functions did the wrong
3324 thing with wildly out-of-range values on 64-bit hosts.
3326 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3327 These casts should not be needed on 32-bit hosts, either.
3328 * keyboard.c (read_char):
3329 * lread.c (Fload): Remove casts to unsigned.
3331 * lisp.h (UNSIGNED_CMP): New macro.
3332 This fixes comparison bugs on 64-bit hosts.
3333 (ASCII_CHAR_P): Use it.
3334 * casefiddle.c (casify_object):
3335 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3336 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3337 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3338 * dispextern.h (FACE_FROM_ID):
3339 * keyboard.c (read_char): Use UNSIGNED_CMP.
3341 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3342 not to EMACS_INT, to avoid GCC warning.
3344 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3346 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3347 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3348 isn't needed on 32-bit machines.
3350 * buffer.c (Fgenerate_new_buffer_name):
3351 Use EMACS_INT for count, not int.
3352 (advance_to_char_boundary): Return EMACS_INT, not int.
3354 * data.c (Qcompiled_function): Now static.
3356 * window.c (window_body_lines): Now static.
3358 * image.c (gif_load): Rename local to avoid shadowing.
3360 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3361 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3362 * alloc.c (make_save_value): Integer argument is now of type
3364 (mark_object): Use ptrdiff_t, not int.
3365 * lisp.h (pD): New macro.
3366 * print.c (print_object): Use it.
3368 * alloc.c: Use EMACS_INT, not int, to count objects.
3369 (total_conses, total_markers, total_symbols, total_vector_size)
3370 (total_free_conses, total_free_markers, total_free_symbols)
3371 (total_free_floats, total_floats, total_free_intervals)
3372 (total_intervals, total_strings, total_free_strings):
3373 Now EMACS_INT, not int. All uses changed.
3374 (Fgarbage_collect): Compute overall total using a double, so that
3375 integer overflow is less likely to be a problem. Check for overflow
3376 when converting back to an integer.
3377 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3378 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3379 These were 'int' variables that could overflow on 64-bit hosts;
3380 they were never used, so remove them instead of repairing them.
3381 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3382 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3383 Previously, this ceilinged at INT_MAX, but that doesn't work on
3385 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3387 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3388 (allocate_vectorlike): Check for ptrdiff_t overflow.
3389 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3390 when a (possibly-narrower) signed value would do just as well.
3391 We prefer using signed arithmetic, to avoid comparison confusion.
3393 * alloc.c: Catch some string size overflows that we were missing.
3394 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3395 for convenience in STRING_BYTES_MAX.
3396 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3397 The definition here is exact; the one in lisp.h was approximate.
3398 (allocate_string_data): Check for string overflow. This catches
3399 some instances we weren't catching before. Also, it catches
3400 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3401 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3402 and ptrdiff_t and EMACS_INT are both 64 bits.
3404 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3405 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3406 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3408 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3410 * alloc.c (Fmake_string): Check for out-of-range init.
3412 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3414 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3416 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3418 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3419 xg_get_default_scrollbar_width.
3421 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3422 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3423 (style_changed_cb): Call update_theme_scrollbar_width and call
3424 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3425 all frames (Bug#8505).
3426 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3427 Call gtk_window_set_resizable if HAVE_GTK3.
3428 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3429 and height if HAVE_GTK3 (Bug#8505).
3430 (scroll_bar_width_for_theme): New variable.
3431 (update_theme_scrollbar_width): New function.
3432 (xg_get_default_scrollbar_width): Move code to
3433 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3434 (xg_initialize): Call update_theme_scrollbar_width.
3436 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3438 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3440 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3442 * frame.c (make_frame): Call other_buffer_safely instead of
3445 * window.c (temp_output_buffer_show): Call display_buffer with
3446 second argument Vtemp_buffer_show_specifiers and reset latter
3447 immediately after the call.
3448 (Vtemp_buffer_show_specifiers): New variable.
3449 (auto_window_vscroll_p, next_screen_context_lines)
3450 (Vscroll_preserve_screen_position): Remove leading asterisks from
3453 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3455 Fix minor problems found by GCC 4.6.0 static checking.
3456 * buffer.c (Qclone_number): Remove for now, as it's unused.
3457 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3458 (record_buffer): Remove unused local.
3459 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3460 (set_frame_buffer_list): Remove; unused.
3461 * frame.h (other_visible_frames): Remove decl.
3462 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3463 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3464 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3466 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3467 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3468 Define only if HAVE_GPM.
3469 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3470 (update_hints_inhibit): Remove; never set. All uses removed.
3471 * widgetprv.h (emacsFrameClassRec): Remove decl.
3472 * window.c (delete_deletable_window): Now returns void, since it
3473 wasn't returning anything.
3474 (compare_window_configurations): Remove unused locals.
3475 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3476 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3477 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3478 the same widths as pointers. This follows up on the 2011-05-06 patch.
3479 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3480 * xterm.h: Likewise.
3481 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3483 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3485 * makefile.w32-in: Update dependencies.
3486 (LISP_H): Add lib/intprops.h.
3488 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3490 * image.c (gif_load): Add animation frame delay to the metadata.
3491 (syms_of_image): Use DEFSYM. New symbol `delay'.
3493 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3495 * window.c (delete_deletable_window): Re-add.
3496 (Fset_window_configuration): Rewrite to handle dead buffers and
3497 consequently deletable windows.
3498 (window_tree, Fwindow_tree): Remove. Supply functionality in
3500 (compare_window_configurations): Simplify code.
3502 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3504 * image.c (imagemagick_load_image): Fix type mismatch.
3505 (Fimagemagick_types): Likewise.
3507 * window.h (replace_buffer_in_windows): Declare.
3509 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3511 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3512 Qclone_number. Remove external declaration of Qdelete_window.
3513 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3515 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3516 Run Qbuffer_list_update_hook if allowed.
3517 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3518 buffer list implementation.
3519 (other_buffer_safely): New function.
3520 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3521 calls to replace_buffer_in_windows and
3522 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3524 (record_buffer): Inhibit quitting and rewrite using quittable
3525 functions. Run Qbuffer_list_update_hook if allowed.
3526 (Frecord_buffer, Funrecord_buffer): New functions.
3527 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3528 Move switch-to-buffer to window.el.
3529 (bury-buffer): Move to window.el.
3530 (Vbuffer_list_update_hook): New variable.
3532 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3535 * window.h (resize_frame_windows): Move up in code.
3536 (Fwindow_frame): Remove EXFUN.
3537 (replace_buffer_in_all_windows): Remove prototype.
3538 (replace_buffer_in_windows_safely): Add prototype.
3540 * window.c: Declare Qdelete_window static again. Move down
3541 declaration of select_count.
3542 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3543 (Fother_window): Move to window.el.
3544 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3545 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3546 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3548 (replace_buffer_in_windows): Implement by calling
3549 Qreplace_buffer_in_windows.
3550 (replace_buffer_in_all_windows): Remove with some functionality
3551 moved into replace_buffer_in_windows_safely.
3552 (replace_buffer_in_windows_safely): New function.
3553 (select_window_norecord, select_frame_norecord): Move in front
3554 of run_window_configuration_change_hook. Remove now obsolete
3556 (Fset_window_buffer): Rewrite doc-string.
3557 Call Qrecord_window_buffer.
3558 (keys_of_window): Move binding for other-window to window.el.
3560 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3562 * dispextern.h (struct image): Replace data member, whose int_val
3563 and ptr_val fields were not used by anything, with a single
3566 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3567 (gif_clear_image, gif_load, imagemagick_load_image)
3568 (gs_clear_image, gs_load): Callers changed.
3570 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3572 * buffer.h: Include <time.h>, for time_t.
3573 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3575 Fix minor problems found by static checking.
3577 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3579 Make identifiers static if they are not used in other modules.
3580 * data.c (Qcompiled_function, Qframe, Qvector):
3581 * image.c (QimageMagick, Qsvg):
3582 * minibuf.c (Qmetadata):
3583 * window.c (resize_window_check, resize_root_window): Now static.
3584 * window.h (resize_window_check, resize_root_window): Remove decls.
3586 * window.c (window_deletion_count, delete_deletable_window):
3588 (window_body_lines): Now static.
3589 (Fdelete_other_windows_internal): Mark vars as initialized.
3590 Make sure 'resize_failed' is initialized.
3591 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3592 (resize_window_apply): Remove unused local.
3593 * window.h (delete_deletable_window): Remove decl.
3595 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3596 (imagemagick_load_image): Fix pointer signedness problem by changing
3597 last arg from unsigned char * to char *. All uses changed.
3598 Also, fix a local for similar reasons.
3599 Remove unused locals. Remove locals to avoid shadowing.
3600 (fn_rsvg_handle_free): Remove; unused.
3601 (svg_load, svg_load_image): Fix pointer signedness problem.
3602 (imagemagick_load_image): Don't use garbage pointer image_wand.
3604 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3606 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3608 * image.c (gif_load): Fix omitted cast error introduced by
3611 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3613 * window.h (resize_proportionally, orig_total_lines)
3614 (orig_top_line): Remove from window structure.
3615 (set_window_height, set_window_width, change_window_heights)
3616 (Fdelete_window): Remove prototypes.
3617 (resize_frame_windows): Remove duplicate declaration.
3619 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3621 * window.h (resize_frame_windows, resize_window_check)
3622 (delete_deletable_window, resize_root_window)
3623 (resize_frame_windows): Declare prototypes.
3625 * window.c (resize_window_apply): Make definition be "static" to
3626 match the prototype.
3628 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3630 * window.c: Remove declarations of Qwindow_size_fixed,
3631 window_min_size_1, window_min_size_2, window_min_size,
3632 size_window, window_fixed_size_p, enlarge_window, delete_window.
3633 Remove static from declaration of Qdelete_window, it's
3634 temporarily needed by Fbury_buffer.
3635 (replace_window): Don't assign orig_top_line and
3637 (Fdelete_window, delete_window): Remove. Window deletion is
3638 handled by window.el.
3639 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3640 Replace Fdelete_window calls with calls to Qdelete_window.
3641 (Fdelete_other_windows): Remove. Deleting other windows is
3642 handled by window.el.
3643 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3644 handled in window.el.
3645 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3646 Window minimum sizes are handled in window.el.
3647 (shrink_windows, size_window, set_window_height)
3648 (set_window_width, change_window_heights, window_height)
3649 (window_width, CURBEG, CURSIZE, enlarge_window)
3650 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3651 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3652 handled in window.el.
3653 (make_dummy_parent): Rename to make_parent_window and give it a
3654 second argument horflag.
3655 (make_window): Don't set resize_proportionally any more.
3656 (Fsplit_window): Remove. Windows are split in window.el.
3657 (save_restore_action, save_restore_orig_size)
3658 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3659 Resize mini windows in window.el.
3660 (grow_mini_window, shrink_mini_window): Implement by calling
3661 Qresize_root_window_vertically, resize_window_check and
3662 resize_window_apply.
3663 (saved_window, Fset_window_configuration, save_window_save):
3664 Do not handle orig_top_line, orig_total_lines, and
3665 resize_proportionally.
3666 (window_min_height, window_min_width): Move to window.el.
3667 (keys_of_window): Move bindings for delete-other-windows,
3668 split-window, delete-window and enlarge-window to window.el.
3670 * buffer.c: Temporarily extern Qdelete_window.
3671 (Fbury_buffer): Temporarily call Qdelete_window instead of
3672 Fdelete_window (Fbury_buffer will move to window.el soon).
3674 * frame.c (set_menu_bar_lines_1): Remove code handling
3675 orig_top_line and orig_total_lines.
3677 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3678 set_window_height but set heights directly.
3679 (change_frame_size_1): Use resize_frame_windows.
3681 * xdisp.c (init_xdisp): Don't use set_window_height but set
3684 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3685 Use resize_frame_windows instead of change_window_heights and run
3686 run_window_configuration_change_hook.
3688 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3689 instead of change_window_heights and run
3690 run_window_configuration_change_hook.
3692 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3694 * window.c (replace_window): Rename second argument REPLACEMENT to
3695 NEW. New third argument SETFLAG. Rewrite.
3696 (delete_window, make_dummy_parent): Call replace_window with
3698 (window_list_1): Move down in code.
3699 (run_window_configuration_change_hook): Move set_buffer part
3700 before select_frame_norecord part in order to unwind correctly.
3701 Rename count1 to count.
3702 (recombine_windows, delete_deletable_window, resize_root_window)
3703 (Fdelete_other_windows_internal)
3704 (Frun_window_configuration_change_hook, make_parent_window)
3705 (resize_window_check, resize_window_apply, Fresize_window_apply)
3706 (resize_frame_windows, Fsplit_window_internal)
3707 (Fdelete_window_internal, Fresize_mini_window_internal):
3709 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3711 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3713 * window.h (window): Add some new members to window structure -
3714 normal_lines, normal_cols, new_total, new_normal, clone_number,
3715 splits, nest, prev_buffers, next_buffers.
3716 (WINDOW_TOTAL_SIZE): Move here from window.c.
3717 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3719 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3721 (make_dummy_parent): Set new members of windows structure.
3722 (make_window): Move down in code. Handle new members of window
3724 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3725 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3726 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3727 (Fset_window_prev_buffers, Fwindow_next_buffers)
3728 (Fset_window_next_buffers, Fset_window_clone_number):
3730 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3731 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3733 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3734 Argument WINDOW can be now internal window too.
3735 (Fwindow_use_time): Move up in code.
3736 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3738 (Fset_window_configuration, saved_window)
3739 (Fcurrent_window_configuration, save_window_save): Handle new
3740 members of window structure.
3741 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3742 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3743 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3744 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3745 Qget_mru_window, Qresize_root_window,
3746 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3747 Qauto_buffer_name; staticpro them.
3749 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3751 * window.c (Fwindow_total_size, Fwindow_left_column)
3752 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3753 (Fwindow_list_1): New functions.
3754 (window_box_text_cols): Replace with window_body_cols.
3755 (Fwindow_width, Fscroll_left, Fscroll_right):
3756 Use window_body_cols instead of window_box_text_cols.
3757 (delete_window, Fset_window_configuration):
3758 Call delete_all_subwindows with window as argument.
3759 (delete_all_subwindows): Take a window as argument and not a
3761 (window_loop): Remove handling of GET_LRU_WINDOW and
3763 (Fget_lru_window, Fget_largest_window): Move to window.el.
3765 * window.h: Extern window_body_cols instead of
3766 window_box_text_cols. delete_all_subwindows now takes a
3767 Lisp_Object as argument.
3769 * indent.c (compute_motion, Fcompute_motion):
3770 Use window_body_cols instead of window_box_text_cols.
3772 * frame.c (delete_frame): Call delete_all_subwindows with root
3775 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3777 * fns.c (Fputhash): Document return value.
3779 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3781 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3783 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3785 Cons<->int and similar integer overflow fixes (Bug#8794).
3787 Check for overflow when converting integer to cons and back.
3788 * charset.c (Fdefine_charset_internal, Fdecode_char):
3789 Use cons_to_unsigned to catch overflow.
3790 (Fencode_char): Use INTEGER_TO_CONS.
3791 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3792 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3793 * data.c (long_to_cons, cons_to_long): Remove.
3794 (cons_to_unsigned, cons_to_signed): New functions.
3795 These signal an error for invalid or out-of-range values.
3796 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3797 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3798 * font.c (Ffont_variation_glyphs):
3799 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3800 * lisp.h: Include <intprops.h>.
3801 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3802 (cons_to_signed, cons_to_unsigned): New decls.
3803 (long_to_cons, cons_to_long): Remove decls.
3804 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3805 (Fprimitive_undo): Use CONS_TO_INTEGER.
3806 * xfns.c (Fx_window_property): Likewise.
3807 * xselect.c: Include <limits.h>.
3808 (x_own_selection, selection_data_to_lisp_data):
3809 Use INTEGER_TO_CONS.
3810 (x_handle_selection_request, x_handle_selection_clear)
3811 (x_get_foreign_selection, Fx_disown_selection_internal)
3812 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3813 (lisp_data_to_selection_data): Use cons_to_unsigned.
3814 (x_fill_property_data): Use cons_to_signed.
3815 Report values out of range.
3817 Check for buffer and string overflow more precisely.
3818 * buffer.h (BUF_BYTES_MAX): New macro.
3819 * lisp.h (STRING_BYTES_MAX): New macro.
3820 * alloc.c (Fmake_string):
3821 * character.c (string_escape_byte8):
3822 * coding.c (coding_alloc_by_realloc):
3823 * doprnt.c (doprnt):
3824 * editfns.c (Fformat):
3826 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3827 since they may not be the same number.
3828 * editfns.c (Finsert_char):
3829 * fileio.c (Finsert_file_contents):
3830 Likewise for BUF_BYTES_MAX.
3832 * image.c: Use ptrdiff_t, not int, for sizes.
3833 (slurp_file): Switch from int to ptrdiff_t.
3835 (slurp_file): Check that file size fits in both size_t (for
3836 malloc) and ptrdiff_t (for sanity and safety).
3838 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3839 if b->modtime has its maximal value.
3841 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3843 Don't assume time_t can fit into int.
3844 * buffer.h (struct buffer.modtime): Now time_t, not int.
3845 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3846 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3848 Minor fixes for signed vs unsigned integers.
3849 * character.h (MAYBE_UNIFY_CHAR):
3850 * charset.c (maybe_unify_char):
3851 * keyboard.c (read_char, reorder_modifiers):
3852 XINT -> XFASTINT, since the integer must be nonnegative.
3853 * ftfont.c (ftfont_spec_pattern):
3854 * keymap.c (access_keymap, silly_event_symbol_error):
3855 XUINT -> XFASTINT, since the integer must be nonnegative.
3856 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3857 since it makes no difference and we prefer signed.
3858 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3859 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3862 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3864 * window.h (Fwindow_frame): Declare.
3866 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3868 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3869 (SPARE_MEMORY): Always define.
3870 (LARGE_REQUEST): Remove.
3871 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3873 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3875 * lisp.h: Move EXFUNS for Fframe_root_window,
3876 Fframe_first_window and Fset_frame_selected_window to window.h.
3878 * window.h: Move EXFUNS for Fframe_root_window,
3879 Fframe_first_window and Fset_frame_selected_window here from
3882 * frame.c (Fwindow_frame, Fframe_first_window)
3883 (Fframe_root_window, Fframe_selected_window)
3884 (Fset_frame_selected_window): Move to window.c.
3885 (Factive_minibuffer_window): Move to minibuf.c.
3886 (Fother_visible_frames_p): New function.
3888 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3890 * window.c (decode_window, decode_any_window): Move up in code.
3891 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3892 (inhibit_frame_unsplittable): Remove unused variable.
3893 (Fwindow_buffer): Move up and rewrite doc-string.
3894 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3895 (Fwindow_prev): New functions.
3896 (Fwindow_frame): Move here from frame.c. Accept any window as
3898 (Fframe_root_window, Fframe_first_window)
3899 (Fframe_selected_window): Move here from frame.c. Accept frame
3900 or arbitrary window as argument. Update doc-strings.
3901 (Fminibuffer_window): Move up in code.
3902 (Fwindow_minibuffer_p): Move up in code and simplify.
3903 (Fset_frame_selected_window): Move here from frame.c.
3905 (Fselected_window, select_window, Fselect_window): Move up in
3906 code. Minor doc-string fixes.
3908 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3910 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3911 Do not assume that spare memory exists; that assumption is valid
3912 only if SYSTEM_MALLOC.
3913 (LARGE_REQUEST): New macro, so that the issue of large requests
3914 is separated from the issue of spare memory.
3916 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3918 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3921 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3923 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3926 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3928 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3930 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3932 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3933 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3935 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3937 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3939 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3941 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3942 (x_clipboard_manager_save): Add return value.
3943 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3945 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3946 Obey Vx_select_enable_clipboard_manager. Catch errors in
3947 x_clipboard_manager_save (Bug#8779).
3948 (Vx_select_enable_clipboard_manager): New variable.
3949 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3951 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3953 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3955 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3957 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3958 in the current matrix if keep_current_p is non-zero.
3960 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3962 * bidi.c (bidi_level_of_next_char): Fix last change.
3964 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3966 Support bidi reordering of text covered by display properties.
3968 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3969 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3970 (bidi_cache_search, bidi_cache_iterator_state)
3971 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3972 (bidi_level_of_next_char, bidi_move_to_visually_next):
3973 Support character positions inside a run of characters covered by a
3975 (bidi_paragraph_init, bidi_resolve_explicit_1)
3976 (bidi_level_of_next_char): Call bidi_fetch_char and
3977 bidi_fetch_char_advance instead of FETCH_CHAR and
3979 (bidi_init_it): Initialize new members.
3980 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3982 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3983 instead of using explicit *_CHAR codes.
3984 (bidi_resolve_explicit, bidi_resolve_weak):
3985 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3986 bidirectional text is supported only in multibyte buffers.
3987 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3988 it to initialize the frame_window_p member of struct bidi_it.
3989 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3990 (bidi_resolve_explicit, bidi_resolve_weak)
3991 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3992 bidi_it->nchars is non-positive.
3993 (bidi_level_of_next_char): Don't try to lookup the cache for the
3994 next/previous character if nothing is cached there yet, or if we
3995 were just reseat()'ed to a new position.
3997 * xdisp.c (set_cursor_from_row): Set start and stop points
3998 according to the row's direction when priming the loop that looks
3999 for the glyph on which to display cursor.
4000 (single_display_spec_intangible_p): Function deleted.
4001 (display_prop_intangible_p): Reimplement to call
4002 handle_display_spec instead of single_display_spec_intangible_p.
4003 Accept 3 additional arguments needed by handle_display_spec.
4004 This fixes incorrect cursor motion across display property with complex
4005 values: lists, `(when COND...)' forms, etc.
4006 (single_display_spec_string_p): Support property values that are
4007 lists with the argument STRING its top-level element.
4008 (display_prop_string_p): Fix the condition for processing a
4009 property that is a list to be consistent with handle_display_spec.
4010 (handle_display_spec): New function, refactored from the
4011 last portion of handle_display_prop.
4012 (compute_display_string_pos): Accept additional argument
4013 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4014 value of a `display' property is a "replacing spec".
4015 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4016 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4017 the display property, but just return a value indicating whether
4018 the display property will replace the characters it covers.
4019 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4020 frame_window_p members of struct bidi_it.
4021 (compute_display_string_pos, compute_display_string_end):
4023 (push_it): Accept second argument POSITION, where pop_it should
4024 jump to continue iteration.
4025 (reseat_1): Initialize bidi_it.disp_pos.
4027 * keyboard.c (adjust_point_for_property): Adjust the call to
4028 display_prop_intangible_p to its new signature.
4030 * dispextern.h (struct bidi_it): New member frame_window_p.
4031 (bidi_init_it): Update prototypes.
4032 (display_prop_intangible_p): Update prototype.
4033 (compute_display_string_pos, compute_display_string_end):
4035 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4038 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4040 Malloc failure behavior now depends on size of allocation.
4041 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4042 * lisp.h: Change signatures accordingly.
4043 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4044 All callers changed. (Bug#8762)
4046 * gnutls.c: Use Emacs's memory allocators.
4047 Without this change, the gnutls library would invoke malloc etc.
4048 directly, which causes problems on non-SYNC_INPUT hosts, and which
4049 runs afoul of improving memory_full behavior. (Bug#8761)
4050 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4051 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4052 xfree instead of the default malloc, realloc, free.
4053 (Fgnutls_boot): No need to check for memory allocation failure,
4054 since xmalloc does that for us.
4056 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4057 * category.c (hash_get_category_set):
4058 * ccl.c (ccl_driver):
4059 * charset.c (Fdefine_charset_internal):
4060 * charset.h (struct charset.hash_index):
4061 * composite.c (get_composition_id, gstring_lookup_cache)
4062 (composition_gstring_put_cache):
4063 * composite.h (struct composition.hash_index):
4064 * dispextern.h (struct image.hash):
4065 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4066 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4067 (hashfn_equal, hashfn_user_defined, make_hash_table)
4068 (maybe_resize_hash_table, hash_lookup, hash_put)
4069 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4070 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4071 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4072 * image.c (make_image, search_image_cache, lookup_image)
4073 (xpm_put_color_table_h):
4074 * lisp.h (struct Lisp_Hash_Table):
4075 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4076 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4077 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4078 * alloc.c (allocate_vectorlike):
4079 Check for overflow in vector size calculations.
4080 * ccl.c (ccl_driver):
4081 Check for overflow when converting EMACS_INT to int.
4082 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4083 need to be updated by these changes.
4084 * fns.c (make_hash_table, maybe_resize_hash_table):
4085 Check for integer overflow with large hash tables.
4086 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4087 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4088 (SXHASH_REDUCE): New macro.
4089 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4090 Use it instead of discarding useful hash info with large hash values.
4091 (sxhash_float): New function.
4092 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4093 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4094 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4095 Rewrite to use FIXNUM_BITS, as this simplifies things.
4096 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4097 Adjust signatures to match updated version of code.
4098 (consing_since_gc): Now EMACS_INT, since a single hash table can
4099 use more than INT_MAX bytes.
4101 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4103 Make it possible to build with GCC-4.6+ -O2 -flto.
4105 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4107 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4109 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4110 Call minibuffer-inactive-mode.
4112 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4114 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4115 Update dependencies.
4117 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4119 * data.c (init_data): Remove code for UTS, this system is not
4122 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4124 Don't force ./temacs to start in terminal mode.
4126 * frame.c (make_initial_frame): Initialize faces in all cases, not
4127 only when CANNOT_DUMP is defined.
4128 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4130 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4132 * dispnew.c (add_window_display_history): Use const for the string
4133 pointer. Remove declaration, not needed.
4135 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4137 Use 'inline', not 'INLINE'.
4138 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4139 * alloc.c, fontset.c (INLINE): Remove.
4140 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4141 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4142 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4143 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4144 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4146 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4148 Make it possible to run ./temacs.
4150 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4151 syms_of_callproc does the same thing. Remove test for
4152 "initialized", do it in the caller.
4153 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4155 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4157 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4158 (read_minibuf): Use get_minibuffer.
4159 (syms_of_minibuf): Use DEFSYM.
4160 (Qmetadata): New var.
4161 * data.c (Qbuffer): Don't make it static.
4162 (syms_of_data): Use DEFSYM.
4164 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4166 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4167 (CCL_CODE_MIN): New macro.
4169 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4171 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4173 * eval.c (Qdebug): Now static.
4174 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4175 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4176 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4178 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4180 * image.c: Various fixes to ImageMagick code comments.
4181 (Fimagemagick_types): Doc fix.
4183 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4185 Minor fixes prompted by GCC 4.6.0 warnings.
4187 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4189 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4190 (x_clipboard_manager_save_all): Move extern decl to ...
4191 * xterm.h: ... here, so that it can be checked for consistency.
4193 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4195 * xselect.c (x_clipboard_manager_save_frame)
4196 (x_clipboard_manager_save_all): New functions.
4197 (Fx_clipboard_manager_save): Lisp function deleted.
4199 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4200 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4202 * xterm.h: Update prototype.
4204 2011-05-28 William Xu <william.xwl@gmail.com>
4206 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4209 2011-05-28 Jim Meyering <meyering@redhat.com>
4211 Avoid a sign-extension bug in crypto_hash_function.
4212 * fns.c (to_uchar): Define.
4213 (crypto_hash_function): Use it to convert some newly-signed
4214 variables to unsigned, to avoid sign-extension bugs. For example,
4215 without this change, (md5 "truc") would evaluate to
4216 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4217 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4218 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4220 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4222 Integer overflow fixes.
4224 * dbusbind.c: Serial number integer overflow fixes.
4225 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4226 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4227 to hold a serial number that is too large for a fixnum.
4228 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4229 Check for serial numbers out of range. Decode any serial number
4230 that was so large that it became a float. (Bug#8722)
4232 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4233 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4234 Use XFASTINT rather than XUINT when numbers are nonnegative.
4235 (xd_append_arg, Fdbus_method_return_internal):
4236 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4237 arguments, check that Lisp number is nonnegative, rather than
4238 silently wrapping negative numbers around. (Bug#8722)
4239 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4242 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4244 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4246 ccl: add integer overflow checks
4247 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4248 (IN_INT_RANGE): New macros.
4249 (ccl_driver): Use them to check for integer overflow when
4250 decoding a CCL program. Many of the new checks are whether XINT (x)
4251 fits in int; it doesn't always, on 64-bit hosts. The new version
4252 doesn't catch all possible integer overflows, but it's an
4253 improvement. (Bug#8719)
4255 * alloc.c (make_event_array): Use XINT, not XUINT.
4256 There's no need for unsigned here.
4258 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4259 This follows up to the 2011-05-06 change that substituted uintptr_t
4260 for EMACS_INT. This case wasn't caught back then.
4262 Rework Fformat to avoid integer overflow issues.
4263 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4264 now (part of C89). Include <verify.h>.
4265 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4266 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4267 (Fformat): Avoid the prepass trying to compute sizes; it was only
4268 approximate and thus did not catch overflow reliably. Instead, walk
4269 through the format just once, formatting and computing sizes as we go,
4270 checking for integer overflow at every step, and allocating a larger
4271 buffer as needed. Keep track separately whether the format is
4272 multibyte. Keep only the most-recently calculated precision, rather
4273 than them all. Record whether each argument has been converted to
4274 string. Use EMACS_INT, not int, for byte and char and arg counts.
4275 Support field widths and precisions larger than INT_MAX. Avoid
4276 sprintf's undefined behavior with conversion specifications such as %#d
4277 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4278 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4279 formatting out-of-range floating point numbers with int
4282 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4284 * data.c: Avoid integer truncation in expressions involving floats.
4285 * data.c: Include <intprops.h>.
4286 (arith_driver): When there's an integer overflow in an expression
4287 involving floating point, convert the integers to floating point
4288 so that the resulting value does not suffer from catastrophic
4289 integer truncation. For example, on a 64-bit host (* 4
4290 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4291 Do not rely on undefined behavior after integer overflow.
4293 merge count_size_as_multibyte, parse_str_to_multibyte
4294 * character.c, character.h (count_size_as_multibyte):
4295 Rename from parse_str_to_multibyte; all uses changed.
4296 Check for integer overflow.
4297 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4298 since it's now a duplicate of the other. This is more of
4299 a character than a buffer op, so better that it's in character.c.
4300 * fns.c, print.c: Adjust to above changes.
4302 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4304 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4306 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4308 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4309 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4310 (x_clipboard_manager_save): Now static.
4311 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4313 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4314 (crypto_hash_function): Now static.
4315 Fix pointer signedness problems. Avoid unnecessary initializations.
4317 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4319 * termhooks.h (Vselection_alist): Make it terminal-local.
4321 * terminal.c (create_terminal): Initialize it.
4323 * xselect.c: Support for clipboard managers.
4324 (Vselection_alist): Move to termhooks.h as terminal-local var.
4325 (LOCAL_SELECTION): New macro.
4326 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4327 (symbol_to_x_atom): Remove gratuitous arg.
4328 (x_handle_selection_request, lisp_data_to_selection_data)
4329 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4330 (x_own_selection, x_get_local_selection, x_convert_selection):
4331 New arg, specifying work frame. Use terminal-local Vselection_alist.
4332 (some_frame_on_display): Delete unused function.
4333 (Fx_own_selection_internal, Fx_get_selection_internal)
4334 (Fx_disown_selection_internal, Fx_selection_owner_p)
4335 (Fx_selection_exists_p): New optional frame arg.
4336 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4337 (x_handle_selection_clear): Don't treat other terminals with the
4338 same keyboard specially. Use the terminal-local Vselection_alist.
4339 (x_clear_frame_selections): Use Frun_hook_with_args.
4341 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4343 * xterm.h: Add support for those atoms.
4345 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4347 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4348 (converted_selections, conversion_fail_tag): New global variables.
4349 (x_selection_request_lisp_error): Free the above.
4350 (x_get_local_selection): Remove unnecessary code.
4351 (x_reply_selection_request): Args changed; handle arbitrary array
4352 of converted selections stored in converted_selections.
4353 Separate the XChangeProperty and SelectionNotify steps.
4354 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4355 (x_convert_selection): New function.
4356 (x_handle_selection_event): Simplify.
4357 (x_get_foreign_selection): Don't ignore incoming requests while
4358 waiting for an answer; this will fail when we implement
4359 SAVE_TARGETS, and seems unnecessary anyway.
4360 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4361 (Vx_sent_selection_functions): Doc fix.
4363 2011-05-26 Leo Liu <sdl.web@gmail.com>
4365 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4367 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4369 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4371 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4372 for fringe update if it has periodic bitmap.
4373 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4374 and fringe_bitmap_periodic_p.
4376 * fringe.c (get_fringe_bitmap_data): New function.
4377 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4378 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4379 row. Mark glyph row for fringe update if periodicity changed.
4381 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4382 for fringe update unless it has periodic bitmap.
4384 2011-05-25 Kenichi Handa <handa@m17n.org>
4386 * xdisp.c (get_next_display_element): Set correct it->face_id for
4387 a static composition.
4389 2011-05-24 Leo Liu <sdl.web@gmail.com>
4392 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4394 * fns.c (crypto_hash_function, Fsha1): New function.
4395 (Fmd5): Use crypto_hash_function.
4396 (syms_of_fns): Add Ssha1.
4398 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4400 * gnutls.c: Remove unused macros.
4401 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4402 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4403 Remove macros that are defined and never used.
4404 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4406 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4408 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4409 (Fx_get_selection_internal): Minor cleanup.
4410 (Fx_own_selection_internal): Rename arguments for consistency with
4413 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4415 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4417 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4419 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4421 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4423 * dispnew.c (scrolling_window): Don't exclude the case that the
4424 last enabled row in the desired matrix touches the bottom boundary.
4426 2011-05-21 Glenn Morris <rgm@gnu.org>
4428 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4429 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4430 and add some more files.
4432 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4434 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4435 report_file_error introduced by the change from 2011-05-07.
4437 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4439 * systime.h (Time): Define only if emacs is defined.
4440 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4441 where the include path doesn't have X11/X.h by default. See
4442 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4444 2011-05-20 Kenichi Handa <handa@m17n.org>
4446 * composite.c (find_automatic_composition): Fix previous change.
4448 2011-05-20 Glenn Morris <rgm@gnu.org>
4450 * lisp.mk: New file, split from Makefile.in.
4451 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4452 (shortlisp): Remove.
4453 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4455 2011-05-19 Glenn Morris <rgm@gnu.org>
4457 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4458 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4459 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4460 (lisp): Set the order to that of loadup.el.
4461 (shortlisp): Make it a copy of $lisp.
4462 (SOME_MACHINE_LISP): Remove.
4463 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4464 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4466 2011-05-18 Kenichi Handa <handa@m17n.org>
4468 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4469 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4470 (find_automatic_composition): Mostly rewrite for efficiency.
4472 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4474 * makefile.w32-in: Update dependencies.
4476 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4478 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4479 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4481 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4483 Fix some integer overflow issues, such as string length overflow.
4485 * insdel.c (count_size_as_multibyte): Check for string overflow.
4487 * character.c (lisp_string_width): Check for string overflow.
4488 Use EMACS_INT, not int, for string indexes and lengths; in
4489 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4490 the resulting string length overflows an EMACS_INT; instead,
4491 report a string overflow if no precision given. When checking for
4492 precision exhaustion, use a check that cannot possibly have
4493 integer overflow. (Bug#8675)
4494 * character.h (lisp_string_width): Adjust to new signature.
4496 * alloc.c (string_overflow): New function.
4497 (Fmake_string): Use it. This doesn't change behavior, but saves
4498 a few bytes and will simplify future changes.
4499 * character.c (string_escape_byte8): Likewise.
4500 * lisp.h (string_overflow): New decl.
4502 Fixups, following up to the user-interface timestamp change.
4503 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4504 for UI timestamps, instead of unsigned long.
4505 * msdos.c (mouse_get_pos): Likewise.
4506 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4507 * w32gui.h (Time): Define by including "systime.h" rather than by
4508 declaring it ourselves. (Bug#8664)
4510 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4511 * image.c (clear_image_cache): Likewise.
4513 * term.c (term_mouse_position): Don't assume time_t wraparound.
4515 Be more systematic about user-interface timestamps.
4516 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4517 and sometimes 'EMACS_UINT', to represent these timestamps.
4518 This change causes it to use 'Time' uniformly, as that's what X uses.
4519 This makes the code easier to follow, and makes it easier to catch
4520 integer overflow bugs such as Bug#8664.
4521 * frame.c (Fmouse_position, Fmouse_pixel_position):
4522 Use Time, not unsigned long, for user-interface timestamps.
4523 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4524 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4525 * keyboard.h (last_event_timestamp): Likewise.
4526 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4527 * menu.h (xmenu_show): Likewise.
4528 * term.c (term_mouse_position): Likewise.
4529 * termhooks.h (struct input_event.timestamp): Likewise.
4530 (struct terminal.mouse_position_hook): Likewise.
4531 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4532 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4533 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4534 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4536 * menu.h, termhooks.h: Include "systime.h", for Time.
4538 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4539 Don't assume that the difference between two unsigned long values
4540 can fit into an integer. At this point, we know button_down_time
4541 <= event->timestamp, so the difference must be nonnegative, so
4542 there's no need to cast the result if double-click-time is
4543 nonnegative, as it should be; check that it's nonnegative, just in
4544 case. This bug is triggered when events are more than 2**31 ms
4545 apart (about 25 days). (Bug#8664)
4547 * xselect.c (last_event_timestamp): Remove duplicate decl.
4548 (x_own_selection): Remove needless cast to unsigned long.
4550 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4551 that always fit in int. Use a sentinel instead of a counter, to
4552 avoid a temp and to allay GCC's concerns about possible int overflow.
4553 * frame.h (struct frame): Use int for menu_bar_items_used
4554 instead of EMACS_INT, since it always fits in int.
4556 * menu.c (grow_menu_items): Check for int overflow.
4558 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4560 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4561 Before, the code was not consistent. These values cannot exceed
4562 2**31 - 1 so there's no need to make them unsigned.
4563 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4564 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4565 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4567 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4569 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4570 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4571 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4572 presumably because the widths might not match.
4574 * window.c (size_window): Avoid needless test at loop start.
4576 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4578 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4580 2011-05-12 Drew Adams <drew.adams@oracle.com>
4582 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4584 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4586 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4587 `width' to `bar_area_x' and `bar_area_width', respectively.
4588 (x_scroll_run): Take account of fringe background extension.
4590 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4591 Rename local vars `left' and `width' to `bar_area_x' and
4592 `bar_area_width', respectively.
4593 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4594 background extension.
4596 2011-05-10 Jim Meyering <meyering@redhat.com>
4598 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4600 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4602 * image.c (Finit_image_library): Return t for built-in image types,
4603 like pbm and xbm. (Bug#8640)
4605 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4607 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4609 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4611 * w32console.c (Fset_screen_color): Doc fix.
4612 (Fget_screen_color): New function.
4613 (syms_of_ntterm): Defsubr it.
4615 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4616 unlink the temporary file if Fcall_process didn't create it in the
4618 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4619 child process will be redirected to a file specified with `:file'.
4620 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4621 cue to call_process_cleanup not to close that handle.
4623 2011-05-07 Ben Key <bkey76@gmail.com>
4625 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4626 one of two shell specific rules, either bootstrap-temacs-CMD or
4627 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4628 to the previous implementation of the bootstrap-temacs rule.
4629 The bootstrap-temacs-CMD rule is similar to the previous
4630 implementation of the bootstrap-temacs rule except that it
4631 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4634 These changes, along with some changes to nt/configure.bat,
4635 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4636 earlier fix to add support for --cflags and --ldflags options
4637 that include quotes so that it works whether make uses cmd or
4640 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4642 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4643 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4645 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4646 a string. Handle both cases.
4647 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4648 (Fdbus_register_method): Use Qinvalid_function.
4650 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4652 * makefile.w32-in: Update dependencies.
4653 (LISP_H): Add inttypes.h and stdin.h.
4654 (PROCESS_H): Add unistd.h.
4656 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4658 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4659 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4661 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4663 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4665 * term.c (vfatal): Remove stray call to va_end.
4666 It's not needed and the C Standard doesn't allow it here anyway.
4668 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4669 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4671 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4674 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4676 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4678 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4680 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4682 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4684 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4685 * charset.c (Fdefine_charset_internal): Don't initialize
4686 charset.code_space[15]. The value was garbage, on hosts with
4687 32-bit int (Bug#8600).
4689 * lread.c (read_integer): Be more consistent with string-to-number.
4690 Use string_to_number to do the actual conversion; this avoids
4691 rounding errors and fixes some other screwups. Without this fix,
4692 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4693 (digit_to_number): Move earlier, for benefit of read_integer.
4694 Return -1 if the digit is out of range for the base, -2 if it is
4695 not a digit in any supported base. (Bug#8602)
4697 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4699 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4700 to match comment at start of function. This also removes a
4701 GCC warning about overflow in a 32+64-bit port.
4703 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4705 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4706 Reported by Stefan Monnier in
4707 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4708 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4709 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4711 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4712 (EMACS_UINTPTR): Likewise, with uintptr_t.
4714 * lisp.h: Prefer 64-bit EMACS_INT if available.
4715 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4716 on 32-bit hosts that have 64-bit int, so that they can access
4718 However, temporarily disable this change unless the temporary
4719 symbol WIDE_EMACS_INT is defined.
4721 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4723 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4724 This removes an assumption that EMACS_INT and long are the same
4725 width as pointers. The assumption is true for Emacs porting targets
4726 now, but we want to make other targets possible.
4727 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4728 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4729 In the rest of the code, change types of integers that hold casted
4730 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4731 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4732 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4733 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4734 No need to cast type when ORing.
4735 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4736 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4737 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4738 assume EMACS_INT is the same width as char *.
4739 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4740 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4741 Remove no-longer-needed casts.
4742 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4743 (xg_tool_bar_help_callback, xg_make_tool_item):
4744 Use EMACS_INTPTR to hold an integer
4745 that will be cast to void *; this can avoid a GCC warning
4746 if EMACS_INT is not the same width as void *.
4747 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4748 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4749 (current_message_1, set_message_1):
4750 Use a local to convert to proper width without a cast.
4751 * xmenu.c (dialog_selection_callback): Likewise.
4753 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4754 Also, don't assume VALBITS / RAND_BITS is less than 5,
4755 and don't rely on undefined behavior when shifting a 1 left into
4757 * lisp.h (get_random): Change signature to match.
4759 * lread.c (hash_string): Use size_t, not int, for hash computation.
4760 Normally we prefer signed values; but hashing is special, because
4761 it's better to use unsigned division on hash table sizes so that
4762 the remainder is nonnegative. Also, size_t is the natural width
4763 for hashing into memory. The previous code used 'int', which doesn't
4764 retain enough info to hash well into very large tables.
4765 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4767 * dbusbind.c: Don't possibly lose pointer info when converting.
4768 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4769 Use XPNTR rather than XHASH, so that the high-order bits of
4770 the pointer aren't lost when converting through void *.
4772 * eval.c (Fautoload): Don't double-shift a pointer.
4774 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4776 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4778 * gnutls.c (DEF_GNUTLS_FN):
4779 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4781 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4783 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4786 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4788 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4789 New version that can reserve upto 2GB of heap space.
4791 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4793 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4795 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4797 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4798 `gnutls_certificate_set_x509_key_file'.
4800 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4802 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4803 Update dependencies.
4805 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4807 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4808 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4809 Remove unused parameter `fildes'.
4810 * process.c (read_process_output, send_process): Don't pass it.
4812 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4814 Fix previous change: the library cache is defined in w32.c.
4815 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4816 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4818 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4820 Implement dynamic loading of GnuTLS on Windows.
4822 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4823 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4824 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4827 * gnutls.c (Qgnutls_dll): Define.
4828 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4829 (gnutls_*): Declare function pointers.
4830 (init_gnutls_functions): New function to initialize function pointers.
4831 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4832 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4833 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4834 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4835 (emacs_gnutls_write, emacs_gnutls_read)
4836 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4837 (Fgnutls_available_p): New function.
4838 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4839 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4840 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4842 * image.c: Include w32.h.
4843 (Vimage_type_cache): Delete.
4844 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4845 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4846 (w32_delayed_load): Move to w32.c.
4848 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4850 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4851 (w32_delayed_load): Move from image.c. When loading a library, record
4852 its filename in the :loaded-from property of the library id.
4853 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4854 Initialize and staticpro them.
4855 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4857 * process.c: Include lisp.h before w32.h, not after.
4858 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4859 instead of gnutls_record_check_pending.
4861 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4863 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4865 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4866 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4869 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4871 * xterm.c (x_set_frame_alpha): Do not set property on anything
4872 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4874 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4876 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4878 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4880 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4881 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4882 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4883 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4884 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4885 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4886 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4887 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4888 (Qgnutls_bootprop_callbacks_verify): Make static.
4890 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4892 * callproc.c: Indentation fixup.
4894 * sysdep.c (wait_for_termination_1): Make static.
4895 (wait_for_termination, interruptible_wait_for_termination):
4896 Move after wait_for_termination_1.
4898 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4900 * sysdep.c (interruptible_wait_for_termination): New function
4901 which is like wait_for_termination, but allows keyboard
4904 * callproc.c (Fcall_process): Add (:file "file") as an option for
4906 (Fcall_process_region): Ditto.
4908 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4910 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4911 rather than `XVECTOR (FOO)->size'.
4913 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4914 inttypes.h, as a gnulib replacement is used if it not available in
4917 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4919 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4920 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4921 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4923 * coding.c (coding_alloc_by_realloc): Error out if destination
4924 will grow beyond MOST_POSITIVE_FIXNUM.
4925 (decode_coding_emacs_mule): Abort if there isn't enough place in
4926 charbuf for the composition carryover bytes. Reserve an extra
4927 space for up to 2 characters produced in a loop.
4928 (decode_coding_iso_2022): Abort if there isn't enough place in
4929 charbuf for the composition carryover bytes.
4931 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4933 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4934 aborting when %lld or %lll format is passed.
4935 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4936 %llo or %llx format is passed. (Bug#8545)
4938 * window.c (window_scroll_line_based): Use a marker instead of
4939 simple variables to record original value of point. (Bug#7952)
4941 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4942 produced by %s or %c overflows available buffer space. (Bug#8545)
4944 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4946 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4947 (SIZE_MAX): Move defn after all includes, as they might #define it.
4949 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4951 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4953 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4955 * keyboard.c (Qdelayed_warnings_hook): Define.
4956 (command_loop_1): Run `delayed-warnings-hook'
4957 if Vdelayed_warnings_list is non-nil.
4958 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4959 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4961 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4963 * doprnt.c (doprnt): Don't return value smaller than the buffer
4964 size if the message was truncated. (Bug#8545).
4966 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4968 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4969 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4971 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4973 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4975 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4977 * makefile.w32-in: Update dependencies.
4979 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4981 Improve `doprnt' and its usage. (Bug#8545)
4982 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4983 `format_end'. Remove support for %l as a conversion specifier.
4984 Don't use xrealloc. Improve diagnostics when the %l size modifier
4985 is used. Update the commentary.
4987 * eval.c (verror): Simplify calculation of size_t.
4989 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4992 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4994 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4997 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4999 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5000 This makes this file independent of the recent pseudovector change.
5002 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5004 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5006 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5007 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5008 Remove unused local.
5009 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5011 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5012 GCC 4.6.0 optimizes based on type-based alias analysis.
5013 For example, if b is of type struct buffer * and v of type struct
5014 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5015 != &v->size, and therefore "v->size = 1; b->size = 2; return
5016 v->size;" must therefore return 1. This assumption is incorrect
5017 for Emacs, since it type-puns struct Lisp_Vector * with many other
5018 types. To fix this problem, this patch adds a new type struct
5019 vectorlike_header that documents the constraints on layout of vectors
5020 and pseudovectors, and helps optimizing compilers not get fooled
5021 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5022 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5023 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5025 (XSETPVECTYPE): Rewrite in terms of new macro.
5026 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5027 This is a bit clearer, and further avoids the possibility of
5028 undesirable aliasing.
5029 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5030 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5031 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5032 since Lisp_Subr is a special case (no "next" field).
5033 (ASIZE): Now uses header.size rather than size.
5034 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5035 to avoid the hassle of writing XVECTOR (foo)->header.size.
5036 (struct vectorlike_header): New type.
5037 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5038 object, to help avoid aliasing.
5039 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5040 (SUBRP): Likewise, since Lisp_Subr is a special case.
5041 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5042 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5043 (struct Lisp_Hash_Table): Combine first two members into a single
5044 struct vectorlike_header member. All uses of "size" and "next" members
5045 changed to be "header.size" and "header.next".
5046 * buffer.h (struct buffer): Likewise.
5047 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5048 * frame.h (struct frame): Likewise.
5049 * process.h (struct Lisp_Process): Likewise.
5050 * termhooks.h (struct terminal): Likewise.
5051 * window.c (struct save_window_data, struct saved_window): Likewise.
5052 * window.h (struct window): Likewise.
5053 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5054 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5055 * buffer.c (init_buffer_once): Likewise.
5056 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5058 * process.c (Fformat_network_address): Use local var for size,
5061 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5063 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5064 * data.c (atof): Remove decl; no longer used or needed.
5065 (digit_to_number): Move to lread.c.
5066 (Fstring_to_number): Use new string_to_number function, to be
5067 consistent with how the Lisp reader treats infinities and NaNs.
5068 Do not assume that floating-point numbers represent EMACS_INT
5069 without losing information; this is not true on most 64-bit hosts.
5070 Avoid double-rounding errors, by insisting on integers when
5071 parsing non-base-10 numbers, as the documentation specifies.
5072 * lisp.h (string_to_number): New decl, replacing ...
5073 (isfloat_string): Remove.
5074 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5075 (read1): Do not accept +. and -. as integers; this
5076 appears to have been a coding error. Similarly, do not accept
5077 strings like +-1e0 as floating point numbers. Do not report
5078 overflow for integer overflows unless the base is not 10 which
5079 means we have no simple and reliable way to continue.
5080 Break out the floating-point parsing into a new
5081 function string_to_number, so that Fstring_to_number parses
5082 floating point numbers consistently with the Lisp reader.
5083 (digit_to_number): Move here from data.c. Make it static inline.
5084 (E_CHAR, EXP_INT): Remove, replacing with ...
5085 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5086 (string_to_number): New function, replacing isfloat_string.
5087 This function checks for valid syntax and produces the resulting
5088 Lisp float number too. Rework it so that string-to-number
5089 no longer mishandles examples like "1.0e+". Use strtoumax,
5090 so that overflow for non-base-10 numbers is reported only when
5091 there's no portable and simple way to convert to floating point.
5093 * textprop.c (set_text_properties_1): Rewrite for clarity,
5094 and to avoid GCC warning about integer overflow.
5096 * intervals.h (struct interval): Use EMACS_INT for members
5097 where EMACS_UINT might cause problems. See
5098 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5099 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5100 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5102 (offset_intervals): Tell GCC not to worry about length overflow
5103 when negating a negative length.
5105 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5106 (overrun_check_free): Likewise.
5108 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5109 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5112 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5113 (gnutls_make_error): Rename local to avoid shadowing.
5114 (gnutls_emacs_global_deinit): ifdef out; not used.
5115 (Fgnutls_boot): Use const for pointer to readonly storage.
5116 Comment out unused local. Fix pointer signedness problems.
5118 * lread.c (openp): Don't stuff size_t into an 'int'.
5119 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5120 about possible signed overflow.
5122 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5123 (GDK_KEY_g): Don't define if already defined.
5124 (xg_prepare_tooltip): Avoid pointer signedness problem.
5125 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5127 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5128 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5130 * xfns.c (Fx_window_property): Simplify a bit,
5131 to make a bit faster and to avoid GCC 4.6.0 warning.
5132 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5134 * fns.c (internal_equal): Don't assume size_t fits in int.
5136 * alloc.c (compact_small_strings): Tighten assertion a little.
5138 Replace pEd with more-general pI, and fix some printf arg casts.
5139 * lisp.h (pI): New macro, generalizing old pEd macro to other
5140 conversion specifiers. For example, use "...%"pI"d..." rather
5141 than "...%"pEd"...".
5142 (pEd): Remove. All uses replaced with similar uses of pI.
5143 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5144 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5145 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5146 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5147 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5148 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5149 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5151 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5152 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5153 * print.c (safe_debug_print, print_object): Likewise.
5154 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5156 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5157 avoiding the 0 flag, which is not portable.
5158 * process.c (Fmake_network_process): Use pI to avoid cast.
5159 * region-cache.c (pp_cache): Likewise.
5160 * xdisp.c (decode_mode_spec): Likewise.
5161 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5162 behavior on 64-bit hosts with printf arg.
5163 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5164 (x_stop_queuing_selection_requests): Likewise.
5165 (x_get_window_property): Don't truncate byte count to an 'int'
5168 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5169 here, since it parses constructs like leading '-' and spaces,
5170 which are not wanted; and it overflows with large numbers.
5171 Instead, simply match F[0-9]+, which is what is wanted anyway.
5173 * alloc.c: Remove unportable assumptions about struct layout.
5174 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5175 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5176 (allocate_vectorlike, make_pure_vector): Use the new macros,
5177 plus offsetof, to remove unportable assumptions about struct layout.
5178 These assumptions hold on all porting targets that I know of, but
5179 they are not guaranteed, they're easy to remove, and removing them
5180 makes further changes easier.
5182 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5183 This doesn't fix a bug but makes the code clearer.
5184 (string_overrun_cookie): Now const. Use initializers that
5185 don't formally overflow signed char, to avoid warnings.
5186 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5187 can cause Emacs to crash when string overrun checking is enabled.
5188 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5189 multiple of sizeof (EMACS_INT); it need not be, if
5190 alignof(EMACS_INT) < sizeof (EMACS_INT).
5191 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5193 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5195 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5197 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5199 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5200 supposed to be handshaking. (Bug#8556)
5201 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5203 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5205 * lisp.h (Qdebug): List symbol.
5206 * eval.c (Qdebug): Restore global linkage.
5207 * keyboard.c (debug-on-event): New variable.
5208 (handle_user_signal): Break into debugger when debug-on-event
5209 matches the current signal symbol.
5211 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5213 * alloc.c (check_sblock, check_string_bytes)
5214 (check_string_free_list): Convert to standard C.
5216 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5218 * w32.c (emacs_gnutls_push): Fix typo.
5220 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5222 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5223 "cast to pointer from integer of different size".
5225 Improve doprnt and its use in verror. (Bug#8545)
5226 * doprnt.c (doprnt): Document the set of format control sequences
5227 supported by the function. Use SAFE_ALLOCA instead of always
5230 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5231 is one byte too soon. Don't use xrealloc; instead xfree and
5234 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5236 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5239 * gnutls.c: Renamed global_initialized to
5240 gnutls_global_initialized. Added internals for the
5241 :verify-hostname-error, :verify-error, and :verify-flags
5242 parameters of `gnutls-boot' and documented those parameters in the
5243 docstring. Start callback support.
5244 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5245 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5246 on error. Return error code.
5247 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5248 (emacs_gnutls_read): Likewise.
5249 (Fgnutls_boot): Return handshake error code.
5250 (emacs_gnutls_handle_error): New function.
5251 (wsaerror_to_errno): Likewise.
5253 * w32.h (emacs_gnutls_pull): Add prototype.
5254 (emacs_gnutls_push): Likewise.
5256 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5257 (emacs_gnutls_push): Likewise.
5259 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5261 * process.c (wait_reading_process_output): Check if GnuTLS
5262 buffered some data internally if no FDs are set for TLS
5265 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5266 (LIBS): Link to USER_LIBS.
5267 ($(BLD)/gnutls.$(0)): New target.
5269 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5271 * xdisp.c (handle_single_display_spec): Rename the
5272 display_replaced_before_p argument into display_replaced_p, to
5273 make it consistent with the commentary. Fix typos in the
5276 * textprop.c (syms_of_textprop): Remove dead code.
5277 (copy_text_properties): Delete obsolete commentary about an
5278 interface that was deleted long ago. Fix typos in the description
5281 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5282 to changes in oldXMenu/XMenu.h from 2011-04-16.
5283 <menu_help_message, prev_menu_help_message>: Constify.
5284 (IT_menu_make_room): menu->help_text is now `const char **';
5287 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5288 to changes in oldXMenu/XMenu.h from 2011-04-16.
5289 (struct XMenu): Declare `help_text' `const char **'.
5291 * xfaces.c <Qunspecified>: Make extern again.
5293 * syntax.c: Include sys/types.h before including regex.h, as
5296 * doc.c (get_doc_string): Improve the format passed to `error'.
5298 * doprnt.c (doprnt): Improve commentary.
5300 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5302 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5305 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5306 changes in globals.h immediately force recompilation.
5307 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5308 $(CURDIR)/s/ms-w32.h.
5309 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5311 * character.c (Fchar_direction): Function deleted.
5312 (syms_of_character): Don't defsubr it.
5313 <char-direction-table>: Deleted.
5315 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5317 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5318 * doprnt.c: Include limits.h.
5319 (SIZE_MAX): New macro.
5320 (doprnt): Return a size_t value. 2nd arg is now size_t.
5321 Many local variables are now size_t instead of int or unsigned.
5322 Improve overflow protection. Support `l' modifier for integer
5323 conversions. Support %l conversion. Don't assume an EMACS_INT
5324 argument for integer conversions and for %c.
5326 * lisp.h (doprnt): Restore prototype.
5328 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5331 * Makefile.in (base_obj): Add back doprnt.o.
5333 * deps.mk (doprnt.o): Add back prerequisites.
5334 (callint.o): Depend on character.h.
5336 * eval.c (internal_lisp_condition_case): Include the handler
5337 representation in the error message.
5338 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5339 when breaking from the loop.
5341 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5343 * callint.c (Fcall_interactively): When displaying error message
5344 about invalid control letter, pass the character's codepoint, not
5345 a pointer to its multibyte form. Improve display of the character
5346 in octal and display also its hex code.
5348 * character.c (char_string): Use %x to display the (unsigned)
5349 codepoint of an invalid character, to avoid displaying a bogus
5352 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5353 `error', not SYMBOL_NAME itself.
5355 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5356 character arguments to `error'.
5358 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5359 to `error' in error message about FINAL_CHAR argument. Make sure
5360 FINAL_CHAR is a character, and use %c when it is passed as
5361 argument to `error'.
5363 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5365 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5367 * w32.c: Include <time.h>.
5368 (sys_localtime): New function.
5370 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5372 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5374 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5376 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5378 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5381 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5383 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5384 gl_state.e_property when gl_state.object is Qt.
5386 * insdel.c (make_gap_larger): Remove limitation of buffer size
5389 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5391 * xdisp.c (lookup_glyphless_char_display)
5392 (produce_glyphless_glyph): Handle cons cell entry in
5393 glyphless-char-display.
5394 (Vglyphless_char_display): Document it.
5396 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5397 glyphless-char-display.
5399 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5401 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5403 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5405 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5406 definition for no-X builds.
5408 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5410 Static checks with GCC 4.6.0 and non-default toolkits.
5412 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5414 * process.c (keyboard_bit_set): Define only if SIGIO.
5415 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5416 (send_process): Repair possible setjmp clobbering.
5418 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5420 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5422 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5424 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5425 Define only if needed.
5427 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5428 by pacifying GCC about it. Maybe it's time to retire it?
5429 * xfaces.c (USG, __TIMEVAL__): Likewise.
5431 * dispextern.h (struct redisplay_interface): Rename param
5433 * termhooks.h (struct terminal): Likewise.
5434 * xterm.c (xembed_send_message): Likewise.
5436 * insdel.c (make_gap_smaller): Define only if
5437 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5439 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5442 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5443 so that we aren't warned about unused symbols.
5445 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5447 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5449 * xfns.c (x_real_positions): Mark locals as initialized.
5451 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5453 * xterm.c: Fix problems found by static analysis with other toolkits.
5454 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5455 (x_dispatch_event): Declare static if USE_GTK, and
5456 define if USE_GTK || USE_X_TOOLKIT.
5457 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5458 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5459 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5460 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5462 * xmenu.c (menu_help_callback): Pointer type fixes.
5463 Use const pointers when pointing at readonly data. Avoid pointer
5465 (FALSE): Remove unused macro.
5466 (update_frame_menubar): Remove unused decl.
5468 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5470 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5471 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5472 (single_menu_item): Rename local to avoid shadowing.
5474 * keyboard.c (make_lispy_event): Remove unused local var.
5476 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5477 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5479 * bitmaps: Change bitmaps from unsigned char back to the X11
5480 compatible char. Avoid the old compiler warnings about
5481 out-of-range initializers by using, for example, '\xab' rather
5484 * xgselect.c (xgselect_initialize): Check vs interface
5485 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5487 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5489 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5490 to read-only memory.
5492 * fns.c (vector): Remove; this old hack is no longer needed.
5494 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5496 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5498 * xrdb.c (x_load_resources): Omit unused local.
5500 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5501 (x_window): Rename locals to avoid shadowing.
5502 (USG): Use the kludged USG macro, to pacify gcc.
5504 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5505 (x_term_init): Remove local to avoid shadowing.
5507 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5509 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5510 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5512 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5514 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5516 Fix regex.c, syntax.c and friends for buffers > 2GB.
5517 * syntax.h (struct gl_state_s): Declare character position members
5520 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5522 * textprop.c (verify_interval_modification, interval_of):
5523 Declare arguments EMACS_INT.
5525 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5528 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5530 * indent.c (Fvertical_motion): Local variable it_start is now
5533 * regex.c (re_match, re_match_2, re_match_2_internal)
5534 (bcmp_translate, regcomp, regexec, print_double_string)
5535 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5536 (re_compile_pattern, re_exec): Declare arguments and local
5537 variables `size_t' and `ssize_t' and return values `regoff_t', as
5539 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5540 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5541 <compile_stack_type>: `size' and `avail' are now `size_t'.
5543 * regex.h <regoff_t>: Use ssize_t, not int.
5544 (re_search, re_search_2, re_match, re_match_2): Arguments that
5545 specify buffer/string position and length are now ssize_t and
5546 size_t. Return type is regoff_t.
5548 2011-04-16 Ben Key <bkey76@gmail.com>
5550 * nsfont.m: Fixed bugs in ns_get_family and
5551 ns_descriptor_to_entity that were caused by using free to
5552 deallocate memory blocks that were allocated by xmalloc (via
5553 xstrdup). This caused Emacs to crash when compiled with
5554 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5555 --enable-checking=xmallocoverrun). xfree is now used to
5556 deallocate these memory blocks.
5558 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5560 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5562 emacs_write: Accept and return EMACS_INT for sizes.
5563 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5565 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5566 Accept and return EMACS_INT.
5567 (emacs_gnutls_write): Return the number of bytes written on
5569 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5570 (emacs_read, emacs_write): Remove check for negative size, as the
5571 Emacs source code has been audited now.
5572 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5573 (emacs_read, emacs_write): Use it.
5574 * process.c (send_process): Adjust to the new signatures of
5575 emacs_write and emacs_gnutls_write. Do not attempt to store
5576 a byte offset into an 'int'; it might overflow.
5577 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5579 * sound.c: Don't assume sizes fit in 'int'.
5580 (struct sound_device.period_size, alsa_period_size):
5581 Return EMACS_INT, not int.
5582 (struct sound_device.write, vox_write, alsa_write):
5583 Accept EMACS_INT, not int.
5584 (wav_play, au_play): Use EMACS_INT to store sizes and to
5585 record read return values.
5587 2011-04-15 Ben Key <bkey76@gmail.com>
5589 * keyboard.c (Qundefined): Don't declare static since it is used
5591 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5592 static since they are used in nsfont.m.
5594 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5596 * process.c (Qprocessp): Don't declare static.
5597 * lisp.h (Qprocessp): Declare again.
5599 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5601 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5603 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5605 Improve C-level modularity by making more things 'static'.
5607 Don't publish debugger-only interfaces to other modules.
5608 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5609 (verify_bytepos, count_markers): Move decls to the only modules
5611 * region-cache.h (pp_cache): Likewise.
5612 * window.h (check_all_windows): Likewise.
5613 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5615 * sysdep.c (croak): Now static, if
5616 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5617 * syssignal.h (croak): Declare only if not static.
5619 * alloc.c (refill_memory_reserve): Now static if
5620 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5621 * lisp.h (refill_memory_reserve): Declare only if not static.
5623 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5624 Define only if USE_LUCID.
5626 * xrdb.c (x_customization_string, x_rm_string): Now static.
5628 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5629 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5631 * xdisp.c (draw_row_with_mouse_face): Now static.
5632 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5634 * window.h (check_all_windows): Mark externally visible.
5636 * window.c (window_deletion_count): Now static.
5638 * undo.c: Make symbols static if they're not exported.
5639 (last_undo_buffer, last_boundary_position, pending_boundary):
5642 * textprop.c (interval_insert_behind_hooks): Now static.
5643 (interval_insert_in_front_hooks): Likewise.
5645 * term.c: Make symbols static if they're not exported.
5646 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5647 (max_frame_lines, tty_set_terminal_modes):
5648 (tty_reset_terminal_modes, tty_turn_off_highlight):
5649 (get_tty_terminal): Now static.
5650 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5651 * termhooks.h (term_mouse_moveto): Do not declare if
5653 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5654 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5656 * sysdep.c: Make symbols static if they're not exported.
5657 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5659 (sigprocmask_set, full_mask): Remove; unused.
5660 (wait_debugging): Mark as visible.
5661 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5662 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5664 * syntax.c (syntax_temp): Define only if !__GNUC__.
5666 * sound.c (current_sound_device, current_sound): Now static.
5668 * search.c (searchbufs, searchbuf_head): Now static.
5670 * scroll.c (scroll_cost): Remove; unused.
5671 * dispextern.h (scroll_cost): Remove decl.
5673 * region-cache.h (pp_cache): Mark as externally visible.
5675 * process.c: Make symbols static if they're not exported.
5676 (process_tick, update_tick, create_process, chan_process):
5677 (Vprocess_alist, proc_buffered_char, datagram_access):
5678 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5679 (deactivate_process): Mark defn as static, as well as decl.
5680 * lisp.h (create_process): Remove decl.
5681 * process.h (chan_process, Vprocess_alist): Remove decls.
5683 * print.c: Make symbols static if they're not exported.
5684 (print_depth, new_backquote_output, being_printed, print_buffer):
5685 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5686 (print_interval, print_number_index, initial_stderr_stream):
5688 * lisp.h (Fprinc): Remove decl.
5689 (debug_output_compilation_hack): Mark as externally visible.
5691 * sysdep.c (croak): Move decl from here to syssignal.h.
5692 * syssignal.h (croak): Put it here, so the API can be checked when
5693 'croak' is called from dissociate_if_controlling_tty.
5695 * minibuf.c: Make symbols static if they're not exported.
5696 (minibuf_save_list, choose_minibuf_frame): Now static.
5697 * lisp.h (choose_minibuf_frame): Remove decl.
5699 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5701 * lread.c: Make symbols static if they're not exported.
5702 (read_objects, initial_obarray, oblookup_last_bucket_number):
5704 (make_symbol): Remove; unused.
5705 * lisp.h (initial_obarray, make_symbol): Remove decls.
5707 * keyboard.c: Make symbols static if they're not exported.
5708 (single_kboard, recent_keys_index, total_keys, recent_keys):
5709 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5710 (this_single_command_key_start, echoing, last_auto_save):
5711 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5712 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5713 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5714 (Vlispy_mouse_stem, double_click_count):
5716 (force_auto_save_soon): Define only if SIGDANGER.
5717 (ignore_mouse_drag_p): Now static if
5718 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5719 (print_help): Remove; unused.
5720 (stop_character, last_timer_event): Mark as externally visible.
5721 * keyboard.h (ignore_mouse_drag_p): Declare only if
5722 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5723 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5724 * lisp.h (echoing): Remove decl.
5725 (force_auto_save_soon): Declare only if SIGDANGER.
5726 * xdisp.c (redisplay_window): Simplify code, to make it more
5727 obvious that ignore_mouse_drag_p is not accessed if !defined
5728 USE_GTK && !defined HAVE_NS.
5730 * intervals.c: Make symbols static if they're not exported.
5731 (merge_properties_sticky, merge_interval_right, delete_interval):
5733 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5735 * insdel.c: Make symbols static if they're not exported.
5736 However, leave prepare_to_modify_buffer alone. It's never
5737 called from outside this function, but that appears to be a bug.
5738 (combine_after_change_list, combine_after_change_buffer):
5739 (adjust_after_replace, signal_before_change): Now static.
5740 (adjust_after_replace_noundo): Remove; unused.
5741 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5742 (signal_before_change): Remove decls.
5744 * indent.c (val_compute_motion, val_vmotion): Now static.
5746 * image.c: Make symbols static if they're not exported.
5747 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5749 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5750 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5752 * fringe.c (standard_bitmaps): Now static.
5753 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5755 * frame.c: Make symbols static if they're not exported.
5756 (x_report_frame_params, make_terminal_frame): Now static.
5757 (get_frame_param): Now static, unless HAVE_NS.
5758 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5759 (x_get_resource_string): Remove; not used.
5760 * frame.h (make_terminal_frame, x_report_frame_params):
5761 (x_get_resource_string); Remove decls.
5762 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5763 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5765 * font.c, fontset.c: Make symbols static if they're not exported.
5766 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5767 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5768 * font.c (font_close_object): Now static.
5769 * font.h (font_close_object): Remove.
5770 * fontset.c (FONTSET_OBJLIST): Remove.
5771 (free_realized_fontset) #if-0 the body, which does nothing.
5772 (face_suitable_for_char_p): #if-0, as it's never called.
5773 * fontset.h (face_suitable_for_char_p): Remove decl.
5774 * xfaces.c (face_at_string_position):
5775 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5776 since 0 is always ASCII.
5778 * fns.c (weak_hash_tables): Now static.
5780 * fileio.c: Make symbols static if they're not exported.
5781 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5782 (Vwrite_region_annotation_buffers): Now static.
5784 * eval.c: Make symbols static if they're not exported.
5785 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5786 * lisp.h (backtrace_list): Remove decl.
5788 * emacs.c: Make symbols static if they're not exported.
5789 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5790 (fatal_error_code, fatal_error_signal_hook, standard_args):
5792 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5793 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5794 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5795 * lisp.h (fatal_error_signal_hook): Remove decl.
5796 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5798 * editfns.c: Move a (normally-unused) function to its only use.
5799 * editfns.c, lisp.h (get_operating_system_release): Remove.
5800 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5801 worth the hassle of breaking this out.
5803 * xterm.c: Make symbols static if they're not exported.
5804 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5805 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5806 (x_destroy_window, x_delete_display):
5808 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5809 (x_mouse_leave): Remove; unused.
5810 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5811 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5812 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5814 (x_mouse_leave): Declare only if WINDOWSNT.
5815 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5816 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5819 * ftxfont.c: Make symbols static if they're not exported.
5820 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5822 * font.h (ftxfont_driver): Likewise.
5824 * xfns.c: Make symbols static if they're not exported.
5825 (x_last_font_name, x_display_info_for_name):
5826 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5827 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5828 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5829 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5830 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5831 (last_show_tip_args): Now static.
5832 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5833 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5834 (x_screen_planes): Remove; unused.
5835 * dispextern.h (x_screen_planes): Remove decl.
5837 * dispnew.c: Make symbols static if they're not exported.
5838 * dispextern.h (redraw_garbaged_frames, scrolling):
5839 (increment_row_positions): Remove.
5840 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5841 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5843 (redraw_garbaged_frames): Remove; unused.
5845 * xfaces.c: Make symbols static if they're not exported.
5846 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5848 * xterm.h (defined_color): Remove decls.
5849 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5850 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5851 (menu_face_changed_default, defined_color, free_realized_face):
5852 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5853 (ascii_face_of_lisp_face): Remove; unused.
5855 * xdisp.c: Make symbols static if they're not exported.
5856 * dispextern.h (scratch_glyph_row, window_box_edges):
5857 (glyph_to_pixel_coords, set_cursor_from_row):
5858 (get_next_display_element, set_iterator_to_next):
5859 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5860 (show_mouse_face): Remove decls
5861 * frame.h (message_buf_print): Likewise.
5862 * lisp.h (pop_message, set_message, check_point_in_composition):
5864 * xterm.h (set_vertical_scroll_bar): Likewise.
5865 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5866 (message_buf_print, scratch_glyph_row, displayed_buffer):
5867 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5868 (get_next_display_element, show_mouse_face, window_box_edges):
5869 (frame_to_window_pixel_xy, check_point_in_composition):
5870 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5871 (glyph_to_pixel_coords): Remove; unused.
5873 * dired.c (file_name_completion): Now static.
5875 * dbusbind.c (xd_in_read_queued_messages): Now static.
5877 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5878 * data.c (circular_list_error): Remove.
5880 * commands.h (last_point_position, last_point_position_buffer):
5881 (last_point_position_window): Remove decls.
5882 * keyboard.c: Make these variables static.
5884 * coding.h (coding, code_convert_region, encode_coding_gap):
5886 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5887 (iso_code_class, detect_coding, code_convert_region): Now static.
5888 (encode_coding_gap): Remove; unused.
5890 * chartab.c (chartab_chars, chartab_bits): Now static.
5892 * charset.h (charset_iso_8859_1): Remove decl.
5893 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5896 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5897 * ccl.c (Vccl_program_table): Now static.
5898 (check_ccl_update): Remove; unused.
5900 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5901 * category.h: ... from here.
5902 * category.c (check_category_table, set_category_set): Now static.
5904 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5905 * lisp.h: Remove these decls.
5907 * buffer.c (buffer_count): Remove unused var.
5909 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5910 so that it's not optimized away.
5911 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5912 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5913 exported only to the debugger.
5915 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5916 * atimer.h (run_all_atimers): Remove; not exported.
5918 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5919 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5920 was inaccessible from Lisp.
5921 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5922 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5924 alloc.c: Import and export fewer symbols, and remove unused items.
5925 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5927 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5928 it's not optimized away by whole-program optimization.
5929 (message_enable_multibyte, free_misc): Remove.
5930 (catchlist, handlerlist, mark_backtrace):
5931 Declare only if BYTE_MARK_STACK.
5932 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5933 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5934 (message_enable_multibyte): Remove decl.
5935 (free_misc, interval_free_list, float_block, float_block_index):
5936 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5937 (cons_free_list, last_marked_index):
5939 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5940 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5941 (mark_backtrace): Define only if BYTE_MARK_STACK.
5942 * xdisp.c (message_enable_multibyte): Now static.
5944 Declare Lisp_Object Q* variables to be 'static' if not exported.
5945 This makes it easier for human readers (and static analyzers)
5946 to see whether these variables are used from other modules.
5947 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5948 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5949 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5950 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5951 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5952 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5953 * xmenu.c, xselect.c:
5954 Declare Q* vars static if they are not used in other modules.
5955 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5956 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5957 Remove decls of unexported vars.
5958 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5960 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5962 Make Emacs functions such as Fatom 'static' by default.
5963 This makes it easier for human readers (and static analyzers)
5964 to see whether these functions can be called from other modules.
5965 DEFUN now defines a static function. To make the function external
5966 so that it can be used in other C modules, use the new macro DEFUE.
5967 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5968 (Finit_image_library):
5969 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5970 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5971 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5972 Remove decls, since these functions are now static.
5973 (Funintern, Fget_internal_run_time): New decls, since these functions
5974 were already external.
5976 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5977 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5978 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5979 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5980 * keyboard.c, keymap.c, lread.c:
5981 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5982 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5983 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5984 Mark functions with DEFUE instead of DEFUN,
5985 if they are used in other modules.
5986 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5987 decls for now-static functions.
5988 * buffer.h (Fdelete_overlay): Remove decl.
5989 * callproc.c (Fgetenv_internal): Mark as internal.
5990 * composite.c (Fremove_list_of_text_properties): Remove decl.
5991 (Fcomposition_get_gstring): New forward static decl.
5992 * composite.h (Fcomposite_get_gstring): Remove decl.
5993 * dired.c (Ffile_attributes): New forward static decl.
5994 * doc.c (Fdocumntation_property): New forward static decl.
5995 * eval.c (Ffetch_bytecode): New forward static decl.
5996 (Funintern): Remove extern decl; now in .h file where it belongs.
5997 * fileio.c (Fmake_symbolic_link): New forward static decl.
5998 * image.c (Finit_image_library): New forward static decl.
5999 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6000 * intervals.h (Fprevious_property_change):
6001 (Fremove_list_of_text_properties): Remove decls.
6002 * keyboard.c (Fthis_command_keys): Remove decl.
6003 (Fcommand_execute): New forward static decl.
6004 * keymap.c (Flookup_key): New forward static decl.
6005 (Fcopy_keymap): Now static.
6006 * keymap.h (Flookup_key): Remove decl.
6007 * process.c (Fget_process): New forward static decl.
6008 (Fprocess_datagram_address): Mark as internal.
6009 * syntax.c (Fsyntax_table_p): New forward static decl.
6010 (skip_chars): Remove duplicate decl.
6011 * textprop.c (Fprevious_property_change): New forward static decl.
6012 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6014 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6015 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6017 * editfns.c (Fformat): Remove unreachable code.
6019 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6021 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6024 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6026 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6027 when at ZV. (Bug#8487)
6029 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6031 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6033 * keyboard.c (parse_tool_bar_item): Likewise.
6034 * sound.c (sound_cleanup, alsa_close): Likewise.
6035 * termcap.c (tgetent): Likewise.
6036 * xfns.c (x_default_font_parameter): Likewise.
6037 * xsettings.c (read_and_apply_settings): Likewise.
6039 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6040 (overrun_check_free): Protoize.
6042 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6044 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6045 since callers should never pass a negative size.
6046 Change the signature to match that of plain 'read' and 'write'; see
6047 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6048 * lisp.h: Update prototypes of emacs_write and emacs_read.
6050 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6052 * xdisp.c (redisplay_window): Don't try to determine the character
6053 position of the scroll margin if the window start point w->startp
6054 is outside the buffer's accessible region. (Bug#8468)
6056 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6058 Fix write-region and its subroutines for buffers > 2GB.
6059 * fileio.c (a_write, e_write): Modify declaration of arguments and
6060 local variables to support buffers larger than 2GB.
6061 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6063 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6064 argument, local variables, and return value.
6066 * lisp.h: Update prototypes of emacs_write and emacs_read.
6068 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6070 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6072 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6074 Fix more problems found by GCC 4.6.0's static checks.
6076 * xdisp.c (vmessage): Use a better test for character truncation.
6078 * charset.c (load_charset_map): <, not <=, for optimization,
6079 and to avoid potential problems with integer overflow.
6080 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6081 * casetab.c (set_identity, shuffle): Likewise.
6082 * editfns.c (Fformat): Likewise.
6083 * syntax.c (skip_chars): Likewise.
6085 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6086 This also lets GCC 4.6.0 generate slightly better loop code.
6088 * callint.c (Fcall_interactively): <, not <=, for optimization.
6089 (Fcall_interactively): Count the number of arguments produced,
6090 not the number of arguments given. This is simpler and lets GCC
6091 4.6.0 generate slightly better code.
6093 * ftfont.c: Distingish more carefully between FcChar8 and char.
6094 The previous code passed unsigned char * to a functions like
6095 strlen and xstrcasecmp that expect char *, which does not
6096 conform to the C standard.
6097 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6098 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6099 char * when the C standard requires it.
6101 * keyboard.c (read_char): Remove unused var.
6103 * eval.c: Port to Windows vsnprintf (Bug#8435).
6105 (SIZE_MAX): Define if the headers do not.
6106 (verror): Do not give up if vsnprintf returns a negative count.
6107 Instead, grow the buffer. This ports to Windows vsnprintf, which
6108 does not conform to C99. Problem reported by Eli Zaretskii.
6109 Also, simplify the allocation scheme, by avoiding the need for
6110 calling realloc, and removing the ALLOCATED variable.
6112 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6114 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6115 But keep the doprint source code for now, as we might revamp it
6116 and use it again (Bug#8435).
6117 * lisp.h (doprnt): Remove.
6118 * Makefile.in (base_obj): Remove doprnt.o.
6119 * deps.mk (doprnt.o): Remove.
6121 error: Print 32- and 64-bit integers portably (Bug#8435).
6122 Without this change, on typical 64-bit hosts error ("...%d...", N)
6123 was used to print both 32- and 64-bit integers N, which relied on
6125 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6127 * lisp.h (error, verror): Mark as printf-like functions.
6128 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6129 Report overflow in size calculations when allocating printf buffer.
6130 Do not truncate output string at its first null byte.
6131 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6132 Truncate the output at a character boundary, since vsnprintf does not
6134 * charset.c (check_iso_charset_parameter): Convert internal
6135 character to string before calling 'error', since %c now has the
6137 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6138 overflow when computing char to be passed to 'error'. Do not
6139 pass Lisp_Object to 'error'; pass the integer instead.
6140 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6141 formatted with plain %d.
6143 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6145 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6147 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6149 * xterm.c (x_catch_errors): Remove duplicate declaration.
6151 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6153 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6155 2011-04-10 Jim Meyering <meyering@redhat.com>
6157 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6158 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6159 return ssize_t not "int", and use size_t as the buffer length.
6160 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6161 * gnutls.h: Update declarations.
6162 * process.c (read_process_output): Use ssize_t, to match.
6163 (send_process): Likewise.
6165 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6167 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6169 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6171 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6172 Use unsigned char, to match FcChar8 type definition.
6174 * xterm.c (handle_one_xevent):
6175 * xmenu.c (create_and_show_popup_menu):
6176 * xselect.c (x_decline_selection_request)
6177 (x_reply_selection_request): Avoid type-punned deref of X events.
6179 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6181 Fix some uses of `int' instead of EMACS_INT.
6182 * search.c (string_match_1, fast_string_match)
6183 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6184 (scan_buffer, find_next_newline_no_quit)
6185 (find_before_next_newline, search_command, Freplace_match)
6186 (Fmatch_data): Make some `int' variables be EMACS_INT.
6188 * xdisp.c (display_count_lines): 3rd argument and return value now
6189 EMACS_INT. All callers changed.
6190 (pint2hrstr): Last argument is now EMACS_INT.
6192 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6193 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6194 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6195 (decode_coding_utf_16, decode_coding_emacs_mule)
6196 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6197 (decode_coding_ccl, decode_coding_charset)
6198 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6199 (decode_coding_iso_2022, decode_coding_emacs_mule)
6200 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6201 <char_offset, last_offset>: Declare EMACS_INT.
6202 (encode_coding_utf_8, encode_coding_utf_16)
6203 (encode_coding_emacs_mule, encode_invocation_designation)
6204 (encode_designation_at_bol, encode_coding_iso_2022)
6205 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6206 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6208 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6209 (encode_invocation_designation): Last argument P_NCHARS is now
6211 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6212 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6214 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6217 * ccl.c (Fccl_execute_on_string): Declare some variables
6220 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6222 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6224 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6226 * process.c (Fformat_network_address): Doc fix.
6228 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6230 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6232 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6234 * keyboard.c (read_char): Call Lisp function help-form-show,
6235 instead of using internal_with_output_to_temp_buffer.
6236 (Qhelp_form_show): New var.
6237 (syms_of_keyboard): Use DEFSYM macro.
6239 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6241 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6243 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6245 * process.c (Flist_processes): Remove to Lisp.
6246 (list_processes_1): Delete.
6248 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6250 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6252 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6254 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6256 Fix more problems found by GCC 4.6.0's static checks.
6258 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6260 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6262 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6264 * xdisp.c (vmessage): Mark as a printf-like function.
6266 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6268 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6270 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6271 printf-like functions.
6272 (tiff_load): Add casts to remove these marks before passing them
6273 to system-supplied API.
6275 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6277 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6278 This avoids several warnings with gcc -Wstrict-overflow.
6279 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6280 directly, rather than having caller test rule sign. This avoids
6281 some unnecessary tests.
6282 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6283 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6284 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6286 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6287 (xfont_open): Avoid unnecessary tests.
6289 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6291 * composite.h, composite.c (composition_gstring_put_cache):
6292 Use EMACS_INT, not int, for length.
6294 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6295 breaking out part of COMPOSITION_DECODE_RULE.
6296 (COMPOSITION_DECODE_RULE): Use it.
6297 * composite.c (get_composition_id): Remove unused local vars,
6298 by using the new macro.
6300 * textprop.c (set_text_properties_1): Change while to do-while,
6301 since the condition is always true at first.
6303 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6304 (interval_deletion_adjustment): Return unsigned value.
6307 * process.c (list_processes_1, create_pty, read_process_output):
6308 (exec_sentinel): Remove vars that were set but not used.
6309 (create_pty): Remove unnecessary "volatile"s.
6310 (Fnetwork_interface_info): Avoid possibility of int overflow.
6311 (read_process_output): Do adaptive read buffering even if carryover.
6312 (read_process_output): Simplify nbytes computation if buffered.
6314 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6316 * syntax.c (scan_words): Remove var that was set but not used.
6317 (update_syntax_table): Use unsigned instead of int.
6319 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6320 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6321 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6323 * print.c (print_error_message): Avoid int overflow.
6325 * font.c (font_list_entities): Redo for clarity,
6326 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6328 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6329 (font_score): Avoid potential overflow in diff calculation.
6331 * fns.c (substring_both): Remove var that is set but not used.
6332 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6334 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6336 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6337 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6338 can always succeed if overflow has undefined behavior.
6340 * search.c (boyer_moore, wordify): Remove vars set but not used.
6341 (wordify): Omit three unnecessary tests.
6343 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6344 All callers changed. This avoids the need for an unused var.
6346 * casefiddle.c (casify_region): Remove var that is set but not used.
6348 * dired.c (file_name_completion): Remove var that is set but not used.
6350 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6352 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6353 (Finsert_file_contents): Remove unnecessary code checking fd.
6355 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6356 Check for integer overflow on size calculations.
6358 * buffer.c (Fprevious_overlay_change): Remove var that is set
6361 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6362 Remove vars that are set but not used.
6363 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6364 (timer_check_2): Mark vars as initialized.
6366 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6368 * image.c (lookup_image): Remove var that is set but not used.
6369 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6371 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6372 that are set but not used.
6374 * xfns.c (make_invisible_cursor): Don't return garbage
6375 if XCreateBitmapFromData fails (Bug#8410).
6377 * xselect.c (x_get_local_selection, x_handle_property_notify):
6378 Remove vars that are set but not used.
6380 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6381 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6383 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6384 Remove var that is set but not used.
6385 (scroll_bar_windows_size): Now size_t, not int.
6386 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6389 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6390 (map_tty_color) [!defined MSDOS]: Likewise.
6392 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6394 * coding.c: Remove vars that are set but not used.
6395 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6396 All callers changed.
6397 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6398 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6399 (decode_coding_charset): Remove vars that are set but not used.
6401 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6402 that is set but not used.
6404 * print.c (print_object): Remove var that is set but not used.
6406 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6407 The gnulib version avoids calling malloc in the usual case,
6408 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6409 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6410 * filelock.c (current_lock_owner): Likewise.
6411 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6412 * sysdep.c: Include allocator.h, careadlinkat.h.
6413 (emacs_no_realloc_allocator): New static constant.
6414 (emacs_readlink): New function.
6415 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6416 ../lib/careadlinkat.h.
6418 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6420 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6421 first non-nil return value).
6423 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6425 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6426 if not defined (Bug#8403).
6428 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6430 * xdisp.c (display_count_lines): Remove parameter `start',
6431 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6432 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6433 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6434 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6435 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6436 and thereabouts. All callers changed.
6437 (get_per_char_metric): Remove parameter `f', unused since
6438 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6440 2011-04-02 Jim Meyering <meyering@redhat.com>
6442 do not dereference NULL upon failed strdup
6443 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6444 (ns_get_family): Likewise.
6446 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6448 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6450 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6452 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6455 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6457 Add lexical binding.
6459 * window.c (Ftemp_output_buffer_show): New fun.
6460 (Fsave_window_excursion):
6461 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6463 * lread.c (lisp_file_lexically_bound_p): New function.
6464 (Fload): Bind Qlexical_binding.
6465 (readevalloop): Remove `evalfun' arg.
6466 Bind Qinternal_interpreter_environment.
6467 (Feval_buffer): Bind Qlexical_binding.
6468 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6470 (syms_of_lread): Declare `lexical-binding'.
6472 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6474 * keyboard.c (eval_dyn): New fun.
6475 (menu_item_eval_property): Use it.
6477 * image.c (parse_image_spec): Use Ffunctionp.
6479 * fns.c (concat, mapcar1): Accept byte-code-functions.
6481 * eval.c (Fsetq): Handle lexical vars.
6482 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6483 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6484 (FletX, Flet): Obey lexical binding.
6485 (Fcommandp): Handle closures.
6486 (Feval): New `lexical' arg.
6487 (eval_sub): New function extracted from Feval. Use it almost
6488 everywhere where Feval was used. Look up vars in lexical env.
6490 (Ffunctionp): Move from subr.el.
6491 (Ffuncall): Handle closures.
6492 (apply_lambda): Remove `eval_flags'.
6493 (funcall_lambda): Handle closures and new byte-code-functions.
6494 (Fspecial_variable_p): New function.
6495 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6496 but without exporting it to Lisp.
6498 * doc.c (Fdocumentation, store_function_docstring):
6499 * data.c (Finteractive_form): Handle closures.
6501 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6504 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6506 (exec_byte_code): New function extracted from Fbyte_code to handle new
6507 calling convention for byte-code-functions. Add new byte-codes.
6509 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6511 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6513 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6515 * xdisp.c (redisplay_internal): Fix prototype.
6517 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6519 * xdisp.c (SCROLL_LIMIT): New macro.
6520 (try_scrolling): Use it when setting scroll_limit.
6521 Limit scrolling to 100 screen lines.
6522 (redisplay_window): Even when falling back on "recentering",
6523 position point in the window according to scroll-conservatively,
6524 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6526 (try_scrolling): When point is above the window, allow searching
6527 as far as scroll_max, or one screenful, to compute vertical
6528 distance from PT to the scroll margin position. This prevents
6529 try_scrolling from unnecessarily failing when
6530 scroll-conservatively is set to a value slightly larger than the
6531 window height. Clean up the case of PT below the margin at bottom
6532 of window: scroll_max can no longer be INT_MAX. When aggressive
6533 scrolling is in use, don't let point enter the opposite scroll
6534 margin as result of the scroll.
6535 (syms_of_xdisp) <scroll-conservatively>: Document the
6536 threshold of 100 lines for never-recentering scrolling.
6538 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6540 * dispextern.h (move_it_by_lines):
6541 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6542 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6543 (message_log_check_duplicate): Remove parameters `prev_bol' and
6544 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6545 (redisplay_internal): Remove parameter `preserve_echo_area',
6546 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6548 * indent.c (Fvertical_motion):
6549 * window.c (window_scroll_pixel_based, Frecenter):
6550 Don't pass `need_y_p' to `move_it_by_lines'.
6552 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6554 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6555 steal a few bits to be more compact.
6556 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6557 Remove unneeded casts.
6559 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6561 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6563 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6564 binding" message (bug#7967).
6566 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6568 Fix more problems found by GCC 4.6.0's static checks.
6570 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6571 Remove unused local var.
6573 * editfns.c (Fmessage_box): Remove unused local var.
6575 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6576 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6577 Omit unused local vars.
6578 * window.c (shrink_windows): Omit unused local var.
6579 * menu.c (digest_single_submenu): Omit unused local var.
6580 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6581 Omit unused local var.
6583 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6584 Don't assume string length fits in int.
6585 (keyremap_step, read_key_sequence): Use size_t for sizes.
6586 (read_key_sequence): Don't check last_real_key_start redundantly.
6588 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6589 instead of alloca (Bug#8344).
6591 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6592 (Fbacktrace_frame): Don't assume nframes fits in int.
6594 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6596 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6599 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6601 * cm.c (calccost): Turn while-do into do-while, for clarity.
6603 * keyboard.c (syms_of_keyboard): Use the same style as later
6604 in this function when indexing through an array. This also
6605 works around GCC bug 48267.
6607 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6609 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6611 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6612 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6614 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6615 This avoids undefined behavior on integer overflow, and is a bit
6616 more convenient anyway since it is compared to a size_t variable.
6618 Variadic C functions now count arguments with size_t, not int.
6619 This avoids an unnecessary limitation on 64-bit machines, which
6620 caused (substring ...) to crash on large vectors (Bug#8344).
6621 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6622 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6623 All variadic functions and their callers changed accordingly.
6624 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6625 * data.c (arith_driver, float_arith_driver): Likewise.
6626 * editfns.c (general_insert_function): Likewise.
6627 * eval.c (struct backtrace.nargs, interactive_p)
6628 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6629 (funcall_lambda, mark_backtrace): Likewise.
6630 * fns.c (concat): Likewise.
6631 * frame.c (x_set_frame_parameters): Likewise.
6632 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6633 0 if not found, not -1. All callers changed.
6635 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6636 (stack_copy_size): Now size_t, not int.
6637 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6639 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6641 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6642 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6643 All callers changed.
6645 * lisp.h (multibyte_char_to_unibyte):
6646 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6647 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6648 * character.h (CHAR_TO_BYTE8):
6649 * cmds.c (internal_self_insert):
6650 * editfns.c (general_insert_function):
6651 * keymap.c (push_key_description):
6652 * search.c (Freplace_match):
6653 * xdisp.c (message_dolog, set_message_1): All callers changed.
6655 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6657 * keyboard.c (safe_run_hook_funcall): New function.
6658 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6659 don't set the hook to nil, but remove the offending function instead.
6660 (Qcommand_hook_internal): Remove, unused.
6661 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6662 Vcommand_hook_internal.
6664 * eval.c (enum run_hooks_condition): Remove.
6665 (funcall_nil, funcall_not): New functions.
6666 (run_hook_with_args): Call each function through a `funcall' argument.
6667 Remove `cond' argument, now redundant.
6668 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6669 (Frun_hook_with_args_until_failure): Adjust accordingly.
6670 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6672 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6674 * dispextern.h (string_buffer_position): Remove declaration.
6676 * print.c (strout): Remove parameter `multibyte', unused since
6677 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6679 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6680 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6681 All callers changed.
6683 * w32.c (_wsa_errlist): Use braces for struct initializers.
6685 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6686 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6687 All callers changed.
6688 (string_buffer_position): Likewise. Also, make static (it's never
6689 used outside xdisp.c).
6690 (cursor_row_p): Remove parameter `w', unused since
6691 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6692 (decode_mode_spec): Remove parameter `precision', introduced during
6693 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6694 All callers changed.
6696 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6698 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6700 2011-03-27 Anders Lindgren <andlind@gmail.com>
6702 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6703 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6704 (ns_update_auto_hide_menu_bar): New functions.
6705 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6706 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6707 ns_constrain_all_frames.
6708 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6709 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6711 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6713 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6715 2011-03-27 Glenn Morris <rgm@gnu.org>
6717 * syssignal.h: Replace RETSIGTYPE with void.
6718 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6719 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6720 Replace SIGTYPE with void everywhere.
6721 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6722 * s/template.h (SIGTYPE): Remove commented out definition.
6724 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6726 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6727 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6729 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6731 * w32.c (read_unc_volume): Use parameter `henum', instead of
6732 global variable `wget_enum_handle'.
6734 * keymap.c (describe_vector): Remove parameters `indices' and
6735 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6736 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6738 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6740 * keyboard.c (timer_check): Remove parameter `do_it_now',
6741 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6742 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6743 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6745 * keyboard.c (read_char):
6746 * w32menu.c (w32_menu_display_help):
6747 * xmenu.c (show_help_event, menu_help_callback):
6748 Adjust calls to `show_help_echo'.
6750 * gtkutil.c (xg_maybe_add_timer):
6751 * keyboard.c (readable_events):
6752 * process.c (wait_reading_process_output):
6753 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6755 * insdel.c (adjust_markers_gap_motion):
6756 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6757 (gap_left, gap_right): Don't call it.
6759 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6761 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6762 incurred during fontification.
6764 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6766 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6767 (DEFVAR_PER_BUFFER): Don't pass it.
6769 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6770 (scrolling_window): Don't pass it.
6772 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6774 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6776 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6778 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6779 of variables specific to SELinux and computation of `encoded_absname'.
6781 * image.c (XPutPixel): Remove unused variable `height'.
6783 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6785 * unexw32.c (get_section_info): Remove unused variable `section'.
6787 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6788 (system_process_attributes): Remove unused variable `sess'.
6789 (sys_read): Remove unused variable `err'.
6791 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6792 (w32_wnd_proc): Remove unused variable `isdead'.
6793 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6794 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6795 (x_create_tip_frame): Remove unused variable `tem'.
6797 * w32inevt.c (w32_console_read_socket):
6798 Remove unused variable `no_events'.
6800 * w32term.c (x_draw_composite_glyph_string_foreground):
6801 Remove unused variable `width'.
6803 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6805 * w32term.c (x_set_glyph_string_clipping):
6806 Don't pass uninitialized region to CombineRgn.
6808 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6810 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6811 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6812 (Fx_close_connection): Remove unused variable `i'.
6814 * w32font.c (w32font_draw): Return number of glyphs.
6815 (w32font_open_internal): Remove unused variable `i'.
6816 (w32font_driver): Add missing initializer.
6818 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6819 (fill_in_menu): Remove unused variable `items_added'.
6821 * w32term.c (last_mouse_press_frame): Remove static global variable.
6822 (w32_clip_to_row): Remove unused variable `f'.
6823 (x_delete_terminal): Remove unused variable `i'.
6825 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6826 (NOTHING): Remove unused static global variable.
6827 (uniscribe_check_otf): Remove unused variable `table'.
6828 (uniscribe_font_driver): Add missing initializers.
6830 2011-03-23 Julien Danjou <julien@danjou.info>
6832 * term.c (Fsuspend_tty, Fresume_tty):
6833 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6834 * window.c (temp_output_buffer_show):
6835 * insdel.c (signal_before_change):
6836 * frame.c (Fhandle_switch_frame):
6837 * fileio.c (Fdo_auto_save):
6838 * emacs.c (Fkill_emacs):
6839 * editfns.c (save_excursion_restore):
6840 * cmds.c (internal_self_insert):
6841 * callint.c (Fcall_interactively):
6842 * buffer.c (Fkill_all_local_variables):
6843 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6845 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6846 unconditionnaly since it does the check itself.
6848 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6850 Fix more problems found by GCC 4.5.2's static checks.
6852 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6853 the first time through the loop, since we know p0 < p1 then.
6854 This also avoids a gcc -Wstrict-overflow warning.
6856 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6857 leading to a memory leak, possible in functions like
6858 load_charset_map_from_file that can allocate an unbounded number
6859 of objects (Bug#8318).
6861 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6862 that could (at least in theory) be that large.
6864 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6865 This is less likely to overflow, and avoids undefined behavior if
6866 overflow does occur. All callers changed. Use strtoul to scan
6867 for the unsigned long integer.
6868 (pint2hrstr): Simplify and tune code slightly.
6869 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6871 * scroll.c (do_scrolling): Work around GCC bug 48228.
6872 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6874 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6875 This also avoids a warning with gcc -Wstrict-overflow.
6876 (validate_x_resource_name): Simplify count usage.
6877 This also avoids a warning with gcc -Wstrict-overflow.
6879 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6882 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6884 * process.c (Fmake_network_process): Use socklen_t, not int,
6885 where POSIX says socklen_t is required in portable programs.
6886 This fixes a porting bug on hosts like 64-bit HP-UX, where
6887 socklen_t is wider than int (Bug#8277).
6888 (Fmake_network_process, server_accept_connection):
6889 (wait_reading_process_output, read_process_output):
6892 * process.c: Rename or move locals to avoid shadowing.
6893 (list_processes_1, Fmake_network_process):
6894 (read_process_output_error_handler, exec_sentinel_error_handler):
6895 Rename or move locals.
6896 (Fmake_network_process): Define label "retry_connect" only if needed.
6897 (Fnetwork_interface_info): Fix pointer signedness.
6898 (process_send_signal): Add cast to avoid pointer signedness problem.
6899 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6900 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6902 Make tparam.h and terminfo.c consistent.
6903 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6904 Include tparam.h instead, since it declares them.
6905 * cm.h (PC): Remove extern decl; tparam.h now does this.
6906 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6907 * terminfo.c: Include tparam.h, to check interfaces.
6908 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6909 (tparam): Adjust signature to match interface in tparam.h;
6910 this removes some undefined behavior. Check that outstring and len
6911 are zero, which they always are with Emacs.
6912 * tparam.h (PC, BC, UP): New extern decls.
6914 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6915 (xftfont_open): Rename locals to avoid shadowing.
6917 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6918 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6919 (OTF_TAG_SYM): Omit macro if not needed.
6920 (ftfont_list): Remove unused local.
6921 (get_adstyle_property, ftfont_pattern_entity):
6922 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6923 Rename locals to avoid shadowing.
6925 * xfont.c (xfont_list_family): Mark var as initialized.
6927 * xml.c (make_dom): Now static.
6929 * composite.c (composition_compute_stop_pos): Rename local to
6931 (composition_reseat_it): Remove unused locals.
6932 (find_automatic_composition, composition_adjust_point): Likewise.
6933 (composition_update_it): Mark var as initialized.
6934 (find_automatic_composition): Mark vars as initialized,
6935 with a FIXME (Bug#8290).
6937 character.h: Rename locals to avoid shadowing.
6938 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6939 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6940 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6941 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6944 * textprop.c (property_change_between_p): Remove; unused.
6946 * intervals.c (interval_start_pos): Now static.
6948 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6950 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6951 Rename locals to avoid shadowing.
6953 * sound.c (wav_play, au_play, Fplay_sound_internal):
6954 Fix pointer signedness.
6955 (alsa_choose_format): Remove unused local var.
6956 (wav_play): Initialize a variable to 0, to prevent undefined
6957 behavior (Bug#8278).
6959 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6961 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6963 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6964 clobbering (Bug#8298).
6965 * sysdep.c (sys_subshell): Likewise.
6966 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6968 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6969 This should get cleaned up, so that child_setup has the
6970 same signature on all platforms.
6972 * callproc.c (call_process_cleanup): Now static.
6973 (relocate_fd): Rename locals to avoid shadowing.
6975 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6977 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6978 not to be necessary, and produces flickering.
6980 2011-03-20 Glenn Morris <rgm@gnu.org>
6982 * config.in: Remove file.
6984 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6986 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6987 are now in src/globals.h.
6988 (syms_of_minibuf): Remove spurious & from previous change.
6990 2011-03-20 Leo <sdl.web@gmail.com>
6992 * minibuf.c (completing-read-function): New variable.
6993 (completing-read-default): Rename from completing-read.
6994 (completing-read): Call completing-read-function.
6996 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6998 * xfaces.c (Fx_load_color_file):
6999 Read color file from absolute filename (bug#8250).
7001 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7003 * makefile.w32-in: Update dependencies.
7005 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7007 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7009 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7011 Fix more problems found by GCC 4.5.2's static checks.
7013 * process.c (make_serial_process_unwind, send_process_trap):
7014 (sigchld_handler): Now static.
7016 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7017 That way, the code declares only the vars that it needs.
7018 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7019 * s/cygwin.h (PTY_ITERATION): Likewise.
7020 * s/darwin.h (PTY_ITERATION): Likewise.
7021 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7023 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7024 * process.c (allocate_pty): Don't declare stb unless it's needed.
7026 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7027 (CONSTANTLIM): Remove; unused.
7028 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7029 Define only if needed.
7031 * unexelf.c (unexec): Name an expression,
7032 to avoid gcc -Wbad-function-cast warning.
7033 Use a different way to cause a compilation error if anyone uses
7034 n rather than nn, a way that does not involve shadowing.
7035 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7037 * deps.mk (unexalpha.o): Remove; unused.
7039 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7040 * unexec.h: New file.
7041 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7042 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7044 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7045 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7046 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7047 Change as necessary to match prototype in unexec.h.
7049 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7051 (back_comment, skip_chars): Mark vars as initialized.
7053 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7054 Rename locals to avoid shadowing.
7056 * lread.c (read1): Rewrite so as not to use empty "else".
7057 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7059 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7061 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7062 warning when compiling print.c.
7064 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7065 instead of using an uninitialized var.
7066 (font_sort_entities): Mark var as initialized.
7068 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7070 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7071 pointers to constants.
7072 (font_parse_fcname): Remove unused vars.
7073 (font_delete_unmatched): Now static.
7074 (font_get_spec): Remove; unused.
7075 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7076 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7077 Rename or move locals to avoid shadowing.
7079 * fns.c (require_nesting_list, require_unwind): Now static.
7080 (Ffillarray): Rename locals to avoid shadowing.
7082 * floatfns.c (domain_error2): Define only if needed.
7083 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7085 * alloc.c (mark_backtrace): Move decl from here ...
7086 * lisp.h: ... to here, so that it can be checked.
7088 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7089 (Fdefvar): Rewrite so as not to use empty "else".
7090 (lisp_indirect_variable): Name an expression,
7091 to avoid gcc -Wbad-function-cast warning.
7092 (Fdefvar): Rename locals to avoid shadowing.
7094 * callint.c (quotify_arg, quotify_args): Now static.
7095 (Fcall_interactively): Rename locals to avoid shadowing.
7096 Use const pointer when appropriate.
7098 * lisp.h (get_system_name, get_operating_system_release):
7099 Move decls here, to check interfaces.
7100 * process.c (get_operating_system_release): Move decl to lisp.h.
7101 * xrdb.c (get_system_name): Likewise.
7102 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7103 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7104 some of which prompt warnings from gcc -Wbad-function-cast.
7105 (Fformat_time_string, Fencode_time, Finsert_char):
7106 (Ftranslate_region_internal, Fformat):
7107 Rename or remove local vars to avoid shadowing.
7108 (Ftranslate_region_internal): Mark var as initialized.
7110 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7113 * lisp.h (eassert): Check that the argument compiles, even if
7114 ENABLE_CHECKING is not defined.
7116 * data.c (Findirect_variable): Name an expression, to avoid
7117 gcc -Wbad-function-cast warning.
7118 (default_value, arithcompare, arith_driver, arith_error): Now static.
7119 (store_symval_forwarding): Rename local to avoid shadowing.
7120 (Fmake_variable_buffer_local, Fmake_local_variable):
7121 Mark variables as initialized.
7122 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7124 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7125 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7126 Rename locals to avoid shadowing.
7127 (mark_stack): Move local variables into the #ifdef region where
7129 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7130 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7132 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7133 (GC_STRING_CHARS): Remove; not used.
7134 (Fmemory_limit): Cast sbrk's returned value to char *.
7136 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7137 avoids undefined behavior in theory.
7139 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7141 Use functions, not macros, for up- and down-casing (Bug#8254).
7142 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7143 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7144 to use the following functions instead of these macros.
7145 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7146 EMACS_INT, since callers assume the returned value fits in int.
7147 (upcase1): Likewise, for UPCASE_TABLE.
7148 (uppercasep, lowercasep, upcase): New static inline functions.
7149 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7150 the race-condition problem in the old DOWNCASE.
7152 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7153 Rename locals to avoid shadowing.
7154 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7155 (regex_compile, re_search_2, re_match_2_internal):
7156 Remove unused local vars.
7157 (FREE_VAR): Rewrite so as not to use empty "else",
7158 which gcc can warn about.
7159 (regex_compile, re_match_2_internal): Mark locals as initialized.
7160 (RETALLOC_IF): Define only if needed.
7161 (WORDCHAR_P): Likewise. This one is never needed, but is used
7162 only in a comment talking about a compiler bug, so put inside
7163 the #if 0 of that comment.
7164 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7165 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7168 * search.c (boyer_moore): Rename locals to avoid shadowing.
7169 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7170 (PREV_CHAR_BOUNDARY): Likewise.
7172 * search.c (simple_search): Remove unused var.
7174 * dired.c (compile_pattern): Move decl from here ...
7175 * lisp.h: ... to here, so that it can be checked.
7176 (struct re_registers): New forward decl.
7178 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7180 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7182 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7183 Rename locals to avoid shadowing.
7184 (Fvertical_motion): Mark locals as initialized.
7186 * casefiddle.c (casify_object, casify_region): Now static.
7187 (casify_region): Mark local as initialized.
7189 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7191 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7192 New macros, so that the caller can use some names other than
7193 gcpro1, gcpro2, etc.
7194 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7196 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7197 argument, for consistency with GCPRO2_VAR, etc: it is now the
7198 prefix of the variable, not the variable itself. All uses
7200 * dired.c (directory_files_internal, file_name_completion):
7201 Rename locals to avoid shadowing.
7203 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7204 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7205 dired.c's scmp function, had undefined behavior.
7206 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7207 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7208 * buffer.h: ... to here, because these macros use current_buffer,
7209 and the new implementation with inline functions needs to have
7210 current_buffer in scope now, rather than later when the macros
7212 (downcase, upcase1): New static inline functions.
7213 (DOWNCASE, UPCASE1): Reimplement using these functions.
7214 This avoids undefined behavior in expressions like
7215 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7216 from race conditions in accessing the global variables
7217 case_temp1 and case_temp2.
7218 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7219 * lisp.h (case_temp1, case_temp2): Remove their decls.
7220 * character.h (ASCII_CHAR_P): Move from here ...
7221 * lisp.h: ... to here, so that the inline functions mentioned
7224 * dired.c (directory_files_internal_unwind): Now static.
7226 * fileio.c (file_name_as_directory, directory_file_name):
7227 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7229 (file_name_as_directory): Use const pointers when appropriate.
7230 (Fexpand_file_name): Likewise. In particular, newdir might
7231 point at constant storage, so make it a const pointer.
7232 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7233 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7235 (Fset_file_times, Finsert_file_contents, auto_save_error):
7236 Rename locals to avoid shadowing.
7238 * minibuf.c (choose_minibuf_frame_1): Now static.
7239 (Ftry_completion, Fall_completions): Rename or remove locals
7242 * marker.c (bytepos_to_charpos): Remove; unused.
7244 * lisp.h (verify_bytepos, count_markers): New decls,
7245 so that gcc does not warn that these functions aren't declared.
7247 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7248 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7249 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7250 (copy_text): Remove unused local var.
7252 * filelock.c (within_one_second): Now static.
7253 (lock_file_1): Rename local to avoid shadowing.
7255 * buffer.c (fix_overlays_before): Mark locals as initialized.
7256 (fix_start_end_in_overlays): Likewise. This function should be
7257 simplified by using pointers-to-pointers, but that's a different
7259 (switch_to_buffer_1): Now static.
7260 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7261 (report_overlay_modification): Rename locals to avoid shadowing.
7263 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7264 Fix pointer signedness issue.
7265 (sys_subshell): Mark local as volatile if checking for lint,
7266 to suppress a gcc -Wclobbered warning that does not seem to be right.
7267 (MAXPATHLEN): Define only if needed.
7269 * process.c (serial_open, serial_configure): Move decls from here ...
7270 * systty.h: ... to here, so that they can be checked.
7272 * fns.c (get_random, seed_random): Move extern decls from here ...
7273 * lisp.h: ... to here, so that they can be checked.
7275 * sysdep.c (reset_io): Now static.
7276 (wait_for_termination_signal): Remove; unused.
7278 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7279 (copy_keymap_item, append_key, push_text_char_description):
7281 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7282 (DENSE_TABLE_SIZE): Remove; unused.
7283 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7284 (describe_map_tree):
7285 Rename locals to avoid shadowing.
7287 * keyboard.c: Declare functions static if they are not used elsewhere.
7288 (echo_char, echo_dash, cmd_error, top_level_2):
7289 (poll_for_input, handle_async_input): Now static.
7290 (read_char, kbd_buffer_get_event, make_lispy_position):
7291 (make_lispy_event, make_lispy_movement, apply_modifiers):
7292 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7293 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7294 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7295 (read_key_sequence, read_char): Mark locals as initialized.
7296 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7298 * keyboard.h (make_ctrl_char): New decl.
7299 (mark_kboards): Move decl here ...
7300 * alloc.c (mark_kboards): ... from here.
7302 * lisp.h (force_auto_save_soon): New decl.
7304 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7305 (DEFINE_DUMMY_FUNCTION): New macro.
7306 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7308 (main): Add casts to avoid warnings
7309 if GCC considers string literals to be constants.
7311 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7313 * dbusbind.c: Pointer signedness fixes.
7314 (xd_signature, xd_append_arg, xd_initialize):
7315 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7316 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7317 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7318 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7320 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7321 if GCC considers string literals to be constants.
7322 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7324 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7326 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7327 (print_preprocess, print_object): New macro to fix last change.
7329 * print.c (print_preprocess): Don't forget font objects.
7331 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7333 * emacs.c (USAGE3): Doc fixes.
7335 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7337 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7340 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7342 * lisp.h (VWindow_system, Qfile_name_history):
7343 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7344 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7345 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7347 * w32select.c: Don't #include "keyboard.h".
7348 (run_protected): Add extern declaration for waiting_for_input.
7350 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7351 * w32console.c (detect_input_pending, read_input_pending)
7352 (encode_terminal_code):
7353 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7354 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7355 (w32_system_caret_y, Qfile_name_history):
7356 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7357 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7358 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7359 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7360 * w32proc.c (Qlocal, report_file_error):
7361 * w32term.c (Vwindow_system, updating_frame):
7362 * w32uniscribe.c (initialized, uniscribe_font_driver):
7363 Remove unneeded extern declarations.
7365 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7367 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7369 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7371 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7372 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7373 These macros can no longer be used for assignment.
7375 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7376 Assign struct members directly, instead of using BUF_BEGV etc.
7377 (record_buffer_markers, fetch_buffer_markers): New functions for
7378 recording and fetching special buffer markers.
7379 (set_buffer_internal_1, set_buffer_temp): Use them.
7381 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7383 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7385 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7386 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7388 * xdisp.c (hscroll_window_tree):
7389 (reconsider_clip_changes): Use PT instead of BUF_PT.
7391 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7393 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7394 $(EMACS_ROOT)/lib/intprops.h.
7396 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7398 Fix more problems found by GCC 4.5.2's static checks.
7400 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7401 to unsigned char * to avoid compiler diagnostic.
7402 (xg_free_frame_widgets): Make it clear that a local variable is
7403 needed only if USE_GTK_TOOLTIP.
7404 (gdk_window_get_screen): Make it clear that this macro is needed
7405 only if USE_GTK_TOOLTIP.
7406 (int_gtk_range_get_value): New function, which avoids a diagnostic
7407 from gcc -Wbad-function-cast.
7408 (xg_set_toolkit_scroll_bar_thumb): Use it.
7409 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7410 diagnostic from gcc -Wbad-function-cast.
7411 (get_utf8_string, xg_get_file_with_chooser):
7412 Rename locals to avoid shadowing.
7413 (create_dialog): Move locals to avoid shadowing.
7415 * xgselect.c (xg_select): Remove unused var.
7417 * image.c (four_corners_best): Mark locals as initialized.
7418 (gif_load): Initialize transparent_p to zero (Bug#8238).
7419 Mark another local as initialized.
7420 (my_png_error, my_error_exit): Mark with NO_RETURN.
7422 * image.c (clear_image_cache): Now static.
7423 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7424 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7425 (x_edge_detection): Remove unnecessary cast that
7426 gcc -Wbad-function-cast diagnoses.
7427 (gif_load): Fix pointer signedness.
7428 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7429 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7431 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7433 Improve quality of tests for time stamp overflow.
7434 For example, without this patch (encode-time 0 0 0 1 1
7435 1152921504606846976) returns the obviously-bogus value (-948597
7436 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7437 reports time overflow. See
7438 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7439 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7440 * editfns.c: Include limits.h and intprops.h.
7441 (TIME_T_MIN, TIME_T_MAX): New macros.
7442 (time_overflow): Move earlier, to before first use.
7443 (hi_time, lo_time): New functions, for an accurate test for
7445 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7446 (Fget_internal_run_time): Don't assume time_t fits in int.
7447 (make_time): Use list2 instead of Fcons twice.
7448 (Fdecode_time): More accurate test for out-of-range times.
7449 (check_tm_member): New function.
7450 (Fencode_time): Use it, to test for out-of-range times.
7451 (lisp_time_argument): Don't rely on undefined left-shift and
7452 right-shift behavior when checking for time stamp overflow.
7454 * editfns.c (time_overflow): New function, refactoring common code.
7455 (Fformat_time_string, Fdecode_time, Fencode_time):
7456 (Fcurrent_time_string): Use it.
7458 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7459 * dired.c (make_time): Move to ...
7460 * editfns.c (make_time): ... here.
7461 * systime.h: Note the move.
7463 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7465 * fringe.c (update_window_fringes): Remove unused variables.
7467 * unexmacosx.c (copy_data_segment): Also copy __got section.
7470 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7472 * termcap.c [MSDOS]: Include "msdos.h".
7473 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7474 Constify `char *' arguments and their references according to
7475 prototypes in tparam.h.
7477 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7479 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7480 Adapt all references accordingly.
7482 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7484 2011-03-11 Tom Tromey <tromey@redhat.com>
7486 * buffer.c (syms_of_buffer): Remove obsolete comment.
7488 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7490 * termhooks.h (encode_terminal_code): Declare prototype.
7492 * msdos.c (encode_terminal_code): Don't declare prototype.
7494 * term.c (encode_terminal_code): Now external again, used by
7495 w32console.c and msdos.c.
7497 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7498 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7500 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7502 Fix some minor problems found by GCC 4.5.2's static checks.
7504 * fringe.c (update_window_fringes): Mark locals as initialized
7506 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7508 * alloc.c (mark_fringe_data): Move decl from here ...
7509 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7510 to check its interface.
7511 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7513 * fontset.c (free_realized_fontset): Now static.
7514 (Fset_fontset_font): Rename local to avoid shadowing.
7515 (fontset_font): Mark local as initialized.
7516 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7518 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7520 * xselect.c (x_disown_buffer_selections): Remove; not used.
7521 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7522 (x_own_selection, Fx_disown_selection_internal): Rename locals
7524 (x_handle_dnd_message): Remove local to avoid shadowing.
7526 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7527 so that the caller can use some name other than gcpro1.
7528 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7529 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7530 (Fx_backspace_delete_keys_p):
7531 Use them to avoid shadowing, and rename vars to avoid shadowing.
7532 (x_decode_color, x_set_name, x_window): Now static.
7533 (Fx_create_frame): Add braces to silence GCC warning.
7534 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7535 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7536 Remove unused locals.
7537 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7538 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7539 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7542 * xterm.h (x_mouse_leave): New decl.
7544 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7545 Remove unused functions.
7546 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7547 (x_calc_absolute_position): Now static.
7548 (XTread_socket): Don't define label "out" unless it's used.
7549 Don't declare local "event" unless it's used.
7550 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7551 unless they are used.
7552 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7553 (x_fatal_error_signal): Remove; not used.
7554 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7555 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7556 (x_error_catcher, x_connection_closed, x_error_handler):
7557 (x_error_quitter, xembed_send_message, x_iconify_frame):
7558 (my_log_handler): Rename locals to avoid shadowing.
7559 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7560 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7562 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7563 Rename or move locals to avoid shadowing.
7564 (tty_defined_color, merge_face_heights): Now static.
7565 (free_realized_faces_for_fontset): Remove; not used.
7566 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7567 does not deduce is never used uninitialized.
7568 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7569 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7571 * terminal.c (store_terminal_param): Now static.
7573 * xmenu.c (menu_highlight_callback): Now static.
7574 (set_frame_menubar): Remove unused local.
7575 (xmenu_show): Rename parameter to avoid shadowing.
7576 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7577 since they might point to immutable storage.
7578 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7579 since it's unused otherwise.
7581 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7582 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7583 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7584 avoids a gcc -Wuninitialized diagnostic.
7585 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7586 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7587 does not deduce are never used uninitialized.
7589 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7591 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7592 * window.c (window_loop, size_window):
7593 (run_window_configuration_change_hook, enlarge_window): Likewise.
7595 * window.c (display_buffer): Now static.
7596 (size_window): Mark variables that gcc -Wuninitialized
7597 does not deduce are never used uninitialized.
7598 * window.h (check_all_windows): New decl, to forestall
7599 gcc -Wmissing-prototypes diagnostic.
7600 * dispextern.h (bidi_dump_cached_states): Likewise.
7602 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7604 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7606 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7607 and to avoid gcc -Wuninitialized warning.
7608 (load_charset_map): Mark variables that gcc -Wuninitialized
7609 does not deduce are never used uninitialized.
7610 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7612 * coding.c (coding_set_source, coding_set_destination):
7613 Use "else { /* comment */ }" rather than "else /* comment */;"
7614 for clarity, and to avoid gcc -Wempty-body warning.
7615 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7616 a block, when the outer 'i' will do.
7617 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7618 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7619 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7620 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7621 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7622 Rename locals to avoid shadowing.
7623 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7624 * coding.c (emacs_mule_char, encode_invocation_designation):
7625 Now static, since they're not used elsewhere.
7626 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7627 (decode_coding_object, encode_coding_object, detect_coding_system):
7628 (decode_coding_emacs_mule): Mark variables that gcc
7629 -Wuninitialized does not deduce are never used uninitialized.
7630 (detect_coding_iso_2022): Initialize a local variable that might
7631 be used uninitialized. Leave a FIXME because it's not clear that
7632 this initialization is needed. (Bug#8211)
7633 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7634 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7635 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7636 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7637 Remove unused macros.
7639 * category.c (hash_get_category_set): Remove unused local var.
7640 (copy_category_table): Now static, since it's not used elsewhere.
7641 * character.c (string_count_byte8): Likewise.
7643 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7644 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7646 * chartab.c (copy_sub_char_table): Now static, since it's not used
7648 (sub_char_table_ref_and_range, char_table_ref_and_range):
7649 Rename locals to avoid shadowing.
7650 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7652 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7653 (BIDI_BOB): Remove unused macro.
7655 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7656 deduce are never used uninitialized.
7657 * term.c (encode_terminal_code): Likewise.
7659 * term.c (encode_terminal_code): Now static. Remove unused local.
7661 * tparam.h: New file.
7662 * term.c, tparam.h: Include it.
7663 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7664 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7665 Move these decls to tparam.h, and make them agree with what
7666 is actually in tparam.c. The previous trick of using incompatible
7667 decls in different modules does not conform to the C standard.
7668 All callers of tparam changed to use tparam's actual API.
7669 * tparam.c (tparam1, tparam, tgoto):
7670 Use const pointers where appropriate.
7672 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7673 * cm.h (struct cm): Likewise.
7674 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7675 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7676 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7677 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7678 (turn_on_face, init_tty): Likewise.
7679 * termchar.h (struct tty_display_info): Likewise.
7681 * term.c (term_mouse_position): Rename local to avoid shadowing.
7683 * alloc.c (mark_ttys): Move decl from here ...
7684 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7686 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7688 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7690 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7692 * search.c (compile_pattern_1): Remove argument regp, unused since
7693 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7694 (compile_pattern): Don't pass it.
7696 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7698 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7699 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7701 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7703 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7705 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7706 gdk_window_get_screen, gdk_window_get_geometry,
7707 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7708 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7709 (xg_get_pixbuf_from_pixmap): New function.
7710 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7711 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7712 Call xg_get_pixbuf_from_pixmap instead of
7713 gdk_pixbuf_get_from_drawable.
7714 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7715 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7716 (xg_check_special_colors): Use GtkStyleContext and its functions
7718 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7719 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7720 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7721 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7722 Call gtk_widget_get_preferred_size.
7723 (xg_frame_resized): gdk_window_get_geometry only takes 5
7725 (xg_win_to_widget, xg_event_is_for_menubar):
7726 Call gdk_x11_window_lookup_for_display.
7727 (xg_set_widget_bg): New function.
7728 (delete_cb): New function.
7729 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7730 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7731 (xg_set_background_color): Call xg_set_widget_bg.
7732 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7733 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7734 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7735 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7737 (update_frame_tool_bar): Call gtk_widget_hide.
7738 (xg_initialize): Use GDK_KEY_g.
7740 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7742 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7744 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7745 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7746 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7748 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7750 * w32xfns.c (select_palette): Check success of RealizePalette against
7751 GDI_ERROR, not zero.
7753 See ChangeLog.11 for earlier changes.
7759 Copyright (C) 2011 Free Software Foundation, Inc.
7761 This file is part of GNU Emacs.
7763 GNU Emacs is free software: you can redistribute it and/or modify
7764 it under the terms of the GNU General Public License as published by
7765 the Free Software Foundation, either version 3 of the License, or
7766 (at your option) any later version.
7768 GNU Emacs is distributed in the hope that it will be useful,
7769 but WITHOUT ANY WARRANTY; without even the implied warranty of
7770 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7771 GNU General Public License for more details.
7773 You should have received a copy of the GNU General Public License
7774 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.