1 2011-10-19 Eli Zaretskii <eliz@gnu.org>
3 * xdisp.c (start_display): If the character at POS is displayed
4 via a display vector, reset IT->current.dpvec_index to zero.
7 2011-10-18 Chong Yidong <cyd@gnu.org>
9 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
10 with nobreak-char-display too.
12 2011-10-18 Eli Zaretskii <eliz@gnu.org>
14 Fix part 3 of bug#9771.
15 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
16 (bidi_resolve_neutral): Don't enter the expensive loop looking for
17 non-neutral characters if the current character is a paragraph
18 separator (a.k.a. Newline). This avoids running the same
19 expensive loop twice, once when we consume the preceding newline
20 and the other time when the line actually needs to be displayed.
21 Avoid the loop when we see neutrals on the base embedding level
22 following a character whose directionality is the same as the
23 paragraph's. This avoids running the expensive loop when a line
24 ends in a long sequence of neutrals, like control characters.
25 Add assertion against STRONG_AL type. Slightly rearrange code
26 that determines the type of a neutral given the first non-neutral
28 (bidi_level_of_next_char): Set next_en_pos to zero when
29 invalidating its info.
31 2011-10-17 Eli Zaretskii <eliz@gnu.org>
33 * xdisp.c (push_display_prop): Determine whether to record string
34 or buffer position by IT->string, not by IT->method. Allow
35 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
36 (move_it_vertically_backward): Don't look for character position
37 immediately after the newline when in a continuation line.
40 2011-10-15 Martin Rudalics <rudalics@gmx.at>
42 * window.c (coordinates_in_window): Rewrite and delabelize
43 vertical border check. (Bug#5357) (Bug#9618)
45 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
47 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
48 errors in XSetWindowBorder (bug#9310).
50 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
52 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
53 avoid crash when xmalloc overrun checking is enabled.
55 2011-10-13 Eli Zaretskii <eliz@gnu.org>
57 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
58 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
59 cursor motion with <left> and <right> arrow keys.
61 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
62 some callers set that themselves.
64 2011-10-12 Eli Zaretskii <eliz@gnu.org>
66 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
67 display string and the previous row comes from the same string and
68 is empty. (Bug#9739) (Bug#9738)
70 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
72 * doc.c (get_doc_string): Encode file name (bug#9735).
74 2011-10-12 Eli Zaretskii <eliz@gnu.org>
76 * bidi.c (bidi_level_of_next_char):
77 * xdisp.c (get_visually_first_element): Remove old incorrect
78 comments regarding the Unicode Line Separator character.
80 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
82 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
84 * alloc.c (Fgc_status): Do not access beyond zombies array
85 boundary if nzombies > MAX_ZOMBIES.
86 * alloc.c (dump_zombies): Add missing format specifier.
88 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
90 * xdisp.c (set_cursor_from_row): Simplify conditionals,
91 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
93 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
94 Some packages use them to denote characters with modifiers.
96 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
98 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
99 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
100 matching a pp-number. Rename parameter var to var1.
102 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
104 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
106 2011-10-08 Glenn Morris <rgm@gnu.org>
108 * callint.c (Fcall_interactively): Give a more explicit error for the
109 'c' case with a non-character input. (Bug#8479)
111 2011-10-08 Eli Zaretskii <eliz@gnu.org>
113 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
115 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
116 lines that are hscrolled on the left.
118 * dispnew.c (buffer_posn_from_coords): Account for a possible
119 presence of header-line. (Bug#4426)
121 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
123 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
124 Don't advertise functionality which we discourage or doesn't work.
126 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
128 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
129 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
130 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
131 this makes Emacs dump core during garbage collection on rare
132 occasions. sizeof is obviously inferior to offsetof here, so
134 (GC_POINTER_ALIGNMENT): New macro.
135 (mark_memory): Omit 3rd (offset) arg; caller changed.
136 Don't assume EMACS_INT alignment is the same as pointer alignment.
138 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
140 * keyboard.c (read_key_sequence_remapped): New var.
141 (read_key_sequence): Compute remapping in the right buffer.
142 (command_loop_1): Use read_key_sequence's remapping directly.
144 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
146 * dired.c (file_name_completion): Don't expand file name.
147 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
148 before checking file name handler.
150 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
151 they've been requested explicitly (bug#9591).
153 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
155 * keymap.c (Fsingle_key_description): Use make_specified_string
156 instead of build_string to build string from push_key_description.
159 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
161 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
162 This fixes a Y2038 bug on 64-bit hosts.
163 * buffer.c (reset_buffer):
164 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
165 (Fclear_buffer_auto_save_failure):
166 Use 0, not -1, to represent an unset failure time, since time_t
169 Remove dependency on glibc malloc internals.
170 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
171 Move back here from lisp.h, but with their new implementations.
172 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
173 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
174 * charset.c (charset_table_init): New static var.
175 (syms_of_charset): Use it instead of xmalloc. This removes a
176 dependency on glibc malloc internals. See Eli Zaretskii's comment in
177 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
178 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
179 Move back to alloc.c.
180 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
181 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
183 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
185 * nsterm.m (windowDidResize): Call x_set_window_size only when
186 ns_in_resize is true. Otherwise set pixelwidth/height and
187 call change_frame_size (Bug#9628).
189 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
191 Port --enable-checking=all to Fedora 14 x86-64.
192 * charset.c (syms_of_charset): Also account for glibc malloc's
193 internal overhead when calculating the initial malloc maximum.
195 Port --enable-checking=all to Fedora 14 x86.
196 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
198 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
199 (overrun_check_realloc, overrun_check_free):
200 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
201 That way, xmalloc returns a properly-aligned pointer even if
202 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
203 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
204 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
205 into account when calculating the initial malloc maximum.
206 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
207 Move here from alloc.c, so that charset.c can use it too.
208 Properly align; the old code wasn't right for common 32-bit hosts
209 when configured with --enable-checking=all.
210 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
211 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
213 2011-09-29 Eli Zaretskii <eliz@gnu.org>
215 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
218 2011-09-28 Eli Zaretskii <eliz@gnu.org>
220 * xdisp.c (compute_display_string_end): If there's no display
221 string at CHARPOS, return -1.
223 * bidi.c (bidi_fetch_char): When compute_display_string_end
224 returns a negative value, treat the character as a normal
225 character not covered by a display string. (Bug#9624)
227 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
229 * lread.c (Fread_from_string): Fix typo in docstring.
231 2011-09-27 Eli Zaretskii <eliz@gnu.org>
233 * xdisp.c (handle_invisible_prop): If invisible text ends on a
234 newline, reseat the iterator instead of bidi-iterating there one
235 character at a time. (Bug#9610)
236 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
237 TO_CHARPOS if the bidi iterator is at base embedding level.
239 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
241 * lread.c (readevalloop): Use correct code for NBSP.
242 (read1): Likewise. (Bug#9608)
244 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
246 * dbusbind.c (Fdbus_register_signal): When service is not
247 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
249 2011-09-25 Glenn Morris <rgm@gnu.org>
251 * buffer.c (truncate-lines): Doc fix.
253 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
255 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
256 (Fset_window_next_buffers): Doc fix.
258 2011-09-24 Glenn Morris <rgm@gnu.org>
260 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
262 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
264 Fix minor problems found by static checking.
265 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
266 * indent.c (Fvertical_motion): Fix == vs = typo.
268 2011-09-24 Eli Zaretskii <eliz@gnu.org>
270 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
271 Default value is now t. Doc fix.
273 * indent.c (Fvertical_motion): Compute and apply the overshoot
274 logic when moving up, not only when moving down. Fix the
275 confusing name and values of the it_overshoot_expected variable;
276 logic changes accordingly. (Bug#9254) (Bug#9549)
278 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
279 CHARPOS is covered by a display string which includes newlines.
280 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
281 is covered by a display string with embedded newlines.
283 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
285 * dbusbind.c (Fdbus_register_signal): Add match rule to
286 Vdbus_registered_objects_table. (Bug#9581)
287 (Fdbus_register_method, Vdbus_registered_objects_table):
290 2011-09-24 Jim Meyering <meyering@redhat.com>
292 do not ignore write error for any output size
293 The previous change was incomplete.
294 While it makes emacs --batch detect the vast majority of stdout
295 write failures, errors were still ignored whenever the output size is
296 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
297 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
298 && echo FAIL: ignored write error
299 FAIL: ignored write error
300 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
301 && echo FAIL: ignored write error
302 FAIL: ignored write error
303 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
305 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
307 * emacs.c (Fkill_emacs): In noninteractive mode exit
308 non-successfully if a write error occurred on stdout. (Bug#9574)
310 2011-09-21 Eli Zaretskii <eliz@gnu.org>
312 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
315 * dispextern.h (struct it): Update the comment documenting what
318 2011-09-20 Eli Zaretskii <eliz@gnu.org>
320 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
321 a display string, extend search for cursor position to end of row.
322 (find_row_edges): If the row ends in a newline from a display
323 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
324 Handle the case of a display string with multiple newlines.
325 (Fcurrent_bidi_paragraph_direction): Fix search for previous
326 non-empty line. Fixes confusing cursor motion with arrow keys at
327 the beginning of a line that starts with whitespace.
329 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
331 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
334 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
336 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
339 2011-09-18 Eli Zaretskii <eliz@gnu.org>
341 * xdisp.c (display_line): Record maximum and minimum buffer
342 positions even if no glyphs were produced (e.g., by a zero-width
343 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
344 buffer positions that will be removed from the glyph row because
346 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
347 column is beyond frame width: don't subtract 1 "pixel" when
348 computing width of the stretch.
349 (reseat_at_next_visible_line_start): Undo the change made on
350 2011-09-17 that saved paragraph information and restored it after
351 the call to `reseat'. (Bug#9545)
353 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
355 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
356 and turn window cursor on if cleared (Bug#9415).
358 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
360 * search.c (boyer_moore): Take unibyte characters from pattern
361 literally. (Bug#9458)
363 2011-09-18 Eli Zaretskii <eliz@gnu.org>
365 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
367 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
369 Fix minor problem found by static checking.
370 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
371 initialized, to pacify gcc -Wuninitialized.
373 * fileio.c: Report proper errno when syscall falls.
374 (Finsert_file_contents): Save and restore errno,
375 so that report_file_error outputs the correct diagnostic.
376 (Fwrite_region) [CLASH_DETECTION]: Likewise.
378 2011-09-18 Eli Zaretskii <eliz@gnu.org>
380 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
382 2011-09-17 Eli Zaretskii <eliz@gnu.org>
384 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
385 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
387 2011-09-17 Eli Zaretskii <eliz@gnu.org>
389 * xdisp.c (reseat_at_next_visible_line_start): Keep information
390 about the current paragraph and restore it after the call to reseat.
392 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
393 (bidi_find_paragraph_start): Search back for paragraph beginning
394 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
395 (bidi_move_to_visually_next): Only trigger paragraph-related
396 computations when the last character is a newline or at EOB, not
397 just any NEUTRAL_B. (Bug#9470)
399 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
400 truncated lines if point is covered by a display string. (Bug#9524)
402 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
404 * xselect.c: Relax test for outgoing X longs (Bug#9498).
405 (cons_to_x_long): New function.
406 (lisp_data_to_selection_data): Use it. Correct the test for
407 short-versus-long data; it was negated. Break out of vector
408 loop, for efficiency, when a long datum is discovered.
410 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
412 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
414 2011-09-16 Eli Zaretskii <eliz@gnu.org>
416 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
417 GCC PR/17406) by declaring this function with external scope.
419 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
421 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
422 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
424 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
426 * editfns.c (Fformat): Correctly handle text properties on "%%".
428 2011-09-15 Eli Zaretskii <eliz@gnu.org>
430 * xterm.c (x_draw_composite_glyph_string_foreground):
431 * w32term.c (x_draw_composite_glyph_string_foreground):
432 * term.c (encode_terminal_code):
433 * composite.c (composition_update_it, get_composition_id):
434 * xdisp.c (get_next_display_element)
435 (fill_composite_glyph_string): Add comments about special meaning
436 of TAB characters in a composition.
438 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
440 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
441 This occurs when processing a multibyte format.
442 Problem reported by Wolfgang Jenker.
444 2011-09-15 Johan Bockgård <bojohan@gnu.org>
446 * xdisp.c (try_cursor_movement): Only check for exact match if
447 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
449 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
451 Remove unused external symbols.
452 * dispextern.h (calc_pixel_width_or_height): Remove decl.
453 * xdisp.c (calc_pixel_width_or_height): Now static.
454 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
455 * indent.c (check_display_width):
456 * w32term.c: Fix comment to match code.
457 * xterm.c, xterm.h (x_catching_errors): Remove.
459 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
461 * xselect.c: Use signed conversions more consistently (Bug#9498).
462 (selection_data_to_lisp_data): Assume incoming selection data are
463 signed integers, not unsigned. This is to be consistent with
464 outgoing selection data, which was modified to use signed integers
465 in as part of the fix to Bug#9196 in response to Jan D.'s comment
466 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
467 expects long, not unsigned long.
469 2011-09-14 Eli Zaretskii <eliz@gnu.org>
471 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
472 computation of loop end. Reported by Johan Bockgård
475 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
477 * frame.c (Fother_visible_frames_p): Function deleted.
479 2011-09-12 Eli Zaretskii <eliz@gnu.org>
481 * indent.c (compute_motion): Process display vector front to back
482 rather than the other way around. (Bug#2496)
484 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
486 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
488 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
490 * minibuf.c (Fread_from_minibuffer): Doc fix.
492 2011-09-11 Eli Zaretskii <eliz@gnu.org>
494 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
495 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
497 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
499 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
500 value for non-existent files.
502 2011-09-11 Eli Zaretskii <eliz@gnu.org>
504 * fileio.c (Finsert_file_contents): If the file cannot be opened,
505 set its "size" to -1. This will set the modtime_size field of
506 the corresponding buffer to -1, which is what
507 verify-visited-file-modtime expects for files that do not exist.
510 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
512 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
514 * lisp.h: ... from here. push_key_description is no longer
515 defined in keyboard.c, so its declaration should not be in
516 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
517 logically belongs with push_key_description.
519 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
521 * buffer.h: Include <sys/types.h> instead of <time.h>.
522 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
523 Problem reported by Herbert J. Skuhra.
525 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
527 * xml.c (parse_region): Make the parsing work for
528 non-comment-starting XML files again (bug#9144).
530 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
532 * image.c (gif_load): Fix calculation of bottom and right corner.
535 2011-09-10 Eli Zaretskii <eliz@gnu.org>
537 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
538 redisplay in small windows.
540 2011-09-09 Eli Zaretskii <eliz@gnu.org>
542 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
544 2011-09-08 Martin Rudalics <rudalics@gmx.at>
546 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
547 Operate on live windows only.
549 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
551 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
553 2011-09-07 Eli Zaretskii <eliz@gnu.org>
555 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
556 only under bidi iteration.
558 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
560 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
562 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
564 isnan: Fix porting problem to Solaris 10 with bundled gcc.
565 Without this fix, the command to link temacs failed due to an
566 undefined symbol __builtin_isnan. This is because
567 /usr/include/iso/math_c99.h #defines isnan(x) to
568 __builtin_isnan(x), but the bundled gcc, which identifies itself
569 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
571 * floatfns.c (isnan): #undef, and then #define to a clone of
573 (Fisnan): Always define, since it's always available now.
574 (syms_of_floatfns): Always define isnan at the Lisp level.
576 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
578 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
580 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
582 * fileio.c: Fix bugs with large file offsets (Bug#9428).
583 The previous code assumed that file offsets (off_t values) fit in
584 EMACS_INT variables, which is not true on typical 32-bit hosts.
585 The code messed up by falsely reporting buffer overflow in cases
586 such as (insert-file-contents "big" nil 1 2) into an empty buffer
587 when "big" contains more than 2**29 bytes, even though this
588 inserts just one byte and does not overflow the buffer.
589 (Finsert_file_contents): Store file offsets as off_t
590 values, not as EMACS_INT values. Check for overflow when
591 converting between EMACS_INT and off_t. When checking for
592 buffer overflow or for overlap, take the offsets into account.
593 Don't use EMACS_INT for small values where int suffices.
594 When checking for overlap, fix a typo: ZV was used where
595 ZV_BYTE was intended.
596 (Fwrite_region): Don't assume off_t fits into 'long'.
597 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
599 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
601 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
603 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
605 sprintf-related integer and memory overflow issues (Bug#9412).
607 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
608 (esprintf, exprintf, evxprintf): New functions.
609 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
610 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
611 (modify_event_symbol): Do not assume that the length of
612 name_alist_or_stem is safe to alloca and fits in int.
613 (Fexecute_extended_command): Likewise for function name and binding.
614 (Frecursion_depth): Wrap around reliably on integer overflow.
615 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
616 since some callers pass EMACS_INT values.
617 (Fsingle_key_description): Don't crash if symbol name contains more
618 than MAX_ALLOCA bytes.
619 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
620 (get_minibuffer): Arg is now EMACS_INT, not int.
621 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
622 (esprintf, exprintf, evxprintf): New decls.
623 * window.h (command_loop_level, minibuf_level): Reflect API changes.
625 * dbusbind.c (signature_cat): New function.
626 (xd_signature, Fdbus_register_signal):
627 Do not overrun buffer; instead, report string overflow.
629 * dispnew.c (add_window_display_history): Don't overrun buffer.
630 Truncate instead; this is OK since it's just a log.
632 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
633 even if the time zone offset is outlandishly large.
634 Don't mishandle offset == INT_MIN.
636 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
637 when creating daemon; the previous buffer-overflow check was incorrect.
639 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
640 which has the guts of the old verror function.
642 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
643 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
645 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
646 (font_unparse_xlfd): Don't blindly alloca long strings.
647 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
648 fits in int, when using sprintf. Use single snprintf to count
649 length of string rather than counting it via multiple sprintfs;
650 that's simpler and more reliable.
651 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
652 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
653 sprintf, in case result does not fit in int.
655 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
656 (fontset_from_font): Print it.
658 * frame.c (tty_frame_count): Now printmax_t, not int.
659 (make_terminal_frame, set_term_frame_name): Print it.
660 (x_report_frame_params): In X, window IDs are unsigned long,
661 not signed long, so print them as unsigned.
662 (validate_x_resource_name): Check for implausibly long names,
663 and don't assume name length fits in 'int'.
664 (x_get_resource_string): Don't blindly alloca invocation name;
665 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
668 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
669 (xg_check_special_colors, xg_set_geometry):
670 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
672 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
673 Use esprintf, not sprintf, in case result does not fit in int.
675 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
676 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
677 it as a large positive number.
678 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
679 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
681 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
682 in case result does not fit in int.
684 * print.c (float_to_string): Detect width overflow more reliably.
685 (print_object): Make sprintf buffer a bit bigger, to avoid potential
686 buffer overrun. Don't assume list length fits in 'int'. Treat
687 print length of 0 as 0, not as infinity; to be consistent with other
688 uses of print length in this function. Don't overflow print length
689 index. Don't assume hash table size fits in 'long', or that
690 vectorlike size fits in 'unsigned long'.
692 * process.c (make_process): Use printmax_t, not int, to format
693 process-name gensyms.
695 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
697 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
698 to avoid potential buffer overrun.
700 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
701 if X resource line is longer than 512 bytes.
703 * xfns.c (x_window): Make sprintf buffer a bit bigger
704 to avoid potential buffer overrun.
706 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
708 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
710 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
712 Integer overflow fixes for scrolling, etc.
713 Without these, Emacs silently mishandles large integers sometimes.
714 For example, "C-u 4294967297 M-x recenter" was treated as if
715 it were "C-u 1 M-x recenter" on a typical 64-bit host.
717 * xdisp.c (try_window_id): Check Emacs fixnum range before
720 * window.c (window_scroll_line_based, Frecenter):
721 Check that an Emacs fixnum is in range before assigning it to 'int'.
722 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
723 values converted from Emacs fixnums.
724 (Frecenter): Don't wrap around a line count if it is out of 'int'
725 range; instead, treat it as an extreme value.
726 (Fset_window_configuration, compare_window_configurations):
727 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
729 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
730 that can exceed INT_MAX. Check that EMACS_INT value is in range
731 before assigning it to the (possibly-narrower) index.
732 (match_limit): Don't assume that a fixnum can fit in 'int'.
734 * print.c (print_object): Use ptrdiff_t, not int, for index that can
737 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
738 (Fvertical_motion): Don't wrap around LINES values that don't fit
739 in 'int'. Instead, treat them as extreme values. This is good
740 enough for windows, which can't have more than INT_MAX lines anyway.
742 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
744 * Require libxml/parser.h to avoid compilation warning.
746 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
748 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
749 since this reportedly can destroy thread storage.
751 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
753 * syntax.c (find_defun_start): Update all cache variables if
754 exiting early (Bug#9401).
756 2011-08-30 Eli Zaretskii <eliz@gnu.org>
758 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
760 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
761 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
762 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
764 * term.c (tty_append_glyph): New function.
765 (produce_stretch_glyph): Static function and its prototype deleted.
767 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
770 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
772 * image.c (parse_image_spec): Check for nonnegative, not for positive,
773 when checking :margin (Bug#9390).
774 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
775 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
776 so that the name doesn't mislead. All uses changed.
778 2011-08-28 Johan Bockgård <bojohan@gnu.org>
780 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
783 2011-08-27 Eli Zaretskii <eliz@gnu.org>
785 * xdisp.c (move_it_to): Don't bail out early when reaching
786 position beyond to_charpos, if we are scanning backwards.
787 (move_it_vertically_backward): When DY == 0, make sure we get to
788 the first character in the line after the newline.
790 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
792 * ccl.c: Improve and simplify overflow checking (Bug#9196).
793 (ccl_driver): Do not generate an out-of-range pointer.
794 (Fccl_execute_on_string): Remove unnecessary check for
795 integer overflow, noted by Stefan Monnier in
796 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
797 Remove a FIXME that didn't need fixing.
798 Simplify the newly-introduced buffer reallocation code.
800 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
802 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
804 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
806 Integer and memory overflow issues (Bug#9196).
808 * doc.c (get_doc_string): Rework so that
809 get_doc_string_buffer_size is the actual buffer size, rather than
810 being 1 less than the actual buffer size; this makes xpalloc more
813 * image.c (x_allocate_bitmap_record, cache_image):
814 * xselect.c (Fx_register_dnd_atom):
815 Simplify previous changes by using xpalloc.
817 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
818 since either will do and ptrdiff_t is convenient with xpalloc.
820 * charset.c (charset_table_size)
821 (struct charset_sort_data.priority): Now ptrdiff_t.
822 (charset_compare): Don't overflow if priorities differ greatly.
823 (Fsort_charsets): Don't assume list length fits in int.
824 Check for size-calculation overflow when allocating sort data.
825 (syms_of_charset): Allocate an initial charset table that is
826 just under 64 KiB, to avoid problems with glibc malloc and mmap.
828 * cmds.c (internal_self_insert): Check for size-calculation overflow.
830 * composite.h (struct composition.glyph_len): Now int, not unsigned.
831 The actual value is always <= INT_MAX, and leaving it unsigned made
832 overflow checking harder.
834 * dispextern.h (struct glyph_matrix.rows_allocated)
835 (struct face_cache.size): Now ptrdiff_t, for convenience in use
836 with xpalloc. The values are still always <= INT_MAX.
838 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
840 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
841 (SAFE_NALLOCA): New macro.
843 * region-cache.c (struct boundary.pos, find_cache_boundary)
844 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
845 (set_cache_region, invalidate_region_cache)
846 (revalidate_region_cache, know_region_cache, region_cache_forward)
847 (region_cache_backward, pp_cache):
848 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
849 so that ptrdiff_t * can be passed to xpalloc.
850 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
851 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
852 (pp_cache): Don't assume cache_len fits in int.
853 * region-cache.h: Adjust extern decls to match.
855 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
856 EMACS_INT, since either will do, for xpalloc.
858 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
859 (xnmalloc, xnrealloc, xpalloc): New functions.
861 * bidi.c (bidi_shelve_header_size): New constant.
862 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
863 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
865 * bidi.c (bidi_cache_shrink):
866 * buffer.c (overlays_at, overlays_in, record_overlay_string)
868 Don't update size of array until after memory allocation succeeds,
869 because xmalloc/xrealloc may not return.
870 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
871 now that we have proper integer overflow checking.
872 (record_overlay_string, overlay_strings): Catch overflows when
873 calculating size of overlay_str_buf.
875 * callproc.c (Fcall_process): Check for size overflow when
876 calculating size of args2.
877 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
878 Normally we prefer signed values, but sticking with ptrdiff_t would
879 require adding more-complicated checks.
881 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
882 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
883 Redo buffer-overflow calculations to avoid integer overflow.
884 Add a FIXME comment where memory seems to be over-allocated.
886 * character.c (Fstring): Check for size-calculation overflow.
888 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
889 unnecessary integer overflow. Check for size overflow.
890 (encode_coding_object): Don't update size until xmalloc succeeds.
892 * composite.c (get_composition_id): Check for overflow in glyph
895 Integer and memory overflow fixes for display code.
896 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
897 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
898 (scrolling_window): Check for overflow in size calculations.
899 (line_draw_cost, realloc_glyph_pool, add_row_entry):
900 Don't assume glyph table len fits in int.
901 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
902 (row_table_size): Now ptrdiff_t, not int.
903 (scrolling_window): Avoid overflow in size calculations.
904 Don't update size until allocation succeeds.
905 * fns.c (concat): Check for overflow in size calculations.
906 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
907 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
908 (NEXT_ALMOST_PRIME_LIMIT): New constant.
910 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
911 (get_doc_string): Check for size calculation overflow.
912 Don't update size until allocation succeeds.
913 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
914 EMACS_INT, where ptrdiff_t will do.
915 (Fsubstitute_command_keys): Check for string overflow.
917 * editfns.c (set_time_zone_rule): Don't assume environment length
919 (message_length): Now ptrdiff_t, not int.
920 (Fmessage_box): Don't update size until allocation succeeds.
921 Don't assume message length fits in int.
922 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
924 * emacs.c (main): Do not reallocate argv, since there is a null at
925 the end that can be overwritten, and this way there's no need to
926 worry about size-calculation overflow.
927 (sort_args): Check for size-calculation overflow.
929 * eval.c (init_eval_once, grow_specpdl): Don't update size until
931 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
933 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
934 (x_set_scroll_bar_width, x_figure_window_size):
935 Check for integer overflow.
936 (x_set_alpha): Do not assume XINT fits in int.
938 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
939 This is for the members text_lines, text_cols, total_lines, total_cols,
940 where the system imposes an 'int' limit.
942 * fringe.c (Fdefine_fringe_bitmap):
943 Don't update size until alloc works.
945 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
946 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
948 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
949 Check for size-calculation overflow.
950 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
951 do, as we prefer signed integers.
952 (id_to_widget.max_size, id_to_widget.used)
953 (xg_store_widget_in_map, xg_remove_widget_from_map)
954 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
955 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
956 Use and return ptrdiff_t, not int.
957 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
958 * gtkutil.h: Change prototypes to match the above.
960 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
961 are duplicate now that they've been promoted to lisp.h.
962 (x_allocate_bitmap_record, x_alloc_image_color)
963 (make_image_cache, cache_image, xpm_load):
964 Don't update size until alloc is done.
965 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
967 Check for size calculation overflow.
968 (ct_colors_allocated_max): New constant.
969 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
972 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
973 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
974 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
975 Use ptrdiff_t, not int, to count maps.
976 (read_char_minibuf_menu_prompt): Check for overflow in size
977 calculations. Don't update size until allocation succeeds.
978 Redo calculations to avoid overflow.
979 * keyboard.h: Change prototypes to match the above.
981 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
983 (current_minor_maps): Check for size calculation overflow.
984 * keymap.h: Change prototypes to match the above.
986 * lread.c (read1, init_obarray): Don't update size until alloc done.
988 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
989 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
991 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
992 Now ptrdiff_t, not int.
993 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
994 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
996 * process.c (Fnetwork_interface_list): Check for overflow
999 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1001 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1002 overflow. Don't bother calling xmalloc when xrealloc will do.
1004 * search.c (Freplace_match): Check for size calculation overflow.
1005 (Fset_match_data): Don't assume list lengths fit in 'int'.
1007 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1008 for command line length. Do not attempt to address one before the
1009 beginning of an array, as that's not portable.
1011 * term.c (max_frame_lines): Remove; unused.
1012 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1014 (encode_terminal_code, calculate_costs): Check for size
1015 calculation overflow.
1016 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1017 table lengths and related sizes. Don't update size until alloc
1018 done. Redo calculations to avoid overflow.
1019 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1021 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1022 subtracting pointers.
1023 (gobble_line): Check for overflow more carefully. Don't update size
1026 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1027 Don't update size until alloc done.
1028 Redo size calculations to avoid overflow.
1029 Check for size calculation overflow.
1030 (main) [DEBUG]: Fix typo in invoking tparam1.
1032 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1033 Use ptrdiff_t, not int, for sizes.
1034 (store_mode_line_noprop_char): Don't update size until alloc done.
1036 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1037 Use ptrdiff_t, not int, for sizes.
1038 (Finternal_make_lisp_face, cache_face):
1039 Check for size calculation overflow.
1040 (cache_face): Treat size calculation overflows as if they were
1041 memory exhaustion (the usual treatment), rather than aborting.
1043 * xfns.c (x_encode_text, x_set_name_internal)
1044 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1045 sizes, since they can exceed INT_MAX in size. Check for size
1046 calculation overflow.
1048 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1049 (xg_select): Check for size calculation overflow.
1050 Don't update size until alloc done.
1052 * xrdb.c (get_environ_db): Don't assume path length fits in int,
1053 as sprintf is limited to int lengths.
1055 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1056 (X_LONG_MIN): New macros.
1057 Use them to make the following changes clearer.
1058 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1059 This change doesn't affect the value now, but it may help remind
1060 future maintainers not to raise the value too much later.
1061 (SELECTION_QUANTUM): Remove, replacing with ...
1062 (selection_quantum): ... new function, which avoids overflow.
1064 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1065 assumption that selection length fits in 'int'.
1066 (x_reply_selection_request, x_handle_selection_request)
1067 (x_get_window_property, receive_incremental_selection)
1068 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1069 (lisp_data_to_selection_data, clean_local_selection_data):
1070 Use ptrdiff_t, not int, to record length of selection.
1071 (x_reply_selection_request, x_get_window_property)
1072 (receive_incremental_selection, x_property_data_to_lisp):
1073 Redo calculations to avoid overflow.
1074 (x_reply_selection_request): When sending hint, ceiling it at
1075 X_LONG_MAX rather than relying on wraparound overflow to send
1077 (x_get_window_property, receive_incremental_selection)
1078 (lisp_data_to_selection_data, x_property_data_to_lisp):
1079 Check for size-calculation overflow.
1080 (x_get_window_property, receive_incremental_selection)
1081 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1082 Don't store size until memory allocation succeeds.
1083 (x_get_window_property): Plug memory leak on memory exhaustion.
1084 Don't double-block input; malloc is safe here. Don't assume 2**34
1085 - 4 fits in unsigned long. Add an xassert to check
1086 XGetWindowProperty overflow. Be more careful about overflow
1087 calculations, and distinguish size from memory overflow better.
1088 (receive_incremental_selection): When tracing, don't assume
1089 unsigned int is less than INT_MAX.
1090 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1091 harmful) conversions of unsigned short to int.
1092 (lisp_data_to_selection_data): Don't assume that integers
1093 in the range -65535 through -1 fit in an X unsigned short.
1094 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1095 result parameters unless successful. Rely on cons_to_unsigned
1096 to report problems with elements; the old code wasn't right anyway.
1097 (x_check_property_data): Check for int overflow; we cannot use
1098 a wider type due to X limits.
1099 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1101 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
1103 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1104 (x_term_init): Check for size calculation overflow.
1105 (x_color_cells): Don't store size until memory allocation succeeds.
1106 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
1107 Don't assume alloca size is less than MAX_ALLOCA.
1108 (x_term_init): Don't assume length fits in int (sprintf is limited
1111 Use ptrdiff_t for composition IDs.
1112 * character.c (lisp_string_width):
1113 * composite.c (composition_table_size, n_compositions)
1114 (get_composition_id, composition_gstring_from_id):
1115 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1116 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1117 * window.c (Frecenter):
1118 Use ptrdiff_t, not int, for composition IDs.
1119 * composite.c (get_composition_id): Check for integer overflow.
1120 * composite.h: Adjust prototypes to match the above changes.
1122 Use ptrdiff_t for hash table indexes.
1123 * category.c (hash_get_category_set):
1124 * ccl.c (ccl_driver):
1125 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1126 * coding.c (coding_system_charset_list, detect_coding_system):
1127 * coding.h (struct coding_system.id):
1128 * composite.c (get_composition_id, gstring_lookup_cache):
1129 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1130 * image.c (xpm_get_color_table_h):
1131 * lisp.h (hash_lookup, hash_put):
1132 * minibuf.c (Ftest_completion):
1133 Use ptrdiff_t for hash table indexes, not int (which is too
1134 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1135 32-bit --with-wide-int hosts).
1137 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1138 Add a FIXME comment about memory leaks.
1139 (syms_of_charset): Don't assume xmalloc returns.
1141 Don't assume that stated character widths fit in int.
1142 * character.c (Fchar_width, c_string_width, lisp_string_width):
1143 * character.h (CHAR_WIDTH):
1144 * indent.c (MULTIBYTE_BYTES_WIDTH):
1145 Use sanitize_char_width to avoid undefined and/or bad behavior
1146 with outlandish widths.
1147 * character.h (sanitize_tab_width): Rename from sanitize_width,
1148 now that we have two such functions. All uses changed.
1149 (sanitize_char_width): New inline function.
1151 Don't assume that tab-width fits in int.
1152 * character.h (sanitize_width): New inline function.
1153 (SANE_TAB_WIDTH): New macro.
1154 (ASCII_CHAR_WIDTH): Use it.
1155 * indent.c (sane_tab_width): Remove. All uses replaced by
1156 SANE_TAB_WIDTH (current_buffer).
1157 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1159 * fileio.c: Integer overflow issues with file modes.
1160 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1162 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1163 Remove unreachable code.
1164 (read_hex, load_charset_map_from_file): Check for integer overflow.
1166 * xterm.c: don't go over XClientMessageEvent limit
1167 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1168 (x_send_scroll_bar_event): Likewise. Check that the size does not
1169 exceed limits imposed by XClientMessageEvent, as well as the usual
1170 ptrdiff_t and size_t limits.
1172 * keyboard.c: Overflow, signedness and related fixes.
1173 (make_lispy_movement): Use same integer type in forward decl
1174 that is used in the definition.
1175 (read_key_sequence, keyremap_step):
1176 Change bufsize argument back to int, undoing my 2011-03-30 change.
1177 We prefer signed types, and int is wide enough here.
1178 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1179 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1180 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1181 length, not size_t. Use ptrdiff_t for index, not int.
1182 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1183 possibility of integer overflow.
1185 Overflow, signedness and related fixes for images.
1187 * dispextern.h (struct it.stack[0].u.image.image_id)
1188 (struct_it.image_id, struct image.id, struct image_cache.size)
1189 (struct image_cache.used, struct image_cache.ref_count):
1190 * gtkutil.c (update_frame_tool_bar):
1191 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1192 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1193 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1194 * nsmenu.m (update_frame_tool_bar):
1195 * xdisp.c (calc_pixel_width_or_height):
1196 * xfns.c (image_cache_refcount):
1197 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1198 on typical 64-bit hosts.
1200 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1201 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1202 Omit unnecessary casts to int.
1203 (parse_image_spec): Check that integers fall into 'int' range
1204 when the callers expect that.
1205 (image_ascent): Redo ascent calculation to avoid int overflow.
1206 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1207 (lookup_image): Remove unnecessary tests.
1208 (xbm_image_p): Locals are now of int, not EMACS_INT,
1209 since parse_image_check makes sure they fit into int.
1210 (png_load, gif_load, svg_load_image):
1211 Prefer int to unsigned where either will do.
1212 (tiff_handler): New function, combining the cores of the
1213 old tiff_error_handler and tiff_warning_handler.
1214 This function is rewritten to use vsnprintf and thereby avoid
1215 stack buffer overflows. It uses only the features of vsnprintf
1216 that are common to both POSIX and native Microsoft.
1217 (tiff_error_handler, tiff_warning_handler): Use it.
1218 (tiff_load, gif_load, imagemagick_load_image):
1219 Don't assume :index value fits in 'int'.
1220 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1221 (imagemagick_load_image): Check that crop parameters fit into
1222 the integer types that MagickCropImage accepts. Don't assume
1223 Vimagemagick_render_type has a nonnegative value. Don't assume
1224 size_t fits in 'long'.
1225 (gs_load): Use printmax_t to print the widest integers possible.
1226 Check for integer overflow when computing image height and width.
1228 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1230 * xdisp.c (redisplay_window): Don't force window start if point
1231 will be invisible in the resulting window. (Bug#9324)
1233 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1235 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1236 the display spec is of the form `(space ...)'.
1237 (handle_display_spec): Return the value returned by
1238 handle_single_display_spec, not just 1 or zero.
1239 (handle_single_display_spec): If the display spec is of the form
1240 `(space ...)', and specifies display in the text area, return 2
1242 (try_cursor_movement): Check for the need to scroll more
1243 accurately, and prefer exact match for point under bidi.
1244 Don't advance `row' beyond the last row of the window.
1246 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1247 into disp_prop; all users changed.
1249 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1250 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1251 for the text covered by the display property.
1253 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1255 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1256 Change return value to nil.
1257 (Frecord_buffer): Delete unused function.
1259 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1261 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1262 buffers, return left-to-right.
1263 (set_cursor_from_row): Consider candidate row a win if its glyph
1264 represents a newline and point is on that newline. Fixes cursor
1265 positioning on the newline at EOL of R2L text within L2R
1266 paragraph, and vice versa.
1267 (try_cursor_movement): Check continued rows, in addition to
1268 continuation rows. Fixes unwarranted scroll when point enters a
1269 continued line of R2L text within an L2R paragraph, or vice versa.
1270 (cursor_row_p): Consider the case of point being equal to
1271 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1272 from the end of a short line to the beginning of a continued line
1273 of R2L text within L2R paragraph.
1274 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1275 composed characters.
1277 * bidi.c (bidi_check_type): Use xassert.
1278 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1281 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1283 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1286 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1288 * nsfont.m (ns_otf_to_script): Fix typo.
1290 2011-08-22 Kenichi Handa <handa@m17n.org>
1292 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1293 extra slot even if the purpose is char-code-property-table.
1295 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1297 * xdisp.c (redisplay_window): When computing centering_position,
1298 account for the height of the header line. (Bug#8874)
1300 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1301 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1302 candidate is selected by the mouse, and that candidate has a
1303 composed character under the mouse.
1305 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1306 coordinates reported by pos-visible-in-window-p for a composed
1307 character in column zero.
1309 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1311 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1313 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1315 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1316 consider it a hit if to_charpos is anywhere in the range of the
1317 composed buffer positions.
1319 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1321 * image.c (gif_load): Don't assume that each subimage has the same
1322 dimensions as the base image. Handle disposal method that is
1323 "undefined" by the gif spec (Bug#9335).
1325 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1327 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1328 (Fcondition_case): Document `debug' symbol in error handler.
1330 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1332 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1333 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1334 from an Org mode buffer to a Speedbar frame.
1336 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1337 a composition, take its buffer position from IT->cmp_it.charpos.
1338 Fixes cursor positioning at the beginning of a line that begins
1339 with a composed character.
1341 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1343 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1344 character bidirectional type, use STRONG_L instead. Fixes crashes
1345 in a buffer produced by `describe-categories'.
1347 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1348 members before the level stack, so they would be saved and
1349 restored when copying iterator state. Fixes incorrect reordering
1350 around TABs covered by display properties.
1352 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1354 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
1356 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1358 * eval.c (internal_condition_case, internal_condition_case_1)
1359 (internal_condition_case_2, internal_condition_case_n):
1360 Remove unnecessary aborts (Bug#9081).
1362 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1364 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1365 has no `load' handler, try opening the file locally. (Bug#9311)
1367 2011-08-16 Ken Brown <kbrown@cornell.edu>
1369 * gmalloc.c: Expand comment.
1371 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1373 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1374 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1376 2011-08-16 Ken Brown <kbrown@cornell.edu>
1378 Fix memory allocation problems in Cygwin build (Bug#9273).
1380 * unexcw.c ( __malloc_initialized): Declare external variable.
1381 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1383 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1385 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1387 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1389 [CYGWIN] (special_realloc): New function.
1390 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1391 requests to realloc storage in the static heap.
1393 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1395 * bidi.c (bidi_initialize): Remove unused local.
1397 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1400 * biditype.h: Remove file.
1401 * makefile.w32-in ($(BLD)/bidi.$(O)):
1402 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
1404 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1406 * chartab.c: Improve commentary for the uniprop_table API.
1408 * bidi.c (bidi_paragraph_init): Support zero value of
1409 bidi_ignore_explicit_marks_for_paragraph_level.
1410 (bidi_initialize): Use uniprop_table instead of including
1411 biditype.h and bidimirror.h.
1413 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1414 coordinates of the iterator when restoring from ppos_it.
1417 2011-08-14 Kenichi Handa <handa@m17n.org>
1419 * process.c (create_process): Call setup_process_coding_systems
1420 after the pid of the process is set to -1 (Bug#8162).
1422 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1424 * xdisp.c (move_it_in_display_line_to): Don't invoke
1425 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1426 ppos_it. Fixes vertical cursor motion when line beginning is
1427 covered by an image. (Bug#9296)
1429 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1431 * nsterm.h (ns_run_ascript): Declare.
1432 (NSAPP_DATA2_RUNASSCRIPT): Define.
1434 * nsfns.m (as_script, as_result, as_status): New static variables.
1435 (ns_run_ascript): New function.
1436 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1437 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1438 the event loop. Get status from as_status (Bug#7276).
1440 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1441 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1442 the event loop (Bug#7276).
1444 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1446 * gnutls.c (QCgnutls_bootprop_priority)
1447 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1448 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1449 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1450 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1451 (QCgnutls_bootprop_verify_hostname_error)
1452 (QCgnutls_bootprop_callbacks_verify): Rename from
1453 Qgnutls_bootprop_..., all uses changed.
1455 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1458 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1460 * xfaces.c (Qframe_set_background_mode): Now static.
1461 * dispextern.h (Qframe_set_background_mode): Remove decl.
1463 * process.c (Fnetwork_interface_info): Declare local only if needed.
1465 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1467 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1468 (Fnetwork_interface_list): Allocate in increments of bytes instead
1469 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1470 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1472 (struct ifflag_def): notrailers is smart on OSX.
1473 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1474 Get hardware address with getifaddrs if available.
1476 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1478 * xdisp.c (iterate_out_of_display_property): xassert that
1479 IT->position is set to within IT->object's boundaries. Break from
1480 the loop as soon as EOB is reached; avoids infloops in redisplay
1481 when IT->position is set up wrongly due to some bug.
1482 Set IT->current to match the bidi iterator unconditionally.
1483 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1484 entry. Force push_it to save on the stack the current
1485 buffer/string position, to be restored by pop_it. Fix flags in
1486 the iterator structure wrt the object coming from a display
1487 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1488 properties. (Bug#9284)
1490 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1492 * fontset.c (fontset_get_font_group): Add proper type checks.
1495 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1497 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1498 and LC_VERSION_MIN_MACOSX.
1499 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1500 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1502 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1504 * xdisp.c (forward_to_next_line_start): Allow to use the
1505 no-display-properties-and-no-overlays under bidi display.
1506 Set disp_pos in the bidi iterator to avoid searches for display
1507 properties and overlays.
1509 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1511 * editfns.c (Fset_time_zone_rule): Document relationship with the
1514 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1515 the font entity extracted from the cache (Bug#8109).
1517 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1519 * composite.c (autocmp_chars): Don't reset point. That is done by
1520 restore_point_unwind (Bug#5984).
1522 2011-08-07 Juri Linkov <juri@jurta.org>
1524 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1525 to show the arg `TIME' instead of `TIMEVAL'.
1527 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1529 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1530 display property strides EOL and includes a newline, as in
1531 longlines-mode. (Bug#9254)
1532 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1533 word-wrap under bidirectional display. (Bug#9224)
1535 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1536 is non-zero, even if the data buffer is NULL. Fixes a crash in
1537 vertical-motion with longlines-mode. (Bug#9254)
1539 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1541 * bidi.c <bidi_cache_total_alloc>: Now static.
1542 (bidi_initialize): Initialize bidi_cache_total_alloc.
1544 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1547 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1548 amount allocated this far in `bidi_cache_total_alloc'.
1549 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1550 non-zero, only free the data buffer without restoring the cache
1551 contents. All callers changed.
1553 * dispextern.h (bidi_unshelve_cache): Update prototype.
1555 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1556 (move_it_in_display_line, move_it_to)
1557 (move_it_vertically_backward, move_it_by_lines): Replace the call
1558 to xfree to an equivalent call to bidi_unshelve_cache.
1559 (move_it_in_display_line_to): Fix logic of returning
1560 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1562 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1564 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1565 came from a string character with a `cursor' property. (Bug#9229)
1567 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1569 * Makefile.in (LIB_PTHREAD): New variable.
1570 (LIBES): Add LIB_PTHREAD (Bug#9216).
1572 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1573 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1575 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1577 * regex.c (re_iswctype): Remove some redundant boolean conversions.
1579 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1581 * xterm.c (x_find_topmost_parent): New function.
1582 (x_set_frame_alpha): Find topmost parent window with
1583 x_find_topmost_parent and set the property there also (bug#9181).
1584 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1586 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1588 * callproc.c (Fcall_process): Avoid vfork clobbering
1589 the local vars buffer, coding_systems, current_dir.
1591 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1593 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1595 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1597 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1598 so that it is not optimized away.
1600 * xdisp.c (compute_display_string_pos): Remove unused local.
1602 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1604 Fix slow cursor motion and scrolling in large buffers with
1605 selective display, like Org Mode buffers. (Bug#9218)
1607 * dispextern.h (struct bidi_it): New member disp_prop_p.
1609 * xdisp.c: Remove one-slot cache of display string positions.
1610 (compute_display_string_pos): Accept an additional argument
1611 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1612 for a display string or property. If found, set DISP_PROP_P
1615 * bidi.c (bidi_fetch_char): Accept an additional argument
1616 DISP_PROP_P, and pass it to compute_display_string_pos.
1617 Only handle text covered by a display string if DISP_PROP_P is returned
1618 non-zero. All callers of bidi_fetch_char changed.
1620 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1622 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1624 2010-12-03 Don March <don@ohspite.net>
1626 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1627 last character M-[char] is translated to ESC [char] (bug#7541).
1629 2011-08-02 Kenichi Handa <handa@m17n.org>
1631 * lisp.h (uniprop_table): Extern it.
1633 * chartab.c (uniprop_table): Make it non-static.
1635 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1637 * xdisp.c (forward_to_next_line_start): Accept additional argument
1638 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1640 (reseat_at_next_visible_line_start): Use the bidi iterator state
1641 returned by forward_to_next_line_start to restore the state of
1642 it->bidi_it after backing up to previous newline. (Bug#9212)
1644 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1646 * regex.c (re_comp): Protoize.
1647 (re_exec): Fix return type.
1648 (regexec): Fix type of `ret'. (Bug#9203)
1650 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1652 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1653 This is needed if max-image-size is a floating-point number.
1655 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1657 * print.c (print_object): Print empty symbol as ##.
1659 * lread.c (read1): Read ## as empty symbol.
1661 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1663 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1664 setting frame foreground color (Bug#9175).
1665 (x_set_background_color): Likewise.
1667 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1668 contents (Bug#9176).
1669 (EmacsTooltip -init): Remove bezels and add shadows to
1672 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1673 or scroll bar (Bug#8470).
1675 * nsfont.m (nsfont_open): Remove assignment to voffset and
1676 unnecessary vars hshink, expand, hd, full_height, min_height.
1677 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1679 * nsterm.h (nsfont_info): Remove voffset field.
1681 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1683 Implement strike-through and overline on NextStep (Bug#8863).
1685 * nsfont.m (nsfont_open): Use underline position provided by font,
1686 instead of hard-coded value of 2.
1687 (nsfont_draw): Call ns_draw_text_decoration instead.
1689 * nsterm.h: Add declaration for ns_draw_text_decoration.
1691 * nsterm.m (ns_draw_text_decoration): New function for drawing
1692 underline, overline, and strike-through.
1693 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1694 ns_draw_text_decoration. Change treatment of cursor drawing to
1695 accommodate underlining, etc.
1697 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1699 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1702 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1704 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1705 Without this fix, if a signal arrives just after memory fills up,
1706 'malloc' might be invoked reentrantly.
1708 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1709 In other words, assume that every image size is allowed, on non-X
1710 hosts. This assumption is probably wrong, but it lets Emacs compile.
1712 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1714 * regex.c (re_iswctype): Convert return values to boolean.
1716 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1718 * xdisp.c (compute_display_string_pos): Don't use cached display
1719 string position if the buffer had its restriction changed.
1722 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1724 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1726 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1728 Integer signedness and overflow and related fixes. (Bug#9079)
1730 * bidi.c: Integer size and overflow fixes.
1731 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1732 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1733 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1734 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1735 (bidi_find_other_level_edge):
1736 Use ptrdiff_t instead of EMACS_INT where either will do.
1737 This works better on 32-bit hosts configured --with-wide-int.
1738 (bidi_cache_ensure_space): Check for size-calculation overflow.
1739 Use % rather than repeated addition, for better worst-case speed.
1740 Don't set bidi_cache_size until after xrealloc returns, because it
1742 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1743 (bidi_cache_ensure_space): Also check that the bidi cache size
1744 does not exceed that of the largest Lisp string or buffer. See Eli
1745 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1747 * alloc.c (__malloc_size_t): Remove.
1748 All uses replaced by size_t. See Andreas Schwab's note
1749 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1751 * image.c: Improve checking for integer overflow.
1752 (check_image_size): Assume that f is nonnull, since
1753 it is always nonnull in practice. This is one less thing to
1754 worry about when checking for integer overflow later.
1755 (x_check_image_size): New function, which checks for integer
1756 overflow issues inside X.
1757 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1758 This removes the need for a memory_full check.
1759 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1760 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1761 (xbm_read_bitmap_data): Change locals back to 'int', since
1762 their values must fit in 'int'.
1763 (xpm_load_image, png_load, tiff_load):
1764 Invoke x_create_x_image_and_pixmap earlier,
1765 to avoid much needless work if the image is too large.
1766 (tiff_load): Treat overly large images as if
1767 x_create_x_image_and_pixmap failed, not as malloc failures.
1768 (gs_load): Use x_check_image_size.
1770 * gtkutil.c: Omit integer casts.
1771 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1772 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1774 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1776 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1777 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1778 would wrongly return t on a 64-bit host.
1780 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1781 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1782 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1783 and therefore cause GCC to emit a bogus diagnostic in some cases.
1785 * image.c: Integer signedness and overflow and related fixes.
1786 This is not an exhaustive set of fixes, but it's time to
1787 record what I've got.
1788 (lookup_pixel_color, check_image_size): Remove redundant decls.
1789 (check_image_size): Don't assume that arbitrary EMACS_INT values
1790 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1791 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1792 (tiff_load, imagemagick_load_image):
1793 Check for overflow in size calculations.
1794 (x_create_x_image_and_pixmap): Remove unnecessary test for
1795 xmalloc returning NULL; that can't happen.
1796 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1797 (xpm_color_bucket): Use better integer hashing function.
1798 (xpm_cache_color): Don't possibly over-allocate memory.
1799 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1800 (gif_memory_source):
1801 Use ptrdiff_t, not int or size_t, to record sizes.
1802 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1803 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1804 either works, as we prefer signed integers.
1805 (tiff_read_from_memory, tiff_write_from_memory):
1806 Return tsize_t, not size_t, since that's what the TIFF API wants.
1807 (tiff_read_from_memory): Don't fail simply because the read would
1808 go past EOF; instead, return a short read.
1809 (tiff_load): Omit no-longer-needed casts.
1810 (Fimagemagick_types): Don't assume size fits into 'int'.
1812 Improve hashing quality when configured --with-wide-int.
1813 * fns.c (hash_string): New function, taken from sxhash_string.
1814 Do not discard information about ASCII character case; this
1815 discarding is no longer needed.
1816 (sxhash-string): Use it. Change sig to match it. Caller changed.
1817 * lisp.h: Declare it.
1818 * lread.c (hash_string): Remove, since we now use fns.c's version.
1819 The fns.c version returns a wider integer if --with-wide-int is
1820 specified, so this should help the quality of the hashing a bit.
1822 * emacs.c: Integer overflow minor fix.
1823 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1824 Define only if GNU_LINUX.
1825 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1827 * dispnew.c: Integer signedness and overflow fixes.
1828 Remove unnecessary forward decls, that were a maintenance hassle.
1829 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1831 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1832 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1833 (prepare_desired_row, line_draw_cost):
1834 Use int, not unsigned, where either works.
1835 (save_current_matrix, restore_current_matrix):
1836 Use ptrdiff_t, not size_t, where either works.
1837 (init_display): Check for overflow more accurately, and without
1838 relying on undefined behavior.
1840 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1841 Remove, replacing with the new symbols in lisp.h. All uses changed.
1842 * fileio.c (make_temp_name):
1843 * filelock.c (lock_file_1, lock_file):
1844 * xdisp.c (message_dolog):
1845 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1846 Use pMd etc. instead.
1847 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1848 replacing the pWIDE etc. symbols removed from editfns.c.
1850 * keyboard.h (num_input_events): Now uintmax_t.
1851 This is (very slightly) less likely to mess up due to wraparound.
1854 * buffer.c: Integer signedness fixes.
1855 (alloc_buffer_text, enlarge_buffer_text):
1856 Use ptrdiff_t rather than size_t when either will do, as we prefer
1859 * alloc.c: Integer signedness and overflow fixes.
1860 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1861 (__malloc_size_t): Default to size_t, not to int.
1862 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1863 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1864 Prefer ptrdiff_t to size_t when either would do, as we prefer
1866 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1867 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1868 Now const. Initialize with values that are in range even if char
1870 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1871 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1872 These functions do the right thing with sizes > 2**32.
1873 (check_depth): Now ptrdiff_t, not int.
1874 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1875 Adjust to new way of storing sizes. Check for size overflow bugs
1877 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1878 slightly wrong anyway, as it missed one instance of
1879 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1880 (refill_memory_reserve): Omit needless cast to size_t.
1881 (mark_object_loop_halt): Mark as externally visible.
1883 * xselect.c: Integer signedness and overflow fixes.
1884 (Fx_register_dnd_atom, x_handle_dnd_message):
1885 Use ptrdiff_t, not size_t, since we prefer signed.
1886 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1887 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1888 x_dnd_atoms_size and x_dnd_atoms_length.
1890 * doprnt.c: Prefer signed to unsigned when either works.
1892 * doprnt.c (doprnt):
1894 * xdisp.c (vmessage):
1895 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1896 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1897 prefer signed arithmetic to avoid comparison confusion.
1898 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1899 but is a bit tricky.
1901 Assume freestanding C89 headers, string.h, stdlib.h.
1902 * data.c, doprnt.c, floatfns.c, print.c:
1903 Include float.h unconditionally.
1904 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1905 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1906 * regex.c: Likewise for stddef.h, string.h.
1907 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1908 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1909 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1910 (STDC_HEADERS): Remove obsolete defines.
1911 * sysdep.c: Include limits.h unconditionally.
1913 Assume support for memcmp, memcpy, memmove, memset.
1914 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1915 * regex.c (memcmp, memcpy):
1916 Remove; we assume C89 now.
1918 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1919 (__malloc_safe_bcopy): Remove; no longer needed.
1921 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1922 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1923 well either way, and we prefer signed to unsigned.
1925 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1927 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1928 closes the connection while we're reading (bug#9182).
1930 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1932 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1933 are specified (Bug#9168).
1935 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1937 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1938 Found by GCC static checking and --with-wide-int on a 32-bit host.
1940 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1942 * xdisp.c (compute_display_string_pos): Fix logic of caching
1943 previous display string position. Initialize cached_prev_pos to
1944 -1. Fixes slow-down at the beginning of a buffer.
1946 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1948 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1949 for attrs[LFACE_FONTSET_INDEX].
1951 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1953 * xml.c (parse_region): Remove unused local
1954 that was recently introduced.
1956 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1958 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1959 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1961 * xdisp.c (move_it_in_display_line_to): Record the best matching
1962 position for TO_CHARPOS while scanning the line, and restore it on
1963 exit if none of the characters scanned was an exact match.
1964 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1965 when exact match is impossible due to invisible text, and the
1966 lines are truncated.
1968 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1970 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1973 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1975 Fix a significant slow-down of cursor motion with C-n, C-p,
1976 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1977 auto-repeat under bidi redisplay in fontified buffers.
1978 * xdisp.c (compute_stop_pos_backwards): New function.
1979 (next_element_from_buffer): Call compute_stop_pos_backwards to
1980 find a suitable prev_stop when we find ourselves before
1982 (reseat): Don't look for prev_stop, as that could mean a very long
1984 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1985 <cached_disp_overlay_modiff>: Cache for last found display string
1987 (compute_display_string_pos): Return the cached position if asked
1988 about the same buffer in the same area of character positions, and
1989 the buffer wasn't changed since the time the display string
1990 position was cached.
1992 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1994 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1995 is an integer, which is important for empty lines. (Bug#9149)
1997 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1999 * frame.c (Fmodify_frame_parameters): In tty case, update the
2000 default face if necessary (Bug#4238).
2002 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
2004 * editfns.c (Fstring_to_char): No need to explain what a character
2005 is in the docstring (Bug#6576).
2007 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2009 * xml.c (parse_region): Make sure we always return a tree.
2011 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2013 * xml.c (parse_region): If a document contains only comments,
2016 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2018 * xml.c (make_dom): Return comments, too.
2020 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2023 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2024 and the surrounding thread.
2025 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2026 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2027 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2029 * s/openbsd.h (BROKEN_SIGIO): Define.
2030 * unexelf.c (unexec) [__OpenBSD__]:
2031 Don't update the .mdebug section of the Alpha COFF symbol table.
2033 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2035 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2038 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2040 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2041 This fixes some race conditions on the permissions of any newly
2044 * alloc.c (valid_pointer_p): Use pipe, not open.
2045 This fixes some permissions issues when debugging.
2047 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2048 If fchown fails to set both uid and gid, try to set just gid,
2049 as that is sometimes allowed. Adjust the file's mode to eliminate
2050 setuid or setgid bits that are inappropriate if fchown fails.
2052 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2054 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2055 to compare Lisp_Objects.
2056 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2057 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2058 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2060 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2062 * lread.c (read_integer): Unread even EOF character.
2063 (read1): Likewise. Properly record start position of symbol.
2065 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2066 symbol character follows.
2068 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2070 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2071 This works around a problem with the previous change to Fcopy_file.
2072 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2073 and without this change, GCC might complain about discarding
2074 fchown's return value.
2076 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
2078 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2080 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2082 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2084 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2086 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2087 it's used from the C level.
2089 * process.c: Use the same condition for POLL_FOR_INPUT in both
2090 keyboard.c and process.c (bug#1858).
2092 2011-07-09 Lawrence Mitchell <wence@gmx.li>
2094 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2095 (Fgnutls_boot): Use it.
2097 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2099 * doc.c (Fsubstitute_command_keys): Revert last change.
2101 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2103 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2104 quotes the next character, and doesn't affect other longer
2105 sequences (bug#8935).
2107 * lread.c (syms_of_lread): Clarify that is isn't only
2108 `eval-buffer' and `eval-defun' that's affected by
2109 `lexical-binding' (bug#8460).
2111 2011-07-15 Eli Zaretskii <eliz@gnu.org>
2113 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2114 bidi redisplay when a line includes both an image and is truncated.
2116 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2118 Fix minor problems found by static checking.
2119 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2120 (elsz): Now a signed constant, not a size_t var. We prefer signed
2121 types to unsigned, to avoid integer comparison confusion. Without
2122 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2123 "cannot optimize loop, the loop counter may overflow", a symptom
2125 * indent.c (Fvertical_motion): Mark locals as initialized.
2126 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2128 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2130 * search.c (Fre_search_backward): Mention `case-fold-search' in
2131 all the re_search_* functions (bug#8138).
2133 * keyboard.c (Fopen_dribble_file): Document when the file is
2136 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2138 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2141 Support bidi reordering of display and overlay strings.
2142 * xdisp.c (compute_display_string_pos)
2143 (compute_display_string_end): Accept additional argument STRING.
2144 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2145 (reseat_to_string): Initialize bidi_it->string.s and
2146 bidi_it->string.schars.
2147 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2148 NULL (avoids a crash in bidi_paragraph_init).
2149 Initialize itb.string.lstring.
2150 (init_iterator): Call bidi_init_it only of a valid
2151 buffer position was specified. Initialize paragraph_embedding to
2153 (reseat_to_string): Initialize the bidi iterator.
2154 (display_string): If we need to ignore text properties of
2155 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2156 original value of -1 will not work with bidi.)
2157 (compute_display_string_pos): First arg is now struct
2158 `text_pos *'; all callers changed. Support display properties on
2160 (compute_display_string_end): Support display properties on Lisp
2162 (init_iterator, reseat_1, reseat_to_string): Initialize the
2163 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2164 when iterating on a string not from display properties).
2165 (compute_display_string_pos, compute_display_string_end):
2166 Fix calculation of the object to scan. Fixes an error when using
2168 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2169 base_level_stop; instead, set base_level_stop to BEGV.
2170 Fixes crashes in vertical-motion.
2171 (next_element_from_buffer): Improve commentary for when
2172 the iterator is before prev_stop.
2173 (init_iterator): Initialize bidi_p from the default value of
2174 bidi-display-reordering, not from buffer-local value. Use the
2175 buffer-local value only if initializing for buffer iteration.
2176 (handle_invisible_prop): Support invisible properties on strings
2177 that are being bidi-reordered.
2178 (set_iterator_to_next): Support bidi reordering of C strings and
2180 (next_element_from_string): Support bidi reordering of Lisp
2182 (handle_stop_backwards): Support Lisp strings as well.
2183 (display_string): Support display of R2L glyph rows.
2184 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2185 (init_iterator): Don't initialize it->bidi_p for strings
2187 (reseat_to_string): Initialize it->bidi_p for strings here.
2188 (next_element_from_string, next_element_from_c_string)
2189 (next_element_from_buffer): Add xassert's for correspondence
2190 between IT's object being iterated and it->bidi_it.string
2192 (face_before_or_after_it_pos): Support bidi iteration.
2193 (next_element_from_c_string): Handle the case of the first string
2194 character that is not the first one in the visual order.
2195 (get_visually_first_element): New function, refactored from common
2196 parts of next_element_from_buffer, next_element_from_string, and
2197 next_element_from_c_string.
2198 (tool_bar_lines_needed, redisplay_tool_bar)
2199 (display_menu_bar): Force left-to-right direction. Add a FIXME
2200 comment for making that be controlled by a user option.
2201 (push_it, pop_it): Save and restore the state of the
2202 bidi iterator. Save and restore the bidi_p flag.
2203 (pop_it): Iterate out of display property for string iteration as
2205 (iterate_out_of_display_property): Support iteration over strings.
2206 (handle_single_display_spec): Set up it->bidi_it for iteration
2207 over a display string, and call bidi_init_it.
2208 (handle_single_display_spec, next_overlay_string)
2209 (get_overlay_strings_1, push_display_prop): Set up the bidi
2210 iterator for displaying display or overlay strings.
2211 (forward_to_next_line_start): Don't use the shortcut if
2213 (back_to_previous_visible_line_start): If handle_display_prop
2214 pushed the iterator stack, restore the internal state of the bidi
2215 iterator by calling bidi_pop_it same number of times.
2216 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2217 and we are bidi-iterating, don't decrement the iterator position;
2218 instead, set the first_elt flag in the bidi iterator, to produce
2220 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2221 (push_display_prop): xassert that we are iterating a buffer.
2222 (push_it, pop_it): Save and restore paragraph_embedding member.
2223 (handle_single_display_spec, next_overlay_string)
2224 (get_overlay_strings_1, reseat_1, reseat_to_string)
2225 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2226 correctly. Don't assume unibyte strings are not bidi-reordered.
2227 (compute_display_string_pos)
2228 (compute_display_string_end): Fix handling the case of C string.
2229 (push_it, pop_it): Save and restore from_disp_prop_p.
2230 (handle_single_display_spec, push_display_prop): Set the
2231 from_disp_prop_p flag.
2232 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2233 (pop_it): Call iterate_out_of_display_property only if we are
2234 popping after iteration over a string that came from a display
2235 property. Fix a typo in popping stretch info. Add an assertion
2236 for verifying that the iterator position is in sync with the bidi
2238 (handle_single_display_spec, get_overlay_strings_1)
2239 (push_display_prop): Fix initialization of paragraph direction for
2240 string when that of the parent object is not yet determined.
2241 (reseat_1): Call bidi_init_it to resync the bidi
2242 iterator with IT's position. (Bug#7616)
2243 (find_row_edges): If ROW->start.pos gives position
2244 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2245 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2246 Reset the from_disp_prop_p flag.
2247 (SAVE_IT, RESTORE_IT): New macros.
2248 (pos_visible_p, face_before_or_after_it_pos)
2249 (back_to_previous_visible_line_start)
2250 (move_it_in_display_line_to, move_it_in_display_line)
2251 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2252 (try_scrolling, redisplay_window, display_line): Use them when
2253 saving a temporary copy of the iterator and restoring it back.
2254 (back_to_previous_visible_line_start, reseat_1)
2255 (init_iterator): Empty the bidi cache "stack".
2256 (move_it_in_display_line_to): If iterator ended up at
2257 EOL, but we never saw any buffer positions smaller than
2258 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2259 motion in bidi-reordered lines.
2260 (move_it_in_display_line_to): Record prev_method and prev_pos
2261 immediately before the call to set_iterator_to_next. Fixes cursor
2262 motion in bidi-reordered lines with stretch glyphs and strings
2263 displayed in margins. (Bug#8133) (Bug#8867)
2264 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2266 (pos_visible_p): Support positions in bidi-reordered lines.
2267 Save and restore bidi cache.
2269 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2270 (bidi_paragraph_info): Delete unused struct.
2271 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2272 (bidi_cache_start): New variable.
2273 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2275 (bidi_cache_fetch_state, bidi_cache_search)
2276 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2277 (bidi_cache_find, bidi_peek_at_next_level)
2278 (bidi_level_of_next_char, bidi_find_other_level_edge)
2279 (bidi_move_to_visually_next): Compare cache index with
2280 bidi_cache_start rather than with zero.
2281 (bidi_fetch_char): Accept new argument STRING; all callers
2282 changed. Support iteration over a string. Support strings with
2283 display properties. Support unibyte strings. Fix the type of
2284 `len' according to what STRING_CHAR_AND_LENGTH expects.
2285 (bidi_paragraph_init, bidi_resolve_explicit_1)
2286 (bidi_resolve_explicit, bidi_resolve_weak)
2287 (bidi_level_of_next_char, bidi_move_to_visually_next):
2288 Support iteration over a string.
2289 (bidi_set_sor_type, bidi_resolve_explicit_1)
2290 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2291 can now be zero (for strings); special values 0 and -1 were
2292 changed to -1 and -2, respectively.
2293 (bidi_char_at_pos): New function.
2294 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2295 Call it instead of FETCH_MULTIBYTE_CHAR.
2296 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2297 initialized to valid values.
2298 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2300 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2301 the test for valid cached positions. Fix the logic for looking up
2302 the sentinel state in the cache. GCPRO the Lisp string we are
2304 (bidi_push_it, bidi_pop_it): New functions.
2305 (bidi_initialize): Initialize the bidi cache start stack pointer.
2306 (bidi_cache_ensure_space): New function, refactored from part of
2307 bidi_cache_iterator_state. Don't assume the required size is just
2308 one BIDI_CACHE_CHUNK away.
2309 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2310 (bidi_count_bytes, bidi_char_at_pos): New functions.
2311 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2312 always valid if bidi_cache_idx is valid.
2313 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2314 is valid if it's going to be used.
2315 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2316 (bidi_cache_fetch_state, bidi_cache_search)
2317 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2318 (bidi_cache_iterator_state, bidi_cache_find)
2319 (bidi_find_other_level_edge, bidi_cache_start_stack):
2320 All variables related to cache indices are now EMACS_INT.
2322 * dispextern.h (struct bidi_string_data): New structure.
2323 (struct bidi_it): New member `string'. Make flag members be 1-bit
2324 fields, and put them last in the struct.
2325 (compute_display_string_pos, compute_display_string_end):
2327 (bidi_push_it, bidi_pop_it): Add prototypes.
2328 (struct iterator_stack_entry): New members bidi_p,
2329 paragraph_embedding, and from_disp_prop_p.
2330 (struct it): Member bidi_p is now a bit field 1 bit wide.
2331 (bidi_shelve_cache, bidi_unshelve_cache):
2334 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2335 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2336 and vector-like objects.
2338 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2339 cache around display iteration.
2341 * window.c (Fwindow_end, window_scroll_pixel_based)
2342 (displayed_window_lines, Frecenter): Save and restore the bidi
2343 cache around display iteration.
2345 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2347 * editfns.c (Fdelete_region): Clarify the use of the named
2348 parameters (bug#6788).
2350 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2352 * indent.c (Fvertical_motion): Set and restore w->pointm when
2353 saving and restoring the window's buffer (Bug#9006).
2355 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2357 * editfns.c (Fstring_to_char): Clarify just what is returned
2358 (bug#6576). Text by Eli Zaretskii.
2360 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2362 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2364 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2366 * buffer.c (mmap_find): Fix a typo.
2368 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2370 Fix execution of x selection hooks.
2371 * xselect.c (Qx_lost_selection_functions)
2372 (Qx_sent_selection_functions): New vars.
2373 (syms_of_xselect): DEFSYM them.
2374 (x_handle_selection_request): Pass Qx_sent_selection_functions
2375 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2376 (x_handle_selection_clear,x_clear_frame_selections):
2377 Pass Qx_lost_selection_functions rather than
2378 Vx_lost_selection_functions to Frun_hook_with_args.
2380 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2382 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2383 The old code sometimes used this field without initializing it.
2385 * alloc.c (gc_sweep): Don't read past end of array.
2386 In theory, the old code could also have corrupted Emacs internals,
2387 though it'd be very unlikely.
2389 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2391 * character.c (Fcharacterp): Don't advertise optional ignored
2392 argument. (Bug#4026)
2394 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2396 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2399 * window.c (Fset_window_start): Doc fix (bug#4199).
2400 (Fset_window_hscroll): Ditto.
2402 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2404 Fix minor new problems caught by GCC 4.6.1.
2405 * term.c (init_tty): Remove unused local.
2406 * xsettings.c (store_monospaced_changed): Define this function only
2407 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2410 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2412 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2414 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2416 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2417 are the mini-buffer and the echo area (bug#3320).
2419 * term.c (init_tty): Remove support for supdup, c10 and perq
2420 terminals, which are no longer supported (bug#1482).
2422 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2424 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2426 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2428 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2429 for non-popups (Bug#3642).
2431 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2433 * alloc.c (reset_malloc_hooks): Protoize.
2434 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2435 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2436 * cm.c (losecursor): Likewise.
2437 * data.c (fmod): Likewise.
2438 * dispnew.c (swap_glyphs_in_rows): Likewise.
2439 * emacs.c (memory_warning_signal): Likewise.
2440 * floatfns.c (float_error): Likewise.
2441 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2442 (otf_open, font_otf_capability, generate_otf_features)
2443 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2445 * image.c (pbm_read_file): Likewise.
2446 * indent.c (string_display_width): Likewise.
2447 * intervals.c (check_for_interval, search_for_interval)
2448 (inc_interval_count, count_intervals, root_interval)
2449 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2450 * lread.c (defalias): Likewise.
2451 * ralloc.c (r_alloc_check): Likewise.
2452 * regex.c (set_image_of_range_1, set_image_of_range)
2453 (regex_grow_registers): Likewise.
2454 * sysdep.c (strerror): Likewise.
2455 * termcap.c (valid_filename_p, tprint, main): Likewise.
2456 * tparam.c (main): Likewise.
2457 * unexhp9k800.c (run_time_remap, save_data_space)
2458 (update_file_ptrs, read_header, write_header, calculate_checksum)
2459 (copy_file, copy_rest, display_header): Likewise.
2460 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2462 * xdisp.c (check_it): Likewise.
2463 * xfaces.c (register_color, unregister_color, unregister_colors):
2465 * xfns.c (print_fontset_result): Likewise.
2466 * xrdb.c (member, fatal, main): Likewise.
2468 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2470 Fix minor problems found by static checking (Bug#9031).
2471 * chartab.c (char_table_set_range, map_sub_char_table):
2472 Remove unused locals.
2473 (uniprop_table): Now static.
2474 * composite.c (_work_char): Remove unused static var.
2476 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2478 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2480 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2482 * gtkutil.c (qttip_cb): Remove code without function.
2484 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2486 * w32.c (pthread_sigmask): New stub.
2488 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2490 Use pthread_sigmask, not sigprocmask (Bug#9010).
2491 sigprocmask is portable only for single-threaded applications, and
2492 Emacs can be multi-threaded when it uses GTK.
2493 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2495 * callproc.c (Fcall_process):
2496 * process.c (create_process):
2497 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2498 Use pthread_sigmask, not sigprocmask.
2500 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2502 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2503 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2506 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2508 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2509 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2510 (xg_hide_tooltip): Fix comment.
2512 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2513 in registerServicesMenuSendTypes.
2514 (validRequestorForSendType): Don't check ns_return_types.
2516 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2519 2011-07-08 Jason Rumney <jasonr@gnu.org>
2521 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2522 frame struct members of non-existent frames (Bug#6284).
2524 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2526 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2527 variable firstTime not needed on OSX >= 10.6.
2528 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2529 >= 10.5. Use setKnobProportion, setDoubleValue.
2531 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2532 (MAC_OS_X_VERSION_10_5): Define if not defined.
2533 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2534 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2535 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2537 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2538 cString and lossyCString on OSX >= 10.4
2540 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2541 sizeToFit on OSX >= 10.2.
2543 * nsimage.m (allocInitFromFile): Don't use deprecated method
2544 bestRepresentationForDevice on OSX >= 10.6.
2546 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2549 * emacs.c: Declare unexec_init_emacs_zone.
2551 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2553 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2555 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2556 on svcsMenu (Bug#8842).
2558 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2560 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2562 * nsterm.m (QUTF8_STRING): Declare.
2563 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2564 (validRequestorForSendType): Return type is (id).
2565 Change indexOfObjectIdenticalTo to indexOfObject.
2566 Check if we have local selection before returning self (Bug#8842).
2567 (writeSelectionToPasteboard): Put local selection into paste board
2568 if we have a local selection (Bug#8842).
2569 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2571 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2572 (ns_get_local_selection): Declare.
2574 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2576 * keymap.c (describe_map_tree): Don't insert a double newline at
2577 the end of the buffer (bug#1169) and return whether we inserted
2580 * callint.c (Fcall_interactively): Change "reading args" to
2581 "providing args" to try to clarify what it does (bug#1010).
2583 2011-07-07 Kenichi Handa <handa@m17n.org>
2585 * composite.c (composition_compute_stop_pos): Ignore a static
2586 composition starting before CHARPOS (Bug#8915).
2588 * xdisp.c (handle_composition_prop): Likewise.
2590 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2592 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2595 2011-07-07 Kenichi Handa <handa@m17n.org>
2597 * character.h (unicode_category_t): New enum type.
2599 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2600 (Qchar_code_property_table): New variable.
2601 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2602 (UNIPROP_COMPRESSED_FORM_P): New macros.
2603 (char_table_ascii): Uncompress the compressed values.
2604 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2605 Uncompress the compressed values.
2606 (sub_char_table_ref_and_range): Likewise.
2607 (char_table_ref_and_range): Uncompress the compressed values.
2608 (sub_char_table_set): New arg is_uniprop. Callers changed.
2609 Uncompress the compressed values.
2610 (sub_char_table_set_range): Args changed. Callers changed.
2611 (char_table_set_range): Adjuted for the above change.
2612 (map_sub_char_table): Delete args default_val and parent. Add arg
2613 top. Give decoded values to a Lisp function.
2614 (map_char_table): Adjust for the above change. Give decoded
2615 values to a Lisp function. Gcpro more variables.
2616 (uniprop_table_uncompress)
2617 (uniprop_decode_value_run_length): New functions.
2618 (uniprop_decoder, uniprop_decoder_count): New variables.
2619 (uniprop_get_decoder, uniprop_encode_value_character)
2620 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2622 (uniprop_encoder, uniprop_encoder_count): New variables.
2623 (uniprop_get_encoder, uniprop_table)
2624 (Funicode_property_table_internal, Fget_unicode_property_internal)
2625 (Fput_unicode_property_internal): New functions.
2626 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2627 Sunicode_property_table_internal, Sget_unicode_property_internal,
2628 and Sput_unicode_property_internal. Defvar_lisp
2629 char-code-property-alist.
2631 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2632 Vunicode_category_table.
2634 * font.c (font_range): Adjust for the change of
2635 Vunicode_category_table.
2637 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2639 * m/iris4d.h: Remove file, move contents ...
2640 * s/irix6-5.h: ... here.
2642 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2644 Remove unportable assumption about struct layout (Bug#8884).
2645 * alloc.c (mark_buffer):
2646 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2647 (clone_per_buffer_values): Don't assume that
2648 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2649 This isn't true in general, and it's particularly not true
2650 if Emacs is configured with --with-wide-int.
2651 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2652 New macros, used in the buffer.c change.
2654 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2656 * xsettings.c: Use both GConf and GSettings if both are available.
2657 (store_config_changed_event): Add comment.
2658 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2659 (store_tool_bar_style_changed): New functions.
2660 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2661 (struct xsettings): Move font inside HAVE_XFT.
2662 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2663 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2664 Move inside HAVE_XFT.
2665 (something_changed_gsettingsCB): Rename from something_changedCB.
2666 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2668 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2669 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2670 (something_changed_gconfCB): Rename from something_changedCB.
2671 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2672 (parse_settings): Move check for font inside HAVE_XFT.
2673 (read_settings, apply_xft_settings): Add comment.
2674 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2675 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2676 call store_font_name_changed.
2677 (xft_settings_event): Add comment.
2678 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2679 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2680 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2681 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2682 (xsettings_initialize): Call init_gsettings last.
2683 (xsettings_get_system_font, xsettings_get_system_normal_font):
2686 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2688 Random fixes. E.g., (random) never returned negative values.
2689 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2690 subseconds part to the entropy, as that's a bit more random.
2691 Prefer signed to unsigned, since the signedness doesn't matter and
2692 in general we prefer signed. When given a limit, use a
2693 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2694 latter isn't right if USE_2_TAGS_FOR_INTS.
2695 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2696 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2698 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2700 * textprop.c (text_property_stickiness):
2701 Obey Vtext_property_default_nonsticky.
2702 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2703 * w32fns.c (syms_of_w32fns):
2704 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2706 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2708 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2709 This is more efficient than Ffile_directory_p and avoids a minor race.
2711 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2713 * buffer.c (Foverlay_put): Say what the return value is
2716 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2717 is a directory before asking whether to use the file name
2719 (barf_or_query_if_file_exists): Make the "File is a directory"
2720 error be more correct.
2722 * fns.c (Frequire): Remove the mention of the .gz files, since
2723 that's installation-specific, but keep the mention of
2724 `get-load-suffixes'.
2726 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2728 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2729 Report string overflow if the output is too long.
2731 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2733 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2734 (syms_of_gnutls): Remove duplicate DEFSYM for
2735 Qgnutls_bootprop_verify_hostname_error, an error for
2736 Qgnutls_bootprop_verify_error (which is no longer used).
2738 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2739 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2740 Also (re)move comments that are misplaced or no longer relevant.
2742 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2744 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2746 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2748 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2749 and background color parameters if they have been changed.
2751 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2753 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2755 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2757 * xsettings.c (SYSTEM_FONT): Define only when used.
2758 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2760 * keymap.c (access_keymap_1): Now static.
2762 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2764 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2765 leave any prefix arg for the up event (Bug#1586).
2767 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2769 * lread.c (syms_of_lread): Mention single symbols defined by
2770 `defvar' or `defconst' (bug#7154).
2772 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2773 (Frequire): Mention get-load-suffixes.
2775 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2777 * window.h (window): Remove clone_number slot.
2778 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2780 (make_parent_window, make_window, saved_window)
2781 (Fset_window_configuration, save_window_save): Don't deal with
2783 * buffer.c (Qclone_number): Remove declaration.
2784 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2786 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2788 Add multiple inheritance to keymaps.
2789 * keymap.c (Fmake_composed_keymap): New function.
2790 (Fset_keymap_parent): Simplify.
2791 (fix_submap_inheritance): Remove.
2792 (access_keymap_1): New function extracted from access_keymap to handle
2793 embedded parents and handle lists of maps.
2794 (access_keymap): Use it.
2795 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2796 (Fcopy_keymap): Handle embedded parents.
2797 (Fcommand_remapping, define_as_prefix): Simplify.
2798 (Fkey_binding): Simplify.
2799 (syms_of_keymap): Move minibuffer-local-completion-map,
2800 minibuffer-local-filename-completion-map,
2801 minibuffer-local-must-match-map, and
2802 minibuffer-local-filename-must-match-map to Elisp.
2803 (syms_of_keymap): Defsubr make-composed-keymap.
2804 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2805 (parse_menu_item): Trivial simplification.
2807 2011-07-01 Glenn Morris <rgm@gnu.org>
2809 * Makefile.in (SETTINGS_LIBS): Fix typo.
2811 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2813 * coding.c (Fencode_coding_string): Record the last coding system
2814 used, as the function doc string says (bug#8738).
2816 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2818 * xsettings.c (store_monospaced_changed): Take new font as arg and
2819 check for change against current_mono_font.
2820 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2821 (emacs_settings_constructor, emacs_settings_get_property)
2822 (emacs_settings_set_property, emacs_settings_class_init)
2823 (emacs_settings_init, gsettings_obj): Remove.
2824 (something_changedCB): New function for HAVE_GSETTINGS.
2825 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2826 with value as argument.
2827 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2828 g_settings_new (Bug#8967). Do not create gsettings_obj.
2829 Remove calls to g_settings_bind. Connect something_changedCB to
2832 * xgselect.c: Add defined (HAVE_GSETTINGS).
2833 (xgselect_initialize): Ditto.
2835 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2836 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2839 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2841 * eval.c (struct backtrace): Simplify and port the data structure.
2842 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2843 signed bit field, as this assumption is not portable and it makes
2844 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2845 "char debug_on_exit : 1" as this is not portable either; instead,
2846 use the portable "unsigned int debug_on_exit : 1". Remove unused
2847 member evalargs. Remove obsolete comments about cc bombing out.
2849 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2851 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2852 Let HAVE_GSETTINGS override HAVE_GCONF.
2853 (store_monospaced_changed): New function.
2854 (EMACS_SETTINGS): A new type derived from GObject to handle
2855 GSettings notifications.
2856 (emacs_settings_constructor, emacs_settings_get_property)
2857 (emacs_settings_set_property, emacs_settings_class_init):
2859 (gsettings_client, gsettings_obj): New variables.
2860 (GSETTINGS_SCHEMA): New define.
2861 (something_changedCB): Call store_monospaced_changed.
2862 (init_gsettings): New function.
2863 (xsettings_initialize): Call init_gsettings.
2864 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2867 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2870 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2872 * window.c (resize_root_window, grow_mini_window)
2873 (shrink_mini_window): Rename Qresize_root_window to
2874 Qwindow_resize_root_window and Qresize_root_window_vertically to
2875 Qwindow_resize_root_window_vertically.
2877 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2879 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2881 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2883 * makefile.w32-in: Redesign dependencies so they reflect more
2884 clearly which files are directly included by each source file,
2885 and not through other includes.
2887 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2889 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2890 (sort_overlays, overlay_strings): When an overlay's clone number
2891 matches the window's clone number process the overlay even if
2892 the overlay's window property doesn't match the current window.
2894 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2895 (Fwindow_hchild): Rename to Fwindow_left_child.
2896 (Fwindow_next): Rename to Fwindow_next_sibling.
2897 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2898 (resize_window_check): Rename to window_resize_check.
2899 (resize_window_apply): Rename to window_resize_apply.
2900 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2901 (Fdelete_other_windows_internal, resize_frame_windows)
2902 (Fsplit_window_internal, Fdelete_window_internal)
2903 (grow_mini_window, shrink_mini_window)
2904 (Fresize_mini_window_internal): Fix callers accordingly.
2906 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2908 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2909 (emacs_fixed_set_min_size): Remove.
2910 (emacs_fixed_new): Take frame as argument.
2912 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2913 (_EmacsFixedPrivate): Remove minwidth/height.
2914 Add struct frame *f.
2915 (emacs_fixed_init): Initialize priv->f.
2916 (get_parent_class, emacs_fixed_set_min_size): Remove.
2917 (emacs_fixed_new): Set priv->f to argument.
2918 (emacs_fixed_get_preferred_width)
2919 (emacs_fixed_get_preferred_height): Use min_width/height from
2920 frames size_hint to set minimum and natural (Bug#8919).
2921 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2922 and use min_width/height from frames size_hint to set
2923 min_width/height (Bug#8919).
2925 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2926 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2929 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2931 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2932 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2935 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2937 * process.c (wait_reading_process_output): Bypass select if
2938 waiting for a cell while ignoring keyboard input, and input is
2939 pending. Suggested by Jan Djärv (Bug#8869).
2941 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2943 Use gnulib's dup2 module instead of rolling our own.
2944 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2946 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2948 * dispnew.c (scrolling_window): Before scrolling, turn off a
2949 mouse-highlight in the window being scrolled.
2951 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2953 Move DEFSYM to lisp.h and use everywhere.
2955 * character.h (DEFSYM): Move declaration...
2956 * lisp.h (DEFSYM): ...here.
2962 * w32select.c: Don't include character.h.
2964 * alloc.c (syms_of_alloc):
2965 * buffer.c (syms_of_buffer):
2966 * bytecode.c (syms_of_bytecode):
2967 * callint.c (syms_of_callint):
2968 * casefiddle.c (syms_of_casefiddle):
2969 * casetab.c (init_casetab_once):
2970 * category.c (init_category_once, syms_of_category):
2971 * ccl.c (syms_of_ccl):
2972 * cmds.c (syms_of_cmds):
2973 * composite.c (syms_of_composite):
2974 * dbusbind.c (syms_of_dbusbind):
2975 * dired.c (syms_of_dired):
2976 * dispnew.c (syms_of_display):
2977 * doc.c (syms_of_doc):
2978 * editfns.c (syms_of_editfns):
2979 * emacs.c (syms_of_emacs):
2980 * eval.c (syms_of_eval):
2981 * fileio.c (syms_of_fileio):
2982 * fns.c (syms_of_fns):
2983 * frame.c (syms_of_frame):
2984 * fringe.c (syms_of_fringe):
2985 * insdel.c (syms_of_insdel):
2986 * keymap.c (syms_of_keymap):
2987 * lread.c (init_obarray, syms_of_lread):
2988 * macros.c (syms_of_macros):
2989 * msdos.c (syms_of_msdos):
2990 * print.c (syms_of_print):
2991 * process.c (syms_of_process):
2992 * search.c (syms_of_search):
2993 * sound.c (syms_of_sound):
2994 * syntax.c (init_syntax_once, syms_of_syntax):
2995 * terminal.c (syms_of_terminal):
2996 * textprop.c (syms_of_textprop):
2997 * undo.c (syms_of_undo):
2998 * w32.c (globals_of_w32):
2999 * window.c (syms_of_window):
3000 * xdisp.c (syms_of_xdisp):
3001 * xfaces.c (syms_of_xfaces):
3002 * xfns.c (syms_of_xfns):
3003 * xmenu.c (syms_of_xmenu):
3004 * xsettings.c (syms_of_xsettings):
3005 * xterm.c (syms_of_xterm): Use DEFSYM.
3007 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3009 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
3011 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3013 Integer and buffer overflow fixes (Bug#8873).
3015 * print.c (printchar, strout): Check for string overflow.
3016 (PRINTPREPARE, printchar, strout):
3017 Don't set size unless allocation succeeds.
3019 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3020 for sizes. Check for string overflow more accurately.
3021 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3023 * macros.c: Integer and buffer overflow fixes.
3024 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3025 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3026 Use ptrdiff_t, not int, for sizes.
3027 Don't increment bufsize until after realloc succeeds.
3028 Check for size-calculation overflow.
3029 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3031 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3033 * lread.c: Integer overflow fixes.
3034 (read_integer): Radix is now EMACS_INT, not int,
3035 to improve quality of diagnostics for out-of-range radices.
3036 Calculate buffer size correctly for out-of-range radices.
3037 (read1): Check for integer overflow in radices, and in
3038 read-circle numbers.
3039 (read_escape): Avoid int overflow.
3040 (Fload, openp, read_buffer_size, read1)
3041 (substitute_object_recurse, read_vector, read_list, map_obarray):
3042 Use ptrdiff_t, not int, for sizes.
3043 (read1): Use EMACS_INT, not int, for sizes.
3044 Check for size overflow.
3046 * image.c (cache_image): Check for size arithmetic overflow.
3048 * lread.c: Integer overflow issues.
3049 (saved_doc_string_size, saved_doc_string_length)
3050 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3051 Now ptrdiff_t, not int.
3052 (read1): Don't assume doc string length fits in int. Check for
3053 out-of-range doc string lengths.
3054 (read_list): Don't assume file position fits in int.
3055 (read_escape): Check for hex character overflow.
3057 2011-06-22 Leo Liu <sdl.web@gmail.com>
3059 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3060 Move to minibuffer.el.
3062 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3064 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
3065 The following patches are for when GLYPH_DEBUG && !XASSERT.
3066 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3067 * dispnew.c (flush_stdout):
3068 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3069 Mark as externally visible.
3070 * dispnew.c (check_window_matrix_pointers): Now static.
3071 * dispnew.c (window_to_frame_vpos):
3072 * xfns.c (unwind_create_frame):
3073 * xterm.c (x_check_font): Remove unused local.
3074 * scroll.c (CHECK_BOUNDS):
3075 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3076 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3077 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3078 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3079 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3081 (debug_method_add): Use va_list and vsprintf rather than relying
3082 on undefined behavior with wrong number of arguments.
3083 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3084 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3085 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3086 since we're not interested in debugging glyphs with old libraries.
3087 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3088 GCC 4.6.0's static checking.
3090 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3092 Integer overflow and signedness fixes (Bug#8873).
3093 A few related buffer overrun fixes, too.
3095 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3097 * dispextern.h (struct face.stipple):
3098 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3099 (x_bitmap_mask, x_allocate_bitmap_record)
3100 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3101 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3102 (x_create_bitmap_from_xpm_data):
3103 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3104 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3106 * xfaces.c (load_pixmap):
3107 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3108 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3109 (.bitmaps_last, struct x_output.icon_bitmap):
3110 Use ptrdiff_t, not int, for bitmap indexes.
3111 (x_allocate_bitmap_record): Check for size overflow.
3112 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3114 Use ptrdiff_t, not int, for overlay counts.
3115 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3116 * editfns.c (overlays_around, get_pos_property):
3117 * textprop.c (get_char_property_and_overlay):
3118 * xdisp.c (next_overlay_change, note_mouse_highlight):
3119 * xfaces.c (face_at_buffer_position):
3120 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3121 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3122 (Fnext_overlay_change, Fprevious_overlay_change)
3123 (mouse_face_overlay_overlaps, Foverlays_in):
3124 Use ptrdiff_t, not int, for sizes.
3125 (overlays_at, overlays_in): Check for size-calculation overflow.
3127 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3129 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3130 (x_session_initialize): Do not assume string length fits in int.
3132 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3133 This is unlikely, but can occur if DPI is outlandish.
3135 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3136 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3138 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3139 * xrdb.c (magic_file_p, search_magic_path):
3140 Omit last arg SUFFIX; it was always 0. All callers changed.
3141 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3143 * xfont.c (xfont_match): Avoid need for strlen.
3145 * xfns.c: Don't assume strlen fits in int.
3146 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3148 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3149 not unsigned long, as we prefer signed integers. All callers changed.
3150 Detect integer overflow in repeat count.
3151 (message_dolog): Don't assume print length fits in 39 bytes.
3152 (display_mode_element): Don't assume strlen fits in int.
3154 * termcap.c: Don't assume sizes fit in int and never overflow.
3155 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3156 (gobble_line): Check for size-calculation overflow.
3158 * minibuf.c (Fread_buffer):
3159 * lread.c (intern, intern_c_string):
3160 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3161 Don't assume string length fits in int.
3163 * keyboard.c (parse_tool_bar_item):
3164 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3166 * font.c: Don't assume string length fits in int.
3167 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3168 Use ptrdiff_t, not int.
3169 (font_intern_prop): Don't assume string length fits in int.
3170 Don't assume integer property fits in fixnum.
3171 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3173 * filelock.c: Fix some buffer overrun and integer overflow issues.
3174 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3175 Reformulate so as not to need the command string.
3176 Invoke gzip -cd rather than gunzip, as it's more portable.
3177 (lock_info_type, lock_file_1, lock_file):
3178 Don't assume pid_t and time_t fit in unsigned long.
3179 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3180 (current_lock_owner): Prefer signed type for sizes.
3181 Use memcpy, not strncpy, where memcpy is what is really wanted.
3182 Don't assume (via atoi) that time_t and pid_t fit in int.
3183 Check for time_t and/or pid_t out of range, e.g., via a network share.
3184 Don't alloca where an auto var works fine.
3186 * fileio.c: Fix some integer overflow issues.
3187 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3188 Don't assume string length fits in int.
3189 (directory_file_name): Don't assume string length fits in long.
3190 (make_temp_name): Don't assume pid fits in int, or that its print
3191 length is less than 20.
3193 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3195 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3197 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3199 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3200 We prefer signed integers, even for size calculations.
3202 * emacs.c: Don't assume string length fits in 'int'.
3203 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3204 (main): Don't invoke strlen when not needed.
3206 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3207 (XD_DEBUG_MESSAGE): Don't waste a byte.
3209 * callproc.c (getenv_internal_1, getenv_internal)
3211 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3213 * lread.c (invalid_syntax): Omit length argument.
3214 All uses changed. This doesn't fix a bug, but it simplifies the
3215 code away from its former Hollerith-constant appearance, and it's
3216 one less 'int' to worry about when looking at integer-overflow issues.
3217 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3219 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3220 This didn't break anything, but it didn't help either.
3221 It's confusing to put a bogus integer in a place where the actual
3222 value does not matter.
3223 (LIST_END_P): Remove unused macro and its bogus comment.
3224 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3226 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3227 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3229 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3230 We prefer signed types, and the value cannot exceed the EMACS_INT
3231 range anyway (because otherwise the length would not be representable).
3232 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3233 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3234 This avoids a GCC warning when WIDE_EMACS_INT.
3236 * indent.c (sane_tab_width): New function.
3237 (current_column, scan_for_column, Findent_to, position_indentation)
3238 (compute_motion): Use it. This is just for clarity.
3239 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3241 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3243 * lisp.h (lint_assume): New macro.
3244 * composite.c (composition_gstring_put_cache):
3245 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3247 * editfns.c, insdel.c:
3248 Omit unnecessary forward decls, to simplify future changes.
3250 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3252 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3254 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3255 Use much-faster test for byte-length change.
3256 Don't assume string byte-length fits in 'int'.
3257 Check that character arg fits in 'int'.
3258 (mapcar1): Declare byte as byte, for clarity.
3260 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3262 * fns.c (concat): Catch string overflow earlier.
3263 Do not rely on integer wraparound.
3265 * dispextern.h (struct it.overlay_strings_charpos)
3266 (struct it.selective): Now EMACS_INT, not int.
3267 * xdisp.c (forward_to_next_line_start)
3268 (back_to_previous_visible_line_start)
3269 (reseat_at_next_visible_line_start, next_element_from_buffer):
3270 Don't arbitrarily truncate the value of 'selective' to int.
3272 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3274 * composite.c: Don't truncate sizes to 'int'.
3275 (composition_gstring_p, composition_reseat_it)
3276 (composition_adjust_point): Use EMACS_INT, not int.
3277 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3278 not EMACS_UINT, for indexes.
3280 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3282 * buffer.c: Include <verify.h>.
3283 (struct sortvec.priority, struct sortstr.priority):
3284 Now EMACS_INT, not int.
3285 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3286 (struct sortstr.size, record_overlay_string)
3287 (struct sortstrlist.size, struct sortlist.used):
3288 Don't truncate size to int.
3289 (record_overlay_string): Check for size-calculation overflow.
3290 (init_buffer_once): Check at compile-time, not run-time.
3292 2011-06-22 Jim Meyering <meyering@redhat.com>
3294 Don't leak an XBM-image-sized buffer
3295 * image.c (xbm_load): Free the image buffer after using it.
3297 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3300 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3301 that Sun C diagnosed.
3302 * fns.c (secure_hash): Fix pointer signedness issue.
3303 * intervals.c (static_offset_intervals): New function.
3304 (offset_intervals): Use it.
3306 2011-06-21 Leo Liu <sdl.web@gmail.com>
3309 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3312 * fns.c (secure_hash): Rename from crypto_hash_function and change
3313 the first arg to accept symbols.
3314 (Fsecure_hash): New primitive.
3315 (syms_of_fns): New symbols.
3317 2011-06-20 Deniz Dogan <deniz@dogan.se>
3319 * process.c (Fset_process_buffer): Clarify return value in
3322 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3324 * dispnew.c (add_window_display_history): Use BVAR.
3326 * xdisp.c (debug_method_add): Use BVAR.
3327 (check_window_end, dump_glyph_matrix, dump_glyph)
3328 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3330 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3333 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3334 check till after the cache is created in init_frame_faces.
3336 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3338 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3340 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3342 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3343 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3344 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3346 Improve buffer-overflow checking (Bug#8873).
3347 * fileio.c (Finsert_file_contents):
3348 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3349 Remove the old (too-loose) buffer overflow checks.
3350 They weren't needed, since make_gap checks for buffer overflow.
3351 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3352 The old code merely checked for Emacs fixnum overflow, and relied
3353 on undefined (wraparound) behavior. The new code avoids undefined
3354 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3356 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3357 Tune. Don't use wider integers than needed. Don't use alloca.
3358 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3360 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3362 * insdel.c, lisp.h (buffer_overflow): New function.
3363 (insert_from_buffer_1, replace_range, replace_range_2):
3364 * insdel.c (make_gap_larger):
3365 * editfns.c (Finsert_char):
3366 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3368 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3370 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3372 Integer overflow and signedness fixes (Bug#8873).
3374 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3375 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3377 * fileio.c: Don't assume EMACS_INT fits in off_t.
3378 (emacs_lseek): New static function.
3379 (Finsert_file_contents, Fwrite_region): Use it.
3380 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3382 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3384 * fns.c: Don't overflow int when computing a list length.
3385 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3386 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3387 truncation on 64-bit hosts. Check for QUIT every
3388 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3389 faster and is responsive enough.
3390 (Flength): Report an error instead of overflowing an integer.
3391 (Fsafe_length): Return a float if the value is not representable
3392 as a fixnum. This shouldn't happen except in contrived situations.
3393 (Fnthcdr, Fsort): Don't assume list length fits in int.
3394 (Fcopy_sequence): Don't assume vector length fits in int.
3396 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3397 (header_size, word_size): New constants.
3398 (allocate_vectorlike): Don't check size overflow here.
3399 (allocate_vector): Check it here instead, since this is the only
3400 caller of allocate_vectorlike that could cause overflow.
3401 Check that the new vector's length is representable as a fixnum.
3403 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3404 The previous code was bogus. For example, next_almost_prime (32)
3405 returned 39, which is undesirable as it is a multiple of 3; and
3406 next_almost_prime (24) returned 25, which is a multiple of 5 so
3407 why was the code bothering to check for multiples of 7?
3409 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3411 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3413 Variadic C functions now count arguments with ptrdiff_t.
3414 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3415 Back then I didn't know that the Emacs coding style prefers signed int.
3416 Also, in the meantime I found a few more instances where arguments
3417 were being counted with int, which may truncate counts on 64-bit
3418 machines, or EMACS_INT, which may be unnecessarily wide.
3419 * lisp.h (struct Lisp_Subr.function.aMANY)
3420 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3421 Arg counts are now ptrdiff_t, not size_t.
3422 All variadic functions and their callers changed accordingly.
3423 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3424 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3425 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3426 * callint.c (Fcall_interactively): Check arg count for overflow,
3427 to avoid potential buffer overrun. Use signed char, not 'int',
3428 for 'varies' array, so that we needn't bother to check its size
3429 calculation for overflow.
3430 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3431 * eval.c (apply_lambda):
3432 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3433 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3434 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3436 * callint.c (Fcall_interactively): Don't use index var as event count.
3438 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3439 * mem-limits.h (SIZE): Remove; no longer used.
3441 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3443 Remove unnecessary casts.
3444 * xterm.c (x_term_init):
3445 * xfns.c (x_set_border_pixel):
3446 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3447 These aren't needed now that we assume ANSI C.
3449 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3450 It's more likely to cause problems (due to unsigned overflow)
3453 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3455 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3457 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3459 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3461 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3463 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3465 GLYPH_CODE_FACE returns EMACS_INT, not int.
3466 * dispextern.h (merge_faces):
3467 * xfaces.c (merge_faces):
3468 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3469 Don't assume EMACS_INT fits in int.
3471 * character.h (CHAR_VALID_P): Remove unused parameter.
3472 * fontset.c, lisp.h, xdisp.c: All uses changed.
3474 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3476 * fns.c (concat): Minor tuning based on overflow analysis.
3477 This doesn't fix any bugs. Use int to hold character, instead
3478 of constantly refetching from Emacs object. Use XFASTINT, not
3479 XINT, for value known to be a character. Don't bother comparing
3480 a single byte to 0400, as it's always less.
3482 * floatfns.c (Fexpt):
3483 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3485 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3488 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3490 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3491 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3492 incorrectly succeed when S was a string, because 4294967386 was
3493 truncated before it was used.
3495 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3496 Otherwise, an out-of-range integer could cause undefined behavior
3499 * composite.c: Use int, not EMACS_INT, for characters.
3500 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3501 EMACS_INT, for values that are known to be in character range.
3502 This doesn't fix any bugs but is the usual style inside Emacs and
3503 may generate better code on 32-bit machines.
3505 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3506 This is for reasons similar to the recent CHAR_STRING fix.
3507 * charset.c (Fencode_char): Check that character arg is actually
3508 a character. Pass an int to ENCODE_CHAR.
3509 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3510 wider than 'int', as a compile-time check to prevent future regressions
3513 * character.c (char_string): Remove unnecessary casts.
3515 Make sure a 64-bit char is never passed to CHAR_STRING.
3516 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3517 by silently ignoring the top 32 bits, allowing some values
3518 that were far too large to be valid characters.
3519 * character.h: Include <verify.h>.
3520 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3521 arguments are no wider than unsigned, as a compile-time check
3522 to prevent future regressions in this area.
3524 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3525 (Fsubst_char_in_region):
3527 * xdisp.c (decode_mode_spec_coding):
3528 Adjust to CHAR_STRING's new requirement.
3529 * editfns.c (Finsert_char, Fsubst_char_in_region):
3530 * fns.c (concat): Check that character args are actually
3531 characters. Without this test, these functions did the wrong
3532 thing with wildly out-of-range values on 64-bit hosts.
3534 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3535 These casts should not be needed on 32-bit hosts, either.
3536 * keyboard.c (read_char):
3537 * lread.c (Fload): Remove casts to unsigned.
3539 * lisp.h (UNSIGNED_CMP): New macro.
3540 This fixes comparison bugs on 64-bit hosts.
3541 (ASCII_CHAR_P): Use it.
3542 * casefiddle.c (casify_object):
3543 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3544 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3545 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3546 * dispextern.h (FACE_FROM_ID):
3547 * keyboard.c (read_char): Use UNSIGNED_CMP.
3549 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3550 not to EMACS_INT, to avoid GCC warning.
3552 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3554 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3555 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3556 isn't needed on 32-bit machines.
3558 * buffer.c (Fgenerate_new_buffer_name):
3559 Use EMACS_INT for count, not int.
3560 (advance_to_char_boundary): Return EMACS_INT, not int.
3562 * data.c (Qcompiled_function): Now static.
3564 * window.c (window_body_lines): Now static.
3566 * image.c (gif_load): Rename local to avoid shadowing.
3568 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3569 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3570 * alloc.c (make_save_value): Integer argument is now of type
3572 (mark_object): Use ptrdiff_t, not int.
3573 * lisp.h (pD): New macro.
3574 * print.c (print_object): Use it.
3576 * alloc.c: Use EMACS_INT, not int, to count objects.
3577 (total_conses, total_markers, total_symbols, total_vector_size)
3578 (total_free_conses, total_free_markers, total_free_symbols)
3579 (total_free_floats, total_floats, total_free_intervals)
3580 (total_intervals, total_strings, total_free_strings):
3581 Now EMACS_INT, not int. All uses changed.
3582 (Fgarbage_collect): Compute overall total using a double, so that
3583 integer overflow is less likely to be a problem. Check for overflow
3584 when converting back to an integer.
3585 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3586 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3587 These were 'int' variables that could overflow on 64-bit hosts;
3588 they were never used, so remove them instead of repairing them.
3589 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3590 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3591 Previously, this ceilinged at INT_MAX, but that doesn't work on
3593 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3595 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3596 (allocate_vectorlike): Check for ptrdiff_t overflow.
3597 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3598 when a (possibly-narrower) signed value would do just as well.
3599 We prefer using signed arithmetic, to avoid comparison confusion.
3601 * alloc.c: Catch some string size overflows that we were missing.
3602 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3603 for convenience in STRING_BYTES_MAX.
3604 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3605 The definition here is exact; the one in lisp.h was approximate.
3606 (allocate_string_data): Check for string overflow. This catches
3607 some instances we weren't catching before. Also, it catches
3608 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3609 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3610 and ptrdiff_t and EMACS_INT are both 64 bits.
3612 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3613 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3614 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3616 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3618 * alloc.c (Fmake_string): Check for out-of-range init.
3620 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3622 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3624 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3626 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3627 xg_get_default_scrollbar_width.
3629 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3630 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3631 (style_changed_cb): Call update_theme_scrollbar_width and call
3632 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3633 all frames (Bug#8505).
3634 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3635 Call gtk_window_set_resizable if HAVE_GTK3.
3636 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3637 and height if HAVE_GTK3 (Bug#8505).
3638 (scroll_bar_width_for_theme): New variable.
3639 (update_theme_scrollbar_width): New function.
3640 (xg_get_default_scrollbar_width): Move code to
3641 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3642 (xg_initialize): Call update_theme_scrollbar_width.
3644 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3646 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3648 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3650 * frame.c (make_frame): Call other_buffer_safely instead of
3653 * window.c (temp_output_buffer_show): Call display_buffer with
3654 second argument Vtemp_buffer_show_specifiers and reset latter
3655 immediately after the call.
3656 (Vtemp_buffer_show_specifiers): New variable.
3657 (auto_window_vscroll_p, next_screen_context_lines)
3658 (Vscroll_preserve_screen_position): Remove leading asterisks from
3661 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3663 Fix minor problems found by GCC 4.6.0 static checking.
3664 * buffer.c (Qclone_number): Remove for now, as it's unused.
3665 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3666 (record_buffer): Remove unused local.
3667 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3668 (set_frame_buffer_list): Remove; unused.
3669 * frame.h (other_visible_frames): Remove decl.
3670 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3671 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3672 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3674 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3675 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3676 Define only if HAVE_GPM.
3677 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3678 (update_hints_inhibit): Remove; never set. All uses removed.
3679 * widgetprv.h (emacsFrameClassRec): Remove decl.
3680 * window.c (delete_deletable_window): Now returns void, since it
3681 wasn't returning anything.
3682 (compare_window_configurations): Remove unused locals.
3683 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3684 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3685 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3686 the same widths as pointers. This follows up on the 2011-05-06 patch.
3687 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3688 * xterm.h: Likewise.
3689 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3691 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3693 * makefile.w32-in: Update dependencies.
3694 (LISP_H): Add lib/intprops.h.
3696 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3698 * image.c (gif_load): Add animation frame delay to the metadata.
3699 (syms_of_image): Use DEFSYM. New symbol `delay'.
3701 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3703 * window.c (delete_deletable_window): Re-add.
3704 (Fset_window_configuration): Rewrite to handle dead buffers and
3705 consequently deletable windows.
3706 (window_tree, Fwindow_tree): Remove. Supply functionality in
3708 (compare_window_configurations): Simplify code.
3710 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3712 * image.c (imagemagick_load_image): Fix type mismatch.
3713 (Fimagemagick_types): Likewise.
3715 * window.h (replace_buffer_in_windows): Declare.
3717 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3719 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3720 Qclone_number. Remove external declaration of Qdelete_window.
3721 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3723 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3724 Run Qbuffer_list_update_hook if allowed.
3725 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3726 buffer list implementation.
3727 (other_buffer_safely): New function.
3728 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3729 calls to replace_buffer_in_windows and
3730 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3732 (record_buffer): Inhibit quitting and rewrite using quittable
3733 functions. Run Qbuffer_list_update_hook if allowed.
3734 (Frecord_buffer, Funrecord_buffer): New functions.
3735 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3736 Move switch-to-buffer to window.el.
3737 (bury-buffer): Move to window.el.
3738 (Vbuffer_list_update_hook): New variable.
3740 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3743 * window.h (resize_frame_windows): Move up in code.
3744 (Fwindow_frame): Remove EXFUN.
3745 (replace_buffer_in_all_windows): Remove prototype.
3746 (replace_buffer_in_windows_safely): Add prototype.
3748 * window.c: Declare Qdelete_window static again. Move down
3749 declaration of select_count.
3750 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3751 (Fother_window): Move to window.el.
3752 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3753 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3754 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3756 (replace_buffer_in_windows): Implement by calling
3757 Qreplace_buffer_in_windows.
3758 (replace_buffer_in_all_windows): Remove with some functionality
3759 moved into replace_buffer_in_windows_safely.
3760 (replace_buffer_in_windows_safely): New function.
3761 (select_window_norecord, select_frame_norecord): Move in front
3762 of run_window_configuration_change_hook. Remove now obsolete
3764 (Fset_window_buffer): Rewrite doc-string.
3765 Call Qrecord_window_buffer.
3766 (keys_of_window): Move binding for other-window to window.el.
3768 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3770 * dispextern.h (struct image): Replace data member, whose int_val
3771 and ptr_val fields were not used by anything, with a single
3774 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3775 (gif_clear_image, gif_load, imagemagick_load_image)
3776 (gs_clear_image, gs_load): Callers changed.
3778 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3780 * buffer.h: Include <time.h>, for time_t.
3781 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3783 Fix minor problems found by static checking.
3785 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3787 Make identifiers static if they are not used in other modules.
3788 * data.c (Qcompiled_function, Qframe, Qvector):
3789 * image.c (QimageMagick, Qsvg):
3790 * minibuf.c (Qmetadata):
3791 * window.c (resize_window_check, resize_root_window): Now static.
3792 * window.h (resize_window_check, resize_root_window): Remove decls.
3794 * window.c (window_deletion_count, delete_deletable_window):
3796 (window_body_lines): Now static.
3797 (Fdelete_other_windows_internal): Mark vars as initialized.
3798 Make sure 'resize_failed' is initialized.
3799 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3800 (resize_window_apply): Remove unused local.
3801 * window.h (delete_deletable_window): Remove decl.
3803 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3804 (imagemagick_load_image): Fix pointer signedness problem by changing
3805 last arg from unsigned char * to char *. All uses changed.
3806 Also, fix a local for similar reasons.
3807 Remove unused locals. Remove locals to avoid shadowing.
3808 (fn_rsvg_handle_free): Remove; unused.
3809 (svg_load, svg_load_image): Fix pointer signedness problem.
3810 (imagemagick_load_image): Don't use garbage pointer image_wand.
3812 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3814 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3816 * image.c (gif_load): Fix omitted cast error introduced by
3819 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3821 * window.h (resize_proportionally, orig_total_lines)
3822 (orig_top_line): Remove from window structure.
3823 (set_window_height, set_window_width, change_window_heights)
3824 (Fdelete_window): Remove prototypes.
3825 (resize_frame_windows): Remove duplicate declaration.
3827 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3829 * window.h (resize_frame_windows, resize_window_check)
3830 (delete_deletable_window, resize_root_window)
3831 (resize_frame_windows): Declare prototypes.
3833 * window.c (resize_window_apply): Make definition be "static" to
3834 match the prototype.
3836 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3838 * window.c: Remove declarations of Qwindow_size_fixed,
3839 window_min_size_1, window_min_size_2, window_min_size,
3840 size_window, window_fixed_size_p, enlarge_window, delete_window.
3841 Remove static from declaration of Qdelete_window, it's
3842 temporarily needed by Fbury_buffer.
3843 (replace_window): Don't assign orig_top_line and
3845 (Fdelete_window, delete_window): Remove. Window deletion is
3846 handled by window.el.
3847 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3848 Replace Fdelete_window calls with calls to Qdelete_window.
3849 (Fdelete_other_windows): Remove. Deleting other windows is
3850 handled by window.el.
3851 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3852 handled in window.el.
3853 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3854 Window minimum sizes are handled in window.el.
3855 (shrink_windows, size_window, set_window_height)
3856 (set_window_width, change_window_heights, window_height)
3857 (window_width, CURBEG, CURSIZE, enlarge_window)
3858 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3859 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3860 handled in window.el.
3861 (make_dummy_parent): Rename to make_parent_window and give it a
3862 second argument horflag.
3863 (make_window): Don't set resize_proportionally any more.
3864 (Fsplit_window): Remove. Windows are split in window.el.
3865 (save_restore_action, save_restore_orig_size)
3866 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3867 Resize mini windows in window.el.
3868 (grow_mini_window, shrink_mini_window): Implement by calling
3869 Qresize_root_window_vertically, resize_window_check and
3870 resize_window_apply.
3871 (saved_window, Fset_window_configuration, save_window_save):
3872 Do not handle orig_top_line, orig_total_lines, and
3873 resize_proportionally.
3874 (window_min_height, window_min_width): Move to window.el.
3875 (keys_of_window): Move bindings for delete-other-windows,
3876 split-window, delete-window and enlarge-window to window.el.
3878 * buffer.c: Temporarily extern Qdelete_window.
3879 (Fbury_buffer): Temporarily call Qdelete_window instead of
3880 Fdelete_window (Fbury_buffer will move to window.el soon).
3882 * frame.c (set_menu_bar_lines_1): Remove code handling
3883 orig_top_line and orig_total_lines.
3885 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3886 set_window_height but set heights directly.
3887 (change_frame_size_1): Use resize_frame_windows.
3889 * xdisp.c (init_xdisp): Don't use set_window_height but set
3892 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3893 Use resize_frame_windows instead of change_window_heights and run
3894 run_window_configuration_change_hook.
3896 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3897 instead of change_window_heights and run
3898 run_window_configuration_change_hook.
3900 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3902 * window.c (replace_window): Rename second argument REPLACEMENT to
3903 NEW. New third argument SETFLAG. Rewrite.
3904 (delete_window, make_dummy_parent): Call replace_window with
3906 (window_list_1): Move down in code.
3907 (run_window_configuration_change_hook): Move set_buffer part
3908 before select_frame_norecord part in order to unwind correctly.
3909 Rename count1 to count.
3910 (recombine_windows, delete_deletable_window, resize_root_window)
3911 (Fdelete_other_windows_internal)
3912 (Frun_window_configuration_change_hook, make_parent_window)
3913 (resize_window_check, resize_window_apply, Fresize_window_apply)
3914 (resize_frame_windows, Fsplit_window_internal)
3915 (Fdelete_window_internal, Fresize_mini_window_internal):
3917 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3919 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3921 * window.h (window): Add some new members to window structure -
3922 normal_lines, normal_cols, new_total, new_normal, clone_number,
3923 splits, nest, prev_buffers, next_buffers.
3924 (WINDOW_TOTAL_SIZE): Move here from window.c.
3925 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3927 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3929 (make_dummy_parent): Set new members of windows structure.
3930 (make_window): Move down in code. Handle new members of window
3932 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3933 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3934 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3935 (Fset_window_prev_buffers, Fwindow_next_buffers)
3936 (Fset_window_next_buffers, Fset_window_clone_number):
3938 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3939 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3941 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3942 Argument WINDOW can be now internal window too.
3943 (Fwindow_use_time): Move up in code.
3944 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3946 (Fset_window_configuration, saved_window)
3947 (Fcurrent_window_configuration, save_window_save): Handle new
3948 members of window structure.
3949 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3950 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3951 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3952 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3953 Qget_mru_window, Qresize_root_window,
3954 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3955 Qauto_buffer_name; staticpro them.
3957 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3959 * window.c (Fwindow_total_size, Fwindow_left_column)
3960 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3961 (Fwindow_list_1): New functions.
3962 (window_box_text_cols): Replace with window_body_cols.
3963 (Fwindow_width, Fscroll_left, Fscroll_right):
3964 Use window_body_cols instead of window_box_text_cols.
3965 (delete_window, Fset_window_configuration):
3966 Call delete_all_subwindows with window as argument.
3967 (delete_all_subwindows): Take a window as argument and not a
3969 (window_loop): Remove handling of GET_LRU_WINDOW and
3971 (Fget_lru_window, Fget_largest_window): Move to window.el.
3973 * window.h: Extern window_body_cols instead of
3974 window_box_text_cols. delete_all_subwindows now takes a
3975 Lisp_Object as argument.
3977 * indent.c (compute_motion, Fcompute_motion):
3978 Use window_body_cols instead of window_box_text_cols.
3980 * frame.c (delete_frame): Call delete_all_subwindows with root
3983 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3985 * fns.c (Fputhash): Document return value.
3987 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3989 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3991 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3993 Cons<->int and similar integer overflow fixes (Bug#8794).
3995 Check for overflow when converting integer to cons and back.
3996 * charset.c (Fdefine_charset_internal, Fdecode_char):
3997 Use cons_to_unsigned to catch overflow.
3998 (Fencode_char): Use INTEGER_TO_CONS.
3999 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4000 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4001 * data.c (long_to_cons, cons_to_long): Remove.
4002 (cons_to_unsigned, cons_to_signed): New functions.
4003 These signal an error for invalid or out-of-range values.
4004 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4005 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4006 * font.c (Ffont_variation_glyphs):
4007 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4008 * lisp.h: Include <intprops.h>.
4009 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4010 (cons_to_signed, cons_to_unsigned): New decls.
4011 (long_to_cons, cons_to_long): Remove decls.
4012 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4013 (Fprimitive_undo): Use CONS_TO_INTEGER.
4014 * xfns.c (Fx_window_property): Likewise.
4015 * xselect.c: Include <limits.h>.
4016 (x_own_selection, selection_data_to_lisp_data):
4017 Use INTEGER_TO_CONS.
4018 (x_handle_selection_request, x_handle_selection_clear)
4019 (x_get_foreign_selection, Fx_disown_selection_internal)
4020 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4021 (lisp_data_to_selection_data): Use cons_to_unsigned.
4022 (x_fill_property_data): Use cons_to_signed.
4023 Report values out of range.
4025 Check for buffer and string overflow more precisely.
4026 * buffer.h (BUF_BYTES_MAX): New macro.
4027 * lisp.h (STRING_BYTES_MAX): New macro.
4028 * alloc.c (Fmake_string):
4029 * character.c (string_escape_byte8):
4030 * coding.c (coding_alloc_by_realloc):
4031 * doprnt.c (doprnt):
4032 * editfns.c (Fformat):
4034 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4035 since they may not be the same number.
4036 * editfns.c (Finsert_char):
4037 * fileio.c (Finsert_file_contents):
4038 Likewise for BUF_BYTES_MAX.
4040 * image.c: Use ptrdiff_t, not int, for sizes.
4041 (slurp_file): Switch from int to ptrdiff_t.
4043 (slurp_file): Check that file size fits in both size_t (for
4044 malloc) and ptrdiff_t (for sanity and safety).
4046 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4047 if b->modtime has its maximal value.
4049 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4051 Don't assume time_t can fit into int.
4052 * buffer.h (struct buffer.modtime): Now time_t, not int.
4053 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4054 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4056 Minor fixes for signed vs unsigned integers.
4057 * character.h (MAYBE_UNIFY_CHAR):
4058 * charset.c (maybe_unify_char):
4059 * keyboard.c (read_char, reorder_modifiers):
4060 XINT -> XFASTINT, since the integer must be nonnegative.
4061 * ftfont.c (ftfont_spec_pattern):
4062 * keymap.c (access_keymap, silly_event_symbol_error):
4063 XUINT -> XFASTINT, since the integer must be nonnegative.
4064 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4065 since it makes no difference and we prefer signed.
4066 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4067 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4070 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4072 * window.h (Fwindow_frame): Declare.
4074 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4076 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4077 (SPARE_MEMORY): Always define.
4078 (LARGE_REQUEST): Remove.
4079 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4081 2011-06-06 Martin Rudalics <rudalics@gmx.at>
4083 * lisp.h: Move EXFUNS for Fframe_root_window,
4084 Fframe_first_window and Fset_frame_selected_window to window.h.
4086 * window.h: Move EXFUNS for Fframe_root_window,
4087 Fframe_first_window and Fset_frame_selected_window here from
4090 * frame.c (Fwindow_frame, Fframe_first_window)
4091 (Fframe_root_window, Fframe_selected_window)
4092 (Fset_frame_selected_window): Move to window.c.
4093 (Factive_minibuffer_window): Move to minibuf.c.
4094 (Fother_visible_frames_p): New function.
4096 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4098 * window.c (decode_window, decode_any_window): Move up in code.
4099 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4100 (inhibit_frame_unsplittable): Remove unused variable.
4101 (Fwindow_buffer): Move up and rewrite doc-string.
4102 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4103 (Fwindow_prev): New functions.
4104 (Fwindow_frame): Move here from frame.c. Accept any window as
4106 (Fframe_root_window, Fframe_first_window)
4107 (Fframe_selected_window): Move here from frame.c. Accept frame
4108 or arbitrary window as argument. Update doc-strings.
4109 (Fminibuffer_window): Move up in code.
4110 (Fwindow_minibuffer_p): Move up in code and simplify.
4111 (Fset_frame_selected_window): Move here from frame.c.
4113 (Fselected_window, select_window, Fselect_window): Move up in
4114 code. Minor doc-string fixes.
4116 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4118 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4119 Do not assume that spare memory exists; that assumption is valid
4120 only if SYSTEM_MALLOC.
4121 (LARGE_REQUEST): New macro, so that the issue of large requests
4122 is separated from the issue of spare memory.
4124 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4126 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4129 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4131 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4134 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4136 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4138 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4140 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4141 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4143 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
4145 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4147 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
4149 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4150 (x_clipboard_manager_save): Add return value.
4151 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4153 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4154 Obey Vx_select_enable_clipboard_manager. Catch errors in
4155 x_clipboard_manager_save (Bug#8779).
4156 (Vx_select_enable_clipboard_manager): New variable.
4157 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4159 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4161 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4163 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4165 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4166 in the current matrix if keep_current_p is non-zero.
4168 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4170 * bidi.c (bidi_level_of_next_char): Fix last change.
4172 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4174 Support bidi reordering of text covered by display properties.
4176 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4177 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4178 (bidi_cache_search, bidi_cache_iterator_state)
4179 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4180 (bidi_level_of_next_char, bidi_move_to_visually_next):
4181 Support character positions inside a run of characters covered by a
4183 (bidi_paragraph_init, bidi_resolve_explicit_1)
4184 (bidi_level_of_next_char): Call bidi_fetch_char and
4185 bidi_fetch_char_advance instead of FETCH_CHAR and
4187 (bidi_init_it): Initialize new members.
4188 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4190 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4191 instead of using explicit *_CHAR codes.
4192 (bidi_resolve_explicit, bidi_resolve_weak):
4193 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4194 bidirectional text is supported only in multibyte buffers.
4195 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4196 it to initialize the frame_window_p member of struct bidi_it.
4197 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4198 (bidi_resolve_explicit, bidi_resolve_weak)
4199 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4200 bidi_it->nchars is non-positive.
4201 (bidi_level_of_next_char): Don't try to lookup the cache for the
4202 next/previous character if nothing is cached there yet, or if we
4203 were just reseat()'ed to a new position.
4205 * xdisp.c (set_cursor_from_row): Set start and stop points
4206 according to the row's direction when priming the loop that looks
4207 for the glyph on which to display cursor.
4208 (single_display_spec_intangible_p): Function deleted.
4209 (display_prop_intangible_p): Reimplement to call
4210 handle_display_spec instead of single_display_spec_intangible_p.
4211 Accept 3 additional arguments needed by handle_display_spec.
4212 This fixes incorrect cursor motion across display property with complex
4213 values: lists, `(when COND...)' forms, etc.
4214 (single_display_spec_string_p): Support property values that are
4215 lists with the argument STRING its top-level element.
4216 (display_prop_string_p): Fix the condition for processing a
4217 property that is a list to be consistent with handle_display_spec.
4218 (handle_display_spec): New function, refactored from the
4219 last portion of handle_display_prop.
4220 (compute_display_string_pos): Accept additional argument
4221 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4222 value of a `display' property is a "replacing spec".
4223 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4224 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4225 the display property, but just return a value indicating whether
4226 the display property will replace the characters it covers.
4227 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4228 frame_window_p members of struct bidi_it.
4229 (compute_display_string_pos, compute_display_string_end):
4231 (push_it): Accept second argument POSITION, where pop_it should
4232 jump to continue iteration.
4233 (reseat_1): Initialize bidi_it.disp_pos.
4235 * keyboard.c (adjust_point_for_property): Adjust the call to
4236 display_prop_intangible_p to its new signature.
4238 * dispextern.h (struct bidi_it): New member frame_window_p.
4239 (bidi_init_it): Update prototypes.
4240 (display_prop_intangible_p): Update prototype.
4241 (compute_display_string_pos, compute_display_string_end):
4243 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4246 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4248 Malloc failure behavior now depends on size of allocation.
4249 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4250 * lisp.h: Change signatures accordingly.
4251 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4252 All callers changed. (Bug#8762)
4254 * gnutls.c: Use Emacs's memory allocators.
4255 Without this change, the gnutls library would invoke malloc etc.
4256 directly, which causes problems on non-SYNC_INPUT hosts, and which
4257 runs afoul of improving memory_full behavior. (Bug#8761)
4258 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4259 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4260 xfree instead of the default malloc, realloc, free.
4261 (Fgnutls_boot): No need to check for memory allocation failure,
4262 since xmalloc does that for us.
4264 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4265 * category.c (hash_get_category_set):
4266 * ccl.c (ccl_driver):
4267 * charset.c (Fdefine_charset_internal):
4268 * charset.h (struct charset.hash_index):
4269 * composite.c (get_composition_id, gstring_lookup_cache)
4270 (composition_gstring_put_cache):
4271 * composite.h (struct composition.hash_index):
4272 * dispextern.h (struct image.hash):
4273 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4274 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4275 (hashfn_equal, hashfn_user_defined, make_hash_table)
4276 (maybe_resize_hash_table, hash_lookup, hash_put)
4277 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4278 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4279 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4280 * image.c (make_image, search_image_cache, lookup_image)
4281 (xpm_put_color_table_h):
4282 * lisp.h (struct Lisp_Hash_Table):
4283 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4284 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4285 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4286 * alloc.c (allocate_vectorlike):
4287 Check for overflow in vector size calculations.
4288 * ccl.c (ccl_driver):
4289 Check for overflow when converting EMACS_INT to int.
4290 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4291 need to be updated by these changes.
4292 * fns.c (make_hash_table, maybe_resize_hash_table):
4293 Check for integer overflow with large hash tables.
4294 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4295 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4296 (SXHASH_REDUCE): New macro.
4297 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4298 Use it instead of discarding useful hash info with large hash values.
4299 (sxhash_float): New function.
4300 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4301 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4302 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4303 Rewrite to use FIXNUM_BITS, as this simplifies things.
4304 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4305 Adjust signatures to match updated version of code.
4306 (consing_since_gc): Now EMACS_INT, since a single hash table can
4307 use more than INT_MAX bytes.
4309 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4311 Make it possible to build with GCC-4.6+ -O2 -flto.
4313 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4315 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4317 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4318 Call minibuffer-inactive-mode.
4320 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4322 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4323 Update dependencies.
4325 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4327 * data.c (init_data): Remove code for UTS, this system is not
4330 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4332 Don't force ./temacs to start in terminal mode.
4334 * frame.c (make_initial_frame): Initialize faces in all cases, not
4335 only when CANNOT_DUMP is defined.
4336 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4338 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4340 * dispnew.c (add_window_display_history): Use const for the string
4341 pointer. Remove declaration, not needed.
4343 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4345 Use 'inline', not 'INLINE'.
4346 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4347 * alloc.c, fontset.c (INLINE): Remove.
4348 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4349 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4350 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4351 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4352 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4354 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4356 Make it possible to run ./temacs.
4358 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4359 syms_of_callproc does the same thing. Remove test for
4360 "initialized", do it in the caller.
4361 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4363 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4365 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4366 (read_minibuf): Use get_minibuffer.
4367 (syms_of_minibuf): Use DEFSYM.
4368 (Qmetadata): New var.
4369 * data.c (Qbuffer): Don't make it static.
4370 (syms_of_data): Use DEFSYM.
4372 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4374 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4375 (CCL_CODE_MIN): New macro.
4377 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4379 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4381 * eval.c (Qdebug): Now static.
4382 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4383 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4384 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4386 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4388 * image.c: Various fixes to ImageMagick code comments.
4389 (Fimagemagick_types): Doc fix.
4391 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4393 Minor fixes prompted by GCC 4.6.0 warnings.
4395 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4397 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4398 (x_clipboard_manager_save_all): Move extern decl to ...
4399 * xterm.h: ... here, so that it can be checked for consistency.
4401 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4403 * xselect.c (x_clipboard_manager_save_frame)
4404 (x_clipboard_manager_save_all): New functions.
4405 (Fx_clipboard_manager_save): Lisp function deleted.
4407 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4408 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4410 * xterm.h: Update prototype.
4412 2011-05-28 William Xu <william.xwl@gmail.com>
4414 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4417 2011-05-28 Jim Meyering <meyering@redhat.com>
4419 Avoid a sign-extension bug in crypto_hash_function.
4420 * fns.c (to_uchar): Define.
4421 (crypto_hash_function): Use it to convert some newly-signed
4422 variables to unsigned, to avoid sign-extension bugs. For example,
4423 without this change, (md5 "truc") would evaluate to
4424 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4425 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4426 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4428 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4430 Integer overflow fixes.
4432 * dbusbind.c: Serial number integer overflow fixes.
4433 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4434 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4435 to hold a serial number that is too large for a fixnum.
4436 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4437 Check for serial numbers out of range. Decode any serial number
4438 that was so large that it became a float. (Bug#8722)
4440 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4441 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4442 Use XFASTINT rather than XUINT when numbers are nonnegative.
4443 (xd_append_arg, Fdbus_method_return_internal):
4444 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4445 arguments, check that Lisp number is nonnegative, rather than
4446 silently wrapping negative numbers around. (Bug#8722)
4447 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4450 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4452 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4454 ccl: add integer overflow checks
4455 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4456 (IN_INT_RANGE): New macros.
4457 (ccl_driver): Use them to check for integer overflow when
4458 decoding a CCL program. Many of the new checks are whether XINT (x)
4459 fits in int; it doesn't always, on 64-bit hosts. The new version
4460 doesn't catch all possible integer overflows, but it's an
4461 improvement. (Bug#8719)
4463 * alloc.c (make_event_array): Use XINT, not XUINT.
4464 There's no need for unsigned here.
4466 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4467 This follows up to the 2011-05-06 change that substituted uintptr_t
4468 for EMACS_INT. This case wasn't caught back then.
4470 Rework Fformat to avoid integer overflow issues.
4471 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4472 now (part of C89). Include <verify.h>.
4473 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4474 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4475 (Fformat): Avoid the prepass trying to compute sizes; it was only
4476 approximate and thus did not catch overflow reliably. Instead, walk
4477 through the format just once, formatting and computing sizes as we go,
4478 checking for integer overflow at every step, and allocating a larger
4479 buffer as needed. Keep track separately whether the format is
4480 multibyte. Keep only the most-recently calculated precision, rather
4481 than them all. Record whether each argument has been converted to
4482 string. Use EMACS_INT, not int, for byte and char and arg counts.
4483 Support field widths and precisions larger than INT_MAX. Avoid
4484 sprintf's undefined behavior with conversion specifications such as %#d
4485 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4486 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4487 formatting out-of-range floating point numbers with int
4490 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4492 * data.c: Avoid integer truncation in expressions involving floats.
4493 * data.c: Include <intprops.h>.
4494 (arith_driver): When there's an integer overflow in an expression
4495 involving floating point, convert the integers to floating point
4496 so that the resulting value does not suffer from catastrophic
4497 integer truncation. For example, on a 64-bit host (* 4
4498 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4499 Do not rely on undefined behavior after integer overflow.
4501 merge count_size_as_multibyte, parse_str_to_multibyte
4502 * character.c, character.h (count_size_as_multibyte):
4503 Rename from parse_str_to_multibyte; all uses changed.
4504 Check for integer overflow.
4505 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4506 since it's now a duplicate of the other. This is more of
4507 a character than a buffer op, so better that it's in character.c.
4508 * fns.c, print.c: Adjust to above changes.
4510 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4512 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4514 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4516 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4517 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4518 (x_clipboard_manager_save): Now static.
4519 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4521 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4522 (crypto_hash_function): Now static.
4523 Fix pointer signedness problems. Avoid unnecessary initializations.
4525 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4527 * termhooks.h (Vselection_alist): Make it terminal-local.
4529 * terminal.c (create_terminal): Initialize it.
4531 * xselect.c: Support for clipboard managers.
4532 (Vselection_alist): Move to termhooks.h as terminal-local var.
4533 (LOCAL_SELECTION): New macro.
4534 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4535 (symbol_to_x_atom): Remove gratuitous arg.
4536 (x_handle_selection_request, lisp_data_to_selection_data)
4537 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4538 (x_own_selection, x_get_local_selection, x_convert_selection):
4539 New arg, specifying work frame. Use terminal-local Vselection_alist.
4540 (some_frame_on_display): Delete unused function.
4541 (Fx_own_selection_internal, Fx_get_selection_internal)
4542 (Fx_disown_selection_internal, Fx_selection_owner_p)
4543 (Fx_selection_exists_p): New optional frame arg.
4544 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4545 (x_handle_selection_clear): Don't treat other terminals with the
4546 same keyboard specially. Use the terminal-local Vselection_alist.
4547 (x_clear_frame_selections): Use Frun_hook_with_args.
4549 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4551 * xterm.h: Add support for those atoms.
4553 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4555 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4556 (converted_selections, conversion_fail_tag): New global variables.
4557 (x_selection_request_lisp_error): Free the above.
4558 (x_get_local_selection): Remove unnecessary code.
4559 (x_reply_selection_request): Args changed; handle arbitrary array
4560 of converted selections stored in converted_selections.
4561 Separate the XChangeProperty and SelectionNotify steps.
4562 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4563 (x_convert_selection): New function.
4564 (x_handle_selection_event): Simplify.
4565 (x_get_foreign_selection): Don't ignore incoming requests while
4566 waiting for an answer; this will fail when we implement
4567 SAVE_TARGETS, and seems unnecessary anyway.
4568 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4569 (Vx_sent_selection_functions): Doc fix.
4571 2011-05-26 Leo Liu <sdl.web@gmail.com>
4573 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4575 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4577 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4579 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4580 for fringe update if it has periodic bitmap.
4581 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4582 and fringe_bitmap_periodic_p.
4584 * fringe.c (get_fringe_bitmap_data): New function.
4585 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4586 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4587 row. Mark glyph row for fringe update if periodicity changed.
4589 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4590 for fringe update unless it has periodic bitmap.
4592 2011-05-25 Kenichi Handa <handa@m17n.org>
4594 * xdisp.c (get_next_display_element): Set correct it->face_id for
4595 a static composition.
4597 2011-05-24 Leo Liu <sdl.web@gmail.com>
4600 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4602 * fns.c (crypto_hash_function, Fsha1): New function.
4603 (Fmd5): Use crypto_hash_function.
4604 (syms_of_fns): Add Ssha1.
4606 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4608 * gnutls.c: Remove unused macros.
4609 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4610 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4611 Remove macros that are defined and never used.
4612 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4614 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4616 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4617 (Fx_get_selection_internal): Minor cleanup.
4618 (Fx_own_selection_internal): Rename arguments for consistency with
4621 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4623 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4625 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4627 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4629 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4631 * dispnew.c (scrolling_window): Don't exclude the case that the
4632 last enabled row in the desired matrix touches the bottom boundary.
4634 2011-05-21 Glenn Morris <rgm@gnu.org>
4636 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4637 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4638 and add some more files.
4640 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4642 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4643 report_file_error introduced by the change from 2011-05-07.
4645 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4647 * systime.h (Time): Define only if emacs is defined.
4648 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4649 where the include path doesn't have X11/X.h by default. See
4650 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4652 2011-05-20 Kenichi Handa <handa@m17n.org>
4654 * composite.c (find_automatic_composition): Fix previous change.
4656 2011-05-20 Glenn Morris <rgm@gnu.org>
4658 * lisp.mk: New file, split from Makefile.in.
4659 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4660 (shortlisp): Remove.
4661 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4663 2011-05-19 Glenn Morris <rgm@gnu.org>
4665 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4666 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4667 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4668 (lisp): Set the order to that of loadup.el.
4669 (shortlisp): Make it a copy of $lisp.
4670 (SOME_MACHINE_LISP): Remove.
4671 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4672 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4674 2011-05-18 Kenichi Handa <handa@m17n.org>
4676 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4677 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4678 (find_automatic_composition): Mostly rewrite for efficiency.
4680 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4682 * makefile.w32-in: Update dependencies.
4684 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4686 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4687 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4689 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4691 Fix some integer overflow issues, such as string length overflow.
4693 * insdel.c (count_size_as_multibyte): Check for string overflow.
4695 * character.c (lisp_string_width): Check for string overflow.
4696 Use EMACS_INT, not int, for string indexes and lengths; in
4697 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4698 the resulting string length overflows an EMACS_INT; instead,
4699 report a string overflow if no precision given. When checking for
4700 precision exhaustion, use a check that cannot possibly have
4701 integer overflow. (Bug#8675)
4702 * character.h (lisp_string_width): Adjust to new signature.
4704 * alloc.c (string_overflow): New function.
4705 (Fmake_string): Use it. This doesn't change behavior, but saves
4706 a few bytes and will simplify future changes.
4707 * character.c (string_escape_byte8): Likewise.
4708 * lisp.h (string_overflow): New decl.
4710 Fixups, following up to the user-interface timestamp change.
4711 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4712 for UI timestamps, instead of unsigned long.
4713 * msdos.c (mouse_get_pos): Likewise.
4714 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4715 * w32gui.h (Time): Define by including "systime.h" rather than by
4716 declaring it ourselves. (Bug#8664)
4718 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4719 * image.c (clear_image_cache): Likewise.
4721 * term.c (term_mouse_position): Don't assume time_t wraparound.
4723 Be more systematic about user-interface timestamps.
4724 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4725 and sometimes 'EMACS_UINT', to represent these timestamps.
4726 This change causes it to use 'Time' uniformly, as that's what X uses.
4727 This makes the code easier to follow, and makes it easier to catch
4728 integer overflow bugs such as Bug#8664.
4729 * frame.c (Fmouse_position, Fmouse_pixel_position):
4730 Use Time, not unsigned long, for user-interface timestamps.
4731 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4732 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4733 * keyboard.h (last_event_timestamp): Likewise.
4734 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4735 * menu.h (xmenu_show): Likewise.
4736 * term.c (term_mouse_position): Likewise.
4737 * termhooks.h (struct input_event.timestamp): Likewise.
4738 (struct terminal.mouse_position_hook): Likewise.
4739 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4740 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4741 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4742 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4744 * menu.h, termhooks.h: Include "systime.h", for Time.
4746 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4747 Don't assume that the difference between two unsigned long values
4748 can fit into an integer. At this point, we know button_down_time
4749 <= event->timestamp, so the difference must be nonnegative, so
4750 there's no need to cast the result if double-click-time is
4751 nonnegative, as it should be; check that it's nonnegative, just in
4752 case. This bug is triggered when events are more than 2**31 ms
4753 apart (about 25 days). (Bug#8664)
4755 * xselect.c (last_event_timestamp): Remove duplicate decl.
4756 (x_own_selection): Remove needless cast to unsigned long.
4758 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4759 that always fit in int. Use a sentinel instead of a counter, to
4760 avoid a temp and to allay GCC's concerns about possible int overflow.
4761 * frame.h (struct frame): Use int for menu_bar_items_used
4762 instead of EMACS_INT, since it always fits in int.
4764 * menu.c (grow_menu_items): Check for int overflow.
4766 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4768 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4769 Before, the code was not consistent. These values cannot exceed
4770 2**31 - 1 so there's no need to make them unsigned.
4771 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4772 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4773 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4775 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4777 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4778 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4779 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4780 presumably because the widths might not match.
4782 * window.c (size_window): Avoid needless test at loop start.
4784 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4786 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4788 2011-05-12 Drew Adams <drew.adams@oracle.com>
4790 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4792 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4794 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4795 `width' to `bar_area_x' and `bar_area_width', respectively.
4796 (x_scroll_run): Take account of fringe background extension.
4798 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4799 Rename local vars `left' and `width' to `bar_area_x' and
4800 `bar_area_width', respectively.
4801 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4802 background extension.
4804 2011-05-10 Jim Meyering <meyering@redhat.com>
4806 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4808 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4810 * image.c (Finit_image_library): Return t for built-in image types,
4811 like pbm and xbm. (Bug#8640)
4813 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4815 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4817 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4819 * w32console.c (Fset_screen_color): Doc fix.
4820 (Fget_screen_color): New function.
4821 (syms_of_ntterm): Defsubr it.
4823 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4824 unlink the temporary file if Fcall_process didn't create it in the
4826 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4827 child process will be redirected to a file specified with `:file'.
4828 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4829 cue to call_process_cleanup not to close that handle.
4831 2011-05-07 Ben Key <bkey76@gmail.com>
4833 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4834 one of two shell specific rules, either bootstrap-temacs-CMD or
4835 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4836 to the previous implementation of the bootstrap-temacs rule.
4837 The bootstrap-temacs-CMD rule is similar to the previous
4838 implementation of the bootstrap-temacs rule except that it
4839 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4842 These changes, along with some changes to nt/configure.bat,
4843 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4844 earlier fix to add support for --cflags and --ldflags options
4845 that include quotes so that it works whether make uses cmd or
4848 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4850 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4851 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4853 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4854 a string. Handle both cases.
4855 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4856 (Fdbus_register_method): Use Qinvalid_function.
4858 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4860 * makefile.w32-in: Update dependencies.
4861 (LISP_H): Add inttypes.h and stdin.h.
4862 (PROCESS_H): Add unistd.h.
4864 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4866 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4867 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4869 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4871 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4873 * term.c (vfatal): Remove stray call to va_end.
4874 It's not needed and the C Standard doesn't allow it here anyway.
4876 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4877 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4879 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4882 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4884 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4886 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4888 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4890 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4892 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4893 * charset.c (Fdefine_charset_internal): Don't initialize
4894 charset.code_space[15]. The value was garbage, on hosts with
4895 32-bit int (Bug#8600).
4897 * lread.c (read_integer): Be more consistent with string-to-number.
4898 Use string_to_number to do the actual conversion; this avoids
4899 rounding errors and fixes some other screwups. Without this fix,
4900 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4901 (digit_to_number): Move earlier, for benefit of read_integer.
4902 Return -1 if the digit is out of range for the base, -2 if it is
4903 not a digit in any supported base. (Bug#8602)
4905 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4907 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4908 to match comment at start of function. This also removes a
4909 GCC warning about overflow in a 32+64-bit port.
4911 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4913 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4914 Reported by Stefan Monnier in
4915 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4916 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4917 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4919 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4920 (EMACS_UINTPTR): Likewise, with uintptr_t.
4922 * lisp.h: Prefer 64-bit EMACS_INT if available.
4923 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4924 on 32-bit hosts that have 64-bit int, so that they can access
4926 However, temporarily disable this change unless the temporary
4927 symbol WIDE_EMACS_INT is defined.
4929 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4931 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4932 This removes an assumption that EMACS_INT and long are the same
4933 width as pointers. The assumption is true for Emacs porting targets
4934 now, but we want to make other targets possible.
4935 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4936 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4937 In the rest of the code, change types of integers that hold casted
4938 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4939 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4940 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4941 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4942 No need to cast type when ORing.
4943 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4944 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4945 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4946 assume EMACS_INT is the same width as char *.
4947 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4948 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4949 Remove no-longer-needed casts.
4950 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4951 (xg_tool_bar_help_callback, xg_make_tool_item):
4952 Use EMACS_INTPTR to hold an integer
4953 that will be cast to void *; this can avoid a GCC warning
4954 if EMACS_INT is not the same width as void *.
4955 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4956 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4957 (current_message_1, set_message_1):
4958 Use a local to convert to proper width without a cast.
4959 * xmenu.c (dialog_selection_callback): Likewise.
4961 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4962 Also, don't assume VALBITS / RAND_BITS is less than 5,
4963 and don't rely on undefined behavior when shifting a 1 left into
4965 * lisp.h (get_random): Change signature to match.
4967 * lread.c (hash_string): Use size_t, not int, for hash computation.
4968 Normally we prefer signed values; but hashing is special, because
4969 it's better to use unsigned division on hash table sizes so that
4970 the remainder is nonnegative. Also, size_t is the natural width
4971 for hashing into memory. The previous code used 'int', which doesn't
4972 retain enough info to hash well into very large tables.
4973 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4975 * dbusbind.c: Don't possibly lose pointer info when converting.
4976 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4977 Use XPNTR rather than XHASH, so that the high-order bits of
4978 the pointer aren't lost when converting through void *.
4980 * eval.c (Fautoload): Don't double-shift a pointer.
4982 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4984 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4986 * gnutls.c (DEF_GNUTLS_FN):
4987 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4989 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4991 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4994 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4996 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4997 New version that can reserve upto 2GB of heap space.
4999 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
5001 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5003 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5005 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5006 `gnutls_certificate_set_x509_key_file'.
5008 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
5010 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5011 Update dependencies.
5013 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5015 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5016 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5017 Remove unused parameter `fildes'.
5018 * process.c (read_process_output, send_process): Don't pass it.
5020 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5022 Fix previous change: the library cache is defined in w32.c.
5023 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5024 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5026 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5028 Implement dynamic loading of GnuTLS on Windows.
5030 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5031 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5032 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5035 * gnutls.c (Qgnutls_dll): Define.
5036 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5037 (gnutls_*): Declare function pointers.
5038 (init_gnutls_functions): New function to initialize function pointers.
5039 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5040 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5041 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5042 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5043 (emacs_gnutls_write, emacs_gnutls_read)
5044 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5045 (Fgnutls_available_p): New function.
5046 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5047 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5048 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5050 * image.c: Include w32.h.
5051 (Vimage_type_cache): Delete.
5052 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5053 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5054 (w32_delayed_load): Move to w32.c.
5056 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5058 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5059 (w32_delayed_load): Move from image.c. When loading a library, record
5060 its filename in the :loaded-from property of the library id.
5061 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5062 Initialize and staticpro them.
5063 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5065 * process.c: Include lisp.h before w32.h, not after.
5066 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5067 instead of gnutls_record_check_pending.
5069 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5071 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5073 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5074 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5077 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5079 * xterm.c (x_set_frame_alpha): Do not set property on anything
5080 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5082 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5084 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5086 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5088 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5089 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5090 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5091 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5092 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5093 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5094 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5095 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5096 (Qgnutls_bootprop_callbacks_verify): Make static.
5098 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5100 * callproc.c: Indentation fixup.
5102 * sysdep.c (wait_for_termination_1): Make static.
5103 (wait_for_termination, interruptible_wait_for_termination):
5104 Move after wait_for_termination_1.
5106 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5108 * sysdep.c (interruptible_wait_for_termination): New function
5109 which is like wait_for_termination, but allows keyboard
5112 * callproc.c (Fcall_process): Add (:file "file") as an option for
5114 (Fcall_process_region): Ditto.
5116 2011-04-30 Eli Zaretskii <eliz@gnu.org>
5118 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5119 rather than `XVECTOR (FOO)->size'.
5121 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5122 inttypes.h, as a gnulib replacement is used if it not available in
5125 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5127 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5128 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5129 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5131 * coding.c (coding_alloc_by_realloc): Error out if destination
5132 will grow beyond MOST_POSITIVE_FIXNUM.
5133 (decode_coding_emacs_mule): Abort if there isn't enough place in
5134 charbuf for the composition carryover bytes. Reserve an extra
5135 space for up to 2 characters produced in a loop.
5136 (decode_coding_iso_2022): Abort if there isn't enough place in
5137 charbuf for the composition carryover bytes.
5139 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5141 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5142 aborting when %lld or %lll format is passed.
5143 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5144 %llo or %llx format is passed. (Bug#8545)
5146 * window.c (window_scroll_line_based): Use a marker instead of
5147 simple variables to record original value of point. (Bug#7952)
5149 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5150 produced by %s or %c overflows available buffer space. (Bug#8545)
5152 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5154 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5155 (SIZE_MAX): Move defn after all includes, as they might #define it.
5157 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5159 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5161 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5163 * keyboard.c (Qdelayed_warnings_hook): Define.
5164 (command_loop_1): Run `delayed-warnings-hook'
5165 if Vdelayed_warnings_list is non-nil.
5166 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5167 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5169 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5171 * doprnt.c (doprnt): Don't return value smaller than the buffer
5172 size if the message was truncated. (Bug#8545).
5174 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5176 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5177 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5179 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5181 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5183 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5185 * makefile.w32-in: Update dependencies.
5187 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5189 Improve `doprnt' and its usage. (Bug#8545)
5190 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5191 `format_end'. Remove support for %l as a conversion specifier.
5192 Don't use xrealloc. Improve diagnostics when the %l size modifier
5193 is used. Update the commentary.
5195 * eval.c (verror): Simplify calculation of size_t.
5197 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5200 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5202 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5205 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5207 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5208 This makes this file independent of the recent pseudovector change.
5210 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5212 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5214 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5215 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5216 Remove unused local.
5217 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5219 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5220 GCC 4.6.0 optimizes based on type-based alias analysis.
5221 For example, if b is of type struct buffer * and v of type struct
5222 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5223 != &v->size, and therefore "v->size = 1; b->size = 2; return
5224 v->size;" must therefore return 1. This assumption is incorrect
5225 for Emacs, since it type-puns struct Lisp_Vector * with many other
5226 types. To fix this problem, this patch adds a new type struct
5227 vectorlike_header that documents the constraints on layout of vectors
5228 and pseudovectors, and helps optimizing compilers not get fooled
5229 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5230 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5231 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5233 (XSETPVECTYPE): Rewrite in terms of new macro.
5234 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5235 This is a bit clearer, and further avoids the possibility of
5236 undesirable aliasing.
5237 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5238 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5239 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5240 since Lisp_Subr is a special case (no "next" field).
5241 (ASIZE): Now uses header.size rather than size.
5242 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5243 to avoid the hassle of writing XVECTOR (foo)->header.size.
5244 (struct vectorlike_header): New type.
5245 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5246 object, to help avoid aliasing.
5247 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5248 (SUBRP): Likewise, since Lisp_Subr is a special case.
5249 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5250 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5251 (struct Lisp_Hash_Table): Combine first two members into a single
5252 struct vectorlike_header member. All uses of "size" and "next" members
5253 changed to be "header.size" and "header.next".
5254 * buffer.h (struct buffer): Likewise.
5255 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5256 * frame.h (struct frame): Likewise.
5257 * process.h (struct Lisp_Process): Likewise.
5258 * termhooks.h (struct terminal): Likewise.
5259 * window.c (struct save_window_data, struct saved_window): Likewise.
5260 * window.h (struct window): Likewise.
5261 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5262 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5263 * buffer.c (init_buffer_once): Likewise.
5264 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5266 * process.c (Fformat_network_address): Use local var for size,
5269 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5271 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5272 * data.c (atof): Remove decl; no longer used or needed.
5273 (digit_to_number): Move to lread.c.
5274 (Fstring_to_number): Use new string_to_number function, to be
5275 consistent with how the Lisp reader treats infinities and NaNs.
5276 Do not assume that floating-point numbers represent EMACS_INT
5277 without losing information; this is not true on most 64-bit hosts.
5278 Avoid double-rounding errors, by insisting on integers when
5279 parsing non-base-10 numbers, as the documentation specifies.
5280 * lisp.h (string_to_number): New decl, replacing ...
5281 (isfloat_string): Remove.
5282 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5283 (read1): Do not accept +. and -. as integers; this
5284 appears to have been a coding error. Similarly, do not accept
5285 strings like +-1e0 as floating point numbers. Do not report
5286 overflow for integer overflows unless the base is not 10 which
5287 means we have no simple and reliable way to continue.
5288 Break out the floating-point parsing into a new
5289 function string_to_number, so that Fstring_to_number parses
5290 floating point numbers consistently with the Lisp reader.
5291 (digit_to_number): Move here from data.c. Make it static inline.
5292 (E_CHAR, EXP_INT): Remove, replacing with ...
5293 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5294 (string_to_number): New function, replacing isfloat_string.
5295 This function checks for valid syntax and produces the resulting
5296 Lisp float number too. Rework it so that string-to-number
5297 no longer mishandles examples like "1.0e+". Use strtoumax,
5298 so that overflow for non-base-10 numbers is reported only when
5299 there's no portable and simple way to convert to floating point.
5301 * textprop.c (set_text_properties_1): Rewrite for clarity,
5302 and to avoid GCC warning about integer overflow.
5304 * intervals.h (struct interval): Use EMACS_INT for members
5305 where EMACS_UINT might cause problems. See
5306 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5307 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5308 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5310 (offset_intervals): Tell GCC not to worry about length overflow
5311 when negating a negative length.
5313 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5314 (overrun_check_free): Likewise.
5316 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5317 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5320 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5321 (gnutls_make_error): Rename local to avoid shadowing.
5322 (gnutls_emacs_global_deinit): ifdef out; not used.
5323 (Fgnutls_boot): Use const for pointer to readonly storage.
5324 Comment out unused local. Fix pointer signedness problems.
5326 * lread.c (openp): Don't stuff size_t into an 'int'.
5327 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5328 about possible signed overflow.
5330 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5331 (GDK_KEY_g): Don't define if already defined.
5332 (xg_prepare_tooltip): Avoid pointer signedness problem.
5333 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5335 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5336 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5338 * xfns.c (Fx_window_property): Simplify a bit,
5339 to make a bit faster and to avoid GCC 4.6.0 warning.
5340 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5342 * fns.c (internal_equal): Don't assume size_t fits in int.
5344 * alloc.c (compact_small_strings): Tighten assertion a little.
5346 Replace pEd with more-general pI, and fix some printf arg casts.
5347 * lisp.h (pI): New macro, generalizing old pEd macro to other
5348 conversion specifiers. For example, use "...%"pI"d..." rather
5349 than "...%"pEd"...".
5350 (pEd): Remove. All uses replaced with similar uses of pI.
5351 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5352 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5353 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5354 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5355 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5356 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5357 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5359 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5360 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5361 * print.c (safe_debug_print, print_object): Likewise.
5362 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5364 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5365 avoiding the 0 flag, which is not portable.
5366 * process.c (Fmake_network_process): Use pI to avoid cast.
5367 * region-cache.c (pp_cache): Likewise.
5368 * xdisp.c (decode_mode_spec): Likewise.
5369 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5370 behavior on 64-bit hosts with printf arg.
5371 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5372 (x_stop_queuing_selection_requests): Likewise.
5373 (x_get_window_property): Don't truncate byte count to an 'int'
5376 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5377 here, since it parses constructs like leading '-' and spaces,
5378 which are not wanted; and it overflows with large numbers.
5379 Instead, simply match F[0-9]+, which is what is wanted anyway.
5381 * alloc.c: Remove unportable assumptions about struct layout.
5382 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5383 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5384 (allocate_vectorlike, make_pure_vector): Use the new macros,
5385 plus offsetof, to remove unportable assumptions about struct layout.
5386 These assumptions hold on all porting targets that I know of, but
5387 they are not guaranteed, they're easy to remove, and removing them
5388 makes further changes easier.
5390 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5391 This doesn't fix a bug but makes the code clearer.
5392 (string_overrun_cookie): Now const. Use initializers that
5393 don't formally overflow signed char, to avoid warnings.
5394 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5395 can cause Emacs to crash when string overrun checking is enabled.
5396 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5397 multiple of sizeof (EMACS_INT); it need not be, if
5398 alignof(EMACS_INT) < sizeof (EMACS_INT).
5399 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5401 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5403 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5405 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5407 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5408 supposed to be handshaking. (Bug#8556)
5409 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5411 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5413 * lisp.h (Qdebug): List symbol.
5414 * eval.c (Qdebug): Restore global linkage.
5415 * keyboard.c (debug-on-event): New variable.
5416 (handle_user_signal): Break into debugger when debug-on-event
5417 matches the current signal symbol.
5419 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5421 * alloc.c (check_sblock, check_string_bytes)
5422 (check_string_free_list): Convert to standard C.
5424 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5426 * w32.c (emacs_gnutls_push): Fix typo.
5428 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5430 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5431 "cast to pointer from integer of different size".
5433 Improve doprnt and its use in verror. (Bug#8545)
5434 * doprnt.c (doprnt): Document the set of format control sequences
5435 supported by the function. Use SAFE_ALLOCA instead of always
5438 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5439 is one byte too soon. Don't use xrealloc; instead xfree and
5442 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5444 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5447 * gnutls.c: Renamed global_initialized to
5448 gnutls_global_initialized. Added internals for the
5449 :verify-hostname-error, :verify-error, and :verify-flags
5450 parameters of `gnutls-boot' and documented those parameters in the
5451 docstring. Start callback support.
5452 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5453 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5454 on error. Return error code.
5455 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5456 (emacs_gnutls_read): Likewise.
5457 (Fgnutls_boot): Return handshake error code.
5458 (emacs_gnutls_handle_error): New function.
5459 (wsaerror_to_errno): Likewise.
5461 * w32.h (emacs_gnutls_pull): Add prototype.
5462 (emacs_gnutls_push): Likewise.
5464 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5465 (emacs_gnutls_push): Likewise.
5467 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5469 * process.c (wait_reading_process_output): Check if GnuTLS
5470 buffered some data internally if no FDs are set for TLS
5473 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5474 (LIBS): Link to USER_LIBS.
5475 ($(BLD)/gnutls.$(0)): New target.
5477 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5479 * xdisp.c (handle_single_display_spec): Rename the
5480 display_replaced_before_p argument into display_replaced_p, to
5481 make it consistent with the commentary. Fix typos in the
5484 * textprop.c (syms_of_textprop): Remove dead code.
5485 (copy_text_properties): Delete obsolete commentary about an
5486 interface that was deleted long ago. Fix typos in the description
5489 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5490 to changes in oldXMenu/XMenu.h from 2011-04-16.
5491 <menu_help_message, prev_menu_help_message>: Constify.
5492 (IT_menu_make_room): menu->help_text is now `const char **';
5495 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5496 to changes in oldXMenu/XMenu.h from 2011-04-16.
5497 (struct XMenu): Declare `help_text' `const char **'.
5499 * xfaces.c <Qunspecified>: Make extern again.
5501 * syntax.c: Include sys/types.h before including regex.h, as
5504 * doc.c (get_doc_string): Improve the format passed to `error'.
5506 * doprnt.c (doprnt): Improve commentary.
5508 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5510 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5513 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5514 changes in globals.h immediately force recompilation.
5515 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5516 $(CURDIR)/s/ms-w32.h.
5517 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5519 * character.c (Fchar_direction): Function deleted.
5520 (syms_of_character): Don't defsubr it.
5521 <char-direction-table>: Deleted.
5523 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5525 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5526 * doprnt.c: Include limits.h.
5527 (SIZE_MAX): New macro.
5528 (doprnt): Return a size_t value. 2nd arg is now size_t.
5529 Many local variables are now size_t instead of int or unsigned.
5530 Improve overflow protection. Support `l' modifier for integer
5531 conversions. Support %l conversion. Don't assume an EMACS_INT
5532 argument for integer conversions and for %c.
5534 * lisp.h (doprnt): Restore prototype.
5536 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5539 * Makefile.in (base_obj): Add back doprnt.o.
5541 * deps.mk (doprnt.o): Add back prerequisites.
5542 (callint.o): Depend on character.h.
5544 * eval.c (internal_lisp_condition_case): Include the handler
5545 representation in the error message.
5546 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5547 when breaking from the loop.
5549 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5551 * callint.c (Fcall_interactively): When displaying error message
5552 about invalid control letter, pass the character's codepoint, not
5553 a pointer to its multibyte form. Improve display of the character
5554 in octal and display also its hex code.
5556 * character.c (char_string): Use %x to display the (unsigned)
5557 codepoint of an invalid character, to avoid displaying a bogus
5560 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5561 `error', not SYMBOL_NAME itself.
5563 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5564 character arguments to `error'.
5566 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5567 to `error' in error message about FINAL_CHAR argument. Make sure
5568 FINAL_CHAR is a character, and use %c when it is passed as
5569 argument to `error'.
5571 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5573 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5575 * w32.c: Include <time.h>.
5576 (sys_localtime): New function.
5578 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5580 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5582 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5584 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5586 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5589 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5591 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5592 gl_state.e_property when gl_state.object is Qt.
5594 * insdel.c (make_gap_larger): Remove limitation of buffer size
5597 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5599 * xdisp.c (lookup_glyphless_char_display)
5600 (produce_glyphless_glyph): Handle cons cell entry in
5601 glyphless-char-display.
5602 (Vglyphless_char_display): Document it.
5604 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5605 glyphless-char-display.
5607 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5609 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5611 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5613 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5614 definition for no-X builds.
5616 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5618 Static checks with GCC 4.6.0 and non-default toolkits.
5620 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5622 * process.c (keyboard_bit_set): Define only if SIGIO.
5623 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5624 (send_process): Repair possible setjmp clobbering.
5626 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5628 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5630 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5632 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5633 Define only if needed.
5635 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5636 by pacifying GCC about it. Maybe it's time to retire it?
5637 * xfaces.c (USG, __TIMEVAL__): Likewise.
5639 * dispextern.h (struct redisplay_interface): Rename param
5641 * termhooks.h (struct terminal): Likewise.
5642 * xterm.c (xembed_send_message): Likewise.
5644 * insdel.c (make_gap_smaller): Define only if
5645 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5647 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5650 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5651 so that we aren't warned about unused symbols.
5653 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5655 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5657 * xfns.c (x_real_positions): Mark locals as initialized.
5659 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5661 * xterm.c: Fix problems found by static analysis with other toolkits.
5662 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5663 (x_dispatch_event): Declare static if USE_GTK, and
5664 define if USE_GTK || USE_X_TOOLKIT.
5665 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5666 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5667 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5668 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5670 * xmenu.c (menu_help_callback): Pointer type fixes.
5671 Use const pointers when pointing at readonly data. Avoid pointer
5673 (FALSE): Remove unused macro.
5674 (update_frame_menubar): Remove unused decl.
5676 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5678 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5679 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5680 (single_menu_item): Rename local to avoid shadowing.
5682 * keyboard.c (make_lispy_event): Remove unused local var.
5684 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5685 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5687 * bitmaps: Change bitmaps from unsigned char back to the X11
5688 compatible char. Avoid the old compiler warnings about
5689 out-of-range initializers by using, for example, '\xab' rather
5692 * xgselect.c (xgselect_initialize): Check vs interface
5693 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5695 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5697 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5698 to read-only memory.
5700 * fns.c (vector): Remove; this old hack is no longer needed.
5702 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5704 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5706 * xrdb.c (x_load_resources): Omit unused local.
5708 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5709 (x_window): Rename locals to avoid shadowing.
5710 (USG): Use the kludged USG macro, to pacify gcc.
5712 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5713 (x_term_init): Remove local to avoid shadowing.
5715 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5717 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5718 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5720 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5722 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5724 Fix regex.c, syntax.c and friends for buffers > 2GB.
5725 * syntax.h (struct gl_state_s): Declare character position members
5728 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5730 * textprop.c (verify_interval_modification, interval_of):
5731 Declare arguments EMACS_INT.
5733 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5736 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5738 * indent.c (Fvertical_motion): Local variable it_start is now
5741 * regex.c (re_match, re_match_2, re_match_2_internal)
5742 (bcmp_translate, regcomp, regexec, print_double_string)
5743 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5744 (re_compile_pattern, re_exec): Declare arguments and local
5745 variables `size_t' and `ssize_t' and return values `regoff_t', as
5747 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5748 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5749 <compile_stack_type>: `size' and `avail' are now `size_t'.
5751 * regex.h <regoff_t>: Use ssize_t, not int.
5752 (re_search, re_search_2, re_match, re_match_2): Arguments that
5753 specify buffer/string position and length are now ssize_t and
5754 size_t. Return type is regoff_t.
5756 2011-04-16 Ben Key <bkey76@gmail.com>
5758 * nsfont.m: Fixed bugs in ns_get_family and
5759 ns_descriptor_to_entity that were caused by using free to
5760 deallocate memory blocks that were allocated by xmalloc (via
5761 xstrdup). This caused Emacs to crash when compiled with
5762 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5763 --enable-checking=xmallocoverrun). xfree is now used to
5764 deallocate these memory blocks.
5766 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5768 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5770 emacs_write: Accept and return EMACS_INT for sizes.
5771 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5773 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5774 Accept and return EMACS_INT.
5775 (emacs_gnutls_write): Return the number of bytes written on
5777 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5778 (emacs_read, emacs_write): Remove check for negative size, as the
5779 Emacs source code has been audited now.
5780 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5781 (emacs_read, emacs_write): Use it.
5782 * process.c (send_process): Adjust to the new signatures of
5783 emacs_write and emacs_gnutls_write. Do not attempt to store
5784 a byte offset into an 'int'; it might overflow.
5785 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5787 * sound.c: Don't assume sizes fit in 'int'.
5788 (struct sound_device.period_size, alsa_period_size):
5789 Return EMACS_INT, not int.
5790 (struct sound_device.write, vox_write, alsa_write):
5791 Accept EMACS_INT, not int.
5792 (wav_play, au_play): Use EMACS_INT to store sizes and to
5793 record read return values.
5795 2011-04-15 Ben Key <bkey76@gmail.com>
5797 * keyboard.c (Qundefined): Don't declare static since it is used
5799 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5800 static since they are used in nsfont.m.
5802 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5804 * process.c (Qprocessp): Don't declare static.
5805 * lisp.h (Qprocessp): Declare again.
5807 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5809 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5811 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5813 Improve C-level modularity by making more things 'static'.
5815 Don't publish debugger-only interfaces to other modules.
5816 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5817 (verify_bytepos, count_markers): Move decls to the only modules
5819 * region-cache.h (pp_cache): Likewise.
5820 * window.h (check_all_windows): Likewise.
5821 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5823 * sysdep.c (croak): Now static, if
5824 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5825 * syssignal.h (croak): Declare only if not static.
5827 * alloc.c (refill_memory_reserve): Now static if
5828 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5829 * lisp.h (refill_memory_reserve): Declare only if not static.
5831 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5832 Define only if USE_LUCID.
5834 * xrdb.c (x_customization_string, x_rm_string): Now static.
5836 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5837 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5839 * xdisp.c (draw_row_with_mouse_face): Now static.
5840 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5842 * window.h (check_all_windows): Mark externally visible.
5844 * window.c (window_deletion_count): Now static.
5846 * undo.c: Make symbols static if they're not exported.
5847 (last_undo_buffer, last_boundary_position, pending_boundary):
5850 * textprop.c (interval_insert_behind_hooks): Now static.
5851 (interval_insert_in_front_hooks): Likewise.
5853 * term.c: Make symbols static if they're not exported.
5854 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5855 (max_frame_lines, tty_set_terminal_modes):
5856 (tty_reset_terminal_modes, tty_turn_off_highlight):
5857 (get_tty_terminal): Now static.
5858 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5859 * termhooks.h (term_mouse_moveto): Do not declare if
5861 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5862 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5864 * sysdep.c: Make symbols static if they're not exported.
5865 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5867 (sigprocmask_set, full_mask): Remove; unused.
5868 (wait_debugging): Mark as visible.
5869 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5870 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5872 * syntax.c (syntax_temp): Define only if !__GNUC__.
5874 * sound.c (current_sound_device, current_sound): Now static.
5876 * search.c (searchbufs, searchbuf_head): Now static.
5878 * scroll.c (scroll_cost): Remove; unused.
5879 * dispextern.h (scroll_cost): Remove decl.
5881 * region-cache.h (pp_cache): Mark as externally visible.
5883 * process.c: Make symbols static if they're not exported.
5884 (process_tick, update_tick, create_process, chan_process):
5885 (Vprocess_alist, proc_buffered_char, datagram_access):
5886 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5887 (deactivate_process): Mark defn as static, as well as decl.
5888 * lisp.h (create_process): Remove decl.
5889 * process.h (chan_process, Vprocess_alist): Remove decls.
5891 * print.c: Make symbols static if they're not exported.
5892 (print_depth, new_backquote_output, being_printed, print_buffer):
5893 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5894 (print_interval, print_number_index, initial_stderr_stream):
5896 * lisp.h (Fprinc): Remove decl.
5897 (debug_output_compilation_hack): Mark as externally visible.
5899 * sysdep.c (croak): Move decl from here to syssignal.h.
5900 * syssignal.h (croak): Put it here, so the API can be checked when
5901 'croak' is called from dissociate_if_controlling_tty.
5903 * minibuf.c: Make symbols static if they're not exported.
5904 (minibuf_save_list, choose_minibuf_frame): Now static.
5905 * lisp.h (choose_minibuf_frame): Remove decl.
5907 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5909 * lread.c: Make symbols static if they're not exported.
5910 (read_objects, initial_obarray, oblookup_last_bucket_number):
5912 (make_symbol): Remove; unused.
5913 * lisp.h (initial_obarray, make_symbol): Remove decls.
5915 * keyboard.c: Make symbols static if they're not exported.
5916 (single_kboard, recent_keys_index, total_keys, recent_keys):
5917 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5918 (this_single_command_key_start, echoing, last_auto_save):
5919 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5920 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5921 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5922 (Vlispy_mouse_stem, double_click_count):
5924 (force_auto_save_soon): Define only if SIGDANGER.
5925 (ignore_mouse_drag_p): Now static if
5926 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5927 (print_help): Remove; unused.
5928 (stop_character, last_timer_event): Mark as externally visible.
5929 * keyboard.h (ignore_mouse_drag_p): Declare only if
5930 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5931 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5932 * lisp.h (echoing): Remove decl.
5933 (force_auto_save_soon): Declare only if SIGDANGER.
5934 * xdisp.c (redisplay_window): Simplify code, to make it more
5935 obvious that ignore_mouse_drag_p is not accessed if !defined
5936 USE_GTK && !defined HAVE_NS.
5938 * intervals.c: Make symbols static if they're not exported.
5939 (merge_properties_sticky, merge_interval_right, delete_interval):
5941 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5943 * insdel.c: Make symbols static if they're not exported.
5944 However, leave prepare_to_modify_buffer alone. It's never
5945 called from outside this function, but that appears to be a bug.
5946 (combine_after_change_list, combine_after_change_buffer):
5947 (adjust_after_replace, signal_before_change): Now static.
5948 (adjust_after_replace_noundo): Remove; unused.
5949 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5950 (signal_before_change): Remove decls.
5952 * indent.c (val_compute_motion, val_vmotion): Now static.
5954 * image.c: Make symbols static if they're not exported.
5955 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5957 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5958 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5960 * fringe.c (standard_bitmaps): Now static.
5961 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5963 * frame.c: Make symbols static if they're not exported.
5964 (x_report_frame_params, make_terminal_frame): Now static.
5965 (get_frame_param): Now static, unless HAVE_NS.
5966 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5967 (x_get_resource_string): Remove; not used.
5968 * frame.h (make_terminal_frame, x_report_frame_params):
5969 (x_get_resource_string); Remove decls.
5970 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5971 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5973 * font.c, fontset.c: Make symbols static if they're not exported.
5974 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5975 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5976 * font.c (font_close_object): Now static.
5977 * font.h (font_close_object): Remove.
5978 * fontset.c (FONTSET_OBJLIST): Remove.
5979 (free_realized_fontset) #if-0 the body, which does nothing.
5980 (face_suitable_for_char_p): #if-0, as it's never called.
5981 * fontset.h (face_suitable_for_char_p): Remove decl.
5982 * xfaces.c (face_at_string_position):
5983 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5984 since 0 is always ASCII.
5986 * fns.c (weak_hash_tables): Now static.
5988 * fileio.c: Make symbols static if they're not exported.
5989 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5990 (Vwrite_region_annotation_buffers): Now static.
5992 * eval.c: Make symbols static if they're not exported.
5993 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5994 * lisp.h (backtrace_list): Remove decl.
5996 * emacs.c: Make symbols static if they're not exported.
5997 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5998 (fatal_error_code, fatal_error_signal_hook, standard_args):
6000 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6001 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6002 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6003 * lisp.h (fatal_error_signal_hook): Remove decl.
6004 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6006 * editfns.c: Move a (normally-unused) function to its only use.
6007 * editfns.c, lisp.h (get_operating_system_release): Remove.
6008 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6009 worth the hassle of breaking this out.
6011 * xterm.c: Make symbols static if they're not exported.
6012 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6013 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6014 (x_destroy_window, x_delete_display):
6016 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6017 (x_mouse_leave): Remove; unused.
6018 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6019 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6020 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6022 (x_mouse_leave): Declare only if WINDOWSNT.
6023 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6024 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6027 * ftxfont.c: Make symbols static if they're not exported.
6028 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6030 * font.h (ftxfont_driver): Likewise.
6032 * xfns.c: Make symbols static if they're not exported.
6033 (x_last_font_name, x_display_info_for_name):
6034 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6035 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6036 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6037 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6038 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6039 (last_show_tip_args): Now static.
6040 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6041 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6042 (x_screen_planes): Remove; unused.
6043 * dispextern.h (x_screen_planes): Remove decl.
6045 * dispnew.c: Make symbols static if they're not exported.
6046 * dispextern.h (redraw_garbaged_frames, scrolling):
6047 (increment_row_positions): Remove.
6048 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6049 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6051 (redraw_garbaged_frames): Remove; unused.
6053 * xfaces.c: Make symbols static if they're not exported.
6054 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6056 * xterm.h (defined_color): Remove decls.
6057 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6058 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6059 (menu_face_changed_default, defined_color, free_realized_face):
6060 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6061 (ascii_face_of_lisp_face): Remove; unused.
6063 * xdisp.c: Make symbols static if they're not exported.
6064 * dispextern.h (scratch_glyph_row, window_box_edges):
6065 (glyph_to_pixel_coords, set_cursor_from_row):
6066 (get_next_display_element, set_iterator_to_next):
6067 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6068 (show_mouse_face): Remove decls
6069 * frame.h (message_buf_print): Likewise.
6070 * lisp.h (pop_message, set_message, check_point_in_composition):
6072 * xterm.h (set_vertical_scroll_bar): Likewise.
6073 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6074 (message_buf_print, scratch_glyph_row, displayed_buffer):
6075 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6076 (get_next_display_element, show_mouse_face, window_box_edges):
6077 (frame_to_window_pixel_xy, check_point_in_composition):
6078 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6079 (glyph_to_pixel_coords): Remove; unused.
6081 * dired.c (file_name_completion): Now static.
6083 * dbusbind.c (xd_in_read_queued_messages): Now static.
6085 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6086 * data.c (circular_list_error): Remove.
6088 * commands.h (last_point_position, last_point_position_buffer):
6089 (last_point_position_window): Remove decls.
6090 * keyboard.c: Make these variables static.
6092 * coding.h (coding, code_convert_region, encode_coding_gap):
6094 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6095 (iso_code_class, detect_coding, code_convert_region): Now static.
6096 (encode_coding_gap): Remove; unused.
6098 * chartab.c (chartab_chars, chartab_bits): Now static.
6100 * charset.h (charset_iso_8859_1): Remove decl.
6101 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6104 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6105 * ccl.c (Vccl_program_table): Now static.
6106 (check_ccl_update): Remove; unused.
6108 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6109 * category.h: ... from here.
6110 * category.c (check_category_table, set_category_set): Now static.
6112 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6113 * lisp.h: Remove these decls.
6115 * buffer.c (buffer_count): Remove unused var.
6117 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6118 so that it's not optimized away.
6119 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6120 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6121 exported only to the debugger.
6123 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
6124 * atimer.h (run_all_atimers): Remove; not exported.
6126 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6127 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6128 was inaccessible from Lisp.
6129 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6130 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6132 alloc.c: Import and export fewer symbols, and remove unused items.
6133 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6135 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6136 it's not optimized away by whole-program optimization.
6137 (message_enable_multibyte, free_misc): Remove.
6138 (catchlist, handlerlist, mark_backtrace):
6139 Declare only if BYTE_MARK_STACK.
6140 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6141 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6142 (message_enable_multibyte): Remove decl.
6143 (free_misc, interval_free_list, float_block, float_block_index):
6144 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6145 (cons_free_list, last_marked_index):
6147 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6148 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6149 (mark_backtrace): Define only if BYTE_MARK_STACK.
6150 * xdisp.c (message_enable_multibyte): Now static.
6152 Declare Lisp_Object Q* variables to be 'static' if not exported.
6153 This makes it easier for human readers (and static analyzers)
6154 to see whether these variables are used from other modules.
6155 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6156 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6157 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6158 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6159 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6160 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6161 * xmenu.c, xselect.c:
6162 Declare Q* vars static if they are not used in other modules.
6163 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6164 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6165 Remove decls of unexported vars.
6166 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6168 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6170 Make Emacs functions such as Fatom 'static' by default.
6171 This makes it easier for human readers (and static analyzers)
6172 to see whether these functions can be called from other modules.
6173 DEFUN now defines a static function. To make the function external
6174 so that it can be used in other C modules, use the new macro DEFUE.
6175 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6176 (Finit_image_library):
6177 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6178 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6179 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6180 Remove decls, since these functions are now static.
6181 (Funintern, Fget_internal_run_time): New decls, since these functions
6182 were already external.
6184 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6185 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6186 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6187 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6188 * keyboard.c, keymap.c, lread.c:
6189 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6190 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6191 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6192 Mark functions with DEFUE instead of DEFUN,
6193 if they are used in other modules.
6194 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6195 decls for now-static functions.
6196 * buffer.h (Fdelete_overlay): Remove decl.
6197 * callproc.c (Fgetenv_internal): Mark as internal.
6198 * composite.c (Fremove_list_of_text_properties): Remove decl.
6199 (Fcomposition_get_gstring): New forward static decl.
6200 * composite.h (Fcomposite_get_gstring): Remove decl.
6201 * dired.c (Ffile_attributes): New forward static decl.
6202 * doc.c (Fdocumntation_property): New forward static decl.
6203 * eval.c (Ffetch_bytecode): New forward static decl.
6204 (Funintern): Remove extern decl; now in .h file where it belongs.
6205 * fileio.c (Fmake_symbolic_link): New forward static decl.
6206 * image.c (Finit_image_library): New forward static decl.
6207 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6208 * intervals.h (Fprevious_property_change):
6209 (Fremove_list_of_text_properties): Remove decls.
6210 * keyboard.c (Fthis_command_keys): Remove decl.
6211 (Fcommand_execute): New forward static decl.
6212 * keymap.c (Flookup_key): New forward static decl.
6213 (Fcopy_keymap): Now static.
6214 * keymap.h (Flookup_key): Remove decl.
6215 * process.c (Fget_process): New forward static decl.
6216 (Fprocess_datagram_address): Mark as internal.
6217 * syntax.c (Fsyntax_table_p): New forward static decl.
6218 (skip_chars): Remove duplicate decl.
6219 * textprop.c (Fprevious_property_change): New forward static decl.
6220 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6222 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6223 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6225 * editfns.c (Fformat): Remove unreachable code.
6227 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6229 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6232 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6234 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6235 when at ZV. (Bug#8487)
6237 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6239 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6241 * keyboard.c (parse_tool_bar_item): Likewise.
6242 * sound.c (sound_cleanup, alsa_close): Likewise.
6243 * termcap.c (tgetent): Likewise.
6244 * xfns.c (x_default_font_parameter): Likewise.
6245 * xsettings.c (read_and_apply_settings): Likewise.
6247 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6248 (overrun_check_free): Protoize.
6250 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6252 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6253 since callers should never pass a negative size.
6254 Change the signature to match that of plain 'read' and 'write'; see
6255 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6256 * lisp.h: Update prototypes of emacs_write and emacs_read.
6258 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6260 * xdisp.c (redisplay_window): Don't try to determine the character
6261 position of the scroll margin if the window start point w->startp
6262 is outside the buffer's accessible region. (Bug#8468)
6264 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6266 Fix write-region and its subroutines for buffers > 2GB.
6267 * fileio.c (a_write, e_write): Modify declaration of arguments and
6268 local variables to support buffers larger than 2GB.
6269 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6271 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6272 argument, local variables, and return value.
6274 * lisp.h: Update prototypes of emacs_write and emacs_read.
6276 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6278 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6280 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6282 Fix more problems found by GCC 4.6.0's static checks.
6284 * xdisp.c (vmessage): Use a better test for character truncation.
6286 * charset.c (load_charset_map): <, not <=, for optimization,
6287 and to avoid potential problems with integer overflow.
6288 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6289 * casetab.c (set_identity, shuffle): Likewise.
6290 * editfns.c (Fformat): Likewise.
6291 * syntax.c (skip_chars): Likewise.
6293 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6294 This also lets GCC 4.6.0 generate slightly better loop code.
6296 * callint.c (Fcall_interactively): <, not <=, for optimization.
6297 (Fcall_interactively): Count the number of arguments produced,
6298 not the number of arguments given. This is simpler and lets GCC
6299 4.6.0 generate slightly better code.
6301 * ftfont.c: Distingish more carefully between FcChar8 and char.
6302 The previous code passed unsigned char * to a functions like
6303 strlen and xstrcasecmp that expect char *, which does not
6304 conform to the C standard.
6305 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6306 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6307 char * when the C standard requires it.
6309 * keyboard.c (read_char): Remove unused var.
6311 * eval.c: Port to Windows vsnprintf (Bug#8435).
6313 (SIZE_MAX): Define if the headers do not.
6314 (verror): Do not give up if vsnprintf returns a negative count.
6315 Instead, grow the buffer. This ports to Windows vsnprintf, which
6316 does not conform to C99. Problem reported by Eli Zaretskii.
6317 Also, simplify the allocation scheme, by avoiding the need for
6318 calling realloc, and removing the ALLOCATED variable.
6320 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6322 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6323 But keep the doprint source code for now, as we might revamp it
6324 and use it again (Bug#8435).
6325 * lisp.h (doprnt): Remove.
6326 * Makefile.in (base_obj): Remove doprnt.o.
6327 * deps.mk (doprnt.o): Remove.
6329 error: Print 32- and 64-bit integers portably (Bug#8435).
6330 Without this change, on typical 64-bit hosts error ("...%d...", N)
6331 was used to print both 32- and 64-bit integers N, which relied on
6333 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6335 * lisp.h (error, verror): Mark as printf-like functions.
6336 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6337 Report overflow in size calculations when allocating printf buffer.
6338 Do not truncate output string at its first null byte.
6339 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6340 Truncate the output at a character boundary, since vsnprintf does not
6342 * charset.c (check_iso_charset_parameter): Convert internal
6343 character to string before calling 'error', since %c now has the
6345 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6346 overflow when computing char to be passed to 'error'. Do not
6347 pass Lisp_Object to 'error'; pass the integer instead.
6348 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6349 formatted with plain %d.
6351 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6353 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6355 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6357 * xterm.c (x_catch_errors): Remove duplicate declaration.
6359 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6361 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6363 2011-04-10 Jim Meyering <meyering@redhat.com>
6365 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6366 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6367 return ssize_t not "int", and use size_t as the buffer length.
6368 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6369 * gnutls.h: Update declarations.
6370 * process.c (read_process_output): Use ssize_t, to match.
6371 (send_process): Likewise.
6373 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6375 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6377 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6379 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6380 Use unsigned char, to match FcChar8 type definition.
6382 * xterm.c (handle_one_xevent):
6383 * xmenu.c (create_and_show_popup_menu):
6384 * xselect.c (x_decline_selection_request)
6385 (x_reply_selection_request): Avoid type-punned deref of X events.
6387 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6389 Fix some uses of `int' instead of EMACS_INT.
6390 * search.c (string_match_1, fast_string_match)
6391 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6392 (scan_buffer, find_next_newline_no_quit)
6393 (find_before_next_newline, search_command, Freplace_match)
6394 (Fmatch_data): Make some `int' variables be EMACS_INT.
6396 * xdisp.c (display_count_lines): 3rd argument and return value now
6397 EMACS_INT. All callers changed.
6398 (pint2hrstr): Last argument is now EMACS_INT.
6400 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6401 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6402 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6403 (decode_coding_utf_16, decode_coding_emacs_mule)
6404 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6405 (decode_coding_ccl, decode_coding_charset)
6406 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6407 (decode_coding_iso_2022, decode_coding_emacs_mule)
6408 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6409 <char_offset, last_offset>: Declare EMACS_INT.
6410 (encode_coding_utf_8, encode_coding_utf_16)
6411 (encode_coding_emacs_mule, encode_invocation_designation)
6412 (encode_designation_at_bol, encode_coding_iso_2022)
6413 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6414 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6416 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6417 (encode_invocation_designation): Last argument P_NCHARS is now
6419 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6420 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6422 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6425 * ccl.c (Fccl_execute_on_string): Declare some variables
6428 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6430 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6432 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6434 * process.c (Fformat_network_address): Doc fix.
6436 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6438 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6440 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6442 * keyboard.c (read_char): Call Lisp function help-form-show,
6443 instead of using internal_with_output_to_temp_buffer.
6444 (Qhelp_form_show): New var.
6445 (syms_of_keyboard): Use DEFSYM macro.
6447 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6449 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6451 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6453 * process.c (Flist_processes): Remove to Lisp.
6454 (list_processes_1): Delete.
6456 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6458 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6460 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6462 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6464 Fix more problems found by GCC 4.6.0's static checks.
6466 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6468 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6470 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6472 * xdisp.c (vmessage): Mark as a printf-like function.
6474 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6476 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6478 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6479 printf-like functions.
6480 (tiff_load): Add casts to remove these marks before passing them
6481 to system-supplied API.
6483 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6485 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6486 This avoids several warnings with gcc -Wstrict-overflow.
6487 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6488 directly, rather than having caller test rule sign. This avoids
6489 some unnecessary tests.
6490 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6491 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6492 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6494 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6495 (xfont_open): Avoid unnecessary tests.
6497 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6499 * composite.h, composite.c (composition_gstring_put_cache):
6500 Use EMACS_INT, not int, for length.
6502 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6503 breaking out part of COMPOSITION_DECODE_RULE.
6504 (COMPOSITION_DECODE_RULE): Use it.
6505 * composite.c (get_composition_id): Remove unused local vars,
6506 by using the new macro.
6508 * textprop.c (set_text_properties_1): Change while to do-while,
6509 since the condition is always true at first.
6511 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6512 (interval_deletion_adjustment): Return unsigned value.
6515 * process.c (list_processes_1, create_pty, read_process_output):
6516 (exec_sentinel): Remove vars that were set but not used.
6517 (create_pty): Remove unnecessary "volatile"s.
6518 (Fnetwork_interface_info): Avoid possibility of int overflow.
6519 (read_process_output): Do adaptive read buffering even if carryover.
6520 (read_process_output): Simplify nbytes computation if buffered.
6522 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6524 * syntax.c (scan_words): Remove var that was set but not used.
6525 (update_syntax_table): Use unsigned instead of int.
6527 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6528 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6529 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6531 * print.c (print_error_message): Avoid int overflow.
6533 * font.c (font_list_entities): Redo for clarity,
6534 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6536 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6537 (font_score): Avoid potential overflow in diff calculation.
6539 * fns.c (substring_both): Remove var that is set but not used.
6540 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6542 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6544 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6545 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6546 can always succeed if overflow has undefined behavior.
6548 * search.c (boyer_moore, wordify): Remove vars set but not used.
6549 (wordify): Omit three unnecessary tests.
6551 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6552 All callers changed. This avoids the need for an unused var.
6554 * casefiddle.c (casify_region): Remove var that is set but not used.
6556 * dired.c (file_name_completion): Remove var that is set but not used.
6558 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6560 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6561 (Finsert_file_contents): Remove unnecessary code checking fd.
6563 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6564 Check for integer overflow on size calculations.
6566 * buffer.c (Fprevious_overlay_change): Remove var that is set
6569 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6570 Remove vars that are set but not used.
6571 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6572 (timer_check_2): Mark vars as initialized.
6574 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6576 * image.c (lookup_image): Remove var that is set but not used.
6577 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6579 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6580 that are set but not used.
6582 * xfns.c (make_invisible_cursor): Don't return garbage
6583 if XCreateBitmapFromData fails (Bug#8410).
6585 * xselect.c (x_get_local_selection, x_handle_property_notify):
6586 Remove vars that are set but not used.
6588 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6589 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6591 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6592 Remove var that is set but not used.
6593 (scroll_bar_windows_size): Now size_t, not int.
6594 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6597 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6598 (map_tty_color) [!defined MSDOS]: Likewise.
6600 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6602 * coding.c: Remove vars that are set but not used.
6603 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6604 All callers changed.
6605 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6606 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6607 (decode_coding_charset): Remove vars that are set but not used.
6609 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6610 that is set but not used.
6612 * print.c (print_object): Remove var that is set but not used.
6614 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6615 The gnulib version avoids calling malloc in the usual case,
6616 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6617 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6618 * filelock.c (current_lock_owner): Likewise.
6619 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6620 * sysdep.c: Include allocator.h, careadlinkat.h.
6621 (emacs_no_realloc_allocator): New static constant.
6622 (emacs_readlink): New function.
6623 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6624 ../lib/careadlinkat.h.
6626 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6628 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6629 first non-nil return value).
6631 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6633 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6634 if not defined (Bug#8403).
6636 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6638 * xdisp.c (display_count_lines): Remove parameter `start',
6639 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6640 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6641 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6642 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6643 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6644 and thereabouts. All callers changed.
6645 (get_per_char_metric): Remove parameter `f', unused since
6646 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6648 2011-04-02 Jim Meyering <meyering@redhat.com>
6650 do not dereference NULL upon failed strdup
6651 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6652 (ns_get_family): Likewise.
6654 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6656 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6658 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6660 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6663 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6665 Add lexical binding.
6667 * window.c (Ftemp_output_buffer_show): New fun.
6668 (Fsave_window_excursion):
6669 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6671 * lread.c (lisp_file_lexically_bound_p): New function.
6672 (Fload): Bind Qlexical_binding.
6673 (readevalloop): Remove `evalfun' arg.
6674 Bind Qinternal_interpreter_environment.
6675 (Feval_buffer): Bind Qlexical_binding.
6676 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6678 (syms_of_lread): Declare `lexical-binding'.
6680 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6682 * keyboard.c (eval_dyn): New fun.
6683 (menu_item_eval_property): Use it.
6685 * image.c (parse_image_spec): Use Ffunctionp.
6687 * fns.c (concat, mapcar1): Accept byte-code-functions.
6689 * eval.c (Fsetq): Handle lexical vars.
6690 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6691 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6692 (FletX, Flet): Obey lexical binding.
6693 (Fcommandp): Handle closures.
6694 (Feval): New `lexical' arg.
6695 (eval_sub): New function extracted from Feval. Use it almost
6696 everywhere where Feval was used. Look up vars in lexical env.
6698 (Ffunctionp): Move from subr.el.
6699 (Ffuncall): Handle closures.
6700 (apply_lambda): Remove `eval_flags'.
6701 (funcall_lambda): Handle closures and new byte-code-functions.
6702 (Fspecial_variable_p): New function.
6703 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6704 but without exporting it to Lisp.
6706 * doc.c (Fdocumentation, store_function_docstring):
6707 * data.c (Finteractive_form): Handle closures.
6709 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6712 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6714 (exec_byte_code): New function extracted from Fbyte_code to handle new
6715 calling convention for byte-code-functions. Add new byte-codes.
6717 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6719 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6721 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6723 * xdisp.c (redisplay_internal): Fix prototype.
6725 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6727 * xdisp.c (SCROLL_LIMIT): New macro.
6728 (try_scrolling): Use it when setting scroll_limit.
6729 Limit scrolling to 100 screen lines.
6730 (redisplay_window): Even when falling back on "recentering",
6731 position point in the window according to scroll-conservatively,
6732 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6734 (try_scrolling): When point is above the window, allow searching
6735 as far as scroll_max, or one screenful, to compute vertical
6736 distance from PT to the scroll margin position. This prevents
6737 try_scrolling from unnecessarily failing when
6738 scroll-conservatively is set to a value slightly larger than the
6739 window height. Clean up the case of PT below the margin at bottom
6740 of window: scroll_max can no longer be INT_MAX. When aggressive
6741 scrolling is in use, don't let point enter the opposite scroll
6742 margin as result of the scroll.
6743 (syms_of_xdisp) <scroll-conservatively>: Document the
6744 threshold of 100 lines for never-recentering scrolling.
6746 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6748 * dispextern.h (move_it_by_lines):
6749 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6750 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6751 (message_log_check_duplicate): Remove parameters `prev_bol' and
6752 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6753 (redisplay_internal): Remove parameter `preserve_echo_area',
6754 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6756 * indent.c (Fvertical_motion):
6757 * window.c (window_scroll_pixel_based, Frecenter):
6758 Don't pass `need_y_p' to `move_it_by_lines'.
6760 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6762 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6763 steal a few bits to be more compact.
6764 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6765 Remove unneeded casts.
6767 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6769 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6771 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6772 binding" message (bug#7967).
6774 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6776 Fix more problems found by GCC 4.6.0's static checks.
6778 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6779 Remove unused local var.
6781 * editfns.c (Fmessage_box): Remove unused local var.
6783 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6784 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6785 Omit unused local vars.
6786 * window.c (shrink_windows): Omit unused local var.
6787 * menu.c (digest_single_submenu): Omit unused local var.
6788 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6789 Omit unused local var.
6791 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6792 Don't assume string length fits in int.
6793 (keyremap_step, read_key_sequence): Use size_t for sizes.
6794 (read_key_sequence): Don't check last_real_key_start redundantly.
6796 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6797 instead of alloca (Bug#8344).
6799 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6800 (Fbacktrace_frame): Don't assume nframes fits in int.
6802 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6804 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6807 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6809 * cm.c (calccost): Turn while-do into do-while, for clarity.
6811 * keyboard.c (syms_of_keyboard): Use the same style as later
6812 in this function when indexing through an array. This also
6813 works around GCC bug 48267.
6815 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6817 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6819 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6820 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6822 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6823 This avoids undefined behavior on integer overflow, and is a bit
6824 more convenient anyway since it is compared to a size_t variable.
6826 Variadic C functions now count arguments with size_t, not int.
6827 This avoids an unnecessary limitation on 64-bit machines, which
6828 caused (substring ...) to crash on large vectors (Bug#8344).
6829 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6830 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6831 All variadic functions and their callers changed accordingly.
6832 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6833 * data.c (arith_driver, float_arith_driver): Likewise.
6834 * editfns.c (general_insert_function): Likewise.
6835 * eval.c (struct backtrace.nargs, interactive_p)
6836 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6837 (funcall_lambda, mark_backtrace): Likewise.
6838 * fns.c (concat): Likewise.
6839 * frame.c (x_set_frame_parameters): Likewise.
6840 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6841 0 if not found, not -1. All callers changed.
6843 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6844 (stack_copy_size): Now size_t, not int.
6845 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6847 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6849 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6850 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6851 All callers changed.
6853 * lisp.h (multibyte_char_to_unibyte):
6854 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6855 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6856 * character.h (CHAR_TO_BYTE8):
6857 * cmds.c (internal_self_insert):
6858 * editfns.c (general_insert_function):
6859 * keymap.c (push_key_description):
6860 * search.c (Freplace_match):
6861 * xdisp.c (message_dolog, set_message_1): All callers changed.
6863 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6865 * keyboard.c (safe_run_hook_funcall): New function.
6866 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6867 don't set the hook to nil, but remove the offending function instead.
6868 (Qcommand_hook_internal): Remove, unused.
6869 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6870 Vcommand_hook_internal.
6872 * eval.c (enum run_hooks_condition): Remove.
6873 (funcall_nil, funcall_not): New functions.
6874 (run_hook_with_args): Call each function through a `funcall' argument.
6875 Remove `cond' argument, now redundant.
6876 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6877 (Frun_hook_with_args_until_failure): Adjust accordingly.
6878 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6880 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6882 * dispextern.h (string_buffer_position): Remove declaration.
6884 * print.c (strout): Remove parameter `multibyte', unused since
6885 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6887 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6888 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6889 All callers changed.
6891 * w32.c (_wsa_errlist): Use braces for struct initializers.
6893 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6894 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6895 All callers changed.
6896 (string_buffer_position): Likewise. Also, make static (it's never
6897 used outside xdisp.c).
6898 (cursor_row_p): Remove parameter `w', unused since
6899 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6900 (decode_mode_spec): Remove parameter `precision', introduced during
6901 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6902 All callers changed.
6904 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6906 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6908 2011-03-27 Anders Lindgren <andlind@gmail.com>
6910 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6911 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6912 (ns_update_auto_hide_menu_bar): New functions.
6913 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6914 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6915 ns_constrain_all_frames.
6916 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6917 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6919 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6921 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6923 2011-03-27 Glenn Morris <rgm@gnu.org>
6925 * syssignal.h: Replace RETSIGTYPE with void.
6926 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6927 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6928 Replace SIGTYPE with void everywhere.
6929 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6930 * s/template.h (SIGTYPE): Remove commented out definition.
6932 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6934 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6935 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6937 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6939 * w32.c (read_unc_volume): Use parameter `henum', instead of
6940 global variable `wget_enum_handle'.
6942 * keymap.c (describe_vector): Remove parameters `indices' and
6943 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6944 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6946 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6948 * keyboard.c (timer_check): Remove parameter `do_it_now',
6949 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6950 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6951 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6953 * keyboard.c (read_char):
6954 * w32menu.c (w32_menu_display_help):
6955 * xmenu.c (show_help_event, menu_help_callback):
6956 Adjust calls to `show_help_echo'.
6958 * gtkutil.c (xg_maybe_add_timer):
6959 * keyboard.c (readable_events):
6960 * process.c (wait_reading_process_output):
6961 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6963 * insdel.c (adjust_markers_gap_motion):
6964 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6965 (gap_left, gap_right): Don't call it.
6967 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6969 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6970 incurred during fontification.
6972 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6974 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6975 (DEFVAR_PER_BUFFER): Don't pass it.
6977 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6978 (scrolling_window): Don't pass it.
6980 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6982 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6984 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6986 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6987 of variables specific to SELinux and computation of `encoded_absname'.
6989 * image.c (XPutPixel): Remove unused variable `height'.
6991 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6993 * unexw32.c (get_section_info): Remove unused variable `section'.
6995 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6996 (system_process_attributes): Remove unused variable `sess'.
6997 (sys_read): Remove unused variable `err'.
6999 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7000 (w32_wnd_proc): Remove unused variable `isdead'.
7001 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7002 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7003 (x_create_tip_frame): Remove unused variable `tem'.
7005 * w32inevt.c (w32_console_read_socket):
7006 Remove unused variable `no_events'.
7008 * w32term.c (x_draw_composite_glyph_string_foreground):
7009 Remove unused variable `width'.
7011 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
7013 * w32term.c (x_set_glyph_string_clipping):
7014 Don't pass uninitialized region to CombineRgn.
7016 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
7018 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7019 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7020 (Fx_close_connection): Remove unused variable `i'.
7022 * w32font.c (w32font_draw): Return number of glyphs.
7023 (w32font_open_internal): Remove unused variable `i'.
7024 (w32font_driver): Add missing initializer.
7026 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7027 (fill_in_menu): Remove unused variable `items_added'.
7029 * w32term.c (last_mouse_press_frame): Remove static global variable.
7030 (w32_clip_to_row): Remove unused variable `f'.
7031 (x_delete_terminal): Remove unused variable `i'.
7033 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7034 (NOTHING): Remove unused static global variable.
7035 (uniscribe_check_otf): Remove unused variable `table'.
7036 (uniscribe_font_driver): Add missing initializers.
7038 2011-03-23 Julien Danjou <julien@danjou.info>
7040 * term.c (Fsuspend_tty, Fresume_tty):
7041 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7042 * window.c (temp_output_buffer_show):
7043 * insdel.c (signal_before_change):
7044 * frame.c (Fhandle_switch_frame):
7045 * fileio.c (Fdo_auto_save):
7046 * emacs.c (Fkill_emacs):
7047 * editfns.c (save_excursion_restore):
7048 * cmds.c (internal_self_insert):
7049 * callint.c (Fcall_interactively):
7050 * buffer.c (Fkill_all_local_variables):
7051 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7053 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
7054 unconditionnaly since it does the check itself.
7056 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
7058 Fix more problems found by GCC 4.5.2's static checks.
7060 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7061 the first time through the loop, since we know p0 < p1 then.
7062 This also avoids a gcc -Wstrict-overflow warning.
7064 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7065 leading to a memory leak, possible in functions like
7066 load_charset_map_from_file that can allocate an unbounded number
7067 of objects (Bug#8318).
7069 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7070 that could (at least in theory) be that large.
7072 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7073 This is less likely to overflow, and avoids undefined behavior if
7074 overflow does occur. All callers changed. Use strtoul to scan
7075 for the unsigned long integer.
7076 (pint2hrstr): Simplify and tune code slightly.
7077 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
7079 * scroll.c (do_scrolling): Work around GCC bug 48228.
7080 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7082 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7083 This also avoids a warning with gcc -Wstrict-overflow.
7084 (validate_x_resource_name): Simplify count usage.
7085 This also avoids a warning with gcc -Wstrict-overflow.
7087 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7090 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
7092 * process.c (Fmake_network_process): Use socklen_t, not int,
7093 where POSIX says socklen_t is required in portable programs.
7094 This fixes a porting bug on hosts like 64-bit HP-UX, where
7095 socklen_t is wider than int (Bug#8277).
7096 (Fmake_network_process, server_accept_connection):
7097 (wait_reading_process_output, read_process_output):
7100 * process.c: Rename or move locals to avoid shadowing.
7101 (list_processes_1, Fmake_network_process):
7102 (read_process_output_error_handler, exec_sentinel_error_handler):
7103 Rename or move locals.
7104 (Fmake_network_process): Define label "retry_connect" only if needed.
7105 (Fnetwork_interface_info): Fix pointer signedness.
7106 (process_send_signal): Add cast to avoid pointer signedness problem.
7107 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7108 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7110 Make tparam.h and terminfo.c consistent.
7111 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7112 Include tparam.h instead, since it declares them.
7113 * cm.h (PC): Remove extern decl; tparam.h now does this.
7114 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7115 * terminfo.c: Include tparam.h, to check interfaces.
7116 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7117 (tparam): Adjust signature to match interface in tparam.h;
7118 this removes some undefined behavior. Check that outstring and len
7119 are zero, which they always are with Emacs.
7120 * tparam.h (PC, BC, UP): New extern decls.
7122 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
7123 (xftfont_open): Rename locals to avoid shadowing.
7125 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
7126 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7127 (OTF_TAG_SYM): Omit macro if not needed.
7128 (ftfont_list): Remove unused local.
7129 (get_adstyle_property, ftfont_pattern_entity):
7130 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7131 Rename locals to avoid shadowing.
7133 * xfont.c (xfont_list_family): Mark var as initialized.
7135 * xml.c (make_dom): Now static.
7137 * composite.c (composition_compute_stop_pos): Rename local to
7139 (composition_reseat_it): Remove unused locals.
7140 (find_automatic_composition, composition_adjust_point): Likewise.
7141 (composition_update_it): Mark var as initialized.
7142 (find_automatic_composition): Mark vars as initialized,
7143 with a FIXME (Bug#8290).
7145 character.h: Rename locals to avoid shadowing.
7146 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7147 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7148 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7149 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7152 * textprop.c (property_change_between_p): Remove; unused.
7154 * intervals.c (interval_start_pos): Now static.
7156 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7158 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7159 Rename locals to avoid shadowing.
7161 * sound.c (wav_play, au_play, Fplay_sound_internal):
7162 Fix pointer signedness.
7163 (alsa_choose_format): Remove unused local var.
7164 (wav_play): Initialize a variable to 0, to prevent undefined
7165 behavior (Bug#8278).
7167 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7169 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7171 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7172 clobbering (Bug#8298).
7173 * sysdep.c (sys_subshell): Likewise.
7174 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7176 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7177 This should get cleaned up, so that child_setup has the
7178 same signature on all platforms.
7180 * callproc.c (call_process_cleanup): Now static.
7181 (relocate_fd): Rename locals to avoid shadowing.
7183 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7185 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7186 not to be necessary, and produces flickering.
7188 2011-03-20 Glenn Morris <rgm@gnu.org>
7190 * config.in: Remove file.
7192 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7194 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7195 are now in src/globals.h.
7196 (syms_of_minibuf): Remove spurious & from previous change.
7198 2011-03-20 Leo <sdl.web@gmail.com>
7200 * minibuf.c (completing-read-function): New variable.
7201 (completing-read-default): Rename from completing-read.
7202 (completing-read): Call completing-read-function.
7204 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7206 * xfaces.c (Fx_load_color_file):
7207 Read color file from absolute filename (bug#8250).
7209 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7211 * makefile.w32-in: Update dependencies.
7213 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7215 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7217 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7219 Fix more problems found by GCC 4.5.2's static checks.
7221 * process.c (make_serial_process_unwind, send_process_trap):
7222 (sigchld_handler): Now static.
7224 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7225 That way, the code declares only the vars that it needs.
7226 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7227 * s/cygwin.h (PTY_ITERATION): Likewise.
7228 * s/darwin.h (PTY_ITERATION): Likewise.
7229 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7231 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7232 * process.c (allocate_pty): Don't declare stb unless it's needed.
7234 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7235 (CONSTANTLIM): Remove; unused.
7236 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7237 Define only if needed.
7239 * unexelf.c (unexec): Name an expression,
7240 to avoid gcc -Wbad-function-cast warning.
7241 Use a different way to cause a compilation error if anyone uses
7242 n rather than nn, a way that does not involve shadowing.
7243 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7245 * deps.mk (unexalpha.o): Remove; unused.
7247 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7248 * unexec.h: New file.
7249 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7250 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7252 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7253 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7254 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7255 Change as necessary to match prototype in unexec.h.
7257 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7259 (back_comment, skip_chars): Mark vars as initialized.
7261 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7262 Rename locals to avoid shadowing.
7264 * lread.c (read1): Rewrite so as not to use empty "else".
7265 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7267 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7269 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7270 warning when compiling print.c.
7272 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7273 instead of using an uninitialized var.
7274 (font_sort_entities): Mark var as initialized.
7276 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7278 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7279 pointers to constants.
7280 (font_parse_fcname): Remove unused vars.
7281 (font_delete_unmatched): Now static.
7282 (font_get_spec): Remove; unused.
7283 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7284 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7285 Rename or move locals to avoid shadowing.
7287 * fns.c (require_nesting_list, require_unwind): Now static.
7288 (Ffillarray): Rename locals to avoid shadowing.
7290 * floatfns.c (domain_error2): Define only if needed.
7291 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7293 * alloc.c (mark_backtrace): Move decl from here ...
7294 * lisp.h: ... to here, so that it can be checked.
7296 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7297 (Fdefvar): Rewrite so as not to use empty "else".
7298 (lisp_indirect_variable): Name an expression,
7299 to avoid gcc -Wbad-function-cast warning.
7300 (Fdefvar): Rename locals to avoid shadowing.
7302 * callint.c (quotify_arg, quotify_args): Now static.
7303 (Fcall_interactively): Rename locals to avoid shadowing.
7304 Use const pointer when appropriate.
7306 * lisp.h (get_system_name, get_operating_system_release):
7307 Move decls here, to check interfaces.
7308 * process.c (get_operating_system_release): Move decl to lisp.h.
7309 * xrdb.c (get_system_name): Likewise.
7310 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7311 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7312 some of which prompt warnings from gcc -Wbad-function-cast.
7313 (Fformat_time_string, Fencode_time, Finsert_char):
7314 (Ftranslate_region_internal, Fformat):
7315 Rename or remove local vars to avoid shadowing.
7316 (Ftranslate_region_internal): Mark var as initialized.
7318 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7321 * lisp.h (eassert): Check that the argument compiles, even if
7322 ENABLE_CHECKING is not defined.
7324 * data.c (Findirect_variable): Name an expression, to avoid
7325 gcc -Wbad-function-cast warning.
7326 (default_value, arithcompare, arith_driver, arith_error): Now static.
7327 (store_symval_forwarding): Rename local to avoid shadowing.
7328 (Fmake_variable_buffer_local, Fmake_local_variable):
7329 Mark variables as initialized.
7330 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7332 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7333 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7334 Rename locals to avoid shadowing.
7335 (mark_stack): Move local variables into the #ifdef region where
7337 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7338 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7340 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7341 (GC_STRING_CHARS): Remove; not used.
7342 (Fmemory_limit): Cast sbrk's returned value to char *.
7344 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7345 avoids undefined behavior in theory.
7347 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7349 Use functions, not macros, for up- and down-casing (Bug#8254).
7350 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7351 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7352 to use the following functions instead of these macros.
7353 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7354 EMACS_INT, since callers assume the returned value fits in int.
7355 (upcase1): Likewise, for UPCASE_TABLE.
7356 (uppercasep, lowercasep, upcase): New static inline functions.
7357 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7358 the race-condition problem in the old DOWNCASE.
7360 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7361 Rename locals to avoid shadowing.
7362 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7363 (regex_compile, re_search_2, re_match_2_internal):
7364 Remove unused local vars.
7365 (FREE_VAR): Rewrite so as not to use empty "else",
7366 which gcc can warn about.
7367 (regex_compile, re_match_2_internal): Mark locals as initialized.
7368 (RETALLOC_IF): Define only if needed.
7369 (WORDCHAR_P): Likewise. This one is never needed, but is used
7370 only in a comment talking about a compiler bug, so put inside
7371 the #if 0 of that comment.
7372 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7373 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7376 * search.c (boyer_moore): Rename locals to avoid shadowing.
7377 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7378 (PREV_CHAR_BOUNDARY): Likewise.
7380 * search.c (simple_search): Remove unused var.
7382 * dired.c (compile_pattern): Move decl from here ...
7383 * lisp.h: ... to here, so that it can be checked.
7384 (struct re_registers): New forward decl.
7386 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7388 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7390 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7391 Rename locals to avoid shadowing.
7392 (Fvertical_motion): Mark locals as initialized.
7394 * casefiddle.c (casify_object, casify_region): Now static.
7395 (casify_region): Mark local as initialized.
7397 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7399 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7400 New macros, so that the caller can use some names other than
7401 gcpro1, gcpro2, etc.
7402 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7404 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7405 argument, for consistency with GCPRO2_VAR, etc: it is now the
7406 prefix of the variable, not the variable itself. All uses
7408 * dired.c (directory_files_internal, file_name_completion):
7409 Rename locals to avoid shadowing.
7411 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7412 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7413 dired.c's scmp function, had undefined behavior.
7414 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7415 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7416 * buffer.h: ... to here, because these macros use current_buffer,
7417 and the new implementation with inline functions needs to have
7418 current_buffer in scope now, rather than later when the macros
7420 (downcase, upcase1): New static inline functions.
7421 (DOWNCASE, UPCASE1): Reimplement using these functions.
7422 This avoids undefined behavior in expressions like
7423 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7424 from race conditions in accessing the global variables
7425 case_temp1 and case_temp2.
7426 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7427 * lisp.h (case_temp1, case_temp2): Remove their decls.
7428 * character.h (ASCII_CHAR_P): Move from here ...
7429 * lisp.h: ... to here, so that the inline functions mentioned
7432 * dired.c (directory_files_internal_unwind): Now static.
7434 * fileio.c (file_name_as_directory, directory_file_name):
7435 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7437 (file_name_as_directory): Use const pointers when appropriate.
7438 (Fexpand_file_name): Likewise. In particular, newdir might
7439 point at constant storage, so make it a const pointer.
7440 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7441 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7443 (Fset_file_times, Finsert_file_contents, auto_save_error):
7444 Rename locals to avoid shadowing.
7446 * minibuf.c (choose_minibuf_frame_1): Now static.
7447 (Ftry_completion, Fall_completions): Rename or remove locals
7450 * marker.c (bytepos_to_charpos): Remove; unused.
7452 * lisp.h (verify_bytepos, count_markers): New decls,
7453 so that gcc does not warn that these functions aren't declared.
7455 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7456 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7457 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7458 (copy_text): Remove unused local var.
7460 * filelock.c (within_one_second): Now static.
7461 (lock_file_1): Rename local to avoid shadowing.
7463 * buffer.c (fix_overlays_before): Mark locals as initialized.
7464 (fix_start_end_in_overlays): Likewise. This function should be
7465 simplified by using pointers-to-pointers, but that's a different
7467 (switch_to_buffer_1): Now static.
7468 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7469 (report_overlay_modification): Rename locals to avoid shadowing.
7471 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7472 Fix pointer signedness issue.
7473 (sys_subshell): Mark local as volatile if checking for lint,
7474 to suppress a gcc -Wclobbered warning that does not seem to be right.
7475 (MAXPATHLEN): Define only if needed.
7477 * process.c (serial_open, serial_configure): Move decls from here ...
7478 * systty.h: ... to here, so that they can be checked.
7480 * fns.c (get_random, seed_random): Move extern decls from here ...
7481 * lisp.h: ... to here, so that they can be checked.
7483 * sysdep.c (reset_io): Now static.
7484 (wait_for_termination_signal): Remove; unused.
7486 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7487 (copy_keymap_item, append_key, push_text_char_description):
7489 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7490 (DENSE_TABLE_SIZE): Remove; unused.
7491 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7492 (describe_map_tree):
7493 Rename locals to avoid shadowing.
7495 * keyboard.c: Declare functions static if they are not used elsewhere.
7496 (echo_char, echo_dash, cmd_error, top_level_2):
7497 (poll_for_input, handle_async_input): Now static.
7498 (read_char, kbd_buffer_get_event, make_lispy_position):
7499 (make_lispy_event, make_lispy_movement, apply_modifiers):
7500 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7501 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7502 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7503 (read_key_sequence, read_char): Mark locals as initialized.
7504 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7506 * keyboard.h (make_ctrl_char): New decl.
7507 (mark_kboards): Move decl here ...
7508 * alloc.c (mark_kboards): ... from here.
7510 * lisp.h (force_auto_save_soon): New decl.
7512 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7513 (DEFINE_DUMMY_FUNCTION): New macro.
7514 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7516 (main): Add casts to avoid warnings
7517 if GCC considers string literals to be constants.
7519 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7521 * dbusbind.c: Pointer signedness fixes.
7522 (xd_signature, xd_append_arg, xd_initialize):
7523 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7524 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7525 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7526 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7528 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7529 if GCC considers string literals to be constants.
7530 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7532 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7534 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7535 (print_preprocess, print_object): New macro to fix last change.
7537 * print.c (print_preprocess): Don't forget font objects.
7539 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7541 * emacs.c (USAGE3): Doc fixes.
7543 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7545 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7548 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7550 * lisp.h (VWindow_system, Qfile_name_history):
7551 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7552 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7553 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7555 * w32select.c: Don't #include "keyboard.h".
7556 (run_protected): Add extern declaration for waiting_for_input.
7558 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7559 * w32console.c (detect_input_pending, read_input_pending)
7560 (encode_terminal_code):
7561 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7562 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7563 (w32_system_caret_y, Qfile_name_history):
7564 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7565 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7566 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7567 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7568 * w32proc.c (Qlocal, report_file_error):
7569 * w32term.c (Vwindow_system, updating_frame):
7570 * w32uniscribe.c (initialized, uniscribe_font_driver):
7571 Remove unneeded extern declarations.
7573 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7575 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7577 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7579 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7580 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7581 These macros can no longer be used for assignment.
7583 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7584 Assign struct members directly, instead of using BUF_BEGV etc.
7585 (record_buffer_markers, fetch_buffer_markers): New functions for
7586 recording and fetching special buffer markers.
7587 (set_buffer_internal_1, set_buffer_temp): Use them.
7589 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7591 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7593 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7594 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7596 * xdisp.c (hscroll_window_tree):
7597 (reconsider_clip_changes): Use PT instead of BUF_PT.
7599 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7601 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7602 $(EMACS_ROOT)/lib/intprops.h.
7604 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7606 Fix more problems found by GCC 4.5.2's static checks.
7608 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7609 to unsigned char * to avoid compiler diagnostic.
7610 (xg_free_frame_widgets): Make it clear that a local variable is
7611 needed only if USE_GTK_TOOLTIP.
7612 (gdk_window_get_screen): Make it clear that this macro is needed
7613 only if USE_GTK_TOOLTIP.
7614 (int_gtk_range_get_value): New function, which avoids a diagnostic
7615 from gcc -Wbad-function-cast.
7616 (xg_set_toolkit_scroll_bar_thumb): Use it.
7617 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7618 diagnostic from gcc -Wbad-function-cast.
7619 (get_utf8_string, xg_get_file_with_chooser):
7620 Rename locals to avoid shadowing.
7621 (create_dialog): Move locals to avoid shadowing.
7623 * xgselect.c (xg_select): Remove unused var.
7625 * image.c (four_corners_best): Mark locals as initialized.
7626 (gif_load): Initialize transparent_p to zero (Bug#8238).
7627 Mark another local as initialized.
7628 (my_png_error, my_error_exit): Mark with NO_RETURN.
7630 * image.c (clear_image_cache): Now static.
7631 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7632 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7633 (x_edge_detection): Remove unnecessary cast that
7634 gcc -Wbad-function-cast diagnoses.
7635 (gif_load): Fix pointer signedness.
7636 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7637 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7639 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7641 Improve quality of tests for time stamp overflow.
7642 For example, without this patch (encode-time 0 0 0 1 1
7643 1152921504606846976) returns the obviously-bogus value (-948597
7644 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7645 reports time overflow. See
7646 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7647 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7648 * editfns.c: Include limits.h and intprops.h.
7649 (TIME_T_MIN, TIME_T_MAX): New macros.
7650 (time_overflow): Move earlier, to before first use.
7651 (hi_time, lo_time): New functions, for an accurate test for
7653 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7654 (Fget_internal_run_time): Don't assume time_t fits in int.
7655 (make_time): Use list2 instead of Fcons twice.
7656 (Fdecode_time): More accurate test for out-of-range times.
7657 (check_tm_member): New function.
7658 (Fencode_time): Use it, to test for out-of-range times.
7659 (lisp_time_argument): Don't rely on undefined left-shift and
7660 right-shift behavior when checking for time stamp overflow.
7662 * editfns.c (time_overflow): New function, refactoring common code.
7663 (Fformat_time_string, Fdecode_time, Fencode_time):
7664 (Fcurrent_time_string): Use it.
7666 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7667 * dired.c (make_time): Move to ...
7668 * editfns.c (make_time): ... here.
7669 * systime.h: Note the move.
7671 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7673 * fringe.c (update_window_fringes): Remove unused variables.
7675 * unexmacosx.c (copy_data_segment): Also copy __got section.
7678 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7680 * termcap.c [MSDOS]: Include "msdos.h".
7681 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7682 Constify `char *' arguments and their references according to
7683 prototypes in tparam.h.
7685 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7687 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7688 Adapt all references accordingly.
7690 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7692 2011-03-11 Tom Tromey <tromey@redhat.com>
7694 * buffer.c (syms_of_buffer): Remove obsolete comment.
7696 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7698 * termhooks.h (encode_terminal_code): Declare prototype.
7700 * msdos.c (encode_terminal_code): Don't declare prototype.
7702 * term.c (encode_terminal_code): Now external again, used by
7703 w32console.c and msdos.c.
7705 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7706 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7708 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7710 Fix some minor problems found by GCC 4.5.2's static checks.
7712 * fringe.c (update_window_fringes): Mark locals as initialized
7714 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7716 * alloc.c (mark_fringe_data): Move decl from here ...
7717 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7718 to check its interface.
7719 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7721 * fontset.c (free_realized_fontset): Now static.
7722 (Fset_fontset_font): Rename local to avoid shadowing.
7723 (fontset_font): Mark local as initialized.
7724 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7726 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7728 * xselect.c (x_disown_buffer_selections): Remove; not used.
7729 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7730 (x_own_selection, Fx_disown_selection_internal): Rename locals
7732 (x_handle_dnd_message): Remove local to avoid shadowing.
7734 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7735 so that the caller can use some name other than gcpro1.
7736 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7737 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7738 (Fx_backspace_delete_keys_p):
7739 Use them to avoid shadowing, and rename vars to avoid shadowing.
7740 (x_decode_color, x_set_name, x_window): Now static.
7741 (Fx_create_frame): Add braces to silence GCC warning.
7742 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7743 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7744 Remove unused locals.
7745 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7746 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7747 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7750 * xterm.h (x_mouse_leave): New decl.
7752 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7753 Remove unused functions.
7754 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7755 (x_calc_absolute_position): Now static.
7756 (XTread_socket): Don't define label "out" unless it's used.
7757 Don't declare local "event" unless it's used.
7758 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7759 unless they are used.
7760 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7761 (x_fatal_error_signal): Remove; not used.
7762 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7763 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7764 (x_error_catcher, x_connection_closed, x_error_handler):
7765 (x_error_quitter, xembed_send_message, x_iconify_frame):
7766 (my_log_handler): Rename locals to avoid shadowing.
7767 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7768 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7770 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7771 Rename or move locals to avoid shadowing.
7772 (tty_defined_color, merge_face_heights): Now static.
7773 (free_realized_faces_for_fontset): Remove; not used.
7774 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7775 does not deduce is never used uninitialized.
7776 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7777 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7779 * terminal.c (store_terminal_param): Now static.
7781 * xmenu.c (menu_highlight_callback): Now static.
7782 (set_frame_menubar): Remove unused local.
7783 (xmenu_show): Rename parameter to avoid shadowing.
7784 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7785 since they might point to immutable storage.
7786 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7787 since it's unused otherwise.
7789 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7790 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7791 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7792 avoids a gcc -Wuninitialized diagnostic.
7793 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7794 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7795 does not deduce are never used uninitialized.
7797 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7799 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7800 * window.c (window_loop, size_window):
7801 (run_window_configuration_change_hook, enlarge_window): Likewise.
7803 * window.c (display_buffer): Now static.
7804 (size_window): Mark variables that gcc -Wuninitialized
7805 does not deduce are never used uninitialized.
7806 * window.h (check_all_windows): New decl, to forestall
7807 gcc -Wmissing-prototypes diagnostic.
7808 * dispextern.h (bidi_dump_cached_states): Likewise.
7810 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7812 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7814 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7815 and to avoid gcc -Wuninitialized warning.
7816 (load_charset_map): Mark variables that gcc -Wuninitialized
7817 does not deduce are never used uninitialized.
7818 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7820 * coding.c (coding_set_source, coding_set_destination):
7821 Use "else { /* comment */ }" rather than "else /* comment */;"
7822 for clarity, and to avoid gcc -Wempty-body warning.
7823 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7824 a block, when the outer 'i' will do.
7825 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7826 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7827 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7828 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7829 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7830 Rename locals to avoid shadowing.
7831 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7832 * coding.c (emacs_mule_char, encode_invocation_designation):
7833 Now static, since they're not used elsewhere.
7834 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7835 (decode_coding_object, encode_coding_object, detect_coding_system):
7836 (decode_coding_emacs_mule): Mark variables that gcc
7837 -Wuninitialized does not deduce are never used uninitialized.
7838 (detect_coding_iso_2022): Initialize a local variable that might
7839 be used uninitialized. Leave a FIXME because it's not clear that
7840 this initialization is needed. (Bug#8211)
7841 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7842 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7843 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7844 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7845 Remove unused macros.
7847 * category.c (hash_get_category_set): Remove unused local var.
7848 (copy_category_table): Now static, since it's not used elsewhere.
7849 * character.c (string_count_byte8): Likewise.
7851 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7852 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7854 * chartab.c (copy_sub_char_table): Now static, since it's not used
7856 (sub_char_table_ref_and_range, char_table_ref_and_range):
7857 Rename locals to avoid shadowing.
7858 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7860 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7861 (BIDI_BOB): Remove unused macro.
7863 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7864 deduce are never used uninitialized.
7865 * term.c (encode_terminal_code): Likewise.
7867 * term.c (encode_terminal_code): Now static. Remove unused local.
7869 * tparam.h: New file.
7870 * term.c, tparam.h: Include it.
7871 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7872 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7873 Move these decls to tparam.h, and make them agree with what
7874 is actually in tparam.c. The previous trick of using incompatible
7875 decls in different modules does not conform to the C standard.
7876 All callers of tparam changed to use tparam's actual API.
7877 * tparam.c (tparam1, tparam, tgoto):
7878 Use const pointers where appropriate.
7880 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7881 * cm.h (struct cm): Likewise.
7882 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7883 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7884 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7885 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7886 (turn_on_face, init_tty): Likewise.
7887 * termchar.h (struct tty_display_info): Likewise.
7889 * term.c (term_mouse_position): Rename local to avoid shadowing.
7891 * alloc.c (mark_ttys): Move decl from here ...
7892 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7894 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7896 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7898 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7900 * search.c (compile_pattern_1): Remove argument regp, unused since
7901 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7902 (compile_pattern): Don't pass it.
7904 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7906 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7907 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7909 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7911 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7913 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7914 gdk_window_get_screen, gdk_window_get_geometry,
7915 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7916 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7917 (xg_get_pixbuf_from_pixmap): New function.
7918 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7919 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7920 Call xg_get_pixbuf_from_pixmap instead of
7921 gdk_pixbuf_get_from_drawable.
7922 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7923 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7924 (xg_check_special_colors): Use GtkStyleContext and its functions
7926 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7927 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7928 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7929 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7930 Call gtk_widget_get_preferred_size.
7931 (xg_frame_resized): gdk_window_get_geometry only takes 5
7933 (xg_win_to_widget, xg_event_is_for_menubar):
7934 Call gdk_x11_window_lookup_for_display.
7935 (xg_set_widget_bg): New function.
7936 (delete_cb): New function.
7937 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7938 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7939 (xg_set_background_color): Call xg_set_widget_bg.
7940 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7941 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7942 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7943 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7945 (update_frame_tool_bar): Call gtk_widget_hide.
7946 (xg_initialize): Use GDK_KEY_g.
7948 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7950 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7952 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7953 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7954 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7956 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7958 * w32xfns.c (select_palette): Check success of RealizePalette against
7959 GDI_ERROR, not zero.
7961 See ChangeLog.11 for earlier changes.
7967 Copyright (C) 2011 Free Software Foundation, Inc.
7969 This file is part of GNU Emacs.
7971 GNU Emacs is free software: you can redistribute it and/or modify
7972 it under the terms of the GNU General Public License as published by
7973 the Free Software Foundation, either version 3 of the License, or
7974 (at your option) any later version.
7976 GNU Emacs is distributed in the hope that it will be useful,
7977 but WITHOUT ANY WARRANTY; without even the implied warranty of
7978 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7979 GNU General Public License for more details.
7981 You should have received a copy of the GNU General Public License
7982 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.