1 2012-03-31 Eli Zaretskii <eliz@gnu.org>
3 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4 string comes from a `display' text property, use the buffer
5 position of that property as if we actually saw that position in
8 2012-03-30 Eli Zaretskii <eliz@gnu.org>
10 * xdisp.c (append_space_for_newline): If the default face was
11 remapped, use the remapped face for the appended newline.
12 (extend_face_to_end_of_line): Use the remapped default face for
13 extending the face to the end of the line.
14 (display_line): Call extend_face_to_end_of_line when the default
15 face was remapped. (Bug#11068)
17 2012-03-29 Eli Zaretskii <eliz@gnu.org>
19 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
21 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
23 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
25 2012-03-27 Glenn Morris <rgm@gnu.org>
27 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
30 2012-03-26 Kenichi Handa <handa@m17n.org>
32 * dispextern.h (struct glyph): Fix previous change. Change the
33 bit length of glyphless.ch to 25 (Bug#11082).
35 2012-03-26 Chong Yidong <cyd@gnu.org>
37 * keyboard.c (Vselection_inhibit_update_commands): New variable.
38 (command_loop_1): Use it; inhibit selection update for
39 handle-select-window too (Bug#8996).
41 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
43 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
45 2012-03-25 Kenichi Handa <handa@m17n.org>
47 * dispextern.h (struct glyph): Change the bit length of
48 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
50 2012-03-24 Eli Zaretskii <eliz@gnu.org>
52 * s/ms-w32.h (tzname): Include time.h before redirecting to
53 _tzname. Fixes the MSVC build. (Bug#9960)
55 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
57 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
60 * xterm.c (XTread_socket): Only modify handling_signal if
61 !SYNC_INPUT. (Bug#11080)
63 2012-03-23 Eli Zaretskii <eliz@gnu.org>
65 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
66 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
67 when fetching a multibyte character consumes more bytes than
68 CHAR_BYTES returns, due to unification of CJK characters in
69 string_char. (Bug#11073)
71 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
73 * process.c (wait_reading_process_output): Handle pty disconnect
74 by refraining from sending oneself a SIGCHLD (bug#10933).
76 2012-03-22 Chong Yidong <cyd@gnu.org>
78 * dispextern.h (struct it): New member string_from_prefix_prop_p.
80 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
81 Mark string as coming from a prefix property.
82 (handle_face_prop): Use default face for prefix strings (Bug#4281).
83 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
85 2012-03-21 Chong Yidong <cyd@gnu.org>
87 * xfaces.c (Vface_remapping_alist): Doc fix.
89 2012-03-20 Eli Zaretskii <eliz@gnu.org>
91 * w32proc.c (Fw32_set_console_codepage)
92 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
95 2012-03-20 Chong Yidong <cyd@gnu.org>
97 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
98 to reflect default non-nil value of redisplay-dont-pause.
100 2012-03-19 Kenichi Handa <handa@m17n.org>
102 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
103 it fit in a valid range (Bug#11003).
105 2012-03-18 Eli Zaretskii <eliz@gnu.org>
107 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
108 that is not from display property, accept the row as a "cursor
109 row" if one of the string's character has a non-nil `cursor'
110 property. Fixes cursor positioning when there are newlines in
111 overlay strings, e.g. in icomplete.el. (Bug#11035)
113 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
115 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
117 2012-03-12 Chong Yidong <cyd@gnu.org>
119 * eval.c (inhibit_lisp_code): Rename from
120 inhibit_window_configuration_change_hook; move from window.c.
122 * xfns.c (unwind_create_frame_1, Fx_create_frame):
123 * window.c (run_window_configuration_change_hook)
124 (syms_of_window): Callers changed.
126 2012-03-11 Chong Yidong <cyd@gnu.org>
128 * keymap.c (Fkey_description): Doc fix (Bug#9700).
130 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
132 2012-03-10 Chong Yidong <cyd@gnu.org>
134 * frame.c (other_visible_frames): Don't assume the selected frame
135 is visible (Bug#10955).
137 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
139 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
141 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
143 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
144 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
147 2012-03-03 Glenn Morris <rgm@gnu.org>
149 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
151 2012-03-02 Eli Zaretskii <eliz@gnu.org>
153 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
154 position past the first glyph_row that ends at ZV. (Bug#10902)
155 (redisplay_window, next_element_from_string): Fix typos in
157 (redisplay_window): Pass to move_it_vertically the margin in
158 pixels, not in screen lines.
160 2012-03-02 Glenn Morris <rgm@gnu.org>
162 * buffer.c (buffer-list-update-hook): Doc fix.
164 2012-02-29 Eli Zaretskii <eliz@gnu.org>
166 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
167 push_it before setting up the iterator for the first overlay
168 string, even if we have an empty string loaded.
169 (next_overlay_string): If there's an empty string on the iterator
170 stack, pop the stack. (Bug#10903)
172 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
174 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
175 Suggested by Stefan Monnier in
176 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
177 * alloc.c (widen_to_Lisp_Object): New static function.
178 (mark_memory): Also mark Lisp_Objects by fetching pointer words
179 and widening them to Lisp_Objects. This would work even if
180 USE_LSB_TAG is defined and wide integers are used, which might
181 happen in a future version of Emacs.
183 2012-02-25 Chong Yidong <cyd@gnu.org>
185 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
188 * xselect.c (Fx_selection_exists_p): Doc fix.
189 (x_clipboard_manager_save_all): Print an informative message
190 before saving to clipboard manager.
192 2012-02-24 Chong Yidong <cyd@gnu.org>
194 * keyboard.c (process_special_events): Handle all X selection
195 requests in kbd_buffer, not just the next one (Bug#8869).
197 2012-02-23 Chong Yidong <cyd@gnu.org>
199 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
200 call when setting menu-bar-lines and tool-bar-lines parameters.
201 (unwind_create_frame_1): New helper function.
203 * window.c (inhibit_window_configuration_change_hook): New var.
204 (run_window_configuration_change_hook): Obey it.
205 (syms_of_window): Initialize it.
207 2012-02-22 Chong Yidong <cyd@gnu.org>
209 * xterm.c (x_draw_image_relief): Add missing type check for
210 Vtool_bar_button_margin (Bug#10743).
212 2012-02-21 Chong Yidong <cyd@gnu.org>
214 * fileio.c (Vfile_name_handler_alist): Doc fix.
216 * buffer.c (Fget_file_buffer): Protect against invalid file
217 handler return value.
219 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
221 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
222 when computing $valmask.
224 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
225 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
226 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
227 It's useless in that case, and it can cause problems on hosts
228 that allocate halves of EMACS_INT values separately.
229 Reported by Dan Horák. Diagnosed by Andreas Schwab in
230 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
231 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
232 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
233 it avoids undefined behavior on hosts where shifting right by more
234 than the word width has undefined behavior.
236 2012-02-19 Chong Yidong <cyd@gnu.org>
238 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
239 (Funhandled_file_name_directory, Ffile_name_as_directory)
240 (Fdirectory_file_name, Fexpand_file_name)
241 (Fsubstitute_in_file_name): Protect against invalid file handler
242 return values (Bug#10845).
244 2012-02-18 Eli Zaretskii <eliz@gnu.org>
246 * .gdbinit (pitx): Fix incorrect references to fields of the
249 2012-02-17 Chong Yidong <cyd@gnu.org>
251 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
253 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
255 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
256 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
258 2012-02-15 Chong Yidong <cyd@gnu.org>
260 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
261 marked as special. Also, starting docstrings with * is obsolete.
263 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
265 * gnutls.c (emacs_gnutls_write): Fix last change.
267 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
269 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
272 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
274 * keymap.c (Fsingle_key_description): Handle char ranges.
276 2012-02-12 Chong Yidong <cyd@gnu.org>
278 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
279 as that creates a dangerous corner case.
281 * window.c (Fdelete_window_internal): Invalidate the mouse
282 highlight (Bug#9904).
284 2012-02-12 Glenn Morris <rgm@gnu.org>
286 * xselect.c (Fx_own_selection_internal)
287 (Fx_get_selection_internal, Fx_disown_selection_internal)
288 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
289 * nsselect.m (Fx_own_selection_internal)
290 (Fx_disown_selection_internal, Fx_selection_exists_p)
291 (Fx_selection_owner_p, Fx_get_selection_internal):
292 Sync docs and argument specs with the xselect.c versions.
294 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
296 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
298 2012-02-11 Eli Zaretskii <eliz@gnu.org>
300 * w32select.c (Fx_selection_exists_p): Sync doc string and
301 argument list with xselect.c. (Bug#10783)
303 * w16select.c (Fx_selection_exists_p): Sync doc string and
304 argument list with xselect.c. (Bug#10783)
306 2012-02-10 Glenn Morris <rgm@gnu.org>
308 * fns.c (Fsecure_hash): Doc fix.
310 2012-02-09 Kenichi Handa <handa@m17n.org>
312 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
314 2012-02-07 Chong Yidong <cyd@gnu.org>
316 * buffer.c (Fbuffer_local_variables)
317 (buffer_lisp_local_variables): Handle unbound vars correctly;
318 don't let Qunbound leak into Lisp.
320 2012-02-07 Glenn Morris <rgm@gnu.org>
322 * image.c (Fimagemagick_types): Doc fix.
324 * image.c (imagemagick-render-type): Change it from a lisp object
325 to an integer. Move the doc here from the lisp manual.
326 Treat all values not equal to 0 the same.
328 2012-02-06 Chong Yidong <cyd@gnu.org>
330 * doc.c (store_function_docstring): Avoid applying docstring of
331 alias to base function (Bug#2603).
333 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
335 * .gdbinit (pp1, pv1): Remove redundant defines.
338 2012-02-04 Chong Yidong <cyd@gnu.org>
340 * nsterm.m: Declare a global (Bug#10694).
342 2012-02-04 Eli Zaretskii <eliz@gnu.org>
344 * w32.c (get_emacs_configuration_options):
345 Include --enable-checking, if specified, in the return value.
347 2012-02-04 Martin Rudalics <rudalics@gmx.at>
349 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
350 after rounding frame sizes. (Bug#9723)
352 2012-02-04 Eli Zaretskii <eliz@gnu.org>
354 * keyboard.c (adjust_point_for_property): Don't position point
355 before BEGV. (Bug#10696)
357 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
359 Handle overflow when computing char display width (Bug#9496).
360 * character.c (char_width): Return EMACS_INT, not int.
361 (char_width, c_string_width): Check for overflow when
362 computing the width; this is possible now that individual
363 characters can have unbounded width. Problem introduced
364 by merge from Emacs 23 on 2012-01-19.
366 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
368 * dbusbind.c (Fdbus_register_method): Mention the return value
369 :ignore in the docstring.
371 2012-02-02 Glenn Morris <rgm@gnu.org>
373 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
375 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
376 Unconditionally set to t. (Bug#10673)
377 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
378 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
379 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
381 2012-02-02 Kenichi Handa <handa@m17n.org>
383 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
384 0, do not call append_composite_glyph.
386 2012-02-02 Kenichi Handa <handa@m17n.org>
388 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
390 (x_produce_glyphs): If the component of a composition is a null
391 string, set it->pixel_width to 1 to avoid zero-width glyph.
393 2012-02-01 Eli Zaretskii <eliz@gnu.org>
395 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
396 first 2 arguments are identical. This makes inserting large
397 output from a subprocess an order of magnitude faster on
398 MS-Windows, where all sbrk'ed memory is always contiguous.
400 2012-01-31 Glenn Morris <rgm@gnu.org>
402 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
403 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
404 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
406 2012-01-29 Glenn Morris <rgm@gnu.org>
408 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
410 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
412 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
414 2012-01-28 Chong Yidong <cyd@gnu.org>
416 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
418 2012-01-26 Chong Yidong <cyd@gnu.org>
420 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
422 * search.c (Fsearch_forward, Fsearch_backward): Document negative
423 repeat counts (Bug#10507).
425 2012-01-26 Glenn Morris <rgm@gnu.org>
427 * lread.c (syms_of_lread): Doc fix.
429 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
431 * coding.c (encode_designation_at_bol): Change return value to
434 2012-01-25 Chong Yidong <cyd@gnu.org>
436 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
438 2012-01-21 Chong Yidong <cyd@gnu.org>
440 * floatfns.c (Fcopysign): Make the second argument non-optional,
441 since nil is not allowed anyway.
443 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
445 * process.c (read_process_output): Use p instead of XPROCESS (proc).
446 (send_process): Likewise.
448 2012-01-19 Martin Rudalics <rudalics@gmx.at>
450 * window.c (save_window_save, Fcurrent_window_configuration)
451 (Vwindow_persistent_parameters): Do not use Qstate.
454 2012-01-19 Kenichi Handa <handa@m17n.org>
456 * character.c (char_width): New function.
457 (Fchar_width, c_string_width, lisp_string_width):
458 Use char_width (Bug#9496).
460 2012-01-16 Martin Rudalics <rudalics@gmx.at>
462 * window.c (Vwindow_persistent_parameters): New variable.
463 (Fset_window_configuration, save_window_save): Handle persistent
466 2012-01-14 Eli Zaretskii <eliz@gnu.org>
468 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
469 thrashing the stack of the thread. (Bug#9087)
471 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
473 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
475 2012-01-11 Eli Zaretskii <eliz@gnu.org>
477 * xdisp.c (rows_from_pos_range): Handle the case where the
478 highlight ends on a newline. (Bug#10464)
479 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
480 he end column for display of highlight that ends on a newline
483 2012-01-11 Glenn Morris <rgm@gnu.org>
485 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
486 from load-path also when installation-directory is nil. (Bug#10208)
488 2012-01-10 Glenn Morris <rgm@gnu.org>
490 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
492 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
493 Update template values to be closer to their typical values these days.
495 2012-01-09 Eli Zaretskii <eliz@gnu.org>
497 * xdisp.c (rows_from_pos_range): Accept additional argument
498 DISP_STRING, and accept any glyph in a row whose object is that
499 string as eligible for mouse highlight. Fixes mouse highlight of
500 display strings from overlays. (Bug#10464)
502 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
504 emacs: fix an auto-save permissions race condition (Bug#10400)
505 * fileio.c (auto_saving_dir_umask): New static var.
506 (Fmake_directory_internal): Use it.
507 (do_auto_save_make_dir): Set it, instead of invoking chmod after
508 creating the directory. The old code temporarily assigns
509 too-generous permissions to the directory.
510 (do_auto_save_eh): Clear it.
511 (Fdo_auto_save): Catch all errors, not just file errors, so
512 that the var is always cleared.
514 2012-01-07 Eli Zaretskii <eliz@gnu.org>
516 * search.c (scan_buffer): Pass character positions to
517 know_region_cache, not byte positions. (Bug#6540)
519 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
521 * w32.c (sys_rename): Report EXDEV when rename of a directory
522 fails because the target is on another logical disk. (Bug#10284)
524 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
526 * xterm.c (x_embed_request_focus): New function.
528 * xterm.h: Add prototype.
530 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
532 2012-01-05 Glenn Morris <rgm@gnu.org>
534 * emacs.c (emacs_copyright): Update short copyright year to 2012.
536 2012-01-01 Eli Zaretskii <eliz@gnu.org>
538 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
539 Load gnutls_transport_set_lowat only if GnuTLS version is below
541 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
542 GnuTLS versions below 2.11.1.
544 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
546 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
547 to the doc string advising against its use for altering the way
548 windows are scrolled.
550 2011-12-28 Kenichi Handa <handa@m17n.org>
552 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
553 coding-system ASCII compatible only when it does not produce BOM
554 on encoding (Bug#10383).
556 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
558 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
560 (create_and_show_popup_menu): Always use menu_position_func for
563 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
565 * callint.c (Fcall_interactively): Don't truncate prompt string.
567 2011-12-23 Eli Zaretskii <eliz@gnu.org>
569 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
570 property that ends at ZV, so that the bidi iteration could be
571 resumed from there (after widening). (Bug#10360)
573 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
575 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
577 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
579 * nsterm.m (x_free_frame_resources):
580 Release f->output_data.ns->miniimage.
581 (ns_index_color): Fix indentation. Do not retain
582 color_table->colors[i].
584 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
587 * nsfns.m (x_set_background_color): Assign return value from
588 ns_index_color to face-background instead of NSColor*.
589 (ns_implicitly_set_icon_type): Fix indentation.
590 Change assignment in for loop to comparison.
592 * emacs.c (ns_pool): New variable.
593 (main): Assign ns_pool.
594 (Fkill_emacs): Call ns_release_autorelease_pool.
596 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
597 autorelease fdesc, release fdAttrs and tdict.
598 (ns_get_covering_families): Release charset.
599 (ns_findfonts): Release NSFontDescriptor created with new.
600 (ns_uni_to_glyphs): Fix indentation.
601 (setString): Release attrStr before assigning new value.
603 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
605 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
607 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
608 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
610 2011-12-18 David Reitter <reitter@cmu.edu>
612 * nsterm.m (ns_term_init): Subscribe for notifications
613 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
614 to method trackingNotification in EmacsMenu.
616 * nsmenu.m (trackingMenu): New variable.
617 (trackingNotification): New method (from Aquamacs).
618 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
619 from Aquamacs (Bug#7030).
621 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
623 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
624 (symbol_to_nsstring): Fix indentation.
625 (ns_symbol_to_pb): New function.
626 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
627 (Fns_rotate_cut_buffers_internal): Remove.
628 (Fns_store_selection_internal): Rename from
629 Fns_store_cut_buffer_internal.
630 (ns_get_foreign_selection, Fx_own_selection_internal)
631 (Fx_disown_selection_internal, Fx_selection_exists_p)
632 (Fns_get_selection_internal, Fns_store_selection_internal):
633 Use ns_symbol_to_pb and check if return value is nil.
634 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
635 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
636 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
637 renamed to Sns_store_selection_internal.
638 (ns_handle_selection_request): Move code to Fx_own_selection_internal
639 and remove this function.
640 (ns_handle_selection_clear): Remove, never used.
641 (Fx_own_selection_internal): Move code from ns_handle_selection_request
644 2011-12-17 Ken Brown <kbrown@cornell.edu>
646 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
647 GID is unknown (Bug#10257).
649 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
651 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
652 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
653 which caused a build failure on GNU/Linux IA-64. This problem was
654 introduced by my 2011-10-07 patch.
656 2011-12-15 Juri Linkov <juri@jurta.org>
658 * image.c (imagemagick_error): New function. (Bug#10112)
659 (imagemagick_load_image): Comment out `MagickSetResolution' call.
660 Use `imagemagick_error' where ImageMagick functions return
662 (Fimagemagick_types): Add `Fnreverse' to return the list in the
665 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
667 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
668 fill background (Bug#8992).
670 2011-12-13 Martin Rudalics <rudalics@gmx.at>
672 * window.c (Vwindow_combination_resize)
673 (Vwindow_combination_limit): Use t instead of non-nil in
675 (Vrecenter_redisplay): Add first sentence of doc-string on
677 (Frecenter): Fix doc-string typo.
679 2011-12-11 Kenichi Handa <handa@m17n.org>
681 * coding.c (Funencodable_char_position): Pay attention to the
682 buffer text relocation (Bug#9389).
684 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
686 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
687 gtk_init (Bug#10100).
689 2011-12-10 Eli Zaretskii <eliz@gnu.org>
691 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
692 IT->string is nil. (Bug#10263)
694 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
696 * nsterm.h (x_free_frame_resources): Declare.
698 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
699 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
701 * nsterm.h (ns_get_defaults_value): Declare.
703 * nsterm.m (ns_default): Call ns_get_defaults_value.
705 2011-12-09 Eli Zaretskii <eliz@gnu.org>
707 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
710 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
712 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
713 that where the value of an _OBJC_* symbol points to is in the .bss
716 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
718 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
719 after the loop to call ccl_driver at least once (Bug#8619).
721 2011-12-08 Kenichi Handa <handa@m17n.org>
723 * ftfont.c (get_adstyle_property): Fix previous change
726 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
728 * w32.c (init_environment): If no_site_lisp, remove site-lisp
729 dirs from the default value of EMACSLOADPATH (bug#10208).
731 2011-12-07 Glenn Morris <rgm@gnu.org>
733 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
734 installation and source directories as well. (Bug#10208)
736 2011-12-06 Chong Yidong <cyd@gnu.org>
738 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
740 2011-12-06 Glenn Morris <rgm@gnu.org>
742 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
743 as an error, not just -1. (Bug#10217)
745 2011-12-05 Chong Yidong <cyd@gnu.org>
747 * keyboard.c (process_special_events): New function.
748 (swallow_events, Finput_pending_p): Use it (Bug#10195).
750 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
752 * coding.c (encode_designation_at_bol): Don't use uninitialized
753 local variable (Bug#9318).
755 2011-12-05 Kenichi Handa <handa@m17n.org>
757 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
758 return Qnil (Bug#8046, Bug#10193).
760 2011-12-05 Kenichi Handa <handa@m17n.org>
762 * coding.c (encode_designation_at_bol): New args charbuf_end and
763 dst. Return the number of produced bytes. Callers changed.
764 (coding_set_source): Return how many bytes coding->source was
766 (coding_set_destination): Return how many bytes
767 coding->destination was relocated.
768 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
769 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
771 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
773 * coding.c (CODING_CHAR_CHARSET_P): New macro.
774 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
777 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
779 The following changes are to fix Bug#9318.
781 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
782 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
783 (encode_coding_iso_2022, encode_coding_sjis)
784 (encode_coding_big5, encode_coding_charset): Use the above macros.
786 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
788 * lisp.h (process_quit_flag): Fix external declaration.
790 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
792 Don't macro-inline non-performance-critical code.
793 * eval.c (process_quit_flag): New function.
794 * lisp.h (QUIT): Use it.
796 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
798 * nsfns.m (get_geometry_from_preferences): New function.
799 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
801 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
803 * emacs.c (Qkill_emacs): Define.
804 (syms_of_emacs): Initialize it.
805 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
806 Qquit_flag to `kill-emacs' instead.
807 (quit_throw_to_read_char): Add parameter `from_signal'.
808 All callers changed. Call Fkill_emacs if requested and safe.
809 * lisp.h (QUIT): Call Fkill_emacs if requested.
811 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
813 * widget.c (update_wm_hints): Return if wmshell is null.
814 (widget_update_wm_size_hints): New function.
816 * widget.h (widget_update_wm_size_hints): Declare.
818 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
819 widget_update_wm_size_hints (Bug#10104).
821 2011-12-03 Eli Zaretskii <eliz@gnu.org>
823 * xdisp.c (handle_invisible_prop): If the invisible text ends just
824 before a newline, prepare the bidi iterator for consuming the
825 newline, and keep the current paragraph direction. (Bug#10183)
826 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
828 2011-12-02 Juri Linkov <juri@jurta.org>
830 * search.c (Fword_search_regexp): New Lisp function created from
831 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
832 (Fword_search_backward, Fword_search_forward)
833 (Fword_search_backward_lax, Fword_search_forward_lax):
834 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
835 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
837 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
839 * fileio.c (Finsert_file_contents): Move after-change-function call
840 to before the "handled:" label, since all "goto handled" appear in
841 cases where the *-change-functions have already been properly called
844 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
846 * keyboard.c (interrupt_signal): Don't call kill-emacs when
847 waiting for input. (Bug#10169)
849 2011-11-30 Eli Zaretskii <eliz@gnu.org>
851 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
852 verifies glyph row's hash code--we have just reallocated the
853 glyphs, so their contents can be complete garbage. (Bug#10164)
855 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
857 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
859 2011-11-30 Eli Zaretskii <eliz@gnu.org>
861 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
862 attributes are tested _before_ calling verify_row_hash, to protect
863 against GCC re-ordering of the tests. (Bug#10164)
865 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
867 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
869 * xterm.c (handle_one_xevent): Only set async_visible and friends
870 if net_wm_state_hidden_seen is non-zero (Bug#10002)
871 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
872 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
874 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
876 Remove GCPRO-related macros that exist only to avoid shadowing locals.
877 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
878 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
879 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
880 All uses changed to use GCPRO1 etc.
881 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
882 Revert to old implementation (i.e., before 2011-03-11).
884 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
886 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
887 of scroll runs so as to avoid assigning disabled bogus rows and
888 unnecessary graphics copy operations.
890 2011-11-27 Eli Zaretskii <eliz@gnu.org>
892 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
893 (snprintf) [_MSC_VER]: Redirect to _snprintf.
894 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
895 (malloc, free, realloc, calloc): Redirect to e_* only when
898 * lisp.h (GCTYPEBITS): Move before first use.
899 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
900 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
901 this macro definition.
903 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
906 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
908 * gtkutil.c (xg_create_frame_widgets):
909 Call gtk_window_set_has_resize_grip (FALSE) if that function is
910 present with Gtk+ 2.0.
912 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
914 * fileio.c (Finsert_file_contents): Undo previous change; see
915 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
917 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
919 Rename locals to avoid shadowing.
920 * fileio.c (Finsert_file_contents):
921 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
922 * process.c (wait_reading_process_output):
923 Rename inner 'proc' to 'p' to avoid shadowing.
924 Indent for consistency with usual Emacs style.
926 2011-11-25 Eli Zaretskii <eliz@gnu.org>
928 * xdisp.c (redisplay_window): If cursor row is not fully visible
929 after recentering, and scroll-conservatively is set to a large
930 number, scroll window by a few more lines to make the cursor fully
931 visible and out of scroll-margin. (Bug#10105)
932 (start_display): Don't move to the next line if the display should
933 start at a newline that is part of a display vector or an overlay
936 2011-11-24 Juri Linkov <juri@jurta.org>
938 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
939 after the `MagickPingImage' call. (Bug#10112)
941 2011-11-23 Chong Yidong <cyd@gnu.org>
943 * window.c (Fcoordinates_in_window_p): Accept only live windows.
945 2011-11-23 Martin Rudalics <rudalics@gmx.at>
947 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
948 making another buffer current. (Bug#10114)
950 2011-11-23 Glenn Morris <rgm@gnu.org>
952 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
954 2011-11-23 Chong Yidong <cyd@gnu.org>
956 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
959 2011-11-22 Eli Zaretskii <eliz@gnu.org>
961 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
962 and header-lines, as they don't have one computed for them.
965 * .gdbinit (prow): Make displayed values more self-explaining.
968 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
970 * process.c (wait_reading_process_output): Fix asynchrounous
971 GnuTLS socket handling on some versions of the GnuTLS library.
972 (wait_reading_process_output): Add comment and URL.
974 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
976 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
978 2011-11-21 Chong Yidong <cyd@gnu.org>
980 * window.c (Fnext_window, Fprevious_window): Doc fix.
982 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
984 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
986 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
988 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
990 2011-11-20 Martin Rudalics <rudalics@gmx.at>
992 * window.c (Fset_window_combination_limit): Rename argument
994 (Vwindow_combination_limit): Remove "status" from doc-string.
996 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
998 * m/ibms390.h: Remove.
999 * m/ibms390x.h: Don't include "ibms390.h".
1001 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1003 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1004 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1006 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1008 * casetab.c (Fset_case_table):
1009 * charset.c (Fcharset_after): Fix typos.
1011 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1013 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1014 Otherwise, valgrind does not work on some platforms.
1015 Problem reported by Andreas Schwab in
1016 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1017 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1018 is set, removing the need for VIRT_ADDRESS_VARIES.
1019 (PURE_P): Use a more-efficient implementation that needs just one
1020 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1021 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1022 to 4 (xorl, subq, cmpq, setbe).
1023 * alloc.c (pure): Always extern now, since that's the
1024 VIRT_ADDR_VARIES behavior.
1025 (PURE_POINTER_P): Use a single comparison, not two, for
1026 consistency with the new puresize.h.
1027 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1028 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1029 Remove VIRT_ADDR_VARIES no longer needed.
1031 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1033 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1034 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1035 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1036 behave as if the cursor position were at the window margin.
1038 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1039 and the cursor position is out of bounds, behave as if the cursor
1040 position were at the window margin. (Bug#10075)
1042 2011-11-18 Chong Yidong <cyd@gnu.org>
1044 * window.c (Fwindow_combination_limit): Make first argument
1045 non-optional, since it is meaningless for live windows like the
1048 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1050 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1052 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1054 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1055 (graft_intervals_into_buffer): Simplify.
1057 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1059 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1060 hash values of the two rows.
1061 (copy_row_except_pointers): Preserve the used[] arrays and the
1062 hash values of the two rows. (Bug#10035)
1063 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1065 * xdisp.c (row_hash): New function, body extracted from
1066 compute_line_metrics.
1067 (compute_line_metrics): Call row_hash, instead of computing the
1070 * dispnew.c (verify_row_hash): Call row_hash for computing the
1071 hash code of a row, instead of duplicating code from xdisp.c.
1073 * dispextern.h (row_hash): Add prototype.
1075 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1077 * frame.c (delete_frame): Don't delete the terminal when the last
1078 X frame is closed if emacs is built with GTK toolkit.
1080 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1082 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1084 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1086 * window.c (Vwindow_splits): Rename to
1087 Vwindow_combination_resize. Suggested by Juri Linkov.
1088 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1091 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1093 * nsfns.m (Fns_font_name):
1094 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1096 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1098 * window.h (window): Rename slot "nest" to "combination_limit".
1099 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1100 (Fset_window_nest): Rename to Fset_window_combination_limit.
1101 (Vwindow_nest): Rename to Vwindow_combination_limit.
1102 (recombine_windows, make_parent_window, make_window)
1103 (Fsplit_window_internal, saved_window)
1104 (Fset_window_configuration, save_window_save): Rename all
1105 occurrences of window_nest to window_combination_limit.
1107 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1109 * image.c (imagemagick_load_image): Fix typo.
1111 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1113 * xdisp.c (display_line): Move the call to
1114 highlight_trailing_whitespace before the call to
1115 compute_line_metrics, since the latter needs to see the final
1116 faces of all the glyphs to compute ROW's hash value.
1117 Fixes assertion violations in row_equal_p. (Bug#10035)
1119 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1121 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1122 just return (bug#10044).
1124 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1126 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1127 with user-defined heap size. Bump the default size of the temacs
1128 heap to 27MB, to avoid memory warning when running temacs.
1129 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1131 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1132 current_matrix and desired_matrix. (Bug#9990)
1133 (verify_row_hash) [XASSERTS]: New function.
1134 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1135 that the hash value of glyph rows is correct.
1137 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1139 * window.h (window): Remove splits slot.
1140 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1141 (Fdelete_other_windows_internal, make_parent_window)
1142 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1143 (Fset_window_configuration, save_window_save): Don't deal with
1144 split status of windows.
1145 (saved_window): Remove splits slot.
1146 (Vwindow_splits): Rewrite doc-string.
1148 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1150 * xfns.c (unwind_create_frame):
1151 * nsfns.m (unwind_create_frame):
1152 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1153 Vframe_list (Bug#9999).
1155 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1157 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1159 2011-11-11 Kenichi Handa <handa@m17n.org>
1161 * callproc.c (Fcall_process): Set the member dst_multibyte of
1164 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1166 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1167 avoid a crash (bug#9496).
1169 2011-11-09 Chong Yidong <cyd@gnu.org>
1171 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1172 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1174 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1176 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1178 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1180 Avoid some portability problems by eschewing 'extern inline' functions.
1181 The trivial performance wins aren't worth the portability hassles; see
1182 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1184 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1185 (window_box_width, window_box_left, window_box_left_offset)
1186 (window_box_right, window_box_right_offset): Undo previous change,
1187 by removing the "extern"s.
1188 * intervals.c (adjust_intervals_for_insertion)
1189 (adjust_intervals_for_deletion): Undo previous change,
1190 making these static again.
1191 (offset_intervals, temp_set_point_both, temp_set_point)
1192 (copy_intervals_to_string): No longer inline.
1193 * xdisp.c (window_text_bottom_y, window_box_width)
1194 (window_box_height, window_box_left_offset)
1195 (window_box_right_offset, window_box_left, window_box_right)
1196 (window_box): No longer inline.
1198 2011-11-08 Chong Yidong <cyd@gnu.org>
1200 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1201 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1202 Signal an error if not a live window.
1203 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1204 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1206 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1208 * lisp.h (syms_of_abbrev): Remove declaration.
1209 Reported by CHENG Gao <chenggao@royau.me>.
1211 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1213 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1214 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1215 of temacs in GUI mode.
1217 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1219 * window.h: Declare delete_all_child_windows instead of
1220 delete_all_subwindows.
1221 * window.c (Fwindow_nest, Fset_window_nest)
1222 (Fset_window_new_total, Fset_window_new_normal)
1223 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1224 (delete_all_subwindows): Rename to delete_all_child_windows.
1225 (Fdelete_other_windows_internal, Fset_window_configuration):
1226 Call delete_all_child_windows instead of delete_all_subwindows.
1227 * frame.c (delete_frame): Call delete_all_child_windows instead
1228 of delete_all_subwindows.
1230 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1232 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1233 This is also needed for porting to any host where GC_MARK_STACK is
1234 not GC_MAKE_GCPROS_NOOPS.
1235 (which_symbols): Use it.
1237 2011-11-07 Kenichi Handa <handa@m17n.org>
1239 * coding.c (coding_set_destination): Check coding->src_pos only
1240 when coding->src_object is a buffer (bug#9910).
1242 * process.c (send_process): Set the member src_multibyte of coding
1243 to 0 (bug#9911) when sending a unibyte text.
1245 * callproc.c (Fcall_process): Set the member src_multibyte of
1246 process_coding to 0 (bug#9912).
1248 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1250 * xmenu.c (cleanup_widget_value_tree): New function.
1251 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1252 calling free_menubar_widget_value_tree directly (Bug#9830).
1254 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1256 Fix some portability problems with 'inline'.
1257 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1258 (window_box_width, window_box_left, window_box_left_offset)
1259 (window_box_right, window_box_right_offset): Declare extern.
1260 Otherwise, these inline functions do not conform to C99 and
1261 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1262 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1263 * intervals.c (adjust_intervals_for_insertion)
1264 (adjust_intervals_for_deletion): Now extern, because otherwise the
1265 extern inline functions 'offset_intervals' couldn't refer to it.
1266 (static_offset_intervals): Remove.
1267 (offset_intervals): Rewrite using the old contents of
1268 static_offset_intervals. The old version didn't conform to C99
1269 because an extern inline function contained a reference to an
1270 identifier with static linkage.
1272 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1274 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1277 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1279 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1280 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1281 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1282 return Qleft_to_right.
1284 2011-11-06 Chong Yidong <cyd@gnu.org>
1286 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1287 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1288 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1289 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1290 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1291 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1292 (Fwindow_vscroll): Doc fix.
1293 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1294 argument, since it makes no sense to pass a live window and for
1295 consistency with window-child.
1297 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1299 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1302 2011-11-05 Jason Rumney <jasonr@gnu.org>
1304 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1305 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1307 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1308 bitwise arithmetic preventing use of unicode-sip and non-truetype
1311 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1313 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1316 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1317 initialization code to keep similarity to xfns.c after changes
1320 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1322 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1323 (unwind_create_frame): New function (Bug#9943).
1324 (Fx_create_frame): Restructure code to be more similar to the one in
1325 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1326 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1327 Move terminal->reference_count++ just before making the frame official
1330 * nsterm.m (x_free_frame_resources): New function.
1331 (x_destroy_window): Move code to x_free_frame_resources.
1333 * xfns.c (unwind_create_frame): Fix comment.
1334 (Fx_create_frame, x_create_tip_frame):
1335 Move terminal->reference_count++ just before making the frame
1336 official. Move initialization of image_cache_refcount and
1337 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1339 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1341 Support MSVC build with newer versions of Visual Studio.
1342 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1343 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1346 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1347 which are not supported by MSVC.
1348 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1349 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1351 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1353 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1355 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1357 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1359 Support MSVC build with newer versions of Visual Studio.
1360 * w32.c: Don't include w32api.h for MSVC.
1361 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1363 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1364 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1365 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1366 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1368 (alloca) [_MSC_VER]: Define to _alloca.
1370 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1372 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1374 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1376 * xdisp.c (note_mouse_highlight): If either of
1377 previous/next-single-property-change returns nil, treat that as
1378 the beginning or the end of the buffer. (Bug#9955)
1380 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1382 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1383 label is not null (Bug#9951).
1384 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1387 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1389 * window.c (Fwindow_body_size): Mention in the doc string that the
1390 return value is in frame's canonical units. (Bug#9949)
1392 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1394 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1396 * w32fns.c (unwind_create_frame): If needed, free the glyph
1397 matrices of the partially constructed frame. (Bug#9943)
1398 * xfns.c (unwind_create_frame): Likewise.
1400 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1402 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1403 Don't stop backward scan on the continuation glyph, even though
1404 its CHARPOS is positive.
1405 (mouse_face_from_buffer_pos, note_mouse_highlight):
1406 Rename cover_string to disp_string.
1408 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1410 * window.c (temp_output_buffer_show): Don't use
1411 Vtemp_buffer_show_specifiers.
1412 (Vtemp_buffer_show_specifiers): Remove unused variable.
1414 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1416 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1417 past the beginning of the current glyph matrix.
1419 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1421 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1422 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1423 HAVE_GTK3 (Bug#9869).
1425 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1426 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1428 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1430 * xterm.c: Declare x_handle_net_wm_state to return int.
1431 (handle_one_xevent): Check if we are iconified but don't have
1432 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1433 (get_current_wm_state): Return non-zero if not hidden,
1434 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1435 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1436 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1437 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1439 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1441 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1442 so that this new function doesn't get optimized away by a
1443 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1445 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1447 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1449 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1451 Fix the `xbytecode' command.
1452 * .gdbinit (xprintbytestr): New command.
1453 (xwhichsymbols): Rename from `which'; all callers changed.
1454 (xbytecode): Print the byte-code string as well.
1456 2011-10-29 Kim Storm <storm@cua.dk>
1458 * alloc.c (which_symbols): New function.
1460 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1462 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1465 2011-10-29 Glenn Morris <rgm@gnu.org>
1467 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1468 Not clear what it was for, and it causes various bugs. (Bug#9839)
1470 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1472 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1473 possible random value that matches one of those tested as
1474 condition to clear the mouse face.
1476 2011-10-28 Chong Yidong <cyd@gnu.org>
1478 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1480 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1482 * window.c (make_window): Initialize phys_cursor_on_p.
1484 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1486 * lisp.h (struct Lisp_Symbol): Update comments.
1488 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1490 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1492 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1494 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1495 <oslsachem@gmail.com> for helping to debug this.
1497 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1498 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1499 (g_b_init_get_glyph_outline_w): New static variables.
1500 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1501 (GetGlyphOutlineW_Proc): New typedefs.
1502 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1503 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1505 (w32font_open_internal, compute_metrics):
1506 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1507 instead of calling the "wide" APIs directly.
1509 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1511 * w32.h (syms_of_w32font): Add prototype.
1513 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1515 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1516 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1517 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1518 (Fmove_to_window_line): Doc fix.
1520 2011-10-27 Chong Yidong <cyd@gnu.org>
1522 * process.c (make_process): Set gnutls_state to NULL.
1524 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1525 non-NULL, regardless of GNUTLS_INITSTAGE.
1526 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1527 an error. Set process slots as soon as we allocate them.
1529 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1531 2011-10-27 Chong Yidong <cyd@gnu.org>
1533 * gnutls.c (emacs_gnutls_deinit): New function.
1534 Deallocate credentials structures as well as calling gnutls_deinit.
1535 (Fgnutls_deinit, Fgnutls_boot): Use it.
1537 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1538 (deactivate_process): Call emacs_gnutls_deinit.
1540 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1542 * image.c (x_create_x_image_and_pixmap):
1543 * w32.c (sys_rename, w32_delayed_load):
1544 * w32font.c (fill_in_logfont):
1545 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1547 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1549 * w32fns.c (w32_default_color_map): New function,
1550 extracted from Fw32_default_color_map.
1551 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1553 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1555 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1557 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1559 * keyboard.c (test_undefined): New function (bug#9751).
1560 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1562 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1564 * sysdep.c (init_sys_modes): Fix the check for the controlling
1565 terminal (Bug#6649).
1567 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1569 * dispextern.h (struct bidi_it): New member next_en_type.
1571 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1572 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1573 current character, check also for next_en_type being WEAK_EN.
1574 (bidi_resolve_weak): Don't enter the expensive loop if the current
1575 position is before next_en_pos. Record the bidi type of the first
1576 non-ET, non-BN character we find, in addition to its position.
1577 (bidi_level_of_next_char): Invalidate next_en_type when
1578 next_en_pos is over-stepped.
1580 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1582 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1583 * editfns.c: Rewrite current-time-zone so that it invokes
1584 the equivalent of (format-time-string "%Z") to get the time zone name.
1585 This fixes a bug when the time zone name contains characters that
1586 need converting from the system time locale to Emacs internal format.
1587 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1588 that patch fixed format-time-string to do the conversion, but
1589 I forgot to fix current-time-zone.
1590 (format_time_string): New function, containing most of
1591 what Fformat_time_string used to contain.
1592 (Fformat_time_string): Rewrite in terms of format_time_string.
1593 This doesn't change this function's behavior.
1594 (current-time-zone): Rewrite to use format_time_string.
1595 This fixes the bug reported by Michael Schierl in
1596 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1597 Jason Rumney's 2007-06-07 change worked around this bug, but
1599 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1601 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1603 * xdisp.c (start_display): If the character at POS is displayed
1604 via a display vector, reset IT->current.dpvec_index to zero.
1605 (try_window_reusing_current_matrix): If a line ends in a display
1606 vector or the next line starts in a display vector, continue
1607 redrawing the window even though the character position of
1608 start_row was reached.
1611 2011-10-18 Chong Yidong <cyd@gnu.org>
1613 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1614 with nobreak-char-display too.
1616 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1618 Fix part 3 of bug#9771.
1619 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1620 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1621 non-neutral characters if the current character is a paragraph
1622 separator (a.k.a. Newline). This avoids running the same
1623 expensive loop twice, once when we consume the preceding newline
1624 and the other time when the line actually needs to be displayed.
1625 Avoid the loop when we see neutrals on the base embedding level
1626 following a character whose directionality is the same as the
1627 paragraph's. This avoids running the expensive loop when a line
1628 ends in a long sequence of neutrals, like control characters.
1629 Add assertion against STRONG_AL type. Slightly rearrange code
1630 that determines the type of a neutral given the first non-neutral
1632 (bidi_level_of_next_char): Set next_en_pos to zero when
1633 invalidating its info.
1635 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1637 * xdisp.c (push_display_prop): Determine whether to record string
1638 or buffer position by IT->string, not by IT->method. Allow
1639 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1640 (move_it_vertically_backward): Don't look for character position
1641 immediately after the newline when in a continuation line.
1644 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1646 * window.c (coordinates_in_window): Rewrite and delabelize
1647 vertical border check. (Bug#5357) (Bug#9618)
1649 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1651 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1652 errors in XSetWindowBorder (bug#9310).
1654 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1656 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1657 avoid crash when xmalloc overrun checking is enabled.
1659 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1661 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1662 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1663 cursor motion with <left> and <right> arrow keys.
1665 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1666 some callers set that themselves.
1668 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1670 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1671 display string and the previous row comes from the same string and
1672 is empty. (Bug#9739) (Bug#9738)
1674 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1676 * doc.c (get_doc_string): Encode file name (bug#9735).
1678 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1680 * bidi.c (bidi_level_of_next_char):
1681 * xdisp.c (get_visually_first_element): Remove old incorrect
1682 comments regarding the Unicode Line Separator character.
1684 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1686 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1688 * alloc.c (Fgc_status): Do not access beyond zombies array
1689 boundary if nzombies > MAX_ZOMBIES.
1690 * alloc.c (dump_zombies): Add missing format specifier.
1692 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1694 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1695 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1697 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1698 Some packages use them to denote characters with modifiers.
1700 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1702 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1703 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1704 matching a pp-number. Rename parameter var to var1.
1706 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1708 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1710 2011-10-08 Glenn Morris <rgm@gnu.org>
1712 * callint.c (Fcall_interactively): Give a more explicit error for the
1713 'c' case with a non-character input. (Bug#8479)
1715 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1717 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1719 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1720 lines that are hscrolled on the left.
1722 * dispnew.c (buffer_posn_from_coords): Account for a possible
1723 presence of header-line. (Bug#4426)
1725 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1727 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1728 Don't advertise functionality which we discourage or doesn't work.
1730 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1732 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1733 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1734 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1735 this makes Emacs dump core during garbage collection on rare
1736 occasions. sizeof is obviously inferior to offsetof here, so
1737 stick with offsetof.
1738 (GC_POINTER_ALIGNMENT): New macro.
1739 (mark_memory): Omit 3rd (offset) arg; caller changed.
1740 Don't assume EMACS_INT alignment is the same as pointer alignment.
1742 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1744 * keyboard.c (read_key_sequence_remapped): New var.
1745 (read_key_sequence): Compute remapping in the right buffer.
1746 (command_loop_1): Use read_key_sequence's remapping directly.
1748 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1750 * dired.c (file_name_completion): Don't expand file name.
1751 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1752 before checking file name handler.
1754 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1755 they've been requested explicitly (bug#9591).
1757 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1759 * keymap.c (Fsingle_key_description): Use make_specified_string
1760 instead of build_string to build string from push_key_description.
1763 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1765 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1766 This fixes a Y2038 bug on 64-bit hosts.
1767 * buffer.c (reset_buffer):
1768 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1769 (Fclear_buffer_auto_save_failure):
1770 Use 0, not -1, to represent an unset failure time, since time_t
1771 might not be signed.
1773 Remove dependency on glibc malloc internals.
1774 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1775 Move back here from lisp.h, but with their new implementations.
1776 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1777 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1778 * charset.c (charset_table_init): New static var.
1779 (syms_of_charset): Use it instead of xmalloc. This removes a
1780 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1781 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1782 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1783 Move back to alloc.c.
1784 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1785 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1787 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1789 * nsterm.m (windowDidResize): Call x_set_window_size only when
1790 ns_in_resize is true. Otherwise set pixelwidth/height and
1791 call change_frame_size (Bug#9628).
1793 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1795 Port --enable-checking=all to Fedora 14 x86-64.
1796 * charset.c (syms_of_charset): Also account for glibc malloc's
1797 internal overhead when calculating the initial malloc maximum.
1799 Port --enable-checking=all to Fedora 14 x86.
1800 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1802 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1803 (overrun_check_realloc, overrun_check_free):
1804 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1805 That way, xmalloc returns a properly-aligned pointer even if
1806 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1807 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1808 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1809 into account when calculating the initial malloc maximum.
1810 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1811 Move here from alloc.c, so that charset.c can use it too.
1812 Properly align; the old code wasn't right for common 32-bit hosts
1813 when configured with --enable-checking=all.
1814 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1815 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1817 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1819 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1822 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1824 * xdisp.c (compute_display_string_end): If there's no display
1825 string at CHARPOS, return -1.
1827 * bidi.c (bidi_fetch_char): When compute_display_string_end
1828 returns a negative value, treat the character as a normal
1829 character not covered by a display string. (Bug#9624)
1831 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1833 * lread.c (Fread_from_string): Fix typo in docstring.
1835 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1837 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1838 newline, reseat the iterator instead of bidi-iterating there one
1839 character at a time. (Bug#9610)
1840 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1841 TO_CHARPOS if the bidi iterator is at base embedding level.
1843 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1845 * lread.c (readevalloop): Use correct code for NBSP.
1846 (read1): Likewise. (Bug#9608)
1848 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1850 * dbusbind.c (Fdbus_register_signal): When service is not
1851 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1853 2011-09-25 Glenn Morris <rgm@gnu.org>
1855 * buffer.c (truncate-lines): Doc fix.
1857 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1859 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1860 (Fset_window_next_buffers): Doc fix.
1862 2011-09-24 Glenn Morris <rgm@gnu.org>
1864 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1866 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1868 Fix minor problems found by static checking.
1869 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1870 * indent.c (Fvertical_motion): Fix == vs = typo.
1872 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1874 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1875 Default value is now t. Doc fix.
1877 * indent.c (Fvertical_motion): Compute and apply the overshoot
1878 logic when moving up, not only when moving down. Fix the
1879 confusing name and values of the it_overshoot_expected variable;
1880 logic changes accordingly. (Bug#9254) (Bug#9549)
1882 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1883 CHARPOS is covered by a display string which includes newlines.
1884 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1885 is covered by a display string with embedded newlines.
1887 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1889 * dbusbind.c (Fdbus_register_signal): Add match rule to
1890 Vdbus_registered_objects_table. (Bug#9581)
1891 (Fdbus_register_method, Vdbus_registered_objects_table):
1894 2011-09-24 Jim Meyering <meyering@redhat.com>
1896 do not ignore write error for any output size
1897 The previous change was incomplete.
1898 While it makes emacs --batch detect the vast majority of stdout
1899 write failures, errors were still ignored whenever the output size is
1900 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1901 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1902 && echo FAIL: ignored write error
1903 FAIL: ignored write error
1904 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1905 && echo FAIL: ignored write error
1906 FAIL: ignored write error
1907 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1909 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1911 * emacs.c (Fkill_emacs): In noninteractive mode exit
1912 non-successfully if a write error occurred on stdout. (Bug#9574)
1914 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1916 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1919 * dispextern.h (struct it): Update the comment documenting what
1922 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1924 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1925 a display string, extend search for cursor position to end of row.
1926 (find_row_edges): If the row ends in a newline from a display
1927 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1928 Handle the case of a display string with multiple newlines.
1929 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1930 non-empty line. Fixes confusing cursor motion with arrow keys at
1931 the beginning of a line that starts with whitespace.
1933 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1935 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1938 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1940 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1943 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1945 * xdisp.c (display_line): Record maximum and minimum buffer
1946 positions even if no glyphs were produced (e.g., by a zero-width
1947 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1948 buffer positions that will be removed from the glyph row because
1950 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1951 column is beyond frame width: don't subtract 1 "pixel" when
1952 computing width of the stretch.
1953 (reseat_at_next_visible_line_start): Undo the change made on
1954 2011-09-17 that saved paragraph information and restored it after
1955 the call to `reseat'. (Bug#9545)
1957 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1959 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1960 and turn window cursor on if cleared (Bug#9415).
1962 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1964 * search.c (boyer_moore): Take unibyte characters from pattern
1965 literally. (Bug#9458)
1967 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1969 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1971 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1973 Fix minor problem found by static checking.
1974 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1975 initialized, to pacify gcc -Wuninitialized.
1977 * fileio.c: Report proper errno when syscall falls.
1978 (Finsert_file_contents): Save and restore errno,
1979 so that report_file_error outputs the correct diagnostic.
1980 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1982 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1984 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1986 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1988 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1989 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1991 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1993 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1994 about the current paragraph and restore it after the call to reseat.
1996 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1997 (bidi_find_paragraph_start): Search back for paragraph beginning
1998 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1999 (bidi_move_to_visually_next): Only trigger paragraph-related
2000 computations when the last character is a newline or at EOB, not
2001 just any NEUTRAL_B. (Bug#9470)
2003 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2004 truncated lines if point is covered by a display string. (Bug#9524)
2006 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2008 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2009 (cons_to_x_long): New function.
2010 (lisp_data_to_selection_data): Use it. Correct the test for
2011 short-versus-long data; it was negated. Break out of vector
2012 loop, for efficiency, when a long datum is discovered.
2014 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2016 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2018 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2020 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2021 GCC PR/17406) by declaring this function with external scope.
2023 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2025 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2026 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2028 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2030 * editfns.c (Fformat): Correctly handle text properties on "%%".
2032 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2034 * xterm.c (x_draw_composite_glyph_string_foreground):
2035 * w32term.c (x_draw_composite_glyph_string_foreground):
2036 * term.c (encode_terminal_code):
2037 * composite.c (composition_update_it, get_composition_id):
2038 * xdisp.c (get_next_display_element)
2039 (fill_composite_glyph_string): Add comments about special meaning
2040 of TAB characters in a composition.
2042 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2044 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2045 This occurs when processing a multibyte format.
2046 Problem reported by Wolfgang Jenker.
2048 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2050 * xdisp.c (try_cursor_movement): Only check for exact match if
2051 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2053 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2055 Remove unused external symbols.
2056 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2057 * xdisp.c (calc_pixel_width_or_height): Now static.
2058 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2059 * indent.c (check_display_width):
2060 * w32term.c: Fix comment to match code.
2061 * xterm.c, xterm.h (x_catching_errors): Remove.
2063 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2065 * xselect.c: Use signed conversions more consistently (Bug#9498).
2066 (selection_data_to_lisp_data): Assume incoming selection data are
2067 signed integers, not unsigned. This is to be consistent with
2068 outgoing selection data, which was modified to use signed integers
2069 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2070 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2071 expects long, not unsigned long.
2073 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2075 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2076 computation of loop end. Reported by Johan Bockgård
2079 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2081 * frame.c (Fother_visible_frames_p): Function deleted.
2083 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2085 * indent.c (compute_motion): Process display vector front to back
2086 rather than the other way around. (Bug#2496)
2088 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2090 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2092 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2094 * minibuf.c (Fread_from_minibuffer): Doc fix.
2096 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2098 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2099 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2101 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2103 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2104 value for non-existent files.
2106 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2108 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2109 set its "size" to -1. This will set the modtime_size field of
2110 the corresponding buffer to -1, which is what
2111 verify-visited-file-modtime expects for files that do not exist.
2114 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2116 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2118 * lisp.h: ... from here. push_key_description is no longer
2119 defined in keyboard.c, so its declaration should not be in
2120 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2121 logically belongs with push_key_description.
2123 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2125 * buffer.h: Include <sys/types.h> instead of <time.h>.
2126 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2127 Problem reported by Herbert J. Skuhra.
2129 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2131 * xml.c (parse_region): Make the parsing work for
2132 non-comment-starting XML files again (bug#9144).
2134 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2136 * image.c (gif_load): Fix calculation of bottom and right corner.
2139 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2141 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2142 redisplay in small windows.
2144 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2146 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2148 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2150 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2151 Operate on live windows only.
2153 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2155 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2157 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2159 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2160 only under bidi iteration.
2162 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2164 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2166 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2168 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2169 Without this fix, the command to link temacs failed due to an
2170 undefined symbol __builtin_isnan. This is because
2171 /usr/include/iso/math_c99.h #defines isnan(x) to
2172 __builtin_isnan(x), but the bundled gcc, which identifies itself
2173 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2175 * floatfns.c (isnan): #undef, and then #define to a clone of
2177 (Fisnan): Always define, since it's always available now.
2178 (syms_of_floatfns): Always define isnan at the Lisp level.
2180 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2182 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2184 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2186 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2187 The previous code assumed that file offsets (off_t values) fit in
2188 EMACS_INT variables, which is not true on typical 32-bit hosts.
2189 The code messed up by falsely reporting buffer overflow in cases
2190 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2191 when "big" contains more than 2**29 bytes, even though this
2192 inserts just one byte and does not overflow the buffer.
2193 (Finsert_file_contents): Store file offsets as off_t
2194 values, not as EMACS_INT values. Check for overflow when
2195 converting between EMACS_INT and off_t. When checking for
2196 buffer overflow or for overlap, take the offsets into account.
2197 Don't use EMACS_INT for small values where int suffices.
2198 When checking for overlap, fix a typo: ZV was used where
2199 ZV_BYTE was intended.
2200 (Fwrite_region): Don't assume off_t fits into 'long'.
2201 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2203 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2205 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2207 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2209 sprintf-related integer and memory overflow issues (Bug#9412).
2211 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2212 (esprintf, exprintf, evxprintf): New functions.
2213 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2214 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2215 (modify_event_symbol): Do not assume that the length of
2216 name_alist_or_stem is safe to alloca and fits in int.
2217 (Fexecute_extended_command): Likewise for function name and binding.
2218 (Frecursion_depth): Wrap around reliably on integer overflow.
2219 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2220 since some callers pass EMACS_INT values.
2221 (Fsingle_key_description): Don't crash if symbol name contains more
2222 than MAX_ALLOCA bytes.
2223 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2224 (get_minibuffer): Arg is now EMACS_INT, not int.
2225 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2226 (esprintf, exprintf, evxprintf): New decls.
2227 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2229 * dbusbind.c (signature_cat): New function.
2230 (xd_signature, Fdbus_register_signal):
2231 Do not overrun buffer; instead, report string overflow.
2233 * dispnew.c (add_window_display_history): Don't overrun buffer.
2234 Truncate instead; this is OK since it's just a log.
2236 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2237 even if the time zone offset is outlandishly large.
2238 Don't mishandle offset == INT_MIN.
2240 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2241 when creating daemon; the previous buffer-overflow check was incorrect.
2243 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2244 which has the guts of the old verror function.
2246 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2247 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2249 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2250 (font_unparse_xlfd): Don't blindly alloca long strings.
2251 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2252 fits in int, when using sprintf. Use single snprintf to count
2253 length of string rather than counting it via multiple sprintfs;
2254 that's simpler and more reliable.
2255 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2256 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2257 sprintf, in case result does not fit in int.
2259 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2260 (fontset_from_font): Print it.
2262 * frame.c (tty_frame_count): Now printmax_t, not int.
2263 (make_terminal_frame, set_term_frame_name): Print it.
2264 (x_report_frame_params): In X, window IDs are unsigned long,
2265 not signed long, so print them as unsigned.
2266 (validate_x_resource_name): Check for implausibly long names,
2267 and don't assume name length fits in 'int'.
2268 (x_get_resource_string): Don't blindly alloca invocation name;
2269 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2272 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2273 (xg_check_special_colors, xg_set_geometry):
2274 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2276 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2277 Use esprintf, not sprintf, in case result does not fit in int.
2279 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2280 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2281 it as a large positive number.
2282 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2283 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2285 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2286 in case result does not fit in int.
2288 * print.c (float_to_string): Detect width overflow more reliably.
2289 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2290 buffer overrun. Don't assume list length fits in 'int'. Treat
2291 print length of 0 as 0, not as infinity; to be consistent with other
2292 uses of print length in this function. Don't overflow print length
2293 index. Don't assume hash table size fits in 'long', or that
2294 vectorlike size fits in 'unsigned long'.
2296 * process.c (make_process): Use printmax_t, not int, to format
2297 process-name gensyms.
2299 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2301 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2302 to avoid potential buffer overrun.
2304 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2305 if X resource line is longer than 512 bytes.
2307 * xfns.c (x_window): Make sprintf buffer a bit bigger
2308 to avoid potential buffer overrun.
2310 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2312 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2314 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2316 Integer overflow fixes for scrolling, etc.
2317 Without these, Emacs silently mishandles large integers sometimes.
2318 For example, "C-u 4294967297 M-x recenter" was treated as if
2319 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2321 * xdisp.c (try_window_id): Check Emacs fixnum range before
2322 converting to 'int'.
2324 * window.c (window_scroll_line_based, Frecenter):
2325 Check that an Emacs fixnum is in range before assigning it to 'int'.
2326 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2327 values converted from Emacs fixnums.
2328 (Frecenter): Don't wrap around a line count if it is out of 'int'
2329 range; instead, treat it as an extreme value.
2330 (Fset_window_configuration, compare_window_configurations):
2331 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2333 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2334 that can exceed INT_MAX. Check that EMACS_INT value is in range
2335 before assigning it to the (possibly-narrower) index.
2336 (match_limit): Don't assume that a fixnum can fit in 'int'.
2338 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2341 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2342 (Fvertical_motion): Don't wrap around LINES values that don't fit
2343 in 'int'. Instead, treat them as extreme values. This is good
2344 enough for windows, which can't have more than INT_MAX lines anyway.
2346 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2348 * Require libxml/parser.h to avoid compilation warning.
2350 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2352 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2353 since this reportedly can destroy thread storage.
2355 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2357 * syntax.c (find_defun_start): Update all cache variables if
2358 exiting early (Bug#9401).
2360 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2362 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2364 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2365 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2366 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2368 * term.c (tty_append_glyph): New function.
2369 (produce_stretch_glyph): Static function and its prototype deleted.
2371 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2374 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2376 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2377 when checking :margin (Bug#9390).
2378 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2379 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2380 so that the name doesn't mislead. All uses changed.
2382 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2384 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2387 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2389 * xdisp.c (move_it_to): Don't bail out early when reaching
2390 position beyond to_charpos, if we are scanning backwards.
2391 (move_it_vertically_backward): When DY == 0, make sure we get to
2392 the first character in the line after the newline.
2394 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2396 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2397 (ccl_driver): Do not generate an out-of-range pointer.
2398 (Fccl_execute_on_string): Remove unnecessary check for
2399 integer overflow, noted by Stefan Monnier in
2400 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2401 Remove a FIXME that didn't need fixing.
2402 Simplify the newly-introduced buffer reallocation code.
2404 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2406 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2408 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2410 Integer and memory overflow issues (Bug#9196).
2412 * doc.c (get_doc_string): Rework so that
2413 get_doc_string_buffer_size is the actual buffer size, rather than
2414 being 1 less than the actual buffer size; this makes xpalloc more
2417 * image.c (x_allocate_bitmap_record, cache_image):
2418 * xselect.c (Fx_register_dnd_atom):
2419 Simplify previous changes by using xpalloc.
2421 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2422 since either will do and ptrdiff_t is convenient with xpalloc.
2424 * charset.c (charset_table_size)
2425 (struct charset_sort_data.priority): Now ptrdiff_t.
2426 (charset_compare): Don't overflow if priorities differ greatly.
2427 (Fsort_charsets): Don't assume list length fits in int.
2428 Check for size-calculation overflow when allocating sort data.
2429 (syms_of_charset): Allocate an initial charset table that is
2430 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2432 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2434 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2435 The actual value is always <= INT_MAX, and leaving it unsigned made
2436 overflow checking harder.
2438 * dispextern.h (struct glyph_matrix.rows_allocated)
2439 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2440 with xpalloc. The values are still always <= INT_MAX.
2442 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2444 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2445 (SAFE_NALLOCA): New macro.
2447 * region-cache.c (struct boundary.pos, find_cache_boundary)
2448 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2449 (set_cache_region, invalidate_region_cache)
2450 (revalidate_region_cache, know_region_cache, region_cache_forward)
2451 (region_cache_backward, pp_cache):
2452 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2453 so that ptrdiff_t * can be passed to xpalloc.
2454 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2455 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2456 (pp_cache): Don't assume cache_len fits in int.
2457 * region-cache.h: Adjust extern decls to match.
2459 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2460 EMACS_INT, since either will do, for xpalloc.
2462 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2463 (xnmalloc, xnrealloc, xpalloc): New functions.
2465 * bidi.c (bidi_shelve_header_size): New constant.
2466 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2467 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2469 * bidi.c (bidi_cache_shrink):
2470 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2472 Don't update size of array until after memory allocation succeeds,
2473 because xmalloc/xrealloc may not return.
2474 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2475 now that we have proper integer overflow checking.
2476 (record_overlay_string, overlay_strings): Catch overflows when
2477 calculating size of overlay_str_buf.
2479 * callproc.c (Fcall_process): Check for size overflow when
2480 calculating size of args2.
2481 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2482 Normally we prefer signed values, but sticking with ptrdiff_t would
2483 require adding more-complicated checks.
2485 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2486 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2487 Redo buffer-overflow calculations to avoid integer overflow.
2488 Add a FIXME comment where memory seems to be over-allocated.
2490 * character.c (Fstring): Check for size-calculation overflow.
2492 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2493 unnecessary integer overflow. Check for size overflow.
2494 (encode_coding_object): Don't update size until xmalloc succeeds.
2496 * composite.c (get_composition_id): Check for overflow in glyph
2497 length calculations.
2499 Integer and memory overflow fixes for display code.
2500 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2501 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2502 (scrolling_window): Check for overflow in size calculations.
2503 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2504 Don't assume glyph table len fits in int.
2505 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2506 (row_table_size): Now ptrdiff_t, not int.
2507 (scrolling_window): Avoid overflow in size calculations.
2508 Don't update size until allocation succeeds.
2509 * fns.c (concat): Check for overflow in size calculations.
2510 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2511 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2512 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2514 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2515 (get_doc_string): Check for size calculation overflow.
2516 Don't update size until allocation succeeds.
2517 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2518 EMACS_INT, where ptrdiff_t will do.
2519 (Fsubstitute_command_keys): Check for string overflow.
2521 * editfns.c (set_time_zone_rule): Don't assume environment length
2523 (message_length): Now ptrdiff_t, not int.
2524 (Fmessage_box): Don't update size until allocation succeeds.
2525 Don't assume message length fits in int.
2526 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2528 * emacs.c (main): Do not reallocate argv, since there is a null at
2529 the end that can be overwritten, and this way there's no need to
2530 worry about size-calculation overflow.
2531 (sort_args): Check for size-calculation overflow.
2533 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2535 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2537 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2538 (x_set_scroll_bar_width, x_figure_window_size):
2539 Check for integer overflow.
2540 (x_set_alpha): Do not assume XINT fits in int.
2542 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2543 This is for the members text_lines, text_cols, total_lines, total_cols,
2544 where the system imposes an 'int' limit.
2546 * fringe.c (Fdefine_fringe_bitmap):
2547 Don't update size until alloc works.
2549 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2550 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2552 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2553 Check for size-calculation overflow.
2554 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2555 do, as we prefer signed integers.
2556 (id_to_widget.max_size, id_to_widget.used)
2557 (xg_store_widget_in_map, xg_remove_widget_from_map)
2558 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2559 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2560 Use and return ptrdiff_t, not int.
2561 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2562 * gtkutil.h: Change prototypes to match the above.
2564 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2565 are duplicate now that they've been promoted to lisp.h.
2566 (x_allocate_bitmap_record, x_alloc_image_color)
2567 (make_image_cache, cache_image, xpm_load):
2568 Don't update size until alloc is done.
2569 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2571 Check for size calculation overflow.
2572 (ct_colors_allocated_max): New constant.
2573 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2576 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2577 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2578 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2579 Use ptrdiff_t, not int, to count maps.
2580 (read_char_minibuf_menu_prompt): Check for overflow in size
2581 calculations. Don't update size until allocation succeeds.
2582 Redo calculations to avoid overflow.
2583 * keyboard.h: Change prototypes to match the above.
2585 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2587 (current_minor_maps): Check for size calculation overflow.
2588 * keymap.h: Change prototypes to match the above.
2590 * lread.c (read1, init_obarray): Don't update size until alloc done.
2592 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2593 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2595 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2596 Now ptrdiff_t, not int.
2597 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2598 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2600 * process.c (Fnetwork_interface_list): Check for overflow
2601 in size calculation.
2603 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2605 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2606 overflow. Don't bother calling xmalloc when xrealloc will do.
2608 * search.c (Freplace_match): Check for size calculation overflow.
2609 (Fset_match_data): Don't assume list lengths fit in 'int'.
2611 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2612 for command line length. Do not attempt to address one before the
2613 beginning of an array, as that's not portable.
2615 * term.c (max_frame_lines): Remove; unused.
2616 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2618 (encode_terminal_code, calculate_costs): Check for size
2619 calculation overflow.
2620 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2621 table lengths and related sizes. Don't update size until alloc
2622 done. Redo calculations to avoid overflow.
2623 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2625 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2626 subtracting pointers.
2627 (gobble_line): Check for overflow more carefully. Don't update size
2630 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2631 Don't update size until alloc done.
2632 Redo size calculations to avoid overflow.
2633 Check for size calculation overflow.
2634 (main) [DEBUG]: Fix typo in invoking tparam1.
2636 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2637 Use ptrdiff_t, not int, for sizes.
2638 (store_mode_line_noprop_char): Don't update size until alloc done.
2640 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2641 Use ptrdiff_t, not int, for sizes.
2642 (Finternal_make_lisp_face, cache_face):
2643 Check for size calculation overflow.
2644 (cache_face): Treat size calculation overflows as if they were
2645 memory exhaustion (the usual treatment), rather than aborting.
2647 * xfns.c (x_encode_text, x_set_name_internal)
2648 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2649 sizes, since they can exceed INT_MAX in size. Check for size
2650 calculation overflow.
2652 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2653 (xg_select): Check for size calculation overflow.
2654 Don't update size until alloc done.
2656 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2657 as sprintf is limited to int lengths.
2659 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2660 (X_LONG_MIN): New macros.
2661 Use them to make the following changes clearer.
2662 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2663 This change doesn't affect the value now, but it may help remind
2664 future maintainers not to raise the value too much later.
2665 (SELECTION_QUANTUM): Remove, replacing with ...
2666 (selection_quantum): ... new function, which avoids overflow.
2668 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2669 assumption that selection length fits in 'int'.
2670 (x_reply_selection_request, x_handle_selection_request)
2671 (x_get_window_property, receive_incremental_selection)
2672 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2673 (lisp_data_to_selection_data, clean_local_selection_data):
2674 Use ptrdiff_t, not int, to record length of selection.
2675 (x_reply_selection_request, x_get_window_property)
2676 (receive_incremental_selection, x_property_data_to_lisp):
2677 Redo calculations to avoid overflow.
2678 (x_reply_selection_request): When sending hint, ceiling it at
2679 X_LONG_MAX rather than relying on wraparound overflow to send
2681 (x_get_window_property, receive_incremental_selection)
2682 (lisp_data_to_selection_data, x_property_data_to_lisp):
2683 Check for size-calculation overflow.
2684 (x_get_window_property, receive_incremental_selection)
2685 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2686 Don't store size until memory allocation succeeds.
2687 (x_get_window_property): Plug memory leak on memory exhaustion.
2688 Don't double-block input; malloc is safe here. Don't assume 2**34
2689 - 4 fits in unsigned long. Add an xassert to check
2690 XGetWindowProperty overflow. Be more careful about overflow
2691 calculations, and distinguish size from memory overflow better.
2692 (receive_incremental_selection): When tracing, don't assume
2693 unsigned int is less than INT_MAX.
2694 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2695 harmful) conversions of unsigned short to int.
2696 (lisp_data_to_selection_data): Don't assume that integers
2697 in the range -65535 through -1 fit in an X unsigned short.
2698 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2699 result parameters unless successful. Rely on cons_to_unsigned
2700 to report problems with elements; the old code wasn't right anyway.
2701 (x_check_property_data): Check for int overflow; we cannot use
2702 a wider type due to X limits.
2703 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2705 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2707 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2708 (x_term_init): Check for size calculation overflow.
2709 (x_color_cells): Don't store size until memory allocation succeeds.
2710 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2711 Don't assume alloca size is less than MAX_ALLOCA.
2712 (x_term_init): Don't assume length fits in int (sprintf is limited
2715 Use ptrdiff_t for composition IDs.
2716 * character.c (lisp_string_width):
2717 * composite.c (composition_table_size, n_compositions)
2718 (get_composition_id, composition_gstring_from_id):
2719 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2720 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2721 * window.c (Frecenter):
2722 Use ptrdiff_t, not int, for composition IDs.
2723 * composite.c (get_composition_id): Check for integer overflow.
2724 * composite.h: Adjust prototypes to match the above changes.
2726 Use ptrdiff_t for hash table indexes.
2727 * category.c (hash_get_category_set):
2728 * ccl.c (ccl_driver):
2729 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2730 * coding.c (coding_system_charset_list, detect_coding_system):
2731 * coding.h (struct coding_system.id):
2732 * composite.c (get_composition_id, gstring_lookup_cache):
2733 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2734 * image.c (xpm_get_color_table_h):
2735 * lisp.h (hash_lookup, hash_put):
2736 * minibuf.c (Ftest_completion):
2737 Use ptrdiff_t for hash table indexes, not int (which is too
2738 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2739 32-bit --with-wide-int hosts).
2741 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2742 Add a FIXME comment about memory leaks.
2743 (syms_of_charset): Don't assume xmalloc returns.
2745 Don't assume that stated character widths fit in int.
2746 * character.c (Fchar_width, c_string_width, lisp_string_width):
2747 * character.h (CHAR_WIDTH):
2748 * indent.c (MULTIBYTE_BYTES_WIDTH):
2749 Use sanitize_char_width to avoid undefined and/or bad behavior
2750 with outlandish widths.
2751 * character.h (sanitize_tab_width): Rename from sanitize_width,
2752 now that we have two such functions. All uses changed.
2753 (sanitize_char_width): New inline function.
2755 Don't assume that tab-width fits in int.
2756 * character.h (sanitize_width): New inline function.
2757 (SANE_TAB_WIDTH): New macro.
2758 (ASCII_CHAR_WIDTH): Use it.
2759 * indent.c (sane_tab_width): Remove. All uses replaced by
2760 SANE_TAB_WIDTH (current_buffer).
2761 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2763 * fileio.c: Integer overflow issues with file modes.
2764 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2766 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2767 Remove unreachable code.
2768 (read_hex, load_charset_map_from_file): Check for integer overflow.
2770 * xterm.c: Don't go over XClientMessageEvent limit.
2771 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2772 (x_send_scroll_bar_event): Likewise. Check that the size does not
2773 exceed limits imposed by XClientMessageEvent, as well as the usual
2774 ptrdiff_t and size_t limits.
2776 * keyboard.c: Overflow, signedness and related fixes.
2777 (make_lispy_movement): Use same integer type in forward decl
2778 that is used in the definition.
2779 (read_key_sequence, keyremap_step):
2780 Change bufsize argument back to int, undoing my 2011-03-30 change.
2781 We prefer signed types, and int is wide enough here.
2782 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2783 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2784 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2785 length, not size_t. Use ptrdiff_t for index, not int.
2786 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2787 possibility of integer overflow.
2789 Overflow, signedness and related fixes for images.
2791 * dispextern.h (struct it.stack[0].u.image.image_id)
2792 (struct_it.image_id, struct image.id, struct image_cache.size)
2793 (struct image_cache.used, struct image_cache.ref_count):
2794 * gtkutil.c (update_frame_tool_bar):
2795 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2796 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2797 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2798 * nsmenu.m (update_frame_tool_bar):
2799 * xdisp.c (calc_pixel_width_or_height):
2800 * xfns.c (image_cache_refcount):
2801 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2802 on typical 64-bit hosts.
2804 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2805 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2806 Omit unnecessary casts to int.
2807 (parse_image_spec): Check that integers fall into 'int' range
2808 when the callers expect that.
2809 (image_ascent): Redo ascent calculation to avoid int overflow.
2810 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2811 (lookup_image): Remove unnecessary tests.
2812 (xbm_image_p): Locals are now of int, not EMACS_INT,
2813 since parse_image_check makes sure they fit into int.
2814 (png_load, gif_load, svg_load_image):
2815 Prefer int to unsigned where either will do.
2816 (tiff_handler): New function, combining the cores of the
2817 old tiff_error_handler and tiff_warning_handler.
2818 This function is rewritten to use vsnprintf and thereby avoid
2819 stack buffer overflows. It uses only the features of vsnprintf
2820 that are common to both POSIX and native Microsoft.
2821 (tiff_error_handler, tiff_warning_handler): Use it.
2822 (tiff_load, gif_load, imagemagick_load_image):
2823 Don't assume :index value fits in 'int'.
2824 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2825 (imagemagick_load_image): Check that crop parameters fit into
2826 the integer types that MagickCropImage accepts. Don't assume
2827 Vimagemagick_render_type has a nonnegative value. Don't assume
2828 size_t fits in 'long'.
2829 (gs_load): Use printmax_t to print the widest integers possible.
2830 Check for integer overflow when computing image height and width.
2832 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2834 * xdisp.c (redisplay_window): Don't force window start if point
2835 will be invisible in the resulting window. (Bug#9324)
2837 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2839 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2840 the display spec is of the form `(space ...)'.
2841 (handle_display_spec): Return the value returned by
2842 handle_single_display_spec, not just 1 or zero.
2843 (handle_single_display_spec): If the display spec is of the form
2844 `(space ...)', and specifies display in the text area, return 2
2846 (try_cursor_movement): Check for the need to scroll more
2847 accurately, and prefer exact match for point under bidi.
2848 Don't advance `row' beyond the last row of the window.
2850 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2851 into disp_prop; all users changed.
2853 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2854 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2855 for the text covered by the display property.
2857 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2859 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2860 Change return value to nil.
2861 (Frecord_buffer): Delete unused function.
2863 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2865 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2866 buffers, return left-to-right.
2867 (set_cursor_from_row): Consider candidate row a win if its glyph
2868 represents a newline and point is on that newline. Fixes cursor
2869 positioning on the newline at EOL of R2L text within L2R
2870 paragraph, and vice versa.
2871 (try_cursor_movement): Check continued rows, in addition to
2872 continuation rows. Fixes unwarranted scroll when point enters a
2873 continued line of R2L text within an L2R paragraph, or vice versa.
2874 (cursor_row_p): Consider the case of point being equal to
2875 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2876 from the end of a short line to the beginning of a continued line
2877 of R2L text within L2R paragraph.
2878 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2879 composed characters.
2881 * bidi.c (bidi_check_type): Use xassert.
2882 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2885 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2887 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2890 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2892 * nsfont.m (ns_otf_to_script): Fix typo.
2894 2011-08-22 Kenichi Handa <handa@m17n.org>
2896 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2897 extra slot even if the purpose is char-code-property-table.
2899 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2901 * xdisp.c (redisplay_window): When computing centering_position,
2902 account for the height of the header line. (Bug#8874)
2904 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2905 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2906 candidate is selected by the mouse, and that candidate has a
2907 composed character under the mouse.
2909 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2910 coordinates reported by pos-visible-in-window-p for a composed
2911 character in column zero.
2913 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2915 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2917 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2919 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2920 consider it a hit if to_charpos is anywhere in the range of the
2921 composed buffer positions.
2923 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2925 * image.c (gif_load): Don't assume that each subimage has the same
2926 dimensions as the base image. Handle disposal method that is
2927 "undefined" by the gif spec (Bug#9335).
2929 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2931 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2932 (Fcondition_case): Document `debug' symbol in error handler.
2934 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2936 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2937 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2938 from an Org mode buffer to a Speedbar frame.
2940 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2941 a composition, take its buffer position from IT->cmp_it.charpos.
2942 Fixes cursor positioning at the beginning of a line that begins
2943 with a composed character.
2945 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2947 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2948 character bidirectional type, use STRONG_L instead. Fixes crashes
2949 in a buffer produced by `describe-categories'.
2951 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2952 members before the level stack, so they would be saved and
2953 restored when copying iterator state. Fixes incorrect reordering
2954 around TABs covered by display properties.
2956 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2958 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2960 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2962 * eval.c (internal_condition_case, internal_condition_case_1)
2963 (internal_condition_case_2, internal_condition_case_n):
2964 Remove unnecessary aborts (Bug#9081).
2966 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2968 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2969 has no `load' handler, try opening the file locally. (Bug#9311)
2971 2011-08-16 Ken Brown <kbrown@cornell.edu>
2973 * gmalloc.c: Expand comment.
2975 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2977 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2978 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2980 2011-08-16 Ken Brown <kbrown@cornell.edu>
2982 Fix memory allocation problems in Cygwin build (Bug#9273).
2984 * unexcw.c ( __malloc_initialized): Declare external variable.
2985 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2987 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2989 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2991 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2993 [CYGWIN] (special_realloc): New function.
2994 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2995 requests to realloc storage in the static heap.
2997 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2999 * bidi.c (bidi_initialize): Remove unused local.
3001 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3004 * biditype.h: Remove file.
3005 * makefile.w32-in ($(BLD)/bidi.$(O)):
3006 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3008 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3010 * chartab.c: Improve commentary for the uniprop_table API.
3012 * bidi.c (bidi_paragraph_init): Support zero value of
3013 bidi_ignore_explicit_marks_for_paragraph_level.
3014 (bidi_initialize): Use uniprop_table instead of including
3015 biditype.h and bidimirror.h.
3017 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3018 coordinates of the iterator when restoring from ppos_it.
3021 2011-08-14 Kenichi Handa <handa@m17n.org>
3023 * process.c (create_process): Call setup_process_coding_systems
3024 after the pid of the process is set to -1 (Bug#8162).
3026 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3028 * xdisp.c (move_it_in_display_line_to): Don't invoke
3029 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3030 ppos_it. Fixes vertical cursor motion when line beginning is
3031 covered by an image. (Bug#9296)
3033 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3035 * nsterm.h (ns_run_ascript): Declare.
3036 (NSAPP_DATA2_RUNASSCRIPT): Define.
3038 * nsfns.m (as_script, as_result, as_status): New static variables.
3039 (ns_run_ascript): New function.
3040 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3041 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3042 the event loop. Get status from as_status (Bug#7276).
3044 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3045 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3046 the event loop (Bug#7276).
3048 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3050 * gnutls.c (QCgnutls_bootprop_priority)
3051 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3052 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3053 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3054 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3055 (QCgnutls_bootprop_verify_hostname_error)
3056 (QCgnutls_bootprop_callbacks_verify): Rename from
3057 Qgnutls_bootprop_..., all uses changed.
3059 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3062 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3064 * xfaces.c (Qframe_set_background_mode): Now static.
3065 * dispextern.h (Qframe_set_background_mode): Remove decl.
3067 * process.c (Fnetwork_interface_info): Declare local only if needed.
3069 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3071 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3072 (Fnetwork_interface_list): Allocate in increments of bytes instead
3073 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3074 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3076 (struct ifflag_def): notrailers is smart on OSX.
3077 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3078 Get hardware address with getifaddrs if available.
3080 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3082 * xdisp.c (iterate_out_of_display_property): xassert that
3083 IT->position is set to within IT->object's boundaries. Break from
3084 the loop as soon as EOB is reached; avoids infloops in redisplay
3085 when IT->position is set up wrongly due to some bug.
3086 Set IT->current to match the bidi iterator unconditionally.
3087 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3088 entry. Force push_it to save on the stack the current
3089 buffer/string position, to be restored by pop_it. Fix flags in
3090 the iterator structure wrt the object coming from a display
3091 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3092 properties. (Bug#9284)
3094 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3096 * fontset.c (fontset_get_font_group): Add proper type checks.
3099 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3101 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3102 and LC_VERSION_MIN_MACOSX.
3103 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3104 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3106 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3108 * xdisp.c (forward_to_next_line_start): Allow to use the
3109 no-display-properties-and-no-overlays under bidi display.
3110 Set disp_pos in the bidi iterator to avoid searches for display
3111 properties and overlays.
3113 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3115 * editfns.c (Fset_time_zone_rule): Document relationship with the
3118 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3119 the font entity extracted from the cache (Bug#8109).
3121 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3123 * composite.c (autocmp_chars): Don't reset point. That is done by
3124 restore_point_unwind (Bug#5984).
3126 2011-08-07 Juri Linkov <juri@jurta.org>
3128 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3129 to show the arg `TIME' instead of `TIMEVAL'.
3131 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3133 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3134 display property strides EOL and includes a newline, as in
3135 longlines-mode. (Bug#9254)
3136 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3137 word-wrap under bidirectional display. (Bug#9224)
3139 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3140 is non-zero, even if the data buffer is NULL. Fixes a crash in
3141 vertical-motion with longlines-mode. (Bug#9254)
3143 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3145 * bidi.c <bidi_cache_total_alloc>: Now static.
3146 (bidi_initialize): Initialize bidi_cache_total_alloc.
3148 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3151 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3152 amount allocated this far in `bidi_cache_total_alloc'.
3153 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3154 non-zero, only free the data buffer without restoring the cache
3155 contents. All callers changed.
3157 * dispextern.h (bidi_unshelve_cache): Update prototype.
3159 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3160 (move_it_in_display_line, move_it_to)
3161 (move_it_vertically_backward, move_it_by_lines): Replace the call
3162 to xfree to an equivalent call to bidi_unshelve_cache.
3163 (move_it_in_display_line_to): Fix logic of returning
3164 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3166 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3168 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3169 came from a string character with a `cursor' property. (Bug#9229)
3171 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3173 * Makefile.in (LIB_PTHREAD): New variable.
3174 (LIBES): Add LIB_PTHREAD (Bug#9216).
3176 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3177 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3179 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3181 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3183 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3185 * xterm.c (x_find_topmost_parent): New function.
3186 (x_set_frame_alpha): Find topmost parent window with
3187 x_find_topmost_parent and set the property there also (bug#9181).
3188 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3190 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3192 * callproc.c (Fcall_process): Avoid vfork clobbering
3193 the local vars buffer, coding_systems, current_dir.
3195 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3197 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3199 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3201 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3202 so that it is not optimized away.
3204 * xdisp.c (compute_display_string_pos): Remove unused local.
3206 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3208 Fix slow cursor motion and scrolling in large buffers with
3209 selective display, like Org Mode buffers. (Bug#9218)
3211 * dispextern.h (struct bidi_it): New member disp_prop_p.
3213 * xdisp.c: Remove one-slot cache of display string positions.
3214 (compute_display_string_pos): Accept an additional argument
3215 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3216 for a display string or property. If found, set DISP_PROP_P
3219 * bidi.c (bidi_fetch_char): Accept an additional argument
3220 DISP_PROP_P, and pass it to compute_display_string_pos.
3221 Only handle text covered by a display string if DISP_PROP_P is returned
3222 non-zero. All callers of bidi_fetch_char changed.
3224 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3226 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3228 2010-12-03 Don March <don@ohspite.net>
3230 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3231 last character M-[char] is translated to ESC [char] (bug#7541).
3233 2011-08-02 Kenichi Handa <handa@m17n.org>
3235 * lisp.h (uniprop_table): Extern it.
3237 * chartab.c (uniprop_table): Make it non-static.
3239 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3241 * xdisp.c (forward_to_next_line_start): Accept additional argument
3242 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3244 (reseat_at_next_visible_line_start): Use the bidi iterator state
3245 returned by forward_to_next_line_start to restore the state of
3246 it->bidi_it after backing up to previous newline. (Bug#9212)
3248 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3250 * regex.c (re_comp): Protoize.
3251 (re_exec): Fix return type.
3252 (regexec): Fix type of `ret'. (Bug#9203)
3254 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3256 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3257 This is needed if max-image-size is a floating-point number.
3259 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3261 * print.c (print_object): Print empty symbol as ##.
3263 * lread.c (read1): Read ## as empty symbol.
3265 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3267 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3268 setting frame foreground color (Bug#9175).
3269 (x_set_background_color): Likewise.
3271 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3272 contents (Bug#9176).
3273 (EmacsTooltip -init): Remove bezels and add shadows to
3276 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3277 or scroll bar (Bug#8470).
3279 * nsfont.m (nsfont_open): Remove assignment to voffset and
3280 unnecessary vars hshink, expand, hd, full_height, min_height.
3281 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3283 * nsterm.h (nsfont_info): Remove voffset field.
3285 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3287 Implement strike-through and overline on NextStep (Bug#8863).
3289 * nsfont.m (nsfont_open): Use underline position provided by font,
3290 instead of hard-coded value of 2.
3291 (nsfont_draw): Call ns_draw_text_decoration instead.
3293 * nsterm.h: Add declaration for ns_draw_text_decoration.
3295 * nsterm.m (ns_draw_text_decoration): New function for drawing
3296 underline, overline, and strike-through.
3297 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3298 ns_draw_text_decoration. Change treatment of cursor drawing to
3299 accommodate underlining, etc.
3301 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3303 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3306 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3308 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3309 Without this fix, if a signal arrives just after memory fills up,
3310 'malloc' might be invoked reentrantly.
3312 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3313 In other words, assume that every image size is allowed, on non-X
3314 hosts. This assumption is probably wrong, but it lets Emacs compile.
3316 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3318 * regex.c (re_iswctype): Convert return values to boolean.
3320 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3322 * xdisp.c (compute_display_string_pos): Don't use cached display
3323 string position if the buffer had its restriction changed.
3326 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3328 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3330 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3332 Integer signedness and overflow and related fixes. (Bug#9079)
3334 * bidi.c: Integer size and overflow fixes.
3335 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3336 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3337 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3338 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3339 (bidi_find_other_level_edge):
3340 Use ptrdiff_t instead of EMACS_INT where either will do.
3341 This works better on 32-bit hosts configured --with-wide-int.
3342 (bidi_cache_ensure_space): Check for size-calculation overflow.
3343 Use % rather than repeated addition, for better worst-case speed.
3344 Don't set bidi_cache_size until after xrealloc returns, because it
3346 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3347 (bidi_cache_ensure_space): Also check that the bidi cache size
3348 does not exceed that of the largest Lisp string or buffer. See Eli
3349 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3351 * alloc.c (__malloc_size_t): Remove.
3352 All uses replaced by size_t. See Andreas Schwab's note
3353 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3355 * image.c: Improve checking for integer overflow.
3356 (check_image_size): Assume that f is nonnull, since
3357 it is always nonnull in practice. This is one less thing to
3358 worry about when checking for integer overflow later.
3359 (x_check_image_size): New function, which checks for integer
3360 overflow issues inside X.
3361 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3362 This removes the need for a memory_full check.
3363 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3364 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3365 (xbm_read_bitmap_data): Change locals back to 'int', since
3366 their values must fit in 'int'.
3367 (xpm_load_image, png_load, tiff_load):
3368 Invoke x_create_x_image_and_pixmap earlier,
3369 to avoid much needless work if the image is too large.
3370 (tiff_load): Treat overly large images as if
3371 x_create_x_image_and_pixmap failed, not as malloc failures.
3372 (gs_load): Use x_check_image_size.
3374 * gtkutil.c: Omit integer casts.
3375 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3376 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3378 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3380 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3381 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3382 would wrongly return t on a 64-bit host.
3384 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3385 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3386 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3387 and therefore cause GCC to emit a bogus diagnostic in some cases.
3389 * image.c: Integer signedness and overflow and related fixes.
3390 This is not an exhaustive set of fixes, but it's time to
3391 record what I've got.
3392 (lookup_pixel_color, check_image_size): Remove redundant decls.
3393 (check_image_size): Don't assume that arbitrary EMACS_INT values
3394 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3395 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3396 (tiff_load, imagemagick_load_image):
3397 Check for overflow in size calculations.
3398 (x_create_x_image_and_pixmap): Remove unnecessary test for
3399 xmalloc returning NULL; that can't happen.
3400 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3401 (xpm_color_bucket): Use better integer hashing function.
3402 (xpm_cache_color): Don't possibly over-allocate memory.
3403 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3404 (gif_memory_source):
3405 Use ptrdiff_t, not int or size_t, to record sizes.
3406 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3407 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3408 either works, as we prefer signed integers.
3409 (tiff_read_from_memory, tiff_write_from_memory):
3410 Return tsize_t, not size_t, since that's what the TIFF API wants.
3411 (tiff_read_from_memory): Don't fail simply because the read would
3412 go past EOF; instead, return a short read.
3413 (tiff_load): Omit no-longer-needed casts.
3414 (Fimagemagick_types): Don't assume size fits into 'int'.
3416 Improve hashing quality when configured --with-wide-int.
3417 * fns.c (hash_string): New function, taken from sxhash_string.
3418 Do not discard information about ASCII character case; this
3419 discarding is no longer needed.
3420 (sxhash-string): Use it. Change sig to match it. Caller changed.
3421 * lisp.h: Declare it.
3422 * lread.c (hash_string): Remove, since we now use fns.c's version.
3423 The fns.c version returns a wider integer if --with-wide-int is
3424 specified, so this should help the quality of the hashing a bit.
3426 * emacs.c: Integer overflow minor fix.
3427 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3428 Define only if GNU_LINUX.
3429 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3431 * dispnew.c: Integer signedness and overflow fixes.
3432 Remove unnecessary forward decls, that were a maintenance hassle.
3433 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3435 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3436 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3437 (prepare_desired_row, line_draw_cost):
3438 Use int, not unsigned, where either works.
3439 (save_current_matrix, restore_current_matrix):
3440 Use ptrdiff_t, not size_t, where either works.
3441 (init_display): Check for overflow more accurately, and without
3442 relying on undefined behavior.
3444 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3445 Remove, replacing with the new symbols in lisp.h. All uses changed.
3446 * fileio.c (make_temp_name):
3447 * filelock.c (lock_file_1, lock_file):
3448 * xdisp.c (message_dolog):
3449 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3450 Use pMd etc. instead.
3451 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3452 replacing the pWIDE etc. symbols removed from editfns.c.
3454 * keyboard.h (num_input_events): Now uintmax_t.
3455 This is (very slightly) less likely to mess up due to wraparound.
3458 * buffer.c: Integer signedness fixes.
3459 (alloc_buffer_text, enlarge_buffer_text):
3460 Use ptrdiff_t rather than size_t when either will do, as we prefer
3463 * alloc.c: Integer signedness and overflow fixes.
3464 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3465 (__malloc_size_t): Default to size_t, not to int.
3466 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3467 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3468 Prefer ptrdiff_t to size_t when either would do, as we prefer
3470 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3471 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3472 Now const. Initialize with values that are in range even if char
3474 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3475 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3476 These functions do the right thing with sizes > 2**32.
3477 (check_depth): Now ptrdiff_t, not int.
3478 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3479 Adjust to new way of storing sizes. Check for size overflow bugs
3481 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3482 slightly wrong anyway, as it missed one instance of
3483 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3484 (refill_memory_reserve): Omit needless cast to size_t.
3485 (mark_object_loop_halt): Mark as externally visible.
3487 * xselect.c: Integer signedness and overflow fixes.
3488 (Fx_register_dnd_atom, x_handle_dnd_message):
3489 Use ptrdiff_t, not size_t, since we prefer signed.
3490 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3491 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3492 x_dnd_atoms_size and x_dnd_atoms_length.
3494 * doprnt.c: Prefer signed to unsigned when either works.
3496 * doprnt.c (doprnt):
3498 * xdisp.c (vmessage):
3499 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3500 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3501 prefer signed arithmetic to avoid comparison confusion.
3502 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3503 but is a bit tricky.
3505 Assume freestanding C89 headers, string.h, stdlib.h.
3506 * data.c, doprnt.c, floatfns.c, print.c:
3507 Include float.h unconditionally.
3508 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3509 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3510 * regex.c: Likewise for stddef.h, string.h.
3511 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3512 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3513 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3514 (STDC_HEADERS): Remove obsolete defines.
3515 * sysdep.c: Include limits.h unconditionally.
3517 Assume support for memcmp, memcpy, memmove, memset.
3518 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3519 * regex.c (memcmp, memcpy):
3520 Remove; we assume C89 now.
3522 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3523 (__malloc_safe_bcopy): Remove; no longer needed.
3525 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3526 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3527 well either way, and we prefer signed to unsigned.
3529 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3531 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3532 closes the connection while we're reading (bug#9182).
3534 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3536 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3537 are specified (Bug#9168).
3539 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3541 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3542 Found by GCC static checking and --with-wide-int on a 32-bit host.
3544 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3546 * xdisp.c (compute_display_string_pos): Fix logic of caching
3547 previous display string position. Initialize cached_prev_pos to
3548 -1. Fixes slow-down at the beginning of a buffer.
3550 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3552 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3553 for attrs[LFACE_FONTSET_INDEX].
3555 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3557 * xml.c (parse_region): Remove unused local
3558 that was recently introduced.
3560 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3562 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3563 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3565 * xdisp.c (move_it_in_display_line_to): Record the best matching
3566 position for TO_CHARPOS while scanning the line, and restore it on
3567 exit if none of the characters scanned was an exact match.
3568 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3569 when exact match is impossible due to invisible text, and the
3570 lines are truncated.
3572 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3574 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3577 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3579 Fix a significant slow-down of cursor motion with C-n, C-p,
3580 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3581 auto-repeat under bidi redisplay in fontified buffers.
3582 * xdisp.c (compute_stop_pos_backwards): New function.
3583 (next_element_from_buffer): Call compute_stop_pos_backwards to
3584 find a suitable prev_stop when we find ourselves before
3586 (reseat): Don't look for prev_stop, as that could mean a very long
3588 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3589 <cached_disp_overlay_modiff>: Cache for last found display string
3591 (compute_display_string_pos): Return the cached position if asked
3592 about the same buffer in the same area of character positions, and
3593 the buffer wasn't changed since the time the display string
3594 position was cached.
3596 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3598 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3599 is an integer, which is important for empty lines. (Bug#9149)
3601 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3603 * frame.c (Fmodify_frame_parameters): In tty case, update the
3604 default face if necessary (Bug#4238).
3606 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3608 * editfns.c (Fstring_to_char): No need to explain what a character
3609 is in the docstring (Bug#6576).
3611 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3613 * xml.c (parse_region): Make sure we always return a tree.
3615 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3617 * xml.c (parse_region): If a document contains only comments,
3620 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3622 * xml.c (make_dom): Return comments, too.
3624 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3627 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3628 and the surrounding thread.
3629 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3630 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3631 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3633 * s/openbsd.h (BROKEN_SIGIO): Define.
3634 * unexelf.c (unexec) [__OpenBSD__]:
3635 Don't update the .mdebug section of the Alpha COFF symbol table.
3637 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3639 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3642 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3644 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3645 This fixes some race conditions on the permissions of any newly
3648 * alloc.c (valid_pointer_p): Use pipe, not open.
3649 This fixes some permissions issues when debugging.
3651 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3652 If fchown fails to set both uid and gid, try to set just gid,
3653 as that is sometimes allowed. Adjust the file's mode to eliminate
3654 setuid or setgid bits that are inappropriate if fchown fails.
3656 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3658 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3659 to compare Lisp_Objects.
3660 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3661 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3662 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3664 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3666 * lread.c (read_integer): Unread even EOF character.
3667 (read1): Likewise. Properly record start position of symbol.
3669 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3670 symbol character follows.
3672 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3674 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3675 This works around a problem with the previous change to Fcopy_file.
3676 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3677 and without this change, GCC might complain about discarding
3678 fchown's return value.
3680 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3682 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3684 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3686 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3688 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3690 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3691 it's used from the C level.
3693 * process.c: Use the same condition for POLL_FOR_INPUT in both
3694 keyboard.c and process.c (bug#1858).
3696 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3698 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3699 (Fgnutls_boot): Use it.
3701 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3703 * doc.c (Fsubstitute_command_keys): Revert last change.
3705 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3707 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3708 quotes the next character, and doesn't affect other longer
3709 sequences (bug#8935).
3711 * lread.c (syms_of_lread): Clarify that is isn't only
3712 `eval-buffer' and `eval-defun' that's affected by
3713 `lexical-binding' (bug#8460).
3715 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3717 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3718 bidi redisplay when a line includes both an image and is truncated.
3720 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3722 Fix minor problems found by static checking.
3723 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3724 (elsz): Now a signed constant, not a size_t var. We prefer signed
3725 types to unsigned, to avoid integer comparison confusion. Without
3726 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3727 "cannot optimize loop, the loop counter may overflow", a symptom
3729 * indent.c (Fvertical_motion): Mark locals as initialized.
3730 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3732 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3734 * search.c (Fre_search_backward): Mention `case-fold-search' in
3735 all the re_search_* functions (bug#8138).
3737 * keyboard.c (Fopen_dribble_file): Document when the file is
3740 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3742 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3745 Support bidi reordering of display and overlay strings.
3746 * xdisp.c (compute_display_string_pos)
3747 (compute_display_string_end): Accept additional argument STRING.
3748 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3749 (reseat_to_string): Initialize bidi_it->string.s and
3750 bidi_it->string.schars.
3751 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3752 NULL (avoids a crash in bidi_paragraph_init).
3753 Initialize itb.string.lstring.
3754 (init_iterator): Call bidi_init_it only of a valid
3755 buffer position was specified. Initialize paragraph_embedding to
3757 (reseat_to_string): Initialize the bidi iterator.
3758 (display_string): If we need to ignore text properties of
3759 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3760 original value of -1 will not work with bidi.)
3761 (compute_display_string_pos): First arg is now struct
3762 `text_pos *'; all callers changed. Support display properties on
3764 (compute_display_string_end): Support display properties on Lisp
3766 (init_iterator, reseat_1, reseat_to_string): Initialize the
3767 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3768 when iterating on a string not from display properties).
3769 (compute_display_string_pos, compute_display_string_end):
3770 Fix calculation of the object to scan. Fixes an error when using
3772 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3773 base_level_stop; instead, set base_level_stop to BEGV.
3774 Fixes crashes in vertical-motion.
3775 (next_element_from_buffer): Improve commentary for when
3776 the iterator is before prev_stop.
3777 (init_iterator): Initialize bidi_p from the default value of
3778 bidi-display-reordering, not from buffer-local value. Use the
3779 buffer-local value only if initializing for buffer iteration.
3780 (handle_invisible_prop): Support invisible properties on strings
3781 that are being bidi-reordered.
3782 (set_iterator_to_next): Support bidi reordering of C strings and
3784 (next_element_from_string): Support bidi reordering of Lisp
3786 (handle_stop_backwards): Support Lisp strings as well.
3787 (display_string): Support display of R2L glyph rows.
3788 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3789 (init_iterator): Don't initialize it->bidi_p for strings
3791 (reseat_to_string): Initialize it->bidi_p for strings here.
3792 (next_element_from_string, next_element_from_c_string)
3793 (next_element_from_buffer): Add xassert's for correspondence
3794 between IT's object being iterated and it->bidi_it.string
3796 (face_before_or_after_it_pos): Support bidi iteration.
3797 (next_element_from_c_string): Handle the case of the first string
3798 character that is not the first one in the visual order.
3799 (get_visually_first_element): New function, refactored from common
3800 parts of next_element_from_buffer, next_element_from_string, and
3801 next_element_from_c_string.
3802 (tool_bar_lines_needed, redisplay_tool_bar)
3803 (display_menu_bar): Force left-to-right direction. Add a FIXME
3804 comment for making that be controlled by a user option.
3805 (push_it, pop_it): Save and restore the state of the
3806 bidi iterator. Save and restore the bidi_p flag.
3807 (pop_it): Iterate out of display property for string iteration as
3809 (iterate_out_of_display_property): Support iteration over strings.
3810 (handle_single_display_spec): Set up it->bidi_it for iteration
3811 over a display string, and call bidi_init_it.
3812 (handle_single_display_spec, next_overlay_string)
3813 (get_overlay_strings_1, push_display_prop): Set up the bidi
3814 iterator for displaying display or overlay strings.
3815 (forward_to_next_line_start): Don't use the shortcut if
3817 (back_to_previous_visible_line_start): If handle_display_prop
3818 pushed the iterator stack, restore the internal state of the bidi
3819 iterator by calling bidi_pop_it same number of times.
3820 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3821 and we are bidi-iterating, don't decrement the iterator position;
3822 instead, set the first_elt flag in the bidi iterator, to produce
3824 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3825 (push_display_prop): xassert that we are iterating a buffer.
3826 (push_it, pop_it): Save and restore paragraph_embedding member.
3827 (handle_single_display_spec, next_overlay_string)
3828 (get_overlay_strings_1, reseat_1, reseat_to_string)
3829 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3830 correctly. Don't assume unibyte strings are not bidi-reordered.
3831 (compute_display_string_pos)
3832 (compute_display_string_end): Fix handling the case of C string.
3833 (push_it, pop_it): Save and restore from_disp_prop_p.
3834 (handle_single_display_spec, push_display_prop): Set the
3835 from_disp_prop_p flag.
3836 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3837 (pop_it): Call iterate_out_of_display_property only if we are
3838 popping after iteration over a string that came from a display
3839 property. Fix a typo in popping stretch info. Add an assertion
3840 for verifying that the iterator position is in sync with the bidi
3842 (handle_single_display_spec, get_overlay_strings_1)
3843 (push_display_prop): Fix initialization of paragraph direction for
3844 string when that of the parent object is not yet determined.
3845 (reseat_1): Call bidi_init_it to resync the bidi
3846 iterator with IT's position. (Bug#7616)
3847 (find_row_edges): If ROW->start.pos gives position
3848 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3849 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3850 Reset the from_disp_prop_p flag.
3851 (SAVE_IT, RESTORE_IT): New macros.
3852 (pos_visible_p, face_before_or_after_it_pos)
3853 (back_to_previous_visible_line_start)
3854 (move_it_in_display_line_to, move_it_in_display_line)
3855 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3856 (try_scrolling, redisplay_window, display_line): Use them when
3857 saving a temporary copy of the iterator and restoring it back.
3858 (back_to_previous_visible_line_start, reseat_1)
3859 (init_iterator): Empty the bidi cache "stack".
3860 (move_it_in_display_line_to): If iterator ended up at
3861 EOL, but we never saw any buffer positions smaller than
3862 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3863 motion in bidi-reordered lines.
3864 (move_it_in_display_line_to): Record prev_method and prev_pos
3865 immediately before the call to set_iterator_to_next. Fixes cursor
3866 motion in bidi-reordered lines with stretch glyphs and strings
3867 displayed in margins. (Bug#8133) (Bug#8867)
3868 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3870 (pos_visible_p): Support positions in bidi-reordered lines.
3871 Save and restore bidi cache.
3873 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3874 (bidi_paragraph_info): Delete unused struct.
3875 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3876 (bidi_cache_start): New variable.
3877 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3879 (bidi_cache_fetch_state, bidi_cache_search)
3880 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3881 (bidi_cache_find, bidi_peek_at_next_level)
3882 (bidi_level_of_next_char, bidi_find_other_level_edge)
3883 (bidi_move_to_visually_next): Compare cache index with
3884 bidi_cache_start rather than with zero.
3885 (bidi_fetch_char): Accept new argument STRING; all callers
3886 changed. Support iteration over a string. Support strings with
3887 display properties. Support unibyte strings. Fix the type of
3888 `len' according to what STRING_CHAR_AND_LENGTH expects.
3889 (bidi_paragraph_init, bidi_resolve_explicit_1)
3890 (bidi_resolve_explicit, bidi_resolve_weak)
3891 (bidi_level_of_next_char, bidi_move_to_visually_next):
3892 Support iteration over a string.
3893 (bidi_set_sor_type, bidi_resolve_explicit_1)
3894 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3895 can now be zero (for strings); special values 0 and -1 were
3896 changed to -1 and -2, respectively.
3897 (bidi_char_at_pos): New function.
3898 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3899 Call it instead of FETCH_MULTIBYTE_CHAR.
3900 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3901 initialized to valid values.
3902 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3904 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3905 the test for valid cached positions. Fix the logic for looking up
3906 the sentinel state in the cache. GCPRO the Lisp string we are
3908 (bidi_push_it, bidi_pop_it): New functions.
3909 (bidi_initialize): Initialize the bidi cache start stack pointer.
3910 (bidi_cache_ensure_space): New function, refactored from part of
3911 bidi_cache_iterator_state. Don't assume the required size is just
3912 one BIDI_CACHE_CHUNK away.
3913 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3914 (bidi_count_bytes, bidi_char_at_pos): New functions.
3915 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3916 always valid if bidi_cache_idx is valid.
3917 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3918 is valid if it's going to be used.
3919 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3920 (bidi_cache_fetch_state, bidi_cache_search)
3921 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3922 (bidi_cache_iterator_state, bidi_cache_find)
3923 (bidi_find_other_level_edge, bidi_cache_start_stack):
3924 All variables related to cache indices are now EMACS_INT.
3926 * dispextern.h (struct bidi_string_data): New structure.
3927 (struct bidi_it): New member `string'. Make flag members be 1-bit
3928 fields, and put them last in the struct.
3929 (compute_display_string_pos, compute_display_string_end):
3931 (bidi_push_it, bidi_pop_it): Add prototypes.
3932 (struct iterator_stack_entry): New members bidi_p,
3933 paragraph_embedding, and from_disp_prop_p.
3934 (struct it): Member bidi_p is now a bit field 1 bit wide.
3935 (bidi_shelve_cache, bidi_unshelve_cache):
3938 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3939 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3940 and vector-like objects.
3942 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3943 cache around display iteration.
3945 * window.c (Fwindow_end, window_scroll_pixel_based)
3946 (displayed_window_lines, Frecenter): Save and restore the bidi
3947 cache around display iteration.
3949 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3951 * editfns.c (Fdelete_region): Clarify the use of the named
3952 parameters (bug#6788).
3954 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3956 * indent.c (Fvertical_motion): Set and restore w->pointm when
3957 saving and restoring the window's buffer (Bug#9006).
3959 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3961 * editfns.c (Fstring_to_char): Clarify just what is returned
3962 (bug#6576). Text by Eli Zaretskii.
3964 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3966 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3968 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3970 * buffer.c (mmap_find): Fix a typo.
3972 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3974 Fix execution of x selection hooks.
3975 * xselect.c (Qx_lost_selection_functions)
3976 (Qx_sent_selection_functions): New vars.
3977 (syms_of_xselect): DEFSYM them.
3978 (x_handle_selection_request): Pass Qx_sent_selection_functions
3979 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3980 (x_handle_selection_clear,x_clear_frame_selections):
3981 Pass Qx_lost_selection_functions rather than
3982 Vx_lost_selection_functions to Frun_hook_with_args.
3984 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3986 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3987 The old code sometimes used this field without initializing it.
3989 * alloc.c (gc_sweep): Don't read past end of array.
3990 In theory, the old code could also have corrupted Emacs internals,
3991 though it'd be very unlikely.
3993 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3995 * character.c (Fcharacterp): Don't advertise optional ignored
3996 argument. (Bug#4026)
3998 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4000 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4003 * window.c (Fset_window_start): Doc fix (bug#4199).
4004 (Fset_window_hscroll): Ditto.
4006 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4008 Fix minor new problems caught by GCC 4.6.1.
4009 * term.c (init_tty): Remove unused local.
4010 * xsettings.c (store_monospaced_changed): Define this function only
4011 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4014 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4016 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4018 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4020 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4021 are the mini-buffer and the echo area (bug#3320).
4023 * term.c (init_tty): Remove support for supdup, c10 and perq
4024 terminals, which are no longer supported (bug#1482).
4026 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4028 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4030 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4032 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4033 for non-popups (Bug#3642).
4035 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4037 * alloc.c (reset_malloc_hooks): Protoize.
4038 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4039 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4040 * cm.c (losecursor): Likewise.
4041 * data.c (fmod): Likewise.
4042 * dispnew.c (swap_glyphs_in_rows): Likewise.
4043 * emacs.c (memory_warning_signal): Likewise.
4044 * floatfns.c (float_error): Likewise.
4045 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4046 (otf_open, font_otf_capability, generate_otf_features)
4047 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4049 * image.c (pbm_read_file): Likewise.
4050 * indent.c (string_display_width): Likewise.
4051 * intervals.c (check_for_interval, search_for_interval)
4052 (inc_interval_count, count_intervals, root_interval)
4053 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4054 * lread.c (defalias): Likewise.
4055 * ralloc.c (r_alloc_check): Likewise.
4056 * regex.c (set_image_of_range_1, set_image_of_range)
4057 (regex_grow_registers): Likewise.
4058 * sysdep.c (strerror): Likewise.
4059 * termcap.c (valid_filename_p, tprint, main): Likewise.
4060 * tparam.c (main): Likewise.
4061 * unexhp9k800.c (run_time_remap, save_data_space)
4062 (update_file_ptrs, read_header, write_header, calculate_checksum)
4063 (copy_file, copy_rest, display_header): Likewise.
4064 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4066 * xdisp.c (check_it): Likewise.
4067 * xfaces.c (register_color, unregister_color, unregister_colors):
4069 * xfns.c (print_fontset_result): Likewise.
4070 * xrdb.c (member, fatal, main): Likewise.
4072 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4074 Fix minor problems found by static checking (Bug#9031).
4075 * chartab.c (char_table_set_range, map_sub_char_table):
4076 Remove unused locals.
4077 (uniprop_table): Now static.
4078 * composite.c (_work_char): Remove unused static var.
4080 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4082 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4084 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4086 * gtkutil.c (qttip_cb): Remove code without function.
4088 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4090 * w32.c (pthread_sigmask): New stub.
4092 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4094 Use pthread_sigmask, not sigprocmask (Bug#9010).
4095 sigprocmask is portable only for single-threaded applications, and
4096 Emacs can be multi-threaded when it uses GTK.
4097 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4099 * callproc.c (Fcall_process):
4100 * process.c (create_process):
4101 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4102 Use pthread_sigmask, not sigprocmask.
4104 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4106 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4107 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4110 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4112 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4113 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4114 (xg_hide_tooltip): Fix comment.
4116 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4117 in registerServicesMenuSendTypes.
4118 (validRequestorForSendType): Don't check ns_return_types.
4120 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4123 2011-07-08 Jason Rumney <jasonr@gnu.org>
4125 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4126 SH_SHOW for hidden windows (Bug#5482).
4128 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4129 frame struct members of non-existent frames (Bug#6284).
4131 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4133 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4134 variable firstTime not needed on OSX >= 10.6.
4135 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4136 >= 10.5. Use setKnobProportion, setDoubleValue.
4138 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4139 (MAC_OS_X_VERSION_10_5): Define if not defined.
4140 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4141 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4142 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4144 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4145 cString and lossyCString on OSX >= 10.4
4147 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4148 sizeToFit on OSX >= 10.2.
4150 * nsimage.m (allocInitFromFile): Don't use deprecated method
4151 bestRepresentationForDevice on OSX >= 10.6.
4153 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4156 * emacs.c: Declare unexec_init_emacs_zone.
4158 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4160 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4162 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4163 on svcsMenu (Bug#8842).
4165 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4167 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4169 * nsterm.m (QUTF8_STRING): Declare.
4170 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4171 (validRequestorForSendType): Return type is (id).
4172 Change indexOfObjectIdenticalTo to indexOfObject.
4173 Check if we have local selection before returning self (Bug#8842).
4174 (writeSelectionToPasteboard): Put local selection into paste board
4175 if we have a local selection (Bug#8842).
4176 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4178 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4179 (ns_get_local_selection): Declare.
4181 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4183 * keymap.c (describe_map_tree): Don't insert a double newline at
4184 the end of the buffer (bug#1169) and return whether we inserted
4187 * callint.c (Fcall_interactively): Change "reading args" to
4188 "providing args" to try to clarify what it does (bug#1010).
4190 2011-07-07 Kenichi Handa <handa@m17n.org>
4192 * composite.c (composition_compute_stop_pos): Ignore a static
4193 composition starting before CHARPOS (Bug#8915).
4195 * xdisp.c (handle_composition_prop): Likewise.
4197 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4199 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4202 2011-07-07 Kenichi Handa <handa@m17n.org>
4204 * character.h (unicode_category_t): New enum type.
4206 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4207 (Qchar_code_property_table): New variable.
4208 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4209 (UNIPROP_COMPRESSED_FORM_P): New macros.
4210 (char_table_ascii): Uncompress the compressed values.
4211 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4212 Uncompress the compressed values.
4213 (sub_char_table_ref_and_range): Likewise.
4214 (char_table_ref_and_range): Uncompress the compressed values.
4215 (sub_char_table_set): New arg is_uniprop. Callers changed.
4216 Uncompress the compressed values.
4217 (sub_char_table_set_range): Args changed. Callers changed.
4218 (char_table_set_range): Adjuted for the above change.
4219 (map_sub_char_table): Delete args default_val and parent. Add arg
4220 top. Give decoded values to a Lisp function.
4221 (map_char_table): Adjust for the above change. Give decoded
4222 values to a Lisp function. Gcpro more variables.
4223 (uniprop_table_uncompress)
4224 (uniprop_decode_value_run_length): New functions.
4225 (uniprop_decoder, uniprop_decoder_count): New variables.
4226 (uniprop_get_decoder, uniprop_encode_value_character)
4227 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4229 (uniprop_encoder, uniprop_encoder_count): New variables.
4230 (uniprop_get_encoder, uniprop_table)
4231 (Funicode_property_table_internal, Fget_unicode_property_internal)
4232 (Fput_unicode_property_internal): New functions.
4233 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4234 Sunicode_property_table_internal, Sget_unicode_property_internal,
4235 and Sput_unicode_property_internal. Defvar_lisp
4236 char-code-property-alist.
4238 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4239 Vunicode_category_table.
4241 * font.c (font_range): Adjust for the change of
4242 Vunicode_category_table.
4244 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4246 * m/iris4d.h: Remove file, move contents ...
4247 * s/irix6-5.h: ... here.
4249 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4251 Remove unportable assumption about struct layout (Bug#8884).
4252 * alloc.c (mark_buffer):
4253 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4254 (clone_per_buffer_values): Don't assume that
4255 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4256 This isn't true in general, and it's particularly not true
4257 if Emacs is configured with --with-wide-int.
4258 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4259 New macros, used in the buffer.c change.
4261 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4263 * xsettings.c: Use both GConf and GSettings if both are available.
4264 (store_config_changed_event): Add comment.
4265 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4266 (store_tool_bar_style_changed): New functions.
4267 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4268 (struct xsettings): Move font inside HAVE_XFT.
4269 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4270 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4271 Move inside HAVE_XFT.
4272 (something_changed_gsettingsCB): Rename from something_changedCB.
4273 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4275 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4276 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4277 (something_changed_gconfCB): Rename from something_changedCB.
4278 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4279 (parse_settings): Move check for font inside HAVE_XFT.
4280 (read_settings, apply_xft_settings): Add comment.
4281 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4282 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4283 call store_font_name_changed.
4284 (xft_settings_event): Add comment.
4285 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4286 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4287 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4288 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4289 (xsettings_initialize): Call init_gsettings last.
4290 (xsettings_get_system_font, xsettings_get_system_normal_font):
4293 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4295 Random fixes. E.g., (random) never returned negative values.
4296 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4297 subseconds part to the entropy, as that's a bit more random.
4298 Prefer signed to unsigned, since the signedness doesn't matter and
4299 in general we prefer signed. When given a limit, use a
4300 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4301 latter isn't right if USE_2_TAGS_FOR_INTS.
4302 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4303 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4305 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4307 * textprop.c (text_property_stickiness):
4308 Obey Vtext_property_default_nonsticky.
4309 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4310 * w32fns.c (syms_of_w32fns):
4311 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4313 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4315 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4316 This is more efficient than Ffile_directory_p and avoids a minor race.
4318 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4320 * buffer.c (Foverlay_put): Say what the return value is
4323 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4324 is a directory before asking whether to use the file name
4326 (barf_or_query_if_file_exists): Make the "File is a directory"
4327 error be more correct.
4329 * fns.c (Frequire): Remove the mention of the .gz files, since
4330 that's installation-specific, but keep the mention of
4331 `get-load-suffixes'.
4333 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4335 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4336 Report string overflow if the output is too long.
4338 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4340 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4341 (syms_of_gnutls): Remove duplicate DEFSYM for
4342 Qgnutls_bootprop_verify_hostname_error, an error for
4343 Qgnutls_bootprop_verify_error (which is no longer used).
4345 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4346 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4347 Also (re)move comments that are misplaced or no longer relevant.
4349 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4351 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4353 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4355 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4356 and background color parameters if they have been changed.
4358 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4360 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4362 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4364 * xsettings.c (SYSTEM_FONT): Define only when used.
4365 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4367 * keymap.c (access_keymap_1): Now static.
4369 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4371 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4372 leave any prefix arg for the up event (Bug#1586).
4374 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4376 * lread.c (syms_of_lread): Mention single symbols defined by
4377 `defvar' or `defconst' (bug#7154).
4379 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4380 (Frequire): Mention get-load-suffixes.
4382 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4384 * window.h (window): Remove clone_number slot.
4385 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4387 (make_parent_window, make_window, saved_window)
4388 (Fset_window_configuration, save_window_save): Don't deal with
4390 * buffer.c (Qclone_number): Remove declaration.
4391 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4393 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4395 Add multiple inheritance to keymaps.
4396 * keymap.c (Fmake_composed_keymap): New function.
4397 (Fset_keymap_parent): Simplify.
4398 (fix_submap_inheritance): Remove.
4399 (access_keymap_1): New function extracted from access_keymap to handle
4400 embedded parents and handle lists of maps.
4401 (access_keymap): Use it.
4402 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4403 (Fcopy_keymap): Handle embedded parents.
4404 (Fcommand_remapping, define_as_prefix): Simplify.
4405 (Fkey_binding): Simplify.
4406 (syms_of_keymap): Move minibuffer-local-completion-map,
4407 minibuffer-local-filename-completion-map,
4408 minibuffer-local-must-match-map, and
4409 minibuffer-local-filename-must-match-map to Elisp.
4410 (syms_of_keymap): Defsubr make-composed-keymap.
4411 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4412 (parse_menu_item): Trivial simplification.
4414 2011-07-01 Glenn Morris <rgm@gnu.org>
4416 * Makefile.in (SETTINGS_LIBS): Fix typo.
4418 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4420 * coding.c (Fencode_coding_string): Record the last coding system
4421 used, as the function doc string says (bug#8738).
4423 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4425 * xsettings.c (store_monospaced_changed): Take new font as arg and
4426 check for change against current_mono_font.
4427 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4428 (emacs_settings_constructor, emacs_settings_get_property)
4429 (emacs_settings_set_property, emacs_settings_class_init)
4430 (emacs_settings_init, gsettings_obj): Remove.
4431 (something_changedCB): New function for HAVE_GSETTINGS.
4432 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4433 with value as argument.
4434 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4435 g_settings_new (Bug#8967). Do not create gsettings_obj.
4436 Remove calls to g_settings_bind. Connect something_changedCB to
4439 * xgselect.c: Add defined (HAVE_GSETTINGS).
4440 (xgselect_initialize): Ditto.
4442 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4443 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4446 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4448 * eval.c (struct backtrace): Simplify and port the data structure.
4449 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4450 signed bit field, as this assumption is not portable and it makes
4451 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4452 "char debug_on_exit : 1" as this is not portable either; instead,
4453 use the portable "unsigned int debug_on_exit : 1". Remove unused
4454 member evalargs. Remove obsolete comments about cc bombing out.
4456 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4458 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4459 Let HAVE_GSETTINGS override HAVE_GCONF.
4460 (store_monospaced_changed): New function.
4461 (EMACS_SETTINGS): A new type derived from GObject to handle
4462 GSettings notifications.
4463 (emacs_settings_constructor, emacs_settings_get_property)
4464 (emacs_settings_set_property, emacs_settings_class_init):
4466 (gsettings_client, gsettings_obj): New variables.
4467 (GSETTINGS_SCHEMA): New define.
4468 (something_changedCB): Call store_monospaced_changed.
4469 (init_gsettings): New function.
4470 (xsettings_initialize): Call init_gsettings.
4471 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4474 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4477 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4479 * window.c (resize_root_window, grow_mini_window)
4480 (shrink_mini_window): Rename Qresize_root_window to
4481 Qwindow_resize_root_window and Qresize_root_window_vertically to
4482 Qwindow_resize_root_window_vertically.
4484 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4486 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4488 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4490 * makefile.w32-in: Redesign dependencies so they reflect more
4491 clearly which files are directly included by each source file,
4492 and not through other includes.
4494 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4496 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4497 (sort_overlays, overlay_strings): When an overlay's clone number
4498 matches the window's clone number process the overlay even if
4499 the overlay's window property doesn't match the current window.
4501 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4502 (Fwindow_hchild): Rename to Fwindow_left_child.
4503 (Fwindow_next): Rename to Fwindow_next_sibling.
4504 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4505 (resize_window_check): Rename to window_resize_check.
4506 (resize_window_apply): Rename to window_resize_apply.
4507 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4508 (Fdelete_other_windows_internal, resize_frame_windows)
4509 (Fsplit_window_internal, Fdelete_window_internal)
4510 (grow_mini_window, shrink_mini_window)
4511 (Fresize_mini_window_internal): Fix callers accordingly.
4513 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4515 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4516 (emacs_fixed_set_min_size): Remove.
4517 (emacs_fixed_new): Take frame as argument.
4519 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4520 (_EmacsFixedPrivate): Remove minwidth/height.
4521 Add struct frame *f.
4522 (emacs_fixed_init): Initialize priv->f.
4523 (get_parent_class, emacs_fixed_set_min_size): Remove.
4524 (emacs_fixed_new): Set priv->f to argument.
4525 (emacs_fixed_get_preferred_width)
4526 (emacs_fixed_get_preferred_height): Use min_width/height from
4527 frames size_hint to set minimum and natural (Bug#8919).
4528 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4529 and use min_width/height from frames size_hint to set
4530 min_width/height (Bug#8919).
4532 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4533 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4536 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4538 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4539 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4542 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4544 * process.c (wait_reading_process_output): Bypass select if
4545 waiting for a cell while ignoring keyboard input, and input is
4546 pending. Suggested by Jan Djärv (Bug#8869).
4548 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4550 Use gnulib's dup2 module instead of rolling our own.
4551 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4553 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4555 * dispnew.c (scrolling_window): Before scrolling, turn off a
4556 mouse-highlight in the window being scrolled.
4558 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4560 Move DEFSYM to lisp.h and use everywhere.
4562 * character.h (DEFSYM): Move declaration...
4563 * lisp.h (DEFSYM): ...here.
4569 * w32select.c: Don't include character.h.
4571 * alloc.c (syms_of_alloc):
4572 * buffer.c (syms_of_buffer):
4573 * bytecode.c (syms_of_bytecode):
4574 * callint.c (syms_of_callint):
4575 * casefiddle.c (syms_of_casefiddle):
4576 * casetab.c (init_casetab_once):
4577 * category.c (init_category_once, syms_of_category):
4578 * ccl.c (syms_of_ccl):
4579 * cmds.c (syms_of_cmds):
4580 * composite.c (syms_of_composite):
4581 * dbusbind.c (syms_of_dbusbind):
4582 * dired.c (syms_of_dired):
4583 * dispnew.c (syms_of_display):
4584 * doc.c (syms_of_doc):
4585 * editfns.c (syms_of_editfns):
4586 * emacs.c (syms_of_emacs):
4587 * eval.c (syms_of_eval):
4588 * fileio.c (syms_of_fileio):
4589 * fns.c (syms_of_fns):
4590 * frame.c (syms_of_frame):
4591 * fringe.c (syms_of_fringe):
4592 * insdel.c (syms_of_insdel):
4593 * keymap.c (syms_of_keymap):
4594 * lread.c (init_obarray, syms_of_lread):
4595 * macros.c (syms_of_macros):
4596 * msdos.c (syms_of_msdos):
4597 * print.c (syms_of_print):
4598 * process.c (syms_of_process):
4599 * search.c (syms_of_search):
4600 * sound.c (syms_of_sound):
4601 * syntax.c (init_syntax_once, syms_of_syntax):
4602 * terminal.c (syms_of_terminal):
4603 * textprop.c (syms_of_textprop):
4604 * undo.c (syms_of_undo):
4605 * w32.c (globals_of_w32):
4606 * window.c (syms_of_window):
4607 * xdisp.c (syms_of_xdisp):
4608 * xfaces.c (syms_of_xfaces):
4609 * xfns.c (syms_of_xfns):
4610 * xmenu.c (syms_of_xmenu):
4611 * xsettings.c (syms_of_xsettings):
4612 * xterm.c (syms_of_xterm): Use DEFSYM.
4614 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4616 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4618 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4620 Integer and buffer overflow fixes (Bug#8873).
4622 * print.c (printchar, strout): Check for string overflow.
4623 (PRINTPREPARE, printchar, strout):
4624 Don't set size unless allocation succeeds.
4626 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4627 for sizes. Check for string overflow more accurately.
4628 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4630 * macros.c: Integer and buffer overflow fixes.
4631 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4632 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4633 Use ptrdiff_t, not int, for sizes.
4634 Don't increment bufsize until after realloc succeeds.
4635 Check for size-calculation overflow.
4636 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4638 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4640 * lread.c: Integer overflow fixes.
4641 (read_integer): Radix is now EMACS_INT, not int,
4642 to improve quality of diagnostics for out-of-range radices.
4643 Calculate buffer size correctly for out-of-range radices.
4644 (read1): Check for integer overflow in radices, and in
4645 read-circle numbers.
4646 (read_escape): Avoid int overflow.
4647 (Fload, openp, read_buffer_size, read1)
4648 (substitute_object_recurse, read_vector, read_list, map_obarray):
4649 Use ptrdiff_t, not int, for sizes.
4650 (read1): Use EMACS_INT, not int, for sizes.
4651 Check for size overflow.
4653 * image.c (cache_image): Check for size arithmetic overflow.
4655 * lread.c: Integer overflow issues.
4656 (saved_doc_string_size, saved_doc_string_length)
4657 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4658 Now ptrdiff_t, not int.
4659 (read1): Don't assume doc string length fits in int. Check for
4660 out-of-range doc string lengths.
4661 (read_list): Don't assume file position fits in int.
4662 (read_escape): Check for hex character overflow.
4664 2011-06-22 Leo Liu <sdl.web@gmail.com>
4666 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4667 Move to minibuffer.el.
4669 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4671 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4672 The following patches are for when GLYPH_DEBUG && !XASSERT.
4673 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4674 * dispnew.c (flush_stdout):
4675 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4676 Mark as externally visible.
4677 * dispnew.c (check_window_matrix_pointers): Now static.
4678 * dispnew.c (window_to_frame_vpos):
4679 * xfns.c (unwind_create_frame):
4680 * xterm.c (x_check_font): Remove unused local.
4681 * scroll.c (CHECK_BOUNDS):
4682 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4683 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4684 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4685 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4686 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4688 (debug_method_add): Use va_list and vsprintf rather than relying
4689 on undefined behavior with wrong number of arguments.
4690 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4691 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4692 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4693 since we're not interested in debugging glyphs with old libraries.
4694 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4695 GCC 4.6.0's static checking.
4697 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4699 Integer overflow and signedness fixes (Bug#8873).
4700 A few related buffer overrun fixes, too.
4702 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4704 * dispextern.h (struct face.stipple):
4705 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4706 (x_bitmap_mask, x_allocate_bitmap_record)
4707 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4708 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4709 (x_create_bitmap_from_xpm_data):
4710 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4711 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4713 * xfaces.c (load_pixmap):
4714 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4715 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4716 (.bitmaps_last, struct x_output.icon_bitmap):
4717 Use ptrdiff_t, not int, for bitmap indexes.
4718 (x_allocate_bitmap_record): Check for size overflow.
4719 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4721 Use ptrdiff_t, not int, for overlay counts.
4722 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4723 * editfns.c (overlays_around, get_pos_property):
4724 * textprop.c (get_char_property_and_overlay):
4725 * xdisp.c (next_overlay_change, note_mouse_highlight):
4726 * xfaces.c (face_at_buffer_position):
4727 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4728 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4729 (Fnext_overlay_change, Fprevious_overlay_change)
4730 (mouse_face_overlay_overlaps, Foverlays_in):
4731 Use ptrdiff_t, not int, for sizes.
4732 (overlays_at, overlays_in): Check for size-calculation overflow.
4734 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4736 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4737 (x_session_initialize): Do not assume string length fits in int.
4739 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4740 This is unlikely, but can occur if DPI is outlandish.
4742 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4743 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4745 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4746 * xrdb.c (magic_file_p, search_magic_path):
4747 Omit last arg SUFFIX; it was always 0. All callers changed.
4748 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4750 * xfont.c (xfont_match): Avoid need for strlen.
4752 * xfns.c: Don't assume strlen fits in int.
4753 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4755 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4756 not unsigned long, as we prefer signed integers. All callers changed.
4757 Detect integer overflow in repeat count.
4758 (message_dolog): Don't assume print length fits in 39 bytes.
4759 (display_mode_element): Don't assume strlen fits in int.
4761 * termcap.c: Don't assume sizes fit in int and never overflow.
4762 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4763 (gobble_line): Check for size-calculation overflow.
4765 * minibuf.c (Fread_buffer):
4766 * lread.c (intern, intern_c_string):
4767 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4768 Don't assume string length fits in int.
4770 * keyboard.c (parse_tool_bar_item):
4771 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4773 * font.c: Don't assume string length fits in int.
4774 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4775 Use ptrdiff_t, not int.
4776 (font_intern_prop): Don't assume string length fits in int.
4777 Don't assume integer property fits in fixnum.
4778 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4780 * filelock.c: Fix some buffer overrun and integer overflow issues.
4781 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4782 Reformulate so as not to need the command string.
4783 Invoke gzip -cd rather than gunzip, as it's more portable.
4784 (lock_info_type, lock_file_1, lock_file):
4785 Don't assume pid_t and time_t fit in unsigned long.
4786 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4787 (current_lock_owner): Prefer signed type for sizes.
4788 Use memcpy, not strncpy, where memcpy is what is really wanted.
4789 Don't assume (via atoi) that time_t and pid_t fit in int.
4790 Check for time_t and/or pid_t out of range, e.g., via a network share.
4791 Don't alloca where an auto var works fine.
4793 * fileio.c: Fix some integer overflow issues.
4794 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4795 Don't assume string length fits in int.
4796 (directory_file_name): Don't assume string length fits in long.
4797 (make_temp_name): Don't assume pid fits in int, or that its print
4798 length is less than 20.
4800 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4802 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4804 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4806 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4807 We prefer signed integers, even for size calculations.
4809 * emacs.c: Don't assume string length fits in 'int'.
4810 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4811 (main): Don't invoke strlen when not needed.
4813 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4814 (XD_DEBUG_MESSAGE): Don't waste a byte.
4816 * callproc.c (getenv_internal_1, getenv_internal)
4818 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4820 * lread.c (invalid_syntax): Omit length argument.
4821 All uses changed. This doesn't fix a bug, but it simplifies the
4822 code away from its former Hollerith-constant appearance, and it's
4823 one less 'int' to worry about when looking at integer-overflow issues.
4824 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4826 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4827 This didn't break anything, but it didn't help either.
4828 It's confusing to put a bogus integer in a place where the actual
4829 value does not matter.
4830 (LIST_END_P): Remove unused macro and its bogus comment.
4831 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4833 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4834 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4836 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4837 We prefer signed types, and the value cannot exceed the EMACS_INT
4838 range anyway (because otherwise the length would not be representable).
4839 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4840 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4841 This avoids a GCC warning when WIDE_EMACS_INT.
4843 * indent.c (sane_tab_width): New function.
4844 (current_column, scan_for_column, Findent_to, position_indentation)
4845 (compute_motion): Use it. This is just for clarity.
4846 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4848 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4850 * lisp.h (lint_assume): New macro.
4851 * composite.c (composition_gstring_put_cache):
4852 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4854 * editfns.c, insdel.c:
4855 Omit unnecessary forward decls, to simplify future changes.
4857 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4859 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4861 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4862 Use much-faster test for byte-length change.
4863 Don't assume string byte-length fits in 'int'.
4864 Check that character arg fits in 'int'.
4865 (mapcar1): Declare byte as byte, for clarity.
4867 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4869 * fns.c (concat): Catch string overflow earlier.
4870 Do not rely on integer wraparound.
4872 * dispextern.h (struct it.overlay_strings_charpos)
4873 (struct it.selective): Now EMACS_INT, not int.
4874 * xdisp.c (forward_to_next_line_start)
4875 (back_to_previous_visible_line_start)
4876 (reseat_at_next_visible_line_start, next_element_from_buffer):
4877 Don't arbitrarily truncate the value of 'selective' to int.
4879 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4881 * composite.c: Don't truncate sizes to 'int'.
4882 (composition_gstring_p, composition_reseat_it)
4883 (composition_adjust_point): Use EMACS_INT, not int.
4884 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4885 not EMACS_UINT, for indexes.
4887 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4889 * buffer.c: Include <verify.h>.
4890 (struct sortvec.priority, struct sortstr.priority):
4891 Now EMACS_INT, not int.
4892 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4893 (struct sortstr.size, record_overlay_string)
4894 (struct sortstrlist.size, struct sortlist.used):
4895 Don't truncate size to int.
4896 (record_overlay_string): Check for size-calculation overflow.
4897 (init_buffer_once): Check at compile-time, not run-time.
4899 2011-06-22 Jim Meyering <meyering@redhat.com>
4901 Don't leak an XBM-image-sized buffer
4902 * image.c (xbm_load): Free the image buffer after using it.
4904 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4907 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4908 that Sun C diagnosed.
4909 * fns.c (secure_hash): Fix pointer signedness issue.
4910 * intervals.c (static_offset_intervals): New function.
4911 (offset_intervals): Use it.
4913 2011-06-21 Leo Liu <sdl.web@gmail.com>
4916 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4919 * fns.c (secure_hash): Rename from crypto_hash_function and change
4920 the first arg to accept symbols.
4921 (Fsecure_hash): New primitive.
4922 (syms_of_fns): New symbols.
4924 2011-06-20 Deniz Dogan <deniz@dogan.se>
4926 * process.c (Fset_process_buffer): Clarify return value in
4929 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4931 * dispnew.c (add_window_display_history): Use BVAR.
4933 * xdisp.c (debug_method_add): Use BVAR.
4934 (check_window_end, dump_glyph_matrix, dump_glyph)
4935 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4937 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4940 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4941 check till after the cache is created in init_frame_faces.
4943 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4945 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4947 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4949 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4950 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4951 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4953 Improve buffer-overflow checking (Bug#8873).
4954 * fileio.c (Finsert_file_contents):
4955 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4956 Remove the old (too-loose) buffer overflow checks.
4957 They weren't needed, since make_gap checks for buffer overflow.
4958 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4959 The old code merely checked for Emacs fixnum overflow, and relied
4960 on undefined (wraparound) behavior. The new code avoids undefined
4961 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4963 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4964 Tune. Don't use wider integers than needed. Don't use alloca.
4965 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4967 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4969 * insdel.c, lisp.h (buffer_overflow): New function.
4970 (insert_from_buffer_1, replace_range, replace_range_2):
4971 * insdel.c (make_gap_larger):
4972 * editfns.c (Finsert_char):
4973 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4975 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4977 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4979 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4981 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4982 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4984 * fileio.c: Don't assume EMACS_INT fits in off_t.
4985 (emacs_lseek): New static function.
4986 (Finsert_file_contents, Fwrite_region): Use it.
4987 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4989 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4991 * fns.c: Don't overflow int when computing a list length.
4992 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4993 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4994 truncation on 64-bit hosts. Check for QUIT every
4995 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4996 faster and is responsive enough.
4997 (Flength): Report an error instead of overflowing an integer.
4998 (Fsafe_length): Return a float if the value is not representable
4999 as a fixnum. This shouldn't happen except in contrived situations.
5000 (Fnthcdr, Fsort): Don't assume list length fits in int.
5001 (Fcopy_sequence): Don't assume vector length fits in int.
5003 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5004 (header_size, word_size): New constants.
5005 (allocate_vectorlike): Don't check size overflow here.
5006 (allocate_vector): Check it here instead, since this is the only
5007 caller of allocate_vectorlike that could cause overflow.
5008 Check that the new vector's length is representable as a fixnum.
5010 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5011 The previous code was bogus. For example, next_almost_prime (32)
5012 returned 39, which is undesirable as it is a multiple of 3; and
5013 next_almost_prime (24) returned 25, which is a multiple of 5 so
5014 why was the code bothering to check for multiples of 7?
5016 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5018 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5020 Variadic C functions now count arguments with ptrdiff_t.
5021 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5022 Back then I didn't know that the Emacs coding style prefers signed int.
5023 Also, in the meantime I found a few more instances where arguments
5024 were being counted with int, which may truncate counts on 64-bit
5025 machines, or EMACS_INT, which may be unnecessarily wide.
5026 * lisp.h (struct Lisp_Subr.function.aMANY)
5027 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5028 Arg counts are now ptrdiff_t, not size_t.
5029 All variadic functions and their callers changed accordingly.
5030 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5031 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5032 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5033 * callint.c (Fcall_interactively): Check arg count for overflow,
5034 to avoid potential buffer overrun. Use signed char, not 'int',
5035 for 'varies' array, so that we needn't bother to check its size
5036 calculation for overflow.
5037 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5038 * eval.c (apply_lambda):
5039 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5040 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5041 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5043 * callint.c (Fcall_interactively): Don't use index var as event count.
5045 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5046 * mem-limits.h (SIZE): Remove; no longer used.
5048 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5050 Remove unnecessary casts.
5051 * xterm.c (x_term_init):
5052 * xfns.c (x_set_border_pixel):
5053 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5054 These aren't needed now that we assume ANSI C.
5056 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5057 It's more likely to cause problems (due to unsigned overflow)
5060 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5062 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5064 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5066 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5068 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5070 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5072 GLYPH_CODE_FACE returns EMACS_INT, not int.
5073 * dispextern.h (merge_faces):
5074 * xfaces.c (merge_faces):
5075 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5076 Don't assume EMACS_INT fits in int.
5078 * character.h (CHAR_VALID_P): Remove unused parameter.
5079 * fontset.c, lisp.h, xdisp.c: All uses changed.
5081 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5083 * fns.c (concat): Minor tuning based on overflow analysis.
5084 This doesn't fix any bugs. Use int to hold character, instead
5085 of constantly refetching from Emacs object. Use XFASTINT, not
5086 XINT, for value known to be a character. Don't bother comparing
5087 a single byte to 0400, as it's always less.
5089 * floatfns.c (Fexpt):
5090 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5092 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5095 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5097 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5098 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5099 incorrectly succeed when S was a string, because 4294967386 was
5100 truncated before it was used.
5102 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5103 Otherwise, an out-of-range integer could cause undefined behavior
5106 * composite.c: Use int, not EMACS_INT, for characters.
5107 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5108 EMACS_INT, for values that are known to be in character range.
5109 This doesn't fix any bugs but is the usual style inside Emacs and
5110 may generate better code on 32-bit machines.
5112 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5113 This is for reasons similar to the recent CHAR_STRING fix.
5114 * charset.c (Fencode_char): Check that character arg is actually
5115 a character. Pass an int to ENCODE_CHAR.
5116 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5117 wider than 'int', as a compile-time check to prevent future regressions
5120 * character.c (char_string): Remove unnecessary casts.
5122 Make sure a 64-bit char is never passed to CHAR_STRING.
5123 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5124 by silently ignoring the top 32 bits, allowing some values
5125 that were far too large to be valid characters.
5126 * character.h: Include <verify.h>.
5127 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5128 arguments are no wider than unsigned, as a compile-time check
5129 to prevent future regressions in this area.
5131 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5132 (Fsubst_char_in_region):
5134 * xdisp.c (decode_mode_spec_coding):
5135 Adjust to CHAR_STRING's new requirement.
5136 * editfns.c (Finsert_char, Fsubst_char_in_region):
5137 * fns.c (concat): Check that character args are actually
5138 characters. Without this test, these functions did the wrong
5139 thing with wildly out-of-range values on 64-bit hosts.
5141 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5142 These casts should not be needed on 32-bit hosts, either.
5143 * keyboard.c (read_char):
5144 * lread.c (Fload): Remove casts to unsigned.
5146 * lisp.h (UNSIGNED_CMP): New macro.
5147 This fixes comparison bugs on 64-bit hosts.
5148 (ASCII_CHAR_P): Use it.
5149 * casefiddle.c (casify_object):
5150 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5151 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5152 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5153 * dispextern.h (FACE_FROM_ID):
5154 * keyboard.c (read_char): Use UNSIGNED_CMP.
5156 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5157 not to EMACS_INT, to avoid GCC warning.
5159 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5161 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5162 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5163 isn't needed on 32-bit machines.
5165 * buffer.c (Fgenerate_new_buffer_name):
5166 Use EMACS_INT for count, not int.
5167 (advance_to_char_boundary): Return EMACS_INT, not int.
5169 * data.c (Qcompiled_function): Now static.
5171 * window.c (window_body_lines): Now static.
5173 * image.c (gif_load): Rename local to avoid shadowing.
5175 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5176 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5177 * alloc.c (make_save_value): Integer argument is now of type
5179 (mark_object): Use ptrdiff_t, not int.
5180 * lisp.h (pD): New macro.
5181 * print.c (print_object): Use it.
5183 * alloc.c: Use EMACS_INT, not int, to count objects.
5184 (total_conses, total_markers, total_symbols, total_vector_size)
5185 (total_free_conses, total_free_markers, total_free_symbols)
5186 (total_free_floats, total_floats, total_free_intervals)
5187 (total_intervals, total_strings, total_free_strings):
5188 Now EMACS_INT, not int. All uses changed.
5189 (Fgarbage_collect): Compute overall total using a double, so that
5190 integer overflow is less likely to be a problem. Check for overflow
5191 when converting back to an integer.
5192 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5193 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5194 These were 'int' variables that could overflow on 64-bit hosts;
5195 they were never used, so remove them instead of repairing them.
5196 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5197 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5198 Previously, this ceilinged at INT_MAX, but that doesn't work on
5200 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5202 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5203 (allocate_vectorlike): Check for ptrdiff_t overflow.
5204 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5205 when a (possibly-narrower) signed value would do just as well.
5206 We prefer using signed arithmetic, to avoid comparison confusion.
5208 * alloc.c: Catch some string size overflows that we were missing.
5209 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5210 for convenience in STRING_BYTES_MAX.
5211 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5212 The definition here is exact; the one in lisp.h was approximate.
5213 (allocate_string_data): Check for string overflow. This catches
5214 some instances we weren't catching before. Also, it catches
5215 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5216 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5217 and ptrdiff_t and EMACS_INT are both 64 bits.
5219 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5220 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5221 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5223 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5225 * alloc.c (Fmake_string): Check for out-of-range init.
5227 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5229 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5231 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5233 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5234 xg_get_default_scrollbar_width.
5236 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5237 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5238 (style_changed_cb): Call update_theme_scrollbar_width and call
5239 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5240 all frames (Bug#8505).
5241 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5242 Call gtk_window_set_resizable if HAVE_GTK3.
5243 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5244 and height if HAVE_GTK3 (Bug#8505).
5245 (scroll_bar_width_for_theme): New variable.
5246 (update_theme_scrollbar_width): New function.
5247 (xg_get_default_scrollbar_width): Move code to
5248 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5249 (xg_initialize): Call update_theme_scrollbar_width.
5251 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5253 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5255 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5257 * frame.c (make_frame): Call other_buffer_safely instead of
5260 * window.c (temp_output_buffer_show): Call display_buffer with
5261 second argument Vtemp_buffer_show_specifiers and reset latter
5262 immediately after the call.
5263 (Vtemp_buffer_show_specifiers): New variable.
5264 (auto_window_vscroll_p, next_screen_context_lines)
5265 (Vscroll_preserve_screen_position): Remove leading asterisks from
5268 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5270 Fix minor problems found by GCC 4.6.0 static checking.
5271 * buffer.c (Qclone_number): Remove for now, as it's unused.
5272 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5273 (record_buffer): Remove unused local.
5274 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5275 (set_frame_buffer_list): Remove; unused.
5276 * frame.h (other_visible_frames): Remove decl.
5277 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5278 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5279 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5281 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5282 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5283 Define only if HAVE_GPM.
5284 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5285 (update_hints_inhibit): Remove; never set. All uses removed.
5286 * widgetprv.h (emacsFrameClassRec): Remove decl.
5287 * window.c (delete_deletable_window): Now returns void, since it
5288 wasn't returning anything.
5289 (compare_window_configurations): Remove unused locals.
5290 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5291 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5292 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5293 the same widths as pointers. This follows up on the 2011-05-06 patch.
5294 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5295 * xterm.h: Likewise.
5296 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5298 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5300 * makefile.w32-in: Update dependencies.
5301 (LISP_H): Add lib/intprops.h.
5303 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5305 * image.c (gif_load): Add animation frame delay to the metadata.
5306 (syms_of_image): Use DEFSYM. New symbol `delay'.
5308 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5310 * window.c (delete_deletable_window): Re-add.
5311 (Fset_window_configuration): Rewrite to handle dead buffers and
5312 consequently deletable windows.
5313 (window_tree, Fwindow_tree): Remove. Supply functionality in
5315 (compare_window_configurations): Simplify code.
5317 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5319 * image.c (imagemagick_load_image): Fix type mismatch.
5320 (Fimagemagick_types): Likewise.
5322 * window.h (replace_buffer_in_windows): Declare.
5324 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5326 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5327 Qclone_number. Remove external declaration of Qdelete_window.
5328 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5330 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5331 Run Qbuffer_list_update_hook if allowed.
5332 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5333 buffer list implementation.
5334 (other_buffer_safely): New function.
5335 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5336 calls to replace_buffer_in_windows and
5337 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5339 (record_buffer): Inhibit quitting and rewrite using quittable
5340 functions. Run Qbuffer_list_update_hook if allowed.
5341 (Frecord_buffer, Funrecord_buffer): New functions.
5342 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5343 Move switch-to-buffer to window.el.
5344 (bury-buffer): Move to window.el.
5345 (Vbuffer_list_update_hook): New variable.
5347 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5350 * window.h (resize_frame_windows): Move up in code.
5351 (Fwindow_frame): Remove EXFUN.
5352 (replace_buffer_in_all_windows): Remove prototype.
5353 (replace_buffer_in_windows_safely): Add prototype.
5355 * window.c: Declare Qdelete_window static again. Move down
5356 declaration of select_count.
5357 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5358 (Fother_window): Move to window.el.
5359 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5360 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5361 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5363 (replace_buffer_in_windows): Implement by calling
5364 Qreplace_buffer_in_windows.
5365 (replace_buffer_in_all_windows): Remove with some functionality
5366 moved into replace_buffer_in_windows_safely.
5367 (replace_buffer_in_windows_safely): New function.
5368 (select_window_norecord, select_frame_norecord): Move in front
5369 of run_window_configuration_change_hook. Remove now obsolete
5371 (Fset_window_buffer): Rewrite doc-string.
5372 Call Qrecord_window_buffer.
5373 (keys_of_window): Move binding for other-window to window.el.
5375 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5377 * dispextern.h (struct image): Replace data member, whose int_val
5378 and ptr_val fields were not used by anything, with a single
5381 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5382 (gif_clear_image, gif_load, imagemagick_load_image)
5383 (gs_clear_image, gs_load): Callers changed.
5385 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5387 * buffer.h: Include <time.h>, for time_t.
5388 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5390 Fix minor problems found by static checking.
5392 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5394 Make identifiers static if they are not used in other modules.
5395 * data.c (Qcompiled_function, Qframe, Qvector):
5396 * image.c (QimageMagick, Qsvg):
5397 * minibuf.c (Qmetadata):
5398 * window.c (resize_window_check, resize_root_window): Now static.
5399 * window.h (resize_window_check, resize_root_window): Remove decls.
5401 * window.c (window_deletion_count, delete_deletable_window):
5403 (window_body_lines): Now static.
5404 (Fdelete_other_windows_internal): Mark vars as initialized.
5405 Make sure 'resize_failed' is initialized.
5406 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5407 (resize_window_apply): Remove unused local.
5408 * window.h (delete_deletable_window): Remove decl.
5410 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5411 (imagemagick_load_image): Fix pointer signedness problem by changing
5412 last arg from unsigned char * to char *. All uses changed.
5413 Also, fix a local for similar reasons.
5414 Remove unused locals. Remove locals to avoid shadowing.
5415 (fn_rsvg_handle_free): Remove; unused.
5416 (svg_load, svg_load_image): Fix pointer signedness problem.
5417 (imagemagick_load_image): Don't use garbage pointer image_wand.
5419 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5421 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5423 * image.c (gif_load): Fix omitted cast error introduced by
5426 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5428 * window.h (resize_proportionally, orig_total_lines)
5429 (orig_top_line): Remove from window structure.
5430 (set_window_height, set_window_width, change_window_heights)
5431 (Fdelete_window): Remove prototypes.
5432 (resize_frame_windows): Remove duplicate declaration.
5434 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5436 * window.h (resize_frame_windows, resize_window_check)
5437 (delete_deletable_window, resize_root_window)
5438 (resize_frame_windows): Declare prototypes.
5440 * window.c (resize_window_apply): Make definition be "static" to
5441 match the prototype.
5443 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5445 * window.c: Remove declarations of Qwindow_size_fixed,
5446 window_min_size_1, window_min_size_2, window_min_size,
5447 size_window, window_fixed_size_p, enlarge_window, delete_window.
5448 Remove static from declaration of Qdelete_window, it's
5449 temporarily needed by Fbury_buffer.
5450 (replace_window): Don't assign orig_top_line and
5452 (Fdelete_window, delete_window): Remove. Window deletion is
5453 handled by window.el.
5454 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5455 Replace Fdelete_window calls with calls to Qdelete_window.
5456 (Fdelete_other_windows): Remove. Deleting other windows is
5457 handled by window.el.
5458 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5459 handled in window.el.
5460 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5461 Window minimum sizes are handled in window.el.
5462 (shrink_windows, size_window, set_window_height)
5463 (set_window_width, change_window_heights, window_height)
5464 (window_width, CURBEG, CURSIZE, enlarge_window)
5465 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5466 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5467 handled in window.el.
5468 (make_dummy_parent): Rename to make_parent_window and give it a
5469 second argument horflag.
5470 (make_window): Don't set resize_proportionally any more.
5471 (Fsplit_window): Remove. Windows are split in window.el.
5472 (save_restore_action, save_restore_orig_size)
5473 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5474 Resize mini windows in window.el.
5475 (grow_mini_window, shrink_mini_window): Implement by calling
5476 Qresize_root_window_vertically, resize_window_check and
5477 resize_window_apply.
5478 (saved_window, Fset_window_configuration, save_window_save):
5479 Do not handle orig_top_line, orig_total_lines, and
5480 resize_proportionally.
5481 (window_min_height, window_min_width): Move to window.el.
5482 (keys_of_window): Move bindings for delete-other-windows,
5483 split-window, delete-window and enlarge-window to window.el.
5485 * buffer.c: Temporarily extern Qdelete_window.
5486 (Fbury_buffer): Temporarily call Qdelete_window instead of
5487 Fdelete_window (Fbury_buffer will move to window.el soon).
5489 * frame.c (set_menu_bar_lines_1): Remove code handling
5490 orig_top_line and orig_total_lines.
5492 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5493 set_window_height but set heights directly.
5494 (change_frame_size_1): Use resize_frame_windows.
5496 * xdisp.c (init_xdisp): Don't use set_window_height but set
5499 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5500 Use resize_frame_windows instead of change_window_heights and run
5501 run_window_configuration_change_hook.
5503 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5504 instead of change_window_heights and run
5505 run_window_configuration_change_hook.
5507 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5509 * window.c (replace_window): Rename second argument REPLACEMENT to
5510 NEW. New third argument SETFLAG. Rewrite.
5511 (delete_window, make_dummy_parent): Call replace_window with
5513 (window_list_1): Move down in code.
5514 (run_window_configuration_change_hook): Move set_buffer part
5515 before select_frame_norecord part in order to unwind correctly.
5516 Rename count1 to count.
5517 (recombine_windows, delete_deletable_window, resize_root_window)
5518 (Fdelete_other_windows_internal)
5519 (Frun_window_configuration_change_hook, make_parent_window)
5520 (resize_window_check, resize_window_apply, Fresize_window_apply)
5521 (resize_frame_windows, Fsplit_window_internal)
5522 (Fdelete_window_internal, Fresize_mini_window_internal):
5524 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5526 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5528 * window.h (window): Add some new members to window structure -
5529 normal_lines, normal_cols, new_total, new_normal, clone_number,
5530 splits, nest, prev_buffers, next_buffers.
5531 (WINDOW_TOTAL_SIZE): Move here from window.c.
5532 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5534 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5536 (make_dummy_parent): Set new members of windows structure.
5537 (make_window): Move down in code. Handle new members of window
5539 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5540 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5541 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5542 (Fset_window_prev_buffers, Fwindow_next_buffers)
5543 (Fset_window_next_buffers, Fset_window_clone_number):
5545 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5546 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5548 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5549 Argument WINDOW can be now internal window too.
5550 (Fwindow_use_time): Move up in code.
5551 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5553 (Fset_window_configuration, saved_window)
5554 (Fcurrent_window_configuration, save_window_save): Handle new
5555 members of window structure.
5556 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5557 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5558 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5559 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5560 Qget_mru_window, Qresize_root_window,
5561 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5562 Qauto_buffer_name; staticpro them.
5564 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5566 * window.c (Fwindow_total_size, Fwindow_left_column)
5567 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5568 (Fwindow_list_1): New functions.
5569 (window_box_text_cols): Replace with window_body_cols.
5570 (Fwindow_width, Fscroll_left, Fscroll_right):
5571 Use window_body_cols instead of window_box_text_cols.
5572 (delete_window, Fset_window_configuration):
5573 Call delete_all_subwindows with window as argument.
5574 (delete_all_subwindows): Take a window as argument and not a
5576 (window_loop): Remove handling of GET_LRU_WINDOW and
5578 (Fget_lru_window, Fget_largest_window): Move to window.el.
5580 * window.h: Extern window_body_cols instead of
5581 window_box_text_cols. delete_all_subwindows now takes a
5582 Lisp_Object as argument.
5584 * indent.c (compute_motion, Fcompute_motion):
5585 Use window_body_cols instead of window_box_text_cols.
5587 * frame.c (delete_frame): Call delete_all_subwindows with root
5590 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5592 * fns.c (Fputhash): Document return value.
5594 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5596 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5598 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5600 Cons<->int and similar integer overflow fixes (Bug#8794).
5602 Check for overflow when converting integer to cons and back.
5603 * charset.c (Fdefine_charset_internal, Fdecode_char):
5604 Use cons_to_unsigned to catch overflow.
5605 (Fencode_char): Use INTEGER_TO_CONS.
5606 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5607 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5608 * data.c (long_to_cons, cons_to_long): Remove.
5609 (cons_to_unsigned, cons_to_signed): New functions.
5610 These signal an error for invalid or out-of-range values.
5611 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5612 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5613 * font.c (Ffont_variation_glyphs):
5614 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5615 * lisp.h: Include <intprops.h>.
5616 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5617 (cons_to_signed, cons_to_unsigned): New decls.
5618 (long_to_cons, cons_to_long): Remove decls.
5619 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5620 (Fprimitive_undo): Use CONS_TO_INTEGER.
5621 * xfns.c (Fx_window_property): Likewise.
5622 * xselect.c: Include <limits.h>.
5623 (x_own_selection, selection_data_to_lisp_data):
5624 Use INTEGER_TO_CONS.
5625 (x_handle_selection_request, x_handle_selection_clear)
5626 (x_get_foreign_selection, Fx_disown_selection_internal)
5627 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5628 (lisp_data_to_selection_data): Use cons_to_unsigned.
5629 (x_fill_property_data): Use cons_to_signed.
5630 Report values out of range.
5632 Check for buffer and string overflow more precisely.
5633 * buffer.h (BUF_BYTES_MAX): New macro.
5634 * lisp.h (STRING_BYTES_MAX): New macro.
5635 * alloc.c (Fmake_string):
5636 * character.c (string_escape_byte8):
5637 * coding.c (coding_alloc_by_realloc):
5638 * doprnt.c (doprnt):
5639 * editfns.c (Fformat):
5641 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5642 since they may not be the same number.
5643 * editfns.c (Finsert_char):
5644 * fileio.c (Finsert_file_contents):
5645 Likewise for BUF_BYTES_MAX.
5647 * image.c: Use ptrdiff_t, not int, for sizes.
5648 (slurp_file): Switch from int to ptrdiff_t.
5650 (slurp_file): Check that file size fits in both size_t (for
5651 malloc) and ptrdiff_t (for sanity and safety).
5653 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5654 if b->modtime has its maximal value.
5656 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5658 Don't assume time_t can fit into int.
5659 * buffer.h (struct buffer.modtime): Now time_t, not int.
5660 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5661 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5663 Minor fixes for signed vs unsigned integers.
5664 * character.h (MAYBE_UNIFY_CHAR):
5665 * charset.c (maybe_unify_char):
5666 * keyboard.c (read_char, reorder_modifiers):
5667 XINT -> XFASTINT, since the integer must be nonnegative.
5668 * ftfont.c (ftfont_spec_pattern):
5669 * keymap.c (access_keymap, silly_event_symbol_error):
5670 XUINT -> XFASTINT, since the integer must be nonnegative.
5671 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5672 since it makes no difference and we prefer signed.
5673 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5674 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5677 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5679 * window.h (Fwindow_frame): Declare.
5681 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5683 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5684 (SPARE_MEMORY): Always define.
5685 (LARGE_REQUEST): Remove.
5686 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5688 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5690 * lisp.h: Move EXFUNS for Fframe_root_window,
5691 Fframe_first_window and Fset_frame_selected_window to window.h.
5693 * window.h: Move EXFUNS for Fframe_root_window,
5694 Fframe_first_window and Fset_frame_selected_window here from
5697 * frame.c (Fwindow_frame, Fframe_first_window)
5698 (Fframe_root_window, Fframe_selected_window)
5699 (Fset_frame_selected_window): Move to window.c.
5700 (Factive_minibuffer_window): Move to minibuf.c.
5701 (Fother_visible_frames_p): New function.
5703 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5705 * window.c (decode_window, decode_any_window): Move up in code.
5706 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5707 (inhibit_frame_unsplittable): Remove unused variable.
5708 (Fwindow_buffer): Move up and rewrite doc-string.
5709 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5710 (Fwindow_prev): New functions.
5711 (Fwindow_frame): Move here from frame.c. Accept any window as
5713 (Fframe_root_window, Fframe_first_window)
5714 (Fframe_selected_window): Move here from frame.c. Accept frame
5715 or arbitrary window as argument. Update doc-strings.
5716 (Fminibuffer_window): Move up in code.
5717 (Fwindow_minibuffer_p): Move up in code and simplify.
5718 (Fset_frame_selected_window): Move here from frame.c.
5720 (Fselected_window, select_window, Fselect_window): Move up in
5721 code. Minor doc-string fixes.
5723 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5725 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5726 Do not assume that spare memory exists; that assumption is valid
5727 only if SYSTEM_MALLOC.
5728 (LARGE_REQUEST): New macro, so that the issue of large requests
5729 is separated from the issue of spare memory.
5731 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5733 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5736 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5738 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5741 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5743 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5745 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5747 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5748 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5750 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5752 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5754 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5756 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5757 (x_clipboard_manager_save): Add return value.
5758 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5760 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5761 Obey Vx_select_enable_clipboard_manager. Catch errors in
5762 x_clipboard_manager_save (Bug#8779).
5763 (Vx_select_enable_clipboard_manager): New variable.
5764 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5766 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5768 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5770 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5772 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5773 in the current matrix if keep_current_p is non-zero.
5775 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5777 * bidi.c (bidi_level_of_next_char): Fix last change.
5779 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5781 Support bidi reordering of text covered by display properties.
5783 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5784 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5785 (bidi_cache_search, bidi_cache_iterator_state)
5786 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5787 (bidi_level_of_next_char, bidi_move_to_visually_next):
5788 Support character positions inside a run of characters covered by a
5790 (bidi_paragraph_init, bidi_resolve_explicit_1)
5791 (bidi_level_of_next_char): Call bidi_fetch_char and
5792 bidi_fetch_char_advance instead of FETCH_CHAR and
5794 (bidi_init_it): Initialize new members.
5795 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5797 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5798 instead of using explicit *_CHAR codes.
5799 (bidi_resolve_explicit, bidi_resolve_weak):
5800 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5801 bidirectional text is supported only in multibyte buffers.
5802 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5803 it to initialize the frame_window_p member of struct bidi_it.
5804 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5805 (bidi_resolve_explicit, bidi_resolve_weak)
5806 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5807 bidi_it->nchars is non-positive.
5808 (bidi_level_of_next_char): Don't try to lookup the cache for the
5809 next/previous character if nothing is cached there yet, or if we
5810 were just reseat()'ed to a new position.
5812 * xdisp.c (set_cursor_from_row): Set start and stop points
5813 according to the row's direction when priming the loop that looks
5814 for the glyph on which to display cursor.
5815 (single_display_spec_intangible_p): Function deleted.
5816 (display_prop_intangible_p): Reimplement to call
5817 handle_display_spec instead of single_display_spec_intangible_p.
5818 Accept 3 additional arguments needed by handle_display_spec.
5819 This fixes incorrect cursor motion across display property with complex
5820 values: lists, `(when COND...)' forms, etc.
5821 (single_display_spec_string_p): Support property values that are
5822 lists with the argument STRING its top-level element.
5823 (display_prop_string_p): Fix the condition for processing a
5824 property that is a list to be consistent with handle_display_spec.
5825 (handle_display_spec): New function, refactored from the
5826 last portion of handle_display_prop.
5827 (compute_display_string_pos): Accept additional argument
5828 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5829 value of a `display' property is a "replacing spec".
5830 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5831 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5832 the display property, but just return a value indicating whether
5833 the display property will replace the characters it covers.
5834 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5835 frame_window_p members of struct bidi_it.
5836 (compute_display_string_pos, compute_display_string_end):
5838 (push_it): Accept second argument POSITION, where pop_it should
5839 jump to continue iteration.
5840 (reseat_1): Initialize bidi_it.disp_pos.
5842 * keyboard.c (adjust_point_for_property): Adjust the call to
5843 display_prop_intangible_p to its new signature.
5845 * dispextern.h (struct bidi_it): New member frame_window_p.
5846 (bidi_init_it): Update prototypes.
5847 (display_prop_intangible_p): Update prototype.
5848 (compute_display_string_pos, compute_display_string_end):
5850 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5853 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5855 Malloc failure behavior now depends on size of allocation.
5856 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5857 * lisp.h: Change signatures accordingly.
5858 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5859 All callers changed. (Bug#8762)
5861 * gnutls.c: Use Emacs's memory allocators.
5862 Without this change, the gnutls library would invoke malloc etc.
5863 directly, which causes problems on non-SYNC_INPUT hosts, and which
5864 runs afoul of improving memory_full behavior. (Bug#8761)
5865 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5866 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5867 xfree instead of the default malloc, realloc, free.
5868 (Fgnutls_boot): No need to check for memory allocation failure,
5869 since xmalloc does that for us.
5871 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5872 * category.c (hash_get_category_set):
5873 * ccl.c (ccl_driver):
5874 * charset.c (Fdefine_charset_internal):
5875 * charset.h (struct charset.hash_index):
5876 * composite.c (get_composition_id, gstring_lookup_cache)
5877 (composition_gstring_put_cache):
5878 * composite.h (struct composition.hash_index):
5879 * dispextern.h (struct image.hash):
5880 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5881 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5882 (hashfn_equal, hashfn_user_defined, make_hash_table)
5883 (maybe_resize_hash_table, hash_lookup, hash_put)
5884 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5885 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5886 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5887 * image.c (make_image, search_image_cache, lookup_image)
5888 (xpm_put_color_table_h):
5889 * lisp.h (struct Lisp_Hash_Table):
5890 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5891 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5892 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5893 * alloc.c (allocate_vectorlike):
5894 Check for overflow in vector size calculations.
5895 * ccl.c (ccl_driver):
5896 Check for overflow when converting EMACS_INT to int.
5897 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5898 need to be updated by these changes.
5899 * fns.c (make_hash_table, maybe_resize_hash_table):
5900 Check for integer overflow with large hash tables.
5901 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5902 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5903 (SXHASH_REDUCE): New macro.
5904 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5905 Use it instead of discarding useful hash info with large hash values.
5906 (sxhash_float): New function.
5907 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5908 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5909 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5910 Rewrite to use FIXNUM_BITS, as this simplifies things.
5911 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5912 Adjust signatures to match updated version of code.
5913 (consing_since_gc): Now EMACS_INT, since a single hash table can
5914 use more than INT_MAX bytes.
5916 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5918 Make it possible to build with GCC-4.6+ -O2 -flto.
5920 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5922 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5924 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5925 Call minibuffer-inactive-mode.
5927 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5929 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5930 Update dependencies.
5932 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5934 * data.c (init_data): Remove code for UTS, this system is not
5937 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5939 Don't force ./temacs to start in terminal mode.
5941 * frame.c (make_initial_frame): Initialize faces in all cases, not
5942 only when CANNOT_DUMP is defined.
5943 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5945 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5947 * dispnew.c (add_window_display_history): Use const for the string
5948 pointer. Remove declaration, not needed.
5950 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5952 Use 'inline', not 'INLINE'.
5953 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5954 * alloc.c, fontset.c (INLINE): Remove.
5955 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5956 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5957 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5958 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5959 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5961 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5963 Make it possible to run ./temacs.
5965 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5966 syms_of_callproc does the same thing. Remove test for
5967 "initialized", do it in the caller.
5968 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5970 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5972 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5973 (read_minibuf): Use get_minibuffer.
5974 (syms_of_minibuf): Use DEFSYM.
5975 (Qmetadata): New var.
5976 * data.c (Qbuffer): Don't make it static.
5977 (syms_of_data): Use DEFSYM.
5979 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5981 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5982 (CCL_CODE_MIN): New macro.
5984 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5986 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5988 * eval.c (Qdebug): Now static.
5989 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5990 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5991 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5993 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5995 * image.c: Various fixes to ImageMagick code comments.
5996 (Fimagemagick_types): Doc fix.
5998 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6000 Minor fixes prompted by GCC 4.6.0 warnings.
6002 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6004 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6005 (x_clipboard_manager_save_all): Move extern decl to ...
6006 * xterm.h: ... here, so that it can be checked for consistency.
6008 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6010 * xselect.c (x_clipboard_manager_save_frame)
6011 (x_clipboard_manager_save_all): New functions.
6012 (Fx_clipboard_manager_save): Lisp function deleted.
6014 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6015 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6017 * xterm.h: Update prototype.
6019 2011-05-28 William Xu <william.xwl@gmail.com>
6021 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6024 2011-05-28 Jim Meyering <meyering@redhat.com>
6026 Avoid a sign-extension bug in crypto_hash_function.
6027 * fns.c (to_uchar): Define.
6028 (crypto_hash_function): Use it to convert some newly-signed
6029 variables to unsigned, to avoid sign-extension bugs. For example,
6030 without this change, (md5 "truc") would evaluate to
6031 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6032 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6033 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6035 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6037 Integer overflow fixes.
6039 * dbusbind.c: Serial number integer overflow fixes.
6040 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6041 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6042 to hold a serial number that is too large for a fixnum.
6043 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6044 Check for serial numbers out of range. Decode any serial number
6045 that was so large that it became a float. (Bug#8722)
6047 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6048 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6049 Use XFASTINT rather than XUINT when numbers are nonnegative.
6050 (xd_append_arg, Fdbus_method_return_internal):
6051 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6052 arguments, check that Lisp number is nonnegative, rather than
6053 silently wrapping negative numbers around. (Bug#8722)
6054 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6057 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6059 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6061 ccl: Add integer overflow checks.
6062 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6063 (IN_INT_RANGE): New macros.
6064 (ccl_driver): Use them to check for integer overflow when
6065 decoding a CCL program. Many of the new checks are whether XINT (x)
6066 fits in int; it doesn't always, on 64-bit hosts. The new version
6067 doesn't catch all possible integer overflows, but it's an
6068 improvement. (Bug#8719)
6070 * alloc.c (make_event_array): Use XINT, not XUINT.
6071 There's no need for unsigned here.
6073 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6074 This follows up to the 2011-05-06 change that substituted uintptr_t
6075 for EMACS_INT. This case wasn't caught back then.
6077 Rework Fformat to avoid integer overflow issues.
6078 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6079 now (part of C89). Include <verify.h>.
6080 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6081 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6082 (Fformat): Avoid the prepass trying to compute sizes; it was only
6083 approximate and thus did not catch overflow reliably. Instead, walk
6084 through the format just once, formatting and computing sizes as we go,
6085 checking for integer overflow at every step, and allocating a larger
6086 buffer as needed. Keep track separately whether the format is
6087 multibyte. Keep only the most-recently calculated precision, rather
6088 than them all. Record whether each argument has been converted to
6089 string. Use EMACS_INT, not int, for byte and char and arg counts.
6090 Support field widths and precisions larger than INT_MAX. Avoid
6091 sprintf's undefined behavior with conversion specifications such as %#d
6092 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6093 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6094 formatting out-of-range floating point numbers with int
6097 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6099 * data.c: Avoid integer truncation in expressions involving floats.
6100 * data.c: Include <intprops.h>.
6101 (arith_driver): When there's an integer overflow in an expression
6102 involving floating point, convert the integers to floating point
6103 so that the resulting value does not suffer from catastrophic
6104 integer truncation. For example, on a 64-bit host (* 4
6105 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6106 Do not rely on undefined behavior after integer overflow.
6108 merge count_size_as_multibyte, parse_str_to_multibyte
6109 * character.c, character.h (count_size_as_multibyte):
6110 Rename from parse_str_to_multibyte; all uses changed.
6111 Check for integer overflow.
6112 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6113 since it's now a duplicate of the other. This is more of
6114 a character than a buffer op, so better that it's in character.c.
6115 * fns.c, print.c: Adjust to above changes.
6117 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6119 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6121 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6123 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6124 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6125 (x_clipboard_manager_save): Now static.
6126 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6128 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6129 (crypto_hash_function): Now static.
6130 Fix pointer signedness problems. Avoid unnecessary initializations.
6132 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6134 * termhooks.h (Vselection_alist): Make it terminal-local.
6136 * terminal.c (create_terminal): Initialize it.
6138 * xselect.c: Support for clipboard managers.
6139 (Vselection_alist): Move to termhooks.h as terminal-local var.
6140 (LOCAL_SELECTION): New macro.
6141 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6142 (symbol_to_x_atom): Remove gratuitous arg.
6143 (x_handle_selection_request, lisp_data_to_selection_data)
6144 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6145 (x_own_selection, x_get_local_selection, x_convert_selection):
6146 New arg, specifying work frame. Use terminal-local Vselection_alist.
6147 (some_frame_on_display): Delete unused function.
6148 (Fx_own_selection_internal, Fx_get_selection_internal)
6149 (Fx_disown_selection_internal, Fx_selection_owner_p)
6150 (Fx_selection_exists_p): New optional frame arg.
6151 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6152 (x_handle_selection_clear): Don't treat other terminals with the
6153 same keyboard specially. Use the terminal-local Vselection_alist.
6154 (x_clear_frame_selections): Use Frun_hook_with_args.
6156 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6158 * xterm.h: Add support for those atoms.
6160 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6162 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6163 (converted_selections, conversion_fail_tag): New global variables.
6164 (x_selection_request_lisp_error): Free the above.
6165 (x_get_local_selection): Remove unnecessary code.
6166 (x_reply_selection_request): Args changed; handle arbitrary array
6167 of converted selections stored in converted_selections.
6168 Separate the XChangeProperty and SelectionNotify steps.
6169 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6170 (x_convert_selection): New function.
6171 (x_handle_selection_event): Simplify.
6172 (x_get_foreign_selection): Don't ignore incoming requests while
6173 waiting for an answer; this will fail when we implement
6174 SAVE_TARGETS, and seems unnecessary anyway.
6175 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6176 (Vx_sent_selection_functions): Doc fix.
6178 2011-05-26 Leo Liu <sdl.web@gmail.com>
6180 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6182 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6184 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6186 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6187 for fringe update if it has periodic bitmap.
6188 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6189 and fringe_bitmap_periodic_p.
6191 * fringe.c (get_fringe_bitmap_data): New function.
6192 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6193 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6194 row. Mark glyph row for fringe update if periodicity changed.
6196 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6197 for fringe update unless it has periodic bitmap.
6199 2011-05-25 Kenichi Handa <handa@m17n.org>
6201 * xdisp.c (get_next_display_element): Set correct it->face_id for
6202 a static composition.
6204 2011-05-24 Leo Liu <sdl.web@gmail.com>
6207 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6209 * fns.c (crypto_hash_function, Fsha1): New function.
6210 (Fmd5): Use crypto_hash_function.
6211 (syms_of_fns): Add Ssha1.
6213 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6215 * gnutls.c: Remove unused macros.
6216 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6217 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6218 Remove macros that are defined and never used.
6219 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6221 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6223 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6224 (Fx_get_selection_internal): Minor cleanup.
6225 (Fx_own_selection_internal): Rename arguments for consistency with
6228 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6230 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6232 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6234 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6236 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6238 * dispnew.c (scrolling_window): Don't exclude the case that the
6239 last enabled row in the desired matrix touches the bottom boundary.
6241 2011-05-21 Glenn Morris <rgm@gnu.org>
6243 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6244 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6245 and add some more files.
6247 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6249 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6250 report_file_error introduced by the change from 2011-05-07.
6252 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6254 * systime.h (Time): Define only if emacs is defined.
6255 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6256 where the include path doesn't have X11/X.h by default. See
6257 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6259 2011-05-20 Kenichi Handa <handa@m17n.org>
6261 * composite.c (find_automatic_composition): Fix previous change.
6263 2011-05-20 Glenn Morris <rgm@gnu.org>
6265 * lisp.mk: New file, split from Makefile.in.
6266 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6267 (shortlisp): Remove.
6268 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6270 2011-05-19 Glenn Morris <rgm@gnu.org>
6272 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6273 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6274 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6275 (lisp): Set the order to that of loadup.el.
6276 (shortlisp): Make it a copy of $lisp.
6277 (SOME_MACHINE_LISP): Remove.
6278 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6279 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6281 2011-05-18 Kenichi Handa <handa@m17n.org>
6283 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6284 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6285 (find_automatic_composition): Mostly rewrite for efficiency.
6287 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6289 * makefile.w32-in: Update dependencies.
6291 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6293 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6294 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6296 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6298 Fix some integer overflow issues, such as string length overflow.
6300 * insdel.c (count_size_as_multibyte): Check for string overflow.
6302 * character.c (lisp_string_width): Check for string overflow.
6303 Use EMACS_INT, not int, for string indexes and lengths; in
6304 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6305 the resulting string length overflows an EMACS_INT; instead,
6306 report a string overflow if no precision given. When checking for
6307 precision exhaustion, use a check that cannot possibly have
6308 integer overflow. (Bug#8675)
6309 * character.h (lisp_string_width): Adjust to new signature.
6311 * alloc.c (string_overflow): New function.
6312 (Fmake_string): Use it. This doesn't change behavior, but saves
6313 a few bytes and will simplify future changes.
6314 * character.c (string_escape_byte8): Likewise.
6315 * lisp.h (string_overflow): New decl.
6317 Fixups, following up to the user-interface timestamp change.
6318 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6319 for UI timestamps, instead of unsigned long.
6320 * msdos.c (mouse_get_pos): Likewise.
6321 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6322 * w32gui.h (Time): Define by including "systime.h" rather than by
6323 declaring it ourselves. (Bug#8664)
6325 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6326 * image.c (clear_image_cache): Likewise.
6328 * term.c (term_mouse_position): Don't assume time_t wraparound.
6330 Be more systematic about user-interface timestamps.
6331 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6332 and sometimes 'EMACS_UINT', to represent these timestamps.
6333 This change causes it to use 'Time' uniformly, as that's what X uses.
6334 This makes the code easier to follow, and makes it easier to catch
6335 integer overflow bugs such as Bug#8664.
6336 * frame.c (Fmouse_position, Fmouse_pixel_position):
6337 Use Time, not unsigned long, for user-interface timestamps.
6338 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6339 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6340 * keyboard.h (last_event_timestamp): Likewise.
6341 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6342 * menu.h (xmenu_show): Likewise.
6343 * term.c (term_mouse_position): Likewise.
6344 * termhooks.h (struct input_event.timestamp): Likewise.
6345 (struct terminal.mouse_position_hook): Likewise.
6346 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6347 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6348 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6349 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6351 * menu.h, termhooks.h: Include "systime.h", for Time.
6353 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6354 Don't assume that the difference between two unsigned long values
6355 can fit into an integer. At this point, we know button_down_time
6356 <= event->timestamp, so the difference must be nonnegative, so
6357 there's no need to cast the result if double-click-time is
6358 nonnegative, as it should be; check that it's nonnegative, just in
6359 case. This bug is triggered when events are more than 2**31 ms
6360 apart (about 25 days). (Bug#8664)
6362 * xselect.c (last_event_timestamp): Remove duplicate decl.
6363 (x_own_selection): Remove needless cast to unsigned long.
6365 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6366 that always fit in int. Use a sentinel instead of a counter, to
6367 avoid a temp and to allay GCC's concerns about possible int overflow.
6368 * frame.h (struct frame): Use int for menu_bar_items_used
6369 instead of EMACS_INT, since it always fits in int.
6371 * menu.c (grow_menu_items): Check for int overflow.
6373 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6375 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6376 Before, the code was not consistent. These values cannot exceed
6377 2**31 - 1 so there's no need to make them unsigned.
6378 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6379 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6380 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6382 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6384 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6385 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6386 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6387 presumably because the widths might not match.
6389 * window.c (size_window): Avoid needless test at loop start.
6391 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6393 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6395 2011-05-12 Drew Adams <drew.adams@oracle.com>
6397 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6399 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6401 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6402 `width' to `bar_area_x' and `bar_area_width', respectively.
6403 (x_scroll_run): Take account of fringe background extension.
6405 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6406 Rename local vars `left' and `width' to `bar_area_x' and
6407 `bar_area_width', respectively.
6408 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6409 background extension.
6411 2011-05-10 Jim Meyering <meyering@redhat.com>
6413 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6415 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6417 * image.c (Finit_image_library): Return t for built-in image types,
6418 like pbm and xbm. (Bug#8640)
6420 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6422 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6424 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6426 * w32console.c (Fset_screen_color): Doc fix.
6427 (Fget_screen_color): New function.
6428 (syms_of_ntterm): Defsubr it.
6430 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6431 unlink the temporary file if Fcall_process didn't create it in the
6433 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6434 child process will be redirected to a file specified with `:file'.
6435 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6436 cue to call_process_cleanup not to close that handle.
6438 2011-05-07 Ben Key <bkey76@gmail.com>
6440 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6441 one of two shell specific rules, either bootstrap-temacs-CMD or
6442 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6443 to the previous implementation of the bootstrap-temacs rule.
6444 The bootstrap-temacs-CMD rule is similar to the previous
6445 implementation of the bootstrap-temacs rule except that it
6446 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6449 These changes, along with some changes to nt/configure.bat,
6450 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6451 earlier fix to add support for --cflags and --ldflags options
6452 that include quotes so that it works whether make uses cmd or
6455 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6457 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6458 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6460 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6461 a string. Handle both cases.
6462 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6463 (Fdbus_register_method): Use Qinvalid_function.
6465 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6467 * makefile.w32-in: Update dependencies.
6468 (LISP_H): Add inttypes.h and stdin.h.
6469 (PROCESS_H): Add unistd.h.
6471 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6473 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6474 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6476 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6478 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6480 * term.c (vfatal): Remove stray call to va_end.
6481 It's not needed and the C Standard doesn't allow it here anyway.
6483 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6484 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6486 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6489 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6491 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6493 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6495 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6497 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6499 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6500 * charset.c (Fdefine_charset_internal): Don't initialize
6501 charset.code_space[15]. The value was garbage, on hosts with
6502 32-bit int (Bug#8600).
6504 * lread.c (read_integer): Be more consistent with string-to-number.
6505 Use string_to_number to do the actual conversion; this avoids
6506 rounding errors and fixes some other screwups. Without this fix,
6507 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6508 (digit_to_number): Move earlier, for benefit of read_integer.
6509 Return -1 if the digit is out of range for the base, -2 if it is
6510 not a digit in any supported base. (Bug#8602)
6512 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6514 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6515 to match comment at start of function. This also removes a
6516 GCC warning about overflow in a 32+64-bit port.
6518 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6520 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6521 Reported by Stefan Monnier in
6522 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6523 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6524 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6526 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6527 (EMACS_UINTPTR): Likewise, with uintptr_t.
6529 * lisp.h: Prefer 64-bit EMACS_INT if available.
6530 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6531 on 32-bit hosts that have 64-bit int, so that they can access
6533 However, temporarily disable this change unless the temporary
6534 symbol WIDE_EMACS_INT is defined.
6536 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6538 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6539 This removes an assumption that EMACS_INT and long are the same
6540 width as pointers. The assumption is true for Emacs porting targets
6541 now, but we want to make other targets possible.
6542 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6543 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6544 In the rest of the code, change types of integers that hold casted
6545 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6546 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6547 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6548 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6549 No need to cast type when ORing.
6550 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6551 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6552 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6553 assume EMACS_INT is the same width as char *.
6554 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6555 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6556 Remove no-longer-needed casts.
6557 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6558 (xg_tool_bar_help_callback, xg_make_tool_item):
6559 Use EMACS_INTPTR to hold an integer
6560 that will be cast to void *; this can avoid a GCC warning
6561 if EMACS_INT is not the same width as void *.
6562 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6563 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6564 (current_message_1, set_message_1):
6565 Use a local to convert to proper width without a cast.
6566 * xmenu.c (dialog_selection_callback): Likewise.
6568 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6569 Also, don't assume VALBITS / RAND_BITS is less than 5,
6570 and don't rely on undefined behavior when shifting a 1 left into
6572 * lisp.h (get_random): Change signature to match.
6574 * lread.c (hash_string): Use size_t, not int, for hash computation.
6575 Normally we prefer signed values; but hashing is special, because
6576 it's better to use unsigned division on hash table sizes so that
6577 the remainder is nonnegative. Also, size_t is the natural width
6578 for hashing into memory. The previous code used 'int', which doesn't
6579 retain enough info to hash well into very large tables.
6580 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6582 * dbusbind.c: Don't possibly lose pointer info when converting.
6583 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6584 Use XPNTR rather than XHASH, so that the high-order bits of
6585 the pointer aren't lost when converting through void *.
6587 * eval.c (Fautoload): Don't double-shift a pointer.
6589 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6591 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6593 * gnutls.c (DEF_GNUTLS_FN):
6594 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6596 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6598 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6601 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6603 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6604 New version that can reserve upto 2GB of heap space.
6606 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6608 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6610 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6612 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6613 `gnutls_certificate_set_x509_key_file'.
6615 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6617 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6618 Update dependencies.
6620 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6622 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6623 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6624 Remove unused parameter `fildes'.
6625 * process.c (read_process_output, send_process): Don't pass it.
6627 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6629 Fix previous change: the library cache is defined in w32.c.
6630 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6631 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6633 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6635 Implement dynamic loading of GnuTLS on Windows.
6637 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6638 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6639 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6642 * gnutls.c (Qgnutls_dll): Define.
6643 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6644 (gnutls_*): Declare function pointers.
6645 (init_gnutls_functions): New function to initialize function pointers.
6646 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6647 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6648 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6649 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6650 (emacs_gnutls_write, emacs_gnutls_read)
6651 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6652 (Fgnutls_available_p): New function.
6653 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6654 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6655 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6657 * image.c: Include w32.h.
6658 (Vimage_type_cache): Delete.
6659 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6660 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6661 (w32_delayed_load): Move to w32.c.
6663 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6665 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6666 (w32_delayed_load): Move from image.c. When loading a library, record
6667 its filename in the :loaded-from property of the library id.
6668 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6669 Initialize and staticpro them.
6670 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6672 * process.c: Include lisp.h before w32.h, not after.
6673 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6674 instead of gnutls_record_check_pending.
6676 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6678 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6680 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6681 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6684 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6686 * xterm.c (x_set_frame_alpha): Do not set property on anything
6687 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6689 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6691 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6693 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6695 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6696 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6697 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6698 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6699 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6700 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6701 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6702 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6703 (Qgnutls_bootprop_callbacks_verify): Make static.
6705 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6707 * callproc.c: Indentation fixup.
6709 * sysdep.c (wait_for_termination_1): Make static.
6710 (wait_for_termination, interruptible_wait_for_termination):
6711 Move after wait_for_termination_1.
6713 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6715 * sysdep.c (interruptible_wait_for_termination): New function
6716 which is like wait_for_termination, but allows keyboard
6719 * callproc.c (Fcall_process): Add (:file "file") as an option for
6721 (Fcall_process_region): Ditto.
6723 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6725 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6726 rather than `XVECTOR (FOO)->size'.
6728 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6729 inttypes.h, as a gnulib replacement is used if it not available in
6732 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6734 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6735 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6736 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6738 * coding.c (coding_alloc_by_realloc): Error out if destination
6739 will grow beyond MOST_POSITIVE_FIXNUM.
6740 (decode_coding_emacs_mule): Abort if there isn't enough place in
6741 charbuf for the composition carryover bytes. Reserve an extra
6742 space for up to 2 characters produced in a loop.
6743 (decode_coding_iso_2022): Abort if there isn't enough place in
6744 charbuf for the composition carryover bytes.
6746 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6748 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6749 aborting when %lld or %lll format is passed.
6750 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6751 %llo or %llx format is passed. (Bug#8545)
6753 * window.c (window_scroll_line_based): Use a marker instead of
6754 simple variables to record original value of point. (Bug#7952)
6756 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6757 produced by %s or %c overflows available buffer space. (Bug#8545)
6759 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6761 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6762 (SIZE_MAX): Move defn after all includes, as they might #define it.
6764 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6766 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6768 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6770 * keyboard.c (Qdelayed_warnings_hook): Define.
6771 (command_loop_1): Run `delayed-warnings-hook'
6772 if Vdelayed_warnings_list is non-nil.
6773 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6774 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6776 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6778 * doprnt.c (doprnt): Don't return value smaller than the buffer
6779 size if the message was truncated. (Bug#8545).
6781 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6783 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6784 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6786 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6788 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6790 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6792 * makefile.w32-in: Update dependencies.
6794 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6796 Improve `doprnt' and its usage. (Bug#8545)
6797 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6798 `format_end'. Remove support for %l as a conversion specifier.
6799 Don't use xrealloc. Improve diagnostics when the %l size modifier
6800 is used. Update the commentary.
6802 * eval.c (verror): Simplify calculation of size_t.
6804 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6807 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6809 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6812 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6814 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6815 This makes this file independent of the recent pseudovector change.
6817 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6819 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6821 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6822 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6823 Remove unused local.
6824 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6826 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6827 GCC 4.6.0 optimizes based on type-based alias analysis.
6828 For example, if b is of type struct buffer * and v of type struct
6829 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6830 != &v->size, and therefore "v->size = 1; b->size = 2; return
6831 v->size;" must therefore return 1. This assumption is incorrect
6832 for Emacs, since it type-puns struct Lisp_Vector * with many other
6833 types. To fix this problem, this patch adds a new type struct
6834 vectorlike_header that documents the constraints on layout of vectors
6835 and pseudovectors, and helps optimizing compilers not get fooled
6836 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6837 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6838 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6840 (XSETPVECTYPE): Rewrite in terms of new macro.
6841 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6842 This is a bit clearer, and further avoids the possibility of
6843 undesirable aliasing.
6844 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6845 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6846 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6847 since Lisp_Subr is a special case (no "next" field).
6848 (ASIZE): Now uses header.size rather than size.
6849 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6850 to avoid the hassle of writing XVECTOR (foo)->header.size.
6851 (struct vectorlike_header): New type.
6852 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6853 object, to help avoid aliasing.
6854 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6855 (SUBRP): Likewise, since Lisp_Subr is a special case.
6856 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6857 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6858 (struct Lisp_Hash_Table): Combine first two members into a single
6859 struct vectorlike_header member. All uses of "size" and "next" members
6860 changed to be "header.size" and "header.next".
6861 * buffer.h (struct buffer): Likewise.
6862 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6863 * frame.h (struct frame): Likewise.
6864 * process.h (struct Lisp_Process): Likewise.
6865 * termhooks.h (struct terminal): Likewise.
6866 * window.c (struct save_window_data, struct saved_window): Likewise.
6867 * window.h (struct window): Likewise.
6868 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6869 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6870 * buffer.c (init_buffer_once): Likewise.
6871 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6873 * process.c (Fformat_network_address): Use local var for size,
6876 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6878 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6879 * data.c (atof): Remove decl; no longer used or needed.
6880 (digit_to_number): Move to lread.c.
6881 (Fstring_to_number): Use new string_to_number function, to be
6882 consistent with how the Lisp reader treats infinities and NaNs.
6883 Do not assume that floating-point numbers represent EMACS_INT
6884 without losing information; this is not true on most 64-bit hosts.
6885 Avoid double-rounding errors, by insisting on integers when
6886 parsing non-base-10 numbers, as the documentation specifies.
6887 * lisp.h (string_to_number): New decl, replacing ...
6888 (isfloat_string): Remove.
6889 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6890 (read1): Do not accept +. and -. as integers; this
6891 appears to have been a coding error. Similarly, do not accept
6892 strings like +-1e0 as floating point numbers. Do not report
6893 overflow for integer overflows unless the base is not 10 which
6894 means we have no simple and reliable way to continue.
6895 Break out the floating-point parsing into a new
6896 function string_to_number, so that Fstring_to_number parses
6897 floating point numbers consistently with the Lisp reader.
6898 (digit_to_number): Move here from data.c. Make it static inline.
6899 (E_CHAR, EXP_INT): Remove, replacing with ...
6900 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6901 (string_to_number): New function, replacing isfloat_string.
6902 This function checks for valid syntax and produces the resulting
6903 Lisp float number too. Rework it so that string-to-number
6904 no longer mishandles examples like "1.0e+". Use strtoumax,
6905 so that overflow for non-base-10 numbers is reported only when
6906 there's no portable and simple way to convert to floating point.
6908 * textprop.c (set_text_properties_1): Rewrite for clarity,
6909 and to avoid GCC warning about integer overflow.
6911 * intervals.h (struct interval): Use EMACS_INT for members
6912 where EMACS_UINT might cause problems. See
6913 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6914 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6915 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6917 (offset_intervals): Tell GCC not to worry about length overflow
6918 when negating a negative length.
6920 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6921 (overrun_check_free): Likewise.
6923 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6924 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6927 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6928 (gnutls_make_error): Rename local to avoid shadowing.
6929 (gnutls_emacs_global_deinit): ifdef out; not used.
6930 (Fgnutls_boot): Use const for pointer to readonly storage.
6931 Comment out unused local. Fix pointer signedness problems.
6933 * lread.c (openp): Don't stuff size_t into an 'int'.
6934 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6935 about possible signed overflow.
6937 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6938 (GDK_KEY_g): Don't define if already defined.
6939 (xg_prepare_tooltip): Avoid pointer signedness problem.
6940 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6942 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6943 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6945 * xfns.c (Fx_window_property): Simplify a bit,
6946 to make a bit faster and to avoid GCC 4.6.0 warning.
6947 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6949 * fns.c (internal_equal): Don't assume size_t fits in int.
6951 * alloc.c (compact_small_strings): Tighten assertion a little.
6953 Replace pEd with more-general pI, and fix some printf arg casts.
6954 * lisp.h (pI): New macro, generalizing old pEd macro to other
6955 conversion specifiers. For example, use "...%"pI"d..." rather
6956 than "...%"pEd"...".
6957 (pEd): Remove. All uses replaced with similar uses of pI.
6958 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
6959 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6960 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6961 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6962 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6963 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6964 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6966 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6967 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6968 * print.c (safe_debug_print, print_object): Likewise.
6969 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6971 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6972 avoiding the 0 flag, which is not portable.
6973 * process.c (Fmake_network_process): Use pI to avoid cast.
6974 * region-cache.c (pp_cache): Likewise.
6975 * xdisp.c (decode_mode_spec): Likewise.
6976 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6977 behavior on 64-bit hosts with printf arg.
6978 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6979 (x_stop_queuing_selection_requests): Likewise.
6980 (x_get_window_property): Don't truncate byte count to an 'int'
6983 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6984 here, since it parses constructs like leading '-' and spaces,
6985 which are not wanted; and it overflows with large numbers.
6986 Instead, simply match F[0-9]+, which is what is wanted anyway.
6988 * alloc.c: Remove unportable assumptions about struct layout.
6989 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6990 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6991 (allocate_vectorlike, make_pure_vector): Use the new macros,
6992 plus offsetof, to remove unportable assumptions about struct layout.
6993 These assumptions hold on all porting targets that I know of, but
6994 they are not guaranteed, they're easy to remove, and removing them
6995 makes further changes easier.
6997 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6998 This doesn't fix a bug but makes the code clearer.
6999 (string_overrun_cookie): Now const. Use initializers that
7000 don't formally overflow signed char, to avoid warnings.
7001 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7002 can cause Emacs to crash when string overrun checking is enabled.
7003 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7004 multiple of sizeof (EMACS_INT); it need not be, if
7005 alignof(EMACS_INT) < sizeof (EMACS_INT).
7006 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7008 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7010 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7012 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7014 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7015 supposed to be handshaking. (Bug#8556)
7016 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7018 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7020 * lisp.h (Qdebug): List symbol.
7021 * eval.c (Qdebug): Restore global linkage.
7022 * keyboard.c (debug-on-event): New variable.
7023 (handle_user_signal): Break into debugger when debug-on-event
7024 matches the current signal symbol.
7026 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7028 * alloc.c (check_sblock, check_string_bytes)
7029 (check_string_free_list): Convert to standard C.
7031 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7033 * w32.c (emacs_gnutls_push): Fix typo.
7035 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7037 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7038 "cast to pointer from integer of different size".
7040 Improve doprnt and its use in verror. (Bug#8545)
7041 * doprnt.c (doprnt): Document the set of format control sequences
7042 supported by the function. Use SAFE_ALLOCA instead of always
7045 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7046 is one byte too soon. Don't use xrealloc; instead xfree and
7049 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7051 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7054 * gnutls.c: Renamed global_initialized to
7055 gnutls_global_initialized. Added internals for the
7056 :verify-hostname-error, :verify-error, and :verify-flags
7057 parameters of `gnutls-boot' and documented those parameters in the
7058 docstring. Start callback support.
7059 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7060 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7061 on error. Return error code.
7062 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7063 (emacs_gnutls_read): Likewise.
7064 (Fgnutls_boot): Return handshake error code.
7065 (emacs_gnutls_handle_error): New function.
7066 (wsaerror_to_errno): Likewise.
7068 * w32.h (emacs_gnutls_pull): Add prototype.
7069 (emacs_gnutls_push): Likewise.
7071 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7072 (emacs_gnutls_push): Likewise.
7074 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7076 * process.c (wait_reading_process_output): Check if GnuTLS
7077 buffered some data internally if no FDs are set for TLS
7080 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7081 (LIBS): Link to USER_LIBS.
7082 ($(BLD)/gnutls.$(0)): New target.
7084 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7086 * xdisp.c (handle_single_display_spec): Rename the
7087 display_replaced_before_p argument into display_replaced_p, to
7088 make it consistent with the commentary. Fix typos in the
7091 * textprop.c (syms_of_textprop): Remove dead code.
7092 (copy_text_properties): Delete obsolete commentary about an
7093 interface that was deleted long ago. Fix typos in the description
7096 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7097 to changes in oldXMenu/XMenu.h from 2011-04-16.
7098 <menu_help_message, prev_menu_help_message>: Constify.
7099 (IT_menu_make_room): menu->help_text is now `const char **';
7102 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7103 to changes in oldXMenu/XMenu.h from 2011-04-16.
7104 (struct XMenu): Declare `help_text' `const char **'.
7106 * xfaces.c <Qunspecified>: Make extern again.
7108 * syntax.c: Include sys/types.h before including regex.h, as
7111 * doc.c (get_doc_string): Improve the format passed to `error'.
7113 * doprnt.c (doprnt): Improve commentary.
7115 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7117 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7120 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7121 changes in globals.h immediately force recompilation.
7122 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7123 $(CURDIR)/s/ms-w32.h.
7124 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7126 * character.c (Fchar_direction): Function deleted.
7127 (syms_of_character): Don't defsubr it.
7128 <char-direction-table>: Deleted.
7130 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7132 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7133 * doprnt.c: Include limits.h.
7134 (SIZE_MAX): New macro.
7135 (doprnt): Return a size_t value. 2nd arg is now size_t.
7136 Many local variables are now size_t instead of int or unsigned.
7137 Improve overflow protection. Support `l' modifier for integer
7138 conversions. Support %l conversion. Don't assume an EMACS_INT
7139 argument for integer conversions and for %c.
7141 * lisp.h (doprnt): Restore prototype.
7143 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7146 * Makefile.in (base_obj): Add back doprnt.o.
7148 * deps.mk (doprnt.o): Add back prerequisites.
7149 (callint.o): Depend on character.h.
7151 * eval.c (internal_lisp_condition_case): Include the handler
7152 representation in the error message.
7153 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7154 when breaking from the loop.
7156 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7158 * callint.c (Fcall_interactively): When displaying error message
7159 about invalid control letter, pass the character's codepoint, not
7160 a pointer to its multibyte form. Improve display of the character
7161 in octal and display also its hex code.
7163 * character.c (char_string): Use %x to display the (unsigned)
7164 codepoint of an invalid character, to avoid displaying a bogus
7167 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7168 `error', not SYMBOL_NAME itself.
7170 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7171 character arguments to `error'.
7173 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7174 to `error' in error message about FINAL_CHAR argument. Make sure
7175 FINAL_CHAR is a character, and use %c when it is passed as
7176 argument to `error'.
7178 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7180 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7182 * w32.c: Include <time.h>.
7183 (sys_localtime): New function.
7185 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7187 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7189 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7191 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7193 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7196 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7198 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7199 gl_state.e_property when gl_state.object is Qt.
7201 * insdel.c (make_gap_larger): Remove limitation of buffer size
7204 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7206 * xdisp.c (lookup_glyphless_char_display)
7207 (produce_glyphless_glyph): Handle cons cell entry in
7208 glyphless-char-display.
7209 (Vglyphless_char_display): Document it.
7211 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7212 glyphless-char-display.
7214 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7216 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7218 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7220 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7221 definition for no-X builds.
7223 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7225 Static checks with GCC 4.6.0 and non-default toolkits.
7227 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7229 * process.c (keyboard_bit_set): Define only if SIGIO.
7230 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7231 (send_process): Repair possible setjmp clobbering.
7233 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7235 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7237 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7239 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7240 Define only if needed.
7242 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7243 by pacifying GCC about it. Maybe it's time to retire it?
7244 * xfaces.c (USG, __TIMEVAL__): Likewise.
7246 * dispextern.h (struct redisplay_interface): Rename param
7248 * termhooks.h (struct terminal): Likewise.
7249 * xterm.c (xembed_send_message): Likewise.
7251 * insdel.c (make_gap_smaller): Define only if
7252 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7254 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7257 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7258 so that we aren't warned about unused symbols.
7260 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7262 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7264 * xfns.c (x_real_positions): Mark locals as initialized.
7266 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7268 * xterm.c: Fix problems found by static analysis with other toolkits.
7269 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7270 (x_dispatch_event): Declare static if USE_GTK, and
7271 define if USE_GTK || USE_X_TOOLKIT.
7272 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7273 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7274 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7275 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7277 * xmenu.c (menu_help_callback): Pointer type fixes.
7278 Use const pointers when pointing at readonly data. Avoid pointer
7280 (FALSE): Remove unused macro.
7281 (update_frame_menubar): Remove unused decl.
7283 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7285 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7286 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7287 (single_menu_item): Rename local to avoid shadowing.
7289 * keyboard.c (make_lispy_event): Remove unused local var.
7291 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7292 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7294 * bitmaps: Change bitmaps from unsigned char back to the X11
7295 compatible char. Avoid the old compiler warnings about
7296 out-of-range initializers by using, for example, '\xab' rather
7299 * xgselect.c (xgselect_initialize): Check vs interface
7300 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7302 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7304 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7305 to read-only memory.
7307 * fns.c (vector): Remove; this old hack is no longer needed.
7309 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7311 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7313 * xrdb.c (x_load_resources): Omit unused local.
7315 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7316 (x_window): Rename locals to avoid shadowing.
7317 (USG): Use the kludged USG macro, to pacify gcc.
7319 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7320 (x_term_init): Remove local to avoid shadowing.
7322 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7324 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7325 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7327 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7329 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7331 Fix regex.c, syntax.c and friends for buffers > 2GB.
7332 * syntax.h (struct gl_state_s): Declare character position members
7335 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7337 * textprop.c (verify_interval_modification, interval_of):
7338 Declare arguments EMACS_INT.
7340 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7343 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7345 * indent.c (Fvertical_motion): Local variable it_start is now
7348 * regex.c (re_match, re_match_2, re_match_2_internal)
7349 (bcmp_translate, regcomp, regexec, print_double_string)
7350 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7351 (re_compile_pattern, re_exec): Declare arguments and local
7352 variables `size_t' and `ssize_t' and return values `regoff_t', as
7354 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7355 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7356 <compile_stack_type>: `size' and `avail' are now `size_t'.
7358 * regex.h <regoff_t>: Use ssize_t, not int.
7359 (re_search, re_search_2, re_match, re_match_2): Arguments that
7360 specify buffer/string position and length are now ssize_t and
7361 size_t. Return type is regoff_t.
7363 2011-04-16 Ben Key <bkey76@gmail.com>
7365 * nsfont.m: Fixed bugs in ns_get_family and
7366 ns_descriptor_to_entity that were caused by using free to
7367 deallocate memory blocks that were allocated by xmalloc (via
7368 xstrdup). This caused Emacs to crash when compiled with
7369 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7370 --enable-checking=xmallocoverrun). xfree is now used to
7371 deallocate these memory blocks.
7373 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7375 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7377 emacs_write: Accept and return EMACS_INT for sizes.
7378 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7380 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7381 Accept and return EMACS_INT.
7382 (emacs_gnutls_write): Return the number of bytes written on
7384 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7385 (emacs_read, emacs_write): Remove check for negative size, as the
7386 Emacs source code has been audited now.
7387 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7388 (emacs_read, emacs_write): Use it.
7389 * process.c (send_process): Adjust to the new signatures of
7390 emacs_write and emacs_gnutls_write. Do not attempt to store
7391 a byte offset into an 'int'; it might overflow.
7392 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7394 * sound.c: Don't assume sizes fit in 'int'.
7395 (struct sound_device.period_size, alsa_period_size):
7396 Return EMACS_INT, not int.
7397 (struct sound_device.write, vox_write, alsa_write):
7398 Accept EMACS_INT, not int.
7399 (wav_play, au_play): Use EMACS_INT to store sizes and to
7400 record read return values.
7402 2011-04-15 Ben Key <bkey76@gmail.com>
7404 * keyboard.c (Qundefined): Don't declare static since it is used
7406 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7407 static since they are used in nsfont.m.
7409 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7411 * process.c (Qprocessp): Don't declare static.
7412 * lisp.h (Qprocessp): Declare again.
7414 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7416 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7418 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7420 Improve C-level modularity by making more things 'static'.
7422 Don't publish debugger-only interfaces to other modules.
7423 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7424 (verify_bytepos, count_markers): Move decls to the only modules
7426 * region-cache.h (pp_cache): Likewise.
7427 * window.h (check_all_windows): Likewise.
7428 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7430 * sysdep.c (croak): Now static, if
7431 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7432 * syssignal.h (croak): Declare only if not static.
7434 * alloc.c (refill_memory_reserve): Now static if
7435 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7436 * lisp.h (refill_memory_reserve): Declare only if not static.
7438 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7439 Define only if USE_LUCID.
7441 * xrdb.c (x_customization_string, x_rm_string): Now static.
7443 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7444 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7446 * xdisp.c (draw_row_with_mouse_face): Now static.
7447 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7449 * window.h (check_all_windows): Mark externally visible.
7451 * window.c (window_deletion_count): Now static.
7453 * undo.c: Make symbols static if they're not exported.
7454 (last_undo_buffer, last_boundary_position, pending_boundary):
7457 * textprop.c (interval_insert_behind_hooks): Now static.
7458 (interval_insert_in_front_hooks): Likewise.
7460 * term.c: Make symbols static if they're not exported.
7461 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7462 (max_frame_lines, tty_set_terminal_modes):
7463 (tty_reset_terminal_modes, tty_turn_off_highlight):
7464 (get_tty_terminal): Now static.
7465 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7466 * termhooks.h (term_mouse_moveto): Do not declare if
7468 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7469 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7471 * sysdep.c: Make symbols static if they're not exported.
7472 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7474 (sigprocmask_set, full_mask): Remove; unused.
7475 (wait_debugging): Mark as visible.
7476 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7477 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7479 * syntax.c (syntax_temp): Define only if !__GNUC__.
7481 * sound.c (current_sound_device, current_sound): Now static.
7483 * search.c (searchbufs, searchbuf_head): Now static.
7485 * scroll.c (scroll_cost): Remove; unused.
7486 * dispextern.h (scroll_cost): Remove decl.
7488 * region-cache.h (pp_cache): Mark as externally visible.
7490 * process.c: Make symbols static if they're not exported.
7491 (process_tick, update_tick, create_process, chan_process):
7492 (Vprocess_alist, proc_buffered_char, datagram_access):
7493 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7494 (deactivate_process): Mark defn as static, as well as decl.
7495 * lisp.h (create_process): Remove decl.
7496 * process.h (chan_process, Vprocess_alist): Remove decls.
7498 * print.c: Make symbols static if they're not exported.
7499 (print_depth, new_backquote_output, being_printed, print_buffer):
7500 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7501 (print_interval, print_number_index, initial_stderr_stream):
7503 * lisp.h (Fprinc): Remove decl.
7504 (debug_output_compilation_hack): Mark as externally visible.
7506 * sysdep.c (croak): Move decl from here to syssignal.h.
7507 * syssignal.h (croak): Put it here, so the API can be checked when
7508 'croak' is called from dissociate_if_controlling_tty.
7510 * minibuf.c: Make symbols static if they're not exported.
7511 (minibuf_save_list, choose_minibuf_frame): Now static.
7512 * lisp.h (choose_minibuf_frame): Remove decl.
7514 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7516 * lread.c: Make symbols static if they're not exported.
7517 (read_objects, initial_obarray, oblookup_last_bucket_number):
7519 (make_symbol): Remove; unused.
7520 * lisp.h (initial_obarray, make_symbol): Remove decls.
7522 * keyboard.c: Make symbols static if they're not exported.
7523 (single_kboard, recent_keys_index, total_keys, recent_keys):
7524 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7525 (this_single_command_key_start, echoing, last_auto_save):
7526 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7527 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7528 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7529 (Vlispy_mouse_stem, double_click_count):
7531 (force_auto_save_soon): Define only if SIGDANGER.
7532 (ignore_mouse_drag_p): Now static if
7533 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7534 (print_help): Remove; unused.
7535 (stop_character, last_timer_event): Mark as externally visible.
7536 * keyboard.h (ignore_mouse_drag_p): Declare only if
7537 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7538 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7539 * lisp.h (echoing): Remove decl.
7540 (force_auto_save_soon): Declare only if SIGDANGER.
7541 * xdisp.c (redisplay_window): Simplify code, to make it more
7542 obvious that ignore_mouse_drag_p is not accessed if !defined
7543 USE_GTK && !defined HAVE_NS.
7545 * intervals.c: Make symbols static if they're not exported.
7546 (merge_properties_sticky, merge_interval_right, delete_interval):
7548 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7550 * insdel.c: Make symbols static if they're not exported.
7551 However, leave prepare_to_modify_buffer alone. It's never
7552 called from outside this function, but that appears to be a bug.
7553 (combine_after_change_list, combine_after_change_buffer):
7554 (adjust_after_replace, signal_before_change): Now static.
7555 (adjust_after_replace_noundo): Remove; unused.
7556 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7557 (signal_before_change): Remove decls.
7559 * indent.c (val_compute_motion, val_vmotion): Now static.
7561 * image.c: Make symbols static if they're not exported.
7562 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7564 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7565 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7567 * fringe.c (standard_bitmaps): Now static.
7568 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7570 * frame.c: Make symbols static if they're not exported.
7571 (x_report_frame_params, make_terminal_frame): Now static.
7572 (get_frame_param): Now static, unless HAVE_NS.
7573 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7574 (x_get_resource_string): Remove; not used.
7575 * frame.h (make_terminal_frame, x_report_frame_params):
7576 (x_get_resource_string); Remove decls.
7577 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7578 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7580 * font.c, fontset.c: Make symbols static if they're not exported.
7581 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7582 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7583 * font.c (font_close_object): Now static.
7584 * font.h (font_close_object): Remove.
7585 * fontset.c (FONTSET_OBJLIST): Remove.
7586 (free_realized_fontset) #if-0 the body, which does nothing.
7587 (face_suitable_for_char_p): #if-0, as it's never called.
7588 * fontset.h (face_suitable_for_char_p): Remove decl.
7589 * xfaces.c (face_at_string_position):
7590 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7591 since 0 is always ASCII.
7593 * fns.c (weak_hash_tables): Now static.
7595 * fileio.c: Make symbols static if they're not exported.
7596 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7597 (Vwrite_region_annotation_buffers): Now static.
7599 * eval.c: Make symbols static if they're not exported.
7600 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7601 * lisp.h (backtrace_list): Remove decl.
7603 * emacs.c: Make symbols static if they're not exported.
7604 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7605 (fatal_error_code, fatal_error_signal_hook, standard_args):
7607 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7608 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7609 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7610 * lisp.h (fatal_error_signal_hook): Remove decl.
7611 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7613 * editfns.c: Move a (normally-unused) function to its only use.
7614 * editfns.c, lisp.h (get_operating_system_release): Remove.
7615 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7616 worth the hassle of breaking this out.
7618 * xterm.c: Make symbols static if they're not exported.
7619 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7620 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7621 (x_destroy_window, x_delete_display):
7623 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7624 (x_mouse_leave): Remove; unused.
7625 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7626 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7627 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7629 (x_mouse_leave): Declare only if WINDOWSNT.
7630 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7631 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7634 * ftxfont.c: Make symbols static if they're not exported.
7635 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7637 * font.h (ftxfont_driver): Likewise.
7639 * xfns.c: Make symbols static if they're not exported.
7640 (x_last_font_name, x_display_info_for_name):
7641 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7642 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7643 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7644 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7645 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7646 (last_show_tip_args): Now static.
7647 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7648 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7649 (x_screen_planes): Remove; unused.
7650 * dispextern.h (x_screen_planes): Remove decl.
7652 * dispnew.c: Make symbols static if they're not exported.
7653 * dispextern.h (redraw_garbaged_frames, scrolling):
7654 (increment_row_positions): Remove.
7655 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7656 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7658 (redraw_garbaged_frames): Remove; unused.
7660 * xfaces.c: Make symbols static if they're not exported.
7661 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7663 * xterm.h (defined_color): Remove decls.
7664 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7665 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7666 (menu_face_changed_default, defined_color, free_realized_face):
7667 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7668 (ascii_face_of_lisp_face): Remove; unused.
7670 * xdisp.c: Make symbols static if they're not exported.
7671 * dispextern.h (scratch_glyph_row, window_box_edges):
7672 (glyph_to_pixel_coords, set_cursor_from_row):
7673 (get_next_display_element, set_iterator_to_next):
7674 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7675 (show_mouse_face): Remove decls
7676 * frame.h (message_buf_print): Likewise.
7677 * lisp.h (pop_message, set_message, check_point_in_composition):
7679 * xterm.h (set_vertical_scroll_bar): Likewise.
7680 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7681 (message_buf_print, scratch_glyph_row, displayed_buffer):
7682 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7683 (get_next_display_element, show_mouse_face, window_box_edges):
7684 (frame_to_window_pixel_xy, check_point_in_composition):
7685 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7686 (glyph_to_pixel_coords): Remove; unused.
7688 * dired.c (file_name_completion): Now static.
7690 * dbusbind.c (xd_in_read_queued_messages): Now static.
7692 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7693 * data.c (circular_list_error): Remove.
7695 * commands.h (last_point_position, last_point_position_buffer):
7696 (last_point_position_window): Remove decls.
7697 * keyboard.c: Make these variables static.
7699 * coding.h (coding, code_convert_region, encode_coding_gap):
7701 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7702 (iso_code_class, detect_coding, code_convert_region): Now static.
7703 (encode_coding_gap): Remove; unused.
7705 * chartab.c (chartab_chars, chartab_bits): Now static.
7707 * charset.h (charset_iso_8859_1): Remove decl.
7708 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7711 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7712 * ccl.c (Vccl_program_table): Now static.
7713 (check_ccl_update): Remove; unused.
7715 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7716 * category.h: ... from here.
7717 * category.c (check_category_table, set_category_set): Now static.
7719 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7720 * lisp.h: Remove these decls.
7722 * buffer.c (buffer_count): Remove unused var.
7724 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7725 so that it's not optimized away.
7726 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7727 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7728 exported only to the debugger.
7730 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7731 * atimer.h (run_all_atimers): Remove; not exported.
7733 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7734 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7735 was inaccessible from Lisp.
7736 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7737 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7739 alloc.c: Import and export fewer symbols, and remove unused items.
7740 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7742 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7743 it's not optimized away by whole-program optimization.
7744 (message_enable_multibyte, free_misc): Remove.
7745 (catchlist, handlerlist, mark_backtrace):
7746 Declare only if BYTE_MARK_STACK.
7747 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7748 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7749 (message_enable_multibyte): Remove decl.
7750 (free_misc, interval_free_list, float_block, float_block_index):
7751 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7752 (cons_free_list, last_marked_index):
7754 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7755 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7756 (mark_backtrace): Define only if BYTE_MARK_STACK.
7757 * xdisp.c (message_enable_multibyte): Now static.
7759 Declare Lisp_Object Q* variables to be 'static' if not exported.
7760 This makes it easier for human readers (and static analyzers)
7761 to see whether these variables are used from other modules.
7762 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7763 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7764 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7765 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7766 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7767 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7768 * xmenu.c, xselect.c:
7769 Declare Q* vars static if they are not used in other modules.
7770 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7771 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7772 Remove decls of unexported vars.
7773 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7775 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7777 Make Emacs functions such as Fatom 'static' by default.
7778 This makes it easier for human readers (and static analyzers)
7779 to see whether these functions can be called from other modules.
7780 DEFUN now defines a static function. To make the function external
7781 so that it can be used in other C modules, use the new macro DEFUE.
7782 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7783 (Finit_image_library):
7784 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7785 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7786 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7787 Remove decls, since these functions are now static.
7788 (Funintern, Fget_internal_run_time): New decls, since these functions
7789 were already external.
7791 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7792 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7793 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7794 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7795 * keyboard.c, keymap.c, lread.c:
7796 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7797 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7798 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7799 Mark functions with DEFUE instead of DEFUN,
7800 if they are used in other modules.
7801 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7802 decls for now-static functions.
7803 * buffer.h (Fdelete_overlay): Remove decl.
7804 * callproc.c (Fgetenv_internal): Mark as internal.
7805 * composite.c (Fremove_list_of_text_properties): Remove decl.
7806 (Fcomposition_get_gstring): New forward static decl.
7807 * composite.h (Fcomposite_get_gstring): Remove decl.
7808 * dired.c (Ffile_attributes): New forward static decl.
7809 * doc.c (Fdocumntation_property): New forward static decl.
7810 * eval.c (Ffetch_bytecode): New forward static decl.
7811 (Funintern): Remove extern decl; now in .h file where it belongs.
7812 * fileio.c (Fmake_symbolic_link): New forward static decl.
7813 * image.c (Finit_image_library): New forward static decl.
7814 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7815 * intervals.h (Fprevious_property_change):
7816 (Fremove_list_of_text_properties): Remove decls.
7817 * keyboard.c (Fthis_command_keys): Remove decl.
7818 (Fcommand_execute): New forward static decl.
7819 * keymap.c (Flookup_key): New forward static decl.
7820 (Fcopy_keymap): Now static.
7821 * keymap.h (Flookup_key): Remove decl.
7822 * process.c (Fget_process): New forward static decl.
7823 (Fprocess_datagram_address): Mark as internal.
7824 * syntax.c (Fsyntax_table_p): New forward static decl.
7825 (skip_chars): Remove duplicate decl.
7826 * textprop.c (Fprevious_property_change): New forward static decl.
7827 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7829 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7830 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7832 * editfns.c (Fformat): Remove unreachable code.
7834 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7836 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7839 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7841 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7842 when at ZV. (Bug#8487)
7844 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7846 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7848 * keyboard.c (parse_tool_bar_item): Likewise.
7849 * sound.c (sound_cleanup, alsa_close): Likewise.
7850 * termcap.c (tgetent): Likewise.
7851 * xfns.c (x_default_font_parameter): Likewise.
7852 * xsettings.c (read_and_apply_settings): Likewise.
7854 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7855 (overrun_check_free): Protoize.
7857 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7859 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7860 since callers should never pass a negative size.
7861 Change the signature to match that of plain 'read' and 'write'; see
7862 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7863 * lisp.h: Update prototypes of emacs_write and emacs_read.
7865 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7867 * xdisp.c (redisplay_window): Don't try to determine the character
7868 position of the scroll margin if the window start point w->startp
7869 is outside the buffer's accessible region. (Bug#8468)
7871 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7873 Fix write-region and its subroutines for buffers > 2GB.
7874 * fileio.c (a_write, e_write): Modify declaration of arguments and
7875 local variables to support buffers larger than 2GB.
7876 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7878 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7879 argument, local variables, and return value.
7881 * lisp.h: Update prototypes of emacs_write and emacs_read.
7883 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7885 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7887 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7889 Fix more problems found by GCC 4.6.0's static checks.
7891 * xdisp.c (vmessage): Use a better test for character truncation.
7893 * charset.c (load_charset_map): <, not <=, for optimization,
7894 and to avoid potential problems with integer overflow.
7895 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7896 * casetab.c (set_identity, shuffle): Likewise.
7897 * editfns.c (Fformat): Likewise.
7898 * syntax.c (skip_chars): Likewise.
7900 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7901 This also lets GCC 4.6.0 generate slightly better loop code.
7903 * callint.c (Fcall_interactively): <, not <=, for optimization.
7904 (Fcall_interactively): Count the number of arguments produced,
7905 not the number of arguments given. This is simpler and lets GCC
7906 4.6.0 generate slightly better code.
7908 * ftfont.c: Distingish more carefully between FcChar8 and char.
7909 The previous code passed unsigned char * to a functions like
7910 strlen and xstrcasecmp that expect char *, which does not
7911 conform to the C standard.
7912 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7913 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7914 char * when the C standard requires it.
7916 * keyboard.c (read_char): Remove unused var.
7918 * eval.c: Port to Windows vsnprintf (Bug#8435).
7920 (SIZE_MAX): Define if the headers do not.
7921 (verror): Do not give up if vsnprintf returns a negative count.
7922 Instead, grow the buffer. This ports to Windows vsnprintf, which
7923 does not conform to C99. Problem reported by Eli Zaretskii.
7924 Also, simplify the allocation scheme, by avoiding the need for
7925 calling realloc, and removing the ALLOCATED variable.
7927 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7929 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7930 But keep the doprint source code for now, as we might revamp it
7931 and use it again (Bug#8435).
7932 * lisp.h (doprnt): Remove.
7933 * Makefile.in (base_obj): Remove doprnt.o.
7934 * deps.mk (doprnt.o): Remove.
7936 error: Print 32- and 64-bit integers portably (Bug#8435).
7937 Without this change, on typical 64-bit hosts error ("...%d...", N)
7938 was used to print both 32- and 64-bit integers N, which relied on
7940 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
7941 * lisp.h (error, verror): Mark as printf-like functions.
7942 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7943 Report overflow in size calculations when allocating printf buffer.
7944 Do not truncate output string at its first null byte.
7945 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7946 Truncate the output at a character boundary, since vsnprintf does not
7948 * charset.c (check_iso_charset_parameter): Convert internal
7949 character to string before calling 'error', since %c now has the
7951 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7952 overflow when computing char to be passed to 'error'. Do not
7953 pass Lisp_Object to 'error'; pass the integer instead.
7954 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7955 formatted with plain %d.
7957 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7959 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7961 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7963 * xterm.c (x_catch_errors): Remove duplicate declaration.
7965 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7967 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7969 2011-04-10 Jim Meyering <meyering@redhat.com>
7971 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7972 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7973 return ssize_t not "int", and use size_t as the buffer length.
7974 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7975 * gnutls.h: Update declarations.
7976 * process.c (read_process_output): Use ssize_t, to match.
7977 (send_process): Likewise.
7979 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7981 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7983 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7985 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7986 Use unsigned char, to match FcChar8 type definition.
7988 * xterm.c (handle_one_xevent):
7989 * xmenu.c (create_and_show_popup_menu):
7990 * xselect.c (x_decline_selection_request)
7991 (x_reply_selection_request): Avoid type-punned deref of X events.
7993 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7995 Fix some uses of `int' instead of EMACS_INT.
7996 * search.c (string_match_1, fast_string_match)
7997 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7998 (scan_buffer, find_next_newline_no_quit)
7999 (find_before_next_newline, search_command, Freplace_match)
8000 (Fmatch_data): Make some `int' variables be EMACS_INT.
8002 * xdisp.c (display_count_lines): 3rd argument and return value now
8003 EMACS_INT. All callers changed.
8004 (pint2hrstr): Last argument is now EMACS_INT.
8006 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8007 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8008 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8009 (decode_coding_utf_16, decode_coding_emacs_mule)
8010 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8011 (decode_coding_ccl, decode_coding_charset)
8012 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8013 (decode_coding_iso_2022, decode_coding_emacs_mule)
8014 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8015 <char_offset, last_offset>: Declare EMACS_INT.
8016 (encode_coding_utf_8, encode_coding_utf_16)
8017 (encode_coding_emacs_mule, encode_invocation_designation)
8018 (encode_designation_at_bol, encode_coding_iso_2022)
8019 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8020 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8022 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8023 (encode_invocation_designation): Last argument P_NCHARS is now
8025 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8026 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8028 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8031 * ccl.c (Fccl_execute_on_string): Declare some variables
8034 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8036 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8038 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8040 * process.c (Fformat_network_address): Doc fix.
8042 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8044 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8046 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8048 * keyboard.c (read_char): Call Lisp function help-form-show,
8049 instead of using internal_with_output_to_temp_buffer.
8050 (Qhelp_form_show): New var.
8051 (syms_of_keyboard): Use DEFSYM macro.
8053 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8055 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8057 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8059 * process.c (Flist_processes): Remove to Lisp.
8060 (list_processes_1): Delete.
8062 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8064 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8066 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8068 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8070 Fix more problems found by GCC 4.6.0's static checks.
8072 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8074 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8076 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8078 * xdisp.c (vmessage): Mark as a printf-like function.
8080 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8082 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8084 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8085 printf-like functions.
8086 (tiff_load): Add casts to remove these marks before passing them
8087 to system-supplied API.
8089 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8091 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8092 This avoids several warnings with gcc -Wstrict-overflow.
8093 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8094 directly, rather than having caller test rule sign. This avoids
8095 some unnecessary tests.
8096 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8097 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8098 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8100 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8101 (xfont_open): Avoid unnecessary tests.
8103 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8105 * composite.h, composite.c (composition_gstring_put_cache):
8106 Use EMACS_INT, not int, for length.
8108 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8109 breaking out part of COMPOSITION_DECODE_RULE.
8110 (COMPOSITION_DECODE_RULE): Use it.
8111 * composite.c (get_composition_id): Remove unused local vars,
8112 by using the new macro.
8114 * textprop.c (set_text_properties_1): Change while to do-while,
8115 since the condition is always true at first.
8117 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8118 (interval_deletion_adjustment): Return unsigned value.
8121 * process.c (list_processes_1, create_pty, read_process_output):
8122 (exec_sentinel): Remove vars that were set but not used.
8123 (create_pty): Remove unnecessary "volatile"s.
8124 (Fnetwork_interface_info): Avoid possibility of int overflow.
8125 (read_process_output): Do adaptive read buffering even if carryover.
8126 (read_process_output): Simplify nbytes computation if buffered.
8128 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8130 * syntax.c (scan_words): Remove var that was set but not used.
8131 (update_syntax_table): Use unsigned instead of int.
8133 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8134 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8135 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8137 * print.c (print_error_message): Avoid int overflow.
8139 * font.c (font_list_entities): Redo for clarity,
8140 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8142 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8143 (font_score): Avoid potential overflow in diff calculation.
8145 * fns.c (substring_both): Remove var that is set but not used.
8146 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8148 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8150 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8151 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8152 can always succeed if overflow has undefined behavior.
8154 * search.c (boyer_moore, wordify): Remove vars set but not used.
8155 (wordify): Omit three unnecessary tests.
8157 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8158 All callers changed. This avoids the need for an unused var.
8160 * casefiddle.c (casify_region): Remove var that is set but not used.
8162 * dired.c (file_name_completion): Remove var that is set but not used.
8164 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8166 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8167 (Finsert_file_contents): Remove unnecessary code checking fd.
8169 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8170 Check for integer overflow on size calculations.
8172 * buffer.c (Fprevious_overlay_change): Remove var that is set
8175 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8176 Remove vars that are set but not used.
8177 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8178 (timer_check_2): Mark vars as initialized.
8180 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8182 * image.c (lookup_image): Remove var that is set but not used.
8183 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8185 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8186 that are set but not used.
8188 * xfns.c (make_invisible_cursor): Don't return garbage
8189 if XCreateBitmapFromData fails (Bug#8410).
8191 * xselect.c (x_get_local_selection, x_handle_property_notify):
8192 Remove vars that are set but not used.
8194 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8195 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8197 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8198 Remove var that is set but not used.
8199 (scroll_bar_windows_size): Now size_t, not int.
8200 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8203 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8204 (map_tty_color) [!defined MSDOS]: Likewise.
8206 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8208 * coding.c: Remove vars that are set but not used.
8209 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8210 All callers changed.
8211 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8212 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8213 (decode_coding_charset): Remove vars that are set but not used.
8215 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8216 that is set but not used.
8218 * print.c (print_object): Remove var that is set but not used.
8220 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8221 The gnulib version avoids calling malloc in the usual case,
8222 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8223 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8224 * filelock.c (current_lock_owner): Likewise.
8225 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8226 * sysdep.c: Include allocator.h, careadlinkat.h.
8227 (emacs_no_realloc_allocator): New static constant.
8228 (emacs_readlink): New function.
8229 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8230 ../lib/careadlinkat.h.
8232 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8234 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8235 first non-nil return value).
8237 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8239 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8240 if not defined (Bug#8403).
8242 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8244 * xdisp.c (display_count_lines): Remove parameter `start',
8245 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8246 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8247 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8248 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8249 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8250 and thereabouts. All callers changed.
8251 (get_per_char_metric): Remove parameter `f', unused since
8252 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8254 2011-04-02 Jim Meyering <meyering@redhat.com>
8256 do not dereference NULL upon failed strdup
8257 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8258 (ns_get_family): Likewise.
8260 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8262 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8264 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8266 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8269 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8271 Add lexical binding.
8273 * window.c (Ftemp_output_buffer_show): New fun.
8274 (Fsave_window_excursion):
8275 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8277 * lread.c (lisp_file_lexically_bound_p): New function.
8278 (Fload): Bind Qlexical_binding.
8279 (readevalloop): Remove `evalfun' arg.
8280 Bind Qinternal_interpreter_environment.
8281 (Feval_buffer): Bind Qlexical_binding.
8282 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8284 (syms_of_lread): Declare `lexical-binding'.
8286 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8288 * keyboard.c (eval_dyn): New fun.
8289 (menu_item_eval_property): Use it.
8291 * image.c (parse_image_spec): Use Ffunctionp.
8293 * fns.c (concat, mapcar1): Accept byte-code-functions.
8295 * eval.c (Fsetq): Handle lexical vars.
8296 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8297 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8298 (FletX, Flet): Obey lexical binding.
8299 (Fcommandp): Handle closures.
8300 (Feval): New `lexical' arg.
8301 (eval_sub): New function extracted from Feval. Use it almost
8302 everywhere where Feval was used. Look up vars in lexical env.
8304 (Ffunctionp): Move from subr.el.
8305 (Ffuncall): Handle closures.
8306 (apply_lambda): Remove `eval_flags'.
8307 (funcall_lambda): Handle closures and new byte-code-functions.
8308 (Fspecial_variable_p): New function.
8309 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8310 but without exporting it to Lisp.
8312 * doc.c (Fdocumentation, store_function_docstring):
8313 * data.c (Finteractive_form): Handle closures.
8315 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8318 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8320 (exec_byte_code): New function extracted from Fbyte_code to handle new
8321 calling convention for byte-code-functions. Add new byte-codes.
8323 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8325 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8327 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8329 * xdisp.c (redisplay_internal): Fix prototype.
8331 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8333 * xdisp.c (SCROLL_LIMIT): New macro.
8334 (try_scrolling): Use it when setting scroll_limit.
8335 Limit scrolling to 100 screen lines.
8336 (redisplay_window): Even when falling back on "recentering",
8337 position point in the window according to scroll-conservatively,
8338 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8340 (try_scrolling): When point is above the window, allow searching
8341 as far as scroll_max, or one screenful, to compute vertical
8342 distance from PT to the scroll margin position. This prevents
8343 try_scrolling from unnecessarily failing when
8344 scroll-conservatively is set to a value slightly larger than the
8345 window height. Clean up the case of PT below the margin at bottom
8346 of window: scroll_max can no longer be INT_MAX. When aggressive
8347 scrolling is in use, don't let point enter the opposite scroll
8348 margin as result of the scroll.
8349 (syms_of_xdisp) <scroll-conservatively>: Document the
8350 threshold of 100 lines for never-recentering scrolling.
8352 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8354 * dispextern.h (move_it_by_lines):
8355 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8356 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8357 (message_log_check_duplicate): Remove parameters `prev_bol' and
8358 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8359 (redisplay_internal): Remove parameter `preserve_echo_area',
8360 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8362 * indent.c (Fvertical_motion):
8363 * window.c (window_scroll_pixel_based, Frecenter):
8364 Don't pass `need_y_p' to `move_it_by_lines'.
8366 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8368 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8369 steal a few bits to be more compact.
8370 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8371 Remove unneeded casts.
8373 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8375 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8377 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8378 binding" message (bug#7967).
8380 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8382 Fix more problems found by GCC 4.6.0's static checks.
8384 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8385 Remove unused local var.
8387 * editfns.c (Fmessage_box): Remove unused local var.
8389 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8390 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8391 Omit unused local vars.
8392 * window.c (shrink_windows): Omit unused local var.
8393 * menu.c (digest_single_submenu): Omit unused local var.
8394 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8395 Omit unused local var.
8397 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8398 Don't assume string length fits in int.
8399 (keyremap_step, read_key_sequence): Use size_t for sizes.
8400 (read_key_sequence): Don't check last_real_key_start redundantly.
8402 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8403 instead of alloca (Bug#8344).
8405 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8406 (Fbacktrace_frame): Don't assume nframes fits in int.
8408 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8410 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8413 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8415 * cm.c (calccost): Turn while-do into do-while, for clarity.
8417 * keyboard.c (syms_of_keyboard): Use the same style as later
8418 in this function when indexing through an array. This also
8419 works around GCC bug 48267.
8421 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8423 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8425 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8426 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8428 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8429 This avoids undefined behavior on integer overflow, and is a bit
8430 more convenient anyway since it is compared to a size_t variable.
8432 Variadic C functions now count arguments with size_t, not int.
8433 This avoids an unnecessary limitation on 64-bit machines, which
8434 caused (substring ...) to crash on large vectors (Bug#8344).
8435 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8436 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8437 All variadic functions and their callers changed accordingly.
8438 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8439 * data.c (arith_driver, float_arith_driver): Likewise.
8440 * editfns.c (general_insert_function): Likewise.
8441 * eval.c (struct backtrace.nargs, interactive_p)
8442 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8443 (funcall_lambda, mark_backtrace): Likewise.
8444 * fns.c (concat): Likewise.
8445 * frame.c (x_set_frame_parameters): Likewise.
8446 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8447 0 if not found, not -1. All callers changed.
8449 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8450 (stack_copy_size): Now size_t, not int.
8451 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8453 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8455 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8456 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8457 All callers changed.
8459 * lisp.h (multibyte_char_to_unibyte):
8460 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8461 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8462 * character.h (CHAR_TO_BYTE8):
8463 * cmds.c (internal_self_insert):
8464 * editfns.c (general_insert_function):
8465 * keymap.c (push_key_description):
8466 * search.c (Freplace_match):
8467 * xdisp.c (message_dolog, set_message_1): All callers changed.
8469 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8471 * keyboard.c (safe_run_hook_funcall): New function.
8472 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8473 don't set the hook to nil, but remove the offending function instead.
8474 (Qcommand_hook_internal): Remove, unused.
8475 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8476 Vcommand_hook_internal.
8478 * eval.c (enum run_hooks_condition): Remove.
8479 (funcall_nil, funcall_not): New functions.
8480 (run_hook_with_args): Call each function through a `funcall' argument.
8481 Remove `cond' argument, now redundant.
8482 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8483 (Frun_hook_with_args_until_failure): Adjust accordingly.
8484 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8486 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8488 * dispextern.h (string_buffer_position): Remove declaration.
8490 * print.c (strout): Remove parameter `multibyte', unused since
8491 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8493 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8494 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8495 All callers changed.
8497 * w32.c (_wsa_errlist): Use braces for struct initializers.
8499 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8500 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8501 All callers changed.
8502 (string_buffer_position): Likewise. Also, make static (it's never
8503 used outside xdisp.c).
8504 (cursor_row_p): Remove parameter `w', unused since
8505 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8506 (decode_mode_spec): Remove parameter `precision', introduced during
8507 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8508 All callers changed.
8510 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8512 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8514 2011-03-27 Anders Lindgren <andlind@gmail.com>
8516 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8517 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8518 (ns_update_auto_hide_menu_bar): New functions.
8519 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8520 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8521 ns_constrain_all_frames.
8522 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8523 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8525 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8527 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8529 2011-03-27 Glenn Morris <rgm@gnu.org>
8531 * syssignal.h: Replace RETSIGTYPE with void.
8532 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8533 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8534 Replace SIGTYPE with void everywhere.
8535 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8536 * s/template.h (SIGTYPE): Remove commented out definition.
8538 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8540 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8541 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8543 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8545 * w32.c (read_unc_volume): Use parameter `henum', instead of
8546 global variable `wget_enum_handle'.
8548 * keymap.c (describe_vector): Remove parameters `indices' and
8549 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8550 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8552 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8554 * keyboard.c (timer_check): Remove parameter `do_it_now',
8555 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8556 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8557 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8559 * keyboard.c (read_char):
8560 * w32menu.c (w32_menu_display_help):
8561 * xmenu.c (show_help_event, menu_help_callback):
8562 Adjust calls to `show_help_echo'.
8564 * gtkutil.c (xg_maybe_add_timer):
8565 * keyboard.c (readable_events):
8566 * process.c (wait_reading_process_output):
8567 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8569 * insdel.c (adjust_markers_gap_motion):
8570 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8571 (gap_left, gap_right): Don't call it.
8573 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8575 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8576 incurred during fontification.
8578 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8580 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8581 (DEFVAR_PER_BUFFER): Don't pass it.
8583 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8584 (scrolling_window): Don't pass it.
8586 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8588 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8590 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8592 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8593 of variables specific to SELinux and computation of `encoded_absname'.
8595 * image.c (XPutPixel): Remove unused variable `height'.
8597 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8599 * unexw32.c (get_section_info): Remove unused variable `section'.
8601 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8602 (system_process_attributes): Remove unused variable `sess'.
8603 (sys_read): Remove unused variable `err'.
8605 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8606 (w32_wnd_proc): Remove unused variable `isdead'.
8607 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8608 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8609 (x_create_tip_frame): Remove unused variable `tem'.
8611 * w32inevt.c (w32_console_read_socket):
8612 Remove unused variable `no_events'.
8614 * w32term.c (x_draw_composite_glyph_string_foreground):
8615 Remove unused variable `width'.
8617 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8619 * w32term.c (x_set_glyph_string_clipping):
8620 Don't pass uninitialized region to CombineRgn.
8622 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8624 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8625 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8626 (Fx_close_connection): Remove unused variable `i'.
8628 * w32font.c (w32font_draw): Return number of glyphs.
8629 (w32font_open_internal): Remove unused variable `i'.
8630 (w32font_driver): Add missing initializer.
8632 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8633 (fill_in_menu): Remove unused variable `items_added'.
8635 * w32term.c (last_mouse_press_frame): Remove static global variable.
8636 (w32_clip_to_row): Remove unused variable `f'.
8637 (x_delete_terminal): Remove unused variable `i'.
8639 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8640 (NOTHING): Remove unused static global variable.
8641 (uniscribe_check_otf): Remove unused variable `table'.
8642 (uniscribe_font_driver): Add missing initializers.
8644 2011-03-23 Julien Danjou <julien@danjou.info>
8646 * term.c (Fsuspend_tty, Fresume_tty):
8647 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8648 * window.c (temp_output_buffer_show):
8649 * insdel.c (signal_before_change):
8650 * frame.c (Fhandle_switch_frame):
8651 * fileio.c (Fdo_auto_save):
8652 * emacs.c (Fkill_emacs):
8653 * editfns.c (save_excursion_restore):
8654 * cmds.c (internal_self_insert):
8655 * callint.c (Fcall_interactively):
8656 * buffer.c (Fkill_all_local_variables):
8657 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8659 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8660 unconditionally since it does the check itself.
8662 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8664 Fix more problems found by GCC 4.5.2's static checks.
8666 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8667 the first time through the loop, since we know p0 < p1 then.
8668 This also avoids a gcc -Wstrict-overflow warning.
8670 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8671 leading to a memory leak, possible in functions like
8672 load_charset_map_from_file that can allocate an unbounded number
8673 of objects (Bug#8318).
8675 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8676 that could (at least in theory) be that large.
8678 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8679 This is less likely to overflow, and avoids undefined behavior if
8680 overflow does occur. All callers changed. Use strtoul to scan
8681 for the unsigned long integer.
8682 (pint2hrstr): Simplify and tune code slightly.
8683 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8685 * scroll.c (do_scrolling): Work around GCC bug 48228.
8686 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8688 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8689 This also avoids a warning with gcc -Wstrict-overflow.
8690 (validate_x_resource_name): Simplify count usage.
8691 This also avoids a warning with gcc -Wstrict-overflow.
8693 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8696 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8698 * process.c (Fmake_network_process): Use socklen_t, not int,
8699 where POSIX says socklen_t is required in portable programs.
8700 This fixes a porting bug on hosts like 64-bit HP-UX, where
8701 socklen_t is wider than int (Bug#8277).
8702 (Fmake_network_process, server_accept_connection):
8703 (wait_reading_process_output, read_process_output):
8706 * process.c: Rename or move locals to avoid shadowing.
8707 (list_processes_1, Fmake_network_process):
8708 (read_process_output_error_handler, exec_sentinel_error_handler):
8709 Rename or move locals.
8710 (Fmake_network_process): Define label "retry_connect" only if needed.
8711 (Fnetwork_interface_info): Fix pointer signedness.
8712 (process_send_signal): Add cast to avoid pointer signedness problem.
8713 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8714 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8716 Make tparam.h and terminfo.c consistent.
8717 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8718 Include tparam.h instead, since it declares them.
8719 * cm.h (PC): Remove extern decl; tparam.h now does this.
8720 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8721 * terminfo.c: Include tparam.h, to check interfaces.
8722 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8723 (tparam): Adjust signature to match interface in tparam.h;
8724 this removes some undefined behavior. Check that outstring and len
8725 are zero, which they always are with Emacs.
8726 * tparam.h (PC, BC, UP): New extern decls.
8728 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8729 (xftfont_open): Rename locals to avoid shadowing.
8731 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8732 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8733 (OTF_TAG_SYM): Omit macro if not needed.
8734 (ftfont_list): Remove unused local.
8735 (get_adstyle_property, ftfont_pattern_entity):
8736 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8737 Rename locals to avoid shadowing.
8739 * xfont.c (xfont_list_family): Mark var as initialized.
8741 * xml.c (make_dom): Now static.
8743 * composite.c (composition_compute_stop_pos): Rename local to
8745 (composition_reseat_it): Remove unused locals.
8746 (find_automatic_composition, composition_adjust_point): Likewise.
8747 (composition_update_it): Mark var as initialized.
8748 (find_automatic_composition): Mark vars as initialized,
8749 with a FIXME (Bug#8290).
8751 character.h: Rename locals to avoid shadowing.
8752 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8753 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8754 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8755 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8758 * textprop.c (property_change_between_p): Remove; unused.
8760 * intervals.c (interval_start_pos): Now static.
8762 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8764 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8765 Rename locals to avoid shadowing.
8767 * sound.c (wav_play, au_play, Fplay_sound_internal):
8768 Fix pointer signedness.
8769 (alsa_choose_format): Remove unused local var.
8770 (wav_play): Initialize a variable to 0, to prevent undefined
8771 behavior (Bug#8278).
8773 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8775 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8777 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8778 clobbering (Bug#8298).
8779 * sysdep.c (sys_subshell): Likewise.
8780 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8782 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8783 This should get cleaned up, so that child_setup has the
8784 same signature on all platforms.
8786 * callproc.c (call_process_cleanup): Now static.
8787 (relocate_fd): Rename locals to avoid shadowing.
8789 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8791 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8792 not to be necessary, and produces flickering.
8794 2011-03-20 Glenn Morris <rgm@gnu.org>
8796 * config.in: Remove file.
8798 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8800 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8801 are now in src/globals.h.
8802 (syms_of_minibuf): Remove spurious & from previous change.
8804 2011-03-20 Leo Liu <sdl.web@gmail.com>
8806 * minibuf.c (completing-read-function): New variable.
8807 (completing-read-default): Rename from completing-read.
8808 (completing-read): Call completing-read-function.
8810 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8812 * xfaces.c (Fx_load_color_file):
8813 Read color file from absolute filename (bug#8250).
8815 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8817 * makefile.w32-in: Update dependencies.
8819 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8821 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8823 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8825 Fix more problems found by GCC 4.5.2's static checks.
8827 * process.c (make_serial_process_unwind, send_process_trap):
8828 (sigchld_handler): Now static.
8830 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8831 That way, the code declares only the vars that it needs.
8832 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8833 * s/cygwin.h (PTY_ITERATION): Likewise.
8834 * s/darwin.h (PTY_ITERATION): Likewise.
8835 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8837 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8838 * process.c (allocate_pty): Don't declare stb unless it's needed.
8840 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8841 (CONSTANTLIM): Remove; unused.
8842 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8843 Define only if needed.
8845 * unexelf.c (unexec): Name an expression,
8846 to avoid gcc -Wbad-function-cast warning.
8847 Use a different way to cause a compilation error if anyone uses
8848 n rather than nn, a way that does not involve shadowing.
8849 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8851 * deps.mk (unexalpha.o): Remove; unused.
8853 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8854 * unexec.h: New file.
8855 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8856 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8858 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8859 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8860 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8861 Change as necessary to match prototype in unexec.h.
8863 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8865 (back_comment, skip_chars): Mark vars as initialized.
8867 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8868 Rename locals to avoid shadowing.
8870 * lread.c (read1): Rewrite so as not to use empty "else".
8871 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8873 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8875 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8876 warning when compiling print.c.
8878 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8879 instead of using an uninitialized var.
8880 (font_sort_entities): Mark var as initialized.
8882 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8884 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8885 pointers to constants.
8886 (font_parse_fcname): Remove unused vars.
8887 (font_delete_unmatched): Now static.
8888 (font_get_spec): Remove; unused.
8889 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8890 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8891 Rename or move locals to avoid shadowing.
8893 * fns.c (require_nesting_list, require_unwind): Now static.
8894 (Ffillarray): Rename locals to avoid shadowing.
8896 * floatfns.c (domain_error2): Define only if needed.
8897 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8899 * alloc.c (mark_backtrace): Move decl from here ...
8900 * lisp.h: ... to here, so that it can be checked.
8902 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8903 (Fdefvar): Rewrite so as not to use empty "else".
8904 (lisp_indirect_variable): Name an expression,
8905 to avoid gcc -Wbad-function-cast warning.
8906 (Fdefvar): Rename locals to avoid shadowing.
8908 * callint.c (quotify_arg, quotify_args): Now static.
8909 (Fcall_interactively): Rename locals to avoid shadowing.
8910 Use const pointer when appropriate.
8912 * lisp.h (get_system_name, get_operating_system_release):
8913 Move decls here, to check interfaces.
8914 * process.c (get_operating_system_release): Move decl to lisp.h.
8915 * xrdb.c (get_system_name): Likewise.
8916 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8917 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8918 some of which prompt warnings from gcc -Wbad-function-cast.
8919 (Fformat_time_string, Fencode_time, Finsert_char):
8920 (Ftranslate_region_internal, Fformat):
8921 Rename or remove local vars to avoid shadowing.
8922 (Ftranslate_region_internal): Mark var as initialized.
8924 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8927 * lisp.h (eassert): Check that the argument compiles, even if
8928 ENABLE_CHECKING is not defined.
8930 * data.c (Findirect_variable): Name an expression, to avoid
8931 gcc -Wbad-function-cast warning.
8932 (default_value, arithcompare, arith_driver, arith_error): Now static.
8933 (store_symval_forwarding): Rename local to avoid shadowing.
8934 (Fmake_variable_buffer_local, Fmake_local_variable):
8935 Mark variables as initialized.
8936 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8938 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8939 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8940 Rename locals to avoid shadowing.
8941 (mark_stack): Move local variables into the #ifdef region where
8943 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8944 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8946 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8947 (GC_STRING_CHARS): Remove; not used.
8948 (Fmemory_limit): Cast sbrk's returned value to char *.
8950 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8951 avoids undefined behavior in theory.
8953 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8955 Use functions, not macros, for up- and down-casing (Bug#8254).
8956 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8957 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8958 to use the following functions instead of these macros.
8959 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8960 EMACS_INT, since callers assume the returned value fits in int.
8961 (upcase1): Likewise, for UPCASE_TABLE.
8962 (uppercasep, lowercasep, upcase): New static inline functions.
8963 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8964 the race-condition problem in the old DOWNCASE.
8966 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8967 Rename locals to avoid shadowing.
8968 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8969 (regex_compile, re_search_2, re_match_2_internal):
8970 Remove unused local vars.
8971 (FREE_VAR): Rewrite so as not to use empty "else",
8972 which gcc can warn about.
8973 (regex_compile, re_match_2_internal): Mark locals as initialized.
8974 (RETALLOC_IF): Define only if needed.
8975 (WORDCHAR_P): Likewise. This one is never needed, but is used
8976 only in a comment talking about a compiler bug, so put inside
8977 the #if 0 of that comment.
8978 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8979 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8982 * search.c (boyer_moore): Rename locals to avoid shadowing.
8983 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8984 (PREV_CHAR_BOUNDARY): Likewise.
8986 * search.c (simple_search): Remove unused var.
8988 * dired.c (compile_pattern): Move decl from here ...
8989 * lisp.h: ... to here, so that it can be checked.
8990 (struct re_registers): New forward decl.
8992 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8994 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8996 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8997 Rename locals to avoid shadowing.
8998 (Fvertical_motion): Mark locals as initialized.
9000 * casefiddle.c (casify_object, casify_region): Now static.
9001 (casify_region): Mark local as initialized.
9003 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9005 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9006 New macros, so that the caller can use some names other than
9007 gcpro1, gcpro2, etc.
9008 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9010 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9011 argument, for consistency with GCPRO2_VAR, etc: it is now the
9012 prefix of the variable, not the variable itself. All uses
9014 * dired.c (directory_files_internal, file_name_completion):
9015 Rename locals to avoid shadowing.
9017 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9018 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9019 dired.c's scmp function, had undefined behavior.
9020 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9021 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9022 * buffer.h: ... to here, because these macros use current_buffer,
9023 and the new implementation with inline functions needs to have
9024 current_buffer in scope now, rather than later when the macros
9026 (downcase, upcase1): New static inline functions.
9027 (DOWNCASE, UPCASE1): Reimplement using these functions.
9028 This avoids undefined behavior in expressions like
9029 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9030 from race conditions in accessing the global variables
9031 case_temp1 and case_temp2.
9032 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9033 * lisp.h (case_temp1, case_temp2): Remove their decls.
9034 * character.h (ASCII_CHAR_P): Move from here ...
9035 * lisp.h: ... to here, so that the inline functions mentioned
9038 * dired.c (directory_files_internal_unwind): Now static.
9040 * fileio.c (file_name_as_directory, directory_file_name):
9041 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9043 (file_name_as_directory): Use const pointers when appropriate.
9044 (Fexpand_file_name): Likewise. In particular, newdir might
9045 point at constant storage, so make it a const pointer.
9046 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9047 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9049 (Fset_file_times, Finsert_file_contents, auto_save_error):
9050 Rename locals to avoid shadowing.
9052 * minibuf.c (choose_minibuf_frame_1): Now static.
9053 (Ftry_completion, Fall_completions): Rename or remove locals
9056 * marker.c (bytepos_to_charpos): Remove; unused.
9058 * lisp.h (verify_bytepos, count_markers): New decls,
9059 so that gcc does not warn that these functions aren't declared.
9061 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9062 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9063 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9064 (copy_text): Remove unused local var.
9066 * filelock.c (within_one_second): Now static.
9067 (lock_file_1): Rename local to avoid shadowing.
9069 * buffer.c (fix_overlays_before): Mark locals as initialized.
9070 (fix_start_end_in_overlays): Likewise. This function should be
9071 simplified by using pointers-to-pointers, but that's a different
9073 (switch_to_buffer_1): Now static.
9074 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9075 (report_overlay_modification): Rename locals to avoid shadowing.
9077 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9078 Fix pointer signedness issue.
9079 (sys_subshell): Mark local as volatile if checking for lint,
9080 to suppress a gcc -Wclobbered warning that does not seem to be right.
9081 (MAXPATHLEN): Define only if needed.
9083 * process.c (serial_open, serial_configure): Move decls from here ...
9084 * systty.h: ... to here, so that they can be checked.
9086 * fns.c (get_random, seed_random): Move extern decls from here ...
9087 * lisp.h: ... to here, so that they can be checked.
9089 * sysdep.c (reset_io): Now static.
9090 (wait_for_termination_signal): Remove; unused.
9092 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9093 (copy_keymap_item, append_key, push_text_char_description):
9095 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9096 (DENSE_TABLE_SIZE): Remove; unused.
9097 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9098 (describe_map_tree):
9099 Rename locals to avoid shadowing.
9101 * keyboard.c: Declare functions static if they are not used elsewhere.
9102 (echo_char, echo_dash, cmd_error, top_level_2):
9103 (poll_for_input, handle_async_input): Now static.
9104 (read_char, kbd_buffer_get_event, make_lispy_position):
9105 (make_lispy_event, make_lispy_movement, apply_modifiers):
9106 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9107 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9108 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9109 (read_key_sequence, read_char): Mark locals as initialized.
9110 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9112 * keyboard.h (make_ctrl_char): New decl.
9113 (mark_kboards): Move decl here ...
9114 * alloc.c (mark_kboards): ... from here.
9116 * lisp.h (force_auto_save_soon): New decl.
9118 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9119 (DEFINE_DUMMY_FUNCTION): New macro.
9120 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9122 (main): Add casts to avoid warnings
9123 if GCC considers string literals to be constants.
9125 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9127 * dbusbind.c: Pointer signedness fixes.
9128 (xd_signature, xd_append_arg, xd_initialize):
9129 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9130 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9131 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9132 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9134 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9135 if GCC considers string literals to be constants.
9136 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9138 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9140 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9141 (print_preprocess, print_object): New macro to fix last change.
9143 * print.c (print_preprocess): Don't forget font objects.
9145 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9147 * emacs.c (USAGE3): Doc fixes.
9149 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9151 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9154 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9156 * lisp.h (VWindow_system, Qfile_name_history):
9157 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9158 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9159 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9161 * w32select.c: Don't #include "keyboard.h".
9162 (run_protected): Add extern declaration for waiting_for_input.
9164 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9165 * w32console.c (detect_input_pending, read_input_pending)
9166 (encode_terminal_code):
9167 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9168 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9169 (w32_system_caret_y, Qfile_name_history):
9170 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9171 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9172 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9173 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9174 * w32proc.c (Qlocal, report_file_error):
9175 * w32term.c (Vwindow_system, updating_frame):
9176 * w32uniscribe.c (initialized, uniscribe_font_driver):
9177 Remove unneeded extern declarations.
9179 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9181 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9183 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9185 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9186 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9187 These macros can no longer be used for assignment.
9189 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9190 Assign struct members directly, instead of using BUF_BEGV etc.
9191 (record_buffer_markers, fetch_buffer_markers): New functions for
9192 recording and fetching special buffer markers.
9193 (set_buffer_internal_1, set_buffer_temp): Use them.
9195 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9197 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9199 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9200 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9202 * xdisp.c (hscroll_window_tree):
9203 (reconsider_clip_changes): Use PT instead of BUF_PT.
9205 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9207 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9208 $(EMACS_ROOT)/lib/intprops.h.
9210 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9212 Fix more problems found by GCC 4.5.2's static checks.
9214 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9215 to unsigned char * to avoid compiler diagnostic.
9216 (xg_free_frame_widgets): Make it clear that a local variable is
9217 needed only if USE_GTK_TOOLTIP.
9218 (gdk_window_get_screen): Make it clear that this macro is needed
9219 only if USE_GTK_TOOLTIP.
9220 (int_gtk_range_get_value): New function, which avoids a diagnostic
9221 from gcc -Wbad-function-cast.
9222 (xg_set_toolkit_scroll_bar_thumb): Use it.
9223 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9224 diagnostic from gcc -Wbad-function-cast.
9225 (get_utf8_string, xg_get_file_with_chooser):
9226 Rename locals to avoid shadowing.
9227 (create_dialog): Move locals to avoid shadowing.
9229 * xgselect.c (xg_select): Remove unused var.
9231 * image.c (four_corners_best): Mark locals as initialized.
9232 (gif_load): Initialize transparent_p to zero (Bug#8238).
9233 Mark another local as initialized.
9234 (my_png_error, my_error_exit): Mark with NO_RETURN.
9236 * image.c (clear_image_cache): Now static.
9237 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9238 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9239 (x_edge_detection): Remove unnecessary cast that
9240 gcc -Wbad-function-cast diagnoses.
9241 (gif_load): Fix pointer signedness.
9242 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9243 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9245 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9247 Improve quality of tests for time stamp overflow.
9248 For example, without this patch (encode-time 0 0 0 1 1
9249 1152921504606846976) returns the obviously-bogus value (-948597
9250 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9251 reports time overflow. See
9252 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9253 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9254 * editfns.c: Include limits.h and intprops.h.
9255 (TIME_T_MIN, TIME_T_MAX): New macros.
9256 (time_overflow): Move earlier, to before first use.
9257 (hi_time, lo_time): New functions, for an accurate test for
9259 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9260 (Fget_internal_run_time): Don't assume time_t fits in int.
9261 (make_time): Use list2 instead of Fcons twice.
9262 (Fdecode_time): More accurate test for out-of-range times.
9263 (check_tm_member): New function.
9264 (Fencode_time): Use it, to test for out-of-range times.
9265 (lisp_time_argument): Don't rely on undefined left-shift and
9266 right-shift behavior when checking for time stamp overflow.
9268 * editfns.c (time_overflow): New function, refactoring common code.
9269 (Fformat_time_string, Fdecode_time, Fencode_time):
9270 (Fcurrent_time_string): Use it.
9272 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9273 * dired.c (make_time): Move to ...
9274 * editfns.c (make_time): ... here.
9275 * systime.h: Note the move.
9277 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9279 * fringe.c (update_window_fringes): Remove unused variables.
9281 * unexmacosx.c (copy_data_segment): Also copy __got section.
9284 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9286 * termcap.c [MSDOS]: Include "msdos.h".
9287 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9288 Constify `char *' arguments and their references according to
9289 prototypes in tparam.h.
9291 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9293 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9294 Adapt all references accordingly.
9296 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9298 2011-03-11 Tom Tromey <tromey@redhat.com>
9300 * buffer.c (syms_of_buffer): Remove obsolete comment.
9302 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9304 * termhooks.h (encode_terminal_code): Declare prototype.
9306 * msdos.c (encode_terminal_code): Don't declare prototype.
9308 * term.c (encode_terminal_code): Now external again, used by
9309 w32console.c and msdos.c.
9311 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9312 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9314 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9316 Fix some minor problems found by GCC 4.5.2's static checks.
9318 * fringe.c (update_window_fringes): Mark locals as initialized
9320 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9322 * alloc.c (mark_fringe_data): Move decl from here ...
9323 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9324 to check its interface.
9325 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9327 * fontset.c (free_realized_fontset): Now static.
9328 (Fset_fontset_font): Rename local to avoid shadowing.
9329 (fontset_font): Mark local as initialized.
9330 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9332 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9334 * xselect.c (x_disown_buffer_selections): Remove; not used.
9335 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9336 (x_own_selection, Fx_disown_selection_internal): Rename locals
9338 (x_handle_dnd_message): Remove local to avoid shadowing.
9340 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9341 so that the caller can use some name other than gcpro1.
9342 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9343 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9344 (Fx_backspace_delete_keys_p):
9345 Use them to avoid shadowing, and rename vars to avoid shadowing.
9346 (x_decode_color, x_set_name, x_window): Now static.
9347 (Fx_create_frame): Add braces to silence GCC warning.
9348 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9349 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9350 Remove unused locals.
9351 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9352 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9353 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9356 * xterm.h (x_mouse_leave): New decl.
9358 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9359 Remove unused functions.
9360 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9361 (x_calc_absolute_position): Now static.
9362 (XTread_socket): Don't define label "out" unless it's used.
9363 Don't declare local "event" unless it's used.
9364 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9365 unless they are used.
9366 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9367 (x_fatal_error_signal): Remove; not used.
9368 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9369 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9370 (x_error_catcher, x_connection_closed, x_error_handler):
9371 (x_error_quitter, xembed_send_message, x_iconify_frame):
9372 (my_log_handler): Rename locals to avoid shadowing.
9373 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9374 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9376 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9377 Rename or move locals to avoid shadowing.
9378 (tty_defined_color, merge_face_heights): Now static.
9379 (free_realized_faces_for_fontset): Remove; not used.
9380 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9381 does not deduce is never used uninitialized.
9382 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9383 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9385 * terminal.c (store_terminal_param): Now static.
9387 * xmenu.c (menu_highlight_callback): Now static.
9388 (set_frame_menubar): Remove unused local.
9389 (xmenu_show): Rename parameter to avoid shadowing.
9390 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9391 since they might point to immutable storage.
9392 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9393 since it's unused otherwise.
9395 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9396 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9397 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9398 avoids a gcc -Wuninitialized diagnostic.
9399 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9400 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9401 does not deduce are never used uninitialized.
9403 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9405 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9406 * window.c (window_loop, size_window):
9407 (run_window_configuration_change_hook, enlarge_window): Likewise.
9409 * window.c (display_buffer): Now static.
9410 (size_window): Mark variables that gcc -Wuninitialized
9411 does not deduce are never used uninitialized.
9412 * window.h (check_all_windows): New decl, to forestall
9413 gcc -Wmissing-prototypes diagnostic.
9414 * dispextern.h (bidi_dump_cached_states): Likewise.
9416 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9418 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9420 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9421 and to avoid gcc -Wuninitialized warning.
9422 (load_charset_map): Mark variables that gcc -Wuninitialized
9423 does not deduce are never used uninitialized.
9424 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9426 * coding.c (coding_set_source, coding_set_destination):
9427 Use "else { /* comment */ }" rather than "else /* comment */;"
9428 for clarity, and to avoid gcc -Wempty-body warning.
9429 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9430 a block, when the outer 'i' will do.
9431 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9432 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9433 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9434 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9435 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9436 Rename locals to avoid shadowing.
9437 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9438 * coding.c (emacs_mule_char, encode_invocation_designation):
9439 Now static, since they're not used elsewhere.
9440 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9441 (decode_coding_object, encode_coding_object, detect_coding_system):
9442 (decode_coding_emacs_mule): Mark variables that gcc
9443 -Wuninitialized does not deduce are never used uninitialized.
9444 (detect_coding_iso_2022): Initialize a local variable that might
9445 be used uninitialized. Leave a FIXME because it's not clear that
9446 this initialization is needed. (Bug#8211)
9447 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9448 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9449 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9450 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9451 Remove unused macros.
9453 * category.c (hash_get_category_set): Remove unused local var.
9454 (copy_category_table): Now static, since it's not used elsewhere.
9455 * character.c (string_count_byte8): Likewise.
9457 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9458 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9460 * chartab.c (copy_sub_char_table): Now static, since it's not used
9462 (sub_char_table_ref_and_range, char_table_ref_and_range):
9463 Rename locals to avoid shadowing.
9464 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9466 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9467 (BIDI_BOB): Remove unused macro.
9469 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9470 deduce are never used uninitialized.
9471 * term.c (encode_terminal_code): Likewise.
9473 * term.c (encode_terminal_code): Now static. Remove unused local.
9475 * tparam.h: New file.
9476 * term.c, tparam.h: Include it.
9477 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9478 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9479 Move these decls to tparam.h, and make them agree with what
9480 is actually in tparam.c. The previous trick of using incompatible
9481 decls in different modules does not conform to the C standard.
9482 All callers of tparam changed to use tparam's actual API.
9483 * tparam.c (tparam1, tparam, tgoto):
9484 Use const pointers where appropriate.
9486 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9487 * cm.h (struct cm): Likewise.
9488 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9489 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9490 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9491 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9492 (turn_on_face, init_tty): Likewise.
9493 * termchar.h (struct tty_display_info): Likewise.
9495 * term.c (term_mouse_position): Rename local to avoid shadowing.
9497 * alloc.c (mark_ttys): Move decl from here ...
9498 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9500 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9502 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9504 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9506 * search.c (compile_pattern_1): Remove argument regp, unused since
9507 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9508 (compile_pattern): Don't pass it.
9510 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9512 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9513 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9515 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9517 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9519 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9520 gdk_window_get_screen, gdk_window_get_geometry,
9521 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9522 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9523 (xg_get_pixbuf_from_pixmap): New function.
9524 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9525 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9526 Call xg_get_pixbuf_from_pixmap instead of
9527 gdk_pixbuf_get_from_drawable.
9528 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9529 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9530 (xg_check_special_colors): Use GtkStyleContext and its functions
9532 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9533 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9534 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9535 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9536 Call gtk_widget_get_preferred_size.
9537 (xg_frame_resized): gdk_window_get_geometry only takes 5
9539 (xg_win_to_widget, xg_event_is_for_menubar):
9540 Call gdk_x11_window_lookup_for_display.
9541 (xg_set_widget_bg): New function.
9542 (delete_cb): New function.
9543 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9544 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9545 (xg_set_background_color): Call xg_set_widget_bg.
9546 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9547 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9548 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9549 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9551 (update_frame_tool_bar): Call gtk_widget_hide.
9552 (xg_initialize): Use GDK_KEY_g.
9554 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9556 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9558 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9559 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9560 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9562 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9564 * w32xfns.c (select_palette): Check success of RealizePalette against
9565 GDI_ERROR, not zero.
9567 See ChangeLog.11 for earlier changes.
9573 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9575 This file is part of GNU Emacs.
9577 GNU Emacs is free software: you can redistribute it and/or modify
9578 it under the terms of the GNU General Public License as published by
9579 the Free Software Foundation, either version 3 of the License, or
9580 (at your option) any later version.
9582 GNU Emacs is distributed in the hope that it will be useful,
9583 but WITHOUT ANY WARRANTY; without even the implied warranty of
9584 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9585 GNU General Public License for more details.
9587 You should have received a copy of the GNU General Public License
9588 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.