1 2012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
3 Use INTERNAL_FIELD for symbols.
4 * lisp.h (SVAR): New macro. Adjust users.
5 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
6 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
8 2012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
10 Use INTERNAL_FIELD for processes.
11 * process.h (PVAR): New macro. Adjust style.
12 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
13 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
15 2012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
17 Use INTERNAL_FIELD for windows.
18 * window.h (WVAR): New macro.
19 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
20 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
21 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
22 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
23 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
24 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
26 2012-08-01 Paul Eggert <eggert@cs.ucla.edu>
28 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
30 2012-08-01 Glenn Morris <rgm@gnu.org>
32 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
35 2012-08-01 Juanma Barranquero <lekktu@gmail.com>
37 * makefile.w32-in (CONFIG_H): Update dependencies.
38 (CONF_POST_H): New macro.
40 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
42 2012-07-31 Glenn Morris <rgm@gnu.org>
44 * Makefile.in (S_FILE): No longer set by configure.
46 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
48 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
50 * process.h (NULL_DEVICE):
52 * editfns.c (USER_FULL_NAME): Let configure set them.
54 * s/README, s/template.h: Remove files.
56 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
58 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
61 2012-07-31 Eli Zaretskii <eliz@gnu.org>
63 * .gdbinit (xframe): Adapt to introduction of FVAR and the
64 resulting renaming of 'struct frame' members.
66 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
68 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
69 after introduction of FVAR.
71 2012-07-31 Jan Djärv <jan.h.d@swipnet.se>
73 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
75 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
76 instead of compositeToPoint.
77 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
79 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
81 2012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
83 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
84 * lisp.h (INTERNAL_FIELD): New macro.
85 * buffer.h (BUFFER_INTERNAL_FIELD): Removed.
86 (BVAR): Change to use INTERNAL_FIELD.
87 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
88 (KVAR): Change to use INTERNAL_FIELD.
89 * frame.h (FVAR): New macro.
90 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
91 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
92 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
93 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
94 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
96 2012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
98 Miscellaneous fixes for non-default X toolkits.
99 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
100 * xterm.c (x_frame_of_widget): Remove redundant prototype.
101 Move under #ifdef USE_LUCID.
102 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
103 definition and usage to avoid warnings.
105 2012-07-31 Jan Djärv <jan.h.d@swipnet.se>
107 * nsterm.m (openFiles): Fix previous checkin.
109 2012-07-31 Paul Eggert <eggert@cs.ucla.edu>
111 * indent.c (compute_motion): Remove unused local.
113 2012-07-31 Glenn Morris <rgm@gnu.org>
115 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
117 * conf_post.h [USG5_4]:
118 Move remaining contents of s/usg5-4-common.h here.
119 * s/usg5-4-common.h: Remove file.
121 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
122 * s/irix6-5.h: Remove file.
124 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
125 * s/darwin.h: Remove file.
127 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
128 * s/hpux10-20.h: Remove file, which is now empty.
130 2012-07-30 Glenn Morris <rgm@gnu.org>
132 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
133 * Makefile.in (config_h): Add conf_post.h.
134 * makefile.w32-in (CONFIG_H): Add conf_post.h.
136 2012-07-30 Jan Djärv <jan.h.d@swipnet.se>
138 * nsterm.m (ns_do_open_file): New variable.
139 (ns_term_init): Set ns_do_open_file to YES after run returns.
140 (openFile, openTempFile, openFileWithoutUI, openFiles): Open
141 files only if ns_do_open_file.
143 2012-07-30 Paul Eggert <eggert@cs.ucla.edu>
145 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
146 This no-op macro hasn't been needed for many years.
147 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
149 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
150 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
151 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
152 gdb_make_enums_visible.
153 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
154 (DIRECTORY_SEP): Now a constant, not a macro.
156 2012-07-30 Eli Zaretskii <eliz@gnu.org>
158 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
159 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
161 * w32term.c <w32_keyboard_codepage>: Renamed from
162 keyboard_codepage and now external. All users changed.
164 * w32term.h: Add declaration of w32_keyboard_codepage.
166 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
167 the codepage to translate keys to Unicode. If this argument is
168 -1, use the value returned by GetConsoleCP. All callers changed.
170 2012-07-30 Paul Eggert <eggert@cs.ucla.edu>
172 Update .PHONY listings in makefiles.
173 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
174 bootstrap-clean, distclean, maintainer-clean, versioclean,
177 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
178 This is a bit clearer. Fix some commentary typos.
180 2012-07-30 Glenn Morris <rgm@gnu.org>
182 * s/netbsd.h: Let configure include signal.h if needed.
183 Remove file, which is now empty.
185 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
186 Let configure set them.
187 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
188 No more need to undefine.
190 2012-07-30 Andreas Schwab <schwab@linux-m68k.org>
192 * keymap.c (Fkey_description): Don't remove 0x80 bit from
193 non-single-byte char when adding meta modifier. (Bug#12090)
195 2012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
197 Convert safe_call to use variable number of arguments.
198 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
199 (safe_call2): Fix comment.
200 * lisp.h (safe_call): Adjust prototype.
201 * coding.c (encode_coding_object): Change to use safe_call2.
202 * xfaces.c (merge_face_heights): Change to use safe_call1.
204 2012-07-30 Glenn Morris <rgm@gnu.org>
206 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
207 does that unconditionally. Remove file, which is now empty.
209 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
212 2012-07-30 Paul Eggert <eggert@cs.ucla.edu>
214 Export to GDB most of lisp.h's remaining object-like macros.
215 * lisp.h (min, max): Move earlier, because they're used earlier now.
216 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
217 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
218 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
219 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
220 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
221 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
222 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
223 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
224 Now constants, for GDB. They need not be macros.
225 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
226 Now constants, for GDB, as well as macros, for static initializers.
227 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
228 Move to after the definition of struct Lisp_Char_Table,
229 since the former now needs that type defined.
230 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
231 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
232 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
233 New enums, for gdb_make_enums_visible.
234 (GLYPH_MODE_LINE_FACE): Remove; unused.
235 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
236 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
237 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
238 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
239 enum maxargs, enum MAX_ALLOCA.
240 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
241 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
242 no longer needed, now that they are done in lisp.h.
244 2012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
246 Cleanup string bytes checking.
247 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
248 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
249 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
250 (check_sblock, compact_small_strings): Simplify.
252 2012-07-29 Paul Eggert <eggert@cs.ucla.edu>
254 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
255 These macros are confusing and no longer need to be defined, as
256 the enum values now suffice. All uses replaced with definiens.
257 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
259 2012-07-29 Juanma Barranquero <lekktu@gmail.com>
261 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
262 ($(BLD)/w32console.$(O)): Update dependencies.
264 2012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
266 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
267 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
269 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
271 2012-07-29 Jan Djärv <jan.h.d@swipnet.se>
273 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
274 setting sitelisp (Bug#12010).
276 2012-07-29 Eli Zaretskii <eliz@gnu.org>
278 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
280 * w32heap.c (cache_system_info):
281 * w32.c (sys_rename):
282 * w32proc.c (find_child_console, sys_kill): All users changed.
284 2012-07-29 Paul Eggert <eggert@cs.ucla.edu>
286 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
288 2012-07-29 Eli Zaretskii <eliz@gnu.org>
290 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
292 2012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
294 Cleanup statistics calculation in Fgarbage_collect.
295 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
296 zombies percentage calculation. Simplify elapsed time calculation.
298 2012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
300 Generalize marker debugging code under MARKER_DEBUG and use eassert.
301 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
302 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
303 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
304 (replace_range, replace_range_2, del_range_2): Change to eassert.
305 * marker.c (byte_char_debug_check): Adjust style.
307 2012-07-29 Paul Eggert <eggert@cs.ucla.edu>
309 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
310 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
311 long-ago-commented-out code that talks about "WIN32".
312 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
315 2012-07-28 Paul Eggert <eggert@cs.ucla.edu>
317 Use Gnulib stdalign module (Bug#9772, Bug#9960).
318 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
319 Simplify by using alignof.
320 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
321 * lisp.h: Include <stdalign.h>.
322 (GCALIGNMENT): New macro and constant.
323 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
324 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
325 (stdalign): New macro, if not already defined.
327 2012-07-28 Eli Zaretskii <eliz@gnu.org>
329 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
330 * w32inevt.c: Include w32inevt.h.
331 (w32_read_console_input): New inline function, calls either
332 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
333 w32_console_unicode_input.
334 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
335 (w32_kbd_patch_key, key_event): Use the codepage returned by
336 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
337 (key_event): use uChar.UnicodeChar only if
338 w32_console_unicode_input is non-zero.
340 * w32console.c: Include w32heap.h.
341 <w32_console_unicode_input>: New global variable.
342 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
343 family of Windows, zero otherwise.
345 * w32inevt.h: Declare w32_console_unicode_input.
347 * xdisp.c (init_iterator): Don't reference tip_frame in a build
348 --without-x. (Bug#11742)
350 2012-07-27 Paul Eggert <eggert@cs.ucla.edu>
352 Adjust GDB to reflect pvec_type changes (Bug#12036).
353 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
354 2012-07-04 changes to pseudovector representation. Problem
355 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
357 2012-07-27 Michael Albinus <michael.albinus@gmx.de>
359 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
361 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
363 2012-07-27 Eli Zaretskii <eliz@gnu.org>
365 * alloc.c (listn): Fix the order the arguments are consed onto the
368 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
369 enumeration constants, as PURE and HEAP are too general, and clash
370 with other headers and sources, such as gmalloc.c and the
371 MS-Windows system headers. All users changed.
373 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
375 Revert last save_excursion_save and save_excursion_restore changes.
376 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
377 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
379 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
381 Fix recently-introduced typos in Windows port.
382 Reported by Martin Rudalics <rudalics@gmx.at>.
383 * w32.c (init_environment): Replace comma with semicolon.
384 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
386 2012-07-27 Paul Eggert <eggert@cs.ucla.edu>
388 Improve GDB symbol export (Bug#12036).
389 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
390 arms of an 'if', not using conditional expressions; otherwise GDB
391 complains about the types in the unevaluated arm when the argument
392 is an integer literal.
393 (xgetint): Simplify expression.
394 * alloc.c (gdb_make_enums_visible): New constant. This ports to
395 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
396 Zaretskii in <http://bugs.gnu.org/12036#13>.
397 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
398 needed now that we have gdb_make_enums_visible.
399 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
400 (enum enum_USE_LSB_TAG):
401 New enum types, packaging up enums that need to be exported to GDB.
403 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
405 Utility function to make a list from specified amount of objects.
406 * lisp.h (enum constype): New datatype.
407 (listn): New prototype.
408 * alloc.c (listn): New function.
409 (Fmemory_use_count, syms_of_alloc): Use it.
410 * buffer.c (syms_of_buffer): Likewise.
411 * callint.c (syms_of_callint): Likewise.
412 * charset.c (define_charset_internal): Likewise.
413 * coding.c (syms_of_coding): Likewise.
414 * keymap.c (syms_of_keymap): Likewise.
415 * search.c (syms_of_search): Likewise.
416 * syntax.c (syms_of_syntax): Likewise.
417 * w32.c (init_environment): Likewise.
418 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
419 * xdisp.c (syms_of_xdisp): Likewise.
420 * xfns.c (syms_of_xfns): Likewise.
422 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
424 Fast save_excursion_save and save_excursion_restore.
425 * lisp.h (struct Lisp_Excursion): New data type.
426 (PVEC_EXCURSION): New pseudovector type.
427 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
428 to deal with it. Adjust comments.
429 (init_marker, attach_marker): New prototype.
430 (unchain_marker): Adjust prototype.
431 * marker.c (attach_marker): Change to global.
432 (init_marker): New function.
433 * alloc.c (Fmake_marker, build_marker): Use it.
434 (build_marker): More easserts.
435 (mark_object): Handle struct Lisp_Excursion.
436 * editfns.c (save_excursion_save, save_excursion_restore):
437 Reimplement to use struct Lisp_Excursion. Add comments.
439 2012-07-26 Paul Eggert <eggert@cs.ucla.edu>
441 Fix export of symbols to GDB (Bug#12036).
442 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
443 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
444 emacs.c, as this is a more-suitable home. Had this been done earlier
445 the fix for 12036 would have avoided some of the problems noted in
446 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
447 would have been more obvious.
448 * emacs.c: Do not include <verify.h>; no longer needed.
449 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
450 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
451 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
452 Remove; now done in lisp.h.
453 * lisp.h (PUBLISH_TO_GDB): New macro.
454 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
455 (DATA_SEG_BITS): Use it.
456 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
457 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
458 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
459 not be usable in #if. This simplifies things.
461 2012-07-26 Juanma Barranquero <lekktu@gmail.com>
463 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
465 2012-07-26 Paul Eggert <eggert@cs.ucla.edu>
467 Simplify export of symbols to GDB (Bug#12036).
468 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
469 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
470 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
471 Adjust to changes in lisp.h and emacs.c, by using
472 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
473 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
474 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
475 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
476 instead of gdb_valbits.
477 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
478 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
479 instead of gdb_array_mark_flag.
480 (xboolvector): Get size from $->size, not $->header.size.
481 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
482 (xreload, hook-run, hookpost-run): Remove.
483 * emacs.c: Include <verify.h>.
484 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
485 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
487 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
488 (gdb_USE_LSB_TAG): New enum constants.
489 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
490 Also define these as enum constants, so they're visible to GDB.
491 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
492 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
493 as constants, so they're visible to GDB.
494 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
495 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
496 Now enum constants, not macros, so they're visible to GDB.
497 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
498 more convenient now. All uses changed.
499 (VALMASK) [USE_LSB_TAG]: Also define in this case.
500 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
502 2012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
504 Explicitly free restriction data that are not needed anymore.
505 * editfns.c (save_restriction_restore): Free restriction data.
507 2012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
509 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
510 add argument, tune behavior, and adjust all callers.
512 2012-07-25 Paul Eggert <eggert@cs.ucla.edu>
514 Use typedef for EMACS_INT, EMACS_UINT.
515 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
516 than macros. This simplifies debugging in the usual case, since
517 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
518 and it allows expressions involving EMACS_INT casts.
519 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
521 2012-07-25 Jan Djärv <jan.h.d@swipnet.se>
523 * nsterm.m (ns_read_socket): Return early if there is a modal
526 2012-07-25 Martin Rudalics <rudalics@gmx.at>
528 * frame.c (Fredirect_frame_focus): In doc-string don't mention
529 that FOCUS-FRAME can be omitted.
531 2012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
533 Adjust buffer text indirection counters at the end of Fkill_buffer.
534 * buffer.c (Fkill_buffer): Adjust indirection counters when the
535 buffer is definitely dead. This should really fix an issue reported
536 by Christoph Scholtes again. (Bug#12007).
537 (init_buffer_once): Initialize indirection counters of
538 buffer_defaults and buffer_local_symbols (for sanity and safety).
540 2012-07-24 Eli Zaretskii <eliz@gnu.org>
542 * xdisp.c (init_iterator): Don't compute dimensions of truncation
543 and continuation glyphs on tooltip frames, leave them at zero.
544 Avoids continued lines in tooltips. (Bug#11832)
546 2012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
548 Simplify copy_overlay.
549 * buffer.c (copy_overlay): Simplify. Use build_marker.
550 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
552 2012-07-23 Eli Zaretskii <eliz@gnu.org>
554 * print.c (print_object): Don't crash when a frame's name is nil
555 or invalid. (Bug#12025)
557 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
558 it signals an error when a tooltip frame is being created.
560 2012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
562 Cleanup miscellaneous objects allocation and initialization.
563 * alloc.c (allocate_misc): Change to static. Add argument to
564 specify the subtype. Adjust comment and users.
565 (build_overlay): New function.
566 * buffer.c (copy_overlays, Fmake_overlay): Use it.
567 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
568 (allocate_misc): Remove prototype.
569 (build_overlay): Add prototype.
571 2012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
573 Swap buffer text indirection counters in Fbuffer_swap_text.
574 * buffer.c (Fbuffer_swap_text): Swap indirections too.
575 This avoids crash reported by Christoph Scholtes at
576 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
578 2012-07-22 Jan Djärv <jan.h.d@swipnet.se>
580 * nsmenu.m (Popdown_data): New struct.
581 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
583 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
584 (initWithContentRect): Make imgView and contentView non-static
585 and autorelease them. Also autorelease img and matrix (Bug#12005).
586 (dealloc): Remove (Bug#12005).
588 2012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
590 Adjust consing_since_gc when objects are explicitly freed.
591 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
592 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
593 (free_cons, free_misc): Subtract object size from consing_since_gc.
595 2012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
597 Simplify and cleanup markers positioning code.
598 * marker.c (attach_marker): More useful eassert.
599 (live_buffer, set_marker_internal): New function.
600 (Fset_marker, set_marker_restricted): Use set_marker_internal.
601 (set_marker_both, set_marker_restricted_both): Use live_buffer.
603 2012-07-22 Paul Eggert <eggert@cs.ucla.edu>
605 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
606 as it's limited by the amount of memory, not by INT_MAX.
608 2012-07-21 Eli Zaretskii <eliz@gnu.org>
610 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
611 in special-event-map. See the discussion at
612 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
615 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
616 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
617 Fabrice Popineau <fabrice.popineau@supelec.fr>.
619 2012-07-21 Jan Djärv <jan.h.d@swipnet.se>
621 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
622 (conversationIdentifier): Return value is NSInteger.
623 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
625 2012-07-21 Chong Yidong <cyd@gnu.org>
627 * window.c (decode_any_window): Signal an error if the window is
628 on a dead frame (Bug#11984).
630 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
632 Add indirection counting to speed up Fkill_buffer.
633 * buffer.h (struct buffer): New member.
634 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
635 (Fmake_indirect_buffer): Set indirection counter to -1, increment
636 base buffer indirection counter.
637 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
638 (Fkill_buffer): Adjust indirection counters as needed, don't walk
639 through buffer list if indirection counter is 0.
641 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
643 Extend the value returned by Fgarbage_collect with heap statistics.
644 * alloc.c (Qheap): New symbol.
645 (syms_of_alloc): DEFSYM it.
646 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
647 (Fmemory_free): Remove.
648 (syms_of_alloc): Don't defsubr it.
649 * buffer.c (Fcompact_buffer): Remove.
650 (syms_of_buffer): Don't defsubr it.
652 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
654 Make maybe_gc inline.
655 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
656 * lisp.h (consing_since_gc, gc_relative_threshold)
657 (memory_full_cons_threshold): Revert declaration.
658 (maybe_gc): Remove prototype, define as inline.
659 * alloc.c: Remove old commented-out code.
660 (consing_since_gc, gc_relative_threshold)
661 (memory_full_cons_threshold): Revert to global.
664 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
666 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
667 * lisp.h (build_unibyte_string): New function.
668 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
669 * sysdep.c, w32fns.c, xfns.c: Use it.
670 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
671 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
672 Adjust users accordingly.
673 * font.h (font_open_by_name): Adjust prototype.
675 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
677 Cleanup calls to Fgarbage_collect.
678 * lisp.h (maybe_gc): New prototype.
679 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
681 * alloc.c (maybe_gc): New function.
682 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
684 * bytecode.c (MAYBE_GC): Use maybe_gc.
685 * eval.c (eval_sub, Ffuncall): Likewise.
686 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
687 to avoid dependency from auto-save feature.
689 2012-07-19 Paul Eggert <eggert@cs.ucla.edu>
691 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
692 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
693 'for_each_per_buffer_object_at'.
694 All uses changed. It's better to use upper-case for macros that
695 cannot be implemented as functions, to give the reader a clue
696 that they're special.
698 2012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
700 * alloc.c (Fgarbage_collect): Tweak docstring.
702 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
704 Tweak the value returned from Fgarbage_collect again.
705 * alloc.c (Fgarbage_collect): New return value, as confirmed in
706 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
707 Adjust documentation.
708 (total_vector_bytes): Rename to total_vector_slots, adjust
710 (total_free_vector_bytes): Rename to total_free_vector_slots,
712 (Qstring_bytes, Qvector_slots): New symbols.
713 (syms_of_alloc): DEFSYM them.
715 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
717 Buffer compaction primitive which may be used from Lisp.
718 * buffer.c (compact_buffer, Fcompact_buffer): New function.
719 (syms_of_buffer): Register Fcompact_buffer.
720 * alloc.c (Fgarbage_collect): Use compact_buffer.
721 * buffer.h (compact_buffer): New prototype.
722 (struct buffer_text): New member.
724 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
726 New macro to iterate over all buffers, miscellaneous cleanups.
727 * lisp.h (all_buffers): Remove declaration.
728 * buffer.h (all_buffers): Add declaration, with comment.
729 (for_each_buffer): New macro.
730 * alloc.c (Fgarbage_collect, mark_object): Use it.
731 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
732 (init_buffer): Likewise.
733 * data.c (Fset_default): Likewise.
734 * coding.c (code_conversion_restore): Remove redundant check
736 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
738 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
740 Fix bug that created negative-length intervals.
741 * intervals.c (merge_interval_right, merge_interval_left):
742 Do not zero out this interval if it is absorbed by its children,
743 as this interval's total length doesn't change in that case. See
744 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
746 2012-07-18 Paul Eggert <eggert@cs.ucla.edu>
748 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
749 when invoking (make-bool-vector N t) and N is a positive
750 multiple of 8 -- the last 8 bits were mistakenly cleared.
752 Remove some struct layout assumptions in bool vectors.
753 * alloc.c (bool_header_size): New constant.
754 (header_size, word_size): Move earlier, as they're now used earlier.
755 Use 'word_size' in a few more places, where it's appropriate.
756 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
757 padding before the data member of a bool vector.
758 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
759 than doing the check by hand with an abort ().
761 2012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
763 * eval.c (Fdefvar): Don't check constants since we only set the var if
764 it's not yet defined anyway (bug#11904).
766 * lisp.h (last_undo_boundary): Declare new var.
767 * keyboard.c (command_loop_1): Set it.
768 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
769 were auto-added by the command loop (bug#11774).
771 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
773 * w32font.c (Qsymbol): Remove local definition.
774 (syms_of_w32font): Don't DEFSYM it.
776 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
778 Fix sweep_vectors to handle large bool vectors correctly.
779 * alloc.c (sweep_vectors): Account total_vector_bytes for
780 bool vectors larger than VBLOCK_BYTES_MAX.
782 2012-07-18 Chong Yidong <cyd@gnu.org>
784 * frame.c (x_set_frame_parameters): Revert bogus change introduced
785 in 2012-05-25 commit by Paul Eggert (Bug#11738).
787 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
789 Return more descriptive data from Fgarbage_collect.
790 Suggested by Stefan Monnier in
791 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
792 * alloc.c (bounded_number): New function.
793 (total_buffers, total_vectors): New variable.
794 (total_string_size): Rename to total_string_bytes, adjust users.
795 (total_vector_size): Rename to total_vector_bytes, adjust users.
796 (sweep_vectors): Account total_vectors and total_vector_bytes.
797 (Fgarbage_collect): New return value. Adjust documentation.
798 (gc_sweep): Account total_buffers.
799 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
800 (VECTOR_SIZE): Remove.
801 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
802 (Qinterval, Qmisc): New symbols.
803 (syms_of_data): Initialize them.
804 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
805 (Qcons, Qbuffer): New declarations.
807 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
809 * alloc.c (Fmemory_free): Account for memory-free's own storage.
810 Round up, not down. Improve doc.
812 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
814 Restore old code in allocate_string_data to avoid Faset breakage.
815 Reported by Julien Danjou <julien@danjou.info> in
816 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
817 * alloc.c (allocate_string_data): Restore old code with minor
818 adjustments, fix comment to explain this subtle issue.
820 2012-07-17 Eli Zaretskii <eliz@gnu.org>
822 Remove FILE_SYSTEM_CASE.
823 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
825 * fileio.c (FILE_SYSTEM_CASE): Don't define.
826 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
827 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
828 call-process-region passes it through expand-file-name.
830 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
832 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
834 Fix crash when creating indirect buffer (Bug#11917)
835 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
836 Don't handle unbound variables specially if non-zero.
837 (Fbuffer_local_variables): Pass zero.
838 (clone_per_buffer_values): Pass non-zero.
840 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
842 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
843 to make the loop interruptible.
845 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
847 * gnutls.c (emacs_gnutls_handshake): Only retry if
848 GNUTLS_E_INTERRUPTED.
850 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
852 Cleanup and convert miscellaneous checks to eassert.
853 * alloc.c (mark_interval): Fix comment, partially rephrase
854 old comment from intervals.h (see below).
855 * intervals.c (find_interval, adjust_intervals_for_insertion)
856 (delete_interval, adjust_intervals_for_deletion)
857 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
859 (adjust_intervals_for_insertion, make_new_interval):
860 Remove obsolete and unused code.
861 * intervals.h (struct interval): Remove obsolete comment.
862 * textprotp.c (erase_properties): Remove unused code.
863 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
864 (Fremove_list_of_text_properties): Convert to eassert.
866 2012-07-17 Chong Yidong <cyd@gnu.org>
868 * editfns.c (Finsert_char): Doc fix.
870 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
872 Fix previous change to make Fmemory_free always accurate.
873 * alloc.c (make_interval): Update total_free_intervals.
874 (make_float): Likewise for total_free_floats.
875 (free_cons, Fcons): Likewise for total_free_conses.
876 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
877 Likewise for total_free_vector_bytes.
878 (Fmake_symbol): Likewise for total_free_symbols.
879 (bytes_free): Remove.
881 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
883 Simple free memory accounting feature.
884 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
885 (sweep_vectors): Accumulate size of free vectors.
886 (Fgarbage_collect): Setup bytes_free.
887 (Fmemory_free): New function.
888 (syms_of_alloc): Register it.
890 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
892 Cleanup overlays checking.
893 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
894 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
895 eassert and OVERLAYP.
896 (sort_overlays): Change to use OVERLAYP.
898 2012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
900 * editfns.c (Finsert_char): Make it interactive, and make the
901 second arg optional. Copy interactive spec and docstring from
904 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
906 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
907 Unlike the other wrapped functions, fabs has an unspecified
910 2012-07-16 Jan Djärv <jan.h.d@swipnet.se>
912 * nsterm.m (keyDown): Interpret flags without left/right bits
913 as the left key (Bug#11670).
915 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
917 Remove empty and useless init functions.
918 * lisp.h (init_character_once, init_fns, init_image)
919 (init_filelock, init_sound): Remove prototype.
920 * character.c (init_character_once): Remove.
921 * filelock.c (init_filelock): Likewise.
922 * fns.c (init_fns): Likewise.
923 * image.c (init_image): Likewise.
924 * sound.c (init_sound): Likewise.
925 * emacs.c (main): Adjust accordingly.
927 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
929 * gtkutil.h: Tiny cleanups.
930 (use_old_gtk_file_dialog): Remove useless declaration.
931 (xg_uses_old_file_dialog): Add suggested const attribute.
933 2012-07-15 Eli Zaretskii <eliz@gnu.org>
935 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
936 (bidi_paragraph_init): Use it to limit search forward for a strong
937 directional character in abnormally large paragraphs full of
938 neutral or weak characters. (Bug#11943)
940 2012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
942 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
943 the toolbar (Bug#9451).
944 (xg_make_tool_item): Give the widget event box a transparent
947 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
949 Cleanup basic allocation variables and functions.
950 * alloc.c (ignore_warnings, init_intervals, init_float)
951 (init_cons, init_symbol, init_marker): Remove.
952 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
953 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
954 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
955 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
956 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
957 (staticidx, init_alloc_once, init_strings, free_ablock):
958 Remove redundant initialization.
959 * fns.c (init_weak_hash_tables): Remove.
960 * lisp.h (init_weak_hash_tables): Remove prototype.
962 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
964 Use zero_vector where appropriate.
965 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
967 * lisp.h (zero_vector): New declaration.
968 * font.c (null_vector): Remove.
969 (syms_of_font): Remove initialization and staticpro.
970 (font_list_entities, font_find_for_lface): Change to use zero_vector.
971 * keymap.c (Faccessible_keymaps): Likewise.
973 2012-07-15 Leo Liu <sdl.web@gmail.com>
975 * fringe.c: Fix typo in comments.
977 2012-07-14 Leo Liu <sdl.web@gmail.com>
979 * fringe.c: Add a new bitmap exclamation-mark.
981 2012-07-14 Eli Zaretskii <eliz@gnu.org>
983 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
985 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
986 (HAVE_MENUS): Don't define, defined by editing config.in with
988 (GMALLOC_INHIBIT_VALLOC): Don't define.
989 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
991 2012-07-14 Juanma Barranquero <lekktu@gmail.com>
993 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
995 2012-07-14 Glenn Morris <rgm@gnu.org>
997 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
998 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
999 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
1001 2012-07-13 Glenn Morris <rgm@gnu.org>
1003 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
1005 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
1006 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
1008 2012-07-13 Jan Djärv <jan.h.d@swipnet.se>
1010 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
1011 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
1012 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
1013 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
1015 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
1016 as boolean expression.
1017 (x_set_window_size): Remove unused variable toolbar.
1018 (ns_get_color_default, ns_mod_to_lisp): Remove.
1019 (ns_mouse_position): Remove unused variables xchar and ychar.
1020 (ns_compute_glyph_string_overhangs): Remove unused variable face.
1021 (ns_set_vertical_scroll_bar): Remove unused variable count.
1022 (ns_delete_terminal): Remove unused variable i.
1023 (ns_term_init): Remove unused variables r, g and b.
1024 (mouseDown): Remove unused variable window.
1025 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
1026 (initFrameFromEmacs): Remove unused variable vbextra.
1027 (mouseEntered): Remove unused variables p and dpyinfo.
1028 (mouseExited): Remove unused variables p and r.
1029 (ns_define_frame_cursor, ns_clear_frame_area)
1030 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1031 (menuDown): Assign [sender tag] to variable and cast the variable.
1033 * nsterm.h (menuDown): Add id as type to argument sender.
1034 (ns_display_info_for_name): Add Lisp_Object argument.
1035 (ns_term_init): Add Lisp_Object argument.
1036 (ns_map_event_to_object): Add void argument.
1037 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1038 prototype with arguments and only declare if __OBJC__.
1039 (nxatoms_of_nsselect): Add void argument.
1040 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1041 (ns_alloc_autorelease_pool): Add void argument.
1042 (ns_release_autorelease_pool): Add void* argument.
1043 (ns_get_defaults_value): Add const char* argument.
1045 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1046 (initFromContents): Use SSDATA where appropriate.
1047 (ns_update_menubar): Add braces to ambigous if-else.
1048 (initWithTitle): Put () around assignment in if statement.
1049 (ns_menu_show): Remove unused variables window and keymap.
1050 (update_frame_tool_bar): Remove unused variable selected_p.
1051 (initWithContentRect): Remove unused variable this_cmd_name.
1053 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1055 (setXBMColor): Remove unused variable len.
1056 (setPixmapData): Put () around assignment in loop statement.
1058 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1059 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1061 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1062 around assignment in loop statement.
1063 (nsfont_open): Remove unused variable i.
1064 (nsfont_open): Remove unused variable len.
1065 (nsfont_draw): Remove unused variable cs.
1067 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1068 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1069 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1070 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1071 (Fns_font_name, Fns_perform_service)
1072 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1073 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1074 (ns_set_name): Remove unused variable view.
1075 (x_set_menu_bar_lines): Remove unused variable olines.
1076 (x_set_tool_bar_lines): Remove unused variable root_window.
1077 (Fns_list_colors): Put () around assignment in while statement.
1078 (Fns_perform_service): Remove unused variable len.
1079 (Fns_display_usable_bounds): Remove unused variable top.
1080 (syms_of_nsfns): Remove unused variable i.
1082 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1085 2012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
1087 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1088 and free it with DestroyExceptionInfo (Bug#11558).
1090 2012-07-13 Juanma Barranquero <lekktu@gmail.com>
1092 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1093 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1094 Set here, not in nt/config.nt.
1096 2012-07-13 Eli Zaretskii <eliz@gnu.org>
1098 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1099 cursor overflow into the last glyph on display line when the right
1100 fringe is off. (Bug#11832)
1102 2012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1104 * xdisp.c (produce_special_glyphs): Now static.
1105 * dispextern.h (produce_special_glyphs): Remove decl.
1107 2012-07-13 Glenn Morris <rgm@gnu.org>
1109 * s/bsd-common.h, s/cygwin.h: Remove empty files.
1110 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1112 * s/usg5-4-common.h (USG, USG5):
1113 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1114 * s/sol2-6.h (SOLARIS2):
1115 * s/irix6-5.h (IRIX6_5):
1116 * s/hpux10-20.h (USG, USG5, HPUX):
1117 * s/gnu-linux.h (USG, GNU_LINUX):
1118 * s/freebsd.h (BSD_SYSTEM):
1119 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1120 * s/cygwin.h (CYGWIN):
1121 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1122 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1124 2012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
1126 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
1128 2012-07-13 Glenn Morris <rgm@gnu.org>
1130 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1132 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1134 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1135 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1137 2012-07-12 Glenn Morris <rgm@gnu.org>
1139 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
1141 * process.c (init_process_emacs): Rename from init_process.
1142 The old name is also the name of a Mach system call.
1143 * lisp.h, emacs.c: Update for this name change.
1144 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1147 2012-07-12 Eli Zaretskii <eliz@gnu.org>
1149 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1150 memmove call that removes glyphs covered by the left truncation
1151 glyph. Improve commentary.
1152 (display_line): Fix display of continuation glyphs on GUI frames
1153 when the right fringe is turned off and variable-size fonts are
1154 used in the window. Move the code that appends a stretch glyph to
1155 produce_special_glyphs, so that it could be used for truncation
1156 and continuation glyphs alike.
1157 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1158 glyph of a suitably computed width, to align the special glyphs at
1159 the window margin. Code moved from display_line. (Bug#11832)
1161 2012-07-12 Glenn Morris <rgm@gnu.org>
1163 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1165 * s/gnu-linux.h, s/hpux10-20.h:
1166 Do not unconditionally define HAVE_XRMSETDATABASE.
1168 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1170 2012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1172 Fix typos that broke OS X build.
1173 Reported by Randal L. Schwartz in
1174 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1175 * nsterm.m (ns_timeout): Add missing local decl.
1176 (ns_get_color): snprintf -> sprintf, to fix typo.
1178 2012-07-12 Glenn Morris <rgm@gnu.org>
1180 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1181 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1182 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1183 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1185 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1186 Move PTY_OPEN to configure.
1188 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1189 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1190 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1192 2012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1194 Use empty_unibyte_string where applicable.
1195 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1196 * lread.c (read1): Likewise.
1197 * xsettings.c (syms_of_xsettings): Likewise.
1199 2012-07-12 Glenn Morris <rgm@gnu.org>
1201 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1202 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
1203 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1204 * s/hpux10-20.h (RUN_TIME_REMAP):
1205 * s/bsd-common.h (TABDLY): Move to configure.
1207 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1209 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1211 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1212 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
1214 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
1216 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1217 * s/template.h: Move NARROWPROTO to configure.
1219 2012-07-11 Glenn Morris <rgm@gnu.org>
1221 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1222 unused since 2011-01-17 change to systty.h.
1224 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1225 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1226 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1228 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1230 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1232 2012-07-11 Glenn Morris <rgm@gnu.org>
1234 * s/darwin.h, s/gnu-linux.h, s/template.h:
1235 Move INTERRUPT_INPUT to configure.
1237 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1239 Minor adjustments to interning code.
1240 * lisp.h (intern, intern_c_string): Redefine as static inline
1241 wrappers for intern_1 and intern_c_string_1, respectively.
1242 (intern_1, intern_c_string_1): Rename prototypes.
1243 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1245 * font.c (font_intern_prop): Likewise. Adjust comment.
1246 * w32font.c (intern_font_name): Likewise.
1248 2012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1250 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1252 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1253 of Fcar/Fcdr if possible.
1254 * font.c (check_otf_features): Likewise.
1255 * fontset.c (Fnew_fontset): Likewise.
1256 * gnutls.c (Fgnutls_boot): Likewise.
1257 * minibuf.c (read_minibuf): Likewise.
1258 * msdos.c (IT_set_frame_parameters): Likewise.
1259 * xmenu.c (Fx_popup_dialog): Likewise.
1260 * w32menu.c (Fx_popup_dialog): Likewise.
1262 2012-07-11 Glenn Morris <rgm@gnu.org>
1264 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1265 since nothing has defined it on these platforms.
1267 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1268 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1270 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1271 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1272 Move CLASH_DETECTION to configure.
1274 * s/gnu.h: Remove file, which is now empty.
1276 * s/gnu.h, s/gnu-linux.h:
1277 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1279 2012-07-11 John Wiegley <johnw@newartisans.com>
1281 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1282 function attribute, so we only use it if it exists in the
1285 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1287 Avoid call to strlen in fast_c_string_match_ignore_case.
1288 * search.c (fast_c_string_match_ignore_case): Change to use
1289 length argument. Adjust users accordingly.
1290 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1292 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1294 Assume mkdir, rmdir.
1295 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1296 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1299 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1302 * s/hpux10-20.h (HAVE_PERROR): Remove.
1303 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1304 Remove dummy definition, as this problem was obsolete long ago.
1307 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1309 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1311 Avoid calls to strlen in font processing functions.
1312 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
1313 (font_open_by_name): Change to use length argument. Adjust
1315 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1317 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1318 Change to return ptrdiff_t.
1319 (xfont_list_pattern, xfont_match): Use length returned by
1320 xfont_decode_coding_xlfd.
1321 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1323 2012-07-11 Glenn Morris <rgm@gnu.org>
1325 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1326 Move DONT_REOPEN_PTY to configure.
1328 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1329 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1331 2012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1333 Remove "#define unix" that is no longer needed (Bug#11905).
1334 * s/aix4-2.h (unix): Remove; no longer needed.
1336 EMACS_TIME simplification (Bug#11875).
1337 This replaces macros (which typically do not work in GDB)
1338 with functions, typedefs and enums, making the code easier to debug.
1339 The functional style also makes code easier to read and maintain.
1340 * systime.h: Include <sys/time.h> on all hosts, not just if
1341 WINDOWSNT, since 'struct timeval' is needed in general.
1342 (EMACS_TIME): Now a typedef, not a macro.
1343 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1345 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1346 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1347 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1348 (EMACS_TIME_LE): Now functions, not macros.
1349 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1350 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1351 which are not functions. All uses rewritten to use:
1352 (make_emacs_time): New function.
1353 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1354 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1355 not functions. All uses rewritten to use the following, respectively:
1356 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1357 (add_emacs_time, sub_emacs_time): New functions.
1358 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
1359 * fileio.c (Fcopy_file):
1360 * xterm.c (XTflash): Get the current time closer to when it's used.
1361 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1363 * bytecode.c (targets): Suppress -Woverride-init warnings.
1365 Simplify by avoiding confusing use of strncpy etc.
1366 * doc.c (Fsnarf_documentation):
1367 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1368 * frame.c (Fmake_terminal_frame):
1369 * gtkutil.c (get_utf8_string):
1371 * nsmenu.m (ns_update_menubar):
1372 * regex.c (regerror):
1373 Prefer memcpy to strncpy and strncat when either will do.
1374 * fileio.c (Fsubstitute_in_file_name):
1375 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1376 (menu_separator_name_p):
1377 * nsmenu.m (ns_update_menubar):
1378 Prefer memcmp to strncmp when either will do.
1379 * nsterm.m: Include <ftoastr.h>.
1381 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1382 Prefer snprintf to strncpy.
1383 * nsterm.m (ns_term_init):
1384 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1385 * nsterm.m (ns_term_init):
1386 Avoid the need for strncpy, by using build_string or
1387 make_unibyte_string directly. Use dtoastr, not snprintf.
1388 * process.c (Fmake_network_process): Diagnose service names that
1389 are too long, rather than silently truncating them or creating
1390 non-null-terminated names.
1391 (Fnetwork_interface_info): Likewise, for interface names.
1392 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1393 Prefer sprintf to strncat.
1394 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1395 Prefer vsnprintf to vsprintf + strncpy.
1397 2012-07-10 Glenn Morris <rgm@gnu.org>
1399 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1400 Clarify fallback case.
1402 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1404 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1405 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1406 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
1407 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
1408 where argument type is known to be a Lisp_Cons.
1410 2012-07-10 Tom Tromey <tromey@redhat.com>
1412 * bytecode.c (BYTE_CODE_THREADED): New macro.
1413 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1414 (enum byte_code_op): New type.
1415 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1416 (exec_byte_code): Use them. Use token threading when applicable.
1418 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1420 Optimize pure C strings initialization.
1421 * lisp.h (make_pure_string): Fix prototype.
1422 (build_pure_c_string): New function, defined as static inline. This
1423 provides a better opportunity to optimize away calls to strlen when
1424 the function is called with compile-time constant argument.
1425 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1426 argument, adjust users accordingly. Use build_pure_c_string where
1428 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1429 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1430 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1432 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1434 Avoid calls to strlen in miscellaneous functions.
1435 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1436 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1437 * lread.c (openp): Likewise.
1439 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1441 Avoid calls to strlen in path processing functions.
1442 * fileio.c (file_name_as_directory): Add comment. Change to add
1443 srclen argument and return the length of result. Adjust users
1445 (directory_file_name): Fix comment. Change to add srclen argument,
1446 swap 1st and 2nd arguments to obey the common convention. Adjust
1448 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1450 2012-07-10 Glenn Morris <rgm@gnu.org>
1452 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1453 Move PENDING_OUTPUT_COUNT definition to configure.
1455 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1456 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1457 * s/gnu.h (DATA_START): Move definitions to configure.
1459 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1460 We include usg5-4-common.h, which defines them both.
1462 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1463 O_RDONLY already includes it).
1465 Stop ns builds setting the EMACSLOADPATH environment variable.
1466 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1467 Now it does not set EMACSLOADPATH, just returns the load-path string.
1468 * nsterm.h: Update accordingly.
1469 * lread.c [HAVE_NS]: Include nsterm.h.
1470 (init_lread) [HAVE_NS]: Use ns_load_path.
1471 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1473 2012-07-09 Glenn Morris <rgm@gnu.org>
1475 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1476 since the included bsd-common.h does so.
1478 Stop ns builds setting the EMACSPATH environment variable.
1479 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1480 (ns_init_paths): Do not set EMACSPATH.
1481 * nsterm.h (ns_exec_path): Add it.
1482 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1485 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1487 2012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1489 * process.c (wait_reading_process_output): 'waitchannels' was unset
1490 when read_kbd || !NILP (wait_for_cell); fix this.
1492 Add GCC-style 'const' attribute to functions that can use it.
1493 * character.h (char_resolve_modifier_mask):
1494 * keyboard.h (make_ctrl_char):
1495 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1496 (init_character_once, next_almost_prime, init_fns, init_image)
1497 (flush_pending_output, init_sound):
1498 * mem-limits.h (start_of_data):
1499 * menu.h (finish_menu_items):
1500 Add ATTRIBUTE_CONST.
1501 * emacs.c (DEFINE_DUMMY_FUNCTION):
1502 Declare the dummy function with ATTRIBUTE_CONST.
1503 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1504 Add decls with ATTRIBUTE_CONST.
1506 Minor improvements to make_formatted_string.
1507 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1508 where int is good enough, as vsprintf returns an int.
1509 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1511 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1513 Use make_formatted_string to avoid double length calculation.
1514 * lisp.h (make_formatted_string): New prototype.
1515 * alloc.c (make_formatted_string): New function.
1516 * buffer.c (Fgenerate_new_buffer_name): Use it.
1517 * dbus.c (syms_of_dbusbind): Likewise.
1518 * editfns.c (Fcurrent_time_zone): Likewise.
1519 * filelock.c (get_boot_time): Likewise.
1520 * frame.c (make_terminal_frame, set_term_frame_name)
1521 (x_report_frame_params): Likewise.
1522 * image.c (gs_load): Likewise.
1523 * minibuf.c (get_minibuffer): Likewise.
1524 * msdos.c (dos_set_window_size): Likewise.
1525 * process.c (make_process): Likewise.
1526 * xdisp.c (ensure_echo_area_buffers): Likewise.
1527 * xsettings.c (apply_xft_settings): Likewise.
1529 2012-07-09 Glenn Morris <rgm@gnu.org>
1531 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1532 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1533 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1534 * nsterm.h (ns_etc_directory): Add it.
1535 * callproc.c [HAVE_NS]: Include nsterm.h.
1536 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1538 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1540 Move marker debugging code under MARKER_DEBUG.
1541 * marker.c (MARKER_DEBUG): Move marker debugging code under
1542 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1543 for bootstrap with --enable-checking (~3x slowdown reported
1544 by Juanma Barranquero <lekktu@gmail.com>).
1545 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1547 2012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1549 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1550 See <http://bugs.gnu.org/11825#29>.
1552 2012-07-08 Eli Zaretskii <eliz@gnu.org>
1554 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1555 has no font, use the frame's font. (Bug#11813)
1556 (display_line): Add commentary about displaying truncation glyphs
1558 (produce_special_glyphs): Move here from term.c.
1560 * term.c (produce_special_glyphs): Move to xdisp.c.
1562 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1565 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1567 * xdisp.c (display_line): Avoid warning about implicit declaration
1570 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1572 * lisp.h: Remove empty conditional.
1574 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1576 * lread.c (load_path_check): Now static.
1578 Fix some minor --with-ns problems found by static checking.
1579 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1580 (x_set_font) [!HAVE_X_WINDOWS]:
1581 * image.c (xpm_load_image) [HAVE_NS]:
1582 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1583 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1584 Remove unused local.
1585 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1586 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1587 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1588 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1589 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1590 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1591 Fix pointer signedness problem.
1592 * xfaces.c (FRAME_X_FONT_TABLE):
1593 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1595 2012-07-07 Glenn Morris <rgm@gnu.org>
1597 * lread.c (load_path_check): New function, split from init_lread.
1598 (init_lread): Reorganize. Motivation:
1599 If EMACSLOADPATH is set, check/warn about that rather than the
1600 defaults, which we are not going to use. Hence we can remove
1601 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1602 Don't warn if site-lisp directories are missing.
1603 If not installed, start from a blank load-path, since
1604 PATH_LOADSEARCH refers to the eventual installation directories.
1606 2012-07-07 Eli Zaretskii <eliz@gnu.org>
1608 Support truncation and continuation glyphs on GUI frames, when
1609 fringes are disabled. (Bug#11832)
1610 * xdisp.c (init_iterator): Get dimensions of truncation and
1611 continuation glyphs even if on GUI frames. Adjust
1612 it->last_visible_x on GUI frames when the left or right fringes,
1613 or both, are absent.
1614 (start_display, move_it_in_display_line_to): Handle the case of a
1615 GUI frame without a fringe to display continuation or truncation
1617 (insert_left_trunc_glyphs): Support GUI frames: make sure
1618 truncation glyphs overwrite enough glyphs from the current line to
1619 have sufficient space in pixels.
1620 (display_line): Support truncation and continuation glyphs on GUI
1621 frames. If some spare pixels are left on the line after inserting
1622 the truncation glyphs, fill that space with a stretch glyph of a
1623 suitably computed width.
1625 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1626 produce_glyphs, to support GUI sessions.
1628 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1630 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1632 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1634 Do not require float-time's arg to fit in time_t (Bug#11825).
1635 This works better on hosts where time_t is unsigned, and where
1636 float-time is applied to the (negative) difference between two times.
1637 * editfns.c (decode_time_components): Last arg is now double *,
1638 not int *, and means to store all the result as a double, without
1639 worrying about whether the seconds part fits in time_t.
1640 All callers changed.
1641 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1642 All callers changed.
1643 (Ffloat_time): Do not fail merely because the specified time falls
1644 outside of time_t range.
1646 2012-07-07 Glenn Morris <rgm@gnu.org>
1648 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1649 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1650 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1652 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
1654 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1655 Update dependencies.
1657 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1659 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1661 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1662 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1663 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1664 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1665 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1666 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1668 * xfont.c (compare_font_names): Redo to omit the need for casts.
1670 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1672 * xfns.c (Fx_change_window_property): Doc fix.
1673 * w32fns.c (Fx_change_window_property): Doc fix.
1675 * w32fns.c (Fx_window_property): Accept the same arguments as the
1676 X Windows version. Doc fix.
1677 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1679 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
1680 Eli Zaretskii <eliz@gnu.org>
1682 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1683 Windows-specific code from nt/config.nt moved here.
1684 Obsolete settings removed.
1686 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1688 * process.c: Avoid unnecessary calls to gettime.
1689 (wait_reading_process_output): Don't get the time of day
1690 when gobbling data immediately and not waiting, as there's no need
1691 for it in that case. This removes a FIXME.
1693 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1695 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1696 is defined (Bug#11768).
1698 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1700 Fix marker debugging code.
1701 * marker.c (byte_char_debug_check): Do not perform the check
1702 if buffer is not multibyte.
1703 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1704 Call byte_char_debug_check with correct arguments.
1706 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1708 Compile marker debugging code only if ENABLE_CHECKING is defined.
1709 * marker.c (byte_char_debug_check, count_markers):
1710 Use only if ENABLE_CHECKING is defined.
1711 (byte_debug_flag): Remove.
1712 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1713 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1715 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1717 Avoid code repetition in marker-related functions.
1718 * marker.c (attach_marker): New function.
1719 (Fset_marker, set_marker_restricted, set_marker_both)
1720 (set_marker_restricted_both): Use it.
1721 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1722 Consistently rename charno to charpos.
1723 (marker_position): Add eassert.
1724 (marker_byte_position): Convert to eassert.
1726 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1728 Simplify list operations in unchain_overlay and unchain_marker.
1729 * buffer.c (unchain_overlay): Simplify. Add comment.
1730 * marker.c (unchain_marker): Simplify. Fix comments.
1732 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1734 Introduce fast path for the widely used marker operation.
1735 * alloc.c (build_marker): New function.
1736 * lisp.h (build_marker): New prototype.
1737 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1738 * composite.c (autocmp_chars): Likewise.
1739 * editfns.c (buildmark): Remove.
1740 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1741 (save_restriction_save): Use build_marker.
1742 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1743 * window.c (save_window_save): Likewise.
1745 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1747 Do not use Fdelete_overlay in delete_all_overlays
1748 to avoid redundant calls to unchain_overlay.
1749 * buffer.c (drop_overlay): New function.
1750 (delete_all_overlays, Fdelete_overlay): Use it.
1751 * minibuf.c (get_minibuffer): Fix comment.
1753 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1755 Port to OpenBSD 5.1 amd64.
1756 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1757 This is needed for OpenBSD, and should be harmless on all BSD systems.
1758 Also, include <sys/sysctl.h>, as it should be available on all
1759 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1760 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1761 use p_pid member, not kp_proc.pid.
1763 2012-07-06 Glenn Morris <rgm@gnu.org>
1765 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1767 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1769 More xmalloc and related cleanup.
1770 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1771 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1772 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1773 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1774 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1775 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1776 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1777 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1778 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1780 Omit needless casts involving void * pointers and allocation.
1781 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1782 as the former is more robust if P's type is changed.
1783 Prefer xzalloc to xmalloc + memset 0.
1784 Simplify malloc-or-realloc to realloc.
1785 Don't worry about xmalloc returning a null pointer.
1786 Prefer xstrdup to xmalloc + strcpy.
1787 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1789 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1790 alloca of a constant.
1792 2012-07-05 Eli Zaretskii <eliz@gnu.org>
1794 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1795 hscroll is larger than the line width. Fixes long and futile
1796 looping inside extend_face_to_end_of_line (on a TTY) producing
1797 glyphs that are not needed and thrown away.
1799 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1801 * marker.c (set_marker_restricted_both): Simplify by using
1804 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1806 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1808 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1810 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1811 not defined (Bug#11768).
1812 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1813 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1814 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1815 followed by gtk_box_set_homogeneous (Bug#11768).
1816 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
1817 (update_theme_scrollbar_width, xg_create_scroll_bar):
1818 Use gtk_scrollbar_new (Bug#11768).
1819 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1820 (is_box_type): New function (Bug#11768).
1821 (xg_tool_item_stale_p): Call is_box_type.
1822 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
1823 with default display (Bug#11768).
1825 2012-07-05 Eli Zaretskii <eliz@gnu.org>
1827 * xdisp.c (window_hscroll_limited): New function.
1828 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1829 coordinates when window's hscroll is set to insanely large
1832 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
1834 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1835 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1837 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1840 * lisp.h (xzalloc): New prototype. Omit needless casts.
1841 * alloc.c (xzalloc): New function. Omit needless casts.
1842 * charset.c: Omit needless casts. Convert all calls to
1843 xmalloc with following memset to xzalloc.
1844 * dispnew.c: Likewise.
1845 * fringe.c: Likewise.
1846 * image.c: Likewise.
1847 * sound.c: Likewise.
1849 * w32fns.c: Likewise.
1850 * w32font.c: Likewise.
1851 * w32term.c: Likewise.
1852 * xfaces.c: Likewise.
1854 * xterm.c: Likewise.
1855 * atimer.c: Omit needless casts.
1856 * buffer.c: Likewise.
1857 * callproc.c: Likewise.
1859 * coding.c: Likewise.
1860 * composite.c: Likewise.
1862 * doprnt.c: Likewise.
1863 * editfns.c: Likewise.
1864 * emacs.c: Likewise.
1866 * filelock.c: Likewise.
1868 * gtkutil.c: Likewise.
1869 * keyboard.c: Likewise.
1871 * lread.c: Likewise.
1872 * minibuf.c: Likewise.
1873 * msdos.c: Likewise.
1874 * print.c: Likewise.
1875 * process.c: Likewise.
1876 * region-cache.c: Likewise.
1877 * search.c: Likewise.
1878 * sysdep.c: Likewise.
1879 * termcap.c: Likewise.
1880 * terminal.c: Likewise.
1881 * tparam.c: Likewise.
1882 * w16select.c: Likewise.
1884 * w32reg.c: Likewise.
1885 * w32select.c: Likewise.
1886 * w32uniscribe.c: Likewise.
1887 * widget.c: Likewise.
1888 * xdisp.c: Likewise.
1889 * xmenu.c: Likewise.
1891 * xselect.c: Likewise.
1893 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1895 * fileio.c (time_error_value): Check the right error number.
1896 Problem reported by Troels Nielsen in
1897 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1899 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1901 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1902 This should be fixed in a better way; see Eli Zaretskii in
1903 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1904 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1906 * fileio.c (time_error_value): Rename from special_mtime.
1907 The old name's problems were noted by Eli Zaretskii in
1908 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1910 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1911 This variable's comment says Emacs needs at least one GDB-visible
1912 symbol of type enum pvec_type, to work around GDB problems.
1913 The symbol's value doesn't matter.
1915 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1916 that causes compilation to fail on pre-C99 compilers.
1918 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
1920 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1921 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1923 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1925 * buffer.c (init_buffer_once): Fix initialization of
1926 headers for buffer_defaults and buffer_local_symbols.
1927 Reported by Juanma Barranquero <lekktu@gmail.com>.
1929 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1931 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1932 * lisp.h (enum pvec_type): Use fewer bits.
1933 (PSEUDOVECTOR_SIZE_BITS): New constant.
1934 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1935 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1936 change in pvec_type.
1937 (PSEUDOVECTOR_TYPEP): New macro.
1938 (TYPED_PSEUDOVECTORP): Use it.
1939 * fns.c (internal_equal): Adapt code to extract pvectype.
1940 * emacs.c (gdb_pvec_type): Update type.
1941 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1942 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1943 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1944 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1945 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1946 abusing vector->header.next.nbytes.
1947 (live_vector_p): Use PVEC_TYPE.
1948 (mark_object): Adapt code to extract pvectype. Use switch.
1950 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1952 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1953 Tighten new eassert a bit.
1955 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1957 Fix compilation with --enable-gcc-warnings and -O1
1959 * doprnt.c (doprnt): Change type of tem to int, initialize
1960 to avoid compiler warning. Add eassert.
1961 * search.c (simple_search): Initialize match_byte to avoid
1962 compiler warning. Add eassert.
1964 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1966 Avoid weird behavior with large horizontal scrolls.
1967 Without this change, for example, large hscroll values would
1968 mess up Emacs's display on Fedora 15 x86, presumably due to
1969 overflows in int calculations in the display code.
1970 Also, if buffers had long lines, Emacs would freeze.
1971 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1972 (set_window_hscroll): New function, containing the old guts of
1973 Fset_window_hscroll. Return the clipped value.
1974 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1975 This avoids the need to check against PTRDIFF_MAX.
1977 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1979 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1981 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1983 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1985 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1986 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1987 since GCC 4.4.6 issues a bogus warning for them.
1989 Fix bugs in file timestamp newness comparisons.
1990 * fileio.c (Ffile_newer_than_file_p):
1991 * lread.c (Fload): Use full timestamp resolution of files,
1992 not just the 1-second resolution, so that files that are only
1993 slightly newer still count as newer.
1994 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1995 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1997 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1999 * fileio.c: Improve handling of file time marker. (Bug#11852)
2000 (special_mtime): New function.
2001 (Finsert_file_contents, Fverify_visited_file_modtime):
2002 Use it to set special mtime values consistently.
2004 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
2006 * fileio.c (Finsert_file_contents): Properly handle st_mtime
2007 marker for non-existing file. (Bug#11852)
2009 2012-07-03 Glenn Morris <rgm@gnu.org>
2011 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
2012 and did not make it into globals.h).
2014 2012-07-03 Tom Tromey <tromey@redhat.com>
2016 * window.c (Fset_window_margins, Fset_window_fringes)
2017 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
2018 * textprop.c (Fprevious_property_change): No longer static.
2019 * syntax.c (Fsyntax_table_p): No longer static.
2020 * process.c (Fget_process, Fprocess_datagram_address): No longer
2022 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
2023 * keyboard.c (Fcommand_execute): No longer static.
2025 * insdel.c (Fcombine_after_change_execute): No longer static.
2026 * image.c (Finit_image_library): No longer static.
2027 * fileio.c (Fmake_symbolic_link): No longer static.
2028 * eval.c (Ffetch_bytecode): No longer static.
2029 * editfns.c (Fuser_full_name): No longer static.
2030 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2032 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2034 * dired.c (Ffile_attributes): No longer static.
2035 * composite.c (Fcomposition_get_gstring): No longer static.
2036 * callproc.c (Fgetenv_internal): No longer static.
2038 * ccl.h: Remove EXFUNs.
2039 * buffer.h: Remove EXFUNs.
2040 * dispextern.h: Remove EXFUNs.
2041 * intervals.h: Remove EXFUNs.
2042 * fontset.h: Remove EXFUN.
2043 * font.h: Remove EXFUNs.
2044 * dosfns.c (system_process_attributes): Remove EXFUN.
2045 * keymap.h: Remove EXFUNs.
2046 * lisp.h: Remove EXFUNs.
2047 * w32term.h: Remove EXFUNs.
2048 * window.h: Remove EXFUNs.
2049 * xsettings.h: Remove EXFUN.
2050 * xterm.h: Remove EXFUN.
2052 2012-07-03 Glenn Morris <rgm@gnu.org>
2054 * lisp.h (Frandom): Make it visible to C.
2055 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2056 buffer for invisible buffers. (Bug#1229)
2058 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2060 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2061 values which aren't power of 2.
2062 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
2063 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
2066 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2068 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2070 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2072 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2074 * alloc.c (allocate_vector_block): Remove redundant
2075 calls to mallopt if DOUG_LEA_MALLOC is defined.
2076 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2077 avoid calls to mallopt if zero_vector is returned.
2079 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2081 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2082 is enabled, avoid dereferencing NULL current_sblock if
2085 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2087 Cleanup basic buffer management.
2088 * buffer.h (struct buffer): Change layout to use generic vector
2089 marking code. Fix some comments. Change type of 'clip_changed'
2090 to bitfield. Remove unused #ifndef old.
2091 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2092 (GET_OVERLAYS_AT): Fix indentation.
2093 (for_each_per_buffer_object_at): New macro.
2094 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2095 (Fbuffer_local_variables): Use it.
2096 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2097 * alloc.c (allocate_buffer): Adjust to match new layout of
2098 struct buffer. Fix comment.
2099 (mark_overlay): New function.
2100 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2101 Lisp area of struct buffer.
2102 (mark_object): Use it. Adjust marking of misc objects
2103 and related comments.
2105 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2107 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2108 wrapper that is not needed because the wrapped code is a no-op (zero
2109 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2110 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2112 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2114 * alloc.c (mark_buffer): Simplify. Remove prototype.
2115 (mark_object): Add comment. Reorganize marking of vector-like
2116 objects. Use CHECK_LIVE for all vector-like objects except buffers
2117 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
2118 redundant calls to mark_vectorlike for bool vectors.
2120 2012-06-30 Glenn Morris <rgm@gnu.org>
2122 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2124 * epaths.in (PATH_SITELOADSEARCH): New.
2125 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2126 This is rather than relying on --enable-locallisppath elements
2127 having "site-lisp" in their names. (Bug#10208#25, 11658)
2129 2012-06-30 Eli Zaretskii <eliz@gnu.org>
2131 * w32proc.c (sys_select): Accept and ignore one more argument.
2133 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2135 * sysselect.h [DOS_NT]: Don't include sys/select.h.
2136 (pselect) [!MS_DOS]: Redirect to sys_select.
2138 * sysdep.c: Don't include dos.h and dosfns.h.
2140 * process.c (sys_select):
2141 * msdos.c (sys_select): Accept one more argument and ignore it.
2143 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2144 adapt data types and code to that.
2147 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2148 which clashes with the gnulib function of the same name.
2150 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2152 * font.c (font_style_to_value, font_style_symbolic)
2153 (font_prop_validate_style): Add type checks for values in
2156 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2158 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2161 2012-06-29 Eli Zaretskii <eliz@gnu.org>
2163 * xdisp.c (try_window_id): Undo last change.
2165 * w32.c (getwd): Adjust commentary about startup_dir.
2166 (init_environment): Always call sys_access, even in non-MSVC
2167 builds. Don't chdir to the directory of the Emacs executable.
2168 This undoes code from 1997 which was justified by the need to
2169 "avoid conflicts when removing and renaming directories". But its
2170 downside was that every relative file name was being interpreted
2171 relative to the directory of the Emacs executable, which can never
2172 be TRT. In particular, it broke sys_access when called with
2173 relative file names.
2174 (sys_access): Map GetLastError to errno.
2176 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2178 * window.h (struct window): Change type of 'fringes_outside_margins'
2179 to bitfield. Fix comment. Adjust users accordingly.
2180 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2182 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2185 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
2187 * gnutls.c (emacs_gnutls_handshake):
2188 Add QUIT to make the loop interruptible.
2190 2012-06-29 Glenn Morris <rgm@gnu.org>
2192 * charset.c (init_charset): Make lack of etc/charsets fatal.
2194 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2196 * editfns.c (region_limit): Fix type mismatch.
2198 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2200 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2201 undefined. Convert from xassert to eassert.
2202 * nsmenu.m: Convert from xassert to eassert.
2203 * nsterm.m: Likewise.
2205 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2207 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2209 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2211 Avoid integer overflow on scroll-left and scroll-right.
2212 * window.c (HSCROLL_MAX): New macro.
2213 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2214 overflow when requested scroll falls outside ptrdiff_t range.
2216 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2218 * window.h (struct window): Change type of 'hscroll',
2219 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2220 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2221 Adjust users accordingly.
2222 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2223 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2224 from EMACS_INT to ptrdiff_t.
2225 (make_window): Omit redundant initialization.
2227 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
2229 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2231 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2233 * window.h (struct window): Change type of 'use_time' and
2234 'sequence_number' from Lisp_Object to int.
2235 * frame.c (make_frame): Adjust users accordingly.
2236 * print.c (print_object): Likewise.
2237 * window.c (select_window, Fwindow_use_time, make_parent_window)
2238 (make_window): Likewise.
2240 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2242 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2243 enabled with --enable-checking=[all,glyphs] configure option.
2244 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2245 adjust comments accordingly.
2246 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2247 undefined, adjust comments accordingly.
2248 * image.c: Likewise.
2249 * scroll.c: Likewise.
2250 * w32fns.c: Likewise.
2251 * w32term.c: Likewise.
2252 * xdisp.c: Likewise.
2253 * xfaces.c: Likewise.
2255 * xterm.c: Likewise.
2257 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2259 Generalize run-time debugging checks.
2260 * dispextern.h (XASSERTS): Remove.
2261 * fontset.c (xassert): Remove.
2262 Convert from xassert to eassert.
2263 * alloc.c: Convert from xassert to eassert.
2265 * dispnew.c: Likewise.
2267 * fringe.c: Likewise.
2268 * ftfont.c: Likewise.
2269 * gtkutil.c: Likewise.
2270 * image.c: Likewise.
2271 * keyboard.c: Likewise.
2273 * process.c: Likewise.
2274 * scroll.c: Likewise.
2275 * sound.c: Likewise.
2277 * w32console.c: Likewise.
2278 * w32fns.c: Likewise.
2279 * w32term.c: Likewise.
2280 * window.c: Likewise.
2281 * xdisp.c: Likewise.
2282 * xfaces.c: Likewise.
2284 * xselect.c: Likewise.
2285 * xterm.c: Likewise.
2287 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2289 * fns.c (maybe_resize_hash_table): Output message when growing the
2292 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2294 * alloc.c (allocate_string_data): Remove dead code.
2295 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2296 avoid GCC warning about unused macro.
2298 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2300 * alloc.c (allocate_string): Omit intervals initialization.
2301 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2302 as in make_pure_string and make_pure_c_string.
2304 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2306 * alloc.c (allocate_string): Fix last change.
2308 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2310 * alloc.c (allocate_string): Remove two redundant calls
2311 to memset, add explicit initialization where appropriate.
2313 2012-06-27 Glenn Morris <rgm@gnu.org>
2315 * lisp.mk (lisp): Remove paths.elc.
2317 2012-06-27 Chong Yidong <cyd@gnu.org>
2319 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2321 2012-06-26 John Wiegley <johnw@newartisans.com>
2323 * unexmacosx.c (copy_data_segment): Add two section names used
2324 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2326 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2327 when building with Clang.
2329 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2331 * eval.c (Fapply): Allow calling it with a single argument.
2333 2012-06-26 Eli Zaretskii <eliz@gnu.org>
2335 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2336 _stricmp and _strnicmp.
2337 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2339 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2341 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2343 (allocate_process): Likewise for new process.
2344 (allocate_terminal): Change to use offsetof.
2345 (allocate_frame): Likewise.
2346 * frame.c (make_frame): Omit redundant initialization.
2347 * window.c (make_parent_window): Use memset.
2348 (make_window): Omit redundant initialization.
2349 * process.c (make_process): Omit redundant initialization.
2350 * terminal.c (create_terminal): Likewise.
2352 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2354 * term.c (delete_tty): Remove redundant call to memset.
2356 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2358 * alloc.c: Remove build_string.
2359 * lisp.h: Define build_string as static inline. This provides
2360 a better opportunity to optimize away calls to strlen when the
2361 function is called with compile-time constant argument.
2362 * image.c (imagemagick_error): Convert to build_string.
2363 * w32proc.c (sys_spawnve): Likewise.
2364 * xterm.c (x_term_init): Likewise.
2366 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2368 Use sprintf return value instead of invoking strlen on result.
2369 In the old days this wasn't portable, since some sprintf
2370 implementations returned char *. But they died out years ago and
2371 Emacs already assumes sprintf returns int.
2372 Similarly for float_to_string.
2373 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2374 * ccl.c (ccl_driver):
2375 * character.c (string_escape_byte8):
2376 * data.c (Fnumber_to_string):
2377 * doprnt.c (doprnt):
2378 * print.c (print_object):
2379 * xdisp.c (message_dolog):
2380 * xfns.c (syms_of_xfns):
2381 Use sprintf or float_to_string result to avoid need to call strlen.
2382 * data.c (Fnumber_to_string):
2383 Use make_unibyte_string, since the string must be ASCII.
2384 * lisp.h, print.c (float_to_string): Now returns int length.
2385 * term.c (produce_glyphless_glyph):
2386 Use sprintf result rather than recomputing it.
2388 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2389 * Makefile.in (ALL_CFLAGS):
2390 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2391 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2393 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2395 * dispextern.h (xstrcasecmp): Define to library function
2396 strcasecmp if available.
2397 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2399 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2401 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2402 Avoid comma operator.
2403 * menu.c (push_submenu_start, push_submenu_end)
2404 (push_left_right_boundary, push_menu_pane): Likewise.
2405 * msdos.c (dos_rawgetc): Likewise.
2407 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2409 * xfns.c (xic_create_fontsetname): Remove redundant calls
2412 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2414 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2415 sprintf already null-terminates its output.
2417 * xfns.c (x_window): Remove redundant cast.
2419 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2421 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2422 `const char *' to `char *' to avoid compiler warning.
2424 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2426 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2427 instead of truncating it to 63 (admittedly a generous limit).
2429 * process.c: Fix spelling and caps in comments.
2431 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2433 * emacs.c (setpgrp): Remove definition, unused.
2434 * sysdep.c (setpgrp): Remove definition, not used in this file.
2436 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
2438 * makefile.w32-in: Update dependencies.
2440 2012-06-24 Eli Zaretskii <eliz@gnu.org>
2442 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2443 (SYSTIME_H): Add nt/inc/sys/time.h.
2445 * systime.h [WINDOWSNT]: Include sys/time.h.
2447 * s/ms-w32.h (struct timespec): Definition moved from
2448 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2450 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2452 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2453 * buffer.h (buffer_slot_type_mismatch):
2454 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2455 * eval.c (unwind_to_catch):
2456 * image.c (my_png_error, my_error_exit):
2457 * keyboard.c (quit_throw_to_read_char, user_error)
2458 (Fexit_recursive_edit, Fabort_recursive_edit):
2459 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2460 (wrong_type_argument, buffer_overflow, __executable_start)
2461 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2462 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2463 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2465 (child_setup) [!DOS_NT]:
2466 * lread.c (end_of_file_error, invalid_syntax):
2467 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2468 * puresize.h (pure_write_error):
2469 * search.c (matcher_overflow):
2470 * sound.c (sound_perror, alsa_sound_perror):
2471 * sysdep.c, syssignal.h (croak):
2472 * term.c (maybe_fatal, vfatal):
2473 * textprop.c (text_read_only):
2474 * undo.c (user_error):
2475 * unexmacosx.c (unexec_error):
2476 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2477 Use _Noreturn rather than NO_RETURN.
2478 No need for separate decl merely because of _Noreturn.
2479 * sound.c (sound_warning, parse_sound):
2480 Remove unnecessary forward decls.
2482 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2484 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2485 * lisp.h (WAIT_READING_MAX): New macro.
2486 * dispnew.c (Fsleep_for, sit_for):
2487 * keyboard.c (kbd_buffer_get_event):
2488 * process.c (Faccept_process_output):
2489 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2490 This improves on the previous patch, which introduced a bug
2491 when time_t is unsigned and as wide as intmax_t.
2492 See <http://bugs.gnu.org/9000#51>.
2494 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2496 * dispnew.c (sit_for, Fsleep_for):
2497 * keyboard.c (kbd_buffer_get_event):
2498 * process.c (Faccept_process_output): Avoid compiler warnings when
2499 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2501 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
2503 * makefile.w32-in: Update dependencies.
2505 * w32.c (ltime): Add return type and declare static.
2506 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2508 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2510 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2511 Privately reported by Herbert J. Skuhra.
2512 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2514 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2515 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2517 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2519 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2520 last argument of make_unibyte_string.
2522 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2523 language ID in the event parameters.
2525 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2526 event.code, not the obscure "character set ID".
2528 2012-06-23 Chong Yidong <cyd@gnu.org>
2530 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2532 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2534 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2535 * w32.c (fdutimens): New function.
2537 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2539 * s/ms-w32.h (pselect): Redirect to sys_select.
2541 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2543 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2544 in the logic of incrementing and decrementing the value of
2545 use_relocatable_buffers.
2547 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2549 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2550 Privately reported by Herbert J. Skuhra.
2551 [__FreeBSD__]: Remove "*/" typo after "#include".
2552 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2553 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2554 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2555 Don't assume EMACS_TIME and struct timeval are the same type.
2557 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2559 Support higher-resolution time stamps (Bug#9000).
2560 The time stamps are only nanosecond-resolution at the C level,
2561 since that's the best that any real-world system supports now.
2562 But they are picosecond-resolution at the Lisp level, as that's
2563 easy, and leaves room for future OS improvements.
2565 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2568 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2569 Don't get current time unless it's needed.
2571 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2572 now provides it if it's absent.
2573 (start_atimer): Port to higher-res time stamps.
2574 Check for time stamp overflow. Don't get current time more
2575 often than is needed.
2577 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2578 Include systime.h, not time.h.
2579 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2581 * dired.c: Include stat-time.h.
2582 (Ffile-attributes): File times now have higher resolution.
2584 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2585 (struct image): Timestamp now has higher resolution.
2587 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2588 has at least microseconds now. All uses removed.
2589 (update_frame, update_single_window, update_window, update_frame_1)
2590 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2592 * editfns.c (time_overflow): Now extern.
2593 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2594 (float-time, Fformat_time_string, Fcurrent_time_string)
2595 (Fcurrent_time_zone): Accept and generate higher-resolution
2597 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2598 (decode_time_components, lisp_seconds_argument): New functions.
2599 (make_time): Now static.
2600 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2601 Report an error if the time is invalid, rather than having the caller
2604 * fileio.c: Include <stat-time.h>
2605 (Fcopy_file): Copy higher-resolution time stamps.
2606 Prefer to set the time stamp via a file descriptor if that works.
2607 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2608 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2609 (Fvisited_file_modtime, Fset_visited_file_modtime):
2610 Support higher-resolution time stamps.
2612 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2614 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2616 * image.c (prepare_image_for_display, clear_image_cache)
2617 (lookup_image): Port to higer-resolution time stamps.
2619 * keyboard.c (start_polling, bind_polling_period):
2620 Check for time stamp overflow.
2621 (read_char, kbd_buffer_get_event, timer_start_idle)
2622 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2623 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2624 Port to higher-resolution time stamps. Do not assume time_t is signed.
2625 (decode_timer): New function. Timers are now vectors of length 9,
2626 not 8, to accommodate the picosecond component.
2627 (timer_check_2): Use it.
2629 * nsterm.m (select_timeout, timeval_subtract): Remove.
2630 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2631 as they're a bit more accurate and handle overflow better.
2632 (ns_select): Change prototype to be compatible with pselect.
2633 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2634 * nsterm.h (ns_select): Adjust prototype.
2636 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2637 us-resolution time stamps.
2638 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2640 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2642 * lisp.h (time_overflow): New decl.
2643 (wait_reading_process_output): First arg is now intmax_t, not int,
2644 to accommodate larger waits.
2646 * process.h (struct Lisp_Process.read_output_delay):
2647 Now counts nanoseconds, not microseconds.
2648 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2650 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2651 (wait_reading_process_output):
2652 Port to ns-resolution time stamps.
2653 (Faccept_process_output, wait_reading_process_output):
2654 Check for time stamp overflow. Do not assume time_t is signed.
2655 (select_wrapper): Remove; we now use pselect.
2656 (Fprocess_attributes): Now generates ns-resolution time stamps.
2658 * sysdep.c: Include utimens.h. Don't include utime.h
2659 or worry about struct utimbuf; gnulib does that for us now.
2660 (gettimeofday): Remove; gnulib provides a substitute.
2661 (make_timeval): New function.
2662 (set_file_times): Now sets ns-resolution time stamps.
2663 New arg FD; all uses changed.
2664 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2665 (system_process_attributes):
2666 Now returns ns-resolution time stamp. All uses changed.
2667 Check for time stamp overflow.
2669 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2670 provides a substitute now.
2672 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2673 since it guarantees struct timespec.
2674 (EMACS_TIME): Now struct timespec, so that we can support
2675 ns-resolution time stamps.
2676 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2677 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2678 (EMACS_USECS): Remove.
2679 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2680 so multiply the arg by 1000 before storing it.
2681 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2683 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2684 Port to ns-resolution time stamps.
2685 (EMACS_TIME_NEG_P): Remove; replaced by....
2686 (EMACS_TIME_SIGN): New macro.
2687 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2688 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2689 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2690 (make_timeval, make_lisp_time, decode_time_components): New decls.
2691 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2692 that it mishandled time_t overflow. You can't compare by subtracting!
2693 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2694 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2696 * term.c: Include <sys/time.h>.
2697 (timeval_to_Time): New function, for proper overflow wraparound.
2698 (term_mouse_position, term_mouse_click): Use it.
2700 * undo.c (record_first_change): Support higher-resolution time stamps
2702 (Fprimitive_undo): Use them when restoring time stamps.
2704 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2705 (w32_get_internal_run_time):
2706 Port to higher-resolution Emacs time stamps.
2707 (ltime): Now accepts single 64-bit integer, as that's more convenient
2710 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2712 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2713 for compatibility with pselect. Support ns-resolution time stamps.
2715 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2717 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2718 Check for time stamp overflow, and support ns-resolution time stamps.
2720 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2721 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2722 (timeval_subtract): Remove; no longer needed.
2723 (XTflash, XTring_bell, x_wait_for_event):
2724 Port to ns-resolution time stamps. Don't assume time_t is signed.
2726 2012-06-22 Chong Yidong <cyd@gnu.org>
2728 * xdisp.c (x_consider_frame_title): Revert last change.
2730 2012-06-22 Eli Zaretskii <eliz@gnu.org>
2732 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2733 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2734 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2735 staticidx goes up to 1597 out of 1600 = 0x640.)
2737 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2739 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2740 Otherwise, the umask might be mistakenly 0 while handling input signals.
2742 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2744 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2746 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2748 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2749 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2750 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2751 access to `contents' member of Lisp_Vector objects with AREF and ASET
2754 2012-06-19 Chong Yidong <cyd@gnu.org>
2756 * frame.c (delete_frame): When selecting a frame on a different
2757 text terminal, do not alter the terminal's top-frame.
2759 * xdisp.c (format_mode_line_unwind_data): Record the target
2760 frame's selected window and its terminal's top-frame.
2761 (unwind_format_mode_line): Restore them.
2762 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2764 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2765 since tty frames can be explicitly named.
2766 (prepare_menu_bars): Likewise.
2768 * term.c (Ftty_top_frame): New function.
2770 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2772 Port byte-code-meter to modern targets.
2773 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2774 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
2775 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
2776 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2777 (METER_1, METER_2): Simplify.
2779 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2781 * data.c (Fdefalias): Return `symbol' (bug#11686).
2783 2012-06-18 Martin Rudalics <rudalics@gmx.at>
2785 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
2786 gets killed during executing of this function (Bug#11665).
2787 Try to always return Qt when the buffer has been actually killed.
2788 (Vkill_buffer_query_functions): In doc-string say that functions
2789 run by this hook should not change the current buffer.
2791 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2793 Fix recently-introduced process.c problems found by static checking.
2794 * process.c (write_queue_push, write_queue_pop, send_process):
2795 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2796 (write_queue_pop): Fix pointer signedness problem.
2797 (send_process): Remove unused local.
2799 2012-06-17 Chong Yidong <cyd@gnu.org>
2801 * xdisp.c (redisplay_internal): No need to redisplay terminal
2802 frames that are not on top.
2804 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
2806 * process.c (make_process): Initialize write_queue.
2807 (write_queue_push, write_queue_pop): New functions.
2808 (send_process): Use them to maintain correct ordering of process
2811 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2813 * lisp.h (eassert): Assume C89 or later.
2814 This removes the need for CHECK.
2815 (CHECK): Remove. Its comments about always evaluating its
2816 argument were confusing, as 'eassert' typically does not evaluate
2819 * coding.c (produce_chars): Use ptrdiff_t, not int.
2821 * xterm.c (x_draw_underwave): Check for integer overflow.
2822 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2824 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
2826 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2827 referenced (Bug#11583).
2829 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2831 Implement wave-style variant of underlining.
2832 * dispextern.h (face_underline_type): New enum.
2833 (face): Add field for underline type.
2834 * nsterm.m (ns_draw_underwave): New function.
2835 (ns_draw_text_decoration): Use it.
2836 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2838 (x_draw_glyph_string): Use them.
2839 * xfaces.c (Qline, Qwave): New Lisp objects.
2840 (check_lface_attrs, merge_face_ref)
2841 (Finternal_set_lisp_face_attribute, realize_x_face):
2842 Handle wave-style underline face attributes.
2843 * xterm.c (x_draw_underwave): New function.
2844 (x_draw_glyph_string): Use it.
2846 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
2848 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2849 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2850 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2851 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2852 ($(BLD)/w32select.$(O)): Update dependencies.
2854 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2856 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2857 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2858 * character.c (_fetch_multibyte_char_p): Remove.
2859 * alloc.c: Include "character.h" before "buffer.h".
2861 * buffer.c: Likewise.
2862 * bytecode.c: Likewise.
2863 * callint.c: Likewise.
2864 * callproc.c: Likewise.
2865 * casefiddle.c: Likewise.
2866 * casetab.c: Likewise.
2867 * category.c: Likewise.
2869 * coding.c: Likewise.
2870 * composite.c: Likewise.
2871 * dired.c: Likewise.
2872 * dispnew.c: Likewise.
2874 * dosfns.c: Likewise.
2875 * editfns.c: Likewise.
2876 * emacs.c: Likewise.
2877 * fileio.c: Likewise.
2878 * filelock.c: Likewise.
2880 * fontset.c: Likewise.
2881 * fringe.c: Likewise.
2882 * indent.c: Likewise.
2883 * insdel.c: Likewise.
2884 * intervals.c: Likewise.
2885 * keyboard.c: Likewise.
2886 * keymap.c: Likewise.
2887 * lread.c: Likewise.
2888 * macros.c: Likewise.
2889 * marker.c: Likewise.
2890 * minibuf.c: Likewise.
2891 * nsfns.m: Likewise.
2892 * nsmenu.m: Likewise.
2893 * print.c: Likewise.
2894 * process.c: Likewise.
2895 * regex.c: Likewise.
2896 * region-cache.c: Likewise.
2897 * search.c: Likewise.
2898 * syntax.c: Likewise.
2900 * textprop.c: Likewise.
2902 * unexsol.c: Likewise.
2903 * w16select.c: Likewise.
2904 * w32fns.c: Likewise.
2905 * w32menu.c: Likewise.
2906 * window.c: Likewise.
2907 * xdisp.c: Likewise.
2909 * xmenu.c: Likewise.
2911 * xselect.c: Likewise.
2913 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2915 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2916 If all the glyphs of the glyph row came from strings, and we have no
2917 cursor positioning clues, put the cursor on the first glyph of the
2919 (handle_face_prop): Use chunk-relative overlay string index when
2920 indexing into it->string_overlays array. (Bug#11653)
2921 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2922 the rightmost. (Bug#11720)
2924 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2926 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2927 (CATEGORY_MEMBER): Enforce 1/0 value.
2928 * category.c (_temp_category_set): Remove.
2930 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2932 * window.c (Fdelete_other_windows_internal)
2933 (Fdelete_window_internal): Don't access frame's mouse highlight
2934 info of the initial frame. (Bug#11677)
2936 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2938 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2939 Assume USE_2_TAGS_FOR_INTS.
2940 (xreload): Adjust $tagmask width to match recent lisp.h change.
2942 Simplify lisp.h in minor ways that should not affect code.
2943 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2944 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2945 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2946 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2947 (INTTYPEBITS): New macro, for clarity.
2948 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
2949 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2950 Simplify now that USE_LSB_TAG is always defined.
2951 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2952 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2954 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
2956 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2958 2012-06-13 Glenn Morris <rgm@gnu.org>
2960 * s/bsd-common.h (BSD4_3):
2961 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2963 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2965 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2968 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2970 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
2971 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
2972 * alloc.c (widen_to_Lisp_Object): Remove.
2973 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2974 * frame.c (delete_frame): Remove outdated comment.
2975 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2976 USE_LISP_UNION_TYPE.
2977 (Fw32_unregister_hot_key): Likewise.
2978 (Fw32_toggle_lock_key): Likewise.
2979 * w32menu.c (add_menu_item): Likewise.
2980 (w32_menu_display_help): Use XIL instead of checking
2981 USE_LISP_UNION_TYPE.
2982 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2983 (init_heap): Likewise.
2984 * w32term.c (w32_read_socket): Update comment.
2986 2012-06-13 Glenn Morris <rgm@gnu.org>
2988 * s/usg5-4-common.h, src/s/unixware.h:
2989 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2991 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2993 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2995 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2996 * alloc.c (make_number) [!defined make_number]:
2997 Remove, as lisp.h always defines this now.
2998 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2999 (roundup_size): Verify that it is a power of 2.
3000 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
3001 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
3002 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
3003 -DUSE_LSB_TAG=0, to override the automatically-selected default.
3004 USE_LSB_TAG now is always defined to be either 0 or 1.
3006 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
3007 code works fine either way, and efficiency is not a concern here,
3008 as the union type is for debugging, not for production.
3009 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
3010 Use an inline function on all platforms when using the union type,
3011 since this is simpler and 'static inline' can be used portably
3013 (LISP_INITIALLY_ZERO): New macro.
3014 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
3015 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
3017 2012-06-12 Glenn Morris <rgm@gnu.org>
3019 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
3021 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
3023 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
3024 Move BROKEN_SIGIO to configure.
3026 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
3027 Move NO_TERMIO to configure.
3029 2012-06-12 Chong Yidong <cyd@gnu.org>
3031 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3032 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3033 MagickExportImagePixels is undefined.
3035 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3037 * image.c (imagemagick_load_image): Remove unused label.
3039 2012-06-11 Glenn Morris <rgm@gnu.org>
3041 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3042 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3043 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3044 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3046 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3048 * alloc.c (make_byte_code): New function.
3049 (Fmake_byte_code): Use it. Don't purify here.
3050 * lread.c (read1): Use it as well to avoid extra allocation.
3052 2012-06-11 Chong Yidong <cyd@gnu.org>
3054 * image.c (imagemagick_load_image): Implement transparency.
3056 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3058 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3059 account for preceding backslashes. (Bug#11663)
3061 2012-06-09 Chong Yidong <cyd@gnu.org>
3063 * term.c: Support italics in capable terminals (Bug#9652).
3064 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3065 (turn_on_face): Output using TS_enter_italic_mode if available.
3066 Don't handle unused blinking and alt-charset cases.
3067 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3068 and tty_alt_charset_p cases.
3069 (tty_capable_p, init_tty): Support italics.
3071 * termchar.h (struct tty_display_info): Add field for italics.
3072 Remove unused blink field.
3074 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3077 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3078 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3079 tty_alt_charset_p. Add tty_italic_p.
3081 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
3083 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3084 dbus_type_is_basic if available.
3085 (xd_extract_signed, xd_extract_unsigned): Rename from
3086 extract_signed and extract_unsigned, respectively. Adapt callers.
3088 2012-06-09 Chong Yidong <cyd@gnu.org>
3090 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3092 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3095 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3097 * xdisp.c (vmessage): Treat frame message as multibyte.
3098 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3099 would generate the diagnostic "Making \302\247 buffer-local while
3102 2012-06-08 Eli Zaretskii <eliz@gnu.org>
3104 * dispnew.c (showing_window_margins_p): Undo last change, which
3105 was done due to an inadvertent commit.
3106 (adjust_frame_glyphs_for_frame_redisplay): Do call
3107 showing_window_margins_p.
3109 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3111 * eval.c (Fmake_var_non_special): New primitive.
3112 (syms_of_eval): Defsubr it.
3113 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3115 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
3117 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3118 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3120 2012-06-08 Eli Zaretskii <eliz@gnu.org>
3122 * alloc.c (allocate_vectorlike): Fix last change.
3124 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3126 Block-based vector allocation of small vectors.
3127 * lisp.h (struct vectorlike_header): New field `nbytes',
3128 adjust comment accordingly.
3129 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3130 to denote vector blocks. Adjust users (live_vector_p,
3131 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3132 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3133 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3134 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3135 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3136 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3137 (roundup_size): New constant.
3138 (struct vector_block): New data type.
3139 (vector_blocks, vector_free_lists, zero_vector): New variables.
3140 (all_vectors): Rename to `large_vectors'.
3141 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3142 (sweep_vectors): New functions.
3143 (allocate_vectorlike): Return `zero_vector' as the only vector of
3144 0 items. Allocate new vector from block if vector size is less than
3145 or equal to VBLOCK_BYTES_MAX.
3146 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3147 (init_alloc_once): Add call to init_vectors.
3149 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3151 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3153 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3155 * doprnt.c (doprnt): Truncate multibyte char correctly.
3156 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3157 would mishandle a string argument "Xc" if X was a multibyte
3158 character of length 2: it would truncate after X's first byte
3159 rather than including all of X.
3161 2012-06-06 Chong Yidong <cyd@gnu.org>
3163 * buffer.c (word_wrap): Doc fix.
3165 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3167 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3169 2012-06-03 Glenn Morris <rgm@gnu.org>
3171 * xdisp.c (tool-bar-style): Doc fix.
3173 2012-06-03 Ulrich Müller <ulm@gentoo.org>
3175 * Makefile.in (PAXCTL): Define.
3176 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3177 binary via PaX flags if the paxctl utility is available.
3178 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3179 Restore PaX flags to their default. (Bug#11398)
3181 2012-06-03 Chong Yidong <cyd@gnu.org>
3183 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3186 2012-06-03 Chong Yidong <cyd@gnu.org>
3188 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3189 (note_mode_line_or_margin_highlight): If there is no help echo,
3190 use mode-line-default-help-echo. Handle the case where the mouse
3191 position is past the end of the mode line string.
3193 * buffer.c (buffer_local_value_1): New function, split from
3194 Fbuffer_local_value; can return Qunbound.
3195 (Fbuffer_local_value): Use it.
3196 (Vmode_line_format): Docstring tweaks.
3198 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3200 * sysdep.c (system_process_attributes): Improve comment.
3202 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3204 * keyboard.c: Export real-this-command to Elisp.
3205 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3206 and DEFVAR it. Update all users.
3208 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3210 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3212 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3213 Convert pctcpu and pctmem to Lisp float properly.
3214 Let the compiler fold better, as 100.0/0x8000 is exact.
3216 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3218 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3221 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3223 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3225 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3227 For a 'struct window', replace some Lisp_Object fields to
3228 bitfields where appropriate, remove unused fields.
3229 * window.h (struct window): Remove unused 'last_mark_x' and
3230 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3231 change it's type from Lisp_Object to bitfield.
3232 Change type of 'force_start', 'optional_new_start',
3233 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3234 fields from Lisp_Object to bitfield. Adjust users accordingly.
3236 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3238 Pacify gcc -Wdouble-precision when using Xaw.
3239 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3240 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3241 Use 'float' consistently, rather than 'float' in most places
3242 and 'double' in a couple of places.
3244 2012-05-31 Eli Zaretskii <eliz@gnu.org>
3246 * xdisp.c (handle_stop): Detect whether we have overlay strings
3247 loaded by testing it->current.overlay_string_index to be
3248 non-negative, instead of checking whether n_overlay_strings is
3249 positive. (Bug#11587)
3251 2012-05-31 Chong Yidong <cyd@gnu.org>
3253 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3255 * doc.c (Fsubstitute_command_keys): Doc fix.
3257 2012-05-31 Eli Zaretskii <eliz@gnu.org>
3259 * search.c (search_buffer): Remove calls to
3260 r_alloc_inhibit_buffer_relocation, as it is now called by
3261 maybe_unify_char, which was the cause of relocation of buffer text
3264 2012-05-31 Eli Zaretskii <eliz@gnu.org>
3266 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3267 for the duration of call to load_charset, to avoid problems with
3268 callers of maybe_unify_char that access buffer text through C
3271 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3272 decrement the inhibition flag, instead of just setting or
3275 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3277 Remove obsolete '#define static' cruft.
3278 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3279 This #undef was "temporary" in 2000; it is no longer needed
3280 now that '#define static' has gone away.
3281 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3282 (gray_bitmap_bits): Remove; no longer needed.
3283 All uses replaced with definiens.
3284 * xterm.c: Include "bitmaps/gray.xbm".
3286 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3288 Clean up __executable_start, monstartup when --enable-profiling.
3289 The following changes affect the code only when profiling.
3290 * dispnew.c (__executable_start): Rename from safe_bcopy.
3291 Define only on platforms that need it.
3292 * emacs.c: Include <sys/gmon.h> when profiling.
3293 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3294 (__executable_start): Remove decl, since lisp.h does it now.
3295 (safe_bcopy): Remove decl; no longer has that name.
3296 (main): Coalesce #if into single bit of code, for simplicity.
3297 Cast pointers to uintptr_t, since standard libraries want integers
3299 * lisp.h (__executable_start): New decl.
3301 2012-05-31 Glenn Morris <rgm@gnu.org>
3303 * image.c (Fimagemagick_types): Doc fix.
3305 2012-05-30 Jim Meyering <meyering@redhat.com>
3307 * callproc.c (Fcall_process_region): Include directory component
3308 in mkstemp error message (Bug#11586).
3310 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3312 * alloc.c, lisp.h (make_pure_vector): Now static.
3314 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3316 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3317 Move to byte-run.el.
3318 (Fautoload): Do the hash-doc more carefully.
3319 * data.c (Fdefalias): Purify definition, except for keymaps.
3320 (Qdefun): Move from eval.c.
3321 * lisp.h (Qdefun): Remove.
3322 * lread.c (read1): Tiny simplification.
3324 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
3326 Do not create empty overlays with the evaporate property (Bug#9642).
3327 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3328 Bug#9642, but explicitly check that the buffer the overlay would
3329 be moved to is live and rearrange lines to make sure that errors
3330 will not put the overlay in an inconsistent state.
3331 (Fdelete_overlay): Cosmetics.
3333 2012-05-28 Eli Zaretskii <eliz@gnu.org>
3335 * w32term.c (my_bring_window_to_top): New function.
3336 (x_raise_frame): Use handle returned by DeferWindowPos, which
3337 could be different from the original one.
3338 Call my_bring_window_to_top instead of my_set_foreground_window.
3341 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3342 by calling BringWindowToTop.
3344 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3345 (WM_EMACS_END): Increase by one.
3347 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3349 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3350 This avoids undefined behavior that might cause the eassert
3351 to not catch an out-of-range value.
3353 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
3355 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3356 Update dependencies.
3358 2012-05-27 Eli Zaretskii <eliz@gnu.org>
3360 * bidi.c (bidi_mirror_char): Fix last change.
3362 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3364 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3365 when referring to sectname field in printf format.
3367 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3369 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3370 Only r_alloc_inhibit_buffer_relocation needed to be added;
3371 the others were already declared.
3373 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3374 before checking whether it's out of range. Put the check inside
3376 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3378 2012-05-27 Ken Brown <kbrown@cornell.edu>
3380 * callproc.c (Fcall_process): Restore a line that was accidentally
3381 commented out in the 2011-02-13 change (bug#11547).
3383 2012-05-27 Eli Zaretskii <eliz@gnu.org>
3385 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3386 defined on ralloc.c.
3388 * buffer.c [REL_ALLOC]: Remove prototypes of
3389 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3390 they are now on lisp.h.
3392 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3394 * search.c (search_buffer): Use it to inhibit relocation of buffer
3395 text while re_search_2 is doing its job, because re_search_2 is
3396 passed C pointers to buffer text. (Bug#11519)
3398 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3401 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3402 state after an additional call to move_it_in_display_line_to, keep
3403 the values of it->max_ascent and it->max_descent found for the
3405 (pos_visible_p): Revert the comparison against bottom_y to what it
3406 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3409 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3411 Fix coding-related core dumps with gcc -ftrapv.
3412 The code was computing A - B, where A and B are pointers, and B is
3413 random garbage. This can lead to core dumps on platforms that
3414 have special pointer registers, and it also leads to core dumps on
3415 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3416 A - B only when B is initialized properly.
3417 * coding.c (coding_set_source, coding_set_destination): Return void.
3418 (coding_change_source, coding_change_destinations): New functions,
3419 with the old behaviors of coding_set_source and coding_set_destination.
3420 All callers that need an offset changed to use these new functions.
3422 2012-05-26 Glenn Morris <rgm@gnu.org>
3424 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3426 2012-05-26 Eli Zaretskii <eliz@gnu.org>
3428 Extend mouse support on W32 text-mode console.
3429 * xdisp.c (draw_row_with_mouse_face):
3430 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
3432 * w32console.c: Include window.h.
3433 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3435 (initialize_w32_display): Initialize mouse-highlight data.
3437 * w32inevt.c: Include termchar.h and window.h.
3438 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3439 moves, call note_mouse_highlight. If help_echo changed, call
3440 gen_help_event to produce help-echo message in the echo area.
3441 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3444 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3446 * lread.c (read1): Simplify slightly to avoid an overflow warning
3447 with GCC 4.7.0 on x86-64.
3449 2012-05-26 Eli Zaretskii <eliz@gnu.org>
3451 * bidi.c (bidi_mirror_char): Revert last change: an int is
3452 definitely wide enough here.
3454 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3456 Fix integer width and related bugs (Bug#9874).
3457 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
3458 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3459 (string_bytes, check_sblock, allocate_string_data):
3460 (compact_small_strings, Fmake_bool_vector, make_string)
3461 (make_unibyte_string, make_multibyte_string)
3462 (make_string_from_bytes, make_specified_string)
3463 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3464 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3466 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3467 (allocate_pseudovector):
3468 Use int, not EMACS_INT, where int is wide enough.
3469 (inhibit_garbage_collection, Fgarbage_collect):
3470 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3471 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3472 int might not be wide enough.
3473 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3474 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3475 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3476 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3477 (bidi_level_of_next_char, bidi_move_to_visually_next):
3478 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3479 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3480 (Fkill_buffer, Fset_buffer_major_mode)
3481 (advance_to_char_boundary, Fbuffer_swap_text)
3482 (Fset_buffer_multibyte, overlays_at, overlays_in)
3483 (overlay_touches_p, struct sortvec, record_overlay_string)
3484 (overlay_strings, recenter_overlay_lists)
3485 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3486 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3487 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3488 (Foverlay_recenter, last_overlay_modification_hooks_used)
3489 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3490 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3491 (validate_region): Omit unnecessary test for b <= e,
3492 since that's guaranteed by the previous test.
3493 (adjust_overlays_for_delete): Avoid pos + length overflow.
3494 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3495 (report_overlay_modification):
3496 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3497 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3498 Omit pointer cast, which isn't needed anyway, and doesn't work
3499 after the EMACS_INT -> ptrdiff_t change.
3500 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
3501 * buffer.h: Adjust decls to match defn changes elsewhere.
3502 (struct buffer_text, struct buffer):
3503 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3504 Use EMACS_INT, not int, where int might not be wide enough.
3505 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3506 not int, to avoid needless 32-bit limit on 64-bit hosts.
3507 (exec_byte_code): Use tighter memory-full test, one that checks
3508 for alloca overflow. Don't compute the address of the object just
3509 before an array, as that's not portable. Use EMACS_INT, not
3510 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
3511 * callint.c (Fcall_interactively):
3512 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3513 * callproc.c (call_process_kill, Fcall_process):
3514 Don't assume pid_t fits into an Emacs fixnum.
3515 (call_process_cleanup, Fcall_process, child_setup):
3516 Don't assume pid_t fits into int.
3517 (call_process_cleanup, Fcall_process, delete_temp_file)
3518 (Fcall_process_region):
3519 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3520 (Fcall_process): Simplify handling of volatile integers.
3521 Use int, not EMACS_INT, where int will do.
3522 * casefiddle.c (casify_object, casify_region, operate_on_word)
3523 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3524 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3525 (casify_object): Avoid integer overflow when overallocating buffer.
3526 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
3527 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
3528 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3529 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3530 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3531 integers are now checked earlier. All uses replaced with XINT.
3533 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3534 For CCL_MapSingle, check that content and value are in int range.
3535 (ccl_driver, Fregister_code_conversion_map):
3536 Check that Vcode_version_map_vector is a vector.
3537 (resolve_symbol_ccl_program): Check that vector header is in range.
3538 Always copy the vector, so that we can check its contents reliably
3539 now rather than having to recheck each instruction as it's being
3540 executed. Check that vector words fit in 'int'.
3541 (ccl_get_compiled_code, Fregister_ccl_program)
3542 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3543 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3544 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3545 contents are in range.
3546 (Fccl_execute_on_string): Check that status is in range.
3547 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3548 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3549 Accept and return EMACS_INT, not int, because callers can pass values
3551 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3552 (multibyte_chars_in_text, parse_str_as_multibyte)
3553 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3554 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3555 (string_escape_byte8, Fget_byte):
3556 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3557 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
3558 avoid mishandling large integers.
3559 * character.h: Adjust decls to match defn changes elsewhere.
3560 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3561 (Ffind_charset_region):
3562 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3563 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3564 (load_charset_map_from_vector, Fdefine_charset_internal):
3565 Don't assume fixnum fits in int.
3566 (load_charset_map_from_vector, Fmap_charset_chars):
3567 Remove now-unnecessary CHECK_NATNUMs.
3568 (Fdefine_charset_internal): Check ranges here, more carefully.
3569 Don't rely on undefined behavior with signed left shift overflow.
3570 Don't assume unsigned int fits into fixnum, or that fixnum fits
3571 into unsigned int. Don't require max_code to be a valid fixnum;
3572 that's not true for gb10830 4-byte on a 32-bit host. Allow
3573 invalid_code to be a cons, for the same reason. Require code_offset
3574 to be a character. Avoid int overflow if max_char is close
3576 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3577 this is intended anyway and avoids some undefined behavior.
3578 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3579 INDEX_TO_CODE_POINT, as that's what it expects.
3580 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
3581 * charset.h (DECODE_CHAR): Return int, not unsigned;
3582 this is what was intended anyway, and it avoids undefined behavior.
3583 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3584 integer-overflow issues.
3585 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3586 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3587 where the argument is EMACS_INT, and this behavior is not intended.
3588 * chartab.c (Fmake_char_table, Fset_char_table_range)
3589 (uniprop_get_decoder, uniprop_get_encoder):
3590 Don't assume fixnum fits in int.
3591 * cmds.c (move_point): New function, that does the gist of
3592 Fforward_char and Fbackward_char, but does so while checking
3593 for integer overflow more accurately.
3594 (Fforward_char, Fbackward_char): Use it.
3595 (Fforward_line, Fend_of_line, internal_self_insert)
3596 (internal_self_insert):
3597 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3598 Fix a FIXME, by checking for integer overflow when calculating
3599 target_clm and actual_clm.
3600 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
3601 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
3602 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3603 (coding_alloc_by_making_gap, alloc_destination)
3604 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3605 (encode_coding_utf_16, detect_coding_emacs_mule)
3606 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3607 (detect_coding_iso_2022, decode_coding_iso_2022)
3608 (encode_invocation_designation, encode_designation_at_bol)
3609 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3610 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3611 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3612 (encode_coding_ccl, encode_coding_raw_text)
3613 (detect_coding_charset, decode_coding_charset)
3614 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3615 (produce_composition, produce_charset, produce_annotation)
3616 (decode_coding, handle_composition_annotation)
3617 (handle_charset_annotation, consume_chars, decode_coding_gap)
3618 (decode_coding_object, encode_coding_object, detect_coding_system)
3619 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3620 (code_convert_region, code_convert_string)
3621 (Fdefine_coding_system_internal)
3622 (coding_set_source, coding_set_destination):
3623 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3624 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3625 (Fdefine_coding_system_internal):
3626 Don't assume fixnums fit in int.
3627 (decode_coding_gap, decode_coding_object, encode_coding_object)
3628 (Fread_coding_system, Fdetect_coding_region)
3629 (Funencodable_char_position, Fcheck_coding_systems_region)
3630 (get_translation, handle_composition_annotation, consume_chars):
3631 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3632 (consume_chars): Rewrite to not calculate an address outside buffer.
3633 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
3634 Don't access memory outside of the args array.
3635 (Fdefine_coding_system_internal): Check for charset-id overflow.
3636 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3637 result of ENCODE_CHAR.
3638 * coding.h: Adjust decls to match defn changes elsewhere.
3639 (struct coding_system):
3640 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3641 * composite.c (get_composition_id, find_composition)
3642 (run_composition_function, update_compositions)
3643 (compose_text, composition_gstring_put_cache)
3644 (composition_gstring_p, composition_gstring_width)
3645 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3646 (composition_compute_stop_pos, composition_reseat_it)
3647 (composition_update_it, struct position_record)
3648 (find_automatic_composition, composition_adjust_point)
3649 (Fcomposition_get_gstring, Ffind_composition_internal):
3650 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3651 (update_compositions):
3652 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3653 * composite.h: Adjust decls to match defn changes elsewhere.
3654 (struct composition):
3655 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3656 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3657 Do not attempt to compute the address of the object just before a
3658 buffer; this is not portable.
3660 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3661 (Faset): Use int, not EMACS_INT, where int is wide enough.
3662 (Fstring_to_number): Don't assume fixnums fit in int.
3663 (Frem): Don't assume arg is nonnegative.
3664 * dbusbind.c (xd_append_arg): Check for integers out of range.
3665 (Fdbus_call_method): Don't overflow the timeout int.
3666 (extract_signed, extract_unsigned): New functions.
3667 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3668 (xd_get_connection_references): Return ptrdiff_t, not int.
3670 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3671 (xd_read_message_1):
3672 Use int, not unsigned, where the dbus API uses int.
3673 (Fdbus_message_internal): Don't overflow mtype.
3674 (syms_of_dbusbind): Allocate right-sized buffer for integers.
3675 * dired.c (directory_files_internal, file_name_completion, scmp)
3676 (file_name_completion_stat):
3677 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3678 (file_name_completion): Don't overflow matchcount.
3679 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3680 * dispextern.h: Adjust decls to match defn changes elsewhere.
3681 (struct text_pos, struct glyph, struct bidi_saved_info)
3682 (struct bidi_string_data, struct bidi_it, struct composition_it)
3684 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3685 (struct display_pos, struct composition_it, struct it):
3686 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3687 * dispnew.c (increment_matrix_positions)
3688 (increment_row_positions, mode_line_string)
3689 (marginal_area_string):
3690 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3691 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
3692 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3693 (duration_to_sec_usec): New function, to check for overflow better.
3694 (Fsleep_for, sit_for): Use it.
3695 * doc.c (get_doc_string, store_function_docstring):
3696 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3697 (get_doc_string, Fsnarf_documentation):
3698 Use int, not EMACS_INT, where int is wide enough.
3700 Use SAFE_ALLOCA, not alloca.
3701 Check for overflow when converting EMACS_INT to off_t.
3702 * doprnt.c (doprnt):
3703 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3704 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3705 Don't assume uid_t fits into fixnum.
3706 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3707 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3708 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3709 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3710 (general_insert_function)
3711 (Finsert_char, make_buffer_string, make_buffer_string_both)
3712 (update_buffer_properties, Fbuffer_substring)
3713 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3714 (Fsubst_char_in_region, check_translation)
3715 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3716 (transpose_markers, Ftranspose_regions):
3717 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3718 (clip_to_bounds): Move to lisp.h as an inline function).
3719 (Fconstrain_to_field): Don't assume integers are nonnegative.
3720 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3721 (Fsubst_char_in_region, Fsave_restriction):
3722 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3723 (Femacs_pid): Don't assume pid_t fits into fixnum.
3724 (lo_time): Use int, not EMACS_INT, when int suffices.
3725 (lisp_time_argument): Check for usec out of range.
3726 (Fencode_time): Don't assume fixnum fits in int.
3727 (Fuser_login_name, Fuser_full_name): Signal an error
3728 if a uid argument is out of range, rather than relying on
3730 (Fformat_time_string): Remove now-unnecessary check.
3731 lisp_time_argument checks for out-of-range usec now.
3732 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
3733 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3734 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3735 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3736 (init_cmdargs, Fdump_emacs):
3737 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3738 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3739 the bottom (typically) 32 bits of the fixnum.
3740 * eval.c (specpdl_size, call_debugger):
3741 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3742 (when_entered_debugger, Fbacktrace_debug):
3743 Don't assume fixnum can fit in int.
3744 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3745 the object just before a buffer; this is not portable.
3746 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3747 (grow_specpdl, unbind_to):
3748 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3749 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3750 (grow_specpdl): Simplify allocation by using xpalloc.
3751 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
3752 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3753 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3754 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3755 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3757 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3758 (Fcopy_file, non_regular_nbytes, read_non_regular)
3759 (Finsert_file_contents):
3760 Use int, not EMACS_INT, where int is wide enough.
3761 (READ_BUF_SIZE): Verify that it fits in int.
3762 (Finsert_file_contents): Check that counts are in proper range,
3763 rather than assuming fixnums fit into ptrdiff_t etc.
3764 Don't assume fixnums fit into int.
3765 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
3766 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3767 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
3768 (string_char_to_byte, string_byte_to_char)
3769 (string_make_multibyte, string_to_multibyte)
3770 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3771 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3772 (substring_both, Fdelete, internal_equal, Ffillarray)
3773 (Fclear_string, mapcar1)
3774 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3775 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3776 (larger_vector, make_hash_table, maybe_resize_hash_table)
3777 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3778 (Fmaphash, secure_hash):
3779 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3780 (concat): Check for string index and length overflow.
3781 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3783 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3784 (larger_vector): New API (vec, incr_min, size_max) replaces old
3785 one (vec, new_size, init). This catches size overflow.
3786 INIT was removed because it was always Qnil.
3787 All callers changed.
3788 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3789 the upper bound on a hash table index size.
3790 (make_hash_table, maybe_resize_hash_table): Use it.
3791 (secure_hash): Computer start_byte and end_byte only after
3792 they're known to be in ptrdiff_t range.
3793 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3794 (Ffont_get_glyphs, Ffont_at):
3795 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3796 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3797 (Flist_fonts, Fopen_font):
3798 Don't assume fixnum can fit in int.
3799 (check_gstring): Don't assume index can fit in int.
3800 (font_match_p): Check that fixnum is a character, not a nonnegative
3801 fixnum, since the later code needs to stuff it into an int.
3802 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3803 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3804 conversion overflow issues.
3805 (Fopen_font): Check for integer out of range.
3806 (Ffont_get_glyphs): Don't assume index can fit in int.
3807 * font.h: Adjust decls to match defn changes elsewhere.
3808 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3810 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3811 printmax_t, where ptrdiff_t is wide enough.
3812 (Finternal_char_font):
3813 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3814 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3815 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3816 (Fset_frame_position, x_set_frame_parameters)
3817 (x_set_line_spacing, x_set_border_width)
3818 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3819 Check that fixnums are in proper range for system types.
3820 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3821 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3822 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3823 Use SAFE_ALLOCA_LISP, not alloca.
3824 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3825 intptr_t is wide enough.
3826 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3827 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3828 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3829 Check for fixnum out of range.
3830 * ftfont.c (ftfont_list): Don't assume index fits in int.
3831 Check that fixnums are in proper range for system types.
3832 (ftfont_shape_by_flt):
3833 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3834 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3835 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3836 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3837 Check that fixnums are in proper range for system types.
3838 * gnutls.h: Adjust decls to match defn changes elsewhere.
3839 * gtkutil.c (xg_dialog_run):
3840 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3841 (update_frame_tool_bar):
3842 Check that fixnums are in proper range for system types.
3843 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
3844 (lookup_image): Check that fixnums are in range for system types.
3845 * indent.c (last_known_column, last_known_column_point):
3846 (current_column_bol_cache):
3847 (skip_invisible, current_column, check_display_width):
3848 (check_display_width, scan_for_column, current_column_1)
3849 (Findent_to, Fcurrent_indentation, position_indentation)
3850 (indented_beyond_p, Fmove_to_column, compute_motion):
3851 (Fcompute_motion, Fvertical_motion):
3852 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3853 (last_known_column_modified): Use EMACS_INT, not int.
3854 (check_display_width):
3856 Check that fixnums and floats are in proper range for system types.
3857 (compute_motion): Don't assume index or fixnum fits in int.
3858 (compute_motion, Fcompute_motion):
3859 Use int, not EMACS_INT, when it is wide enough.
3860 (vmotion): Omit local var start_hpos that is always 0; that way
3861 we don't need to worry about overflow in expressions involving it.
3862 * indent.h: Adjust decls to match defn changes elsewhere.
3864 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3865 Use int, not EMACS_INT, where int is wide enough.
3866 Remove unused members ovstring_chars_done and tab_offset;
3868 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3869 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3870 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3871 (make_gap, copy_text, insert, insert_and_inherit)
3872 (insert_before_markers, insert_before_markers_and_inherit)
3873 (insert_1, count_combining_before, count_combining_after)
3874 (insert_1_both, insert_from_string)
3875 (insert_from_string_before_markers, insert_from_string_1)
3876 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3877 (adjust_after_replace, adjust_after_insert, replace_range)
3878 (replace_range_2, del_range, del_range_1, del_range_byte)
3879 (del_range_both, del_range_2, modify_region)
3880 (prepare_to_modify_buffer, signal_before_change)
3881 (signal_after_change, Fcombine_after_change_execute):
3882 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3883 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3884 (balance_an_interval, split_interval_right, split_interval_left)
3885 (find_interval, next_interval, update_interval)
3886 (adjust_intervals_for_insertion, delete_node, delete_interval)
3887 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3888 (static_offset_intervals, offset_intervals)
3889 (merge_interval_right, merge_interval_left, make_new_interval)
3890 (graft_intervals_into_buffer, temp_set_point_both)
3891 (temp_set_point, set_point, adjust_for_invis_intang)
3892 (set_point_both, move_if_not_intangible, get_property_and_range)
3893 (get_local_map, copy_intervals, copy_intervals_to_string)
3894 (compare_string_intervals, set_intervals_multibyte_1):
3895 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3896 * intervals.h: Adjust decls to match defn changes elsewhere.
3898 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3899 * keyboard.c (this_command_key_count, this_single_command_key_start)
3900 (before_command_key_count, before_command_echo_length, echo_now)
3901 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3902 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3903 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3904 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3905 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3906 (last_non_minibuf_size, last_point_position, echo_truncate)
3907 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3908 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3909 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3910 (stuff_buffered_input):
3911 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3912 (last_auto_save, command_loop_1, read_char):
3913 Use EMACS_INT, not int, to avoid integer overflow.
3914 (record_char): Avoid overflow in total_keys computation.
3915 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3916 * keyboard.h: Adjust decls to match defn changes elsewhere.
3917 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3918 (Fkey_description, Fdescribe_vector, Flookup_key):
3919 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3920 (click_position): New function, to check that positions are in range.
3921 (Fcurrent_active_maps):
3923 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3924 (Faccessible_keymaps, Fkey_description):
3925 (preferred_sequence_p):
3926 Don't assume fixnum can fit into int.
3927 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3928 Check for integer overflow in size calculations.
3929 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3930 avoid mishandling large integers.
3931 * lisp.h: Adjust decls to match defn changes elsewhere.
3932 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3933 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3934 (struct Lisp_Marker):
3935 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3936 (clip_to_bounds): Now an inline function, moved here from editfns.c.
3937 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3938 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3939 All callers changed.
3940 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3941 Assume the arg has valid form, since it always does.
3942 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3943 unsigned integer system type.
3944 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3945 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3946 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3947 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3948 (duration_to_sec_usec): New decl.
3949 * lread.c (read_from_string_index, read_from_string_index_byte)
3950 (read_from_string_limit, readchar, unreadchar, openp)
3951 (read_internal_start, read1, oblookup):
3952 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3953 (Fload, readevalloop, Feval_buffer, Feval_region):
3954 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3955 (openp): Check for out-of-range argument to 'access'.
3956 (read1): Use int, not EMACS_INT, where int is wide enough.
3957 Don't assume fixnum fits into int.
3958 Fix off-by-one error that can read outside a buffer.
3959 (read_filtered_event): Use duration_to_sec_usec
3960 to do proper overflow checking on durations.
3961 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3962 in size calculation.
3963 (Fexecute_kbd_macro):
3964 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3965 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3966 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3967 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3968 (set_marker_both, set_marker_restricted_both, marker_position)
3969 (marker_byte_position, Fbuffer_has_markers_at):
3970 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3971 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
3972 * menu.c (ensure_menu_items): Rename from grow_menu_items.
3973 It now merely ensures that the menu is large enough, without
3974 necessarily growing it, as this avoids some integer overflow issues.
3975 All callers changed.
3976 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3977 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3978 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3979 Use SAFE_ALLOCA_LISP, not alloca.
3980 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3981 to EMACS_INT. Check that fixnums are in proper range for system types.
3982 * minibuf.c (minibuf_prompt_width, string_to_object)
3983 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3984 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3985 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3986 (get_minibuffer, read_minibuf_unwind):
3987 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3988 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3989 this simplifies overflow checking. All callers changed.
3990 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3992 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3993 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3994 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3995 Check that fixnums are in proper range for system types.
3996 (Fx_create_frame, Fx_show_tip):
3997 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3998 * nsfont.m (ns_findfonts, nsfont_list_family):
3999 Don't assume fixnum fits in long.
4000 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
4001 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4002 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
4004 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
4005 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4006 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
4007 (PRINTDECLARE, PRINTPREPARE):
4008 (strout, print_string):
4009 (print, print_preprocess, print_check_string_charset_prop)
4011 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4013 (temp_output_buffer_setup, Fprin1_to_string, print_object):
4014 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4015 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
4016 (printchar, strout): Use xpalloc to catch size calculation overflow.
4017 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
4018 (print_error_message): Use SAFE_ALLOCA, not alloca.
4019 (print_object): Use int, not EMACS_INT, where int is wide enough.
4020 (print_depth, new_backquote_output, print_number_index):
4021 Use ptrdiff_t, not int, where int might not be wide enough.
4022 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
4023 (Fset_process_window_size, Fformat_network_address)
4024 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
4026 Check that fixnums are in proper range for system types.
4027 (Fsignal_process): Simplify by avoiding a goto.
4028 Check for process-ids out of pid_t range rather than relying on
4030 (process_tick, update_tick): Use EMACS_INT, not int.
4031 (Fformat_network_address, read_process_output, send_process)
4032 (Fprocess_send_region, status_notify):
4033 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4034 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4035 (wait_reading_process_output, read_process_output, exec_sentinel):
4036 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4037 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4038 (Faccept_process_output): Use duration_to_sec_usec to do proper
4039 overflow checking on durations.
4040 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4041 Don't assume pid_t fits in int.
4042 * process.h (struct Lisp_Process): Members tick and update_tick
4043 are now of type EMACS_INT, not int.
4044 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4045 configured --with-wide-int.
4046 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4047 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4048 * search.c (looking_at_1, string_match_1):
4049 (fast_string_match, fast_c_string_match_ignore_case)
4050 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4051 (scan_newline, find_before_next_newline, search_command)
4052 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4053 (set_search_regs, wordify):
4056 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4057 (string_match_1, search_buffer, set_search_regs):
4059 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4060 (wordify): Check for overflow in size calculation.
4061 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4062 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4063 Check that fixnums are in proper range for system types.
4064 * sound.c (struct sound_device)
4065 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4066 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4067 (Fplay_sound_internal):
4068 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4069 * syntax.c (struct lisp_parse_state, find_start_modiff)
4070 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4071 (Fparse_partial_sexp):
4072 Don't assume fixnums can fit in int.
4073 (struct lisp_parse_state, find_start_pos, find_start_value)
4074 (find_start_value_byte, find_start_begv)
4075 (update_syntax_table, char_quoted, dec_bytepos)
4076 (find_defun_start, prev_char_comend_first, back_comment):
4077 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4078 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4079 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4080 (Finternal_describe_syntax_value): Check that match_lisp is a
4081 character, not an integer, since the code stuffs it into int.
4082 (scan_words, scan_sexps_forward):
4083 Check that fixnums are in proper range for system types.
4085 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4086 (scan_sexps_forward):
4087 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4088 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4089 * syntax.h: Adjust decls to match defn changes elsewhere.
4090 (struct gl_state_s):
4091 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4092 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4093 MOST_POSITIVE_FIXNUM.
4094 * sysdep.c (wait_for_termination_1, wait_for_termination)
4095 (interruptible_wait_for_termination, mkdir):
4096 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4097 (emacs_read, emacs_write):
4098 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4099 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4100 and double all fit in int.
4101 * term.c (set_tty_color_mode):
4102 Check that fixnums are in proper range for system types.
4103 * termhooks.h (struct input_event):
4104 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4105 * textprop.c (validate_interval_range, interval_of)
4106 (Fadd_text_properties, set_text_properties_1)
4107 (Fremove_text_properties, Fremove_list_of_text_properties)
4108 (Ftext_property_any, Ftext_property_not_all)
4109 (copy_text_properties, text_property_list, extend_property_ranges)
4110 (verify_interval_modification):
4111 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4112 (Fnext_single_char_property_change)
4113 (Fprevious_single_char_property_change):
4114 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4115 (copy_text_properties):
4116 Check for integer overflow in index calculation.
4117 * undo.c (last_boundary_position, record_point, record_insert)
4118 (record_delete, record_marker_adjustment, record_change)
4119 (record_property_change):
4120 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4121 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4122 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4123 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4124 (Fx_hide_tip, Fx_file_dialog):
4125 * w32menu.c (set_frame_menubar):
4126 Use ptrdiff_t, not int, for consistency with rest of code.
4127 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4128 (select_window, Fdelete_other_windows_internal)
4129 (window_scroll_pixel_based, window_scroll_line_based)
4130 (Frecenter, Fset_window_configuration):
4131 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4132 (Fset_window_hscroll, run_window_configuration_change_hook)
4133 (set_window_buffer, temp_output_buffer_show, scroll_command)
4134 (Fscroll_other_window, Frecenter):
4135 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4136 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4137 Don't assume fixnum fits in int.
4138 (Fset_window_scroll_bars):
4139 Check that fixnums are in proper range for system types.
4140 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4141 (string_pos, c_string_pos, number_of_chars, init_iterator)
4142 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4143 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4144 (compute_display_string_end, handle_face_prop)
4145 (face_before_or_after_it_pos, handle_invisible_prop)
4146 (handle_display_prop, handle_display_spec, handle_single_display_spec)
4147 (display_prop_intangible_p, string_buffer_position_lim)
4148 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4149 (get_overlay_strings_1, get_overlay_strings)
4150 (iterate_out_of_display_property, forward_to_next_line_start)
4151 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4152 (get_next_display_element, set_iterator_to_next)
4153 (get_visually_first_element, compute_stop_pos_backwards)
4154 (handle_stop_backwards, next_element_from_buffer)
4155 (move_it_in_display_line_to, move_it_in_display_line)
4156 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4157 (add_to_log, message_dolog, message_log_check_duplicate)
4158 (message2, message2_nolog, message3, message3_nolog
4159 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4160 (current_message_1, truncate_echo_area, truncate_message_1)
4161 (set_message, set_message_1, store_mode_line_noprop)
4162 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4163 (text_outside_line_unchanged_p, check_point_in_composition)
4164 (reconsider_clip_changes)
4165 (redisplay_internal, set_cursor_from_row, try_scrolling)
4166 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4167 (redisplay_window, find_last_unchanged_at_beg_row)
4168 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4169 (trailing_whitespace_p, find_row_edges, display_line)
4170 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4171 (display_mode_element, store_mode_line_string)
4172 (pint2str, pint2hrstr, decode_mode_spec)
4173 (display_count_lines, display_string, draw_glyphs)
4174 (x_produce_glyphs, x_insert_glyphs)
4175 (rows_from_pos_range, mouse_face_from_buffer_pos)
4176 (fast_find_string_pos, mouse_face_from_string_pos)
4177 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4178 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4179 (safe_call, init_from_display_pos, handle_fontified_prop)
4180 (handle_single_display_spec, load_overlay_strings)
4181 (with_echo_area_buffer, setup_echo_area_for_printing)
4182 (display_echo_area, echo_area_display)
4183 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4184 (update_tool_bar, hscroll_window_tree, redisplay_internal)
4185 (redisplay_window, dump_glyph_row, display_mode_line)
4186 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
4187 (handle_display_spec, display_prop_string_p):
4188 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4189 (handle_single_display_spec, build_desired_tool_bar_string)
4190 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4191 (get_specified_cursor_type):
4192 Check that fixnums are in proper range for system types.
4193 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4194 (Flookup_image_map):
4195 Don't assume fixnums fit in int.
4196 (compare_overlay_entries):
4197 Avoid mishandling comparisons due to subtraction overflow.
4198 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4199 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4200 (handle_tool_bar_click):
4201 Use int, not unsigned, since we prefer signed and the signedness
4202 doesn't matter here.
4203 (get_next_display_element, next_element_from_display_vector):
4204 Use int, not EMACS_INT, when int is wide enough.
4205 (start_hourglass): Use duration_to_sec_usec to do proper
4206 overflow checking on durations.
4207 * xfaces.c (Fbitmap_spec_p):
4208 Check that fixnums are in proper range for system types.
4209 (compare_fonts_by_sort_order):
4210 Avoid mishandling comparisons due to subtraction overflow.
4211 (Fx_family_fonts, realize_basic_faces):
4212 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4214 Don't assume fixnum fits in int.
4215 Use SAFE_ALLOCA_LISP, not alloca.
4216 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4217 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4218 (face_at_buffer_position, face_for_overlay_string)
4219 (face_at_string_position):
4220 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4221 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4222 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4224 Check that fixnums are in proper range for system types.
4225 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4226 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4227 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4228 (Fx_change_window_property): Don't assume fixnums fit in int.
4229 * xfont.c (xfont_chars_supported):
4230 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4231 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4232 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4233 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4234 * xml.c (parse_region):
4235 * xrdb.c (magic_file_p):
4236 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4237 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4238 (x_get_local_selection, x_reply_selection_request)
4239 (x_handle_selection_request, wait_for_property_change):
4240 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4241 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4242 short is wide enough.
4243 (x_send_client_event): Don't assume fixnum fits in int.
4244 * xterm.c (x_x_to_emacs_modifiers):
4245 Don't assume EMACS_INT overflows nicely into int.
4246 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4248 (handle_one_xevent): NATNUMP can eval its arg twice.
4249 (x_connection_closed):
4250 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4251 * xterm.h: Adjust decls to match defn changes elsewhere.
4252 (struct scroll_bar): Use struct vectorlike_header
4253 rather than rolling our own approximation.
4254 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4256 2012-05-25 Glenn Morris <rgm@gnu.org>
4258 * lisp.mk (lisp): Update for more files being compiled now.
4260 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4262 * lread.c: Remove `read_pure' which makes no difference.
4263 (read_pure): Remove var.
4264 (unreadpure): Remove function.
4265 (readevalloop): Don't call read_list with -1 flag.
4266 (read1, read_vector): Don't test read_pure any more.
4267 (read_list): Simplify.
4269 * fileio.c, character.h: Minor style tweaks.
4271 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4273 * window.h (clip_changed): Remove useless declaration.
4275 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
4277 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4278 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4280 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4283 This directory predates autoconf and is no longer needed nowadays.
4284 Move its few remaining bits of functionality to where they're needed.
4285 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4286 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4287 * m/template.h: Remove.
4288 * Makefile.in (M_FILE): Remove. All uses removed.
4289 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4290 * lisp.h (USE_LSB_TAG):
4291 * mem-limits.h (EXCEEDS_LISP_PTR):
4292 Use VAL_MAX, not VALBITS, in #if.
4293 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4294 (EMACS_UINT): Define unconditionally now.
4295 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4296 (BITS_PER_EMACS_INT): New constants, replacing
4297 what used to be in config.h, but not useful in #if.
4298 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4299 define them any more.
4300 (VAL_MAX): New macro.
4302 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4303 BITS_PER_EMACS_INT, in #if.
4304 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4305 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4306 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4307 * s/ms-w32.h (DATA_START):
4308 Move here from removed file m/intel386.h.
4309 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4310 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4312 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4314 Assume C89 or later.
4315 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4316 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4318 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4319 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4320 * textprop.c, tparam.c (NULL): Remove.
4321 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4322 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4323 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4324 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4325 * xterm.c (input_signal_count): Assume volatile works.
4327 2012-05-21 Ken Brown <kbrown@cornell.edu>
4329 * xgselect.c (xg_select): Fix first argument in call to 'select'
4332 2012-05-20 Ken Brown <kbrown@cornell.edu>
4334 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
4335 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
4337 2012-05-19 Ken Brown <kbrown@cornell.edu>
4339 * xfns.c (x_in_use): Remove `static' qualifier.
4340 * xterm.h (x_in_use): Declare.
4341 * xgselect.c: Include xterm.h.
4342 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4343 and `display_arg' (bug#9754).
4345 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4347 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4349 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4350 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4352 2012-05-18 Eli Zaretskii <eliz@gnu.org>
4354 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4356 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
4357 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
4359 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4360 reference to image_cache->refcount.
4361 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4363 2012-05-17 Juri Linkov <juri@jurta.org>
4365 * search.c (Fword_search_regexp, Fword_search_backward)
4366 (Fword_search_forward, Fword_search_backward_lax)
4367 (Fword_search_forward_lax): Move functions to isearch.el
4368 (bug#10145, bug#11381).
4370 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4372 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4374 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4376 * lread.c (init_obarray): Declare Qt and Qnil as special.
4378 2012-05-14 Glenn Morris <rgm@gnu.org>
4380 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
4381 Put "libexec" before "bin", for the sake of init_callproc_1.
4383 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4385 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4387 * unexaix.c: Port to more-recent AIX compilers.
4388 (report_error, report_error_1, make_hdr, copy_sym)
4389 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4390 Make arguments const char *, not char *, to avoid violations of C
4391 standard and to fix some AIX warnings reported by Gilles Pion.
4393 2012-05-14 Eli Zaretskii <eliz@gnu.org>
4395 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4396 already have overlays loaded.
4397 (handle_single_display_spec): Before returning without displaying
4398 fringe bitmap, synchronize the bidi iterator with the main display
4399 iterator, by calling iterate_out_of_display_property.
4400 (iterate_out_of_display_property): Detect buffer iteration by
4401 testing that it->string is a Lisp string.
4402 (get_next_display_element): When the current object is exhausted,
4403 and there's something on it->stack, call set_iterator_to_next to
4404 proceed with what's on the stack, instead of returning zero.
4405 (set_iterator_to_next): If called at the end of a Lisp string,
4406 proceed to consider_string_end without incrementing string
4407 position. Don't increment display vector index past the end of
4408 the display vector. (Bug#11417)
4409 (pos_visible_p): Don't report a position visible when move_it_to
4410 stopped at the last line of window, which happens to be scanned
4411 backwards by the bidi iteration. (Bug#11464)
4413 2012-05-14 Eli Zaretskii <eliz@gnu.org>
4415 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4416 and right-margin display specs even if the spec is invalid or we
4417 are on a TTY, and thus unable to display on the fringes.
4418 That's because the text with the property will not be displayed anyway,
4419 so we need to signal to the caller that this is a "replacing"
4420 display spec. This fixes display when the spec is invalid or we
4423 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4425 * unexaix.c (make_hdr): Fix typo in prototype.
4426 This bug broke the build on AIX. Problem reported by Gilles Pion.
4428 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
4430 * keyboard.c (kbd_buffer_get_event): Read special events also in
4431 batch mode. (Bug#11415)
4433 2012-05-12 Glenn Morris <rgm@gnu.org>
4435 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4437 2012-05-12 Eli Zaretskii <eliz@gnu.org>
4439 * lisp.mk (lisp): Add newcomment.elc.
4441 2012-05-12 Glenn Morris <rgm@gnu.org>
4443 * Makefile.in (MKDIR_P): New, set by configure.
4444 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4446 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4448 Remove unused function hourglass_started.
4449 * dispextern.h (hourglass_started):
4450 * w32fns.c (hourglass_started):
4451 * xdisp.c (hourglass_started): Remove.
4453 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
4455 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4456 Update dependencies.
4458 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4460 * xgselect.c (xg_select): Put maxfds+1 into a var.
4461 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4463 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4465 2012-05-10 Dave Abrahams <dave@boostpro.com>
4467 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4468 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4470 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
4472 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4473 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4474 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4475 Initialize xd_registered_buses.
4477 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4479 Untag more efficiently if USE_LSB_TAG.
4480 This is based on a proposal by YAMAMOTO Mitsuharu in
4481 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4482 For an admittedly artificial (nth 8000 longlist) benchmark on
4483 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4484 Emacs's overall text size by 1%.
4485 * lisp.h (XUNTAG): New macro.
4486 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4487 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4488 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4489 * eval.c (Fautoload):
4490 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4491 * frame.h (XFRAME): Use XUNTAG.
4493 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4494 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4495 Remove unportable assumptions about print widths of types like
4497 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4498 intptr_t when converting between pointer and integer, to avoid GCC
4499 warnings about wrong width.
4501 2012-05-09 Eli Zaretskii <eliz@gnu.org>
4503 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4504 stack for each reader_thread, instead of defaulting to 8MB
4505 determined by the linker. This avoids failures in creating
4506 subprocesses on Windows 7, see the discussion in this thread:
4507 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4509 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4511 Fix up display of the *Minibuf-0* buffer in the mini window.
4512 * keyboard.c (read_char): Don't clear the echo area if there's no
4514 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
4515 contents of *Minibuf-0*) if there's no message displayed in its stead.
4517 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
4519 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4522 2012-05-06 Chong Yidong <cyd@gnu.org>
4524 * lisp.mk (lisp): Update.
4526 2012-05-05 Jim Meyering <meyering@redhat.com>
4528 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4530 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4532 * data.c (PUT_ERROR): New macro.
4533 (syms_of_data): Use it. Add new error type `user-error'.
4534 * undo.c (user_error): New function.
4535 (Fprimitive_undo): Use it.
4536 * print.c (print_error_message): Adjust print style for `user-error'.
4537 * keyboard.c (user_error): New function.
4538 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4540 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4542 Do not limit current-time-string to years 1000..9999.
4543 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4544 (Fcurrent_time_string): Support any year that is supported by the
4545 underlying localtime representation. Don't use asctime, as it
4546 has undefined behavior for years outside the range -999..9999.
4548 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4550 Fix race conditions involving setenv, gmtime, localtime, asctime.
4551 Without this fix, interrupts could mess up code that uses these
4552 nonreentrant functions, since setting TZ invalidates existing
4553 tm_zone or tzname values, and since most of these functions return
4554 pointers to static storage.
4555 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4556 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4557 Grow the critical sections to include not just invoking
4558 localtime/gmtime, but also accessing these functions' results
4559 including their tm_zone values if any, and any related TZ setting.
4560 (format_time_string): Last arg is now struct tm *, not struct tm **,
4561 so that the struct tm is saved in the critical section.
4562 All callers changed. Simplify allocation of initial buffer, partly
4563 motivated by the fact that memory allocation needs to be outside
4564 the critical section.
4566 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4568 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4569 with RESET_INTERVAL.
4571 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4572 Remove duplicated buffer name initialization.
4574 2012-05-02 Jim Meyering <jim@meyering.net>
4576 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4578 * xfns.c (x_window): Use xstrdup (Bug#11375).
4580 2012-05-02 Eli Zaretskii <eliz@gnu.org>
4582 * xdisp.c (pos_visible_p): If already at a newline from the
4583 display string before the 'while' loop, don't walk back the glyphs
4584 from it3.glyph_row. Solves assertion violation when the display
4585 string begins with a newline (egg.el). (Bug#11367)
4587 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4589 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4592 2012-05-01 Glenn Morris <rgm@gnu.org>
4594 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4595 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4596 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4597 All were removed before 23.1.
4599 * dispnew.c: Remove HAVE_LIBNCURSES test;
4600 it is always true on relevant platforms.
4602 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4603 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4605 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4607 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4609 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4610 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4613 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4615 Do not avoid creating empty evaporating overlays (Bug#9642).
4616 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4617 That is, do not delete an evaporating overlay if it becomes
4618 empty after its bounds are adjusted to fit within its buffer.
4619 This fix caused other problems, and I'm reverting it until we get
4620 to the bottom of them.
4622 2012-04-27 Chong Yidong <cyd@gnu.org>
4624 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4626 2012-04-27 Eli Zaretskii <eliz@gnu.org>
4628 * xdisp.c (pos_visible_p): If the window start position is beyond
4629 ZV, start the display from buffer beginning. Prevents assertion
4630 violation in init_iterator when the minibuffer window is scrolled
4633 * window.c (window_scroll_pixel_based): Likewise.
4635 2012-04-27 Chong Yidong <cyd@gnu.org>
4637 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4639 2012-04-27 Glenn Morris <rgm@gnu.org>
4641 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4642 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4644 2012-04-27 Eli Zaretskii <eliz@gnu.org>
4646 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4647 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
4649 2012-04-26 Eli Zaretskii <eliz@gnu.org>
4651 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4652 display element, check also the underlying string or buffer
4653 character. (Bug#11341)
4655 * w32menu.c: Include w32heap.h.
4656 (add_menu_item): If the call to AppendMenuW (via
4657 unicode_append_menu) fails, disable Unicode menus only if we are
4658 running on Windows 9X/Me.
4660 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4662 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4663 (xgetint): Add missing shift for LSB tags.
4665 2012-04-24 Martin Rudalics <rudalics@gmx.at>
4667 * keyboard.c (read_char): Don't wipe echo area for select window
4668 events: These might get delayed via `mouse-autoselect-window'
4671 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
4673 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4674 manipulation of :loaded-from data.
4676 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
4678 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4679 now a cons (bug#11311).
4681 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4683 Do not create empty overlays with the evaporate property (Bug#9642).
4684 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4685 if it becomes empty after its bounds are adjusted to fit within
4686 its buffer. Without this fix, in a nonempty buffer (let ((o
4687 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4688 yields an empty overlay that has the evaporate property, which is
4689 not supposed to happen.
4691 Fix minor GTK3 problems found by static checking.
4692 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4693 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4694 (struct _EmacsFixedClass, emacs_fixed_get_type):
4695 Move decls here from emacsgtkfixed.h, since they needn't be public.
4696 (emacs_fixed_get_type): Now static.
4697 (emacs_fixed_class_init): Omit unused local.
4698 (emacs_fixed_child_type): Remove; unused.
4699 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4700 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4701 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4702 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4703 (EMACS_FIXED_GET_CLASS): Remove; unused.
4704 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4706 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4707 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4709 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4711 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
4712 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
4713 (__malloc_size_t, __malloc_ptrdiff_t):
4714 Remove. All uses removed, replaced by the definiens if needed,
4715 since we can assume C89 or better now.
4716 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4717 (protect_malloc_state, align, get_contiguous_space)
4718 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4719 (malloc_atfork_handler_child, malloc_enable_thread)
4720 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4721 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4722 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4723 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4724 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4725 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4726 Define using prototypes, not old style.
4727 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4728 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4729 (align): Don't assume that signed integer overflow wraps around.
4730 Omit unused local var.
4731 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4732 (_free_internal_nolock, memalign, mallochook, reallochook):
4733 Omit no-longer-needed casts.
4734 (valloc): Use getpagesize, not __getpagesize.
4735 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4736 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4738 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4740 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
4742 Move functions from C to Lisp. Make non-blocking method calls
4743 the default. Implement further D-Bus standard interfaces.
4745 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4746 (QCdbus_request_name_allow_replacement)
4747 (QCdbus_request_name_replace_existing)
4748 (QCdbus_request_name_do_not_queue)
4749 (QCdbus_request_name_reply_primary_owner)
4750 (QCdbus_request_name_reply_in_queue)
4751 (QCdbus_request_name_reply_exists)
4752 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4753 (QCdbus_registered_serial, QCdbus_registered_method)
4754 (QCdbus_registered_signal): New Lisp objects.
4755 (XD_DEBUG_MESSAGE): Use sizeof.
4756 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4757 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4758 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4759 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4760 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4761 (xd_signature, xd_append_arg): Allow float for integer types.
4762 (xd_get_connection_references): New function.
4763 (xd_get_connection_address): Rename from xd_initialize.
4764 Return cached address.
4765 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4766 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4768 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
4769 Return number of refcounts.
4770 (Fdbus_get_unique_name): Make stronger parameter check.
4771 (Fdbus_message_internal): New defun.
4772 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4773 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4774 (Fdbus_send_signal, Fdbus_register_service)
4775 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4776 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4777 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4778 (Vdbus_compiled_version, Vdbus_runtime_version)
4779 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4780 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4781 (Vdbus_message_type_signal): New defvars.
4782 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4785 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4787 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4788 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4789 Do not assume ptrdiff_t is the same width as 'int'.
4791 * alloc.c: Handle unusual debugging option combinations.
4792 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4793 since the two debugging options are incompatible.
4794 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4796 (mem_init, mem_insert, mem_insert_fixup):
4797 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4798 (NEED_MEM_INSERT): Remove; no longer needed.
4800 2012-04-22 Leo Liu <sdl.web@gmail.com>
4802 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4804 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4806 * sysdep.c [__FreeBSD__]: Minor cleanups.
4807 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4808 Use Emacs indenting style more consistently. Avoid some casts.
4809 Use 'double' consistently rather than mixing 'float' and 'double'.
4811 2012-04-21 Eduard Wiebe <usenet@pusto.de>
4813 * sysdep.c (list_system_processes, system_process_attributes):
4814 Add implementation for FreeBSD (Bug#5243).
4816 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4818 * lisp.mk (lisp): Update.
4820 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4822 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4823 It is never used otherwise.
4825 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4827 * print.c (print_preprocess): Only check print_depth if print-circle
4829 (print_object): Check for cycles even when print-circle is nil and
4830 print-gensym is t, but only check print_depth if print-circle is nil.
4832 2012-04-20 Chong Yidong <cyd@gnu.org>
4834 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4835 set the status to "failed" and ensure that sentinel is run.
4837 2012-04-20 Glenn Morris <rgm@gnu.org>
4839 * process.c (Fset_process_inherit_coding_system_flag)
4840 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4841 (Fmake_network_process, Fmake_serial_process): Doc fix.
4843 2012-04-20 Eli Zaretskii <eliz@gnu.org>
4845 * xdisp.c (string_buffer_position_lim): Limit starting position to
4847 (set_cursor_from_row): If called for a mode-line or header-line
4848 row, return zero immediately.
4849 (try_cursor_movement): If inside continuation line, don't back up
4850 farther than the first row after the header line, if any.
4851 Don't consider the header-line row as "partially visible", even if
4852 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4854 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
4856 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4859 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
4860 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
4862 configure: new option --enable-gcc-warnings (Bug#11207)
4863 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4864 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4865 (ALL_CFLAGS): Use new macros rather than old.
4866 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4867 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4868 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4869 -Wunused-result, -Wunused-variable. This should go away once
4870 the Emacs and Gnulib regex code is merged.
4871 (xmalloc, xrealloc): Now static.
4873 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4875 * dired.c (Fsystem_groups): Remove unused local.
4877 2012-04-17 Glenn Morris <rgm@gnu.org>
4879 * dired.c (Fsystem_users): Doc fix.
4881 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4883 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4884 (syms_of_dired): Add them.
4886 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4888 Fix minor alloc.c problems found by static checking.
4889 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4890 New extern decls, to avoid calling undeclared functions.
4891 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4892 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4893 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4894 (NEED_MEM_INSERT): New macro.
4895 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4896 Remove one incorrect comment and fix another.
4898 Fix minor ralloc.c problems found by static checking.
4899 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4900 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4901 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4902 (r_alloc_sbrk): Now static.
4904 Improve ralloc.c interface checking.
4905 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4906 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4907 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4908 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4909 [REL_ALLOC]: ... to here, to check interface.
4910 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4911 Remove decls. This fixes an "It stinks!".
4913 * alloc.c (which_symbols): Fix alignment issue / type clash.
4915 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4917 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4918 (struct Lisp_Misc_Any): Likewise.
4919 (struct Lisp_Free): Likewise.
4920 * alloc.c (union aligned_Lisp_Symbol): Define.
4921 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4922 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4923 (union aligned_Lisp_Misc): Define.
4924 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4925 aligned_Lisp_Misc instead of union Lisp_Misc.
4926 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
4928 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4930 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4931 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4932 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4933 * s/netbsd.h, s/sol2-6.h:
4934 Remove definition of GC_MARK_STACK, since the default now works.
4935 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4936 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4937 no longer the default.
4938 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4940 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
4942 * lread.c (lisp_file_lexically_bound_p):
4943 Fix hang at ";-*-\n" (bug#11238).
4945 2012-04-14 Eli Zaretskii <eliz@gnu.org>
4947 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4948 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4950 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4952 * nsterm.m (constrainFrameRect): Always constrain when there is only
4953 one screen (Bug#10962).
4955 2012-04-13 Ken Brown <kbrown@cornell.edu>
4957 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4959 2012-04-13 Reuben Thomas <rrt@sc3d.org>
4961 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4963 2012-04-11 Daniel Colascione <dancol@dancol.org>
4965 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4966 against is gone. It's better to use vfork now so that when Cygwin
4967 gains a new, working vfork, we use it automatically (bug#10398).
4969 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4971 * window.c (save_window_save): Obey window-point-insertion-type.
4973 2012-04-11 Glenn Morris <rgm@gnu.org>
4975 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4977 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4979 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4981 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
4983 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4984 (force_quit_count): New var.
4985 (handle_interrupt): Use it.
4987 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
4989 * w32.c (w32_delayed_load): Record the full path of the library
4990 being loaded (bug#10424).
4992 2012-04-09 Glenn Morris <rgm@gnu.org>
4994 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4995 not just in the obarray, before snarfing them. (Bug#11036)
4997 * Makefile.in ($(leimdir)/leim-list.el):
4998 Pass EMACS rather than BUILT_EMACS.
5000 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
5002 * process.c (make_process):
5003 * process.h: Add integer `gnutls_handshakes_tried' member to
5006 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
5007 Add convenience `GNUTLS_LOG2i' macro.
5009 * gnutls.c (gnutls_log_function2i): Convenience log function.
5010 (emacs_gnutls_read): Use new log functions,
5011 `gnutls_handshakes_tried' process member, and
5012 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
5013 attempts per process (connection).
5015 2012-04-09 Chong Yidong <cyd@gnu.org>
5017 * eval.c (Fuser_variable_p, user_variable_p_eh)
5018 (lisp_indirect_variable): Functions deleted.
5019 (Fdefvar): Caller changed.
5021 * callint.c (Finteractive, Fcall_interactively):
5022 * minibuf.c (Fread_variable): Callers changed.
5024 2012-04-09 Eli Zaretskii <eliz@gnu.org>
5026 * xdisp.c (set_cursor_from_row): If the display string appears in
5027 the buffer at position that is closer to point than the position
5028 after the display string, display the cursor on the first glyph of
5029 the display string. Fixes cursor display when a 'display' text
5030 property immediately follows invisible text. (Bug#11094)
5032 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5034 composite.c: use 'double' consistently
5035 * composite.c (get_composition_id): Use 'double' consistently
5036 instead of converting 'float' to 'double' and vice versa; this is
5037 easier to understand and avoids a GCC warning.
5039 2012-04-09 Glenn Morris <rgm@gnu.org>
5041 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5042 preparation for dumping it with emacs. (Bug#4789)
5043 (leimdir): New variable.
5044 ($(leimdir)/leim-list.el): New rule.
5045 (emacs$(EXEEXT)): Depend on leim-list.el.
5047 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5048 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5049 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5051 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5053 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5056 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
5058 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5059 Remove unused local variable.
5061 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5063 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5064 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5065 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5066 objects, as mark_maybe_pointer will catch them otherwise.
5067 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5068 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5070 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5072 Fix typo that broke non-Windows builds.
5073 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5075 2012-04-07 Eli Zaretskii <eliz@gnu.org>
5077 Support building on MS-Windows with libxml2.
5079 * makefile.w32-in (OBJ2): Add xml.$(O).
5080 (GLOBAL_SOURCES): Add xml.c.
5081 ($(BLD)/xml.$(O)): New dependency list.
5083 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5084 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5085 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5086 [!WINDOWSNT]: New macros.
5087 (init_libxml2_functions, libxml2_loaded_p): New functions.
5088 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5089 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5090 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5091 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5093 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5094 Call init_libxml2_functions before calling libxml2 functions.
5095 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5097 * emacs.c: Don't include libxml/parser.h.
5098 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5099 xmlCleanupParser directly.
5101 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5103 2012-04-07 Eli Zaretskii <eliz@gnu.org>
5105 * indent.c (Fvertical_motion): If there is a display string at
5106 point, use it.vpos to compute how many lines to backtrack after
5107 move_it_to point. (Bug#11133)
5109 2012-04-06 Eli Zaretskii <eliz@gnu.org>
5111 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5112 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5113 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5114 macros related to unification of CJK characters. For the details,
5115 see the discussion following the message here:
5116 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5118 2012-04-04 Chong Yidong <cyd@gnu.org>
5120 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5122 2012-04-01 Eli Zaretskii <eliz@gnu.org>
5124 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5125 instead of alloca. (Bug#11138)
5127 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5129 * w32menu.c (is_simple_dialog): Properly check lisp types.
5132 2012-03-31 Eli Zaretskii <eliz@gnu.org>
5134 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5135 position we get to after a call to move_it_to fails the
5136 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5137 only if we wind up in a string from display property. (Bug#11063)
5139 * window.c (Fdelete_other_windows_internal): Invalidate the row
5140 and column information about mouse highlight, so that redisplay
5141 restores it after reallocating the glyph matrices. (Bug#7464)
5143 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5144 string comes from a `display' text property, use the buffer
5145 position of that property as if we actually saw that position in
5147 (move_it_by_lines): Remove the assertion that
5148 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5149 violated when there's a before-string at the beginning of a line.
5152 2012-03-30 Eli Zaretskii <eliz@gnu.org>
5154 * xdisp.c (append_space_for_newline): If the default face was
5155 remapped, use the remapped face for the appended newline.
5156 (extend_face_to_end_of_line): Use the remapped default face for
5157 extending the face to the end of the line.
5158 (display_line): Call extend_face_to_end_of_line when the default
5159 face was remapped. (Bug#11068)
5161 2012-03-29 Eli Zaretskii <eliz@gnu.org>
5163 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5165 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5167 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5169 2012-03-27 Glenn Morris <rgm@gnu.org>
5171 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5174 2012-03-26 Kenichi Handa <handa@m17n.org>
5176 * dispextern.h (struct glyph): Fix previous change. Change the
5177 bit length of glyphless.ch to 25 (Bug#11082).
5179 2012-03-26 Chong Yidong <cyd@gnu.org>
5181 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5182 (command_loop_1): Use it; inhibit selection update for
5183 handle-select-window too (Bug#8996).
5185 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5187 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
5189 2012-03-25 Kenichi Handa <handa@m17n.org>
5191 * dispextern.h (struct glyph): Change the bit length of
5192 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5194 2012-03-24 Eli Zaretskii <eliz@gnu.org>
5196 * s/ms-w32.h (tzname): Include time.h before redirecting to
5197 _tzname. Fixes the MSVC build. (Bug#9960)
5199 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5201 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5204 * xterm.c (XTread_socket): Only modify handling_signal if
5205 !SYNC_INPUT. (Bug#11080)
5207 2012-03-23 Eli Zaretskii <eliz@gnu.org>
5209 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5210 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5211 when fetching a multibyte character consumes more bytes than
5212 CHAR_BYTES returns, due to unification of CJK characters in
5213 string_char. (Bug#11073)
5215 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5217 * process.c (wait_reading_process_output): Handle pty disconnect
5218 by refraining from sending oneself a SIGCHLD (bug#10933).
5220 2012-03-22 Chong Yidong <cyd@gnu.org>
5222 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5224 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
5225 Mark string as coming from a prefix property.
5226 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5227 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5229 2012-03-21 Chong Yidong <cyd@gnu.org>
5231 * xfaces.c (Vface_remapping_alist): Doc fix.
5233 2012-03-20 Eli Zaretskii <eliz@gnu.org>
5235 * w32proc.c (Fw32_set_console_codepage)
5236 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5239 2012-03-20 Chong Yidong <cyd@gnu.org>
5241 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5242 to reflect default non-nil value of redisplay-dont-pause.
5244 2012-03-19 Kenichi Handa <handa@m17n.org>
5246 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5247 it fit in a valid range (Bug#11003).
5249 2012-03-18 Eli Zaretskii <eliz@gnu.org>
5251 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5252 that is not from display property, accept the row as a "cursor
5253 row" if one of the string's character has a non-nil `cursor'
5254 property. Fixes cursor positioning when there are newlines in
5255 overlay strings, e.g. in icomplete.el. (Bug#11035)
5257 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5259 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5261 2012-03-12 Chong Yidong <cyd@gnu.org>
5263 * eval.c (inhibit_lisp_code): Rename from
5264 inhibit_window_configuration_change_hook; move from window.c.
5266 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5267 * window.c (run_window_configuration_change_hook)
5268 (syms_of_window): Callers changed.
5270 2012-03-11 Chong Yidong <cyd@gnu.org>
5272 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5274 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5276 2012-03-10 Chong Yidong <cyd@gnu.org>
5278 * frame.c (other_visible_frames): Don't assume the selected frame
5279 is visible (Bug#10955).
5281 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5283 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5285 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5287 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5288 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5291 2012-03-03 Glenn Morris <rgm@gnu.org>
5293 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
5295 2012-03-02 Eli Zaretskii <eliz@gnu.org>
5297 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5298 position past the first glyph_row that ends at ZV. (Bug#10902)
5299 (redisplay_window, next_element_from_string): Fix typos in
5301 (redisplay_window): Pass to move_it_vertically the margin in
5302 pixels, not in screen lines.
5304 2012-03-02 Glenn Morris <rgm@gnu.org>
5306 * buffer.c (buffer-list-update-hook): Doc fix.
5308 2012-02-29 Eli Zaretskii <eliz@gnu.org>
5310 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5311 push_it before setting up the iterator for the first overlay
5312 string, even if we have an empty string loaded.
5313 (next_overlay_string): If there's an empty string on the iterator
5314 stack, pop the stack. (Bug#10903)
5316 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5318 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5319 Suggested by Stefan Monnier in
5320 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5321 * alloc.c (widen_to_Lisp_Object): New static function.
5322 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5323 and widening them to Lisp_Objects. This would work even if
5324 USE_LSB_TAG is defined and wide integers are used, which might
5325 happen in a future version of Emacs.
5327 2012-02-25 Chong Yidong <cyd@gnu.org>
5329 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5332 * xselect.c (Fx_selection_exists_p): Doc fix.
5333 (x_clipboard_manager_save_all): Print an informative message
5334 before saving to clipboard manager.
5336 2012-02-24 Chong Yidong <cyd@gnu.org>
5338 * keyboard.c (process_special_events): Handle all X selection
5339 requests in kbd_buffer, not just the next one (Bug#8869).
5341 2012-02-23 Chong Yidong <cyd@gnu.org>
5343 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5344 call when setting menu-bar-lines and tool-bar-lines parameters.
5345 (unwind_create_frame_1): New helper function.
5347 * window.c (inhibit_window_configuration_change_hook): New var.
5348 (run_window_configuration_change_hook): Obey it.
5349 (syms_of_window): Initialize it.
5351 2012-02-22 Chong Yidong <cyd@gnu.org>
5353 * xterm.c (x_draw_image_relief): Add missing type check for
5354 Vtool_bar_button_margin (Bug#10743).
5356 2012-02-21 Chong Yidong <cyd@gnu.org>
5358 * fileio.c (Vfile_name_handler_alist): Doc fix.
5360 * buffer.c (Fget_file_buffer): Protect against invalid file
5361 handler return value.
5363 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5365 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5366 when computing $valmask.
5368 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5369 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5370 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5371 It's useless in that case, and it can cause problems on hosts
5372 that allocate halves of EMACS_INT values separately.
5373 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5374 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5375 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5376 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5377 it avoids undefined behavior on hosts where shifting right by more
5378 than the word width has undefined behavior.
5380 2012-02-19 Chong Yidong <cyd@gnu.org>
5382 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5383 (Funhandled_file_name_directory, Ffile_name_as_directory)
5384 (Fdirectory_file_name, Fexpand_file_name)
5385 (Fsubstitute_in_file_name): Protect against invalid file handler
5386 return values (Bug#10845).
5388 2012-02-18 Eli Zaretskii <eliz@gnu.org>
5390 * .gdbinit (pitx): Fix incorrect references to fields of the
5393 2012-02-17 Chong Yidong <cyd@gnu.org>
5395 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5397 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5399 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5400 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5402 2012-02-15 Chong Yidong <cyd@gnu.org>
5404 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5405 marked as special. Also, starting docstrings with * is obsolete.
5407 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5409 * gnutls.c (emacs_gnutls_write): Fix last change.
5411 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5413 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5416 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5418 * keymap.c (Fsingle_key_description): Handle char ranges.
5420 2012-02-12 Chong Yidong <cyd@gnu.org>
5422 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5423 as that creates a dangerous corner case.
5425 * window.c (Fdelete_window_internal): Invalidate the mouse
5426 highlight (Bug#9904).
5428 2012-02-12 Glenn Morris <rgm@gnu.org>
5430 * xselect.c (Fx_own_selection_internal)
5431 (Fx_get_selection_internal, Fx_disown_selection_internal)
5432 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5433 * nsselect.m (Fx_own_selection_internal)
5434 (Fx_disown_selection_internal, Fx_selection_exists_p)
5435 (Fx_selection_owner_p, Fx_get_selection_internal):
5436 Sync docs and argument specs with the xselect.c versions.
5438 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5440 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5442 2012-02-11 Eli Zaretskii <eliz@gnu.org>
5444 * w32select.c (Fx_selection_exists_p): Sync doc string and
5445 argument list with xselect.c. (Bug#10783)
5447 * w16select.c (Fx_selection_exists_p): Sync doc string and
5448 argument list with xselect.c. (Bug#10783)
5450 2012-02-10 Glenn Morris <rgm@gnu.org>
5452 * fns.c (Fsecure_hash): Doc fix.
5454 2012-02-09 Kenichi Handa <handa@m17n.org>
5456 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5458 2012-02-07 Chong Yidong <cyd@gnu.org>
5460 * buffer.c (Fbuffer_local_variables)
5461 (buffer_lisp_local_variables): Handle unbound vars correctly;
5462 don't let Qunbound leak into Lisp.
5464 2012-02-07 Glenn Morris <rgm@gnu.org>
5466 * image.c (Fimagemagick_types): Doc fix.
5468 * image.c (imagemagick-render-type): Change it from a lisp object
5469 to an integer. Move the doc here from the lisp manual.
5470 Treat all values not equal to 0 the same.
5472 2012-02-06 Chong Yidong <cyd@gnu.org>
5474 * doc.c (store_function_docstring): Avoid applying docstring of
5475 alias to base function (Bug#2603).
5477 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5479 * .gdbinit (pp1, pv1): Remove redundant defines.
5482 2012-02-04 Chong Yidong <cyd@gnu.org>
5484 * nsterm.m: Declare a global (Bug#10694).
5486 2012-02-04 Eli Zaretskii <eliz@gnu.org>
5488 * w32.c (get_emacs_configuration_options):
5489 Include --enable-checking, if specified, in the return value.
5491 2012-02-04 Martin Rudalics <rudalics@gmx.at>
5493 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5494 after rounding frame sizes. (Bug#9723)
5496 2012-02-04 Eli Zaretskii <eliz@gnu.org>
5498 * keyboard.c (adjust_point_for_property): Don't position point
5499 before BEGV. (Bug#10696)
5501 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5503 Handle overflow when computing char display width (Bug#9496).
5504 * character.c (char_width): Return EMACS_INT, not int.
5505 (char_width, c_string_width): Check for overflow when
5506 computing the width; this is possible now that individual
5507 characters can have unbounded width. Problem introduced
5508 by merge from Emacs 23 on 2012-01-19.
5510 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
5512 * dbusbind.c (Fdbus_register_method): Mention the return value
5513 :ignore in the docstring.
5515 2012-02-02 Glenn Morris <rgm@gnu.org>
5517 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5519 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5520 Unconditionally set to t. (Bug#10673)
5521 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5522 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5523 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5525 2012-02-02 Kenichi Handa <handa@m17n.org>
5527 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5528 0, do not call append_composite_glyph.
5530 2012-02-02 Kenichi Handa <handa@m17n.org>
5532 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5534 (x_produce_glyphs): If the component of a composition is a null
5535 string, set it->pixel_width to 1 to avoid zero-width glyph.
5537 2012-02-01 Eli Zaretskii <eliz@gnu.org>
5539 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5540 first 2 arguments are identical. This makes inserting large
5541 output from a subprocess an order of magnitude faster on
5542 MS-Windows, where all sbrk'ed memory is always contiguous.
5544 2012-01-31 Glenn Morris <rgm@gnu.org>
5546 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5547 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5548 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5550 2012-01-29 Glenn Morris <rgm@gnu.org>
5552 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5554 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5556 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5558 2012-01-28 Chong Yidong <cyd@gnu.org>
5560 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5562 2012-01-26 Chong Yidong <cyd@gnu.org>
5564 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5566 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5567 repeat counts (Bug#10507).
5569 2012-01-26 Glenn Morris <rgm@gnu.org>
5571 * lread.c (syms_of_lread): Doc fix.
5573 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5575 * coding.c (encode_designation_at_bol): Change return value to
5578 2012-01-25 Chong Yidong <cyd@gnu.org>
5580 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5582 2012-01-21 Chong Yidong <cyd@gnu.org>
5584 * floatfns.c (Fcopysign): Make the second argument non-optional,
5585 since nil is not allowed anyway.
5587 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5589 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5590 (send_process): Likewise.
5592 2012-01-19 Martin Rudalics <rudalics@gmx.at>
5594 * window.c (save_window_save, Fcurrent_window_configuration)
5595 (Vwindow_persistent_parameters): Do not use Qstate.
5596 Rewrite doc-strings.
5598 2012-01-19 Kenichi Handa <handa@m17n.org>
5600 * character.c (char_width): New function.
5601 (Fchar_width, c_string_width, lisp_string_width):
5602 Use char_width (Bug#9496).
5604 2012-01-16 Martin Rudalics <rudalics@gmx.at>
5606 * window.c (Vwindow_persistent_parameters): New variable.
5607 (Fset_window_configuration, save_window_save): Handle persistent
5610 2012-01-14 Eli Zaretskii <eliz@gnu.org>
5612 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5613 thrashing the stack of the thread. (Bug#9087)
5615 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5617 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5619 2012-01-11 Eli Zaretskii <eliz@gnu.org>
5621 * xdisp.c (rows_from_pos_range): Handle the case where the
5622 highlight ends on a newline. (Bug#10464)
5623 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5624 he end column for display of highlight that ends on a newline
5627 2012-01-11 Glenn Morris <rgm@gnu.org>
5629 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5630 from load-path also when installation-directory is nil. (Bug#10208)
5632 2012-01-10 Glenn Morris <rgm@gnu.org>
5634 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5636 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5637 Update template values to be closer to their typical values these days.
5639 2012-01-09 Eli Zaretskii <eliz@gnu.org>
5641 * xdisp.c (rows_from_pos_range): Accept additional argument
5642 DISP_STRING, and accept any glyph in a row whose object is that
5643 string as eligible for mouse highlight. Fixes mouse highlight of
5644 display strings from overlays. (Bug#10464)
5646 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
5648 emacs: fix an auto-save permissions race condition (Bug#10400)
5649 * fileio.c (auto_saving_dir_umask): New static var.
5650 (Fmake_directory_internal): Use it.
5651 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5652 creating the directory. The old code temporarily assigns
5653 too-generous permissions to the directory.
5654 (do_auto_save_eh): Clear it.
5655 (Fdo_auto_save): Catch all errors, not just file errors, so
5656 that the var is always cleared.
5658 2012-01-07 Eli Zaretskii <eliz@gnu.org>
5660 * search.c (scan_buffer): Pass character positions to
5661 know_region_cache, not byte positions. (Bug#6540)
5663 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
5665 * w32.c (sys_rename): Report EXDEV when rename of a directory
5666 fails because the target is on another logical disk. (Bug#10284)
5668 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5670 * xterm.c (x_embed_request_focus): New function.
5672 * xterm.h: Add prototype.
5674 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5676 2012-01-05 Glenn Morris <rgm@gnu.org>
5678 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5680 2012-01-01 Eli Zaretskii <eliz@gnu.org>
5682 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5683 Load gnutls_transport_set_lowat only if GnuTLS version is below
5685 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5686 GnuTLS versions below 2.11.1.
5688 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5690 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5691 to the doc string advising against its use for altering the way
5692 windows are scrolled.
5694 2011-12-28 Kenichi Handa <handa@m17n.org>
5696 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5697 coding-system ASCII compatible only when it does not produce BOM
5698 on encoding (Bug#10383).
5700 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5702 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5704 (create_and_show_popup_menu): Always use menu_position_func for
5707 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5709 * callint.c (Fcall_interactively): Don't truncate prompt string.
5711 2011-12-23 Eli Zaretskii <eliz@gnu.org>
5713 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5714 property that ends at ZV, so that the bidi iteration could be
5715 resumed from there (after widening). (Bug#10360)
5717 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5719 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5721 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5723 * nsterm.m (x_free_frame_resources):
5724 Release f->output_data.ns->miniimage.
5725 (ns_index_color): Fix indentation. Do not retain
5726 color_table->colors[i].
5728 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5731 * nsfns.m (x_set_background_color): Assign return value from
5732 ns_index_color to face-background instead of NSColor*.
5733 (ns_implicitly_set_icon_type): Fix indentation.
5734 Change assignment in for loop to comparison.
5736 * emacs.c (ns_pool): New variable.
5737 (main): Assign ns_pool.
5738 (Fkill_emacs): Call ns_release_autorelease_pool.
5740 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5741 autorelease fdesc, release fdAttrs and tdict.
5742 (ns_get_covering_families): Release charset.
5743 (ns_findfonts): Release NSFontDescriptor created with new.
5744 (ns_uni_to_glyphs): Fix indentation.
5745 (setString): Release attrStr before assigning new value.
5747 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5749 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5751 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5752 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5754 2011-12-18 David Reitter <reitter@cmu.edu>
5756 * nsterm.m (ns_term_init): Subscribe for notifications
5757 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5758 to method trackingNotification in EmacsMenu.
5760 * nsmenu.m (trackingMenu): New variable.
5761 (trackingNotification): New method (from Aquamacs).
5762 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
5763 from Aquamacs (Bug#7030).
5765 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5767 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5768 (symbol_to_nsstring): Fix indentation.
5769 (ns_symbol_to_pb): New function.
5770 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5771 (Fns_rotate_cut_buffers_internal): Remove.
5772 (Fns_store_selection_internal): Rename from
5773 Fns_store_cut_buffer_internal.
5774 (ns_get_foreign_selection, Fx_own_selection_internal)
5775 (Fx_disown_selection_internal, Fx_selection_exists_p)
5776 (Fns_get_selection_internal, Fns_store_selection_internal):
5777 Use ns_symbol_to_pb and check if return value is nil.
5778 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5779 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
5780 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5781 renamed to Sns_store_selection_internal.
5782 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5783 and remove this function.
5784 (ns_handle_selection_clear): Remove, never used.
5785 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5788 2011-12-17 Ken Brown <kbrown@cornell.edu>
5790 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5791 GID is unknown (Bug#10257).
5793 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5795 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5796 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5797 which caused a build failure on GNU/Linux IA-64. This problem was
5798 introduced by my 2011-10-07 patch.
5800 2011-12-15 Juri Linkov <juri@jurta.org>
5802 * image.c (imagemagick_error): New function. (Bug#10112)
5803 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5804 Use `imagemagick_error' where ImageMagick functions return
5806 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5809 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5811 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5812 fill background (Bug#8992).
5814 2011-12-13 Martin Rudalics <rudalics@gmx.at>
5816 * window.c (Vwindow_combination_resize)
5817 (Vwindow_combination_limit): Use t instead of non-nil in
5819 (Vrecenter_redisplay): Add first sentence of doc-string on
5821 (Frecenter): Fix doc-string typo.
5823 2011-12-11 Kenichi Handa <handa@m17n.org>
5825 * coding.c (Funencodable_char_position): Pay attention to the
5826 buffer text relocation (Bug#9389).
5828 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5830 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5831 gtk_init (Bug#10100).
5833 2011-12-10 Eli Zaretskii <eliz@gnu.org>
5835 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5836 IT->string is nil. (Bug#10263)
5838 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5840 * nsterm.h (x_free_frame_resources): Declare.
5842 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5843 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5845 * nsterm.h (ns_get_defaults_value): Declare.
5847 * nsterm.m (ns_default): Call ns_get_defaults_value.
5849 2011-12-09 Eli Zaretskii <eliz@gnu.org>
5851 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5854 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5856 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5857 that where the value of an _OBJC_* symbol points to is in the .bss
5858 section (Bug#10240).
5860 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5862 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
5863 after the loop to call ccl_driver at least once (Bug#8619).
5865 2011-12-08 Kenichi Handa <handa@m17n.org>
5867 * ftfont.c (get_adstyle_property): Fix previous change
5870 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
5872 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5873 dirs from the default value of EMACSLOADPATH (bug#10208).
5875 2011-12-07 Glenn Morris <rgm@gnu.org>
5877 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5878 installation and source directories as well. (Bug#10208)
5880 2011-12-06 Chong Yidong <cyd@gnu.org>
5882 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5884 2011-12-06 Glenn Morris <rgm@gnu.org>
5886 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5887 as an error, not just -1. (Bug#10217)
5889 2011-12-05 Chong Yidong <cyd@gnu.org>
5891 * keyboard.c (process_special_events): New function.
5892 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5894 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5896 * coding.c (encode_designation_at_bol): Don't use uninitialized
5897 local variable (Bug#9318).
5899 2011-12-05 Kenichi Handa <handa@m17n.org>
5901 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5902 return Qnil (Bug#8046, Bug#10193).
5904 2011-12-05 Kenichi Handa <handa@m17n.org>
5906 * coding.c (encode_designation_at_bol): New args charbuf_end and
5907 dst. Return the number of produced bytes. Callers changed.
5908 (coding_set_source): Return how many bytes coding->source was
5910 (coding_set_destination): Return how many bytes
5911 coding->destination was relocated.
5912 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
5913 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5915 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5917 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5918 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5921 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5923 The following changes are to fix Bug#9318.
5925 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5926 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5927 (encode_coding_iso_2022, encode_coding_sjis)
5928 (encode_coding_big5, encode_coding_charset): Use the above macros.
5930 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
5932 * lisp.h (process_quit_flag): Fix external declaration.
5934 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5936 Don't macro-inline non-performance-critical code.
5937 * eval.c (process_quit_flag): New function.
5938 * lisp.h (QUIT): Use it.
5940 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5942 * nsfns.m (get_geometry_from_preferences): New function.
5943 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5945 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5947 * emacs.c (Qkill_emacs): Define.
5948 (syms_of_emacs): Initialize it.
5949 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5950 Qquit_flag to `kill-emacs' instead.
5951 (quit_throw_to_read_char): Add parameter `from_signal'.
5952 All callers changed. Call Fkill_emacs if requested and safe.
5953 * lisp.h (QUIT): Call Fkill_emacs if requested.
5955 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5957 * widget.c (update_wm_hints): Return if wmshell is null.
5958 (widget_update_wm_size_hints): New function.
5960 * widget.h (widget_update_wm_size_hints): Declare.
5962 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5963 widget_update_wm_size_hints (Bug#10104).
5965 2011-12-03 Eli Zaretskii <eliz@gnu.org>
5967 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5968 before a newline, prepare the bidi iterator for consuming the
5969 newline, and keep the current paragraph direction. (Bug#10183)
5970 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
5972 2011-12-02 Juri Linkov <juri@jurta.org>
5974 * search.c (Fword_search_regexp): New Lisp function created from
5975 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5976 (Fword_search_backward, Fword_search_forward)
5977 (Fword_search_backward_lax, Fword_search_forward_lax):
5978 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5979 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5981 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5983 * fileio.c (Finsert_file_contents): Move after-change-function call
5984 to before the "handled:" label, since all "goto handled" appear in
5985 cases where the *-change-functions have already been properly called
5988 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5990 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5991 waiting for input. (Bug#10169)
5993 2011-11-30 Eli Zaretskii <eliz@gnu.org>
5995 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5996 verifies glyph row's hash code--we have just reallocated the
5997 glyphs, so their contents can be complete garbage. (Bug#10164)
5999 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
6001 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
6003 2011-11-30 Eli Zaretskii <eliz@gnu.org>
6005 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
6006 attributes are tested _before_ calling verify_row_hash, to protect
6007 against GCC re-ordering of the tests. (Bug#10164)
6009 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
6011 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
6013 * xterm.c (handle_one_xevent): Only set async_visible and friends
6014 if net_wm_state_hidden_seen is non-zero (Bug#10002)
6015 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
6016 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
6018 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
6020 Remove GCPRO-related macros that exist only to avoid shadowing locals.
6021 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
6022 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
6023 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6024 All uses changed to use GCPRO1 etc.
6025 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
6026 Revert to old implementation (i.e., before 2011-03-11).
6028 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6030 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6031 of scroll runs so as to avoid assigning disabled bogus rows and
6032 unnecessary graphics copy operations.
6034 2011-11-27 Eli Zaretskii <eliz@gnu.org>
6036 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6037 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6038 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6039 (malloc, free, realloc, calloc): Redirect to e_* only when
6042 * lisp.h (GCTYPEBITS): Move before first use.
6043 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6044 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6045 this macro definition.
6047 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6050 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6052 * gtkutil.c (xg_create_frame_widgets):
6053 Call gtk_window_set_has_resize_grip (FALSE) if that function is
6054 present with Gtk+ 2.0.
6056 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6058 * fileio.c (Finsert_file_contents): Undo previous change; see
6059 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6061 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6063 Rename locals to avoid shadowing.
6064 * fileio.c (Finsert_file_contents):
6065 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6066 * process.c (wait_reading_process_output):
6067 Rename inner 'proc' to 'p' to avoid shadowing.
6068 Indent for consistency with usual Emacs style.
6070 2011-11-25 Eli Zaretskii <eliz@gnu.org>
6072 * xdisp.c (redisplay_window): If cursor row is not fully visible
6073 after recentering, and scroll-conservatively is set to a large
6074 number, scroll window by a few more lines to make the cursor fully
6075 visible and out of scroll-margin. (Bug#10105)
6076 (start_display): Don't move to the next line if the display should
6077 start at a newline that is part of a display vector or an overlay
6080 2011-11-24 Juri Linkov <juri@jurta.org>
6082 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6083 after the `MagickPingImage' call. (Bug#10112)
6085 2011-11-23 Chong Yidong <cyd@gnu.org>
6087 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6089 2011-11-23 Martin Rudalics <rudalics@gmx.at>
6091 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6092 making another buffer current. (Bug#10114)
6094 2011-11-23 Glenn Morris <rgm@gnu.org>
6096 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6098 2011-11-23 Chong Yidong <cyd@gnu.org>
6100 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6101 using it (Bug#5984).
6103 2011-11-22 Eli Zaretskii <eliz@gnu.org>
6105 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6106 and header-lines, as they don't have one computed for them.
6109 * .gdbinit (prow): Make displayed values more self-explaining.
6110 Add row's hash code.
6112 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6114 * process.c (wait_reading_process_output): Fix asynchrounous
6115 GnuTLS socket handling on some versions of the GnuTLS library.
6116 (wait_reading_process_output): Add comment and URL.
6118 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6120 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6122 2011-11-21 Chong Yidong <cyd@gnu.org>
6124 * window.c (Fnext_window, Fprevious_window): Doc fix.
6126 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6128 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6130 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
6132 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6134 2011-11-20 Martin Rudalics <rudalics@gmx.at>
6136 * window.c (Fset_window_combination_limit): Rename argument
6138 (Vwindow_combination_limit): Remove "status" from doc-string.
6140 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6142 * m/ibms390.h: Remove.
6143 * m/ibms390x.h: Don't include "ibms390.h".
6145 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6147 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6148 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6150 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
6152 * casetab.c (Fset_case_table):
6153 * charset.c (Fcharset_after): Fix typos.
6155 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6157 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6158 Otherwise, valgrind does not work on some platforms.
6159 Problem reported by Andreas Schwab in
6160 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6161 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6162 is set, removing the need for VIRT_ADDRESS_VARIES.
6163 (PURE_P): Use a more-efficient implementation that needs just one
6164 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6165 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6166 to 4 (xorl, subq, cmpq, setbe).
6167 * alloc.c (pure): Always extern now, since that's the
6168 VIRT_ADDR_VARIES behavior.
6169 (PURE_POINTER_P): Use a single comparison, not two, for
6170 consistency with the new puresize.h.
6171 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6172 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6173 Remove VIRT_ADDR_VARIES no longer needed.
6175 2011-11-19 Eli Zaretskii <eliz@gnu.org>
6177 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6178 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6179 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6180 behave as if the cursor position were at the window margin.
6182 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6183 and the cursor position is out of bounds, behave as if the cursor
6184 position were at the window margin. (Bug#10075)
6186 2011-11-18 Chong Yidong <cyd@gnu.org>
6188 * window.c (Fwindow_combination_limit): Make first argument
6189 non-optional, since it is meaningless for live windows like the
6192 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6194 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6196 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6198 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6199 (graft_intervals_into_buffer): Simplify.
6201 2011-11-18 Eli Zaretskii <eliz@gnu.org>
6203 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6204 hash values of the two rows.
6205 (copy_row_except_pointers): Preserve the used[] arrays and the
6206 hash values of the two rows. (Bug#10035)
6207 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
6209 * xdisp.c (row_hash): New function, body extracted from
6210 compute_line_metrics.
6211 (compute_line_metrics): Call row_hash, instead of computing the
6214 * dispnew.c (verify_row_hash): Call row_hash for computing the
6215 hash code of a row, instead of duplicating code from xdisp.c.
6217 * dispextern.h (row_hash): Add prototype.
6219 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6221 * frame.c (delete_frame): Don't delete the terminal when the last
6222 X frame is closed if emacs is built with GTK toolkit.
6224 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
6226 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6228 2011-11-17 Martin Rudalics <rudalics@gmx.at>
6230 * window.c (Vwindow_splits): Rename to
6231 Vwindow_combination_resize. Suggested by Juri Linkov.
6232 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6235 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
6237 * nsfns.m (Fns_font_name):
6238 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
6240 2011-11-16 Martin Rudalics <rudalics@gmx.at>
6242 * window.h (window): Rename slot "nest" to "combination_limit".
6243 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6244 (Fset_window_nest): Rename to Fset_window_combination_limit.
6245 (Vwindow_nest): Rename to Vwindow_combination_limit.
6246 (recombine_windows, make_parent_window, make_window)
6247 (Fsplit_window_internal, saved_window)
6248 (Fset_window_configuration, save_window_save): Rename all
6249 occurrences of window_nest to window_combination_limit.
6251 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
6253 * image.c (imagemagick_load_image): Fix typo.
6255 2011-11-14 Eli Zaretskii <eliz@gnu.org>
6257 * xdisp.c (display_line): Move the call to
6258 highlight_trailing_whitespace before the call to
6259 compute_line_metrics, since the latter needs to see the final
6260 faces of all the glyphs to compute ROW's hash value.
6261 Fixes assertion violations in row_equal_p. (Bug#10035)
6263 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
6265 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6266 just return (bug#10044).
6268 2011-11-12 Eli Zaretskii <eliz@gnu.org>
6270 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6271 with user-defined heap size. Bump the default size of the temacs
6272 heap to 27MB, to avoid memory warning when running temacs.
6273 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6275 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6276 current_matrix and desired_matrix. (Bug#9990)
6277 (verify_row_hash) [XASSERTS]: New function.
6278 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6279 that the hash value of glyph rows is correct.
6281 2011-11-12 Martin Rudalics <rudalics@gmx.at>
6283 * window.h (window): Remove splits slot.
6284 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6285 (Fdelete_other_windows_internal, make_parent_window)
6286 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6287 (Fset_window_configuration, save_window_save): Don't deal with
6288 split status of windows.
6289 (saved_window): Remove splits slot.
6290 (Vwindow_splits): Rewrite doc-string.
6292 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6294 * xfns.c (unwind_create_frame):
6295 * nsfns.m (unwind_create_frame):
6296 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6297 Vframe_list (Bug#9999).
6299 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6301 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
6303 2011-11-11 Kenichi Handa <handa@m17n.org>
6305 * callproc.c (Fcall_process): Set the member dst_multibyte of
6308 2011-11-11 Johan Bockgård <bojohan@gnu.org>
6310 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6311 avoid a crash (bug#9496).
6313 2011-11-09 Chong Yidong <cyd@gnu.org>
6315 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6316 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6318 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6320 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6322 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6324 Avoid some portability problems by eschewing 'extern inline' functions.
6325 The trivial performance wins aren't worth the portability hassles; see
6326 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6328 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6329 (window_box_width, window_box_left, window_box_left_offset)
6330 (window_box_right, window_box_right_offset): Undo previous change,
6331 by removing the "extern"s.
6332 * intervals.c (adjust_intervals_for_insertion)
6333 (adjust_intervals_for_deletion): Undo previous change,
6334 making these static again.
6335 (offset_intervals, temp_set_point_both, temp_set_point)
6336 (copy_intervals_to_string): No longer inline.
6337 * xdisp.c (window_text_bottom_y, window_box_width)
6338 (window_box_height, window_box_left_offset)
6339 (window_box_right_offset, window_box_left, window_box_right)
6340 (window_box): No longer inline.
6342 2011-11-08 Chong Yidong <cyd@gnu.org>
6344 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6345 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6346 Signal an error if not a live window.
6347 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6348 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6350 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
6352 * lisp.h (syms_of_abbrev): Remove declaration.
6353 Reported by CHENG Gao <chenggao@royau.me>.
6355 2011-11-07 Eli Zaretskii <eliz@gnu.org>
6357 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6358 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6359 of temacs in GUI mode.
6361 2011-11-07 Martin Rudalics <rudalics@gmx.at>
6363 * window.h: Declare delete_all_child_windows instead of
6364 delete_all_subwindows.
6365 * window.c (Fwindow_nest, Fset_window_nest)
6366 (Fset_window_new_total, Fset_window_new_normal)
6367 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6368 (delete_all_subwindows): Rename to delete_all_child_windows.
6369 (Fdelete_other_windows_internal, Fset_window_configuration):
6370 Call delete_all_child_windows instead of delete_all_subwindows.
6371 * frame.c (delete_frame): Call delete_all_child_windows instead
6372 of delete_all_subwindows.
6374 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6376 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6377 This is also needed for porting to any host where GC_MARK_STACK is
6378 not GC_MAKE_GCPROS_NOOPS.
6379 (which_symbols): Use it.
6381 2011-11-07 Kenichi Handa <handa@m17n.org>
6383 * coding.c (coding_set_destination): Check coding->src_pos only
6384 when coding->src_object is a buffer (bug#9910).
6386 * process.c (send_process): Set the member src_multibyte of coding
6387 to 0 (bug#9911) when sending a unibyte text.
6389 * callproc.c (Fcall_process): Set the member src_multibyte of
6390 process_coding to 0 (bug#9912).
6392 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6394 * xmenu.c (cleanup_widget_value_tree): New function.
6395 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6396 calling free_menubar_widget_value_tree directly (Bug#9830).
6398 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6400 Fix some portability problems with 'inline'.
6401 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6402 (window_box_width, window_box_left, window_box_left_offset)
6403 (window_box_right, window_box_right_offset): Declare extern.
6404 Otherwise, these inline functions do not conform to C99 and
6405 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6406 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6407 * intervals.c (adjust_intervals_for_insertion)
6408 (adjust_intervals_for_deletion): Now extern, because otherwise the
6409 extern inline functions 'offset_intervals' couldn't refer to it.
6410 (static_offset_intervals): Remove.
6411 (offset_intervals): Rewrite using the old contents of
6412 static_offset_intervals. The old version didn't conform to C99
6413 because an extern inline function contained a reference to an
6414 identifier with static linkage.
6416 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6418 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6421 2011-11-06 Eli Zaretskii <eliz@gnu.org>
6423 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6424 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6425 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6426 return Qleft_to_right.
6428 2011-11-06 Chong Yidong <cyd@gnu.org>
6430 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6431 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6432 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6433 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6434 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6435 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6436 (Fwindow_vscroll): Doc fix.
6437 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6438 argument, since it makes no sense to pass a live window and for
6439 consistency with window-child.
6441 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6443 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6446 2011-11-05 Jason Rumney <jasonr@gnu.org>
6448 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6449 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6451 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6452 bitwise arithmetic preventing use of unicode-sip and non-truetype
6455 2011-11-05 Eli Zaretskii <eliz@gnu.org>
6457 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6460 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6461 initialization code to keep similarity to xfns.c after changes
6464 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6466 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6467 (unwind_create_frame): New function (Bug#9943).
6468 (Fx_create_frame): Restructure code to be more similar to the one in
6469 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6470 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6471 Move terminal->reference_count++ just before making the frame official
6474 * nsterm.m (x_free_frame_resources): New function.
6475 (x_destroy_window): Move code to x_free_frame_resources.
6477 * xfns.c (unwind_create_frame): Fix comment.
6478 (Fx_create_frame, x_create_tip_frame):
6479 Move terminal->reference_count++ just before making the frame
6480 official. Move initialization of image_cache_refcount and
6481 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6483 2011-11-05 Eli Zaretskii <eliz@gnu.org>
6485 Support MSVC build with newer versions of Visual Studio.
6486 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6487 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6490 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6491 which are not supported by MSVC.
6492 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6493 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6495 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6497 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6499 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6501 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
6503 Support MSVC build with newer versions of Visual Studio.
6504 * w32.c: Don't include w32api.h for MSVC.
6505 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6507 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6508 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6509 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6510 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6512 (alloca) [_MSC_VER]: Define to _alloca.
6514 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6516 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6518 2011-11-04 Eli Zaretskii <eliz@gnu.org>
6520 * xdisp.c (note_mouse_highlight): If either of
6521 previous/next-single-property-change returns nil, treat that as
6522 the beginning or the end of the buffer. (Bug#9955)
6524 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6526 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
6527 label is not null (Bug#9951).
6528 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6531 2011-11-04 Eli Zaretskii <eliz@gnu.org>
6533 * window.c (Fwindow_body_size): Mention in the doc string that the
6534 return value is in frame's canonical units. (Bug#9949)
6536 2011-11-03 Eli Zaretskii <eliz@gnu.org>
6538 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6540 * w32fns.c (unwind_create_frame): If needed, free the glyph
6541 matrices of the partially constructed frame. (Bug#9943)
6542 * xfns.c (unwind_create_frame): Likewise.
6544 2011-11-01 Eli Zaretskii <eliz@gnu.org>
6546 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6547 Don't stop backward scan on the continuation glyph, even though
6548 its CHARPOS is positive.
6549 (mouse_face_from_buffer_pos, note_mouse_highlight):
6550 Rename cover_string to disp_string.
6552 2011-11-01 Martin Rudalics <rudalics@gmx.at>
6554 * window.c (temp_output_buffer_show): Don't use
6555 Vtemp_buffer_show_specifiers.
6556 (Vtemp_buffer_show_specifiers): Remove unused variable.
6558 2011-10-30 Eli Zaretskii <eliz@gnu.org>
6560 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6561 past the beginning of the current glyph matrix.
6563 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6565 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6566 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6567 HAVE_GTK3 (Bug#9869).
6569 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6570 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6572 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6574 * xterm.c: Declare x_handle_net_wm_state to return int.
6575 (handle_one_xevent): Check if we are iconified but don't have
6576 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6577 (get_current_wm_state): Return non-zero if not hidden,
6578 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6579 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6580 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6581 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6583 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6585 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6586 so that this new function doesn't get optimized away by a
6587 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6589 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6591 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6593 2011-10-29 Eli Zaretskii <eliz@gnu.org>
6595 Fix the `xbytecode' command.
6596 * .gdbinit (xprintbytestr): New command.
6597 (xwhichsymbols): Rename from `which'; all callers changed.
6598 (xbytecode): Print the byte-code string as well.
6600 2011-10-29 Kim Storm <storm@cua.dk>
6602 * alloc.c (which_symbols): New function.
6604 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6606 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6609 2011-10-29 Glenn Morris <rgm@gnu.org>
6611 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6612 Not clear what it was for, and it causes various bugs. (Bug#9839)
6614 2011-10-28 Eli Zaretskii <eliz@gnu.org>
6616 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6617 possible random value that matches one of those tested as
6618 condition to clear the mouse face.
6620 2011-10-28 Chong Yidong <cyd@gnu.org>
6622 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6624 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6626 * window.c (make_window): Initialize phys_cursor_on_p.
6628 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6630 * lisp.h (struct Lisp_Symbol): Update comments.
6632 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
6634 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6636 2011-10-28 Eli Zaretskii <eliz@gnu.org>
6638 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6639 <oslsachem@gmail.com> for helping to debug this.
6641 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6642 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6643 (g_b_init_get_glyph_outline_w): New static variables.
6644 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6645 (GetGlyphOutlineW_Proc): New typedefs.
6646 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
6647 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6649 (w32font_open_internal, compute_metrics):
6650 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
6651 instead of calling the "wide" APIs directly.
6653 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6655 * w32.h (syms_of_w32font): Add prototype.
6657 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
6659 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6660 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6661 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6662 (Fmove_to_window_line): Doc fix.
6664 2011-10-27 Chong Yidong <cyd@gnu.org>
6666 * process.c (make_process): Set gnutls_state to NULL.
6668 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6669 non-NULL, regardless of GNUTLS_INITSTAGE.
6670 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6671 an error. Set process slots as soon as we allocate them.
6673 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6675 2011-10-27 Chong Yidong <cyd@gnu.org>
6677 * gnutls.c (emacs_gnutls_deinit): New function.
6678 Deallocate credentials structures as well as calling gnutls_deinit.
6679 (Fgnutls_deinit, Fgnutls_boot): Use it.
6681 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6682 (deactivate_process): Call emacs_gnutls_deinit.
6684 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
6686 * image.c (x_create_x_image_and_pixmap):
6687 * w32.c (sys_rename, w32_delayed_load):
6688 * w32font.c (fill_in_logfont):
6689 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6691 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
6693 * w32fns.c (w32_default_color_map): New function,
6694 extracted from Fw32_default_color_map.
6695 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
6697 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6699 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6701 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6703 * keyboard.c (test_undefined): New function (bug#9751).
6704 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6706 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6708 * sysdep.c (init_sys_modes): Fix the check for the controlling
6709 terminal (Bug#6649).
6711 2011-10-20 Eli Zaretskii <eliz@gnu.org>
6713 * dispextern.h (struct bidi_it): New member next_en_type.
6715 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6716 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6717 current character, check also for next_en_type being WEAK_EN.
6718 (bidi_resolve_weak): Don't enter the expensive loop if the current
6719 position is before next_en_pos. Record the bidi type of the first
6720 non-ET, non-BN character we find, in addition to its position.
6721 (bidi_level_of_next_char): Invalidate next_en_type when
6722 next_en_pos is over-stepped.
6724 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6726 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6727 * editfns.c: Rewrite current-time-zone so that it invokes
6728 the equivalent of (format-time-string "%Z") to get the time zone name.
6729 This fixes a bug when the time zone name contains characters that
6730 need converting from the system time locale to Emacs internal format.
6731 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6732 that patch fixed format-time-string to do the conversion, but
6733 I forgot to fix current-time-zone.
6734 (format_time_string): New function, containing most of
6735 what Fformat_time_string used to contain.
6736 (Fformat_time_string): Rewrite in terms of format_time_string.
6737 This doesn't change this function's behavior.
6738 (current-time-zone): Rewrite to use format_time_string.
6739 This fixes the bug reported by Michael Schierl in
6740 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6741 Jason Rumney's 2007-06-07 change worked around this bug, but
6743 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6745 2011-10-19 Eli Zaretskii <eliz@gnu.org>
6747 * xdisp.c (start_display): If the character at POS is displayed
6748 via a display vector, reset IT->current.dpvec_index to zero.
6749 (try_window_reusing_current_matrix): If a line ends in a display
6750 vector or the next line starts in a display vector, continue
6751 redrawing the window even though the character position of
6752 start_row was reached.
6755 2011-10-18 Chong Yidong <cyd@gnu.org>
6757 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6758 with nobreak-char-display too.
6760 2011-10-18 Eli Zaretskii <eliz@gnu.org>
6762 Fix part 3 of bug#9771.
6763 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6764 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6765 non-neutral characters if the current character is a paragraph
6766 separator (a.k.a. Newline). This avoids running the same
6767 expensive loop twice, once when we consume the preceding newline
6768 and the other time when the line actually needs to be displayed.
6769 Avoid the loop when we see neutrals on the base embedding level
6770 following a character whose directionality is the same as the
6771 paragraph's. This avoids running the expensive loop when a line
6772 ends in a long sequence of neutrals, like control characters.
6773 Add assertion against STRONG_AL type. Slightly rearrange code
6774 that determines the type of a neutral given the first non-neutral
6776 (bidi_level_of_next_char): Set next_en_pos to zero when
6777 invalidating its info.
6779 2011-10-17 Eli Zaretskii <eliz@gnu.org>
6781 * xdisp.c (push_display_prop): Determine whether to record string
6782 or buffer position by IT->string, not by IT->method. Allow
6783 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
6784 (move_it_vertically_backward): Don't look for character position
6785 immediately after the newline when in a continuation line.
6788 2011-10-15 Martin Rudalics <rudalics@gmx.at>
6790 * window.c (coordinates_in_window): Rewrite and delabelize
6791 vertical border check. (Bug#5357) (Bug#9618)
6793 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6795 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6796 errors in XSetWindowBorder (bug#9310).
6798 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6800 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6801 avoid crash when xmalloc overrun checking is enabled.
6803 2011-10-13 Eli Zaretskii <eliz@gnu.org>
6805 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6806 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6807 cursor motion with <left> and <right> arrow keys.
6809 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6810 some callers set that themselves.
6812 2011-10-12 Eli Zaretskii <eliz@gnu.org>
6814 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6815 display string and the previous row comes from the same string and
6816 is empty. (Bug#9739) (Bug#9738)
6818 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6820 * doc.c (get_doc_string): Encode file name (bug#9735).
6822 2011-10-12 Eli Zaretskii <eliz@gnu.org>
6824 * bidi.c (bidi_level_of_next_char):
6825 * xdisp.c (get_visually_first_element): Remove old incorrect
6826 comments regarding the Unicode Line Separator character.
6828 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6830 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6832 * alloc.c (Fgc_status): Do not access beyond zombies array
6833 boundary if nzombies > MAX_ZOMBIES.
6834 * alloc.c (dump_zombies): Add missing format specifier.
6836 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6838 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6839 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6841 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6842 Some packages use them to denote characters with modifiers.
6844 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6846 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6847 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6848 matching a pp-number. Rename parameter var to var1.
6850 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6852 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6854 2011-10-08 Glenn Morris <rgm@gnu.org>
6856 * callint.c (Fcall_interactively): Give a more explicit error for the
6857 'c' case with a non-character input. (Bug#8479)
6859 2011-10-08 Eli Zaretskii <eliz@gnu.org>
6861 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6863 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6864 lines that are hscrolled on the left.
6866 * dispnew.c (buffer_posn_from_coords): Account for a possible
6867 presence of header-line. (Bug#4426)
6869 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6871 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6872 Don't advertise functionality which we discourage or doesn't work.
6874 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6876 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6877 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6878 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6879 this makes Emacs dump core during garbage collection on rare
6880 occasions. sizeof is obviously inferior to offsetof here, so
6881 stick with offsetof.
6882 (GC_POINTER_ALIGNMENT): New macro.
6883 (mark_memory): Omit 3rd (offset) arg; caller changed.
6884 Don't assume EMACS_INT alignment is the same as pointer alignment.
6886 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6888 * keyboard.c (read_key_sequence_remapped): New var.
6889 (read_key_sequence): Compute remapping in the right buffer.
6890 (command_loop_1): Use read_key_sequence's remapping directly.
6892 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6894 * dired.c (file_name_completion): Don't expand file name.
6895 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6896 before checking file name handler.
6898 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6899 they've been requested explicitly (bug#9591).
6901 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
6903 * keymap.c (Fsingle_key_description): Use make_specified_string
6904 instead of build_string to build string from push_key_description.
6907 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6909 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6910 This fixes a Y2038 bug on 64-bit hosts.
6911 * buffer.c (reset_buffer):
6912 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6913 (Fclear_buffer_auto_save_failure):
6914 Use 0, not -1, to represent an unset failure time, since time_t
6915 might not be signed.
6917 Remove dependency on glibc malloc internals.
6918 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6919 Move back here from lisp.h, but with their new implementations.
6920 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6921 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6922 * charset.c (charset_table_init): New static var.
6923 (syms_of_charset): Use it instead of xmalloc. This removes a
6924 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6925 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6926 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6927 Move back to alloc.c.
6928 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6929 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6931 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6933 * nsterm.m (windowDidResize): Call x_set_window_size only when
6934 ns_in_resize is true. Otherwise set pixelwidth/height and
6935 call change_frame_size (Bug#9628).
6937 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6939 Port --enable-checking=all to Fedora 14 x86-64.
6940 * charset.c (syms_of_charset): Also account for glibc malloc's
6941 internal overhead when calculating the initial malloc maximum.
6943 Port --enable-checking=all to Fedora 14 x86.
6944 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6946 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6947 (overrun_check_realloc, overrun_check_free):
6948 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6949 That way, xmalloc returns a properly-aligned pointer even if
6950 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6951 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6952 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6953 into account when calculating the initial malloc maximum.
6954 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6955 Move here from alloc.c, so that charset.c can use it too.
6956 Properly align; the old code wasn't right for common 32-bit hosts
6957 when configured with --enable-checking=all.
6958 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6959 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6961 2011-09-29 Eli Zaretskii <eliz@gnu.org>
6963 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
6966 2011-09-28 Eli Zaretskii <eliz@gnu.org>
6968 * xdisp.c (compute_display_string_end): If there's no display
6969 string at CHARPOS, return -1.
6971 * bidi.c (bidi_fetch_char): When compute_display_string_end
6972 returns a negative value, treat the character as a normal
6973 character not covered by a display string. (Bug#9624)
6975 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
6977 * lread.c (Fread_from_string): Fix typo in docstring.
6979 2011-09-27 Eli Zaretskii <eliz@gnu.org>
6981 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6982 newline, reseat the iterator instead of bidi-iterating there one
6983 character at a time. (Bug#9610)
6984 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6985 TO_CHARPOS if the bidi iterator is at base embedding level.
6987 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6989 * lread.c (readevalloop): Use correct code for NBSP.
6990 (read1): Likewise. (Bug#9608)
6992 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
6994 * dbusbind.c (Fdbus_register_signal): When service is not
6995 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6997 2011-09-25 Glenn Morris <rgm@gnu.org>
6999 * buffer.c (truncate-lines): Doc fix.
7001 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
7003 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
7004 (Fset_window_next_buffers): Doc fix.
7006 2011-09-24 Glenn Morris <rgm@gnu.org>
7008 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
7010 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
7012 Fix minor problems found by static checking.
7013 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
7014 * indent.c (Fvertical_motion): Fix == vs = typo.
7016 2011-09-24 Eli Zaretskii <eliz@gnu.org>
7018 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
7019 Default value is now t. Doc fix.
7021 * indent.c (Fvertical_motion): Compute and apply the overshoot
7022 logic when moving up, not only when moving down. Fix the
7023 confusing name and values of the it_overshoot_expected variable;
7024 logic changes accordingly. (Bug#9254) (Bug#9549)
7026 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
7027 CHARPOS is covered by a display string which includes newlines.
7028 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7029 is covered by a display string with embedded newlines.
7031 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
7033 * dbusbind.c (Fdbus_register_signal): Add match rule to
7034 Vdbus_registered_objects_table. (Bug#9581)
7035 (Fdbus_register_method, Vdbus_registered_objects_table):
7038 2011-09-24 Jim Meyering <meyering@redhat.com>
7040 do not ignore write error for any output size
7041 The previous change was incomplete.
7042 While it makes emacs --batch detect the vast majority of stdout
7043 write failures, errors were still ignored whenever the output size is
7044 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7045 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7046 && echo FAIL: ignored write error
7047 FAIL: ignored write error
7048 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7049 && echo FAIL: ignored write error
7050 FAIL: ignored write error
7051 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7053 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7055 * emacs.c (Fkill_emacs): In noninteractive mode exit
7056 non-successfully if a write error occurred on stdout. (Bug#9574)
7058 2011-09-21 Eli Zaretskii <eliz@gnu.org>
7060 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7063 * dispextern.h (struct it): Update the comment documenting what
7066 2011-09-20 Eli Zaretskii <eliz@gnu.org>
7068 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7069 a display string, extend search for cursor position to end of row.
7070 (find_row_edges): If the row ends in a newline from a display
7071 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7072 Handle the case of a display string with multiple newlines.
7073 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7074 non-empty line. Fixes confusing cursor motion with arrow keys at
7075 the beginning of a line that starts with whitespace.
7077 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7079 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7082 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
7084 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7087 2011-09-18 Eli Zaretskii <eliz@gnu.org>
7089 * xdisp.c (display_line): Record maximum and minimum buffer
7090 positions even if no glyphs were produced (e.g., by a zero-width
7091 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7092 buffer positions that will be removed from the glyph row because
7094 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7095 column is beyond frame width: don't subtract 1 "pixel" when
7096 computing width of the stretch.
7097 (reseat_at_next_visible_line_start): Undo the change made on
7098 2011-09-17 that saved paragraph information and restored it after
7099 the call to `reseat'. (Bug#9545)
7101 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7103 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7104 and turn window cursor on if cleared (Bug#9415).
7106 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
7108 * search.c (boyer_moore): Take unibyte characters from pattern
7109 literally. (Bug#9458)
7111 2011-09-18 Eli Zaretskii <eliz@gnu.org>
7113 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7115 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7117 Fix minor problem found by static checking.
7118 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7119 initialized, to pacify gcc -Wuninitialized.
7121 * fileio.c: Report proper errno when syscall falls.
7122 (Finsert_file_contents): Save and restore errno,
7123 so that report_file_error outputs the correct diagnostic.
7124 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7126 2011-09-18 Eli Zaretskii <eliz@gnu.org>
7128 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7130 2011-09-17 Eli Zaretskii <eliz@gnu.org>
7132 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7133 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7135 2011-09-17 Eli Zaretskii <eliz@gnu.org>
7137 * xdisp.c (reseat_at_next_visible_line_start): Keep information
7138 about the current paragraph and restore it after the call to reseat.
7140 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7141 (bidi_find_paragraph_start): Search back for paragraph beginning
7142 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7143 (bidi_move_to_visually_next): Only trigger paragraph-related
7144 computations when the last character is a newline or at EOB, not
7145 just any NEUTRAL_B. (Bug#9470)
7147 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7148 truncated lines if point is covered by a display string. (Bug#9524)
7150 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7152 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7153 (cons_to_x_long): New function.
7154 (lisp_data_to_selection_data): Use it. Correct the test for
7155 short-versus-long data; it was negated. Break out of vector
7156 loop, for efficiency, when a long datum is discovered.
7158 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7160 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7162 2011-09-16 Eli Zaretskii <eliz@gnu.org>
7164 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7165 GCC PR/17406) by declaring this function with external scope.
7167 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7169 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7170 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7172 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7174 * editfns.c (Fformat): Correctly handle text properties on "%%".
7176 2011-09-15 Eli Zaretskii <eliz@gnu.org>
7178 * xterm.c (x_draw_composite_glyph_string_foreground):
7179 * w32term.c (x_draw_composite_glyph_string_foreground):
7180 * term.c (encode_terminal_code):
7181 * composite.c (composition_update_it, get_composition_id):
7182 * xdisp.c (get_next_display_element)
7183 (fill_composite_glyph_string): Add comments about special meaning
7184 of TAB characters in a composition.
7186 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7188 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
7189 This occurs when processing a multibyte format.
7190 Problem reported by Wolfgang Jenker.
7192 2011-09-15 Johan Bockgård <bojohan@gnu.org>
7194 * xdisp.c (try_cursor_movement): Only check for exact match if
7195 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7197 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7199 Remove unused external symbols.
7200 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7201 * xdisp.c (calc_pixel_width_or_height): Now static.
7202 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7203 * indent.c (check_display_width):
7204 * w32term.c: Fix comment to match code.
7205 * xterm.c, xterm.h (x_catching_errors): Remove.
7207 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7209 * xselect.c: Use signed conversions more consistently (Bug#9498).
7210 (selection_data_to_lisp_data): Assume incoming selection data are
7211 signed integers, not unsigned. This is to be consistent with
7212 outgoing selection data, which was modified to use signed integers
7213 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7214 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7215 expects long, not unsigned long.
7217 2011-09-14 Eli Zaretskii <eliz@gnu.org>
7219 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7220 computation of loop end. Reported by Johan Bockgård
7223 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
7225 * frame.c (Fother_visible_frames_p): Function deleted.
7227 2011-09-12 Eli Zaretskii <eliz@gnu.org>
7229 * indent.c (compute_motion): Process display vector front to back
7230 rather than the other way around. (Bug#2496)
7232 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7234 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7236 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
7238 * minibuf.c (Fread_from_minibuffer): Doc fix.
7240 2011-09-11 Eli Zaretskii <eliz@gnu.org>
7242 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7243 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7245 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7247 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7248 value for non-existent files.
7250 2011-09-11 Eli Zaretskii <eliz@gnu.org>
7252 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7253 set its "size" to -1. This will set the modtime_size field of
7254 the corresponding buffer to -1, which is what
7255 verify-visited-file-modtime expects for files that do not exist.
7258 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7260 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7262 * lisp.h: ... from here. push_key_description is no longer
7263 defined in keyboard.c, so its declaration should not be in
7264 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7265 logically belongs with push_key_description.
7267 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7269 * buffer.h: Include <sys/types.h> instead of <time.h>.
7270 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7271 Problem reported by Herbert J. Skuhra.
7273 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7275 * xml.c (parse_region): Make the parsing work for
7276 non-comment-starting XML files again (bug#9144).
7278 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7280 * image.c (gif_load): Fix calculation of bottom and right corner.
7283 2011-09-10 Eli Zaretskii <eliz@gnu.org>
7285 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7286 redisplay in small windows.
7288 2011-09-09 Eli Zaretskii <eliz@gnu.org>
7290 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7292 2011-09-08 Martin Rudalics <rudalics@gmx.at>
7294 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7295 Operate on live windows only.
7297 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
7299 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7301 2011-09-07 Eli Zaretskii <eliz@gnu.org>
7303 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7304 only under bidi iteration.
7306 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7308 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7310 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7312 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7313 Without this fix, the command to link temacs failed due to an
7314 undefined symbol __builtin_isnan. This is because
7315 /usr/include/iso/math_c99.h #defines isnan(x) to
7316 __builtin_isnan(x), but the bundled gcc, which identifies itself
7317 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7319 * floatfns.c (isnan): #undef, and then #define to a clone of
7321 (Fisnan): Always define, since it's always available now.
7322 (syms_of_floatfns): Always define isnan at the Lisp level.
7324 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7326 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7328 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7330 * fileio.c: Fix bugs with large file offsets (Bug#9428).
7331 The previous code assumed that file offsets (off_t values) fit in
7332 EMACS_INT variables, which is not true on typical 32-bit hosts.
7333 The code messed up by falsely reporting buffer overflow in cases
7334 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7335 when "big" contains more than 2**29 bytes, even though this
7336 inserts just one byte and does not overflow the buffer.
7337 (Finsert_file_contents): Store file offsets as off_t
7338 values, not as EMACS_INT values. Check for overflow when
7339 converting between EMACS_INT and off_t. When checking for
7340 buffer overflow or for overlap, take the offsets into account.
7341 Don't use EMACS_INT for small values where int suffices.
7342 When checking for overlap, fix a typo: ZV was used where
7343 ZV_BYTE was intended.
7344 (Fwrite_region): Don't assume off_t fits into 'long'.
7345 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7347 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
7349 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7351 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7353 sprintf-related integer and memory overflow issues (Bug#9412).
7355 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
7356 (esprintf, exprintf, evxprintf): New functions.
7357 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
7358 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
7359 (modify_event_symbol): Do not assume that the length of
7360 name_alist_or_stem is safe to alloca and fits in int.
7361 (Fexecute_extended_command): Likewise for function name and binding.
7362 (Frecursion_depth): Wrap around reliably on integer overflow.
7363 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7364 since some callers pass EMACS_INT values.
7365 (Fsingle_key_description): Don't crash if symbol name contains more
7366 than MAX_ALLOCA bytes.
7367 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7368 (get_minibuffer): Arg is now EMACS_INT, not int.
7369 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
7370 (esprintf, exprintf, evxprintf): New decls.
7371 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7373 * dbusbind.c (signature_cat): New function.
7374 (xd_signature, Fdbus_register_signal):
7375 Do not overrun buffer; instead, report string overflow.
7377 * dispnew.c (add_window_display_history): Don't overrun buffer.
7378 Truncate instead; this is OK since it's just a log.
7380 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7381 even if the time zone offset is outlandishly large.
7382 Don't mishandle offset == INT_MIN.
7384 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7385 when creating daemon; the previous buffer-overflow check was incorrect.
7387 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7388 which has the guts of the old verror function.
7390 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7391 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7393 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7394 (font_unparse_xlfd): Don't blindly alloca long strings.
7395 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
7396 fits in int, when using sprintf. Use single snprintf to count
7397 length of string rather than counting it via multiple sprintfs;
7398 that's simpler and more reliable.
7399 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7400 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7401 sprintf, in case result does not fit in int.
7403 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7404 (fontset_from_font): Print it.
7406 * frame.c (tty_frame_count): Now printmax_t, not int.
7407 (make_terminal_frame, set_term_frame_name): Print it.
7408 (x_report_frame_params): In X, window IDs are unsigned long,
7409 not signed long, so print them as unsigned.
7410 (validate_x_resource_name): Check for implausibly long names,
7411 and don't assume name length fits in 'int'.
7412 (x_get_resource_string): Don't blindly alloca invocation name;
7413 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7416 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7417 (xg_check_special_colors, xg_set_geometry):
7418 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7420 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7421 Use esprintf, not sprintf, in case result does not fit in int.
7423 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7424 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7425 it as a large positive number.
7426 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7427 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7429 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7430 in case result does not fit in int.
7432 * print.c (float_to_string): Detect width overflow more reliably.
7433 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7434 buffer overrun. Don't assume list length fits in 'int'. Treat
7435 print length of 0 as 0, not as infinity; to be consistent with other
7436 uses of print length in this function. Don't overflow print length
7437 index. Don't assume hash table size fits in 'long', or that
7438 vectorlike size fits in 'unsigned long'.
7440 * process.c (make_process): Use printmax_t, not int, to format
7441 process-name gensyms.
7443 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7445 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7446 to avoid potential buffer overrun.
7448 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7449 if X resource line is longer than 512 bytes.
7451 * xfns.c (x_window): Make sprintf buffer a bit bigger
7452 to avoid potential buffer overrun.
7454 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7456 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7458 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7460 Integer overflow fixes for scrolling, etc.
7461 Without these, Emacs silently mishandles large integers sometimes.
7462 For example, "C-u 4294967297 M-x recenter" was treated as if
7463 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7465 * xdisp.c (try_window_id): Check Emacs fixnum range before
7466 converting to 'int'.
7468 * window.c (window_scroll_line_based, Frecenter):
7469 Check that an Emacs fixnum is in range before assigning it to 'int'.
7470 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7471 values converted from Emacs fixnums.
7472 (Frecenter): Don't wrap around a line count if it is out of 'int'
7473 range; instead, treat it as an extreme value.
7474 (Fset_window_configuration, compare_window_configurations):
7475 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7477 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7478 that can exceed INT_MAX. Check that EMACS_INT value is in range
7479 before assigning it to the (possibly-narrower) index.
7480 (match_limit): Don't assume that a fixnum can fit in 'int'.
7482 * print.c (print_object): Use ptrdiff_t, not int, for index that can
7485 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
7486 (Fvertical_motion): Don't wrap around LINES values that don't fit
7487 in 'int'. Instead, treat them as extreme values. This is good
7488 enough for windows, which can't have more than INT_MAX lines anyway.
7490 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7492 * Require libxml/parser.h to avoid compilation warning.
7494 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7496 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7497 since this reportedly can destroy thread storage.
7499 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
7501 * syntax.c (find_defun_start): Update all cache variables if
7502 exiting early (Bug#9401).
7504 2011-08-30 Eli Zaretskii <eliz@gnu.org>
7506 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7508 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7509 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7510 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7512 * term.c (tty_append_glyph): New function.
7513 (produce_stretch_glyph): Static function and its prototype deleted.
7515 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7518 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7520 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7521 when checking :margin (Bug#9390).
7522 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
7523 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
7524 so that the name doesn't mislead. All uses changed.
7526 2011-08-28 Johan Bockgård <bojohan@gnu.org>
7528 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7531 2011-08-27 Eli Zaretskii <eliz@gnu.org>
7533 * xdisp.c (move_it_to): Don't bail out early when reaching
7534 position beyond to_charpos, if we are scanning backwards.
7535 (move_it_vertically_backward): When DY == 0, make sure we get to
7536 the first character in the line after the newline.
7538 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7540 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7541 (ccl_driver): Do not generate an out-of-range pointer.
7542 (Fccl_execute_on_string): Remove unnecessary check for
7543 integer overflow, noted by Stefan Monnier in
7544 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7545 Remove a FIXME that didn't need fixing.
7546 Simplify the newly-introduced buffer reallocation code.
7548 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
7550 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7552 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
7554 Integer and memory overflow issues (Bug#9196).
7556 * doc.c (get_doc_string): Rework so that
7557 get_doc_string_buffer_size is the actual buffer size, rather than
7558 being 1 less than the actual buffer size; this makes xpalloc more
7561 * image.c (x_allocate_bitmap_record, cache_image):
7562 * xselect.c (Fx_register_dnd_atom):
7563 Simplify previous changes by using xpalloc.
7565 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7566 since either will do and ptrdiff_t is convenient with xpalloc.
7568 * charset.c (charset_table_size)
7569 (struct charset_sort_data.priority): Now ptrdiff_t.
7570 (charset_compare): Don't overflow if priorities differ greatly.
7571 (Fsort_charsets): Don't assume list length fits in int.
7572 Check for size-calculation overflow when allocating sort data.
7573 (syms_of_charset): Allocate an initial charset table that is
7574 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7576 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7578 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7579 The actual value is always <= INT_MAX, and leaving it unsigned made
7580 overflow checking harder.
7582 * dispextern.h (struct glyph_matrix.rows_allocated)
7583 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7584 with xpalloc. The values are still always <= INT_MAX.
7586 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7588 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7589 (SAFE_NALLOCA): New macro.
7591 * region-cache.c (struct boundary.pos, find_cache_boundary)
7592 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7593 (set_cache_region, invalidate_region_cache)
7594 (revalidate_region_cache, know_region_cache, region_cache_forward)
7595 (region_cache_backward, pp_cache):
7596 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7597 so that ptrdiff_t * can be passed to xpalloc.
7598 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7599 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7600 (pp_cache): Don't assume cache_len fits in int.
7601 * region-cache.h: Adjust extern decls to match.
7603 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7604 EMACS_INT, since either will do, for xpalloc.
7606 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7607 (xnmalloc, xnrealloc, xpalloc): New functions.
7609 * bidi.c (bidi_shelve_header_size): New constant.
7610 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7611 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7613 * bidi.c (bidi_cache_shrink):
7614 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7616 Don't update size of array until after memory allocation succeeds,
7617 because xmalloc/xrealloc may not return.
7618 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7619 now that we have proper integer overflow checking.
7620 (record_overlay_string, overlay_strings): Catch overflows when
7621 calculating size of overlay_str_buf.
7623 * callproc.c (Fcall_process): Check for size overflow when
7624 calculating size of args2.
7625 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7626 Normally we prefer signed values, but sticking with ptrdiff_t would
7627 require adding more-complicated checks.
7629 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7630 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7631 Redo buffer-overflow calculations to avoid integer overflow.
7632 Add a FIXME comment where memory seems to be over-allocated.
7634 * character.c (Fstring): Check for size-calculation overflow.
7636 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7637 unnecessary integer overflow. Check for size overflow.
7638 (encode_coding_object): Don't update size until xmalloc succeeds.
7640 * composite.c (get_composition_id): Check for overflow in glyph
7641 length calculations.
7643 Integer and memory overflow fixes for display code.
7644 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7645 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7646 (scrolling_window): Check for overflow in size calculations.
7647 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7648 Don't assume glyph table len fits in int.
7649 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7650 (row_table_size): Now ptrdiff_t, not int.
7651 (scrolling_window): Avoid overflow in size calculations.
7652 Don't update size until allocation succeeds.
7653 * fns.c (concat): Check for overflow in size calculations.
7654 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7655 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7656 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7658 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7659 (get_doc_string): Check for size calculation overflow.
7660 Don't update size until allocation succeeds.
7661 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7662 EMACS_INT, where ptrdiff_t will do.
7663 (Fsubstitute_command_keys): Check for string overflow.
7665 * editfns.c (set_time_zone_rule): Don't assume environment length
7667 (message_length): Now ptrdiff_t, not int.
7668 (Fmessage_box): Don't update size until allocation succeeds.
7669 Don't assume message length fits in int.
7670 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7672 * emacs.c (main): Do not reallocate argv, since there is a null at
7673 the end that can be overwritten, and this way there's no need to
7674 worry about size-calculation overflow.
7675 (sort_args): Check for size-calculation overflow.
7677 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7679 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7681 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7682 (x_set_scroll_bar_width, x_figure_window_size):
7683 Check for integer overflow.
7684 (x_set_alpha): Do not assume XINT fits in int.
7686 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7687 This is for the members text_lines, text_cols, total_lines, total_cols,
7688 where the system imposes an 'int' limit.
7690 * fringe.c (Fdefine_fringe_bitmap):
7691 Don't update size until alloc works.
7693 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7694 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7696 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7697 Check for size-calculation overflow.
7698 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7699 do, as we prefer signed integers.
7700 (id_to_widget.max_size, id_to_widget.used)
7701 (xg_store_widget_in_map, xg_remove_widget_from_map)
7702 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7703 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7704 Use and return ptrdiff_t, not int.
7705 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7706 * gtkutil.h: Change prototypes to match the above.
7708 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7709 are duplicate now that they've been promoted to lisp.h.
7710 (x_allocate_bitmap_record, x_alloc_image_color)
7711 (make_image_cache, cache_image, xpm_load):
7712 Don't update size until alloc is done.
7713 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7715 Check for size calculation overflow.
7716 (ct_colors_allocated_max): New constant.
7717 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7720 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7721 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7722 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7723 Use ptrdiff_t, not int, to count maps.
7724 (read_char_minibuf_menu_prompt): Check for overflow in size
7725 calculations. Don't update size until allocation succeeds.
7726 Redo calculations to avoid overflow.
7727 * keyboard.h: Change prototypes to match the above.
7729 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7731 (current_minor_maps): Check for size calculation overflow.
7732 * keymap.h: Change prototypes to match the above.
7734 * lread.c (read1, init_obarray): Don't update size until alloc done.
7736 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7737 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7739 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7740 Now ptrdiff_t, not int.
7741 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7742 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7744 * process.c (Fnetwork_interface_list): Check for overflow
7745 in size calculation.
7747 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7749 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7750 overflow. Don't bother calling xmalloc when xrealloc will do.
7752 * search.c (Freplace_match): Check for size calculation overflow.
7753 (Fset_match_data): Don't assume list lengths fit in 'int'.
7755 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7756 for command line length. Do not attempt to address one before the
7757 beginning of an array, as that's not portable.
7759 * term.c (max_frame_lines): Remove; unused.
7760 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7762 (encode_terminal_code, calculate_costs): Check for size
7763 calculation overflow.
7764 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7765 table lengths and related sizes. Don't update size until alloc
7766 done. Redo calculations to avoid overflow.
7767 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7769 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7770 subtracting pointers.
7771 (gobble_line): Check for overflow more carefully. Don't update size
7774 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7775 Don't update size until alloc done.
7776 Redo size calculations to avoid overflow.
7777 Check for size calculation overflow.
7778 (main) [DEBUG]: Fix typo in invoking tparam1.
7780 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7781 Use ptrdiff_t, not int, for sizes.
7782 (store_mode_line_noprop_char): Don't update size until alloc done.
7784 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7785 Use ptrdiff_t, not int, for sizes.
7786 (Finternal_make_lisp_face, cache_face):
7787 Check for size calculation overflow.
7788 (cache_face): Treat size calculation overflows as if they were
7789 memory exhaustion (the usual treatment), rather than aborting.
7791 * xfns.c (x_encode_text, x_set_name_internal)
7792 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7793 sizes, since they can exceed INT_MAX in size. Check for size
7794 calculation overflow.
7796 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7797 (xg_select): Check for size calculation overflow.
7798 Don't update size until alloc done.
7800 * xrdb.c (get_environ_db): Don't assume path length fits in int,
7801 as sprintf is limited to int lengths.
7803 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7804 (X_LONG_MIN): New macros.
7805 Use them to make the following changes clearer.
7806 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7807 This change doesn't affect the value now, but it may help remind
7808 future maintainers not to raise the value too much later.
7809 (SELECTION_QUANTUM): Remove, replacing with ...
7810 (selection_quantum): ... new function, which avoids overflow.
7812 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7813 assumption that selection length fits in 'int'.
7814 (x_reply_selection_request, x_handle_selection_request)
7815 (x_get_window_property, receive_incremental_selection)
7816 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7817 (lisp_data_to_selection_data, clean_local_selection_data):
7818 Use ptrdiff_t, not int, to record length of selection.
7819 (x_reply_selection_request, x_get_window_property)
7820 (receive_incremental_selection, x_property_data_to_lisp):
7821 Redo calculations to avoid overflow.
7822 (x_reply_selection_request): When sending hint, ceiling it at
7823 X_LONG_MAX rather than relying on wraparound overflow to send
7825 (x_get_window_property, receive_incremental_selection)
7826 (lisp_data_to_selection_data, x_property_data_to_lisp):
7827 Check for size-calculation overflow.
7828 (x_get_window_property, receive_incremental_selection)
7829 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7830 Don't store size until memory allocation succeeds.
7831 (x_get_window_property): Plug memory leak on memory exhaustion.
7832 Don't double-block input; malloc is safe here. Don't assume 2**34
7833 - 4 fits in unsigned long. Add an xassert to check
7834 XGetWindowProperty overflow. Be more careful about overflow
7835 calculations, and distinguish size from memory overflow better.
7836 (receive_incremental_selection): When tracing, don't assume
7837 unsigned int is less than INT_MAX.
7838 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7839 harmful) conversions of unsigned short to int.
7840 (lisp_data_to_selection_data): Don't assume that integers
7841 in the range -65535 through -1 fit in an X unsigned short.
7842 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7843 result parameters unless successful. Rely on cons_to_unsigned
7844 to report problems with elements; the old code wasn't right anyway.
7845 (x_check_property_data): Check for int overflow; we cannot use
7846 a wider type due to X limits.
7847 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7849 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
7851 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7852 (x_term_init): Check for size calculation overflow.
7853 (x_color_cells): Don't store size until memory allocation succeeds.
7854 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
7855 Don't assume alloca size is less than MAX_ALLOCA.
7856 (x_term_init): Don't assume length fits in int (sprintf is limited
7859 Use ptrdiff_t for composition IDs.
7860 * character.c (lisp_string_width):
7861 * composite.c (composition_table_size, n_compositions)
7862 (get_composition_id, composition_gstring_from_id):
7863 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7864 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7865 * window.c (Frecenter):
7866 Use ptrdiff_t, not int, for composition IDs.
7867 * composite.c (get_composition_id): Check for integer overflow.
7868 * composite.h: Adjust prototypes to match the above changes.
7870 Use ptrdiff_t for hash table indexes.
7871 * category.c (hash_get_category_set):
7872 * ccl.c (ccl_driver):
7873 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7874 * coding.c (coding_system_charset_list, detect_coding_system):
7875 * coding.h (struct coding_system.id):
7876 * composite.c (get_composition_id, gstring_lookup_cache):
7877 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7878 * image.c (xpm_get_color_table_h):
7879 * lisp.h (hash_lookup, hash_put):
7880 * minibuf.c (Ftest_completion):
7881 Use ptrdiff_t for hash table indexes, not int (which is too
7882 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7883 32-bit --with-wide-int hosts).
7885 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7886 Add a FIXME comment about memory leaks.
7887 (syms_of_charset): Don't assume xmalloc returns.
7889 Don't assume that stated character widths fit in int.
7890 * character.c (Fchar_width, c_string_width, lisp_string_width):
7891 * character.h (CHAR_WIDTH):
7892 * indent.c (MULTIBYTE_BYTES_WIDTH):
7893 Use sanitize_char_width to avoid undefined and/or bad behavior
7894 with outlandish widths.
7895 * character.h (sanitize_tab_width): Rename from sanitize_width,
7896 now that we have two such functions. All uses changed.
7897 (sanitize_char_width): New inline function.
7899 Don't assume that tab-width fits in int.
7900 * character.h (sanitize_width): New inline function.
7901 (SANE_TAB_WIDTH): New macro.
7902 (ASCII_CHAR_WIDTH): Use it.
7903 * indent.c (sane_tab_width): Remove. All uses replaced by
7904 SANE_TAB_WIDTH (current_buffer).
7905 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7907 * fileio.c: Integer overflow issues with file modes.
7908 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7910 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7911 Remove unreachable code.
7912 (read_hex, load_charset_map_from_file): Check for integer overflow.
7914 * xterm.c: Don't go over XClientMessageEvent limit.
7915 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7916 (x_send_scroll_bar_event): Likewise. Check that the size does not
7917 exceed limits imposed by XClientMessageEvent, as well as the usual
7918 ptrdiff_t and size_t limits.
7920 * keyboard.c: Overflow, signedness and related fixes.
7921 (make_lispy_movement): Use same integer type in forward decl
7922 that is used in the definition.
7923 (read_key_sequence, keyremap_step):
7924 Change bufsize argument back to int, undoing my 2011-03-30 change.
7925 We prefer signed types, and int is wide enough here.
7926 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7927 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7928 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7929 length, not size_t. Use ptrdiff_t for index, not int.
7930 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7931 possibility of integer overflow.
7933 Overflow, signedness and related fixes for images.
7935 * dispextern.h (struct it.stack[0].u.image.image_id)
7936 (struct_it.image_id, struct image.id, struct image_cache.size)
7937 (struct image_cache.used, struct image_cache.ref_count):
7938 * gtkutil.c (update_frame_tool_bar):
7939 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7940 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7941 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7942 * nsmenu.m (update_frame_tool_bar):
7943 * xdisp.c (calc_pixel_width_or_height):
7944 * xfns.c (image_cache_refcount):
7945 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7946 on typical 64-bit hosts.
7948 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7949 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7950 Omit unnecessary casts to int.
7951 (parse_image_spec): Check that integers fall into 'int' range
7952 when the callers expect that.
7953 (image_ascent): Redo ascent calculation to avoid int overflow.
7954 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7955 (lookup_image): Remove unnecessary tests.
7956 (xbm_image_p): Locals are now of int, not EMACS_INT,
7957 since parse_image_check makes sure they fit into int.
7958 (png_load, gif_load, svg_load_image):
7959 Prefer int to unsigned where either will do.
7960 (tiff_handler): New function, combining the cores of the
7961 old tiff_error_handler and tiff_warning_handler.
7962 This function is rewritten to use vsnprintf and thereby avoid
7963 stack buffer overflows. It uses only the features of vsnprintf
7964 that are common to both POSIX and native Microsoft.
7965 (tiff_error_handler, tiff_warning_handler): Use it.
7966 (tiff_load, gif_load, imagemagick_load_image):
7967 Don't assume :index value fits in 'int'.
7968 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7969 (imagemagick_load_image): Check that crop parameters fit into
7970 the integer types that MagickCropImage accepts. Don't assume
7971 Vimagemagick_render_type has a nonnegative value. Don't assume
7972 size_t fits in 'long'.
7973 (gs_load): Use printmax_t to print the widest integers possible.
7974 Check for integer overflow when computing image height and width.
7976 2011-08-26 Eli Zaretskii <eliz@gnu.org>
7978 * xdisp.c (redisplay_window): Don't force window start if point
7979 will be invisible in the resulting window. (Bug#9324)
7981 2011-08-25 Eli Zaretskii <eliz@gnu.org>
7983 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7984 the display spec is of the form `(space ...)'.
7985 (handle_display_spec): Return the value returned by
7986 handle_single_display_spec, not just 1 or zero.
7987 (handle_single_display_spec): If the display spec is of the form
7988 `(space ...)', and specifies display in the text area, return 2
7990 (try_cursor_movement): Check for the need to scroll more
7991 accurately, and prefer exact match for point under bidi.
7992 Don't advance `row' beyond the last row of the window.
7994 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7995 into disp_prop; all users changed.
7997 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7998 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7999 for the text covered by the display property.
8001 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
8003 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
8004 Change return value to nil.
8005 (Frecord_buffer): Delete unused function.
8007 2011-08-24 Eli Zaretskii <eliz@gnu.org>
8009 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
8010 buffers, return left-to-right.
8011 (set_cursor_from_row): Consider candidate row a win if its glyph
8012 represents a newline and point is on that newline. Fixes cursor
8013 positioning on the newline at EOL of R2L text within L2R
8014 paragraph, and vice versa.
8015 (try_cursor_movement): Check continued rows, in addition to
8016 continuation rows. Fixes unwarranted scroll when point enters a
8017 continued line of R2L text within an L2R paragraph, or vice versa.
8018 (cursor_row_p): Consider the case of point being equal to
8019 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
8020 from the end of a short line to the beginning of a continued line
8021 of R2L text within L2R paragraph.
8022 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
8023 composed characters.
8025 * bidi.c (bidi_check_type): Use xassert.
8026 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8029 2011-08-23 Eli Zaretskii <eliz@gnu.org>
8031 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8034 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
8036 * nsfont.m (ns_otf_to_script): Fix typo.
8038 2011-08-22 Kenichi Handa <handa@m17n.org>
8040 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8041 extra slot even if the purpose is char-code-property-table.
8043 2011-08-23 Eli Zaretskii <eliz@gnu.org>
8045 * xdisp.c (redisplay_window): When computing centering_position,
8046 account for the height of the header line. (Bug#8874)
8048 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8049 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8050 candidate is selected by the mouse, and that candidate has a
8051 composed character under the mouse.
8053 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8054 coordinates reported by pos-visible-in-window-p for a composed
8055 character in column zero.
8057 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8059 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8061 2011-08-22 Eli Zaretskii <eliz@gnu.org>
8063 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8064 consider it a hit if to_charpos is anywhere in the range of the
8065 composed buffer positions.
8067 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
8069 * image.c (gif_load): Don't assume that each subimage has the same
8070 dimensions as the base image. Handle disposal method that is
8071 "undefined" by the gif spec (Bug#9335).
8073 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
8075 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
8076 (Fcondition_case): Document `debug' symbol in error handler.
8078 2011-08-19 Eli Zaretskii <eliz@gnu.org>
8080 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8081 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8082 from an Org mode buffer to a Speedbar frame.
8084 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8085 a composition, take its buffer position from IT->cmp_it.charpos.
8086 Fixes cursor positioning at the beginning of a line that begins
8087 with a composed character.
8089 2011-08-18 Eli Zaretskii <eliz@gnu.org>
8091 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8092 character bidirectional type, use STRONG_L instead. Fixes crashes
8093 in a buffer produced by `describe-categories'.
8095 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8096 members before the level stack, so they would be saved and
8097 restored when copying iterator state. Fixes incorrect reordering
8098 around TABs covered by display properties.
8100 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8102 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
8104 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
8106 * eval.c (internal_condition_case, internal_condition_case_1)
8107 (internal_condition_case_2, internal_condition_case_n):
8108 Remove unnecessary aborts (Bug#9081).
8110 2011-08-17 Eli Zaretskii <eliz@gnu.org>
8112 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8113 has no `load' handler, try opening the file locally. (Bug#9311)
8115 2011-08-16 Ken Brown <kbrown@cornell.edu>
8117 * gmalloc.c: Expand comment.
8119 2011-08-16 Eli Zaretskii <eliz@gnu.org>
8121 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8122 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8124 2011-08-16 Ken Brown <kbrown@cornell.edu>
8126 Fix memory allocation problems in Cygwin build (Bug#9273).
8128 * unexcw.c ( __malloc_initialized): Declare external variable.
8129 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8131 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8133 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8135 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8137 [CYGWIN] (special_realloc): New function.
8138 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8139 requests to realloc storage in the static heap.
8141 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8143 * bidi.c (bidi_initialize): Remove unused local.
8145 2011-08-15 Eli Zaretskii <eliz@gnu.org>
8148 * biditype.h: Remove file.
8149 * makefile.w32-in ($(BLD)/bidi.$(O)):
8150 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
8152 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8154 * chartab.c: Improve commentary for the uniprop_table API.
8156 * bidi.c (bidi_paragraph_init): Support zero value of
8157 bidi_ignore_explicit_marks_for_paragraph_level.
8158 (bidi_initialize): Use uniprop_table instead of including
8159 biditype.h and bidimirror.h.
8161 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8162 coordinates of the iterator when restoring from ppos_it.
8165 2011-08-14 Kenichi Handa <handa@m17n.org>
8167 * process.c (create_process): Call setup_process_coding_systems
8168 after the pid of the process is set to -1 (Bug#8162).
8170 2011-08-14 Eli Zaretskii <eliz@gnu.org>
8172 * xdisp.c (move_it_in_display_line_to): Don't invoke
8173 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8174 ppos_it. Fixes vertical cursor motion when line beginning is
8175 covered by an image. (Bug#9296)
8177 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8179 * nsterm.h (ns_run_ascript): Declare.
8180 (NSAPP_DATA2_RUNASSCRIPT): Define.
8182 * nsfns.m (as_script, as_result, as_status): New static variables.
8183 (ns_run_ascript): New function.
8184 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
8185 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8186 the event loop. Get status from as_status (Bug#7276).
8188 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8189 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8190 the event loop (Bug#7276).
8192 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8194 * gnutls.c (QCgnutls_bootprop_priority)
8195 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8196 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8197 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8198 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8199 (QCgnutls_bootprop_verify_hostname_error)
8200 (QCgnutls_bootprop_callbacks_verify): Rename from
8201 Qgnutls_bootprop_..., all uses changed.
8203 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8206 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8208 * xfaces.c (Qframe_set_background_mode): Now static.
8209 * dispextern.h (Qframe_set_background_mode): Remove decl.
8211 * process.c (Fnetwork_interface_info): Declare local only if needed.
8213 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8215 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8216 (Fnetwork_interface_list): Allocate in increments of bytes instead
8217 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8218 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8220 (struct ifflag_def): notrailers is smart on OSX.
8221 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8222 Get hardware address with getifaddrs if available.
8224 2011-08-12 Eli Zaretskii <eliz@gnu.org>
8226 * xdisp.c (iterate_out_of_display_property): xassert that
8227 IT->position is set to within IT->object's boundaries. Break from
8228 the loop as soon as EOB is reached; avoids infloops in redisplay
8229 when IT->position is set up wrongly due to some bug.
8230 Set IT->current to match the bidi iterator unconditionally.
8231 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8232 entry. Force push_it to save on the stack the current
8233 buffer/string position, to be restored by pop_it. Fix flags in
8234 the iterator structure wrt the object coming from a display
8235 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8236 properties. (Bug#9284)
8238 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
8240 * fontset.c (fontset_get_font_group): Add proper type checks.
8243 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8245 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8246 and LC_VERSION_MIN_MACOSX.
8247 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8248 (dump_it) [LC_FUNCTION_STARTS]: Use it.
8250 2011-08-08 Eli Zaretskii <eliz@gnu.org>
8252 * xdisp.c (forward_to_next_line_start): Allow to use the
8253 no-display-properties-and-no-overlays under bidi display.
8254 Set disp_pos in the bidi iterator to avoid searches for display
8255 properties and overlays.
8257 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
8259 * editfns.c (Fset_time_zone_rule): Document relationship with the
8262 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8263 the font entity extracted from the cache (Bug#8109).
8265 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
8267 * composite.c (autocmp_chars): Don't reset point. That is done by
8268 restore_point_unwind (Bug#5984).
8270 2011-08-07 Juri Linkov <juri@jurta.org>
8272 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8273 to show the arg `TIME' instead of `TIMEVAL'.
8275 2011-08-06 Eli Zaretskii <eliz@gnu.org>
8277 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8278 display property strides EOL and includes a newline, as in
8279 longlines-mode. (Bug#9254)
8280 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8281 word-wrap under bidirectional display. (Bug#9224)
8283 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8284 is non-zero, even if the data buffer is NULL. Fixes a crash in
8285 vertical-motion with longlines-mode. (Bug#9254)
8287 2011-08-05 Eli Zaretskii <eliz@gnu.org>
8289 * bidi.c <bidi_cache_total_alloc>: Now static.
8290 (bidi_initialize): Initialize bidi_cache_total_alloc.
8292 * xdisp.c (display_line): Release buffer allocated for shelved bidi
8295 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8296 amount allocated this far in `bidi_cache_total_alloc'.
8297 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8298 non-zero, only free the data buffer without restoring the cache
8299 contents. All callers changed.
8301 * dispextern.h (bidi_unshelve_cache): Update prototype.
8303 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8304 (move_it_in_display_line, move_it_to)
8305 (move_it_vertically_backward, move_it_by_lines): Replace the call
8306 to xfree to an equivalent call to bidi_unshelve_cache.
8307 (move_it_in_display_line_to): Fix logic of returning
8308 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
8310 2011-08-05 Eli Zaretskii <eliz@gnu.org>
8312 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8313 came from a string character with a `cursor' property. (Bug#9229)
8315 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8317 * Makefile.in (LIB_PTHREAD): New variable.
8318 (LIBES): Add LIB_PTHREAD (Bug#9216).
8320 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8321 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8323 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8325 * regex.c (re_iswctype): Remove some redundant boolean conversions.
8327 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8329 * xterm.c (x_find_topmost_parent): New function.
8330 (x_set_frame_alpha): Find topmost parent window with
8331 x_find_topmost_parent and set the property there also (bug#9181).
8332 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8334 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8336 * callproc.c (Fcall_process): Avoid vfork clobbering
8337 the local vars buffer, coding_systems, current_dir.
8339 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8341 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8343 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8345 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8346 so that it is not optimized away.
8348 * xdisp.c (compute_display_string_pos): Remove unused local.
8350 2011-08-02 Eli Zaretskii <eliz@gnu.org>
8352 Fix slow cursor motion and scrolling in large buffers with
8353 selective display, like Org Mode buffers. (Bug#9218)
8355 * dispextern.h (struct bidi_it): New member disp_prop_p.
8357 * xdisp.c: Remove one-slot cache of display string positions.
8358 (compute_display_string_pos): Accept an additional argument
8359 DISP_PROP_P; callers changed. Scan at most 5K characters forward
8360 for a display string or property. If found, set DISP_PROP_P
8363 * bidi.c (bidi_fetch_char): Accept an additional argument
8364 DISP_PROP_P, and pass it to compute_display_string_pos.
8365 Only handle text covered by a display string if DISP_PROP_P is returned
8366 non-zero. All callers of bidi_fetch_char changed.
8368 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8370 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8372 2010-12-03 Don March <don@ohspite.net>
8374 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8375 last character M-[char] is translated to ESC [char] (bug#7541).
8377 2011-08-02 Kenichi Handa <handa@m17n.org>
8379 * lisp.h (uniprop_table): Extern it.
8381 * chartab.c (uniprop_table): Make it non-static.
8383 2011-08-01 Eli Zaretskii <eliz@gnu.org>
8385 * xdisp.c (forward_to_next_line_start): Accept additional argument
8386 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8388 (reseat_at_next_visible_line_start): Use the bidi iterator state
8389 returned by forward_to_next_line_start to restore the state of
8390 it->bidi_it after backing up to previous newline. (Bug#9212)
8392 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8394 * regex.c (re_comp): Protoize.
8395 (re_exec): Fix return type.
8396 (regexec): Fix type of `ret'. (Bug#9203)
8398 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8400 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8401 This is needed if max-image-size is a floating-point number.
8403 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8405 * print.c (print_object): Print empty symbol as ##.
8407 * lread.c (read1): Read ## as empty symbol.
8409 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8411 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8412 setting frame foreground color (Bug#9175).
8413 (x_set_background_color): Likewise.
8415 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8416 contents (Bug#9176).
8417 (EmacsTooltip -init): Remove bezels and add shadows to
8420 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8421 or scroll bar (Bug#8470).
8423 * nsfont.m (nsfont_open): Remove assignment to voffset and
8424 unnecessary vars hshink, expand, hd, full_height, min_height.
8425 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8427 * nsterm.h (nsfont_info): Remove voffset field.
8429 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8431 Implement strike-through and overline on NextStep (Bug#8863).
8433 * nsfont.m (nsfont_open): Use underline position provided by font,
8434 instead of hard-coded value of 2.
8435 (nsfont_draw): Call ns_draw_text_decoration instead.
8437 * nsterm.h: Add declaration for ns_draw_text_decoration.
8439 * nsterm.m (ns_draw_text_decoration): New function for drawing
8440 underline, overline, and strike-through.
8441 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8442 ns_draw_text_decoration. Change treatment of cursor drawing to
8443 accommodate underlining, etc.
8445 2011-07-28 Eli Zaretskii <eliz@gnu.org>
8447 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8450 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8452 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8453 Without this fix, if a signal arrives just after memory fills up,
8454 'malloc' might be invoked reentrantly.
8456 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8457 In other words, assume that every image size is allowed, on non-X
8458 hosts. This assumption is probably wrong, but it lets Emacs compile.
8460 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8462 * regex.c (re_iswctype): Convert return values to boolean.
8464 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8466 * xdisp.c (compute_display_string_pos): Don't use cached display
8467 string position if the buffer had its restriction changed.
8470 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8472 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8474 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8476 Integer signedness and overflow and related fixes. (Bug#9079)
8478 * bidi.c: Integer size and overflow fixes.
8479 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8480 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8481 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8482 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8483 (bidi_find_other_level_edge):
8484 Use ptrdiff_t instead of EMACS_INT where either will do.
8485 This works better on 32-bit hosts configured --with-wide-int.
8486 (bidi_cache_ensure_space): Check for size-calculation overflow.
8487 Use % rather than repeated addition, for better worst-case speed.
8488 Don't set bidi_cache_size until after xrealloc returns, because it
8490 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
8491 (bidi_cache_ensure_space): Also check that the bidi cache size
8492 does not exceed that of the largest Lisp string or buffer. See Eli
8493 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
8495 * alloc.c (__malloc_size_t): Remove.
8496 All uses replaced by size_t. See Andreas Schwab's note
8497 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8499 * image.c: Improve checking for integer overflow.
8500 (check_image_size): Assume that f is nonnull, since
8501 it is always nonnull in practice. This is one less thing to
8502 worry about when checking for integer overflow later.
8503 (x_check_image_size): New function, which checks for integer
8504 overflow issues inside X.
8505 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8506 This removes the need for a memory_full check.
8507 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8508 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8509 (xbm_read_bitmap_data): Change locals back to 'int', since
8510 their values must fit in 'int'.
8511 (xpm_load_image, png_load, tiff_load):
8512 Invoke x_create_x_image_and_pixmap earlier,
8513 to avoid much needless work if the image is too large.
8514 (tiff_load): Treat overly large images as if
8515 x_create_x_image_and_pixmap failed, not as malloc failures.
8516 (gs_load): Use x_check_image_size.
8518 * gtkutil.c: Omit integer casts.
8519 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8520 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8522 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8524 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8525 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8526 would wrongly return t on a 64-bit host.
8528 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8529 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8530 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8531 and therefore cause GCC to emit a bogus diagnostic in some cases.
8533 * image.c: Integer signedness and overflow and related fixes.
8534 This is not an exhaustive set of fixes, but it's time to
8535 record what I've got.
8536 (lookup_pixel_color, check_image_size): Remove redundant decls.
8537 (check_image_size): Don't assume that arbitrary EMACS_INT values
8538 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8539 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8540 (tiff_load, imagemagick_load_image):
8541 Check for overflow in size calculations.
8542 (x_create_x_image_and_pixmap): Remove unnecessary test for
8543 xmalloc returning NULL; that can't happen.
8544 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8545 (xpm_color_bucket): Use better integer hashing function.
8546 (xpm_cache_color): Don't possibly over-allocate memory.
8547 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8548 (gif_memory_source):
8549 Use ptrdiff_t, not int or size_t, to record sizes.
8550 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8551 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8552 either works, as we prefer signed integers.
8553 (tiff_read_from_memory, tiff_write_from_memory):
8554 Return tsize_t, not size_t, since that's what the TIFF API wants.
8555 (tiff_read_from_memory): Don't fail simply because the read would
8556 go past EOF; instead, return a short read.
8557 (tiff_load): Omit no-longer-needed casts.
8558 (Fimagemagick_types): Don't assume size fits into 'int'.
8560 Improve hashing quality when configured --with-wide-int.
8561 * fns.c (hash_string): New function, taken from sxhash_string.
8562 Do not discard information about ASCII character case; this
8563 discarding is no longer needed.
8564 (sxhash-string): Use it. Change sig to match it. Caller changed.
8565 * lisp.h: Declare it.
8566 * lread.c (hash_string): Remove, since we now use fns.c's version.
8567 The fns.c version returns a wider integer if --with-wide-int is
8568 specified, so this should help the quality of the hashing a bit.
8570 * emacs.c: Integer overflow minor fix.
8571 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8572 Define only if GNU_LINUX.
8573 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8575 * dispnew.c: Integer signedness and overflow fixes.
8576 Remove unnecessary forward decls, that were a maintenance hassle.
8577 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8579 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8580 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8581 (prepare_desired_row, line_draw_cost):
8582 Use int, not unsigned, where either works.
8583 (save_current_matrix, restore_current_matrix):
8584 Use ptrdiff_t, not size_t, where either works.
8585 (init_display): Check for overflow more accurately, and without
8586 relying on undefined behavior.
8588 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8589 Remove, replacing with the new symbols in lisp.h. All uses changed.
8590 * fileio.c (make_temp_name):
8591 * filelock.c (lock_file_1, lock_file):
8592 * xdisp.c (message_dolog):
8593 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8594 Use pMd etc. instead.
8595 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8596 replacing the pWIDE etc. symbols removed from editfns.c.
8598 * keyboard.h (num_input_events): Now uintmax_t.
8599 This is (very slightly) less likely to mess up due to wraparound.
8602 * buffer.c: Integer signedness fixes.
8603 (alloc_buffer_text, enlarge_buffer_text):
8604 Use ptrdiff_t rather than size_t when either will do, as we prefer
8607 * alloc.c: Integer signedness and overflow fixes.
8608 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8609 (__malloc_size_t): Default to size_t, not to int.
8610 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8611 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8612 Prefer ptrdiff_t to size_t when either would do, as we prefer
8614 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8615 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8616 Now const. Initialize with values that are in range even if char
8618 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8619 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8620 These functions do the right thing with sizes > 2**32.
8621 (check_depth): Now ptrdiff_t, not int.
8622 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8623 Adjust to new way of storing sizes. Check for size overflow bugs
8625 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8626 slightly wrong anyway, as it missed one instance of
8627 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8628 (refill_memory_reserve): Omit needless cast to size_t.
8629 (mark_object_loop_halt): Mark as externally visible.
8631 * xselect.c: Integer signedness and overflow fixes.
8632 (Fx_register_dnd_atom, x_handle_dnd_message):
8633 Use ptrdiff_t, not size_t, since we prefer signed.
8634 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8635 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8636 x_dnd_atoms_size and x_dnd_atoms_length.
8638 * doprnt.c: Prefer signed to unsigned when either works.
8640 * doprnt.c (doprnt):
8642 * xdisp.c (vmessage):
8643 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8644 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8645 prefer signed arithmetic to avoid comparison confusion.
8646 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8647 but is a bit tricky.
8649 Assume freestanding C89 headers, string.h, stdlib.h.
8650 * data.c, doprnt.c, floatfns.c, print.c:
8651 Include float.h unconditionally.
8652 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8653 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8654 * regex.c: Likewise for stddef.h, string.h.
8655 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8656 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8657 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8658 (STDC_HEADERS): Remove obsolete defines.
8659 * sysdep.c: Include limits.h unconditionally.
8661 Assume support for memcmp, memcpy, memmove, memset.
8662 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8663 * regex.c (memcmp, memcpy):
8664 Remove; we assume C89 now.
8666 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8667 (__malloc_safe_bcopy): Remove; no longer needed.
8669 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
8670 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8671 well either way, and we prefer signed to unsigned.
8673 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8675 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8676 closes the connection while we're reading (bug#9182).
8678 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
8680 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8681 are specified (Bug#9168).
8683 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8685 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8686 Found by GCC static checking and --with-wide-int on a 32-bit host.
8688 2011-07-25 Eli Zaretskii <eliz@gnu.org>
8690 * xdisp.c (compute_display_string_pos): Fix logic of caching
8691 previous display string position. Initialize cached_prev_pos to
8692 -1. Fixes slow-down at the beginning of a buffer.
8694 2011-07-24 Eli Zaretskii <eliz@gnu.org>
8696 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8697 for attrs[LFACE_FONTSET_INDEX].
8699 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8701 * xml.c (parse_region): Remove unused local
8702 that was recently introduced.
8704 2011-07-23 Eli Zaretskii <eliz@gnu.org>
8706 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8707 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8709 * xdisp.c (move_it_in_display_line_to): Record the best matching
8710 position for TO_CHARPOS while scanning the line, and restore it on
8711 exit if none of the characters scanned was an exact match.
8712 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
8713 when exact match is impossible due to invisible text, and the
8714 lines are truncated.
8716 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8718 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8721 2011-07-22 Eli Zaretskii <eliz@gnu.org>
8723 Fix a significant slow-down of cursor motion with C-n, C-p,
8724 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8725 auto-repeat under bidi redisplay in fontified buffers.
8726 * xdisp.c (compute_stop_pos_backwards): New function.
8727 (next_element_from_buffer): Call compute_stop_pos_backwards to
8728 find a suitable prev_stop when we find ourselves before
8730 (reseat): Don't look for prev_stop, as that could mean a very long
8732 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8733 <cached_disp_overlay_modiff>: Cache for last found display string
8735 (compute_display_string_pos): Return the cached position if asked
8736 about the same buffer in the same area of character positions, and
8737 the buffer wasn't changed since the time the display string
8738 position was cached.
8740 2011-07-22 Eli Zaretskii <eliz@gnu.org>
8742 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8743 is an integer, which is important for empty lines. (Bug#9149)
8745 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
8747 * frame.c (Fmodify_frame_parameters): In tty case, update the
8748 default face if necessary (Bug#4238).
8750 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
8752 * editfns.c (Fstring_to_char): No need to explain what a character
8753 is in the docstring (Bug#6576).
8755 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8757 * xml.c (parse_region): Make sure we always return a tree.
8759 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8761 * xml.c (parse_region): If a document contains only comments,
8764 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8766 * xml.c (make_dom): Return comments, too.
8768 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8771 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8772 and the surrounding thread.
8773 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8774 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8775 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8777 * s/openbsd.h (BROKEN_SIGIO): Define.
8778 * unexelf.c (unexec) [__OpenBSD__]:
8779 Don't update the .mdebug section of the Alpha COFF symbol table.
8781 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8783 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8786 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8788 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8789 This fixes some race conditions on the permissions of any newly
8792 * alloc.c (valid_pointer_p): Use pipe, not open.
8793 This fixes some permissions issues when debugging.
8795 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8796 If fchown fails to set both uid and gid, try to set just gid,
8797 as that is sometimes allowed. Adjust the file's mode to eliminate
8798 setuid or setgid bits that are inappropriate if fchown fails.
8800 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8802 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8803 to compare Lisp_Objects.
8804 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8805 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8806 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8808 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8810 * lread.c (read_integer): Unread even EOF character.
8811 (read1): Likewise. Properly record start position of symbol.
8813 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8814 symbol character follows.
8816 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8818 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8819 This works around a problem with the previous change to Fcopy_file.
8820 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8821 and without this change, GCC might complain about discarding
8822 fchown's return value.
8824 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
8826 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8828 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8830 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8832 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8834 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8835 it's used from the C level.
8837 * process.c: Use the same condition for POLL_FOR_INPUT in both
8838 keyboard.c and process.c (bug#1858).
8840 2011-07-09 Lawrence Mitchell <wence@gmx.li>
8842 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8843 (Fgnutls_boot): Use it.
8845 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8847 * doc.c (Fsubstitute_command_keys): Revert last change.
8849 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8851 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8852 quotes the next character, and doesn't affect other longer
8853 sequences (bug#8935).
8855 * lread.c (syms_of_lread): Clarify that is isn't only
8856 `eval-buffer' and `eval-defun' that's affected by
8857 `lexical-binding' (bug#8460).
8859 2011-07-15 Eli Zaretskii <eliz@gnu.org>
8861 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
8862 bidi redisplay when a line includes both an image and is truncated.
8864 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8866 Fix minor problems found by static checking.
8867 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8868 (elsz): Now a signed constant, not a size_t var. We prefer signed
8869 types to unsigned, to avoid integer comparison confusion. Without
8870 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8871 "cannot optimize loop, the loop counter may overflow", a symptom
8873 * indent.c (Fvertical_motion): Mark locals as initialized.
8874 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8876 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8878 * search.c (Fre_search_backward): Mention `case-fold-search' in
8879 all the re_search_* functions (bug#8138).
8881 * keyboard.c (Fopen_dribble_file): Document when the file is
8884 2011-07-14 Eli Zaretskii <eliz@gnu.org>
8886 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8889 Support bidi reordering of display and overlay strings.
8890 * xdisp.c (compute_display_string_pos)
8891 (compute_display_string_end): Accept additional argument STRING.
8892 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8893 (reseat_to_string): Initialize bidi_it->string.s and
8894 bidi_it->string.schars.
8895 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
8896 NULL (avoids a crash in bidi_paragraph_init).
8897 Initialize itb.string.lstring.
8898 (init_iterator): Call bidi_init_it only of a valid
8899 buffer position was specified. Initialize paragraph_embedding to
8901 (reseat_to_string): Initialize the bidi iterator.
8902 (display_string): If we need to ignore text properties of
8903 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8904 original value of -1 will not work with bidi.)
8905 (compute_display_string_pos): First arg is now struct
8906 `text_pos *'; all callers changed. Support display properties on
8908 (compute_display_string_end): Support display properties on Lisp
8910 (init_iterator, reseat_1, reseat_to_string): Initialize the
8911 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8912 when iterating on a string not from display properties).
8913 (compute_display_string_pos, compute_display_string_end):
8914 Fix calculation of the object to scan. Fixes an error when using
8916 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
8917 base_level_stop; instead, set base_level_stop to BEGV.
8918 Fixes crashes in vertical-motion.
8919 (next_element_from_buffer): Improve commentary for when
8920 the iterator is before prev_stop.
8921 (init_iterator): Initialize bidi_p from the default value of
8922 bidi-display-reordering, not from buffer-local value. Use the
8923 buffer-local value only if initializing for buffer iteration.
8924 (handle_invisible_prop): Support invisible properties on strings
8925 that are being bidi-reordered.
8926 (set_iterator_to_next): Support bidi reordering of C strings and
8928 (next_element_from_string): Support bidi reordering of Lisp
8930 (handle_stop_backwards): Support Lisp strings as well.
8931 (display_string): Support display of R2L glyph rows.
8932 Use IT_STRING_CHARPOS when displaying from a Lisp string.
8933 (init_iterator): Don't initialize it->bidi_p for strings
8935 (reseat_to_string): Initialize it->bidi_p for strings here.
8936 (next_element_from_string, next_element_from_c_string)
8937 (next_element_from_buffer): Add xassert's for correspondence
8938 between IT's object being iterated and it->bidi_it.string
8940 (face_before_or_after_it_pos): Support bidi iteration.
8941 (next_element_from_c_string): Handle the case of the first string
8942 character that is not the first one in the visual order.
8943 (get_visually_first_element): New function, refactored from common
8944 parts of next_element_from_buffer, next_element_from_string, and
8945 next_element_from_c_string.
8946 (tool_bar_lines_needed, redisplay_tool_bar)
8947 (display_menu_bar): Force left-to-right direction. Add a FIXME
8948 comment for making that be controlled by a user option.
8949 (push_it, pop_it): Save and restore the state of the
8950 bidi iterator. Save and restore the bidi_p flag.
8951 (pop_it): Iterate out of display property for string iteration as
8953 (iterate_out_of_display_property): Support iteration over strings.
8954 (handle_single_display_spec): Set up it->bidi_it for iteration
8955 over a display string, and call bidi_init_it.
8956 (handle_single_display_spec, next_overlay_string)
8957 (get_overlay_strings_1, push_display_prop): Set up the bidi
8958 iterator for displaying display or overlay strings.
8959 (forward_to_next_line_start): Don't use the shortcut if
8961 (back_to_previous_visible_line_start): If handle_display_prop
8962 pushed the iterator stack, restore the internal state of the bidi
8963 iterator by calling bidi_pop_it same number of times.
8964 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8965 and we are bidi-iterating, don't decrement the iterator position;
8966 instead, set the first_elt flag in the bidi iterator, to produce
8968 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8969 (push_display_prop): xassert that we are iterating a buffer.
8970 (push_it, pop_it): Save and restore paragraph_embedding member.
8971 (handle_single_display_spec, next_overlay_string)
8972 (get_overlay_strings_1, reseat_1, reseat_to_string)
8973 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8974 correctly. Don't assume unibyte strings are not bidi-reordered.
8975 (compute_display_string_pos)
8976 (compute_display_string_end): Fix handling the case of C string.
8977 (push_it, pop_it): Save and restore from_disp_prop_p.
8978 (handle_single_display_spec, push_display_prop): Set the
8979 from_disp_prop_p flag.
8980 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8981 (pop_it): Call iterate_out_of_display_property only if we are
8982 popping after iteration over a string that came from a display
8983 property. Fix a typo in popping stretch info. Add an assertion
8984 for verifying that the iterator position is in sync with the bidi
8986 (handle_single_display_spec, get_overlay_strings_1)
8987 (push_display_prop): Fix initialization of paragraph direction for
8988 string when that of the parent object is not yet determined.
8989 (reseat_1): Call bidi_init_it to resync the bidi
8990 iterator with IT's position. (Bug#7616)
8991 (find_row_edges): If ROW->start.pos gives position
8992 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8993 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8994 Reset the from_disp_prop_p flag.
8995 (SAVE_IT, RESTORE_IT): New macros.
8996 (pos_visible_p, face_before_or_after_it_pos)
8997 (back_to_previous_visible_line_start)
8998 (move_it_in_display_line_to, move_it_in_display_line)
8999 (move_it_to, move_it_vertically_backward, move_it_by_lines)
9000 (try_scrolling, redisplay_window, display_line): Use them when
9001 saving a temporary copy of the iterator and restoring it back.
9002 (back_to_previous_visible_line_start, reseat_1)
9003 (init_iterator): Empty the bidi cache "stack".
9004 (move_it_in_display_line_to): If iterator ended up at
9005 EOL, but we never saw any buffer positions smaller than
9006 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
9007 motion in bidi-reordered lines.
9008 (move_it_in_display_line_to): Record prev_method and prev_pos
9009 immediately before the call to set_iterator_to_next. Fixes cursor
9010 motion in bidi-reordered lines with stretch glyphs and strings
9011 displayed in margins. (Bug#8133) (Bug#8867)
9012 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
9014 (pos_visible_p): Support positions in bidi-reordered lines.
9015 Save and restore bidi cache.
9017 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
9018 (bidi_paragraph_info): Delete unused struct.
9019 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
9020 (bidi_cache_start): New variable.
9021 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
9023 (bidi_cache_fetch_state, bidi_cache_search)
9024 (bidi_cache_find_level_change, bidi_cache_iterator_state)
9025 (bidi_cache_find, bidi_peek_at_next_level)
9026 (bidi_level_of_next_char, bidi_find_other_level_edge)
9027 (bidi_move_to_visually_next): Compare cache index with
9028 bidi_cache_start rather than with zero.
9029 (bidi_fetch_char): Accept new argument STRING; all callers
9030 changed. Support iteration over a string. Support strings with
9031 display properties. Support unibyte strings. Fix the type of
9032 `len' according to what STRING_CHAR_AND_LENGTH expects.
9033 (bidi_paragraph_init, bidi_resolve_explicit_1)
9034 (bidi_resolve_explicit, bidi_resolve_weak)
9035 (bidi_level_of_next_char, bidi_move_to_visually_next):
9036 Support iteration over a string.
9037 (bidi_set_sor_type, bidi_resolve_explicit_1)
9038 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9039 can now be zero (for strings); special values 0 and -1 were
9040 changed to -1 and -2, respectively.
9041 (bidi_char_at_pos): New function.
9042 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9043 Call it instead of FETCH_MULTIBYTE_CHAR.
9044 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9045 initialized to valid values.
9046 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9048 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9049 the test for valid cached positions. Fix the logic for looking up
9050 the sentinel state in the cache. GCPRO the Lisp string we are
9052 (bidi_push_it, bidi_pop_it): New functions.
9053 (bidi_initialize): Initialize the bidi cache start stack pointer.
9054 (bidi_cache_ensure_space): New function, refactored from part of
9055 bidi_cache_iterator_state. Don't assume the required size is just
9056 one BIDI_CACHE_CHUNK away.
9057 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9058 (bidi_count_bytes, bidi_char_at_pos): New functions.
9059 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9060 always valid if bidi_cache_idx is valid.
9061 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9062 is valid if it's going to be used.
9063 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9064 (bidi_cache_fetch_state, bidi_cache_search)
9065 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9066 (bidi_cache_iterator_state, bidi_cache_find)
9067 (bidi_find_other_level_edge, bidi_cache_start_stack):
9068 All variables related to cache indices are now EMACS_INT.
9070 * dispextern.h (struct bidi_string_data): New structure.
9071 (struct bidi_it): New member `string'. Make flag members be 1-bit
9072 fields, and put them last in the struct.
9073 (compute_display_string_pos, compute_display_string_end):
9075 (bidi_push_it, bidi_pop_it): Add prototypes.
9076 (struct iterator_stack_entry): New members bidi_p,
9077 paragraph_embedding, and from_disp_prop_p.
9078 (struct it): Member bidi_p is now a bit field 1 bit wide.
9079 (bidi_shelve_cache, bidi_unshelve_cache):
9082 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9083 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9084 and vector-like objects.
9086 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9087 cache around display iteration.
9089 * window.c (Fwindow_end, window_scroll_pixel_based)
9090 (displayed_window_lines, Frecenter): Save and restore the bidi
9091 cache around display iteration.
9093 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9095 * editfns.c (Fdelete_region): Clarify the use of the named
9096 parameters (bug#6788).
9098 2011-07-14 Martin Rudalics <rudalics@gmx.at>
9100 * indent.c (Fvertical_motion): Set and restore w->pointm when
9101 saving and restoring the window's buffer (Bug#9006).
9103 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9105 * editfns.c (Fstring_to_char): Clarify just what is returned
9106 (bug#6576). Text by Eli Zaretskii.
9108 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
9110 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9112 2011-07-13 Eli Zaretskii <eliz@gnu.org>
9114 * buffer.c (mmap_find): Fix a typo.
9116 2011-07-13 Johan Bockgård <bojohan@gnu.org>
9118 Fix execution of x selection hooks.
9119 * xselect.c (Qx_lost_selection_functions)
9120 (Qx_sent_selection_functions): New vars.
9121 (syms_of_xselect): DEFSYM them.
9122 (x_handle_selection_request): Pass Qx_sent_selection_functions
9123 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9124 (x_handle_selection_clear,x_clear_frame_selections):
9125 Pass Qx_lost_selection_functions rather than
9126 Vx_lost_selection_functions to Frun_hook_with_args.
9128 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9130 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
9131 The old code sometimes used this field without initializing it.
9133 * alloc.c (gc_sweep): Don't read past end of array.
9134 In theory, the old code could also have corrupted Emacs internals,
9135 though it'd be very unlikely.
9137 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9139 * character.c (Fcharacterp): Don't advertise optional ignored
9140 argument. (Bug#4026)
9142 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9144 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9147 * window.c (Fset_window_start): Doc fix (bug#4199).
9148 (Fset_window_hscroll): Ditto.
9150 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9152 Fix minor new problems caught by GCC 4.6.1.
9153 * term.c (init_tty): Remove unused local.
9154 * xsettings.c (store_monospaced_changed): Define this function only
9155 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
9158 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
9160 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9162 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9164 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9165 are the mini-buffer and the echo area (bug#3320).
9167 * term.c (init_tty): Remove support for supdup, c10 and perq
9168 terminals, which are no longer supported (bug#1482).
9170 2011-07-10 Johan Bockgård <bojohan@gnu.org>
9172 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9174 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9176 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9177 for non-popups (Bug#3642).
9179 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9181 * alloc.c (reset_malloc_hooks): Protoize.
9182 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
9183 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9184 * cm.c (losecursor): Likewise.
9185 * data.c (fmod): Likewise.
9186 * dispnew.c (swap_glyphs_in_rows): Likewise.
9187 * emacs.c (memory_warning_signal): Likewise.
9188 * floatfns.c (float_error): Likewise.
9189 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9190 (otf_open, font_otf_capability, generate_otf_features)
9191 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9193 * image.c (pbm_read_file): Likewise.
9194 * indent.c (string_display_width): Likewise.
9195 * intervals.c (check_for_interval, search_for_interval)
9196 (inc_interval_count, count_intervals, root_interval)
9197 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9198 * lread.c (defalias): Likewise.
9199 * ralloc.c (r_alloc_check): Likewise.
9200 * regex.c (set_image_of_range_1, set_image_of_range)
9201 (regex_grow_registers): Likewise.
9202 * sysdep.c (strerror): Likewise.
9203 * termcap.c (valid_filename_p, tprint, main): Likewise.
9204 * tparam.c (main): Likewise.
9205 * unexhp9k800.c (run_time_remap, save_data_space)
9206 (update_file_ptrs, read_header, write_header, calculate_checksum)
9207 (copy_file, copy_rest, display_header): Likewise.
9208 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9210 * xdisp.c (check_it): Likewise.
9211 * xfaces.c (register_color, unregister_color, unregister_colors):
9213 * xfns.c (print_fontset_result): Likewise.
9214 * xrdb.c (member, fatal, main): Likewise.
9216 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9218 Fix minor problems found by static checking (Bug#9031).
9219 * chartab.c (char_table_set_range, map_sub_char_table):
9220 Remove unused locals.
9221 (uniprop_table): Now static.
9222 * composite.c (_work_char): Remove unused static var.
9224 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
9226 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9228 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9230 * gtkutil.c (qttip_cb): Remove code without function.
9232 2011-07-09 Eli Zaretskii <eliz@gnu.org>
9234 * w32.c (pthread_sigmask): New stub.
9236 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
9238 Use pthread_sigmask, not sigprocmask (Bug#9010).
9239 sigprocmask is portable only for single-threaded applications, and
9240 Emacs can be multi-threaded when it uses GTK.
9241 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9243 * callproc.c (Fcall_process):
9244 * process.c (create_process):
9245 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9246 Use pthread_sigmask, not sigprocmask.
9248 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9250 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9251 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9254 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9256 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9257 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9258 (xg_hide_tooltip): Fix comment.
9260 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9261 in registerServicesMenuSendTypes.
9262 (validRequestorForSendType): Don't check ns_return_types.
9264 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9267 2011-07-08 Jason Rumney <jasonr@gnu.org>
9269 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9270 SH_SHOW for hidden windows (Bug#5482).
9272 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9273 frame struct members of non-existent frames (Bug#6284).
9275 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9277 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9278 variable firstTime not needed on OSX >= 10.6.
9279 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9280 >= 10.5. Use setKnobProportion, setDoubleValue.
9282 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9283 (MAC_OS_X_VERSION_10_5): Define if not defined.
9284 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9285 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9286 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9288 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
9289 cString and lossyCString on OSX >= 10.4.
9291 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
9292 sizeToFit on OSX >= 10.2.
9294 * nsimage.m (allocInitFromFile): Don't use deprecated method
9295 bestRepresentationForDevice on OSX >= 10.6.
9297 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9300 * emacs.c: Declare unexec_init_emacs_zone.
9302 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9304 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9306 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9307 on svcsMenu (Bug#8842).
9309 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9311 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9313 * nsterm.m (QUTF8_STRING): Declare.
9314 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9315 (validRequestorForSendType): Return type is (id).
9316 Change indexOfObjectIdenticalTo to indexOfObject.
9317 Check if we have local selection before returning self (Bug#8842).
9318 (writeSelectionToPasteboard): Put local selection into paste board
9319 if we have a local selection (Bug#8842).
9320 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9322 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9323 (ns_get_local_selection): Declare.
9325 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9327 * keymap.c (describe_map_tree): Don't insert a double newline at
9328 the end of the buffer (bug#1169) and return whether we inserted
9331 * callint.c (Fcall_interactively): Change "reading args" to
9332 "providing args" to try to clarify what it does (bug#1010).
9334 2011-07-07 Kenichi Handa <handa@m17n.org>
9336 * composite.c (composition_compute_stop_pos): Ignore a static
9337 composition starting before CHARPOS (Bug#8915).
9339 * xdisp.c (handle_composition_prop): Likewise.
9341 2011-07-07 Eli Zaretskii <eliz@gnu.org>
9343 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9346 2011-07-07 Kenichi Handa <handa@m17n.org>
9348 * character.h (unicode_category_t): New enum type.
9350 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9351 (Qchar_code_property_table): New variable.
9352 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9353 (UNIPROP_COMPRESSED_FORM_P): New macros.
9354 (char_table_ascii): Uncompress the compressed values.
9355 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9356 Uncompress the compressed values.
9357 (sub_char_table_ref_and_range): Likewise.
9358 (char_table_ref_and_range): Uncompress the compressed values.
9359 (sub_char_table_set): New arg is_uniprop. Callers changed.
9360 Uncompress the compressed values.
9361 (sub_char_table_set_range): Args changed. Callers changed.
9362 (char_table_set_range): Adjuted for the above change.
9363 (map_sub_char_table): Delete args default_val and parent. Add arg
9364 top. Give decoded values to a Lisp function.
9365 (map_char_table): Adjust for the above change. Give decoded
9366 values to a Lisp function. Gcpro more variables.
9367 (uniprop_table_uncompress)
9368 (uniprop_decode_value_run_length): New functions.
9369 (uniprop_decoder, uniprop_decoder_count): New variables.
9370 (uniprop_get_decoder, uniprop_encode_value_character)
9371 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9373 (uniprop_encoder, uniprop_encoder_count): New variables.
9374 (uniprop_get_encoder, uniprop_table)
9375 (Funicode_property_table_internal, Fget_unicode_property_internal)
9376 (Fput_unicode_property_internal): New functions.
9377 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9378 Sunicode_property_table_internal, Sget_unicode_property_internal,
9379 and Sput_unicode_property_internal. Defvar_lisp
9380 char-code-property-alist.
9382 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
9383 Vunicode_category_table.
9385 * font.c (font_range): Adjust for the change of
9386 Vunicode_category_table.
9388 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9390 * m/iris4d.h: Remove file, move contents ...
9391 * s/irix6-5.h: ... here.
9393 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9395 Remove unportable assumption about struct layout (Bug#8884).
9396 * alloc.c (mark_buffer):
9397 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9398 (clone_per_buffer_values): Don't assume that
9399 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9400 This isn't true in general, and it's particularly not true
9401 if Emacs is configured with --with-wide-int.
9402 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9403 New macros, used in the buffer.c change.
9405 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9407 * xsettings.c: Use both GConf and GSettings if both are available.
9408 (store_config_changed_event): Add comment.
9409 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9410 (store_tool_bar_style_changed): New functions.
9411 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
9412 (struct xsettings): Move font inside HAVE_XFT.
9413 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
9414 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
9415 Move inside HAVE_XFT.
9416 (something_changed_gsettingsCB): Rename from something_changedCB.
9417 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9419 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
9420 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
9421 (something_changed_gconfCB): Rename from something_changedCB.
9422 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9423 (parse_settings): Move check for font inside HAVE_XFT.
9424 (read_settings, apply_xft_settings): Add comment.
9425 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9426 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9427 call store_font_name_changed.
9428 (xft_settings_event): Add comment.
9429 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9430 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9431 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9432 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9433 (xsettings_initialize): Call init_gsettings last.
9434 (xsettings_get_system_font, xsettings_get_system_normal_font):
9437 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9439 Random fixes. E.g., (random) never returned negative values.
9440 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9441 subseconds part to the entropy, as that's a bit more random.
9442 Prefer signed to unsigned, since the signedness doesn't matter and
9443 in general we prefer signed. When given a limit, use a
9444 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9445 latter isn't right if USE_2_TAGS_FOR_INTS.
9446 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9447 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9449 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9451 * textprop.c (text_property_stickiness):
9452 Obey Vtext_property_default_nonsticky.
9453 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9454 * w32fns.c (syms_of_w32fns):
9455 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9457 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9459 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9460 This is more efficient than Ffile_directory_p and avoids a minor race.
9462 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9464 * buffer.c (Foverlay_put): Say what the return value is
9467 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9468 is a directory before asking whether to use the file name
9470 (barf_or_query_if_file_exists): Make the "File is a directory"
9471 error be more correct.
9473 * fns.c (Frequire): Remove the mention of the .gz files, since
9474 that's installation-specific, but keep the mention of
9475 `get-load-suffixes'.
9477 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9479 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9480 Report string overflow if the output is too long.
9482 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
9484 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9485 (syms_of_gnutls): Remove duplicate DEFSYM for
9486 Qgnutls_bootprop_verify_hostname_error, an error for
9487 Qgnutls_bootprop_verify_error (which is no longer used).
9489 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9490 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9491 Also (re)move comments that are misplaced or no longer relevant.
9493 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9495 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9497 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
9499 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9500 and background color parameters if they have been changed.
9502 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9504 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9506 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9508 * xsettings.c (SYSTEM_FONT): Define only when used.
9509 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9511 * keymap.c (access_keymap_1): Now static.
9513 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
9515 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9516 leave any prefix arg for the up event (Bug#1586).
9518 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9520 * lread.c (syms_of_lread): Mention single symbols defined by
9521 `defvar' or `defconst' (bug#7154).
9523 * fns.c (Frequire): Mention .el.gz files (bug#7314).
9524 (Frequire): Mention get-load-suffixes.
9526 2011-07-02 Martin Rudalics <rudalics@gmx.at>
9528 * window.h (window): Remove clone_number slot.
9529 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9531 (make_parent_window, make_window, saved_window)
9532 (Fset_window_configuration, save_window_save): Don't deal with
9534 * buffer.c (Qclone_number): Remove declaration.
9535 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9537 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9539 Add multiple inheritance to keymaps.
9540 * keymap.c (Fmake_composed_keymap): New function.
9541 (Fset_keymap_parent): Simplify.
9542 (fix_submap_inheritance): Remove.
9543 (access_keymap_1): New function extracted from access_keymap to handle
9544 embedded parents and handle lists of maps.
9545 (access_keymap): Use it.
9546 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9547 (Fcopy_keymap): Handle embedded parents.
9548 (Fcommand_remapping, define_as_prefix): Simplify.
9549 (Fkey_binding): Simplify.
9550 (syms_of_keymap): Move minibuffer-local-completion-map,
9551 minibuffer-local-filename-completion-map,
9552 minibuffer-local-must-match-map, and
9553 minibuffer-local-filename-must-match-map to Elisp.
9554 (syms_of_keymap): Defsubr make-composed-keymap.
9555 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9556 (parse_menu_item): Trivial simplification.
9558 2011-07-01 Glenn Morris <rgm@gnu.org>
9560 * Makefile.in (SETTINGS_LIBS): Fix typo.
9562 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9564 * coding.c (Fencode_coding_string): Record the last coding system
9565 used, as the function doc string says (bug#8738).
9567 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9569 * xsettings.c (store_monospaced_changed): Take new font as arg and
9570 check for change against current_mono_font.
9571 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9572 (emacs_settings_constructor, emacs_settings_get_property)
9573 (emacs_settings_set_property, emacs_settings_class_init)
9574 (emacs_settings_init, gsettings_obj): Remove.
9575 (something_changedCB): New function for HAVE_GSETTINGS.
9576 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9577 with value as argument.
9578 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9579 g_settings_new (Bug#8967). Do not create gsettings_obj.
9580 Remove calls to g_settings_bind. Connect something_changedCB to
9583 * xgselect.c: Add defined (HAVE_GSETTINGS).
9584 (xgselect_initialize): Ditto.
9586 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9587 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9590 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9592 * eval.c (struct backtrace): Simplify and port the data structure.
9593 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9594 signed bit field, as this assumption is not portable and it makes
9595 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9596 "char debug_on_exit : 1" as this is not portable either; instead,
9597 use the portable "unsigned int debug_on_exit : 1". Remove unused
9598 member evalargs. Remove obsolete comments about cc bombing out.
9600 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9602 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9603 Let HAVE_GSETTINGS override HAVE_GCONF.
9604 (store_monospaced_changed): New function.
9605 (EMACS_SETTINGS): A new type derived from GObject to handle
9606 GSettings notifications.
9607 (emacs_settings_constructor, emacs_settings_get_property)
9608 (emacs_settings_set_property, emacs_settings_class_init):
9610 (gsettings_client, gsettings_obj): New variables.
9611 (GSETTINGS_SCHEMA): New define.
9612 (something_changedCB): Call store_monospaced_changed.
9613 (init_gsettings): New function.
9614 (xsettings_initialize): Call init_gsettings.
9615 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9618 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9621 2011-06-29 Martin Rudalics <rudalics@gmx.at>
9623 * window.c (resize_root_window, grow_mini_window)
9624 (shrink_mini_window): Rename Qresize_root_window to
9625 Qwindow_resize_root_window and Qresize_root_window_vertically to
9626 Qwindow_resize_root_window_vertically.
9628 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9630 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9632 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
9634 * makefile.w32-in: Redesign dependencies so they reflect more
9635 clearly which files are directly included by each source file,
9636 and not through other includes.
9638 2011-06-27 Martin Rudalics <rudalics@gmx.at>
9640 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9641 (sort_overlays, overlay_strings): When an overlay's clone number
9642 matches the window's clone number process the overlay even if
9643 the overlay's window property doesn't match the current window.
9645 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9646 (Fwindow_hchild): Rename to Fwindow_left_child.
9647 (Fwindow_next): Rename to Fwindow_next_sibling.
9648 (Fwindow_prev): Rename to Fwindow_prev_sibling.
9649 (resize_window_check): Rename to window_resize_check.
9650 (resize_window_apply): Rename to window_resize_apply.
9651 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9652 (Fdelete_other_windows_internal, resize_frame_windows)
9653 (Fsplit_window_internal, Fdelete_window_internal)
9654 (grow_mini_window, shrink_mini_window)
9655 (Fresize_mini_window_internal): Fix callers accordingly.
9657 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9659 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9660 (emacs_fixed_set_min_size): Remove.
9661 (emacs_fixed_new): Take frame as argument.
9663 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9664 (_EmacsFixedPrivate): Remove minwidth/height.
9665 Add struct frame *f.
9666 (emacs_fixed_init): Initialize priv->f.
9667 (get_parent_class, emacs_fixed_set_min_size): Remove.
9668 (emacs_fixed_new): Set priv->f to argument.
9669 (emacs_fixed_get_preferred_width)
9670 (emacs_fixed_get_preferred_height): Use min_width/height from
9671 frames size_hint to set minimum and natural (Bug#8919).
9672 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9673 and use min_width/height from frames size_hint to set
9674 min_width/height (Bug#8919).
9676 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9677 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9680 2011-06-26 Eli Zaretskii <eliz@gnu.org>
9682 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9683 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9686 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
9688 * process.c (wait_reading_process_output): Bypass select if
9689 waiting for a cell while ignoring keyboard input, and input is
9690 pending. Suggested by Jan Djärv (Bug#8869).
9692 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9694 Use gnulib's dup2 module instead of rolling our own.
9695 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9697 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9699 * dispnew.c (scrolling_window): Before scrolling, turn off a
9700 mouse-highlight in the window being scrolled.
9702 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
9704 Move DEFSYM to lisp.h and use everywhere.
9706 * character.h (DEFSYM): Move declaration...
9707 * lisp.h (DEFSYM): ...here.
9713 * w32select.c: Don't include character.h.
9715 * alloc.c (syms_of_alloc):
9716 * buffer.c (syms_of_buffer):
9717 * bytecode.c (syms_of_bytecode):
9718 * callint.c (syms_of_callint):
9719 * casefiddle.c (syms_of_casefiddle):
9720 * casetab.c (init_casetab_once):
9721 * category.c (init_category_once, syms_of_category):
9722 * ccl.c (syms_of_ccl):
9723 * cmds.c (syms_of_cmds):
9724 * composite.c (syms_of_composite):
9725 * dbusbind.c (syms_of_dbusbind):
9726 * dired.c (syms_of_dired):
9727 * dispnew.c (syms_of_display):
9728 * doc.c (syms_of_doc):
9729 * editfns.c (syms_of_editfns):
9730 * emacs.c (syms_of_emacs):
9731 * eval.c (syms_of_eval):
9732 * fileio.c (syms_of_fileio):
9733 * fns.c (syms_of_fns):
9734 * frame.c (syms_of_frame):
9735 * fringe.c (syms_of_fringe):
9736 * insdel.c (syms_of_insdel):
9737 * keymap.c (syms_of_keymap):
9738 * lread.c (init_obarray, syms_of_lread):
9739 * macros.c (syms_of_macros):
9740 * msdos.c (syms_of_msdos):
9741 * print.c (syms_of_print):
9742 * process.c (syms_of_process):
9743 * search.c (syms_of_search):
9744 * sound.c (syms_of_sound):
9745 * syntax.c (init_syntax_once, syms_of_syntax):
9746 * terminal.c (syms_of_terminal):
9747 * textprop.c (syms_of_textprop):
9748 * undo.c (syms_of_undo):
9749 * w32.c (globals_of_w32):
9750 * window.c (syms_of_window):
9751 * xdisp.c (syms_of_xdisp):
9752 * xfaces.c (syms_of_xfaces):
9753 * xfns.c (syms_of_xfns):
9754 * xmenu.c (syms_of_xmenu):
9755 * xsettings.c (syms_of_xsettings):
9756 * xterm.c (syms_of_xterm): Use DEFSYM.
9758 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9760 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
9762 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9764 Integer and buffer overflow fixes (Bug#8873).
9766 * print.c (printchar, strout): Check for string overflow.
9767 (PRINTPREPARE, printchar, strout):
9768 Don't set size unless allocation succeeds.
9770 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9771 for sizes. Check for string overflow more accurately.
9772 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9774 * macros.c: Integer and buffer overflow fixes.
9775 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9776 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9777 Use ptrdiff_t, not int, for sizes.
9778 Don't increment bufsize until after realloc succeeds.
9779 Check for size-calculation overflow.
9780 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9782 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9784 * lread.c: Integer overflow fixes.
9785 (read_integer): Radix is now EMACS_INT, not int,
9786 to improve quality of diagnostics for out-of-range radices.
9787 Calculate buffer size correctly for out-of-range radices.
9788 (read1): Check for integer overflow in radices, and in
9789 read-circle numbers.
9790 (read_escape): Avoid int overflow.
9791 (Fload, openp, read_buffer_size, read1)
9792 (substitute_object_recurse, read_vector, read_list, map_obarray):
9793 Use ptrdiff_t, not int, for sizes.
9794 (read1): Use EMACS_INT, not int, for sizes.
9795 Check for size overflow.
9797 * image.c (cache_image): Check for size arithmetic overflow.
9799 * lread.c: Integer overflow issues.
9800 (saved_doc_string_size, saved_doc_string_length)
9801 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9802 Now ptrdiff_t, not int.
9803 (read1): Don't assume doc string length fits in int. Check for
9804 out-of-range doc string lengths.
9805 (read_list): Don't assume file position fits in int.
9806 (read_escape): Check for hex character overflow.
9808 2011-06-22 Leo Liu <sdl.web@gmail.com>
9810 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9811 Move to minibuffer.el.
9813 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9815 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
9816 The following patches are for when GLYPH_DEBUG && !XASSERT.
9817 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9818 * dispnew.c (flush_stdout):
9819 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9820 Mark as externally visible.
9821 * dispnew.c (check_window_matrix_pointers): Now static.
9822 * dispnew.c (window_to_frame_vpos):
9823 * xfns.c (unwind_create_frame):
9824 * xterm.c (x_check_font): Remove unused local.
9825 * scroll.c (CHECK_BOUNDS):
9826 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9827 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9828 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9829 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9830 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9832 (debug_method_add): Use va_list and vsprintf rather than relying
9833 on undefined behavior with wrong number of arguments.
9834 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9835 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9836 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9837 since we're not interested in debugging glyphs with old libraries.
9838 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9839 GCC 4.6.0's static checking.
9841 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9843 Integer overflow and signedness fixes (Bug#8873).
9844 A few related buffer overrun fixes, too.
9846 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9848 * dispextern.h (struct face.stipple):
9849 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9850 (x_bitmap_mask, x_allocate_bitmap_record)
9851 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9852 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9853 (x_create_bitmap_from_xpm_data):
9854 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9855 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9857 * xfaces.c (load_pixmap):
9858 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9859 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9860 (.bitmaps_last, struct x_output.icon_bitmap):
9861 Use ptrdiff_t, not int, for bitmap indexes.
9862 (x_allocate_bitmap_record): Check for size overflow.
9863 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9865 Use ptrdiff_t, not int, for overlay counts.
9866 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9867 * editfns.c (overlays_around, get_pos_property):
9868 * textprop.c (get_char_property_and_overlay):
9869 * xdisp.c (next_overlay_change, note_mouse_highlight):
9870 * xfaces.c (face_at_buffer_position):
9871 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9872 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9873 (Fnext_overlay_change, Fprevious_overlay_change)
9874 (mouse_face_overlay_overlaps, Foverlays_in):
9875 Use ptrdiff_t, not int, for sizes.
9876 (overlays_at, overlays_in): Check for size-calculation overflow.
9878 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9880 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9881 (x_session_initialize): Do not assume string length fits in int.
9883 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9884 This is unlikely, but can occur if DPI is outlandish.
9886 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
9887 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9889 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9890 * xrdb.c (magic_file_p, search_magic_path):
9891 Omit last arg SUFFIX; it was always 0. All callers changed.
9892 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9894 * xfont.c (xfont_match): Avoid need for strlen.
9896 * xfns.c: Don't assume strlen fits in int.
9897 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9899 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9900 not unsigned long, as we prefer signed integers. All callers changed.
9901 Detect integer overflow in repeat count.
9902 (message_dolog): Don't assume print length fits in 39 bytes.
9903 (display_mode_element): Don't assume strlen fits in int.
9905 * termcap.c: Don't assume sizes fit in int and never overflow.
9906 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9907 (gobble_line): Check for size-calculation overflow.
9909 * minibuf.c (Fread_buffer):
9910 * lread.c (intern, intern_c_string):
9911 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9912 Don't assume string length fits in int.
9914 * keyboard.c (parse_tool_bar_item):
9915 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9917 * font.c: Don't assume string length fits in int.
9918 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9919 Use ptrdiff_t, not int.
9920 (font_intern_prop): Don't assume string length fits in int.
9921 Don't assume integer property fits in fixnum.
9922 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
9924 * filelock.c: Fix some buffer overrun and integer overflow issues.
9925 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
9926 Reformulate so as not to need the command string.
9927 Invoke gzip -cd rather than gunzip, as it's more portable.
9928 (lock_info_type, lock_file_1, lock_file):
9929 Don't assume pid_t and time_t fit in unsigned long.
9930 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9931 (current_lock_owner): Prefer signed type for sizes.
9932 Use memcpy, not strncpy, where memcpy is what is really wanted.
9933 Don't assume (via atoi) that time_t and pid_t fit in int.
9934 Check for time_t and/or pid_t out of range, e.g., via a network share.
9935 Don't alloca where an auto var works fine.
9937 * fileio.c: Fix some integer overflow issues.
9938 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9939 Don't assume string length fits in int.
9940 (directory_file_name): Don't assume string length fits in long.
9941 (make_temp_name): Don't assume pid fits in int, or that its print
9942 length is less than 20.
9944 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9946 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9948 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9950 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9951 We prefer signed integers, even for size calculations.
9953 * emacs.c: Don't assume string length fits in 'int'.
9954 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9955 (main): Don't invoke strlen when not needed.
9957 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9958 (XD_DEBUG_MESSAGE): Don't waste a byte.
9960 * callproc.c (getenv_internal_1, getenv_internal)
9962 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9964 * lread.c (invalid_syntax): Omit length argument.
9965 All uses changed. This doesn't fix a bug, but it simplifies the
9966 code away from its former Hollerith-constant appearance, and it's
9967 one less 'int' to worry about when looking at integer-overflow issues.
9968 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
9970 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9971 This didn't break anything, but it didn't help either.
9972 It's confusing to put a bogus integer in a place where the actual
9973 value does not matter.
9974 (LIST_END_P): Remove unused macro and its bogus comment.
9975 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
9977 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9978 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9980 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9981 We prefer signed types, and the value cannot exceed the EMACS_INT
9982 range anyway (because otherwise the length would not be representable).
9983 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9984 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9985 This avoids a GCC warning when WIDE_EMACS_INT.
9987 * indent.c (sane_tab_width): New function.
9988 (current_column, scan_for_column, Findent_to, position_indentation)
9989 (compute_motion): Use it. This is just for clarity.
9990 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
9992 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
9994 * lisp.h (lint_assume): New macro.
9995 * composite.c (composition_gstring_put_cache):
9996 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9998 * editfns.c, insdel.c:
9999 Omit unnecessary forward decls, to simplify future changes.
10001 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
10003 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
10005 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
10006 Use much-faster test for byte-length change.
10007 Don't assume string byte-length fits in 'int'.
10008 Check that character arg fits in 'int'.
10009 (mapcar1): Declare byte as byte, for clarity.
10011 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10013 * fns.c (concat): Catch string overflow earlier.
10014 Do not rely on integer wraparound.
10016 * dispextern.h (struct it.overlay_strings_charpos)
10017 (struct it.selective): Now EMACS_INT, not int.
10018 * xdisp.c (forward_to_next_line_start)
10019 (back_to_previous_visible_line_start)
10020 (reseat_at_next_visible_line_start, next_element_from_buffer):
10021 Don't arbitrarily truncate the value of 'selective' to int.
10023 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
10025 * composite.c: Don't truncate sizes to 'int'.
10026 (composition_gstring_p, composition_reseat_it)
10027 (composition_adjust_point): Use EMACS_INT, not int.
10028 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10029 not EMACS_UINT, for indexes.
10031 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10033 * buffer.c: Include <verify.h>.
10034 (struct sortvec.priority, struct sortstr.priority):
10035 Now EMACS_INT, not int.
10036 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
10037 (struct sortstr.size, record_overlay_string)
10038 (struct sortstrlist.size, struct sortlist.used):
10039 Don't truncate size to int.
10040 (record_overlay_string): Check for size-calculation overflow.
10041 (init_buffer_once): Check at compile-time, not run-time.
10043 2011-06-22 Jim Meyering <meyering@redhat.com>
10045 Don't leak an XBM-image-sized buffer
10046 * image.c (xbm_load): Free the image buffer after using it.
10048 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10051 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10052 that Sun C diagnosed.
10053 * fns.c (secure_hash): Fix pointer signedness issue.
10054 * intervals.c (static_offset_intervals): New function.
10055 (offset_intervals): Use it.
10057 2011-06-21 Leo Liu <sdl.web@gmail.com>
10060 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10063 * fns.c (secure_hash): Rename from crypto_hash_function and change
10064 the first arg to accept symbols.
10065 (Fsecure_hash): New primitive.
10066 (syms_of_fns): New symbols.
10068 2011-06-20 Deniz Dogan <deniz@dogan.se>
10070 * process.c (Fset_process_buffer): Clarify return value in
10073 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
10075 * dispnew.c (add_window_display_history): Use BVAR.
10077 * xdisp.c (debug_method_add): Use BVAR.
10078 (check_window_end, dump_glyph_matrix, dump_glyph)
10079 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10081 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10084 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10085 check till after the cache is created in init_frame_faces.
10087 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10089 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10091 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10093 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10094 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10095 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10097 Improve buffer-overflow checking (Bug#8873).
10098 * fileio.c (Finsert_file_contents):
10099 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10100 Remove the old (too-loose) buffer overflow checks.
10101 They weren't needed, since make_gap checks for buffer overflow.
10102 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10103 The old code merely checked for Emacs fixnum overflow, and relied
10104 on undefined (wraparound) behavior. The new code avoids undefined
10105 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10107 * editfns.c (Finsert_char): Don't dump core with very negative counts.
10108 Tune. Don't use wider integers than needed. Don't use alloca.
10109 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
10111 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10113 * insdel.c, lisp.h (buffer_overflow): New function.
10114 (insert_from_buffer_1, replace_range, replace_range_2):
10115 * insdel.c (make_gap_larger):
10116 * editfns.c (Finsert_char):
10117 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10119 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10121 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10123 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
10125 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10126 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10128 * fileio.c: Don't assume EMACS_INT fits in off_t.
10129 (emacs_lseek): New static function.
10130 (Finsert_file_contents, Fwrite_region): Use it.
10131 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10133 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10135 * fns.c: Don't overflow int when computing a list length.
10136 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10137 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10138 truncation on 64-bit hosts. Check for QUIT every
10139 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10140 faster and is responsive enough.
10141 (Flength): Report an error instead of overflowing an integer.
10142 (Fsafe_length): Return a float if the value is not representable
10143 as a fixnum. This shouldn't happen except in contrived situations.
10144 (Fnthcdr, Fsort): Don't assume list length fits in int.
10145 (Fcopy_sequence): Don't assume vector length fits in int.
10147 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10148 (header_size, word_size): New constants.
10149 (allocate_vectorlike): Don't check size overflow here.
10150 (allocate_vector): Check it here instead, since this is the only
10151 caller of allocate_vectorlike that could cause overflow.
10152 Check that the new vector's length is representable as a fixnum.
10154 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10155 The previous code was bogus. For example, next_almost_prime (32)
10156 returned 39, which is undesirable as it is a multiple of 3; and
10157 next_almost_prime (24) returned 25, which is a multiple of 5 so
10158 why was the code bothering to check for multiples of 7?
10160 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10162 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10164 Variadic C functions now count arguments with ptrdiff_t.
10165 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10166 Back then I didn't know that the Emacs coding style prefers signed int.
10167 Also, in the meantime I found a few more instances where arguments
10168 were being counted with int, which may truncate counts on 64-bit
10169 machines, or EMACS_INT, which may be unnecessarily wide.
10170 * lisp.h (struct Lisp_Subr.function.aMANY)
10171 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10172 Arg counts are now ptrdiff_t, not size_t.
10173 All variadic functions and their callers changed accordingly.
10174 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10175 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10176 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10177 * callint.c (Fcall_interactively): Check arg count for overflow,
10178 to avoid potential buffer overrun. Use signed char, not 'int',
10179 for 'varies' array, so that we needn't bother to check its size
10180 calculation for overflow.
10181 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10182 * eval.c (apply_lambda):
10183 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10184 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10185 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10187 * callint.c (Fcall_interactively): Don't use index var as event count.
10189 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10190 * mem-limits.h (SIZE): Remove; no longer used.
10192 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
10194 Remove unnecessary casts.
10195 * xterm.c (x_term_init):
10196 * xfns.c (x_set_border_pixel):
10197 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10198 These aren't needed now that we assume ANSI C.
10200 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10201 It's more likely to cause problems (due to unsigned overflow)
10204 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10206 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10208 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10210 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10212 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10214 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10216 GLYPH_CODE_FACE returns EMACS_INT, not int.
10217 * dispextern.h (merge_faces):
10218 * xfaces.c (merge_faces):
10219 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10220 Don't assume EMACS_INT fits in int.
10222 * character.h (CHAR_VALID_P): Remove unused parameter.
10223 * fontset.c, lisp.h, xdisp.c: All uses changed.
10225 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10227 * fns.c (concat): Minor tuning based on overflow analysis.
10228 This doesn't fix any bugs. Use int to hold character, instead
10229 of constantly refetching from Emacs object. Use XFASTINT, not
10230 XINT, for value known to be a character. Don't bother comparing
10231 a single byte to 0400, as it's always less.
10233 * floatfns.c (Fexpt):
10234 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10236 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10239 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10241 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10242 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10243 incorrectly succeed when S was a string, because 4294967386 was
10244 truncated before it was used.
10246 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10247 Otherwise, an out-of-range integer could cause undefined behavior
10250 * composite.c: Use int, not EMACS_INT, for characters.
10251 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10252 EMACS_INT, for values that are known to be in character range.
10253 This doesn't fix any bugs but is the usual style inside Emacs and
10254 may generate better code on 32-bit machines.
10256 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10257 This is for reasons similar to the recent CHAR_STRING fix.
10258 * charset.c (Fencode_char): Check that character arg is actually
10259 a character. Pass an int to ENCODE_CHAR.
10260 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10261 wider than 'int', as a compile-time check to prevent future regressions
10264 * character.c (char_string): Remove unnecessary casts.
10266 Make sure a 64-bit char is never passed to CHAR_STRING.
10267 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10268 by silently ignoring the top 32 bits, allowing some values
10269 that were far too large to be valid characters.
10270 * character.h: Include <verify.h>.
10271 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10272 arguments are no wider than unsigned, as a compile-time check
10273 to prevent future regressions in this area.
10275 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
10276 (Fsubst_char_in_region):
10278 * xdisp.c (decode_mode_spec_coding):
10279 Adjust to CHAR_STRING's new requirement.
10280 * editfns.c (Finsert_char, Fsubst_char_in_region):
10281 * fns.c (concat): Check that character args are actually
10282 characters. Without this test, these functions did the wrong
10283 thing with wildly out-of-range values on 64-bit hosts.
10285 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10286 These casts should not be needed on 32-bit hosts, either.
10287 * keyboard.c (read_char):
10288 * lread.c (Fload): Remove casts to unsigned.
10290 * lisp.h (UNSIGNED_CMP): New macro.
10291 This fixes comparison bugs on 64-bit hosts.
10292 (ASCII_CHAR_P): Use it.
10293 * casefiddle.c (casify_object):
10294 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
10295 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10296 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10297 * dispextern.h (FACE_FROM_ID):
10298 * keyboard.c (read_char): Use UNSIGNED_CMP.
10300 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10301 not to EMACS_INT, to avoid GCC warning.
10303 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10305 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10306 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10307 isn't needed on 32-bit machines.
10309 * buffer.c (Fgenerate_new_buffer_name):
10310 Use EMACS_INT for count, not int.
10311 (advance_to_char_boundary): Return EMACS_INT, not int.
10313 * data.c (Qcompiled_function): Now static.
10315 * window.c (window_body_lines): Now static.
10317 * image.c (gif_load): Rename local to avoid shadowing.
10319 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10320 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10321 * alloc.c (make_save_value): Integer argument is now of type
10322 ptrdiff_t, not int.
10323 (mark_object): Use ptrdiff_t, not int.
10324 * lisp.h (pD): New macro.
10325 * print.c (print_object): Use it.
10327 * alloc.c: Use EMACS_INT, not int, to count objects.
10328 (total_conses, total_markers, total_symbols, total_vector_size)
10329 (total_free_conses, total_free_markers, total_free_symbols)
10330 (total_free_floats, total_floats, total_free_intervals)
10331 (total_intervals, total_strings, total_free_strings):
10332 Now EMACS_INT, not int. All uses changed.
10333 (Fgarbage_collect): Compute overall total using a double, so that
10334 integer overflow is less likely to be a problem. Check for overflow
10335 when converting back to an integer.
10336 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10337 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10338 These were 'int' variables that could overflow on 64-bit hosts;
10339 they were never used, so remove them instead of repairing them.
10340 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
10341 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10342 Previously, this ceilinged at INT_MAX, but that doesn't work on
10344 (allocate_pseudovector): Don't use EMACS_INT when int would do.
10346 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
10347 (allocate_vectorlike): Check for ptrdiff_t overflow.
10348 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10349 when a (possibly-narrower) signed value would do just as well.
10350 We prefer using signed arithmetic, to avoid comparison confusion.
10352 * alloc.c: Catch some string size overflows that we were missing.
10353 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10354 for convenience in STRING_BYTES_MAX.
10355 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10356 The definition here is exact; the one in lisp.h was approximate.
10357 (allocate_string_data): Check for string overflow. This catches
10358 some instances we weren't catching before. Also, it catches
10359 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10360 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10361 and ptrdiff_t and EMACS_INT are both 64 bits.
10363 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10364 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
10365 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
10367 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10369 * alloc.c (Fmake_string): Check for out-of-range init.
10371 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10373 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10375 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10377 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10378 xg_get_default_scrollbar_width.
10380 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10381 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10382 (style_changed_cb): Call update_theme_scrollbar_width and call
10383 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10384 all frames (Bug#8505).
10385 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10386 Call gtk_window_set_resizable if HAVE_GTK3.
10387 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10388 and height if HAVE_GTK3 (Bug#8505).
10389 (scroll_bar_width_for_theme): New variable.
10390 (update_theme_scrollbar_width): New function.
10391 (xg_get_default_scrollbar_width): Move code to
10392 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10393 (xg_initialize): Call update_theme_scrollbar_width.
10395 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10397 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10399 2011-06-12 Martin Rudalics <rudalics@gmx.at>
10401 * frame.c (make_frame): Call other_buffer_safely instead of
10404 * window.c (temp_output_buffer_show): Call display_buffer with
10405 second argument Vtemp_buffer_show_specifiers and reset latter
10406 immediately after the call.
10407 (Vtemp_buffer_show_specifiers): New variable.
10408 (auto_window_vscroll_p, next_screen_context_lines)
10409 (Vscroll_preserve_screen_position): Remove leading asterisks from
10412 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
10414 Fix minor problems found by GCC 4.6.0 static checking.
10415 * buffer.c (Qclone_number): Remove for now, as it's unused.
10416 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10417 (record_buffer): Remove unused local.
10418 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10419 (set_frame_buffer_list): Remove; unused.
10420 * frame.h (other_visible_frames): Remove decl.
10421 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10422 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10423 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10425 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10426 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10427 Define only if HAVE_GPM.
10428 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10429 (update_hints_inhibit): Remove; never set. All uses removed.
10430 * widgetprv.h (emacsFrameClassRec): Remove decl.
10431 * window.c (delete_deletable_window): Now returns void, since it
10432 wasn't returning anything.
10433 (compare_window_configurations): Remove unused locals.
10434 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10435 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
10436 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10437 the same widths as pointers. This follows up on the 2011-05-06 patch.
10438 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10439 * xterm.h: Likewise.
10440 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10442 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
10444 * makefile.w32-in: Update dependencies.
10445 (LISP_H): Add lib/intprops.h.
10447 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
10449 * image.c (gif_load): Add animation frame delay to the metadata.
10450 (syms_of_image): Use DEFSYM. New symbol `delay'.
10452 2011-06-11 Martin Rudalics <rudalics@gmx.at>
10454 * window.c (delete_deletable_window): Re-add.
10455 (Fset_window_configuration): Rewrite to handle dead buffers and
10456 consequently deletable windows.
10457 (window_tree, Fwindow_tree): Remove. Supply functionality in
10459 (compare_window_configurations): Simplify code.
10461 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10463 * image.c (imagemagick_load_image): Fix type mismatch.
10464 (Fimagemagick_types): Likewise.
10466 * window.h (replace_buffer_in_windows): Declare.
10468 2011-06-11 Martin Rudalics <rudalics@gmx.at>
10470 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10471 Qclone_number. Remove external declaration of Qdelete_window.
10472 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10474 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10475 Run Qbuffer_list_update_hook if allowed.
10476 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10477 buffer list implementation.
10478 (other_buffer_safely): New function.
10479 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10480 calls to replace_buffer_in_windows and
10481 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10483 (record_buffer): Inhibit quitting and rewrite using quittable
10484 functions. Run Qbuffer_list_update_hook if allowed.
10485 (Frecord_buffer, Funrecord_buffer): New functions.
10486 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10487 Move switch-to-buffer to window.el.
10488 (bury-buffer): Move to window.el.
10489 (Vbuffer_list_update_hook): New variable.
10491 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10494 * window.h (resize_frame_windows): Move up in code.
10495 (Fwindow_frame): Remove EXFUN.
10496 (replace_buffer_in_all_windows): Remove prototype.
10497 (replace_buffer_in_windows_safely): Add prototype.
10499 * window.c: Declare Qdelete_window static again. Move down
10500 declaration of select_count.
10501 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10502 (Fother_window): Move to window.el.
10503 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10504 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10505 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10507 (replace_buffer_in_windows): Implement by calling
10508 Qreplace_buffer_in_windows.
10509 (replace_buffer_in_all_windows): Remove with some functionality
10510 moved into replace_buffer_in_windows_safely.
10511 (replace_buffer_in_windows_safely): New function.
10512 (select_window_norecord, select_frame_norecord): Move in front
10513 of run_window_configuration_change_hook. Remove now obsolete
10515 (Fset_window_buffer): Rewrite doc-string.
10516 Call Qrecord_window_buffer.
10517 (keys_of_window): Move binding for other-window to window.el.
10519 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
10521 * dispextern.h (struct image): Replace data member, whose int_val
10522 and ptr_val fields were not used by anything, with a single
10525 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10526 (gif_clear_image, gif_load, imagemagick_load_image)
10527 (gs_clear_image, gs_load): Callers changed.
10529 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10531 * buffer.h: Include <time.h>, for time_t.
10532 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10534 Fix minor problems found by static checking.
10536 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10538 Make identifiers static if they are not used in other modules.
10539 * data.c (Qcompiled_function, Qframe, Qvector):
10540 * image.c (QimageMagick, Qsvg):
10541 * minibuf.c (Qmetadata):
10542 * window.c (resize_window_check, resize_root_window): Now static.
10543 * window.h (resize_window_check, resize_root_window): Remove decls.
10545 * window.c (window_deletion_count, delete_deletable_window):
10547 (window_body_lines): Now static.
10548 (Fdelete_other_windows_internal): Mark vars as initialized.
10549 Make sure 'resize_failed' is initialized.
10550 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10551 (resize_window_apply): Remove unused local.
10552 * window.h (delete_deletable_window): Remove decl.
10554 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
10555 (imagemagick_load_image): Fix pointer signedness problem by changing
10556 last arg from unsigned char * to char *. All uses changed.
10557 Also, fix a local for similar reasons.
10558 Remove unused locals. Remove locals to avoid shadowing.
10559 (fn_rsvg_handle_free): Remove; unused.
10560 (svg_load, svg_load_image): Fix pointer signedness problem.
10561 (imagemagick_load_image): Don't use garbage pointer image_wand.
10563 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10565 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
10567 * image.c (gif_load): Fix omitted cast error introduced by
10570 2011-06-10 Martin Rudalics <rudalics@gmx.at>
10572 * window.h (resize_proportionally, orig_total_lines)
10573 (orig_top_line): Remove from window structure.
10574 (set_window_height, set_window_width, change_window_heights)
10575 (Fdelete_window): Remove prototypes.
10576 (resize_frame_windows): Remove duplicate declaration.
10578 2011-06-10 Eli Zaretskii <eliz@gnu.org>
10580 * window.h (resize_frame_windows, resize_window_check)
10581 (delete_deletable_window, resize_root_window)
10582 (resize_frame_windows): Declare prototypes.
10584 * window.c (resize_window_apply): Make definition be "static" to
10585 match the prototype.
10587 2011-06-10 Martin Rudalics <rudalics@gmx.at>
10589 * window.c: Remove declarations of Qwindow_size_fixed,
10590 window_min_size_1, window_min_size_2, window_min_size,
10591 size_window, window_fixed_size_p, enlarge_window, delete_window.
10592 Remove static from declaration of Qdelete_window, it's
10593 temporarily needed by Fbury_buffer.
10594 (replace_window): Don't assign orig_top_line and
10596 (Fdelete_window, delete_window): Remove. Window deletion is
10597 handled by window.el.
10598 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10599 Replace Fdelete_window calls with calls to Qdelete_window.
10600 (Fdelete_other_windows): Remove. Deleting other windows is
10601 handled by window.el.
10602 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10603 handled in window.el.
10604 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10605 Window minimum sizes are handled in window.el.
10606 (shrink_windows, size_window, set_window_height)
10607 (set_window_width, change_window_heights, window_height)
10608 (window_width, CURBEG, CURSIZE, enlarge_window)
10609 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10610 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10611 handled in window.el.
10612 (make_dummy_parent): Rename to make_parent_window and give it a
10613 second argument horflag.
10614 (make_window): Don't set resize_proportionally any more.
10615 (Fsplit_window): Remove. Windows are split in window.el.
10616 (save_restore_action, save_restore_orig_size)
10617 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10618 Resize mini windows in window.el.
10619 (grow_mini_window, shrink_mini_window): Implement by calling
10620 Qresize_root_window_vertically, resize_window_check and
10621 resize_window_apply.
10622 (saved_window, Fset_window_configuration, save_window_save):
10623 Do not handle orig_top_line, orig_total_lines, and
10624 resize_proportionally.
10625 (window_min_height, window_min_width): Move to window.el.
10626 (keys_of_window): Move bindings for delete-other-windows,
10627 split-window, delete-window and enlarge-window to window.el.
10629 * buffer.c: Temporarily extern Qdelete_window.
10630 (Fbury_buffer): Temporarily call Qdelete_window instead of
10631 Fdelete_window (Fbury_buffer will move to window.el soon).
10633 * frame.c (set_menu_bar_lines_1): Remove code handling
10634 orig_top_line and orig_total_lines.
10636 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10637 set_window_height but set heights directly.
10638 (change_frame_size_1): Use resize_frame_windows.
10640 * xdisp.c (init_xdisp): Don't use set_window_height but set
10643 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10644 Use resize_frame_windows instead of change_window_heights and run
10645 run_window_configuration_change_hook.
10647 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10648 instead of change_window_heights and run
10649 run_window_configuration_change_hook.
10651 2011-06-09 Martin Rudalics <rudalics@gmx.at>
10653 * window.c (replace_window): Rename second argument REPLACEMENT to
10654 NEW. New third argument SETFLAG. Rewrite.
10655 (delete_window, make_dummy_parent): Call replace_window with
10657 (window_list_1): Move down in code.
10658 (run_window_configuration_change_hook): Move set_buffer part
10659 before select_frame_norecord part in order to unwind correctly.
10660 Rename count1 to count.
10661 (recombine_windows, delete_deletable_window, resize_root_window)
10662 (Fdelete_other_windows_internal)
10663 (Frun_window_configuration_change_hook, make_parent_window)
10664 (resize_window_check, resize_window_apply, Fresize_window_apply)
10665 (resize_frame_windows, Fsplit_window_internal)
10666 (Fdelete_window_internal, Fresize_mini_window_internal):
10668 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10670 2011-06-08 Martin Rudalics <rudalics@gmx.at>
10672 * window.h (window): Add some new members to window structure -
10673 normal_lines, normal_cols, new_total, new_normal, clone_number,
10674 splits, nest, prev_buffers, next_buffers.
10675 (WINDOW_TOTAL_SIZE): Move here from window.c.
10676 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
10678 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10680 (make_dummy_parent): Set new members of windows structure.
10681 (make_window): Move down in code. Handle new members of window
10683 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10684 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10685 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10686 (Fset_window_prev_buffers, Fwindow_next_buffers)
10687 (Fset_window_next_buffers, Fset_window_clone_number):
10689 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10690 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10692 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10693 Argument WINDOW can be now internal window too.
10694 (Fwindow_use_time): Move up in code.
10695 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10696 Rewrite doc-string.
10697 (Fset_window_configuration, saved_window)
10698 (Fcurrent_window_configuration, save_window_save): Handle new
10699 members of window structure.
10700 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10701 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10702 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10703 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10704 Qget_mru_window, Qresize_root_window,
10705 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10706 Qauto_buffer_name; staticpro them.
10708 2011-06-07 Martin Rudalics <rudalics@gmx.at>
10710 * window.c (Fwindow_total_size, Fwindow_left_column)
10711 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10712 (Fwindow_list_1): New functions.
10713 (window_box_text_cols): Replace with window_body_cols.
10714 (Fwindow_width, Fscroll_left, Fscroll_right):
10715 Use window_body_cols instead of window_box_text_cols.
10716 (delete_window, Fset_window_configuration):
10717 Call delete_all_subwindows with window as argument.
10718 (delete_all_subwindows): Take a window as argument and not a
10719 structure. Rewrite.
10720 (window_loop): Remove handling of GET_LRU_WINDOW and
10721 GET_LARGEST_WINDOW.
10722 (Fget_lru_window, Fget_largest_window): Move to window.el.
10724 * window.h: Extern window_body_cols instead of
10725 window_box_text_cols. delete_all_subwindows now takes a
10726 Lisp_Object as argument.
10728 * indent.c (compute_motion, Fcompute_motion):
10729 Use window_body_cols instead of window_box_text_cols.
10731 * frame.c (delete_frame): Call delete_all_subwindows with root
10732 window as argument.
10734 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10736 * fns.c (Fputhash): Document return value.
10738 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
10740 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10742 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10744 Cons<->int and similar integer overflow fixes (Bug#8794).
10746 Check for overflow when converting integer to cons and back.
10747 * charset.c (Fdefine_charset_internal, Fdecode_char):
10748 Use cons_to_unsigned to catch overflow.
10749 (Fencode_char): Use INTEGER_TO_CONS.
10750 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10751 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10752 * data.c (long_to_cons, cons_to_long): Remove.
10753 (cons_to_unsigned, cons_to_signed): New functions.
10754 These signal an error for invalid or out-of-range values.
10755 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10756 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10757 * font.c (Ffont_variation_glyphs):
10758 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10759 * lisp.h: Include <intprops.h>.
10760 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10761 (cons_to_signed, cons_to_unsigned): New decls.
10762 (long_to_cons, cons_to_long): Remove decls.
10763 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10764 (Fprimitive_undo): Use CONS_TO_INTEGER.
10765 * xfns.c (Fx_window_property): Likewise.
10766 * xselect.c: Include <limits.h>.
10767 (x_own_selection, selection_data_to_lisp_data):
10768 Use INTEGER_TO_CONS.
10769 (x_handle_selection_request, x_handle_selection_clear)
10770 (x_get_foreign_selection, Fx_disown_selection_internal)
10771 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10772 (lisp_data_to_selection_data): Use cons_to_unsigned.
10773 (x_fill_property_data): Use cons_to_signed.
10774 Report values out of range.
10776 Check for buffer and string overflow more precisely.
10777 * buffer.h (BUF_BYTES_MAX): New macro.
10778 * lisp.h (STRING_BYTES_MAX): New macro.
10779 * alloc.c (Fmake_string):
10780 * character.c (string_escape_byte8):
10781 * coding.c (coding_alloc_by_realloc):
10782 * doprnt.c (doprnt):
10783 * editfns.c (Fformat):
10785 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10786 since they may not be the same number.
10787 * editfns.c (Finsert_char):
10788 * fileio.c (Finsert_file_contents):
10789 Likewise for BUF_BYTES_MAX.
10791 * image.c: Use ptrdiff_t, not int, for sizes.
10792 (slurp_file): Switch from int to ptrdiff_t.
10794 (slurp_file): Check that file size fits in both size_t (for
10795 malloc) and ptrdiff_t (for sanity and safety).
10797 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10798 if b->modtime has its maximal value.
10800 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10802 Don't assume time_t can fit into int.
10803 * buffer.h (struct buffer.modtime): Now time_t, not int.
10804 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10805 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10807 Minor fixes for signed vs unsigned integers.
10808 * character.h (MAYBE_UNIFY_CHAR):
10809 * charset.c (maybe_unify_char):
10810 * keyboard.c (read_char, reorder_modifiers):
10811 XINT -> XFASTINT, since the integer must be nonnegative.
10812 * ftfont.c (ftfont_spec_pattern):
10813 * keymap.c (access_keymap, silly_event_symbol_error):
10814 XUINT -> XFASTINT, since the integer must be nonnegative.
10815 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10816 since it makes no difference and we prefer signed.
10817 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10818 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10821 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10823 * window.h (Fwindow_frame): Declare.
10825 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10827 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10828 (SPARE_MEMORY): Always define.
10829 (LARGE_REQUEST): Remove.
10830 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10832 2011-06-06 Martin Rudalics <rudalics@gmx.at>
10834 * lisp.h: Move EXFUNS for Fframe_root_window,
10835 Fframe_first_window and Fset_frame_selected_window to window.h.
10837 * window.h: Move EXFUNS for Fframe_root_window,
10838 Fframe_first_window and Fset_frame_selected_window here from
10841 * frame.c (Fwindow_frame, Fframe_first_window)
10842 (Fframe_root_window, Fframe_selected_window)
10843 (Fset_frame_selected_window): Move to window.c.
10844 (Factive_minibuffer_window): Move to minibuf.c.
10845 (Fother_visible_frames_p): New function.
10847 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10849 * window.c (decode_window, decode_any_window): Move up in code.
10850 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10851 (inhibit_frame_unsplittable): Remove unused variable.
10852 (Fwindow_buffer): Move up and rewrite doc-string.
10853 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10854 (Fwindow_prev): New functions.
10855 (Fwindow_frame): Move here from frame.c. Accept any window as
10857 (Fframe_root_window, Fframe_first_window)
10858 (Fframe_selected_window): Move here from frame.c. Accept frame
10859 or arbitrary window as argument. Update doc-strings.
10860 (Fminibuffer_window): Move up in code.
10861 (Fwindow_minibuffer_p): Move up in code and simplify.
10862 (Fset_frame_selected_window): Move here from frame.c.
10864 (Fselected_window, select_window, Fselect_window): Move up in
10865 code. Minor doc-string fixes.
10867 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10869 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10870 Do not assume that spare memory exists; that assumption is valid
10871 only if SYSTEM_MALLOC.
10872 (LARGE_REQUEST): New macro, so that the issue of large requests
10873 is separated from the issue of spare memory.
10875 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10877 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10880 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10882 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10885 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10887 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10889 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10891 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10892 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10894 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
10896 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10898 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
10900 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10901 (x_clipboard_manager_save): Add return value.
10902 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10903 New error handlers.
10904 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10905 Obey Vx_select_enable_clipboard_manager. Catch errors in
10906 x_clipboard_manager_save (Bug#8779).
10907 (Vx_select_enable_clipboard_manager): New variable.
10908 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
10910 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
10912 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10914 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10916 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10917 in the current matrix if keep_current_p is non-zero.
10919 2011-06-04 Eli Zaretskii <eliz@gnu.org>
10921 * bidi.c (bidi_level_of_next_char): Fix last change.
10923 2011-06-03 Eli Zaretskii <eliz@gnu.org>
10925 Support bidi reordering of text covered by display properties.
10927 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10928 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10929 (bidi_cache_search, bidi_cache_iterator_state)
10930 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
10931 (bidi_level_of_next_char, bidi_move_to_visually_next):
10932 Support character positions inside a run of characters covered by a
10934 (bidi_paragraph_init, bidi_resolve_explicit_1)
10935 (bidi_level_of_next_char): Call bidi_fetch_char and
10936 bidi_fetch_char_advance instead of FETCH_CHAR and
10937 FETCH_CHAR_ADVANCE.
10938 (bidi_init_it): Initialize new members.
10939 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10941 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10942 instead of using explicit *_CHAR codes.
10943 (bidi_resolve_explicit, bidi_resolve_weak):
10944 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
10945 bidirectional text is supported only in multibyte buffers.
10946 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10947 it to initialize the frame_window_p member of struct bidi_it.
10948 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10949 (bidi_resolve_explicit, bidi_resolve_weak)
10950 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10951 bidi_it->nchars is non-positive.
10952 (bidi_level_of_next_char): Don't try to lookup the cache for the
10953 next/previous character if nothing is cached there yet, or if we
10954 were just reseat()'ed to a new position.
10956 * xdisp.c (set_cursor_from_row): Set start and stop points
10957 according to the row's direction when priming the loop that looks
10958 for the glyph on which to display cursor.
10959 (single_display_spec_intangible_p): Function deleted.
10960 (display_prop_intangible_p): Reimplement to call
10961 handle_display_spec instead of single_display_spec_intangible_p.
10962 Accept 3 additional arguments needed by handle_display_spec.
10963 This fixes incorrect cursor motion across display property with complex
10964 values: lists, `(when COND...)' forms, etc.
10965 (single_display_spec_string_p): Support property values that are
10966 lists with the argument STRING its top-level element.
10967 (display_prop_string_p): Fix the condition for processing a
10968 property that is a list to be consistent with handle_display_spec.
10969 (handle_display_spec): New function, refactored from the
10970 last portion of handle_display_prop.
10971 (compute_display_string_pos): Accept additional argument
10972 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10973 value of a `display' property is a "replacing spec".
10974 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10975 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10976 the display property, but just return a value indicating whether
10977 the display property will replace the characters it covers.
10978 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10979 frame_window_p members of struct bidi_it.
10980 (compute_display_string_pos, compute_display_string_end):
10982 (push_it): Accept second argument POSITION, where pop_it should
10983 jump to continue iteration.
10984 (reseat_1): Initialize bidi_it.disp_pos.
10986 * keyboard.c (adjust_point_for_property): Adjust the call to
10987 display_prop_intangible_p to its new signature.
10989 * dispextern.h (struct bidi_it): New member frame_window_p.
10990 (bidi_init_it): Update prototypes.
10991 (display_prop_intangible_p): Update prototype.
10992 (compute_display_string_pos, compute_display_string_end):
10993 Declare prototypes.
10994 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10997 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
10999 Malloc failure behavior now depends on size of allocation.
11000 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
11001 * lisp.h: Change signatures accordingly.
11002 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
11003 All callers changed. (Bug#8762)
11005 * gnutls.c: Use Emacs's memory allocators.
11006 Without this change, the gnutls library would invoke malloc etc.
11007 directly, which causes problems on non-SYNC_INPUT hosts, and which
11008 runs afoul of improving memory_full behavior. (Bug#8761)
11009 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
11010 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
11011 xfree instead of the default malloc, realloc, free.
11012 (Fgnutls_boot): No need to check for memory allocation failure,
11013 since xmalloc does that for us.
11015 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
11016 * category.c (hash_get_category_set):
11017 * ccl.c (ccl_driver):
11018 * charset.c (Fdefine_charset_internal):
11019 * charset.h (struct charset.hash_index):
11020 * composite.c (get_composition_id, gstring_lookup_cache)
11021 (composition_gstring_put_cache):
11022 * composite.h (struct composition.hash_index):
11023 * dispextern.h (struct image.hash):
11024 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
11025 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
11026 (hashfn_equal, hashfn_user_defined, make_hash_table)
11027 (maybe_resize_hash_table, hash_lookup, hash_put)
11028 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11029 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11030 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11031 * image.c (make_image, search_image_cache, lookup_image)
11032 (xpm_put_color_table_h):
11033 * lisp.h (struct Lisp_Hash_Table):
11034 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
11035 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
11036 for hashes and hash indexes, instead of 'unsigned' and 'int'.
11037 * alloc.c (allocate_vectorlike):
11038 Check for overflow in vector size calculations.
11039 * ccl.c (ccl_driver):
11040 Check for overflow when converting EMACS_INT to int.
11041 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11042 need to be updated by these changes.
11043 * fns.c (make_hash_table, maybe_resize_hash_table):
11044 Check for integer overflow with large hash tables.
11045 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11046 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11047 (SXHASH_REDUCE): New macro.
11048 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11049 Use it instead of discarding useful hash info with large hash values.
11050 (sxhash_float): New function.
11051 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11052 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
11053 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11054 Rewrite to use FIXNUM_BITS, as this simplifies things.
11055 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11056 Adjust signatures to match updated version of code.
11057 (consing_since_gc): Now EMACS_INT, since a single hash table can
11058 use more than INT_MAX bytes.
11060 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11062 Make it possible to build with GCC-4.6+ -O2 -flto.
11064 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11066 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11068 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11069 Call minibuffer-inactive-mode.
11071 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
11073 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11074 Update dependencies.
11076 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11078 * data.c (init_data): Remove code for UTS, this system is not
11081 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11083 Don't force ./temacs to start in terminal mode.
11085 * frame.c (make_initial_frame): Initialize faces in all cases, not
11086 only when CANNOT_DUMP is defined.
11087 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11089 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11091 * dispnew.c (add_window_display_history): Use const for the string
11092 pointer. Remove declaration, not needed.
11094 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11096 Use 'inline', not 'INLINE'.
11097 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
11098 * alloc.c, fontset.c (INLINE): Remove.
11099 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11100 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11101 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11102 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11103 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11105 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11107 Make it possible to run ./temacs.
11109 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11110 syms_of_callproc does the same thing. Remove test for
11111 "initialized", do it in the caller.
11112 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11114 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11116 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11117 (read_minibuf): Use get_minibuffer.
11118 (syms_of_minibuf): Use DEFSYM.
11119 (Qmetadata): New var.
11120 * data.c (Qbuffer): Don't make it static.
11121 (syms_of_data): Use DEFSYM.
11123 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11125 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11126 (CCL_CODE_MIN): New macro.
11128 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11130 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11132 * eval.c (Qdebug): Now static.
11133 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11134 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11135 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11137 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
11139 * image.c: Various fixes to ImageMagick code comments.
11140 (Fimagemagick_types): Doc fix.
11142 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11144 Minor fixes prompted by GCC 4.6.0 warnings.
11146 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11148 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11149 (x_clipboard_manager_save_all): Move extern decl to ...
11150 * xterm.h: ... here, so that it can be checked for consistency.
11152 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
11154 * xselect.c (x_clipboard_manager_save_frame)
11155 (x_clipboard_manager_save_all): New functions.
11156 (Fx_clipboard_manager_save): Lisp function deleted.
11158 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11159 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11161 * xterm.h: Update prototype.
11163 2011-05-28 William Xu <william.xwl@gmail.com>
11165 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11166 exiting (Bug#8239).
11168 2011-05-28 Jim Meyering <meyering@redhat.com>
11170 Avoid a sign-extension bug in crypto_hash_function.
11171 * fns.c (to_uchar): Define.
11172 (crypto_hash_function): Use it to convert some newly-signed
11173 variables to unsigned, to avoid sign-extension bugs. For example,
11174 without this change, (md5 "truc") would evaluate to
11175 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11176 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
11177 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
11179 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11181 Integer overflow fixes.
11183 * dbusbind.c: Serial number integer overflow fixes.
11184 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
11185 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11186 to hold a serial number that is too large for a fixnum.
11187 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11188 Check for serial numbers out of range. Decode any serial number
11189 that was so large that it became a float. (Bug#8722)
11191 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11192 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11193 Use XFASTINT rather than XUINT when numbers are nonnegative.
11194 (xd_append_arg, Fdbus_method_return_internal):
11195 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11196 arguments, check that Lisp number is nonnegative, rather than
11197 silently wrapping negative numbers around. (Bug#8722)
11198 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
11201 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11203 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11205 ccl: Add integer overflow checks.
11206 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11207 (IN_INT_RANGE): New macros.
11208 (ccl_driver): Use them to check for integer overflow when
11209 decoding a CCL program. Many of the new checks are whether XINT (x)
11210 fits in int; it doesn't always, on 64-bit hosts. The new version
11211 doesn't catch all possible integer overflows, but it's an
11212 improvement. (Bug#8719)
11214 * alloc.c (make_event_array): Use XINT, not XUINT.
11215 There's no need for unsigned here.
11217 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11218 This follows up to the 2011-05-06 change that substituted uintptr_t
11219 for EMACS_INT. This case wasn't caught back then.
11221 Rework Fformat to avoid integer overflow issues.
11222 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11223 now (part of C89). Include <verify.h>.
11224 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11225 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11226 (Fformat): Avoid the prepass trying to compute sizes; it was only
11227 approximate and thus did not catch overflow reliably. Instead, walk
11228 through the format just once, formatting and computing sizes as we go,
11229 checking for integer overflow at every step, and allocating a larger
11230 buffer as needed. Keep track separately whether the format is
11231 multibyte. Keep only the most-recently calculated precision, rather
11232 than them all. Record whether each argument has been converted to
11233 string. Use EMACS_INT, not int, for byte and char and arg counts.
11234 Support field widths and precisions larger than INT_MAX. Avoid
11235 sprintf's undefined behavior with conversion specifications such as %#d
11236 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11237 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11238 formatting out-of-range floating point numbers with int
11239 formats. (Bug#8668)
11241 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11243 * data.c: Avoid integer truncation in expressions involving floats.
11244 * data.c: Include <intprops.h>.
11245 (arith_driver): When there's an integer overflow in an expression
11246 involving floating point, convert the integers to floating point
11247 so that the resulting value does not suffer from catastrophic
11248 integer truncation. For example, on a 64-bit host (* 4
11249 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11250 Do not rely on undefined behavior after integer overflow.
11252 merge count_size_as_multibyte, parse_str_to_multibyte
11253 * character.c, character.h (count_size_as_multibyte):
11254 Rename from parse_str_to_multibyte; all uses changed.
11255 Check for integer overflow.
11256 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11257 since it's now a duplicate of the other. This is more of
11258 a character than a buffer op, so better that it's in character.c.
11259 * fns.c, print.c: Adjust to above changes.
11261 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11263 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11265 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11267 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11268 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11269 (x_clipboard_manager_save): Now static.
11270 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11272 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11273 (crypto_hash_function): Now static.
11274 Fix pointer signedness problems. Avoid unnecessary initializations.
11276 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
11278 * termhooks.h (Vselection_alist): Make it terminal-local.
11280 * terminal.c (create_terminal): Initialize it.
11282 * xselect.c: Support for clipboard managers.
11283 (Vselection_alist): Move to termhooks.h as terminal-local var.
11284 (LOCAL_SELECTION): New macro.
11285 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11286 (symbol_to_x_atom): Remove gratuitous arg.
11287 (x_handle_selection_request, lisp_data_to_selection_data)
11288 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
11289 (x_own_selection, x_get_local_selection, x_convert_selection):
11290 New arg, specifying work frame. Use terminal-local Vselection_alist.
11291 (some_frame_on_display): Delete unused function.
11292 (Fx_own_selection_internal, Fx_get_selection_internal)
11293 (Fx_disown_selection_internal, Fx_selection_owner_p)
11294 (Fx_selection_exists_p): New optional frame arg.
11295 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11296 (x_handle_selection_clear): Don't treat other terminals with the
11297 same keyboard specially. Use the terminal-local Vselection_alist.
11298 (x_clear_frame_selections): Use Frun_hook_with_args.
11300 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11302 * xterm.h: Add support for those atoms.
11304 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
11306 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11307 (converted_selections, conversion_fail_tag): New global variables.
11308 (x_selection_request_lisp_error): Free the above.
11309 (x_get_local_selection): Remove unnecessary code.
11310 (x_reply_selection_request): Args changed; handle arbitrary array
11311 of converted selections stored in converted_selections.
11312 Separate the XChangeProperty and SelectionNotify steps.
11313 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11314 (x_convert_selection): New function.
11315 (x_handle_selection_event): Simplify.
11316 (x_get_foreign_selection): Don't ignore incoming requests while
11317 waiting for an answer; this will fail when we implement
11318 SAVE_TARGETS, and seems unnecessary anyway.
11319 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11320 (Vx_sent_selection_functions): Doc fix.
11322 2011-05-26 Leo Liu <sdl.web@gmail.com>
11324 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11326 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11328 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11330 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11331 for fringe update if it has periodic bitmap.
11332 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
11333 and fringe_bitmap_periodic_p.
11335 * fringe.c (get_fringe_bitmap_data): New function.
11336 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11337 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11338 row. Mark glyph row for fringe update if periodicity changed.
11340 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11341 for fringe update unless it has periodic bitmap.
11343 2011-05-25 Kenichi Handa <handa@m17n.org>
11345 * xdisp.c (get_next_display_element): Set correct it->face_id for
11346 a static composition.
11348 2011-05-24 Leo Liu <sdl.web@gmail.com>
11351 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11353 * fns.c (crypto_hash_function, Fsha1): New function.
11354 (Fmd5): Use crypto_hash_function.
11355 (syms_of_fns): Add Ssha1.
11357 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11359 * gnutls.c: Remove unused macros.
11360 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11361 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11362 Remove macros that are defined and never used.
11363 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11365 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
11367 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11368 (Fx_get_selection_internal): Minor cleanup.
11369 (Fx_own_selection_internal): Rename arguments for consistency with
11372 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11374 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11376 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
11378 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11380 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11382 * dispnew.c (scrolling_window): Don't exclude the case that the
11383 last enabled row in the desired matrix touches the bottom boundary.
11385 2011-05-21 Glenn Morris <rgm@gnu.org>
11387 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
11388 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11389 and add some more files.
11391 2011-05-20 Eli Zaretskii <eliz@gnu.org>
11393 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11394 report_file_error introduced by the change from 2011-05-07.
11396 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11398 * systime.h (Time): Define only if emacs is defined.
11399 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11400 where the include path doesn't have X11/X.h by default. See
11401 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11403 2011-05-20 Kenichi Handa <handa@m17n.org>
11405 * composite.c (find_automatic_composition): Fix previous change.
11407 2011-05-20 Glenn Morris <rgm@gnu.org>
11409 * lisp.mk: New file, split from Makefile.in.
11410 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11411 (shortlisp): Remove.
11412 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11414 2011-05-19 Glenn Morris <rgm@gnu.org>
11416 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11417 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11418 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11419 (lisp): Set the order to that of loadup.el.
11420 (shortlisp): Make it a copy of $lisp.
11421 (SOME_MACHINE_LISP): Remove.
11422 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11423 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11425 2011-05-18 Kenichi Handa <handa@m17n.org>
11427 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11428 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11429 (find_automatic_composition): Mostly rewrite for efficiency.
11431 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
11433 * makefile.w32-in: Update dependencies.
11435 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11437 * menu.c: Include limits.h (fixes the MS-Windows build broken by
11438 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
11440 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
11442 Fix some integer overflow issues, such as string length overflow.
11444 * insdel.c (count_size_as_multibyte): Check for string overflow.
11446 * character.c (lisp_string_width): Check for string overflow.
11447 Use EMACS_INT, not int, for string indexes and lengths; in
11448 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11449 the resulting string length overflows an EMACS_INT; instead,
11450 report a string overflow if no precision given. When checking for
11451 precision exhaustion, use a check that cannot possibly have
11452 integer overflow. (Bug#8675)
11453 * character.h (lisp_string_width): Adjust to new signature.
11455 * alloc.c (string_overflow): New function.
11456 (Fmake_string): Use it. This doesn't change behavior, but saves
11457 a few bytes and will simplify future changes.
11458 * character.c (string_escape_byte8): Likewise.
11459 * lisp.h (string_overflow): New decl.
11461 Fixups, following up to the user-interface timestamp change.
11462 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11463 for UI timestamps, instead of unsigned long.
11464 * msdos.c (mouse_get_pos): Likewise.
11465 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
11466 * w32gui.h (Time): Define by including "systime.h" rather than by
11467 declaring it ourselves. (Bug#8664)
11469 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11470 * image.c (clear_image_cache): Likewise.
11472 * term.c (term_mouse_position): Don't assume time_t wraparound.
11474 Be more systematic about user-interface timestamps.
11475 Before, the code sometimes used 'Time', sometimes 'unsigned long',
11476 and sometimes 'EMACS_UINT', to represent these timestamps.
11477 This change causes it to use 'Time' uniformly, as that's what X uses.
11478 This makes the code easier to follow, and makes it easier to catch
11479 integer overflow bugs such as Bug#8664.
11480 * frame.c (Fmouse_position, Fmouse_pixel_position):
11481 Use Time, not unsigned long, for user-interface timestamps.
11482 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11483 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11484 * keyboard.h (last_event_timestamp): Likewise.
11485 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11486 * menu.h (xmenu_show): Likewise.
11487 * term.c (term_mouse_position): Likewise.
11488 * termhooks.h (struct input_event.timestamp): Likewise.
11489 (struct terminal.mouse_position_hook): Likewise.
11490 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11491 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11492 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11493 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11494 what it was before.
11495 * menu.h, termhooks.h: Include "systime.h", for Time.
11497 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11498 Don't assume that the difference between two unsigned long values
11499 can fit into an integer. At this point, we know button_down_time
11500 <= event->timestamp, so the difference must be nonnegative, so
11501 there's no need to cast the result if double-click-time is
11502 nonnegative, as it should be; check that it's nonnegative, just in
11503 case. This bug is triggered when events are more than 2**31 ms
11504 apart (about 25 days). (Bug#8664)
11506 * xselect.c (last_event_timestamp): Remove duplicate decl.
11507 (x_own_selection): Remove needless cast to unsigned long.
11509 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11510 that always fit in int. Use a sentinel instead of a counter, to
11511 avoid a temp and to allay GCC's concerns about possible int overflow.
11512 * frame.h (struct frame): Use int for menu_bar_items_used
11513 instead of EMACS_INT, since it always fits in int.
11515 * menu.c (grow_menu_items): Check for int overflow.
11517 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11519 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11520 Before, the code was not consistent. These values cannot exceed
11521 2**31 - 1 so there's no need to make them unsigned.
11522 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11523 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11524 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11526 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11528 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11529 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11530 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11531 presumably because the widths might not match.
11533 * window.c (size_window): Avoid needless test at loop start.
11535 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11537 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11539 2011-05-12 Drew Adams <drew.adams@oracle.com>
11541 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11543 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11545 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11546 `width' to `bar_area_x' and `bar_area_width', respectively.
11547 (x_scroll_run): Take account of fringe background extension.
11549 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11550 Rename local vars `left' and `width' to `bar_area_x' and
11551 `bar_area_width', respectively.
11552 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11553 background extension.
11555 2011-05-10 Jim Meyering <meyering@redhat.com>
11557 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11559 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
11561 * image.c (Finit_image_library): Return t for built-in image types,
11562 like pbm and xbm. (Bug#8640)
11564 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11566 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11568 2011-05-07 Eli Zaretskii <eliz@gnu.org>
11570 * w32console.c (Fset_screen_color): Doc fix.
11571 (Fget_screen_color): New function.
11572 (syms_of_ntterm): Defsubr it.
11574 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11575 unlink the temporary file if Fcall_process didn't create it in the
11577 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11578 child process will be redirected to a file specified with `:file'.
11579 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11580 cue to call_process_cleanup not to close that handle.
11582 2011-05-07 Ben Key <bkey76@gmail.com>
11584 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11585 one of two shell specific rules, either bootstrap-temacs-CMD or
11586 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11587 to the previous implementation of the bootstrap-temacs rule.
11588 The bootstrap-temacs-CMD rule is similar to the previous
11589 implementation of the bootstrap-temacs rule except that it
11590 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11593 These changes, along with some changes to nt/configure.bat,
11594 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11595 earlier fix to add support for --cflags and --ldflags options
11596 that include quotes so that it works whether make uses cmd or
11599 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
11601 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11602 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11604 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11605 a string. Handle both cases.
11606 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11607 (Fdbus_register_method): Use Qinvalid_function.
11609 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
11611 * makefile.w32-in: Update dependencies.
11612 (LISP_H): Add inttypes.h and stdin.h.
11613 (PROCESS_H): Add unistd.h.
11615 2011-05-06 Eli Zaretskii <eliz@gnu.org>
11617 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11618 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11620 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
11622 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11624 * term.c (vfatal): Remove stray call to va_end.
11625 It's not needed and the C Standard doesn't allow it here anyway.
11627 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11628 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11630 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11633 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11635 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11637 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11639 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11641 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11643 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11644 * charset.c (Fdefine_charset_internal): Don't initialize
11645 charset.code_space[15]. The value was garbage, on hosts with
11646 32-bit int (Bug#8600).
11648 * lread.c (read_integer): Be more consistent with string-to-number.
11649 Use string_to_number to do the actual conversion; this avoids
11650 rounding errors and fixes some other screwups. Without this fix,
11651 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11652 (digit_to_number): Move earlier, for benefit of read_integer.
11653 Return -1 if the digit is out of range for the base, -2 if it is
11654 not a digit in any supported base. (Bug#8602)
11656 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11658 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11659 to match comment at start of function. This also removes a
11660 GCC warning about overflow in a 32+64-bit port.
11662 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11664 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11665 Reported by Stefan Monnier in
11666 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
11667 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11668 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
11670 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11671 (EMACS_UINTPTR): Likewise, with uintptr_t.
11673 * lisp.h: Prefer 64-bit EMACS_INT if available.
11674 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11675 on 32-bit hosts that have 64-bit int, so that they can access
11677 However, temporarily disable this change unless the temporary
11678 symbol WIDE_EMACS_INT is defined.
11680 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11682 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11683 This removes an assumption that EMACS_INT and long are the same
11684 width as pointers. The assumption is true for Emacs porting targets
11685 now, but we want to make other targets possible.
11686 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11687 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11688 In the rest of the code, change types of integers that hold casted
11689 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11690 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11691 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11692 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11693 No need to cast type when ORing.
11694 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11695 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11696 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11697 assume EMACS_INT is the same width as char *.
11698 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11699 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11700 Remove no-longer-needed casts.
11701 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11702 (xg_tool_bar_help_callback, xg_make_tool_item):
11703 Use EMACS_INTPTR to hold an integer
11704 that will be cast to void *; this can avoid a GCC warning
11705 if EMACS_INT is not the same width as void *.
11706 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11707 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11708 (current_message_1, set_message_1):
11709 Use a local to convert to proper width without a cast.
11710 * xmenu.c (dialog_selection_callback): Likewise.
11712 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11713 Also, don't assume VALBITS / RAND_BITS is less than 5,
11714 and don't rely on undefined behavior when shifting a 1 left into
11716 * lisp.h (get_random): Change signature to match.
11718 * lread.c (hash_string): Use size_t, not int, for hash computation.
11719 Normally we prefer signed values; but hashing is special, because
11720 it's better to use unsigned division on hash table sizes so that
11721 the remainder is nonnegative. Also, size_t is the natural width
11722 for hashing into memory. The previous code used 'int', which doesn't
11723 retain enough info to hash well into very large tables.
11724 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11726 * dbusbind.c: Don't possibly lose pointer info when converting.
11727 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11728 Use XPNTR rather than XHASH, so that the high-order bits of
11729 the pointer aren't lost when converting through void *.
11731 * eval.c (Fautoload): Don't double-shift a pointer.
11733 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11735 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
11737 * gnutls.c (DEF_GNUTLS_FN):
11738 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11740 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11742 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11745 2011-05-05 Eli Zaretskii <eliz@gnu.org>
11747 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11748 New version that can reserve upto 2GB of heap space.
11750 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
11752 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11754 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11756 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11757 `gnutls_certificate_set_x509_key_file'.
11759 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
11761 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11762 Update dependencies.
11764 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11766 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11767 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11768 Remove unused parameter `fildes'.
11769 * process.c (read_process_output, send_process): Don't pass it.
11771 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11773 Fix previous change: the library cache is defined in w32.c.
11774 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11775 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11777 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11779 Implement dynamic loading of GnuTLS on Windows.
11781 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11782 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11783 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11786 * gnutls.c (Qgnutls_dll): Define.
11787 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11788 (gnutls_*): Declare function pointers.
11789 (init_gnutls_functions): New function to initialize function pointers.
11790 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11791 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11792 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11793 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11794 (emacs_gnutls_write, emacs_gnutls_read)
11795 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11796 (Fgnutls_available_p): New function.
11797 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11798 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11799 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11801 * image.c: Include w32.h.
11802 (Vimage_type_cache): Delete.
11803 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11804 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11805 (w32_delayed_load): Move to w32.c.
11807 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11809 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11810 (w32_delayed_load): Move from image.c. When loading a library, record
11811 its filename in the :loaded-from property of the library id.
11812 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11813 Initialize and staticpro them.
11814 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11816 * process.c: Include lisp.h before w32.h, not after.
11817 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11818 instead of gnutls_record_check_pending.
11820 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11822 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11824 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11825 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11828 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11830 * xterm.c (x_set_frame_alpha): Do not set property on anything
11831 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11833 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11835 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11837 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11839 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11840 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11841 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11842 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11843 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11844 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11845 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11846 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11847 (Qgnutls_bootprop_callbacks_verify): Make static.
11849 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11851 * callproc.c: Indentation fixup.
11853 * sysdep.c (wait_for_termination_1): Make static.
11854 (wait_for_termination, interruptible_wait_for_termination):
11855 Move after wait_for_termination_1.
11857 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11859 * sysdep.c (interruptible_wait_for_termination): New function
11860 which is like wait_for_termination, but allows keyboard
11863 * callproc.c (Fcall_process): Add (:file "file") as an option for
11865 (Fcall_process_region): Ditto.
11867 2011-04-30 Eli Zaretskii <eliz@gnu.org>
11869 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11870 rather than `XVECTOR (FOO)->size'.
11872 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11873 inttypes.h, as a gnulib replacement is used if it not available in
11876 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11878 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11879 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11880 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11882 * coding.c (coding_alloc_by_realloc): Error out if destination
11883 will grow beyond MOST_POSITIVE_FIXNUM.
11884 (decode_coding_emacs_mule): Abort if there isn't enough place in
11885 charbuf for the composition carryover bytes. Reserve an extra
11886 space for up to 2 characters produced in a loop.
11887 (decode_coding_iso_2022): Abort if there isn't enough place in
11888 charbuf for the composition carryover bytes.
11890 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11892 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11893 aborting when %lld or %lll format is passed.
11894 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11895 %llo or %llx format is passed. (Bug#8545)
11897 * window.c (window_scroll_line_based): Use a marker instead of
11898 simple variables to record original value of point. (Bug#7952)
11900 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11901 produced by %s or %c overflows available buffer space. (Bug#8545)
11903 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11905 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
11906 (SIZE_MAX): Move defn after all includes, as they might #define it.
11908 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11910 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11912 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11914 * keyboard.c (Qdelayed_warnings_hook): Define.
11915 (command_loop_1): Run `delayed-warnings-hook'
11916 if Vdelayed_warnings_list is non-nil.
11917 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11918 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11920 2011-04-28 Eli Zaretskii <eliz@gnu.org>
11922 * doprnt.c (doprnt): Don't return value smaller than the buffer
11923 size if the message was truncated. (Bug#8545).
11925 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11927 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11928 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11930 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11932 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11934 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
11936 * makefile.w32-in: Update dependencies.
11938 2011-04-27 Eli Zaretskii <eliz@gnu.org>
11940 Improve `doprnt' and its usage. (Bug#8545)
11941 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11942 `format_end'. Remove support for %l as a conversion specifier.
11943 Don't use xrealloc. Improve diagnostics when the %l size modifier
11944 is used. Update the commentary.
11946 * eval.c (verror): Simplify calculation of size_t.
11948 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11951 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11953 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11956 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11958 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11959 This makes this file independent of the recent pseudovector change.
11961 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
11963 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11965 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
11966 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
11967 Remove unused local.
11968 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
11970 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
11971 GCC 4.6.0 optimizes based on type-based alias analysis.
11972 For example, if b is of type struct buffer * and v of type struct
11973 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11974 != &v->size, and therefore "v->size = 1; b->size = 2; return
11975 v->size;" must therefore return 1. This assumption is incorrect
11976 for Emacs, since it type-puns struct Lisp_Vector * with many other
11977 types. To fix this problem, this patch adds a new type struct
11978 vectorlike_header that documents the constraints on layout of vectors
11979 and pseudovectors, and helps optimizing compilers not get fooled
11980 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11981 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
11982 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11984 (XSETPVECTYPE): Rewrite in terms of new macro.
11985 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11986 This is a bit clearer, and further avoids the possibility of
11987 undesirable aliasing.
11988 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
11989 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
11990 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11991 since Lisp_Subr is a special case (no "next" field).
11992 (ASIZE): Now uses header.size rather than size.
11993 All previous uses of XVECTOR (foo)->size replaced to use this macro,
11994 to avoid the hassle of writing XVECTOR (foo)->header.size.
11995 (struct vectorlike_header): New type.
11996 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11997 object, to help avoid aliasing.
11998 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11999 (SUBRP): Likewise, since Lisp_Subr is a special case.
12000 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
12001 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
12002 (struct Lisp_Hash_Table): Combine first two members into a single
12003 struct vectorlike_header member. All uses of "size" and "next" members
12004 changed to be "header.size" and "header.next".
12005 * buffer.h (struct buffer): Likewise.
12006 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
12007 * frame.h (struct frame): Likewise.
12008 * process.h (struct Lisp_Process): Likewise.
12009 * termhooks.h (struct terminal): Likewise.
12010 * window.c (struct save_window_data, struct saved_window): Likewise.
12011 * window.h (struct window): Likewise.
12012 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
12013 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
12014 * buffer.c (init_buffer_once): Likewise.
12015 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
12017 * process.c (Fformat_network_address): Use local var for size,
12020 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
12022 Make the Lisp reader and string-to-float more consistent (Bug#8525)
12023 * data.c (atof): Remove decl; no longer used or needed.
12024 (digit_to_number): Move to lread.c.
12025 (Fstring_to_number): Use new string_to_number function, to be
12026 consistent with how the Lisp reader treats infinities and NaNs.
12027 Do not assume that floating-point numbers represent EMACS_INT
12028 without losing information; this is not true on most 64-bit hosts.
12029 Avoid double-rounding errors, by insisting on integers when
12030 parsing non-base-10 numbers, as the documentation specifies.
12031 * lisp.h (string_to_number): New decl, replacing ...
12032 (isfloat_string): Remove.
12033 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
12034 (read1): Do not accept +. and -. as integers; this
12035 appears to have been a coding error. Similarly, do not accept
12036 strings like +-1e0 as floating point numbers. Do not report
12037 overflow for integer overflows unless the base is not 10 which
12038 means we have no simple and reliable way to continue.
12039 Break out the floating-point parsing into a new
12040 function string_to_number, so that Fstring_to_number parses
12041 floating point numbers consistently with the Lisp reader.
12042 (digit_to_number): Move here from data.c. Make it static inline.
12043 (E_CHAR, EXP_INT): Remove, replacing with ...
12044 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12045 (string_to_number): New function, replacing isfloat_string.
12046 This function checks for valid syntax and produces the resulting
12047 Lisp float number too. Rework it so that string-to-number
12048 no longer mishandles examples like "1.0e+". Use strtoumax,
12049 so that overflow for non-base-10 numbers is reported only when
12050 there's no portable and simple way to convert to floating point.
12052 * textprop.c (set_text_properties_1): Rewrite for clarity,
12053 and to avoid GCC warning about integer overflow.
12055 * intervals.h (struct interval): Use EMACS_INT for members
12056 where EMACS_UINT might cause problems. See
12057 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12058 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12059 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12061 (offset_intervals): Tell GCC not to worry about length overflow
12062 when negating a negative length.
12064 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12065 (overrun_check_free): Likewise.
12067 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12068 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12071 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12072 (gnutls_make_error): Rename local to avoid shadowing.
12073 (gnutls_emacs_global_deinit): ifdef out; not used.
12074 (Fgnutls_boot): Use const for pointer to readonly storage.
12075 Comment out unused local. Fix pointer signedness problems.
12077 * lread.c (openp): Don't stuff size_t into an 'int'.
12078 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12079 about possible signed overflow.
12081 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12082 (GDK_KEY_g): Don't define if already defined.
12083 (xg_prepare_tooltip): Avoid pointer signedness problem.
12084 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12086 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12087 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12089 * xfns.c (Fx_window_property): Simplify a bit,
12090 to make a bit faster and to avoid GCC 4.6.0 warning.
12091 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12093 * fns.c (internal_equal): Don't assume size_t fits in int.
12095 * alloc.c (compact_small_strings): Tighten assertion a little.
12097 Replace pEd with more-general pI, and fix some printf arg casts.
12098 * lisp.h (pI): New macro, generalizing old pEd macro to other
12099 conversion specifiers. For example, use "...%"pI"d..." rather
12100 than "...%"pEd"...".
12101 (pEd): Remove. All uses replaced with similar uses of pI.
12102 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
12103 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12104 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12105 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12106 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12107 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12108 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12110 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12111 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12112 * print.c (safe_debug_print, print_object): Likewise.
12113 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12115 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12116 avoiding the 0 flag, which is not portable.
12117 * process.c (Fmake_network_process): Use pI to avoid cast.
12118 * region-cache.c (pp_cache): Likewise.
12119 * xdisp.c (decode_mode_spec): Likewise.
12120 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12121 behavior on 64-bit hosts with printf arg.
12122 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
12123 (x_stop_queuing_selection_requests): Likewise.
12124 (x_get_window_property): Don't truncate byte count to an 'int'
12127 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12128 here, since it parses constructs like leading '-' and spaces,
12129 which are not wanted; and it overflows with large numbers.
12130 Instead, simply match F[0-9]+, which is what is wanted anyway.
12132 * alloc.c: Remove unportable assumptions about struct layout.
12133 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12134 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12135 (allocate_vectorlike, make_pure_vector): Use the new macros,
12136 plus offsetof, to remove unportable assumptions about struct layout.
12137 These assumptions hold on all porting targets that I know of, but
12138 they are not guaranteed, they're easy to remove, and removing them
12139 makes further changes easier.
12141 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12142 This doesn't fix a bug but makes the code clearer.
12143 (string_overrun_cookie): Now const. Use initializers that
12144 don't formally overflow signed char, to avoid warnings.
12145 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12146 can cause Emacs to crash when string overrun checking is enabled.
12147 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12148 multiple of sizeof (EMACS_INT); it need not be, if
12149 alignof(EMACS_INT) < sizeof (EMACS_INT).
12150 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
12152 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
12154 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12156 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12158 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
12159 supposed to be handshaking. (Bug#8556)
12160 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12162 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
12164 * lisp.h (Qdebug): List symbol.
12165 * eval.c (Qdebug): Restore global linkage.
12166 * keyboard.c (debug-on-event): New variable.
12167 (handle_user_signal): Break into debugger when debug-on-event
12168 matches the current signal symbol.
12170 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12172 * alloc.c (check_sblock, check_string_bytes)
12173 (check_string_free_list): Convert to standard C.
12175 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12177 * w32.c (emacs_gnutls_push): Fix typo.
12179 2011-04-25 Eli Zaretskii <eliz@gnu.org>
12181 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12182 "cast to pointer from integer of different size".
12184 Improve doprnt and its use in verror. (Bug#8545)
12185 * doprnt.c (doprnt): Document the set of format control sequences
12186 supported by the function. Use SAFE_ALLOCA instead of always
12189 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12190 is one byte too soon. Don't use xrealloc; instead xfree and
12193 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12195 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12198 * gnutls.c: Renamed global_initialized to
12199 gnutls_global_initialized. Added internals for the
12200 :verify-hostname-error, :verify-error, and :verify-flags
12201 parameters of `gnutls-boot' and documented those parameters in the
12202 docstring. Start callback support.
12203 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12204 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12205 on error. Return error code.
12206 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12207 (emacs_gnutls_read): Likewise.
12208 (Fgnutls_boot): Return handshake error code.
12209 (emacs_gnutls_handle_error): New function.
12210 (wsaerror_to_errno): Likewise.
12212 * w32.h (emacs_gnutls_pull): Add prototype.
12213 (emacs_gnutls_push): Likewise.
12215 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12216 (emacs_gnutls_push): Likewise.
12218 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12220 * process.c (wait_reading_process_output): Check if GnuTLS
12221 buffered some data internally if no FDs are set for TLS
12224 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12225 (LIBS): Link to USER_LIBS.
12226 ($(BLD)/gnutls.$(0)): New target.
12228 2011-04-24 Eli Zaretskii <eliz@gnu.org>
12230 * xdisp.c (handle_single_display_spec): Rename the
12231 display_replaced_before_p argument into display_replaced_p, to
12232 make it consistent with the commentary. Fix typos in the
12235 * textprop.c (syms_of_textprop): Remove dead code.
12236 (copy_text_properties): Delete obsolete commentary about an
12237 interface that was deleted long ago. Fix typos in the description
12240 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12241 to changes in oldXMenu/XMenu.h from 2011-04-16.
12242 <menu_help_message, prev_menu_help_message>: Constify.
12243 (IT_menu_make_room): menu->help_text is now `const char **';
12246 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12247 to changes in oldXMenu/XMenu.h from 2011-04-16.
12248 (struct XMenu): Declare `help_text' `const char **'.
12250 * xfaces.c <Qunspecified>: Make extern again.
12252 * syntax.c: Include sys/types.h before including regex.h, as
12255 * doc.c (get_doc_string): Improve the format passed to `error'.
12257 * doprnt.c (doprnt): Improve commentary.
12259 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12261 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12264 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12265 changes in globals.h immediately force recompilation.
12266 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12267 $(CURDIR)/s/ms-w32.h.
12268 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
12270 * character.c (Fchar_direction): Function deleted.
12271 (syms_of_character): Don't defsubr it.
12272 <char-direction-table>: Deleted.
12274 2011-04-23 Eli Zaretskii <eliz@gnu.org>
12276 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12277 * doprnt.c: Include limits.h.
12278 (SIZE_MAX): New macro.
12279 (doprnt): Return a size_t value. 2nd arg is now size_t.
12280 Many local variables are now size_t instead of int or unsigned.
12281 Improve overflow protection. Support `l' modifier for integer
12282 conversions. Support %l conversion. Don't assume an EMACS_INT
12283 argument for integer conversions and for %c.
12285 * lisp.h (doprnt): Restore prototype.
12287 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12288 $(SRC)/character.h.
12290 * Makefile.in (base_obj): Add back doprnt.o.
12292 * deps.mk (doprnt.o): Add back prerequisites.
12293 (callint.o): Depend on character.h.
12295 * eval.c (internal_lisp_condition_case): Include the handler
12296 representation in the error message.
12297 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12298 when breaking from the loop.
12300 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12302 * callint.c (Fcall_interactively): When displaying error message
12303 about invalid control letter, pass the character's codepoint, not
12304 a pointer to its multibyte form. Improve display of the character
12305 in octal and display also its hex code.
12307 * character.c (char_string): Use %x to display the (unsigned)
12308 codepoint of an invalid character, to avoid displaying a bogus
12311 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12312 `error', not SYMBOL_NAME itself.
12314 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12315 character arguments to `error'.
12317 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12318 to `error' in error message about FINAL_CHAR argument. Make sure
12319 FINAL_CHAR is a character, and use %c when it is passed as
12320 argument to `error'.
12322 2011-04-23 Eli Zaretskii <eliz@gnu.org>
12324 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12326 * w32.c: Include <time.h>.
12327 (sys_localtime): New function.
12329 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
12331 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12333 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
12335 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
12337 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12338 zombies (Bug#8467).
12340 2011-04-19 Eli Zaretskii <eliz@gnu.org>
12342 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12343 gl_state.e_property when gl_state.object is Qt.
12345 * insdel.c (make_gap_larger): Remove limitation of buffer size
12348 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
12350 * xdisp.c (lookup_glyphless_char_display)
12351 (produce_glyphless_glyph): Handle cons cell entry in
12352 glyphless-char-display.
12353 (Vglyphless_char_display): Document it.
12355 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12356 glyphless-char-display.
12358 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
12360 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12362 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12364 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12365 definition for no-X builds.
12367 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
12369 Static checks with GCC 4.6.0 and non-default toolkits.
12371 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12373 * process.c (keyboard_bit_set): Define only if SIGIO.
12374 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12375 (send_process): Repair possible setjmp clobbering.
12377 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12379 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12381 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12383 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12384 Define only if needed.
12386 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12387 by pacifying GCC about it. Maybe it's time to retire it?
12388 * xfaces.c (USG, __TIMEVAL__): Likewise.
12390 * dispextern.h (struct redisplay_interface): Rename param
12391 to avoid shadowing.
12392 * termhooks.h (struct terminal): Likewise.
12393 * xterm.c (xembed_send_message): Likewise.
12395 * insdel.c (make_gap_smaller): Define only if
12396 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12398 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12401 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12402 so that we aren't warned about unused symbols.
12404 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12406 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
12408 * xfns.c (x_real_positions): Mark locals as initialized.
12410 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12412 * xterm.c: Fix problems found by static analysis with other toolkits.
12413 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
12414 (x_dispatch_event): Declare static if USE_GTK, and
12415 define if USE_GTK || USE_X_TOOLKIT.
12416 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
12417 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
12418 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12419 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
12421 * xmenu.c (menu_help_callback): Pointer type fixes.
12422 Use const pointers when pointing at readonly data. Avoid pointer
12423 signedness clashes.
12424 (FALSE): Remove unused macro.
12425 (update_frame_menubar): Remove unused decl.
12427 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12429 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12430 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12431 (single_menu_item): Rename local to avoid shadowing.
12433 * keyboard.c (make_lispy_event): Remove unused local var.
12435 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12436 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12438 * bitmaps: Change bitmaps from unsigned char back to the X11
12439 compatible char. Avoid the old compiler warnings about
12440 out-of-range initializers by using, for example, '\xab' rather
12443 * xgselect.c (xgselect_initialize): Check vs interface
12444 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12446 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12448 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12449 to read-only memory.
12451 * fns.c (vector): Remove; this old hack is no longer needed.
12453 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
12455 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
12457 * xrdb.c (x_load_resources): Omit unused local.
12459 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
12460 (x_window): Rename locals to avoid shadowing.
12461 (USG): Use the kludged USG macro, to pacify gcc.
12463 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
12464 (x_term_init): Remove local to avoid shadowing.
12466 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
12468 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12469 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12471 2011-04-16 Eli Zaretskii <eliz@gnu.org>
12473 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12475 Fix regex.c, syntax.c and friends for buffers > 2GB.
12476 * syntax.h (struct gl_state_s): Declare character position members
12479 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12481 * textprop.c (verify_interval_modification, interval_of):
12482 Declare arguments EMACS_INT.
12484 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12487 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12489 * indent.c (Fvertical_motion): Local variable it_start is now
12492 * regex.c (re_match, re_match_2, re_match_2_internal)
12493 (bcmp_translate, regcomp, regexec, print_double_string)
12494 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12495 (re_compile_pattern, re_exec): Declare arguments and local
12496 variables `size_t' and `ssize_t' and return values `regoff_t', as
12498 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12499 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12500 <compile_stack_type>: `size' and `avail' are now `size_t'.
12502 * regex.h <regoff_t>: Use ssize_t, not int.
12503 (re_search, re_search_2, re_match, re_match_2): Arguments that
12504 specify buffer/string position and length are now ssize_t and
12505 size_t. Return type is regoff_t.
12507 2011-04-16 Ben Key <bkey76@gmail.com>
12509 * nsfont.m: Fixed bugs in ns_get_family and
12510 ns_descriptor_to_entity that were caused by using free to
12511 deallocate memory blocks that were allocated by xmalloc (via
12512 xstrdup). This caused Emacs to crash when compiled with
12513 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12514 --enable-checking=xmallocoverrun). xfree is now used to
12515 deallocate these memory blocks.
12517 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
12519 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12521 emacs_write: Accept and return EMACS_INT for sizes.
12522 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12524 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12525 Accept and return EMACS_INT.
12526 (emacs_gnutls_write): Return the number of bytes written on
12528 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
12529 (emacs_read, emacs_write): Remove check for negative size, as the
12530 Emacs source code has been audited now.
12531 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12532 (emacs_read, emacs_write): Use it.
12533 * process.c (send_process): Adjust to the new signatures of
12534 emacs_write and emacs_gnutls_write. Do not attempt to store
12535 a byte offset into an 'int'; it might overflow.
12536 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
12538 * sound.c: Don't assume sizes fit in 'int'.
12539 (struct sound_device.period_size, alsa_period_size):
12540 Return EMACS_INT, not int.
12541 (struct sound_device.write, vox_write, alsa_write):
12542 Accept EMACS_INT, not int.
12543 (wav_play, au_play): Use EMACS_INT to store sizes and to
12544 record read return values.
12546 2011-04-15 Ben Key <bkey76@gmail.com>
12548 * keyboard.c (Qundefined): Don't declare static since it is used
12550 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12551 static since they are used in nsfont.m.
12553 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12555 * process.c (Qprocessp): Don't declare static.
12556 * lisp.h (Qprocessp): Declare again.
12558 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
12560 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12562 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12564 Improve C-level modularity by making more things 'static'.
12566 Don't publish debugger-only interfaces to other modules.
12567 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12568 (verify_bytepos, count_markers): Move decls to the only modules
12570 * region-cache.h (pp_cache): Likewise.
12571 * window.h (check_all_windows): Likewise.
12572 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12574 * sysdep.c (croak): Now static, if
12575 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12576 * syssignal.h (croak): Declare only if not static.
12578 * alloc.c (refill_memory_reserve): Now static if
12579 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12580 * lisp.h (refill_memory_reserve): Declare only if not static.
12582 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12583 Define only if USE_LUCID.
12585 * xrdb.c (x_customization_string, x_rm_string): Now static.
12587 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12588 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12590 * xdisp.c (draw_row_with_mouse_face): Now static.
12591 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12593 * window.h (check_all_windows): Mark externally visible.
12595 * window.c (window_deletion_count): Now static.
12597 * undo.c: Make symbols static if they're not exported.
12598 (last_undo_buffer, last_boundary_position, pending_boundary):
12601 * textprop.c (interval_insert_behind_hooks): Now static.
12602 (interval_insert_in_front_hooks): Likewise.
12604 * term.c: Make symbols static if they're not exported.
12605 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12606 (max_frame_lines, tty_set_terminal_modes):
12607 (tty_reset_terminal_modes, tty_turn_off_highlight):
12608 (get_tty_terminal): Now static.
12609 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12610 * termhooks.h (term_mouse_moveto): Do not declare if
12611 HAVE_WINDOW_SYSTEM.
12612 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12613 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12615 * sysdep.c: Make symbols static if they're not exported.
12616 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12618 (sigprocmask_set, full_mask): Remove; unused.
12619 (wait_debugging): Mark as visible.
12620 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12621 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12623 * syntax.c (syntax_temp): Define only if !__GNUC__.
12625 * sound.c (current_sound_device, current_sound): Now static.
12627 * search.c (searchbufs, searchbuf_head): Now static.
12629 * scroll.c (scroll_cost): Remove; unused.
12630 * dispextern.h (scroll_cost): Remove decl.
12632 * region-cache.h (pp_cache): Mark as externally visible.
12634 * process.c: Make symbols static if they're not exported.
12635 (process_tick, update_tick, create_process, chan_process):
12636 (Vprocess_alist, proc_buffered_char, datagram_access):
12637 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12638 (deactivate_process): Mark defn as static, as well as decl.
12639 * lisp.h (create_process): Remove decl.
12640 * process.h (chan_process, Vprocess_alist): Remove decls.
12642 * print.c: Make symbols static if they're not exported.
12643 (print_depth, new_backquote_output, being_printed, print_buffer):
12644 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12645 (print_interval, print_number_index, initial_stderr_stream):
12647 * lisp.h (Fprinc): Remove decl.
12648 (debug_output_compilation_hack): Mark as externally visible.
12650 * sysdep.c (croak): Move decl from here to syssignal.h.
12651 * syssignal.h (croak): Put it here, so the API can be checked when
12652 'croak' is called from dissociate_if_controlling_tty.
12654 * minibuf.c: Make symbols static if they're not exported.
12655 (minibuf_save_list, choose_minibuf_frame): Now static.
12656 * lisp.h (choose_minibuf_frame): Remove decl.
12658 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12660 * lread.c: Make symbols static if they're not exported.
12661 (read_objects, initial_obarray, oblookup_last_bucket_number):
12663 (make_symbol): Remove; unused.
12664 * lisp.h (initial_obarray, make_symbol): Remove decls.
12666 * keyboard.c: Make symbols static if they're not exported.
12667 (single_kboard, recent_keys_index, total_keys, recent_keys):
12668 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12669 (this_single_command_key_start, echoing, last_auto_save):
12670 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12671 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12672 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12673 (Vlispy_mouse_stem, double_click_count):
12675 (force_auto_save_soon): Define only if SIGDANGER.
12676 (ignore_mouse_drag_p): Now static if
12677 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12678 (print_help): Remove; unused.
12679 (stop_character, last_timer_event): Mark as externally visible.
12680 * keyboard.h (ignore_mouse_drag_p): Declare only if
12681 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12682 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12683 * lisp.h (echoing): Remove decl.
12684 (force_auto_save_soon): Declare only if SIGDANGER.
12685 * xdisp.c (redisplay_window): Simplify code, to make it more
12686 obvious that ignore_mouse_drag_p is not accessed if !defined
12687 USE_GTK && !defined HAVE_NS.
12689 * intervals.c: Make symbols static if they're not exported.
12690 (merge_properties_sticky, merge_interval_right, delete_interval):
12692 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12694 * insdel.c: Make symbols static if they're not exported.
12695 However, leave prepare_to_modify_buffer alone. It's never
12696 called from outside this function, but that appears to be a bug.
12697 (combine_after_change_list, combine_after_change_buffer):
12698 (adjust_after_replace, signal_before_change): Now static.
12699 (adjust_after_replace_noundo): Remove; unused.
12700 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
12701 (signal_before_change): Remove decls.
12703 * indent.c (val_compute_motion, val_vmotion): Now static.
12705 * image.c: Make symbols static if they're not exported.
12706 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12708 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12709 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12711 * fringe.c (standard_bitmaps): Now static.
12712 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12714 * frame.c: Make symbols static if they're not exported.
12715 (x_report_frame_params, make_terminal_frame): Now static.
12716 (get_frame_param): Now static, unless HAVE_NS.
12717 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12718 (x_get_resource_string): Remove; not used.
12719 * frame.h (make_terminal_frame, x_report_frame_params):
12720 (x_get_resource_string); Remove decls.
12721 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12722 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12724 * font.c, fontset.c: Make symbols static if they're not exported.
12725 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12726 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12727 * font.c (font_close_object): Now static.
12728 * font.h (font_close_object): Remove.
12729 * fontset.c (FONTSET_OBJLIST): Remove.
12730 (free_realized_fontset) #if-0 the body, which does nothing.
12731 (face_suitable_for_char_p): #if-0, as it's never called.
12732 * fontset.h (face_suitable_for_char_p): Remove decl.
12733 * xfaces.c (face_at_string_position):
12734 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
12735 since 0 is always ASCII.
12737 * fns.c (weak_hash_tables): Now static.
12739 * fileio.c: Make symbols static if they're not exported.
12740 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12741 (Vwrite_region_annotation_buffers): Now static.
12743 * eval.c: Make symbols static if they're not exported.
12744 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12745 * lisp.h (backtrace_list): Remove decl.
12747 * emacs.c: Make symbols static if they're not exported.
12748 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12749 (fatal_error_code, fatal_error_signal_hook, standard_args):
12751 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12752 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12753 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12754 * lisp.h (fatal_error_signal_hook): Remove decl.
12755 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12757 * editfns.c: Move a (normally-unused) function to its only use.
12758 * editfns.c, lisp.h (get_operating_system_release): Remove.
12759 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12760 worth the hassle of breaking this out.
12762 * xterm.c: Make symbols static if they're not exported.
12763 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12764 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12765 (x_destroy_window, x_delete_display):
12767 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12768 (x_mouse_leave): Remove; unused.
12769 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12770 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12771 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12773 (x_mouse_leave): Declare only if WINDOWSNT.
12774 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12775 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12778 * ftxfont.c: Make symbols static if they're not exported.
12779 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12781 * font.h (ftxfont_driver): Likewise.
12783 * xfns.c: Make symbols static if they're not exported.
12784 (x_last_font_name, x_display_info_for_name):
12785 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12786 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12787 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12788 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12789 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12790 (last_show_tip_args): Now static.
12791 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12792 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12793 (x_screen_planes): Remove; unused.
12794 * dispextern.h (x_screen_planes): Remove decl.
12796 * dispnew.c: Make symbols static if they're not exported.
12797 * dispextern.h (redraw_garbaged_frames, scrolling):
12798 (increment_row_positions): Remove.
12799 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12800 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12802 (redraw_garbaged_frames): Remove; unused.
12804 * xfaces.c: Make symbols static if they're not exported.
12805 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12807 * xterm.h (defined_color): Remove decls.
12808 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12809 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12810 (menu_face_changed_default, defined_color, free_realized_face):
12811 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12812 (ascii_face_of_lisp_face): Remove; unused.
12814 * xdisp.c: Make symbols static if they're not exported.
12815 * dispextern.h (scratch_glyph_row, window_box_edges):
12816 (glyph_to_pixel_coords, set_cursor_from_row):
12817 (get_next_display_element, set_iterator_to_next):
12818 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12819 (show_mouse_face): Remove decls
12820 * frame.h (message_buf_print): Likewise.
12821 * lisp.h (pop_message, set_message, check_point_in_composition):
12823 * xterm.h (set_vertical_scroll_bar): Likewise.
12824 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12825 (message_buf_print, scratch_glyph_row, displayed_buffer):
12826 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12827 (get_next_display_element, show_mouse_face, window_box_edges):
12828 (frame_to_window_pixel_xy, check_point_in_composition):
12829 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12830 (glyph_to_pixel_coords): Remove; unused.
12832 * dired.c (file_name_completion): Now static.
12834 * dbusbind.c (xd_in_read_queued_messages): Now static.
12836 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12837 * data.c (circular_list_error): Remove.
12839 * commands.h (last_point_position, last_point_position_buffer):
12840 (last_point_position_window): Remove decls.
12841 * keyboard.c: Make these variables static.
12843 * coding.h (coding, code_convert_region, encode_coding_gap):
12845 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12846 (iso_code_class, detect_coding, code_convert_region): Now static.
12847 (encode_coding_gap): Remove; unused.
12849 * chartab.c (chartab_chars, chartab_bits): Now static.
12851 * charset.h (charset_iso_8859_1): Remove decl.
12852 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12855 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12856 * ccl.c (Vccl_program_table): Now static.
12857 (check_ccl_update): Remove; unused.
12859 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12860 * category.h: ... from here.
12861 * category.c (check_category_table, set_category_set): Now static.
12863 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12864 * lisp.h: Remove these decls.
12866 * buffer.c (buffer_count): Remove unused var.
12868 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12869 so that it's not optimized away.
12870 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12871 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12872 exported only to the debugger.
12874 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
12875 * atimer.h (run_all_atimers): Remove; not exported.
12877 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12878 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12879 was inaccessible from Lisp.
12880 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12881 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12883 alloc.c: Import and export fewer symbols, and remove unused items.
12884 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12886 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12887 it's not optimized away by whole-program optimization.
12888 (message_enable_multibyte, free_misc): Remove.
12889 (catchlist, handlerlist, mark_backtrace):
12890 Declare only if BYTE_MARK_STACK.
12891 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12892 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12893 (message_enable_multibyte): Remove decl.
12894 (free_misc, interval_free_list, float_block, float_block_index):
12895 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12896 (cons_free_list, last_marked_index):
12898 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12899 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12900 (mark_backtrace): Define only if BYTE_MARK_STACK.
12901 * xdisp.c (message_enable_multibyte): Now static.
12903 Declare Lisp_Object Q* variables to be 'static' if not exported.
12904 This makes it easier for human readers (and static analyzers)
12905 to see whether these variables are used from other modules.
12906 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12907 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12908 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12909 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12910 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12911 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12912 * xmenu.c, xselect.c:
12913 Declare Q* vars static if they are not used in other modules.
12914 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12915 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12916 Remove decls of unexported vars.
12917 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12919 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12921 Make Emacs functions such as Fatom 'static' by default.
12922 This makes it easier for human readers (and static analyzers)
12923 to see whether these functions can be called from other modules.
12924 DEFUN now defines a static function. To make the function external
12925 so that it can be used in other C modules, use the new macro DEFUE.
12926 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12927 (Finit_image_library):
12928 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12929 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12930 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12931 Remove decls, since these functions are now static.
12932 (Funintern, Fget_internal_run_time): New decls, since these functions
12933 were already external.
12935 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12936 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12937 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12938 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12939 * keyboard.c, keymap.c, lread.c:
12940 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12941 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12942 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12943 Mark functions with DEFUE instead of DEFUN,
12944 if they are used in other modules.
12945 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12946 decls for now-static functions.
12947 * buffer.h (Fdelete_overlay): Remove decl.
12948 * callproc.c (Fgetenv_internal): Mark as internal.
12949 * composite.c (Fremove_list_of_text_properties): Remove decl.
12950 (Fcomposition_get_gstring): New forward static decl.
12951 * composite.h (Fcomposite_get_gstring): Remove decl.
12952 * dired.c (Ffile_attributes): New forward static decl.
12953 * doc.c (Fdocumntation_property): New forward static decl.
12954 * eval.c (Ffetch_bytecode): New forward static decl.
12955 (Funintern): Remove extern decl; now in .h file where it belongs.
12956 * fileio.c (Fmake_symbolic_link): New forward static decl.
12957 * image.c (Finit_image_library): New forward static decl.
12958 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12959 * intervals.h (Fprevious_property_change):
12960 (Fremove_list_of_text_properties): Remove decls.
12961 * keyboard.c (Fthis_command_keys): Remove decl.
12962 (Fcommand_execute): New forward static decl.
12963 * keymap.c (Flookup_key): New forward static decl.
12964 (Fcopy_keymap): Now static.
12965 * keymap.h (Flookup_key): Remove decl.
12966 * process.c (Fget_process): New forward static decl.
12967 (Fprocess_datagram_address): Mark as internal.
12968 * syntax.c (Fsyntax_table_p): New forward static decl.
12969 (skip_chars): Remove duplicate decl.
12970 * textprop.c (Fprevious_property_change): New forward static decl.
12971 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12973 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12974 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12976 * editfns.c (Fformat): Remove unreachable code.
12978 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12980 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12983 2011-04-13 Eli Zaretskii <eliz@gnu.org>
12985 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12986 when at ZV. (Bug#8487)
12988 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12990 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12992 * keyboard.c (parse_tool_bar_item): Likewise.
12993 * sound.c (sound_cleanup, alsa_close): Likewise.
12994 * termcap.c (tgetent): Likewise.
12995 * xfns.c (x_default_font_parameter): Likewise.
12996 * xsettings.c (read_and_apply_settings): Likewise.
12998 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12999 (overrun_check_free): Protoize.
13001 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
13003 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
13004 since callers should never pass a negative size.
13005 Change the signature to match that of plain 'read' and 'write'; see
13006 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
13007 * lisp.h: Update prototypes of emacs_write and emacs_read.
13009 2011-04-11 Eli Zaretskii <eliz@gnu.org>
13011 * xdisp.c (redisplay_window): Don't try to determine the character
13012 position of the scroll margin if the window start point w->startp
13013 is outside the buffer's accessible region. (Bug#8468)
13015 2011-04-10 Eli Zaretskii <eliz@gnu.org>
13017 Fix write-region and its subroutines for buffers > 2GB.
13018 * fileio.c (a_write, e_write): Modify declaration of arguments and
13019 local variables to support buffers larger than 2GB.
13020 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
13022 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
13023 argument, local variables, and return value.
13025 * lisp.h: Update prototypes of emacs_write and emacs_read.
13027 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
13029 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
13031 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13033 Fix more problems found by GCC 4.6.0's static checks.
13035 * xdisp.c (vmessage): Use a better test for character truncation.
13037 * charset.c (load_charset_map): <, not <=, for optimization,
13038 and to avoid potential problems with integer overflow.
13039 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
13040 * casetab.c (set_identity, shuffle): Likewise.
13041 * editfns.c (Fformat): Likewise.
13042 * syntax.c (skip_chars): Likewise.
13044 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13045 This also lets GCC 4.6.0 generate slightly better loop code.
13047 * callint.c (Fcall_interactively): <, not <=, for optimization.
13048 (Fcall_interactively): Count the number of arguments produced,
13049 not the number of arguments given. This is simpler and lets GCC
13050 4.6.0 generate slightly better code.
13052 * ftfont.c: Distingish more carefully between FcChar8 and char.
13053 The previous code passed unsigned char * to a functions like
13054 strlen and xstrcasecmp that expect char *, which does not
13055 conform to the C standard.
13056 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13057 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13058 char * when the C standard requires it.
13060 * keyboard.c (read_char): Remove unused var.
13062 * eval.c: Port to Windows vsnprintf (Bug#8435).
13063 Include <limits.h>.
13064 (SIZE_MAX): Define if the headers do not.
13065 (verror): Do not give up if vsnprintf returns a negative count.
13066 Instead, grow the buffer. This ports to Windows vsnprintf, which
13067 does not conform to C99. Problem reported by Eli Zaretskii.
13068 Also, simplify the allocation scheme, by avoiding the need for
13069 calling realloc, and removing the ALLOCATED variable.
13071 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13073 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13074 But keep the doprint source code for now, as we might revamp it
13075 and use it again (Bug#8435).
13076 * lisp.h (doprnt): Remove.
13077 * Makefile.in (base_obj): Remove doprnt.o.
13078 * deps.mk (doprnt.o): Remove.
13080 error: Print 32- and 64-bit integers portably (Bug#8435).
13081 Without this change, on typical 64-bit hosts error ("...%d...", N)
13082 was used to print both 32- and 64-bit integers N, which relied on
13083 undefined behavior.
13084 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
13085 * lisp.h (error, verror): Mark as printf-like functions.
13086 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13087 Report overflow in size calculations when allocating printf buffer.
13088 Do not truncate output string at its first null byte.
13089 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13090 Truncate the output at a character boundary, since vsnprintf does not
13092 * charset.c (check_iso_charset_parameter): Convert internal
13093 character to string before calling 'error', since %c now has the
13095 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13096 overflow when computing char to be passed to 'error'. Do not
13097 pass Lisp_Object to 'error'; pass the integer instead.
13098 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13099 formatted with plain %d.
13101 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13103 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13105 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13107 * xterm.c (x_catch_errors): Remove duplicate declaration.
13109 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13111 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13113 2011-04-10 Jim Meyering <meyering@redhat.com>
13115 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13116 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13117 return ssize_t not "int", and use size_t as the buffer length.
13118 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13119 * gnutls.h: Update declarations.
13120 * process.c (read_process_output): Use ssize_t, to match.
13121 (send_process): Likewise.
13123 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
13125 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13127 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
13129 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13130 Use unsigned char, to match FcChar8 type definition.
13132 * xterm.c (handle_one_xevent):
13133 * xmenu.c (create_and_show_popup_menu):
13134 * xselect.c (x_decline_selection_request)
13135 (x_reply_selection_request): Avoid type-punned deref of X events.
13137 2011-04-09 Eli Zaretskii <eliz@gnu.org>
13139 Fix some uses of `int' instead of EMACS_INT.
13140 * search.c (string_match_1, fast_string_match)
13141 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13142 (scan_buffer, find_next_newline_no_quit)
13143 (find_before_next_newline, search_command, Freplace_match)
13144 (Fmatch_data): Make some `int' variables be EMACS_INT.
13146 * xdisp.c (display_count_lines): 3rd argument and return value now
13147 EMACS_INT. All callers changed.
13148 (pint2hrstr): Last argument is now EMACS_INT.
13150 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13151 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13152 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13153 (decode_coding_utf_16, decode_coding_emacs_mule)
13154 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13155 (decode_coding_ccl, decode_coding_charset)
13156 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13157 (decode_coding_iso_2022, decode_coding_emacs_mule)
13158 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13159 <char_offset, last_offset>: Declare EMACS_INT.
13160 (encode_coding_utf_8, encode_coding_utf_16)
13161 (encode_coding_emacs_mule, encode_invocation_designation)
13162 (encode_designation_at_bol, encode_coding_iso_2022)
13163 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13164 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13166 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13167 (encode_invocation_designation): Last argument P_NCHARS is now
13169 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13170 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13172 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13175 * ccl.c (Fccl_execute_on_string): Declare some variables
13178 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
13180 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13182 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13184 * process.c (Fformat_network_address): Doc fix.
13186 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13188 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
13190 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
13192 * keyboard.c (read_char): Call Lisp function help-form-show,
13193 instead of using internal_with_output_to_temp_buffer.
13194 (Qhelp_form_show): New var.
13195 (syms_of_keyboard): Use DEFSYM macro.
13197 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13199 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13201 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
13203 * process.c (Flist_processes): Remove to Lisp.
13204 (list_processes_1): Delete.
13206 2011-04-06 Eli Zaretskii <eliz@gnu.org>
13208 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13210 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13212 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
13214 Fix more problems found by GCC 4.6.0's static checks.
13216 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13218 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13220 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
13222 * xdisp.c (vmessage): Mark as a printf-like function.
13224 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13226 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13228 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13229 printf-like functions.
13230 (tiff_load): Add casts to remove these marks before passing them
13231 to system-supplied API.
13233 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13235 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13236 This avoids several warnings with gcc -Wstrict-overflow.
13237 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13238 directly, rather than having caller test rule sign. This avoids
13239 some unnecessary tests.
13240 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13241 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13242 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
13244 * xfont.c (xfont_text_extents): Remove var that was set but not used.
13245 (xfont_open): Avoid unnecessary tests.
13247 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13249 * composite.h, composite.c (composition_gstring_put_cache):
13250 Use EMACS_INT, not int, for length.
13252 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13253 breaking out part of COMPOSITION_DECODE_RULE.
13254 (COMPOSITION_DECODE_RULE): Use it.
13255 * composite.c (get_composition_id): Remove unused local vars,
13256 by using the new macro.
13258 * textprop.c (set_text_properties_1): Change while to do-while,
13259 since the condition is always true at first.
13261 * intervals.c (graft_intervals_into_buffer): Mark var as used.
13262 (interval_deletion_adjustment): Return unsigned value.
13265 * process.c (list_processes_1, create_pty, read_process_output):
13266 (exec_sentinel): Remove vars that were set but not used.
13267 (create_pty): Remove unnecessary "volatile"s.
13268 (Fnetwork_interface_info): Avoid possibility of int overflow.
13269 (read_process_output): Do adaptive read buffering even if carryover.
13270 (read_process_output): Simplify nbytes computation if buffered.
13272 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13274 * syntax.c (scan_words): Remove var that was set but not used.
13275 (update_syntax_table): Use unsigned instead of int.
13277 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
13278 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
13279 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
13281 * print.c (print_error_message): Avoid int overflow.
13283 * font.c (font_list_entities): Redo for clarity,
13284 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13286 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
13287 (font_score): Avoid potential overflow in diff calculation.
13289 * fns.c (substring_both): Remove var that is set but not used.
13290 (sxhash): Redo loop for clarity and to avoid wraparound warning.
13292 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13294 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13295 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13296 can always succeed if overflow has undefined behavior.
13298 * search.c (boyer_moore, wordify): Remove vars set but not used.
13299 (wordify): Omit three unnecessary tests.
13301 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13302 All callers changed. This avoids the need for an unused var.
13304 * casefiddle.c (casify_region): Remove var that is set but not used.
13306 * dired.c (file_name_completion): Remove var that is set but not used.
13308 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13310 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
13311 (Finsert_file_contents): Remove unnecessary code checking fd.
13313 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13314 Check for integer overflow on size calculations.
13316 * buffer.c (Fprevious_overlay_change): Remove var that is set
13319 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13320 Remove vars that are set but not used.
13321 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
13322 (timer_check_2): Mark vars as initialized.
13324 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13326 * image.c (lookup_image): Remove var that is set but not used.
13327 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
13329 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13330 that are set but not used.
13332 * xfns.c (make_invisible_cursor): Don't return garbage
13333 if XCreateBitmapFromData fails (Bug#8410).
13335 * xselect.c (x_get_local_selection, x_handle_property_notify):
13336 Remove vars that are set but not used.
13338 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
13339 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
13341 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13342 Remove var that is set but not used.
13343 (scroll_bar_windows_size): Now size_t, not int.
13344 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13345 Check for overflow.
13347 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13348 (map_tty_color) [!defined MSDOS]: Likewise.
13350 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13352 * coding.c: Remove vars that are set but not used.
13353 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13354 All callers changed.
13355 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13356 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13357 (decode_coding_charset): Remove vars that are set but not used.
13359 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13360 that is set but not used.
13362 * print.c (print_object): Remove var that is set but not used.
13364 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
13365 The gnulib version avoids calling malloc in the usual case,
13366 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13367 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13368 * filelock.c (current_lock_owner): Likewise.
13369 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13370 * sysdep.c: Include allocator.h, careadlinkat.h.
13371 (emacs_no_realloc_allocator): New static constant.
13372 (emacs_readlink): New function.
13373 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13374 ../lib/careadlinkat.h.
13376 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13378 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13379 first non-nil return value).
13381 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13383 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13384 if not defined (Bug#8403).
13386 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
13388 * xdisp.c (display_count_lines): Remove parameter `start',
13389 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13390 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13391 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13392 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13393 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13394 and thereabouts. All callers changed.
13395 (get_per_char_metric): Remove parameter `f', unused since
13396 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13398 2011-04-02 Jim Meyering <meyering@redhat.com>
13400 do not dereference NULL upon failed strdup
13401 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13402 (ns_get_family): Likewise.
13404 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
13406 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13408 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13410 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13413 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13415 Add lexical binding.
13417 * window.c (Ftemp_output_buffer_show): New fun.
13418 (Fsave_window_excursion):
13419 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13421 * lread.c (lisp_file_lexically_bound_p): New function.
13422 (Fload): Bind Qlexical_binding.
13423 (readevalloop): Remove `evalfun' arg.
13424 Bind Qinternal_interpreter_environment.
13425 (Feval_buffer): Bind Qlexical_binding.
13426 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13428 (syms_of_lread): Declare `lexical-binding'.
13430 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13432 * keyboard.c (eval_dyn): New fun.
13433 (menu_item_eval_property): Use it.
13435 * image.c (parse_image_spec): Use Ffunctionp.
13437 * fns.c (concat, mapcar1): Accept byte-code-functions.
13439 * eval.c (Fsetq): Handle lexical vars.
13440 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13441 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13442 (FletX, Flet): Obey lexical binding.
13443 (Fcommandp): Handle closures.
13444 (Feval): New `lexical' arg.
13445 (eval_sub): New function extracted from Feval. Use it almost
13446 everywhere where Feval was used. Look up vars in lexical env.
13448 (Ffunctionp): Move from subr.el.
13449 (Ffuncall): Handle closures.
13450 (apply_lambda): Remove `eval_flags'.
13451 (funcall_lambda): Handle closures and new byte-code-functions.
13452 (Fspecial_variable_p): New function.
13453 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13454 but without exporting it to Lisp.
13456 * doc.c (Fdocumentation, store_function_docstring):
13457 * data.c (Finteractive_form): Handle closures.
13459 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13462 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13464 (exec_byte_code): New function extracted from Fbyte_code to handle new
13465 calling convention for byte-code-functions. Add new byte-codes.
13467 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
13469 * alloc.c (Fmake_symbol): Init new `declared_special' field.
13471 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
13473 * xdisp.c (redisplay_internal): Fix prototype.
13475 2011-03-31 Eli Zaretskii <eliz@gnu.org>
13477 * xdisp.c (SCROLL_LIMIT): New macro.
13478 (try_scrolling): Use it when setting scroll_limit.
13479 Limit scrolling to 100 screen lines.
13480 (redisplay_window): Even when falling back on "recentering",
13481 position point in the window according to scroll-conservatively,
13482 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13484 (try_scrolling): When point is above the window, allow searching
13485 as far as scroll_max, or one screenful, to compute vertical
13486 distance from PT to the scroll margin position. This prevents
13487 try_scrolling from unnecessarily failing when
13488 scroll-conservatively is set to a value slightly larger than the
13489 window height. Clean up the case of PT below the margin at bottom
13490 of window: scroll_max can no longer be INT_MAX. When aggressive
13491 scrolling is in use, don't let point enter the opposite scroll
13492 margin as result of the scroll.
13493 (syms_of_xdisp) <scroll-conservatively>: Document the
13494 threshold of 100 lines for never-recentering scrolling.
13496 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
13498 * dispextern.h (move_it_by_lines):
13499 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13500 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13501 (message_log_check_duplicate): Remove parameters `prev_bol' and
13502 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13503 (redisplay_internal): Remove parameter `preserve_echo_area',
13504 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13506 * indent.c (Fvertical_motion):
13507 * window.c (window_scroll_pixel_based, Frecenter):
13508 Don't pass `need_y_p' to `move_it_by_lines'.
13510 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13512 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13513 steal a few bits to be more compact.
13514 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13515 Remove unneeded casts.
13517 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13519 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13521 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13522 binding" message (bug#7967).
13524 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13526 Fix more problems found by GCC 4.6.0's static checks.
13528 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13529 Remove unused local var.
13531 * editfns.c (Fmessage_box): Remove unused local var.
13533 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13534 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13535 Omit unused local vars.
13536 * window.c (shrink_windows): Omit unused local var.
13537 * menu.c (digest_single_submenu): Omit unused local var.
13538 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13539 Omit unused local var.
13541 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13542 Don't assume string length fits in int.
13543 (keyremap_step, read_key_sequence): Use size_t for sizes.
13544 (read_key_sequence): Don't check last_real_key_start redundantly.
13546 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13547 instead of alloca (Bug#8344).
13549 * eval.c (Fbacktrace): Don't assume nargs fits in int.
13550 (Fbacktrace_frame): Don't assume nframes fits in int.
13552 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13554 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13557 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13559 * cm.c (calccost): Turn while-do into do-while, for clarity.
13561 * keyboard.c (syms_of_keyboard): Use the same style as later
13562 in this function when indexing through an array. This also
13563 works around GCC bug 48267.
13565 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13567 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13569 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13570 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13572 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13573 This avoids undefined behavior on integer overflow, and is a bit
13574 more convenient anyway since it is compared to a size_t variable.
13576 Variadic C functions now count arguments with size_t, not int.
13577 This avoids an unnecessary limitation on 64-bit machines, which
13578 caused (substring ...) to crash on large vectors (Bug#8344).
13579 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13580 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
13581 All variadic functions and their callers changed accordingly.
13582 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13583 * data.c (arith_driver, float_arith_driver): Likewise.
13584 * editfns.c (general_insert_function): Likewise.
13585 * eval.c (struct backtrace.nargs, interactive_p)
13586 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13587 (funcall_lambda, mark_backtrace): Likewise.
13588 * fns.c (concat): Likewise.
13589 * frame.c (x_set_frame_parameters): Likewise.
13590 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13591 0 if not found, not -1. All callers changed.
13593 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13594 (stack_copy_size): Now size_t, not int.
13595 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13597 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
13599 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13600 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13601 All callers changed.
13603 * lisp.h (multibyte_char_to_unibyte):
13604 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13605 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13606 * character.h (CHAR_TO_BYTE8):
13607 * cmds.c (internal_self_insert):
13608 * editfns.c (general_insert_function):
13609 * keymap.c (push_key_description):
13610 * search.c (Freplace_match):
13611 * xdisp.c (message_dolog, set_message_1): All callers changed.
13613 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13615 * keyboard.c (safe_run_hook_funcall): New function.
13616 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13617 don't set the hook to nil, but remove the offending function instead.
13618 (Qcommand_hook_internal): Remove, unused.
13619 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13620 Vcommand_hook_internal.
13622 * eval.c (enum run_hooks_condition): Remove.
13623 (funcall_nil, funcall_not): New functions.
13624 (run_hook_with_args): Call each function through a `funcall' argument.
13625 Remove `cond' argument, now redundant.
13626 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13627 (Frun_hook_with_args_until_failure): Adjust accordingly.
13628 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13630 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
13632 * dispextern.h (string_buffer_position): Remove declaration.
13634 * print.c (strout): Remove parameter `multibyte', unused since
13635 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13637 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13638 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13639 All callers changed.
13641 * w32.c (_wsa_errlist): Use braces for struct initializers.
13643 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13644 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13645 All callers changed.
13646 (string_buffer_position): Likewise. Also, make static (it's never
13647 used outside xdisp.c).
13648 (cursor_row_p): Remove parameter `w', unused since
13649 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13650 (decode_mode_spec): Remove parameter `precision', introduced during
13651 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13652 All callers changed.
13654 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13656 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13658 2011-03-27 Anders Lindgren <andlind@gmail.com>
13660 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13661 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13662 (ns_update_auto_hide_menu_bar): New functions.
13663 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13664 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13665 ns_constrain_all_frames.
13666 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13667 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13669 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13671 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13673 2011-03-27 Glenn Morris <rgm@gnu.org>
13675 * syssignal.h: Replace RETSIGTYPE with void.
13676 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13677 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13678 Replace SIGTYPE with void everywhere.
13679 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13680 * s/template.h (SIGTYPE): Remove commented out definition.
13682 2011-03-26 Eli Zaretskii <eliz@gnu.org>
13684 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13685 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13687 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
13689 * w32.c (read_unc_volume): Use parameter `henum', instead of
13690 global variable `wget_enum_handle'.
13692 * keymap.c (describe_vector): Remove parameters `indices' and
13693 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13694 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13696 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13698 * keyboard.c (timer_check): Remove parameter `do_it_now',
13699 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13700 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13701 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13703 * keyboard.c (read_char):
13704 * w32menu.c (w32_menu_display_help):
13705 * xmenu.c (show_help_event, menu_help_callback):
13706 Adjust calls to `show_help_echo'.
13708 * gtkutil.c (xg_maybe_add_timer):
13709 * keyboard.c (readable_events):
13710 * process.c (wait_reading_process_output):
13711 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13713 * insdel.c (adjust_markers_gap_motion):
13714 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13715 (gap_left, gap_right): Don't call it.
13717 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
13719 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13720 incurred during fontification.
13722 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
13724 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13725 (DEFVAR_PER_BUFFER): Don't pass it.
13727 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13728 (scrolling_window): Don't pass it.
13730 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
13732 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13734 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13736 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13737 of variables specific to SELinux and computation of `encoded_absname'.
13739 * image.c (XPutPixel): Remove unused variable `height'.
13741 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13743 * unexw32.c (get_section_info): Remove unused variable `section'.
13745 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13746 (system_process_attributes): Remove unused variable `sess'.
13747 (sys_read): Remove unused variable `err'.
13749 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13750 (w32_wnd_proc): Remove unused variable `isdead'.
13751 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13752 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13753 (x_create_tip_frame): Remove unused variable `tem'.
13755 * w32inevt.c (w32_console_read_socket):
13756 Remove unused variable `no_events'.
13758 * w32term.c (x_draw_composite_glyph_string_foreground):
13759 Remove unused variable `width'.
13761 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
13763 * w32term.c (x_set_glyph_string_clipping):
13764 Don't pass uninitialized region to CombineRgn.
13766 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
13768 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13769 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13770 (Fx_close_connection): Remove unused variable `i'.
13772 * w32font.c (w32font_draw): Return number of glyphs.
13773 (w32font_open_internal): Remove unused variable `i'.
13774 (w32font_driver): Add missing initializer.
13776 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13777 (fill_in_menu): Remove unused variable `items_added'.
13779 * w32term.c (last_mouse_press_frame): Remove static global variable.
13780 (w32_clip_to_row): Remove unused variable `f'.
13781 (x_delete_terminal): Remove unused variable `i'.
13783 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13784 (NOTHING): Remove unused static global variable.
13785 (uniscribe_check_otf): Remove unused variable `table'.
13786 (uniscribe_font_driver): Add missing initializers.
13788 2011-03-23 Julien Danjou <julien@danjou.info>
13790 * term.c (Fsuspend_tty, Fresume_tty):
13791 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13792 * window.c (temp_output_buffer_show):
13793 * insdel.c (signal_before_change):
13794 * frame.c (Fhandle_switch_frame):
13795 * fileio.c (Fdo_auto_save):
13796 * emacs.c (Fkill_emacs):
13797 * editfns.c (save_excursion_restore):
13798 * cmds.c (internal_self_insert):
13799 * callint.c (Fcall_interactively):
13800 * buffer.c (Fkill_all_local_variables):
13801 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13803 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
13804 unconditionally since it does the check itself.
13806 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
13808 Fix more problems found by GCC 4.5.2's static checks.
13810 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13811 the first time through the loop, since we know p0 < p1 then.
13812 This also avoids a gcc -Wstrict-overflow warning.
13814 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13815 leading to a memory leak, possible in functions like
13816 load_charset_map_from_file that can allocate an unbounded number
13817 of objects (Bug#8318).
13819 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13820 that could (at least in theory) be that large.
13822 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13823 This is less likely to overflow, and avoids undefined behavior if
13824 overflow does occur. All callers changed. Use strtoul to scan
13825 for the unsigned long integer.
13826 (pint2hrstr): Simplify and tune code slightly.
13827 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
13829 * scroll.c (do_scrolling): Work around GCC bug 48228.
13830 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13832 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13833 This also avoids a warning with gcc -Wstrict-overflow.
13834 (validate_x_resource_name): Simplify count usage.
13835 This also avoids a warning with gcc -Wstrict-overflow.
13837 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13840 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
13842 * process.c (Fmake_network_process): Use socklen_t, not int,
13843 where POSIX says socklen_t is required in portable programs.
13844 This fixes a porting bug on hosts like 64-bit HP-UX, where
13845 socklen_t is wider than int (Bug#8277).
13846 (Fmake_network_process, server_accept_connection):
13847 (wait_reading_process_output, read_process_output):
13850 * process.c: Rename or move locals to avoid shadowing.
13851 (list_processes_1, Fmake_network_process):
13852 (read_process_output_error_handler, exec_sentinel_error_handler):
13853 Rename or move locals.
13854 (Fmake_network_process): Define label "retry_connect" only if needed.
13855 (Fnetwork_interface_info): Fix pointer signedness.
13856 (process_send_signal): Add cast to avoid pointer signedness problem.
13857 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
13858 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
13860 Make tparam.h and terminfo.c consistent.
13861 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13862 Include tparam.h instead, since it declares them.
13863 * cm.h (PC): Remove extern decl; tparam.h now does this.
13864 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13865 * terminfo.c: Include tparam.h, to check interfaces.
13866 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13867 (tparam): Adjust signature to match interface in tparam.h;
13868 this removes some undefined behavior. Check that outstring and len
13869 are zero, which they always are with Emacs.
13870 * tparam.h (PC, BC, UP): New extern decls.
13872 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
13873 (xftfont_open): Rename locals to avoid shadowing.
13875 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
13876 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13877 (OTF_TAG_SYM): Omit macro if not needed.
13878 (ftfont_list): Remove unused local.
13879 (get_adstyle_property, ftfont_pattern_entity):
13880 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13881 Rename locals to avoid shadowing.
13883 * xfont.c (xfont_list_family): Mark var as initialized.
13885 * xml.c (make_dom): Now static.
13887 * composite.c (composition_compute_stop_pos): Rename local to
13889 (composition_reseat_it): Remove unused locals.
13890 (find_automatic_composition, composition_adjust_point): Likewise.
13891 (composition_update_it): Mark var as initialized.
13892 (find_automatic_composition): Mark vars as initialized,
13893 with a FIXME (Bug#8290).
13895 character.h: Rename locals to avoid shadowing.
13896 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13897 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13898 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13899 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13900 to avoid shadowing.
13902 * textprop.c (property_change_between_p): Remove; unused.
13904 * intervals.c (interval_start_pos): Now static.
13906 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13908 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13909 Rename locals to avoid shadowing.
13911 * sound.c (wav_play, au_play, Fplay_sound_internal):
13912 Fix pointer signedness.
13913 (alsa_choose_format): Remove unused local var.
13914 (wav_play): Initialize a variable to 0, to prevent undefined
13915 behavior (Bug#8278).
13917 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13919 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13921 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13922 clobbering (Bug#8298).
13923 * sysdep.c (sys_subshell): Likewise.
13924 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
13926 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13927 This should get cleaned up, so that child_setup has the
13928 same signature on all platforms.
13930 * callproc.c (call_process_cleanup): Now static.
13931 (relocate_fd): Rename locals to avoid shadowing.
13933 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
13935 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13936 not to be necessary, and produces flickering.
13938 2011-03-20 Glenn Morris <rgm@gnu.org>
13940 * config.in: Remove file.
13942 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
13944 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13945 are now in src/globals.h.
13946 (syms_of_minibuf): Remove spurious & from previous change.
13948 2011-03-20 Leo Liu <sdl.web@gmail.com>
13950 * minibuf.c (completing-read-function): New variable.
13951 (completing-read-default): Rename from completing-read.
13952 (completing-read): Call completing-read-function.
13954 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13956 * xfaces.c (Fx_load_color_file):
13957 Read color file from absolute filename (bug#8250).
13959 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13961 * makefile.w32-in: Update dependencies.
13963 2011-03-17 Eli Zaretskii <eliz@gnu.org>
13965 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13967 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13969 Fix more problems found by GCC 4.5.2's static checks.
13971 * process.c (make_serial_process_unwind, send_process_trap):
13972 (sigchld_handler): Now static.
13974 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13975 That way, the code declares only the vars that it needs.
13976 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13977 * s/cygwin.h (PTY_ITERATION): Likewise.
13978 * s/darwin.h (PTY_ITERATION): Likewise.
13979 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13981 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13982 * process.c (allocate_pty): Don't declare stb unless it's needed.
13984 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
13985 (CONSTANTLIM): Remove; unused.
13986 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13987 Define only if needed.
13989 * unexelf.c (unexec): Name an expression,
13990 to avoid gcc -Wbad-function-cast warning.
13991 Use a different way to cause a compilation error if anyone uses
13992 n rather than nn, a way that does not involve shadowing.
13993 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
13995 * deps.mk (unexalpha.o): Remove; unused.
13997 New file unexec.h, the (simple) interface for unexec (Bug#8267).
13998 * unexec.h: New file.
13999 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
14000 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
14001 Depend on unexec.h.
14002 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
14003 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
14004 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
14005 Change as necessary to match prototype in unexec.h.
14007 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
14009 (back_comment, skip_chars): Mark vars as initialized.
14011 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
14012 Rename locals to avoid shadowing.
14014 * lread.c (read1): Rewrite so as not to use empty "else".
14015 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
14017 * print.c (Fredirect_debugging_output): Fix pointer signedess.
14019 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
14020 warning when compiling print.c.
14022 * font.c (font_unparse_fcname): Abort in an "impossible" situation
14023 instead of using an uninitialized var.
14024 (font_sort_entities): Mark var as initialized.
14026 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
14028 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14029 pointers to constants.
14030 (font_parse_fcname): Remove unused vars.
14031 (font_delete_unmatched): Now static.
14032 (font_get_spec): Remove; unused.
14033 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14034 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14035 Rename or move locals to avoid shadowing.
14037 * fns.c (require_nesting_list, require_unwind): Now static.
14038 (Ffillarray): Rename locals to avoid shadowing.
14040 * floatfns.c (domain_error2): Define only if needed.
14041 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
14043 * alloc.c (mark_backtrace): Move decl from here ...
14044 * lisp.h: ... to here, so that it can be checked.
14046 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
14047 (Fdefvar): Rewrite so as not to use empty "else".
14048 (lisp_indirect_variable): Name an expression,
14049 to avoid gcc -Wbad-function-cast warning.
14050 (Fdefvar): Rename locals to avoid shadowing.
14052 * callint.c (quotify_arg, quotify_args): Now static.
14053 (Fcall_interactively): Rename locals to avoid shadowing.
14054 Use const pointer when appropriate.
14056 * lisp.h (get_system_name, get_operating_system_release):
14057 Move decls here, to check interfaces.
14058 * process.c (get_operating_system_release): Move decl to lisp.h.
14059 * xrdb.c (get_system_name): Likewise.
14060 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14061 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14062 some of which prompt warnings from gcc -Wbad-function-cast.
14063 (Fformat_time_string, Fencode_time, Finsert_char):
14064 (Ftranslate_region_internal, Fformat):
14065 Rename or remove local vars to avoid shadowing.
14066 (Ftranslate_region_internal): Mark var as initialized.
14068 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14071 * lisp.h (eassert): Check that the argument compiles, even if
14072 ENABLE_CHECKING is not defined.
14074 * data.c (Findirect_variable): Name an expression, to avoid
14075 gcc -Wbad-function-cast warning.
14076 (default_value, arithcompare, arith_driver, arith_error): Now static.
14077 (store_symval_forwarding): Rename local to avoid shadowing.
14078 (Fmake_variable_buffer_local, Fmake_local_variable):
14079 Mark variables as initialized.
14080 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
14082 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
14083 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14084 Rename locals to avoid shadowing.
14085 (mark_stack): Move local variables into the #ifdef region where
14087 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14088 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14090 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14091 (GC_STRING_CHARS): Remove; not used.
14092 (Fmemory_limit): Cast sbrk's returned value to char *.
14094 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14095 avoids undefined behavior in theory.
14097 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14099 Use functions, not macros, for up- and down-casing (Bug#8254).
14100 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14101 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14102 to use the following functions instead of these macros.
14103 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14104 EMACS_INT, since callers assume the returned value fits in int.
14105 (upcase1): Likewise, for UPCASE_TABLE.
14106 (uppercasep, lowercasep, upcase): New static inline functions.
14107 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
14108 the race-condition problem in the old DOWNCASE.
14110 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14111 Rename locals to avoid shadowing.
14112 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
14113 (regex_compile, re_search_2, re_match_2_internal):
14114 Remove unused local vars.
14115 (FREE_VAR): Rewrite so as not to use empty "else",
14116 which gcc can warn about.
14117 (regex_compile, re_match_2_internal): Mark locals as initialized.
14118 (RETALLOC_IF): Define only if needed.
14119 (WORDCHAR_P): Likewise. This one is never needed, but is used
14120 only in a comment talking about a compiler bug, so put inside
14121 the #if 0 of that comment.
14122 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14123 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14126 * search.c (boyer_moore): Rename locals to avoid shadowing.
14127 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14128 (PREV_CHAR_BOUNDARY): Likewise.
14130 * search.c (simple_search): Remove unused var.
14132 * dired.c (compile_pattern): Move decl from here ...
14133 * lisp.h: ... to here, so that it can be checked.
14134 (struct re_registers): New forward decl.
14136 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14138 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14140 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14141 Rename locals to avoid shadowing.
14142 (Fvertical_motion): Mark locals as initialized.
14144 * casefiddle.c (casify_object, casify_region): Now static.
14145 (casify_region): Mark local as initialized.
14147 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14149 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14150 New macros, so that the caller can use some names other than
14151 gcpro1, gcpro2, etc.
14152 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14154 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14155 argument, for consistency with GCPRO2_VAR, etc: it is now the
14156 prefix of the variable, not the variable itself. All uses
14158 * dired.c (directory_files_internal, file_name_completion):
14159 Rename locals to avoid shadowing.
14161 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14162 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14163 dired.c's scmp function, had undefined behavior.
14164 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14165 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14166 * buffer.h: ... to here, because these macros use current_buffer,
14167 and the new implementation with inline functions needs to have
14168 current_buffer in scope now, rather than later when the macros
14170 (downcase, upcase1): New static inline functions.
14171 (DOWNCASE, UPCASE1): Reimplement using these functions.
14172 This avoids undefined behavior in expressions like
14173 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14174 from race conditions in accessing the global variables
14175 case_temp1 and case_temp2.
14176 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14177 * lisp.h (case_temp1, case_temp2): Remove their decls.
14178 * character.h (ASCII_CHAR_P): Move from here ...
14179 * lisp.h: ... to here, so that the inline functions mentioned
14180 above can use them.
14182 * dired.c (directory_files_internal_unwind): Now static.
14184 * fileio.c (file_name_as_directory, directory_file_name):
14185 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14187 (file_name_as_directory): Use const pointers when appropriate.
14188 (Fexpand_file_name): Likewise. In particular, newdir might
14189 point at constant storage, so make it a const pointer.
14190 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
14191 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14193 (Fset_file_times, Finsert_file_contents, auto_save_error):
14194 Rename locals to avoid shadowing.
14196 * minibuf.c (choose_minibuf_frame_1): Now static.
14197 (Ftry_completion, Fall_completions): Rename or remove locals
14198 to avoid shadowing.
14200 * marker.c (bytepos_to_charpos): Remove; unused.
14202 * lisp.h (verify_bytepos, count_markers): New decls,
14203 so that gcc does not warn that these functions aren't declared.
14205 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14206 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
14207 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
14208 (copy_text): Remove unused local var.
14210 * filelock.c (within_one_second): Now static.
14211 (lock_file_1): Rename local to avoid shadowing.
14213 * buffer.c (fix_overlays_before): Mark locals as initialized.
14214 (fix_start_end_in_overlays): Likewise. This function should be
14215 simplified by using pointers-to-pointers, but that's a different
14217 (switch_to_buffer_1): Now static.
14218 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14219 (report_overlay_modification): Rename locals to avoid shadowing.
14221 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
14222 Fix pointer signedness issue.
14223 (sys_subshell): Mark local as volatile if checking for lint,
14224 to suppress a gcc -Wclobbered warning that does not seem to be right.
14225 (MAXPATHLEN): Define only if needed.
14227 * process.c (serial_open, serial_configure): Move decls from here ...
14228 * systty.h: ... to here, so that they can be checked.
14230 * fns.c (get_random, seed_random): Move extern decls from here ...
14231 * lisp.h: ... to here, so that they can be checked.
14233 * sysdep.c (reset_io): Now static.
14234 (wait_for_termination_signal): Remove; unused.
14236 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14237 (copy_keymap_item, append_key, push_text_char_description):
14239 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
14240 (DENSE_TABLE_SIZE): Remove; unused.
14241 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14242 (describe_map_tree):
14243 Rename locals to avoid shadowing.
14245 * keyboard.c: Declare functions static if they are not used elsewhere.
14246 (echo_char, echo_dash, cmd_error, top_level_2):
14247 (poll_for_input, handle_async_input): Now static.
14248 (read_char, kbd_buffer_get_event, make_lispy_position):
14249 (make_lispy_event, make_lispy_movement, apply_modifiers):
14250 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14251 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14252 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
14253 (read_key_sequence, read_char): Mark locals as initialized.
14254 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
14256 * keyboard.h (make_ctrl_char): New decl.
14257 (mark_kboards): Move decl here ...
14258 * alloc.c (mark_kboards): ... from here.
14260 * lisp.h (force_auto_save_soon): New decl.
14262 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
14263 (DEFINE_DUMMY_FUNCTION): New macro.
14264 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14266 (main): Add casts to avoid warnings
14267 if GCC considers string literals to be constants.
14269 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14271 * dbusbind.c: Pointer signedness fixes.
14272 (xd_signature, xd_append_arg, xd_initialize):
14273 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14274 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14275 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14276 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14278 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14279 if GCC considers string literals to be constants.
14280 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
14282 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14284 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14285 (print_preprocess, print_object): New macro to fix last change.
14287 * print.c (print_preprocess): Don't forget font objects.
14289 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
14291 * emacs.c (USAGE3): Doc fixes.
14293 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14295 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14298 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
14300 * lisp.h (VWindow_system, Qfile_name_history):
14301 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14302 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14303 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14305 * w32select.c: Don't #include "keyboard.h".
14306 (run_protected): Add extern declaration for waiting_for_input.
14308 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14309 * w32console.c (detect_input_pending, read_input_pending)
14310 (encode_terminal_code):
14311 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14312 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14313 (w32_system_caret_y, Qfile_name_history):
14314 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14315 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14316 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14317 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14318 * w32proc.c (Qlocal, report_file_error):
14319 * w32term.c (Vwindow_system, updating_frame):
14320 * w32uniscribe.c (initialized, uniscribe_font_driver):
14321 Remove unneeded extern declarations.
14323 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
14325 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
14327 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
14329 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14330 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14331 These macros can no longer be used for assignment.
14333 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14334 Assign struct members directly, instead of using BUF_BEGV etc.
14335 (record_buffer_markers, fetch_buffer_markers): New functions for
14336 recording and fetching special buffer markers.
14337 (set_buffer_internal_1, set_buffer_temp): Use them.
14339 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14341 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14343 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14344 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14346 * xdisp.c (hscroll_window_tree):
14347 (reconsider_clip_changes): Use PT instead of BUF_PT.
14349 2011-03-13 Eli Zaretskii <eliz@gnu.org>
14351 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14352 $(EMACS_ROOT)/lib/intprops.h.
14354 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14356 Fix more problems found by GCC 4.5.2's static checks.
14358 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14359 to unsigned char * to avoid compiler diagnostic.
14360 (xg_free_frame_widgets): Make it clear that a local variable is
14361 needed only if USE_GTK_TOOLTIP.
14362 (gdk_window_get_screen): Make it clear that this macro is needed
14363 only if USE_GTK_TOOLTIP.
14364 (int_gtk_range_get_value): New function, which avoids a diagnostic
14365 from gcc -Wbad-function-cast.
14366 (xg_set_toolkit_scroll_bar_thumb): Use it.
14367 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14368 diagnostic from gcc -Wbad-function-cast.
14369 (get_utf8_string, xg_get_file_with_chooser):
14370 Rename locals to avoid shadowing.
14371 (create_dialog): Move locals to avoid shadowing.
14373 * xgselect.c (xg_select): Remove unused var.
14375 * image.c (four_corners_best): Mark locals as initialized.
14376 (gif_load): Initialize transparent_p to zero (Bug#8238).
14377 Mark another local as initialized.
14378 (my_png_error, my_error_exit): Mark with NO_RETURN.
14380 * image.c (clear_image_cache): Now static.
14381 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
14382 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
14383 (x_edge_detection): Remove unnecessary cast that
14384 gcc -Wbad-function-cast diagnoses.
14385 (gif_load): Fix pointer signedness.
14386 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14387 (jpeg_load, gif_load): Rename locals to avoid shadowing.
14389 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
14391 Improve quality of tests for time stamp overflow.
14392 For example, without this patch (encode-time 0 0 0 1 1
14393 1152921504606846976) returns the obviously-bogus value (-948597
14394 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14395 reports time overflow. See
14396 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
14397 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14398 * editfns.c: Include limits.h and intprops.h.
14399 (TIME_T_MIN, TIME_T_MAX): New macros.
14400 (time_overflow): Move earlier, to before first use.
14401 (hi_time, lo_time): New functions, for an accurate test for
14402 out-of-range times.
14403 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14404 (Fget_internal_run_time): Don't assume time_t fits in int.
14405 (make_time): Use list2 instead of Fcons twice.
14406 (Fdecode_time): More accurate test for out-of-range times.
14407 (check_tm_member): New function.
14408 (Fencode_time): Use it, to test for out-of-range times.
14409 (lisp_time_argument): Don't rely on undefined left-shift and
14410 right-shift behavior when checking for time stamp overflow.
14412 * editfns.c (time_overflow): New function, refactoring common code.
14413 (Fformat_time_string, Fdecode_time, Fencode_time):
14414 (Fcurrent_time_string): Use it.
14416 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14417 * dired.c (make_time): Move to ...
14418 * editfns.c (make_time): ... here.
14419 * systime.h: Note the move.
14421 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14423 * fringe.c (update_window_fringes): Remove unused variables.
14425 * unexmacosx.c (copy_data_segment): Also copy __got section.
14428 2011-03-12 Eli Zaretskii <eliz@gnu.org>
14430 * termcap.c [MSDOS]: Include "msdos.h".
14431 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14432 Constify `char *' arguments and their references according to
14433 prototypes in tparam.h.
14435 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
14437 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14438 Adapt all references accordingly.
14440 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14442 2011-03-11 Tom Tromey <tromey@redhat.com>
14444 * buffer.c (syms_of_buffer): Remove obsolete comment.
14446 2011-03-11 Eli Zaretskii <eliz@gnu.org>
14448 * termhooks.h (encode_terminal_code): Declare prototype.
14450 * msdos.c (encode_terminal_code): Don't declare prototype.
14452 * term.c (encode_terminal_code): Now external again, used by
14453 w32console.c and msdos.c.
14455 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14456 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
14458 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
14460 Fix some minor problems found by GCC 4.5.2's static checks.
14462 * fringe.c (update_window_fringes): Mark locals as initialized
14464 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
14466 * alloc.c (mark_fringe_data): Move decl from here ...
14467 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14468 to check its interface.
14469 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14471 * fontset.c (free_realized_fontset): Now static.
14472 (Fset_fontset_font): Rename local to avoid shadowing.
14473 (fontset_font): Mark local as initialized.
14474 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
14476 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14478 * xselect.c (x_disown_buffer_selections): Remove; not used.
14479 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
14480 (x_own_selection, Fx_disown_selection_internal): Rename locals
14481 to avoid shadowing.
14482 (x_handle_dnd_message): Remove local to avoid shadowing.
14484 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14485 so that the caller can use some name other than gcpro1.
14486 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
14487 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14488 (Fx_backspace_delete_keys_p):
14489 Use them to avoid shadowing, and rename vars to avoid shadowing.
14490 (x_decode_color, x_set_name, x_window): Now static.
14491 (Fx_create_frame): Add braces to silence GCC warning.
14492 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
14493 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14494 Remove unused locals.
14495 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14496 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14497 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14500 * xterm.h (x_mouse_leave): New decl.
14502 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14503 Remove unused functions.
14504 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14505 (x_calc_absolute_position): Now static.
14506 (XTread_socket): Don't define label "out" unless it's used.
14507 Don't declare local "event" unless it's used.
14508 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14509 unless they are used.
14510 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14511 (x_fatal_error_signal): Remove; not used.
14512 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14513 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14514 (x_error_catcher, x_connection_closed, x_error_handler):
14515 (x_error_quitter, xembed_send_message, x_iconify_frame):
14516 (my_log_handler): Rename locals to avoid shadowing.
14517 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
14518 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
14520 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14521 Rename or move locals to avoid shadowing.
14522 (tty_defined_color, merge_face_heights): Now static.
14523 (free_realized_faces_for_fontset): Remove; not used.
14524 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14525 does not deduce is never used uninitialized.
14526 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14527 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
14529 * terminal.c (store_terminal_param): Now static.
14531 * xmenu.c (menu_highlight_callback): Now static.
14532 (set_frame_menubar): Remove unused local.
14533 (xmenu_show): Rename parameter to avoid shadowing.
14534 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14535 since they might point to immutable storage.
14536 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14537 since it's unused otherwise.
14539 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
14540 Add a FIXME, since the code still doesn't look right. (Bug#8215)
14541 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14542 avoids a gcc -Wuninitialized diagnostic.
14543 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
14544 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14545 does not deduce are never used uninitialized.
14547 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14549 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
14550 * window.c (window_loop, size_window):
14551 (run_window_configuration_change_hook, enlarge_window): Likewise.
14553 * window.c (display_buffer): Now static.
14554 (size_window): Mark variables that gcc -Wuninitialized
14555 does not deduce are never used uninitialized.
14556 * window.h (check_all_windows): New decl, to forestall
14557 gcc -Wmissing-prototypes diagnostic.
14558 * dispextern.h (bidi_dump_cached_states): Likewise.
14560 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14562 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
14563 Include <limits.h>.
14564 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14565 and to avoid gcc -Wuninitialized warning.
14566 (load_charset_map): Mark variables that gcc -Wuninitialized
14567 does not deduce are never used uninitialized.
14568 (load_charset): Abort instead of using uninitialized var (Bug#8229).
14570 * coding.c (coding_set_source, coding_set_destination):
14571 Use "else { /* comment */ }" rather than "else /* comment */;"
14572 for clarity, and to avoid gcc -Wempty-body warning.
14573 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14574 a block, when the outer 'i' will do.
14575 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14576 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14577 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14578 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14579 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14580 Rename locals to avoid shadowing.
14581 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
14582 * coding.c (emacs_mule_char, encode_invocation_designation):
14583 Now static, since they're not used elsewhere.
14584 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
14585 (decode_coding_object, encode_coding_object, detect_coding_system):
14586 (decode_coding_emacs_mule): Mark variables that gcc
14587 -Wuninitialized does not deduce are never used uninitialized.
14588 (detect_coding_iso_2022): Initialize a local variable that might
14589 be used uninitialized. Leave a FIXME because it's not clear that
14590 this initialization is needed. (Bug#8211)
14591 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14592 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14593 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14594 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14595 Remove unused macros.
14597 * category.c (hash_get_category_set): Remove unused local var.
14598 (copy_category_table): Now static, since it's not used elsewhere.
14599 * character.c (string_count_byte8): Likewise.
14601 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14602 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14604 * chartab.c (copy_sub_char_table): Now static, since it's not used
14606 (sub_char_table_ref_and_range, char_table_ref_and_range):
14607 Rename locals to avoid shadowing.
14608 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
14610 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
14611 (BIDI_BOB): Remove unused macro.
14613 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14614 deduce are never used uninitialized.
14615 * term.c (encode_terminal_code): Likewise.
14617 * term.c (encode_terminal_code): Now static. Remove unused local.
14619 * tparam.h: New file.
14620 * term.c, tparam.h: Include it.
14621 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14622 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14623 Move these decls to tparam.h, and make them agree with what
14624 is actually in tparam.c. The previous trick of using incompatible
14625 decls in different modules does not conform to the C standard.
14626 All callers of tparam changed to use tparam's actual API.
14627 * tparam.c (tparam1, tparam, tgoto):
14628 Use const pointers where appropriate.
14630 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14631 * cm.h (struct cm): Likewise.
14632 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14633 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14634 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14635 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14636 (turn_on_face, init_tty): Likewise.
14637 * termchar.h (struct tty_display_info): Likewise.
14639 * term.c (term_mouse_position): Rename local to avoid shadowing.
14641 * alloc.c (mark_ttys): Move decl from here ...
14642 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14644 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14646 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14648 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
14650 * search.c (compile_pattern_1): Remove argument regp, unused since
14651 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14652 (compile_pattern): Don't pass it.
14654 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14656 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14657 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14659 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14661 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14663 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14664 gdk_window_get_screen, gdk_window_get_geometry,
14665 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14666 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14667 (xg_get_pixbuf_from_pixmap): New function.
14668 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14669 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14670 Call xg_get_pixbuf_from_pixmap instead of
14671 gdk_pixbuf_get_from_drawable.
14672 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14673 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14674 (xg_check_special_colors): Use GtkStyleContext and its functions
14676 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14677 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14678 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
14679 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14680 Call gtk_widget_get_preferred_size.
14681 (xg_frame_resized): gdk_window_get_geometry only takes 5
14683 (xg_win_to_widget, xg_event_is_for_menubar):
14684 Call gdk_x11_window_lookup_for_display.
14685 (xg_set_widget_bg): New function.
14686 (delete_cb): New function.
14687 (xg_create_frame_widgets): Connect delete-event to delete_cb.
14688 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
14689 (xg_set_background_color): Call xg_set_widget_bg.
14690 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14691 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14692 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14693 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14695 (update_frame_tool_bar): Call gtk_widget_hide.
14696 (xg_initialize): Use GDK_KEY_g.
14698 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14700 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14702 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14703 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14704 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14706 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
14708 * w32xfns.c (select_palette): Check success of RealizePalette against
14709 GDI_ERROR, not zero.
14711 See ChangeLog.11 for earlier changes.
14713 ;; Local Variables:
14717 Copyright (C) 2011-2012 Free Software Foundation, Inc.
14719 This file is part of GNU Emacs.
14721 GNU Emacs is free software: you can redistribute it and/or modify
14722 it under the terms of the GNU General Public License as published by
14723 the Free Software Foundation, either version 3 of the License, or
14724 (at your option) any later version.
14726 GNU Emacs is distributed in the hope that it will be useful,
14727 but WITHOUT ANY WARRANTY; without even the implied warranty of
14728 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14729 GNU General Public License for more details.
14731 You should have received a copy of the GNU General Public License
14732 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.