1 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4 avoid crash when xmalloc overrun checking is enabled.
6 2011-10-13 Eli Zaretskii <eliz@gnu.org>
8 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
9 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
10 cursor motion with <left> and <right> arrow keys.
12 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
13 some callers set that themselves.
15 2011-10-12 Eli Zaretskii <eliz@gnu.org>
17 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
18 display string and the previous row comes from the same string and
19 is empty. (Bug#9739) (Bug#9738)
21 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
23 * doc.c (get_doc_string): Encode file name (bug#9735).
25 2011-10-12 Eli Zaretskii <eliz@gnu.org>
27 * bidi.c (bidi_level_of_next_char):
28 * xdisp.c (get_visually_first_element): Remove old incorrect
29 comments regarding the Unicode Line Separator character.
31 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
33 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
35 * alloc.c (Fgc_status): Do not access beyond zombies array
36 boundary if nzombies > MAX_ZOMBIES.
37 * alloc.c (dump_zombies): Add missing format specifier.
39 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
41 * xdisp.c (set_cursor_from_row): Simplify conditionals,
42 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
44 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
45 Some packages use them to denote characters with modifiers.
47 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
49 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
50 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
51 matching a pp-number. Rename parameter var to var1.
53 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
55 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
57 2011-10-08 Glenn Morris <rgm@gnu.org>
59 * callint.c (Fcall_interactively): Give a more explicit error for the
60 'c' case with a non-character input. (Bug#8479)
62 2011-10-08 Eli Zaretskii <eliz@gnu.org>
64 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
66 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
67 lines that are hscrolled on the left.
69 * dispnew.c (buffer_posn_from_coords): Account for a possible
70 presence of header-line. (Bug#4426)
72 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
74 * buffer.c (syms_of_buffer) <enable-multibyte-characters>: Don't
75 advertise functionality which we discourage or doesn't work.
77 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
79 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
80 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
81 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
82 this makes Emacs dump core during garbage collection on rare
83 occasions. sizeof is obviously inferior to offsetof here, so
85 (GC_POINTER_ALIGNMENT): New macro.
86 (mark_memory): Omit 3rd (offset) arg; caller changed.
87 Don't assume EMACS_INT alignment is the same as pointer alignment.
89 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
91 * keyboard.c (read_key_sequence_remapped): New var.
92 (read_key_sequence): Compute remapping in the right buffer.
93 (command_loop_1): Use read_key_sequence's remapping directly.
95 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
97 * dired.c (file_name_completion): Don't expand file name.
98 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
99 before checking file name handler.
101 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
102 they've been requested explicitly (bug#9591).
104 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
106 * keymap.c (Fsingle_key_description): Use make_specified_string
107 instead of build_string to build string from push_key_description.
110 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
112 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
113 This fixes a Y2038 bug on 64-bit hosts.
114 * buffer.c (reset_buffer):
115 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
116 (Fclear_buffer_auto_save_failure):
117 Use 0, not -1, to represent an unset failure time, since time_t
120 Remove dependency on glibc malloc internals.
121 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
122 Move back here from lisp.h, but with their new implementations.
123 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
124 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
125 * charset.c (charset_table_init): New static var.
126 (syms_of_charset): Use it instead of xmalloc. This removes a
127 dependency on glibc malloc internals. See Eli Zaretskii's comment in
128 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
129 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
130 Move back to alloc.c.
131 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
132 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
134 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
136 * nsterm.m (windowDidResize): Call x_set_window_size only when
137 ns_in_resize is true. Otherwise set pixelwidth/height and
138 call change_frame_size (Bug#9628).
140 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
142 Port --enable-checking=all to Fedora 14 x86-64.
143 * charset.c (syms_of_charset): Also account for glibc malloc's
144 internal overhead when calculating the initial malloc maximum.
146 Port --enable-checking=all to Fedora 14 x86.
147 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
149 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
150 (overrun_check_realloc, overrun_check_free):
151 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
152 That way, xmalloc returns a properly-aligned pointer even if
153 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
154 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
155 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
156 into account when calculating the initial malloc maximum.
157 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
158 Move here from alloc.c, so that charset.c can use it too.
159 Properly align; the old code wasn't right for common 32-bit hosts
160 when configured with --enable-checking=all.
161 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
162 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
164 2011-09-29 Eli Zaretskii <eliz@gnu.org>
166 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
169 2011-09-28 Eli Zaretskii <eliz@gnu.org>
171 * xdisp.c (compute_display_string_end): If there's no display
172 string at CHARPOS, return -1.
174 * bidi.c (bidi_fetch_char): When compute_display_string_end
175 returns a negative value, treat the character as a normal
176 character not covered by a display string. (Bug#9624)
178 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
180 * lread.c (Fread_from_string): Fix typo in docstring.
182 2011-09-27 Eli Zaretskii <eliz@gnu.org>
184 * xdisp.c (handle_invisible_prop): If invisible text ends on a
185 newline, reseat the iterator instead of bidi-iterating there one
186 character at a time. (Bug#9610)
187 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
188 TO_CHARPOS if the bidi iterator is at base embedding level.
190 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
192 * lread.c (readevalloop): Use correct code for NBSP.
193 (read1): Likewise. (Bug#9608)
195 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
197 * dbusbind.c (Fdbus_register_signal): When service is not
198 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
200 2011-09-25 Glenn Morris <rgm@gnu.org>
202 * buffer.c (truncate-lines): Doc fix.
204 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
206 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
207 (Fset_window_next_buffers): Doc fix.
209 2011-09-24 Glenn Morris <rgm@gnu.org>
211 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
213 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
215 Fix minor problems found by static checking.
216 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
217 * indent.c (Fvertical_motion): Fix == vs = typo.
219 2011-09-24 Eli Zaretskii <eliz@gnu.org>
221 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
222 Default value is now t. Doc fix.
224 * indent.c (Fvertical_motion): Compute and apply the overshoot
225 logic when moving up, not only when moving down. Fix the
226 confusing name and values of the it_overshoot_expected variable;
227 logic changes accordingly. (Bug#9254) (Bug#9549)
229 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
230 CHARPOS is covered by a display string which includes newlines.
231 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
232 is covered by a display string with embedded newlines.
234 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
236 * dbusbind.c (Fdbus_register_signal): Add match rule to
237 Vdbus_registered_objects_table. (Bug#9581)
238 (Fdbus_register_method, Vdbus_registered_objects_table):
241 2011-09-24 Jim Meyering <meyering@redhat.com>
243 do not ignore write error for any output size
244 The previous change was incomplete.
245 While it makes emacs --batch detect the vast majority of stdout
246 write failures, errors were still ignored whenever the output size is
247 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
248 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
249 && echo FAIL: ignored write error
250 FAIL: ignored write error
251 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
252 && echo FAIL: ignored write error
253 FAIL: ignored write error
254 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
256 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
258 * emacs.c (Fkill_emacs): In noninteractive mode exit
259 non-successfully if a write error occurred on stdout. (Bug#9574)
261 2011-09-21 Eli Zaretskii <eliz@gnu.org>
263 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
266 * dispextern.h (struct it): Update the comment documenting what
269 2011-09-20 Eli Zaretskii <eliz@gnu.org>
271 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
272 a display string, extend search for cursor position to end of row.
273 (find_row_edges): If the row ends in a newline from a display
274 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
275 Handle the case of a display string with multiple newlines.
276 (Fcurrent_bidi_paragraph_direction): Fix search for previous
277 non-empty line. Fixes confusing cursor motion with arrow keys at
278 the beginning of a line that starts with whitespace.
280 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
282 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
285 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
287 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
290 2011-09-18 Eli Zaretskii <eliz@gnu.org>
292 * xdisp.c (display_line): Record maximum and minimum buffer
293 positions even if no glyphs were produced (e.g., by a zero-width
294 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
295 buffer positions that will be removed from the glyph row because
297 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
298 column is beyond frame width: don't subtract 1 "pixel" when
299 computing width of the stretch.
300 (reseat_at_next_visible_line_start): Undo the change made on
301 2011-09-17 that saved paragraph information and restored it after
302 the call to `reseat'. (Bug#9545)
304 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
306 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
307 and turn window cursor on if cleared (Bug#9415).
309 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
311 * search.c (boyer_moore): Take unibyte characters from pattern
312 literally. (Bug#9458)
314 2011-09-18 Eli Zaretskii <eliz@gnu.org>
316 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
318 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
320 Fix minor problem found by static checking.
321 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
322 initialized, to pacify gcc -Wuninitialized.
324 * fileio.c: Report proper errno when syscall falls.
325 (Finsert_file_contents): Save and restore errno,
326 so that report_file_error outputs the correct diagnostic.
327 (Fwrite_region) [CLASH_DETECTION]: Likewise.
329 2011-09-18 Eli Zaretskii <eliz@gnu.org>
331 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
333 2011-09-17 Eli Zaretskii <eliz@gnu.org>
335 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
336 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
338 2011-09-17 Eli Zaretskii <eliz@gnu.org>
340 * xdisp.c (reseat_at_next_visible_line_start): Keep information
341 about the current paragraph and restore it after the call to
344 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
345 (bidi_find_paragraph_start): Search back for paragraph beginning
346 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
347 (bidi_move_to_visually_next): Only trigger paragraph-related
348 computations when the last character is a newline or at EOB, not
349 just any NEUTRAL_B. (Bug#9470)
351 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
352 truncated lines if point is covered by a display string. (Bug#9524)
354 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
356 * xselect.c: Relax test for outgoing X longs (Bug#9498).
357 (cons_to_x_long): New function.
358 (lisp_data_to_selection_data): Use it. Correct the test for
359 short-versus-long data; it was negated. Break out of vector
360 loop, for efficiency, when a long datum is discovered.
362 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
364 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
366 2011-09-16 Eli Zaretskii <eliz@gnu.org>
368 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
369 GCC PR/17406) by declaring this function with external scope.
371 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
373 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
374 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
376 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
378 * editfns.c (Fformat): Correctly handle text properties on "%%".
380 2011-09-15 Eli Zaretskii <eliz@gnu.org>
382 * xterm.c (x_draw_composite_glyph_string_foreground):
383 * w32term.c (x_draw_composite_glyph_string_foreground):
384 * term.c (encode_terminal_code):
385 * composite.c (composition_update_it, get_composition_id):
386 * xdisp.c (get_next_display_element)
387 (fill_composite_glyph_string): Add comments about special meaning
388 of TAB characters in a composition.
390 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
392 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
393 This occurs when processing a multibyte format.
394 Problem reported by Wolfgang Jenker.
396 2011-09-15 Johan Bockgård <bojohan@gnu.org>
398 * xdisp.c (try_cursor_movement): Only check for exact match if
399 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
401 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
403 Remove unused external symbols.
404 * dispextern.h (calc_pixel_width_or_height): Remove decl.
405 * xdisp.c (calc_pixel_width_or_height): Now static.
406 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
407 * indent.c (check_display_width):
408 * w32term.c: Fix comment to match code.
409 * xterm.c, xterm.h (x_catching_errors): Remove.
411 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
413 * xselect.c: Use signed conversions more consistently (Bug#9498).
414 (selection_data_to_lisp_data): Assume incoming selection data are
415 signed integers, not unsigned. This is to be consistent with
416 outgoing selection data, which was modified to use signed integers
417 in as part of the fix to Bug#9196 in response to Jan D.'s comment
418 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
419 expects long, not unsigned long.
421 2011-09-14 Eli Zaretskii <eliz@gnu.org>
423 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
424 computation of loop end. Reported by Johan Bockgård
427 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
429 * frame.c (Fother_visible_frames_p): Function deleted.
431 2011-09-12 Eli Zaretskii <eliz@gnu.org>
433 * indent.c (compute_motion): Process display vector front to back
434 rather than the other way around. (Bug#2496)
436 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
438 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
440 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
442 * minibuf.c (Fread_from_minibuffer): Doc fix.
444 2011-09-11 Eli Zaretskii <eliz@gnu.org>
446 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
447 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
449 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
451 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
452 value for non-existent files.
454 2011-09-11 Eli Zaretskii <eliz@gnu.org>
456 * fileio.c (Finsert_file_contents): If the file cannot be opened,
457 set its "size" to -1. This will set the modtime_size field of
458 the corresponding buffer to -1, which is what
459 verify-visited-file-modtime expects for files that do not exist.
462 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
464 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
466 * lisp.h: ... from here. push_key_description is no longer
467 defined in keyboard.c, so its declaration should not be in
468 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
469 logically belongs with push_key_description.
471 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
473 * buffer.h: Include <sys/types.h> instead of <time.h>.
474 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
475 Problem reported by Herbert J. Skuhra.
477 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
479 * xml.c (parse_region): Make the parsing work for
480 non-comment-starting XML files again (bug#9144).
482 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
484 * image.c (gif_load): Fix calculation of bottom and right corner.
487 2011-09-10 Eli Zaretskii <eliz@gnu.org>
489 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
490 redisplay in small windows.
492 2011-09-09 Eli Zaretskii <eliz@gnu.org>
494 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
496 2011-09-08 Martin Rudalics <rudalics@gmx.at>
498 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
499 Operate on live windows only.
501 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
503 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
505 2011-09-07 Eli Zaretskii <eliz@gnu.org>
507 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
508 only under bidi iteration.
510 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
512 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
514 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
516 isnan: Fix porting problem to Solaris 10 with bundled gcc.
517 Without this fix, the command to link temacs failed due to an
518 undefined symbol __builtin_isnan. This is because
519 /usr/include/iso/math_c99.h #defines isnan(x) to
520 __builtin_isnan(x), but the bundled gcc, which identifies itself
521 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
523 * floatfns.c (isnan): #undef, and then #define to a clone of
525 (Fisnan): Always define, since it's always available now.
526 (syms_of_floatfns): Always define isnan at the Lisp level.
528 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
530 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
532 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
534 * fileio.c: Fix bugs with large file offsets (Bug#9428).
535 The previous code assumed that file offsets (off_t values) fit in
536 EMACS_INT variables, which is not true on typical 32-bit hosts.
537 The code messed up by falsely reporting buffer overflow in cases
538 such as (insert-file-contents "big" nil 1 2) into an empty buffer
539 when "big" contains more than 2**29 bytes, even though this
540 inserts just one byte and does not overflow the buffer.
541 (Finsert_file_contents): Store file offsets as off_t
542 values, not as EMACS_INT values. Check for overflow when
543 converting between EMACS_INT and off_t. When checking for
544 buffer overflow or for overlap, take the offsets into account.
545 Don't use EMACS_INT for small values where int suffices.
546 When checking for overlap, fix a typo: ZV was used where
547 ZV_BYTE was intended.
548 (Fwrite_region): Don't assume off_t fits into 'long'.
549 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
551 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
553 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
555 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
557 sprintf-related integer and memory overflow issues (Bug#9412).
559 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
560 (esprintf, exprintf, evxprintf): New functions.
561 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
562 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
563 (modify_event_symbol): Do not assume that the length of
564 name_alist_or_stem is safe to alloca and fits in int.
565 (Fexecute_extended_command): Likewise for function name and binding.
566 (Frecursion_depth): Wrap around reliably on integer overflow.
567 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
568 since some callers pass EMACS_INT values.
569 (Fsingle_key_description): Don't crash if symbol name contains more
570 than MAX_ALLOCA bytes.
571 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
572 (get_minibuffer): Arg is now EMACS_INT, not int.
573 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
574 (esprintf, exprintf, evxprintf): New decls.
575 * window.h (command_loop_level, minibuf_level): Reflect API changes.
577 * dbusbind.c (signature_cat): New function.
578 (xd_signature, Fdbus_register_signal):
579 Do not overrun buffer; instead, report string overflow.
581 * dispnew.c (add_window_display_history): Don't overrun buffer.
582 Truncate instead; this is OK since it's just a log.
584 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
585 even if the time zone offset is outlandishly large.
586 Don't mishandle offset == INT_MIN.
588 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
589 when creating daemon; the previous buffer-overflow check was incorrect.
591 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
592 which has the guts of the old verror function.
594 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
595 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
597 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
598 (font_unparse_xlfd): Don't blindly alloca long strings.
599 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
600 fits in int, when using sprintf. Use single snprintf to count
601 length of string rather than counting it via multiple sprintfs;
602 that's simpler and more reliable.
603 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
604 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
605 sprintf, in case result does not fit in int.
607 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
608 (fontset_from_font): Print it.
610 * frame.c (tty_frame_count): Now printmax_t, not int.
611 (make_terminal_frame, set_term_frame_name): Print it.
612 (x_report_frame_params): In X, window IDs are unsigned long,
613 not signed long, so print them as unsigned.
614 (validate_x_resource_name): Check for implausibly long names,
615 and don't assume name length fits in 'int'.
616 (x_get_resource_string): Don't blindly alloca invocation name;
617 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
620 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
621 (xg_check_special_colors, xg_set_geometry):
622 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
624 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
625 Use esprintf, not sprintf, in case result does not fit in int.
627 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
628 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
629 it as a large positive number.
630 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
631 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
633 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
634 in case result does not fit in int.
636 * print.c (float_to_string): Detect width overflow more reliably.
637 (print_object): Make sprintf buffer a bit bigger, to avoid potential
638 buffer overrun. Don't assume list length fits in 'int'. Treat
639 print length of 0 as 0, not as infinity; to be consistent with other
640 uses of print length in this function. Don't overflow print length
641 index. Don't assume hash table size fits in 'long', or that
642 vectorlike size fits in 'unsigned long'.
644 * process.c (make_process): Use printmax_t, not int, to format
645 process-name gensyms.
647 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
649 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
650 to avoid potential buffer overrun.
652 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
653 if X resource line is longer than 512 bytes.
655 * xfns.c (x_window): Make sprintf buffer a bit bigger
656 to avoid potential buffer overrun.
658 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
660 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
662 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
664 Integer overflow fixes for scrolling, etc.
665 Without these, Emacs silently mishandles large integers sometimes.
666 For example, "C-u 4294967297 M-x recenter" was treated as if
667 it were "C-u 1 M-x recenter" on a typical 64-bit host.
669 * xdisp.c (try_window_id): Check Emacs fixnum range before
672 * window.c (window_scroll_line_based, Frecenter):
673 Check that an Emacs fixnum is in range before assigning it to 'int'.
674 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
675 values converted from Emacs fixnums.
676 (Frecenter): Don't wrap around a line count if it is out of 'int'
677 range; instead, treat it as an extreme value.
678 (Fset_window_configuration, compare_window_configurations):
679 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
681 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
682 that can exceed INT_MAX. Check that EMACS_INT value is in range
683 before assigning it to the (possibly-narrower) index.
684 (match_limit): Don't assume that a fixnum can fit in 'int'.
686 * print.c (print_object): Use ptrdiff_t, not int, for index that can
689 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
690 (Fvertical_motion): Don't wrap around LINES values that don't fit
691 in 'int'. Instead, treat them as extreme values. This is good
692 enough for windows, which can't have more than INT_MAX lines anyway.
694 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
696 * Require libxml/parser.h to avoid compilation warning.
698 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
700 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
701 since this reportedly can destroy thread storage.
703 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
705 * syntax.c (find_defun_start): Update all cache variables if
706 exiting early (Bug#9401).
708 2011-08-30 Eli Zaretskii <eliz@gnu.org>
710 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
712 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
713 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
714 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
716 * term.c (tty_append_glyph): New function.
717 (produce_stretch_glyph): Static function and its prototype deleted.
719 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
722 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
724 * image.c (parse_image_spec): Check for nonnegative, not for positive,
725 when checking :margin (Bug#9390).
726 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
727 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
728 so that the name doesn't mislead. All uses changed.
730 2011-08-28 Johan Bockgård <bojohan@gnu.org>
732 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
735 2011-08-27 Eli Zaretskii <eliz@gnu.org>
737 * xdisp.c (move_it_to): Don't bail out early when reaching
738 position beyond to_charpos, if we are scanning backwards.
739 (move_it_vertically_backward): When DY == 0, make sure we get to
740 the first character in the line after the newline.
742 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
744 * ccl.c: Improve and simplify overflow checking (Bug#9196).
745 (ccl_driver): Do not generate an out-of-range pointer.
746 (Fccl_execute_on_string): Remove unnecessary check for
747 integer overflow, noted by Stefan Monnier in
748 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
749 Remove a FIXME that didn't need fixing.
750 Simplify the newly-introduced buffer reallocation code.
752 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
754 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
756 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
758 Integer and memory overflow issues (Bug#9196).
760 * doc.c (get_doc_string): Rework so that
761 get_doc_string_buffer_size is the actual buffer size, rather than
762 being 1 less than the actual buffer size; this makes xpalloc more
765 * image.c (x_allocate_bitmap_record, cache_image):
766 * xselect.c (Fx_register_dnd_atom):
767 Simplify previous changes by using xpalloc.
769 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
770 since either will do and ptrdiff_t is convenient with xpalloc.
772 * charset.c (charset_table_size)
773 (struct charset_sort_data.priority): Now ptrdiff_t.
774 (charset_compare): Don't overflow if priorities differ greatly.
775 (Fsort_charsets): Don't assume list length fits in int.
776 Check for size-calculation overflow when allocating sort data.
777 (syms_of_charset): Allocate an initial charset table that is
778 just under 64 KiB, to avoid problems with glibc malloc and mmap.
780 * cmds.c (internal_self_insert): Check for size-calculation overflow.
782 * composite.h (struct composition.glyph_len): Now int, not unsigned.
783 The actual value is always <= INT_MAX, and leaving it unsigned made
784 overflow checking harder.
786 * dispextern.h (struct glyph_matrix.rows_allocated)
787 (struct face_cache.size): Now ptrdiff_t, for convenience in use
788 with xpalloc. The values are still always <= INT_MAX.
790 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
792 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
793 (SAFE_NALLOCA): New macro.
795 * region-cache.c (struct boundary.pos, find_cache_boundary)
796 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
797 (set_cache_region, invalidate_region_cache)
798 (revalidate_region_cache, know_region_cache, region_cache_forward)
799 (region_cache_backward, pp_cache):
800 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
801 so that ptrdiff_t * can be passed to xpalloc.
802 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
803 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
804 (pp_cache): Don't assume cache_len fits in int.
805 * region-cache.h: Adjust extern decls to match.
807 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
808 EMACS_INT, since either will do, for xpalloc.
810 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
811 (xnmalloc, xnrealloc, xpalloc): New functions.
813 * bidi.c (bidi_shelve_header_size): New constant.
814 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
815 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
817 * bidi.c (bidi_cache_shrink):
818 * buffer.c (overlays_at, overlays_in, record_overlay_string)
820 Don't update size of array until after memory allocation succeeds,
821 because xmalloc/xrealloc may not return.
822 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
823 now that we have proper integer overflow checking.
824 (record_overlay_string, overlay_strings): Catch overflows when
825 calculating size of overlay_str_buf.
827 * callproc.c (Fcall_process): Check for size overflow when
828 calculating size of args2.
829 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
830 Normally we prefer signed values, but sticking with ptrdiff_t would
831 require adding more-complicated checks.
833 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
834 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
835 Redo buffer-overflow calculations to avoid integer overflow.
836 Add a FIXME comment where memory seems to be over-allocated.
838 * character.c (Fstring): Check for size-calculation overflow.
840 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
841 unnecessary integer overflow. Check for size overflow.
842 (encode_coding_object): Don't update size until xmalloc succeeds.
844 * composite.c (get_composition_id): Check for overflow in glyph
847 Integer and memory overflow fixes for display code.
848 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
849 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
850 (scrolling_window): Check for overflow in size calculations.
851 (line_draw_cost, realloc_glyph_pool, add_row_entry):
852 Don't assume glyph table len fits in int.
853 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
854 (row_table_size): Now ptrdiff_t, not int.
855 (scrolling_window): Avoid overflow in size calculations.
856 Don't update size until allocation succeeds.
857 * fns.c (concat): Check for overflow in size calculations.
858 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
859 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
860 (NEXT_ALMOST_PRIME_LIMIT): New constant.
862 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
863 (get_doc_string): Check for size calculation overflow.
864 Don't update size until allocation succeeds.
865 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
866 EMACS_INT, where ptrdiff_t will do.
867 (Fsubstitute_command_keys): Check for string overflow.
869 * editfns.c (set_time_zone_rule): Don't assume environment length
871 (message_length): Now ptrdiff_t, not int.
872 (Fmessage_box): Don't update size until allocation succeeds.
873 Don't assume message length fits in int.
874 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
876 * emacs.c (main): Do not reallocate argv, since there is a null at
877 the end that can be overwritten, and this way there's no need to
878 worry about size-calculation overflow.
879 (sort_args): Check for size-calculation overflow.
881 * eval.c (init_eval_once, grow_specpdl): Don't update size until
883 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
885 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
886 (x_set_scroll_bar_width, x_figure_window_size):
887 Check for integer overflow.
888 (x_set_alpha): Do not assume XINT fits in int.
890 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
891 This is for the members text_lines, text_cols, total_lines, total_cols,
892 where the system imposes an 'int' limit.
894 * fringe.c (Fdefine_fringe_bitmap):
895 Don't update size until alloc works.
897 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
898 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
900 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
901 Check for size-calculation overflow.
902 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
903 do, as we prefer signed integers.
904 (id_to_widget.max_size, id_to_widget.used)
905 (xg_store_widget_in_map, xg_remove_widget_from_map)
906 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
907 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
908 Use and return ptrdiff_t, not int.
909 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
910 * gtkutil.h: Change prototypes to match the above.
912 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
913 are duplicate now that they've been promoted to lisp.h.
914 (x_allocate_bitmap_record, x_alloc_image_color)
915 (make_image_cache, cache_image, xpm_load):
916 Don't update size until alloc is done.
917 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
919 Check for size calculation overflow.
920 (ct_colors_allocated_max): New constant.
921 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
924 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
925 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
926 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
927 Use ptrdiff_t, not int, to count maps.
928 (read_char_minibuf_menu_prompt): Check for overflow in size
929 calculations. Don't update size until allocation succeeds.
930 Redo calculations to avoid overflow.
931 * keyboard.h: Change prototypes to match the above.
933 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
935 (current_minor_maps): Check for size calculation overflow.
936 * keymap.h: Change prototypes to match the above.
938 * lread.c (read1, init_obarray): Don't update size until alloc done.
940 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
941 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
943 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
944 Now ptrdiff_t, not int.
945 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
946 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
948 * process.c (Fnetwork_interface_list): Check for overflow
951 * region-cache.c (move_cache_gap): Check for size calculation overflow.
953 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
954 overflow. Don't bother calling xmalloc when xrealloc will do.
956 * search.c (Freplace_match): Check for size calculation overflow.
957 (Fset_match_data): Don't assume list lengths fit in 'int'.
959 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
960 for command line length. Do not attempt to address one before the
961 beginning of an array, as that's not portable.
963 * term.c (max_frame_lines): Remove; unused.
964 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
966 (encode_terminal_code, calculate_costs): Check for size
967 calculation overflow.
968 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
969 table lengths and related sizes. Don't update size until alloc
970 done. Redo calculations to avoid overflow.
971 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
973 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
974 subtracting pointers.
975 (gobble_line): Check for overflow more carefully. Don't update size
978 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
979 Don't update size until alloc done.
980 Redo size calculations to avoid overflow.
981 Check for size calculation overflow.
982 (main) [DEBUG]: Fix typo in invoking tparam1.
984 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
985 Use ptrdiff_t, not int, for sizes.
986 (store_mode_line_noprop_char): Don't update size until alloc done.
988 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
989 Use ptrdiff_t, not int, for sizes.
990 (Finternal_make_lisp_face, cache_face):
991 Check for size calculation overflow.
992 (cache_face): Treat size calculation overflows as if they were
993 memory exhaustion (the usual treatment), rather than aborting.
995 * xfns.c (x_encode_text, x_set_name_internal)
996 (Fx_change_window_property): Use ptrdiff_t, not int, to count
997 sizes, since they can exceed INT_MAX in size. Check for size
998 calculation overflow.
1000 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1001 (xg_select): Check for size calculation overflow.
1002 Don't update size until alloc done.
1004 * xrdb.c (get_environ_db): Don't assume path length fits in int,
1005 as sprintf is limited to int lengths.
1007 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1008 (X_LONG_MIN): New macros.
1009 Use them to make the following changes clearer.
1010 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1011 This change doesn't affect the value now, but it may help remind
1012 future maintainers not to raise the value too much later.
1013 (SELECTION_QUANTUM): Remove, replacing with ...
1014 (selection_quantum): ... new function, which avoids overflow.
1016 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1017 assumption that selection length fits in 'int'.
1018 (x_reply_selection_request, x_handle_selection_request)
1019 (x_get_window_property, receive_incremental_selection)
1020 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1021 (lisp_data_to_selection_data, clean_local_selection_data):
1022 Use ptrdiff_t, not int, to record length of selection.
1023 (x_reply_selection_request, x_get_window_property)
1024 (receive_incremental_selection, x_property_data_to_lisp):
1025 Redo calculations to avoid overflow.
1026 (x_reply_selection_request): When sending hint, ceiling it at
1027 X_LONG_MAX rather than relying on wraparound overflow to send
1029 (x_get_window_property, receive_incremental_selection)
1030 (lisp_data_to_selection_data, x_property_data_to_lisp):
1031 Check for size-calculation overflow.
1032 (x_get_window_property, receive_incremental_selection)
1033 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1034 Don't store size until memory allocation succeeds.
1035 (x_get_window_property): Plug memory leak on memory exhaustion.
1036 Don't double-block input; malloc is safe here. Don't assume 2**34
1037 - 4 fits in unsigned long. Add an xassert to check
1038 XGetWindowProperty overflow. Be more careful about overflow
1039 calculations, and distinguish size from memory overflow better.
1040 (receive_incremental_selection): When tracing, don't assume
1041 unsigned int is less than INT_MAX.
1042 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1043 harmful) conversions of unsigned short to int.
1044 (lisp_data_to_selection_data): Don't assume that integers
1045 in the range -65535 through -1 fit in an X unsigned short.
1046 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1047 result parameters unless successful. Rely on cons_to_unsigned
1048 to report problems with elements; the old code wasn't right anyway.
1049 (x_check_property_data): Check for int overflow; we cannot use
1050 a wider type due to X limits.
1051 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1053 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
1055 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1056 (x_term_init): Check for size calculation overflow.
1057 (x_color_cells): Don't store size until memory allocation succeeds.
1058 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
1059 Don't assume alloca size is less than MAX_ALLOCA.
1060 (x_term_init): Don't assume length fits in int (sprintf is limited
1063 Use ptrdiff_t for composition IDs.
1064 * character.c (lisp_string_width):
1065 * composite.c (composition_table_size, n_compositions)
1066 (get_composition_id, composition_gstring_from_id):
1067 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1068 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1069 * window.c (Frecenter):
1070 Use ptrdiff_t, not int, for composition IDs.
1071 * composite.c (get_composition_id): Check for integer overflow.
1072 * composite.h: Adjust prototypes to match the above changes.
1074 Use ptrdiff_t for hash table indexes.
1075 * category.c (hash_get_category_set):
1076 * ccl.c (ccl_driver):
1077 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1078 * coding.c (coding_system_charset_list, detect_coding_system):
1079 * coding.h (struct coding_system.id):
1080 * composite.c (get_composition_id, gstring_lookup_cache):
1081 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1082 * image.c (xpm_get_color_table_h):
1083 * lisp.h (hash_lookup, hash_put):
1084 * minibuf.c (Ftest_completion):
1085 Use ptrdiff_t for hash table indexes, not int (which is too
1086 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1087 32-bit --with-wide-int hosts).
1089 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1090 Add a FIXME comment about memory leaks.
1091 (syms_of_charset): Don't assume xmalloc returns.
1093 Don't assume that stated character widths fit in int.
1094 * character.c (Fchar_width, c_string_width, lisp_string_width):
1095 * character.h (CHAR_WIDTH):
1096 * indent.c (MULTIBYTE_BYTES_WIDTH):
1097 Use sanitize_char_width to avoid undefined and/or bad behavior
1098 with outlandish widths.
1099 * character.h (sanitize_tab_width): Rename from sanitize_width,
1100 now that we have two such functions. All uses changed.
1101 (sanitize_char_width): New inline function.
1103 Don't assume that tab-width fits in int.
1104 * character.h (sanitize_width): New inline function.
1105 (SANE_TAB_WIDTH): New macro.
1106 (ASCII_CHAR_WIDTH): Use it.
1107 * indent.c (sane_tab_width): Remove. All uses replaced by
1108 SANE_TAB_WIDTH (current_buffer).
1109 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1111 * fileio.c: Integer overflow issues with file modes.
1112 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1114 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1115 Remove unreachable code.
1116 (read_hex, load_charset_map_from_file): Check for integer overflow.
1118 * xterm.c: don't go over XClientMessageEvent limit
1119 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1120 (x_send_scroll_bar_event): Likewise. Check that the size does not
1121 exceed limits imposed by XClientMessageEvent, as well as the usual
1122 ptrdiff_t and size_t limits.
1124 * keyboard.c: Overflow, signedness and related fixes.
1125 (make_lispy_movement): Use same integer type in forward decl
1126 that is used in the definition.
1127 (read_key_sequence, keyremap_step):
1128 Change bufsize argument back to int, undoing my 2011-03-30 change.
1129 We prefer signed types, and int is wide enough here.
1130 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1131 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1132 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1133 length, not size_t. Use ptrdiff_t for index, not int.
1134 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1135 possibility of integer overflow.
1137 Overflow, signedness and related fixes for images.
1139 * dispextern.h (struct it.stack[0].u.image.image_id)
1140 (struct_it.image_id, struct image.id, struct image_cache.size)
1141 (struct image_cache.used, struct image_cache.ref_count):
1142 * gtkutil.c (update_frame_tool_bar):
1143 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1144 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1145 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1146 * nsmenu.m (update_frame_tool_bar):
1147 * xdisp.c (calc_pixel_width_or_height):
1148 * xfns.c (image_cache_refcount):
1149 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1150 on typical 64-bit hosts.
1152 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1153 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1154 Omit unnecessary casts to int.
1155 (parse_image_spec): Check that integers fall into 'int' range
1156 when the callers expect that.
1157 (image_ascent): Redo ascent calculation to avoid int overflow.
1158 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1159 (lookup_image): Remove unnecessary tests.
1160 (xbm_image_p): Locals are now of int, not EMACS_INT,
1161 since parse_image_check makes sure they fit into int.
1162 (png_load, gif_load, svg_load_image):
1163 Prefer int to unsigned where either will do.
1164 (tiff_handler): New function, combining the cores of the
1165 old tiff_error_handler and tiff_warning_handler.
1166 This function is rewritten to use vsnprintf and thereby avoid
1167 stack buffer overflows. It uses only the features of vsnprintf
1168 that are common to both POSIX and native Microsoft.
1169 (tiff_error_handler, tiff_warning_handler): Use it.
1170 (tiff_load, gif_load, imagemagick_load_image):
1171 Don't assume :index value fits in 'int'.
1172 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1173 (imagemagick_load_image): Check that crop parameters fit into
1174 the integer types that MagickCropImage accepts. Don't assume
1175 Vimagemagick_render_type has a nonnegative value. Don't assume
1176 size_t fits in 'long'.
1177 (gs_load): Use printmax_t to print the widest integers possible.
1178 Check for integer overflow when computing image height and width.
1180 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1182 * xdisp.c (redisplay_window): Don't force window start if point
1183 will be invisible in the resulting window. (Bug#9324)
1185 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1187 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1188 the display spec is of the form `(space ...)'.
1189 (handle_display_spec): Return the value returned by
1190 handle_single_display_spec, not just 1 or zero.
1191 (handle_single_display_spec): If the display spec is of the form
1192 `(space ...)', and specifies display in the text area, return 2
1194 (try_cursor_movement): Check for the need to scroll more
1195 accurately, and prefer exact match for point under bidi.
1196 Don't advance `row' beyond the last row of the window.
1198 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1199 into disp_prop; all users changed.
1201 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1202 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1203 for the text covered by the display property.
1205 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1207 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1208 Change return value to nil.
1209 (Frecord_buffer): Delete unused function.
1211 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1213 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1214 buffers, return left-to-right.
1215 (set_cursor_from_row): Consider candidate row a win if its glyph
1216 represents a newline and point is on that newline. Fixes cursor
1217 positioning on the newline at EOL of R2L text within L2R
1218 paragraph, and vice versa.
1219 (try_cursor_movement): Check continued rows, in addition to
1220 continuation rows. Fixes unwarranted scroll when point enters a
1221 continued line of R2L text within an L2R paragraph, or vice versa.
1222 (cursor_row_p): Consider the case of point being equal to
1223 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1224 from the end of a short line to the beginning of a continued line
1225 of R2L text within L2R paragraph.
1226 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1227 composed characters.
1229 * bidi.c (bidi_check_type): Use xassert.
1230 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1233 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1235 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1238 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1240 * nsfont.m (ns_otf_to_script): Fix typo.
1242 2011-08-22 Kenichi Handa <handa@m17n.org>
1244 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1245 extra slot even if the purpose is char-code-property-table.
1247 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1249 * xdisp.c (redisplay_window): When computing centering_position,
1250 account for the height of the header line. (Bug#8874)
1252 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1253 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1254 candidate is selected by the mouse, and that candidate has a
1255 composed character under the mouse.
1257 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1258 coordinates reported by pos-visible-in-window-p for a composed
1259 character in column zero.
1261 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1263 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1265 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1267 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1268 consider it a hit if to_charpos is anywhere in the range of the
1269 composed buffer positions.
1271 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1273 * image.c (gif_load): Don't assume that each subimage has the same
1274 dimensions as the base image. Handle disposal method that is
1275 "undefined" by the gif spec (Bug#9335).
1277 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1279 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1280 (Fcondition_case): Document `debug' symbol in error handler.
1282 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1284 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1285 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1286 from an Org mode buffer to a Speedbar frame.
1288 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1289 a composition, take its buffer position from IT->cmp_it.charpos.
1290 Fixes cursor positioning at the beginning of a line that begins
1291 with a composed character.
1293 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1295 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1296 character bidirectional type, use STRONG_L instead. Fixes crashes
1297 in a buffer produced by `describe-categories'.
1299 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1300 members before the level stack, so they would be saved and
1301 restored when copying iterator state. Fixes incorrect reordering
1302 around TABs covered by display properties.
1304 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1306 * process.c (Fnetwork_interface_list): Correctly determine buffer
1309 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1311 * eval.c (internal_condition_case, internal_condition_case_1)
1312 (internal_condition_case_2, internal_condition_case_n):
1313 Remove unnecessary aborts (Bug#9081).
1315 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1317 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1318 has no `load' handler, try opening the file locally. (Bug#9311)
1320 2011-08-16 Ken Brown <kbrown@cornell.edu>
1322 * gmalloc.c: Expand comment.
1324 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1326 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1327 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1329 2011-08-16 Ken Brown <kbrown@cornell.edu>
1331 Fix memory allocation problems in Cygwin build (Bug#9273).
1333 * unexcw.c ( __malloc_initialized): Declare external variable.
1334 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1336 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1338 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1340 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1342 [CYGWIN] (special_realloc): New function.
1343 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1344 requests to realloc storage in the static heap.
1346 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1348 * bidi.c (bidi_initialize): Remove unused local.
1350 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1352 * biditype.h: File removed.
1354 * bidimirror.h: File removed.
1356 * deps.mk (bidi.o): Remove biditype.h and
1359 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1362 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1364 * chartab.c: Improve commentary for the uniprop_table API.
1366 * bidi.c (bidi_paragraph_init): Support zero value of
1367 bidi_ignore_explicit_marks_for_paragraph_level.
1368 (bidi_initialize): Use uniprop_table instead of including
1369 biditype.h and bidimirror.h.
1371 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1372 coordinates of the iterator when restoring from ppos_it.
1375 2011-08-14 Kenichi Handa <handa@m17n.org>
1377 * process.c (create_process): Call setup_process_coding_systems
1378 after the pid of the process is set to -1 (Bug#8162).
1380 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1382 * xdisp.c (move_it_in_display_line_to): Don't invoke
1383 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1384 ppos_it. Fixes vertical cursor motion when line beginning is
1385 covered by an image. (Bug#9296)
1387 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1389 * nsterm.h (ns_run_ascript): Declare.
1390 (NSAPP_DATA2_RUNASSCRIPT): Define.
1392 * nsfns.m (as_script, as_result, as_status): New static variables.
1393 (ns_run_ascript): New function.
1394 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1395 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1396 the event loop. Get status from as_status (Bug#7276).
1398 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1399 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1400 the event loop (Bug#7276).
1402 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1404 * gnutls.c (QCgnutls_bootprop_priority)
1405 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1406 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1407 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1408 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1409 (QCgnutls_bootprop_verify_hostname_error)
1410 (QCgnutls_bootprop_callbacks_verify): Rename from
1411 Qgnutls_bootprop_..., all uses changed.
1413 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1416 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1418 * xfaces.c (Qframe_set_background_mode): Now static.
1419 * dispextern.h (Qframe_set_background_mode): Remove decl.
1421 * process.c (Fnetwork_interface_info): Declare local only if needed.
1423 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1425 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1426 (Fnetwork_interface_list): Allocate in increments of bytes instead
1427 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1428 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1430 (struct ifflag_def): notrailers is smart on OSX.
1431 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1432 Get hardware address with getifaddrs if available.
1434 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1436 * xdisp.c (iterate_out_of_display_property): xassert that
1437 IT->position is set to within IT->object's boundaries. Break from
1438 the loop as soon as EOB is reached; avoids infloops in redisplay
1439 when IT->position is set up wrongly due to some bug.
1440 Set IT->current to match the bidi iterator unconditionally.
1441 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1442 entry. Force push_it to save on the stack the current
1443 buffer/string position, to be restored by pop_it. Fix flags in
1444 the iterator structure wrt the object coming from a display
1445 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1446 properties. (Bug#9284)
1448 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1450 * fontset.c (fontset_get_font_group): Add proper type checks.
1453 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1455 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1456 and LC_VERSION_MIN_MACOSX.
1457 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1458 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1460 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1462 * xdisp.c (forward_to_next_line_start): Allow to use the
1463 no-display-properties-and-no-overlays under bidi display.
1464 Set disp_pos in the bidi iterator to avoid searches for display
1465 properties and overlays.
1467 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1469 * editfns.c (Fset_time_zone_rule): Document relationship with the
1472 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1473 the font entity extracted from the cache (Bug#8109).
1475 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1477 * composite.c (autocmp_chars): Don't reset point. That is done by
1478 restore_point_unwind (Bug#5984).
1480 2011-08-07 Juri Linkov <juri@jurta.org>
1482 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1483 to show the arg `TIME' instead of `TIMEVAL'.
1485 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1487 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1488 display property strides EOL and includes a newline, as in
1489 longlines-mode. (Bug#9254)
1490 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1491 word-wrap under bidirectional display. (Bug#9224)
1493 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1494 is non-zero, even if the data buffer is NULL. Fixes a crash in
1495 vertical-motion with longlines-mode. (Bug#9254)
1497 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1499 * bidi.c <bidi_cache_total_alloc>: Now static.
1500 (bidi_initialize): Initialize bidi_cache_total_alloc.
1502 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1505 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1506 amount allocated this far in `bidi_cache_total_alloc'.
1507 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1508 non-zero, only free the data buffer without restoring the cache
1509 contents. All callers changed.
1511 * dispextern.h (bidi_unshelve_cache): Update prototype.
1513 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1514 (move_it_in_display_line, move_it_to)
1515 (move_it_vertically_backward, move_it_by_lines): Replace the call
1516 to xfree to an equivalent call to bidi_unshelve_cache.
1517 (move_it_in_display_line_to): Fix logic of returning
1518 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1520 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1522 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1523 came from a string character with a `cursor' property. (Bug#9229)
1525 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1527 * Makefile.in (LIB_PTHREAD): New variable.
1528 (LIBES): Add LIB_PTHREAD (Bug#9216).
1530 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1531 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1533 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1535 * regex.c (re_iswctype): Remove some redundant boolean
1538 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1540 * xterm.c (x_find_topmost_parent): New function.
1541 (x_set_frame_alpha): Find topmost parent window with
1542 x_find_topmost_parent and set the property there also (bug#9181).
1543 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1545 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1547 * callproc.c (Fcall_process): Avoid vfork clobbering
1548 the local vars buffer, coding_systems, current_dir.
1550 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1552 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1554 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1556 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1557 so that it is not optimized away.
1559 * xdisp.c (compute_display_string_pos): Remove unused local.
1561 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1563 Fix slow cursor motion and scrolling in large buffers with
1564 selective display, like Org Mode buffers. (Bug#9218)
1566 * dispextern.h (struct bidi_it): New member disp_prop_p.
1568 * xdisp.c: Remove one-slot cache of display string positions.
1569 (compute_display_string_pos): Accept an additional argument
1570 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1571 for a display string or property. If found, set DISP_PROP_P
1574 * bidi.c (bidi_fetch_char): Accept an additional argument
1575 DISP_PROP_P, and pass it to compute_display_string_pos.
1576 Only handle text covered by a display string if DISP_PROP_P is returned
1577 non-zero. All callers of bidi_fetch_char changed.
1579 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1581 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1583 2010-12-03 Don March <don@ohspite.net>
1585 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1586 last character M-[char] is translated to ESC [char] (bug#7541).
1588 2011-08-02 Kenichi Handa <handa@m17n.org>
1590 * lisp.h (uniprop_table): Extern it.
1592 * chartab.c (uniprop_table): Make it non-static.
1594 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1596 * xdisp.c (forward_to_next_line_start): Accept additional argument
1597 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1599 (reseat_at_next_visible_line_start): Use the bidi iterator state
1600 returned by forward_to_next_line_start to restore the state of
1601 it->bidi_it after backing up to previous newline. (Bug#9212)
1603 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1605 * regex.c (re_comp): Protoize.
1606 (re_exec): Fix return type.
1607 (regexec): Fix type of `ret'. (Bug#9203)
1609 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1611 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1612 This is needed if max-image-size is a floating-point number.
1614 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1616 * print.c (print_object): Print empty symbol as ##.
1618 * lread.c (read1): Read ## as empty symbol.
1620 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1622 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1623 setting frame foreground color (Bug#9175).
1624 (x_set_background_color): Likewise.
1626 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1627 contents (Bug#9176).
1628 (EmacsTooltip -init): Remove bezels and add shadows to
1631 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1632 or scroll bar (Bug#8470).
1634 * nsfont.m (nsfont_open): Remove assignment to voffset and
1635 unnecessary vars hshink, expand, hd, full_height, min_height.
1636 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1638 * nsterm.h (nsfont_info): Remove voffset field.
1640 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1642 Implement strike-through and overline on NextStep (Bug#8863).
1644 * nsfont.m (nsfont_open): Use underline position provided by font,
1645 instead of hard-coded value of 2.
1646 (nsfont_draw): Call ns_draw_text_decoration instead.
1648 * nsterm.h: Add declaration for ns_draw_text_decoration.
1650 * nsterm.m (ns_draw_text_decoration): New function for drawing
1651 underline, overline, and strike-through.
1652 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1653 ns_draw_text_decoration. Change treatment of cursor drawing to
1654 accommodate underlining, etc.
1656 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1658 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1661 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1663 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1664 Without this fix, if a signal arrives just after memory fills up,
1665 'malloc' might be invoked reentrantly.
1667 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1668 In other words, assume that every image size is allowed, on non-X
1669 hosts. This assumption is probably wrong, but it lets Emacs compile.
1671 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1673 * regex.c (re_iswctype): Convert return values to boolean.
1675 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1677 * xdisp.c (compute_display_string_pos): Don't use cached display
1678 string position if the buffer had its restriction changed.
1681 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1683 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1685 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1687 Integer signedness and overflow and related fixes. (Bug#9079)
1689 * bidi.c: Integer size and overflow fixes.
1690 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1691 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1692 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1693 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1694 (bidi_find_other_level_edge):
1695 Use ptrdiff_t instead of EMACS_INT where either will do.
1696 This works better on 32-bit hosts configured --with-wide-int.
1697 (bidi_cache_ensure_space): Check for size-calculation overflow.
1698 Use % rather than repeated addition, for better worst-case speed.
1699 Don't set bidi_cache_size until after xrealloc returns, because it
1701 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1702 (bidi_cache_ensure_space): Also check that the bidi cache size
1703 does not exceed that of the largest Lisp string or buffer. See Eli
1704 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1706 * alloc.c (__malloc_size_t): Remove.
1707 All uses replaced by size_t. See Andreas Schwab's note
1708 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1710 * image.c: Improve checking for integer overflow.
1711 (check_image_size): Assume that f is nonnull, since
1712 it is always nonnull in practice. This is one less thing to
1713 worry about when checking for integer overflow later.
1714 (x_check_image_size): New function, which checks for integer
1715 overflow issues inside X.
1716 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1717 This removes the need for a memory_full check.
1718 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1719 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1720 (xbm_read_bitmap_data): Change locals back to 'int', since
1721 their values must fit in 'int'.
1722 (xpm_load_image, png_load, tiff_load):
1723 Invoke x_create_x_image_and_pixmap earlier,
1724 to avoid much needless work if the image is too large.
1725 (tiff_load): Treat overly large images as if
1726 x_create_x_image_and_pixmap failed, not as malloc failures.
1727 (gs_load): Use x_check_image_size.
1729 * gtkutil.c: Omit integer casts.
1730 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1731 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1733 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1735 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1736 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1737 would wrongly return t on a 64-bit host.
1739 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1740 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1741 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1742 and therefore cause GCC to emit a bogus diagnostic in some cases.
1744 * image.c: Integer signedness and overflow and related fixes.
1745 This is not an exhaustive set of fixes, but it's time to
1746 record what I've got.
1747 (lookup_pixel_color, check_image_size): Remove redundant decls.
1748 (check_image_size): Don't assume that arbitrary EMACS_INT values
1749 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1750 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1751 (tiff_load, imagemagick_load_image):
1752 Check for overflow in size calculations.
1753 (x_create_x_image_and_pixmap): Remove unnecessary test for
1754 xmalloc returning NULL; that can't happen.
1755 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1756 (xpm_color_bucket): Use better integer hashing function.
1757 (xpm_cache_color): Don't possibly over-allocate memory.
1758 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1759 (gif_memory_source):
1760 Use ptrdiff_t, not int or size_t, to record sizes.
1761 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1762 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1763 either works, as we prefer signed integers.
1764 (tiff_read_from_memory, tiff_write_from_memory):
1765 Return tsize_t, not size_t, since that's what the TIFF API wants.
1766 (tiff_read_from_memory): Don't fail simply because the read would
1767 go past EOF; instead, return a short read.
1768 (tiff_load): Omit no-longer-needed casts.
1769 (Fimagemagick_types): Don't assume size fits into 'int'.
1771 Improve hashing quality when configured --with-wide-int.
1772 * fns.c (hash_string): New function, taken from sxhash_string.
1773 Do not discard information about ASCII character case; this
1774 discarding is no longer needed.
1775 (sxhash-string): Use it. Change sig to match it. Caller changed.
1776 * lisp.h: Declare it.
1777 * lread.c (hash_string): Remove, since we now use fns.c's version.
1778 The fns.c version returns a wider integer if --with-wide-int is
1779 specified, so this should help the quality of the hashing a bit.
1781 * emacs.c: Integer overflow minor fix.
1782 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1783 Define only if GNU_LINUX.
1784 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1786 * dispnew.c: Integer signedness and overflow fixes.
1787 Remove unnecessary forward decls, that were a maintenance hassle.
1788 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1790 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1791 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1792 (prepare_desired_row, line_draw_cost):
1793 Use int, not unsigned, where either works.
1794 (save_current_matrix, restore_current_matrix):
1795 Use ptrdiff_t, not size_t, where either works.
1796 (init_display): Check for overflow more accurately, and without
1797 relying on undefined behavior.
1799 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1800 Remove, replacing with the new symbols in lisp.h. All uses changed.
1801 * fileio.c (make_temp_name):
1802 * filelock.c (lock_file_1, lock_file):
1803 * xdisp.c (message_dolog):
1804 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1805 Use pMd etc. instead.
1806 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1807 replacing the pWIDE etc. symbols removed from editfns.c.
1809 * keyboard.h (num_input_events): Now uintmax_t.
1810 This is (very slightly) less likely to mess up due to wraparound.
1813 * buffer.c: Integer signedness fixes.
1814 (alloc_buffer_text, enlarge_buffer_text):
1815 Use ptrdiff_t rather than size_t when either will do, as we prefer
1818 * alloc.c: Integer signedness and overflow fixes.
1819 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1820 (__malloc_size_t): Default to size_t, not to int.
1821 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1822 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1823 Prefer ptrdiff_t to size_t when either would do, as we prefer
1825 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1826 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1827 Now const. Initialize with values that are in range even if char
1829 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1830 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1831 These functions do the right thing with sizes > 2**32.
1832 (check_depth): Now ptrdiff_t, not int.
1833 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1834 Adjust to new way of storing sizes. Check for size overflow bugs
1836 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1837 slightly wrong anyway, as it missed one instance of
1838 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1839 (refill_memory_reserve): Omit needless cast to size_t.
1840 (mark_object_loop_halt): Mark as externally visible.
1842 * xselect.c: Integer signedness and overflow fixes.
1843 (Fx_register_dnd_atom, x_handle_dnd_message):
1844 Use ptrdiff_t, not size_t, since we prefer signed.
1845 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1846 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1847 x_dnd_atoms_size and x_dnd_atoms_length.
1849 * doprnt.c: Prefer signed to unsigned when either works.
1851 * doprnt.c (doprnt):
1853 * xdisp.c (vmessage):
1854 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1855 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1856 prefer signed arithmetic to avoid comparison confusion.
1857 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1858 but is a bit tricky.
1860 Assume freestanding C89 headers, string.h, stdlib.h.
1861 * data.c, doprnt.c, floatfns.c, print.c:
1862 Include float.h unconditionally.
1863 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1864 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1865 * regex.c: Likewise for stddef.h, string.h.
1866 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1867 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1868 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1869 (STDC_HEADERS): Remove obsolete defines.
1870 * sysdep.c: Include limits.h unconditionally.
1872 Assume support for memcmp, memcpy, memmove, memset.
1873 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1874 * regex.c (memcmp, memcpy):
1875 Remove; we assume C89 now.
1877 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1878 (__malloc_safe_bcopy): Remove; no longer needed.
1880 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1881 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1882 well either way, and we prefer signed to unsigned.
1884 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1886 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1887 closes the connection while we're reading (bug#9182).
1889 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1891 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1892 are specified (Bug#9168).
1894 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1896 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1897 Found by GCC static checking and --with-wide-int on a 32-bit host.
1899 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1901 * xdisp.c (compute_display_string_pos): Fix logic of caching
1902 previous display string position. Initialize cached_prev_pos to
1903 -1. Fixes slow-down at the beginning of a buffer.
1905 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1907 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1908 for attrs[LFACE_FONTSET_INDEX].
1910 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1912 * xml.c (parse_region): Remove unused local
1913 that was recently introduced.
1915 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1917 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1918 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1920 * xdisp.c (move_it_in_display_line_to): Record the best matching
1921 position for TO_CHARPOS while scanning the line, and restore it on
1922 exit if none of the characters scanned was an exact match.
1923 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1924 when exact match is impossible due to invisible text, and the
1925 lines are truncated.
1927 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1929 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1932 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1934 Fix a significant slow-down of cursor motion with C-n, C-p,
1935 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1936 auto-repeat under bidi redisplay in fontified buffers.
1937 * xdisp.c (compute_stop_pos_backwards): New function.
1938 (next_element_from_buffer): Call compute_stop_pos_backwards to
1939 find a suitable prev_stop when we find ourselves before
1941 (reseat): Don't look for prev_stop, as that could mean a very long
1943 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1944 <cached_disp_overlay_modiff>: Cache for last found display string
1946 (compute_display_string_pos): Return the cached position if asked
1947 about the same buffer in the same area of character positions, and
1948 the buffer wasn't changed since the time the display string
1949 position was cached.
1951 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1953 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1954 is an integer, which is important for empty lines. (Bug#9149)
1956 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1958 * frame.c (Fmodify_frame_parameters): In tty case, update the
1959 default face if necessary (Bug#4238).
1961 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1963 * editfns.c (Fstring_to_char): No need to explain what a character
1964 is in the docstring (Bug#6576).
1966 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1968 * xml.c (parse_region): Make sure we always return a tree.
1970 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1972 * xml.c (parse_region): If a document contains only comments,
1975 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1977 * xml.c (make_dom): Return comments, too.
1979 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1982 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1983 and the surrounding thread.
1984 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1985 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1986 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1988 * s/openbsd.h (BROKEN_SIGIO): Define.
1989 * unexelf.c (unexec) [__OpenBSD__]:
1990 Don't update the .mdebug section of the Alpha COFF symbol table.
1992 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1994 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1997 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1999 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2000 This fixes some race conditions on the permissions of any newly
2003 * alloc.c (valid_pointer_p): Use pipe, not open.
2004 This fixes some permissions issues when debugging.
2006 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2007 If fchown fails to set both uid and gid, try to set just gid,
2008 as that is sometimes allowed. Adjust the file's mode to eliminate
2009 setuid or setgid bits that are inappropriate if fchown fails.
2011 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2013 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2014 to compare Lisp_Objects.
2015 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2016 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2017 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2019 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2021 * lread.c (read_integer): Unread even EOF character.
2022 (read1): Likewise. Properly record start position of symbol.
2024 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2025 symbol character follows.
2027 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2029 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2030 This works around a problem with the previous change to Fcopy_file.
2031 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2032 and without this change, GCC might complain about discarding
2033 fchown's return value.
2035 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
2037 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2039 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2041 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2043 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2045 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2046 it's used from the C level.
2048 * process.c: Use the same condition for POLL_FOR_INPUT in both
2049 keyboard.c and process.c (bug#1858).
2051 2011-07-09 Lawrence Mitchell <wence@gmx.li>
2053 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2054 (Fgnutls_boot): Use it.
2056 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2058 * doc.c (Fsubstitute_command_keys): Revert last change.
2060 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2062 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2063 quotes the next character, and doesn't affect other longer
2064 sequences (bug#8935).
2066 * lread.c (syms_of_lread): Clarify that is isn't only
2067 `eval-buffer' and `eval-defun' that's affected by
2068 `lexical-binding' (bug#8460).
2070 2011-07-15 Eli Zaretskii <eliz@gnu.org>
2072 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2073 bidi redisplay when a line includes both an image and is
2076 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2078 Fix minor problems found by static checking.
2079 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2080 (elsz): Now a signed constant, not a size_t var. We prefer signed
2081 types to unsigned, to avoid integer comparison confusion. Without
2082 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2083 "cannot optimize loop, the loop counter may overflow", a symptom
2085 * indent.c (Fvertical_motion): Mark locals as initialized.
2086 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2088 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2090 * search.c (Fre_search_backward): Mention `case-fold-search' in
2091 all the re_search_* functions (bug#8138).
2093 * keyboard.c (Fopen_dribble_file): Document when the file is
2096 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2098 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2101 Support bidi reordering of display and overlay strings.
2102 * xdisp.c (compute_display_string_pos)
2103 (compute_display_string_end): Accept additional argument STRING.
2104 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2105 (reseat_to_string): Initialize bidi_it->string.s and
2106 bidi_it->string.schars.
2107 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2108 NULL (avoids a crash in bidi_paragraph_init).
2109 Initialize itb.string.lstring.
2110 (init_iterator): Call bidi_init_it only of a valid
2111 buffer position was specified. Initialize paragraph_embedding to
2113 (reseat_to_string): Initialize the bidi iterator.
2114 (display_string): If we need to ignore text properties of
2115 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2116 original value of -1 will not work with bidi.)
2117 (compute_display_string_pos): First arg is now struct
2118 `text_pos *'; all callers changed. Support display properties on
2120 (compute_display_string_end): Support display properties on Lisp
2122 (init_iterator, reseat_1, reseat_to_string): Initialize the
2123 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2124 when iterating on a string not from display properties).
2125 (compute_display_string_pos, compute_display_string_end):
2126 Fix calculation of the object to scan. Fixes an error when using
2128 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2129 base_level_stop; instead, set base_level_stop to BEGV.
2130 Fixes crashes in vertical-motion.
2131 (next_element_from_buffer): Improve commentary for when
2132 the iterator is before prev_stop.
2133 (init_iterator): Initialize bidi_p from the default value of
2134 bidi-display-reordering, not from buffer-local value. Use the
2135 buffer-local value only if initializing for buffer iteration.
2136 (handle_invisible_prop): Support invisible properties on strings
2137 that are being bidi-reordered.
2138 (set_iterator_to_next): Support bidi reordering of C strings and
2140 (next_element_from_string): Support bidi reordering of Lisp
2142 (handle_stop_backwards): Support Lisp strings as well.
2143 (display_string): Support display of R2L glyph rows.
2144 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2145 (init_iterator): Don't initialize it->bidi_p for strings
2147 (reseat_to_string): Initialize it->bidi_p for strings here.
2148 (next_element_from_string, next_element_from_c_string)
2149 (next_element_from_buffer): Add xassert's for correspondence
2150 between IT's object being iterated and it->bidi_it.string
2152 (face_before_or_after_it_pos): Support bidi iteration.
2153 (next_element_from_c_string): Handle the case of the first string
2154 character that is not the first one in the visual order.
2155 (get_visually_first_element): New function, refactored from common
2156 parts of next_element_from_buffer, next_element_from_string, and
2157 next_element_from_c_string.
2158 (tool_bar_lines_needed, redisplay_tool_bar)
2159 (display_menu_bar): Force left-to-right direction. Add a FIXME
2160 comment for making that be controlled by a user option.
2161 (push_it, pop_it): Save and restore the state of the
2162 bidi iterator. Save and restore the bidi_p flag.
2163 (pop_it): Iterate out of display property for string iteration as
2165 (iterate_out_of_display_property): Support iteration over strings.
2166 (handle_single_display_spec): Set up it->bidi_it for iteration
2167 over a display string, and call bidi_init_it.
2168 (handle_single_display_spec, next_overlay_string)
2169 (get_overlay_strings_1, push_display_prop): Set up the bidi
2170 iterator for displaying display or overlay strings.
2171 (forward_to_next_line_start): Don't use the shortcut if
2173 (back_to_previous_visible_line_start): If handle_display_prop
2174 pushed the iterator stack, restore the internal state of the bidi
2175 iterator by calling bidi_pop_it same number of times.
2176 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2177 and we are bidi-iterating, don't decrement the iterator position;
2178 instead, set the first_elt flag in the bidi iterator, to produce
2180 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2181 (push_display_prop): xassert that we are iterating a buffer.
2182 (push_it, pop_it): Save and restore paragraph_embedding member.
2183 (handle_single_display_spec, next_overlay_string)
2184 (get_overlay_strings_1, reseat_1, reseat_to_string)
2185 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2186 correctly. Don't assume unibyte strings are not bidi-reordered.
2187 (compute_display_string_pos)
2188 (compute_display_string_end): Fix handling the case of C string.
2189 (push_it, pop_it): Save and restore from_disp_prop_p.
2190 (handle_single_display_spec, push_display_prop): Set the
2191 from_disp_prop_p flag.
2192 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2193 (pop_it): Call iterate_out_of_display_property only if we are
2194 popping after iteration over a string that came from a display
2195 property. Fix a typo in popping stretch info. Add an assertion
2196 for verifying that the iterator position is in sync with the bidi
2198 (handle_single_display_spec, get_overlay_strings_1)
2199 (push_display_prop): Fix initialization of paragraph direction for
2200 string when that of the parent object is not yet determined.
2201 (reseat_1): Call bidi_init_it to resync the bidi
2202 iterator with IT's position. (Bug#7616)
2203 (find_row_edges): If ROW->start.pos gives position
2204 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2205 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2206 Reset the from_disp_prop_p flag.
2207 (SAVE_IT, RESTORE_IT): New macros.
2208 (pos_visible_p, face_before_or_after_it_pos)
2209 (back_to_previous_visible_line_start)
2210 (move_it_in_display_line_to, move_it_in_display_line)
2211 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2212 (try_scrolling, redisplay_window, display_line): Use them when
2213 saving a temporary copy of the iterator and restoring it back.
2214 (back_to_previous_visible_line_start, reseat_1)
2215 (init_iterator): Empty the bidi cache "stack".
2216 (move_it_in_display_line_to): If iterator ended up at
2217 EOL, but we never saw any buffer positions smaller than
2218 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2219 motion in bidi-reordered lines.
2220 (move_it_in_display_line_to): Record prev_method and prev_pos
2221 immediately before the call to set_iterator_to_next. Fixes cursor
2222 motion in bidi-reordered lines with stretch glyphs and strings
2223 displayed in margins. (Bug#8133) (Bug#8867)
2224 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2226 (pos_visible_p): Support positions in bidi-reordered lines.
2227 Save and restore bidi cache.
2229 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2230 (bidi_paragraph_info): Delete unused struct.
2231 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2232 (bidi_cache_start): New variable.
2233 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2235 (bidi_cache_fetch_state, bidi_cache_search)
2236 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2237 (bidi_cache_find, bidi_peek_at_next_level)
2238 (bidi_level_of_next_char, bidi_find_other_level_edge)
2239 (bidi_move_to_visually_next): Compare cache index with
2240 bidi_cache_start rather than with zero.
2241 (bidi_fetch_char): Accept new argument STRING; all callers
2242 changed. Support iteration over a string. Support strings with
2243 display properties. Support unibyte strings. Fix the type of
2244 `len' according to what STRING_CHAR_AND_LENGTH expects.
2245 (bidi_paragraph_init, bidi_resolve_explicit_1)
2246 (bidi_resolve_explicit, bidi_resolve_weak)
2247 (bidi_level_of_next_char, bidi_move_to_visually_next):
2248 Support iteration over a string.
2249 (bidi_set_sor_type, bidi_resolve_explicit_1)
2250 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2251 can now be zero (for strings); special values 0 and -1 were
2252 changed to -1 and -2, respectively.
2253 (bidi_char_at_pos): New function.
2254 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2255 Call it instead of FETCH_MULTIBYTE_CHAR.
2256 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2257 initialized to valid values.
2258 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2260 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2261 the test for valid cached positions. Fix the logic for looking up
2262 the sentinel state in the cache. GCPRO the Lisp string we are
2264 (bidi_push_it, bidi_pop_it): New functions.
2265 (bidi_initialize): Initialize the bidi cache start stack pointer.
2266 (bidi_cache_ensure_space): New function, refactored from part of
2267 bidi_cache_iterator_state. Don't assume the required size is just
2268 one BIDI_CACHE_CHUNK away.
2269 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2270 (bidi_count_bytes, bidi_char_at_pos): New functions.
2271 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2272 always valid if bidi_cache_idx is valid.
2273 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2274 is valid if it's going to be used.
2275 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2276 (bidi_cache_fetch_state, bidi_cache_search)
2277 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2278 (bidi_cache_iterator_state, bidi_cache_find)
2279 (bidi_find_other_level_edge, bidi_cache_start_stack):
2280 All variables related to cache indices are now EMACS_INT.
2282 * dispextern.h (struct bidi_string_data): New structure.
2283 (struct bidi_it): New member `string'. Make flag members be 1-bit
2284 fields, and put them last in the struct.
2285 (compute_display_string_pos, compute_display_string_end):
2287 (bidi_push_it, bidi_pop_it): Add prototypes.
2288 (struct iterator_stack_entry): New members bidi_p,
2289 paragraph_embedding, and from_disp_prop_p.
2290 (struct it): Member bidi_p is now a bit field 1 bit wide.
2291 (bidi_shelve_cache, bidi_unshelve_cache):
2294 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2295 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2296 and vector-like objects.
2298 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2299 cache around display iteration.
2301 * window.c (Fwindow_end, window_scroll_pixel_based)
2302 (displayed_window_lines, Frecenter): Save and restore the bidi
2303 cache around display iteration.
2305 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2307 * editfns.c (Fdelete_region): Clarify the use of the named
2308 parameters (bug#6788).
2310 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2312 * indent.c (Fvertical_motion): Set and restore w->pointm when
2313 saving and restoring the window's buffer (Bug#9006).
2315 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2317 * editfns.c (Fstring_to_char): Clarify just what is returned
2318 (bug#6576). Text by Eli Zaretskii.
2320 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2322 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2324 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2326 * buffer.c (mmap_find): Fix a typo.
2328 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2330 Fix execution of x selection hooks.
2331 * xselect.c (Qx_lost_selection_functions)
2332 (Qx_sent_selection_functions): New vars.
2333 (syms_of_xselect): DEFSYM them.
2334 (x_handle_selection_request): Pass Qx_sent_selection_functions
2335 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2336 (x_handle_selection_clear,x_clear_frame_selections):
2337 Pass Qx_lost_selection_functions rather than
2338 Vx_lost_selection_functions to Frun_hook_with_args.
2340 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2342 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2343 The old code sometimes used this field without initializing it.
2345 * alloc.c (gc_sweep): Don't read past end of array.
2346 In theory, the old code could also have corrupted Emacs internals,
2347 though it'd be very unlikely.
2349 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2351 * character.c (Fcharacterp): Don't advertise optional ignored
2352 argument. (Bug#4026)
2354 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2356 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2359 * window.c (Fset_window_start): Doc fix (bug#4199).
2360 (Fset_window_hscroll): Ditto.
2362 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2364 Fix minor new problems caught by GCC 4.6.1.
2365 * term.c (init_tty): Remove unused local.
2366 * xsettings.c (store_monospaced_changed): Define this function only
2367 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2370 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2372 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2374 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2376 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2377 are the mini-buffer and the echo area (bug#3320).
2379 * term.c (init_tty): Remove support for supdup, c10 and perq
2380 terminals, which are no longer supported (bug#1482).
2382 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2384 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2386 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2388 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2389 for non-popups (Bug#3642).
2391 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2393 * alloc.c (reset_malloc_hooks): Protoize.
2394 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2395 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2396 * cm.c (losecursor): Likewise.
2397 * data.c (fmod): Likewise.
2398 * dispnew.c (swap_glyphs_in_rows): Likewise.
2399 * emacs.c (memory_warning_signal): Likewise.
2400 * floatfns.c (float_error): Likewise.
2401 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2402 (otf_open, font_otf_capability, generate_otf_features)
2403 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2405 * image.c (pbm_read_file): Likewise.
2406 * indent.c (string_display_width): Likewise.
2407 * intervals.c (check_for_interval, search_for_interval)
2408 (inc_interval_count, count_intervals, root_interval)
2409 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2410 * lread.c (defalias): Likewise.
2411 * ralloc.c (r_alloc_check): Likewise.
2412 * regex.c (set_image_of_range_1, set_image_of_range)
2413 (regex_grow_registers): Likewise.
2414 * sysdep.c (strerror): Likewise.
2415 * termcap.c (valid_filename_p, tprint, main): Likewise.
2416 * tparam.c (main): Likewise.
2417 * unexhp9k800.c (run_time_remap, save_data_space)
2418 (update_file_ptrs, read_header, write_header, calculate_checksum)
2419 (copy_file, copy_rest, display_header): Likewise.
2420 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2422 * xdisp.c (check_it): Likewise.
2423 * xfaces.c (register_color, unregister_color, unregister_colors):
2425 * xfns.c (print_fontset_result): Likewise.
2426 * xrdb.c (member, fatal, main): Likewise.
2428 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2430 Fix minor problems found by static checking (Bug#9031).
2431 * chartab.c (char_table_set_range, map_sub_char_table):
2432 Remove unused locals.
2433 (uniprop_table): Now static.
2434 * composite.c (_work_char): Remove unused static var.
2436 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2438 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2440 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2442 * gtkutil.c (qttip_cb): Remove code without function.
2444 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2446 * w32.c (pthread_sigmask): New stub.
2448 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2450 Use pthread_sigmask, not sigprocmask (Bug#9010).
2451 sigprocmask is portable only for single-threaded applications, and
2452 Emacs can be multi-threaded when it uses GTK.
2453 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2455 * callproc.c (Fcall_process):
2456 * process.c (create_process):
2457 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2458 Use pthread_sigmask, not sigprocmask.
2460 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2462 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2463 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2466 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2468 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2469 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2470 (xg_hide_tooltip): Fix comment.
2472 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2473 in registerServicesMenuSendTypes.
2474 (validRequestorForSendType): Don't check ns_return_types.
2476 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2479 2011-07-08 Jason Rumney <jasonr@gnu.org>
2481 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2482 frame struct members of non-existent frames (Bug#6284).
2484 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2486 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2487 variable firstTime not needed on OSX >= 10.6.
2488 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2489 >= 10.5. Use setKnobProportion, setDoubleValue.
2491 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2492 (MAC_OS_X_VERSION_10_5): Define if not defined.
2493 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2494 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2495 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2497 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2498 cString and lossyCString on OSX >= 10.4
2500 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2501 sizeToFit on OSX >= 10.2.
2503 * nsimage.m (allocInitFromFile): Don't use deprecated method
2504 bestRepresentationForDevice on OSX >= 10.6.
2506 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2509 * emacs.c: Declare unexec_init_emacs_zone.
2511 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2513 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2515 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2516 on svcsMenu (Bug#8842).
2518 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2520 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2522 * nsterm.m (QUTF8_STRING): Declare.
2523 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2524 (validRequestorForSendType): Return type is (id).
2525 Change indexOfObjectIdenticalTo to indexOfObject.
2526 Check if we have local selection before returning self (Bug#8842).
2527 (writeSelectionToPasteboard): Put local selection into paste board
2528 if we have a local selection (Bug#8842).
2529 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2531 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2532 (ns_get_local_selection): Declare.
2534 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2536 * keymap.c (describe_map_tree): Don't insert a double newline at
2537 the end of the buffer (bug#1169) and return whether we inserted
2540 * callint.c (Fcall_interactively): Change "reading args" to
2541 "providing args" to try to clarify what it does (bug#1010).
2543 2011-07-07 Kenichi Handa <handa@m17n.org>
2545 * composite.c (composition_compute_stop_pos): Ignore a static
2546 composition starting before CHARPOS (Bug#8915).
2548 * xdisp.c (handle_composition_prop): Likewise.
2550 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2552 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2555 2011-07-07 Kenichi Handa <handa@m17n.org>
2557 * character.h (unicode_category_t): New enum type.
2559 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2560 (Qchar_code_property_table): New variable.
2561 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2562 (UNIPROP_COMPRESSED_FORM_P): New macros.
2563 (char_table_ascii): Uncompress the compressed values.
2564 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2565 Uncompress the compressed values.
2566 (sub_char_table_ref_and_range): Likewise.
2567 (char_table_ref_and_range): Uncompress the compressed values.
2568 (sub_char_table_set): New arg is_uniprop. Callers changed.
2569 Uncompress the compressed values.
2570 (sub_char_table_set_range): Args changed. Callers changed.
2571 (char_table_set_range): Adjuted for the above change.
2572 (map_sub_char_table): Delete args default_val and parent. Add arg
2573 top. Give decoded values to a Lisp function.
2574 (map_char_table): Adjust for the above change. Give decoded
2575 values to a Lisp function. Gcpro more variables.
2576 (uniprop_table_uncompress)
2577 (uniprop_decode_value_run_length): New functions.
2578 (uniprop_decoder, uniprop_decoder_count): New variables.
2579 (uniprop_get_decoder, uniprop_encode_value_character)
2580 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2582 (uniprop_encoder, uniprop_encoder_count): New variables.
2583 (uniprop_get_encoder, uniprop_table)
2584 (Funicode_property_table_internal, Fget_unicode_property_internal)
2585 (Fput_unicode_property_internal): New functions.
2586 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2587 Sunicode_property_table_internal, Sget_unicode_property_internal,
2588 and Sput_unicode_property_internal. Defvar_lisp
2589 char-code-property-alist.
2591 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2592 Vunicode_category_table.
2594 * font.c (font_range): Adjust for the change of
2595 Vunicode_category_table.
2597 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2599 * m/iris4d.h: Remove file, move contents ...
2600 * s/irix6-5.h: ... here.
2602 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2604 Remove unportable assumption about struct layout (Bug#8884).
2605 * alloc.c (mark_buffer):
2606 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2607 (clone_per_buffer_values): Don't assume that
2608 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2609 This isn't true in general, and it's particularly not true
2610 if Emacs is configured with --with-wide-int.
2611 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2612 New macros, used in the buffer.c change.
2614 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2616 * xsettings.c: Use both GConf and GSettings if both are available.
2617 (store_config_changed_event): Add comment.
2618 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2619 (store_tool_bar_style_changed): New functions.
2620 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2621 (struct xsettings): Move font inside HAVE_XFT.
2622 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2623 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2624 Move inside HAVE_XFT.
2625 (something_changed_gsettingsCB): Rename from something_changedCB.
2626 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2628 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2629 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2630 (something_changed_gconfCB): Rename from something_changedCB.
2631 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2632 (parse_settings): Move check for font inside HAVE_XFT.
2633 (read_settings, apply_xft_settings): Add comment.
2634 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2635 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2636 call store_font_name_changed.
2637 (xft_settings_event): Add comment.
2638 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2639 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2640 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2641 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2642 (xsettings_initialize): Call init_gsettings last.
2643 (xsettings_get_system_font, xsettings_get_system_normal_font):
2646 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2648 Random fixes. E.g., (random) never returned negative values.
2649 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2650 subseconds part to the entropy, as that's a bit more random.
2651 Prefer signed to unsigned, since the signedness doesn't matter and
2652 in general we prefer signed. When given a limit, use a
2653 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2654 latter isn't right if USE_2_TAGS_FOR_INTS.
2655 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2656 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2658 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2660 * textprop.c (text_property_stickiness):
2661 Obey Vtext_property_default_nonsticky.
2662 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2663 * w32fns.c (syms_of_w32fns):
2664 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2666 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2668 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2669 This is more efficient than Ffile_directory_p and avoids a minor race.
2671 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2673 * buffer.c (Foverlay_put): Say what the return value is
2676 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2677 is a directory before asking whether to use the file name
2679 (barf_or_query_if_file_exists): Make the "File is a directory"
2680 error be more correct.
2682 * fns.c (Frequire): Remove the mention of the .gz files, since
2683 that's installation-specific, but keep the mention of
2684 `get-load-suffixes'.
2686 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2688 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2689 Report string overflow if the output is too long.
2691 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2693 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2694 (syms_of_gnutls): Remove duplicate DEFSYM for
2695 Qgnutls_bootprop_verify_hostname_error, an error for
2696 Qgnutls_bootprop_verify_error (which is no longer used).
2698 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2699 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2700 Also (re)move comments that are misplaced or no longer relevant.
2702 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2704 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2706 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2708 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2709 and background color parameters if they have been changed.
2711 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2713 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2715 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2717 * xsettings.c (SYSTEM_FONT): Define only when used.
2718 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2720 * keymap.c (access_keymap_1): Now static.
2722 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2724 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2725 leave any prefix arg for the up event (Bug#1586).
2727 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2729 * lread.c (syms_of_lread): Mention single symbols defined by
2730 `defvar' or `defconst' (bug#7154).
2732 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2733 (Frequire): Mention get-load-suffixes.
2735 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2737 * window.h (window): Remove clone_number slot.
2738 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2740 (make_parent_window, make_window, saved_window)
2741 (Fset_window_configuration, save_window_save): Don't deal with
2743 * buffer.c (Qclone_number): Remove declaration.
2744 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2746 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2748 Add multiple inheritance to keymaps.
2749 * keymap.c (Fmake_composed_keymap): New function.
2750 (Fset_keymap_parent): Simplify.
2751 (fix_submap_inheritance): Remove.
2752 (access_keymap_1): New function extracted from access_keymap to handle
2753 embedded parents and handle lists of maps.
2754 (access_keymap): Use it.
2755 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2756 (Fcopy_keymap): Handle embedded parents.
2757 (Fcommand_remapping, define_as_prefix): Simplify.
2758 (Fkey_binding): Simplify.
2759 (syms_of_keymap): Move minibuffer-local-completion-map,
2760 minibuffer-local-filename-completion-map,
2761 minibuffer-local-must-match-map, and
2762 minibuffer-local-filename-must-match-map to Elisp.
2763 (syms_of_keymap): Defsubr make-composed-keymap.
2764 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2765 (parse_menu_item): Trivial simplification.
2767 2011-07-01 Glenn Morris <rgm@gnu.org>
2769 * Makefile.in (SETTINGS_LIBS): Fix typo.
2771 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2773 * coding.c (Fencode_coding_string): Record the last coding system
2774 used, as the function doc string says (bug#8738).
2776 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2778 * xsettings.c (store_monospaced_changed): Take new font as arg and
2779 check for change against current_mono_font.
2780 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2781 (emacs_settings_constructor, emacs_settings_get_property)
2782 (emacs_settings_set_property, emacs_settings_class_init)
2783 (emacs_settings_init, gsettings_obj): Remove.
2784 (something_changedCB): New function for HAVE_GSETTINGS.
2785 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2786 with value as argument.
2787 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2788 g_settings_new (Bug#8967). Do not create gsettings_obj.
2789 Remove calls to g_settings_bind. Connect something_changedCB to
2792 * xgselect.c: Add defined (HAVE_GSETTINGS).
2793 (xgselect_initialize): Ditto.
2795 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2796 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2799 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2801 * eval.c (struct backtrace): Simplify and port the data structure.
2802 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2803 signed bit field, as this assumption is not portable and it makes
2804 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2805 "char debug_on_exit : 1" as this is not portable either; instead,
2806 use the portable "unsigned int debug_on_exit : 1". Remove unused
2807 member evalargs. Remove obsolete comments about cc bombing out.
2809 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2811 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2812 Let HAVE_GSETTINGS override HAVE_GCONF.
2813 (store_monospaced_changed): New function.
2814 (EMACS_SETTINGS): A new type derived from GObject to handle
2815 GSettings notifications.
2816 (emacs_settings_constructor, emacs_settings_get_property)
2817 (emacs_settings_set_property, emacs_settings_class_init):
2819 (gsettings_client, gsettings_obj): New variables.
2820 (GSETTINGS_SCHEMA): New define.
2821 (something_changedCB): Call store_monospaced_changed.
2822 (init_gsettings): New function.
2823 (xsettings_initialize): Call init_gsettings.
2824 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2827 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2830 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2832 * window.c (resize_root_window, grow_mini_window)
2833 (shrink_mini_window): Rename Qresize_root_window to
2834 Qwindow_resize_root_window and Qresize_root_window_vertically to
2835 Qwindow_resize_root_window_vertically.
2837 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2839 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2841 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2843 * makefile.w32-in: Redesign dependencies so they reflect more
2844 clearly which files are directly included by each source file,
2845 and not through other includes.
2847 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2849 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2850 (sort_overlays, overlay_strings): When an overlay's clone number
2851 matches the window's clone number process the overlay even if
2852 the overlay's window property doesn't match the current window.
2854 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2855 (Fwindow_hchild): Rename to Fwindow_left_child.
2856 (Fwindow_next): Rename to Fwindow_next_sibling.
2857 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2858 (resize_window_check): Rename to window_resize_check.
2859 (resize_window_apply): Rename to window_resize_apply.
2860 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2861 (Fdelete_other_windows_internal, resize_frame_windows)
2862 (Fsplit_window_internal, Fdelete_window_internal)
2863 (grow_mini_window, shrink_mini_window)
2864 (Fresize_mini_window_internal): Fix callers accordingly.
2866 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2868 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2869 (emacs_fixed_set_min_size): Remove.
2870 (emacs_fixed_new): Take frame as argument.
2872 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2873 (_EmacsFixedPrivate): Remove minwidth/height.
2874 Add struct frame *f.
2875 (emacs_fixed_init): Initialize priv->f.
2876 (get_parent_class, emacs_fixed_set_min_size): Remove.
2877 (emacs_fixed_new): Set priv->f to argument.
2878 (emacs_fixed_get_preferred_width)
2879 (emacs_fixed_get_preferred_height): Use min_width/height from
2880 frames size_hint to set minimum and natural (Bug#8919).
2881 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2882 and use min_width/height from frames size_hint to set
2883 min_width/height (Bug#8919).
2885 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2886 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2889 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2891 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2892 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2895 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2897 * process.c (wait_reading_process_output): Bypass select if
2898 waiting for a cell while ignoring keyboard input, and input is
2899 pending. Suggested by Jan Djärv (Bug#8869).
2901 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2903 Use gnulib's dup2 module instead of rolling our own.
2904 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2906 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2908 * dispnew.c (scrolling_window): Before scrolling, turn off a
2909 mouse-highlight in the window being scrolled.
2911 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2913 Move DEFSYM to lisp.h and use everywhere.
2915 * character.h (DEFSYM): Move declaration...
2916 * lisp.h (DEFSYM): ...here.
2922 * w32select.c: Don't include character.h.
2924 * alloc.c (syms_of_alloc):
2925 * buffer.c (syms_of_buffer):
2926 * bytecode.c (syms_of_bytecode):
2927 * callint.c (syms_of_callint):
2928 * casefiddle.c (syms_of_casefiddle):
2929 * casetab.c (init_casetab_once):
2930 * category.c (init_category_once, syms_of_category):
2931 * ccl.c (syms_of_ccl):
2932 * cmds.c (syms_of_cmds):
2933 * composite.c (syms_of_composite):
2934 * dbusbind.c (syms_of_dbusbind):
2935 * dired.c (syms_of_dired):
2936 * dispnew.c (syms_of_display):
2937 * doc.c (syms_of_doc):
2938 * editfns.c (syms_of_editfns):
2939 * emacs.c (syms_of_emacs):
2940 * eval.c (syms_of_eval):
2941 * fileio.c (syms_of_fileio):
2942 * fns.c (syms_of_fns):
2943 * frame.c (syms_of_frame):
2944 * fringe.c (syms_of_fringe):
2945 * insdel.c (syms_of_insdel):
2946 * keymap.c (syms_of_keymap):
2947 * lread.c (init_obarray, syms_of_lread):
2948 * macros.c (syms_of_macros):
2949 * msdos.c (syms_of_msdos):
2950 * print.c (syms_of_print):
2951 * process.c (syms_of_process):
2952 * search.c (syms_of_search):
2953 * sound.c (syms_of_sound):
2954 * syntax.c (init_syntax_once, syms_of_syntax):
2955 * terminal.c (syms_of_terminal):
2956 * textprop.c (syms_of_textprop):
2957 * undo.c (syms_of_undo):
2958 * w32.c (globals_of_w32):
2959 * window.c (syms_of_window):
2960 * xdisp.c (syms_of_xdisp):
2961 * xfaces.c (syms_of_xfaces):
2962 * xfns.c (syms_of_xfns):
2963 * xmenu.c (syms_of_xmenu):
2964 * xsettings.c (syms_of_xsettings):
2965 * xterm.c (syms_of_xterm): Use DEFSYM.
2967 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2969 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2971 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2973 Integer and buffer overflow fixes (Bug#8873).
2975 * print.c (printchar, strout): Check for string overflow.
2976 (PRINTPREPARE, printchar, strout):
2977 Don't set size unless allocation succeeds.
2979 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2980 for sizes. Check for string overflow more accurately.
2981 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2983 * macros.c: Integer and buffer overflow fixes.
2984 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2985 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2986 Use ptrdiff_t, not int, for sizes.
2987 Don't increment bufsize until after realloc succeeds.
2988 Check for size-calculation overflow.
2989 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2991 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2993 * lread.c: Integer overflow fixes.
2994 (read_integer): Radix is now EMACS_INT, not int,
2995 to improve quality of diagnostics for out-of-range radices.
2996 Calculate buffer size correctly for out-of-range radices.
2997 (read1): Check for integer overflow in radices, and in
2998 read-circle numbers.
2999 (read_escape): Avoid int overflow.
3000 (Fload, openp, read_buffer_size, read1)
3001 (substitute_object_recurse, read_vector, read_list, map_obarray):
3002 Use ptrdiff_t, not int, for sizes.
3003 (read1): Use EMACS_INT, not int, for sizes.
3004 Check for size overflow.
3006 * image.c (cache_image): Check for size arithmetic overflow.
3008 * lread.c: Integer overflow issues.
3009 (saved_doc_string_size, saved_doc_string_length)
3010 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3011 Now ptrdiff_t, not int.
3012 (read1): Don't assume doc string length fits in int. Check for
3013 out-of-range doc string lengths.
3014 (read_list): Don't assume file position fits in int.
3015 (read_escape): Check for hex character overflow.
3017 2011-06-22 Leo Liu <sdl.web@gmail.com>
3019 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3020 Move to minibuffer.el.
3022 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3024 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
3025 The following patches are for when GLYPH_DEBUG && !XASSERT.
3026 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3027 * dispnew.c (flush_stdout):
3028 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3029 Mark as externally visible.
3030 * dispnew.c (check_window_matrix_pointers): Now static.
3031 * dispnew.c (window_to_frame_vpos):
3032 * xfns.c (unwind_create_frame):
3033 * xterm.c (x_check_font): Remove unused local.
3034 * scroll.c (CHECK_BOUNDS):
3035 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3036 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3037 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3038 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3039 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3041 (debug_method_add): Use va_list and vsprintf rather than relying
3042 on undefined behavior with wrong number of arguments.
3043 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3044 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3045 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3046 since we're not interested in debugging glyphs with old libraries.
3047 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3048 GCC 4.6.0's static checking.
3050 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3052 Integer overflow and signedness fixes (Bug#8873).
3053 A few related buffer overrun fixes, too.
3055 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3057 * dispextern.h (struct face.stipple):
3058 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3059 (x_bitmap_mask, x_allocate_bitmap_record)
3060 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3061 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3062 (x_create_bitmap_from_xpm_data):
3063 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3064 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3066 * xfaces.c (load_pixmap):
3067 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3068 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3069 (.bitmaps_last, struct x_output.icon_bitmap):
3070 Use ptrdiff_t, not int, for bitmap indexes.
3071 (x_allocate_bitmap_record): Check for size overflow.
3072 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3074 Use ptrdiff_t, not int, for overlay counts.
3075 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3076 * editfns.c (overlays_around, get_pos_property):
3077 * textprop.c (get_char_property_and_overlay):
3078 * xdisp.c (next_overlay_change, note_mouse_highlight):
3079 * xfaces.c (face_at_buffer_position):
3080 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3081 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3082 (Fnext_overlay_change, Fprevious_overlay_change)
3083 (mouse_face_overlay_overlaps, Foverlays_in):
3084 Use ptrdiff_t, not int, for sizes.
3085 (overlays_at, overlays_in): Check for size-calculation overflow.
3087 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3089 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3090 (x_session_initialize): Do not assume string length fits in int.
3092 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3093 This is unlikely, but can occur if DPI is outlandish.
3095 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3096 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3098 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3099 * xrdb.c (magic_file_p, search_magic_path):
3100 Omit last arg SUFFIX; it was always 0. All callers changed.
3101 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3103 * xfont.c (xfont_match): Avoid need for strlen.
3105 * xfns.c: Don't assume strlen fits in int.
3106 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3108 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3109 not unsigned long, as we prefer signed integers. All callers changed.
3110 Detect integer overflow in repeat count.
3111 (message_dolog): Don't assume print length fits in 39 bytes.
3112 (display_mode_element): Don't assume strlen fits in int.
3114 * termcap.c: Don't assume sizes fit in int and never overflow.
3115 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3116 (gobble_line): Check for size-calculation overflow.
3118 * minibuf.c (Fread_buffer):
3119 * lread.c (intern, intern_c_string):
3120 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3121 Don't assume string length fits in int.
3123 * keyboard.c (parse_tool_bar_item):
3124 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3126 * font.c: Don't assume string length fits in int.
3127 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3128 Use ptrdiff_t, not int.
3129 (font_intern_prop): Don't assume string length fits in int.
3130 Don't assume integer property fits in fixnum.
3131 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3133 * filelock.c: Fix some buffer overrun and integer overflow issues.
3134 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3135 Reformulate so as not to need the command string.
3136 Invoke gzip -cd rather than gunzip, as it's more portable.
3137 (lock_info_type, lock_file_1, lock_file):
3138 Don't assume pid_t and time_t fit in unsigned long.
3139 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3140 (current_lock_owner): Prefer signed type for sizes.
3141 Use memcpy, not strncpy, where memcpy is what is really wanted.
3142 Don't assume (via atoi) that time_t and pid_t fit in int.
3143 Check for time_t and/or pid_t out of range, e.g., via a network share.
3144 Don't alloca where an auto var works fine.
3146 * fileio.c: Fix some integer overflow issues.
3147 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3148 Don't assume string length fits in int.
3149 (directory_file_name): Don't assume string length fits in long.
3150 (make_temp_name): Don't assume pid fits in int, or that its print
3151 length is less than 20.
3153 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3155 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3157 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3159 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3160 We prefer signed integers, even for size calculations.
3162 * emacs.c: Don't assume string length fits in 'int'.
3163 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3164 (main): Don't invoke strlen when not needed.
3166 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3167 (XD_DEBUG_MESSAGE): Don't waste a byte.
3169 * callproc.c (getenv_internal_1, getenv_internal)
3171 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3173 * lread.c (invalid_syntax): Omit length argument.
3174 All uses changed. This doesn't fix a bug, but it simplifies the
3175 code away from its former Hollerith-constant appearance, and it's
3176 one less 'int' to worry about when looking at integer-overflow issues.
3177 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3179 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3180 This didn't break anything, but it didn't help either.
3181 It's confusing to put a bogus integer in a place where the actual
3182 value does not matter.
3183 (LIST_END_P): Remove unused macro and its bogus comment.
3184 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3186 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3187 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3189 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3190 We prefer signed types, and the value cannot exceed the EMACS_INT
3191 range anyway (because otherwise the length would not be representable).
3192 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3193 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3194 This avoids a GCC warning when WIDE_EMACS_INT.
3196 * indent.c (sane_tab_width): New function.
3197 (current_column, scan_for_column, Findent_to, position_indentation)
3198 (compute_motion): Use it. This is just for clarity.
3199 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3201 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3203 * lisp.h (lint_assume): New macro.
3204 * composite.c (composition_gstring_put_cache):
3205 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3207 * editfns.c, insdel.c:
3208 Omit unnecessary forward decls, to simplify future changes.
3210 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3212 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3214 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3215 Use much-faster test for byte-length change.
3216 Don't assume string byte-length fits in 'int'.
3217 Check that character arg fits in 'int'.
3218 (mapcar1): Declare byte as byte, for clarity.
3220 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3222 * fns.c (concat): Catch string overflow earlier.
3223 Do not rely on integer wraparound.
3225 * dispextern.h (struct it.overlay_strings_charpos)
3226 (struct it.selective): Now EMACS_INT, not int.
3227 * xdisp.c (forward_to_next_line_start)
3228 (back_to_previous_visible_line_start)
3229 (reseat_at_next_visible_line_start, next_element_from_buffer):
3230 Don't arbitrarily truncate the value of 'selective' to int.
3232 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3234 * composite.c: Don't truncate sizes to 'int'.
3235 (composition_gstring_p, composition_reseat_it)
3236 (composition_adjust_point): Use EMACS_INT, not int.
3237 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3238 not EMACS_UINT, for indexes.
3240 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3242 * buffer.c: Include <verify.h>.
3243 (struct sortvec.priority, struct sortstr.priority):
3244 Now EMACS_INT, not int.
3245 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3246 (struct sortstr.size, record_overlay_string)
3247 (struct sortstrlist.size, struct sortlist.used):
3248 Don't truncate size to int.
3249 (record_overlay_string): Check for size-calculation overflow.
3250 (init_buffer_once): Check at compile-time, not run-time.
3252 2011-06-22 Jim Meyering <meyering@redhat.com>
3254 Don't leak an XBM-image-sized buffer
3255 * image.c (xbm_load): Free the image buffer after using it.
3257 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3260 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3261 that Sun C diagnosed.
3262 * fns.c (secure_hash): Fix pointer signedness issue.
3263 * intervals.c (static_offset_intervals): New function.
3264 (offset_intervals): Use it.
3266 2011-06-21 Leo Liu <sdl.web@gmail.com>
3269 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3272 * fns.c (secure_hash): Rename from crypto_hash_function and change
3273 the first arg to accept symbols.
3274 (Fsecure_hash): New primitive.
3275 (syms_of_fns): New symbols.
3277 2011-06-20 Deniz Dogan <deniz@dogan.se>
3279 * process.c (Fset_process_buffer): Clarify return value in
3282 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3284 * dispnew.c (add_window_display_history): Use BVAR.
3286 * xdisp.c (debug_method_add): Use BVAR.
3287 (check_window_end, dump_glyph_matrix, dump_glyph)
3288 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3290 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3293 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3294 check till after the cache is created in init_frame_faces.
3296 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3298 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3300 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3302 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3303 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3304 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3306 Improve buffer-overflow checking (Bug#8873).
3307 * fileio.c (Finsert_file_contents):
3308 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3309 Remove the old (too-loose) buffer overflow checks.
3310 They weren't needed, since make_gap checks for buffer overflow.
3311 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3312 The old code merely checked for Emacs fixnum overflow, and relied
3313 on undefined (wraparound) behavior. The new code avoids undefined
3314 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3316 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3317 Tune. Don't use wider integers than needed. Don't use alloca.
3318 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3320 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3322 * insdel.c, lisp.h (buffer_overflow): New function.
3323 (insert_from_buffer_1, replace_range, replace_range_2):
3324 * insdel.c (make_gap_larger):
3325 * editfns.c (Finsert_char):
3326 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3328 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3330 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3332 Integer overflow and signedness fixes (Bug#8873).
3334 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3335 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3337 * fileio.c: Don't assume EMACS_INT fits in off_t.
3338 (emacs_lseek): New static function.
3339 (Finsert_file_contents, Fwrite_region): Use it.
3340 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3342 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3344 * fns.c: Don't overflow int when computing a list length.
3345 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3346 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3347 truncation on 64-bit hosts. Check for QUIT every
3348 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3349 faster and is responsive enough.
3350 (Flength): Report an error instead of overflowing an integer.
3351 (Fsafe_length): Return a float if the value is not representable
3352 as a fixnum. This shouldn't happen except in contrived situations.
3353 (Fnthcdr, Fsort): Don't assume list length fits in int.
3354 (Fcopy_sequence): Don't assume vector length fits in int.
3356 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3357 (header_size, word_size): New constants.
3358 (allocate_vectorlike): Don't check size overflow here.
3359 (allocate_vector): Check it here instead, since this is the only
3360 caller of allocate_vectorlike that could cause overflow.
3361 Check that the new vector's length is representable as a fixnum.
3363 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3364 The previous code was bogus. For example, next_almost_prime (32)
3365 returned 39, which is undesirable as it is a multiple of 3; and
3366 next_almost_prime (24) returned 25, which is a multiple of 5 so
3367 why was the code bothering to check for multiples of 7?
3369 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3371 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3373 Variadic C functions now count arguments with ptrdiff_t.
3374 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3375 Back then I didn't know that the Emacs coding style prefers signed int.
3376 Also, in the meantime I found a few more instances where arguments
3377 were being counted with int, which may truncate counts on 64-bit
3378 machines, or EMACS_INT, which may be unnecessarily wide.
3379 * lisp.h (struct Lisp_Subr.function.aMANY)
3380 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3381 Arg counts are now ptrdiff_t, not size_t.
3382 All variadic functions and their callers changed accordingly.
3383 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3384 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3385 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3386 * callint.c (Fcall_interactively): Check arg count for overflow,
3387 to avoid potential buffer overrun. Use signed char, not 'int',
3388 for 'varies' array, so that we needn't bother to check its size
3389 calculation for overflow.
3390 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3391 * eval.c (apply_lambda):
3392 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3393 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3394 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3396 * callint.c (Fcall_interactively): Don't use index var as event count.
3398 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3399 * mem-limits.h (SIZE): Remove; no longer used.
3401 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3403 Remove unnecessary casts.
3404 * xterm.c (x_term_init):
3405 * xfns.c (x_set_border_pixel):
3406 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3407 These aren't needed now that we assume ANSI C.
3409 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3410 It's more likely to cause problems (due to unsigned overflow)
3413 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3415 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3417 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3419 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3421 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3423 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3425 GLYPH_CODE_FACE returns EMACS_INT, not int.
3426 * dispextern.h (merge_faces):
3427 * xfaces.c (merge_faces):
3428 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3429 Don't assume EMACS_INT fits in int.
3431 * character.h (CHAR_VALID_P): Remove unused parameter.
3432 * fontset.c, lisp.h, xdisp.c: All uses changed.
3434 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3436 * fns.c (concat): Minor tuning based on overflow analysis.
3437 This doesn't fix any bugs. Use int to hold character, instead
3438 of constantly refetching from Emacs object. Use XFASTINT, not
3439 XINT, for value known to be a character. Don't bother comparing
3440 a single byte to 0400, as it's always less.
3442 * floatfns.c (Fexpt):
3443 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3445 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3448 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3450 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3451 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3452 incorrectly succeed when S was a string, because 4294967386 was
3453 truncated before it was used.
3455 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3456 Otherwise, an out-of-range integer could cause undefined behavior
3459 * composite.c: Use int, not EMACS_INT, for characters.
3460 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3461 EMACS_INT, for values that are known to be in character range.
3462 This doesn't fix any bugs but is the usual style inside Emacs and
3463 may generate better code on 32-bit machines.
3465 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3466 This is for reasons similar to the recent CHAR_STRING fix.
3467 * charset.c (Fencode_char): Check that character arg is actually
3468 a character. Pass an int to ENCODE_CHAR.
3469 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3470 wider than 'int', as a compile-time check to prevent future regressions
3473 * character.c (char_string): Remove unnecessary casts.
3475 Make sure a 64-bit char is never passed to CHAR_STRING.
3476 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3477 by silently ignoring the top 32 bits, allowing some values
3478 that were far too large to be valid characters.
3479 * character.h: Include <verify.h>.
3480 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3481 arguments are no wider than unsigned, as a compile-time check
3482 to prevent future regressions in this area.
3484 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3485 (Fsubst_char_in_region):
3487 * xdisp.c (decode_mode_spec_coding):
3488 Adjust to CHAR_STRING's new requirement.
3489 * editfns.c (Finsert_char, Fsubst_char_in_region):
3490 * fns.c (concat): Check that character args are actually
3491 characters. Without this test, these functions did the wrong
3492 thing with wildly out-of-range values on 64-bit hosts.
3494 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3495 These casts should not be needed on 32-bit hosts, either.
3496 * keyboard.c (read_char):
3497 * lread.c (Fload): Remove casts to unsigned.
3499 * lisp.h (UNSIGNED_CMP): New macro.
3500 This fixes comparison bugs on 64-bit hosts.
3501 (ASCII_CHAR_P): Use it.
3502 * casefiddle.c (casify_object):
3503 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3504 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3505 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3506 * dispextern.h (FACE_FROM_ID):
3507 * keyboard.c (read_char): Use UNSIGNED_CMP.
3509 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3510 not to EMACS_INT, to avoid GCC warning.
3512 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3514 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3515 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3516 isn't needed on 32-bit machines.
3518 * buffer.c (Fgenerate_new_buffer_name):
3519 Use EMACS_INT for count, not int.
3520 (advance_to_char_boundary): Return EMACS_INT, not int.
3522 * data.c (Qcompiled_function): Now static.
3524 * window.c (window_body_lines): Now static.
3526 * image.c (gif_load): Rename local to avoid shadowing.
3528 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3529 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3530 * alloc.c (make_save_value): Integer argument is now of type
3532 (mark_object): Use ptrdiff_t, not int.
3533 * lisp.h (pD): New macro.
3534 * print.c (print_object): Use it.
3536 * alloc.c: Use EMACS_INT, not int, to count objects.
3537 (total_conses, total_markers, total_symbols, total_vector_size)
3538 (total_free_conses, total_free_markers, total_free_symbols)
3539 (total_free_floats, total_floats, total_free_intervals)
3540 (total_intervals, total_strings, total_free_strings):
3541 Now EMACS_INT, not int. All uses changed.
3542 (Fgarbage_collect): Compute overall total using a double, so that
3543 integer overflow is less likely to be a problem. Check for overflow
3544 when converting back to an integer.
3545 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3546 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3547 These were 'int' variables that could overflow on 64-bit hosts;
3548 they were never used, so remove them instead of repairing them.
3549 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3550 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3551 Previously, this ceilinged at INT_MAX, but that doesn't work on
3553 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3555 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3556 (allocate_vectorlike): Check for ptrdiff_t overflow.
3557 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3558 when a (possibly-narrower) signed value would do just as well.
3559 We prefer using signed arithmetic, to avoid comparison confusion.
3561 * alloc.c: Catch some string size overflows that we were missing.
3562 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3563 for convenience in STRING_BYTES_MAX.
3564 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3565 The definition here is exact; the one in lisp.h was approximate.
3566 (allocate_string_data): Check for string overflow. This catches
3567 some instances we weren't catching before. Also, it catches
3568 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3569 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3570 and ptrdiff_t and EMACS_INT are both 64 bits.
3572 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3573 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3574 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3576 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3578 * alloc.c (Fmake_string): Check for out-of-range init.
3580 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3582 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3584 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3586 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3587 xg_get_default_scrollbar_width.
3589 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3590 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3591 (style_changed_cb): Call update_theme_scrollbar_width and call
3592 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3593 all frames (Bug#8505).
3594 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3595 Call gtk_window_set_resizable if HAVE_GTK3.
3596 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3597 and height if HAVE_GTK3 (Bug#8505).
3598 (scroll_bar_width_for_theme): New variable.
3599 (update_theme_scrollbar_width): New function.
3600 (xg_get_default_scrollbar_width): Move code to
3601 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3602 (xg_initialize): Call update_theme_scrollbar_width.
3604 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3606 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3608 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3610 * frame.c (make_frame): Call other_buffer_safely instead of
3613 * window.c (temp_output_buffer_show): Call display_buffer with
3614 second argument Vtemp_buffer_show_specifiers and reset latter
3615 immediately after the call.
3616 (Vtemp_buffer_show_specifiers): New variable.
3617 (auto_window_vscroll_p, next_screen_context_lines)
3618 (Vscroll_preserve_screen_position): Remove leading asterisks from
3621 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3623 Fix minor problems found by GCC 4.6.0 static checking.
3624 * buffer.c (Qclone_number): Remove for now, as it's unused.
3625 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3626 (record_buffer): Remove unused local.
3627 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3628 (set_frame_buffer_list): Remove; unused.
3629 * frame.h (other_visible_frames): Remove decl.
3630 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3631 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3632 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3634 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3635 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3636 Define only if HAVE_GPM.
3637 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3638 (update_hints_inhibit): Remove; never set. All uses removed.
3639 * widgetprv.h (emacsFrameClassRec): Remove decl.
3640 * window.c (delete_deletable_window): Now returns void, since it
3641 wasn't returning anything.
3642 (compare_window_configurations): Remove unused locals.
3643 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3644 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3645 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3646 the same widths as pointers. This follows up on the 2011-05-06 patch.
3647 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3648 * xterm.h: Likewise.
3649 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3651 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3653 * makefile.w32-in: Update dependencies.
3654 (LISP_H): Add lib/intprops.h.
3656 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3658 * image.c (gif_load): Add animation frame delay to the metadata.
3659 (syms_of_image): Use DEFSYM. New symbol `delay'.
3661 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3663 * window.c (delete_deletable_window): Re-add.
3664 (Fset_window_configuration): Rewrite to handle dead buffers and
3665 consequently deletable windows.
3666 (window_tree, Fwindow_tree): Remove. Supply functionality in
3668 (compare_window_configurations): Simplify code.
3670 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3672 * image.c (imagemagick_load_image): Fix type mismatch.
3673 (Fimagemagick_types): Likewise.
3675 * window.h (replace_buffer_in_windows): Declare.
3677 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3679 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3680 Qclone_number. Remove external declaration of Qdelete_window.
3681 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3683 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3684 Run Qbuffer_list_update_hook if allowed.
3685 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3686 buffer list implementation.
3687 (other_buffer_safely): New function.
3688 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3689 calls to replace_buffer_in_windows and
3690 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3692 (record_buffer): Inhibit quitting and rewrite using quittable
3693 functions. Run Qbuffer_list_update_hook if allowed.
3694 (Frecord_buffer, Funrecord_buffer): New functions.
3695 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3696 Move switch-to-buffer to window.el.
3697 (bury-buffer): Move to window.el.
3698 (Vbuffer_list_update_hook): New variable.
3700 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3703 * window.h (resize_frame_windows): Move up in code.
3704 (Fwindow_frame): Remove EXFUN.
3705 (replace_buffer_in_all_windows): Remove prototype.
3706 (replace_buffer_in_windows_safely): Add prototype.
3708 * window.c: Declare Qdelete_window static again. Move down
3709 declaration of select_count.
3710 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3711 (Fother_window): Move to window.el.
3712 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3713 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3714 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3716 (replace_buffer_in_windows): Implement by calling
3717 Qreplace_buffer_in_windows.
3718 (replace_buffer_in_all_windows): Remove with some functionality
3719 moved into replace_buffer_in_windows_safely.
3720 (replace_buffer_in_windows_safely): New function.
3721 (select_window_norecord, select_frame_norecord): Move in front
3722 of run_window_configuration_change_hook. Remove now obsolete
3724 (Fset_window_buffer): Rewrite doc-string.
3725 Call Qrecord_window_buffer.
3726 (keys_of_window): Move binding for other-window to window.el.
3728 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3730 * dispextern.h (struct image): Replace data member, whose int_val
3731 and ptr_val fields were not used by anything, with a single
3734 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3735 (gif_clear_image, gif_load, imagemagick_load_image)
3736 (gs_clear_image, gs_load): Callers changed.
3738 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3740 * buffer.h: Include <time.h>, for time_t.
3741 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3743 Fix minor problems found by static checking.
3745 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3747 Make identifiers static if they are not used in other modules.
3748 * data.c (Qcompiled_function, Qframe, Qvector):
3749 * image.c (QimageMagick, Qsvg):
3750 * minibuf.c (Qmetadata):
3751 * window.c (resize_window_check, resize_root_window): Now static.
3752 * window.h (resize_window_check, resize_root_window): Remove decls.
3754 * window.c (window_deletion_count, delete_deletable_window):
3756 (window_body_lines): Now static.
3757 (Fdelete_other_windows_internal): Mark vars as initialized.
3758 Make sure 'resize_failed' is initialized.
3759 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3760 (resize_window_apply): Remove unused local.
3761 * window.h (delete_deletable_window): Remove decl.
3763 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3764 (imagemagick_load_image): Fix pointer signedness problem by changing
3765 last arg from unsigned char * to char *. All uses changed.
3766 Also, fix a local for similar reasons.
3767 Remove unused locals. Remove locals to avoid shadowing.
3768 (fn_rsvg_handle_free): Remove; unused.
3769 (svg_load, svg_load_image): Fix pointer signedness problem.
3770 (imagemagick_load_image): Don't use garbage pointer image_wand.
3772 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3774 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3776 * image.c (gif_load): Fix omitted cast error introduced by
3779 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3781 * window.h (resize_proportionally, orig_total_lines)
3782 (orig_top_line): Remove from window structure.
3783 (set_window_height, set_window_width, change_window_heights)
3784 (Fdelete_window): Remove prototypes.
3785 (resize_frame_windows): Remove duplicate declaration.
3787 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3789 * window.h (resize_frame_windows, resize_window_check)
3790 (delete_deletable_window, resize_root_window)
3791 (resize_frame_windows): Declare prototypes.
3793 * window.c (resize_window_apply): Make definition be "static" to
3794 match the prototype.
3796 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3798 * window.c: Remove declarations of Qwindow_size_fixed,
3799 window_min_size_1, window_min_size_2, window_min_size,
3800 size_window, window_fixed_size_p, enlarge_window, delete_window.
3801 Remove static from declaration of Qdelete_window, it's
3802 temporarily needed by Fbury_buffer.
3803 (replace_window): Don't assign orig_top_line and
3805 (Fdelete_window, delete_window): Remove. Window deletion is
3806 handled by window.el.
3807 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3808 Replace Fdelete_window calls with calls to Qdelete_window.
3809 (Fdelete_other_windows): Remove. Deleting other windows is
3810 handled by window.el.
3811 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3812 handled in window.el.
3813 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3814 Window minimum sizes are handled in window.el.
3815 (shrink_windows, size_window, set_window_height)
3816 (set_window_width, change_window_heights, window_height)
3817 (window_width, CURBEG, CURSIZE, enlarge_window)
3818 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3819 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3820 handled in window.el.
3821 (make_dummy_parent): Rename to make_parent_window and give it a
3822 second argument horflag.
3823 (make_window): Don't set resize_proportionally any more.
3824 (Fsplit_window): Remove. Windows are split in window.el.
3825 (save_restore_action, save_restore_orig_size)
3826 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3827 Resize mini windows in window.el.
3828 (grow_mini_window, shrink_mini_window): Implement by calling
3829 Qresize_root_window_vertically, resize_window_check and
3830 resize_window_apply.
3831 (saved_window, Fset_window_configuration, save_window_save):
3832 Do not handle orig_top_line, orig_total_lines, and
3833 resize_proportionally.
3834 (window_min_height, window_min_width): Move to window.el.
3835 (keys_of_window): Move bindings for delete-other-windows,
3836 split-window, delete-window and enlarge-window to window.el.
3838 * buffer.c: Temporarily extern Qdelete_window.
3839 (Fbury_buffer): Temporarily call Qdelete_window instead of
3840 Fdelete_window (Fbury_buffer will move to window.el soon).
3842 * frame.c (set_menu_bar_lines_1): Remove code handling
3843 orig_top_line and orig_total_lines.
3845 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3846 set_window_height but set heights directly.
3847 (change_frame_size_1): Use resize_frame_windows.
3849 * xdisp.c (init_xdisp): Don't use set_window_height but set
3852 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3853 Use resize_frame_windows instead of change_window_heights and run
3854 run_window_configuration_change_hook.
3856 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3857 instead of change_window_heights and run
3858 run_window_configuration_change_hook.
3860 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3862 * window.c (replace_window): Rename second argument REPLACEMENT to
3863 NEW. New third argument SETFLAG. Rewrite.
3864 (delete_window, make_dummy_parent): Call replace_window with
3866 (window_list_1): Move down in code.
3867 (run_window_configuration_change_hook): Move set_buffer part
3868 before select_frame_norecord part in order to unwind correctly.
3869 Rename count1 to count.
3870 (recombine_windows, delete_deletable_window, resize_root_window)
3871 (Fdelete_other_windows_internal)
3872 (Frun_window_configuration_change_hook, make_parent_window)
3873 (resize_window_check, resize_window_apply, Fresize_window_apply)
3874 (resize_frame_windows, Fsplit_window_internal)
3875 (Fdelete_window_internal, Fresize_mini_window_internal):
3877 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3879 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3881 * window.h (window): Add some new members to window structure -
3882 normal_lines, normal_cols, new_total, new_normal, clone_number,
3883 splits, nest, prev_buffers, next_buffers.
3884 (WINDOW_TOTAL_SIZE): Move here from window.c.
3885 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3887 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3889 (make_dummy_parent): Set new members of windows structure.
3890 (make_window): Move down in code. Handle new members of window
3892 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3893 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3894 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3895 (Fset_window_prev_buffers, Fwindow_next_buffers)
3896 (Fset_window_next_buffers, Fset_window_clone_number):
3898 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3899 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3901 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3902 Argument WINDOW can be now internal window too.
3903 (Fwindow_use_time): Move up in code.
3904 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3906 (Fset_window_configuration, saved_window)
3907 (Fcurrent_window_configuration, save_window_save): Handle new
3908 members of window structure.
3909 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3910 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3911 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3912 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3913 Qget_mru_window, Qresize_root_window,
3914 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3915 Qauto_buffer_name; staticpro them.
3917 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3919 * window.c (Fwindow_total_size, Fwindow_left_column)
3920 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3921 (Fwindow_list_1): New functions.
3922 (window_box_text_cols): Replace with window_body_cols.
3923 (Fwindow_width, Fscroll_left, Fscroll_right):
3924 Use window_body_cols instead of window_box_text_cols.
3925 (delete_window, Fset_window_configuration):
3926 Call delete_all_subwindows with window as argument.
3927 (delete_all_subwindows): Take a window as argument and not a
3929 (window_loop): Remove handling of GET_LRU_WINDOW and
3931 (Fget_lru_window, Fget_largest_window): Move to window.el.
3933 * window.h: Extern window_body_cols instead of
3934 window_box_text_cols. delete_all_subwindows now takes a
3935 Lisp_Object as argument.
3937 * indent.c (compute_motion, Fcompute_motion):
3938 Use window_body_cols instead of window_box_text_cols.
3940 * frame.c (delete_frame): Call delete_all_subwindows with root
3943 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3945 * fns.c (Fputhash): Document return value.
3947 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3949 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3951 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3953 Cons<->int and similar integer overflow fixes (Bug#8794).
3955 Check for overflow when converting integer to cons and back.
3956 * charset.c (Fdefine_charset_internal, Fdecode_char):
3957 Use cons_to_unsigned to catch overflow.
3958 (Fencode_char): Use INTEGER_TO_CONS.
3959 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3960 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3961 * data.c (long_to_cons, cons_to_long): Remove.
3962 (cons_to_unsigned, cons_to_signed): New functions.
3963 These signal an error for invalid or out-of-range values.
3964 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3965 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3966 * font.c (Ffont_variation_glyphs):
3967 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3968 * lisp.h: Include <intprops.h>.
3969 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3970 (cons_to_signed, cons_to_unsigned): New decls.
3971 (long_to_cons, cons_to_long): Remove decls.
3972 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3973 (Fprimitive_undo): Use CONS_TO_INTEGER.
3974 * xfns.c (Fx_window_property): Likewise.
3975 * xselect.c: Include <limits.h>.
3976 (x_own_selection, selection_data_to_lisp_data):
3977 Use INTEGER_TO_CONS.
3978 (x_handle_selection_request, x_handle_selection_clear)
3979 (x_get_foreign_selection, Fx_disown_selection_internal)
3980 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3981 (lisp_data_to_selection_data): Use cons_to_unsigned.
3982 (x_fill_property_data): Use cons_to_signed.
3983 Report values out of range.
3985 Check for buffer and string overflow more precisely.
3986 * buffer.h (BUF_BYTES_MAX): New macro.
3987 * lisp.h (STRING_BYTES_MAX): New macro.
3988 * alloc.c (Fmake_string):
3989 * character.c (string_escape_byte8):
3990 * coding.c (coding_alloc_by_realloc):
3991 * doprnt.c (doprnt):
3992 * editfns.c (Fformat):
3994 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3995 since they may not be the same number.
3996 * editfns.c (Finsert_char):
3997 * fileio.c (Finsert_file_contents):
3998 Likewise for BUF_BYTES_MAX.
4000 * image.c: Use ptrdiff_t, not int, for sizes.
4001 (slurp_file): Switch from int to ptrdiff_t.
4003 (slurp_file): Check that file size fits in both size_t (for
4004 malloc) and ptrdiff_t (for sanity and safety).
4006 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4007 if b->modtime has its maximal value.
4009 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4011 Don't assume time_t can fit into int.
4012 * buffer.h (struct buffer.modtime): Now time_t, not int.
4013 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4014 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4016 Minor fixes for signed vs unsigned integers.
4017 * character.h (MAYBE_UNIFY_CHAR):
4018 * charset.c (maybe_unify_char):
4019 * keyboard.c (read_char, reorder_modifiers):
4020 XINT -> XFASTINT, since the integer must be nonnegative.
4021 * ftfont.c (ftfont_spec_pattern):
4022 * keymap.c (access_keymap, silly_event_symbol_error):
4023 XUINT -> XFASTINT, since the integer must be nonnegative.
4024 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4025 since it makes no difference and we prefer signed.
4026 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4027 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4030 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4032 * window.h (Fwindow_frame): Declare.
4034 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4036 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4037 (SPARE_MEMORY): Always define.
4038 (LARGE_REQUEST): Remove.
4039 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4041 2011-06-06 Martin Rudalics <rudalics@gmx.at>
4043 * lisp.h: Move EXFUNS for Fframe_root_window,
4044 Fframe_first_window and Fset_frame_selected_window to window.h.
4046 * window.h: Move EXFUNS for Fframe_root_window,
4047 Fframe_first_window and Fset_frame_selected_window here from
4050 * frame.c (Fwindow_frame, Fframe_first_window)
4051 (Fframe_root_window, Fframe_selected_window)
4052 (Fset_frame_selected_window): Move to window.c.
4053 (Factive_minibuffer_window): Move to minibuf.c.
4054 (Fother_visible_frames_p): New function.
4056 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4058 * window.c (decode_window, decode_any_window): Move up in code.
4059 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4060 (inhibit_frame_unsplittable): Remove unused variable.
4061 (Fwindow_buffer): Move up and rewrite doc-string.
4062 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4063 (Fwindow_prev): New functions.
4064 (Fwindow_frame): Move here from frame.c. Accept any window as
4066 (Fframe_root_window, Fframe_first_window)
4067 (Fframe_selected_window): Move here from frame.c. Accept frame
4068 or arbitrary window as argument. Update doc-strings.
4069 (Fminibuffer_window): Move up in code.
4070 (Fwindow_minibuffer_p): Move up in code and simplify.
4071 (Fset_frame_selected_window): Move here from frame.c.
4073 (Fselected_window, select_window, Fselect_window): Move up in
4074 code. Minor doc-string fixes.
4076 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4078 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4079 Do not assume that spare memory exists; that assumption is valid
4080 only if SYSTEM_MALLOC.
4081 (LARGE_REQUEST): New macro, so that the issue of large requests
4082 is separated from the issue of spare memory.
4084 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4086 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4089 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4091 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4094 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4096 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4098 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4100 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4101 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4103 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
4105 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4107 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
4109 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4110 (x_clipboard_manager_save): Add return value.
4111 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4113 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4114 Obey Vx_select_enable_clipboard_manager. Catch errors in
4115 x_clipboard_manager_save (Bug#8779).
4116 (Vx_select_enable_clipboard_manager): New variable.
4117 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4119 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4121 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4123 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4125 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4126 in the current matrix if keep_current_p is non-zero.
4128 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4130 * bidi.c (bidi_level_of_next_char): Fix last change.
4132 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4134 Support bidi reordering of text covered by display properties.
4136 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4137 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4138 (bidi_cache_search, bidi_cache_iterator_state)
4139 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4140 (bidi_level_of_next_char, bidi_move_to_visually_next):
4141 Support character positions inside a run of characters covered by a
4143 (bidi_paragraph_init, bidi_resolve_explicit_1)
4144 (bidi_level_of_next_char): Call bidi_fetch_char and
4145 bidi_fetch_char_advance instead of FETCH_CHAR and
4147 (bidi_init_it): Initialize new members.
4148 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4150 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4151 instead of using explicit *_CHAR codes.
4152 (bidi_resolve_explicit, bidi_resolve_weak):
4153 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4154 bidirectional text is supported only in multibyte buffers.
4155 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4156 it to initialize the frame_window_p member of struct bidi_it.
4157 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4158 (bidi_resolve_explicit, bidi_resolve_weak)
4159 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4160 bidi_it->nchars is non-positive.
4161 (bidi_level_of_next_char): Don't try to lookup the cache for the
4162 next/previous character if nothing is cached there yet, or if we
4163 were just reseat()'ed to a new position.
4165 * xdisp.c (set_cursor_from_row): Set start and stop points
4166 according to the row's direction when priming the loop that looks
4167 for the glyph on which to display cursor.
4168 (single_display_spec_intangible_p): Function deleted.
4169 (display_prop_intangible_p): Reimplement to call
4170 handle_display_spec instead of single_display_spec_intangible_p.
4171 Accept 3 additional arguments needed by handle_display_spec.
4172 This fixes incorrect cursor motion across display property with complex
4173 values: lists, `(when COND...)' forms, etc.
4174 (single_display_spec_string_p): Support property values that are
4175 lists with the argument STRING its top-level element.
4176 (display_prop_string_p): Fix the condition for processing a
4177 property that is a list to be consistent with handle_display_spec.
4178 (handle_display_spec): New function, refactored from the
4179 last portion of handle_display_prop.
4180 (compute_display_string_pos): Accept additional argument
4181 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4182 value of a `display' property is a "replacing spec".
4183 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4184 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4185 the display property, but just return a value indicating whether
4186 the display property will replace the characters it covers.
4187 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4188 frame_window_p members of struct bidi_it.
4189 (compute_display_string_pos, compute_display_string_end):
4191 (push_it): Accept second argument POSITION, where pop_it should
4192 jump to continue iteration.
4193 (reseat_1): Initialize bidi_it.disp_pos.
4195 * keyboard.c (adjust_point_for_property): Adjust the call to
4196 display_prop_intangible_p to its new signature.
4198 * dispextern.h (struct bidi_it): New member frame_window_p.
4199 (bidi_init_it): Update prototypes.
4200 (display_prop_intangible_p): Update prototype.
4201 (compute_display_string_pos, compute_display_string_end):
4203 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4206 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4208 Malloc failure behavior now depends on size of allocation.
4209 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4210 * lisp.h: Change signatures accordingly.
4211 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4212 All callers changed. (Bug#8762)
4214 * gnutls.c: Use Emacs's memory allocators.
4215 Without this change, the gnutls library would invoke malloc etc.
4216 directly, which causes problems on non-SYNC_INPUT hosts, and which
4217 runs afoul of improving memory_full behavior. (Bug#8761)
4218 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4219 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4220 xfree instead of the default malloc, realloc, free.
4221 (Fgnutls_boot): No need to check for memory allocation failure,
4222 since xmalloc does that for us.
4224 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4225 * category.c (hash_get_category_set):
4226 * ccl.c (ccl_driver):
4227 * charset.c (Fdefine_charset_internal):
4228 * charset.h (struct charset.hash_index):
4229 * composite.c (get_composition_id, gstring_lookup_cache)
4230 (composition_gstring_put_cache):
4231 * composite.h (struct composition.hash_index):
4232 * dispextern.h (struct image.hash):
4233 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4234 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4235 (hashfn_equal, hashfn_user_defined, make_hash_table)
4236 (maybe_resize_hash_table, hash_lookup, hash_put)
4237 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4238 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4239 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4240 * image.c (make_image, search_image_cache, lookup_image)
4241 (xpm_put_color_table_h):
4242 * lisp.h (struct Lisp_Hash_Table):
4243 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4244 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4245 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4246 * alloc.c (allocate_vectorlike):
4247 Check for overflow in vector size calculations.
4248 * ccl.c (ccl_driver):
4249 Check for overflow when converting EMACS_INT to int.
4250 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4251 need to be updated by these changes.
4252 * fns.c (make_hash_table, maybe_resize_hash_table):
4253 Check for integer overflow with large hash tables.
4254 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4255 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4256 (SXHASH_REDUCE): New macro.
4257 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4258 Use it instead of discarding useful hash info with large hash values.
4259 (sxhash_float): New function.
4260 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4261 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4262 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4263 Rewrite to use FIXNUM_BITS, as this simplifies things.
4264 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4265 Adjust signatures to match updated version of code.
4266 (consing_since_gc): Now EMACS_INT, since a single hash table can
4267 use more than INT_MAX bytes.
4269 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4271 Make it possible to build with GCC-4.6+ -O2 -flto.
4273 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4275 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4277 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4278 Call minibuffer-inactive-mode.
4280 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4282 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4283 Update dependencies.
4285 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4287 * data.c (init_data): Remove code for UTS, this system is not
4290 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4292 Don't force ./temacs to start in terminal mode.
4294 * frame.c (make_initial_frame): Initialize faces in all cases, not
4295 only when CANNOT_DUMP is defined.
4296 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4298 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4300 * dispnew.c (add_window_display_history): Use const for the string
4301 pointer. Remove declaration, not needed.
4303 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4305 Use 'inline', not 'INLINE'.
4306 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4307 * alloc.c, fontset.c (INLINE): Remove.
4308 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4309 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4310 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4311 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4312 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4314 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4316 Make it possible to run ./temacs.
4318 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4319 syms_of_callproc does the same thing. Remove test for
4320 "initialized", do it in the caller.
4321 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4323 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4325 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4326 (read_minibuf): Use get_minibuffer.
4327 (syms_of_minibuf): Use DEFSYM.
4328 (Qmetadata): New var.
4329 * data.c (Qbuffer): Don't make it static.
4330 (syms_of_data): Use DEFSYM.
4332 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4334 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4335 (CCL_CODE_MIN): New macro.
4337 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4339 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4341 * eval.c (Qdebug): Now static.
4342 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4343 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4344 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4346 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4348 * image.c: Various fixes to ImageMagick code comments.
4349 (Fimagemagick_types): Doc fix.
4351 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4353 Minor fixes prompted by GCC 4.6.0 warnings.
4355 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4357 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4358 (x_clipboard_manager_save_all): Move extern decl to ...
4359 * xterm.h: ... here, so that it can be checked for consistency.
4361 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4363 * xselect.c (x_clipboard_manager_save_frame)
4364 (x_clipboard_manager_save_all): New functions.
4365 (Fx_clipboard_manager_save): Lisp function deleted.
4367 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4368 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4370 * xterm.h: Update prototype.
4372 2011-05-28 William Xu <william.xwl@gmail.com>
4374 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4377 2011-05-28 Jim Meyering <meyering@redhat.com>
4379 Avoid a sign-extension bug in crypto_hash_function.
4380 * fns.c (to_uchar): Define.
4381 (crypto_hash_function): Use it to convert some newly-signed
4382 variables to unsigned, to avoid sign-extension bugs. For example,
4383 without this change, (md5 "truc") would evaluate to
4384 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4385 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4386 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4388 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4390 Integer overflow fixes.
4392 * dbusbind.c: Serial number integer overflow fixes.
4393 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4394 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4395 to hold a serial number that is too large for a fixnum.
4396 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4397 Check for serial numbers out of range. Decode any serial number
4398 that was so large that it became a float. (Bug#8722)
4400 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4401 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4402 Use XFASTINT rather than XUINT when numbers are nonnegative.
4403 (xd_append_arg, Fdbus_method_return_internal):
4404 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4405 arguments, check that Lisp number is nonnegative, rather than
4406 silently wrapping negative numbers around. (Bug#8722)
4407 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4410 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4412 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4414 ccl: add integer overflow checks
4415 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4416 (IN_INT_RANGE): New macros.
4417 (ccl_driver): Use them to check for integer overflow when
4418 decoding a CCL program. Many of the new checks are whether XINT (x)
4419 fits in int; it doesn't always, on 64-bit hosts. The new version
4420 doesn't catch all possible integer overflows, but it's an
4421 improvement. (Bug#8719)
4423 * alloc.c (make_event_array): Use XINT, not XUINT.
4424 There's no need for unsigned here.
4426 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4427 This follows up to the 2011-05-06 change that substituted uintptr_t
4428 for EMACS_INT. This case wasn't caught back then.
4430 Rework Fformat to avoid integer overflow issues.
4431 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4432 now (part of C89). Include <verify.h>.
4433 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4434 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4435 (Fformat): Avoid the prepass trying to compute sizes; it was only
4436 approximate and thus did not catch overflow reliably. Instead, walk
4437 through the format just once, formatting and computing sizes as we go,
4438 checking for integer overflow at every step, and allocating a larger
4439 buffer as needed. Keep track separately whether the format is
4440 multibyte. Keep only the most-recently calculated precision, rather
4441 than them all. Record whether each argument has been converted to
4442 string. Use EMACS_INT, not int, for byte and char and arg counts.
4443 Support field widths and precisions larger than INT_MAX. Avoid
4444 sprintf's undefined behavior with conversion specifications such as %#d
4445 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4446 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4447 formatting out-of-range floating point numbers with int
4450 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4452 * data.c: Avoid integer truncation in expressions involving floats.
4453 * data.c: Include <intprops.h>.
4454 (arith_driver): When there's an integer overflow in an expression
4455 involving floating point, convert the integers to floating point
4456 so that the resulting value does not suffer from catastrophic
4457 integer truncation. For example, on a 64-bit host (* 4
4458 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4459 Do not rely on undefined behavior after integer overflow.
4461 merge count_size_as_multibyte, parse_str_to_multibyte
4462 * character.c, character.h (count_size_as_multibyte):
4463 Rename from parse_str_to_multibyte; all uses changed.
4464 Check for integer overflow.
4465 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4466 since it's now a duplicate of the other. This is more of
4467 a character than a buffer op, so better that it's in character.c.
4468 * fns.c, print.c: Adjust to above changes.
4470 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4472 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4474 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4476 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4477 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4478 (x_clipboard_manager_save): Now static.
4479 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4481 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4482 (crypto_hash_function): Now static.
4483 Fix pointer signedness problems. Avoid unnecessary initializations.
4485 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4487 * termhooks.h (Vselection_alist): Make it terminal-local.
4489 * terminal.c (create_terminal): Initialize it.
4491 * xselect.c: Support for clipboard managers.
4492 (Vselection_alist): Move to termhooks.h as terminal-local var.
4493 (LOCAL_SELECTION): New macro.
4494 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4495 (symbol_to_x_atom): Remove gratuitous arg.
4496 (x_handle_selection_request, lisp_data_to_selection_data)
4497 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4498 (x_own_selection, x_get_local_selection, x_convert_selection):
4499 New arg, specifying work frame. Use terminal-local Vselection_alist.
4500 (some_frame_on_display): Delete unused function.
4501 (Fx_own_selection_internal, Fx_get_selection_internal)
4502 (Fx_disown_selection_internal, Fx_selection_owner_p)
4503 (Fx_selection_exists_p): New optional frame arg.
4504 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4505 (x_handle_selection_clear): Don't treat other terminals with the
4506 same keyboard specially. Use the terminal-local Vselection_alist.
4507 (x_clear_frame_selections): Use Frun_hook_with_args.
4509 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4511 * xterm.h: Add support for those atoms.
4513 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4515 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4516 (converted_selections, conversion_fail_tag): New global variables.
4517 (x_selection_request_lisp_error): Free the above.
4518 (x_get_local_selection): Remove unnecessary code.
4519 (x_reply_selection_request): Args changed; handle arbitrary array
4520 of converted selections stored in converted_selections.
4521 Separate the XChangeProperty and SelectionNotify steps.
4522 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4523 (x_convert_selection): New function.
4524 (x_handle_selection_event): Simplify.
4525 (x_get_foreign_selection): Don't ignore incoming requests while
4526 waiting for an answer; this will fail when we implement
4527 SAVE_TARGETS, and seems unnecessary anyway.
4528 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4529 (Vx_sent_selection_functions): Doc fix.
4531 2011-05-26 Leo Liu <sdl.web@gmail.com>
4533 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4535 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4537 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4539 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4540 for fringe update if it has periodic bitmap.
4541 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4542 and fringe_bitmap_periodic_p.
4544 * fringe.c (get_fringe_bitmap_data): New function.
4545 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4546 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4547 row. Mark glyph row for fringe update if periodicity changed.
4549 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4550 for fringe update unless it has periodic bitmap.
4552 2011-05-25 Kenichi Handa <handa@m17n.org>
4554 * xdisp.c (get_next_display_element): Set correct it->face_id for
4555 a static composition.
4557 2011-05-24 Leo Liu <sdl.web@gmail.com>
4560 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4562 * fns.c (crypto_hash_function, Fsha1): New function.
4563 (Fmd5): Use crypto_hash_function.
4564 (syms_of_fns): Add Ssha1.
4566 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4568 * gnutls.c: Remove unused macros.
4569 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4570 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4571 Remove macros that are defined and never used.
4572 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4574 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4576 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4577 (Fx_get_selection_internal): Minor cleanup.
4578 (Fx_own_selection_internal): Rename arguments for consistency with
4581 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4583 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4585 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4587 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4589 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4591 * dispnew.c (scrolling_window): Don't exclude the case that the
4592 last enabled row in the desired matrix touches the bottom boundary.
4594 2011-05-21 Glenn Morris <rgm@gnu.org>
4596 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4597 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4598 and add some more files.
4600 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4602 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4603 report_file_error introduced by the change from 2011-05-07.
4605 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4607 * systime.h (Time): Define only if emacs is defined.
4608 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4609 where the include path doesn't have X11/X.h by default. See
4610 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4612 2011-05-20 Kenichi Handa <handa@m17n.org>
4614 * composite.c (find_automatic_composition): Fix previous change.
4616 2011-05-20 Glenn Morris <rgm@gnu.org>
4618 * lisp.mk: New file, split from Makefile.in.
4619 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4620 (shortlisp): Remove.
4621 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4623 2011-05-19 Glenn Morris <rgm@gnu.org>
4625 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4626 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4627 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4628 (lisp): Set the order to that of loadup.el.
4629 (shortlisp): Make it a copy of $lisp.
4630 (SOME_MACHINE_LISP): Remove.
4631 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4632 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4634 2011-05-18 Kenichi Handa <handa@m17n.org>
4636 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4637 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4638 (find_automatic_composition): Mostly rewrite for efficiency.
4640 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4642 * makefile.w32-in: Update dependencies.
4644 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4646 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4647 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4649 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4651 Fix some integer overflow issues, such as string length overflow.
4653 * insdel.c (count_size_as_multibyte): Check for string overflow.
4655 * character.c (lisp_string_width): Check for string overflow.
4656 Use EMACS_INT, not int, for string indexes and lengths; in
4657 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4658 the resulting string length overflows an EMACS_INT; instead,
4659 report a string overflow if no precision given. When checking for
4660 precision exhaustion, use a check that cannot possibly have
4661 integer overflow. (Bug#8675)
4662 * character.h (lisp_string_width): Adjust to new signature.
4664 * alloc.c (string_overflow): New function.
4665 (Fmake_string): Use it. This doesn't change behavior, but saves
4666 a few bytes and will simplify future changes.
4667 * character.c (string_escape_byte8): Likewise.
4668 * lisp.h (string_overflow): New decl.
4670 Fixups, following up to the user-interface timestamp change.
4671 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4672 for UI timestamps, instead of unsigned long.
4673 * msdos.c (mouse_get_pos): Likewise.
4674 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4675 * w32gui.h (Time): Define by including "systime.h" rather than by
4676 declaring it ourselves. (Bug#8664)
4678 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4679 * image.c (clear_image_cache): Likewise.
4681 * term.c (term_mouse_position): Don't assume time_t wraparound.
4683 Be more systematic about user-interface timestamps.
4684 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4685 and sometimes 'EMACS_UINT', to represent these timestamps.
4686 This change causes it to use 'Time' uniformly, as that's what X uses.
4687 This makes the code easier to follow, and makes it easier to catch
4688 integer overflow bugs such as Bug#8664.
4689 * frame.c (Fmouse_position, Fmouse_pixel_position):
4690 Use Time, not unsigned long, for user-interface timestamps.
4691 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4692 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4693 * keyboard.h (last_event_timestamp): Likewise.
4694 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4695 * menu.h (xmenu_show): Likewise.
4696 * term.c (term_mouse_position): Likewise.
4697 * termhooks.h (struct input_event.timestamp): Likewise.
4698 (struct terminal.mouse_position_hook): Likewise.
4699 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4700 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4701 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4702 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4704 * menu.h, termhooks.h: Include "systime.h", for Time.
4706 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4707 Don't assume that the difference between two unsigned long values
4708 can fit into an integer. At this point, we know button_down_time
4709 <= event->timestamp, so the difference must be nonnegative, so
4710 there's no need to cast the result if double-click-time is
4711 nonnegative, as it should be; check that it's nonnegative, just in
4712 case. This bug is triggered when events are more than 2**31 ms
4713 apart (about 25 days). (Bug#8664)
4715 * xselect.c (last_event_timestamp): Remove duplicate decl.
4716 (x_own_selection): Remove needless cast to unsigned long.
4718 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4719 that always fit in int. Use a sentinel instead of a counter, to
4720 avoid a temp and to allay GCC's concerns about possible int overflow.
4721 * frame.h (struct frame): Use int for menu_bar_items_used
4722 instead of EMACS_INT, since it always fits in int.
4724 * menu.c (grow_menu_items): Check for int overflow.
4726 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4728 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4729 Before, the code was not consistent. These values cannot exceed
4730 2**31 - 1 so there's no need to make them unsigned.
4731 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4732 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4733 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4735 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4737 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4738 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4739 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4740 presumably because the widths might not match.
4742 * window.c (size_window): Avoid needless test at loop start.
4744 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4746 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4748 2011-05-12 Drew Adams <drew.adams@oracle.com>
4750 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4752 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4754 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4755 `width' to `bar_area_x' and `bar_area_width', respectively.
4756 (x_scroll_run): Take account of fringe background extension.
4758 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4759 Rename local vars `left' and `width' to `bar_area_x' and
4760 `bar_area_width', respectively.
4761 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4762 background extension.
4764 2011-05-10 Jim Meyering <meyering@redhat.com>
4766 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4768 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4770 * image.c (Finit_image_library): Return t for built-in image types,
4771 like pbm and xbm. (Bug#8640)
4773 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4775 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4777 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4779 * w32console.c (Fset_screen_color): Doc fix.
4780 (Fget_screen_color): New function.
4781 (syms_of_ntterm): Defsubr it.
4783 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4784 unlink the temporary file if Fcall_process didn't create it in the
4786 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4787 child process will be redirected to a file specified with `:file'.
4788 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4789 cue to call_process_cleanup not to close that handle.
4791 2011-05-07 Ben Key <bkey76@gmail.com>
4793 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4794 one of two shell specific rules, either bootstrap-temacs-CMD or
4795 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4796 to the previous implementation of the bootstrap-temacs rule.
4797 The bootstrap-temacs-CMD rule is similar to the previous
4798 implementation of the bootstrap-temacs rule except that it
4799 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4802 These changes, along with some changes to nt/configure.bat,
4803 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4804 earlier fix to add support for --cflags and --ldflags options
4805 that include quotes so that it works whether make uses cmd or
4808 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4810 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4811 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4813 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4814 a string. Handle both cases.
4815 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4816 (Fdbus_register_method): Use Qinvalid_function.
4818 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4820 * makefile.w32-in: Update dependencies.
4821 (LISP_H): Add inttypes.h and stdin.h.
4822 (PROCESS_H): Add unistd.h.
4824 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4826 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4827 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4829 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4831 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4833 * term.c (vfatal): Remove stray call to va_end.
4834 It's not needed and the C Standard doesn't allow it here anyway.
4836 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4837 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4839 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4842 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4844 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4846 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4848 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4850 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4852 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4853 * charset.c (Fdefine_charset_internal): Don't initialize
4854 charset.code_space[15]. The value was garbage, on hosts with
4855 32-bit int (Bug#8600).
4857 * lread.c (read_integer): Be more consistent with string-to-number.
4858 Use string_to_number to do the actual conversion; this avoids
4859 rounding errors and fixes some other screwups. Without this fix,
4860 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4861 (digit_to_number): Move earlier, for benefit of read_integer.
4862 Return -1 if the digit is out of range for the base, -2 if it is
4863 not a digit in any supported base. (Bug#8602)
4865 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4867 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4868 to match comment at start of function. This also removes a
4869 GCC warning about overflow in a 32+64-bit port.
4871 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4873 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4874 Reported by Stefan Monnier in
4875 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4876 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4877 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4879 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4880 (EMACS_UINTPTR): Likewise, with uintptr_t.
4882 * lisp.h: Prefer 64-bit EMACS_INT if available.
4883 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4884 on 32-bit hosts that have 64-bit int, so that they can access
4886 However, temporarily disable this change unless the temporary
4887 symbol WIDE_EMACS_INT is defined.
4889 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4891 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4892 This removes an assumption that EMACS_INT and long are the same
4893 width as pointers. The assumption is true for Emacs porting targets
4894 now, but we want to make other targets possible.
4895 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4896 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4897 In the rest of the code, change types of integers that hold casted
4898 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4899 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4900 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4901 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4902 No need to cast type when ORing.
4903 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4904 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4905 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4906 assume EMACS_INT is the same width as char *.
4907 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4908 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4909 Remove no-longer-needed casts.
4910 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4911 (xg_tool_bar_help_callback, xg_make_tool_item):
4912 Use EMACS_INTPTR to hold an integer
4913 that will be cast to void *; this can avoid a GCC warning
4914 if EMACS_INT is not the same width as void *.
4915 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4916 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4917 (current_message_1, set_message_1):
4918 Use a local to convert to proper width without a cast.
4919 * xmenu.c (dialog_selection_callback): Likewise.
4921 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4922 Also, don't assume VALBITS / RAND_BITS is less than 5,
4923 and don't rely on undefined behavior when shifting a 1 left into
4925 * lisp.h (get_random): Change signature to match.
4927 * lread.c (hash_string): Use size_t, not int, for hash computation.
4928 Normally we prefer signed values; but hashing is special, because
4929 it's better to use unsigned division on hash table sizes so that
4930 the remainder is nonnegative. Also, size_t is the natural width
4931 for hashing into memory. The previous code used 'int', which doesn't
4932 retain enough info to hash well into very large tables.
4933 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4935 * dbusbind.c: Don't possibly lose pointer info when converting.
4936 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4937 Use XPNTR rather than XHASH, so that the high-order bits of
4938 the pointer aren't lost when converting through void *.
4940 * eval.c (Fautoload): Don't double-shift a pointer.
4942 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4944 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4946 * gnutls.c (DEF_GNUTLS_FN):
4947 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4949 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4951 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4954 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4956 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4957 New version that can reserve upto 2GB of heap space.
4959 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4961 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4963 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4965 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4966 `gnutls_certificate_set_x509_key_file'.
4968 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4970 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4971 Update dependencies.
4973 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4975 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4976 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4977 Remove unused parameter `fildes'.
4978 * process.c (read_process_output, send_process): Don't pass it.
4980 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4982 Fix previous change: the library cache is defined in w32.c.
4983 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4984 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4986 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4988 Implement dynamic loading of GnuTLS on Windows.
4990 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4991 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4992 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4995 * gnutls.c (Qgnutls_dll): Define.
4996 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4997 (gnutls_*): Declare function pointers.
4998 (init_gnutls_functions): New function to initialize function pointers.
4999 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5000 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5001 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5002 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5003 (emacs_gnutls_write, emacs_gnutls_read)
5004 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5005 (Fgnutls_available_p): New function.
5006 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5007 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5008 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5010 * image.c: Include w32.h.
5011 (Vimage_type_cache): Delete.
5012 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5013 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5014 (w32_delayed_load): Move to w32.c.
5016 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5018 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5019 (w32_delayed_load): Move from image.c. When loading a library, record
5020 its filename in the :loaded-from property of the library id.
5021 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5022 Initialize and staticpro them.
5023 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5025 * process.c: Include lisp.h before w32.h, not after.
5026 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5027 instead of gnutls_record_check_pending.
5029 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5031 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5033 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5034 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5037 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5039 * xterm.c (x_set_frame_alpha): Do not set property on anything
5040 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5042 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5044 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5046 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5048 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5049 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5050 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5051 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5052 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5053 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5054 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5055 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5056 (Qgnutls_bootprop_callbacks_verify): Make static.
5058 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5060 * callproc.c: Indentation fixup.
5062 * sysdep.c (wait_for_termination_1): Make static.
5063 (wait_for_termination, interruptible_wait_for_termination):
5064 Move after wait_for_termination_1.
5066 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5068 * sysdep.c (interruptible_wait_for_termination): New function
5069 which is like wait_for_termination, but allows keyboard
5072 * callproc.c (Fcall_process): Add (:file "file") as an option for
5074 (Fcall_process_region): Ditto.
5076 2011-04-30 Eli Zaretskii <eliz@gnu.org>
5078 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5079 rather than `XVECTOR (FOO)->size'.
5081 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5082 inttypes.h, as a gnulib replacement is used if it not available in
5085 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5087 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5088 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5089 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5091 * coding.c (coding_alloc_by_realloc): Error out if destination
5092 will grow beyond MOST_POSITIVE_FIXNUM.
5093 (decode_coding_emacs_mule): Abort if there isn't enough place in
5094 charbuf for the composition carryover bytes. Reserve an extra
5095 space for up to 2 characters produced in a loop.
5096 (decode_coding_iso_2022): Abort if there isn't enough place in
5097 charbuf for the composition carryover bytes.
5099 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5101 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5102 aborting when %lld or %lll format is passed.
5103 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5104 %llo or %llx format is passed. (Bug#8545)
5106 * window.c (window_scroll_line_based): Use a marker instead of
5107 simple variables to record original value of point. (Bug#7952)
5109 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5110 produced by %s or %c overflows available buffer space. (Bug#8545)
5112 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5114 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5115 (SIZE_MAX): Move defn after all includes, as they might #define it.
5117 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5119 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5121 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5123 * keyboard.c (Qdelayed_warnings_hook): Define.
5124 (command_loop_1): Run `delayed-warnings-hook'
5125 if Vdelayed_warnings_list is non-nil.
5126 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5127 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5129 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5131 * doprnt.c (doprnt): Don't return value smaller than the buffer
5132 size if the message was truncated. (Bug#8545).
5134 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5136 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5137 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5139 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5141 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5143 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5145 * makefile.w32-in: Update dependencies.
5147 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5149 Improve `doprnt' and its usage. (Bug#8545)
5150 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5151 `format_end'. Remove support for %l as a conversion specifier.
5152 Don't use xrealloc. Improve diagnostics when the %l size modifier
5153 is used. Update the commentary.
5155 * eval.c (verror): Simplify calculation of size_t.
5157 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5160 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5162 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5165 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5167 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5168 This makes this file independent of the recent pseudovector change.
5170 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5172 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5174 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5175 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5176 Remove unused local.
5177 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5179 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5180 GCC 4.6.0 optimizes based on type-based alias analysis.
5181 For example, if b is of type struct buffer * and v of type struct
5182 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5183 != &v->size, and therefore "v->size = 1; b->size = 2; return
5184 v->size;" must therefore return 1. This assumption is incorrect
5185 for Emacs, since it type-puns struct Lisp_Vector * with many other
5186 types. To fix this problem, this patch adds a new type struct
5187 vectorlike_header that documents the constraints on layout of vectors
5188 and pseudovectors, and helps optimizing compilers not get fooled
5189 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5190 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5191 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5193 (XSETPVECTYPE): Rewrite in terms of new macro.
5194 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5195 This is a bit clearer, and further avoids the possibility of
5196 undesirable aliasing.
5197 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5198 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5199 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5200 since Lisp_Subr is a special case (no "next" field).
5201 (ASIZE): Now uses header.size rather than size.
5202 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5203 to avoid the hassle of writing XVECTOR (foo)->header.size.
5204 (struct vectorlike_header): New type.
5205 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5206 object, to help avoid aliasing.
5207 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5208 (SUBRP): Likewise, since Lisp_Subr is a special case.
5209 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5210 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5211 (struct Lisp_Hash_Table): Combine first two members into a single
5212 struct vectorlike_header member. All uses of "size" and "next" members
5213 changed to be "header.size" and "header.next".
5214 * buffer.h (struct buffer): Likewise.
5215 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5216 * frame.h (struct frame): Likewise.
5217 * process.h (struct Lisp_Process): Likewise.
5218 * termhooks.h (struct terminal): Likewise.
5219 * window.c (struct save_window_data, struct saved_window): Likewise.
5220 * window.h (struct window): Likewise.
5221 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5222 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5223 * buffer.c (init_buffer_once): Likewise.
5224 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5226 * process.c (Fformat_network_address): Use local var for size,
5229 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5231 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5232 * data.c (atof): Remove decl; no longer used or needed.
5233 (digit_to_number): Move to lread.c.
5234 (Fstring_to_number): Use new string_to_number function, to be
5235 consistent with how the Lisp reader treats infinities and NaNs.
5236 Do not assume that floating-point numbers represent EMACS_INT
5237 without losing information; this is not true on most 64-bit hosts.
5238 Avoid double-rounding errors, by insisting on integers when
5239 parsing non-base-10 numbers, as the documentation specifies.
5240 * lisp.h (string_to_number): New decl, replacing ...
5241 (isfloat_string): Remove.
5242 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5243 (read1): Do not accept +. and -. as integers; this
5244 appears to have been a coding error. Similarly, do not accept
5245 strings like +-1e0 as floating point numbers. Do not report
5246 overflow for integer overflows unless the base is not 10 which
5247 means we have no simple and reliable way to continue.
5248 Break out the floating-point parsing into a new
5249 function string_to_number, so that Fstring_to_number parses
5250 floating point numbers consistently with the Lisp reader.
5251 (digit_to_number): Move here from data.c. Make it static inline.
5252 (E_CHAR, EXP_INT): Remove, replacing with ...
5253 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5254 (string_to_number): New function, replacing isfloat_string.
5255 This function checks for valid syntax and produces the resulting
5256 Lisp float number too. Rework it so that string-to-number
5257 no longer mishandles examples like "1.0e+". Use strtoumax,
5258 so that overflow for non-base-10 numbers is reported only when
5259 there's no portable and simple way to convert to floating point.
5261 * textprop.c (set_text_properties_1): Rewrite for clarity,
5262 and to avoid GCC warning about integer overflow.
5264 * intervals.h (struct interval): Use EMACS_INT for members
5265 where EMACS_UINT might cause problems. See
5266 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5267 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5268 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5270 (offset_intervals): Tell GCC not to worry about length overflow
5271 when negating a negative length.
5273 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5274 (overrun_check_free): Likewise.
5276 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5277 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5280 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5281 (gnutls_make_error): Rename local to avoid shadowing.
5282 (gnutls_emacs_global_deinit): ifdef out; not used.
5283 (Fgnutls_boot): Use const for pointer to readonly storage.
5284 Comment out unused local. Fix pointer signedness problems.
5286 * lread.c (openp): Don't stuff size_t into an 'int'.
5287 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5288 about possible signed overflow.
5290 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5291 (GDK_KEY_g): Don't define if already defined.
5292 (xg_prepare_tooltip): Avoid pointer signedness problem.
5293 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5295 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5296 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5298 * xfns.c (Fx_window_property): Simplify a bit,
5299 to make a bit faster and to avoid GCC 4.6.0 warning.
5300 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5302 * fns.c (internal_equal): Don't assume size_t fits in int.
5304 * alloc.c (compact_small_strings): Tighten assertion a little.
5306 Replace pEd with more-general pI, and fix some printf arg casts.
5307 * lisp.h (pI): New macro, generalizing old pEd macro to other
5308 conversion specifiers. For example, use "...%"pI"d..." rather
5309 than "...%"pEd"...".
5310 (pEd): Remove. All uses replaced with similar uses of pI.
5311 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5312 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5313 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5314 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5315 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5316 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5317 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5319 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5320 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5321 * print.c (safe_debug_print, print_object): Likewise.
5322 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5324 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5325 avoiding the 0 flag, which is not portable.
5326 * process.c (Fmake_network_process): Use pI to avoid cast.
5327 * region-cache.c (pp_cache): Likewise.
5328 * xdisp.c (decode_mode_spec): Likewise.
5329 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5330 behavior on 64-bit hosts with printf arg.
5331 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5332 (x_stop_queuing_selection_requests): Likewise.
5333 (x_get_window_property): Don't truncate byte count to an 'int'
5336 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5337 here, since it parses constructs like leading '-' and spaces,
5338 which are not wanted; and it overflows with large numbers.
5339 Instead, simply match F[0-9]+, which is what is wanted anyway.
5341 * alloc.c: Remove unportable assumptions about struct layout.
5342 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5343 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5344 (allocate_vectorlike, make_pure_vector): Use the new macros,
5345 plus offsetof, to remove unportable assumptions about struct layout.
5346 These assumptions hold on all porting targets that I know of, but
5347 they are not guaranteed, they're easy to remove, and removing them
5348 makes further changes easier.
5350 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5351 This doesn't fix a bug but makes the code clearer.
5352 (string_overrun_cookie): Now const. Use initializers that
5353 don't formally overflow signed char, to avoid warnings.
5354 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5355 can cause Emacs to crash when string overrun checking is enabled.
5356 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5357 multiple of sizeof (EMACS_INT); it need not be, if
5358 alignof(EMACS_INT) < sizeof (EMACS_INT).
5359 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5361 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5363 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5365 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5367 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5368 supposed to be handshaking. (Bug#8556)
5369 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5371 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5373 * lisp.h (Qdebug): List symbol.
5374 * eval.c (Qdebug): Restore global linkage.
5375 * keyboard.c (debug-on-event): New variable.
5376 (handle_user_signal): Break into debugger when debug-on-event
5377 matches the current signal symbol.
5379 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5381 * alloc.c (check_sblock, check_string_bytes)
5382 (check_string_free_list): Convert to standard C.
5384 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5386 * w32.c (emacs_gnutls_push): Fix typo.
5388 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5390 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5391 "cast to pointer from integer of different size".
5393 Improve doprnt and its use in verror. (Bug#8545)
5394 * doprnt.c (doprnt): Document the set of format control sequences
5395 supported by the function. Use SAFE_ALLOCA instead of always
5398 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5399 is one byte too soon. Don't use xrealloc; instead xfree and
5402 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5404 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5407 * gnutls.c: Renamed global_initialized to
5408 gnutls_global_initialized. Added internals for the
5409 :verify-hostname-error, :verify-error, and :verify-flags
5410 parameters of `gnutls-boot' and documented those parameters in the
5411 docstring. Start callback support.
5412 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5413 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5414 on error. Return error code.
5415 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5416 (emacs_gnutls_read): Likewise.
5417 (Fgnutls_boot): Return handshake error code.
5418 (emacs_gnutls_handle_error): New function.
5419 (wsaerror_to_errno): Likewise.
5421 * w32.h (emacs_gnutls_pull): Add prototype.
5422 (emacs_gnutls_push): Likewise.
5424 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5425 (emacs_gnutls_push): Likewise.
5427 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5429 * process.c (wait_reading_process_output): Check if GnuTLS
5430 buffered some data internally if no FDs are set for TLS
5433 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5434 (LIBS): Link to USER_LIBS.
5435 ($(BLD)/gnutls.$(0)): New target.
5437 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5439 * xdisp.c (handle_single_display_spec): Rename the
5440 display_replaced_before_p argument into display_replaced_p, to
5441 make it consistent with the commentary. Fix typos in the
5444 * textprop.c (syms_of_textprop): Remove dead code.
5445 (copy_text_properties): Delete obsolete commentary about an
5446 interface that was deleted long ago. Fix typos in the description
5449 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5450 to changes in oldXMenu/XMenu.h from 2011-04-16.
5451 <menu_help_message, prev_menu_help_message>: Constify.
5452 (IT_menu_make_room): menu->help_text is now `const char **';
5455 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5456 to changes in oldXMenu/XMenu.h from 2011-04-16.
5457 (struct XMenu): Declare `help_text' `const char **'.
5459 * xfaces.c <Qunspecified>: Make extern again.
5461 * syntax.c: Include sys/types.h before including regex.h, as
5464 * doc.c (get_doc_string): Improve the format passed to `error'.
5466 * doprnt.c (doprnt): Improve commentary.
5468 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5470 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5473 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5474 changes in globals.h immediately force recompilation.
5475 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5476 $(CURDIR)/s/ms-w32.h.
5477 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5479 * character.c (Fchar_direction): Function deleted.
5480 (syms_of_character): Don't defsubr it.
5481 <char-direction-table>: Deleted.
5483 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5485 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5486 * doprnt.c: Include limits.h.
5487 (SIZE_MAX): New macro.
5488 (doprnt): Return a size_t value. 2nd arg is now size_t.
5489 Many local variables are now size_t instead of int or unsigned.
5490 Improve overflow protection. Support `l' modifier for integer
5491 conversions. Support %l conversion. Don't assume an EMACS_INT
5492 argument for integer conversions and for %c.
5494 * lisp.h (doprnt): Restore prototype.
5496 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5499 * Makefile.in (base_obj): Add back doprnt.o.
5501 * deps.mk (doprnt.o): Add back prerequisites.
5502 (callint.o): Depend on character.h.
5504 * eval.c (internal_lisp_condition_case): Include the handler
5505 representation in the error message.
5506 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5507 when breaking from the loop.
5509 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5511 * callint.c (Fcall_interactively): When displaying error message
5512 about invalid control letter, pass the character's codepoint, not
5513 a pointer to its multibyte form. Improve display of the character
5514 in octal and display also its hex code.
5516 * character.c (char_string): Use %x to display the (unsigned)
5517 codepoint of an invalid character, to avoid displaying a bogus
5520 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5521 `error', not SYMBOL_NAME itself.
5523 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5524 character arguments to `error'.
5526 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5527 to `error' in error message about FINAL_CHAR argument. Make sure
5528 FINAL_CHAR is a character, and use %c when it is passed as
5529 argument to `error'.
5531 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5533 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5535 * w32.c: Include <time.h>.
5536 (sys_localtime): New function.
5538 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5540 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5542 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5544 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5546 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5549 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5551 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5552 gl_state.e_property when gl_state.object is Qt.
5554 * insdel.c (make_gap_larger): Remove limitation of buffer size
5557 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5559 * xdisp.c (lookup_glyphless_char_display)
5560 (produce_glyphless_glyph): Handle cons cell entry in
5561 glyphless-char-display.
5562 (Vglyphless_char_display): Document it.
5564 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5565 glyphless-char-display.
5567 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5569 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5571 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5573 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5574 definition for no-X builds.
5576 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5578 Static checks with GCC 4.6.0 and non-default toolkits.
5580 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5582 * process.c (keyboard_bit_set): Define only if SIGIO.
5583 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5584 (send_process): Repair possible setjmp clobbering.
5586 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5588 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5590 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5592 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5593 Define only if needed.
5595 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5596 by pacifying GCC about it. Maybe it's time to retire it?
5597 * xfaces.c (USG, __TIMEVAL__): Likewise.
5599 * dispextern.h (struct redisplay_interface): Rename param
5601 * termhooks.h (struct terminal): Likewise.
5602 * xterm.c (xembed_send_message): Likewise.
5604 * insdel.c (make_gap_smaller): Define only if
5605 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5607 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5610 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5611 so that we aren't warned about unused symbols.
5613 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5615 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5617 * xfns.c (x_real_positions): Mark locals as initialized.
5619 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5621 * xterm.c: Fix problems found by static analysis with other toolkits.
5622 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5623 (x_dispatch_event): Declare static if USE_GTK, and
5624 define if USE_GTK || USE_X_TOOLKIT.
5625 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5626 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5627 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5628 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5630 * xmenu.c (menu_help_callback): Pointer type fixes.
5631 Use const pointers when pointing at readonly data. Avoid pointer
5633 (FALSE): Remove unused macro.
5634 (update_frame_menubar): Remove unused decl.
5636 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5638 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5639 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5640 (single_menu_item): Rename local to avoid shadowing.
5642 * keyboard.c (make_lispy_event): Remove unused local var.
5644 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5645 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5647 * bitmaps: Change bitmaps from unsigned char back to the X11
5648 compatible char. Avoid the old compiler warnings about
5649 out-of-range initializers by using, for example, '\xab' rather
5652 * xgselect.c (xgselect_initialize): Check vs interface
5653 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5655 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5657 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5658 to read-only memory.
5660 * fns.c (vector): Remove; this old hack is no longer needed.
5662 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5664 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5666 * xrdb.c (x_load_resources): Omit unused local.
5668 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5669 (x_window): Rename locals to avoid shadowing.
5670 (USG): Use the kludged USG macro, to pacify gcc.
5672 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5673 (x_term_init): Remove local to avoid shadowing.
5675 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5677 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5678 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5680 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5682 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5684 Fix regex.c, syntax.c and friends for buffers > 2GB.
5685 * syntax.h (struct gl_state_s): Declare character position members
5688 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5690 * textprop.c (verify_interval_modification, interval_of):
5691 Declare arguments EMACS_INT.
5693 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5696 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5698 * indent.c (Fvertical_motion): Local variable it_start is now
5701 * regex.c (re_match, re_match_2, re_match_2_internal)
5702 (bcmp_translate, regcomp, regexec, print_double_string)
5703 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5704 (re_compile_pattern, re_exec): Declare arguments and local
5705 variables `size_t' and `ssize_t' and return values `regoff_t', as
5707 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5708 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5709 <compile_stack_type>: `size' and `avail' are now `size_t'.
5711 * regex.h <regoff_t>: Use ssize_t, not int.
5712 (re_search, re_search_2, re_match, re_match_2): Arguments that
5713 specify buffer/string position and length are now ssize_t and
5714 size_t. Return type is regoff_t.
5716 2011-04-16 Ben Key <bkey76@gmail.com>
5718 * nsfont.m: Fixed bugs in ns_get_family and
5719 ns_descriptor_to_entity that were caused by using free to
5720 deallocate memory blocks that were allocated by xmalloc (via
5721 xstrdup). This caused Emacs to crash when compiled with
5722 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5723 --enable-checking=xmallocoverrun). xfree is now used to
5724 deallocate these memory blocks.
5726 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5728 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5730 emacs_write: Accept and return EMACS_INT for sizes.
5731 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5733 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5734 Accept and return EMACS_INT.
5735 (emacs_gnutls_write): Return the number of bytes written on
5737 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5738 (emacs_read, emacs_write): Remove check for negative size, as the
5739 Emacs source code has been audited now.
5740 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5741 (emacs_read, emacs_write): Use it.
5742 * process.c (send_process): Adjust to the new signatures of
5743 emacs_write and emacs_gnutls_write. Do not attempt to store
5744 a byte offset into an 'int'; it might overflow.
5745 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5747 * sound.c: Don't assume sizes fit in 'int'.
5748 (struct sound_device.period_size, alsa_period_size):
5749 Return EMACS_INT, not int.
5750 (struct sound_device.write, vox_write, alsa_write):
5751 Accept EMACS_INT, not int.
5752 (wav_play, au_play): Use EMACS_INT to store sizes and to
5753 record read return values.
5755 2011-04-15 Ben Key <bkey76@gmail.com>
5757 * keyboard.c (Qundefined): Don't declare static since it is used
5759 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5760 static since they are used in nsfont.m.
5762 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5764 * process.c (Qprocessp): Don't declare static.
5765 * lisp.h (Qprocessp): Declare again.
5767 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5769 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5771 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5773 Improve C-level modularity by making more things 'static'.
5775 Don't publish debugger-only interfaces to other modules.
5776 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5777 (verify_bytepos, count_markers): Move decls to the only modules
5779 * region-cache.h (pp_cache): Likewise.
5780 * window.h (check_all_windows): Likewise.
5781 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5783 * sysdep.c (croak): Now static, if
5784 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5785 * syssignal.h (croak): Declare only if not static.
5787 * alloc.c (refill_memory_reserve): Now static if
5788 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5789 * lisp.h (refill_memory_reserve): Declare only if not static.
5791 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5792 Define only if USE_LUCID.
5794 * xrdb.c (x_customization_string, x_rm_string): Now static.
5796 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5797 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5799 * xdisp.c (draw_row_with_mouse_face): Now static.
5800 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5802 * window.h (check_all_windows): Mark externally visible.
5804 * window.c (window_deletion_count): Now static.
5806 * undo.c: Make symbols static if they're not exported.
5807 (last_undo_buffer, last_boundary_position, pending_boundary):
5810 * textprop.c (interval_insert_behind_hooks): Now static.
5811 (interval_insert_in_front_hooks): Likewise.
5813 * term.c: Make symbols static if they're not exported.
5814 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5815 (max_frame_lines, tty_set_terminal_modes):
5816 (tty_reset_terminal_modes, tty_turn_off_highlight):
5817 (get_tty_terminal): Now static.
5818 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5819 * termhooks.h (term_mouse_moveto): Do not declare if
5821 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5822 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5824 * sysdep.c: Make symbols static if they're not exported.
5825 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5827 (sigprocmask_set, full_mask): Remove; unused.
5828 (wait_debugging): Mark as visible.
5829 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5830 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5832 * syntax.c (syntax_temp): Define only if !__GNUC__.
5834 * sound.c (current_sound_device, current_sound): Now static.
5836 * search.c (searchbufs, searchbuf_head): Now static.
5838 * scroll.c (scroll_cost): Remove; unused.
5839 * dispextern.h (scroll_cost): Remove decl.
5841 * region-cache.h (pp_cache): Mark as externally visible.
5843 * process.c: Make symbols static if they're not exported.
5844 (process_tick, update_tick, create_process, chan_process):
5845 (Vprocess_alist, proc_buffered_char, datagram_access):
5846 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5847 (deactivate_process): Mark defn as static, as well as decl.
5848 * lisp.h (create_process): Remove decl.
5849 * process.h (chan_process, Vprocess_alist): Remove decls.
5851 * print.c: Make symbols static if they're not exported.
5852 (print_depth, new_backquote_output, being_printed, print_buffer):
5853 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5854 (print_interval, print_number_index, initial_stderr_stream):
5856 * lisp.h (Fprinc): Remove decl.
5857 (debug_output_compilation_hack): Mark as externally visible.
5859 * sysdep.c (croak): Move decl from here to syssignal.h.
5860 * syssignal.h (croak): Put it here, so the API can be checked when
5861 'croak' is called from dissociate_if_controlling_tty.
5863 * minibuf.c: Make symbols static if they're not exported.
5864 (minibuf_save_list, choose_minibuf_frame): Now static.
5865 * lisp.h (choose_minibuf_frame): Remove decl.
5867 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5869 * lread.c: Make symbols static if they're not exported.
5870 (read_objects, initial_obarray, oblookup_last_bucket_number):
5872 (make_symbol): Remove; unused.
5873 * lisp.h (initial_obarray, make_symbol): Remove decls.
5875 * keyboard.c: Make symbols static if they're not exported.
5876 (single_kboard, recent_keys_index, total_keys, recent_keys):
5877 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5878 (this_single_command_key_start, echoing, last_auto_save):
5879 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5880 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5881 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5882 (Vlispy_mouse_stem, double_click_count):
5884 (force_auto_save_soon): Define only if SIGDANGER.
5885 (ignore_mouse_drag_p): Now static if
5886 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5887 (print_help): Remove; unused.
5888 (stop_character, last_timer_event): Mark as externally visible.
5889 * keyboard.h (ignore_mouse_drag_p): Declare only if
5890 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5891 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5892 * lisp.h (echoing): Remove decl.
5893 (force_auto_save_soon): Declare only if SIGDANGER.
5894 * xdisp.c (redisplay_window): Simplify code, to make it more
5895 obvious that ignore_mouse_drag_p is not accessed if !defined
5896 USE_GTK && !defined HAVE_NS.
5898 * intervals.c: Make symbols static if they're not exported.
5899 (merge_properties_sticky, merge_interval_right, delete_interval):
5901 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5903 * insdel.c: Make symbols static if they're not exported.
5904 However, leave prepare_to_modify_buffer alone. It's never
5905 called from outside this function, but that appears to be a bug.
5906 (combine_after_change_list, combine_after_change_buffer):
5907 (adjust_after_replace, signal_before_change): Now static.
5908 (adjust_after_replace_noundo): Remove; unused.
5909 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5910 (signal_before_change): Remove decls.
5912 * indent.c (val_compute_motion, val_vmotion): Now static.
5914 * image.c: Make symbols static if they're not exported.
5915 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5917 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5918 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5920 * fringe.c (standard_bitmaps): Now static.
5921 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5923 * frame.c: Make symbols static if they're not exported.
5924 (x_report_frame_params, make_terminal_frame): Now static.
5925 (get_frame_param): Now static, unless HAVE_NS.
5926 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5927 (x_get_resource_string): Remove; not used.
5928 * frame.h (make_terminal_frame, x_report_frame_params):
5929 (x_get_resource_string); Remove decls.
5930 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5931 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5933 * font.c, fontset.c: Make symbols static if they're not exported.
5934 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5935 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5936 * font.c (font_close_object): Now static.
5937 * font.h (font_close_object): Remove.
5938 * fontset.c (FONTSET_OBJLIST): Remove.
5939 (free_realized_fontset) #if-0 the body, which does nothing.
5940 (face_suitable_for_char_p): #if-0, as it's never called.
5941 * fontset.h (face_suitable_for_char_p): Remove decl.
5942 * xfaces.c (face_at_string_position):
5943 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5944 since 0 is always ASCII.
5946 * fns.c (weak_hash_tables): Now static.
5948 * fileio.c: Make symbols static if they're not exported.
5949 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5950 (Vwrite_region_annotation_buffers): Now static.
5952 * eval.c: Make symbols static if they're not exported.
5953 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5954 * lisp.h (backtrace_list): Remove decl.
5956 * emacs.c: Make symbols static if they're not exported.
5957 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5958 (fatal_error_code, fatal_error_signal_hook, standard_args):
5960 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5961 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5962 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5963 * lisp.h (fatal_error_signal_hook): Remove decl.
5964 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5966 * editfns.c: Move a (normally-unused) function to its only use.
5967 * editfns.c, lisp.h (get_operating_system_release): Remove.
5968 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5969 worth the hassle of breaking this out.
5971 * xterm.c: Make symbols static if they're not exported.
5972 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5973 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5974 (x_destroy_window, x_delete_display):
5976 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5977 (x_mouse_leave): Remove; unused.
5978 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5979 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5980 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5982 (x_mouse_leave): Declare only if WINDOWSNT.
5983 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5984 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5987 * ftxfont.c: Make symbols static if they're not exported.
5988 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5990 * font.h (ftxfont_driver): Likewise.
5992 * xfns.c: Make symbols static if they're not exported.
5993 (x_last_font_name, x_display_info_for_name):
5994 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5995 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5996 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5997 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5998 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5999 (last_show_tip_args): Now static.
6000 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6001 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6002 (x_screen_planes): Remove; unused.
6003 * dispextern.h (x_screen_planes): Remove decl.
6005 * dispnew.c: Make symbols static if they're not exported.
6006 * dispextern.h (redraw_garbaged_frames, scrolling):
6007 (increment_row_positions): Remove.
6008 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6009 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6011 (redraw_garbaged_frames): Remove; unused.
6013 * xfaces.c: Make symbols static if they're not exported.
6014 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6016 * xterm.h (defined_color): Remove decls.
6017 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6018 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6019 (menu_face_changed_default, defined_color, free_realized_face):
6020 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6021 (ascii_face_of_lisp_face): Remove; unused.
6023 * xdisp.c: Make symbols static if they're not exported.
6024 * dispextern.h (scratch_glyph_row, window_box_edges):
6025 (glyph_to_pixel_coords, set_cursor_from_row):
6026 (get_next_display_element, set_iterator_to_next):
6027 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6028 (show_mouse_face): Remove decls
6029 * frame.h (message_buf_print): Likewise.
6030 * lisp.h (pop_message, set_message, check_point_in_composition):
6032 * xterm.h (set_vertical_scroll_bar): Likewise.
6033 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6034 (message_buf_print, scratch_glyph_row, displayed_buffer):
6035 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6036 (get_next_display_element, show_mouse_face, window_box_edges):
6037 (frame_to_window_pixel_xy, check_point_in_composition):
6038 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6039 (glyph_to_pixel_coords): Remove; unused.
6041 * dired.c (file_name_completion): Now static.
6043 * dbusbind.c (xd_in_read_queued_messages): Now static.
6045 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6046 * data.c (circular_list_error): Remove.
6048 * commands.h (last_point_position, last_point_position_buffer):
6049 (last_point_position_window): Remove decls.
6050 * keyboard.c: Make these variables static.
6052 * coding.h (coding, code_convert_region, encode_coding_gap):
6054 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6055 (iso_code_class, detect_coding, code_convert_region): Now static.
6056 (encode_coding_gap): Remove; unused.
6058 * chartab.c (chartab_chars, chartab_bits): Now static.
6060 * charset.h (charset_iso_8859_1): Remove decl.
6061 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6064 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6065 * ccl.c (Vccl_program_table): Now static.
6066 (check_ccl_update): Remove; unused.
6068 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6069 * category.h: ... from here.
6070 * category.c (check_category_table, set_category_set): Now static.
6072 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6073 * lisp.h: Remove these decls.
6075 * buffer.c (buffer_count): Remove unused var.
6077 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6078 so that it's not optimized away.
6079 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6080 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6081 exported only to the debugger.
6083 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
6084 * atimer.h (run_all_atimers): Remove; not exported.
6086 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6087 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6088 was inaccessible from Lisp.
6089 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6090 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6092 alloc.c: Import and export fewer symbols, and remove unused items.
6093 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6095 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6096 it's not optimized away by whole-program optimization.
6097 (message_enable_multibyte, free_misc): Remove.
6098 (catchlist, handlerlist, mark_backtrace):
6099 Declare only if BYTE_MARK_STACK.
6100 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6101 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6102 (message_enable_multibyte): Remove decl.
6103 (free_misc, interval_free_list, float_block, float_block_index):
6104 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6105 (cons_free_list, last_marked_index):
6107 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6108 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6109 (mark_backtrace): Define only if BYTE_MARK_STACK.
6110 * xdisp.c (message_enable_multibyte): Now static.
6112 Declare Lisp_Object Q* variables to be 'static' if not exported.
6113 This makes it easier for human readers (and static analyzers)
6114 to see whether these variables are used from other modules.
6115 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6116 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6117 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6118 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6119 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6120 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6121 * xmenu.c, xselect.c:
6122 Declare Q* vars static if they are not used in other modules.
6123 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6124 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6125 Remove decls of unexported vars.
6126 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6128 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6130 Make Emacs functions such as Fatom 'static' by default.
6131 This makes it easier for human readers (and static analyzers)
6132 to see whether these functions can be called from other modules.
6133 DEFUN now defines a static function. To make the function external
6134 so that it can be used in other C modules, use the new macro DEFUE.
6135 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6136 (Finit_image_library):
6137 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6138 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6139 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6140 Remove decls, since these functions are now static.
6141 (Funintern, Fget_internal_run_time): New decls, since these functions
6142 were already external.
6144 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6145 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6146 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6147 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6148 * keyboard.c, keymap.c, lread.c:
6149 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6150 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6151 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6152 Mark functions with DEFUE instead of DEFUN,
6153 if they are used in other modules.
6154 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6155 decls for now-static functions.
6156 * buffer.h (Fdelete_overlay): Remove decl.
6157 * callproc.c (Fgetenv_internal): Mark as internal.
6158 * composite.c (Fremove_list_of_text_properties): Remove decl.
6159 (Fcomposition_get_gstring): New forward static decl.
6160 * composite.h (Fcomposite_get_gstring): Remove decl.
6161 * dired.c (Ffile_attributes): New forward static decl.
6162 * doc.c (Fdocumntation_property): New forward static decl.
6163 * eval.c (Ffetch_bytecode): New forward static decl.
6164 (Funintern): Remove extern decl; now in .h file where it belongs.
6165 * fileio.c (Fmake_symbolic_link): New forward static decl.
6166 * image.c (Finit_image_library): New forward static decl.
6167 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6168 * intervals.h (Fprevious_property_change):
6169 (Fremove_list_of_text_properties): Remove decls.
6170 * keyboard.c (Fthis_command_keys): Remove decl.
6171 (Fcommand_execute): New forward static decl.
6172 * keymap.c (Flookup_key): New forward static decl.
6173 (Fcopy_keymap): Now static.
6174 * keymap.h (Flookup_key): Remove decl.
6175 * process.c (Fget_process): New forward static decl.
6176 (Fprocess_datagram_address): Mark as internal.
6177 * syntax.c (Fsyntax_table_p): New forward static decl.
6178 (skip_chars): Remove duplicate decl.
6179 * textprop.c (Fprevious_property_change): New forward static decl.
6180 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6182 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6183 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6185 * editfns.c (Fformat): Remove unreachable code.
6187 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6189 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6192 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6194 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6195 when at ZV. (Bug#8487)
6197 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6199 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6201 * keyboard.c (parse_tool_bar_item): Likewise.
6202 * sound.c (sound_cleanup, alsa_close): Likewise.
6203 * termcap.c (tgetent): Likewise.
6204 * xfns.c (x_default_font_parameter): Likewise.
6205 * xsettings.c (read_and_apply_settings): Likewise.
6207 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6208 (overrun_check_free): Protoize.
6210 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6212 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6213 since callers should never pass a negative size.
6214 Change the signature to match that of plain 'read' and 'write'; see
6215 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6216 * lisp.h: Update prototypes of emacs_write and emacs_read.
6218 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6220 * xdisp.c (redisplay_window): Don't try to determine the character
6221 position of the scroll margin if the window start point w->startp
6222 is outside the buffer's accessible region. (Bug#8468)
6224 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6226 Fix write-region and its subroutines for buffers > 2GB.
6227 * fileio.c (a_write, e_write): Modify declaration of arguments and
6228 local variables to support buffers larger than 2GB.
6229 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6231 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6232 argument, local variables, and return value.
6234 * lisp.h: Update prototypes of emacs_write and emacs_read.
6236 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6238 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6240 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6242 Fix more problems found by GCC 4.6.0's static checks.
6244 * xdisp.c (vmessage): Use a better test for character truncation.
6246 * charset.c (load_charset_map): <, not <=, for optimization,
6247 and to avoid potential problems with integer overflow.
6248 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6249 * casetab.c (set_identity, shuffle): Likewise.
6250 * editfns.c (Fformat): Likewise.
6251 * syntax.c (skip_chars): Likewise.
6253 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6254 This also lets GCC 4.6.0 generate slightly better loop code.
6256 * callint.c (Fcall_interactively): <, not <=, for optimization.
6257 (Fcall_interactively): Count the number of arguments produced,
6258 not the number of arguments given. This is simpler and lets GCC
6259 4.6.0 generate slightly better code.
6261 * ftfont.c: Distingish more carefully between FcChar8 and char.
6262 The previous code passed unsigned char * to a functions like
6263 strlen and xstrcasecmp that expect char *, which does not
6264 conform to the C standard.
6265 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6266 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6267 char * when the C standard requires it.
6269 * keyboard.c (read_char): Remove unused var.
6271 * eval.c: Port to Windows vsnprintf (Bug#8435).
6273 (SIZE_MAX): Define if the headers do not.
6274 (verror): Do not give up if vsnprintf returns a negative count.
6275 Instead, grow the buffer. This ports to Windows vsnprintf, which
6276 does not conform to C99. Problem reported by Eli Zaretskii.
6277 Also, simplify the allocation scheme, by avoiding the need for
6278 calling realloc, and removing the ALLOCATED variable.
6280 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6282 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6283 But keep the doprint source code for now, as we might revamp it
6284 and use it again (Bug#8435).
6285 * lisp.h (doprnt): Remove.
6286 * Makefile.in (base_obj): Remove doprnt.o.
6287 * deps.mk (doprnt.o): Remove.
6289 error: Print 32- and 64-bit integers portably (Bug#8435).
6290 Without this change, on typical 64-bit hosts error ("...%d...", N)
6291 was used to print both 32- and 64-bit integers N, which relied on
6293 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6295 * lisp.h (error, verror): Mark as printf-like functions.
6296 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6297 Report overflow in size calculations when allocating printf buffer.
6298 Do not truncate output string at its first null byte.
6299 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6300 Truncate the output at a character boundary, since vsnprintf does not
6302 * charset.c (check_iso_charset_parameter): Convert internal
6303 character to string before calling 'error', since %c now has the
6305 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6306 overflow when computing char to be passed to 'error'. Do not
6307 pass Lisp_Object to 'error'; pass the integer instead.
6308 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6309 formatted with plain %d.
6311 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6313 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6315 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6317 * xterm.c (x_catch_errors): Remove duplicate declaration.
6319 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6321 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6323 2011-04-10 Jim Meyering <meyering@redhat.com>
6325 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6326 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6327 return ssize_t not "int", and use size_t as the buffer length.
6328 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6329 * gnutls.h: Update declarations.
6330 * process.c (read_process_output): Use ssize_t, to match.
6331 (send_process): Likewise.
6333 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6335 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6337 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6339 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6340 Use unsigned char, to match FcChar8 type definition.
6342 * xterm.c (handle_one_xevent):
6343 * xmenu.c (create_and_show_popup_menu):
6344 * xselect.c (x_decline_selection_request)
6345 (x_reply_selection_request): Avoid type-punned deref of X events.
6347 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6349 Fix some uses of `int' instead of EMACS_INT.
6350 * search.c (string_match_1, fast_string_match)
6351 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6352 (scan_buffer, find_next_newline_no_quit)
6353 (find_before_next_newline, search_command, Freplace_match)
6354 (Fmatch_data): Make some `int' variables be EMACS_INT.
6356 * xdisp.c (display_count_lines): 3rd argument and return value now
6357 EMACS_INT. All callers changed.
6358 (pint2hrstr): Last argument is now EMACS_INT.
6360 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6361 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6362 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6363 (decode_coding_utf_16, decode_coding_emacs_mule)
6364 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6365 (decode_coding_ccl, decode_coding_charset)
6366 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6367 (decode_coding_iso_2022, decode_coding_emacs_mule)
6368 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6369 <char_offset, last_offset>: Declare EMACS_INT.
6370 (encode_coding_utf_8, encode_coding_utf_16)
6371 (encode_coding_emacs_mule, encode_invocation_designation)
6372 (encode_designation_at_bol, encode_coding_iso_2022)
6373 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6374 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6376 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6377 (encode_invocation_designation): Last argument P_NCHARS is now
6379 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6380 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6382 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6385 * ccl.c (Fccl_execute_on_string): Declare some variables
6388 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6390 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6392 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6394 * process.c (Fformat_network_address): Doc fix.
6396 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6398 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6400 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6402 * keyboard.c (read_char): Call Lisp function help-form-show,
6403 instead of using internal_with_output_to_temp_buffer.
6404 (Qhelp_form_show): New var.
6405 (syms_of_keyboard): Use DEFSYM macro.
6407 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6409 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6411 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6413 * process.c (Flist_processes): Remove to Lisp.
6414 (list_processes_1): Delete.
6416 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6418 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6420 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6422 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6424 Fix more problems found by GCC 4.6.0's static checks.
6426 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6428 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6430 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6432 * xdisp.c (vmessage): Mark as a printf-like function.
6434 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6436 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6438 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6439 printf-like functions.
6440 (tiff_load): Add casts to remove these marks before passing them
6441 to system-supplied API.
6443 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6445 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6446 This avoids several warnings with gcc -Wstrict-overflow.
6447 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6448 directly, rather than having caller test rule sign. This avoids
6449 some unnecessary tests.
6450 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6451 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6452 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6454 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6455 (xfont_open): Avoid unnecessary tests.
6457 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6459 * composite.h, composite.c (composition_gstring_put_cache):
6460 Use EMACS_INT, not int, for length.
6462 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6463 breaking out part of COMPOSITION_DECODE_RULE.
6464 (COMPOSITION_DECODE_RULE): Use it.
6465 * composite.c (get_composition_id): Remove unused local vars,
6466 by using the new macro.
6468 * textprop.c (set_text_properties_1): Change while to do-while,
6469 since the condition is always true at first.
6471 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6472 (interval_deletion_adjustment): Return unsigned value.
6475 * process.c (list_processes_1, create_pty, read_process_output):
6476 (exec_sentinel): Remove vars that were set but not used.
6477 (create_pty): Remove unnecessary "volatile"s.
6478 (Fnetwork_interface_info): Avoid possibility of int overflow.
6479 (read_process_output): Do adaptive read buffering even if carryover.
6480 (read_process_output): Simplify nbytes computation if buffered.
6482 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6484 * syntax.c (scan_words): Remove var that was set but not used.
6485 (update_syntax_table): Use unsigned instead of int.
6487 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6488 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6489 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6491 * print.c (print_error_message): Avoid int overflow.
6493 * font.c (font_list_entities): Redo for clarity,
6494 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6496 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6497 (font_score): Avoid potential overflow in diff calculation.
6499 * fns.c (substring_both): Remove var that is set but not used.
6500 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6502 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6504 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6505 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6506 can always succeed if overflow has undefined behavior.
6508 * search.c (boyer_moore, wordify): Remove vars set but not used.
6509 (wordify): Omit three unnecessary tests.
6511 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6512 All callers changed. This avoids the need for an unused var.
6514 * casefiddle.c (casify_region): Remove var that is set but not used.
6516 * dired.c (file_name_completion): Remove var that is set but not used.
6518 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6520 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6521 (Finsert_file_contents): Remove unnecessary code checking fd.
6523 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6524 Check for integer overflow on size calculations.
6526 * buffer.c (Fprevious_overlay_change): Remove var that is set
6529 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6530 Remove vars that are set but not used.
6531 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6532 (timer_check_2): Mark vars as initialized.
6534 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6536 * image.c (lookup_image): Remove var that is set but not used.
6537 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6539 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6540 that are set but not used.
6542 * xfns.c (make_invisible_cursor): Don't return garbage
6543 if XCreateBitmapFromData fails (Bug#8410).
6545 * xselect.c (x_get_local_selection, x_handle_property_notify):
6546 Remove vars that are set but not used.
6548 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6549 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6551 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6552 Remove var that is set but not used.
6553 (scroll_bar_windows_size): Now size_t, not int.
6554 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6557 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6558 (map_tty_color) [!defined MSDOS]: Likewise.
6560 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6562 * coding.c: Remove vars that are set but not used.
6563 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6564 All callers changed.
6565 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6566 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6567 (decode_coding_charset): Remove vars that are set but not used.
6569 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6570 that is set but not used.
6572 * print.c (print_object): Remove var that is set but not used.
6574 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6575 The gnulib version avoids calling malloc in the usual case,
6576 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6577 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6578 * filelock.c (current_lock_owner): Likewise.
6579 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6580 * sysdep.c: Include allocator.h, careadlinkat.h.
6581 (emacs_no_realloc_allocator): New static constant.
6582 (emacs_readlink): New function.
6583 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6584 ../lib/careadlinkat.h.
6586 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6588 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6589 first non-nil return value).
6591 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6593 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6594 if not defined (Bug#8403).
6596 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6598 * xdisp.c (display_count_lines): Remove parameter `start',
6599 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6600 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6601 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6602 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6603 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6604 and thereabouts. All callers changed.
6605 (get_per_char_metric): Remove parameter `f', unused since
6606 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6608 2011-04-02 Jim Meyering <meyering@redhat.com>
6610 do not dereference NULL upon failed strdup
6611 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6612 (ns_get_family): Likewise.
6614 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6616 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6618 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6620 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6623 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6625 Add lexical binding.
6627 * window.c (Ftemp_output_buffer_show): New fun.
6628 (Fsave_window_excursion):
6629 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6631 * lread.c (lisp_file_lexically_bound_p): New function.
6632 (Fload): Bind Qlexical_binding.
6633 (readevalloop): Remove `evalfun' arg.
6634 Bind Qinternal_interpreter_environment.
6635 (Feval_buffer): Bind Qlexical_binding.
6636 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6638 (syms_of_lread): Declare `lexical-binding'.
6640 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6642 * keyboard.c (eval_dyn): New fun.
6643 (menu_item_eval_property): Use it.
6645 * image.c (parse_image_spec): Use Ffunctionp.
6647 * fns.c (concat, mapcar1): Accept byte-code-functions.
6649 * eval.c (Fsetq): Handle lexical vars.
6650 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6651 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6652 (FletX, Flet): Obey lexical binding.
6653 (Fcommandp): Handle closures.
6654 (Feval): New `lexical' arg.
6655 (eval_sub): New function extracted from Feval. Use it almost
6656 everywhere where Feval was used. Look up vars in lexical env.
6658 (Ffunctionp): Move from subr.el.
6659 (Ffuncall): Handle closures.
6660 (apply_lambda): Remove `eval_flags'.
6661 (funcall_lambda): Handle closures and new byte-code-functions.
6662 (Fspecial_variable_p): New function.
6663 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6664 but without exporting it to Lisp.
6666 * doc.c (Fdocumentation, store_function_docstring):
6667 * data.c (Finteractive_form): Handle closures.
6669 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6672 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6674 (exec_byte_code): New function extracted from Fbyte_code to handle new
6675 calling convention for byte-code-functions. Add new byte-codes.
6677 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6679 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6681 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6683 * xdisp.c (redisplay_internal): Fix prototype.
6685 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6687 * xdisp.c (SCROLL_LIMIT): New macro.
6688 (try_scrolling): Use it when setting scroll_limit.
6689 Limit scrolling to 100 screen lines.
6690 (redisplay_window): Even when falling back on "recentering",
6691 position point in the window according to scroll-conservatively,
6692 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6694 (try_scrolling): When point is above the window, allow searching
6695 as far as scroll_max, or one screenful, to compute vertical
6696 distance from PT to the scroll margin position. This prevents
6697 try_scrolling from unnecessarily failing when
6698 scroll-conservatively is set to a value slightly larger than the
6699 window height. Clean up the case of PT below the margin at bottom
6700 of window: scroll_max can no longer be INT_MAX. When aggressive
6701 scrolling is in use, don't let point enter the opposite scroll
6702 margin as result of the scroll.
6703 (syms_of_xdisp) <scroll-conservatively>: Document the
6704 threshold of 100 lines for never-recentering scrolling.
6706 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6708 * dispextern.h (move_it_by_lines):
6709 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6710 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6711 (message_log_check_duplicate): Remove parameters `prev_bol' and
6712 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6713 (redisplay_internal): Remove parameter `preserve_echo_area',
6714 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6716 * indent.c (Fvertical_motion):
6717 * window.c (window_scroll_pixel_based, Frecenter):
6718 Don't pass `need_y_p' to `move_it_by_lines'.
6720 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6722 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6723 steal a few bits to be more compact.
6724 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6725 Remove unneeded casts.
6727 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6729 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6731 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6732 binding" message (bug#7967).
6734 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6736 Fix more problems found by GCC 4.6.0's static checks.
6738 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6739 Remove unused local var.
6741 * editfns.c (Fmessage_box): Remove unused local var.
6743 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6744 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6745 Omit unused local vars.
6746 * window.c (shrink_windows): Omit unused local var.
6747 * menu.c (digest_single_submenu): Omit unused local var.
6748 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6749 Omit unused local var.
6751 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6752 Don't assume string length fits in int.
6753 (keyremap_step, read_key_sequence): Use size_t for sizes.
6754 (read_key_sequence): Don't check last_real_key_start redundantly.
6756 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6757 instead of alloca (Bug#8344).
6759 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6760 (Fbacktrace_frame): Don't assume nframes fits in int.
6762 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6764 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6767 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6769 * cm.c (calccost): Turn while-do into do-while, for clarity.
6771 * keyboard.c (syms_of_keyboard): Use the same style as later
6772 in this function when indexing through an array. This also
6773 works around GCC bug 48267.
6775 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6777 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6779 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6780 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6782 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6783 This avoids undefined behavior on integer overflow, and is a bit
6784 more convenient anyway since it is compared to a size_t variable.
6786 Variadic C functions now count arguments with size_t, not int.
6787 This avoids an unnecessary limitation on 64-bit machines, which
6788 caused (substring ...) to crash on large vectors (Bug#8344).
6789 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6790 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6791 All variadic functions and their callers changed accordingly.
6792 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6793 * data.c (arith_driver, float_arith_driver): Likewise.
6794 * editfns.c (general_insert_function): Likewise.
6795 * eval.c (struct backtrace.nargs, interactive_p)
6796 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6797 (funcall_lambda, mark_backtrace): Likewise.
6798 * fns.c (concat): Likewise.
6799 * frame.c (x_set_frame_parameters): Likewise.
6800 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6801 0 if not found, not -1. All callers changed.
6803 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6804 (stack_copy_size): Now size_t, not int.
6805 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6807 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6809 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6810 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6811 All callers changed.
6813 * lisp.h (multibyte_char_to_unibyte):
6814 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6815 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6816 * character.h (CHAR_TO_BYTE8):
6817 * cmds.c (internal_self_insert):
6818 * editfns.c (general_insert_function):
6819 * keymap.c (push_key_description):
6820 * search.c (Freplace_match):
6821 * xdisp.c (message_dolog, set_message_1): All callers changed.
6823 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6825 * keyboard.c (safe_run_hook_funcall): New function.
6826 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6827 don't set the hook to nil, but remove the offending function instead.
6828 (Qcommand_hook_internal): Remove, unused.
6829 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6830 Vcommand_hook_internal.
6832 * eval.c (enum run_hooks_condition): Remove.
6833 (funcall_nil, funcall_not): New functions.
6834 (run_hook_with_args): Call each function through a `funcall' argument.
6835 Remove `cond' argument, now redundant.
6836 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6837 (Frun_hook_with_args_until_failure): Adjust accordingly.
6838 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6840 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6842 * dispextern.h (string_buffer_position): Remove declaration.
6844 * print.c (strout): Remove parameter `multibyte', unused since
6845 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6847 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6848 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6849 All callers changed.
6851 * w32.c (_wsa_errlist): Use braces for struct initializers.
6853 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6854 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6855 All callers changed.
6856 (string_buffer_position): Likewise. Also, make static (it's never
6857 used outside xdisp.c).
6858 (cursor_row_p): Remove parameter `w', unused since
6859 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6860 (decode_mode_spec): Remove parameter `precision', introduced during
6861 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6862 All callers changed.
6864 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6866 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6868 2011-03-27 Anders Lindgren <andlind@gmail.com>
6870 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6871 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6872 (ns_update_auto_hide_menu_bar): New functions.
6873 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6874 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6875 ns_constrain_all_frames.
6876 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6877 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6879 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6881 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6883 2011-03-27 Glenn Morris <rgm@gnu.org>
6885 * syssignal.h: Replace RETSIGTYPE with void.
6886 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6887 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6888 Replace SIGTYPE with void everywhere.
6889 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6890 * s/template.h (SIGTYPE): Remove commented out definition.
6892 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6894 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6895 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6897 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6899 * w32.c (read_unc_volume): Use parameter `henum', instead of
6900 global variable `wget_enum_handle'.
6902 * keymap.c (describe_vector): Remove parameters `indices' and
6903 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6904 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6906 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6908 * keyboard.c (timer_check): Remove parameter `do_it_now',
6909 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6910 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6911 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6913 * keyboard.c (read_char):
6914 * w32menu.c (w32_menu_display_help):
6915 * xmenu.c (show_help_event, menu_help_callback):
6916 Adjust calls to `show_help_echo'.
6918 * gtkutil.c (xg_maybe_add_timer):
6919 * keyboard.c (readable_events):
6920 * process.c (wait_reading_process_output):
6921 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6923 * insdel.c (adjust_markers_gap_motion):
6924 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6925 (gap_left, gap_right): Don't call it.
6927 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6929 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6930 incurred during fontification.
6932 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6934 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6935 (DEFVAR_PER_BUFFER): Don't pass it.
6937 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6938 (scrolling_window): Don't pass it.
6940 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6942 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6944 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6946 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6947 of variables specific to SELinux and computation of `encoded_absname'.
6949 * image.c (XPutPixel): Remove unused variable `height'.
6951 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6953 * unexw32.c (get_section_info): Remove unused variable `section'.
6955 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6956 (system_process_attributes): Remove unused variable `sess'.
6957 (sys_read): Remove unused variable `err'.
6959 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6960 (w32_wnd_proc): Remove unused variable `isdead'.
6961 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6962 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6963 (x_create_tip_frame): Remove unused variable `tem'.
6965 * w32inevt.c (w32_console_read_socket):
6966 Remove unused variable `no_events'.
6968 * w32term.c (x_draw_composite_glyph_string_foreground):
6969 Remove unused variable `width'.
6971 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6973 * w32term.c (x_set_glyph_string_clipping):
6974 Don't pass uninitialized region to CombineRgn.
6976 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6978 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6979 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6980 (Fx_close_connection): Remove unused variable `i'.
6982 * w32font.c (w32font_draw): Return number of glyphs.
6983 (w32font_open_internal): Remove unused variable `i'.
6984 (w32font_driver): Add missing initializer.
6986 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6987 (fill_in_menu): Remove unused variable `items_added'.
6989 * w32term.c (last_mouse_press_frame): Remove static global variable.
6990 (w32_clip_to_row): Remove unused variable `f'.
6991 (x_delete_terminal): Remove unused variable `i'.
6993 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6994 (NOTHING): Remove unused static global variable.
6995 (uniscribe_check_otf): Remove unused variable `table'.
6996 (uniscribe_font_driver): Add missing initializers.
6998 2011-03-23 Julien Danjou <julien@danjou.info>
7000 * term.c (Fsuspend_tty, Fresume_tty):
7001 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7002 * window.c (temp_output_buffer_show):
7003 * insdel.c (signal_before_change):
7004 * frame.c (Fhandle_switch_frame):
7005 * fileio.c (Fdo_auto_save):
7006 * emacs.c (Fkill_emacs):
7007 * editfns.c (save_excursion_restore):
7008 * cmds.c (internal_self_insert):
7009 * callint.c (Fcall_interactively):
7010 * buffer.c (Fkill_all_local_variables):
7011 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7013 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
7014 unconditionnaly since it does the check itself.
7016 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
7018 Fix more problems found by GCC 4.5.2's static checks.
7020 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7021 the first time through the loop, since we know p0 < p1 then.
7022 This also avoids a gcc -Wstrict-overflow warning.
7024 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7025 leading to a memory leak, possible in functions like
7026 load_charset_map_from_file that can allocate an unbounded number
7027 of objects (Bug#8318).
7029 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7030 that could (at least in theory) be that large.
7032 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7033 This is less likely to overflow, and avoids undefined behavior if
7034 overflow does occur. All callers changed. Use strtoul to scan
7035 for the unsigned long integer.
7036 (pint2hrstr): Simplify and tune code slightly.
7037 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
7039 * scroll.c (do_scrolling): Work around GCC bug 48228.
7040 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7042 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7043 This also avoids a warning with gcc -Wstrict-overflow.
7044 (validate_x_resource_name): Simplify count usage.
7045 This also avoids a warning with gcc -Wstrict-overflow.
7047 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7050 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
7052 * process.c (Fmake_network_process): Use socklen_t, not int,
7053 where POSIX says socklen_t is required in portable programs.
7054 This fixes a porting bug on hosts like 64-bit HP-UX, where
7055 socklen_t is wider than int (Bug#8277).
7056 (Fmake_network_process, server_accept_connection):
7057 (wait_reading_process_output, read_process_output):
7060 * process.c: Rename or move locals to avoid shadowing.
7061 (list_processes_1, Fmake_network_process):
7062 (read_process_output_error_handler, exec_sentinel_error_handler):
7063 Rename or move locals.
7064 (Fmake_network_process): Define label "retry_connect" only if needed.
7065 (Fnetwork_interface_info): Fix pointer signedness.
7066 (process_send_signal): Add cast to avoid pointer signedness problem.
7067 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7068 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7070 Make tparam.h and terminfo.c consistent.
7071 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7072 Include tparam.h instead, since it declares them.
7073 * cm.h (PC): Remove extern decl; tparam.h now does this.
7074 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7075 * terminfo.c: Include tparam.h, to check interfaces.
7076 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7077 (tparam): Adjust signature to match interface in tparam.h;
7078 this removes some undefined behavior. Check that outstring and len
7079 are zero, which they always are with Emacs.
7080 * tparam.h (PC, BC, UP): New extern decls.
7082 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
7083 (xftfont_open): Rename locals to avoid shadowing.
7085 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
7086 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7087 (OTF_TAG_SYM): Omit macro if not needed.
7088 (ftfont_list): Remove unused local.
7089 (get_adstyle_property, ftfont_pattern_entity):
7090 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7091 Rename locals to avoid shadowing.
7093 * xfont.c (xfont_list_family): Mark var as initialized.
7095 * xml.c (make_dom): Now static.
7097 * composite.c (composition_compute_stop_pos): Rename local to
7099 (composition_reseat_it): Remove unused locals.
7100 (find_automatic_composition, composition_adjust_point): Likewise.
7101 (composition_update_it): Mark var as initialized.
7102 (find_automatic_composition): Mark vars as initialized,
7103 with a FIXME (Bug#8290).
7105 character.h: Rename locals to avoid shadowing.
7106 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7107 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7108 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7109 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7112 * textprop.c (property_change_between_p): Remove; unused.
7114 * intervals.c (interval_start_pos): Now static.
7116 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7118 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7119 Rename locals to avoid shadowing.
7121 * sound.c (wav_play, au_play, Fplay_sound_internal):
7122 Fix pointer signedness.
7123 (alsa_choose_format): Remove unused local var.
7124 (wav_play): Initialize a variable to 0, to prevent undefined
7125 behavior (Bug#8278).
7127 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7129 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7131 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7132 clobbering (Bug#8298).
7133 * sysdep.c (sys_subshell): Likewise.
7134 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7136 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7137 This should get cleaned up, so that child_setup has the
7138 same signature on all platforms.
7140 * callproc.c (call_process_cleanup): Now static.
7141 (relocate_fd): Rename locals to avoid shadowing.
7143 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7145 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7146 not to be necessary, and produces flickering.
7148 2011-03-20 Glenn Morris <rgm@gnu.org>
7150 * config.in: Remove file.
7152 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7154 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7155 are now in src/globals.h.
7156 (syms_of_minibuf): Remove spurious & from previous change.
7158 2011-03-20 Leo <sdl.web@gmail.com>
7160 * minibuf.c (completing-read-function): New variable.
7161 (completing-read-default): Rename from completing-read.
7162 (completing-read): Call completing-read-function.
7164 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7166 * xfaces.c (Fx_load_color_file):
7167 Read color file from absolute filename (bug#8250).
7169 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7171 * makefile.w32-in: Update dependencies.
7173 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7175 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7177 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7179 Fix more problems found by GCC 4.5.2's static checks.
7181 * process.c (make_serial_process_unwind, send_process_trap):
7182 (sigchld_handler): Now static.
7184 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7185 That way, the code declares only the vars that it needs.
7186 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7187 * s/cygwin.h (PTY_ITERATION): Likewise.
7188 * s/darwin.h (PTY_ITERATION): Likewise.
7189 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7191 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7192 * process.c (allocate_pty): Don't declare stb unless it's needed.
7194 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7195 (CONSTANTLIM): Remove; unused.
7196 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7197 Define only if needed.
7199 * unexelf.c (unexec): Name an expression,
7200 to avoid gcc -Wbad-function-cast warning.
7201 Use a different way to cause a compilation error if anyone uses
7202 n rather than nn, a way that does not involve shadowing.
7203 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7205 * deps.mk (unexalpha.o): Remove; unused.
7207 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7208 * unexec.h: New file.
7209 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7210 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7212 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7213 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7214 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7215 Change as necessary to match prototype in unexec.h.
7217 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7219 (back_comment, skip_chars): Mark vars as initialized.
7221 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7222 Rename locals to avoid shadowing.
7224 * lread.c (read1): Rewrite so as not to use empty "else".
7225 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7227 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7229 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7230 warning when compiling print.c.
7232 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7233 instead of using an uninitialized var.
7234 (font_sort_entities): Mark var as initialized.
7236 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7238 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7239 pointers to constants.
7240 (font_parse_fcname): Remove unused vars.
7241 (font_delete_unmatched): Now static.
7242 (font_get_spec): Remove; unused.
7243 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7244 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7245 Rename or move locals to avoid shadowing.
7247 * fns.c (require_nesting_list, require_unwind): Now static.
7248 (Ffillarray): Rename locals to avoid shadowing.
7250 * floatfns.c (domain_error2): Define only if needed.
7251 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7253 * alloc.c (mark_backtrace): Move decl from here ...
7254 * lisp.h: ... to here, so that it can be checked.
7256 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7257 (Fdefvar): Rewrite so as not to use empty "else".
7258 (lisp_indirect_variable): Name an expression,
7259 to avoid gcc -Wbad-function-cast warning.
7260 (Fdefvar): Rename locals to avoid shadowing.
7262 * callint.c (quotify_arg, quotify_args): Now static.
7263 (Fcall_interactively): Rename locals to avoid shadowing.
7264 Use const pointer when appropriate.
7266 * lisp.h (get_system_name, get_operating_system_release):
7267 Move decls here, to check interfaces.
7268 * process.c (get_operating_system_release): Move decl to lisp.h.
7269 * xrdb.c (get_system_name): Likewise.
7270 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7271 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7272 some of which prompt warnings from gcc -Wbad-function-cast.
7273 (Fformat_time_string, Fencode_time, Finsert_char):
7274 (Ftranslate_region_internal, Fformat):
7275 Rename or remove local vars to avoid shadowing.
7276 (Ftranslate_region_internal): Mark var as initialized.
7278 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7281 * lisp.h (eassert): Check that the argument compiles, even if
7282 ENABLE_CHECKING is not defined.
7284 * data.c (Findirect_variable): Name an expression, to avoid
7285 gcc -Wbad-function-cast warning.
7286 (default_value, arithcompare, arith_driver, arith_error): Now static.
7287 (store_symval_forwarding): Rename local to avoid shadowing.
7288 (Fmake_variable_buffer_local, Fmake_local_variable):
7289 Mark variables as initialized.
7290 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7292 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7293 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7294 Rename locals to avoid shadowing.
7295 (mark_stack): Move local variables into the #ifdef region where
7297 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7298 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7300 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7301 (GC_STRING_CHARS): Remove; not used.
7302 (Fmemory_limit): Cast sbrk's returned value to char *.
7304 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7305 avoids undefined behavior in theory.
7307 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7309 Use functions, not macros, for up- and down-casing (Bug#8254).
7310 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7311 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7312 to use the following functions instead of these macros.
7313 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7314 EMACS_INT, since callers assume the returned value fits in int.
7315 (upcase1): Likewise, for UPCASE_TABLE.
7316 (uppercasep, lowercasep, upcase): New static inline functions.
7317 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7318 the race-condition problem in the old DOWNCASE.
7320 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7321 Rename locals to avoid shadowing.
7322 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7323 (regex_compile, re_search_2, re_match_2_internal):
7324 Remove unused local vars.
7325 (FREE_VAR): Rewrite so as not to use empty "else",
7326 which gcc can warn about.
7327 (regex_compile, re_match_2_internal): Mark locals as initialized.
7328 (RETALLOC_IF): Define only if needed.
7329 (WORDCHAR_P): Likewise. This one is never needed, but is used
7330 only in a comment talking about a compiler bug, so put inside
7331 the #if 0 of that comment.
7332 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7333 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7336 * search.c (boyer_moore): Rename locals to avoid shadowing.
7337 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7338 (PREV_CHAR_BOUNDARY): Likewise.
7340 * search.c (simple_search): Remove unused var.
7342 * dired.c (compile_pattern): Move decl from here ...
7343 * lisp.h: ... to here, so that it can be checked.
7344 (struct re_registers): New forward decl.
7346 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7348 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7350 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7351 Rename locals to avoid shadowing.
7352 (Fvertical_motion): Mark locals as initialized.
7354 * casefiddle.c (casify_object, casify_region): Now static.
7355 (casify_region): Mark local as initialized.
7357 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7359 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7360 New macros, so that the caller can use some names other than
7361 gcpro1, gcpro2, etc.
7362 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7364 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7365 argument, for consistency with GCPRO2_VAR, etc: it is now the
7366 prefix of the variable, not the variable itself. All uses
7368 * dired.c (directory_files_internal, file_name_completion):
7369 Rename locals to avoid shadowing.
7371 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7372 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7373 dired.c's scmp function, had undefined behavior.
7374 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7375 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7376 * buffer.h: ... to here, because these macros use current_buffer,
7377 and the new implementation with inline functions needs to have
7378 current_buffer in scope now, rather than later when the macros
7380 (downcase, upcase1): New static inline functions.
7381 (DOWNCASE, UPCASE1): Reimplement using these functions.
7382 This avoids undefined behavior in expressions like
7383 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7384 from race conditions in accessing the global variables
7385 case_temp1 and case_temp2.
7386 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7387 * lisp.h (case_temp1, case_temp2): Remove their decls.
7388 * character.h (ASCII_CHAR_P): Move from here ...
7389 * lisp.h: ... to here, so that the inline functions mentioned
7392 * dired.c (directory_files_internal_unwind): Now static.
7394 * fileio.c (file_name_as_directory, directory_file_name):
7395 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7397 (file_name_as_directory): Use const pointers when appropriate.
7398 (Fexpand_file_name): Likewise. In particular, newdir might
7399 point at constant storage, so make it a const pointer.
7400 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7401 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7403 (Fset_file_times, Finsert_file_contents, auto_save_error):
7404 Rename locals to avoid shadowing.
7406 * minibuf.c (choose_minibuf_frame_1): Now static.
7407 (Ftry_completion, Fall_completions): Rename or remove locals
7410 * marker.c (bytepos_to_charpos): Remove; unused.
7412 * lisp.h (verify_bytepos, count_markers): New decls,
7413 so that gcc does not warn that these functions aren't declared.
7415 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7416 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7417 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7418 (copy_text): Remove unused local var.
7420 * filelock.c (within_one_second): Now static.
7421 (lock_file_1): Rename local to avoid shadowing.
7423 * buffer.c (fix_overlays_before): Mark locals as initialized.
7424 (fix_start_end_in_overlays): Likewise. This function should be
7425 simplified by using pointers-to-pointers, but that's a different
7427 (switch_to_buffer_1): Now static.
7428 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7429 (report_overlay_modification): Rename locals to avoid shadowing.
7431 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7432 Fix pointer signedness issue.
7433 (sys_subshell): Mark local as volatile if checking for lint,
7434 to suppress a gcc -Wclobbered warning that does not seem to be right.
7435 (MAXPATHLEN): Define only if needed.
7437 * process.c (serial_open, serial_configure): Move decls from here ...
7438 * systty.h: ... to here, so that they can be checked.
7440 * fns.c (get_random, seed_random): Move extern decls from here ...
7441 * lisp.h: ... to here, so that they can be checked.
7443 * sysdep.c (reset_io): Now static.
7444 (wait_for_termination_signal): Remove; unused.
7446 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7447 (copy_keymap_item, append_key, push_text_char_description):
7449 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7450 (DENSE_TABLE_SIZE): Remove; unused.
7451 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7452 (describe_map_tree):
7453 Rename locals to avoid shadowing.
7455 * keyboard.c: Declare functions static if they are not used elsewhere.
7456 (echo_char, echo_dash, cmd_error, top_level_2):
7457 (poll_for_input, handle_async_input): Now static.
7458 (read_char, kbd_buffer_get_event, make_lispy_position):
7459 (make_lispy_event, make_lispy_movement, apply_modifiers):
7460 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7461 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7462 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7463 (read_key_sequence, read_char): Mark locals as initialized.
7464 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7466 * keyboard.h (make_ctrl_char): New decl.
7467 (mark_kboards): Move decl here ...
7468 * alloc.c (mark_kboards): ... from here.
7470 * lisp.h (force_auto_save_soon): New decl.
7472 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7473 (DEFINE_DUMMY_FUNCTION): New macro.
7474 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7476 (main): Add casts to avoid warnings
7477 if GCC considers string literals to be constants.
7479 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7481 * dbusbind.c: Pointer signedness fixes.
7482 (xd_signature, xd_append_arg, xd_initialize):
7483 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7484 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7485 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7486 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7488 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7489 if GCC considers string literals to be constants.
7490 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7492 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7494 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7495 (print_preprocess, print_object): New macro to fix last change.
7497 * print.c (print_preprocess): Don't forget font objects.
7499 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7501 * emacs.c (USAGE3): Doc fixes.
7503 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7505 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7508 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7510 * lisp.h (VWindow_system, Qfile_name_history):
7511 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7512 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7513 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7515 * w32select.c: Don't #include "keyboard.h".
7516 (run_protected): Add extern declaration for waiting_for_input.
7518 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7519 * w32console.c (detect_input_pending, read_input_pending)
7520 (encode_terminal_code):
7521 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7522 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7523 (w32_system_caret_y, Qfile_name_history):
7524 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7525 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7526 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7527 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7528 * w32proc.c (Qlocal, report_file_error):
7529 * w32term.c (Vwindow_system, updating_frame):
7530 * w32uniscribe.c (initialized, uniscribe_font_driver):
7531 Remove unneeded extern declarations.
7533 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7535 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7537 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7539 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7540 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7541 These macros can no longer be used for assignment.
7543 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7544 Assign struct members directly, instead of using BUF_BEGV etc.
7545 (record_buffer_markers, fetch_buffer_markers): New functions for
7546 recording and fetching special buffer markers.
7547 (set_buffer_internal_1, set_buffer_temp): Use them.
7549 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7551 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7553 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7554 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7556 * xdisp.c (hscroll_window_tree):
7557 (reconsider_clip_changes): Use PT instead of BUF_PT.
7559 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7561 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7562 $(EMACS_ROOT)/lib/intprops.h.
7564 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7566 Fix more problems found by GCC 4.5.2's static checks.
7568 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7569 to unsigned char * to avoid compiler diagnostic.
7570 (xg_free_frame_widgets): Make it clear that a local variable is
7571 needed only if USE_GTK_TOOLTIP.
7572 (gdk_window_get_screen): Make it clear that this macro is needed
7573 only if USE_GTK_TOOLTIP.
7574 (int_gtk_range_get_value): New function, which avoids a diagnostic
7575 from gcc -Wbad-function-cast.
7576 (xg_set_toolkit_scroll_bar_thumb): Use it.
7577 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7578 diagnostic from gcc -Wbad-function-cast.
7579 (get_utf8_string, xg_get_file_with_chooser):
7580 Rename locals to avoid shadowing.
7581 (create_dialog): Move locals to avoid shadowing.
7583 * xgselect.c (xg_select): Remove unused var.
7585 * image.c (four_corners_best): Mark locals as initialized.
7586 (gif_load): Initialize transparent_p to zero (Bug#8238).
7587 Mark another local as initialized.
7588 (my_png_error, my_error_exit): Mark with NO_RETURN.
7590 * image.c (clear_image_cache): Now static.
7591 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7592 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7593 (x_edge_detection): Remove unnecessary cast that
7594 gcc -Wbad-function-cast diagnoses.
7595 (gif_load): Fix pointer signedness.
7596 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7597 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7599 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7601 Improve quality of tests for time stamp overflow.
7602 For example, without this patch (encode-time 0 0 0 1 1
7603 1152921504606846976) returns the obviously-bogus value (-948597
7604 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7605 reports time overflow. See
7606 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7607 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7608 * editfns.c: Include limits.h and intprops.h.
7609 (TIME_T_MIN, TIME_T_MAX): New macros.
7610 (time_overflow): Move earlier, to before first use.
7611 (hi_time, lo_time): New functions, for an accurate test for
7613 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7614 (Fget_internal_run_time): Don't assume time_t fits in int.
7615 (make_time): Use list2 instead of Fcons twice.
7616 (Fdecode_time): More accurate test for out-of-range times.
7617 (check_tm_member): New function.
7618 (Fencode_time): Use it, to test for out-of-range times.
7619 (lisp_time_argument): Don't rely on undefined left-shift and
7620 right-shift behavior when checking for time stamp overflow.
7622 * editfns.c (time_overflow): New function, refactoring common code.
7623 (Fformat_time_string, Fdecode_time, Fencode_time):
7624 (Fcurrent_time_string): Use it.
7626 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7627 * dired.c (make_time): Move to ...
7628 * editfns.c (make_time): ... here.
7629 * systime.h: Note the move.
7631 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7633 * fringe.c (update_window_fringes): Remove unused variables.
7635 * unexmacosx.c (copy_data_segment): Also copy __got section.
7638 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7640 * termcap.c [MSDOS]: Include "msdos.h".
7641 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7642 Constify `char *' arguments and their references according to
7643 prototypes in tparam.h.
7645 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7647 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7648 Adapt all references accordingly.
7650 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7652 2011-03-11 Tom Tromey <tromey@redhat.com>
7654 * buffer.c (syms_of_buffer): Remove obsolete comment.
7656 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7658 * termhooks.h (encode_terminal_code): Declare prototype.
7660 * msdos.c (encode_terminal_code): Don't declare prototype.
7662 * term.c (encode_terminal_code): Now external again, used by
7663 w32console.c and msdos.c.
7665 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7666 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7668 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7670 Fix some minor problems found by GCC 4.5.2's static checks.
7672 * fringe.c (update_window_fringes): Mark locals as initialized
7674 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7676 * alloc.c (mark_fringe_data): Move decl from here ...
7677 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7678 to check its interface.
7679 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7681 * fontset.c (free_realized_fontset): Now static.
7682 (Fset_fontset_font): Rename local to avoid shadowing.
7683 (fontset_font): Mark local as initialized.
7684 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7686 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7688 * xselect.c (x_disown_buffer_selections): Remove; not used.
7689 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7690 (x_own_selection, Fx_disown_selection_internal): Rename locals
7692 (x_handle_dnd_message): Remove local to avoid shadowing.
7694 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7695 so that the caller can use some name other than gcpro1.
7696 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7697 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7698 (Fx_backspace_delete_keys_p):
7699 Use them to avoid shadowing, and rename vars to avoid shadowing.
7700 (x_decode_color, x_set_name, x_window): Now static.
7701 (Fx_create_frame): Add braces to silence GCC warning.
7702 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7703 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7704 Remove unused locals.
7705 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7706 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7707 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7710 * xterm.h (x_mouse_leave): New decl.
7712 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7713 Remove unused functions.
7714 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7715 (x_calc_absolute_position): Now static.
7716 (XTread_socket): Don't define label "out" unless it's used.
7717 Don't declare local "event" unless it's used.
7718 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7719 unless they are used.
7720 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7721 (x_fatal_error_signal): Remove; not used.
7722 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7723 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7724 (x_error_catcher, x_connection_closed, x_error_handler):
7725 (x_error_quitter, xembed_send_message, x_iconify_frame):
7726 (my_log_handler): Rename locals to avoid shadowing.
7727 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7728 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7730 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7731 Rename or move locals to avoid shadowing.
7732 (tty_defined_color, merge_face_heights): Now static.
7733 (free_realized_faces_for_fontset): Remove; not used.
7734 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7735 does not deduce is never used uninitialized.
7736 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7737 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7739 * terminal.c (store_terminal_param): Now static.
7741 * xmenu.c (menu_highlight_callback): Now static.
7742 (set_frame_menubar): Remove unused local.
7743 (xmenu_show): Rename parameter to avoid shadowing.
7744 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7745 since they might point to immutable storage.
7746 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7747 since it's unused otherwise.
7749 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7750 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7751 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7752 avoids a gcc -Wuninitialized diagnostic.
7753 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7754 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7755 does not deduce are never used uninitialized.
7757 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7759 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7760 * window.c (window_loop, size_window):
7761 (run_window_configuration_change_hook, enlarge_window): Likewise.
7763 * window.c (display_buffer): Now static.
7764 (size_window): Mark variables that gcc -Wuninitialized
7765 does not deduce are never used uninitialized.
7766 * window.h (check_all_windows): New decl, to forestall
7767 gcc -Wmissing-prototypes diagnostic.
7768 * dispextern.h (bidi_dump_cached_states): Likewise.
7770 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7772 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7774 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7775 and to avoid gcc -Wuninitialized warning.
7776 (load_charset_map): Mark variables that gcc -Wuninitialized
7777 does not deduce are never used uninitialized.
7778 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7780 * coding.c (coding_set_source, coding_set_destination):
7781 Use "else { /* comment */ }" rather than "else /* comment */;"
7782 for clarity, and to avoid gcc -Wempty-body warning.
7783 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7784 a block, when the outer 'i' will do.
7785 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7786 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7787 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7788 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7789 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7790 Rename locals to avoid shadowing.
7791 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7792 * coding.c (emacs_mule_char, encode_invocation_designation):
7793 Now static, since they're not used elsewhere.
7794 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7795 (decode_coding_object, encode_coding_object, detect_coding_system):
7796 (decode_coding_emacs_mule): Mark variables that gcc
7797 -Wuninitialized does not deduce are never used uninitialized.
7798 (detect_coding_iso_2022): Initialize a local variable that might
7799 be used uninitialized. Leave a FIXME because it's not clear that
7800 this initialization is needed. (Bug#8211)
7801 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7802 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7803 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7804 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7805 Remove unused macros.
7807 * category.c (hash_get_category_set): Remove unused local var.
7808 (copy_category_table): Now static, since it's not used elsewhere.
7809 * character.c (string_count_byte8): Likewise.
7811 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7812 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7814 * chartab.c (copy_sub_char_table): Now static, since it's not used
7816 (sub_char_table_ref_and_range, char_table_ref_and_range):
7817 Rename locals to avoid shadowing.
7818 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7820 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7821 (BIDI_BOB): Remove unused macro.
7823 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7824 deduce are never used uninitialized.
7825 * term.c (encode_terminal_code): Likewise.
7827 * term.c (encode_terminal_code): Now static. Remove unused local.
7829 * tparam.h: New file.
7830 * term.c, tparam.h: Include it.
7831 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7832 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7833 Move these decls to tparam.h, and make them agree with what
7834 is actually in tparam.c. The previous trick of using incompatible
7835 decls in different modules does not conform to the C standard.
7836 All callers of tparam changed to use tparam's actual API.
7837 * tparam.c (tparam1, tparam, tgoto):
7838 Use const pointers where appropriate.
7840 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7841 * cm.h (struct cm): Likewise.
7842 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7843 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7844 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7845 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7846 (turn_on_face, init_tty): Likewise.
7847 * termchar.h (struct tty_display_info): Likewise.
7849 * term.c (term_mouse_position): Rename local to avoid shadowing.
7851 * alloc.c (mark_ttys): Move decl from here ...
7852 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7854 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7856 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7858 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7860 * search.c (compile_pattern_1): Remove argument regp, unused since
7861 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7862 (compile_pattern): Don't pass it.
7864 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7866 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7867 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7869 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7871 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7873 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7874 gdk_window_get_screen, gdk_window_get_geometry,
7875 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7876 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7877 (xg_get_pixbuf_from_pixmap): New function.
7878 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7879 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7880 Call xg_get_pixbuf_from_pixmap instead of
7881 gdk_pixbuf_get_from_drawable.
7882 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7883 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7884 (xg_check_special_colors): Use GtkStyleContext and its functions
7886 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7887 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7888 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7889 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7890 Call gtk_widget_get_preferred_size.
7891 (xg_frame_resized): gdk_window_get_geometry only takes 5
7893 (xg_win_to_widget, xg_event_is_for_menubar):
7894 Call gdk_x11_window_lookup_for_display.
7895 (xg_set_widget_bg): New function.
7896 (delete_cb): New function.
7897 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7898 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7899 (xg_set_background_color): Call xg_set_widget_bg.
7900 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7901 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7902 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7903 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7905 (update_frame_tool_bar): Call gtk_widget_hide.
7906 (xg_initialize): Use GDK_KEY_g.
7908 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7910 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7912 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7913 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7914 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7916 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7918 * w32xfns.c (select_palette): Check success of RealizePalette against
7919 GDI_ERROR, not zero.
7921 See ChangeLog.11 for earlier changes.
7927 Copyright (C) 2011 Free Software Foundation, Inc.
7929 This file is part of GNU Emacs.
7931 GNU Emacs is free software: you can redistribute it and/or modify
7932 it under the terms of the GNU General Public License as published by
7933 the Free Software Foundation, either version 3 of the License, or
7934 (at your option) any later version.
7936 GNU Emacs is distributed in the hope that it will be useful,
7937 but WITHOUT ANY WARRANTY; without even the implied warranty of
7938 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7939 GNU General Public License for more details.
7941 You should have received a copy of the GNU General Public License
7942 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.