1 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
3 * xdisp.c: Integer overflow fix.
4 (try_window_id): Check Emacs fixnum range before converting to 'int'.
6 * window.c: Integer overflow fixes.
7 (window_scroll_line_based, Frecenter):
8 Check that an Emacs fixnum is in range before assigning it to 'int'.
9 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
10 values converted from Emacs fixnums.
11 (Frecenter): Don't wrap around a line count if it is out of 'int'
12 range; instead, treat it as an extreme value.
13 (Fset_window_configuration, compare_window_configurations):
14 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
16 * search.c: Integer overflow fixes
17 (Freplace_match): Use ptrdiff_t, not int, for indexes that can
18 exceed INT_MAX. Check that EMACS_INT value is in range before
19 assigning it to the (possibly-narrower) index.
20 (match_limit): Don't assume that a fixnum can fit in 'int'.
22 * print.c: Integer overflow fix.
23 (print_object): Use ptrdiff_t, not int, for index that can
26 * indent.c: Integer overflow fixes.
27 (position_indentation): Now takes ptrdiff_t, not int.
28 (Fvertical_motion): Don't wrap around LINES values that don't fit
29 in 'int'. Instead, treat them as extreme values. This is good
30 enough for windows, which can't have more than INT_MAX lines anyway.
32 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
34 * Require libxml/parser.h to avoid compilation warning.
36 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
38 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
39 since this reportedly can destroy thread storage.
41 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
43 * syntax.c (find_defun_start): Update all cache variables if
44 exiting early (Bug#9401).
46 2011-08-30 Eli Zaretskii <eliz@gnu.org>
48 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
50 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
51 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
52 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
54 * term.c (tty_append_glyph): New function.
55 (produce_stretch_glyph): Static function and its prototype deleted.
57 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
60 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
62 * image.c (parse_image_spec): Check for nonnegative, not for positive,
63 when checking :margin (Bug#9390).
64 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
65 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
66 so that the name doesn't mislead. All uses changed.
68 2011-08-28 Johan Bockgård <bojohan@gnu.org>
70 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
73 2011-08-27 Eli Zaretskii <eliz@gnu.org>
75 * xdisp.c (move_it_to): Don't bail out early when reaching
76 position beyond to_charpos, if we are scanning backwards.
77 (move_it_vertically_backward): When DY == 0, make sure we get to
78 the first character in the line after the newline.
80 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
82 * ccl.c: Improve and simplify overflow checking (Bug#9196).
83 (ccl_driver): Do not generate an out-of-range pointer.
84 (Fccl_execute_on_string): Remove unnecessary check for
85 integer overflow, noted by Stefan Monnier in
86 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
87 Remove a FIXME that didn't need fixing.
88 Simplify the newly-introduced buffer reallocation code.
90 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
92 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
94 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
96 Integer and memory overflow issues (Bug#9196).
98 * doc.c (get_doc_string): Rework so that
99 get_doc_string_buffer_size is the actual buffer size, rather than
100 being 1 less than the actual buffer size; this makes xpalloc more
103 * image.c (x_allocate_bitmap_record, cache_image):
104 * xselect.c (Fx_register_dnd_atom):
105 Simplify previous changes by using xpalloc.
107 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
108 since either will do and ptrdiff_t is convenient with xpalloc.
110 * charset.c (charset_table_size)
111 (struct charset_sort_data.priority): Now ptrdiff_t.
112 (charset_compare): Don't overflow if priorities differ greatly.
113 (Fsort_charsets): Don't assume list length fits in int.
114 Check for size-calculation overflow when allocating sort data.
115 (syms_of_charset): Allocate an initial charset table that is
116 just under 64 KiB, to avoid problems with glibc malloc and mmap.
118 * cmds.c (internal_self_insert): Check for size-calculation overflow.
120 * composite.h (struct composition.glyph_len): Now int, not unsigned.
121 The actual value is always <= INT_MAX, and leaving it unsigned made
122 overflow checking harder.
124 * dispextern.h (struct glyph_matrix.rows_allocated)
125 (struct face_cache.size): Now ptrdiff_t, for convenience in use
126 with xpalloc. The values are still always <= INT_MAX.
128 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
130 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
131 (SAFE_NALLOCA): New macro.
133 * region-cache.c (struct boundary.pos, find_cache_boundary)
134 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
135 (set_cache_region, invalidate_region_cache)
136 (revalidate_region_cache, know_region_cache, region_cache_forward)
137 (region_cache_backward, pp_cache):
138 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
139 so that ptrdiff_t * can be passed to xpalloc.
140 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
141 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
142 (pp_cache): Don't assume cache_len fits in int.
143 * region-cache.h: Adjust extern decls to match.
145 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
146 EMACS_INT, since either will do, for xpalloc.
148 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
149 (xnmalloc, xnrealloc, xpalloc): New functions.
151 * bidi.c (bidi_shelve_header_size): New constant.
152 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
153 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
155 * bidi.c (bidi_cache_shrink):
156 * buffer.c (overlays_at, overlays_in, record_overlay_string)
158 Don't update size of array until after memory allocation succeeds,
159 because xmalloc/xrealloc may not return.
160 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
161 now that we have proper integer overflow checking.
162 (record_overlay_string, overlay_strings): Catch overflows when
163 calculating size of overlay_str_buf.
165 * callproc.c (Fcall_process): Check for size overflow when
166 calculating size of args2.
167 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
168 Normally we prefer signed values, but sticking with ptrdiff_t would
169 require adding more-complicated checks.
171 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
172 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
173 Redo buffer-overflow calculations to avoid integer overflow.
174 Add a FIXME comment where memory seems to be over-allocated.
176 * character.c (Fstring): Check for size-calculation overflow.
178 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
179 unnecessary integer overflow. Check for size overflow.
180 (encode_coding_object): Don't update size until xmalloc succeeds.
182 * composite.c (get_composition_id): Check for overflow in glyph
185 Integer and memory overflow fixes for display code.
186 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
187 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
188 (scrolling_window): Check for overflow in size calculations.
189 (line_draw_cost, realloc_glyph_pool, add_row_entry):
190 Don't assume glyph table len fits in int.
191 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
192 (row_table_size): Now ptrdiff_t, not int.
193 (scrolling_window): Avoid overflow in size calculations.
194 Don't update size until allocation succeeds.
195 * fns.c (concat): Check for overflow in size calculations.
196 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
197 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
198 (NEXT_ALMOST_PRIME_LIMIT): New constant.
200 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
201 (get_doc_string): Check for size calculation overflow.
202 Don't update size until allocation succeeds.
203 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
204 EMACS_INT, where ptrdiff_t will do.
205 (Fsubstitute_command_keys): Check for string overflow.
207 * editfns.c (set_time_zone_rule): Don't assume environment length
209 (message_length): Now ptrdiff_t, not int.
210 (Fmessage_box): Don't update size until allocation succeeds.
211 Don't assume message length fits in int.
212 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
214 * emacs.c (main): Do not reallocate argv, since there is a null at
215 the end that can be overwritten, and this way there's no need to
216 worry about size-calculation overflow.
217 (sort_args): Check for size-calculation overflow.
219 * eval.c (init_eval_once, grow_specpdl): Don't update size until
221 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
223 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
224 (x_set_scroll_bar_width, x_figure_window_size):
225 Check for integer overflow.
226 (x_set_alpha): Do not assume XINT fits in int.
228 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
229 This is for the members text_lines, text_cols, total_lines, total_cols,
230 where the system imposes an 'int' limit.
232 * fringe.c (Fdefine_fringe_bitmap):
233 Don't update size until alloc works.
235 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
236 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
238 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
239 Check for size-calculation overflow.
240 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
241 do, as we prefer signed integers.
242 (id_to_widget.max_size, id_to_widget.used)
243 (xg_store_widget_in_map, xg_remove_widget_from_map)
244 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
245 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
246 Use and return ptrdiff_t, not int.
247 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
248 * gtkutil.h: Change prototypes to match the above.
250 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
251 are duplicate now that they've been promoted to lisp.h.
252 (x_allocate_bitmap_record, x_alloc_image_color)
253 (make_image_cache, cache_image, xpm_load):
254 Don't update size until alloc is done.
255 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
257 Check for size calculation overflow.
258 (ct_colors_allocated_max): New constant.
259 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
262 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
263 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
264 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
265 Use ptrdiff_t, not int, to count maps.
266 (read_char_minibuf_menu_prompt): Check for overflow in size
267 calculations. Don't update size until allocation succeeds. Redo
268 calculations to avoid overflow.
269 * keyboard.h: Change prototypes to match the above.
271 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
273 (current_minor_maps): Check for size calculation overflow.
274 * keymap.h: Change prototypes to match the above.
276 * lread.c (read1, init_obarray): Don't update size until alloc done.
278 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
279 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
281 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
282 Now ptrdiff_t, not int.
283 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
284 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
286 * process.c (Fnetwork_interface_list): Check for overflow
289 * region-cache.c (move_cache_gap): Check for size calculation overflow.
291 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
292 overflow. Don't bother calling xmalloc when xrealloc will do.
294 * search.c (Freplace_match): Check for size calculation overflow.
295 (Fset_match_data): Don't assume list lengths fit in 'int'.
297 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
298 for command line length. Do not attempt to address one before the
299 beginning of an array, as that's not portable.
301 * term.c (max_frame_lines): Remove; unused.
302 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
304 (encode_terminal_code, calculate_costs): Check for size
305 calculation overflow.
306 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
307 table lengths and related sizes. Don't update size until alloc
308 done. Redo calculations to avoid overflow.
309 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
311 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
312 subtracting pointers.
313 (gobble_line): Check for overflow more carefully. Don't update size
316 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
317 Don't update size until alloc done.
318 Redo size calculations to avoid overflow.
319 Check for size calculation overflow.
320 (main) [DEBUG]: Fix typo in invoking tparam1.
322 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
323 Use ptrdiff_t, not int, for sizes.
324 (store_mode_line_noprop_char): Don't update size until alloc done.
326 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
327 Use ptrdiff_t, not int, for sizes.
328 (Finternal_make_lisp_face, cache_face):
329 Check for size calculation overflow.
330 (cache_face): Treat size calculation overflows as if they were
331 memory exhaustion (the usual treatment), rather than aborting.
333 * xfns.c (x_encode_text, x_set_name_internal)
334 (Fx_change_window_property): Use ptrdiff_t, not int, to count
335 sizes, since they can exceed INT_MAX in size. Check for size
336 calculation overflow.
338 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
339 (xg_select): Check for size calculation overflow.
340 Don't update size until alloc done.
342 * xrdb.c (get_environ_db): Don't assume path length fits in int,
343 as sprintf is limited to int lengths.
345 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
346 (X_LONG_MIN): New macros.
347 Use them to make the following changes clearer.
348 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
349 This change doesn't affect the value now, but it may help remind
350 future maintainers not to raise the value too much later.
351 (SELECTION_QUANTUM): Remove, replacing with ...
352 (selection_quantum): ... new function, which avoids overflow.
354 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
355 assumption that selection length fits in 'int'.
356 (x_reply_selection_request, x_handle_selection_request)
357 (x_get_window_property, receive_incremental_selection)
358 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
359 (lisp_data_to_selection_data, clean_local_selection_data):
360 Use ptrdiff_t, not int, to record length of selection.
361 (x_reply_selection_request, x_get_window_property)
362 (receive_incremental_selection, x_property_data_to_lisp):
363 Redo calculations to avoid overflow.
364 (x_reply_selection_request): When sending hint, ceiling it at
365 X_LONG_MAX rather than relying on wraparound overflow to send
367 (x_get_window_property, receive_incremental_selection)
368 (lisp_data_to_selection_data, x_property_data_to_lisp):
369 Check for size-calculation overflow.
370 (x_get_window_property, receive_incremental_selection)
371 (lisp_data_to_selection_data, Fx_register_dnd_atom):
372 Don't store size until memory allocation succeeds.
373 (x_get_window_property): Plug memory leak on memory exhaustion.
374 Don't double-block input; malloc is safe here. Don't assume 2**34
375 - 4 fits in unsigned long. Add an xassert to check
376 XGetWindowProperty overflow. Be more careful about overflow
377 calculations, and distinguish size from memory overflow better.
378 (receive_incremental_selection): When tracing, don't assume
379 unsigned int is less than INT_MAX.
380 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
381 harmful) conversions of unsigned short to int.
382 (lisp_data_to_selection_data): Don't assume that integers
383 in the range -65535 through -1 fit in an X unsigned short.
384 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
385 result parameters unless successful. Rely on cons_to_unsigned
386 to report problems with elements; the old code wasn't right anyway.
387 (x_check_property_data): Check for int overflow; we cannot use
388 a wider type due to X limits.
389 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
391 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
393 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
394 (x_term_init): Check for size calculation overflow.
395 (x_color_cells): Don't store size until memory allocation succeeds.
396 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
397 Don't assume alloca size is less than MAX_ALLOCA.
398 (x_term_init): Don't assume length fits in int (sprintf is limited
401 Use ptrdiff_t for composition IDs.
402 * character.c (lisp_string_width):
403 * composite.c (composition_table_size, n_compositions)
404 (get_composition_id, composition_gstring_from_id):
405 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
406 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
407 * window.c (Frecenter):
408 Use ptrdiff_t, not int, for composition IDs.
409 * composite.c (get_composition_id): Check for integer overflow.
410 * composite.h: Adjust prototypes to match the above changes.
412 Use ptrdiff_t for hash table indexes.
413 * category.c (hash_get_category_set):
414 * ccl.c (ccl_driver):
415 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
416 * coding.c (coding_system_charset_list, detect_coding_system):
417 * coding.h (struct coding_system.id):
418 * composite.c (get_composition_id, gstring_lookup_cache):
419 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
420 * image.c (xpm_get_color_table_h):
421 * lisp.h (hash_lookup, hash_put):
422 * minibuf.c (Ftest_completion):
423 Use ptrdiff_t for hash table indexes, not int (which is too
424 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
425 32-bit --with-wide-int hosts).
427 * charset.c (Fdefine_charset_internal): Check for integer overflow.
428 Add a FIXME comment about memory leaks.
429 (syms_of_charset): Don't assume xmalloc returns.
431 Don't assume that stated character widths fit in int.
432 * character.c (Fchar_width, c_string_width, lisp_string_width):
433 * character.h (CHAR_WIDTH):
434 * indent.c (MULTIBYTE_BYTES_WIDTH):
435 Use sanitize_char_width to avoid undefined and/or bad behavior
436 with outlandish widths.
437 * character.h (sanitize_tab_width): Renamed from sanitize_width,
438 now that we have two such functions. All uses changed.
439 (sanitize_char_width): New inline function.
441 Don't assume that tab-width fits in int.
442 * character.h (sanitize_width): New inline function.
443 (SANE_TAB_WIDTH): New macro.
444 (ASCII_CHAR_WIDTH): Use it.
445 * indent.c (sane_tab_width): Remove. All uses replaced by
446 SANE_TAB_WIDTH (current_buffer).
447 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
449 * fileio.c: Integer overflow issues with file modes.
450 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
452 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
453 Remove unreachable code.
454 (read_hex, load_charset_map_from_file): Check for integer overflow.
456 * xterm.c: don't go over XClientMessageEvent limit
457 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
458 (x_send_scroll_bar_event): Likewise. Check that the size does not
459 exceed limits imposed by XClientMessageEvent, as well as the usual
460 ptrdiff_t and size_t limits.
462 * keyboard.c: Overflow, signedness and related fixes.
463 (make_lispy_movement): Use same integer type in forward decl
464 that is used in the definition.
465 (read_key_sequence, keyremap_step):
466 Change bufsize argument back to int, undoing my 2011-03-30 change.
467 We prefer signed types, and int is wide enough here.
468 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
469 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
470 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
471 length, not size_t. Use ptrdiff_t for index, not int.
472 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
473 possibility of integer overflow.
475 Overflow, signedness and related fixes for images.
477 * dispextern.h (struct it.stack[0].u.image.image_id)
478 (struct_it.image_id, struct image.id, struct image_cache.size)
479 (struct image_cache.used, struct image_cache.ref_count):
480 * gtkutil.c (update_frame_tool_bar):
481 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
482 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
483 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
484 * nsmenu.m (update_frame_tool_bar):
485 * xdisp.c (calc_pixel_width_or_height):
486 * xfns.c (image_cache_refcount):
487 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
488 on typical 64-bit hosts.
490 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
491 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
492 Omit unnecessary casts to int.
493 (parse_image_spec): Check that integers fall into 'int' range
494 when the callers expect that.
495 (image_ascent): Redo ascent calculation to avoid int overflow.
496 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
497 (lookup_image): Remove unnecessary tests.
498 (xbm_image_p): Locals are now of int, not EMACS_INT,
499 since parse_image_check makes sure they fit into int.
500 (png_load, gif_load, svg_load_image):
501 Prefer int to unsigned where either will do.
502 (tiff_handler): New function, combining the cores of the
503 old tiff_error_handler and tiff_warning_handler. This
504 function is rewritten to use vsnprintf and thereby avoid
505 stack buffer overflows. It uses only the features of vsnprintf
506 that are common to both POSIX and native Microsoft.
507 (tiff_error_handler, tiff_warning_handler): Use it.
508 (tiff_load, gif_load, imagemagick_load_image):
509 Don't assume :index value fits in 'int'.
510 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
511 (imagemagick_load_image): Check that crop parameters fit into
512 the integer types that MagickCropImage accepts. Don't assume
513 Vimagemagick_render_type has a nonnegative value. Don't assume
514 size_t fits in 'long'.
515 (gs_load): Use printmax_t to print the widest integers possible.
516 Check for integer overflow when computing image height and width.
518 2011-08-26 Eli Zaretskii <eliz@gnu.org>
520 * xdisp.c (redisplay_window): Don't force window start if point
521 will be invisible in the resulting window. (Bug#9324)
523 2011-08-25 Eli Zaretskii <eliz@gnu.org>
525 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
526 the display spec is of the form `(space ...)'.
527 (handle_display_spec): Return the value returned by
528 handle_single_display_spec, not just 1 or zero.
529 (handle_single_display_spec): If the display spec is of the form
530 `(space ...)', and specifies display in the text area, return 2
532 (try_cursor_movement): Check for the need to scroll more
533 accurately, and prefer exact match for point under bidi. Don't
534 advance `row' beyond the last row of the window.
536 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
537 into disp_prop; all users changed.
539 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
540 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
541 for the text covered by the display property.
543 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
545 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
546 Change return value to nil.
547 (Frecord_buffer): Delete unused function.
549 2011-08-24 Eli Zaretskii <eliz@gnu.org>
551 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
552 buffers, return left-to-right.
553 (set_cursor_from_row): Consider candidate row a win if its glyph
554 represents a newline and point is on that newline. Fixes cursor
555 positioning on the newline at EOL of R2L text within L2R
556 paragraph, and vice versa.
557 (try_cursor_movement): Check continued rows, in addition to
558 continuation rows. Fixes unwarranted scroll when point enters a
559 continued line of R2L text within an L2R paragraph, or vice versa.
560 (cursor_row_p): Consider the case of point being equal to
561 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
562 from the end of a short line to the beginning of a continued line
563 of R2L text within L2R paragraph.
564 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
567 * bidi.c (bidi_check_type): Use xassert.
568 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
571 2011-08-23 Eli Zaretskii <eliz@gnu.org>
573 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
576 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
578 * nsfont.m (ns_otf_to_script): Fix typo.
580 2011-08-22 Kenichi Handa <handa@m17n.org>
582 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
583 extra slot even if the purpose is char-code-property-table.
585 2011-08-23 Eli Zaretskii <eliz@gnu.org>
587 * xdisp.c (redisplay_window): When computing centering_position,
588 account for the height of the header line. (Bug#8874)
590 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
591 instead of CHAR_TO_BYTE. Fixes a crash when a completion
592 candidate is selected by the mouse, and that candidate has a
593 composed character under the mouse.
595 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
596 coordinates reported by pos-visible-in-window-p for a composed
597 character in column zero.
599 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
601 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
603 2011-08-22 Eli Zaretskii <eliz@gnu.org>
605 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
606 consider it a hit if to_charpos is anywhere in the range of the
607 composed buffer positions.
609 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
611 * image.c (gif_load): Don't assume that each subimage has the same
612 dimensions as the base image. Handle disposal method that is
613 "undefined" by the gif spec (Bug#9335).
615 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
617 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
618 (Fcondition_case): Document `debug' symbol in error handler.
620 2011-08-19 Eli Zaretskii <eliz@gnu.org>
622 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
623 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
624 from an Org mode buffer to a Speedbar frame.
626 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
627 a composition, take its buffer position from IT->cmp_it.charpos.
628 Fixes cursor positioning at the beginning of a line that begins
629 with a composed character.
631 2011-08-18 Eli Zaretskii <eliz@gnu.org>
633 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
634 character bidirectional type, use STRONG_L instead. Fixes crashes
635 in a buffer produced by `describe-categories'.
637 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
638 members before the level stack, so they would be saved and
639 restored when copying iterator state. Fixes incorrect reordering
640 around TABs covered by display properties.
642 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
644 * process.c (Fnetwork_interface_list): Correctly determine buffer
647 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
649 * eval.c (internal_condition_case, internal_condition_case_1)
650 (internal_condition_case_2, internal_condition_case_n):
651 Remove unnecessary aborts (Bug#9081).
653 2011-08-17 Eli Zaretskii <eliz@gnu.org>
655 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
656 has no `load' handler, try opening the file locally. (Bug#9311)
658 2011-08-16 Ken Brown <kbrown@cornell.edu>
660 * gmalloc.c: Expand comment.
662 2011-08-16 Eli Zaretskii <eliz@gnu.org>
664 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
665 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
667 2011-08-16 Ken Brown <kbrown@cornell.edu>
669 Fix memory allocation problems in Cygwin build (Bug#9273).
671 * unexcw.c ( __malloc_initialized): Declare external variable.
672 (fixup_executable): Force the dumped emacs to reinitialize malloc.
674 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
676 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
678 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
680 [CYGWIN] (special_realloc): New function.
681 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
682 requests to realloc storage in the static heap.
684 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
686 * bidi.c (bidi_initialize): Remove unused local.
688 2011-08-15 Eli Zaretskii <eliz@gnu.org>
690 * biditype.h: File removed.
692 * bidimirror.h: File removed.
694 * deps.mk (bidi.o): Remove biditype.h and
697 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
700 * dispextern.h: Fix a typo in the comment to bidi_type_t.
702 * chartab.c: Improve commentary for the uniprop_table API.
704 * bidi.c (bidi_paragraph_init): Support zero value of
705 bidi_ignore_explicit_marks_for_paragraph_level.
706 (bidi_initialize): Use uniprop_table instead of including
707 biditype.h and bidimirror.h.
709 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
710 coordinates of the iterator when restoring from ppos_it.
713 2011-08-14 Kenichi Handa <handa@m17n.org>
715 * process.c (create_process): Call setup_process_coding_systems
716 after the pid of the process is set to -1 (Bug#8162).
718 2011-08-14 Eli Zaretskii <eliz@gnu.org>
720 * xdisp.c (move_it_in_display_line_to): Don't invoke
721 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
722 ppos_it. Fixes vertical cursor motion when line beginning is
723 covered by an image. (Bug#9296)
725 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
727 * nsterm.h (ns_run_ascript): Declare.
728 (NSAPP_DATA2_RUNASSCRIPT): Define.
730 * nsfns.m (as_script, as_result, as_status): New static variables.
731 (ns_run_ascript): New function.
732 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
733 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
734 the event loop. Get status from as_status (Bug#7276).
736 * nsterm.m (sendEvent): If event is NSApplicationDefined and
737 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
738 the event loop (Bug#7276).
740 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
742 * gnutls.c (QCgnutls_bootprop_priority)
743 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
744 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
745 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
746 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
747 (QCgnutls_bootprop_verify_hostname_error)
748 (QCgnutls_bootprop_callbacks_verify): Rename from
749 Qgnutls_bootprop_..., all uses changed.
751 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
754 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
756 * xfaces.c (Qframe_set_background_mode): Now static.
757 * dispextern.h (Qframe_set_background_mode): Remove decl.
759 * process.c (Fnetwork_interface_info): Declare local only if needed.
761 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
763 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
764 (Fnetwork_interface_list): Allocate in increments of bytes instead
765 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
766 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
768 (struct ifflag_def): notrailers is smart on OSX.
769 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
770 Get hardware address with getifaddrs if available.
772 2011-08-12 Eli Zaretskii <eliz@gnu.org>
774 * xdisp.c (iterate_out_of_display_property): xassert that
775 IT->position is set to within IT->object's boundaries. Break from
776 the loop as soon as EOB is reached; avoids infloops in redisplay
777 when IT->position is set up wrongly due to some bug.
778 Set IT->current to match the bidi iterator unconditionally.
779 (push_display_prop): Allow GET_FROM_STRING as IT->method on
780 entry. Force push_it to save on the stack the current
781 buffer/string position, to be restored by pop_it. Fix flags in
782 the iterator structure wrt the object coming from a display
783 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
784 properties. (Bug#9284)
786 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
788 * fontset.c (fontset_get_font_group): Add proper type checks.
791 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
793 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
794 and LC_VERSION_MIN_MACOSX.
795 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
796 (dump_it) [LC_FUNCTION_STARTS]: Use it.
798 2011-08-08 Eli Zaretskii <eliz@gnu.org>
800 * xdisp.c (forward_to_next_line_start): Allow to use the
801 no-display-properties-and-no-overlays under bidi display.
802 Set disp_pos in the bidi iterator to avoid searches for display
803 properties and overlays.
805 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
807 * editfns.c (Fset_time_zone_rule): Document relationship with the
810 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
811 the font entity extracted from the cache (Bug#8109).
813 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
815 * composite.c (autocmp_chars): Don't reset point. That is done by
816 restore_point_unwind (Bug#5984).
818 2011-08-07 Juri Linkov <juri@jurta.org>
820 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
821 to show the arg `TIME' instead of `TIMEVAL'.
823 2011-08-06 Eli Zaretskii <eliz@gnu.org>
825 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
826 display property strides EOL and includes a newline, as in
827 longlines-mode. (Bug#9254)
828 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
829 word-wrap under bidirectional display. (Bug#9224)
831 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
832 is non-zero, even if the data buffer is NULL. Fixes a crash in
833 vertical-motion with longlines-mode. (Bug#9254)
835 2011-08-05 Eli Zaretskii <eliz@gnu.org>
837 * bidi.c <bidi_cache_total_alloc>: Now static.
838 (bidi_initialize): Initialize bidi_cache_total_alloc.
840 * xdisp.c (display_line): Release buffer allocated for shelved bidi
843 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
844 amount allocated this far in `bidi_cache_total_alloc'.
845 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
846 non-zero, only free the data buffer without restoring the cache
847 contents. All callers changed.
849 * dispextern.h (bidi_unshelve_cache): Update prototype.
851 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
852 (move_it_in_display_line, move_it_to)
853 (move_it_vertically_backward, move_it_by_lines): Replace the call
854 to xfree to an equivalent call to bidi_unshelve_cache.
855 (move_it_in_display_line_to): Fix logic of returning
856 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
858 2011-08-05 Eli Zaretskii <eliz@gnu.org>
860 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
861 came from a string character with a `cursor' property. (Bug#9229)
863 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
865 * Makefile.in (LIB_PTHREAD): New variable.
866 (LIBES): Add LIB_PTHREAD (Bug#9216).
868 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
869 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
871 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
873 * regex.c (re_iswctype): Remove some redundant boolean
876 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
878 * xterm.c (x_find_topmost_parent): New function.
879 (x_set_frame_alpha): Find topmost parent window with
880 x_find_topmost_parent and set the property there also (bug#9181).
881 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
883 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
885 * callproc.c (Fcall_process): Avoid vfork clobbering
886 the local vars buffer, coding_systems, current_dir.
888 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
890 * keymap.c (Fmake_composed_keymap): Move to subr.el.
892 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
894 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
895 so that it is not optimized away.
897 * xdisp.c (compute_display_string_pos): Remove unused local.
899 2011-08-02 Eli Zaretskii <eliz@gnu.org>
901 Fix slow cursor motion and scrolling in large buffers with
902 selective display, like Org Mode buffers. (Bug#9218)
904 * dispextern.h (struct bidi_it): New member disp_prop_p.
906 * xdisp.c: Remove one-slot cache of display string positions.
907 (compute_display_string_pos): Accept an additional argument
908 DISP_PROP_P; callers changed. Scan at most 5K characters forward
909 for a display string or property. If found, set DISP_PROP_P
912 * bidi.c (bidi_fetch_char): Accept an additional argument
913 DISP_PROP_P, and pass it to compute_display_string_pos.
914 Only handle text covered by a display string if DISP_PROP_P is returned
915 non-zero. All callers of bidi_fetch_char changed.
917 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
919 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
921 2010-12-03 Don March <don@ohspite.net>
923 * keymap.c (Fdefine_key): Fix non-prefix key error message when
924 last character M-[char] is translated to ESC [char] (bug#7541).
926 2011-08-02 Kenichi Handa <handa@m17n.org>
928 * lisp.h (uniprop_table): Extern it.
930 * chartab.c (uniprop_table): Make it non-static.
932 2011-08-01 Eli Zaretskii <eliz@gnu.org>
934 * xdisp.c (forward_to_next_line_start): Accept additional argument
935 BIDI_IT_PREV, and store into it the state of the bidi iterator had
937 (reseat_at_next_visible_line_start): Use the bidi iterator state
938 returned by forward_to_next_line_start to restore the state of
939 it->bidi_it after backing up to previous newline. (Bug#9212)
941 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
943 * regex.c (re_comp): Protoize.
944 (re_exec): Fix return type.
945 (regexec): Fix type of `ret'. (Bug#9203)
947 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
949 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
950 This is needed if max-image-size is a floating-point number.
952 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
954 * print.c (print_object): Print empty symbol as ##.
956 * lread.c (read1): Read ## as empty symbol.
958 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
960 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
961 setting frame foreground color (Bug#9175).
962 (x_set_background_color): Likewise.
964 * nsmenu.m (-setText): Size tooltip dimensions precisely to
966 (EmacsTooltip -init): Remove bezels and add shadows to
969 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
970 or scroll bar (Bug#8470).
972 * nsfont.m (nsfont_open): Remove assignment to voffset and
973 unnecessary vars hshink, expand, hd, full_height, min_height.
974 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
976 * nsterm.h (nsfont_info): Remove voffset field.
978 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
980 Implement strike-through and overline on NextStep (Bug#8863).
982 * nsfont.m (nsfont_open): Use underline position provided by font,
983 instead of hard-coded value of 2.
984 (nsfont_draw): Call ns_draw_text_decoration instead.
986 * nsterm.h: Add declaration for ns_draw_text_decoration.
988 * nsterm.m (ns_draw_text_decoration): New function for drawing
989 underline, overline, and strike-through.
990 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
991 ns_draw_text_decoration. Change treatment of cursor drawing to
992 accomodate underlining, etc.
994 2011-07-28 Eli Zaretskii <eliz@gnu.org>
996 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
999 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1001 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1002 Without this fix, if a signal arrives just after memory fills up,
1003 'malloc' might be invoked reentrantly.
1005 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1006 In other words, assume that every image size is allowed, on non-X
1007 hosts. This assumption is probably wrong, but it lets Emacs compile.
1009 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1011 * regex.c (re_iswctype): Convert return values to boolean.
1013 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1015 * xdisp.c (compute_display_string_pos): Don't use cached display
1016 string position if the buffer had its restriction changed.
1019 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1021 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1023 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1025 Integer signedness and overflow and related fixes. (Bug#9079)
1027 * bidi.c: Integer size and overflow fixes.
1028 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1029 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1030 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1031 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1032 (bidi_find_other_level_edge):
1033 Use ptrdiff_t instead of EMACS_INT where either will do.
1034 This works better on 32-bit hosts configured --with-wide-int.
1035 (bidi_cache_ensure_space): Check for size-calculation overflow.
1036 Use % rather than repeated addition, for better worst-case speed.
1037 Don't set bidi_cache_size until after xrealloc returns, because it
1039 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1040 (bidi_cache_ensure_space): Also check that the bidi cache size
1041 does not exceed that of the largest Lisp string or buffer. See Eli
1042 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1044 * alloc.c (__malloc_size_t): Remove.
1045 All uses replaced by size_t. See Andreas Schwab's note
1046 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1048 * image.c: Improve checking for integer overflow.
1049 (check_image_size): Assume that f is nonnull, since
1050 it is always nonnull in practice. This is one less thing to
1051 worry about when checking for integer overflow later.
1052 (x_check_image_size): New function, which checks for integer
1053 overflow issues inside X.
1054 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1055 This removes the need for a memory_full check.
1056 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1057 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1058 (xbm_read_bitmap_data): Change locals back to 'int', since
1059 their values must fit in 'int'.
1060 (xpm_load_image, png_load, tiff_load):
1061 Invoke x_create_x_image_and_pixmap earlier,
1062 to avoid much needless work if the image is too large.
1063 (tiff_load): Treat overly large images as if
1064 x_create_x_image_and_pixmap failed, not as malloc failures.
1065 (gs_load): Use x_check_image_size.
1067 * gtkutil.c: Omit integer casts.
1068 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1069 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1071 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1073 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1074 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1075 would wrongly return t on a 64-bit host.
1077 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1078 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1079 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1080 and therefore cause GCC to emit a bogus diagnostic in some cases.
1082 * image.c: Integer signedness and overflow and related fixes.
1083 This is not an exhaustive set of fixes, but it's time to
1084 record what I've got.
1085 (lookup_pixel_color, check_image_size): Remove redundant decls.
1086 (check_image_size): Don't assume that arbitrary EMACS_INT values
1087 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1088 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1089 (tiff_load, imagemagick_load_image):
1090 Check for overflow in size calculations.
1091 (x_create_x_image_and_pixmap): Remove unnecessary test for
1092 xmalloc returning NULL; that can't happen.
1093 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1094 (xpm_color_bucket): Use better integer hashing function.
1095 (xpm_cache_color): Don't possibly over-allocate memory.
1096 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1097 (gif_memory_source):
1098 Use ptrdiff_t, not int or size_t, to record sizes.
1099 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1100 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1101 either works, as we prefer signed integers.
1102 (tiff_read_from_memory, tiff_write_from_memory):
1103 Return tsize_t, not size_t, since that's what the TIFF API wants.
1104 (tiff_read_from_memory): Don't fail simply because the read would
1105 go past EOF; instead, return a short read.
1106 (tiff_load): Omit no-longer-needed casts.
1107 (Fimagemagick_types): Don't assume size fits into 'int'.
1109 Improve hashing quality when configured --with-wide-int.
1110 * fns.c (hash_string): New function, taken from sxhash_string.
1111 Do not discard information about ASCII character case; this
1112 discarding is no longer needed.
1113 (sxhash-string): Use it. Change sig to match it. Caller changed.
1114 * lisp.h: Declare it.
1115 * lread.c (hash_string): Remove, since we now use fns.c's version.
1116 The fns.c version returns a wider integer if --with-wide-int is
1117 specified, so this should help the quality of the hashing a bit.
1119 * emacs.c: Integer overflow minor fix.
1120 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1121 Define only if GNU_LINUX.
1122 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1124 * dispnew.c: Integer signedness and overflow fixes.
1125 Remove unnecessary forward decls, that were a maintenance hassle.
1126 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1128 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1129 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1130 (prepare_desired_row, line_draw_cost):
1131 Use int, not unsigned, where either works.
1132 (save_current_matrix, restore_current_matrix):
1133 Use ptrdiff_t, not size_t, where either works.
1134 (init_display): Check for overflow more accurately, and without
1135 relying on undefined behavior.
1137 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1138 Remove, replacing with the new symbols in lisp.h. All uses changed.
1139 * fileio.c (make_temp_name):
1140 * filelock.c (lock_file_1, lock_file):
1141 * xdisp.c (message_dolog):
1142 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1143 Use pMd etc. instead.
1144 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1145 replacing the pWIDE etc. symbols removed from editfns.c.
1147 * keyboard.h (num_input_events): Now uintmax_t.
1148 This is (very slightly) less likely to mess up due to wraparound.
1151 * buffer.c: Integer signedness fixes.
1152 (alloc_buffer_text, enlarge_buffer_text):
1153 Use ptrdiff_t rather than size_t when either will do, as we prefer
1156 * alloc.c: Integer signedness and overflow fixes.
1157 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1158 (__malloc_size_t): Default to size_t, not to int.
1159 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1160 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1161 Prefer ptrdiff_t to size_t when either would do, as we prefer
1163 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1164 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1165 Now const. Initialize with values that are in range even if char
1167 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1168 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1169 These functions do the right thing with sizes > 2**32.
1170 (check_depth): Now ptrdiff_t, not int.
1171 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1172 Adjust to new way of storing sizes. Check for size overflow bugs
1174 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1175 slightly wrong anyway, as it missed one instance of
1176 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1177 (refill_memory_reserve): Omit needless cast to size_t.
1178 (mark_object_loop_halt): Mark as externally visible.
1180 * xselect.c: Integer signedness and overflow fixes.
1181 (Fx_register_dnd_atom, x_handle_dnd_message):
1182 Use ptrdiff_t, not size_t, since we prefer signed.
1183 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1184 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1185 x_dnd_atoms_size and x_dnd_atoms_length.
1187 * doprnt.c: Prefer signed to unsigned when either works.
1189 * doprnt.c (doprnt):
1191 * xdisp.c (vmessage):
1192 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1193 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1194 prefer signed arithmetic to avoid comparison confusion.
1195 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1196 but is a bit tricky.
1198 Assume freestanding C89 headers, string.h, stdlib.h.
1199 * data.c, doprnt.c, floatfns.c, print.c:
1200 Include float.h unconditionally.
1201 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1202 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1203 * regex.c: Likewise for stddef.h, string.h.
1204 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1205 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1206 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1207 (STDC_HEADERS): Remove obsolete defines.
1208 * sysdep.c: Include limits.h unconditionally.
1210 Assume support for memcmp, memcpy, memmove, memset.
1211 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1212 * regex.c (memcmp, memcpy):
1213 Remove; we assume C89 now.
1215 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1216 (__malloc_safe_bcopy): Remove; no longer needed.
1218 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1219 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1220 well either way, and we prefer signed to unsigned.
1222 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1224 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1225 closes the connection while we're reading (bug#9182).
1227 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1229 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1230 are specified (Bug#9168).
1232 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1234 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1235 Found by GCC static checking and --with-wide-int on a 32-bit host.
1237 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1239 * xdisp.c (compute_display_string_pos): Fix logic of caching
1240 previous display string position. Initialize cached_prev_pos to
1241 -1. Fixes slow-down at the beginning of a buffer.
1243 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1245 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1246 for attrs[LFACE_FONTSET_INDEX].
1248 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1250 * xml.c (parse_region): Remove unused local
1251 that was recently introduced.
1253 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1255 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1256 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1258 * xdisp.c (move_it_in_display_line_to): Record the best matching
1259 position for TO_CHARPOS while scanning the line, and restore it on
1260 exit if none of the characters scanned was an exact match.
1261 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1262 when exact match is impossible due to invisible text, and the
1263 lines are truncated.
1265 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1267 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1270 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1272 Fix a significant slow-down of cursor motion with C-n, C-p,
1273 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1274 auto-repeat under bidi redisplay in fontified buffers.
1275 * xdisp.c (compute_stop_pos_backwards): New function.
1276 (next_element_from_buffer): Call compute_stop_pos_backwards to
1277 find a suitable prev_stop when we find ourselves before
1279 (reseat): Don't look for prev_stop, as that could mean a very long
1281 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1282 <cached_disp_overlay_modiff>: Cache for last found display string
1284 (compute_display_string_pos): Return the cached position if asked
1285 about the same buffer in the same area of character positions, and
1286 the buffer wasn't changed since the time the display string
1287 position was cached.
1289 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1291 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1292 is an integer, which is important for empty lines. (Bug#9149)
1294 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1296 * frame.c (Fmodify_frame_parameters): In tty case, update the
1297 default face if necessary (Bug#4238).
1299 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1301 * editfns.c (Fstring_to_char): No need to explain what a character
1302 is in the docstring (Bug#6576).
1304 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1306 * xml.c (parse_region): Make sure we always return a tree.
1308 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1310 * xml.c (parse_region): If a document contains only comments,
1313 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1315 * xml.c (make_dom): Return comments, too.
1317 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1320 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1321 and the surrounding thread.
1322 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1323 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1324 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1326 * s/openbsd.h (BROKEN_SIGIO): Define.
1327 * unexelf.c (unexec) [__OpenBSD__]:
1328 Don't update the .mdebug section of the Alpha COFF symbol table.
1330 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1332 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1335 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1337 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1338 This fixes some race conditions on the permissions of any newly
1341 * alloc.c (valid_pointer_p): Use pipe, not open.
1342 This fixes some permissions issues when debugging.
1344 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1345 If fchown fails to set both uid and gid, try to set just gid,
1346 as that is sometimes allowed. Adjust the file's mode to eliminate
1347 setuid or setgid bits that are inappropriate if fchown fails.
1349 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1351 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1352 to compare Lisp_Objects.
1353 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1354 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1355 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1357 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1359 * lread.c (read_integer): Unread even EOF character.
1360 (read1): Likewise. Properly record start position of symbol.
1362 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1363 symbol character follows.
1365 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1367 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1368 This works around a problem with the previous change to Fcopy_file.
1369 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1370 and without this change, GCC might complain about discarding
1371 fchown's return value.
1373 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1375 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1377 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1379 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1381 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1383 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1384 it's used from the C level.
1386 * process.c: Use the same condition for POLL_FOR_INPUT in both
1387 keyboard.c and process.c (bug#1858).
1389 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1391 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1392 (Fgnutls_boot): Use it.
1394 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1396 * doc.c (Fsubstitute_command_keys): Revert last change.
1398 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1400 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1401 quotes the next character, and doesn't affect other longer
1402 sequences (bug#8935).
1404 * lread.c (syms_of_lread): Clarify that is isn't only
1405 `eval-buffer' and `eval-defun' that's affected by
1406 `lexical-binding' (bug#8460).
1408 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1410 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1411 bidi redisplay when a line includes both an image and is
1414 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1416 Fix minor problems found by static checking.
1417 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1418 (elsz): Now a signed constant, not a size_t var. We prefer signed
1419 types to unsigned, to avoid integer comparison confusion. Without
1420 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1421 "cannot optimize loop, the loop counter may overflow", a symptom
1423 * indent.c (Fvertical_motion): Mark locals as initialized.
1424 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1426 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1428 * search.c (Fre_search_backward): Mention `case-fold-search' in
1429 all the re_search_* functions (bug#8138).
1431 * keyboard.c (Fopen_dribble_file): Document when the file is
1434 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1436 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1439 Support bidi reordering of display and overlay strings.
1440 * xdisp.c (compute_display_string_pos)
1441 (compute_display_string_end): Accept additional argument STRING.
1442 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1443 (reseat_to_string): Initialize bidi_it->string.s and
1444 bidi_it->string.schars.
1445 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1446 NULL (avoids a crash in bidi_paragraph_init).
1447 Initialize itb.string.lstring.
1448 (init_iterator): Call bidi_init_it only of a valid
1449 buffer position was specified. Initialize paragraph_embedding to
1451 (reseat_to_string): Initialize the bidi iterator.
1452 (display_string): If we need to ignore text properties of
1453 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1454 original value of -1 will not work with bidi.)
1455 (compute_display_string_pos): First arg is now struct
1456 `text_pos *'; all callers changed. Support display properties on
1458 (compute_display_string_end): Support display properties on Lisp
1460 (init_iterator, reseat_1, reseat_to_string): Initialize the
1461 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1462 when iterating on a string not from display properties).
1463 (compute_display_string_pos, compute_display_string_end):
1464 Fix calculation of the object to scan. Fixes an error when using
1466 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1467 base_level_stop; instead, set base_level_stop to BEGV.
1468 Fixes crashes in vertical-motion.
1469 (next_element_from_buffer): Improve commentary for when
1470 the iterator is before prev_stop.
1471 (init_iterator): Initialize bidi_p from the default value of
1472 bidi-display-reordering, not from buffer-local value. Use the
1473 buffer-local value only if initializing for buffer iteration.
1474 (handle_invisible_prop): Support invisible properties on strings
1475 that are being bidi-reordered.
1476 (set_iterator_to_next): Support bidi reordering of C strings and
1478 (next_element_from_string): Support bidi reordering of Lisp
1480 (handle_stop_backwards): Support Lisp strings as well.
1481 (display_string): Support display of R2L glyph rows.
1482 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1483 (init_iterator): Don't initialize it->bidi_p for strings
1485 (reseat_to_string): Initialize it->bidi_p for strings here.
1486 (next_element_from_string, next_element_from_c_string)
1487 (next_element_from_buffer): Add xassert's for correspondence
1488 between IT's object being iterated and it->bidi_it.string
1490 (face_before_or_after_it_pos): Support bidi iteration.
1491 (next_element_from_c_string): Handle the case of the first string
1492 character that is not the first one in the visual order.
1493 (get_visually_first_element): New function, refactored from common
1494 parts of next_element_from_buffer, next_element_from_string, and
1495 next_element_from_c_string.
1496 (tool_bar_lines_needed, redisplay_tool_bar)
1497 (display_menu_bar): Force left-to-right direction. Add a FIXME
1498 comment for making that be controlled by a user option.
1499 (push_it, pop_it): Save and restore the state of the
1500 bidi iterator. Save and restore the bidi_p flag.
1501 (pop_it): Iterate out of display property for string iteration as
1503 (iterate_out_of_display_property): Support iteration over strings.
1504 (handle_single_display_spec): Set up it->bidi_it for iteration
1505 over a display string, and call bidi_init_it.
1506 (handle_single_display_spec, next_overlay_string)
1507 (get_overlay_strings_1, push_display_prop): Set up the bidi
1508 iterator for displaying display or overlay strings.
1509 (forward_to_next_line_start): Don't use the shortcut if
1511 (back_to_previous_visible_line_start): If handle_display_prop
1512 pushed the iterator stack, restore the internal state of the bidi
1513 iterator by calling bidi_pop_it same number of times.
1514 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1515 and we are bidi-iterating, don't decrement the iterator position;
1516 instead, set the first_elt flag in the bidi iterator, to produce
1518 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1519 (push_display_prop): xassert that we are iterating a buffer.
1520 (push_it, pop_it): Save and restore paragraph_embedding member.
1521 (handle_single_display_spec, next_overlay_string)
1522 (get_overlay_strings_1, reseat_1, reseat_to_string)
1523 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1524 correctly. Don't assume unibyte strings are not bidi-reordered.
1525 (compute_display_string_pos)
1526 (compute_display_string_end): Fix handling the case of C string.
1527 (push_it, pop_it): Save and restore from_disp_prop_p.
1528 (handle_single_display_spec, push_display_prop): Set the
1529 from_disp_prop_p flag.
1530 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1531 (pop_it): Call iterate_out_of_display_property only if we are
1532 popping after iteration over a string that came from a display
1533 property. Fix a typo in popping stretch info. Add an assertion
1534 for verifying that the iterator position is in sync with the bidi
1536 (handle_single_display_spec, get_overlay_strings_1)
1537 (push_display_prop): Fix initialization of paragraph direction for
1538 string when that of the parent object is not yet determined.
1539 (reseat_1): Call bidi_init_it to resync the bidi
1540 iterator with IT's position. (Bug#7616)
1541 (find_row_edges): If ROW->start.pos gives position
1542 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1543 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1544 Reset the from_disp_prop_p flag.
1545 (SAVE_IT, RESTORE_IT): New macros.
1546 (pos_visible_p, face_before_or_after_it_pos)
1547 (back_to_previous_visible_line_start)
1548 (move_it_in_display_line_to, move_it_in_display_line)
1549 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1550 (try_scrolling, redisplay_window, display_line): Use them when
1551 saving a temporary copy of the iterator and restoring it back.
1552 (back_to_previous_visible_line_start, reseat_1)
1553 (init_iterator): Empty the bidi cache "stack".
1554 (move_it_in_display_line_to): If iterator ended up at
1555 EOL, but we never saw any buffer positions smaller than
1556 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1557 motion in bidi-reordered lines.
1558 (move_it_in_display_line_to): Record prev_method and prev_pos
1559 immediately before the call to set_iterator_to_next. Fixes cursor
1560 motion in bidi-reordered lines with stretch glyphs and strings
1561 displayed in margins. (Bug#8133) (Bug#8867)
1562 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1564 (pos_visible_p): Support positions in bidi-reordered lines.
1565 Save and restore bidi cache.
1567 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1568 (bidi_paragraph_info): Delete unused struct.
1569 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1570 (bidi_cache_start): New variable.
1571 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1573 (bidi_cache_fetch_state, bidi_cache_search)
1574 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1575 (bidi_cache_find, bidi_peek_at_next_level)
1576 (bidi_level_of_next_char, bidi_find_other_level_edge)
1577 (bidi_move_to_visually_next): Compare cache index with
1578 bidi_cache_start rather than with zero.
1579 (bidi_fetch_char): Accept new argument STRING; all callers
1580 changed. Support iteration over a string. Support strings with
1581 display properties. Support unibyte strings. Fix the type of
1582 `len' according to what STRING_CHAR_AND_LENGTH expects.
1583 (bidi_paragraph_init, bidi_resolve_explicit_1)
1584 (bidi_resolve_explicit, bidi_resolve_weak)
1585 (bidi_level_of_next_char, bidi_move_to_visually_next):
1586 Support iteration over a string.
1587 (bidi_set_sor_type, bidi_resolve_explicit_1)
1588 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1589 can now be zero (for strings); special values 0 and -1 were
1590 changed to -1 and -2, respectively.
1591 (bidi_char_at_pos): New function.
1592 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1593 Call it instead of FETCH_MULTIBYTE_CHAR.
1594 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1595 initialized to valid values.
1596 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1598 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1599 the test for valid cached positions. Fix the logic for looking up
1600 the sentinel state in the cache. GCPRO the Lisp string we are
1602 (bidi_push_it, bidi_pop_it): New functions.
1603 (bidi_initialize): Initialize the bidi cache start stack pointer.
1604 (bidi_cache_ensure_space): New function, refactored from part of
1605 bidi_cache_iterator_state. Don't assume the required size is just
1606 one BIDI_CACHE_CHUNK away.
1607 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1608 (bidi_count_bytes, bidi_char_at_pos): New functions.
1609 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1610 always valid if bidi_cache_idx is valid.
1611 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1612 is valid if it's going to be used.
1613 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1614 (bidi_cache_fetch_state, bidi_cache_search)
1615 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1616 (bidi_cache_iterator_state, bidi_cache_find)
1617 (bidi_find_other_level_edge, bidi_cache_start_stack):
1618 All variables related to cache indices are now EMACS_INT.
1620 * dispextern.h (struct bidi_string_data): New structure.
1621 (struct bidi_it): New member `string'. Make flag members be 1-bit
1622 fields, and put them last in the struct.
1623 (compute_display_string_pos, compute_display_string_end):
1625 (bidi_push_it, bidi_pop_it): Add prototypes.
1626 (struct iterator_stack_entry): New members bidi_p,
1627 paragraph_embedding, and from_disp_prop_p.
1628 (struct it): Member bidi_p is now a bit field 1 bit wide.
1629 (bidi_shelve_cache, bidi_unshelve_cache):
1632 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1633 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1634 and vector-like objects.
1636 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1637 cache around display iteration.
1639 * window.c (Fwindow_end, window_scroll_pixel_based)
1640 (displayed_window_lines, Frecenter): Save and restore the bidi
1641 cache around display iteration.
1643 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1645 * editfns.c (Fdelete_region): Clarify the use of the named
1646 parameters (bug#6788).
1648 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1650 * indent.c (Fvertical_motion): Set and restore w->pointm when
1651 saving and restoring the window's buffer (Bug#9006).
1653 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1655 * editfns.c (Fstring_to_char): Clarify just what is returned
1656 (bug#6576). Text by Eli Zaretskii.
1658 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1660 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1662 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1664 * buffer.c (mmap_find): Fix a typo.
1666 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1668 Fix execution of x selection hooks.
1669 * xselect.c (Qx_lost_selection_functions)
1670 (Qx_sent_selection_functions): New vars.
1671 (syms_of_xselect): DEFSYM them.
1672 (x_handle_selection_request): Pass Qx_sent_selection_functions
1673 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1674 (x_handle_selection_clear,x_clear_frame_selections):
1675 Pass Qx_lost_selection_functions rather than
1676 Vx_lost_selection_functions to Frun_hook_with_args.
1678 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1680 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1681 The old code sometimes used this field without initializing it.
1683 * alloc.c (gc_sweep): Don't read past end of array.
1684 In theory, the old code could also have corrupted Emacs internals,
1685 though it'd be very unlikely.
1687 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1689 * character.c (Fcharacterp): Don't advertise optional ignored
1690 argument. (Bug#4026)
1692 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1694 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1697 * window.c (Fset_window_start): Doc fix (bug#4199).
1698 (Fset_window_hscroll): Ditto.
1700 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1702 Fix minor new problems caught by GCC 4.6.1.
1703 * term.c (init_tty): Remove unused local.
1704 * xsettings.c (store_monospaced_changed): Define this function only
1705 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1708 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1710 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1712 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1714 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1715 are the mini-buffer and the echo area (bug#3320).
1717 * term.c (init_tty): Remove support for supdup, c10 and perq
1718 terminals, which are no longer supported (bug#1482).
1720 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1722 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1724 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1726 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1727 for non-popups (Bug#3642).
1729 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1731 * alloc.c (reset_malloc_hooks): Protoize.
1732 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1733 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1734 * cm.c (losecursor): Likewise.
1735 * data.c (fmod): Likewise.
1736 * dispnew.c (swap_glyphs_in_rows): Likewise.
1737 * emacs.c (memory_warning_signal): Likewise.
1738 * floatfns.c (float_error): Likewise.
1739 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1740 (otf_open, font_otf_capability, generate_otf_features)
1741 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1743 * image.c (pbm_read_file): Likewise.
1744 * indent.c (string_display_width): Likewise.
1745 * intervals.c (check_for_interval, search_for_interval)
1746 (inc_interval_count, count_intervals, root_interval)
1747 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1748 * lread.c (defalias): Likewise.
1749 * ralloc.c (r_alloc_check): Likewise.
1750 * regex.c (set_image_of_range_1, set_image_of_range)
1751 (regex_grow_registers): Likewise.
1752 * sysdep.c (strerror): Likewise.
1753 * termcap.c (valid_filename_p, tprint, main): Likewise.
1754 * tparam.c (main): Likewise.
1755 * unexhp9k800.c (run_time_remap, save_data_space)
1756 (update_file_ptrs, read_header, write_header, calculate_checksum)
1757 (copy_file, copy_rest, display_header): Likewise.
1758 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1760 * xdisp.c (check_it): Likewise.
1761 * xfaces.c (register_color, unregister_color, unregister_colors):
1763 * xfns.c (print_fontset_result): Likewise.
1764 * xrdb.c (member, fatal, main): Likewise.
1766 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1768 Fix minor problems found by static checking (Bug#9031).
1769 * chartab.c (char_table_set_range, map_sub_char_table):
1770 Remove unused locals.
1771 (uniprop_table): Now static.
1772 * composite.c (_work_char): Remove unused static var.
1774 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1776 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1778 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1780 * gtkutil.c (qttip_cb): Remove code without function.
1782 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1784 * w32.c (pthread_sigmask): New stub.
1786 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1788 Use pthread_sigmask, not sigprocmask (Bug#9010).
1789 sigprocmask is portable only for single-threaded applications, and
1790 Emacs can be multi-threaded when it uses GTK.
1791 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1793 * callproc.c (Fcall_process):
1794 * process.c (create_process):
1795 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1796 Use pthread_sigmask, not sigprocmask.
1798 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1800 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1801 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1804 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1806 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1807 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1808 (xg_hide_tooltip): Fix comment.
1810 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1811 in registerServicesMenuSendTypes.
1812 (validRequestorForSendType): Don't check ns_return_types.
1814 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1817 2011-07-08 Jason Rumney <jasonr@gnu.org>
1819 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1820 frame struct members of non-existent frames (Bug#6284).
1822 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1824 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1825 variable firstTime not needed on OSX >= 10.6.
1826 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1827 >= 10.5. Use setKnobProportion, setDoubleValue.
1829 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1830 (MAC_OS_X_VERSION_10_5): Define if not defined.
1831 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1832 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1833 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1835 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1836 cString and lossyCString on OSX >= 10.4
1838 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1839 sizeToFit on OSX >= 10.2.
1841 * nsimage.m (allocInitFromFile): Don't use deprecated method
1842 bestRepresentationForDevice on OSX >= 10.6.
1844 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1847 * emacs.c: Declare unexec_init_emacs_zone.
1849 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1851 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1853 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1854 on svcsMenu (Bug#8842).
1856 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1858 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1860 * nsterm.m (QUTF8_STRING): Declare.
1861 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1862 (validRequestorForSendType): Return type is (id).
1863 Change indexOfObjectIdenticalTo to indexOfObject.
1864 Check if we have local selection before returning self (Bug#8842).
1865 (writeSelectionToPasteboard): Put local selection into paste board
1866 if we have a local selection (Bug#8842).
1867 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1869 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1870 (ns_get_local_selection): Declare.
1872 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1874 * keymap.c (describe_map_tree): Don't insert a double newline at
1875 the end of the buffer (bug#1169) and return whether we inserted
1878 * callint.c (Fcall_interactively): Change "reading args" to
1879 "providing args" to try to clarify what it does (bug#1010).
1881 2011-07-07 Kenichi Handa <handa@m17n.org>
1883 * composite.c (composition_compute_stop_pos): Ignore a static
1884 composition starting before CHARPOS (Bug#8915).
1886 * xdisp.c (handle_composition_prop): Likewise.
1888 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1890 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1893 2011-07-07 Kenichi Handa <handa@m17n.org>
1895 * character.h (unicode_category_t): New enum type.
1897 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1898 (Qchar_code_property_table): New variable.
1899 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1900 (UNIPROP_COMPRESSED_FORM_P): New macros.
1901 (char_table_ascii): Uncompress the compressed values.
1902 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1903 Uncompress the compressed values.
1904 (sub_char_table_ref_and_range): Likewise.
1905 (char_table_ref_and_range): Uncompress the compressed values.
1906 (sub_char_table_set): New arg is_uniprop. Callers changed.
1907 Uncompress the compressed values.
1908 (sub_char_table_set_range): Args changed. Callers changed.
1909 (char_table_set_range): Adjuted for the above change.
1910 (map_sub_char_table): Delete args default_val and parent. Add arg
1911 top. Give decoded values to a Lisp function.
1912 (map_char_table): Adjust for the above change. Give decoded
1913 values to a Lisp function. Gcpro more variables.
1914 (uniprop_table_uncompress)
1915 (uniprop_decode_value_run_length): New functions.
1916 (uniprop_decoder, uniprop_decoder_count): New variables.
1917 (uniprop_get_decoder, uniprop_encode_value_character)
1918 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1920 (uniprop_encoder, uniprop_encoder_count): New variables.
1921 (uniprop_get_encoder, uniprop_table)
1922 (Funicode_property_table_internal, Fget_unicode_property_internal)
1923 (Fput_unicode_property_internal): New functions.
1924 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1925 Sunicode_property_table_internal, Sget_unicode_property_internal,
1926 and Sput_unicode_property_internal. Defvar_lisp
1927 char-code-property-alist.
1929 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
1930 Vunicode_category_table.
1932 * font.c (font_range): Adjust for the change of
1933 Vunicode_category_table.
1935 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1937 * m/iris4d.h: Remove file, move contents ...
1938 * s/irix6-5.h: ... here.
1940 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1942 Remove unportable assumption about struct layout (Bug#8884).
1943 * alloc.c (mark_buffer):
1944 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1945 (clone_per_buffer_values): Don't assume that
1946 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1947 This isn't true in general, and it's particularly not true
1948 if Emacs is configured with --with-wide-int.
1949 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1950 New macros, used in the buffer.c change.
1952 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1954 * xsettings.c: Use both GConf and GSettings if both are available.
1955 (store_config_changed_event): Add comment.
1956 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1957 (store_tool_bar_style_changed): New functions.
1958 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1959 (struct xsettings): Move font inside HAVE_XFT.
1960 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1961 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
1962 Move inside HAVE_XFT.
1963 (something_changed_gsettingsCB): Rename from something_changedCB.
1964 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1966 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1967 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1968 (something_changed_gconfCB): Rename from something_changedCB.
1969 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1970 (parse_settings): Move check for font inside HAVE_XFT.
1971 (read_settings, apply_xft_settings): Add comment.
1972 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1973 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1974 call store_font_name_changed.
1975 (xft_settings_event): Add comment.
1976 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1977 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1978 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1979 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1980 (xsettings_initialize): Call init_gsettings last.
1981 (xsettings_get_system_font, xsettings_get_system_normal_font):
1984 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1986 Random fixes. E.g., (random) never returned negative values.
1987 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1988 subseconds part to the entropy, as that's a bit more random.
1989 Prefer signed to unsigned, since the signedness doesn't matter and
1990 in general we prefer signed. When given a limit, use a
1991 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1992 latter isn't right if USE_2_TAGS_FOR_INTS.
1993 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1994 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1996 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1998 * textprop.c (text_property_stickiness):
1999 Obey Vtext_property_default_nonsticky.
2000 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2001 * w32fns.c (syms_of_w32fns):
2002 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2004 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2006 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2007 This is more efficient than Ffile_directory_p and avoids a minor race.
2009 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2011 * buffer.c (Foverlay_put): Say what the return value is
2014 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2015 is a directory before asking whether to use the file name
2017 (barf_or_query_if_file_exists): Make the "File is a directory"
2018 error be more correct.
2020 * fns.c (Frequire): Remove the mention of the .gz files, since
2021 that's installation-specific, but keep the mention of
2022 `get-load-suffixes'.
2024 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2026 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2027 Report string overflow if the output is too long.
2029 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2031 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2032 (syms_of_gnutls): Remove duplicate DEFSYM for
2033 Qgnutls_bootprop_verify_hostname_error, an error for
2034 Qgnutls_bootprop_verify_error (which is no longer used).
2036 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2037 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2038 Also (re)move comments that are misplaced or no longer relevant.
2040 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2042 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2044 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2046 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2047 and background color parameters if they have been changed.
2049 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2051 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2053 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2055 * xsettings.c (SYSTEM_FONT): Define only when used.
2056 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2058 * keymap.c (access_keymap_1): Now static.
2060 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2062 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2063 leave any prefix arg for the up event (Bug#1586).
2065 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2067 * lread.c (syms_of_lread): Mention single symbols defined by
2068 `defvar' or `defconst' (bug#7154).
2070 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2071 (Frequire): Mention get-load-suffixes.
2073 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2075 * window.h (window): Remove clone_number slot.
2076 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2078 (make_parent_window, make_window, saved_window)
2079 (Fset_window_configuration, save_window_save): Don't deal with
2081 * buffer.c (Qclone_number): Remove declaration.
2082 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2084 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2086 Add multiple inheritance to keymaps.
2087 * keymap.c (Fmake_composed_keymap): New function.
2088 (Fset_keymap_parent): Simplify.
2089 (fix_submap_inheritance): Remove.
2090 (access_keymap_1): New function extracted from access_keymap to handle
2091 embedded parents and handle lists of maps.
2092 (access_keymap): Use it.
2093 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2094 (Fcopy_keymap): Handle embedded parents.
2095 (Fcommand_remapping, define_as_prefix): Simplify.
2096 (Fkey_binding): Simplify.
2097 (syms_of_keymap): Move minibuffer-local-completion-map,
2098 minibuffer-local-filename-completion-map,
2099 minibuffer-local-must-match-map, and
2100 minibuffer-local-filename-must-match-map to Elisp.
2101 (syms_of_keymap): Defsubr make-composed-keymap.
2102 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2103 (parse_menu_item): Trivial simplification.
2105 2011-07-01 Glenn Morris <rgm@gnu.org>
2107 * Makefile.in (SETTINGS_LIBS): Fix typo.
2109 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2111 * coding.c (Fencode_coding_string): Record the last coding system
2112 used, as the function doc string says (bug#8738).
2114 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2116 * xsettings.c (store_monospaced_changed): Take new font as arg and
2117 check for change against current_mono_font.
2118 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2119 (emacs_settings_constructor, emacs_settings_get_property)
2120 (emacs_settings_set_property, emacs_settings_class_init)
2121 (emacs_settings_init, gsettings_obj): Remove.
2122 (something_changedCB): New function for HAVE_GSETTINGS.
2123 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2124 with value as argument.
2125 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2126 g_settings_new (Bug#8967). Do not create gsettings_obj.
2127 Remove calls to g_settings_bind. Connect something_changedCB to
2130 * xgselect.c: Add defined (HAVE_GSETTINGS).
2131 (xgselect_initialize): Ditto.
2133 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2134 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2137 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2139 * eval.c (struct backtrace): Simplify and port the data structure.
2140 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2141 signed bit field, as this assumption is not portable and it makes
2142 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2143 "char debug_on_exit : 1" as this is not portable either; instead,
2144 use the portable "unsigned int debug_on_exit : 1". Remove unused
2145 member evalargs. Remove obsolete comments about cc bombing out.
2147 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2149 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2150 Let HAVE_GSETTINGS override HAVE_GCONF.
2151 (store_monospaced_changed): New function.
2152 (EMACS_SETTINGS): A new type derived from GObject to handle
2153 GSettings notifications.
2154 (emacs_settings_constructor, emacs_settings_get_property)
2155 (emacs_settings_set_property, emacs_settings_class_init):
2157 (gsettings_client, gsettings_obj): New variables.
2158 (GSETTINGS_SCHEMA): New define.
2159 (something_changedCB): Call store_monospaced_changed.
2160 (init_gsettings): New function.
2161 (xsettings_initialize): Call init_gsettings.
2162 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2165 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2168 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2170 * window.c (resize_root_window, grow_mini_window)
2171 (shrink_mini_window): Rename Qresize_root_window to
2172 Qwindow_resize_root_window and Qresize_root_window_vertically to
2173 Qwindow_resize_root_window_vertically.
2175 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2177 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2179 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2181 * makefile.w32-in: Redesign dependencies so they reflect more
2182 clearly which files are directly included by each source file,
2183 and not through other includes.
2185 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2187 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2188 (sort_overlays, overlay_strings): When an overlay's clone number
2189 matches the window's clone number process the overlay even if
2190 the overlay's window property doesn't match the current window.
2192 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2193 (Fwindow_hchild): Rename to Fwindow_left_child.
2194 (Fwindow_next): Rename to Fwindow_next_sibling.
2195 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2196 (resize_window_check): Rename to window_resize_check.
2197 (resize_window_apply): Rename to window_resize_apply.
2198 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2199 (Fdelete_other_windows_internal, resize_frame_windows)
2200 (Fsplit_window_internal, Fdelete_window_internal)
2201 (grow_mini_window, shrink_mini_window)
2202 (Fresize_mini_window_internal): Fix callers accordingly.
2204 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2206 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2207 (emacs_fixed_set_min_size): Remove.
2208 (emacs_fixed_new): Take frame as argument.
2210 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2211 (_EmacsFixedPrivate): Remove minwidth/height.
2212 Add struct frame *f.
2213 (emacs_fixed_init): Initialize priv->f.
2214 (get_parent_class, emacs_fixed_set_min_size): Remove.
2215 (emacs_fixed_new): Set priv->f to argument.
2216 (emacs_fixed_get_preferred_width)
2217 (emacs_fixed_get_preferred_height): Use min_width/height from
2218 frames size_hint to set minimum and natural (Bug#8919).
2219 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2220 and use min_width/height from frames size_hint to set
2221 min_width/height (Bug#8919).
2223 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2224 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2227 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2229 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2230 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2233 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2235 * process.c (wait_reading_process_output): Bypass select if
2236 waiting for a cell while ignoring keyboard input, and input is
2237 pending. Suggested by Jan Djärv (Bug#8869).
2239 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2241 Use gnulib's dup2 module instead of rolling our own.
2242 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2244 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2246 * dispnew.c (scrolling_window): Before scrolling, turn off a
2247 mouse-highlight in the window being scrolled.
2249 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2251 Move DEFSYM to lisp.h and use everywhere.
2253 * character.h (DEFSYM): Move declaration...
2254 * lisp.h (DEFSYM): ...here.
2260 * w32select.c: Don't include character.h.
2262 * alloc.c (syms_of_alloc):
2263 * buffer.c (syms_of_buffer):
2264 * bytecode.c (syms_of_bytecode):
2265 * callint.c (syms_of_callint):
2266 * casefiddle.c (syms_of_casefiddle):
2267 * casetab.c (init_casetab_once):
2268 * category.c (init_category_once, syms_of_category):
2269 * ccl.c (syms_of_ccl):
2270 * cmds.c (syms_of_cmds):
2271 * composite.c (syms_of_composite):
2272 * dbusbind.c (syms_of_dbusbind):
2273 * dired.c (syms_of_dired):
2274 * dispnew.c (syms_of_display):
2275 * doc.c (syms_of_doc):
2276 * editfns.c (syms_of_editfns):
2277 * emacs.c (syms_of_emacs):
2278 * eval.c (syms_of_eval):
2279 * fileio.c (syms_of_fileio):
2280 * fns.c (syms_of_fns):
2281 * frame.c (syms_of_frame):
2282 * fringe.c (syms_of_fringe):
2283 * insdel.c (syms_of_insdel):
2284 * keymap.c (syms_of_keymap):
2285 * lread.c (init_obarray, syms_of_lread):
2286 * macros.c (syms_of_macros):
2287 * msdos.c (syms_of_msdos):
2288 * print.c (syms_of_print):
2289 * process.c (syms_of_process):
2290 * search.c (syms_of_search):
2291 * sound.c (syms_of_sound):
2292 * syntax.c (init_syntax_once, syms_of_syntax):
2293 * terminal.c (syms_of_terminal):
2294 * textprop.c (syms_of_textprop):
2295 * undo.c (syms_of_undo):
2296 * w32.c (globals_of_w32):
2297 * window.c (syms_of_window):
2298 * xdisp.c (syms_of_xdisp):
2299 * xfaces.c (syms_of_xfaces):
2300 * xfns.c (syms_of_xfns):
2301 * xmenu.c (syms_of_xmenu):
2302 * xsettings.c (syms_of_xsettings):
2303 * xterm.c (syms_of_xterm): Use DEFSYM.
2305 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2307 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2309 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2311 Integer and buffer overflow fixes (Bug#8873).
2313 * print.c (printchar, strout): Check for string overflow.
2314 (PRINTPREPARE, printchar, strout):
2315 Don't set size unless allocation succeeds.
2317 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2318 for sizes. Check for string overflow more accurately.
2319 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2321 * macros.c: Integer and buffer overflow fixes.
2322 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2323 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2324 Use ptrdiff_t, not int, for sizes.
2325 Don't increment bufsize until after realloc succeeds.
2326 Check for size-calculation overflow.
2327 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2329 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2331 * lread.c: Integer overflow fixes.
2332 (read_integer): Radix is now EMACS_INT, not int,
2333 to improve quality of diagnostics for out-of-range radices.
2334 Calculate buffer size correctly for out-of-range radices.
2335 (read1): Check for integer overflow in radices, and in
2336 read-circle numbers.
2337 (read_escape): Avoid int overflow.
2338 (Fload, openp, read_buffer_size, read1)
2339 (substitute_object_recurse, read_vector, read_list, map_obarray):
2340 Use ptrdiff_t, not int, for sizes.
2341 (read1): Use EMACS_INT, not int, for sizes.
2342 Check for size overflow.
2344 * image.c (cache_image): Check for size arithmetic overflow.
2346 * lread.c: Integer overflow issues.
2347 (saved_doc_string_size, saved_doc_string_length)
2348 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2349 Now ptrdiff_t, not int.
2350 (read1): Don't assume doc string length fits in int. Check for
2351 out-of-range doc string lengths.
2352 (read_list): Don't assume file position fits in int.
2353 (read_escape): Check for hex character overflow.
2355 2011-06-22 Leo Liu <sdl.web@gmail.com>
2357 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2358 Move to minibuffer.el.
2360 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2362 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2363 The following patches are for when GLYPH_DEBUG && !XASSERT.
2364 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2365 * dispnew.c (flush_stdout):
2366 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2367 Mark as externally visible.
2368 * dispnew.c (check_window_matrix_pointers): Now static.
2369 * dispnew.c (window_to_frame_vpos):
2370 * xfns.c (unwind_create_frame):
2371 * xterm.c (x_check_font): Remove unused local.
2372 * scroll.c (CHECK_BOUNDS):
2373 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2374 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2375 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2376 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2377 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2379 (debug_method_add): Use va_list and vsprintf rather than relying
2380 on undefined behavior with wrong number of arguments.
2381 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2382 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2383 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2384 since we're not interested in debugging glyphs with old libraries.
2385 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2386 GCC 4.6.0's static checking.
2388 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2390 Integer overflow and signedness fixes (Bug#8873).
2391 A few related buffer overrun fixes, too.
2393 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2395 * dispextern.h (struct face.stipple):
2396 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2397 (x_bitmap_mask, x_allocate_bitmap_record)
2398 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2399 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2400 (x_create_bitmap_from_xpm_data):
2401 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2402 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2404 * xfaces.c (load_pixmap):
2405 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2406 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2407 (.bitmaps_last, struct x_output.icon_bitmap):
2408 Use ptrdiff_t, not int, for bitmap indexes.
2409 (x_allocate_bitmap_record): Check for size overflow.
2410 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2412 Use ptrdiff_t, not int, for overlay counts.
2413 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2414 * editfns.c (overlays_around, get_pos_property):
2415 * textprop.c (get_char_property_and_overlay):
2416 * xdisp.c (next_overlay_change, note_mouse_highlight):
2417 * xfaces.c (face_at_buffer_position):
2418 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2419 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2420 (Fnext_overlay_change, Fprevious_overlay_change)
2421 (mouse_face_overlay_overlaps, Foverlays_in):
2422 Use ptrdiff_t, not int, for sizes.
2423 (overlays_at, overlays_in): Check for size-calculation overflow.
2425 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2427 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2428 (x_session_initialize): Do not assume string length fits in int.
2430 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2431 This is unlikely, but can occur if DPI is outlandish.
2433 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2434 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2436 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2437 * xrdb.c (magic_file_p, search_magic_path):
2438 Omit last arg SUFFIX; it was always 0. All callers changed.
2439 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2441 * xfont.c (xfont_match): Avoid need for strlen.
2443 * xfns.c: Don't assume strlen fits in int.
2444 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2446 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2447 not unsigned long, as we prefer signed integers. All callers changed.
2448 Detect integer overflow in repeat count.
2449 (message_dolog): Don't assume print length fits in 39 bytes.
2450 (display_mode_element): Don't assume strlen fits in int.
2452 * termcap.c: Don't assume sizes fit in int and never overflow.
2453 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2454 (gobble_line): Check for size-calculation overflow.
2456 * minibuf.c (Fread_buffer):
2457 * lread.c (intern, intern_c_string):
2458 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2459 Don't assume string length fits in int.
2461 * keyboard.c (parse_tool_bar_item):
2462 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2464 * font.c: Don't assume string length fits in int.
2465 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2466 Use ptrdiff_t, not int.
2467 (font_intern_prop): Don't assume string length fits in int.
2468 Don't assume integer property fits in fixnum.
2469 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2471 * filelock.c: Fix some buffer overrun and integer overflow issues.
2472 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2473 Reformulate so as not to need the command string.
2474 Invoke gzip -cd rather than gunzip, as it's more portable.
2475 (lock_info_type, lock_file_1, lock_file):
2476 Don't assume pid_t and time_t fit in unsigned long.
2477 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2478 (current_lock_owner): Prefer signed type for sizes.
2479 Use memcpy, not strncpy, where memcpy is what is really wanted.
2480 Don't assume (via atoi) that time_t and pid_t fit in int.
2481 Check for time_t and/or pid_t out of range, e.g., via a network share.
2482 Don't alloca where an auto var works fine.
2484 * fileio.c: Fix some integer overflow issues.
2485 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2486 Don't assume string length fits in int.
2487 (directory_file_name): Don't assume string length fits in long.
2488 (make_temp_name): Don't assume pid fits in int, or that its print
2489 length is less than 20.
2491 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2493 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2495 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2497 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2498 We prefer signed integers, even for size calculations.
2500 * emacs.c: Don't assume string length fits in 'int'.
2501 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2502 (main): Don't invoke strlen when not needed.
2504 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2505 (XD_DEBUG_MESSAGE): Don't waste a byte.
2507 * callproc.c (getenv_internal_1, getenv_internal)
2509 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2511 * lread.c (invalid_syntax): Omit length argument.
2512 All uses changed. This doesn't fix a bug, but it simplifies the
2513 code away from its former Hollerith-constant appearance, and it's
2514 one less 'int' to worry about when looking at integer-overflow issues.
2515 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2517 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2518 This didn't break anything, but it didn't help either.
2519 It's confusing to put a bogus integer in a place where the actual
2520 value does not matter.
2521 (LIST_END_P): Remove unused macro and its bogus comment.
2522 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2524 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2525 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2527 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2528 We prefer signed types, and the value cannot exceed the EMACS_INT
2529 range anyway (because otherwise the length would not be representable).
2530 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2531 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2532 This avoids a GCC warning when WIDE_EMACS_INT.
2534 * indent.c (sane_tab_width): New function.
2535 (current_column, scan_for_column, Findent_to, position_indentation)
2536 (compute_motion): Use it. This is just for clarity.
2537 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2539 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2541 * lisp.h (lint_assume): New macro.
2542 * composite.c (composition_gstring_put_cache):
2543 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2545 * editfns.c, insdel.c:
2546 Omit unnecessary forward decls, to simplify future changes.
2548 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2550 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2552 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2553 Use much-faster test for byte-length change.
2554 Don't assume string byte-length fits in 'int'.
2555 Check that character arg fits in 'int'.
2556 (mapcar1): Declare byte as byte, for clarity.
2558 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2560 * fns.c (concat): Catch string overflow earlier.
2561 Do not rely on integer wraparound.
2563 * dispextern.h (struct it.overlay_strings_charpos)
2564 (struct it.selective): Now EMACS_INT, not int.
2565 * xdisp.c (forward_to_next_line_start)
2566 (back_to_previous_visible_line_start)
2567 (reseat_at_next_visible_line_start, next_element_from_buffer):
2568 Don't arbitrarily truncate the value of 'selective' to int.
2570 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2572 * composite.c: Don't truncate sizes to 'int'.
2573 (composition_gstring_p, composition_reseat_it)
2574 (composition_adjust_point): Use EMACS_INT, not int.
2575 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2576 not EMACS_UINT, for indexes.
2578 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2580 * buffer.c: Include <verify.h>.
2581 (struct sortvec.priority, struct sortstr.priority):
2582 Now EMACS_INT, not int.
2583 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2584 (struct sortstr.size, record_overlay_string)
2585 (struct sortstrlist.size, struct sortlist.used):
2586 Don't truncate size to int.
2587 (record_overlay_string): Check for size-calculation overflow.
2588 (init_buffer_once): Check at compile-time, not run-time.
2590 2011-06-22 Jim Meyering <meyering@redhat.com>
2592 Don't leak an XBM-image-sized buffer
2593 * image.c (xbm_load): Free the image buffer after using it.
2595 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2598 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2599 that Sun C diagnosed.
2600 * fns.c (secure_hash): Fix pointer signedness issue.
2601 * intervals.c (static_offset_intervals): New function.
2602 (offset_intervals): Use it.
2604 2011-06-21 Leo Liu <sdl.web@gmail.com>
2607 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2610 * fns.c (secure_hash): Rename from crypto_hash_function and change
2611 the first arg to accept symbols.
2612 (Fsecure_hash): New primitive.
2613 (syms_of_fns): New symbols.
2615 2011-06-20 Deniz Dogan <deniz@dogan.se>
2617 * process.c (Fset_process_buffer): Clarify return value in
2620 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2622 * dispnew.c (add_window_display_history): Use BVAR.
2624 * xdisp.c (debug_method_add): Use BVAR.
2625 (check_window_end, dump_glyph_matrix, dump_glyph)
2626 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2628 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2631 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2632 check till after the cache is created in init_frame_faces.
2634 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2636 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2638 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2640 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2641 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2642 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2644 Improve buffer-overflow checking (Bug#8873).
2645 * fileio.c (Finsert_file_contents):
2646 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2647 Remove the old (too-loose) buffer overflow checks.
2648 They weren't needed, since make_gap checks for buffer overflow.
2649 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2650 The old code merely checked for Emacs fixnum overflow, and relied
2651 on undefined (wraparound) behavior. The new code avoids undefined
2652 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2654 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2655 Tune. Don't use wider integers than needed. Don't use alloca.
2656 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2658 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2660 * insdel.c, lisp.h (buffer_overflow): New function.
2661 (insert_from_buffer_1, replace_range, replace_range_2):
2662 * insdel.c (make_gap_larger):
2663 * editfns.c (Finsert_char):
2664 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2666 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2668 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2670 Integer overflow and signedness fixes (Bug#8873).
2672 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2673 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2675 * fileio.c: Don't assume EMACS_INT fits in off_t.
2676 (emacs_lseek): New static function.
2677 (Finsert_file_contents, Fwrite_region): Use it.
2678 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2680 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2682 * fns.c: Don't overflow int when computing a list length.
2683 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2684 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2685 truncation on 64-bit hosts. Check for QUIT every
2686 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2687 faster and is responsive enough.
2688 (Flength): Report an error instead of overflowing an integer.
2689 (Fsafe_length): Return a float if the value is not representable
2690 as a fixnum. This shouldn't happen except in contrived situations.
2691 (Fnthcdr, Fsort): Don't assume list length fits in int.
2692 (Fcopy_sequence): Don't assume vector length fits in int.
2694 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2695 (header_size, word_size): New constants.
2696 (allocate_vectorlike): Don't check size overflow here.
2697 (allocate_vector): Check it here instead, since this is the only
2698 caller of allocate_vectorlike that could cause overflow.
2699 Check that the new vector's length is representable as a fixnum.
2701 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2702 The previous code was bogus. For example, next_almost_prime (32)
2703 returned 39, which is undesirable as it is a multiple of 3; and
2704 next_almost_prime (24) returned 25, which is a multiple of 5 so
2705 why was the code bothering to check for multiples of 7?
2707 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2709 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2711 Variadic C functions now count arguments with ptrdiff_t.
2712 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2713 Back then I didn't know that the Emacs coding style prefers signed int.
2714 Also, in the meantime I found a few more instances where arguments
2715 were being counted with int, which may truncate counts on 64-bit
2716 machines, or EMACS_INT, which may be unnecessarily wide.
2717 * lisp.h (struct Lisp_Subr.function.aMANY)
2718 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2719 Arg counts are now ptrdiff_t, not size_t.
2720 All variadic functions and their callers changed accordingly.
2721 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2722 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2723 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2724 * callint.c (Fcall_interactively): Check arg count for overflow,
2725 to avoid potential buffer overrun. Use signed char, not 'int',
2726 for 'varies' array, so that we needn't bother to check its size
2727 calculation for overflow.
2728 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2729 * eval.c (apply_lambda):
2730 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2731 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2732 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2734 * callint.c (Fcall_interactively): Don't use index var as event count.
2736 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2737 * mem-limits.h (SIZE): Remove; no longer used.
2739 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2741 Remove unnecessary casts.
2742 * xterm.c (x_term_init):
2743 * xfns.c (x_set_border_pixel):
2744 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2745 These aren't needed now that we assume ANSI C.
2747 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2748 It's more likely to cause problems (due to unsigned overflow)
2751 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2753 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2755 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2757 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2759 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2761 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2763 GLYPH_CODE_FACE returns EMACS_INT, not int.
2764 * dispextern.h (merge_faces):
2765 * xfaces.c (merge_faces):
2766 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2767 Don't assume EMACS_INT fits in int.
2769 * character.h (CHAR_VALID_P): Remove unused parameter.
2770 * fontset.c, lisp.h, xdisp.c: All uses changed.
2772 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2774 * fns.c (concat): Minor tuning based on overflow analysis.
2775 This doesn't fix any bugs. Use int to hold character, instead
2776 of constantly refetching from Emacs object. Use XFASTINT, not
2777 XINT, for value known to be a character. Don't bother comparing
2778 a single byte to 0400, as it's always less.
2780 * floatfns.c (Fexpt):
2781 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2783 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2786 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2788 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2789 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2790 incorrectly succeed when S was a string, because 4294967386 was
2791 truncated before it was used.
2793 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2794 Otherwise, an out-of-range integer could cause undefined behavior
2797 * composite.c: Use int, not EMACS_INT, for characters.
2798 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2799 EMACS_INT, for values that are known to be in character range.
2800 This doesn't fix any bugs but is the usual style inside Emacs and
2801 may generate better code on 32-bit machines.
2803 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2804 This is for reasons similar to the recent CHAR_STRING fix.
2805 * charset.c (Fencode_char): Check that character arg is actually
2806 a character. Pass an int to ENCODE_CHAR.
2807 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2808 wider than 'int', as a compile-time check to prevent future regressions
2811 * character.c (char_string): Remove unnecessary casts.
2813 Make sure a 64-bit char is never passed to CHAR_STRING.
2814 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2815 by silently ignoring the top 32 bits, allowing some values
2816 that were far too large to be valid characters.
2817 * character.h: Include <verify.h>.
2818 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2819 arguments are no wider than unsigned, as a compile-time check
2820 to prevent future regressions in this area.
2822 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2823 (Fsubst_char_in_region):
2825 * xdisp.c (decode_mode_spec_coding):
2826 Adjust to CHAR_STRING's new requirement.
2827 * editfns.c (Finsert_char, Fsubst_char_in_region):
2828 * fns.c (concat): Check that character args are actually
2829 characters. Without this test, these functions did the wrong
2830 thing with wildly out-of-range values on 64-bit hosts.
2832 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2833 These casts should not be needed on 32-bit hosts, either.
2834 * keyboard.c (read_char):
2835 * lread.c (Fload): Remove casts to unsigned.
2837 * lisp.h (UNSIGNED_CMP): New macro.
2838 This fixes comparison bugs on 64-bit hosts.
2839 (ASCII_CHAR_P): Use it.
2840 * casefiddle.c (casify_object):
2841 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2842 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2843 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2844 * dispextern.h (FACE_FROM_ID):
2845 * keyboard.c (read_char): Use UNSIGNED_CMP.
2847 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2848 not to EMACS_INT, to avoid GCC warning.
2850 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2852 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2853 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2854 isn't needed on 32-bit machines.
2856 * buffer.c (Fgenerate_new_buffer_name):
2857 Use EMACS_INT for count, not int.
2858 (advance_to_char_boundary): Return EMACS_INT, not int.
2860 * data.c (Qcompiled_function): Now static.
2862 * window.c (window_body_lines): Now static.
2864 * image.c (gif_load): Rename local to avoid shadowing.
2866 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2867 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2868 * alloc.c (make_save_value): Integer argument is now of type
2870 (mark_object): Use ptrdiff_t, not int.
2871 * lisp.h (pD): New macro.
2872 * print.c (print_object): Use it.
2874 * alloc.c: Use EMACS_INT, not int, to count objects.
2875 (total_conses, total_markers, total_symbols, total_vector_size)
2876 (total_free_conses, total_free_markers, total_free_symbols)
2877 (total_free_floats, total_floats, total_free_intervals)
2878 (total_intervals, total_strings, total_free_strings):
2879 Now EMACS_INT, not int. All uses changed.
2880 (Fgarbage_collect): Compute overall total using a double, so that
2881 integer overflow is less likely to be a problem. Check for overflow
2882 when converting back to an integer.
2883 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2884 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2885 These were 'int' variables that could overflow on 64-bit hosts;
2886 they were never used, so remove them instead of repairing them.
2887 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2888 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2889 Previously, this ceilinged at INT_MAX, but that doesn't work on
2891 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2893 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2894 (allocate_vectorlike): Check for ptrdiff_t overflow.
2895 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2896 when a (possibly-narrower) signed value would do just as well.
2897 We prefer using signed arithmetic, to avoid comparison confusion.
2899 * alloc.c: Catch some string size overflows that we were missing.
2900 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2901 for convenience in STRING_BYTES_MAX.
2902 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2903 The definition here is exact; the one in lisp.h was approximate.
2904 (allocate_string_data): Check for string overflow. This catches
2905 some instances we weren't catching before. Also, it catches
2906 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2907 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2908 and ptrdiff_t and EMACS_INT are both 64 bits.
2910 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2911 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2912 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2914 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2916 * alloc.c (Fmake_string): Check for out-of-range init.
2918 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2920 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2922 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2924 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2925 xg_get_default_scrollbar_width.
2927 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2928 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2929 (style_changed_cb): Call update_theme_scrollbar_width and call
2930 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2931 all frames (Bug#8505).
2932 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2933 Call gtk_window_set_resizable if HAVE_GTK3.
2934 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2935 and height if HAVE_GTK3 (Bug#8505).
2936 (scroll_bar_width_for_theme): New variable.
2937 (update_theme_scrollbar_width): New function.
2938 (xg_get_default_scrollbar_width): Move code to
2939 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2940 (xg_initialize): Call update_theme_scrollbar_width.
2942 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2944 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2946 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2948 * frame.c (make_frame): Call other_buffer_safely instead of
2951 * window.c (temp_output_buffer_show): Call display_buffer with
2952 second argument Vtemp_buffer_show_specifiers and reset latter
2953 immediately after the call.
2954 (Vtemp_buffer_show_specifiers): New variable.
2955 (auto_window_vscroll_p, next_screen_context_lines)
2956 (Vscroll_preserve_screen_position): Remove leading asterisks from
2959 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2961 Fix minor problems found by GCC 4.6.0 static checking.
2962 * buffer.c (Qclone_number): Remove for now, as it's unused.
2963 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2964 (record_buffer): Remove unused local.
2965 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2966 (set_frame_buffer_list): Remove; unused.
2967 * frame.h (other_visible_frames): Remove decl.
2968 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2969 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2970 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2972 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2973 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2974 Define only if HAVE_GPM.
2975 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2976 (update_hints_inhibit): Remove; never set. All uses removed.
2977 * widgetprv.h (emacsFrameClassRec): Remove decl.
2978 * window.c (delete_deletable_window): Now returns void, since it
2979 wasn't returning anything.
2980 (compare_window_configurations): Remove unused locals.
2981 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2982 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2983 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2984 the same widths as pointers. This follows up on the 2011-05-06 patch.
2985 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2986 * xterm.h: Likewise.
2987 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2989 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2991 * makefile.w32-in: Update dependencies.
2992 (LISP_H): Add lib/intprops.h.
2994 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2996 * image.c (gif_load): Add animation frame delay to the metadata.
2997 (syms_of_image): Use DEFSYM. New symbol `delay'.
2999 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3001 * window.c (delete_deletable_window): Re-add.
3002 (Fset_window_configuration): Rewrite to handle dead buffers and
3003 consequently deletable windows.
3004 (window_tree, Fwindow_tree): Remove. Supply functionality in
3006 (compare_window_configurations): Simplify code.
3008 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3010 * image.c (imagemagick_load_image): Fix type mismatch.
3011 (Fimagemagick_types): Likewise.
3013 * window.h (replace_buffer_in_windows): Declare.
3015 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3017 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3018 Qclone_number. Remove external declaration of Qdelete_window.
3019 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3021 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3022 Run Qbuffer_list_update_hook if allowed.
3023 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3024 buffer list implementation.
3025 (other_buffer_safely): New function.
3026 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3027 calls to replace_buffer_in_windows and
3028 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3030 (record_buffer): Inhibit quitting and rewrite using quittable
3031 functions. Run Qbuffer_list_update_hook if allowed.
3032 (Frecord_buffer, Funrecord_buffer): New functions.
3033 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3034 Move switch-to-buffer to window.el.
3035 (bury-buffer): Move to window.el.
3036 (Vbuffer_list_update_hook): New variable.
3038 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3041 * window.h (resize_frame_windows): Move up in code.
3042 (Fwindow_frame): Remove EXFUN.
3043 (replace_buffer_in_all_windows): Remove prototype.
3044 (replace_buffer_in_windows_safely): Add prototype.
3046 * window.c: Declare Qdelete_window static again. Move down
3047 declaration of select_count.
3048 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3049 (Fother_window): Move to window.el.
3050 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3051 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3052 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3054 (replace_buffer_in_windows): Implement by calling
3055 Qreplace_buffer_in_windows.
3056 (replace_buffer_in_all_windows): Remove with some functionality
3057 moved into replace_buffer_in_windows_safely.
3058 (replace_buffer_in_windows_safely): New function.
3059 (select_window_norecord, select_frame_norecord): Move in front
3060 of run_window_configuration_change_hook. Remove now obsolete
3062 (Fset_window_buffer): Rewrite doc-string.
3063 Call Qrecord_window_buffer.
3064 (keys_of_window): Move binding for other-window to window.el.
3066 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3068 * dispextern.h (struct image): Replace data member, whose int_val
3069 and ptr_val fields were not used by anything, with a single
3072 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3073 (gif_clear_image, gif_load, imagemagick_load_image)
3074 (gs_clear_image, gs_load): Callers changed.
3076 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3078 * buffer.h: Include <time.h>, for time_t.
3079 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3081 Fix minor problems found by static checking.
3083 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3085 Make identifiers static if they are not used in other modules.
3086 * data.c (Qcompiled_function, Qframe, Qvector):
3087 * image.c (QimageMagick, Qsvg):
3088 * minibuf.c (Qmetadata):
3089 * window.c (resize_window_check, resize_root_window): Now static.
3090 * window.h (resize_window_check, resize_root_window): Remove decls.
3092 * window.c (window_deletion_count, delete_deletable_window):
3094 (window_body_lines): Now static.
3095 (Fdelete_other_windows_internal): Mark vars as initialized.
3096 Make sure 'resize_failed' is initialized.
3097 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3098 (resize_window_apply): Remove unused local.
3099 * window.h (delete_deletable_window): Remove decl.
3101 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3102 (imagemagick_load_image): Fix pointer signedness problem by changing
3103 last arg from unsigned char * to char *. All uses changed.
3104 Also, fix a local for similar reasons.
3105 Remove unused locals. Remove locals to avoid shadowing.
3106 (fn_rsvg_handle_free): Remove; unused.
3107 (svg_load, svg_load_image): Fix pointer signedness problem.
3108 (imagemagick_load_image): Don't use garbage pointer image_wand.
3110 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3112 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3114 * image.c (gif_load): Fix omitted cast error introduced by
3117 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3119 * window.h (resize_proportionally, orig_total_lines)
3120 (orig_top_line): Remove from window structure.
3121 (set_window_height, set_window_width, change_window_heights)
3122 (Fdelete_window): Remove prototypes.
3123 (resize_frame_windows): Remove duplicate declaration.
3125 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3127 * window.h (resize_frame_windows, resize_window_check)
3128 (delete_deletable_window, resize_root_window)
3129 (resize_frame_windows): Declare prototypes.
3131 * window.c (resize_window_apply): Make definition be "static" to
3132 match the prototype.
3134 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3136 * window.c: Remove declarations of Qwindow_size_fixed,
3137 window_min_size_1, window_min_size_2, window_min_size,
3138 size_window, window_fixed_size_p, enlarge_window, delete_window.
3139 Remove static from declaration of Qdelete_window, it's
3140 temporarily needed by Fbury_buffer.
3141 (replace_window): Don't assign orig_top_line and
3143 (Fdelete_window, delete_window): Remove. Window deletion is
3144 handled by window.el.
3145 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3146 Replace Fdelete_window calls with calls to Qdelete_window.
3147 (Fdelete_other_windows): Remove. Deleting other windows is
3148 handled by window.el.
3149 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3150 handled in window.el.
3151 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3152 Window minimum sizes are handled in window.el.
3153 (shrink_windows, size_window, set_window_height)
3154 (set_window_width, change_window_heights, window_height)
3155 (window_width, CURBEG, CURSIZE, enlarge_window)
3156 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3157 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3158 handled in window.el.
3159 (make_dummy_parent): Rename to make_parent_window and give it a
3160 second argument horflag.
3161 (make_window): Don't set resize_proportionally any more.
3162 (Fsplit_window): Remove. Windows are split in window.el.
3163 (save_restore_action, save_restore_orig_size)
3164 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3165 Resize mini windows in window.el.
3166 (grow_mini_window, shrink_mini_window): Implement by calling
3167 Qresize_root_window_vertically, resize_window_check and
3168 resize_window_apply.
3169 (saved_window, Fset_window_configuration, save_window_save):
3170 Do not handle orig_top_line, orig_total_lines, and
3171 resize_proportionally.
3172 (window_min_height, window_min_width): Move to window.el.
3173 (keys_of_window): Move bindings for delete-other-windows,
3174 split-window, delete-window and enlarge-window to window.el.
3176 * buffer.c: Temporarily extern Qdelete_window.
3177 (Fbury_buffer): Temporarily call Qdelete_window instead of
3178 Fdelete_window (Fbury_buffer will move to window.el soon).
3180 * frame.c (set_menu_bar_lines_1): Remove code handling
3181 orig_top_line and orig_total_lines.
3183 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3184 set_window_height but set heights directly.
3185 (change_frame_size_1): Use resize_frame_windows.
3187 * xdisp.c (init_xdisp): Don't use set_window_height but set
3190 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3191 Use resize_frame_windows instead of change_window_heights and run
3192 run_window_configuration_change_hook.
3194 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3195 instead of change_window_heights and run
3196 run_window_configuration_change_hook.
3198 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3200 * window.c (replace_window): Rename second argument REPLACEMENT to
3201 NEW. New third argument SETFLAG. Rewrite.
3202 (delete_window, make_dummy_parent): Call replace_window with
3204 (window_list_1): Move down in code.
3205 (run_window_configuration_change_hook): Move set_buffer part
3206 before select_frame_norecord part in order to unwind correctly.
3207 Rename count1 to count.
3208 (recombine_windows, delete_deletable_window, resize_root_window)
3209 (Fdelete_other_windows_internal)
3210 (Frun_window_configuration_change_hook, make_parent_window)
3211 (resize_window_check, resize_window_apply, Fresize_window_apply)
3212 (resize_frame_windows, Fsplit_window_internal)
3213 (Fdelete_window_internal, Fresize_mini_window_internal):
3215 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3217 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3219 * window.h (window): Add some new members to window structure -
3220 normal_lines, normal_cols, new_total, new_normal, clone_number,
3221 splits, nest, prev_buffers, next_buffers.
3222 (WINDOW_TOTAL_SIZE): Move here from window.c.
3223 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3225 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3227 (make_dummy_parent): Set new members of windows structure.
3228 (make_window): Move down in code. Handle new members of window
3230 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3231 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3232 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3233 (Fset_window_prev_buffers, Fwindow_next_buffers)
3234 (Fset_window_next_buffers, Fset_window_clone_number):
3236 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3237 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3239 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3240 Argument WINDOW can be now internal window too.
3241 (Fwindow_use_time): Move up in code.
3242 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3244 (Fset_window_configuration, saved_window)
3245 (Fcurrent_window_configuration, save_window_save): Handle new
3246 members of window structure.
3247 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3248 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3249 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3250 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3251 Qget_mru_window, Qresize_root_window,
3252 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3253 Qauto_buffer_name; staticpro them.
3255 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3257 * window.c (Fwindow_total_size, Fwindow_left_column)
3258 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3259 (Fwindow_list_1): New functions.
3260 (window_box_text_cols): Replace with window_body_cols.
3261 (Fwindow_width, Fscroll_left, Fscroll_right):
3262 Use window_body_cols instead of window_box_text_cols.
3263 (delete_window, Fset_window_configuration):
3264 Call delete_all_subwindows with window as argument.
3265 (delete_all_subwindows): Take a window as argument and not a
3267 (window_loop): Remove handling of GET_LRU_WINDOW and
3269 (Fget_lru_window, Fget_largest_window): Move to window.el.
3271 * window.h: Extern window_body_cols instead of
3272 window_box_text_cols. delete_all_subwindows now takes a
3273 Lisp_Object as argument.
3275 * indent.c (compute_motion, Fcompute_motion):
3276 Use window_body_cols instead of window_box_text_cols.
3278 * frame.c (delete_frame): Call delete_all_subwindows with root
3281 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3283 * fns.c (Fputhash): Document return value.
3285 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3287 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3289 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3291 Cons<->int and similar integer overflow fixes (Bug#8794).
3293 Check for overflow when converting integer to cons and back.
3294 * charset.c (Fdefine_charset_internal, Fdecode_char):
3295 Use cons_to_unsigned to catch overflow.
3296 (Fencode_char): Use INTEGER_TO_CONS.
3297 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3298 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3299 * data.c (long_to_cons, cons_to_long): Remove.
3300 (cons_to_unsigned, cons_to_signed): New functions.
3301 These signal an error for invalid or out-of-range values.
3302 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3303 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3304 * font.c (Ffont_variation_glyphs):
3305 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3306 * lisp.h: Include <intprops.h>.
3307 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3308 (cons_to_signed, cons_to_unsigned): New decls.
3309 (long_to_cons, cons_to_long): Remove decls.
3310 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3311 (Fprimitive_undo): Use CONS_TO_INTEGER.
3312 * xfns.c (Fx_window_property): Likewise.
3313 * xselect.c: Include <limits.h>.
3314 (x_own_selection, selection_data_to_lisp_data):
3315 Use INTEGER_TO_CONS.
3316 (x_handle_selection_request, x_handle_selection_clear)
3317 (x_get_foreign_selection, Fx_disown_selection_internal)
3318 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3319 (lisp_data_to_selection_data): Use cons_to_unsigned.
3320 (x_fill_property_data): Use cons_to_signed.
3321 Report values out of range.
3323 Check for buffer and string overflow more precisely.
3324 * buffer.h (BUF_BYTES_MAX): New macro.
3325 * lisp.h (STRING_BYTES_MAX): New macro.
3326 * alloc.c (Fmake_string):
3327 * character.c (string_escape_byte8):
3328 * coding.c (coding_alloc_by_realloc):
3329 * doprnt.c (doprnt):
3330 * editfns.c (Fformat):
3332 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3333 since they may not be the same number.
3334 * editfns.c (Finsert_char):
3335 * fileio.c (Finsert_file_contents):
3336 Likewise for BUF_BYTES_MAX.
3338 * image.c: Use ptrdiff_t, not int, for sizes.
3339 (slurp_file): Switch from int to ptrdiff_t.
3341 (slurp_file): Check that file size fits in both size_t (for
3342 malloc) and ptrdiff_t (for sanity and safety).
3344 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3345 if b->modtime has its maximal value.
3347 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3349 Don't assume time_t can fit into int.
3350 * buffer.h (struct buffer.modtime): Now time_t, not int.
3351 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3352 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3354 Minor fixes for signed vs unsigned integers.
3355 * character.h (MAYBE_UNIFY_CHAR):
3356 * charset.c (maybe_unify_char):
3357 * keyboard.c (read_char, reorder_modifiers):
3358 XINT -> XFASTINT, since the integer must be nonnegative.
3359 * ftfont.c (ftfont_spec_pattern):
3360 * keymap.c (access_keymap, silly_event_symbol_error):
3361 XUINT -> XFASTINT, since the integer must be nonnegative.
3362 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3363 since it makes no difference and we prefer signed.
3364 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3365 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3368 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3370 * window.h (Fwindow_frame): Declare.
3372 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3374 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3375 (SPARE_MEMORY): Always define.
3376 (LARGE_REQUEST): Remove.
3377 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3379 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3381 * lisp.h: Move EXFUNS for Fframe_root_window,
3382 Fframe_first_window and Fset_frame_selected_window to window.h.
3384 * window.h: Move EXFUNS for Fframe_root_window,
3385 Fframe_first_window and Fset_frame_selected_window here from
3388 * frame.c (Fwindow_frame, Fframe_first_window)
3389 (Fframe_root_window, Fframe_selected_window)
3390 (Fset_frame_selected_window): Move to window.c.
3391 (Factive_minibuffer_window): Move to minibuf.c.
3392 (Fother_visible_frames_p): New function.
3394 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3396 * window.c (decode_window, decode_any_window): Move up in code.
3397 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3398 (inhibit_frame_unsplittable): Remove unused variable.
3399 (Fwindow_buffer): Move up and rewrite doc-string.
3400 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3401 (Fwindow_prev): New functions.
3402 (Fwindow_frame): Move here from frame.c. Accept any window as
3404 (Fframe_root_window, Fframe_first_window)
3405 (Fframe_selected_window): Move here from frame.c. Accept frame
3406 or arbitrary window as argument. Update doc-strings.
3407 (Fminibuffer_window): Move up in code.
3408 (Fwindow_minibuffer_p): Move up in code and simplify.
3409 (Fset_frame_selected_window): Move here from frame.c.
3411 (Fselected_window, select_window, Fselect_window): Move up in
3412 code. Minor doc-string fixes.
3414 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3416 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3417 Do not assume that spare memory exists; that assumption is valid
3418 only if SYSTEM_MALLOC.
3419 (LARGE_REQUEST): New macro, so that the issue of large requests
3420 is separated from the issue of spare memory.
3422 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3424 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3427 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3429 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3432 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3434 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3436 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3438 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3439 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3441 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3443 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3445 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3447 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3448 (x_clipboard_manager_save): Add return value.
3449 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3451 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3452 Obey Vx_select_enable_clipboard_manager. Catch errors in
3453 x_clipboard_manager_save (Bug#8779).
3454 (Vx_select_enable_clipboard_manager): New variable.
3455 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3457 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3459 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3461 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3463 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3464 in the current matrix if keep_current_p is non-zero.
3466 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3468 * bidi.c (bidi_level_of_next_char): Fix last change.
3470 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3472 Support bidi reordering of text covered by display properties.
3474 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3475 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3476 (bidi_cache_search, bidi_cache_iterator_state)
3477 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3478 (bidi_level_of_next_char, bidi_move_to_visually_next):
3479 Support character positions inside a run of characters covered by a
3481 (bidi_paragraph_init, bidi_resolve_explicit_1)
3482 (bidi_level_of_next_char): Call bidi_fetch_char and
3483 bidi_fetch_char_advance instead of FETCH_CHAR and
3485 (bidi_init_it): Initialize new members.
3486 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3488 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3489 instead of using explicit *_CHAR codes.
3490 (bidi_resolve_explicit, bidi_resolve_weak):
3491 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3492 bidirectional text is supported only in multibyte buffers.
3493 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3494 it to initialize the frame_window_p member of struct bidi_it.
3495 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3496 (bidi_resolve_explicit, bidi_resolve_weak)
3497 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3498 bidi_it->nchars is non-positive.
3499 (bidi_level_of_next_char): Don't try to lookup the cache for the
3500 next/previous character if nothing is cached there yet, or if we
3501 were just reseat()'ed to a new position.
3503 * xdisp.c (set_cursor_from_row): Set start and stop points
3504 according to the row's direction when priming the loop that looks
3505 for the glyph on which to display cursor.
3506 (single_display_spec_intangible_p): Function deleted.
3507 (display_prop_intangible_p): Reimplement to call
3508 handle_display_spec instead of single_display_spec_intangible_p.
3509 Accept 3 additional arguments needed by handle_display_spec.
3510 This fixes incorrect cursor motion across display property with complex
3511 values: lists, `(when COND...)' forms, etc.
3512 (single_display_spec_string_p): Support property values that are
3513 lists with the argument STRING its top-level element.
3514 (display_prop_string_p): Fix the condition for processing a
3515 property that is a list to be consistent with handle_display_spec.
3516 (handle_display_spec): New function, refactored from the
3517 last portion of handle_display_prop.
3518 (compute_display_string_pos): Accept additional argument
3519 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3520 value of a `display' property is a "replacing spec".
3521 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3522 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3523 the display property, but just return a value indicating whether
3524 the display property will replace the characters it covers.
3525 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3526 frame_window_p members of struct bidi_it.
3527 (compute_display_string_pos, compute_display_string_end):
3529 (push_it): Accept second argument POSITION, where pop_it should
3530 jump to continue iteration.
3531 (reseat_1): Initialize bidi_it.disp_pos.
3533 * keyboard.c (adjust_point_for_property): Adjust the call to
3534 display_prop_intangible_p to its new signature.
3536 * dispextern.h (struct bidi_it): New member frame_window_p.
3537 (bidi_init_it): Update prototypes.
3538 (display_prop_intangible_p): Update prototype.
3539 (compute_display_string_pos, compute_display_string_end):
3541 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3544 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3546 Malloc failure behavior now depends on size of allocation.
3547 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3548 * lisp.h: Change signatures accordingly.
3549 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3550 All callers changed. (Bug#8762)
3552 * gnutls.c: Use Emacs's memory allocators.
3553 Without this change, the gnutls library would invoke malloc etc.
3554 directly, which causes problems on non-SYNC_INPUT hosts, and which
3555 runs afoul of improving memory_full behavior. (Bug#8761)
3556 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3557 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3558 xfree instead of the default malloc, realloc, free.
3559 (Fgnutls_boot): No need to check for memory allocation failure,
3560 since xmalloc does that for us.
3562 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3563 * category.c (hash_get_category_set):
3564 * ccl.c (ccl_driver):
3565 * charset.c (Fdefine_charset_internal):
3566 * charset.h (struct charset.hash_index):
3567 * composite.c (get_composition_id, gstring_lookup_cache)
3568 (composition_gstring_put_cache):
3569 * composite.h (struct composition.hash_index):
3570 * dispextern.h (struct image.hash):
3571 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3572 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3573 (hashfn_equal, hashfn_user_defined, make_hash_table)
3574 (maybe_resize_hash_table, hash_lookup, hash_put)
3575 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3576 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3577 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3578 * image.c (make_image, search_image_cache, lookup_image)
3579 (xpm_put_color_table_h):
3580 * lisp.h (struct Lisp_Hash_Table):
3581 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3582 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3583 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3584 * alloc.c (allocate_vectorlike):
3585 Check for overflow in vector size calculations.
3586 * ccl.c (ccl_driver):
3587 Check for overflow when converting EMACS_INT to int.
3588 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3589 need to be updated by these changes.
3590 * fns.c (make_hash_table, maybe_resize_hash_table):
3591 Check for integer overflow with large hash tables.
3592 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3593 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3594 (SXHASH_REDUCE): New macro.
3595 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3596 Use it instead of discarding useful hash info with large hash values.
3597 (sxhash_float): New function.
3598 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3599 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3600 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3601 Rewrite to use FIXNUM_BITS, as this simplifies things.
3602 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3603 Adjust signatures to match updated version of code.
3604 (consing_since_gc): Now EMACS_INT, since a single hash table can
3605 use more than INT_MAX bytes.
3607 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3609 Make it possible to build with GCC-4.6+ -O2 -flto.
3611 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3613 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3615 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3616 Call minibuffer-inactive-mode.
3618 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3620 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3621 Update dependencies.
3623 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3625 * data.c (init_data): Remove code for UTS, this system is not
3628 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3630 Don't force ./temacs to start in terminal mode.
3632 * frame.c (make_initial_frame): Initialize faces in all cases, not
3633 only when CANNOT_DUMP is defined.
3634 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3636 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3638 * dispnew.c (add_window_display_history): Use const for the string
3639 pointer. Remove declaration, not needed.
3641 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3643 Use 'inline', not 'INLINE'.
3644 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3645 * alloc.c, fontset.c (INLINE): Remove.
3646 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3647 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3648 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3649 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3650 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3652 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3654 Make it possible to run ./temacs.
3656 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3657 syms_of_callproc does the same thing. Remove test for
3658 "initialized", do it in the caller.
3659 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3661 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3663 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3664 (read_minibuf): Use get_minibuffer.
3665 (syms_of_minibuf): Use DEFSYM.
3666 (Qmetadata): New var.
3667 * data.c (Qbuffer): Don't make it static.
3668 (syms_of_data): Use DEFSYM.
3670 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3672 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3673 (CCL_CODE_MIN): New macro.
3675 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3677 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3679 * eval.c (Qdebug): Now static.
3680 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3681 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3682 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3684 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3686 * image.c: Various fixes to ImageMagick code comments.
3687 (Fimagemagick_types): Doc fix.
3689 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3691 Minor fixes prompted by GCC 4.6.0 warnings.
3693 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3695 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3696 (x_clipboard_manager_save_all): Move extern decl to ...
3697 * xterm.h: ... here, so that it can be checked for consistency.
3699 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3701 * xselect.c (x_clipboard_manager_save_frame)
3702 (x_clipboard_manager_save_all): New functions.
3703 (Fx_clipboard_manager_save): Lisp function deleted.
3705 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3706 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3708 * xterm.h: Update prototype.
3710 2011-05-28 William Xu <william.xwl@gmail.com>
3712 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3715 2011-05-28 Jim Meyering <meyering@redhat.com>
3717 Avoid a sign-extension bug in crypto_hash_function.
3718 * fns.c (to_uchar): Define.
3719 (crypto_hash_function): Use it to convert some newly-signed
3720 variables to unsigned, to avoid sign-extension bugs. For example,
3721 without this change, (md5 "truc") would evaluate to
3722 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3723 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3724 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3726 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3728 Integer overflow fixes.
3730 * dbusbind.c: Serial number integer overflow fixes.
3731 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3732 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3733 to hold a serial number that is too large for a fixnum.
3734 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3735 Check for serial numbers out of range. Decode any serial number
3736 that was so large that it became a float. (Bug#8722)
3738 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3739 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3740 Use XFASTINT rather than XUINT when numbers are nonnegative.
3741 (xd_append_arg, Fdbus_method_return_internal):
3742 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3743 arguments, check that Lisp number is nonnegative, rather than
3744 silently wrapping negative numbers around. (Bug#8722)
3745 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3748 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3750 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3752 ccl: add integer overflow checks
3753 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3754 (IN_INT_RANGE): New macros.
3755 (ccl_driver): Use them to check for integer overflow when
3756 decoding a CCL program. Many of the new checks are whether XINT (x)
3757 fits in int; it doesn't always, on 64-bit hosts. The new version
3758 doesn't catch all possible integer overflows, but it's an
3759 improvement. (Bug#8719)
3761 * alloc.c (make_event_array): Use XINT, not XUINT.
3762 There's no need for unsigned here.
3764 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3765 This follows up to the 2011-05-06 change that substituted uintptr_t
3766 for EMACS_INT. This case wasn't caught back then.
3768 Rework Fformat to avoid integer overflow issues.
3769 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3770 now (part of C89). Include <verify.h>.
3771 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3772 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3773 (Fformat): Avoid the prepass trying to compute sizes; it was only
3774 approximate and thus did not catch overflow reliably. Instead, walk
3775 through the format just once, formatting and computing sizes as we go,
3776 checking for integer overflow at every step, and allocating a larger
3777 buffer as needed. Keep track separately whether the format is
3778 multibyte. Keep only the most-recently calculated precision, rather
3779 than them all. Record whether each argument has been converted to
3780 string. Use EMACS_INT, not int, for byte and char and arg counts.
3781 Support field widths and precisions larger than INT_MAX. Avoid
3782 sprintf's undefined behavior with conversion specifications such as %#d
3783 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3784 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3785 formatting out-of-range floating point numbers with int
3788 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3790 * data.c: Avoid integer truncation in expressions involving floats.
3791 * data.c: Include <intprops.h>.
3792 (arith_driver): When there's an integer overflow in an expression
3793 involving floating point, convert the integers to floating point
3794 so that the resulting value does not suffer from catastrophic
3795 integer truncation. For example, on a 64-bit host (* 4
3796 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3797 Do not rely on undefined behavior after integer overflow.
3799 merge count_size_as_multibyte, parse_str_to_multibyte
3800 * character.c, character.h (count_size_as_multibyte):
3801 Rename from parse_str_to_multibyte; all uses changed.
3802 Check for integer overflow.
3803 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3804 since it's now a duplicate of the other. This is more of
3805 a character than a buffer op, so better that it's in character.c.
3806 * fns.c, print.c: Adjust to above changes.
3808 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3810 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3812 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3814 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3815 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3816 (x_clipboard_manager_save): Now static.
3817 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3819 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3820 (crypto_hash_function): Now static.
3821 Fix pointer signedness problems. Avoid unnecessary initializations.
3823 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3825 * termhooks.h (Vselection_alist): Make it terminal-local.
3827 * terminal.c (create_terminal): Initialize it.
3829 * xselect.c: Support for clipboard managers.
3830 (Vselection_alist): Move to termhooks.h as terminal-local var.
3831 (LOCAL_SELECTION): New macro.
3832 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3833 (symbol_to_x_atom): Remove gratuitous arg.
3834 (x_handle_selection_request, lisp_data_to_selection_data)
3835 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3836 (x_own_selection, x_get_local_selection, x_convert_selection):
3837 New arg, specifying work frame. Use terminal-local Vselection_alist.
3838 (some_frame_on_display): Delete unused function.
3839 (Fx_own_selection_internal, Fx_get_selection_internal)
3840 (Fx_disown_selection_internal, Fx_selection_owner_p)
3841 (Fx_selection_exists_p): New optional frame arg.
3842 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3843 (x_handle_selection_clear): Don't treat other terminals with the
3844 same keyboard specially. Use the terminal-local Vselection_alist.
3845 (x_clear_frame_selections): Use Frun_hook_with_args.
3847 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3849 * xterm.h: Add support for those atoms.
3851 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3853 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3854 (converted_selections, conversion_fail_tag): New global variables.
3855 (x_selection_request_lisp_error): Free the above.
3856 (x_get_local_selection): Remove unnecessary code.
3857 (x_reply_selection_request): Args changed; handle arbitrary array
3858 of converted selections stored in converted_selections.
3859 Separate the XChangeProperty and SelectionNotify steps.
3860 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3861 (x_convert_selection): New function.
3862 (x_handle_selection_event): Simplify.
3863 (x_get_foreign_selection): Don't ignore incoming requests while
3864 waiting for an answer; this will fail when we implement
3865 SAVE_TARGETS, and seems unnecessary anyway.
3866 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3867 (Vx_sent_selection_functions): Doc fix.
3869 2011-05-26 Leo Liu <sdl.web@gmail.com>
3871 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3873 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3875 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3877 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3878 for fringe update if it has periodic bitmap.
3879 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3880 and fringe_bitmap_periodic_p.
3882 * fringe.c (get_fringe_bitmap_data): New function.
3883 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3884 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3885 row. Mark glyph row for fringe update if periodicity changed.
3887 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3888 for fringe update unless it has periodic bitmap.
3890 2011-05-25 Kenichi Handa <handa@m17n.org>
3892 * xdisp.c (get_next_display_element): Set correct it->face_id for
3893 a static composition.
3895 2011-05-24 Leo Liu <sdl.web@gmail.com>
3898 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3900 * fns.c (crypto_hash_function, Fsha1): New function.
3901 (Fmd5): Use crypto_hash_function.
3902 (syms_of_fns): Add Ssha1.
3904 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3906 * gnutls.c: Remove unused macros.
3907 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3908 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3909 Remove macros that are defined and never used.
3910 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3912 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3914 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3915 (Fx_get_selection_internal): Minor cleanup.
3916 (Fx_own_selection_internal): Rename arguments for consistency with
3919 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3921 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3923 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3925 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3927 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3929 * dispnew.c (scrolling_window): Don't exclude the case that the
3930 last enabled row in the desired matrix touches the bottom boundary.
3932 2011-05-21 Glenn Morris <rgm@gnu.org>
3934 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3935 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3936 and add some more files.
3938 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3940 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3941 report_file_error introduced by the change from 2011-05-07.
3943 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3945 * systime.h (Time): Define only if emacs is defined.
3946 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3947 where the include path doesn't have X11/X.h by default. See
3948 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3950 2011-05-20 Kenichi Handa <handa@m17n.org>
3952 * composite.c (find_automatic_composition): Fix previous change.
3954 2011-05-20 Glenn Morris <rgm@gnu.org>
3956 * lisp.mk: New file, split from Makefile.in.
3957 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3958 (shortlisp): Remove.
3959 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3961 2011-05-19 Glenn Morris <rgm@gnu.org>
3963 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3964 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3965 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3966 (lisp): Set the order to that of loadup.el.
3967 (shortlisp): Make it a copy of $lisp.
3968 (SOME_MACHINE_LISP): Remove.
3969 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3970 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3972 2011-05-18 Kenichi Handa <handa@m17n.org>
3974 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3975 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3976 (find_automatic_composition): Mostly rewrite for efficiency.
3978 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3980 * makefile.w32-in: Update dependencies.
3982 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3984 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3985 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3987 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3989 Fix some integer overflow issues, such as string length overflow.
3991 * insdel.c (count_size_as_multibyte): Check for string overflow.
3993 * character.c (lisp_string_width): Check for string overflow.
3994 Use EMACS_INT, not int, for string indexes and lengths; in
3995 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3996 the resulting string length overflows an EMACS_INT; instead,
3997 report a string overflow if no precision given. When checking for
3998 precision exhaustion, use a check that cannot possibly have
3999 integer overflow. (Bug#8675)
4000 * character.h (lisp_string_width): Adjust to new signature.
4002 * alloc.c (string_overflow): New function.
4003 (Fmake_string): Use it. This doesn't change behavior, but saves
4004 a few bytes and will simplify future changes.
4005 * character.c (string_escape_byte8): Likewise.
4006 * lisp.h (string_overflow): New decl.
4008 Fixups, following up to the user-interface timestamp change.
4009 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4010 for UI timestamps, instead of unsigned long.
4011 * msdos.c (mouse_get_pos): Likewise.
4012 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4013 * w32gui.h (Time): Define by including "systime.h" rather than by
4014 declaring it ourselves. (Bug#8664)
4016 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4017 * image.c (clear_image_cache): Likewise.
4019 * term.c (term_mouse_position): Don't assume time_t wraparound.
4021 Be more systematic about user-interface timestamps.
4022 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4023 and sometimes 'EMACS_UINT', to represent these timestamps.
4024 This change causes it to use 'Time' uniformly, as that's what X uses.
4025 This makes the code easier to follow, and makes it easier to catch
4026 integer overflow bugs such as Bug#8664.
4027 * frame.c (Fmouse_position, Fmouse_pixel_position):
4028 Use Time, not unsigned long, for user-interface timestamps.
4029 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4030 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4031 * keyboard.h (last_event_timestamp): Likewise.
4032 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4033 * menu.h (xmenu_show): Likewise.
4034 * term.c (term_mouse_position): Likewise.
4035 * termhooks.h (struct input_event.timestamp): Likewise.
4036 (struct terminal.mouse_position_hook): Likewise.
4037 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4038 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4039 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4040 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4042 * menu.h, termhooks.h: Include "systime.h", for Time.
4044 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4045 Don't assume that the difference between two unsigned long values
4046 can fit into an integer. At this point, we know button_down_time
4047 <= event->timestamp, so the difference must be nonnegative, so
4048 there's no need to cast the result if double-click-time is
4049 nonnegative, as it should be; check that it's nonnegative, just in
4050 case. This bug is triggered when events are more than 2**31 ms
4051 apart (about 25 days). (Bug#8664)
4053 * xselect.c (last_event_timestamp): Remove duplicate decl.
4054 (x_own_selection): Remove needless cast to unsigned long.
4056 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4057 that always fit in int. Use a sentinel instead of a counter, to
4058 avoid a temp and to allay GCC's concerns about possible int overflow.
4059 * frame.h (struct frame): Use int for menu_bar_items_used
4060 instead of EMACS_INT, since it always fits in int.
4062 * menu.c (grow_menu_items): Check for int overflow.
4064 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4066 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4067 Before, the code was not consistent. These values cannot exceed
4068 2**31 - 1 so there's no need to make them unsigned.
4069 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4070 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4071 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4073 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4075 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4076 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4077 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4078 presumably because the widths might not match.
4080 * window.c (size_window): Avoid needless test at loop start.
4082 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4084 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4086 2011-05-12 Drew Adams <drew.adams@oracle.com>
4088 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4090 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4092 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4093 `width' to `bar_area_x' and `bar_area_width', respectively.
4094 (x_scroll_run): Take account of fringe background extension.
4096 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4097 Rename local vars `left' and `width' to `bar_area_x' and
4098 `bar_area_width', respectively.
4099 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4100 background extension.
4102 2011-05-10 Jim Meyering <meyering@redhat.com>
4104 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4106 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4108 * image.c (Finit_image_library): Return t for built-in image types,
4109 like pbm and xbm. (Bug#8640)
4111 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4113 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4115 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4117 * w32console.c (Fset_screen_color): Doc fix.
4118 (Fget_screen_color): New function.
4119 (syms_of_ntterm): Defsubr it.
4121 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4122 unlink the temporary file if Fcall_process didn't create it in the
4124 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4125 child process will be redirected to a file specified with `:file'.
4126 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4127 cue to call_process_cleanup not to close that handle.
4129 2011-05-07 Ben Key <bkey76@gmail.com>
4131 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4132 one of two shell specific rules, either bootstrap-temacs-CMD or
4133 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4134 to the previous implementation of the bootstrap-temacs rule.
4135 The bootstrap-temacs-CMD rule is similar to the previous
4136 implementation of the bootstrap-temacs rule except that it
4137 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4140 These changes, along with some changes to nt/configure.bat,
4141 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4142 earlier fix to add support for --cflags and --ldflags options
4143 that include quotes so that it works whether make uses cmd or
4146 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4148 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4149 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4151 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4152 a string. Handle both cases.
4153 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4154 (Fdbus_register_method): Use Qinvalid_function.
4156 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4158 * makefile.w32-in: Update dependencies.
4159 (LISP_H): Add inttypes.h and stdin.h.
4160 (PROCESS_H): Add unistd.h.
4162 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4164 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4165 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4167 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4169 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4171 * term.c (vfatal): Remove stray call to va_end.
4172 It's not needed and the C Standard doesn't allow it here anyway.
4174 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4175 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4177 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4180 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4182 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4184 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4186 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4188 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4190 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4191 * charset.c (Fdefine_charset_internal): Don't initialize
4192 charset.code_space[15]. The value was garbage, on hosts with
4193 32-bit int (Bug#8600).
4195 * lread.c (read_integer): Be more consistent with string-to-number.
4196 Use string_to_number to do the actual conversion; this avoids
4197 rounding errors and fixes some other screwups. Without this fix,
4198 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4199 (digit_to_number): Move earlier, for benefit of read_integer.
4200 Return -1 if the digit is out of range for the base, -2 if it is
4201 not a digit in any supported base. (Bug#8602)
4203 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4205 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4206 to match comment at start of function. This also removes a
4207 GCC warning about overflow in a 32+64-bit port.
4209 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4211 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4212 Reported by Stefan Monnier in
4213 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4214 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4215 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4217 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4218 (EMACS_UINTPTR): Likewise, with uintptr_t.
4220 * lisp.h: Prefer 64-bit EMACS_INT if available.
4221 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4222 on 32-bit hosts that have 64-bit int, so that they can access
4224 However, temporarily disable this change unless the temporary
4225 symbol WIDE_EMACS_INT is defined.
4227 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4229 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4230 This removes an assumption that EMACS_INT and long are the same
4231 width as pointers. The assumption is true for Emacs porting targets
4232 now, but we want to make other targets possible.
4233 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4234 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4235 In the rest of the code, change types of integers that hold casted
4236 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4237 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4238 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4239 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4240 No need to cast type when ORing.
4241 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4242 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4243 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4244 assume EMACS_INT is the same width as char *.
4245 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4246 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4247 Remove no-longer-needed casts.
4248 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4249 (xg_tool_bar_help_callback, xg_make_tool_item):
4250 Use EMACS_INTPTR to hold an integer
4251 that will be cast to void *; this can avoid a GCC warning
4252 if EMACS_INT is not the same width as void *.
4253 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4254 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4255 (current_message_1, set_message_1):
4256 Use a local to convert to proper width without a cast.
4257 * xmenu.c (dialog_selection_callback): Likewise.
4259 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4260 Also, don't assume VALBITS / RAND_BITS is less than 5,
4261 and don't rely on undefined behavior when shifting a 1 left into
4263 * lisp.h (get_random): Change signature to match.
4265 * lread.c (hash_string): Use size_t, not int, for hash computation.
4266 Normally we prefer signed values; but hashing is special, because
4267 it's better to use unsigned division on hash table sizes so that
4268 the remainder is nonnegative. Also, size_t is the natural width
4269 for hashing into memory. The previous code used 'int', which doesn't
4270 retain enough info to hash well into very large tables.
4271 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4273 * dbusbind.c: Don't possibly lose pointer info when converting.
4274 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4275 Use XPNTR rather than XHASH, so that the high-order bits of
4276 the pointer aren't lost when converting through void *.
4278 * eval.c (Fautoload): Don't double-shift a pointer.
4280 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4282 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4284 * gnutls.c (DEF_GNUTLS_FN):
4285 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4287 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4289 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4292 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4294 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4295 New version that can reserve upto 2GB of heap space.
4297 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4299 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4301 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4303 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4304 `gnutls_certificate_set_x509_key_file'.
4306 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4308 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4309 Update dependencies.
4311 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4313 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4314 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4315 Remove unused parameter `fildes'.
4316 * process.c (read_process_output, send_process): Don't pass it.
4318 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4320 Fix previous change: the library cache is defined in w32.c.
4321 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4322 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4324 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4326 Implement dynamic loading of GnuTLS on Windows.
4328 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4329 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4330 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4333 * gnutls.c (Qgnutls_dll): Define.
4334 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4335 (gnutls_*): Declare function pointers.
4336 (init_gnutls_functions): New function to initialize function pointers.
4337 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4338 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4339 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4340 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4341 (emacs_gnutls_write, emacs_gnutls_read)
4342 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4343 (Fgnutls_available_p): New function.
4344 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4345 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4346 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4348 * image.c: Include w32.h.
4349 (Vimage_type_cache): Delete.
4350 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4351 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4352 (w32_delayed_load): Move to w32.c.
4354 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4356 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4357 (w32_delayed_load): Move from image.c. When loading a library, record
4358 its filename in the :loaded-from property of the library id.
4359 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4360 Initialize and staticpro them.
4361 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4363 * process.c: Include lisp.h before w32.h, not after.
4364 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4365 instead of gnutls_record_check_pending.
4367 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4369 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4371 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4372 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4375 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4377 * xterm.c (x_set_frame_alpha): Do not set property on anything
4378 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4380 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4382 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4384 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4386 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4387 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4388 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4389 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4390 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4391 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4392 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4393 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4394 (Qgnutls_bootprop_callbacks_verify): Make static.
4396 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4398 * callproc.c: Indentation fixup.
4400 * sysdep.c (wait_for_termination_1): Make static.
4401 (wait_for_termination, interruptible_wait_for_termination):
4402 Move after wait_for_termination_1.
4404 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4406 * sysdep.c (interruptible_wait_for_termination): New function
4407 which is like wait_for_termination, but allows keyboard
4410 * callproc.c (Fcall_process): Add (:file "file") as an option for
4412 (Fcall_process_region): Ditto.
4414 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4416 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4417 rather than `XVECTOR (FOO)->size'.
4419 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4420 inttypes.h, as a gnulib replacement is used if it not available in
4423 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4425 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4426 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4427 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4429 * coding.c (coding_alloc_by_realloc): Error out if destination
4430 will grow beyond MOST_POSITIVE_FIXNUM.
4431 (decode_coding_emacs_mule): Abort if there isn't enough place in
4432 charbuf for the composition carryover bytes. Reserve an extra
4433 space for up to 2 characters produced in a loop.
4434 (decode_coding_iso_2022): Abort if there isn't enough place in
4435 charbuf for the composition carryover bytes.
4437 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4439 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4440 aborting when %lld or %lll format is passed.
4441 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4442 %llo or %llx format is passed. (Bug#8545)
4444 * window.c (window_scroll_line_based): Use a marker instead of
4445 simple variables to record original value of point. (Bug#7952)
4447 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4448 produced by %s or %c overflows available buffer space. (Bug#8545)
4450 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4452 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4453 (SIZE_MAX): Move defn after all includes, as they might #define it.
4455 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4457 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4459 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4461 * keyboard.c (Qdelayed_warnings_hook): Define.
4462 (command_loop_1): Run `delayed-warnings-hook'
4463 if Vdelayed_warnings_list is non-nil.
4464 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4465 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4467 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4469 * doprnt.c (doprnt): Don't return value smaller than the buffer
4470 size if the message was truncated. (Bug#8545).
4472 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4474 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4475 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4477 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4479 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4481 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4483 * makefile.w32-in: Update dependencies.
4485 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4487 Improve `doprnt' and its usage. (Bug#8545)
4488 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4489 `format_end'. Remove support for %l as a conversion specifier.
4490 Don't use xrealloc. Improve diagnostics when the %l size modifier
4491 is used. Update the commentary.
4493 * eval.c (verror): Simplify calculation of size_t.
4495 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4498 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4500 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4503 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4505 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4506 This makes this file independent of the recent pseudovector change.
4508 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4510 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4512 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4513 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4514 Remove unused local.
4515 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4517 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4518 GCC 4.6.0 optimizes based on type-based alias analysis.
4519 For example, if b is of type struct buffer * and v of type struct
4520 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4521 != &v->size, and therefore "v->size = 1; b->size = 2; return
4522 v->size;" must therefore return 1. This assumption is incorrect
4523 for Emacs, since it type-puns struct Lisp_Vector * with many other
4524 types. To fix this problem, this patch adds a new type struct
4525 vectorlike_header that documents the constraints on layout of vectors
4526 and pseudovectors, and helps optimizing compilers not get fooled
4527 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4528 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4529 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4531 (XSETPVECTYPE): Rewrite in terms of new macro.
4532 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4533 This is a bit clearer, and further avoids the possibility of
4534 undesirable aliasing.
4535 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4536 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4537 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4538 since Lisp_Subr is a special case (no "next" field).
4539 (ASIZE): Now uses header.size rather than size.
4540 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4541 to avoid the hassle of writing XVECTOR (foo)->header.size.
4542 (struct vectorlike_header): New type.
4543 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4544 object, to help avoid aliasing.
4545 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4546 (SUBRP): Likewise, since Lisp_Subr is a special case.
4547 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4548 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4549 (struct Lisp_Hash_Table): Combine first two members into a single
4550 struct vectorlike_header member. All uses of "size" and "next" members
4551 changed to be "header.size" and "header.next".
4552 * buffer.h (struct buffer): Likewise.
4553 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4554 * frame.h (struct frame): Likewise.
4555 * process.h (struct Lisp_Process): Likewise.
4556 * termhooks.h (struct terminal): Likewise.
4557 * window.c (struct save_window_data, struct saved_window): Likewise.
4558 * window.h (struct window): Likewise.
4559 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4560 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4561 * buffer.c (init_buffer_once): Likewise.
4562 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4564 * process.c (Fformat_network_address): Use local var for size,
4567 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4569 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4570 * data.c (atof): Remove decl; no longer used or needed.
4571 (digit_to_number): Move to lread.c.
4572 (Fstring_to_number): Use new string_to_number function, to be
4573 consistent with how the Lisp reader treats infinities and NaNs.
4574 Do not assume that floating-point numbers represent EMACS_INT
4575 without losing information; this is not true on most 64-bit hosts.
4576 Avoid double-rounding errors, by insisting on integers when
4577 parsing non-base-10 numbers, as the documentation specifies.
4578 * lisp.h (string_to_number): New decl, replacing ...
4579 (isfloat_string): Remove.
4580 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4581 (read1): Do not accept +. and -. as integers; this
4582 appears to have been a coding error. Similarly, do not accept
4583 strings like +-1e0 as floating point numbers. Do not report
4584 overflow for integer overflows unless the base is not 10 which
4585 means we have no simple and reliable way to continue.
4586 Break out the floating-point parsing into a new
4587 function string_to_number, so that Fstring_to_number parses
4588 floating point numbers consistently with the Lisp reader.
4589 (digit_to_number): Move here from data.c. Make it static inline.
4590 (E_CHAR, EXP_INT): Remove, replacing with ...
4591 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4592 (string_to_number): New function, replacing isfloat_string.
4593 This function checks for valid syntax and produces the resulting
4594 Lisp float number too. Rework it so that string-to-number
4595 no longer mishandles examples like "1.0e+". Use strtoumax,
4596 so that overflow for non-base-10 numbers is reported only when
4597 there's no portable and simple way to convert to floating point.
4599 * textprop.c (set_text_properties_1): Rewrite for clarity,
4600 and to avoid GCC warning about integer overflow.
4602 * intervals.h (struct interval): Use EMACS_INT for members
4603 where EMACS_UINT might cause problems. See
4604 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4605 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4606 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4608 (offset_intervals): Tell GCC not to worry about length overflow
4609 when negating a negative length.
4611 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4612 (overrun_check_free): Likewise.
4614 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4615 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4618 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4619 (gnutls_make_error): Rename local to avoid shadowing.
4620 (gnutls_emacs_global_deinit): ifdef out; not used.
4621 (Fgnutls_boot): Use const for pointer to readonly storage.
4622 Comment out unused local. Fix pointer signedness problems.
4624 * lread.c (openp): Don't stuff size_t into an 'int'.
4625 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4626 about possible signed overflow.
4628 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4629 (GDK_KEY_g): Don't define if already defined.
4630 (xg_prepare_tooltip): Avoid pointer signedness problem.
4631 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4633 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4634 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4636 * xfns.c (Fx_window_property): Simplify a bit,
4637 to make a bit faster and to avoid GCC 4.6.0 warning.
4638 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4640 * fns.c (internal_equal): Don't assume size_t fits in int.
4642 * alloc.c (compact_small_strings): Tighten assertion a little.
4644 Replace pEd with more-general pI, and fix some printf arg casts.
4645 * lisp.h (pI): New macro, generalizing old pEd macro to other
4646 conversion specifiers. For example, use "...%"pI"d..." rather
4647 than "...%"pEd"...".
4648 (pEd): Remove. All uses replaced with similar uses of pI.
4649 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4650 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4651 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4652 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4653 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4654 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4655 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4657 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4658 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4659 * print.c (safe_debug_print, print_object): Likewise.
4660 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4662 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4663 avoiding the 0 flag, which is not portable.
4664 * process.c (Fmake_network_process): Use pI to avoid cast.
4665 * region-cache.c (pp_cache): Likewise.
4666 * xdisp.c (decode_mode_spec): Likewise.
4667 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4668 behavior on 64-bit hosts with printf arg.
4669 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4670 (x_stop_queuing_selection_requests): Likewise.
4671 (x_get_window_property): Don't truncate byte count to an 'int'
4674 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4675 here, since it parses constructs like leading '-' and spaces,
4676 which are not wanted; and it overflows with large numbers.
4677 Instead, simply match F[0-9]+, which is what is wanted anyway.
4679 * alloc.c: Remove unportable assumptions about struct layout.
4680 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4681 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4682 (allocate_vectorlike, make_pure_vector): Use the new macros,
4683 plus offsetof, to remove unportable assumptions about struct layout.
4684 These assumptions hold on all porting targets that I know of, but
4685 they are not guaranteed, they're easy to remove, and removing them
4686 makes further changes easier.
4688 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4689 This doesn't fix a bug but makes the code clearer.
4690 (string_overrun_cookie): Now const. Use initializers that
4691 don't formally overflow signed char, to avoid warnings.
4692 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4693 can cause Emacs to crash when string overrun checking is enabled.
4694 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4695 multiple of sizeof (EMACS_INT); it need not be, if
4696 alignof(EMACS_INT) < sizeof (EMACS_INT).
4697 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4699 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4701 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4703 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4705 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4706 supposed to be handshaking. (Bug#8556)
4707 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4709 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4711 * lisp.h (Qdebug): List symbol.
4712 * eval.c (Qdebug): Restore global linkage.
4713 * keyboard.c (debug-on-event): New variable.
4714 (handle_user_signal): Break into debugger when debug-on-event
4715 matches the current signal symbol.
4717 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4719 * alloc.c (check_sblock, check_string_bytes)
4720 (check_string_free_list): Convert to standard C.
4722 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4724 * w32.c (emacs_gnutls_push): Fix typo.
4726 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4728 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4729 "cast to pointer from integer of different size".
4731 Improve doprnt and its use in verror. (Bug#8545)
4732 * doprnt.c (doprnt): Document the set of format control sequences
4733 supported by the function. Use SAFE_ALLOCA instead of always
4736 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4737 is one byte too soon. Don't use xrealloc; instead xfree and
4740 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4742 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4745 * gnutls.c: Renamed global_initialized to
4746 gnutls_global_initialized. Added internals for the
4747 :verify-hostname-error, :verify-error, and :verify-flags
4748 parameters of `gnutls-boot' and documented those parameters in the
4749 docstring. Start callback support.
4750 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4751 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4752 on error. Return error code.
4753 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4754 (emacs_gnutls_read): Likewise.
4755 (Fgnutls_boot): Return handshake error code.
4756 (emacs_gnutls_handle_error): New function.
4757 (wsaerror_to_errno): Likewise.
4759 * w32.h (emacs_gnutls_pull): Add prototype.
4760 (emacs_gnutls_push): Likewise.
4762 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4763 (emacs_gnutls_push): Likewise.
4765 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4767 * process.c (wait_reading_process_output): Check if GnuTLS
4768 buffered some data internally if no FDs are set for TLS
4771 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4772 (LIBS): Link to USER_LIBS.
4773 ($(BLD)/gnutls.$(0)): New target.
4775 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4777 * xdisp.c (handle_single_display_spec): Rename the
4778 display_replaced_before_p argument into display_replaced_p, to
4779 make it consistent with the commentary. Fix typos in the
4782 * textprop.c (syms_of_textprop): Remove dead code.
4783 (copy_text_properties): Delete obsolete commentary about an
4784 interface that was deleted long ago. Fix typos in the description
4787 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4788 to changes in oldXMenu/XMenu.h from 2011-04-16.
4789 <menu_help_message, prev_menu_help_message>: Constify.
4790 (IT_menu_make_room): menu->help_text is now `const char **';
4793 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4794 to changes in oldXMenu/XMenu.h from 2011-04-16.
4795 (struct XMenu): Declare `help_text' `const char **'.
4797 * xfaces.c <Qunspecified>: Make extern again.
4799 * syntax.c: Include sys/types.h before including regex.h, as
4802 * doc.c (get_doc_string): Improve the format passed to `error'.
4804 * doprnt.c (doprnt): Improve commentary.
4806 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4808 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4811 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4812 changes in globals.h immediately force recompilation.
4813 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4814 $(CURDIR)/s/ms-w32.h.
4815 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4817 * character.c (Fchar_direction): Function deleted.
4818 (syms_of_character): Don't defsubr it.
4819 <char-direction-table>: Deleted.
4821 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4823 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4824 * doprnt.c: Include limits.h.
4825 (SIZE_MAX): New macro.
4826 (doprnt): Return a size_t value. 2nd arg is now size_t.
4827 Many local variables are now size_t instead of int or unsigned.
4828 Improve overflow protection. Support `l' modifier for integer
4829 conversions. Support %l conversion. Don't assume an EMACS_INT
4830 argument for integer conversions and for %c.
4832 * lisp.h (doprnt): Restore prototype.
4834 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4837 * Makefile.in (base_obj): Add back doprnt.o.
4839 * deps.mk (doprnt.o): Add back prerequisites.
4840 (callint.o): Depend on character.h.
4842 * eval.c (internal_lisp_condition_case): Include the handler
4843 representation in the error message.
4844 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4845 when breaking from the loop.
4847 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4849 * callint.c (Fcall_interactively): When displaying error message
4850 about invalid control letter, pass the character's codepoint, not
4851 a pointer to its multibyte form. Improve display of the character
4852 in octal and display also its hex code.
4854 * character.c (char_string): Use %x to display the (unsigned)
4855 codepoint of an invalid character, to avoid displaying a bogus
4858 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4859 `error', not SYMBOL_NAME itself.
4861 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4862 character arguments to `error'.
4864 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4865 to `error' in error message about FINAL_CHAR argument. Make sure
4866 FINAL_CHAR is a character, and use %c when it is passed as
4867 argument to `error'.
4869 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4871 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4873 * w32.c: Include <time.h>.
4874 (sys_localtime): New function.
4876 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4878 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4880 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4882 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4884 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4887 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4889 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4890 gl_state.e_property when gl_state.object is Qt.
4892 * insdel.c (make_gap_larger): Remove limitation of buffer size
4895 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4897 * xdisp.c (lookup_glyphless_char_display)
4898 (produce_glyphless_glyph): Handle cons cell entry in
4899 glyphless-char-display.
4900 (Vglyphless_char_display): Document it.
4902 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4903 glyphless-char-display.
4905 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4907 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4909 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4911 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4912 definition for no-X builds.
4914 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4916 Static checks with GCC 4.6.0 and non-default toolkits.
4918 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4920 * process.c (keyboard_bit_set): Define only if SIGIO.
4921 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4922 (send_process): Repair possible setjmp clobbering.
4924 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4926 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4928 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4930 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4931 Define only if needed.
4933 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4934 by pacifying GCC about it. Maybe it's time to retire it?
4935 * xfaces.c (USG, __TIMEVAL__): Likewise.
4937 * dispextern.h (struct redisplay_interface): Rename param
4939 * termhooks.h (struct terminal): Likewise.
4940 * xterm.c (xembed_send_message): Likewise.
4942 * insdel.c (make_gap_smaller): Define only if
4943 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4945 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4948 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4949 so that we aren't warned about unused symbols.
4951 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4953 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4955 * xfns.c (x_real_positions): Mark locals as initialized.
4957 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4959 * xterm.c: Fix problems found by static analysis with other toolkits.
4960 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4961 (x_dispatch_event): Declare static if USE_GTK, and
4962 define if USE_GTK || USE_X_TOOLKIT.
4963 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4964 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4965 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4966 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4968 * xmenu.c (menu_help_callback): Pointer type fixes.
4969 Use const pointers when pointing at readonly data. Avoid pointer
4971 (FALSE): Remove unused macro.
4972 (update_frame_menubar): Remove unused decl.
4974 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4976 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4977 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4978 (single_menu_item): Rename local to avoid shadowing.
4980 * keyboard.c (make_lispy_event): Remove unused local var.
4982 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4983 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4985 * bitmaps: Change bitmaps from unsigned char back to the X11
4986 compatible char. Avoid the old compiler warnings about
4987 out-of-range initializers by using, for example, '\xab' rather
4990 * xgselect.c (xgselect_initialize): Check vs interface
4991 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4993 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4995 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4996 to read-only memory.
4998 * fns.c (vector): Remove; this old hack is no longer needed.
5000 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5002 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5004 * xrdb.c (x_load_resources): Omit unused local.
5006 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5007 (x_window): Rename locals to avoid shadowing.
5008 (USG): Use the kludged USG macro, to pacify gcc.
5010 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5011 (x_term_init): Remove local to avoid shadowing.
5013 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5015 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5016 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5018 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5020 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5022 Fix regex.c, syntax.c and friends for buffers > 2GB.
5023 * syntax.h (struct gl_state_s): Declare character position members
5026 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5028 * textprop.c (verify_interval_modification, interval_of):
5029 Declare arguments EMACS_INT.
5031 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5034 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5036 * indent.c (Fvertical_motion): Local variable it_start is now
5039 * regex.c (re_match, re_match_2, re_match_2_internal)
5040 (bcmp_translate, regcomp, regexec, print_double_string)
5041 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5042 (re_compile_pattern, re_exec): Declare arguments and local
5043 variables `size_t' and `ssize_t' and return values `regoff_t', as
5045 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5046 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5047 <compile_stack_type>: `size' and `avail' are now `size_t'.
5049 * regex.h <regoff_t>: Use ssize_t, not int.
5050 (re_search, re_search_2, re_match, re_match_2): Arguments that
5051 specify buffer/string position and length are now ssize_t and
5052 size_t. Return type is regoff_t.
5054 2011-04-16 Ben Key <bkey76@gmail.com>
5056 * nsfont.m: Fixed bugs in ns_get_family and
5057 ns_descriptor_to_entity that were caused by using free to
5058 deallocate memory blocks that were allocated by xmalloc (via
5059 xstrdup). This caused Emacs to crash when compiled with
5060 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5061 --enable-checking=xmallocoverrun). xfree is now used to
5062 deallocate these memory blocks.
5064 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5066 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5068 emacs_write: Accept and return EMACS_INT for sizes.
5069 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5071 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5072 Accept and return EMACS_INT.
5073 (emacs_gnutls_write): Return the number of bytes written on
5075 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5076 (emacs_read, emacs_write): Remove check for negative size, as the
5077 Emacs source code has been audited now.
5078 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5079 (emacs_read, emacs_write): Use it.
5080 * process.c (send_process): Adjust to the new signatures of
5081 emacs_write and emacs_gnutls_write. Do not attempt to store
5082 a byte offset into an 'int'; it might overflow.
5083 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5085 * sound.c: Don't assume sizes fit in 'int'.
5086 (struct sound_device.period_size, alsa_period_size):
5087 Return EMACS_INT, not int.
5088 (struct sound_device.write, vox_write, alsa_write):
5089 Accept EMACS_INT, not int.
5090 (wav_play, au_play): Use EMACS_INT to store sizes and to
5091 record read return values.
5093 2011-04-15 Ben Key <bkey76@gmail.com>
5095 * keyboard.c (Qundefined): Don't declare static since it is used
5097 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5098 static since they are used in nsfont.m.
5100 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5102 * process.c (Qprocessp): Don't declare static.
5103 * lisp.h (Qprocessp): Declare again.
5105 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5107 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5109 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5111 Improve C-level modularity by making more things 'static'.
5113 Don't publish debugger-only interfaces to other modules.
5114 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5115 (verify_bytepos, count_markers): Move decls to the only modules
5117 * region-cache.h (pp_cache): Likewise.
5118 * window.h (check_all_windows): Likewise.
5119 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5121 * sysdep.c (croak): Now static, if
5122 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5123 * syssignal.h (croak): Declare only if not static.
5125 * alloc.c (refill_memory_reserve): Now static if
5126 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5127 * lisp.h (refill_memory_reserve): Declare only if not static.
5129 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5130 Define only if USE_LUCID.
5132 * xrdb.c (x_customization_string, x_rm_string): Now static.
5134 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5135 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5137 * xdisp.c (draw_row_with_mouse_face): Now static.
5138 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5140 * window.h (check_all_windows): Mark externally visible.
5142 * window.c (window_deletion_count): Now static.
5144 * undo.c: Make symbols static if they're not exported.
5145 (last_undo_buffer, last_boundary_position, pending_boundary):
5148 * textprop.c (interval_insert_behind_hooks): Now static.
5149 (interval_insert_in_front_hooks): Likewise.
5151 * term.c: Make symbols static if they're not exported.
5152 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5153 (max_frame_lines, tty_set_terminal_modes):
5154 (tty_reset_terminal_modes, tty_turn_off_highlight):
5155 (get_tty_terminal): Now static.
5156 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5157 * termhooks.h (term_mouse_moveto): Do not declare if
5159 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5160 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5162 * sysdep.c: Make symbols static if they're not exported.
5163 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5165 (sigprocmask_set, full_mask): Remove; unused.
5166 (wait_debugging): Mark as visible.
5167 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5168 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5170 * syntax.c (syntax_temp): Define only if !__GNUC__.
5172 * sound.c (current_sound_device, current_sound): Now static.
5174 * search.c (searchbufs, searchbuf_head): Now static.
5176 * scroll.c (scroll_cost): Remove; unused.
5177 * dispextern.h (scroll_cost): Remove decl.
5179 * region-cache.h (pp_cache): Mark as externally visible.
5181 * process.c: Make symbols static if they're not exported.
5182 (process_tick, update_tick, create_process, chan_process):
5183 (Vprocess_alist, proc_buffered_char, datagram_access):
5184 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5185 (deactivate_process): Mark defn as static, as well as decl.
5186 * lisp.h (create_process): Remove decl.
5187 * process.h (chan_process, Vprocess_alist): Remove decls.
5189 * print.c: Make symbols static if they're not exported.
5190 (print_depth, new_backquote_output, being_printed, print_buffer):
5191 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5192 (print_interval, print_number_index, initial_stderr_stream):
5194 * lisp.h (Fprinc): Remove decl.
5195 (debug_output_compilation_hack): Mark as externally visible.
5197 * sysdep.c (croak): Move decl from here to syssignal.h.
5198 * syssignal.h (croak): Put it here, so the API can be checked when
5199 'croak' is called from dissociate_if_controlling_tty.
5201 * minibuf.c: Make symbols static if they're not exported.
5202 (minibuf_save_list, choose_minibuf_frame): Now static.
5203 * lisp.h (choose_minibuf_frame): Remove decl.
5205 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5207 * lread.c: Make symbols static if they're not exported.
5208 (read_objects, initial_obarray, oblookup_last_bucket_number):
5210 (make_symbol): Remove; unused.
5211 * lisp.h (initial_obarray, make_symbol): Remove decls.
5213 * keyboard.c: Make symbols static if they're not exported.
5214 (single_kboard, recent_keys_index, total_keys, recent_keys):
5215 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5216 (this_single_command_key_start, echoing, last_auto_save):
5217 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5218 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5219 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5220 (Vlispy_mouse_stem, double_click_count):
5222 (force_auto_save_soon): Define only if SIGDANGER.
5223 (ignore_mouse_drag_p): Now static if
5224 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5225 (print_help): Remove; unused.
5226 (stop_character, last_timer_event): Mark as externally visible.
5227 * keyboard.h (ignore_mouse_drag_p): Declare only if
5228 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5229 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5230 * lisp.h (echoing): Remove decl.
5231 (force_auto_save_soon): Declare only if SIGDANGER.
5232 * xdisp.c (redisplay_window): Simplify code, to make it more
5233 obvious that ignore_mouse_drag_p is not accessed if !defined
5234 USE_GTK && !defined HAVE_NS.
5236 * intervals.c: Make symbols static if they're not exported.
5237 (merge_properties_sticky, merge_interval_right, delete_interval):
5239 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5241 * insdel.c: Make symbols static if they're not exported.
5242 However, leave prepare_to_modify_buffer alone. It's never
5243 called from outside this function, but that appears to be a bug.
5244 (combine_after_change_list, combine_after_change_buffer):
5245 (adjust_after_replace, signal_before_change): Now static.
5246 (adjust_after_replace_noundo): Remove; unused.
5247 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5248 (signal_before_change): Remove decls.
5250 * indent.c (val_compute_motion, val_vmotion): Now static.
5252 * image.c: Make symbols static if they're not exported.
5253 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5255 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5256 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5258 * fringe.c (standard_bitmaps): Now static.
5259 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5261 * frame.c: Make symbols static if they're not exported.
5262 (x_report_frame_params, make_terminal_frame): Now static.
5263 (get_frame_param): Now static, unless HAVE_NS.
5264 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5265 (x_get_resource_string): Remove; not used.
5266 * frame.h (make_terminal_frame, x_report_frame_params):
5267 (x_get_resource_string); Remove decls.
5268 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5269 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5271 * font.c, fontset.c: Make symbols static if they're not exported.
5272 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5273 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5274 * font.c (font_close_object): Now static.
5275 * font.h (font_close_object): Remove.
5276 * fontset.c (FONTSET_OBJLIST): Remove.
5277 (free_realized_fontset) #if-0 the body, which does nothing.
5278 (face_suitable_for_char_p): #if-0, as it's never called.
5279 * fontset.h (face_suitable_for_char_p): Remove decl.
5280 * xfaces.c (face_at_string_position):
5281 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5282 since 0 is always ASCII.
5284 * fns.c (weak_hash_tables): Now static.
5286 * fileio.c: Make symbols static if they're not exported.
5287 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5288 (Vwrite_region_annotation_buffers): Now static.
5290 * eval.c: Make symbols static if they're not exported.
5291 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5292 * lisp.h (backtrace_list): Remove decl.
5294 * emacs.c: Make symbols static if they're not exported.
5295 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5296 (fatal_error_code, fatal_error_signal_hook, standard_args):
5298 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5299 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5300 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5301 * lisp.h (fatal_error_signal_hook): Remove decl.
5302 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5304 * editfns.c: Move a (normally-unused) function to its only use.
5305 * editfns.c, lisp.h (get_operating_system_release): Remove.
5306 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5307 worth the hassle of breaking this out.
5309 * xterm.c: Make symbols static if they're not exported.
5310 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5311 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5312 (x_destroy_window, x_delete_display):
5314 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5315 (x_mouse_leave): Remove; unused.
5316 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5317 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5318 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5320 (x_mouse_leave): Declare only if WINDOWSNT.
5321 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5322 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5325 * ftxfont.c: Make symbols static if they're not exported.
5326 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5328 * font.h (ftxfont_driver): Likewise.
5330 * xfns.c: Make symbols static if they're not exported.
5331 (x_last_font_name, x_display_info_for_name):
5332 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5333 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5334 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5335 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5336 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5337 (last_show_tip_args): Now static.
5338 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5339 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5340 (x_screen_planes): Remove; unused.
5341 * dispextern.h (x_screen_planes): Remove decl.
5343 * dispnew.c: Make symbols static if they're not exported.
5344 * dispextern.h (redraw_garbaged_frames, scrolling):
5345 (increment_row_positions): Remove.
5346 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5347 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5349 (redraw_garbaged_frames): Remove; unused.
5351 * xfaces.c: Make symbols static if they're not exported.
5352 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5354 * xterm.h (defined_color): Remove decls.
5355 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5356 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5357 (menu_face_changed_default, defined_color, free_realized_face):
5358 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5359 (ascii_face_of_lisp_face): Remove; unused.
5361 * xdisp.c: Make symbols static if they're not exported.
5362 * dispextern.h (scratch_glyph_row, window_box_edges):
5363 (glyph_to_pixel_coords, set_cursor_from_row):
5364 (get_next_display_element, set_iterator_to_next):
5365 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5366 (show_mouse_face): Remove decls
5367 * frame.h (message_buf_print): Likewise.
5368 * lisp.h (pop_message, set_message, check_point_in_composition):
5370 * xterm.h (set_vertical_scroll_bar): Likewise.
5371 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5372 (message_buf_print, scratch_glyph_row, displayed_buffer):
5373 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5374 (get_next_display_element, show_mouse_face, window_box_edges):
5375 (frame_to_window_pixel_xy, check_point_in_composition):
5376 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5377 (glyph_to_pixel_coords): Remove; unused.
5379 * dired.c (file_name_completion): Now static.
5381 * dbusbind.c (xd_in_read_queued_messages): Now static.
5383 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5384 * data.c (circular_list_error): Remove.
5386 * commands.h (last_point_position, last_point_position_buffer):
5387 (last_point_position_window): Remove decls.
5388 * keyboard.c: Make these variables static.
5390 * coding.h (coding, code_convert_region, encode_coding_gap):
5392 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5393 (iso_code_class, detect_coding, code_convert_region): Now static.
5394 (encode_coding_gap): Remove; unused.
5396 * chartab.c (chartab_chars, chartab_bits): Now static.
5398 * charset.h (charset_iso_8859_1): Remove decl.
5399 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5402 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5403 * ccl.c (Vccl_program_table): Now static.
5404 (check_ccl_update): Remove; unused.
5406 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5407 * category.h: ... from here.
5408 * category.c (check_category_table, set_category_set): Now static.
5410 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5411 * lisp.h: Remove these decls.
5413 * buffer.c (buffer_count): Remove unused var.
5415 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5416 so that it's not optimized away.
5417 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5418 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5419 exported only to the debugger.
5421 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5422 * atimer.h (run_all_atimers): Remove; not exported.
5424 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5425 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5426 was inaccessible from Lisp.
5427 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5428 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5430 alloc.c: Import and export fewer symbols, and remove unused items.
5431 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5433 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5434 it's not optimized away by whole-program optimization.
5435 (message_enable_multibyte, free_misc): Remove.
5436 (catchlist, handlerlist, mark_backtrace):
5437 Declare only if BYTE_MARK_STACK.
5438 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5439 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5440 (message_enable_multibyte): Remove decl.
5441 (free_misc, interval_free_list, float_block, float_block_index):
5442 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5443 (cons_free_list, last_marked_index):
5445 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5446 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5447 (mark_backtrace): Define only if BYTE_MARK_STACK.
5448 * xdisp.c (message_enable_multibyte): Now static.
5450 Declare Lisp_Object Q* variables to be 'static' if not exported.
5451 This makes it easier for human readers (and static analyzers)
5452 to see whether these variables are used from other modules.
5453 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5454 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5455 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5456 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5457 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5458 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5459 * xmenu.c, xselect.c:
5460 Declare Q* vars static if they are not used in other modules.
5461 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5462 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5463 Remove decls of unexported vars.
5464 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5466 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5468 Make Emacs functions such as Fatom 'static' by default.
5469 This makes it easier for human readers (and static analyzers)
5470 to see whether these functions can be called from other modules.
5471 DEFUN now defines a static function. To make the function external
5472 so that it can be used in other C modules, use the new macro DEFUE.
5473 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5474 (Finit_image_library):
5475 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5476 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5477 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5478 Remove decls, since these functions are now static.
5479 (Funintern, Fget_internal_run_time): New decls, since these functions
5480 were already external.
5482 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5483 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5484 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5485 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5486 * keyboard.c, keymap.c, lread.c:
5487 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5488 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5489 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5490 Mark functions with DEFUE instead of DEFUN,
5491 if they are used in other modules.
5492 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5493 decls for now-static functions.
5494 * buffer.h (Fdelete_overlay): Remove decl.
5495 * callproc.c (Fgetenv_internal): Mark as internal.
5496 * composite.c (Fremove_list_of_text_properties): Remove decl.
5497 (Fcomposition_get_gstring): New forward static decl.
5498 * composite.h (Fcomposite_get_gstring): Remove decl.
5499 * dired.c (Ffile_attributes): New forward static decl.
5500 * doc.c (Fdocumntation_property): New forward static decl.
5501 * eval.c (Ffetch_bytecode): New forward static decl.
5502 (Funintern): Remove extern decl; now in .h file where it belongs.
5503 * fileio.c (Fmake_symbolic_link): New forward static decl.
5504 * image.c (Finit_image_library): New forward static decl.
5505 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5506 * intervals.h (Fprevious_property_change):
5507 (Fremove_list_of_text_properties): Remove decls.
5508 * keyboard.c (Fthis_command_keys): Remove decl.
5509 (Fcommand_execute): New forward static decl.
5510 * keymap.c (Flookup_key): New forward static decl.
5511 (Fcopy_keymap): Now static.
5512 * keymap.h (Flookup_key): Remove decl.
5513 * process.c (Fget_process): New forward static decl.
5514 (Fprocess_datagram_address): Mark as internal.
5515 * syntax.c (Fsyntax_table_p): New forward static decl.
5516 (skip_chars): Remove duplicate decl.
5517 * textprop.c (Fprevious_property_change): New forward static decl.
5518 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5520 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5521 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5523 * editfns.c (Fformat): Remove unreachable code.
5525 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5527 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5530 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5532 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5533 when at ZV. (Bug#8487)
5535 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5537 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5539 * keyboard.c (parse_tool_bar_item): Likewise.
5540 * sound.c (sound_cleanup, alsa_close): Likewise.
5541 * termcap.c (tgetent): Likewise.
5542 * xfns.c (x_default_font_parameter): Likewise.
5543 * xsettings.c (read_and_apply_settings): Likewise.
5545 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5546 (overrun_check_free): Protoize.
5548 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5550 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5551 since callers should never pass a negative size.
5552 Change the signature to match that of plain 'read' and 'write'; see
5553 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5554 * lisp.h: Update prototypes of emacs_write and emacs_read.
5556 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5558 * xdisp.c (redisplay_window): Don't try to determine the character
5559 position of the scroll margin if the window start point w->startp
5560 is outside the buffer's accessible region. (Bug#8468)
5562 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5564 Fix write-region and its subroutines for buffers > 2GB.
5565 * fileio.c (a_write, e_write): Modify declaration of arguments and
5566 local variables to support buffers larger than 2GB.
5567 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5569 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5570 argument, local variables, and return value.
5572 * lisp.h: Update prototypes of emacs_write and emacs_read.
5574 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5576 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5578 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5580 Fix more problems found by GCC 4.6.0's static checks.
5582 * xdisp.c (vmessage): Use a better test for character truncation.
5584 * charset.c (load_charset_map): <, not <=, for optimization,
5585 and to avoid potential problems with integer overflow.
5586 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5587 * casetab.c (set_identity, shuffle): Likewise.
5588 * editfns.c (Fformat): Likewise.
5589 * syntax.c (skip_chars): Likewise.
5591 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5592 This also lets GCC 4.6.0 generate slightly better loop code.
5594 * callint.c (Fcall_interactively): <, not <=, for optimization.
5595 (Fcall_interactively): Count the number of arguments produced,
5596 not the number of arguments given. This is simpler and lets GCC
5597 4.6.0 generate slightly better code.
5599 * ftfont.c: Distingish more carefully between FcChar8 and char.
5600 The previous code passed unsigned char * to a functions like
5601 strlen and xstrcasecmp that expect char *, which does not
5602 conform to the C standard.
5603 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5604 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5605 char * when the C standard requires it.
5607 * keyboard.c (read_char): Remove unused var.
5609 * eval.c: Port to Windows vsnprintf (Bug#8435).
5611 (SIZE_MAX): Define if the headers do not.
5612 (verror): Do not give up if vsnprintf returns a negative count.
5613 Instead, grow the buffer. This ports to Windows vsnprintf, which
5614 does not conform to C99. Problem reported by Eli Zaretskii.
5615 Also, simplify the allocation scheme, by avoiding the need for
5616 calling realloc, and removing the ALLOCATED variable.
5618 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5620 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5621 But keep the doprint source code for now, as we might revamp it
5622 and use it again (Bug#8435).
5623 * lisp.h (doprnt): Remove.
5624 * Makefile.in (base_obj): Remove doprnt.o.
5625 * deps.mk (doprnt.o): Remove.
5627 error: Print 32- and 64-bit integers portably (Bug#8435).
5628 Without this change, on typical 64-bit hosts error ("...%d...", N)
5629 was used to print both 32- and 64-bit integers N, which relied on
5631 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5633 * lisp.h (error, verror): Mark as printf-like functions.
5634 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5635 Report overflow in size calculations when allocating printf buffer.
5636 Do not truncate output string at its first null byte.
5637 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5638 Truncate the output at a character boundary, since vsnprintf does not
5640 * charset.c (check_iso_charset_parameter): Convert internal
5641 character to string before calling 'error', since %c now has the
5643 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5644 overflow when computing char to be passed to 'error'. Do not
5645 pass Lisp_Object to 'error'; pass the integer instead.
5646 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5647 formatted with plain %d.
5649 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5651 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5653 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5655 * xterm.c (x_catch_errors): Remove duplicate declaration.
5657 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5659 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5661 2011-04-10 Jim Meyering <meyering@redhat.com>
5663 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5664 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5665 return ssize_t not "int", and use size_t as the buffer length.
5666 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5667 * gnutls.h: Update declarations.
5668 * process.c (read_process_output): Use ssize_t, to match.
5669 (send_process): Likewise.
5671 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5673 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5675 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5677 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5678 Use unsigned char, to match FcChar8 type definition.
5680 * xterm.c (handle_one_xevent):
5681 * xmenu.c (create_and_show_popup_menu):
5682 * xselect.c (x_decline_selection_request)
5683 (x_reply_selection_request): Avoid type-punned deref of X events.
5685 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5687 Fix some uses of `int' instead of EMACS_INT.
5688 * search.c (string_match_1, fast_string_match)
5689 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5690 (scan_buffer, find_next_newline_no_quit)
5691 (find_before_next_newline, search_command, Freplace_match)
5692 (Fmatch_data): Make some `int' variables be EMACS_INT.
5694 * xdisp.c (display_count_lines): 3rd argument and return value now
5695 EMACS_INT. All callers changed.
5696 (pint2hrstr): Last argument is now EMACS_INT.
5698 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5699 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5700 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5701 (decode_coding_utf_16, decode_coding_emacs_mule)
5702 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5703 (decode_coding_ccl, decode_coding_charset)
5704 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5705 (decode_coding_iso_2022, decode_coding_emacs_mule)
5706 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5707 <char_offset, last_offset>: Declare EMACS_INT.
5708 (encode_coding_utf_8, encode_coding_utf_16)
5709 (encode_coding_emacs_mule, encode_invocation_designation)
5710 (encode_designation_at_bol, encode_coding_iso_2022)
5711 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5712 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5714 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5715 (encode_invocation_designation): Last argument P_NCHARS is now
5717 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5718 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5720 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5723 * ccl.c (Fccl_execute_on_string): Declare some variables
5726 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5728 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5730 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5732 * process.c (Fformat_network_address): Doc fix.
5734 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5736 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5738 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5740 * keyboard.c (read_char): Call Lisp function help-form-show,
5741 instead of using internal_with_output_to_temp_buffer.
5742 (Qhelp_form_show): New var.
5743 (syms_of_keyboard): Use DEFSYM macro.
5745 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5747 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5749 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5751 * process.c (Flist_processes): Remove to Lisp.
5752 (list_processes_1): Delete.
5754 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5756 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5758 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5760 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5762 Fix more problems found by GCC 4.6.0's static checks.
5764 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5766 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5768 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5770 * xdisp.c (vmessage): Mark as a printf-like function.
5772 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5774 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5776 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5777 printf-like functions.
5778 (tiff_load): Add casts to remove these marks before passing them
5779 to system-supplied API.
5781 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5783 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5784 This avoids several warnings with gcc -Wstrict-overflow.
5785 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5786 directly, rather than having caller test rule sign. This avoids
5787 some unnecessary tests.
5788 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5789 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5790 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5792 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5793 (xfont_open): Avoid unnecessary tests.
5795 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5797 * composite.h, composite.c (composition_gstring_put_cache):
5798 Use EMACS_INT, not int, for length.
5800 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5801 breaking out part of COMPOSITION_DECODE_RULE.
5802 (COMPOSITION_DECODE_RULE): Use it.
5803 * composite.c (get_composition_id): Remove unused local vars,
5804 by using the new macro.
5806 * textprop.c (set_text_properties_1): Change while to do-while,
5807 since the condition is always true at first.
5809 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5810 (interval_deletion_adjustment): Return unsigned value.
5813 * process.c (list_processes_1, create_pty, read_process_output):
5814 (exec_sentinel): Remove vars that were set but not used.
5815 (create_pty): Remove unnecessary "volatile"s.
5816 (Fnetwork_interface_info): Avoid possibility of int overflow.
5817 (read_process_output): Do adaptive read buffering even if carryover.
5818 (read_process_output): Simplify nbytes computation if buffered.
5820 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5822 * syntax.c (scan_words): Remove var that was set but not used.
5823 (update_syntax_table): Use unsigned instead of int.
5825 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5826 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5827 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5829 * print.c (print_error_message): Avoid int overflow.
5831 * font.c (font_list_entities): Redo for clarity,
5832 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5834 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5835 (font_score): Avoid potential overflow in diff calculation.
5837 * fns.c (substring_both): Remove var that is set but not used.
5838 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5840 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5842 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5843 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5844 can always succeed if overflow has undefined behavior.
5846 * search.c (boyer_moore, wordify): Remove vars set but not used.
5847 (wordify): Omit three unnecessary tests.
5849 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5850 All callers changed. This avoids the need for an unused var.
5852 * casefiddle.c (casify_region): Remove var that is set but not used.
5854 * dired.c (file_name_completion): Remove var that is set but not used.
5856 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5858 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5859 (Finsert_file_contents): Remove unnecessary code checking fd.
5861 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5862 Check for integer overflow on size calculations.
5864 * buffer.c (Fprevious_overlay_change): Remove var that is set
5867 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5868 Remove vars that are set but not used.
5869 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5870 (timer_check_2): Mark vars as initialized.
5872 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5874 * image.c (lookup_image): Remove var that is set but not used.
5875 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5877 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5878 that are set but not used.
5880 * xfns.c (make_invisible_cursor): Don't return garbage
5881 if XCreateBitmapFromData fails (Bug#8410).
5883 * xselect.c (x_get_local_selection, x_handle_property_notify):
5884 Remove vars that are set but not used.
5886 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5887 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5889 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5890 Remove var that is set but not used.
5891 (scroll_bar_windows_size): Now size_t, not int.
5892 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5895 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5896 (map_tty_color) [!defined MSDOS]: Likewise.
5898 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5900 * coding.c: Remove vars that are set but not used.
5901 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5902 All callers changed.
5903 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5904 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5905 (decode_coding_charset): Remove vars that are set but not used.
5907 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5908 that is set but not used.
5910 * print.c (print_object): Remove var that is set but not used.
5912 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5913 The gnulib version avoids calling malloc in the usual case,
5914 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5915 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5916 * filelock.c (current_lock_owner): Likewise.
5917 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5918 * sysdep.c: Include allocator.h, careadlinkat.h.
5919 (emacs_no_realloc_allocator): New static constant.
5920 (emacs_readlink): New function.
5921 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5922 ../lib/careadlinkat.h.
5924 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5926 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5927 first non-nil return value).
5929 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5931 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5932 if not defined (Bug#8403).
5934 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5936 * xdisp.c (display_count_lines): Remove parameter `start',
5937 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5938 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5939 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5940 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5941 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5942 and thereabouts. All callers changed.
5943 (get_per_char_metric): Remove parameter `f', unused since
5944 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5946 2011-04-02 Jim Meyering <meyering@redhat.com>
5948 do not dereference NULL upon failed strdup
5949 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5950 (ns_get_family): Likewise.
5952 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5954 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5956 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5958 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5961 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5963 Add lexical binding.
5965 * window.c (Ftemp_output_buffer_show): New fun.
5966 (Fsave_window_excursion):
5967 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5969 * lread.c (lisp_file_lexically_bound_p): New function.
5970 (Fload): Bind Qlexical_binding.
5971 (readevalloop): Remove `evalfun' arg.
5972 Bind Qinternal_interpreter_environment.
5973 (Feval_buffer): Bind Qlexical_binding.
5974 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5976 (syms_of_lread): Declare `lexical-binding'.
5978 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5980 * keyboard.c (eval_dyn): New fun.
5981 (menu_item_eval_property): Use it.
5983 * image.c (parse_image_spec): Use Ffunctionp.
5985 * fns.c (concat, mapcar1): Accept byte-code-functions.
5987 * eval.c (Fsetq): Handle lexical vars.
5988 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5989 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5990 (FletX, Flet): Obey lexical binding.
5991 (Fcommandp): Handle closures.
5992 (Feval): New `lexical' arg.
5993 (eval_sub): New function extracted from Feval. Use it almost
5994 everywhere where Feval was used. Look up vars in lexical env.
5996 (Ffunctionp): Move from subr.el.
5997 (Ffuncall): Handle closures.
5998 (apply_lambda): Remove `eval_flags'.
5999 (funcall_lambda): Handle closures and new byte-code-functions.
6000 (Fspecial_variable_p): New function.
6001 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6002 but without exporting it to Lisp.
6004 * doc.c (Fdocumentation, store_function_docstring):
6005 * data.c (Finteractive_form): Handle closures.
6007 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6010 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6012 (exec_byte_code): New function extracted from Fbyte_code to handle new
6013 calling convention for byte-code-functions. Add new byte-codes.
6015 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6017 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6019 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6021 * xdisp.c (redisplay_internal): Fix prototype.
6023 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6025 * xdisp.c (SCROLL_LIMIT): New macro.
6026 (try_scrolling): Use it when setting scroll_limit.
6027 Limit scrolling to 100 screen lines.
6028 (redisplay_window): Even when falling back on "recentering",
6029 position point in the window according to scroll-conservatively,
6030 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6032 (try_scrolling): When point is above the window, allow searching
6033 as far as scroll_max, or one screenful, to compute vertical
6034 distance from PT to the scroll margin position. This prevents
6035 try_scrolling from unnecessarily failing when
6036 scroll-conservatively is set to a value slightly larger than the
6037 window height. Clean up the case of PT below the margin at bottom
6038 of window: scroll_max can no longer be INT_MAX. When aggressive
6039 scrolling is in use, don't let point enter the opposite scroll
6040 margin as result of the scroll.
6041 (syms_of_xdisp) <scroll-conservatively>: Document the
6042 threshold of 100 lines for never-recentering scrolling.
6044 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6046 * dispextern.h (move_it_by_lines):
6047 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6048 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6049 (message_log_check_duplicate): Remove parameters `prev_bol' and
6050 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6051 (redisplay_internal): Remove parameter `preserve_echo_area',
6052 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6054 * indent.c (Fvertical_motion):
6055 * window.c (window_scroll_pixel_based, Frecenter):
6056 Don't pass `need_y_p' to `move_it_by_lines'.
6058 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6060 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6061 steal a few bits to be more compact.
6062 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6063 Remove unneeded casts.
6065 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6067 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6069 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6070 binding" message (bug#7967).
6072 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6074 Fix more problems found by GCC 4.6.0's static checks.
6076 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6077 Remove unused local var.
6079 * editfns.c (Fmessage_box): Remove unused local var.
6081 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6082 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6083 Omit unused local vars.
6084 * window.c (shrink_windows): Omit unused local var.
6085 * menu.c (digest_single_submenu): Omit unused local var.
6086 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6087 Omit unused local var.
6089 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6090 Don't assume string length fits in int.
6091 (keyremap_step, read_key_sequence): Use size_t for sizes.
6092 (read_key_sequence): Don't check last_real_key_start redundantly.
6094 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6095 instead of alloca (Bug#8344).
6097 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6098 (Fbacktrace_frame): Don't assume nframes fits in int.
6100 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6102 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6105 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6107 * cm.c (calccost): Turn while-do into do-while, for clarity.
6109 * keyboard.c (syms_of_keyboard): Use the same style as later
6110 in this function when indexing through an array. This also
6111 works around GCC bug 48267.
6113 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6115 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6117 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6118 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6120 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6121 This avoids undefined behavior on integer overflow, and is a bit
6122 more convenient anyway since it is compared to a size_t variable.
6124 Variadic C functions now count arguments with size_t, not int.
6125 This avoids an unnecessary limitation on 64-bit machines, which
6126 caused (substring ...) to crash on large vectors (Bug#8344).
6127 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6128 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6129 All variadic functions and their callers changed accordingly.
6130 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6131 * data.c (arith_driver, float_arith_driver): Likewise.
6132 * editfns.c (general_insert_function): Likewise.
6133 * eval.c (struct backtrace.nargs, interactive_p)
6134 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6135 (funcall_lambda, mark_backtrace): Likewise.
6136 * fns.c (concat): Likewise.
6137 * frame.c (x_set_frame_parameters): Likewise.
6138 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6139 0 if not found, not -1. All callers changed.
6141 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6142 (stack_copy_size): Now size_t, not int.
6143 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6145 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6147 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6148 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6149 All callers changed.
6151 * lisp.h (multibyte_char_to_unibyte):
6152 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6153 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6154 * character.h (CHAR_TO_BYTE8):
6155 * cmds.c (internal_self_insert):
6156 * editfns.c (general_insert_function):
6157 * keymap.c (push_key_description):
6158 * search.c (Freplace_match):
6159 * xdisp.c (message_dolog, set_message_1): All callers changed.
6161 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6163 * keyboard.c (safe_run_hook_funcall): New function.
6164 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6165 don't set the hook to nil, but remove the offending function instead.
6166 (Qcommand_hook_internal): Remove, unused.
6167 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6168 Vcommand_hook_internal.
6170 * eval.c (enum run_hooks_condition): Remove.
6171 (funcall_nil, funcall_not): New functions.
6172 (run_hook_with_args): Call each function through a `funcall' argument.
6173 Remove `cond' argument, now redundant.
6174 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6175 (Frun_hook_with_args_until_failure): Adjust accordingly.
6176 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6178 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6180 * dispextern.h (string_buffer_position): Remove declaration.
6182 * print.c (strout): Remove parameter `multibyte', unused since
6183 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6185 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6186 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6187 All callers changed.
6189 * w32.c (_wsa_errlist): Use braces for struct initializers.
6191 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6192 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6193 All callers changed.
6194 (string_buffer_position): Likewise. Also, make static (it's never
6195 used outside xdisp.c).
6196 (cursor_row_p): Remove parameter `w', unused since
6197 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6198 (decode_mode_spec): Remove parameter `precision', introduced during
6199 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6200 All callers changed.
6202 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6204 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6206 2011-03-27 Anders Lindgren <andlind@gmail.com>
6208 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6209 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6210 (ns_update_auto_hide_menu_bar): New functions.
6211 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6212 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6213 ns_constrain_all_frames.
6214 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6215 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6217 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6219 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6221 2011-03-27 Glenn Morris <rgm@gnu.org>
6223 * syssignal.h: Replace RETSIGTYPE with void.
6224 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6225 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6226 Replace SIGTYPE with void everywhere.
6227 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6228 * s/template.h (SIGTYPE): Remove commented out definition.
6230 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6232 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6233 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6235 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6237 * w32.c (read_unc_volume): Use parameter `henum', instead of
6238 global variable `wget_enum_handle'.
6240 * keymap.c (describe_vector): Remove parameters `indices' and
6241 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6242 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6244 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6246 * keyboard.c (timer_check): Remove parameter `do_it_now',
6247 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6248 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6249 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6251 * keyboard.c (read_char):
6252 * w32menu.c (w32_menu_display_help):
6253 * xmenu.c (show_help_event, menu_help_callback):
6254 Adjust calls to `show_help_echo'.
6256 * gtkutil.c (xg_maybe_add_timer):
6257 * keyboard.c (readable_events):
6258 * process.c (wait_reading_process_output):
6259 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6261 * insdel.c (adjust_markers_gap_motion):
6262 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6263 (gap_left, gap_right): Don't call it.
6265 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6267 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6268 incurred during fontification.
6270 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6272 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6273 (DEFVAR_PER_BUFFER): Don't pass it.
6275 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6276 (scrolling_window): Don't pass it.
6278 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6280 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6282 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6284 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6285 of variables specific to SELinux and computation of `encoded_absname'.
6287 * image.c (XPutPixel): Remove unused variable `height'.
6289 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6291 * unexw32.c (get_section_info): Remove unused variable `section'.
6293 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6294 (system_process_attributes): Remove unused variable `sess'.
6295 (sys_read): Remove unused variable `err'.
6297 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6298 (w32_wnd_proc): Remove unused variable `isdead'.
6299 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6300 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6301 (x_create_tip_frame): Remove unused variable `tem'.
6303 * w32inevt.c (w32_console_read_socket):
6304 Remove unused variable `no_events'.
6306 * w32term.c (x_draw_composite_glyph_string_foreground):
6307 Remove unused variable `width'.
6309 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6311 * w32term.c (x_set_glyph_string_clipping):
6312 Don't pass uninitialized region to CombineRgn.
6314 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6316 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6317 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6318 (Fx_close_connection): Remove unused variable `i'.
6320 * w32font.c (w32font_draw): Return number of glyphs.
6321 (w32font_open_internal): Remove unused variable `i'.
6322 (w32font_driver): Add missing initializer.
6324 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6325 (fill_in_menu): Remove unused variable `items_added'.
6327 * w32term.c (last_mouse_press_frame): Remove static global variable.
6328 (w32_clip_to_row): Remove unused variable `f'.
6329 (x_delete_terminal): Remove unused variable `i'.
6331 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6332 (NOTHING): Remove unused static global variable.
6333 (uniscribe_check_otf): Remove unused variable `table'.
6334 (uniscribe_font_driver): Add missing initializers.
6336 2011-03-23 Julien Danjou <julien@danjou.info>
6338 * term.c (Fsuspend_tty, Fresume_tty):
6339 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6340 * window.c (temp_output_buffer_show):
6341 * insdel.c (signal_before_change):
6342 * frame.c (Fhandle_switch_frame):
6343 * fileio.c (Fdo_auto_save):
6344 * emacs.c (Fkill_emacs):
6345 * editfns.c (save_excursion_restore):
6346 * cmds.c (internal_self_insert):
6347 * callint.c (Fcall_interactively):
6348 * buffer.c (Fkill_all_local_variables):
6349 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6351 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6352 unconditionnaly since it does the check itself.
6354 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6356 Fix more problems found by GCC 4.5.2's static checks.
6358 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6359 the first time through the loop, since we know p0 < p1 then.
6360 This also avoids a gcc -Wstrict-overflow warning.
6362 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6363 leading to a memory leak, possible in functions like
6364 load_charset_map_from_file that can allocate an unbounded number
6365 of objects (Bug#8318).
6367 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6368 that could (at least in theory) be that large.
6370 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6371 This is less likely to overflow, and avoids undefined behavior if
6372 overflow does occur. All callers changed. Use strtoul to scan
6373 for the unsigned long integer.
6374 (pint2hrstr): Simplify and tune code slightly.
6375 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6377 * scroll.c (do_scrolling): Work around GCC bug 48228.
6378 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6380 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6381 This also avoids a warning with gcc -Wstrict-overflow.
6382 (validate_x_resource_name): Simplify count usage.
6383 This also avoids a warning with gcc -Wstrict-overflow.
6385 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6388 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6390 * process.c (Fmake_network_process): Use socklen_t, not int,
6391 where POSIX says socklen_t is required in portable programs.
6392 This fixes a porting bug on hosts like 64-bit HP-UX, where
6393 socklen_t is wider than int (Bug#8277).
6394 (Fmake_network_process, server_accept_connection):
6395 (wait_reading_process_output, read_process_output):
6398 * process.c: Rename or move locals to avoid shadowing.
6399 (list_processes_1, Fmake_network_process):
6400 (read_process_output_error_handler, exec_sentinel_error_handler):
6401 Rename or move locals.
6402 (Fmake_network_process): Define label "retry_connect" only if needed.
6403 (Fnetwork_interface_info): Fix pointer signedness.
6404 (process_send_signal): Add cast to avoid pointer signedness problem.
6405 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6406 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6408 Make tparam.h and terminfo.c consistent.
6409 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6410 Include tparam.h instead, since it declares them.
6411 * cm.h (PC): Remove extern decl; tparam.h now does this.
6412 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6413 * terminfo.c: Include tparam.h, to check interfaces.
6414 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6415 (tparam): Adjust signature to match interface in tparam.h;
6416 this removes some undefined behavior. Check that outstring and len
6417 are zero, which they always are with Emacs.
6418 * tparam.h (PC, BC, UP): New extern decls.
6420 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6421 (xftfont_open): Rename locals to avoid shadowing.
6423 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6424 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6425 (OTF_TAG_SYM): Omit macro if not needed.
6426 (ftfont_list): Remove unused local.
6427 (get_adstyle_property, ftfont_pattern_entity):
6428 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6429 Rename locals to avoid shadowing.
6431 * xfont.c (xfont_list_family): Mark var as initialized.
6433 * xml.c (make_dom): Now static.
6435 * composite.c (composition_compute_stop_pos): Rename local to
6437 (composition_reseat_it): Remove unused locals.
6438 (find_automatic_composition, composition_adjust_point): Likewise.
6439 (composition_update_it): Mark var as initialized.
6440 (find_automatic_composition): Mark vars as initialized,
6441 with a FIXME (Bug#8290).
6443 character.h: Rename locals to avoid shadowing.
6444 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6445 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6446 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6447 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6450 * textprop.c (property_change_between_p): Remove; unused.
6452 * intervals.c (interval_start_pos): Now static.
6454 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6456 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6457 Rename locals to avoid shadowing.
6459 * sound.c (wav_play, au_play, Fplay_sound_internal):
6460 Fix pointer signedness.
6461 (alsa_choose_format): Remove unused local var.
6462 (wav_play): Initialize a variable to 0, to prevent undefined
6463 behavior (Bug#8278).
6465 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6467 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6469 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6470 clobbering (Bug#8298).
6471 * sysdep.c (sys_subshell): Likewise.
6472 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6474 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6475 This should get cleaned up, so that child_setup has the
6476 same signature on all platforms.
6478 * callproc.c (call_process_cleanup): Now static.
6479 (relocate_fd): Rename locals to avoid shadowing.
6481 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6483 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6484 not to be necessary, and produces flickering.
6486 2011-03-20 Glenn Morris <rgm@gnu.org>
6488 * config.in: Remove file.
6490 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6492 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6493 are now in src/globals.h.
6494 (syms_of_minibuf): Remove spurious & from previous change.
6496 2011-03-20 Leo <sdl.web@gmail.com>
6498 * minibuf.c (completing-read-function): New variable.
6499 (completing-read-default): Rename from completing-read.
6500 (completing-read): Call completing-read-function.
6502 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6504 * xfaces.c (Fx_load_color_file):
6505 Read color file from absolute filename (bug#8250).
6507 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6509 * makefile.w32-in: Update dependencies.
6511 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6513 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6515 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6517 Fix more problems found by GCC 4.5.2's static checks.
6519 * process.c (make_serial_process_unwind, send_process_trap):
6520 (sigchld_handler): Now static.
6522 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6523 That way, the code declares only the vars that it needs.
6524 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6525 * s/cygwin.h (PTY_ITERATION): Likewise.
6526 * s/darwin.h (PTY_ITERATION): Likewise.
6527 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6529 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6530 * process.c (allocate_pty): Don't declare stb unless it's needed.
6532 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6533 (CONSTANTLIM): Remove; unused.
6534 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6535 Define only if needed.
6537 * unexelf.c (unexec): Name an expression,
6538 to avoid gcc -Wbad-function-cast warning.
6539 Use a different way to cause a compilation error if anyone uses
6540 n rather than nn, a way that does not involve shadowing.
6541 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6543 * deps.mk (unexalpha.o): Remove; unused.
6545 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6546 * unexec.h: New file.
6547 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6548 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6550 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6551 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6552 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6553 Change as necessary to match prototype in unexec.h.
6555 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6557 (back_comment, skip_chars): Mark vars as initialized.
6559 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6560 Rename locals to avoid shadowing.
6562 * lread.c (read1): Rewrite so as not to use empty "else".
6563 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6565 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6567 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6568 warning when compiling print.c.
6570 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6571 instead of using an uninitialized var.
6572 (font_sort_entities): Mark var as initialized.
6574 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6576 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6577 pointers to constants.
6578 (font_parse_fcname): Remove unused vars.
6579 (font_delete_unmatched): Now static.
6580 (font_get_spec): Remove; unused.
6581 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6582 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6583 Rename or move locals to avoid shadowing.
6585 * fns.c (require_nesting_list, require_unwind): Now static.
6586 (Ffillarray): Rename locals to avoid shadowing.
6588 * floatfns.c (domain_error2): Define only if needed.
6589 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6591 * alloc.c (mark_backtrace): Move decl from here ...
6592 * lisp.h: ... to here, so that it can be checked.
6594 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6595 (Fdefvar): Rewrite so as not to use empty "else".
6596 (lisp_indirect_variable): Name an expression,
6597 to avoid gcc -Wbad-function-cast warning.
6598 (Fdefvar): Rename locals to avoid shadowing.
6600 * callint.c (quotify_arg, quotify_args): Now static.
6601 (Fcall_interactively): Rename locals to avoid shadowing.
6602 Use const pointer when appropriate.
6604 * lisp.h (get_system_name, get_operating_system_release):
6605 Move decls here, to check interfaces.
6606 * process.c (get_operating_system_release): Move decl to lisp.h.
6607 * xrdb.c (get_system_name): Likewise.
6608 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6609 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6610 some of which prompt warnings from gcc -Wbad-function-cast.
6611 (Fformat_time_string, Fencode_time, Finsert_char):
6612 (Ftranslate_region_internal, Fformat):
6613 Rename or remove local vars to avoid shadowing.
6614 (Ftranslate_region_internal): Mark var as initialized.
6616 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6619 * lisp.h (eassert): Check that the argument compiles, even if
6620 ENABLE_CHECKING is not defined.
6622 * data.c (Findirect_variable): Name an expression, to avoid
6623 gcc -Wbad-function-cast warning.
6624 (default_value, arithcompare, arith_driver, arith_error): Now static.
6625 (store_symval_forwarding): Rename local to avoid shadowing.
6626 (Fmake_variable_buffer_local, Fmake_local_variable):
6627 Mark variables as initialized.
6628 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6630 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6631 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6632 Rename locals to avoid shadowing.
6633 (mark_stack): Move local variables into the #ifdef region where
6635 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6636 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6638 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6639 (GC_STRING_CHARS): Remove; not used.
6640 (Fmemory_limit): Cast sbrk's returned value to char *.
6642 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6643 avoids undefined behavior in theory.
6645 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6647 Use functions, not macros, for up- and down-casing (Bug#8254).
6648 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6649 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6650 to use the following functions instead of these macros.
6651 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6652 EMACS_INT, since callers assume the returned value fits in int.
6653 (upcase1): Likewise, for UPCASE_TABLE.
6654 (uppercasep, lowercasep, upcase): New static inline functions.
6655 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6656 the race-condition problem in the old DOWNCASE.
6658 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6659 Rename locals to avoid shadowing.
6660 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6661 (regex_compile, re_search_2, re_match_2_internal):
6662 Remove unused local vars.
6663 (FREE_VAR): Rewrite so as not to use empty "else",
6664 which gcc can warn about.
6665 (regex_compile, re_match_2_internal): Mark locals as initialized.
6666 (RETALLOC_IF): Define only if needed.
6667 (WORDCHAR_P): Likewise. This one is never needed, but is used
6668 only in a comment talking about a compiler bug, so put inside
6669 the #if 0 of that comment.
6670 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6671 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6674 * search.c (boyer_moore): Rename locals to avoid shadowing.
6675 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6676 (PREV_CHAR_BOUNDARY): Likewise.
6678 * search.c (simple_search): Remove unused var.
6680 * dired.c (compile_pattern): Move decl from here ...
6681 * lisp.h: ... to here, so that it can be checked.
6682 (struct re_registers): New forward decl.
6684 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6686 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6688 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6689 Rename locals to avoid shadowing.
6690 (Fvertical_motion): Mark locals as initialized.
6692 * casefiddle.c (casify_object, casify_region): Now static.
6693 (casify_region): Mark local as initialized.
6695 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6697 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6698 New macros, so that the caller can use some names other than
6699 gcpro1, gcpro2, etc.
6700 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6702 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6703 argument, for consistency with GCPRO2_VAR, etc: it is now the
6704 prefix of the variable, not the variable itself. All uses
6706 * dired.c (directory_files_internal, file_name_completion):
6707 Rename locals to avoid shadowing.
6709 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6710 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6711 dired.c's scmp function, had undefined behavior.
6712 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6713 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6714 * buffer.h: ... to here, because these macros use current_buffer,
6715 and the new implementation with inline functions needs to have
6716 current_buffer in scope now, rather than later when the macros
6718 (downcase, upcase1): New static inline functions.
6719 (DOWNCASE, UPCASE1): Reimplement using these functions.
6720 This avoids undefined behavior in expressions like
6721 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6722 from race conditions in accessing the global variables
6723 case_temp1 and case_temp2.
6724 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6725 * lisp.h (case_temp1, case_temp2): Remove their decls.
6726 * character.h (ASCII_CHAR_P): Move from here ...
6727 * lisp.h: ... to here, so that the inline functions mentioned
6730 * dired.c (directory_files_internal_unwind): Now static.
6732 * fileio.c (file_name_as_directory, directory_file_name):
6733 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6735 (file_name_as_directory): Use const pointers when appropriate.
6736 (Fexpand_file_name): Likewise. In particular, newdir might
6737 point at constant storage, so make it a const pointer.
6738 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6739 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6741 (Fset_file_times, Finsert_file_contents, auto_save_error):
6742 Rename locals to avoid shadowing.
6744 * minibuf.c (choose_minibuf_frame_1): Now static.
6745 (Ftry_completion, Fall_completions): Rename or remove locals
6748 * marker.c (bytepos_to_charpos): Remove; unused.
6750 * lisp.h (verify_bytepos, count_markers): New decls,
6751 so that gcc does not warn that these functions aren't declared.
6753 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6754 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6755 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6756 (copy_text): Remove unused local var.
6758 * filelock.c (within_one_second): Now static.
6759 (lock_file_1): Rename local to avoid shadowing.
6761 * buffer.c (fix_overlays_before): Mark locals as initialized.
6762 (fix_start_end_in_overlays): Likewise. This function should be
6763 simplified by using pointers-to-pointers, but that's a different
6765 (switch_to_buffer_1): Now static.
6766 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6767 (report_overlay_modification): Rename locals to avoid shadowing.
6769 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6770 Fix pointer signedness issue.
6771 (sys_subshell): Mark local as volatile if checking for lint,
6772 to suppress a gcc -Wclobbered warning that does not seem to be right.
6773 (MAXPATHLEN): Define only if needed.
6775 * process.c (serial_open, serial_configure): Move decls from here ...
6776 * systty.h: ... to here, so that they can be checked.
6778 * fns.c (get_random, seed_random): Move extern decls from here ...
6779 * lisp.h: ... to here, so that they can be checked.
6781 * sysdep.c (reset_io): Now static.
6782 (wait_for_termination_signal): Remove; unused.
6784 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6785 (copy_keymap_item, append_key, push_text_char_description):
6787 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6788 (DENSE_TABLE_SIZE): Remove; unused.
6789 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6790 (describe_map_tree):
6791 Rename locals to avoid shadowing.
6793 * keyboard.c: Declare functions static if they are not used elsewhere.
6794 (echo_char, echo_dash, cmd_error, top_level_2):
6795 (poll_for_input, handle_async_input): Now static.
6796 (read_char, kbd_buffer_get_event, make_lispy_position):
6797 (make_lispy_event, make_lispy_movement, apply_modifiers):
6798 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6799 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6800 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6801 (read_key_sequence, read_char): Mark locals as initialized.
6802 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6804 * keyboard.h (make_ctrl_char): New decl.
6805 (mark_kboards): Move decl here ...
6806 * alloc.c (mark_kboards): ... from here.
6808 * lisp.h (force_auto_save_soon): New decl.
6810 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6811 (DEFINE_DUMMY_FUNCTION): New macro.
6812 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6814 (main): Add casts to avoid warnings
6815 if GCC considers string literals to be constants.
6817 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6819 * dbusbind.c: Pointer signedness fixes.
6820 (xd_signature, xd_append_arg, xd_initialize):
6821 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6822 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6823 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6824 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6826 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6827 if GCC considers string literals to be constants.
6828 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6830 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6832 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6833 (print_preprocess, print_object): New macro to fix last change.
6835 * print.c (print_preprocess): Don't forget font objects.
6837 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6839 * emacs.c (USAGE3): Doc fixes.
6841 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6843 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6846 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6848 * lisp.h (VWindow_system, Qfile_name_history):
6849 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6850 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6851 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6853 * w32select.c: Don't #include "keyboard.h".
6854 (run_protected): Add extern declaration for waiting_for_input.
6856 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6857 * w32console.c (detect_input_pending, read_input_pending)
6858 (encode_terminal_code):
6859 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6860 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6861 (w32_system_caret_y, Qfile_name_history):
6862 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6863 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6864 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6865 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6866 * w32proc.c (Qlocal, report_file_error):
6867 * w32term.c (Vwindow_system, updating_frame):
6868 * w32uniscribe.c (initialized, uniscribe_font_driver):
6869 Remove unneeded extern declarations.
6871 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6873 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6875 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6877 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6878 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6879 These macros can no longer be used for assignment.
6881 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6882 Assign struct members directly, instead of using BUF_BEGV etc.
6883 (record_buffer_markers, fetch_buffer_markers): New functions for
6884 recording and fetching special buffer markers.
6885 (set_buffer_internal_1, set_buffer_temp): Use them.
6887 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6889 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6891 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6892 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6894 * xdisp.c (hscroll_window_tree):
6895 (reconsider_clip_changes): Use PT instead of BUF_PT.
6897 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6899 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6900 $(EMACS_ROOT)/lib/intprops.h.
6902 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6904 Fix more problems found by GCC 4.5.2's static checks.
6906 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6907 to unsigned char * to avoid compiler diagnostic.
6908 (xg_free_frame_widgets): Make it clear that a local variable is
6909 needed only if USE_GTK_TOOLTIP.
6910 (gdk_window_get_screen): Make it clear that this macro is needed
6911 only if USE_GTK_TOOLTIP.
6912 (int_gtk_range_get_value): New function, which avoids a diagnostic
6913 from gcc -Wbad-function-cast.
6914 (xg_set_toolkit_scroll_bar_thumb): Use it.
6915 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6916 diagnostic from gcc -Wbad-function-cast.
6917 (get_utf8_string, xg_get_file_with_chooser):
6918 Rename locals to avoid shadowing.
6919 (create_dialog): Move locals to avoid shadowing.
6921 * xgselect.c (xg_select): Remove unused var.
6923 * image.c (four_corners_best): Mark locals as initialized.
6924 (gif_load): Initialize transparent_p to zero (Bug#8238).
6925 Mark another local as initialized.
6926 (my_png_error, my_error_exit): Mark with NO_RETURN.
6928 * image.c (clear_image_cache): Now static.
6929 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6930 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6931 (x_edge_detection): Remove unnecessary cast that
6932 gcc -Wbad-function-cast diagnoses.
6933 (gif_load): Fix pointer signedness.
6934 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6935 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6937 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6939 Improve quality of tests for time stamp overflow.
6940 For example, without this patch (encode-time 0 0 0 1 1
6941 1152921504606846976) returns the obviously-bogus value (-948597
6942 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6943 reports time overflow. See
6944 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6945 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6946 * editfns.c: Include limits.h and intprops.h.
6947 (TIME_T_MIN, TIME_T_MAX): New macros.
6948 (time_overflow): Move earlier, to before first use.
6949 (hi_time, lo_time): New functions, for an accurate test for
6951 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6952 (Fget_internal_run_time): Don't assume time_t fits in int.
6953 (make_time): Use list2 instead of Fcons twice.
6954 (Fdecode_time): More accurate test for out-of-range times.
6955 (check_tm_member): New function.
6956 (Fencode_time): Use it, to test for out-of-range times.
6957 (lisp_time_argument): Don't rely on undefined left-shift and
6958 right-shift behavior when checking for time stamp overflow.
6960 * editfns.c (time_overflow): New function, refactoring common code.
6961 (Fformat_time_string, Fdecode_time, Fencode_time):
6962 (Fcurrent_time_string): Use it.
6964 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6965 * dired.c (make_time): Move to ...
6966 * editfns.c (make_time): ... here.
6967 * systime.h: Note the move.
6969 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6971 * fringe.c (update_window_fringes): Remove unused variables.
6973 * unexmacosx.c (copy_data_segment): Also copy __got section.
6976 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6978 * termcap.c [MSDOS]: Include "msdos.h".
6979 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6980 Constify `char *' arguments and their references according to
6981 prototypes in tparam.h.
6983 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6985 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6986 Adapt all references accordingly.
6988 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6990 2011-03-11 Tom Tromey <tromey@redhat.com>
6992 * buffer.c (syms_of_buffer): Remove obsolete comment.
6994 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6996 * termhooks.h (encode_terminal_code): Declare prototype.
6998 * msdos.c (encode_terminal_code): Don't declare prototype.
7000 * term.c (encode_terminal_code): Now external again, used by
7001 w32console.c and msdos.c.
7003 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7004 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7006 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7008 Fix some minor problems found by GCC 4.5.2's static checks.
7010 * fringe.c (update_window_fringes): Mark locals as initialized
7012 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7014 * alloc.c (mark_fringe_data): Move decl from here ...
7015 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7016 to check its interface.
7017 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7019 * fontset.c (free_realized_fontset): Now static.
7020 (Fset_fontset_font): Rename local to avoid shadowing.
7021 (fontset_font): Mark local as initialized.
7022 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7024 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7026 * xselect.c (x_disown_buffer_selections): Remove; not used.
7027 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7028 (x_own_selection, Fx_disown_selection_internal): Rename locals
7030 (x_handle_dnd_message): Remove local to avoid shadowing.
7032 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7033 so that the caller can use some name other than gcpro1.
7034 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7035 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7036 (Fx_backspace_delete_keys_p):
7037 Use them to avoid shadowing, and rename vars to avoid shadowing.
7038 (x_decode_color, x_set_name, x_window): Now static.
7039 (Fx_create_frame): Add braces to silence GCC warning.
7040 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7041 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7042 Remove unused locals.
7043 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7044 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7045 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7048 * xterm.h (x_mouse_leave): New decl.
7050 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7051 Remove unused functions.
7052 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7053 (x_calc_absolute_position): Now static.
7054 (XTread_socket): Don't define label "out" unless it's used.
7055 Don't declare local "event" unless it's used.
7056 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7057 unless they are used.
7058 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7059 (x_fatal_error_signal): Remove; not used.
7060 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7061 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7062 (x_error_catcher, x_connection_closed, x_error_handler):
7063 (x_error_quitter, xembed_send_message, x_iconify_frame):
7064 (my_log_handler): Rename locals to avoid shadowing.
7065 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7066 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7068 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7069 Rename or move locals to avoid shadowing.
7070 (tty_defined_color, merge_face_heights): Now static.
7071 (free_realized_faces_for_fontset): Remove; not used.
7072 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7073 does not deduce is never used uninitialized.
7074 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7075 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7077 * terminal.c (store_terminal_param): Now static.
7079 * xmenu.c (menu_highlight_callback): Now static.
7080 (set_frame_menubar): Remove unused local.
7081 (xmenu_show): Rename parameter to avoid shadowing.
7082 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7083 since they might point to immutable storage.
7084 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7085 since it's unused otherwise.
7087 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7088 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7089 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7090 avoids a gcc -Wuninitialized diagnostic.
7091 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7092 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7093 does not deduce are never used uninitialized.
7095 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7097 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7098 * window.c (window_loop, size_window):
7099 (run_window_configuration_change_hook, enlarge_window): Likewise.
7101 * window.c (display_buffer): Now static.
7102 (size_window): Mark variables that gcc -Wuninitialized
7103 does not deduce are never used uninitialized.
7104 * window.h (check_all_windows): New decl, to forestall
7105 gcc -Wmissing-prototypes diagnostic.
7106 * dispextern.h (bidi_dump_cached_states): Likewise.
7108 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7110 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7112 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7113 and to avoid gcc -Wuninitialized warning.
7114 (load_charset_map): Mark variables that gcc -Wuninitialized
7115 does not deduce are never used uninitialized.
7116 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7118 * coding.c (coding_set_source, coding_set_destination):
7119 Use "else { /* comment */ }" rather than "else /* comment */;"
7120 for clarity, and to avoid gcc -Wempty-body warning.
7121 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7122 a block, when the outer 'i' will do.
7123 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7124 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7125 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7126 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7127 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7128 Rename locals to avoid shadowing.
7129 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7130 * coding.c (emacs_mule_char, encode_invocation_designation):
7131 Now static, since they're not used elsewhere.
7132 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7133 (decode_coding_object, encode_coding_object, detect_coding_system):
7134 (decode_coding_emacs_mule): Mark variables that gcc
7135 -Wuninitialized does not deduce are never used uninitialized.
7136 (detect_coding_iso_2022): Initialize a local variable that might
7137 be used uninitialized. Leave a FIXME because it's not clear that
7138 this initialization is needed. (Bug#8211)
7139 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7140 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7141 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7142 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7143 Remove unused macros.
7145 * category.c (hash_get_category_set): Remove unused local var.
7146 (copy_category_table): Now static, since it's not used elsewhere.
7147 * character.c (string_count_byte8): Likewise.
7149 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7150 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7152 * chartab.c (copy_sub_char_table): Now static, since it's not used
7154 (sub_char_table_ref_and_range, char_table_ref_and_range):
7155 Rename locals to avoid shadowing.
7156 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7158 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7159 (BIDI_BOB): Remove unused macro.
7161 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7162 deduce are never used uninitialized.
7163 * term.c (encode_terminal_code): Likewise.
7165 * term.c (encode_terminal_code): Now static. Remove unused local.
7167 * tparam.h: New file.
7168 * term.c, tparam.h: Include it.
7169 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7170 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7171 Move these decls to tparam.h, and make them agree with what
7172 is actually in tparam.c. The previous trick of using incompatible
7173 decls in different modules does not conform to the C standard.
7174 All callers of tparam changed to use tparam's actual API.
7175 * tparam.c (tparam1, tparam, tgoto):
7176 Use const pointers where appropriate.
7178 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7179 * cm.h (struct cm): Likewise.
7180 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7181 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7182 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7183 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7184 (turn_on_face, init_tty): Likewise.
7185 * termchar.h (struct tty_display_info): Likewise.
7187 * term.c (term_mouse_position): Rename local to avoid shadowing.
7189 * alloc.c (mark_ttys): Move decl from here ...
7190 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7192 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7194 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7196 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7198 * search.c (compile_pattern_1): Remove argument regp, unused since
7199 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7200 (compile_pattern): Don't pass it.
7202 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7204 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7205 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7207 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7209 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7211 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7212 gdk_window_get_screen, gdk_window_get_geometry,
7213 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7214 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7215 (xg_get_pixbuf_from_pixmap): New function.
7216 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7217 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7218 Call xg_get_pixbuf_from_pixmap instead of
7219 gdk_pixbuf_get_from_drawable.
7220 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7221 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7222 (xg_check_special_colors): Use GtkStyleContext and its functions
7224 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7225 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7226 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7227 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7228 Call gtk_widget_get_preferred_size.
7229 (xg_frame_resized): gdk_window_get_geometry only takes 5
7231 (xg_win_to_widget, xg_event_is_for_menubar):
7232 Call gdk_x11_window_lookup_for_display.
7233 (xg_set_widget_bg): New function.
7234 (delete_cb): New function.
7235 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7236 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7237 (xg_set_background_color): Call xg_set_widget_bg.
7238 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7239 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7240 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7241 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7243 (update_frame_tool_bar): Call gtk_widget_hide.
7244 (xg_initialize): Use GDK_KEY_g.
7246 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7248 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7250 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7251 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7252 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7254 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7256 * w32xfns.c (select_palette): Check success of RealizePalette against
7257 GDI_ERROR, not zero.
7259 See ChangeLog.11 for earlier changes.
7265 Copyright (C) 2011 Free Software Foundation, Inc.
7267 This file is part of GNU Emacs.
7269 GNU Emacs is free software: you can redistribute it and/or modify
7270 it under the terms of the GNU General Public License as published by
7271 the Free Software Foundation, either version 3 of the License, or
7272 (at your option) any later version.
7274 GNU Emacs is distributed in the hope that it will be useful,
7275 but WITHOUT ANY WARRANTY; without even the implied warranty of
7276 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7277 GNU General Public License for more details.
7279 You should have received a copy of the GNU General Public License
7280 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.