1 2011-12-09 Eli Zaretskii <eliz@gnu.org>
3 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
6 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
9 that where the value of an _OBJC_* symbol points to is in the .bss
12 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
14 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
15 after the loop to call ccl_driver at least once (Bug#8619).
17 2011-12-08 Kenichi Handa <handa@m17n.org>
19 * ftfont.c (get_adstyle_property): Fix previous change
22 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
24 * w32.c (init_environment): If no_site_lisp, remove site-lisp
25 dirs from the default value of EMACSLOADPATH (bug#10208).
27 2011-12-07 Glenn Morris <rgm@gnu.org>
29 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
30 installation and source directories as well. (Bug#10208)
32 2011-12-06 Chong Yidong <cyd@gnu.org>
34 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
36 2011-12-06 Glenn Morris <rgm@gnu.org>
38 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
39 as an error, not just -1. (Bug#10217)
41 2011-12-05 Chong Yidong <cyd@gnu.org>
43 * keyboard.c (process_special_events): New function.
44 (swallow_events, Finput_pending_p): Use it (Bug#10195).
46 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
48 * coding.c (encode_designation_at_bol): Don't use uninitialized
49 local variable (Bug#9318).
51 2011-12-05 Kenichi Handa <handa@m17n.org>
53 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
54 return Qnil (Bug#8046, Bug#10193).
56 2011-12-05 Kenichi Handa <handa@m17n.org>
58 * coding.c (encode_designation_at_bol): New args charbuf_end and
59 dst. Return the number of produced bytes. Callers changed.
60 (coding_set_source): Return how many bytes coding->source was
62 (coding_set_destination): Return how many bytes
63 coding->destination was relocated.
64 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
65 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
67 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
69 * coding.c (CODING_CHAR_CHARSET_P): New macro.
70 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
73 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
75 The following changes are to fix Bug#9318.
77 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
78 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
79 (encode_coding_iso_2022, encode_coding_sjis)
80 (encode_coding_big5, encode_coding_charset): Use the above macros.
82 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
84 * lisp.h (process_quit_flag): Fix external declaration.
86 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
88 Don't macro-inline non-performance-critical code.
89 * eval.c (process_quit_flag): New function.
90 * lisp.h (QUIT): Use it.
92 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
94 * nsfns.m (get_geometry_from_preferences): New function.
95 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
97 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
99 * emacs.c (Qkill_emacs): Define.
100 (syms_of_emacs): Initialize it.
101 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
102 Qquit_flag to `kill-emacs' instead.
103 (quit_throw_to_read_char): Add parameter `from_signal'.
104 All callers changed. Call Fkill_emacs if requested and safe.
105 * lisp.h (QUIT): Call Fkill_emacs if requested.
107 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
109 * widget.c (update_wm_hints): Return if wmshell is null.
110 (widget_update_wm_size_hints): New function.
112 * widget.h (widget_update_wm_size_hints): Declare.
114 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
115 widget_update_wm_size_hints (Bug#10104).
117 2011-12-03 Eli Zaretskii <eliz@gnu.org>
119 * xdisp.c (handle_invisible_prop): If the invisible text ends just
120 before a newline, prepare the bidi iterator for consuming the
121 newline, and keep the current paragraph direction. (Bug#10183)
122 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
124 2011-12-02 Juri Linkov <juri@jurta.org>
126 * search.c (Fword_search_regexp): New Lisp function created from
127 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
128 (Fword_search_backward, Fword_search_forward)
129 (Fword_search_backward_lax, Fword_search_forward_lax):
130 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
131 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
133 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
135 * fileio.c (Finsert_file_contents): Move after-change-function call
136 to before the "handled:" label, since all "goto handled" appear in
137 cases where the *-change-functions have already been properly called
140 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
142 * keyboard.c (interrupt_signal): Don't call kill-emacs when
143 waiting for input. (Bug#10169)
145 2011-11-30 Eli Zaretskii <eliz@gnu.org>
147 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
148 verifies glyph row's hash code--we have just reallocated the
149 glyphs, so their contents can be complete garbage. (Bug#10164)
151 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
153 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
155 2011-11-30 Eli Zaretskii <eliz@gnu.org>
157 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
158 attributes are tested _before_ calling verify_row_hash, to protect
159 against GCC re-ordering of the tests. (Bug#10164)
161 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
163 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
165 * xterm.c (handle_one_xevent): Only set async_visible and friends
166 if net_wm_state_hidden_seen is non-zero (Bug#10002)
167 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
168 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
170 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
172 Remove GCPRO-related macros that exist only to avoid shadowing locals.
173 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
174 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
175 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
176 All uses changed to use GCPRO1 etc.
177 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
178 Revert to old implementation (i.e., before 2011-03-11).
180 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
182 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
183 of scroll runs so as to avoid assigning disabled bogus rows and
184 unnecessary graphics copy operations.
186 2011-11-27 Eli Zaretskii <eliz@gnu.org>
188 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
189 (snprintf) [_MSC_VER]: Redirect to _snprintf.
190 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
191 (malloc, free, realloc, calloc): Redirect to e_* only when
194 * lisp.h (GCTYPEBITS): Move before first use.
195 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
196 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
197 this macro definition.
199 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
202 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
204 * gtkutil.c (xg_create_frame_widgets):
205 Call gtk_window_set_has_resize_grip (FALSE) if that function is
206 present with Gtk+ 2.0.
208 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
210 * fileio.c (Finsert_file_contents): Undo previous change; see
211 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
213 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
215 Rename locals to avoid shadowing.
216 * fileio.c (Finsert_file_contents):
217 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
218 * process.c (wait_reading_process_output):
219 Rename inner 'proc' to 'p' to avoid shadowing.
220 Indent for consistency with usual Emacs style.
222 2011-11-25 Eli Zaretskii <eliz@gnu.org>
224 * xdisp.c (redisplay_window): If cursor row is not fully visible
225 after recentering, and scroll-conservatively is set to a large
226 number, scroll window by a few more lines to make the cursor fully
227 visible and out of scroll-margin. (Bug#10105)
228 (start_display): Don't move to the next line if the display should
229 start at a newline that is part of a display vector or an overlay
232 2011-11-24 Juri Linkov <juri@jurta.org>
234 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
235 after the `MagickPingImage' call. (Bug#10112)
237 2011-11-23 Chong Yidong <cyd@gnu.org>
239 * window.c (Fcoordinates_in_window_p): Accept only live windows.
241 2011-11-23 Martin Rudalics <rudalics@gmx.at>
243 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
244 making another buffer current. (Bug#10114)
246 2011-11-23 Glenn Morris <rgm@gnu.org>
248 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
250 2011-11-23 Chong Yidong <cyd@gnu.org>
252 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
255 2011-11-22 Eli Zaretskii <eliz@gnu.org>
257 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
258 and header-lines, as they don't have one computed for them.
261 * .gdbinit (prow): Make displayed values more self-explaining.
264 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
266 * process.c (wait_reading_process_output): Fix asynchrounous
267 GnuTLS socket handling on some versions of the GnuTLS library.
268 (wait_reading_process_output): Add comment and URL.
270 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
272 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
274 2011-11-21 Chong Yidong <cyd@gnu.org>
276 * window.c (Fnext_window, Fprevious_window): Doc fix.
278 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
280 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
282 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
284 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
286 2011-11-20 Martin Rudalics <rudalics@gmx.at>
288 * window.c (Fset_window_combination_limit): Rename argument
290 (Vwindow_combination_limit): Remove "status" from doc-string.
292 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
294 * m/ibms390.h: Remove.
295 * m/ibms390x.h: Don't include "ibms390.h".
297 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
299 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
300 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
302 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
304 * casetab.c (Fset_case_table):
305 * charset.c (Fcharset_after): Fix typos.
307 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
309 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
310 Otherwise, valgrind does not work on some platforms.
311 Problem reported by Andreas Schwab in
312 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
313 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
314 is set, removing the need for VIRT_ADDRESS_VARIES.
315 (PURE_P): Use a more-efficient implementation that needs just one
316 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
317 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
318 to 4 (xorl, subq, cmpq, setbe).
319 * alloc.c (pure): Always extern now, since that's the
320 VIRT_ADDR_VARIES behavior.
321 (PURE_POINTER_P): Use a single comparison, not two, for
322 consistency with the new puresize.h.
323 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
324 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
325 Remove VIRT_ADDR_VARIES no longer needed.
327 2011-11-19 Eli Zaretskii <eliz@gnu.org>
329 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
330 (erase_phys_cursor, update_window_cursor, show_mouse_face)
331 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
332 behave as if the cursor position were at the window margin.
334 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
335 and the cursor position is out of bounds, behave as if the cursor
336 position were at the window margin. (Bug#10075)
338 2011-11-18 Chong Yidong <cyd@gnu.org>
340 * window.c (Fwindow_combination_limit): Make first argument
341 non-optional, since it is meaningless for live windows like the
344 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
346 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
348 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
350 * intervals.c: Fix grafting over the whole buffer (bug#10071).
351 (graft_intervals_into_buffer): Simplify.
353 2011-11-18 Eli Zaretskii <eliz@gnu.org>
355 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
356 hash values of the two rows.
357 (copy_row_except_pointers): Preserve the used[] arrays and the
358 hash values of the two rows. (Bug#10035)
359 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
361 * xdisp.c (row_hash): New function, body extracted from
362 compute_line_metrics.
363 (compute_line_metrics): Call row_hash, instead of computing the
366 * dispnew.c (verify_row_hash): Call row_hash for computing the
367 hash code of a row, instead of duplicating code from xdisp.c.
369 * dispextern.h (row_hash): Add prototype.
371 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
373 * frame.c (delete_frame): Don't delete the terminal when the last
374 X frame is closed if emacs is built with GTK toolkit.
376 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
378 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
380 2011-11-17 Martin Rudalics <rudalics@gmx.at>
382 * window.c (Vwindow_splits): Rename to
383 Vwindow_combination_resize. Suggested by Juri Linkov.
384 (Fsplit_window_internal): Use Vwindow_combination_resize instead
387 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
389 * nsfns.m (Fns_font_name):
390 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
392 2011-11-16 Martin Rudalics <rudalics@gmx.at>
394 * window.h (window): Rename slot "nest" to "combination_limit".
395 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
396 (Fset_window_nest): Rename to Fset_window_combination_limit.
397 (Vwindow_nest): Rename to Vwindow_combination_limit.
398 (recombine_windows, make_parent_window, make_window)
399 (Fsplit_window_internal, saved_window)
400 (Fset_window_configuration, save_window_save): Rename all
401 occurrences of window_nest to window_combination_limit.
403 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
405 * image.c (imagemagick_load_image): Fix typo.
407 2011-11-14 Eli Zaretskii <eliz@gnu.org>
409 * xdisp.c (display_line): Move the call to
410 highlight_trailing_whitespace before the call to
411 compute_line_metrics, since the latter needs to see the final
412 faces of all the glyphs to compute ROW's hash value.
413 Fixes assertion violations in row_equal_p. (Bug#10035)
415 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
417 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
418 just return (bug#10044).
420 2011-11-12 Eli Zaretskii <eliz@gnu.org>
422 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
423 with user-defined heap size. Bump the default size of the temacs
424 heap to 27MB, to avoid memory warning when running temacs.
425 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
427 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
428 current_matrix and desired_matrix. (Bug#9990)
429 (verify_row_hash) [XASSERTS]: New function.
430 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
431 that the hash value of glyph rows is correct.
433 2011-11-12 Martin Rudalics <rudalics@gmx.at>
435 * window.h (window): Remove splits slot.
436 * window.c (Fwindow_splits, Fset_window_splits): Remove.
437 (Fdelete_other_windows_internal, make_parent_window)
438 (make_window, Fsplit_window_internal, Fdelete_window_internal)
439 (Fset_window_configuration, save_window_save): Don't deal with
440 split status of windows.
441 (saved_window): Remove splits slot.
442 (Vwindow_splits): Rewrite doc-string.
444 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
446 * xfns.c (unwind_create_frame):
447 * nsfns.m (unwind_create_frame):
448 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
449 Vframe_list (Bug#9999).
451 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
453 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
455 2011-11-11 Kenichi Handa <handa@m17n.org>
457 * callproc.c (Fcall_process): Set the member dst_multibyte of
460 2011-11-11 Johan Bockgård <bojohan@gnu.org>
462 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
463 avoid a crash (bug#9496).
465 2011-11-09 Chong Yidong <cyd@gnu.org>
467 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
468 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
470 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
472 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
474 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
476 Avoid some portability problems by eschewing 'extern inline' functions.
477 The trivial performance wins aren't worth the portability hassles; see
478 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
480 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
481 (window_box_width, window_box_left, window_box_left_offset)
482 (window_box_right, window_box_right_offset): Undo previous change,
483 by removing the "extern"s.
484 * intervals.c (adjust_intervals_for_insertion)
485 (adjust_intervals_for_deletion): Undo previous change,
486 making these static again.
487 (offset_intervals, temp_set_point_both, temp_set_point)
488 (copy_intervals_to_string): No longer inline.
489 * xdisp.c (window_text_bottom_y, window_box_width)
490 (window_box_height, window_box_left_offset)
491 (window_box_right_offset, window_box_left, window_box_right)
492 (window_box): No longer inline.
494 2011-11-08 Chong Yidong <cyd@gnu.org>
496 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
497 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
498 Signal an error if not a live window.
499 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
500 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
502 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
504 * lisp.h (syms_of_abbrev): Remove declaration.
505 Reported by CHENG Gao <chenggao@royau.me>.
507 2011-11-07 Eli Zaretskii <eliz@gnu.org>
509 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
510 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
511 of temacs in GUI mode.
513 2011-11-07 Martin Rudalics <rudalics@gmx.at>
515 * window.h: Declare delete_all_child_windows instead of
516 delete_all_subwindows.
517 * window.c (Fwindow_nest, Fset_window_nest)
518 (Fset_window_new_total, Fset_window_new_normal)
519 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
520 (delete_all_subwindows): Rename to delete_all_child_windows.
521 (Fdelete_other_windows_internal, Fset_window_configuration):
522 Call delete_all_child_windows instead of delete_all_subwindows.
523 * frame.c (delete_frame): Call delete_all_child_windows instead
524 of delete_all_subwindows.
526 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
528 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
529 This is also needed for porting to any host where GC_MARK_STACK is
530 not GC_MAKE_GCPROS_NOOPS.
531 (which_symbols): Use it.
533 2011-11-07 Kenichi Handa <handa@m17n.org>
535 * coding.c (coding_set_destination): Check coding->src_pos only
536 when coding->src_object is a buffer (bug#9910).
538 * process.c (send_process): Set the member src_multibyte of coding
539 to 0 (bug#9911) when sending a unibyte text.
541 * callproc.c (Fcall_process): Set the member src_multibyte of
542 process_coding to 0 (bug#9912).
544 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
546 * xmenu.c (cleanup_widget_value_tree): New function.
547 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
548 calling free_menubar_widget_value_tree directly (Bug#9830).
550 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
552 Fix some portability problems with 'inline'.
553 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
554 (window_box_width, window_box_left, window_box_left_offset)
555 (window_box_right, window_box_right_offset): Declare extern.
556 Otherwise, these inline functions do not conform to C99 and
557 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
558 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
559 * intervals.c (adjust_intervals_for_insertion)
560 (adjust_intervals_for_deletion): Now extern, because otherwise the
561 extern inline functions 'offset_intervals' couldn't refer to it.
562 (static_offset_intervals): Remove.
563 (offset_intervals): Rewrite using the old contents of
564 static_offset_intervals. The old version didn't conform to C99
565 because an extern inline function contained a reference to an
566 identifier with static linkage.
568 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
570 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
573 2011-11-06 Eli Zaretskii <eliz@gnu.org>
575 * xdisp.c (init_iterator, reseat_to_string): Don't set the
576 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
577 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
578 return Qleft_to_right.
580 2011-11-06 Chong Yidong <cyd@gnu.org>
582 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
583 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
584 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
585 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
586 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
587 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
588 (Fwindow_vscroll): Doc fix.
589 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
590 argument, since it makes no sense to pass a live window and for
591 consistency with window-child.
593 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
595 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
598 2011-11-05 Jason Rumney <jasonr@gnu.org>
600 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
601 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
603 (add_font_entity_to_list): Fix logic errors in mixed boolean and
604 bitwise arithmetic preventing use of unicode-sip and non-truetype
607 2011-11-05 Eli Zaretskii <eliz@gnu.org>
609 * s/ms-w32.h (fstat, stat, utime): Move redirections to
612 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
613 initialization code to keep similarity to xfns.c after changes
616 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
618 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
619 (unwind_create_frame): New function (Bug#9943).
620 (Fx_create_frame): Restructure code to be more similar to the one in
621 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
622 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
623 Move terminal->reference_count++ just before making the frame official
626 * nsterm.m (x_free_frame_resources): New function.
627 (x_destroy_window): Move code to x_free_frame_resources.
629 * xfns.c (unwind_create_frame): Fix comment.
630 (Fx_create_frame, x_create_tip_frame):
631 Move terminal->reference_count++ just before making the frame
632 official. Move initialization of image_cache_refcount and
633 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
635 2011-11-05 Eli Zaretskii <eliz@gnu.org>
637 Support MSVC build with newer versions of Visual Studio.
638 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
639 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
642 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
643 which are not supported by MSVC.
644 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
645 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
647 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
649 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
651 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
653 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
655 Support MSVC build with newer versions of Visual Studio.
656 * w32.c: Don't include w32api.h for MSVC.
657 (init_environment) [_MSC_VER]: Call sys_access, not _access.
659 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
660 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
661 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
662 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
664 (alloca) [_MSC_VER]: Define to _alloca.
666 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
668 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
670 2011-11-04 Eli Zaretskii <eliz@gnu.org>
672 * xdisp.c (note_mouse_highlight): If either of
673 previous/next-single-property-change returns nil, treat that as
674 the beginning or the end of the buffer. (Bug#9955)
676 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
678 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
679 label is not null (Bug#9951).
680 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
683 2011-11-04 Eli Zaretskii <eliz@gnu.org>
685 * window.c (Fwindow_body_size): Mention in the doc string that the
686 return value is in frame's canonical units. (Bug#9949)
688 2011-11-03 Eli Zaretskii <eliz@gnu.org>
690 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
692 * w32fns.c (unwind_create_frame): If needed, free the glyph
693 matrices of the partially constructed frame. (Bug#9943)
694 * xfns.c (unwind_create_frame): Likewise.
696 2011-11-01 Eli Zaretskii <eliz@gnu.org>
698 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
699 Don't stop backward scan on the continuation glyph, even though
700 its CHARPOS is positive.
701 (mouse_face_from_buffer_pos, note_mouse_highlight):
702 Rename cover_string to disp_string.
704 2011-11-01 Martin Rudalics <rudalics@gmx.at>
706 * window.c (temp_output_buffer_show): Don't use
707 Vtemp_buffer_show_specifiers.
708 (Vtemp_buffer_show_specifiers): Remove unused variable.
710 2011-10-30 Eli Zaretskii <eliz@gnu.org>
712 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
713 past the beginning of the current glyph matrix.
715 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
717 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
718 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
719 HAVE_GTK3 (Bug#9869).
721 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
722 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
724 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
726 * xterm.c: Declare x_handle_net_wm_state to return int.
727 (handle_one_xevent): Check if we are iconified but don't have
728 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
729 (get_current_wm_state): Return non-zero if not hidden,
730 check for _NET_WM_STATE_HIDDEN (Bug#9893).
731 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
732 (x_handle_net_wm_state): Return what get_current_wm_state returns.
733 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
735 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
737 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
738 so that this new function doesn't get optimized away by a
739 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
741 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
743 * frame.h (MOUSE_HL_INFO): Remove excess parens.
745 2011-10-29 Eli Zaretskii <eliz@gnu.org>
747 Fix the `xbytecode' command.
748 * .gdbinit (xprintbytestr): New command.
749 (xwhichsymbols): Rename from `which'; all callers changed.
750 (xbytecode): Print the byte-code string as well.
752 2011-10-29 Kim Storm <storm@cua.dk>
754 * alloc.c (which_symbols): New function.
756 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
758 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
761 2011-10-29 Glenn Morris <rgm@gnu.org>
763 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
764 Not clear what it was for, and it causes various bugs. (Bug#9839)
766 2011-10-28 Eli Zaretskii <eliz@gnu.org>
768 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
769 possible random value that matches one of those tested as
770 condition to clear the mouse face.
772 2011-10-28 Chong Yidong <cyd@gnu.org>
774 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
776 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
778 * window.c (make_window): Initialize phys_cursor_on_p.
780 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
782 * lisp.h (struct Lisp_Symbol): Update comments.
784 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
786 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
788 2011-10-28 Eli Zaretskii <eliz@gnu.org>
790 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
791 <oslsachem@gmail.com> for helping to debug this.
793 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
794 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
795 (g_b_init_get_glyph_outline_w): New static variables.
796 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
797 (GetGlyphOutlineW_Proc): New typedefs.
798 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
799 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
801 (w32font_open_internal, compute_metrics):
802 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
803 instead of calling the "wide" APIs directly.
805 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
807 * w32.h (syms_of_w32font): Add prototype.
809 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
811 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
812 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
813 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
814 (Fmove_to_window_line): Doc fix.
816 2011-10-27 Chong Yidong <cyd@gnu.org>
818 * process.c (make_process): Set gnutls_state to NULL.
820 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
821 non-NULL, regardless of GNUTLS_INITSTAGE.
822 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
823 an error. Set process slots as soon as we allocate them.
825 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
827 2011-10-27 Chong Yidong <cyd@gnu.org>
829 * gnutls.c (emacs_gnutls_deinit): New function.
830 Deallocate credentials structures as well as calling gnutls_deinit.
831 (Fgnutls_deinit, Fgnutls_boot): Use it.
833 * process.c (make_process): Initialize GnuTLS credentials to NULL.
834 (deactivate_process): Call emacs_gnutls_deinit.
836 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
838 * image.c (x_create_x_image_and_pixmap):
839 * w32.c (sys_rename, w32_delayed_load):
840 * w32font.c (fill_in_logfont):
841 * w32reg.c (x_get_string_resource): Silence compiler warnings.
843 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
845 * w32fns.c (w32_default_color_map): New function,
846 extracted from Fw32_default_color_map.
847 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
849 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
851 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
853 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
855 * keyboard.c (test_undefined): New function (bug#9751).
856 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
858 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
860 * sysdep.c (init_sys_modes): Fix the check for the controlling
863 2011-10-20 Eli Zaretskii <eliz@gnu.org>
865 * dispextern.h (struct bidi_it): New member next_en_type.
867 * bidi.c (bidi_line_init): Initialize the next_en_type member.
868 (bidi_resolve_explicit_1): When next_en_pos is valid for the
869 current character, check also for next_en_type being WEAK_EN.
870 (bidi_resolve_weak): Don't enter the expensive loop if the current
871 position is before next_en_pos. Record the bidi type of the first
872 non-ET, non-BN character we find, in addition to its position.
873 (bidi_level_of_next_char): Invalidate next_en_type when
874 next_en_pos is over-stepped.
876 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
878 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
879 * editfns.c: Rewrite current-time-zone so that it invokes
880 the equivalent of (format-time-string "%Z") to get the time zone name.
881 This fixes a bug when the time zone name contains characters that
882 need converting from the system time locale to Emacs internal format.
883 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
884 that patch fixed format-time-string to do the conversion, but
885 I forgot to fix current-time-zone.
886 (format_time_string): New function, containing most of
887 what Fformat_time_string used to contain.
888 (Fformat_time_string): Rewrite in terms of format_time_string.
889 This doesn't change this function's behavior.
890 (current-time-zone): Rewrite to use format_time_string.
891 This fixes the bug reported by Michael Schierl in
892 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
893 Jason Rumney's 2007-06-07 change worked around this bug, but
895 * systime.h (tzname, timezone): Remove no-longer-used declarations.
897 2011-10-19 Eli Zaretskii <eliz@gnu.org>
899 * xdisp.c (start_display): If the character at POS is displayed
900 via a display vector, reset IT->current.dpvec_index to zero.
901 (try_window_reusing_current_matrix): If a line ends in a display
902 vector or the next line starts in a display vector, continue
903 redrawing the window even though the character position of
904 start_row was reached.
907 2011-10-18 Chong Yidong <cyd@gnu.org>
909 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
910 with nobreak-char-display too.
912 2011-10-18 Eli Zaretskii <eliz@gnu.org>
914 Fix part 3 of bug#9771.
915 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
916 (bidi_resolve_neutral): Don't enter the expensive loop looking for
917 non-neutral characters if the current character is a paragraph
918 separator (a.k.a. Newline). This avoids running the same
919 expensive loop twice, once when we consume the preceding newline
920 and the other time when the line actually needs to be displayed.
921 Avoid the loop when we see neutrals on the base embedding level
922 following a character whose directionality is the same as the
923 paragraph's. This avoids running the expensive loop when a line
924 ends in a long sequence of neutrals, like control characters.
925 Add assertion against STRONG_AL type. Slightly rearrange code
926 that determines the type of a neutral given the first non-neutral
928 (bidi_level_of_next_char): Set next_en_pos to zero when
929 invalidating its info.
931 2011-10-17 Eli Zaretskii <eliz@gnu.org>
933 * xdisp.c (push_display_prop): Determine whether to record string
934 or buffer position by IT->string, not by IT->method. Allow
935 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
936 (move_it_vertically_backward): Don't look for character position
937 immediately after the newline when in a continuation line.
940 2011-10-15 Martin Rudalics <rudalics@gmx.at>
942 * window.c (coordinates_in_window): Rewrite and delabelize
943 vertical border check. (Bug#5357) (Bug#9618)
945 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
947 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
948 errors in XSetWindowBorder (bug#9310).
950 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
952 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
953 avoid crash when xmalloc overrun checking is enabled.
955 2011-10-13 Eli Zaretskii <eliz@gnu.org>
957 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
958 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
959 cursor motion with <left> and <right> arrow keys.
961 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
962 some callers set that themselves.
964 2011-10-12 Eli Zaretskii <eliz@gnu.org>
966 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
967 display string and the previous row comes from the same string and
968 is empty. (Bug#9739) (Bug#9738)
970 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
972 * doc.c (get_doc_string): Encode file name (bug#9735).
974 2011-10-12 Eli Zaretskii <eliz@gnu.org>
976 * bidi.c (bidi_level_of_next_char):
977 * xdisp.c (get_visually_first_element): Remove old incorrect
978 comments regarding the Unicode Line Separator character.
980 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
982 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
984 * alloc.c (Fgc_status): Do not access beyond zombies array
985 boundary if nzombies > MAX_ZOMBIES.
986 * alloc.c (dump_zombies): Add missing format specifier.
988 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
990 * xdisp.c (set_cursor_from_row): Simplify conditionals,
991 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
993 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
994 Some packages use them to denote characters with modifiers.
996 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
998 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
999 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1000 matching a pp-number. Rename parameter var to var1.
1002 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1004 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1006 2011-10-08 Glenn Morris <rgm@gnu.org>
1008 * callint.c (Fcall_interactively): Give a more explicit error for the
1009 'c' case with a non-character input. (Bug#8479)
1011 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1013 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1015 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1016 lines that are hscrolled on the left.
1018 * dispnew.c (buffer_posn_from_coords): Account for a possible
1019 presence of header-line. (Bug#4426)
1021 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1023 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1024 Don't advertise functionality which we discourage or doesn't work.
1026 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1028 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1029 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1030 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1031 this makes Emacs dump core during garbage collection on rare
1032 occasions. sizeof is obviously inferior to offsetof here, so
1033 stick with offsetof.
1034 (GC_POINTER_ALIGNMENT): New macro.
1035 (mark_memory): Omit 3rd (offset) arg; caller changed.
1036 Don't assume EMACS_INT alignment is the same as pointer alignment.
1038 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1040 * keyboard.c (read_key_sequence_remapped): New var.
1041 (read_key_sequence): Compute remapping in the right buffer.
1042 (command_loop_1): Use read_key_sequence's remapping directly.
1044 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1046 * dired.c (file_name_completion): Don't expand file name.
1047 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1048 before checking file name handler.
1050 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1051 they've been requested explicitly (bug#9591).
1053 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1055 * keymap.c (Fsingle_key_description): Use make_specified_string
1056 instead of build_string to build string from push_key_description.
1059 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1061 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1062 This fixes a Y2038 bug on 64-bit hosts.
1063 * buffer.c (reset_buffer):
1064 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1065 (Fclear_buffer_auto_save_failure):
1066 Use 0, not -1, to represent an unset failure time, since time_t
1067 might not be signed.
1069 Remove dependency on glibc malloc internals.
1070 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1071 Move back here from lisp.h, but with their new implementations.
1072 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1073 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1074 * charset.c (charset_table_init): New static var.
1075 (syms_of_charset): Use it instead of xmalloc. This removes a
1076 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1077 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1078 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1079 Move back to alloc.c.
1080 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1081 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1083 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1085 * nsterm.m (windowDidResize): Call x_set_window_size only when
1086 ns_in_resize is true. Otherwise set pixelwidth/height and
1087 call change_frame_size (Bug#9628).
1089 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1091 Port --enable-checking=all to Fedora 14 x86-64.
1092 * charset.c (syms_of_charset): Also account for glibc malloc's
1093 internal overhead when calculating the initial malloc maximum.
1095 Port --enable-checking=all to Fedora 14 x86.
1096 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1098 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1099 (overrun_check_realloc, overrun_check_free):
1100 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1101 That way, xmalloc returns a properly-aligned pointer even if
1102 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1103 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1104 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1105 into account when calculating the initial malloc maximum.
1106 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1107 Move here from alloc.c, so that charset.c can use it too.
1108 Properly align; the old code wasn't right for common 32-bit hosts
1109 when configured with --enable-checking=all.
1110 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1111 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1113 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1115 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1118 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1120 * xdisp.c (compute_display_string_end): If there's no display
1121 string at CHARPOS, return -1.
1123 * bidi.c (bidi_fetch_char): When compute_display_string_end
1124 returns a negative value, treat the character as a normal
1125 character not covered by a display string. (Bug#9624)
1127 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1129 * lread.c (Fread_from_string): Fix typo in docstring.
1131 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1133 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1134 newline, reseat the iterator instead of bidi-iterating there one
1135 character at a time. (Bug#9610)
1136 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1137 TO_CHARPOS if the bidi iterator is at base embedding level.
1139 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1141 * lread.c (readevalloop): Use correct code for NBSP.
1142 (read1): Likewise. (Bug#9608)
1144 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1146 * dbusbind.c (Fdbus_register_signal): When service is not
1147 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1149 2011-09-25 Glenn Morris <rgm@gnu.org>
1151 * buffer.c (truncate-lines): Doc fix.
1153 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1155 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1156 (Fset_window_next_buffers): Doc fix.
1158 2011-09-24 Glenn Morris <rgm@gnu.org>
1160 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1162 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1164 Fix minor problems found by static checking.
1165 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1166 * indent.c (Fvertical_motion): Fix == vs = typo.
1168 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1170 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1171 Default value is now t. Doc fix.
1173 * indent.c (Fvertical_motion): Compute and apply the overshoot
1174 logic when moving up, not only when moving down. Fix the
1175 confusing name and values of the it_overshoot_expected variable;
1176 logic changes accordingly. (Bug#9254) (Bug#9549)
1178 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1179 CHARPOS is covered by a display string which includes newlines.
1180 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1181 is covered by a display string with embedded newlines.
1183 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1185 * dbusbind.c (Fdbus_register_signal): Add match rule to
1186 Vdbus_registered_objects_table. (Bug#9581)
1187 (Fdbus_register_method, Vdbus_registered_objects_table):
1190 2011-09-24 Jim Meyering <meyering@redhat.com>
1192 do not ignore write error for any output size
1193 The previous change was incomplete.
1194 While it makes emacs --batch detect the vast majority of stdout
1195 write failures, errors were still ignored whenever the output size is
1196 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1197 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1198 && echo FAIL: ignored write error
1199 FAIL: ignored write error
1200 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1201 && echo FAIL: ignored write error
1202 FAIL: ignored write error
1203 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1205 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1207 * emacs.c (Fkill_emacs): In noninteractive mode exit
1208 non-successfully if a write error occurred on stdout. (Bug#9574)
1210 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1212 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1215 * dispextern.h (struct it): Update the comment documenting what
1218 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1220 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1221 a display string, extend search for cursor position to end of row.
1222 (find_row_edges): If the row ends in a newline from a display
1223 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1224 Handle the case of a display string with multiple newlines.
1225 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1226 non-empty line. Fixes confusing cursor motion with arrow keys at
1227 the beginning of a line that starts with whitespace.
1229 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1231 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1234 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1236 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1239 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1241 * xdisp.c (display_line): Record maximum and minimum buffer
1242 positions even if no glyphs were produced (e.g., by a zero-width
1243 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1244 buffer positions that will be removed from the glyph row because
1246 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1247 column is beyond frame width: don't subtract 1 "pixel" when
1248 computing width of the stretch.
1249 (reseat_at_next_visible_line_start): Undo the change made on
1250 2011-09-17 that saved paragraph information and restored it after
1251 the call to `reseat'. (Bug#9545)
1253 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1255 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1256 and turn window cursor on if cleared (Bug#9415).
1258 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1260 * search.c (boyer_moore): Take unibyte characters from pattern
1261 literally. (Bug#9458)
1263 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1265 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1267 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1269 Fix minor problem found by static checking.
1270 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1271 initialized, to pacify gcc -Wuninitialized.
1273 * fileio.c: Report proper errno when syscall falls.
1274 (Finsert_file_contents): Save and restore errno,
1275 so that report_file_error outputs the correct diagnostic.
1276 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1278 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1280 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1282 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1284 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1285 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1287 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1289 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1290 about the current paragraph and restore it after the call to reseat.
1292 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1293 (bidi_find_paragraph_start): Search back for paragraph beginning
1294 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1295 (bidi_move_to_visually_next): Only trigger paragraph-related
1296 computations when the last character is a newline or at EOB, not
1297 just any NEUTRAL_B. (Bug#9470)
1299 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1300 truncated lines if point is covered by a display string. (Bug#9524)
1302 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1304 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1305 (cons_to_x_long): New function.
1306 (lisp_data_to_selection_data): Use it. Correct the test for
1307 short-versus-long data; it was negated. Break out of vector
1308 loop, for efficiency, when a long datum is discovered.
1310 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1312 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1314 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1316 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1317 GCC PR/17406) by declaring this function with external scope.
1319 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1321 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1322 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1324 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1326 * editfns.c (Fformat): Correctly handle text properties on "%%".
1328 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1330 * xterm.c (x_draw_composite_glyph_string_foreground):
1331 * w32term.c (x_draw_composite_glyph_string_foreground):
1332 * term.c (encode_terminal_code):
1333 * composite.c (composition_update_it, get_composition_id):
1334 * xdisp.c (get_next_display_element)
1335 (fill_composite_glyph_string): Add comments about special meaning
1336 of TAB characters in a composition.
1338 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1340 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1341 This occurs when processing a multibyte format.
1342 Problem reported by Wolfgang Jenker.
1344 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1346 * xdisp.c (try_cursor_movement): Only check for exact match if
1347 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1349 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1351 Remove unused external symbols.
1352 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1353 * xdisp.c (calc_pixel_width_or_height): Now static.
1354 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1355 * indent.c (check_display_width):
1356 * w32term.c: Fix comment to match code.
1357 * xterm.c, xterm.h (x_catching_errors): Remove.
1359 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1361 * xselect.c: Use signed conversions more consistently (Bug#9498).
1362 (selection_data_to_lisp_data): Assume incoming selection data are
1363 signed integers, not unsigned. This is to be consistent with
1364 outgoing selection data, which was modified to use signed integers
1365 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1366 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1367 expects long, not unsigned long.
1369 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1371 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1372 computation of loop end. Reported by Johan Bockgård
1375 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1377 * frame.c (Fother_visible_frames_p): Function deleted.
1379 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1381 * indent.c (compute_motion): Process display vector front to back
1382 rather than the other way around. (Bug#2496)
1384 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1386 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1388 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1390 * minibuf.c (Fread_from_minibuffer): Doc fix.
1392 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1394 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1395 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1397 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1399 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1400 value for non-existent files.
1402 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1404 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1405 set its "size" to -1. This will set the modtime_size field of
1406 the corresponding buffer to -1, which is what
1407 verify-visited-file-modtime expects for files that do not exist.
1410 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1412 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1414 * lisp.h: ... from here. push_key_description is no longer
1415 defined in keyboard.c, so its declaration should not be in
1416 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1417 logically belongs with push_key_description.
1419 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1421 * buffer.h: Include <sys/types.h> instead of <time.h>.
1422 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1423 Problem reported by Herbert J. Skuhra.
1425 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1427 * xml.c (parse_region): Make the parsing work for
1428 non-comment-starting XML files again (bug#9144).
1430 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1432 * image.c (gif_load): Fix calculation of bottom and right corner.
1435 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1437 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1438 redisplay in small windows.
1440 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1442 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1444 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1446 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1447 Operate on live windows only.
1449 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1451 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1453 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1455 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1456 only under bidi iteration.
1458 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1460 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1462 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1464 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1465 Without this fix, the command to link temacs failed due to an
1466 undefined symbol __builtin_isnan. This is because
1467 /usr/include/iso/math_c99.h #defines isnan(x) to
1468 __builtin_isnan(x), but the bundled gcc, which identifies itself
1469 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1471 * floatfns.c (isnan): #undef, and then #define to a clone of
1473 (Fisnan): Always define, since it's always available now.
1474 (syms_of_floatfns): Always define isnan at the Lisp level.
1476 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1478 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1480 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1482 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1483 The previous code assumed that file offsets (off_t values) fit in
1484 EMACS_INT variables, which is not true on typical 32-bit hosts.
1485 The code messed up by falsely reporting buffer overflow in cases
1486 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1487 when "big" contains more than 2**29 bytes, even though this
1488 inserts just one byte and does not overflow the buffer.
1489 (Finsert_file_contents): Store file offsets as off_t
1490 values, not as EMACS_INT values. Check for overflow when
1491 converting between EMACS_INT and off_t. When checking for
1492 buffer overflow or for overlap, take the offsets into account.
1493 Don't use EMACS_INT for small values where int suffices.
1494 When checking for overlap, fix a typo: ZV was used where
1495 ZV_BYTE was intended.
1496 (Fwrite_region): Don't assume off_t fits into 'long'.
1497 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1499 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1501 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1503 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1505 sprintf-related integer and memory overflow issues (Bug#9412).
1507 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1508 (esprintf, exprintf, evxprintf): New functions.
1509 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1510 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1511 (modify_event_symbol): Do not assume that the length of
1512 name_alist_or_stem is safe to alloca and fits in int.
1513 (Fexecute_extended_command): Likewise for function name and binding.
1514 (Frecursion_depth): Wrap around reliably on integer overflow.
1515 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1516 since some callers pass EMACS_INT values.
1517 (Fsingle_key_description): Don't crash if symbol name contains more
1518 than MAX_ALLOCA bytes.
1519 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1520 (get_minibuffer): Arg is now EMACS_INT, not int.
1521 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1522 (esprintf, exprintf, evxprintf): New decls.
1523 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1525 * dbusbind.c (signature_cat): New function.
1526 (xd_signature, Fdbus_register_signal):
1527 Do not overrun buffer; instead, report string overflow.
1529 * dispnew.c (add_window_display_history): Don't overrun buffer.
1530 Truncate instead; this is OK since it's just a log.
1532 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1533 even if the time zone offset is outlandishly large.
1534 Don't mishandle offset == INT_MIN.
1536 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1537 when creating daemon; the previous buffer-overflow check was incorrect.
1539 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1540 which has the guts of the old verror function.
1542 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1543 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1545 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1546 (font_unparse_xlfd): Don't blindly alloca long strings.
1547 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1548 fits in int, when using sprintf. Use single snprintf to count
1549 length of string rather than counting it via multiple sprintfs;
1550 that's simpler and more reliable.
1551 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1552 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1553 sprintf, in case result does not fit in int.
1555 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1556 (fontset_from_font): Print it.
1558 * frame.c (tty_frame_count): Now printmax_t, not int.
1559 (make_terminal_frame, set_term_frame_name): Print it.
1560 (x_report_frame_params): In X, window IDs are unsigned long,
1561 not signed long, so print them as unsigned.
1562 (validate_x_resource_name): Check for implausibly long names,
1563 and don't assume name length fits in 'int'.
1564 (x_get_resource_string): Don't blindly alloca invocation name;
1565 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1568 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1569 (xg_check_special_colors, xg_set_geometry):
1570 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1572 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1573 Use esprintf, not sprintf, in case result does not fit in int.
1575 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1576 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1577 it as a large positive number.
1578 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1579 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1581 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1582 in case result does not fit in int.
1584 * print.c (float_to_string): Detect width overflow more reliably.
1585 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1586 buffer overrun. Don't assume list length fits in 'int'. Treat
1587 print length of 0 as 0, not as infinity; to be consistent with other
1588 uses of print length in this function. Don't overflow print length
1589 index. Don't assume hash table size fits in 'long', or that
1590 vectorlike size fits in 'unsigned long'.
1592 * process.c (make_process): Use printmax_t, not int, to format
1593 process-name gensyms.
1595 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1597 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1598 to avoid potential buffer overrun.
1600 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1601 if X resource line is longer than 512 bytes.
1603 * xfns.c (x_window): Make sprintf buffer a bit bigger
1604 to avoid potential buffer overrun.
1606 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1608 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1610 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1612 Integer overflow fixes for scrolling, etc.
1613 Without these, Emacs silently mishandles large integers sometimes.
1614 For example, "C-u 4294967297 M-x recenter" was treated as if
1615 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1617 * xdisp.c (try_window_id): Check Emacs fixnum range before
1618 converting to 'int'.
1620 * window.c (window_scroll_line_based, Frecenter):
1621 Check that an Emacs fixnum is in range before assigning it to 'int'.
1622 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1623 values converted from Emacs fixnums.
1624 (Frecenter): Don't wrap around a line count if it is out of 'int'
1625 range; instead, treat it as an extreme value.
1626 (Fset_window_configuration, compare_window_configurations):
1627 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1629 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1630 that can exceed INT_MAX. Check that EMACS_INT value is in range
1631 before assigning it to the (possibly-narrower) index.
1632 (match_limit): Don't assume that a fixnum can fit in 'int'.
1634 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1637 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1638 (Fvertical_motion): Don't wrap around LINES values that don't fit
1639 in 'int'. Instead, treat them as extreme values. This is good
1640 enough for windows, which can't have more than INT_MAX lines anyway.
1642 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1644 * Require libxml/parser.h to avoid compilation warning.
1646 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1648 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1649 since this reportedly can destroy thread storage.
1651 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1653 * syntax.c (find_defun_start): Update all cache variables if
1654 exiting early (Bug#9401).
1656 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1658 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1660 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1661 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1662 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1664 * term.c (tty_append_glyph): New function.
1665 (produce_stretch_glyph): Static function and its prototype deleted.
1667 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1670 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1672 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1673 when checking :margin (Bug#9390).
1674 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1675 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1676 so that the name doesn't mislead. All uses changed.
1678 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1680 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1683 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1685 * xdisp.c (move_it_to): Don't bail out early when reaching
1686 position beyond to_charpos, if we are scanning backwards.
1687 (move_it_vertically_backward): When DY == 0, make sure we get to
1688 the first character in the line after the newline.
1690 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1692 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1693 (ccl_driver): Do not generate an out-of-range pointer.
1694 (Fccl_execute_on_string): Remove unnecessary check for
1695 integer overflow, noted by Stefan Monnier in
1696 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1697 Remove a FIXME that didn't need fixing.
1698 Simplify the newly-introduced buffer reallocation code.
1700 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1702 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1704 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1706 Integer and memory overflow issues (Bug#9196).
1708 * doc.c (get_doc_string): Rework so that
1709 get_doc_string_buffer_size is the actual buffer size, rather than
1710 being 1 less than the actual buffer size; this makes xpalloc more
1713 * image.c (x_allocate_bitmap_record, cache_image):
1714 * xselect.c (Fx_register_dnd_atom):
1715 Simplify previous changes by using xpalloc.
1717 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1718 since either will do and ptrdiff_t is convenient with xpalloc.
1720 * charset.c (charset_table_size)
1721 (struct charset_sort_data.priority): Now ptrdiff_t.
1722 (charset_compare): Don't overflow if priorities differ greatly.
1723 (Fsort_charsets): Don't assume list length fits in int.
1724 Check for size-calculation overflow when allocating sort data.
1725 (syms_of_charset): Allocate an initial charset table that is
1726 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1728 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1730 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1731 The actual value is always <= INT_MAX, and leaving it unsigned made
1732 overflow checking harder.
1734 * dispextern.h (struct glyph_matrix.rows_allocated)
1735 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1736 with xpalloc. The values are still always <= INT_MAX.
1738 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1740 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1741 (SAFE_NALLOCA): New macro.
1743 * region-cache.c (struct boundary.pos, find_cache_boundary)
1744 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1745 (set_cache_region, invalidate_region_cache)
1746 (revalidate_region_cache, know_region_cache, region_cache_forward)
1747 (region_cache_backward, pp_cache):
1748 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1749 so that ptrdiff_t * can be passed to xpalloc.
1750 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1751 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1752 (pp_cache): Don't assume cache_len fits in int.
1753 * region-cache.h: Adjust extern decls to match.
1755 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1756 EMACS_INT, since either will do, for xpalloc.
1758 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1759 (xnmalloc, xnrealloc, xpalloc): New functions.
1761 * bidi.c (bidi_shelve_header_size): New constant.
1762 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1763 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1765 * bidi.c (bidi_cache_shrink):
1766 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1768 Don't update size of array until after memory allocation succeeds,
1769 because xmalloc/xrealloc may not return.
1770 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1771 now that we have proper integer overflow checking.
1772 (record_overlay_string, overlay_strings): Catch overflows when
1773 calculating size of overlay_str_buf.
1775 * callproc.c (Fcall_process): Check for size overflow when
1776 calculating size of args2.
1777 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1778 Normally we prefer signed values, but sticking with ptrdiff_t would
1779 require adding more-complicated checks.
1781 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1782 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1783 Redo buffer-overflow calculations to avoid integer overflow.
1784 Add a FIXME comment where memory seems to be over-allocated.
1786 * character.c (Fstring): Check for size-calculation overflow.
1788 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1789 unnecessary integer overflow. Check for size overflow.
1790 (encode_coding_object): Don't update size until xmalloc succeeds.
1792 * composite.c (get_composition_id): Check for overflow in glyph
1793 length calculations.
1795 Integer and memory overflow fixes for display code.
1796 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1797 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1798 (scrolling_window): Check for overflow in size calculations.
1799 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1800 Don't assume glyph table len fits in int.
1801 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1802 (row_table_size): Now ptrdiff_t, not int.
1803 (scrolling_window): Avoid overflow in size calculations.
1804 Don't update size until allocation succeeds.
1805 * fns.c (concat): Check for overflow in size calculations.
1806 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1807 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1808 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1810 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1811 (get_doc_string): Check for size calculation overflow.
1812 Don't update size until allocation succeeds.
1813 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1814 EMACS_INT, where ptrdiff_t will do.
1815 (Fsubstitute_command_keys): Check for string overflow.
1817 * editfns.c (set_time_zone_rule): Don't assume environment length
1819 (message_length): Now ptrdiff_t, not int.
1820 (Fmessage_box): Don't update size until allocation succeeds.
1821 Don't assume message length fits in int.
1822 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1824 * emacs.c (main): Do not reallocate argv, since there is a null at
1825 the end that can be overwritten, and this way there's no need to
1826 worry about size-calculation overflow.
1827 (sort_args): Check for size-calculation overflow.
1829 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1831 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1833 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1834 (x_set_scroll_bar_width, x_figure_window_size):
1835 Check for integer overflow.
1836 (x_set_alpha): Do not assume XINT fits in int.
1838 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1839 This is for the members text_lines, text_cols, total_lines, total_cols,
1840 where the system imposes an 'int' limit.
1842 * fringe.c (Fdefine_fringe_bitmap):
1843 Don't update size until alloc works.
1845 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1846 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1848 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1849 Check for size-calculation overflow.
1850 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1851 do, as we prefer signed integers.
1852 (id_to_widget.max_size, id_to_widget.used)
1853 (xg_store_widget_in_map, xg_remove_widget_from_map)
1854 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1855 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1856 Use and return ptrdiff_t, not int.
1857 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1858 * gtkutil.h: Change prototypes to match the above.
1860 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1861 are duplicate now that they've been promoted to lisp.h.
1862 (x_allocate_bitmap_record, x_alloc_image_color)
1863 (make_image_cache, cache_image, xpm_load):
1864 Don't update size until alloc is done.
1865 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1867 Check for size calculation overflow.
1868 (ct_colors_allocated_max): New constant.
1869 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1872 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1873 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1874 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1875 Use ptrdiff_t, not int, to count maps.
1876 (read_char_minibuf_menu_prompt): Check for overflow in size
1877 calculations. Don't update size until allocation succeeds.
1878 Redo calculations to avoid overflow.
1879 * keyboard.h: Change prototypes to match the above.
1881 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1883 (current_minor_maps): Check for size calculation overflow.
1884 * keymap.h: Change prototypes to match the above.
1886 * lread.c (read1, init_obarray): Don't update size until alloc done.
1888 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1889 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1891 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1892 Now ptrdiff_t, not int.
1893 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1894 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1896 * process.c (Fnetwork_interface_list): Check for overflow
1897 in size calculation.
1899 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1901 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1902 overflow. Don't bother calling xmalloc when xrealloc will do.
1904 * search.c (Freplace_match): Check for size calculation overflow.
1905 (Fset_match_data): Don't assume list lengths fit in 'int'.
1907 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1908 for command line length. Do not attempt to address one before the
1909 beginning of an array, as that's not portable.
1911 * term.c (max_frame_lines): Remove; unused.
1912 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1914 (encode_terminal_code, calculate_costs): Check for size
1915 calculation overflow.
1916 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1917 table lengths and related sizes. Don't update size until alloc
1918 done. Redo calculations to avoid overflow.
1919 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1921 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1922 subtracting pointers.
1923 (gobble_line): Check for overflow more carefully. Don't update size
1926 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1927 Don't update size until alloc done.
1928 Redo size calculations to avoid overflow.
1929 Check for size calculation overflow.
1930 (main) [DEBUG]: Fix typo in invoking tparam1.
1932 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1933 Use ptrdiff_t, not int, for sizes.
1934 (store_mode_line_noprop_char): Don't update size until alloc done.
1936 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1937 Use ptrdiff_t, not int, for sizes.
1938 (Finternal_make_lisp_face, cache_face):
1939 Check for size calculation overflow.
1940 (cache_face): Treat size calculation overflows as if they were
1941 memory exhaustion (the usual treatment), rather than aborting.
1943 * xfns.c (x_encode_text, x_set_name_internal)
1944 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1945 sizes, since they can exceed INT_MAX in size. Check for size
1946 calculation overflow.
1948 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1949 (xg_select): Check for size calculation overflow.
1950 Don't update size until alloc done.
1952 * xrdb.c (get_environ_db): Don't assume path length fits in int,
1953 as sprintf is limited to int lengths.
1955 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1956 (X_LONG_MIN): New macros.
1957 Use them to make the following changes clearer.
1958 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1959 This change doesn't affect the value now, but it may help remind
1960 future maintainers not to raise the value too much later.
1961 (SELECTION_QUANTUM): Remove, replacing with ...
1962 (selection_quantum): ... new function, which avoids overflow.
1964 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1965 assumption that selection length fits in 'int'.
1966 (x_reply_selection_request, x_handle_selection_request)
1967 (x_get_window_property, receive_incremental_selection)
1968 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1969 (lisp_data_to_selection_data, clean_local_selection_data):
1970 Use ptrdiff_t, not int, to record length of selection.
1971 (x_reply_selection_request, x_get_window_property)
1972 (receive_incremental_selection, x_property_data_to_lisp):
1973 Redo calculations to avoid overflow.
1974 (x_reply_selection_request): When sending hint, ceiling it at
1975 X_LONG_MAX rather than relying on wraparound overflow to send
1977 (x_get_window_property, receive_incremental_selection)
1978 (lisp_data_to_selection_data, x_property_data_to_lisp):
1979 Check for size-calculation overflow.
1980 (x_get_window_property, receive_incremental_selection)
1981 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1982 Don't store size until memory allocation succeeds.
1983 (x_get_window_property): Plug memory leak on memory exhaustion.
1984 Don't double-block input; malloc is safe here. Don't assume 2**34
1985 - 4 fits in unsigned long. Add an xassert to check
1986 XGetWindowProperty overflow. Be more careful about overflow
1987 calculations, and distinguish size from memory overflow better.
1988 (receive_incremental_selection): When tracing, don't assume
1989 unsigned int is less than INT_MAX.
1990 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1991 harmful) conversions of unsigned short to int.
1992 (lisp_data_to_selection_data): Don't assume that integers
1993 in the range -65535 through -1 fit in an X unsigned short.
1994 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1995 result parameters unless successful. Rely on cons_to_unsigned
1996 to report problems with elements; the old code wasn't right anyway.
1997 (x_check_property_data): Check for int overflow; we cannot use
1998 a wider type due to X limits.
1999 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2001 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2003 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2004 (x_term_init): Check for size calculation overflow.
2005 (x_color_cells): Don't store size until memory allocation succeeds.
2006 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2007 Don't assume alloca size is less than MAX_ALLOCA.
2008 (x_term_init): Don't assume length fits in int (sprintf is limited
2011 Use ptrdiff_t for composition IDs.
2012 * character.c (lisp_string_width):
2013 * composite.c (composition_table_size, n_compositions)
2014 (get_composition_id, composition_gstring_from_id):
2015 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2016 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2017 * window.c (Frecenter):
2018 Use ptrdiff_t, not int, for composition IDs.
2019 * composite.c (get_composition_id): Check for integer overflow.
2020 * composite.h: Adjust prototypes to match the above changes.
2022 Use ptrdiff_t for hash table indexes.
2023 * category.c (hash_get_category_set):
2024 * ccl.c (ccl_driver):
2025 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2026 * coding.c (coding_system_charset_list, detect_coding_system):
2027 * coding.h (struct coding_system.id):
2028 * composite.c (get_composition_id, gstring_lookup_cache):
2029 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2030 * image.c (xpm_get_color_table_h):
2031 * lisp.h (hash_lookup, hash_put):
2032 * minibuf.c (Ftest_completion):
2033 Use ptrdiff_t for hash table indexes, not int (which is too
2034 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2035 32-bit --with-wide-int hosts).
2037 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2038 Add a FIXME comment about memory leaks.
2039 (syms_of_charset): Don't assume xmalloc returns.
2041 Don't assume that stated character widths fit in int.
2042 * character.c (Fchar_width, c_string_width, lisp_string_width):
2043 * character.h (CHAR_WIDTH):
2044 * indent.c (MULTIBYTE_BYTES_WIDTH):
2045 Use sanitize_char_width to avoid undefined and/or bad behavior
2046 with outlandish widths.
2047 * character.h (sanitize_tab_width): Rename from sanitize_width,
2048 now that we have two such functions. All uses changed.
2049 (sanitize_char_width): New inline function.
2051 Don't assume that tab-width fits in int.
2052 * character.h (sanitize_width): New inline function.
2053 (SANE_TAB_WIDTH): New macro.
2054 (ASCII_CHAR_WIDTH): Use it.
2055 * indent.c (sane_tab_width): Remove. All uses replaced by
2056 SANE_TAB_WIDTH (current_buffer).
2057 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2059 * fileio.c: Integer overflow issues with file modes.
2060 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2062 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2063 Remove unreachable code.
2064 (read_hex, load_charset_map_from_file): Check for integer overflow.
2066 * xterm.c: don't go over XClientMessageEvent limit
2067 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2068 (x_send_scroll_bar_event): Likewise. Check that the size does not
2069 exceed limits imposed by XClientMessageEvent, as well as the usual
2070 ptrdiff_t and size_t limits.
2072 * keyboard.c: Overflow, signedness and related fixes.
2073 (make_lispy_movement): Use same integer type in forward decl
2074 that is used in the definition.
2075 (read_key_sequence, keyremap_step):
2076 Change bufsize argument back to int, undoing my 2011-03-30 change.
2077 We prefer signed types, and int is wide enough here.
2078 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2079 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2080 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2081 length, not size_t. Use ptrdiff_t for index, not int.
2082 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2083 possibility of integer overflow.
2085 Overflow, signedness and related fixes for images.
2087 * dispextern.h (struct it.stack[0].u.image.image_id)
2088 (struct_it.image_id, struct image.id, struct image_cache.size)
2089 (struct image_cache.used, struct image_cache.ref_count):
2090 * gtkutil.c (update_frame_tool_bar):
2091 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2092 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2093 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2094 * nsmenu.m (update_frame_tool_bar):
2095 * xdisp.c (calc_pixel_width_or_height):
2096 * xfns.c (image_cache_refcount):
2097 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2098 on typical 64-bit hosts.
2100 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2101 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2102 Omit unnecessary casts to int.
2103 (parse_image_spec): Check that integers fall into 'int' range
2104 when the callers expect that.
2105 (image_ascent): Redo ascent calculation to avoid int overflow.
2106 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2107 (lookup_image): Remove unnecessary tests.
2108 (xbm_image_p): Locals are now of int, not EMACS_INT,
2109 since parse_image_check makes sure they fit into int.
2110 (png_load, gif_load, svg_load_image):
2111 Prefer int to unsigned where either will do.
2112 (tiff_handler): New function, combining the cores of the
2113 old tiff_error_handler and tiff_warning_handler.
2114 This function is rewritten to use vsnprintf and thereby avoid
2115 stack buffer overflows. It uses only the features of vsnprintf
2116 that are common to both POSIX and native Microsoft.
2117 (tiff_error_handler, tiff_warning_handler): Use it.
2118 (tiff_load, gif_load, imagemagick_load_image):
2119 Don't assume :index value fits in 'int'.
2120 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2121 (imagemagick_load_image): Check that crop parameters fit into
2122 the integer types that MagickCropImage accepts. Don't assume
2123 Vimagemagick_render_type has a nonnegative value. Don't assume
2124 size_t fits in 'long'.
2125 (gs_load): Use printmax_t to print the widest integers possible.
2126 Check for integer overflow when computing image height and width.
2128 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2130 * xdisp.c (redisplay_window): Don't force window start if point
2131 will be invisible in the resulting window. (Bug#9324)
2133 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2135 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2136 the display spec is of the form `(space ...)'.
2137 (handle_display_spec): Return the value returned by
2138 handle_single_display_spec, not just 1 or zero.
2139 (handle_single_display_spec): If the display spec is of the form
2140 `(space ...)', and specifies display in the text area, return 2
2142 (try_cursor_movement): Check for the need to scroll more
2143 accurately, and prefer exact match for point under bidi.
2144 Don't advance `row' beyond the last row of the window.
2146 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2147 into disp_prop; all users changed.
2149 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2150 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2151 for the text covered by the display property.
2153 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2155 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2156 Change return value to nil.
2157 (Frecord_buffer): Delete unused function.
2159 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2161 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2162 buffers, return left-to-right.
2163 (set_cursor_from_row): Consider candidate row a win if its glyph
2164 represents a newline and point is on that newline. Fixes cursor
2165 positioning on the newline at EOL of R2L text within L2R
2166 paragraph, and vice versa.
2167 (try_cursor_movement): Check continued rows, in addition to
2168 continuation rows. Fixes unwarranted scroll when point enters a
2169 continued line of R2L text within an L2R paragraph, or vice versa.
2170 (cursor_row_p): Consider the case of point being equal to
2171 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2172 from the end of a short line to the beginning of a continued line
2173 of R2L text within L2R paragraph.
2174 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2175 composed characters.
2177 * bidi.c (bidi_check_type): Use xassert.
2178 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2181 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2183 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2186 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2188 * nsfont.m (ns_otf_to_script): Fix typo.
2190 2011-08-22 Kenichi Handa <handa@m17n.org>
2192 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2193 extra slot even if the purpose is char-code-property-table.
2195 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2197 * xdisp.c (redisplay_window): When computing centering_position,
2198 account for the height of the header line. (Bug#8874)
2200 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2201 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2202 candidate is selected by the mouse, and that candidate has a
2203 composed character under the mouse.
2205 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2206 coordinates reported by pos-visible-in-window-p for a composed
2207 character in column zero.
2209 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2211 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2213 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2215 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2216 consider it a hit if to_charpos is anywhere in the range of the
2217 composed buffer positions.
2219 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2221 * image.c (gif_load): Don't assume that each subimage has the same
2222 dimensions as the base image. Handle disposal method that is
2223 "undefined" by the gif spec (Bug#9335).
2225 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2227 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2228 (Fcondition_case): Document `debug' symbol in error handler.
2230 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2232 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2233 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2234 from an Org mode buffer to a Speedbar frame.
2236 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2237 a composition, take its buffer position from IT->cmp_it.charpos.
2238 Fixes cursor positioning at the beginning of a line that begins
2239 with a composed character.
2241 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2243 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2244 character bidirectional type, use STRONG_L instead. Fixes crashes
2245 in a buffer produced by `describe-categories'.
2247 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2248 members before the level stack, so they would be saved and
2249 restored when copying iterator state. Fixes incorrect reordering
2250 around TABs covered by display properties.
2252 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2254 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2256 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2258 * eval.c (internal_condition_case, internal_condition_case_1)
2259 (internal_condition_case_2, internal_condition_case_n):
2260 Remove unnecessary aborts (Bug#9081).
2262 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2264 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2265 has no `load' handler, try opening the file locally. (Bug#9311)
2267 2011-08-16 Ken Brown <kbrown@cornell.edu>
2269 * gmalloc.c: Expand comment.
2271 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2273 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2274 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2276 2011-08-16 Ken Brown <kbrown@cornell.edu>
2278 Fix memory allocation problems in Cygwin build (Bug#9273).
2280 * unexcw.c ( __malloc_initialized): Declare external variable.
2281 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2283 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2285 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2287 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2289 [CYGWIN] (special_realloc): New function.
2290 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2291 requests to realloc storage in the static heap.
2293 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2295 * bidi.c (bidi_initialize): Remove unused local.
2297 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2300 * biditype.h: Remove file.
2301 * makefile.w32-in ($(BLD)/bidi.$(O)):
2302 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2304 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2306 * chartab.c: Improve commentary for the uniprop_table API.
2308 * bidi.c (bidi_paragraph_init): Support zero value of
2309 bidi_ignore_explicit_marks_for_paragraph_level.
2310 (bidi_initialize): Use uniprop_table instead of including
2311 biditype.h and bidimirror.h.
2313 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2314 coordinates of the iterator when restoring from ppos_it.
2317 2011-08-14 Kenichi Handa <handa@m17n.org>
2319 * process.c (create_process): Call setup_process_coding_systems
2320 after the pid of the process is set to -1 (Bug#8162).
2322 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2324 * xdisp.c (move_it_in_display_line_to): Don't invoke
2325 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2326 ppos_it. Fixes vertical cursor motion when line beginning is
2327 covered by an image. (Bug#9296)
2329 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2331 * nsterm.h (ns_run_ascript): Declare.
2332 (NSAPP_DATA2_RUNASSCRIPT): Define.
2334 * nsfns.m (as_script, as_result, as_status): New static variables.
2335 (ns_run_ascript): New function.
2336 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2337 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2338 the event loop. Get status from as_status (Bug#7276).
2340 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2341 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2342 the event loop (Bug#7276).
2344 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2346 * gnutls.c (QCgnutls_bootprop_priority)
2347 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2348 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2349 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2350 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2351 (QCgnutls_bootprop_verify_hostname_error)
2352 (QCgnutls_bootprop_callbacks_verify): Rename from
2353 Qgnutls_bootprop_..., all uses changed.
2355 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2358 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2360 * xfaces.c (Qframe_set_background_mode): Now static.
2361 * dispextern.h (Qframe_set_background_mode): Remove decl.
2363 * process.c (Fnetwork_interface_info): Declare local only if needed.
2365 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2367 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2368 (Fnetwork_interface_list): Allocate in increments of bytes instead
2369 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2370 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2372 (struct ifflag_def): notrailers is smart on OSX.
2373 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2374 Get hardware address with getifaddrs if available.
2376 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2378 * xdisp.c (iterate_out_of_display_property): xassert that
2379 IT->position is set to within IT->object's boundaries. Break from
2380 the loop as soon as EOB is reached; avoids infloops in redisplay
2381 when IT->position is set up wrongly due to some bug.
2382 Set IT->current to match the bidi iterator unconditionally.
2383 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2384 entry. Force push_it to save on the stack the current
2385 buffer/string position, to be restored by pop_it. Fix flags in
2386 the iterator structure wrt the object coming from a display
2387 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2388 properties. (Bug#9284)
2390 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2392 * fontset.c (fontset_get_font_group): Add proper type checks.
2395 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2397 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2398 and LC_VERSION_MIN_MACOSX.
2399 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2400 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2402 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2404 * xdisp.c (forward_to_next_line_start): Allow to use the
2405 no-display-properties-and-no-overlays under bidi display.
2406 Set disp_pos in the bidi iterator to avoid searches for display
2407 properties and overlays.
2409 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2411 * editfns.c (Fset_time_zone_rule): Document relationship with the
2414 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2415 the font entity extracted from the cache (Bug#8109).
2417 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2419 * composite.c (autocmp_chars): Don't reset point. That is done by
2420 restore_point_unwind (Bug#5984).
2422 2011-08-07 Juri Linkov <juri@jurta.org>
2424 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2425 to show the arg `TIME' instead of `TIMEVAL'.
2427 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2429 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2430 display property strides EOL and includes a newline, as in
2431 longlines-mode. (Bug#9254)
2432 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2433 word-wrap under bidirectional display. (Bug#9224)
2435 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2436 is non-zero, even if the data buffer is NULL. Fixes a crash in
2437 vertical-motion with longlines-mode. (Bug#9254)
2439 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2441 * bidi.c <bidi_cache_total_alloc>: Now static.
2442 (bidi_initialize): Initialize bidi_cache_total_alloc.
2444 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2447 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2448 amount allocated this far in `bidi_cache_total_alloc'.
2449 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2450 non-zero, only free the data buffer without restoring the cache
2451 contents. All callers changed.
2453 * dispextern.h (bidi_unshelve_cache): Update prototype.
2455 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2456 (move_it_in_display_line, move_it_to)
2457 (move_it_vertically_backward, move_it_by_lines): Replace the call
2458 to xfree to an equivalent call to bidi_unshelve_cache.
2459 (move_it_in_display_line_to): Fix logic of returning
2460 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2462 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2464 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2465 came from a string character with a `cursor' property. (Bug#9229)
2467 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2469 * Makefile.in (LIB_PTHREAD): New variable.
2470 (LIBES): Add LIB_PTHREAD (Bug#9216).
2472 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2473 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2475 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2477 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2479 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2481 * xterm.c (x_find_topmost_parent): New function.
2482 (x_set_frame_alpha): Find topmost parent window with
2483 x_find_topmost_parent and set the property there also (bug#9181).
2484 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2486 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2488 * callproc.c (Fcall_process): Avoid vfork clobbering
2489 the local vars buffer, coding_systems, current_dir.
2491 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2493 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2495 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2497 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2498 so that it is not optimized away.
2500 * xdisp.c (compute_display_string_pos): Remove unused local.
2502 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2504 Fix slow cursor motion and scrolling in large buffers with
2505 selective display, like Org Mode buffers. (Bug#9218)
2507 * dispextern.h (struct bidi_it): New member disp_prop_p.
2509 * xdisp.c: Remove one-slot cache of display string positions.
2510 (compute_display_string_pos): Accept an additional argument
2511 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2512 for a display string or property. If found, set DISP_PROP_P
2515 * bidi.c (bidi_fetch_char): Accept an additional argument
2516 DISP_PROP_P, and pass it to compute_display_string_pos.
2517 Only handle text covered by a display string if DISP_PROP_P is returned
2518 non-zero. All callers of bidi_fetch_char changed.
2520 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2522 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2524 2010-12-03 Don March <don@ohspite.net>
2526 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2527 last character M-[char] is translated to ESC [char] (bug#7541).
2529 2011-08-02 Kenichi Handa <handa@m17n.org>
2531 * lisp.h (uniprop_table): Extern it.
2533 * chartab.c (uniprop_table): Make it non-static.
2535 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2537 * xdisp.c (forward_to_next_line_start): Accept additional argument
2538 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2540 (reseat_at_next_visible_line_start): Use the bidi iterator state
2541 returned by forward_to_next_line_start to restore the state of
2542 it->bidi_it after backing up to previous newline. (Bug#9212)
2544 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2546 * regex.c (re_comp): Protoize.
2547 (re_exec): Fix return type.
2548 (regexec): Fix type of `ret'. (Bug#9203)
2550 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2552 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2553 This is needed if max-image-size is a floating-point number.
2555 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2557 * print.c (print_object): Print empty symbol as ##.
2559 * lread.c (read1): Read ## as empty symbol.
2561 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2563 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2564 setting frame foreground color (Bug#9175).
2565 (x_set_background_color): Likewise.
2567 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2568 contents (Bug#9176).
2569 (EmacsTooltip -init): Remove bezels and add shadows to
2572 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2573 or scroll bar (Bug#8470).
2575 * nsfont.m (nsfont_open): Remove assignment to voffset and
2576 unnecessary vars hshink, expand, hd, full_height, min_height.
2577 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2579 * nsterm.h (nsfont_info): Remove voffset field.
2581 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2583 Implement strike-through and overline on NextStep (Bug#8863).
2585 * nsfont.m (nsfont_open): Use underline position provided by font,
2586 instead of hard-coded value of 2.
2587 (nsfont_draw): Call ns_draw_text_decoration instead.
2589 * nsterm.h: Add declaration for ns_draw_text_decoration.
2591 * nsterm.m (ns_draw_text_decoration): New function for drawing
2592 underline, overline, and strike-through.
2593 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2594 ns_draw_text_decoration. Change treatment of cursor drawing to
2595 accommodate underlining, etc.
2597 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2599 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2602 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2604 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2605 Without this fix, if a signal arrives just after memory fills up,
2606 'malloc' might be invoked reentrantly.
2608 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2609 In other words, assume that every image size is allowed, on non-X
2610 hosts. This assumption is probably wrong, but it lets Emacs compile.
2612 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2614 * regex.c (re_iswctype): Convert return values to boolean.
2616 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2618 * xdisp.c (compute_display_string_pos): Don't use cached display
2619 string position if the buffer had its restriction changed.
2622 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2624 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2626 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2628 Integer signedness and overflow and related fixes. (Bug#9079)
2630 * bidi.c: Integer size and overflow fixes.
2631 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2632 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2633 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2634 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2635 (bidi_find_other_level_edge):
2636 Use ptrdiff_t instead of EMACS_INT where either will do.
2637 This works better on 32-bit hosts configured --with-wide-int.
2638 (bidi_cache_ensure_space): Check for size-calculation overflow.
2639 Use % rather than repeated addition, for better worst-case speed.
2640 Don't set bidi_cache_size until after xrealloc returns, because it
2642 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2643 (bidi_cache_ensure_space): Also check that the bidi cache size
2644 does not exceed that of the largest Lisp string or buffer. See Eli
2645 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2647 * alloc.c (__malloc_size_t): Remove.
2648 All uses replaced by size_t. See Andreas Schwab's note
2649 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2651 * image.c: Improve checking for integer overflow.
2652 (check_image_size): Assume that f is nonnull, since
2653 it is always nonnull in practice. This is one less thing to
2654 worry about when checking for integer overflow later.
2655 (x_check_image_size): New function, which checks for integer
2656 overflow issues inside X.
2657 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2658 This removes the need for a memory_full check.
2659 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2660 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2661 (xbm_read_bitmap_data): Change locals back to 'int', since
2662 their values must fit in 'int'.
2663 (xpm_load_image, png_load, tiff_load):
2664 Invoke x_create_x_image_and_pixmap earlier,
2665 to avoid much needless work if the image is too large.
2666 (tiff_load): Treat overly large images as if
2667 x_create_x_image_and_pixmap failed, not as malloc failures.
2668 (gs_load): Use x_check_image_size.
2670 * gtkutil.c: Omit integer casts.
2671 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2672 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2674 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2676 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2677 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2678 would wrongly return t on a 64-bit host.
2680 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2681 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2682 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2683 and therefore cause GCC to emit a bogus diagnostic in some cases.
2685 * image.c: Integer signedness and overflow and related fixes.
2686 This is not an exhaustive set of fixes, but it's time to
2687 record what I've got.
2688 (lookup_pixel_color, check_image_size): Remove redundant decls.
2689 (check_image_size): Don't assume that arbitrary EMACS_INT values
2690 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2691 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2692 (tiff_load, imagemagick_load_image):
2693 Check for overflow in size calculations.
2694 (x_create_x_image_and_pixmap): Remove unnecessary test for
2695 xmalloc returning NULL; that can't happen.
2696 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2697 (xpm_color_bucket): Use better integer hashing function.
2698 (xpm_cache_color): Don't possibly over-allocate memory.
2699 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2700 (gif_memory_source):
2701 Use ptrdiff_t, not int or size_t, to record sizes.
2702 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2703 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2704 either works, as we prefer signed integers.
2705 (tiff_read_from_memory, tiff_write_from_memory):
2706 Return tsize_t, not size_t, since that's what the TIFF API wants.
2707 (tiff_read_from_memory): Don't fail simply because the read would
2708 go past EOF; instead, return a short read.
2709 (tiff_load): Omit no-longer-needed casts.
2710 (Fimagemagick_types): Don't assume size fits into 'int'.
2712 Improve hashing quality when configured --with-wide-int.
2713 * fns.c (hash_string): New function, taken from sxhash_string.
2714 Do not discard information about ASCII character case; this
2715 discarding is no longer needed.
2716 (sxhash-string): Use it. Change sig to match it. Caller changed.
2717 * lisp.h: Declare it.
2718 * lread.c (hash_string): Remove, since we now use fns.c's version.
2719 The fns.c version returns a wider integer if --with-wide-int is
2720 specified, so this should help the quality of the hashing a bit.
2722 * emacs.c: Integer overflow minor fix.
2723 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2724 Define only if GNU_LINUX.
2725 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2727 * dispnew.c: Integer signedness and overflow fixes.
2728 Remove unnecessary forward decls, that were a maintenance hassle.
2729 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2731 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2732 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2733 (prepare_desired_row, line_draw_cost):
2734 Use int, not unsigned, where either works.
2735 (save_current_matrix, restore_current_matrix):
2736 Use ptrdiff_t, not size_t, where either works.
2737 (init_display): Check for overflow more accurately, and without
2738 relying on undefined behavior.
2740 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2741 Remove, replacing with the new symbols in lisp.h. All uses changed.
2742 * fileio.c (make_temp_name):
2743 * filelock.c (lock_file_1, lock_file):
2744 * xdisp.c (message_dolog):
2745 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2746 Use pMd etc. instead.
2747 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2748 replacing the pWIDE etc. symbols removed from editfns.c.
2750 * keyboard.h (num_input_events): Now uintmax_t.
2751 This is (very slightly) less likely to mess up due to wraparound.
2754 * buffer.c: Integer signedness fixes.
2755 (alloc_buffer_text, enlarge_buffer_text):
2756 Use ptrdiff_t rather than size_t when either will do, as we prefer
2759 * alloc.c: Integer signedness and overflow fixes.
2760 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2761 (__malloc_size_t): Default to size_t, not to int.
2762 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2763 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2764 Prefer ptrdiff_t to size_t when either would do, as we prefer
2766 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2767 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2768 Now const. Initialize with values that are in range even if char
2770 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2771 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2772 These functions do the right thing with sizes > 2**32.
2773 (check_depth): Now ptrdiff_t, not int.
2774 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2775 Adjust to new way of storing sizes. Check for size overflow bugs
2777 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2778 slightly wrong anyway, as it missed one instance of
2779 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2780 (refill_memory_reserve): Omit needless cast to size_t.
2781 (mark_object_loop_halt): Mark as externally visible.
2783 * xselect.c: Integer signedness and overflow fixes.
2784 (Fx_register_dnd_atom, x_handle_dnd_message):
2785 Use ptrdiff_t, not size_t, since we prefer signed.
2786 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2787 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2788 x_dnd_atoms_size and x_dnd_atoms_length.
2790 * doprnt.c: Prefer signed to unsigned when either works.
2792 * doprnt.c (doprnt):
2794 * xdisp.c (vmessage):
2795 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2796 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2797 prefer signed arithmetic to avoid comparison confusion.
2798 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2799 but is a bit tricky.
2801 Assume freestanding C89 headers, string.h, stdlib.h.
2802 * data.c, doprnt.c, floatfns.c, print.c:
2803 Include float.h unconditionally.
2804 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2805 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2806 * regex.c: Likewise for stddef.h, string.h.
2807 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2808 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2809 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2810 (STDC_HEADERS): Remove obsolete defines.
2811 * sysdep.c: Include limits.h unconditionally.
2813 Assume support for memcmp, memcpy, memmove, memset.
2814 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2815 * regex.c (memcmp, memcpy):
2816 Remove; we assume C89 now.
2818 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2819 (__malloc_safe_bcopy): Remove; no longer needed.
2821 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
2822 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2823 well either way, and we prefer signed to unsigned.
2825 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2827 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2828 closes the connection while we're reading (bug#9182).
2830 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
2832 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2833 are specified (Bug#9168).
2835 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2837 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2838 Found by GCC static checking and --with-wide-int on a 32-bit host.
2840 2011-07-25 Eli Zaretskii <eliz@gnu.org>
2842 * xdisp.c (compute_display_string_pos): Fix logic of caching
2843 previous display string position. Initialize cached_prev_pos to
2844 -1. Fixes slow-down at the beginning of a buffer.
2846 2011-07-24 Eli Zaretskii <eliz@gnu.org>
2848 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2849 for attrs[LFACE_FONTSET_INDEX].
2851 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2853 * xml.c (parse_region): Remove unused local
2854 that was recently introduced.
2856 2011-07-23 Eli Zaretskii <eliz@gnu.org>
2858 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2859 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2861 * xdisp.c (move_it_in_display_line_to): Record the best matching
2862 position for TO_CHARPOS while scanning the line, and restore it on
2863 exit if none of the characters scanned was an exact match.
2864 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
2865 when exact match is impossible due to invisible text, and the
2866 lines are truncated.
2868 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2870 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2873 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2875 Fix a significant slow-down of cursor motion with C-n, C-p,
2876 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2877 auto-repeat under bidi redisplay in fontified buffers.
2878 * xdisp.c (compute_stop_pos_backwards): New function.
2879 (next_element_from_buffer): Call compute_stop_pos_backwards to
2880 find a suitable prev_stop when we find ourselves before
2882 (reseat): Don't look for prev_stop, as that could mean a very long
2884 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2885 <cached_disp_overlay_modiff>: Cache for last found display string
2887 (compute_display_string_pos): Return the cached position if asked
2888 about the same buffer in the same area of character positions, and
2889 the buffer wasn't changed since the time the display string
2890 position was cached.
2892 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2894 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2895 is an integer, which is important for empty lines. (Bug#9149)
2897 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
2899 * frame.c (Fmodify_frame_parameters): In tty case, update the
2900 default face if necessary (Bug#4238).
2902 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
2904 * editfns.c (Fstring_to_char): No need to explain what a character
2905 is in the docstring (Bug#6576).
2907 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2909 * xml.c (parse_region): Make sure we always return a tree.
2911 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2913 * xml.c (parse_region): If a document contains only comments,
2916 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2918 * xml.c (make_dom): Return comments, too.
2920 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2923 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2924 and the surrounding thread.
2925 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2926 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2927 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2929 * s/openbsd.h (BROKEN_SIGIO): Define.
2930 * unexelf.c (unexec) [__OpenBSD__]:
2931 Don't update the .mdebug section of the Alpha COFF symbol table.
2933 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2935 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2938 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2940 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2941 This fixes some race conditions on the permissions of any newly
2944 * alloc.c (valid_pointer_p): Use pipe, not open.
2945 This fixes some permissions issues when debugging.
2947 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2948 If fchown fails to set both uid and gid, try to set just gid,
2949 as that is sometimes allowed. Adjust the file's mode to eliminate
2950 setuid or setgid bits that are inappropriate if fchown fails.
2952 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2954 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2955 to compare Lisp_Objects.
2956 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2957 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2958 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2960 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2962 * lread.c (read_integer): Unread even EOF character.
2963 (read1): Likewise. Properly record start position of symbol.
2965 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2966 symbol character follows.
2968 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2970 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2971 This works around a problem with the previous change to Fcopy_file.
2972 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2973 and without this change, GCC might complain about discarding
2974 fchown's return value.
2976 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
2978 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2980 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2982 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2984 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2986 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2987 it's used from the C level.
2989 * process.c: Use the same condition for POLL_FOR_INPUT in both
2990 keyboard.c and process.c (bug#1858).
2992 2011-07-09 Lawrence Mitchell <wence@gmx.li>
2994 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2995 (Fgnutls_boot): Use it.
2997 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2999 * doc.c (Fsubstitute_command_keys): Revert last change.
3001 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3003 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3004 quotes the next character, and doesn't affect other longer
3005 sequences (bug#8935).
3007 * lread.c (syms_of_lread): Clarify that is isn't only
3008 `eval-buffer' and `eval-defun' that's affected by
3009 `lexical-binding' (bug#8460).
3011 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3013 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3014 bidi redisplay when a line includes both an image and is truncated.
3016 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3018 Fix minor problems found by static checking.
3019 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3020 (elsz): Now a signed constant, not a size_t var. We prefer signed
3021 types to unsigned, to avoid integer comparison confusion. Without
3022 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3023 "cannot optimize loop, the loop counter may overflow", a symptom
3025 * indent.c (Fvertical_motion): Mark locals as initialized.
3026 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3028 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3030 * search.c (Fre_search_backward): Mention `case-fold-search' in
3031 all the re_search_* functions (bug#8138).
3033 * keyboard.c (Fopen_dribble_file): Document when the file is
3036 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3038 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3041 Support bidi reordering of display and overlay strings.
3042 * xdisp.c (compute_display_string_pos)
3043 (compute_display_string_end): Accept additional argument STRING.
3044 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3045 (reseat_to_string): Initialize bidi_it->string.s and
3046 bidi_it->string.schars.
3047 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3048 NULL (avoids a crash in bidi_paragraph_init).
3049 Initialize itb.string.lstring.
3050 (init_iterator): Call bidi_init_it only of a valid
3051 buffer position was specified. Initialize paragraph_embedding to
3053 (reseat_to_string): Initialize the bidi iterator.
3054 (display_string): If we need to ignore text properties of
3055 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3056 original value of -1 will not work with bidi.)
3057 (compute_display_string_pos): First arg is now struct
3058 `text_pos *'; all callers changed. Support display properties on
3060 (compute_display_string_end): Support display properties on Lisp
3062 (init_iterator, reseat_1, reseat_to_string): Initialize the
3063 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3064 when iterating on a string not from display properties).
3065 (compute_display_string_pos, compute_display_string_end):
3066 Fix calculation of the object to scan. Fixes an error when using
3068 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3069 base_level_stop; instead, set base_level_stop to BEGV.
3070 Fixes crashes in vertical-motion.
3071 (next_element_from_buffer): Improve commentary for when
3072 the iterator is before prev_stop.
3073 (init_iterator): Initialize bidi_p from the default value of
3074 bidi-display-reordering, not from buffer-local value. Use the
3075 buffer-local value only if initializing for buffer iteration.
3076 (handle_invisible_prop): Support invisible properties on strings
3077 that are being bidi-reordered.
3078 (set_iterator_to_next): Support bidi reordering of C strings and
3080 (next_element_from_string): Support bidi reordering of Lisp
3082 (handle_stop_backwards): Support Lisp strings as well.
3083 (display_string): Support display of R2L glyph rows.
3084 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3085 (init_iterator): Don't initialize it->bidi_p for strings
3087 (reseat_to_string): Initialize it->bidi_p for strings here.
3088 (next_element_from_string, next_element_from_c_string)
3089 (next_element_from_buffer): Add xassert's for correspondence
3090 between IT's object being iterated and it->bidi_it.string
3092 (face_before_or_after_it_pos): Support bidi iteration.
3093 (next_element_from_c_string): Handle the case of the first string
3094 character that is not the first one in the visual order.
3095 (get_visually_first_element): New function, refactored from common
3096 parts of next_element_from_buffer, next_element_from_string, and
3097 next_element_from_c_string.
3098 (tool_bar_lines_needed, redisplay_tool_bar)
3099 (display_menu_bar): Force left-to-right direction. Add a FIXME
3100 comment for making that be controlled by a user option.
3101 (push_it, pop_it): Save and restore the state of the
3102 bidi iterator. Save and restore the bidi_p flag.
3103 (pop_it): Iterate out of display property for string iteration as
3105 (iterate_out_of_display_property): Support iteration over strings.
3106 (handle_single_display_spec): Set up it->bidi_it for iteration
3107 over a display string, and call bidi_init_it.
3108 (handle_single_display_spec, next_overlay_string)
3109 (get_overlay_strings_1, push_display_prop): Set up the bidi
3110 iterator for displaying display or overlay strings.
3111 (forward_to_next_line_start): Don't use the shortcut if
3113 (back_to_previous_visible_line_start): If handle_display_prop
3114 pushed the iterator stack, restore the internal state of the bidi
3115 iterator by calling bidi_pop_it same number of times.
3116 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3117 and we are bidi-iterating, don't decrement the iterator position;
3118 instead, set the first_elt flag in the bidi iterator, to produce
3120 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3121 (push_display_prop): xassert that we are iterating a buffer.
3122 (push_it, pop_it): Save and restore paragraph_embedding member.
3123 (handle_single_display_spec, next_overlay_string)
3124 (get_overlay_strings_1, reseat_1, reseat_to_string)
3125 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3126 correctly. Don't assume unibyte strings are not bidi-reordered.
3127 (compute_display_string_pos)
3128 (compute_display_string_end): Fix handling the case of C string.
3129 (push_it, pop_it): Save and restore from_disp_prop_p.
3130 (handle_single_display_spec, push_display_prop): Set the
3131 from_disp_prop_p flag.
3132 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3133 (pop_it): Call iterate_out_of_display_property only if we are
3134 popping after iteration over a string that came from a display
3135 property. Fix a typo in popping stretch info. Add an assertion
3136 for verifying that the iterator position is in sync with the bidi
3138 (handle_single_display_spec, get_overlay_strings_1)
3139 (push_display_prop): Fix initialization of paragraph direction for
3140 string when that of the parent object is not yet determined.
3141 (reseat_1): Call bidi_init_it to resync the bidi
3142 iterator with IT's position. (Bug#7616)
3143 (find_row_edges): If ROW->start.pos gives position
3144 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3145 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3146 Reset the from_disp_prop_p flag.
3147 (SAVE_IT, RESTORE_IT): New macros.
3148 (pos_visible_p, face_before_or_after_it_pos)
3149 (back_to_previous_visible_line_start)
3150 (move_it_in_display_line_to, move_it_in_display_line)
3151 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3152 (try_scrolling, redisplay_window, display_line): Use them when
3153 saving a temporary copy of the iterator and restoring it back.
3154 (back_to_previous_visible_line_start, reseat_1)
3155 (init_iterator): Empty the bidi cache "stack".
3156 (move_it_in_display_line_to): If iterator ended up at
3157 EOL, but we never saw any buffer positions smaller than
3158 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3159 motion in bidi-reordered lines.
3160 (move_it_in_display_line_to): Record prev_method and prev_pos
3161 immediately before the call to set_iterator_to_next. Fixes cursor
3162 motion in bidi-reordered lines with stretch glyphs and strings
3163 displayed in margins. (Bug#8133) (Bug#8867)
3164 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3166 (pos_visible_p): Support positions in bidi-reordered lines.
3167 Save and restore bidi cache.
3169 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3170 (bidi_paragraph_info): Delete unused struct.
3171 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3172 (bidi_cache_start): New variable.
3173 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3175 (bidi_cache_fetch_state, bidi_cache_search)
3176 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3177 (bidi_cache_find, bidi_peek_at_next_level)
3178 (bidi_level_of_next_char, bidi_find_other_level_edge)
3179 (bidi_move_to_visually_next): Compare cache index with
3180 bidi_cache_start rather than with zero.
3181 (bidi_fetch_char): Accept new argument STRING; all callers
3182 changed. Support iteration over a string. Support strings with
3183 display properties. Support unibyte strings. Fix the type of
3184 `len' according to what STRING_CHAR_AND_LENGTH expects.
3185 (bidi_paragraph_init, bidi_resolve_explicit_1)
3186 (bidi_resolve_explicit, bidi_resolve_weak)
3187 (bidi_level_of_next_char, bidi_move_to_visually_next):
3188 Support iteration over a string.
3189 (bidi_set_sor_type, bidi_resolve_explicit_1)
3190 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3191 can now be zero (for strings); special values 0 and -1 were
3192 changed to -1 and -2, respectively.
3193 (bidi_char_at_pos): New function.
3194 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3195 Call it instead of FETCH_MULTIBYTE_CHAR.
3196 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3197 initialized to valid values.
3198 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3200 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3201 the test for valid cached positions. Fix the logic for looking up
3202 the sentinel state in the cache. GCPRO the Lisp string we are
3204 (bidi_push_it, bidi_pop_it): New functions.
3205 (bidi_initialize): Initialize the bidi cache start stack pointer.
3206 (bidi_cache_ensure_space): New function, refactored from part of
3207 bidi_cache_iterator_state. Don't assume the required size is just
3208 one BIDI_CACHE_CHUNK away.
3209 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3210 (bidi_count_bytes, bidi_char_at_pos): New functions.
3211 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3212 always valid if bidi_cache_idx is valid.
3213 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3214 is valid if it's going to be used.
3215 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3216 (bidi_cache_fetch_state, bidi_cache_search)
3217 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3218 (bidi_cache_iterator_state, bidi_cache_find)
3219 (bidi_find_other_level_edge, bidi_cache_start_stack):
3220 All variables related to cache indices are now EMACS_INT.
3222 * dispextern.h (struct bidi_string_data): New structure.
3223 (struct bidi_it): New member `string'. Make flag members be 1-bit
3224 fields, and put them last in the struct.
3225 (compute_display_string_pos, compute_display_string_end):
3227 (bidi_push_it, bidi_pop_it): Add prototypes.
3228 (struct iterator_stack_entry): New members bidi_p,
3229 paragraph_embedding, and from_disp_prop_p.
3230 (struct it): Member bidi_p is now a bit field 1 bit wide.
3231 (bidi_shelve_cache, bidi_unshelve_cache):
3234 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3235 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3236 and vector-like objects.
3238 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3239 cache around display iteration.
3241 * window.c (Fwindow_end, window_scroll_pixel_based)
3242 (displayed_window_lines, Frecenter): Save and restore the bidi
3243 cache around display iteration.
3245 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3247 * editfns.c (Fdelete_region): Clarify the use of the named
3248 parameters (bug#6788).
3250 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3252 * indent.c (Fvertical_motion): Set and restore w->pointm when
3253 saving and restoring the window's buffer (Bug#9006).
3255 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3257 * editfns.c (Fstring_to_char): Clarify just what is returned
3258 (bug#6576). Text by Eli Zaretskii.
3260 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3262 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3264 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3266 * buffer.c (mmap_find): Fix a typo.
3268 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3270 Fix execution of x selection hooks.
3271 * xselect.c (Qx_lost_selection_functions)
3272 (Qx_sent_selection_functions): New vars.
3273 (syms_of_xselect): DEFSYM them.
3274 (x_handle_selection_request): Pass Qx_sent_selection_functions
3275 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3276 (x_handle_selection_clear,x_clear_frame_selections):
3277 Pass Qx_lost_selection_functions rather than
3278 Vx_lost_selection_functions to Frun_hook_with_args.
3280 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3282 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3283 The old code sometimes used this field without initializing it.
3285 * alloc.c (gc_sweep): Don't read past end of array.
3286 In theory, the old code could also have corrupted Emacs internals,
3287 though it'd be very unlikely.
3289 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3291 * character.c (Fcharacterp): Don't advertise optional ignored
3292 argument. (Bug#4026)
3294 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3296 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3299 * window.c (Fset_window_start): Doc fix (bug#4199).
3300 (Fset_window_hscroll): Ditto.
3302 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3304 Fix minor new problems caught by GCC 4.6.1.
3305 * term.c (init_tty): Remove unused local.
3306 * xsettings.c (store_monospaced_changed): Define this function only
3307 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3310 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3312 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3314 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3316 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3317 are the mini-buffer and the echo area (bug#3320).
3319 * term.c (init_tty): Remove support for supdup, c10 and perq
3320 terminals, which are no longer supported (bug#1482).
3322 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3324 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3326 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3328 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3329 for non-popups (Bug#3642).
3331 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3333 * alloc.c (reset_malloc_hooks): Protoize.
3334 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3335 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3336 * cm.c (losecursor): Likewise.
3337 * data.c (fmod): Likewise.
3338 * dispnew.c (swap_glyphs_in_rows): Likewise.
3339 * emacs.c (memory_warning_signal): Likewise.
3340 * floatfns.c (float_error): Likewise.
3341 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3342 (otf_open, font_otf_capability, generate_otf_features)
3343 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3345 * image.c (pbm_read_file): Likewise.
3346 * indent.c (string_display_width): Likewise.
3347 * intervals.c (check_for_interval, search_for_interval)
3348 (inc_interval_count, count_intervals, root_interval)
3349 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3350 * lread.c (defalias): Likewise.
3351 * ralloc.c (r_alloc_check): Likewise.
3352 * regex.c (set_image_of_range_1, set_image_of_range)
3353 (regex_grow_registers): Likewise.
3354 * sysdep.c (strerror): Likewise.
3355 * termcap.c (valid_filename_p, tprint, main): Likewise.
3356 * tparam.c (main): Likewise.
3357 * unexhp9k800.c (run_time_remap, save_data_space)
3358 (update_file_ptrs, read_header, write_header, calculate_checksum)
3359 (copy_file, copy_rest, display_header): Likewise.
3360 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3362 * xdisp.c (check_it): Likewise.
3363 * xfaces.c (register_color, unregister_color, unregister_colors):
3365 * xfns.c (print_fontset_result): Likewise.
3366 * xrdb.c (member, fatal, main): Likewise.
3368 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3370 Fix minor problems found by static checking (Bug#9031).
3371 * chartab.c (char_table_set_range, map_sub_char_table):
3372 Remove unused locals.
3373 (uniprop_table): Now static.
3374 * composite.c (_work_char): Remove unused static var.
3376 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3378 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3380 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3382 * gtkutil.c (qttip_cb): Remove code without function.
3384 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3386 * w32.c (pthread_sigmask): New stub.
3388 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3390 Use pthread_sigmask, not sigprocmask (Bug#9010).
3391 sigprocmask is portable only for single-threaded applications, and
3392 Emacs can be multi-threaded when it uses GTK.
3393 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3395 * callproc.c (Fcall_process):
3396 * process.c (create_process):
3397 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3398 Use pthread_sigmask, not sigprocmask.
3400 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3402 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3403 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3406 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3408 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3409 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3410 (xg_hide_tooltip): Fix comment.
3412 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3413 in registerServicesMenuSendTypes.
3414 (validRequestorForSendType): Don't check ns_return_types.
3416 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3419 2011-07-08 Jason Rumney <jasonr@gnu.org>
3421 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3422 SH_SHOW for hidden windows (Bug#5482).
3424 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3425 frame struct members of non-existent frames (Bug#6284).
3427 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3429 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3430 variable firstTime not needed on OSX >= 10.6.
3431 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3432 >= 10.5. Use setKnobProportion, setDoubleValue.
3434 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3435 (MAC_OS_X_VERSION_10_5): Define if not defined.
3436 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3437 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3438 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3440 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3441 cString and lossyCString on OSX >= 10.4
3443 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3444 sizeToFit on OSX >= 10.2.
3446 * nsimage.m (allocInitFromFile): Don't use deprecated method
3447 bestRepresentationForDevice on OSX >= 10.6.
3449 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3452 * emacs.c: Declare unexec_init_emacs_zone.
3454 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3456 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3458 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3459 on svcsMenu (Bug#8842).
3461 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3463 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3465 * nsterm.m (QUTF8_STRING): Declare.
3466 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3467 (validRequestorForSendType): Return type is (id).
3468 Change indexOfObjectIdenticalTo to indexOfObject.
3469 Check if we have local selection before returning self (Bug#8842).
3470 (writeSelectionToPasteboard): Put local selection into paste board
3471 if we have a local selection (Bug#8842).
3472 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3474 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3475 (ns_get_local_selection): Declare.
3477 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3479 * keymap.c (describe_map_tree): Don't insert a double newline at
3480 the end of the buffer (bug#1169) and return whether we inserted
3483 * callint.c (Fcall_interactively): Change "reading args" to
3484 "providing args" to try to clarify what it does (bug#1010).
3486 2011-07-07 Kenichi Handa <handa@m17n.org>
3488 * composite.c (composition_compute_stop_pos): Ignore a static
3489 composition starting before CHARPOS (Bug#8915).
3491 * xdisp.c (handle_composition_prop): Likewise.
3493 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3495 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3498 2011-07-07 Kenichi Handa <handa@m17n.org>
3500 * character.h (unicode_category_t): New enum type.
3502 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3503 (Qchar_code_property_table): New variable.
3504 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3505 (UNIPROP_COMPRESSED_FORM_P): New macros.
3506 (char_table_ascii): Uncompress the compressed values.
3507 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3508 Uncompress the compressed values.
3509 (sub_char_table_ref_and_range): Likewise.
3510 (char_table_ref_and_range): Uncompress the compressed values.
3511 (sub_char_table_set): New arg is_uniprop. Callers changed.
3512 Uncompress the compressed values.
3513 (sub_char_table_set_range): Args changed. Callers changed.
3514 (char_table_set_range): Adjuted for the above change.
3515 (map_sub_char_table): Delete args default_val and parent. Add arg
3516 top. Give decoded values to a Lisp function.
3517 (map_char_table): Adjust for the above change. Give decoded
3518 values to a Lisp function. Gcpro more variables.
3519 (uniprop_table_uncompress)
3520 (uniprop_decode_value_run_length): New functions.
3521 (uniprop_decoder, uniprop_decoder_count): New variables.
3522 (uniprop_get_decoder, uniprop_encode_value_character)
3523 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3525 (uniprop_encoder, uniprop_encoder_count): New variables.
3526 (uniprop_get_encoder, uniprop_table)
3527 (Funicode_property_table_internal, Fget_unicode_property_internal)
3528 (Fput_unicode_property_internal): New functions.
3529 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3530 Sunicode_property_table_internal, Sget_unicode_property_internal,
3531 and Sput_unicode_property_internal. Defvar_lisp
3532 char-code-property-alist.
3534 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3535 Vunicode_category_table.
3537 * font.c (font_range): Adjust for the change of
3538 Vunicode_category_table.
3540 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3542 * m/iris4d.h: Remove file, move contents ...
3543 * s/irix6-5.h: ... here.
3545 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3547 Remove unportable assumption about struct layout (Bug#8884).
3548 * alloc.c (mark_buffer):
3549 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3550 (clone_per_buffer_values): Don't assume that
3551 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3552 This isn't true in general, and it's particularly not true
3553 if Emacs is configured with --with-wide-int.
3554 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3555 New macros, used in the buffer.c change.
3557 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3559 * xsettings.c: Use both GConf and GSettings if both are available.
3560 (store_config_changed_event): Add comment.
3561 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3562 (store_tool_bar_style_changed): New functions.
3563 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3564 (struct xsettings): Move font inside HAVE_XFT.
3565 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3566 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3567 Move inside HAVE_XFT.
3568 (something_changed_gsettingsCB): Rename from something_changedCB.
3569 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3571 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3572 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3573 (something_changed_gconfCB): Rename from something_changedCB.
3574 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3575 (parse_settings): Move check for font inside HAVE_XFT.
3576 (read_settings, apply_xft_settings): Add comment.
3577 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3578 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3579 call store_font_name_changed.
3580 (xft_settings_event): Add comment.
3581 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3582 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3583 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3584 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3585 (xsettings_initialize): Call init_gsettings last.
3586 (xsettings_get_system_font, xsettings_get_system_normal_font):
3589 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3591 Random fixes. E.g., (random) never returned negative values.
3592 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3593 subseconds part to the entropy, as that's a bit more random.
3594 Prefer signed to unsigned, since the signedness doesn't matter and
3595 in general we prefer signed. When given a limit, use a
3596 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3597 latter isn't right if USE_2_TAGS_FOR_INTS.
3598 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3599 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3601 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3603 * textprop.c (text_property_stickiness):
3604 Obey Vtext_property_default_nonsticky.
3605 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3606 * w32fns.c (syms_of_w32fns):
3607 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3609 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3611 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3612 This is more efficient than Ffile_directory_p and avoids a minor race.
3614 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3616 * buffer.c (Foverlay_put): Say what the return value is
3619 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3620 is a directory before asking whether to use the file name
3622 (barf_or_query_if_file_exists): Make the "File is a directory"
3623 error be more correct.
3625 * fns.c (Frequire): Remove the mention of the .gz files, since
3626 that's installation-specific, but keep the mention of
3627 `get-load-suffixes'.
3629 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3631 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3632 Report string overflow if the output is too long.
3634 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3636 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3637 (syms_of_gnutls): Remove duplicate DEFSYM for
3638 Qgnutls_bootprop_verify_hostname_error, an error for
3639 Qgnutls_bootprop_verify_error (which is no longer used).
3641 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3642 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3643 Also (re)move comments that are misplaced or no longer relevant.
3645 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3647 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3649 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3651 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3652 and background color parameters if they have been changed.
3654 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3656 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3658 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3660 * xsettings.c (SYSTEM_FONT): Define only when used.
3661 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3663 * keymap.c (access_keymap_1): Now static.
3665 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3667 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3668 leave any prefix arg for the up event (Bug#1586).
3670 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3672 * lread.c (syms_of_lread): Mention single symbols defined by
3673 `defvar' or `defconst' (bug#7154).
3675 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3676 (Frequire): Mention get-load-suffixes.
3678 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3680 * window.h (window): Remove clone_number slot.
3681 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3683 (make_parent_window, make_window, saved_window)
3684 (Fset_window_configuration, save_window_save): Don't deal with
3686 * buffer.c (Qclone_number): Remove declaration.
3687 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3689 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3691 Add multiple inheritance to keymaps.
3692 * keymap.c (Fmake_composed_keymap): New function.
3693 (Fset_keymap_parent): Simplify.
3694 (fix_submap_inheritance): Remove.
3695 (access_keymap_1): New function extracted from access_keymap to handle
3696 embedded parents and handle lists of maps.
3697 (access_keymap): Use it.
3698 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3699 (Fcopy_keymap): Handle embedded parents.
3700 (Fcommand_remapping, define_as_prefix): Simplify.
3701 (Fkey_binding): Simplify.
3702 (syms_of_keymap): Move minibuffer-local-completion-map,
3703 minibuffer-local-filename-completion-map,
3704 minibuffer-local-must-match-map, and
3705 minibuffer-local-filename-must-match-map to Elisp.
3706 (syms_of_keymap): Defsubr make-composed-keymap.
3707 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3708 (parse_menu_item): Trivial simplification.
3710 2011-07-01 Glenn Morris <rgm@gnu.org>
3712 * Makefile.in (SETTINGS_LIBS): Fix typo.
3714 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3716 * coding.c (Fencode_coding_string): Record the last coding system
3717 used, as the function doc string says (bug#8738).
3719 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3721 * xsettings.c (store_monospaced_changed): Take new font as arg and
3722 check for change against current_mono_font.
3723 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3724 (emacs_settings_constructor, emacs_settings_get_property)
3725 (emacs_settings_set_property, emacs_settings_class_init)
3726 (emacs_settings_init, gsettings_obj): Remove.
3727 (something_changedCB): New function for HAVE_GSETTINGS.
3728 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3729 with value as argument.
3730 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3731 g_settings_new (Bug#8967). Do not create gsettings_obj.
3732 Remove calls to g_settings_bind. Connect something_changedCB to
3735 * xgselect.c: Add defined (HAVE_GSETTINGS).
3736 (xgselect_initialize): Ditto.
3738 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3739 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3742 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3744 * eval.c (struct backtrace): Simplify and port the data structure.
3745 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3746 signed bit field, as this assumption is not portable and it makes
3747 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3748 "char debug_on_exit : 1" as this is not portable either; instead,
3749 use the portable "unsigned int debug_on_exit : 1". Remove unused
3750 member evalargs. Remove obsolete comments about cc bombing out.
3752 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3754 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3755 Let HAVE_GSETTINGS override HAVE_GCONF.
3756 (store_monospaced_changed): New function.
3757 (EMACS_SETTINGS): A new type derived from GObject to handle
3758 GSettings notifications.
3759 (emacs_settings_constructor, emacs_settings_get_property)
3760 (emacs_settings_set_property, emacs_settings_class_init):
3762 (gsettings_client, gsettings_obj): New variables.
3763 (GSETTINGS_SCHEMA): New define.
3764 (something_changedCB): Call store_monospaced_changed.
3765 (init_gsettings): New function.
3766 (xsettings_initialize): Call init_gsettings.
3767 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3770 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
3773 2011-06-29 Martin Rudalics <rudalics@gmx.at>
3775 * window.c (resize_root_window, grow_mini_window)
3776 (shrink_mini_window): Rename Qresize_root_window to
3777 Qwindow_resize_root_window and Qresize_root_window_vertically to
3778 Qwindow_resize_root_window_vertically.
3780 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3782 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3784 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
3786 * makefile.w32-in: Redesign dependencies so they reflect more
3787 clearly which files are directly included by each source file,
3788 and not through other includes.
3790 2011-06-27 Martin Rudalics <rudalics@gmx.at>
3792 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3793 (sort_overlays, overlay_strings): When an overlay's clone number
3794 matches the window's clone number process the overlay even if
3795 the overlay's window property doesn't match the current window.
3797 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3798 (Fwindow_hchild): Rename to Fwindow_left_child.
3799 (Fwindow_next): Rename to Fwindow_next_sibling.
3800 (Fwindow_prev): Rename to Fwindow_prev_sibling.
3801 (resize_window_check): Rename to window_resize_check.
3802 (resize_window_apply): Rename to window_resize_apply.
3803 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3804 (Fdelete_other_windows_internal, resize_frame_windows)
3805 (Fsplit_window_internal, Fdelete_window_internal)
3806 (grow_mini_window, shrink_mini_window)
3807 (Fresize_mini_window_internal): Fix callers accordingly.
3809 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3811 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3812 (emacs_fixed_set_min_size): Remove.
3813 (emacs_fixed_new): Take frame as argument.
3815 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3816 (_EmacsFixedPrivate): Remove minwidth/height.
3817 Add struct frame *f.
3818 (emacs_fixed_init): Initialize priv->f.
3819 (get_parent_class, emacs_fixed_set_min_size): Remove.
3820 (emacs_fixed_new): Set priv->f to argument.
3821 (emacs_fixed_get_preferred_width)
3822 (emacs_fixed_get_preferred_height): Use min_width/height from
3823 frames size_hint to set minimum and natural (Bug#8919).
3824 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3825 and use min_width/height from frames size_hint to set
3826 min_width/height (Bug#8919).
3828 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
3829 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3832 2011-06-26 Eli Zaretskii <eliz@gnu.org>
3834 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3835 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3838 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
3840 * process.c (wait_reading_process_output): Bypass select if
3841 waiting for a cell while ignoring keyboard input, and input is
3842 pending. Suggested by Jan Djärv (Bug#8869).
3844 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3846 Use gnulib's dup2 module instead of rolling our own.
3847 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3849 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3851 * dispnew.c (scrolling_window): Before scrolling, turn off a
3852 mouse-highlight in the window being scrolled.
3854 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
3856 Move DEFSYM to lisp.h and use everywhere.
3858 * character.h (DEFSYM): Move declaration...
3859 * lisp.h (DEFSYM): ...here.
3865 * w32select.c: Don't include character.h.
3867 * alloc.c (syms_of_alloc):
3868 * buffer.c (syms_of_buffer):
3869 * bytecode.c (syms_of_bytecode):
3870 * callint.c (syms_of_callint):
3871 * casefiddle.c (syms_of_casefiddle):
3872 * casetab.c (init_casetab_once):
3873 * category.c (init_category_once, syms_of_category):
3874 * ccl.c (syms_of_ccl):
3875 * cmds.c (syms_of_cmds):
3876 * composite.c (syms_of_composite):
3877 * dbusbind.c (syms_of_dbusbind):
3878 * dired.c (syms_of_dired):
3879 * dispnew.c (syms_of_display):
3880 * doc.c (syms_of_doc):
3881 * editfns.c (syms_of_editfns):
3882 * emacs.c (syms_of_emacs):
3883 * eval.c (syms_of_eval):
3884 * fileio.c (syms_of_fileio):
3885 * fns.c (syms_of_fns):
3886 * frame.c (syms_of_frame):
3887 * fringe.c (syms_of_fringe):
3888 * insdel.c (syms_of_insdel):
3889 * keymap.c (syms_of_keymap):
3890 * lread.c (init_obarray, syms_of_lread):
3891 * macros.c (syms_of_macros):
3892 * msdos.c (syms_of_msdos):
3893 * print.c (syms_of_print):
3894 * process.c (syms_of_process):
3895 * search.c (syms_of_search):
3896 * sound.c (syms_of_sound):
3897 * syntax.c (init_syntax_once, syms_of_syntax):
3898 * terminal.c (syms_of_terminal):
3899 * textprop.c (syms_of_textprop):
3900 * undo.c (syms_of_undo):
3901 * w32.c (globals_of_w32):
3902 * window.c (syms_of_window):
3903 * xdisp.c (syms_of_xdisp):
3904 * xfaces.c (syms_of_xfaces):
3905 * xfns.c (syms_of_xfns):
3906 * xmenu.c (syms_of_xmenu):
3907 * xsettings.c (syms_of_xsettings):
3908 * xterm.c (syms_of_xterm): Use DEFSYM.
3910 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3912 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
3914 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3916 Integer and buffer overflow fixes (Bug#8873).
3918 * print.c (printchar, strout): Check for string overflow.
3919 (PRINTPREPARE, printchar, strout):
3920 Don't set size unless allocation succeeds.
3922 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3923 for sizes. Check for string overflow more accurately.
3924 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3926 * macros.c: Integer and buffer overflow fixes.
3927 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3928 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3929 Use ptrdiff_t, not int, for sizes.
3930 Don't increment bufsize until after realloc succeeds.
3931 Check for size-calculation overflow.
3932 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3934 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3936 * lread.c: Integer overflow fixes.
3937 (read_integer): Radix is now EMACS_INT, not int,
3938 to improve quality of diagnostics for out-of-range radices.
3939 Calculate buffer size correctly for out-of-range radices.
3940 (read1): Check for integer overflow in radices, and in
3941 read-circle numbers.
3942 (read_escape): Avoid int overflow.
3943 (Fload, openp, read_buffer_size, read1)
3944 (substitute_object_recurse, read_vector, read_list, map_obarray):
3945 Use ptrdiff_t, not int, for sizes.
3946 (read1): Use EMACS_INT, not int, for sizes.
3947 Check for size overflow.
3949 * image.c (cache_image): Check for size arithmetic overflow.
3951 * lread.c: Integer overflow issues.
3952 (saved_doc_string_size, saved_doc_string_length)
3953 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3954 Now ptrdiff_t, not int.
3955 (read1): Don't assume doc string length fits in int. Check for
3956 out-of-range doc string lengths.
3957 (read_list): Don't assume file position fits in int.
3958 (read_escape): Check for hex character overflow.
3960 2011-06-22 Leo Liu <sdl.web@gmail.com>
3962 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3963 Move to minibuffer.el.
3965 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3967 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
3968 The following patches are for when GLYPH_DEBUG && !XASSERT.
3969 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3970 * dispnew.c (flush_stdout):
3971 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3972 Mark as externally visible.
3973 * dispnew.c (check_window_matrix_pointers): Now static.
3974 * dispnew.c (window_to_frame_vpos):
3975 * xfns.c (unwind_create_frame):
3976 * xterm.c (x_check_font): Remove unused local.
3977 * scroll.c (CHECK_BOUNDS):
3978 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3979 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3980 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3981 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3982 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3984 (debug_method_add): Use va_list and vsprintf rather than relying
3985 on undefined behavior with wrong number of arguments.
3986 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3987 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3988 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3989 since we're not interested in debugging glyphs with old libraries.
3990 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3991 GCC 4.6.0's static checking.
3993 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3995 Integer overflow and signedness fixes (Bug#8873).
3996 A few related buffer overrun fixes, too.
3998 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4000 * dispextern.h (struct face.stipple):
4001 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4002 (x_bitmap_mask, x_allocate_bitmap_record)
4003 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4004 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4005 (x_create_bitmap_from_xpm_data):
4006 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4007 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4009 * xfaces.c (load_pixmap):
4010 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4011 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4012 (.bitmaps_last, struct x_output.icon_bitmap):
4013 Use ptrdiff_t, not int, for bitmap indexes.
4014 (x_allocate_bitmap_record): Check for size overflow.
4015 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4017 Use ptrdiff_t, not int, for overlay counts.
4018 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4019 * editfns.c (overlays_around, get_pos_property):
4020 * textprop.c (get_char_property_and_overlay):
4021 * xdisp.c (next_overlay_change, note_mouse_highlight):
4022 * xfaces.c (face_at_buffer_position):
4023 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4024 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4025 (Fnext_overlay_change, Fprevious_overlay_change)
4026 (mouse_face_overlay_overlaps, Foverlays_in):
4027 Use ptrdiff_t, not int, for sizes.
4028 (overlays_at, overlays_in): Check for size-calculation overflow.
4030 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4032 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4033 (x_session_initialize): Do not assume string length fits in int.
4035 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4036 This is unlikely, but can occur if DPI is outlandish.
4038 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4039 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4041 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4042 * xrdb.c (magic_file_p, search_magic_path):
4043 Omit last arg SUFFIX; it was always 0. All callers changed.
4044 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4046 * xfont.c (xfont_match): Avoid need for strlen.
4048 * xfns.c: Don't assume strlen fits in int.
4049 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4051 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4052 not unsigned long, as we prefer signed integers. All callers changed.
4053 Detect integer overflow in repeat count.
4054 (message_dolog): Don't assume print length fits in 39 bytes.
4055 (display_mode_element): Don't assume strlen fits in int.
4057 * termcap.c: Don't assume sizes fit in int and never overflow.
4058 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4059 (gobble_line): Check for size-calculation overflow.
4061 * minibuf.c (Fread_buffer):
4062 * lread.c (intern, intern_c_string):
4063 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4064 Don't assume string length fits in int.
4066 * keyboard.c (parse_tool_bar_item):
4067 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4069 * font.c: Don't assume string length fits in int.
4070 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4071 Use ptrdiff_t, not int.
4072 (font_intern_prop): Don't assume string length fits in int.
4073 Don't assume integer property fits in fixnum.
4074 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4076 * filelock.c: Fix some buffer overrun and integer overflow issues.
4077 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4078 Reformulate so as not to need the command string.
4079 Invoke gzip -cd rather than gunzip, as it's more portable.
4080 (lock_info_type, lock_file_1, lock_file):
4081 Don't assume pid_t and time_t fit in unsigned long.
4082 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4083 (current_lock_owner): Prefer signed type for sizes.
4084 Use memcpy, not strncpy, where memcpy is what is really wanted.
4085 Don't assume (via atoi) that time_t and pid_t fit in int.
4086 Check for time_t and/or pid_t out of range, e.g., via a network share.
4087 Don't alloca where an auto var works fine.
4089 * fileio.c: Fix some integer overflow issues.
4090 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4091 Don't assume string length fits in int.
4092 (directory_file_name): Don't assume string length fits in long.
4093 (make_temp_name): Don't assume pid fits in int, or that its print
4094 length is less than 20.
4096 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4098 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4100 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4102 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4103 We prefer signed integers, even for size calculations.
4105 * emacs.c: Don't assume string length fits in 'int'.
4106 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4107 (main): Don't invoke strlen when not needed.
4109 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4110 (XD_DEBUG_MESSAGE): Don't waste a byte.
4112 * callproc.c (getenv_internal_1, getenv_internal)
4114 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4116 * lread.c (invalid_syntax): Omit length argument.
4117 All uses changed. This doesn't fix a bug, but it simplifies the
4118 code away from its former Hollerith-constant appearance, and it's
4119 one less 'int' to worry about when looking at integer-overflow issues.
4120 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4122 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4123 This didn't break anything, but it didn't help either.
4124 It's confusing to put a bogus integer in a place where the actual
4125 value does not matter.
4126 (LIST_END_P): Remove unused macro and its bogus comment.
4127 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4129 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4130 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4132 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4133 We prefer signed types, and the value cannot exceed the EMACS_INT
4134 range anyway (because otherwise the length would not be representable).
4135 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4136 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4137 This avoids a GCC warning when WIDE_EMACS_INT.
4139 * indent.c (sane_tab_width): New function.
4140 (current_column, scan_for_column, Findent_to, position_indentation)
4141 (compute_motion): Use it. This is just for clarity.
4142 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4144 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4146 * lisp.h (lint_assume): New macro.
4147 * composite.c (composition_gstring_put_cache):
4148 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4150 * editfns.c, insdel.c:
4151 Omit unnecessary forward decls, to simplify future changes.
4153 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4155 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4157 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4158 Use much-faster test for byte-length change.
4159 Don't assume string byte-length fits in 'int'.
4160 Check that character arg fits in 'int'.
4161 (mapcar1): Declare byte as byte, for clarity.
4163 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4165 * fns.c (concat): Catch string overflow earlier.
4166 Do not rely on integer wraparound.
4168 * dispextern.h (struct it.overlay_strings_charpos)
4169 (struct it.selective): Now EMACS_INT, not int.
4170 * xdisp.c (forward_to_next_line_start)
4171 (back_to_previous_visible_line_start)
4172 (reseat_at_next_visible_line_start, next_element_from_buffer):
4173 Don't arbitrarily truncate the value of 'selective' to int.
4175 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4177 * composite.c: Don't truncate sizes to 'int'.
4178 (composition_gstring_p, composition_reseat_it)
4179 (composition_adjust_point): Use EMACS_INT, not int.
4180 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4181 not EMACS_UINT, for indexes.
4183 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4185 * buffer.c: Include <verify.h>.
4186 (struct sortvec.priority, struct sortstr.priority):
4187 Now EMACS_INT, not int.
4188 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4189 (struct sortstr.size, record_overlay_string)
4190 (struct sortstrlist.size, struct sortlist.used):
4191 Don't truncate size to int.
4192 (record_overlay_string): Check for size-calculation overflow.
4193 (init_buffer_once): Check at compile-time, not run-time.
4195 2011-06-22 Jim Meyering <meyering@redhat.com>
4197 Don't leak an XBM-image-sized buffer
4198 * image.c (xbm_load): Free the image buffer after using it.
4200 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4203 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4204 that Sun C diagnosed.
4205 * fns.c (secure_hash): Fix pointer signedness issue.
4206 * intervals.c (static_offset_intervals): New function.
4207 (offset_intervals): Use it.
4209 2011-06-21 Leo Liu <sdl.web@gmail.com>
4212 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4215 * fns.c (secure_hash): Rename from crypto_hash_function and change
4216 the first arg to accept symbols.
4217 (Fsecure_hash): New primitive.
4218 (syms_of_fns): New symbols.
4220 2011-06-20 Deniz Dogan <deniz@dogan.se>
4222 * process.c (Fset_process_buffer): Clarify return value in
4225 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4227 * dispnew.c (add_window_display_history): Use BVAR.
4229 * xdisp.c (debug_method_add): Use BVAR.
4230 (check_window_end, dump_glyph_matrix, dump_glyph)
4231 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4233 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4236 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4237 check till after the cache is created in init_frame_faces.
4239 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4241 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4243 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4245 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4246 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4247 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4249 Improve buffer-overflow checking (Bug#8873).
4250 * fileio.c (Finsert_file_contents):
4251 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4252 Remove the old (too-loose) buffer overflow checks.
4253 They weren't needed, since make_gap checks for buffer overflow.
4254 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4255 The old code merely checked for Emacs fixnum overflow, and relied
4256 on undefined (wraparound) behavior. The new code avoids undefined
4257 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4259 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4260 Tune. Don't use wider integers than needed. Don't use alloca.
4261 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4263 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4265 * insdel.c, lisp.h (buffer_overflow): New function.
4266 (insert_from_buffer_1, replace_range, replace_range_2):
4267 * insdel.c (make_gap_larger):
4268 * editfns.c (Finsert_char):
4269 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4271 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4273 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4275 Integer overflow and signedness fixes (Bug#8873).
4277 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4278 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4280 * fileio.c: Don't assume EMACS_INT fits in off_t.
4281 (emacs_lseek): New static function.
4282 (Finsert_file_contents, Fwrite_region): Use it.
4283 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4285 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4287 * fns.c: Don't overflow int when computing a list length.
4288 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4289 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4290 truncation on 64-bit hosts. Check for QUIT every
4291 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4292 faster and is responsive enough.
4293 (Flength): Report an error instead of overflowing an integer.
4294 (Fsafe_length): Return a float if the value is not representable
4295 as a fixnum. This shouldn't happen except in contrived situations.
4296 (Fnthcdr, Fsort): Don't assume list length fits in int.
4297 (Fcopy_sequence): Don't assume vector length fits in int.
4299 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4300 (header_size, word_size): New constants.
4301 (allocate_vectorlike): Don't check size overflow here.
4302 (allocate_vector): Check it here instead, since this is the only
4303 caller of allocate_vectorlike that could cause overflow.
4304 Check that the new vector's length is representable as a fixnum.
4306 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4307 The previous code was bogus. For example, next_almost_prime (32)
4308 returned 39, which is undesirable as it is a multiple of 3; and
4309 next_almost_prime (24) returned 25, which is a multiple of 5 so
4310 why was the code bothering to check for multiples of 7?
4312 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4314 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4316 Variadic C functions now count arguments with ptrdiff_t.
4317 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4318 Back then I didn't know that the Emacs coding style prefers signed int.
4319 Also, in the meantime I found a few more instances where arguments
4320 were being counted with int, which may truncate counts on 64-bit
4321 machines, or EMACS_INT, which may be unnecessarily wide.
4322 * lisp.h (struct Lisp_Subr.function.aMANY)
4323 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4324 Arg counts are now ptrdiff_t, not size_t.
4325 All variadic functions and their callers changed accordingly.
4326 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4327 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4328 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4329 * callint.c (Fcall_interactively): Check arg count for overflow,
4330 to avoid potential buffer overrun. Use signed char, not 'int',
4331 for 'varies' array, so that we needn't bother to check its size
4332 calculation for overflow.
4333 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4334 * eval.c (apply_lambda):
4335 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4336 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4337 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4339 * callint.c (Fcall_interactively): Don't use index var as event count.
4341 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4342 * mem-limits.h (SIZE): Remove; no longer used.
4344 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4346 Remove unnecessary casts.
4347 * xterm.c (x_term_init):
4348 * xfns.c (x_set_border_pixel):
4349 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4350 These aren't needed now that we assume ANSI C.
4352 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4353 It's more likely to cause problems (due to unsigned overflow)
4356 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4358 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4360 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4362 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4364 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4366 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4368 GLYPH_CODE_FACE returns EMACS_INT, not int.
4369 * dispextern.h (merge_faces):
4370 * xfaces.c (merge_faces):
4371 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4372 Don't assume EMACS_INT fits in int.
4374 * character.h (CHAR_VALID_P): Remove unused parameter.
4375 * fontset.c, lisp.h, xdisp.c: All uses changed.
4377 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4379 * fns.c (concat): Minor tuning based on overflow analysis.
4380 This doesn't fix any bugs. Use int to hold character, instead
4381 of constantly refetching from Emacs object. Use XFASTINT, not
4382 XINT, for value known to be a character. Don't bother comparing
4383 a single byte to 0400, as it's always less.
4385 * floatfns.c (Fexpt):
4386 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4388 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4391 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4393 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4394 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4395 incorrectly succeed when S was a string, because 4294967386 was
4396 truncated before it was used.
4398 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4399 Otherwise, an out-of-range integer could cause undefined behavior
4402 * composite.c: Use int, not EMACS_INT, for characters.
4403 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4404 EMACS_INT, for values that are known to be in character range.
4405 This doesn't fix any bugs but is the usual style inside Emacs and
4406 may generate better code on 32-bit machines.
4408 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4409 This is for reasons similar to the recent CHAR_STRING fix.
4410 * charset.c (Fencode_char): Check that character arg is actually
4411 a character. Pass an int to ENCODE_CHAR.
4412 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4413 wider than 'int', as a compile-time check to prevent future regressions
4416 * character.c (char_string): Remove unnecessary casts.
4418 Make sure a 64-bit char is never passed to CHAR_STRING.
4419 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4420 by silently ignoring the top 32 bits, allowing some values
4421 that were far too large to be valid characters.
4422 * character.h: Include <verify.h>.
4423 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4424 arguments are no wider than unsigned, as a compile-time check
4425 to prevent future regressions in this area.
4427 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4428 (Fsubst_char_in_region):
4430 * xdisp.c (decode_mode_spec_coding):
4431 Adjust to CHAR_STRING's new requirement.
4432 * editfns.c (Finsert_char, Fsubst_char_in_region):
4433 * fns.c (concat): Check that character args are actually
4434 characters. Without this test, these functions did the wrong
4435 thing with wildly out-of-range values on 64-bit hosts.
4437 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4438 These casts should not be needed on 32-bit hosts, either.
4439 * keyboard.c (read_char):
4440 * lread.c (Fload): Remove casts to unsigned.
4442 * lisp.h (UNSIGNED_CMP): New macro.
4443 This fixes comparison bugs on 64-bit hosts.
4444 (ASCII_CHAR_P): Use it.
4445 * casefiddle.c (casify_object):
4446 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4447 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4448 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4449 * dispextern.h (FACE_FROM_ID):
4450 * keyboard.c (read_char): Use UNSIGNED_CMP.
4452 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4453 not to EMACS_INT, to avoid GCC warning.
4455 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4457 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4458 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4459 isn't needed on 32-bit machines.
4461 * buffer.c (Fgenerate_new_buffer_name):
4462 Use EMACS_INT for count, not int.
4463 (advance_to_char_boundary): Return EMACS_INT, not int.
4465 * data.c (Qcompiled_function): Now static.
4467 * window.c (window_body_lines): Now static.
4469 * image.c (gif_load): Rename local to avoid shadowing.
4471 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4472 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4473 * alloc.c (make_save_value): Integer argument is now of type
4475 (mark_object): Use ptrdiff_t, not int.
4476 * lisp.h (pD): New macro.
4477 * print.c (print_object): Use it.
4479 * alloc.c: Use EMACS_INT, not int, to count objects.
4480 (total_conses, total_markers, total_symbols, total_vector_size)
4481 (total_free_conses, total_free_markers, total_free_symbols)
4482 (total_free_floats, total_floats, total_free_intervals)
4483 (total_intervals, total_strings, total_free_strings):
4484 Now EMACS_INT, not int. All uses changed.
4485 (Fgarbage_collect): Compute overall total using a double, so that
4486 integer overflow is less likely to be a problem. Check for overflow
4487 when converting back to an integer.
4488 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4489 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4490 These were 'int' variables that could overflow on 64-bit hosts;
4491 they were never used, so remove them instead of repairing them.
4492 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4493 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4494 Previously, this ceilinged at INT_MAX, but that doesn't work on
4496 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4498 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4499 (allocate_vectorlike): Check for ptrdiff_t overflow.
4500 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4501 when a (possibly-narrower) signed value would do just as well.
4502 We prefer using signed arithmetic, to avoid comparison confusion.
4504 * alloc.c: Catch some string size overflows that we were missing.
4505 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4506 for convenience in STRING_BYTES_MAX.
4507 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4508 The definition here is exact; the one in lisp.h was approximate.
4509 (allocate_string_data): Check for string overflow. This catches
4510 some instances we weren't catching before. Also, it catches
4511 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4512 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4513 and ptrdiff_t and EMACS_INT are both 64 bits.
4515 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4516 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4517 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4519 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4521 * alloc.c (Fmake_string): Check for out-of-range init.
4523 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4525 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4527 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4529 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4530 xg_get_default_scrollbar_width.
4532 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4533 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4534 (style_changed_cb): Call update_theme_scrollbar_width and call
4535 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4536 all frames (Bug#8505).
4537 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4538 Call gtk_window_set_resizable if HAVE_GTK3.
4539 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4540 and height if HAVE_GTK3 (Bug#8505).
4541 (scroll_bar_width_for_theme): New variable.
4542 (update_theme_scrollbar_width): New function.
4543 (xg_get_default_scrollbar_width): Move code to
4544 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4545 (xg_initialize): Call update_theme_scrollbar_width.
4547 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4549 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4551 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4553 * frame.c (make_frame): Call other_buffer_safely instead of
4556 * window.c (temp_output_buffer_show): Call display_buffer with
4557 second argument Vtemp_buffer_show_specifiers and reset latter
4558 immediately after the call.
4559 (Vtemp_buffer_show_specifiers): New variable.
4560 (auto_window_vscroll_p, next_screen_context_lines)
4561 (Vscroll_preserve_screen_position): Remove leading asterisks from
4564 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4566 Fix minor problems found by GCC 4.6.0 static checking.
4567 * buffer.c (Qclone_number): Remove for now, as it's unused.
4568 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4569 (record_buffer): Remove unused local.
4570 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4571 (set_frame_buffer_list): Remove; unused.
4572 * frame.h (other_visible_frames): Remove decl.
4573 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4574 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4575 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4577 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4578 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4579 Define only if HAVE_GPM.
4580 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4581 (update_hints_inhibit): Remove; never set. All uses removed.
4582 * widgetprv.h (emacsFrameClassRec): Remove decl.
4583 * window.c (delete_deletable_window): Now returns void, since it
4584 wasn't returning anything.
4585 (compare_window_configurations): Remove unused locals.
4586 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4587 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4588 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4589 the same widths as pointers. This follows up on the 2011-05-06 patch.
4590 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4591 * xterm.h: Likewise.
4592 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4594 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4596 * makefile.w32-in: Update dependencies.
4597 (LISP_H): Add lib/intprops.h.
4599 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4601 * image.c (gif_load): Add animation frame delay to the metadata.
4602 (syms_of_image): Use DEFSYM. New symbol `delay'.
4604 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4606 * window.c (delete_deletable_window): Re-add.
4607 (Fset_window_configuration): Rewrite to handle dead buffers and
4608 consequently deletable windows.
4609 (window_tree, Fwindow_tree): Remove. Supply functionality in
4611 (compare_window_configurations): Simplify code.
4613 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4615 * image.c (imagemagick_load_image): Fix type mismatch.
4616 (Fimagemagick_types): Likewise.
4618 * window.h (replace_buffer_in_windows): Declare.
4620 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4622 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4623 Qclone_number. Remove external declaration of Qdelete_window.
4624 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4626 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4627 Run Qbuffer_list_update_hook if allowed.
4628 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4629 buffer list implementation.
4630 (other_buffer_safely): New function.
4631 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4632 calls to replace_buffer_in_windows and
4633 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4635 (record_buffer): Inhibit quitting and rewrite using quittable
4636 functions. Run Qbuffer_list_update_hook if allowed.
4637 (Frecord_buffer, Funrecord_buffer): New functions.
4638 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4639 Move switch-to-buffer to window.el.
4640 (bury-buffer): Move to window.el.
4641 (Vbuffer_list_update_hook): New variable.
4643 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4646 * window.h (resize_frame_windows): Move up in code.
4647 (Fwindow_frame): Remove EXFUN.
4648 (replace_buffer_in_all_windows): Remove prototype.
4649 (replace_buffer_in_windows_safely): Add prototype.
4651 * window.c: Declare Qdelete_window static again. Move down
4652 declaration of select_count.
4653 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4654 (Fother_window): Move to window.el.
4655 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4656 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4657 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4659 (replace_buffer_in_windows): Implement by calling
4660 Qreplace_buffer_in_windows.
4661 (replace_buffer_in_all_windows): Remove with some functionality
4662 moved into replace_buffer_in_windows_safely.
4663 (replace_buffer_in_windows_safely): New function.
4664 (select_window_norecord, select_frame_norecord): Move in front
4665 of run_window_configuration_change_hook. Remove now obsolete
4667 (Fset_window_buffer): Rewrite doc-string.
4668 Call Qrecord_window_buffer.
4669 (keys_of_window): Move binding for other-window to window.el.
4671 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4673 * dispextern.h (struct image): Replace data member, whose int_val
4674 and ptr_val fields were not used by anything, with a single
4677 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4678 (gif_clear_image, gif_load, imagemagick_load_image)
4679 (gs_clear_image, gs_load): Callers changed.
4681 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4683 * buffer.h: Include <time.h>, for time_t.
4684 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4686 Fix minor problems found by static checking.
4688 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4690 Make identifiers static if they are not used in other modules.
4691 * data.c (Qcompiled_function, Qframe, Qvector):
4692 * image.c (QimageMagick, Qsvg):
4693 * minibuf.c (Qmetadata):
4694 * window.c (resize_window_check, resize_root_window): Now static.
4695 * window.h (resize_window_check, resize_root_window): Remove decls.
4697 * window.c (window_deletion_count, delete_deletable_window):
4699 (window_body_lines): Now static.
4700 (Fdelete_other_windows_internal): Mark vars as initialized.
4701 Make sure 'resize_failed' is initialized.
4702 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4703 (resize_window_apply): Remove unused local.
4704 * window.h (delete_deletable_window): Remove decl.
4706 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4707 (imagemagick_load_image): Fix pointer signedness problem by changing
4708 last arg from unsigned char * to char *. All uses changed.
4709 Also, fix a local for similar reasons.
4710 Remove unused locals. Remove locals to avoid shadowing.
4711 (fn_rsvg_handle_free): Remove; unused.
4712 (svg_load, svg_load_image): Fix pointer signedness problem.
4713 (imagemagick_load_image): Don't use garbage pointer image_wand.
4715 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4717 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4719 * image.c (gif_load): Fix omitted cast error introduced by
4722 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4724 * window.h (resize_proportionally, orig_total_lines)
4725 (orig_top_line): Remove from window structure.
4726 (set_window_height, set_window_width, change_window_heights)
4727 (Fdelete_window): Remove prototypes.
4728 (resize_frame_windows): Remove duplicate declaration.
4730 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4732 * window.h (resize_frame_windows, resize_window_check)
4733 (delete_deletable_window, resize_root_window)
4734 (resize_frame_windows): Declare prototypes.
4736 * window.c (resize_window_apply): Make definition be "static" to
4737 match the prototype.
4739 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4741 * window.c: Remove declarations of Qwindow_size_fixed,
4742 window_min_size_1, window_min_size_2, window_min_size,
4743 size_window, window_fixed_size_p, enlarge_window, delete_window.
4744 Remove static from declaration of Qdelete_window, it's
4745 temporarily needed by Fbury_buffer.
4746 (replace_window): Don't assign orig_top_line and
4748 (Fdelete_window, delete_window): Remove. Window deletion is
4749 handled by window.el.
4750 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4751 Replace Fdelete_window calls with calls to Qdelete_window.
4752 (Fdelete_other_windows): Remove. Deleting other windows is
4753 handled by window.el.
4754 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4755 handled in window.el.
4756 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4757 Window minimum sizes are handled in window.el.
4758 (shrink_windows, size_window, set_window_height)
4759 (set_window_width, change_window_heights, window_height)
4760 (window_width, CURBEG, CURSIZE, enlarge_window)
4761 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4762 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4763 handled in window.el.
4764 (make_dummy_parent): Rename to make_parent_window and give it a
4765 second argument horflag.
4766 (make_window): Don't set resize_proportionally any more.
4767 (Fsplit_window): Remove. Windows are split in window.el.
4768 (save_restore_action, save_restore_orig_size)
4769 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4770 Resize mini windows in window.el.
4771 (grow_mini_window, shrink_mini_window): Implement by calling
4772 Qresize_root_window_vertically, resize_window_check and
4773 resize_window_apply.
4774 (saved_window, Fset_window_configuration, save_window_save):
4775 Do not handle orig_top_line, orig_total_lines, and
4776 resize_proportionally.
4777 (window_min_height, window_min_width): Move to window.el.
4778 (keys_of_window): Move bindings for delete-other-windows,
4779 split-window, delete-window and enlarge-window to window.el.
4781 * buffer.c: Temporarily extern Qdelete_window.
4782 (Fbury_buffer): Temporarily call Qdelete_window instead of
4783 Fdelete_window (Fbury_buffer will move to window.el soon).
4785 * frame.c (set_menu_bar_lines_1): Remove code handling
4786 orig_top_line and orig_total_lines.
4788 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4789 set_window_height but set heights directly.
4790 (change_frame_size_1): Use resize_frame_windows.
4792 * xdisp.c (init_xdisp): Don't use set_window_height but set
4795 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4796 Use resize_frame_windows instead of change_window_heights and run
4797 run_window_configuration_change_hook.
4799 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4800 instead of change_window_heights and run
4801 run_window_configuration_change_hook.
4803 2011-06-09 Martin Rudalics <rudalics@gmx.at>
4805 * window.c (replace_window): Rename second argument REPLACEMENT to
4806 NEW. New third argument SETFLAG. Rewrite.
4807 (delete_window, make_dummy_parent): Call replace_window with
4809 (window_list_1): Move down in code.
4810 (run_window_configuration_change_hook): Move set_buffer part
4811 before select_frame_norecord part in order to unwind correctly.
4812 Rename count1 to count.
4813 (recombine_windows, delete_deletable_window, resize_root_window)
4814 (Fdelete_other_windows_internal)
4815 (Frun_window_configuration_change_hook, make_parent_window)
4816 (resize_window_check, resize_window_apply, Fresize_window_apply)
4817 (resize_frame_windows, Fsplit_window_internal)
4818 (Fdelete_window_internal, Fresize_mini_window_internal):
4820 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4822 2011-06-08 Martin Rudalics <rudalics@gmx.at>
4824 * window.h (window): Add some new members to window structure -
4825 normal_lines, normal_cols, new_total, new_normal, clone_number,
4826 splits, nest, prev_buffers, next_buffers.
4827 (WINDOW_TOTAL_SIZE): Move here from window.c.
4828 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
4830 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4832 (make_dummy_parent): Set new members of windows structure.
4833 (make_window): Move down in code. Handle new members of window
4835 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4836 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4837 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4838 (Fset_window_prev_buffers, Fwindow_next_buffers)
4839 (Fset_window_next_buffers, Fset_window_clone_number):
4841 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4842 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4844 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4845 Argument WINDOW can be now internal window too.
4846 (Fwindow_use_time): Move up in code.
4847 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4849 (Fset_window_configuration, saved_window)
4850 (Fcurrent_window_configuration, save_window_save): Handle new
4851 members of window structure.
4852 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4853 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4854 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4855 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4856 Qget_mru_window, Qresize_root_window,
4857 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4858 Qauto_buffer_name; staticpro them.
4860 2011-06-07 Martin Rudalics <rudalics@gmx.at>
4862 * window.c (Fwindow_total_size, Fwindow_left_column)
4863 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4864 (Fwindow_list_1): New functions.
4865 (window_box_text_cols): Replace with window_body_cols.
4866 (Fwindow_width, Fscroll_left, Fscroll_right):
4867 Use window_body_cols instead of window_box_text_cols.
4868 (delete_window, Fset_window_configuration):
4869 Call delete_all_subwindows with window as argument.
4870 (delete_all_subwindows): Take a window as argument and not a
4872 (window_loop): Remove handling of GET_LRU_WINDOW and
4874 (Fget_lru_window, Fget_largest_window): Move to window.el.
4876 * window.h: Extern window_body_cols instead of
4877 window_box_text_cols. delete_all_subwindows now takes a
4878 Lisp_Object as argument.
4880 * indent.c (compute_motion, Fcompute_motion):
4881 Use window_body_cols instead of window_box_text_cols.
4883 * frame.c (delete_frame): Call delete_all_subwindows with root
4886 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4888 * fns.c (Fputhash): Document return value.
4890 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
4892 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4894 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4896 Cons<->int and similar integer overflow fixes (Bug#8794).
4898 Check for overflow when converting integer to cons and back.
4899 * charset.c (Fdefine_charset_internal, Fdecode_char):
4900 Use cons_to_unsigned to catch overflow.
4901 (Fencode_char): Use INTEGER_TO_CONS.
4902 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4903 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4904 * data.c (long_to_cons, cons_to_long): Remove.
4905 (cons_to_unsigned, cons_to_signed): New functions.
4906 These signal an error for invalid or out-of-range values.
4907 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4908 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4909 * font.c (Ffont_variation_glyphs):
4910 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4911 * lisp.h: Include <intprops.h>.
4912 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4913 (cons_to_signed, cons_to_unsigned): New decls.
4914 (long_to_cons, cons_to_long): Remove decls.
4915 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4916 (Fprimitive_undo): Use CONS_TO_INTEGER.
4917 * xfns.c (Fx_window_property): Likewise.
4918 * xselect.c: Include <limits.h>.
4919 (x_own_selection, selection_data_to_lisp_data):
4920 Use INTEGER_TO_CONS.
4921 (x_handle_selection_request, x_handle_selection_clear)
4922 (x_get_foreign_selection, Fx_disown_selection_internal)
4923 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4924 (lisp_data_to_selection_data): Use cons_to_unsigned.
4925 (x_fill_property_data): Use cons_to_signed.
4926 Report values out of range.
4928 Check for buffer and string overflow more precisely.
4929 * buffer.h (BUF_BYTES_MAX): New macro.
4930 * lisp.h (STRING_BYTES_MAX): New macro.
4931 * alloc.c (Fmake_string):
4932 * character.c (string_escape_byte8):
4933 * coding.c (coding_alloc_by_realloc):
4934 * doprnt.c (doprnt):
4935 * editfns.c (Fformat):
4937 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4938 since they may not be the same number.
4939 * editfns.c (Finsert_char):
4940 * fileio.c (Finsert_file_contents):
4941 Likewise for BUF_BYTES_MAX.
4943 * image.c: Use ptrdiff_t, not int, for sizes.
4944 (slurp_file): Switch from int to ptrdiff_t.
4946 (slurp_file): Check that file size fits in both size_t (for
4947 malloc) and ptrdiff_t (for sanity and safety).
4949 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4950 if b->modtime has its maximal value.
4952 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4954 Don't assume time_t can fit into int.
4955 * buffer.h (struct buffer.modtime): Now time_t, not int.
4956 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4957 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4959 Minor fixes for signed vs unsigned integers.
4960 * character.h (MAYBE_UNIFY_CHAR):
4961 * charset.c (maybe_unify_char):
4962 * keyboard.c (read_char, reorder_modifiers):
4963 XINT -> XFASTINT, since the integer must be nonnegative.
4964 * ftfont.c (ftfont_spec_pattern):
4965 * keymap.c (access_keymap, silly_event_symbol_error):
4966 XUINT -> XFASTINT, since the integer must be nonnegative.
4967 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4968 since it makes no difference and we prefer signed.
4969 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4970 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4973 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4975 * window.h (Fwindow_frame): Declare.
4977 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4979 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4980 (SPARE_MEMORY): Always define.
4981 (LARGE_REQUEST): Remove.
4982 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4984 2011-06-06 Martin Rudalics <rudalics@gmx.at>
4986 * lisp.h: Move EXFUNS for Fframe_root_window,
4987 Fframe_first_window and Fset_frame_selected_window to window.h.
4989 * window.h: Move EXFUNS for Fframe_root_window,
4990 Fframe_first_window and Fset_frame_selected_window here from
4993 * frame.c (Fwindow_frame, Fframe_first_window)
4994 (Fframe_root_window, Fframe_selected_window)
4995 (Fset_frame_selected_window): Move to window.c.
4996 (Factive_minibuffer_window): Move to minibuf.c.
4997 (Fother_visible_frames_p): New function.
4999 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5001 * window.c (decode_window, decode_any_window): Move up in code.
5002 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5003 (inhibit_frame_unsplittable): Remove unused variable.
5004 (Fwindow_buffer): Move up and rewrite doc-string.
5005 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5006 (Fwindow_prev): New functions.
5007 (Fwindow_frame): Move here from frame.c. Accept any window as
5009 (Fframe_root_window, Fframe_first_window)
5010 (Fframe_selected_window): Move here from frame.c. Accept frame
5011 or arbitrary window as argument. Update doc-strings.
5012 (Fminibuffer_window): Move up in code.
5013 (Fwindow_minibuffer_p): Move up in code and simplify.
5014 (Fset_frame_selected_window): Move here from frame.c.
5016 (Fselected_window, select_window, Fselect_window): Move up in
5017 code. Minor doc-string fixes.
5019 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5021 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5022 Do not assume that spare memory exists; that assumption is valid
5023 only if SYSTEM_MALLOC.
5024 (LARGE_REQUEST): New macro, so that the issue of large requests
5025 is separated from the issue of spare memory.
5027 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5029 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5032 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5034 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5037 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5039 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5041 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5043 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5044 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5046 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5048 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5050 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5052 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5053 (x_clipboard_manager_save): Add return value.
5054 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5056 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5057 Obey Vx_select_enable_clipboard_manager. Catch errors in
5058 x_clipboard_manager_save (Bug#8779).
5059 (Vx_select_enable_clipboard_manager): New variable.
5060 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5062 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5064 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5066 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5068 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5069 in the current matrix if keep_current_p is non-zero.
5071 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5073 * bidi.c (bidi_level_of_next_char): Fix last change.
5075 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5077 Support bidi reordering of text covered by display properties.
5079 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5080 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5081 (bidi_cache_search, bidi_cache_iterator_state)
5082 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5083 (bidi_level_of_next_char, bidi_move_to_visually_next):
5084 Support character positions inside a run of characters covered by a
5086 (bidi_paragraph_init, bidi_resolve_explicit_1)
5087 (bidi_level_of_next_char): Call bidi_fetch_char and
5088 bidi_fetch_char_advance instead of FETCH_CHAR and
5090 (bidi_init_it): Initialize new members.
5091 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5093 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5094 instead of using explicit *_CHAR codes.
5095 (bidi_resolve_explicit, bidi_resolve_weak):
5096 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5097 bidirectional text is supported only in multibyte buffers.
5098 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5099 it to initialize the frame_window_p member of struct bidi_it.
5100 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5101 (bidi_resolve_explicit, bidi_resolve_weak)
5102 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5103 bidi_it->nchars is non-positive.
5104 (bidi_level_of_next_char): Don't try to lookup the cache for the
5105 next/previous character if nothing is cached there yet, or if we
5106 were just reseat()'ed to a new position.
5108 * xdisp.c (set_cursor_from_row): Set start and stop points
5109 according to the row's direction when priming the loop that looks
5110 for the glyph on which to display cursor.
5111 (single_display_spec_intangible_p): Function deleted.
5112 (display_prop_intangible_p): Reimplement to call
5113 handle_display_spec instead of single_display_spec_intangible_p.
5114 Accept 3 additional arguments needed by handle_display_spec.
5115 This fixes incorrect cursor motion across display property with complex
5116 values: lists, `(when COND...)' forms, etc.
5117 (single_display_spec_string_p): Support property values that are
5118 lists with the argument STRING its top-level element.
5119 (display_prop_string_p): Fix the condition for processing a
5120 property that is a list to be consistent with handle_display_spec.
5121 (handle_display_spec): New function, refactored from the
5122 last portion of handle_display_prop.
5123 (compute_display_string_pos): Accept additional argument
5124 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5125 value of a `display' property is a "replacing spec".
5126 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5127 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5128 the display property, but just return a value indicating whether
5129 the display property will replace the characters it covers.
5130 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5131 frame_window_p members of struct bidi_it.
5132 (compute_display_string_pos, compute_display_string_end):
5134 (push_it): Accept second argument POSITION, where pop_it should
5135 jump to continue iteration.
5136 (reseat_1): Initialize bidi_it.disp_pos.
5138 * keyboard.c (adjust_point_for_property): Adjust the call to
5139 display_prop_intangible_p to its new signature.
5141 * dispextern.h (struct bidi_it): New member frame_window_p.
5142 (bidi_init_it): Update prototypes.
5143 (display_prop_intangible_p): Update prototype.
5144 (compute_display_string_pos, compute_display_string_end):
5146 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5149 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5151 Malloc failure behavior now depends on size of allocation.
5152 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5153 * lisp.h: Change signatures accordingly.
5154 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5155 All callers changed. (Bug#8762)
5157 * gnutls.c: Use Emacs's memory allocators.
5158 Without this change, the gnutls library would invoke malloc etc.
5159 directly, which causes problems on non-SYNC_INPUT hosts, and which
5160 runs afoul of improving memory_full behavior. (Bug#8761)
5161 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5162 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5163 xfree instead of the default malloc, realloc, free.
5164 (Fgnutls_boot): No need to check for memory allocation failure,
5165 since xmalloc does that for us.
5167 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5168 * category.c (hash_get_category_set):
5169 * ccl.c (ccl_driver):
5170 * charset.c (Fdefine_charset_internal):
5171 * charset.h (struct charset.hash_index):
5172 * composite.c (get_composition_id, gstring_lookup_cache)
5173 (composition_gstring_put_cache):
5174 * composite.h (struct composition.hash_index):
5175 * dispextern.h (struct image.hash):
5176 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5177 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5178 (hashfn_equal, hashfn_user_defined, make_hash_table)
5179 (maybe_resize_hash_table, hash_lookup, hash_put)
5180 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5181 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5182 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5183 * image.c (make_image, search_image_cache, lookup_image)
5184 (xpm_put_color_table_h):
5185 * lisp.h (struct Lisp_Hash_Table):
5186 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5187 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5188 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5189 * alloc.c (allocate_vectorlike):
5190 Check for overflow in vector size calculations.
5191 * ccl.c (ccl_driver):
5192 Check for overflow when converting EMACS_INT to int.
5193 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5194 need to be updated by these changes.
5195 * fns.c (make_hash_table, maybe_resize_hash_table):
5196 Check for integer overflow with large hash tables.
5197 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5198 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5199 (SXHASH_REDUCE): New macro.
5200 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5201 Use it instead of discarding useful hash info with large hash values.
5202 (sxhash_float): New function.
5203 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5204 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5205 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5206 Rewrite to use FIXNUM_BITS, as this simplifies things.
5207 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5208 Adjust signatures to match updated version of code.
5209 (consing_since_gc): Now EMACS_INT, since a single hash table can
5210 use more than INT_MAX bytes.
5212 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5214 Make it possible to build with GCC-4.6+ -O2 -flto.
5216 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5218 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5220 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5221 Call minibuffer-inactive-mode.
5223 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5225 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5226 Update dependencies.
5228 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5230 * data.c (init_data): Remove code for UTS, this system is not
5233 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5235 Don't force ./temacs to start in terminal mode.
5237 * frame.c (make_initial_frame): Initialize faces in all cases, not
5238 only when CANNOT_DUMP is defined.
5239 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5241 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5243 * dispnew.c (add_window_display_history): Use const for the string
5244 pointer. Remove declaration, not needed.
5246 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5248 Use 'inline', not 'INLINE'.
5249 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5250 * alloc.c, fontset.c (INLINE): Remove.
5251 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5252 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5253 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5254 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5255 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5257 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5259 Make it possible to run ./temacs.
5261 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5262 syms_of_callproc does the same thing. Remove test for
5263 "initialized", do it in the caller.
5264 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5266 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5268 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5269 (read_minibuf): Use get_minibuffer.
5270 (syms_of_minibuf): Use DEFSYM.
5271 (Qmetadata): New var.
5272 * data.c (Qbuffer): Don't make it static.
5273 (syms_of_data): Use DEFSYM.
5275 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5277 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5278 (CCL_CODE_MIN): New macro.
5280 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5282 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5284 * eval.c (Qdebug): Now static.
5285 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5286 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5287 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5289 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5291 * image.c: Various fixes to ImageMagick code comments.
5292 (Fimagemagick_types): Doc fix.
5294 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5296 Minor fixes prompted by GCC 4.6.0 warnings.
5298 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5300 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5301 (x_clipboard_manager_save_all): Move extern decl to ...
5302 * xterm.h: ... here, so that it can be checked for consistency.
5304 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5306 * xselect.c (x_clipboard_manager_save_frame)
5307 (x_clipboard_manager_save_all): New functions.
5308 (Fx_clipboard_manager_save): Lisp function deleted.
5310 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5311 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5313 * xterm.h: Update prototype.
5315 2011-05-28 William Xu <william.xwl@gmail.com>
5317 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5320 2011-05-28 Jim Meyering <meyering@redhat.com>
5322 Avoid a sign-extension bug in crypto_hash_function.
5323 * fns.c (to_uchar): Define.
5324 (crypto_hash_function): Use it to convert some newly-signed
5325 variables to unsigned, to avoid sign-extension bugs. For example,
5326 without this change, (md5 "truc") would evaluate to
5327 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5328 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5329 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5331 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5333 Integer overflow fixes.
5335 * dbusbind.c: Serial number integer overflow fixes.
5336 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5337 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5338 to hold a serial number that is too large for a fixnum.
5339 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5340 Check for serial numbers out of range. Decode any serial number
5341 that was so large that it became a float. (Bug#8722)
5343 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5344 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5345 Use XFASTINT rather than XUINT when numbers are nonnegative.
5346 (xd_append_arg, Fdbus_method_return_internal):
5347 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5348 arguments, check that Lisp number is nonnegative, rather than
5349 silently wrapping negative numbers around. (Bug#8722)
5350 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5353 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5355 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5357 ccl: add integer overflow checks
5358 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5359 (IN_INT_RANGE): New macros.
5360 (ccl_driver): Use them to check for integer overflow when
5361 decoding a CCL program. Many of the new checks are whether XINT (x)
5362 fits in int; it doesn't always, on 64-bit hosts. The new version
5363 doesn't catch all possible integer overflows, but it's an
5364 improvement. (Bug#8719)
5366 * alloc.c (make_event_array): Use XINT, not XUINT.
5367 There's no need for unsigned here.
5369 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5370 This follows up to the 2011-05-06 change that substituted uintptr_t
5371 for EMACS_INT. This case wasn't caught back then.
5373 Rework Fformat to avoid integer overflow issues.
5374 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5375 now (part of C89). Include <verify.h>.
5376 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5377 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5378 (Fformat): Avoid the prepass trying to compute sizes; it was only
5379 approximate and thus did not catch overflow reliably. Instead, walk
5380 through the format just once, formatting and computing sizes as we go,
5381 checking for integer overflow at every step, and allocating a larger
5382 buffer as needed. Keep track separately whether the format is
5383 multibyte. Keep only the most-recently calculated precision, rather
5384 than them all. Record whether each argument has been converted to
5385 string. Use EMACS_INT, not int, for byte and char and arg counts.
5386 Support field widths and precisions larger than INT_MAX. Avoid
5387 sprintf's undefined behavior with conversion specifications such as %#d
5388 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5389 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5390 formatting out-of-range floating point numbers with int
5393 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5395 * data.c: Avoid integer truncation in expressions involving floats.
5396 * data.c: Include <intprops.h>.
5397 (arith_driver): When there's an integer overflow in an expression
5398 involving floating point, convert the integers to floating point
5399 so that the resulting value does not suffer from catastrophic
5400 integer truncation. For example, on a 64-bit host (* 4
5401 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5402 Do not rely on undefined behavior after integer overflow.
5404 merge count_size_as_multibyte, parse_str_to_multibyte
5405 * character.c, character.h (count_size_as_multibyte):
5406 Rename from parse_str_to_multibyte; all uses changed.
5407 Check for integer overflow.
5408 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5409 since it's now a duplicate of the other. This is more of
5410 a character than a buffer op, so better that it's in character.c.
5411 * fns.c, print.c: Adjust to above changes.
5413 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5415 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5417 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5419 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5420 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5421 (x_clipboard_manager_save): Now static.
5422 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5424 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5425 (crypto_hash_function): Now static.
5426 Fix pointer signedness problems. Avoid unnecessary initializations.
5428 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5430 * termhooks.h (Vselection_alist): Make it terminal-local.
5432 * terminal.c (create_terminal): Initialize it.
5434 * xselect.c: Support for clipboard managers.
5435 (Vselection_alist): Move to termhooks.h as terminal-local var.
5436 (LOCAL_SELECTION): New macro.
5437 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5438 (symbol_to_x_atom): Remove gratuitous arg.
5439 (x_handle_selection_request, lisp_data_to_selection_data)
5440 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5441 (x_own_selection, x_get_local_selection, x_convert_selection):
5442 New arg, specifying work frame. Use terminal-local Vselection_alist.
5443 (some_frame_on_display): Delete unused function.
5444 (Fx_own_selection_internal, Fx_get_selection_internal)
5445 (Fx_disown_selection_internal, Fx_selection_owner_p)
5446 (Fx_selection_exists_p): New optional frame arg.
5447 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5448 (x_handle_selection_clear): Don't treat other terminals with the
5449 same keyboard specially. Use the terminal-local Vselection_alist.
5450 (x_clear_frame_selections): Use Frun_hook_with_args.
5452 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5454 * xterm.h: Add support for those atoms.
5456 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5458 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5459 (converted_selections, conversion_fail_tag): New global variables.
5460 (x_selection_request_lisp_error): Free the above.
5461 (x_get_local_selection): Remove unnecessary code.
5462 (x_reply_selection_request): Args changed; handle arbitrary array
5463 of converted selections stored in converted_selections.
5464 Separate the XChangeProperty and SelectionNotify steps.
5465 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5466 (x_convert_selection): New function.
5467 (x_handle_selection_event): Simplify.
5468 (x_get_foreign_selection): Don't ignore incoming requests while
5469 waiting for an answer; this will fail when we implement
5470 SAVE_TARGETS, and seems unnecessary anyway.
5471 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5472 (Vx_sent_selection_functions): Doc fix.
5474 2011-05-26 Leo Liu <sdl.web@gmail.com>
5476 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5478 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5480 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5482 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5483 for fringe update if it has periodic bitmap.
5484 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5485 and fringe_bitmap_periodic_p.
5487 * fringe.c (get_fringe_bitmap_data): New function.
5488 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5489 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5490 row. Mark glyph row for fringe update if periodicity changed.
5492 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5493 for fringe update unless it has periodic bitmap.
5495 2011-05-25 Kenichi Handa <handa@m17n.org>
5497 * xdisp.c (get_next_display_element): Set correct it->face_id for
5498 a static composition.
5500 2011-05-24 Leo Liu <sdl.web@gmail.com>
5503 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5505 * fns.c (crypto_hash_function, Fsha1): New function.
5506 (Fmd5): Use crypto_hash_function.
5507 (syms_of_fns): Add Ssha1.
5509 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5511 * gnutls.c: Remove unused macros.
5512 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5513 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5514 Remove macros that are defined and never used.
5515 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5517 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5519 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5520 (Fx_get_selection_internal): Minor cleanup.
5521 (Fx_own_selection_internal): Rename arguments for consistency with
5524 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5526 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5528 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5530 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5532 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5534 * dispnew.c (scrolling_window): Don't exclude the case that the
5535 last enabled row in the desired matrix touches the bottom boundary.
5537 2011-05-21 Glenn Morris <rgm@gnu.org>
5539 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5540 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5541 and add some more files.
5543 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5545 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5546 report_file_error introduced by the change from 2011-05-07.
5548 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5550 * systime.h (Time): Define only if emacs is defined.
5551 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5552 where the include path doesn't have X11/X.h by default. See
5553 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5555 2011-05-20 Kenichi Handa <handa@m17n.org>
5557 * composite.c (find_automatic_composition): Fix previous change.
5559 2011-05-20 Glenn Morris <rgm@gnu.org>
5561 * lisp.mk: New file, split from Makefile.in.
5562 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5563 (shortlisp): Remove.
5564 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5566 2011-05-19 Glenn Morris <rgm@gnu.org>
5568 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5569 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5570 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5571 (lisp): Set the order to that of loadup.el.
5572 (shortlisp): Make it a copy of $lisp.
5573 (SOME_MACHINE_LISP): Remove.
5574 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5575 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5577 2011-05-18 Kenichi Handa <handa@m17n.org>
5579 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5580 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5581 (find_automatic_composition): Mostly rewrite for efficiency.
5583 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5585 * makefile.w32-in: Update dependencies.
5587 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5589 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5590 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5592 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5594 Fix some integer overflow issues, such as string length overflow.
5596 * insdel.c (count_size_as_multibyte): Check for string overflow.
5598 * character.c (lisp_string_width): Check for string overflow.
5599 Use EMACS_INT, not int, for string indexes and lengths; in
5600 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5601 the resulting string length overflows an EMACS_INT; instead,
5602 report a string overflow if no precision given. When checking for
5603 precision exhaustion, use a check that cannot possibly have
5604 integer overflow. (Bug#8675)
5605 * character.h (lisp_string_width): Adjust to new signature.
5607 * alloc.c (string_overflow): New function.
5608 (Fmake_string): Use it. This doesn't change behavior, but saves
5609 a few bytes and will simplify future changes.
5610 * character.c (string_escape_byte8): Likewise.
5611 * lisp.h (string_overflow): New decl.
5613 Fixups, following up to the user-interface timestamp change.
5614 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5615 for UI timestamps, instead of unsigned long.
5616 * msdos.c (mouse_get_pos): Likewise.
5617 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5618 * w32gui.h (Time): Define by including "systime.h" rather than by
5619 declaring it ourselves. (Bug#8664)
5621 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5622 * image.c (clear_image_cache): Likewise.
5624 * term.c (term_mouse_position): Don't assume time_t wraparound.
5626 Be more systematic about user-interface timestamps.
5627 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5628 and sometimes 'EMACS_UINT', to represent these timestamps.
5629 This change causes it to use 'Time' uniformly, as that's what X uses.
5630 This makes the code easier to follow, and makes it easier to catch
5631 integer overflow bugs such as Bug#8664.
5632 * frame.c (Fmouse_position, Fmouse_pixel_position):
5633 Use Time, not unsigned long, for user-interface timestamps.
5634 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5635 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5636 * keyboard.h (last_event_timestamp): Likewise.
5637 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5638 * menu.h (xmenu_show): Likewise.
5639 * term.c (term_mouse_position): Likewise.
5640 * termhooks.h (struct input_event.timestamp): Likewise.
5641 (struct terminal.mouse_position_hook): Likewise.
5642 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5643 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5644 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5645 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5647 * menu.h, termhooks.h: Include "systime.h", for Time.
5649 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5650 Don't assume that the difference between two unsigned long values
5651 can fit into an integer. At this point, we know button_down_time
5652 <= event->timestamp, so the difference must be nonnegative, so
5653 there's no need to cast the result if double-click-time is
5654 nonnegative, as it should be; check that it's nonnegative, just in
5655 case. This bug is triggered when events are more than 2**31 ms
5656 apart (about 25 days). (Bug#8664)
5658 * xselect.c (last_event_timestamp): Remove duplicate decl.
5659 (x_own_selection): Remove needless cast to unsigned long.
5661 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5662 that always fit in int. Use a sentinel instead of a counter, to
5663 avoid a temp and to allay GCC's concerns about possible int overflow.
5664 * frame.h (struct frame): Use int for menu_bar_items_used
5665 instead of EMACS_INT, since it always fits in int.
5667 * menu.c (grow_menu_items): Check for int overflow.
5669 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5671 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5672 Before, the code was not consistent. These values cannot exceed
5673 2**31 - 1 so there's no need to make them unsigned.
5674 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5675 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5676 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5678 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5680 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5681 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5682 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5683 presumably because the widths might not match.
5685 * window.c (size_window): Avoid needless test at loop start.
5687 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5689 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5691 2011-05-12 Drew Adams <drew.adams@oracle.com>
5693 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5695 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5697 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5698 `width' to `bar_area_x' and `bar_area_width', respectively.
5699 (x_scroll_run): Take account of fringe background extension.
5701 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5702 Rename local vars `left' and `width' to `bar_area_x' and
5703 `bar_area_width', respectively.
5704 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5705 background extension.
5707 2011-05-10 Jim Meyering <meyering@redhat.com>
5709 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5711 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5713 * image.c (Finit_image_library): Return t for built-in image types,
5714 like pbm and xbm. (Bug#8640)
5716 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5718 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5720 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5722 * w32console.c (Fset_screen_color): Doc fix.
5723 (Fget_screen_color): New function.
5724 (syms_of_ntterm): Defsubr it.
5726 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5727 unlink the temporary file if Fcall_process didn't create it in the
5729 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5730 child process will be redirected to a file specified with `:file'.
5731 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5732 cue to call_process_cleanup not to close that handle.
5734 2011-05-07 Ben Key <bkey76@gmail.com>
5736 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5737 one of two shell specific rules, either bootstrap-temacs-CMD or
5738 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5739 to the previous implementation of the bootstrap-temacs rule.
5740 The bootstrap-temacs-CMD rule is similar to the previous
5741 implementation of the bootstrap-temacs rule except that it
5742 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5745 These changes, along with some changes to nt/configure.bat,
5746 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5747 earlier fix to add support for --cflags and --ldflags options
5748 that include quotes so that it works whether make uses cmd or
5751 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
5753 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5754 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5756 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5757 a string. Handle both cases.
5758 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5759 (Fdbus_register_method): Use Qinvalid_function.
5761 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5763 * makefile.w32-in: Update dependencies.
5764 (LISP_H): Add inttypes.h and stdin.h.
5765 (PROCESS_H): Add unistd.h.
5767 2011-05-06 Eli Zaretskii <eliz@gnu.org>
5769 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5770 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5772 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
5774 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5776 * term.c (vfatal): Remove stray call to va_end.
5777 It's not needed and the C Standard doesn't allow it here anyway.
5779 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5780 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5782 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5785 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5787 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5789 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5791 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5793 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5795 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5796 * charset.c (Fdefine_charset_internal): Don't initialize
5797 charset.code_space[15]. The value was garbage, on hosts with
5798 32-bit int (Bug#8600).
5800 * lread.c (read_integer): Be more consistent with string-to-number.
5801 Use string_to_number to do the actual conversion; this avoids
5802 rounding errors and fixes some other screwups. Without this fix,
5803 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5804 (digit_to_number): Move earlier, for benefit of read_integer.
5805 Return -1 if the digit is out of range for the base, -2 if it is
5806 not a digit in any supported base. (Bug#8602)
5808 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5810 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5811 to match comment at start of function. This also removes a
5812 GCC warning about overflow in a 32+64-bit port.
5814 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5816 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5817 Reported by Stefan Monnier in
5818 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
5819 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5820 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
5822 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5823 (EMACS_UINTPTR): Likewise, with uintptr_t.
5825 * lisp.h: Prefer 64-bit EMACS_INT if available.
5826 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5827 on 32-bit hosts that have 64-bit int, so that they can access
5829 However, temporarily disable this change unless the temporary
5830 symbol WIDE_EMACS_INT is defined.
5832 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5834 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5835 This removes an assumption that EMACS_INT and long are the same
5836 width as pointers. The assumption is true for Emacs porting targets
5837 now, but we want to make other targets possible.
5838 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5839 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5840 In the rest of the code, change types of integers that hold casted
5841 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5842 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5843 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5844 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5845 No need to cast type when ORing.
5846 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5847 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5848 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5849 assume EMACS_INT is the same width as char *.
5850 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5851 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5852 Remove no-longer-needed casts.
5853 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5854 (xg_tool_bar_help_callback, xg_make_tool_item):
5855 Use EMACS_INTPTR to hold an integer
5856 that will be cast to void *; this can avoid a GCC warning
5857 if EMACS_INT is not the same width as void *.
5858 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5859 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5860 (current_message_1, set_message_1):
5861 Use a local to convert to proper width without a cast.
5862 * xmenu.c (dialog_selection_callback): Likewise.
5864 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5865 Also, don't assume VALBITS / RAND_BITS is less than 5,
5866 and don't rely on undefined behavior when shifting a 1 left into
5868 * lisp.h (get_random): Change signature to match.
5870 * lread.c (hash_string): Use size_t, not int, for hash computation.
5871 Normally we prefer signed values; but hashing is special, because
5872 it's better to use unsigned division on hash table sizes so that
5873 the remainder is nonnegative. Also, size_t is the natural width
5874 for hashing into memory. The previous code used 'int', which doesn't
5875 retain enough info to hash well into very large tables.
5876 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5878 * dbusbind.c: Don't possibly lose pointer info when converting.
5879 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5880 Use XPNTR rather than XHASH, so that the high-order bits of
5881 the pointer aren't lost when converting through void *.
5883 * eval.c (Fautoload): Don't double-shift a pointer.
5885 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5887 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5889 * gnutls.c (DEF_GNUTLS_FN):
5890 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5892 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5894 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5897 2011-05-05 Eli Zaretskii <eliz@gnu.org>
5899 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5900 New version that can reserve upto 2GB of heap space.
5902 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
5904 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5906 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5908 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5909 `gnutls_certificate_set_x509_key_file'.
5911 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
5913 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5914 Update dependencies.
5916 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5918 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5919 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5920 Remove unused parameter `fildes'.
5921 * process.c (read_process_output, send_process): Don't pass it.
5923 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5925 Fix previous change: the library cache is defined in w32.c.
5926 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5927 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5929 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5931 Implement dynamic loading of GnuTLS on Windows.
5933 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5934 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5935 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5938 * gnutls.c (Qgnutls_dll): Define.
5939 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5940 (gnutls_*): Declare function pointers.
5941 (init_gnutls_functions): New function to initialize function pointers.
5942 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5943 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5944 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5945 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5946 (emacs_gnutls_write, emacs_gnutls_read)
5947 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5948 (Fgnutls_available_p): New function.
5949 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5950 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5951 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5953 * image.c: Include w32.h.
5954 (Vimage_type_cache): Delete.
5955 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5956 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5957 (w32_delayed_load): Move to w32.c.
5959 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5961 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5962 (w32_delayed_load): Move from image.c. When loading a library, record
5963 its filename in the :loaded-from property of the library id.
5964 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5965 Initialize and staticpro them.
5966 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5968 * process.c: Include lisp.h before w32.h, not after.
5969 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5970 instead of gnutls_record_check_pending.
5972 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5974 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5976 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5977 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5980 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5982 * xterm.c (x_set_frame_alpha): Do not set property on anything
5983 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5985 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5987 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5989 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5991 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5992 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5993 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5994 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5995 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5996 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5997 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5998 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5999 (Qgnutls_bootprop_callbacks_verify): Make static.
6001 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6003 * callproc.c: Indentation fixup.
6005 * sysdep.c (wait_for_termination_1): Make static.
6006 (wait_for_termination, interruptible_wait_for_termination):
6007 Move after wait_for_termination_1.
6009 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6011 * sysdep.c (interruptible_wait_for_termination): New function
6012 which is like wait_for_termination, but allows keyboard
6015 * callproc.c (Fcall_process): Add (:file "file") as an option for
6017 (Fcall_process_region): Ditto.
6019 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6021 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6022 rather than `XVECTOR (FOO)->size'.
6024 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6025 inttypes.h, as a gnulib replacement is used if it not available in
6028 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6030 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6031 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6032 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6034 * coding.c (coding_alloc_by_realloc): Error out if destination
6035 will grow beyond MOST_POSITIVE_FIXNUM.
6036 (decode_coding_emacs_mule): Abort if there isn't enough place in
6037 charbuf for the composition carryover bytes. Reserve an extra
6038 space for up to 2 characters produced in a loop.
6039 (decode_coding_iso_2022): Abort if there isn't enough place in
6040 charbuf for the composition carryover bytes.
6042 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6044 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6045 aborting when %lld or %lll format is passed.
6046 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6047 %llo or %llx format is passed. (Bug#8545)
6049 * window.c (window_scroll_line_based): Use a marker instead of
6050 simple variables to record original value of point. (Bug#7952)
6052 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6053 produced by %s or %c overflows available buffer space. (Bug#8545)
6055 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6057 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6058 (SIZE_MAX): Move defn after all includes, as they might #define it.
6060 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6062 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6064 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6066 * keyboard.c (Qdelayed_warnings_hook): Define.
6067 (command_loop_1): Run `delayed-warnings-hook'
6068 if Vdelayed_warnings_list is non-nil.
6069 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6070 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6072 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6074 * doprnt.c (doprnt): Don't return value smaller than the buffer
6075 size if the message was truncated. (Bug#8545).
6077 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6079 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6080 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6082 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6084 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6086 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6088 * makefile.w32-in: Update dependencies.
6090 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6092 Improve `doprnt' and its usage. (Bug#8545)
6093 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6094 `format_end'. Remove support for %l as a conversion specifier.
6095 Don't use xrealloc. Improve diagnostics when the %l size modifier
6096 is used. Update the commentary.
6098 * eval.c (verror): Simplify calculation of size_t.
6100 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6103 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6105 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6108 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6110 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6111 This makes this file independent of the recent pseudovector change.
6113 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6115 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6117 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6118 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6119 Remove unused local.
6120 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6122 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6123 GCC 4.6.0 optimizes based on type-based alias analysis.
6124 For example, if b is of type struct buffer * and v of type struct
6125 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6126 != &v->size, and therefore "v->size = 1; b->size = 2; return
6127 v->size;" must therefore return 1. This assumption is incorrect
6128 for Emacs, since it type-puns struct Lisp_Vector * with many other
6129 types. To fix this problem, this patch adds a new type struct
6130 vectorlike_header that documents the constraints on layout of vectors
6131 and pseudovectors, and helps optimizing compilers not get fooled
6132 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6133 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6134 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6136 (XSETPVECTYPE): Rewrite in terms of new macro.
6137 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6138 This is a bit clearer, and further avoids the possibility of
6139 undesirable aliasing.
6140 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6141 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6142 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6143 since Lisp_Subr is a special case (no "next" field).
6144 (ASIZE): Now uses header.size rather than size.
6145 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6146 to avoid the hassle of writing XVECTOR (foo)->header.size.
6147 (struct vectorlike_header): New type.
6148 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6149 object, to help avoid aliasing.
6150 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6151 (SUBRP): Likewise, since Lisp_Subr is a special case.
6152 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6153 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6154 (struct Lisp_Hash_Table): Combine first two members into a single
6155 struct vectorlike_header member. All uses of "size" and "next" members
6156 changed to be "header.size" and "header.next".
6157 * buffer.h (struct buffer): Likewise.
6158 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6159 * frame.h (struct frame): Likewise.
6160 * process.h (struct Lisp_Process): Likewise.
6161 * termhooks.h (struct terminal): Likewise.
6162 * window.c (struct save_window_data, struct saved_window): Likewise.
6163 * window.h (struct window): Likewise.
6164 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6165 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6166 * buffer.c (init_buffer_once): Likewise.
6167 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6169 * process.c (Fformat_network_address): Use local var for size,
6172 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6174 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6175 * data.c (atof): Remove decl; no longer used or needed.
6176 (digit_to_number): Move to lread.c.
6177 (Fstring_to_number): Use new string_to_number function, to be
6178 consistent with how the Lisp reader treats infinities and NaNs.
6179 Do not assume that floating-point numbers represent EMACS_INT
6180 without losing information; this is not true on most 64-bit hosts.
6181 Avoid double-rounding errors, by insisting on integers when
6182 parsing non-base-10 numbers, as the documentation specifies.
6183 * lisp.h (string_to_number): New decl, replacing ...
6184 (isfloat_string): Remove.
6185 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6186 (read1): Do not accept +. and -. as integers; this
6187 appears to have been a coding error. Similarly, do not accept
6188 strings like +-1e0 as floating point numbers. Do not report
6189 overflow for integer overflows unless the base is not 10 which
6190 means we have no simple and reliable way to continue.
6191 Break out the floating-point parsing into a new
6192 function string_to_number, so that Fstring_to_number parses
6193 floating point numbers consistently with the Lisp reader.
6194 (digit_to_number): Move here from data.c. Make it static inline.
6195 (E_CHAR, EXP_INT): Remove, replacing with ...
6196 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6197 (string_to_number): New function, replacing isfloat_string.
6198 This function checks for valid syntax and produces the resulting
6199 Lisp float number too. Rework it so that string-to-number
6200 no longer mishandles examples like "1.0e+". Use strtoumax,
6201 so that overflow for non-base-10 numbers is reported only when
6202 there's no portable and simple way to convert to floating point.
6204 * textprop.c (set_text_properties_1): Rewrite for clarity,
6205 and to avoid GCC warning about integer overflow.
6207 * intervals.h (struct interval): Use EMACS_INT for members
6208 where EMACS_UINT might cause problems. See
6209 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6210 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6211 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6213 (offset_intervals): Tell GCC not to worry about length overflow
6214 when negating a negative length.
6216 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6217 (overrun_check_free): Likewise.
6219 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6220 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6223 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6224 (gnutls_make_error): Rename local to avoid shadowing.
6225 (gnutls_emacs_global_deinit): ifdef out; not used.
6226 (Fgnutls_boot): Use const for pointer to readonly storage.
6227 Comment out unused local. Fix pointer signedness problems.
6229 * lread.c (openp): Don't stuff size_t into an 'int'.
6230 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6231 about possible signed overflow.
6233 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6234 (GDK_KEY_g): Don't define if already defined.
6235 (xg_prepare_tooltip): Avoid pointer signedness problem.
6236 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6238 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6239 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6241 * xfns.c (Fx_window_property): Simplify a bit,
6242 to make a bit faster and to avoid GCC 4.6.0 warning.
6243 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6245 * fns.c (internal_equal): Don't assume size_t fits in int.
6247 * alloc.c (compact_small_strings): Tighten assertion a little.
6249 Replace pEd with more-general pI, and fix some printf arg casts.
6250 * lisp.h (pI): New macro, generalizing old pEd macro to other
6251 conversion specifiers. For example, use "...%"pI"d..." rather
6252 than "...%"pEd"...".
6253 (pEd): Remove. All uses replaced with similar uses of pI.
6254 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6255 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6256 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6257 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6258 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6259 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6260 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6262 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6263 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6264 * print.c (safe_debug_print, print_object): Likewise.
6265 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6267 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6268 avoiding the 0 flag, which is not portable.
6269 * process.c (Fmake_network_process): Use pI to avoid cast.
6270 * region-cache.c (pp_cache): Likewise.
6271 * xdisp.c (decode_mode_spec): Likewise.
6272 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6273 behavior on 64-bit hosts with printf arg.
6274 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6275 (x_stop_queuing_selection_requests): Likewise.
6276 (x_get_window_property): Don't truncate byte count to an 'int'
6279 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6280 here, since it parses constructs like leading '-' and spaces,
6281 which are not wanted; and it overflows with large numbers.
6282 Instead, simply match F[0-9]+, which is what is wanted anyway.
6284 * alloc.c: Remove unportable assumptions about struct layout.
6285 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6286 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6287 (allocate_vectorlike, make_pure_vector): Use the new macros,
6288 plus offsetof, to remove unportable assumptions about struct layout.
6289 These assumptions hold on all porting targets that I know of, but
6290 they are not guaranteed, they're easy to remove, and removing them
6291 makes further changes easier.
6293 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6294 This doesn't fix a bug but makes the code clearer.
6295 (string_overrun_cookie): Now const. Use initializers that
6296 don't formally overflow signed char, to avoid warnings.
6297 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6298 can cause Emacs to crash when string overrun checking is enabled.
6299 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6300 multiple of sizeof (EMACS_INT); it need not be, if
6301 alignof(EMACS_INT) < sizeof (EMACS_INT).
6302 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6304 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6306 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6308 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6310 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6311 supposed to be handshaking. (Bug#8556)
6312 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6314 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6316 * lisp.h (Qdebug): List symbol.
6317 * eval.c (Qdebug): Restore global linkage.
6318 * keyboard.c (debug-on-event): New variable.
6319 (handle_user_signal): Break into debugger when debug-on-event
6320 matches the current signal symbol.
6322 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6324 * alloc.c (check_sblock, check_string_bytes)
6325 (check_string_free_list): Convert to standard C.
6327 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6329 * w32.c (emacs_gnutls_push): Fix typo.
6331 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6333 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6334 "cast to pointer from integer of different size".
6336 Improve doprnt and its use in verror. (Bug#8545)
6337 * doprnt.c (doprnt): Document the set of format control sequences
6338 supported by the function. Use SAFE_ALLOCA instead of always
6341 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6342 is one byte too soon. Don't use xrealloc; instead xfree and
6345 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6347 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6350 * gnutls.c: Renamed global_initialized to
6351 gnutls_global_initialized. Added internals for the
6352 :verify-hostname-error, :verify-error, and :verify-flags
6353 parameters of `gnutls-boot' and documented those parameters in the
6354 docstring. Start callback support.
6355 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6356 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6357 on error. Return error code.
6358 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6359 (emacs_gnutls_read): Likewise.
6360 (Fgnutls_boot): Return handshake error code.
6361 (emacs_gnutls_handle_error): New function.
6362 (wsaerror_to_errno): Likewise.
6364 * w32.h (emacs_gnutls_pull): Add prototype.
6365 (emacs_gnutls_push): Likewise.
6367 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6368 (emacs_gnutls_push): Likewise.
6370 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6372 * process.c (wait_reading_process_output): Check if GnuTLS
6373 buffered some data internally if no FDs are set for TLS
6376 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6377 (LIBS): Link to USER_LIBS.
6378 ($(BLD)/gnutls.$(0)): New target.
6380 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6382 * xdisp.c (handle_single_display_spec): Rename the
6383 display_replaced_before_p argument into display_replaced_p, to
6384 make it consistent with the commentary. Fix typos in the
6387 * textprop.c (syms_of_textprop): Remove dead code.
6388 (copy_text_properties): Delete obsolete commentary about an
6389 interface that was deleted long ago. Fix typos in the description
6392 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6393 to changes in oldXMenu/XMenu.h from 2011-04-16.
6394 <menu_help_message, prev_menu_help_message>: Constify.
6395 (IT_menu_make_room): menu->help_text is now `const char **';
6398 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6399 to changes in oldXMenu/XMenu.h from 2011-04-16.
6400 (struct XMenu): Declare `help_text' `const char **'.
6402 * xfaces.c <Qunspecified>: Make extern again.
6404 * syntax.c: Include sys/types.h before including regex.h, as
6407 * doc.c (get_doc_string): Improve the format passed to `error'.
6409 * doprnt.c (doprnt): Improve commentary.
6411 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6413 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6416 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6417 changes in globals.h immediately force recompilation.
6418 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6419 $(CURDIR)/s/ms-w32.h.
6420 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6422 * character.c (Fchar_direction): Function deleted.
6423 (syms_of_character): Don't defsubr it.
6424 <char-direction-table>: Deleted.
6426 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6428 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6429 * doprnt.c: Include limits.h.
6430 (SIZE_MAX): New macro.
6431 (doprnt): Return a size_t value. 2nd arg is now size_t.
6432 Many local variables are now size_t instead of int or unsigned.
6433 Improve overflow protection. Support `l' modifier for integer
6434 conversions. Support %l conversion. Don't assume an EMACS_INT
6435 argument for integer conversions and for %c.
6437 * lisp.h (doprnt): Restore prototype.
6439 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6442 * Makefile.in (base_obj): Add back doprnt.o.
6444 * deps.mk (doprnt.o): Add back prerequisites.
6445 (callint.o): Depend on character.h.
6447 * eval.c (internal_lisp_condition_case): Include the handler
6448 representation in the error message.
6449 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6450 when breaking from the loop.
6452 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6454 * callint.c (Fcall_interactively): When displaying error message
6455 about invalid control letter, pass the character's codepoint, not
6456 a pointer to its multibyte form. Improve display of the character
6457 in octal and display also its hex code.
6459 * character.c (char_string): Use %x to display the (unsigned)
6460 codepoint of an invalid character, to avoid displaying a bogus
6463 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6464 `error', not SYMBOL_NAME itself.
6466 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6467 character arguments to `error'.
6469 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6470 to `error' in error message about FINAL_CHAR argument. Make sure
6471 FINAL_CHAR is a character, and use %c when it is passed as
6472 argument to `error'.
6474 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6476 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6478 * w32.c: Include <time.h>.
6479 (sys_localtime): New function.
6481 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6483 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6485 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6487 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6489 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6492 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6494 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6495 gl_state.e_property when gl_state.object is Qt.
6497 * insdel.c (make_gap_larger): Remove limitation of buffer size
6500 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6502 * xdisp.c (lookup_glyphless_char_display)
6503 (produce_glyphless_glyph): Handle cons cell entry in
6504 glyphless-char-display.
6505 (Vglyphless_char_display): Document it.
6507 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6508 glyphless-char-display.
6510 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6512 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6514 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6516 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6517 definition for no-X builds.
6519 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6521 Static checks with GCC 4.6.0 and non-default toolkits.
6523 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6525 * process.c (keyboard_bit_set): Define only if SIGIO.
6526 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6527 (send_process): Repair possible setjmp clobbering.
6529 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6531 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6533 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6535 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6536 Define only if needed.
6538 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6539 by pacifying GCC about it. Maybe it's time to retire it?
6540 * xfaces.c (USG, __TIMEVAL__): Likewise.
6542 * dispextern.h (struct redisplay_interface): Rename param
6544 * termhooks.h (struct terminal): Likewise.
6545 * xterm.c (xembed_send_message): Likewise.
6547 * insdel.c (make_gap_smaller): Define only if
6548 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6550 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6553 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6554 so that we aren't warned about unused symbols.
6556 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6558 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6560 * xfns.c (x_real_positions): Mark locals as initialized.
6562 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6564 * xterm.c: Fix problems found by static analysis with other toolkits.
6565 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6566 (x_dispatch_event): Declare static if USE_GTK, and
6567 define if USE_GTK || USE_X_TOOLKIT.
6568 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6569 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6570 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6571 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6573 * xmenu.c (menu_help_callback): Pointer type fixes.
6574 Use const pointers when pointing at readonly data. Avoid pointer
6576 (FALSE): Remove unused macro.
6577 (update_frame_menubar): Remove unused decl.
6579 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6581 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6582 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6583 (single_menu_item): Rename local to avoid shadowing.
6585 * keyboard.c (make_lispy_event): Remove unused local var.
6587 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6588 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6590 * bitmaps: Change bitmaps from unsigned char back to the X11
6591 compatible char. Avoid the old compiler warnings about
6592 out-of-range initializers by using, for example, '\xab' rather
6595 * xgselect.c (xgselect_initialize): Check vs interface
6596 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6598 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6600 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6601 to read-only memory.
6603 * fns.c (vector): Remove; this old hack is no longer needed.
6605 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6607 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6609 * xrdb.c (x_load_resources): Omit unused local.
6611 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6612 (x_window): Rename locals to avoid shadowing.
6613 (USG): Use the kludged USG macro, to pacify gcc.
6615 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6616 (x_term_init): Remove local to avoid shadowing.
6618 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6620 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6621 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6623 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6625 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6627 Fix regex.c, syntax.c and friends for buffers > 2GB.
6628 * syntax.h (struct gl_state_s): Declare character position members
6631 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6633 * textprop.c (verify_interval_modification, interval_of):
6634 Declare arguments EMACS_INT.
6636 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6639 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6641 * indent.c (Fvertical_motion): Local variable it_start is now
6644 * regex.c (re_match, re_match_2, re_match_2_internal)
6645 (bcmp_translate, regcomp, regexec, print_double_string)
6646 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6647 (re_compile_pattern, re_exec): Declare arguments and local
6648 variables `size_t' and `ssize_t' and return values `regoff_t', as
6650 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6651 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6652 <compile_stack_type>: `size' and `avail' are now `size_t'.
6654 * regex.h <regoff_t>: Use ssize_t, not int.
6655 (re_search, re_search_2, re_match, re_match_2): Arguments that
6656 specify buffer/string position and length are now ssize_t and
6657 size_t. Return type is regoff_t.
6659 2011-04-16 Ben Key <bkey76@gmail.com>
6661 * nsfont.m: Fixed bugs in ns_get_family and
6662 ns_descriptor_to_entity that were caused by using free to
6663 deallocate memory blocks that were allocated by xmalloc (via
6664 xstrdup). This caused Emacs to crash when compiled with
6665 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6666 --enable-checking=xmallocoverrun). xfree is now used to
6667 deallocate these memory blocks.
6669 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6671 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6673 emacs_write: Accept and return EMACS_INT for sizes.
6674 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6676 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6677 Accept and return EMACS_INT.
6678 (emacs_gnutls_write): Return the number of bytes written on
6680 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6681 (emacs_read, emacs_write): Remove check for negative size, as the
6682 Emacs source code has been audited now.
6683 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6684 (emacs_read, emacs_write): Use it.
6685 * process.c (send_process): Adjust to the new signatures of
6686 emacs_write and emacs_gnutls_write. Do not attempt to store
6687 a byte offset into an 'int'; it might overflow.
6688 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6690 * sound.c: Don't assume sizes fit in 'int'.
6691 (struct sound_device.period_size, alsa_period_size):
6692 Return EMACS_INT, not int.
6693 (struct sound_device.write, vox_write, alsa_write):
6694 Accept EMACS_INT, not int.
6695 (wav_play, au_play): Use EMACS_INT to store sizes and to
6696 record read return values.
6698 2011-04-15 Ben Key <bkey76@gmail.com>
6700 * keyboard.c (Qundefined): Don't declare static since it is used
6702 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6703 static since they are used in nsfont.m.
6705 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6707 * process.c (Qprocessp): Don't declare static.
6708 * lisp.h (Qprocessp): Declare again.
6710 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6712 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6714 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6716 Improve C-level modularity by making more things 'static'.
6718 Don't publish debugger-only interfaces to other modules.
6719 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6720 (verify_bytepos, count_markers): Move decls to the only modules
6722 * region-cache.h (pp_cache): Likewise.
6723 * window.h (check_all_windows): Likewise.
6724 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6726 * sysdep.c (croak): Now static, if
6727 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6728 * syssignal.h (croak): Declare only if not static.
6730 * alloc.c (refill_memory_reserve): Now static if
6731 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6732 * lisp.h (refill_memory_reserve): Declare only if not static.
6734 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6735 Define only if USE_LUCID.
6737 * xrdb.c (x_customization_string, x_rm_string): Now static.
6739 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6740 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6742 * xdisp.c (draw_row_with_mouse_face): Now static.
6743 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6745 * window.h (check_all_windows): Mark externally visible.
6747 * window.c (window_deletion_count): Now static.
6749 * undo.c: Make symbols static if they're not exported.
6750 (last_undo_buffer, last_boundary_position, pending_boundary):
6753 * textprop.c (interval_insert_behind_hooks): Now static.
6754 (interval_insert_in_front_hooks): Likewise.
6756 * term.c: Make symbols static if they're not exported.
6757 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6758 (max_frame_lines, tty_set_terminal_modes):
6759 (tty_reset_terminal_modes, tty_turn_off_highlight):
6760 (get_tty_terminal): Now static.
6761 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6762 * termhooks.h (term_mouse_moveto): Do not declare if
6764 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6765 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6767 * sysdep.c: Make symbols static if they're not exported.
6768 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6770 (sigprocmask_set, full_mask): Remove; unused.
6771 (wait_debugging): Mark as visible.
6772 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6773 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6775 * syntax.c (syntax_temp): Define only if !__GNUC__.
6777 * sound.c (current_sound_device, current_sound): Now static.
6779 * search.c (searchbufs, searchbuf_head): Now static.
6781 * scroll.c (scroll_cost): Remove; unused.
6782 * dispextern.h (scroll_cost): Remove decl.
6784 * region-cache.h (pp_cache): Mark as externally visible.
6786 * process.c: Make symbols static if they're not exported.
6787 (process_tick, update_tick, create_process, chan_process):
6788 (Vprocess_alist, proc_buffered_char, datagram_access):
6789 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6790 (deactivate_process): Mark defn as static, as well as decl.
6791 * lisp.h (create_process): Remove decl.
6792 * process.h (chan_process, Vprocess_alist): Remove decls.
6794 * print.c: Make symbols static if they're not exported.
6795 (print_depth, new_backquote_output, being_printed, print_buffer):
6796 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6797 (print_interval, print_number_index, initial_stderr_stream):
6799 * lisp.h (Fprinc): Remove decl.
6800 (debug_output_compilation_hack): Mark as externally visible.
6802 * sysdep.c (croak): Move decl from here to syssignal.h.
6803 * syssignal.h (croak): Put it here, so the API can be checked when
6804 'croak' is called from dissociate_if_controlling_tty.
6806 * minibuf.c: Make symbols static if they're not exported.
6807 (minibuf_save_list, choose_minibuf_frame): Now static.
6808 * lisp.h (choose_minibuf_frame): Remove decl.
6810 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6812 * lread.c: Make symbols static if they're not exported.
6813 (read_objects, initial_obarray, oblookup_last_bucket_number):
6815 (make_symbol): Remove; unused.
6816 * lisp.h (initial_obarray, make_symbol): Remove decls.
6818 * keyboard.c: Make symbols static if they're not exported.
6819 (single_kboard, recent_keys_index, total_keys, recent_keys):
6820 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6821 (this_single_command_key_start, echoing, last_auto_save):
6822 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6823 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6824 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6825 (Vlispy_mouse_stem, double_click_count):
6827 (force_auto_save_soon): Define only if SIGDANGER.
6828 (ignore_mouse_drag_p): Now static if
6829 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6830 (print_help): Remove; unused.
6831 (stop_character, last_timer_event): Mark as externally visible.
6832 * keyboard.h (ignore_mouse_drag_p): Declare only if
6833 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6834 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6835 * lisp.h (echoing): Remove decl.
6836 (force_auto_save_soon): Declare only if SIGDANGER.
6837 * xdisp.c (redisplay_window): Simplify code, to make it more
6838 obvious that ignore_mouse_drag_p is not accessed if !defined
6839 USE_GTK && !defined HAVE_NS.
6841 * intervals.c: Make symbols static if they're not exported.
6842 (merge_properties_sticky, merge_interval_right, delete_interval):
6844 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6846 * insdel.c: Make symbols static if they're not exported.
6847 However, leave prepare_to_modify_buffer alone. It's never
6848 called from outside this function, but that appears to be a bug.
6849 (combine_after_change_list, combine_after_change_buffer):
6850 (adjust_after_replace, signal_before_change): Now static.
6851 (adjust_after_replace_noundo): Remove; unused.
6852 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
6853 (signal_before_change): Remove decls.
6855 * indent.c (val_compute_motion, val_vmotion): Now static.
6857 * image.c: Make symbols static if they're not exported.
6858 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6860 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6861 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6863 * fringe.c (standard_bitmaps): Now static.
6864 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6866 * frame.c: Make symbols static if they're not exported.
6867 (x_report_frame_params, make_terminal_frame): Now static.
6868 (get_frame_param): Now static, unless HAVE_NS.
6869 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6870 (x_get_resource_string): Remove; not used.
6871 * frame.h (make_terminal_frame, x_report_frame_params):
6872 (x_get_resource_string); Remove decls.
6873 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6874 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6876 * font.c, fontset.c: Make symbols static if they're not exported.
6877 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6878 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6879 * font.c (font_close_object): Now static.
6880 * font.h (font_close_object): Remove.
6881 * fontset.c (FONTSET_OBJLIST): Remove.
6882 (free_realized_fontset) #if-0 the body, which does nothing.
6883 (face_suitable_for_char_p): #if-0, as it's never called.
6884 * fontset.h (face_suitable_for_char_p): Remove decl.
6885 * xfaces.c (face_at_string_position):
6886 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
6887 since 0 is always ASCII.
6889 * fns.c (weak_hash_tables): Now static.
6891 * fileio.c: Make symbols static if they're not exported.
6892 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6893 (Vwrite_region_annotation_buffers): Now static.
6895 * eval.c: Make symbols static if they're not exported.
6896 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6897 * lisp.h (backtrace_list): Remove decl.
6899 * emacs.c: Make symbols static if they're not exported.
6900 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6901 (fatal_error_code, fatal_error_signal_hook, standard_args):
6903 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6904 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6905 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6906 * lisp.h (fatal_error_signal_hook): Remove decl.
6907 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6909 * editfns.c: Move a (normally-unused) function to its only use.
6910 * editfns.c, lisp.h (get_operating_system_release): Remove.
6911 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6912 worth the hassle of breaking this out.
6914 * xterm.c: Make symbols static if they're not exported.
6915 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6916 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6917 (x_destroy_window, x_delete_display):
6919 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6920 (x_mouse_leave): Remove; unused.
6921 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6922 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6923 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6925 (x_mouse_leave): Declare only if WINDOWSNT.
6926 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6927 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6930 * ftxfont.c: Make symbols static if they're not exported.
6931 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6933 * font.h (ftxfont_driver): Likewise.
6935 * xfns.c: Make symbols static if they're not exported.
6936 (x_last_font_name, x_display_info_for_name):
6937 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6938 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6939 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6940 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6941 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6942 (last_show_tip_args): Now static.
6943 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6944 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6945 (x_screen_planes): Remove; unused.
6946 * dispextern.h (x_screen_planes): Remove decl.
6948 * dispnew.c: Make symbols static if they're not exported.
6949 * dispextern.h (redraw_garbaged_frames, scrolling):
6950 (increment_row_positions): Remove.
6951 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6952 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6954 (redraw_garbaged_frames): Remove; unused.
6956 * xfaces.c: Make symbols static if they're not exported.
6957 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6959 * xterm.h (defined_color): Remove decls.
6960 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6961 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6962 (menu_face_changed_default, defined_color, free_realized_face):
6963 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6964 (ascii_face_of_lisp_face): Remove; unused.
6966 * xdisp.c: Make symbols static if they're not exported.
6967 * dispextern.h (scratch_glyph_row, window_box_edges):
6968 (glyph_to_pixel_coords, set_cursor_from_row):
6969 (get_next_display_element, set_iterator_to_next):
6970 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6971 (show_mouse_face): Remove decls
6972 * frame.h (message_buf_print): Likewise.
6973 * lisp.h (pop_message, set_message, check_point_in_composition):
6975 * xterm.h (set_vertical_scroll_bar): Likewise.
6976 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6977 (message_buf_print, scratch_glyph_row, displayed_buffer):
6978 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6979 (get_next_display_element, show_mouse_face, window_box_edges):
6980 (frame_to_window_pixel_xy, check_point_in_composition):
6981 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6982 (glyph_to_pixel_coords): Remove; unused.
6984 * dired.c (file_name_completion): Now static.
6986 * dbusbind.c (xd_in_read_queued_messages): Now static.
6988 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6989 * data.c (circular_list_error): Remove.
6991 * commands.h (last_point_position, last_point_position_buffer):
6992 (last_point_position_window): Remove decls.
6993 * keyboard.c: Make these variables static.
6995 * coding.h (coding, code_convert_region, encode_coding_gap):
6997 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6998 (iso_code_class, detect_coding, code_convert_region): Now static.
6999 (encode_coding_gap): Remove; unused.
7001 * chartab.c (chartab_chars, chartab_bits): Now static.
7003 * charset.h (charset_iso_8859_1): Remove decl.
7004 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7007 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7008 * ccl.c (Vccl_program_table): Now static.
7009 (check_ccl_update): Remove; unused.
7011 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7012 * category.h: ... from here.
7013 * category.c (check_category_table, set_category_set): Now static.
7015 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7016 * lisp.h: Remove these decls.
7018 * buffer.c (buffer_count): Remove unused var.
7020 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7021 so that it's not optimized away.
7022 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7023 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7024 exported only to the debugger.
7026 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7027 * atimer.h (run_all_atimers): Remove; not exported.
7029 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7030 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7031 was inaccessible from Lisp.
7032 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7033 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7035 alloc.c: Import and export fewer symbols, and remove unused items.
7036 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7038 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7039 it's not optimized away by whole-program optimization.
7040 (message_enable_multibyte, free_misc): Remove.
7041 (catchlist, handlerlist, mark_backtrace):
7042 Declare only if BYTE_MARK_STACK.
7043 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7044 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7045 (message_enable_multibyte): Remove decl.
7046 (free_misc, interval_free_list, float_block, float_block_index):
7047 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7048 (cons_free_list, last_marked_index):
7050 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7051 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7052 (mark_backtrace): Define only if BYTE_MARK_STACK.
7053 * xdisp.c (message_enable_multibyte): Now static.
7055 Declare Lisp_Object Q* variables to be 'static' if not exported.
7056 This makes it easier for human readers (and static analyzers)
7057 to see whether these variables are used from other modules.
7058 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7059 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7060 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7061 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7062 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7063 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7064 * xmenu.c, xselect.c:
7065 Declare Q* vars static if they are not used in other modules.
7066 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7067 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7068 Remove decls of unexported vars.
7069 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7071 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7073 Make Emacs functions such as Fatom 'static' by default.
7074 This makes it easier for human readers (and static analyzers)
7075 to see whether these functions can be called from other modules.
7076 DEFUN now defines a static function. To make the function external
7077 so that it can be used in other C modules, use the new macro DEFUE.
7078 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7079 (Finit_image_library):
7080 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7081 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7082 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7083 Remove decls, since these functions are now static.
7084 (Funintern, Fget_internal_run_time): New decls, since these functions
7085 were already external.
7087 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7088 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7089 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7090 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7091 * keyboard.c, keymap.c, lread.c:
7092 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7093 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7094 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7095 Mark functions with DEFUE instead of DEFUN,
7096 if they are used in other modules.
7097 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7098 decls for now-static functions.
7099 * buffer.h (Fdelete_overlay): Remove decl.
7100 * callproc.c (Fgetenv_internal): Mark as internal.
7101 * composite.c (Fremove_list_of_text_properties): Remove decl.
7102 (Fcomposition_get_gstring): New forward static decl.
7103 * composite.h (Fcomposite_get_gstring): Remove decl.
7104 * dired.c (Ffile_attributes): New forward static decl.
7105 * doc.c (Fdocumntation_property): New forward static decl.
7106 * eval.c (Ffetch_bytecode): New forward static decl.
7107 (Funintern): Remove extern decl; now in .h file where it belongs.
7108 * fileio.c (Fmake_symbolic_link): New forward static decl.
7109 * image.c (Finit_image_library): New forward static decl.
7110 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7111 * intervals.h (Fprevious_property_change):
7112 (Fremove_list_of_text_properties): Remove decls.
7113 * keyboard.c (Fthis_command_keys): Remove decl.
7114 (Fcommand_execute): New forward static decl.
7115 * keymap.c (Flookup_key): New forward static decl.
7116 (Fcopy_keymap): Now static.
7117 * keymap.h (Flookup_key): Remove decl.
7118 * process.c (Fget_process): New forward static decl.
7119 (Fprocess_datagram_address): Mark as internal.
7120 * syntax.c (Fsyntax_table_p): New forward static decl.
7121 (skip_chars): Remove duplicate decl.
7122 * textprop.c (Fprevious_property_change): New forward static decl.
7123 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7125 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7126 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7128 * editfns.c (Fformat): Remove unreachable code.
7130 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7132 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7135 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7137 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7138 when at ZV. (Bug#8487)
7140 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7142 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7144 * keyboard.c (parse_tool_bar_item): Likewise.
7145 * sound.c (sound_cleanup, alsa_close): Likewise.
7146 * termcap.c (tgetent): Likewise.
7147 * xfns.c (x_default_font_parameter): Likewise.
7148 * xsettings.c (read_and_apply_settings): Likewise.
7150 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7151 (overrun_check_free): Protoize.
7153 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7155 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7156 since callers should never pass a negative size.
7157 Change the signature to match that of plain 'read' and 'write'; see
7158 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7159 * lisp.h: Update prototypes of emacs_write and emacs_read.
7161 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7163 * xdisp.c (redisplay_window): Don't try to determine the character
7164 position of the scroll margin if the window start point w->startp
7165 is outside the buffer's accessible region. (Bug#8468)
7167 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7169 Fix write-region and its subroutines for buffers > 2GB.
7170 * fileio.c (a_write, e_write): Modify declaration of arguments and
7171 local variables to support buffers larger than 2GB.
7172 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7174 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7175 argument, local variables, and return value.
7177 * lisp.h: Update prototypes of emacs_write and emacs_read.
7179 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7181 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7183 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7185 Fix more problems found by GCC 4.6.0's static checks.
7187 * xdisp.c (vmessage): Use a better test for character truncation.
7189 * charset.c (load_charset_map): <, not <=, for optimization,
7190 and to avoid potential problems with integer overflow.
7191 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7192 * casetab.c (set_identity, shuffle): Likewise.
7193 * editfns.c (Fformat): Likewise.
7194 * syntax.c (skip_chars): Likewise.
7196 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7197 This also lets GCC 4.6.0 generate slightly better loop code.
7199 * callint.c (Fcall_interactively): <, not <=, for optimization.
7200 (Fcall_interactively): Count the number of arguments produced,
7201 not the number of arguments given. This is simpler and lets GCC
7202 4.6.0 generate slightly better code.
7204 * ftfont.c: Distingish more carefully between FcChar8 and char.
7205 The previous code passed unsigned char * to a functions like
7206 strlen and xstrcasecmp that expect char *, which does not
7207 conform to the C standard.
7208 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7209 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7210 char * when the C standard requires it.
7212 * keyboard.c (read_char): Remove unused var.
7214 * eval.c: Port to Windows vsnprintf (Bug#8435).
7216 (SIZE_MAX): Define if the headers do not.
7217 (verror): Do not give up if vsnprintf returns a negative count.
7218 Instead, grow the buffer. This ports to Windows vsnprintf, which
7219 does not conform to C99. Problem reported by Eli Zaretskii.
7220 Also, simplify the allocation scheme, by avoiding the need for
7221 calling realloc, and removing the ALLOCATED variable.
7223 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7225 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7226 But keep the doprint source code for now, as we might revamp it
7227 and use it again (Bug#8435).
7228 * lisp.h (doprnt): Remove.
7229 * Makefile.in (base_obj): Remove doprnt.o.
7230 * deps.mk (doprnt.o): Remove.
7232 error: Print 32- and 64-bit integers portably (Bug#8435).
7233 Without this change, on typical 64-bit hosts error ("...%d...", N)
7234 was used to print both 32- and 64-bit integers N, which relied on
7236 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7238 * lisp.h (error, verror): Mark as printf-like functions.
7239 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7240 Report overflow in size calculations when allocating printf buffer.
7241 Do not truncate output string at its first null byte.
7242 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7243 Truncate the output at a character boundary, since vsnprintf does not
7245 * charset.c (check_iso_charset_parameter): Convert internal
7246 character to string before calling 'error', since %c now has the
7248 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7249 overflow when computing char to be passed to 'error'. Do not
7250 pass Lisp_Object to 'error'; pass the integer instead.
7251 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7252 formatted with plain %d.
7254 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7256 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7258 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7260 * xterm.c (x_catch_errors): Remove duplicate declaration.
7262 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7264 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7266 2011-04-10 Jim Meyering <meyering@redhat.com>
7268 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7269 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7270 return ssize_t not "int", and use size_t as the buffer length.
7271 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7272 * gnutls.h: Update declarations.
7273 * process.c (read_process_output): Use ssize_t, to match.
7274 (send_process): Likewise.
7276 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7278 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7280 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7282 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7283 Use unsigned char, to match FcChar8 type definition.
7285 * xterm.c (handle_one_xevent):
7286 * xmenu.c (create_and_show_popup_menu):
7287 * xselect.c (x_decline_selection_request)
7288 (x_reply_selection_request): Avoid type-punned deref of X events.
7290 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7292 Fix some uses of `int' instead of EMACS_INT.
7293 * search.c (string_match_1, fast_string_match)
7294 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7295 (scan_buffer, find_next_newline_no_quit)
7296 (find_before_next_newline, search_command, Freplace_match)
7297 (Fmatch_data): Make some `int' variables be EMACS_INT.
7299 * xdisp.c (display_count_lines): 3rd argument and return value now
7300 EMACS_INT. All callers changed.
7301 (pint2hrstr): Last argument is now EMACS_INT.
7303 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7304 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7305 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7306 (decode_coding_utf_16, decode_coding_emacs_mule)
7307 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7308 (decode_coding_ccl, decode_coding_charset)
7309 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7310 (decode_coding_iso_2022, decode_coding_emacs_mule)
7311 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7312 <char_offset, last_offset>: Declare EMACS_INT.
7313 (encode_coding_utf_8, encode_coding_utf_16)
7314 (encode_coding_emacs_mule, encode_invocation_designation)
7315 (encode_designation_at_bol, encode_coding_iso_2022)
7316 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7317 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7319 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7320 (encode_invocation_designation): Last argument P_NCHARS is now
7322 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7323 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7325 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7328 * ccl.c (Fccl_execute_on_string): Declare some variables
7331 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7333 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7335 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7337 * process.c (Fformat_network_address): Doc fix.
7339 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7341 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7343 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7345 * keyboard.c (read_char): Call Lisp function help-form-show,
7346 instead of using internal_with_output_to_temp_buffer.
7347 (Qhelp_form_show): New var.
7348 (syms_of_keyboard): Use DEFSYM macro.
7350 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7352 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7354 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7356 * process.c (Flist_processes): Remove to Lisp.
7357 (list_processes_1): Delete.
7359 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7361 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7363 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7365 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7367 Fix more problems found by GCC 4.6.0's static checks.
7369 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7371 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7373 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7375 * xdisp.c (vmessage): Mark as a printf-like function.
7377 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7379 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7381 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7382 printf-like functions.
7383 (tiff_load): Add casts to remove these marks before passing them
7384 to system-supplied API.
7386 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7388 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7389 This avoids several warnings with gcc -Wstrict-overflow.
7390 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7391 directly, rather than having caller test rule sign. This avoids
7392 some unnecessary tests.
7393 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7394 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7395 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7397 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7398 (xfont_open): Avoid unnecessary tests.
7400 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7402 * composite.h, composite.c (composition_gstring_put_cache):
7403 Use EMACS_INT, not int, for length.
7405 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7406 breaking out part of COMPOSITION_DECODE_RULE.
7407 (COMPOSITION_DECODE_RULE): Use it.
7408 * composite.c (get_composition_id): Remove unused local vars,
7409 by using the new macro.
7411 * textprop.c (set_text_properties_1): Change while to do-while,
7412 since the condition is always true at first.
7414 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7415 (interval_deletion_adjustment): Return unsigned value.
7418 * process.c (list_processes_1, create_pty, read_process_output):
7419 (exec_sentinel): Remove vars that were set but not used.
7420 (create_pty): Remove unnecessary "volatile"s.
7421 (Fnetwork_interface_info): Avoid possibility of int overflow.
7422 (read_process_output): Do adaptive read buffering even if carryover.
7423 (read_process_output): Simplify nbytes computation if buffered.
7425 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7427 * syntax.c (scan_words): Remove var that was set but not used.
7428 (update_syntax_table): Use unsigned instead of int.
7430 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7431 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7432 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7434 * print.c (print_error_message): Avoid int overflow.
7436 * font.c (font_list_entities): Redo for clarity,
7437 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7439 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7440 (font_score): Avoid potential overflow in diff calculation.
7442 * fns.c (substring_both): Remove var that is set but not used.
7443 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7445 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7447 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7448 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7449 can always succeed if overflow has undefined behavior.
7451 * search.c (boyer_moore, wordify): Remove vars set but not used.
7452 (wordify): Omit three unnecessary tests.
7454 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7455 All callers changed. This avoids the need for an unused var.
7457 * casefiddle.c (casify_region): Remove var that is set but not used.
7459 * dired.c (file_name_completion): Remove var that is set but not used.
7461 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7463 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7464 (Finsert_file_contents): Remove unnecessary code checking fd.
7466 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7467 Check for integer overflow on size calculations.
7469 * buffer.c (Fprevious_overlay_change): Remove var that is set
7472 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7473 Remove vars that are set but not used.
7474 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7475 (timer_check_2): Mark vars as initialized.
7477 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7479 * image.c (lookup_image): Remove var that is set but not used.
7480 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7482 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7483 that are set but not used.
7485 * xfns.c (make_invisible_cursor): Don't return garbage
7486 if XCreateBitmapFromData fails (Bug#8410).
7488 * xselect.c (x_get_local_selection, x_handle_property_notify):
7489 Remove vars that are set but not used.
7491 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7492 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7494 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7495 Remove var that is set but not used.
7496 (scroll_bar_windows_size): Now size_t, not int.
7497 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7500 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7501 (map_tty_color) [!defined MSDOS]: Likewise.
7503 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7505 * coding.c: Remove vars that are set but not used.
7506 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7507 All callers changed.
7508 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7509 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7510 (decode_coding_charset): Remove vars that are set but not used.
7512 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7513 that is set but not used.
7515 * print.c (print_object): Remove var that is set but not used.
7517 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7518 The gnulib version avoids calling malloc in the usual case,
7519 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7520 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7521 * filelock.c (current_lock_owner): Likewise.
7522 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7523 * sysdep.c: Include allocator.h, careadlinkat.h.
7524 (emacs_no_realloc_allocator): New static constant.
7525 (emacs_readlink): New function.
7526 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7527 ../lib/careadlinkat.h.
7529 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7531 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7532 first non-nil return value).
7534 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7536 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7537 if not defined (Bug#8403).
7539 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7541 * xdisp.c (display_count_lines): Remove parameter `start',
7542 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7543 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7544 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7545 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7546 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7547 and thereabouts. All callers changed.
7548 (get_per_char_metric): Remove parameter `f', unused since
7549 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7551 2011-04-02 Jim Meyering <meyering@redhat.com>
7553 do not dereference NULL upon failed strdup
7554 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7555 (ns_get_family): Likewise.
7557 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7559 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7561 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7563 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7566 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7568 Add lexical binding.
7570 * window.c (Ftemp_output_buffer_show): New fun.
7571 (Fsave_window_excursion):
7572 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7574 * lread.c (lisp_file_lexically_bound_p): New function.
7575 (Fload): Bind Qlexical_binding.
7576 (readevalloop): Remove `evalfun' arg.
7577 Bind Qinternal_interpreter_environment.
7578 (Feval_buffer): Bind Qlexical_binding.
7579 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7581 (syms_of_lread): Declare `lexical-binding'.
7583 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7585 * keyboard.c (eval_dyn): New fun.
7586 (menu_item_eval_property): Use it.
7588 * image.c (parse_image_spec): Use Ffunctionp.
7590 * fns.c (concat, mapcar1): Accept byte-code-functions.
7592 * eval.c (Fsetq): Handle lexical vars.
7593 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7594 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7595 (FletX, Flet): Obey lexical binding.
7596 (Fcommandp): Handle closures.
7597 (Feval): New `lexical' arg.
7598 (eval_sub): New function extracted from Feval. Use it almost
7599 everywhere where Feval was used. Look up vars in lexical env.
7601 (Ffunctionp): Move from subr.el.
7602 (Ffuncall): Handle closures.
7603 (apply_lambda): Remove `eval_flags'.
7604 (funcall_lambda): Handle closures and new byte-code-functions.
7605 (Fspecial_variable_p): New function.
7606 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7607 but without exporting it to Lisp.
7609 * doc.c (Fdocumentation, store_function_docstring):
7610 * data.c (Finteractive_form): Handle closures.
7612 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7615 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7617 (exec_byte_code): New function extracted from Fbyte_code to handle new
7618 calling convention for byte-code-functions. Add new byte-codes.
7620 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7622 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7624 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7626 * xdisp.c (redisplay_internal): Fix prototype.
7628 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7630 * xdisp.c (SCROLL_LIMIT): New macro.
7631 (try_scrolling): Use it when setting scroll_limit.
7632 Limit scrolling to 100 screen lines.
7633 (redisplay_window): Even when falling back on "recentering",
7634 position point in the window according to scroll-conservatively,
7635 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7637 (try_scrolling): When point is above the window, allow searching
7638 as far as scroll_max, or one screenful, to compute vertical
7639 distance from PT to the scroll margin position. This prevents
7640 try_scrolling from unnecessarily failing when
7641 scroll-conservatively is set to a value slightly larger than the
7642 window height. Clean up the case of PT below the margin at bottom
7643 of window: scroll_max can no longer be INT_MAX. When aggressive
7644 scrolling is in use, don't let point enter the opposite scroll
7645 margin as result of the scroll.
7646 (syms_of_xdisp) <scroll-conservatively>: Document the
7647 threshold of 100 lines for never-recentering scrolling.
7649 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7651 * dispextern.h (move_it_by_lines):
7652 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7653 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7654 (message_log_check_duplicate): Remove parameters `prev_bol' and
7655 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7656 (redisplay_internal): Remove parameter `preserve_echo_area',
7657 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7659 * indent.c (Fvertical_motion):
7660 * window.c (window_scroll_pixel_based, Frecenter):
7661 Don't pass `need_y_p' to `move_it_by_lines'.
7663 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7665 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7666 steal a few bits to be more compact.
7667 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7668 Remove unneeded casts.
7670 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7672 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7674 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7675 binding" message (bug#7967).
7677 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7679 Fix more problems found by GCC 4.6.0's static checks.
7681 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7682 Remove unused local var.
7684 * editfns.c (Fmessage_box): Remove unused local var.
7686 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7687 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7688 Omit unused local vars.
7689 * window.c (shrink_windows): Omit unused local var.
7690 * menu.c (digest_single_submenu): Omit unused local var.
7691 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7692 Omit unused local var.
7694 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7695 Don't assume string length fits in int.
7696 (keyremap_step, read_key_sequence): Use size_t for sizes.
7697 (read_key_sequence): Don't check last_real_key_start redundantly.
7699 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7700 instead of alloca (Bug#8344).
7702 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7703 (Fbacktrace_frame): Don't assume nframes fits in int.
7705 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7707 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7710 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7712 * cm.c (calccost): Turn while-do into do-while, for clarity.
7714 * keyboard.c (syms_of_keyboard): Use the same style as later
7715 in this function when indexing through an array. This also
7716 works around GCC bug 48267.
7718 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7720 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7722 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7723 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7725 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7726 This avoids undefined behavior on integer overflow, and is a bit
7727 more convenient anyway since it is compared to a size_t variable.
7729 Variadic C functions now count arguments with size_t, not int.
7730 This avoids an unnecessary limitation on 64-bit machines, which
7731 caused (substring ...) to crash on large vectors (Bug#8344).
7732 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7733 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7734 All variadic functions and their callers changed accordingly.
7735 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7736 * data.c (arith_driver, float_arith_driver): Likewise.
7737 * editfns.c (general_insert_function): Likewise.
7738 * eval.c (struct backtrace.nargs, interactive_p)
7739 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7740 (funcall_lambda, mark_backtrace): Likewise.
7741 * fns.c (concat): Likewise.
7742 * frame.c (x_set_frame_parameters): Likewise.
7743 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7744 0 if not found, not -1. All callers changed.
7746 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7747 (stack_copy_size): Now size_t, not int.
7748 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7750 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7752 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7753 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7754 All callers changed.
7756 * lisp.h (multibyte_char_to_unibyte):
7757 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7758 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7759 * character.h (CHAR_TO_BYTE8):
7760 * cmds.c (internal_self_insert):
7761 * editfns.c (general_insert_function):
7762 * keymap.c (push_key_description):
7763 * search.c (Freplace_match):
7764 * xdisp.c (message_dolog, set_message_1): All callers changed.
7766 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7768 * keyboard.c (safe_run_hook_funcall): New function.
7769 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7770 don't set the hook to nil, but remove the offending function instead.
7771 (Qcommand_hook_internal): Remove, unused.
7772 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7773 Vcommand_hook_internal.
7775 * eval.c (enum run_hooks_condition): Remove.
7776 (funcall_nil, funcall_not): New functions.
7777 (run_hook_with_args): Call each function through a `funcall' argument.
7778 Remove `cond' argument, now redundant.
7779 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7780 (Frun_hook_with_args_until_failure): Adjust accordingly.
7781 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7783 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7785 * dispextern.h (string_buffer_position): Remove declaration.
7787 * print.c (strout): Remove parameter `multibyte', unused since
7788 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7790 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7791 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7792 All callers changed.
7794 * w32.c (_wsa_errlist): Use braces for struct initializers.
7796 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7797 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7798 All callers changed.
7799 (string_buffer_position): Likewise. Also, make static (it's never
7800 used outside xdisp.c).
7801 (cursor_row_p): Remove parameter `w', unused since
7802 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7803 (decode_mode_spec): Remove parameter `precision', introduced during
7804 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7805 All callers changed.
7807 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7809 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7811 2011-03-27 Anders Lindgren <andlind@gmail.com>
7813 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7814 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7815 (ns_update_auto_hide_menu_bar): New functions.
7816 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7817 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7818 ns_constrain_all_frames.
7819 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7820 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7822 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7824 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7826 2011-03-27 Glenn Morris <rgm@gnu.org>
7828 * syssignal.h: Replace RETSIGTYPE with void.
7829 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7830 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7831 Replace SIGTYPE with void everywhere.
7832 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7833 * s/template.h (SIGTYPE): Remove commented out definition.
7835 2011-03-26 Eli Zaretskii <eliz@gnu.org>
7837 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7838 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7840 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
7842 * w32.c (read_unc_volume): Use parameter `henum', instead of
7843 global variable `wget_enum_handle'.
7845 * keymap.c (describe_vector): Remove parameters `indices' and
7846 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7847 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7849 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7851 * keyboard.c (timer_check): Remove parameter `do_it_now',
7852 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7853 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7854 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7856 * keyboard.c (read_char):
7857 * w32menu.c (w32_menu_display_help):
7858 * xmenu.c (show_help_event, menu_help_callback):
7859 Adjust calls to `show_help_echo'.
7861 * gtkutil.c (xg_maybe_add_timer):
7862 * keyboard.c (readable_events):
7863 * process.c (wait_reading_process_output):
7864 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7866 * insdel.c (adjust_markers_gap_motion):
7867 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7868 (gap_left, gap_right): Don't call it.
7870 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
7872 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7873 incurred during fontification.
7875 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7877 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7878 (DEFVAR_PER_BUFFER): Don't pass it.
7880 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7881 (scrolling_window): Don't pass it.
7883 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7885 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7887 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7889 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7890 of variables specific to SELinux and computation of `encoded_absname'.
7892 * image.c (XPutPixel): Remove unused variable `height'.
7894 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7896 * unexw32.c (get_section_info): Remove unused variable `section'.
7898 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7899 (system_process_attributes): Remove unused variable `sess'.
7900 (sys_read): Remove unused variable `err'.
7902 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7903 (w32_wnd_proc): Remove unused variable `isdead'.
7904 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7905 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7906 (x_create_tip_frame): Remove unused variable `tem'.
7908 * w32inevt.c (w32_console_read_socket):
7909 Remove unused variable `no_events'.
7911 * w32term.c (x_draw_composite_glyph_string_foreground):
7912 Remove unused variable `width'.
7914 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
7916 * w32term.c (x_set_glyph_string_clipping):
7917 Don't pass uninitialized region to CombineRgn.
7919 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
7921 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7922 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7923 (Fx_close_connection): Remove unused variable `i'.
7925 * w32font.c (w32font_draw): Return number of glyphs.
7926 (w32font_open_internal): Remove unused variable `i'.
7927 (w32font_driver): Add missing initializer.
7929 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7930 (fill_in_menu): Remove unused variable `items_added'.
7932 * w32term.c (last_mouse_press_frame): Remove static global variable.
7933 (w32_clip_to_row): Remove unused variable `f'.
7934 (x_delete_terminal): Remove unused variable `i'.
7936 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7937 (NOTHING): Remove unused static global variable.
7938 (uniscribe_check_otf): Remove unused variable `table'.
7939 (uniscribe_font_driver): Add missing initializers.
7941 2011-03-23 Julien Danjou <julien@danjou.info>
7943 * term.c (Fsuspend_tty, Fresume_tty):
7944 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7945 * window.c (temp_output_buffer_show):
7946 * insdel.c (signal_before_change):
7947 * frame.c (Fhandle_switch_frame):
7948 * fileio.c (Fdo_auto_save):
7949 * emacs.c (Fkill_emacs):
7950 * editfns.c (save_excursion_restore):
7951 * cmds.c (internal_self_insert):
7952 * callint.c (Fcall_interactively):
7953 * buffer.c (Fkill_all_local_variables):
7954 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7956 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
7957 unconditionally since it does the check itself.
7959 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
7961 Fix more problems found by GCC 4.5.2's static checks.
7963 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7964 the first time through the loop, since we know p0 < p1 then.
7965 This also avoids a gcc -Wstrict-overflow warning.
7967 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7968 leading to a memory leak, possible in functions like
7969 load_charset_map_from_file that can allocate an unbounded number
7970 of objects (Bug#8318).
7972 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7973 that could (at least in theory) be that large.
7975 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7976 This is less likely to overflow, and avoids undefined behavior if
7977 overflow does occur. All callers changed. Use strtoul to scan
7978 for the unsigned long integer.
7979 (pint2hrstr): Simplify and tune code slightly.
7980 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
7982 * scroll.c (do_scrolling): Work around GCC bug 48228.
7983 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7985 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7986 This also avoids a warning with gcc -Wstrict-overflow.
7987 (validate_x_resource_name): Simplify count usage.
7988 This also avoids a warning with gcc -Wstrict-overflow.
7990 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7993 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
7995 * process.c (Fmake_network_process): Use socklen_t, not int,
7996 where POSIX says socklen_t is required in portable programs.
7997 This fixes a porting bug on hosts like 64-bit HP-UX, where
7998 socklen_t is wider than int (Bug#8277).
7999 (Fmake_network_process, server_accept_connection):
8000 (wait_reading_process_output, read_process_output):
8003 * process.c: Rename or move locals to avoid shadowing.
8004 (list_processes_1, Fmake_network_process):
8005 (read_process_output_error_handler, exec_sentinel_error_handler):
8006 Rename or move locals.
8007 (Fmake_network_process): Define label "retry_connect" only if needed.
8008 (Fnetwork_interface_info): Fix pointer signedness.
8009 (process_send_signal): Add cast to avoid pointer signedness problem.
8010 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8011 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8013 Make tparam.h and terminfo.c consistent.
8014 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8015 Include tparam.h instead, since it declares them.
8016 * cm.h (PC): Remove extern decl; tparam.h now does this.
8017 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8018 * terminfo.c: Include tparam.h, to check interfaces.
8019 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8020 (tparam): Adjust signature to match interface in tparam.h;
8021 this removes some undefined behavior. Check that outstring and len
8022 are zero, which they always are with Emacs.
8023 * tparam.h (PC, BC, UP): New extern decls.
8025 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8026 (xftfont_open): Rename locals to avoid shadowing.
8028 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8029 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8030 (OTF_TAG_SYM): Omit macro if not needed.
8031 (ftfont_list): Remove unused local.
8032 (get_adstyle_property, ftfont_pattern_entity):
8033 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8034 Rename locals to avoid shadowing.
8036 * xfont.c (xfont_list_family): Mark var as initialized.
8038 * xml.c (make_dom): Now static.
8040 * composite.c (composition_compute_stop_pos): Rename local to
8042 (composition_reseat_it): Remove unused locals.
8043 (find_automatic_composition, composition_adjust_point): Likewise.
8044 (composition_update_it): Mark var as initialized.
8045 (find_automatic_composition): Mark vars as initialized,
8046 with a FIXME (Bug#8290).
8048 character.h: Rename locals to avoid shadowing.
8049 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8050 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8051 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8052 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8055 * textprop.c (property_change_between_p): Remove; unused.
8057 * intervals.c (interval_start_pos): Now static.
8059 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8061 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8062 Rename locals to avoid shadowing.
8064 * sound.c (wav_play, au_play, Fplay_sound_internal):
8065 Fix pointer signedness.
8066 (alsa_choose_format): Remove unused local var.
8067 (wav_play): Initialize a variable to 0, to prevent undefined
8068 behavior (Bug#8278).
8070 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8072 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8074 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8075 clobbering (Bug#8298).
8076 * sysdep.c (sys_subshell): Likewise.
8077 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8079 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8080 This should get cleaned up, so that child_setup has the
8081 same signature on all platforms.
8083 * callproc.c (call_process_cleanup): Now static.
8084 (relocate_fd): Rename locals to avoid shadowing.
8086 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8088 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8089 not to be necessary, and produces flickering.
8091 2011-03-20 Glenn Morris <rgm@gnu.org>
8093 * config.in: Remove file.
8095 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8097 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8098 are now in src/globals.h.
8099 (syms_of_minibuf): Remove spurious & from previous change.
8101 2011-03-20 Leo <sdl.web@gmail.com>
8103 * minibuf.c (completing-read-function): New variable.
8104 (completing-read-default): Rename from completing-read.
8105 (completing-read): Call completing-read-function.
8107 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8109 * xfaces.c (Fx_load_color_file):
8110 Read color file from absolute filename (bug#8250).
8112 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8114 * makefile.w32-in: Update dependencies.
8116 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8118 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8120 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8122 Fix more problems found by GCC 4.5.2's static checks.
8124 * process.c (make_serial_process_unwind, send_process_trap):
8125 (sigchld_handler): Now static.
8127 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8128 That way, the code declares only the vars that it needs.
8129 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8130 * s/cygwin.h (PTY_ITERATION): Likewise.
8131 * s/darwin.h (PTY_ITERATION): Likewise.
8132 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8134 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8135 * process.c (allocate_pty): Don't declare stb unless it's needed.
8137 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8138 (CONSTANTLIM): Remove; unused.
8139 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8140 Define only if needed.
8142 * unexelf.c (unexec): Name an expression,
8143 to avoid gcc -Wbad-function-cast warning.
8144 Use a different way to cause a compilation error if anyone uses
8145 n rather than nn, a way that does not involve shadowing.
8146 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8148 * deps.mk (unexalpha.o): Remove; unused.
8150 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8151 * unexec.h: New file.
8152 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8153 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8155 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8156 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8157 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8158 Change as necessary to match prototype in unexec.h.
8160 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8162 (back_comment, skip_chars): Mark vars as initialized.
8164 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8165 Rename locals to avoid shadowing.
8167 * lread.c (read1): Rewrite so as not to use empty "else".
8168 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8170 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8172 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8173 warning when compiling print.c.
8175 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8176 instead of using an uninitialized var.
8177 (font_sort_entities): Mark var as initialized.
8179 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8181 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8182 pointers to constants.
8183 (font_parse_fcname): Remove unused vars.
8184 (font_delete_unmatched): Now static.
8185 (font_get_spec): Remove; unused.
8186 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8187 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8188 Rename or move locals to avoid shadowing.
8190 * fns.c (require_nesting_list, require_unwind): Now static.
8191 (Ffillarray): Rename locals to avoid shadowing.
8193 * floatfns.c (domain_error2): Define only if needed.
8194 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8196 * alloc.c (mark_backtrace): Move decl from here ...
8197 * lisp.h: ... to here, so that it can be checked.
8199 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8200 (Fdefvar): Rewrite so as not to use empty "else".
8201 (lisp_indirect_variable): Name an expression,
8202 to avoid gcc -Wbad-function-cast warning.
8203 (Fdefvar): Rename locals to avoid shadowing.
8205 * callint.c (quotify_arg, quotify_args): Now static.
8206 (Fcall_interactively): Rename locals to avoid shadowing.
8207 Use const pointer when appropriate.
8209 * lisp.h (get_system_name, get_operating_system_release):
8210 Move decls here, to check interfaces.
8211 * process.c (get_operating_system_release): Move decl to lisp.h.
8212 * xrdb.c (get_system_name): Likewise.
8213 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8214 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8215 some of which prompt warnings from gcc -Wbad-function-cast.
8216 (Fformat_time_string, Fencode_time, Finsert_char):
8217 (Ftranslate_region_internal, Fformat):
8218 Rename or remove local vars to avoid shadowing.
8219 (Ftranslate_region_internal): Mark var as initialized.
8221 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8224 * lisp.h (eassert): Check that the argument compiles, even if
8225 ENABLE_CHECKING is not defined.
8227 * data.c (Findirect_variable): Name an expression, to avoid
8228 gcc -Wbad-function-cast warning.
8229 (default_value, arithcompare, arith_driver, arith_error): Now static.
8230 (store_symval_forwarding): Rename local to avoid shadowing.
8231 (Fmake_variable_buffer_local, Fmake_local_variable):
8232 Mark variables as initialized.
8233 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8235 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8236 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8237 Rename locals to avoid shadowing.
8238 (mark_stack): Move local variables into the #ifdef region where
8240 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8241 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8243 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8244 (GC_STRING_CHARS): Remove; not used.
8245 (Fmemory_limit): Cast sbrk's returned value to char *.
8247 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8248 avoids undefined behavior in theory.
8250 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8252 Use functions, not macros, for up- and down-casing (Bug#8254).
8253 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8254 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8255 to use the following functions instead of these macros.
8256 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8257 EMACS_INT, since callers assume the returned value fits in int.
8258 (upcase1): Likewise, for UPCASE_TABLE.
8259 (uppercasep, lowercasep, upcase): New static inline functions.
8260 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8261 the race-condition problem in the old DOWNCASE.
8263 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8264 Rename locals to avoid shadowing.
8265 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8266 (regex_compile, re_search_2, re_match_2_internal):
8267 Remove unused local vars.
8268 (FREE_VAR): Rewrite so as not to use empty "else",
8269 which gcc can warn about.
8270 (regex_compile, re_match_2_internal): Mark locals as initialized.
8271 (RETALLOC_IF): Define only if needed.
8272 (WORDCHAR_P): Likewise. This one is never needed, but is used
8273 only in a comment talking about a compiler bug, so put inside
8274 the #if 0 of that comment.
8275 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8276 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8279 * search.c (boyer_moore): Rename locals to avoid shadowing.
8280 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8281 (PREV_CHAR_BOUNDARY): Likewise.
8283 * search.c (simple_search): Remove unused var.
8285 * dired.c (compile_pattern): Move decl from here ...
8286 * lisp.h: ... to here, so that it can be checked.
8287 (struct re_registers): New forward decl.
8289 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8291 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8293 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8294 Rename locals to avoid shadowing.
8295 (Fvertical_motion): Mark locals as initialized.
8297 * casefiddle.c (casify_object, casify_region): Now static.
8298 (casify_region): Mark local as initialized.
8300 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8302 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8303 New macros, so that the caller can use some names other than
8304 gcpro1, gcpro2, etc.
8305 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8307 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8308 argument, for consistency with GCPRO2_VAR, etc: it is now the
8309 prefix of the variable, not the variable itself. All uses
8311 * dired.c (directory_files_internal, file_name_completion):
8312 Rename locals to avoid shadowing.
8314 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8315 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8316 dired.c's scmp function, had undefined behavior.
8317 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8318 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8319 * buffer.h: ... to here, because these macros use current_buffer,
8320 and the new implementation with inline functions needs to have
8321 current_buffer in scope now, rather than later when the macros
8323 (downcase, upcase1): New static inline functions.
8324 (DOWNCASE, UPCASE1): Reimplement using these functions.
8325 This avoids undefined behavior in expressions like
8326 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8327 from race conditions in accessing the global variables
8328 case_temp1 and case_temp2.
8329 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8330 * lisp.h (case_temp1, case_temp2): Remove their decls.
8331 * character.h (ASCII_CHAR_P): Move from here ...
8332 * lisp.h: ... to here, so that the inline functions mentioned
8335 * dired.c (directory_files_internal_unwind): Now static.
8337 * fileio.c (file_name_as_directory, directory_file_name):
8338 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8340 (file_name_as_directory): Use const pointers when appropriate.
8341 (Fexpand_file_name): Likewise. In particular, newdir might
8342 point at constant storage, so make it a const pointer.
8343 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8344 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8346 (Fset_file_times, Finsert_file_contents, auto_save_error):
8347 Rename locals to avoid shadowing.
8349 * minibuf.c (choose_minibuf_frame_1): Now static.
8350 (Ftry_completion, Fall_completions): Rename or remove locals
8353 * marker.c (bytepos_to_charpos): Remove; unused.
8355 * lisp.h (verify_bytepos, count_markers): New decls,
8356 so that gcc does not warn that these functions aren't declared.
8358 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8359 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8360 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8361 (copy_text): Remove unused local var.
8363 * filelock.c (within_one_second): Now static.
8364 (lock_file_1): Rename local to avoid shadowing.
8366 * buffer.c (fix_overlays_before): Mark locals as initialized.
8367 (fix_start_end_in_overlays): Likewise. This function should be
8368 simplified by using pointers-to-pointers, but that's a different
8370 (switch_to_buffer_1): Now static.
8371 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8372 (report_overlay_modification): Rename locals to avoid shadowing.
8374 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8375 Fix pointer signedness issue.
8376 (sys_subshell): Mark local as volatile if checking for lint,
8377 to suppress a gcc -Wclobbered warning that does not seem to be right.
8378 (MAXPATHLEN): Define only if needed.
8380 * process.c (serial_open, serial_configure): Move decls from here ...
8381 * systty.h: ... to here, so that they can be checked.
8383 * fns.c (get_random, seed_random): Move extern decls from here ...
8384 * lisp.h: ... to here, so that they can be checked.
8386 * sysdep.c (reset_io): Now static.
8387 (wait_for_termination_signal): Remove; unused.
8389 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8390 (copy_keymap_item, append_key, push_text_char_description):
8392 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8393 (DENSE_TABLE_SIZE): Remove; unused.
8394 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8395 (describe_map_tree):
8396 Rename locals to avoid shadowing.
8398 * keyboard.c: Declare functions static if they are not used elsewhere.
8399 (echo_char, echo_dash, cmd_error, top_level_2):
8400 (poll_for_input, handle_async_input): Now static.
8401 (read_char, kbd_buffer_get_event, make_lispy_position):
8402 (make_lispy_event, make_lispy_movement, apply_modifiers):
8403 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8404 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8405 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8406 (read_key_sequence, read_char): Mark locals as initialized.
8407 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8409 * keyboard.h (make_ctrl_char): New decl.
8410 (mark_kboards): Move decl here ...
8411 * alloc.c (mark_kboards): ... from here.
8413 * lisp.h (force_auto_save_soon): New decl.
8415 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8416 (DEFINE_DUMMY_FUNCTION): New macro.
8417 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8419 (main): Add casts to avoid warnings
8420 if GCC considers string literals to be constants.
8422 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8424 * dbusbind.c: Pointer signedness fixes.
8425 (xd_signature, xd_append_arg, xd_initialize):
8426 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8427 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8428 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8429 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8431 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8432 if GCC considers string literals to be constants.
8433 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8435 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8437 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8438 (print_preprocess, print_object): New macro to fix last change.
8440 * print.c (print_preprocess): Don't forget font objects.
8442 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8444 * emacs.c (USAGE3): Doc fixes.
8446 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8448 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8451 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8453 * lisp.h (VWindow_system, Qfile_name_history):
8454 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8455 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8456 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8458 * w32select.c: Don't #include "keyboard.h".
8459 (run_protected): Add extern declaration for waiting_for_input.
8461 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8462 * w32console.c (detect_input_pending, read_input_pending)
8463 (encode_terminal_code):
8464 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8465 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8466 (w32_system_caret_y, Qfile_name_history):
8467 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8468 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8469 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8470 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8471 * w32proc.c (Qlocal, report_file_error):
8472 * w32term.c (Vwindow_system, updating_frame):
8473 * w32uniscribe.c (initialized, uniscribe_font_driver):
8474 Remove unneeded extern declarations.
8476 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8478 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8480 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8482 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8483 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8484 These macros can no longer be used for assignment.
8486 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8487 Assign struct members directly, instead of using BUF_BEGV etc.
8488 (record_buffer_markers, fetch_buffer_markers): New functions for
8489 recording and fetching special buffer markers.
8490 (set_buffer_internal_1, set_buffer_temp): Use them.
8492 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8494 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8496 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8497 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8499 * xdisp.c (hscroll_window_tree):
8500 (reconsider_clip_changes): Use PT instead of BUF_PT.
8502 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8504 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8505 $(EMACS_ROOT)/lib/intprops.h.
8507 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8509 Fix more problems found by GCC 4.5.2's static checks.
8511 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8512 to unsigned char * to avoid compiler diagnostic.
8513 (xg_free_frame_widgets): Make it clear that a local variable is
8514 needed only if USE_GTK_TOOLTIP.
8515 (gdk_window_get_screen): Make it clear that this macro is needed
8516 only if USE_GTK_TOOLTIP.
8517 (int_gtk_range_get_value): New function, which avoids a diagnostic
8518 from gcc -Wbad-function-cast.
8519 (xg_set_toolkit_scroll_bar_thumb): Use it.
8520 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8521 diagnostic from gcc -Wbad-function-cast.
8522 (get_utf8_string, xg_get_file_with_chooser):
8523 Rename locals to avoid shadowing.
8524 (create_dialog): Move locals to avoid shadowing.
8526 * xgselect.c (xg_select): Remove unused var.
8528 * image.c (four_corners_best): Mark locals as initialized.
8529 (gif_load): Initialize transparent_p to zero (Bug#8238).
8530 Mark another local as initialized.
8531 (my_png_error, my_error_exit): Mark with NO_RETURN.
8533 * image.c (clear_image_cache): Now static.
8534 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8535 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8536 (x_edge_detection): Remove unnecessary cast that
8537 gcc -Wbad-function-cast diagnoses.
8538 (gif_load): Fix pointer signedness.
8539 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8540 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8542 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8544 Improve quality of tests for time stamp overflow.
8545 For example, without this patch (encode-time 0 0 0 1 1
8546 1152921504606846976) returns the obviously-bogus value (-948597
8547 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8548 reports time overflow. See
8549 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8550 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8551 * editfns.c: Include limits.h and intprops.h.
8552 (TIME_T_MIN, TIME_T_MAX): New macros.
8553 (time_overflow): Move earlier, to before first use.
8554 (hi_time, lo_time): New functions, for an accurate test for
8556 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8557 (Fget_internal_run_time): Don't assume time_t fits in int.
8558 (make_time): Use list2 instead of Fcons twice.
8559 (Fdecode_time): More accurate test for out-of-range times.
8560 (check_tm_member): New function.
8561 (Fencode_time): Use it, to test for out-of-range times.
8562 (lisp_time_argument): Don't rely on undefined left-shift and
8563 right-shift behavior when checking for time stamp overflow.
8565 * editfns.c (time_overflow): New function, refactoring common code.
8566 (Fformat_time_string, Fdecode_time, Fencode_time):
8567 (Fcurrent_time_string): Use it.
8569 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8570 * dired.c (make_time): Move to ...
8571 * editfns.c (make_time): ... here.
8572 * systime.h: Note the move.
8574 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8576 * fringe.c (update_window_fringes): Remove unused variables.
8578 * unexmacosx.c (copy_data_segment): Also copy __got section.
8581 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8583 * termcap.c [MSDOS]: Include "msdos.h".
8584 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8585 Constify `char *' arguments and their references according to
8586 prototypes in tparam.h.
8588 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8590 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8591 Adapt all references accordingly.
8593 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8595 2011-03-11 Tom Tromey <tromey@redhat.com>
8597 * buffer.c (syms_of_buffer): Remove obsolete comment.
8599 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8601 * termhooks.h (encode_terminal_code): Declare prototype.
8603 * msdos.c (encode_terminal_code): Don't declare prototype.
8605 * term.c (encode_terminal_code): Now external again, used by
8606 w32console.c and msdos.c.
8608 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8609 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8611 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8613 Fix some minor problems found by GCC 4.5.2's static checks.
8615 * fringe.c (update_window_fringes): Mark locals as initialized
8617 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8619 * alloc.c (mark_fringe_data): Move decl from here ...
8620 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8621 to check its interface.
8622 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8624 * fontset.c (free_realized_fontset): Now static.
8625 (Fset_fontset_font): Rename local to avoid shadowing.
8626 (fontset_font): Mark local as initialized.
8627 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8629 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8631 * xselect.c (x_disown_buffer_selections): Remove; not used.
8632 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8633 (x_own_selection, Fx_disown_selection_internal): Rename locals
8635 (x_handle_dnd_message): Remove local to avoid shadowing.
8637 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8638 so that the caller can use some name other than gcpro1.
8639 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8640 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8641 (Fx_backspace_delete_keys_p):
8642 Use them to avoid shadowing, and rename vars to avoid shadowing.
8643 (x_decode_color, x_set_name, x_window): Now static.
8644 (Fx_create_frame): Add braces to silence GCC warning.
8645 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8646 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8647 Remove unused locals.
8648 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8649 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8650 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8653 * xterm.h (x_mouse_leave): New decl.
8655 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8656 Remove unused functions.
8657 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8658 (x_calc_absolute_position): Now static.
8659 (XTread_socket): Don't define label "out" unless it's used.
8660 Don't declare local "event" unless it's used.
8661 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8662 unless they are used.
8663 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8664 (x_fatal_error_signal): Remove; not used.
8665 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8666 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8667 (x_error_catcher, x_connection_closed, x_error_handler):
8668 (x_error_quitter, xembed_send_message, x_iconify_frame):
8669 (my_log_handler): Rename locals to avoid shadowing.
8670 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8671 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8673 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8674 Rename or move locals to avoid shadowing.
8675 (tty_defined_color, merge_face_heights): Now static.
8676 (free_realized_faces_for_fontset): Remove; not used.
8677 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8678 does not deduce is never used uninitialized.
8679 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8680 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8682 * terminal.c (store_terminal_param): Now static.
8684 * xmenu.c (menu_highlight_callback): Now static.
8685 (set_frame_menubar): Remove unused local.
8686 (xmenu_show): Rename parameter to avoid shadowing.
8687 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8688 since they might point to immutable storage.
8689 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8690 since it's unused otherwise.
8692 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8693 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8694 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8695 avoids a gcc -Wuninitialized diagnostic.
8696 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8697 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8698 does not deduce are never used uninitialized.
8700 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8702 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8703 * window.c (window_loop, size_window):
8704 (run_window_configuration_change_hook, enlarge_window): Likewise.
8706 * window.c (display_buffer): Now static.
8707 (size_window): Mark variables that gcc -Wuninitialized
8708 does not deduce are never used uninitialized.
8709 * window.h (check_all_windows): New decl, to forestall
8710 gcc -Wmissing-prototypes diagnostic.
8711 * dispextern.h (bidi_dump_cached_states): Likewise.
8713 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8715 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8717 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8718 and to avoid gcc -Wuninitialized warning.
8719 (load_charset_map): Mark variables that gcc -Wuninitialized
8720 does not deduce are never used uninitialized.
8721 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8723 * coding.c (coding_set_source, coding_set_destination):
8724 Use "else { /* comment */ }" rather than "else /* comment */;"
8725 for clarity, and to avoid gcc -Wempty-body warning.
8726 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8727 a block, when the outer 'i' will do.
8728 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8729 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8730 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8731 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8732 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8733 Rename locals to avoid shadowing.
8734 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8735 * coding.c (emacs_mule_char, encode_invocation_designation):
8736 Now static, since they're not used elsewhere.
8737 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8738 (decode_coding_object, encode_coding_object, detect_coding_system):
8739 (decode_coding_emacs_mule): Mark variables that gcc
8740 -Wuninitialized does not deduce are never used uninitialized.
8741 (detect_coding_iso_2022): Initialize a local variable that might
8742 be used uninitialized. Leave a FIXME because it's not clear that
8743 this initialization is needed. (Bug#8211)
8744 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8745 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8746 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8747 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8748 Remove unused macros.
8750 * category.c (hash_get_category_set): Remove unused local var.
8751 (copy_category_table): Now static, since it's not used elsewhere.
8752 * character.c (string_count_byte8): Likewise.
8754 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8755 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8757 * chartab.c (copy_sub_char_table): Now static, since it's not used
8759 (sub_char_table_ref_and_range, char_table_ref_and_range):
8760 Rename locals to avoid shadowing.
8761 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8763 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8764 (BIDI_BOB): Remove unused macro.
8766 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8767 deduce are never used uninitialized.
8768 * term.c (encode_terminal_code): Likewise.
8770 * term.c (encode_terminal_code): Now static. Remove unused local.
8772 * tparam.h: New file.
8773 * term.c, tparam.h: Include it.
8774 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8775 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8776 Move these decls to tparam.h, and make them agree with what
8777 is actually in tparam.c. The previous trick of using incompatible
8778 decls in different modules does not conform to the C standard.
8779 All callers of tparam changed to use tparam's actual API.
8780 * tparam.c (tparam1, tparam, tgoto):
8781 Use const pointers where appropriate.
8783 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8784 * cm.h (struct cm): Likewise.
8785 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8786 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8787 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8788 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8789 (turn_on_face, init_tty): Likewise.
8790 * termchar.h (struct tty_display_info): Likewise.
8792 * term.c (term_mouse_position): Rename local to avoid shadowing.
8794 * alloc.c (mark_ttys): Move decl from here ...
8795 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8797 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8799 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8801 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
8803 * search.c (compile_pattern_1): Remove argument regp, unused since
8804 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8805 (compile_pattern): Don't pass it.
8807 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8809 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8810 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8812 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8814 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8816 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8817 gdk_window_get_screen, gdk_window_get_geometry,
8818 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8819 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8820 (xg_get_pixbuf_from_pixmap): New function.
8821 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8822 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8823 Call xg_get_pixbuf_from_pixmap instead of
8824 gdk_pixbuf_get_from_drawable.
8825 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8826 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8827 (xg_check_special_colors): Use GtkStyleContext and its functions
8829 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8830 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8831 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
8832 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8833 Call gtk_widget_get_preferred_size.
8834 (xg_frame_resized): gdk_window_get_geometry only takes 5
8836 (xg_win_to_widget, xg_event_is_for_menubar):
8837 Call gdk_x11_window_lookup_for_display.
8838 (xg_set_widget_bg): New function.
8839 (delete_cb): New function.
8840 (xg_create_frame_widgets): Connect delete-event to delete_cb.
8841 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
8842 (xg_set_background_color): Call xg_set_widget_bg.
8843 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8844 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8845 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8846 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8848 (update_frame_tool_bar): Call gtk_widget_hide.
8849 (xg_initialize): Use GDK_KEY_g.
8851 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8853 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8855 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8856 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8857 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8859 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
8861 * w32xfns.c (select_palette): Check success of RealizePalette against
8862 GDI_ERROR, not zero.
8864 See ChangeLog.11 for earlier changes.
8870 Copyright (C) 2011 Free Software Foundation, Inc.
8872 This file is part of GNU Emacs.
8874 GNU Emacs is free software: you can redistribute it and/or modify
8875 it under the terms of the GNU General Public License as published by
8876 the Free Software Foundation, either version 3 of the License, or
8877 (at your option) any later version.
8879 GNU Emacs is distributed in the hope that it will be useful,
8880 but WITHOUT ANY WARRANTY; without even the implied warranty of
8881 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8882 GNU General Public License for more details.
8884 You should have received a copy of the GNU General Public License
8885 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.