1 2012-06-23 Eli Zaretskii <eliz@gnu.org>
3 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
4 last argument of make_unibyte_string.
6 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
7 language ID in the event parameters.
9 * w32term.c (w32_read_socket): Put the new keyboard codepage into
10 event.code, not the obscure "character set ID".
12 2012-06-23 Chong Yidong <cyd@gnu.org>
14 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
16 2012-06-23 Eli Zaretskii <eliz@gnu.org>
18 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
19 * w32.c (fdutimens): New function.
21 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
23 * s/ms-w32.h (pselect): Redirect to sys_select.
25 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
27 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
28 in the logic of incrementing and decrementing the value of
29 use_relocatable_buffers.
31 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
33 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
34 Privately reported by Herbert J. Skuhra.
35 [__FreeBSD__]: Remove "*/" typo after "#include".
36 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
37 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
38 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
39 Don't assume EMACS_TIME and struct timeval are the same type.
41 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
43 Support higher-resolution time stamps (Bug#9000).
44 The time stamps are only nanosecond-resolution at the C level,
45 since that's the best that any real-world system supports now.
46 But they are picosecond-resolution at the Lisp level, as that's
47 easy, and leaves room for future OS improvements.
49 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
52 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
53 Don't get current time unless it's needed.
55 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
56 now provides it if it's absent.
57 (start_atimer): Port to higher-res time stamps.
58 Check for time stamp overflow. Don't get current time more
61 * buffer.h (struct buffer): Buffer modtime now has high resolution.
62 Include systime.h, not time.h.
63 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
65 * dired.c: Include stat-time.h.
66 (Ffile-attributes): File times now have higher resolution.
68 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
69 (struct image): Timestamp now has higher resolution.
71 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
72 has at least microseconds now. All uses removed.
73 (update_frame, update_single_window, update_window, update_frame_1)
74 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
76 * editfns.c (time_overflow): Now extern.
77 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
78 (float-time, Fformat_time_string, Fcurrent_time_string)
79 (Fcurrent_time_zone): Accept and generate higher-resolution
81 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
82 (decode_time_components, lisp_seconds_argument): New functions.
83 (make_time): Now static.
84 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
85 Report an error if the time is invalid, rather than having the caller
88 * fileio.c: Include <stat-time.h>
89 (Fcopy_file): Copy higher-resolution time stamps.
90 Prefer to set the time stamp via a file descriptor if that works.
91 (Fset_file_times, Finsert_file_contents, Fwrite_region)
92 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
93 (Fvisited_file_modtime, Fset_visited_file_modtime):
94 Support higher-resolution time stamps.
96 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
98 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
100 * image.c (prepare_image_for_display, clear_image_cache)
101 (lookup_image): Port to higer-resolution time stamps.
103 * keyboard.c (start_polling, bind_polling_period):
104 Check for time stamp overflow.
105 (read_char, kbd_buffer_get_event, timer_start_idle)
106 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
107 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
108 Port to higher-resolution time stamps. Do not assume time_t is signed.
109 (decode_timer): New function. Timers are now vectors of length 9,
110 not 8, to accommodate the picosecond component.
111 (timer_check_2): Use it.
113 * nsterm.m (select_timeout, timeval_subtract): Remove.
114 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
115 as they're a bit more accurate and handle overflow better.
116 (ns_select): Change prototype to be compatible with pselect.
117 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
118 * nsterm.h (ns_select): Adjust prototype.
120 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
121 us-resolution time stamps.
122 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
124 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
126 * lisp.h (time_overflow): New decl.
127 (wait_reading_process_output): First arg is now intmax_t, not int,
128 to accommodate larger waits.
130 * process.h (struct Lisp_Process.read_output_delay):
131 Now counts nanoseconds, not microseconds.
132 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
134 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
135 (wait_reading_process_output):
136 Port to ns-resolution time stamps.
137 (Faccept_process_output, wait_reading_process_output):
138 Check for time stamp overflow. Do not assume time_t is signed.
139 (select_wrapper): Remove; we now use pselect.
140 (Fprocess_attributes): Now generates ns-resolution time stamps.
142 * sysdep.c: Include utimens.h. Don't include utime.h
143 or worry about struct utimbuf; gnulib does that for us now.
144 (gettimeofday): Remove; gnulib provides a substitute.
145 (make_timeval): New function.
146 (set_file_times): Now sets ns-resolution time stamps.
147 New arg FD; all uses changed.
148 (time_from_jiffies, ltime_from_jiffies, get_up_time)
149 (system_process_attributes):
150 Now returns ns-resolution time stamp. All uses changed.
151 Check for time stamp overflow.
153 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
154 provides a substitute now.
156 * systime.h: Include timespec.h rather than sys/time.h and time.h,
157 since it guarantees struct timespec.
158 (EMACS_TIME): Now struct timespec, so that we can support
159 ns-resolution time stamps.
160 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
161 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
162 (EMACS_USECS): Remove.
163 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
164 so multiply the arg by 1000 before storing it.
165 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
167 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
168 Port to ns-resolution time stamps.
169 (EMACS_TIME_NEG_P): Remove; replaced by....
170 (EMACS_TIME_SIGN): New macro.
171 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
172 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
173 (set_file_times, make_time, lisp_time_argument): Adjust signature.
174 (make_timeval, make_lisp_time, decode_time_components): New decls.
175 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
176 that it mishandled time_t overflow. You can't compare by subtracting!
177 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
178 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
180 * term.c: Include <sys/time.h>.
181 (timeval_to_Time): New function, for proper overflow wraparound.
182 (term_mouse_position, term_mouse_click): Use it.
184 * undo.c (record_first_change): Support higher-resolution time stamps
186 (Fprimitive_undo): Use them when restoring time stamps.
188 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
189 (w32_get_internal_run_time):
190 Port to higher-resolution Emacs time stamps.
191 (ltime): Now accepts single 64-bit integer, as that's more convenient
194 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
196 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
197 for compatibility with pselect. Support ns-resolution time stamps.
199 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
201 * xselect.c (wait_for_property_change, x_get_foreign_selection):
202 Check for time stamp overflow, and support ns-resolution time stamps.
204 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
205 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
206 (timeval_subtract): Remove; no longer needed.
207 (XTflash, XTring_bell, x_wait_for_event):
208 Port to ns-resolution time stamps. Don't assume time_t is signed.
210 2012-06-22 Chong Yidong <cyd@gnu.org>
212 * xdisp.c (x_consider_frame_title): Revert last change.
214 2012-06-22 Eli Zaretskii <eliz@gnu.org>
216 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
217 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
218 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
219 staticidx goes up to 1597 out of 1600 = 0x640.)
221 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
223 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
224 Otherwise, the umask might be mistakenly 0 while handling input signals.
226 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
228 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
230 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
232 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
233 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
234 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
235 access to `contents' member of Lisp_Vector objects with AREF and ASET
238 2012-06-19 Chong Yidong <cyd@gnu.org>
240 * frame.c (delete_frame): When selecting a frame on a different
241 text terminal, do not alter the terminal's top-frame.
243 * xdisp.c (format_mode_line_unwind_data): Record the target
244 frame's selected window and its terminal's top-frame.
245 (unwind_format_mode_line): Restore them.
246 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
248 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
249 since tty frames can be explicitly named.
250 (prepare_menu_bars): Likewise.
252 * term.c (Ftty_top_frame): New function.
254 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
256 Port byte-code-meter to modern targets.
257 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
258 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
259 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
260 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
261 (METER_1, METER_2): Simplify.
263 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
265 * data.c (Fdefalias): Return `symbol' (bug#11686).
267 2012-06-18 Martin Rudalics <rudalics@gmx.at>
269 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
270 gets killed during executing of this function (Bug#11665).
271 Try to always return Qt when the buffer has been actually killed.
272 (Vkill_buffer_query_functions): In doc-string say that functions
273 run by this hook should not change the current buffer.
275 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
277 Fix recently-introduced process.c problems found by static checking.
278 * process.c (write_queue_push, write_queue_pop, send_process):
279 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
280 (write_queue_pop): Fix pointer signedness problem.
281 (send_process): Remove unused local.
283 2012-06-17 Chong Yidong <cyd@gnu.org>
285 * xdisp.c (redisplay_internal): No need to redisplay terminal
286 frames that are not on top.
288 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
290 * process.c (make_process): Initialize write_queue.
291 (write_queue_push, write_queue_pop): New functions.
292 (send_process): Use them to maintain correct ordering of process
295 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
297 * lisp.h (eassert): Assume C89 or later.
298 This removes the need for CHECK.
299 (CHECK): Remove. Its comments about always evaluating its
300 argument were confusing, as 'eassert' typically does not evaluate
303 * coding.c (produce_chars): Use ptrdiff_t, not int.
305 * xterm.c (x_draw_underwave): Check for integer overflow.
306 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
308 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
310 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
311 referenced (Bug#11583).
313 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
315 Implement wave-style variant of underlining.
316 * dispextern.h (face_underline_type): New enum.
317 (face): Add field for underline type.
318 * nsterm.m (ns_draw_underwave): New function.
319 (ns_draw_text_decoration): Use it.
320 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
322 (x_draw_glyph_string): Use them.
323 * xfaces.c (Qline, Qwave): New Lisp objects.
324 (check_lface_attrs, merge_face_ref)
325 (Finternal_set_lisp_face_attribute, realize_x_face):
326 Handle wave-style underline face attributes.
327 * xterm.c (x_draw_underwave): New function.
328 (x_draw_glyph_string): Use it.
330 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
332 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
333 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
334 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
335 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
336 ($(BLD)/w32select.$(O)): Update dependencies.
338 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
340 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
341 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
342 * character.c (_fetch_multibyte_char_p): Remove.
343 * alloc.c: Include "character.h" before "buffer.h".
345 * buffer.c: Likewise.
346 * bytecode.c: Likewise.
347 * callint.c: Likewise.
348 * callproc.c: Likewise.
349 * casefiddle.c: Likewise.
350 * casetab.c: Likewise.
351 * category.c: Likewise.
353 * coding.c: Likewise.
354 * composite.c: Likewise.
356 * dispnew.c: Likewise.
358 * dosfns.c: Likewise.
359 * editfns.c: Likewise.
361 * fileio.c: Likewise.
362 * filelock.c: Likewise.
364 * fontset.c: Likewise.
365 * fringe.c: Likewise.
366 * indent.c: Likewise.
367 * insdel.c: Likewise.
368 * intervals.c: Likewise.
369 * keyboard.c: Likewise.
370 * keymap.c: Likewise.
372 * macros.c: Likewise.
373 * marker.c: Likewise.
374 * minibuf.c: Likewise.
376 * nsmenu.m: Likewise.
378 * process.c: Likewise.
380 * region-cache.c: Likewise.
381 * search.c: Likewise.
382 * syntax.c: Likewise.
384 * textprop.c: Likewise.
386 * unexsol.c: Likewise.
387 * w16select.c: Likewise.
388 * w32fns.c: Likewise.
389 * w32menu.c: Likewise.
390 * window.c: Likewise.
395 * xselect.c: Likewise.
397 2012-06-16 Eli Zaretskii <eliz@gnu.org>
399 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
400 If all the glyphs of the glyph row came from strings, and we have no
401 cursor positioning clues, put the cursor on the first glyph of the
403 (handle_face_prop): Use chunk-relative overlay string index when
404 indexing into it->string_overlays array. (Bug#11653)
405 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
406 the rightmost. (Bug#11720)
408 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
410 * category.h (CHAR_HAS_CATEGORY): Define as inline.
411 (CATEGORY_MEMBER): Enforce 1/0 value.
412 * category.c (_temp_category_set): Remove.
414 2012-06-16 Eli Zaretskii <eliz@gnu.org>
416 * window.c (Fdelete_other_windows_internal)
417 (Fdelete_window_internal): Don't access frame's mouse highlight
418 info of the initial frame. (Bug#11677)
420 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
422 * .gdbinit (xgetint): Fix recently-introduced paren typo.
423 Assume USE_2_TAGS_FOR_INTS.
424 (xreload): Adjust $tagmask width to match recent lisp.h change.
426 Simplify lisp.h in minor ways that should not affect code.
427 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
428 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
429 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
430 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
431 (INTTYPEBITS): New macro, for clarity.
432 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
433 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
434 Simplify now that USE_LSB_TAG is always defined.
435 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
436 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
438 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
440 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
442 2012-06-13 Glenn Morris <rgm@gnu.org>
444 * s/bsd-common.h (BSD4_3):
445 * s/usg5-4-common.h (USG5_4): No longer define; unused.
447 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
449 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
452 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
454 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
455 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
456 * alloc.c (widen_to_Lisp_Object): Remove.
457 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
458 * frame.c (delete_frame): Remove outdated comment.
459 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
461 (Fw32_unregister_hot_key): Likewise.
462 (Fw32_toggle_lock_key): Likewise.
463 * w32menu.c (add_menu_item): Likewise.
464 (w32_menu_display_help): Use XIL instead of checking
466 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
467 (init_heap): Likewise.
468 * w32term.c (w32_read_socket): Update comment.
470 2012-06-13 Glenn Morris <rgm@gnu.org>
472 * s/usg5-4-common.h, src/s/unixware.h:
473 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
475 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
477 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
479 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
480 * alloc.c (make_number) [!defined make_number]:
481 Remove, as lisp.h always defines this now.
482 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
483 (roundup_size): Verify that it is a power of 2.
484 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
485 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
486 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
487 -DUSE_LSB_TAG=0, to override the automatically-selected default.
488 USE_LSB_TAG now is always defined to be either 0 or 1.
490 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
491 code works fine either way, and efficiency is not a concern here,
492 as the union type is for debugging, not for production.
493 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
494 Use an inline function on all platforms when using the union type,
495 since this is simpler and 'static inline' can be used portably
497 (LISP_INITIALLY_ZERO): New macro.
498 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
499 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
501 2012-06-12 Glenn Morris <rgm@gnu.org>
503 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
505 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
507 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
508 Move BROKEN_SIGIO to configure.
510 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
511 Move NO_TERMIO to configure.
513 2012-06-12 Chong Yidong <cyd@gnu.org>
515 * image.c (imagemagick_load_image): Use MagickFlattenImage if
516 MagickMergeImageLayers is undefined. Use pixel pusher loop if
517 MagickExportImagePixels is undefined.
519 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
521 * image.c (imagemagick_load_image): Remove unused label.
523 2012-06-11 Glenn Morris <rgm@gnu.org>
525 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
526 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
527 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
528 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
530 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
532 * alloc.c (make_byte_code): New function.
533 (Fmake_byte_code): Use it. Don't purify here.
534 * lread.c (read1): Use it as well to avoid extra allocation.
536 2012-06-11 Chong Yidong <cyd@gnu.org>
538 * image.c (imagemagick_load_image): Implement transparency.
540 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
542 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
543 account for preceding backslashes. (Bug#11663)
545 2012-06-09 Chong Yidong <cyd@gnu.org>
547 * term.c: Support italics in capable terminals (Bug#9652).
548 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
549 (turn_on_face): Output using TS_enter_italic_mode if available.
550 Don't handle unused blinking and alt-charset cases.
551 (turn_off_face): Handle italic case; discard unused tty_blinking_p
552 and tty_alt_charset_p cases.
553 (tty_capable_p, init_tty): Support italics.
555 * termchar.h (struct tty_display_info): Add field for italics.
556 Remove unused blink field.
558 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
561 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
562 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
563 tty_alt_charset_p. Add tty_italic_p.
565 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
567 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
568 dbus_type_is_basic if available.
569 (xd_extract_signed, xd_extract_unsigned): Rename from
570 extract_signed and extract_unsigned, respectively. Adapt callers.
572 2012-06-09 Chong Yidong <cyd@gnu.org>
574 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
576 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
579 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
581 * xdisp.c (vmessage): Treat frame message as multibyte.
582 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
583 would generate the diagnostic "Making \302\247 buffer-local while
586 2012-06-08 Eli Zaretskii <eliz@gnu.org>
588 * dispnew.c (showing_window_margins_p): Undo last change, which
589 was done due to an inadvertent commit.
590 (adjust_frame_glyphs_for_frame_redisplay): Do call
591 showing_window_margins_p.
593 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
595 * eval.c (Fmake_var_non_special): New primitive.
596 (syms_of_eval): Defsubr it.
597 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
599 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
601 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
602 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
604 2012-06-08 Eli Zaretskii <eliz@gnu.org>
606 * alloc.c (allocate_vectorlike): Fix last change.
608 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
610 Block-based vector allocation of small vectors.
611 * lisp.h (struct vectorlike_header): New field `nbytes',
612 adjust comment accordingly.
613 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
614 to denote vector blocks. Adjust users (live_vector_p,
615 mark_maybe_pointer, valid_lisp_object_p) accordingly.
616 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
617 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
618 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
619 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
620 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
621 (roundup_size): New constant.
622 (struct vector_block): New data type.
623 (vector_blocks, vector_free_lists, zero_vector): New variables.
624 (all_vectors): Rename to `large_vectors'.
625 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
626 (sweep_vectors): New functions.
627 (allocate_vectorlike): Return `zero_vector' as the only vector of
628 0 items. Allocate new vector from block if vector size is less than
629 or equal to VBLOCK_BYTES_MAX.
630 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
631 (init_alloc_once): Add call to init_vectors.
633 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
635 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
637 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
639 * doprnt.c (doprnt): Truncate multibyte char correctly.
640 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
641 would mishandle a string argument "Xc" if X was a multibyte
642 character of length 2: it would truncate after X's first byte
643 rather than including all of X.
645 2012-06-06 Chong Yidong <cyd@gnu.org>
647 * buffer.c (word_wrap): Doc fix.
649 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
651 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
653 2012-06-03 Glenn Morris <rgm@gnu.org>
655 * xdisp.c (tool-bar-style): Doc fix.
657 2012-06-03 Ulrich Müller <ulm@gentoo.org>
659 * Makefile.in (PAXCTL): Define.
660 (temacs$(EXEEXT)): Disable memory randomization for the temacs
661 binary via PaX flags if the paxctl utility is available.
662 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
663 Restore PaX flags to their default. (Bug#11398)
665 2012-06-03 Chong Yidong <cyd@gnu.org>
667 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
670 2012-06-03 Chong Yidong <cyd@gnu.org>
672 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
673 (note_mode_line_or_margin_highlight): If there is no help echo,
674 use mode-line-default-help-echo. Handle the case where the mouse
675 position is past the end of the mode line string.
677 * buffer.c (buffer_local_value_1): New function, split from
678 Fbuffer_local_value; can return Qunbound.
679 (Fbuffer_local_value): Use it.
680 (Vmode_line_format): Docstring tweaks.
682 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
684 * sysdep.c (system_process_attributes): Improve comment.
686 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
688 * keyboard.c: Export real-this-command to Elisp.
689 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
690 and DEFVAR it. Update all users.
692 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
694 * minibuf.c (Fassoc_string): Remove duplicate declaration.
696 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
697 Convert pctcpu and pctmem to Lisp float properly.
698 Let the compiler fold better, as 100.0/0x8000 is exact.
700 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
702 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
705 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
707 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
709 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
711 For a 'struct window', replace some Lisp_Object fields to
712 bitfields where appropriate, remove unused fields.
713 * window.h (struct window): Remove unused 'last_mark_x' and
714 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
715 change it's type from Lisp_Object to bitfield.
716 Change type of 'force_start', 'optional_new_start',
717 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
718 fields from Lisp_Object to bitfield. Adjust users accordingly.
720 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
722 Pacify gcc -Wdouble-precision when using Xaw.
723 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
724 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
725 Use 'float' consistently, rather than 'float' in most places
726 and 'double' in a couple of places.
728 2012-05-31 Eli Zaretskii <eliz@gnu.org>
730 * xdisp.c (handle_stop): Detect whether we have overlay strings
731 loaded by testing it->current.overlay_string_index to be
732 non-negative, instead of checking whether n_overlay_strings is
733 positive. (Bug#11587)
735 2012-05-31 Chong Yidong <cyd@gnu.org>
737 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
739 * doc.c (Fsubstitute_command_keys): Doc fix.
741 2012-05-31 Eli Zaretskii <eliz@gnu.org>
743 * search.c (search_buffer): Remove calls to
744 r_alloc_inhibit_buffer_relocation, as it is now called by
745 maybe_unify_char, which was the cause of relocation of buffer text
748 2012-05-31 Eli Zaretskii <eliz@gnu.org>
750 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
751 for the duration of call to load_charset, to avoid problems with
752 callers of maybe_unify_char that access buffer text through C
755 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
756 decrement the inhibition flag, instead of just setting or
759 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
761 Remove obsolete '#define static' cruft.
762 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
763 This #undef was "temporary" in 2000; it is no longer needed
764 now that '#define static' has gone away.
765 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
766 (gray_bitmap_bits): Remove; no longer needed.
767 All uses replaced with definiens.
768 * xterm.c: Include "bitmaps/gray.xbm".
770 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
772 Clean up __executable_start, monstartup when --enable-profiling.
773 The following changes affect the code only when profiling.
774 * dispnew.c (__executable_start): Rename from safe_bcopy.
775 Define only on platforms that need it.
776 * emacs.c: Include <sys/gmon.h> when profiling.
777 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
778 (__executable_start): Remove decl, since lisp.h does it now.
779 (safe_bcopy): Remove decl; no longer has that name.
780 (main): Coalesce #if into single bit of code, for simplicity.
781 Cast pointers to uintptr_t, since standard libraries want integers
783 * lisp.h (__executable_start): New decl.
785 2012-05-31 Glenn Morris <rgm@gnu.org>
787 * image.c (Fimagemagick_types): Doc fix.
789 2012-05-30 Jim Meyering <meyering@redhat.com>
791 * callproc.c (Fcall_process_region): Include directory component
792 in mkstemp error message (Bug#11586).
794 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
796 * alloc.c, lisp.h (make_pure_vector): Now static.
798 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
800 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
802 (Fautoload): Do the hash-doc more carefully.
803 * data.c (Fdefalias): Purify definition, except for keymaps.
804 (Qdefun): Move from eval.c.
805 * lisp.h (Qdefun): Remove.
806 * lread.c (read1): Tiny simplification.
808 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
810 Do not create empty overlays with the evaporate property (Bug#9642).
811 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
812 Bug#9642, but explicitly check that the buffer the overlay would
813 be moved to is live and rearrange lines to make sure that errors
814 will not put the overlay in an inconsistent state.
815 (Fdelete_overlay): Cosmetics.
817 2012-05-28 Eli Zaretskii <eliz@gnu.org>
819 * w32term.c (my_bring_window_to_top): New function.
820 (x_raise_frame): Use handle returned by DeferWindowPos, which
821 could be different from the original one.
822 Call my_bring_window_to_top instead of my_set_foreground_window.
825 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
826 by calling BringWindowToTop.
828 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
829 (WM_EMACS_END): Increase by one.
831 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
833 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
834 This avoids undefined behavior that might cause the eassert
835 to not catch an out-of-range value.
837 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
839 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
842 2012-05-27 Eli Zaretskii <eliz@gnu.org>
844 * bidi.c (bidi_mirror_char): Fix last change.
846 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
848 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
849 when referring to sectname field in printf format.
851 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
853 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
854 Only r_alloc_inhibit_buffer_relocation needed to be added;
855 the others were already declared.
857 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
858 before checking whether it's out of range. Put the check inside
860 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
862 2012-05-27 Ken Brown <kbrown@cornell.edu>
864 * callproc.c (Fcall_process): Restore a line that was accidentally
865 commented out in the 2011-02-13 change (bug#11547).
867 2012-05-27 Eli Zaretskii <eliz@gnu.org>
869 * lisp.h [REL_ALLOC]: Add prototypes for external functions
872 * buffer.c [REL_ALLOC]: Remove prototypes of
873 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
874 they are now on lisp.h.
876 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
878 * search.c (search_buffer): Use it to inhibit relocation of buffer
879 text while re_search_2 is doing its job, because re_search_2 is
880 passed C pointers to buffer text. (Bug#11519)
882 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
885 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
886 state after an additional call to move_it_in_display_line_to, keep
887 the values of it->max_ascent and it->max_descent found for the
889 (pos_visible_p): Revert the comparison against bottom_y to what it
890 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
893 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
895 Fix coding-related core dumps with gcc -ftrapv.
896 The code was computing A - B, where A and B are pointers, and B is
897 random garbage. This can lead to core dumps on platforms that
898 have special pointer registers, and it also leads to core dumps on
899 x86-64 when compiled with gcc -ftrapv. The fix is to compute
900 A - B only when B is initialized properly.
901 * coding.c (coding_set_source, coding_set_destination): Return void.
902 (coding_change_source, coding_change_destinations): New functions,
903 with the old behaviors of coding_set_source and coding_set_destination.
904 All callers that need an offset changed to use these new functions.
906 2012-05-26 Glenn Morris <rgm@gnu.org>
908 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
910 2012-05-26 Eli Zaretskii <eliz@gnu.org>
912 Extend mouse support on W32 text-mode console.
913 * xdisp.c (draw_row_with_mouse_face):
914 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
916 * w32console.c: Include window.h.
917 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
919 (initialize_w32_display): Initialize mouse-highlight data.
921 * w32inevt.c: Include termchar.h and window.h.
922 (do_mouse_event): Support mouse-autoselect-window. When the mouse
923 moves, call note_mouse_highlight. If help_echo changed, call
924 gen_help_event to produce help-echo message in the echo area.
925 Call clear_mouse_face if mouse_face_hidden is set in the mouse
928 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
930 * lread.c (read1): Simplify slightly to avoid an overflow warning
931 with GCC 4.7.0 on x86-64.
933 2012-05-26 Eli Zaretskii <eliz@gnu.org>
935 * bidi.c (bidi_mirror_char): Revert last change: an int is
936 definitely wide enough here.
938 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
940 Fix integer width and related bugs (Bug#9874).
941 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
942 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
943 (string_bytes, check_sblock, allocate_string_data):
944 (compact_small_strings, Fmake_bool_vector, make_string)
945 (make_unibyte_string, make_multibyte_string)
946 (make_string_from_bytes, make_specified_string)
947 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
948 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
950 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
951 (allocate_pseudovector):
952 Use int, not EMACS_INT, where int is wide enough.
953 (inhibit_garbage_collection, Fgarbage_collect):
954 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
955 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
956 int might not be wide enough.
957 (bidi_cache_search, bidi_cache_find, bidi_init_it)
958 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
959 (bidi_at_paragraph_end, bidi_find_paragraph_start)
960 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
961 (bidi_level_of_next_char, bidi_move_to_visually_next):
962 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
963 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
964 (Fkill_buffer, Fset_buffer_major_mode)
965 (advance_to_char_boundary, Fbuffer_swap_text)
966 (Fset_buffer_multibyte, overlays_at, overlays_in)
967 (overlay_touches_p, struct sortvec, record_overlay_string)
968 (overlay_strings, recenter_overlay_lists)
969 (adjust_overlays_for_insert, adjust_overlays_for_delete)
970 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
971 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
972 (Foverlay_recenter, last_overlay_modification_hooks_used)
973 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
974 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
975 (validate_region): Omit unnecessary test for b <= e,
976 since that's guaranteed by the previous test.
977 (adjust_overlays_for_delete): Avoid pos + length overflow.
978 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
979 (report_overlay_modification):
980 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
981 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
982 Omit pointer cast, which isn't needed anyway, and doesn't work
983 after the EMACS_INT -> ptrdiff_t change.
984 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
985 * buffer.h: Adjust decls to match defn changes elsewhere.
986 (struct buffer_text, struct buffer):
987 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
988 Use EMACS_INT, not int, where int might not be wide enough.
989 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
990 not int, to avoid needless 32-bit limit on 64-bit hosts.
991 (exec_byte_code): Use tighter memory-full test, one that checks
992 for alloca overflow. Don't compute the address of the object just
993 before an array, as that's not portable. Use EMACS_INT, not
994 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
995 * callint.c (Fcall_interactively):
996 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
997 * callproc.c (call_process_kill, Fcall_process):
998 Don't assume pid_t fits into an Emacs fixnum.
999 (call_process_cleanup, Fcall_process, child_setup):
1000 Don't assume pid_t fits into int.
1001 (call_process_cleanup, Fcall_process, delete_temp_file)
1002 (Fcall_process_region):
1003 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1004 (Fcall_process): Simplify handling of volatile integers.
1005 Use int, not EMACS_INT, where int will do.
1006 * casefiddle.c (casify_object, casify_region, operate_on_word)
1007 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1008 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1009 (casify_object): Avoid integer overflow when overallocating buffer.
1010 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
1011 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
1012 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1013 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1014 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1015 integers are now checked earlier. All uses replaced with XINT.
1017 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1018 For CCL_MapSingle, check that content and value are in int range.
1019 (ccl_driver, Fregister_code_conversion_map):
1020 Check that Vcode_version_map_vector is a vector.
1021 (resolve_symbol_ccl_program): Check that vector header is in range.
1022 Always copy the vector, so that we can check its contents reliably
1023 now rather than having to recheck each instruction as it's being
1024 executed. Check that vector words fit in 'int'.
1025 (ccl_get_compiled_code, Fregister_ccl_program)
1026 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1027 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1028 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1029 contents are in range.
1030 (Fccl_execute_on_string): Check that status is in range.
1031 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1032 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1033 Accept and return EMACS_INT, not int, because callers can pass values
1035 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1036 (multibyte_chars_in_text, parse_str_as_multibyte)
1037 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1038 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1039 (string_escape_byte8, Fget_byte):
1040 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1041 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
1042 avoid mishandling large integers.
1043 * character.h: Adjust decls to match defn changes elsewhere.
1044 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1045 (Ffind_charset_region):
1046 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1047 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1048 (load_charset_map_from_vector, Fdefine_charset_internal):
1049 Don't assume fixnum fits in int.
1050 (load_charset_map_from_vector, Fmap_charset_chars):
1051 Remove now-unnecessary CHECK_NATNUMs.
1052 (Fdefine_charset_internal): Check ranges here, more carefully.
1053 Don't rely on undefined behavior with signed left shift overflow.
1054 Don't assume unsigned int fits into fixnum, or that fixnum fits
1055 into unsigned int. Don't require max_code to be a valid fixnum;
1056 that's not true for gb10830 4-byte on a 32-bit host. Allow
1057 invalid_code to be a cons, for the same reason. Require code_offset
1058 to be a character. Avoid int overflow if max_char is close
1060 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1061 this is intended anyway and avoids some undefined behavior.
1062 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1063 INDEX_TO_CODE_POINT, as that's what it expects.
1064 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
1065 * charset.h (DECODE_CHAR): Return int, not unsigned;
1066 this is what was intended anyway, and it avoids undefined behavior.
1067 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1068 integer-overflow issues.
1069 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1070 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1071 where the argument is EMACS_INT, and this behavior is not intended.
1072 * chartab.c (Fmake_char_table, Fset_char_table_range)
1073 (uniprop_get_decoder, uniprop_get_encoder):
1074 Don't assume fixnum fits in int.
1075 * cmds.c (move_point): New function, that does the gist of
1076 Fforward_char and Fbackward_char, but does so while checking
1077 for integer overflow more accurately.
1078 (Fforward_char, Fbackward_char): Use it.
1079 (Fforward_line, Fend_of_line, internal_self_insert)
1080 (internal_self_insert):
1081 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1082 Fix a FIXME, by checking for integer overflow when calculating
1083 target_clm and actual_clm.
1084 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
1085 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
1086 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1087 (coding_alloc_by_making_gap, alloc_destination)
1088 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1089 (encode_coding_utf_16, detect_coding_emacs_mule)
1090 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1091 (detect_coding_iso_2022, decode_coding_iso_2022)
1092 (encode_invocation_designation, encode_designation_at_bol)
1093 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1094 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1095 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1096 (encode_coding_ccl, encode_coding_raw_text)
1097 (detect_coding_charset, decode_coding_charset)
1098 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1099 (produce_composition, produce_charset, produce_annotation)
1100 (decode_coding, handle_composition_annotation)
1101 (handle_charset_annotation, consume_chars, decode_coding_gap)
1102 (decode_coding_object, encode_coding_object, detect_coding_system)
1103 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1104 (code_convert_region, code_convert_string)
1105 (Fdefine_coding_system_internal)
1106 (coding_set_source, coding_set_destination):
1107 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1108 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1109 (Fdefine_coding_system_internal):
1110 Don't assume fixnums fit in int.
1111 (decode_coding_gap, decode_coding_object, encode_coding_object)
1112 (Fread_coding_system, Fdetect_coding_region)
1113 (Funencodable_char_position, Fcheck_coding_systems_region)
1114 (get_translation, handle_composition_annotation, consume_chars):
1115 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1116 (consume_chars): Rewrite to not calculate an address outside buffer.
1117 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
1118 Don't access memory outside of the args array.
1119 (Fdefine_coding_system_internal): Check for charset-id overflow.
1120 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1121 result of ENCODE_CHAR.
1122 * coding.h: Adjust decls to match defn changes elsewhere.
1123 (struct coding_system):
1124 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1125 * composite.c (get_composition_id, find_composition)
1126 (run_composition_function, update_compositions)
1127 (compose_text, composition_gstring_put_cache)
1128 (composition_gstring_p, composition_gstring_width)
1129 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1130 (composition_compute_stop_pos, composition_reseat_it)
1131 (composition_update_it, struct position_record)
1132 (find_automatic_composition, composition_adjust_point)
1133 (Fcomposition_get_gstring, Ffind_composition_internal):
1134 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1135 (update_compositions):
1136 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1137 * composite.h: Adjust decls to match defn changes elsewhere.
1138 (struct composition):
1139 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1140 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1141 Do not attempt to compute the address of the object just before a
1142 buffer; this is not portable.
1144 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1145 (Faset): Use int, not EMACS_INT, where int is wide enough.
1146 (Fstring_to_number): Don't assume fixnums fit in int.
1147 (Frem): Don't assume arg is nonnegative.
1148 * dbusbind.c (xd_append_arg): Check for integers out of range.
1149 (Fdbus_call_method): Don't overflow the timeout int.
1150 (extract_signed, extract_unsigned): New functions.
1151 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1152 (xd_get_connection_references): Return ptrdiff_t, not int.
1154 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1155 (xd_read_message_1):
1156 Use int, not unsigned, where the dbus API uses int.
1157 (Fdbus_message_internal): Don't overflow mtype.
1158 (syms_of_dbusbind): Allocate right-sized buffer for integers.
1159 * dired.c (directory_files_internal, file_name_completion, scmp)
1160 (file_name_completion_stat):
1161 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1162 (file_name_completion): Don't overflow matchcount.
1163 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1164 * dispextern.h: Adjust decls to match defn changes elsewhere.
1165 (struct text_pos, struct glyph, struct bidi_saved_info)
1166 (struct bidi_string_data, struct bidi_it, struct composition_it)
1168 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1169 (struct display_pos, struct composition_it, struct it):
1170 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1171 * dispnew.c (increment_matrix_positions)
1172 (increment_row_positions, mode_line_string)
1173 (marginal_area_string):
1174 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1175 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
1176 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1177 (duration_to_sec_usec): New function, to check for overflow better.
1178 (Fsleep_for, sit_for): Use it.
1179 * doc.c (get_doc_string, store_function_docstring):
1180 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1181 (get_doc_string, Fsnarf_documentation):
1182 Use int, not EMACS_INT, where int is wide enough.
1184 Use SAFE_ALLOCA, not alloca.
1185 Check for overflow when converting EMACS_INT to off_t.
1186 * doprnt.c (doprnt):
1187 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1188 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1189 Don't assume uid_t fits into fixnum.
1190 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1191 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1192 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1193 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1194 (general_insert_function)
1195 (Finsert_char, make_buffer_string, make_buffer_string_both)
1196 (update_buffer_properties, Fbuffer_substring)
1197 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1198 (Fsubst_char_in_region, check_translation)
1199 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1200 (transpose_markers, Ftranspose_regions):
1201 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1202 (clip_to_bounds): Move to lisp.h as an inline function).
1203 (Fconstrain_to_field): Don't assume integers are nonnegative.
1204 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1205 (Fsubst_char_in_region, Fsave_restriction):
1206 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1207 (Femacs_pid): Don't assume pid_t fits into fixnum.
1208 (lo_time): Use int, not EMACS_INT, when int suffices.
1209 (lisp_time_argument): Check for usec out of range.
1210 (Fencode_time): Don't assume fixnum fits in int.
1211 (Fuser_login_name, Fuser_full_name): Signal an error
1212 if a uid argument is out of range, rather than relying on
1214 (Fformat_time_string): Remove now-unnecessary check.
1215 lisp_time_argument checks for out-of-range usec now.
1216 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
1217 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1218 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1219 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1220 (init_cmdargs, Fdump_emacs):
1221 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1222 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1223 the bottom (typically) 32 bits of the fixnum.
1224 * eval.c (specpdl_size, call_debugger):
1225 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1226 (when_entered_debugger, Fbacktrace_debug):
1227 Don't assume fixnum can fit in int.
1228 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1229 the object just before a buffer; this is not portable.
1230 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1231 (grow_specpdl, unbind_to):
1232 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1233 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1234 (grow_specpdl): Simplify allocation by using xpalloc.
1235 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
1236 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1237 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1238 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1239 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1241 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1242 (Fcopy_file, non_regular_nbytes, read_non_regular)
1243 (Finsert_file_contents):
1244 Use int, not EMACS_INT, where int is wide enough.
1245 (READ_BUF_SIZE): Verify that it fits in int.
1246 (Finsert_file_contents): Check that counts are in proper range,
1247 rather than assuming fixnums fit into ptrdiff_t etc.
1248 Don't assume fixnums fit into int.
1249 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
1250 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1251 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
1252 (string_char_to_byte, string_byte_to_char)
1253 (string_make_multibyte, string_to_multibyte)
1254 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1255 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1256 (substring_both, Fdelete, internal_equal, Ffillarray)
1257 (Fclear_string, mapcar1)
1258 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1259 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1260 (larger_vector, make_hash_table, maybe_resize_hash_table)
1261 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1262 (Fmaphash, secure_hash):
1263 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1264 (concat): Check for string index and length overflow.
1265 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1267 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1268 (larger_vector): New API (vec, incr_min, size_max) replaces old
1269 one (vec, new_size, init). This catches size overflow.
1270 INIT was removed because it was always Qnil.
1271 All callers changed.
1272 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1273 the upper bound on a hash table index size.
1274 (make_hash_table, maybe_resize_hash_table): Use it.
1275 (secure_hash): Computer start_byte and end_byte only after
1276 they're known to be in ptrdiff_t range.
1277 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1278 (Ffont_get_glyphs, Ffont_at):
1279 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1280 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1281 (Flist_fonts, Fopen_font):
1282 Don't assume fixnum can fit in int.
1283 (check_gstring): Don't assume index can fit in int.
1284 (font_match_p): Check that fixnum is a character, not a nonnegative
1285 fixnum, since the later code needs to stuff it into an int.
1286 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1287 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1288 conversion overflow issues.
1289 (Fopen_font): Check for integer out of range.
1290 (Ffont_get_glyphs): Don't assume index can fit in int.
1291 * font.h: Adjust decls to match defn changes elsewhere.
1292 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1294 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1295 printmax_t, where ptrdiff_t is wide enough.
1296 (Finternal_char_font):
1297 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1298 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1299 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1300 (Fset_frame_position, x_set_frame_parameters)
1301 (x_set_line_spacing, x_set_border_width)
1302 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1303 Check that fixnums are in proper range for system types.
1304 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1305 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1306 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1307 Use SAFE_ALLOCA_LISP, not alloca.
1308 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1309 intptr_t is wide enough.
1310 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1311 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1312 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1313 Check for fixnum out of range.
1314 * ftfont.c (ftfont_list): Don't assume index fits in int.
1315 Check that fixnums are in proper range for system types.
1316 (ftfont_shape_by_flt):
1317 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1318 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1319 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1320 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1321 Check that fixnums are in proper range for system types.
1322 * gnutls.h: Adjust decls to match defn changes elsewhere.
1323 * gtkutil.c (xg_dialog_run):
1324 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1325 (update_frame_tool_bar):
1326 Check that fixnums are in proper range for system types.
1327 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
1328 (lookup_image): Check that fixnums are in range for system types.
1329 * indent.c (last_known_column, last_known_column_point):
1330 (current_column_bol_cache):
1331 (skip_invisible, current_column, check_display_width):
1332 (check_display_width, scan_for_column, current_column_1)
1333 (Findent_to, Fcurrent_indentation, position_indentation)
1334 (indented_beyond_p, Fmove_to_column, compute_motion):
1335 (Fcompute_motion, Fvertical_motion):
1336 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1337 (last_known_column_modified): Use EMACS_INT, not int.
1338 (check_display_width):
1340 Check that fixnums and floats are in proper range for system types.
1341 (compute_motion): Don't assume index or fixnum fits in int.
1342 (compute_motion, Fcompute_motion):
1343 Use int, not EMACS_INT, when it is wide enough.
1344 (vmotion): Omit local var start_hpos that is always 0; that way
1345 we don't need to worry about overflow in expressions involving it.
1346 * indent.h: Adjust decls to match defn changes elsewhere.
1348 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1349 Use int, not EMACS_INT, where int is wide enough.
1350 Remove unused members ovstring_chars_done and tab_offset;
1352 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1353 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1354 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1355 (make_gap, copy_text, insert, insert_and_inherit)
1356 (insert_before_markers, insert_before_markers_and_inherit)
1357 (insert_1, count_combining_before, count_combining_after)
1358 (insert_1_both, insert_from_string)
1359 (insert_from_string_before_markers, insert_from_string_1)
1360 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1361 (adjust_after_replace, adjust_after_insert, replace_range)
1362 (replace_range_2, del_range, del_range_1, del_range_byte)
1363 (del_range_both, del_range_2, modify_region)
1364 (prepare_to_modify_buffer, signal_before_change)
1365 (signal_after_change, Fcombine_after_change_execute):
1366 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1367 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1368 (balance_an_interval, split_interval_right, split_interval_left)
1369 (find_interval, next_interval, update_interval)
1370 (adjust_intervals_for_insertion, delete_node, delete_interval)
1371 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1372 (static_offset_intervals, offset_intervals)
1373 (merge_interval_right, merge_interval_left, make_new_interval)
1374 (graft_intervals_into_buffer, temp_set_point_both)
1375 (temp_set_point, set_point, adjust_for_invis_intang)
1376 (set_point_both, move_if_not_intangible, get_property_and_range)
1377 (get_local_map, copy_intervals, copy_intervals_to_string)
1378 (compare_string_intervals, set_intervals_multibyte_1):
1379 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1380 * intervals.h: Adjust decls to match defn changes elsewhere.
1382 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1383 * keyboard.c (this_command_key_count, this_single_command_key_start)
1384 (before_command_key_count, before_command_echo_length, echo_now)
1385 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1386 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1387 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1388 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1389 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1390 (last_non_minibuf_size, last_point_position, echo_truncate)
1391 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1392 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1393 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1394 (stuff_buffered_input):
1395 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1396 (last_auto_save, command_loop_1, read_char):
1397 Use EMACS_INT, not int, to avoid integer overflow.
1398 (record_char): Avoid overflow in total_keys computation.
1399 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1400 * keyboard.h: Adjust decls to match defn changes elsewhere.
1401 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1402 (Fkey_description, Fdescribe_vector, Flookup_key):
1403 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1404 (click_position): New function, to check that positions are in range.
1405 (Fcurrent_active_maps):
1407 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1408 (Faccessible_keymaps, Fkey_description):
1409 (preferred_sequence_p):
1410 Don't assume fixnum can fit into int.
1411 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1412 Check for integer overflow in size calculations.
1413 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1414 avoid mishandling large integers.
1415 * lisp.h: Adjust decls to match defn changes elsewhere.
1416 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1417 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1418 (struct Lisp_Marker):
1419 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1420 (clip_to_bounds): Now an inline function, moved here from editfns.c.
1421 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1422 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1423 All callers changed.
1424 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1425 Assume the arg has valid form, since it always does.
1426 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1427 unsigned integer system type.
1428 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1429 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1430 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1431 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1432 (duration_to_sec_usec): New decl.
1433 * lread.c (read_from_string_index, read_from_string_index_byte)
1434 (read_from_string_limit, readchar, unreadchar, openp)
1435 (read_internal_start, read1, oblookup):
1436 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1437 (Fload, readevalloop, Feval_buffer, Feval_region):
1438 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1439 (openp): Check for out-of-range argument to 'access'.
1440 (read1): Use int, not EMACS_INT, where int is wide enough.
1441 Don't assume fixnum fits into int.
1442 Fix off-by-one error that can read outside a buffer.
1443 (read_filtered_event): Use duration_to_sec_usec
1444 to do proper overflow checking on durations.
1445 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1446 in size calculation.
1447 (Fexecute_kbd_macro):
1448 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1449 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1450 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1451 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1452 (set_marker_both, set_marker_restricted_both, marker_position)
1453 (marker_byte_position, Fbuffer_has_markers_at):
1454 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1455 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
1456 * menu.c (ensure_menu_items): Rename from grow_menu_items.
1457 It now merely ensures that the menu is large enough, without
1458 necessarily growing it, as this avoids some integer overflow issues.
1459 All callers changed.
1460 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1461 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1462 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1463 Use SAFE_ALLOCA_LISP, not alloca.
1464 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1465 to EMACS_INT. Check that fixnums are in proper range for system types.
1466 * minibuf.c (minibuf_prompt_width, string_to_object)
1467 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1468 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1469 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1470 (get_minibuffer, read_minibuf_unwind):
1471 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1472 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1473 this simplifies overflow checking. All callers changed.
1474 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1476 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1477 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1478 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1479 Check that fixnums are in proper range for system types.
1480 (Fx_create_frame, Fx_show_tip):
1481 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1482 * nsfont.m (ns_findfonts, nsfont_list_family):
1483 Don't assume fixnum fits in long.
1484 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1485 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1486 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1488 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
1489 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1490 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1491 (PRINTDECLARE, PRINTPREPARE):
1492 (strout, print_string):
1493 (print, print_preprocess, print_check_string_charset_prop)
1495 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1497 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1498 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1499 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
1500 (printchar, strout): Use xpalloc to catch size calculation overflow.
1501 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
1502 (print_error_message): Use SAFE_ALLOCA, not alloca.
1503 (print_object): Use int, not EMACS_INT, where int is wide enough.
1504 (print_depth, new_backquote_output, print_number_index):
1505 Use ptrdiff_t, not int, where int might not be wide enough.
1506 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1507 (Fset_process_window_size, Fformat_network_address)
1508 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
1510 Check that fixnums are in proper range for system types.
1511 (Fsignal_process): Simplify by avoiding a goto.
1512 Check for process-ids out of pid_t range rather than relying on
1514 (process_tick, update_tick): Use EMACS_INT, not int.
1515 (Fformat_network_address, read_process_output, send_process)
1516 (Fprocess_send_region, status_notify):
1517 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1518 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1519 (wait_reading_process_output, read_process_output, exec_sentinel):
1520 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1521 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1522 (Faccept_process_output): Use duration_to_sec_usec to do proper
1523 overflow checking on durations.
1524 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1525 Don't assume pid_t fits in int.
1526 * process.h (struct Lisp_Process): Members tick and update_tick
1527 are now of type EMACS_INT, not int.
1528 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1529 configured --with-wide-int.
1530 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1531 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1532 * search.c (looking_at_1, string_match_1):
1533 (fast_string_match, fast_c_string_match_ignore_case)
1534 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1535 (scan_newline, find_before_next_newline, search_command)
1536 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1537 (set_search_regs, wordify):
1540 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1541 (string_match_1, search_buffer, set_search_regs):
1543 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1544 (wordify): Check for overflow in size calculation.
1545 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1546 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1547 Check that fixnums are in proper range for system types.
1548 * sound.c (struct sound_device)
1549 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1550 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1551 (Fplay_sound_internal):
1552 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1553 * syntax.c (struct lisp_parse_state, find_start_modiff)
1554 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1555 (Fparse_partial_sexp):
1556 Don't assume fixnums can fit in int.
1557 (struct lisp_parse_state, find_start_pos, find_start_value)
1558 (find_start_value_byte, find_start_begv)
1559 (update_syntax_table, char_quoted, dec_bytepos)
1560 (find_defun_start, prev_char_comend_first, back_comment):
1561 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1562 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1563 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1564 (Finternal_describe_syntax_value): Check that match_lisp is a
1565 character, not an integer, since the code stuffs it into int.
1566 (scan_words, scan_sexps_forward):
1567 Check that fixnums are in proper range for system types.
1569 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1570 (scan_sexps_forward):
1571 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1572 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1573 * syntax.h: Adjust decls to match defn changes elsewhere.
1574 (struct gl_state_s):
1575 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1576 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1577 MOST_POSITIVE_FIXNUM.
1578 * sysdep.c (wait_for_termination_1, wait_for_termination)
1579 (interruptible_wait_for_termination, mkdir):
1580 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1581 (emacs_read, emacs_write):
1582 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1583 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1584 and double all fit in int.
1585 * term.c (set_tty_color_mode):
1586 Check that fixnums are in proper range for system types.
1587 * termhooks.h (struct input_event):
1588 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1589 * textprop.c (validate_interval_range, interval_of)
1590 (Fadd_text_properties, set_text_properties_1)
1591 (Fremove_text_properties, Fremove_list_of_text_properties)
1592 (Ftext_property_any, Ftext_property_not_all)
1593 (copy_text_properties, text_property_list, extend_property_ranges)
1594 (verify_interval_modification):
1595 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1596 (Fnext_single_char_property_change)
1597 (Fprevious_single_char_property_change):
1598 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1599 (copy_text_properties):
1600 Check for integer overflow in index calculation.
1601 * undo.c (last_boundary_position, record_point, record_insert)
1602 (record_delete, record_marker_adjustment, record_change)
1603 (record_property_change):
1604 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1605 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1606 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1607 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1608 (Fx_hide_tip, Fx_file_dialog):
1609 * w32menu.c (set_frame_menubar):
1610 Use ptrdiff_t, not int, for consistency with rest of code.
1611 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1612 (select_window, Fdelete_other_windows_internal)
1613 (window_scroll_pixel_based, window_scroll_line_based)
1614 (Frecenter, Fset_window_configuration):
1615 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1616 (Fset_window_hscroll, run_window_configuration_change_hook)
1617 (set_window_buffer, temp_output_buffer_show, scroll_command)
1618 (Fscroll_other_window, Frecenter):
1619 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1620 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1621 Don't assume fixnum fits in int.
1622 (Fset_window_scroll_bars):
1623 Check that fixnums are in proper range for system types.
1624 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1625 (string_pos, c_string_pos, number_of_chars, init_iterator)
1626 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1627 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1628 (compute_display_string_end, handle_face_prop)
1629 (face_before_or_after_it_pos, handle_invisible_prop)
1630 (handle_display_prop, handle_display_spec, handle_single_display_spec)
1631 (display_prop_intangible_p, string_buffer_position_lim)
1632 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1633 (get_overlay_strings_1, get_overlay_strings)
1634 (iterate_out_of_display_property, forward_to_next_line_start)
1635 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1636 (get_next_display_element, set_iterator_to_next)
1637 (get_visually_first_element, compute_stop_pos_backwards)
1638 (handle_stop_backwards, next_element_from_buffer)
1639 (move_it_in_display_line_to, move_it_in_display_line)
1640 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1641 (add_to_log, message_dolog, message_log_check_duplicate)
1642 (message2, message2_nolog, message3, message3_nolog
1643 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1644 (current_message_1, truncate_echo_area, truncate_message_1)
1645 (set_message, set_message_1, store_mode_line_noprop)
1646 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1647 (text_outside_line_unchanged_p, check_point_in_composition)
1648 (reconsider_clip_changes)
1649 (redisplay_internal, set_cursor_from_row, try_scrolling)
1650 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1651 (redisplay_window, find_last_unchanged_at_beg_row)
1652 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1653 (trailing_whitespace_p, find_row_edges, display_line)
1654 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1655 (display_mode_element, store_mode_line_string)
1656 (pint2str, pint2hrstr, decode_mode_spec)
1657 (display_count_lines, display_string, draw_glyphs)
1658 (x_produce_glyphs, x_insert_glyphs)
1659 (rows_from_pos_range, mouse_face_from_buffer_pos)
1660 (fast_find_string_pos, mouse_face_from_string_pos)
1661 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1662 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1663 (safe_call, init_from_display_pos, handle_fontified_prop)
1664 (handle_single_display_spec, load_overlay_strings)
1665 (with_echo_area_buffer, setup_echo_area_for_printing)
1666 (display_echo_area, echo_area_display)
1667 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1668 (update_tool_bar, hscroll_window_tree, redisplay_internal)
1669 (redisplay_window, dump_glyph_row, display_mode_line)
1670 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
1671 (handle_display_spec, display_prop_string_p):
1672 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1673 (handle_single_display_spec, build_desired_tool_bar_string)
1674 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1675 (get_specified_cursor_type):
1676 Check that fixnums are in proper range for system types.
1677 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1678 (Flookup_image_map):
1679 Don't assume fixnums fit in int.
1680 (compare_overlay_entries):
1681 Avoid mishandling comparisons due to subtraction overflow.
1682 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1683 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1684 (handle_tool_bar_click):
1685 Use int, not unsigned, since we prefer signed and the signedness
1686 doesn't matter here.
1687 (get_next_display_element, next_element_from_display_vector):
1688 Use int, not EMACS_INT, when int is wide enough.
1689 (start_hourglass): Use duration_to_sec_usec to do proper
1690 overflow checking on durations.
1691 * xfaces.c (Fbitmap_spec_p):
1692 Check that fixnums are in proper range for system types.
1693 (compare_fonts_by_sort_order):
1694 Avoid mishandling comparisons due to subtraction overflow.
1695 (Fx_family_fonts, realize_basic_faces):
1696 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1698 Don't assume fixnum fits in int.
1699 Use SAFE_ALLOCA_LISP, not alloca.
1700 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1701 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1702 (face_at_buffer_position, face_for_overlay_string)
1703 (face_at_string_position):
1704 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1705 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1706 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1708 Check that fixnums are in proper range for system types.
1709 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1710 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1711 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1712 (Fx_change_window_property): Don't assume fixnums fit in int.
1713 * xfont.c (xfont_chars_supported):
1714 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1715 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1716 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1717 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1718 * xml.c (parse_region):
1719 * xrdb.c (magic_file_p):
1720 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1721 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1722 (x_get_local_selection, x_reply_selection_request)
1723 (x_handle_selection_request, wait_for_property_change):
1724 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1725 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1726 short is wide enough.
1727 (x_send_client_event): Don't assume fixnum fits in int.
1728 * xterm.c (x_x_to_emacs_modifiers):
1729 Don't assume EMACS_INT overflows nicely into int.
1730 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1732 (handle_one_xevent): NATNUMP can eval its arg twice.
1733 (x_connection_closed):
1734 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1735 * xterm.h: Adjust decls to match defn changes elsewhere.
1736 (struct scroll_bar): Use struct vectorlike_header
1737 rather than rolling our own approximation.
1738 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1740 2012-05-25 Glenn Morris <rgm@gnu.org>
1742 * lisp.mk (lisp): Update for more files being compiled now.
1744 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1746 * lread.c: Remove `read_pure' which makes no difference.
1747 (read_pure): Remove var.
1748 (unreadpure): Remove function.
1749 (readevalloop): Don't call read_list with -1 flag.
1750 (read1, read_vector): Don't test read_pure any more.
1751 (read_list): Simplify.
1753 * fileio.c, character.h: Minor style tweaks.
1755 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1757 * window.h (clip_changed): Remove useless declaration.
1759 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
1761 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1762 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1764 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1767 This directory predates autoconf and is no longer needed nowadays.
1768 Move its few remaining bits of functionality to where they're needed.
1769 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1770 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1771 * m/template.h: Remove.
1772 * Makefile.in (M_FILE): Remove. All uses removed.
1773 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1774 * lisp.h (USE_LSB_TAG):
1775 * mem-limits.h (EXCEEDS_LISP_PTR):
1776 Use VAL_MAX, not VALBITS, in #if.
1777 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1778 (EMACS_UINT): Define unconditionally now.
1779 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1780 (BITS_PER_EMACS_INT): New constants, replacing
1781 what used to be in config.h, but not useful in #if.
1782 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1783 define them any more.
1784 (VAL_MAX): New macro.
1786 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1787 BITS_PER_EMACS_INT, in #if.
1788 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1789 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1790 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1791 * s/ms-w32.h (DATA_START):
1792 Move here from removed file m/intel386.h.
1793 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1794 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1796 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1798 Assume C89 or later.
1799 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1800 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1802 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1803 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1804 * textprop.c, tparam.c (NULL): Remove.
1805 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1806 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1807 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1808 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1809 * xterm.c (input_signal_count): Assume volatile works.
1811 2012-05-21 Ken Brown <kbrown@cornell.edu>
1813 * xgselect.c (xg_select): Fix first argument in call to 'select'
1816 2012-05-20 Ken Brown <kbrown@cornell.edu>
1818 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
1819 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1821 2012-05-19 Ken Brown <kbrown@cornell.edu>
1823 * xfns.c (x_in_use): Remove `static' qualifier.
1824 * xterm.h (x_in_use): Declare.
1825 * xgselect.c: Include xterm.h.
1826 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1827 and `display_arg' (bug#9754).
1829 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1831 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1833 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1834 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1836 2012-05-18 Eli Zaretskii <eliz@gnu.org>
1838 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1840 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1841 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1843 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1844 reference to image_cache->refcount.
1845 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1847 2012-05-17 Juri Linkov <juri@jurta.org>
1849 * search.c (Fword_search_regexp, Fword_search_backward)
1850 (Fword_search_forward, Fword_search_backward_lax)
1851 (Fword_search_forward_lax): Move functions to isearch.el
1852 (bug#10145, bug#11381).
1854 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1856 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1858 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1860 * lread.c (init_obarray): Declare Qt and Qnil as special.
1862 2012-05-14 Glenn Morris <rgm@gnu.org>
1864 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
1865 Put "libexec" before "bin", for the sake of init_callproc_1.
1867 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1869 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1871 * unexaix.c: Port to more-recent AIX compilers.
1872 (report_error, report_error_1, make_hdr, copy_sym)
1873 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1874 Make arguments const char *, not char *, to avoid violations of C
1875 standard and to fix some AIX warnings reported by Gilles Pion.
1877 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1879 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1880 already have overlays loaded.
1881 (handle_single_display_spec): Before returning without displaying
1882 fringe bitmap, synchronize the bidi iterator with the main display
1883 iterator, by calling iterate_out_of_display_property.
1884 (iterate_out_of_display_property): Detect buffer iteration by
1885 testing that it->string is a Lisp string.
1886 (get_next_display_element): When the current object is exhausted,
1887 and there's something on it->stack, call set_iterator_to_next to
1888 proceed with what's on the stack, instead of returning zero.
1889 (set_iterator_to_next): If called at the end of a Lisp string,
1890 proceed to consider_string_end without incrementing string
1891 position. Don't increment display vector index past the end of
1892 the display vector. (Bug#11417)
1893 (pos_visible_p): Don't report a position visible when move_it_to
1894 stopped at the last line of window, which happens to be scanned
1895 backwards by the bidi iteration. (Bug#11464)
1897 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1899 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1900 and right-margin display specs even if the spec is invalid or we
1901 are on a TTY, and thus unable to display on the fringes.
1902 That's because the text with the property will not be displayed anyway,
1903 so we need to signal to the caller that this is a "replacing"
1904 display spec. This fixes display when the spec is invalid or we
1907 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1909 * unexaix.c (make_hdr): Fix typo in prototype.
1910 This bug broke the build on AIX. Problem reported by Gilles Pion.
1912 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
1914 * keyboard.c (kbd_buffer_get_event): Read special events also in
1915 batch mode. (Bug#11415)
1917 2012-05-12 Glenn Morris <rgm@gnu.org>
1919 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1921 2012-05-12 Eli Zaretskii <eliz@gnu.org>
1923 * lisp.mk (lisp): Add newcomment.elc.
1925 2012-05-12 Glenn Morris <rgm@gnu.org>
1927 * Makefile.in (MKDIR_P): New, set by configure.
1928 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1930 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1932 Remove unused function hourglass_started.
1933 * dispextern.h (hourglass_started):
1934 * w32fns.c (hourglass_started):
1935 * xdisp.c (hourglass_started): Remove.
1937 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
1939 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1940 Update dependencies.
1942 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1944 * xgselect.c (xg_select): Put maxfds+1 into a var.
1945 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1947 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1949 2012-05-10 Dave Abrahams <dave@boostpro.com>
1951 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1952 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1954 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
1956 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1957 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1958 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1959 Initialize xd_registered_buses.
1961 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1963 Untag more efficiently if USE_LSB_TAG.
1964 This is based on a proposal by YAMAMOTO Mitsuharu in
1965 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1966 For an admittedly artificial (nth 8000 longlist) benchmark on
1967 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1968 Emacs's overall text size by 1%.
1969 * lisp.h (XUNTAG): New macro.
1970 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1971 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1972 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1973 * eval.c (Fautoload):
1974 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1975 * frame.h (XFRAME): Use XUNTAG.
1977 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1978 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1979 Remove unportable assumptions about print widths of types like
1981 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1982 intptr_t when converting between pointer and integer, to avoid GCC
1983 warnings about wrong width.
1985 2012-05-09 Eli Zaretskii <eliz@gnu.org>
1987 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1988 stack for each reader_thread, instead of defaulting to 8MB
1989 determined by the linker. This avoids failures in creating
1990 subprocesses on Windows 7, see the discussion in this thread:
1991 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1993 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1995 Fix up display of the *Minibuf-0* buffer in the mini window.
1996 * keyboard.c (read_char): Don't clear the echo area if there's no
1998 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
1999 contents of *Minibuf-0*) if there's no message displayed in its stead.
2001 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
2003 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2006 2012-05-06 Chong Yidong <cyd@gnu.org>
2008 * lisp.mk (lisp): Update.
2010 2012-05-05 Jim Meyering <meyering@redhat.com>
2012 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2014 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2016 * data.c (PUT_ERROR): New macro.
2017 (syms_of_data): Use it. Add new error type `user-error'.
2018 * undo.c (user_error): New function.
2019 (Fprimitive_undo): Use it.
2020 * print.c (print_error_message): Adjust print style for `user-error'.
2021 * keyboard.c (user_error): New function.
2022 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2024 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2026 Do not limit current-time-string to years 1000..9999.
2027 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2028 (Fcurrent_time_string): Support any year that is supported by the
2029 underlying localtime representation. Don't use asctime, as it
2030 has undefined behavior for years outside the range -999..9999.
2032 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2034 Fix race conditions involving setenv, gmtime, localtime, asctime.
2035 Without this fix, interrupts could mess up code that uses these
2036 nonreentrant functions, since setting TZ invalidates existing
2037 tm_zone or tzname values, and since most of these functions return
2038 pointers to static storage.
2039 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2040 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2041 Grow the critical sections to include not just invoking
2042 localtime/gmtime, but also accessing these functions' results
2043 including their tm_zone values if any, and any related TZ setting.
2044 (format_time_string): Last arg is now struct tm *, not struct tm **,
2045 so that the struct tm is saved in the critical section.
2046 All callers changed. Simplify allocation of initial buffer, partly
2047 motivated by the fact that memory allocation needs to be outside
2048 the critical section.
2050 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2052 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2053 with RESET_INTERVAL.
2055 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2056 Remove duplicated buffer name initialization.
2058 2012-05-02 Jim Meyering <jim@meyering.net>
2060 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2062 * xfns.c (x_window): Use xstrdup (Bug#11375).
2064 2012-05-02 Eli Zaretskii <eliz@gnu.org>
2066 * xdisp.c (pos_visible_p): If already at a newline from the
2067 display string before the 'while' loop, don't walk back the glyphs
2068 from it3.glyph_row. Solves assertion violation when the display
2069 string begins with a newline (egg.el). (Bug#11367)
2071 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2073 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2076 2012-05-01 Glenn Morris <rgm@gnu.org>
2078 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2079 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2080 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2081 All were removed before 23.1.
2083 * dispnew.c: Remove HAVE_LIBNCURSES test;
2084 it is always true on relevant platforms.
2086 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2087 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2089 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2091 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2093 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2094 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2097 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2099 Do not avoid creating empty evaporating overlays (Bug#9642).
2100 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2101 That is, do not delete an evaporating overlay if it becomes
2102 empty after its bounds are adjusted to fit within its buffer.
2103 This fix caused other problems, and I'm reverting it until we get
2104 to the bottom of them.
2106 2012-04-27 Chong Yidong <cyd@gnu.org>
2108 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2110 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2112 * xdisp.c (pos_visible_p): If the window start position is beyond
2113 ZV, start the display from buffer beginning. Prevents assertion
2114 violation in init_iterator when the minibuffer window is scrolled
2117 * window.c (window_scroll_pixel_based): Likewise.
2119 2012-04-27 Chong Yidong <cyd@gnu.org>
2121 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2123 2012-04-27 Glenn Morris <rgm@gnu.org>
2125 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2126 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2128 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2130 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2131 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
2133 2012-04-26 Eli Zaretskii <eliz@gnu.org>
2135 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2136 display element, check also the underlying string or buffer
2137 character. (Bug#11341)
2139 * w32menu.c: Include w32heap.h.
2140 (add_menu_item): If the call to AppendMenuW (via
2141 unicode_append_menu) fails, disable Unicode menus only if we are
2142 running on Windows 9X/Me.
2144 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2146 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2147 (xgetint): Add missing shift for LSB tags.
2149 2012-04-24 Martin Rudalics <rudalics@gmx.at>
2151 * keyboard.c (read_char): Don't wipe echo area for select window
2152 events: These might get delayed via `mouse-autoselect-window'
2155 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
2157 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2158 manipulation of :loaded-from data.
2160 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
2162 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2163 now a cons (bug#11311).
2165 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2167 Do not create empty overlays with the evaporate property (Bug#9642).
2168 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2169 if it becomes empty after its bounds are adjusted to fit within
2170 its buffer. Without this fix, in a nonempty buffer (let ((o
2171 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2172 yields an empty overlay that has the evaporate property, which is
2173 not supposed to happen.
2175 Fix minor GTK3 problems found by static checking.
2176 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2177 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2178 (struct _EmacsFixedClass, emacs_fixed_get_type):
2179 Move decls here from emacsgtkfixed.h, since they needn't be public.
2180 (emacs_fixed_get_type): Now static.
2181 (emacs_fixed_class_init): Omit unused local.
2182 (emacs_fixed_child_type): Remove; unused.
2183 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2184 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2185 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2186 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2187 (EMACS_FIXED_GET_CLASS): Remove; unused.
2188 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2190 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2191 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2193 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2195 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
2196 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
2197 (__malloc_size_t, __malloc_ptrdiff_t):
2198 Remove. All uses removed, replaced by the definiens if needed,
2199 since we can assume C89 or better now.
2200 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2201 (protect_malloc_state, align, get_contiguous_space)
2202 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2203 (malloc_atfork_handler_child, malloc_enable_thread)
2204 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2205 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2206 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2207 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2208 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2209 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2210 Define using prototypes, not old style.
2211 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2212 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2213 (align): Don't assume that signed integer overflow wraps around.
2214 Omit unused local var.
2215 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2216 (_free_internal_nolock, memalign, mallochook, reallochook):
2217 Omit no-longer-needed casts.
2218 (valloc): Use getpagesize, not __getpagesize.
2219 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2220 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2222 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2224 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
2226 Move functions from C to Lisp. Make non-blocking method calls
2227 the default. Implement further D-Bus standard interfaces.
2229 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2230 (QCdbus_request_name_allow_replacement)
2231 (QCdbus_request_name_replace_existing)
2232 (QCdbus_request_name_do_not_queue)
2233 (QCdbus_request_name_reply_primary_owner)
2234 (QCdbus_request_name_reply_in_queue)
2235 (QCdbus_request_name_reply_exists)
2236 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2237 (QCdbus_registered_serial, QCdbus_registered_method)
2238 (QCdbus_registered_signal): New Lisp objects.
2239 (XD_DEBUG_MESSAGE): Use sizeof.
2240 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2241 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2242 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2243 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2244 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2245 (xd_signature, xd_append_arg): Allow float for integer types.
2246 (xd_get_connection_references): New function.
2247 (xd_get_connection_address): Rename from xd_initialize.
2248 Return cached address.
2249 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2250 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2252 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
2253 Return number of refcounts.
2254 (Fdbus_get_unique_name): Make stronger parameter check.
2255 (Fdbus_message_internal): New defun.
2256 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2257 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2258 (Fdbus_send_signal, Fdbus_register_service)
2259 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2260 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2261 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2262 (Vdbus_compiled_version, Vdbus_runtime_version)
2263 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2264 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2265 (Vdbus_message_type_signal): New defvars.
2266 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2269 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2271 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2272 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2273 Do not assume ptrdiff_t is the same width as 'int'.
2275 * alloc.c: Handle unusual debugging option combinations.
2276 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2277 since the two debugging options are incompatible.
2278 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2280 (mem_init, mem_insert, mem_insert_fixup):
2281 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2282 (NEED_MEM_INSERT): Remove; no longer needed.
2284 2012-04-22 Leo Liu <sdl.web@gmail.com>
2286 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2288 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2290 * sysdep.c [__FreeBSD__]: Minor cleanups.
2291 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2292 Use Emacs indenting style more consistently. Avoid some casts.
2293 Use 'double' consistently rather than mixing 'float' and 'double'.
2295 2012-04-21 Eduard Wiebe <usenet@pusto.de>
2297 * sysdep.c (list_system_processes, system_process_attributes):
2298 Add implementation for FreeBSD (Bug#5243).
2300 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2302 * lisp.mk (lisp): Update.
2304 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2306 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2307 It is never used otherwise.
2309 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2311 * print.c (print_preprocess): Only check print_depth if print-circle
2313 (print_object): Check for cycles even when print-circle is nil and
2314 print-gensym is t, but only check print_depth if print-circle is nil.
2316 2012-04-20 Chong Yidong <cyd@gnu.org>
2318 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2319 set the status to "failed" and ensure that sentinel is run.
2321 2012-04-20 Glenn Morris <rgm@gnu.org>
2323 * process.c (Fset_process_inherit_coding_system_flag)
2324 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
2325 (Fmake_network_process, Fmake_serial_process): Doc fix.
2327 2012-04-20 Eli Zaretskii <eliz@gnu.org>
2329 * xdisp.c (string_buffer_position_lim): Limit starting position to
2331 (set_cursor_from_row): If called for a mode-line or header-line
2332 row, return zero immediately.
2333 (try_cursor_movement): If inside continuation line, don't back up
2334 farther than the first row after the header line, if any.
2335 Don't consider the header-line row as "partially visible", even if
2336 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2338 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2340 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2343 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
2344 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
2346 configure: new option --enable-gcc-warnings (Bug#11207)
2347 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2348 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2349 (ALL_CFLAGS): Use new macros rather than old.
2350 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2351 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2352 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2353 -Wunused-result, -Wunused-variable. This should go away once
2354 the Emacs and Gnulib regex code is merged.
2355 (xmalloc, xrealloc): Now static.
2357 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2359 * dired.c (Fsystem_groups): Remove unused local.
2361 2012-04-17 Glenn Morris <rgm@gnu.org>
2363 * dired.c (Fsystem_users): Doc fix.
2365 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2367 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2368 (syms_of_dired): Add them.
2370 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2372 Fix minor alloc.c problems found by static checking.
2373 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2374 New extern decls, to avoid calling undeclared functions.
2375 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2376 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2377 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2378 (NEED_MEM_INSERT): New macro.
2379 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
2380 Remove one incorrect comment and fix another.
2382 Fix minor ralloc.c problems found by static checking.
2383 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2384 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2385 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2386 (r_alloc_sbrk): Now static.
2388 Improve ralloc.c interface checking.
2389 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2390 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2391 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2392 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2393 [REL_ALLOC]: ... to here, to check interface.
2394 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2395 Remove decls. This fixes an "It stinks!".
2397 * alloc.c (which_symbols): Fix alignment issue / type clash.
2399 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2401 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2402 (struct Lisp_Misc_Any): Likewise.
2403 (struct Lisp_Free): Likewise.
2404 * alloc.c (union aligned_Lisp_Symbol): Define.
2405 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2406 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2407 (union aligned_Lisp_Misc): Define.
2408 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2409 aligned_Lisp_Misc instead of union Lisp_Misc.
2410 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
2412 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2414 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2415 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2416 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2417 * s/netbsd.h, s/sol2-6.h:
2418 Remove definition of GC_MARK_STACK, since the default now works.
2419 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2420 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2421 no longer the default.
2422 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2424 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2426 * lread.c (lisp_file_lexically_bound_p):
2427 Fix hang at ";-*-\n" (bug#11238).
2429 2012-04-14 Eli Zaretskii <eliz@gnu.org>
2431 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2432 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2434 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2436 * nsterm.m (constrainFrameRect): Always constrain when there is only
2437 one screen (Bug#10962).
2439 2012-04-13 Ken Brown <kbrown@cornell.edu>
2441 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2443 2012-04-13 Reuben Thomas <rrt@sc3d.org>
2445 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2447 2012-04-11 Daniel Colascione <dancol@dancol.org>
2449 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2450 against is gone. It's better to use vfork now so that when Cygwin
2451 gains a new, working vfork, we use it automatically (bug#10398).
2453 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2455 * window.c (save_window_save): Obey window-point-insertion-type.
2457 2012-04-11 Glenn Morris <rgm@gnu.org>
2459 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2461 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2463 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2465 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
2467 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2468 (force_quit_count): New var.
2469 (handle_interrupt): Use it.
2471 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
2473 * w32.c (w32_delayed_load): Record the full path of the library
2474 being loaded (bug#10424).
2476 2012-04-09 Glenn Morris <rgm@gnu.org>
2478 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2479 not just in the obarray, before snarfing them. (Bug#11036)
2481 * Makefile.in ($(leimdir)/leim-list.el):
2482 Pass EMACS rather than BUILT_EMACS.
2484 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2486 * process.c (make_process):
2487 * process.h: Add integer `gnutls_handshakes_tried' member to
2490 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2491 Add convenience `GNUTLS_LOG2i' macro.
2493 * gnutls.c (gnutls_log_function2i): Convenience log function.
2494 (emacs_gnutls_read): Use new log functions,
2495 `gnutls_handshakes_tried' process member, and
2496 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2497 attempts per process (connection).
2499 2012-04-09 Chong Yidong <cyd@gnu.org>
2501 * eval.c (Fuser_variable_p, user_variable_p_eh)
2502 (lisp_indirect_variable): Functions deleted.
2503 (Fdefvar): Caller changed.
2505 * callint.c (Finteractive, Fcall_interactively):
2506 * minibuf.c (Fread_variable): Callers changed.
2508 2012-04-09 Eli Zaretskii <eliz@gnu.org>
2510 * xdisp.c (set_cursor_from_row): If the display string appears in
2511 the buffer at position that is closer to point than the position
2512 after the display string, display the cursor on the first glyph of
2513 the display string. Fixes cursor display when a 'display' text
2514 property immediately follows invisible text. (Bug#11094)
2516 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2518 composite.c: use 'double' consistently
2519 * composite.c (get_composition_id): Use 'double' consistently
2520 instead of converting 'float' to 'double' and vice versa; this is
2521 easier to understand and avoids a GCC warning.
2523 2012-04-09 Glenn Morris <rgm@gnu.org>
2525 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2526 preparation for dumping it with emacs. (Bug#4789)
2527 (leimdir): New variable.
2528 ($(leimdir)/leim-list.el): New rule.
2529 (emacs$(EXEEXT)): Depend on leim-list.el.
2531 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2532 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2533 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2535 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2537 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2540 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
2542 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2543 Remove unused local variable.
2545 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2547 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2548 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2549 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2550 objects, as mark_maybe_pointer will catch them otherwise.
2551 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2552 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2554 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2556 Fix typo that broke non-Windows builds.
2557 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2559 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2561 Support building on MS-Windows with libxml2.
2563 * makefile.w32-in (OBJ2): Add xml.$(O).
2564 (GLOBAL_SOURCES): Add xml.c.
2565 ($(BLD)/xml.$(O)): New dependency list.
2567 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2568 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2569 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2570 [!WINDOWSNT]: New macros.
2571 (init_libxml2_functions, libxml2_loaded_p): New functions.
2572 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2573 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2574 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2575 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2577 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2578 Call init_libxml2_functions before calling libxml2 functions.
2579 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2581 * emacs.c: Don't include libxml/parser.h.
2582 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2583 xmlCleanupParser directly.
2585 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2587 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2589 * indent.c (Fvertical_motion): If there is a display string at
2590 point, use it.vpos to compute how many lines to backtrack after
2591 move_it_to point. (Bug#11133)
2593 2012-04-06 Eli Zaretskii <eliz@gnu.org>
2595 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2596 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2597 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2598 macros related to unification of CJK characters. For the details,
2599 see the discussion following the message here:
2600 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2602 2012-04-04 Chong Yidong <cyd@gnu.org>
2604 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2606 2012-04-01 Eli Zaretskii <eliz@gnu.org>
2608 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2609 instead of alloca. (Bug#11138)
2611 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2613 * w32menu.c (is_simple_dialog): Properly check lisp types.
2616 2012-03-31 Eli Zaretskii <eliz@gnu.org>
2618 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2619 position we get to after a call to move_it_to fails the
2620 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2621 only if we wind up in a string from display property. (Bug#11063)
2623 * window.c (Fdelete_other_windows_internal): Invalidate the row
2624 and column information about mouse highlight, so that redisplay
2625 restores it after reallocating the glyph matrices. (Bug#7464)
2627 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2628 string comes from a `display' text property, use the buffer
2629 position of that property as if we actually saw that position in
2631 (move_it_by_lines): Remove the assertion that
2632 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2633 violated when there's a before-string at the beginning of a line.
2636 2012-03-30 Eli Zaretskii <eliz@gnu.org>
2638 * xdisp.c (append_space_for_newline): If the default face was
2639 remapped, use the remapped face for the appended newline.
2640 (extend_face_to_end_of_line): Use the remapped default face for
2641 extending the face to the end of the line.
2642 (display_line): Call extend_face_to_end_of_line when the default
2643 face was remapped. (Bug#11068)
2645 2012-03-29 Eli Zaretskii <eliz@gnu.org>
2647 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2649 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2651 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2653 2012-03-27 Glenn Morris <rgm@gnu.org>
2655 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2658 2012-03-26 Kenichi Handa <handa@m17n.org>
2660 * dispextern.h (struct glyph): Fix previous change. Change the
2661 bit length of glyphless.ch to 25 (Bug#11082).
2663 2012-03-26 Chong Yidong <cyd@gnu.org>
2665 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2666 (command_loop_1): Use it; inhibit selection update for
2667 handle-select-window too (Bug#8996).
2669 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2671 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
2673 2012-03-25 Kenichi Handa <handa@m17n.org>
2675 * dispextern.h (struct glyph): Change the bit length of
2676 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2678 2012-03-24 Eli Zaretskii <eliz@gnu.org>
2680 * s/ms-w32.h (tzname): Include time.h before redirecting to
2681 _tzname. Fixes the MSVC build. (Bug#9960)
2683 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2685 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2688 * xterm.c (XTread_socket): Only modify handling_signal if
2689 !SYNC_INPUT. (Bug#11080)
2691 2012-03-23 Eli Zaretskii <eliz@gnu.org>
2693 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2694 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2695 when fetching a multibyte character consumes more bytes than
2696 CHAR_BYTES returns, due to unification of CJK characters in
2697 string_char. (Bug#11073)
2699 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2701 * process.c (wait_reading_process_output): Handle pty disconnect
2702 by refraining from sending oneself a SIGCHLD (bug#10933).
2704 2012-03-22 Chong Yidong <cyd@gnu.org>
2706 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2708 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
2709 Mark string as coming from a prefix property.
2710 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2711 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2713 2012-03-21 Chong Yidong <cyd@gnu.org>
2715 * xfaces.c (Vface_remapping_alist): Doc fix.
2717 2012-03-20 Eli Zaretskii <eliz@gnu.org>
2719 * w32proc.c (Fw32_set_console_codepage)
2720 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2723 2012-03-20 Chong Yidong <cyd@gnu.org>
2725 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2726 to reflect default non-nil value of redisplay-dont-pause.
2728 2012-03-19 Kenichi Handa <handa@m17n.org>
2730 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2731 it fit in a valid range (Bug#11003).
2733 2012-03-18 Eli Zaretskii <eliz@gnu.org>
2735 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2736 that is not from display property, accept the row as a "cursor
2737 row" if one of the string's character has a non-nil `cursor'
2738 property. Fixes cursor positioning when there are newlines in
2739 overlay strings, e.g. in icomplete.el. (Bug#11035)
2741 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2743 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2745 2012-03-12 Chong Yidong <cyd@gnu.org>
2747 * eval.c (inhibit_lisp_code): Rename from
2748 inhibit_window_configuration_change_hook; move from window.c.
2750 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2751 * window.c (run_window_configuration_change_hook)
2752 (syms_of_window): Callers changed.
2754 2012-03-11 Chong Yidong <cyd@gnu.org>
2756 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2758 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2760 2012-03-10 Chong Yidong <cyd@gnu.org>
2762 * frame.c (other_visible_frames): Don't assume the selected frame
2763 is visible (Bug#10955).
2765 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2767 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2769 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2771 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2772 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2775 2012-03-03 Glenn Morris <rgm@gnu.org>
2777 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
2779 2012-03-02 Eli Zaretskii <eliz@gnu.org>
2781 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2782 position past the first glyph_row that ends at ZV. (Bug#10902)
2783 (redisplay_window, next_element_from_string): Fix typos in
2785 (redisplay_window): Pass to move_it_vertically the margin in
2786 pixels, not in screen lines.
2788 2012-03-02 Glenn Morris <rgm@gnu.org>
2790 * buffer.c (buffer-list-update-hook): Doc fix.
2792 2012-02-29 Eli Zaretskii <eliz@gnu.org>
2794 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2795 push_it before setting up the iterator for the first overlay
2796 string, even if we have an empty string loaded.
2797 (next_overlay_string): If there's an empty string on the iterator
2798 stack, pop the stack. (Bug#10903)
2800 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2802 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2803 Suggested by Stefan Monnier in
2804 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2805 * alloc.c (widen_to_Lisp_Object): New static function.
2806 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2807 and widening them to Lisp_Objects. This would work even if
2808 USE_LSB_TAG is defined and wide integers are used, which might
2809 happen in a future version of Emacs.
2811 2012-02-25 Chong Yidong <cyd@gnu.org>
2813 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2816 * xselect.c (Fx_selection_exists_p): Doc fix.
2817 (x_clipboard_manager_save_all): Print an informative message
2818 before saving to clipboard manager.
2820 2012-02-24 Chong Yidong <cyd@gnu.org>
2822 * keyboard.c (process_special_events): Handle all X selection
2823 requests in kbd_buffer, not just the next one (Bug#8869).
2825 2012-02-23 Chong Yidong <cyd@gnu.org>
2827 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2828 call when setting menu-bar-lines and tool-bar-lines parameters.
2829 (unwind_create_frame_1): New helper function.
2831 * window.c (inhibit_window_configuration_change_hook): New var.
2832 (run_window_configuration_change_hook): Obey it.
2833 (syms_of_window): Initialize it.
2835 2012-02-22 Chong Yidong <cyd@gnu.org>
2837 * xterm.c (x_draw_image_relief): Add missing type check for
2838 Vtool_bar_button_margin (Bug#10743).
2840 2012-02-21 Chong Yidong <cyd@gnu.org>
2842 * fileio.c (Vfile_name_handler_alist): Doc fix.
2844 * buffer.c (Fget_file_buffer): Protect against invalid file
2845 handler return value.
2847 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2849 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2850 when computing $valmask.
2852 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2853 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2854 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2855 It's useless in that case, and it can cause problems on hosts
2856 that allocate halves of EMACS_INT values separately.
2857 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2858 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2859 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2860 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2861 it avoids undefined behavior on hosts where shifting right by more
2862 than the word width has undefined behavior.
2864 2012-02-19 Chong Yidong <cyd@gnu.org>
2866 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2867 (Funhandled_file_name_directory, Ffile_name_as_directory)
2868 (Fdirectory_file_name, Fexpand_file_name)
2869 (Fsubstitute_in_file_name): Protect against invalid file handler
2870 return values (Bug#10845).
2872 2012-02-18 Eli Zaretskii <eliz@gnu.org>
2874 * .gdbinit (pitx): Fix incorrect references to fields of the
2877 2012-02-17 Chong Yidong <cyd@gnu.org>
2879 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2881 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2883 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2884 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2886 2012-02-15 Chong Yidong <cyd@gnu.org>
2888 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2889 marked as special. Also, starting docstrings with * is obsolete.
2891 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2893 * gnutls.c (emacs_gnutls_write): Fix last change.
2895 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2897 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2900 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2902 * keymap.c (Fsingle_key_description): Handle char ranges.
2904 2012-02-12 Chong Yidong <cyd@gnu.org>
2906 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2907 as that creates a dangerous corner case.
2909 * window.c (Fdelete_window_internal): Invalidate the mouse
2910 highlight (Bug#9904).
2912 2012-02-12 Glenn Morris <rgm@gnu.org>
2914 * xselect.c (Fx_own_selection_internal)
2915 (Fx_get_selection_internal, Fx_disown_selection_internal)
2916 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2917 * nsselect.m (Fx_own_selection_internal)
2918 (Fx_disown_selection_internal, Fx_selection_exists_p)
2919 (Fx_selection_owner_p, Fx_get_selection_internal):
2920 Sync docs and argument specs with the xselect.c versions.
2922 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2924 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2926 2012-02-11 Eli Zaretskii <eliz@gnu.org>
2928 * w32select.c (Fx_selection_exists_p): Sync doc string and
2929 argument list with xselect.c. (Bug#10783)
2931 * w16select.c (Fx_selection_exists_p): Sync doc string and
2932 argument list with xselect.c. (Bug#10783)
2934 2012-02-10 Glenn Morris <rgm@gnu.org>
2936 * fns.c (Fsecure_hash): Doc fix.
2938 2012-02-09 Kenichi Handa <handa@m17n.org>
2940 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2942 2012-02-07 Chong Yidong <cyd@gnu.org>
2944 * buffer.c (Fbuffer_local_variables)
2945 (buffer_lisp_local_variables): Handle unbound vars correctly;
2946 don't let Qunbound leak into Lisp.
2948 2012-02-07 Glenn Morris <rgm@gnu.org>
2950 * image.c (Fimagemagick_types): Doc fix.
2952 * image.c (imagemagick-render-type): Change it from a lisp object
2953 to an integer. Move the doc here from the lisp manual.
2954 Treat all values not equal to 0 the same.
2956 2012-02-06 Chong Yidong <cyd@gnu.org>
2958 * doc.c (store_function_docstring): Avoid applying docstring of
2959 alias to base function (Bug#2603).
2961 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2963 * .gdbinit (pp1, pv1): Remove redundant defines.
2966 2012-02-04 Chong Yidong <cyd@gnu.org>
2968 * nsterm.m: Declare a global (Bug#10694).
2970 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2972 * w32.c (get_emacs_configuration_options):
2973 Include --enable-checking, if specified, in the return value.
2975 2012-02-04 Martin Rudalics <rudalics@gmx.at>
2977 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2978 after rounding frame sizes. (Bug#9723)
2980 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2982 * keyboard.c (adjust_point_for_property): Don't position point
2983 before BEGV. (Bug#10696)
2985 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2987 Handle overflow when computing char display width (Bug#9496).
2988 * character.c (char_width): Return EMACS_INT, not int.
2989 (char_width, c_string_width): Check for overflow when
2990 computing the width; this is possible now that individual
2991 characters can have unbounded width. Problem introduced
2992 by merge from Emacs 23 on 2012-01-19.
2994 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
2996 * dbusbind.c (Fdbus_register_method): Mention the return value
2997 :ignore in the docstring.
2999 2012-02-02 Glenn Morris <rgm@gnu.org>
3001 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3003 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3004 Unconditionally set to t. (Bug#10673)
3005 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3006 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3007 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3009 2012-02-02 Kenichi Handa <handa@m17n.org>
3011 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3012 0, do not call append_composite_glyph.
3014 2012-02-02 Kenichi Handa <handa@m17n.org>
3016 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3018 (x_produce_glyphs): If the component of a composition is a null
3019 string, set it->pixel_width to 1 to avoid zero-width glyph.
3021 2012-02-01 Eli Zaretskii <eliz@gnu.org>
3023 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3024 first 2 arguments are identical. This makes inserting large
3025 output from a subprocess an order of magnitude faster on
3026 MS-Windows, where all sbrk'ed memory is always contiguous.
3028 2012-01-31 Glenn Morris <rgm@gnu.org>
3030 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3031 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3032 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3034 2012-01-29 Glenn Morris <rgm@gnu.org>
3036 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3038 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3040 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3042 2012-01-28 Chong Yidong <cyd@gnu.org>
3044 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3046 2012-01-26 Chong Yidong <cyd@gnu.org>
3048 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3050 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3051 repeat counts (Bug#10507).
3053 2012-01-26 Glenn Morris <rgm@gnu.org>
3055 * lread.c (syms_of_lread): Doc fix.
3057 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3059 * coding.c (encode_designation_at_bol): Change return value to
3062 2012-01-25 Chong Yidong <cyd@gnu.org>
3064 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3066 2012-01-21 Chong Yidong <cyd@gnu.org>
3068 * floatfns.c (Fcopysign): Make the second argument non-optional,
3069 since nil is not allowed anyway.
3071 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3073 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3074 (send_process): Likewise.
3076 2012-01-19 Martin Rudalics <rudalics@gmx.at>
3078 * window.c (save_window_save, Fcurrent_window_configuration)
3079 (Vwindow_persistent_parameters): Do not use Qstate.
3080 Rewrite doc-strings.
3082 2012-01-19 Kenichi Handa <handa@m17n.org>
3084 * character.c (char_width): New function.
3085 (Fchar_width, c_string_width, lisp_string_width):
3086 Use char_width (Bug#9496).
3088 2012-01-16 Martin Rudalics <rudalics@gmx.at>
3090 * window.c (Vwindow_persistent_parameters): New variable.
3091 (Fset_window_configuration, save_window_save): Handle persistent
3094 2012-01-14 Eli Zaretskii <eliz@gnu.org>
3096 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3097 thrashing the stack of the thread. (Bug#9087)
3099 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3101 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3103 2012-01-11 Eli Zaretskii <eliz@gnu.org>
3105 * xdisp.c (rows_from_pos_range): Handle the case where the
3106 highlight ends on a newline. (Bug#10464)
3107 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3108 he end column for display of highlight that ends on a newline
3111 2012-01-11 Glenn Morris <rgm@gnu.org>
3113 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3114 from load-path also when installation-directory is nil. (Bug#10208)
3116 2012-01-10 Glenn Morris <rgm@gnu.org>
3118 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3120 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3121 Update template values to be closer to their typical values these days.
3123 2012-01-09 Eli Zaretskii <eliz@gnu.org>
3125 * xdisp.c (rows_from_pos_range): Accept additional argument
3126 DISP_STRING, and accept any glyph in a row whose object is that
3127 string as eligible for mouse highlight. Fixes mouse highlight of
3128 display strings from overlays. (Bug#10464)
3130 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
3132 emacs: fix an auto-save permissions race condition (Bug#10400)
3133 * fileio.c (auto_saving_dir_umask): New static var.
3134 (Fmake_directory_internal): Use it.
3135 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3136 creating the directory. The old code temporarily assigns
3137 too-generous permissions to the directory.
3138 (do_auto_save_eh): Clear it.
3139 (Fdo_auto_save): Catch all errors, not just file errors, so
3140 that the var is always cleared.
3142 2012-01-07 Eli Zaretskii <eliz@gnu.org>
3144 * search.c (scan_buffer): Pass character positions to
3145 know_region_cache, not byte positions. (Bug#6540)
3147 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
3149 * w32.c (sys_rename): Report EXDEV when rename of a directory
3150 fails because the target is on another logical disk. (Bug#10284)
3152 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3154 * xterm.c (x_embed_request_focus): New function.
3156 * xterm.h: Add prototype.
3158 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3160 2012-01-05 Glenn Morris <rgm@gnu.org>
3162 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3164 2012-01-01 Eli Zaretskii <eliz@gnu.org>
3166 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3167 Load gnutls_transport_set_lowat only if GnuTLS version is below
3169 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3170 GnuTLS versions below 2.11.1.
3172 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3174 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3175 to the doc string advising against its use for altering the way
3176 windows are scrolled.
3178 2011-12-28 Kenichi Handa <handa@m17n.org>
3180 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3181 coding-system ASCII compatible only when it does not produce BOM
3182 on encoding (Bug#10383).
3184 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3186 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3188 (create_and_show_popup_menu): Always use menu_position_func for
3191 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3193 * callint.c (Fcall_interactively): Don't truncate prompt string.
3195 2011-12-23 Eli Zaretskii <eliz@gnu.org>
3197 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3198 property that ends at ZV, so that the bidi iteration could be
3199 resumed from there (after widening). (Bug#10360)
3201 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3203 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3205 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3207 * nsterm.m (x_free_frame_resources):
3208 Release f->output_data.ns->miniimage.
3209 (ns_index_color): Fix indentation. Do not retain
3210 color_table->colors[i].
3212 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3215 * nsfns.m (x_set_background_color): Assign return value from
3216 ns_index_color to face-background instead of NSColor*.
3217 (ns_implicitly_set_icon_type): Fix indentation.
3218 Change assignment in for loop to comparison.
3220 * emacs.c (ns_pool): New variable.
3221 (main): Assign ns_pool.
3222 (Fkill_emacs): Call ns_release_autorelease_pool.
3224 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3225 autorelease fdesc, release fdAttrs and tdict.
3226 (ns_get_covering_families): Release charset.
3227 (ns_findfonts): Release NSFontDescriptor created with new.
3228 (ns_uni_to_glyphs): Fix indentation.
3229 (setString): Release attrStr before assigning new value.
3231 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3233 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3235 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3236 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3238 2011-12-18 David Reitter <reitter@cmu.edu>
3240 * nsterm.m (ns_term_init): Subscribe for notifications
3241 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3242 to method trackingNotification in EmacsMenu.
3244 * nsmenu.m (trackingMenu): New variable.
3245 (trackingNotification): New method (from Aquamacs).
3246 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3247 from Aquamacs (Bug#7030).
3249 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3251 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3252 (symbol_to_nsstring): Fix indentation.
3253 (ns_symbol_to_pb): New function.
3254 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3255 (Fns_rotate_cut_buffers_internal): Remove.
3256 (Fns_store_selection_internal): Rename from
3257 Fns_store_cut_buffer_internal.
3258 (ns_get_foreign_selection, Fx_own_selection_internal)
3259 (Fx_disown_selection_internal, Fx_selection_exists_p)
3260 (Fns_get_selection_internal, Fns_store_selection_internal):
3261 Use ns_symbol_to_pb and check if return value is nil.
3262 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3263 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
3264 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3265 renamed to Sns_store_selection_internal.
3266 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3267 and remove this function.
3268 (ns_handle_selection_clear): Remove, never used.
3269 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3272 2011-12-17 Ken Brown <kbrown@cornell.edu>
3274 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3275 GID is unknown (Bug#10257).
3277 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3279 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3280 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3281 which caused a build failure on GNU/Linux IA-64. This problem was
3282 introduced by my 2011-10-07 patch.
3284 2011-12-15 Juri Linkov <juri@jurta.org>
3286 * image.c (imagemagick_error): New function. (Bug#10112)
3287 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3288 Use `imagemagick_error' where ImageMagick functions return
3290 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3293 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3295 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3296 fill background (Bug#8992).
3298 2011-12-13 Martin Rudalics <rudalics@gmx.at>
3300 * window.c (Vwindow_combination_resize)
3301 (Vwindow_combination_limit): Use t instead of non-nil in
3303 (Vrecenter_redisplay): Add first sentence of doc-string on
3305 (Frecenter): Fix doc-string typo.
3307 2011-12-11 Kenichi Handa <handa@m17n.org>
3309 * coding.c (Funencodable_char_position): Pay attention to the
3310 buffer text relocation (Bug#9389).
3312 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3314 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3315 gtk_init (Bug#10100).
3317 2011-12-10 Eli Zaretskii <eliz@gnu.org>
3319 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3320 IT->string is nil. (Bug#10263)
3322 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3324 * nsterm.h (x_free_frame_resources): Declare.
3326 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3327 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3329 * nsterm.h (ns_get_defaults_value): Declare.
3331 * nsterm.m (ns_default): Call ns_get_defaults_value.
3333 2011-12-09 Eli Zaretskii <eliz@gnu.org>
3335 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3338 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3340 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3341 that where the value of an _OBJC_* symbol points to is in the .bss
3342 section (Bug#10240).
3344 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3346 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
3347 after the loop to call ccl_driver at least once (Bug#8619).
3349 2011-12-08 Kenichi Handa <handa@m17n.org>
3351 * ftfont.c (get_adstyle_property): Fix previous change
3354 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
3356 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3357 dirs from the default value of EMACSLOADPATH (bug#10208).
3359 2011-12-07 Glenn Morris <rgm@gnu.org>
3361 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3362 installation and source directories as well. (Bug#10208)
3364 2011-12-06 Chong Yidong <cyd@gnu.org>
3366 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3368 2011-12-06 Glenn Morris <rgm@gnu.org>
3370 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3371 as an error, not just -1. (Bug#10217)
3373 2011-12-05 Chong Yidong <cyd@gnu.org>
3375 * keyboard.c (process_special_events): New function.
3376 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3378 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3380 * coding.c (encode_designation_at_bol): Don't use uninitialized
3381 local variable (Bug#9318).
3383 2011-12-05 Kenichi Handa <handa@m17n.org>
3385 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3386 return Qnil (Bug#8046, Bug#10193).
3388 2011-12-05 Kenichi Handa <handa@m17n.org>
3390 * coding.c (encode_designation_at_bol): New args charbuf_end and
3391 dst. Return the number of produced bytes. Callers changed.
3392 (coding_set_source): Return how many bytes coding->source was
3394 (coding_set_destination): Return how many bytes
3395 coding->destination was relocated.
3396 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
3397 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
3399 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3401 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3402 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3405 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3407 The following changes are to fix Bug#9318.
3409 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
3410 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3411 (encode_coding_iso_2022, encode_coding_sjis)
3412 (encode_coding_big5, encode_coding_charset): Use the above macros.
3414 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
3416 * lisp.h (process_quit_flag): Fix external declaration.
3418 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3420 Don't macro-inline non-performance-critical code.
3421 * eval.c (process_quit_flag): New function.
3422 * lisp.h (QUIT): Use it.
3424 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3426 * nsfns.m (get_geometry_from_preferences): New function.
3427 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3429 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3431 * emacs.c (Qkill_emacs): Define.
3432 (syms_of_emacs): Initialize it.
3433 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3434 Qquit_flag to `kill-emacs' instead.
3435 (quit_throw_to_read_char): Add parameter `from_signal'.
3436 All callers changed. Call Fkill_emacs if requested and safe.
3437 * lisp.h (QUIT): Call Fkill_emacs if requested.
3439 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3441 * widget.c (update_wm_hints): Return if wmshell is null.
3442 (widget_update_wm_size_hints): New function.
3444 * widget.h (widget_update_wm_size_hints): Declare.
3446 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3447 widget_update_wm_size_hints (Bug#10104).
3449 2011-12-03 Eli Zaretskii <eliz@gnu.org>
3451 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3452 before a newline, prepare the bidi iterator for consuming the
3453 newline, and keep the current paragraph direction. (Bug#10183)
3454 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
3456 2011-12-02 Juri Linkov <juri@jurta.org>
3458 * search.c (Fword_search_regexp): New Lisp function created from
3459 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3460 (Fword_search_backward, Fword_search_forward)
3461 (Fword_search_backward_lax, Fword_search_forward_lax):
3462 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3463 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3465 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3467 * fileio.c (Finsert_file_contents): Move after-change-function call
3468 to before the "handled:" label, since all "goto handled" appear in
3469 cases where the *-change-functions have already been properly called
3472 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3474 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3475 waiting for input. (Bug#10169)
3477 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3479 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3480 verifies glyph row's hash code--we have just reallocated the
3481 glyphs, so their contents can be complete garbage. (Bug#10164)
3483 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
3485 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3487 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3489 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3490 attributes are tested _before_ calling verify_row_hash, to protect
3491 against GCC re-ordering of the tests. (Bug#10164)
3493 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3495 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3497 * xterm.c (handle_one_xevent): Only set async_visible and friends
3498 if net_wm_state_hidden_seen is non-zero (Bug#10002)
3499 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
3500 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3502 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3504 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3505 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3506 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3507 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3508 All uses changed to use GCPRO1 etc.
3509 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3510 Revert to old implementation (i.e., before 2011-03-11).
3512 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3514 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3515 of scroll runs so as to avoid assigning disabled bogus rows and
3516 unnecessary graphics copy operations.
3518 2011-11-27 Eli Zaretskii <eliz@gnu.org>
3520 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3521 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3522 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3523 (malloc, free, realloc, calloc): Redirect to e_* only when
3526 * lisp.h (GCTYPEBITS): Move before first use.
3527 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3528 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3529 this macro definition.
3531 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3534 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3536 * gtkutil.c (xg_create_frame_widgets):
3537 Call gtk_window_set_has_resize_grip (FALSE) if that function is
3538 present with Gtk+ 2.0.
3540 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3542 * fileio.c (Finsert_file_contents): Undo previous change; see
3543 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3545 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3547 Rename locals to avoid shadowing.
3548 * fileio.c (Finsert_file_contents):
3549 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3550 * process.c (wait_reading_process_output):
3551 Rename inner 'proc' to 'p' to avoid shadowing.
3552 Indent for consistency with usual Emacs style.
3554 2011-11-25 Eli Zaretskii <eliz@gnu.org>
3556 * xdisp.c (redisplay_window): If cursor row is not fully visible
3557 after recentering, and scroll-conservatively is set to a large
3558 number, scroll window by a few more lines to make the cursor fully
3559 visible and out of scroll-margin. (Bug#10105)
3560 (start_display): Don't move to the next line if the display should
3561 start at a newline that is part of a display vector or an overlay
3564 2011-11-24 Juri Linkov <juri@jurta.org>
3566 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3567 after the `MagickPingImage' call. (Bug#10112)
3569 2011-11-23 Chong Yidong <cyd@gnu.org>
3571 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3573 2011-11-23 Martin Rudalics <rudalics@gmx.at>
3575 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3576 making another buffer current. (Bug#10114)
3578 2011-11-23 Glenn Morris <rgm@gnu.org>
3580 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3582 2011-11-23 Chong Yidong <cyd@gnu.org>
3584 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3585 using it (Bug#5984).
3587 2011-11-22 Eli Zaretskii <eliz@gnu.org>
3589 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3590 and header-lines, as they don't have one computed for them.
3593 * .gdbinit (prow): Make displayed values more self-explaining.
3594 Add row's hash code.
3596 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3598 * process.c (wait_reading_process_output): Fix asynchrounous
3599 GnuTLS socket handling on some versions of the GnuTLS library.
3600 (wait_reading_process_output): Add comment and URL.
3602 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3604 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3606 2011-11-21 Chong Yidong <cyd@gnu.org>
3608 * window.c (Fnext_window, Fprevious_window): Doc fix.
3610 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3612 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3614 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3616 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3618 2011-11-20 Martin Rudalics <rudalics@gmx.at>
3620 * window.c (Fset_window_combination_limit): Rename argument
3622 (Vwindow_combination_limit): Remove "status" from doc-string.
3624 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3626 * m/ibms390.h: Remove.
3627 * m/ibms390x.h: Don't include "ibms390.h".
3629 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3631 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3632 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3634 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3636 * casetab.c (Fset_case_table):
3637 * charset.c (Fcharset_after): Fix typos.
3639 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
3641 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3642 Otherwise, valgrind does not work on some platforms.
3643 Problem reported by Andreas Schwab in
3644 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3645 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3646 is set, removing the need for VIRT_ADDRESS_VARIES.
3647 (PURE_P): Use a more-efficient implementation that needs just one
3648 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3649 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3650 to 4 (xorl, subq, cmpq, setbe).
3651 * alloc.c (pure): Always extern now, since that's the
3652 VIRT_ADDR_VARIES behavior.
3653 (PURE_POINTER_P): Use a single comparison, not two, for
3654 consistency with the new puresize.h.
3655 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3656 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3657 Remove VIRT_ADDR_VARIES no longer needed.
3659 2011-11-19 Eli Zaretskii <eliz@gnu.org>
3661 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3662 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3663 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3664 behave as if the cursor position were at the window margin.
3666 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3667 and the cursor position is out of bounds, behave as if the cursor
3668 position were at the window margin. (Bug#10075)
3670 2011-11-18 Chong Yidong <cyd@gnu.org>
3672 * window.c (Fwindow_combination_limit): Make first argument
3673 non-optional, since it is meaningless for live windows like the
3676 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3678 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3680 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3682 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3683 (graft_intervals_into_buffer): Simplify.
3685 2011-11-18 Eli Zaretskii <eliz@gnu.org>
3687 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3688 hash values of the two rows.
3689 (copy_row_except_pointers): Preserve the used[] arrays and the
3690 hash values of the two rows. (Bug#10035)
3691 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
3693 * xdisp.c (row_hash): New function, body extracted from
3694 compute_line_metrics.
3695 (compute_line_metrics): Call row_hash, instead of computing the
3698 * dispnew.c (verify_row_hash): Call row_hash for computing the
3699 hash code of a row, instead of duplicating code from xdisp.c.
3701 * dispextern.h (row_hash): Add prototype.
3703 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3705 * frame.c (delete_frame): Don't delete the terminal when the last
3706 X frame is closed if emacs is built with GTK toolkit.
3708 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
3710 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3712 2011-11-17 Martin Rudalics <rudalics@gmx.at>
3714 * window.c (Vwindow_splits): Rename to
3715 Vwindow_combination_resize. Suggested by Juri Linkov.
3716 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3719 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
3721 * nsfns.m (Fns_font_name):
3722 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
3724 2011-11-16 Martin Rudalics <rudalics@gmx.at>
3726 * window.h (window): Rename slot "nest" to "combination_limit".
3727 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3728 (Fset_window_nest): Rename to Fset_window_combination_limit.
3729 (Vwindow_nest): Rename to Vwindow_combination_limit.
3730 (recombine_windows, make_parent_window, make_window)
3731 (Fsplit_window_internal, saved_window)
3732 (Fset_window_configuration, save_window_save): Rename all
3733 occurrences of window_nest to window_combination_limit.
3735 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
3737 * image.c (imagemagick_load_image): Fix typo.
3739 2011-11-14 Eli Zaretskii <eliz@gnu.org>
3741 * xdisp.c (display_line): Move the call to
3742 highlight_trailing_whitespace before the call to
3743 compute_line_metrics, since the latter needs to see the final
3744 faces of all the glyphs to compute ROW's hash value.
3745 Fixes assertion violations in row_equal_p. (Bug#10035)
3747 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
3749 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3750 just return (bug#10044).
3752 2011-11-12 Eli Zaretskii <eliz@gnu.org>
3754 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3755 with user-defined heap size. Bump the default size of the temacs
3756 heap to 27MB, to avoid memory warning when running temacs.
3757 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3759 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3760 current_matrix and desired_matrix. (Bug#9990)
3761 (verify_row_hash) [XASSERTS]: New function.
3762 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3763 that the hash value of glyph rows is correct.
3765 2011-11-12 Martin Rudalics <rudalics@gmx.at>
3767 * window.h (window): Remove splits slot.
3768 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3769 (Fdelete_other_windows_internal, make_parent_window)
3770 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3771 (Fset_window_configuration, save_window_save): Don't deal with
3772 split status of windows.
3773 (saved_window): Remove splits slot.
3774 (Vwindow_splits): Rewrite doc-string.
3776 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3778 * xfns.c (unwind_create_frame):
3779 * nsfns.m (unwind_create_frame):
3780 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3781 Vframe_list (Bug#9999).
3783 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3785 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
3787 2011-11-11 Kenichi Handa <handa@m17n.org>
3789 * callproc.c (Fcall_process): Set the member dst_multibyte of
3792 2011-11-11 Johan Bockgård <bojohan@gnu.org>
3794 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3795 avoid a crash (bug#9496).
3797 2011-11-09 Chong Yidong <cyd@gnu.org>
3799 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3800 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3802 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3804 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3806 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3808 Avoid some portability problems by eschewing 'extern inline' functions.
3809 The trivial performance wins aren't worth the portability hassles; see
3810 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3812 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3813 (window_box_width, window_box_left, window_box_left_offset)
3814 (window_box_right, window_box_right_offset): Undo previous change,
3815 by removing the "extern"s.
3816 * intervals.c (adjust_intervals_for_insertion)
3817 (adjust_intervals_for_deletion): Undo previous change,
3818 making these static again.
3819 (offset_intervals, temp_set_point_both, temp_set_point)
3820 (copy_intervals_to_string): No longer inline.
3821 * xdisp.c (window_text_bottom_y, window_box_width)
3822 (window_box_height, window_box_left_offset)
3823 (window_box_right_offset, window_box_left, window_box_right)
3824 (window_box): No longer inline.
3826 2011-11-08 Chong Yidong <cyd@gnu.org>
3828 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
3829 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3830 Signal an error if not a live window.
3831 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3832 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3834 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
3836 * lisp.h (syms_of_abbrev): Remove declaration.
3837 Reported by CHENG Gao <chenggao@royau.me>.
3839 2011-11-07 Eli Zaretskii <eliz@gnu.org>
3841 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3842 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3843 of temacs in GUI mode.
3845 2011-11-07 Martin Rudalics <rudalics@gmx.at>
3847 * window.h: Declare delete_all_child_windows instead of
3848 delete_all_subwindows.
3849 * window.c (Fwindow_nest, Fset_window_nest)
3850 (Fset_window_new_total, Fset_window_new_normal)
3851 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3852 (delete_all_subwindows): Rename to delete_all_child_windows.
3853 (Fdelete_other_windows_internal, Fset_window_configuration):
3854 Call delete_all_child_windows instead of delete_all_subwindows.
3855 * frame.c (delete_frame): Call delete_all_child_windows instead
3856 of delete_all_subwindows.
3858 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3860 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3861 This is also needed for porting to any host where GC_MARK_STACK is
3862 not GC_MAKE_GCPROS_NOOPS.
3863 (which_symbols): Use it.
3865 2011-11-07 Kenichi Handa <handa@m17n.org>
3867 * coding.c (coding_set_destination): Check coding->src_pos only
3868 when coding->src_object is a buffer (bug#9910).
3870 * process.c (send_process): Set the member src_multibyte of coding
3871 to 0 (bug#9911) when sending a unibyte text.
3873 * callproc.c (Fcall_process): Set the member src_multibyte of
3874 process_coding to 0 (bug#9912).
3876 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3878 * xmenu.c (cleanup_widget_value_tree): New function.
3879 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3880 calling free_menubar_widget_value_tree directly (Bug#9830).
3882 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3884 Fix some portability problems with 'inline'.
3885 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3886 (window_box_width, window_box_left, window_box_left_offset)
3887 (window_box_right, window_box_right_offset): Declare extern.
3888 Otherwise, these inline functions do not conform to C99 and
3889 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3890 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3891 * intervals.c (adjust_intervals_for_insertion)
3892 (adjust_intervals_for_deletion): Now extern, because otherwise the
3893 extern inline functions 'offset_intervals' couldn't refer to it.
3894 (static_offset_intervals): Remove.
3895 (offset_intervals): Rewrite using the old contents of
3896 static_offset_intervals. The old version didn't conform to C99
3897 because an extern inline function contained a reference to an
3898 identifier with static linkage.
3900 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3902 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3905 2011-11-06 Eli Zaretskii <eliz@gnu.org>
3907 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3908 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3909 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3910 return Qleft_to_right.
3912 2011-11-06 Chong Yidong <cyd@gnu.org>
3914 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3915 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3916 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3917 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3918 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3919 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3920 (Fwindow_vscroll): Doc fix.
3921 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3922 argument, since it makes no sense to pass a live window and for
3923 consistency with window-child.
3925 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3927 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3930 2011-11-05 Jason Rumney <jasonr@gnu.org>
3932 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3933 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3935 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3936 bitwise arithmetic preventing use of unicode-sip and non-truetype
3939 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3941 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3944 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3945 initialization code to keep similarity to xfns.c after changes
3948 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3950 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3951 (unwind_create_frame): New function (Bug#9943).
3952 (Fx_create_frame): Restructure code to be more similar to the one in
3953 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3954 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3955 Move terminal->reference_count++ just before making the frame official
3958 * nsterm.m (x_free_frame_resources): New function.
3959 (x_destroy_window): Move code to x_free_frame_resources.
3961 * xfns.c (unwind_create_frame): Fix comment.
3962 (Fx_create_frame, x_create_tip_frame):
3963 Move terminal->reference_count++ just before making the frame
3964 official. Move initialization of image_cache_refcount and
3965 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3967 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3969 Support MSVC build with newer versions of Visual Studio.
3970 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3971 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3974 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3975 which are not supported by MSVC.
3976 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3977 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3979 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3981 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3983 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3985 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
3987 Support MSVC build with newer versions of Visual Studio.
3988 * w32.c: Don't include w32api.h for MSVC.
3989 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3991 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3992 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3993 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3994 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3996 (alloca) [_MSC_VER]: Define to _alloca.
3998 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4000 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4002 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4004 * xdisp.c (note_mouse_highlight): If either of
4005 previous/next-single-property-change returns nil, treat that as
4006 the beginning or the end of the buffer. (Bug#9955)
4008 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4010 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
4011 label is not null (Bug#9951).
4012 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4015 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4017 * window.c (Fwindow_body_size): Mention in the doc string that the
4018 return value is in frame's canonical units. (Bug#9949)
4020 2011-11-03 Eli Zaretskii <eliz@gnu.org>
4022 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4024 * w32fns.c (unwind_create_frame): If needed, free the glyph
4025 matrices of the partially constructed frame. (Bug#9943)
4026 * xfns.c (unwind_create_frame): Likewise.
4028 2011-11-01 Eli Zaretskii <eliz@gnu.org>
4030 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4031 Don't stop backward scan on the continuation glyph, even though
4032 its CHARPOS is positive.
4033 (mouse_face_from_buffer_pos, note_mouse_highlight):
4034 Rename cover_string to disp_string.
4036 2011-11-01 Martin Rudalics <rudalics@gmx.at>
4038 * window.c (temp_output_buffer_show): Don't use
4039 Vtemp_buffer_show_specifiers.
4040 (Vtemp_buffer_show_specifiers): Remove unused variable.
4042 2011-10-30 Eli Zaretskii <eliz@gnu.org>
4044 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4045 past the beginning of the current glyph matrix.
4047 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
4049 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4050 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4051 HAVE_GTK3 (Bug#9869).
4053 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4054 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4056 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4058 * xterm.c: Declare x_handle_net_wm_state to return int.
4059 (handle_one_xevent): Check if we are iconified but don't have
4060 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4061 (get_current_wm_state): Return non-zero if not hidden,
4062 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4063 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4064 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4065 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4067 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4069 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4070 so that this new function doesn't get optimized away by a
4071 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4073 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4075 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4077 2011-10-29 Eli Zaretskii <eliz@gnu.org>
4079 Fix the `xbytecode' command.
4080 * .gdbinit (xprintbytestr): New command.
4081 (xwhichsymbols): Rename from `which'; all callers changed.
4082 (xbytecode): Print the byte-code string as well.
4084 2011-10-29 Kim Storm <storm@cua.dk>
4086 * alloc.c (which_symbols): New function.
4088 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4090 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4093 2011-10-29 Glenn Morris <rgm@gnu.org>
4095 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4096 Not clear what it was for, and it causes various bugs. (Bug#9839)
4098 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4100 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4101 possible random value that matches one of those tested as
4102 condition to clear the mouse face.
4104 2011-10-28 Chong Yidong <cyd@gnu.org>
4106 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4108 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4110 * window.c (make_window): Initialize phys_cursor_on_p.
4112 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4114 * lisp.h (struct Lisp_Symbol): Update comments.
4116 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
4118 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4120 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4122 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4123 <oslsachem@gmail.com> for helping to debug this.
4125 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4126 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4127 (g_b_init_get_glyph_outline_w): New static variables.
4128 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4129 (GetGlyphOutlineW_Proc): New typedefs.
4130 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
4131 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4133 (w32font_open_internal, compute_metrics):
4134 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
4135 instead of calling the "wide" APIs directly.
4137 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4139 * w32.h (syms_of_w32font): Add prototype.
4141 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
4143 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4144 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4145 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4146 (Fmove_to_window_line): Doc fix.
4148 2011-10-27 Chong Yidong <cyd@gnu.org>
4150 * process.c (make_process): Set gnutls_state to NULL.
4152 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4153 non-NULL, regardless of GNUTLS_INITSTAGE.
4154 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4155 an error. Set process slots as soon as we allocate them.
4157 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4159 2011-10-27 Chong Yidong <cyd@gnu.org>
4161 * gnutls.c (emacs_gnutls_deinit): New function.
4162 Deallocate credentials structures as well as calling gnutls_deinit.
4163 (Fgnutls_deinit, Fgnutls_boot): Use it.
4165 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4166 (deactivate_process): Call emacs_gnutls_deinit.
4168 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
4170 * image.c (x_create_x_image_and_pixmap):
4171 * w32.c (sys_rename, w32_delayed_load):
4172 * w32font.c (fill_in_logfont):
4173 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4175 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
4177 * w32fns.c (w32_default_color_map): New function,
4178 extracted from Fw32_default_color_map.
4179 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
4181 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4183 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4185 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4187 * keyboard.c (test_undefined): New function (bug#9751).
4188 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4190 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4192 * sysdep.c (init_sys_modes): Fix the check for the controlling
4193 terminal (Bug#6649).
4195 2011-10-20 Eli Zaretskii <eliz@gnu.org>
4197 * dispextern.h (struct bidi_it): New member next_en_type.
4199 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4200 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4201 current character, check also for next_en_type being WEAK_EN.
4202 (bidi_resolve_weak): Don't enter the expensive loop if the current
4203 position is before next_en_pos. Record the bidi type of the first
4204 non-ET, non-BN character we find, in addition to its position.
4205 (bidi_level_of_next_char): Invalidate next_en_type when
4206 next_en_pos is over-stepped.
4208 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4210 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4211 * editfns.c: Rewrite current-time-zone so that it invokes
4212 the equivalent of (format-time-string "%Z") to get the time zone name.
4213 This fixes a bug when the time zone name contains characters that
4214 need converting from the system time locale to Emacs internal format.
4215 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4216 that patch fixed format-time-string to do the conversion, but
4217 I forgot to fix current-time-zone.
4218 (format_time_string): New function, containing most of
4219 what Fformat_time_string used to contain.
4220 (Fformat_time_string): Rewrite in terms of format_time_string.
4221 This doesn't change this function's behavior.
4222 (current-time-zone): Rewrite to use format_time_string.
4223 This fixes the bug reported by Michael Schierl in
4224 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4225 Jason Rumney's 2007-06-07 change worked around this bug, but
4227 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4229 2011-10-19 Eli Zaretskii <eliz@gnu.org>
4231 * xdisp.c (start_display): If the character at POS is displayed
4232 via a display vector, reset IT->current.dpvec_index to zero.
4233 (try_window_reusing_current_matrix): If a line ends in a display
4234 vector or the next line starts in a display vector, continue
4235 redrawing the window even though the character position of
4236 start_row was reached.
4239 2011-10-18 Chong Yidong <cyd@gnu.org>
4241 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4242 with nobreak-char-display too.
4244 2011-10-18 Eli Zaretskii <eliz@gnu.org>
4246 Fix part 3 of bug#9771.
4247 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4248 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4249 non-neutral characters if the current character is a paragraph
4250 separator (a.k.a. Newline). This avoids running the same
4251 expensive loop twice, once when we consume the preceding newline
4252 and the other time when the line actually needs to be displayed.
4253 Avoid the loop when we see neutrals on the base embedding level
4254 following a character whose directionality is the same as the
4255 paragraph's. This avoids running the expensive loop when a line
4256 ends in a long sequence of neutrals, like control characters.
4257 Add assertion against STRONG_AL type. Slightly rearrange code
4258 that determines the type of a neutral given the first non-neutral
4260 (bidi_level_of_next_char): Set next_en_pos to zero when
4261 invalidating its info.
4263 2011-10-17 Eli Zaretskii <eliz@gnu.org>
4265 * xdisp.c (push_display_prop): Determine whether to record string
4266 or buffer position by IT->string, not by IT->method. Allow
4267 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
4268 (move_it_vertically_backward): Don't look for character position
4269 immediately after the newline when in a continuation line.
4272 2011-10-15 Martin Rudalics <rudalics@gmx.at>
4274 * window.c (coordinates_in_window): Rewrite and delabelize
4275 vertical border check. (Bug#5357) (Bug#9618)
4277 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4279 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4280 errors in XSetWindowBorder (bug#9310).
4282 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4284 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4285 avoid crash when xmalloc overrun checking is enabled.
4287 2011-10-13 Eli Zaretskii <eliz@gnu.org>
4289 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4290 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4291 cursor motion with <left> and <right> arrow keys.
4293 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4294 some callers set that themselves.
4296 2011-10-12 Eli Zaretskii <eliz@gnu.org>
4298 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4299 display string and the previous row comes from the same string and
4300 is empty. (Bug#9739) (Bug#9738)
4302 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4304 * doc.c (get_doc_string): Encode file name (bug#9735).
4306 2011-10-12 Eli Zaretskii <eliz@gnu.org>
4308 * bidi.c (bidi_level_of_next_char):
4309 * xdisp.c (get_visually_first_element): Remove old incorrect
4310 comments regarding the Unicode Line Separator character.
4312 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4314 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4316 * alloc.c (Fgc_status): Do not access beyond zombies array
4317 boundary if nzombies > MAX_ZOMBIES.
4318 * alloc.c (dump_zombies): Add missing format specifier.
4320 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4322 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4323 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4325 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4326 Some packages use them to denote characters with modifiers.
4328 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4330 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4331 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4332 matching a pp-number. Rename parameter var to var1.
4334 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4336 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4338 2011-10-08 Glenn Morris <rgm@gnu.org>
4340 * callint.c (Fcall_interactively): Give a more explicit error for the
4341 'c' case with a non-character input. (Bug#8479)
4343 2011-10-08 Eli Zaretskii <eliz@gnu.org>
4345 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4347 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4348 lines that are hscrolled on the left.
4350 * dispnew.c (buffer_posn_from_coords): Account for a possible
4351 presence of header-line. (Bug#4426)
4353 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4355 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4356 Don't advertise functionality which we discourage or doesn't work.
4358 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4360 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4361 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4362 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4363 this makes Emacs dump core during garbage collection on rare
4364 occasions. sizeof is obviously inferior to offsetof here, so
4365 stick with offsetof.
4366 (GC_POINTER_ALIGNMENT): New macro.
4367 (mark_memory): Omit 3rd (offset) arg; caller changed.
4368 Don't assume EMACS_INT alignment is the same as pointer alignment.
4370 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4372 * keyboard.c (read_key_sequence_remapped): New var.
4373 (read_key_sequence): Compute remapping in the right buffer.
4374 (command_loop_1): Use read_key_sequence's remapping directly.
4376 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4378 * dired.c (file_name_completion): Don't expand file name.
4379 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4380 before checking file name handler.
4382 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4383 they've been requested explicitly (bug#9591).
4385 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
4387 * keymap.c (Fsingle_key_description): Use make_specified_string
4388 instead of build_string to build string from push_key_description.
4391 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4393 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4394 This fixes a Y2038 bug on 64-bit hosts.
4395 * buffer.c (reset_buffer):
4396 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4397 (Fclear_buffer_auto_save_failure):
4398 Use 0, not -1, to represent an unset failure time, since time_t
4399 might not be signed.
4401 Remove dependency on glibc malloc internals.
4402 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4403 Move back here from lisp.h, but with their new implementations.
4404 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4405 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4406 * charset.c (charset_table_init): New static var.
4407 (syms_of_charset): Use it instead of xmalloc. This removes a
4408 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4409 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4410 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4411 Move back to alloc.c.
4412 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4413 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4415 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4417 * nsterm.m (windowDidResize): Call x_set_window_size only when
4418 ns_in_resize is true. Otherwise set pixelwidth/height and
4419 call change_frame_size (Bug#9628).
4421 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4423 Port --enable-checking=all to Fedora 14 x86-64.
4424 * charset.c (syms_of_charset): Also account for glibc malloc's
4425 internal overhead when calculating the initial malloc maximum.
4427 Port --enable-checking=all to Fedora 14 x86.
4428 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4430 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4431 (overrun_check_realloc, overrun_check_free):
4432 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4433 That way, xmalloc returns a properly-aligned pointer even if
4434 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4435 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4436 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4437 into account when calculating the initial malloc maximum.
4438 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4439 Move here from alloc.c, so that charset.c can use it too.
4440 Properly align; the old code wasn't right for common 32-bit hosts
4441 when configured with --enable-checking=all.
4442 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4443 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4445 2011-09-29 Eli Zaretskii <eliz@gnu.org>
4447 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
4450 2011-09-28 Eli Zaretskii <eliz@gnu.org>
4452 * xdisp.c (compute_display_string_end): If there's no display
4453 string at CHARPOS, return -1.
4455 * bidi.c (bidi_fetch_char): When compute_display_string_end
4456 returns a negative value, treat the character as a normal
4457 character not covered by a display string. (Bug#9624)
4459 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
4461 * lread.c (Fread_from_string): Fix typo in docstring.
4463 2011-09-27 Eli Zaretskii <eliz@gnu.org>
4465 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4466 newline, reseat the iterator instead of bidi-iterating there one
4467 character at a time. (Bug#9610)
4468 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4469 TO_CHARPOS if the bidi iterator is at base embedding level.
4471 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4473 * lread.c (readevalloop): Use correct code for NBSP.
4474 (read1): Likewise. (Bug#9608)
4476 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
4478 * dbusbind.c (Fdbus_register_signal): When service is not
4479 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4481 2011-09-25 Glenn Morris <rgm@gnu.org>
4483 * buffer.c (truncate-lines): Doc fix.
4485 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
4487 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4488 (Fset_window_next_buffers): Doc fix.
4490 2011-09-24 Glenn Morris <rgm@gnu.org>
4492 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4494 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4496 Fix minor problems found by static checking.
4497 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
4498 * indent.c (Fvertical_motion): Fix == vs = typo.
4500 2011-09-24 Eli Zaretskii <eliz@gnu.org>
4502 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4503 Default value is now t. Doc fix.
4505 * indent.c (Fvertical_motion): Compute and apply the overshoot
4506 logic when moving up, not only when moving down. Fix the
4507 confusing name and values of the it_overshoot_expected variable;
4508 logic changes accordingly. (Bug#9254) (Bug#9549)
4510 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4511 CHARPOS is covered by a display string which includes newlines.
4512 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4513 is covered by a display string with embedded newlines.
4515 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
4517 * dbusbind.c (Fdbus_register_signal): Add match rule to
4518 Vdbus_registered_objects_table. (Bug#9581)
4519 (Fdbus_register_method, Vdbus_registered_objects_table):
4522 2011-09-24 Jim Meyering <meyering@redhat.com>
4524 do not ignore write error for any output size
4525 The previous change was incomplete.
4526 While it makes emacs --batch detect the vast majority of stdout
4527 write failures, errors were still ignored whenever the output size is
4528 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4529 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4530 && echo FAIL: ignored write error
4531 FAIL: ignored write error
4532 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4533 && echo FAIL: ignored write error
4534 FAIL: ignored write error
4535 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4537 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4539 * emacs.c (Fkill_emacs): In noninteractive mode exit
4540 non-successfully if a write error occurred on stdout. (Bug#9574)
4542 2011-09-21 Eli Zaretskii <eliz@gnu.org>
4544 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4547 * dispextern.h (struct it): Update the comment documenting what
4550 2011-09-20 Eli Zaretskii <eliz@gnu.org>
4552 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4553 a display string, extend search for cursor position to end of row.
4554 (find_row_edges): If the row ends in a newline from a display
4555 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4556 Handle the case of a display string with multiple newlines.
4557 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4558 non-empty line. Fixes confusing cursor motion with arrow keys at
4559 the beginning of a line that starts with whitespace.
4561 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4563 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4566 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
4568 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4571 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4573 * xdisp.c (display_line): Record maximum and minimum buffer
4574 positions even if no glyphs were produced (e.g., by a zero-width
4575 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4576 buffer positions that will be removed from the glyph row because
4578 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4579 column is beyond frame width: don't subtract 1 "pixel" when
4580 computing width of the stretch.
4581 (reseat_at_next_visible_line_start): Undo the change made on
4582 2011-09-17 that saved paragraph information and restored it after
4583 the call to `reseat'. (Bug#9545)
4585 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4587 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4588 and turn window cursor on if cleared (Bug#9415).
4590 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
4592 * search.c (boyer_moore): Take unibyte characters from pattern
4593 literally. (Bug#9458)
4595 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4597 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4599 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4601 Fix minor problem found by static checking.
4602 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4603 initialized, to pacify gcc -Wuninitialized.
4605 * fileio.c: Report proper errno when syscall falls.
4606 (Finsert_file_contents): Save and restore errno,
4607 so that report_file_error outputs the correct diagnostic.
4608 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4610 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4612 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4614 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4616 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4617 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4619 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4621 * xdisp.c (reseat_at_next_visible_line_start): Keep information
4622 about the current paragraph and restore it after the call to reseat.
4624 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4625 (bidi_find_paragraph_start): Search back for paragraph beginning
4626 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4627 (bidi_move_to_visually_next): Only trigger paragraph-related
4628 computations when the last character is a newline or at EOB, not
4629 just any NEUTRAL_B. (Bug#9470)
4631 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4632 truncated lines if point is covered by a display string. (Bug#9524)
4634 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4636 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4637 (cons_to_x_long): New function.
4638 (lisp_data_to_selection_data): Use it. Correct the test for
4639 short-versus-long data; it was negated. Break out of vector
4640 loop, for efficiency, when a long datum is discovered.
4642 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4644 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4646 2011-09-16 Eli Zaretskii <eliz@gnu.org>
4648 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4649 GCC PR/17406) by declaring this function with external scope.
4651 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4653 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4654 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4656 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4658 * editfns.c (Fformat): Correctly handle text properties on "%%".
4660 2011-09-15 Eli Zaretskii <eliz@gnu.org>
4662 * xterm.c (x_draw_composite_glyph_string_foreground):
4663 * w32term.c (x_draw_composite_glyph_string_foreground):
4664 * term.c (encode_terminal_code):
4665 * composite.c (composition_update_it, get_composition_id):
4666 * xdisp.c (get_next_display_element)
4667 (fill_composite_glyph_string): Add comments about special meaning
4668 of TAB characters in a composition.
4670 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4672 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4673 This occurs when processing a multibyte format.
4674 Problem reported by Wolfgang Jenker.
4676 2011-09-15 Johan Bockgård <bojohan@gnu.org>
4678 * xdisp.c (try_cursor_movement): Only check for exact match if
4679 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4681 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4683 Remove unused external symbols.
4684 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4685 * xdisp.c (calc_pixel_width_or_height): Now static.
4686 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4687 * indent.c (check_display_width):
4688 * w32term.c: Fix comment to match code.
4689 * xterm.c, xterm.h (x_catching_errors): Remove.
4691 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4693 * xselect.c: Use signed conversions more consistently (Bug#9498).
4694 (selection_data_to_lisp_data): Assume incoming selection data are
4695 signed integers, not unsigned. This is to be consistent with
4696 outgoing selection data, which was modified to use signed integers
4697 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4698 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4699 expects long, not unsigned long.
4701 2011-09-14 Eli Zaretskii <eliz@gnu.org>
4703 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4704 computation of loop end. Reported by Johan Bockgård
4707 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
4709 * frame.c (Fother_visible_frames_p): Function deleted.
4711 2011-09-12 Eli Zaretskii <eliz@gnu.org>
4713 * indent.c (compute_motion): Process display vector front to back
4714 rather than the other way around. (Bug#2496)
4716 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4718 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4720 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
4722 * minibuf.c (Fread_from_minibuffer): Doc fix.
4724 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4726 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4727 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4729 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4731 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4732 value for non-existent files.
4734 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4736 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4737 set its "size" to -1. This will set the modtime_size field of
4738 the corresponding buffer to -1, which is what
4739 verify-visited-file-modtime expects for files that do not exist.
4742 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4744 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4746 * lisp.h: ... from here. push_key_description is no longer
4747 defined in keyboard.c, so its declaration should not be in
4748 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4749 logically belongs with push_key_description.
4751 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4753 * buffer.h: Include <sys/types.h> instead of <time.h>.
4754 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4755 Problem reported by Herbert J. Skuhra.
4757 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4759 * xml.c (parse_region): Make the parsing work for
4760 non-comment-starting XML files again (bug#9144).
4762 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4764 * image.c (gif_load): Fix calculation of bottom and right corner.
4767 2011-09-10 Eli Zaretskii <eliz@gnu.org>
4769 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4770 redisplay in small windows.
4772 2011-09-09 Eli Zaretskii <eliz@gnu.org>
4774 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4776 2011-09-08 Martin Rudalics <rudalics@gmx.at>
4778 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4779 Operate on live windows only.
4781 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
4783 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4785 2011-09-07 Eli Zaretskii <eliz@gnu.org>
4787 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4788 only under bidi iteration.
4790 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4792 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4794 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4796 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4797 Without this fix, the command to link temacs failed due to an
4798 undefined symbol __builtin_isnan. This is because
4799 /usr/include/iso/math_c99.h #defines isnan(x) to
4800 __builtin_isnan(x), but the bundled gcc, which identifies itself
4801 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4803 * floatfns.c (isnan): #undef, and then #define to a clone of
4805 (Fisnan): Always define, since it's always available now.
4806 (syms_of_floatfns): Always define isnan at the Lisp level.
4808 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4810 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4812 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4814 * fileio.c: Fix bugs with large file offsets (Bug#9428).
4815 The previous code assumed that file offsets (off_t values) fit in
4816 EMACS_INT variables, which is not true on typical 32-bit hosts.
4817 The code messed up by falsely reporting buffer overflow in cases
4818 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4819 when "big" contains more than 2**29 bytes, even though this
4820 inserts just one byte and does not overflow the buffer.
4821 (Finsert_file_contents): Store file offsets as off_t
4822 values, not as EMACS_INT values. Check for overflow when
4823 converting between EMACS_INT and off_t. When checking for
4824 buffer overflow or for overlap, take the offsets into account.
4825 Don't use EMACS_INT for small values where int suffices.
4826 When checking for overlap, fix a typo: ZV was used where
4827 ZV_BYTE was intended.
4828 (Fwrite_region): Don't assume off_t fits into 'long'.
4829 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4831 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
4833 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4835 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4837 sprintf-related integer and memory overflow issues (Bug#9412).
4839 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
4840 (esprintf, exprintf, evxprintf): New functions.
4841 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
4842 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
4843 (modify_event_symbol): Do not assume that the length of
4844 name_alist_or_stem is safe to alloca and fits in int.
4845 (Fexecute_extended_command): Likewise for function name and binding.
4846 (Frecursion_depth): Wrap around reliably on integer overflow.
4847 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4848 since some callers pass EMACS_INT values.
4849 (Fsingle_key_description): Don't crash if symbol name contains more
4850 than MAX_ALLOCA bytes.
4851 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4852 (get_minibuffer): Arg is now EMACS_INT, not int.
4853 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
4854 (esprintf, exprintf, evxprintf): New decls.
4855 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4857 * dbusbind.c (signature_cat): New function.
4858 (xd_signature, Fdbus_register_signal):
4859 Do not overrun buffer; instead, report string overflow.
4861 * dispnew.c (add_window_display_history): Don't overrun buffer.
4862 Truncate instead; this is OK since it's just a log.
4864 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4865 even if the time zone offset is outlandishly large.
4866 Don't mishandle offset == INT_MIN.
4868 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4869 when creating daemon; the previous buffer-overflow check was incorrect.
4871 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4872 which has the guts of the old verror function.
4874 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4875 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4877 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4878 (font_unparse_xlfd): Don't blindly alloca long strings.
4879 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
4880 fits in int, when using sprintf. Use single snprintf to count
4881 length of string rather than counting it via multiple sprintfs;
4882 that's simpler and more reliable.
4883 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4884 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4885 sprintf, in case result does not fit in int.
4887 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4888 (fontset_from_font): Print it.
4890 * frame.c (tty_frame_count): Now printmax_t, not int.
4891 (make_terminal_frame, set_term_frame_name): Print it.
4892 (x_report_frame_params): In X, window IDs are unsigned long,
4893 not signed long, so print them as unsigned.
4894 (validate_x_resource_name): Check for implausibly long names,
4895 and don't assume name length fits in 'int'.
4896 (x_get_resource_string): Don't blindly alloca invocation name;
4897 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4900 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4901 (xg_check_special_colors, xg_set_geometry):
4902 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4904 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4905 Use esprintf, not sprintf, in case result does not fit in int.
4907 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4908 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4909 it as a large positive number.
4910 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4911 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4913 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4914 in case result does not fit in int.
4916 * print.c (float_to_string): Detect width overflow more reliably.
4917 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4918 buffer overrun. Don't assume list length fits in 'int'. Treat
4919 print length of 0 as 0, not as infinity; to be consistent with other
4920 uses of print length in this function. Don't overflow print length
4921 index. Don't assume hash table size fits in 'long', or that
4922 vectorlike size fits in 'unsigned long'.
4924 * process.c (make_process): Use printmax_t, not int, to format
4925 process-name gensyms.
4927 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4929 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4930 to avoid potential buffer overrun.
4932 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4933 if X resource line is longer than 512 bytes.
4935 * xfns.c (x_window): Make sprintf buffer a bit bigger
4936 to avoid potential buffer overrun.
4938 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4940 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4942 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4944 Integer overflow fixes for scrolling, etc.
4945 Without these, Emacs silently mishandles large integers sometimes.
4946 For example, "C-u 4294967297 M-x recenter" was treated as if
4947 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4949 * xdisp.c (try_window_id): Check Emacs fixnum range before
4950 converting to 'int'.
4952 * window.c (window_scroll_line_based, Frecenter):
4953 Check that an Emacs fixnum is in range before assigning it to 'int'.
4954 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4955 values converted from Emacs fixnums.
4956 (Frecenter): Don't wrap around a line count if it is out of 'int'
4957 range; instead, treat it as an extreme value.
4958 (Fset_window_configuration, compare_window_configurations):
4959 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4961 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4962 that can exceed INT_MAX. Check that EMACS_INT value is in range
4963 before assigning it to the (possibly-narrower) index.
4964 (match_limit): Don't assume that a fixnum can fit in 'int'.
4966 * print.c (print_object): Use ptrdiff_t, not int, for index that can
4969 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
4970 (Fvertical_motion): Don't wrap around LINES values that don't fit
4971 in 'int'. Instead, treat them as extreme values. This is good
4972 enough for windows, which can't have more than INT_MAX lines anyway.
4974 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4976 * Require libxml/parser.h to avoid compilation warning.
4978 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4980 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4981 since this reportedly can destroy thread storage.
4983 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
4985 * syntax.c (find_defun_start): Update all cache variables if
4986 exiting early (Bug#9401).
4988 2011-08-30 Eli Zaretskii <eliz@gnu.org>
4990 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4992 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4993 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4994 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4996 * term.c (tty_append_glyph): New function.
4997 (produce_stretch_glyph): Static function and its prototype deleted.
4999 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5002 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5004 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5005 when checking :margin (Bug#9390).
5006 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
5007 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
5008 so that the name doesn't mislead. All uses changed.
5010 2011-08-28 Johan Bockgård <bojohan@gnu.org>
5012 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5015 2011-08-27 Eli Zaretskii <eliz@gnu.org>
5017 * xdisp.c (move_it_to): Don't bail out early when reaching
5018 position beyond to_charpos, if we are scanning backwards.
5019 (move_it_vertically_backward): When DY == 0, make sure we get to
5020 the first character in the line after the newline.
5022 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5024 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5025 (ccl_driver): Do not generate an out-of-range pointer.
5026 (Fccl_execute_on_string): Remove unnecessary check for
5027 integer overflow, noted by Stefan Monnier in
5028 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5029 Remove a FIXME that didn't need fixing.
5030 Simplify the newly-introduced buffer reallocation code.
5032 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
5034 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5036 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
5038 Integer and memory overflow issues (Bug#9196).
5040 * doc.c (get_doc_string): Rework so that
5041 get_doc_string_buffer_size is the actual buffer size, rather than
5042 being 1 less than the actual buffer size; this makes xpalloc more
5045 * image.c (x_allocate_bitmap_record, cache_image):
5046 * xselect.c (Fx_register_dnd_atom):
5047 Simplify previous changes by using xpalloc.
5049 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5050 since either will do and ptrdiff_t is convenient with xpalloc.
5052 * charset.c (charset_table_size)
5053 (struct charset_sort_data.priority): Now ptrdiff_t.
5054 (charset_compare): Don't overflow if priorities differ greatly.
5055 (Fsort_charsets): Don't assume list length fits in int.
5056 Check for size-calculation overflow when allocating sort data.
5057 (syms_of_charset): Allocate an initial charset table that is
5058 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5060 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5062 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5063 The actual value is always <= INT_MAX, and leaving it unsigned made
5064 overflow checking harder.
5066 * dispextern.h (struct glyph_matrix.rows_allocated)
5067 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5068 with xpalloc. The values are still always <= INT_MAX.
5070 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5072 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5073 (SAFE_NALLOCA): New macro.
5075 * region-cache.c (struct boundary.pos, find_cache_boundary)
5076 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5077 (set_cache_region, invalidate_region_cache)
5078 (revalidate_region_cache, know_region_cache, region_cache_forward)
5079 (region_cache_backward, pp_cache):
5080 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5081 so that ptrdiff_t * can be passed to xpalloc.
5082 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5083 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5084 (pp_cache): Don't assume cache_len fits in int.
5085 * region-cache.h: Adjust extern decls to match.
5087 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5088 EMACS_INT, since either will do, for xpalloc.
5090 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5091 (xnmalloc, xnrealloc, xpalloc): New functions.
5093 * bidi.c (bidi_shelve_header_size): New constant.
5094 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5095 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5097 * bidi.c (bidi_cache_shrink):
5098 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5100 Don't update size of array until after memory allocation succeeds,
5101 because xmalloc/xrealloc may not return.
5102 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5103 now that we have proper integer overflow checking.
5104 (record_overlay_string, overlay_strings): Catch overflows when
5105 calculating size of overlay_str_buf.
5107 * callproc.c (Fcall_process): Check for size overflow when
5108 calculating size of args2.
5109 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5110 Normally we prefer signed values, but sticking with ptrdiff_t would
5111 require adding more-complicated checks.
5113 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5114 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5115 Redo buffer-overflow calculations to avoid integer overflow.
5116 Add a FIXME comment where memory seems to be over-allocated.
5118 * character.c (Fstring): Check for size-calculation overflow.
5120 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5121 unnecessary integer overflow. Check for size overflow.
5122 (encode_coding_object): Don't update size until xmalloc succeeds.
5124 * composite.c (get_composition_id): Check for overflow in glyph
5125 length calculations.
5127 Integer and memory overflow fixes for display code.
5128 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5129 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5130 (scrolling_window): Check for overflow in size calculations.
5131 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5132 Don't assume glyph table len fits in int.
5133 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5134 (row_table_size): Now ptrdiff_t, not int.
5135 (scrolling_window): Avoid overflow in size calculations.
5136 Don't update size until allocation succeeds.
5137 * fns.c (concat): Check for overflow in size calculations.
5138 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5139 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5140 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5142 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5143 (get_doc_string): Check for size calculation overflow.
5144 Don't update size until allocation succeeds.
5145 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5146 EMACS_INT, where ptrdiff_t will do.
5147 (Fsubstitute_command_keys): Check for string overflow.
5149 * editfns.c (set_time_zone_rule): Don't assume environment length
5151 (message_length): Now ptrdiff_t, not int.
5152 (Fmessage_box): Don't update size until allocation succeeds.
5153 Don't assume message length fits in int.
5154 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5156 * emacs.c (main): Do not reallocate argv, since there is a null at
5157 the end that can be overwritten, and this way there's no need to
5158 worry about size-calculation overflow.
5159 (sort_args): Check for size-calculation overflow.
5161 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5163 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5165 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5166 (x_set_scroll_bar_width, x_figure_window_size):
5167 Check for integer overflow.
5168 (x_set_alpha): Do not assume XINT fits in int.
5170 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5171 This is for the members text_lines, text_cols, total_lines, total_cols,
5172 where the system imposes an 'int' limit.
5174 * fringe.c (Fdefine_fringe_bitmap):
5175 Don't update size until alloc works.
5177 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5178 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5180 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5181 Check for size-calculation overflow.
5182 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5183 do, as we prefer signed integers.
5184 (id_to_widget.max_size, id_to_widget.used)
5185 (xg_store_widget_in_map, xg_remove_widget_from_map)
5186 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5187 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5188 Use and return ptrdiff_t, not int.
5189 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5190 * gtkutil.h: Change prototypes to match the above.
5192 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5193 are duplicate now that they've been promoted to lisp.h.
5194 (x_allocate_bitmap_record, x_alloc_image_color)
5195 (make_image_cache, cache_image, xpm_load):
5196 Don't update size until alloc is done.
5197 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5199 Check for size calculation overflow.
5200 (ct_colors_allocated_max): New constant.
5201 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5204 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5205 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5206 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5207 Use ptrdiff_t, not int, to count maps.
5208 (read_char_minibuf_menu_prompt): Check for overflow in size
5209 calculations. Don't update size until allocation succeeds.
5210 Redo calculations to avoid overflow.
5211 * keyboard.h: Change prototypes to match the above.
5213 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5215 (current_minor_maps): Check for size calculation overflow.
5216 * keymap.h: Change prototypes to match the above.
5218 * lread.c (read1, init_obarray): Don't update size until alloc done.
5220 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5221 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5223 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5224 Now ptrdiff_t, not int.
5225 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5226 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5228 * process.c (Fnetwork_interface_list): Check for overflow
5229 in size calculation.
5231 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5233 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5234 overflow. Don't bother calling xmalloc when xrealloc will do.
5236 * search.c (Freplace_match): Check for size calculation overflow.
5237 (Fset_match_data): Don't assume list lengths fit in 'int'.
5239 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5240 for command line length. Do not attempt to address one before the
5241 beginning of an array, as that's not portable.
5243 * term.c (max_frame_lines): Remove; unused.
5244 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5246 (encode_terminal_code, calculate_costs): Check for size
5247 calculation overflow.
5248 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5249 table lengths and related sizes. Don't update size until alloc
5250 done. Redo calculations to avoid overflow.
5251 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5253 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5254 subtracting pointers.
5255 (gobble_line): Check for overflow more carefully. Don't update size
5258 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5259 Don't update size until alloc done.
5260 Redo size calculations to avoid overflow.
5261 Check for size calculation overflow.
5262 (main) [DEBUG]: Fix typo in invoking tparam1.
5264 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5265 Use ptrdiff_t, not int, for sizes.
5266 (store_mode_line_noprop_char): Don't update size until alloc done.
5268 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5269 Use ptrdiff_t, not int, for sizes.
5270 (Finternal_make_lisp_face, cache_face):
5271 Check for size calculation overflow.
5272 (cache_face): Treat size calculation overflows as if they were
5273 memory exhaustion (the usual treatment), rather than aborting.
5275 * xfns.c (x_encode_text, x_set_name_internal)
5276 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5277 sizes, since they can exceed INT_MAX in size. Check for size
5278 calculation overflow.
5280 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5281 (xg_select): Check for size calculation overflow.
5282 Don't update size until alloc done.
5284 * xrdb.c (get_environ_db): Don't assume path length fits in int,
5285 as sprintf is limited to int lengths.
5287 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5288 (X_LONG_MIN): New macros.
5289 Use them to make the following changes clearer.
5290 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5291 This change doesn't affect the value now, but it may help remind
5292 future maintainers not to raise the value too much later.
5293 (SELECTION_QUANTUM): Remove, replacing with ...
5294 (selection_quantum): ... new function, which avoids overflow.
5296 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5297 assumption that selection length fits in 'int'.
5298 (x_reply_selection_request, x_handle_selection_request)
5299 (x_get_window_property, receive_incremental_selection)
5300 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5301 (lisp_data_to_selection_data, clean_local_selection_data):
5302 Use ptrdiff_t, not int, to record length of selection.
5303 (x_reply_selection_request, x_get_window_property)
5304 (receive_incremental_selection, x_property_data_to_lisp):
5305 Redo calculations to avoid overflow.
5306 (x_reply_selection_request): When sending hint, ceiling it at
5307 X_LONG_MAX rather than relying on wraparound overflow to send
5309 (x_get_window_property, receive_incremental_selection)
5310 (lisp_data_to_selection_data, x_property_data_to_lisp):
5311 Check for size-calculation overflow.
5312 (x_get_window_property, receive_incremental_selection)
5313 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5314 Don't store size until memory allocation succeeds.
5315 (x_get_window_property): Plug memory leak on memory exhaustion.
5316 Don't double-block input; malloc is safe here. Don't assume 2**34
5317 - 4 fits in unsigned long. Add an xassert to check
5318 XGetWindowProperty overflow. Be more careful about overflow
5319 calculations, and distinguish size from memory overflow better.
5320 (receive_incremental_selection): When tracing, don't assume
5321 unsigned int is less than INT_MAX.
5322 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5323 harmful) conversions of unsigned short to int.
5324 (lisp_data_to_selection_data): Don't assume that integers
5325 in the range -65535 through -1 fit in an X unsigned short.
5326 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5327 result parameters unless successful. Rely on cons_to_unsigned
5328 to report problems with elements; the old code wasn't right anyway.
5329 (x_check_property_data): Check for int overflow; we cannot use
5330 a wider type due to X limits.
5331 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5333 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
5335 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5336 (x_term_init): Check for size calculation overflow.
5337 (x_color_cells): Don't store size until memory allocation succeeds.
5338 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
5339 Don't assume alloca size is less than MAX_ALLOCA.
5340 (x_term_init): Don't assume length fits in int (sprintf is limited
5343 Use ptrdiff_t for composition IDs.
5344 * character.c (lisp_string_width):
5345 * composite.c (composition_table_size, n_compositions)
5346 (get_composition_id, composition_gstring_from_id):
5347 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5348 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5349 * window.c (Frecenter):
5350 Use ptrdiff_t, not int, for composition IDs.
5351 * composite.c (get_composition_id): Check for integer overflow.
5352 * composite.h: Adjust prototypes to match the above changes.
5354 Use ptrdiff_t for hash table indexes.
5355 * category.c (hash_get_category_set):
5356 * ccl.c (ccl_driver):
5357 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5358 * coding.c (coding_system_charset_list, detect_coding_system):
5359 * coding.h (struct coding_system.id):
5360 * composite.c (get_composition_id, gstring_lookup_cache):
5361 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5362 * image.c (xpm_get_color_table_h):
5363 * lisp.h (hash_lookup, hash_put):
5364 * minibuf.c (Ftest_completion):
5365 Use ptrdiff_t for hash table indexes, not int (which is too
5366 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5367 32-bit --with-wide-int hosts).
5369 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5370 Add a FIXME comment about memory leaks.
5371 (syms_of_charset): Don't assume xmalloc returns.
5373 Don't assume that stated character widths fit in int.
5374 * character.c (Fchar_width, c_string_width, lisp_string_width):
5375 * character.h (CHAR_WIDTH):
5376 * indent.c (MULTIBYTE_BYTES_WIDTH):
5377 Use sanitize_char_width to avoid undefined and/or bad behavior
5378 with outlandish widths.
5379 * character.h (sanitize_tab_width): Rename from sanitize_width,
5380 now that we have two such functions. All uses changed.
5381 (sanitize_char_width): New inline function.
5383 Don't assume that tab-width fits in int.
5384 * character.h (sanitize_width): New inline function.
5385 (SANE_TAB_WIDTH): New macro.
5386 (ASCII_CHAR_WIDTH): Use it.
5387 * indent.c (sane_tab_width): Remove. All uses replaced by
5388 SANE_TAB_WIDTH (current_buffer).
5389 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5391 * fileio.c: Integer overflow issues with file modes.
5392 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5394 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5395 Remove unreachable code.
5396 (read_hex, load_charset_map_from_file): Check for integer overflow.
5398 * xterm.c: Don't go over XClientMessageEvent limit.
5399 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5400 (x_send_scroll_bar_event): Likewise. Check that the size does not
5401 exceed limits imposed by XClientMessageEvent, as well as the usual
5402 ptrdiff_t and size_t limits.
5404 * keyboard.c: Overflow, signedness and related fixes.
5405 (make_lispy_movement): Use same integer type in forward decl
5406 that is used in the definition.
5407 (read_key_sequence, keyremap_step):
5408 Change bufsize argument back to int, undoing my 2011-03-30 change.
5409 We prefer signed types, and int is wide enough here.
5410 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5411 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5412 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5413 length, not size_t. Use ptrdiff_t for index, not int.
5414 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5415 possibility of integer overflow.
5417 Overflow, signedness and related fixes for images.
5419 * dispextern.h (struct it.stack[0].u.image.image_id)
5420 (struct_it.image_id, struct image.id, struct image_cache.size)
5421 (struct image_cache.used, struct image_cache.ref_count):
5422 * gtkutil.c (update_frame_tool_bar):
5423 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5424 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5425 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5426 * nsmenu.m (update_frame_tool_bar):
5427 * xdisp.c (calc_pixel_width_or_height):
5428 * xfns.c (image_cache_refcount):
5429 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5430 on typical 64-bit hosts.
5432 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5433 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5434 Omit unnecessary casts to int.
5435 (parse_image_spec): Check that integers fall into 'int' range
5436 when the callers expect that.
5437 (image_ascent): Redo ascent calculation to avoid int overflow.
5438 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5439 (lookup_image): Remove unnecessary tests.
5440 (xbm_image_p): Locals are now of int, not EMACS_INT,
5441 since parse_image_check makes sure they fit into int.
5442 (png_load, gif_load, svg_load_image):
5443 Prefer int to unsigned where either will do.
5444 (tiff_handler): New function, combining the cores of the
5445 old tiff_error_handler and tiff_warning_handler.
5446 This function is rewritten to use vsnprintf and thereby avoid
5447 stack buffer overflows. It uses only the features of vsnprintf
5448 that are common to both POSIX and native Microsoft.
5449 (tiff_error_handler, tiff_warning_handler): Use it.
5450 (tiff_load, gif_load, imagemagick_load_image):
5451 Don't assume :index value fits in 'int'.
5452 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5453 (imagemagick_load_image): Check that crop parameters fit into
5454 the integer types that MagickCropImage accepts. Don't assume
5455 Vimagemagick_render_type has a nonnegative value. Don't assume
5456 size_t fits in 'long'.
5457 (gs_load): Use printmax_t to print the widest integers possible.
5458 Check for integer overflow when computing image height and width.
5460 2011-08-26 Eli Zaretskii <eliz@gnu.org>
5462 * xdisp.c (redisplay_window): Don't force window start if point
5463 will be invisible in the resulting window. (Bug#9324)
5465 2011-08-25 Eli Zaretskii <eliz@gnu.org>
5467 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5468 the display spec is of the form `(space ...)'.
5469 (handle_display_spec): Return the value returned by
5470 handle_single_display_spec, not just 1 or zero.
5471 (handle_single_display_spec): If the display spec is of the form
5472 `(space ...)', and specifies display in the text area, return 2
5474 (try_cursor_movement): Check for the need to scroll more
5475 accurately, and prefer exact match for point under bidi.
5476 Don't advance `row' beyond the last row of the window.
5478 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5479 into disp_prop; all users changed.
5481 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5482 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5483 for the text covered by the display property.
5485 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
5487 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5488 Change return value to nil.
5489 (Frecord_buffer): Delete unused function.
5491 2011-08-24 Eli Zaretskii <eliz@gnu.org>
5493 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5494 buffers, return left-to-right.
5495 (set_cursor_from_row): Consider candidate row a win if its glyph
5496 represents a newline and point is on that newline. Fixes cursor
5497 positioning on the newline at EOL of R2L text within L2R
5498 paragraph, and vice versa.
5499 (try_cursor_movement): Check continued rows, in addition to
5500 continuation rows. Fixes unwarranted scroll when point enters a
5501 continued line of R2L text within an L2R paragraph, or vice versa.
5502 (cursor_row_p): Consider the case of point being equal to
5503 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5504 from the end of a short line to the beginning of a continued line
5505 of R2L text within L2R paragraph.
5506 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5507 composed characters.
5509 * bidi.c (bidi_check_type): Use xassert.
5510 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5513 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5515 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5518 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
5520 * nsfont.m (ns_otf_to_script): Fix typo.
5522 2011-08-22 Kenichi Handa <handa@m17n.org>
5524 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5525 extra slot even if the purpose is char-code-property-table.
5527 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5529 * xdisp.c (redisplay_window): When computing centering_position,
5530 account for the height of the header line. (Bug#8874)
5532 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5533 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5534 candidate is selected by the mouse, and that candidate has a
5535 composed character under the mouse.
5537 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5538 coordinates reported by pos-visible-in-window-p for a composed
5539 character in column zero.
5541 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5543 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5545 2011-08-22 Eli Zaretskii <eliz@gnu.org>
5547 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5548 consider it a hit if to_charpos is anywhere in the range of the
5549 composed buffer positions.
5551 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
5553 * image.c (gif_load): Don't assume that each subimage has the same
5554 dimensions as the base image. Handle disposal method that is
5555 "undefined" by the gif spec (Bug#9335).
5557 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
5559 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
5560 (Fcondition_case): Document `debug' symbol in error handler.
5562 2011-08-19 Eli Zaretskii <eliz@gnu.org>
5564 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5565 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5566 from an Org mode buffer to a Speedbar frame.
5568 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5569 a composition, take its buffer position from IT->cmp_it.charpos.
5570 Fixes cursor positioning at the beginning of a line that begins
5571 with a composed character.
5573 2011-08-18 Eli Zaretskii <eliz@gnu.org>
5575 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5576 character bidirectional type, use STRONG_L instead. Fixes crashes
5577 in a buffer produced by `describe-categories'.
5579 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5580 members before the level stack, so they would be saved and
5581 restored when copying iterator state. Fixes incorrect reordering
5582 around TABs covered by display properties.
5584 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5586 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
5588 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
5590 * eval.c (internal_condition_case, internal_condition_case_1)
5591 (internal_condition_case_2, internal_condition_case_n):
5592 Remove unnecessary aborts (Bug#9081).
5594 2011-08-17 Eli Zaretskii <eliz@gnu.org>
5596 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5597 has no `load' handler, try opening the file locally. (Bug#9311)
5599 2011-08-16 Ken Brown <kbrown@cornell.edu>
5601 * gmalloc.c: Expand comment.
5603 2011-08-16 Eli Zaretskii <eliz@gnu.org>
5605 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5606 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5608 2011-08-16 Ken Brown <kbrown@cornell.edu>
5610 Fix memory allocation problems in Cygwin build (Bug#9273).
5612 * unexcw.c ( __malloc_initialized): Declare external variable.
5613 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5615 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5617 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5619 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5621 [CYGWIN] (special_realloc): New function.
5622 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5623 requests to realloc storage in the static heap.
5625 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5627 * bidi.c (bidi_initialize): Remove unused local.
5629 2011-08-15 Eli Zaretskii <eliz@gnu.org>
5632 * biditype.h: Remove file.
5633 * makefile.w32-in ($(BLD)/bidi.$(O)):
5634 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
5636 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5638 * chartab.c: Improve commentary for the uniprop_table API.
5640 * bidi.c (bidi_paragraph_init): Support zero value of
5641 bidi_ignore_explicit_marks_for_paragraph_level.
5642 (bidi_initialize): Use uniprop_table instead of including
5643 biditype.h and bidimirror.h.
5645 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5646 coordinates of the iterator when restoring from ppos_it.
5649 2011-08-14 Kenichi Handa <handa@m17n.org>
5651 * process.c (create_process): Call setup_process_coding_systems
5652 after the pid of the process is set to -1 (Bug#8162).
5654 2011-08-14 Eli Zaretskii <eliz@gnu.org>
5656 * xdisp.c (move_it_in_display_line_to): Don't invoke
5657 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5658 ppos_it. Fixes vertical cursor motion when line beginning is
5659 covered by an image. (Bug#9296)
5661 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5663 * nsterm.h (ns_run_ascript): Declare.
5664 (NSAPP_DATA2_RUNASSCRIPT): Define.
5666 * nsfns.m (as_script, as_result, as_status): New static variables.
5667 (ns_run_ascript): New function.
5668 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
5669 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5670 the event loop. Get status from as_status (Bug#7276).
5672 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5673 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5674 the event loop (Bug#7276).
5676 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5678 * gnutls.c (QCgnutls_bootprop_priority)
5679 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5680 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5681 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5682 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5683 (QCgnutls_bootprop_verify_hostname_error)
5684 (QCgnutls_bootprop_callbacks_verify): Rename from
5685 Qgnutls_bootprop_..., all uses changed.
5687 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5690 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5692 * xfaces.c (Qframe_set_background_mode): Now static.
5693 * dispextern.h (Qframe_set_background_mode): Remove decl.
5695 * process.c (Fnetwork_interface_info): Declare local only if needed.
5697 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5699 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5700 (Fnetwork_interface_list): Allocate in increments of bytes instead
5701 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5702 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5704 (struct ifflag_def): notrailers is smart on OSX.
5705 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5706 Get hardware address with getifaddrs if available.
5708 2011-08-12 Eli Zaretskii <eliz@gnu.org>
5710 * xdisp.c (iterate_out_of_display_property): xassert that
5711 IT->position is set to within IT->object's boundaries. Break from
5712 the loop as soon as EOB is reached; avoids infloops in redisplay
5713 when IT->position is set up wrongly due to some bug.
5714 Set IT->current to match the bidi iterator unconditionally.
5715 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5716 entry. Force push_it to save on the stack the current
5717 buffer/string position, to be restored by pop_it. Fix flags in
5718 the iterator structure wrt the object coming from a display
5719 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5720 properties. (Bug#9284)
5722 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
5724 * fontset.c (fontset_get_font_group): Add proper type checks.
5727 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5729 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5730 and LC_VERSION_MIN_MACOSX.
5731 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5732 (dump_it) [LC_FUNCTION_STARTS]: Use it.
5734 2011-08-08 Eli Zaretskii <eliz@gnu.org>
5736 * xdisp.c (forward_to_next_line_start): Allow to use the
5737 no-display-properties-and-no-overlays under bidi display.
5738 Set disp_pos in the bidi iterator to avoid searches for display
5739 properties and overlays.
5741 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
5743 * editfns.c (Fset_time_zone_rule): Document relationship with the
5746 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5747 the font entity extracted from the cache (Bug#8109).
5749 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
5751 * composite.c (autocmp_chars): Don't reset point. That is done by
5752 restore_point_unwind (Bug#5984).
5754 2011-08-07 Juri Linkov <juri@jurta.org>
5756 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5757 to show the arg `TIME' instead of `TIMEVAL'.
5759 2011-08-06 Eli Zaretskii <eliz@gnu.org>
5761 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5762 display property strides EOL and includes a newline, as in
5763 longlines-mode. (Bug#9254)
5764 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5765 word-wrap under bidirectional display. (Bug#9224)
5767 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5768 is non-zero, even if the data buffer is NULL. Fixes a crash in
5769 vertical-motion with longlines-mode. (Bug#9254)
5771 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5773 * bidi.c <bidi_cache_total_alloc>: Now static.
5774 (bidi_initialize): Initialize bidi_cache_total_alloc.
5776 * xdisp.c (display_line): Release buffer allocated for shelved bidi
5779 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5780 amount allocated this far in `bidi_cache_total_alloc'.
5781 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5782 non-zero, only free the data buffer without restoring the cache
5783 contents. All callers changed.
5785 * dispextern.h (bidi_unshelve_cache): Update prototype.
5787 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5788 (move_it_in_display_line, move_it_to)
5789 (move_it_vertically_backward, move_it_by_lines): Replace the call
5790 to xfree to an equivalent call to bidi_unshelve_cache.
5791 (move_it_in_display_line_to): Fix logic of returning
5792 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
5794 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5796 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5797 came from a string character with a `cursor' property. (Bug#9229)
5799 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5801 * Makefile.in (LIB_PTHREAD): New variable.
5802 (LIBES): Add LIB_PTHREAD (Bug#9216).
5804 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5805 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5807 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5809 * regex.c (re_iswctype): Remove some redundant boolean conversions.
5811 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5813 * xterm.c (x_find_topmost_parent): New function.
5814 (x_set_frame_alpha): Find topmost parent window with
5815 x_find_topmost_parent and set the property there also (bug#9181).
5816 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5818 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5820 * callproc.c (Fcall_process): Avoid vfork clobbering
5821 the local vars buffer, coding_systems, current_dir.
5823 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5825 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5827 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5829 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5830 so that it is not optimized away.
5832 * xdisp.c (compute_display_string_pos): Remove unused local.
5834 2011-08-02 Eli Zaretskii <eliz@gnu.org>
5836 Fix slow cursor motion and scrolling in large buffers with
5837 selective display, like Org Mode buffers. (Bug#9218)
5839 * dispextern.h (struct bidi_it): New member disp_prop_p.
5841 * xdisp.c: Remove one-slot cache of display string positions.
5842 (compute_display_string_pos): Accept an additional argument
5843 DISP_PROP_P; callers changed. Scan at most 5K characters forward
5844 for a display string or property. If found, set DISP_PROP_P
5847 * bidi.c (bidi_fetch_char): Accept an additional argument
5848 DISP_PROP_P, and pass it to compute_display_string_pos.
5849 Only handle text covered by a display string if DISP_PROP_P is returned
5850 non-zero. All callers of bidi_fetch_char changed.
5852 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5854 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5856 2010-12-03 Don March <don@ohspite.net>
5858 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5859 last character M-[char] is translated to ESC [char] (bug#7541).
5861 2011-08-02 Kenichi Handa <handa@m17n.org>
5863 * lisp.h (uniprop_table): Extern it.
5865 * chartab.c (uniprop_table): Make it non-static.
5867 2011-08-01 Eli Zaretskii <eliz@gnu.org>
5869 * xdisp.c (forward_to_next_line_start): Accept additional argument
5870 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5872 (reseat_at_next_visible_line_start): Use the bidi iterator state
5873 returned by forward_to_next_line_start to restore the state of
5874 it->bidi_it after backing up to previous newline. (Bug#9212)
5876 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5878 * regex.c (re_comp): Protoize.
5879 (re_exec): Fix return type.
5880 (regexec): Fix type of `ret'. (Bug#9203)
5882 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5884 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5885 This is needed if max-image-size is a floating-point number.
5887 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5889 * print.c (print_object): Print empty symbol as ##.
5891 * lread.c (read1): Read ## as empty symbol.
5893 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5895 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5896 setting frame foreground color (Bug#9175).
5897 (x_set_background_color): Likewise.
5899 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5900 contents (Bug#9176).
5901 (EmacsTooltip -init): Remove bezels and add shadows to
5904 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5905 or scroll bar (Bug#8470).
5907 * nsfont.m (nsfont_open): Remove assignment to voffset and
5908 unnecessary vars hshink, expand, hd, full_height, min_height.
5909 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5911 * nsterm.h (nsfont_info): Remove voffset field.
5913 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5915 Implement strike-through and overline on NextStep (Bug#8863).
5917 * nsfont.m (nsfont_open): Use underline position provided by font,
5918 instead of hard-coded value of 2.
5919 (nsfont_draw): Call ns_draw_text_decoration instead.
5921 * nsterm.h: Add declaration for ns_draw_text_decoration.
5923 * nsterm.m (ns_draw_text_decoration): New function for drawing
5924 underline, overline, and strike-through.
5925 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5926 ns_draw_text_decoration. Change treatment of cursor drawing to
5927 accommodate underlining, etc.
5929 2011-07-28 Eli Zaretskii <eliz@gnu.org>
5931 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5934 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5936 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5937 Without this fix, if a signal arrives just after memory fills up,
5938 'malloc' might be invoked reentrantly.
5940 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5941 In other words, assume that every image size is allowed, on non-X
5942 hosts. This assumption is probably wrong, but it lets Emacs compile.
5944 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5946 * regex.c (re_iswctype): Convert return values to boolean.
5948 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5950 * xdisp.c (compute_display_string_pos): Don't use cached display
5951 string position if the buffer had its restriction changed.
5954 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5956 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5958 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5960 Integer signedness and overflow and related fixes. (Bug#9079)
5962 * bidi.c: Integer size and overflow fixes.
5963 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5964 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5965 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5966 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5967 (bidi_find_other_level_edge):
5968 Use ptrdiff_t instead of EMACS_INT where either will do.
5969 This works better on 32-bit hosts configured --with-wide-int.
5970 (bidi_cache_ensure_space): Check for size-calculation overflow.
5971 Use % rather than repeated addition, for better worst-case speed.
5972 Don't set bidi_cache_size until after xrealloc returns, because it
5974 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
5975 (bidi_cache_ensure_space): Also check that the bidi cache size
5976 does not exceed that of the largest Lisp string or buffer. See Eli
5977 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
5979 * alloc.c (__malloc_size_t): Remove.
5980 All uses replaced by size_t. See Andreas Schwab's note
5981 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5983 * image.c: Improve checking for integer overflow.
5984 (check_image_size): Assume that f is nonnull, since
5985 it is always nonnull in practice. This is one less thing to
5986 worry about when checking for integer overflow later.
5987 (x_check_image_size): New function, which checks for integer
5988 overflow issues inside X.
5989 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5990 This removes the need for a memory_full check.
5991 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5992 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5993 (xbm_read_bitmap_data): Change locals back to 'int', since
5994 their values must fit in 'int'.
5995 (xpm_load_image, png_load, tiff_load):
5996 Invoke x_create_x_image_and_pixmap earlier,
5997 to avoid much needless work if the image is too large.
5998 (tiff_load): Treat overly large images as if
5999 x_create_x_image_and_pixmap failed, not as malloc failures.
6000 (gs_load): Use x_check_image_size.
6002 * gtkutil.c: Omit integer casts.
6003 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6004 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6006 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6008 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6009 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6010 would wrongly return t on a 64-bit host.
6012 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6013 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6014 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6015 and therefore cause GCC to emit a bogus diagnostic in some cases.
6017 * image.c: Integer signedness and overflow and related fixes.
6018 This is not an exhaustive set of fixes, but it's time to
6019 record what I've got.
6020 (lookup_pixel_color, check_image_size): Remove redundant decls.
6021 (check_image_size): Don't assume that arbitrary EMACS_INT values
6022 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6023 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6024 (tiff_load, imagemagick_load_image):
6025 Check for overflow in size calculations.
6026 (x_create_x_image_and_pixmap): Remove unnecessary test for
6027 xmalloc returning NULL; that can't happen.
6028 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6029 (xpm_color_bucket): Use better integer hashing function.
6030 (xpm_cache_color): Don't possibly over-allocate memory.
6031 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6032 (gif_memory_source):
6033 Use ptrdiff_t, not int or size_t, to record sizes.
6034 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6035 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6036 either works, as we prefer signed integers.
6037 (tiff_read_from_memory, tiff_write_from_memory):
6038 Return tsize_t, not size_t, since that's what the TIFF API wants.
6039 (tiff_read_from_memory): Don't fail simply because the read would
6040 go past EOF; instead, return a short read.
6041 (tiff_load): Omit no-longer-needed casts.
6042 (Fimagemagick_types): Don't assume size fits into 'int'.
6044 Improve hashing quality when configured --with-wide-int.
6045 * fns.c (hash_string): New function, taken from sxhash_string.
6046 Do not discard information about ASCII character case; this
6047 discarding is no longer needed.
6048 (sxhash-string): Use it. Change sig to match it. Caller changed.
6049 * lisp.h: Declare it.
6050 * lread.c (hash_string): Remove, since we now use fns.c's version.
6051 The fns.c version returns a wider integer if --with-wide-int is
6052 specified, so this should help the quality of the hashing a bit.
6054 * emacs.c: Integer overflow minor fix.
6055 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6056 Define only if GNU_LINUX.
6057 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6059 * dispnew.c: Integer signedness and overflow fixes.
6060 Remove unnecessary forward decls, that were a maintenance hassle.
6061 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6063 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6064 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6065 (prepare_desired_row, line_draw_cost):
6066 Use int, not unsigned, where either works.
6067 (save_current_matrix, restore_current_matrix):
6068 Use ptrdiff_t, not size_t, where either works.
6069 (init_display): Check for overflow more accurately, and without
6070 relying on undefined behavior.
6072 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6073 Remove, replacing with the new symbols in lisp.h. All uses changed.
6074 * fileio.c (make_temp_name):
6075 * filelock.c (lock_file_1, lock_file):
6076 * xdisp.c (message_dolog):
6077 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6078 Use pMd etc. instead.
6079 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6080 replacing the pWIDE etc. symbols removed from editfns.c.
6082 * keyboard.h (num_input_events): Now uintmax_t.
6083 This is (very slightly) less likely to mess up due to wraparound.
6086 * buffer.c: Integer signedness fixes.
6087 (alloc_buffer_text, enlarge_buffer_text):
6088 Use ptrdiff_t rather than size_t when either will do, as we prefer
6091 * alloc.c: Integer signedness and overflow fixes.
6092 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6093 (__malloc_size_t): Default to size_t, not to int.
6094 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6095 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6096 Prefer ptrdiff_t to size_t when either would do, as we prefer
6098 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6099 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6100 Now const. Initialize with values that are in range even if char
6102 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6103 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6104 These functions do the right thing with sizes > 2**32.
6105 (check_depth): Now ptrdiff_t, not int.
6106 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6107 Adjust to new way of storing sizes. Check for size overflow bugs
6109 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6110 slightly wrong anyway, as it missed one instance of
6111 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6112 (refill_memory_reserve): Omit needless cast to size_t.
6113 (mark_object_loop_halt): Mark as externally visible.
6115 * xselect.c: Integer signedness and overflow fixes.
6116 (Fx_register_dnd_atom, x_handle_dnd_message):
6117 Use ptrdiff_t, not size_t, since we prefer signed.
6118 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6119 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6120 x_dnd_atoms_size and x_dnd_atoms_length.
6122 * doprnt.c: Prefer signed to unsigned when either works.
6124 * doprnt.c (doprnt):
6126 * xdisp.c (vmessage):
6127 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6128 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6129 prefer signed arithmetic to avoid comparison confusion.
6130 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6131 but is a bit tricky.
6133 Assume freestanding C89 headers, string.h, stdlib.h.
6134 * data.c, doprnt.c, floatfns.c, print.c:
6135 Include float.h unconditionally.
6136 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6137 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6138 * regex.c: Likewise for stddef.h, string.h.
6139 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6140 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6141 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6142 (STDC_HEADERS): Remove obsolete defines.
6143 * sysdep.c: Include limits.h unconditionally.
6145 Assume support for memcmp, memcpy, memmove, memset.
6146 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6147 * regex.c (memcmp, memcpy):
6148 Remove; we assume C89 now.
6150 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6151 (__malloc_safe_bcopy): Remove; no longer needed.
6153 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6154 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6155 well either way, and we prefer signed to unsigned.
6157 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6159 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6160 closes the connection while we're reading (bug#9182).
6162 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
6164 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6165 are specified (Bug#9168).
6167 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6169 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6170 Found by GCC static checking and --with-wide-int on a 32-bit host.
6172 2011-07-25 Eli Zaretskii <eliz@gnu.org>
6174 * xdisp.c (compute_display_string_pos): Fix logic of caching
6175 previous display string position. Initialize cached_prev_pos to
6176 -1. Fixes slow-down at the beginning of a buffer.
6178 2011-07-24 Eli Zaretskii <eliz@gnu.org>
6180 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6181 for attrs[LFACE_FONTSET_INDEX].
6183 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6185 * xml.c (parse_region): Remove unused local
6186 that was recently introduced.
6188 2011-07-23 Eli Zaretskii <eliz@gnu.org>
6190 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6191 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6193 * xdisp.c (move_it_in_display_line_to): Record the best matching
6194 position for TO_CHARPOS while scanning the line, and restore it on
6195 exit if none of the characters scanned was an exact match.
6196 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
6197 when exact match is impossible due to invisible text, and the
6198 lines are truncated.
6200 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6202 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6205 2011-07-22 Eli Zaretskii <eliz@gnu.org>
6207 Fix a significant slow-down of cursor motion with C-n, C-p,
6208 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6209 auto-repeat under bidi redisplay in fontified buffers.
6210 * xdisp.c (compute_stop_pos_backwards): New function.
6211 (next_element_from_buffer): Call compute_stop_pos_backwards to
6212 find a suitable prev_stop when we find ourselves before
6214 (reseat): Don't look for prev_stop, as that could mean a very long
6216 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6217 <cached_disp_overlay_modiff>: Cache for last found display string
6219 (compute_display_string_pos): Return the cached position if asked
6220 about the same buffer in the same area of character positions, and
6221 the buffer wasn't changed since the time the display string
6222 position was cached.
6224 2011-07-22 Eli Zaretskii <eliz@gnu.org>
6226 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6227 is an integer, which is important for empty lines. (Bug#9149)
6229 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
6231 * frame.c (Fmodify_frame_parameters): In tty case, update the
6232 default face if necessary (Bug#4238).
6234 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
6236 * editfns.c (Fstring_to_char): No need to explain what a character
6237 is in the docstring (Bug#6576).
6239 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6241 * xml.c (parse_region): Make sure we always return a tree.
6243 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6245 * xml.c (parse_region): If a document contains only comments,
6248 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6250 * xml.c (make_dom): Return comments, too.
6252 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6255 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6256 and the surrounding thread.
6257 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6258 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6259 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6261 * s/openbsd.h (BROKEN_SIGIO): Define.
6262 * unexelf.c (unexec) [__OpenBSD__]:
6263 Don't update the .mdebug section of the Alpha COFF symbol table.
6265 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6267 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6270 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6272 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6273 This fixes some race conditions on the permissions of any newly
6276 * alloc.c (valid_pointer_p): Use pipe, not open.
6277 This fixes some permissions issues when debugging.
6279 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6280 If fchown fails to set both uid and gid, try to set just gid,
6281 as that is sometimes allowed. Adjust the file's mode to eliminate
6282 setuid or setgid bits that are inappropriate if fchown fails.
6284 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6286 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6287 to compare Lisp_Objects.
6288 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6289 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6290 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6292 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6294 * lread.c (read_integer): Unread even EOF character.
6295 (read1): Likewise. Properly record start position of symbol.
6297 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6298 symbol character follows.
6300 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6302 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6303 This works around a problem with the previous change to Fcopy_file.
6304 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6305 and without this change, GCC might complain about discarding
6306 fchown's return value.
6308 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
6310 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6312 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6314 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6316 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6318 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6319 it's used from the C level.
6321 * process.c: Use the same condition for POLL_FOR_INPUT in both
6322 keyboard.c and process.c (bug#1858).
6324 2011-07-09 Lawrence Mitchell <wence@gmx.li>
6326 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6327 (Fgnutls_boot): Use it.
6329 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6331 * doc.c (Fsubstitute_command_keys): Revert last change.
6333 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6335 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6336 quotes the next character, and doesn't affect other longer
6337 sequences (bug#8935).
6339 * lread.c (syms_of_lread): Clarify that is isn't only
6340 `eval-buffer' and `eval-defun' that's affected by
6341 `lexical-binding' (bug#8460).
6343 2011-07-15 Eli Zaretskii <eliz@gnu.org>
6345 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6346 bidi redisplay when a line includes both an image and is truncated.
6348 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6350 Fix minor problems found by static checking.
6351 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6352 (elsz): Now a signed constant, not a size_t var. We prefer signed
6353 types to unsigned, to avoid integer comparison confusion. Without
6354 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6355 "cannot optimize loop, the loop counter may overflow", a symptom
6357 * indent.c (Fvertical_motion): Mark locals as initialized.
6358 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6360 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6362 * search.c (Fre_search_backward): Mention `case-fold-search' in
6363 all the re_search_* functions (bug#8138).
6365 * keyboard.c (Fopen_dribble_file): Document when the file is
6368 2011-07-14 Eli Zaretskii <eliz@gnu.org>
6370 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6373 Support bidi reordering of display and overlay strings.
6374 * xdisp.c (compute_display_string_pos)
6375 (compute_display_string_end): Accept additional argument STRING.
6376 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6377 (reseat_to_string): Initialize bidi_it->string.s and
6378 bidi_it->string.schars.
6379 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
6380 NULL (avoids a crash in bidi_paragraph_init).
6381 Initialize itb.string.lstring.
6382 (init_iterator): Call bidi_init_it only of a valid
6383 buffer position was specified. Initialize paragraph_embedding to
6385 (reseat_to_string): Initialize the bidi iterator.
6386 (display_string): If we need to ignore text properties of
6387 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6388 original value of -1 will not work with bidi.)
6389 (compute_display_string_pos): First arg is now struct
6390 `text_pos *'; all callers changed. Support display properties on
6392 (compute_display_string_end): Support display properties on Lisp
6394 (init_iterator, reseat_1, reseat_to_string): Initialize the
6395 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6396 when iterating on a string not from display properties).
6397 (compute_display_string_pos, compute_display_string_end):
6398 Fix calculation of the object to scan. Fixes an error when using
6400 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
6401 base_level_stop; instead, set base_level_stop to BEGV.
6402 Fixes crashes in vertical-motion.
6403 (next_element_from_buffer): Improve commentary for when
6404 the iterator is before prev_stop.
6405 (init_iterator): Initialize bidi_p from the default value of
6406 bidi-display-reordering, not from buffer-local value. Use the
6407 buffer-local value only if initializing for buffer iteration.
6408 (handle_invisible_prop): Support invisible properties on strings
6409 that are being bidi-reordered.
6410 (set_iterator_to_next): Support bidi reordering of C strings and
6412 (next_element_from_string): Support bidi reordering of Lisp
6414 (handle_stop_backwards): Support Lisp strings as well.
6415 (display_string): Support display of R2L glyph rows.
6416 Use IT_STRING_CHARPOS when displaying from a Lisp string.
6417 (init_iterator): Don't initialize it->bidi_p for strings
6419 (reseat_to_string): Initialize it->bidi_p for strings here.
6420 (next_element_from_string, next_element_from_c_string)
6421 (next_element_from_buffer): Add xassert's for correspondence
6422 between IT's object being iterated and it->bidi_it.string
6424 (face_before_or_after_it_pos): Support bidi iteration.
6425 (next_element_from_c_string): Handle the case of the first string
6426 character that is not the first one in the visual order.
6427 (get_visually_first_element): New function, refactored from common
6428 parts of next_element_from_buffer, next_element_from_string, and
6429 next_element_from_c_string.
6430 (tool_bar_lines_needed, redisplay_tool_bar)
6431 (display_menu_bar): Force left-to-right direction. Add a FIXME
6432 comment for making that be controlled by a user option.
6433 (push_it, pop_it): Save and restore the state of the
6434 bidi iterator. Save and restore the bidi_p flag.
6435 (pop_it): Iterate out of display property for string iteration as
6437 (iterate_out_of_display_property): Support iteration over strings.
6438 (handle_single_display_spec): Set up it->bidi_it for iteration
6439 over a display string, and call bidi_init_it.
6440 (handle_single_display_spec, next_overlay_string)
6441 (get_overlay_strings_1, push_display_prop): Set up the bidi
6442 iterator for displaying display or overlay strings.
6443 (forward_to_next_line_start): Don't use the shortcut if
6445 (back_to_previous_visible_line_start): If handle_display_prop
6446 pushed the iterator stack, restore the internal state of the bidi
6447 iterator by calling bidi_pop_it same number of times.
6448 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6449 and we are bidi-iterating, don't decrement the iterator position;
6450 instead, set the first_elt flag in the bidi iterator, to produce
6452 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6453 (push_display_prop): xassert that we are iterating a buffer.
6454 (push_it, pop_it): Save and restore paragraph_embedding member.
6455 (handle_single_display_spec, next_overlay_string)
6456 (get_overlay_strings_1, reseat_1, reseat_to_string)
6457 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6458 correctly. Don't assume unibyte strings are not bidi-reordered.
6459 (compute_display_string_pos)
6460 (compute_display_string_end): Fix handling the case of C string.
6461 (push_it, pop_it): Save and restore from_disp_prop_p.
6462 (handle_single_display_spec, push_display_prop): Set the
6463 from_disp_prop_p flag.
6464 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6465 (pop_it): Call iterate_out_of_display_property only if we are
6466 popping after iteration over a string that came from a display
6467 property. Fix a typo in popping stretch info. Add an assertion
6468 for verifying that the iterator position is in sync with the bidi
6470 (handle_single_display_spec, get_overlay_strings_1)
6471 (push_display_prop): Fix initialization of paragraph direction for
6472 string when that of the parent object is not yet determined.
6473 (reseat_1): Call bidi_init_it to resync the bidi
6474 iterator with IT's position. (Bug#7616)
6475 (find_row_edges): If ROW->start.pos gives position
6476 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6477 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6478 Reset the from_disp_prop_p flag.
6479 (SAVE_IT, RESTORE_IT): New macros.
6480 (pos_visible_p, face_before_or_after_it_pos)
6481 (back_to_previous_visible_line_start)
6482 (move_it_in_display_line_to, move_it_in_display_line)
6483 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6484 (try_scrolling, redisplay_window, display_line): Use them when
6485 saving a temporary copy of the iterator and restoring it back.
6486 (back_to_previous_visible_line_start, reseat_1)
6487 (init_iterator): Empty the bidi cache "stack".
6488 (move_it_in_display_line_to): If iterator ended up at
6489 EOL, but we never saw any buffer positions smaller than
6490 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6491 motion in bidi-reordered lines.
6492 (move_it_in_display_line_to): Record prev_method and prev_pos
6493 immediately before the call to set_iterator_to_next. Fixes cursor
6494 motion in bidi-reordered lines with stretch glyphs and strings
6495 displayed in margins. (Bug#8133) (Bug#8867)
6496 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6498 (pos_visible_p): Support positions in bidi-reordered lines.
6499 Save and restore bidi cache.
6501 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6502 (bidi_paragraph_info): Delete unused struct.
6503 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6504 (bidi_cache_start): New variable.
6505 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6507 (bidi_cache_fetch_state, bidi_cache_search)
6508 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6509 (bidi_cache_find, bidi_peek_at_next_level)
6510 (bidi_level_of_next_char, bidi_find_other_level_edge)
6511 (bidi_move_to_visually_next): Compare cache index with
6512 bidi_cache_start rather than with zero.
6513 (bidi_fetch_char): Accept new argument STRING; all callers
6514 changed. Support iteration over a string. Support strings with
6515 display properties. Support unibyte strings. Fix the type of
6516 `len' according to what STRING_CHAR_AND_LENGTH expects.
6517 (bidi_paragraph_init, bidi_resolve_explicit_1)
6518 (bidi_resolve_explicit, bidi_resolve_weak)
6519 (bidi_level_of_next_char, bidi_move_to_visually_next):
6520 Support iteration over a string.
6521 (bidi_set_sor_type, bidi_resolve_explicit_1)
6522 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6523 can now be zero (for strings); special values 0 and -1 were
6524 changed to -1 and -2, respectively.
6525 (bidi_char_at_pos): New function.
6526 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6527 Call it instead of FETCH_MULTIBYTE_CHAR.
6528 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6529 initialized to valid values.
6530 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6532 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6533 the test for valid cached positions. Fix the logic for looking up
6534 the sentinel state in the cache. GCPRO the Lisp string we are
6536 (bidi_push_it, bidi_pop_it): New functions.
6537 (bidi_initialize): Initialize the bidi cache start stack pointer.
6538 (bidi_cache_ensure_space): New function, refactored from part of
6539 bidi_cache_iterator_state. Don't assume the required size is just
6540 one BIDI_CACHE_CHUNK away.
6541 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6542 (bidi_count_bytes, bidi_char_at_pos): New functions.
6543 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6544 always valid if bidi_cache_idx is valid.
6545 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6546 is valid if it's going to be used.
6547 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6548 (bidi_cache_fetch_state, bidi_cache_search)
6549 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6550 (bidi_cache_iterator_state, bidi_cache_find)
6551 (bidi_find_other_level_edge, bidi_cache_start_stack):
6552 All variables related to cache indices are now EMACS_INT.
6554 * dispextern.h (struct bidi_string_data): New structure.
6555 (struct bidi_it): New member `string'. Make flag members be 1-bit
6556 fields, and put them last in the struct.
6557 (compute_display_string_pos, compute_display_string_end):
6559 (bidi_push_it, bidi_pop_it): Add prototypes.
6560 (struct iterator_stack_entry): New members bidi_p,
6561 paragraph_embedding, and from_disp_prop_p.
6562 (struct it): Member bidi_p is now a bit field 1 bit wide.
6563 (bidi_shelve_cache, bidi_unshelve_cache):
6566 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6567 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6568 and vector-like objects.
6570 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6571 cache around display iteration.
6573 * window.c (Fwindow_end, window_scroll_pixel_based)
6574 (displayed_window_lines, Frecenter): Save and restore the bidi
6575 cache around display iteration.
6577 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6579 * editfns.c (Fdelete_region): Clarify the use of the named
6580 parameters (bug#6788).
6582 2011-07-14 Martin Rudalics <rudalics@gmx.at>
6584 * indent.c (Fvertical_motion): Set and restore w->pointm when
6585 saving and restoring the window's buffer (Bug#9006).
6587 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6589 * editfns.c (Fstring_to_char): Clarify just what is returned
6590 (bug#6576). Text by Eli Zaretskii.
6592 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
6594 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6596 2011-07-13 Eli Zaretskii <eliz@gnu.org>
6598 * buffer.c (mmap_find): Fix a typo.
6600 2011-07-13 Johan Bockgård <bojohan@gnu.org>
6602 Fix execution of x selection hooks.
6603 * xselect.c (Qx_lost_selection_functions)
6604 (Qx_sent_selection_functions): New vars.
6605 (syms_of_xselect): DEFSYM them.
6606 (x_handle_selection_request): Pass Qx_sent_selection_functions
6607 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6608 (x_handle_selection_clear,x_clear_frame_selections):
6609 Pass Qx_lost_selection_functions rather than
6610 Vx_lost_selection_functions to Frun_hook_with_args.
6612 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6614 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
6615 The old code sometimes used this field without initializing it.
6617 * alloc.c (gc_sweep): Don't read past end of array.
6618 In theory, the old code could also have corrupted Emacs internals,
6619 though it'd be very unlikely.
6621 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6623 * character.c (Fcharacterp): Don't advertise optional ignored
6624 argument. (Bug#4026)
6626 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6628 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6631 * window.c (Fset_window_start): Doc fix (bug#4199).
6632 (Fset_window_hscroll): Ditto.
6634 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6636 Fix minor new problems caught by GCC 4.6.1.
6637 * term.c (init_tty): Remove unused local.
6638 * xsettings.c (store_monospaced_changed): Define this function only
6639 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
6642 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
6644 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6646 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6648 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6649 are the mini-buffer and the echo area (bug#3320).
6651 * term.c (init_tty): Remove support for supdup, c10 and perq
6652 terminals, which are no longer supported (bug#1482).
6654 2011-07-10 Johan Bockgård <bojohan@gnu.org>
6656 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6658 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6660 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6661 for non-popups (Bug#3642).
6663 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6665 * alloc.c (reset_malloc_hooks): Protoize.
6666 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
6667 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6668 * cm.c (losecursor): Likewise.
6669 * data.c (fmod): Likewise.
6670 * dispnew.c (swap_glyphs_in_rows): Likewise.
6671 * emacs.c (memory_warning_signal): Likewise.
6672 * floatfns.c (float_error): Likewise.
6673 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6674 (otf_open, font_otf_capability, generate_otf_features)
6675 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6677 * image.c (pbm_read_file): Likewise.
6678 * indent.c (string_display_width): Likewise.
6679 * intervals.c (check_for_interval, search_for_interval)
6680 (inc_interval_count, count_intervals, root_interval)
6681 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6682 * lread.c (defalias): Likewise.
6683 * ralloc.c (r_alloc_check): Likewise.
6684 * regex.c (set_image_of_range_1, set_image_of_range)
6685 (regex_grow_registers): Likewise.
6686 * sysdep.c (strerror): Likewise.
6687 * termcap.c (valid_filename_p, tprint, main): Likewise.
6688 * tparam.c (main): Likewise.
6689 * unexhp9k800.c (run_time_remap, save_data_space)
6690 (update_file_ptrs, read_header, write_header, calculate_checksum)
6691 (copy_file, copy_rest, display_header): Likewise.
6692 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6694 * xdisp.c (check_it): Likewise.
6695 * xfaces.c (register_color, unregister_color, unregister_colors):
6697 * xfns.c (print_fontset_result): Likewise.
6698 * xrdb.c (member, fatal, main): Likewise.
6700 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6702 Fix minor problems found by static checking (Bug#9031).
6703 * chartab.c (char_table_set_range, map_sub_char_table):
6704 Remove unused locals.
6705 (uniprop_table): Now static.
6706 * composite.c (_work_char): Remove unused static var.
6708 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
6710 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6712 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6714 * gtkutil.c (qttip_cb): Remove code without function.
6716 2011-07-09 Eli Zaretskii <eliz@gnu.org>
6718 * w32.c (pthread_sigmask): New stub.
6720 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
6722 Use pthread_sigmask, not sigprocmask (Bug#9010).
6723 sigprocmask is portable only for single-threaded applications, and
6724 Emacs can be multi-threaded when it uses GTK.
6725 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6727 * callproc.c (Fcall_process):
6728 * process.c (create_process):
6729 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6730 Use pthread_sigmask, not sigprocmask.
6732 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6734 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6735 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6738 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6740 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6741 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6742 (xg_hide_tooltip): Fix comment.
6744 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6745 in registerServicesMenuSendTypes.
6746 (validRequestorForSendType): Don't check ns_return_types.
6748 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6751 2011-07-08 Jason Rumney <jasonr@gnu.org>
6753 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6754 SH_SHOW for hidden windows (Bug#5482).
6756 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6757 frame struct members of non-existent frames (Bug#6284).
6759 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6761 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6762 variable firstTime not needed on OSX >= 10.6.
6763 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6764 >= 10.5. Use setKnobProportion, setDoubleValue.
6766 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6767 (MAC_OS_X_VERSION_10_5): Define if not defined.
6768 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6769 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6770 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6772 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6773 cString and lossyCString on OSX >= 10.4
6775 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
6776 sizeToFit on OSX >= 10.2.
6778 * nsimage.m (allocInitFromFile): Don't use deprecated method
6779 bestRepresentationForDevice on OSX >= 10.6.
6781 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6784 * emacs.c: Declare unexec_init_emacs_zone.
6786 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6788 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6790 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6791 on svcsMenu (Bug#8842).
6793 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6795 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6797 * nsterm.m (QUTF8_STRING): Declare.
6798 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6799 (validRequestorForSendType): Return type is (id).
6800 Change indexOfObjectIdenticalTo to indexOfObject.
6801 Check if we have local selection before returning self (Bug#8842).
6802 (writeSelectionToPasteboard): Put local selection into paste board
6803 if we have a local selection (Bug#8842).
6804 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6806 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6807 (ns_get_local_selection): Declare.
6809 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6811 * keymap.c (describe_map_tree): Don't insert a double newline at
6812 the end of the buffer (bug#1169) and return whether we inserted
6815 * callint.c (Fcall_interactively): Change "reading args" to
6816 "providing args" to try to clarify what it does (bug#1010).
6818 2011-07-07 Kenichi Handa <handa@m17n.org>
6820 * composite.c (composition_compute_stop_pos): Ignore a static
6821 composition starting before CHARPOS (Bug#8915).
6823 * xdisp.c (handle_composition_prop): Likewise.
6825 2011-07-07 Eli Zaretskii <eliz@gnu.org>
6827 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6830 2011-07-07 Kenichi Handa <handa@m17n.org>
6832 * character.h (unicode_category_t): New enum type.
6834 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6835 (Qchar_code_property_table): New variable.
6836 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6837 (UNIPROP_COMPRESSED_FORM_P): New macros.
6838 (char_table_ascii): Uncompress the compressed values.
6839 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6840 Uncompress the compressed values.
6841 (sub_char_table_ref_and_range): Likewise.
6842 (char_table_ref_and_range): Uncompress the compressed values.
6843 (sub_char_table_set): New arg is_uniprop. Callers changed.
6844 Uncompress the compressed values.
6845 (sub_char_table_set_range): Args changed. Callers changed.
6846 (char_table_set_range): Adjuted for the above change.
6847 (map_sub_char_table): Delete args default_val and parent. Add arg
6848 top. Give decoded values to a Lisp function.
6849 (map_char_table): Adjust for the above change. Give decoded
6850 values to a Lisp function. Gcpro more variables.
6851 (uniprop_table_uncompress)
6852 (uniprop_decode_value_run_length): New functions.
6853 (uniprop_decoder, uniprop_decoder_count): New variables.
6854 (uniprop_get_decoder, uniprop_encode_value_character)
6855 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6857 (uniprop_encoder, uniprop_encoder_count): New variables.
6858 (uniprop_get_encoder, uniprop_table)
6859 (Funicode_property_table_internal, Fget_unicode_property_internal)
6860 (Fput_unicode_property_internal): New functions.
6861 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6862 Sunicode_property_table_internal, Sget_unicode_property_internal,
6863 and Sput_unicode_property_internal. Defvar_lisp
6864 char-code-property-alist.
6866 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
6867 Vunicode_category_table.
6869 * font.c (font_range): Adjust for the change of
6870 Vunicode_category_table.
6872 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6874 * m/iris4d.h: Remove file, move contents ...
6875 * s/irix6-5.h: ... here.
6877 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6879 Remove unportable assumption about struct layout (Bug#8884).
6880 * alloc.c (mark_buffer):
6881 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6882 (clone_per_buffer_values): Don't assume that
6883 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6884 This isn't true in general, and it's particularly not true
6885 if Emacs is configured with --with-wide-int.
6886 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6887 New macros, used in the buffer.c change.
6889 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6891 * xsettings.c: Use both GConf and GSettings if both are available.
6892 (store_config_changed_event): Add comment.
6893 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6894 (store_tool_bar_style_changed): New functions.
6895 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
6896 (struct xsettings): Move font inside HAVE_XFT.
6897 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
6898 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
6899 Move inside HAVE_XFT.
6900 (something_changed_gsettingsCB): Rename from something_changedCB.
6901 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6903 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
6904 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
6905 (something_changed_gconfCB): Rename from something_changedCB.
6906 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6907 (parse_settings): Move check for font inside HAVE_XFT.
6908 (read_settings, apply_xft_settings): Add comment.
6909 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6910 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6911 call store_font_name_changed.
6912 (xft_settings_event): Add comment.
6913 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6914 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6915 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6916 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6917 (xsettings_initialize): Call init_gsettings last.
6918 (xsettings_get_system_font, xsettings_get_system_normal_font):
6921 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6923 Random fixes. E.g., (random) never returned negative values.
6924 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6925 subseconds part to the entropy, as that's a bit more random.
6926 Prefer signed to unsigned, since the signedness doesn't matter and
6927 in general we prefer signed. When given a limit, use a
6928 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6929 latter isn't right if USE_2_TAGS_FOR_INTS.
6930 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6931 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6933 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6935 * textprop.c (text_property_stickiness):
6936 Obey Vtext_property_default_nonsticky.
6937 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6938 * w32fns.c (syms_of_w32fns):
6939 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6941 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6943 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6944 This is more efficient than Ffile_directory_p and avoids a minor race.
6946 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6948 * buffer.c (Foverlay_put): Say what the return value is
6951 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6952 is a directory before asking whether to use the file name
6954 (barf_or_query_if_file_exists): Make the "File is a directory"
6955 error be more correct.
6957 * fns.c (Frequire): Remove the mention of the .gz files, since
6958 that's installation-specific, but keep the mention of
6959 `get-load-suffixes'.
6961 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6963 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6964 Report string overflow if the output is too long.
6966 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
6968 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6969 (syms_of_gnutls): Remove duplicate DEFSYM for
6970 Qgnutls_bootprop_verify_hostname_error, an error for
6971 Qgnutls_bootprop_verify_error (which is no longer used).
6973 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6974 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6975 Also (re)move comments that are misplaced or no longer relevant.
6977 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6979 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6981 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
6983 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6984 and background color parameters if they have been changed.
6986 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6988 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6990 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6992 * xsettings.c (SYSTEM_FONT): Define only when used.
6993 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6995 * keymap.c (access_keymap_1): Now static.
6997 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
6999 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7000 leave any prefix arg for the up event (Bug#1586).
7002 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7004 * lread.c (syms_of_lread): Mention single symbols defined by
7005 `defvar' or `defconst' (bug#7154).
7007 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7008 (Frequire): Mention get-load-suffixes.
7010 2011-07-02 Martin Rudalics <rudalics@gmx.at>
7012 * window.h (window): Remove clone_number slot.
7013 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7015 (make_parent_window, make_window, saved_window)
7016 (Fset_window_configuration, save_window_save): Don't deal with
7018 * buffer.c (Qclone_number): Remove declaration.
7019 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7021 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7023 Add multiple inheritance to keymaps.
7024 * keymap.c (Fmake_composed_keymap): New function.
7025 (Fset_keymap_parent): Simplify.
7026 (fix_submap_inheritance): Remove.
7027 (access_keymap_1): New function extracted from access_keymap to handle
7028 embedded parents and handle lists of maps.
7029 (access_keymap): Use it.
7030 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7031 (Fcopy_keymap): Handle embedded parents.
7032 (Fcommand_remapping, define_as_prefix): Simplify.
7033 (Fkey_binding): Simplify.
7034 (syms_of_keymap): Move minibuffer-local-completion-map,
7035 minibuffer-local-filename-completion-map,
7036 minibuffer-local-must-match-map, and
7037 minibuffer-local-filename-must-match-map to Elisp.
7038 (syms_of_keymap): Defsubr make-composed-keymap.
7039 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7040 (parse_menu_item): Trivial simplification.
7042 2011-07-01 Glenn Morris <rgm@gnu.org>
7044 * Makefile.in (SETTINGS_LIBS): Fix typo.
7046 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7048 * coding.c (Fencode_coding_string): Record the last coding system
7049 used, as the function doc string says (bug#8738).
7051 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7053 * xsettings.c (store_monospaced_changed): Take new font as arg and
7054 check for change against current_mono_font.
7055 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7056 (emacs_settings_constructor, emacs_settings_get_property)
7057 (emacs_settings_set_property, emacs_settings_class_init)
7058 (emacs_settings_init, gsettings_obj): Remove.
7059 (something_changedCB): New function for HAVE_GSETTINGS.
7060 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7061 with value as argument.
7062 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7063 g_settings_new (Bug#8967). Do not create gsettings_obj.
7064 Remove calls to g_settings_bind. Connect something_changedCB to
7067 * xgselect.c: Add defined (HAVE_GSETTINGS).
7068 (xgselect_initialize): Ditto.
7070 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7071 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7074 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7076 * eval.c (struct backtrace): Simplify and port the data structure.
7077 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7078 signed bit field, as this assumption is not portable and it makes
7079 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7080 "char debug_on_exit : 1" as this is not portable either; instead,
7081 use the portable "unsigned int debug_on_exit : 1". Remove unused
7082 member evalargs. Remove obsolete comments about cc bombing out.
7084 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7086 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
7087 Let HAVE_GSETTINGS override HAVE_GCONF.
7088 (store_monospaced_changed): New function.
7089 (EMACS_SETTINGS): A new type derived from GObject to handle
7090 GSettings notifications.
7091 (emacs_settings_constructor, emacs_settings_get_property)
7092 (emacs_settings_set_property, emacs_settings_class_init):
7094 (gsettings_client, gsettings_obj): New variables.
7095 (GSETTINGS_SCHEMA): New define.
7096 (something_changedCB): Call store_monospaced_changed.
7097 (init_gsettings): New function.
7098 (xsettings_initialize): Call init_gsettings.
7099 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7102 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
7105 2011-06-29 Martin Rudalics <rudalics@gmx.at>
7107 * window.c (resize_root_window, grow_mini_window)
7108 (shrink_mini_window): Rename Qresize_root_window to
7109 Qwindow_resize_root_window and Qresize_root_window_vertically to
7110 Qwindow_resize_root_window_vertically.
7112 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7114 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7116 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
7118 * makefile.w32-in: Redesign dependencies so they reflect more
7119 clearly which files are directly included by each source file,
7120 and not through other includes.
7122 2011-06-27 Martin Rudalics <rudalics@gmx.at>
7124 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7125 (sort_overlays, overlay_strings): When an overlay's clone number
7126 matches the window's clone number process the overlay even if
7127 the overlay's window property doesn't match the current window.
7129 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7130 (Fwindow_hchild): Rename to Fwindow_left_child.
7131 (Fwindow_next): Rename to Fwindow_next_sibling.
7132 (Fwindow_prev): Rename to Fwindow_prev_sibling.
7133 (resize_window_check): Rename to window_resize_check.
7134 (resize_window_apply): Rename to window_resize_apply.
7135 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7136 (Fdelete_other_windows_internal, resize_frame_windows)
7137 (Fsplit_window_internal, Fdelete_window_internal)
7138 (grow_mini_window, shrink_mini_window)
7139 (Fresize_mini_window_internal): Fix callers accordingly.
7141 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7143 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7144 (emacs_fixed_set_min_size): Remove.
7145 (emacs_fixed_new): Take frame as argument.
7147 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7148 (_EmacsFixedPrivate): Remove minwidth/height.
7149 Add struct frame *f.
7150 (emacs_fixed_init): Initialize priv->f.
7151 (get_parent_class, emacs_fixed_set_min_size): Remove.
7152 (emacs_fixed_new): Set priv->f to argument.
7153 (emacs_fixed_get_preferred_width)
7154 (emacs_fixed_get_preferred_height): Use min_width/height from
7155 frames size_hint to set minimum and natural (Bug#8919).
7156 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7157 and use min_width/height from frames size_hint to set
7158 min_width/height (Bug#8919).
7160 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
7161 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7164 2011-06-26 Eli Zaretskii <eliz@gnu.org>
7166 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7167 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7170 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
7172 * process.c (wait_reading_process_output): Bypass select if
7173 waiting for a cell while ignoring keyboard input, and input is
7174 pending. Suggested by Jan Djärv (Bug#8869).
7176 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7178 Use gnulib's dup2 module instead of rolling our own.
7179 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7181 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7183 * dispnew.c (scrolling_window): Before scrolling, turn off a
7184 mouse-highlight in the window being scrolled.
7186 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
7188 Move DEFSYM to lisp.h and use everywhere.
7190 * character.h (DEFSYM): Move declaration...
7191 * lisp.h (DEFSYM): ...here.
7197 * w32select.c: Don't include character.h.
7199 * alloc.c (syms_of_alloc):
7200 * buffer.c (syms_of_buffer):
7201 * bytecode.c (syms_of_bytecode):
7202 * callint.c (syms_of_callint):
7203 * casefiddle.c (syms_of_casefiddle):
7204 * casetab.c (init_casetab_once):
7205 * category.c (init_category_once, syms_of_category):
7206 * ccl.c (syms_of_ccl):
7207 * cmds.c (syms_of_cmds):
7208 * composite.c (syms_of_composite):
7209 * dbusbind.c (syms_of_dbusbind):
7210 * dired.c (syms_of_dired):
7211 * dispnew.c (syms_of_display):
7212 * doc.c (syms_of_doc):
7213 * editfns.c (syms_of_editfns):
7214 * emacs.c (syms_of_emacs):
7215 * eval.c (syms_of_eval):
7216 * fileio.c (syms_of_fileio):
7217 * fns.c (syms_of_fns):
7218 * frame.c (syms_of_frame):
7219 * fringe.c (syms_of_fringe):
7220 * insdel.c (syms_of_insdel):
7221 * keymap.c (syms_of_keymap):
7222 * lread.c (init_obarray, syms_of_lread):
7223 * macros.c (syms_of_macros):
7224 * msdos.c (syms_of_msdos):
7225 * print.c (syms_of_print):
7226 * process.c (syms_of_process):
7227 * search.c (syms_of_search):
7228 * sound.c (syms_of_sound):
7229 * syntax.c (init_syntax_once, syms_of_syntax):
7230 * terminal.c (syms_of_terminal):
7231 * textprop.c (syms_of_textprop):
7232 * undo.c (syms_of_undo):
7233 * w32.c (globals_of_w32):
7234 * window.c (syms_of_window):
7235 * xdisp.c (syms_of_xdisp):
7236 * xfaces.c (syms_of_xfaces):
7237 * xfns.c (syms_of_xfns):
7238 * xmenu.c (syms_of_xmenu):
7239 * xsettings.c (syms_of_xsettings):
7240 * xterm.c (syms_of_xterm): Use DEFSYM.
7242 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7244 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
7246 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7248 Integer and buffer overflow fixes (Bug#8873).
7250 * print.c (printchar, strout): Check for string overflow.
7251 (PRINTPREPARE, printchar, strout):
7252 Don't set size unless allocation succeeds.
7254 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7255 for sizes. Check for string overflow more accurately.
7256 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7258 * macros.c: Integer and buffer overflow fixes.
7259 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7260 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7261 Use ptrdiff_t, not int, for sizes.
7262 Don't increment bufsize until after realloc succeeds.
7263 Check for size-calculation overflow.
7264 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7266 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7268 * lread.c: Integer overflow fixes.
7269 (read_integer): Radix is now EMACS_INT, not int,
7270 to improve quality of diagnostics for out-of-range radices.
7271 Calculate buffer size correctly for out-of-range radices.
7272 (read1): Check for integer overflow in radices, and in
7273 read-circle numbers.
7274 (read_escape): Avoid int overflow.
7275 (Fload, openp, read_buffer_size, read1)
7276 (substitute_object_recurse, read_vector, read_list, map_obarray):
7277 Use ptrdiff_t, not int, for sizes.
7278 (read1): Use EMACS_INT, not int, for sizes.
7279 Check for size overflow.
7281 * image.c (cache_image): Check for size arithmetic overflow.
7283 * lread.c: Integer overflow issues.
7284 (saved_doc_string_size, saved_doc_string_length)
7285 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7286 Now ptrdiff_t, not int.
7287 (read1): Don't assume doc string length fits in int. Check for
7288 out-of-range doc string lengths.
7289 (read_list): Don't assume file position fits in int.
7290 (read_escape): Check for hex character overflow.
7292 2011-06-22 Leo Liu <sdl.web@gmail.com>
7294 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7295 Move to minibuffer.el.
7297 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7299 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
7300 The following patches are for when GLYPH_DEBUG && !XASSERT.
7301 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7302 * dispnew.c (flush_stdout):
7303 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7304 Mark as externally visible.
7305 * dispnew.c (check_window_matrix_pointers): Now static.
7306 * dispnew.c (window_to_frame_vpos):
7307 * xfns.c (unwind_create_frame):
7308 * xterm.c (x_check_font): Remove unused local.
7309 * scroll.c (CHECK_BOUNDS):
7310 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7311 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7312 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7313 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7314 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7316 (debug_method_add): Use va_list and vsprintf rather than relying
7317 on undefined behavior with wrong number of arguments.
7318 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7319 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7320 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7321 since we're not interested in debugging glyphs with old libraries.
7322 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7323 GCC 4.6.0's static checking.
7325 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7327 Integer overflow and signedness fixes (Bug#8873).
7328 A few related buffer overrun fixes, too.
7330 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7332 * dispextern.h (struct face.stipple):
7333 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7334 (x_bitmap_mask, x_allocate_bitmap_record)
7335 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7336 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7337 (x_create_bitmap_from_xpm_data):
7338 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7339 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7341 * xfaces.c (load_pixmap):
7342 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7343 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7344 (.bitmaps_last, struct x_output.icon_bitmap):
7345 Use ptrdiff_t, not int, for bitmap indexes.
7346 (x_allocate_bitmap_record): Check for size overflow.
7347 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7349 Use ptrdiff_t, not int, for overlay counts.
7350 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7351 * editfns.c (overlays_around, get_pos_property):
7352 * textprop.c (get_char_property_and_overlay):
7353 * xdisp.c (next_overlay_change, note_mouse_highlight):
7354 * xfaces.c (face_at_buffer_position):
7355 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7356 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7357 (Fnext_overlay_change, Fprevious_overlay_change)
7358 (mouse_face_overlay_overlaps, Foverlays_in):
7359 Use ptrdiff_t, not int, for sizes.
7360 (overlays_at, overlays_in): Check for size-calculation overflow.
7362 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7364 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7365 (x_session_initialize): Do not assume string length fits in int.
7367 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7368 This is unlikely, but can occur if DPI is outlandish.
7370 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
7371 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7373 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7374 * xrdb.c (magic_file_p, search_magic_path):
7375 Omit last arg SUFFIX; it was always 0. All callers changed.
7376 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7378 * xfont.c (xfont_match): Avoid need for strlen.
7380 * xfns.c: Don't assume strlen fits in int.
7381 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7383 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7384 not unsigned long, as we prefer signed integers. All callers changed.
7385 Detect integer overflow in repeat count.
7386 (message_dolog): Don't assume print length fits in 39 bytes.
7387 (display_mode_element): Don't assume strlen fits in int.
7389 * termcap.c: Don't assume sizes fit in int and never overflow.
7390 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7391 (gobble_line): Check for size-calculation overflow.
7393 * minibuf.c (Fread_buffer):
7394 * lread.c (intern, intern_c_string):
7395 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7396 Don't assume string length fits in int.
7398 * keyboard.c (parse_tool_bar_item):
7399 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7401 * font.c: Don't assume string length fits in int.
7402 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7403 Use ptrdiff_t, not int.
7404 (font_intern_prop): Don't assume string length fits in int.
7405 Don't assume integer property fits in fixnum.
7406 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
7408 * filelock.c: Fix some buffer overrun and integer overflow issues.
7409 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
7410 Reformulate so as not to need the command string.
7411 Invoke gzip -cd rather than gunzip, as it's more portable.
7412 (lock_info_type, lock_file_1, lock_file):
7413 Don't assume pid_t and time_t fit in unsigned long.
7414 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7415 (current_lock_owner): Prefer signed type for sizes.
7416 Use memcpy, not strncpy, where memcpy is what is really wanted.
7417 Don't assume (via atoi) that time_t and pid_t fit in int.
7418 Check for time_t and/or pid_t out of range, e.g., via a network share.
7419 Don't alloca where an auto var works fine.
7421 * fileio.c: Fix some integer overflow issues.
7422 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7423 Don't assume string length fits in int.
7424 (directory_file_name): Don't assume string length fits in long.
7425 (make_temp_name): Don't assume pid fits in int, or that its print
7426 length is less than 20.
7428 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7430 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7432 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7434 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7435 We prefer signed integers, even for size calculations.
7437 * emacs.c: Don't assume string length fits in 'int'.
7438 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7439 (main): Don't invoke strlen when not needed.
7441 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7442 (XD_DEBUG_MESSAGE): Don't waste a byte.
7444 * callproc.c (getenv_internal_1, getenv_internal)
7446 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7448 * lread.c (invalid_syntax): Omit length argument.
7449 All uses changed. This doesn't fix a bug, but it simplifies the
7450 code away from its former Hollerith-constant appearance, and it's
7451 one less 'int' to worry about when looking at integer-overflow issues.
7452 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
7454 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7455 This didn't break anything, but it didn't help either.
7456 It's confusing to put a bogus integer in a place where the actual
7457 value does not matter.
7458 (LIST_END_P): Remove unused macro and its bogus comment.
7459 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
7461 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7462 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7464 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7465 We prefer signed types, and the value cannot exceed the EMACS_INT
7466 range anyway (because otherwise the length would not be representable).
7467 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7468 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7469 This avoids a GCC warning when WIDE_EMACS_INT.
7471 * indent.c (sane_tab_width): New function.
7472 (current_column, scan_for_column, Findent_to, position_indentation)
7473 (compute_motion): Use it. This is just for clarity.
7474 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
7476 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
7478 * lisp.h (lint_assume): New macro.
7479 * composite.c (composition_gstring_put_cache):
7480 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7482 * editfns.c, insdel.c:
7483 Omit unnecessary forward decls, to simplify future changes.
7485 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7487 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7489 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
7490 Use much-faster test for byte-length change.
7491 Don't assume string byte-length fits in 'int'.
7492 Check that character arg fits in 'int'.
7493 (mapcar1): Declare byte as byte, for clarity.
7495 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7497 * fns.c (concat): Catch string overflow earlier.
7498 Do not rely on integer wraparound.
7500 * dispextern.h (struct it.overlay_strings_charpos)
7501 (struct it.selective): Now EMACS_INT, not int.
7502 * xdisp.c (forward_to_next_line_start)
7503 (back_to_previous_visible_line_start)
7504 (reseat_at_next_visible_line_start, next_element_from_buffer):
7505 Don't arbitrarily truncate the value of 'selective' to int.
7507 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7509 * composite.c: Don't truncate sizes to 'int'.
7510 (composition_gstring_p, composition_reseat_it)
7511 (composition_adjust_point): Use EMACS_INT, not int.
7512 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7513 not EMACS_UINT, for indexes.
7515 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7517 * buffer.c: Include <verify.h>.
7518 (struct sortvec.priority, struct sortstr.priority):
7519 Now EMACS_INT, not int.
7520 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
7521 (struct sortstr.size, record_overlay_string)
7522 (struct sortstrlist.size, struct sortlist.used):
7523 Don't truncate size to int.
7524 (record_overlay_string): Check for size-calculation overflow.
7525 (init_buffer_once): Check at compile-time, not run-time.
7527 2011-06-22 Jim Meyering <meyering@redhat.com>
7529 Don't leak an XBM-image-sized buffer
7530 * image.c (xbm_load): Free the image buffer after using it.
7532 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7535 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7536 that Sun C diagnosed.
7537 * fns.c (secure_hash): Fix pointer signedness issue.
7538 * intervals.c (static_offset_intervals): New function.
7539 (offset_intervals): Use it.
7541 2011-06-21 Leo Liu <sdl.web@gmail.com>
7544 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7547 * fns.c (secure_hash): Rename from crypto_hash_function and change
7548 the first arg to accept symbols.
7549 (Fsecure_hash): New primitive.
7550 (syms_of_fns): New symbols.
7552 2011-06-20 Deniz Dogan <deniz@dogan.se>
7554 * process.c (Fset_process_buffer): Clarify return value in
7557 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
7559 * dispnew.c (add_window_display_history): Use BVAR.
7561 * xdisp.c (debug_method_add): Use BVAR.
7562 (check_window_end, dump_glyph_matrix, dump_glyph)
7563 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7565 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7568 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7569 check till after the cache is created in init_frame_faces.
7571 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7573 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7575 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7577 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7578 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7579 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7581 Improve buffer-overflow checking (Bug#8873).
7582 * fileio.c (Finsert_file_contents):
7583 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7584 Remove the old (too-loose) buffer overflow checks.
7585 They weren't needed, since make_gap checks for buffer overflow.
7586 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7587 The old code merely checked for Emacs fixnum overflow, and relied
7588 on undefined (wraparound) behavior. The new code avoids undefined
7589 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7591 * editfns.c (Finsert_char): Don't dump core with very negative counts.
7592 Tune. Don't use wider integers than needed. Don't use alloca.
7593 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
7595 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7597 * insdel.c, lisp.h (buffer_overflow): New function.
7598 (insert_from_buffer_1, replace_range, replace_range_2):
7599 * insdel.c (make_gap_larger):
7600 * editfns.c (Finsert_char):
7601 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7603 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7605 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7607 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
7609 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7610 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7612 * fileio.c: Don't assume EMACS_INT fits in off_t.
7613 (emacs_lseek): New static function.
7614 (Finsert_file_contents, Fwrite_region): Use it.
7615 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7617 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7619 * fns.c: Don't overflow int when computing a list length.
7620 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7621 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7622 truncation on 64-bit hosts. Check for QUIT every
7623 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7624 faster and is responsive enough.
7625 (Flength): Report an error instead of overflowing an integer.
7626 (Fsafe_length): Return a float if the value is not representable
7627 as a fixnum. This shouldn't happen except in contrived situations.
7628 (Fnthcdr, Fsort): Don't assume list length fits in int.
7629 (Fcopy_sequence): Don't assume vector length fits in int.
7631 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7632 (header_size, word_size): New constants.
7633 (allocate_vectorlike): Don't check size overflow here.
7634 (allocate_vector): Check it here instead, since this is the only
7635 caller of allocate_vectorlike that could cause overflow.
7636 Check that the new vector's length is representable as a fixnum.
7638 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7639 The previous code was bogus. For example, next_almost_prime (32)
7640 returned 39, which is undesirable as it is a multiple of 3; and
7641 next_almost_prime (24) returned 25, which is a multiple of 5 so
7642 why was the code bothering to check for multiples of 7?
7644 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7646 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7648 Variadic C functions now count arguments with ptrdiff_t.
7649 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7650 Back then I didn't know that the Emacs coding style prefers signed int.
7651 Also, in the meantime I found a few more instances where arguments
7652 were being counted with int, which may truncate counts on 64-bit
7653 machines, or EMACS_INT, which may be unnecessarily wide.
7654 * lisp.h (struct Lisp_Subr.function.aMANY)
7655 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7656 Arg counts are now ptrdiff_t, not size_t.
7657 All variadic functions and their callers changed accordingly.
7658 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7659 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7660 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7661 * callint.c (Fcall_interactively): Check arg count for overflow,
7662 to avoid potential buffer overrun. Use signed char, not 'int',
7663 for 'varies' array, so that we needn't bother to check its size
7664 calculation for overflow.
7665 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7666 * eval.c (apply_lambda):
7667 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7668 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7669 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7671 * callint.c (Fcall_interactively): Don't use index var as event count.
7673 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7674 * mem-limits.h (SIZE): Remove; no longer used.
7676 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
7678 Remove unnecessary casts.
7679 * xterm.c (x_term_init):
7680 * xfns.c (x_set_border_pixel):
7681 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7682 These aren't needed now that we assume ANSI C.
7684 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7685 It's more likely to cause problems (due to unsigned overflow)
7688 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7690 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7692 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7694 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7696 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7698 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7700 GLYPH_CODE_FACE returns EMACS_INT, not int.
7701 * dispextern.h (merge_faces):
7702 * xfaces.c (merge_faces):
7703 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7704 Don't assume EMACS_INT fits in int.
7706 * character.h (CHAR_VALID_P): Remove unused parameter.
7707 * fontset.c, lisp.h, xdisp.c: All uses changed.
7709 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7711 * fns.c (concat): Minor tuning based on overflow analysis.
7712 This doesn't fix any bugs. Use int to hold character, instead
7713 of constantly refetching from Emacs object. Use XFASTINT, not
7714 XINT, for value known to be a character. Don't bother comparing
7715 a single byte to 0400, as it's always less.
7717 * floatfns.c (Fexpt):
7718 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7720 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7723 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7725 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7726 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7727 incorrectly succeed when S was a string, because 4294967386 was
7728 truncated before it was used.
7730 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7731 Otherwise, an out-of-range integer could cause undefined behavior
7734 * composite.c: Use int, not EMACS_INT, for characters.
7735 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7736 EMACS_INT, for values that are known to be in character range.
7737 This doesn't fix any bugs but is the usual style inside Emacs and
7738 may generate better code on 32-bit machines.
7740 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7741 This is for reasons similar to the recent CHAR_STRING fix.
7742 * charset.c (Fencode_char): Check that character arg is actually
7743 a character. Pass an int to ENCODE_CHAR.
7744 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7745 wider than 'int', as a compile-time check to prevent future regressions
7748 * character.c (char_string): Remove unnecessary casts.
7750 Make sure a 64-bit char is never passed to CHAR_STRING.
7751 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7752 by silently ignoring the top 32 bits, allowing some values
7753 that were far too large to be valid characters.
7754 * character.h: Include <verify.h>.
7755 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7756 arguments are no wider than unsigned, as a compile-time check
7757 to prevent future regressions in this area.
7759 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
7760 (Fsubst_char_in_region):
7762 * xdisp.c (decode_mode_spec_coding):
7763 Adjust to CHAR_STRING's new requirement.
7764 * editfns.c (Finsert_char, Fsubst_char_in_region):
7765 * fns.c (concat): Check that character args are actually
7766 characters. Without this test, these functions did the wrong
7767 thing with wildly out-of-range values on 64-bit hosts.
7769 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7770 These casts should not be needed on 32-bit hosts, either.
7771 * keyboard.c (read_char):
7772 * lread.c (Fload): Remove casts to unsigned.
7774 * lisp.h (UNSIGNED_CMP): New macro.
7775 This fixes comparison bugs on 64-bit hosts.
7776 (ASCII_CHAR_P): Use it.
7777 * casefiddle.c (casify_object):
7778 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
7779 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7780 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7781 * dispextern.h (FACE_FROM_ID):
7782 * keyboard.c (read_char): Use UNSIGNED_CMP.
7784 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7785 not to EMACS_INT, to avoid GCC warning.
7787 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7789 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7790 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7791 isn't needed on 32-bit machines.
7793 * buffer.c (Fgenerate_new_buffer_name):
7794 Use EMACS_INT for count, not int.
7795 (advance_to_char_boundary): Return EMACS_INT, not int.
7797 * data.c (Qcompiled_function): Now static.
7799 * window.c (window_body_lines): Now static.
7801 * image.c (gif_load): Rename local to avoid shadowing.
7803 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7804 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7805 * alloc.c (make_save_value): Integer argument is now of type
7807 (mark_object): Use ptrdiff_t, not int.
7808 * lisp.h (pD): New macro.
7809 * print.c (print_object): Use it.
7811 * alloc.c: Use EMACS_INT, not int, to count objects.
7812 (total_conses, total_markers, total_symbols, total_vector_size)
7813 (total_free_conses, total_free_markers, total_free_symbols)
7814 (total_free_floats, total_floats, total_free_intervals)
7815 (total_intervals, total_strings, total_free_strings):
7816 Now EMACS_INT, not int. All uses changed.
7817 (Fgarbage_collect): Compute overall total using a double, so that
7818 integer overflow is less likely to be a problem. Check for overflow
7819 when converting back to an integer.
7820 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7821 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7822 These were 'int' variables that could overflow on 64-bit hosts;
7823 they were never used, so remove them instead of repairing them.
7824 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
7825 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7826 Previously, this ceilinged at INT_MAX, but that doesn't work on
7828 (allocate_pseudovector): Don't use EMACS_INT when int would do.
7830 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
7831 (allocate_vectorlike): Check for ptrdiff_t overflow.
7832 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7833 when a (possibly-narrower) signed value would do just as well.
7834 We prefer using signed arithmetic, to avoid comparison confusion.
7836 * alloc.c: Catch some string size overflows that we were missing.
7837 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7838 for convenience in STRING_BYTES_MAX.
7839 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7840 The definition here is exact; the one in lisp.h was approximate.
7841 (allocate_string_data): Check for string overflow. This catches
7842 some instances we weren't catching before. Also, it catches
7843 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7844 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7845 and ptrdiff_t and EMACS_INT are both 64 bits.
7847 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7848 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
7849 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
7851 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7853 * alloc.c (Fmake_string): Check for out-of-range init.
7855 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7857 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7859 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7861 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7862 xg_get_default_scrollbar_width.
7864 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7865 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7866 (style_changed_cb): Call update_theme_scrollbar_width and call
7867 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7868 all frames (Bug#8505).
7869 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7870 Call gtk_window_set_resizable if HAVE_GTK3.
7871 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7872 and height if HAVE_GTK3 (Bug#8505).
7873 (scroll_bar_width_for_theme): New variable.
7874 (update_theme_scrollbar_width): New function.
7875 (xg_get_default_scrollbar_width): Move code to
7876 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7877 (xg_initialize): Call update_theme_scrollbar_width.
7879 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7881 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7883 2011-06-12 Martin Rudalics <rudalics@gmx.at>
7885 * frame.c (make_frame): Call other_buffer_safely instead of
7888 * window.c (temp_output_buffer_show): Call display_buffer with
7889 second argument Vtemp_buffer_show_specifiers and reset latter
7890 immediately after the call.
7891 (Vtemp_buffer_show_specifiers): New variable.
7892 (auto_window_vscroll_p, next_screen_context_lines)
7893 (Vscroll_preserve_screen_position): Remove leading asterisks from
7896 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
7898 Fix minor problems found by GCC 4.6.0 static checking.
7899 * buffer.c (Qclone_number): Remove for now, as it's unused.
7900 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7901 (record_buffer): Remove unused local.
7902 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7903 (set_frame_buffer_list): Remove; unused.
7904 * frame.h (other_visible_frames): Remove decl.
7905 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7906 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7907 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7909 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7910 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7911 Define only if HAVE_GPM.
7912 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7913 (update_hints_inhibit): Remove; never set. All uses removed.
7914 * widgetprv.h (emacsFrameClassRec): Remove decl.
7915 * window.c (delete_deletable_window): Now returns void, since it
7916 wasn't returning anything.
7917 (compare_window_configurations): Remove unused locals.
7918 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7919 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
7920 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7921 the same widths as pointers. This follows up on the 2011-05-06 patch.
7922 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7923 * xterm.h: Likewise.
7924 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7926 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
7928 * makefile.w32-in: Update dependencies.
7929 (LISP_H): Add lib/intprops.h.
7931 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7933 * image.c (gif_load): Add animation frame delay to the metadata.
7934 (syms_of_image): Use DEFSYM. New symbol `delay'.
7936 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7938 * window.c (delete_deletable_window): Re-add.
7939 (Fset_window_configuration): Rewrite to handle dead buffers and
7940 consequently deletable windows.
7941 (window_tree, Fwindow_tree): Remove. Supply functionality in
7943 (compare_window_configurations): Simplify code.
7945 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7947 * image.c (imagemagick_load_image): Fix type mismatch.
7948 (Fimagemagick_types): Likewise.
7950 * window.h (replace_buffer_in_windows): Declare.
7952 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7954 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7955 Qclone_number. Remove external declaration of Qdelete_window.
7956 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7958 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7959 Run Qbuffer_list_update_hook if allowed.
7960 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7961 buffer list implementation.
7962 (other_buffer_safely): New function.
7963 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7964 calls to replace_buffer_in_windows and
7965 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7967 (record_buffer): Inhibit quitting and rewrite using quittable
7968 functions. Run Qbuffer_list_update_hook if allowed.
7969 (Frecord_buffer, Funrecord_buffer): New functions.
7970 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7971 Move switch-to-buffer to window.el.
7972 (bury-buffer): Move to window.el.
7973 (Vbuffer_list_update_hook): New variable.
7975 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7978 * window.h (resize_frame_windows): Move up in code.
7979 (Fwindow_frame): Remove EXFUN.
7980 (replace_buffer_in_all_windows): Remove prototype.
7981 (replace_buffer_in_windows_safely): Add prototype.
7983 * window.c: Declare Qdelete_window static again. Move down
7984 declaration of select_count.
7985 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7986 (Fother_window): Move to window.el.
7987 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7988 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7989 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7991 (replace_buffer_in_windows): Implement by calling
7992 Qreplace_buffer_in_windows.
7993 (replace_buffer_in_all_windows): Remove with some functionality
7994 moved into replace_buffer_in_windows_safely.
7995 (replace_buffer_in_windows_safely): New function.
7996 (select_window_norecord, select_frame_norecord): Move in front
7997 of run_window_configuration_change_hook. Remove now obsolete
7999 (Fset_window_buffer): Rewrite doc-string.
8000 Call Qrecord_window_buffer.
8001 (keys_of_window): Move binding for other-window to window.el.
8003 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8005 * dispextern.h (struct image): Replace data member, whose int_val
8006 and ptr_val fields were not used by anything, with a single
8009 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8010 (gif_clear_image, gif_load, imagemagick_load_image)
8011 (gs_clear_image, gs_load): Callers changed.
8013 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8015 * buffer.h: Include <time.h>, for time_t.
8016 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8018 Fix minor problems found by static checking.
8020 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8022 Make identifiers static if they are not used in other modules.
8023 * data.c (Qcompiled_function, Qframe, Qvector):
8024 * image.c (QimageMagick, Qsvg):
8025 * minibuf.c (Qmetadata):
8026 * window.c (resize_window_check, resize_root_window): Now static.
8027 * window.h (resize_window_check, resize_root_window): Remove decls.
8029 * window.c (window_deletion_count, delete_deletable_window):
8031 (window_body_lines): Now static.
8032 (Fdelete_other_windows_internal): Mark vars as initialized.
8033 Make sure 'resize_failed' is initialized.
8034 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8035 (resize_window_apply): Remove unused local.
8036 * window.h (delete_deletable_window): Remove decl.
8038 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
8039 (imagemagick_load_image): Fix pointer signedness problem by changing
8040 last arg from unsigned char * to char *. All uses changed.
8041 Also, fix a local for similar reasons.
8042 Remove unused locals. Remove locals to avoid shadowing.
8043 (fn_rsvg_handle_free): Remove; unused.
8044 (svg_load, svg_load_image): Fix pointer signedness problem.
8045 (imagemagick_load_image): Don't use garbage pointer image_wand.
8047 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8049 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
8051 * image.c (gif_load): Fix omitted cast error introduced by
8054 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8056 * window.h (resize_proportionally, orig_total_lines)
8057 (orig_top_line): Remove from window structure.
8058 (set_window_height, set_window_width, change_window_heights)
8059 (Fdelete_window): Remove prototypes.
8060 (resize_frame_windows): Remove duplicate declaration.
8062 2011-06-10 Eli Zaretskii <eliz@gnu.org>
8064 * window.h (resize_frame_windows, resize_window_check)
8065 (delete_deletable_window, resize_root_window)
8066 (resize_frame_windows): Declare prototypes.
8068 * window.c (resize_window_apply): Make definition be "static" to
8069 match the prototype.
8071 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8073 * window.c: Remove declarations of Qwindow_size_fixed,
8074 window_min_size_1, window_min_size_2, window_min_size,
8075 size_window, window_fixed_size_p, enlarge_window, delete_window.
8076 Remove static from declaration of Qdelete_window, it's
8077 temporarily needed by Fbury_buffer.
8078 (replace_window): Don't assign orig_top_line and
8080 (Fdelete_window, delete_window): Remove. Window deletion is
8081 handled by window.el.
8082 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8083 Replace Fdelete_window calls with calls to Qdelete_window.
8084 (Fdelete_other_windows): Remove. Deleting other windows is
8085 handled by window.el.
8086 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8087 handled in window.el.
8088 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8089 Window minimum sizes are handled in window.el.
8090 (shrink_windows, size_window, set_window_height)
8091 (set_window_width, change_window_heights, window_height)
8092 (window_width, CURBEG, CURSIZE, enlarge_window)
8093 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8094 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8095 handled in window.el.
8096 (make_dummy_parent): Rename to make_parent_window and give it a
8097 second argument horflag.
8098 (make_window): Don't set resize_proportionally any more.
8099 (Fsplit_window): Remove. Windows are split in window.el.
8100 (save_restore_action, save_restore_orig_size)
8101 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8102 Resize mini windows in window.el.
8103 (grow_mini_window, shrink_mini_window): Implement by calling
8104 Qresize_root_window_vertically, resize_window_check and
8105 resize_window_apply.
8106 (saved_window, Fset_window_configuration, save_window_save):
8107 Do not handle orig_top_line, orig_total_lines, and
8108 resize_proportionally.
8109 (window_min_height, window_min_width): Move to window.el.
8110 (keys_of_window): Move bindings for delete-other-windows,
8111 split-window, delete-window and enlarge-window to window.el.
8113 * buffer.c: Temporarily extern Qdelete_window.
8114 (Fbury_buffer): Temporarily call Qdelete_window instead of
8115 Fdelete_window (Fbury_buffer will move to window.el soon).
8117 * frame.c (set_menu_bar_lines_1): Remove code handling
8118 orig_top_line and orig_total_lines.
8120 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8121 set_window_height but set heights directly.
8122 (change_frame_size_1): Use resize_frame_windows.
8124 * xdisp.c (init_xdisp): Don't use set_window_height but set
8127 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8128 Use resize_frame_windows instead of change_window_heights and run
8129 run_window_configuration_change_hook.
8131 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8132 instead of change_window_heights and run
8133 run_window_configuration_change_hook.
8135 2011-06-09 Martin Rudalics <rudalics@gmx.at>
8137 * window.c (replace_window): Rename second argument REPLACEMENT to
8138 NEW. New third argument SETFLAG. Rewrite.
8139 (delete_window, make_dummy_parent): Call replace_window with
8141 (window_list_1): Move down in code.
8142 (run_window_configuration_change_hook): Move set_buffer part
8143 before select_frame_norecord part in order to unwind correctly.
8144 Rename count1 to count.
8145 (recombine_windows, delete_deletable_window, resize_root_window)
8146 (Fdelete_other_windows_internal)
8147 (Frun_window_configuration_change_hook, make_parent_window)
8148 (resize_window_check, resize_window_apply, Fresize_window_apply)
8149 (resize_frame_windows, Fsplit_window_internal)
8150 (Fdelete_window_internal, Fresize_mini_window_internal):
8152 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8154 2011-06-08 Martin Rudalics <rudalics@gmx.at>
8156 * window.h (window): Add some new members to window structure -
8157 normal_lines, normal_cols, new_total, new_normal, clone_number,
8158 splits, nest, prev_buffers, next_buffers.
8159 (WINDOW_TOTAL_SIZE): Move here from window.c.
8160 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
8162 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8164 (make_dummy_parent): Set new members of windows structure.
8165 (make_window): Move down in code. Handle new members of window
8167 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8168 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8169 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8170 (Fset_window_prev_buffers, Fwindow_next_buffers)
8171 (Fset_window_next_buffers, Fset_window_clone_number):
8173 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8174 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8176 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8177 Argument WINDOW can be now internal window too.
8178 (Fwindow_use_time): Move up in code.
8179 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8181 (Fset_window_configuration, saved_window)
8182 (Fcurrent_window_configuration, save_window_save): Handle new
8183 members of window structure.
8184 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8185 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8186 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8187 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8188 Qget_mru_window, Qresize_root_window,
8189 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8190 Qauto_buffer_name; staticpro them.
8192 2011-06-07 Martin Rudalics <rudalics@gmx.at>
8194 * window.c (Fwindow_total_size, Fwindow_left_column)
8195 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8196 (Fwindow_list_1): New functions.
8197 (window_box_text_cols): Replace with window_body_cols.
8198 (Fwindow_width, Fscroll_left, Fscroll_right):
8199 Use window_body_cols instead of window_box_text_cols.
8200 (delete_window, Fset_window_configuration):
8201 Call delete_all_subwindows with window as argument.
8202 (delete_all_subwindows): Take a window as argument and not a
8204 (window_loop): Remove handling of GET_LRU_WINDOW and
8206 (Fget_lru_window, Fget_largest_window): Move to window.el.
8208 * window.h: Extern window_body_cols instead of
8209 window_box_text_cols. delete_all_subwindows now takes a
8210 Lisp_Object as argument.
8212 * indent.c (compute_motion, Fcompute_motion):
8213 Use window_body_cols instead of window_box_text_cols.
8215 * frame.c (delete_frame): Call delete_all_subwindows with root
8218 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8220 * fns.c (Fputhash): Document return value.
8222 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
8224 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8226 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8228 Cons<->int and similar integer overflow fixes (Bug#8794).
8230 Check for overflow when converting integer to cons and back.
8231 * charset.c (Fdefine_charset_internal, Fdecode_char):
8232 Use cons_to_unsigned to catch overflow.
8233 (Fencode_char): Use INTEGER_TO_CONS.
8234 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8235 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8236 * data.c (long_to_cons, cons_to_long): Remove.
8237 (cons_to_unsigned, cons_to_signed): New functions.
8238 These signal an error for invalid or out-of-range values.
8239 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8240 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8241 * font.c (Ffont_variation_glyphs):
8242 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8243 * lisp.h: Include <intprops.h>.
8244 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8245 (cons_to_signed, cons_to_unsigned): New decls.
8246 (long_to_cons, cons_to_long): Remove decls.
8247 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8248 (Fprimitive_undo): Use CONS_TO_INTEGER.
8249 * xfns.c (Fx_window_property): Likewise.
8250 * xselect.c: Include <limits.h>.
8251 (x_own_selection, selection_data_to_lisp_data):
8252 Use INTEGER_TO_CONS.
8253 (x_handle_selection_request, x_handle_selection_clear)
8254 (x_get_foreign_selection, Fx_disown_selection_internal)
8255 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8256 (lisp_data_to_selection_data): Use cons_to_unsigned.
8257 (x_fill_property_data): Use cons_to_signed.
8258 Report values out of range.
8260 Check for buffer and string overflow more precisely.
8261 * buffer.h (BUF_BYTES_MAX): New macro.
8262 * lisp.h (STRING_BYTES_MAX): New macro.
8263 * alloc.c (Fmake_string):
8264 * character.c (string_escape_byte8):
8265 * coding.c (coding_alloc_by_realloc):
8266 * doprnt.c (doprnt):
8267 * editfns.c (Fformat):
8269 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8270 since they may not be the same number.
8271 * editfns.c (Finsert_char):
8272 * fileio.c (Finsert_file_contents):
8273 Likewise for BUF_BYTES_MAX.
8275 * image.c: Use ptrdiff_t, not int, for sizes.
8276 (slurp_file): Switch from int to ptrdiff_t.
8278 (slurp_file): Check that file size fits in both size_t (for
8279 malloc) and ptrdiff_t (for sanity and safety).
8281 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8282 if b->modtime has its maximal value.
8284 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8286 Don't assume time_t can fit into int.
8287 * buffer.h (struct buffer.modtime): Now time_t, not int.
8288 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8289 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8291 Minor fixes for signed vs unsigned integers.
8292 * character.h (MAYBE_UNIFY_CHAR):
8293 * charset.c (maybe_unify_char):
8294 * keyboard.c (read_char, reorder_modifiers):
8295 XINT -> XFASTINT, since the integer must be nonnegative.
8296 * ftfont.c (ftfont_spec_pattern):
8297 * keymap.c (access_keymap, silly_event_symbol_error):
8298 XUINT -> XFASTINT, since the integer must be nonnegative.
8299 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8300 since it makes no difference and we prefer signed.
8301 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8302 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8305 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8307 * window.h (Fwindow_frame): Declare.
8309 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8311 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8312 (SPARE_MEMORY): Always define.
8313 (LARGE_REQUEST): Remove.
8314 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8316 2011-06-06 Martin Rudalics <rudalics@gmx.at>
8318 * lisp.h: Move EXFUNS for Fframe_root_window,
8319 Fframe_first_window and Fset_frame_selected_window to window.h.
8321 * window.h: Move EXFUNS for Fframe_root_window,
8322 Fframe_first_window and Fset_frame_selected_window here from
8325 * frame.c (Fwindow_frame, Fframe_first_window)
8326 (Fframe_root_window, Fframe_selected_window)
8327 (Fset_frame_selected_window): Move to window.c.
8328 (Factive_minibuffer_window): Move to minibuf.c.
8329 (Fother_visible_frames_p): New function.
8331 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8333 * window.c (decode_window, decode_any_window): Move up in code.
8334 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8335 (inhibit_frame_unsplittable): Remove unused variable.
8336 (Fwindow_buffer): Move up and rewrite doc-string.
8337 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8338 (Fwindow_prev): New functions.
8339 (Fwindow_frame): Move here from frame.c. Accept any window as
8341 (Fframe_root_window, Fframe_first_window)
8342 (Fframe_selected_window): Move here from frame.c. Accept frame
8343 or arbitrary window as argument. Update doc-strings.
8344 (Fminibuffer_window): Move up in code.
8345 (Fwindow_minibuffer_p): Move up in code and simplify.
8346 (Fset_frame_selected_window): Move here from frame.c.
8348 (Fselected_window, select_window, Fselect_window): Move up in
8349 code. Minor doc-string fixes.
8351 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8353 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8354 Do not assume that spare memory exists; that assumption is valid
8355 only if SYSTEM_MALLOC.
8356 (LARGE_REQUEST): New macro, so that the issue of large requests
8357 is separated from the issue of spare memory.
8359 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8361 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8364 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8366 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8369 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8371 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8373 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8375 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8376 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8378 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
8380 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8382 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
8384 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8385 (x_clipboard_manager_save): Add return value.
8386 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8388 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8389 Obey Vx_select_enable_clipboard_manager. Catch errors in
8390 x_clipboard_manager_save (Bug#8779).
8391 (Vx_select_enable_clipboard_manager): New variable.
8392 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
8394 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8396 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8398 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8400 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8401 in the current matrix if keep_current_p is non-zero.
8403 2011-06-04 Eli Zaretskii <eliz@gnu.org>
8405 * bidi.c (bidi_level_of_next_char): Fix last change.
8407 2011-06-03 Eli Zaretskii <eliz@gnu.org>
8409 Support bidi reordering of text covered by display properties.
8411 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8412 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8413 (bidi_cache_search, bidi_cache_iterator_state)
8414 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
8415 (bidi_level_of_next_char, bidi_move_to_visually_next):
8416 Support character positions inside a run of characters covered by a
8418 (bidi_paragraph_init, bidi_resolve_explicit_1)
8419 (bidi_level_of_next_char): Call bidi_fetch_char and
8420 bidi_fetch_char_advance instead of FETCH_CHAR and
8422 (bidi_init_it): Initialize new members.
8423 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8425 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8426 instead of using explicit *_CHAR codes.
8427 (bidi_resolve_explicit, bidi_resolve_weak):
8428 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
8429 bidirectional text is supported only in multibyte buffers.
8430 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8431 it to initialize the frame_window_p member of struct bidi_it.
8432 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8433 (bidi_resolve_explicit, bidi_resolve_weak)
8434 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8435 bidi_it->nchars is non-positive.
8436 (bidi_level_of_next_char): Don't try to lookup the cache for the
8437 next/previous character if nothing is cached there yet, or if we
8438 were just reseat()'ed to a new position.
8440 * xdisp.c (set_cursor_from_row): Set start and stop points
8441 according to the row's direction when priming the loop that looks
8442 for the glyph on which to display cursor.
8443 (single_display_spec_intangible_p): Function deleted.
8444 (display_prop_intangible_p): Reimplement to call
8445 handle_display_spec instead of single_display_spec_intangible_p.
8446 Accept 3 additional arguments needed by handle_display_spec.
8447 This fixes incorrect cursor motion across display property with complex
8448 values: lists, `(when COND...)' forms, etc.
8449 (single_display_spec_string_p): Support property values that are
8450 lists with the argument STRING its top-level element.
8451 (display_prop_string_p): Fix the condition for processing a
8452 property that is a list to be consistent with handle_display_spec.
8453 (handle_display_spec): New function, refactored from the
8454 last portion of handle_display_prop.
8455 (compute_display_string_pos): Accept additional argument
8456 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8457 value of a `display' property is a "replacing spec".
8458 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8459 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8460 the display property, but just return a value indicating whether
8461 the display property will replace the characters it covers.
8462 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8463 frame_window_p members of struct bidi_it.
8464 (compute_display_string_pos, compute_display_string_end):
8466 (push_it): Accept second argument POSITION, where pop_it should
8467 jump to continue iteration.
8468 (reseat_1): Initialize bidi_it.disp_pos.
8470 * keyboard.c (adjust_point_for_property): Adjust the call to
8471 display_prop_intangible_p to its new signature.
8473 * dispextern.h (struct bidi_it): New member frame_window_p.
8474 (bidi_init_it): Update prototypes.
8475 (display_prop_intangible_p): Update prototype.
8476 (compute_display_string_pos, compute_display_string_end):
8478 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8481 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
8483 Malloc failure behavior now depends on size of allocation.
8484 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8485 * lisp.h: Change signatures accordingly.
8486 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8487 All callers changed. (Bug#8762)
8489 * gnutls.c: Use Emacs's memory allocators.
8490 Without this change, the gnutls library would invoke malloc etc.
8491 directly, which causes problems on non-SYNC_INPUT hosts, and which
8492 runs afoul of improving memory_full behavior. (Bug#8761)
8493 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8494 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8495 xfree instead of the default malloc, realloc, free.
8496 (Fgnutls_boot): No need to check for memory allocation failure,
8497 since xmalloc does that for us.
8499 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
8500 * category.c (hash_get_category_set):
8501 * ccl.c (ccl_driver):
8502 * charset.c (Fdefine_charset_internal):
8503 * charset.h (struct charset.hash_index):
8504 * composite.c (get_composition_id, gstring_lookup_cache)
8505 (composition_gstring_put_cache):
8506 * composite.h (struct composition.hash_index):
8507 * dispextern.h (struct image.hash):
8508 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8509 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8510 (hashfn_equal, hashfn_user_defined, make_hash_table)
8511 (maybe_resize_hash_table, hash_lookup, hash_put)
8512 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8513 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8514 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8515 * image.c (make_image, search_image_cache, lookup_image)
8516 (xpm_put_color_table_h):
8517 * lisp.h (struct Lisp_Hash_Table):
8518 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
8519 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
8520 for hashes and hash indexes, instead of 'unsigned' and 'int'.
8521 * alloc.c (allocate_vectorlike):
8522 Check for overflow in vector size calculations.
8523 * ccl.c (ccl_driver):
8524 Check for overflow when converting EMACS_INT to int.
8525 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8526 need to be updated by these changes.
8527 * fns.c (make_hash_table, maybe_resize_hash_table):
8528 Check for integer overflow with large hash tables.
8529 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8530 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8531 (SXHASH_REDUCE): New macro.
8532 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8533 Use it instead of discarding useful hash info with large hash values.
8534 (sxhash_float): New function.
8535 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8536 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
8537 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8538 Rewrite to use FIXNUM_BITS, as this simplifies things.
8539 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8540 Adjust signatures to match updated version of code.
8541 (consing_since_gc): Now EMACS_INT, since a single hash table can
8542 use more than INT_MAX bytes.
8544 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8546 Make it possible to build with GCC-4.6+ -O2 -flto.
8548 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8550 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8552 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8553 Call minibuffer-inactive-mode.
8555 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
8557 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8558 Update dependencies.
8560 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8562 * data.c (init_data): Remove code for UTS, this system is not
8565 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8567 Don't force ./temacs to start in terminal mode.
8569 * frame.c (make_initial_frame): Initialize faces in all cases, not
8570 only when CANNOT_DUMP is defined.
8571 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8573 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8575 * dispnew.c (add_window_display_history): Use const for the string
8576 pointer. Remove declaration, not needed.
8578 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8580 Use 'inline', not 'INLINE'.
8581 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
8582 * alloc.c, fontset.c (INLINE): Remove.
8583 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8584 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8585 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8586 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8587 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8589 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8591 Make it possible to run ./temacs.
8593 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8594 syms_of_callproc does the same thing. Remove test for
8595 "initialized", do it in the caller.
8596 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8598 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8600 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8601 (read_minibuf): Use get_minibuffer.
8602 (syms_of_minibuf): Use DEFSYM.
8603 (Qmetadata): New var.
8604 * data.c (Qbuffer): Don't make it static.
8605 (syms_of_data): Use DEFSYM.
8607 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8609 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8610 (CCL_CODE_MIN): New macro.
8612 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8614 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8616 * eval.c (Qdebug): Now static.
8617 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8618 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8619 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8621 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8623 * image.c: Various fixes to ImageMagick code comments.
8624 (Fimagemagick_types): Doc fix.
8626 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8628 Minor fixes prompted by GCC 4.6.0 warnings.
8630 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8632 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8633 (x_clipboard_manager_save_all): Move extern decl to ...
8634 * xterm.h: ... here, so that it can be checked for consistency.
8636 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8638 * xselect.c (x_clipboard_manager_save_frame)
8639 (x_clipboard_manager_save_all): New functions.
8640 (Fx_clipboard_manager_save): Lisp function deleted.
8642 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8643 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8645 * xterm.h: Update prototype.
8647 2011-05-28 William Xu <william.xwl@gmail.com>
8649 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8652 2011-05-28 Jim Meyering <meyering@redhat.com>
8654 Avoid a sign-extension bug in crypto_hash_function.
8655 * fns.c (to_uchar): Define.
8656 (crypto_hash_function): Use it to convert some newly-signed
8657 variables to unsigned, to avoid sign-extension bugs. For example,
8658 without this change, (md5 "truc") would evaluate to
8659 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8660 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
8661 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
8663 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8665 Integer overflow fixes.
8667 * dbusbind.c: Serial number integer overflow fixes.
8668 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
8669 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8670 to hold a serial number that is too large for a fixnum.
8671 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8672 Check for serial numbers out of range. Decode any serial number
8673 that was so large that it became a float. (Bug#8722)
8675 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8676 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8677 Use XFASTINT rather than XUINT when numbers are nonnegative.
8678 (xd_append_arg, Fdbus_method_return_internal):
8679 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8680 arguments, check that Lisp number is nonnegative, rather than
8681 silently wrapping negative numbers around. (Bug#8722)
8682 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
8685 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8687 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8689 ccl: Add integer overflow checks.
8690 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8691 (IN_INT_RANGE): New macros.
8692 (ccl_driver): Use them to check for integer overflow when
8693 decoding a CCL program. Many of the new checks are whether XINT (x)
8694 fits in int; it doesn't always, on 64-bit hosts. The new version
8695 doesn't catch all possible integer overflows, but it's an
8696 improvement. (Bug#8719)
8698 * alloc.c (make_event_array): Use XINT, not XUINT.
8699 There's no need for unsigned here.
8701 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8702 This follows up to the 2011-05-06 change that substituted uintptr_t
8703 for EMACS_INT. This case wasn't caught back then.
8705 Rework Fformat to avoid integer overflow issues.
8706 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8707 now (part of C89). Include <verify.h>.
8708 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8709 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8710 (Fformat): Avoid the prepass trying to compute sizes; it was only
8711 approximate and thus did not catch overflow reliably. Instead, walk
8712 through the format just once, formatting and computing sizes as we go,
8713 checking for integer overflow at every step, and allocating a larger
8714 buffer as needed. Keep track separately whether the format is
8715 multibyte. Keep only the most-recently calculated precision, rather
8716 than them all. Record whether each argument has been converted to
8717 string. Use EMACS_INT, not int, for byte and char and arg counts.
8718 Support field widths and precisions larger than INT_MAX. Avoid
8719 sprintf's undefined behavior with conversion specifications such as %#d
8720 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8721 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8722 formatting out-of-range floating point numbers with int
8725 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8727 * data.c: Avoid integer truncation in expressions involving floats.
8728 * data.c: Include <intprops.h>.
8729 (arith_driver): When there's an integer overflow in an expression
8730 involving floating point, convert the integers to floating point
8731 so that the resulting value does not suffer from catastrophic
8732 integer truncation. For example, on a 64-bit host (* 4
8733 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8734 Do not rely on undefined behavior after integer overflow.
8736 merge count_size_as_multibyte, parse_str_to_multibyte
8737 * character.c, character.h (count_size_as_multibyte):
8738 Rename from parse_str_to_multibyte; all uses changed.
8739 Check for integer overflow.
8740 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8741 since it's now a duplicate of the other. This is more of
8742 a character than a buffer op, so better that it's in character.c.
8743 * fns.c, print.c: Adjust to above changes.
8745 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8747 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8749 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8751 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8752 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8753 (x_clipboard_manager_save): Now static.
8754 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8756 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8757 (crypto_hash_function): Now static.
8758 Fix pointer signedness problems. Avoid unnecessary initializations.
8760 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
8762 * termhooks.h (Vselection_alist): Make it terminal-local.
8764 * terminal.c (create_terminal): Initialize it.
8766 * xselect.c: Support for clipboard managers.
8767 (Vselection_alist): Move to termhooks.h as terminal-local var.
8768 (LOCAL_SELECTION): New macro.
8769 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8770 (symbol_to_x_atom): Remove gratuitous arg.
8771 (x_handle_selection_request, lisp_data_to_selection_data)
8772 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
8773 (x_own_selection, x_get_local_selection, x_convert_selection):
8774 New arg, specifying work frame. Use terminal-local Vselection_alist.
8775 (some_frame_on_display): Delete unused function.
8776 (Fx_own_selection_internal, Fx_get_selection_internal)
8777 (Fx_disown_selection_internal, Fx_selection_owner_p)
8778 (Fx_selection_exists_p): New optional frame arg.
8779 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8780 (x_handle_selection_clear): Don't treat other terminals with the
8781 same keyboard specially. Use the terminal-local Vselection_alist.
8782 (x_clear_frame_selections): Use Frun_hook_with_args.
8784 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8786 * xterm.h: Add support for those atoms.
8788 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
8790 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8791 (converted_selections, conversion_fail_tag): New global variables.
8792 (x_selection_request_lisp_error): Free the above.
8793 (x_get_local_selection): Remove unnecessary code.
8794 (x_reply_selection_request): Args changed; handle arbitrary array
8795 of converted selections stored in converted_selections.
8796 Separate the XChangeProperty and SelectionNotify steps.
8797 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8798 (x_convert_selection): New function.
8799 (x_handle_selection_event): Simplify.
8800 (x_get_foreign_selection): Don't ignore incoming requests while
8801 waiting for an answer; this will fail when we implement
8802 SAVE_TARGETS, and seems unnecessary anyway.
8803 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8804 (Vx_sent_selection_functions): Doc fix.
8806 2011-05-26 Leo Liu <sdl.web@gmail.com>
8808 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8810 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8812 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8814 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8815 for fringe update if it has periodic bitmap.
8816 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
8817 and fringe_bitmap_periodic_p.
8819 * fringe.c (get_fringe_bitmap_data): New function.
8820 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8821 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8822 row. Mark glyph row for fringe update if periodicity changed.
8824 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8825 for fringe update unless it has periodic bitmap.
8827 2011-05-25 Kenichi Handa <handa@m17n.org>
8829 * xdisp.c (get_next_display_element): Set correct it->face_id for
8830 a static composition.
8832 2011-05-24 Leo Liu <sdl.web@gmail.com>
8835 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8837 * fns.c (crypto_hash_function, Fsha1): New function.
8838 (Fmd5): Use crypto_hash_function.
8839 (syms_of_fns): Add Ssha1.
8841 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8843 * gnutls.c: Remove unused macros.
8844 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8845 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8846 Remove macros that are defined and never used.
8847 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8849 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8851 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8852 (Fx_get_selection_internal): Minor cleanup.
8853 (Fx_own_selection_internal): Rename arguments for consistency with
8856 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8858 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8860 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8862 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8864 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8866 * dispnew.c (scrolling_window): Don't exclude the case that the
8867 last enabled row in the desired matrix touches the bottom boundary.
8869 2011-05-21 Glenn Morris <rgm@gnu.org>
8871 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
8872 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8873 and add some more files.
8875 2011-05-20 Eli Zaretskii <eliz@gnu.org>
8877 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8878 report_file_error introduced by the change from 2011-05-07.
8880 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8882 * systime.h (Time): Define only if emacs is defined.
8883 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8884 where the include path doesn't have X11/X.h by default. See
8885 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8887 2011-05-20 Kenichi Handa <handa@m17n.org>
8889 * composite.c (find_automatic_composition): Fix previous change.
8891 2011-05-20 Glenn Morris <rgm@gnu.org>
8893 * lisp.mk: New file, split from Makefile.in.
8894 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8895 (shortlisp): Remove.
8896 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8898 2011-05-19 Glenn Morris <rgm@gnu.org>
8900 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8901 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8902 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8903 (lisp): Set the order to that of loadup.el.
8904 (shortlisp): Make it a copy of $lisp.
8905 (SOME_MACHINE_LISP): Remove.
8906 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8907 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8909 2011-05-18 Kenichi Handa <handa@m17n.org>
8911 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8912 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8913 (find_automatic_composition): Mostly rewrite for efficiency.
8915 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
8917 * makefile.w32-in: Update dependencies.
8919 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8921 * menu.c: Include limits.h (fixes the MS-Windows build broken by
8922 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8924 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
8926 Fix some integer overflow issues, such as string length overflow.
8928 * insdel.c (count_size_as_multibyte): Check for string overflow.
8930 * character.c (lisp_string_width): Check for string overflow.
8931 Use EMACS_INT, not int, for string indexes and lengths; in
8932 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8933 the resulting string length overflows an EMACS_INT; instead,
8934 report a string overflow if no precision given. When checking for
8935 precision exhaustion, use a check that cannot possibly have
8936 integer overflow. (Bug#8675)
8937 * character.h (lisp_string_width): Adjust to new signature.
8939 * alloc.c (string_overflow): New function.
8940 (Fmake_string): Use it. This doesn't change behavior, but saves
8941 a few bytes and will simplify future changes.
8942 * character.c (string_escape_byte8): Likewise.
8943 * lisp.h (string_overflow): New decl.
8945 Fixups, following up to the user-interface timestamp change.
8946 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8947 for UI timestamps, instead of unsigned long.
8948 * msdos.c (mouse_get_pos): Likewise.
8949 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
8950 * w32gui.h (Time): Define by including "systime.h" rather than by
8951 declaring it ourselves. (Bug#8664)
8953 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8954 * image.c (clear_image_cache): Likewise.
8956 * term.c (term_mouse_position): Don't assume time_t wraparound.
8958 Be more systematic about user-interface timestamps.
8959 Before, the code sometimes used 'Time', sometimes 'unsigned long',
8960 and sometimes 'EMACS_UINT', to represent these timestamps.
8961 This change causes it to use 'Time' uniformly, as that's what X uses.
8962 This makes the code easier to follow, and makes it easier to catch
8963 integer overflow bugs such as Bug#8664.
8964 * frame.c (Fmouse_position, Fmouse_pixel_position):
8965 Use Time, not unsigned long, for user-interface timestamps.
8966 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8967 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8968 * keyboard.h (last_event_timestamp): Likewise.
8969 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8970 * menu.h (xmenu_show): Likewise.
8971 * term.c (term_mouse_position): Likewise.
8972 * termhooks.h (struct input_event.timestamp): Likewise.
8973 (struct terminal.mouse_position_hook): Likewise.
8974 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8975 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8976 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8977 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8979 * menu.h, termhooks.h: Include "systime.h", for Time.
8981 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8982 Don't assume that the difference between two unsigned long values
8983 can fit into an integer. At this point, we know button_down_time
8984 <= event->timestamp, so the difference must be nonnegative, so
8985 there's no need to cast the result if double-click-time is
8986 nonnegative, as it should be; check that it's nonnegative, just in
8987 case. This bug is triggered when events are more than 2**31 ms
8988 apart (about 25 days). (Bug#8664)
8990 * xselect.c (last_event_timestamp): Remove duplicate decl.
8991 (x_own_selection): Remove needless cast to unsigned long.
8993 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8994 that always fit in int. Use a sentinel instead of a counter, to
8995 avoid a temp and to allay GCC's concerns about possible int overflow.
8996 * frame.h (struct frame): Use int for menu_bar_items_used
8997 instead of EMACS_INT, since it always fits in int.
8999 * menu.c (grow_menu_items): Check for int overflow.
9001 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9003 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9004 Before, the code was not consistent. These values cannot exceed
9005 2**31 - 1 so there's no need to make them unsigned.
9006 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9007 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9008 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9010 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9012 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9013 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9014 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9015 presumably because the widths might not match.
9017 * window.c (size_window): Avoid needless test at loop start.
9019 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9021 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9023 2011-05-12 Drew Adams <drew.adams@oracle.com>
9025 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9027 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9029 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9030 `width' to `bar_area_x' and `bar_area_width', respectively.
9031 (x_scroll_run): Take account of fringe background extension.
9033 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9034 Rename local vars `left' and `width' to `bar_area_x' and
9035 `bar_area_width', respectively.
9036 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9037 background extension.
9039 2011-05-10 Jim Meyering <meyering@redhat.com>
9041 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9043 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
9045 * image.c (Finit_image_library): Return t for built-in image types,
9046 like pbm and xbm. (Bug#8640)
9048 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9050 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9052 2011-05-07 Eli Zaretskii <eliz@gnu.org>
9054 * w32console.c (Fset_screen_color): Doc fix.
9055 (Fget_screen_color): New function.
9056 (syms_of_ntterm): Defsubr it.
9058 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9059 unlink the temporary file if Fcall_process didn't create it in the
9061 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9062 child process will be redirected to a file specified with `:file'.
9063 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9064 cue to call_process_cleanup not to close that handle.
9066 2011-05-07 Ben Key <bkey76@gmail.com>
9068 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9069 one of two shell specific rules, either bootstrap-temacs-CMD or
9070 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9071 to the previous implementation of the bootstrap-temacs rule.
9072 The bootstrap-temacs-CMD rule is similar to the previous
9073 implementation of the bootstrap-temacs rule except that it
9074 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9077 These changes, along with some changes to nt/configure.bat,
9078 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9079 earlier fix to add support for --cflags and --ldflags options
9080 that include quotes so that it works whether make uses cmd or
9083 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
9085 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9086 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9088 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9089 a string. Handle both cases.
9090 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9091 (Fdbus_register_method): Use Qinvalid_function.
9093 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
9095 * makefile.w32-in: Update dependencies.
9096 (LISP_H): Add inttypes.h and stdin.h.
9097 (PROCESS_H): Add unistd.h.
9099 2011-05-06 Eli Zaretskii <eliz@gnu.org>
9101 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9102 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9104 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
9106 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9108 * term.c (vfatal): Remove stray call to va_end.
9109 It's not needed and the C Standard doesn't allow it here anyway.
9111 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9112 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9114 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9117 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9119 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9121 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9123 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9125 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9127 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9128 * charset.c (Fdefine_charset_internal): Don't initialize
9129 charset.code_space[15]. The value was garbage, on hosts with
9130 32-bit int (Bug#8600).
9132 * lread.c (read_integer): Be more consistent with string-to-number.
9133 Use string_to_number to do the actual conversion; this avoids
9134 rounding errors and fixes some other screwups. Without this fix,
9135 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9136 (digit_to_number): Move earlier, for benefit of read_integer.
9137 Return -1 if the digit is out of range for the base, -2 if it is
9138 not a digit in any supported base. (Bug#8602)
9140 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9142 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9143 to match comment at start of function. This also removes a
9144 GCC warning about overflow in a 32+64-bit port.
9146 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9148 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9149 Reported by Stefan Monnier in
9150 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
9151 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9152 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
9154 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9155 (EMACS_UINTPTR): Likewise, with uintptr_t.
9157 * lisp.h: Prefer 64-bit EMACS_INT if available.
9158 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9159 on 32-bit hosts that have 64-bit int, so that they can access
9161 However, temporarily disable this change unless the temporary
9162 symbol WIDE_EMACS_INT is defined.
9164 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9166 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9167 This removes an assumption that EMACS_INT and long are the same
9168 width as pointers. The assumption is true for Emacs porting targets
9169 now, but we want to make other targets possible.
9170 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9171 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9172 In the rest of the code, change types of integers that hold casted
9173 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9174 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9175 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9176 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9177 No need to cast type when ORing.
9178 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9179 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9180 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9181 assume EMACS_INT is the same width as char *.
9182 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9183 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9184 Remove no-longer-needed casts.
9185 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9186 (xg_tool_bar_help_callback, xg_make_tool_item):
9187 Use EMACS_INTPTR to hold an integer
9188 that will be cast to void *; this can avoid a GCC warning
9189 if EMACS_INT is not the same width as void *.
9190 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9191 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9192 (current_message_1, set_message_1):
9193 Use a local to convert to proper width without a cast.
9194 * xmenu.c (dialog_selection_callback): Likewise.
9196 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9197 Also, don't assume VALBITS / RAND_BITS is less than 5,
9198 and don't rely on undefined behavior when shifting a 1 left into
9200 * lisp.h (get_random): Change signature to match.
9202 * lread.c (hash_string): Use size_t, not int, for hash computation.
9203 Normally we prefer signed values; but hashing is special, because
9204 it's better to use unsigned division on hash table sizes so that
9205 the remainder is nonnegative. Also, size_t is the natural width
9206 for hashing into memory. The previous code used 'int', which doesn't
9207 retain enough info to hash well into very large tables.
9208 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9210 * dbusbind.c: Don't possibly lose pointer info when converting.
9211 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9212 Use XPNTR rather than XHASH, so that the high-order bits of
9213 the pointer aren't lost when converting through void *.
9215 * eval.c (Fautoload): Don't double-shift a pointer.
9217 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9219 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
9221 * gnutls.c (DEF_GNUTLS_FN):
9222 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9224 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9226 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9229 2011-05-05 Eli Zaretskii <eliz@gnu.org>
9231 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9232 New version that can reserve upto 2GB of heap space.
9234 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
9236 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9238 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9240 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9241 `gnutls_certificate_set_x509_key_file'.
9243 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
9245 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9246 Update dependencies.
9248 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9250 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9251 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9252 Remove unused parameter `fildes'.
9253 * process.c (read_process_output, send_process): Don't pass it.
9255 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9257 Fix previous change: the library cache is defined in w32.c.
9258 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9259 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9261 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9263 Implement dynamic loading of GnuTLS on Windows.
9265 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9266 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9267 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9270 * gnutls.c (Qgnutls_dll): Define.
9271 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9272 (gnutls_*): Declare function pointers.
9273 (init_gnutls_functions): New function to initialize function pointers.
9274 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9275 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9276 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9277 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9278 (emacs_gnutls_write, emacs_gnutls_read)
9279 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9280 (Fgnutls_available_p): New function.
9281 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9282 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9283 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9285 * image.c: Include w32.h.
9286 (Vimage_type_cache): Delete.
9287 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9288 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9289 (w32_delayed_load): Move to w32.c.
9291 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9293 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9294 (w32_delayed_load): Move from image.c. When loading a library, record
9295 its filename in the :loaded-from property of the library id.
9296 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9297 Initialize and staticpro them.
9298 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9300 * process.c: Include lisp.h before w32.h, not after.
9301 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9302 instead of gnutls_record_check_pending.
9304 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9306 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9308 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9309 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9312 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9314 * xterm.c (x_set_frame_alpha): Do not set property on anything
9315 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9317 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9319 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9321 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9323 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9324 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9325 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9326 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9327 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9328 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9329 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9330 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9331 (Qgnutls_bootprop_callbacks_verify): Make static.
9333 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9335 * callproc.c: Indentation fixup.
9337 * sysdep.c (wait_for_termination_1): Make static.
9338 (wait_for_termination, interruptible_wait_for_termination):
9339 Move after wait_for_termination_1.
9341 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9343 * sysdep.c (interruptible_wait_for_termination): New function
9344 which is like wait_for_termination, but allows keyboard
9347 * callproc.c (Fcall_process): Add (:file "file") as an option for
9349 (Fcall_process_region): Ditto.
9351 2011-04-30 Eli Zaretskii <eliz@gnu.org>
9353 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9354 rather than `XVECTOR (FOO)->size'.
9356 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9357 inttypes.h, as a gnulib replacement is used if it not available in
9360 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9362 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9363 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9364 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9366 * coding.c (coding_alloc_by_realloc): Error out if destination
9367 will grow beyond MOST_POSITIVE_FIXNUM.
9368 (decode_coding_emacs_mule): Abort if there isn't enough place in
9369 charbuf for the composition carryover bytes. Reserve an extra
9370 space for up to 2 characters produced in a loop.
9371 (decode_coding_iso_2022): Abort if there isn't enough place in
9372 charbuf for the composition carryover bytes.
9374 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9376 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9377 aborting when %lld or %lll format is passed.
9378 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9379 %llo or %llx format is passed. (Bug#8545)
9381 * window.c (window_scroll_line_based): Use a marker instead of
9382 simple variables to record original value of point. (Bug#7952)
9384 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9385 produced by %s or %c overflows available buffer space. (Bug#8545)
9387 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9389 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
9390 (SIZE_MAX): Move defn after all includes, as they might #define it.
9392 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9394 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9396 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9398 * keyboard.c (Qdelayed_warnings_hook): Define.
9399 (command_loop_1): Run `delayed-warnings-hook'
9400 if Vdelayed_warnings_list is non-nil.
9401 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9402 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9404 2011-04-28 Eli Zaretskii <eliz@gnu.org>
9406 * doprnt.c (doprnt): Don't return value smaller than the buffer
9407 size if the message was truncated. (Bug#8545).
9409 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9411 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9412 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9414 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9416 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9418 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
9420 * makefile.w32-in: Update dependencies.
9422 2011-04-27 Eli Zaretskii <eliz@gnu.org>
9424 Improve `doprnt' and its usage. (Bug#8545)
9425 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9426 `format_end'. Remove support for %l as a conversion specifier.
9427 Don't use xrealloc. Improve diagnostics when the %l size modifier
9428 is used. Update the commentary.
9430 * eval.c (verror): Simplify calculation of size_t.
9432 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9435 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9437 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9440 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9442 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9443 This makes this file independent of the recent pseudovector change.
9445 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
9447 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9449 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
9450 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
9451 Remove unused local.
9452 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
9454 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
9455 GCC 4.6.0 optimizes based on type-based alias analysis.
9456 For example, if b is of type struct buffer * and v of type struct
9457 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9458 != &v->size, and therefore "v->size = 1; b->size = 2; return
9459 v->size;" must therefore return 1. This assumption is incorrect
9460 for Emacs, since it type-puns struct Lisp_Vector * with many other
9461 types. To fix this problem, this patch adds a new type struct
9462 vectorlike_header that documents the constraints on layout of vectors
9463 and pseudovectors, and helps optimizing compilers not get fooled
9464 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9465 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
9466 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9468 (XSETPVECTYPE): Rewrite in terms of new macro.
9469 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9470 This is a bit clearer, and further avoids the possibility of
9471 undesirable aliasing.
9472 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
9473 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
9474 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9475 since Lisp_Subr is a special case (no "next" field).
9476 (ASIZE): Now uses header.size rather than size.
9477 All previous uses of XVECTOR (foo)->size replaced to use this macro,
9478 to avoid the hassle of writing XVECTOR (foo)->header.size.
9479 (struct vectorlike_header): New type.
9480 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9481 object, to help avoid aliasing.
9482 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9483 (SUBRP): Likewise, since Lisp_Subr is a special case.
9484 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9485 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9486 (struct Lisp_Hash_Table): Combine first two members into a single
9487 struct vectorlike_header member. All uses of "size" and "next" members
9488 changed to be "header.size" and "header.next".
9489 * buffer.h (struct buffer): Likewise.
9490 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9491 * frame.h (struct frame): Likewise.
9492 * process.h (struct Lisp_Process): Likewise.
9493 * termhooks.h (struct terminal): Likewise.
9494 * window.c (struct save_window_data, struct saved_window): Likewise.
9495 * window.h (struct window): Likewise.
9496 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9497 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9498 * buffer.c (init_buffer_once): Likewise.
9499 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9501 * process.c (Fformat_network_address): Use local var for size,
9504 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9506 Make the Lisp reader and string-to-float more consistent (Bug#8525)
9507 * data.c (atof): Remove decl; no longer used or needed.
9508 (digit_to_number): Move to lread.c.
9509 (Fstring_to_number): Use new string_to_number function, to be
9510 consistent with how the Lisp reader treats infinities and NaNs.
9511 Do not assume that floating-point numbers represent EMACS_INT
9512 without losing information; this is not true on most 64-bit hosts.
9513 Avoid double-rounding errors, by insisting on integers when
9514 parsing non-base-10 numbers, as the documentation specifies.
9515 * lisp.h (string_to_number): New decl, replacing ...
9516 (isfloat_string): Remove.
9517 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
9518 (read1): Do not accept +. and -. as integers; this
9519 appears to have been a coding error. Similarly, do not accept
9520 strings like +-1e0 as floating point numbers. Do not report
9521 overflow for integer overflows unless the base is not 10 which
9522 means we have no simple and reliable way to continue.
9523 Break out the floating-point parsing into a new
9524 function string_to_number, so that Fstring_to_number parses
9525 floating point numbers consistently with the Lisp reader.
9526 (digit_to_number): Move here from data.c. Make it static inline.
9527 (E_CHAR, EXP_INT): Remove, replacing with ...
9528 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9529 (string_to_number): New function, replacing isfloat_string.
9530 This function checks for valid syntax and produces the resulting
9531 Lisp float number too. Rework it so that string-to-number
9532 no longer mishandles examples like "1.0e+". Use strtoumax,
9533 so that overflow for non-base-10 numbers is reported only when
9534 there's no portable and simple way to convert to floating point.
9536 * textprop.c (set_text_properties_1): Rewrite for clarity,
9537 and to avoid GCC warning about integer overflow.
9539 * intervals.h (struct interval): Use EMACS_INT for members
9540 where EMACS_UINT might cause problems. See
9541 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9542 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9543 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9545 (offset_intervals): Tell GCC not to worry about length overflow
9546 when negating a negative length.
9548 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9549 (overrun_check_free): Likewise.
9551 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9552 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9555 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9556 (gnutls_make_error): Rename local to avoid shadowing.
9557 (gnutls_emacs_global_deinit): ifdef out; not used.
9558 (Fgnutls_boot): Use const for pointer to readonly storage.
9559 Comment out unused local. Fix pointer signedness problems.
9561 * lread.c (openp): Don't stuff size_t into an 'int'.
9562 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9563 about possible signed overflow.
9565 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9566 (GDK_KEY_g): Don't define if already defined.
9567 (xg_prepare_tooltip): Avoid pointer signedness problem.
9568 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9570 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9571 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9573 * xfns.c (Fx_window_property): Simplify a bit,
9574 to make a bit faster and to avoid GCC 4.6.0 warning.
9575 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9577 * fns.c (internal_equal): Don't assume size_t fits in int.
9579 * alloc.c (compact_small_strings): Tighten assertion a little.
9581 Replace pEd with more-general pI, and fix some printf arg casts.
9582 * lisp.h (pI): New macro, generalizing old pEd macro to other
9583 conversion specifiers. For example, use "...%"pI"d..." rather
9584 than "...%"pEd"...".
9585 (pEd): Remove. All uses replaced with similar uses of pI.
9586 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
9587 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9588 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9589 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9590 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9591 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9592 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9594 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9595 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9596 * print.c (safe_debug_print, print_object): Likewise.
9597 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9599 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9600 avoiding the 0 flag, which is not portable.
9601 * process.c (Fmake_network_process): Use pI to avoid cast.
9602 * region-cache.c (pp_cache): Likewise.
9603 * xdisp.c (decode_mode_spec): Likewise.
9604 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9605 behavior on 64-bit hosts with printf arg.
9606 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
9607 (x_stop_queuing_selection_requests): Likewise.
9608 (x_get_window_property): Don't truncate byte count to an 'int'
9611 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9612 here, since it parses constructs like leading '-' and spaces,
9613 which are not wanted; and it overflows with large numbers.
9614 Instead, simply match F[0-9]+, which is what is wanted anyway.
9616 * alloc.c: Remove unportable assumptions about struct layout.
9617 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9618 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9619 (allocate_vectorlike, make_pure_vector): Use the new macros,
9620 plus offsetof, to remove unportable assumptions about struct layout.
9621 These assumptions hold on all porting targets that I know of, but
9622 they are not guaranteed, they're easy to remove, and removing them
9623 makes further changes easier.
9625 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9626 This doesn't fix a bug but makes the code clearer.
9627 (string_overrun_cookie): Now const. Use initializers that
9628 don't formally overflow signed char, to avoid warnings.
9629 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9630 can cause Emacs to crash when string overrun checking is enabled.
9631 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9632 multiple of sizeof (EMACS_INT); it need not be, if
9633 alignof(EMACS_INT) < sizeof (EMACS_INT).
9634 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
9636 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
9638 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9640 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9642 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
9643 supposed to be handshaking. (Bug#8556)
9644 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9646 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
9648 * lisp.h (Qdebug): List symbol.
9649 * eval.c (Qdebug): Restore global linkage.
9650 * keyboard.c (debug-on-event): New variable.
9651 (handle_user_signal): Break into debugger when debug-on-event
9652 matches the current signal symbol.
9654 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9656 * alloc.c (check_sblock, check_string_bytes)
9657 (check_string_free_list): Convert to standard C.
9659 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9661 * w32.c (emacs_gnutls_push): Fix typo.
9663 2011-04-25 Eli Zaretskii <eliz@gnu.org>
9665 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9666 "cast to pointer from integer of different size".
9668 Improve doprnt and its use in verror. (Bug#8545)
9669 * doprnt.c (doprnt): Document the set of format control sequences
9670 supported by the function. Use SAFE_ALLOCA instead of always
9673 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9674 is one byte too soon. Don't use xrealloc; instead xfree and
9677 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9679 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9682 * gnutls.c: Renamed global_initialized to
9683 gnutls_global_initialized. Added internals for the
9684 :verify-hostname-error, :verify-error, and :verify-flags
9685 parameters of `gnutls-boot' and documented those parameters in the
9686 docstring. Start callback support.
9687 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9688 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9689 on error. Return error code.
9690 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9691 (emacs_gnutls_read): Likewise.
9692 (Fgnutls_boot): Return handshake error code.
9693 (emacs_gnutls_handle_error): New function.
9694 (wsaerror_to_errno): Likewise.
9696 * w32.h (emacs_gnutls_pull): Add prototype.
9697 (emacs_gnutls_push): Likewise.
9699 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9700 (emacs_gnutls_push): Likewise.
9702 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9704 * process.c (wait_reading_process_output): Check if GnuTLS
9705 buffered some data internally if no FDs are set for TLS
9708 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9709 (LIBS): Link to USER_LIBS.
9710 ($(BLD)/gnutls.$(0)): New target.
9712 2011-04-24 Eli Zaretskii <eliz@gnu.org>
9714 * xdisp.c (handle_single_display_spec): Rename the
9715 display_replaced_before_p argument into display_replaced_p, to
9716 make it consistent with the commentary. Fix typos in the
9719 * textprop.c (syms_of_textprop): Remove dead code.
9720 (copy_text_properties): Delete obsolete commentary about an
9721 interface that was deleted long ago. Fix typos in the description
9724 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9725 to changes in oldXMenu/XMenu.h from 2011-04-16.
9726 <menu_help_message, prev_menu_help_message>: Constify.
9727 (IT_menu_make_room): menu->help_text is now `const char **';
9730 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9731 to changes in oldXMenu/XMenu.h from 2011-04-16.
9732 (struct XMenu): Declare `help_text' `const char **'.
9734 * xfaces.c <Qunspecified>: Make extern again.
9736 * syntax.c: Include sys/types.h before including regex.h, as
9739 * doc.c (get_doc_string): Improve the format passed to `error'.
9741 * doprnt.c (doprnt): Improve commentary.
9743 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9745 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9748 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9749 changes in globals.h immediately force recompilation.
9750 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9751 $(CURDIR)/s/ms-w32.h.
9752 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
9754 * character.c (Fchar_direction): Function deleted.
9755 (syms_of_character): Don't defsubr it.
9756 <char-direction-table>: Deleted.
9758 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9760 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9761 * doprnt.c: Include limits.h.
9762 (SIZE_MAX): New macro.
9763 (doprnt): Return a size_t value. 2nd arg is now size_t.
9764 Many local variables are now size_t instead of int or unsigned.
9765 Improve overflow protection. Support `l' modifier for integer
9766 conversions. Support %l conversion. Don't assume an EMACS_INT
9767 argument for integer conversions and for %c.
9769 * lisp.h (doprnt): Restore prototype.
9771 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9774 * Makefile.in (base_obj): Add back doprnt.o.
9776 * deps.mk (doprnt.o): Add back prerequisites.
9777 (callint.o): Depend on character.h.
9779 * eval.c (internal_lisp_condition_case): Include the handler
9780 representation in the error message.
9781 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9782 when breaking from the loop.
9784 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9786 * callint.c (Fcall_interactively): When displaying error message
9787 about invalid control letter, pass the character's codepoint, not
9788 a pointer to its multibyte form. Improve display of the character
9789 in octal and display also its hex code.
9791 * character.c (char_string): Use %x to display the (unsigned)
9792 codepoint of an invalid character, to avoid displaying a bogus
9795 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9796 `error', not SYMBOL_NAME itself.
9798 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9799 character arguments to `error'.
9801 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9802 to `error' in error message about FINAL_CHAR argument. Make sure
9803 FINAL_CHAR is a character, and use %c when it is passed as
9804 argument to `error'.
9806 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9808 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9810 * w32.c: Include <time.h>.
9811 (sys_localtime): New function.
9813 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
9815 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9817 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
9819 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
9821 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9824 2011-04-19 Eli Zaretskii <eliz@gnu.org>
9826 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9827 gl_state.e_property when gl_state.object is Qt.
9829 * insdel.c (make_gap_larger): Remove limitation of buffer size
9832 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
9834 * xdisp.c (lookup_glyphless_char_display)
9835 (produce_glyphless_glyph): Handle cons cell entry in
9836 glyphless-char-display.
9837 (Vglyphless_char_display): Document it.
9839 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9840 glyphless-char-display.
9842 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
9844 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9846 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9848 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9849 definition for no-X builds.
9851 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
9853 Static checks with GCC 4.6.0 and non-default toolkits.
9855 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9857 * process.c (keyboard_bit_set): Define only if SIGIO.
9858 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9859 (send_process): Repair possible setjmp clobbering.
9861 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9863 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9865 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9867 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9868 Define only if needed.
9870 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9871 by pacifying GCC about it. Maybe it's time to retire it?
9872 * xfaces.c (USG, __TIMEVAL__): Likewise.
9874 * dispextern.h (struct redisplay_interface): Rename param
9876 * termhooks.h (struct terminal): Likewise.
9877 * xterm.c (xembed_send_message): Likewise.
9879 * insdel.c (make_gap_smaller): Define only if
9880 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9882 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9885 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9886 so that we aren't warned about unused symbols.
9888 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9890 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
9892 * xfns.c (x_real_positions): Mark locals as initialized.
9894 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9896 * xterm.c: Fix problems found by static analysis with other toolkits.
9897 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
9898 (x_dispatch_event): Declare static if USE_GTK, and
9899 define if USE_GTK || USE_X_TOOLKIT.
9900 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
9901 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
9902 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9903 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
9905 * xmenu.c (menu_help_callback): Pointer type fixes.
9906 Use const pointers when pointing at readonly data. Avoid pointer
9908 (FALSE): Remove unused macro.
9909 (update_frame_menubar): Remove unused decl.
9911 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9913 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9914 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9915 (single_menu_item): Rename local to avoid shadowing.
9917 * keyboard.c (make_lispy_event): Remove unused local var.
9919 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9920 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9922 * bitmaps: Change bitmaps from unsigned char back to the X11
9923 compatible char. Avoid the old compiler warnings about
9924 out-of-range initializers by using, for example, '\xab' rather
9927 * xgselect.c (xgselect_initialize): Check vs interface
9928 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9930 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9932 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9933 to read-only memory.
9935 * fns.c (vector): Remove; this old hack is no longer needed.
9937 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
9939 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
9941 * xrdb.c (x_load_resources): Omit unused local.
9943 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
9944 (x_window): Rename locals to avoid shadowing.
9945 (USG): Use the kludged USG macro, to pacify gcc.
9947 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
9948 (x_term_init): Remove local to avoid shadowing.
9950 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
9952 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9953 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9955 2011-04-16 Eli Zaretskii <eliz@gnu.org>
9957 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9959 Fix regex.c, syntax.c and friends for buffers > 2GB.
9960 * syntax.h (struct gl_state_s): Declare character position members
9963 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9965 * textprop.c (verify_interval_modification, interval_of):
9966 Declare arguments EMACS_INT.
9968 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9971 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9973 * indent.c (Fvertical_motion): Local variable it_start is now
9976 * regex.c (re_match, re_match_2, re_match_2_internal)
9977 (bcmp_translate, regcomp, regexec, print_double_string)
9978 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9979 (re_compile_pattern, re_exec): Declare arguments and local
9980 variables `size_t' and `ssize_t' and return values `regoff_t', as
9982 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9983 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9984 <compile_stack_type>: `size' and `avail' are now `size_t'.
9986 * regex.h <regoff_t>: Use ssize_t, not int.
9987 (re_search, re_search_2, re_match, re_match_2): Arguments that
9988 specify buffer/string position and length are now ssize_t and
9989 size_t. Return type is regoff_t.
9991 2011-04-16 Ben Key <bkey76@gmail.com>
9993 * nsfont.m: Fixed bugs in ns_get_family and
9994 ns_descriptor_to_entity that were caused by using free to
9995 deallocate memory blocks that were allocated by xmalloc (via
9996 xstrdup). This caused Emacs to crash when compiled with
9997 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9998 --enable-checking=xmallocoverrun). xfree is now used to
9999 deallocate these memory blocks.
10001 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
10003 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10005 emacs_write: Accept and return EMACS_INT for sizes.
10006 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10008 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10009 Accept and return EMACS_INT.
10010 (emacs_gnutls_write): Return the number of bytes written on
10012 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
10013 (emacs_read, emacs_write): Remove check for negative size, as the
10014 Emacs source code has been audited now.
10015 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10016 (emacs_read, emacs_write): Use it.
10017 * process.c (send_process): Adjust to the new signatures of
10018 emacs_write and emacs_gnutls_write. Do not attempt to store
10019 a byte offset into an 'int'; it might overflow.
10020 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
10022 * sound.c: Don't assume sizes fit in 'int'.
10023 (struct sound_device.period_size, alsa_period_size):
10024 Return EMACS_INT, not int.
10025 (struct sound_device.write, vox_write, alsa_write):
10026 Accept EMACS_INT, not int.
10027 (wav_play, au_play): Use EMACS_INT to store sizes and to
10028 record read return values.
10030 2011-04-15 Ben Key <bkey76@gmail.com>
10032 * keyboard.c (Qundefined): Don't declare static since it is used
10034 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10035 static since they are used in nsfont.m.
10037 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10039 * process.c (Qprocessp): Don't declare static.
10040 * lisp.h (Qprocessp): Declare again.
10042 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
10044 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10046 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10048 Improve C-level modularity by making more things 'static'.
10050 Don't publish debugger-only interfaces to other modules.
10051 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10052 (verify_bytepos, count_markers): Move decls to the only modules
10054 * region-cache.h (pp_cache): Likewise.
10055 * window.h (check_all_windows): Likewise.
10056 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10058 * sysdep.c (croak): Now static, if
10059 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10060 * syssignal.h (croak): Declare only if not static.
10062 * alloc.c (refill_memory_reserve): Now static if
10063 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10064 * lisp.h (refill_memory_reserve): Declare only if not static.
10066 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10067 Define only if USE_LUCID.
10069 * xrdb.c (x_customization_string, x_rm_string): Now static.
10071 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10072 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10074 * xdisp.c (draw_row_with_mouse_face): Now static.
10075 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10077 * window.h (check_all_windows): Mark externally visible.
10079 * window.c (window_deletion_count): Now static.
10081 * undo.c: Make symbols static if they're not exported.
10082 (last_undo_buffer, last_boundary_position, pending_boundary):
10085 * textprop.c (interval_insert_behind_hooks): Now static.
10086 (interval_insert_in_front_hooks): Likewise.
10088 * term.c: Make symbols static if they're not exported.
10089 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10090 (max_frame_lines, tty_set_terminal_modes):
10091 (tty_reset_terminal_modes, tty_turn_off_highlight):
10092 (get_tty_terminal): Now static.
10093 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10094 * termhooks.h (term_mouse_moveto): Do not declare if
10095 HAVE_WINDOW_SYSTEM.
10096 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10097 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10099 * sysdep.c: Make symbols static if they're not exported.
10100 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10102 (sigprocmask_set, full_mask): Remove; unused.
10103 (wait_debugging): Mark as visible.
10104 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10105 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10107 * syntax.c (syntax_temp): Define only if !__GNUC__.
10109 * sound.c (current_sound_device, current_sound): Now static.
10111 * search.c (searchbufs, searchbuf_head): Now static.
10113 * scroll.c (scroll_cost): Remove; unused.
10114 * dispextern.h (scroll_cost): Remove decl.
10116 * region-cache.h (pp_cache): Mark as externally visible.
10118 * process.c: Make symbols static if they're not exported.
10119 (process_tick, update_tick, create_process, chan_process):
10120 (Vprocess_alist, proc_buffered_char, datagram_access):
10121 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10122 (deactivate_process): Mark defn as static, as well as decl.
10123 * lisp.h (create_process): Remove decl.
10124 * process.h (chan_process, Vprocess_alist): Remove decls.
10126 * print.c: Make symbols static if they're not exported.
10127 (print_depth, new_backquote_output, being_printed, print_buffer):
10128 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10129 (print_interval, print_number_index, initial_stderr_stream):
10131 * lisp.h (Fprinc): Remove decl.
10132 (debug_output_compilation_hack): Mark as externally visible.
10134 * sysdep.c (croak): Move decl from here to syssignal.h.
10135 * syssignal.h (croak): Put it here, so the API can be checked when
10136 'croak' is called from dissociate_if_controlling_tty.
10138 * minibuf.c: Make symbols static if they're not exported.
10139 (minibuf_save_list, choose_minibuf_frame): Now static.
10140 * lisp.h (choose_minibuf_frame): Remove decl.
10142 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10144 * lread.c: Make symbols static if they're not exported.
10145 (read_objects, initial_obarray, oblookup_last_bucket_number):
10147 (make_symbol): Remove; unused.
10148 * lisp.h (initial_obarray, make_symbol): Remove decls.
10150 * keyboard.c: Make symbols static if they're not exported.
10151 (single_kboard, recent_keys_index, total_keys, recent_keys):
10152 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10153 (this_single_command_key_start, echoing, last_auto_save):
10154 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10155 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10156 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10157 (Vlispy_mouse_stem, double_click_count):
10159 (force_auto_save_soon): Define only if SIGDANGER.
10160 (ignore_mouse_drag_p): Now static if
10161 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10162 (print_help): Remove; unused.
10163 (stop_character, last_timer_event): Mark as externally visible.
10164 * keyboard.h (ignore_mouse_drag_p): Declare only if
10165 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10166 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10167 * lisp.h (echoing): Remove decl.
10168 (force_auto_save_soon): Declare only if SIGDANGER.
10169 * xdisp.c (redisplay_window): Simplify code, to make it more
10170 obvious that ignore_mouse_drag_p is not accessed if !defined
10171 USE_GTK && !defined HAVE_NS.
10173 * intervals.c: Make symbols static if they're not exported.
10174 (merge_properties_sticky, merge_interval_right, delete_interval):
10176 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10178 * insdel.c: Make symbols static if they're not exported.
10179 However, leave prepare_to_modify_buffer alone. It's never
10180 called from outside this function, but that appears to be a bug.
10181 (combine_after_change_list, combine_after_change_buffer):
10182 (adjust_after_replace, signal_before_change): Now static.
10183 (adjust_after_replace_noundo): Remove; unused.
10184 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
10185 (signal_before_change): Remove decls.
10187 * indent.c (val_compute_motion, val_vmotion): Now static.
10189 * image.c: Make symbols static if they're not exported.
10190 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10192 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10193 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10195 * fringe.c (standard_bitmaps): Now static.
10196 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10198 * frame.c: Make symbols static if they're not exported.
10199 (x_report_frame_params, make_terminal_frame): Now static.
10200 (get_frame_param): Now static, unless HAVE_NS.
10201 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10202 (x_get_resource_string): Remove; not used.
10203 * frame.h (make_terminal_frame, x_report_frame_params):
10204 (x_get_resource_string); Remove decls.
10205 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10206 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10208 * font.c, fontset.c: Make symbols static if they're not exported.
10209 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10210 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10211 * font.c (font_close_object): Now static.
10212 * font.h (font_close_object): Remove.
10213 * fontset.c (FONTSET_OBJLIST): Remove.
10214 (free_realized_fontset) #if-0 the body, which does nothing.
10215 (face_suitable_for_char_p): #if-0, as it's never called.
10216 * fontset.h (face_suitable_for_char_p): Remove decl.
10217 * xfaces.c (face_at_string_position):
10218 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
10219 since 0 is always ASCII.
10221 * fns.c (weak_hash_tables): Now static.
10223 * fileio.c: Make symbols static if they're not exported.
10224 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10225 (Vwrite_region_annotation_buffers): Now static.
10227 * eval.c: Make symbols static if they're not exported.
10228 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10229 * lisp.h (backtrace_list): Remove decl.
10231 * emacs.c: Make symbols static if they're not exported.
10232 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10233 (fatal_error_code, fatal_error_signal_hook, standard_args):
10235 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10236 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10237 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10238 * lisp.h (fatal_error_signal_hook): Remove decl.
10239 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10241 * editfns.c: Move a (normally-unused) function to its only use.
10242 * editfns.c, lisp.h (get_operating_system_release): Remove.
10243 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10244 worth the hassle of breaking this out.
10246 * xterm.c: Make symbols static if they're not exported.
10247 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10248 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10249 (x_destroy_window, x_delete_display):
10251 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10252 (x_mouse_leave): Remove; unused.
10253 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10254 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10255 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10257 (x_mouse_leave): Declare only if WINDOWSNT.
10258 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10259 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10262 * ftxfont.c: Make symbols static if they're not exported.
10263 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10265 * font.h (ftxfont_driver): Likewise.
10267 * xfns.c: Make symbols static if they're not exported.
10268 (x_last_font_name, x_display_info_for_name):
10269 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10270 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10271 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10272 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10273 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10274 (last_show_tip_args): Now static.
10275 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10276 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10277 (x_screen_planes): Remove; unused.
10278 * dispextern.h (x_screen_planes): Remove decl.
10280 * dispnew.c: Make symbols static if they're not exported.
10281 * dispextern.h (redraw_garbaged_frames, scrolling):
10282 (increment_row_positions): Remove.
10283 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10284 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10286 (redraw_garbaged_frames): Remove; unused.
10288 * xfaces.c: Make symbols static if they're not exported.
10289 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10291 * xterm.h (defined_color): Remove decls.
10292 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10293 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10294 (menu_face_changed_default, defined_color, free_realized_face):
10295 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10296 (ascii_face_of_lisp_face): Remove; unused.
10298 * xdisp.c: Make symbols static if they're not exported.
10299 * dispextern.h (scratch_glyph_row, window_box_edges):
10300 (glyph_to_pixel_coords, set_cursor_from_row):
10301 (get_next_display_element, set_iterator_to_next):
10302 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10303 (show_mouse_face): Remove decls
10304 * frame.h (message_buf_print): Likewise.
10305 * lisp.h (pop_message, set_message, check_point_in_composition):
10307 * xterm.h (set_vertical_scroll_bar): Likewise.
10308 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10309 (message_buf_print, scratch_glyph_row, displayed_buffer):
10310 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10311 (get_next_display_element, show_mouse_face, window_box_edges):
10312 (frame_to_window_pixel_xy, check_point_in_composition):
10313 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10314 (glyph_to_pixel_coords): Remove; unused.
10316 * dired.c (file_name_completion): Now static.
10318 * dbusbind.c (xd_in_read_queued_messages): Now static.
10320 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10321 * data.c (circular_list_error): Remove.
10323 * commands.h (last_point_position, last_point_position_buffer):
10324 (last_point_position_window): Remove decls.
10325 * keyboard.c: Make these variables static.
10327 * coding.h (coding, code_convert_region, encode_coding_gap):
10329 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10330 (iso_code_class, detect_coding, code_convert_region): Now static.
10331 (encode_coding_gap): Remove; unused.
10333 * chartab.c (chartab_chars, chartab_bits): Now static.
10335 * charset.h (charset_iso_8859_1): Remove decl.
10336 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10339 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10340 * ccl.c (Vccl_program_table): Now static.
10341 (check_ccl_update): Remove; unused.
10343 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10344 * category.h: ... from here.
10345 * category.c (check_category_table, set_category_set): Now static.
10347 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10348 * lisp.h: Remove these decls.
10350 * buffer.c (buffer_count): Remove unused var.
10352 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10353 so that it's not optimized away.
10354 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10355 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10356 exported only to the debugger.
10358 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
10359 * atimer.h (run_all_atimers): Remove; not exported.
10361 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10362 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10363 was inaccessible from Lisp.
10364 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10365 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10367 alloc.c: Import and export fewer symbols, and remove unused items.
10368 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10370 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10371 it's not optimized away by whole-program optimization.
10372 (message_enable_multibyte, free_misc): Remove.
10373 (catchlist, handlerlist, mark_backtrace):
10374 Declare only if BYTE_MARK_STACK.
10375 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10376 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10377 (message_enable_multibyte): Remove decl.
10378 (free_misc, interval_free_list, float_block, float_block_index):
10379 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10380 (cons_free_list, last_marked_index):
10382 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10383 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10384 (mark_backtrace): Define only if BYTE_MARK_STACK.
10385 * xdisp.c (message_enable_multibyte): Now static.
10387 Declare Lisp_Object Q* variables to be 'static' if not exported.
10388 This makes it easier for human readers (and static analyzers)
10389 to see whether these variables are used from other modules.
10390 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10391 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10392 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10393 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10394 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10395 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10396 * xmenu.c, xselect.c:
10397 Declare Q* vars static if they are not used in other modules.
10398 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10399 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10400 Remove decls of unexported vars.
10401 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10403 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10405 Make Emacs functions such as Fatom 'static' by default.
10406 This makes it easier for human readers (and static analyzers)
10407 to see whether these functions can be called from other modules.
10408 DEFUN now defines a static function. To make the function external
10409 so that it can be used in other C modules, use the new macro DEFUE.
10410 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10411 (Finit_image_library):
10412 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10413 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10414 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10415 Remove decls, since these functions are now static.
10416 (Funintern, Fget_internal_run_time): New decls, since these functions
10417 were already external.
10419 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10420 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10421 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10422 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10423 * keyboard.c, keymap.c, lread.c:
10424 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10425 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10426 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10427 Mark functions with DEFUE instead of DEFUN,
10428 if they are used in other modules.
10429 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10430 decls for now-static functions.
10431 * buffer.h (Fdelete_overlay): Remove decl.
10432 * callproc.c (Fgetenv_internal): Mark as internal.
10433 * composite.c (Fremove_list_of_text_properties): Remove decl.
10434 (Fcomposition_get_gstring): New forward static decl.
10435 * composite.h (Fcomposite_get_gstring): Remove decl.
10436 * dired.c (Ffile_attributes): New forward static decl.
10437 * doc.c (Fdocumntation_property): New forward static decl.
10438 * eval.c (Ffetch_bytecode): New forward static decl.
10439 (Funintern): Remove extern decl; now in .h file where it belongs.
10440 * fileio.c (Fmake_symbolic_link): New forward static decl.
10441 * image.c (Finit_image_library): New forward static decl.
10442 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10443 * intervals.h (Fprevious_property_change):
10444 (Fremove_list_of_text_properties): Remove decls.
10445 * keyboard.c (Fthis_command_keys): Remove decl.
10446 (Fcommand_execute): New forward static decl.
10447 * keymap.c (Flookup_key): New forward static decl.
10448 (Fcopy_keymap): Now static.
10449 * keymap.h (Flookup_key): Remove decl.
10450 * process.c (Fget_process): New forward static decl.
10451 (Fprocess_datagram_address): Mark as internal.
10452 * syntax.c (Fsyntax_table_p): New forward static decl.
10453 (skip_chars): Remove duplicate decl.
10454 * textprop.c (Fprevious_property_change): New forward static decl.
10455 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10457 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10458 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10460 * editfns.c (Fformat): Remove unreachable code.
10462 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10464 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10467 2011-04-13 Eli Zaretskii <eliz@gnu.org>
10469 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10470 when at ZV. (Bug#8487)
10472 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10474 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10476 * keyboard.c (parse_tool_bar_item): Likewise.
10477 * sound.c (sound_cleanup, alsa_close): Likewise.
10478 * termcap.c (tgetent): Likewise.
10479 * xfns.c (x_default_font_parameter): Likewise.
10480 * xsettings.c (read_and_apply_settings): Likewise.
10482 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10483 (overrun_check_free): Protoize.
10485 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10487 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10488 since callers should never pass a negative size.
10489 Change the signature to match that of plain 'read' and 'write'; see
10490 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10491 * lisp.h: Update prototypes of emacs_write and emacs_read.
10493 2011-04-11 Eli Zaretskii <eliz@gnu.org>
10495 * xdisp.c (redisplay_window): Don't try to determine the character
10496 position of the scroll margin if the window start point w->startp
10497 is outside the buffer's accessible region. (Bug#8468)
10499 2011-04-10 Eli Zaretskii <eliz@gnu.org>
10501 Fix write-region and its subroutines for buffers > 2GB.
10502 * fileio.c (a_write, e_write): Modify declaration of arguments and
10503 local variables to support buffers larger than 2GB.
10504 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10506 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10507 argument, local variables, and return value.
10509 * lisp.h: Update prototypes of emacs_write and emacs_read.
10511 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10513 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
10515 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10517 Fix more problems found by GCC 4.6.0's static checks.
10519 * xdisp.c (vmessage): Use a better test for character truncation.
10521 * charset.c (load_charset_map): <, not <=, for optimization,
10522 and to avoid potential problems with integer overflow.
10523 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
10524 * casetab.c (set_identity, shuffle): Likewise.
10525 * editfns.c (Fformat): Likewise.
10526 * syntax.c (skip_chars): Likewise.
10528 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10529 This also lets GCC 4.6.0 generate slightly better loop code.
10531 * callint.c (Fcall_interactively): <, not <=, for optimization.
10532 (Fcall_interactively): Count the number of arguments produced,
10533 not the number of arguments given. This is simpler and lets GCC
10534 4.6.0 generate slightly better code.
10536 * ftfont.c: Distingish more carefully between FcChar8 and char.
10537 The previous code passed unsigned char * to a functions like
10538 strlen and xstrcasecmp that expect char *, which does not
10539 conform to the C standard.
10540 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10541 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10542 char * when the C standard requires it.
10544 * keyboard.c (read_char): Remove unused var.
10546 * eval.c: Port to Windows vsnprintf (Bug#8435).
10547 Include <limits.h>.
10548 (SIZE_MAX): Define if the headers do not.
10549 (verror): Do not give up if vsnprintf returns a negative count.
10550 Instead, grow the buffer. This ports to Windows vsnprintf, which
10551 does not conform to C99. Problem reported by Eli Zaretskii.
10552 Also, simplify the allocation scheme, by avoiding the need for
10553 calling realloc, and removing the ALLOCATED variable.
10555 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10557 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10558 But keep the doprint source code for now, as we might revamp it
10559 and use it again (Bug#8435).
10560 * lisp.h (doprnt): Remove.
10561 * Makefile.in (base_obj): Remove doprnt.o.
10562 * deps.mk (doprnt.o): Remove.
10564 error: Print 32- and 64-bit integers portably (Bug#8435).
10565 Without this change, on typical 64-bit hosts error ("...%d...", N)
10566 was used to print both 32- and 64-bit integers N, which relied on
10567 undefined behavior.
10568 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
10569 * lisp.h (error, verror): Mark as printf-like functions.
10570 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10571 Report overflow in size calculations when allocating printf buffer.
10572 Do not truncate output string at its first null byte.
10573 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10574 Truncate the output at a character boundary, since vsnprintf does not
10576 * charset.c (check_iso_charset_parameter): Convert internal
10577 character to string before calling 'error', since %c now has the
10579 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10580 overflow when computing char to be passed to 'error'. Do not
10581 pass Lisp_Object to 'error'; pass the integer instead.
10582 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10583 formatted with plain %d.
10585 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10587 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10589 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10591 * xterm.c (x_catch_errors): Remove duplicate declaration.
10593 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10595 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10597 2011-04-10 Jim Meyering <meyering@redhat.com>
10599 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10600 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10601 return ssize_t not "int", and use size_t as the buffer length.
10602 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10603 * gnutls.h: Update declarations.
10604 * process.c (read_process_output): Use ssize_t, to match.
10605 (send_process): Likewise.
10607 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10609 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10611 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10613 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10614 Use unsigned char, to match FcChar8 type definition.
10616 * xterm.c (handle_one_xevent):
10617 * xmenu.c (create_and_show_popup_menu):
10618 * xselect.c (x_decline_selection_request)
10619 (x_reply_selection_request): Avoid type-punned deref of X events.
10621 2011-04-09 Eli Zaretskii <eliz@gnu.org>
10623 Fix some uses of `int' instead of EMACS_INT.
10624 * search.c (string_match_1, fast_string_match)
10625 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10626 (scan_buffer, find_next_newline_no_quit)
10627 (find_before_next_newline, search_command, Freplace_match)
10628 (Fmatch_data): Make some `int' variables be EMACS_INT.
10630 * xdisp.c (display_count_lines): 3rd argument and return value now
10631 EMACS_INT. All callers changed.
10632 (pint2hrstr): Last argument is now EMACS_INT.
10634 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10635 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10636 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10637 (decode_coding_utf_16, decode_coding_emacs_mule)
10638 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10639 (decode_coding_ccl, decode_coding_charset)
10640 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10641 (decode_coding_iso_2022, decode_coding_emacs_mule)
10642 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10643 <char_offset, last_offset>: Declare EMACS_INT.
10644 (encode_coding_utf_8, encode_coding_utf_16)
10645 (encode_coding_emacs_mule, encode_invocation_designation)
10646 (encode_designation_at_bol, encode_coding_iso_2022)
10647 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10648 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10650 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10651 (encode_invocation_designation): Last argument P_NCHARS is now
10653 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10654 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10656 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10659 * ccl.c (Fccl_execute_on_string): Declare some variables
10662 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
10664 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10666 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10668 * process.c (Fformat_network_address): Doc fix.
10670 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10672 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
10674 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
10676 * keyboard.c (read_char): Call Lisp function help-form-show,
10677 instead of using internal_with_output_to_temp_buffer.
10678 (Qhelp_form_show): New var.
10679 (syms_of_keyboard): Use DEFSYM macro.
10681 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10683 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10685 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
10687 * process.c (Flist_processes): Remove to Lisp.
10688 (list_processes_1): Delete.
10690 2011-04-06 Eli Zaretskii <eliz@gnu.org>
10692 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10694 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10696 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
10698 Fix more problems found by GCC 4.6.0's static checks.
10700 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10702 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10704 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
10706 * xdisp.c (vmessage): Mark as a printf-like function.
10708 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10710 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10712 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10713 printf-like functions.
10714 (tiff_load): Add casts to remove these marks before passing them
10715 to system-supplied API.
10717 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10719 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10720 This avoids several warnings with gcc -Wstrict-overflow.
10721 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10722 directly, rather than having caller test rule sign. This avoids
10723 some unnecessary tests.
10724 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10725 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10726 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
10728 * xfont.c (xfont_text_extents): Remove var that was set but not used.
10729 (xfont_open): Avoid unnecessary tests.
10731 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10733 * composite.h, composite.c (composition_gstring_put_cache):
10734 Use EMACS_INT, not int, for length.
10736 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10737 breaking out part of COMPOSITION_DECODE_RULE.
10738 (COMPOSITION_DECODE_RULE): Use it.
10739 * composite.c (get_composition_id): Remove unused local vars,
10740 by using the new macro.
10742 * textprop.c (set_text_properties_1): Change while to do-while,
10743 since the condition is always true at first.
10745 * intervals.c (graft_intervals_into_buffer): Mark var as used.
10746 (interval_deletion_adjustment): Return unsigned value.
10749 * process.c (list_processes_1, create_pty, read_process_output):
10750 (exec_sentinel): Remove vars that were set but not used.
10751 (create_pty): Remove unnecessary "volatile"s.
10752 (Fnetwork_interface_info): Avoid possibility of int overflow.
10753 (read_process_output): Do adaptive read buffering even if carryover.
10754 (read_process_output): Simplify nbytes computation if buffered.
10756 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10758 * syntax.c (scan_words): Remove var that was set but not used.
10759 (update_syntax_table): Use unsigned instead of int.
10761 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
10762 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
10763 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
10765 * print.c (print_error_message): Avoid int overflow.
10767 * font.c (font_list_entities): Redo for clarity,
10768 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10770 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
10771 (font_score): Avoid potential overflow in diff calculation.
10773 * fns.c (substring_both): Remove var that is set but not used.
10774 (sxhash): Redo loop for clarity and to avoid wraparound warning.
10776 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10778 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10779 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10780 can always succeed if overflow has undefined behavior.
10782 * search.c (boyer_moore, wordify): Remove vars set but not used.
10783 (wordify): Omit three unnecessary tests.
10785 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10786 All callers changed. This avoids the need for an unused var.
10788 * casefiddle.c (casify_region): Remove var that is set but not used.
10790 * dired.c (file_name_completion): Remove var that is set but not used.
10792 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10794 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
10795 (Finsert_file_contents): Remove unnecessary code checking fd.
10797 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10798 Check for integer overflow on size calculations.
10800 * buffer.c (Fprevious_overlay_change): Remove var that is set
10803 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10804 Remove vars that are set but not used.
10805 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
10806 (timer_check_2): Mark vars as initialized.
10808 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10810 * image.c (lookup_image): Remove var that is set but not used.
10811 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
10813 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10814 that are set but not used.
10816 * xfns.c (make_invisible_cursor): Don't return garbage
10817 if XCreateBitmapFromData fails (Bug#8410).
10819 * xselect.c (x_get_local_selection, x_handle_property_notify):
10820 Remove vars that are set but not used.
10822 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
10823 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
10825 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10826 Remove var that is set but not used.
10827 (scroll_bar_windows_size): Now size_t, not int.
10828 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10829 Check for overflow.
10831 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10832 (map_tty_color) [!defined MSDOS]: Likewise.
10834 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10836 * coding.c: Remove vars that are set but not used.
10837 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10838 All callers changed.
10839 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10840 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10841 (decode_coding_charset): Remove vars that are set but not used.
10843 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10844 that is set but not used.
10846 * print.c (print_object): Remove var that is set but not used.
10848 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
10849 The gnulib version avoids calling malloc in the usual case,
10850 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10851 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10852 * filelock.c (current_lock_owner): Likewise.
10853 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10854 * sysdep.c: Include allocator.h, careadlinkat.h.
10855 (emacs_no_realloc_allocator): New static constant.
10856 (emacs_readlink): New function.
10857 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10858 ../lib/careadlinkat.h.
10860 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10862 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10863 first non-nil return value).
10865 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10867 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10868 if not defined (Bug#8403).
10870 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10872 * xdisp.c (display_count_lines): Remove parameter `start',
10873 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10874 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10875 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10876 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10877 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10878 and thereabouts. All callers changed.
10879 (get_per_char_metric): Remove parameter `f', unused since
10880 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10882 2011-04-02 Jim Meyering <meyering@redhat.com>
10884 do not dereference NULL upon failed strdup
10885 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10886 (ns_get_family): Likewise.
10888 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10890 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10892 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10894 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10897 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10899 Add lexical binding.
10901 * window.c (Ftemp_output_buffer_show): New fun.
10902 (Fsave_window_excursion):
10903 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10905 * lread.c (lisp_file_lexically_bound_p): New function.
10906 (Fload): Bind Qlexical_binding.
10907 (readevalloop): Remove `evalfun' arg.
10908 Bind Qinternal_interpreter_environment.
10909 (Feval_buffer): Bind Qlexical_binding.
10910 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10912 (syms_of_lread): Declare `lexical-binding'.
10914 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10916 * keyboard.c (eval_dyn): New fun.
10917 (menu_item_eval_property): Use it.
10919 * image.c (parse_image_spec): Use Ffunctionp.
10921 * fns.c (concat, mapcar1): Accept byte-code-functions.
10923 * eval.c (Fsetq): Handle lexical vars.
10924 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10925 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10926 (FletX, Flet): Obey lexical binding.
10927 (Fcommandp): Handle closures.
10928 (Feval): New `lexical' arg.
10929 (eval_sub): New function extracted from Feval. Use it almost
10930 everywhere where Feval was used. Look up vars in lexical env.
10932 (Ffunctionp): Move from subr.el.
10933 (Ffuncall): Handle closures.
10934 (apply_lambda): Remove `eval_flags'.
10935 (funcall_lambda): Handle closures and new byte-code-functions.
10936 (Fspecial_variable_p): New function.
10937 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10938 but without exporting it to Lisp.
10940 * doc.c (Fdocumentation, store_function_docstring):
10941 * data.c (Finteractive_form): Handle closures.
10943 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10946 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10948 (exec_byte_code): New function extracted from Fbyte_code to handle new
10949 calling convention for byte-code-functions. Add new byte-codes.
10951 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
10953 * alloc.c (Fmake_symbol): Init new `declared_special' field.
10955 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10957 * xdisp.c (redisplay_internal): Fix prototype.
10959 2011-03-31 Eli Zaretskii <eliz@gnu.org>
10961 * xdisp.c (SCROLL_LIMIT): New macro.
10962 (try_scrolling): Use it when setting scroll_limit.
10963 Limit scrolling to 100 screen lines.
10964 (redisplay_window): Even when falling back on "recentering",
10965 position point in the window according to scroll-conservatively,
10966 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10968 (try_scrolling): When point is above the window, allow searching
10969 as far as scroll_max, or one screenful, to compute vertical
10970 distance from PT to the scroll margin position. This prevents
10971 try_scrolling from unnecessarily failing when
10972 scroll-conservatively is set to a value slightly larger than the
10973 window height. Clean up the case of PT below the margin at bottom
10974 of window: scroll_max can no longer be INT_MAX. When aggressive
10975 scrolling is in use, don't let point enter the opposite scroll
10976 margin as result of the scroll.
10977 (syms_of_xdisp) <scroll-conservatively>: Document the
10978 threshold of 100 lines for never-recentering scrolling.
10980 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10982 * dispextern.h (move_it_by_lines):
10983 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10984 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10985 (message_log_check_duplicate): Remove parameters `prev_bol' and
10986 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10987 (redisplay_internal): Remove parameter `preserve_echo_area',
10988 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10990 * indent.c (Fvertical_motion):
10991 * window.c (window_scroll_pixel_based, Frecenter):
10992 Don't pass `need_y_p' to `move_it_by_lines'.
10994 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10996 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10997 steal a few bits to be more compact.
10998 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10999 Remove unneeded casts.
11001 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11003 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11005 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11006 binding" message (bug#7967).
11008 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11010 Fix more problems found by GCC 4.6.0's static checks.
11012 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11013 Remove unused local var.
11015 * editfns.c (Fmessage_box): Remove unused local var.
11017 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11018 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11019 Omit unused local vars.
11020 * window.c (shrink_windows): Omit unused local var.
11021 * menu.c (digest_single_submenu): Omit unused local var.
11022 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11023 Omit unused local var.
11025 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11026 Don't assume string length fits in int.
11027 (keyremap_step, read_key_sequence): Use size_t for sizes.
11028 (read_key_sequence): Don't check last_real_key_start redundantly.
11030 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11031 instead of alloca (Bug#8344).
11033 * eval.c (Fbacktrace): Don't assume nargs fits in int.
11034 (Fbacktrace_frame): Don't assume nframes fits in int.
11036 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11038 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11041 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11043 * cm.c (calccost): Turn while-do into do-while, for clarity.
11045 * keyboard.c (syms_of_keyboard): Use the same style as later
11046 in this function when indexing through an array. This also
11047 works around GCC bug 48267.
11049 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11051 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11053 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11054 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11056 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11057 This avoids undefined behavior on integer overflow, and is a bit
11058 more convenient anyway since it is compared to a size_t variable.
11060 Variadic C functions now count arguments with size_t, not int.
11061 This avoids an unnecessary limitation on 64-bit machines, which
11062 caused (substring ...) to crash on large vectors (Bug#8344).
11063 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11064 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
11065 All variadic functions and their callers changed accordingly.
11066 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11067 * data.c (arith_driver, float_arith_driver): Likewise.
11068 * editfns.c (general_insert_function): Likewise.
11069 * eval.c (struct backtrace.nargs, interactive_p)
11070 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11071 (funcall_lambda, mark_backtrace): Likewise.
11072 * fns.c (concat): Likewise.
11073 * frame.c (x_set_frame_parameters): Likewise.
11074 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11075 0 if not found, not -1. All callers changed.
11077 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11078 (stack_copy_size): Now size_t, not int.
11079 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11081 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11083 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11084 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11085 All callers changed.
11087 * lisp.h (multibyte_char_to_unibyte):
11088 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11089 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11090 * character.h (CHAR_TO_BYTE8):
11091 * cmds.c (internal_self_insert):
11092 * editfns.c (general_insert_function):
11093 * keymap.c (push_key_description):
11094 * search.c (Freplace_match):
11095 * xdisp.c (message_dolog, set_message_1): All callers changed.
11097 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11099 * keyboard.c (safe_run_hook_funcall): New function.
11100 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11101 don't set the hook to nil, but remove the offending function instead.
11102 (Qcommand_hook_internal): Remove, unused.
11103 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11104 Vcommand_hook_internal.
11106 * eval.c (enum run_hooks_condition): Remove.
11107 (funcall_nil, funcall_not): New functions.
11108 (run_hook_with_args): Call each function through a `funcall' argument.
11109 Remove `cond' argument, now redundant.
11110 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11111 (Frun_hook_with_args_until_failure): Adjust accordingly.
11112 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11114 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11116 * dispextern.h (string_buffer_position): Remove declaration.
11118 * print.c (strout): Remove parameter `multibyte', unused since
11119 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11121 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11122 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11123 All callers changed.
11125 * w32.c (_wsa_errlist): Use braces for struct initializers.
11127 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11128 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11129 All callers changed.
11130 (string_buffer_position): Likewise. Also, make static (it's never
11131 used outside xdisp.c).
11132 (cursor_row_p): Remove parameter `w', unused since
11133 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11134 (decode_mode_spec): Remove parameter `precision', introduced during
11135 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11136 All callers changed.
11138 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11140 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11142 2011-03-27 Anders Lindgren <andlind@gmail.com>
11144 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11145 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11146 (ns_update_auto_hide_menu_bar): New functions.
11147 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11148 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11149 ns_constrain_all_frames.
11150 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11151 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11153 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11155 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11157 2011-03-27 Glenn Morris <rgm@gnu.org>
11159 * syssignal.h: Replace RETSIGTYPE with void.
11160 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11161 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11162 Replace SIGTYPE with void everywhere.
11163 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11164 * s/template.h (SIGTYPE): Remove commented out definition.
11166 2011-03-26 Eli Zaretskii <eliz@gnu.org>
11168 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11169 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11171 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
11173 * w32.c (read_unc_volume): Use parameter `henum', instead of
11174 global variable `wget_enum_handle'.
11176 * keymap.c (describe_vector): Remove parameters `indices' and
11177 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11178 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11180 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11182 * keyboard.c (timer_check): Remove parameter `do_it_now',
11183 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11184 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11185 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11187 * keyboard.c (read_char):
11188 * w32menu.c (w32_menu_display_help):
11189 * xmenu.c (show_help_event, menu_help_callback):
11190 Adjust calls to `show_help_echo'.
11192 * gtkutil.c (xg_maybe_add_timer):
11193 * keyboard.c (readable_events):
11194 * process.c (wait_reading_process_output):
11195 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11197 * insdel.c (adjust_markers_gap_motion):
11198 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11199 (gap_left, gap_right): Don't call it.
11201 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
11203 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11204 incurred during fontification.
11206 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
11208 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11209 (DEFVAR_PER_BUFFER): Don't pass it.
11211 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11212 (scrolling_window): Don't pass it.
11214 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
11216 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11218 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11220 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11221 of variables specific to SELinux and computation of `encoded_absname'.
11223 * image.c (XPutPixel): Remove unused variable `height'.
11225 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11227 * unexw32.c (get_section_info): Remove unused variable `section'.
11229 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11230 (system_process_attributes): Remove unused variable `sess'.
11231 (sys_read): Remove unused variable `err'.
11233 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11234 (w32_wnd_proc): Remove unused variable `isdead'.
11235 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11236 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11237 (x_create_tip_frame): Remove unused variable `tem'.
11239 * w32inevt.c (w32_console_read_socket):
11240 Remove unused variable `no_events'.
11242 * w32term.c (x_draw_composite_glyph_string_foreground):
11243 Remove unused variable `width'.
11245 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
11247 * w32term.c (x_set_glyph_string_clipping):
11248 Don't pass uninitialized region to CombineRgn.
11250 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
11252 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11253 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11254 (Fx_close_connection): Remove unused variable `i'.
11256 * w32font.c (w32font_draw): Return number of glyphs.
11257 (w32font_open_internal): Remove unused variable `i'.
11258 (w32font_driver): Add missing initializer.
11260 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11261 (fill_in_menu): Remove unused variable `items_added'.
11263 * w32term.c (last_mouse_press_frame): Remove static global variable.
11264 (w32_clip_to_row): Remove unused variable `f'.
11265 (x_delete_terminal): Remove unused variable `i'.
11267 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11268 (NOTHING): Remove unused static global variable.
11269 (uniscribe_check_otf): Remove unused variable `table'.
11270 (uniscribe_font_driver): Add missing initializers.
11272 2011-03-23 Julien Danjou <julien@danjou.info>
11274 * term.c (Fsuspend_tty, Fresume_tty):
11275 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11276 * window.c (temp_output_buffer_show):
11277 * insdel.c (signal_before_change):
11278 * frame.c (Fhandle_switch_frame):
11279 * fileio.c (Fdo_auto_save):
11280 * emacs.c (Fkill_emacs):
11281 * editfns.c (save_excursion_restore):
11282 * cmds.c (internal_self_insert):
11283 * callint.c (Fcall_interactively):
11284 * buffer.c (Fkill_all_local_variables):
11285 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11287 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
11288 unconditionally since it does the check itself.
11290 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
11292 Fix more problems found by GCC 4.5.2's static checks.
11294 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11295 the first time through the loop, since we know p0 < p1 then.
11296 This also avoids a gcc -Wstrict-overflow warning.
11298 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11299 leading to a memory leak, possible in functions like
11300 load_charset_map_from_file that can allocate an unbounded number
11301 of objects (Bug#8318).
11303 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11304 that could (at least in theory) be that large.
11306 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11307 This is less likely to overflow, and avoids undefined behavior if
11308 overflow does occur. All callers changed. Use strtoul to scan
11309 for the unsigned long integer.
11310 (pint2hrstr): Simplify and tune code slightly.
11311 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
11313 * scroll.c (do_scrolling): Work around GCC bug 48228.
11314 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11316 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11317 This also avoids a warning with gcc -Wstrict-overflow.
11318 (validate_x_resource_name): Simplify count usage.
11319 This also avoids a warning with gcc -Wstrict-overflow.
11321 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11324 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
11326 * process.c (Fmake_network_process): Use socklen_t, not int,
11327 where POSIX says socklen_t is required in portable programs.
11328 This fixes a porting bug on hosts like 64-bit HP-UX, where
11329 socklen_t is wider than int (Bug#8277).
11330 (Fmake_network_process, server_accept_connection):
11331 (wait_reading_process_output, read_process_output):
11334 * process.c: Rename or move locals to avoid shadowing.
11335 (list_processes_1, Fmake_network_process):
11336 (read_process_output_error_handler, exec_sentinel_error_handler):
11337 Rename or move locals.
11338 (Fmake_network_process): Define label "retry_connect" only if needed.
11339 (Fnetwork_interface_info): Fix pointer signedness.
11340 (process_send_signal): Add cast to avoid pointer signedness problem.
11341 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
11342 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
11344 Make tparam.h and terminfo.c consistent.
11345 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11346 Include tparam.h instead, since it declares them.
11347 * cm.h (PC): Remove extern decl; tparam.h now does this.
11348 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11349 * terminfo.c: Include tparam.h, to check interfaces.
11350 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11351 (tparam): Adjust signature to match interface in tparam.h;
11352 this removes some undefined behavior. Check that outstring and len
11353 are zero, which they always are with Emacs.
11354 * tparam.h (PC, BC, UP): New extern decls.
11356 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
11357 (xftfont_open): Rename locals to avoid shadowing.
11359 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
11360 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11361 (OTF_TAG_SYM): Omit macro if not needed.
11362 (ftfont_list): Remove unused local.
11363 (get_adstyle_property, ftfont_pattern_entity):
11364 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11365 Rename locals to avoid shadowing.
11367 * xfont.c (xfont_list_family): Mark var as initialized.
11369 * xml.c (make_dom): Now static.
11371 * composite.c (composition_compute_stop_pos): Rename local to
11373 (composition_reseat_it): Remove unused locals.
11374 (find_automatic_composition, composition_adjust_point): Likewise.
11375 (composition_update_it): Mark var as initialized.
11376 (find_automatic_composition): Mark vars as initialized,
11377 with a FIXME (Bug#8290).
11379 character.h: Rename locals to avoid shadowing.
11380 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11381 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11382 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11383 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11384 to avoid shadowing.
11386 * textprop.c (property_change_between_p): Remove; unused.
11388 * intervals.c (interval_start_pos): Now static.
11390 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11392 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11393 Rename locals to avoid shadowing.
11395 * sound.c (wav_play, au_play, Fplay_sound_internal):
11396 Fix pointer signedness.
11397 (alsa_choose_format): Remove unused local var.
11398 (wav_play): Initialize a variable to 0, to prevent undefined
11399 behavior (Bug#8278).
11401 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11403 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11405 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11406 clobbering (Bug#8298).
11407 * sysdep.c (sys_subshell): Likewise.
11408 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
11410 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11411 This should get cleaned up, so that child_setup has the
11412 same signature on all platforms.
11414 * callproc.c (call_process_cleanup): Now static.
11415 (relocate_fd): Rename locals to avoid shadowing.
11417 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
11419 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11420 not to be necessary, and produces flickering.
11422 2011-03-20 Glenn Morris <rgm@gnu.org>
11424 * config.in: Remove file.
11426 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
11428 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11429 are now in src/globals.h.
11430 (syms_of_minibuf): Remove spurious & from previous change.
11432 2011-03-20 Leo Liu <sdl.web@gmail.com>
11434 * minibuf.c (completing-read-function): New variable.
11435 (completing-read-default): Rename from completing-read.
11436 (completing-read): Call completing-read-function.
11438 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11440 * xfaces.c (Fx_load_color_file):
11441 Read color file from absolute filename (bug#8250).
11443 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11445 * makefile.w32-in: Update dependencies.
11447 2011-03-17 Eli Zaretskii <eliz@gnu.org>
11449 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11451 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11453 Fix more problems found by GCC 4.5.2's static checks.
11455 * process.c (make_serial_process_unwind, send_process_trap):
11456 (sigchld_handler): Now static.
11458 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11459 That way, the code declares only the vars that it needs.
11460 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11461 * s/cygwin.h (PTY_ITERATION): Likewise.
11462 * s/darwin.h (PTY_ITERATION): Likewise.
11463 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11465 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11466 * process.c (allocate_pty): Don't declare stb unless it's needed.
11468 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
11469 (CONSTANTLIM): Remove; unused.
11470 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11471 Define only if needed.
11473 * unexelf.c (unexec): Name an expression,
11474 to avoid gcc -Wbad-function-cast warning.
11475 Use a different way to cause a compilation error if anyone uses
11476 n rather than nn, a way that does not involve shadowing.
11477 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
11479 * deps.mk (unexalpha.o): Remove; unused.
11481 New file unexec.h, the (simple) interface for unexec (Bug#8267).
11482 * unexec.h: New file.
11483 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11484 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11485 Depend on unexec.h.
11486 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11487 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11488 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
11489 Change as necessary to match prototype in unexec.h.
11491 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11493 (back_comment, skip_chars): Mark vars as initialized.
11495 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11496 Rename locals to avoid shadowing.
11498 * lread.c (read1): Rewrite so as not to use empty "else".
11499 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
11501 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11503 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11504 warning when compiling print.c.
11506 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11507 instead of using an uninitialized var.
11508 (font_sort_entities): Mark var as initialized.
11510 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11512 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11513 pointers to constants.
11514 (font_parse_fcname): Remove unused vars.
11515 (font_delete_unmatched): Now static.
11516 (font_get_spec): Remove; unused.
11517 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11518 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11519 Rename or move locals to avoid shadowing.
11521 * fns.c (require_nesting_list, require_unwind): Now static.
11522 (Ffillarray): Rename locals to avoid shadowing.
11524 * floatfns.c (domain_error2): Define only if needed.
11525 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
11527 * alloc.c (mark_backtrace): Move decl from here ...
11528 * lisp.h: ... to here, so that it can be checked.
11530 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
11531 (Fdefvar): Rewrite so as not to use empty "else".
11532 (lisp_indirect_variable): Name an expression,
11533 to avoid gcc -Wbad-function-cast warning.
11534 (Fdefvar): Rename locals to avoid shadowing.
11536 * callint.c (quotify_arg, quotify_args): Now static.
11537 (Fcall_interactively): Rename locals to avoid shadowing.
11538 Use const pointer when appropriate.
11540 * lisp.h (get_system_name, get_operating_system_release):
11541 Move decls here, to check interfaces.
11542 * process.c (get_operating_system_release): Move decl to lisp.h.
11543 * xrdb.c (get_system_name): Likewise.
11544 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11545 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11546 some of which prompt warnings from gcc -Wbad-function-cast.
11547 (Fformat_time_string, Fencode_time, Finsert_char):
11548 (Ftranslate_region_internal, Fformat):
11549 Rename or remove local vars to avoid shadowing.
11550 (Ftranslate_region_internal): Mark var as initialized.
11552 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11555 * lisp.h (eassert): Check that the argument compiles, even if
11556 ENABLE_CHECKING is not defined.
11558 * data.c (Findirect_variable): Name an expression, to avoid
11559 gcc -Wbad-function-cast warning.
11560 (default_value, arithcompare, arith_driver, arith_error): Now static.
11561 (store_symval_forwarding): Rename local to avoid shadowing.
11562 (Fmake_variable_buffer_local, Fmake_local_variable):
11563 Mark variables as initialized.
11564 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
11566 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
11567 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11568 Rename locals to avoid shadowing.
11569 (mark_stack): Move local variables into the #ifdef region where
11571 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11572 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11574 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11575 (GC_STRING_CHARS): Remove; not used.
11576 (Fmemory_limit): Cast sbrk's returned value to char *.
11578 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11579 avoids undefined behavior in theory.
11581 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11583 Use functions, not macros, for up- and down-casing (Bug#8254).
11584 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11585 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11586 to use the following functions instead of these macros.
11587 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11588 EMACS_INT, since callers assume the returned value fits in int.
11589 (upcase1): Likewise, for UPCASE_TABLE.
11590 (uppercasep, lowercasep, upcase): New static inline functions.
11591 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
11592 the race-condition problem in the old DOWNCASE.
11594 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11595 Rename locals to avoid shadowing.
11596 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
11597 (regex_compile, re_search_2, re_match_2_internal):
11598 Remove unused local vars.
11599 (FREE_VAR): Rewrite so as not to use empty "else",
11600 which gcc can warn about.
11601 (regex_compile, re_match_2_internal): Mark locals as initialized.
11602 (RETALLOC_IF): Define only if needed.
11603 (WORDCHAR_P): Likewise. This one is never needed, but is used
11604 only in a comment talking about a compiler bug, so put inside
11605 the #if 0 of that comment.
11606 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11607 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11610 * search.c (boyer_moore): Rename locals to avoid shadowing.
11611 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11612 (PREV_CHAR_BOUNDARY): Likewise.
11614 * search.c (simple_search): Remove unused var.
11616 * dired.c (compile_pattern): Move decl from here ...
11617 * lisp.h: ... to here, so that it can be checked.
11618 (struct re_registers): New forward decl.
11620 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11622 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11624 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11625 Rename locals to avoid shadowing.
11626 (Fvertical_motion): Mark locals as initialized.
11628 * casefiddle.c (casify_object, casify_region): Now static.
11629 (casify_region): Mark local as initialized.
11631 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11633 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11634 New macros, so that the caller can use some names other than
11635 gcpro1, gcpro2, etc.
11636 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11638 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11639 argument, for consistency with GCPRO2_VAR, etc: it is now the
11640 prefix of the variable, not the variable itself. All uses
11642 * dired.c (directory_files_internal, file_name_completion):
11643 Rename locals to avoid shadowing.
11645 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11646 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11647 dired.c's scmp function, had undefined behavior.
11648 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11649 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11650 * buffer.h: ... to here, because these macros use current_buffer,
11651 and the new implementation with inline functions needs to have
11652 current_buffer in scope now, rather than later when the macros
11654 (downcase, upcase1): New static inline functions.
11655 (DOWNCASE, UPCASE1): Reimplement using these functions.
11656 This avoids undefined behavior in expressions like
11657 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11658 from race conditions in accessing the global variables
11659 case_temp1 and case_temp2.
11660 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11661 * lisp.h (case_temp1, case_temp2): Remove their decls.
11662 * character.h (ASCII_CHAR_P): Move from here ...
11663 * lisp.h: ... to here, so that the inline functions mentioned
11664 above can use them.
11666 * dired.c (directory_files_internal_unwind): Now static.
11668 * fileio.c (file_name_as_directory, directory_file_name):
11669 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11671 (file_name_as_directory): Use const pointers when appropriate.
11672 (Fexpand_file_name): Likewise. In particular, newdir might
11673 point at constant storage, so make it a const pointer.
11674 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
11675 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11677 (Fset_file_times, Finsert_file_contents, auto_save_error):
11678 Rename locals to avoid shadowing.
11680 * minibuf.c (choose_minibuf_frame_1): Now static.
11681 (Ftry_completion, Fall_completions): Rename or remove locals
11682 to avoid shadowing.
11684 * marker.c (bytepos_to_charpos): Remove; unused.
11686 * lisp.h (verify_bytepos, count_markers): New decls,
11687 so that gcc does not warn that these functions aren't declared.
11689 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11690 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
11691 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
11692 (copy_text): Remove unused local var.
11694 * filelock.c (within_one_second): Now static.
11695 (lock_file_1): Rename local to avoid shadowing.
11697 * buffer.c (fix_overlays_before): Mark locals as initialized.
11698 (fix_start_end_in_overlays): Likewise. This function should be
11699 simplified by using pointers-to-pointers, but that's a different
11701 (switch_to_buffer_1): Now static.
11702 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11703 (report_overlay_modification): Rename locals to avoid shadowing.
11705 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
11706 Fix pointer signedness issue.
11707 (sys_subshell): Mark local as volatile if checking for lint,
11708 to suppress a gcc -Wclobbered warning that does not seem to be right.
11709 (MAXPATHLEN): Define only if needed.
11711 * process.c (serial_open, serial_configure): Move decls from here ...
11712 * systty.h: ... to here, so that they can be checked.
11714 * fns.c (get_random, seed_random): Move extern decls from here ...
11715 * lisp.h: ... to here, so that they can be checked.
11717 * sysdep.c (reset_io): Now static.
11718 (wait_for_termination_signal): Remove; unused.
11720 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11721 (copy_keymap_item, append_key, push_text_char_description):
11723 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
11724 (DENSE_TABLE_SIZE): Remove; unused.
11725 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11726 (describe_map_tree):
11727 Rename locals to avoid shadowing.
11729 * keyboard.c: Declare functions static if they are not used elsewhere.
11730 (echo_char, echo_dash, cmd_error, top_level_2):
11731 (poll_for_input, handle_async_input): Now static.
11732 (read_char, kbd_buffer_get_event, make_lispy_position):
11733 (make_lispy_event, make_lispy_movement, apply_modifiers):
11734 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11735 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11736 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
11737 (read_key_sequence, read_char): Mark locals as initialized.
11738 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
11740 * keyboard.h (make_ctrl_char): New decl.
11741 (mark_kboards): Move decl here ...
11742 * alloc.c (mark_kboards): ... from here.
11744 * lisp.h (force_auto_save_soon): New decl.
11746 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
11747 (DEFINE_DUMMY_FUNCTION): New macro.
11748 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11750 (main): Add casts to avoid warnings
11751 if GCC considers string literals to be constants.
11753 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11755 * dbusbind.c: Pointer signedness fixes.
11756 (xd_signature, xd_append_arg, xd_initialize):
11757 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11758 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11759 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11760 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11762 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11763 if GCC considers string literals to be constants.
11764 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
11766 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11768 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11769 (print_preprocess, print_object): New macro to fix last change.
11771 * print.c (print_preprocess): Don't forget font objects.
11773 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
11775 * emacs.c (USAGE3): Doc fixes.
11777 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11779 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11782 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
11784 * lisp.h (VWindow_system, Qfile_name_history):
11785 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11786 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11787 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11789 * w32select.c: Don't #include "keyboard.h".
11790 (run_protected): Add extern declaration for waiting_for_input.
11792 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11793 * w32console.c (detect_input_pending, read_input_pending)
11794 (encode_terminal_code):
11795 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11796 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11797 (w32_system_caret_y, Qfile_name_history):
11798 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11799 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11800 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11801 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11802 * w32proc.c (Qlocal, report_file_error):
11803 * w32term.c (Vwindow_system, updating_frame):
11804 * w32uniscribe.c (initialized, uniscribe_font_driver):
11805 Remove unneeded extern declarations.
11807 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
11809 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
11811 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
11813 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11814 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11815 These macros can no longer be used for assignment.
11817 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11818 Assign struct members directly, instead of using BUF_BEGV etc.
11819 (record_buffer_markers, fetch_buffer_markers): New functions for
11820 recording and fetching special buffer markers.
11821 (set_buffer_internal_1, set_buffer_temp): Use them.
11823 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11825 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11827 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11828 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11830 * xdisp.c (hscroll_window_tree):
11831 (reconsider_clip_changes): Use PT instead of BUF_PT.
11833 2011-03-13 Eli Zaretskii <eliz@gnu.org>
11835 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11836 $(EMACS_ROOT)/lib/intprops.h.
11838 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11840 Fix more problems found by GCC 4.5.2's static checks.
11842 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11843 to unsigned char * to avoid compiler diagnostic.
11844 (xg_free_frame_widgets): Make it clear that a local variable is
11845 needed only if USE_GTK_TOOLTIP.
11846 (gdk_window_get_screen): Make it clear that this macro is needed
11847 only if USE_GTK_TOOLTIP.
11848 (int_gtk_range_get_value): New function, which avoids a diagnostic
11849 from gcc -Wbad-function-cast.
11850 (xg_set_toolkit_scroll_bar_thumb): Use it.
11851 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11852 diagnostic from gcc -Wbad-function-cast.
11853 (get_utf8_string, xg_get_file_with_chooser):
11854 Rename locals to avoid shadowing.
11855 (create_dialog): Move locals to avoid shadowing.
11857 * xgselect.c (xg_select): Remove unused var.
11859 * image.c (four_corners_best): Mark locals as initialized.
11860 (gif_load): Initialize transparent_p to zero (Bug#8238).
11861 Mark another local as initialized.
11862 (my_png_error, my_error_exit): Mark with NO_RETURN.
11864 * image.c (clear_image_cache): Now static.
11865 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
11866 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
11867 (x_edge_detection): Remove unnecessary cast that
11868 gcc -Wbad-function-cast diagnoses.
11869 (gif_load): Fix pointer signedness.
11870 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11871 (jpeg_load, gif_load): Rename locals to avoid shadowing.
11873 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
11875 Improve quality of tests for time stamp overflow.
11876 For example, without this patch (encode-time 0 0 0 1 1
11877 1152921504606846976) returns the obviously-bogus value (-948597
11878 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11879 reports time overflow. See
11880 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
11881 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11882 * editfns.c: Include limits.h and intprops.h.
11883 (TIME_T_MIN, TIME_T_MAX): New macros.
11884 (time_overflow): Move earlier, to before first use.
11885 (hi_time, lo_time): New functions, for an accurate test for
11886 out-of-range times.
11887 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11888 (Fget_internal_run_time): Don't assume time_t fits in int.
11889 (make_time): Use list2 instead of Fcons twice.
11890 (Fdecode_time): More accurate test for out-of-range times.
11891 (check_tm_member): New function.
11892 (Fencode_time): Use it, to test for out-of-range times.
11893 (lisp_time_argument): Don't rely on undefined left-shift and
11894 right-shift behavior when checking for time stamp overflow.
11896 * editfns.c (time_overflow): New function, refactoring common code.
11897 (Fformat_time_string, Fdecode_time, Fencode_time):
11898 (Fcurrent_time_string): Use it.
11900 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11901 * dired.c (make_time): Move to ...
11902 * editfns.c (make_time): ... here.
11903 * systime.h: Note the move.
11905 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11907 * fringe.c (update_window_fringes): Remove unused variables.
11909 * unexmacosx.c (copy_data_segment): Also copy __got section.
11912 2011-03-12 Eli Zaretskii <eliz@gnu.org>
11914 * termcap.c [MSDOS]: Include "msdos.h".
11915 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11916 Constify `char *' arguments and their references according to
11917 prototypes in tparam.h.
11919 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
11921 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11922 Adapt all references accordingly.
11924 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11926 2011-03-11 Tom Tromey <tromey@redhat.com>
11928 * buffer.c (syms_of_buffer): Remove obsolete comment.
11930 2011-03-11 Eli Zaretskii <eliz@gnu.org>
11932 * termhooks.h (encode_terminal_code): Declare prototype.
11934 * msdos.c (encode_terminal_code): Don't declare prototype.
11936 * term.c (encode_terminal_code): Now external again, used by
11937 w32console.c and msdos.c.
11939 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11940 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
11942 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
11944 Fix some minor problems found by GCC 4.5.2's static checks.
11946 * fringe.c (update_window_fringes): Mark locals as initialized
11948 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
11950 * alloc.c (mark_fringe_data): Move decl from here ...
11951 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11952 to check its interface.
11953 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11955 * fontset.c (free_realized_fontset): Now static.
11956 (Fset_fontset_font): Rename local to avoid shadowing.
11957 (fontset_font): Mark local as initialized.
11958 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
11960 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11962 * xselect.c (x_disown_buffer_selections): Remove; not used.
11963 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
11964 (x_own_selection, Fx_disown_selection_internal): Rename locals
11965 to avoid shadowing.
11966 (x_handle_dnd_message): Remove local to avoid shadowing.
11968 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11969 so that the caller can use some name other than gcpro1.
11970 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
11971 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11972 (Fx_backspace_delete_keys_p):
11973 Use them to avoid shadowing, and rename vars to avoid shadowing.
11974 (x_decode_color, x_set_name, x_window): Now static.
11975 (Fx_create_frame): Add braces to silence GCC warning.
11976 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
11977 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11978 Remove unused locals.
11979 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11980 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11981 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11984 * xterm.h (x_mouse_leave): New decl.
11986 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11987 Remove unused functions.
11988 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11989 (x_calc_absolute_position): Now static.
11990 (XTread_socket): Don't define label "out" unless it's used.
11991 Don't declare local "event" unless it's used.
11992 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11993 unless they are used.
11994 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11995 (x_fatal_error_signal): Remove; not used.
11996 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11997 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11998 (x_error_catcher, x_connection_closed, x_error_handler):
11999 (x_error_quitter, xembed_send_message, x_iconify_frame):
12000 (my_log_handler): Rename locals to avoid shadowing.
12001 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
12002 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
12004 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12005 Rename or move locals to avoid shadowing.
12006 (tty_defined_color, merge_face_heights): Now static.
12007 (free_realized_faces_for_fontset): Remove; not used.
12008 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12009 does not deduce is never used uninitialized.
12010 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12011 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
12013 * terminal.c (store_terminal_param): Now static.
12015 * xmenu.c (menu_highlight_callback): Now static.
12016 (set_frame_menubar): Remove unused local.
12017 (xmenu_show): Rename parameter to avoid shadowing.
12018 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12019 since they might point to immutable storage.
12020 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12021 since it's unused otherwise.
12023 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
12024 Add a FIXME, since the code still doesn't look right. (Bug#8215)
12025 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12026 avoids a gcc -Wuninitialized diagnostic.
12027 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
12028 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12029 does not deduce are never used uninitialized.
12031 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12033 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
12034 * window.c (window_loop, size_window):
12035 (run_window_configuration_change_hook, enlarge_window): Likewise.
12037 * window.c (display_buffer): Now static.
12038 (size_window): Mark variables that gcc -Wuninitialized
12039 does not deduce are never used uninitialized.
12040 * window.h (check_all_windows): New decl, to forestall
12041 gcc -Wmissing-prototypes diagnostic.
12042 * dispextern.h (bidi_dump_cached_states): Likewise.
12044 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12046 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
12047 Include <limits.h>.
12048 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12049 and to avoid gcc -Wuninitialized warning.
12050 (load_charset_map): Mark variables that gcc -Wuninitialized
12051 does not deduce are never used uninitialized.
12052 (load_charset): Abort instead of using uninitialized var (Bug#8229).
12054 * coding.c (coding_set_source, coding_set_destination):
12055 Use "else { /* comment */ }" rather than "else /* comment */;"
12056 for clarity, and to avoid gcc -Wempty-body warning.
12057 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12058 a block, when the outer 'i' will do.
12059 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12060 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12061 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12062 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12063 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12064 Rename locals to avoid shadowing.
12065 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
12066 * coding.c (emacs_mule_char, encode_invocation_designation):
12067 Now static, since they're not used elsewhere.
12068 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
12069 (decode_coding_object, encode_coding_object, detect_coding_system):
12070 (decode_coding_emacs_mule): Mark variables that gcc
12071 -Wuninitialized does not deduce are never used uninitialized.
12072 (detect_coding_iso_2022): Initialize a local variable that might
12073 be used uninitialized. Leave a FIXME because it's not clear that
12074 this initialization is needed. (Bug#8211)
12075 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12076 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12077 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12078 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12079 Remove unused macros.
12081 * category.c (hash_get_category_set): Remove unused local var.
12082 (copy_category_table): Now static, since it's not used elsewhere.
12083 * character.c (string_count_byte8): Likewise.
12085 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12086 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12088 * chartab.c (copy_sub_char_table): Now static, since it's not used
12090 (sub_char_table_ref_and_range, char_table_ref_and_range):
12091 Rename locals to avoid shadowing.
12092 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
12094 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
12095 (BIDI_BOB): Remove unused macro.
12097 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12098 deduce are never used uninitialized.
12099 * term.c (encode_terminal_code): Likewise.
12101 * term.c (encode_terminal_code): Now static. Remove unused local.
12103 * tparam.h: New file.
12104 * term.c, tparam.h: Include it.
12105 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12106 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12107 Move these decls to tparam.h, and make them agree with what
12108 is actually in tparam.c. The previous trick of using incompatible
12109 decls in different modules does not conform to the C standard.
12110 All callers of tparam changed to use tparam's actual API.
12111 * tparam.c (tparam1, tparam, tgoto):
12112 Use const pointers where appropriate.
12114 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12115 * cm.h (struct cm): Likewise.
12116 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12117 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12118 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12119 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12120 (turn_on_face, init_tty): Likewise.
12121 * termchar.h (struct tty_display_info): Likewise.
12123 * term.c (term_mouse_position): Rename local to avoid shadowing.
12125 * alloc.c (mark_ttys): Move decl from here ...
12126 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12128 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12130 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12132 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
12134 * search.c (compile_pattern_1): Remove argument regp, unused since
12135 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12136 (compile_pattern): Don't pass it.
12138 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12140 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12141 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12143 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12145 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12147 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12148 gdk_window_get_screen, gdk_window_get_geometry,
12149 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12150 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12151 (xg_get_pixbuf_from_pixmap): New function.
12152 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12153 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12154 Call xg_get_pixbuf_from_pixmap instead of
12155 gdk_pixbuf_get_from_drawable.
12156 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12157 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12158 (xg_check_special_colors): Use GtkStyleContext and its functions
12160 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12161 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12162 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
12163 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12164 Call gtk_widget_get_preferred_size.
12165 (xg_frame_resized): gdk_window_get_geometry only takes 5
12167 (xg_win_to_widget, xg_event_is_for_menubar):
12168 Call gdk_x11_window_lookup_for_display.
12169 (xg_set_widget_bg): New function.
12170 (delete_cb): New function.
12171 (xg_create_frame_widgets): Connect delete-event to delete_cb.
12172 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
12173 (xg_set_background_color): Call xg_set_widget_bg.
12174 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12175 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12176 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12177 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12179 (update_frame_tool_bar): Call gtk_widget_hide.
12180 (xg_initialize): Use GDK_KEY_g.
12182 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12184 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12186 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12187 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12188 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12190 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
12192 * w32xfns.c (select_palette): Check success of RealizePalette against
12193 GDI_ERROR, not zero.
12195 See ChangeLog.11 for earlier changes.
12197 ;; Local Variables:
12201 Copyright (C) 2011-2012 Free Software Foundation, Inc.
12203 This file is part of GNU Emacs.
12205 GNU Emacs is free software: you can redistribute it and/or modify
12206 it under the terms of the GNU General Public License as published by
12207 the Free Software Foundation, either version 3 of the License, or
12208 (at your option) any later version.
12210 GNU Emacs is distributed in the hope that it will be useful,
12211 but WITHOUT ANY WARRANTY; without even the implied warranty of
12212 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12213 GNU General Public License for more details.
12215 You should have received a copy of the GNU General Public License
12216 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.