1 2012-01-10 Glenn Morris <rgm@gnu.org>
3 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
6 Update template values to be closer to their typical values these days.
8 2012-01-09 Eli Zaretskii <eliz@gnu.org>
10 * xdisp.c (rows_from_pos_range): Accept additional argument
11 DISP_STRING, and accept any glyph in a row whose object is that
12 string as eligible for mouse highlight. Fixes mouse highlight of
13 display strings from overlays. (Bug#10464)
15 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
17 emacs: fix an auto-save permissions race condition (Bug#10400)
18 * fileio.c (auto_saving_dir_umask): New static var.
19 (Fmake_directory_internal): Use it.
20 (do_auto_save_make_dir): Set it, instead of invoking chmod after
21 creating the directory. The old code temporarily assigns
22 too-generous permissions to the directory.
23 (do_auto_save_eh): Clear it.
24 (Fdo_auto_save): Catch all errors, not just file errors, so
25 that the var is always cleared.
27 2012-01-07 Eli Zaretskii <eliz@gnu.org>
29 * search.c (scan_buffer): Pass character positions to
30 know_region_cache, not byte positions. (Bug#6540)
32 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
34 * w32.c (sys_rename): Report EXDEV when rename of a directory
35 fails because the target is on another logical disk. (Bug#10284)
37 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
39 * xterm.c (x_embed_request_focus): New function.
41 * xterm.h: Add prototype.
43 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
45 2012-01-05 Glenn Morris <rgm@gnu.org>
47 * emacs.c (emacs_copyright): Update short copyright year to 2012.
49 2012-01-01 Eli Zaretskii <eliz@gnu.org>
51 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
52 Load gnutls_transport_set_lowat only if GnuTLS version is below
54 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
55 GnuTLS versions below 2.11.1.
57 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
59 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
60 to the doc string advising against its use for altering the way
63 2011-12-28 Kenichi Handa <handa@m17n.org>
65 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
66 coding-system ASCII compatible only when it does not produce BOM
67 on encoding (Bug#10383).
69 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
71 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
73 (create_and_show_popup_menu): Always use menu_position_func for
76 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
78 * callint.c (Fcall_interactively): Don't truncate prompt string.
80 2011-12-23 Eli Zaretskii <eliz@gnu.org>
82 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
83 property that ends at ZV, so that the bidi iteration could be
84 resumed from there (after widening). (Bug#10360)
86 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
88 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
90 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
92 * nsterm.m (x_free_frame_resources):
93 Release f->output_data.ns->miniimage.
94 (ns_index_color): Fix indentation. Do not retain
95 color_table->colors[i].
97 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
100 * nsfns.m (x_set_background_color): Assign return value from
101 ns_index_color to face-background instead of NSColor*.
102 (ns_implicitly_set_icon_type): Fix indentation.
103 Change assignment in for loop to comparison.
105 * emacs.c (ns_pool): New variable.
106 (main): Assign ns_pool.
107 (Fkill_emacs): Call ns_release_autorelease_pool.
109 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
110 autorelease fdesc, release fdAttrs and tdict.
111 (ns_get_covering_families): Release charset.
112 (ns_findfonts): Release NSFontDescriptor created with new.
113 (ns_uni_to_glyphs): Fix indentation.
114 (setString): Release attrStr before assigning new value.
116 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
118 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
120 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
121 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
123 2011-12-18 David Reitter <reitter@cmu.edu>
125 * nsterm.m (ns_term_init): Subscribe for notifications
126 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
127 to method trackingNotification in EmacsMenu.
129 * nsmenu.m (trackingMenu): New variable.
130 (trackingNotification): New method (from Aquamacs).
131 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
132 from Aquamacs (Bug#7030).
134 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
136 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
137 (symbol_to_nsstring): Fix indentation.
138 (ns_symbol_to_pb): New function.
139 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
140 (Fns_rotate_cut_buffers_internal): Removed.
141 (Fns_store_selection_internal): Renamed from
142 Fns_store_cut_buffer_internal.
143 (ns_get_foreign_selection, Fx_own_selection_internal)
144 (Fx_disown_selection_internal, Fx_selection_exists_p)
145 (Fns_get_selection_internal, Fns_store_selection_internal):
146 Use ns_symbol_to_pb and check if return value is nil.
147 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
148 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
149 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
150 renamed to Sns_store_selection_internal.
151 (ns_handle_selection_request): Move code to Fx_own_selection_internal
152 and remove this function.
153 (ns_handle_selection_clear): Remove, never used.
154 (Fx_own_selection_internal): Move code from ns_handle_selection_request
157 2011-12-17 Ken Brown <kbrown@cornell.edu>
159 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
160 GID is unknown (Bug#10257).
162 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
164 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
165 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
166 which caused a build failure on GNU/Linux IA-64. This problem was
167 introduced by my 2011-10-07 patch.
169 2011-12-15 Juri Linkov <juri@jurta.org>
171 * image.c (imagemagick_error): New function. (Bug#10112)
172 (imagemagick_load_image): Comment out `MagickSetResolution' call.
173 Use `imagemagick_error' where ImageMagick functions return
175 (Fimagemagick_types): Add `Fnreverse' to return the list in the
178 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
180 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
181 fill background (Bug#8992).
183 2011-12-13 Martin Rudalics <rudalics@gmx.at>
185 * window.c (Vwindow_combination_resize)
186 (Vwindow_combination_limit): Use t instead of non-nil in
188 (Vrecenter_redisplay): Add first sentence of doc-string on
190 (Frecenter): Fix doc-string typo.
192 2011-12-11 Kenichi Handa <handa@m17n.org>
194 * coding.c (Funencodable_char_position): Pay attention to the
195 buffer text relocation (Bug#9389).
197 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
199 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
200 gtk_init (Bug#10100).
202 2011-12-10 Eli Zaretskii <eliz@gnu.org>
204 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
205 IT->string is nil. (Bug#10263)
207 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
209 * nsterm.h (x_free_frame_resources): Declare.
211 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
212 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
214 * nsterm.h (ns_get_defaults_value): Declare.
216 * nsterm.m (ns_default): Call ns_get_defaults_value.
218 2011-12-09 Eli Zaretskii <eliz@gnu.org>
220 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
223 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
225 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
226 that where the value of an _OBJC_* symbol points to is in the .bss
229 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
231 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
232 after the loop to call ccl_driver at least once (Bug#8619).
234 2011-12-08 Kenichi Handa <handa@m17n.org>
236 * ftfont.c (get_adstyle_property): Fix previous change
239 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
241 * w32.c (init_environment): If no_site_lisp, remove site-lisp
242 dirs from the default value of EMACSLOADPATH (bug#10208).
244 2011-12-07 Glenn Morris <rgm@gnu.org>
246 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
247 installation and source directories as well. (Bug#10208)
249 2011-12-06 Chong Yidong <cyd@gnu.org>
251 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
253 2011-12-06 Glenn Morris <rgm@gnu.org>
255 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
256 as an error, not just -1. (Bug#10217)
258 2011-12-05 Chong Yidong <cyd@gnu.org>
260 * keyboard.c (process_special_events): New function.
261 (swallow_events, Finput_pending_p): Use it (Bug#10195).
263 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
265 * coding.c (encode_designation_at_bol): Don't use uninitialized
266 local variable (Bug#9318).
268 2011-12-05 Kenichi Handa <handa@m17n.org>
270 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
271 return Qnil (Bug#8046, Bug#10193).
273 2011-12-05 Kenichi Handa <handa@m17n.org>
275 * coding.c (encode_designation_at_bol): New args charbuf_end and
276 dst. Return the number of produced bytes. Callers changed.
277 (coding_set_source): Return how many bytes coding->source was
279 (coding_set_destination): Return how many bytes
280 coding->destination was relocated.
281 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
282 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
284 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
286 * coding.c (CODING_CHAR_CHARSET_P): New macro.
287 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
290 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
292 The following changes are to fix Bug#9318.
294 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
295 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
296 (encode_coding_iso_2022, encode_coding_sjis)
297 (encode_coding_big5, encode_coding_charset): Use the above macros.
299 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
301 * lisp.h (process_quit_flag): Fix external declaration.
303 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
305 Don't macro-inline non-performance-critical code.
306 * eval.c (process_quit_flag): New function.
307 * lisp.h (QUIT): Use it.
309 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
311 * nsfns.m (get_geometry_from_preferences): New function.
312 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
314 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
316 * emacs.c (Qkill_emacs): Define.
317 (syms_of_emacs): Initialize it.
318 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
319 Qquit_flag to `kill-emacs' instead.
320 (quit_throw_to_read_char): Add parameter `from_signal'.
321 All callers changed. Call Fkill_emacs if requested and safe.
322 * lisp.h (QUIT): Call Fkill_emacs if requested.
324 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
326 * widget.c (update_wm_hints): Return if wmshell is null.
327 (widget_update_wm_size_hints): New function.
329 * widget.h (widget_update_wm_size_hints): Declare.
331 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
332 widget_update_wm_size_hints (Bug#10104).
334 2011-12-03 Eli Zaretskii <eliz@gnu.org>
336 * xdisp.c (handle_invisible_prop): If the invisible text ends just
337 before a newline, prepare the bidi iterator for consuming the
338 newline, and keep the current paragraph direction. (Bug#10183)
339 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
341 2011-12-02 Juri Linkov <juri@jurta.org>
343 * search.c (Fword_search_regexp): New Lisp function created from
344 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
345 (Fword_search_backward, Fword_search_forward)
346 (Fword_search_backward_lax, Fword_search_forward_lax):
347 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
348 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
350 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
352 * fileio.c (Finsert_file_contents): Move after-change-function call
353 to before the "handled:" label, since all "goto handled" appear in
354 cases where the *-change-functions have already been properly called
357 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
359 * keyboard.c (interrupt_signal): Don't call kill-emacs when
360 waiting for input. (Bug#10169)
362 2011-11-30 Eli Zaretskii <eliz@gnu.org>
364 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
365 verifies glyph row's hash code--we have just reallocated the
366 glyphs, so their contents can be complete garbage. (Bug#10164)
368 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
370 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
372 2011-11-30 Eli Zaretskii <eliz@gnu.org>
374 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
375 attributes are tested _before_ calling verify_row_hash, to protect
376 against GCC re-ordering of the tests. (Bug#10164)
378 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
380 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
382 * xterm.c (handle_one_xevent): Only set async_visible and friends
383 if net_wm_state_hidden_seen is non-zero (Bug#10002)
384 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
385 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
387 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
389 Remove GCPRO-related macros that exist only to avoid shadowing locals.
390 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
391 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
392 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
393 All uses changed to use GCPRO1 etc.
394 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
395 Revert to old implementation (i.e., before 2011-03-11).
397 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
399 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
400 of scroll runs so as to avoid assigning disabled bogus rows and
401 unnecessary graphics copy operations.
403 2011-11-27 Eli Zaretskii <eliz@gnu.org>
405 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
406 (snprintf) [_MSC_VER]: Redirect to _snprintf.
407 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
408 (malloc, free, realloc, calloc): Redirect to e_* only when
411 * lisp.h (GCTYPEBITS): Move before first use.
412 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
413 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
414 this macro definition.
416 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
419 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
421 * gtkutil.c (xg_create_frame_widgets):
422 Call gtk_window_set_has_resize_grip (FALSE) if that function is
423 present with Gtk+ 2.0.
425 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
427 * fileio.c (Finsert_file_contents): Undo previous change; see
428 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
430 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
432 Rename locals to avoid shadowing.
433 * fileio.c (Finsert_file_contents):
434 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
435 * process.c (wait_reading_process_output):
436 Rename inner 'proc' to 'p' to avoid shadowing.
437 Indent for consistency with usual Emacs style.
439 2011-11-25 Eli Zaretskii <eliz@gnu.org>
441 * xdisp.c (redisplay_window): If cursor row is not fully visible
442 after recentering, and scroll-conservatively is set to a large
443 number, scroll window by a few more lines to make the cursor fully
444 visible and out of scroll-margin. (Bug#10105)
445 (start_display): Don't move to the next line if the display should
446 start at a newline that is part of a display vector or an overlay
449 2011-11-24 Juri Linkov <juri@jurta.org>
451 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
452 after the `MagickPingImage' call. (Bug#10112)
454 2011-11-23 Chong Yidong <cyd@gnu.org>
456 * window.c (Fcoordinates_in_window_p): Accept only live windows.
458 2011-11-23 Martin Rudalics <rudalics@gmx.at>
460 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
461 making another buffer current. (Bug#10114)
463 2011-11-23 Glenn Morris <rgm@gnu.org>
465 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
467 2011-11-23 Chong Yidong <cyd@gnu.org>
469 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
472 2011-11-22 Eli Zaretskii <eliz@gnu.org>
474 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
475 and header-lines, as they don't have one computed for them.
478 * .gdbinit (prow): Make displayed values more self-explaining.
481 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
483 * process.c (wait_reading_process_output): Fix asynchrounous
484 GnuTLS socket handling on some versions of the GnuTLS library.
485 (wait_reading_process_output): Add comment and URL.
487 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
489 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
491 2011-11-21 Chong Yidong <cyd@gnu.org>
493 * window.c (Fnext_window, Fprevious_window): Doc fix.
495 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
497 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
499 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
501 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
503 2011-11-20 Martin Rudalics <rudalics@gmx.at>
505 * window.c (Fset_window_combination_limit): Rename argument
507 (Vwindow_combination_limit): Remove "status" from doc-string.
509 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
511 * m/ibms390.h: Remove.
512 * m/ibms390x.h: Don't include "ibms390.h".
514 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
516 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
517 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
519 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
521 * casetab.c (Fset_case_table):
522 * charset.c (Fcharset_after): Fix typos.
524 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
526 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
527 Otherwise, valgrind does not work on some platforms.
528 Problem reported by Andreas Schwab in
529 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
530 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
531 is set, removing the need for VIRT_ADDRESS_VARIES.
532 (PURE_P): Use a more-efficient implementation that needs just one
533 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
534 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
535 to 4 (xorl, subq, cmpq, setbe).
536 * alloc.c (pure): Always extern now, since that's the
537 VIRT_ADDR_VARIES behavior.
538 (PURE_POINTER_P): Use a single comparison, not two, for
539 consistency with the new puresize.h.
540 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
541 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
542 Remove VIRT_ADDR_VARIES no longer needed.
544 2011-11-19 Eli Zaretskii <eliz@gnu.org>
546 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
547 (erase_phys_cursor, update_window_cursor, show_mouse_face)
548 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
549 behave as if the cursor position were at the window margin.
551 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
552 and the cursor position is out of bounds, behave as if the cursor
553 position were at the window margin. (Bug#10075)
555 2011-11-18 Chong Yidong <cyd@gnu.org>
557 * window.c (Fwindow_combination_limit): Make first argument
558 non-optional, since it is meaningless for live windows like the
561 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
563 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
565 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
567 * intervals.c: Fix grafting over the whole buffer (bug#10071).
568 (graft_intervals_into_buffer): Simplify.
570 2011-11-18 Eli Zaretskii <eliz@gnu.org>
572 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
573 hash values of the two rows.
574 (copy_row_except_pointers): Preserve the used[] arrays and the
575 hash values of the two rows. (Bug#10035)
576 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
578 * xdisp.c (row_hash): New function, body extracted from
579 compute_line_metrics.
580 (compute_line_metrics): Call row_hash, instead of computing the
583 * dispnew.c (verify_row_hash): Call row_hash for computing the
584 hash code of a row, instead of duplicating code from xdisp.c.
586 * dispextern.h (row_hash): Add prototype.
588 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
590 * frame.c (delete_frame): Don't delete the terminal when the last
591 X frame is closed if emacs is built with GTK toolkit.
593 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
595 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
597 2011-11-17 Martin Rudalics <rudalics@gmx.at>
599 * window.c (Vwindow_splits): Rename to
600 Vwindow_combination_resize. Suggested by Juri Linkov.
601 (Fsplit_window_internal): Use Vwindow_combination_resize instead
604 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
606 * nsfns.m (Fns_font_name):
607 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
609 2011-11-16 Martin Rudalics <rudalics@gmx.at>
611 * window.h (window): Rename slot "nest" to "combination_limit".
612 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
613 (Fset_window_nest): Rename to Fset_window_combination_limit.
614 (Vwindow_nest): Rename to Vwindow_combination_limit.
615 (recombine_windows, make_parent_window, make_window)
616 (Fsplit_window_internal, saved_window)
617 (Fset_window_configuration, save_window_save): Rename all
618 occurrences of window_nest to window_combination_limit.
620 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
622 * image.c (imagemagick_load_image): Fix typo.
624 2011-11-14 Eli Zaretskii <eliz@gnu.org>
626 * xdisp.c (display_line): Move the call to
627 highlight_trailing_whitespace before the call to
628 compute_line_metrics, since the latter needs to see the final
629 faces of all the glyphs to compute ROW's hash value.
630 Fixes assertion violations in row_equal_p. (Bug#10035)
632 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
634 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
635 just return (bug#10044).
637 2011-11-12 Eli Zaretskii <eliz@gnu.org>
639 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
640 with user-defined heap size. Bump the default size of the temacs
641 heap to 27MB, to avoid memory warning when running temacs.
642 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
644 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
645 current_matrix and desired_matrix. (Bug#9990)
646 (verify_row_hash) [XASSERTS]: New function.
647 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
648 that the hash value of glyph rows is correct.
650 2011-11-12 Martin Rudalics <rudalics@gmx.at>
652 * window.h (window): Remove splits slot.
653 * window.c (Fwindow_splits, Fset_window_splits): Remove.
654 (Fdelete_other_windows_internal, make_parent_window)
655 (make_window, Fsplit_window_internal, Fdelete_window_internal)
656 (Fset_window_configuration, save_window_save): Don't deal with
657 split status of windows.
658 (saved_window): Remove splits slot.
659 (Vwindow_splits): Rewrite doc-string.
661 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
663 * xfns.c (unwind_create_frame):
664 * nsfns.m (unwind_create_frame):
665 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
666 Vframe_list (Bug#9999).
668 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
670 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
672 2011-11-11 Kenichi Handa <handa@m17n.org>
674 * callproc.c (Fcall_process): Set the member dst_multibyte of
677 2011-11-11 Johan Bockgård <bojohan@gnu.org>
679 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
680 avoid a crash (bug#9496).
682 2011-11-09 Chong Yidong <cyd@gnu.org>
684 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
685 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
687 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
689 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
691 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
693 Avoid some portability problems by eschewing 'extern inline' functions.
694 The trivial performance wins aren't worth the portability hassles; see
695 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
697 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
698 (window_box_width, window_box_left, window_box_left_offset)
699 (window_box_right, window_box_right_offset): Undo previous change,
700 by removing the "extern"s.
701 * intervals.c (adjust_intervals_for_insertion)
702 (adjust_intervals_for_deletion): Undo previous change,
703 making these static again.
704 (offset_intervals, temp_set_point_both, temp_set_point)
705 (copy_intervals_to_string): No longer inline.
706 * xdisp.c (window_text_bottom_y, window_box_width)
707 (window_box_height, window_box_left_offset)
708 (window_box_right_offset, window_box_left, window_box_right)
709 (window_box): No longer inline.
711 2011-11-08 Chong Yidong <cyd@gnu.org>
713 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
714 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
715 Signal an error if not a live window.
716 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
717 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
719 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
721 * lisp.h (syms_of_abbrev): Remove declaration.
722 Reported by CHENG Gao <chenggao@royau.me>.
724 2011-11-07 Eli Zaretskii <eliz@gnu.org>
726 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
727 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
728 of temacs in GUI mode.
730 2011-11-07 Martin Rudalics <rudalics@gmx.at>
732 * window.h: Declare delete_all_child_windows instead of
733 delete_all_subwindows.
734 * window.c (Fwindow_nest, Fset_window_nest)
735 (Fset_window_new_total, Fset_window_new_normal)
736 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
737 (delete_all_subwindows): Rename to delete_all_child_windows.
738 (Fdelete_other_windows_internal, Fset_window_configuration):
739 Call delete_all_child_windows instead of delete_all_subwindows.
740 * frame.c (delete_frame): Call delete_all_child_windows instead
741 of delete_all_subwindows.
743 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
745 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
746 This is also needed for porting to any host where GC_MARK_STACK is
747 not GC_MAKE_GCPROS_NOOPS.
748 (which_symbols): Use it.
750 2011-11-07 Kenichi Handa <handa@m17n.org>
752 * coding.c (coding_set_destination): Check coding->src_pos only
753 when coding->src_object is a buffer (bug#9910).
755 * process.c (send_process): Set the member src_multibyte of coding
756 to 0 (bug#9911) when sending a unibyte text.
758 * callproc.c (Fcall_process): Set the member src_multibyte of
759 process_coding to 0 (bug#9912).
761 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
763 * xmenu.c (cleanup_widget_value_tree): New function.
764 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
765 calling free_menubar_widget_value_tree directly (Bug#9830).
767 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
769 Fix some portability problems with 'inline'.
770 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
771 (window_box_width, window_box_left, window_box_left_offset)
772 (window_box_right, window_box_right_offset): Declare extern.
773 Otherwise, these inline functions do not conform to C99 and
774 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
775 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
776 * intervals.c (adjust_intervals_for_insertion)
777 (adjust_intervals_for_deletion): Now extern, because otherwise the
778 extern inline functions 'offset_intervals' couldn't refer to it.
779 (static_offset_intervals): Remove.
780 (offset_intervals): Rewrite using the old contents of
781 static_offset_intervals. The old version didn't conform to C99
782 because an extern inline function contained a reference to an
783 identifier with static linkage.
785 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
787 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
790 2011-11-06 Eli Zaretskii <eliz@gnu.org>
792 * xdisp.c (init_iterator, reseat_to_string): Don't set the
793 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
794 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
795 return Qleft_to_right.
797 2011-11-06 Chong Yidong <cyd@gnu.org>
799 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
800 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
801 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
802 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
803 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
804 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
805 (Fwindow_vscroll): Doc fix.
806 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
807 argument, since it makes no sense to pass a live window and for
808 consistency with window-child.
810 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
812 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
815 2011-11-05 Jason Rumney <jasonr@gnu.org>
817 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
818 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
820 (add_font_entity_to_list): Fix logic errors in mixed boolean and
821 bitwise arithmetic preventing use of unicode-sip and non-truetype
824 2011-11-05 Eli Zaretskii <eliz@gnu.org>
826 * s/ms-w32.h (fstat, stat, utime): Move redirections to
829 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
830 initialization code to keep similarity to xfns.c after changes
833 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
835 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
836 (unwind_create_frame): New function (Bug#9943).
837 (Fx_create_frame): Restructure code to be more similar to the one in
838 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
839 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
840 Move terminal->reference_count++ just before making the frame official
843 * nsterm.m (x_free_frame_resources): New function.
844 (x_destroy_window): Move code to x_free_frame_resources.
846 * xfns.c (unwind_create_frame): Fix comment.
847 (Fx_create_frame, x_create_tip_frame):
848 Move terminal->reference_count++ just before making the frame
849 official. Move initialization of image_cache_refcount and
850 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
852 2011-11-05 Eli Zaretskii <eliz@gnu.org>
854 Support MSVC build with newer versions of Visual Studio.
855 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
856 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
859 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
860 which are not supported by MSVC.
861 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
862 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
864 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
866 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
868 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
870 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
872 Support MSVC build with newer versions of Visual Studio.
873 * w32.c: Don't include w32api.h for MSVC.
874 (init_environment) [_MSC_VER]: Call sys_access, not _access.
876 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
877 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
878 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
879 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
881 (alloca) [_MSC_VER]: Define to _alloca.
883 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
885 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
887 2011-11-04 Eli Zaretskii <eliz@gnu.org>
889 * xdisp.c (note_mouse_highlight): If either of
890 previous/next-single-property-change returns nil, treat that as
891 the beginning or the end of the buffer. (Bug#9955)
893 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
895 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
896 label is not null (Bug#9951).
897 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
900 2011-11-04 Eli Zaretskii <eliz@gnu.org>
902 * window.c (Fwindow_body_size): Mention in the doc string that the
903 return value is in frame's canonical units. (Bug#9949)
905 2011-11-03 Eli Zaretskii <eliz@gnu.org>
907 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
909 * w32fns.c (unwind_create_frame): If needed, free the glyph
910 matrices of the partially constructed frame. (Bug#9943)
911 * xfns.c (unwind_create_frame): Likewise.
913 2011-11-01 Eli Zaretskii <eliz@gnu.org>
915 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
916 Don't stop backward scan on the continuation glyph, even though
917 its CHARPOS is positive.
918 (mouse_face_from_buffer_pos, note_mouse_highlight):
919 Rename cover_string to disp_string.
921 2011-11-01 Martin Rudalics <rudalics@gmx.at>
923 * window.c (temp_output_buffer_show): Don't use
924 Vtemp_buffer_show_specifiers.
925 (Vtemp_buffer_show_specifiers): Remove unused variable.
927 2011-10-30 Eli Zaretskii <eliz@gnu.org>
929 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
930 past the beginning of the current glyph matrix.
932 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
934 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
935 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
936 HAVE_GTK3 (Bug#9869).
938 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
939 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
941 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
943 * xterm.c: Declare x_handle_net_wm_state to return int.
944 (handle_one_xevent): Check if we are iconified but don't have
945 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
946 (get_current_wm_state): Return non-zero if not hidden,
947 check for _NET_WM_STATE_HIDDEN (Bug#9893).
948 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
949 (x_handle_net_wm_state): Return what get_current_wm_state returns.
950 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
952 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
954 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
955 so that this new function doesn't get optimized away by a
956 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
958 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
960 * frame.h (MOUSE_HL_INFO): Remove excess parens.
962 2011-10-29 Eli Zaretskii <eliz@gnu.org>
964 Fix the `xbytecode' command.
965 * .gdbinit (xprintbytestr): New command.
966 (xwhichsymbols): Rename from `which'; all callers changed.
967 (xbytecode): Print the byte-code string as well.
969 2011-10-29 Kim Storm <storm@cua.dk>
971 * alloc.c (which_symbols): New function.
973 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
975 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
978 2011-10-29 Glenn Morris <rgm@gnu.org>
980 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
981 Not clear what it was for, and it causes various bugs. (Bug#9839)
983 2011-10-28 Eli Zaretskii <eliz@gnu.org>
985 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
986 possible random value that matches one of those tested as
987 condition to clear the mouse face.
989 2011-10-28 Chong Yidong <cyd@gnu.org>
991 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
993 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
995 * window.c (make_window): Initialize phys_cursor_on_p.
997 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
999 * lisp.h (struct Lisp_Symbol): Update comments.
1001 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1003 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1005 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1007 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1008 <oslsachem@gmail.com> for helping to debug this.
1010 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1011 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1012 (g_b_init_get_glyph_outline_w): New static variables.
1013 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1014 (GetGlyphOutlineW_Proc): New typedefs.
1015 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1016 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1018 (w32font_open_internal, compute_metrics):
1019 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1020 instead of calling the "wide" APIs directly.
1022 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1024 * w32.h (syms_of_w32font): Add prototype.
1026 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1028 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1029 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1030 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1031 (Fmove_to_window_line): Doc fix.
1033 2011-10-27 Chong Yidong <cyd@gnu.org>
1035 * process.c (make_process): Set gnutls_state to NULL.
1037 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1038 non-NULL, regardless of GNUTLS_INITSTAGE.
1039 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1040 an error. Set process slots as soon as we allocate them.
1042 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1044 2011-10-27 Chong Yidong <cyd@gnu.org>
1046 * gnutls.c (emacs_gnutls_deinit): New function.
1047 Deallocate credentials structures as well as calling gnutls_deinit.
1048 (Fgnutls_deinit, Fgnutls_boot): Use it.
1050 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1051 (deactivate_process): Call emacs_gnutls_deinit.
1053 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1055 * image.c (x_create_x_image_and_pixmap):
1056 * w32.c (sys_rename, w32_delayed_load):
1057 * w32font.c (fill_in_logfont):
1058 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1060 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1062 * w32fns.c (w32_default_color_map): New function,
1063 extracted from Fw32_default_color_map.
1064 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1066 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1068 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1070 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1072 * keyboard.c (test_undefined): New function (bug#9751).
1073 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1075 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1077 * sysdep.c (init_sys_modes): Fix the check for the controlling
1078 terminal (Bug#6649).
1080 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1082 * dispextern.h (struct bidi_it): New member next_en_type.
1084 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1085 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1086 current character, check also for next_en_type being WEAK_EN.
1087 (bidi_resolve_weak): Don't enter the expensive loop if the current
1088 position is before next_en_pos. Record the bidi type of the first
1089 non-ET, non-BN character we find, in addition to its position.
1090 (bidi_level_of_next_char): Invalidate next_en_type when
1091 next_en_pos is over-stepped.
1093 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1095 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1096 * editfns.c: Rewrite current-time-zone so that it invokes
1097 the equivalent of (format-time-string "%Z") to get the time zone name.
1098 This fixes a bug when the time zone name contains characters that
1099 need converting from the system time locale to Emacs internal format.
1100 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1101 that patch fixed format-time-string to do the conversion, but
1102 I forgot to fix current-time-zone.
1103 (format_time_string): New function, containing most of
1104 what Fformat_time_string used to contain.
1105 (Fformat_time_string): Rewrite in terms of format_time_string.
1106 This doesn't change this function's behavior.
1107 (current-time-zone): Rewrite to use format_time_string.
1108 This fixes the bug reported by Michael Schierl in
1109 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1110 Jason Rumney's 2007-06-07 change worked around this bug, but
1112 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1114 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1116 * xdisp.c (start_display): If the character at POS is displayed
1117 via a display vector, reset IT->current.dpvec_index to zero.
1118 (try_window_reusing_current_matrix): If a line ends in a display
1119 vector or the next line starts in a display vector, continue
1120 redrawing the window even though the character position of
1121 start_row was reached.
1124 2011-10-18 Chong Yidong <cyd@gnu.org>
1126 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1127 with nobreak-char-display too.
1129 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1131 Fix part 3 of bug#9771.
1132 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1133 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1134 non-neutral characters if the current character is a paragraph
1135 separator (a.k.a. Newline). This avoids running the same
1136 expensive loop twice, once when we consume the preceding newline
1137 and the other time when the line actually needs to be displayed.
1138 Avoid the loop when we see neutrals on the base embedding level
1139 following a character whose directionality is the same as the
1140 paragraph's. This avoids running the expensive loop when a line
1141 ends in a long sequence of neutrals, like control characters.
1142 Add assertion against STRONG_AL type. Slightly rearrange code
1143 that determines the type of a neutral given the first non-neutral
1145 (bidi_level_of_next_char): Set next_en_pos to zero when
1146 invalidating its info.
1148 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1150 * xdisp.c (push_display_prop): Determine whether to record string
1151 or buffer position by IT->string, not by IT->method. Allow
1152 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1153 (move_it_vertically_backward): Don't look for character position
1154 immediately after the newline when in a continuation line.
1157 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1159 * window.c (coordinates_in_window): Rewrite and delabelize
1160 vertical border check. (Bug#5357) (Bug#9618)
1162 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1164 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1165 errors in XSetWindowBorder (bug#9310).
1167 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1169 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1170 avoid crash when xmalloc overrun checking is enabled.
1172 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1174 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1175 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1176 cursor motion with <left> and <right> arrow keys.
1178 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1179 some callers set that themselves.
1181 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1183 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1184 display string and the previous row comes from the same string and
1185 is empty. (Bug#9739) (Bug#9738)
1187 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1189 * doc.c (get_doc_string): Encode file name (bug#9735).
1191 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1193 * bidi.c (bidi_level_of_next_char):
1194 * xdisp.c (get_visually_first_element): Remove old incorrect
1195 comments regarding the Unicode Line Separator character.
1197 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1199 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1201 * alloc.c (Fgc_status): Do not access beyond zombies array
1202 boundary if nzombies > MAX_ZOMBIES.
1203 * alloc.c (dump_zombies): Add missing format specifier.
1205 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1207 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1208 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1210 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1211 Some packages use them to denote characters with modifiers.
1213 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1215 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1216 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1217 matching a pp-number. Rename parameter var to var1.
1219 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1221 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1223 2011-10-08 Glenn Morris <rgm@gnu.org>
1225 * callint.c (Fcall_interactively): Give a more explicit error for the
1226 'c' case with a non-character input. (Bug#8479)
1228 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1230 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1232 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1233 lines that are hscrolled on the left.
1235 * dispnew.c (buffer_posn_from_coords): Account for a possible
1236 presence of header-line. (Bug#4426)
1238 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1240 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1241 Don't advertise functionality which we discourage or doesn't work.
1243 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1245 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1246 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1247 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1248 this makes Emacs dump core during garbage collection on rare
1249 occasions. sizeof is obviously inferior to offsetof here, so
1250 stick with offsetof.
1251 (GC_POINTER_ALIGNMENT): New macro.
1252 (mark_memory): Omit 3rd (offset) arg; caller changed.
1253 Don't assume EMACS_INT alignment is the same as pointer alignment.
1255 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1257 * keyboard.c (read_key_sequence_remapped): New var.
1258 (read_key_sequence): Compute remapping in the right buffer.
1259 (command_loop_1): Use read_key_sequence's remapping directly.
1261 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1263 * dired.c (file_name_completion): Don't expand file name.
1264 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1265 before checking file name handler.
1267 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1268 they've been requested explicitly (bug#9591).
1270 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1272 * keymap.c (Fsingle_key_description): Use make_specified_string
1273 instead of build_string to build string from push_key_description.
1276 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1278 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1279 This fixes a Y2038 bug on 64-bit hosts.
1280 * buffer.c (reset_buffer):
1281 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1282 (Fclear_buffer_auto_save_failure):
1283 Use 0, not -1, to represent an unset failure time, since time_t
1284 might not be signed.
1286 Remove dependency on glibc malloc internals.
1287 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1288 Move back here from lisp.h, but with their new implementations.
1289 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1290 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1291 * charset.c (charset_table_init): New static var.
1292 (syms_of_charset): Use it instead of xmalloc. This removes a
1293 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1294 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1295 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1296 Move back to alloc.c.
1297 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1298 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1300 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1302 * nsterm.m (windowDidResize): Call x_set_window_size only when
1303 ns_in_resize is true. Otherwise set pixelwidth/height and
1304 call change_frame_size (Bug#9628).
1306 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1308 Port --enable-checking=all to Fedora 14 x86-64.
1309 * charset.c (syms_of_charset): Also account for glibc malloc's
1310 internal overhead when calculating the initial malloc maximum.
1312 Port --enable-checking=all to Fedora 14 x86.
1313 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1315 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1316 (overrun_check_realloc, overrun_check_free):
1317 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1318 That way, xmalloc returns a properly-aligned pointer even if
1319 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1320 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1321 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1322 into account when calculating the initial malloc maximum.
1323 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1324 Move here from alloc.c, so that charset.c can use it too.
1325 Properly align; the old code wasn't right for common 32-bit hosts
1326 when configured with --enable-checking=all.
1327 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1328 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1330 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1332 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1335 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1337 * xdisp.c (compute_display_string_end): If there's no display
1338 string at CHARPOS, return -1.
1340 * bidi.c (bidi_fetch_char): When compute_display_string_end
1341 returns a negative value, treat the character as a normal
1342 character not covered by a display string. (Bug#9624)
1344 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1346 * lread.c (Fread_from_string): Fix typo in docstring.
1348 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1350 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1351 newline, reseat the iterator instead of bidi-iterating there one
1352 character at a time. (Bug#9610)
1353 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1354 TO_CHARPOS if the bidi iterator is at base embedding level.
1356 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1358 * lread.c (readevalloop): Use correct code for NBSP.
1359 (read1): Likewise. (Bug#9608)
1361 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1363 * dbusbind.c (Fdbus_register_signal): When service is not
1364 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1366 2011-09-25 Glenn Morris <rgm@gnu.org>
1368 * buffer.c (truncate-lines): Doc fix.
1370 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1372 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1373 (Fset_window_next_buffers): Doc fix.
1375 2011-09-24 Glenn Morris <rgm@gnu.org>
1377 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1379 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1381 Fix minor problems found by static checking.
1382 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1383 * indent.c (Fvertical_motion): Fix == vs = typo.
1385 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1387 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1388 Default value is now t. Doc fix.
1390 * indent.c (Fvertical_motion): Compute and apply the overshoot
1391 logic when moving up, not only when moving down. Fix the
1392 confusing name and values of the it_overshoot_expected variable;
1393 logic changes accordingly. (Bug#9254) (Bug#9549)
1395 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1396 CHARPOS is covered by a display string which includes newlines.
1397 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1398 is covered by a display string with embedded newlines.
1400 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1402 * dbusbind.c (Fdbus_register_signal): Add match rule to
1403 Vdbus_registered_objects_table. (Bug#9581)
1404 (Fdbus_register_method, Vdbus_registered_objects_table):
1407 2011-09-24 Jim Meyering <meyering@redhat.com>
1409 do not ignore write error for any output size
1410 The previous change was incomplete.
1411 While it makes emacs --batch detect the vast majority of stdout
1412 write failures, errors were still ignored whenever the output size is
1413 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1414 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1415 && echo FAIL: ignored write error
1416 FAIL: ignored write error
1417 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1418 && echo FAIL: ignored write error
1419 FAIL: ignored write error
1420 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1422 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1424 * emacs.c (Fkill_emacs): In noninteractive mode exit
1425 non-successfully if a write error occurred on stdout. (Bug#9574)
1427 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1429 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1432 * dispextern.h (struct it): Update the comment documenting what
1435 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1437 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1438 a display string, extend search for cursor position to end of row.
1439 (find_row_edges): If the row ends in a newline from a display
1440 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1441 Handle the case of a display string with multiple newlines.
1442 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1443 non-empty line. Fixes confusing cursor motion with arrow keys at
1444 the beginning of a line that starts with whitespace.
1446 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1448 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1451 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1453 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1456 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1458 * xdisp.c (display_line): Record maximum and minimum buffer
1459 positions even if no glyphs were produced (e.g., by a zero-width
1460 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1461 buffer positions that will be removed from the glyph row because
1463 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1464 column is beyond frame width: don't subtract 1 "pixel" when
1465 computing width of the stretch.
1466 (reseat_at_next_visible_line_start): Undo the change made on
1467 2011-09-17 that saved paragraph information and restored it after
1468 the call to `reseat'. (Bug#9545)
1470 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1472 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1473 and turn window cursor on if cleared (Bug#9415).
1475 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1477 * search.c (boyer_moore): Take unibyte characters from pattern
1478 literally. (Bug#9458)
1480 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1482 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1484 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1486 Fix minor problem found by static checking.
1487 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1488 initialized, to pacify gcc -Wuninitialized.
1490 * fileio.c: Report proper errno when syscall falls.
1491 (Finsert_file_contents): Save and restore errno,
1492 so that report_file_error outputs the correct diagnostic.
1493 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1495 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1497 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1499 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1501 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1502 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1504 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1506 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1507 about the current paragraph and restore it after the call to reseat.
1509 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1510 (bidi_find_paragraph_start): Search back for paragraph beginning
1511 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1512 (bidi_move_to_visually_next): Only trigger paragraph-related
1513 computations when the last character is a newline or at EOB, not
1514 just any NEUTRAL_B. (Bug#9470)
1516 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1517 truncated lines if point is covered by a display string. (Bug#9524)
1519 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1521 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1522 (cons_to_x_long): New function.
1523 (lisp_data_to_selection_data): Use it. Correct the test for
1524 short-versus-long data; it was negated. Break out of vector
1525 loop, for efficiency, when a long datum is discovered.
1527 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1529 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1531 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1533 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1534 GCC PR/17406) by declaring this function with external scope.
1536 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1538 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1539 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1541 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1543 * editfns.c (Fformat): Correctly handle text properties on "%%".
1545 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1547 * xterm.c (x_draw_composite_glyph_string_foreground):
1548 * w32term.c (x_draw_composite_glyph_string_foreground):
1549 * term.c (encode_terminal_code):
1550 * composite.c (composition_update_it, get_composition_id):
1551 * xdisp.c (get_next_display_element)
1552 (fill_composite_glyph_string): Add comments about special meaning
1553 of TAB characters in a composition.
1555 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1557 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1558 This occurs when processing a multibyte format.
1559 Problem reported by Wolfgang Jenker.
1561 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1563 * xdisp.c (try_cursor_movement): Only check for exact match if
1564 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1566 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1568 Remove unused external symbols.
1569 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1570 * xdisp.c (calc_pixel_width_or_height): Now static.
1571 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1572 * indent.c (check_display_width):
1573 * w32term.c: Fix comment to match code.
1574 * xterm.c, xterm.h (x_catching_errors): Remove.
1576 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1578 * xselect.c: Use signed conversions more consistently (Bug#9498).
1579 (selection_data_to_lisp_data): Assume incoming selection data are
1580 signed integers, not unsigned. This is to be consistent with
1581 outgoing selection data, which was modified to use signed integers
1582 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1583 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1584 expects long, not unsigned long.
1586 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1588 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1589 computation of loop end. Reported by Johan Bockgård
1592 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1594 * frame.c (Fother_visible_frames_p): Function deleted.
1596 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1598 * indent.c (compute_motion): Process display vector front to back
1599 rather than the other way around. (Bug#2496)
1601 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1603 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1605 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1607 * minibuf.c (Fread_from_minibuffer): Doc fix.
1609 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1611 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1612 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1614 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1616 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1617 value for non-existent files.
1619 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1621 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1622 set its "size" to -1. This will set the modtime_size field of
1623 the corresponding buffer to -1, which is what
1624 verify-visited-file-modtime expects for files that do not exist.
1627 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1629 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1631 * lisp.h: ... from here. push_key_description is no longer
1632 defined in keyboard.c, so its declaration should not be in
1633 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1634 logically belongs with push_key_description.
1636 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1638 * buffer.h: Include <sys/types.h> instead of <time.h>.
1639 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1640 Problem reported by Herbert J. Skuhra.
1642 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1644 * xml.c (parse_region): Make the parsing work for
1645 non-comment-starting XML files again (bug#9144).
1647 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1649 * image.c (gif_load): Fix calculation of bottom and right corner.
1652 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1654 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1655 redisplay in small windows.
1657 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1659 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1661 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1663 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1664 Operate on live windows only.
1666 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1668 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1670 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1672 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1673 only under bidi iteration.
1675 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1677 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1679 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1681 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1682 Without this fix, the command to link temacs failed due to an
1683 undefined symbol __builtin_isnan. This is because
1684 /usr/include/iso/math_c99.h #defines isnan(x) to
1685 __builtin_isnan(x), but the bundled gcc, which identifies itself
1686 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1688 * floatfns.c (isnan): #undef, and then #define to a clone of
1690 (Fisnan): Always define, since it's always available now.
1691 (syms_of_floatfns): Always define isnan at the Lisp level.
1693 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1695 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1697 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1699 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1700 The previous code assumed that file offsets (off_t values) fit in
1701 EMACS_INT variables, which is not true on typical 32-bit hosts.
1702 The code messed up by falsely reporting buffer overflow in cases
1703 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1704 when "big" contains more than 2**29 bytes, even though this
1705 inserts just one byte and does not overflow the buffer.
1706 (Finsert_file_contents): Store file offsets as off_t
1707 values, not as EMACS_INT values. Check for overflow when
1708 converting between EMACS_INT and off_t. When checking for
1709 buffer overflow or for overlap, take the offsets into account.
1710 Don't use EMACS_INT for small values where int suffices.
1711 When checking for overlap, fix a typo: ZV was used where
1712 ZV_BYTE was intended.
1713 (Fwrite_region): Don't assume off_t fits into 'long'.
1714 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1716 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1718 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1720 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1722 sprintf-related integer and memory overflow issues (Bug#9412).
1724 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1725 (esprintf, exprintf, evxprintf): New functions.
1726 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1727 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1728 (modify_event_symbol): Do not assume that the length of
1729 name_alist_or_stem is safe to alloca and fits in int.
1730 (Fexecute_extended_command): Likewise for function name and binding.
1731 (Frecursion_depth): Wrap around reliably on integer overflow.
1732 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1733 since some callers pass EMACS_INT values.
1734 (Fsingle_key_description): Don't crash if symbol name contains more
1735 than MAX_ALLOCA bytes.
1736 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1737 (get_minibuffer): Arg is now EMACS_INT, not int.
1738 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1739 (esprintf, exprintf, evxprintf): New decls.
1740 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1742 * dbusbind.c (signature_cat): New function.
1743 (xd_signature, Fdbus_register_signal):
1744 Do not overrun buffer; instead, report string overflow.
1746 * dispnew.c (add_window_display_history): Don't overrun buffer.
1747 Truncate instead; this is OK since it's just a log.
1749 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1750 even if the time zone offset is outlandishly large.
1751 Don't mishandle offset == INT_MIN.
1753 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1754 when creating daemon; the previous buffer-overflow check was incorrect.
1756 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1757 which has the guts of the old verror function.
1759 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1760 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1762 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1763 (font_unparse_xlfd): Don't blindly alloca long strings.
1764 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1765 fits in int, when using sprintf. Use single snprintf to count
1766 length of string rather than counting it via multiple sprintfs;
1767 that's simpler and more reliable.
1768 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1769 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1770 sprintf, in case result does not fit in int.
1772 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1773 (fontset_from_font): Print it.
1775 * frame.c (tty_frame_count): Now printmax_t, not int.
1776 (make_terminal_frame, set_term_frame_name): Print it.
1777 (x_report_frame_params): In X, window IDs are unsigned long,
1778 not signed long, so print them as unsigned.
1779 (validate_x_resource_name): Check for implausibly long names,
1780 and don't assume name length fits in 'int'.
1781 (x_get_resource_string): Don't blindly alloca invocation name;
1782 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1785 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1786 (xg_check_special_colors, xg_set_geometry):
1787 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1789 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1790 Use esprintf, not sprintf, in case result does not fit in int.
1792 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1793 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1794 it as a large positive number.
1795 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1796 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1798 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1799 in case result does not fit in int.
1801 * print.c (float_to_string): Detect width overflow more reliably.
1802 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1803 buffer overrun. Don't assume list length fits in 'int'. Treat
1804 print length of 0 as 0, not as infinity; to be consistent with other
1805 uses of print length in this function. Don't overflow print length
1806 index. Don't assume hash table size fits in 'long', or that
1807 vectorlike size fits in 'unsigned long'.
1809 * process.c (make_process): Use printmax_t, not int, to format
1810 process-name gensyms.
1812 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1814 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1815 to avoid potential buffer overrun.
1817 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1818 if X resource line is longer than 512 bytes.
1820 * xfns.c (x_window): Make sprintf buffer a bit bigger
1821 to avoid potential buffer overrun.
1823 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1825 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1827 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1829 Integer overflow fixes for scrolling, etc.
1830 Without these, Emacs silently mishandles large integers sometimes.
1831 For example, "C-u 4294967297 M-x recenter" was treated as if
1832 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1834 * xdisp.c (try_window_id): Check Emacs fixnum range before
1835 converting to 'int'.
1837 * window.c (window_scroll_line_based, Frecenter):
1838 Check that an Emacs fixnum is in range before assigning it to 'int'.
1839 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1840 values converted from Emacs fixnums.
1841 (Frecenter): Don't wrap around a line count if it is out of 'int'
1842 range; instead, treat it as an extreme value.
1843 (Fset_window_configuration, compare_window_configurations):
1844 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1846 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1847 that can exceed INT_MAX. Check that EMACS_INT value is in range
1848 before assigning it to the (possibly-narrower) index.
1849 (match_limit): Don't assume that a fixnum can fit in 'int'.
1851 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1854 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1855 (Fvertical_motion): Don't wrap around LINES values that don't fit
1856 in 'int'. Instead, treat them as extreme values. This is good
1857 enough for windows, which can't have more than INT_MAX lines anyway.
1859 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1861 * Require libxml/parser.h to avoid compilation warning.
1863 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1865 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1866 since this reportedly can destroy thread storage.
1868 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1870 * syntax.c (find_defun_start): Update all cache variables if
1871 exiting early (Bug#9401).
1873 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1875 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1877 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1878 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1879 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1881 * term.c (tty_append_glyph): New function.
1882 (produce_stretch_glyph): Static function and its prototype deleted.
1884 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1887 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1889 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1890 when checking :margin (Bug#9390).
1891 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1892 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1893 so that the name doesn't mislead. All uses changed.
1895 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1897 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1900 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1902 * xdisp.c (move_it_to): Don't bail out early when reaching
1903 position beyond to_charpos, if we are scanning backwards.
1904 (move_it_vertically_backward): When DY == 0, make sure we get to
1905 the first character in the line after the newline.
1907 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1909 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1910 (ccl_driver): Do not generate an out-of-range pointer.
1911 (Fccl_execute_on_string): Remove unnecessary check for
1912 integer overflow, noted by Stefan Monnier in
1913 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1914 Remove a FIXME that didn't need fixing.
1915 Simplify the newly-introduced buffer reallocation code.
1917 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1919 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1921 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1923 Integer and memory overflow issues (Bug#9196).
1925 * doc.c (get_doc_string): Rework so that
1926 get_doc_string_buffer_size is the actual buffer size, rather than
1927 being 1 less than the actual buffer size; this makes xpalloc more
1930 * image.c (x_allocate_bitmap_record, cache_image):
1931 * xselect.c (Fx_register_dnd_atom):
1932 Simplify previous changes by using xpalloc.
1934 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1935 since either will do and ptrdiff_t is convenient with xpalloc.
1937 * charset.c (charset_table_size)
1938 (struct charset_sort_data.priority): Now ptrdiff_t.
1939 (charset_compare): Don't overflow if priorities differ greatly.
1940 (Fsort_charsets): Don't assume list length fits in int.
1941 Check for size-calculation overflow when allocating sort data.
1942 (syms_of_charset): Allocate an initial charset table that is
1943 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1945 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1947 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1948 The actual value is always <= INT_MAX, and leaving it unsigned made
1949 overflow checking harder.
1951 * dispextern.h (struct glyph_matrix.rows_allocated)
1952 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1953 with xpalloc. The values are still always <= INT_MAX.
1955 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1957 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1958 (SAFE_NALLOCA): New macro.
1960 * region-cache.c (struct boundary.pos, find_cache_boundary)
1961 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1962 (set_cache_region, invalidate_region_cache)
1963 (revalidate_region_cache, know_region_cache, region_cache_forward)
1964 (region_cache_backward, pp_cache):
1965 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1966 so that ptrdiff_t * can be passed to xpalloc.
1967 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1968 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1969 (pp_cache): Don't assume cache_len fits in int.
1970 * region-cache.h: Adjust extern decls to match.
1972 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1973 EMACS_INT, since either will do, for xpalloc.
1975 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1976 (xnmalloc, xnrealloc, xpalloc): New functions.
1978 * bidi.c (bidi_shelve_header_size): New constant.
1979 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1980 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1982 * bidi.c (bidi_cache_shrink):
1983 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1985 Don't update size of array until after memory allocation succeeds,
1986 because xmalloc/xrealloc may not return.
1987 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1988 now that we have proper integer overflow checking.
1989 (record_overlay_string, overlay_strings): Catch overflows when
1990 calculating size of overlay_str_buf.
1992 * callproc.c (Fcall_process): Check for size overflow when
1993 calculating size of args2.
1994 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1995 Normally we prefer signed values, but sticking with ptrdiff_t would
1996 require adding more-complicated checks.
1998 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1999 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2000 Redo buffer-overflow calculations to avoid integer overflow.
2001 Add a FIXME comment where memory seems to be over-allocated.
2003 * character.c (Fstring): Check for size-calculation overflow.
2005 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2006 unnecessary integer overflow. Check for size overflow.
2007 (encode_coding_object): Don't update size until xmalloc succeeds.
2009 * composite.c (get_composition_id): Check for overflow in glyph
2010 length calculations.
2012 Integer and memory overflow fixes for display code.
2013 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2014 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2015 (scrolling_window): Check for overflow in size calculations.
2016 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2017 Don't assume glyph table len fits in int.
2018 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2019 (row_table_size): Now ptrdiff_t, not int.
2020 (scrolling_window): Avoid overflow in size calculations.
2021 Don't update size until allocation succeeds.
2022 * fns.c (concat): Check for overflow in size calculations.
2023 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2024 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2025 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2027 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2028 (get_doc_string): Check for size calculation overflow.
2029 Don't update size until allocation succeeds.
2030 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2031 EMACS_INT, where ptrdiff_t will do.
2032 (Fsubstitute_command_keys): Check for string overflow.
2034 * editfns.c (set_time_zone_rule): Don't assume environment length
2036 (message_length): Now ptrdiff_t, not int.
2037 (Fmessage_box): Don't update size until allocation succeeds.
2038 Don't assume message length fits in int.
2039 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2041 * emacs.c (main): Do not reallocate argv, since there is a null at
2042 the end that can be overwritten, and this way there's no need to
2043 worry about size-calculation overflow.
2044 (sort_args): Check for size-calculation overflow.
2046 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2048 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2050 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2051 (x_set_scroll_bar_width, x_figure_window_size):
2052 Check for integer overflow.
2053 (x_set_alpha): Do not assume XINT fits in int.
2055 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2056 This is for the members text_lines, text_cols, total_lines, total_cols,
2057 where the system imposes an 'int' limit.
2059 * fringe.c (Fdefine_fringe_bitmap):
2060 Don't update size until alloc works.
2062 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2063 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2065 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2066 Check for size-calculation overflow.
2067 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2068 do, as we prefer signed integers.
2069 (id_to_widget.max_size, id_to_widget.used)
2070 (xg_store_widget_in_map, xg_remove_widget_from_map)
2071 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2072 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2073 Use and return ptrdiff_t, not int.
2074 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2075 * gtkutil.h: Change prototypes to match the above.
2077 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2078 are duplicate now that they've been promoted to lisp.h.
2079 (x_allocate_bitmap_record, x_alloc_image_color)
2080 (make_image_cache, cache_image, xpm_load):
2081 Don't update size until alloc is done.
2082 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2084 Check for size calculation overflow.
2085 (ct_colors_allocated_max): New constant.
2086 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2089 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2090 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2091 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2092 Use ptrdiff_t, not int, to count maps.
2093 (read_char_minibuf_menu_prompt): Check for overflow in size
2094 calculations. Don't update size until allocation succeeds.
2095 Redo calculations to avoid overflow.
2096 * keyboard.h: Change prototypes to match the above.
2098 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2100 (current_minor_maps): Check for size calculation overflow.
2101 * keymap.h: Change prototypes to match the above.
2103 * lread.c (read1, init_obarray): Don't update size until alloc done.
2105 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2106 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2108 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2109 Now ptrdiff_t, not int.
2110 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2111 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2113 * process.c (Fnetwork_interface_list): Check for overflow
2114 in size calculation.
2116 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2118 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2119 overflow. Don't bother calling xmalloc when xrealloc will do.
2121 * search.c (Freplace_match): Check for size calculation overflow.
2122 (Fset_match_data): Don't assume list lengths fit in 'int'.
2124 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2125 for command line length. Do not attempt to address one before the
2126 beginning of an array, as that's not portable.
2128 * term.c (max_frame_lines): Remove; unused.
2129 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2131 (encode_terminal_code, calculate_costs): Check for size
2132 calculation overflow.
2133 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2134 table lengths and related sizes. Don't update size until alloc
2135 done. Redo calculations to avoid overflow.
2136 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2138 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2139 subtracting pointers.
2140 (gobble_line): Check for overflow more carefully. Don't update size
2143 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2144 Don't update size until alloc done.
2145 Redo size calculations to avoid overflow.
2146 Check for size calculation overflow.
2147 (main) [DEBUG]: Fix typo in invoking tparam1.
2149 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2150 Use ptrdiff_t, not int, for sizes.
2151 (store_mode_line_noprop_char): Don't update size until alloc done.
2153 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2154 Use ptrdiff_t, not int, for sizes.
2155 (Finternal_make_lisp_face, cache_face):
2156 Check for size calculation overflow.
2157 (cache_face): Treat size calculation overflows as if they were
2158 memory exhaustion (the usual treatment), rather than aborting.
2160 * xfns.c (x_encode_text, x_set_name_internal)
2161 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2162 sizes, since they can exceed INT_MAX in size. Check for size
2163 calculation overflow.
2165 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2166 (xg_select): Check for size calculation overflow.
2167 Don't update size until alloc done.
2169 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2170 as sprintf is limited to int lengths.
2172 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2173 (X_LONG_MIN): New macros.
2174 Use them to make the following changes clearer.
2175 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2176 This change doesn't affect the value now, but it may help remind
2177 future maintainers not to raise the value too much later.
2178 (SELECTION_QUANTUM): Remove, replacing with ...
2179 (selection_quantum): ... new function, which avoids overflow.
2181 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2182 assumption that selection length fits in 'int'.
2183 (x_reply_selection_request, x_handle_selection_request)
2184 (x_get_window_property, receive_incremental_selection)
2185 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2186 (lisp_data_to_selection_data, clean_local_selection_data):
2187 Use ptrdiff_t, not int, to record length of selection.
2188 (x_reply_selection_request, x_get_window_property)
2189 (receive_incremental_selection, x_property_data_to_lisp):
2190 Redo calculations to avoid overflow.
2191 (x_reply_selection_request): When sending hint, ceiling it at
2192 X_LONG_MAX rather than relying on wraparound overflow to send
2194 (x_get_window_property, receive_incremental_selection)
2195 (lisp_data_to_selection_data, x_property_data_to_lisp):
2196 Check for size-calculation overflow.
2197 (x_get_window_property, receive_incremental_selection)
2198 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2199 Don't store size until memory allocation succeeds.
2200 (x_get_window_property): Plug memory leak on memory exhaustion.
2201 Don't double-block input; malloc is safe here. Don't assume 2**34
2202 - 4 fits in unsigned long. Add an xassert to check
2203 XGetWindowProperty overflow. Be more careful about overflow
2204 calculations, and distinguish size from memory overflow better.
2205 (receive_incremental_selection): When tracing, don't assume
2206 unsigned int is less than INT_MAX.
2207 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2208 harmful) conversions of unsigned short to int.
2209 (lisp_data_to_selection_data): Don't assume that integers
2210 in the range -65535 through -1 fit in an X unsigned short.
2211 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2212 result parameters unless successful. Rely on cons_to_unsigned
2213 to report problems with elements; the old code wasn't right anyway.
2214 (x_check_property_data): Check for int overflow; we cannot use
2215 a wider type due to X limits.
2216 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2218 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2220 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2221 (x_term_init): Check for size calculation overflow.
2222 (x_color_cells): Don't store size until memory allocation succeeds.
2223 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2224 Don't assume alloca size is less than MAX_ALLOCA.
2225 (x_term_init): Don't assume length fits in int (sprintf is limited
2228 Use ptrdiff_t for composition IDs.
2229 * character.c (lisp_string_width):
2230 * composite.c (composition_table_size, n_compositions)
2231 (get_composition_id, composition_gstring_from_id):
2232 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2233 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2234 * window.c (Frecenter):
2235 Use ptrdiff_t, not int, for composition IDs.
2236 * composite.c (get_composition_id): Check for integer overflow.
2237 * composite.h: Adjust prototypes to match the above changes.
2239 Use ptrdiff_t for hash table indexes.
2240 * category.c (hash_get_category_set):
2241 * ccl.c (ccl_driver):
2242 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2243 * coding.c (coding_system_charset_list, detect_coding_system):
2244 * coding.h (struct coding_system.id):
2245 * composite.c (get_composition_id, gstring_lookup_cache):
2246 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2247 * image.c (xpm_get_color_table_h):
2248 * lisp.h (hash_lookup, hash_put):
2249 * minibuf.c (Ftest_completion):
2250 Use ptrdiff_t for hash table indexes, not int (which is too
2251 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2252 32-bit --with-wide-int hosts).
2254 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2255 Add a FIXME comment about memory leaks.
2256 (syms_of_charset): Don't assume xmalloc returns.
2258 Don't assume that stated character widths fit in int.
2259 * character.c (Fchar_width, c_string_width, lisp_string_width):
2260 * character.h (CHAR_WIDTH):
2261 * indent.c (MULTIBYTE_BYTES_WIDTH):
2262 Use sanitize_char_width to avoid undefined and/or bad behavior
2263 with outlandish widths.
2264 * character.h (sanitize_tab_width): Rename from sanitize_width,
2265 now that we have two such functions. All uses changed.
2266 (sanitize_char_width): New inline function.
2268 Don't assume that tab-width fits in int.
2269 * character.h (sanitize_width): New inline function.
2270 (SANE_TAB_WIDTH): New macro.
2271 (ASCII_CHAR_WIDTH): Use it.
2272 * indent.c (sane_tab_width): Remove. All uses replaced by
2273 SANE_TAB_WIDTH (current_buffer).
2274 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2276 * fileio.c: Integer overflow issues with file modes.
2277 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2279 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2280 Remove unreachable code.
2281 (read_hex, load_charset_map_from_file): Check for integer overflow.
2283 * xterm.c: don't go over XClientMessageEvent limit
2284 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2285 (x_send_scroll_bar_event): Likewise. Check that the size does not
2286 exceed limits imposed by XClientMessageEvent, as well as the usual
2287 ptrdiff_t and size_t limits.
2289 * keyboard.c: Overflow, signedness and related fixes.
2290 (make_lispy_movement): Use same integer type in forward decl
2291 that is used in the definition.
2292 (read_key_sequence, keyremap_step):
2293 Change bufsize argument back to int, undoing my 2011-03-30 change.
2294 We prefer signed types, and int is wide enough here.
2295 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2296 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2297 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2298 length, not size_t. Use ptrdiff_t for index, not int.
2299 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2300 possibility of integer overflow.
2302 Overflow, signedness and related fixes for images.
2304 * dispextern.h (struct it.stack[0].u.image.image_id)
2305 (struct_it.image_id, struct image.id, struct image_cache.size)
2306 (struct image_cache.used, struct image_cache.ref_count):
2307 * gtkutil.c (update_frame_tool_bar):
2308 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2309 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2310 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2311 * nsmenu.m (update_frame_tool_bar):
2312 * xdisp.c (calc_pixel_width_or_height):
2313 * xfns.c (image_cache_refcount):
2314 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2315 on typical 64-bit hosts.
2317 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2318 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2319 Omit unnecessary casts to int.
2320 (parse_image_spec): Check that integers fall into 'int' range
2321 when the callers expect that.
2322 (image_ascent): Redo ascent calculation to avoid int overflow.
2323 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2324 (lookup_image): Remove unnecessary tests.
2325 (xbm_image_p): Locals are now of int, not EMACS_INT,
2326 since parse_image_check makes sure they fit into int.
2327 (png_load, gif_load, svg_load_image):
2328 Prefer int to unsigned where either will do.
2329 (tiff_handler): New function, combining the cores of the
2330 old tiff_error_handler and tiff_warning_handler.
2331 This function is rewritten to use vsnprintf and thereby avoid
2332 stack buffer overflows. It uses only the features of vsnprintf
2333 that are common to both POSIX and native Microsoft.
2334 (tiff_error_handler, tiff_warning_handler): Use it.
2335 (tiff_load, gif_load, imagemagick_load_image):
2336 Don't assume :index value fits in 'int'.
2337 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2338 (imagemagick_load_image): Check that crop parameters fit into
2339 the integer types that MagickCropImage accepts. Don't assume
2340 Vimagemagick_render_type has a nonnegative value. Don't assume
2341 size_t fits in 'long'.
2342 (gs_load): Use printmax_t to print the widest integers possible.
2343 Check for integer overflow when computing image height and width.
2345 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2347 * xdisp.c (redisplay_window): Don't force window start if point
2348 will be invisible in the resulting window. (Bug#9324)
2350 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2352 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2353 the display spec is of the form `(space ...)'.
2354 (handle_display_spec): Return the value returned by
2355 handle_single_display_spec, not just 1 or zero.
2356 (handle_single_display_spec): If the display spec is of the form
2357 `(space ...)', and specifies display in the text area, return 2
2359 (try_cursor_movement): Check for the need to scroll more
2360 accurately, and prefer exact match for point under bidi.
2361 Don't advance `row' beyond the last row of the window.
2363 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2364 into disp_prop; all users changed.
2366 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2367 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2368 for the text covered by the display property.
2370 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2372 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2373 Change return value to nil.
2374 (Frecord_buffer): Delete unused function.
2376 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2378 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2379 buffers, return left-to-right.
2380 (set_cursor_from_row): Consider candidate row a win if its glyph
2381 represents a newline and point is on that newline. Fixes cursor
2382 positioning on the newline at EOL of R2L text within L2R
2383 paragraph, and vice versa.
2384 (try_cursor_movement): Check continued rows, in addition to
2385 continuation rows. Fixes unwarranted scroll when point enters a
2386 continued line of R2L text within an L2R paragraph, or vice versa.
2387 (cursor_row_p): Consider the case of point being equal to
2388 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2389 from the end of a short line to the beginning of a continued line
2390 of R2L text within L2R paragraph.
2391 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2392 composed characters.
2394 * bidi.c (bidi_check_type): Use xassert.
2395 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2398 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2400 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2403 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2405 * nsfont.m (ns_otf_to_script): Fix typo.
2407 2011-08-22 Kenichi Handa <handa@m17n.org>
2409 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2410 extra slot even if the purpose is char-code-property-table.
2412 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2414 * xdisp.c (redisplay_window): When computing centering_position,
2415 account for the height of the header line. (Bug#8874)
2417 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2418 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2419 candidate is selected by the mouse, and that candidate has a
2420 composed character under the mouse.
2422 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2423 coordinates reported by pos-visible-in-window-p for a composed
2424 character in column zero.
2426 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2428 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2430 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2432 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2433 consider it a hit if to_charpos is anywhere in the range of the
2434 composed buffer positions.
2436 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2438 * image.c (gif_load): Don't assume that each subimage has the same
2439 dimensions as the base image. Handle disposal method that is
2440 "undefined" by the gif spec (Bug#9335).
2442 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2444 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2445 (Fcondition_case): Document `debug' symbol in error handler.
2447 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2449 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2450 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2451 from an Org mode buffer to a Speedbar frame.
2453 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2454 a composition, take its buffer position from IT->cmp_it.charpos.
2455 Fixes cursor positioning at the beginning of a line that begins
2456 with a composed character.
2458 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2460 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2461 character bidirectional type, use STRONG_L instead. Fixes crashes
2462 in a buffer produced by `describe-categories'.
2464 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2465 members before the level stack, so they would be saved and
2466 restored when copying iterator state. Fixes incorrect reordering
2467 around TABs covered by display properties.
2469 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2471 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2473 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2475 * eval.c (internal_condition_case, internal_condition_case_1)
2476 (internal_condition_case_2, internal_condition_case_n):
2477 Remove unnecessary aborts (Bug#9081).
2479 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2481 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2482 has no `load' handler, try opening the file locally. (Bug#9311)
2484 2011-08-16 Ken Brown <kbrown@cornell.edu>
2486 * gmalloc.c: Expand comment.
2488 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2490 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2491 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2493 2011-08-16 Ken Brown <kbrown@cornell.edu>
2495 Fix memory allocation problems in Cygwin build (Bug#9273).
2497 * unexcw.c ( __malloc_initialized): Declare external variable.
2498 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2500 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2502 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2504 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2506 [CYGWIN] (special_realloc): New function.
2507 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2508 requests to realloc storage in the static heap.
2510 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2512 * bidi.c (bidi_initialize): Remove unused local.
2514 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2517 * biditype.h: Remove file.
2518 * makefile.w32-in ($(BLD)/bidi.$(O)):
2519 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2521 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2523 * chartab.c: Improve commentary for the uniprop_table API.
2525 * bidi.c (bidi_paragraph_init): Support zero value of
2526 bidi_ignore_explicit_marks_for_paragraph_level.
2527 (bidi_initialize): Use uniprop_table instead of including
2528 biditype.h and bidimirror.h.
2530 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2531 coordinates of the iterator when restoring from ppos_it.
2534 2011-08-14 Kenichi Handa <handa@m17n.org>
2536 * process.c (create_process): Call setup_process_coding_systems
2537 after the pid of the process is set to -1 (Bug#8162).
2539 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2541 * xdisp.c (move_it_in_display_line_to): Don't invoke
2542 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2543 ppos_it. Fixes vertical cursor motion when line beginning is
2544 covered by an image. (Bug#9296)
2546 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2548 * nsterm.h (ns_run_ascript): Declare.
2549 (NSAPP_DATA2_RUNASSCRIPT): Define.
2551 * nsfns.m (as_script, as_result, as_status): New static variables.
2552 (ns_run_ascript): New function.
2553 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2554 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2555 the event loop. Get status from as_status (Bug#7276).
2557 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2558 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2559 the event loop (Bug#7276).
2561 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2563 * gnutls.c (QCgnutls_bootprop_priority)
2564 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2565 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2566 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2567 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2568 (QCgnutls_bootprop_verify_hostname_error)
2569 (QCgnutls_bootprop_callbacks_verify): Rename from
2570 Qgnutls_bootprop_..., all uses changed.
2572 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2575 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2577 * xfaces.c (Qframe_set_background_mode): Now static.
2578 * dispextern.h (Qframe_set_background_mode): Remove decl.
2580 * process.c (Fnetwork_interface_info): Declare local only if needed.
2582 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2584 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2585 (Fnetwork_interface_list): Allocate in increments of bytes instead
2586 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2587 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2589 (struct ifflag_def): notrailers is smart on OSX.
2590 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2591 Get hardware address with getifaddrs if available.
2593 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2595 * xdisp.c (iterate_out_of_display_property): xassert that
2596 IT->position is set to within IT->object's boundaries. Break from
2597 the loop as soon as EOB is reached; avoids infloops in redisplay
2598 when IT->position is set up wrongly due to some bug.
2599 Set IT->current to match the bidi iterator unconditionally.
2600 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2601 entry. Force push_it to save on the stack the current
2602 buffer/string position, to be restored by pop_it. Fix flags in
2603 the iterator structure wrt the object coming from a display
2604 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2605 properties. (Bug#9284)
2607 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2609 * fontset.c (fontset_get_font_group): Add proper type checks.
2612 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2614 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2615 and LC_VERSION_MIN_MACOSX.
2616 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2617 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2619 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2621 * xdisp.c (forward_to_next_line_start): Allow to use the
2622 no-display-properties-and-no-overlays under bidi display.
2623 Set disp_pos in the bidi iterator to avoid searches for display
2624 properties and overlays.
2626 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2628 * editfns.c (Fset_time_zone_rule): Document relationship with the
2631 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2632 the font entity extracted from the cache (Bug#8109).
2634 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2636 * composite.c (autocmp_chars): Don't reset point. That is done by
2637 restore_point_unwind (Bug#5984).
2639 2011-08-07 Juri Linkov <juri@jurta.org>
2641 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2642 to show the arg `TIME' instead of `TIMEVAL'.
2644 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2646 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2647 display property strides EOL and includes a newline, as in
2648 longlines-mode. (Bug#9254)
2649 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2650 word-wrap under bidirectional display. (Bug#9224)
2652 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2653 is non-zero, even if the data buffer is NULL. Fixes a crash in
2654 vertical-motion with longlines-mode. (Bug#9254)
2656 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2658 * bidi.c <bidi_cache_total_alloc>: Now static.
2659 (bidi_initialize): Initialize bidi_cache_total_alloc.
2661 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2664 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2665 amount allocated this far in `bidi_cache_total_alloc'.
2666 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2667 non-zero, only free the data buffer without restoring the cache
2668 contents. All callers changed.
2670 * dispextern.h (bidi_unshelve_cache): Update prototype.
2672 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2673 (move_it_in_display_line, move_it_to)
2674 (move_it_vertically_backward, move_it_by_lines): Replace the call
2675 to xfree to an equivalent call to bidi_unshelve_cache.
2676 (move_it_in_display_line_to): Fix logic of returning
2677 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2679 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2681 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2682 came from a string character with a `cursor' property. (Bug#9229)
2684 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2686 * Makefile.in (LIB_PTHREAD): New variable.
2687 (LIBES): Add LIB_PTHREAD (Bug#9216).
2689 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2690 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2692 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2694 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2696 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2698 * xterm.c (x_find_topmost_parent): New function.
2699 (x_set_frame_alpha): Find topmost parent window with
2700 x_find_topmost_parent and set the property there also (bug#9181).
2701 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2703 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2705 * callproc.c (Fcall_process): Avoid vfork clobbering
2706 the local vars buffer, coding_systems, current_dir.
2708 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2710 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2712 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2714 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2715 so that it is not optimized away.
2717 * xdisp.c (compute_display_string_pos): Remove unused local.
2719 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2721 Fix slow cursor motion and scrolling in large buffers with
2722 selective display, like Org Mode buffers. (Bug#9218)
2724 * dispextern.h (struct bidi_it): New member disp_prop_p.
2726 * xdisp.c: Remove one-slot cache of display string positions.
2727 (compute_display_string_pos): Accept an additional argument
2728 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2729 for a display string or property. If found, set DISP_PROP_P
2732 * bidi.c (bidi_fetch_char): Accept an additional argument
2733 DISP_PROP_P, and pass it to compute_display_string_pos.
2734 Only handle text covered by a display string if DISP_PROP_P is returned
2735 non-zero. All callers of bidi_fetch_char changed.
2737 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2739 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2741 2010-12-03 Don March <don@ohspite.net>
2743 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2744 last character M-[char] is translated to ESC [char] (bug#7541).
2746 2011-08-02 Kenichi Handa <handa@m17n.org>
2748 * lisp.h (uniprop_table): Extern it.
2750 * chartab.c (uniprop_table): Make it non-static.
2752 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2754 * xdisp.c (forward_to_next_line_start): Accept additional argument
2755 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2757 (reseat_at_next_visible_line_start): Use the bidi iterator state
2758 returned by forward_to_next_line_start to restore the state of
2759 it->bidi_it after backing up to previous newline. (Bug#9212)
2761 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2763 * regex.c (re_comp): Protoize.
2764 (re_exec): Fix return type.
2765 (regexec): Fix type of `ret'. (Bug#9203)
2767 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2769 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2770 This is needed if max-image-size is a floating-point number.
2772 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2774 * print.c (print_object): Print empty symbol as ##.
2776 * lread.c (read1): Read ## as empty symbol.
2778 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2780 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2781 setting frame foreground color (Bug#9175).
2782 (x_set_background_color): Likewise.
2784 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2785 contents (Bug#9176).
2786 (EmacsTooltip -init): Remove bezels and add shadows to
2789 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2790 or scroll bar (Bug#8470).
2792 * nsfont.m (nsfont_open): Remove assignment to voffset and
2793 unnecessary vars hshink, expand, hd, full_height, min_height.
2794 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2796 * nsterm.h (nsfont_info): Remove voffset field.
2798 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2800 Implement strike-through and overline on NextStep (Bug#8863).
2802 * nsfont.m (nsfont_open): Use underline position provided by font,
2803 instead of hard-coded value of 2.
2804 (nsfont_draw): Call ns_draw_text_decoration instead.
2806 * nsterm.h: Add declaration for ns_draw_text_decoration.
2808 * nsterm.m (ns_draw_text_decoration): New function for drawing
2809 underline, overline, and strike-through.
2810 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2811 ns_draw_text_decoration. Change treatment of cursor drawing to
2812 accommodate underlining, etc.
2814 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2816 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2819 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2821 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2822 Without this fix, if a signal arrives just after memory fills up,
2823 'malloc' might be invoked reentrantly.
2825 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2826 In other words, assume that every image size is allowed, on non-X
2827 hosts. This assumption is probably wrong, but it lets Emacs compile.
2829 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2831 * regex.c (re_iswctype): Convert return values to boolean.
2833 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2835 * xdisp.c (compute_display_string_pos): Don't use cached display
2836 string position if the buffer had its restriction changed.
2839 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2841 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2843 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2845 Integer signedness and overflow and related fixes. (Bug#9079)
2847 * bidi.c: Integer size and overflow fixes.
2848 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2849 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2850 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2851 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2852 (bidi_find_other_level_edge):
2853 Use ptrdiff_t instead of EMACS_INT where either will do.
2854 This works better on 32-bit hosts configured --with-wide-int.
2855 (bidi_cache_ensure_space): Check for size-calculation overflow.
2856 Use % rather than repeated addition, for better worst-case speed.
2857 Don't set bidi_cache_size until after xrealloc returns, because it
2859 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2860 (bidi_cache_ensure_space): Also check that the bidi cache size
2861 does not exceed that of the largest Lisp string or buffer. See Eli
2862 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2864 * alloc.c (__malloc_size_t): Remove.
2865 All uses replaced by size_t. See Andreas Schwab's note
2866 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2868 * image.c: Improve checking for integer overflow.
2869 (check_image_size): Assume that f is nonnull, since
2870 it is always nonnull in practice. This is one less thing to
2871 worry about when checking for integer overflow later.
2872 (x_check_image_size): New function, which checks for integer
2873 overflow issues inside X.
2874 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2875 This removes the need for a memory_full check.
2876 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2877 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2878 (xbm_read_bitmap_data): Change locals back to 'int', since
2879 their values must fit in 'int'.
2880 (xpm_load_image, png_load, tiff_load):
2881 Invoke x_create_x_image_and_pixmap earlier,
2882 to avoid much needless work if the image is too large.
2883 (tiff_load): Treat overly large images as if
2884 x_create_x_image_and_pixmap failed, not as malloc failures.
2885 (gs_load): Use x_check_image_size.
2887 * gtkutil.c: Omit integer casts.
2888 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2889 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2891 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2893 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2894 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2895 would wrongly return t on a 64-bit host.
2897 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2898 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2899 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2900 and therefore cause GCC to emit a bogus diagnostic in some cases.
2902 * image.c: Integer signedness and overflow and related fixes.
2903 This is not an exhaustive set of fixes, but it's time to
2904 record what I've got.
2905 (lookup_pixel_color, check_image_size): Remove redundant decls.
2906 (check_image_size): Don't assume that arbitrary EMACS_INT values
2907 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2908 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2909 (tiff_load, imagemagick_load_image):
2910 Check for overflow in size calculations.
2911 (x_create_x_image_and_pixmap): Remove unnecessary test for
2912 xmalloc returning NULL; that can't happen.
2913 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2914 (xpm_color_bucket): Use better integer hashing function.
2915 (xpm_cache_color): Don't possibly over-allocate memory.
2916 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2917 (gif_memory_source):
2918 Use ptrdiff_t, not int or size_t, to record sizes.
2919 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2920 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2921 either works, as we prefer signed integers.
2922 (tiff_read_from_memory, tiff_write_from_memory):
2923 Return tsize_t, not size_t, since that's what the TIFF API wants.
2924 (tiff_read_from_memory): Don't fail simply because the read would
2925 go past EOF; instead, return a short read.
2926 (tiff_load): Omit no-longer-needed casts.
2927 (Fimagemagick_types): Don't assume size fits into 'int'.
2929 Improve hashing quality when configured --with-wide-int.
2930 * fns.c (hash_string): New function, taken from sxhash_string.
2931 Do not discard information about ASCII character case; this
2932 discarding is no longer needed.
2933 (sxhash-string): Use it. Change sig to match it. Caller changed.
2934 * lisp.h: Declare it.
2935 * lread.c (hash_string): Remove, since we now use fns.c's version.
2936 The fns.c version returns a wider integer if --with-wide-int is
2937 specified, so this should help the quality of the hashing a bit.
2939 * emacs.c: Integer overflow minor fix.
2940 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2941 Define only if GNU_LINUX.
2942 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2944 * dispnew.c: Integer signedness and overflow fixes.
2945 Remove unnecessary forward decls, that were a maintenance hassle.
2946 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2948 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2949 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2950 (prepare_desired_row, line_draw_cost):
2951 Use int, not unsigned, where either works.
2952 (save_current_matrix, restore_current_matrix):
2953 Use ptrdiff_t, not size_t, where either works.
2954 (init_display): Check for overflow more accurately, and without
2955 relying on undefined behavior.
2957 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2958 Remove, replacing with the new symbols in lisp.h. All uses changed.
2959 * fileio.c (make_temp_name):
2960 * filelock.c (lock_file_1, lock_file):
2961 * xdisp.c (message_dolog):
2962 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2963 Use pMd etc. instead.
2964 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2965 replacing the pWIDE etc. symbols removed from editfns.c.
2967 * keyboard.h (num_input_events): Now uintmax_t.
2968 This is (very slightly) less likely to mess up due to wraparound.
2971 * buffer.c: Integer signedness fixes.
2972 (alloc_buffer_text, enlarge_buffer_text):
2973 Use ptrdiff_t rather than size_t when either will do, as we prefer
2976 * alloc.c: Integer signedness and overflow fixes.
2977 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2978 (__malloc_size_t): Default to size_t, not to int.
2979 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2980 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2981 Prefer ptrdiff_t to size_t when either would do, as we prefer
2983 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2984 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2985 Now const. Initialize with values that are in range even if char
2987 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2988 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2989 These functions do the right thing with sizes > 2**32.
2990 (check_depth): Now ptrdiff_t, not int.
2991 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2992 Adjust to new way of storing sizes. Check for size overflow bugs
2994 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2995 slightly wrong anyway, as it missed one instance of
2996 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2997 (refill_memory_reserve): Omit needless cast to size_t.
2998 (mark_object_loop_halt): Mark as externally visible.
3000 * xselect.c: Integer signedness and overflow fixes.
3001 (Fx_register_dnd_atom, x_handle_dnd_message):
3002 Use ptrdiff_t, not size_t, since we prefer signed.
3003 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3004 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3005 x_dnd_atoms_size and x_dnd_atoms_length.
3007 * doprnt.c: Prefer signed to unsigned when either works.
3009 * doprnt.c (doprnt):
3011 * xdisp.c (vmessage):
3012 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3013 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3014 prefer signed arithmetic to avoid comparison confusion.
3015 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3016 but is a bit tricky.
3018 Assume freestanding C89 headers, string.h, stdlib.h.
3019 * data.c, doprnt.c, floatfns.c, print.c:
3020 Include float.h unconditionally.
3021 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3022 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3023 * regex.c: Likewise for stddef.h, string.h.
3024 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3025 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3026 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3027 (STDC_HEADERS): Remove obsolete defines.
3028 * sysdep.c: Include limits.h unconditionally.
3030 Assume support for memcmp, memcpy, memmove, memset.
3031 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3032 * regex.c (memcmp, memcpy):
3033 Remove; we assume C89 now.
3035 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3036 (__malloc_safe_bcopy): Remove; no longer needed.
3038 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3039 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3040 well either way, and we prefer signed to unsigned.
3042 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3044 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3045 closes the connection while we're reading (bug#9182).
3047 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3049 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3050 are specified (Bug#9168).
3052 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3054 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3055 Found by GCC static checking and --with-wide-int on a 32-bit host.
3057 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3059 * xdisp.c (compute_display_string_pos): Fix logic of caching
3060 previous display string position. Initialize cached_prev_pos to
3061 -1. Fixes slow-down at the beginning of a buffer.
3063 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3065 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3066 for attrs[LFACE_FONTSET_INDEX].
3068 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3070 * xml.c (parse_region): Remove unused local
3071 that was recently introduced.
3073 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3075 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3076 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3078 * xdisp.c (move_it_in_display_line_to): Record the best matching
3079 position for TO_CHARPOS while scanning the line, and restore it on
3080 exit if none of the characters scanned was an exact match.
3081 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3082 when exact match is impossible due to invisible text, and the
3083 lines are truncated.
3085 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3087 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3090 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3092 Fix a significant slow-down of cursor motion with C-n, C-p,
3093 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3094 auto-repeat under bidi redisplay in fontified buffers.
3095 * xdisp.c (compute_stop_pos_backwards): New function.
3096 (next_element_from_buffer): Call compute_stop_pos_backwards to
3097 find a suitable prev_stop when we find ourselves before
3099 (reseat): Don't look for prev_stop, as that could mean a very long
3101 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3102 <cached_disp_overlay_modiff>: Cache for last found display string
3104 (compute_display_string_pos): Return the cached position if asked
3105 about the same buffer in the same area of character positions, and
3106 the buffer wasn't changed since the time the display string
3107 position was cached.
3109 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3111 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3112 is an integer, which is important for empty lines. (Bug#9149)
3114 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3116 * frame.c (Fmodify_frame_parameters): In tty case, update the
3117 default face if necessary (Bug#4238).
3119 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3121 * editfns.c (Fstring_to_char): No need to explain what a character
3122 is in the docstring (Bug#6576).
3124 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3126 * xml.c (parse_region): Make sure we always return a tree.
3128 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3130 * xml.c (parse_region): If a document contains only comments,
3133 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3135 * xml.c (make_dom): Return comments, too.
3137 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3140 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3141 and the surrounding thread.
3142 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3143 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3144 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3146 * s/openbsd.h (BROKEN_SIGIO): Define.
3147 * unexelf.c (unexec) [__OpenBSD__]:
3148 Don't update the .mdebug section of the Alpha COFF symbol table.
3150 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3152 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3155 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3157 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3158 This fixes some race conditions on the permissions of any newly
3161 * alloc.c (valid_pointer_p): Use pipe, not open.
3162 This fixes some permissions issues when debugging.
3164 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3165 If fchown fails to set both uid and gid, try to set just gid,
3166 as that is sometimes allowed. Adjust the file's mode to eliminate
3167 setuid or setgid bits that are inappropriate if fchown fails.
3169 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3171 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3172 to compare Lisp_Objects.
3173 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3174 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3175 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3177 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3179 * lread.c (read_integer): Unread even EOF character.
3180 (read1): Likewise. Properly record start position of symbol.
3182 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3183 symbol character follows.
3185 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3187 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3188 This works around a problem with the previous change to Fcopy_file.
3189 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3190 and without this change, GCC might complain about discarding
3191 fchown's return value.
3193 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3195 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3197 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3199 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3201 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3203 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3204 it's used from the C level.
3206 * process.c: Use the same condition for POLL_FOR_INPUT in both
3207 keyboard.c and process.c (bug#1858).
3209 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3211 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3212 (Fgnutls_boot): Use it.
3214 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3216 * doc.c (Fsubstitute_command_keys): Revert last change.
3218 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3220 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3221 quotes the next character, and doesn't affect other longer
3222 sequences (bug#8935).
3224 * lread.c (syms_of_lread): Clarify that is isn't only
3225 `eval-buffer' and `eval-defun' that's affected by
3226 `lexical-binding' (bug#8460).
3228 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3230 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3231 bidi redisplay when a line includes both an image and is truncated.
3233 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3235 Fix minor problems found by static checking.
3236 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3237 (elsz): Now a signed constant, not a size_t var. We prefer signed
3238 types to unsigned, to avoid integer comparison confusion. Without
3239 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3240 "cannot optimize loop, the loop counter may overflow", a symptom
3242 * indent.c (Fvertical_motion): Mark locals as initialized.
3243 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3245 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3247 * search.c (Fre_search_backward): Mention `case-fold-search' in
3248 all the re_search_* functions (bug#8138).
3250 * keyboard.c (Fopen_dribble_file): Document when the file is
3253 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3255 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3258 Support bidi reordering of display and overlay strings.
3259 * xdisp.c (compute_display_string_pos)
3260 (compute_display_string_end): Accept additional argument STRING.
3261 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3262 (reseat_to_string): Initialize bidi_it->string.s and
3263 bidi_it->string.schars.
3264 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3265 NULL (avoids a crash in bidi_paragraph_init).
3266 Initialize itb.string.lstring.
3267 (init_iterator): Call bidi_init_it only of a valid
3268 buffer position was specified. Initialize paragraph_embedding to
3270 (reseat_to_string): Initialize the bidi iterator.
3271 (display_string): If we need to ignore text properties of
3272 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3273 original value of -1 will not work with bidi.)
3274 (compute_display_string_pos): First arg is now struct
3275 `text_pos *'; all callers changed. Support display properties on
3277 (compute_display_string_end): Support display properties on Lisp
3279 (init_iterator, reseat_1, reseat_to_string): Initialize the
3280 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3281 when iterating on a string not from display properties).
3282 (compute_display_string_pos, compute_display_string_end):
3283 Fix calculation of the object to scan. Fixes an error when using
3285 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3286 base_level_stop; instead, set base_level_stop to BEGV.
3287 Fixes crashes in vertical-motion.
3288 (next_element_from_buffer): Improve commentary for when
3289 the iterator is before prev_stop.
3290 (init_iterator): Initialize bidi_p from the default value of
3291 bidi-display-reordering, not from buffer-local value. Use the
3292 buffer-local value only if initializing for buffer iteration.
3293 (handle_invisible_prop): Support invisible properties on strings
3294 that are being bidi-reordered.
3295 (set_iterator_to_next): Support bidi reordering of C strings and
3297 (next_element_from_string): Support bidi reordering of Lisp
3299 (handle_stop_backwards): Support Lisp strings as well.
3300 (display_string): Support display of R2L glyph rows.
3301 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3302 (init_iterator): Don't initialize it->bidi_p for strings
3304 (reseat_to_string): Initialize it->bidi_p for strings here.
3305 (next_element_from_string, next_element_from_c_string)
3306 (next_element_from_buffer): Add xassert's for correspondence
3307 between IT's object being iterated and it->bidi_it.string
3309 (face_before_or_after_it_pos): Support bidi iteration.
3310 (next_element_from_c_string): Handle the case of the first string
3311 character that is not the first one in the visual order.
3312 (get_visually_first_element): New function, refactored from common
3313 parts of next_element_from_buffer, next_element_from_string, and
3314 next_element_from_c_string.
3315 (tool_bar_lines_needed, redisplay_tool_bar)
3316 (display_menu_bar): Force left-to-right direction. Add a FIXME
3317 comment for making that be controlled by a user option.
3318 (push_it, pop_it): Save and restore the state of the
3319 bidi iterator. Save and restore the bidi_p flag.
3320 (pop_it): Iterate out of display property for string iteration as
3322 (iterate_out_of_display_property): Support iteration over strings.
3323 (handle_single_display_spec): Set up it->bidi_it for iteration
3324 over a display string, and call bidi_init_it.
3325 (handle_single_display_spec, next_overlay_string)
3326 (get_overlay_strings_1, push_display_prop): Set up the bidi
3327 iterator for displaying display or overlay strings.
3328 (forward_to_next_line_start): Don't use the shortcut if
3330 (back_to_previous_visible_line_start): If handle_display_prop
3331 pushed the iterator stack, restore the internal state of the bidi
3332 iterator by calling bidi_pop_it same number of times.
3333 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3334 and we are bidi-iterating, don't decrement the iterator position;
3335 instead, set the first_elt flag in the bidi iterator, to produce
3337 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3338 (push_display_prop): xassert that we are iterating a buffer.
3339 (push_it, pop_it): Save and restore paragraph_embedding member.
3340 (handle_single_display_spec, next_overlay_string)
3341 (get_overlay_strings_1, reseat_1, reseat_to_string)
3342 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3343 correctly. Don't assume unibyte strings are not bidi-reordered.
3344 (compute_display_string_pos)
3345 (compute_display_string_end): Fix handling the case of C string.
3346 (push_it, pop_it): Save and restore from_disp_prop_p.
3347 (handle_single_display_spec, push_display_prop): Set the
3348 from_disp_prop_p flag.
3349 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3350 (pop_it): Call iterate_out_of_display_property only if we are
3351 popping after iteration over a string that came from a display
3352 property. Fix a typo in popping stretch info. Add an assertion
3353 for verifying that the iterator position is in sync with the bidi
3355 (handle_single_display_spec, get_overlay_strings_1)
3356 (push_display_prop): Fix initialization of paragraph direction for
3357 string when that of the parent object is not yet determined.
3358 (reseat_1): Call bidi_init_it to resync the bidi
3359 iterator with IT's position. (Bug#7616)
3360 (find_row_edges): If ROW->start.pos gives position
3361 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3362 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3363 Reset the from_disp_prop_p flag.
3364 (SAVE_IT, RESTORE_IT): New macros.
3365 (pos_visible_p, face_before_or_after_it_pos)
3366 (back_to_previous_visible_line_start)
3367 (move_it_in_display_line_to, move_it_in_display_line)
3368 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3369 (try_scrolling, redisplay_window, display_line): Use them when
3370 saving a temporary copy of the iterator and restoring it back.
3371 (back_to_previous_visible_line_start, reseat_1)
3372 (init_iterator): Empty the bidi cache "stack".
3373 (move_it_in_display_line_to): If iterator ended up at
3374 EOL, but we never saw any buffer positions smaller than
3375 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3376 motion in bidi-reordered lines.
3377 (move_it_in_display_line_to): Record prev_method and prev_pos
3378 immediately before the call to set_iterator_to_next. Fixes cursor
3379 motion in bidi-reordered lines with stretch glyphs and strings
3380 displayed in margins. (Bug#8133) (Bug#8867)
3381 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3383 (pos_visible_p): Support positions in bidi-reordered lines.
3384 Save and restore bidi cache.
3386 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3387 (bidi_paragraph_info): Delete unused struct.
3388 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3389 (bidi_cache_start): New variable.
3390 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3392 (bidi_cache_fetch_state, bidi_cache_search)
3393 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3394 (bidi_cache_find, bidi_peek_at_next_level)
3395 (bidi_level_of_next_char, bidi_find_other_level_edge)
3396 (bidi_move_to_visually_next): Compare cache index with
3397 bidi_cache_start rather than with zero.
3398 (bidi_fetch_char): Accept new argument STRING; all callers
3399 changed. Support iteration over a string. Support strings with
3400 display properties. Support unibyte strings. Fix the type of
3401 `len' according to what STRING_CHAR_AND_LENGTH expects.
3402 (bidi_paragraph_init, bidi_resolve_explicit_1)
3403 (bidi_resolve_explicit, bidi_resolve_weak)
3404 (bidi_level_of_next_char, bidi_move_to_visually_next):
3405 Support iteration over a string.
3406 (bidi_set_sor_type, bidi_resolve_explicit_1)
3407 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3408 can now be zero (for strings); special values 0 and -1 were
3409 changed to -1 and -2, respectively.
3410 (bidi_char_at_pos): New function.
3411 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3412 Call it instead of FETCH_MULTIBYTE_CHAR.
3413 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3414 initialized to valid values.
3415 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3417 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3418 the test for valid cached positions. Fix the logic for looking up
3419 the sentinel state in the cache. GCPRO the Lisp string we are
3421 (bidi_push_it, bidi_pop_it): New functions.
3422 (bidi_initialize): Initialize the bidi cache start stack pointer.
3423 (bidi_cache_ensure_space): New function, refactored from part of
3424 bidi_cache_iterator_state. Don't assume the required size is just
3425 one BIDI_CACHE_CHUNK away.
3426 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3427 (bidi_count_bytes, bidi_char_at_pos): New functions.
3428 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3429 always valid if bidi_cache_idx is valid.
3430 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3431 is valid if it's going to be used.
3432 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3433 (bidi_cache_fetch_state, bidi_cache_search)
3434 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3435 (bidi_cache_iterator_state, bidi_cache_find)
3436 (bidi_find_other_level_edge, bidi_cache_start_stack):
3437 All variables related to cache indices are now EMACS_INT.
3439 * dispextern.h (struct bidi_string_data): New structure.
3440 (struct bidi_it): New member `string'. Make flag members be 1-bit
3441 fields, and put them last in the struct.
3442 (compute_display_string_pos, compute_display_string_end):
3444 (bidi_push_it, bidi_pop_it): Add prototypes.
3445 (struct iterator_stack_entry): New members bidi_p,
3446 paragraph_embedding, and from_disp_prop_p.
3447 (struct it): Member bidi_p is now a bit field 1 bit wide.
3448 (bidi_shelve_cache, bidi_unshelve_cache):
3451 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3452 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3453 and vector-like objects.
3455 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3456 cache around display iteration.
3458 * window.c (Fwindow_end, window_scroll_pixel_based)
3459 (displayed_window_lines, Frecenter): Save and restore the bidi
3460 cache around display iteration.
3462 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3464 * editfns.c (Fdelete_region): Clarify the use of the named
3465 parameters (bug#6788).
3467 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3469 * indent.c (Fvertical_motion): Set and restore w->pointm when
3470 saving and restoring the window's buffer (Bug#9006).
3472 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3474 * editfns.c (Fstring_to_char): Clarify just what is returned
3475 (bug#6576). Text by Eli Zaretskii.
3477 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3479 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3481 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3483 * buffer.c (mmap_find): Fix a typo.
3485 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3487 Fix execution of x selection hooks.
3488 * xselect.c (Qx_lost_selection_functions)
3489 (Qx_sent_selection_functions): New vars.
3490 (syms_of_xselect): DEFSYM them.
3491 (x_handle_selection_request): Pass Qx_sent_selection_functions
3492 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3493 (x_handle_selection_clear,x_clear_frame_selections):
3494 Pass Qx_lost_selection_functions rather than
3495 Vx_lost_selection_functions to Frun_hook_with_args.
3497 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3499 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3500 The old code sometimes used this field without initializing it.
3502 * alloc.c (gc_sweep): Don't read past end of array.
3503 In theory, the old code could also have corrupted Emacs internals,
3504 though it'd be very unlikely.
3506 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3508 * character.c (Fcharacterp): Don't advertise optional ignored
3509 argument. (Bug#4026)
3511 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3513 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3516 * window.c (Fset_window_start): Doc fix (bug#4199).
3517 (Fset_window_hscroll): Ditto.
3519 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3521 Fix minor new problems caught by GCC 4.6.1.
3522 * term.c (init_tty): Remove unused local.
3523 * xsettings.c (store_monospaced_changed): Define this function only
3524 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3527 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3529 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3531 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3533 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3534 are the mini-buffer and the echo area (bug#3320).
3536 * term.c (init_tty): Remove support for supdup, c10 and perq
3537 terminals, which are no longer supported (bug#1482).
3539 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3541 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3543 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3545 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3546 for non-popups (Bug#3642).
3548 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3550 * alloc.c (reset_malloc_hooks): Protoize.
3551 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3552 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3553 * cm.c (losecursor): Likewise.
3554 * data.c (fmod): Likewise.
3555 * dispnew.c (swap_glyphs_in_rows): Likewise.
3556 * emacs.c (memory_warning_signal): Likewise.
3557 * floatfns.c (float_error): Likewise.
3558 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3559 (otf_open, font_otf_capability, generate_otf_features)
3560 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3562 * image.c (pbm_read_file): Likewise.
3563 * indent.c (string_display_width): Likewise.
3564 * intervals.c (check_for_interval, search_for_interval)
3565 (inc_interval_count, count_intervals, root_interval)
3566 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3567 * lread.c (defalias): Likewise.
3568 * ralloc.c (r_alloc_check): Likewise.
3569 * regex.c (set_image_of_range_1, set_image_of_range)
3570 (regex_grow_registers): Likewise.
3571 * sysdep.c (strerror): Likewise.
3572 * termcap.c (valid_filename_p, tprint, main): Likewise.
3573 * tparam.c (main): Likewise.
3574 * unexhp9k800.c (run_time_remap, save_data_space)
3575 (update_file_ptrs, read_header, write_header, calculate_checksum)
3576 (copy_file, copy_rest, display_header): Likewise.
3577 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3579 * xdisp.c (check_it): Likewise.
3580 * xfaces.c (register_color, unregister_color, unregister_colors):
3582 * xfns.c (print_fontset_result): Likewise.
3583 * xrdb.c (member, fatal, main): Likewise.
3585 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3587 Fix minor problems found by static checking (Bug#9031).
3588 * chartab.c (char_table_set_range, map_sub_char_table):
3589 Remove unused locals.
3590 (uniprop_table): Now static.
3591 * composite.c (_work_char): Remove unused static var.
3593 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3595 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3597 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3599 * gtkutil.c (qttip_cb): Remove code without function.
3601 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3603 * w32.c (pthread_sigmask): New stub.
3605 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3607 Use pthread_sigmask, not sigprocmask (Bug#9010).
3608 sigprocmask is portable only for single-threaded applications, and
3609 Emacs can be multi-threaded when it uses GTK.
3610 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3612 * callproc.c (Fcall_process):
3613 * process.c (create_process):
3614 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3615 Use pthread_sigmask, not sigprocmask.
3617 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3619 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3620 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3623 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3625 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3626 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3627 (xg_hide_tooltip): Fix comment.
3629 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3630 in registerServicesMenuSendTypes.
3631 (validRequestorForSendType): Don't check ns_return_types.
3633 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3636 2011-07-08 Jason Rumney <jasonr@gnu.org>
3638 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3639 SH_SHOW for hidden windows (Bug#5482).
3641 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3642 frame struct members of non-existent frames (Bug#6284).
3644 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3646 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3647 variable firstTime not needed on OSX >= 10.6.
3648 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3649 >= 10.5. Use setKnobProportion, setDoubleValue.
3651 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3652 (MAC_OS_X_VERSION_10_5): Define if not defined.
3653 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3654 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3655 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3657 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3658 cString and lossyCString on OSX >= 10.4
3660 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3661 sizeToFit on OSX >= 10.2.
3663 * nsimage.m (allocInitFromFile): Don't use deprecated method
3664 bestRepresentationForDevice on OSX >= 10.6.
3666 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3669 * emacs.c: Declare unexec_init_emacs_zone.
3671 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3673 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3675 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3676 on svcsMenu (Bug#8842).
3678 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3680 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3682 * nsterm.m (QUTF8_STRING): Declare.
3683 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3684 (validRequestorForSendType): Return type is (id).
3685 Change indexOfObjectIdenticalTo to indexOfObject.
3686 Check if we have local selection before returning self (Bug#8842).
3687 (writeSelectionToPasteboard): Put local selection into paste board
3688 if we have a local selection (Bug#8842).
3689 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3691 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3692 (ns_get_local_selection): Declare.
3694 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3696 * keymap.c (describe_map_tree): Don't insert a double newline at
3697 the end of the buffer (bug#1169) and return whether we inserted
3700 * callint.c (Fcall_interactively): Change "reading args" to
3701 "providing args" to try to clarify what it does (bug#1010).
3703 2011-07-07 Kenichi Handa <handa@m17n.org>
3705 * composite.c (composition_compute_stop_pos): Ignore a static
3706 composition starting before CHARPOS (Bug#8915).
3708 * xdisp.c (handle_composition_prop): Likewise.
3710 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3712 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3715 2011-07-07 Kenichi Handa <handa@m17n.org>
3717 * character.h (unicode_category_t): New enum type.
3719 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3720 (Qchar_code_property_table): New variable.
3721 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3722 (UNIPROP_COMPRESSED_FORM_P): New macros.
3723 (char_table_ascii): Uncompress the compressed values.
3724 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3725 Uncompress the compressed values.
3726 (sub_char_table_ref_and_range): Likewise.
3727 (char_table_ref_and_range): Uncompress the compressed values.
3728 (sub_char_table_set): New arg is_uniprop. Callers changed.
3729 Uncompress the compressed values.
3730 (sub_char_table_set_range): Args changed. Callers changed.
3731 (char_table_set_range): Adjuted for the above change.
3732 (map_sub_char_table): Delete args default_val and parent. Add arg
3733 top. Give decoded values to a Lisp function.
3734 (map_char_table): Adjust for the above change. Give decoded
3735 values to a Lisp function. Gcpro more variables.
3736 (uniprop_table_uncompress)
3737 (uniprop_decode_value_run_length): New functions.
3738 (uniprop_decoder, uniprop_decoder_count): New variables.
3739 (uniprop_get_decoder, uniprop_encode_value_character)
3740 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3742 (uniprop_encoder, uniprop_encoder_count): New variables.
3743 (uniprop_get_encoder, uniprop_table)
3744 (Funicode_property_table_internal, Fget_unicode_property_internal)
3745 (Fput_unicode_property_internal): New functions.
3746 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3747 Sunicode_property_table_internal, Sget_unicode_property_internal,
3748 and Sput_unicode_property_internal. Defvar_lisp
3749 char-code-property-alist.
3751 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3752 Vunicode_category_table.
3754 * font.c (font_range): Adjust for the change of
3755 Vunicode_category_table.
3757 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3759 * m/iris4d.h: Remove file, move contents ...
3760 * s/irix6-5.h: ... here.
3762 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3764 Remove unportable assumption about struct layout (Bug#8884).
3765 * alloc.c (mark_buffer):
3766 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3767 (clone_per_buffer_values): Don't assume that
3768 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3769 This isn't true in general, and it's particularly not true
3770 if Emacs is configured with --with-wide-int.
3771 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3772 New macros, used in the buffer.c change.
3774 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3776 * xsettings.c: Use both GConf and GSettings if both are available.
3777 (store_config_changed_event): Add comment.
3778 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3779 (store_tool_bar_style_changed): New functions.
3780 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3781 (struct xsettings): Move font inside HAVE_XFT.
3782 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3783 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3784 Move inside HAVE_XFT.
3785 (something_changed_gsettingsCB): Rename from something_changedCB.
3786 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3788 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3789 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3790 (something_changed_gconfCB): Rename from something_changedCB.
3791 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3792 (parse_settings): Move check for font inside HAVE_XFT.
3793 (read_settings, apply_xft_settings): Add comment.
3794 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3795 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3796 call store_font_name_changed.
3797 (xft_settings_event): Add comment.
3798 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3799 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3800 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3801 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3802 (xsettings_initialize): Call init_gsettings last.
3803 (xsettings_get_system_font, xsettings_get_system_normal_font):
3806 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3808 Random fixes. E.g., (random) never returned negative values.
3809 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3810 subseconds part to the entropy, as that's a bit more random.
3811 Prefer signed to unsigned, since the signedness doesn't matter and
3812 in general we prefer signed. When given a limit, use a
3813 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3814 latter isn't right if USE_2_TAGS_FOR_INTS.
3815 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3816 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3818 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3820 * textprop.c (text_property_stickiness):
3821 Obey Vtext_property_default_nonsticky.
3822 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3823 * w32fns.c (syms_of_w32fns):
3824 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3826 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3828 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3829 This is more efficient than Ffile_directory_p and avoids a minor race.
3831 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3833 * buffer.c (Foverlay_put): Say what the return value is
3836 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3837 is a directory before asking whether to use the file name
3839 (barf_or_query_if_file_exists): Make the "File is a directory"
3840 error be more correct.
3842 * fns.c (Frequire): Remove the mention of the .gz files, since
3843 that's installation-specific, but keep the mention of
3844 `get-load-suffixes'.
3846 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3848 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3849 Report string overflow if the output is too long.
3851 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3853 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3854 (syms_of_gnutls): Remove duplicate DEFSYM for
3855 Qgnutls_bootprop_verify_hostname_error, an error for
3856 Qgnutls_bootprop_verify_error (which is no longer used).
3858 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3859 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3860 Also (re)move comments that are misplaced or no longer relevant.
3862 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3864 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3866 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3868 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3869 and background color parameters if they have been changed.
3871 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3873 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3875 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3877 * xsettings.c (SYSTEM_FONT): Define only when used.
3878 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3880 * keymap.c (access_keymap_1): Now static.
3882 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3884 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3885 leave any prefix arg for the up event (Bug#1586).
3887 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3889 * lread.c (syms_of_lread): Mention single symbols defined by
3890 `defvar' or `defconst' (bug#7154).
3892 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3893 (Frequire): Mention get-load-suffixes.
3895 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3897 * window.h (window): Remove clone_number slot.
3898 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3900 (make_parent_window, make_window, saved_window)
3901 (Fset_window_configuration, save_window_save): Don't deal with
3903 * buffer.c (Qclone_number): Remove declaration.
3904 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3906 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3908 Add multiple inheritance to keymaps.
3909 * keymap.c (Fmake_composed_keymap): New function.
3910 (Fset_keymap_parent): Simplify.
3911 (fix_submap_inheritance): Remove.
3912 (access_keymap_1): New function extracted from access_keymap to handle
3913 embedded parents and handle lists of maps.
3914 (access_keymap): Use it.
3915 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3916 (Fcopy_keymap): Handle embedded parents.
3917 (Fcommand_remapping, define_as_prefix): Simplify.
3918 (Fkey_binding): Simplify.
3919 (syms_of_keymap): Move minibuffer-local-completion-map,
3920 minibuffer-local-filename-completion-map,
3921 minibuffer-local-must-match-map, and
3922 minibuffer-local-filename-must-match-map to Elisp.
3923 (syms_of_keymap): Defsubr make-composed-keymap.
3924 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3925 (parse_menu_item): Trivial simplification.
3927 2011-07-01 Glenn Morris <rgm@gnu.org>
3929 * Makefile.in (SETTINGS_LIBS): Fix typo.
3931 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3933 * coding.c (Fencode_coding_string): Record the last coding system
3934 used, as the function doc string says (bug#8738).
3936 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3938 * xsettings.c (store_monospaced_changed): Take new font as arg and
3939 check for change against current_mono_font.
3940 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3941 (emacs_settings_constructor, emacs_settings_get_property)
3942 (emacs_settings_set_property, emacs_settings_class_init)
3943 (emacs_settings_init, gsettings_obj): Remove.
3944 (something_changedCB): New function for HAVE_GSETTINGS.
3945 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3946 with value as argument.
3947 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3948 g_settings_new (Bug#8967). Do not create gsettings_obj.
3949 Remove calls to g_settings_bind. Connect something_changedCB to
3952 * xgselect.c: Add defined (HAVE_GSETTINGS).
3953 (xgselect_initialize): Ditto.
3955 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3956 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3959 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3961 * eval.c (struct backtrace): Simplify and port the data structure.
3962 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3963 signed bit field, as this assumption is not portable and it makes
3964 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3965 "char debug_on_exit : 1" as this is not portable either; instead,
3966 use the portable "unsigned int debug_on_exit : 1". Remove unused
3967 member evalargs. Remove obsolete comments about cc bombing out.
3969 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3971 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3972 Let HAVE_GSETTINGS override HAVE_GCONF.
3973 (store_monospaced_changed): New function.
3974 (EMACS_SETTINGS): A new type derived from GObject to handle
3975 GSettings notifications.
3976 (emacs_settings_constructor, emacs_settings_get_property)
3977 (emacs_settings_set_property, emacs_settings_class_init):
3979 (gsettings_client, gsettings_obj): New variables.
3980 (GSETTINGS_SCHEMA): New define.
3981 (something_changedCB): Call store_monospaced_changed.
3982 (init_gsettings): New function.
3983 (xsettings_initialize): Call init_gsettings.
3984 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3987 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
3990 2011-06-29 Martin Rudalics <rudalics@gmx.at>
3992 * window.c (resize_root_window, grow_mini_window)
3993 (shrink_mini_window): Rename Qresize_root_window to
3994 Qwindow_resize_root_window and Qresize_root_window_vertically to
3995 Qwindow_resize_root_window_vertically.
3997 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3999 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4001 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4003 * makefile.w32-in: Redesign dependencies so they reflect more
4004 clearly which files are directly included by each source file,
4005 and not through other includes.
4007 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4009 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4010 (sort_overlays, overlay_strings): When an overlay's clone number
4011 matches the window's clone number process the overlay even if
4012 the overlay's window property doesn't match the current window.
4014 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4015 (Fwindow_hchild): Rename to Fwindow_left_child.
4016 (Fwindow_next): Rename to Fwindow_next_sibling.
4017 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4018 (resize_window_check): Rename to window_resize_check.
4019 (resize_window_apply): Rename to window_resize_apply.
4020 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4021 (Fdelete_other_windows_internal, resize_frame_windows)
4022 (Fsplit_window_internal, Fdelete_window_internal)
4023 (grow_mini_window, shrink_mini_window)
4024 (Fresize_mini_window_internal): Fix callers accordingly.
4026 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4028 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4029 (emacs_fixed_set_min_size): Remove.
4030 (emacs_fixed_new): Take frame as argument.
4032 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4033 (_EmacsFixedPrivate): Remove minwidth/height.
4034 Add struct frame *f.
4035 (emacs_fixed_init): Initialize priv->f.
4036 (get_parent_class, emacs_fixed_set_min_size): Remove.
4037 (emacs_fixed_new): Set priv->f to argument.
4038 (emacs_fixed_get_preferred_width)
4039 (emacs_fixed_get_preferred_height): Use min_width/height from
4040 frames size_hint to set minimum and natural (Bug#8919).
4041 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4042 and use min_width/height from frames size_hint to set
4043 min_width/height (Bug#8919).
4045 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4046 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4049 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4051 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4052 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4055 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4057 * process.c (wait_reading_process_output): Bypass select if
4058 waiting for a cell while ignoring keyboard input, and input is
4059 pending. Suggested by Jan Djärv (Bug#8869).
4061 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4063 Use gnulib's dup2 module instead of rolling our own.
4064 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4066 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4068 * dispnew.c (scrolling_window): Before scrolling, turn off a
4069 mouse-highlight in the window being scrolled.
4071 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4073 Move DEFSYM to lisp.h and use everywhere.
4075 * character.h (DEFSYM): Move declaration...
4076 * lisp.h (DEFSYM): ...here.
4082 * w32select.c: Don't include character.h.
4084 * alloc.c (syms_of_alloc):
4085 * buffer.c (syms_of_buffer):
4086 * bytecode.c (syms_of_bytecode):
4087 * callint.c (syms_of_callint):
4088 * casefiddle.c (syms_of_casefiddle):
4089 * casetab.c (init_casetab_once):
4090 * category.c (init_category_once, syms_of_category):
4091 * ccl.c (syms_of_ccl):
4092 * cmds.c (syms_of_cmds):
4093 * composite.c (syms_of_composite):
4094 * dbusbind.c (syms_of_dbusbind):
4095 * dired.c (syms_of_dired):
4096 * dispnew.c (syms_of_display):
4097 * doc.c (syms_of_doc):
4098 * editfns.c (syms_of_editfns):
4099 * emacs.c (syms_of_emacs):
4100 * eval.c (syms_of_eval):
4101 * fileio.c (syms_of_fileio):
4102 * fns.c (syms_of_fns):
4103 * frame.c (syms_of_frame):
4104 * fringe.c (syms_of_fringe):
4105 * insdel.c (syms_of_insdel):
4106 * keymap.c (syms_of_keymap):
4107 * lread.c (init_obarray, syms_of_lread):
4108 * macros.c (syms_of_macros):
4109 * msdos.c (syms_of_msdos):
4110 * print.c (syms_of_print):
4111 * process.c (syms_of_process):
4112 * search.c (syms_of_search):
4113 * sound.c (syms_of_sound):
4114 * syntax.c (init_syntax_once, syms_of_syntax):
4115 * terminal.c (syms_of_terminal):
4116 * textprop.c (syms_of_textprop):
4117 * undo.c (syms_of_undo):
4118 * w32.c (globals_of_w32):
4119 * window.c (syms_of_window):
4120 * xdisp.c (syms_of_xdisp):
4121 * xfaces.c (syms_of_xfaces):
4122 * xfns.c (syms_of_xfns):
4123 * xmenu.c (syms_of_xmenu):
4124 * xsettings.c (syms_of_xsettings):
4125 * xterm.c (syms_of_xterm): Use DEFSYM.
4127 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4129 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4131 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4133 Integer and buffer overflow fixes (Bug#8873).
4135 * print.c (printchar, strout): Check for string overflow.
4136 (PRINTPREPARE, printchar, strout):
4137 Don't set size unless allocation succeeds.
4139 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4140 for sizes. Check for string overflow more accurately.
4141 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4143 * macros.c: Integer and buffer overflow fixes.
4144 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4145 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4146 Use ptrdiff_t, not int, for sizes.
4147 Don't increment bufsize until after realloc succeeds.
4148 Check for size-calculation overflow.
4149 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4151 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4153 * lread.c: Integer overflow fixes.
4154 (read_integer): Radix is now EMACS_INT, not int,
4155 to improve quality of diagnostics for out-of-range radices.
4156 Calculate buffer size correctly for out-of-range radices.
4157 (read1): Check for integer overflow in radices, and in
4158 read-circle numbers.
4159 (read_escape): Avoid int overflow.
4160 (Fload, openp, read_buffer_size, read1)
4161 (substitute_object_recurse, read_vector, read_list, map_obarray):
4162 Use ptrdiff_t, not int, for sizes.
4163 (read1): Use EMACS_INT, not int, for sizes.
4164 Check for size overflow.
4166 * image.c (cache_image): Check for size arithmetic overflow.
4168 * lread.c: Integer overflow issues.
4169 (saved_doc_string_size, saved_doc_string_length)
4170 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4171 Now ptrdiff_t, not int.
4172 (read1): Don't assume doc string length fits in int. Check for
4173 out-of-range doc string lengths.
4174 (read_list): Don't assume file position fits in int.
4175 (read_escape): Check for hex character overflow.
4177 2011-06-22 Leo Liu <sdl.web@gmail.com>
4179 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4180 Move to minibuffer.el.
4182 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4184 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4185 The following patches are for when GLYPH_DEBUG && !XASSERT.
4186 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4187 * dispnew.c (flush_stdout):
4188 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4189 Mark as externally visible.
4190 * dispnew.c (check_window_matrix_pointers): Now static.
4191 * dispnew.c (window_to_frame_vpos):
4192 * xfns.c (unwind_create_frame):
4193 * xterm.c (x_check_font): Remove unused local.
4194 * scroll.c (CHECK_BOUNDS):
4195 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4196 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4197 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4198 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4199 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4201 (debug_method_add): Use va_list and vsprintf rather than relying
4202 on undefined behavior with wrong number of arguments.
4203 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4204 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4205 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4206 since we're not interested in debugging glyphs with old libraries.
4207 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4208 GCC 4.6.0's static checking.
4210 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4212 Integer overflow and signedness fixes (Bug#8873).
4213 A few related buffer overrun fixes, too.
4215 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4217 * dispextern.h (struct face.stipple):
4218 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4219 (x_bitmap_mask, x_allocate_bitmap_record)
4220 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4221 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4222 (x_create_bitmap_from_xpm_data):
4223 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4224 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4226 * xfaces.c (load_pixmap):
4227 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4228 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4229 (.bitmaps_last, struct x_output.icon_bitmap):
4230 Use ptrdiff_t, not int, for bitmap indexes.
4231 (x_allocate_bitmap_record): Check for size overflow.
4232 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4234 Use ptrdiff_t, not int, for overlay counts.
4235 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4236 * editfns.c (overlays_around, get_pos_property):
4237 * textprop.c (get_char_property_and_overlay):
4238 * xdisp.c (next_overlay_change, note_mouse_highlight):
4239 * xfaces.c (face_at_buffer_position):
4240 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4241 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4242 (Fnext_overlay_change, Fprevious_overlay_change)
4243 (mouse_face_overlay_overlaps, Foverlays_in):
4244 Use ptrdiff_t, not int, for sizes.
4245 (overlays_at, overlays_in): Check for size-calculation overflow.
4247 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4249 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4250 (x_session_initialize): Do not assume string length fits in int.
4252 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4253 This is unlikely, but can occur if DPI is outlandish.
4255 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4256 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4258 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4259 * xrdb.c (magic_file_p, search_magic_path):
4260 Omit last arg SUFFIX; it was always 0. All callers changed.
4261 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4263 * xfont.c (xfont_match): Avoid need for strlen.
4265 * xfns.c: Don't assume strlen fits in int.
4266 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4268 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4269 not unsigned long, as we prefer signed integers. All callers changed.
4270 Detect integer overflow in repeat count.
4271 (message_dolog): Don't assume print length fits in 39 bytes.
4272 (display_mode_element): Don't assume strlen fits in int.
4274 * termcap.c: Don't assume sizes fit in int and never overflow.
4275 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4276 (gobble_line): Check for size-calculation overflow.
4278 * minibuf.c (Fread_buffer):
4279 * lread.c (intern, intern_c_string):
4280 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4281 Don't assume string length fits in int.
4283 * keyboard.c (parse_tool_bar_item):
4284 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4286 * font.c: Don't assume string length fits in int.
4287 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4288 Use ptrdiff_t, not int.
4289 (font_intern_prop): Don't assume string length fits in int.
4290 Don't assume integer property fits in fixnum.
4291 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4293 * filelock.c: Fix some buffer overrun and integer overflow issues.
4294 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4295 Reformulate so as not to need the command string.
4296 Invoke gzip -cd rather than gunzip, as it's more portable.
4297 (lock_info_type, lock_file_1, lock_file):
4298 Don't assume pid_t and time_t fit in unsigned long.
4299 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4300 (current_lock_owner): Prefer signed type for sizes.
4301 Use memcpy, not strncpy, where memcpy is what is really wanted.
4302 Don't assume (via atoi) that time_t and pid_t fit in int.
4303 Check for time_t and/or pid_t out of range, e.g., via a network share.
4304 Don't alloca where an auto var works fine.
4306 * fileio.c: Fix some integer overflow issues.
4307 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4308 Don't assume string length fits in int.
4309 (directory_file_name): Don't assume string length fits in long.
4310 (make_temp_name): Don't assume pid fits in int, or that its print
4311 length is less than 20.
4313 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4315 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4317 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4319 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4320 We prefer signed integers, even for size calculations.
4322 * emacs.c: Don't assume string length fits in 'int'.
4323 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4324 (main): Don't invoke strlen when not needed.
4326 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4327 (XD_DEBUG_MESSAGE): Don't waste a byte.
4329 * callproc.c (getenv_internal_1, getenv_internal)
4331 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4333 * lread.c (invalid_syntax): Omit length argument.
4334 All uses changed. This doesn't fix a bug, but it simplifies the
4335 code away from its former Hollerith-constant appearance, and it's
4336 one less 'int' to worry about when looking at integer-overflow issues.
4337 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4339 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4340 This didn't break anything, but it didn't help either.
4341 It's confusing to put a bogus integer in a place where the actual
4342 value does not matter.
4343 (LIST_END_P): Remove unused macro and its bogus comment.
4344 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4346 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4347 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4349 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4350 We prefer signed types, and the value cannot exceed the EMACS_INT
4351 range anyway (because otherwise the length would not be representable).
4352 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4353 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4354 This avoids a GCC warning when WIDE_EMACS_INT.
4356 * indent.c (sane_tab_width): New function.
4357 (current_column, scan_for_column, Findent_to, position_indentation)
4358 (compute_motion): Use it. This is just for clarity.
4359 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4361 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4363 * lisp.h (lint_assume): New macro.
4364 * composite.c (composition_gstring_put_cache):
4365 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4367 * editfns.c, insdel.c:
4368 Omit unnecessary forward decls, to simplify future changes.
4370 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4372 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4374 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4375 Use much-faster test for byte-length change.
4376 Don't assume string byte-length fits in 'int'.
4377 Check that character arg fits in 'int'.
4378 (mapcar1): Declare byte as byte, for clarity.
4380 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4382 * fns.c (concat): Catch string overflow earlier.
4383 Do not rely on integer wraparound.
4385 * dispextern.h (struct it.overlay_strings_charpos)
4386 (struct it.selective): Now EMACS_INT, not int.
4387 * xdisp.c (forward_to_next_line_start)
4388 (back_to_previous_visible_line_start)
4389 (reseat_at_next_visible_line_start, next_element_from_buffer):
4390 Don't arbitrarily truncate the value of 'selective' to int.
4392 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4394 * composite.c: Don't truncate sizes to 'int'.
4395 (composition_gstring_p, composition_reseat_it)
4396 (composition_adjust_point): Use EMACS_INT, not int.
4397 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4398 not EMACS_UINT, for indexes.
4400 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4402 * buffer.c: Include <verify.h>.
4403 (struct sortvec.priority, struct sortstr.priority):
4404 Now EMACS_INT, not int.
4405 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4406 (struct sortstr.size, record_overlay_string)
4407 (struct sortstrlist.size, struct sortlist.used):
4408 Don't truncate size to int.
4409 (record_overlay_string): Check for size-calculation overflow.
4410 (init_buffer_once): Check at compile-time, not run-time.
4412 2011-06-22 Jim Meyering <meyering@redhat.com>
4414 Don't leak an XBM-image-sized buffer
4415 * image.c (xbm_load): Free the image buffer after using it.
4417 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4420 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4421 that Sun C diagnosed.
4422 * fns.c (secure_hash): Fix pointer signedness issue.
4423 * intervals.c (static_offset_intervals): New function.
4424 (offset_intervals): Use it.
4426 2011-06-21 Leo Liu <sdl.web@gmail.com>
4429 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4432 * fns.c (secure_hash): Rename from crypto_hash_function and change
4433 the first arg to accept symbols.
4434 (Fsecure_hash): New primitive.
4435 (syms_of_fns): New symbols.
4437 2011-06-20 Deniz Dogan <deniz@dogan.se>
4439 * process.c (Fset_process_buffer): Clarify return value in
4442 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4444 * dispnew.c (add_window_display_history): Use BVAR.
4446 * xdisp.c (debug_method_add): Use BVAR.
4447 (check_window_end, dump_glyph_matrix, dump_glyph)
4448 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4450 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4453 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4454 check till after the cache is created in init_frame_faces.
4456 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4458 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4460 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4462 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4463 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4464 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4466 Improve buffer-overflow checking (Bug#8873).
4467 * fileio.c (Finsert_file_contents):
4468 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4469 Remove the old (too-loose) buffer overflow checks.
4470 They weren't needed, since make_gap checks for buffer overflow.
4471 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4472 The old code merely checked for Emacs fixnum overflow, and relied
4473 on undefined (wraparound) behavior. The new code avoids undefined
4474 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4476 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4477 Tune. Don't use wider integers than needed. Don't use alloca.
4478 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4480 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4482 * insdel.c, lisp.h (buffer_overflow): New function.
4483 (insert_from_buffer_1, replace_range, replace_range_2):
4484 * insdel.c (make_gap_larger):
4485 * editfns.c (Finsert_char):
4486 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4488 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4490 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4492 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4494 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4495 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4497 * fileio.c: Don't assume EMACS_INT fits in off_t.
4498 (emacs_lseek): New static function.
4499 (Finsert_file_contents, Fwrite_region): Use it.
4500 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4502 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4504 * fns.c: Don't overflow int when computing a list length.
4505 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4506 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4507 truncation on 64-bit hosts. Check for QUIT every
4508 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4509 faster and is responsive enough.
4510 (Flength): Report an error instead of overflowing an integer.
4511 (Fsafe_length): Return a float if the value is not representable
4512 as a fixnum. This shouldn't happen except in contrived situations.
4513 (Fnthcdr, Fsort): Don't assume list length fits in int.
4514 (Fcopy_sequence): Don't assume vector length fits in int.
4516 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4517 (header_size, word_size): New constants.
4518 (allocate_vectorlike): Don't check size overflow here.
4519 (allocate_vector): Check it here instead, since this is the only
4520 caller of allocate_vectorlike that could cause overflow.
4521 Check that the new vector's length is representable as a fixnum.
4523 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4524 The previous code was bogus. For example, next_almost_prime (32)
4525 returned 39, which is undesirable as it is a multiple of 3; and
4526 next_almost_prime (24) returned 25, which is a multiple of 5 so
4527 why was the code bothering to check for multiples of 7?
4529 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4531 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4533 Variadic C functions now count arguments with ptrdiff_t.
4534 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4535 Back then I didn't know that the Emacs coding style prefers signed int.
4536 Also, in the meantime I found a few more instances where arguments
4537 were being counted with int, which may truncate counts on 64-bit
4538 machines, or EMACS_INT, which may be unnecessarily wide.
4539 * lisp.h (struct Lisp_Subr.function.aMANY)
4540 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4541 Arg counts are now ptrdiff_t, not size_t.
4542 All variadic functions and their callers changed accordingly.
4543 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4544 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4545 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4546 * callint.c (Fcall_interactively): Check arg count for overflow,
4547 to avoid potential buffer overrun. Use signed char, not 'int',
4548 for 'varies' array, so that we needn't bother to check its size
4549 calculation for overflow.
4550 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4551 * eval.c (apply_lambda):
4552 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4553 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4554 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4556 * callint.c (Fcall_interactively): Don't use index var as event count.
4558 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4559 * mem-limits.h (SIZE): Remove; no longer used.
4561 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4563 Remove unnecessary casts.
4564 * xterm.c (x_term_init):
4565 * xfns.c (x_set_border_pixel):
4566 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4567 These aren't needed now that we assume ANSI C.
4569 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4570 It's more likely to cause problems (due to unsigned overflow)
4573 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4575 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4577 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4579 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4581 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4583 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4585 GLYPH_CODE_FACE returns EMACS_INT, not int.
4586 * dispextern.h (merge_faces):
4587 * xfaces.c (merge_faces):
4588 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4589 Don't assume EMACS_INT fits in int.
4591 * character.h (CHAR_VALID_P): Remove unused parameter.
4592 * fontset.c, lisp.h, xdisp.c: All uses changed.
4594 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4596 * fns.c (concat): Minor tuning based on overflow analysis.
4597 This doesn't fix any bugs. Use int to hold character, instead
4598 of constantly refetching from Emacs object. Use XFASTINT, not
4599 XINT, for value known to be a character. Don't bother comparing
4600 a single byte to 0400, as it's always less.
4602 * floatfns.c (Fexpt):
4603 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4605 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4608 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4610 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4611 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4612 incorrectly succeed when S was a string, because 4294967386 was
4613 truncated before it was used.
4615 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4616 Otherwise, an out-of-range integer could cause undefined behavior
4619 * composite.c: Use int, not EMACS_INT, for characters.
4620 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4621 EMACS_INT, for values that are known to be in character range.
4622 This doesn't fix any bugs but is the usual style inside Emacs and
4623 may generate better code on 32-bit machines.
4625 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4626 This is for reasons similar to the recent CHAR_STRING fix.
4627 * charset.c (Fencode_char): Check that character arg is actually
4628 a character. Pass an int to ENCODE_CHAR.
4629 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4630 wider than 'int', as a compile-time check to prevent future regressions
4633 * character.c (char_string): Remove unnecessary casts.
4635 Make sure a 64-bit char is never passed to CHAR_STRING.
4636 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4637 by silently ignoring the top 32 bits, allowing some values
4638 that were far too large to be valid characters.
4639 * character.h: Include <verify.h>.
4640 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4641 arguments are no wider than unsigned, as a compile-time check
4642 to prevent future regressions in this area.
4644 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4645 (Fsubst_char_in_region):
4647 * xdisp.c (decode_mode_spec_coding):
4648 Adjust to CHAR_STRING's new requirement.
4649 * editfns.c (Finsert_char, Fsubst_char_in_region):
4650 * fns.c (concat): Check that character args are actually
4651 characters. Without this test, these functions did the wrong
4652 thing with wildly out-of-range values on 64-bit hosts.
4654 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4655 These casts should not be needed on 32-bit hosts, either.
4656 * keyboard.c (read_char):
4657 * lread.c (Fload): Remove casts to unsigned.
4659 * lisp.h (UNSIGNED_CMP): New macro.
4660 This fixes comparison bugs on 64-bit hosts.
4661 (ASCII_CHAR_P): Use it.
4662 * casefiddle.c (casify_object):
4663 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4664 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4665 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4666 * dispextern.h (FACE_FROM_ID):
4667 * keyboard.c (read_char): Use UNSIGNED_CMP.
4669 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4670 not to EMACS_INT, to avoid GCC warning.
4672 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4674 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4675 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4676 isn't needed on 32-bit machines.
4678 * buffer.c (Fgenerate_new_buffer_name):
4679 Use EMACS_INT for count, not int.
4680 (advance_to_char_boundary): Return EMACS_INT, not int.
4682 * data.c (Qcompiled_function): Now static.
4684 * window.c (window_body_lines): Now static.
4686 * image.c (gif_load): Rename local to avoid shadowing.
4688 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4689 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4690 * alloc.c (make_save_value): Integer argument is now of type
4692 (mark_object): Use ptrdiff_t, not int.
4693 * lisp.h (pD): New macro.
4694 * print.c (print_object): Use it.
4696 * alloc.c: Use EMACS_INT, not int, to count objects.
4697 (total_conses, total_markers, total_symbols, total_vector_size)
4698 (total_free_conses, total_free_markers, total_free_symbols)
4699 (total_free_floats, total_floats, total_free_intervals)
4700 (total_intervals, total_strings, total_free_strings):
4701 Now EMACS_INT, not int. All uses changed.
4702 (Fgarbage_collect): Compute overall total using a double, so that
4703 integer overflow is less likely to be a problem. Check for overflow
4704 when converting back to an integer.
4705 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4706 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4707 These were 'int' variables that could overflow on 64-bit hosts;
4708 they were never used, so remove them instead of repairing them.
4709 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4710 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4711 Previously, this ceilinged at INT_MAX, but that doesn't work on
4713 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4715 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4716 (allocate_vectorlike): Check for ptrdiff_t overflow.
4717 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4718 when a (possibly-narrower) signed value would do just as well.
4719 We prefer using signed arithmetic, to avoid comparison confusion.
4721 * alloc.c: Catch some string size overflows that we were missing.
4722 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4723 for convenience in STRING_BYTES_MAX.
4724 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4725 The definition here is exact; the one in lisp.h was approximate.
4726 (allocate_string_data): Check for string overflow. This catches
4727 some instances we weren't catching before. Also, it catches
4728 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4729 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4730 and ptrdiff_t and EMACS_INT are both 64 bits.
4732 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4733 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4734 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4736 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4738 * alloc.c (Fmake_string): Check for out-of-range init.
4740 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4742 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4744 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4746 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4747 xg_get_default_scrollbar_width.
4749 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4750 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4751 (style_changed_cb): Call update_theme_scrollbar_width and call
4752 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4753 all frames (Bug#8505).
4754 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4755 Call gtk_window_set_resizable if HAVE_GTK3.
4756 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4757 and height if HAVE_GTK3 (Bug#8505).
4758 (scroll_bar_width_for_theme): New variable.
4759 (update_theme_scrollbar_width): New function.
4760 (xg_get_default_scrollbar_width): Move code to
4761 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4762 (xg_initialize): Call update_theme_scrollbar_width.
4764 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4766 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4768 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4770 * frame.c (make_frame): Call other_buffer_safely instead of
4773 * window.c (temp_output_buffer_show): Call display_buffer with
4774 second argument Vtemp_buffer_show_specifiers and reset latter
4775 immediately after the call.
4776 (Vtemp_buffer_show_specifiers): New variable.
4777 (auto_window_vscroll_p, next_screen_context_lines)
4778 (Vscroll_preserve_screen_position): Remove leading asterisks from
4781 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4783 Fix minor problems found by GCC 4.6.0 static checking.
4784 * buffer.c (Qclone_number): Remove for now, as it's unused.
4785 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4786 (record_buffer): Remove unused local.
4787 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4788 (set_frame_buffer_list): Remove; unused.
4789 * frame.h (other_visible_frames): Remove decl.
4790 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4791 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4792 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4794 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4795 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4796 Define only if HAVE_GPM.
4797 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4798 (update_hints_inhibit): Remove; never set. All uses removed.
4799 * widgetprv.h (emacsFrameClassRec): Remove decl.
4800 * window.c (delete_deletable_window): Now returns void, since it
4801 wasn't returning anything.
4802 (compare_window_configurations): Remove unused locals.
4803 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4804 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4805 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4806 the same widths as pointers. This follows up on the 2011-05-06 patch.
4807 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4808 * xterm.h: Likewise.
4809 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4811 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4813 * makefile.w32-in: Update dependencies.
4814 (LISP_H): Add lib/intprops.h.
4816 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4818 * image.c (gif_load): Add animation frame delay to the metadata.
4819 (syms_of_image): Use DEFSYM. New symbol `delay'.
4821 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4823 * window.c (delete_deletable_window): Re-add.
4824 (Fset_window_configuration): Rewrite to handle dead buffers and
4825 consequently deletable windows.
4826 (window_tree, Fwindow_tree): Remove. Supply functionality in
4828 (compare_window_configurations): Simplify code.
4830 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4832 * image.c (imagemagick_load_image): Fix type mismatch.
4833 (Fimagemagick_types): Likewise.
4835 * window.h (replace_buffer_in_windows): Declare.
4837 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4839 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4840 Qclone_number. Remove external declaration of Qdelete_window.
4841 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4843 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4844 Run Qbuffer_list_update_hook if allowed.
4845 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4846 buffer list implementation.
4847 (other_buffer_safely): New function.
4848 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4849 calls to replace_buffer_in_windows and
4850 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4852 (record_buffer): Inhibit quitting and rewrite using quittable
4853 functions. Run Qbuffer_list_update_hook if allowed.
4854 (Frecord_buffer, Funrecord_buffer): New functions.
4855 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4856 Move switch-to-buffer to window.el.
4857 (bury-buffer): Move to window.el.
4858 (Vbuffer_list_update_hook): New variable.
4860 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4863 * window.h (resize_frame_windows): Move up in code.
4864 (Fwindow_frame): Remove EXFUN.
4865 (replace_buffer_in_all_windows): Remove prototype.
4866 (replace_buffer_in_windows_safely): Add prototype.
4868 * window.c: Declare Qdelete_window static again. Move down
4869 declaration of select_count.
4870 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4871 (Fother_window): Move to window.el.
4872 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4873 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4874 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4876 (replace_buffer_in_windows): Implement by calling
4877 Qreplace_buffer_in_windows.
4878 (replace_buffer_in_all_windows): Remove with some functionality
4879 moved into replace_buffer_in_windows_safely.
4880 (replace_buffer_in_windows_safely): New function.
4881 (select_window_norecord, select_frame_norecord): Move in front
4882 of run_window_configuration_change_hook. Remove now obsolete
4884 (Fset_window_buffer): Rewrite doc-string.
4885 Call Qrecord_window_buffer.
4886 (keys_of_window): Move binding for other-window to window.el.
4888 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4890 * dispextern.h (struct image): Replace data member, whose int_val
4891 and ptr_val fields were not used by anything, with a single
4894 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4895 (gif_clear_image, gif_load, imagemagick_load_image)
4896 (gs_clear_image, gs_load): Callers changed.
4898 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4900 * buffer.h: Include <time.h>, for time_t.
4901 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4903 Fix minor problems found by static checking.
4905 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4907 Make identifiers static if they are not used in other modules.
4908 * data.c (Qcompiled_function, Qframe, Qvector):
4909 * image.c (QimageMagick, Qsvg):
4910 * minibuf.c (Qmetadata):
4911 * window.c (resize_window_check, resize_root_window): Now static.
4912 * window.h (resize_window_check, resize_root_window): Remove decls.
4914 * window.c (window_deletion_count, delete_deletable_window):
4916 (window_body_lines): Now static.
4917 (Fdelete_other_windows_internal): Mark vars as initialized.
4918 Make sure 'resize_failed' is initialized.
4919 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4920 (resize_window_apply): Remove unused local.
4921 * window.h (delete_deletable_window): Remove decl.
4923 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4924 (imagemagick_load_image): Fix pointer signedness problem by changing
4925 last arg from unsigned char * to char *. All uses changed.
4926 Also, fix a local for similar reasons.
4927 Remove unused locals. Remove locals to avoid shadowing.
4928 (fn_rsvg_handle_free): Remove; unused.
4929 (svg_load, svg_load_image): Fix pointer signedness problem.
4930 (imagemagick_load_image): Don't use garbage pointer image_wand.
4932 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4934 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4936 * image.c (gif_load): Fix omitted cast error introduced by
4939 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4941 * window.h (resize_proportionally, orig_total_lines)
4942 (orig_top_line): Remove from window structure.
4943 (set_window_height, set_window_width, change_window_heights)
4944 (Fdelete_window): Remove prototypes.
4945 (resize_frame_windows): Remove duplicate declaration.
4947 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4949 * window.h (resize_frame_windows, resize_window_check)
4950 (delete_deletable_window, resize_root_window)
4951 (resize_frame_windows): Declare prototypes.
4953 * window.c (resize_window_apply): Make definition be "static" to
4954 match the prototype.
4956 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4958 * window.c: Remove declarations of Qwindow_size_fixed,
4959 window_min_size_1, window_min_size_2, window_min_size,
4960 size_window, window_fixed_size_p, enlarge_window, delete_window.
4961 Remove static from declaration of Qdelete_window, it's
4962 temporarily needed by Fbury_buffer.
4963 (replace_window): Don't assign orig_top_line and
4965 (Fdelete_window, delete_window): Remove. Window deletion is
4966 handled by window.el.
4967 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4968 Replace Fdelete_window calls with calls to Qdelete_window.
4969 (Fdelete_other_windows): Remove. Deleting other windows is
4970 handled by window.el.
4971 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4972 handled in window.el.
4973 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4974 Window minimum sizes are handled in window.el.
4975 (shrink_windows, size_window, set_window_height)
4976 (set_window_width, change_window_heights, window_height)
4977 (window_width, CURBEG, CURSIZE, enlarge_window)
4978 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4979 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4980 handled in window.el.
4981 (make_dummy_parent): Rename to make_parent_window and give it a
4982 second argument horflag.
4983 (make_window): Don't set resize_proportionally any more.
4984 (Fsplit_window): Remove. Windows are split in window.el.
4985 (save_restore_action, save_restore_orig_size)
4986 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4987 Resize mini windows in window.el.
4988 (grow_mini_window, shrink_mini_window): Implement by calling
4989 Qresize_root_window_vertically, resize_window_check and
4990 resize_window_apply.
4991 (saved_window, Fset_window_configuration, save_window_save):
4992 Do not handle orig_top_line, orig_total_lines, and
4993 resize_proportionally.
4994 (window_min_height, window_min_width): Move to window.el.
4995 (keys_of_window): Move bindings for delete-other-windows,
4996 split-window, delete-window and enlarge-window to window.el.
4998 * buffer.c: Temporarily extern Qdelete_window.
4999 (Fbury_buffer): Temporarily call Qdelete_window instead of
5000 Fdelete_window (Fbury_buffer will move to window.el soon).
5002 * frame.c (set_menu_bar_lines_1): Remove code handling
5003 orig_top_line and orig_total_lines.
5005 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5006 set_window_height but set heights directly.
5007 (change_frame_size_1): Use resize_frame_windows.
5009 * xdisp.c (init_xdisp): Don't use set_window_height but set
5012 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5013 Use resize_frame_windows instead of change_window_heights and run
5014 run_window_configuration_change_hook.
5016 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5017 instead of change_window_heights and run
5018 run_window_configuration_change_hook.
5020 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5022 * window.c (replace_window): Rename second argument REPLACEMENT to
5023 NEW. New third argument SETFLAG. Rewrite.
5024 (delete_window, make_dummy_parent): Call replace_window with
5026 (window_list_1): Move down in code.
5027 (run_window_configuration_change_hook): Move set_buffer part
5028 before select_frame_norecord part in order to unwind correctly.
5029 Rename count1 to count.
5030 (recombine_windows, delete_deletable_window, resize_root_window)
5031 (Fdelete_other_windows_internal)
5032 (Frun_window_configuration_change_hook, make_parent_window)
5033 (resize_window_check, resize_window_apply, Fresize_window_apply)
5034 (resize_frame_windows, Fsplit_window_internal)
5035 (Fdelete_window_internal, Fresize_mini_window_internal):
5037 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5039 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5041 * window.h (window): Add some new members to window structure -
5042 normal_lines, normal_cols, new_total, new_normal, clone_number,
5043 splits, nest, prev_buffers, next_buffers.
5044 (WINDOW_TOTAL_SIZE): Move here from window.c.
5045 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5047 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5049 (make_dummy_parent): Set new members of windows structure.
5050 (make_window): Move down in code. Handle new members of window
5052 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5053 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5054 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5055 (Fset_window_prev_buffers, Fwindow_next_buffers)
5056 (Fset_window_next_buffers, Fset_window_clone_number):
5058 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5059 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5061 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5062 Argument WINDOW can be now internal window too.
5063 (Fwindow_use_time): Move up in code.
5064 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5066 (Fset_window_configuration, saved_window)
5067 (Fcurrent_window_configuration, save_window_save): Handle new
5068 members of window structure.
5069 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5070 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5071 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5072 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5073 Qget_mru_window, Qresize_root_window,
5074 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5075 Qauto_buffer_name; staticpro them.
5077 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5079 * window.c (Fwindow_total_size, Fwindow_left_column)
5080 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5081 (Fwindow_list_1): New functions.
5082 (window_box_text_cols): Replace with window_body_cols.
5083 (Fwindow_width, Fscroll_left, Fscroll_right):
5084 Use window_body_cols instead of window_box_text_cols.
5085 (delete_window, Fset_window_configuration):
5086 Call delete_all_subwindows with window as argument.
5087 (delete_all_subwindows): Take a window as argument and not a
5089 (window_loop): Remove handling of GET_LRU_WINDOW and
5091 (Fget_lru_window, Fget_largest_window): Move to window.el.
5093 * window.h: Extern window_body_cols instead of
5094 window_box_text_cols. delete_all_subwindows now takes a
5095 Lisp_Object as argument.
5097 * indent.c (compute_motion, Fcompute_motion):
5098 Use window_body_cols instead of window_box_text_cols.
5100 * frame.c (delete_frame): Call delete_all_subwindows with root
5103 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5105 * fns.c (Fputhash): Document return value.
5107 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5109 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5111 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5113 Cons<->int and similar integer overflow fixes (Bug#8794).
5115 Check for overflow when converting integer to cons and back.
5116 * charset.c (Fdefine_charset_internal, Fdecode_char):
5117 Use cons_to_unsigned to catch overflow.
5118 (Fencode_char): Use INTEGER_TO_CONS.
5119 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5120 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5121 * data.c (long_to_cons, cons_to_long): Remove.
5122 (cons_to_unsigned, cons_to_signed): New functions.
5123 These signal an error for invalid or out-of-range values.
5124 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5125 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5126 * font.c (Ffont_variation_glyphs):
5127 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5128 * lisp.h: Include <intprops.h>.
5129 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5130 (cons_to_signed, cons_to_unsigned): New decls.
5131 (long_to_cons, cons_to_long): Remove decls.
5132 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5133 (Fprimitive_undo): Use CONS_TO_INTEGER.
5134 * xfns.c (Fx_window_property): Likewise.
5135 * xselect.c: Include <limits.h>.
5136 (x_own_selection, selection_data_to_lisp_data):
5137 Use INTEGER_TO_CONS.
5138 (x_handle_selection_request, x_handle_selection_clear)
5139 (x_get_foreign_selection, Fx_disown_selection_internal)
5140 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5141 (lisp_data_to_selection_data): Use cons_to_unsigned.
5142 (x_fill_property_data): Use cons_to_signed.
5143 Report values out of range.
5145 Check for buffer and string overflow more precisely.
5146 * buffer.h (BUF_BYTES_MAX): New macro.
5147 * lisp.h (STRING_BYTES_MAX): New macro.
5148 * alloc.c (Fmake_string):
5149 * character.c (string_escape_byte8):
5150 * coding.c (coding_alloc_by_realloc):
5151 * doprnt.c (doprnt):
5152 * editfns.c (Fformat):
5154 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5155 since they may not be the same number.
5156 * editfns.c (Finsert_char):
5157 * fileio.c (Finsert_file_contents):
5158 Likewise for BUF_BYTES_MAX.
5160 * image.c: Use ptrdiff_t, not int, for sizes.
5161 (slurp_file): Switch from int to ptrdiff_t.
5163 (slurp_file): Check that file size fits in both size_t (for
5164 malloc) and ptrdiff_t (for sanity and safety).
5166 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5167 if b->modtime has its maximal value.
5169 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5171 Don't assume time_t can fit into int.
5172 * buffer.h (struct buffer.modtime): Now time_t, not int.
5173 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5174 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5176 Minor fixes for signed vs unsigned integers.
5177 * character.h (MAYBE_UNIFY_CHAR):
5178 * charset.c (maybe_unify_char):
5179 * keyboard.c (read_char, reorder_modifiers):
5180 XINT -> XFASTINT, since the integer must be nonnegative.
5181 * ftfont.c (ftfont_spec_pattern):
5182 * keymap.c (access_keymap, silly_event_symbol_error):
5183 XUINT -> XFASTINT, since the integer must be nonnegative.
5184 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5185 since it makes no difference and we prefer signed.
5186 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5187 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5190 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5192 * window.h (Fwindow_frame): Declare.
5194 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5196 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5197 (SPARE_MEMORY): Always define.
5198 (LARGE_REQUEST): Remove.
5199 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5201 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5203 * lisp.h: Move EXFUNS for Fframe_root_window,
5204 Fframe_first_window and Fset_frame_selected_window to window.h.
5206 * window.h: Move EXFUNS for Fframe_root_window,
5207 Fframe_first_window and Fset_frame_selected_window here from
5210 * frame.c (Fwindow_frame, Fframe_first_window)
5211 (Fframe_root_window, Fframe_selected_window)
5212 (Fset_frame_selected_window): Move to window.c.
5213 (Factive_minibuffer_window): Move to minibuf.c.
5214 (Fother_visible_frames_p): New function.
5216 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5218 * window.c (decode_window, decode_any_window): Move up in code.
5219 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5220 (inhibit_frame_unsplittable): Remove unused variable.
5221 (Fwindow_buffer): Move up and rewrite doc-string.
5222 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5223 (Fwindow_prev): New functions.
5224 (Fwindow_frame): Move here from frame.c. Accept any window as
5226 (Fframe_root_window, Fframe_first_window)
5227 (Fframe_selected_window): Move here from frame.c. Accept frame
5228 or arbitrary window as argument. Update doc-strings.
5229 (Fminibuffer_window): Move up in code.
5230 (Fwindow_minibuffer_p): Move up in code and simplify.
5231 (Fset_frame_selected_window): Move here from frame.c.
5233 (Fselected_window, select_window, Fselect_window): Move up in
5234 code. Minor doc-string fixes.
5236 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5238 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5239 Do not assume that spare memory exists; that assumption is valid
5240 only if SYSTEM_MALLOC.
5241 (LARGE_REQUEST): New macro, so that the issue of large requests
5242 is separated from the issue of spare memory.
5244 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5246 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5249 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5251 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5254 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5256 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5258 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5260 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5261 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5263 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5265 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5267 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5269 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5270 (x_clipboard_manager_save): Add return value.
5271 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5273 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5274 Obey Vx_select_enable_clipboard_manager. Catch errors in
5275 x_clipboard_manager_save (Bug#8779).
5276 (Vx_select_enable_clipboard_manager): New variable.
5277 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5279 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5281 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5283 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5285 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5286 in the current matrix if keep_current_p is non-zero.
5288 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5290 * bidi.c (bidi_level_of_next_char): Fix last change.
5292 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5294 Support bidi reordering of text covered by display properties.
5296 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5297 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5298 (bidi_cache_search, bidi_cache_iterator_state)
5299 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5300 (bidi_level_of_next_char, bidi_move_to_visually_next):
5301 Support character positions inside a run of characters covered by a
5303 (bidi_paragraph_init, bidi_resolve_explicit_1)
5304 (bidi_level_of_next_char): Call bidi_fetch_char and
5305 bidi_fetch_char_advance instead of FETCH_CHAR and
5307 (bidi_init_it): Initialize new members.
5308 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5310 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5311 instead of using explicit *_CHAR codes.
5312 (bidi_resolve_explicit, bidi_resolve_weak):
5313 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5314 bidirectional text is supported only in multibyte buffers.
5315 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5316 it to initialize the frame_window_p member of struct bidi_it.
5317 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5318 (bidi_resolve_explicit, bidi_resolve_weak)
5319 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5320 bidi_it->nchars is non-positive.
5321 (bidi_level_of_next_char): Don't try to lookup the cache for the
5322 next/previous character if nothing is cached there yet, or if we
5323 were just reseat()'ed to a new position.
5325 * xdisp.c (set_cursor_from_row): Set start and stop points
5326 according to the row's direction when priming the loop that looks
5327 for the glyph on which to display cursor.
5328 (single_display_spec_intangible_p): Function deleted.
5329 (display_prop_intangible_p): Reimplement to call
5330 handle_display_spec instead of single_display_spec_intangible_p.
5331 Accept 3 additional arguments needed by handle_display_spec.
5332 This fixes incorrect cursor motion across display property with complex
5333 values: lists, `(when COND...)' forms, etc.
5334 (single_display_spec_string_p): Support property values that are
5335 lists with the argument STRING its top-level element.
5336 (display_prop_string_p): Fix the condition for processing a
5337 property that is a list to be consistent with handle_display_spec.
5338 (handle_display_spec): New function, refactored from the
5339 last portion of handle_display_prop.
5340 (compute_display_string_pos): Accept additional argument
5341 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5342 value of a `display' property is a "replacing spec".
5343 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5344 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5345 the display property, but just return a value indicating whether
5346 the display property will replace the characters it covers.
5347 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5348 frame_window_p members of struct bidi_it.
5349 (compute_display_string_pos, compute_display_string_end):
5351 (push_it): Accept second argument POSITION, where pop_it should
5352 jump to continue iteration.
5353 (reseat_1): Initialize bidi_it.disp_pos.
5355 * keyboard.c (adjust_point_for_property): Adjust the call to
5356 display_prop_intangible_p to its new signature.
5358 * dispextern.h (struct bidi_it): New member frame_window_p.
5359 (bidi_init_it): Update prototypes.
5360 (display_prop_intangible_p): Update prototype.
5361 (compute_display_string_pos, compute_display_string_end):
5363 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5366 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5368 Malloc failure behavior now depends on size of allocation.
5369 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5370 * lisp.h: Change signatures accordingly.
5371 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5372 All callers changed. (Bug#8762)
5374 * gnutls.c: Use Emacs's memory allocators.
5375 Without this change, the gnutls library would invoke malloc etc.
5376 directly, which causes problems on non-SYNC_INPUT hosts, and which
5377 runs afoul of improving memory_full behavior. (Bug#8761)
5378 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5379 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5380 xfree instead of the default malloc, realloc, free.
5381 (Fgnutls_boot): No need to check for memory allocation failure,
5382 since xmalloc does that for us.
5384 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5385 * category.c (hash_get_category_set):
5386 * ccl.c (ccl_driver):
5387 * charset.c (Fdefine_charset_internal):
5388 * charset.h (struct charset.hash_index):
5389 * composite.c (get_composition_id, gstring_lookup_cache)
5390 (composition_gstring_put_cache):
5391 * composite.h (struct composition.hash_index):
5392 * dispextern.h (struct image.hash):
5393 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5394 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5395 (hashfn_equal, hashfn_user_defined, make_hash_table)
5396 (maybe_resize_hash_table, hash_lookup, hash_put)
5397 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5398 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5399 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5400 * image.c (make_image, search_image_cache, lookup_image)
5401 (xpm_put_color_table_h):
5402 * lisp.h (struct Lisp_Hash_Table):
5403 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5404 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5405 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5406 * alloc.c (allocate_vectorlike):
5407 Check for overflow in vector size calculations.
5408 * ccl.c (ccl_driver):
5409 Check for overflow when converting EMACS_INT to int.
5410 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5411 need to be updated by these changes.
5412 * fns.c (make_hash_table, maybe_resize_hash_table):
5413 Check for integer overflow with large hash tables.
5414 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5415 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5416 (SXHASH_REDUCE): New macro.
5417 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5418 Use it instead of discarding useful hash info with large hash values.
5419 (sxhash_float): New function.
5420 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5421 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5422 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5423 Rewrite to use FIXNUM_BITS, as this simplifies things.
5424 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5425 Adjust signatures to match updated version of code.
5426 (consing_since_gc): Now EMACS_INT, since a single hash table can
5427 use more than INT_MAX bytes.
5429 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5431 Make it possible to build with GCC-4.6+ -O2 -flto.
5433 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5435 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5437 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5438 Call minibuffer-inactive-mode.
5440 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5442 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5443 Update dependencies.
5445 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5447 * data.c (init_data): Remove code for UTS, this system is not
5450 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5452 Don't force ./temacs to start in terminal mode.
5454 * frame.c (make_initial_frame): Initialize faces in all cases, not
5455 only when CANNOT_DUMP is defined.
5456 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5458 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5460 * dispnew.c (add_window_display_history): Use const for the string
5461 pointer. Remove declaration, not needed.
5463 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5465 Use 'inline', not 'INLINE'.
5466 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5467 * alloc.c, fontset.c (INLINE): Remove.
5468 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5469 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5470 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5471 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5472 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5474 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5476 Make it possible to run ./temacs.
5478 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5479 syms_of_callproc does the same thing. Remove test for
5480 "initialized", do it in the caller.
5481 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5483 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5485 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5486 (read_minibuf): Use get_minibuffer.
5487 (syms_of_minibuf): Use DEFSYM.
5488 (Qmetadata): New var.
5489 * data.c (Qbuffer): Don't make it static.
5490 (syms_of_data): Use DEFSYM.
5492 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5494 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5495 (CCL_CODE_MIN): New macro.
5497 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5499 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5501 * eval.c (Qdebug): Now static.
5502 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5503 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5504 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5506 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5508 * image.c: Various fixes to ImageMagick code comments.
5509 (Fimagemagick_types): Doc fix.
5511 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5513 Minor fixes prompted by GCC 4.6.0 warnings.
5515 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5517 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5518 (x_clipboard_manager_save_all): Move extern decl to ...
5519 * xterm.h: ... here, so that it can be checked for consistency.
5521 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5523 * xselect.c (x_clipboard_manager_save_frame)
5524 (x_clipboard_manager_save_all): New functions.
5525 (Fx_clipboard_manager_save): Lisp function deleted.
5527 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5528 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5530 * xterm.h: Update prototype.
5532 2011-05-28 William Xu <william.xwl@gmail.com>
5534 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5537 2011-05-28 Jim Meyering <meyering@redhat.com>
5539 Avoid a sign-extension bug in crypto_hash_function.
5540 * fns.c (to_uchar): Define.
5541 (crypto_hash_function): Use it to convert some newly-signed
5542 variables to unsigned, to avoid sign-extension bugs. For example,
5543 without this change, (md5 "truc") would evaluate to
5544 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5545 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5546 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5548 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5550 Integer overflow fixes.
5552 * dbusbind.c: Serial number integer overflow fixes.
5553 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5554 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5555 to hold a serial number that is too large for a fixnum.
5556 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5557 Check for serial numbers out of range. Decode any serial number
5558 that was so large that it became a float. (Bug#8722)
5560 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5561 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5562 Use XFASTINT rather than XUINT when numbers are nonnegative.
5563 (xd_append_arg, Fdbus_method_return_internal):
5564 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5565 arguments, check that Lisp number is nonnegative, rather than
5566 silently wrapping negative numbers around. (Bug#8722)
5567 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5570 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5572 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5574 ccl: add integer overflow checks
5575 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5576 (IN_INT_RANGE): New macros.
5577 (ccl_driver): Use them to check for integer overflow when
5578 decoding a CCL program. Many of the new checks are whether XINT (x)
5579 fits in int; it doesn't always, on 64-bit hosts. The new version
5580 doesn't catch all possible integer overflows, but it's an
5581 improvement. (Bug#8719)
5583 * alloc.c (make_event_array): Use XINT, not XUINT.
5584 There's no need for unsigned here.
5586 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5587 This follows up to the 2011-05-06 change that substituted uintptr_t
5588 for EMACS_INT. This case wasn't caught back then.
5590 Rework Fformat to avoid integer overflow issues.
5591 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5592 now (part of C89). Include <verify.h>.
5593 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5594 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5595 (Fformat): Avoid the prepass trying to compute sizes; it was only
5596 approximate and thus did not catch overflow reliably. Instead, walk
5597 through the format just once, formatting and computing sizes as we go,
5598 checking for integer overflow at every step, and allocating a larger
5599 buffer as needed. Keep track separately whether the format is
5600 multibyte. Keep only the most-recently calculated precision, rather
5601 than them all. Record whether each argument has been converted to
5602 string. Use EMACS_INT, not int, for byte and char and arg counts.
5603 Support field widths and precisions larger than INT_MAX. Avoid
5604 sprintf's undefined behavior with conversion specifications such as %#d
5605 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5606 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5607 formatting out-of-range floating point numbers with int
5610 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5612 * data.c: Avoid integer truncation in expressions involving floats.
5613 * data.c: Include <intprops.h>.
5614 (arith_driver): When there's an integer overflow in an expression
5615 involving floating point, convert the integers to floating point
5616 so that the resulting value does not suffer from catastrophic
5617 integer truncation. For example, on a 64-bit host (* 4
5618 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5619 Do not rely on undefined behavior after integer overflow.
5621 merge count_size_as_multibyte, parse_str_to_multibyte
5622 * character.c, character.h (count_size_as_multibyte):
5623 Rename from parse_str_to_multibyte; all uses changed.
5624 Check for integer overflow.
5625 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5626 since it's now a duplicate of the other. This is more of
5627 a character than a buffer op, so better that it's in character.c.
5628 * fns.c, print.c: Adjust to above changes.
5630 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5632 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5634 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5636 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5637 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5638 (x_clipboard_manager_save): Now static.
5639 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5641 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5642 (crypto_hash_function): Now static.
5643 Fix pointer signedness problems. Avoid unnecessary initializations.
5645 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5647 * termhooks.h (Vselection_alist): Make it terminal-local.
5649 * terminal.c (create_terminal): Initialize it.
5651 * xselect.c: Support for clipboard managers.
5652 (Vselection_alist): Move to termhooks.h as terminal-local var.
5653 (LOCAL_SELECTION): New macro.
5654 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5655 (symbol_to_x_atom): Remove gratuitous arg.
5656 (x_handle_selection_request, lisp_data_to_selection_data)
5657 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5658 (x_own_selection, x_get_local_selection, x_convert_selection):
5659 New arg, specifying work frame. Use terminal-local Vselection_alist.
5660 (some_frame_on_display): Delete unused function.
5661 (Fx_own_selection_internal, Fx_get_selection_internal)
5662 (Fx_disown_selection_internal, Fx_selection_owner_p)
5663 (Fx_selection_exists_p): New optional frame arg.
5664 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5665 (x_handle_selection_clear): Don't treat other terminals with the
5666 same keyboard specially. Use the terminal-local Vselection_alist.
5667 (x_clear_frame_selections): Use Frun_hook_with_args.
5669 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5671 * xterm.h: Add support for those atoms.
5673 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5675 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5676 (converted_selections, conversion_fail_tag): New global variables.
5677 (x_selection_request_lisp_error): Free the above.
5678 (x_get_local_selection): Remove unnecessary code.
5679 (x_reply_selection_request): Args changed; handle arbitrary array
5680 of converted selections stored in converted_selections.
5681 Separate the XChangeProperty and SelectionNotify steps.
5682 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5683 (x_convert_selection): New function.
5684 (x_handle_selection_event): Simplify.
5685 (x_get_foreign_selection): Don't ignore incoming requests while
5686 waiting for an answer; this will fail when we implement
5687 SAVE_TARGETS, and seems unnecessary anyway.
5688 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5689 (Vx_sent_selection_functions): Doc fix.
5691 2011-05-26 Leo Liu <sdl.web@gmail.com>
5693 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5695 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5697 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5699 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5700 for fringe update if it has periodic bitmap.
5701 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5702 and fringe_bitmap_periodic_p.
5704 * fringe.c (get_fringe_bitmap_data): New function.
5705 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5706 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5707 row. Mark glyph row for fringe update if periodicity changed.
5709 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5710 for fringe update unless it has periodic bitmap.
5712 2011-05-25 Kenichi Handa <handa@m17n.org>
5714 * xdisp.c (get_next_display_element): Set correct it->face_id for
5715 a static composition.
5717 2011-05-24 Leo Liu <sdl.web@gmail.com>
5720 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5722 * fns.c (crypto_hash_function, Fsha1): New function.
5723 (Fmd5): Use crypto_hash_function.
5724 (syms_of_fns): Add Ssha1.
5726 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5728 * gnutls.c: Remove unused macros.
5729 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5730 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5731 Remove macros that are defined and never used.
5732 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5734 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5736 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5737 (Fx_get_selection_internal): Minor cleanup.
5738 (Fx_own_selection_internal): Rename arguments for consistency with
5741 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5743 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5745 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5747 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5749 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5751 * dispnew.c (scrolling_window): Don't exclude the case that the
5752 last enabled row in the desired matrix touches the bottom boundary.
5754 2011-05-21 Glenn Morris <rgm@gnu.org>
5756 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5757 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5758 and add some more files.
5760 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5762 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5763 report_file_error introduced by the change from 2011-05-07.
5765 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5767 * systime.h (Time): Define only if emacs is defined.
5768 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5769 where the include path doesn't have X11/X.h by default. See
5770 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5772 2011-05-20 Kenichi Handa <handa@m17n.org>
5774 * composite.c (find_automatic_composition): Fix previous change.
5776 2011-05-20 Glenn Morris <rgm@gnu.org>
5778 * lisp.mk: New file, split from Makefile.in.
5779 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5780 (shortlisp): Remove.
5781 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5783 2011-05-19 Glenn Morris <rgm@gnu.org>
5785 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5786 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5787 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5788 (lisp): Set the order to that of loadup.el.
5789 (shortlisp): Make it a copy of $lisp.
5790 (SOME_MACHINE_LISP): Remove.
5791 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5792 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5794 2011-05-18 Kenichi Handa <handa@m17n.org>
5796 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5797 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5798 (find_automatic_composition): Mostly rewrite for efficiency.
5800 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5802 * makefile.w32-in: Update dependencies.
5804 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5806 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5807 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5809 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5811 Fix some integer overflow issues, such as string length overflow.
5813 * insdel.c (count_size_as_multibyte): Check for string overflow.
5815 * character.c (lisp_string_width): Check for string overflow.
5816 Use EMACS_INT, not int, for string indexes and lengths; in
5817 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5818 the resulting string length overflows an EMACS_INT; instead,
5819 report a string overflow if no precision given. When checking for
5820 precision exhaustion, use a check that cannot possibly have
5821 integer overflow. (Bug#8675)
5822 * character.h (lisp_string_width): Adjust to new signature.
5824 * alloc.c (string_overflow): New function.
5825 (Fmake_string): Use it. This doesn't change behavior, but saves
5826 a few bytes and will simplify future changes.
5827 * character.c (string_escape_byte8): Likewise.
5828 * lisp.h (string_overflow): New decl.
5830 Fixups, following up to the user-interface timestamp change.
5831 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5832 for UI timestamps, instead of unsigned long.
5833 * msdos.c (mouse_get_pos): Likewise.
5834 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5835 * w32gui.h (Time): Define by including "systime.h" rather than by
5836 declaring it ourselves. (Bug#8664)
5838 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5839 * image.c (clear_image_cache): Likewise.
5841 * term.c (term_mouse_position): Don't assume time_t wraparound.
5843 Be more systematic about user-interface timestamps.
5844 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5845 and sometimes 'EMACS_UINT', to represent these timestamps.
5846 This change causes it to use 'Time' uniformly, as that's what X uses.
5847 This makes the code easier to follow, and makes it easier to catch
5848 integer overflow bugs such as Bug#8664.
5849 * frame.c (Fmouse_position, Fmouse_pixel_position):
5850 Use Time, not unsigned long, for user-interface timestamps.
5851 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5852 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5853 * keyboard.h (last_event_timestamp): Likewise.
5854 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5855 * menu.h (xmenu_show): Likewise.
5856 * term.c (term_mouse_position): Likewise.
5857 * termhooks.h (struct input_event.timestamp): Likewise.
5858 (struct terminal.mouse_position_hook): Likewise.
5859 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5860 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5861 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5862 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5864 * menu.h, termhooks.h: Include "systime.h", for Time.
5866 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5867 Don't assume that the difference between two unsigned long values
5868 can fit into an integer. At this point, we know button_down_time
5869 <= event->timestamp, so the difference must be nonnegative, so
5870 there's no need to cast the result if double-click-time is
5871 nonnegative, as it should be; check that it's nonnegative, just in
5872 case. This bug is triggered when events are more than 2**31 ms
5873 apart (about 25 days). (Bug#8664)
5875 * xselect.c (last_event_timestamp): Remove duplicate decl.
5876 (x_own_selection): Remove needless cast to unsigned long.
5878 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5879 that always fit in int. Use a sentinel instead of a counter, to
5880 avoid a temp and to allay GCC's concerns about possible int overflow.
5881 * frame.h (struct frame): Use int for menu_bar_items_used
5882 instead of EMACS_INT, since it always fits in int.
5884 * menu.c (grow_menu_items): Check for int overflow.
5886 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5888 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5889 Before, the code was not consistent. These values cannot exceed
5890 2**31 - 1 so there's no need to make them unsigned.
5891 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5892 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5893 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5895 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5897 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5898 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5899 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5900 presumably because the widths might not match.
5902 * window.c (size_window): Avoid needless test at loop start.
5904 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5906 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5908 2011-05-12 Drew Adams <drew.adams@oracle.com>
5910 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5912 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5914 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5915 `width' to `bar_area_x' and `bar_area_width', respectively.
5916 (x_scroll_run): Take account of fringe background extension.
5918 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5919 Rename local vars `left' and `width' to `bar_area_x' and
5920 `bar_area_width', respectively.
5921 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5922 background extension.
5924 2011-05-10 Jim Meyering <meyering@redhat.com>
5926 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5928 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5930 * image.c (Finit_image_library): Return t for built-in image types,
5931 like pbm and xbm. (Bug#8640)
5933 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5935 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5937 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5939 * w32console.c (Fset_screen_color): Doc fix.
5940 (Fget_screen_color): New function.
5941 (syms_of_ntterm): Defsubr it.
5943 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5944 unlink the temporary file if Fcall_process didn't create it in the
5946 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5947 child process will be redirected to a file specified with `:file'.
5948 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5949 cue to call_process_cleanup not to close that handle.
5951 2011-05-07 Ben Key <bkey76@gmail.com>
5953 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5954 one of two shell specific rules, either bootstrap-temacs-CMD or
5955 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5956 to the previous implementation of the bootstrap-temacs rule.
5957 The bootstrap-temacs-CMD rule is similar to the previous
5958 implementation of the bootstrap-temacs rule except that it
5959 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5962 These changes, along with some changes to nt/configure.bat,
5963 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5964 earlier fix to add support for --cflags and --ldflags options
5965 that include quotes so that it works whether make uses cmd or
5968 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
5970 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5971 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5973 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5974 a string. Handle both cases.
5975 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5976 (Fdbus_register_method): Use Qinvalid_function.
5978 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5980 * makefile.w32-in: Update dependencies.
5981 (LISP_H): Add inttypes.h and stdin.h.
5982 (PROCESS_H): Add unistd.h.
5984 2011-05-06 Eli Zaretskii <eliz@gnu.org>
5986 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5987 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5989 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
5991 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5993 * term.c (vfatal): Remove stray call to va_end.
5994 It's not needed and the C Standard doesn't allow it here anyway.
5996 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5997 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5999 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6002 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6004 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6006 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6008 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6010 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6012 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6013 * charset.c (Fdefine_charset_internal): Don't initialize
6014 charset.code_space[15]. The value was garbage, on hosts with
6015 32-bit int (Bug#8600).
6017 * lread.c (read_integer): Be more consistent with string-to-number.
6018 Use string_to_number to do the actual conversion; this avoids
6019 rounding errors and fixes some other screwups. Without this fix,
6020 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6021 (digit_to_number): Move earlier, for benefit of read_integer.
6022 Return -1 if the digit is out of range for the base, -2 if it is
6023 not a digit in any supported base. (Bug#8602)
6025 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6027 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6028 to match comment at start of function. This also removes a
6029 GCC warning about overflow in a 32+64-bit port.
6031 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6033 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6034 Reported by Stefan Monnier in
6035 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6036 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6037 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6039 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6040 (EMACS_UINTPTR): Likewise, with uintptr_t.
6042 * lisp.h: Prefer 64-bit EMACS_INT if available.
6043 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6044 on 32-bit hosts that have 64-bit int, so that they can access
6046 However, temporarily disable this change unless the temporary
6047 symbol WIDE_EMACS_INT is defined.
6049 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6051 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6052 This removes an assumption that EMACS_INT and long are the same
6053 width as pointers. The assumption is true for Emacs porting targets
6054 now, but we want to make other targets possible.
6055 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6056 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6057 In the rest of the code, change types of integers that hold casted
6058 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6059 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6060 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6061 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6062 No need to cast type when ORing.
6063 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6064 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6065 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6066 assume EMACS_INT is the same width as char *.
6067 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6068 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6069 Remove no-longer-needed casts.
6070 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6071 (xg_tool_bar_help_callback, xg_make_tool_item):
6072 Use EMACS_INTPTR to hold an integer
6073 that will be cast to void *; this can avoid a GCC warning
6074 if EMACS_INT is not the same width as void *.
6075 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6076 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6077 (current_message_1, set_message_1):
6078 Use a local to convert to proper width without a cast.
6079 * xmenu.c (dialog_selection_callback): Likewise.
6081 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6082 Also, don't assume VALBITS / RAND_BITS is less than 5,
6083 and don't rely on undefined behavior when shifting a 1 left into
6085 * lisp.h (get_random): Change signature to match.
6087 * lread.c (hash_string): Use size_t, not int, for hash computation.
6088 Normally we prefer signed values; but hashing is special, because
6089 it's better to use unsigned division on hash table sizes so that
6090 the remainder is nonnegative. Also, size_t is the natural width
6091 for hashing into memory. The previous code used 'int', which doesn't
6092 retain enough info to hash well into very large tables.
6093 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6095 * dbusbind.c: Don't possibly lose pointer info when converting.
6096 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6097 Use XPNTR rather than XHASH, so that the high-order bits of
6098 the pointer aren't lost when converting through void *.
6100 * eval.c (Fautoload): Don't double-shift a pointer.
6102 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6104 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6106 * gnutls.c (DEF_GNUTLS_FN):
6107 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6109 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6111 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6114 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6116 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6117 New version that can reserve upto 2GB of heap space.
6119 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6121 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6123 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6125 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6126 `gnutls_certificate_set_x509_key_file'.
6128 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6130 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6131 Update dependencies.
6133 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6135 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6136 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6137 Remove unused parameter `fildes'.
6138 * process.c (read_process_output, send_process): Don't pass it.
6140 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6142 Fix previous change: the library cache is defined in w32.c.
6143 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6144 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6146 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6148 Implement dynamic loading of GnuTLS on Windows.
6150 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6151 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6152 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6155 * gnutls.c (Qgnutls_dll): Define.
6156 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6157 (gnutls_*): Declare function pointers.
6158 (init_gnutls_functions): New function to initialize function pointers.
6159 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6160 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6161 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6162 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6163 (emacs_gnutls_write, emacs_gnutls_read)
6164 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6165 (Fgnutls_available_p): New function.
6166 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6167 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6168 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6170 * image.c: Include w32.h.
6171 (Vimage_type_cache): Delete.
6172 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6173 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6174 (w32_delayed_load): Move to w32.c.
6176 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6178 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6179 (w32_delayed_load): Move from image.c. When loading a library, record
6180 its filename in the :loaded-from property of the library id.
6181 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6182 Initialize and staticpro them.
6183 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6185 * process.c: Include lisp.h before w32.h, not after.
6186 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6187 instead of gnutls_record_check_pending.
6189 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6191 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6193 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6194 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6197 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6199 * xterm.c (x_set_frame_alpha): Do not set property on anything
6200 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6202 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6204 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6206 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6208 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6209 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6210 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6211 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6212 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6213 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6214 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6215 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6216 (Qgnutls_bootprop_callbacks_verify): Make static.
6218 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6220 * callproc.c: Indentation fixup.
6222 * sysdep.c (wait_for_termination_1): Make static.
6223 (wait_for_termination, interruptible_wait_for_termination):
6224 Move after wait_for_termination_1.
6226 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6228 * sysdep.c (interruptible_wait_for_termination): New function
6229 which is like wait_for_termination, but allows keyboard
6232 * callproc.c (Fcall_process): Add (:file "file") as an option for
6234 (Fcall_process_region): Ditto.
6236 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6238 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6239 rather than `XVECTOR (FOO)->size'.
6241 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6242 inttypes.h, as a gnulib replacement is used if it not available in
6245 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6247 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6248 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6249 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6251 * coding.c (coding_alloc_by_realloc): Error out if destination
6252 will grow beyond MOST_POSITIVE_FIXNUM.
6253 (decode_coding_emacs_mule): Abort if there isn't enough place in
6254 charbuf for the composition carryover bytes. Reserve an extra
6255 space for up to 2 characters produced in a loop.
6256 (decode_coding_iso_2022): Abort if there isn't enough place in
6257 charbuf for the composition carryover bytes.
6259 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6261 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6262 aborting when %lld or %lll format is passed.
6263 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6264 %llo or %llx format is passed. (Bug#8545)
6266 * window.c (window_scroll_line_based): Use a marker instead of
6267 simple variables to record original value of point. (Bug#7952)
6269 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6270 produced by %s or %c overflows available buffer space. (Bug#8545)
6272 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6274 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6275 (SIZE_MAX): Move defn after all includes, as they might #define it.
6277 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6279 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6281 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6283 * keyboard.c (Qdelayed_warnings_hook): Define.
6284 (command_loop_1): Run `delayed-warnings-hook'
6285 if Vdelayed_warnings_list is non-nil.
6286 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6287 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6289 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6291 * doprnt.c (doprnt): Don't return value smaller than the buffer
6292 size if the message was truncated. (Bug#8545).
6294 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6296 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6297 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6299 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6301 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6303 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6305 * makefile.w32-in: Update dependencies.
6307 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6309 Improve `doprnt' and its usage. (Bug#8545)
6310 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6311 `format_end'. Remove support for %l as a conversion specifier.
6312 Don't use xrealloc. Improve diagnostics when the %l size modifier
6313 is used. Update the commentary.
6315 * eval.c (verror): Simplify calculation of size_t.
6317 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6320 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6322 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6325 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6327 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6328 This makes this file independent of the recent pseudovector change.
6330 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6332 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6334 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6335 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6336 Remove unused local.
6337 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6339 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6340 GCC 4.6.0 optimizes based on type-based alias analysis.
6341 For example, if b is of type struct buffer * and v of type struct
6342 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6343 != &v->size, and therefore "v->size = 1; b->size = 2; return
6344 v->size;" must therefore return 1. This assumption is incorrect
6345 for Emacs, since it type-puns struct Lisp_Vector * with many other
6346 types. To fix this problem, this patch adds a new type struct
6347 vectorlike_header that documents the constraints on layout of vectors
6348 and pseudovectors, and helps optimizing compilers not get fooled
6349 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6350 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6351 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6353 (XSETPVECTYPE): Rewrite in terms of new macro.
6354 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6355 This is a bit clearer, and further avoids the possibility of
6356 undesirable aliasing.
6357 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6358 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6359 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6360 since Lisp_Subr is a special case (no "next" field).
6361 (ASIZE): Now uses header.size rather than size.
6362 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6363 to avoid the hassle of writing XVECTOR (foo)->header.size.
6364 (struct vectorlike_header): New type.
6365 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6366 object, to help avoid aliasing.
6367 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6368 (SUBRP): Likewise, since Lisp_Subr is a special case.
6369 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6370 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6371 (struct Lisp_Hash_Table): Combine first two members into a single
6372 struct vectorlike_header member. All uses of "size" and "next" members
6373 changed to be "header.size" and "header.next".
6374 * buffer.h (struct buffer): Likewise.
6375 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6376 * frame.h (struct frame): Likewise.
6377 * process.h (struct Lisp_Process): Likewise.
6378 * termhooks.h (struct terminal): Likewise.
6379 * window.c (struct save_window_data, struct saved_window): Likewise.
6380 * window.h (struct window): Likewise.
6381 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6382 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6383 * buffer.c (init_buffer_once): Likewise.
6384 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6386 * process.c (Fformat_network_address): Use local var for size,
6389 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6391 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6392 * data.c (atof): Remove decl; no longer used or needed.
6393 (digit_to_number): Move to lread.c.
6394 (Fstring_to_number): Use new string_to_number function, to be
6395 consistent with how the Lisp reader treats infinities and NaNs.
6396 Do not assume that floating-point numbers represent EMACS_INT
6397 without losing information; this is not true on most 64-bit hosts.
6398 Avoid double-rounding errors, by insisting on integers when
6399 parsing non-base-10 numbers, as the documentation specifies.
6400 * lisp.h (string_to_number): New decl, replacing ...
6401 (isfloat_string): Remove.
6402 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6403 (read1): Do not accept +. and -. as integers; this
6404 appears to have been a coding error. Similarly, do not accept
6405 strings like +-1e0 as floating point numbers. Do not report
6406 overflow for integer overflows unless the base is not 10 which
6407 means we have no simple and reliable way to continue.
6408 Break out the floating-point parsing into a new
6409 function string_to_number, so that Fstring_to_number parses
6410 floating point numbers consistently with the Lisp reader.
6411 (digit_to_number): Move here from data.c. Make it static inline.
6412 (E_CHAR, EXP_INT): Remove, replacing with ...
6413 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6414 (string_to_number): New function, replacing isfloat_string.
6415 This function checks for valid syntax and produces the resulting
6416 Lisp float number too. Rework it so that string-to-number
6417 no longer mishandles examples like "1.0e+". Use strtoumax,
6418 so that overflow for non-base-10 numbers is reported only when
6419 there's no portable and simple way to convert to floating point.
6421 * textprop.c (set_text_properties_1): Rewrite for clarity,
6422 and to avoid GCC warning about integer overflow.
6424 * intervals.h (struct interval): Use EMACS_INT for members
6425 where EMACS_UINT might cause problems. See
6426 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6427 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6428 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6430 (offset_intervals): Tell GCC not to worry about length overflow
6431 when negating a negative length.
6433 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6434 (overrun_check_free): Likewise.
6436 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6437 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6440 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6441 (gnutls_make_error): Rename local to avoid shadowing.
6442 (gnutls_emacs_global_deinit): ifdef out; not used.
6443 (Fgnutls_boot): Use const for pointer to readonly storage.
6444 Comment out unused local. Fix pointer signedness problems.
6446 * lread.c (openp): Don't stuff size_t into an 'int'.
6447 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6448 about possible signed overflow.
6450 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6451 (GDK_KEY_g): Don't define if already defined.
6452 (xg_prepare_tooltip): Avoid pointer signedness problem.
6453 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6455 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6456 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6458 * xfns.c (Fx_window_property): Simplify a bit,
6459 to make a bit faster and to avoid GCC 4.6.0 warning.
6460 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6462 * fns.c (internal_equal): Don't assume size_t fits in int.
6464 * alloc.c (compact_small_strings): Tighten assertion a little.
6466 Replace pEd with more-general pI, and fix some printf arg casts.
6467 * lisp.h (pI): New macro, generalizing old pEd macro to other
6468 conversion specifiers. For example, use "...%"pI"d..." rather
6469 than "...%"pEd"...".
6470 (pEd): Remove. All uses replaced with similar uses of pI.
6471 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6472 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6473 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6474 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6475 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6476 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6477 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6479 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6480 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6481 * print.c (safe_debug_print, print_object): Likewise.
6482 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6484 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6485 avoiding the 0 flag, which is not portable.
6486 * process.c (Fmake_network_process): Use pI to avoid cast.
6487 * region-cache.c (pp_cache): Likewise.
6488 * xdisp.c (decode_mode_spec): Likewise.
6489 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6490 behavior on 64-bit hosts with printf arg.
6491 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6492 (x_stop_queuing_selection_requests): Likewise.
6493 (x_get_window_property): Don't truncate byte count to an 'int'
6496 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6497 here, since it parses constructs like leading '-' and spaces,
6498 which are not wanted; and it overflows with large numbers.
6499 Instead, simply match F[0-9]+, which is what is wanted anyway.
6501 * alloc.c: Remove unportable assumptions about struct layout.
6502 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6503 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6504 (allocate_vectorlike, make_pure_vector): Use the new macros,
6505 plus offsetof, to remove unportable assumptions about struct layout.
6506 These assumptions hold on all porting targets that I know of, but
6507 they are not guaranteed, they're easy to remove, and removing them
6508 makes further changes easier.
6510 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6511 This doesn't fix a bug but makes the code clearer.
6512 (string_overrun_cookie): Now const. Use initializers that
6513 don't formally overflow signed char, to avoid warnings.
6514 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6515 can cause Emacs to crash when string overrun checking is enabled.
6516 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6517 multiple of sizeof (EMACS_INT); it need not be, if
6518 alignof(EMACS_INT) < sizeof (EMACS_INT).
6519 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6521 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6523 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6525 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6527 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6528 supposed to be handshaking. (Bug#8556)
6529 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6531 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6533 * lisp.h (Qdebug): List symbol.
6534 * eval.c (Qdebug): Restore global linkage.
6535 * keyboard.c (debug-on-event): New variable.
6536 (handle_user_signal): Break into debugger when debug-on-event
6537 matches the current signal symbol.
6539 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6541 * alloc.c (check_sblock, check_string_bytes)
6542 (check_string_free_list): Convert to standard C.
6544 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6546 * w32.c (emacs_gnutls_push): Fix typo.
6548 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6550 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6551 "cast to pointer from integer of different size".
6553 Improve doprnt and its use in verror. (Bug#8545)
6554 * doprnt.c (doprnt): Document the set of format control sequences
6555 supported by the function. Use SAFE_ALLOCA instead of always
6558 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6559 is one byte too soon. Don't use xrealloc; instead xfree and
6562 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6564 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6567 * gnutls.c: Renamed global_initialized to
6568 gnutls_global_initialized. Added internals for the
6569 :verify-hostname-error, :verify-error, and :verify-flags
6570 parameters of `gnutls-boot' and documented those parameters in the
6571 docstring. Start callback support.
6572 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6573 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6574 on error. Return error code.
6575 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6576 (emacs_gnutls_read): Likewise.
6577 (Fgnutls_boot): Return handshake error code.
6578 (emacs_gnutls_handle_error): New function.
6579 (wsaerror_to_errno): Likewise.
6581 * w32.h (emacs_gnutls_pull): Add prototype.
6582 (emacs_gnutls_push): Likewise.
6584 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6585 (emacs_gnutls_push): Likewise.
6587 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6589 * process.c (wait_reading_process_output): Check if GnuTLS
6590 buffered some data internally if no FDs are set for TLS
6593 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6594 (LIBS): Link to USER_LIBS.
6595 ($(BLD)/gnutls.$(0)): New target.
6597 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6599 * xdisp.c (handle_single_display_spec): Rename the
6600 display_replaced_before_p argument into display_replaced_p, to
6601 make it consistent with the commentary. Fix typos in the
6604 * textprop.c (syms_of_textprop): Remove dead code.
6605 (copy_text_properties): Delete obsolete commentary about an
6606 interface that was deleted long ago. Fix typos in the description
6609 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6610 to changes in oldXMenu/XMenu.h from 2011-04-16.
6611 <menu_help_message, prev_menu_help_message>: Constify.
6612 (IT_menu_make_room): menu->help_text is now `const char **';
6615 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6616 to changes in oldXMenu/XMenu.h from 2011-04-16.
6617 (struct XMenu): Declare `help_text' `const char **'.
6619 * xfaces.c <Qunspecified>: Make extern again.
6621 * syntax.c: Include sys/types.h before including regex.h, as
6624 * doc.c (get_doc_string): Improve the format passed to `error'.
6626 * doprnt.c (doprnt): Improve commentary.
6628 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6630 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6633 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6634 changes in globals.h immediately force recompilation.
6635 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6636 $(CURDIR)/s/ms-w32.h.
6637 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6639 * character.c (Fchar_direction): Function deleted.
6640 (syms_of_character): Don't defsubr it.
6641 <char-direction-table>: Deleted.
6643 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6645 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6646 * doprnt.c: Include limits.h.
6647 (SIZE_MAX): New macro.
6648 (doprnt): Return a size_t value. 2nd arg is now size_t.
6649 Many local variables are now size_t instead of int or unsigned.
6650 Improve overflow protection. Support `l' modifier for integer
6651 conversions. Support %l conversion. Don't assume an EMACS_INT
6652 argument for integer conversions and for %c.
6654 * lisp.h (doprnt): Restore prototype.
6656 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6659 * Makefile.in (base_obj): Add back doprnt.o.
6661 * deps.mk (doprnt.o): Add back prerequisites.
6662 (callint.o): Depend on character.h.
6664 * eval.c (internal_lisp_condition_case): Include the handler
6665 representation in the error message.
6666 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6667 when breaking from the loop.
6669 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6671 * callint.c (Fcall_interactively): When displaying error message
6672 about invalid control letter, pass the character's codepoint, not
6673 a pointer to its multibyte form. Improve display of the character
6674 in octal and display also its hex code.
6676 * character.c (char_string): Use %x to display the (unsigned)
6677 codepoint of an invalid character, to avoid displaying a bogus
6680 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6681 `error', not SYMBOL_NAME itself.
6683 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6684 character arguments to `error'.
6686 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6687 to `error' in error message about FINAL_CHAR argument. Make sure
6688 FINAL_CHAR is a character, and use %c when it is passed as
6689 argument to `error'.
6691 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6693 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6695 * w32.c: Include <time.h>.
6696 (sys_localtime): New function.
6698 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6700 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6702 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6704 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6706 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6709 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6711 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6712 gl_state.e_property when gl_state.object is Qt.
6714 * insdel.c (make_gap_larger): Remove limitation of buffer size
6717 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6719 * xdisp.c (lookup_glyphless_char_display)
6720 (produce_glyphless_glyph): Handle cons cell entry in
6721 glyphless-char-display.
6722 (Vglyphless_char_display): Document it.
6724 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6725 glyphless-char-display.
6727 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6729 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6731 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6733 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6734 definition for no-X builds.
6736 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6738 Static checks with GCC 4.6.0 and non-default toolkits.
6740 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6742 * process.c (keyboard_bit_set): Define only if SIGIO.
6743 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6744 (send_process): Repair possible setjmp clobbering.
6746 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6748 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6750 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6752 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6753 Define only if needed.
6755 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6756 by pacifying GCC about it. Maybe it's time to retire it?
6757 * xfaces.c (USG, __TIMEVAL__): Likewise.
6759 * dispextern.h (struct redisplay_interface): Rename param
6761 * termhooks.h (struct terminal): Likewise.
6762 * xterm.c (xembed_send_message): Likewise.
6764 * insdel.c (make_gap_smaller): Define only if
6765 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6767 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6770 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6771 so that we aren't warned about unused symbols.
6773 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6775 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6777 * xfns.c (x_real_positions): Mark locals as initialized.
6779 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6781 * xterm.c: Fix problems found by static analysis with other toolkits.
6782 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6783 (x_dispatch_event): Declare static if USE_GTK, and
6784 define if USE_GTK || USE_X_TOOLKIT.
6785 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6786 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6787 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6788 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6790 * xmenu.c (menu_help_callback): Pointer type fixes.
6791 Use const pointers when pointing at readonly data. Avoid pointer
6793 (FALSE): Remove unused macro.
6794 (update_frame_menubar): Remove unused decl.
6796 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6798 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6799 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6800 (single_menu_item): Rename local to avoid shadowing.
6802 * keyboard.c (make_lispy_event): Remove unused local var.
6804 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6805 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6807 * bitmaps: Change bitmaps from unsigned char back to the X11
6808 compatible char. Avoid the old compiler warnings about
6809 out-of-range initializers by using, for example, '\xab' rather
6812 * xgselect.c (xgselect_initialize): Check vs interface
6813 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6815 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6817 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6818 to read-only memory.
6820 * fns.c (vector): Remove; this old hack is no longer needed.
6822 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6824 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6826 * xrdb.c (x_load_resources): Omit unused local.
6828 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6829 (x_window): Rename locals to avoid shadowing.
6830 (USG): Use the kludged USG macro, to pacify gcc.
6832 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6833 (x_term_init): Remove local to avoid shadowing.
6835 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6837 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6838 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6840 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6842 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6844 Fix regex.c, syntax.c and friends for buffers > 2GB.
6845 * syntax.h (struct gl_state_s): Declare character position members
6848 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6850 * textprop.c (verify_interval_modification, interval_of):
6851 Declare arguments EMACS_INT.
6853 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6856 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6858 * indent.c (Fvertical_motion): Local variable it_start is now
6861 * regex.c (re_match, re_match_2, re_match_2_internal)
6862 (bcmp_translate, regcomp, regexec, print_double_string)
6863 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6864 (re_compile_pattern, re_exec): Declare arguments and local
6865 variables `size_t' and `ssize_t' and return values `regoff_t', as
6867 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6868 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6869 <compile_stack_type>: `size' and `avail' are now `size_t'.
6871 * regex.h <regoff_t>: Use ssize_t, not int.
6872 (re_search, re_search_2, re_match, re_match_2): Arguments that
6873 specify buffer/string position and length are now ssize_t and
6874 size_t. Return type is regoff_t.
6876 2011-04-16 Ben Key <bkey76@gmail.com>
6878 * nsfont.m: Fixed bugs in ns_get_family and
6879 ns_descriptor_to_entity that were caused by using free to
6880 deallocate memory blocks that were allocated by xmalloc (via
6881 xstrdup). This caused Emacs to crash when compiled with
6882 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6883 --enable-checking=xmallocoverrun). xfree is now used to
6884 deallocate these memory blocks.
6886 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6888 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6890 emacs_write: Accept and return EMACS_INT for sizes.
6891 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6893 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6894 Accept and return EMACS_INT.
6895 (emacs_gnutls_write): Return the number of bytes written on
6897 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6898 (emacs_read, emacs_write): Remove check for negative size, as the
6899 Emacs source code has been audited now.
6900 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6901 (emacs_read, emacs_write): Use it.
6902 * process.c (send_process): Adjust to the new signatures of
6903 emacs_write and emacs_gnutls_write. Do not attempt to store
6904 a byte offset into an 'int'; it might overflow.
6905 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6907 * sound.c: Don't assume sizes fit in 'int'.
6908 (struct sound_device.period_size, alsa_period_size):
6909 Return EMACS_INT, not int.
6910 (struct sound_device.write, vox_write, alsa_write):
6911 Accept EMACS_INT, not int.
6912 (wav_play, au_play): Use EMACS_INT to store sizes and to
6913 record read return values.
6915 2011-04-15 Ben Key <bkey76@gmail.com>
6917 * keyboard.c (Qundefined): Don't declare static since it is used
6919 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6920 static since they are used in nsfont.m.
6922 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6924 * process.c (Qprocessp): Don't declare static.
6925 * lisp.h (Qprocessp): Declare again.
6927 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6929 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6931 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6933 Improve C-level modularity by making more things 'static'.
6935 Don't publish debugger-only interfaces to other modules.
6936 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6937 (verify_bytepos, count_markers): Move decls to the only modules
6939 * region-cache.h (pp_cache): Likewise.
6940 * window.h (check_all_windows): Likewise.
6941 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6943 * sysdep.c (croak): Now static, if
6944 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6945 * syssignal.h (croak): Declare only if not static.
6947 * alloc.c (refill_memory_reserve): Now static if
6948 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6949 * lisp.h (refill_memory_reserve): Declare only if not static.
6951 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6952 Define only if USE_LUCID.
6954 * xrdb.c (x_customization_string, x_rm_string): Now static.
6956 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6957 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6959 * xdisp.c (draw_row_with_mouse_face): Now static.
6960 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6962 * window.h (check_all_windows): Mark externally visible.
6964 * window.c (window_deletion_count): Now static.
6966 * undo.c: Make symbols static if they're not exported.
6967 (last_undo_buffer, last_boundary_position, pending_boundary):
6970 * textprop.c (interval_insert_behind_hooks): Now static.
6971 (interval_insert_in_front_hooks): Likewise.
6973 * term.c: Make symbols static if they're not exported.
6974 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6975 (max_frame_lines, tty_set_terminal_modes):
6976 (tty_reset_terminal_modes, tty_turn_off_highlight):
6977 (get_tty_terminal): Now static.
6978 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6979 * termhooks.h (term_mouse_moveto): Do not declare if
6981 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6982 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6984 * sysdep.c: Make symbols static if they're not exported.
6985 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6987 (sigprocmask_set, full_mask): Remove; unused.
6988 (wait_debugging): Mark as visible.
6989 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6990 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6992 * syntax.c (syntax_temp): Define only if !__GNUC__.
6994 * sound.c (current_sound_device, current_sound): Now static.
6996 * search.c (searchbufs, searchbuf_head): Now static.
6998 * scroll.c (scroll_cost): Remove; unused.
6999 * dispextern.h (scroll_cost): Remove decl.
7001 * region-cache.h (pp_cache): Mark as externally visible.
7003 * process.c: Make symbols static if they're not exported.
7004 (process_tick, update_tick, create_process, chan_process):
7005 (Vprocess_alist, proc_buffered_char, datagram_access):
7006 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7007 (deactivate_process): Mark defn as static, as well as decl.
7008 * lisp.h (create_process): Remove decl.
7009 * process.h (chan_process, Vprocess_alist): Remove decls.
7011 * print.c: Make symbols static if they're not exported.
7012 (print_depth, new_backquote_output, being_printed, print_buffer):
7013 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7014 (print_interval, print_number_index, initial_stderr_stream):
7016 * lisp.h (Fprinc): Remove decl.
7017 (debug_output_compilation_hack): Mark as externally visible.
7019 * sysdep.c (croak): Move decl from here to syssignal.h.
7020 * syssignal.h (croak): Put it here, so the API can be checked when
7021 'croak' is called from dissociate_if_controlling_tty.
7023 * minibuf.c: Make symbols static if they're not exported.
7024 (minibuf_save_list, choose_minibuf_frame): Now static.
7025 * lisp.h (choose_minibuf_frame): Remove decl.
7027 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7029 * lread.c: Make symbols static if they're not exported.
7030 (read_objects, initial_obarray, oblookup_last_bucket_number):
7032 (make_symbol): Remove; unused.
7033 * lisp.h (initial_obarray, make_symbol): Remove decls.
7035 * keyboard.c: Make symbols static if they're not exported.
7036 (single_kboard, recent_keys_index, total_keys, recent_keys):
7037 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7038 (this_single_command_key_start, echoing, last_auto_save):
7039 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7040 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7041 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7042 (Vlispy_mouse_stem, double_click_count):
7044 (force_auto_save_soon): Define only if SIGDANGER.
7045 (ignore_mouse_drag_p): Now static if
7046 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7047 (print_help): Remove; unused.
7048 (stop_character, last_timer_event): Mark as externally visible.
7049 * keyboard.h (ignore_mouse_drag_p): Declare only if
7050 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7051 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7052 * lisp.h (echoing): Remove decl.
7053 (force_auto_save_soon): Declare only if SIGDANGER.
7054 * xdisp.c (redisplay_window): Simplify code, to make it more
7055 obvious that ignore_mouse_drag_p is not accessed if !defined
7056 USE_GTK && !defined HAVE_NS.
7058 * intervals.c: Make symbols static if they're not exported.
7059 (merge_properties_sticky, merge_interval_right, delete_interval):
7061 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7063 * insdel.c: Make symbols static if they're not exported.
7064 However, leave prepare_to_modify_buffer alone. It's never
7065 called from outside this function, but that appears to be a bug.
7066 (combine_after_change_list, combine_after_change_buffer):
7067 (adjust_after_replace, signal_before_change): Now static.
7068 (adjust_after_replace_noundo): Remove; unused.
7069 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7070 (signal_before_change): Remove decls.
7072 * indent.c (val_compute_motion, val_vmotion): Now static.
7074 * image.c: Make symbols static if they're not exported.
7075 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7077 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7078 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7080 * fringe.c (standard_bitmaps): Now static.
7081 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7083 * frame.c: Make symbols static if they're not exported.
7084 (x_report_frame_params, make_terminal_frame): Now static.
7085 (get_frame_param): Now static, unless HAVE_NS.
7086 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7087 (x_get_resource_string): Remove; not used.
7088 * frame.h (make_terminal_frame, x_report_frame_params):
7089 (x_get_resource_string); Remove decls.
7090 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7091 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7093 * font.c, fontset.c: Make symbols static if they're not exported.
7094 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7095 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7096 * font.c (font_close_object): Now static.
7097 * font.h (font_close_object): Remove.
7098 * fontset.c (FONTSET_OBJLIST): Remove.
7099 (free_realized_fontset) #if-0 the body, which does nothing.
7100 (face_suitable_for_char_p): #if-0, as it's never called.
7101 * fontset.h (face_suitable_for_char_p): Remove decl.
7102 * xfaces.c (face_at_string_position):
7103 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7104 since 0 is always ASCII.
7106 * fns.c (weak_hash_tables): Now static.
7108 * fileio.c: Make symbols static if they're not exported.
7109 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7110 (Vwrite_region_annotation_buffers): Now static.
7112 * eval.c: Make symbols static if they're not exported.
7113 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7114 * lisp.h (backtrace_list): Remove decl.
7116 * emacs.c: Make symbols static if they're not exported.
7117 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7118 (fatal_error_code, fatal_error_signal_hook, standard_args):
7120 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7121 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7122 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7123 * lisp.h (fatal_error_signal_hook): Remove decl.
7124 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7126 * editfns.c: Move a (normally-unused) function to its only use.
7127 * editfns.c, lisp.h (get_operating_system_release): Remove.
7128 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7129 worth the hassle of breaking this out.
7131 * xterm.c: Make symbols static if they're not exported.
7132 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7133 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7134 (x_destroy_window, x_delete_display):
7136 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7137 (x_mouse_leave): Remove; unused.
7138 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7139 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7140 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7142 (x_mouse_leave): Declare only if WINDOWSNT.
7143 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7144 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7147 * ftxfont.c: Make symbols static if they're not exported.
7148 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7150 * font.h (ftxfont_driver): Likewise.
7152 * xfns.c: Make symbols static if they're not exported.
7153 (x_last_font_name, x_display_info_for_name):
7154 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7155 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7156 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7157 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7158 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7159 (last_show_tip_args): Now static.
7160 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7161 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7162 (x_screen_planes): Remove; unused.
7163 * dispextern.h (x_screen_planes): Remove decl.
7165 * dispnew.c: Make symbols static if they're not exported.
7166 * dispextern.h (redraw_garbaged_frames, scrolling):
7167 (increment_row_positions): Remove.
7168 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7169 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7171 (redraw_garbaged_frames): Remove; unused.
7173 * xfaces.c: Make symbols static if they're not exported.
7174 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7176 * xterm.h (defined_color): Remove decls.
7177 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7178 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7179 (menu_face_changed_default, defined_color, free_realized_face):
7180 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7181 (ascii_face_of_lisp_face): Remove; unused.
7183 * xdisp.c: Make symbols static if they're not exported.
7184 * dispextern.h (scratch_glyph_row, window_box_edges):
7185 (glyph_to_pixel_coords, set_cursor_from_row):
7186 (get_next_display_element, set_iterator_to_next):
7187 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7188 (show_mouse_face): Remove decls
7189 * frame.h (message_buf_print): Likewise.
7190 * lisp.h (pop_message, set_message, check_point_in_composition):
7192 * xterm.h (set_vertical_scroll_bar): Likewise.
7193 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7194 (message_buf_print, scratch_glyph_row, displayed_buffer):
7195 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7196 (get_next_display_element, show_mouse_face, window_box_edges):
7197 (frame_to_window_pixel_xy, check_point_in_composition):
7198 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7199 (glyph_to_pixel_coords): Remove; unused.
7201 * dired.c (file_name_completion): Now static.
7203 * dbusbind.c (xd_in_read_queued_messages): Now static.
7205 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7206 * data.c (circular_list_error): Remove.
7208 * commands.h (last_point_position, last_point_position_buffer):
7209 (last_point_position_window): Remove decls.
7210 * keyboard.c: Make these variables static.
7212 * coding.h (coding, code_convert_region, encode_coding_gap):
7214 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7215 (iso_code_class, detect_coding, code_convert_region): Now static.
7216 (encode_coding_gap): Remove; unused.
7218 * chartab.c (chartab_chars, chartab_bits): Now static.
7220 * charset.h (charset_iso_8859_1): Remove decl.
7221 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7224 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7225 * ccl.c (Vccl_program_table): Now static.
7226 (check_ccl_update): Remove; unused.
7228 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7229 * category.h: ... from here.
7230 * category.c (check_category_table, set_category_set): Now static.
7232 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7233 * lisp.h: Remove these decls.
7235 * buffer.c (buffer_count): Remove unused var.
7237 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7238 so that it's not optimized away.
7239 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7240 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7241 exported only to the debugger.
7243 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7244 * atimer.h (run_all_atimers): Remove; not exported.
7246 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7247 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7248 was inaccessible from Lisp.
7249 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7250 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7252 alloc.c: Import and export fewer symbols, and remove unused items.
7253 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7255 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7256 it's not optimized away by whole-program optimization.
7257 (message_enable_multibyte, free_misc): Remove.
7258 (catchlist, handlerlist, mark_backtrace):
7259 Declare only if BYTE_MARK_STACK.
7260 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7261 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7262 (message_enable_multibyte): Remove decl.
7263 (free_misc, interval_free_list, float_block, float_block_index):
7264 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7265 (cons_free_list, last_marked_index):
7267 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7268 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7269 (mark_backtrace): Define only if BYTE_MARK_STACK.
7270 * xdisp.c (message_enable_multibyte): Now static.
7272 Declare Lisp_Object Q* variables to be 'static' if not exported.
7273 This makes it easier for human readers (and static analyzers)
7274 to see whether these variables are used from other modules.
7275 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7276 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7277 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7278 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7279 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7280 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7281 * xmenu.c, xselect.c:
7282 Declare Q* vars static if they are not used in other modules.
7283 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7284 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7285 Remove decls of unexported vars.
7286 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7288 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7290 Make Emacs functions such as Fatom 'static' by default.
7291 This makes it easier for human readers (and static analyzers)
7292 to see whether these functions can be called from other modules.
7293 DEFUN now defines a static function. To make the function external
7294 so that it can be used in other C modules, use the new macro DEFUE.
7295 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7296 (Finit_image_library):
7297 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7298 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7299 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7300 Remove decls, since these functions are now static.
7301 (Funintern, Fget_internal_run_time): New decls, since these functions
7302 were already external.
7304 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7305 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7306 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7307 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7308 * keyboard.c, keymap.c, lread.c:
7309 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7310 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7311 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7312 Mark functions with DEFUE instead of DEFUN,
7313 if they are used in other modules.
7314 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7315 decls for now-static functions.
7316 * buffer.h (Fdelete_overlay): Remove decl.
7317 * callproc.c (Fgetenv_internal): Mark as internal.
7318 * composite.c (Fremove_list_of_text_properties): Remove decl.
7319 (Fcomposition_get_gstring): New forward static decl.
7320 * composite.h (Fcomposite_get_gstring): Remove decl.
7321 * dired.c (Ffile_attributes): New forward static decl.
7322 * doc.c (Fdocumntation_property): New forward static decl.
7323 * eval.c (Ffetch_bytecode): New forward static decl.
7324 (Funintern): Remove extern decl; now in .h file where it belongs.
7325 * fileio.c (Fmake_symbolic_link): New forward static decl.
7326 * image.c (Finit_image_library): New forward static decl.
7327 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7328 * intervals.h (Fprevious_property_change):
7329 (Fremove_list_of_text_properties): Remove decls.
7330 * keyboard.c (Fthis_command_keys): Remove decl.
7331 (Fcommand_execute): New forward static decl.
7332 * keymap.c (Flookup_key): New forward static decl.
7333 (Fcopy_keymap): Now static.
7334 * keymap.h (Flookup_key): Remove decl.
7335 * process.c (Fget_process): New forward static decl.
7336 (Fprocess_datagram_address): Mark as internal.
7337 * syntax.c (Fsyntax_table_p): New forward static decl.
7338 (skip_chars): Remove duplicate decl.
7339 * textprop.c (Fprevious_property_change): New forward static decl.
7340 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7342 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7343 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7345 * editfns.c (Fformat): Remove unreachable code.
7347 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7349 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7352 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7354 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7355 when at ZV. (Bug#8487)
7357 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7359 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7361 * keyboard.c (parse_tool_bar_item): Likewise.
7362 * sound.c (sound_cleanup, alsa_close): Likewise.
7363 * termcap.c (tgetent): Likewise.
7364 * xfns.c (x_default_font_parameter): Likewise.
7365 * xsettings.c (read_and_apply_settings): Likewise.
7367 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7368 (overrun_check_free): Protoize.
7370 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7372 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7373 since callers should never pass a negative size.
7374 Change the signature to match that of plain 'read' and 'write'; see
7375 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7376 * lisp.h: Update prototypes of emacs_write and emacs_read.
7378 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7380 * xdisp.c (redisplay_window): Don't try to determine the character
7381 position of the scroll margin if the window start point w->startp
7382 is outside the buffer's accessible region. (Bug#8468)
7384 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7386 Fix write-region and its subroutines for buffers > 2GB.
7387 * fileio.c (a_write, e_write): Modify declaration of arguments and
7388 local variables to support buffers larger than 2GB.
7389 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7391 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7392 argument, local variables, and return value.
7394 * lisp.h: Update prototypes of emacs_write and emacs_read.
7396 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7398 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7400 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7402 Fix more problems found by GCC 4.6.0's static checks.
7404 * xdisp.c (vmessage): Use a better test for character truncation.
7406 * charset.c (load_charset_map): <, not <=, for optimization,
7407 and to avoid potential problems with integer overflow.
7408 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7409 * casetab.c (set_identity, shuffle): Likewise.
7410 * editfns.c (Fformat): Likewise.
7411 * syntax.c (skip_chars): Likewise.
7413 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7414 This also lets GCC 4.6.0 generate slightly better loop code.
7416 * callint.c (Fcall_interactively): <, not <=, for optimization.
7417 (Fcall_interactively): Count the number of arguments produced,
7418 not the number of arguments given. This is simpler and lets GCC
7419 4.6.0 generate slightly better code.
7421 * ftfont.c: Distingish more carefully between FcChar8 and char.
7422 The previous code passed unsigned char * to a functions like
7423 strlen and xstrcasecmp that expect char *, which does not
7424 conform to the C standard.
7425 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7426 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7427 char * when the C standard requires it.
7429 * keyboard.c (read_char): Remove unused var.
7431 * eval.c: Port to Windows vsnprintf (Bug#8435).
7433 (SIZE_MAX): Define if the headers do not.
7434 (verror): Do not give up if vsnprintf returns a negative count.
7435 Instead, grow the buffer. This ports to Windows vsnprintf, which
7436 does not conform to C99. Problem reported by Eli Zaretskii.
7437 Also, simplify the allocation scheme, by avoiding the need for
7438 calling realloc, and removing the ALLOCATED variable.
7440 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7442 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7443 But keep the doprint source code for now, as we might revamp it
7444 and use it again (Bug#8435).
7445 * lisp.h (doprnt): Remove.
7446 * Makefile.in (base_obj): Remove doprnt.o.
7447 * deps.mk (doprnt.o): Remove.
7449 error: Print 32- and 64-bit integers portably (Bug#8435).
7450 Without this change, on typical 64-bit hosts error ("...%d...", N)
7451 was used to print both 32- and 64-bit integers N, which relied on
7453 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7455 * lisp.h (error, verror): Mark as printf-like functions.
7456 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7457 Report overflow in size calculations when allocating printf buffer.
7458 Do not truncate output string at its first null byte.
7459 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7460 Truncate the output at a character boundary, since vsnprintf does not
7462 * charset.c (check_iso_charset_parameter): Convert internal
7463 character to string before calling 'error', since %c now has the
7465 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7466 overflow when computing char to be passed to 'error'. Do not
7467 pass Lisp_Object to 'error'; pass the integer instead.
7468 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7469 formatted with plain %d.
7471 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7473 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7475 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7477 * xterm.c (x_catch_errors): Remove duplicate declaration.
7479 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7481 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7483 2011-04-10 Jim Meyering <meyering@redhat.com>
7485 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7486 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7487 return ssize_t not "int", and use size_t as the buffer length.
7488 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7489 * gnutls.h: Update declarations.
7490 * process.c (read_process_output): Use ssize_t, to match.
7491 (send_process): Likewise.
7493 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7495 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7497 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7499 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7500 Use unsigned char, to match FcChar8 type definition.
7502 * xterm.c (handle_one_xevent):
7503 * xmenu.c (create_and_show_popup_menu):
7504 * xselect.c (x_decline_selection_request)
7505 (x_reply_selection_request): Avoid type-punned deref of X events.
7507 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7509 Fix some uses of `int' instead of EMACS_INT.
7510 * search.c (string_match_1, fast_string_match)
7511 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7512 (scan_buffer, find_next_newline_no_quit)
7513 (find_before_next_newline, search_command, Freplace_match)
7514 (Fmatch_data): Make some `int' variables be EMACS_INT.
7516 * xdisp.c (display_count_lines): 3rd argument and return value now
7517 EMACS_INT. All callers changed.
7518 (pint2hrstr): Last argument is now EMACS_INT.
7520 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7521 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7522 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7523 (decode_coding_utf_16, decode_coding_emacs_mule)
7524 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7525 (decode_coding_ccl, decode_coding_charset)
7526 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7527 (decode_coding_iso_2022, decode_coding_emacs_mule)
7528 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7529 <char_offset, last_offset>: Declare EMACS_INT.
7530 (encode_coding_utf_8, encode_coding_utf_16)
7531 (encode_coding_emacs_mule, encode_invocation_designation)
7532 (encode_designation_at_bol, encode_coding_iso_2022)
7533 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7534 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7536 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7537 (encode_invocation_designation): Last argument P_NCHARS is now
7539 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7540 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7542 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7545 * ccl.c (Fccl_execute_on_string): Declare some variables
7548 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7550 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7552 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7554 * process.c (Fformat_network_address): Doc fix.
7556 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7558 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7560 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7562 * keyboard.c (read_char): Call Lisp function help-form-show,
7563 instead of using internal_with_output_to_temp_buffer.
7564 (Qhelp_form_show): New var.
7565 (syms_of_keyboard): Use DEFSYM macro.
7567 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7569 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7571 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7573 * process.c (Flist_processes): Remove to Lisp.
7574 (list_processes_1): Delete.
7576 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7578 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7580 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7582 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7584 Fix more problems found by GCC 4.6.0's static checks.
7586 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7588 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7590 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7592 * xdisp.c (vmessage): Mark as a printf-like function.
7594 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7596 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7598 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7599 printf-like functions.
7600 (tiff_load): Add casts to remove these marks before passing them
7601 to system-supplied API.
7603 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7605 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7606 This avoids several warnings with gcc -Wstrict-overflow.
7607 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7608 directly, rather than having caller test rule sign. This avoids
7609 some unnecessary tests.
7610 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7611 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7612 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7614 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7615 (xfont_open): Avoid unnecessary tests.
7617 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7619 * composite.h, composite.c (composition_gstring_put_cache):
7620 Use EMACS_INT, not int, for length.
7622 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7623 breaking out part of COMPOSITION_DECODE_RULE.
7624 (COMPOSITION_DECODE_RULE): Use it.
7625 * composite.c (get_composition_id): Remove unused local vars,
7626 by using the new macro.
7628 * textprop.c (set_text_properties_1): Change while to do-while,
7629 since the condition is always true at first.
7631 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7632 (interval_deletion_adjustment): Return unsigned value.
7635 * process.c (list_processes_1, create_pty, read_process_output):
7636 (exec_sentinel): Remove vars that were set but not used.
7637 (create_pty): Remove unnecessary "volatile"s.
7638 (Fnetwork_interface_info): Avoid possibility of int overflow.
7639 (read_process_output): Do adaptive read buffering even if carryover.
7640 (read_process_output): Simplify nbytes computation if buffered.
7642 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7644 * syntax.c (scan_words): Remove var that was set but not used.
7645 (update_syntax_table): Use unsigned instead of int.
7647 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7648 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7649 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7651 * print.c (print_error_message): Avoid int overflow.
7653 * font.c (font_list_entities): Redo for clarity,
7654 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7656 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7657 (font_score): Avoid potential overflow in diff calculation.
7659 * fns.c (substring_both): Remove var that is set but not used.
7660 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7662 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7664 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7665 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7666 can always succeed if overflow has undefined behavior.
7668 * search.c (boyer_moore, wordify): Remove vars set but not used.
7669 (wordify): Omit three unnecessary tests.
7671 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7672 All callers changed. This avoids the need for an unused var.
7674 * casefiddle.c (casify_region): Remove var that is set but not used.
7676 * dired.c (file_name_completion): Remove var that is set but not used.
7678 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7680 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7681 (Finsert_file_contents): Remove unnecessary code checking fd.
7683 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7684 Check for integer overflow on size calculations.
7686 * buffer.c (Fprevious_overlay_change): Remove var that is set
7689 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7690 Remove vars that are set but not used.
7691 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7692 (timer_check_2): Mark vars as initialized.
7694 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7696 * image.c (lookup_image): Remove var that is set but not used.
7697 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7699 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7700 that are set but not used.
7702 * xfns.c (make_invisible_cursor): Don't return garbage
7703 if XCreateBitmapFromData fails (Bug#8410).
7705 * xselect.c (x_get_local_selection, x_handle_property_notify):
7706 Remove vars that are set but not used.
7708 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7709 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7711 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7712 Remove var that is set but not used.
7713 (scroll_bar_windows_size): Now size_t, not int.
7714 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7717 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7718 (map_tty_color) [!defined MSDOS]: Likewise.
7720 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7722 * coding.c: Remove vars that are set but not used.
7723 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7724 All callers changed.
7725 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7726 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7727 (decode_coding_charset): Remove vars that are set but not used.
7729 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7730 that is set but not used.
7732 * print.c (print_object): Remove var that is set but not used.
7734 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7735 The gnulib version avoids calling malloc in the usual case,
7736 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7737 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7738 * filelock.c (current_lock_owner): Likewise.
7739 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7740 * sysdep.c: Include allocator.h, careadlinkat.h.
7741 (emacs_no_realloc_allocator): New static constant.
7742 (emacs_readlink): New function.
7743 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7744 ../lib/careadlinkat.h.
7746 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7748 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7749 first non-nil return value).
7751 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7753 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7754 if not defined (Bug#8403).
7756 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7758 * xdisp.c (display_count_lines): Remove parameter `start',
7759 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7760 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7761 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7762 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7763 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7764 and thereabouts. All callers changed.
7765 (get_per_char_metric): Remove parameter `f', unused since
7766 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7768 2011-04-02 Jim Meyering <meyering@redhat.com>
7770 do not dereference NULL upon failed strdup
7771 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7772 (ns_get_family): Likewise.
7774 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7776 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7778 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7780 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7783 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7785 Add lexical binding.
7787 * window.c (Ftemp_output_buffer_show): New fun.
7788 (Fsave_window_excursion):
7789 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7791 * lread.c (lisp_file_lexically_bound_p): New function.
7792 (Fload): Bind Qlexical_binding.
7793 (readevalloop): Remove `evalfun' arg.
7794 Bind Qinternal_interpreter_environment.
7795 (Feval_buffer): Bind Qlexical_binding.
7796 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7798 (syms_of_lread): Declare `lexical-binding'.
7800 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7802 * keyboard.c (eval_dyn): New fun.
7803 (menu_item_eval_property): Use it.
7805 * image.c (parse_image_spec): Use Ffunctionp.
7807 * fns.c (concat, mapcar1): Accept byte-code-functions.
7809 * eval.c (Fsetq): Handle lexical vars.
7810 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7811 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7812 (FletX, Flet): Obey lexical binding.
7813 (Fcommandp): Handle closures.
7814 (Feval): New `lexical' arg.
7815 (eval_sub): New function extracted from Feval. Use it almost
7816 everywhere where Feval was used. Look up vars in lexical env.
7818 (Ffunctionp): Move from subr.el.
7819 (Ffuncall): Handle closures.
7820 (apply_lambda): Remove `eval_flags'.
7821 (funcall_lambda): Handle closures and new byte-code-functions.
7822 (Fspecial_variable_p): New function.
7823 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7824 but without exporting it to Lisp.
7826 * doc.c (Fdocumentation, store_function_docstring):
7827 * data.c (Finteractive_form): Handle closures.
7829 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7832 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7834 (exec_byte_code): New function extracted from Fbyte_code to handle new
7835 calling convention for byte-code-functions. Add new byte-codes.
7837 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7839 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7841 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7843 * xdisp.c (redisplay_internal): Fix prototype.
7845 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7847 * xdisp.c (SCROLL_LIMIT): New macro.
7848 (try_scrolling): Use it when setting scroll_limit.
7849 Limit scrolling to 100 screen lines.
7850 (redisplay_window): Even when falling back on "recentering",
7851 position point in the window according to scroll-conservatively,
7852 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7854 (try_scrolling): When point is above the window, allow searching
7855 as far as scroll_max, or one screenful, to compute vertical
7856 distance from PT to the scroll margin position. This prevents
7857 try_scrolling from unnecessarily failing when
7858 scroll-conservatively is set to a value slightly larger than the
7859 window height. Clean up the case of PT below the margin at bottom
7860 of window: scroll_max can no longer be INT_MAX. When aggressive
7861 scrolling is in use, don't let point enter the opposite scroll
7862 margin as result of the scroll.
7863 (syms_of_xdisp) <scroll-conservatively>: Document the
7864 threshold of 100 lines for never-recentering scrolling.
7866 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7868 * dispextern.h (move_it_by_lines):
7869 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7870 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7871 (message_log_check_duplicate): Remove parameters `prev_bol' and
7872 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7873 (redisplay_internal): Remove parameter `preserve_echo_area',
7874 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7876 * indent.c (Fvertical_motion):
7877 * window.c (window_scroll_pixel_based, Frecenter):
7878 Don't pass `need_y_p' to `move_it_by_lines'.
7880 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7882 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7883 steal a few bits to be more compact.
7884 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7885 Remove unneeded casts.
7887 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7889 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7891 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7892 binding" message (bug#7967).
7894 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7896 Fix more problems found by GCC 4.6.0's static checks.
7898 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7899 Remove unused local var.
7901 * editfns.c (Fmessage_box): Remove unused local var.
7903 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7904 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7905 Omit unused local vars.
7906 * window.c (shrink_windows): Omit unused local var.
7907 * menu.c (digest_single_submenu): Omit unused local var.
7908 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7909 Omit unused local var.
7911 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7912 Don't assume string length fits in int.
7913 (keyremap_step, read_key_sequence): Use size_t for sizes.
7914 (read_key_sequence): Don't check last_real_key_start redundantly.
7916 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7917 instead of alloca (Bug#8344).
7919 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7920 (Fbacktrace_frame): Don't assume nframes fits in int.
7922 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7924 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7927 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7929 * cm.c (calccost): Turn while-do into do-while, for clarity.
7931 * keyboard.c (syms_of_keyboard): Use the same style as later
7932 in this function when indexing through an array. This also
7933 works around GCC bug 48267.
7935 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7937 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7939 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7940 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7942 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7943 This avoids undefined behavior on integer overflow, and is a bit
7944 more convenient anyway since it is compared to a size_t variable.
7946 Variadic C functions now count arguments with size_t, not int.
7947 This avoids an unnecessary limitation on 64-bit machines, which
7948 caused (substring ...) to crash on large vectors (Bug#8344).
7949 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7950 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7951 All variadic functions and their callers changed accordingly.
7952 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7953 * data.c (arith_driver, float_arith_driver): Likewise.
7954 * editfns.c (general_insert_function): Likewise.
7955 * eval.c (struct backtrace.nargs, interactive_p)
7956 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7957 (funcall_lambda, mark_backtrace): Likewise.
7958 * fns.c (concat): Likewise.
7959 * frame.c (x_set_frame_parameters): Likewise.
7960 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7961 0 if not found, not -1. All callers changed.
7963 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7964 (stack_copy_size): Now size_t, not int.
7965 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7967 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7969 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7970 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7971 All callers changed.
7973 * lisp.h (multibyte_char_to_unibyte):
7974 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7975 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7976 * character.h (CHAR_TO_BYTE8):
7977 * cmds.c (internal_self_insert):
7978 * editfns.c (general_insert_function):
7979 * keymap.c (push_key_description):
7980 * search.c (Freplace_match):
7981 * xdisp.c (message_dolog, set_message_1): All callers changed.
7983 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7985 * keyboard.c (safe_run_hook_funcall): New function.
7986 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7987 don't set the hook to nil, but remove the offending function instead.
7988 (Qcommand_hook_internal): Remove, unused.
7989 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7990 Vcommand_hook_internal.
7992 * eval.c (enum run_hooks_condition): Remove.
7993 (funcall_nil, funcall_not): New functions.
7994 (run_hook_with_args): Call each function through a `funcall' argument.
7995 Remove `cond' argument, now redundant.
7996 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7997 (Frun_hook_with_args_until_failure): Adjust accordingly.
7998 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8000 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8002 * dispextern.h (string_buffer_position): Remove declaration.
8004 * print.c (strout): Remove parameter `multibyte', unused since
8005 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8007 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8008 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8009 All callers changed.
8011 * w32.c (_wsa_errlist): Use braces for struct initializers.
8013 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8014 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8015 All callers changed.
8016 (string_buffer_position): Likewise. Also, make static (it's never
8017 used outside xdisp.c).
8018 (cursor_row_p): Remove parameter `w', unused since
8019 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8020 (decode_mode_spec): Remove parameter `precision', introduced during
8021 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8022 All callers changed.
8024 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8026 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8028 2011-03-27 Anders Lindgren <andlind@gmail.com>
8030 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8031 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8032 (ns_update_auto_hide_menu_bar): New functions.
8033 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8034 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8035 ns_constrain_all_frames.
8036 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8037 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8039 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8041 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8043 2011-03-27 Glenn Morris <rgm@gnu.org>
8045 * syssignal.h: Replace RETSIGTYPE with void.
8046 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8047 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8048 Replace SIGTYPE with void everywhere.
8049 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8050 * s/template.h (SIGTYPE): Remove commented out definition.
8052 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8054 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8055 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8057 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8059 * w32.c (read_unc_volume): Use parameter `henum', instead of
8060 global variable `wget_enum_handle'.
8062 * keymap.c (describe_vector): Remove parameters `indices' and
8063 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8064 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8066 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8068 * keyboard.c (timer_check): Remove parameter `do_it_now',
8069 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8070 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8071 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8073 * keyboard.c (read_char):
8074 * w32menu.c (w32_menu_display_help):
8075 * xmenu.c (show_help_event, menu_help_callback):
8076 Adjust calls to `show_help_echo'.
8078 * gtkutil.c (xg_maybe_add_timer):
8079 * keyboard.c (readable_events):
8080 * process.c (wait_reading_process_output):
8081 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8083 * insdel.c (adjust_markers_gap_motion):
8084 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8085 (gap_left, gap_right): Don't call it.
8087 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8089 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8090 incurred during fontification.
8092 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8094 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8095 (DEFVAR_PER_BUFFER): Don't pass it.
8097 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8098 (scrolling_window): Don't pass it.
8100 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8102 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8104 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8106 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8107 of variables specific to SELinux and computation of `encoded_absname'.
8109 * image.c (XPutPixel): Remove unused variable `height'.
8111 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8113 * unexw32.c (get_section_info): Remove unused variable `section'.
8115 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8116 (system_process_attributes): Remove unused variable `sess'.
8117 (sys_read): Remove unused variable `err'.
8119 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8120 (w32_wnd_proc): Remove unused variable `isdead'.
8121 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8122 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8123 (x_create_tip_frame): Remove unused variable `tem'.
8125 * w32inevt.c (w32_console_read_socket):
8126 Remove unused variable `no_events'.
8128 * w32term.c (x_draw_composite_glyph_string_foreground):
8129 Remove unused variable `width'.
8131 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8133 * w32term.c (x_set_glyph_string_clipping):
8134 Don't pass uninitialized region to CombineRgn.
8136 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8138 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8139 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8140 (Fx_close_connection): Remove unused variable `i'.
8142 * w32font.c (w32font_draw): Return number of glyphs.
8143 (w32font_open_internal): Remove unused variable `i'.
8144 (w32font_driver): Add missing initializer.
8146 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8147 (fill_in_menu): Remove unused variable `items_added'.
8149 * w32term.c (last_mouse_press_frame): Remove static global variable.
8150 (w32_clip_to_row): Remove unused variable `f'.
8151 (x_delete_terminal): Remove unused variable `i'.
8153 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8154 (NOTHING): Remove unused static global variable.
8155 (uniscribe_check_otf): Remove unused variable `table'.
8156 (uniscribe_font_driver): Add missing initializers.
8158 2011-03-23 Julien Danjou <julien@danjou.info>
8160 * term.c (Fsuspend_tty, Fresume_tty):
8161 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8162 * window.c (temp_output_buffer_show):
8163 * insdel.c (signal_before_change):
8164 * frame.c (Fhandle_switch_frame):
8165 * fileio.c (Fdo_auto_save):
8166 * emacs.c (Fkill_emacs):
8167 * editfns.c (save_excursion_restore):
8168 * cmds.c (internal_self_insert):
8169 * callint.c (Fcall_interactively):
8170 * buffer.c (Fkill_all_local_variables):
8171 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8173 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8174 unconditionally since it does the check itself.
8176 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8178 Fix more problems found by GCC 4.5.2's static checks.
8180 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8181 the first time through the loop, since we know p0 < p1 then.
8182 This also avoids a gcc -Wstrict-overflow warning.
8184 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8185 leading to a memory leak, possible in functions like
8186 load_charset_map_from_file that can allocate an unbounded number
8187 of objects (Bug#8318).
8189 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8190 that could (at least in theory) be that large.
8192 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8193 This is less likely to overflow, and avoids undefined behavior if
8194 overflow does occur. All callers changed. Use strtoul to scan
8195 for the unsigned long integer.
8196 (pint2hrstr): Simplify and tune code slightly.
8197 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8199 * scroll.c (do_scrolling): Work around GCC bug 48228.
8200 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8202 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8203 This also avoids a warning with gcc -Wstrict-overflow.
8204 (validate_x_resource_name): Simplify count usage.
8205 This also avoids a warning with gcc -Wstrict-overflow.
8207 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8210 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8212 * process.c (Fmake_network_process): Use socklen_t, not int,
8213 where POSIX says socklen_t is required in portable programs.
8214 This fixes a porting bug on hosts like 64-bit HP-UX, where
8215 socklen_t is wider than int (Bug#8277).
8216 (Fmake_network_process, server_accept_connection):
8217 (wait_reading_process_output, read_process_output):
8220 * process.c: Rename or move locals to avoid shadowing.
8221 (list_processes_1, Fmake_network_process):
8222 (read_process_output_error_handler, exec_sentinel_error_handler):
8223 Rename or move locals.
8224 (Fmake_network_process): Define label "retry_connect" only if needed.
8225 (Fnetwork_interface_info): Fix pointer signedness.
8226 (process_send_signal): Add cast to avoid pointer signedness problem.
8227 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8228 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8230 Make tparam.h and terminfo.c consistent.
8231 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8232 Include tparam.h instead, since it declares them.
8233 * cm.h (PC): Remove extern decl; tparam.h now does this.
8234 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8235 * terminfo.c: Include tparam.h, to check interfaces.
8236 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8237 (tparam): Adjust signature to match interface in tparam.h;
8238 this removes some undefined behavior. Check that outstring and len
8239 are zero, which they always are with Emacs.
8240 * tparam.h (PC, BC, UP): New extern decls.
8242 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8243 (xftfont_open): Rename locals to avoid shadowing.
8245 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8246 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8247 (OTF_TAG_SYM): Omit macro if not needed.
8248 (ftfont_list): Remove unused local.
8249 (get_adstyle_property, ftfont_pattern_entity):
8250 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8251 Rename locals to avoid shadowing.
8253 * xfont.c (xfont_list_family): Mark var as initialized.
8255 * xml.c (make_dom): Now static.
8257 * composite.c (composition_compute_stop_pos): Rename local to
8259 (composition_reseat_it): Remove unused locals.
8260 (find_automatic_composition, composition_adjust_point): Likewise.
8261 (composition_update_it): Mark var as initialized.
8262 (find_automatic_composition): Mark vars as initialized,
8263 with a FIXME (Bug#8290).
8265 character.h: Rename locals to avoid shadowing.
8266 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8267 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8268 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8269 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8272 * textprop.c (property_change_between_p): Remove; unused.
8274 * intervals.c (interval_start_pos): Now static.
8276 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8278 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8279 Rename locals to avoid shadowing.
8281 * sound.c (wav_play, au_play, Fplay_sound_internal):
8282 Fix pointer signedness.
8283 (alsa_choose_format): Remove unused local var.
8284 (wav_play): Initialize a variable to 0, to prevent undefined
8285 behavior (Bug#8278).
8287 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8289 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8291 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8292 clobbering (Bug#8298).
8293 * sysdep.c (sys_subshell): Likewise.
8294 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8296 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8297 This should get cleaned up, so that child_setup has the
8298 same signature on all platforms.
8300 * callproc.c (call_process_cleanup): Now static.
8301 (relocate_fd): Rename locals to avoid shadowing.
8303 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8305 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8306 not to be necessary, and produces flickering.
8308 2011-03-20 Glenn Morris <rgm@gnu.org>
8310 * config.in: Remove file.
8312 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8314 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8315 are now in src/globals.h.
8316 (syms_of_minibuf): Remove spurious & from previous change.
8318 2011-03-20 Leo Liu <sdl.web@gmail.com>
8320 * minibuf.c (completing-read-function): New variable.
8321 (completing-read-default): Rename from completing-read.
8322 (completing-read): Call completing-read-function.
8324 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8326 * xfaces.c (Fx_load_color_file):
8327 Read color file from absolute filename (bug#8250).
8329 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8331 * makefile.w32-in: Update dependencies.
8333 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8335 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8337 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8339 Fix more problems found by GCC 4.5.2's static checks.
8341 * process.c (make_serial_process_unwind, send_process_trap):
8342 (sigchld_handler): Now static.
8344 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8345 That way, the code declares only the vars that it needs.
8346 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8347 * s/cygwin.h (PTY_ITERATION): Likewise.
8348 * s/darwin.h (PTY_ITERATION): Likewise.
8349 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8351 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8352 * process.c (allocate_pty): Don't declare stb unless it's needed.
8354 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8355 (CONSTANTLIM): Remove; unused.
8356 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8357 Define only if needed.
8359 * unexelf.c (unexec): Name an expression,
8360 to avoid gcc -Wbad-function-cast warning.
8361 Use a different way to cause a compilation error if anyone uses
8362 n rather than nn, a way that does not involve shadowing.
8363 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8365 * deps.mk (unexalpha.o): Remove; unused.
8367 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8368 * unexec.h: New file.
8369 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8370 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8372 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8373 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8374 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8375 Change as necessary to match prototype in unexec.h.
8377 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8379 (back_comment, skip_chars): Mark vars as initialized.
8381 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8382 Rename locals to avoid shadowing.
8384 * lread.c (read1): Rewrite so as not to use empty "else".
8385 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8387 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8389 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8390 warning when compiling print.c.
8392 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8393 instead of using an uninitialized var.
8394 (font_sort_entities): Mark var as initialized.
8396 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8398 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8399 pointers to constants.
8400 (font_parse_fcname): Remove unused vars.
8401 (font_delete_unmatched): Now static.
8402 (font_get_spec): Remove; unused.
8403 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8404 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8405 Rename or move locals to avoid shadowing.
8407 * fns.c (require_nesting_list, require_unwind): Now static.
8408 (Ffillarray): Rename locals to avoid shadowing.
8410 * floatfns.c (domain_error2): Define only if needed.
8411 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8413 * alloc.c (mark_backtrace): Move decl from here ...
8414 * lisp.h: ... to here, so that it can be checked.
8416 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8417 (Fdefvar): Rewrite so as not to use empty "else".
8418 (lisp_indirect_variable): Name an expression,
8419 to avoid gcc -Wbad-function-cast warning.
8420 (Fdefvar): Rename locals to avoid shadowing.
8422 * callint.c (quotify_arg, quotify_args): Now static.
8423 (Fcall_interactively): Rename locals to avoid shadowing.
8424 Use const pointer when appropriate.
8426 * lisp.h (get_system_name, get_operating_system_release):
8427 Move decls here, to check interfaces.
8428 * process.c (get_operating_system_release): Move decl to lisp.h.
8429 * xrdb.c (get_system_name): Likewise.
8430 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8431 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8432 some of which prompt warnings from gcc -Wbad-function-cast.
8433 (Fformat_time_string, Fencode_time, Finsert_char):
8434 (Ftranslate_region_internal, Fformat):
8435 Rename or remove local vars to avoid shadowing.
8436 (Ftranslate_region_internal): Mark var as initialized.
8438 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8441 * lisp.h (eassert): Check that the argument compiles, even if
8442 ENABLE_CHECKING is not defined.
8444 * data.c (Findirect_variable): Name an expression, to avoid
8445 gcc -Wbad-function-cast warning.
8446 (default_value, arithcompare, arith_driver, arith_error): Now static.
8447 (store_symval_forwarding): Rename local to avoid shadowing.
8448 (Fmake_variable_buffer_local, Fmake_local_variable):
8449 Mark variables as initialized.
8450 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8452 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8453 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8454 Rename locals to avoid shadowing.
8455 (mark_stack): Move local variables into the #ifdef region where
8457 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8458 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8460 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8461 (GC_STRING_CHARS): Remove; not used.
8462 (Fmemory_limit): Cast sbrk's returned value to char *.
8464 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8465 avoids undefined behavior in theory.
8467 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8469 Use functions, not macros, for up- and down-casing (Bug#8254).
8470 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8471 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8472 to use the following functions instead of these macros.
8473 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8474 EMACS_INT, since callers assume the returned value fits in int.
8475 (upcase1): Likewise, for UPCASE_TABLE.
8476 (uppercasep, lowercasep, upcase): New static inline functions.
8477 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8478 the race-condition problem in the old DOWNCASE.
8480 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8481 Rename locals to avoid shadowing.
8482 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8483 (regex_compile, re_search_2, re_match_2_internal):
8484 Remove unused local vars.
8485 (FREE_VAR): Rewrite so as not to use empty "else",
8486 which gcc can warn about.
8487 (regex_compile, re_match_2_internal): Mark locals as initialized.
8488 (RETALLOC_IF): Define only if needed.
8489 (WORDCHAR_P): Likewise. This one is never needed, but is used
8490 only in a comment talking about a compiler bug, so put inside
8491 the #if 0 of that comment.
8492 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8493 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8496 * search.c (boyer_moore): Rename locals to avoid shadowing.
8497 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8498 (PREV_CHAR_BOUNDARY): Likewise.
8500 * search.c (simple_search): Remove unused var.
8502 * dired.c (compile_pattern): Move decl from here ...
8503 * lisp.h: ... to here, so that it can be checked.
8504 (struct re_registers): New forward decl.
8506 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8508 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8510 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8511 Rename locals to avoid shadowing.
8512 (Fvertical_motion): Mark locals as initialized.
8514 * casefiddle.c (casify_object, casify_region): Now static.
8515 (casify_region): Mark local as initialized.
8517 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8519 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8520 New macros, so that the caller can use some names other than
8521 gcpro1, gcpro2, etc.
8522 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8524 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8525 argument, for consistency with GCPRO2_VAR, etc: it is now the
8526 prefix of the variable, not the variable itself. All uses
8528 * dired.c (directory_files_internal, file_name_completion):
8529 Rename locals to avoid shadowing.
8531 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8532 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8533 dired.c's scmp function, had undefined behavior.
8534 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8535 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8536 * buffer.h: ... to here, because these macros use current_buffer,
8537 and the new implementation with inline functions needs to have
8538 current_buffer in scope now, rather than later when the macros
8540 (downcase, upcase1): New static inline functions.
8541 (DOWNCASE, UPCASE1): Reimplement using these functions.
8542 This avoids undefined behavior in expressions like
8543 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8544 from race conditions in accessing the global variables
8545 case_temp1 and case_temp2.
8546 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8547 * lisp.h (case_temp1, case_temp2): Remove their decls.
8548 * character.h (ASCII_CHAR_P): Move from here ...
8549 * lisp.h: ... to here, so that the inline functions mentioned
8552 * dired.c (directory_files_internal_unwind): Now static.
8554 * fileio.c (file_name_as_directory, directory_file_name):
8555 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8557 (file_name_as_directory): Use const pointers when appropriate.
8558 (Fexpand_file_name): Likewise. In particular, newdir might
8559 point at constant storage, so make it a const pointer.
8560 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8561 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8563 (Fset_file_times, Finsert_file_contents, auto_save_error):
8564 Rename locals to avoid shadowing.
8566 * minibuf.c (choose_minibuf_frame_1): Now static.
8567 (Ftry_completion, Fall_completions): Rename or remove locals
8570 * marker.c (bytepos_to_charpos): Remove; unused.
8572 * lisp.h (verify_bytepos, count_markers): New decls,
8573 so that gcc does not warn that these functions aren't declared.
8575 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8576 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8577 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8578 (copy_text): Remove unused local var.
8580 * filelock.c (within_one_second): Now static.
8581 (lock_file_1): Rename local to avoid shadowing.
8583 * buffer.c (fix_overlays_before): Mark locals as initialized.
8584 (fix_start_end_in_overlays): Likewise. This function should be
8585 simplified by using pointers-to-pointers, but that's a different
8587 (switch_to_buffer_1): Now static.
8588 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8589 (report_overlay_modification): Rename locals to avoid shadowing.
8591 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8592 Fix pointer signedness issue.
8593 (sys_subshell): Mark local as volatile if checking for lint,
8594 to suppress a gcc -Wclobbered warning that does not seem to be right.
8595 (MAXPATHLEN): Define only if needed.
8597 * process.c (serial_open, serial_configure): Move decls from here ...
8598 * systty.h: ... to here, so that they can be checked.
8600 * fns.c (get_random, seed_random): Move extern decls from here ...
8601 * lisp.h: ... to here, so that they can be checked.
8603 * sysdep.c (reset_io): Now static.
8604 (wait_for_termination_signal): Remove; unused.
8606 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8607 (copy_keymap_item, append_key, push_text_char_description):
8609 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8610 (DENSE_TABLE_SIZE): Remove; unused.
8611 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8612 (describe_map_tree):
8613 Rename locals to avoid shadowing.
8615 * keyboard.c: Declare functions static if they are not used elsewhere.
8616 (echo_char, echo_dash, cmd_error, top_level_2):
8617 (poll_for_input, handle_async_input): Now static.
8618 (read_char, kbd_buffer_get_event, make_lispy_position):
8619 (make_lispy_event, make_lispy_movement, apply_modifiers):
8620 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8621 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8622 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8623 (read_key_sequence, read_char): Mark locals as initialized.
8624 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8626 * keyboard.h (make_ctrl_char): New decl.
8627 (mark_kboards): Move decl here ...
8628 * alloc.c (mark_kboards): ... from here.
8630 * lisp.h (force_auto_save_soon): New decl.
8632 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8633 (DEFINE_DUMMY_FUNCTION): New macro.
8634 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8636 (main): Add casts to avoid warnings
8637 if GCC considers string literals to be constants.
8639 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8641 * dbusbind.c: Pointer signedness fixes.
8642 (xd_signature, xd_append_arg, xd_initialize):
8643 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8644 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8645 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8646 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8648 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8649 if GCC considers string literals to be constants.
8650 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8652 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8654 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8655 (print_preprocess, print_object): New macro to fix last change.
8657 * print.c (print_preprocess): Don't forget font objects.
8659 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8661 * emacs.c (USAGE3): Doc fixes.
8663 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8665 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8668 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8670 * lisp.h (VWindow_system, Qfile_name_history):
8671 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8672 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8673 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8675 * w32select.c: Don't #include "keyboard.h".
8676 (run_protected): Add extern declaration for waiting_for_input.
8678 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8679 * w32console.c (detect_input_pending, read_input_pending)
8680 (encode_terminal_code):
8681 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8682 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8683 (w32_system_caret_y, Qfile_name_history):
8684 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8685 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8686 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8687 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8688 * w32proc.c (Qlocal, report_file_error):
8689 * w32term.c (Vwindow_system, updating_frame):
8690 * w32uniscribe.c (initialized, uniscribe_font_driver):
8691 Remove unneeded extern declarations.
8693 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8695 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8697 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8699 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8700 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8701 These macros can no longer be used for assignment.
8703 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8704 Assign struct members directly, instead of using BUF_BEGV etc.
8705 (record_buffer_markers, fetch_buffer_markers): New functions for
8706 recording and fetching special buffer markers.
8707 (set_buffer_internal_1, set_buffer_temp): Use them.
8709 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8711 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8713 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8714 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8716 * xdisp.c (hscroll_window_tree):
8717 (reconsider_clip_changes): Use PT instead of BUF_PT.
8719 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8721 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8722 $(EMACS_ROOT)/lib/intprops.h.
8724 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8726 Fix more problems found by GCC 4.5.2's static checks.
8728 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8729 to unsigned char * to avoid compiler diagnostic.
8730 (xg_free_frame_widgets): Make it clear that a local variable is
8731 needed only if USE_GTK_TOOLTIP.
8732 (gdk_window_get_screen): Make it clear that this macro is needed
8733 only if USE_GTK_TOOLTIP.
8734 (int_gtk_range_get_value): New function, which avoids a diagnostic
8735 from gcc -Wbad-function-cast.
8736 (xg_set_toolkit_scroll_bar_thumb): Use it.
8737 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8738 diagnostic from gcc -Wbad-function-cast.
8739 (get_utf8_string, xg_get_file_with_chooser):
8740 Rename locals to avoid shadowing.
8741 (create_dialog): Move locals to avoid shadowing.
8743 * xgselect.c (xg_select): Remove unused var.
8745 * image.c (four_corners_best): Mark locals as initialized.
8746 (gif_load): Initialize transparent_p to zero (Bug#8238).
8747 Mark another local as initialized.
8748 (my_png_error, my_error_exit): Mark with NO_RETURN.
8750 * image.c (clear_image_cache): Now static.
8751 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8752 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8753 (x_edge_detection): Remove unnecessary cast that
8754 gcc -Wbad-function-cast diagnoses.
8755 (gif_load): Fix pointer signedness.
8756 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8757 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8759 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8761 Improve quality of tests for time stamp overflow.
8762 For example, without this patch (encode-time 0 0 0 1 1
8763 1152921504606846976) returns the obviously-bogus value (-948597
8764 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8765 reports time overflow. See
8766 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8767 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8768 * editfns.c: Include limits.h and intprops.h.
8769 (TIME_T_MIN, TIME_T_MAX): New macros.
8770 (time_overflow): Move earlier, to before first use.
8771 (hi_time, lo_time): New functions, for an accurate test for
8773 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8774 (Fget_internal_run_time): Don't assume time_t fits in int.
8775 (make_time): Use list2 instead of Fcons twice.
8776 (Fdecode_time): More accurate test for out-of-range times.
8777 (check_tm_member): New function.
8778 (Fencode_time): Use it, to test for out-of-range times.
8779 (lisp_time_argument): Don't rely on undefined left-shift and
8780 right-shift behavior when checking for time stamp overflow.
8782 * editfns.c (time_overflow): New function, refactoring common code.
8783 (Fformat_time_string, Fdecode_time, Fencode_time):
8784 (Fcurrent_time_string): Use it.
8786 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8787 * dired.c (make_time): Move to ...
8788 * editfns.c (make_time): ... here.
8789 * systime.h: Note the move.
8791 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8793 * fringe.c (update_window_fringes): Remove unused variables.
8795 * unexmacosx.c (copy_data_segment): Also copy __got section.
8798 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8800 * termcap.c [MSDOS]: Include "msdos.h".
8801 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8802 Constify `char *' arguments and their references according to
8803 prototypes in tparam.h.
8805 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8807 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8808 Adapt all references accordingly.
8810 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8812 2011-03-11 Tom Tromey <tromey@redhat.com>
8814 * buffer.c (syms_of_buffer): Remove obsolete comment.
8816 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8818 * termhooks.h (encode_terminal_code): Declare prototype.
8820 * msdos.c (encode_terminal_code): Don't declare prototype.
8822 * term.c (encode_terminal_code): Now external again, used by
8823 w32console.c and msdos.c.
8825 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8826 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8828 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8830 Fix some minor problems found by GCC 4.5.2's static checks.
8832 * fringe.c (update_window_fringes): Mark locals as initialized
8834 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8836 * alloc.c (mark_fringe_data): Move decl from here ...
8837 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8838 to check its interface.
8839 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8841 * fontset.c (free_realized_fontset): Now static.
8842 (Fset_fontset_font): Rename local to avoid shadowing.
8843 (fontset_font): Mark local as initialized.
8844 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8846 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8848 * xselect.c (x_disown_buffer_selections): Remove; not used.
8849 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8850 (x_own_selection, Fx_disown_selection_internal): Rename locals
8852 (x_handle_dnd_message): Remove local to avoid shadowing.
8854 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8855 so that the caller can use some name other than gcpro1.
8856 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8857 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8858 (Fx_backspace_delete_keys_p):
8859 Use them to avoid shadowing, and rename vars to avoid shadowing.
8860 (x_decode_color, x_set_name, x_window): Now static.
8861 (Fx_create_frame): Add braces to silence GCC warning.
8862 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8863 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8864 Remove unused locals.
8865 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8866 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8867 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8870 * xterm.h (x_mouse_leave): New decl.
8872 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8873 Remove unused functions.
8874 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8875 (x_calc_absolute_position): Now static.
8876 (XTread_socket): Don't define label "out" unless it's used.
8877 Don't declare local "event" unless it's used.
8878 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8879 unless they are used.
8880 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8881 (x_fatal_error_signal): Remove; not used.
8882 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8883 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8884 (x_error_catcher, x_connection_closed, x_error_handler):
8885 (x_error_quitter, xembed_send_message, x_iconify_frame):
8886 (my_log_handler): Rename locals to avoid shadowing.
8887 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8888 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8890 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8891 Rename or move locals to avoid shadowing.
8892 (tty_defined_color, merge_face_heights): Now static.
8893 (free_realized_faces_for_fontset): Remove; not used.
8894 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8895 does not deduce is never used uninitialized.
8896 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8897 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8899 * terminal.c (store_terminal_param): Now static.
8901 * xmenu.c (menu_highlight_callback): Now static.
8902 (set_frame_menubar): Remove unused local.
8903 (xmenu_show): Rename parameter to avoid shadowing.
8904 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8905 since they might point to immutable storage.
8906 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8907 since it's unused otherwise.
8909 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8910 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8911 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8912 avoids a gcc -Wuninitialized diagnostic.
8913 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8914 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8915 does not deduce are never used uninitialized.
8917 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8919 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8920 * window.c (window_loop, size_window):
8921 (run_window_configuration_change_hook, enlarge_window): Likewise.
8923 * window.c (display_buffer): Now static.
8924 (size_window): Mark variables that gcc -Wuninitialized
8925 does not deduce are never used uninitialized.
8926 * window.h (check_all_windows): New decl, to forestall
8927 gcc -Wmissing-prototypes diagnostic.
8928 * dispextern.h (bidi_dump_cached_states): Likewise.
8930 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8932 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8934 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8935 and to avoid gcc -Wuninitialized warning.
8936 (load_charset_map): Mark variables that gcc -Wuninitialized
8937 does not deduce are never used uninitialized.
8938 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8940 * coding.c (coding_set_source, coding_set_destination):
8941 Use "else { /* comment */ }" rather than "else /* comment */;"
8942 for clarity, and to avoid gcc -Wempty-body warning.
8943 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8944 a block, when the outer 'i' will do.
8945 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8946 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8947 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8948 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8949 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8950 Rename locals to avoid shadowing.
8951 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8952 * coding.c (emacs_mule_char, encode_invocation_designation):
8953 Now static, since they're not used elsewhere.
8954 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8955 (decode_coding_object, encode_coding_object, detect_coding_system):
8956 (decode_coding_emacs_mule): Mark variables that gcc
8957 -Wuninitialized does not deduce are never used uninitialized.
8958 (detect_coding_iso_2022): Initialize a local variable that might
8959 be used uninitialized. Leave a FIXME because it's not clear that
8960 this initialization is needed. (Bug#8211)
8961 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8962 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8963 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8964 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8965 Remove unused macros.
8967 * category.c (hash_get_category_set): Remove unused local var.
8968 (copy_category_table): Now static, since it's not used elsewhere.
8969 * character.c (string_count_byte8): Likewise.
8971 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8972 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8974 * chartab.c (copy_sub_char_table): Now static, since it's not used
8976 (sub_char_table_ref_and_range, char_table_ref_and_range):
8977 Rename locals to avoid shadowing.
8978 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8980 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8981 (BIDI_BOB): Remove unused macro.
8983 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8984 deduce are never used uninitialized.
8985 * term.c (encode_terminal_code): Likewise.
8987 * term.c (encode_terminal_code): Now static. Remove unused local.
8989 * tparam.h: New file.
8990 * term.c, tparam.h: Include it.
8991 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8992 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8993 Move these decls to tparam.h, and make them agree with what
8994 is actually in tparam.c. The previous trick of using incompatible
8995 decls in different modules does not conform to the C standard.
8996 All callers of tparam changed to use tparam's actual API.
8997 * tparam.c (tparam1, tparam, tgoto):
8998 Use const pointers where appropriate.
9000 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9001 * cm.h (struct cm): Likewise.
9002 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9003 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9004 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9005 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9006 (turn_on_face, init_tty): Likewise.
9007 * termchar.h (struct tty_display_info): Likewise.
9009 * term.c (term_mouse_position): Rename local to avoid shadowing.
9011 * alloc.c (mark_ttys): Move decl from here ...
9012 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9014 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9016 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9018 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9020 * search.c (compile_pattern_1): Remove argument regp, unused since
9021 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9022 (compile_pattern): Don't pass it.
9024 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9026 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9027 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9029 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9031 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9033 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9034 gdk_window_get_screen, gdk_window_get_geometry,
9035 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9036 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9037 (xg_get_pixbuf_from_pixmap): New function.
9038 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9039 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9040 Call xg_get_pixbuf_from_pixmap instead of
9041 gdk_pixbuf_get_from_drawable.
9042 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9043 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9044 (xg_check_special_colors): Use GtkStyleContext and its functions
9046 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9047 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9048 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9049 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9050 Call gtk_widget_get_preferred_size.
9051 (xg_frame_resized): gdk_window_get_geometry only takes 5
9053 (xg_win_to_widget, xg_event_is_for_menubar):
9054 Call gdk_x11_window_lookup_for_display.
9055 (xg_set_widget_bg): New function.
9056 (delete_cb): New function.
9057 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9058 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9059 (xg_set_background_color): Call xg_set_widget_bg.
9060 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9061 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9062 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9063 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9065 (update_frame_tool_bar): Call gtk_widget_hide.
9066 (xg_initialize): Use GDK_KEY_g.
9068 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9070 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9072 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9073 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9074 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9076 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9078 * w32xfns.c (select_palette): Check success of RealizePalette against
9079 GDI_ERROR, not zero.
9081 See ChangeLog.11 for earlier changes.
9087 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9089 This file is part of GNU Emacs.
9091 GNU Emacs is free software: you can redistribute it and/or modify
9092 it under the terms of the GNU General Public License as published by
9093 the Free Software Foundation, either version 3 of the License, or
9094 (at your option) any later version.
9096 GNU Emacs is distributed in the hope that it will be useful,
9097 but WITHOUT ANY WARRANTY; without even the implied warranty of
9098 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9099 GNU General Public License for more details.
9101 You should have received a copy of the GNU General Public License
9102 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.