1 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4 verifies glyph row's hash code--we have just reallocated the
5 glyphs, so their contents can be complete garbage. (Bug#10164)
7 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
9 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
11 2011-11-30 Eli Zaretskii <eliz@gnu.org>
13 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
14 attributes are tested _before_ calling verify_row_hash, to protect
15 against GCC re-ordering of the tests. (Bug#10164)
17 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
19 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
21 * xterm.c (handle_one_xevent): Only set async_visible and friends
22 if net_wm_state_hidden_seen is non-zero (Bug#10002)
23 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
24 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
26 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
28 Remove GCPRO-related macros that exist only to avoid shadowing locals.
29 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
30 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
31 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
32 All uses changed to use GCPRO1 etc.
33 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
34 Revert to old implementation (i.e., before 2011-03-11).
36 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
38 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
39 of scroll runs so as to avoid assigning disabled bogus rows and
40 unnecessary graphics copy operations.
42 2011-11-27 Eli Zaretskii <eliz@gnu.org>
44 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
45 (snprintf) [_MSC_VER]: Redirect to _snprintf.
46 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
47 (malloc, free, realloc, calloc): Redirect to e_* only when
50 * lisp.h (GCTYPEBITS): Move before first use.
51 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
52 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
53 this macro definition.
55 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
58 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
60 * gtkutil.c (xg_create_frame_widgets): Call
61 gtk_window_set_has_resize_grip (FALSE) if that function is
62 present with Gtk+ 2.0.
64 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
66 * fileio.c (Finsert_file_contents): Undo previous change; see
67 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
69 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
71 Rename locals to avoid shadowing.
72 * fileio.c (Finsert_file_contents):
73 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
74 * process.c (wait_reading_process_output):
75 Rename inner 'proc' to 'p' to avoid shadowing.
76 Indent for consistency with usual Emacs style.
78 2011-11-25 Eli Zaretskii <eliz@gnu.org>
80 * xdisp.c (redisplay_window): If cursor row is not fully visible
81 after recentering, and scroll-conservatively is set to a large
82 number, scroll window by a few more lines to make the cursor fully
83 visible and out of scroll-margin. (Bug#10105)
84 (start_display): Don't move to the next line if the display should
85 start at a newline that is part of a display vector or an overlay
88 2011-11-24 Juri Linkov <juri@jurta.org>
90 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
91 after the `MagickPingImage' call. (Bug#10112)
93 2011-11-23 Chong Yidong <cyd@gnu.org>
95 * window.c (Fcoordinates_in_window_p): Accept only live windows.
97 2011-11-23 Martin Rudalics <rudalics@gmx.at>
99 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
100 making another buffer current. (Bug#10114)
102 2011-11-23 Glenn Morris <rgm@gnu.org>
104 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
106 2011-11-23 Chong Yidong <cyd@gnu.org>
108 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
111 2011-11-22 Eli Zaretskii <eliz@gnu.org>
113 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
114 and header-lines, as they don't have one computed for them.
117 * .gdbinit (prow): Make displayed values more self-explaining.
120 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
122 * process.c (wait_reading_process_output): Fix asynchrounous
123 GnuTLS socket handling on some versions of the GnuTLS library.
124 (wait_reading_process_output): Add comment and URL.
126 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
128 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
130 2011-11-21 Chong Yidong <cyd@gnu.org>
132 * window.c (Fnext_window, Fprevious_window): Doc fix.
134 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
136 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
138 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
140 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
142 2011-11-20 Martin Rudalics <rudalics@gmx.at>
144 * window.c (Fset_window_combination_limit): Rename argument
146 (Vwindow_combination_limit): Remove "status" from doc-string.
148 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
150 * m/ibms390.h: Remove.
151 * m/ibms390x.h: Don't include "ibms390.h".
153 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
155 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
156 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
158 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
160 * casetab.c (Fset_case_table):
161 * charset.c (Fcharset_after): Fix typos.
163 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
165 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
166 Otherwise, valgrind does not work on some platforms.
167 Problem reported by Andreas Schwab in
168 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
169 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
170 is set, removing the need for VIRT_ADDRESS_VARIES.
171 (PURE_P): Use a more-efficient implementation that needs just one
172 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
173 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
174 to 4 (xorl, subq, cmpq, setbe).
175 * alloc.c (pure): Always extern now, since that's the
176 VIRT_ADDR_VARIES behavior.
177 (PURE_POINTER_P): Use a single comparison, not two, for
178 consistency with the new puresize.h.
179 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
180 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
181 Remove VIRT_ADDR_VARIES no longer needed.
183 2011-11-19 Eli Zaretskii <eliz@gnu.org>
185 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
186 (erase_phys_cursor, update_window_cursor, show_mouse_face)
187 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
188 behave as if the cursor position were at the window margin.
190 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
191 and the cursor position is out of bounds, behave as if the cursor
192 position were at the window margin. (Bug#10075)
194 2011-11-18 Chong Yidong <cyd@gnu.org>
196 * window.c (Fwindow_combination_limit): Make first argument
197 non-optional, since it is meaningless for live windows like the
200 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
202 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
204 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
206 * intervals.c: Fix grafting over the whole buffer (bug#10071).
207 (graft_intervals_into_buffer): Simplify.
209 2011-11-18 Eli Zaretskii <eliz@gnu.org>
211 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
212 hash values of the two rows.
213 (copy_row_except_pointers): Preserve the used[] arrays and the
214 hash values of the two rows. (Bug#10035)
215 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
217 * xdisp.c (row_hash): New function, body extracted from
218 compute_line_metrics.
219 (compute_line_metrics): Call row_hash, instead of computing the
222 * dispnew.c (verify_row_hash): Call row_hash for computing the
223 hash code of a row, instead of duplicating code from xdisp.c.
225 * dispextern.h (row_hash): Add prototype.
227 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
229 * frame.c (delete_frame): Don't delete the terminal when the last
230 X frame is closed if emacs is built with GTK toolkit.
232 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
234 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
236 2011-11-17 Martin Rudalics <rudalics@gmx.at>
238 * window.c (Vwindow_splits): Rename to
239 Vwindow_combination_resize. Suggested by Juri Linkov.
240 (Fsplit_window_internal): Use Vwindow_combination_resize instead
243 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
245 * nsfns.m (Fns_font_name):
246 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
248 2011-11-16 Martin Rudalics <rudalics@gmx.at>
250 * window.h (window): Rename slot "nest" to "combination_limit".
251 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
252 (Fset_window_nest): Rename to Fset_window_combination_limit.
253 (Vwindow_nest): Rename to Vwindow_combination_limit.
254 (recombine_windows, make_parent_window, make_window)
255 (Fsplit_window_internal, saved_window)
256 (Fset_window_configuration, save_window_save): Rename all
257 occurrences of window_nest to window_combination_limit.
259 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
261 * image.c (imagemagick_load_image): Fix typo.
263 2011-11-14 Eli Zaretskii <eliz@gnu.org>
265 * xdisp.c (display_line): Move the call to
266 highlight_trailing_whitespace before the call to
267 compute_line_metrics, since the latter needs to see the final
268 faces of all the glyphs to compute ROW's hash value. Fixes
269 assertion violations in row_equal_p. (Bug#10035)
271 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
273 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
274 just return (bug#10044).
276 2011-11-12 Eli Zaretskii <eliz@gnu.org>
278 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
279 with user-defined heap size. Bump the default size of the temacs
280 heap to 27MB, to avoid memory warning when running temacs.
281 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
283 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
284 current_matrix and desired_matrix. (Bug#9990)
285 (verify_row_hash) [XASSERTS]: New function.
286 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
287 that the hash value of glyph rows is correct.
289 2011-11-12 Martin Rudalics <rudalics@gmx.at>
291 * window.h (window): Remove splits slot.
292 * window.c (Fwindow_splits, Fset_window_splits): Remove.
293 (Fdelete_other_windows_internal, make_parent_window)
294 (make_window, Fsplit_window_internal, Fdelete_window_internal)
295 (Fset_window_configuration, save_window_save): Don't deal with
296 split status of windows.
297 (saved_window): Remove splits slot.
298 (Vwindow_splits): Rewrite doc-string.
300 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
302 * xfns.c (unwind_create_frame):
303 * nsfns.m (unwind_create_frame):
304 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
305 Vframe_list (Bug#9999).
307 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
309 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
311 2011-11-11 Kenichi Handa <handa@m17n.org>
313 * callproc.c (Fcall_process): Set the member dst_multibyte of
316 2011-11-11 Johan Bockgård <bojohan@gnu.org>
318 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
319 avoid a crash (bug#9496).
321 2011-11-09 Chong Yidong <cyd@gnu.org>
323 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
324 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
326 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
328 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
330 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
332 Avoid some portability problems by eschewing 'extern inline' functions.
333 The trivial performance wins aren't worth the portability hassles; see
334 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
336 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
337 (window_box_width, window_box_left, window_box_left_offset)
338 (window_box_right, window_box_right_offset): Undo previous change,
339 by removing the "extern"s.
340 * intervals.c (adjust_intervals_for_insertion)
341 (adjust_intervals_for_deletion): Undo previous change,
342 making these static again.
343 (offset_intervals, temp_set_point_both, temp_set_point)
344 (copy_intervals_to_string): No longer inline.
345 * xdisp.c (window_text_bottom_y, window_box_width)
346 (window_box_height, window_box_left_offset)
347 (window_box_right_offset, window_box_left, window_box_right)
348 (window_box): No longer inline.
350 2011-11-08 Chong Yidong <cyd@gnu.org>
352 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
353 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
354 an error if not a live window.
355 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
356 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
358 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
360 * lisp.h (syms_of_abbrev): Remove declaration.
361 Reported by CHENG Gao <chenggao@royau.me>.
363 2011-11-07 Eli Zaretskii <eliz@gnu.org>
365 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
366 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
367 of temacs in GUI mode.
369 2011-11-07 Martin Rudalics <rudalics@gmx.at>
371 * window.h: Declare delete_all_child_windows instead of
372 delete_all_subwindows.
373 * window.c (Fwindow_nest, Fset_window_nest)
374 (Fset_window_new_total, Fset_window_new_normal)
375 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
376 (delete_all_subwindows): Rename to delete_all_child_windows.
377 (Fdelete_other_windows_internal, Fset_window_configuration):
378 Call delete_all_child_windows instead of delete_all_subwindows.
379 * frame.c (delete_frame): Call delete_all_child_windows instead
380 of delete_all_subwindows.
382 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
384 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
385 This is also needed for porting to any host where GC_MARK_STACK is
386 not GC_MAKE_GCPROS_NOOPS.
387 (which_symbols): Use it.
389 2011-11-07 Kenichi Handa <handa@m17n.org>
391 * coding.c (coding_set_destination): Check coding->src_pos only
392 when coding->src_object is a buffer (bug#9910).
394 * process.c (send_process): Set the member src_multibyte of coding
395 to 0 (bug#9911) when sending a unibyte text.
397 * callproc.c (Fcall_process): Set the member src_multibyte of
398 process_coding to 0 (bug#9912).
400 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
402 * xmenu.c (cleanup_widget_value_tree): New function.
403 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
404 calling free_menubar_widget_value_tree directly (Bug#9830).
406 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
408 Fix some portability problems with 'inline'.
409 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
410 (window_box_width, window_box_left, window_box_left_offset)
411 (window_box_right, window_box_right_offset): Declare extern.
412 Otherwise, these inline functions do not conform to C99 and
413 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
414 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
415 * intervals.c (adjust_intervals_for_insertion)
416 (adjust_intervals_for_deletion): Now extern, because otherwise the
417 extern inline functions 'offset_intervals' couldn't refer to it.
418 (static_offset_intervals): Remove.
419 (offset_intervals): Rewrite using the old contents of
420 static_offset_intervals. The old version didn't conform to C99
421 because an extern inline function contained a reference to an
422 identifier with static linkage.
424 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
426 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
429 2011-11-06 Eli Zaretskii <eliz@gnu.org>
431 * xdisp.c (init_iterator, reseat_to_string): Don't set the
432 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
433 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
434 return Qleft_to_right.
436 2011-11-06 Chong Yidong <cyd@gnu.org>
438 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
439 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
440 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
441 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
442 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
443 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
444 (Fwindow_vscroll): Doc fix.
445 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
446 argument, since it makes no sense to pass a live window and for
447 consistency with window-child.
449 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
451 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
454 2011-11-05 Jason Rumney <jasonr@gnu.org>
456 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
457 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
459 (add_font_entity_to_list): Fix logic errors in mixed boolean and
460 bitwise arithmetic preventing use of unicode-sip and non-truetype
463 2011-11-05 Eli Zaretskii <eliz@gnu.org>
465 * s/ms-w32.h (fstat, stat, utime): Move redirections to
468 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
469 initialization code to keep similarity to xfns.c after changes
472 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
474 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
475 (unwind_create_frame): New function (Bug#9943).
476 (Fx_create_frame): Restructure code to be more similar to the one in
477 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
478 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
479 Move terminal->reference_count++ just before making the frame official
482 * nsterm.m (x_free_frame_resources): New function.
483 (x_destroy_window): Move code to x_free_frame_resources.
485 * xfns.c (unwind_create_frame): Fix comment.
486 (Fx_create_frame, x_create_tip_frame): Move
487 terminal->reference_count++ just before making the frame
488 official. Move initialization of image_cache_refcount and
489 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
491 2011-11-05 Eli Zaretskii <eliz@gnu.org>
493 Support MSVC build with newer versions of Visual Studio.
494 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
495 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
498 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
499 which are not supported by MSVC.
500 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
501 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
503 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
505 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
507 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
509 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
511 Support MSVC build with newer versions of Visual Studio.
512 * w32.c: Don't include w32api.h for MSVC.
513 (init_environment) [_MSC_VER]: Call sys_access, not _access.
515 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
516 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
517 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
518 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
520 (alloca) [_MSC_VER]: Define to _alloca.
522 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
524 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
526 2011-11-04 Eli Zaretskii <eliz@gnu.org>
528 * xdisp.c (note_mouse_highlight): If either of
529 previous/next-single-property-change returns nil, treat that as
530 the beginning or the end of the buffer. (Bug#9955)
532 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
534 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
535 label is not null (Bug#9951).
536 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
539 2011-11-04 Eli Zaretskii <eliz@gnu.org>
541 * window.c (Fwindow_body_size): Mention in the doc string that the
542 return value is in frame's canonical units. (Bug#9949)
544 2011-11-03 Eli Zaretskii <eliz@gnu.org>
546 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
548 * w32fns.c (unwind_create_frame): If needed, free the glyph
549 matrices of the partially constructed frame. (Bug#9943)
550 * xfns.c (unwind_create_frame): Likewise.
552 2011-11-01 Eli Zaretskii <eliz@gnu.org>
554 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
555 Don't stop backward scan on the continuation glyph, even though
556 its CHARPOS is positive.
557 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
558 cover_string to disp_string.
560 2011-11-01 Martin Rudalics <rudalics@gmx.at>
562 * window.c (temp_output_buffer_show): Don't use
563 Vtemp_buffer_show_specifiers.
564 (Vtemp_buffer_show_specifiers): Remove unused variable.
566 2011-10-30 Eli Zaretskii <eliz@gnu.org>
568 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
569 past the beginning of the current glyph matrix.
571 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
573 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
574 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
575 HAVE_GTK3 (Bug#9869).
577 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
578 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
580 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
582 * xterm.c: Declare x_handle_net_wm_state to return int.
583 (handle_one_xevent): Check if we are iconified but don't have
584 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
585 (get_current_wm_state): Return non-zero if not hidden,
586 check for _NET_WM_STATE_HIDDEN (Bug#9893).
587 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
588 (x_handle_net_wm_state): Return what get_current_wm_state returns.
589 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
591 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
593 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
594 so that this new function doesn't get optimized away by a
595 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
597 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
599 * frame.h (MOUSE_HL_INFO): Remove excess parens.
601 2011-10-29 Eli Zaretskii <eliz@gnu.org>
603 Fix the `xbytecode' command.
604 * .gdbinit (xprintbytestr): New command.
605 (xwhichsymbols): Rename from `which'; all callers changed.
606 (xbytecode): Print the byte-code string as well.
608 2011-10-29 Kim Storm <storm@cua.dk>
610 * alloc.c (which_symbols): New function.
612 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
614 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
617 2011-10-29 Glenn Morris <rgm@gnu.org>
619 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
620 Not clear what it was for, and it causes various bugs. (Bug#9839)
622 2011-10-28 Eli Zaretskii <eliz@gnu.org>
624 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
625 possible random value that matches one of those tested as
626 condition to clear the mouse face.
628 2011-10-28 Chong Yidong <cyd@gnu.org>
630 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
632 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
634 * window.c (make_window): Initialize phys_cursor_on_p.
636 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
638 * lisp.h (struct Lisp_Symbol): Update comments.
640 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
642 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
644 2011-10-28 Eli Zaretskii <eliz@gnu.org>
646 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
647 <oslsachem@gmail.com> for helping to debug this.
649 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
650 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
651 (g_b_init_get_glyph_outline_w): New static variables.
652 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
653 (GetGlyphOutlineW_Proc): New typedefs.
654 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
655 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
657 (w32font_open_internal, compute_metrics):
658 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
659 instead of calling the "wide" APIs directly.
661 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
663 * w32.h (syms_of_w32font): Add prototype.
665 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
667 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
668 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
669 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
670 (Fmove_to_window_line): Doc fix.
672 2011-10-27 Chong Yidong <cyd@gnu.org>
674 * process.c (make_process): Set gnutls_state to NULL.
676 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
677 non-NULL, regardless of GNUTLS_INITSTAGE.
678 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
679 an error. Set process slots as soon as we allocate them.
681 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
683 2011-10-27 Chong Yidong <cyd@gnu.org>
685 * gnutls.c (emacs_gnutls_deinit): New function.
686 Deallocate credentials structures as well as calling gnutls_deinit.
687 (Fgnutls_deinit, Fgnutls_boot): Use it.
689 * process.c (make_process): Initialize GnuTLS credentials to NULL.
690 (deactivate_process): Call emacs_gnutls_deinit.
692 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
694 * image.c (x_create_x_image_and_pixmap):
695 * w32.c (sys_rename, w32_delayed_load):
696 * w32font.c (fill_in_logfont):
697 * w32reg.c (x_get_string_resource): Silence compiler warnings.
699 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
701 * w32fns.c (w32_default_color_map): New function,
702 extracted from Fw32_default_color_map.
703 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
705 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
707 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
709 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
711 * keyboard.c (test_undefined): New function (bug#9751).
712 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
714 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
716 * sysdep.c (init_sys_modes): Fix the check for the controlling
719 2011-10-20 Eli Zaretskii <eliz@gnu.org>
721 * dispextern.h (struct bidi_it): New member next_en_type.
723 * bidi.c (bidi_line_init): Initialize the next_en_type member.
724 (bidi_resolve_explicit_1): When next_en_pos is valid for the
725 current character, check also for next_en_type being WEAK_EN.
726 (bidi_resolve_weak): Don't enter the expensive loop if the current
727 position is before next_en_pos. Record the bidi type of the first
728 non-ET, non-BN character we find, in addition to its position.
729 (bidi_level_of_next_char): Invalidate next_en_type when
730 next_en_pos is over-stepped.
732 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
734 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
735 * editfns.c: Rewrite current-time-zone so that it invokes
736 the equivalent of (format-time-string "%Z") to get the time zone name.
737 This fixes a bug when the time zone name contains characters that
738 need converting from the system time locale to Emacs internal format.
739 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
740 that patch fixed format-time-string to do the conversion, but
741 I forgot to fix current-time-zone.
742 (format_time_string): New function, containing most of
743 what Fformat_time_string used to contain.
744 (Fformat_time_string): Rewrite in terms of format_time_string.
745 This doesn't change this function's behavior.
746 (current-time-zone): Rewrite to use format_time_string.
747 This fixes the bug reported by Michael Schierl in
748 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
749 Jason Rumney's 2007-06-07 change worked around this bug, but
751 * systime.h (tzname, timezone): Remove no-longer-used declarations.
753 2011-10-19 Eli Zaretskii <eliz@gnu.org>
755 * xdisp.c (start_display): If the character at POS is displayed
756 via a display vector, reset IT->current.dpvec_index to zero.
757 (try_window_reusing_current_matrix): If a line ends in a display
758 vector or the next line starts in a display vector, continue
759 redrawing the window even though the character position of
760 start_row was reached.
763 2011-10-18 Chong Yidong <cyd@gnu.org>
765 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
766 with nobreak-char-display too.
768 2011-10-18 Eli Zaretskii <eliz@gnu.org>
770 Fix part 3 of bug#9771.
771 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
772 (bidi_resolve_neutral): Don't enter the expensive loop looking for
773 non-neutral characters if the current character is a paragraph
774 separator (a.k.a. Newline). This avoids running the same
775 expensive loop twice, once when we consume the preceding newline
776 and the other time when the line actually needs to be displayed.
777 Avoid the loop when we see neutrals on the base embedding level
778 following a character whose directionality is the same as the
779 paragraph's. This avoids running the expensive loop when a line
780 ends in a long sequence of neutrals, like control characters.
781 Add assertion against STRONG_AL type. Slightly rearrange code
782 that determines the type of a neutral given the first non-neutral
784 (bidi_level_of_next_char): Set next_en_pos to zero when
785 invalidating its info.
787 2011-10-17 Eli Zaretskii <eliz@gnu.org>
789 * xdisp.c (push_display_prop): Determine whether to record string
790 or buffer position by IT->string, not by IT->method. Allow
791 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
792 (move_it_vertically_backward): Don't look for character position
793 immediately after the newline when in a continuation line.
796 2011-10-15 Martin Rudalics <rudalics@gmx.at>
798 * window.c (coordinates_in_window): Rewrite and delabelize
799 vertical border check. (Bug#5357) (Bug#9618)
801 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
803 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
804 errors in XSetWindowBorder (bug#9310).
806 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
808 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
809 avoid crash when xmalloc overrun checking is enabled.
811 2011-10-13 Eli Zaretskii <eliz@gnu.org>
813 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
814 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
815 cursor motion with <left> and <right> arrow keys.
817 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
818 some callers set that themselves.
820 2011-10-12 Eli Zaretskii <eliz@gnu.org>
822 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
823 display string and the previous row comes from the same string and
824 is empty. (Bug#9739) (Bug#9738)
826 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
828 * doc.c (get_doc_string): Encode file name (bug#9735).
830 2011-10-12 Eli Zaretskii <eliz@gnu.org>
832 * bidi.c (bidi_level_of_next_char):
833 * xdisp.c (get_visually_first_element): Remove old incorrect
834 comments regarding the Unicode Line Separator character.
836 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
838 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
840 * alloc.c (Fgc_status): Do not access beyond zombies array
841 boundary if nzombies > MAX_ZOMBIES.
842 * alloc.c (dump_zombies): Add missing format specifier.
844 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
846 * xdisp.c (set_cursor_from_row): Simplify conditionals,
847 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
849 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
850 Some packages use them to denote characters with modifiers.
852 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
854 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
855 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
856 matching a pp-number. Rename parameter var to var1.
858 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
860 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
862 2011-10-08 Glenn Morris <rgm@gnu.org>
864 * callint.c (Fcall_interactively): Give a more explicit error for the
865 'c' case with a non-character input. (Bug#8479)
867 2011-10-08 Eli Zaretskii <eliz@gnu.org>
869 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
871 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
872 lines that are hscrolled on the left.
874 * dispnew.c (buffer_posn_from_coords): Account for a possible
875 presence of header-line. (Bug#4426)
877 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
879 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
880 Don't advertise functionality which we discourage or doesn't work.
882 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
884 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
885 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
886 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
887 this makes Emacs dump core during garbage collection on rare
888 occasions. sizeof is obviously inferior to offsetof here, so
890 (GC_POINTER_ALIGNMENT): New macro.
891 (mark_memory): Omit 3rd (offset) arg; caller changed.
892 Don't assume EMACS_INT alignment is the same as pointer alignment.
894 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
896 * keyboard.c (read_key_sequence_remapped): New var.
897 (read_key_sequence): Compute remapping in the right buffer.
898 (command_loop_1): Use read_key_sequence's remapping directly.
900 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
902 * dired.c (file_name_completion): Don't expand file name.
903 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
904 before checking file name handler.
906 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
907 they've been requested explicitly (bug#9591).
909 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
911 * keymap.c (Fsingle_key_description): Use make_specified_string
912 instead of build_string to build string from push_key_description.
915 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
917 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
918 This fixes a Y2038 bug on 64-bit hosts.
919 * buffer.c (reset_buffer):
920 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
921 (Fclear_buffer_auto_save_failure):
922 Use 0, not -1, to represent an unset failure time, since time_t
925 Remove dependency on glibc malloc internals.
926 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
927 Move back here from lisp.h, but with their new implementations.
928 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
929 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
930 * charset.c (charset_table_init): New static var.
931 (syms_of_charset): Use it instead of xmalloc. This removes a
932 dependency on glibc malloc internals. See Eli Zaretskii's comment in
933 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
934 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
935 Move back to alloc.c.
936 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
937 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
939 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
941 * nsterm.m (windowDidResize): Call x_set_window_size only when
942 ns_in_resize is true. Otherwise set pixelwidth/height and
943 call change_frame_size (Bug#9628).
945 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
947 Port --enable-checking=all to Fedora 14 x86-64.
948 * charset.c (syms_of_charset): Also account for glibc malloc's
949 internal overhead when calculating the initial malloc maximum.
951 Port --enable-checking=all to Fedora 14 x86.
952 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
954 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
955 (overrun_check_realloc, overrun_check_free):
956 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
957 That way, xmalloc returns a properly-aligned pointer even if
958 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
959 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
960 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
961 into account when calculating the initial malloc maximum.
962 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
963 Move here from alloc.c, so that charset.c can use it too.
964 Properly align; the old code wasn't right for common 32-bit hosts
965 when configured with --enable-checking=all.
966 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
967 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
969 2011-09-29 Eli Zaretskii <eliz@gnu.org>
971 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
974 2011-09-28 Eli Zaretskii <eliz@gnu.org>
976 * xdisp.c (compute_display_string_end): If there's no display
977 string at CHARPOS, return -1.
979 * bidi.c (bidi_fetch_char): When compute_display_string_end
980 returns a negative value, treat the character as a normal
981 character not covered by a display string. (Bug#9624)
983 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
985 * lread.c (Fread_from_string): Fix typo in docstring.
987 2011-09-27 Eli Zaretskii <eliz@gnu.org>
989 * xdisp.c (handle_invisible_prop): If invisible text ends on a
990 newline, reseat the iterator instead of bidi-iterating there one
991 character at a time. (Bug#9610)
992 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
993 TO_CHARPOS if the bidi iterator is at base embedding level.
995 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
997 * lread.c (readevalloop): Use correct code for NBSP.
998 (read1): Likewise. (Bug#9608)
1000 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1002 * dbusbind.c (Fdbus_register_signal): When service is not
1003 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1005 2011-09-25 Glenn Morris <rgm@gnu.org>
1007 * buffer.c (truncate-lines): Doc fix.
1009 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1011 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1012 (Fset_window_next_buffers): Doc fix.
1014 2011-09-24 Glenn Morris <rgm@gnu.org>
1016 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1018 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1020 Fix minor problems found by static checking.
1021 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1022 * indent.c (Fvertical_motion): Fix == vs = typo.
1024 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1026 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1027 Default value is now t. Doc fix.
1029 * indent.c (Fvertical_motion): Compute and apply the overshoot
1030 logic when moving up, not only when moving down. Fix the
1031 confusing name and values of the it_overshoot_expected variable;
1032 logic changes accordingly. (Bug#9254) (Bug#9549)
1034 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1035 CHARPOS is covered by a display string which includes newlines.
1036 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1037 is covered by a display string with embedded newlines.
1039 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1041 * dbusbind.c (Fdbus_register_signal): Add match rule to
1042 Vdbus_registered_objects_table. (Bug#9581)
1043 (Fdbus_register_method, Vdbus_registered_objects_table):
1046 2011-09-24 Jim Meyering <meyering@redhat.com>
1048 do not ignore write error for any output size
1049 The previous change was incomplete.
1050 While it makes emacs --batch detect the vast majority of stdout
1051 write failures, errors were still ignored whenever the output size is
1052 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1053 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1054 && echo FAIL: ignored write error
1055 FAIL: ignored write error
1056 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1057 && echo FAIL: ignored write error
1058 FAIL: ignored write error
1059 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1061 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1063 * emacs.c (Fkill_emacs): In noninteractive mode exit
1064 non-successfully if a write error occurred on stdout. (Bug#9574)
1066 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1068 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1071 * dispextern.h (struct it): Update the comment documenting what
1074 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1076 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1077 a display string, extend search for cursor position to end of row.
1078 (find_row_edges): If the row ends in a newline from a display
1079 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1080 Handle the case of a display string with multiple newlines.
1081 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1082 non-empty line. Fixes confusing cursor motion with arrow keys at
1083 the beginning of a line that starts with whitespace.
1085 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1087 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1090 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1092 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1095 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1097 * xdisp.c (display_line): Record maximum and minimum buffer
1098 positions even if no glyphs were produced (e.g., by a zero-width
1099 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1100 buffer positions that will be removed from the glyph row because
1102 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1103 column is beyond frame width: don't subtract 1 "pixel" when
1104 computing width of the stretch.
1105 (reseat_at_next_visible_line_start): Undo the change made on
1106 2011-09-17 that saved paragraph information and restored it after
1107 the call to `reseat'. (Bug#9545)
1109 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1111 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1112 and turn window cursor on if cleared (Bug#9415).
1114 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1116 * search.c (boyer_moore): Take unibyte characters from pattern
1117 literally. (Bug#9458)
1119 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1121 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1123 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1125 Fix minor problem found by static checking.
1126 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1127 initialized, to pacify gcc -Wuninitialized.
1129 * fileio.c: Report proper errno when syscall falls.
1130 (Finsert_file_contents): Save and restore errno,
1131 so that report_file_error outputs the correct diagnostic.
1132 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1134 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1136 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1138 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1140 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1141 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1143 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1145 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1146 about the current paragraph and restore it after the call to reseat.
1148 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1149 (bidi_find_paragraph_start): Search back for paragraph beginning
1150 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1151 (bidi_move_to_visually_next): Only trigger paragraph-related
1152 computations when the last character is a newline or at EOB, not
1153 just any NEUTRAL_B. (Bug#9470)
1155 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1156 truncated lines if point is covered by a display string. (Bug#9524)
1158 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1160 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1161 (cons_to_x_long): New function.
1162 (lisp_data_to_selection_data): Use it. Correct the test for
1163 short-versus-long data; it was negated. Break out of vector
1164 loop, for efficiency, when a long datum is discovered.
1166 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1168 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1170 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1172 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1173 GCC PR/17406) by declaring this function with external scope.
1175 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1177 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1178 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1180 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1182 * editfns.c (Fformat): Correctly handle text properties on "%%".
1184 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1186 * xterm.c (x_draw_composite_glyph_string_foreground):
1187 * w32term.c (x_draw_composite_glyph_string_foreground):
1188 * term.c (encode_terminal_code):
1189 * composite.c (composition_update_it, get_composition_id):
1190 * xdisp.c (get_next_display_element)
1191 (fill_composite_glyph_string): Add comments about special meaning
1192 of TAB characters in a composition.
1194 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1196 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1197 This occurs when processing a multibyte format.
1198 Problem reported by Wolfgang Jenker.
1200 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1202 * xdisp.c (try_cursor_movement): Only check for exact match if
1203 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1205 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1207 Remove unused external symbols.
1208 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1209 * xdisp.c (calc_pixel_width_or_height): Now static.
1210 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1211 * indent.c (check_display_width):
1212 * w32term.c: Fix comment to match code.
1213 * xterm.c, xterm.h (x_catching_errors): Remove.
1215 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1217 * xselect.c: Use signed conversions more consistently (Bug#9498).
1218 (selection_data_to_lisp_data): Assume incoming selection data are
1219 signed integers, not unsigned. This is to be consistent with
1220 outgoing selection data, which was modified to use signed integers
1221 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1222 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1223 expects long, not unsigned long.
1225 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1227 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1228 computation of loop end. Reported by Johan Bockgård
1231 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1233 * frame.c (Fother_visible_frames_p): Function deleted.
1235 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1237 * indent.c (compute_motion): Process display vector front to back
1238 rather than the other way around. (Bug#2496)
1240 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1242 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1244 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1246 * minibuf.c (Fread_from_minibuffer): Doc fix.
1248 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1250 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1251 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1253 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1255 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1256 value for non-existent files.
1258 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1260 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1261 set its "size" to -1. This will set the modtime_size field of
1262 the corresponding buffer to -1, which is what
1263 verify-visited-file-modtime expects for files that do not exist.
1266 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1268 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1270 * lisp.h: ... from here. push_key_description is no longer
1271 defined in keyboard.c, so its declaration should not be in
1272 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1273 logically belongs with push_key_description.
1275 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1277 * buffer.h: Include <sys/types.h> instead of <time.h>.
1278 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1279 Problem reported by Herbert J. Skuhra.
1281 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1283 * xml.c (parse_region): Make the parsing work for
1284 non-comment-starting XML files again (bug#9144).
1286 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1288 * image.c (gif_load): Fix calculation of bottom and right corner.
1291 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1293 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1294 redisplay in small windows.
1296 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1298 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1300 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1302 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1303 Operate on live windows only.
1305 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1307 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1309 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1311 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1312 only under bidi iteration.
1314 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1316 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1318 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1320 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1321 Without this fix, the command to link temacs failed due to an
1322 undefined symbol __builtin_isnan. This is because
1323 /usr/include/iso/math_c99.h #defines isnan(x) to
1324 __builtin_isnan(x), but the bundled gcc, which identifies itself
1325 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1327 * floatfns.c (isnan): #undef, and then #define to a clone of
1329 (Fisnan): Always define, since it's always available now.
1330 (syms_of_floatfns): Always define isnan at the Lisp level.
1332 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1334 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1336 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1338 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1339 The previous code assumed that file offsets (off_t values) fit in
1340 EMACS_INT variables, which is not true on typical 32-bit hosts.
1341 The code messed up by falsely reporting buffer overflow in cases
1342 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1343 when "big" contains more than 2**29 bytes, even though this
1344 inserts just one byte and does not overflow the buffer.
1345 (Finsert_file_contents): Store file offsets as off_t
1346 values, not as EMACS_INT values. Check for overflow when
1347 converting between EMACS_INT and off_t. When checking for
1348 buffer overflow or for overlap, take the offsets into account.
1349 Don't use EMACS_INT for small values where int suffices.
1350 When checking for overlap, fix a typo: ZV was used where
1351 ZV_BYTE was intended.
1352 (Fwrite_region): Don't assume off_t fits into 'long'.
1353 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1355 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1357 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1359 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1361 sprintf-related integer and memory overflow issues (Bug#9412).
1363 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1364 (esprintf, exprintf, evxprintf): New functions.
1365 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1366 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1367 (modify_event_symbol): Do not assume that the length of
1368 name_alist_or_stem is safe to alloca and fits in int.
1369 (Fexecute_extended_command): Likewise for function name and binding.
1370 (Frecursion_depth): Wrap around reliably on integer overflow.
1371 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1372 since some callers pass EMACS_INT values.
1373 (Fsingle_key_description): Don't crash if symbol name contains more
1374 than MAX_ALLOCA bytes.
1375 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1376 (get_minibuffer): Arg is now EMACS_INT, not int.
1377 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1378 (esprintf, exprintf, evxprintf): New decls.
1379 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1381 * dbusbind.c (signature_cat): New function.
1382 (xd_signature, Fdbus_register_signal):
1383 Do not overrun buffer; instead, report string overflow.
1385 * dispnew.c (add_window_display_history): Don't overrun buffer.
1386 Truncate instead; this is OK since it's just a log.
1388 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1389 even if the time zone offset is outlandishly large.
1390 Don't mishandle offset == INT_MIN.
1392 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1393 when creating daemon; the previous buffer-overflow check was incorrect.
1395 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1396 which has the guts of the old verror function.
1398 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1399 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1401 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1402 (font_unparse_xlfd): Don't blindly alloca long strings.
1403 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1404 fits in int, when using sprintf. Use single snprintf to count
1405 length of string rather than counting it via multiple sprintfs;
1406 that's simpler and more reliable.
1407 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1408 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1409 sprintf, in case result does not fit in int.
1411 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1412 (fontset_from_font): Print it.
1414 * frame.c (tty_frame_count): Now printmax_t, not int.
1415 (make_terminal_frame, set_term_frame_name): Print it.
1416 (x_report_frame_params): In X, window IDs are unsigned long,
1417 not signed long, so print them as unsigned.
1418 (validate_x_resource_name): Check for implausibly long names,
1419 and don't assume name length fits in 'int'.
1420 (x_get_resource_string): Don't blindly alloca invocation name;
1421 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1424 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1425 (xg_check_special_colors, xg_set_geometry):
1426 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1428 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1429 Use esprintf, not sprintf, in case result does not fit in int.
1431 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1432 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1433 it as a large positive number.
1434 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1435 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1437 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1438 in case result does not fit in int.
1440 * print.c (float_to_string): Detect width overflow more reliably.
1441 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1442 buffer overrun. Don't assume list length fits in 'int'. Treat
1443 print length of 0 as 0, not as infinity; to be consistent with other
1444 uses of print length in this function. Don't overflow print length
1445 index. Don't assume hash table size fits in 'long', or that
1446 vectorlike size fits in 'unsigned long'.
1448 * process.c (make_process): Use printmax_t, not int, to format
1449 process-name gensyms.
1451 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1453 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1454 to avoid potential buffer overrun.
1456 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1457 if X resource line is longer than 512 bytes.
1459 * xfns.c (x_window): Make sprintf buffer a bit bigger
1460 to avoid potential buffer overrun.
1462 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1464 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1466 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1468 Integer overflow fixes for scrolling, etc.
1469 Without these, Emacs silently mishandles large integers sometimes.
1470 For example, "C-u 4294967297 M-x recenter" was treated as if
1471 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1473 * xdisp.c (try_window_id): Check Emacs fixnum range before
1474 converting to 'int'.
1476 * window.c (window_scroll_line_based, Frecenter):
1477 Check that an Emacs fixnum is in range before assigning it to 'int'.
1478 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1479 values converted from Emacs fixnums.
1480 (Frecenter): Don't wrap around a line count if it is out of 'int'
1481 range; instead, treat it as an extreme value.
1482 (Fset_window_configuration, compare_window_configurations):
1483 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1485 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1486 that can exceed INT_MAX. Check that EMACS_INT value is in range
1487 before assigning it to the (possibly-narrower) index.
1488 (match_limit): Don't assume that a fixnum can fit in 'int'.
1490 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1493 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1494 (Fvertical_motion): Don't wrap around LINES values that don't fit
1495 in 'int'. Instead, treat them as extreme values. This is good
1496 enough for windows, which can't have more than INT_MAX lines anyway.
1498 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1500 * Require libxml/parser.h to avoid compilation warning.
1502 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1504 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1505 since this reportedly can destroy thread storage.
1507 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1509 * syntax.c (find_defun_start): Update all cache variables if
1510 exiting early (Bug#9401).
1512 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1514 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1516 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1517 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1518 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1520 * term.c (tty_append_glyph): New function.
1521 (produce_stretch_glyph): Static function and its prototype deleted.
1523 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1526 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1528 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1529 when checking :margin (Bug#9390).
1530 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1531 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1532 so that the name doesn't mislead. All uses changed.
1534 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1536 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1539 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1541 * xdisp.c (move_it_to): Don't bail out early when reaching
1542 position beyond to_charpos, if we are scanning backwards.
1543 (move_it_vertically_backward): When DY == 0, make sure we get to
1544 the first character in the line after the newline.
1546 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1548 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1549 (ccl_driver): Do not generate an out-of-range pointer.
1550 (Fccl_execute_on_string): Remove unnecessary check for
1551 integer overflow, noted by Stefan Monnier in
1552 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1553 Remove a FIXME that didn't need fixing.
1554 Simplify the newly-introduced buffer reallocation code.
1556 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1558 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1560 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1562 Integer and memory overflow issues (Bug#9196).
1564 * doc.c (get_doc_string): Rework so that
1565 get_doc_string_buffer_size is the actual buffer size, rather than
1566 being 1 less than the actual buffer size; this makes xpalloc more
1569 * image.c (x_allocate_bitmap_record, cache_image):
1570 * xselect.c (Fx_register_dnd_atom):
1571 Simplify previous changes by using xpalloc.
1573 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1574 since either will do and ptrdiff_t is convenient with xpalloc.
1576 * charset.c (charset_table_size)
1577 (struct charset_sort_data.priority): Now ptrdiff_t.
1578 (charset_compare): Don't overflow if priorities differ greatly.
1579 (Fsort_charsets): Don't assume list length fits in int.
1580 Check for size-calculation overflow when allocating sort data.
1581 (syms_of_charset): Allocate an initial charset table that is
1582 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1584 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1586 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1587 The actual value is always <= INT_MAX, and leaving it unsigned made
1588 overflow checking harder.
1590 * dispextern.h (struct glyph_matrix.rows_allocated)
1591 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1592 with xpalloc. The values are still always <= INT_MAX.
1594 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1596 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1597 (SAFE_NALLOCA): New macro.
1599 * region-cache.c (struct boundary.pos, find_cache_boundary)
1600 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1601 (set_cache_region, invalidate_region_cache)
1602 (revalidate_region_cache, know_region_cache, region_cache_forward)
1603 (region_cache_backward, pp_cache):
1604 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1605 so that ptrdiff_t * can be passed to xpalloc.
1606 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1607 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1608 (pp_cache): Don't assume cache_len fits in int.
1609 * region-cache.h: Adjust extern decls to match.
1611 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1612 EMACS_INT, since either will do, for xpalloc.
1614 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1615 (xnmalloc, xnrealloc, xpalloc): New functions.
1617 * bidi.c (bidi_shelve_header_size): New constant.
1618 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1619 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1621 * bidi.c (bidi_cache_shrink):
1622 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1624 Don't update size of array until after memory allocation succeeds,
1625 because xmalloc/xrealloc may not return.
1626 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1627 now that we have proper integer overflow checking.
1628 (record_overlay_string, overlay_strings): Catch overflows when
1629 calculating size of overlay_str_buf.
1631 * callproc.c (Fcall_process): Check for size overflow when
1632 calculating size of args2.
1633 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1634 Normally we prefer signed values, but sticking with ptrdiff_t would
1635 require adding more-complicated checks.
1637 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1638 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1639 Redo buffer-overflow calculations to avoid integer overflow.
1640 Add a FIXME comment where memory seems to be over-allocated.
1642 * character.c (Fstring): Check for size-calculation overflow.
1644 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1645 unnecessary integer overflow. Check for size overflow.
1646 (encode_coding_object): Don't update size until xmalloc succeeds.
1648 * composite.c (get_composition_id): Check for overflow in glyph
1649 length calculations.
1651 Integer and memory overflow fixes for display code.
1652 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1653 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1654 (scrolling_window): Check for overflow in size calculations.
1655 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1656 Don't assume glyph table len fits in int.
1657 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1658 (row_table_size): Now ptrdiff_t, not int.
1659 (scrolling_window): Avoid overflow in size calculations.
1660 Don't update size until allocation succeeds.
1661 * fns.c (concat): Check for overflow in size calculations.
1662 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1663 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1664 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1666 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1667 (get_doc_string): Check for size calculation overflow.
1668 Don't update size until allocation succeeds.
1669 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1670 EMACS_INT, where ptrdiff_t will do.
1671 (Fsubstitute_command_keys): Check for string overflow.
1673 * editfns.c (set_time_zone_rule): Don't assume environment length
1675 (message_length): Now ptrdiff_t, not int.
1676 (Fmessage_box): Don't update size until allocation succeeds.
1677 Don't assume message length fits in int.
1678 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1680 * emacs.c (main): Do not reallocate argv, since there is a null at
1681 the end that can be overwritten, and this way there's no need to
1682 worry about size-calculation overflow.
1683 (sort_args): Check for size-calculation overflow.
1685 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1687 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1689 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1690 (x_set_scroll_bar_width, x_figure_window_size):
1691 Check for integer overflow.
1692 (x_set_alpha): Do not assume XINT fits in int.
1694 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1695 This is for the members text_lines, text_cols, total_lines, total_cols,
1696 where the system imposes an 'int' limit.
1698 * fringe.c (Fdefine_fringe_bitmap):
1699 Don't update size until alloc works.
1701 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1702 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1704 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1705 Check for size-calculation overflow.
1706 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1707 do, as we prefer signed integers.
1708 (id_to_widget.max_size, id_to_widget.used)
1709 (xg_store_widget_in_map, xg_remove_widget_from_map)
1710 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1711 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1712 Use and return ptrdiff_t, not int.
1713 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1714 * gtkutil.h: Change prototypes to match the above.
1716 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1717 are duplicate now that they've been promoted to lisp.h.
1718 (x_allocate_bitmap_record, x_alloc_image_color)
1719 (make_image_cache, cache_image, xpm_load):
1720 Don't update size until alloc is done.
1721 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1723 Check for size calculation overflow.
1724 (ct_colors_allocated_max): New constant.
1725 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1728 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1729 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1730 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1731 Use ptrdiff_t, not int, to count maps.
1732 (read_char_minibuf_menu_prompt): Check for overflow in size
1733 calculations. Don't update size until allocation succeeds.
1734 Redo calculations to avoid overflow.
1735 * keyboard.h: Change prototypes to match the above.
1737 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1739 (current_minor_maps): Check for size calculation overflow.
1740 * keymap.h: Change prototypes to match the above.
1742 * lread.c (read1, init_obarray): Don't update size until alloc done.
1744 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1745 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1747 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1748 Now ptrdiff_t, not int.
1749 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1750 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1752 * process.c (Fnetwork_interface_list): Check for overflow
1753 in size calculation.
1755 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1757 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1758 overflow. Don't bother calling xmalloc when xrealloc will do.
1760 * search.c (Freplace_match): Check for size calculation overflow.
1761 (Fset_match_data): Don't assume list lengths fit in 'int'.
1763 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1764 for command line length. Do not attempt to address one before the
1765 beginning of an array, as that's not portable.
1767 * term.c (max_frame_lines): Remove; unused.
1768 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1770 (encode_terminal_code, calculate_costs): Check for size
1771 calculation overflow.
1772 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1773 table lengths and related sizes. Don't update size until alloc
1774 done. Redo calculations to avoid overflow.
1775 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1777 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1778 subtracting pointers.
1779 (gobble_line): Check for overflow more carefully. Don't update size
1782 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1783 Don't update size until alloc done.
1784 Redo size calculations to avoid overflow.
1785 Check for size calculation overflow.
1786 (main) [DEBUG]: Fix typo in invoking tparam1.
1788 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1789 Use ptrdiff_t, not int, for sizes.
1790 (store_mode_line_noprop_char): Don't update size until alloc done.
1792 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1793 Use ptrdiff_t, not int, for sizes.
1794 (Finternal_make_lisp_face, cache_face):
1795 Check for size calculation overflow.
1796 (cache_face): Treat size calculation overflows as if they were
1797 memory exhaustion (the usual treatment), rather than aborting.
1799 * xfns.c (x_encode_text, x_set_name_internal)
1800 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1801 sizes, since they can exceed INT_MAX in size. Check for size
1802 calculation overflow.
1804 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1805 (xg_select): Check for size calculation overflow.
1806 Don't update size until alloc done.
1808 * xrdb.c (get_environ_db): Don't assume path length fits in int,
1809 as sprintf is limited to int lengths.
1811 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1812 (X_LONG_MIN): New macros.
1813 Use them to make the following changes clearer.
1814 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1815 This change doesn't affect the value now, but it may help remind
1816 future maintainers not to raise the value too much later.
1817 (SELECTION_QUANTUM): Remove, replacing with ...
1818 (selection_quantum): ... new function, which avoids overflow.
1820 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1821 assumption that selection length fits in 'int'.
1822 (x_reply_selection_request, x_handle_selection_request)
1823 (x_get_window_property, receive_incremental_selection)
1824 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1825 (lisp_data_to_selection_data, clean_local_selection_data):
1826 Use ptrdiff_t, not int, to record length of selection.
1827 (x_reply_selection_request, x_get_window_property)
1828 (receive_incremental_selection, x_property_data_to_lisp):
1829 Redo calculations to avoid overflow.
1830 (x_reply_selection_request): When sending hint, ceiling it at
1831 X_LONG_MAX rather than relying on wraparound overflow to send
1833 (x_get_window_property, receive_incremental_selection)
1834 (lisp_data_to_selection_data, x_property_data_to_lisp):
1835 Check for size-calculation overflow.
1836 (x_get_window_property, receive_incremental_selection)
1837 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1838 Don't store size until memory allocation succeeds.
1839 (x_get_window_property): Plug memory leak on memory exhaustion.
1840 Don't double-block input; malloc is safe here. Don't assume 2**34
1841 - 4 fits in unsigned long. Add an xassert to check
1842 XGetWindowProperty overflow. Be more careful about overflow
1843 calculations, and distinguish size from memory overflow better.
1844 (receive_incremental_selection): When tracing, don't assume
1845 unsigned int is less than INT_MAX.
1846 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1847 harmful) conversions of unsigned short to int.
1848 (lisp_data_to_selection_data): Don't assume that integers
1849 in the range -65535 through -1 fit in an X unsigned short.
1850 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1851 result parameters unless successful. Rely on cons_to_unsigned
1852 to report problems with elements; the old code wasn't right anyway.
1853 (x_check_property_data): Check for int overflow; we cannot use
1854 a wider type due to X limits.
1855 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1857 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
1859 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1860 (x_term_init): Check for size calculation overflow.
1861 (x_color_cells): Don't store size until memory allocation succeeds.
1862 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
1863 Don't assume alloca size is less than MAX_ALLOCA.
1864 (x_term_init): Don't assume length fits in int (sprintf is limited
1867 Use ptrdiff_t for composition IDs.
1868 * character.c (lisp_string_width):
1869 * composite.c (composition_table_size, n_compositions)
1870 (get_composition_id, composition_gstring_from_id):
1871 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1872 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1873 * window.c (Frecenter):
1874 Use ptrdiff_t, not int, for composition IDs.
1875 * composite.c (get_composition_id): Check for integer overflow.
1876 * composite.h: Adjust prototypes to match the above changes.
1878 Use ptrdiff_t for hash table indexes.
1879 * category.c (hash_get_category_set):
1880 * ccl.c (ccl_driver):
1881 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1882 * coding.c (coding_system_charset_list, detect_coding_system):
1883 * coding.h (struct coding_system.id):
1884 * composite.c (get_composition_id, gstring_lookup_cache):
1885 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1886 * image.c (xpm_get_color_table_h):
1887 * lisp.h (hash_lookup, hash_put):
1888 * minibuf.c (Ftest_completion):
1889 Use ptrdiff_t for hash table indexes, not int (which is too
1890 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1891 32-bit --with-wide-int hosts).
1893 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1894 Add a FIXME comment about memory leaks.
1895 (syms_of_charset): Don't assume xmalloc returns.
1897 Don't assume that stated character widths fit in int.
1898 * character.c (Fchar_width, c_string_width, lisp_string_width):
1899 * character.h (CHAR_WIDTH):
1900 * indent.c (MULTIBYTE_BYTES_WIDTH):
1901 Use sanitize_char_width to avoid undefined and/or bad behavior
1902 with outlandish widths.
1903 * character.h (sanitize_tab_width): Rename from sanitize_width,
1904 now that we have two such functions. All uses changed.
1905 (sanitize_char_width): New inline function.
1907 Don't assume that tab-width fits in int.
1908 * character.h (sanitize_width): New inline function.
1909 (SANE_TAB_WIDTH): New macro.
1910 (ASCII_CHAR_WIDTH): Use it.
1911 * indent.c (sane_tab_width): Remove. All uses replaced by
1912 SANE_TAB_WIDTH (current_buffer).
1913 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1915 * fileio.c: Integer overflow issues with file modes.
1916 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1918 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1919 Remove unreachable code.
1920 (read_hex, load_charset_map_from_file): Check for integer overflow.
1922 * xterm.c: don't go over XClientMessageEvent limit
1923 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1924 (x_send_scroll_bar_event): Likewise. Check that the size does not
1925 exceed limits imposed by XClientMessageEvent, as well as the usual
1926 ptrdiff_t and size_t limits.
1928 * keyboard.c: Overflow, signedness and related fixes.
1929 (make_lispy_movement): Use same integer type in forward decl
1930 that is used in the definition.
1931 (read_key_sequence, keyremap_step):
1932 Change bufsize argument back to int, undoing my 2011-03-30 change.
1933 We prefer signed types, and int is wide enough here.
1934 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1935 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1936 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1937 length, not size_t. Use ptrdiff_t for index, not int.
1938 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1939 possibility of integer overflow.
1941 Overflow, signedness and related fixes for images.
1943 * dispextern.h (struct it.stack[0].u.image.image_id)
1944 (struct_it.image_id, struct image.id, struct image_cache.size)
1945 (struct image_cache.used, struct image_cache.ref_count):
1946 * gtkutil.c (update_frame_tool_bar):
1947 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1948 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1949 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1950 * nsmenu.m (update_frame_tool_bar):
1951 * xdisp.c (calc_pixel_width_or_height):
1952 * xfns.c (image_cache_refcount):
1953 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1954 on typical 64-bit hosts.
1956 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1957 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1958 Omit unnecessary casts to int.
1959 (parse_image_spec): Check that integers fall into 'int' range
1960 when the callers expect that.
1961 (image_ascent): Redo ascent calculation to avoid int overflow.
1962 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1963 (lookup_image): Remove unnecessary tests.
1964 (xbm_image_p): Locals are now of int, not EMACS_INT,
1965 since parse_image_check makes sure they fit into int.
1966 (png_load, gif_load, svg_load_image):
1967 Prefer int to unsigned where either will do.
1968 (tiff_handler): New function, combining the cores of the
1969 old tiff_error_handler and tiff_warning_handler.
1970 This function is rewritten to use vsnprintf and thereby avoid
1971 stack buffer overflows. It uses only the features of vsnprintf
1972 that are common to both POSIX and native Microsoft.
1973 (tiff_error_handler, tiff_warning_handler): Use it.
1974 (tiff_load, gif_load, imagemagick_load_image):
1975 Don't assume :index value fits in 'int'.
1976 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1977 (imagemagick_load_image): Check that crop parameters fit into
1978 the integer types that MagickCropImage accepts. Don't assume
1979 Vimagemagick_render_type has a nonnegative value. Don't assume
1980 size_t fits in 'long'.
1981 (gs_load): Use printmax_t to print the widest integers possible.
1982 Check for integer overflow when computing image height and width.
1984 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1986 * xdisp.c (redisplay_window): Don't force window start if point
1987 will be invisible in the resulting window. (Bug#9324)
1989 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1991 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1992 the display spec is of the form `(space ...)'.
1993 (handle_display_spec): Return the value returned by
1994 handle_single_display_spec, not just 1 or zero.
1995 (handle_single_display_spec): If the display spec is of the form
1996 `(space ...)', and specifies display in the text area, return 2
1998 (try_cursor_movement): Check for the need to scroll more
1999 accurately, and prefer exact match for point under bidi.
2000 Don't advance `row' beyond the last row of the window.
2002 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2003 into disp_prop; all users changed.
2005 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2006 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2007 for the text covered by the display property.
2009 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2011 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2012 Change return value to nil.
2013 (Frecord_buffer): Delete unused function.
2015 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2017 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2018 buffers, return left-to-right.
2019 (set_cursor_from_row): Consider candidate row a win if its glyph
2020 represents a newline and point is on that newline. Fixes cursor
2021 positioning on the newline at EOL of R2L text within L2R
2022 paragraph, and vice versa.
2023 (try_cursor_movement): Check continued rows, in addition to
2024 continuation rows. Fixes unwarranted scroll when point enters a
2025 continued line of R2L text within an L2R paragraph, or vice versa.
2026 (cursor_row_p): Consider the case of point being equal to
2027 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2028 from the end of a short line to the beginning of a continued line
2029 of R2L text within L2R paragraph.
2030 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2031 composed characters.
2033 * bidi.c (bidi_check_type): Use xassert.
2034 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2037 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2039 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2042 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2044 * nsfont.m (ns_otf_to_script): Fix typo.
2046 2011-08-22 Kenichi Handa <handa@m17n.org>
2048 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2049 extra slot even if the purpose is char-code-property-table.
2051 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2053 * xdisp.c (redisplay_window): When computing centering_position,
2054 account for the height of the header line. (Bug#8874)
2056 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2057 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2058 candidate is selected by the mouse, and that candidate has a
2059 composed character under the mouse.
2061 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2062 coordinates reported by pos-visible-in-window-p for a composed
2063 character in column zero.
2065 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2067 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2069 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2071 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2072 consider it a hit if to_charpos is anywhere in the range of the
2073 composed buffer positions.
2075 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2077 * image.c (gif_load): Don't assume that each subimage has the same
2078 dimensions as the base image. Handle disposal method that is
2079 "undefined" by the gif spec (Bug#9335).
2081 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2083 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2084 (Fcondition_case): Document `debug' symbol in error handler.
2086 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2088 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2089 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2090 from an Org mode buffer to a Speedbar frame.
2092 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2093 a composition, take its buffer position from IT->cmp_it.charpos.
2094 Fixes cursor positioning at the beginning of a line that begins
2095 with a composed character.
2097 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2099 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2100 character bidirectional type, use STRONG_L instead. Fixes crashes
2101 in a buffer produced by `describe-categories'.
2103 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2104 members before the level stack, so they would be saved and
2105 restored when copying iterator state. Fixes incorrect reordering
2106 around TABs covered by display properties.
2108 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2110 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2112 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2114 * eval.c (internal_condition_case, internal_condition_case_1)
2115 (internal_condition_case_2, internal_condition_case_n):
2116 Remove unnecessary aborts (Bug#9081).
2118 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2120 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2121 has no `load' handler, try opening the file locally. (Bug#9311)
2123 2011-08-16 Ken Brown <kbrown@cornell.edu>
2125 * gmalloc.c: Expand comment.
2127 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2129 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2130 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2132 2011-08-16 Ken Brown <kbrown@cornell.edu>
2134 Fix memory allocation problems in Cygwin build (Bug#9273).
2136 * unexcw.c ( __malloc_initialized): Declare external variable.
2137 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2139 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2141 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2143 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2145 [CYGWIN] (special_realloc): New function.
2146 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2147 requests to realloc storage in the static heap.
2149 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2151 * bidi.c (bidi_initialize): Remove unused local.
2153 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2156 * biditype.h: Remove file.
2157 * makefile.w32-in ($(BLD)/bidi.$(O)):
2158 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2160 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2162 * chartab.c: Improve commentary for the uniprop_table API.
2164 * bidi.c (bidi_paragraph_init): Support zero value of
2165 bidi_ignore_explicit_marks_for_paragraph_level.
2166 (bidi_initialize): Use uniprop_table instead of including
2167 biditype.h and bidimirror.h.
2169 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2170 coordinates of the iterator when restoring from ppos_it.
2173 2011-08-14 Kenichi Handa <handa@m17n.org>
2175 * process.c (create_process): Call setup_process_coding_systems
2176 after the pid of the process is set to -1 (Bug#8162).
2178 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2180 * xdisp.c (move_it_in_display_line_to): Don't invoke
2181 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2182 ppos_it. Fixes vertical cursor motion when line beginning is
2183 covered by an image. (Bug#9296)
2185 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2187 * nsterm.h (ns_run_ascript): Declare.
2188 (NSAPP_DATA2_RUNASSCRIPT): Define.
2190 * nsfns.m (as_script, as_result, as_status): New static variables.
2191 (ns_run_ascript): New function.
2192 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2193 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2194 the event loop. Get status from as_status (Bug#7276).
2196 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2197 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2198 the event loop (Bug#7276).
2200 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2202 * gnutls.c (QCgnutls_bootprop_priority)
2203 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2204 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2205 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2206 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2207 (QCgnutls_bootprop_verify_hostname_error)
2208 (QCgnutls_bootprop_callbacks_verify): Rename from
2209 Qgnutls_bootprop_..., all uses changed.
2211 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2214 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2216 * xfaces.c (Qframe_set_background_mode): Now static.
2217 * dispextern.h (Qframe_set_background_mode): Remove decl.
2219 * process.c (Fnetwork_interface_info): Declare local only if needed.
2221 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2223 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2224 (Fnetwork_interface_list): Allocate in increments of bytes instead
2225 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2226 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2228 (struct ifflag_def): notrailers is smart on OSX.
2229 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2230 Get hardware address with getifaddrs if available.
2232 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2234 * xdisp.c (iterate_out_of_display_property): xassert that
2235 IT->position is set to within IT->object's boundaries. Break from
2236 the loop as soon as EOB is reached; avoids infloops in redisplay
2237 when IT->position is set up wrongly due to some bug.
2238 Set IT->current to match the bidi iterator unconditionally.
2239 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2240 entry. Force push_it to save on the stack the current
2241 buffer/string position, to be restored by pop_it. Fix flags in
2242 the iterator structure wrt the object coming from a display
2243 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2244 properties. (Bug#9284)
2246 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2248 * fontset.c (fontset_get_font_group): Add proper type checks.
2251 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2253 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2254 and LC_VERSION_MIN_MACOSX.
2255 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2256 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2258 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2260 * xdisp.c (forward_to_next_line_start): Allow to use the
2261 no-display-properties-and-no-overlays under bidi display.
2262 Set disp_pos in the bidi iterator to avoid searches for display
2263 properties and overlays.
2265 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2267 * editfns.c (Fset_time_zone_rule): Document relationship with the
2270 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2271 the font entity extracted from the cache (Bug#8109).
2273 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2275 * composite.c (autocmp_chars): Don't reset point. That is done by
2276 restore_point_unwind (Bug#5984).
2278 2011-08-07 Juri Linkov <juri@jurta.org>
2280 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2281 to show the arg `TIME' instead of `TIMEVAL'.
2283 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2285 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2286 display property strides EOL and includes a newline, as in
2287 longlines-mode. (Bug#9254)
2288 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2289 word-wrap under bidirectional display. (Bug#9224)
2291 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2292 is non-zero, even if the data buffer is NULL. Fixes a crash in
2293 vertical-motion with longlines-mode. (Bug#9254)
2295 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2297 * bidi.c <bidi_cache_total_alloc>: Now static.
2298 (bidi_initialize): Initialize bidi_cache_total_alloc.
2300 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2303 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2304 amount allocated this far in `bidi_cache_total_alloc'.
2305 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2306 non-zero, only free the data buffer without restoring the cache
2307 contents. All callers changed.
2309 * dispextern.h (bidi_unshelve_cache): Update prototype.
2311 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2312 (move_it_in_display_line, move_it_to)
2313 (move_it_vertically_backward, move_it_by_lines): Replace the call
2314 to xfree to an equivalent call to bidi_unshelve_cache.
2315 (move_it_in_display_line_to): Fix logic of returning
2316 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2318 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2320 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2321 came from a string character with a `cursor' property. (Bug#9229)
2323 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2325 * Makefile.in (LIB_PTHREAD): New variable.
2326 (LIBES): Add LIB_PTHREAD (Bug#9216).
2328 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2329 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2331 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2333 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2335 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2337 * xterm.c (x_find_topmost_parent): New function.
2338 (x_set_frame_alpha): Find topmost parent window with
2339 x_find_topmost_parent and set the property there also (bug#9181).
2340 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2342 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2344 * callproc.c (Fcall_process): Avoid vfork clobbering
2345 the local vars buffer, coding_systems, current_dir.
2347 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2349 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2351 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2353 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2354 so that it is not optimized away.
2356 * xdisp.c (compute_display_string_pos): Remove unused local.
2358 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2360 Fix slow cursor motion and scrolling in large buffers with
2361 selective display, like Org Mode buffers. (Bug#9218)
2363 * dispextern.h (struct bidi_it): New member disp_prop_p.
2365 * xdisp.c: Remove one-slot cache of display string positions.
2366 (compute_display_string_pos): Accept an additional argument
2367 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2368 for a display string or property. If found, set DISP_PROP_P
2371 * bidi.c (bidi_fetch_char): Accept an additional argument
2372 DISP_PROP_P, and pass it to compute_display_string_pos.
2373 Only handle text covered by a display string if DISP_PROP_P is returned
2374 non-zero. All callers of bidi_fetch_char changed.
2376 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2378 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2380 2010-12-03 Don March <don@ohspite.net>
2382 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2383 last character M-[char] is translated to ESC [char] (bug#7541).
2385 2011-08-02 Kenichi Handa <handa@m17n.org>
2387 * lisp.h (uniprop_table): Extern it.
2389 * chartab.c (uniprop_table): Make it non-static.
2391 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2393 * xdisp.c (forward_to_next_line_start): Accept additional argument
2394 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2396 (reseat_at_next_visible_line_start): Use the bidi iterator state
2397 returned by forward_to_next_line_start to restore the state of
2398 it->bidi_it after backing up to previous newline. (Bug#9212)
2400 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2402 * regex.c (re_comp): Protoize.
2403 (re_exec): Fix return type.
2404 (regexec): Fix type of `ret'. (Bug#9203)
2406 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2408 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2409 This is needed if max-image-size is a floating-point number.
2411 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2413 * print.c (print_object): Print empty symbol as ##.
2415 * lread.c (read1): Read ## as empty symbol.
2417 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2419 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2420 setting frame foreground color (Bug#9175).
2421 (x_set_background_color): Likewise.
2423 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2424 contents (Bug#9176).
2425 (EmacsTooltip -init): Remove bezels and add shadows to
2428 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2429 or scroll bar (Bug#8470).
2431 * nsfont.m (nsfont_open): Remove assignment to voffset and
2432 unnecessary vars hshink, expand, hd, full_height, min_height.
2433 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2435 * nsterm.h (nsfont_info): Remove voffset field.
2437 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2439 Implement strike-through and overline on NextStep (Bug#8863).
2441 * nsfont.m (nsfont_open): Use underline position provided by font,
2442 instead of hard-coded value of 2.
2443 (nsfont_draw): Call ns_draw_text_decoration instead.
2445 * nsterm.h: Add declaration for ns_draw_text_decoration.
2447 * nsterm.m (ns_draw_text_decoration): New function for drawing
2448 underline, overline, and strike-through.
2449 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2450 ns_draw_text_decoration. Change treatment of cursor drawing to
2451 accommodate underlining, etc.
2453 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2455 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2458 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2460 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2461 Without this fix, if a signal arrives just after memory fills up,
2462 'malloc' might be invoked reentrantly.
2464 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2465 In other words, assume that every image size is allowed, on non-X
2466 hosts. This assumption is probably wrong, but it lets Emacs compile.
2468 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2470 * regex.c (re_iswctype): Convert return values to boolean.
2472 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2474 * xdisp.c (compute_display_string_pos): Don't use cached display
2475 string position if the buffer had its restriction changed.
2478 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2480 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2482 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2484 Integer signedness and overflow and related fixes. (Bug#9079)
2486 * bidi.c: Integer size and overflow fixes.
2487 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2488 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2489 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2490 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2491 (bidi_find_other_level_edge):
2492 Use ptrdiff_t instead of EMACS_INT where either will do.
2493 This works better on 32-bit hosts configured --with-wide-int.
2494 (bidi_cache_ensure_space): Check for size-calculation overflow.
2495 Use % rather than repeated addition, for better worst-case speed.
2496 Don't set bidi_cache_size until after xrealloc returns, because it
2498 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2499 (bidi_cache_ensure_space): Also check that the bidi cache size
2500 does not exceed that of the largest Lisp string or buffer. See Eli
2501 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2503 * alloc.c (__malloc_size_t): Remove.
2504 All uses replaced by size_t. See Andreas Schwab's note
2505 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2507 * image.c: Improve checking for integer overflow.
2508 (check_image_size): Assume that f is nonnull, since
2509 it is always nonnull in practice. This is one less thing to
2510 worry about when checking for integer overflow later.
2511 (x_check_image_size): New function, which checks for integer
2512 overflow issues inside X.
2513 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2514 This removes the need for a memory_full check.
2515 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2516 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2517 (xbm_read_bitmap_data): Change locals back to 'int', since
2518 their values must fit in 'int'.
2519 (xpm_load_image, png_load, tiff_load):
2520 Invoke x_create_x_image_and_pixmap earlier,
2521 to avoid much needless work if the image is too large.
2522 (tiff_load): Treat overly large images as if
2523 x_create_x_image_and_pixmap failed, not as malloc failures.
2524 (gs_load): Use x_check_image_size.
2526 * gtkutil.c: Omit integer casts.
2527 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2528 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2530 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2532 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2533 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2534 would wrongly return t on a 64-bit host.
2536 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2537 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2538 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2539 and therefore cause GCC to emit a bogus diagnostic in some cases.
2541 * image.c: Integer signedness and overflow and related fixes.
2542 This is not an exhaustive set of fixes, but it's time to
2543 record what I've got.
2544 (lookup_pixel_color, check_image_size): Remove redundant decls.
2545 (check_image_size): Don't assume that arbitrary EMACS_INT values
2546 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2547 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2548 (tiff_load, imagemagick_load_image):
2549 Check for overflow in size calculations.
2550 (x_create_x_image_and_pixmap): Remove unnecessary test for
2551 xmalloc returning NULL; that can't happen.
2552 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2553 (xpm_color_bucket): Use better integer hashing function.
2554 (xpm_cache_color): Don't possibly over-allocate memory.
2555 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2556 (gif_memory_source):
2557 Use ptrdiff_t, not int or size_t, to record sizes.
2558 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2559 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2560 either works, as we prefer signed integers.
2561 (tiff_read_from_memory, tiff_write_from_memory):
2562 Return tsize_t, not size_t, since that's what the TIFF API wants.
2563 (tiff_read_from_memory): Don't fail simply because the read would
2564 go past EOF; instead, return a short read.
2565 (tiff_load): Omit no-longer-needed casts.
2566 (Fimagemagick_types): Don't assume size fits into 'int'.
2568 Improve hashing quality when configured --with-wide-int.
2569 * fns.c (hash_string): New function, taken from sxhash_string.
2570 Do not discard information about ASCII character case; this
2571 discarding is no longer needed.
2572 (sxhash-string): Use it. Change sig to match it. Caller changed.
2573 * lisp.h: Declare it.
2574 * lread.c (hash_string): Remove, since we now use fns.c's version.
2575 The fns.c version returns a wider integer if --with-wide-int is
2576 specified, so this should help the quality of the hashing a bit.
2578 * emacs.c: Integer overflow minor fix.
2579 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2580 Define only if GNU_LINUX.
2581 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2583 * dispnew.c: Integer signedness and overflow fixes.
2584 Remove unnecessary forward decls, that were a maintenance hassle.
2585 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2587 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2588 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2589 (prepare_desired_row, line_draw_cost):
2590 Use int, not unsigned, where either works.
2591 (save_current_matrix, restore_current_matrix):
2592 Use ptrdiff_t, not size_t, where either works.
2593 (init_display): Check for overflow more accurately, and without
2594 relying on undefined behavior.
2596 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2597 Remove, replacing with the new symbols in lisp.h. All uses changed.
2598 * fileio.c (make_temp_name):
2599 * filelock.c (lock_file_1, lock_file):
2600 * xdisp.c (message_dolog):
2601 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2602 Use pMd etc. instead.
2603 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2604 replacing the pWIDE etc. symbols removed from editfns.c.
2606 * keyboard.h (num_input_events): Now uintmax_t.
2607 This is (very slightly) less likely to mess up due to wraparound.
2610 * buffer.c: Integer signedness fixes.
2611 (alloc_buffer_text, enlarge_buffer_text):
2612 Use ptrdiff_t rather than size_t when either will do, as we prefer
2615 * alloc.c: Integer signedness and overflow fixes.
2616 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2617 (__malloc_size_t): Default to size_t, not to int.
2618 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2619 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2620 Prefer ptrdiff_t to size_t when either would do, as we prefer
2622 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2623 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2624 Now const. Initialize with values that are in range even if char
2626 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2627 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2628 These functions do the right thing with sizes > 2**32.
2629 (check_depth): Now ptrdiff_t, not int.
2630 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2631 Adjust to new way of storing sizes. Check for size overflow bugs
2633 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2634 slightly wrong anyway, as it missed one instance of
2635 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2636 (refill_memory_reserve): Omit needless cast to size_t.
2637 (mark_object_loop_halt): Mark as externally visible.
2639 * xselect.c: Integer signedness and overflow fixes.
2640 (Fx_register_dnd_atom, x_handle_dnd_message):
2641 Use ptrdiff_t, not size_t, since we prefer signed.
2642 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2643 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2644 x_dnd_atoms_size and x_dnd_atoms_length.
2646 * doprnt.c: Prefer signed to unsigned when either works.
2648 * doprnt.c (doprnt):
2650 * xdisp.c (vmessage):
2651 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2652 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2653 prefer signed arithmetic to avoid comparison confusion.
2654 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2655 but is a bit tricky.
2657 Assume freestanding C89 headers, string.h, stdlib.h.
2658 * data.c, doprnt.c, floatfns.c, print.c:
2659 Include float.h unconditionally.
2660 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2661 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2662 * regex.c: Likewise for stddef.h, string.h.
2663 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2664 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2665 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2666 (STDC_HEADERS): Remove obsolete defines.
2667 * sysdep.c: Include limits.h unconditionally.
2669 Assume support for memcmp, memcpy, memmove, memset.
2670 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2671 * regex.c (memcmp, memcpy):
2672 Remove; we assume C89 now.
2674 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2675 (__malloc_safe_bcopy): Remove; no longer needed.
2677 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
2678 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2679 well either way, and we prefer signed to unsigned.
2681 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2683 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2684 closes the connection while we're reading (bug#9182).
2686 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
2688 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2689 are specified (Bug#9168).
2691 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2693 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2694 Found by GCC static checking and --with-wide-int on a 32-bit host.
2696 2011-07-25 Eli Zaretskii <eliz@gnu.org>
2698 * xdisp.c (compute_display_string_pos): Fix logic of caching
2699 previous display string position. Initialize cached_prev_pos to
2700 -1. Fixes slow-down at the beginning of a buffer.
2702 2011-07-24 Eli Zaretskii <eliz@gnu.org>
2704 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2705 for attrs[LFACE_FONTSET_INDEX].
2707 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2709 * xml.c (parse_region): Remove unused local
2710 that was recently introduced.
2712 2011-07-23 Eli Zaretskii <eliz@gnu.org>
2714 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2715 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2717 * xdisp.c (move_it_in_display_line_to): Record the best matching
2718 position for TO_CHARPOS while scanning the line, and restore it on
2719 exit if none of the characters scanned was an exact match.
2720 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
2721 when exact match is impossible due to invisible text, and the
2722 lines are truncated.
2724 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2726 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2729 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2731 Fix a significant slow-down of cursor motion with C-n, C-p,
2732 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2733 auto-repeat under bidi redisplay in fontified buffers.
2734 * xdisp.c (compute_stop_pos_backwards): New function.
2735 (next_element_from_buffer): Call compute_stop_pos_backwards to
2736 find a suitable prev_stop when we find ourselves before
2738 (reseat): Don't look for prev_stop, as that could mean a very long
2740 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2741 <cached_disp_overlay_modiff>: Cache for last found display string
2743 (compute_display_string_pos): Return the cached position if asked
2744 about the same buffer in the same area of character positions, and
2745 the buffer wasn't changed since the time the display string
2746 position was cached.
2748 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2750 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2751 is an integer, which is important for empty lines. (Bug#9149)
2753 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
2755 * frame.c (Fmodify_frame_parameters): In tty case, update the
2756 default face if necessary (Bug#4238).
2758 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
2760 * editfns.c (Fstring_to_char): No need to explain what a character
2761 is in the docstring (Bug#6576).
2763 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2765 * xml.c (parse_region): Make sure we always return a tree.
2767 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2769 * xml.c (parse_region): If a document contains only comments,
2772 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2774 * xml.c (make_dom): Return comments, too.
2776 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2779 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2780 and the surrounding thread.
2781 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2782 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2783 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2785 * s/openbsd.h (BROKEN_SIGIO): Define.
2786 * unexelf.c (unexec) [__OpenBSD__]:
2787 Don't update the .mdebug section of the Alpha COFF symbol table.
2789 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2791 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2794 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2796 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2797 This fixes some race conditions on the permissions of any newly
2800 * alloc.c (valid_pointer_p): Use pipe, not open.
2801 This fixes some permissions issues when debugging.
2803 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2804 If fchown fails to set both uid and gid, try to set just gid,
2805 as that is sometimes allowed. Adjust the file's mode to eliminate
2806 setuid or setgid bits that are inappropriate if fchown fails.
2808 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2810 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2811 to compare Lisp_Objects.
2812 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2813 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2814 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2816 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2818 * lread.c (read_integer): Unread even EOF character.
2819 (read1): Likewise. Properly record start position of symbol.
2821 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2822 symbol character follows.
2824 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2826 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2827 This works around a problem with the previous change to Fcopy_file.
2828 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2829 and without this change, GCC might complain about discarding
2830 fchown's return value.
2832 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
2834 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2836 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2838 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2840 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2842 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2843 it's used from the C level.
2845 * process.c: Use the same condition for POLL_FOR_INPUT in both
2846 keyboard.c and process.c (bug#1858).
2848 2011-07-09 Lawrence Mitchell <wence@gmx.li>
2850 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2851 (Fgnutls_boot): Use it.
2853 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2855 * doc.c (Fsubstitute_command_keys): Revert last change.
2857 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2859 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2860 quotes the next character, and doesn't affect other longer
2861 sequences (bug#8935).
2863 * lread.c (syms_of_lread): Clarify that is isn't only
2864 `eval-buffer' and `eval-defun' that's affected by
2865 `lexical-binding' (bug#8460).
2867 2011-07-15 Eli Zaretskii <eliz@gnu.org>
2869 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2870 bidi redisplay when a line includes both an image and is truncated.
2872 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2874 Fix minor problems found by static checking.
2875 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2876 (elsz): Now a signed constant, not a size_t var. We prefer signed
2877 types to unsigned, to avoid integer comparison confusion. Without
2878 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2879 "cannot optimize loop, the loop counter may overflow", a symptom
2881 * indent.c (Fvertical_motion): Mark locals as initialized.
2882 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2884 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2886 * search.c (Fre_search_backward): Mention `case-fold-search' in
2887 all the re_search_* functions (bug#8138).
2889 * keyboard.c (Fopen_dribble_file): Document when the file is
2892 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2894 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2897 Support bidi reordering of display and overlay strings.
2898 * xdisp.c (compute_display_string_pos)
2899 (compute_display_string_end): Accept additional argument STRING.
2900 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2901 (reseat_to_string): Initialize bidi_it->string.s and
2902 bidi_it->string.schars.
2903 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2904 NULL (avoids a crash in bidi_paragraph_init).
2905 Initialize itb.string.lstring.
2906 (init_iterator): Call bidi_init_it only of a valid
2907 buffer position was specified. Initialize paragraph_embedding to
2909 (reseat_to_string): Initialize the bidi iterator.
2910 (display_string): If we need to ignore text properties of
2911 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2912 original value of -1 will not work with bidi.)
2913 (compute_display_string_pos): First arg is now struct
2914 `text_pos *'; all callers changed. Support display properties on
2916 (compute_display_string_end): Support display properties on Lisp
2918 (init_iterator, reseat_1, reseat_to_string): Initialize the
2919 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2920 when iterating on a string not from display properties).
2921 (compute_display_string_pos, compute_display_string_end):
2922 Fix calculation of the object to scan. Fixes an error when using
2924 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2925 base_level_stop; instead, set base_level_stop to BEGV.
2926 Fixes crashes in vertical-motion.
2927 (next_element_from_buffer): Improve commentary for when
2928 the iterator is before prev_stop.
2929 (init_iterator): Initialize bidi_p from the default value of
2930 bidi-display-reordering, not from buffer-local value. Use the
2931 buffer-local value only if initializing for buffer iteration.
2932 (handle_invisible_prop): Support invisible properties on strings
2933 that are being bidi-reordered.
2934 (set_iterator_to_next): Support bidi reordering of C strings and
2936 (next_element_from_string): Support bidi reordering of Lisp
2938 (handle_stop_backwards): Support Lisp strings as well.
2939 (display_string): Support display of R2L glyph rows.
2940 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2941 (init_iterator): Don't initialize it->bidi_p for strings
2943 (reseat_to_string): Initialize it->bidi_p for strings here.
2944 (next_element_from_string, next_element_from_c_string)
2945 (next_element_from_buffer): Add xassert's for correspondence
2946 between IT's object being iterated and it->bidi_it.string
2948 (face_before_or_after_it_pos): Support bidi iteration.
2949 (next_element_from_c_string): Handle the case of the first string
2950 character that is not the first one in the visual order.
2951 (get_visually_first_element): New function, refactored from common
2952 parts of next_element_from_buffer, next_element_from_string, and
2953 next_element_from_c_string.
2954 (tool_bar_lines_needed, redisplay_tool_bar)
2955 (display_menu_bar): Force left-to-right direction. Add a FIXME
2956 comment for making that be controlled by a user option.
2957 (push_it, pop_it): Save and restore the state of the
2958 bidi iterator. Save and restore the bidi_p flag.
2959 (pop_it): Iterate out of display property for string iteration as
2961 (iterate_out_of_display_property): Support iteration over strings.
2962 (handle_single_display_spec): Set up it->bidi_it for iteration
2963 over a display string, and call bidi_init_it.
2964 (handle_single_display_spec, next_overlay_string)
2965 (get_overlay_strings_1, push_display_prop): Set up the bidi
2966 iterator for displaying display or overlay strings.
2967 (forward_to_next_line_start): Don't use the shortcut if
2969 (back_to_previous_visible_line_start): If handle_display_prop
2970 pushed the iterator stack, restore the internal state of the bidi
2971 iterator by calling bidi_pop_it same number of times.
2972 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2973 and we are bidi-iterating, don't decrement the iterator position;
2974 instead, set the first_elt flag in the bidi iterator, to produce
2976 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2977 (push_display_prop): xassert that we are iterating a buffer.
2978 (push_it, pop_it): Save and restore paragraph_embedding member.
2979 (handle_single_display_spec, next_overlay_string)
2980 (get_overlay_strings_1, reseat_1, reseat_to_string)
2981 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2982 correctly. Don't assume unibyte strings are not bidi-reordered.
2983 (compute_display_string_pos)
2984 (compute_display_string_end): Fix handling the case of C string.
2985 (push_it, pop_it): Save and restore from_disp_prop_p.
2986 (handle_single_display_spec, push_display_prop): Set the
2987 from_disp_prop_p flag.
2988 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2989 (pop_it): Call iterate_out_of_display_property only if we are
2990 popping after iteration over a string that came from a display
2991 property. Fix a typo in popping stretch info. Add an assertion
2992 for verifying that the iterator position is in sync with the bidi
2994 (handle_single_display_spec, get_overlay_strings_1)
2995 (push_display_prop): Fix initialization of paragraph direction for
2996 string when that of the parent object is not yet determined.
2997 (reseat_1): Call bidi_init_it to resync the bidi
2998 iterator with IT's position. (Bug#7616)
2999 (find_row_edges): If ROW->start.pos gives position
3000 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3001 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3002 Reset the from_disp_prop_p flag.
3003 (SAVE_IT, RESTORE_IT): New macros.
3004 (pos_visible_p, face_before_or_after_it_pos)
3005 (back_to_previous_visible_line_start)
3006 (move_it_in_display_line_to, move_it_in_display_line)
3007 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3008 (try_scrolling, redisplay_window, display_line): Use them when
3009 saving a temporary copy of the iterator and restoring it back.
3010 (back_to_previous_visible_line_start, reseat_1)
3011 (init_iterator): Empty the bidi cache "stack".
3012 (move_it_in_display_line_to): If iterator ended up at
3013 EOL, but we never saw any buffer positions smaller than
3014 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3015 motion in bidi-reordered lines.
3016 (move_it_in_display_line_to): Record prev_method and prev_pos
3017 immediately before the call to set_iterator_to_next. Fixes cursor
3018 motion in bidi-reordered lines with stretch glyphs and strings
3019 displayed in margins. (Bug#8133) (Bug#8867)
3020 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3022 (pos_visible_p): Support positions in bidi-reordered lines.
3023 Save and restore bidi cache.
3025 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3026 (bidi_paragraph_info): Delete unused struct.
3027 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3028 (bidi_cache_start): New variable.
3029 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3031 (bidi_cache_fetch_state, bidi_cache_search)
3032 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3033 (bidi_cache_find, bidi_peek_at_next_level)
3034 (bidi_level_of_next_char, bidi_find_other_level_edge)
3035 (bidi_move_to_visually_next): Compare cache index with
3036 bidi_cache_start rather than with zero.
3037 (bidi_fetch_char): Accept new argument STRING; all callers
3038 changed. Support iteration over a string. Support strings with
3039 display properties. Support unibyte strings. Fix the type of
3040 `len' according to what STRING_CHAR_AND_LENGTH expects.
3041 (bidi_paragraph_init, bidi_resolve_explicit_1)
3042 (bidi_resolve_explicit, bidi_resolve_weak)
3043 (bidi_level_of_next_char, bidi_move_to_visually_next):
3044 Support iteration over a string.
3045 (bidi_set_sor_type, bidi_resolve_explicit_1)
3046 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3047 can now be zero (for strings); special values 0 and -1 were
3048 changed to -1 and -2, respectively.
3049 (bidi_char_at_pos): New function.
3050 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3051 Call it instead of FETCH_MULTIBYTE_CHAR.
3052 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3053 initialized to valid values.
3054 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3056 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3057 the test for valid cached positions. Fix the logic for looking up
3058 the sentinel state in the cache. GCPRO the Lisp string we are
3060 (bidi_push_it, bidi_pop_it): New functions.
3061 (bidi_initialize): Initialize the bidi cache start stack pointer.
3062 (bidi_cache_ensure_space): New function, refactored from part of
3063 bidi_cache_iterator_state. Don't assume the required size is just
3064 one BIDI_CACHE_CHUNK away.
3065 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3066 (bidi_count_bytes, bidi_char_at_pos): New functions.
3067 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3068 always valid if bidi_cache_idx is valid.
3069 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3070 is valid if it's going to be used.
3071 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3072 (bidi_cache_fetch_state, bidi_cache_search)
3073 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3074 (bidi_cache_iterator_state, bidi_cache_find)
3075 (bidi_find_other_level_edge, bidi_cache_start_stack):
3076 All variables related to cache indices are now EMACS_INT.
3078 * dispextern.h (struct bidi_string_data): New structure.
3079 (struct bidi_it): New member `string'. Make flag members be 1-bit
3080 fields, and put them last in the struct.
3081 (compute_display_string_pos, compute_display_string_end):
3083 (bidi_push_it, bidi_pop_it): Add prototypes.
3084 (struct iterator_stack_entry): New members bidi_p,
3085 paragraph_embedding, and from_disp_prop_p.
3086 (struct it): Member bidi_p is now a bit field 1 bit wide.
3087 (bidi_shelve_cache, bidi_unshelve_cache):
3090 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3091 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3092 and vector-like objects.
3094 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3095 cache around display iteration.
3097 * window.c (Fwindow_end, window_scroll_pixel_based)
3098 (displayed_window_lines, Frecenter): Save and restore the bidi
3099 cache around display iteration.
3101 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3103 * editfns.c (Fdelete_region): Clarify the use of the named
3104 parameters (bug#6788).
3106 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3108 * indent.c (Fvertical_motion): Set and restore w->pointm when
3109 saving and restoring the window's buffer (Bug#9006).
3111 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3113 * editfns.c (Fstring_to_char): Clarify just what is returned
3114 (bug#6576). Text by Eli Zaretskii.
3116 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3118 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3120 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3122 * buffer.c (mmap_find): Fix a typo.
3124 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3126 Fix execution of x selection hooks.
3127 * xselect.c (Qx_lost_selection_functions)
3128 (Qx_sent_selection_functions): New vars.
3129 (syms_of_xselect): DEFSYM them.
3130 (x_handle_selection_request): Pass Qx_sent_selection_functions
3131 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3132 (x_handle_selection_clear,x_clear_frame_selections):
3133 Pass Qx_lost_selection_functions rather than
3134 Vx_lost_selection_functions to Frun_hook_with_args.
3136 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3138 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3139 The old code sometimes used this field without initializing it.
3141 * alloc.c (gc_sweep): Don't read past end of array.
3142 In theory, the old code could also have corrupted Emacs internals,
3143 though it'd be very unlikely.
3145 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3147 * character.c (Fcharacterp): Don't advertise optional ignored
3148 argument. (Bug#4026)
3150 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3152 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3155 * window.c (Fset_window_start): Doc fix (bug#4199).
3156 (Fset_window_hscroll): Ditto.
3158 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3160 Fix minor new problems caught by GCC 4.6.1.
3161 * term.c (init_tty): Remove unused local.
3162 * xsettings.c (store_monospaced_changed): Define this function only
3163 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3166 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3168 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3170 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3172 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3173 are the mini-buffer and the echo area (bug#3320).
3175 * term.c (init_tty): Remove support for supdup, c10 and perq
3176 terminals, which are no longer supported (bug#1482).
3178 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3180 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3182 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3184 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3185 for non-popups (Bug#3642).
3187 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3189 * alloc.c (reset_malloc_hooks): Protoize.
3190 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3191 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3192 * cm.c (losecursor): Likewise.
3193 * data.c (fmod): Likewise.
3194 * dispnew.c (swap_glyphs_in_rows): Likewise.
3195 * emacs.c (memory_warning_signal): Likewise.
3196 * floatfns.c (float_error): Likewise.
3197 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3198 (otf_open, font_otf_capability, generate_otf_features)
3199 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3201 * image.c (pbm_read_file): Likewise.
3202 * indent.c (string_display_width): Likewise.
3203 * intervals.c (check_for_interval, search_for_interval)
3204 (inc_interval_count, count_intervals, root_interval)
3205 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3206 * lread.c (defalias): Likewise.
3207 * ralloc.c (r_alloc_check): Likewise.
3208 * regex.c (set_image_of_range_1, set_image_of_range)
3209 (regex_grow_registers): Likewise.
3210 * sysdep.c (strerror): Likewise.
3211 * termcap.c (valid_filename_p, tprint, main): Likewise.
3212 * tparam.c (main): Likewise.
3213 * unexhp9k800.c (run_time_remap, save_data_space)
3214 (update_file_ptrs, read_header, write_header, calculate_checksum)
3215 (copy_file, copy_rest, display_header): Likewise.
3216 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3218 * xdisp.c (check_it): Likewise.
3219 * xfaces.c (register_color, unregister_color, unregister_colors):
3221 * xfns.c (print_fontset_result): Likewise.
3222 * xrdb.c (member, fatal, main): Likewise.
3224 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3226 Fix minor problems found by static checking (Bug#9031).
3227 * chartab.c (char_table_set_range, map_sub_char_table):
3228 Remove unused locals.
3229 (uniprop_table): Now static.
3230 * composite.c (_work_char): Remove unused static var.
3232 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3234 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3236 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3238 * gtkutil.c (qttip_cb): Remove code without function.
3240 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3242 * w32.c (pthread_sigmask): New stub.
3244 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3246 Use pthread_sigmask, not sigprocmask (Bug#9010).
3247 sigprocmask is portable only for single-threaded applications, and
3248 Emacs can be multi-threaded when it uses GTK.
3249 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3251 * callproc.c (Fcall_process):
3252 * process.c (create_process):
3253 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3254 Use pthread_sigmask, not sigprocmask.
3256 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3258 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3259 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3262 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3264 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3265 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3266 (xg_hide_tooltip): Fix comment.
3268 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3269 in registerServicesMenuSendTypes.
3270 (validRequestorForSendType): Don't check ns_return_types.
3272 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3275 2011-07-08 Jason Rumney <jasonr@gnu.org>
3277 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3278 SH_SHOW for hidden windows (Bug#5482).
3280 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3281 frame struct members of non-existent frames (Bug#6284).
3283 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3285 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3286 variable firstTime not needed on OSX >= 10.6.
3287 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3288 >= 10.5. Use setKnobProportion, setDoubleValue.
3290 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3291 (MAC_OS_X_VERSION_10_5): Define if not defined.
3292 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3293 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3294 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3296 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3297 cString and lossyCString on OSX >= 10.4
3299 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3300 sizeToFit on OSX >= 10.2.
3302 * nsimage.m (allocInitFromFile): Don't use deprecated method
3303 bestRepresentationForDevice on OSX >= 10.6.
3305 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3308 * emacs.c: Declare unexec_init_emacs_zone.
3310 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3312 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3314 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3315 on svcsMenu (Bug#8842).
3317 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3319 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3321 * nsterm.m (QUTF8_STRING): Declare.
3322 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3323 (validRequestorForSendType): Return type is (id).
3324 Change indexOfObjectIdenticalTo to indexOfObject.
3325 Check if we have local selection before returning self (Bug#8842).
3326 (writeSelectionToPasteboard): Put local selection into paste board
3327 if we have a local selection (Bug#8842).
3328 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3330 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3331 (ns_get_local_selection): Declare.
3333 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3335 * keymap.c (describe_map_tree): Don't insert a double newline at
3336 the end of the buffer (bug#1169) and return whether we inserted
3339 * callint.c (Fcall_interactively): Change "reading args" to
3340 "providing args" to try to clarify what it does (bug#1010).
3342 2011-07-07 Kenichi Handa <handa@m17n.org>
3344 * composite.c (composition_compute_stop_pos): Ignore a static
3345 composition starting before CHARPOS (Bug#8915).
3347 * xdisp.c (handle_composition_prop): Likewise.
3349 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3351 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3354 2011-07-07 Kenichi Handa <handa@m17n.org>
3356 * character.h (unicode_category_t): New enum type.
3358 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3359 (Qchar_code_property_table): New variable.
3360 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3361 (UNIPROP_COMPRESSED_FORM_P): New macros.
3362 (char_table_ascii): Uncompress the compressed values.
3363 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3364 Uncompress the compressed values.
3365 (sub_char_table_ref_and_range): Likewise.
3366 (char_table_ref_and_range): Uncompress the compressed values.
3367 (sub_char_table_set): New arg is_uniprop. Callers changed.
3368 Uncompress the compressed values.
3369 (sub_char_table_set_range): Args changed. Callers changed.
3370 (char_table_set_range): Adjuted for the above change.
3371 (map_sub_char_table): Delete args default_val and parent. Add arg
3372 top. Give decoded values to a Lisp function.
3373 (map_char_table): Adjust for the above change. Give decoded
3374 values to a Lisp function. Gcpro more variables.
3375 (uniprop_table_uncompress)
3376 (uniprop_decode_value_run_length): New functions.
3377 (uniprop_decoder, uniprop_decoder_count): New variables.
3378 (uniprop_get_decoder, uniprop_encode_value_character)
3379 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3381 (uniprop_encoder, uniprop_encoder_count): New variables.
3382 (uniprop_get_encoder, uniprop_table)
3383 (Funicode_property_table_internal, Fget_unicode_property_internal)
3384 (Fput_unicode_property_internal): New functions.
3385 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3386 Sunicode_property_table_internal, Sget_unicode_property_internal,
3387 and Sput_unicode_property_internal. Defvar_lisp
3388 char-code-property-alist.
3390 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3391 Vunicode_category_table.
3393 * font.c (font_range): Adjust for the change of
3394 Vunicode_category_table.
3396 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3398 * m/iris4d.h: Remove file, move contents ...
3399 * s/irix6-5.h: ... here.
3401 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3403 Remove unportable assumption about struct layout (Bug#8884).
3404 * alloc.c (mark_buffer):
3405 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3406 (clone_per_buffer_values): Don't assume that
3407 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3408 This isn't true in general, and it's particularly not true
3409 if Emacs is configured with --with-wide-int.
3410 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3411 New macros, used in the buffer.c change.
3413 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3415 * xsettings.c: Use both GConf and GSettings if both are available.
3416 (store_config_changed_event): Add comment.
3417 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3418 (store_tool_bar_style_changed): New functions.
3419 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3420 (struct xsettings): Move font inside HAVE_XFT.
3421 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3422 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3423 Move inside HAVE_XFT.
3424 (something_changed_gsettingsCB): Rename from something_changedCB.
3425 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3427 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3428 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3429 (something_changed_gconfCB): Rename from something_changedCB.
3430 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3431 (parse_settings): Move check for font inside HAVE_XFT.
3432 (read_settings, apply_xft_settings): Add comment.
3433 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3434 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3435 call store_font_name_changed.
3436 (xft_settings_event): Add comment.
3437 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3438 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3439 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3440 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3441 (xsettings_initialize): Call init_gsettings last.
3442 (xsettings_get_system_font, xsettings_get_system_normal_font):
3445 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3447 Random fixes. E.g., (random) never returned negative values.
3448 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3449 subseconds part to the entropy, as that's a bit more random.
3450 Prefer signed to unsigned, since the signedness doesn't matter and
3451 in general we prefer signed. When given a limit, use a
3452 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3453 latter isn't right if USE_2_TAGS_FOR_INTS.
3454 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3455 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3457 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3459 * textprop.c (text_property_stickiness):
3460 Obey Vtext_property_default_nonsticky.
3461 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3462 * w32fns.c (syms_of_w32fns):
3463 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3465 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3467 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3468 This is more efficient than Ffile_directory_p and avoids a minor race.
3470 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3472 * buffer.c (Foverlay_put): Say what the return value is
3475 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3476 is a directory before asking whether to use the file name
3478 (barf_or_query_if_file_exists): Make the "File is a directory"
3479 error be more correct.
3481 * fns.c (Frequire): Remove the mention of the .gz files, since
3482 that's installation-specific, but keep the mention of
3483 `get-load-suffixes'.
3485 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3487 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3488 Report string overflow if the output is too long.
3490 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3492 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3493 (syms_of_gnutls): Remove duplicate DEFSYM for
3494 Qgnutls_bootprop_verify_hostname_error, an error for
3495 Qgnutls_bootprop_verify_error (which is no longer used).
3497 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3498 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3499 Also (re)move comments that are misplaced or no longer relevant.
3501 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3503 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3505 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3507 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3508 and background color parameters if they have been changed.
3510 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3512 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3514 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3516 * xsettings.c (SYSTEM_FONT): Define only when used.
3517 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3519 * keymap.c (access_keymap_1): Now static.
3521 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3523 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3524 leave any prefix arg for the up event (Bug#1586).
3526 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3528 * lread.c (syms_of_lread): Mention single symbols defined by
3529 `defvar' or `defconst' (bug#7154).
3531 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3532 (Frequire): Mention get-load-suffixes.
3534 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3536 * window.h (window): Remove clone_number slot.
3537 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3539 (make_parent_window, make_window, saved_window)
3540 (Fset_window_configuration, save_window_save): Don't deal with
3542 * buffer.c (Qclone_number): Remove declaration.
3543 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3545 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3547 Add multiple inheritance to keymaps.
3548 * keymap.c (Fmake_composed_keymap): New function.
3549 (Fset_keymap_parent): Simplify.
3550 (fix_submap_inheritance): Remove.
3551 (access_keymap_1): New function extracted from access_keymap to handle
3552 embedded parents and handle lists of maps.
3553 (access_keymap): Use it.
3554 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3555 (Fcopy_keymap): Handle embedded parents.
3556 (Fcommand_remapping, define_as_prefix): Simplify.
3557 (Fkey_binding): Simplify.
3558 (syms_of_keymap): Move minibuffer-local-completion-map,
3559 minibuffer-local-filename-completion-map,
3560 minibuffer-local-must-match-map, and
3561 minibuffer-local-filename-must-match-map to Elisp.
3562 (syms_of_keymap): Defsubr make-composed-keymap.
3563 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3564 (parse_menu_item): Trivial simplification.
3566 2011-07-01 Glenn Morris <rgm@gnu.org>
3568 * Makefile.in (SETTINGS_LIBS): Fix typo.
3570 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3572 * coding.c (Fencode_coding_string): Record the last coding system
3573 used, as the function doc string says (bug#8738).
3575 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3577 * xsettings.c (store_monospaced_changed): Take new font as arg and
3578 check for change against current_mono_font.
3579 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3580 (emacs_settings_constructor, emacs_settings_get_property)
3581 (emacs_settings_set_property, emacs_settings_class_init)
3582 (emacs_settings_init, gsettings_obj): Remove.
3583 (something_changedCB): New function for HAVE_GSETTINGS.
3584 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3585 with value as argument.
3586 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3587 g_settings_new (Bug#8967). Do not create gsettings_obj.
3588 Remove calls to g_settings_bind. Connect something_changedCB to
3591 * xgselect.c: Add defined (HAVE_GSETTINGS).
3592 (xgselect_initialize): Ditto.
3594 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3595 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3598 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3600 * eval.c (struct backtrace): Simplify and port the data structure.
3601 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3602 signed bit field, as this assumption is not portable and it makes
3603 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3604 "char debug_on_exit : 1" as this is not portable either; instead,
3605 use the portable "unsigned int debug_on_exit : 1". Remove unused
3606 member evalargs. Remove obsolete comments about cc bombing out.
3608 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3610 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3611 Let HAVE_GSETTINGS override HAVE_GCONF.
3612 (store_monospaced_changed): New function.
3613 (EMACS_SETTINGS): A new type derived from GObject to handle
3614 GSettings notifications.
3615 (emacs_settings_constructor, emacs_settings_get_property)
3616 (emacs_settings_set_property, emacs_settings_class_init):
3618 (gsettings_client, gsettings_obj): New variables.
3619 (GSETTINGS_SCHEMA): New define.
3620 (something_changedCB): Call store_monospaced_changed.
3621 (init_gsettings): New function.
3622 (xsettings_initialize): Call init_gsettings.
3623 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3626 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
3629 2011-06-29 Martin Rudalics <rudalics@gmx.at>
3631 * window.c (resize_root_window, grow_mini_window)
3632 (shrink_mini_window): Rename Qresize_root_window to
3633 Qwindow_resize_root_window and Qresize_root_window_vertically to
3634 Qwindow_resize_root_window_vertically.
3636 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3638 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3640 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
3642 * makefile.w32-in: Redesign dependencies so they reflect more
3643 clearly which files are directly included by each source file,
3644 and not through other includes.
3646 2011-06-27 Martin Rudalics <rudalics@gmx.at>
3648 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3649 (sort_overlays, overlay_strings): When an overlay's clone number
3650 matches the window's clone number process the overlay even if
3651 the overlay's window property doesn't match the current window.
3653 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3654 (Fwindow_hchild): Rename to Fwindow_left_child.
3655 (Fwindow_next): Rename to Fwindow_next_sibling.
3656 (Fwindow_prev): Rename to Fwindow_prev_sibling.
3657 (resize_window_check): Rename to window_resize_check.
3658 (resize_window_apply): Rename to window_resize_apply.
3659 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3660 (Fdelete_other_windows_internal, resize_frame_windows)
3661 (Fsplit_window_internal, Fdelete_window_internal)
3662 (grow_mini_window, shrink_mini_window)
3663 (Fresize_mini_window_internal): Fix callers accordingly.
3665 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3667 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3668 (emacs_fixed_set_min_size): Remove.
3669 (emacs_fixed_new): Take frame as argument.
3671 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3672 (_EmacsFixedPrivate): Remove minwidth/height.
3673 Add struct frame *f.
3674 (emacs_fixed_init): Initialize priv->f.
3675 (get_parent_class, emacs_fixed_set_min_size): Remove.
3676 (emacs_fixed_new): Set priv->f to argument.
3677 (emacs_fixed_get_preferred_width)
3678 (emacs_fixed_get_preferred_height): Use min_width/height from
3679 frames size_hint to set minimum and natural (Bug#8919).
3680 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3681 and use min_width/height from frames size_hint to set
3682 min_width/height (Bug#8919).
3684 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
3685 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3688 2011-06-26 Eli Zaretskii <eliz@gnu.org>
3690 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3691 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3694 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
3696 * process.c (wait_reading_process_output): Bypass select if
3697 waiting for a cell while ignoring keyboard input, and input is
3698 pending. Suggested by Jan Djärv (Bug#8869).
3700 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3702 Use gnulib's dup2 module instead of rolling our own.
3703 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3705 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3707 * dispnew.c (scrolling_window): Before scrolling, turn off a
3708 mouse-highlight in the window being scrolled.
3710 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
3712 Move DEFSYM to lisp.h and use everywhere.
3714 * character.h (DEFSYM): Move declaration...
3715 * lisp.h (DEFSYM): ...here.
3721 * w32select.c: Don't include character.h.
3723 * alloc.c (syms_of_alloc):
3724 * buffer.c (syms_of_buffer):
3725 * bytecode.c (syms_of_bytecode):
3726 * callint.c (syms_of_callint):
3727 * casefiddle.c (syms_of_casefiddle):
3728 * casetab.c (init_casetab_once):
3729 * category.c (init_category_once, syms_of_category):
3730 * ccl.c (syms_of_ccl):
3731 * cmds.c (syms_of_cmds):
3732 * composite.c (syms_of_composite):
3733 * dbusbind.c (syms_of_dbusbind):
3734 * dired.c (syms_of_dired):
3735 * dispnew.c (syms_of_display):
3736 * doc.c (syms_of_doc):
3737 * editfns.c (syms_of_editfns):
3738 * emacs.c (syms_of_emacs):
3739 * eval.c (syms_of_eval):
3740 * fileio.c (syms_of_fileio):
3741 * fns.c (syms_of_fns):
3742 * frame.c (syms_of_frame):
3743 * fringe.c (syms_of_fringe):
3744 * insdel.c (syms_of_insdel):
3745 * keymap.c (syms_of_keymap):
3746 * lread.c (init_obarray, syms_of_lread):
3747 * macros.c (syms_of_macros):
3748 * msdos.c (syms_of_msdos):
3749 * print.c (syms_of_print):
3750 * process.c (syms_of_process):
3751 * search.c (syms_of_search):
3752 * sound.c (syms_of_sound):
3753 * syntax.c (init_syntax_once, syms_of_syntax):
3754 * terminal.c (syms_of_terminal):
3755 * textprop.c (syms_of_textprop):
3756 * undo.c (syms_of_undo):
3757 * w32.c (globals_of_w32):
3758 * window.c (syms_of_window):
3759 * xdisp.c (syms_of_xdisp):
3760 * xfaces.c (syms_of_xfaces):
3761 * xfns.c (syms_of_xfns):
3762 * xmenu.c (syms_of_xmenu):
3763 * xsettings.c (syms_of_xsettings):
3764 * xterm.c (syms_of_xterm): Use DEFSYM.
3766 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3768 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
3770 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3772 Integer and buffer overflow fixes (Bug#8873).
3774 * print.c (printchar, strout): Check for string overflow.
3775 (PRINTPREPARE, printchar, strout):
3776 Don't set size unless allocation succeeds.
3778 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3779 for sizes. Check for string overflow more accurately.
3780 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3782 * macros.c: Integer and buffer overflow fixes.
3783 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3784 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3785 Use ptrdiff_t, not int, for sizes.
3786 Don't increment bufsize until after realloc succeeds.
3787 Check for size-calculation overflow.
3788 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3790 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3792 * lread.c: Integer overflow fixes.
3793 (read_integer): Radix is now EMACS_INT, not int,
3794 to improve quality of diagnostics for out-of-range radices.
3795 Calculate buffer size correctly for out-of-range radices.
3796 (read1): Check for integer overflow in radices, and in
3797 read-circle numbers.
3798 (read_escape): Avoid int overflow.
3799 (Fload, openp, read_buffer_size, read1)
3800 (substitute_object_recurse, read_vector, read_list, map_obarray):
3801 Use ptrdiff_t, not int, for sizes.
3802 (read1): Use EMACS_INT, not int, for sizes.
3803 Check for size overflow.
3805 * image.c (cache_image): Check for size arithmetic overflow.
3807 * lread.c: Integer overflow issues.
3808 (saved_doc_string_size, saved_doc_string_length)
3809 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3810 Now ptrdiff_t, not int.
3811 (read1): Don't assume doc string length fits in int. Check for
3812 out-of-range doc string lengths.
3813 (read_list): Don't assume file position fits in int.
3814 (read_escape): Check for hex character overflow.
3816 2011-06-22 Leo Liu <sdl.web@gmail.com>
3818 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3819 Move to minibuffer.el.
3821 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3823 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
3824 The following patches are for when GLYPH_DEBUG && !XASSERT.
3825 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3826 * dispnew.c (flush_stdout):
3827 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3828 Mark as externally visible.
3829 * dispnew.c (check_window_matrix_pointers): Now static.
3830 * dispnew.c (window_to_frame_vpos):
3831 * xfns.c (unwind_create_frame):
3832 * xterm.c (x_check_font): Remove unused local.
3833 * scroll.c (CHECK_BOUNDS):
3834 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3835 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3836 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3837 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3838 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3840 (debug_method_add): Use va_list and vsprintf rather than relying
3841 on undefined behavior with wrong number of arguments.
3842 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3843 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3844 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3845 since we're not interested in debugging glyphs with old libraries.
3846 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3847 GCC 4.6.0's static checking.
3849 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3851 Integer overflow and signedness fixes (Bug#8873).
3852 A few related buffer overrun fixes, too.
3854 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3856 * dispextern.h (struct face.stipple):
3857 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3858 (x_bitmap_mask, x_allocate_bitmap_record)
3859 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3860 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3861 (x_create_bitmap_from_xpm_data):
3862 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3863 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3865 * xfaces.c (load_pixmap):
3866 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3867 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3868 (.bitmaps_last, struct x_output.icon_bitmap):
3869 Use ptrdiff_t, not int, for bitmap indexes.
3870 (x_allocate_bitmap_record): Check for size overflow.
3871 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3873 Use ptrdiff_t, not int, for overlay counts.
3874 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3875 * editfns.c (overlays_around, get_pos_property):
3876 * textprop.c (get_char_property_and_overlay):
3877 * xdisp.c (next_overlay_change, note_mouse_highlight):
3878 * xfaces.c (face_at_buffer_position):
3879 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3880 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3881 (Fnext_overlay_change, Fprevious_overlay_change)
3882 (mouse_face_overlay_overlaps, Foverlays_in):
3883 Use ptrdiff_t, not int, for sizes.
3884 (overlays_at, overlays_in): Check for size-calculation overflow.
3886 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3888 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3889 (x_session_initialize): Do not assume string length fits in int.
3891 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3892 This is unlikely, but can occur if DPI is outlandish.
3894 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3895 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3897 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3898 * xrdb.c (magic_file_p, search_magic_path):
3899 Omit last arg SUFFIX; it was always 0. All callers changed.
3900 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3902 * xfont.c (xfont_match): Avoid need for strlen.
3904 * xfns.c: Don't assume strlen fits in int.
3905 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3907 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3908 not unsigned long, as we prefer signed integers. All callers changed.
3909 Detect integer overflow in repeat count.
3910 (message_dolog): Don't assume print length fits in 39 bytes.
3911 (display_mode_element): Don't assume strlen fits in int.
3913 * termcap.c: Don't assume sizes fit in int and never overflow.
3914 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3915 (gobble_line): Check for size-calculation overflow.
3917 * minibuf.c (Fread_buffer):
3918 * lread.c (intern, intern_c_string):
3919 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3920 Don't assume string length fits in int.
3922 * keyboard.c (parse_tool_bar_item):
3923 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3925 * font.c: Don't assume string length fits in int.
3926 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3927 Use ptrdiff_t, not int.
3928 (font_intern_prop): Don't assume string length fits in int.
3929 Don't assume integer property fits in fixnum.
3930 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3932 * filelock.c: Fix some buffer overrun and integer overflow issues.
3933 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3934 Reformulate so as not to need the command string.
3935 Invoke gzip -cd rather than gunzip, as it's more portable.
3936 (lock_info_type, lock_file_1, lock_file):
3937 Don't assume pid_t and time_t fit in unsigned long.
3938 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3939 (current_lock_owner): Prefer signed type for sizes.
3940 Use memcpy, not strncpy, where memcpy is what is really wanted.
3941 Don't assume (via atoi) that time_t and pid_t fit in int.
3942 Check for time_t and/or pid_t out of range, e.g., via a network share.
3943 Don't alloca where an auto var works fine.
3945 * fileio.c: Fix some integer overflow issues.
3946 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3947 Don't assume string length fits in int.
3948 (directory_file_name): Don't assume string length fits in long.
3949 (make_temp_name): Don't assume pid fits in int, or that its print
3950 length is less than 20.
3952 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3954 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3956 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3958 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3959 We prefer signed integers, even for size calculations.
3961 * emacs.c: Don't assume string length fits in 'int'.
3962 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3963 (main): Don't invoke strlen when not needed.
3965 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3966 (XD_DEBUG_MESSAGE): Don't waste a byte.
3968 * callproc.c (getenv_internal_1, getenv_internal)
3970 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3972 * lread.c (invalid_syntax): Omit length argument.
3973 All uses changed. This doesn't fix a bug, but it simplifies the
3974 code away from its former Hollerith-constant appearance, and it's
3975 one less 'int' to worry about when looking at integer-overflow issues.
3976 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3978 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3979 This didn't break anything, but it didn't help either.
3980 It's confusing to put a bogus integer in a place where the actual
3981 value does not matter.
3982 (LIST_END_P): Remove unused macro and its bogus comment.
3983 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3985 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3986 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3988 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3989 We prefer signed types, and the value cannot exceed the EMACS_INT
3990 range anyway (because otherwise the length would not be representable).
3991 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3992 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3993 This avoids a GCC warning when WIDE_EMACS_INT.
3995 * indent.c (sane_tab_width): New function.
3996 (current_column, scan_for_column, Findent_to, position_indentation)
3997 (compute_motion): Use it. This is just for clarity.
3998 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4000 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4002 * lisp.h (lint_assume): New macro.
4003 * composite.c (composition_gstring_put_cache):
4004 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4006 * editfns.c, insdel.c:
4007 Omit unnecessary forward decls, to simplify future changes.
4009 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4011 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4013 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4014 Use much-faster test for byte-length change.
4015 Don't assume string byte-length fits in 'int'.
4016 Check that character arg fits in 'int'.
4017 (mapcar1): Declare byte as byte, for clarity.
4019 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4021 * fns.c (concat): Catch string overflow earlier.
4022 Do not rely on integer wraparound.
4024 * dispextern.h (struct it.overlay_strings_charpos)
4025 (struct it.selective): Now EMACS_INT, not int.
4026 * xdisp.c (forward_to_next_line_start)
4027 (back_to_previous_visible_line_start)
4028 (reseat_at_next_visible_line_start, next_element_from_buffer):
4029 Don't arbitrarily truncate the value of 'selective' to int.
4031 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4033 * composite.c: Don't truncate sizes to 'int'.
4034 (composition_gstring_p, composition_reseat_it)
4035 (composition_adjust_point): Use EMACS_INT, not int.
4036 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4037 not EMACS_UINT, for indexes.
4039 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4041 * buffer.c: Include <verify.h>.
4042 (struct sortvec.priority, struct sortstr.priority):
4043 Now EMACS_INT, not int.
4044 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4045 (struct sortstr.size, record_overlay_string)
4046 (struct sortstrlist.size, struct sortlist.used):
4047 Don't truncate size to int.
4048 (record_overlay_string): Check for size-calculation overflow.
4049 (init_buffer_once): Check at compile-time, not run-time.
4051 2011-06-22 Jim Meyering <meyering@redhat.com>
4053 Don't leak an XBM-image-sized buffer
4054 * image.c (xbm_load): Free the image buffer after using it.
4056 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4059 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4060 that Sun C diagnosed.
4061 * fns.c (secure_hash): Fix pointer signedness issue.
4062 * intervals.c (static_offset_intervals): New function.
4063 (offset_intervals): Use it.
4065 2011-06-21 Leo Liu <sdl.web@gmail.com>
4068 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4071 * fns.c (secure_hash): Rename from crypto_hash_function and change
4072 the first arg to accept symbols.
4073 (Fsecure_hash): New primitive.
4074 (syms_of_fns): New symbols.
4076 2011-06-20 Deniz Dogan <deniz@dogan.se>
4078 * process.c (Fset_process_buffer): Clarify return value in
4081 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4083 * dispnew.c (add_window_display_history): Use BVAR.
4085 * xdisp.c (debug_method_add): Use BVAR.
4086 (check_window_end, dump_glyph_matrix, dump_glyph)
4087 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4089 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4092 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4093 check till after the cache is created in init_frame_faces.
4095 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4097 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4099 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4101 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4102 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4103 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4105 Improve buffer-overflow checking (Bug#8873).
4106 * fileio.c (Finsert_file_contents):
4107 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4108 Remove the old (too-loose) buffer overflow checks.
4109 They weren't needed, since make_gap checks for buffer overflow.
4110 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4111 The old code merely checked for Emacs fixnum overflow, and relied
4112 on undefined (wraparound) behavior. The new code avoids undefined
4113 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4115 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4116 Tune. Don't use wider integers than needed. Don't use alloca.
4117 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4119 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4121 * insdel.c, lisp.h (buffer_overflow): New function.
4122 (insert_from_buffer_1, replace_range, replace_range_2):
4123 * insdel.c (make_gap_larger):
4124 * editfns.c (Finsert_char):
4125 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4127 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4129 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4131 Integer overflow and signedness fixes (Bug#8873).
4133 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4134 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4136 * fileio.c: Don't assume EMACS_INT fits in off_t.
4137 (emacs_lseek): New static function.
4138 (Finsert_file_contents, Fwrite_region): Use it.
4139 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4141 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4143 * fns.c: Don't overflow int when computing a list length.
4144 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4145 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4146 truncation on 64-bit hosts. Check for QUIT every
4147 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4148 faster and is responsive enough.
4149 (Flength): Report an error instead of overflowing an integer.
4150 (Fsafe_length): Return a float if the value is not representable
4151 as a fixnum. This shouldn't happen except in contrived situations.
4152 (Fnthcdr, Fsort): Don't assume list length fits in int.
4153 (Fcopy_sequence): Don't assume vector length fits in int.
4155 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4156 (header_size, word_size): New constants.
4157 (allocate_vectorlike): Don't check size overflow here.
4158 (allocate_vector): Check it here instead, since this is the only
4159 caller of allocate_vectorlike that could cause overflow.
4160 Check that the new vector's length is representable as a fixnum.
4162 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4163 The previous code was bogus. For example, next_almost_prime (32)
4164 returned 39, which is undesirable as it is a multiple of 3; and
4165 next_almost_prime (24) returned 25, which is a multiple of 5 so
4166 why was the code bothering to check for multiples of 7?
4168 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4170 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4172 Variadic C functions now count arguments with ptrdiff_t.
4173 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4174 Back then I didn't know that the Emacs coding style prefers signed int.
4175 Also, in the meantime I found a few more instances where arguments
4176 were being counted with int, which may truncate counts on 64-bit
4177 machines, or EMACS_INT, which may be unnecessarily wide.
4178 * lisp.h (struct Lisp_Subr.function.aMANY)
4179 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4180 Arg counts are now ptrdiff_t, not size_t.
4181 All variadic functions and their callers changed accordingly.
4182 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4183 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4184 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4185 * callint.c (Fcall_interactively): Check arg count for overflow,
4186 to avoid potential buffer overrun. Use signed char, not 'int',
4187 for 'varies' array, so that we needn't bother to check its size
4188 calculation for overflow.
4189 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4190 * eval.c (apply_lambda):
4191 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4192 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4193 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4195 * callint.c (Fcall_interactively): Don't use index var as event count.
4197 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4198 * mem-limits.h (SIZE): Remove; no longer used.
4200 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4202 Remove unnecessary casts.
4203 * xterm.c (x_term_init):
4204 * xfns.c (x_set_border_pixel):
4205 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4206 These aren't needed now that we assume ANSI C.
4208 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4209 It's more likely to cause problems (due to unsigned overflow)
4212 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4214 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4216 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4218 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4220 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4222 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4224 GLYPH_CODE_FACE returns EMACS_INT, not int.
4225 * dispextern.h (merge_faces):
4226 * xfaces.c (merge_faces):
4227 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4228 Don't assume EMACS_INT fits in int.
4230 * character.h (CHAR_VALID_P): Remove unused parameter.
4231 * fontset.c, lisp.h, xdisp.c: All uses changed.
4233 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4235 * fns.c (concat): Minor tuning based on overflow analysis.
4236 This doesn't fix any bugs. Use int to hold character, instead
4237 of constantly refetching from Emacs object. Use XFASTINT, not
4238 XINT, for value known to be a character. Don't bother comparing
4239 a single byte to 0400, as it's always less.
4241 * floatfns.c (Fexpt):
4242 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4244 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4247 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4249 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4250 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4251 incorrectly succeed when S was a string, because 4294967386 was
4252 truncated before it was used.
4254 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4255 Otherwise, an out-of-range integer could cause undefined behavior
4258 * composite.c: Use int, not EMACS_INT, for characters.
4259 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4260 EMACS_INT, for values that are known to be in character range.
4261 This doesn't fix any bugs but is the usual style inside Emacs and
4262 may generate better code on 32-bit machines.
4264 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4265 This is for reasons similar to the recent CHAR_STRING fix.
4266 * charset.c (Fencode_char): Check that character arg is actually
4267 a character. Pass an int to ENCODE_CHAR.
4268 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4269 wider than 'int', as a compile-time check to prevent future regressions
4272 * character.c (char_string): Remove unnecessary casts.
4274 Make sure a 64-bit char is never passed to CHAR_STRING.
4275 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4276 by silently ignoring the top 32 bits, allowing some values
4277 that were far too large to be valid characters.
4278 * character.h: Include <verify.h>.
4279 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4280 arguments are no wider than unsigned, as a compile-time check
4281 to prevent future regressions in this area.
4283 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4284 (Fsubst_char_in_region):
4286 * xdisp.c (decode_mode_spec_coding):
4287 Adjust to CHAR_STRING's new requirement.
4288 * editfns.c (Finsert_char, Fsubst_char_in_region):
4289 * fns.c (concat): Check that character args are actually
4290 characters. Without this test, these functions did the wrong
4291 thing with wildly out-of-range values on 64-bit hosts.
4293 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4294 These casts should not be needed on 32-bit hosts, either.
4295 * keyboard.c (read_char):
4296 * lread.c (Fload): Remove casts to unsigned.
4298 * lisp.h (UNSIGNED_CMP): New macro.
4299 This fixes comparison bugs on 64-bit hosts.
4300 (ASCII_CHAR_P): Use it.
4301 * casefiddle.c (casify_object):
4302 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4303 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4304 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4305 * dispextern.h (FACE_FROM_ID):
4306 * keyboard.c (read_char): Use UNSIGNED_CMP.
4308 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4309 not to EMACS_INT, to avoid GCC warning.
4311 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4313 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4314 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4315 isn't needed on 32-bit machines.
4317 * buffer.c (Fgenerate_new_buffer_name):
4318 Use EMACS_INT for count, not int.
4319 (advance_to_char_boundary): Return EMACS_INT, not int.
4321 * data.c (Qcompiled_function): Now static.
4323 * window.c (window_body_lines): Now static.
4325 * image.c (gif_load): Rename local to avoid shadowing.
4327 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4328 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4329 * alloc.c (make_save_value): Integer argument is now of type
4331 (mark_object): Use ptrdiff_t, not int.
4332 * lisp.h (pD): New macro.
4333 * print.c (print_object): Use it.
4335 * alloc.c: Use EMACS_INT, not int, to count objects.
4336 (total_conses, total_markers, total_symbols, total_vector_size)
4337 (total_free_conses, total_free_markers, total_free_symbols)
4338 (total_free_floats, total_floats, total_free_intervals)
4339 (total_intervals, total_strings, total_free_strings):
4340 Now EMACS_INT, not int. All uses changed.
4341 (Fgarbage_collect): Compute overall total using a double, so that
4342 integer overflow is less likely to be a problem. Check for overflow
4343 when converting back to an integer.
4344 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4345 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4346 These were 'int' variables that could overflow on 64-bit hosts;
4347 they were never used, so remove them instead of repairing them.
4348 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4349 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4350 Previously, this ceilinged at INT_MAX, but that doesn't work on
4352 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4354 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4355 (allocate_vectorlike): Check for ptrdiff_t overflow.
4356 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4357 when a (possibly-narrower) signed value would do just as well.
4358 We prefer using signed arithmetic, to avoid comparison confusion.
4360 * alloc.c: Catch some string size overflows that we were missing.
4361 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4362 for convenience in STRING_BYTES_MAX.
4363 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4364 The definition here is exact; the one in lisp.h was approximate.
4365 (allocate_string_data): Check for string overflow. This catches
4366 some instances we weren't catching before. Also, it catches
4367 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4368 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4369 and ptrdiff_t and EMACS_INT are both 64 bits.
4371 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4372 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4373 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4375 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4377 * alloc.c (Fmake_string): Check for out-of-range init.
4379 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4381 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4383 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4385 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4386 xg_get_default_scrollbar_width.
4388 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4389 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4390 (style_changed_cb): Call update_theme_scrollbar_width and call
4391 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4392 all frames (Bug#8505).
4393 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4394 Call gtk_window_set_resizable if HAVE_GTK3.
4395 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4396 and height if HAVE_GTK3 (Bug#8505).
4397 (scroll_bar_width_for_theme): New variable.
4398 (update_theme_scrollbar_width): New function.
4399 (xg_get_default_scrollbar_width): Move code to
4400 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4401 (xg_initialize): Call update_theme_scrollbar_width.
4403 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4405 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4407 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4409 * frame.c (make_frame): Call other_buffer_safely instead of
4412 * window.c (temp_output_buffer_show): Call display_buffer with
4413 second argument Vtemp_buffer_show_specifiers and reset latter
4414 immediately after the call.
4415 (Vtemp_buffer_show_specifiers): New variable.
4416 (auto_window_vscroll_p, next_screen_context_lines)
4417 (Vscroll_preserve_screen_position): Remove leading asterisks from
4420 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4422 Fix minor problems found by GCC 4.6.0 static checking.
4423 * buffer.c (Qclone_number): Remove for now, as it's unused.
4424 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4425 (record_buffer): Remove unused local.
4426 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4427 (set_frame_buffer_list): Remove; unused.
4428 * frame.h (other_visible_frames): Remove decl.
4429 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4430 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4431 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4433 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4434 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4435 Define only if HAVE_GPM.
4436 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4437 (update_hints_inhibit): Remove; never set. All uses removed.
4438 * widgetprv.h (emacsFrameClassRec): Remove decl.
4439 * window.c (delete_deletable_window): Now returns void, since it
4440 wasn't returning anything.
4441 (compare_window_configurations): Remove unused locals.
4442 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4443 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4444 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4445 the same widths as pointers. This follows up on the 2011-05-06 patch.
4446 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4447 * xterm.h: Likewise.
4448 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4450 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4452 * makefile.w32-in: Update dependencies.
4453 (LISP_H): Add lib/intprops.h.
4455 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4457 * image.c (gif_load): Add animation frame delay to the metadata.
4458 (syms_of_image): Use DEFSYM. New symbol `delay'.
4460 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4462 * window.c (delete_deletable_window): Re-add.
4463 (Fset_window_configuration): Rewrite to handle dead buffers and
4464 consequently deletable windows.
4465 (window_tree, Fwindow_tree): Remove. Supply functionality in
4467 (compare_window_configurations): Simplify code.
4469 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4471 * image.c (imagemagick_load_image): Fix type mismatch.
4472 (Fimagemagick_types): Likewise.
4474 * window.h (replace_buffer_in_windows): Declare.
4476 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4478 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4479 Qclone_number. Remove external declaration of Qdelete_window.
4480 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4482 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4483 Run Qbuffer_list_update_hook if allowed.
4484 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4485 buffer list implementation.
4486 (other_buffer_safely): New function.
4487 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4488 calls to replace_buffer_in_windows and
4489 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4491 (record_buffer): Inhibit quitting and rewrite using quittable
4492 functions. Run Qbuffer_list_update_hook if allowed.
4493 (Frecord_buffer, Funrecord_buffer): New functions.
4494 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4495 Move switch-to-buffer to window.el.
4496 (bury-buffer): Move to window.el.
4497 (Vbuffer_list_update_hook): New variable.
4499 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4502 * window.h (resize_frame_windows): Move up in code.
4503 (Fwindow_frame): Remove EXFUN.
4504 (replace_buffer_in_all_windows): Remove prototype.
4505 (replace_buffer_in_windows_safely): Add prototype.
4507 * window.c: Declare Qdelete_window static again. Move down
4508 declaration of select_count.
4509 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4510 (Fother_window): Move to window.el.
4511 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4512 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4513 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4515 (replace_buffer_in_windows): Implement by calling
4516 Qreplace_buffer_in_windows.
4517 (replace_buffer_in_all_windows): Remove with some functionality
4518 moved into replace_buffer_in_windows_safely.
4519 (replace_buffer_in_windows_safely): New function.
4520 (select_window_norecord, select_frame_norecord): Move in front
4521 of run_window_configuration_change_hook. Remove now obsolete
4523 (Fset_window_buffer): Rewrite doc-string.
4524 Call Qrecord_window_buffer.
4525 (keys_of_window): Move binding for other-window to window.el.
4527 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4529 * dispextern.h (struct image): Replace data member, whose int_val
4530 and ptr_val fields were not used by anything, with a single
4533 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4534 (gif_clear_image, gif_load, imagemagick_load_image)
4535 (gs_clear_image, gs_load): Callers changed.
4537 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4539 * buffer.h: Include <time.h>, for time_t.
4540 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4542 Fix minor problems found by static checking.
4544 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4546 Make identifiers static if they are not used in other modules.
4547 * data.c (Qcompiled_function, Qframe, Qvector):
4548 * image.c (QimageMagick, Qsvg):
4549 * minibuf.c (Qmetadata):
4550 * window.c (resize_window_check, resize_root_window): Now static.
4551 * window.h (resize_window_check, resize_root_window): Remove decls.
4553 * window.c (window_deletion_count, delete_deletable_window):
4555 (window_body_lines): Now static.
4556 (Fdelete_other_windows_internal): Mark vars as initialized.
4557 Make sure 'resize_failed' is initialized.
4558 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4559 (resize_window_apply): Remove unused local.
4560 * window.h (delete_deletable_window): Remove decl.
4562 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4563 (imagemagick_load_image): Fix pointer signedness problem by changing
4564 last arg from unsigned char * to char *. All uses changed.
4565 Also, fix a local for similar reasons.
4566 Remove unused locals. Remove locals to avoid shadowing.
4567 (fn_rsvg_handle_free): Remove; unused.
4568 (svg_load, svg_load_image): Fix pointer signedness problem.
4569 (imagemagick_load_image): Don't use garbage pointer image_wand.
4571 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4573 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4575 * image.c (gif_load): Fix omitted cast error introduced by
4578 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4580 * window.h (resize_proportionally, orig_total_lines)
4581 (orig_top_line): Remove from window structure.
4582 (set_window_height, set_window_width, change_window_heights)
4583 (Fdelete_window): Remove prototypes.
4584 (resize_frame_windows): Remove duplicate declaration.
4586 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4588 * window.h (resize_frame_windows, resize_window_check)
4589 (delete_deletable_window, resize_root_window)
4590 (resize_frame_windows): Declare prototypes.
4592 * window.c (resize_window_apply): Make definition be "static" to
4593 match the prototype.
4595 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4597 * window.c: Remove declarations of Qwindow_size_fixed,
4598 window_min_size_1, window_min_size_2, window_min_size,
4599 size_window, window_fixed_size_p, enlarge_window, delete_window.
4600 Remove static from declaration of Qdelete_window, it's
4601 temporarily needed by Fbury_buffer.
4602 (replace_window): Don't assign orig_top_line and
4604 (Fdelete_window, delete_window): Remove. Window deletion is
4605 handled by window.el.
4606 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4607 Replace Fdelete_window calls with calls to Qdelete_window.
4608 (Fdelete_other_windows): Remove. Deleting other windows is
4609 handled by window.el.
4610 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4611 handled in window.el.
4612 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4613 Window minimum sizes are handled in window.el.
4614 (shrink_windows, size_window, set_window_height)
4615 (set_window_width, change_window_heights, window_height)
4616 (window_width, CURBEG, CURSIZE, enlarge_window)
4617 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4618 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4619 handled in window.el.
4620 (make_dummy_parent): Rename to make_parent_window and give it a
4621 second argument horflag.
4622 (make_window): Don't set resize_proportionally any more.
4623 (Fsplit_window): Remove. Windows are split in window.el.
4624 (save_restore_action, save_restore_orig_size)
4625 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4626 Resize mini windows in window.el.
4627 (grow_mini_window, shrink_mini_window): Implement by calling
4628 Qresize_root_window_vertically, resize_window_check and
4629 resize_window_apply.
4630 (saved_window, Fset_window_configuration, save_window_save):
4631 Do not handle orig_top_line, orig_total_lines, and
4632 resize_proportionally.
4633 (window_min_height, window_min_width): Move to window.el.
4634 (keys_of_window): Move bindings for delete-other-windows,
4635 split-window, delete-window and enlarge-window to window.el.
4637 * buffer.c: Temporarily extern Qdelete_window.
4638 (Fbury_buffer): Temporarily call Qdelete_window instead of
4639 Fdelete_window (Fbury_buffer will move to window.el soon).
4641 * frame.c (set_menu_bar_lines_1): Remove code handling
4642 orig_top_line and orig_total_lines.
4644 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4645 set_window_height but set heights directly.
4646 (change_frame_size_1): Use resize_frame_windows.
4648 * xdisp.c (init_xdisp): Don't use set_window_height but set
4651 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4652 Use resize_frame_windows instead of change_window_heights and run
4653 run_window_configuration_change_hook.
4655 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4656 instead of change_window_heights and run
4657 run_window_configuration_change_hook.
4659 2011-06-09 Martin Rudalics <rudalics@gmx.at>
4661 * window.c (replace_window): Rename second argument REPLACEMENT to
4662 NEW. New third argument SETFLAG. Rewrite.
4663 (delete_window, make_dummy_parent): Call replace_window with
4665 (window_list_1): Move down in code.
4666 (run_window_configuration_change_hook): Move set_buffer part
4667 before select_frame_norecord part in order to unwind correctly.
4668 Rename count1 to count.
4669 (recombine_windows, delete_deletable_window, resize_root_window)
4670 (Fdelete_other_windows_internal)
4671 (Frun_window_configuration_change_hook, make_parent_window)
4672 (resize_window_check, resize_window_apply, Fresize_window_apply)
4673 (resize_frame_windows, Fsplit_window_internal)
4674 (Fdelete_window_internal, Fresize_mini_window_internal):
4676 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4678 2011-06-08 Martin Rudalics <rudalics@gmx.at>
4680 * window.h (window): Add some new members to window structure -
4681 normal_lines, normal_cols, new_total, new_normal, clone_number,
4682 splits, nest, prev_buffers, next_buffers.
4683 (WINDOW_TOTAL_SIZE): Move here from window.c.
4684 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
4686 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4688 (make_dummy_parent): Set new members of windows structure.
4689 (make_window): Move down in code. Handle new members of window
4691 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4692 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4693 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4694 (Fset_window_prev_buffers, Fwindow_next_buffers)
4695 (Fset_window_next_buffers, Fset_window_clone_number):
4697 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4698 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4700 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4701 Argument WINDOW can be now internal window too.
4702 (Fwindow_use_time): Move up in code.
4703 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4705 (Fset_window_configuration, saved_window)
4706 (Fcurrent_window_configuration, save_window_save): Handle new
4707 members of window structure.
4708 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4709 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4710 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4711 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4712 Qget_mru_window, Qresize_root_window,
4713 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4714 Qauto_buffer_name; staticpro them.
4716 2011-06-07 Martin Rudalics <rudalics@gmx.at>
4718 * window.c (Fwindow_total_size, Fwindow_left_column)
4719 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4720 (Fwindow_list_1): New functions.
4721 (window_box_text_cols): Replace with window_body_cols.
4722 (Fwindow_width, Fscroll_left, Fscroll_right):
4723 Use window_body_cols instead of window_box_text_cols.
4724 (delete_window, Fset_window_configuration):
4725 Call delete_all_subwindows with window as argument.
4726 (delete_all_subwindows): Take a window as argument and not a
4728 (window_loop): Remove handling of GET_LRU_WINDOW and
4730 (Fget_lru_window, Fget_largest_window): Move to window.el.
4732 * window.h: Extern window_body_cols instead of
4733 window_box_text_cols. delete_all_subwindows now takes a
4734 Lisp_Object as argument.
4736 * indent.c (compute_motion, Fcompute_motion):
4737 Use window_body_cols instead of window_box_text_cols.
4739 * frame.c (delete_frame): Call delete_all_subwindows with root
4742 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4744 * fns.c (Fputhash): Document return value.
4746 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
4748 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4750 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4752 Cons<->int and similar integer overflow fixes (Bug#8794).
4754 Check for overflow when converting integer to cons and back.
4755 * charset.c (Fdefine_charset_internal, Fdecode_char):
4756 Use cons_to_unsigned to catch overflow.
4757 (Fencode_char): Use INTEGER_TO_CONS.
4758 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4759 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4760 * data.c (long_to_cons, cons_to_long): Remove.
4761 (cons_to_unsigned, cons_to_signed): New functions.
4762 These signal an error for invalid or out-of-range values.
4763 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4764 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4765 * font.c (Ffont_variation_glyphs):
4766 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4767 * lisp.h: Include <intprops.h>.
4768 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4769 (cons_to_signed, cons_to_unsigned): New decls.
4770 (long_to_cons, cons_to_long): Remove decls.
4771 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4772 (Fprimitive_undo): Use CONS_TO_INTEGER.
4773 * xfns.c (Fx_window_property): Likewise.
4774 * xselect.c: Include <limits.h>.
4775 (x_own_selection, selection_data_to_lisp_data):
4776 Use INTEGER_TO_CONS.
4777 (x_handle_selection_request, x_handle_selection_clear)
4778 (x_get_foreign_selection, Fx_disown_selection_internal)
4779 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4780 (lisp_data_to_selection_data): Use cons_to_unsigned.
4781 (x_fill_property_data): Use cons_to_signed.
4782 Report values out of range.
4784 Check for buffer and string overflow more precisely.
4785 * buffer.h (BUF_BYTES_MAX): New macro.
4786 * lisp.h (STRING_BYTES_MAX): New macro.
4787 * alloc.c (Fmake_string):
4788 * character.c (string_escape_byte8):
4789 * coding.c (coding_alloc_by_realloc):
4790 * doprnt.c (doprnt):
4791 * editfns.c (Fformat):
4793 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4794 since they may not be the same number.
4795 * editfns.c (Finsert_char):
4796 * fileio.c (Finsert_file_contents):
4797 Likewise for BUF_BYTES_MAX.
4799 * image.c: Use ptrdiff_t, not int, for sizes.
4800 (slurp_file): Switch from int to ptrdiff_t.
4802 (slurp_file): Check that file size fits in both size_t (for
4803 malloc) and ptrdiff_t (for sanity and safety).
4805 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4806 if b->modtime has its maximal value.
4808 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4810 Don't assume time_t can fit into int.
4811 * buffer.h (struct buffer.modtime): Now time_t, not int.
4812 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4813 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4815 Minor fixes for signed vs unsigned integers.
4816 * character.h (MAYBE_UNIFY_CHAR):
4817 * charset.c (maybe_unify_char):
4818 * keyboard.c (read_char, reorder_modifiers):
4819 XINT -> XFASTINT, since the integer must be nonnegative.
4820 * ftfont.c (ftfont_spec_pattern):
4821 * keymap.c (access_keymap, silly_event_symbol_error):
4822 XUINT -> XFASTINT, since the integer must be nonnegative.
4823 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4824 since it makes no difference and we prefer signed.
4825 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4826 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4829 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4831 * window.h (Fwindow_frame): Declare.
4833 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4835 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4836 (SPARE_MEMORY): Always define.
4837 (LARGE_REQUEST): Remove.
4838 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4840 2011-06-06 Martin Rudalics <rudalics@gmx.at>
4842 * lisp.h: Move EXFUNS for Fframe_root_window,
4843 Fframe_first_window and Fset_frame_selected_window to window.h.
4845 * window.h: Move EXFUNS for Fframe_root_window,
4846 Fframe_first_window and Fset_frame_selected_window here from
4849 * frame.c (Fwindow_frame, Fframe_first_window)
4850 (Fframe_root_window, Fframe_selected_window)
4851 (Fset_frame_selected_window): Move to window.c.
4852 (Factive_minibuffer_window): Move to minibuf.c.
4853 (Fother_visible_frames_p): New function.
4855 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4857 * window.c (decode_window, decode_any_window): Move up in code.
4858 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4859 (inhibit_frame_unsplittable): Remove unused variable.
4860 (Fwindow_buffer): Move up and rewrite doc-string.
4861 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4862 (Fwindow_prev): New functions.
4863 (Fwindow_frame): Move here from frame.c. Accept any window as
4865 (Fframe_root_window, Fframe_first_window)
4866 (Fframe_selected_window): Move here from frame.c. Accept frame
4867 or arbitrary window as argument. Update doc-strings.
4868 (Fminibuffer_window): Move up in code.
4869 (Fwindow_minibuffer_p): Move up in code and simplify.
4870 (Fset_frame_selected_window): Move here from frame.c.
4872 (Fselected_window, select_window, Fselect_window): Move up in
4873 code. Minor doc-string fixes.
4875 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4877 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4878 Do not assume that spare memory exists; that assumption is valid
4879 only if SYSTEM_MALLOC.
4880 (LARGE_REQUEST): New macro, so that the issue of large requests
4881 is separated from the issue of spare memory.
4883 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4885 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4888 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4890 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4893 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4895 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4897 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4899 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4900 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4902 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
4904 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4906 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
4908 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4909 (x_clipboard_manager_save): Add return value.
4910 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4912 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4913 Obey Vx_select_enable_clipboard_manager. Catch errors in
4914 x_clipboard_manager_save (Bug#8779).
4915 (Vx_select_enable_clipboard_manager): New variable.
4916 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4918 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4920 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4922 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4924 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4925 in the current matrix if keep_current_p is non-zero.
4927 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4929 * bidi.c (bidi_level_of_next_char): Fix last change.
4931 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4933 Support bidi reordering of text covered by display properties.
4935 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4936 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4937 (bidi_cache_search, bidi_cache_iterator_state)
4938 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4939 (bidi_level_of_next_char, bidi_move_to_visually_next):
4940 Support character positions inside a run of characters covered by a
4942 (bidi_paragraph_init, bidi_resolve_explicit_1)
4943 (bidi_level_of_next_char): Call bidi_fetch_char and
4944 bidi_fetch_char_advance instead of FETCH_CHAR and
4946 (bidi_init_it): Initialize new members.
4947 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4949 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4950 instead of using explicit *_CHAR codes.
4951 (bidi_resolve_explicit, bidi_resolve_weak):
4952 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4953 bidirectional text is supported only in multibyte buffers.
4954 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4955 it to initialize the frame_window_p member of struct bidi_it.
4956 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4957 (bidi_resolve_explicit, bidi_resolve_weak)
4958 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4959 bidi_it->nchars is non-positive.
4960 (bidi_level_of_next_char): Don't try to lookup the cache for the
4961 next/previous character if nothing is cached there yet, or if we
4962 were just reseat()'ed to a new position.
4964 * xdisp.c (set_cursor_from_row): Set start and stop points
4965 according to the row's direction when priming the loop that looks
4966 for the glyph on which to display cursor.
4967 (single_display_spec_intangible_p): Function deleted.
4968 (display_prop_intangible_p): Reimplement to call
4969 handle_display_spec instead of single_display_spec_intangible_p.
4970 Accept 3 additional arguments needed by handle_display_spec.
4971 This fixes incorrect cursor motion across display property with complex
4972 values: lists, `(when COND...)' forms, etc.
4973 (single_display_spec_string_p): Support property values that are
4974 lists with the argument STRING its top-level element.
4975 (display_prop_string_p): Fix the condition for processing a
4976 property that is a list to be consistent with handle_display_spec.
4977 (handle_display_spec): New function, refactored from the
4978 last portion of handle_display_prop.
4979 (compute_display_string_pos): Accept additional argument
4980 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4981 value of a `display' property is a "replacing spec".
4982 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4983 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4984 the display property, but just return a value indicating whether
4985 the display property will replace the characters it covers.
4986 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4987 frame_window_p members of struct bidi_it.
4988 (compute_display_string_pos, compute_display_string_end):
4990 (push_it): Accept second argument POSITION, where pop_it should
4991 jump to continue iteration.
4992 (reseat_1): Initialize bidi_it.disp_pos.
4994 * keyboard.c (adjust_point_for_property): Adjust the call to
4995 display_prop_intangible_p to its new signature.
4997 * dispextern.h (struct bidi_it): New member frame_window_p.
4998 (bidi_init_it): Update prototypes.
4999 (display_prop_intangible_p): Update prototype.
5000 (compute_display_string_pos, compute_display_string_end):
5002 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5005 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5007 Malloc failure behavior now depends on size of allocation.
5008 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5009 * lisp.h: Change signatures accordingly.
5010 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5011 All callers changed. (Bug#8762)
5013 * gnutls.c: Use Emacs's memory allocators.
5014 Without this change, the gnutls library would invoke malloc etc.
5015 directly, which causes problems on non-SYNC_INPUT hosts, and which
5016 runs afoul of improving memory_full behavior. (Bug#8761)
5017 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5018 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5019 xfree instead of the default malloc, realloc, free.
5020 (Fgnutls_boot): No need to check for memory allocation failure,
5021 since xmalloc does that for us.
5023 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5024 * category.c (hash_get_category_set):
5025 * ccl.c (ccl_driver):
5026 * charset.c (Fdefine_charset_internal):
5027 * charset.h (struct charset.hash_index):
5028 * composite.c (get_composition_id, gstring_lookup_cache)
5029 (composition_gstring_put_cache):
5030 * composite.h (struct composition.hash_index):
5031 * dispextern.h (struct image.hash):
5032 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5033 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5034 (hashfn_equal, hashfn_user_defined, make_hash_table)
5035 (maybe_resize_hash_table, hash_lookup, hash_put)
5036 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5037 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5038 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5039 * image.c (make_image, search_image_cache, lookup_image)
5040 (xpm_put_color_table_h):
5041 * lisp.h (struct Lisp_Hash_Table):
5042 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5043 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5044 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5045 * alloc.c (allocate_vectorlike):
5046 Check for overflow in vector size calculations.
5047 * ccl.c (ccl_driver):
5048 Check for overflow when converting EMACS_INT to int.
5049 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5050 need to be updated by these changes.
5051 * fns.c (make_hash_table, maybe_resize_hash_table):
5052 Check for integer overflow with large hash tables.
5053 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5054 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5055 (SXHASH_REDUCE): New macro.
5056 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5057 Use it instead of discarding useful hash info with large hash values.
5058 (sxhash_float): New function.
5059 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5060 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5061 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5062 Rewrite to use FIXNUM_BITS, as this simplifies things.
5063 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5064 Adjust signatures to match updated version of code.
5065 (consing_since_gc): Now EMACS_INT, since a single hash table can
5066 use more than INT_MAX bytes.
5068 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5070 Make it possible to build with GCC-4.6+ -O2 -flto.
5072 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5074 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5076 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5077 Call minibuffer-inactive-mode.
5079 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5081 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5082 Update dependencies.
5084 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5086 * data.c (init_data): Remove code for UTS, this system is not
5089 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5091 Don't force ./temacs to start in terminal mode.
5093 * frame.c (make_initial_frame): Initialize faces in all cases, not
5094 only when CANNOT_DUMP is defined.
5095 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5097 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5099 * dispnew.c (add_window_display_history): Use const for the string
5100 pointer. Remove declaration, not needed.
5102 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5104 Use 'inline', not 'INLINE'.
5105 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5106 * alloc.c, fontset.c (INLINE): Remove.
5107 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5108 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5109 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5110 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5111 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5113 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5115 Make it possible to run ./temacs.
5117 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5118 syms_of_callproc does the same thing. Remove test for
5119 "initialized", do it in the caller.
5120 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5122 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5124 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5125 (read_minibuf): Use get_minibuffer.
5126 (syms_of_minibuf): Use DEFSYM.
5127 (Qmetadata): New var.
5128 * data.c (Qbuffer): Don't make it static.
5129 (syms_of_data): Use DEFSYM.
5131 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5133 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5134 (CCL_CODE_MIN): New macro.
5136 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5138 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5140 * eval.c (Qdebug): Now static.
5141 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5142 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5143 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5145 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5147 * image.c: Various fixes to ImageMagick code comments.
5148 (Fimagemagick_types): Doc fix.
5150 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5152 Minor fixes prompted by GCC 4.6.0 warnings.
5154 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5156 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5157 (x_clipboard_manager_save_all): Move extern decl to ...
5158 * xterm.h: ... here, so that it can be checked for consistency.
5160 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5162 * xselect.c (x_clipboard_manager_save_frame)
5163 (x_clipboard_manager_save_all): New functions.
5164 (Fx_clipboard_manager_save): Lisp function deleted.
5166 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5167 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5169 * xterm.h: Update prototype.
5171 2011-05-28 William Xu <william.xwl@gmail.com>
5173 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5176 2011-05-28 Jim Meyering <meyering@redhat.com>
5178 Avoid a sign-extension bug in crypto_hash_function.
5179 * fns.c (to_uchar): Define.
5180 (crypto_hash_function): Use it to convert some newly-signed
5181 variables to unsigned, to avoid sign-extension bugs. For example,
5182 without this change, (md5 "truc") would evaluate to
5183 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5184 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5185 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5187 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5189 Integer overflow fixes.
5191 * dbusbind.c: Serial number integer overflow fixes.
5192 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5193 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5194 to hold a serial number that is too large for a fixnum.
5195 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5196 Check for serial numbers out of range. Decode any serial number
5197 that was so large that it became a float. (Bug#8722)
5199 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5200 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5201 Use XFASTINT rather than XUINT when numbers are nonnegative.
5202 (xd_append_arg, Fdbus_method_return_internal):
5203 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5204 arguments, check that Lisp number is nonnegative, rather than
5205 silently wrapping negative numbers around. (Bug#8722)
5206 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5209 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5211 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5213 ccl: add integer overflow checks
5214 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5215 (IN_INT_RANGE): New macros.
5216 (ccl_driver): Use them to check for integer overflow when
5217 decoding a CCL program. Many of the new checks are whether XINT (x)
5218 fits in int; it doesn't always, on 64-bit hosts. The new version
5219 doesn't catch all possible integer overflows, but it's an
5220 improvement. (Bug#8719)
5222 * alloc.c (make_event_array): Use XINT, not XUINT.
5223 There's no need for unsigned here.
5225 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5226 This follows up to the 2011-05-06 change that substituted uintptr_t
5227 for EMACS_INT. This case wasn't caught back then.
5229 Rework Fformat to avoid integer overflow issues.
5230 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5231 now (part of C89). Include <verify.h>.
5232 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5233 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5234 (Fformat): Avoid the prepass trying to compute sizes; it was only
5235 approximate and thus did not catch overflow reliably. Instead, walk
5236 through the format just once, formatting and computing sizes as we go,
5237 checking for integer overflow at every step, and allocating a larger
5238 buffer as needed. Keep track separately whether the format is
5239 multibyte. Keep only the most-recently calculated precision, rather
5240 than them all. Record whether each argument has been converted to
5241 string. Use EMACS_INT, not int, for byte and char and arg counts.
5242 Support field widths and precisions larger than INT_MAX. Avoid
5243 sprintf's undefined behavior with conversion specifications such as %#d
5244 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5245 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5246 formatting out-of-range floating point numbers with int
5249 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5251 * data.c: Avoid integer truncation in expressions involving floats.
5252 * data.c: Include <intprops.h>.
5253 (arith_driver): When there's an integer overflow in an expression
5254 involving floating point, convert the integers to floating point
5255 so that the resulting value does not suffer from catastrophic
5256 integer truncation. For example, on a 64-bit host (* 4
5257 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5258 Do not rely on undefined behavior after integer overflow.
5260 merge count_size_as_multibyte, parse_str_to_multibyte
5261 * character.c, character.h (count_size_as_multibyte):
5262 Rename from parse_str_to_multibyte; all uses changed.
5263 Check for integer overflow.
5264 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5265 since it's now a duplicate of the other. This is more of
5266 a character than a buffer op, so better that it's in character.c.
5267 * fns.c, print.c: Adjust to above changes.
5269 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5271 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5273 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5275 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5276 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5277 (x_clipboard_manager_save): Now static.
5278 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5280 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5281 (crypto_hash_function): Now static.
5282 Fix pointer signedness problems. Avoid unnecessary initializations.
5284 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5286 * termhooks.h (Vselection_alist): Make it terminal-local.
5288 * terminal.c (create_terminal): Initialize it.
5290 * xselect.c: Support for clipboard managers.
5291 (Vselection_alist): Move to termhooks.h as terminal-local var.
5292 (LOCAL_SELECTION): New macro.
5293 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5294 (symbol_to_x_atom): Remove gratuitous arg.
5295 (x_handle_selection_request, lisp_data_to_selection_data)
5296 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5297 (x_own_selection, x_get_local_selection, x_convert_selection):
5298 New arg, specifying work frame. Use terminal-local Vselection_alist.
5299 (some_frame_on_display): Delete unused function.
5300 (Fx_own_selection_internal, Fx_get_selection_internal)
5301 (Fx_disown_selection_internal, Fx_selection_owner_p)
5302 (Fx_selection_exists_p): New optional frame arg.
5303 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5304 (x_handle_selection_clear): Don't treat other terminals with the
5305 same keyboard specially. Use the terminal-local Vselection_alist.
5306 (x_clear_frame_selections): Use Frun_hook_with_args.
5308 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5310 * xterm.h: Add support for those atoms.
5312 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5314 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5315 (converted_selections, conversion_fail_tag): New global variables.
5316 (x_selection_request_lisp_error): Free the above.
5317 (x_get_local_selection): Remove unnecessary code.
5318 (x_reply_selection_request): Args changed; handle arbitrary array
5319 of converted selections stored in converted_selections.
5320 Separate the XChangeProperty and SelectionNotify steps.
5321 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5322 (x_convert_selection): New function.
5323 (x_handle_selection_event): Simplify.
5324 (x_get_foreign_selection): Don't ignore incoming requests while
5325 waiting for an answer; this will fail when we implement
5326 SAVE_TARGETS, and seems unnecessary anyway.
5327 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5328 (Vx_sent_selection_functions): Doc fix.
5330 2011-05-26 Leo Liu <sdl.web@gmail.com>
5332 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5334 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5336 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5338 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5339 for fringe update if it has periodic bitmap.
5340 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5341 and fringe_bitmap_periodic_p.
5343 * fringe.c (get_fringe_bitmap_data): New function.
5344 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5345 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5346 row. Mark glyph row for fringe update if periodicity changed.
5348 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5349 for fringe update unless it has periodic bitmap.
5351 2011-05-25 Kenichi Handa <handa@m17n.org>
5353 * xdisp.c (get_next_display_element): Set correct it->face_id for
5354 a static composition.
5356 2011-05-24 Leo Liu <sdl.web@gmail.com>
5359 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5361 * fns.c (crypto_hash_function, Fsha1): New function.
5362 (Fmd5): Use crypto_hash_function.
5363 (syms_of_fns): Add Ssha1.
5365 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5367 * gnutls.c: Remove unused macros.
5368 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5369 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5370 Remove macros that are defined and never used.
5371 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5373 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5375 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5376 (Fx_get_selection_internal): Minor cleanup.
5377 (Fx_own_selection_internal): Rename arguments for consistency with
5380 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5382 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5384 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5386 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5388 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5390 * dispnew.c (scrolling_window): Don't exclude the case that the
5391 last enabled row in the desired matrix touches the bottom boundary.
5393 2011-05-21 Glenn Morris <rgm@gnu.org>
5395 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5396 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5397 and add some more files.
5399 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5401 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5402 report_file_error introduced by the change from 2011-05-07.
5404 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5406 * systime.h (Time): Define only if emacs is defined.
5407 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5408 where the include path doesn't have X11/X.h by default. See
5409 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5411 2011-05-20 Kenichi Handa <handa@m17n.org>
5413 * composite.c (find_automatic_composition): Fix previous change.
5415 2011-05-20 Glenn Morris <rgm@gnu.org>
5417 * lisp.mk: New file, split from Makefile.in.
5418 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5419 (shortlisp): Remove.
5420 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5422 2011-05-19 Glenn Morris <rgm@gnu.org>
5424 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5425 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5426 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5427 (lisp): Set the order to that of loadup.el.
5428 (shortlisp): Make it a copy of $lisp.
5429 (SOME_MACHINE_LISP): Remove.
5430 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5431 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5433 2011-05-18 Kenichi Handa <handa@m17n.org>
5435 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5436 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5437 (find_automatic_composition): Mostly rewrite for efficiency.
5439 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5441 * makefile.w32-in: Update dependencies.
5443 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5445 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5446 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5448 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5450 Fix some integer overflow issues, such as string length overflow.
5452 * insdel.c (count_size_as_multibyte): Check for string overflow.
5454 * character.c (lisp_string_width): Check for string overflow.
5455 Use EMACS_INT, not int, for string indexes and lengths; in
5456 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5457 the resulting string length overflows an EMACS_INT; instead,
5458 report a string overflow if no precision given. When checking for
5459 precision exhaustion, use a check that cannot possibly have
5460 integer overflow. (Bug#8675)
5461 * character.h (lisp_string_width): Adjust to new signature.
5463 * alloc.c (string_overflow): New function.
5464 (Fmake_string): Use it. This doesn't change behavior, but saves
5465 a few bytes and will simplify future changes.
5466 * character.c (string_escape_byte8): Likewise.
5467 * lisp.h (string_overflow): New decl.
5469 Fixups, following up to the user-interface timestamp change.
5470 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5471 for UI timestamps, instead of unsigned long.
5472 * msdos.c (mouse_get_pos): Likewise.
5473 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5474 * w32gui.h (Time): Define by including "systime.h" rather than by
5475 declaring it ourselves. (Bug#8664)
5477 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5478 * image.c (clear_image_cache): Likewise.
5480 * term.c (term_mouse_position): Don't assume time_t wraparound.
5482 Be more systematic about user-interface timestamps.
5483 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5484 and sometimes 'EMACS_UINT', to represent these timestamps.
5485 This change causes it to use 'Time' uniformly, as that's what X uses.
5486 This makes the code easier to follow, and makes it easier to catch
5487 integer overflow bugs such as Bug#8664.
5488 * frame.c (Fmouse_position, Fmouse_pixel_position):
5489 Use Time, not unsigned long, for user-interface timestamps.
5490 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5491 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5492 * keyboard.h (last_event_timestamp): Likewise.
5493 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5494 * menu.h (xmenu_show): Likewise.
5495 * term.c (term_mouse_position): Likewise.
5496 * termhooks.h (struct input_event.timestamp): Likewise.
5497 (struct terminal.mouse_position_hook): Likewise.
5498 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5499 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5500 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5501 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5503 * menu.h, termhooks.h: Include "systime.h", for Time.
5505 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5506 Don't assume that the difference between two unsigned long values
5507 can fit into an integer. At this point, we know button_down_time
5508 <= event->timestamp, so the difference must be nonnegative, so
5509 there's no need to cast the result if double-click-time is
5510 nonnegative, as it should be; check that it's nonnegative, just in
5511 case. This bug is triggered when events are more than 2**31 ms
5512 apart (about 25 days). (Bug#8664)
5514 * xselect.c (last_event_timestamp): Remove duplicate decl.
5515 (x_own_selection): Remove needless cast to unsigned long.
5517 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5518 that always fit in int. Use a sentinel instead of a counter, to
5519 avoid a temp and to allay GCC's concerns about possible int overflow.
5520 * frame.h (struct frame): Use int for menu_bar_items_used
5521 instead of EMACS_INT, since it always fits in int.
5523 * menu.c (grow_menu_items): Check for int overflow.
5525 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5527 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5528 Before, the code was not consistent. These values cannot exceed
5529 2**31 - 1 so there's no need to make them unsigned.
5530 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5531 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5532 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5534 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5536 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5537 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5538 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5539 presumably because the widths might not match.
5541 * window.c (size_window): Avoid needless test at loop start.
5543 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5545 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5547 2011-05-12 Drew Adams <drew.adams@oracle.com>
5549 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5551 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5553 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5554 `width' to `bar_area_x' and `bar_area_width', respectively.
5555 (x_scroll_run): Take account of fringe background extension.
5557 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5558 Rename local vars `left' and `width' to `bar_area_x' and
5559 `bar_area_width', respectively.
5560 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5561 background extension.
5563 2011-05-10 Jim Meyering <meyering@redhat.com>
5565 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5567 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5569 * image.c (Finit_image_library): Return t for built-in image types,
5570 like pbm and xbm. (Bug#8640)
5572 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5574 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5576 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5578 * w32console.c (Fset_screen_color): Doc fix.
5579 (Fget_screen_color): New function.
5580 (syms_of_ntterm): Defsubr it.
5582 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5583 unlink the temporary file if Fcall_process didn't create it in the
5585 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5586 child process will be redirected to a file specified with `:file'.
5587 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5588 cue to call_process_cleanup not to close that handle.
5590 2011-05-07 Ben Key <bkey76@gmail.com>
5592 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5593 one of two shell specific rules, either bootstrap-temacs-CMD or
5594 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5595 to the previous implementation of the bootstrap-temacs rule.
5596 The bootstrap-temacs-CMD rule is similar to the previous
5597 implementation of the bootstrap-temacs rule except that it
5598 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5601 These changes, along with some changes to nt/configure.bat,
5602 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5603 earlier fix to add support for --cflags and --ldflags options
5604 that include quotes so that it works whether make uses cmd or
5607 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
5609 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5610 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5612 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5613 a string. Handle both cases.
5614 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5615 (Fdbus_register_method): Use Qinvalid_function.
5617 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5619 * makefile.w32-in: Update dependencies.
5620 (LISP_H): Add inttypes.h and stdin.h.
5621 (PROCESS_H): Add unistd.h.
5623 2011-05-06 Eli Zaretskii <eliz@gnu.org>
5625 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5626 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5628 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
5630 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5632 * term.c (vfatal): Remove stray call to va_end.
5633 It's not needed and the C Standard doesn't allow it here anyway.
5635 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5636 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5638 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5641 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5643 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5645 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5647 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5649 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5651 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5652 * charset.c (Fdefine_charset_internal): Don't initialize
5653 charset.code_space[15]. The value was garbage, on hosts with
5654 32-bit int (Bug#8600).
5656 * lread.c (read_integer): Be more consistent with string-to-number.
5657 Use string_to_number to do the actual conversion; this avoids
5658 rounding errors and fixes some other screwups. Without this fix,
5659 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5660 (digit_to_number): Move earlier, for benefit of read_integer.
5661 Return -1 if the digit is out of range for the base, -2 if it is
5662 not a digit in any supported base. (Bug#8602)
5664 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5666 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5667 to match comment at start of function. This also removes a
5668 GCC warning about overflow in a 32+64-bit port.
5670 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5672 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5673 Reported by Stefan Monnier in
5674 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
5675 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5676 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
5678 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5679 (EMACS_UINTPTR): Likewise, with uintptr_t.
5681 * lisp.h: Prefer 64-bit EMACS_INT if available.
5682 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5683 on 32-bit hosts that have 64-bit int, so that they can access
5685 However, temporarily disable this change unless the temporary
5686 symbol WIDE_EMACS_INT is defined.
5688 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5690 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5691 This removes an assumption that EMACS_INT and long are the same
5692 width as pointers. The assumption is true for Emacs porting targets
5693 now, but we want to make other targets possible.
5694 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5695 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5696 In the rest of the code, change types of integers that hold casted
5697 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5698 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5699 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5700 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5701 No need to cast type when ORing.
5702 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5703 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5704 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5705 assume EMACS_INT is the same width as char *.
5706 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5707 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5708 Remove no-longer-needed casts.
5709 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5710 (xg_tool_bar_help_callback, xg_make_tool_item):
5711 Use EMACS_INTPTR to hold an integer
5712 that will be cast to void *; this can avoid a GCC warning
5713 if EMACS_INT is not the same width as void *.
5714 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5715 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5716 (current_message_1, set_message_1):
5717 Use a local to convert to proper width without a cast.
5718 * xmenu.c (dialog_selection_callback): Likewise.
5720 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5721 Also, don't assume VALBITS / RAND_BITS is less than 5,
5722 and don't rely on undefined behavior when shifting a 1 left into
5724 * lisp.h (get_random): Change signature to match.
5726 * lread.c (hash_string): Use size_t, not int, for hash computation.
5727 Normally we prefer signed values; but hashing is special, because
5728 it's better to use unsigned division on hash table sizes so that
5729 the remainder is nonnegative. Also, size_t is the natural width
5730 for hashing into memory. The previous code used 'int', which doesn't
5731 retain enough info to hash well into very large tables.
5732 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5734 * dbusbind.c: Don't possibly lose pointer info when converting.
5735 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5736 Use XPNTR rather than XHASH, so that the high-order bits of
5737 the pointer aren't lost when converting through void *.
5739 * eval.c (Fautoload): Don't double-shift a pointer.
5741 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5743 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5745 * gnutls.c (DEF_GNUTLS_FN):
5746 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5748 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5750 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5753 2011-05-05 Eli Zaretskii <eliz@gnu.org>
5755 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5756 New version that can reserve upto 2GB of heap space.
5758 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
5760 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5762 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5764 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5765 `gnutls_certificate_set_x509_key_file'.
5767 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
5769 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5770 Update dependencies.
5772 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5774 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5775 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5776 Remove unused parameter `fildes'.
5777 * process.c (read_process_output, send_process): Don't pass it.
5779 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5781 Fix previous change: the library cache is defined in w32.c.
5782 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5783 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5785 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5787 Implement dynamic loading of GnuTLS on Windows.
5789 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5790 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5791 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5794 * gnutls.c (Qgnutls_dll): Define.
5795 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5796 (gnutls_*): Declare function pointers.
5797 (init_gnutls_functions): New function to initialize function pointers.
5798 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5799 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5800 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5801 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5802 (emacs_gnutls_write, emacs_gnutls_read)
5803 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5804 (Fgnutls_available_p): New function.
5805 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5806 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5807 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5809 * image.c: Include w32.h.
5810 (Vimage_type_cache): Delete.
5811 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5812 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5813 (w32_delayed_load): Move to w32.c.
5815 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5817 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5818 (w32_delayed_load): Move from image.c. When loading a library, record
5819 its filename in the :loaded-from property of the library id.
5820 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5821 Initialize and staticpro them.
5822 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5824 * process.c: Include lisp.h before w32.h, not after.
5825 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5826 instead of gnutls_record_check_pending.
5828 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5830 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5832 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5833 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5836 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5838 * xterm.c (x_set_frame_alpha): Do not set property on anything
5839 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5841 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5843 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5845 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5847 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5848 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5849 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5850 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5851 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5852 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5853 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5854 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5855 (Qgnutls_bootprop_callbacks_verify): Make static.
5857 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5859 * callproc.c: Indentation fixup.
5861 * sysdep.c (wait_for_termination_1): Make static.
5862 (wait_for_termination, interruptible_wait_for_termination):
5863 Move after wait_for_termination_1.
5865 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5867 * sysdep.c (interruptible_wait_for_termination): New function
5868 which is like wait_for_termination, but allows keyboard
5871 * callproc.c (Fcall_process): Add (:file "file") as an option for
5873 (Fcall_process_region): Ditto.
5875 2011-04-30 Eli Zaretskii <eliz@gnu.org>
5877 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5878 rather than `XVECTOR (FOO)->size'.
5880 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5881 inttypes.h, as a gnulib replacement is used if it not available in
5884 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5886 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5887 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5888 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5890 * coding.c (coding_alloc_by_realloc): Error out if destination
5891 will grow beyond MOST_POSITIVE_FIXNUM.
5892 (decode_coding_emacs_mule): Abort if there isn't enough place in
5893 charbuf for the composition carryover bytes. Reserve an extra
5894 space for up to 2 characters produced in a loop.
5895 (decode_coding_iso_2022): Abort if there isn't enough place in
5896 charbuf for the composition carryover bytes.
5898 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5900 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5901 aborting when %lld or %lll format is passed.
5902 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5903 %llo or %llx format is passed. (Bug#8545)
5905 * window.c (window_scroll_line_based): Use a marker instead of
5906 simple variables to record original value of point. (Bug#7952)
5908 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5909 produced by %s or %c overflows available buffer space. (Bug#8545)
5911 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5913 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5914 (SIZE_MAX): Move defn after all includes, as they might #define it.
5916 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5918 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5920 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5922 * keyboard.c (Qdelayed_warnings_hook): Define.
5923 (command_loop_1): Run `delayed-warnings-hook'
5924 if Vdelayed_warnings_list is non-nil.
5925 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5926 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5928 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5930 * doprnt.c (doprnt): Don't return value smaller than the buffer
5931 size if the message was truncated. (Bug#8545).
5933 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5935 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5936 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5938 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5940 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5942 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5944 * makefile.w32-in: Update dependencies.
5946 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5948 Improve `doprnt' and its usage. (Bug#8545)
5949 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5950 `format_end'. Remove support for %l as a conversion specifier.
5951 Don't use xrealloc. Improve diagnostics when the %l size modifier
5952 is used. Update the commentary.
5954 * eval.c (verror): Simplify calculation of size_t.
5956 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5959 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5961 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5964 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5966 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5967 This makes this file independent of the recent pseudovector change.
5969 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5971 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5973 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5974 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5975 Remove unused local.
5976 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5978 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5979 GCC 4.6.0 optimizes based on type-based alias analysis.
5980 For example, if b is of type struct buffer * and v of type struct
5981 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5982 != &v->size, and therefore "v->size = 1; b->size = 2; return
5983 v->size;" must therefore return 1. This assumption is incorrect
5984 for Emacs, since it type-puns struct Lisp_Vector * with many other
5985 types. To fix this problem, this patch adds a new type struct
5986 vectorlike_header that documents the constraints on layout of vectors
5987 and pseudovectors, and helps optimizing compilers not get fooled
5988 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5989 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5990 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5992 (XSETPVECTYPE): Rewrite in terms of new macro.
5993 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5994 This is a bit clearer, and further avoids the possibility of
5995 undesirable aliasing.
5996 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5997 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5998 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5999 since Lisp_Subr is a special case (no "next" field).
6000 (ASIZE): Now uses header.size rather than size.
6001 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6002 to avoid the hassle of writing XVECTOR (foo)->header.size.
6003 (struct vectorlike_header): New type.
6004 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6005 object, to help avoid aliasing.
6006 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6007 (SUBRP): Likewise, since Lisp_Subr is a special case.
6008 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6009 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6010 (struct Lisp_Hash_Table): Combine first two members into a single
6011 struct vectorlike_header member. All uses of "size" and "next" members
6012 changed to be "header.size" and "header.next".
6013 * buffer.h (struct buffer): Likewise.
6014 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6015 * frame.h (struct frame): Likewise.
6016 * process.h (struct Lisp_Process): Likewise.
6017 * termhooks.h (struct terminal): Likewise.
6018 * window.c (struct save_window_data, struct saved_window): Likewise.
6019 * window.h (struct window): Likewise.
6020 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6021 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6022 * buffer.c (init_buffer_once): Likewise.
6023 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6025 * process.c (Fformat_network_address): Use local var for size,
6028 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6030 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6031 * data.c (atof): Remove decl; no longer used or needed.
6032 (digit_to_number): Move to lread.c.
6033 (Fstring_to_number): Use new string_to_number function, to be
6034 consistent with how the Lisp reader treats infinities and NaNs.
6035 Do not assume that floating-point numbers represent EMACS_INT
6036 without losing information; this is not true on most 64-bit hosts.
6037 Avoid double-rounding errors, by insisting on integers when
6038 parsing non-base-10 numbers, as the documentation specifies.
6039 * lisp.h (string_to_number): New decl, replacing ...
6040 (isfloat_string): Remove.
6041 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6042 (read1): Do not accept +. and -. as integers; this
6043 appears to have been a coding error. Similarly, do not accept
6044 strings like +-1e0 as floating point numbers. Do not report
6045 overflow for integer overflows unless the base is not 10 which
6046 means we have no simple and reliable way to continue.
6047 Break out the floating-point parsing into a new
6048 function string_to_number, so that Fstring_to_number parses
6049 floating point numbers consistently with the Lisp reader.
6050 (digit_to_number): Move here from data.c. Make it static inline.
6051 (E_CHAR, EXP_INT): Remove, replacing with ...
6052 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6053 (string_to_number): New function, replacing isfloat_string.
6054 This function checks for valid syntax and produces the resulting
6055 Lisp float number too. Rework it so that string-to-number
6056 no longer mishandles examples like "1.0e+". Use strtoumax,
6057 so that overflow for non-base-10 numbers is reported only when
6058 there's no portable and simple way to convert to floating point.
6060 * textprop.c (set_text_properties_1): Rewrite for clarity,
6061 and to avoid GCC warning about integer overflow.
6063 * intervals.h (struct interval): Use EMACS_INT for members
6064 where EMACS_UINT might cause problems. See
6065 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6066 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6067 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6069 (offset_intervals): Tell GCC not to worry about length overflow
6070 when negating a negative length.
6072 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6073 (overrun_check_free): Likewise.
6075 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6076 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6079 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6080 (gnutls_make_error): Rename local to avoid shadowing.
6081 (gnutls_emacs_global_deinit): ifdef out; not used.
6082 (Fgnutls_boot): Use const for pointer to readonly storage.
6083 Comment out unused local. Fix pointer signedness problems.
6085 * lread.c (openp): Don't stuff size_t into an 'int'.
6086 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6087 about possible signed overflow.
6089 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6090 (GDK_KEY_g): Don't define if already defined.
6091 (xg_prepare_tooltip): Avoid pointer signedness problem.
6092 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6094 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6095 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6097 * xfns.c (Fx_window_property): Simplify a bit,
6098 to make a bit faster and to avoid GCC 4.6.0 warning.
6099 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6101 * fns.c (internal_equal): Don't assume size_t fits in int.
6103 * alloc.c (compact_small_strings): Tighten assertion a little.
6105 Replace pEd with more-general pI, and fix some printf arg casts.
6106 * lisp.h (pI): New macro, generalizing old pEd macro to other
6107 conversion specifiers. For example, use "...%"pI"d..." rather
6108 than "...%"pEd"...".
6109 (pEd): Remove. All uses replaced with similar uses of pI.
6110 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6111 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6112 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6113 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6114 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6115 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6116 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6118 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6119 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6120 * print.c (safe_debug_print, print_object): Likewise.
6121 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6123 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6124 avoiding the 0 flag, which is not portable.
6125 * process.c (Fmake_network_process): Use pI to avoid cast.
6126 * region-cache.c (pp_cache): Likewise.
6127 * xdisp.c (decode_mode_spec): Likewise.
6128 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6129 behavior on 64-bit hosts with printf arg.
6130 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6131 (x_stop_queuing_selection_requests): Likewise.
6132 (x_get_window_property): Don't truncate byte count to an 'int'
6135 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6136 here, since it parses constructs like leading '-' and spaces,
6137 which are not wanted; and it overflows with large numbers.
6138 Instead, simply match F[0-9]+, which is what is wanted anyway.
6140 * alloc.c: Remove unportable assumptions about struct layout.
6141 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6142 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6143 (allocate_vectorlike, make_pure_vector): Use the new macros,
6144 plus offsetof, to remove unportable assumptions about struct layout.
6145 These assumptions hold on all porting targets that I know of, but
6146 they are not guaranteed, they're easy to remove, and removing them
6147 makes further changes easier.
6149 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6150 This doesn't fix a bug but makes the code clearer.
6151 (string_overrun_cookie): Now const. Use initializers that
6152 don't formally overflow signed char, to avoid warnings.
6153 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6154 can cause Emacs to crash when string overrun checking is enabled.
6155 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6156 multiple of sizeof (EMACS_INT); it need not be, if
6157 alignof(EMACS_INT) < sizeof (EMACS_INT).
6158 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6160 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6162 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6164 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6166 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6167 supposed to be handshaking. (Bug#8556)
6168 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6170 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6172 * lisp.h (Qdebug): List symbol.
6173 * eval.c (Qdebug): Restore global linkage.
6174 * keyboard.c (debug-on-event): New variable.
6175 (handle_user_signal): Break into debugger when debug-on-event
6176 matches the current signal symbol.
6178 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6180 * alloc.c (check_sblock, check_string_bytes)
6181 (check_string_free_list): Convert to standard C.
6183 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6185 * w32.c (emacs_gnutls_push): Fix typo.
6187 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6189 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6190 "cast to pointer from integer of different size".
6192 Improve doprnt and its use in verror. (Bug#8545)
6193 * doprnt.c (doprnt): Document the set of format control sequences
6194 supported by the function. Use SAFE_ALLOCA instead of always
6197 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6198 is one byte too soon. Don't use xrealloc; instead xfree and
6201 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6203 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6206 * gnutls.c: Renamed global_initialized to
6207 gnutls_global_initialized. Added internals for the
6208 :verify-hostname-error, :verify-error, and :verify-flags
6209 parameters of `gnutls-boot' and documented those parameters in the
6210 docstring. Start callback support.
6211 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6212 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6213 on error. Return error code.
6214 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6215 (emacs_gnutls_read): Likewise.
6216 (Fgnutls_boot): Return handshake error code.
6217 (emacs_gnutls_handle_error): New function.
6218 (wsaerror_to_errno): Likewise.
6220 * w32.h (emacs_gnutls_pull): Add prototype.
6221 (emacs_gnutls_push): Likewise.
6223 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6224 (emacs_gnutls_push): Likewise.
6226 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6228 * process.c (wait_reading_process_output): Check if GnuTLS
6229 buffered some data internally if no FDs are set for TLS
6232 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6233 (LIBS): Link to USER_LIBS.
6234 ($(BLD)/gnutls.$(0)): New target.
6236 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6238 * xdisp.c (handle_single_display_spec): Rename the
6239 display_replaced_before_p argument into display_replaced_p, to
6240 make it consistent with the commentary. Fix typos in the
6243 * textprop.c (syms_of_textprop): Remove dead code.
6244 (copy_text_properties): Delete obsolete commentary about an
6245 interface that was deleted long ago. Fix typos in the description
6248 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6249 to changes in oldXMenu/XMenu.h from 2011-04-16.
6250 <menu_help_message, prev_menu_help_message>: Constify.
6251 (IT_menu_make_room): menu->help_text is now `const char **';
6254 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6255 to changes in oldXMenu/XMenu.h from 2011-04-16.
6256 (struct XMenu): Declare `help_text' `const char **'.
6258 * xfaces.c <Qunspecified>: Make extern again.
6260 * syntax.c: Include sys/types.h before including regex.h, as
6263 * doc.c (get_doc_string): Improve the format passed to `error'.
6265 * doprnt.c (doprnt): Improve commentary.
6267 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6269 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6272 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6273 changes in globals.h immediately force recompilation.
6274 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6275 $(CURDIR)/s/ms-w32.h.
6276 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6278 * character.c (Fchar_direction): Function deleted.
6279 (syms_of_character): Don't defsubr it.
6280 <char-direction-table>: Deleted.
6282 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6284 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6285 * doprnt.c: Include limits.h.
6286 (SIZE_MAX): New macro.
6287 (doprnt): Return a size_t value. 2nd arg is now size_t.
6288 Many local variables are now size_t instead of int or unsigned.
6289 Improve overflow protection. Support `l' modifier for integer
6290 conversions. Support %l conversion. Don't assume an EMACS_INT
6291 argument for integer conversions and for %c.
6293 * lisp.h (doprnt): Restore prototype.
6295 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6298 * Makefile.in (base_obj): Add back doprnt.o.
6300 * deps.mk (doprnt.o): Add back prerequisites.
6301 (callint.o): Depend on character.h.
6303 * eval.c (internal_lisp_condition_case): Include the handler
6304 representation in the error message.
6305 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6306 when breaking from the loop.
6308 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6310 * callint.c (Fcall_interactively): When displaying error message
6311 about invalid control letter, pass the character's codepoint, not
6312 a pointer to its multibyte form. Improve display of the character
6313 in octal and display also its hex code.
6315 * character.c (char_string): Use %x to display the (unsigned)
6316 codepoint of an invalid character, to avoid displaying a bogus
6319 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6320 `error', not SYMBOL_NAME itself.
6322 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6323 character arguments to `error'.
6325 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6326 to `error' in error message about FINAL_CHAR argument. Make sure
6327 FINAL_CHAR is a character, and use %c when it is passed as
6328 argument to `error'.
6330 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6332 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6334 * w32.c: Include <time.h>.
6335 (sys_localtime): New function.
6337 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6339 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6341 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6343 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6345 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6348 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6350 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6351 gl_state.e_property when gl_state.object is Qt.
6353 * insdel.c (make_gap_larger): Remove limitation of buffer size
6356 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6358 * xdisp.c (lookup_glyphless_char_display)
6359 (produce_glyphless_glyph): Handle cons cell entry in
6360 glyphless-char-display.
6361 (Vglyphless_char_display): Document it.
6363 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6364 glyphless-char-display.
6366 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6368 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6370 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6372 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6373 definition for no-X builds.
6375 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6377 Static checks with GCC 4.6.0 and non-default toolkits.
6379 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6381 * process.c (keyboard_bit_set): Define only if SIGIO.
6382 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6383 (send_process): Repair possible setjmp clobbering.
6385 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6387 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6389 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6391 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6392 Define only if needed.
6394 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6395 by pacifying GCC about it. Maybe it's time to retire it?
6396 * xfaces.c (USG, __TIMEVAL__): Likewise.
6398 * dispextern.h (struct redisplay_interface): Rename param
6400 * termhooks.h (struct terminal): Likewise.
6401 * xterm.c (xembed_send_message): Likewise.
6403 * insdel.c (make_gap_smaller): Define only if
6404 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6406 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6409 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6410 so that we aren't warned about unused symbols.
6412 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6414 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6416 * xfns.c (x_real_positions): Mark locals as initialized.
6418 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6420 * xterm.c: Fix problems found by static analysis with other toolkits.
6421 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6422 (x_dispatch_event): Declare static if USE_GTK, and
6423 define if USE_GTK || USE_X_TOOLKIT.
6424 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6425 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6426 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6427 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6429 * xmenu.c (menu_help_callback): Pointer type fixes.
6430 Use const pointers when pointing at readonly data. Avoid pointer
6432 (FALSE): Remove unused macro.
6433 (update_frame_menubar): Remove unused decl.
6435 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6437 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6438 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6439 (single_menu_item): Rename local to avoid shadowing.
6441 * keyboard.c (make_lispy_event): Remove unused local var.
6443 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6444 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6446 * bitmaps: Change bitmaps from unsigned char back to the X11
6447 compatible char. Avoid the old compiler warnings about
6448 out-of-range initializers by using, for example, '\xab' rather
6451 * xgselect.c (xgselect_initialize): Check vs interface
6452 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6454 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6456 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6457 to read-only memory.
6459 * fns.c (vector): Remove; this old hack is no longer needed.
6461 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6463 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6465 * xrdb.c (x_load_resources): Omit unused local.
6467 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6468 (x_window): Rename locals to avoid shadowing.
6469 (USG): Use the kludged USG macro, to pacify gcc.
6471 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6472 (x_term_init): Remove local to avoid shadowing.
6474 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6476 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6477 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6479 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6481 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6483 Fix regex.c, syntax.c and friends for buffers > 2GB.
6484 * syntax.h (struct gl_state_s): Declare character position members
6487 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6489 * textprop.c (verify_interval_modification, interval_of):
6490 Declare arguments EMACS_INT.
6492 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6495 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6497 * indent.c (Fvertical_motion): Local variable it_start is now
6500 * regex.c (re_match, re_match_2, re_match_2_internal)
6501 (bcmp_translate, regcomp, regexec, print_double_string)
6502 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6503 (re_compile_pattern, re_exec): Declare arguments and local
6504 variables `size_t' and `ssize_t' and return values `regoff_t', as
6506 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6507 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6508 <compile_stack_type>: `size' and `avail' are now `size_t'.
6510 * regex.h <regoff_t>: Use ssize_t, not int.
6511 (re_search, re_search_2, re_match, re_match_2): Arguments that
6512 specify buffer/string position and length are now ssize_t and
6513 size_t. Return type is regoff_t.
6515 2011-04-16 Ben Key <bkey76@gmail.com>
6517 * nsfont.m: Fixed bugs in ns_get_family and
6518 ns_descriptor_to_entity that were caused by using free to
6519 deallocate memory blocks that were allocated by xmalloc (via
6520 xstrdup). This caused Emacs to crash when compiled with
6521 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6522 --enable-checking=xmallocoverrun). xfree is now used to
6523 deallocate these memory blocks.
6525 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6527 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6529 emacs_write: Accept and return EMACS_INT for sizes.
6530 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6532 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6533 Accept and return EMACS_INT.
6534 (emacs_gnutls_write): Return the number of bytes written on
6536 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6537 (emacs_read, emacs_write): Remove check for negative size, as the
6538 Emacs source code has been audited now.
6539 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6540 (emacs_read, emacs_write): Use it.
6541 * process.c (send_process): Adjust to the new signatures of
6542 emacs_write and emacs_gnutls_write. Do not attempt to store
6543 a byte offset into an 'int'; it might overflow.
6544 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6546 * sound.c: Don't assume sizes fit in 'int'.
6547 (struct sound_device.period_size, alsa_period_size):
6548 Return EMACS_INT, not int.
6549 (struct sound_device.write, vox_write, alsa_write):
6550 Accept EMACS_INT, not int.
6551 (wav_play, au_play): Use EMACS_INT to store sizes and to
6552 record read return values.
6554 2011-04-15 Ben Key <bkey76@gmail.com>
6556 * keyboard.c (Qundefined): Don't declare static since it is used
6558 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6559 static since they are used in nsfont.m.
6561 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6563 * process.c (Qprocessp): Don't declare static.
6564 * lisp.h (Qprocessp): Declare again.
6566 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6568 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6570 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6572 Improve C-level modularity by making more things 'static'.
6574 Don't publish debugger-only interfaces to other modules.
6575 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6576 (verify_bytepos, count_markers): Move decls to the only modules
6578 * region-cache.h (pp_cache): Likewise.
6579 * window.h (check_all_windows): Likewise.
6580 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6582 * sysdep.c (croak): Now static, if
6583 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6584 * syssignal.h (croak): Declare only if not static.
6586 * alloc.c (refill_memory_reserve): Now static if
6587 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6588 * lisp.h (refill_memory_reserve): Declare only if not static.
6590 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6591 Define only if USE_LUCID.
6593 * xrdb.c (x_customization_string, x_rm_string): Now static.
6595 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6596 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6598 * xdisp.c (draw_row_with_mouse_face): Now static.
6599 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6601 * window.h (check_all_windows): Mark externally visible.
6603 * window.c (window_deletion_count): Now static.
6605 * undo.c: Make symbols static if they're not exported.
6606 (last_undo_buffer, last_boundary_position, pending_boundary):
6609 * textprop.c (interval_insert_behind_hooks): Now static.
6610 (interval_insert_in_front_hooks): Likewise.
6612 * term.c: Make symbols static if they're not exported.
6613 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6614 (max_frame_lines, tty_set_terminal_modes):
6615 (tty_reset_terminal_modes, tty_turn_off_highlight):
6616 (get_tty_terminal): Now static.
6617 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6618 * termhooks.h (term_mouse_moveto): Do not declare if
6620 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6621 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6623 * sysdep.c: Make symbols static if they're not exported.
6624 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6626 (sigprocmask_set, full_mask): Remove; unused.
6627 (wait_debugging): Mark as visible.
6628 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6629 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6631 * syntax.c (syntax_temp): Define only if !__GNUC__.
6633 * sound.c (current_sound_device, current_sound): Now static.
6635 * search.c (searchbufs, searchbuf_head): Now static.
6637 * scroll.c (scroll_cost): Remove; unused.
6638 * dispextern.h (scroll_cost): Remove decl.
6640 * region-cache.h (pp_cache): Mark as externally visible.
6642 * process.c: Make symbols static if they're not exported.
6643 (process_tick, update_tick, create_process, chan_process):
6644 (Vprocess_alist, proc_buffered_char, datagram_access):
6645 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6646 (deactivate_process): Mark defn as static, as well as decl.
6647 * lisp.h (create_process): Remove decl.
6648 * process.h (chan_process, Vprocess_alist): Remove decls.
6650 * print.c: Make symbols static if they're not exported.
6651 (print_depth, new_backquote_output, being_printed, print_buffer):
6652 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6653 (print_interval, print_number_index, initial_stderr_stream):
6655 * lisp.h (Fprinc): Remove decl.
6656 (debug_output_compilation_hack): Mark as externally visible.
6658 * sysdep.c (croak): Move decl from here to syssignal.h.
6659 * syssignal.h (croak): Put it here, so the API can be checked when
6660 'croak' is called from dissociate_if_controlling_tty.
6662 * minibuf.c: Make symbols static if they're not exported.
6663 (minibuf_save_list, choose_minibuf_frame): Now static.
6664 * lisp.h (choose_minibuf_frame): Remove decl.
6666 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6668 * lread.c: Make symbols static if they're not exported.
6669 (read_objects, initial_obarray, oblookup_last_bucket_number):
6671 (make_symbol): Remove; unused.
6672 * lisp.h (initial_obarray, make_symbol): Remove decls.
6674 * keyboard.c: Make symbols static if they're not exported.
6675 (single_kboard, recent_keys_index, total_keys, recent_keys):
6676 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6677 (this_single_command_key_start, echoing, last_auto_save):
6678 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6679 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6680 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6681 (Vlispy_mouse_stem, double_click_count):
6683 (force_auto_save_soon): Define only if SIGDANGER.
6684 (ignore_mouse_drag_p): Now static if
6685 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6686 (print_help): Remove; unused.
6687 (stop_character, last_timer_event): Mark as externally visible.
6688 * keyboard.h (ignore_mouse_drag_p): Declare only if
6689 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6690 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6691 * lisp.h (echoing): Remove decl.
6692 (force_auto_save_soon): Declare only if SIGDANGER.
6693 * xdisp.c (redisplay_window): Simplify code, to make it more
6694 obvious that ignore_mouse_drag_p is not accessed if !defined
6695 USE_GTK && !defined HAVE_NS.
6697 * intervals.c: Make symbols static if they're not exported.
6698 (merge_properties_sticky, merge_interval_right, delete_interval):
6700 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6702 * insdel.c: Make symbols static if they're not exported.
6703 However, leave prepare_to_modify_buffer alone. It's never
6704 called from outside this function, but that appears to be a bug.
6705 (combine_after_change_list, combine_after_change_buffer):
6706 (adjust_after_replace, signal_before_change): Now static.
6707 (adjust_after_replace_noundo): Remove; unused.
6708 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
6709 (signal_before_change): Remove decls.
6711 * indent.c (val_compute_motion, val_vmotion): Now static.
6713 * image.c: Make symbols static if they're not exported.
6714 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6716 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6717 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6719 * fringe.c (standard_bitmaps): Now static.
6720 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6722 * frame.c: Make symbols static if they're not exported.
6723 (x_report_frame_params, make_terminal_frame): Now static.
6724 (get_frame_param): Now static, unless HAVE_NS.
6725 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6726 (x_get_resource_string): Remove; not used.
6727 * frame.h (make_terminal_frame, x_report_frame_params):
6728 (x_get_resource_string); Remove decls.
6729 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6730 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6732 * font.c, fontset.c: Make symbols static if they're not exported.
6733 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6734 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6735 * font.c (font_close_object): Now static.
6736 * font.h (font_close_object): Remove.
6737 * fontset.c (FONTSET_OBJLIST): Remove.
6738 (free_realized_fontset) #if-0 the body, which does nothing.
6739 (face_suitable_for_char_p): #if-0, as it's never called.
6740 * fontset.h (face_suitable_for_char_p): Remove decl.
6741 * xfaces.c (face_at_string_position):
6742 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
6743 since 0 is always ASCII.
6745 * fns.c (weak_hash_tables): Now static.
6747 * fileio.c: Make symbols static if they're not exported.
6748 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6749 (Vwrite_region_annotation_buffers): Now static.
6751 * eval.c: Make symbols static if they're not exported.
6752 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6753 * lisp.h (backtrace_list): Remove decl.
6755 * emacs.c: Make symbols static if they're not exported.
6756 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6757 (fatal_error_code, fatal_error_signal_hook, standard_args):
6759 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6760 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6761 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6762 * lisp.h (fatal_error_signal_hook): Remove decl.
6763 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6765 * editfns.c: Move a (normally-unused) function to its only use.
6766 * editfns.c, lisp.h (get_operating_system_release): Remove.
6767 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6768 worth the hassle of breaking this out.
6770 * xterm.c: Make symbols static if they're not exported.
6771 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6772 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6773 (x_destroy_window, x_delete_display):
6775 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6776 (x_mouse_leave): Remove; unused.
6777 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6778 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6779 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6781 (x_mouse_leave): Declare only if WINDOWSNT.
6782 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6783 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6786 * ftxfont.c: Make symbols static if they're not exported.
6787 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6789 * font.h (ftxfont_driver): Likewise.
6791 * xfns.c: Make symbols static if they're not exported.
6792 (x_last_font_name, x_display_info_for_name):
6793 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6794 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6795 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6796 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6797 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6798 (last_show_tip_args): Now static.
6799 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6800 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6801 (x_screen_planes): Remove; unused.
6802 * dispextern.h (x_screen_planes): Remove decl.
6804 * dispnew.c: Make symbols static if they're not exported.
6805 * dispextern.h (redraw_garbaged_frames, scrolling):
6806 (increment_row_positions): Remove.
6807 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6808 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6810 (redraw_garbaged_frames): Remove; unused.
6812 * xfaces.c: Make symbols static if they're not exported.
6813 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6815 * xterm.h (defined_color): Remove decls.
6816 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6817 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6818 (menu_face_changed_default, defined_color, free_realized_face):
6819 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6820 (ascii_face_of_lisp_face): Remove; unused.
6822 * xdisp.c: Make symbols static if they're not exported.
6823 * dispextern.h (scratch_glyph_row, window_box_edges):
6824 (glyph_to_pixel_coords, set_cursor_from_row):
6825 (get_next_display_element, set_iterator_to_next):
6826 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6827 (show_mouse_face): Remove decls
6828 * frame.h (message_buf_print): Likewise.
6829 * lisp.h (pop_message, set_message, check_point_in_composition):
6831 * xterm.h (set_vertical_scroll_bar): Likewise.
6832 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6833 (message_buf_print, scratch_glyph_row, displayed_buffer):
6834 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6835 (get_next_display_element, show_mouse_face, window_box_edges):
6836 (frame_to_window_pixel_xy, check_point_in_composition):
6837 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6838 (glyph_to_pixel_coords): Remove; unused.
6840 * dired.c (file_name_completion): Now static.
6842 * dbusbind.c (xd_in_read_queued_messages): Now static.
6844 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6845 * data.c (circular_list_error): Remove.
6847 * commands.h (last_point_position, last_point_position_buffer):
6848 (last_point_position_window): Remove decls.
6849 * keyboard.c: Make these variables static.
6851 * coding.h (coding, code_convert_region, encode_coding_gap):
6853 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6854 (iso_code_class, detect_coding, code_convert_region): Now static.
6855 (encode_coding_gap): Remove; unused.
6857 * chartab.c (chartab_chars, chartab_bits): Now static.
6859 * charset.h (charset_iso_8859_1): Remove decl.
6860 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6863 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6864 * ccl.c (Vccl_program_table): Now static.
6865 (check_ccl_update): Remove; unused.
6867 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6868 * category.h: ... from here.
6869 * category.c (check_category_table, set_category_set): Now static.
6871 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6872 * lisp.h: Remove these decls.
6874 * buffer.c (buffer_count): Remove unused var.
6876 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6877 so that it's not optimized away.
6878 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6879 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6880 exported only to the debugger.
6882 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
6883 * atimer.h (run_all_atimers): Remove; not exported.
6885 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6886 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6887 was inaccessible from Lisp.
6888 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6889 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6891 alloc.c: Import and export fewer symbols, and remove unused items.
6892 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6894 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6895 it's not optimized away by whole-program optimization.
6896 (message_enable_multibyte, free_misc): Remove.
6897 (catchlist, handlerlist, mark_backtrace):
6898 Declare only if BYTE_MARK_STACK.
6899 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6900 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6901 (message_enable_multibyte): Remove decl.
6902 (free_misc, interval_free_list, float_block, float_block_index):
6903 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6904 (cons_free_list, last_marked_index):
6906 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6907 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6908 (mark_backtrace): Define only if BYTE_MARK_STACK.
6909 * xdisp.c (message_enable_multibyte): Now static.
6911 Declare Lisp_Object Q* variables to be 'static' if not exported.
6912 This makes it easier for human readers (and static analyzers)
6913 to see whether these variables are used from other modules.
6914 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6915 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6916 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6917 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6918 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6919 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6920 * xmenu.c, xselect.c:
6921 Declare Q* vars static if they are not used in other modules.
6922 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6923 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6924 Remove decls of unexported vars.
6925 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6927 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6929 Make Emacs functions such as Fatom 'static' by default.
6930 This makes it easier for human readers (and static analyzers)
6931 to see whether these functions can be called from other modules.
6932 DEFUN now defines a static function. To make the function external
6933 so that it can be used in other C modules, use the new macro DEFUE.
6934 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6935 (Finit_image_library):
6936 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6937 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6938 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6939 Remove decls, since these functions are now static.
6940 (Funintern, Fget_internal_run_time): New decls, since these functions
6941 were already external.
6943 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6944 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6945 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6946 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6947 * keyboard.c, keymap.c, lread.c:
6948 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6949 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6950 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6951 Mark functions with DEFUE instead of DEFUN,
6952 if they are used in other modules.
6953 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6954 decls for now-static functions.
6955 * buffer.h (Fdelete_overlay): Remove decl.
6956 * callproc.c (Fgetenv_internal): Mark as internal.
6957 * composite.c (Fremove_list_of_text_properties): Remove decl.
6958 (Fcomposition_get_gstring): New forward static decl.
6959 * composite.h (Fcomposite_get_gstring): Remove decl.
6960 * dired.c (Ffile_attributes): New forward static decl.
6961 * doc.c (Fdocumntation_property): New forward static decl.
6962 * eval.c (Ffetch_bytecode): New forward static decl.
6963 (Funintern): Remove extern decl; now in .h file where it belongs.
6964 * fileio.c (Fmake_symbolic_link): New forward static decl.
6965 * image.c (Finit_image_library): New forward static decl.
6966 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6967 * intervals.h (Fprevious_property_change):
6968 (Fremove_list_of_text_properties): Remove decls.
6969 * keyboard.c (Fthis_command_keys): Remove decl.
6970 (Fcommand_execute): New forward static decl.
6971 * keymap.c (Flookup_key): New forward static decl.
6972 (Fcopy_keymap): Now static.
6973 * keymap.h (Flookup_key): Remove decl.
6974 * process.c (Fget_process): New forward static decl.
6975 (Fprocess_datagram_address): Mark as internal.
6976 * syntax.c (Fsyntax_table_p): New forward static decl.
6977 (skip_chars): Remove duplicate decl.
6978 * textprop.c (Fprevious_property_change): New forward static decl.
6979 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6981 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6982 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6984 * editfns.c (Fformat): Remove unreachable code.
6986 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6988 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6991 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6993 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6994 when at ZV. (Bug#8487)
6996 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6998 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7000 * keyboard.c (parse_tool_bar_item): Likewise.
7001 * sound.c (sound_cleanup, alsa_close): Likewise.
7002 * termcap.c (tgetent): Likewise.
7003 * xfns.c (x_default_font_parameter): Likewise.
7004 * xsettings.c (read_and_apply_settings): Likewise.
7006 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7007 (overrun_check_free): Protoize.
7009 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7011 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7012 since callers should never pass a negative size.
7013 Change the signature to match that of plain 'read' and 'write'; see
7014 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7015 * lisp.h: Update prototypes of emacs_write and emacs_read.
7017 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7019 * xdisp.c (redisplay_window): Don't try to determine the character
7020 position of the scroll margin if the window start point w->startp
7021 is outside the buffer's accessible region. (Bug#8468)
7023 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7025 Fix write-region and its subroutines for buffers > 2GB.
7026 * fileio.c (a_write, e_write): Modify declaration of arguments and
7027 local variables to support buffers larger than 2GB.
7028 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7030 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7031 argument, local variables, and return value.
7033 * lisp.h: Update prototypes of emacs_write and emacs_read.
7035 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7037 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7039 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7041 Fix more problems found by GCC 4.6.0's static checks.
7043 * xdisp.c (vmessage): Use a better test for character truncation.
7045 * charset.c (load_charset_map): <, not <=, for optimization,
7046 and to avoid potential problems with integer overflow.
7047 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7048 * casetab.c (set_identity, shuffle): Likewise.
7049 * editfns.c (Fformat): Likewise.
7050 * syntax.c (skip_chars): Likewise.
7052 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7053 This also lets GCC 4.6.0 generate slightly better loop code.
7055 * callint.c (Fcall_interactively): <, not <=, for optimization.
7056 (Fcall_interactively): Count the number of arguments produced,
7057 not the number of arguments given. This is simpler and lets GCC
7058 4.6.0 generate slightly better code.
7060 * ftfont.c: Distingish more carefully between FcChar8 and char.
7061 The previous code passed unsigned char * to a functions like
7062 strlen and xstrcasecmp that expect char *, which does not
7063 conform to the C standard.
7064 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7065 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7066 char * when the C standard requires it.
7068 * keyboard.c (read_char): Remove unused var.
7070 * eval.c: Port to Windows vsnprintf (Bug#8435).
7072 (SIZE_MAX): Define if the headers do not.
7073 (verror): Do not give up if vsnprintf returns a negative count.
7074 Instead, grow the buffer. This ports to Windows vsnprintf, which
7075 does not conform to C99. Problem reported by Eli Zaretskii.
7076 Also, simplify the allocation scheme, by avoiding the need for
7077 calling realloc, and removing the ALLOCATED variable.
7079 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7081 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7082 But keep the doprint source code for now, as we might revamp it
7083 and use it again (Bug#8435).
7084 * lisp.h (doprnt): Remove.
7085 * Makefile.in (base_obj): Remove doprnt.o.
7086 * deps.mk (doprnt.o): Remove.
7088 error: Print 32- and 64-bit integers portably (Bug#8435).
7089 Without this change, on typical 64-bit hosts error ("...%d...", N)
7090 was used to print both 32- and 64-bit integers N, which relied on
7092 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7094 * lisp.h (error, verror): Mark as printf-like functions.
7095 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7096 Report overflow in size calculations when allocating printf buffer.
7097 Do not truncate output string at its first null byte.
7098 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7099 Truncate the output at a character boundary, since vsnprintf does not
7101 * charset.c (check_iso_charset_parameter): Convert internal
7102 character to string before calling 'error', since %c now has the
7104 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7105 overflow when computing char to be passed to 'error'. Do not
7106 pass Lisp_Object to 'error'; pass the integer instead.
7107 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7108 formatted with plain %d.
7110 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7112 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7114 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7116 * xterm.c (x_catch_errors): Remove duplicate declaration.
7118 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7120 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7122 2011-04-10 Jim Meyering <meyering@redhat.com>
7124 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7125 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7126 return ssize_t not "int", and use size_t as the buffer length.
7127 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7128 * gnutls.h: Update declarations.
7129 * process.c (read_process_output): Use ssize_t, to match.
7130 (send_process): Likewise.
7132 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7134 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7136 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7138 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7139 Use unsigned char, to match FcChar8 type definition.
7141 * xterm.c (handle_one_xevent):
7142 * xmenu.c (create_and_show_popup_menu):
7143 * xselect.c (x_decline_selection_request)
7144 (x_reply_selection_request): Avoid type-punned deref of X events.
7146 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7148 Fix some uses of `int' instead of EMACS_INT.
7149 * search.c (string_match_1, fast_string_match)
7150 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7151 (scan_buffer, find_next_newline_no_quit)
7152 (find_before_next_newline, search_command, Freplace_match)
7153 (Fmatch_data): Make some `int' variables be EMACS_INT.
7155 * xdisp.c (display_count_lines): 3rd argument and return value now
7156 EMACS_INT. All callers changed.
7157 (pint2hrstr): Last argument is now EMACS_INT.
7159 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7160 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7161 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7162 (decode_coding_utf_16, decode_coding_emacs_mule)
7163 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7164 (decode_coding_ccl, decode_coding_charset)
7165 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7166 (decode_coding_iso_2022, decode_coding_emacs_mule)
7167 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7168 <char_offset, last_offset>: Declare EMACS_INT.
7169 (encode_coding_utf_8, encode_coding_utf_16)
7170 (encode_coding_emacs_mule, encode_invocation_designation)
7171 (encode_designation_at_bol, encode_coding_iso_2022)
7172 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7173 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7175 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7176 (encode_invocation_designation): Last argument P_NCHARS is now
7178 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7179 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7181 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7184 * ccl.c (Fccl_execute_on_string): Declare some variables
7187 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7189 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7191 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7193 * process.c (Fformat_network_address): Doc fix.
7195 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7197 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7199 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7201 * keyboard.c (read_char): Call Lisp function help-form-show,
7202 instead of using internal_with_output_to_temp_buffer.
7203 (Qhelp_form_show): New var.
7204 (syms_of_keyboard): Use DEFSYM macro.
7206 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7208 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7210 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7212 * process.c (Flist_processes): Remove to Lisp.
7213 (list_processes_1): Delete.
7215 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7217 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7219 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7221 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7223 Fix more problems found by GCC 4.6.0's static checks.
7225 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7227 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7229 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7231 * xdisp.c (vmessage): Mark as a printf-like function.
7233 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7235 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7237 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7238 printf-like functions.
7239 (tiff_load): Add casts to remove these marks before passing them
7240 to system-supplied API.
7242 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7244 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7245 This avoids several warnings with gcc -Wstrict-overflow.
7246 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7247 directly, rather than having caller test rule sign. This avoids
7248 some unnecessary tests.
7249 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7250 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7251 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7253 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7254 (xfont_open): Avoid unnecessary tests.
7256 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7258 * composite.h, composite.c (composition_gstring_put_cache):
7259 Use EMACS_INT, not int, for length.
7261 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7262 breaking out part of COMPOSITION_DECODE_RULE.
7263 (COMPOSITION_DECODE_RULE): Use it.
7264 * composite.c (get_composition_id): Remove unused local vars,
7265 by using the new macro.
7267 * textprop.c (set_text_properties_1): Change while to do-while,
7268 since the condition is always true at first.
7270 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7271 (interval_deletion_adjustment): Return unsigned value.
7274 * process.c (list_processes_1, create_pty, read_process_output):
7275 (exec_sentinel): Remove vars that were set but not used.
7276 (create_pty): Remove unnecessary "volatile"s.
7277 (Fnetwork_interface_info): Avoid possibility of int overflow.
7278 (read_process_output): Do adaptive read buffering even if carryover.
7279 (read_process_output): Simplify nbytes computation if buffered.
7281 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7283 * syntax.c (scan_words): Remove var that was set but not used.
7284 (update_syntax_table): Use unsigned instead of int.
7286 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7287 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7288 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7290 * print.c (print_error_message): Avoid int overflow.
7292 * font.c (font_list_entities): Redo for clarity,
7293 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7295 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7296 (font_score): Avoid potential overflow in diff calculation.
7298 * fns.c (substring_both): Remove var that is set but not used.
7299 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7301 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7303 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7304 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7305 can always succeed if overflow has undefined behavior.
7307 * search.c (boyer_moore, wordify): Remove vars set but not used.
7308 (wordify): Omit three unnecessary tests.
7310 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7311 All callers changed. This avoids the need for an unused var.
7313 * casefiddle.c (casify_region): Remove var that is set but not used.
7315 * dired.c (file_name_completion): Remove var that is set but not used.
7317 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7319 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7320 (Finsert_file_contents): Remove unnecessary code checking fd.
7322 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7323 Check for integer overflow on size calculations.
7325 * buffer.c (Fprevious_overlay_change): Remove var that is set
7328 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7329 Remove vars that are set but not used.
7330 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7331 (timer_check_2): Mark vars as initialized.
7333 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7335 * image.c (lookup_image): Remove var that is set but not used.
7336 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7338 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7339 that are set but not used.
7341 * xfns.c (make_invisible_cursor): Don't return garbage
7342 if XCreateBitmapFromData fails (Bug#8410).
7344 * xselect.c (x_get_local_selection, x_handle_property_notify):
7345 Remove vars that are set but not used.
7347 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7348 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7350 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7351 Remove var that is set but not used.
7352 (scroll_bar_windows_size): Now size_t, not int.
7353 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7356 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7357 (map_tty_color) [!defined MSDOS]: Likewise.
7359 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7361 * coding.c: Remove vars that are set but not used.
7362 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7363 All callers changed.
7364 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7365 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7366 (decode_coding_charset): Remove vars that are set but not used.
7368 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7369 that is set but not used.
7371 * print.c (print_object): Remove var that is set but not used.
7373 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7374 The gnulib version avoids calling malloc in the usual case,
7375 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7376 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7377 * filelock.c (current_lock_owner): Likewise.
7378 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7379 * sysdep.c: Include allocator.h, careadlinkat.h.
7380 (emacs_no_realloc_allocator): New static constant.
7381 (emacs_readlink): New function.
7382 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7383 ../lib/careadlinkat.h.
7385 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7387 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7388 first non-nil return value).
7390 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7392 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7393 if not defined (Bug#8403).
7395 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7397 * xdisp.c (display_count_lines): Remove parameter `start',
7398 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7399 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7400 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7401 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7402 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7403 and thereabouts. All callers changed.
7404 (get_per_char_metric): Remove parameter `f', unused since
7405 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7407 2011-04-02 Jim Meyering <meyering@redhat.com>
7409 do not dereference NULL upon failed strdup
7410 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7411 (ns_get_family): Likewise.
7413 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7415 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7417 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7419 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7422 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7424 Add lexical binding.
7426 * window.c (Ftemp_output_buffer_show): New fun.
7427 (Fsave_window_excursion):
7428 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7430 * lread.c (lisp_file_lexically_bound_p): New function.
7431 (Fload): Bind Qlexical_binding.
7432 (readevalloop): Remove `evalfun' arg.
7433 Bind Qinternal_interpreter_environment.
7434 (Feval_buffer): Bind Qlexical_binding.
7435 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7437 (syms_of_lread): Declare `lexical-binding'.
7439 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7441 * keyboard.c (eval_dyn): New fun.
7442 (menu_item_eval_property): Use it.
7444 * image.c (parse_image_spec): Use Ffunctionp.
7446 * fns.c (concat, mapcar1): Accept byte-code-functions.
7448 * eval.c (Fsetq): Handle lexical vars.
7449 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7450 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7451 (FletX, Flet): Obey lexical binding.
7452 (Fcommandp): Handle closures.
7453 (Feval): New `lexical' arg.
7454 (eval_sub): New function extracted from Feval. Use it almost
7455 everywhere where Feval was used. Look up vars in lexical env.
7457 (Ffunctionp): Move from subr.el.
7458 (Ffuncall): Handle closures.
7459 (apply_lambda): Remove `eval_flags'.
7460 (funcall_lambda): Handle closures and new byte-code-functions.
7461 (Fspecial_variable_p): New function.
7462 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7463 but without exporting it to Lisp.
7465 * doc.c (Fdocumentation, store_function_docstring):
7466 * data.c (Finteractive_form): Handle closures.
7468 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7471 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7473 (exec_byte_code): New function extracted from Fbyte_code to handle new
7474 calling convention for byte-code-functions. Add new byte-codes.
7476 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7478 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7480 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7482 * xdisp.c (redisplay_internal): Fix prototype.
7484 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7486 * xdisp.c (SCROLL_LIMIT): New macro.
7487 (try_scrolling): Use it when setting scroll_limit.
7488 Limit scrolling to 100 screen lines.
7489 (redisplay_window): Even when falling back on "recentering",
7490 position point in the window according to scroll-conservatively,
7491 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7493 (try_scrolling): When point is above the window, allow searching
7494 as far as scroll_max, or one screenful, to compute vertical
7495 distance from PT to the scroll margin position. This prevents
7496 try_scrolling from unnecessarily failing when
7497 scroll-conservatively is set to a value slightly larger than the
7498 window height. Clean up the case of PT below the margin at bottom
7499 of window: scroll_max can no longer be INT_MAX. When aggressive
7500 scrolling is in use, don't let point enter the opposite scroll
7501 margin as result of the scroll.
7502 (syms_of_xdisp) <scroll-conservatively>: Document the
7503 threshold of 100 lines for never-recentering scrolling.
7505 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7507 * dispextern.h (move_it_by_lines):
7508 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7509 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7510 (message_log_check_duplicate): Remove parameters `prev_bol' and
7511 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7512 (redisplay_internal): Remove parameter `preserve_echo_area',
7513 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7515 * indent.c (Fvertical_motion):
7516 * window.c (window_scroll_pixel_based, Frecenter):
7517 Don't pass `need_y_p' to `move_it_by_lines'.
7519 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7521 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7522 steal a few bits to be more compact.
7523 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7524 Remove unneeded casts.
7526 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7528 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7530 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7531 binding" message (bug#7967).
7533 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7535 Fix more problems found by GCC 4.6.0's static checks.
7537 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7538 Remove unused local var.
7540 * editfns.c (Fmessage_box): Remove unused local var.
7542 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7543 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7544 Omit unused local vars.
7545 * window.c (shrink_windows): Omit unused local var.
7546 * menu.c (digest_single_submenu): Omit unused local var.
7547 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7548 Omit unused local var.
7550 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7551 Don't assume string length fits in int.
7552 (keyremap_step, read_key_sequence): Use size_t for sizes.
7553 (read_key_sequence): Don't check last_real_key_start redundantly.
7555 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7556 instead of alloca (Bug#8344).
7558 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7559 (Fbacktrace_frame): Don't assume nframes fits in int.
7561 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7563 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7566 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7568 * cm.c (calccost): Turn while-do into do-while, for clarity.
7570 * keyboard.c (syms_of_keyboard): Use the same style as later
7571 in this function when indexing through an array. This also
7572 works around GCC bug 48267.
7574 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7576 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7578 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7579 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7581 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7582 This avoids undefined behavior on integer overflow, and is a bit
7583 more convenient anyway since it is compared to a size_t variable.
7585 Variadic C functions now count arguments with size_t, not int.
7586 This avoids an unnecessary limitation on 64-bit machines, which
7587 caused (substring ...) to crash on large vectors (Bug#8344).
7588 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7589 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7590 All variadic functions and their callers changed accordingly.
7591 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7592 * data.c (arith_driver, float_arith_driver): Likewise.
7593 * editfns.c (general_insert_function): Likewise.
7594 * eval.c (struct backtrace.nargs, interactive_p)
7595 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7596 (funcall_lambda, mark_backtrace): Likewise.
7597 * fns.c (concat): Likewise.
7598 * frame.c (x_set_frame_parameters): Likewise.
7599 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7600 0 if not found, not -1. All callers changed.
7602 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7603 (stack_copy_size): Now size_t, not int.
7604 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7606 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7608 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7609 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7610 All callers changed.
7612 * lisp.h (multibyte_char_to_unibyte):
7613 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7614 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7615 * character.h (CHAR_TO_BYTE8):
7616 * cmds.c (internal_self_insert):
7617 * editfns.c (general_insert_function):
7618 * keymap.c (push_key_description):
7619 * search.c (Freplace_match):
7620 * xdisp.c (message_dolog, set_message_1): All callers changed.
7622 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7624 * keyboard.c (safe_run_hook_funcall): New function.
7625 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7626 don't set the hook to nil, but remove the offending function instead.
7627 (Qcommand_hook_internal): Remove, unused.
7628 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7629 Vcommand_hook_internal.
7631 * eval.c (enum run_hooks_condition): Remove.
7632 (funcall_nil, funcall_not): New functions.
7633 (run_hook_with_args): Call each function through a `funcall' argument.
7634 Remove `cond' argument, now redundant.
7635 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7636 (Frun_hook_with_args_until_failure): Adjust accordingly.
7637 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7639 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7641 * dispextern.h (string_buffer_position): Remove declaration.
7643 * print.c (strout): Remove parameter `multibyte', unused since
7644 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7646 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7647 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7648 All callers changed.
7650 * w32.c (_wsa_errlist): Use braces for struct initializers.
7652 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7653 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7654 All callers changed.
7655 (string_buffer_position): Likewise. Also, make static (it's never
7656 used outside xdisp.c).
7657 (cursor_row_p): Remove parameter `w', unused since
7658 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7659 (decode_mode_spec): Remove parameter `precision', introduced during
7660 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7661 All callers changed.
7663 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7665 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7667 2011-03-27 Anders Lindgren <andlind@gmail.com>
7669 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7670 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7671 (ns_update_auto_hide_menu_bar): New functions.
7672 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7673 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7674 ns_constrain_all_frames.
7675 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7676 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7678 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7680 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7682 2011-03-27 Glenn Morris <rgm@gnu.org>
7684 * syssignal.h: Replace RETSIGTYPE with void.
7685 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7686 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7687 Replace SIGTYPE with void everywhere.
7688 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7689 * s/template.h (SIGTYPE): Remove commented out definition.
7691 2011-03-26 Eli Zaretskii <eliz@gnu.org>
7693 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7694 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7696 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
7698 * w32.c (read_unc_volume): Use parameter `henum', instead of
7699 global variable `wget_enum_handle'.
7701 * keymap.c (describe_vector): Remove parameters `indices' and
7702 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7703 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7705 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7707 * keyboard.c (timer_check): Remove parameter `do_it_now',
7708 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7709 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7710 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7712 * keyboard.c (read_char):
7713 * w32menu.c (w32_menu_display_help):
7714 * xmenu.c (show_help_event, menu_help_callback):
7715 Adjust calls to `show_help_echo'.
7717 * gtkutil.c (xg_maybe_add_timer):
7718 * keyboard.c (readable_events):
7719 * process.c (wait_reading_process_output):
7720 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7722 * insdel.c (adjust_markers_gap_motion):
7723 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7724 (gap_left, gap_right): Don't call it.
7726 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
7728 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7729 incurred during fontification.
7731 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7733 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7734 (DEFVAR_PER_BUFFER): Don't pass it.
7736 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7737 (scrolling_window): Don't pass it.
7739 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7741 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7743 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7745 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7746 of variables specific to SELinux and computation of `encoded_absname'.
7748 * image.c (XPutPixel): Remove unused variable `height'.
7750 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7752 * unexw32.c (get_section_info): Remove unused variable `section'.
7754 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7755 (system_process_attributes): Remove unused variable `sess'.
7756 (sys_read): Remove unused variable `err'.
7758 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7759 (w32_wnd_proc): Remove unused variable `isdead'.
7760 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7761 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7762 (x_create_tip_frame): Remove unused variable `tem'.
7764 * w32inevt.c (w32_console_read_socket):
7765 Remove unused variable `no_events'.
7767 * w32term.c (x_draw_composite_glyph_string_foreground):
7768 Remove unused variable `width'.
7770 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
7772 * w32term.c (x_set_glyph_string_clipping):
7773 Don't pass uninitialized region to CombineRgn.
7775 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
7777 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7778 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7779 (Fx_close_connection): Remove unused variable `i'.
7781 * w32font.c (w32font_draw): Return number of glyphs.
7782 (w32font_open_internal): Remove unused variable `i'.
7783 (w32font_driver): Add missing initializer.
7785 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7786 (fill_in_menu): Remove unused variable `items_added'.
7788 * w32term.c (last_mouse_press_frame): Remove static global variable.
7789 (w32_clip_to_row): Remove unused variable `f'.
7790 (x_delete_terminal): Remove unused variable `i'.
7792 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7793 (NOTHING): Remove unused static global variable.
7794 (uniscribe_check_otf): Remove unused variable `table'.
7795 (uniscribe_font_driver): Add missing initializers.
7797 2011-03-23 Julien Danjou <julien@danjou.info>
7799 * term.c (Fsuspend_tty, Fresume_tty):
7800 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7801 * window.c (temp_output_buffer_show):
7802 * insdel.c (signal_before_change):
7803 * frame.c (Fhandle_switch_frame):
7804 * fileio.c (Fdo_auto_save):
7805 * emacs.c (Fkill_emacs):
7806 * editfns.c (save_excursion_restore):
7807 * cmds.c (internal_self_insert):
7808 * callint.c (Fcall_interactively):
7809 * buffer.c (Fkill_all_local_variables):
7810 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7812 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
7813 unconditionally since it does the check itself.
7815 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
7817 Fix more problems found by GCC 4.5.2's static checks.
7819 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7820 the first time through the loop, since we know p0 < p1 then.
7821 This also avoids a gcc -Wstrict-overflow warning.
7823 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7824 leading to a memory leak, possible in functions like
7825 load_charset_map_from_file that can allocate an unbounded number
7826 of objects (Bug#8318).
7828 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7829 that could (at least in theory) be that large.
7831 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7832 This is less likely to overflow, and avoids undefined behavior if
7833 overflow does occur. All callers changed. Use strtoul to scan
7834 for the unsigned long integer.
7835 (pint2hrstr): Simplify and tune code slightly.
7836 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
7838 * scroll.c (do_scrolling): Work around GCC bug 48228.
7839 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7841 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7842 This also avoids a warning with gcc -Wstrict-overflow.
7843 (validate_x_resource_name): Simplify count usage.
7844 This also avoids a warning with gcc -Wstrict-overflow.
7846 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7849 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
7851 * process.c (Fmake_network_process): Use socklen_t, not int,
7852 where POSIX says socklen_t is required in portable programs.
7853 This fixes a porting bug on hosts like 64-bit HP-UX, where
7854 socklen_t is wider than int (Bug#8277).
7855 (Fmake_network_process, server_accept_connection):
7856 (wait_reading_process_output, read_process_output):
7859 * process.c: Rename or move locals to avoid shadowing.
7860 (list_processes_1, Fmake_network_process):
7861 (read_process_output_error_handler, exec_sentinel_error_handler):
7862 Rename or move locals.
7863 (Fmake_network_process): Define label "retry_connect" only if needed.
7864 (Fnetwork_interface_info): Fix pointer signedness.
7865 (process_send_signal): Add cast to avoid pointer signedness problem.
7866 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7867 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7869 Make tparam.h and terminfo.c consistent.
7870 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7871 Include tparam.h instead, since it declares them.
7872 * cm.h (PC): Remove extern decl; tparam.h now does this.
7873 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7874 * terminfo.c: Include tparam.h, to check interfaces.
7875 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7876 (tparam): Adjust signature to match interface in tparam.h;
7877 this removes some undefined behavior. Check that outstring and len
7878 are zero, which they always are with Emacs.
7879 * tparam.h (PC, BC, UP): New extern decls.
7881 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
7882 (xftfont_open): Rename locals to avoid shadowing.
7884 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
7885 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7886 (OTF_TAG_SYM): Omit macro if not needed.
7887 (ftfont_list): Remove unused local.
7888 (get_adstyle_property, ftfont_pattern_entity):
7889 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7890 Rename locals to avoid shadowing.
7892 * xfont.c (xfont_list_family): Mark var as initialized.
7894 * xml.c (make_dom): Now static.
7896 * composite.c (composition_compute_stop_pos): Rename local to
7898 (composition_reseat_it): Remove unused locals.
7899 (find_automatic_composition, composition_adjust_point): Likewise.
7900 (composition_update_it): Mark var as initialized.
7901 (find_automatic_composition): Mark vars as initialized,
7902 with a FIXME (Bug#8290).
7904 character.h: Rename locals to avoid shadowing.
7905 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7906 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7907 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7908 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7911 * textprop.c (property_change_between_p): Remove; unused.
7913 * intervals.c (interval_start_pos): Now static.
7915 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7917 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7918 Rename locals to avoid shadowing.
7920 * sound.c (wav_play, au_play, Fplay_sound_internal):
7921 Fix pointer signedness.
7922 (alsa_choose_format): Remove unused local var.
7923 (wav_play): Initialize a variable to 0, to prevent undefined
7924 behavior (Bug#8278).
7926 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7928 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7930 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7931 clobbering (Bug#8298).
7932 * sysdep.c (sys_subshell): Likewise.
7933 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7935 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7936 This should get cleaned up, so that child_setup has the
7937 same signature on all platforms.
7939 * callproc.c (call_process_cleanup): Now static.
7940 (relocate_fd): Rename locals to avoid shadowing.
7942 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7944 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7945 not to be necessary, and produces flickering.
7947 2011-03-20 Glenn Morris <rgm@gnu.org>
7949 * config.in: Remove file.
7951 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7953 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7954 are now in src/globals.h.
7955 (syms_of_minibuf): Remove spurious & from previous change.
7957 2011-03-20 Leo <sdl.web@gmail.com>
7959 * minibuf.c (completing-read-function): New variable.
7960 (completing-read-default): Rename from completing-read.
7961 (completing-read): Call completing-read-function.
7963 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7965 * xfaces.c (Fx_load_color_file):
7966 Read color file from absolute filename (bug#8250).
7968 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7970 * makefile.w32-in: Update dependencies.
7972 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7974 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7976 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7978 Fix more problems found by GCC 4.5.2's static checks.
7980 * process.c (make_serial_process_unwind, send_process_trap):
7981 (sigchld_handler): Now static.
7983 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7984 That way, the code declares only the vars that it needs.
7985 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7986 * s/cygwin.h (PTY_ITERATION): Likewise.
7987 * s/darwin.h (PTY_ITERATION): Likewise.
7988 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7990 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7991 * process.c (allocate_pty): Don't declare stb unless it's needed.
7993 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7994 (CONSTANTLIM): Remove; unused.
7995 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7996 Define only if needed.
7998 * unexelf.c (unexec): Name an expression,
7999 to avoid gcc -Wbad-function-cast warning.
8000 Use a different way to cause a compilation error if anyone uses
8001 n rather than nn, a way that does not involve shadowing.
8002 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8004 * deps.mk (unexalpha.o): Remove; unused.
8006 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8007 * unexec.h: New file.
8008 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8009 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8011 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8012 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8013 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8014 Change as necessary to match prototype in unexec.h.
8016 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8018 (back_comment, skip_chars): Mark vars as initialized.
8020 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8021 Rename locals to avoid shadowing.
8023 * lread.c (read1): Rewrite so as not to use empty "else".
8024 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8026 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8028 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8029 warning when compiling print.c.
8031 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8032 instead of using an uninitialized var.
8033 (font_sort_entities): Mark var as initialized.
8035 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8037 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8038 pointers to constants.
8039 (font_parse_fcname): Remove unused vars.
8040 (font_delete_unmatched): Now static.
8041 (font_get_spec): Remove; unused.
8042 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8043 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8044 Rename or move locals to avoid shadowing.
8046 * fns.c (require_nesting_list, require_unwind): Now static.
8047 (Ffillarray): Rename locals to avoid shadowing.
8049 * floatfns.c (domain_error2): Define only if needed.
8050 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8052 * alloc.c (mark_backtrace): Move decl from here ...
8053 * lisp.h: ... to here, so that it can be checked.
8055 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8056 (Fdefvar): Rewrite so as not to use empty "else".
8057 (lisp_indirect_variable): Name an expression,
8058 to avoid gcc -Wbad-function-cast warning.
8059 (Fdefvar): Rename locals to avoid shadowing.
8061 * callint.c (quotify_arg, quotify_args): Now static.
8062 (Fcall_interactively): Rename locals to avoid shadowing.
8063 Use const pointer when appropriate.
8065 * lisp.h (get_system_name, get_operating_system_release):
8066 Move decls here, to check interfaces.
8067 * process.c (get_operating_system_release): Move decl to lisp.h.
8068 * xrdb.c (get_system_name): Likewise.
8069 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8070 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8071 some of which prompt warnings from gcc -Wbad-function-cast.
8072 (Fformat_time_string, Fencode_time, Finsert_char):
8073 (Ftranslate_region_internal, Fformat):
8074 Rename or remove local vars to avoid shadowing.
8075 (Ftranslate_region_internal): Mark var as initialized.
8077 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8080 * lisp.h (eassert): Check that the argument compiles, even if
8081 ENABLE_CHECKING is not defined.
8083 * data.c (Findirect_variable): Name an expression, to avoid
8084 gcc -Wbad-function-cast warning.
8085 (default_value, arithcompare, arith_driver, arith_error): Now static.
8086 (store_symval_forwarding): Rename local to avoid shadowing.
8087 (Fmake_variable_buffer_local, Fmake_local_variable):
8088 Mark variables as initialized.
8089 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8091 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8092 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8093 Rename locals to avoid shadowing.
8094 (mark_stack): Move local variables into the #ifdef region where
8096 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8097 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8099 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8100 (GC_STRING_CHARS): Remove; not used.
8101 (Fmemory_limit): Cast sbrk's returned value to char *.
8103 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8104 avoids undefined behavior in theory.
8106 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8108 Use functions, not macros, for up- and down-casing (Bug#8254).
8109 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8110 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8111 to use the following functions instead of these macros.
8112 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8113 EMACS_INT, since callers assume the returned value fits in int.
8114 (upcase1): Likewise, for UPCASE_TABLE.
8115 (uppercasep, lowercasep, upcase): New static inline functions.
8116 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8117 the race-condition problem in the old DOWNCASE.
8119 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8120 Rename locals to avoid shadowing.
8121 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8122 (regex_compile, re_search_2, re_match_2_internal):
8123 Remove unused local vars.
8124 (FREE_VAR): Rewrite so as not to use empty "else",
8125 which gcc can warn about.
8126 (regex_compile, re_match_2_internal): Mark locals as initialized.
8127 (RETALLOC_IF): Define only if needed.
8128 (WORDCHAR_P): Likewise. This one is never needed, but is used
8129 only in a comment talking about a compiler bug, so put inside
8130 the #if 0 of that comment.
8131 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8132 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8135 * search.c (boyer_moore): Rename locals to avoid shadowing.
8136 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8137 (PREV_CHAR_BOUNDARY): Likewise.
8139 * search.c (simple_search): Remove unused var.
8141 * dired.c (compile_pattern): Move decl from here ...
8142 * lisp.h: ... to here, so that it can be checked.
8143 (struct re_registers): New forward decl.
8145 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8147 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8149 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8150 Rename locals to avoid shadowing.
8151 (Fvertical_motion): Mark locals as initialized.
8153 * casefiddle.c (casify_object, casify_region): Now static.
8154 (casify_region): Mark local as initialized.
8156 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8158 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8159 New macros, so that the caller can use some names other than
8160 gcpro1, gcpro2, etc.
8161 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8163 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8164 argument, for consistency with GCPRO2_VAR, etc: it is now the
8165 prefix of the variable, not the variable itself. All uses
8167 * dired.c (directory_files_internal, file_name_completion):
8168 Rename locals to avoid shadowing.
8170 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8171 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8172 dired.c's scmp function, had undefined behavior.
8173 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8174 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8175 * buffer.h: ... to here, because these macros use current_buffer,
8176 and the new implementation with inline functions needs to have
8177 current_buffer in scope now, rather than later when the macros
8179 (downcase, upcase1): New static inline functions.
8180 (DOWNCASE, UPCASE1): Reimplement using these functions.
8181 This avoids undefined behavior in expressions like
8182 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8183 from race conditions in accessing the global variables
8184 case_temp1 and case_temp2.
8185 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8186 * lisp.h (case_temp1, case_temp2): Remove their decls.
8187 * character.h (ASCII_CHAR_P): Move from here ...
8188 * lisp.h: ... to here, so that the inline functions mentioned
8191 * dired.c (directory_files_internal_unwind): Now static.
8193 * fileio.c (file_name_as_directory, directory_file_name):
8194 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8196 (file_name_as_directory): Use const pointers when appropriate.
8197 (Fexpand_file_name): Likewise. In particular, newdir might
8198 point at constant storage, so make it a const pointer.
8199 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8200 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8202 (Fset_file_times, Finsert_file_contents, auto_save_error):
8203 Rename locals to avoid shadowing.
8205 * minibuf.c (choose_minibuf_frame_1): Now static.
8206 (Ftry_completion, Fall_completions): Rename or remove locals
8209 * marker.c (bytepos_to_charpos): Remove; unused.
8211 * lisp.h (verify_bytepos, count_markers): New decls,
8212 so that gcc does not warn that these functions aren't declared.
8214 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8215 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8216 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8217 (copy_text): Remove unused local var.
8219 * filelock.c (within_one_second): Now static.
8220 (lock_file_1): Rename local to avoid shadowing.
8222 * buffer.c (fix_overlays_before): Mark locals as initialized.
8223 (fix_start_end_in_overlays): Likewise. This function should be
8224 simplified by using pointers-to-pointers, but that's a different
8226 (switch_to_buffer_1): Now static.
8227 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8228 (report_overlay_modification): Rename locals to avoid shadowing.
8230 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8231 Fix pointer signedness issue.
8232 (sys_subshell): Mark local as volatile if checking for lint,
8233 to suppress a gcc -Wclobbered warning that does not seem to be right.
8234 (MAXPATHLEN): Define only if needed.
8236 * process.c (serial_open, serial_configure): Move decls from here ...
8237 * systty.h: ... to here, so that they can be checked.
8239 * fns.c (get_random, seed_random): Move extern decls from here ...
8240 * lisp.h: ... to here, so that they can be checked.
8242 * sysdep.c (reset_io): Now static.
8243 (wait_for_termination_signal): Remove; unused.
8245 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8246 (copy_keymap_item, append_key, push_text_char_description):
8248 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8249 (DENSE_TABLE_SIZE): Remove; unused.
8250 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8251 (describe_map_tree):
8252 Rename locals to avoid shadowing.
8254 * keyboard.c: Declare functions static if they are not used elsewhere.
8255 (echo_char, echo_dash, cmd_error, top_level_2):
8256 (poll_for_input, handle_async_input): Now static.
8257 (read_char, kbd_buffer_get_event, make_lispy_position):
8258 (make_lispy_event, make_lispy_movement, apply_modifiers):
8259 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8260 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8261 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8262 (read_key_sequence, read_char): Mark locals as initialized.
8263 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8265 * keyboard.h (make_ctrl_char): New decl.
8266 (mark_kboards): Move decl here ...
8267 * alloc.c (mark_kboards): ... from here.
8269 * lisp.h (force_auto_save_soon): New decl.
8271 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8272 (DEFINE_DUMMY_FUNCTION): New macro.
8273 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8275 (main): Add casts to avoid warnings
8276 if GCC considers string literals to be constants.
8278 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8280 * dbusbind.c: Pointer signedness fixes.
8281 (xd_signature, xd_append_arg, xd_initialize):
8282 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8283 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8284 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8285 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8287 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8288 if GCC considers string literals to be constants.
8289 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8291 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8293 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8294 (print_preprocess, print_object): New macro to fix last change.
8296 * print.c (print_preprocess): Don't forget font objects.
8298 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8300 * emacs.c (USAGE3): Doc fixes.
8302 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8304 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8307 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8309 * lisp.h (VWindow_system, Qfile_name_history):
8310 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8311 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8312 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8314 * w32select.c: Don't #include "keyboard.h".
8315 (run_protected): Add extern declaration for waiting_for_input.
8317 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8318 * w32console.c (detect_input_pending, read_input_pending)
8319 (encode_terminal_code):
8320 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8321 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8322 (w32_system_caret_y, Qfile_name_history):
8323 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8324 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8325 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8326 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8327 * w32proc.c (Qlocal, report_file_error):
8328 * w32term.c (Vwindow_system, updating_frame):
8329 * w32uniscribe.c (initialized, uniscribe_font_driver):
8330 Remove unneeded extern declarations.
8332 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8334 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8336 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8338 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8339 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8340 These macros can no longer be used for assignment.
8342 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8343 Assign struct members directly, instead of using BUF_BEGV etc.
8344 (record_buffer_markers, fetch_buffer_markers): New functions for
8345 recording and fetching special buffer markers.
8346 (set_buffer_internal_1, set_buffer_temp): Use them.
8348 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8350 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8352 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8353 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8355 * xdisp.c (hscroll_window_tree):
8356 (reconsider_clip_changes): Use PT instead of BUF_PT.
8358 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8360 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8361 $(EMACS_ROOT)/lib/intprops.h.
8363 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8365 Fix more problems found by GCC 4.5.2's static checks.
8367 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8368 to unsigned char * to avoid compiler diagnostic.
8369 (xg_free_frame_widgets): Make it clear that a local variable is
8370 needed only if USE_GTK_TOOLTIP.
8371 (gdk_window_get_screen): Make it clear that this macro is needed
8372 only if USE_GTK_TOOLTIP.
8373 (int_gtk_range_get_value): New function, which avoids a diagnostic
8374 from gcc -Wbad-function-cast.
8375 (xg_set_toolkit_scroll_bar_thumb): Use it.
8376 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8377 diagnostic from gcc -Wbad-function-cast.
8378 (get_utf8_string, xg_get_file_with_chooser):
8379 Rename locals to avoid shadowing.
8380 (create_dialog): Move locals to avoid shadowing.
8382 * xgselect.c (xg_select): Remove unused var.
8384 * image.c (four_corners_best): Mark locals as initialized.
8385 (gif_load): Initialize transparent_p to zero (Bug#8238).
8386 Mark another local as initialized.
8387 (my_png_error, my_error_exit): Mark with NO_RETURN.
8389 * image.c (clear_image_cache): Now static.
8390 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8391 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8392 (x_edge_detection): Remove unnecessary cast that
8393 gcc -Wbad-function-cast diagnoses.
8394 (gif_load): Fix pointer signedness.
8395 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8396 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8398 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8400 Improve quality of tests for time stamp overflow.
8401 For example, without this patch (encode-time 0 0 0 1 1
8402 1152921504606846976) returns the obviously-bogus value (-948597
8403 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8404 reports time overflow. See
8405 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8406 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8407 * editfns.c: Include limits.h and intprops.h.
8408 (TIME_T_MIN, TIME_T_MAX): New macros.
8409 (time_overflow): Move earlier, to before first use.
8410 (hi_time, lo_time): New functions, for an accurate test for
8412 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8413 (Fget_internal_run_time): Don't assume time_t fits in int.
8414 (make_time): Use list2 instead of Fcons twice.
8415 (Fdecode_time): More accurate test for out-of-range times.
8416 (check_tm_member): New function.
8417 (Fencode_time): Use it, to test for out-of-range times.
8418 (lisp_time_argument): Don't rely on undefined left-shift and
8419 right-shift behavior when checking for time stamp overflow.
8421 * editfns.c (time_overflow): New function, refactoring common code.
8422 (Fformat_time_string, Fdecode_time, Fencode_time):
8423 (Fcurrent_time_string): Use it.
8425 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8426 * dired.c (make_time): Move to ...
8427 * editfns.c (make_time): ... here.
8428 * systime.h: Note the move.
8430 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8432 * fringe.c (update_window_fringes): Remove unused variables.
8434 * unexmacosx.c (copy_data_segment): Also copy __got section.
8437 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8439 * termcap.c [MSDOS]: Include "msdos.h".
8440 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8441 Constify `char *' arguments and their references according to
8442 prototypes in tparam.h.
8444 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8446 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8447 Adapt all references accordingly.
8449 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8451 2011-03-11 Tom Tromey <tromey@redhat.com>
8453 * buffer.c (syms_of_buffer): Remove obsolete comment.
8455 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8457 * termhooks.h (encode_terminal_code): Declare prototype.
8459 * msdos.c (encode_terminal_code): Don't declare prototype.
8461 * term.c (encode_terminal_code): Now external again, used by
8462 w32console.c and msdos.c.
8464 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8465 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8467 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8469 Fix some minor problems found by GCC 4.5.2's static checks.
8471 * fringe.c (update_window_fringes): Mark locals as initialized
8473 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8475 * alloc.c (mark_fringe_data): Move decl from here ...
8476 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8477 to check its interface.
8478 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8480 * fontset.c (free_realized_fontset): Now static.
8481 (Fset_fontset_font): Rename local to avoid shadowing.
8482 (fontset_font): Mark local as initialized.
8483 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8485 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8487 * xselect.c (x_disown_buffer_selections): Remove; not used.
8488 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8489 (x_own_selection, Fx_disown_selection_internal): Rename locals
8491 (x_handle_dnd_message): Remove local to avoid shadowing.
8493 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8494 so that the caller can use some name other than gcpro1.
8495 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8496 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8497 (Fx_backspace_delete_keys_p):
8498 Use them to avoid shadowing, and rename vars to avoid shadowing.
8499 (x_decode_color, x_set_name, x_window): Now static.
8500 (Fx_create_frame): Add braces to silence GCC warning.
8501 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8502 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8503 Remove unused locals.
8504 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8505 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8506 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8509 * xterm.h (x_mouse_leave): New decl.
8511 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8512 Remove unused functions.
8513 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8514 (x_calc_absolute_position): Now static.
8515 (XTread_socket): Don't define label "out" unless it's used.
8516 Don't declare local "event" unless it's used.
8517 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8518 unless they are used.
8519 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8520 (x_fatal_error_signal): Remove; not used.
8521 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8522 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8523 (x_error_catcher, x_connection_closed, x_error_handler):
8524 (x_error_quitter, xembed_send_message, x_iconify_frame):
8525 (my_log_handler): Rename locals to avoid shadowing.
8526 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8527 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8529 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8530 Rename or move locals to avoid shadowing.
8531 (tty_defined_color, merge_face_heights): Now static.
8532 (free_realized_faces_for_fontset): Remove; not used.
8533 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8534 does not deduce is never used uninitialized.
8535 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8536 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8538 * terminal.c (store_terminal_param): Now static.
8540 * xmenu.c (menu_highlight_callback): Now static.
8541 (set_frame_menubar): Remove unused local.
8542 (xmenu_show): Rename parameter to avoid shadowing.
8543 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8544 since they might point to immutable storage.
8545 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8546 since it's unused otherwise.
8548 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8549 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8550 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8551 avoids a gcc -Wuninitialized diagnostic.
8552 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8553 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8554 does not deduce are never used uninitialized.
8556 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8558 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8559 * window.c (window_loop, size_window):
8560 (run_window_configuration_change_hook, enlarge_window): Likewise.
8562 * window.c (display_buffer): Now static.
8563 (size_window): Mark variables that gcc -Wuninitialized
8564 does not deduce are never used uninitialized.
8565 * window.h (check_all_windows): New decl, to forestall
8566 gcc -Wmissing-prototypes diagnostic.
8567 * dispextern.h (bidi_dump_cached_states): Likewise.
8569 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8571 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8573 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8574 and to avoid gcc -Wuninitialized warning.
8575 (load_charset_map): Mark variables that gcc -Wuninitialized
8576 does not deduce are never used uninitialized.
8577 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8579 * coding.c (coding_set_source, coding_set_destination):
8580 Use "else { /* comment */ }" rather than "else /* comment */;"
8581 for clarity, and to avoid gcc -Wempty-body warning.
8582 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8583 a block, when the outer 'i' will do.
8584 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8585 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8586 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8587 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8588 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8589 Rename locals to avoid shadowing.
8590 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8591 * coding.c (emacs_mule_char, encode_invocation_designation):
8592 Now static, since they're not used elsewhere.
8593 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8594 (decode_coding_object, encode_coding_object, detect_coding_system):
8595 (decode_coding_emacs_mule): Mark variables that gcc
8596 -Wuninitialized does not deduce are never used uninitialized.
8597 (detect_coding_iso_2022): Initialize a local variable that might
8598 be used uninitialized. Leave a FIXME because it's not clear that
8599 this initialization is needed. (Bug#8211)
8600 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8601 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8602 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8603 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8604 Remove unused macros.
8606 * category.c (hash_get_category_set): Remove unused local var.
8607 (copy_category_table): Now static, since it's not used elsewhere.
8608 * character.c (string_count_byte8): Likewise.
8610 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8611 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8613 * chartab.c (copy_sub_char_table): Now static, since it's not used
8615 (sub_char_table_ref_and_range, char_table_ref_and_range):
8616 Rename locals to avoid shadowing.
8617 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8619 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8620 (BIDI_BOB): Remove unused macro.
8622 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8623 deduce are never used uninitialized.
8624 * term.c (encode_terminal_code): Likewise.
8626 * term.c (encode_terminal_code): Now static. Remove unused local.
8628 * tparam.h: New file.
8629 * term.c, tparam.h: Include it.
8630 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8631 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8632 Move these decls to tparam.h, and make them agree with what
8633 is actually in tparam.c. The previous trick of using incompatible
8634 decls in different modules does not conform to the C standard.
8635 All callers of tparam changed to use tparam's actual API.
8636 * tparam.c (tparam1, tparam, tgoto):
8637 Use const pointers where appropriate.
8639 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8640 * cm.h (struct cm): Likewise.
8641 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8642 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8643 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8644 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8645 (turn_on_face, init_tty): Likewise.
8646 * termchar.h (struct tty_display_info): Likewise.
8648 * term.c (term_mouse_position): Rename local to avoid shadowing.
8650 * alloc.c (mark_ttys): Move decl from here ...
8651 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8653 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8655 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8657 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
8659 * search.c (compile_pattern_1): Remove argument regp, unused since
8660 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8661 (compile_pattern): Don't pass it.
8663 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8665 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8666 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8668 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8670 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8672 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8673 gdk_window_get_screen, gdk_window_get_geometry,
8674 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8675 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8676 (xg_get_pixbuf_from_pixmap): New function.
8677 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8678 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8679 Call xg_get_pixbuf_from_pixmap instead of
8680 gdk_pixbuf_get_from_drawable.
8681 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8682 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8683 (xg_check_special_colors): Use GtkStyleContext and its functions
8685 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8686 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8687 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
8688 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8689 Call gtk_widget_get_preferred_size.
8690 (xg_frame_resized): gdk_window_get_geometry only takes 5
8692 (xg_win_to_widget, xg_event_is_for_menubar):
8693 Call gdk_x11_window_lookup_for_display.
8694 (xg_set_widget_bg): New function.
8695 (delete_cb): New function.
8696 (xg_create_frame_widgets): Connect delete-event to delete_cb.
8697 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
8698 (xg_set_background_color): Call xg_set_widget_bg.
8699 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8700 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8701 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8702 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8704 (update_frame_tool_bar): Call gtk_widget_hide.
8705 (xg_initialize): Use GDK_KEY_g.
8707 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8709 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8711 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8712 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8713 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8715 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
8717 * w32xfns.c (select_palette): Check success of RealizePalette against
8718 GDI_ERROR, not zero.
8720 See ChangeLog.11 for earlier changes.
8726 Copyright (C) 2011 Free Software Foundation, Inc.
8728 This file is part of GNU Emacs.
8730 GNU Emacs is free software: you can redistribute it and/or modify
8731 it under the terms of the GNU General Public License as published by
8732 the Free Software Foundation, either version 3 of the License, or
8733 (at your option) any later version.
8735 GNU Emacs is distributed in the hope that it will be useful,
8736 but WITHOUT ANY WARRANTY; without even the implied warranty of
8737 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8738 GNU General Public License for more details.
8740 You should have received a copy of the GNU General Public License
8741 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.