1 2011-10-08 Eli Zaretskii <eliz@gnu.org>
3 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6 lines that are hscrolled on the left.
8 * dispnew.c (buffer_posn_from_coords): Account for a possible
9 presence of header-line. (Bug#4426)
11 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
13 * buffer.c (syms_of_buffer) <enable-multibyte-characters>: Don't
14 advertise functionality which we discourage or doesn't work.
16 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
18 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
19 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
20 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
21 this makes Emacs dump core during garbage collection on rare
22 occasions. sizeof is obviously inferior to offsetof here, so
24 (GC_POINTER_ALIGNMENT): New macro.
25 (mark_memory): Omit 3rd (offset) arg; caller changed.
26 Don't assume EMACS_INT alignment is the same as pointer alignment.
28 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
30 * keyboard.c (read_key_sequence_remapped): New var.
31 (read_key_sequence): Compute remapping in the right buffer.
32 (command_loop_1): Use read_key_sequence's remapping directly.
34 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
36 * dired.c (file_name_completion): Don't expand file name.
37 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
38 before checking file name handler.
40 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
41 they've been requested explicitly (bug#9591).
43 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
45 * keymap.c (Fsingle_key_description): Use make_specified_string
46 instead of build_string to build string from push_key_description.
49 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
51 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
52 This fixes a Y2038 bug on 64-bit hosts.
53 * buffer.c (reset_buffer):
54 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
55 (Fclear_buffer_auto_save_failure):
56 Use 0, not -1, to represent an unset failure time, since time_t
59 Remove dependency on glibc malloc internals.
60 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
61 Move back here from lisp.h, but with their new implementations.
62 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
63 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
64 * charset.c (charset_table_init): New static var.
65 (syms_of_charset): Use it instead of xmalloc. This removes a
66 dependency on glibc malloc internals. See Eli Zaretskii's comment in
67 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
68 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
70 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
71 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
73 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
75 * nsterm.m (windowDidResize): Call x_set_window_size only when
76 ns_in_resize is true. Otherwise set pixelwidth/height and
77 call change_frame_size (Bug#9628).
79 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
81 Port --enable-checking=all to Fedora 14 x86-64.
82 * charset.c (syms_of_charset): Also account for glibc malloc's
83 internal overhead when calculating the initial malloc maximum.
85 Port --enable-checking=all to Fedora 14 x86.
86 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
88 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
89 (overrun_check_realloc, overrun_check_free):
90 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
91 That way, xmalloc returns a properly-aligned pointer even if
92 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
93 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
94 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
95 into account when calculating the initial malloc maximum.
96 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
97 Move here from alloc.c, so that charset.c can use it too.
98 Properly align; the old code wasn't right for common 32-bit hosts
99 when configured with --enable-checking=all.
100 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
101 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
103 2011-09-29 Eli Zaretskii <eliz@gnu.org>
105 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
108 2011-09-28 Eli Zaretskii <eliz@gnu.org>
110 * xdisp.c (compute_display_string_end): If there's no display
111 string at CHARPOS, return -1.
113 * bidi.c (bidi_fetch_char): When compute_display_string_end
114 returns a negative value, treat the character as a normal
115 character not covered by a display string. (Bug#9624)
117 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
119 * lread.c (Fread_from_string): Fix typo in docstring.
121 2011-09-27 Eli Zaretskii <eliz@gnu.org>
123 * xdisp.c (handle_invisible_prop): If invisible text ends on a
124 newline, reseat the iterator instead of bidi-iterating there one
125 character at a time. (Bug#9610)
126 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
127 TO_CHARPOS if the bidi iterator is at base embedding level.
129 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
131 * lread.c (readevalloop): Use correct code for NBSP.
132 (read1): Likewise. (Bug#9608)
134 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
136 * dbusbind.c (Fdbus_register_signal): When service is not
137 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
139 2011-09-25 Glenn Morris <rgm@gnu.org>
141 * buffer.c (truncate-lines): Doc fix.
143 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
145 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
146 (Fset_window_next_buffers): Doc fix.
148 2011-09-24 Glenn Morris <rgm@gnu.org>
150 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
152 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
154 Fix minor problems found by static checking.
155 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
156 * indent.c (Fvertical_motion): Fix == vs = typo.
158 2011-09-24 Eli Zaretskii <eliz@gnu.org>
160 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
161 Default value is now t. Doc fix.
163 * indent.c (Fvertical_motion): Compute and apply the overshoot
164 logic when moving up, not only when moving down. Fix the
165 confusing name and values of the it_overshoot_expected variable;
166 logic changes accordingly. (Bug#9254) (Bug#9549)
168 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
169 CHARPOS is covered by a display string which includes newlines.
170 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
171 is covered by a display string with embedded newlines.
173 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
175 * dbusbind.c (Fdbus_register_signal): Add match rule to
176 Vdbus_registered_objects_table. (Bug#9581)
177 (Fdbus_register_method, Vdbus_registered_objects_table):
180 2011-09-24 Jim Meyering <meyering@redhat.com>
182 do not ignore write error for any output size
183 The previous change was incomplete.
184 While it makes emacs --batch detect the vast majority of stdout
185 write failures, errors were still ignored whenever the output size is
186 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
187 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
188 && echo FAIL: ignored write error
189 FAIL: ignored write error
190 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
191 && echo FAIL: ignored write error
192 FAIL: ignored write error
193 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
195 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
197 * emacs.c (Fkill_emacs): In noninteractive mode exit
198 non-successfully if a write error occurred on stdout. (Bug#9574)
200 2011-09-21 Eli Zaretskii <eliz@gnu.org>
202 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
205 * dispextern.h (struct it): Update the comment documenting what
208 2011-09-20 Eli Zaretskii <eliz@gnu.org>
210 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
211 a display string, extend search for cursor position to end of row.
212 (find_row_edges): If the row ends in a newline from a display
213 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
214 Handle the case of a display string with multiple newlines.
215 (Fcurrent_bidi_paragraph_direction): Fix search for previous
216 non-empty line. Fixes confusing cursor motion with arrow keys at
217 the beginning of a line that starts with whitespace.
219 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
221 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
224 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
226 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
229 2011-09-18 Eli Zaretskii <eliz@gnu.org>
231 * xdisp.c (display_line): Record maximum and minimum buffer
232 positions even if no glyphs were produced (e.g., by a zero-width
233 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
234 buffer positions that will be removed from the glyph row because
236 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
237 column is beyond frame width: don't subtract 1 "pixel" when
238 computing width of the stretch.
239 (reseat_at_next_visible_line_start): Undo the change made on
240 2011-09-17 that saved paragraph information and restored it after
241 the call to `reseat'. (Bug#9545)
243 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
245 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
246 and turn window cursor on if cleared (Bug#9415).
248 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
250 * search.c (boyer_moore): Take unibyte characters from pattern
251 literally. (Bug#9458)
253 2011-09-18 Eli Zaretskii <eliz@gnu.org>
255 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
257 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
259 Fix minor problem found by static checking.
260 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
261 initialized, to pacify gcc -Wuninitialized.
263 * fileio.c: Report proper errno when syscall falls.
264 (Finsert_file_contents): Save and restore errno,
265 so that report_file_error outputs the correct diagnostic.
266 (Fwrite_region) [CLASH_DETECTION]: Likewise.
268 2011-09-18 Eli Zaretskii <eliz@gnu.org>
270 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
272 2011-09-17 Eli Zaretskii <eliz@gnu.org>
274 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
275 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
277 2011-09-17 Eli Zaretskii <eliz@gnu.org>
279 * xdisp.c (reseat_at_next_visible_line_start): Keep information
280 about the current paragraph and restore it after the call to
283 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
284 (bidi_find_paragraph_start): Search back for paragraph beginning
285 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
286 (bidi_move_to_visually_next): Only trigger paragraph-related
287 computations when the last character is a newline or at EOB, not
288 just any NEUTRAL_B. (Bug#9470)
290 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
291 truncated lines if point is covered by a display string. (Bug#9524)
293 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
295 * xselect.c: Relax test for outgoing X longs (Bug#9498).
296 (cons_to_x_long): New function.
297 (lisp_data_to_selection_data): Use it. Correct the test for
298 short-versus-long data; it was negated. Break out of vector
299 loop, for efficiency, when a long datum is discovered.
301 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
303 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
305 2011-09-16 Eli Zaretskii <eliz@gnu.org>
307 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
308 GCC PR/17406) by declaring this function with external scope.
310 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
312 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
313 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
315 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
317 * editfns.c (Fformat): Correctly handle text properties on "%%".
319 2011-09-15 Eli Zaretskii <eliz@gnu.org>
321 * xterm.c (x_draw_composite_glyph_string_foreground):
322 * w32term.c (x_draw_composite_glyph_string_foreground):
323 * term.c (encode_terminal_code):
324 * composite.c (composition_update_it, get_composition_id):
325 * xdisp.c (get_next_display_element)
326 (fill_composite_glyph_string): Add comments about special meaning
327 of TAB characters in a composition.
329 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
331 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
332 This occurs when processing a multibyte format.
333 Problem reported by Wolfgang Jenker.
335 2011-09-15 Johan Bockgård <bojohan@gnu.org>
337 * xdisp.c (try_cursor_movement): Only check for exact match if
338 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
340 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
342 Remove unused external symbols.
343 * dispextern.h (calc_pixel_width_or_height): Remove decl.
344 * xdisp.c (calc_pixel_width_or_height): Now static.
345 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
346 * indent.c (check_display_width):
347 * w32term.c: Fix comment to match code.
348 * xterm.c, xterm.h (x_catching_errors): Remove.
350 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
352 * xselect.c: Use signed conversions more consistently (Bug#9498).
353 (selection_data_to_lisp_data): Assume incoming selection data are
354 signed integers, not unsigned. This is to be consistent with
355 outgoing selection data, which was modified to use signed integers
356 in as part of the fix to Bug#9196 in response to Jan D.'s comment
357 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
358 expects long, not unsigned long.
360 2011-09-14 Eli Zaretskii <eliz@gnu.org>
362 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
363 computation of loop end. Reported by Johan Bockgård
366 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
368 * frame.c (Fother_visible_frames_p): Function deleted.
370 2011-09-12 Eli Zaretskii <eliz@gnu.org>
372 * indent.c (compute_motion): Process display vector front to back
373 rather than the other way around. (Bug#2496)
375 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
377 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
379 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
381 * minibuf.c (Fread_from_minibuffer): Doc fix.
383 2011-09-11 Eli Zaretskii <eliz@gnu.org>
385 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
386 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
388 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
390 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
391 value for non-existent files.
393 2011-09-11 Eli Zaretskii <eliz@gnu.org>
395 * fileio.c (Finsert_file_contents): If the file cannot be opened,
396 set its "size" to -1. This will set the modtime_size field of
397 the corresponding buffer to -1, which is what
398 verify-visited-file-modtime expects for files that do not exist.
401 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
403 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
405 * lisp.h: ... from here. push_key_description is no longer
406 defined in keyboard.c, so its declaration should not be in
407 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
408 logically belongs with push_key_description.
410 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
412 * buffer.h: Include <sys/types.h> instead of <time.h>.
413 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
414 Problem reported by Herbert J. Skuhra.
416 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
418 * xml.c (parse_region): Make the parsing work for
419 non-comment-starting XML files again (bug#9144).
421 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
423 * image.c (gif_load): Fix calculation of bottom and right corner.
426 2011-09-10 Eli Zaretskii <eliz@gnu.org>
428 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
429 redisplay in small windows.
431 2011-09-09 Eli Zaretskii <eliz@gnu.org>
433 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
435 2011-09-08 Martin Rudalics <rudalics@gmx.at>
437 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
438 Operate on live windows only.
440 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
442 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
444 2011-09-07 Eli Zaretskii <eliz@gnu.org>
446 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
447 only under bidi iteration.
449 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
451 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
453 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
455 isnan: Fix porting problem to Solaris 10 with bundled gcc.
456 Without this fix, the command to link temacs failed due to an
457 undefined symbol __builtin_isnan. This is because
458 /usr/include/iso/math_c99.h #defines isnan(x) to
459 __builtin_isnan(x), but the bundled gcc, which identifies itself
460 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
462 * floatfns.c (isnan): #undef, and then #define to a clone of
464 (Fisnan): Always define, since it's always available now.
465 (syms_of_floatfns): Always define isnan at the Lisp level.
467 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
469 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
471 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
473 * fileio.c: Fix bugs with large file offsets (Bug#9428).
474 The previous code assumed that file offsets (off_t values) fit in
475 EMACS_INT variables, which is not true on typical 32-bit hosts.
476 The code messed up by falsely reporting buffer overflow in cases
477 such as (insert-file-contents "big" nil 1 2) into an empty buffer
478 when "big" contains more than 2**29 bytes, even though this
479 inserts just one byte and does not overflow the buffer.
480 (Finsert_file_contents): Store file offsets as off_t
481 values, not as EMACS_INT values. Check for overflow when
482 converting between EMACS_INT and off_t. When checking for
483 buffer overflow or for overlap, take the offsets into account.
484 Don't use EMACS_INT for small values where int suffices.
485 When checking for overlap, fix a typo: ZV was used where
486 ZV_BYTE was intended.
487 (Fwrite_region): Don't assume off_t fits into 'long'.
488 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
490 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
492 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
494 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
496 sprintf-related integer and memory overflow issues (Bug#9412).
498 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
499 (esprintf, exprintf, evxprintf): New functions.
500 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
501 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
502 (modify_event_symbol): Do not assume that the length of
503 name_alist_or_stem is safe to alloca and fits in int.
504 (Fexecute_extended_command): Likewise for function name and binding.
505 (Frecursion_depth): Wrap around reliably on integer overflow.
506 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
507 since some callers pass EMACS_INT values.
508 (Fsingle_key_description): Don't crash if symbol name contains more
509 than MAX_ALLOCA bytes.
510 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
511 (get_minibuffer): Arg is now EMACS_INT, not int.
512 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
513 (esprintf, exprintf, evxprintf): New decls.
514 * window.h (command_loop_level, minibuf_level): Reflect API changes.
516 * dbusbind.c (signature_cat): New function.
517 (xd_signature, Fdbus_register_signal):
518 Do not overrun buffer; instead, report string overflow.
520 * dispnew.c (add_window_display_history): Don't overrun buffer.
521 Truncate instead; this is OK since it's just a log.
523 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
524 even if the time zone offset is outlandishly large.
525 Don't mishandle offset == INT_MIN.
527 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
528 when creating daemon; the previous buffer-overflow check was incorrect.
530 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
531 which has the guts of the old verror function.
533 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
534 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
536 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
537 (font_unparse_xlfd): Don't blindly alloca long strings.
538 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
539 fits in int, when using sprintf. Use single snprintf to count
540 length of string rather than counting it via multiple sprintfs;
541 that's simpler and more reliable.
542 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
543 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
544 sprintf, in case result does not fit in int.
546 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
547 (fontset_from_font): Print it.
549 * frame.c (tty_frame_count): Now printmax_t, not int.
550 (make_terminal_frame, set_term_frame_name): Print it.
551 (x_report_frame_params): In X, window IDs are unsigned long,
552 not signed long, so print them as unsigned.
553 (validate_x_resource_name): Check for implausibly long names,
554 and don't assume name length fits in 'int'.
555 (x_get_resource_string): Don't blindly alloca invocation name;
556 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
559 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
560 (xg_check_special_colors, xg_set_geometry):
561 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
563 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
564 Use esprintf, not sprintf, in case result does not fit in int.
566 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
567 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
568 it as a large positive number.
569 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
570 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
572 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
573 in case result does not fit in int.
575 * print.c (float_to_string): Detect width overflow more reliably.
576 (print_object): Make sprintf buffer a bit bigger, to avoid potential
577 buffer overrun. Don't assume list length fits in 'int'. Treat
578 print length of 0 as 0, not as infinity; to be consistent with other
579 uses of print length in this function. Don't overflow print length
580 index. Don't assume hash table size fits in 'long', or that
581 vectorlike size fits in 'unsigned long'.
583 * process.c (make_process): Use printmax_t, not int, to format
584 process-name gensyms.
586 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
588 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
589 to avoid potential buffer overrun.
591 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
592 if X resource line is longer than 512 bytes.
594 * xfns.c (x_window): Make sprintf buffer a bit bigger
595 to avoid potential buffer overrun.
597 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
599 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
601 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
603 Integer overflow fixes for scrolling, etc.
604 Without these, Emacs silently mishandles large integers sometimes.
605 For example, "C-u 4294967297 M-x recenter" was treated as if
606 it were "C-u 1 M-x recenter" on a typical 64-bit host.
608 * xdisp.c (try_window_id): Check Emacs fixnum range before
611 * window.c (window_scroll_line_based, Frecenter):
612 Check that an Emacs fixnum is in range before assigning it to 'int'.
613 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
614 values converted from Emacs fixnums.
615 (Frecenter): Don't wrap around a line count if it is out of 'int'
616 range; instead, treat it as an extreme value.
617 (Fset_window_configuration, compare_window_configurations):
618 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
620 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
621 that can exceed INT_MAX. Check that EMACS_INT value is in range
622 before assigning it to the (possibly-narrower) index.
623 (match_limit): Don't assume that a fixnum can fit in 'int'.
625 * print.c (print_object): Use ptrdiff_t, not int, for index that can
628 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
629 (Fvertical_motion): Don't wrap around LINES values that don't fit
630 in 'int'. Instead, treat them as extreme values. This is good
631 enough for windows, which can't have more than INT_MAX lines anyway.
633 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
635 * Require libxml/parser.h to avoid compilation warning.
637 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
639 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
640 since this reportedly can destroy thread storage.
642 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
644 * syntax.c (find_defun_start): Update all cache variables if
645 exiting early (Bug#9401).
647 2011-08-30 Eli Zaretskii <eliz@gnu.org>
649 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
651 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
652 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
653 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
655 * term.c (tty_append_glyph): New function.
656 (produce_stretch_glyph): Static function and its prototype deleted.
658 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
661 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
663 * image.c (parse_image_spec): Check for nonnegative, not for positive,
664 when checking :margin (Bug#9390).
665 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
666 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
667 so that the name doesn't mislead. All uses changed.
669 2011-08-28 Johan Bockgård <bojohan@gnu.org>
671 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
674 2011-08-27 Eli Zaretskii <eliz@gnu.org>
676 * xdisp.c (move_it_to): Don't bail out early when reaching
677 position beyond to_charpos, if we are scanning backwards.
678 (move_it_vertically_backward): When DY == 0, make sure we get to
679 the first character in the line after the newline.
681 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
683 * ccl.c: Improve and simplify overflow checking (Bug#9196).
684 (ccl_driver): Do not generate an out-of-range pointer.
685 (Fccl_execute_on_string): Remove unnecessary check for
686 integer overflow, noted by Stefan Monnier in
687 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
688 Remove a FIXME that didn't need fixing.
689 Simplify the newly-introduced buffer reallocation code.
691 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
693 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
695 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
697 Integer and memory overflow issues (Bug#9196).
699 * doc.c (get_doc_string): Rework so that
700 get_doc_string_buffer_size is the actual buffer size, rather than
701 being 1 less than the actual buffer size; this makes xpalloc more
704 * image.c (x_allocate_bitmap_record, cache_image):
705 * xselect.c (Fx_register_dnd_atom):
706 Simplify previous changes by using xpalloc.
708 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
709 since either will do and ptrdiff_t is convenient with xpalloc.
711 * charset.c (charset_table_size)
712 (struct charset_sort_data.priority): Now ptrdiff_t.
713 (charset_compare): Don't overflow if priorities differ greatly.
714 (Fsort_charsets): Don't assume list length fits in int.
715 Check for size-calculation overflow when allocating sort data.
716 (syms_of_charset): Allocate an initial charset table that is
717 just under 64 KiB, to avoid problems with glibc malloc and mmap.
719 * cmds.c (internal_self_insert): Check for size-calculation overflow.
721 * composite.h (struct composition.glyph_len): Now int, not unsigned.
722 The actual value is always <= INT_MAX, and leaving it unsigned made
723 overflow checking harder.
725 * dispextern.h (struct glyph_matrix.rows_allocated)
726 (struct face_cache.size): Now ptrdiff_t, for convenience in use
727 with xpalloc. The values are still always <= INT_MAX.
729 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
731 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
732 (SAFE_NALLOCA): New macro.
734 * region-cache.c (struct boundary.pos, find_cache_boundary)
735 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
736 (set_cache_region, invalidate_region_cache)
737 (revalidate_region_cache, know_region_cache, region_cache_forward)
738 (region_cache_backward, pp_cache):
739 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
740 so that ptrdiff_t * can be passed to xpalloc.
741 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
742 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
743 (pp_cache): Don't assume cache_len fits in int.
744 * region-cache.h: Adjust extern decls to match.
746 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
747 EMACS_INT, since either will do, for xpalloc.
749 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
750 (xnmalloc, xnrealloc, xpalloc): New functions.
752 * bidi.c (bidi_shelve_header_size): New constant.
753 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
754 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
756 * bidi.c (bidi_cache_shrink):
757 * buffer.c (overlays_at, overlays_in, record_overlay_string)
759 Don't update size of array until after memory allocation succeeds,
760 because xmalloc/xrealloc may not return.
761 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
762 now that we have proper integer overflow checking.
763 (record_overlay_string, overlay_strings): Catch overflows when
764 calculating size of overlay_str_buf.
766 * callproc.c (Fcall_process): Check for size overflow when
767 calculating size of args2.
768 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
769 Normally we prefer signed values, but sticking with ptrdiff_t would
770 require adding more-complicated checks.
772 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
773 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
774 Redo buffer-overflow calculations to avoid integer overflow.
775 Add a FIXME comment where memory seems to be over-allocated.
777 * character.c (Fstring): Check for size-calculation overflow.
779 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
780 unnecessary integer overflow. Check for size overflow.
781 (encode_coding_object): Don't update size until xmalloc succeeds.
783 * composite.c (get_composition_id): Check for overflow in glyph
786 Integer and memory overflow fixes for display code.
787 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
788 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
789 (scrolling_window): Check for overflow in size calculations.
790 (line_draw_cost, realloc_glyph_pool, add_row_entry):
791 Don't assume glyph table len fits in int.
792 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
793 (row_table_size): Now ptrdiff_t, not int.
794 (scrolling_window): Avoid overflow in size calculations.
795 Don't update size until allocation succeeds.
796 * fns.c (concat): Check for overflow in size calculations.
797 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
798 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
799 (NEXT_ALMOST_PRIME_LIMIT): New constant.
801 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
802 (get_doc_string): Check for size calculation overflow.
803 Don't update size until allocation succeeds.
804 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
805 EMACS_INT, where ptrdiff_t will do.
806 (Fsubstitute_command_keys): Check for string overflow.
808 * editfns.c (set_time_zone_rule): Don't assume environment length
810 (message_length): Now ptrdiff_t, not int.
811 (Fmessage_box): Don't update size until allocation succeeds.
812 Don't assume message length fits in int.
813 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
815 * emacs.c (main): Do not reallocate argv, since there is a null at
816 the end that can be overwritten, and this way there's no need to
817 worry about size-calculation overflow.
818 (sort_args): Check for size-calculation overflow.
820 * eval.c (init_eval_once, grow_specpdl): Don't update size until
822 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
824 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
825 (x_set_scroll_bar_width, x_figure_window_size):
826 Check for integer overflow.
827 (x_set_alpha): Do not assume XINT fits in int.
829 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
830 This is for the members text_lines, text_cols, total_lines, total_cols,
831 where the system imposes an 'int' limit.
833 * fringe.c (Fdefine_fringe_bitmap):
834 Don't update size until alloc works.
836 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
837 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
839 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
840 Check for size-calculation overflow.
841 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
842 do, as we prefer signed integers.
843 (id_to_widget.max_size, id_to_widget.used)
844 (xg_store_widget_in_map, xg_remove_widget_from_map)
845 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
846 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
847 Use and return ptrdiff_t, not int.
848 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
849 * gtkutil.h: Change prototypes to match the above.
851 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
852 are duplicate now that they've been promoted to lisp.h.
853 (x_allocate_bitmap_record, x_alloc_image_color)
854 (make_image_cache, cache_image, xpm_load):
855 Don't update size until alloc is done.
856 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
858 Check for size calculation overflow.
859 (ct_colors_allocated_max): New constant.
860 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
863 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
864 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
865 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
866 Use ptrdiff_t, not int, to count maps.
867 (read_char_minibuf_menu_prompt): Check for overflow in size
868 calculations. Don't update size until allocation succeeds.
869 Redo calculations to avoid overflow.
870 * keyboard.h: Change prototypes to match the above.
872 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
874 (current_minor_maps): Check for size calculation overflow.
875 * keymap.h: Change prototypes to match the above.
877 * lread.c (read1, init_obarray): Don't update size until alloc done.
879 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
880 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
882 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
883 Now ptrdiff_t, not int.
884 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
885 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
887 * process.c (Fnetwork_interface_list): Check for overflow
890 * region-cache.c (move_cache_gap): Check for size calculation overflow.
892 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
893 overflow. Don't bother calling xmalloc when xrealloc will do.
895 * search.c (Freplace_match): Check for size calculation overflow.
896 (Fset_match_data): Don't assume list lengths fit in 'int'.
898 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
899 for command line length. Do not attempt to address one before the
900 beginning of an array, as that's not portable.
902 * term.c (max_frame_lines): Remove; unused.
903 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
905 (encode_terminal_code, calculate_costs): Check for size
906 calculation overflow.
907 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
908 table lengths and related sizes. Don't update size until alloc
909 done. Redo calculations to avoid overflow.
910 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
912 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
913 subtracting pointers.
914 (gobble_line): Check for overflow more carefully. Don't update size
917 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
918 Don't update size until alloc done.
919 Redo size calculations to avoid overflow.
920 Check for size calculation overflow.
921 (main) [DEBUG]: Fix typo in invoking tparam1.
923 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
924 Use ptrdiff_t, not int, for sizes.
925 (store_mode_line_noprop_char): Don't update size until alloc done.
927 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
928 Use ptrdiff_t, not int, for sizes.
929 (Finternal_make_lisp_face, cache_face):
930 Check for size calculation overflow.
931 (cache_face): Treat size calculation overflows as if they were
932 memory exhaustion (the usual treatment), rather than aborting.
934 * xfns.c (x_encode_text, x_set_name_internal)
935 (Fx_change_window_property): Use ptrdiff_t, not int, to count
936 sizes, since they can exceed INT_MAX in size. Check for size
937 calculation overflow.
939 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
940 (xg_select): Check for size calculation overflow.
941 Don't update size until alloc done.
943 * xrdb.c (get_environ_db): Don't assume path length fits in int,
944 as sprintf is limited to int lengths.
946 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
947 (X_LONG_MIN): New macros.
948 Use them to make the following changes clearer.
949 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
950 This change doesn't affect the value now, but it may help remind
951 future maintainers not to raise the value too much later.
952 (SELECTION_QUANTUM): Remove, replacing with ...
953 (selection_quantum): ... new function, which avoids overflow.
955 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
956 assumption that selection length fits in 'int'.
957 (x_reply_selection_request, x_handle_selection_request)
958 (x_get_window_property, receive_incremental_selection)
959 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
960 (lisp_data_to_selection_data, clean_local_selection_data):
961 Use ptrdiff_t, not int, to record length of selection.
962 (x_reply_selection_request, x_get_window_property)
963 (receive_incremental_selection, x_property_data_to_lisp):
964 Redo calculations to avoid overflow.
965 (x_reply_selection_request): When sending hint, ceiling it at
966 X_LONG_MAX rather than relying on wraparound overflow to send
968 (x_get_window_property, receive_incremental_selection)
969 (lisp_data_to_selection_data, x_property_data_to_lisp):
970 Check for size-calculation overflow.
971 (x_get_window_property, receive_incremental_selection)
972 (lisp_data_to_selection_data, Fx_register_dnd_atom):
973 Don't store size until memory allocation succeeds.
974 (x_get_window_property): Plug memory leak on memory exhaustion.
975 Don't double-block input; malloc is safe here. Don't assume 2**34
976 - 4 fits in unsigned long. Add an xassert to check
977 XGetWindowProperty overflow. Be more careful about overflow
978 calculations, and distinguish size from memory overflow better.
979 (receive_incremental_selection): When tracing, don't assume
980 unsigned int is less than INT_MAX.
981 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
982 harmful) conversions of unsigned short to int.
983 (lisp_data_to_selection_data): Don't assume that integers
984 in the range -65535 through -1 fit in an X unsigned short.
985 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
986 result parameters unless successful. Rely on cons_to_unsigned
987 to report problems with elements; the old code wasn't right anyway.
988 (x_check_property_data): Check for int overflow; we cannot use
989 a wider type due to X limits.
990 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
992 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
994 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
995 (x_term_init): Check for size calculation overflow.
996 (x_color_cells): Don't store size until memory allocation succeeds.
997 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
998 Don't assume alloca size is less than MAX_ALLOCA.
999 (x_term_init): Don't assume length fits in int (sprintf is limited
1002 Use ptrdiff_t for composition IDs.
1003 * character.c (lisp_string_width):
1004 * composite.c (composition_table_size, n_compositions)
1005 (get_composition_id, composition_gstring_from_id):
1006 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1007 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1008 * window.c (Frecenter):
1009 Use ptrdiff_t, not int, for composition IDs.
1010 * composite.c (get_composition_id): Check for integer overflow.
1011 * composite.h: Adjust prototypes to match the above changes.
1013 Use ptrdiff_t for hash table indexes.
1014 * category.c (hash_get_category_set):
1015 * ccl.c (ccl_driver):
1016 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1017 * coding.c (coding_system_charset_list, detect_coding_system):
1018 * coding.h (struct coding_system.id):
1019 * composite.c (get_composition_id, gstring_lookup_cache):
1020 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1021 * image.c (xpm_get_color_table_h):
1022 * lisp.h (hash_lookup, hash_put):
1023 * minibuf.c (Ftest_completion):
1024 Use ptrdiff_t for hash table indexes, not int (which is too
1025 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1026 32-bit --with-wide-int hosts).
1028 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1029 Add a FIXME comment about memory leaks.
1030 (syms_of_charset): Don't assume xmalloc returns.
1032 Don't assume that stated character widths fit in int.
1033 * character.c (Fchar_width, c_string_width, lisp_string_width):
1034 * character.h (CHAR_WIDTH):
1035 * indent.c (MULTIBYTE_BYTES_WIDTH):
1036 Use sanitize_char_width to avoid undefined and/or bad behavior
1037 with outlandish widths.
1038 * character.h (sanitize_tab_width): Rename from sanitize_width,
1039 now that we have two such functions. All uses changed.
1040 (sanitize_char_width): New inline function.
1042 Don't assume that tab-width fits in int.
1043 * character.h (sanitize_width): New inline function.
1044 (SANE_TAB_WIDTH): New macro.
1045 (ASCII_CHAR_WIDTH): Use it.
1046 * indent.c (sane_tab_width): Remove. All uses replaced by
1047 SANE_TAB_WIDTH (current_buffer).
1048 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1050 * fileio.c: Integer overflow issues with file modes.
1051 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1053 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1054 Remove unreachable code.
1055 (read_hex, load_charset_map_from_file): Check for integer overflow.
1057 * xterm.c: don't go over XClientMessageEvent limit
1058 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1059 (x_send_scroll_bar_event): Likewise. Check that the size does not
1060 exceed limits imposed by XClientMessageEvent, as well as the usual
1061 ptrdiff_t and size_t limits.
1063 * keyboard.c: Overflow, signedness and related fixes.
1064 (make_lispy_movement): Use same integer type in forward decl
1065 that is used in the definition.
1066 (read_key_sequence, keyremap_step):
1067 Change bufsize argument back to int, undoing my 2011-03-30 change.
1068 We prefer signed types, and int is wide enough here.
1069 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1070 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1071 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1072 length, not size_t. Use ptrdiff_t for index, not int.
1073 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1074 possibility of integer overflow.
1076 Overflow, signedness and related fixes for images.
1078 * dispextern.h (struct it.stack[0].u.image.image_id)
1079 (struct_it.image_id, struct image.id, struct image_cache.size)
1080 (struct image_cache.used, struct image_cache.ref_count):
1081 * gtkutil.c (update_frame_tool_bar):
1082 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1083 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1084 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1085 * nsmenu.m (update_frame_tool_bar):
1086 * xdisp.c (calc_pixel_width_or_height):
1087 * xfns.c (image_cache_refcount):
1088 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1089 on typical 64-bit hosts.
1091 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1092 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1093 Omit unnecessary casts to int.
1094 (parse_image_spec): Check that integers fall into 'int' range
1095 when the callers expect that.
1096 (image_ascent): Redo ascent calculation to avoid int overflow.
1097 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1098 (lookup_image): Remove unnecessary tests.
1099 (xbm_image_p): Locals are now of int, not EMACS_INT,
1100 since parse_image_check makes sure they fit into int.
1101 (png_load, gif_load, svg_load_image):
1102 Prefer int to unsigned where either will do.
1103 (tiff_handler): New function, combining the cores of the
1104 old tiff_error_handler and tiff_warning_handler.
1105 This function is rewritten to use vsnprintf and thereby avoid
1106 stack buffer overflows. It uses only the features of vsnprintf
1107 that are common to both POSIX and native Microsoft.
1108 (tiff_error_handler, tiff_warning_handler): Use it.
1109 (tiff_load, gif_load, imagemagick_load_image):
1110 Don't assume :index value fits in 'int'.
1111 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1112 (imagemagick_load_image): Check that crop parameters fit into
1113 the integer types that MagickCropImage accepts. Don't assume
1114 Vimagemagick_render_type has a nonnegative value. Don't assume
1115 size_t fits in 'long'.
1116 (gs_load): Use printmax_t to print the widest integers possible.
1117 Check for integer overflow when computing image height and width.
1119 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1121 * xdisp.c (redisplay_window): Don't force window start if point
1122 will be invisible in the resulting window. (Bug#9324)
1124 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1126 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1127 the display spec is of the form `(space ...)'.
1128 (handle_display_spec): Return the value returned by
1129 handle_single_display_spec, not just 1 or zero.
1130 (handle_single_display_spec): If the display spec is of the form
1131 `(space ...)', and specifies display in the text area, return 2
1133 (try_cursor_movement): Check for the need to scroll more
1134 accurately, and prefer exact match for point under bidi.
1135 Don't advance `row' beyond the last row of the window.
1137 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1138 into disp_prop; all users changed.
1140 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1141 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1142 for the text covered by the display property.
1144 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1146 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1147 Change return value to nil.
1148 (Frecord_buffer): Delete unused function.
1150 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1152 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1153 buffers, return left-to-right.
1154 (set_cursor_from_row): Consider candidate row a win if its glyph
1155 represents a newline and point is on that newline. Fixes cursor
1156 positioning on the newline at EOL of R2L text within L2R
1157 paragraph, and vice versa.
1158 (try_cursor_movement): Check continued rows, in addition to
1159 continuation rows. Fixes unwarranted scroll when point enters a
1160 continued line of R2L text within an L2R paragraph, or vice versa.
1161 (cursor_row_p): Consider the case of point being equal to
1162 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1163 from the end of a short line to the beginning of a continued line
1164 of R2L text within L2R paragraph.
1165 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1166 composed characters.
1168 * bidi.c (bidi_check_type): Use xassert.
1169 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1172 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1174 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1177 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1179 * nsfont.m (ns_otf_to_script): Fix typo.
1181 2011-08-22 Kenichi Handa <handa@m17n.org>
1183 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1184 extra slot even if the purpose is char-code-property-table.
1186 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1188 * xdisp.c (redisplay_window): When computing centering_position,
1189 account for the height of the header line. (Bug#8874)
1191 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1192 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1193 candidate is selected by the mouse, and that candidate has a
1194 composed character under the mouse.
1196 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1197 coordinates reported by pos-visible-in-window-p for a composed
1198 character in column zero.
1200 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1202 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1204 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1206 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1207 consider it a hit if to_charpos is anywhere in the range of the
1208 composed buffer positions.
1210 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1212 * image.c (gif_load): Don't assume that each subimage has the same
1213 dimensions as the base image. Handle disposal method that is
1214 "undefined" by the gif spec (Bug#9335).
1216 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1218 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1219 (Fcondition_case): Document `debug' symbol in error handler.
1221 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1223 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1224 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1225 from an Org mode buffer to a Speedbar frame.
1227 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1228 a composition, take its buffer position from IT->cmp_it.charpos.
1229 Fixes cursor positioning at the beginning of a line that begins
1230 with a composed character.
1232 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1234 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1235 character bidirectional type, use STRONG_L instead. Fixes crashes
1236 in a buffer produced by `describe-categories'.
1238 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1239 members before the level stack, so they would be saved and
1240 restored when copying iterator state. Fixes incorrect reordering
1241 around TABs covered by display properties.
1243 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1245 * process.c (Fnetwork_interface_list): Correctly determine buffer
1248 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1250 * eval.c (internal_condition_case, internal_condition_case_1)
1251 (internal_condition_case_2, internal_condition_case_n):
1252 Remove unnecessary aborts (Bug#9081).
1254 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1256 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1257 has no `load' handler, try opening the file locally. (Bug#9311)
1259 2011-08-16 Ken Brown <kbrown@cornell.edu>
1261 * gmalloc.c: Expand comment.
1263 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1265 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1266 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1268 2011-08-16 Ken Brown <kbrown@cornell.edu>
1270 Fix memory allocation problems in Cygwin build (Bug#9273).
1272 * unexcw.c ( __malloc_initialized): Declare external variable.
1273 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1275 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1277 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1279 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1281 [CYGWIN] (special_realloc): New function.
1282 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1283 requests to realloc storage in the static heap.
1285 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1287 * bidi.c (bidi_initialize): Remove unused local.
1289 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1291 * biditype.h: File removed.
1293 * bidimirror.h: File removed.
1295 * deps.mk (bidi.o): Remove biditype.h and
1298 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1301 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1303 * chartab.c: Improve commentary for the uniprop_table API.
1305 * bidi.c (bidi_paragraph_init): Support zero value of
1306 bidi_ignore_explicit_marks_for_paragraph_level.
1307 (bidi_initialize): Use uniprop_table instead of including
1308 biditype.h and bidimirror.h.
1310 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1311 coordinates of the iterator when restoring from ppos_it.
1314 2011-08-14 Kenichi Handa <handa@m17n.org>
1316 * process.c (create_process): Call setup_process_coding_systems
1317 after the pid of the process is set to -1 (Bug#8162).
1319 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1321 * xdisp.c (move_it_in_display_line_to): Don't invoke
1322 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1323 ppos_it. Fixes vertical cursor motion when line beginning is
1324 covered by an image. (Bug#9296)
1326 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1328 * nsterm.h (ns_run_ascript): Declare.
1329 (NSAPP_DATA2_RUNASSCRIPT): Define.
1331 * nsfns.m (as_script, as_result, as_status): New static variables.
1332 (ns_run_ascript): New function.
1333 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1334 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1335 the event loop. Get status from as_status (Bug#7276).
1337 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1338 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1339 the event loop (Bug#7276).
1341 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1343 * gnutls.c (QCgnutls_bootprop_priority)
1344 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1345 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1346 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1347 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1348 (QCgnutls_bootprop_verify_hostname_error)
1349 (QCgnutls_bootprop_callbacks_verify): Rename from
1350 Qgnutls_bootprop_..., all uses changed.
1352 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1355 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1357 * xfaces.c (Qframe_set_background_mode): Now static.
1358 * dispextern.h (Qframe_set_background_mode): Remove decl.
1360 * process.c (Fnetwork_interface_info): Declare local only if needed.
1362 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1364 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1365 (Fnetwork_interface_list): Allocate in increments of bytes instead
1366 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1367 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1369 (struct ifflag_def): notrailers is smart on OSX.
1370 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1371 Get hardware address with getifaddrs if available.
1373 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1375 * xdisp.c (iterate_out_of_display_property): xassert that
1376 IT->position is set to within IT->object's boundaries. Break from
1377 the loop as soon as EOB is reached; avoids infloops in redisplay
1378 when IT->position is set up wrongly due to some bug.
1379 Set IT->current to match the bidi iterator unconditionally.
1380 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1381 entry. Force push_it to save on the stack the current
1382 buffer/string position, to be restored by pop_it. Fix flags in
1383 the iterator structure wrt the object coming from a display
1384 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1385 properties. (Bug#9284)
1387 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1389 * fontset.c (fontset_get_font_group): Add proper type checks.
1392 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1394 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1395 and LC_VERSION_MIN_MACOSX.
1396 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1397 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1399 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1401 * xdisp.c (forward_to_next_line_start): Allow to use the
1402 no-display-properties-and-no-overlays under bidi display.
1403 Set disp_pos in the bidi iterator to avoid searches for display
1404 properties and overlays.
1406 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1408 * editfns.c (Fset_time_zone_rule): Document relationship with the
1411 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1412 the font entity extracted from the cache (Bug#8109).
1414 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1416 * composite.c (autocmp_chars): Don't reset point. That is done by
1417 restore_point_unwind (Bug#5984).
1419 2011-08-07 Juri Linkov <juri@jurta.org>
1421 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1422 to show the arg `TIME' instead of `TIMEVAL'.
1424 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1426 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1427 display property strides EOL and includes a newline, as in
1428 longlines-mode. (Bug#9254)
1429 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1430 word-wrap under bidirectional display. (Bug#9224)
1432 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1433 is non-zero, even if the data buffer is NULL. Fixes a crash in
1434 vertical-motion with longlines-mode. (Bug#9254)
1436 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1438 * bidi.c <bidi_cache_total_alloc>: Now static.
1439 (bidi_initialize): Initialize bidi_cache_total_alloc.
1441 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1444 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1445 amount allocated this far in `bidi_cache_total_alloc'.
1446 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1447 non-zero, only free the data buffer without restoring the cache
1448 contents. All callers changed.
1450 * dispextern.h (bidi_unshelve_cache): Update prototype.
1452 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1453 (move_it_in_display_line, move_it_to)
1454 (move_it_vertically_backward, move_it_by_lines): Replace the call
1455 to xfree to an equivalent call to bidi_unshelve_cache.
1456 (move_it_in_display_line_to): Fix logic of returning
1457 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1459 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1461 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1462 came from a string character with a `cursor' property. (Bug#9229)
1464 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1466 * Makefile.in (LIB_PTHREAD): New variable.
1467 (LIBES): Add LIB_PTHREAD (Bug#9216).
1469 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1470 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1472 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1474 * regex.c (re_iswctype): Remove some redundant boolean
1477 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1479 * xterm.c (x_find_topmost_parent): New function.
1480 (x_set_frame_alpha): Find topmost parent window with
1481 x_find_topmost_parent and set the property there also (bug#9181).
1482 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1484 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1486 * callproc.c (Fcall_process): Avoid vfork clobbering
1487 the local vars buffer, coding_systems, current_dir.
1489 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1491 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1493 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1495 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1496 so that it is not optimized away.
1498 * xdisp.c (compute_display_string_pos): Remove unused local.
1500 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1502 Fix slow cursor motion and scrolling in large buffers with
1503 selective display, like Org Mode buffers. (Bug#9218)
1505 * dispextern.h (struct bidi_it): New member disp_prop_p.
1507 * xdisp.c: Remove one-slot cache of display string positions.
1508 (compute_display_string_pos): Accept an additional argument
1509 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1510 for a display string or property. If found, set DISP_PROP_P
1513 * bidi.c (bidi_fetch_char): Accept an additional argument
1514 DISP_PROP_P, and pass it to compute_display_string_pos.
1515 Only handle text covered by a display string if DISP_PROP_P is returned
1516 non-zero. All callers of bidi_fetch_char changed.
1518 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1520 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1522 2010-12-03 Don March <don@ohspite.net>
1524 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1525 last character M-[char] is translated to ESC [char] (bug#7541).
1527 2011-08-02 Kenichi Handa <handa@m17n.org>
1529 * lisp.h (uniprop_table): Extern it.
1531 * chartab.c (uniprop_table): Make it non-static.
1533 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1535 * xdisp.c (forward_to_next_line_start): Accept additional argument
1536 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1538 (reseat_at_next_visible_line_start): Use the bidi iterator state
1539 returned by forward_to_next_line_start to restore the state of
1540 it->bidi_it after backing up to previous newline. (Bug#9212)
1542 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1544 * regex.c (re_comp): Protoize.
1545 (re_exec): Fix return type.
1546 (regexec): Fix type of `ret'. (Bug#9203)
1548 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1550 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1551 This is needed if max-image-size is a floating-point number.
1553 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1555 * print.c (print_object): Print empty symbol as ##.
1557 * lread.c (read1): Read ## as empty symbol.
1559 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1561 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1562 setting frame foreground color (Bug#9175).
1563 (x_set_background_color): Likewise.
1565 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1566 contents (Bug#9176).
1567 (EmacsTooltip -init): Remove bezels and add shadows to
1570 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1571 or scroll bar (Bug#8470).
1573 * nsfont.m (nsfont_open): Remove assignment to voffset and
1574 unnecessary vars hshink, expand, hd, full_height, min_height.
1575 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1577 * nsterm.h (nsfont_info): Remove voffset field.
1579 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1581 Implement strike-through and overline on NextStep (Bug#8863).
1583 * nsfont.m (nsfont_open): Use underline position provided by font,
1584 instead of hard-coded value of 2.
1585 (nsfont_draw): Call ns_draw_text_decoration instead.
1587 * nsterm.h: Add declaration for ns_draw_text_decoration.
1589 * nsterm.m (ns_draw_text_decoration): New function for drawing
1590 underline, overline, and strike-through.
1591 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1592 ns_draw_text_decoration. Change treatment of cursor drawing to
1593 accommodate underlining, etc.
1595 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1597 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1600 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1602 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1603 Without this fix, if a signal arrives just after memory fills up,
1604 'malloc' might be invoked reentrantly.
1606 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1607 In other words, assume that every image size is allowed, on non-X
1608 hosts. This assumption is probably wrong, but it lets Emacs compile.
1610 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1612 * regex.c (re_iswctype): Convert return values to boolean.
1614 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1616 * xdisp.c (compute_display_string_pos): Don't use cached display
1617 string position if the buffer had its restriction changed.
1620 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1622 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1624 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1626 Integer signedness and overflow and related fixes. (Bug#9079)
1628 * bidi.c: Integer size and overflow fixes.
1629 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1630 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1631 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1632 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1633 (bidi_find_other_level_edge):
1634 Use ptrdiff_t instead of EMACS_INT where either will do.
1635 This works better on 32-bit hosts configured --with-wide-int.
1636 (bidi_cache_ensure_space): Check for size-calculation overflow.
1637 Use % rather than repeated addition, for better worst-case speed.
1638 Don't set bidi_cache_size until after xrealloc returns, because it
1640 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1641 (bidi_cache_ensure_space): Also check that the bidi cache size
1642 does not exceed that of the largest Lisp string or buffer. See Eli
1643 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1645 * alloc.c (__malloc_size_t): Remove.
1646 All uses replaced by size_t. See Andreas Schwab's note
1647 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1649 * image.c: Improve checking for integer overflow.
1650 (check_image_size): Assume that f is nonnull, since
1651 it is always nonnull in practice. This is one less thing to
1652 worry about when checking for integer overflow later.
1653 (x_check_image_size): New function, which checks for integer
1654 overflow issues inside X.
1655 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1656 This removes the need for a memory_full check.
1657 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1658 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1659 (xbm_read_bitmap_data): Change locals back to 'int', since
1660 their values must fit in 'int'.
1661 (xpm_load_image, png_load, tiff_load):
1662 Invoke x_create_x_image_and_pixmap earlier,
1663 to avoid much needless work if the image is too large.
1664 (tiff_load): Treat overly large images as if
1665 x_create_x_image_and_pixmap failed, not as malloc failures.
1666 (gs_load): Use x_check_image_size.
1668 * gtkutil.c: Omit integer casts.
1669 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1670 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1672 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1674 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1675 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1676 would wrongly return t on a 64-bit host.
1678 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1679 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1680 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1681 and therefore cause GCC to emit a bogus diagnostic in some cases.
1683 * image.c: Integer signedness and overflow and related fixes.
1684 This is not an exhaustive set of fixes, but it's time to
1685 record what I've got.
1686 (lookup_pixel_color, check_image_size): Remove redundant decls.
1687 (check_image_size): Don't assume that arbitrary EMACS_INT values
1688 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1689 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1690 (tiff_load, imagemagick_load_image):
1691 Check for overflow in size calculations.
1692 (x_create_x_image_and_pixmap): Remove unnecessary test for
1693 xmalloc returning NULL; that can't happen.
1694 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1695 (xpm_color_bucket): Use better integer hashing function.
1696 (xpm_cache_color): Don't possibly over-allocate memory.
1697 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1698 (gif_memory_source):
1699 Use ptrdiff_t, not int or size_t, to record sizes.
1700 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1701 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1702 either works, as we prefer signed integers.
1703 (tiff_read_from_memory, tiff_write_from_memory):
1704 Return tsize_t, not size_t, since that's what the TIFF API wants.
1705 (tiff_read_from_memory): Don't fail simply because the read would
1706 go past EOF; instead, return a short read.
1707 (tiff_load): Omit no-longer-needed casts.
1708 (Fimagemagick_types): Don't assume size fits into 'int'.
1710 Improve hashing quality when configured --with-wide-int.
1711 * fns.c (hash_string): New function, taken from sxhash_string.
1712 Do not discard information about ASCII character case; this
1713 discarding is no longer needed.
1714 (sxhash-string): Use it. Change sig to match it. Caller changed.
1715 * lisp.h: Declare it.
1716 * lread.c (hash_string): Remove, since we now use fns.c's version.
1717 The fns.c version returns a wider integer if --with-wide-int is
1718 specified, so this should help the quality of the hashing a bit.
1720 * emacs.c: Integer overflow minor fix.
1721 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1722 Define only if GNU_LINUX.
1723 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1725 * dispnew.c: Integer signedness and overflow fixes.
1726 Remove unnecessary forward decls, that were a maintenance hassle.
1727 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1729 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1730 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1731 (prepare_desired_row, line_draw_cost):
1732 Use int, not unsigned, where either works.
1733 (save_current_matrix, restore_current_matrix):
1734 Use ptrdiff_t, not size_t, where either works.
1735 (init_display): Check for overflow more accurately, and without
1736 relying on undefined behavior.
1738 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1739 Remove, replacing with the new symbols in lisp.h. All uses changed.
1740 * fileio.c (make_temp_name):
1741 * filelock.c (lock_file_1, lock_file):
1742 * xdisp.c (message_dolog):
1743 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1744 Use pMd etc. instead.
1745 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1746 replacing the pWIDE etc. symbols removed from editfns.c.
1748 * keyboard.h (num_input_events): Now uintmax_t.
1749 This is (very slightly) less likely to mess up due to wraparound.
1752 * buffer.c: Integer signedness fixes.
1753 (alloc_buffer_text, enlarge_buffer_text):
1754 Use ptrdiff_t rather than size_t when either will do, as we prefer
1757 * alloc.c: Integer signedness and overflow fixes.
1758 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1759 (__malloc_size_t): Default to size_t, not to int.
1760 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1761 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1762 Prefer ptrdiff_t to size_t when either would do, as we prefer
1764 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1765 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1766 Now const. Initialize with values that are in range even if char
1768 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1769 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1770 These functions do the right thing with sizes > 2**32.
1771 (check_depth): Now ptrdiff_t, not int.
1772 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1773 Adjust to new way of storing sizes. Check for size overflow bugs
1775 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1776 slightly wrong anyway, as it missed one instance of
1777 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1778 (refill_memory_reserve): Omit needless cast to size_t.
1779 (mark_object_loop_halt): Mark as externally visible.
1781 * xselect.c: Integer signedness and overflow fixes.
1782 (Fx_register_dnd_atom, x_handle_dnd_message):
1783 Use ptrdiff_t, not size_t, since we prefer signed.
1784 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1785 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1786 x_dnd_atoms_size and x_dnd_atoms_length.
1788 * doprnt.c: Prefer signed to unsigned when either works.
1790 * doprnt.c (doprnt):
1792 * xdisp.c (vmessage):
1793 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1794 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1795 prefer signed arithmetic to avoid comparison confusion.
1796 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1797 but is a bit tricky.
1799 Assume freestanding C89 headers, string.h, stdlib.h.
1800 * data.c, doprnt.c, floatfns.c, print.c:
1801 Include float.h unconditionally.
1802 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1803 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1804 * regex.c: Likewise for stddef.h, string.h.
1805 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1806 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1807 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1808 (STDC_HEADERS): Remove obsolete defines.
1809 * sysdep.c: Include limits.h unconditionally.
1811 Assume support for memcmp, memcpy, memmove, memset.
1812 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1813 * regex.c (memcmp, memcpy):
1814 Remove; we assume C89 now.
1816 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1817 (__malloc_safe_bcopy): Remove; no longer needed.
1819 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1820 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1821 well either way, and we prefer signed to unsigned.
1823 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1825 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1826 closes the connection while we're reading (bug#9182).
1828 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1830 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1831 are specified (Bug#9168).
1833 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1835 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1836 Found by GCC static checking and --with-wide-int on a 32-bit host.
1838 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1840 * xdisp.c (compute_display_string_pos): Fix logic of caching
1841 previous display string position. Initialize cached_prev_pos to
1842 -1. Fixes slow-down at the beginning of a buffer.
1844 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1846 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1847 for attrs[LFACE_FONTSET_INDEX].
1849 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1851 * xml.c (parse_region): Remove unused local
1852 that was recently introduced.
1854 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1856 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1857 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1859 * xdisp.c (move_it_in_display_line_to): Record the best matching
1860 position for TO_CHARPOS while scanning the line, and restore it on
1861 exit if none of the characters scanned was an exact match.
1862 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1863 when exact match is impossible due to invisible text, and the
1864 lines are truncated.
1866 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1868 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1871 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1873 Fix a significant slow-down of cursor motion with C-n, C-p,
1874 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1875 auto-repeat under bidi redisplay in fontified buffers.
1876 * xdisp.c (compute_stop_pos_backwards): New function.
1877 (next_element_from_buffer): Call compute_stop_pos_backwards to
1878 find a suitable prev_stop when we find ourselves before
1880 (reseat): Don't look for prev_stop, as that could mean a very long
1882 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1883 <cached_disp_overlay_modiff>: Cache for last found display string
1885 (compute_display_string_pos): Return the cached position if asked
1886 about the same buffer in the same area of character positions, and
1887 the buffer wasn't changed since the time the display string
1888 position was cached.
1890 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1892 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1893 is an integer, which is important for empty lines. (Bug#9149)
1895 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1897 * frame.c (Fmodify_frame_parameters): In tty case, update the
1898 default face if necessary (Bug#4238).
1900 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1902 * editfns.c (Fstring_to_char): No need to explain what a character
1903 is in the docstring (Bug#6576).
1905 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1907 * xml.c (parse_region): Make sure we always return a tree.
1909 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1911 * xml.c (parse_region): If a document contains only comments,
1914 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1916 * xml.c (make_dom): Return comments, too.
1918 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1921 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1922 and the surrounding thread.
1923 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1924 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1925 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1927 * s/openbsd.h (BROKEN_SIGIO): Define.
1928 * unexelf.c (unexec) [__OpenBSD__]:
1929 Don't update the .mdebug section of the Alpha COFF symbol table.
1931 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1933 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1936 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1938 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1939 This fixes some race conditions on the permissions of any newly
1942 * alloc.c (valid_pointer_p): Use pipe, not open.
1943 This fixes some permissions issues when debugging.
1945 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1946 If fchown fails to set both uid and gid, try to set just gid,
1947 as that is sometimes allowed. Adjust the file's mode to eliminate
1948 setuid or setgid bits that are inappropriate if fchown fails.
1950 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1952 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1953 to compare Lisp_Objects.
1954 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1955 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1956 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1958 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1960 * lread.c (read_integer): Unread even EOF character.
1961 (read1): Likewise. Properly record start position of symbol.
1963 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1964 symbol character follows.
1966 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1968 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1969 This works around a problem with the previous change to Fcopy_file.
1970 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1971 and without this change, GCC might complain about discarding
1972 fchown's return value.
1974 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1976 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1978 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1980 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1982 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1984 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1985 it's used from the C level.
1987 * process.c: Use the same condition for POLL_FOR_INPUT in both
1988 keyboard.c and process.c (bug#1858).
1990 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1992 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1993 (Fgnutls_boot): Use it.
1995 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1997 * doc.c (Fsubstitute_command_keys): Revert last change.
1999 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2001 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2002 quotes the next character, and doesn't affect other longer
2003 sequences (bug#8935).
2005 * lread.c (syms_of_lread): Clarify that is isn't only
2006 `eval-buffer' and `eval-defun' that's affected by
2007 `lexical-binding' (bug#8460).
2009 2011-07-15 Eli Zaretskii <eliz@gnu.org>
2011 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2012 bidi redisplay when a line includes both an image and is
2015 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2017 Fix minor problems found by static checking.
2018 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2019 (elsz): Now a signed constant, not a size_t var. We prefer signed
2020 types to unsigned, to avoid integer comparison confusion. Without
2021 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2022 "cannot optimize loop, the loop counter may overflow", a symptom
2024 * indent.c (Fvertical_motion): Mark locals as initialized.
2025 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2027 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2029 * search.c (Fre_search_backward): Mention `case-fold-search' in
2030 all the re_search_* functions (bug#8138).
2032 * keyboard.c (Fopen_dribble_file): Document when the file is
2035 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2037 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2040 Support bidi reordering of display and overlay strings.
2041 * xdisp.c (compute_display_string_pos)
2042 (compute_display_string_end): Accept additional argument STRING.
2043 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2044 (reseat_to_string): Initialize bidi_it->string.s and
2045 bidi_it->string.schars.
2046 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2047 NULL (avoids a crash in bidi_paragraph_init).
2048 Initialize itb.string.lstring.
2049 (init_iterator): Call bidi_init_it only of a valid
2050 buffer position was specified. Initialize paragraph_embedding to
2052 (reseat_to_string): Initialize the bidi iterator.
2053 (display_string): If we need to ignore text properties of
2054 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2055 original value of -1 will not work with bidi.)
2056 (compute_display_string_pos): First arg is now struct
2057 `text_pos *'; all callers changed. Support display properties on
2059 (compute_display_string_end): Support display properties on Lisp
2061 (init_iterator, reseat_1, reseat_to_string): Initialize the
2062 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2063 when iterating on a string not from display properties).
2064 (compute_display_string_pos, compute_display_string_end):
2065 Fix calculation of the object to scan. Fixes an error when using
2067 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2068 base_level_stop; instead, set base_level_stop to BEGV.
2069 Fixes crashes in vertical-motion.
2070 (next_element_from_buffer): Improve commentary for when
2071 the iterator is before prev_stop.
2072 (init_iterator): Initialize bidi_p from the default value of
2073 bidi-display-reordering, not from buffer-local value. Use the
2074 buffer-local value only if initializing for buffer iteration.
2075 (handle_invisible_prop): Support invisible properties on strings
2076 that are being bidi-reordered.
2077 (set_iterator_to_next): Support bidi reordering of C strings and
2079 (next_element_from_string): Support bidi reordering of Lisp
2081 (handle_stop_backwards): Support Lisp strings as well.
2082 (display_string): Support display of R2L glyph rows.
2083 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2084 (init_iterator): Don't initialize it->bidi_p for strings
2086 (reseat_to_string): Initialize it->bidi_p for strings here.
2087 (next_element_from_string, next_element_from_c_string)
2088 (next_element_from_buffer): Add xassert's for correspondence
2089 between IT's object being iterated and it->bidi_it.string
2091 (face_before_or_after_it_pos): Support bidi iteration.
2092 (next_element_from_c_string): Handle the case of the first string
2093 character that is not the first one in the visual order.
2094 (get_visually_first_element): New function, refactored from common
2095 parts of next_element_from_buffer, next_element_from_string, and
2096 next_element_from_c_string.
2097 (tool_bar_lines_needed, redisplay_tool_bar)
2098 (display_menu_bar): Force left-to-right direction. Add a FIXME
2099 comment for making that be controlled by a user option.
2100 (push_it, pop_it): Save and restore the state of the
2101 bidi iterator. Save and restore the bidi_p flag.
2102 (pop_it): Iterate out of display property for string iteration as
2104 (iterate_out_of_display_property): Support iteration over strings.
2105 (handle_single_display_spec): Set up it->bidi_it for iteration
2106 over a display string, and call bidi_init_it.
2107 (handle_single_display_spec, next_overlay_string)
2108 (get_overlay_strings_1, push_display_prop): Set up the bidi
2109 iterator for displaying display or overlay strings.
2110 (forward_to_next_line_start): Don't use the shortcut if
2112 (back_to_previous_visible_line_start): If handle_display_prop
2113 pushed the iterator stack, restore the internal state of the bidi
2114 iterator by calling bidi_pop_it same number of times.
2115 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2116 and we are bidi-iterating, don't decrement the iterator position;
2117 instead, set the first_elt flag in the bidi iterator, to produce
2119 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2120 (push_display_prop): xassert that we are iterating a buffer.
2121 (push_it, pop_it): Save and restore paragraph_embedding member.
2122 (handle_single_display_spec, next_overlay_string)
2123 (get_overlay_strings_1, reseat_1, reseat_to_string)
2124 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2125 correctly. Don't assume unibyte strings are not bidi-reordered.
2126 (compute_display_string_pos)
2127 (compute_display_string_end): Fix handling the case of C string.
2128 (push_it, pop_it): Save and restore from_disp_prop_p.
2129 (handle_single_display_spec, push_display_prop): Set the
2130 from_disp_prop_p flag.
2131 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2132 (pop_it): Call iterate_out_of_display_property only if we are
2133 popping after iteration over a string that came from a display
2134 property. Fix a typo in popping stretch info. Add an assertion
2135 for verifying that the iterator position is in sync with the bidi
2137 (handle_single_display_spec, get_overlay_strings_1)
2138 (push_display_prop): Fix initialization of paragraph direction for
2139 string when that of the parent object is not yet determined.
2140 (reseat_1): Call bidi_init_it to resync the bidi
2141 iterator with IT's position. (Bug#7616)
2142 (find_row_edges): If ROW->start.pos gives position
2143 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2144 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2145 Reset the from_disp_prop_p flag.
2146 (SAVE_IT, RESTORE_IT): New macros.
2147 (pos_visible_p, face_before_or_after_it_pos)
2148 (back_to_previous_visible_line_start)
2149 (move_it_in_display_line_to, move_it_in_display_line)
2150 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2151 (try_scrolling, redisplay_window, display_line): Use them when
2152 saving a temporary copy of the iterator and restoring it back.
2153 (back_to_previous_visible_line_start, reseat_1)
2154 (init_iterator): Empty the bidi cache "stack".
2155 (move_it_in_display_line_to): If iterator ended up at
2156 EOL, but we never saw any buffer positions smaller than
2157 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2158 motion in bidi-reordered lines.
2159 (move_it_in_display_line_to): Record prev_method and prev_pos
2160 immediately before the call to set_iterator_to_next. Fixes cursor
2161 motion in bidi-reordered lines with stretch glyphs and strings
2162 displayed in margins. (Bug#8133) (Bug#8867)
2163 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2165 (pos_visible_p): Support positions in bidi-reordered lines.
2166 Save and restore bidi cache.
2168 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2169 (bidi_paragraph_info): Delete unused struct.
2170 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2171 (bidi_cache_start): New variable.
2172 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2174 (bidi_cache_fetch_state, bidi_cache_search)
2175 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2176 (bidi_cache_find, bidi_peek_at_next_level)
2177 (bidi_level_of_next_char, bidi_find_other_level_edge)
2178 (bidi_move_to_visually_next): Compare cache index with
2179 bidi_cache_start rather than with zero.
2180 (bidi_fetch_char): Accept new argument STRING; all callers
2181 changed. Support iteration over a string. Support strings with
2182 display properties. Support unibyte strings. Fix the type of
2183 `len' according to what STRING_CHAR_AND_LENGTH expects.
2184 (bidi_paragraph_init, bidi_resolve_explicit_1)
2185 (bidi_resolve_explicit, bidi_resolve_weak)
2186 (bidi_level_of_next_char, bidi_move_to_visually_next):
2187 Support iteration over a string.
2188 (bidi_set_sor_type, bidi_resolve_explicit_1)
2189 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2190 can now be zero (for strings); special values 0 and -1 were
2191 changed to -1 and -2, respectively.
2192 (bidi_char_at_pos): New function.
2193 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2194 Call it instead of FETCH_MULTIBYTE_CHAR.
2195 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2196 initialized to valid values.
2197 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2199 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2200 the test for valid cached positions. Fix the logic for looking up
2201 the sentinel state in the cache. GCPRO the Lisp string we are
2203 (bidi_push_it, bidi_pop_it): New functions.
2204 (bidi_initialize): Initialize the bidi cache start stack pointer.
2205 (bidi_cache_ensure_space): New function, refactored from part of
2206 bidi_cache_iterator_state. Don't assume the required size is just
2207 one BIDI_CACHE_CHUNK away.
2208 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2209 (bidi_count_bytes, bidi_char_at_pos): New functions.
2210 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2211 always valid if bidi_cache_idx is valid.
2212 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2213 is valid if it's going to be used.
2214 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2215 (bidi_cache_fetch_state, bidi_cache_search)
2216 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2217 (bidi_cache_iterator_state, bidi_cache_find)
2218 (bidi_find_other_level_edge, bidi_cache_start_stack):
2219 All variables related to cache indices are now EMACS_INT.
2221 * dispextern.h (struct bidi_string_data): New structure.
2222 (struct bidi_it): New member `string'. Make flag members be 1-bit
2223 fields, and put them last in the struct.
2224 (compute_display_string_pos, compute_display_string_end):
2226 (bidi_push_it, bidi_pop_it): Add prototypes.
2227 (struct iterator_stack_entry): New members bidi_p,
2228 paragraph_embedding, and from_disp_prop_p.
2229 (struct it): Member bidi_p is now a bit field 1 bit wide.
2230 (bidi_shelve_cache, bidi_unshelve_cache):
2233 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2234 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2235 and vector-like objects.
2237 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2238 cache around display iteration.
2240 * window.c (Fwindow_end, window_scroll_pixel_based)
2241 (displayed_window_lines, Frecenter): Save and restore the bidi
2242 cache around display iteration.
2244 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2246 * editfns.c (Fdelete_region): Clarify the use of the named
2247 parameters (bug#6788).
2249 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2251 * indent.c (Fvertical_motion): Set and restore w->pointm when
2252 saving and restoring the window's buffer (Bug#9006).
2254 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2256 * editfns.c (Fstring_to_char): Clarify just what is returned
2257 (bug#6576). Text by Eli Zaretskii.
2259 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2261 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2263 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2265 * buffer.c (mmap_find): Fix a typo.
2267 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2269 Fix execution of x selection hooks.
2270 * xselect.c (Qx_lost_selection_functions)
2271 (Qx_sent_selection_functions): New vars.
2272 (syms_of_xselect): DEFSYM them.
2273 (x_handle_selection_request): Pass Qx_sent_selection_functions
2274 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2275 (x_handle_selection_clear,x_clear_frame_selections):
2276 Pass Qx_lost_selection_functions rather than
2277 Vx_lost_selection_functions to Frun_hook_with_args.
2279 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2281 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2282 The old code sometimes used this field without initializing it.
2284 * alloc.c (gc_sweep): Don't read past end of array.
2285 In theory, the old code could also have corrupted Emacs internals,
2286 though it'd be very unlikely.
2288 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2290 * character.c (Fcharacterp): Don't advertise optional ignored
2291 argument. (Bug#4026)
2293 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2295 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2298 * window.c (Fset_window_start): Doc fix (bug#4199).
2299 (Fset_window_hscroll): Ditto.
2301 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2303 Fix minor new problems caught by GCC 4.6.1.
2304 * term.c (init_tty): Remove unused local.
2305 * xsettings.c (store_monospaced_changed): Define this function only
2306 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2309 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2311 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2313 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2315 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2316 are the mini-buffer and the echo area (bug#3320).
2318 * term.c (init_tty): Remove support for supdup, c10 and perq
2319 terminals, which are no longer supported (bug#1482).
2321 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2323 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2325 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2327 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2328 for non-popups (Bug#3642).
2330 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2332 * alloc.c (reset_malloc_hooks): Protoize.
2333 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2334 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2335 * cm.c (losecursor): Likewise.
2336 * data.c (fmod): Likewise.
2337 * dispnew.c (swap_glyphs_in_rows): Likewise.
2338 * emacs.c (memory_warning_signal): Likewise.
2339 * floatfns.c (float_error): Likewise.
2340 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2341 (otf_open, font_otf_capability, generate_otf_features)
2342 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2344 * image.c (pbm_read_file): Likewise.
2345 * indent.c (string_display_width): Likewise.
2346 * intervals.c (check_for_interval, search_for_interval)
2347 (inc_interval_count, count_intervals, root_interval)
2348 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2349 * lread.c (defalias): Likewise.
2350 * ralloc.c (r_alloc_check): Likewise.
2351 * regex.c (set_image_of_range_1, set_image_of_range)
2352 (regex_grow_registers): Likewise.
2353 * sysdep.c (strerror): Likewise.
2354 * termcap.c (valid_filename_p, tprint, main): Likewise.
2355 * tparam.c (main): Likewise.
2356 * unexhp9k800.c (run_time_remap, save_data_space)
2357 (update_file_ptrs, read_header, write_header, calculate_checksum)
2358 (copy_file, copy_rest, display_header): Likewise.
2359 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2361 * xdisp.c (check_it): Likewise.
2362 * xfaces.c (register_color, unregister_color, unregister_colors):
2364 * xfns.c (print_fontset_result): Likewise.
2365 * xrdb.c (member, fatal, main): Likewise.
2367 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2369 Fix minor problems found by static checking (Bug#9031).
2370 * chartab.c (char_table_set_range, map_sub_char_table):
2371 Remove unused locals.
2372 (uniprop_table): Now static.
2373 * composite.c (_work_char): Remove unused static var.
2375 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2377 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2379 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2381 * gtkutil.c (qttip_cb): Remove code without function.
2383 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2385 * w32.c (pthread_sigmask): New stub.
2387 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2389 Use pthread_sigmask, not sigprocmask (Bug#9010).
2390 sigprocmask is portable only for single-threaded applications, and
2391 Emacs can be multi-threaded when it uses GTK.
2392 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2394 * callproc.c (Fcall_process):
2395 * process.c (create_process):
2396 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2397 Use pthread_sigmask, not sigprocmask.
2399 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2401 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2402 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2405 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2407 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2408 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2409 (xg_hide_tooltip): Fix comment.
2411 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2412 in registerServicesMenuSendTypes.
2413 (validRequestorForSendType): Don't check ns_return_types.
2415 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2418 2011-07-08 Jason Rumney <jasonr@gnu.org>
2420 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2421 frame struct members of non-existent frames (Bug#6284).
2423 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2425 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2426 variable firstTime not needed on OSX >= 10.6.
2427 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2428 >= 10.5. Use setKnobProportion, setDoubleValue.
2430 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2431 (MAC_OS_X_VERSION_10_5): Define if not defined.
2432 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2433 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2434 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2436 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2437 cString and lossyCString on OSX >= 10.4
2439 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2440 sizeToFit on OSX >= 10.2.
2442 * nsimage.m (allocInitFromFile): Don't use deprecated method
2443 bestRepresentationForDevice on OSX >= 10.6.
2445 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2448 * emacs.c: Declare unexec_init_emacs_zone.
2450 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2452 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2454 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2455 on svcsMenu (Bug#8842).
2457 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2459 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2461 * nsterm.m (QUTF8_STRING): Declare.
2462 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2463 (validRequestorForSendType): Return type is (id).
2464 Change indexOfObjectIdenticalTo to indexOfObject.
2465 Check if we have local selection before returning self (Bug#8842).
2466 (writeSelectionToPasteboard): Put local selection into paste board
2467 if we have a local selection (Bug#8842).
2468 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2470 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2471 (ns_get_local_selection): Declare.
2473 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2475 * keymap.c (describe_map_tree): Don't insert a double newline at
2476 the end of the buffer (bug#1169) and return whether we inserted
2479 * callint.c (Fcall_interactively): Change "reading args" to
2480 "providing args" to try to clarify what it does (bug#1010).
2482 2011-07-07 Kenichi Handa <handa@m17n.org>
2484 * composite.c (composition_compute_stop_pos): Ignore a static
2485 composition starting before CHARPOS (Bug#8915).
2487 * xdisp.c (handle_composition_prop): Likewise.
2489 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2491 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2494 2011-07-07 Kenichi Handa <handa@m17n.org>
2496 * character.h (unicode_category_t): New enum type.
2498 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2499 (Qchar_code_property_table): New variable.
2500 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2501 (UNIPROP_COMPRESSED_FORM_P): New macros.
2502 (char_table_ascii): Uncompress the compressed values.
2503 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2504 Uncompress the compressed values.
2505 (sub_char_table_ref_and_range): Likewise.
2506 (char_table_ref_and_range): Uncompress the compressed values.
2507 (sub_char_table_set): New arg is_uniprop. Callers changed.
2508 Uncompress the compressed values.
2509 (sub_char_table_set_range): Args changed. Callers changed.
2510 (char_table_set_range): Adjuted for the above change.
2511 (map_sub_char_table): Delete args default_val and parent. Add arg
2512 top. Give decoded values to a Lisp function.
2513 (map_char_table): Adjust for the above change. Give decoded
2514 values to a Lisp function. Gcpro more variables.
2515 (uniprop_table_uncompress)
2516 (uniprop_decode_value_run_length): New functions.
2517 (uniprop_decoder, uniprop_decoder_count): New variables.
2518 (uniprop_get_decoder, uniprop_encode_value_character)
2519 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2521 (uniprop_encoder, uniprop_encoder_count): New variables.
2522 (uniprop_get_encoder, uniprop_table)
2523 (Funicode_property_table_internal, Fget_unicode_property_internal)
2524 (Fput_unicode_property_internal): New functions.
2525 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2526 Sunicode_property_table_internal, Sget_unicode_property_internal,
2527 and Sput_unicode_property_internal. Defvar_lisp
2528 char-code-property-alist.
2530 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2531 Vunicode_category_table.
2533 * font.c (font_range): Adjust for the change of
2534 Vunicode_category_table.
2536 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2538 * m/iris4d.h: Remove file, move contents ...
2539 * s/irix6-5.h: ... here.
2541 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2543 Remove unportable assumption about struct layout (Bug#8884).
2544 * alloc.c (mark_buffer):
2545 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2546 (clone_per_buffer_values): Don't assume that
2547 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2548 This isn't true in general, and it's particularly not true
2549 if Emacs is configured with --with-wide-int.
2550 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2551 New macros, used in the buffer.c change.
2553 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2555 * xsettings.c: Use both GConf and GSettings if both are available.
2556 (store_config_changed_event): Add comment.
2557 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2558 (store_tool_bar_style_changed): New functions.
2559 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2560 (struct xsettings): Move font inside HAVE_XFT.
2561 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2562 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2563 Move inside HAVE_XFT.
2564 (something_changed_gsettingsCB): Rename from something_changedCB.
2565 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2567 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2568 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2569 (something_changed_gconfCB): Rename from something_changedCB.
2570 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2571 (parse_settings): Move check for font inside HAVE_XFT.
2572 (read_settings, apply_xft_settings): Add comment.
2573 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2574 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2575 call store_font_name_changed.
2576 (xft_settings_event): Add comment.
2577 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2578 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2579 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2580 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2581 (xsettings_initialize): Call init_gsettings last.
2582 (xsettings_get_system_font, xsettings_get_system_normal_font):
2585 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2587 Random fixes. E.g., (random) never returned negative values.
2588 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2589 subseconds part to the entropy, as that's a bit more random.
2590 Prefer signed to unsigned, since the signedness doesn't matter and
2591 in general we prefer signed. When given a limit, use a
2592 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2593 latter isn't right if USE_2_TAGS_FOR_INTS.
2594 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2595 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2597 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2599 * textprop.c (text_property_stickiness):
2600 Obey Vtext_property_default_nonsticky.
2601 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2602 * w32fns.c (syms_of_w32fns):
2603 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2605 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2607 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2608 This is more efficient than Ffile_directory_p and avoids a minor race.
2610 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2612 * buffer.c (Foverlay_put): Say what the return value is
2615 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2616 is a directory before asking whether to use the file name
2618 (barf_or_query_if_file_exists): Make the "File is a directory"
2619 error be more correct.
2621 * fns.c (Frequire): Remove the mention of the .gz files, since
2622 that's installation-specific, but keep the mention of
2623 `get-load-suffixes'.
2625 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2627 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2628 Report string overflow if the output is too long.
2630 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2632 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2633 (syms_of_gnutls): Remove duplicate DEFSYM for
2634 Qgnutls_bootprop_verify_hostname_error, an error for
2635 Qgnutls_bootprop_verify_error (which is no longer used).
2637 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2638 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2639 Also (re)move comments that are misplaced or no longer relevant.
2641 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2643 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2645 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2647 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2648 and background color parameters if they have been changed.
2650 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2652 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2654 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2656 * xsettings.c (SYSTEM_FONT): Define only when used.
2657 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2659 * keymap.c (access_keymap_1): Now static.
2661 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2663 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2664 leave any prefix arg for the up event (Bug#1586).
2666 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2668 * lread.c (syms_of_lread): Mention single symbols defined by
2669 `defvar' or `defconst' (bug#7154).
2671 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2672 (Frequire): Mention get-load-suffixes.
2674 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2676 * window.h (window): Remove clone_number slot.
2677 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2679 (make_parent_window, make_window, saved_window)
2680 (Fset_window_configuration, save_window_save): Don't deal with
2682 * buffer.c (Qclone_number): Remove declaration.
2683 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2685 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2687 Add multiple inheritance to keymaps.
2688 * keymap.c (Fmake_composed_keymap): New function.
2689 (Fset_keymap_parent): Simplify.
2690 (fix_submap_inheritance): Remove.
2691 (access_keymap_1): New function extracted from access_keymap to handle
2692 embedded parents and handle lists of maps.
2693 (access_keymap): Use it.
2694 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2695 (Fcopy_keymap): Handle embedded parents.
2696 (Fcommand_remapping, define_as_prefix): Simplify.
2697 (Fkey_binding): Simplify.
2698 (syms_of_keymap): Move minibuffer-local-completion-map,
2699 minibuffer-local-filename-completion-map,
2700 minibuffer-local-must-match-map, and
2701 minibuffer-local-filename-must-match-map to Elisp.
2702 (syms_of_keymap): Defsubr make-composed-keymap.
2703 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2704 (parse_menu_item): Trivial simplification.
2706 2011-07-01 Glenn Morris <rgm@gnu.org>
2708 * Makefile.in (SETTINGS_LIBS): Fix typo.
2710 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2712 * coding.c (Fencode_coding_string): Record the last coding system
2713 used, as the function doc string says (bug#8738).
2715 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2717 * xsettings.c (store_monospaced_changed): Take new font as arg and
2718 check for change against current_mono_font.
2719 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2720 (emacs_settings_constructor, emacs_settings_get_property)
2721 (emacs_settings_set_property, emacs_settings_class_init)
2722 (emacs_settings_init, gsettings_obj): Remove.
2723 (something_changedCB): New function for HAVE_GSETTINGS.
2724 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2725 with value as argument.
2726 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2727 g_settings_new (Bug#8967). Do not create gsettings_obj.
2728 Remove calls to g_settings_bind. Connect something_changedCB to
2731 * xgselect.c: Add defined (HAVE_GSETTINGS).
2732 (xgselect_initialize): Ditto.
2734 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2735 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2738 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2740 * eval.c (struct backtrace): Simplify and port the data structure.
2741 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2742 signed bit field, as this assumption is not portable and it makes
2743 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2744 "char debug_on_exit : 1" as this is not portable either; instead,
2745 use the portable "unsigned int debug_on_exit : 1". Remove unused
2746 member evalargs. Remove obsolete comments about cc bombing out.
2748 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2750 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2751 Let HAVE_GSETTINGS override HAVE_GCONF.
2752 (store_monospaced_changed): New function.
2753 (EMACS_SETTINGS): A new type derived from GObject to handle
2754 GSettings notifications.
2755 (emacs_settings_constructor, emacs_settings_get_property)
2756 (emacs_settings_set_property, emacs_settings_class_init):
2758 (gsettings_client, gsettings_obj): New variables.
2759 (GSETTINGS_SCHEMA): New define.
2760 (something_changedCB): Call store_monospaced_changed.
2761 (init_gsettings): New function.
2762 (xsettings_initialize): Call init_gsettings.
2763 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2766 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2769 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2771 * window.c (resize_root_window, grow_mini_window)
2772 (shrink_mini_window): Rename Qresize_root_window to
2773 Qwindow_resize_root_window and Qresize_root_window_vertically to
2774 Qwindow_resize_root_window_vertically.
2776 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2778 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2780 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2782 * makefile.w32-in: Redesign dependencies so they reflect more
2783 clearly which files are directly included by each source file,
2784 and not through other includes.
2786 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2788 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2789 (sort_overlays, overlay_strings): When an overlay's clone number
2790 matches the window's clone number process the overlay even if
2791 the overlay's window property doesn't match the current window.
2793 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2794 (Fwindow_hchild): Rename to Fwindow_left_child.
2795 (Fwindow_next): Rename to Fwindow_next_sibling.
2796 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2797 (resize_window_check): Rename to window_resize_check.
2798 (resize_window_apply): Rename to window_resize_apply.
2799 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2800 (Fdelete_other_windows_internal, resize_frame_windows)
2801 (Fsplit_window_internal, Fdelete_window_internal)
2802 (grow_mini_window, shrink_mini_window)
2803 (Fresize_mini_window_internal): Fix callers accordingly.
2805 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2807 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2808 (emacs_fixed_set_min_size): Remove.
2809 (emacs_fixed_new): Take frame as argument.
2811 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2812 (_EmacsFixedPrivate): Remove minwidth/height.
2813 Add struct frame *f.
2814 (emacs_fixed_init): Initialize priv->f.
2815 (get_parent_class, emacs_fixed_set_min_size): Remove.
2816 (emacs_fixed_new): Set priv->f to argument.
2817 (emacs_fixed_get_preferred_width)
2818 (emacs_fixed_get_preferred_height): Use min_width/height from
2819 frames size_hint to set minimum and natural (Bug#8919).
2820 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2821 and use min_width/height from frames size_hint to set
2822 min_width/height (Bug#8919).
2824 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2825 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2828 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2830 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2831 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2834 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2836 * process.c (wait_reading_process_output): Bypass select if
2837 waiting for a cell while ignoring keyboard input, and input is
2838 pending. Suggested by Jan Djärv (Bug#8869).
2840 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2842 Use gnulib's dup2 module instead of rolling our own.
2843 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2845 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2847 * dispnew.c (scrolling_window): Before scrolling, turn off a
2848 mouse-highlight in the window being scrolled.
2850 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2852 Move DEFSYM to lisp.h and use everywhere.
2854 * character.h (DEFSYM): Move declaration...
2855 * lisp.h (DEFSYM): ...here.
2861 * w32select.c: Don't include character.h.
2863 * alloc.c (syms_of_alloc):
2864 * buffer.c (syms_of_buffer):
2865 * bytecode.c (syms_of_bytecode):
2866 * callint.c (syms_of_callint):
2867 * casefiddle.c (syms_of_casefiddle):
2868 * casetab.c (init_casetab_once):
2869 * category.c (init_category_once, syms_of_category):
2870 * ccl.c (syms_of_ccl):
2871 * cmds.c (syms_of_cmds):
2872 * composite.c (syms_of_composite):
2873 * dbusbind.c (syms_of_dbusbind):
2874 * dired.c (syms_of_dired):
2875 * dispnew.c (syms_of_display):
2876 * doc.c (syms_of_doc):
2877 * editfns.c (syms_of_editfns):
2878 * emacs.c (syms_of_emacs):
2879 * eval.c (syms_of_eval):
2880 * fileio.c (syms_of_fileio):
2881 * fns.c (syms_of_fns):
2882 * frame.c (syms_of_frame):
2883 * fringe.c (syms_of_fringe):
2884 * insdel.c (syms_of_insdel):
2885 * keymap.c (syms_of_keymap):
2886 * lread.c (init_obarray, syms_of_lread):
2887 * macros.c (syms_of_macros):
2888 * msdos.c (syms_of_msdos):
2889 * print.c (syms_of_print):
2890 * process.c (syms_of_process):
2891 * search.c (syms_of_search):
2892 * sound.c (syms_of_sound):
2893 * syntax.c (init_syntax_once, syms_of_syntax):
2894 * terminal.c (syms_of_terminal):
2895 * textprop.c (syms_of_textprop):
2896 * undo.c (syms_of_undo):
2897 * w32.c (globals_of_w32):
2898 * window.c (syms_of_window):
2899 * xdisp.c (syms_of_xdisp):
2900 * xfaces.c (syms_of_xfaces):
2901 * xfns.c (syms_of_xfns):
2902 * xmenu.c (syms_of_xmenu):
2903 * xsettings.c (syms_of_xsettings):
2904 * xterm.c (syms_of_xterm): Use DEFSYM.
2906 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2908 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2910 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2912 Integer and buffer overflow fixes (Bug#8873).
2914 * print.c (printchar, strout): Check for string overflow.
2915 (PRINTPREPARE, printchar, strout):
2916 Don't set size unless allocation succeeds.
2918 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2919 for sizes. Check for string overflow more accurately.
2920 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2922 * macros.c: Integer and buffer overflow fixes.
2923 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2924 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2925 Use ptrdiff_t, not int, for sizes.
2926 Don't increment bufsize until after realloc succeeds.
2927 Check for size-calculation overflow.
2928 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2930 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2932 * lread.c: Integer overflow fixes.
2933 (read_integer): Radix is now EMACS_INT, not int,
2934 to improve quality of diagnostics for out-of-range radices.
2935 Calculate buffer size correctly for out-of-range radices.
2936 (read1): Check for integer overflow in radices, and in
2937 read-circle numbers.
2938 (read_escape): Avoid int overflow.
2939 (Fload, openp, read_buffer_size, read1)
2940 (substitute_object_recurse, read_vector, read_list, map_obarray):
2941 Use ptrdiff_t, not int, for sizes.
2942 (read1): Use EMACS_INT, not int, for sizes.
2943 Check for size overflow.
2945 * image.c (cache_image): Check for size arithmetic overflow.
2947 * lread.c: Integer overflow issues.
2948 (saved_doc_string_size, saved_doc_string_length)
2949 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2950 Now ptrdiff_t, not int.
2951 (read1): Don't assume doc string length fits in int. Check for
2952 out-of-range doc string lengths.
2953 (read_list): Don't assume file position fits in int.
2954 (read_escape): Check for hex character overflow.
2956 2011-06-22 Leo Liu <sdl.web@gmail.com>
2958 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2959 Move to minibuffer.el.
2961 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2963 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2964 The following patches are for when GLYPH_DEBUG && !XASSERT.
2965 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2966 * dispnew.c (flush_stdout):
2967 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2968 Mark as externally visible.
2969 * dispnew.c (check_window_matrix_pointers): Now static.
2970 * dispnew.c (window_to_frame_vpos):
2971 * xfns.c (unwind_create_frame):
2972 * xterm.c (x_check_font): Remove unused local.
2973 * scroll.c (CHECK_BOUNDS):
2974 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2975 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2976 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2977 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2978 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2980 (debug_method_add): Use va_list and vsprintf rather than relying
2981 on undefined behavior with wrong number of arguments.
2982 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2983 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2984 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2985 since we're not interested in debugging glyphs with old libraries.
2986 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2987 GCC 4.6.0's static checking.
2989 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2991 Integer overflow and signedness fixes (Bug#8873).
2992 A few related buffer overrun fixes, too.
2994 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2996 * dispextern.h (struct face.stipple):
2997 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2998 (x_bitmap_mask, x_allocate_bitmap_record)
2999 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3000 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3001 (x_create_bitmap_from_xpm_data):
3002 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3003 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3005 * xfaces.c (load_pixmap):
3006 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3007 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3008 (.bitmaps_last, struct x_output.icon_bitmap):
3009 Use ptrdiff_t, not int, for bitmap indexes.
3010 (x_allocate_bitmap_record): Check for size overflow.
3011 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3013 Use ptrdiff_t, not int, for overlay counts.
3014 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3015 * editfns.c (overlays_around, get_pos_property):
3016 * textprop.c (get_char_property_and_overlay):
3017 * xdisp.c (next_overlay_change, note_mouse_highlight):
3018 * xfaces.c (face_at_buffer_position):
3019 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3020 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3021 (Fnext_overlay_change, Fprevious_overlay_change)
3022 (mouse_face_overlay_overlaps, Foverlays_in):
3023 Use ptrdiff_t, not int, for sizes.
3024 (overlays_at, overlays_in): Check for size-calculation overflow.
3026 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3028 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3029 (x_session_initialize): Do not assume string length fits in int.
3031 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3032 This is unlikely, but can occur if DPI is outlandish.
3034 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3035 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3037 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3038 * xrdb.c (magic_file_p, search_magic_path):
3039 Omit last arg SUFFIX; it was always 0. All callers changed.
3040 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3042 * xfont.c (xfont_match): Avoid need for strlen.
3044 * xfns.c: Don't assume strlen fits in int.
3045 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3047 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3048 not unsigned long, as we prefer signed integers. All callers changed.
3049 Detect integer overflow in repeat count.
3050 (message_dolog): Don't assume print length fits in 39 bytes.
3051 (display_mode_element): Don't assume strlen fits in int.
3053 * termcap.c: Don't assume sizes fit in int and never overflow.
3054 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3055 (gobble_line): Check for size-calculation overflow.
3057 * minibuf.c (Fread_buffer):
3058 * lread.c (intern, intern_c_string):
3059 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3060 Don't assume string length fits in int.
3062 * keyboard.c (parse_tool_bar_item):
3063 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3065 * font.c: Don't assume string length fits in int.
3066 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3067 Use ptrdiff_t, not int.
3068 (font_intern_prop): Don't assume string length fits in int.
3069 Don't assume integer property fits in fixnum.
3070 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3072 * filelock.c: Fix some buffer overrun and integer overflow issues.
3073 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3074 Reformulate so as not to need the command string.
3075 Invoke gzip -cd rather than gunzip, as it's more portable.
3076 (lock_info_type, lock_file_1, lock_file):
3077 Don't assume pid_t and time_t fit in unsigned long.
3078 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3079 (current_lock_owner): Prefer signed type for sizes.
3080 Use memcpy, not strncpy, where memcpy is what is really wanted.
3081 Don't assume (via atoi) that time_t and pid_t fit in int.
3082 Check for time_t and/or pid_t out of range, e.g., via a network share.
3083 Don't alloca where an auto var works fine.
3085 * fileio.c: Fix some integer overflow issues.
3086 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3087 Don't assume string length fits in int.
3088 (directory_file_name): Don't assume string length fits in long.
3089 (make_temp_name): Don't assume pid fits in int, or that its print
3090 length is less than 20.
3092 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3094 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3096 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3098 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3099 We prefer signed integers, even for size calculations.
3101 * emacs.c: Don't assume string length fits in 'int'.
3102 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3103 (main): Don't invoke strlen when not needed.
3105 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3106 (XD_DEBUG_MESSAGE): Don't waste a byte.
3108 * callproc.c (getenv_internal_1, getenv_internal)
3110 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3112 * lread.c (invalid_syntax): Omit length argument.
3113 All uses changed. This doesn't fix a bug, but it simplifies the
3114 code away from its former Hollerith-constant appearance, and it's
3115 one less 'int' to worry about when looking at integer-overflow issues.
3116 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3118 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3119 This didn't break anything, but it didn't help either.
3120 It's confusing to put a bogus integer in a place where the actual
3121 value does not matter.
3122 (LIST_END_P): Remove unused macro and its bogus comment.
3123 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3125 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3126 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3128 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3129 We prefer signed types, and the value cannot exceed the EMACS_INT
3130 range anyway (because otherwise the length would not be representable).
3131 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3132 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3133 This avoids a GCC warning when WIDE_EMACS_INT.
3135 * indent.c (sane_tab_width): New function.
3136 (current_column, scan_for_column, Findent_to, position_indentation)
3137 (compute_motion): Use it. This is just for clarity.
3138 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3140 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3142 * lisp.h (lint_assume): New macro.
3143 * composite.c (composition_gstring_put_cache):
3144 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3146 * editfns.c, insdel.c:
3147 Omit unnecessary forward decls, to simplify future changes.
3149 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3151 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3153 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3154 Use much-faster test for byte-length change.
3155 Don't assume string byte-length fits in 'int'.
3156 Check that character arg fits in 'int'.
3157 (mapcar1): Declare byte as byte, for clarity.
3159 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3161 * fns.c (concat): Catch string overflow earlier.
3162 Do not rely on integer wraparound.
3164 * dispextern.h (struct it.overlay_strings_charpos)
3165 (struct it.selective): Now EMACS_INT, not int.
3166 * xdisp.c (forward_to_next_line_start)
3167 (back_to_previous_visible_line_start)
3168 (reseat_at_next_visible_line_start, next_element_from_buffer):
3169 Don't arbitrarily truncate the value of 'selective' to int.
3171 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3173 * composite.c: Don't truncate sizes to 'int'.
3174 (composition_gstring_p, composition_reseat_it)
3175 (composition_adjust_point): Use EMACS_INT, not int.
3176 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3177 not EMACS_UINT, for indexes.
3179 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3181 * buffer.c: Include <verify.h>.
3182 (struct sortvec.priority, struct sortstr.priority):
3183 Now EMACS_INT, not int.
3184 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3185 (struct sortstr.size, record_overlay_string)
3186 (struct sortstrlist.size, struct sortlist.used):
3187 Don't truncate size to int.
3188 (record_overlay_string): Check for size-calculation overflow.
3189 (init_buffer_once): Check at compile-time, not run-time.
3191 2011-06-22 Jim Meyering <meyering@redhat.com>
3193 Don't leak an XBM-image-sized buffer
3194 * image.c (xbm_load): Free the image buffer after using it.
3196 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3199 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3200 that Sun C diagnosed.
3201 * fns.c (secure_hash): Fix pointer signedness issue.
3202 * intervals.c (static_offset_intervals): New function.
3203 (offset_intervals): Use it.
3205 2011-06-21 Leo Liu <sdl.web@gmail.com>
3208 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3211 * fns.c (secure_hash): Rename from crypto_hash_function and change
3212 the first arg to accept symbols.
3213 (Fsecure_hash): New primitive.
3214 (syms_of_fns): New symbols.
3216 2011-06-20 Deniz Dogan <deniz@dogan.se>
3218 * process.c (Fset_process_buffer): Clarify return value in
3221 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3223 * dispnew.c (add_window_display_history): Use BVAR.
3225 * xdisp.c (debug_method_add): Use BVAR.
3226 (check_window_end, dump_glyph_matrix, dump_glyph)
3227 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3229 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3232 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3233 check till after the cache is created in init_frame_faces.
3235 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3237 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3239 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3241 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3242 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3243 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3245 Improve buffer-overflow checking (Bug#8873).
3246 * fileio.c (Finsert_file_contents):
3247 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3248 Remove the old (too-loose) buffer overflow checks.
3249 They weren't needed, since make_gap checks for buffer overflow.
3250 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3251 The old code merely checked for Emacs fixnum overflow, and relied
3252 on undefined (wraparound) behavior. The new code avoids undefined
3253 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3255 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3256 Tune. Don't use wider integers than needed. Don't use alloca.
3257 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3259 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3261 * insdel.c, lisp.h (buffer_overflow): New function.
3262 (insert_from_buffer_1, replace_range, replace_range_2):
3263 * insdel.c (make_gap_larger):
3264 * editfns.c (Finsert_char):
3265 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3267 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3269 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3271 Integer overflow and signedness fixes (Bug#8873).
3273 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3274 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3276 * fileio.c: Don't assume EMACS_INT fits in off_t.
3277 (emacs_lseek): New static function.
3278 (Finsert_file_contents, Fwrite_region): Use it.
3279 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3281 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3283 * fns.c: Don't overflow int when computing a list length.
3284 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3285 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3286 truncation on 64-bit hosts. Check for QUIT every
3287 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3288 faster and is responsive enough.
3289 (Flength): Report an error instead of overflowing an integer.
3290 (Fsafe_length): Return a float if the value is not representable
3291 as a fixnum. This shouldn't happen except in contrived situations.
3292 (Fnthcdr, Fsort): Don't assume list length fits in int.
3293 (Fcopy_sequence): Don't assume vector length fits in int.
3295 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3296 (header_size, word_size): New constants.
3297 (allocate_vectorlike): Don't check size overflow here.
3298 (allocate_vector): Check it here instead, since this is the only
3299 caller of allocate_vectorlike that could cause overflow.
3300 Check that the new vector's length is representable as a fixnum.
3302 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3303 The previous code was bogus. For example, next_almost_prime (32)
3304 returned 39, which is undesirable as it is a multiple of 3; and
3305 next_almost_prime (24) returned 25, which is a multiple of 5 so
3306 why was the code bothering to check for multiples of 7?
3308 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3310 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3312 Variadic C functions now count arguments with ptrdiff_t.
3313 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3314 Back then I didn't know that the Emacs coding style prefers signed int.
3315 Also, in the meantime I found a few more instances where arguments
3316 were being counted with int, which may truncate counts on 64-bit
3317 machines, or EMACS_INT, which may be unnecessarily wide.
3318 * lisp.h (struct Lisp_Subr.function.aMANY)
3319 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3320 Arg counts are now ptrdiff_t, not size_t.
3321 All variadic functions and their callers changed accordingly.
3322 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3323 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3324 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3325 * callint.c (Fcall_interactively): Check arg count for overflow,
3326 to avoid potential buffer overrun. Use signed char, not 'int',
3327 for 'varies' array, so that we needn't bother to check its size
3328 calculation for overflow.
3329 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3330 * eval.c (apply_lambda):
3331 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3332 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3333 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3335 * callint.c (Fcall_interactively): Don't use index var as event count.
3337 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3338 * mem-limits.h (SIZE): Remove; no longer used.
3340 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3342 Remove unnecessary casts.
3343 * xterm.c (x_term_init):
3344 * xfns.c (x_set_border_pixel):
3345 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3346 These aren't needed now that we assume ANSI C.
3348 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3349 It's more likely to cause problems (due to unsigned overflow)
3352 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3354 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3356 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3358 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3360 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3362 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3364 GLYPH_CODE_FACE returns EMACS_INT, not int.
3365 * dispextern.h (merge_faces):
3366 * xfaces.c (merge_faces):
3367 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3368 Don't assume EMACS_INT fits in int.
3370 * character.h (CHAR_VALID_P): Remove unused parameter.
3371 * fontset.c, lisp.h, xdisp.c: All uses changed.
3373 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3375 * fns.c (concat): Minor tuning based on overflow analysis.
3376 This doesn't fix any bugs. Use int to hold character, instead
3377 of constantly refetching from Emacs object. Use XFASTINT, not
3378 XINT, for value known to be a character. Don't bother comparing
3379 a single byte to 0400, as it's always less.
3381 * floatfns.c (Fexpt):
3382 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3384 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3387 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3389 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3390 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3391 incorrectly succeed when S was a string, because 4294967386 was
3392 truncated before it was used.
3394 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3395 Otherwise, an out-of-range integer could cause undefined behavior
3398 * composite.c: Use int, not EMACS_INT, for characters.
3399 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3400 EMACS_INT, for values that are known to be in character range.
3401 This doesn't fix any bugs but is the usual style inside Emacs and
3402 may generate better code on 32-bit machines.
3404 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3405 This is for reasons similar to the recent CHAR_STRING fix.
3406 * charset.c (Fencode_char): Check that character arg is actually
3407 a character. Pass an int to ENCODE_CHAR.
3408 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3409 wider than 'int', as a compile-time check to prevent future regressions
3412 * character.c (char_string): Remove unnecessary casts.
3414 Make sure a 64-bit char is never passed to CHAR_STRING.
3415 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3416 by silently ignoring the top 32 bits, allowing some values
3417 that were far too large to be valid characters.
3418 * character.h: Include <verify.h>.
3419 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3420 arguments are no wider than unsigned, as a compile-time check
3421 to prevent future regressions in this area.
3423 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3424 (Fsubst_char_in_region):
3426 * xdisp.c (decode_mode_spec_coding):
3427 Adjust to CHAR_STRING's new requirement.
3428 * editfns.c (Finsert_char, Fsubst_char_in_region):
3429 * fns.c (concat): Check that character args are actually
3430 characters. Without this test, these functions did the wrong
3431 thing with wildly out-of-range values on 64-bit hosts.
3433 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3434 These casts should not be needed on 32-bit hosts, either.
3435 * keyboard.c (read_char):
3436 * lread.c (Fload): Remove casts to unsigned.
3438 * lisp.h (UNSIGNED_CMP): New macro.
3439 This fixes comparison bugs on 64-bit hosts.
3440 (ASCII_CHAR_P): Use it.
3441 * casefiddle.c (casify_object):
3442 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3443 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3444 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3445 * dispextern.h (FACE_FROM_ID):
3446 * keyboard.c (read_char): Use UNSIGNED_CMP.
3448 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3449 not to EMACS_INT, to avoid GCC warning.
3451 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3453 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3454 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3455 isn't needed on 32-bit machines.
3457 * buffer.c (Fgenerate_new_buffer_name):
3458 Use EMACS_INT for count, not int.
3459 (advance_to_char_boundary): Return EMACS_INT, not int.
3461 * data.c (Qcompiled_function): Now static.
3463 * window.c (window_body_lines): Now static.
3465 * image.c (gif_load): Rename local to avoid shadowing.
3467 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3468 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3469 * alloc.c (make_save_value): Integer argument is now of type
3471 (mark_object): Use ptrdiff_t, not int.
3472 * lisp.h (pD): New macro.
3473 * print.c (print_object): Use it.
3475 * alloc.c: Use EMACS_INT, not int, to count objects.
3476 (total_conses, total_markers, total_symbols, total_vector_size)
3477 (total_free_conses, total_free_markers, total_free_symbols)
3478 (total_free_floats, total_floats, total_free_intervals)
3479 (total_intervals, total_strings, total_free_strings):
3480 Now EMACS_INT, not int. All uses changed.
3481 (Fgarbage_collect): Compute overall total using a double, so that
3482 integer overflow is less likely to be a problem. Check for overflow
3483 when converting back to an integer.
3484 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3485 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3486 These were 'int' variables that could overflow on 64-bit hosts;
3487 they were never used, so remove them instead of repairing them.
3488 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3489 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3490 Previously, this ceilinged at INT_MAX, but that doesn't work on
3492 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3494 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3495 (allocate_vectorlike): Check for ptrdiff_t overflow.
3496 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3497 when a (possibly-narrower) signed value would do just as well.
3498 We prefer using signed arithmetic, to avoid comparison confusion.
3500 * alloc.c: Catch some string size overflows that we were missing.
3501 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3502 for convenience in STRING_BYTES_MAX.
3503 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3504 The definition here is exact; the one in lisp.h was approximate.
3505 (allocate_string_data): Check for string overflow. This catches
3506 some instances we weren't catching before. Also, it catches
3507 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3508 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3509 and ptrdiff_t and EMACS_INT are both 64 bits.
3511 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3512 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3513 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3515 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3517 * alloc.c (Fmake_string): Check for out-of-range init.
3519 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3521 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3523 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3525 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3526 xg_get_default_scrollbar_width.
3528 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3529 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3530 (style_changed_cb): Call update_theme_scrollbar_width and call
3531 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3532 all frames (Bug#8505).
3533 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3534 Call gtk_window_set_resizable if HAVE_GTK3.
3535 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3536 and height if HAVE_GTK3 (Bug#8505).
3537 (scroll_bar_width_for_theme): New variable.
3538 (update_theme_scrollbar_width): New function.
3539 (xg_get_default_scrollbar_width): Move code to
3540 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3541 (xg_initialize): Call update_theme_scrollbar_width.
3543 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3545 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3547 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3549 * frame.c (make_frame): Call other_buffer_safely instead of
3552 * window.c (temp_output_buffer_show): Call display_buffer with
3553 second argument Vtemp_buffer_show_specifiers and reset latter
3554 immediately after the call.
3555 (Vtemp_buffer_show_specifiers): New variable.
3556 (auto_window_vscroll_p, next_screen_context_lines)
3557 (Vscroll_preserve_screen_position): Remove leading asterisks from
3560 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3562 Fix minor problems found by GCC 4.6.0 static checking.
3563 * buffer.c (Qclone_number): Remove for now, as it's unused.
3564 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3565 (record_buffer): Remove unused local.
3566 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3567 (set_frame_buffer_list): Remove; unused.
3568 * frame.h (other_visible_frames): Remove decl.
3569 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3570 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3571 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3573 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3574 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3575 Define only if HAVE_GPM.
3576 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3577 (update_hints_inhibit): Remove; never set. All uses removed.
3578 * widgetprv.h (emacsFrameClassRec): Remove decl.
3579 * window.c (delete_deletable_window): Now returns void, since it
3580 wasn't returning anything.
3581 (compare_window_configurations): Remove unused locals.
3582 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3583 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3584 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3585 the same widths as pointers. This follows up on the 2011-05-06 patch.
3586 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3587 * xterm.h: Likewise.
3588 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3590 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3592 * makefile.w32-in: Update dependencies.
3593 (LISP_H): Add lib/intprops.h.
3595 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3597 * image.c (gif_load): Add animation frame delay to the metadata.
3598 (syms_of_image): Use DEFSYM. New symbol `delay'.
3600 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3602 * window.c (delete_deletable_window): Re-add.
3603 (Fset_window_configuration): Rewrite to handle dead buffers and
3604 consequently deletable windows.
3605 (window_tree, Fwindow_tree): Remove. Supply functionality in
3607 (compare_window_configurations): Simplify code.
3609 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3611 * image.c (imagemagick_load_image): Fix type mismatch.
3612 (Fimagemagick_types): Likewise.
3614 * window.h (replace_buffer_in_windows): Declare.
3616 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3618 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3619 Qclone_number. Remove external declaration of Qdelete_window.
3620 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3622 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3623 Run Qbuffer_list_update_hook if allowed.
3624 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3625 buffer list implementation.
3626 (other_buffer_safely): New function.
3627 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3628 calls to replace_buffer_in_windows and
3629 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3631 (record_buffer): Inhibit quitting and rewrite using quittable
3632 functions. Run Qbuffer_list_update_hook if allowed.
3633 (Frecord_buffer, Funrecord_buffer): New functions.
3634 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3635 Move switch-to-buffer to window.el.
3636 (bury-buffer): Move to window.el.
3637 (Vbuffer_list_update_hook): New variable.
3639 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3642 * window.h (resize_frame_windows): Move up in code.
3643 (Fwindow_frame): Remove EXFUN.
3644 (replace_buffer_in_all_windows): Remove prototype.
3645 (replace_buffer_in_windows_safely): Add prototype.
3647 * window.c: Declare Qdelete_window static again. Move down
3648 declaration of select_count.
3649 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3650 (Fother_window): Move to window.el.
3651 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3652 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3653 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3655 (replace_buffer_in_windows): Implement by calling
3656 Qreplace_buffer_in_windows.
3657 (replace_buffer_in_all_windows): Remove with some functionality
3658 moved into replace_buffer_in_windows_safely.
3659 (replace_buffer_in_windows_safely): New function.
3660 (select_window_norecord, select_frame_norecord): Move in front
3661 of run_window_configuration_change_hook. Remove now obsolete
3663 (Fset_window_buffer): Rewrite doc-string.
3664 Call Qrecord_window_buffer.
3665 (keys_of_window): Move binding for other-window to window.el.
3667 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3669 * dispextern.h (struct image): Replace data member, whose int_val
3670 and ptr_val fields were not used by anything, with a single
3673 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3674 (gif_clear_image, gif_load, imagemagick_load_image)
3675 (gs_clear_image, gs_load): Callers changed.
3677 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3679 * buffer.h: Include <time.h>, for time_t.
3680 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3682 Fix minor problems found by static checking.
3684 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3686 Make identifiers static if they are not used in other modules.
3687 * data.c (Qcompiled_function, Qframe, Qvector):
3688 * image.c (QimageMagick, Qsvg):
3689 * minibuf.c (Qmetadata):
3690 * window.c (resize_window_check, resize_root_window): Now static.
3691 * window.h (resize_window_check, resize_root_window): Remove decls.
3693 * window.c (window_deletion_count, delete_deletable_window):
3695 (window_body_lines): Now static.
3696 (Fdelete_other_windows_internal): Mark vars as initialized.
3697 Make sure 'resize_failed' is initialized.
3698 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3699 (resize_window_apply): Remove unused local.
3700 * window.h (delete_deletable_window): Remove decl.
3702 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3703 (imagemagick_load_image): Fix pointer signedness problem by changing
3704 last arg from unsigned char * to char *. All uses changed.
3705 Also, fix a local for similar reasons.
3706 Remove unused locals. Remove locals to avoid shadowing.
3707 (fn_rsvg_handle_free): Remove; unused.
3708 (svg_load, svg_load_image): Fix pointer signedness problem.
3709 (imagemagick_load_image): Don't use garbage pointer image_wand.
3711 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3713 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3715 * image.c (gif_load): Fix omitted cast error introduced by
3718 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3720 * window.h (resize_proportionally, orig_total_lines)
3721 (orig_top_line): Remove from window structure.
3722 (set_window_height, set_window_width, change_window_heights)
3723 (Fdelete_window): Remove prototypes.
3724 (resize_frame_windows): Remove duplicate declaration.
3726 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3728 * window.h (resize_frame_windows, resize_window_check)
3729 (delete_deletable_window, resize_root_window)
3730 (resize_frame_windows): Declare prototypes.
3732 * window.c (resize_window_apply): Make definition be "static" to
3733 match the prototype.
3735 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3737 * window.c: Remove declarations of Qwindow_size_fixed,
3738 window_min_size_1, window_min_size_2, window_min_size,
3739 size_window, window_fixed_size_p, enlarge_window, delete_window.
3740 Remove static from declaration of Qdelete_window, it's
3741 temporarily needed by Fbury_buffer.
3742 (replace_window): Don't assign orig_top_line and
3744 (Fdelete_window, delete_window): Remove. Window deletion is
3745 handled by window.el.
3746 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3747 Replace Fdelete_window calls with calls to Qdelete_window.
3748 (Fdelete_other_windows): Remove. Deleting other windows is
3749 handled by window.el.
3750 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3751 handled in window.el.
3752 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3753 Window minimum sizes are handled in window.el.
3754 (shrink_windows, size_window, set_window_height)
3755 (set_window_width, change_window_heights, window_height)
3756 (window_width, CURBEG, CURSIZE, enlarge_window)
3757 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3758 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3759 handled in window.el.
3760 (make_dummy_parent): Rename to make_parent_window and give it a
3761 second argument horflag.
3762 (make_window): Don't set resize_proportionally any more.
3763 (Fsplit_window): Remove. Windows are split in window.el.
3764 (save_restore_action, save_restore_orig_size)
3765 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3766 Resize mini windows in window.el.
3767 (grow_mini_window, shrink_mini_window): Implement by calling
3768 Qresize_root_window_vertically, resize_window_check and
3769 resize_window_apply.
3770 (saved_window, Fset_window_configuration, save_window_save):
3771 Do not handle orig_top_line, orig_total_lines, and
3772 resize_proportionally.
3773 (window_min_height, window_min_width): Move to window.el.
3774 (keys_of_window): Move bindings for delete-other-windows,
3775 split-window, delete-window and enlarge-window to window.el.
3777 * buffer.c: Temporarily extern Qdelete_window.
3778 (Fbury_buffer): Temporarily call Qdelete_window instead of
3779 Fdelete_window (Fbury_buffer will move to window.el soon).
3781 * frame.c (set_menu_bar_lines_1): Remove code handling
3782 orig_top_line and orig_total_lines.
3784 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3785 set_window_height but set heights directly.
3786 (change_frame_size_1): Use resize_frame_windows.
3788 * xdisp.c (init_xdisp): Don't use set_window_height but set
3791 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3792 Use resize_frame_windows instead of change_window_heights and run
3793 run_window_configuration_change_hook.
3795 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3796 instead of change_window_heights and run
3797 run_window_configuration_change_hook.
3799 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3801 * window.c (replace_window): Rename second argument REPLACEMENT to
3802 NEW. New third argument SETFLAG. Rewrite.
3803 (delete_window, make_dummy_parent): Call replace_window with
3805 (window_list_1): Move down in code.
3806 (run_window_configuration_change_hook): Move set_buffer part
3807 before select_frame_norecord part in order to unwind correctly.
3808 Rename count1 to count.
3809 (recombine_windows, delete_deletable_window, resize_root_window)
3810 (Fdelete_other_windows_internal)
3811 (Frun_window_configuration_change_hook, make_parent_window)
3812 (resize_window_check, resize_window_apply, Fresize_window_apply)
3813 (resize_frame_windows, Fsplit_window_internal)
3814 (Fdelete_window_internal, Fresize_mini_window_internal):
3816 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3818 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3820 * window.h (window): Add some new members to window structure -
3821 normal_lines, normal_cols, new_total, new_normal, clone_number,
3822 splits, nest, prev_buffers, next_buffers.
3823 (WINDOW_TOTAL_SIZE): Move here from window.c.
3824 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3826 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3828 (make_dummy_parent): Set new members of windows structure.
3829 (make_window): Move down in code. Handle new members of window
3831 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3832 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3833 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3834 (Fset_window_prev_buffers, Fwindow_next_buffers)
3835 (Fset_window_next_buffers, Fset_window_clone_number):
3837 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3838 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3840 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3841 Argument WINDOW can be now internal window too.
3842 (Fwindow_use_time): Move up in code.
3843 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3845 (Fset_window_configuration, saved_window)
3846 (Fcurrent_window_configuration, save_window_save): Handle new
3847 members of window structure.
3848 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3849 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3850 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3851 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3852 Qget_mru_window, Qresize_root_window,
3853 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3854 Qauto_buffer_name; staticpro them.
3856 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3858 * window.c (Fwindow_total_size, Fwindow_left_column)
3859 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3860 (Fwindow_list_1): New functions.
3861 (window_box_text_cols): Replace with window_body_cols.
3862 (Fwindow_width, Fscroll_left, Fscroll_right):
3863 Use window_body_cols instead of window_box_text_cols.
3864 (delete_window, Fset_window_configuration):
3865 Call delete_all_subwindows with window as argument.
3866 (delete_all_subwindows): Take a window as argument and not a
3868 (window_loop): Remove handling of GET_LRU_WINDOW and
3870 (Fget_lru_window, Fget_largest_window): Move to window.el.
3872 * window.h: Extern window_body_cols instead of
3873 window_box_text_cols. delete_all_subwindows now takes a
3874 Lisp_Object as argument.
3876 * indent.c (compute_motion, Fcompute_motion):
3877 Use window_body_cols instead of window_box_text_cols.
3879 * frame.c (delete_frame): Call delete_all_subwindows with root
3882 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3884 * fns.c (Fputhash): Document return value.
3886 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3888 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3890 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3892 Cons<->int and similar integer overflow fixes (Bug#8794).
3894 Check for overflow when converting integer to cons and back.
3895 * charset.c (Fdefine_charset_internal, Fdecode_char):
3896 Use cons_to_unsigned to catch overflow.
3897 (Fencode_char): Use INTEGER_TO_CONS.
3898 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3899 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3900 * data.c (long_to_cons, cons_to_long): Remove.
3901 (cons_to_unsigned, cons_to_signed): New functions.
3902 These signal an error for invalid or out-of-range values.
3903 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3904 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3905 * font.c (Ffont_variation_glyphs):
3906 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3907 * lisp.h: Include <intprops.h>.
3908 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3909 (cons_to_signed, cons_to_unsigned): New decls.
3910 (long_to_cons, cons_to_long): Remove decls.
3911 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3912 (Fprimitive_undo): Use CONS_TO_INTEGER.
3913 * xfns.c (Fx_window_property): Likewise.
3914 * xselect.c: Include <limits.h>.
3915 (x_own_selection, selection_data_to_lisp_data):
3916 Use INTEGER_TO_CONS.
3917 (x_handle_selection_request, x_handle_selection_clear)
3918 (x_get_foreign_selection, Fx_disown_selection_internal)
3919 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3920 (lisp_data_to_selection_data): Use cons_to_unsigned.
3921 (x_fill_property_data): Use cons_to_signed.
3922 Report values out of range.
3924 Check for buffer and string overflow more precisely.
3925 * buffer.h (BUF_BYTES_MAX): New macro.
3926 * lisp.h (STRING_BYTES_MAX): New macro.
3927 * alloc.c (Fmake_string):
3928 * character.c (string_escape_byte8):
3929 * coding.c (coding_alloc_by_realloc):
3930 * doprnt.c (doprnt):
3931 * editfns.c (Fformat):
3933 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3934 since they may not be the same number.
3935 * editfns.c (Finsert_char):
3936 * fileio.c (Finsert_file_contents):
3937 Likewise for BUF_BYTES_MAX.
3939 * image.c: Use ptrdiff_t, not int, for sizes.
3940 (slurp_file): Switch from int to ptrdiff_t.
3942 (slurp_file): Check that file size fits in both size_t (for
3943 malloc) and ptrdiff_t (for sanity and safety).
3945 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3946 if b->modtime has its maximal value.
3948 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3950 Don't assume time_t can fit into int.
3951 * buffer.h (struct buffer.modtime): Now time_t, not int.
3952 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3953 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3955 Minor fixes for signed vs unsigned integers.
3956 * character.h (MAYBE_UNIFY_CHAR):
3957 * charset.c (maybe_unify_char):
3958 * keyboard.c (read_char, reorder_modifiers):
3959 XINT -> XFASTINT, since the integer must be nonnegative.
3960 * ftfont.c (ftfont_spec_pattern):
3961 * keymap.c (access_keymap, silly_event_symbol_error):
3962 XUINT -> XFASTINT, since the integer must be nonnegative.
3963 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3964 since it makes no difference and we prefer signed.
3965 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3966 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3969 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3971 * window.h (Fwindow_frame): Declare.
3973 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3975 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3976 (SPARE_MEMORY): Always define.
3977 (LARGE_REQUEST): Remove.
3978 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3980 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3982 * lisp.h: Move EXFUNS for Fframe_root_window,
3983 Fframe_first_window and Fset_frame_selected_window to window.h.
3985 * window.h: Move EXFUNS for Fframe_root_window,
3986 Fframe_first_window and Fset_frame_selected_window here from
3989 * frame.c (Fwindow_frame, Fframe_first_window)
3990 (Fframe_root_window, Fframe_selected_window)
3991 (Fset_frame_selected_window): Move to window.c.
3992 (Factive_minibuffer_window): Move to minibuf.c.
3993 (Fother_visible_frames_p): New function.
3995 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3997 * window.c (decode_window, decode_any_window): Move up in code.
3998 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3999 (inhibit_frame_unsplittable): Remove unused variable.
4000 (Fwindow_buffer): Move up and rewrite doc-string.
4001 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4002 (Fwindow_prev): New functions.
4003 (Fwindow_frame): Move here from frame.c. Accept any window as
4005 (Fframe_root_window, Fframe_first_window)
4006 (Fframe_selected_window): Move here from frame.c. Accept frame
4007 or arbitrary window as argument. Update doc-strings.
4008 (Fminibuffer_window): Move up in code.
4009 (Fwindow_minibuffer_p): Move up in code and simplify.
4010 (Fset_frame_selected_window): Move here from frame.c.
4012 (Fselected_window, select_window, Fselect_window): Move up in
4013 code. Minor doc-string fixes.
4015 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4017 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4018 Do not assume that spare memory exists; that assumption is valid
4019 only if SYSTEM_MALLOC.
4020 (LARGE_REQUEST): New macro, so that the issue of large requests
4021 is separated from the issue of spare memory.
4023 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4025 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4028 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4030 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4033 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4035 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4037 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4039 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4040 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4042 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
4044 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4046 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
4048 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4049 (x_clipboard_manager_save): Add return value.
4050 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4052 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4053 Obey Vx_select_enable_clipboard_manager. Catch errors in
4054 x_clipboard_manager_save (Bug#8779).
4055 (Vx_select_enable_clipboard_manager): New variable.
4056 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4058 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4060 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4062 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4064 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4065 in the current matrix if keep_current_p is non-zero.
4067 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4069 * bidi.c (bidi_level_of_next_char): Fix last change.
4071 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4073 Support bidi reordering of text covered by display properties.
4075 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4076 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4077 (bidi_cache_search, bidi_cache_iterator_state)
4078 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4079 (bidi_level_of_next_char, bidi_move_to_visually_next):
4080 Support character positions inside a run of characters covered by a
4082 (bidi_paragraph_init, bidi_resolve_explicit_1)
4083 (bidi_level_of_next_char): Call bidi_fetch_char and
4084 bidi_fetch_char_advance instead of FETCH_CHAR and
4086 (bidi_init_it): Initialize new members.
4087 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4089 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4090 instead of using explicit *_CHAR codes.
4091 (bidi_resolve_explicit, bidi_resolve_weak):
4092 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4093 bidirectional text is supported only in multibyte buffers.
4094 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4095 it to initialize the frame_window_p member of struct bidi_it.
4096 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4097 (bidi_resolve_explicit, bidi_resolve_weak)
4098 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4099 bidi_it->nchars is non-positive.
4100 (bidi_level_of_next_char): Don't try to lookup the cache for the
4101 next/previous character if nothing is cached there yet, or if we
4102 were just reseat()'ed to a new position.
4104 * xdisp.c (set_cursor_from_row): Set start and stop points
4105 according to the row's direction when priming the loop that looks
4106 for the glyph on which to display cursor.
4107 (single_display_spec_intangible_p): Function deleted.
4108 (display_prop_intangible_p): Reimplement to call
4109 handle_display_spec instead of single_display_spec_intangible_p.
4110 Accept 3 additional arguments needed by handle_display_spec.
4111 This fixes incorrect cursor motion across display property with complex
4112 values: lists, `(when COND...)' forms, etc.
4113 (single_display_spec_string_p): Support property values that are
4114 lists with the argument STRING its top-level element.
4115 (display_prop_string_p): Fix the condition for processing a
4116 property that is a list to be consistent with handle_display_spec.
4117 (handle_display_spec): New function, refactored from the
4118 last portion of handle_display_prop.
4119 (compute_display_string_pos): Accept additional argument
4120 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4121 value of a `display' property is a "replacing spec".
4122 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4123 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4124 the display property, but just return a value indicating whether
4125 the display property will replace the characters it covers.
4126 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4127 frame_window_p members of struct bidi_it.
4128 (compute_display_string_pos, compute_display_string_end):
4130 (push_it): Accept second argument POSITION, where pop_it should
4131 jump to continue iteration.
4132 (reseat_1): Initialize bidi_it.disp_pos.
4134 * keyboard.c (adjust_point_for_property): Adjust the call to
4135 display_prop_intangible_p to its new signature.
4137 * dispextern.h (struct bidi_it): New member frame_window_p.
4138 (bidi_init_it): Update prototypes.
4139 (display_prop_intangible_p): Update prototype.
4140 (compute_display_string_pos, compute_display_string_end):
4142 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4145 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4147 Malloc failure behavior now depends on size of allocation.
4148 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4149 * lisp.h: Change signatures accordingly.
4150 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4151 All callers changed. (Bug#8762)
4153 * gnutls.c: Use Emacs's memory allocators.
4154 Without this change, the gnutls library would invoke malloc etc.
4155 directly, which causes problems on non-SYNC_INPUT hosts, and which
4156 runs afoul of improving memory_full behavior. (Bug#8761)
4157 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4158 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4159 xfree instead of the default malloc, realloc, free.
4160 (Fgnutls_boot): No need to check for memory allocation failure,
4161 since xmalloc does that for us.
4163 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4164 * category.c (hash_get_category_set):
4165 * ccl.c (ccl_driver):
4166 * charset.c (Fdefine_charset_internal):
4167 * charset.h (struct charset.hash_index):
4168 * composite.c (get_composition_id, gstring_lookup_cache)
4169 (composition_gstring_put_cache):
4170 * composite.h (struct composition.hash_index):
4171 * dispextern.h (struct image.hash):
4172 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4173 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4174 (hashfn_equal, hashfn_user_defined, make_hash_table)
4175 (maybe_resize_hash_table, hash_lookup, hash_put)
4176 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4177 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4178 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4179 * image.c (make_image, search_image_cache, lookup_image)
4180 (xpm_put_color_table_h):
4181 * lisp.h (struct Lisp_Hash_Table):
4182 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4183 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4184 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4185 * alloc.c (allocate_vectorlike):
4186 Check for overflow in vector size calculations.
4187 * ccl.c (ccl_driver):
4188 Check for overflow when converting EMACS_INT to int.
4189 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4190 need to be updated by these changes.
4191 * fns.c (make_hash_table, maybe_resize_hash_table):
4192 Check for integer overflow with large hash tables.
4193 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4194 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4195 (SXHASH_REDUCE): New macro.
4196 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4197 Use it instead of discarding useful hash info with large hash values.
4198 (sxhash_float): New function.
4199 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4200 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4201 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4202 Rewrite to use FIXNUM_BITS, as this simplifies things.
4203 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4204 Adjust signatures to match updated version of code.
4205 (consing_since_gc): Now EMACS_INT, since a single hash table can
4206 use more than INT_MAX bytes.
4208 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4210 Make it possible to build with GCC-4.6+ -O2 -flto.
4212 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4214 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4216 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4217 Call minibuffer-inactive-mode.
4219 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4221 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4222 Update dependencies.
4224 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4226 * data.c (init_data): Remove code for UTS, this system is not
4229 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4231 Don't force ./temacs to start in terminal mode.
4233 * frame.c (make_initial_frame): Initialize faces in all cases, not
4234 only when CANNOT_DUMP is defined.
4235 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4237 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4239 * dispnew.c (add_window_display_history): Use const for the string
4240 pointer. Remove declaration, not needed.
4242 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4244 Use 'inline', not 'INLINE'.
4245 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4246 * alloc.c, fontset.c (INLINE): Remove.
4247 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4248 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4249 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4250 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4251 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4253 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4255 Make it possible to run ./temacs.
4257 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4258 syms_of_callproc does the same thing. Remove test for
4259 "initialized", do it in the caller.
4260 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4262 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4264 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4265 (read_minibuf): Use get_minibuffer.
4266 (syms_of_minibuf): Use DEFSYM.
4267 (Qmetadata): New var.
4268 * data.c (Qbuffer): Don't make it static.
4269 (syms_of_data): Use DEFSYM.
4271 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4273 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4274 (CCL_CODE_MIN): New macro.
4276 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4278 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4280 * eval.c (Qdebug): Now static.
4281 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4282 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4283 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4285 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4287 * image.c: Various fixes to ImageMagick code comments.
4288 (Fimagemagick_types): Doc fix.
4290 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4292 Minor fixes prompted by GCC 4.6.0 warnings.
4294 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4296 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4297 (x_clipboard_manager_save_all): Move extern decl to ...
4298 * xterm.h: ... here, so that it can be checked for consistency.
4300 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4302 * xselect.c (x_clipboard_manager_save_frame)
4303 (x_clipboard_manager_save_all): New functions.
4304 (Fx_clipboard_manager_save): Lisp function deleted.
4306 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4307 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4309 * xterm.h: Update prototype.
4311 2011-05-28 William Xu <william.xwl@gmail.com>
4313 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4316 2011-05-28 Jim Meyering <meyering@redhat.com>
4318 Avoid a sign-extension bug in crypto_hash_function.
4319 * fns.c (to_uchar): Define.
4320 (crypto_hash_function): Use it to convert some newly-signed
4321 variables to unsigned, to avoid sign-extension bugs. For example,
4322 without this change, (md5 "truc") would evaluate to
4323 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4324 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4325 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4327 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4329 Integer overflow fixes.
4331 * dbusbind.c: Serial number integer overflow fixes.
4332 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4333 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4334 to hold a serial number that is too large for a fixnum.
4335 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4336 Check for serial numbers out of range. Decode any serial number
4337 that was so large that it became a float. (Bug#8722)
4339 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4340 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4341 Use XFASTINT rather than XUINT when numbers are nonnegative.
4342 (xd_append_arg, Fdbus_method_return_internal):
4343 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4344 arguments, check that Lisp number is nonnegative, rather than
4345 silently wrapping negative numbers around. (Bug#8722)
4346 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4349 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4351 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4353 ccl: add integer overflow checks
4354 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4355 (IN_INT_RANGE): New macros.
4356 (ccl_driver): Use them to check for integer overflow when
4357 decoding a CCL program. Many of the new checks are whether XINT (x)
4358 fits in int; it doesn't always, on 64-bit hosts. The new version
4359 doesn't catch all possible integer overflows, but it's an
4360 improvement. (Bug#8719)
4362 * alloc.c (make_event_array): Use XINT, not XUINT.
4363 There's no need for unsigned here.
4365 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4366 This follows up to the 2011-05-06 change that substituted uintptr_t
4367 for EMACS_INT. This case wasn't caught back then.
4369 Rework Fformat to avoid integer overflow issues.
4370 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4371 now (part of C89). Include <verify.h>.
4372 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4373 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4374 (Fformat): Avoid the prepass trying to compute sizes; it was only
4375 approximate and thus did not catch overflow reliably. Instead, walk
4376 through the format just once, formatting and computing sizes as we go,
4377 checking for integer overflow at every step, and allocating a larger
4378 buffer as needed. Keep track separately whether the format is
4379 multibyte. Keep only the most-recently calculated precision, rather
4380 than them all. Record whether each argument has been converted to
4381 string. Use EMACS_INT, not int, for byte and char and arg counts.
4382 Support field widths and precisions larger than INT_MAX. Avoid
4383 sprintf's undefined behavior with conversion specifications such as %#d
4384 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4385 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4386 formatting out-of-range floating point numbers with int
4389 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4391 * data.c: Avoid integer truncation in expressions involving floats.
4392 * data.c: Include <intprops.h>.
4393 (arith_driver): When there's an integer overflow in an expression
4394 involving floating point, convert the integers to floating point
4395 so that the resulting value does not suffer from catastrophic
4396 integer truncation. For example, on a 64-bit host (* 4
4397 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4398 Do not rely on undefined behavior after integer overflow.
4400 merge count_size_as_multibyte, parse_str_to_multibyte
4401 * character.c, character.h (count_size_as_multibyte):
4402 Rename from parse_str_to_multibyte; all uses changed.
4403 Check for integer overflow.
4404 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4405 since it's now a duplicate of the other. This is more of
4406 a character than a buffer op, so better that it's in character.c.
4407 * fns.c, print.c: Adjust to above changes.
4409 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4411 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4413 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4415 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4416 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4417 (x_clipboard_manager_save): Now static.
4418 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4420 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4421 (crypto_hash_function): Now static.
4422 Fix pointer signedness problems. Avoid unnecessary initializations.
4424 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4426 * termhooks.h (Vselection_alist): Make it terminal-local.
4428 * terminal.c (create_terminal): Initialize it.
4430 * xselect.c: Support for clipboard managers.
4431 (Vselection_alist): Move to termhooks.h as terminal-local var.
4432 (LOCAL_SELECTION): New macro.
4433 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4434 (symbol_to_x_atom): Remove gratuitous arg.
4435 (x_handle_selection_request, lisp_data_to_selection_data)
4436 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4437 (x_own_selection, x_get_local_selection, x_convert_selection):
4438 New arg, specifying work frame. Use terminal-local Vselection_alist.
4439 (some_frame_on_display): Delete unused function.
4440 (Fx_own_selection_internal, Fx_get_selection_internal)
4441 (Fx_disown_selection_internal, Fx_selection_owner_p)
4442 (Fx_selection_exists_p): New optional frame arg.
4443 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4444 (x_handle_selection_clear): Don't treat other terminals with the
4445 same keyboard specially. Use the terminal-local Vselection_alist.
4446 (x_clear_frame_selections): Use Frun_hook_with_args.
4448 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4450 * xterm.h: Add support for those atoms.
4452 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4454 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4455 (converted_selections, conversion_fail_tag): New global variables.
4456 (x_selection_request_lisp_error): Free the above.
4457 (x_get_local_selection): Remove unnecessary code.
4458 (x_reply_selection_request): Args changed; handle arbitrary array
4459 of converted selections stored in converted_selections.
4460 Separate the XChangeProperty and SelectionNotify steps.
4461 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4462 (x_convert_selection): New function.
4463 (x_handle_selection_event): Simplify.
4464 (x_get_foreign_selection): Don't ignore incoming requests while
4465 waiting for an answer; this will fail when we implement
4466 SAVE_TARGETS, and seems unnecessary anyway.
4467 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4468 (Vx_sent_selection_functions): Doc fix.
4470 2011-05-26 Leo Liu <sdl.web@gmail.com>
4472 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4474 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4476 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4478 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4479 for fringe update if it has periodic bitmap.
4480 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4481 and fringe_bitmap_periodic_p.
4483 * fringe.c (get_fringe_bitmap_data): New function.
4484 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4485 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4486 row. Mark glyph row for fringe update if periodicity changed.
4488 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4489 for fringe update unless it has periodic bitmap.
4491 2011-05-25 Kenichi Handa <handa@m17n.org>
4493 * xdisp.c (get_next_display_element): Set correct it->face_id for
4494 a static composition.
4496 2011-05-24 Leo Liu <sdl.web@gmail.com>
4499 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4501 * fns.c (crypto_hash_function, Fsha1): New function.
4502 (Fmd5): Use crypto_hash_function.
4503 (syms_of_fns): Add Ssha1.
4505 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4507 * gnutls.c: Remove unused macros.
4508 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4509 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4510 Remove macros that are defined and never used.
4511 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4513 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4515 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4516 (Fx_get_selection_internal): Minor cleanup.
4517 (Fx_own_selection_internal): Rename arguments for consistency with
4520 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4522 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4524 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4526 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4528 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4530 * dispnew.c (scrolling_window): Don't exclude the case that the
4531 last enabled row in the desired matrix touches the bottom boundary.
4533 2011-05-21 Glenn Morris <rgm@gnu.org>
4535 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4536 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4537 and add some more files.
4539 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4541 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4542 report_file_error introduced by the change from 2011-05-07.
4544 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4546 * systime.h (Time): Define only if emacs is defined.
4547 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4548 where the include path doesn't have X11/X.h by default. See
4549 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4551 2011-05-20 Kenichi Handa <handa@m17n.org>
4553 * composite.c (find_automatic_composition): Fix previous change.
4555 2011-05-20 Glenn Morris <rgm@gnu.org>
4557 * lisp.mk: New file, split from Makefile.in.
4558 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4559 (shortlisp): Remove.
4560 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4562 2011-05-19 Glenn Morris <rgm@gnu.org>
4564 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4565 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4566 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4567 (lisp): Set the order to that of loadup.el.
4568 (shortlisp): Make it a copy of $lisp.
4569 (SOME_MACHINE_LISP): Remove.
4570 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4571 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4573 2011-05-18 Kenichi Handa <handa@m17n.org>
4575 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4576 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4577 (find_automatic_composition): Mostly rewrite for efficiency.
4579 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4581 * makefile.w32-in: Update dependencies.
4583 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4585 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4586 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4588 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4590 Fix some integer overflow issues, such as string length overflow.
4592 * insdel.c (count_size_as_multibyte): Check for string overflow.
4594 * character.c (lisp_string_width): Check for string overflow.
4595 Use EMACS_INT, not int, for string indexes and lengths; in
4596 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4597 the resulting string length overflows an EMACS_INT; instead,
4598 report a string overflow if no precision given. When checking for
4599 precision exhaustion, use a check that cannot possibly have
4600 integer overflow. (Bug#8675)
4601 * character.h (lisp_string_width): Adjust to new signature.
4603 * alloc.c (string_overflow): New function.
4604 (Fmake_string): Use it. This doesn't change behavior, but saves
4605 a few bytes and will simplify future changes.
4606 * character.c (string_escape_byte8): Likewise.
4607 * lisp.h (string_overflow): New decl.
4609 Fixups, following up to the user-interface timestamp change.
4610 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4611 for UI timestamps, instead of unsigned long.
4612 * msdos.c (mouse_get_pos): Likewise.
4613 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4614 * w32gui.h (Time): Define by including "systime.h" rather than by
4615 declaring it ourselves. (Bug#8664)
4617 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4618 * image.c (clear_image_cache): Likewise.
4620 * term.c (term_mouse_position): Don't assume time_t wraparound.
4622 Be more systematic about user-interface timestamps.
4623 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4624 and sometimes 'EMACS_UINT', to represent these timestamps.
4625 This change causes it to use 'Time' uniformly, as that's what X uses.
4626 This makes the code easier to follow, and makes it easier to catch
4627 integer overflow bugs such as Bug#8664.
4628 * frame.c (Fmouse_position, Fmouse_pixel_position):
4629 Use Time, not unsigned long, for user-interface timestamps.
4630 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4631 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4632 * keyboard.h (last_event_timestamp): Likewise.
4633 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4634 * menu.h (xmenu_show): Likewise.
4635 * term.c (term_mouse_position): Likewise.
4636 * termhooks.h (struct input_event.timestamp): Likewise.
4637 (struct terminal.mouse_position_hook): Likewise.
4638 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4639 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4640 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4641 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4643 * menu.h, termhooks.h: Include "systime.h", for Time.
4645 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4646 Don't assume that the difference between two unsigned long values
4647 can fit into an integer. At this point, we know button_down_time
4648 <= event->timestamp, so the difference must be nonnegative, so
4649 there's no need to cast the result if double-click-time is
4650 nonnegative, as it should be; check that it's nonnegative, just in
4651 case. This bug is triggered when events are more than 2**31 ms
4652 apart (about 25 days). (Bug#8664)
4654 * xselect.c (last_event_timestamp): Remove duplicate decl.
4655 (x_own_selection): Remove needless cast to unsigned long.
4657 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4658 that always fit in int. Use a sentinel instead of a counter, to
4659 avoid a temp and to allay GCC's concerns about possible int overflow.
4660 * frame.h (struct frame): Use int for menu_bar_items_used
4661 instead of EMACS_INT, since it always fits in int.
4663 * menu.c (grow_menu_items): Check for int overflow.
4665 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4667 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4668 Before, the code was not consistent. These values cannot exceed
4669 2**31 - 1 so there's no need to make them unsigned.
4670 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4671 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4672 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4674 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4676 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4677 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4678 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4679 presumably because the widths might not match.
4681 * window.c (size_window): Avoid needless test at loop start.
4683 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4685 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4687 2011-05-12 Drew Adams <drew.adams@oracle.com>
4689 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4691 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4693 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4694 `width' to `bar_area_x' and `bar_area_width', respectively.
4695 (x_scroll_run): Take account of fringe background extension.
4697 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4698 Rename local vars `left' and `width' to `bar_area_x' and
4699 `bar_area_width', respectively.
4700 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4701 background extension.
4703 2011-05-10 Jim Meyering <meyering@redhat.com>
4705 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4707 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4709 * image.c (Finit_image_library): Return t for built-in image types,
4710 like pbm and xbm. (Bug#8640)
4712 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4714 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4716 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4718 * w32console.c (Fset_screen_color): Doc fix.
4719 (Fget_screen_color): New function.
4720 (syms_of_ntterm): Defsubr it.
4722 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4723 unlink the temporary file if Fcall_process didn't create it in the
4725 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4726 child process will be redirected to a file specified with `:file'.
4727 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4728 cue to call_process_cleanup not to close that handle.
4730 2011-05-07 Ben Key <bkey76@gmail.com>
4732 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4733 one of two shell specific rules, either bootstrap-temacs-CMD or
4734 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4735 to the previous implementation of the bootstrap-temacs rule.
4736 The bootstrap-temacs-CMD rule is similar to the previous
4737 implementation of the bootstrap-temacs rule except that it
4738 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4741 These changes, along with some changes to nt/configure.bat,
4742 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4743 earlier fix to add support for --cflags and --ldflags options
4744 that include quotes so that it works whether make uses cmd or
4747 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4749 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4750 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4752 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4753 a string. Handle both cases.
4754 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4755 (Fdbus_register_method): Use Qinvalid_function.
4757 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4759 * makefile.w32-in: Update dependencies.
4760 (LISP_H): Add inttypes.h and stdin.h.
4761 (PROCESS_H): Add unistd.h.
4763 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4765 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4766 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4768 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4770 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4772 * term.c (vfatal): Remove stray call to va_end.
4773 It's not needed and the C Standard doesn't allow it here anyway.
4775 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4776 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4778 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4781 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4783 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4785 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4787 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4789 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4791 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4792 * charset.c (Fdefine_charset_internal): Don't initialize
4793 charset.code_space[15]. The value was garbage, on hosts with
4794 32-bit int (Bug#8600).
4796 * lread.c (read_integer): Be more consistent with string-to-number.
4797 Use string_to_number to do the actual conversion; this avoids
4798 rounding errors and fixes some other screwups. Without this fix,
4799 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4800 (digit_to_number): Move earlier, for benefit of read_integer.
4801 Return -1 if the digit is out of range for the base, -2 if it is
4802 not a digit in any supported base. (Bug#8602)
4804 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4806 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4807 to match comment at start of function. This also removes a
4808 GCC warning about overflow in a 32+64-bit port.
4810 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4812 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4813 Reported by Stefan Monnier in
4814 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4815 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4816 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4818 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4819 (EMACS_UINTPTR): Likewise, with uintptr_t.
4821 * lisp.h: Prefer 64-bit EMACS_INT if available.
4822 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4823 on 32-bit hosts that have 64-bit int, so that they can access
4825 However, temporarily disable this change unless the temporary
4826 symbol WIDE_EMACS_INT is defined.
4828 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4830 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4831 This removes an assumption that EMACS_INT and long are the same
4832 width as pointers. The assumption is true for Emacs porting targets
4833 now, but we want to make other targets possible.
4834 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4835 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4836 In the rest of the code, change types of integers that hold casted
4837 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4838 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4839 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4840 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4841 No need to cast type when ORing.
4842 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4843 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4844 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4845 assume EMACS_INT is the same width as char *.
4846 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4847 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4848 Remove no-longer-needed casts.
4849 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4850 (xg_tool_bar_help_callback, xg_make_tool_item):
4851 Use EMACS_INTPTR to hold an integer
4852 that will be cast to void *; this can avoid a GCC warning
4853 if EMACS_INT is not the same width as void *.
4854 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4855 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4856 (current_message_1, set_message_1):
4857 Use a local to convert to proper width without a cast.
4858 * xmenu.c (dialog_selection_callback): Likewise.
4860 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4861 Also, don't assume VALBITS / RAND_BITS is less than 5,
4862 and don't rely on undefined behavior when shifting a 1 left into
4864 * lisp.h (get_random): Change signature to match.
4866 * lread.c (hash_string): Use size_t, not int, for hash computation.
4867 Normally we prefer signed values; but hashing is special, because
4868 it's better to use unsigned division on hash table sizes so that
4869 the remainder is nonnegative. Also, size_t is the natural width
4870 for hashing into memory. The previous code used 'int', which doesn't
4871 retain enough info to hash well into very large tables.
4872 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4874 * dbusbind.c: Don't possibly lose pointer info when converting.
4875 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4876 Use XPNTR rather than XHASH, so that the high-order bits of
4877 the pointer aren't lost when converting through void *.
4879 * eval.c (Fautoload): Don't double-shift a pointer.
4881 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4883 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4885 * gnutls.c (DEF_GNUTLS_FN):
4886 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4888 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4890 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4893 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4895 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4896 New version that can reserve upto 2GB of heap space.
4898 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4900 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4902 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4904 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4905 `gnutls_certificate_set_x509_key_file'.
4907 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4909 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4910 Update dependencies.
4912 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4914 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4915 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4916 Remove unused parameter `fildes'.
4917 * process.c (read_process_output, send_process): Don't pass it.
4919 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4921 Fix previous change: the library cache is defined in w32.c.
4922 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4923 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4925 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4927 Implement dynamic loading of GnuTLS on Windows.
4929 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4930 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4931 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4934 * gnutls.c (Qgnutls_dll): Define.
4935 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4936 (gnutls_*): Declare function pointers.
4937 (init_gnutls_functions): New function to initialize function pointers.
4938 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4939 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4940 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4941 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4942 (emacs_gnutls_write, emacs_gnutls_read)
4943 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4944 (Fgnutls_available_p): New function.
4945 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4946 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4947 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4949 * image.c: Include w32.h.
4950 (Vimage_type_cache): Delete.
4951 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4952 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4953 (w32_delayed_load): Move to w32.c.
4955 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4957 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4958 (w32_delayed_load): Move from image.c. When loading a library, record
4959 its filename in the :loaded-from property of the library id.
4960 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4961 Initialize and staticpro them.
4962 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4964 * process.c: Include lisp.h before w32.h, not after.
4965 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4966 instead of gnutls_record_check_pending.
4968 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4970 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4972 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4973 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4976 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4978 * xterm.c (x_set_frame_alpha): Do not set property on anything
4979 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4981 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4983 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4985 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4987 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4988 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4989 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4990 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4991 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4992 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4993 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4994 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4995 (Qgnutls_bootprop_callbacks_verify): Make static.
4997 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4999 * callproc.c: Indentation fixup.
5001 * sysdep.c (wait_for_termination_1): Make static.
5002 (wait_for_termination, interruptible_wait_for_termination):
5003 Move after wait_for_termination_1.
5005 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5007 * sysdep.c (interruptible_wait_for_termination): New function
5008 which is like wait_for_termination, but allows keyboard
5011 * callproc.c (Fcall_process): Add (:file "file") as an option for
5013 (Fcall_process_region): Ditto.
5015 2011-04-30 Eli Zaretskii <eliz@gnu.org>
5017 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5018 rather than `XVECTOR (FOO)->size'.
5020 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5021 inttypes.h, as a gnulib replacement is used if it not available in
5024 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5026 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5027 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5028 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5030 * coding.c (coding_alloc_by_realloc): Error out if destination
5031 will grow beyond MOST_POSITIVE_FIXNUM.
5032 (decode_coding_emacs_mule): Abort if there isn't enough place in
5033 charbuf for the composition carryover bytes. Reserve an extra
5034 space for up to 2 characters produced in a loop.
5035 (decode_coding_iso_2022): Abort if there isn't enough place in
5036 charbuf for the composition carryover bytes.
5038 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5040 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5041 aborting when %lld or %lll format is passed.
5042 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5043 %llo or %llx format is passed. (Bug#8545)
5045 * window.c (window_scroll_line_based): Use a marker instead of
5046 simple variables to record original value of point. (Bug#7952)
5048 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5049 produced by %s or %c overflows available buffer space. (Bug#8545)
5051 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5053 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5054 (SIZE_MAX): Move defn after all includes, as they might #define it.
5056 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5058 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5060 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5062 * keyboard.c (Qdelayed_warnings_hook): Define.
5063 (command_loop_1): Run `delayed-warnings-hook'
5064 if Vdelayed_warnings_list is non-nil.
5065 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5066 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5068 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5070 * doprnt.c (doprnt): Don't return value smaller than the buffer
5071 size if the message was truncated. (Bug#8545).
5073 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5075 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5076 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5078 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5080 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5082 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5084 * makefile.w32-in: Update dependencies.
5086 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5088 Improve `doprnt' and its usage. (Bug#8545)
5089 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5090 `format_end'. Remove support for %l as a conversion specifier.
5091 Don't use xrealloc. Improve diagnostics when the %l size modifier
5092 is used. Update the commentary.
5094 * eval.c (verror): Simplify calculation of size_t.
5096 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5099 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5101 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5104 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5106 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5107 This makes this file independent of the recent pseudovector change.
5109 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5111 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5113 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5114 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5115 Remove unused local.
5116 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5118 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5119 GCC 4.6.0 optimizes based on type-based alias analysis.
5120 For example, if b is of type struct buffer * and v of type struct
5121 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5122 != &v->size, and therefore "v->size = 1; b->size = 2; return
5123 v->size;" must therefore return 1. This assumption is incorrect
5124 for Emacs, since it type-puns struct Lisp_Vector * with many other
5125 types. To fix this problem, this patch adds a new type struct
5126 vectorlike_header that documents the constraints on layout of vectors
5127 and pseudovectors, and helps optimizing compilers not get fooled
5128 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5129 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5130 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5132 (XSETPVECTYPE): Rewrite in terms of new macro.
5133 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5134 This is a bit clearer, and further avoids the possibility of
5135 undesirable aliasing.
5136 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5137 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5138 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5139 since Lisp_Subr is a special case (no "next" field).
5140 (ASIZE): Now uses header.size rather than size.
5141 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5142 to avoid the hassle of writing XVECTOR (foo)->header.size.
5143 (struct vectorlike_header): New type.
5144 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5145 object, to help avoid aliasing.
5146 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5147 (SUBRP): Likewise, since Lisp_Subr is a special case.
5148 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5149 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5150 (struct Lisp_Hash_Table): Combine first two members into a single
5151 struct vectorlike_header member. All uses of "size" and "next" members
5152 changed to be "header.size" and "header.next".
5153 * buffer.h (struct buffer): Likewise.
5154 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5155 * frame.h (struct frame): Likewise.
5156 * process.h (struct Lisp_Process): Likewise.
5157 * termhooks.h (struct terminal): Likewise.
5158 * window.c (struct save_window_data, struct saved_window): Likewise.
5159 * window.h (struct window): Likewise.
5160 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5161 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5162 * buffer.c (init_buffer_once): Likewise.
5163 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5165 * process.c (Fformat_network_address): Use local var for size,
5168 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5170 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5171 * data.c (atof): Remove decl; no longer used or needed.
5172 (digit_to_number): Move to lread.c.
5173 (Fstring_to_number): Use new string_to_number function, to be
5174 consistent with how the Lisp reader treats infinities and NaNs.
5175 Do not assume that floating-point numbers represent EMACS_INT
5176 without losing information; this is not true on most 64-bit hosts.
5177 Avoid double-rounding errors, by insisting on integers when
5178 parsing non-base-10 numbers, as the documentation specifies.
5179 * lisp.h (string_to_number): New decl, replacing ...
5180 (isfloat_string): Remove.
5181 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5182 (read1): Do not accept +. and -. as integers; this
5183 appears to have been a coding error. Similarly, do not accept
5184 strings like +-1e0 as floating point numbers. Do not report
5185 overflow for integer overflows unless the base is not 10 which
5186 means we have no simple and reliable way to continue.
5187 Break out the floating-point parsing into a new
5188 function string_to_number, so that Fstring_to_number parses
5189 floating point numbers consistently with the Lisp reader.
5190 (digit_to_number): Move here from data.c. Make it static inline.
5191 (E_CHAR, EXP_INT): Remove, replacing with ...
5192 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5193 (string_to_number): New function, replacing isfloat_string.
5194 This function checks for valid syntax and produces the resulting
5195 Lisp float number too. Rework it so that string-to-number
5196 no longer mishandles examples like "1.0e+". Use strtoumax,
5197 so that overflow for non-base-10 numbers is reported only when
5198 there's no portable and simple way to convert to floating point.
5200 * textprop.c (set_text_properties_1): Rewrite for clarity,
5201 and to avoid GCC warning about integer overflow.
5203 * intervals.h (struct interval): Use EMACS_INT for members
5204 where EMACS_UINT might cause problems. See
5205 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5206 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5207 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5209 (offset_intervals): Tell GCC not to worry about length overflow
5210 when negating a negative length.
5212 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5213 (overrun_check_free): Likewise.
5215 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5216 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5219 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5220 (gnutls_make_error): Rename local to avoid shadowing.
5221 (gnutls_emacs_global_deinit): ifdef out; not used.
5222 (Fgnutls_boot): Use const for pointer to readonly storage.
5223 Comment out unused local. Fix pointer signedness problems.
5225 * lread.c (openp): Don't stuff size_t into an 'int'.
5226 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5227 about possible signed overflow.
5229 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5230 (GDK_KEY_g): Don't define if already defined.
5231 (xg_prepare_tooltip): Avoid pointer signedness problem.
5232 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5234 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5235 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5237 * xfns.c (Fx_window_property): Simplify a bit,
5238 to make a bit faster and to avoid GCC 4.6.0 warning.
5239 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5241 * fns.c (internal_equal): Don't assume size_t fits in int.
5243 * alloc.c (compact_small_strings): Tighten assertion a little.
5245 Replace pEd with more-general pI, and fix some printf arg casts.
5246 * lisp.h (pI): New macro, generalizing old pEd macro to other
5247 conversion specifiers. For example, use "...%"pI"d..." rather
5248 than "...%"pEd"...".
5249 (pEd): Remove. All uses replaced with similar uses of pI.
5250 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5251 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5252 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5253 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5254 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5255 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5256 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5258 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5259 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5260 * print.c (safe_debug_print, print_object): Likewise.
5261 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5263 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5264 avoiding the 0 flag, which is not portable.
5265 * process.c (Fmake_network_process): Use pI to avoid cast.
5266 * region-cache.c (pp_cache): Likewise.
5267 * xdisp.c (decode_mode_spec): Likewise.
5268 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5269 behavior on 64-bit hosts with printf arg.
5270 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5271 (x_stop_queuing_selection_requests): Likewise.
5272 (x_get_window_property): Don't truncate byte count to an 'int'
5275 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5276 here, since it parses constructs like leading '-' and spaces,
5277 which are not wanted; and it overflows with large numbers.
5278 Instead, simply match F[0-9]+, which is what is wanted anyway.
5280 * alloc.c: Remove unportable assumptions about struct layout.
5281 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5282 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5283 (allocate_vectorlike, make_pure_vector): Use the new macros,
5284 plus offsetof, to remove unportable assumptions about struct layout.
5285 These assumptions hold on all porting targets that I know of, but
5286 they are not guaranteed, they're easy to remove, and removing them
5287 makes further changes easier.
5289 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5290 This doesn't fix a bug but makes the code clearer.
5291 (string_overrun_cookie): Now const. Use initializers that
5292 don't formally overflow signed char, to avoid warnings.
5293 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5294 can cause Emacs to crash when string overrun checking is enabled.
5295 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5296 multiple of sizeof (EMACS_INT); it need not be, if
5297 alignof(EMACS_INT) < sizeof (EMACS_INT).
5298 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5300 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5302 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5304 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5306 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5307 supposed to be handshaking. (Bug#8556)
5308 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5310 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5312 * lisp.h (Qdebug): List symbol.
5313 * eval.c (Qdebug): Restore global linkage.
5314 * keyboard.c (debug-on-event): New variable.
5315 (handle_user_signal): Break into debugger when debug-on-event
5316 matches the current signal symbol.
5318 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5320 * alloc.c (check_sblock, check_string_bytes)
5321 (check_string_free_list): Convert to standard C.
5323 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5325 * w32.c (emacs_gnutls_push): Fix typo.
5327 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5329 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5330 "cast to pointer from integer of different size".
5332 Improve doprnt and its use in verror. (Bug#8545)
5333 * doprnt.c (doprnt): Document the set of format control sequences
5334 supported by the function. Use SAFE_ALLOCA instead of always
5337 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5338 is one byte too soon. Don't use xrealloc; instead xfree and
5341 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5343 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5346 * gnutls.c: Renamed global_initialized to
5347 gnutls_global_initialized. Added internals for the
5348 :verify-hostname-error, :verify-error, and :verify-flags
5349 parameters of `gnutls-boot' and documented those parameters in the
5350 docstring. Start callback support.
5351 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5352 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5353 on error. Return error code.
5354 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5355 (emacs_gnutls_read): Likewise.
5356 (Fgnutls_boot): Return handshake error code.
5357 (emacs_gnutls_handle_error): New function.
5358 (wsaerror_to_errno): Likewise.
5360 * w32.h (emacs_gnutls_pull): Add prototype.
5361 (emacs_gnutls_push): Likewise.
5363 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5364 (emacs_gnutls_push): Likewise.
5366 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5368 * process.c (wait_reading_process_output): Check if GnuTLS
5369 buffered some data internally if no FDs are set for TLS
5372 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5373 (LIBS): Link to USER_LIBS.
5374 ($(BLD)/gnutls.$(0)): New target.
5376 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5378 * xdisp.c (handle_single_display_spec): Rename the
5379 display_replaced_before_p argument into display_replaced_p, to
5380 make it consistent with the commentary. Fix typos in the
5383 * textprop.c (syms_of_textprop): Remove dead code.
5384 (copy_text_properties): Delete obsolete commentary about an
5385 interface that was deleted long ago. Fix typos in the description
5388 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5389 to changes in oldXMenu/XMenu.h from 2011-04-16.
5390 <menu_help_message, prev_menu_help_message>: Constify.
5391 (IT_menu_make_room): menu->help_text is now `const char **';
5394 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5395 to changes in oldXMenu/XMenu.h from 2011-04-16.
5396 (struct XMenu): Declare `help_text' `const char **'.
5398 * xfaces.c <Qunspecified>: Make extern again.
5400 * syntax.c: Include sys/types.h before including regex.h, as
5403 * doc.c (get_doc_string): Improve the format passed to `error'.
5405 * doprnt.c (doprnt): Improve commentary.
5407 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5409 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5412 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5413 changes in globals.h immediately force recompilation.
5414 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5415 $(CURDIR)/s/ms-w32.h.
5416 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5418 * character.c (Fchar_direction): Function deleted.
5419 (syms_of_character): Don't defsubr it.
5420 <char-direction-table>: Deleted.
5422 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5424 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5425 * doprnt.c: Include limits.h.
5426 (SIZE_MAX): New macro.
5427 (doprnt): Return a size_t value. 2nd arg is now size_t.
5428 Many local variables are now size_t instead of int or unsigned.
5429 Improve overflow protection. Support `l' modifier for integer
5430 conversions. Support %l conversion. Don't assume an EMACS_INT
5431 argument for integer conversions and for %c.
5433 * lisp.h (doprnt): Restore prototype.
5435 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5438 * Makefile.in (base_obj): Add back doprnt.o.
5440 * deps.mk (doprnt.o): Add back prerequisites.
5441 (callint.o): Depend on character.h.
5443 * eval.c (internal_lisp_condition_case): Include the handler
5444 representation in the error message.
5445 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5446 when breaking from the loop.
5448 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5450 * callint.c (Fcall_interactively): When displaying error message
5451 about invalid control letter, pass the character's codepoint, not
5452 a pointer to its multibyte form. Improve display of the character
5453 in octal and display also its hex code.
5455 * character.c (char_string): Use %x to display the (unsigned)
5456 codepoint of an invalid character, to avoid displaying a bogus
5459 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5460 `error', not SYMBOL_NAME itself.
5462 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5463 character arguments to `error'.
5465 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5466 to `error' in error message about FINAL_CHAR argument. Make sure
5467 FINAL_CHAR is a character, and use %c when it is passed as
5468 argument to `error'.
5470 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5472 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5474 * w32.c: Include <time.h>.
5475 (sys_localtime): New function.
5477 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5479 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5481 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5483 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5485 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5488 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5490 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5491 gl_state.e_property when gl_state.object is Qt.
5493 * insdel.c (make_gap_larger): Remove limitation of buffer size
5496 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5498 * xdisp.c (lookup_glyphless_char_display)
5499 (produce_glyphless_glyph): Handle cons cell entry in
5500 glyphless-char-display.
5501 (Vglyphless_char_display): Document it.
5503 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5504 glyphless-char-display.
5506 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5508 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5510 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5512 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5513 definition for no-X builds.
5515 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5517 Static checks with GCC 4.6.0 and non-default toolkits.
5519 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5521 * process.c (keyboard_bit_set): Define only if SIGIO.
5522 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5523 (send_process): Repair possible setjmp clobbering.
5525 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5527 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5529 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5531 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5532 Define only if needed.
5534 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5535 by pacifying GCC about it. Maybe it's time to retire it?
5536 * xfaces.c (USG, __TIMEVAL__): Likewise.
5538 * dispextern.h (struct redisplay_interface): Rename param
5540 * termhooks.h (struct terminal): Likewise.
5541 * xterm.c (xembed_send_message): Likewise.
5543 * insdel.c (make_gap_smaller): Define only if
5544 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5546 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5549 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5550 so that we aren't warned about unused symbols.
5552 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5554 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5556 * xfns.c (x_real_positions): Mark locals as initialized.
5558 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5560 * xterm.c: Fix problems found by static analysis with other toolkits.
5561 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5562 (x_dispatch_event): Declare static if USE_GTK, and
5563 define if USE_GTK || USE_X_TOOLKIT.
5564 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5565 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5566 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5567 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5569 * xmenu.c (menu_help_callback): Pointer type fixes.
5570 Use const pointers when pointing at readonly data. Avoid pointer
5572 (FALSE): Remove unused macro.
5573 (update_frame_menubar): Remove unused decl.
5575 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5577 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5578 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5579 (single_menu_item): Rename local to avoid shadowing.
5581 * keyboard.c (make_lispy_event): Remove unused local var.
5583 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5584 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5586 * bitmaps: Change bitmaps from unsigned char back to the X11
5587 compatible char. Avoid the old compiler warnings about
5588 out-of-range initializers by using, for example, '\xab' rather
5591 * xgselect.c (xgselect_initialize): Check vs interface
5592 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5594 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5596 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5597 to read-only memory.
5599 * fns.c (vector): Remove; this old hack is no longer needed.
5601 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5603 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5605 * xrdb.c (x_load_resources): Omit unused local.
5607 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5608 (x_window): Rename locals to avoid shadowing.
5609 (USG): Use the kludged USG macro, to pacify gcc.
5611 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5612 (x_term_init): Remove local to avoid shadowing.
5614 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5616 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5617 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5619 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5621 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5623 Fix regex.c, syntax.c and friends for buffers > 2GB.
5624 * syntax.h (struct gl_state_s): Declare character position members
5627 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5629 * textprop.c (verify_interval_modification, interval_of):
5630 Declare arguments EMACS_INT.
5632 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5635 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5637 * indent.c (Fvertical_motion): Local variable it_start is now
5640 * regex.c (re_match, re_match_2, re_match_2_internal)
5641 (bcmp_translate, regcomp, regexec, print_double_string)
5642 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5643 (re_compile_pattern, re_exec): Declare arguments and local
5644 variables `size_t' and `ssize_t' and return values `regoff_t', as
5646 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5647 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5648 <compile_stack_type>: `size' and `avail' are now `size_t'.
5650 * regex.h <regoff_t>: Use ssize_t, not int.
5651 (re_search, re_search_2, re_match, re_match_2): Arguments that
5652 specify buffer/string position and length are now ssize_t and
5653 size_t. Return type is regoff_t.
5655 2011-04-16 Ben Key <bkey76@gmail.com>
5657 * nsfont.m: Fixed bugs in ns_get_family and
5658 ns_descriptor_to_entity that were caused by using free to
5659 deallocate memory blocks that were allocated by xmalloc (via
5660 xstrdup). This caused Emacs to crash when compiled with
5661 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5662 --enable-checking=xmallocoverrun). xfree is now used to
5663 deallocate these memory blocks.
5665 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5667 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5669 emacs_write: Accept and return EMACS_INT for sizes.
5670 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5672 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5673 Accept and return EMACS_INT.
5674 (emacs_gnutls_write): Return the number of bytes written on
5676 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5677 (emacs_read, emacs_write): Remove check for negative size, as the
5678 Emacs source code has been audited now.
5679 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5680 (emacs_read, emacs_write): Use it.
5681 * process.c (send_process): Adjust to the new signatures of
5682 emacs_write and emacs_gnutls_write. Do not attempt to store
5683 a byte offset into an 'int'; it might overflow.
5684 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5686 * sound.c: Don't assume sizes fit in 'int'.
5687 (struct sound_device.period_size, alsa_period_size):
5688 Return EMACS_INT, not int.
5689 (struct sound_device.write, vox_write, alsa_write):
5690 Accept EMACS_INT, not int.
5691 (wav_play, au_play): Use EMACS_INT to store sizes and to
5692 record read return values.
5694 2011-04-15 Ben Key <bkey76@gmail.com>
5696 * keyboard.c (Qundefined): Don't declare static since it is used
5698 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5699 static since they are used in nsfont.m.
5701 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5703 * process.c (Qprocessp): Don't declare static.
5704 * lisp.h (Qprocessp): Declare again.
5706 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5708 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5710 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5712 Improve C-level modularity by making more things 'static'.
5714 Don't publish debugger-only interfaces to other modules.
5715 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5716 (verify_bytepos, count_markers): Move decls to the only modules
5718 * region-cache.h (pp_cache): Likewise.
5719 * window.h (check_all_windows): Likewise.
5720 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5722 * sysdep.c (croak): Now static, if
5723 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5724 * syssignal.h (croak): Declare only if not static.
5726 * alloc.c (refill_memory_reserve): Now static if
5727 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5728 * lisp.h (refill_memory_reserve): Declare only if not static.
5730 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5731 Define only if USE_LUCID.
5733 * xrdb.c (x_customization_string, x_rm_string): Now static.
5735 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5736 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5738 * xdisp.c (draw_row_with_mouse_face): Now static.
5739 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5741 * window.h (check_all_windows): Mark externally visible.
5743 * window.c (window_deletion_count): Now static.
5745 * undo.c: Make symbols static if they're not exported.
5746 (last_undo_buffer, last_boundary_position, pending_boundary):
5749 * textprop.c (interval_insert_behind_hooks): Now static.
5750 (interval_insert_in_front_hooks): Likewise.
5752 * term.c: Make symbols static if they're not exported.
5753 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5754 (max_frame_lines, tty_set_terminal_modes):
5755 (tty_reset_terminal_modes, tty_turn_off_highlight):
5756 (get_tty_terminal): Now static.
5757 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5758 * termhooks.h (term_mouse_moveto): Do not declare if
5760 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5761 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5763 * sysdep.c: Make symbols static if they're not exported.
5764 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5766 (sigprocmask_set, full_mask): Remove; unused.
5767 (wait_debugging): Mark as visible.
5768 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5769 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5771 * syntax.c (syntax_temp): Define only if !__GNUC__.
5773 * sound.c (current_sound_device, current_sound): Now static.
5775 * search.c (searchbufs, searchbuf_head): Now static.
5777 * scroll.c (scroll_cost): Remove; unused.
5778 * dispextern.h (scroll_cost): Remove decl.
5780 * region-cache.h (pp_cache): Mark as externally visible.
5782 * process.c: Make symbols static if they're not exported.
5783 (process_tick, update_tick, create_process, chan_process):
5784 (Vprocess_alist, proc_buffered_char, datagram_access):
5785 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5786 (deactivate_process): Mark defn as static, as well as decl.
5787 * lisp.h (create_process): Remove decl.
5788 * process.h (chan_process, Vprocess_alist): Remove decls.
5790 * print.c: Make symbols static if they're not exported.
5791 (print_depth, new_backquote_output, being_printed, print_buffer):
5792 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5793 (print_interval, print_number_index, initial_stderr_stream):
5795 * lisp.h (Fprinc): Remove decl.
5796 (debug_output_compilation_hack): Mark as externally visible.
5798 * sysdep.c (croak): Move decl from here to syssignal.h.
5799 * syssignal.h (croak): Put it here, so the API can be checked when
5800 'croak' is called from dissociate_if_controlling_tty.
5802 * minibuf.c: Make symbols static if they're not exported.
5803 (minibuf_save_list, choose_minibuf_frame): Now static.
5804 * lisp.h (choose_minibuf_frame): Remove decl.
5806 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5808 * lread.c: Make symbols static if they're not exported.
5809 (read_objects, initial_obarray, oblookup_last_bucket_number):
5811 (make_symbol): Remove; unused.
5812 * lisp.h (initial_obarray, make_symbol): Remove decls.
5814 * keyboard.c: Make symbols static if they're not exported.
5815 (single_kboard, recent_keys_index, total_keys, recent_keys):
5816 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5817 (this_single_command_key_start, echoing, last_auto_save):
5818 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5819 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5820 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5821 (Vlispy_mouse_stem, double_click_count):
5823 (force_auto_save_soon): Define only if SIGDANGER.
5824 (ignore_mouse_drag_p): Now static if
5825 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5826 (print_help): Remove; unused.
5827 (stop_character, last_timer_event): Mark as externally visible.
5828 * keyboard.h (ignore_mouse_drag_p): Declare only if
5829 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5830 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5831 * lisp.h (echoing): Remove decl.
5832 (force_auto_save_soon): Declare only if SIGDANGER.
5833 * xdisp.c (redisplay_window): Simplify code, to make it more
5834 obvious that ignore_mouse_drag_p is not accessed if !defined
5835 USE_GTK && !defined HAVE_NS.
5837 * intervals.c: Make symbols static if they're not exported.
5838 (merge_properties_sticky, merge_interval_right, delete_interval):
5840 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5842 * insdel.c: Make symbols static if they're not exported.
5843 However, leave prepare_to_modify_buffer alone. It's never
5844 called from outside this function, but that appears to be a bug.
5845 (combine_after_change_list, combine_after_change_buffer):
5846 (adjust_after_replace, signal_before_change): Now static.
5847 (adjust_after_replace_noundo): Remove; unused.
5848 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5849 (signal_before_change): Remove decls.
5851 * indent.c (val_compute_motion, val_vmotion): Now static.
5853 * image.c: Make symbols static if they're not exported.
5854 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5856 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5857 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5859 * fringe.c (standard_bitmaps): Now static.
5860 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5862 * frame.c: Make symbols static if they're not exported.
5863 (x_report_frame_params, make_terminal_frame): Now static.
5864 (get_frame_param): Now static, unless HAVE_NS.
5865 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5866 (x_get_resource_string): Remove; not used.
5867 * frame.h (make_terminal_frame, x_report_frame_params):
5868 (x_get_resource_string); Remove decls.
5869 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5870 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5872 * font.c, fontset.c: Make symbols static if they're not exported.
5873 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5874 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5875 * font.c (font_close_object): Now static.
5876 * font.h (font_close_object): Remove.
5877 * fontset.c (FONTSET_OBJLIST): Remove.
5878 (free_realized_fontset) #if-0 the body, which does nothing.
5879 (face_suitable_for_char_p): #if-0, as it's never called.
5880 * fontset.h (face_suitable_for_char_p): Remove decl.
5881 * xfaces.c (face_at_string_position):
5882 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5883 since 0 is always ASCII.
5885 * fns.c (weak_hash_tables): Now static.
5887 * fileio.c: Make symbols static if they're not exported.
5888 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5889 (Vwrite_region_annotation_buffers): Now static.
5891 * eval.c: Make symbols static if they're not exported.
5892 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5893 * lisp.h (backtrace_list): Remove decl.
5895 * emacs.c: Make symbols static if they're not exported.
5896 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5897 (fatal_error_code, fatal_error_signal_hook, standard_args):
5899 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5900 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5901 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5902 * lisp.h (fatal_error_signal_hook): Remove decl.
5903 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5905 * editfns.c: Move a (normally-unused) function to its only use.
5906 * editfns.c, lisp.h (get_operating_system_release): Remove.
5907 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5908 worth the hassle of breaking this out.
5910 * xterm.c: Make symbols static if they're not exported.
5911 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5912 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5913 (x_destroy_window, x_delete_display):
5915 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5916 (x_mouse_leave): Remove; unused.
5917 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5918 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5919 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5921 (x_mouse_leave): Declare only if WINDOWSNT.
5922 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5923 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5926 * ftxfont.c: Make symbols static if they're not exported.
5927 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5929 * font.h (ftxfont_driver): Likewise.
5931 * xfns.c: Make symbols static if they're not exported.
5932 (x_last_font_name, x_display_info_for_name):
5933 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5934 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5935 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5936 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5937 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5938 (last_show_tip_args): Now static.
5939 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5940 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5941 (x_screen_planes): Remove; unused.
5942 * dispextern.h (x_screen_planes): Remove decl.
5944 * dispnew.c: Make symbols static if they're not exported.
5945 * dispextern.h (redraw_garbaged_frames, scrolling):
5946 (increment_row_positions): Remove.
5947 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5948 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5950 (redraw_garbaged_frames): Remove; unused.
5952 * xfaces.c: Make symbols static if they're not exported.
5953 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5955 * xterm.h (defined_color): Remove decls.
5956 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5957 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5958 (menu_face_changed_default, defined_color, free_realized_face):
5959 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5960 (ascii_face_of_lisp_face): Remove; unused.
5962 * xdisp.c: Make symbols static if they're not exported.
5963 * dispextern.h (scratch_glyph_row, window_box_edges):
5964 (glyph_to_pixel_coords, set_cursor_from_row):
5965 (get_next_display_element, set_iterator_to_next):
5966 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5967 (show_mouse_face): Remove decls
5968 * frame.h (message_buf_print): Likewise.
5969 * lisp.h (pop_message, set_message, check_point_in_composition):
5971 * xterm.h (set_vertical_scroll_bar): Likewise.
5972 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5973 (message_buf_print, scratch_glyph_row, displayed_buffer):
5974 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5975 (get_next_display_element, show_mouse_face, window_box_edges):
5976 (frame_to_window_pixel_xy, check_point_in_composition):
5977 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5978 (glyph_to_pixel_coords): Remove; unused.
5980 * dired.c (file_name_completion): Now static.
5982 * dbusbind.c (xd_in_read_queued_messages): Now static.
5984 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5985 * data.c (circular_list_error): Remove.
5987 * commands.h (last_point_position, last_point_position_buffer):
5988 (last_point_position_window): Remove decls.
5989 * keyboard.c: Make these variables static.
5991 * coding.h (coding, code_convert_region, encode_coding_gap):
5993 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5994 (iso_code_class, detect_coding, code_convert_region): Now static.
5995 (encode_coding_gap): Remove; unused.
5997 * chartab.c (chartab_chars, chartab_bits): Now static.
5999 * charset.h (charset_iso_8859_1): Remove decl.
6000 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6003 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6004 * ccl.c (Vccl_program_table): Now static.
6005 (check_ccl_update): Remove; unused.
6007 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6008 * category.h: ... from here.
6009 * category.c (check_category_table, set_category_set): Now static.
6011 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6012 * lisp.h: Remove these decls.
6014 * buffer.c (buffer_count): Remove unused var.
6016 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6017 so that it's not optimized away.
6018 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6019 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6020 exported only to the debugger.
6022 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
6023 * atimer.h (run_all_atimers): Remove; not exported.
6025 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6026 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6027 was inaccessible from Lisp.
6028 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6029 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6031 alloc.c: Import and export fewer symbols, and remove unused items.
6032 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6034 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6035 it's not optimized away by whole-program optimization.
6036 (message_enable_multibyte, free_misc): Remove.
6037 (catchlist, handlerlist, mark_backtrace):
6038 Declare only if BYTE_MARK_STACK.
6039 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6040 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6041 (message_enable_multibyte): Remove decl.
6042 (free_misc, interval_free_list, float_block, float_block_index):
6043 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6044 (cons_free_list, last_marked_index):
6046 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6047 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6048 (mark_backtrace): Define only if BYTE_MARK_STACK.
6049 * xdisp.c (message_enable_multibyte): Now static.
6051 Declare Lisp_Object Q* variables to be 'static' if not exported.
6052 This makes it easier for human readers (and static analyzers)
6053 to see whether these variables are used from other modules.
6054 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6055 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6056 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6057 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6058 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6059 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6060 * xmenu.c, xselect.c:
6061 Declare Q* vars static if they are not used in other modules.
6062 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6063 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6064 Remove decls of unexported vars.
6065 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6067 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6069 Make Emacs functions such as Fatom 'static' by default.
6070 This makes it easier for human readers (and static analyzers)
6071 to see whether these functions can be called from other modules.
6072 DEFUN now defines a static function. To make the function external
6073 so that it can be used in other C modules, use the new macro DEFUE.
6074 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6075 (Finit_image_library):
6076 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6077 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6078 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6079 Remove decls, since these functions are now static.
6080 (Funintern, Fget_internal_run_time): New decls, since these functions
6081 were already external.
6083 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6084 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6085 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6086 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6087 * keyboard.c, keymap.c, lread.c:
6088 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6089 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6090 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6091 Mark functions with DEFUE instead of DEFUN,
6092 if they are used in other modules.
6093 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6094 decls for now-static functions.
6095 * buffer.h (Fdelete_overlay): Remove decl.
6096 * callproc.c (Fgetenv_internal): Mark as internal.
6097 * composite.c (Fremove_list_of_text_properties): Remove decl.
6098 (Fcomposition_get_gstring): New forward static decl.
6099 * composite.h (Fcomposite_get_gstring): Remove decl.
6100 * dired.c (Ffile_attributes): New forward static decl.
6101 * doc.c (Fdocumntation_property): New forward static decl.
6102 * eval.c (Ffetch_bytecode): New forward static decl.
6103 (Funintern): Remove extern decl; now in .h file where it belongs.
6104 * fileio.c (Fmake_symbolic_link): New forward static decl.
6105 * image.c (Finit_image_library): New forward static decl.
6106 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6107 * intervals.h (Fprevious_property_change):
6108 (Fremove_list_of_text_properties): Remove decls.
6109 * keyboard.c (Fthis_command_keys): Remove decl.
6110 (Fcommand_execute): New forward static decl.
6111 * keymap.c (Flookup_key): New forward static decl.
6112 (Fcopy_keymap): Now static.
6113 * keymap.h (Flookup_key): Remove decl.
6114 * process.c (Fget_process): New forward static decl.
6115 (Fprocess_datagram_address): Mark as internal.
6116 * syntax.c (Fsyntax_table_p): New forward static decl.
6117 (skip_chars): Remove duplicate decl.
6118 * textprop.c (Fprevious_property_change): New forward static decl.
6119 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6121 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6122 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6124 * editfns.c (Fformat): Remove unreachable code.
6126 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6128 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6131 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6133 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6134 when at ZV. (Bug#8487)
6136 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6138 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6140 * keyboard.c (parse_tool_bar_item): Likewise.
6141 * sound.c (sound_cleanup, alsa_close): Likewise.
6142 * termcap.c (tgetent): Likewise.
6143 * xfns.c (x_default_font_parameter): Likewise.
6144 * xsettings.c (read_and_apply_settings): Likewise.
6146 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6147 (overrun_check_free): Protoize.
6149 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6151 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6152 since callers should never pass a negative size.
6153 Change the signature to match that of plain 'read' and 'write'; see
6154 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6155 * lisp.h: Update prototypes of emacs_write and emacs_read.
6157 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6159 * xdisp.c (redisplay_window): Don't try to determine the character
6160 position of the scroll margin if the window start point w->startp
6161 is outside the buffer's accessible region. (Bug#8468)
6163 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6165 Fix write-region and its subroutines for buffers > 2GB.
6166 * fileio.c (a_write, e_write): Modify declaration of arguments and
6167 local variables to support buffers larger than 2GB.
6168 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6170 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6171 argument, local variables, and return value.
6173 * lisp.h: Update prototypes of emacs_write and emacs_read.
6175 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6177 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6179 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6181 Fix more problems found by GCC 4.6.0's static checks.
6183 * xdisp.c (vmessage): Use a better test for character truncation.
6185 * charset.c (load_charset_map): <, not <=, for optimization,
6186 and to avoid potential problems with integer overflow.
6187 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6188 * casetab.c (set_identity, shuffle): Likewise.
6189 * editfns.c (Fformat): Likewise.
6190 * syntax.c (skip_chars): Likewise.
6192 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6193 This also lets GCC 4.6.0 generate slightly better loop code.
6195 * callint.c (Fcall_interactively): <, not <=, for optimization.
6196 (Fcall_interactively): Count the number of arguments produced,
6197 not the number of arguments given. This is simpler and lets GCC
6198 4.6.0 generate slightly better code.
6200 * ftfont.c: Distingish more carefully between FcChar8 and char.
6201 The previous code passed unsigned char * to a functions like
6202 strlen and xstrcasecmp that expect char *, which does not
6203 conform to the C standard.
6204 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6205 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6206 char * when the C standard requires it.
6208 * keyboard.c (read_char): Remove unused var.
6210 * eval.c: Port to Windows vsnprintf (Bug#8435).
6212 (SIZE_MAX): Define if the headers do not.
6213 (verror): Do not give up if vsnprintf returns a negative count.
6214 Instead, grow the buffer. This ports to Windows vsnprintf, which
6215 does not conform to C99. Problem reported by Eli Zaretskii.
6216 Also, simplify the allocation scheme, by avoiding the need for
6217 calling realloc, and removing the ALLOCATED variable.
6219 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6221 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6222 But keep the doprint source code for now, as we might revamp it
6223 and use it again (Bug#8435).
6224 * lisp.h (doprnt): Remove.
6225 * Makefile.in (base_obj): Remove doprnt.o.
6226 * deps.mk (doprnt.o): Remove.
6228 error: Print 32- and 64-bit integers portably (Bug#8435).
6229 Without this change, on typical 64-bit hosts error ("...%d...", N)
6230 was used to print both 32- and 64-bit integers N, which relied on
6232 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6234 * lisp.h (error, verror): Mark as printf-like functions.
6235 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6236 Report overflow in size calculations when allocating printf buffer.
6237 Do not truncate output string at its first null byte.
6238 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6239 Truncate the output at a character boundary, since vsnprintf does not
6241 * charset.c (check_iso_charset_parameter): Convert internal
6242 character to string before calling 'error', since %c now has the
6244 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6245 overflow when computing char to be passed to 'error'. Do not
6246 pass Lisp_Object to 'error'; pass the integer instead.
6247 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6248 formatted with plain %d.
6250 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6252 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6254 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6256 * xterm.c (x_catch_errors): Remove duplicate declaration.
6258 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6260 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6262 2011-04-10 Jim Meyering <meyering@redhat.com>
6264 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6265 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6266 return ssize_t not "int", and use size_t as the buffer length.
6267 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6268 * gnutls.h: Update declarations.
6269 * process.c (read_process_output): Use ssize_t, to match.
6270 (send_process): Likewise.
6272 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6274 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6276 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6278 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6279 Use unsigned char, to match FcChar8 type definition.
6281 * xterm.c (handle_one_xevent):
6282 * xmenu.c (create_and_show_popup_menu):
6283 * xselect.c (x_decline_selection_request)
6284 (x_reply_selection_request): Avoid type-punned deref of X events.
6286 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6288 Fix some uses of `int' instead of EMACS_INT.
6289 * search.c (string_match_1, fast_string_match)
6290 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6291 (scan_buffer, find_next_newline_no_quit)
6292 (find_before_next_newline, search_command, Freplace_match)
6293 (Fmatch_data): Make some `int' variables be EMACS_INT.
6295 * xdisp.c (display_count_lines): 3rd argument and return value now
6296 EMACS_INT. All callers changed.
6297 (pint2hrstr): Last argument is now EMACS_INT.
6299 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6300 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6301 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6302 (decode_coding_utf_16, decode_coding_emacs_mule)
6303 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6304 (decode_coding_ccl, decode_coding_charset)
6305 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6306 (decode_coding_iso_2022, decode_coding_emacs_mule)
6307 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6308 <char_offset, last_offset>: Declare EMACS_INT.
6309 (encode_coding_utf_8, encode_coding_utf_16)
6310 (encode_coding_emacs_mule, encode_invocation_designation)
6311 (encode_designation_at_bol, encode_coding_iso_2022)
6312 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6313 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6315 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6316 (encode_invocation_designation): Last argument P_NCHARS is now
6318 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6319 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6321 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6324 * ccl.c (Fccl_execute_on_string): Declare some variables
6327 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6329 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6331 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6333 * process.c (Fformat_network_address): Doc fix.
6335 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6337 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6339 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6341 * keyboard.c (read_char): Call Lisp function help-form-show,
6342 instead of using internal_with_output_to_temp_buffer.
6343 (Qhelp_form_show): New var.
6344 (syms_of_keyboard): Use DEFSYM macro.
6346 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6348 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6350 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6352 * process.c (Flist_processes): Remove to Lisp.
6353 (list_processes_1): Delete.
6355 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6357 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6359 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6361 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6363 Fix more problems found by GCC 4.6.0's static checks.
6365 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6367 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6369 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6371 * xdisp.c (vmessage): Mark as a printf-like function.
6373 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6375 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6377 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6378 printf-like functions.
6379 (tiff_load): Add casts to remove these marks before passing them
6380 to system-supplied API.
6382 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6384 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6385 This avoids several warnings with gcc -Wstrict-overflow.
6386 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6387 directly, rather than having caller test rule sign. This avoids
6388 some unnecessary tests.
6389 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6390 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6391 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6393 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6394 (xfont_open): Avoid unnecessary tests.
6396 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6398 * composite.h, composite.c (composition_gstring_put_cache):
6399 Use EMACS_INT, not int, for length.
6401 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6402 breaking out part of COMPOSITION_DECODE_RULE.
6403 (COMPOSITION_DECODE_RULE): Use it.
6404 * composite.c (get_composition_id): Remove unused local vars,
6405 by using the new macro.
6407 * textprop.c (set_text_properties_1): Change while to do-while,
6408 since the condition is always true at first.
6410 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6411 (interval_deletion_adjustment): Return unsigned value.
6414 * process.c (list_processes_1, create_pty, read_process_output):
6415 (exec_sentinel): Remove vars that were set but not used.
6416 (create_pty): Remove unnecessary "volatile"s.
6417 (Fnetwork_interface_info): Avoid possibility of int overflow.
6418 (read_process_output): Do adaptive read buffering even if carryover.
6419 (read_process_output): Simplify nbytes computation if buffered.
6421 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6423 * syntax.c (scan_words): Remove var that was set but not used.
6424 (update_syntax_table): Use unsigned instead of int.
6426 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6427 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6428 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6430 * print.c (print_error_message): Avoid int overflow.
6432 * font.c (font_list_entities): Redo for clarity,
6433 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6435 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6436 (font_score): Avoid potential overflow in diff calculation.
6438 * fns.c (substring_both): Remove var that is set but not used.
6439 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6441 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6443 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6444 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6445 can always succeed if overflow has undefined behavior.
6447 * search.c (boyer_moore, wordify): Remove vars set but not used.
6448 (wordify): Omit three unnecessary tests.
6450 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6451 All callers changed. This avoids the need for an unused var.
6453 * casefiddle.c (casify_region): Remove var that is set but not used.
6455 * dired.c (file_name_completion): Remove var that is set but not used.
6457 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6459 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6460 (Finsert_file_contents): Remove unnecessary code checking fd.
6462 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6463 Check for integer overflow on size calculations.
6465 * buffer.c (Fprevious_overlay_change): Remove var that is set
6468 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6469 Remove vars that are set but not used.
6470 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6471 (timer_check_2): Mark vars as initialized.
6473 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6475 * image.c (lookup_image): Remove var that is set but not used.
6476 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6478 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6479 that are set but not used.
6481 * xfns.c (make_invisible_cursor): Don't return garbage
6482 if XCreateBitmapFromData fails (Bug#8410).
6484 * xselect.c (x_get_local_selection, x_handle_property_notify):
6485 Remove vars that are set but not used.
6487 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6488 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6490 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6491 Remove var that is set but not used.
6492 (scroll_bar_windows_size): Now size_t, not int.
6493 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6496 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6497 (map_tty_color) [!defined MSDOS]: Likewise.
6499 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6501 * coding.c: Remove vars that are set but not used.
6502 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6503 All callers changed.
6504 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6505 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6506 (decode_coding_charset): Remove vars that are set but not used.
6508 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6509 that is set but not used.
6511 * print.c (print_object): Remove var that is set but not used.
6513 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6514 The gnulib version avoids calling malloc in the usual case,
6515 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6516 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6517 * filelock.c (current_lock_owner): Likewise.
6518 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6519 * sysdep.c: Include allocator.h, careadlinkat.h.
6520 (emacs_no_realloc_allocator): New static constant.
6521 (emacs_readlink): New function.
6522 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6523 ../lib/careadlinkat.h.
6525 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6527 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6528 first non-nil return value).
6530 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6532 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6533 if not defined (Bug#8403).
6535 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6537 * xdisp.c (display_count_lines): Remove parameter `start',
6538 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6539 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6540 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6541 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6542 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6543 and thereabouts. All callers changed.
6544 (get_per_char_metric): Remove parameter `f', unused since
6545 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6547 2011-04-02 Jim Meyering <meyering@redhat.com>
6549 do not dereference NULL upon failed strdup
6550 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6551 (ns_get_family): Likewise.
6553 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6555 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6557 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6559 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6562 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6564 Add lexical binding.
6566 * window.c (Ftemp_output_buffer_show): New fun.
6567 (Fsave_window_excursion):
6568 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6570 * lread.c (lisp_file_lexically_bound_p): New function.
6571 (Fload): Bind Qlexical_binding.
6572 (readevalloop): Remove `evalfun' arg.
6573 Bind Qinternal_interpreter_environment.
6574 (Feval_buffer): Bind Qlexical_binding.
6575 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6577 (syms_of_lread): Declare `lexical-binding'.
6579 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6581 * keyboard.c (eval_dyn): New fun.
6582 (menu_item_eval_property): Use it.
6584 * image.c (parse_image_spec): Use Ffunctionp.
6586 * fns.c (concat, mapcar1): Accept byte-code-functions.
6588 * eval.c (Fsetq): Handle lexical vars.
6589 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6590 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6591 (FletX, Flet): Obey lexical binding.
6592 (Fcommandp): Handle closures.
6593 (Feval): New `lexical' arg.
6594 (eval_sub): New function extracted from Feval. Use it almost
6595 everywhere where Feval was used. Look up vars in lexical env.
6597 (Ffunctionp): Move from subr.el.
6598 (Ffuncall): Handle closures.
6599 (apply_lambda): Remove `eval_flags'.
6600 (funcall_lambda): Handle closures and new byte-code-functions.
6601 (Fspecial_variable_p): New function.
6602 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6603 but without exporting it to Lisp.
6605 * doc.c (Fdocumentation, store_function_docstring):
6606 * data.c (Finteractive_form): Handle closures.
6608 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6611 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6613 (exec_byte_code): New function extracted from Fbyte_code to handle new
6614 calling convention for byte-code-functions. Add new byte-codes.
6616 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6618 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6620 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6622 * xdisp.c (redisplay_internal): Fix prototype.
6624 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6626 * xdisp.c (SCROLL_LIMIT): New macro.
6627 (try_scrolling): Use it when setting scroll_limit.
6628 Limit scrolling to 100 screen lines.
6629 (redisplay_window): Even when falling back on "recentering",
6630 position point in the window according to scroll-conservatively,
6631 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6633 (try_scrolling): When point is above the window, allow searching
6634 as far as scroll_max, or one screenful, to compute vertical
6635 distance from PT to the scroll margin position. This prevents
6636 try_scrolling from unnecessarily failing when
6637 scroll-conservatively is set to a value slightly larger than the
6638 window height. Clean up the case of PT below the margin at bottom
6639 of window: scroll_max can no longer be INT_MAX. When aggressive
6640 scrolling is in use, don't let point enter the opposite scroll
6641 margin as result of the scroll.
6642 (syms_of_xdisp) <scroll-conservatively>: Document the
6643 threshold of 100 lines for never-recentering scrolling.
6645 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6647 * dispextern.h (move_it_by_lines):
6648 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6649 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6650 (message_log_check_duplicate): Remove parameters `prev_bol' and
6651 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6652 (redisplay_internal): Remove parameter `preserve_echo_area',
6653 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6655 * indent.c (Fvertical_motion):
6656 * window.c (window_scroll_pixel_based, Frecenter):
6657 Don't pass `need_y_p' to `move_it_by_lines'.
6659 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6661 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6662 steal a few bits to be more compact.
6663 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6664 Remove unneeded casts.
6666 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6668 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6670 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6671 binding" message (bug#7967).
6673 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6675 Fix more problems found by GCC 4.6.0's static checks.
6677 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6678 Remove unused local var.
6680 * editfns.c (Fmessage_box): Remove unused local var.
6682 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6683 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6684 Omit unused local vars.
6685 * window.c (shrink_windows): Omit unused local var.
6686 * menu.c (digest_single_submenu): Omit unused local var.
6687 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6688 Omit unused local var.
6690 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6691 Don't assume string length fits in int.
6692 (keyremap_step, read_key_sequence): Use size_t for sizes.
6693 (read_key_sequence): Don't check last_real_key_start redundantly.
6695 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6696 instead of alloca (Bug#8344).
6698 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6699 (Fbacktrace_frame): Don't assume nframes fits in int.
6701 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6703 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6706 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6708 * cm.c (calccost): Turn while-do into do-while, for clarity.
6710 * keyboard.c (syms_of_keyboard): Use the same style as later
6711 in this function when indexing through an array. This also
6712 works around GCC bug 48267.
6714 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6716 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6718 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6719 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6721 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6722 This avoids undefined behavior on integer overflow, and is a bit
6723 more convenient anyway since it is compared to a size_t variable.
6725 Variadic C functions now count arguments with size_t, not int.
6726 This avoids an unnecessary limitation on 64-bit machines, which
6727 caused (substring ...) to crash on large vectors (Bug#8344).
6728 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6729 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6730 All variadic functions and their callers changed accordingly.
6731 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6732 * data.c (arith_driver, float_arith_driver): Likewise.
6733 * editfns.c (general_insert_function): Likewise.
6734 * eval.c (struct backtrace.nargs, interactive_p)
6735 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6736 (funcall_lambda, mark_backtrace): Likewise.
6737 * fns.c (concat): Likewise.
6738 * frame.c (x_set_frame_parameters): Likewise.
6739 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6740 0 if not found, not -1. All callers changed.
6742 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6743 (stack_copy_size): Now size_t, not int.
6744 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6746 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6748 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6749 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6750 All callers changed.
6752 * lisp.h (multibyte_char_to_unibyte):
6753 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6754 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6755 * character.h (CHAR_TO_BYTE8):
6756 * cmds.c (internal_self_insert):
6757 * editfns.c (general_insert_function):
6758 * keymap.c (push_key_description):
6759 * search.c (Freplace_match):
6760 * xdisp.c (message_dolog, set_message_1): All callers changed.
6762 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6764 * keyboard.c (safe_run_hook_funcall): New function.
6765 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6766 don't set the hook to nil, but remove the offending function instead.
6767 (Qcommand_hook_internal): Remove, unused.
6768 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6769 Vcommand_hook_internal.
6771 * eval.c (enum run_hooks_condition): Remove.
6772 (funcall_nil, funcall_not): New functions.
6773 (run_hook_with_args): Call each function through a `funcall' argument.
6774 Remove `cond' argument, now redundant.
6775 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6776 (Frun_hook_with_args_until_failure): Adjust accordingly.
6777 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6779 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6781 * dispextern.h (string_buffer_position): Remove declaration.
6783 * print.c (strout): Remove parameter `multibyte', unused since
6784 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6786 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6787 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6788 All callers changed.
6790 * w32.c (_wsa_errlist): Use braces for struct initializers.
6792 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6793 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6794 All callers changed.
6795 (string_buffer_position): Likewise. Also, make static (it's never
6796 used outside xdisp.c).
6797 (cursor_row_p): Remove parameter `w', unused since
6798 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6799 (decode_mode_spec): Remove parameter `precision', introduced during
6800 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6801 All callers changed.
6803 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6805 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6807 2011-03-27 Anders Lindgren <andlind@gmail.com>
6809 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6810 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6811 (ns_update_auto_hide_menu_bar): New functions.
6812 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6813 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6814 ns_constrain_all_frames.
6815 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6816 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6818 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6820 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6822 2011-03-27 Glenn Morris <rgm@gnu.org>
6824 * syssignal.h: Replace RETSIGTYPE with void.
6825 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6826 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6827 Replace SIGTYPE with void everywhere.
6828 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6829 * s/template.h (SIGTYPE): Remove commented out definition.
6831 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6833 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6834 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6836 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6838 * w32.c (read_unc_volume): Use parameter `henum', instead of
6839 global variable `wget_enum_handle'.
6841 * keymap.c (describe_vector): Remove parameters `indices' and
6842 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6843 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6845 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6847 * keyboard.c (timer_check): Remove parameter `do_it_now',
6848 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6849 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6850 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6852 * keyboard.c (read_char):
6853 * w32menu.c (w32_menu_display_help):
6854 * xmenu.c (show_help_event, menu_help_callback):
6855 Adjust calls to `show_help_echo'.
6857 * gtkutil.c (xg_maybe_add_timer):
6858 * keyboard.c (readable_events):
6859 * process.c (wait_reading_process_output):
6860 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6862 * insdel.c (adjust_markers_gap_motion):
6863 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6864 (gap_left, gap_right): Don't call it.
6866 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6868 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6869 incurred during fontification.
6871 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6873 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6874 (DEFVAR_PER_BUFFER): Don't pass it.
6876 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6877 (scrolling_window): Don't pass it.
6879 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6881 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6883 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6885 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6886 of variables specific to SELinux and computation of `encoded_absname'.
6888 * image.c (XPutPixel): Remove unused variable `height'.
6890 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6892 * unexw32.c (get_section_info): Remove unused variable `section'.
6894 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6895 (system_process_attributes): Remove unused variable `sess'.
6896 (sys_read): Remove unused variable `err'.
6898 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6899 (w32_wnd_proc): Remove unused variable `isdead'.
6900 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6901 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6902 (x_create_tip_frame): Remove unused variable `tem'.
6904 * w32inevt.c (w32_console_read_socket):
6905 Remove unused variable `no_events'.
6907 * w32term.c (x_draw_composite_glyph_string_foreground):
6908 Remove unused variable `width'.
6910 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6912 * w32term.c (x_set_glyph_string_clipping):
6913 Don't pass uninitialized region to CombineRgn.
6915 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6917 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6918 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6919 (Fx_close_connection): Remove unused variable `i'.
6921 * w32font.c (w32font_draw): Return number of glyphs.
6922 (w32font_open_internal): Remove unused variable `i'.
6923 (w32font_driver): Add missing initializer.
6925 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6926 (fill_in_menu): Remove unused variable `items_added'.
6928 * w32term.c (last_mouse_press_frame): Remove static global variable.
6929 (w32_clip_to_row): Remove unused variable `f'.
6930 (x_delete_terminal): Remove unused variable `i'.
6932 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6933 (NOTHING): Remove unused static global variable.
6934 (uniscribe_check_otf): Remove unused variable `table'.
6935 (uniscribe_font_driver): Add missing initializers.
6937 2011-03-23 Julien Danjou <julien@danjou.info>
6939 * term.c (Fsuspend_tty, Fresume_tty):
6940 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6941 * window.c (temp_output_buffer_show):
6942 * insdel.c (signal_before_change):
6943 * frame.c (Fhandle_switch_frame):
6944 * fileio.c (Fdo_auto_save):
6945 * emacs.c (Fkill_emacs):
6946 * editfns.c (save_excursion_restore):
6947 * cmds.c (internal_self_insert):
6948 * callint.c (Fcall_interactively):
6949 * buffer.c (Fkill_all_local_variables):
6950 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6952 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6953 unconditionnaly since it does the check itself.
6955 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6957 Fix more problems found by GCC 4.5.2's static checks.
6959 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6960 the first time through the loop, since we know p0 < p1 then.
6961 This also avoids a gcc -Wstrict-overflow warning.
6963 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6964 leading to a memory leak, possible in functions like
6965 load_charset_map_from_file that can allocate an unbounded number
6966 of objects (Bug#8318).
6968 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6969 that could (at least in theory) be that large.
6971 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6972 This is less likely to overflow, and avoids undefined behavior if
6973 overflow does occur. All callers changed. Use strtoul to scan
6974 for the unsigned long integer.
6975 (pint2hrstr): Simplify and tune code slightly.
6976 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6978 * scroll.c (do_scrolling): Work around GCC bug 48228.
6979 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6981 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6982 This also avoids a warning with gcc -Wstrict-overflow.
6983 (validate_x_resource_name): Simplify count usage.
6984 This also avoids a warning with gcc -Wstrict-overflow.
6986 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6989 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6991 * process.c (Fmake_network_process): Use socklen_t, not int,
6992 where POSIX says socklen_t is required in portable programs.
6993 This fixes a porting bug on hosts like 64-bit HP-UX, where
6994 socklen_t is wider than int (Bug#8277).
6995 (Fmake_network_process, server_accept_connection):
6996 (wait_reading_process_output, read_process_output):
6999 * process.c: Rename or move locals to avoid shadowing.
7000 (list_processes_1, Fmake_network_process):
7001 (read_process_output_error_handler, exec_sentinel_error_handler):
7002 Rename or move locals.
7003 (Fmake_network_process): Define label "retry_connect" only if needed.
7004 (Fnetwork_interface_info): Fix pointer signedness.
7005 (process_send_signal): Add cast to avoid pointer signedness problem.
7006 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7007 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7009 Make tparam.h and terminfo.c consistent.
7010 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7011 Include tparam.h instead, since it declares them.
7012 * cm.h (PC): Remove extern decl; tparam.h now does this.
7013 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7014 * terminfo.c: Include tparam.h, to check interfaces.
7015 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7016 (tparam): Adjust signature to match interface in tparam.h;
7017 this removes some undefined behavior. Check that outstring and len
7018 are zero, which they always are with Emacs.
7019 * tparam.h (PC, BC, UP): New extern decls.
7021 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
7022 (xftfont_open): Rename locals to avoid shadowing.
7024 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
7025 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7026 (OTF_TAG_SYM): Omit macro if not needed.
7027 (ftfont_list): Remove unused local.
7028 (get_adstyle_property, ftfont_pattern_entity):
7029 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7030 Rename locals to avoid shadowing.
7032 * xfont.c (xfont_list_family): Mark var as initialized.
7034 * xml.c (make_dom): Now static.
7036 * composite.c (composition_compute_stop_pos): Rename local to
7038 (composition_reseat_it): Remove unused locals.
7039 (find_automatic_composition, composition_adjust_point): Likewise.
7040 (composition_update_it): Mark var as initialized.
7041 (find_automatic_composition): Mark vars as initialized,
7042 with a FIXME (Bug#8290).
7044 character.h: Rename locals to avoid shadowing.
7045 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7046 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7047 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7048 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7051 * textprop.c (property_change_between_p): Remove; unused.
7053 * intervals.c (interval_start_pos): Now static.
7055 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7057 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7058 Rename locals to avoid shadowing.
7060 * sound.c (wav_play, au_play, Fplay_sound_internal):
7061 Fix pointer signedness.
7062 (alsa_choose_format): Remove unused local var.
7063 (wav_play): Initialize a variable to 0, to prevent undefined
7064 behavior (Bug#8278).
7066 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7068 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7070 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7071 clobbering (Bug#8298).
7072 * sysdep.c (sys_subshell): Likewise.
7073 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7075 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7076 This should get cleaned up, so that child_setup has the
7077 same signature on all platforms.
7079 * callproc.c (call_process_cleanup): Now static.
7080 (relocate_fd): Rename locals to avoid shadowing.
7082 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7084 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7085 not to be necessary, and produces flickering.
7087 2011-03-20 Glenn Morris <rgm@gnu.org>
7089 * config.in: Remove file.
7091 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7093 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7094 are now in src/globals.h.
7095 (syms_of_minibuf): Remove spurious & from previous change.
7097 2011-03-20 Leo <sdl.web@gmail.com>
7099 * minibuf.c (completing-read-function): New variable.
7100 (completing-read-default): Rename from completing-read.
7101 (completing-read): Call completing-read-function.
7103 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7105 * xfaces.c (Fx_load_color_file):
7106 Read color file from absolute filename (bug#8250).
7108 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7110 * makefile.w32-in: Update dependencies.
7112 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7114 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7116 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7118 Fix more problems found by GCC 4.5.2's static checks.
7120 * process.c (make_serial_process_unwind, send_process_trap):
7121 (sigchld_handler): Now static.
7123 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7124 That way, the code declares only the vars that it needs.
7125 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7126 * s/cygwin.h (PTY_ITERATION): Likewise.
7127 * s/darwin.h (PTY_ITERATION): Likewise.
7128 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7130 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7131 * process.c (allocate_pty): Don't declare stb unless it's needed.
7133 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7134 (CONSTANTLIM): Remove; unused.
7135 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7136 Define only if needed.
7138 * unexelf.c (unexec): Name an expression,
7139 to avoid gcc -Wbad-function-cast warning.
7140 Use a different way to cause a compilation error if anyone uses
7141 n rather than nn, a way that does not involve shadowing.
7142 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7144 * deps.mk (unexalpha.o): Remove; unused.
7146 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7147 * unexec.h: New file.
7148 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7149 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7151 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7152 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7153 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7154 Change as necessary to match prototype in unexec.h.
7156 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7158 (back_comment, skip_chars): Mark vars as initialized.
7160 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7161 Rename locals to avoid shadowing.
7163 * lread.c (read1): Rewrite so as not to use empty "else".
7164 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7166 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7168 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7169 warning when compiling print.c.
7171 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7172 instead of using an uninitialized var.
7173 (font_sort_entities): Mark var as initialized.
7175 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7177 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7178 pointers to constants.
7179 (font_parse_fcname): Remove unused vars.
7180 (font_delete_unmatched): Now static.
7181 (font_get_spec): Remove; unused.
7182 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7183 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7184 Rename or move locals to avoid shadowing.
7186 * fns.c (require_nesting_list, require_unwind): Now static.
7187 (Ffillarray): Rename locals to avoid shadowing.
7189 * floatfns.c (domain_error2): Define only if needed.
7190 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7192 * alloc.c (mark_backtrace): Move decl from here ...
7193 * lisp.h: ... to here, so that it can be checked.
7195 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7196 (Fdefvar): Rewrite so as not to use empty "else".
7197 (lisp_indirect_variable): Name an expression,
7198 to avoid gcc -Wbad-function-cast warning.
7199 (Fdefvar): Rename locals to avoid shadowing.
7201 * callint.c (quotify_arg, quotify_args): Now static.
7202 (Fcall_interactively): Rename locals to avoid shadowing.
7203 Use const pointer when appropriate.
7205 * lisp.h (get_system_name, get_operating_system_release):
7206 Move decls here, to check interfaces.
7207 * process.c (get_operating_system_release): Move decl to lisp.h.
7208 * xrdb.c (get_system_name): Likewise.
7209 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7210 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7211 some of which prompt warnings from gcc -Wbad-function-cast.
7212 (Fformat_time_string, Fencode_time, Finsert_char):
7213 (Ftranslate_region_internal, Fformat):
7214 Rename or remove local vars to avoid shadowing.
7215 (Ftranslate_region_internal): Mark var as initialized.
7217 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7220 * lisp.h (eassert): Check that the argument compiles, even if
7221 ENABLE_CHECKING is not defined.
7223 * data.c (Findirect_variable): Name an expression, to avoid
7224 gcc -Wbad-function-cast warning.
7225 (default_value, arithcompare, arith_driver, arith_error): Now static.
7226 (store_symval_forwarding): Rename local to avoid shadowing.
7227 (Fmake_variable_buffer_local, Fmake_local_variable):
7228 Mark variables as initialized.
7229 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7231 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7232 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7233 Rename locals to avoid shadowing.
7234 (mark_stack): Move local variables into the #ifdef region where
7236 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7237 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7239 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7240 (GC_STRING_CHARS): Remove; not used.
7241 (Fmemory_limit): Cast sbrk's returned value to char *.
7243 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7244 avoids undefined behavior in theory.
7246 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7248 Use functions, not macros, for up- and down-casing (Bug#8254).
7249 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7250 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7251 to use the following functions instead of these macros.
7252 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7253 EMACS_INT, since callers assume the returned value fits in int.
7254 (upcase1): Likewise, for UPCASE_TABLE.
7255 (uppercasep, lowercasep, upcase): New static inline functions.
7256 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7257 the race-condition problem in the old DOWNCASE.
7259 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7260 Rename locals to avoid shadowing.
7261 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7262 (regex_compile, re_search_2, re_match_2_internal):
7263 Remove unused local vars.
7264 (FREE_VAR): Rewrite so as not to use empty "else",
7265 which gcc can warn about.
7266 (regex_compile, re_match_2_internal): Mark locals as initialized.
7267 (RETALLOC_IF): Define only if needed.
7268 (WORDCHAR_P): Likewise. This one is never needed, but is used
7269 only in a comment talking about a compiler bug, so put inside
7270 the #if 0 of that comment.
7271 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7272 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7275 * search.c (boyer_moore): Rename locals to avoid shadowing.
7276 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7277 (PREV_CHAR_BOUNDARY): Likewise.
7279 * search.c (simple_search): Remove unused var.
7281 * dired.c (compile_pattern): Move decl from here ...
7282 * lisp.h: ... to here, so that it can be checked.
7283 (struct re_registers): New forward decl.
7285 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7287 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7289 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7290 Rename locals to avoid shadowing.
7291 (Fvertical_motion): Mark locals as initialized.
7293 * casefiddle.c (casify_object, casify_region): Now static.
7294 (casify_region): Mark local as initialized.
7296 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7298 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7299 New macros, so that the caller can use some names other than
7300 gcpro1, gcpro2, etc.
7301 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7303 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7304 argument, for consistency with GCPRO2_VAR, etc: it is now the
7305 prefix of the variable, not the variable itself. All uses
7307 * dired.c (directory_files_internal, file_name_completion):
7308 Rename locals to avoid shadowing.
7310 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7311 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7312 dired.c's scmp function, had undefined behavior.
7313 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7314 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7315 * buffer.h: ... to here, because these macros use current_buffer,
7316 and the new implementation with inline functions needs to have
7317 current_buffer in scope now, rather than later when the macros
7319 (downcase, upcase1): New static inline functions.
7320 (DOWNCASE, UPCASE1): Reimplement using these functions.
7321 This avoids undefined behavior in expressions like
7322 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7323 from race conditions in accessing the global variables
7324 case_temp1 and case_temp2.
7325 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7326 * lisp.h (case_temp1, case_temp2): Remove their decls.
7327 * character.h (ASCII_CHAR_P): Move from here ...
7328 * lisp.h: ... to here, so that the inline functions mentioned
7331 * dired.c (directory_files_internal_unwind): Now static.
7333 * fileio.c (file_name_as_directory, directory_file_name):
7334 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7336 (file_name_as_directory): Use const pointers when appropriate.
7337 (Fexpand_file_name): Likewise. In particular, newdir might
7338 point at constant storage, so make it a const pointer.
7339 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7340 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7342 (Fset_file_times, Finsert_file_contents, auto_save_error):
7343 Rename locals to avoid shadowing.
7345 * minibuf.c (choose_minibuf_frame_1): Now static.
7346 (Ftry_completion, Fall_completions): Rename or remove locals
7349 * marker.c (bytepos_to_charpos): Remove; unused.
7351 * lisp.h (verify_bytepos, count_markers): New decls,
7352 so that gcc does not warn that these functions aren't declared.
7354 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7355 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7356 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7357 (copy_text): Remove unused local var.
7359 * filelock.c (within_one_second): Now static.
7360 (lock_file_1): Rename local to avoid shadowing.
7362 * buffer.c (fix_overlays_before): Mark locals as initialized.
7363 (fix_start_end_in_overlays): Likewise. This function should be
7364 simplified by using pointers-to-pointers, but that's a different
7366 (switch_to_buffer_1): Now static.
7367 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7368 (report_overlay_modification): Rename locals to avoid shadowing.
7370 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7371 Fix pointer signedness issue.
7372 (sys_subshell): Mark local as volatile if checking for lint,
7373 to suppress a gcc -Wclobbered warning that does not seem to be right.
7374 (MAXPATHLEN): Define only if needed.
7376 * process.c (serial_open, serial_configure): Move decls from here ...
7377 * systty.h: ... to here, so that they can be checked.
7379 * fns.c (get_random, seed_random): Move extern decls from here ...
7380 * lisp.h: ... to here, so that they can be checked.
7382 * sysdep.c (reset_io): Now static.
7383 (wait_for_termination_signal): Remove; unused.
7385 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7386 (copy_keymap_item, append_key, push_text_char_description):
7388 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7389 (DENSE_TABLE_SIZE): Remove; unused.
7390 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7391 (describe_map_tree):
7392 Rename locals to avoid shadowing.
7394 * keyboard.c: Declare functions static if they are not used elsewhere.
7395 (echo_char, echo_dash, cmd_error, top_level_2):
7396 (poll_for_input, handle_async_input): Now static.
7397 (read_char, kbd_buffer_get_event, make_lispy_position):
7398 (make_lispy_event, make_lispy_movement, apply_modifiers):
7399 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7400 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7401 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7402 (read_key_sequence, read_char): Mark locals as initialized.
7403 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7405 * keyboard.h (make_ctrl_char): New decl.
7406 (mark_kboards): Move decl here ...
7407 * alloc.c (mark_kboards): ... from here.
7409 * lisp.h (force_auto_save_soon): New decl.
7411 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7412 (DEFINE_DUMMY_FUNCTION): New macro.
7413 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7415 (main): Add casts to avoid warnings
7416 if GCC considers string literals to be constants.
7418 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7420 * dbusbind.c: Pointer signedness fixes.
7421 (xd_signature, xd_append_arg, xd_initialize):
7422 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7423 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7424 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7425 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7427 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7428 if GCC considers string literals to be constants.
7429 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7431 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7433 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7434 (print_preprocess, print_object): New macro to fix last change.
7436 * print.c (print_preprocess): Don't forget font objects.
7438 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7440 * emacs.c (USAGE3): Doc fixes.
7442 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7444 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7447 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7449 * lisp.h (VWindow_system, Qfile_name_history):
7450 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7451 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7452 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7454 * w32select.c: Don't #include "keyboard.h".
7455 (run_protected): Add extern declaration for waiting_for_input.
7457 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7458 * w32console.c (detect_input_pending, read_input_pending)
7459 (encode_terminal_code):
7460 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7461 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7462 (w32_system_caret_y, Qfile_name_history):
7463 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7464 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7465 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7466 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7467 * w32proc.c (Qlocal, report_file_error):
7468 * w32term.c (Vwindow_system, updating_frame):
7469 * w32uniscribe.c (initialized, uniscribe_font_driver):
7470 Remove unneeded extern declarations.
7472 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7474 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7476 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7478 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7479 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7480 These macros can no longer be used for assignment.
7482 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7483 Assign struct members directly, instead of using BUF_BEGV etc.
7484 (record_buffer_markers, fetch_buffer_markers): New functions for
7485 recording and fetching special buffer markers.
7486 (set_buffer_internal_1, set_buffer_temp): Use them.
7488 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7490 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7492 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7493 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7495 * xdisp.c (hscroll_window_tree):
7496 (reconsider_clip_changes): Use PT instead of BUF_PT.
7498 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7500 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7501 $(EMACS_ROOT)/lib/intprops.h.
7503 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7505 Fix more problems found by GCC 4.5.2's static checks.
7507 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7508 to unsigned char * to avoid compiler diagnostic.
7509 (xg_free_frame_widgets): Make it clear that a local variable is
7510 needed only if USE_GTK_TOOLTIP.
7511 (gdk_window_get_screen): Make it clear that this macro is needed
7512 only if USE_GTK_TOOLTIP.
7513 (int_gtk_range_get_value): New function, which avoids a diagnostic
7514 from gcc -Wbad-function-cast.
7515 (xg_set_toolkit_scroll_bar_thumb): Use it.
7516 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7517 diagnostic from gcc -Wbad-function-cast.
7518 (get_utf8_string, xg_get_file_with_chooser):
7519 Rename locals to avoid shadowing.
7520 (create_dialog): Move locals to avoid shadowing.
7522 * xgselect.c (xg_select): Remove unused var.
7524 * image.c (four_corners_best): Mark locals as initialized.
7525 (gif_load): Initialize transparent_p to zero (Bug#8238).
7526 Mark another local as initialized.
7527 (my_png_error, my_error_exit): Mark with NO_RETURN.
7529 * image.c (clear_image_cache): Now static.
7530 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7531 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7532 (x_edge_detection): Remove unnecessary cast that
7533 gcc -Wbad-function-cast diagnoses.
7534 (gif_load): Fix pointer signedness.
7535 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7536 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7538 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7540 Improve quality of tests for time stamp overflow.
7541 For example, without this patch (encode-time 0 0 0 1 1
7542 1152921504606846976) returns the obviously-bogus value (-948597
7543 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7544 reports time overflow. See
7545 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7546 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7547 * editfns.c: Include limits.h and intprops.h.
7548 (TIME_T_MIN, TIME_T_MAX): New macros.
7549 (time_overflow): Move earlier, to before first use.
7550 (hi_time, lo_time): New functions, for an accurate test for
7552 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7553 (Fget_internal_run_time): Don't assume time_t fits in int.
7554 (make_time): Use list2 instead of Fcons twice.
7555 (Fdecode_time): More accurate test for out-of-range times.
7556 (check_tm_member): New function.
7557 (Fencode_time): Use it, to test for out-of-range times.
7558 (lisp_time_argument): Don't rely on undefined left-shift and
7559 right-shift behavior when checking for time stamp overflow.
7561 * editfns.c (time_overflow): New function, refactoring common code.
7562 (Fformat_time_string, Fdecode_time, Fencode_time):
7563 (Fcurrent_time_string): Use it.
7565 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7566 * dired.c (make_time): Move to ...
7567 * editfns.c (make_time): ... here.
7568 * systime.h: Note the move.
7570 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7572 * fringe.c (update_window_fringes): Remove unused variables.
7574 * unexmacosx.c (copy_data_segment): Also copy __got section.
7577 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7579 * termcap.c [MSDOS]: Include "msdos.h".
7580 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7581 Constify `char *' arguments and their references according to
7582 prototypes in tparam.h.
7584 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7586 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7587 Adapt all references accordingly.
7589 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7591 2011-03-11 Tom Tromey <tromey@redhat.com>
7593 * buffer.c (syms_of_buffer): Remove obsolete comment.
7595 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7597 * termhooks.h (encode_terminal_code): Declare prototype.
7599 * msdos.c (encode_terminal_code): Don't declare prototype.
7601 * term.c (encode_terminal_code): Now external again, used by
7602 w32console.c and msdos.c.
7604 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7605 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7607 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7609 Fix some minor problems found by GCC 4.5.2's static checks.
7611 * fringe.c (update_window_fringes): Mark locals as initialized
7613 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7615 * alloc.c (mark_fringe_data): Move decl from here ...
7616 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7617 to check its interface.
7618 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7620 * fontset.c (free_realized_fontset): Now static.
7621 (Fset_fontset_font): Rename local to avoid shadowing.
7622 (fontset_font): Mark local as initialized.
7623 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7625 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7627 * xselect.c (x_disown_buffer_selections): Remove; not used.
7628 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7629 (x_own_selection, Fx_disown_selection_internal): Rename locals
7631 (x_handle_dnd_message): Remove local to avoid shadowing.
7633 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7634 so that the caller can use some name other than gcpro1.
7635 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7636 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7637 (Fx_backspace_delete_keys_p):
7638 Use them to avoid shadowing, and rename vars to avoid shadowing.
7639 (x_decode_color, x_set_name, x_window): Now static.
7640 (Fx_create_frame): Add braces to silence GCC warning.
7641 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7642 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7643 Remove unused locals.
7644 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7645 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7646 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7649 * xterm.h (x_mouse_leave): New decl.
7651 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7652 Remove unused functions.
7653 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7654 (x_calc_absolute_position): Now static.
7655 (XTread_socket): Don't define label "out" unless it's used.
7656 Don't declare local "event" unless it's used.
7657 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7658 unless they are used.
7659 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7660 (x_fatal_error_signal): Remove; not used.
7661 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7662 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7663 (x_error_catcher, x_connection_closed, x_error_handler):
7664 (x_error_quitter, xembed_send_message, x_iconify_frame):
7665 (my_log_handler): Rename locals to avoid shadowing.
7666 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7667 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7669 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7670 Rename or move locals to avoid shadowing.
7671 (tty_defined_color, merge_face_heights): Now static.
7672 (free_realized_faces_for_fontset): Remove; not used.
7673 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7674 does not deduce is never used uninitialized.
7675 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7676 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7678 * terminal.c (store_terminal_param): Now static.
7680 * xmenu.c (menu_highlight_callback): Now static.
7681 (set_frame_menubar): Remove unused local.
7682 (xmenu_show): Rename parameter to avoid shadowing.
7683 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7684 since they might point to immutable storage.
7685 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7686 since it's unused otherwise.
7688 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7689 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7690 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7691 avoids a gcc -Wuninitialized diagnostic.
7692 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7693 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7694 does not deduce are never used uninitialized.
7696 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7698 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7699 * window.c (window_loop, size_window):
7700 (run_window_configuration_change_hook, enlarge_window): Likewise.
7702 * window.c (display_buffer): Now static.
7703 (size_window): Mark variables that gcc -Wuninitialized
7704 does not deduce are never used uninitialized.
7705 * window.h (check_all_windows): New decl, to forestall
7706 gcc -Wmissing-prototypes diagnostic.
7707 * dispextern.h (bidi_dump_cached_states): Likewise.
7709 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7711 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7713 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7714 and to avoid gcc -Wuninitialized warning.
7715 (load_charset_map): Mark variables that gcc -Wuninitialized
7716 does not deduce are never used uninitialized.
7717 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7719 * coding.c (coding_set_source, coding_set_destination):
7720 Use "else { /* comment */ }" rather than "else /* comment */;"
7721 for clarity, and to avoid gcc -Wempty-body warning.
7722 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7723 a block, when the outer 'i' will do.
7724 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7725 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7726 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7727 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7728 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7729 Rename locals to avoid shadowing.
7730 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7731 * coding.c (emacs_mule_char, encode_invocation_designation):
7732 Now static, since they're not used elsewhere.
7733 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7734 (decode_coding_object, encode_coding_object, detect_coding_system):
7735 (decode_coding_emacs_mule): Mark variables that gcc
7736 -Wuninitialized does not deduce are never used uninitialized.
7737 (detect_coding_iso_2022): Initialize a local variable that might
7738 be used uninitialized. Leave a FIXME because it's not clear that
7739 this initialization is needed. (Bug#8211)
7740 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7741 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7742 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7743 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7744 Remove unused macros.
7746 * category.c (hash_get_category_set): Remove unused local var.
7747 (copy_category_table): Now static, since it's not used elsewhere.
7748 * character.c (string_count_byte8): Likewise.
7750 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7751 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7753 * chartab.c (copy_sub_char_table): Now static, since it's not used
7755 (sub_char_table_ref_and_range, char_table_ref_and_range):
7756 Rename locals to avoid shadowing.
7757 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7759 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7760 (BIDI_BOB): Remove unused macro.
7762 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7763 deduce are never used uninitialized.
7764 * term.c (encode_terminal_code): Likewise.
7766 * term.c (encode_terminal_code): Now static. Remove unused local.
7768 * tparam.h: New file.
7769 * term.c, tparam.h: Include it.
7770 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7771 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7772 Move these decls to tparam.h, and make them agree with what
7773 is actually in tparam.c. The previous trick of using incompatible
7774 decls in different modules does not conform to the C standard.
7775 All callers of tparam changed to use tparam's actual API.
7776 * tparam.c (tparam1, tparam, tgoto):
7777 Use const pointers where appropriate.
7779 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7780 * cm.h (struct cm): Likewise.
7781 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7782 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7783 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7784 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7785 (turn_on_face, init_tty): Likewise.
7786 * termchar.h (struct tty_display_info): Likewise.
7788 * term.c (term_mouse_position): Rename local to avoid shadowing.
7790 * alloc.c (mark_ttys): Move decl from here ...
7791 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7793 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7795 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7797 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7799 * search.c (compile_pattern_1): Remove argument regp, unused since
7800 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7801 (compile_pattern): Don't pass it.
7803 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7805 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7806 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7808 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7810 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7812 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7813 gdk_window_get_screen, gdk_window_get_geometry,
7814 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7815 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7816 (xg_get_pixbuf_from_pixmap): New function.
7817 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7818 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7819 Call xg_get_pixbuf_from_pixmap instead of
7820 gdk_pixbuf_get_from_drawable.
7821 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7822 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7823 (xg_check_special_colors): Use GtkStyleContext and its functions
7825 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7826 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7827 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7828 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7829 Call gtk_widget_get_preferred_size.
7830 (xg_frame_resized): gdk_window_get_geometry only takes 5
7832 (xg_win_to_widget, xg_event_is_for_menubar):
7833 Call gdk_x11_window_lookup_for_display.
7834 (xg_set_widget_bg): New function.
7835 (delete_cb): New function.
7836 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7837 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7838 (xg_set_background_color): Call xg_set_widget_bg.
7839 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7840 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7841 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7842 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7844 (update_frame_tool_bar): Call gtk_widget_hide.
7845 (xg_initialize): Use GDK_KEY_g.
7847 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7849 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7851 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7852 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7853 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7855 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7857 * w32xfns.c (select_palette): Check success of RealizePalette against
7858 GDI_ERROR, not zero.
7860 See ChangeLog.11 for earlier changes.
7866 Copyright (C) 2011 Free Software Foundation, Inc.
7868 This file is part of GNU Emacs.
7870 GNU Emacs is free software: you can redistribute it and/or modify
7871 it under the terms of the GNU General Public License as published by
7872 the Free Software Foundation, either version 3 of the License, or
7873 (at your option) any later version.
7875 GNU Emacs is distributed in the hope that it will be useful,
7876 but WITHOUT ANY WARRANTY; without even the implied warranty of
7877 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7878 GNU General Public License for more details.
7880 You should have received a copy of the GNU General Public License
7881 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.