1 2012-08-03 Eli Zaretskii <eliz@gnu.org>
3 Support symlinks on latest versions of MS-Windows.
4 * w32.c: Include winioctl.h and aclapi.h.
5 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
6 (revert_to_self): Forward declarations of static functions.
7 <static BOOL g_b_init_get_security_info>:
8 <g_b_init_create_symbolic_link>: New static flags.
9 (globals_of_w32): Initialize them to zero.
10 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
11 (map_w32_filename): Improve commentary. Simplify switch.
12 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
13 headers (most versions of MinGW w32api don't).
14 (get_security_info, create_symbolic_link)
15 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
17 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
18 in the argument file name.
19 (sys_access): Call unc_volume_file_attributes only if
20 GetFileAttributes fails with network-related error codes.
21 (sys_rename): Diagnose renaming of a symlink when the user doesn't
22 have the required privileges.
23 (get_file_security_desc_by_name): Renamed from
24 get_file_security_desc.
25 (stat_worker): New function, with most of the guts of 'stat', and
26 with addition of handling of symlinks and support for 'lstat'. If
27 possible, get file's attributes and security information by
28 handle, not by name. Produce S_IFLNK bit for symlinks, when
30 (stat, lstat): New functions, call 'stat_worker'.
31 (symlink, readlink, careadlinkat): Rewritten to create and resolve
32 symlinks when the underlying filesystem supports them.
34 2012-08-02 Paul Eggert <eggert@cs.ucla.edu>
36 Fix macroexp crash on Windows with debugging (Bug#12118).
37 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
38 checking subscripts; problem introduced with the recent
39 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
40 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
41 since it's used in non-static inline functions now.
43 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
44 Don't assume buffer size fits in 'int'. Remove unused local.
46 Use C99-style 'extern inline' if available.
47 * buffer.h (BUFFER_INLINE):
48 * category.h (CATEGORY_INLINE):
49 * character.h (CHARACTER_INLINE):
50 * charset.h (CHARSET_INLINE):
51 * composite.h (COMPOSITE_INLINE):
52 * dispextern.h (DISPEXTERN_INLINE):
53 * lisp.h (LISP_INLINE):
54 * systime.h (SYSTIME_INLINE):
55 New macro, replacing 'static inline' in this header.
56 * buffer.h, category.h, character.h, charset.h, composite.h:
57 * dispextern.h, lisp.h, systime.h:
58 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
59 * alloc.c (LISP_INLINE):
60 * buffer.c (BUFFER_INLINE):
61 * category.c (CATEGORY_INLINE):
62 * character.c (CHARACTER_INLINE):
63 * charset.c (CHARSET_INLINE):
64 * composite.c (COMPOSITE_INLINE):
65 * dispnew.c (DISPEXTERN_INLINE):
66 * sysdep.c (SYSTIME_INLINE):
67 Define to EXTERN_INLINE, so that the corresponding functions
68 are compiled into code.
69 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
70 (INLINE_HEADER_END): New macros.
71 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
72 since it's used in non-static inline functions now.
73 (VALMASK) [!USE_LSB_TAG]: Likewise.
75 2012-08-02 Glenn Morris <rgm@gnu.org>
77 * s/: Remove empty directory.
79 * s/ms-w32.h: Move to ../nt/inc.
80 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
81 Update for new ms-w32.h location.
83 2012-08-02 Paul Eggert <eggert@cs.ucla.edu>
86 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
88 2012-08-02 Glenn Morris <rgm@gnu.org>
90 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
91 hard-coding the path separator.
93 2012-08-01 Paul Eggert <eggert@cs.ucla.edu>
95 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
96 This how ASET and AREF are supposed to work, and makes
97 it easier to think about future improvements. See
98 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
99 * charset.h (set_charset_attr): New function.
100 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
101 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
102 (aref_addr): New function. All uses of &AREF(...) changed.
103 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
104 (set_hash_index): New functions. All lvalue-style uses of
105 HASH_KEY etc. changed.
106 * keyboard.c (set_prop): New function. All lvalue-style uses
109 2012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
111 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
112 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
113 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
114 * nsfns.m (ns_set_name_as_filename): Likewise.
115 * nsmenu.m (ns_update_menubar): Likewise.
116 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
118 2012-08-01 Eli Zaretskii <eliz@gnu.org>
120 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
121 Adapt to latest changes in field names of the corresponding Lisp
124 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
126 2012-08-01 Glenn Morris <rgm@gnu.org>
128 * s/msdos.h: Remove file.
129 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
130 * Makefile.in (S_FILE): Remove.
131 (config_h): Remove S_FILE.
133 2012-08-01 Juanma Barranquero <lekktu@gmail.com>
135 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
136 Remove; moved to nt/config.nt.
138 2012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
140 Use INTERNAL_FIELD for conses and overlays.
141 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
142 Remove obsolete comment.
144 (struct Lisp_Overlay): Use INTERNAL_FIELD.
145 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
147 2012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
149 Use INTERNAL_FIELD for symbols.
150 * lisp.h (SVAR): New macro. Adjust users.
151 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
152 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
154 2012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
156 Use INTERNAL_FIELD for processes.
157 * process.h (PVAR): New macro. Adjust style.
158 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
159 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
161 2012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
163 Use INTERNAL_FIELD for windows.
164 * window.h (WVAR): New macro.
165 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
166 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
167 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
168 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
169 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
170 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
172 2012-08-01 Paul Eggert <eggert@cs.ucla.edu>
174 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
176 2012-08-01 Glenn Morris <rgm@gnu.org>
178 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
179 Move to configure.ac.
181 2012-08-01 Juanma Barranquero <lekktu@gmail.com>
183 * makefile.w32-in (CONFIG_H): Update dependencies.
184 (CONF_POST_H): New macro.
186 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
188 2012-07-31 Glenn Morris <rgm@gnu.org>
190 * Makefile.in (S_FILE): No longer set by configure.
192 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
194 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
196 * process.h (NULL_DEVICE):
198 * editfns.c (USER_FULL_NAME): Let configure set them.
200 * s/README, s/template.h: Remove files.
202 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
204 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
205 Move to configure.ac.
207 2012-07-31 Eli Zaretskii <eliz@gnu.org>
209 * .gdbinit (xframe): Adapt to introduction of FVAR and the
210 resulting renaming of 'struct frame' members.
212 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
214 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
215 after introduction of FVAR.
217 2012-07-31 Jan Djärv <jan.h.d@swipnet.se>
219 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
221 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
222 instead of compositeToPoint.
223 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
225 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
227 2012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
229 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
230 * lisp.h (INTERNAL_FIELD): New macro.
231 * buffer.h (BUFFER_INTERNAL_FIELD): Removed.
232 (BVAR): Change to use INTERNAL_FIELD.
233 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
234 (KVAR): Change to use INTERNAL_FIELD.
235 * frame.h (FVAR): New macro.
236 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
237 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
238 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
239 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
240 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
242 2012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
244 Miscellaneous fixes for non-default X toolkits.
245 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
246 * xterm.c (x_frame_of_widget): Remove redundant prototype.
247 Move under #ifdef USE_LUCID.
248 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
249 definition and usage to avoid warnings.
251 2012-07-31 Jan Djärv <jan.h.d@swipnet.se>
253 * nsterm.m (openFiles): Fix previous checkin.
255 2012-07-31 Paul Eggert <eggert@cs.ucla.edu>
257 * indent.c (compute_motion): Remove unused local.
259 2012-07-31 Glenn Morris <rgm@gnu.org>
261 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
263 * conf_post.h [USG5_4]:
264 Move remaining contents of s/usg5-4-common.h here.
265 * s/usg5-4-common.h: Remove file.
267 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
268 * s/irix6-5.h: Remove file.
270 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
271 * s/darwin.h: Remove file.
273 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
274 * s/hpux10-20.h: Remove file, which is now empty.
276 2012-07-30 Glenn Morris <rgm@gnu.org>
278 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
279 * Makefile.in (config_h): Add conf_post.h.
280 * makefile.w32-in (CONFIG_H): Add conf_post.h.
282 2012-07-30 Jan Djärv <jan.h.d@swipnet.se>
284 * nsterm.m (ns_do_open_file): New variable.
285 (ns_term_init): Set ns_do_open_file to YES after run returns.
286 (openFile, openTempFile, openFileWithoutUI, openFiles): Open
287 files only if ns_do_open_file.
289 2012-07-30 Paul Eggert <eggert@cs.ucla.edu>
291 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
292 This no-op macro hasn't been needed for many years.
293 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
295 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
296 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
297 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
298 gdb_make_enums_visible.
299 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
300 (DIRECTORY_SEP): Now a constant, not a macro.
302 2012-07-30 Eli Zaretskii <eliz@gnu.org>
304 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
305 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
307 * w32term.c <w32_keyboard_codepage>: Renamed from
308 keyboard_codepage and now external. All users changed.
310 * w32term.h: Add declaration of w32_keyboard_codepage.
312 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
313 the codepage to translate keys to Unicode. If this argument is
314 -1, use the value returned by GetConsoleCP. All callers changed.
316 2012-07-30 Paul Eggert <eggert@cs.ucla.edu>
318 Update .PHONY listings in makefiles.
319 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
320 bootstrap-clean, distclean, maintainer-clean, versioclean,
323 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
324 This is a bit clearer. Fix some commentary typos.
326 2012-07-30 Glenn Morris <rgm@gnu.org>
328 * s/netbsd.h: Let configure include signal.h if needed.
329 Remove file, which is now empty.
331 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
332 Let configure set them.
333 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
334 No more need to undefine.
336 2012-07-30 Andreas Schwab <schwab@linux-m68k.org>
338 * keymap.c (Fkey_description): Don't remove 0x80 bit from
339 non-single-byte char when adding meta modifier. (Bug#12090)
341 2012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
343 Convert safe_call to use variable number of arguments.
344 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
345 (safe_call2): Fix comment.
346 * lisp.h (safe_call): Adjust prototype.
347 * coding.c (encode_coding_object): Change to use safe_call2.
348 * xfaces.c (merge_face_heights): Change to use safe_call1.
350 2012-07-30 Glenn Morris <rgm@gnu.org>
352 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
353 does that unconditionally. Remove file, which is now empty.
355 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
358 2012-07-30 Paul Eggert <eggert@cs.ucla.edu>
360 Export to GDB most of lisp.h's remaining object-like macros.
361 * lisp.h (min, max): Move earlier, because they're used earlier now.
362 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
363 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
364 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
365 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
366 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
367 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
368 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
369 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
370 Now constants, for GDB. They need not be macros.
371 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
372 Now constants, for GDB, as well as macros, for static initializers.
373 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
374 Move to after the definition of struct Lisp_Char_Table,
375 since the former now needs that type defined.
376 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
377 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
378 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
379 New enums, for gdb_make_enums_visible.
380 (GLYPH_MODE_LINE_FACE): Remove; unused.
381 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
382 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
383 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
384 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
385 enum maxargs, enum MAX_ALLOCA.
386 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
387 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
388 no longer needed, now that they are done in lisp.h.
390 2012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
392 Cleanup string bytes checking.
393 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
394 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
395 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
396 (check_sblock, compact_small_strings): Simplify.
398 2012-07-29 Paul Eggert <eggert@cs.ucla.edu>
400 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
401 These macros are confusing and no longer need to be defined, as
402 the enum values now suffice. All uses replaced with definiens.
403 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
405 2012-07-29 Juanma Barranquero <lekktu@gmail.com>
407 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
408 ($(BLD)/w32console.$(O)): Update dependencies.
410 2012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
412 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
413 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
415 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
417 2012-07-29 Jan Djärv <jan.h.d@swipnet.se>
419 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
420 setting sitelisp (Bug#12010).
422 2012-07-29 Eli Zaretskii <eliz@gnu.org>
424 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
426 * w32heap.c (cache_system_info):
427 * w32.c (sys_rename):
428 * w32proc.c (find_child_console, sys_kill): All users changed.
430 2012-07-29 Paul Eggert <eggert@cs.ucla.edu>
432 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
434 2012-07-29 Eli Zaretskii <eliz@gnu.org>
436 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
438 2012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
440 Cleanup statistics calculation in Fgarbage_collect.
441 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
442 zombies percentage calculation. Simplify elapsed time calculation.
444 2012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
446 Generalize marker debugging code under MARKER_DEBUG and use eassert.
447 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
448 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
449 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
450 (replace_range, replace_range_2, del_range_2): Change to eassert.
451 * marker.c (byte_char_debug_check): Adjust style.
453 2012-07-29 Paul Eggert <eggert@cs.ucla.edu>
455 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
456 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
457 long-ago-commented-out code that talks about "WIN32".
458 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
461 2012-07-28 Paul Eggert <eggert@cs.ucla.edu>
463 Use Gnulib stdalign module (Bug#9772, Bug#9960).
464 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
465 Simplify by using alignof.
466 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
467 * lisp.h: Include <stdalign.h>.
468 (GCALIGNMENT): New macro and constant.
469 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
470 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
471 (stdalign): New macro, if not already defined.
473 2012-07-28 Eli Zaretskii <eliz@gnu.org>
475 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
476 * w32inevt.c: Include w32inevt.h.
477 (w32_read_console_input): New inline function, calls either
478 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
479 w32_console_unicode_input.
480 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
481 (w32_kbd_patch_key, key_event): Use the codepage returned by
482 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
483 (key_event): use uChar.UnicodeChar only if
484 w32_console_unicode_input is non-zero.
486 * w32console.c: Include w32heap.h.
487 <w32_console_unicode_input>: New global variable.
488 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
489 family of Windows, zero otherwise.
491 * w32inevt.h: Declare w32_console_unicode_input.
493 * xdisp.c (init_iterator): Don't reference tip_frame in a build
494 --without-x. (Bug#11742)
496 2012-07-27 Paul Eggert <eggert@cs.ucla.edu>
498 Adjust GDB to reflect pvec_type changes (Bug#12036).
499 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
500 2012-07-04 changes to pseudovector representation. Problem
501 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
503 2012-07-27 Michael Albinus <michael.albinus@gmx.de>
505 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
507 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
509 2012-07-27 Eli Zaretskii <eliz@gnu.org>
511 * alloc.c (listn): Fix the order the arguments are consed onto the
514 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
515 enumeration constants, as PURE and HEAP are too general, and clash
516 with other headers and sources, such as gmalloc.c and the
517 MS-Windows system headers. All users changed.
519 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
521 Revert last save_excursion_save and save_excursion_restore changes.
522 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
523 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
525 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
527 Fix recently-introduced typos in Windows port.
528 Reported by Martin Rudalics <rudalics@gmx.at>.
529 * w32.c (init_environment): Replace comma with semicolon.
530 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
532 2012-07-27 Paul Eggert <eggert@cs.ucla.edu>
534 Improve GDB symbol export (Bug#12036).
535 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
536 arms of an 'if', not using conditional expressions; otherwise GDB
537 complains about the types in the unevaluated arm when the argument
538 is an integer literal.
539 (xgetint): Simplify expression.
540 * alloc.c (gdb_make_enums_visible): New constant. This ports to
541 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
542 Zaretskii in <http://bugs.gnu.org/12036#13>.
543 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
544 needed now that we have gdb_make_enums_visible.
545 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
546 (enum enum_USE_LSB_TAG):
547 New enum types, packaging up enums that need to be exported to GDB.
549 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
551 Utility function to make a list from specified amount of objects.
552 * lisp.h (enum constype): New datatype.
553 (listn): New prototype.
554 * alloc.c (listn): New function.
555 (Fmemory_use_count, syms_of_alloc): Use it.
556 * buffer.c (syms_of_buffer): Likewise.
557 * callint.c (syms_of_callint): Likewise.
558 * charset.c (define_charset_internal): Likewise.
559 * coding.c (syms_of_coding): Likewise.
560 * keymap.c (syms_of_keymap): Likewise.
561 * search.c (syms_of_search): Likewise.
562 * syntax.c (syms_of_syntax): Likewise.
563 * w32.c (init_environment): Likewise.
564 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
565 * xdisp.c (syms_of_xdisp): Likewise.
566 * xfns.c (syms_of_xfns): Likewise.
568 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
570 Fast save_excursion_save and save_excursion_restore.
571 * lisp.h (struct Lisp_Excursion): New data type.
572 (PVEC_EXCURSION): New pseudovector type.
573 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
574 to deal with it. Adjust comments.
575 (init_marker, attach_marker): New prototype.
576 (unchain_marker): Adjust prototype.
577 * marker.c (attach_marker): Change to global.
578 (init_marker): New function.
579 * alloc.c (Fmake_marker, build_marker): Use it.
580 (build_marker): More easserts.
581 (mark_object): Handle struct Lisp_Excursion.
582 * editfns.c (save_excursion_save, save_excursion_restore):
583 Reimplement to use struct Lisp_Excursion. Add comments.
585 2012-07-26 Paul Eggert <eggert@cs.ucla.edu>
587 Fix export of symbols to GDB (Bug#12036).
588 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
589 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
590 emacs.c, as this is a more-suitable home. Had this been done earlier
591 the fix for 12036 would have avoided some of the problems noted in
592 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
593 would have been more obvious.
594 * emacs.c: Do not include <verify.h>; no longer needed.
595 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
596 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
597 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
598 Remove; now done in lisp.h.
599 * lisp.h (PUBLISH_TO_GDB): New macro.
600 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
601 (DATA_SEG_BITS): Use it.
602 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
603 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
604 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
605 not be usable in #if. This simplifies things.
607 2012-07-26 Juanma Barranquero <lekktu@gmail.com>
609 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
611 2012-07-26 Paul Eggert <eggert@cs.ucla.edu>
613 Simplify export of symbols to GDB (Bug#12036).
614 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
615 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
616 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
617 Adjust to changes in lisp.h and emacs.c, by using
618 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
619 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
620 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
621 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
622 instead of gdb_valbits.
623 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
624 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
625 instead of gdb_array_mark_flag.
626 (xboolvector): Get size from $->size, not $->header.size.
627 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
628 (xreload, hook-run, hookpost-run): Remove.
629 * emacs.c: Include <verify.h>.
630 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
631 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
633 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
634 (gdb_USE_LSB_TAG): New enum constants.
635 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
636 Also define these as enum constants, so they're visible to GDB.
637 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
638 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
639 as constants, so they're visible to GDB.
640 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
641 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
642 Now enum constants, not macros, so they're visible to GDB.
643 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
644 more convenient now. All uses changed.
645 (VALMASK) [USE_LSB_TAG]: Also define in this case.
646 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
648 2012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
650 Explicitly free restriction data that are not needed anymore.
651 * editfns.c (save_restriction_restore): Free restriction data.
653 2012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
655 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
656 add argument, tune behavior, and adjust all callers.
658 2012-07-25 Paul Eggert <eggert@cs.ucla.edu>
660 Use typedef for EMACS_INT, EMACS_UINT.
661 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
662 than macros. This simplifies debugging in the usual case, since
663 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
664 and it allows expressions involving EMACS_INT casts.
665 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
667 2012-07-25 Jan Djärv <jan.h.d@swipnet.se>
669 * nsterm.m (ns_read_socket): Return early if there is a modal
672 2012-07-25 Martin Rudalics <rudalics@gmx.at>
674 * frame.c (Fredirect_frame_focus): In doc-string don't mention
675 that FOCUS-FRAME can be omitted.
677 2012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
679 Adjust buffer text indirection counters at the end of Fkill_buffer.
680 * buffer.c (Fkill_buffer): Adjust indirection counters when the
681 buffer is definitely dead. This should really fix an issue reported
682 by Christoph Scholtes again. (Bug#12007).
683 (init_buffer_once): Initialize indirection counters of
684 buffer_defaults and buffer_local_symbols (for sanity and safety).
686 2012-07-24 Eli Zaretskii <eliz@gnu.org>
688 * xdisp.c (init_iterator): Don't compute dimensions of truncation
689 and continuation glyphs on tooltip frames, leave them at zero.
690 Avoids continued lines in tooltips. (Bug#11832)
692 2012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
694 Simplify copy_overlay.
695 * buffer.c (copy_overlay): Simplify. Use build_marker.
696 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
698 2012-07-23 Eli Zaretskii <eliz@gnu.org>
700 * print.c (print_object): Don't crash when a frame's name is nil
701 or invalid. (Bug#12025)
703 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
704 it signals an error when a tooltip frame is being created.
706 2012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
708 Cleanup miscellaneous objects allocation and initialization.
709 * alloc.c (allocate_misc): Change to static. Add argument to
710 specify the subtype. Adjust comment and users.
711 (build_overlay): New function.
712 * buffer.c (copy_overlays, Fmake_overlay): Use it.
713 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
714 (allocate_misc): Remove prototype.
715 (build_overlay): Add prototype.
717 2012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
719 Swap buffer text indirection counters in Fbuffer_swap_text.
720 * buffer.c (Fbuffer_swap_text): Swap indirections too.
721 This avoids crash reported by Christoph Scholtes at
722 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
724 2012-07-22 Jan Djärv <jan.h.d@swipnet.se>
726 * nsmenu.m (Popdown_data): New struct.
727 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
729 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
730 (initWithContentRect): Make imgView and contentView non-static
731 and autorelease them. Also autorelease img and matrix (Bug#12005).
732 (dealloc): Remove (Bug#12005).
734 2012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
736 Adjust consing_since_gc when objects are explicitly freed.
737 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
738 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
739 (free_cons, free_misc): Subtract object size from consing_since_gc.
741 2012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
743 Simplify and cleanup markers positioning code.
744 * marker.c (attach_marker): More useful eassert.
745 (live_buffer, set_marker_internal): New function.
746 (Fset_marker, set_marker_restricted): Use set_marker_internal.
747 (set_marker_both, set_marker_restricted_both): Use live_buffer.
749 2012-07-22 Paul Eggert <eggert@cs.ucla.edu>
751 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
752 as it's limited by the amount of memory, not by INT_MAX.
754 2012-07-21 Eli Zaretskii <eliz@gnu.org>
756 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
757 in special-event-map. See the discussion at
758 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
761 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
762 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
763 Fabrice Popineau <fabrice.popineau@supelec.fr>.
765 2012-07-21 Jan Djärv <jan.h.d@swipnet.se>
767 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
768 (conversationIdentifier): Return value is NSInteger.
769 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
771 2012-07-21 Chong Yidong <cyd@gnu.org>
773 * window.c (decode_any_window): Signal an error if the window is
774 on a dead frame (Bug#11984).
776 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
778 Add indirection counting to speed up Fkill_buffer.
779 * buffer.h (struct buffer): New member.
780 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
781 (Fmake_indirect_buffer): Set indirection counter to -1, increment
782 base buffer indirection counter.
783 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
784 (Fkill_buffer): Adjust indirection counters as needed, don't walk
785 through buffer list if indirection counter is 0.
787 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
789 Extend the value returned by Fgarbage_collect with heap statistics.
790 * alloc.c (Qheap): New symbol.
791 (syms_of_alloc): DEFSYM it.
792 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
793 (Fmemory_free): Remove.
794 (syms_of_alloc): Don't defsubr it.
795 * buffer.c (Fcompact_buffer): Remove.
796 (syms_of_buffer): Don't defsubr it.
798 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
800 Make maybe_gc inline.
801 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
802 * lisp.h (consing_since_gc, gc_relative_threshold)
803 (memory_full_cons_threshold): Revert declaration.
804 (maybe_gc): Remove prototype, define as inline.
805 * alloc.c: Remove old commented-out code.
806 (consing_since_gc, gc_relative_threshold)
807 (memory_full_cons_threshold): Revert to global.
810 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
812 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
813 * lisp.h (build_unibyte_string): New function.
814 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
815 * sysdep.c, w32fns.c, xfns.c: Use it.
816 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
817 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
818 Adjust users accordingly.
819 * font.h (font_open_by_name): Adjust prototype.
821 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
823 Cleanup calls to Fgarbage_collect.
824 * lisp.h (maybe_gc): New prototype.
825 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
827 * alloc.c (maybe_gc): New function.
828 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
830 * bytecode.c (MAYBE_GC): Use maybe_gc.
831 * eval.c (eval_sub, Ffuncall): Likewise.
832 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
833 to avoid dependency from auto-save feature.
835 2012-07-19 Paul Eggert <eggert@cs.ucla.edu>
837 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
838 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
839 'for_each_per_buffer_object_at'.
840 All uses changed. It's better to use upper-case for macros that
841 cannot be implemented as functions, to give the reader a clue
842 that they're special.
844 2012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
846 * alloc.c (Fgarbage_collect): Tweak docstring.
848 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
850 Tweak the value returned from Fgarbage_collect again.
851 * alloc.c (Fgarbage_collect): New return value, as confirmed in
852 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
853 Adjust documentation.
854 (total_vector_bytes): Rename to total_vector_slots, adjust
856 (total_free_vector_bytes): Rename to total_free_vector_slots,
858 (Qstring_bytes, Qvector_slots): New symbols.
859 (syms_of_alloc): DEFSYM them.
861 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
863 Buffer compaction primitive which may be used from Lisp.
864 * buffer.c (compact_buffer, Fcompact_buffer): New function.
865 (syms_of_buffer): Register Fcompact_buffer.
866 * alloc.c (Fgarbage_collect): Use compact_buffer.
867 * buffer.h (compact_buffer): New prototype.
868 (struct buffer_text): New member.
870 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
872 New macro to iterate over all buffers, miscellaneous cleanups.
873 * lisp.h (all_buffers): Remove declaration.
874 * buffer.h (all_buffers): Add declaration, with comment.
875 (for_each_buffer): New macro.
876 * alloc.c (Fgarbage_collect, mark_object): Use it.
877 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
878 (init_buffer): Likewise.
879 * data.c (Fset_default): Likewise.
880 * coding.c (code_conversion_restore): Remove redundant check
882 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
884 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
886 Fix bug that created negative-length intervals.
887 * intervals.c (merge_interval_right, merge_interval_left):
888 Do not zero out this interval if it is absorbed by its children,
889 as this interval's total length doesn't change in that case. See
890 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
892 2012-07-18 Paul Eggert <eggert@cs.ucla.edu>
894 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
895 when invoking (make-bool-vector N t) and N is a positive
896 multiple of 8 -- the last 8 bits were mistakenly cleared.
898 Remove some struct layout assumptions in bool vectors.
899 * alloc.c (bool_header_size): New constant.
900 (header_size, word_size): Move earlier, as they're now used earlier.
901 Use 'word_size' in a few more places, where it's appropriate.
902 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
903 padding before the data member of a bool vector.
904 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
905 than doing the check by hand with an abort ().
907 2012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
909 * eval.c (Fdefvar): Don't check constants since we only set the var if
910 it's not yet defined anyway (bug#11904).
912 * lisp.h (last_undo_boundary): Declare new var.
913 * keyboard.c (command_loop_1): Set it.
914 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
915 were auto-added by the command loop (bug#11774).
917 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
919 * w32font.c (Qsymbol): Remove local definition.
920 (syms_of_w32font): Don't DEFSYM it.
922 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
924 Fix sweep_vectors to handle large bool vectors correctly.
925 * alloc.c (sweep_vectors): Account total_vector_bytes for
926 bool vectors larger than VBLOCK_BYTES_MAX.
928 2012-07-18 Chong Yidong <cyd@gnu.org>
930 * frame.c (x_set_frame_parameters): Revert bogus change introduced
931 in 2012-05-25 commit by Paul Eggert (Bug#11738).
933 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
935 Return more descriptive data from Fgarbage_collect.
936 Suggested by Stefan Monnier in
937 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
938 * alloc.c (bounded_number): New function.
939 (total_buffers, total_vectors): New variable.
940 (total_string_size): Rename to total_string_bytes, adjust users.
941 (total_vector_size): Rename to total_vector_bytes, adjust users.
942 (sweep_vectors): Account total_vectors and total_vector_bytes.
943 (Fgarbage_collect): New return value. Adjust documentation.
944 (gc_sweep): Account total_buffers.
945 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
946 (VECTOR_SIZE): Remove.
947 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
948 (Qinterval, Qmisc): New symbols.
949 (syms_of_data): Initialize them.
950 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
951 (Qcons, Qbuffer): New declarations.
953 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
955 * alloc.c (Fmemory_free): Account for memory-free's own storage.
956 Round up, not down. Improve doc.
958 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
960 Restore old code in allocate_string_data to avoid Faset breakage.
961 Reported by Julien Danjou <julien@danjou.info> in
962 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
963 * alloc.c (allocate_string_data): Restore old code with minor
964 adjustments, fix comment to explain this subtle issue.
966 2012-07-17 Eli Zaretskii <eliz@gnu.org>
968 Remove FILE_SYSTEM_CASE.
969 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
971 * fileio.c (FILE_SYSTEM_CASE): Don't define.
972 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
973 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
974 call-process-region passes it through expand-file-name.
976 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
978 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
980 Fix crash when creating indirect buffer (Bug#11917)
981 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
982 Don't handle unbound variables specially if non-zero.
983 (Fbuffer_local_variables): Pass zero.
984 (clone_per_buffer_values): Pass non-zero.
986 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
988 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
989 to make the loop interruptible.
991 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
993 * gnutls.c (emacs_gnutls_handshake): Only retry if
994 GNUTLS_E_INTERRUPTED.
996 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
998 Cleanup and convert miscellaneous checks to eassert.
999 * alloc.c (mark_interval): Fix comment, partially rephrase
1000 old comment from intervals.h (see below).
1001 * intervals.c (find_interval, adjust_intervals_for_insertion)
1002 (delete_interval, adjust_intervals_for_deletion)
1003 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
1005 (adjust_intervals_for_insertion, make_new_interval):
1006 Remove obsolete and unused code.
1007 * intervals.h (struct interval): Remove obsolete comment.
1008 * textprotp.c (erase_properties): Remove unused code.
1009 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
1010 (Fremove_list_of_text_properties): Convert to eassert.
1012 2012-07-17 Chong Yidong <cyd@gnu.org>
1014 * editfns.c (Finsert_char): Doc fix.
1016 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1018 Fix previous change to make Fmemory_free always accurate.
1019 * alloc.c (make_interval): Update total_free_intervals.
1020 (make_float): Likewise for total_free_floats.
1021 (free_cons, Fcons): Likewise for total_free_conses.
1022 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
1023 Likewise for total_free_vector_bytes.
1024 (Fmake_symbol): Likewise for total_free_symbols.
1025 (bytes_free): Remove.
1027 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1029 Simple free memory accounting feature.
1030 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
1031 (sweep_vectors): Accumulate size of free vectors.
1032 (Fgarbage_collect): Setup bytes_free.
1033 (Fmemory_free): New function.
1034 (syms_of_alloc): Register it.
1036 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1038 Cleanup overlays checking.
1039 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
1040 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
1041 eassert and OVERLAYP.
1042 (sort_overlays): Change to use OVERLAYP.
1044 2012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
1046 * editfns.c (Finsert_char): Make it interactive, and make the
1047 second arg optional. Copy interactive spec and docstring from
1050 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1052 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
1053 Unlike the other wrapped functions, fabs has an unspecified
1056 2012-07-16 Jan Djärv <jan.h.d@swipnet.se>
1058 * nsterm.m (keyDown): Interpret flags without left/right bits
1059 as the left key (Bug#11670).
1061 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1063 Remove empty and useless init functions.
1064 * lisp.h (init_character_once, init_fns, init_image)
1065 (init_filelock, init_sound): Remove prototype.
1066 * character.c (init_character_once): Remove.
1067 * filelock.c (init_filelock): Likewise.
1068 * fns.c (init_fns): Likewise.
1069 * image.c (init_image): Likewise.
1070 * sound.c (init_sound): Likewise.
1071 * emacs.c (main): Adjust accordingly.
1073 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1075 * gtkutil.h: Tiny cleanups.
1076 (use_old_gtk_file_dialog): Remove useless declaration.
1077 (xg_uses_old_file_dialog): Add suggested const attribute.
1079 2012-07-15 Eli Zaretskii <eliz@gnu.org>
1081 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
1082 (bidi_paragraph_init): Use it to limit search forward for a strong
1083 directional character in abnormally large paragraphs full of
1084 neutral or weak characters. (Bug#11943)
1086 2012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
1088 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
1089 the toolbar (Bug#9451).
1090 (xg_make_tool_item): Give the widget event box a transparent
1093 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1095 Cleanup basic allocation variables and functions.
1096 * alloc.c (ignore_warnings, init_intervals, init_float)
1097 (init_cons, init_symbol, init_marker): Remove.
1098 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
1099 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
1100 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
1101 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
1102 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
1103 (staticidx, init_alloc_once, init_strings, free_ablock):
1104 Remove redundant initialization.
1105 * fns.c (init_weak_hash_tables): Remove.
1106 * lisp.h (init_weak_hash_tables): Remove prototype.
1108 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1110 Use zero_vector where appropriate.
1111 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
1113 * lisp.h (zero_vector): New declaration.
1114 * font.c (null_vector): Remove.
1115 (syms_of_font): Remove initialization and staticpro.
1116 (font_list_entities, font_find_for_lface): Change to use zero_vector.
1117 * keymap.c (Faccessible_keymaps): Likewise.
1119 2012-07-15 Leo Liu <sdl.web@gmail.com>
1121 * fringe.c: Fix typo in comments.
1123 2012-07-14 Leo Liu <sdl.web@gmail.com>
1125 * fringe.c: Add a new bitmap exclamation-mark.
1127 2012-07-14 Eli Zaretskii <eliz@gnu.org>
1129 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
1131 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
1132 (HAVE_MENUS): Don't define, defined by editing config.in with
1134 (GMALLOC_INHIBIT_VALLOC): Don't define.
1135 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
1137 2012-07-14 Juanma Barranquero <lekktu@gmail.com>
1139 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
1141 2012-07-14 Glenn Morris <rgm@gnu.org>
1143 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
1144 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
1145 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
1147 2012-07-13 Glenn Morris <rgm@gnu.org>
1149 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
1151 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
1152 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
1154 2012-07-13 Jan Djärv <jan.h.d@swipnet.se>
1156 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
1157 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
1158 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
1159 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
1161 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
1162 as boolean expression.
1163 (x_set_window_size): Remove unused variable toolbar.
1164 (ns_get_color_default, ns_mod_to_lisp): Remove.
1165 (ns_mouse_position): Remove unused variables xchar and ychar.
1166 (ns_compute_glyph_string_overhangs): Remove unused variable face.
1167 (ns_set_vertical_scroll_bar): Remove unused variable count.
1168 (ns_delete_terminal): Remove unused variable i.
1169 (ns_term_init): Remove unused variables r, g and b.
1170 (mouseDown): Remove unused variable window.
1171 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
1172 (initFrameFromEmacs): Remove unused variable vbextra.
1173 (mouseEntered): Remove unused variables p and dpyinfo.
1174 (mouseExited): Remove unused variables p and r.
1175 (ns_define_frame_cursor, ns_clear_frame_area)
1176 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1177 (menuDown): Assign [sender tag] to variable and cast the variable.
1179 * nsterm.h (menuDown): Add id as type to argument sender.
1180 (ns_display_info_for_name): Add Lisp_Object argument.
1181 (ns_term_init): Add Lisp_Object argument.
1182 (ns_map_event_to_object): Add void argument.
1183 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1184 prototype with arguments and only declare if __OBJC__.
1185 (nxatoms_of_nsselect): Add void argument.
1186 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1187 (ns_alloc_autorelease_pool): Add void argument.
1188 (ns_release_autorelease_pool): Add void* argument.
1189 (ns_get_defaults_value): Add const char* argument.
1191 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1192 (initFromContents): Use SSDATA where appropriate.
1193 (ns_update_menubar): Add braces to ambigous if-else.
1194 (initWithTitle): Put () around assignment in if statement.
1195 (ns_menu_show): Remove unused variables window and keymap.
1196 (update_frame_tool_bar): Remove unused variable selected_p.
1197 (initWithContentRect): Remove unused variable this_cmd_name.
1199 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1201 (setXBMColor): Remove unused variable len.
1202 (setPixmapData): Put () around assignment in loop statement.
1204 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1205 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1207 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1208 around assignment in loop statement.
1209 (nsfont_open): Remove unused variable i.
1210 (nsfont_open): Remove unused variable len.
1211 (nsfont_draw): Remove unused variable cs.
1213 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1214 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1215 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1216 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1217 (Fns_font_name, Fns_perform_service)
1218 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1219 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1220 (ns_set_name): Remove unused variable view.
1221 (x_set_menu_bar_lines): Remove unused variable olines.
1222 (x_set_tool_bar_lines): Remove unused variable root_window.
1223 (Fns_list_colors): Put () around assignment in while statement.
1224 (Fns_perform_service): Remove unused variable len.
1225 (Fns_display_usable_bounds): Remove unused variable top.
1226 (syms_of_nsfns): Remove unused variable i.
1228 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1231 2012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
1233 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1234 and free it with DestroyExceptionInfo (Bug#11558).
1236 2012-07-13 Juanma Barranquero <lekktu@gmail.com>
1238 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1239 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1240 Set here, not in nt/config.nt.
1242 2012-07-13 Eli Zaretskii <eliz@gnu.org>
1244 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1245 cursor overflow into the last glyph on display line when the right
1246 fringe is off. (Bug#11832)
1248 2012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1250 * xdisp.c (produce_special_glyphs): Now static.
1251 * dispextern.h (produce_special_glyphs): Remove decl.
1253 2012-07-13 Glenn Morris <rgm@gnu.org>
1255 * s/bsd-common.h, s/cygwin.h: Remove empty files.
1256 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1258 * s/usg5-4-common.h (USG, USG5):
1259 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1260 * s/sol2-6.h (SOLARIS2):
1261 * s/irix6-5.h (IRIX6_5):
1262 * s/hpux10-20.h (USG, USG5, HPUX):
1263 * s/gnu-linux.h (USG, GNU_LINUX):
1264 * s/freebsd.h (BSD_SYSTEM):
1265 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1266 * s/cygwin.h (CYGWIN):
1267 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1268 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1270 2012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
1272 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
1274 2012-07-13 Glenn Morris <rgm@gnu.org>
1276 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1278 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1280 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1281 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1283 2012-07-12 Glenn Morris <rgm@gnu.org>
1285 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
1287 * process.c (init_process_emacs): Rename from init_process.
1288 The old name is also the name of a Mach system call.
1289 * lisp.h, emacs.c: Update for this name change.
1290 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1293 2012-07-12 Eli Zaretskii <eliz@gnu.org>
1295 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1296 memmove call that removes glyphs covered by the left truncation
1297 glyph. Improve commentary.
1298 (display_line): Fix display of continuation glyphs on GUI frames
1299 when the right fringe is turned off and variable-size fonts are
1300 used in the window. Move the code that appends a stretch glyph to
1301 produce_special_glyphs, so that it could be used for truncation
1302 and continuation glyphs alike.
1303 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1304 glyph of a suitably computed width, to align the special glyphs at
1305 the window margin. Code moved from display_line. (Bug#11832)
1307 2012-07-12 Glenn Morris <rgm@gnu.org>
1309 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1311 * s/gnu-linux.h, s/hpux10-20.h:
1312 Do not unconditionally define HAVE_XRMSETDATABASE.
1314 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1316 2012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1318 Fix typos that broke OS X build.
1319 Reported by Randal L. Schwartz in
1320 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1321 * nsterm.m (ns_timeout): Add missing local decl.
1322 (ns_get_color): snprintf -> sprintf, to fix typo.
1324 2012-07-12 Glenn Morris <rgm@gnu.org>
1326 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1327 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1328 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1329 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1331 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1332 Move PTY_OPEN to configure.
1334 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1335 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1336 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1338 2012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1340 Use empty_unibyte_string where applicable.
1341 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1342 * lread.c (read1): Likewise.
1343 * xsettings.c (syms_of_xsettings): Likewise.
1345 2012-07-12 Glenn Morris <rgm@gnu.org>
1347 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1348 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
1349 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1350 * s/hpux10-20.h (RUN_TIME_REMAP):
1351 * s/bsd-common.h (TABDLY): Move to configure.
1353 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1355 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1357 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1358 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
1360 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
1362 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1363 * s/template.h: Move NARROWPROTO to configure.
1365 2012-07-11 Glenn Morris <rgm@gnu.org>
1367 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1368 unused since 2011-01-17 change to systty.h.
1370 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1371 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1372 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1374 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1376 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1378 2012-07-11 Glenn Morris <rgm@gnu.org>
1380 * s/darwin.h, s/gnu-linux.h, s/template.h:
1381 Move INTERRUPT_INPUT to configure.
1383 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1385 Minor adjustments to interning code.
1386 * lisp.h (intern, intern_c_string): Redefine as static inline
1387 wrappers for intern_1 and intern_c_string_1, respectively.
1388 (intern_1, intern_c_string_1): Rename prototypes.
1389 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1391 * font.c (font_intern_prop): Likewise. Adjust comment.
1392 * w32font.c (intern_font_name): Likewise.
1394 2012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1396 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1398 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1399 of Fcar/Fcdr if possible.
1400 * font.c (check_otf_features): Likewise.
1401 * fontset.c (Fnew_fontset): Likewise.
1402 * gnutls.c (Fgnutls_boot): Likewise.
1403 * minibuf.c (read_minibuf): Likewise.
1404 * msdos.c (IT_set_frame_parameters): Likewise.
1405 * xmenu.c (Fx_popup_dialog): Likewise.
1406 * w32menu.c (Fx_popup_dialog): Likewise.
1408 2012-07-11 Glenn Morris <rgm@gnu.org>
1410 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1411 since nothing has defined it on these platforms.
1413 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1414 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1416 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1417 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1418 Move CLASH_DETECTION to configure.
1420 * s/gnu.h: Remove file, which is now empty.
1422 * s/gnu.h, s/gnu-linux.h:
1423 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1425 2012-07-11 John Wiegley <johnw@newartisans.com>
1427 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1428 function attribute, so we only use it if it exists in the
1431 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1433 Avoid call to strlen in fast_c_string_match_ignore_case.
1434 * search.c (fast_c_string_match_ignore_case): Change to use
1435 length argument. Adjust users accordingly.
1436 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1438 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1440 Assume mkdir, rmdir.
1441 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1442 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1445 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1448 * s/hpux10-20.h (HAVE_PERROR): Remove.
1449 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1450 Remove dummy definition, as this problem was obsolete long ago.
1453 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1455 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1457 Avoid calls to strlen in font processing functions.
1458 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
1459 (font_open_by_name): Change to use length argument. Adjust
1461 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1463 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1464 Change to return ptrdiff_t.
1465 (xfont_list_pattern, xfont_match): Use length returned by
1466 xfont_decode_coding_xlfd.
1467 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1469 2012-07-11 Glenn Morris <rgm@gnu.org>
1471 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1472 Move DONT_REOPEN_PTY to configure.
1474 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1475 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1477 2012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1479 Remove "#define unix" that is no longer needed (Bug#11905).
1480 * s/aix4-2.h (unix): Remove; no longer needed.
1482 EMACS_TIME simplification (Bug#11875).
1483 This replaces macros (which typically do not work in GDB)
1484 with functions, typedefs and enums, making the code easier to debug.
1485 The functional style also makes code easier to read and maintain.
1486 * systime.h: Include <sys/time.h> on all hosts, not just if
1487 WINDOWSNT, since 'struct timeval' is needed in general.
1488 (EMACS_TIME): Now a typedef, not a macro.
1489 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1491 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1492 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1493 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1494 (EMACS_TIME_LE): Now functions, not macros.
1495 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1496 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1497 which are not functions. All uses rewritten to use:
1498 (make_emacs_time): New function.
1499 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1500 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1501 not functions. All uses rewritten to use the following, respectively:
1502 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1503 (add_emacs_time, sub_emacs_time): New functions.
1504 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
1505 * fileio.c (Fcopy_file):
1506 * xterm.c (XTflash): Get the current time closer to when it's used.
1507 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1509 * bytecode.c (targets): Suppress -Woverride-init warnings.
1511 Simplify by avoiding confusing use of strncpy etc.
1512 * doc.c (Fsnarf_documentation):
1513 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1514 * frame.c (Fmake_terminal_frame):
1515 * gtkutil.c (get_utf8_string):
1517 * nsmenu.m (ns_update_menubar):
1518 * regex.c (regerror):
1519 Prefer memcpy to strncpy and strncat when either will do.
1520 * fileio.c (Fsubstitute_in_file_name):
1521 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1522 (menu_separator_name_p):
1523 * nsmenu.m (ns_update_menubar):
1524 Prefer memcmp to strncmp when either will do.
1525 * nsterm.m: Include <ftoastr.h>.
1527 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1528 Prefer snprintf to strncpy.
1529 * nsterm.m (ns_term_init):
1530 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1531 * nsterm.m (ns_term_init):
1532 Avoid the need for strncpy, by using build_string or
1533 make_unibyte_string directly. Use dtoastr, not snprintf.
1534 * process.c (Fmake_network_process): Diagnose service names that
1535 are too long, rather than silently truncating them or creating
1536 non-null-terminated names.
1537 (Fnetwork_interface_info): Likewise, for interface names.
1538 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1539 Prefer sprintf to strncat.
1540 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1541 Prefer vsnprintf to vsprintf + strncpy.
1543 2012-07-10 Glenn Morris <rgm@gnu.org>
1545 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1546 Clarify fallback case.
1548 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1550 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1551 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1552 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
1553 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
1554 where argument type is known to be a Lisp_Cons.
1556 2012-07-10 Tom Tromey <tromey@redhat.com>
1558 * bytecode.c (BYTE_CODE_THREADED): New macro.
1559 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1560 (enum byte_code_op): New type.
1561 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1562 (exec_byte_code): Use them. Use token threading when applicable.
1564 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1566 Optimize pure C strings initialization.
1567 * lisp.h (make_pure_string): Fix prototype.
1568 (build_pure_c_string): New function, defined as static inline. This
1569 provides a better opportunity to optimize away calls to strlen when
1570 the function is called with compile-time constant argument.
1571 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1572 argument, adjust users accordingly. Use build_pure_c_string where
1574 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1575 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1576 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1578 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1580 Avoid calls to strlen in miscellaneous functions.
1581 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1582 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1583 * lread.c (openp): Likewise.
1585 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1587 Avoid calls to strlen in path processing functions.
1588 * fileio.c (file_name_as_directory): Add comment. Change to add
1589 srclen argument and return the length of result. Adjust users
1591 (directory_file_name): Fix comment. Change to add srclen argument,
1592 swap 1st and 2nd arguments to obey the common convention. Adjust
1594 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1596 2012-07-10 Glenn Morris <rgm@gnu.org>
1598 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1599 Move PENDING_OUTPUT_COUNT definition to configure.
1601 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1602 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1603 * s/gnu.h (DATA_START): Move definitions to configure.
1605 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1606 We include usg5-4-common.h, which defines them both.
1608 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1609 O_RDONLY already includes it).
1611 Stop ns builds setting the EMACSLOADPATH environment variable.
1612 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1613 Now it does not set EMACSLOADPATH, just returns the load-path string.
1614 * nsterm.h: Update accordingly.
1615 * lread.c [HAVE_NS]: Include nsterm.h.
1616 (init_lread) [HAVE_NS]: Use ns_load_path.
1617 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1619 2012-07-09 Glenn Morris <rgm@gnu.org>
1621 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1622 since the included bsd-common.h does so.
1624 Stop ns builds setting the EMACSPATH environment variable.
1625 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1626 (ns_init_paths): Do not set EMACSPATH.
1627 * nsterm.h (ns_exec_path): Add it.
1628 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1631 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1633 2012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1635 * process.c (wait_reading_process_output): 'waitchannels' was unset
1636 when read_kbd || !NILP (wait_for_cell); fix this.
1638 Add GCC-style 'const' attribute to functions that can use it.
1639 * character.h (char_resolve_modifier_mask):
1640 * keyboard.h (make_ctrl_char):
1641 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1642 (init_character_once, next_almost_prime, init_fns, init_image)
1643 (flush_pending_output, init_sound):
1644 * mem-limits.h (start_of_data):
1645 * menu.h (finish_menu_items):
1646 Add ATTRIBUTE_CONST.
1647 * emacs.c (DEFINE_DUMMY_FUNCTION):
1648 Declare the dummy function with ATTRIBUTE_CONST.
1649 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1650 Add decls with ATTRIBUTE_CONST.
1652 Minor improvements to make_formatted_string.
1653 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1654 where int is good enough, as vsprintf returns an int.
1655 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1657 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1659 Use make_formatted_string to avoid double length calculation.
1660 * lisp.h (make_formatted_string): New prototype.
1661 * alloc.c (make_formatted_string): New function.
1662 * buffer.c (Fgenerate_new_buffer_name): Use it.
1663 * dbus.c (syms_of_dbusbind): Likewise.
1664 * editfns.c (Fcurrent_time_zone): Likewise.
1665 * filelock.c (get_boot_time): Likewise.
1666 * frame.c (make_terminal_frame, set_term_frame_name)
1667 (x_report_frame_params): Likewise.
1668 * image.c (gs_load): Likewise.
1669 * minibuf.c (get_minibuffer): Likewise.
1670 * msdos.c (dos_set_window_size): Likewise.
1671 * process.c (make_process): Likewise.
1672 * xdisp.c (ensure_echo_area_buffers): Likewise.
1673 * xsettings.c (apply_xft_settings): Likewise.
1675 2012-07-09 Glenn Morris <rgm@gnu.org>
1677 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1678 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1679 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1680 * nsterm.h (ns_etc_directory): Add it.
1681 * callproc.c [HAVE_NS]: Include nsterm.h.
1682 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1684 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1686 Move marker debugging code under MARKER_DEBUG.
1687 * marker.c (MARKER_DEBUG): Move marker debugging code under
1688 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1689 for bootstrap with --enable-checking (~3x slowdown reported
1690 by Juanma Barranquero <lekktu@gmail.com>).
1691 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1693 2012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1695 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1696 See <http://bugs.gnu.org/11825#29>.
1698 2012-07-08 Eli Zaretskii <eliz@gnu.org>
1700 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1701 has no font, use the frame's font. (Bug#11813)
1702 (display_line): Add commentary about displaying truncation glyphs
1704 (produce_special_glyphs): Move here from term.c.
1706 * term.c (produce_special_glyphs): Move to xdisp.c.
1708 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1711 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1713 * xdisp.c (display_line): Avoid warning about implicit declaration
1716 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1718 * lisp.h: Remove empty conditional.
1720 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1722 * lread.c (load_path_check): Now static.
1724 Fix some minor --with-ns problems found by static checking.
1725 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1726 (x_set_font) [!HAVE_X_WINDOWS]:
1727 * image.c (xpm_load_image) [HAVE_NS]:
1728 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1729 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1730 Remove unused local.
1731 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1732 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1733 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1734 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1735 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1736 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1737 Fix pointer signedness problem.
1738 * xfaces.c (FRAME_X_FONT_TABLE):
1739 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1741 2012-07-07 Glenn Morris <rgm@gnu.org>
1743 * lread.c (load_path_check): New function, split from init_lread.
1744 (init_lread): Reorganize. Motivation:
1745 If EMACSLOADPATH is set, check/warn about that rather than the
1746 defaults, which we are not going to use. Hence we can remove
1747 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1748 Don't warn if site-lisp directories are missing.
1749 If not installed, start from a blank load-path, since
1750 PATH_LOADSEARCH refers to the eventual installation directories.
1752 2012-07-07 Eli Zaretskii <eliz@gnu.org>
1754 Support truncation and continuation glyphs on GUI frames, when
1755 fringes are disabled. (Bug#11832)
1756 * xdisp.c (init_iterator): Get dimensions of truncation and
1757 continuation glyphs even if on GUI frames. Adjust
1758 it->last_visible_x on GUI frames when the left or right fringes,
1759 or both, are absent.
1760 (start_display, move_it_in_display_line_to): Handle the case of a
1761 GUI frame without a fringe to display continuation or truncation
1763 (insert_left_trunc_glyphs): Support GUI frames: make sure
1764 truncation glyphs overwrite enough glyphs from the current line to
1765 have sufficient space in pixels.
1766 (display_line): Support truncation and continuation glyphs on GUI
1767 frames. If some spare pixels are left on the line after inserting
1768 the truncation glyphs, fill that space with a stretch glyph of a
1769 suitably computed width.
1771 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1772 produce_glyphs, to support GUI sessions.
1774 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1776 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1778 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1780 Do not require float-time's arg to fit in time_t (Bug#11825).
1781 This works better on hosts where time_t is unsigned, and where
1782 float-time is applied to the (negative) difference between two times.
1783 * editfns.c (decode_time_components): Last arg is now double *,
1784 not int *, and means to store all the result as a double, without
1785 worrying about whether the seconds part fits in time_t.
1786 All callers changed.
1787 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1788 All callers changed.
1789 (Ffloat_time): Do not fail merely because the specified time falls
1790 outside of time_t range.
1792 2012-07-07 Glenn Morris <rgm@gnu.org>
1794 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1795 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1796 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1798 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
1800 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1801 Update dependencies.
1803 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1805 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1807 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1808 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1809 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1810 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1811 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1812 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1814 * xfont.c (compare_font_names): Redo to omit the need for casts.
1816 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1818 * xfns.c (Fx_change_window_property): Doc fix.
1819 * w32fns.c (Fx_change_window_property): Doc fix.
1821 * w32fns.c (Fx_window_property): Accept the same arguments as the
1822 X Windows version. Doc fix.
1823 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1825 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
1826 Eli Zaretskii <eliz@gnu.org>
1828 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1829 Windows-specific code from nt/config.nt moved here.
1830 Obsolete settings removed.
1832 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1834 * process.c: Avoid unnecessary calls to gettime.
1835 (wait_reading_process_output): Don't get the time of day
1836 when gobbling data immediately and not waiting, as there's no need
1837 for it in that case. This removes a FIXME.
1839 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1841 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1842 is defined (Bug#11768).
1844 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1846 Fix marker debugging code.
1847 * marker.c (byte_char_debug_check): Do not perform the check
1848 if buffer is not multibyte.
1849 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1850 Call byte_char_debug_check with correct arguments.
1852 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1854 Compile marker debugging code only if ENABLE_CHECKING is defined.
1855 * marker.c (byte_char_debug_check, count_markers):
1856 Use only if ENABLE_CHECKING is defined.
1857 (byte_debug_flag): Remove.
1858 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1859 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1861 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1863 Avoid code repetition in marker-related functions.
1864 * marker.c (attach_marker): New function.
1865 (Fset_marker, set_marker_restricted, set_marker_both)
1866 (set_marker_restricted_both): Use it.
1867 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1868 Consistently rename charno to charpos.
1869 (marker_position): Add eassert.
1870 (marker_byte_position): Convert to eassert.
1872 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1874 Simplify list operations in unchain_overlay and unchain_marker.
1875 * buffer.c (unchain_overlay): Simplify. Add comment.
1876 * marker.c (unchain_marker): Simplify. Fix comments.
1878 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1880 Introduce fast path for the widely used marker operation.
1881 * alloc.c (build_marker): New function.
1882 * lisp.h (build_marker): New prototype.
1883 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1884 * composite.c (autocmp_chars): Likewise.
1885 * editfns.c (buildmark): Remove.
1886 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1887 (save_restriction_save): Use build_marker.
1888 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1889 * window.c (save_window_save): Likewise.
1891 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1893 Do not use Fdelete_overlay in delete_all_overlays
1894 to avoid redundant calls to unchain_overlay.
1895 * buffer.c (drop_overlay): New function.
1896 (delete_all_overlays, Fdelete_overlay): Use it.
1897 * minibuf.c (get_minibuffer): Fix comment.
1899 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1901 Port to OpenBSD 5.1 amd64.
1902 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1903 This is needed for OpenBSD, and should be harmless on all BSD systems.
1904 Also, include <sys/sysctl.h>, as it should be available on all
1905 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1906 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1907 use p_pid member, not kp_proc.pid.
1909 2012-07-06 Glenn Morris <rgm@gnu.org>
1911 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1913 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1915 More xmalloc and related cleanup.
1916 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1917 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1918 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1919 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1920 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1921 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1922 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1923 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1924 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1926 Omit needless casts involving void * pointers and allocation.
1927 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1928 as the former is more robust if P's type is changed.
1929 Prefer xzalloc to xmalloc + memset 0.
1930 Simplify malloc-or-realloc to realloc.
1931 Don't worry about xmalloc returning a null pointer.
1932 Prefer xstrdup to xmalloc + strcpy.
1933 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1935 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1936 alloca of a constant.
1938 2012-07-05 Eli Zaretskii <eliz@gnu.org>
1940 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1941 hscroll is larger than the line width. Fixes long and futile
1942 looping inside extend_face_to_end_of_line (on a TTY) producing
1943 glyphs that are not needed and thrown away.
1945 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1947 * marker.c (set_marker_restricted_both): Simplify by using
1950 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1952 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1954 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1956 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1957 not defined (Bug#11768).
1958 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1959 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1960 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1961 followed by gtk_box_set_homogeneous (Bug#11768).
1962 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
1963 (update_theme_scrollbar_width, xg_create_scroll_bar):
1964 Use gtk_scrollbar_new (Bug#11768).
1965 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1966 (is_box_type): New function (Bug#11768).
1967 (xg_tool_item_stale_p): Call is_box_type.
1968 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
1969 with default display (Bug#11768).
1971 2012-07-05 Eli Zaretskii <eliz@gnu.org>
1973 * xdisp.c (window_hscroll_limited): New function.
1974 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1975 coordinates when window's hscroll is set to insanely large
1978 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
1980 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1981 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1983 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1986 * lisp.h (xzalloc): New prototype. Omit needless casts.
1987 * alloc.c (xzalloc): New function. Omit needless casts.
1988 * charset.c: Omit needless casts. Convert all calls to
1989 xmalloc with following memset to xzalloc.
1990 * dispnew.c: Likewise.
1991 * fringe.c: Likewise.
1992 * image.c: Likewise.
1993 * sound.c: Likewise.
1995 * w32fns.c: Likewise.
1996 * w32font.c: Likewise.
1997 * w32term.c: Likewise.
1998 * xfaces.c: Likewise.
2000 * xterm.c: Likewise.
2001 * atimer.c: Omit needless casts.
2002 * buffer.c: Likewise.
2003 * callproc.c: Likewise.
2005 * coding.c: Likewise.
2006 * composite.c: Likewise.
2008 * doprnt.c: Likewise.
2009 * editfns.c: Likewise.
2010 * emacs.c: Likewise.
2012 * filelock.c: Likewise.
2014 * gtkutil.c: Likewise.
2015 * keyboard.c: Likewise.
2017 * lread.c: Likewise.
2018 * minibuf.c: Likewise.
2019 * msdos.c: Likewise.
2020 * print.c: Likewise.
2021 * process.c: Likewise.
2022 * region-cache.c: Likewise.
2023 * search.c: Likewise.
2024 * sysdep.c: Likewise.
2025 * termcap.c: Likewise.
2026 * terminal.c: Likewise.
2027 * tparam.c: Likewise.
2028 * w16select.c: Likewise.
2030 * w32reg.c: Likewise.
2031 * w32select.c: Likewise.
2032 * w32uniscribe.c: Likewise.
2033 * widget.c: Likewise.
2034 * xdisp.c: Likewise.
2035 * xmenu.c: Likewise.
2037 * xselect.c: Likewise.
2039 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2041 * fileio.c (time_error_value): Check the right error number.
2042 Problem reported by Troels Nielsen in
2043 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
2045 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2047 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
2048 This should be fixed in a better way; see Eli Zaretskii in
2049 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
2050 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
2052 * fileio.c (time_error_value): Rename from special_mtime.
2053 The old name's problems were noted by Eli Zaretskii in
2054 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
2056 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
2057 This variable's comment says Emacs needs at least one GDB-visible
2058 symbol of type enum pvec_type, to work around GDB problems.
2059 The symbol's value doesn't matter.
2061 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
2062 that causes compilation to fail on pre-C99 compilers.
2064 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
2066 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
2067 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
2069 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2071 * buffer.c (init_buffer_once): Fix initialization of
2072 headers for buffer_defaults and buffer_local_symbols.
2073 Reported by Juanma Barranquero <lekktu@gmail.com>.
2075 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2077 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
2078 * lisp.h (enum pvec_type): Use fewer bits.
2079 (PSEUDOVECTOR_SIZE_BITS): New constant.
2080 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
2081 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
2082 change in pvec_type.
2083 (PSEUDOVECTOR_TYPEP): New macro.
2084 (TYPED_PSEUDOVECTORP): Use it.
2085 * fns.c (internal_equal): Adapt code to extract pvectype.
2086 * emacs.c (gdb_pvec_type): Update type.
2087 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
2088 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
2089 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
2090 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
2091 (sweep_vectors): Use it. Use local var `total_bytes' instead of
2092 abusing vector->header.next.nbytes.
2093 (live_vector_p): Use PVEC_TYPE.
2094 (mark_object): Adapt code to extract pvectype. Use switch.
2096 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2098 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
2099 Tighten new eassert a bit.
2101 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2103 Fix compilation with --enable-gcc-warnings and -O1
2105 * doprnt.c (doprnt): Change type of tem to int, initialize
2106 to avoid compiler warning. Add eassert.
2107 * search.c (simple_search): Initialize match_byte to avoid
2108 compiler warning. Add eassert.
2110 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2112 Avoid weird behavior with large horizontal scrolls.
2113 Without this change, for example, large hscroll values would
2114 mess up Emacs's display on Fedora 15 x86, presumably due to
2115 overflows in int calculations in the display code.
2116 Also, if buffers had long lines, Emacs would freeze.
2117 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
2118 (set_window_hscroll): New function, containing the old guts of
2119 Fset_window_hscroll. Return the clipped value.
2120 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
2121 This avoids the need to check against PTRDIFF_MAX.
2123 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
2125 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2127 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
2129 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2131 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
2132 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
2133 since GCC 4.4.6 issues a bogus warning for them.
2135 Fix bugs in file timestamp newness comparisons.
2136 * fileio.c (Ffile_newer_than_file_p):
2137 * lread.c (Fload): Use full timestamp resolution of files,
2138 not just the 1-second resolution, so that files that are only
2139 slightly newer still count as newer.
2140 * fileio.c (Ffile_newer_than_file_p): Don't assume file
2141 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
2143 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
2145 * fileio.c: Improve handling of file time marker. (Bug#11852)
2146 (special_mtime): New function.
2147 (Finsert_file_contents, Fverify_visited_file_modtime):
2148 Use it to set special mtime values consistently.
2150 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
2152 * fileio.c (Finsert_file_contents): Properly handle st_mtime
2153 marker for non-existing file. (Bug#11852)
2155 2012-07-03 Glenn Morris <rgm@gnu.org>
2157 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
2158 and did not make it into globals.h).
2160 2012-07-03 Tom Tromey <tromey@redhat.com>
2162 * window.c (Fset_window_margins, Fset_window_fringes)
2163 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
2164 * textprop.c (Fprevious_property_change): No longer static.
2165 * syntax.c (Fsyntax_table_p): No longer static.
2166 * process.c (Fget_process, Fprocess_datagram_address): No longer
2168 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
2169 * keyboard.c (Fcommand_execute): No longer static.
2171 * insdel.c (Fcombine_after_change_execute): No longer static.
2172 * image.c (Finit_image_library): No longer static.
2173 * fileio.c (Fmake_symbolic_link): No longer static.
2174 * eval.c (Ffetch_bytecode): No longer static.
2175 * editfns.c (Fuser_full_name): No longer static.
2176 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2178 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2180 * dired.c (Ffile_attributes): No longer static.
2181 * composite.c (Fcomposition_get_gstring): No longer static.
2182 * callproc.c (Fgetenv_internal): No longer static.
2184 * ccl.h: Remove EXFUNs.
2185 * buffer.h: Remove EXFUNs.
2186 * dispextern.h: Remove EXFUNs.
2187 * intervals.h: Remove EXFUNs.
2188 * fontset.h: Remove EXFUN.
2189 * font.h: Remove EXFUNs.
2190 * dosfns.c (system_process_attributes): Remove EXFUN.
2191 * keymap.h: Remove EXFUNs.
2192 * lisp.h: Remove EXFUNs.
2193 * w32term.h: Remove EXFUNs.
2194 * window.h: Remove EXFUNs.
2195 * xsettings.h: Remove EXFUN.
2196 * xterm.h: Remove EXFUN.
2198 2012-07-03 Glenn Morris <rgm@gnu.org>
2200 * lisp.h (Frandom): Make it visible to C.
2201 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2202 buffer for invisible buffers. (Bug#1229)
2204 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2206 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2207 values which aren't power of 2.
2208 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
2209 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
2212 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2214 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2216 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2218 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2220 * alloc.c (allocate_vector_block): Remove redundant
2221 calls to mallopt if DOUG_LEA_MALLOC is defined.
2222 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2223 avoid calls to mallopt if zero_vector is returned.
2225 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2227 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2228 is enabled, avoid dereferencing NULL current_sblock if
2231 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2233 Cleanup basic buffer management.
2234 * buffer.h (struct buffer): Change layout to use generic vector
2235 marking code. Fix some comments. Change type of 'clip_changed'
2236 to bitfield. Remove unused #ifndef old.
2237 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2238 (GET_OVERLAYS_AT): Fix indentation.
2239 (for_each_per_buffer_object_at): New macro.
2240 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2241 (Fbuffer_local_variables): Use it.
2242 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2243 * alloc.c (allocate_buffer): Adjust to match new layout of
2244 struct buffer. Fix comment.
2245 (mark_overlay): New function.
2246 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2247 Lisp area of struct buffer.
2248 (mark_object): Use it. Adjust marking of misc objects
2249 and related comments.
2251 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2253 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2254 wrapper that is not needed because the wrapped code is a no-op (zero
2255 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2256 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2258 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2260 * alloc.c (mark_buffer): Simplify. Remove prototype.
2261 (mark_object): Add comment. Reorganize marking of vector-like
2262 objects. Use CHECK_LIVE for all vector-like objects except buffers
2263 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
2264 redundant calls to mark_vectorlike for bool vectors.
2266 2012-06-30 Glenn Morris <rgm@gnu.org>
2268 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2270 * epaths.in (PATH_SITELOADSEARCH): New.
2271 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2272 This is rather than relying on --enable-locallisppath elements
2273 having "site-lisp" in their names. (Bug#10208#25, 11658)
2275 2012-06-30 Eli Zaretskii <eliz@gnu.org>
2277 * w32proc.c (sys_select): Accept and ignore one more argument.
2279 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2281 * sysselect.h [DOS_NT]: Don't include sys/select.h.
2282 (pselect) [!MS_DOS]: Redirect to sys_select.
2284 * sysdep.c: Don't include dos.h and dosfns.h.
2286 * process.c (sys_select):
2287 * msdos.c (sys_select): Accept one more argument and ignore it.
2289 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2290 adapt data types and code to that.
2293 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2294 which clashes with the gnulib function of the same name.
2296 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2298 * font.c (font_style_to_value, font_style_symbolic)
2299 (font_prop_validate_style): Add type checks for values in
2302 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2304 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2307 2012-06-29 Eli Zaretskii <eliz@gnu.org>
2309 * xdisp.c (try_window_id): Undo last change.
2311 * w32.c (getwd): Adjust commentary about startup_dir.
2312 (init_environment): Always call sys_access, even in non-MSVC
2313 builds. Don't chdir to the directory of the Emacs executable.
2314 This undoes code from 1997 which was justified by the need to
2315 "avoid conflicts when removing and renaming directories". But its
2316 downside was that every relative file name was being interpreted
2317 relative to the directory of the Emacs executable, which can never
2318 be TRT. In particular, it broke sys_access when called with
2319 relative file names.
2320 (sys_access): Map GetLastError to errno.
2322 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2324 * window.h (struct window): Change type of 'fringes_outside_margins'
2325 to bitfield. Fix comment. Adjust users accordingly.
2326 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2328 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2331 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
2333 * gnutls.c (emacs_gnutls_handshake):
2334 Add QUIT to make the loop interruptible.
2336 2012-06-29 Glenn Morris <rgm@gnu.org>
2338 * charset.c (init_charset): Make lack of etc/charsets fatal.
2340 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2342 * editfns.c (region_limit): Fix type mismatch.
2344 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2346 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2347 undefined. Convert from xassert to eassert.
2348 * nsmenu.m: Convert from xassert to eassert.
2349 * nsterm.m: Likewise.
2351 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2353 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2355 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2357 Avoid integer overflow on scroll-left and scroll-right.
2358 * window.c (HSCROLL_MAX): New macro.
2359 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2360 overflow when requested scroll falls outside ptrdiff_t range.
2362 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2364 * window.h (struct window): Change type of 'hscroll',
2365 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2366 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2367 Adjust users accordingly.
2368 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2369 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2370 from EMACS_INT to ptrdiff_t.
2371 (make_window): Omit redundant initialization.
2373 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
2375 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2377 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2379 * window.h (struct window): Change type of 'use_time' and
2380 'sequence_number' from Lisp_Object to int.
2381 * frame.c (make_frame): Adjust users accordingly.
2382 * print.c (print_object): Likewise.
2383 * window.c (select_window, Fwindow_use_time, make_parent_window)
2384 (make_window): Likewise.
2386 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2388 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2389 enabled with --enable-checking=[all,glyphs] configure option.
2390 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2391 adjust comments accordingly.
2392 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2393 undefined, adjust comments accordingly.
2394 * image.c: Likewise.
2395 * scroll.c: Likewise.
2396 * w32fns.c: Likewise.
2397 * w32term.c: Likewise.
2398 * xdisp.c: Likewise.
2399 * xfaces.c: Likewise.
2401 * xterm.c: Likewise.
2403 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2405 Generalize run-time debugging checks.
2406 * dispextern.h (XASSERTS): Remove.
2407 * fontset.c (xassert): Remove.
2408 Convert from xassert to eassert.
2409 * alloc.c: Convert from xassert to eassert.
2411 * dispnew.c: Likewise.
2413 * fringe.c: Likewise.
2414 * ftfont.c: Likewise.
2415 * gtkutil.c: Likewise.
2416 * image.c: Likewise.
2417 * keyboard.c: Likewise.
2419 * process.c: Likewise.
2420 * scroll.c: Likewise.
2421 * sound.c: Likewise.
2423 * w32console.c: Likewise.
2424 * w32fns.c: Likewise.
2425 * w32term.c: Likewise.
2426 * window.c: Likewise.
2427 * xdisp.c: Likewise.
2428 * xfaces.c: Likewise.
2430 * xselect.c: Likewise.
2431 * xterm.c: Likewise.
2433 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2435 * fns.c (maybe_resize_hash_table): Output message when growing the
2438 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2440 * alloc.c (allocate_string_data): Remove dead code.
2441 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2442 avoid GCC warning about unused macro.
2444 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2446 * alloc.c (allocate_string): Omit intervals initialization.
2447 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2448 as in make_pure_string and make_pure_c_string.
2450 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2452 * alloc.c (allocate_string): Fix last change.
2454 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2456 * alloc.c (allocate_string): Remove two redundant calls
2457 to memset, add explicit initialization where appropriate.
2459 2012-06-27 Glenn Morris <rgm@gnu.org>
2461 * lisp.mk (lisp): Remove paths.elc.
2463 2012-06-27 Chong Yidong <cyd@gnu.org>
2465 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2467 2012-06-26 John Wiegley <johnw@newartisans.com>
2469 * unexmacosx.c (copy_data_segment): Add two section names used
2470 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2472 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2473 when building with Clang.
2475 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2477 * eval.c (Fapply): Allow calling it with a single argument.
2479 2012-06-26 Eli Zaretskii <eliz@gnu.org>
2481 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2482 _stricmp and _strnicmp.
2483 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2485 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2487 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2489 (allocate_process): Likewise for new process.
2490 (allocate_terminal): Change to use offsetof.
2491 (allocate_frame): Likewise.
2492 * frame.c (make_frame): Omit redundant initialization.
2493 * window.c (make_parent_window): Use memset.
2494 (make_window): Omit redundant initialization.
2495 * process.c (make_process): Omit redundant initialization.
2496 * terminal.c (create_terminal): Likewise.
2498 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2500 * term.c (delete_tty): Remove redundant call to memset.
2502 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2504 * alloc.c: Remove build_string.
2505 * lisp.h: Define build_string as static inline. This provides
2506 a better opportunity to optimize away calls to strlen when the
2507 function is called with compile-time constant argument.
2508 * image.c (imagemagick_error): Convert to build_string.
2509 * w32proc.c (sys_spawnve): Likewise.
2510 * xterm.c (x_term_init): Likewise.
2512 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2514 Use sprintf return value instead of invoking strlen on result.
2515 In the old days this wasn't portable, since some sprintf
2516 implementations returned char *. But they died out years ago and
2517 Emacs already assumes sprintf returns int.
2518 Similarly for float_to_string.
2519 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2520 * ccl.c (ccl_driver):
2521 * character.c (string_escape_byte8):
2522 * data.c (Fnumber_to_string):
2523 * doprnt.c (doprnt):
2524 * print.c (print_object):
2525 * xdisp.c (message_dolog):
2526 * xfns.c (syms_of_xfns):
2527 Use sprintf or float_to_string result to avoid need to call strlen.
2528 * data.c (Fnumber_to_string):
2529 Use make_unibyte_string, since the string must be ASCII.
2530 * lisp.h, print.c (float_to_string): Now returns int length.
2531 * term.c (produce_glyphless_glyph):
2532 Use sprintf result rather than recomputing it.
2534 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2535 * Makefile.in (ALL_CFLAGS):
2536 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2537 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2539 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2541 * dispextern.h (xstrcasecmp): Define to library function
2542 strcasecmp if available.
2543 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2545 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2547 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2548 Avoid comma operator.
2549 * menu.c (push_submenu_start, push_submenu_end)
2550 (push_left_right_boundary, push_menu_pane): Likewise.
2551 * msdos.c (dos_rawgetc): Likewise.
2553 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2555 * xfns.c (xic_create_fontsetname): Remove redundant calls
2558 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2560 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2561 sprintf already null-terminates its output.
2563 * xfns.c (x_window): Remove redundant cast.
2565 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2567 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2568 `const char *' to `char *' to avoid compiler warning.
2570 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2572 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2573 instead of truncating it to 63 (admittedly a generous limit).
2575 * process.c: Fix spelling and caps in comments.
2577 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2579 * emacs.c (setpgrp): Remove definition, unused.
2580 * sysdep.c (setpgrp): Remove definition, not used in this file.
2582 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
2584 * makefile.w32-in: Update dependencies.
2586 2012-06-24 Eli Zaretskii <eliz@gnu.org>
2588 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2589 (SYSTIME_H): Add nt/inc/sys/time.h.
2591 * systime.h [WINDOWSNT]: Include sys/time.h.
2593 * s/ms-w32.h (struct timespec): Definition moved from
2594 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2596 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2598 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2599 * buffer.h (buffer_slot_type_mismatch):
2600 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2601 * eval.c (unwind_to_catch):
2602 * image.c (my_png_error, my_error_exit):
2603 * keyboard.c (quit_throw_to_read_char, user_error)
2604 (Fexit_recursive_edit, Fabort_recursive_edit):
2605 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2606 (wrong_type_argument, buffer_overflow, __executable_start)
2607 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2608 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2609 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2611 (child_setup) [!DOS_NT]:
2612 * lread.c (end_of_file_error, invalid_syntax):
2613 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2614 * puresize.h (pure_write_error):
2615 * search.c (matcher_overflow):
2616 * sound.c (sound_perror, alsa_sound_perror):
2617 * sysdep.c, syssignal.h (croak):
2618 * term.c (maybe_fatal, vfatal):
2619 * textprop.c (text_read_only):
2620 * undo.c (user_error):
2621 * unexmacosx.c (unexec_error):
2622 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2623 Use _Noreturn rather than NO_RETURN.
2624 No need for separate decl merely because of _Noreturn.
2625 * sound.c (sound_warning, parse_sound):
2626 Remove unnecessary forward decls.
2628 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2630 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2631 * lisp.h (WAIT_READING_MAX): New macro.
2632 * dispnew.c (Fsleep_for, sit_for):
2633 * keyboard.c (kbd_buffer_get_event):
2634 * process.c (Faccept_process_output):
2635 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2636 This improves on the previous patch, which introduced a bug
2637 when time_t is unsigned and as wide as intmax_t.
2638 See <http://bugs.gnu.org/9000#51>.
2640 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2642 * dispnew.c (sit_for, Fsleep_for):
2643 * keyboard.c (kbd_buffer_get_event):
2644 * process.c (Faccept_process_output): Avoid compiler warnings when
2645 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2647 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
2649 * makefile.w32-in: Update dependencies.
2651 * w32.c (ltime): Add return type and declare static.
2652 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2654 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2656 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2657 Privately reported by Herbert J. Skuhra.
2658 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2660 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2661 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2663 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2665 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2666 last argument of make_unibyte_string.
2668 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2669 language ID in the event parameters.
2671 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2672 event.code, not the obscure "character set ID".
2674 2012-06-23 Chong Yidong <cyd@gnu.org>
2676 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2678 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2680 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2681 * w32.c (fdutimens): New function.
2683 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2685 * s/ms-w32.h (pselect): Redirect to sys_select.
2687 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2689 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2690 in the logic of incrementing and decrementing the value of
2691 use_relocatable_buffers.
2693 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2695 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2696 Privately reported by Herbert J. Skuhra.
2697 [__FreeBSD__]: Remove "*/" typo after "#include".
2698 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2699 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2700 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2701 Don't assume EMACS_TIME and struct timeval are the same type.
2703 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2705 Support higher-resolution time stamps (Bug#9000).
2706 The time stamps are only nanosecond-resolution at the C level,
2707 since that's the best that any real-world system supports now.
2708 But they are picosecond-resolution at the Lisp level, as that's
2709 easy, and leaves room for future OS improvements.
2711 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2714 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2715 Don't get current time unless it's needed.
2717 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2718 now provides it if it's absent.
2719 (start_atimer): Port to higher-res time stamps.
2720 Check for time stamp overflow. Don't get current time more
2721 often than is needed.
2723 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2724 Include systime.h, not time.h.
2725 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2727 * dired.c: Include stat-time.h.
2728 (Ffile-attributes): File times now have higher resolution.
2730 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2731 (struct image): Timestamp now has higher resolution.
2733 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2734 has at least microseconds now. All uses removed.
2735 (update_frame, update_single_window, update_window, update_frame_1)
2736 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2738 * editfns.c (time_overflow): Now extern.
2739 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2740 (float-time, Fformat_time_string, Fcurrent_time_string)
2741 (Fcurrent_time_zone): Accept and generate higher-resolution
2743 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2744 (decode_time_components, lisp_seconds_argument): New functions.
2745 (make_time): Now static.
2746 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2747 Report an error if the time is invalid, rather than having the caller
2750 * fileio.c: Include <stat-time.h>
2751 (Fcopy_file): Copy higher-resolution time stamps.
2752 Prefer to set the time stamp via a file descriptor if that works.
2753 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2754 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2755 (Fvisited_file_modtime, Fset_visited_file_modtime):
2756 Support higher-resolution time stamps.
2758 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2760 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2762 * image.c (prepare_image_for_display, clear_image_cache)
2763 (lookup_image): Port to higer-resolution time stamps.
2765 * keyboard.c (start_polling, bind_polling_period):
2766 Check for time stamp overflow.
2767 (read_char, kbd_buffer_get_event, timer_start_idle)
2768 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2769 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2770 Port to higher-resolution time stamps. Do not assume time_t is signed.
2771 (decode_timer): New function. Timers are now vectors of length 9,
2772 not 8, to accommodate the picosecond component.
2773 (timer_check_2): Use it.
2775 * nsterm.m (select_timeout, timeval_subtract): Remove.
2776 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2777 as they're a bit more accurate and handle overflow better.
2778 (ns_select): Change prototype to be compatible with pselect.
2779 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2780 * nsterm.h (ns_select): Adjust prototype.
2782 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2783 us-resolution time stamps.
2784 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2786 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2788 * lisp.h (time_overflow): New decl.
2789 (wait_reading_process_output): First arg is now intmax_t, not int,
2790 to accommodate larger waits.
2792 * process.h (struct Lisp_Process.read_output_delay):
2793 Now counts nanoseconds, not microseconds.
2794 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2796 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2797 (wait_reading_process_output):
2798 Port to ns-resolution time stamps.
2799 (Faccept_process_output, wait_reading_process_output):
2800 Check for time stamp overflow. Do not assume time_t is signed.
2801 (select_wrapper): Remove; we now use pselect.
2802 (Fprocess_attributes): Now generates ns-resolution time stamps.
2804 * sysdep.c: Include utimens.h. Don't include utime.h
2805 or worry about struct utimbuf; gnulib does that for us now.
2806 (gettimeofday): Remove; gnulib provides a substitute.
2807 (make_timeval): New function.
2808 (set_file_times): Now sets ns-resolution time stamps.
2809 New arg FD; all uses changed.
2810 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2811 (system_process_attributes):
2812 Now returns ns-resolution time stamp. All uses changed.
2813 Check for time stamp overflow.
2815 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2816 provides a substitute now.
2818 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2819 since it guarantees struct timespec.
2820 (EMACS_TIME): Now struct timespec, so that we can support
2821 ns-resolution time stamps.
2822 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2823 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2824 (EMACS_USECS): Remove.
2825 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2826 so multiply the arg by 1000 before storing it.
2827 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2829 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2830 Port to ns-resolution time stamps.
2831 (EMACS_TIME_NEG_P): Remove; replaced by....
2832 (EMACS_TIME_SIGN): New macro.
2833 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2834 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2835 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2836 (make_timeval, make_lisp_time, decode_time_components): New decls.
2837 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2838 that it mishandled time_t overflow. You can't compare by subtracting!
2839 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2840 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2842 * term.c: Include <sys/time.h>.
2843 (timeval_to_Time): New function, for proper overflow wraparound.
2844 (term_mouse_position, term_mouse_click): Use it.
2846 * undo.c (record_first_change): Support higher-resolution time stamps
2848 (Fprimitive_undo): Use them when restoring time stamps.
2850 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2851 (w32_get_internal_run_time):
2852 Port to higher-resolution Emacs time stamps.
2853 (ltime): Now accepts single 64-bit integer, as that's more convenient
2856 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2858 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2859 for compatibility with pselect. Support ns-resolution time stamps.
2861 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2863 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2864 Check for time stamp overflow, and support ns-resolution time stamps.
2866 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2867 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2868 (timeval_subtract): Remove; no longer needed.
2869 (XTflash, XTring_bell, x_wait_for_event):
2870 Port to ns-resolution time stamps. Don't assume time_t is signed.
2872 2012-06-22 Chong Yidong <cyd@gnu.org>
2874 * xdisp.c (x_consider_frame_title): Revert last change.
2876 2012-06-22 Eli Zaretskii <eliz@gnu.org>
2878 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2879 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2880 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2881 staticidx goes up to 1597 out of 1600 = 0x640.)
2883 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2885 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2886 Otherwise, the umask might be mistakenly 0 while handling input signals.
2888 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2890 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2892 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2894 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2895 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2896 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2897 access to `contents' member of Lisp_Vector objects with AREF and ASET
2900 2012-06-19 Chong Yidong <cyd@gnu.org>
2902 * frame.c (delete_frame): When selecting a frame on a different
2903 text terminal, do not alter the terminal's top-frame.
2905 * xdisp.c (format_mode_line_unwind_data): Record the target
2906 frame's selected window and its terminal's top-frame.
2907 (unwind_format_mode_line): Restore them.
2908 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2910 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2911 since tty frames can be explicitly named.
2912 (prepare_menu_bars): Likewise.
2914 * term.c (Ftty_top_frame): New function.
2916 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2918 Port byte-code-meter to modern targets.
2919 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2920 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
2921 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
2922 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2923 (METER_1, METER_2): Simplify.
2925 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2927 * data.c (Fdefalias): Return `symbol' (bug#11686).
2929 2012-06-18 Martin Rudalics <rudalics@gmx.at>
2931 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
2932 gets killed during executing of this function (Bug#11665).
2933 Try to always return Qt when the buffer has been actually killed.
2934 (Vkill_buffer_query_functions): In doc-string say that functions
2935 run by this hook should not change the current buffer.
2937 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2939 Fix recently-introduced process.c problems found by static checking.
2940 * process.c (write_queue_push, write_queue_pop, send_process):
2941 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2942 (write_queue_pop): Fix pointer signedness problem.
2943 (send_process): Remove unused local.
2945 2012-06-17 Chong Yidong <cyd@gnu.org>
2947 * xdisp.c (redisplay_internal): No need to redisplay terminal
2948 frames that are not on top.
2950 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
2952 * process.c (make_process): Initialize write_queue.
2953 (write_queue_push, write_queue_pop): New functions.
2954 (send_process): Use them to maintain correct ordering of process
2957 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2959 * lisp.h (eassert): Assume C89 or later.
2960 This removes the need for CHECK.
2961 (CHECK): Remove. Its comments about always evaluating its
2962 argument were confusing, as 'eassert' typically does not evaluate
2965 * coding.c (produce_chars): Use ptrdiff_t, not int.
2967 * xterm.c (x_draw_underwave): Check for integer overflow.
2968 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2970 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
2972 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2973 referenced (Bug#11583).
2975 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2977 Implement wave-style variant of underlining.
2978 * dispextern.h (face_underline_type): New enum.
2979 (face): Add field for underline type.
2980 * nsterm.m (ns_draw_underwave): New function.
2981 (ns_draw_text_decoration): Use it.
2982 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2984 (x_draw_glyph_string): Use them.
2985 * xfaces.c (Qline, Qwave): New Lisp objects.
2986 (check_lface_attrs, merge_face_ref)
2987 (Finternal_set_lisp_face_attribute, realize_x_face):
2988 Handle wave-style underline face attributes.
2989 * xterm.c (x_draw_underwave): New function.
2990 (x_draw_glyph_string): Use it.
2992 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
2994 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2995 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2996 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2997 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2998 ($(BLD)/w32select.$(O)): Update dependencies.
3000 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3002 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
3003 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
3004 * character.c (_fetch_multibyte_char_p): Remove.
3005 * alloc.c: Include "character.h" before "buffer.h".
3007 * buffer.c: Likewise.
3008 * bytecode.c: Likewise.
3009 * callint.c: Likewise.
3010 * callproc.c: Likewise.
3011 * casefiddle.c: Likewise.
3012 * casetab.c: Likewise.
3013 * category.c: Likewise.
3015 * coding.c: Likewise.
3016 * composite.c: Likewise.
3017 * dired.c: Likewise.
3018 * dispnew.c: Likewise.
3020 * dosfns.c: Likewise.
3021 * editfns.c: Likewise.
3022 * emacs.c: Likewise.
3023 * fileio.c: Likewise.
3024 * filelock.c: Likewise.
3026 * fontset.c: Likewise.
3027 * fringe.c: Likewise.
3028 * indent.c: Likewise.
3029 * insdel.c: Likewise.
3030 * intervals.c: Likewise.
3031 * keyboard.c: Likewise.
3032 * keymap.c: Likewise.
3033 * lread.c: Likewise.
3034 * macros.c: Likewise.
3035 * marker.c: Likewise.
3036 * minibuf.c: Likewise.
3037 * nsfns.m: Likewise.
3038 * nsmenu.m: Likewise.
3039 * print.c: Likewise.
3040 * process.c: Likewise.
3041 * regex.c: Likewise.
3042 * region-cache.c: Likewise.
3043 * search.c: Likewise.
3044 * syntax.c: Likewise.
3046 * textprop.c: Likewise.
3048 * unexsol.c: Likewise.
3049 * w16select.c: Likewise.
3050 * w32fns.c: Likewise.
3051 * w32menu.c: Likewise.
3052 * window.c: Likewise.
3053 * xdisp.c: Likewise.
3055 * xmenu.c: Likewise.
3057 * xselect.c: Likewise.
3059 2012-06-16 Eli Zaretskii <eliz@gnu.org>
3061 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
3062 If all the glyphs of the glyph row came from strings, and we have no
3063 cursor positioning clues, put the cursor on the first glyph of the
3065 (handle_face_prop): Use chunk-relative overlay string index when
3066 indexing into it->string_overlays array. (Bug#11653)
3067 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
3068 the rightmost. (Bug#11720)
3070 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3072 * category.h (CHAR_HAS_CATEGORY): Define as inline.
3073 (CATEGORY_MEMBER): Enforce 1/0 value.
3074 * category.c (_temp_category_set): Remove.
3076 2012-06-16 Eli Zaretskii <eliz@gnu.org>
3078 * window.c (Fdelete_other_windows_internal)
3079 (Fdelete_window_internal): Don't access frame's mouse highlight
3080 info of the initial frame. (Bug#11677)
3082 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
3084 * .gdbinit (xgetint): Fix recently-introduced paren typo.
3085 Assume USE_2_TAGS_FOR_INTS.
3086 (xreload): Adjust $tagmask width to match recent lisp.h change.
3088 Simplify lisp.h in minor ways that should not affect code.
3089 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
3090 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
3091 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
3092 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
3093 (INTTYPEBITS): New macro, for clarity.
3094 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
3095 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
3096 Simplify now that USE_LSB_TAG is always defined.
3097 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
3098 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
3100 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
3102 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
3104 2012-06-13 Glenn Morris <rgm@gnu.org>
3106 * s/bsd-common.h (BSD4_3):
3107 * s/usg5-4-common.h (USG5_4): No longer define; unused.
3109 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
3111 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
3114 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
3116 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
3117 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
3118 * alloc.c (widen_to_Lisp_Object): Remove.
3119 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
3120 * frame.c (delete_frame): Remove outdated comment.
3121 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
3122 USE_LISP_UNION_TYPE.
3123 (Fw32_unregister_hot_key): Likewise.
3124 (Fw32_toggle_lock_key): Likewise.
3125 * w32menu.c (add_menu_item): Likewise.
3126 (w32_menu_display_help): Use XIL instead of checking
3127 USE_LISP_UNION_TYPE.
3128 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
3129 (init_heap): Likewise.
3130 * w32term.c (w32_read_socket): Update comment.
3132 2012-06-13 Glenn Morris <rgm@gnu.org>
3134 * s/usg5-4-common.h, src/s/unixware.h:
3135 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
3137 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
3139 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
3141 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
3142 * alloc.c (make_number) [!defined make_number]:
3143 Remove, as lisp.h always defines this now.
3144 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
3145 (roundup_size): Verify that it is a power of 2.
3146 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
3147 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
3148 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
3149 -DUSE_LSB_TAG=0, to override the automatically-selected default.
3150 USE_LSB_TAG now is always defined to be either 0 or 1.
3152 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
3153 code works fine either way, and efficiency is not a concern here,
3154 as the union type is for debugging, not for production.
3155 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
3156 Use an inline function on all platforms when using the union type,
3157 since this is simpler and 'static inline' can be used portably
3159 (LISP_INITIALLY_ZERO): New macro.
3160 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
3161 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
3163 2012-06-12 Glenn Morris <rgm@gnu.org>
3165 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
3167 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
3169 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
3170 Move BROKEN_SIGIO to configure.
3172 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
3173 Move NO_TERMIO to configure.
3175 2012-06-12 Chong Yidong <cyd@gnu.org>
3177 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3178 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3179 MagickExportImagePixels is undefined.
3181 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3183 * image.c (imagemagick_load_image): Remove unused label.
3185 2012-06-11 Glenn Morris <rgm@gnu.org>
3187 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3188 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3189 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3190 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3192 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3194 * alloc.c (make_byte_code): New function.
3195 (Fmake_byte_code): Use it. Don't purify here.
3196 * lread.c (read1): Use it as well to avoid extra allocation.
3198 2012-06-11 Chong Yidong <cyd@gnu.org>
3200 * image.c (imagemagick_load_image): Implement transparency.
3202 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3204 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3205 account for preceding backslashes. (Bug#11663)
3207 2012-06-09 Chong Yidong <cyd@gnu.org>
3209 * term.c: Support italics in capable terminals (Bug#9652).
3210 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3211 (turn_on_face): Output using TS_enter_italic_mode if available.
3212 Don't handle unused blinking and alt-charset cases.
3213 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3214 and tty_alt_charset_p cases.
3215 (tty_capable_p, init_tty): Support italics.
3217 * termchar.h (struct tty_display_info): Add field for italics.
3218 Remove unused blink field.
3220 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3223 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3224 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3225 tty_alt_charset_p. Add tty_italic_p.
3227 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
3229 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3230 dbus_type_is_basic if available.
3231 (xd_extract_signed, xd_extract_unsigned): Rename from
3232 extract_signed and extract_unsigned, respectively. Adapt callers.
3234 2012-06-09 Chong Yidong <cyd@gnu.org>
3236 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3238 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3241 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3243 * xdisp.c (vmessage): Treat frame message as multibyte.
3244 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3245 would generate the diagnostic "Making \302\247 buffer-local while
3248 2012-06-08 Eli Zaretskii <eliz@gnu.org>
3250 * dispnew.c (showing_window_margins_p): Undo last change, which
3251 was done due to an inadvertent commit.
3252 (adjust_frame_glyphs_for_frame_redisplay): Do call
3253 showing_window_margins_p.
3255 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3257 * eval.c (Fmake_var_non_special): New primitive.
3258 (syms_of_eval): Defsubr it.
3259 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3261 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
3263 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3264 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3266 2012-06-08 Eli Zaretskii <eliz@gnu.org>
3268 * alloc.c (allocate_vectorlike): Fix last change.
3270 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3272 Block-based vector allocation of small vectors.
3273 * lisp.h (struct vectorlike_header): New field `nbytes',
3274 adjust comment accordingly.
3275 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3276 to denote vector blocks. Adjust users (live_vector_p,
3277 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3278 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3279 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3280 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3281 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3282 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3283 (roundup_size): New constant.
3284 (struct vector_block): New data type.
3285 (vector_blocks, vector_free_lists, zero_vector): New variables.
3286 (all_vectors): Rename to `large_vectors'.
3287 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3288 (sweep_vectors): New functions.
3289 (allocate_vectorlike): Return `zero_vector' as the only vector of
3290 0 items. Allocate new vector from block if vector size is less than
3291 or equal to VBLOCK_BYTES_MAX.
3292 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3293 (init_alloc_once): Add call to init_vectors.
3295 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3297 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3299 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3301 * doprnt.c (doprnt): Truncate multibyte char correctly.
3302 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3303 would mishandle a string argument "Xc" if X was a multibyte
3304 character of length 2: it would truncate after X's first byte
3305 rather than including all of X.
3307 2012-06-06 Chong Yidong <cyd@gnu.org>
3309 * buffer.c (word_wrap): Doc fix.
3311 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3313 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3315 2012-06-03 Glenn Morris <rgm@gnu.org>
3317 * xdisp.c (tool-bar-style): Doc fix.
3319 2012-06-03 Ulrich Müller <ulm@gentoo.org>
3321 * Makefile.in (PAXCTL): Define.
3322 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3323 binary via PaX flags if the paxctl utility is available.
3324 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3325 Restore PaX flags to their default. (Bug#11398)
3327 2012-06-03 Chong Yidong <cyd@gnu.org>
3329 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3332 2012-06-03 Chong Yidong <cyd@gnu.org>
3334 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3335 (note_mode_line_or_margin_highlight): If there is no help echo,
3336 use mode-line-default-help-echo. Handle the case where the mouse
3337 position is past the end of the mode line string.
3339 * buffer.c (buffer_local_value_1): New function, split from
3340 Fbuffer_local_value; can return Qunbound.
3341 (Fbuffer_local_value): Use it.
3342 (Vmode_line_format): Docstring tweaks.
3344 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3346 * sysdep.c (system_process_attributes): Improve comment.
3348 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3350 * keyboard.c: Export real-this-command to Elisp.
3351 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3352 and DEFVAR it. Update all users.
3354 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3356 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3358 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3359 Convert pctcpu and pctmem to Lisp float properly.
3360 Let the compiler fold better, as 100.0/0x8000 is exact.
3362 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3364 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3367 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3369 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3371 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3373 For a 'struct window', replace some Lisp_Object fields to
3374 bitfields where appropriate, remove unused fields.
3375 * window.h (struct window): Remove unused 'last_mark_x' and
3376 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3377 change it's type from Lisp_Object to bitfield.
3378 Change type of 'force_start', 'optional_new_start',
3379 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3380 fields from Lisp_Object to bitfield. Adjust users accordingly.
3382 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3384 Pacify gcc -Wdouble-precision when using Xaw.
3385 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3386 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3387 Use 'float' consistently, rather than 'float' in most places
3388 and 'double' in a couple of places.
3390 2012-05-31 Eli Zaretskii <eliz@gnu.org>
3392 * xdisp.c (handle_stop): Detect whether we have overlay strings
3393 loaded by testing it->current.overlay_string_index to be
3394 non-negative, instead of checking whether n_overlay_strings is
3395 positive. (Bug#11587)
3397 2012-05-31 Chong Yidong <cyd@gnu.org>
3399 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3401 * doc.c (Fsubstitute_command_keys): Doc fix.
3403 2012-05-31 Eli Zaretskii <eliz@gnu.org>
3405 * search.c (search_buffer): Remove calls to
3406 r_alloc_inhibit_buffer_relocation, as it is now called by
3407 maybe_unify_char, which was the cause of relocation of buffer text
3410 2012-05-31 Eli Zaretskii <eliz@gnu.org>
3412 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3413 for the duration of call to load_charset, to avoid problems with
3414 callers of maybe_unify_char that access buffer text through C
3417 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3418 decrement the inhibition flag, instead of just setting or
3421 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3423 Remove obsolete '#define static' cruft.
3424 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3425 This #undef was "temporary" in 2000; it is no longer needed
3426 now that '#define static' has gone away.
3427 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3428 (gray_bitmap_bits): Remove; no longer needed.
3429 All uses replaced with definiens.
3430 * xterm.c: Include "bitmaps/gray.xbm".
3432 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3434 Clean up __executable_start, monstartup when --enable-profiling.
3435 The following changes affect the code only when profiling.
3436 * dispnew.c (__executable_start): Rename from safe_bcopy.
3437 Define only on platforms that need it.
3438 * emacs.c: Include <sys/gmon.h> when profiling.
3439 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3440 (__executable_start): Remove decl, since lisp.h does it now.
3441 (safe_bcopy): Remove decl; no longer has that name.
3442 (main): Coalesce #if into single bit of code, for simplicity.
3443 Cast pointers to uintptr_t, since standard libraries want integers
3445 * lisp.h (__executable_start): New decl.
3447 2012-05-31 Glenn Morris <rgm@gnu.org>
3449 * image.c (Fimagemagick_types): Doc fix.
3451 2012-05-30 Jim Meyering <meyering@redhat.com>
3453 * callproc.c (Fcall_process_region): Include directory component
3454 in mkstemp error message (Bug#11586).
3456 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3458 * alloc.c, lisp.h (make_pure_vector): Now static.
3460 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3462 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3463 Move to byte-run.el.
3464 (Fautoload): Do the hash-doc more carefully.
3465 * data.c (Fdefalias): Purify definition, except for keymaps.
3466 (Qdefun): Move from eval.c.
3467 * lisp.h (Qdefun): Remove.
3468 * lread.c (read1): Tiny simplification.
3470 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
3472 Do not create empty overlays with the evaporate property (Bug#9642).
3473 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3474 Bug#9642, but explicitly check that the buffer the overlay would
3475 be moved to is live and rearrange lines to make sure that errors
3476 will not put the overlay in an inconsistent state.
3477 (Fdelete_overlay): Cosmetics.
3479 2012-05-28 Eli Zaretskii <eliz@gnu.org>
3481 * w32term.c (my_bring_window_to_top): New function.
3482 (x_raise_frame): Use handle returned by DeferWindowPos, which
3483 could be different from the original one.
3484 Call my_bring_window_to_top instead of my_set_foreground_window.
3487 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3488 by calling BringWindowToTop.
3490 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3491 (WM_EMACS_END): Increase by one.
3493 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3495 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3496 This avoids undefined behavior that might cause the eassert
3497 to not catch an out-of-range value.
3499 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
3501 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3502 Update dependencies.
3504 2012-05-27 Eli Zaretskii <eliz@gnu.org>
3506 * bidi.c (bidi_mirror_char): Fix last change.
3508 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3510 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3511 when referring to sectname field in printf format.
3513 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3515 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3516 Only r_alloc_inhibit_buffer_relocation needed to be added;
3517 the others were already declared.
3519 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3520 before checking whether it's out of range. Put the check inside
3522 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3524 2012-05-27 Ken Brown <kbrown@cornell.edu>
3526 * callproc.c (Fcall_process): Restore a line that was accidentally
3527 commented out in the 2011-02-13 change (bug#11547).
3529 2012-05-27 Eli Zaretskii <eliz@gnu.org>
3531 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3532 defined on ralloc.c.
3534 * buffer.c [REL_ALLOC]: Remove prototypes of
3535 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3536 they are now on lisp.h.
3538 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3540 * search.c (search_buffer): Use it to inhibit relocation of buffer
3541 text while re_search_2 is doing its job, because re_search_2 is
3542 passed C pointers to buffer text. (Bug#11519)
3544 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3547 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3548 state after an additional call to move_it_in_display_line_to, keep
3549 the values of it->max_ascent and it->max_descent found for the
3551 (pos_visible_p): Revert the comparison against bottom_y to what it
3552 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3555 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3557 Fix coding-related core dumps with gcc -ftrapv.
3558 The code was computing A - B, where A and B are pointers, and B is
3559 random garbage. This can lead to core dumps on platforms that
3560 have special pointer registers, and it also leads to core dumps on
3561 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3562 A - B only when B is initialized properly.
3563 * coding.c (coding_set_source, coding_set_destination): Return void.
3564 (coding_change_source, coding_change_destinations): New functions,
3565 with the old behaviors of coding_set_source and coding_set_destination.
3566 All callers that need an offset changed to use these new functions.
3568 2012-05-26 Glenn Morris <rgm@gnu.org>
3570 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3572 2012-05-26 Eli Zaretskii <eliz@gnu.org>
3574 Extend mouse support on W32 text-mode console.
3575 * xdisp.c (draw_row_with_mouse_face):
3576 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
3578 * w32console.c: Include window.h.
3579 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3581 (initialize_w32_display): Initialize mouse-highlight data.
3583 * w32inevt.c: Include termchar.h and window.h.
3584 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3585 moves, call note_mouse_highlight. If help_echo changed, call
3586 gen_help_event to produce help-echo message in the echo area.
3587 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3590 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3592 * lread.c (read1): Simplify slightly to avoid an overflow warning
3593 with GCC 4.7.0 on x86-64.
3595 2012-05-26 Eli Zaretskii <eliz@gnu.org>
3597 * bidi.c (bidi_mirror_char): Revert last change: an int is
3598 definitely wide enough here.
3600 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3602 Fix integer width and related bugs (Bug#9874).
3603 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
3604 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3605 (string_bytes, check_sblock, allocate_string_data):
3606 (compact_small_strings, Fmake_bool_vector, make_string)
3607 (make_unibyte_string, make_multibyte_string)
3608 (make_string_from_bytes, make_specified_string)
3609 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3610 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3612 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3613 (allocate_pseudovector):
3614 Use int, not EMACS_INT, where int is wide enough.
3615 (inhibit_garbage_collection, Fgarbage_collect):
3616 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3617 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3618 int might not be wide enough.
3619 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3620 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3621 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3622 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3623 (bidi_level_of_next_char, bidi_move_to_visually_next):
3624 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3625 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3626 (Fkill_buffer, Fset_buffer_major_mode)
3627 (advance_to_char_boundary, Fbuffer_swap_text)
3628 (Fset_buffer_multibyte, overlays_at, overlays_in)
3629 (overlay_touches_p, struct sortvec, record_overlay_string)
3630 (overlay_strings, recenter_overlay_lists)
3631 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3632 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3633 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3634 (Foverlay_recenter, last_overlay_modification_hooks_used)
3635 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3636 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3637 (validate_region): Omit unnecessary test for b <= e,
3638 since that's guaranteed by the previous test.
3639 (adjust_overlays_for_delete): Avoid pos + length overflow.
3640 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3641 (report_overlay_modification):
3642 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3643 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3644 Omit pointer cast, which isn't needed anyway, and doesn't work
3645 after the EMACS_INT -> ptrdiff_t change.
3646 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
3647 * buffer.h: Adjust decls to match defn changes elsewhere.
3648 (struct buffer_text, struct buffer):
3649 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3650 Use EMACS_INT, not int, where int might not be wide enough.
3651 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3652 not int, to avoid needless 32-bit limit on 64-bit hosts.
3653 (exec_byte_code): Use tighter memory-full test, one that checks
3654 for alloca overflow. Don't compute the address of the object just
3655 before an array, as that's not portable. Use EMACS_INT, not
3656 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
3657 * callint.c (Fcall_interactively):
3658 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3659 * callproc.c (call_process_kill, Fcall_process):
3660 Don't assume pid_t fits into an Emacs fixnum.
3661 (call_process_cleanup, Fcall_process, child_setup):
3662 Don't assume pid_t fits into int.
3663 (call_process_cleanup, Fcall_process, delete_temp_file)
3664 (Fcall_process_region):
3665 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3666 (Fcall_process): Simplify handling of volatile integers.
3667 Use int, not EMACS_INT, where int will do.
3668 * casefiddle.c (casify_object, casify_region, operate_on_word)
3669 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3670 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3671 (casify_object): Avoid integer overflow when overallocating buffer.
3672 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
3673 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
3674 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3675 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3676 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3677 integers are now checked earlier. All uses replaced with XINT.
3679 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3680 For CCL_MapSingle, check that content and value are in int range.
3681 (ccl_driver, Fregister_code_conversion_map):
3682 Check that Vcode_version_map_vector is a vector.
3683 (resolve_symbol_ccl_program): Check that vector header is in range.
3684 Always copy the vector, so that we can check its contents reliably
3685 now rather than having to recheck each instruction as it's being
3686 executed. Check that vector words fit in 'int'.
3687 (ccl_get_compiled_code, Fregister_ccl_program)
3688 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3689 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3690 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3691 contents are in range.
3692 (Fccl_execute_on_string): Check that status is in range.
3693 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3694 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3695 Accept and return EMACS_INT, not int, because callers can pass values
3697 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3698 (multibyte_chars_in_text, parse_str_as_multibyte)
3699 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3700 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3701 (string_escape_byte8, Fget_byte):
3702 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3703 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
3704 avoid mishandling large integers.
3705 * character.h: Adjust decls to match defn changes elsewhere.
3706 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3707 (Ffind_charset_region):
3708 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3709 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3710 (load_charset_map_from_vector, Fdefine_charset_internal):
3711 Don't assume fixnum fits in int.
3712 (load_charset_map_from_vector, Fmap_charset_chars):
3713 Remove now-unnecessary CHECK_NATNUMs.
3714 (Fdefine_charset_internal): Check ranges here, more carefully.
3715 Don't rely on undefined behavior with signed left shift overflow.
3716 Don't assume unsigned int fits into fixnum, or that fixnum fits
3717 into unsigned int. Don't require max_code to be a valid fixnum;
3718 that's not true for gb10830 4-byte on a 32-bit host. Allow
3719 invalid_code to be a cons, for the same reason. Require code_offset
3720 to be a character. Avoid int overflow if max_char is close
3722 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3723 this is intended anyway and avoids some undefined behavior.
3724 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3725 INDEX_TO_CODE_POINT, as that's what it expects.
3726 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
3727 * charset.h (DECODE_CHAR): Return int, not unsigned;
3728 this is what was intended anyway, and it avoids undefined behavior.
3729 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3730 integer-overflow issues.
3731 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3732 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3733 where the argument is EMACS_INT, and this behavior is not intended.
3734 * chartab.c (Fmake_char_table, Fset_char_table_range)
3735 (uniprop_get_decoder, uniprop_get_encoder):
3736 Don't assume fixnum fits in int.
3737 * cmds.c (move_point): New function, that does the gist of
3738 Fforward_char and Fbackward_char, but does so while checking
3739 for integer overflow more accurately.
3740 (Fforward_char, Fbackward_char): Use it.
3741 (Fforward_line, Fend_of_line, internal_self_insert)
3742 (internal_self_insert):
3743 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3744 Fix a FIXME, by checking for integer overflow when calculating
3745 target_clm and actual_clm.
3746 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
3747 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
3748 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3749 (coding_alloc_by_making_gap, alloc_destination)
3750 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3751 (encode_coding_utf_16, detect_coding_emacs_mule)
3752 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3753 (detect_coding_iso_2022, decode_coding_iso_2022)
3754 (encode_invocation_designation, encode_designation_at_bol)
3755 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3756 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3757 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3758 (encode_coding_ccl, encode_coding_raw_text)
3759 (detect_coding_charset, decode_coding_charset)
3760 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3761 (produce_composition, produce_charset, produce_annotation)
3762 (decode_coding, handle_composition_annotation)
3763 (handle_charset_annotation, consume_chars, decode_coding_gap)
3764 (decode_coding_object, encode_coding_object, detect_coding_system)
3765 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3766 (code_convert_region, code_convert_string)
3767 (Fdefine_coding_system_internal)
3768 (coding_set_source, coding_set_destination):
3769 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3770 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3771 (Fdefine_coding_system_internal):
3772 Don't assume fixnums fit in int.
3773 (decode_coding_gap, decode_coding_object, encode_coding_object)
3774 (Fread_coding_system, Fdetect_coding_region)
3775 (Funencodable_char_position, Fcheck_coding_systems_region)
3776 (get_translation, handle_composition_annotation, consume_chars):
3777 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3778 (consume_chars): Rewrite to not calculate an address outside buffer.
3779 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
3780 Don't access memory outside of the args array.
3781 (Fdefine_coding_system_internal): Check for charset-id overflow.
3782 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3783 result of ENCODE_CHAR.
3784 * coding.h: Adjust decls to match defn changes elsewhere.
3785 (struct coding_system):
3786 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3787 * composite.c (get_composition_id, find_composition)
3788 (run_composition_function, update_compositions)
3789 (compose_text, composition_gstring_put_cache)
3790 (composition_gstring_p, composition_gstring_width)
3791 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3792 (composition_compute_stop_pos, composition_reseat_it)
3793 (composition_update_it, struct position_record)
3794 (find_automatic_composition, composition_adjust_point)
3795 (Fcomposition_get_gstring, Ffind_composition_internal):
3796 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3797 (update_compositions):
3798 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3799 * composite.h: Adjust decls to match defn changes elsewhere.
3800 (struct composition):
3801 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3802 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3803 Do not attempt to compute the address of the object just before a
3804 buffer; this is not portable.
3806 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3807 (Faset): Use int, not EMACS_INT, where int is wide enough.
3808 (Fstring_to_number): Don't assume fixnums fit in int.
3809 (Frem): Don't assume arg is nonnegative.
3810 * dbusbind.c (xd_append_arg): Check for integers out of range.
3811 (Fdbus_call_method): Don't overflow the timeout int.
3812 (extract_signed, extract_unsigned): New functions.
3813 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3814 (xd_get_connection_references): Return ptrdiff_t, not int.
3816 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3817 (xd_read_message_1):
3818 Use int, not unsigned, where the dbus API uses int.
3819 (Fdbus_message_internal): Don't overflow mtype.
3820 (syms_of_dbusbind): Allocate right-sized buffer for integers.
3821 * dired.c (directory_files_internal, file_name_completion, scmp)
3822 (file_name_completion_stat):
3823 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3824 (file_name_completion): Don't overflow matchcount.
3825 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3826 * dispextern.h: Adjust decls to match defn changes elsewhere.
3827 (struct text_pos, struct glyph, struct bidi_saved_info)
3828 (struct bidi_string_data, struct bidi_it, struct composition_it)
3830 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3831 (struct display_pos, struct composition_it, struct it):
3832 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3833 * dispnew.c (increment_matrix_positions)
3834 (increment_row_positions, mode_line_string)
3835 (marginal_area_string):
3836 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3837 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
3838 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3839 (duration_to_sec_usec): New function, to check for overflow better.
3840 (Fsleep_for, sit_for): Use it.
3841 * doc.c (get_doc_string, store_function_docstring):
3842 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3843 (get_doc_string, Fsnarf_documentation):
3844 Use int, not EMACS_INT, where int is wide enough.
3846 Use SAFE_ALLOCA, not alloca.
3847 Check for overflow when converting EMACS_INT to off_t.
3848 * doprnt.c (doprnt):
3849 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3850 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3851 Don't assume uid_t fits into fixnum.
3852 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3853 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3854 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3855 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3856 (general_insert_function)
3857 (Finsert_char, make_buffer_string, make_buffer_string_both)
3858 (update_buffer_properties, Fbuffer_substring)
3859 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3860 (Fsubst_char_in_region, check_translation)
3861 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3862 (transpose_markers, Ftranspose_regions):
3863 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3864 (clip_to_bounds): Move to lisp.h as an inline function).
3865 (Fconstrain_to_field): Don't assume integers are nonnegative.
3866 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3867 (Fsubst_char_in_region, Fsave_restriction):
3868 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3869 (Femacs_pid): Don't assume pid_t fits into fixnum.
3870 (lo_time): Use int, not EMACS_INT, when int suffices.
3871 (lisp_time_argument): Check for usec out of range.
3872 (Fencode_time): Don't assume fixnum fits in int.
3873 (Fuser_login_name, Fuser_full_name): Signal an error
3874 if a uid argument is out of range, rather than relying on
3876 (Fformat_time_string): Remove now-unnecessary check.
3877 lisp_time_argument checks for out-of-range usec now.
3878 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
3879 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3880 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3881 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3882 (init_cmdargs, Fdump_emacs):
3883 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3884 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3885 the bottom (typically) 32 bits of the fixnum.
3886 * eval.c (specpdl_size, call_debugger):
3887 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3888 (when_entered_debugger, Fbacktrace_debug):
3889 Don't assume fixnum can fit in int.
3890 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3891 the object just before a buffer; this is not portable.
3892 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3893 (grow_specpdl, unbind_to):
3894 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3895 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3896 (grow_specpdl): Simplify allocation by using xpalloc.
3897 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
3898 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3899 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3900 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3901 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3903 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3904 (Fcopy_file, non_regular_nbytes, read_non_regular)
3905 (Finsert_file_contents):
3906 Use int, not EMACS_INT, where int is wide enough.
3907 (READ_BUF_SIZE): Verify that it fits in int.
3908 (Finsert_file_contents): Check that counts are in proper range,
3909 rather than assuming fixnums fit into ptrdiff_t etc.
3910 Don't assume fixnums fit into int.
3911 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
3912 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3913 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
3914 (string_char_to_byte, string_byte_to_char)
3915 (string_make_multibyte, string_to_multibyte)
3916 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3917 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3918 (substring_both, Fdelete, internal_equal, Ffillarray)
3919 (Fclear_string, mapcar1)
3920 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3921 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3922 (larger_vector, make_hash_table, maybe_resize_hash_table)
3923 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3924 (Fmaphash, secure_hash):
3925 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3926 (concat): Check for string index and length overflow.
3927 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3929 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3930 (larger_vector): New API (vec, incr_min, size_max) replaces old
3931 one (vec, new_size, init). This catches size overflow.
3932 INIT was removed because it was always Qnil.
3933 All callers changed.
3934 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3935 the upper bound on a hash table index size.
3936 (make_hash_table, maybe_resize_hash_table): Use it.
3937 (secure_hash): Computer start_byte and end_byte only after
3938 they're known to be in ptrdiff_t range.
3939 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3940 (Ffont_get_glyphs, Ffont_at):
3941 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3942 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3943 (Flist_fonts, Fopen_font):
3944 Don't assume fixnum can fit in int.
3945 (check_gstring): Don't assume index can fit in int.
3946 (font_match_p): Check that fixnum is a character, not a nonnegative
3947 fixnum, since the later code needs to stuff it into an int.
3948 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3949 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3950 conversion overflow issues.
3951 (Fopen_font): Check for integer out of range.
3952 (Ffont_get_glyphs): Don't assume index can fit in int.
3953 * font.h: Adjust decls to match defn changes elsewhere.
3954 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3956 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3957 printmax_t, where ptrdiff_t is wide enough.
3958 (Finternal_char_font):
3959 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3960 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3961 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3962 (Fset_frame_position, x_set_frame_parameters)
3963 (x_set_line_spacing, x_set_border_width)
3964 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3965 Check that fixnums are in proper range for system types.
3966 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3967 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3968 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3969 Use SAFE_ALLOCA_LISP, not alloca.
3970 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3971 intptr_t is wide enough.
3972 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3973 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3974 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3975 Check for fixnum out of range.
3976 * ftfont.c (ftfont_list): Don't assume index fits in int.
3977 Check that fixnums are in proper range for system types.
3978 (ftfont_shape_by_flt):
3979 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3980 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3981 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3982 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3983 Check that fixnums are in proper range for system types.
3984 * gnutls.h: Adjust decls to match defn changes elsewhere.
3985 * gtkutil.c (xg_dialog_run):
3986 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3987 (update_frame_tool_bar):
3988 Check that fixnums are in proper range for system types.
3989 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
3990 (lookup_image): Check that fixnums are in range for system types.
3991 * indent.c (last_known_column, last_known_column_point):
3992 (current_column_bol_cache):
3993 (skip_invisible, current_column, check_display_width):
3994 (check_display_width, scan_for_column, current_column_1)
3995 (Findent_to, Fcurrent_indentation, position_indentation)
3996 (indented_beyond_p, Fmove_to_column, compute_motion):
3997 (Fcompute_motion, Fvertical_motion):
3998 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3999 (last_known_column_modified): Use EMACS_INT, not int.
4000 (check_display_width):
4002 Check that fixnums and floats are in proper range for system types.
4003 (compute_motion): Don't assume index or fixnum fits in int.
4004 (compute_motion, Fcompute_motion):
4005 Use int, not EMACS_INT, when it is wide enough.
4006 (vmotion): Omit local var start_hpos that is always 0; that way
4007 we don't need to worry about overflow in expressions involving it.
4008 * indent.h: Adjust decls to match defn changes elsewhere.
4010 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4011 Use int, not EMACS_INT, where int is wide enough.
4012 Remove unused members ovstring_chars_done and tab_offset;
4014 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
4015 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
4016 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
4017 (make_gap, copy_text, insert, insert_and_inherit)
4018 (insert_before_markers, insert_before_markers_and_inherit)
4019 (insert_1, count_combining_before, count_combining_after)
4020 (insert_1_both, insert_from_string)
4021 (insert_from_string_before_markers, insert_from_string_1)
4022 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
4023 (adjust_after_replace, adjust_after_insert, replace_range)
4024 (replace_range_2, del_range, del_range_1, del_range_byte)
4025 (del_range_both, del_range_2, modify_region)
4026 (prepare_to_modify_buffer, signal_before_change)
4027 (signal_after_change, Fcombine_after_change_execute):
4028 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4029 * intervals.c (traverse_intervals, rotate_right, rotate_left)
4030 (balance_an_interval, split_interval_right, split_interval_left)
4031 (find_interval, next_interval, update_interval)
4032 (adjust_intervals_for_insertion, delete_node, delete_interval)
4033 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4034 (static_offset_intervals, offset_intervals)
4035 (merge_interval_right, merge_interval_left, make_new_interval)
4036 (graft_intervals_into_buffer, temp_set_point_both)
4037 (temp_set_point, set_point, adjust_for_invis_intang)
4038 (set_point_both, move_if_not_intangible, get_property_and_range)
4039 (get_local_map, copy_intervals, copy_intervals_to_string)
4040 (compare_string_intervals, set_intervals_multibyte_1):
4041 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4042 * intervals.h: Adjust decls to match defn changes elsewhere.
4044 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4045 * keyboard.c (this_command_key_count, this_single_command_key_start)
4046 (before_command_key_count, before_command_echo_length, echo_now)
4047 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
4048 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
4049 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
4050 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
4051 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4052 (last_non_minibuf_size, last_point_position, echo_truncate)
4053 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
4054 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
4055 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
4056 (stuff_buffered_input):
4057 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4058 (last_auto_save, command_loop_1, read_char):
4059 Use EMACS_INT, not int, to avoid integer overflow.
4060 (record_char): Avoid overflow in total_keys computation.
4061 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
4062 * keyboard.h: Adjust decls to match defn changes elsewhere.
4063 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
4064 (Fkey_description, Fdescribe_vector, Flookup_key):
4065 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4066 (click_position): New function, to check that positions are in range.
4067 (Fcurrent_active_maps):
4069 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4070 (Faccessible_keymaps, Fkey_description):
4071 (preferred_sequence_p):
4072 Don't assume fixnum can fit into int.
4073 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
4074 Check for integer overflow in size calculations.
4075 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
4076 avoid mishandling large integers.
4077 * lisp.h: Adjust decls to match defn changes elsewhere.
4078 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
4079 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
4080 (struct Lisp_Marker):
4081 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4082 (clip_to_bounds): Now an inline function, moved here from editfns.c.
4083 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
4084 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
4085 All callers changed.
4086 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
4087 Assume the arg has valid form, since it always does.
4088 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
4089 unsigned integer system type.
4090 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
4091 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
4092 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4093 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
4094 (duration_to_sec_usec): New decl.
4095 * lread.c (read_from_string_index, read_from_string_index_byte)
4096 (read_from_string_limit, readchar, unreadchar, openp)
4097 (read_internal_start, read1, oblookup):
4098 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4099 (Fload, readevalloop, Feval_buffer, Feval_region):
4100 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4101 (openp): Check for out-of-range argument to 'access'.
4102 (read1): Use int, not EMACS_INT, where int is wide enough.
4103 Don't assume fixnum fits into int.
4104 Fix off-by-one error that can read outside a buffer.
4105 (read_filtered_event): Use duration_to_sec_usec
4106 to do proper overflow checking on durations.
4107 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
4108 in size calculation.
4109 (Fexecute_kbd_macro):
4110 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4111 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
4112 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
4113 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
4114 (set_marker_both, set_marker_restricted_both, marker_position)
4115 (marker_byte_position, Fbuffer_has_markers_at):
4116 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4117 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
4118 * menu.c (ensure_menu_items): Rename from grow_menu_items.
4119 It now merely ensures that the menu is large enough, without
4120 necessarily growing it, as this avoids some integer overflow issues.
4121 All callers changed.
4122 (keymap_panes, parse_single_submenu, Fx_popup_menu):
4123 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4124 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
4125 Use SAFE_ALLOCA_LISP, not alloca.
4126 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
4127 to EMACS_INT. Check that fixnums are in proper range for system types.
4128 * minibuf.c (minibuf_prompt_width, string_to_object)
4129 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
4130 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
4131 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4132 (get_minibuffer, read_minibuf_unwind):
4133 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4134 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
4135 this simplifies overflow checking. All callers changed.
4136 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
4138 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4139 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
4140 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
4141 Check that fixnums are in proper range for system types.
4142 (Fx_create_frame, Fx_show_tip):
4143 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4144 * nsfont.m (ns_findfonts, nsfont_list_family):
4145 Don't assume fixnum fits in long.
4146 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
4147 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4148 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
4150 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
4151 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4152 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
4153 (PRINTDECLARE, PRINTPREPARE):
4154 (strout, print_string):
4155 (print, print_preprocess, print_check_string_charset_prop)
4157 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4159 (temp_output_buffer_setup, Fprin1_to_string, print_object):
4160 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4161 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
4162 (printchar, strout): Use xpalloc to catch size calculation overflow.
4163 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
4164 (print_error_message): Use SAFE_ALLOCA, not alloca.
4165 (print_object): Use int, not EMACS_INT, where int is wide enough.
4166 (print_depth, new_backquote_output, print_number_index):
4167 Use ptrdiff_t, not int, where int might not be wide enough.
4168 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
4169 (Fset_process_window_size, Fformat_network_address)
4170 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
4172 Check that fixnums are in proper range for system types.
4173 (Fsignal_process): Simplify by avoiding a goto.
4174 Check for process-ids out of pid_t range rather than relying on
4176 (process_tick, update_tick): Use EMACS_INT, not int.
4177 (Fformat_network_address, read_process_output, send_process)
4178 (Fprocess_send_region, status_notify):
4179 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4180 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4181 (wait_reading_process_output, read_process_output, exec_sentinel):
4182 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4183 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4184 (Faccept_process_output): Use duration_to_sec_usec to do proper
4185 overflow checking on durations.
4186 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4187 Don't assume pid_t fits in int.
4188 * process.h (struct Lisp_Process): Members tick and update_tick
4189 are now of type EMACS_INT, not int.
4190 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4191 configured --with-wide-int.
4192 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4193 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4194 * search.c (looking_at_1, string_match_1):
4195 (fast_string_match, fast_c_string_match_ignore_case)
4196 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4197 (scan_newline, find_before_next_newline, search_command)
4198 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4199 (set_search_regs, wordify):
4202 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4203 (string_match_1, search_buffer, set_search_regs):
4205 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4206 (wordify): Check for overflow in size calculation.
4207 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4208 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4209 Check that fixnums are in proper range for system types.
4210 * sound.c (struct sound_device)
4211 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4212 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4213 (Fplay_sound_internal):
4214 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4215 * syntax.c (struct lisp_parse_state, find_start_modiff)
4216 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4217 (Fparse_partial_sexp):
4218 Don't assume fixnums can fit in int.
4219 (struct lisp_parse_state, find_start_pos, find_start_value)
4220 (find_start_value_byte, find_start_begv)
4221 (update_syntax_table, char_quoted, dec_bytepos)
4222 (find_defun_start, prev_char_comend_first, back_comment):
4223 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4224 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4225 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4226 (Finternal_describe_syntax_value): Check that match_lisp is a
4227 character, not an integer, since the code stuffs it into int.
4228 (scan_words, scan_sexps_forward):
4229 Check that fixnums are in proper range for system types.
4231 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4232 (scan_sexps_forward):
4233 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4234 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4235 * syntax.h: Adjust decls to match defn changes elsewhere.
4236 (struct gl_state_s):
4237 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4238 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4239 MOST_POSITIVE_FIXNUM.
4240 * sysdep.c (wait_for_termination_1, wait_for_termination)
4241 (interruptible_wait_for_termination, mkdir):
4242 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4243 (emacs_read, emacs_write):
4244 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4245 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4246 and double all fit in int.
4247 * term.c (set_tty_color_mode):
4248 Check that fixnums are in proper range for system types.
4249 * termhooks.h (struct input_event):
4250 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4251 * textprop.c (validate_interval_range, interval_of)
4252 (Fadd_text_properties, set_text_properties_1)
4253 (Fremove_text_properties, Fremove_list_of_text_properties)
4254 (Ftext_property_any, Ftext_property_not_all)
4255 (copy_text_properties, text_property_list, extend_property_ranges)
4256 (verify_interval_modification):
4257 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4258 (Fnext_single_char_property_change)
4259 (Fprevious_single_char_property_change):
4260 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4261 (copy_text_properties):
4262 Check for integer overflow in index calculation.
4263 * undo.c (last_boundary_position, record_point, record_insert)
4264 (record_delete, record_marker_adjustment, record_change)
4265 (record_property_change):
4266 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4267 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4268 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4269 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4270 (Fx_hide_tip, Fx_file_dialog):
4271 * w32menu.c (set_frame_menubar):
4272 Use ptrdiff_t, not int, for consistency with rest of code.
4273 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4274 (select_window, Fdelete_other_windows_internal)
4275 (window_scroll_pixel_based, window_scroll_line_based)
4276 (Frecenter, Fset_window_configuration):
4277 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4278 (Fset_window_hscroll, run_window_configuration_change_hook)
4279 (set_window_buffer, temp_output_buffer_show, scroll_command)
4280 (Fscroll_other_window, Frecenter):
4281 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4282 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4283 Don't assume fixnum fits in int.
4284 (Fset_window_scroll_bars):
4285 Check that fixnums are in proper range for system types.
4286 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4287 (string_pos, c_string_pos, number_of_chars, init_iterator)
4288 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4289 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4290 (compute_display_string_end, handle_face_prop)
4291 (face_before_or_after_it_pos, handle_invisible_prop)
4292 (handle_display_prop, handle_display_spec, handle_single_display_spec)
4293 (display_prop_intangible_p, string_buffer_position_lim)
4294 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4295 (get_overlay_strings_1, get_overlay_strings)
4296 (iterate_out_of_display_property, forward_to_next_line_start)
4297 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4298 (get_next_display_element, set_iterator_to_next)
4299 (get_visually_first_element, compute_stop_pos_backwards)
4300 (handle_stop_backwards, next_element_from_buffer)
4301 (move_it_in_display_line_to, move_it_in_display_line)
4302 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4303 (add_to_log, message_dolog, message_log_check_duplicate)
4304 (message2, message2_nolog, message3, message3_nolog
4305 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4306 (current_message_1, truncate_echo_area, truncate_message_1)
4307 (set_message, set_message_1, store_mode_line_noprop)
4308 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4309 (text_outside_line_unchanged_p, check_point_in_composition)
4310 (reconsider_clip_changes)
4311 (redisplay_internal, set_cursor_from_row, try_scrolling)
4312 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4313 (redisplay_window, find_last_unchanged_at_beg_row)
4314 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4315 (trailing_whitespace_p, find_row_edges, display_line)
4316 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4317 (display_mode_element, store_mode_line_string)
4318 (pint2str, pint2hrstr, decode_mode_spec)
4319 (display_count_lines, display_string, draw_glyphs)
4320 (x_produce_glyphs, x_insert_glyphs)
4321 (rows_from_pos_range, mouse_face_from_buffer_pos)
4322 (fast_find_string_pos, mouse_face_from_string_pos)
4323 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4324 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4325 (safe_call, init_from_display_pos, handle_fontified_prop)
4326 (handle_single_display_spec, load_overlay_strings)
4327 (with_echo_area_buffer, setup_echo_area_for_printing)
4328 (display_echo_area, echo_area_display)
4329 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4330 (update_tool_bar, hscroll_window_tree, redisplay_internal)
4331 (redisplay_window, dump_glyph_row, display_mode_line)
4332 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
4333 (handle_display_spec, display_prop_string_p):
4334 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4335 (handle_single_display_spec, build_desired_tool_bar_string)
4336 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4337 (get_specified_cursor_type):
4338 Check that fixnums are in proper range for system types.
4339 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4340 (Flookup_image_map):
4341 Don't assume fixnums fit in int.
4342 (compare_overlay_entries):
4343 Avoid mishandling comparisons due to subtraction overflow.
4344 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4345 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4346 (handle_tool_bar_click):
4347 Use int, not unsigned, since we prefer signed and the signedness
4348 doesn't matter here.
4349 (get_next_display_element, next_element_from_display_vector):
4350 Use int, not EMACS_INT, when int is wide enough.
4351 (start_hourglass): Use duration_to_sec_usec to do proper
4352 overflow checking on durations.
4353 * xfaces.c (Fbitmap_spec_p):
4354 Check that fixnums are in proper range for system types.
4355 (compare_fonts_by_sort_order):
4356 Avoid mishandling comparisons due to subtraction overflow.
4357 (Fx_family_fonts, realize_basic_faces):
4358 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4360 Don't assume fixnum fits in int.
4361 Use SAFE_ALLOCA_LISP, not alloca.
4362 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4363 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4364 (face_at_buffer_position, face_for_overlay_string)
4365 (face_at_string_position):
4366 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4367 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4368 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4370 Check that fixnums are in proper range for system types.
4371 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4372 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4373 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4374 (Fx_change_window_property): Don't assume fixnums fit in int.
4375 * xfont.c (xfont_chars_supported):
4376 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4377 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4378 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4379 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4380 * xml.c (parse_region):
4381 * xrdb.c (magic_file_p):
4382 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4383 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4384 (x_get_local_selection, x_reply_selection_request)
4385 (x_handle_selection_request, wait_for_property_change):
4386 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4387 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4388 short is wide enough.
4389 (x_send_client_event): Don't assume fixnum fits in int.
4390 * xterm.c (x_x_to_emacs_modifiers):
4391 Don't assume EMACS_INT overflows nicely into int.
4392 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4394 (handle_one_xevent): NATNUMP can eval its arg twice.
4395 (x_connection_closed):
4396 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4397 * xterm.h: Adjust decls to match defn changes elsewhere.
4398 (struct scroll_bar): Use struct vectorlike_header
4399 rather than rolling our own approximation.
4400 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4402 2012-05-25 Glenn Morris <rgm@gnu.org>
4404 * lisp.mk (lisp): Update for more files being compiled now.
4406 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4408 * lread.c: Remove `read_pure' which makes no difference.
4409 (read_pure): Remove var.
4410 (unreadpure): Remove function.
4411 (readevalloop): Don't call read_list with -1 flag.
4412 (read1, read_vector): Don't test read_pure any more.
4413 (read_list): Simplify.
4415 * fileio.c, character.h: Minor style tweaks.
4417 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4419 * window.h (clip_changed): Remove useless declaration.
4421 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
4423 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4424 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4426 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4429 This directory predates autoconf and is no longer needed nowadays.
4430 Move its few remaining bits of functionality to where they're needed.
4431 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4432 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4433 * m/template.h: Remove.
4434 * Makefile.in (M_FILE): Remove. All uses removed.
4435 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4436 * lisp.h (USE_LSB_TAG):
4437 * mem-limits.h (EXCEEDS_LISP_PTR):
4438 Use VAL_MAX, not VALBITS, in #if.
4439 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4440 (EMACS_UINT): Define unconditionally now.
4441 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4442 (BITS_PER_EMACS_INT): New constants, replacing
4443 what used to be in config.h, but not useful in #if.
4444 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4445 define them any more.
4446 (VAL_MAX): New macro.
4448 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4449 BITS_PER_EMACS_INT, in #if.
4450 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4451 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4452 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4453 * s/ms-w32.h (DATA_START):
4454 Move here from removed file m/intel386.h.
4455 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4456 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4458 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4460 Assume C89 or later.
4461 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4462 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4464 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4465 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4466 * textprop.c, tparam.c (NULL): Remove.
4467 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4468 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4469 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4470 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4471 * xterm.c (input_signal_count): Assume volatile works.
4473 2012-05-21 Ken Brown <kbrown@cornell.edu>
4475 * xgselect.c (xg_select): Fix first argument in call to 'select'
4478 2012-05-20 Ken Brown <kbrown@cornell.edu>
4480 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
4481 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
4483 2012-05-19 Ken Brown <kbrown@cornell.edu>
4485 * xfns.c (x_in_use): Remove `static' qualifier.
4486 * xterm.h (x_in_use): Declare.
4487 * xgselect.c: Include xterm.h.
4488 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4489 and `display_arg' (bug#9754).
4491 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4493 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4495 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4496 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4498 2012-05-18 Eli Zaretskii <eliz@gnu.org>
4500 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4502 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
4503 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
4505 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4506 reference to image_cache->refcount.
4507 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4509 2012-05-17 Juri Linkov <juri@jurta.org>
4511 * search.c (Fword_search_regexp, Fword_search_backward)
4512 (Fword_search_forward, Fword_search_backward_lax)
4513 (Fword_search_forward_lax): Move functions to isearch.el
4514 (bug#10145, bug#11381).
4516 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4518 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4520 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4522 * lread.c (init_obarray): Declare Qt and Qnil as special.
4524 2012-05-14 Glenn Morris <rgm@gnu.org>
4526 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
4527 Put "libexec" before "bin", for the sake of init_callproc_1.
4529 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4531 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4533 * unexaix.c: Port to more-recent AIX compilers.
4534 (report_error, report_error_1, make_hdr, copy_sym)
4535 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4536 Make arguments const char *, not char *, to avoid violations of C
4537 standard and to fix some AIX warnings reported by Gilles Pion.
4539 2012-05-14 Eli Zaretskii <eliz@gnu.org>
4541 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4542 already have overlays loaded.
4543 (handle_single_display_spec): Before returning without displaying
4544 fringe bitmap, synchronize the bidi iterator with the main display
4545 iterator, by calling iterate_out_of_display_property.
4546 (iterate_out_of_display_property): Detect buffer iteration by
4547 testing that it->string is a Lisp string.
4548 (get_next_display_element): When the current object is exhausted,
4549 and there's something on it->stack, call set_iterator_to_next to
4550 proceed with what's on the stack, instead of returning zero.
4551 (set_iterator_to_next): If called at the end of a Lisp string,
4552 proceed to consider_string_end without incrementing string
4553 position. Don't increment display vector index past the end of
4554 the display vector. (Bug#11417)
4555 (pos_visible_p): Don't report a position visible when move_it_to
4556 stopped at the last line of window, which happens to be scanned
4557 backwards by the bidi iteration. (Bug#11464)
4559 2012-05-14 Eli Zaretskii <eliz@gnu.org>
4561 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4562 and right-margin display specs even if the spec is invalid or we
4563 are on a TTY, and thus unable to display on the fringes.
4564 That's because the text with the property will not be displayed anyway,
4565 so we need to signal to the caller that this is a "replacing"
4566 display spec. This fixes display when the spec is invalid or we
4569 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4571 * unexaix.c (make_hdr): Fix typo in prototype.
4572 This bug broke the build on AIX. Problem reported by Gilles Pion.
4574 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
4576 * keyboard.c (kbd_buffer_get_event): Read special events also in
4577 batch mode. (Bug#11415)
4579 2012-05-12 Glenn Morris <rgm@gnu.org>
4581 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4583 2012-05-12 Eli Zaretskii <eliz@gnu.org>
4585 * lisp.mk (lisp): Add newcomment.elc.
4587 2012-05-12 Glenn Morris <rgm@gnu.org>
4589 * Makefile.in (MKDIR_P): New, set by configure.
4590 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4592 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4594 Remove unused function hourglass_started.
4595 * dispextern.h (hourglass_started):
4596 * w32fns.c (hourglass_started):
4597 * xdisp.c (hourglass_started): Remove.
4599 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
4601 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4602 Update dependencies.
4604 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4606 * xgselect.c (xg_select): Put maxfds+1 into a var.
4607 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4609 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4611 2012-05-10 Dave Abrahams <dave@boostpro.com>
4613 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4614 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4616 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
4618 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4619 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4620 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4621 Initialize xd_registered_buses.
4623 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4625 Untag more efficiently if USE_LSB_TAG.
4626 This is based on a proposal by YAMAMOTO Mitsuharu in
4627 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4628 For an admittedly artificial (nth 8000 longlist) benchmark on
4629 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4630 Emacs's overall text size by 1%.
4631 * lisp.h (XUNTAG): New macro.
4632 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4633 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4634 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4635 * eval.c (Fautoload):
4636 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4637 * frame.h (XFRAME): Use XUNTAG.
4639 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4640 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4641 Remove unportable assumptions about print widths of types like
4643 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4644 intptr_t when converting between pointer and integer, to avoid GCC
4645 warnings about wrong width.
4647 2012-05-09 Eli Zaretskii <eliz@gnu.org>
4649 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4650 stack for each reader_thread, instead of defaulting to 8MB
4651 determined by the linker. This avoids failures in creating
4652 subprocesses on Windows 7, see the discussion in this thread:
4653 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4655 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4657 Fix up display of the *Minibuf-0* buffer in the mini window.
4658 * keyboard.c (read_char): Don't clear the echo area if there's no
4660 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
4661 contents of *Minibuf-0*) if there's no message displayed in its stead.
4663 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
4665 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4668 2012-05-06 Chong Yidong <cyd@gnu.org>
4670 * lisp.mk (lisp): Update.
4672 2012-05-05 Jim Meyering <meyering@redhat.com>
4674 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4676 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4678 * data.c (PUT_ERROR): New macro.
4679 (syms_of_data): Use it. Add new error type `user-error'.
4680 * undo.c (user_error): New function.
4681 (Fprimitive_undo): Use it.
4682 * print.c (print_error_message): Adjust print style for `user-error'.
4683 * keyboard.c (user_error): New function.
4684 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4686 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4688 Do not limit current-time-string to years 1000..9999.
4689 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4690 (Fcurrent_time_string): Support any year that is supported by the
4691 underlying localtime representation. Don't use asctime, as it
4692 has undefined behavior for years outside the range -999..9999.
4694 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4696 Fix race conditions involving setenv, gmtime, localtime, asctime.
4697 Without this fix, interrupts could mess up code that uses these
4698 nonreentrant functions, since setting TZ invalidates existing
4699 tm_zone or tzname values, and since most of these functions return
4700 pointers to static storage.
4701 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4702 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4703 Grow the critical sections to include not just invoking
4704 localtime/gmtime, but also accessing these functions' results
4705 including their tm_zone values if any, and any related TZ setting.
4706 (format_time_string): Last arg is now struct tm *, not struct tm **,
4707 so that the struct tm is saved in the critical section.
4708 All callers changed. Simplify allocation of initial buffer, partly
4709 motivated by the fact that memory allocation needs to be outside
4710 the critical section.
4712 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4714 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4715 with RESET_INTERVAL.
4717 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4718 Remove duplicated buffer name initialization.
4720 2012-05-02 Jim Meyering <jim@meyering.net>
4722 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4724 * xfns.c (x_window): Use xstrdup (Bug#11375).
4726 2012-05-02 Eli Zaretskii <eliz@gnu.org>
4728 * xdisp.c (pos_visible_p): If already at a newline from the
4729 display string before the 'while' loop, don't walk back the glyphs
4730 from it3.glyph_row. Solves assertion violation when the display
4731 string begins with a newline (egg.el). (Bug#11367)
4733 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4735 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4738 2012-05-01 Glenn Morris <rgm@gnu.org>
4740 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4741 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4742 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4743 All were removed before 23.1.
4745 * dispnew.c: Remove HAVE_LIBNCURSES test;
4746 it is always true on relevant platforms.
4748 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4749 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4751 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4753 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4755 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4756 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4759 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4761 Do not avoid creating empty evaporating overlays (Bug#9642).
4762 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4763 That is, do not delete an evaporating overlay if it becomes
4764 empty after its bounds are adjusted to fit within its buffer.
4765 This fix caused other problems, and I'm reverting it until we get
4766 to the bottom of them.
4768 2012-04-27 Chong Yidong <cyd@gnu.org>
4770 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4772 2012-04-27 Eli Zaretskii <eliz@gnu.org>
4774 * xdisp.c (pos_visible_p): If the window start position is beyond
4775 ZV, start the display from buffer beginning. Prevents assertion
4776 violation in init_iterator when the minibuffer window is scrolled
4779 * window.c (window_scroll_pixel_based): Likewise.
4781 2012-04-27 Chong Yidong <cyd@gnu.org>
4783 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4785 2012-04-27 Glenn Morris <rgm@gnu.org>
4787 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4788 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4790 2012-04-27 Eli Zaretskii <eliz@gnu.org>
4792 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4793 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
4795 2012-04-26 Eli Zaretskii <eliz@gnu.org>
4797 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4798 display element, check also the underlying string or buffer
4799 character. (Bug#11341)
4801 * w32menu.c: Include w32heap.h.
4802 (add_menu_item): If the call to AppendMenuW (via
4803 unicode_append_menu) fails, disable Unicode menus only if we are
4804 running on Windows 9X/Me.
4806 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4808 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4809 (xgetint): Add missing shift for LSB tags.
4811 2012-04-24 Martin Rudalics <rudalics@gmx.at>
4813 * keyboard.c (read_char): Don't wipe echo area for select window
4814 events: These might get delayed via `mouse-autoselect-window'
4817 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
4819 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4820 manipulation of :loaded-from data.
4822 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
4824 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4825 now a cons (bug#11311).
4827 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4829 Do not create empty overlays with the evaporate property (Bug#9642).
4830 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4831 if it becomes empty after its bounds are adjusted to fit within
4832 its buffer. Without this fix, in a nonempty buffer (let ((o
4833 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4834 yields an empty overlay that has the evaporate property, which is
4835 not supposed to happen.
4837 Fix minor GTK3 problems found by static checking.
4838 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4839 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4840 (struct _EmacsFixedClass, emacs_fixed_get_type):
4841 Move decls here from emacsgtkfixed.h, since they needn't be public.
4842 (emacs_fixed_get_type): Now static.
4843 (emacs_fixed_class_init): Omit unused local.
4844 (emacs_fixed_child_type): Remove; unused.
4845 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4846 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4847 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4848 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4849 (EMACS_FIXED_GET_CLASS): Remove; unused.
4850 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4852 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4853 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4855 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4857 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
4858 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
4859 (__malloc_size_t, __malloc_ptrdiff_t):
4860 Remove. All uses removed, replaced by the definiens if needed,
4861 since we can assume C89 or better now.
4862 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4863 (protect_malloc_state, align, get_contiguous_space)
4864 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4865 (malloc_atfork_handler_child, malloc_enable_thread)
4866 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4867 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4868 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4869 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4870 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4871 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4872 Define using prototypes, not old style.
4873 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4874 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4875 (align): Don't assume that signed integer overflow wraps around.
4876 Omit unused local var.
4877 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4878 (_free_internal_nolock, memalign, mallochook, reallochook):
4879 Omit no-longer-needed casts.
4880 (valloc): Use getpagesize, not __getpagesize.
4881 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4882 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4884 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4886 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
4888 Move functions from C to Lisp. Make non-blocking method calls
4889 the default. Implement further D-Bus standard interfaces.
4891 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4892 (QCdbus_request_name_allow_replacement)
4893 (QCdbus_request_name_replace_existing)
4894 (QCdbus_request_name_do_not_queue)
4895 (QCdbus_request_name_reply_primary_owner)
4896 (QCdbus_request_name_reply_in_queue)
4897 (QCdbus_request_name_reply_exists)
4898 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4899 (QCdbus_registered_serial, QCdbus_registered_method)
4900 (QCdbus_registered_signal): New Lisp objects.
4901 (XD_DEBUG_MESSAGE): Use sizeof.
4902 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4903 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4904 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4905 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4906 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4907 (xd_signature, xd_append_arg): Allow float for integer types.
4908 (xd_get_connection_references): New function.
4909 (xd_get_connection_address): Rename from xd_initialize.
4910 Return cached address.
4911 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4912 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4914 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
4915 Return number of refcounts.
4916 (Fdbus_get_unique_name): Make stronger parameter check.
4917 (Fdbus_message_internal): New defun.
4918 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4919 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4920 (Fdbus_send_signal, Fdbus_register_service)
4921 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4922 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4923 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4924 (Vdbus_compiled_version, Vdbus_runtime_version)
4925 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4926 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4927 (Vdbus_message_type_signal): New defvars.
4928 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4931 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4933 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4934 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4935 Do not assume ptrdiff_t is the same width as 'int'.
4937 * alloc.c: Handle unusual debugging option combinations.
4938 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4939 since the two debugging options are incompatible.
4940 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4942 (mem_init, mem_insert, mem_insert_fixup):
4943 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4944 (NEED_MEM_INSERT): Remove; no longer needed.
4946 2012-04-22 Leo Liu <sdl.web@gmail.com>
4948 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4950 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4952 * sysdep.c [__FreeBSD__]: Minor cleanups.
4953 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4954 Use Emacs indenting style more consistently. Avoid some casts.
4955 Use 'double' consistently rather than mixing 'float' and 'double'.
4957 2012-04-21 Eduard Wiebe <usenet@pusto.de>
4959 * sysdep.c (list_system_processes, system_process_attributes):
4960 Add implementation for FreeBSD (Bug#5243).
4962 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4964 * lisp.mk (lisp): Update.
4966 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4968 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4969 It is never used otherwise.
4971 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4973 * print.c (print_preprocess): Only check print_depth if print-circle
4975 (print_object): Check for cycles even when print-circle is nil and
4976 print-gensym is t, but only check print_depth if print-circle is nil.
4978 2012-04-20 Chong Yidong <cyd@gnu.org>
4980 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4981 set the status to "failed" and ensure that sentinel is run.
4983 2012-04-20 Glenn Morris <rgm@gnu.org>
4985 * process.c (Fset_process_inherit_coding_system_flag)
4986 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4987 (Fmake_network_process, Fmake_serial_process): Doc fix.
4989 2012-04-20 Eli Zaretskii <eliz@gnu.org>
4991 * xdisp.c (string_buffer_position_lim): Limit starting position to
4993 (set_cursor_from_row): If called for a mode-line or header-line
4994 row, return zero immediately.
4995 (try_cursor_movement): If inside continuation line, don't back up
4996 farther than the first row after the header line, if any.
4997 Don't consider the header-line row as "partially visible", even if
4998 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
5000 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
5002 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
5005 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
5006 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
5008 configure: new option --enable-gcc-warnings (Bug#11207)
5009 * Makefile.in (C_WARNINGS_SWITCH): Remove.
5010 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
5011 (ALL_CFLAGS): Use new macros rather than old.
5012 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
5013 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
5014 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
5015 -Wunused-result, -Wunused-variable. This should go away once
5016 the Emacs and Gnulib regex code is merged.
5017 (xmalloc, xrealloc): Now static.
5019 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
5021 * dired.c (Fsystem_groups): Remove unused local.
5023 2012-04-17 Glenn Morris <rgm@gnu.org>
5025 * dired.c (Fsystem_users): Doc fix.
5027 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
5029 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
5030 (syms_of_dired): Add them.
5032 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
5034 Fix minor alloc.c problems found by static checking.
5035 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
5036 New extern decls, to avoid calling undeclared functions.
5037 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
5038 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
5039 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
5040 (NEED_MEM_INSERT): New macro.
5041 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
5042 Remove one incorrect comment and fix another.
5044 Fix minor ralloc.c problems found by static checking.
5045 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5046 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
5047 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
5048 (r_alloc_sbrk): Now static.
5050 Improve ralloc.c interface checking.
5051 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5052 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
5053 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
5054 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
5055 [REL_ALLOC]: ... to here, to check interface.
5056 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
5057 Remove decls. This fixes an "It stinks!".
5059 * alloc.c (which_symbols): Fix alignment issue / type clash.
5061 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
5063 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
5064 (struct Lisp_Misc_Any): Likewise.
5065 (struct Lisp_Free): Likewise.
5066 * alloc.c (union aligned_Lisp_Symbol): Define.
5067 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
5068 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
5069 (union aligned_Lisp_Misc): Define.
5070 (MARKER_BLOCK_SIZE, struct marker_block): Use union
5071 aligned_Lisp_Misc instead of union Lisp_Misc.
5072 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
5074 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
5076 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
5077 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
5078 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
5079 * s/netbsd.h, s/sol2-6.h:
5080 Remove definition of GC_MARK_STACK, since the default now works.
5081 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
5082 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
5083 no longer the default.
5084 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
5086 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
5088 * lread.c (lisp_file_lexically_bound_p):
5089 Fix hang at ";-*-\n" (bug#11238).
5091 2012-04-14 Eli Zaretskii <eliz@gnu.org>
5093 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
5094 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
5096 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
5098 * nsterm.m (constrainFrameRect): Always constrain when there is only
5099 one screen (Bug#10962).
5101 2012-04-13 Ken Brown <kbrown@cornell.edu>
5103 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
5105 2012-04-13 Reuben Thomas <rrt@sc3d.org>
5107 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
5109 2012-04-11 Daniel Colascione <dancol@dancol.org>
5111 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
5112 against is gone. It's better to use vfork now so that when Cygwin
5113 gains a new, working vfork, we use it automatically (bug#10398).
5115 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5117 * window.c (save_window_save): Obey window-point-insertion-type.
5119 2012-04-11 Glenn Morris <rgm@gnu.org>
5121 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
5123 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5125 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
5127 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
5129 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
5130 (force_quit_count): New var.
5131 (handle_interrupt): Use it.
5133 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
5135 * w32.c (w32_delayed_load): Record the full path of the library
5136 being loaded (bug#10424).
5138 2012-04-09 Glenn Morris <rgm@gnu.org>
5140 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
5141 not just in the obarray, before snarfing them. (Bug#11036)
5143 * Makefile.in ($(leimdir)/leim-list.el):
5144 Pass EMACS rather than BUILT_EMACS.
5146 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
5148 * process.c (make_process):
5149 * process.h: Add integer `gnutls_handshakes_tried' member to
5152 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
5153 Add convenience `GNUTLS_LOG2i' macro.
5155 * gnutls.c (gnutls_log_function2i): Convenience log function.
5156 (emacs_gnutls_read): Use new log functions,
5157 `gnutls_handshakes_tried' process member, and
5158 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
5159 attempts per process (connection).
5161 2012-04-09 Chong Yidong <cyd@gnu.org>
5163 * eval.c (Fuser_variable_p, user_variable_p_eh)
5164 (lisp_indirect_variable): Functions deleted.
5165 (Fdefvar): Caller changed.
5167 * callint.c (Finteractive, Fcall_interactively):
5168 * minibuf.c (Fread_variable): Callers changed.
5170 2012-04-09 Eli Zaretskii <eliz@gnu.org>
5172 * xdisp.c (set_cursor_from_row): If the display string appears in
5173 the buffer at position that is closer to point than the position
5174 after the display string, display the cursor on the first glyph of
5175 the display string. Fixes cursor display when a 'display' text
5176 property immediately follows invisible text. (Bug#11094)
5178 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5180 composite.c: use 'double' consistently
5181 * composite.c (get_composition_id): Use 'double' consistently
5182 instead of converting 'float' to 'double' and vice versa; this is
5183 easier to understand and avoids a GCC warning.
5185 2012-04-09 Glenn Morris <rgm@gnu.org>
5187 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5188 preparation for dumping it with emacs. (Bug#4789)
5189 (leimdir): New variable.
5190 ($(leimdir)/leim-list.el): New rule.
5191 (emacs$(EXEEXT)): Depend on leim-list.el.
5193 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5194 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5195 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5197 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5199 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5202 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
5204 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5205 Remove unused local variable.
5207 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5209 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5210 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5211 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5212 objects, as mark_maybe_pointer will catch them otherwise.
5213 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5214 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5216 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5218 Fix typo that broke non-Windows builds.
5219 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5221 2012-04-07 Eli Zaretskii <eliz@gnu.org>
5223 Support building on MS-Windows with libxml2.
5225 * makefile.w32-in (OBJ2): Add xml.$(O).
5226 (GLOBAL_SOURCES): Add xml.c.
5227 ($(BLD)/xml.$(O)): New dependency list.
5229 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5230 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5231 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5232 [!WINDOWSNT]: New macros.
5233 (init_libxml2_functions, libxml2_loaded_p): New functions.
5234 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5235 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5236 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5237 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5239 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5240 Call init_libxml2_functions before calling libxml2 functions.
5241 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5243 * emacs.c: Don't include libxml/parser.h.
5244 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5245 xmlCleanupParser directly.
5247 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5249 2012-04-07 Eli Zaretskii <eliz@gnu.org>
5251 * indent.c (Fvertical_motion): If there is a display string at
5252 point, use it.vpos to compute how many lines to backtrack after
5253 move_it_to point. (Bug#11133)
5255 2012-04-06 Eli Zaretskii <eliz@gnu.org>
5257 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5258 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5259 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5260 macros related to unification of CJK characters. For the details,
5261 see the discussion following the message here:
5262 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5264 2012-04-04 Chong Yidong <cyd@gnu.org>
5266 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5268 2012-04-01 Eli Zaretskii <eliz@gnu.org>
5270 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5271 instead of alloca. (Bug#11138)
5273 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5275 * w32menu.c (is_simple_dialog): Properly check lisp types.
5278 2012-03-31 Eli Zaretskii <eliz@gnu.org>
5280 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5281 position we get to after a call to move_it_to fails the
5282 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5283 only if we wind up in a string from display property. (Bug#11063)
5285 * window.c (Fdelete_other_windows_internal): Invalidate the row
5286 and column information about mouse highlight, so that redisplay
5287 restores it after reallocating the glyph matrices. (Bug#7464)
5289 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5290 string comes from a `display' text property, use the buffer
5291 position of that property as if we actually saw that position in
5293 (move_it_by_lines): Remove the assertion that
5294 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5295 violated when there's a before-string at the beginning of a line.
5298 2012-03-30 Eli Zaretskii <eliz@gnu.org>
5300 * xdisp.c (append_space_for_newline): If the default face was
5301 remapped, use the remapped face for the appended newline.
5302 (extend_face_to_end_of_line): Use the remapped default face for
5303 extending the face to the end of the line.
5304 (display_line): Call extend_face_to_end_of_line when the default
5305 face was remapped. (Bug#11068)
5307 2012-03-29 Eli Zaretskii <eliz@gnu.org>
5309 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5311 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5313 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5315 2012-03-27 Glenn Morris <rgm@gnu.org>
5317 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5320 2012-03-26 Kenichi Handa <handa@m17n.org>
5322 * dispextern.h (struct glyph): Fix previous change. Change the
5323 bit length of glyphless.ch to 25 (Bug#11082).
5325 2012-03-26 Chong Yidong <cyd@gnu.org>
5327 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5328 (command_loop_1): Use it; inhibit selection update for
5329 handle-select-window too (Bug#8996).
5331 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5333 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
5335 2012-03-25 Kenichi Handa <handa@m17n.org>
5337 * dispextern.h (struct glyph): Change the bit length of
5338 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5340 2012-03-24 Eli Zaretskii <eliz@gnu.org>
5342 * s/ms-w32.h (tzname): Include time.h before redirecting to
5343 _tzname. Fixes the MSVC build. (Bug#9960)
5345 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5347 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5350 * xterm.c (XTread_socket): Only modify handling_signal if
5351 !SYNC_INPUT. (Bug#11080)
5353 2012-03-23 Eli Zaretskii <eliz@gnu.org>
5355 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5356 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5357 when fetching a multibyte character consumes more bytes than
5358 CHAR_BYTES returns, due to unification of CJK characters in
5359 string_char. (Bug#11073)
5361 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5363 * process.c (wait_reading_process_output): Handle pty disconnect
5364 by refraining from sending oneself a SIGCHLD (bug#10933).
5366 2012-03-22 Chong Yidong <cyd@gnu.org>
5368 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5370 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
5371 Mark string as coming from a prefix property.
5372 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5373 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5375 2012-03-21 Chong Yidong <cyd@gnu.org>
5377 * xfaces.c (Vface_remapping_alist): Doc fix.
5379 2012-03-20 Eli Zaretskii <eliz@gnu.org>
5381 * w32proc.c (Fw32_set_console_codepage)
5382 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5385 2012-03-20 Chong Yidong <cyd@gnu.org>
5387 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5388 to reflect default non-nil value of redisplay-dont-pause.
5390 2012-03-19 Kenichi Handa <handa@m17n.org>
5392 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5393 it fit in a valid range (Bug#11003).
5395 2012-03-18 Eli Zaretskii <eliz@gnu.org>
5397 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5398 that is not from display property, accept the row as a "cursor
5399 row" if one of the string's character has a non-nil `cursor'
5400 property. Fixes cursor positioning when there are newlines in
5401 overlay strings, e.g. in icomplete.el. (Bug#11035)
5403 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5405 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5407 2012-03-12 Chong Yidong <cyd@gnu.org>
5409 * eval.c (inhibit_lisp_code): Rename from
5410 inhibit_window_configuration_change_hook; move from window.c.
5412 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5413 * window.c (run_window_configuration_change_hook)
5414 (syms_of_window): Callers changed.
5416 2012-03-11 Chong Yidong <cyd@gnu.org>
5418 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5420 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5422 2012-03-10 Chong Yidong <cyd@gnu.org>
5424 * frame.c (other_visible_frames): Don't assume the selected frame
5425 is visible (Bug#10955).
5427 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5429 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5431 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5433 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5434 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5437 2012-03-03 Glenn Morris <rgm@gnu.org>
5439 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
5441 2012-03-02 Eli Zaretskii <eliz@gnu.org>
5443 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5444 position past the first glyph_row that ends at ZV. (Bug#10902)
5445 (redisplay_window, next_element_from_string): Fix typos in
5447 (redisplay_window): Pass to move_it_vertically the margin in
5448 pixels, not in screen lines.
5450 2012-03-02 Glenn Morris <rgm@gnu.org>
5452 * buffer.c (buffer-list-update-hook): Doc fix.
5454 2012-02-29 Eli Zaretskii <eliz@gnu.org>
5456 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5457 push_it before setting up the iterator for the first overlay
5458 string, even if we have an empty string loaded.
5459 (next_overlay_string): If there's an empty string on the iterator
5460 stack, pop the stack. (Bug#10903)
5462 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5464 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5465 Suggested by Stefan Monnier in
5466 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5467 * alloc.c (widen_to_Lisp_Object): New static function.
5468 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5469 and widening them to Lisp_Objects. This would work even if
5470 USE_LSB_TAG is defined and wide integers are used, which might
5471 happen in a future version of Emacs.
5473 2012-02-25 Chong Yidong <cyd@gnu.org>
5475 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5478 * xselect.c (Fx_selection_exists_p): Doc fix.
5479 (x_clipboard_manager_save_all): Print an informative message
5480 before saving to clipboard manager.
5482 2012-02-24 Chong Yidong <cyd@gnu.org>
5484 * keyboard.c (process_special_events): Handle all X selection
5485 requests in kbd_buffer, not just the next one (Bug#8869).
5487 2012-02-23 Chong Yidong <cyd@gnu.org>
5489 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5490 call when setting menu-bar-lines and tool-bar-lines parameters.
5491 (unwind_create_frame_1): New helper function.
5493 * window.c (inhibit_window_configuration_change_hook): New var.
5494 (run_window_configuration_change_hook): Obey it.
5495 (syms_of_window): Initialize it.
5497 2012-02-22 Chong Yidong <cyd@gnu.org>
5499 * xterm.c (x_draw_image_relief): Add missing type check for
5500 Vtool_bar_button_margin (Bug#10743).
5502 2012-02-21 Chong Yidong <cyd@gnu.org>
5504 * fileio.c (Vfile_name_handler_alist): Doc fix.
5506 * buffer.c (Fget_file_buffer): Protect against invalid file
5507 handler return value.
5509 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5511 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5512 when computing $valmask.
5514 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5515 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5516 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5517 It's useless in that case, and it can cause problems on hosts
5518 that allocate halves of EMACS_INT values separately.
5519 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5520 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5521 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5522 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5523 it avoids undefined behavior on hosts where shifting right by more
5524 than the word width has undefined behavior.
5526 2012-02-19 Chong Yidong <cyd@gnu.org>
5528 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5529 (Funhandled_file_name_directory, Ffile_name_as_directory)
5530 (Fdirectory_file_name, Fexpand_file_name)
5531 (Fsubstitute_in_file_name): Protect against invalid file handler
5532 return values (Bug#10845).
5534 2012-02-18 Eli Zaretskii <eliz@gnu.org>
5536 * .gdbinit (pitx): Fix incorrect references to fields of the
5539 2012-02-17 Chong Yidong <cyd@gnu.org>
5541 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5543 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5545 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5546 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5548 2012-02-15 Chong Yidong <cyd@gnu.org>
5550 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5551 marked as special. Also, starting docstrings with * is obsolete.
5553 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5555 * gnutls.c (emacs_gnutls_write): Fix last change.
5557 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5559 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5562 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5564 * keymap.c (Fsingle_key_description): Handle char ranges.
5566 2012-02-12 Chong Yidong <cyd@gnu.org>
5568 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5569 as that creates a dangerous corner case.
5571 * window.c (Fdelete_window_internal): Invalidate the mouse
5572 highlight (Bug#9904).
5574 2012-02-12 Glenn Morris <rgm@gnu.org>
5576 * xselect.c (Fx_own_selection_internal)
5577 (Fx_get_selection_internal, Fx_disown_selection_internal)
5578 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5579 * nsselect.m (Fx_own_selection_internal)
5580 (Fx_disown_selection_internal, Fx_selection_exists_p)
5581 (Fx_selection_owner_p, Fx_get_selection_internal):
5582 Sync docs and argument specs with the xselect.c versions.
5584 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5586 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5588 2012-02-11 Eli Zaretskii <eliz@gnu.org>
5590 * w32select.c (Fx_selection_exists_p): Sync doc string and
5591 argument list with xselect.c. (Bug#10783)
5593 * w16select.c (Fx_selection_exists_p): Sync doc string and
5594 argument list with xselect.c. (Bug#10783)
5596 2012-02-10 Glenn Morris <rgm@gnu.org>
5598 * fns.c (Fsecure_hash): Doc fix.
5600 2012-02-09 Kenichi Handa <handa@m17n.org>
5602 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5604 2012-02-07 Chong Yidong <cyd@gnu.org>
5606 * buffer.c (Fbuffer_local_variables)
5607 (buffer_lisp_local_variables): Handle unbound vars correctly;
5608 don't let Qunbound leak into Lisp.
5610 2012-02-07 Glenn Morris <rgm@gnu.org>
5612 * image.c (Fimagemagick_types): Doc fix.
5614 * image.c (imagemagick-render-type): Change it from a lisp object
5615 to an integer. Move the doc here from the lisp manual.
5616 Treat all values not equal to 0 the same.
5618 2012-02-06 Chong Yidong <cyd@gnu.org>
5620 * doc.c (store_function_docstring): Avoid applying docstring of
5621 alias to base function (Bug#2603).
5623 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5625 * .gdbinit (pp1, pv1): Remove redundant defines.
5628 2012-02-04 Chong Yidong <cyd@gnu.org>
5630 * nsterm.m: Declare a global (Bug#10694).
5632 2012-02-04 Eli Zaretskii <eliz@gnu.org>
5634 * w32.c (get_emacs_configuration_options):
5635 Include --enable-checking, if specified, in the return value.
5637 2012-02-04 Martin Rudalics <rudalics@gmx.at>
5639 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5640 after rounding frame sizes. (Bug#9723)
5642 2012-02-04 Eli Zaretskii <eliz@gnu.org>
5644 * keyboard.c (adjust_point_for_property): Don't position point
5645 before BEGV. (Bug#10696)
5647 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5649 Handle overflow when computing char display width (Bug#9496).
5650 * character.c (char_width): Return EMACS_INT, not int.
5651 (char_width, c_string_width): Check for overflow when
5652 computing the width; this is possible now that individual
5653 characters can have unbounded width. Problem introduced
5654 by merge from Emacs 23 on 2012-01-19.
5656 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
5658 * dbusbind.c (Fdbus_register_method): Mention the return value
5659 :ignore in the docstring.
5661 2012-02-02 Glenn Morris <rgm@gnu.org>
5663 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5665 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5666 Unconditionally set to t. (Bug#10673)
5667 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5668 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5669 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5671 2012-02-02 Kenichi Handa <handa@m17n.org>
5673 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5674 0, do not call append_composite_glyph.
5676 2012-02-02 Kenichi Handa <handa@m17n.org>
5678 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5680 (x_produce_glyphs): If the component of a composition is a null
5681 string, set it->pixel_width to 1 to avoid zero-width glyph.
5683 2012-02-01 Eli Zaretskii <eliz@gnu.org>
5685 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5686 first 2 arguments are identical. This makes inserting large
5687 output from a subprocess an order of magnitude faster on
5688 MS-Windows, where all sbrk'ed memory is always contiguous.
5690 2012-01-31 Glenn Morris <rgm@gnu.org>
5692 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5693 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5694 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5696 2012-01-29 Glenn Morris <rgm@gnu.org>
5698 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5700 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5702 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5704 2012-01-28 Chong Yidong <cyd@gnu.org>
5706 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5708 2012-01-26 Chong Yidong <cyd@gnu.org>
5710 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5712 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5713 repeat counts (Bug#10507).
5715 2012-01-26 Glenn Morris <rgm@gnu.org>
5717 * lread.c (syms_of_lread): Doc fix.
5719 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5721 * coding.c (encode_designation_at_bol): Change return value to
5724 2012-01-25 Chong Yidong <cyd@gnu.org>
5726 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5728 2012-01-21 Chong Yidong <cyd@gnu.org>
5730 * floatfns.c (Fcopysign): Make the second argument non-optional,
5731 since nil is not allowed anyway.
5733 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5735 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5736 (send_process): Likewise.
5738 2012-01-19 Martin Rudalics <rudalics@gmx.at>
5740 * window.c (save_window_save, Fcurrent_window_configuration)
5741 (Vwindow_persistent_parameters): Do not use Qstate.
5742 Rewrite doc-strings.
5744 2012-01-19 Kenichi Handa <handa@m17n.org>
5746 * character.c (char_width): New function.
5747 (Fchar_width, c_string_width, lisp_string_width):
5748 Use char_width (Bug#9496).
5750 2012-01-16 Martin Rudalics <rudalics@gmx.at>
5752 * window.c (Vwindow_persistent_parameters): New variable.
5753 (Fset_window_configuration, save_window_save): Handle persistent
5756 2012-01-14 Eli Zaretskii <eliz@gnu.org>
5758 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5759 thrashing the stack of the thread. (Bug#9087)
5761 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5763 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5765 2012-01-11 Eli Zaretskii <eliz@gnu.org>
5767 * xdisp.c (rows_from_pos_range): Handle the case where the
5768 highlight ends on a newline. (Bug#10464)
5769 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5770 he end column for display of highlight that ends on a newline
5773 2012-01-11 Glenn Morris <rgm@gnu.org>
5775 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5776 from load-path also when installation-directory is nil. (Bug#10208)
5778 2012-01-10 Glenn Morris <rgm@gnu.org>
5780 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5782 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5783 Update template values to be closer to their typical values these days.
5785 2012-01-09 Eli Zaretskii <eliz@gnu.org>
5787 * xdisp.c (rows_from_pos_range): Accept additional argument
5788 DISP_STRING, and accept any glyph in a row whose object is that
5789 string as eligible for mouse highlight. Fixes mouse highlight of
5790 display strings from overlays. (Bug#10464)
5792 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
5794 emacs: fix an auto-save permissions race condition (Bug#10400)
5795 * fileio.c (auto_saving_dir_umask): New static var.
5796 (Fmake_directory_internal): Use it.
5797 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5798 creating the directory. The old code temporarily assigns
5799 too-generous permissions to the directory.
5800 (do_auto_save_eh): Clear it.
5801 (Fdo_auto_save): Catch all errors, not just file errors, so
5802 that the var is always cleared.
5804 2012-01-07 Eli Zaretskii <eliz@gnu.org>
5806 * search.c (scan_buffer): Pass character positions to
5807 know_region_cache, not byte positions. (Bug#6540)
5809 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
5811 * w32.c (sys_rename): Report EXDEV when rename of a directory
5812 fails because the target is on another logical disk. (Bug#10284)
5814 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5816 * xterm.c (x_embed_request_focus): New function.
5818 * xterm.h: Add prototype.
5820 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5822 2012-01-05 Glenn Morris <rgm@gnu.org>
5824 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5826 2012-01-01 Eli Zaretskii <eliz@gnu.org>
5828 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5829 Load gnutls_transport_set_lowat only if GnuTLS version is below
5831 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5832 GnuTLS versions below 2.11.1.
5834 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5836 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5837 to the doc string advising against its use for altering the way
5838 windows are scrolled.
5840 2011-12-28 Kenichi Handa <handa@m17n.org>
5842 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5843 coding-system ASCII compatible only when it does not produce BOM
5844 on encoding (Bug#10383).
5846 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5848 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5850 (create_and_show_popup_menu): Always use menu_position_func for
5853 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5855 * callint.c (Fcall_interactively): Don't truncate prompt string.
5857 2011-12-23 Eli Zaretskii <eliz@gnu.org>
5859 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5860 property that ends at ZV, so that the bidi iteration could be
5861 resumed from there (after widening). (Bug#10360)
5863 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5865 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5867 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5869 * nsterm.m (x_free_frame_resources):
5870 Release f->output_data.ns->miniimage.
5871 (ns_index_color): Fix indentation. Do not retain
5872 color_table->colors[i].
5874 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5877 * nsfns.m (x_set_background_color): Assign return value from
5878 ns_index_color to face-background instead of NSColor*.
5879 (ns_implicitly_set_icon_type): Fix indentation.
5880 Change assignment in for loop to comparison.
5882 * emacs.c (ns_pool): New variable.
5883 (main): Assign ns_pool.
5884 (Fkill_emacs): Call ns_release_autorelease_pool.
5886 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5887 autorelease fdesc, release fdAttrs and tdict.
5888 (ns_get_covering_families): Release charset.
5889 (ns_findfonts): Release NSFontDescriptor created with new.
5890 (ns_uni_to_glyphs): Fix indentation.
5891 (setString): Release attrStr before assigning new value.
5893 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5895 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5897 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5898 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5900 2011-12-18 David Reitter <reitter@cmu.edu>
5902 * nsterm.m (ns_term_init): Subscribe for notifications
5903 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5904 to method trackingNotification in EmacsMenu.
5906 * nsmenu.m (trackingMenu): New variable.
5907 (trackingNotification): New method (from Aquamacs).
5908 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
5909 from Aquamacs (Bug#7030).
5911 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5913 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5914 (symbol_to_nsstring): Fix indentation.
5915 (ns_symbol_to_pb): New function.
5916 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5917 (Fns_rotate_cut_buffers_internal): Remove.
5918 (Fns_store_selection_internal): Rename from
5919 Fns_store_cut_buffer_internal.
5920 (ns_get_foreign_selection, Fx_own_selection_internal)
5921 (Fx_disown_selection_internal, Fx_selection_exists_p)
5922 (Fns_get_selection_internal, Fns_store_selection_internal):
5923 Use ns_symbol_to_pb and check if return value is nil.
5924 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5925 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
5926 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5927 renamed to Sns_store_selection_internal.
5928 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5929 and remove this function.
5930 (ns_handle_selection_clear): Remove, never used.
5931 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5934 2011-12-17 Ken Brown <kbrown@cornell.edu>
5936 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5937 GID is unknown (Bug#10257).
5939 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5941 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5942 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5943 which caused a build failure on GNU/Linux IA-64. This problem was
5944 introduced by my 2011-10-07 patch.
5946 2011-12-15 Juri Linkov <juri@jurta.org>
5948 * image.c (imagemagick_error): New function. (Bug#10112)
5949 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5950 Use `imagemagick_error' where ImageMagick functions return
5952 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5955 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5957 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5958 fill background (Bug#8992).
5960 2011-12-13 Martin Rudalics <rudalics@gmx.at>
5962 * window.c (Vwindow_combination_resize)
5963 (Vwindow_combination_limit): Use t instead of non-nil in
5965 (Vrecenter_redisplay): Add first sentence of doc-string on
5967 (Frecenter): Fix doc-string typo.
5969 2011-12-11 Kenichi Handa <handa@m17n.org>
5971 * coding.c (Funencodable_char_position): Pay attention to the
5972 buffer text relocation (Bug#9389).
5974 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5976 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5977 gtk_init (Bug#10100).
5979 2011-12-10 Eli Zaretskii <eliz@gnu.org>
5981 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5982 IT->string is nil. (Bug#10263)
5984 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5986 * nsterm.h (x_free_frame_resources): Declare.
5988 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5989 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5991 * nsterm.h (ns_get_defaults_value): Declare.
5993 * nsterm.m (ns_default): Call ns_get_defaults_value.
5995 2011-12-09 Eli Zaretskii <eliz@gnu.org>
5997 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
6000 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6002 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
6003 that where the value of an _OBJC_* symbol points to is in the .bss
6004 section (Bug#10240).
6006 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6008 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
6009 after the loop to call ccl_driver at least once (Bug#8619).
6011 2011-12-08 Kenichi Handa <handa@m17n.org>
6013 * ftfont.c (get_adstyle_property): Fix previous change
6016 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
6018 * w32.c (init_environment): If no_site_lisp, remove site-lisp
6019 dirs from the default value of EMACSLOADPATH (bug#10208).
6021 2011-12-07 Glenn Morris <rgm@gnu.org>
6023 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
6024 installation and source directories as well. (Bug#10208)
6026 2011-12-06 Chong Yidong <cyd@gnu.org>
6028 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
6030 2011-12-06 Glenn Morris <rgm@gnu.org>
6032 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
6033 as an error, not just -1. (Bug#10217)
6035 2011-12-05 Chong Yidong <cyd@gnu.org>
6037 * keyboard.c (process_special_events): New function.
6038 (swallow_events, Finput_pending_p): Use it (Bug#10195).
6040 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
6042 * coding.c (encode_designation_at_bol): Don't use uninitialized
6043 local variable (Bug#9318).
6045 2011-12-05 Kenichi Handa <handa@m17n.org>
6047 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
6048 return Qnil (Bug#8046, Bug#10193).
6050 2011-12-05 Kenichi Handa <handa@m17n.org>
6052 * coding.c (encode_designation_at_bol): New args charbuf_end and
6053 dst. Return the number of produced bytes. Callers changed.
6054 (coding_set_source): Return how many bytes coding->source was
6056 (coding_set_destination): Return how many bytes
6057 coding->destination was relocated.
6058 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
6059 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
6061 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6063 * coding.c (CODING_CHAR_CHARSET_P): New macro.
6064 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
6067 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
6069 The following changes are to fix Bug#9318.
6071 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
6072 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
6073 (encode_coding_iso_2022, encode_coding_sjis)
6074 (encode_coding_big5, encode_coding_charset): Use the above macros.
6076 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
6078 * lisp.h (process_quit_flag): Fix external declaration.
6080 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
6082 Don't macro-inline non-performance-critical code.
6083 * eval.c (process_quit_flag): New function.
6084 * lisp.h (QUIT): Use it.
6086 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
6088 * nsfns.m (get_geometry_from_preferences): New function.
6089 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
6091 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
6093 * emacs.c (Qkill_emacs): Define.
6094 (syms_of_emacs): Initialize it.
6095 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
6096 Qquit_flag to `kill-emacs' instead.
6097 (quit_throw_to_read_char): Add parameter `from_signal'.
6098 All callers changed. Call Fkill_emacs if requested and safe.
6099 * lisp.h (QUIT): Call Fkill_emacs if requested.
6101 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
6103 * widget.c (update_wm_hints): Return if wmshell is null.
6104 (widget_update_wm_size_hints): New function.
6106 * widget.h (widget_update_wm_size_hints): Declare.
6108 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
6109 widget_update_wm_size_hints (Bug#10104).
6111 2011-12-03 Eli Zaretskii <eliz@gnu.org>
6113 * xdisp.c (handle_invisible_prop): If the invisible text ends just
6114 before a newline, prepare the bidi iterator for consuming the
6115 newline, and keep the current paragraph direction. (Bug#10183)
6116 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
6118 2011-12-02 Juri Linkov <juri@jurta.org>
6120 * search.c (Fword_search_regexp): New Lisp function created from
6121 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
6122 (Fword_search_backward, Fword_search_forward)
6123 (Fword_search_backward_lax, Fword_search_forward_lax):
6124 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
6125 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
6127 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
6129 * fileio.c (Finsert_file_contents): Move after-change-function call
6130 to before the "handled:" label, since all "goto handled" appear in
6131 cases where the *-change-functions have already been properly called
6134 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
6136 * keyboard.c (interrupt_signal): Don't call kill-emacs when
6137 waiting for input. (Bug#10169)
6139 2011-11-30 Eli Zaretskii <eliz@gnu.org>
6141 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
6142 verifies glyph row's hash code--we have just reallocated the
6143 glyphs, so their contents can be complete garbage. (Bug#10164)
6145 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
6147 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
6149 2011-11-30 Eli Zaretskii <eliz@gnu.org>
6151 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
6152 attributes are tested _before_ calling verify_row_hash, to protect
6153 against GCC re-ordering of the tests. (Bug#10164)
6155 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
6157 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
6159 * xterm.c (handle_one_xevent): Only set async_visible and friends
6160 if net_wm_state_hidden_seen is non-zero (Bug#10002)
6161 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
6162 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
6164 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
6166 Remove GCPRO-related macros that exist only to avoid shadowing locals.
6167 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
6168 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
6169 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6170 All uses changed to use GCPRO1 etc.
6171 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
6172 Revert to old implementation (i.e., before 2011-03-11).
6174 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6176 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6177 of scroll runs so as to avoid assigning disabled bogus rows and
6178 unnecessary graphics copy operations.
6180 2011-11-27 Eli Zaretskii <eliz@gnu.org>
6182 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6183 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6184 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6185 (malloc, free, realloc, calloc): Redirect to e_* only when
6188 * lisp.h (GCTYPEBITS): Move before first use.
6189 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6190 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6191 this macro definition.
6193 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6196 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6198 * gtkutil.c (xg_create_frame_widgets):
6199 Call gtk_window_set_has_resize_grip (FALSE) if that function is
6200 present with Gtk+ 2.0.
6202 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6204 * fileio.c (Finsert_file_contents): Undo previous change; see
6205 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6207 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6209 Rename locals to avoid shadowing.
6210 * fileio.c (Finsert_file_contents):
6211 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6212 * process.c (wait_reading_process_output):
6213 Rename inner 'proc' to 'p' to avoid shadowing.
6214 Indent for consistency with usual Emacs style.
6216 2011-11-25 Eli Zaretskii <eliz@gnu.org>
6218 * xdisp.c (redisplay_window): If cursor row is not fully visible
6219 after recentering, and scroll-conservatively is set to a large
6220 number, scroll window by a few more lines to make the cursor fully
6221 visible and out of scroll-margin. (Bug#10105)
6222 (start_display): Don't move to the next line if the display should
6223 start at a newline that is part of a display vector or an overlay
6226 2011-11-24 Juri Linkov <juri@jurta.org>
6228 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6229 after the `MagickPingImage' call. (Bug#10112)
6231 2011-11-23 Chong Yidong <cyd@gnu.org>
6233 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6235 2011-11-23 Martin Rudalics <rudalics@gmx.at>
6237 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6238 making another buffer current. (Bug#10114)
6240 2011-11-23 Glenn Morris <rgm@gnu.org>
6242 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6244 2011-11-23 Chong Yidong <cyd@gnu.org>
6246 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6247 using it (Bug#5984).
6249 2011-11-22 Eli Zaretskii <eliz@gnu.org>
6251 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6252 and header-lines, as they don't have one computed for them.
6255 * .gdbinit (prow): Make displayed values more self-explaining.
6256 Add row's hash code.
6258 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6260 * process.c (wait_reading_process_output): Fix asynchrounous
6261 GnuTLS socket handling on some versions of the GnuTLS library.
6262 (wait_reading_process_output): Add comment and URL.
6264 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6266 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6268 2011-11-21 Chong Yidong <cyd@gnu.org>
6270 * window.c (Fnext_window, Fprevious_window): Doc fix.
6272 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6274 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6276 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
6278 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6280 2011-11-20 Martin Rudalics <rudalics@gmx.at>
6282 * window.c (Fset_window_combination_limit): Rename argument
6284 (Vwindow_combination_limit): Remove "status" from doc-string.
6286 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6288 * m/ibms390.h: Remove.
6289 * m/ibms390x.h: Don't include "ibms390.h".
6291 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6293 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6294 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6296 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
6298 * casetab.c (Fset_case_table):
6299 * charset.c (Fcharset_after): Fix typos.
6301 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6303 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6304 Otherwise, valgrind does not work on some platforms.
6305 Problem reported by Andreas Schwab in
6306 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6307 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6308 is set, removing the need for VIRT_ADDRESS_VARIES.
6309 (PURE_P): Use a more-efficient implementation that needs just one
6310 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6311 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6312 to 4 (xorl, subq, cmpq, setbe).
6313 * alloc.c (pure): Always extern now, since that's the
6314 VIRT_ADDR_VARIES behavior.
6315 (PURE_POINTER_P): Use a single comparison, not two, for
6316 consistency with the new puresize.h.
6317 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6318 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6319 Remove VIRT_ADDR_VARIES no longer needed.
6321 2011-11-19 Eli Zaretskii <eliz@gnu.org>
6323 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6324 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6325 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6326 behave as if the cursor position were at the window margin.
6328 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6329 and the cursor position is out of bounds, behave as if the cursor
6330 position were at the window margin. (Bug#10075)
6332 2011-11-18 Chong Yidong <cyd@gnu.org>
6334 * window.c (Fwindow_combination_limit): Make first argument
6335 non-optional, since it is meaningless for live windows like the
6338 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6340 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6342 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6344 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6345 (graft_intervals_into_buffer): Simplify.
6347 2011-11-18 Eli Zaretskii <eliz@gnu.org>
6349 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6350 hash values of the two rows.
6351 (copy_row_except_pointers): Preserve the used[] arrays and the
6352 hash values of the two rows. (Bug#10035)
6353 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
6355 * xdisp.c (row_hash): New function, body extracted from
6356 compute_line_metrics.
6357 (compute_line_metrics): Call row_hash, instead of computing the
6360 * dispnew.c (verify_row_hash): Call row_hash for computing the
6361 hash code of a row, instead of duplicating code from xdisp.c.
6363 * dispextern.h (row_hash): Add prototype.
6365 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6367 * frame.c (delete_frame): Don't delete the terminal when the last
6368 X frame is closed if emacs is built with GTK toolkit.
6370 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
6372 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6374 2011-11-17 Martin Rudalics <rudalics@gmx.at>
6376 * window.c (Vwindow_splits): Rename to
6377 Vwindow_combination_resize. Suggested by Juri Linkov.
6378 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6381 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
6383 * nsfns.m (Fns_font_name):
6384 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
6386 2011-11-16 Martin Rudalics <rudalics@gmx.at>
6388 * window.h (window): Rename slot "nest" to "combination_limit".
6389 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6390 (Fset_window_nest): Rename to Fset_window_combination_limit.
6391 (Vwindow_nest): Rename to Vwindow_combination_limit.
6392 (recombine_windows, make_parent_window, make_window)
6393 (Fsplit_window_internal, saved_window)
6394 (Fset_window_configuration, save_window_save): Rename all
6395 occurrences of window_nest to window_combination_limit.
6397 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
6399 * image.c (imagemagick_load_image): Fix typo.
6401 2011-11-14 Eli Zaretskii <eliz@gnu.org>
6403 * xdisp.c (display_line): Move the call to
6404 highlight_trailing_whitespace before the call to
6405 compute_line_metrics, since the latter needs to see the final
6406 faces of all the glyphs to compute ROW's hash value.
6407 Fixes assertion violations in row_equal_p. (Bug#10035)
6409 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
6411 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6412 just return (bug#10044).
6414 2011-11-12 Eli Zaretskii <eliz@gnu.org>
6416 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6417 with user-defined heap size. Bump the default size of the temacs
6418 heap to 27MB, to avoid memory warning when running temacs.
6419 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6421 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6422 current_matrix and desired_matrix. (Bug#9990)
6423 (verify_row_hash) [XASSERTS]: New function.
6424 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6425 that the hash value of glyph rows is correct.
6427 2011-11-12 Martin Rudalics <rudalics@gmx.at>
6429 * window.h (window): Remove splits slot.
6430 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6431 (Fdelete_other_windows_internal, make_parent_window)
6432 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6433 (Fset_window_configuration, save_window_save): Don't deal with
6434 split status of windows.
6435 (saved_window): Remove splits slot.
6436 (Vwindow_splits): Rewrite doc-string.
6438 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6440 * xfns.c (unwind_create_frame):
6441 * nsfns.m (unwind_create_frame):
6442 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6443 Vframe_list (Bug#9999).
6445 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6447 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
6449 2011-11-11 Kenichi Handa <handa@m17n.org>
6451 * callproc.c (Fcall_process): Set the member dst_multibyte of
6454 2011-11-11 Johan Bockgård <bojohan@gnu.org>
6456 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6457 avoid a crash (bug#9496).
6459 2011-11-09 Chong Yidong <cyd@gnu.org>
6461 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6462 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6464 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6466 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6468 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6470 Avoid some portability problems by eschewing 'extern inline' functions.
6471 The trivial performance wins aren't worth the portability hassles; see
6472 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6474 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6475 (window_box_width, window_box_left, window_box_left_offset)
6476 (window_box_right, window_box_right_offset): Undo previous change,
6477 by removing the "extern"s.
6478 * intervals.c (adjust_intervals_for_insertion)
6479 (adjust_intervals_for_deletion): Undo previous change,
6480 making these static again.
6481 (offset_intervals, temp_set_point_both, temp_set_point)
6482 (copy_intervals_to_string): No longer inline.
6483 * xdisp.c (window_text_bottom_y, window_box_width)
6484 (window_box_height, window_box_left_offset)
6485 (window_box_right_offset, window_box_left, window_box_right)
6486 (window_box): No longer inline.
6488 2011-11-08 Chong Yidong <cyd@gnu.org>
6490 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6491 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6492 Signal an error if not a live window.
6493 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6494 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6496 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
6498 * lisp.h (syms_of_abbrev): Remove declaration.
6499 Reported by CHENG Gao <chenggao@royau.me>.
6501 2011-11-07 Eli Zaretskii <eliz@gnu.org>
6503 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6504 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6505 of temacs in GUI mode.
6507 2011-11-07 Martin Rudalics <rudalics@gmx.at>
6509 * window.h: Declare delete_all_child_windows instead of
6510 delete_all_subwindows.
6511 * window.c (Fwindow_nest, Fset_window_nest)
6512 (Fset_window_new_total, Fset_window_new_normal)
6513 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6514 (delete_all_subwindows): Rename to delete_all_child_windows.
6515 (Fdelete_other_windows_internal, Fset_window_configuration):
6516 Call delete_all_child_windows instead of delete_all_subwindows.
6517 * frame.c (delete_frame): Call delete_all_child_windows instead
6518 of delete_all_subwindows.
6520 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6522 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6523 This is also needed for porting to any host where GC_MARK_STACK is
6524 not GC_MAKE_GCPROS_NOOPS.
6525 (which_symbols): Use it.
6527 2011-11-07 Kenichi Handa <handa@m17n.org>
6529 * coding.c (coding_set_destination): Check coding->src_pos only
6530 when coding->src_object is a buffer (bug#9910).
6532 * process.c (send_process): Set the member src_multibyte of coding
6533 to 0 (bug#9911) when sending a unibyte text.
6535 * callproc.c (Fcall_process): Set the member src_multibyte of
6536 process_coding to 0 (bug#9912).
6538 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6540 * xmenu.c (cleanup_widget_value_tree): New function.
6541 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6542 calling free_menubar_widget_value_tree directly (Bug#9830).
6544 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6546 Fix some portability problems with 'inline'.
6547 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6548 (window_box_width, window_box_left, window_box_left_offset)
6549 (window_box_right, window_box_right_offset): Declare extern.
6550 Otherwise, these inline functions do not conform to C99 and
6551 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6552 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6553 * intervals.c (adjust_intervals_for_insertion)
6554 (adjust_intervals_for_deletion): Now extern, because otherwise the
6555 extern inline functions 'offset_intervals' couldn't refer to it.
6556 (static_offset_intervals): Remove.
6557 (offset_intervals): Rewrite using the old contents of
6558 static_offset_intervals. The old version didn't conform to C99
6559 because an extern inline function contained a reference to an
6560 identifier with static linkage.
6562 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6564 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6567 2011-11-06 Eli Zaretskii <eliz@gnu.org>
6569 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6570 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6571 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6572 return Qleft_to_right.
6574 2011-11-06 Chong Yidong <cyd@gnu.org>
6576 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6577 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6578 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6579 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6580 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6581 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6582 (Fwindow_vscroll): Doc fix.
6583 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6584 argument, since it makes no sense to pass a live window and for
6585 consistency with window-child.
6587 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6589 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6592 2011-11-05 Jason Rumney <jasonr@gnu.org>
6594 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6595 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6597 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6598 bitwise arithmetic preventing use of unicode-sip and non-truetype
6601 2011-11-05 Eli Zaretskii <eliz@gnu.org>
6603 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6606 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6607 initialization code to keep similarity to xfns.c after changes
6610 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6612 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6613 (unwind_create_frame): New function (Bug#9943).
6614 (Fx_create_frame): Restructure code to be more similar to the one in
6615 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6616 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6617 Move terminal->reference_count++ just before making the frame official
6620 * nsterm.m (x_free_frame_resources): New function.
6621 (x_destroy_window): Move code to x_free_frame_resources.
6623 * xfns.c (unwind_create_frame): Fix comment.
6624 (Fx_create_frame, x_create_tip_frame):
6625 Move terminal->reference_count++ just before making the frame
6626 official. Move initialization of image_cache_refcount and
6627 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6629 2011-11-05 Eli Zaretskii <eliz@gnu.org>
6631 Support MSVC build with newer versions of Visual Studio.
6632 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6633 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6636 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6637 which are not supported by MSVC.
6638 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6639 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6641 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6643 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6645 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6647 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
6649 Support MSVC build with newer versions of Visual Studio.
6650 * w32.c: Don't include w32api.h for MSVC.
6651 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6653 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6654 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6655 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6656 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6658 (alloca) [_MSC_VER]: Define to _alloca.
6660 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6662 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6664 2011-11-04 Eli Zaretskii <eliz@gnu.org>
6666 * xdisp.c (note_mouse_highlight): If either of
6667 previous/next-single-property-change returns nil, treat that as
6668 the beginning or the end of the buffer. (Bug#9955)
6670 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6672 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
6673 label is not null (Bug#9951).
6674 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6677 2011-11-04 Eli Zaretskii <eliz@gnu.org>
6679 * window.c (Fwindow_body_size): Mention in the doc string that the
6680 return value is in frame's canonical units. (Bug#9949)
6682 2011-11-03 Eli Zaretskii <eliz@gnu.org>
6684 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6686 * w32fns.c (unwind_create_frame): If needed, free the glyph
6687 matrices of the partially constructed frame. (Bug#9943)
6688 * xfns.c (unwind_create_frame): Likewise.
6690 2011-11-01 Eli Zaretskii <eliz@gnu.org>
6692 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6693 Don't stop backward scan on the continuation glyph, even though
6694 its CHARPOS is positive.
6695 (mouse_face_from_buffer_pos, note_mouse_highlight):
6696 Rename cover_string to disp_string.
6698 2011-11-01 Martin Rudalics <rudalics@gmx.at>
6700 * window.c (temp_output_buffer_show): Don't use
6701 Vtemp_buffer_show_specifiers.
6702 (Vtemp_buffer_show_specifiers): Remove unused variable.
6704 2011-10-30 Eli Zaretskii <eliz@gnu.org>
6706 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6707 past the beginning of the current glyph matrix.
6709 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6711 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6712 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6713 HAVE_GTK3 (Bug#9869).
6715 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6716 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6718 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6720 * xterm.c: Declare x_handle_net_wm_state to return int.
6721 (handle_one_xevent): Check if we are iconified but don't have
6722 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6723 (get_current_wm_state): Return non-zero if not hidden,
6724 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6725 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6726 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6727 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6729 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6731 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6732 so that this new function doesn't get optimized away by a
6733 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6735 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6737 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6739 2011-10-29 Eli Zaretskii <eliz@gnu.org>
6741 Fix the `xbytecode' command.
6742 * .gdbinit (xprintbytestr): New command.
6743 (xwhichsymbols): Rename from `which'; all callers changed.
6744 (xbytecode): Print the byte-code string as well.
6746 2011-10-29 Kim Storm <storm@cua.dk>
6748 * alloc.c (which_symbols): New function.
6750 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6752 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6755 2011-10-29 Glenn Morris <rgm@gnu.org>
6757 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6758 Not clear what it was for, and it causes various bugs. (Bug#9839)
6760 2011-10-28 Eli Zaretskii <eliz@gnu.org>
6762 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6763 possible random value that matches one of those tested as
6764 condition to clear the mouse face.
6766 2011-10-28 Chong Yidong <cyd@gnu.org>
6768 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6770 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6772 * window.c (make_window): Initialize phys_cursor_on_p.
6774 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6776 * lisp.h (struct Lisp_Symbol): Update comments.
6778 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
6780 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6782 2011-10-28 Eli Zaretskii <eliz@gnu.org>
6784 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6785 <oslsachem@gmail.com> for helping to debug this.
6787 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6788 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6789 (g_b_init_get_glyph_outline_w): New static variables.
6790 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6791 (GetGlyphOutlineW_Proc): New typedefs.
6792 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
6793 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6795 (w32font_open_internal, compute_metrics):
6796 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
6797 instead of calling the "wide" APIs directly.
6799 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6801 * w32.h (syms_of_w32font): Add prototype.
6803 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
6805 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6806 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6807 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6808 (Fmove_to_window_line): Doc fix.
6810 2011-10-27 Chong Yidong <cyd@gnu.org>
6812 * process.c (make_process): Set gnutls_state to NULL.
6814 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6815 non-NULL, regardless of GNUTLS_INITSTAGE.
6816 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6817 an error. Set process slots as soon as we allocate them.
6819 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6821 2011-10-27 Chong Yidong <cyd@gnu.org>
6823 * gnutls.c (emacs_gnutls_deinit): New function.
6824 Deallocate credentials structures as well as calling gnutls_deinit.
6825 (Fgnutls_deinit, Fgnutls_boot): Use it.
6827 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6828 (deactivate_process): Call emacs_gnutls_deinit.
6830 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
6832 * image.c (x_create_x_image_and_pixmap):
6833 * w32.c (sys_rename, w32_delayed_load):
6834 * w32font.c (fill_in_logfont):
6835 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6837 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
6839 * w32fns.c (w32_default_color_map): New function,
6840 extracted from Fw32_default_color_map.
6841 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
6843 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6845 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6847 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6849 * keyboard.c (test_undefined): New function (bug#9751).
6850 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6852 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6854 * sysdep.c (init_sys_modes): Fix the check for the controlling
6855 terminal (Bug#6649).
6857 2011-10-20 Eli Zaretskii <eliz@gnu.org>
6859 * dispextern.h (struct bidi_it): New member next_en_type.
6861 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6862 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6863 current character, check also for next_en_type being WEAK_EN.
6864 (bidi_resolve_weak): Don't enter the expensive loop if the current
6865 position is before next_en_pos. Record the bidi type of the first
6866 non-ET, non-BN character we find, in addition to its position.
6867 (bidi_level_of_next_char): Invalidate next_en_type when
6868 next_en_pos is over-stepped.
6870 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6872 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6873 * editfns.c: Rewrite current-time-zone so that it invokes
6874 the equivalent of (format-time-string "%Z") to get the time zone name.
6875 This fixes a bug when the time zone name contains characters that
6876 need converting from the system time locale to Emacs internal format.
6877 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6878 that patch fixed format-time-string to do the conversion, but
6879 I forgot to fix current-time-zone.
6880 (format_time_string): New function, containing most of
6881 what Fformat_time_string used to contain.
6882 (Fformat_time_string): Rewrite in terms of format_time_string.
6883 This doesn't change this function's behavior.
6884 (current-time-zone): Rewrite to use format_time_string.
6885 This fixes the bug reported by Michael Schierl in
6886 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6887 Jason Rumney's 2007-06-07 change worked around this bug, but
6889 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6891 2011-10-19 Eli Zaretskii <eliz@gnu.org>
6893 * xdisp.c (start_display): If the character at POS is displayed
6894 via a display vector, reset IT->current.dpvec_index to zero.
6895 (try_window_reusing_current_matrix): If a line ends in a display
6896 vector or the next line starts in a display vector, continue
6897 redrawing the window even though the character position of
6898 start_row was reached.
6901 2011-10-18 Chong Yidong <cyd@gnu.org>
6903 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6904 with nobreak-char-display too.
6906 2011-10-18 Eli Zaretskii <eliz@gnu.org>
6908 Fix part 3 of bug#9771.
6909 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6910 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6911 non-neutral characters if the current character is a paragraph
6912 separator (a.k.a. Newline). This avoids running the same
6913 expensive loop twice, once when we consume the preceding newline
6914 and the other time when the line actually needs to be displayed.
6915 Avoid the loop when we see neutrals on the base embedding level
6916 following a character whose directionality is the same as the
6917 paragraph's. This avoids running the expensive loop when a line
6918 ends in a long sequence of neutrals, like control characters.
6919 Add assertion against STRONG_AL type. Slightly rearrange code
6920 that determines the type of a neutral given the first non-neutral
6922 (bidi_level_of_next_char): Set next_en_pos to zero when
6923 invalidating its info.
6925 2011-10-17 Eli Zaretskii <eliz@gnu.org>
6927 * xdisp.c (push_display_prop): Determine whether to record string
6928 or buffer position by IT->string, not by IT->method. Allow
6929 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
6930 (move_it_vertically_backward): Don't look for character position
6931 immediately after the newline when in a continuation line.
6934 2011-10-15 Martin Rudalics <rudalics@gmx.at>
6936 * window.c (coordinates_in_window): Rewrite and delabelize
6937 vertical border check. (Bug#5357) (Bug#9618)
6939 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6941 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6942 errors in XSetWindowBorder (bug#9310).
6944 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6946 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6947 avoid crash when xmalloc overrun checking is enabled.
6949 2011-10-13 Eli Zaretskii <eliz@gnu.org>
6951 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6952 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6953 cursor motion with <left> and <right> arrow keys.
6955 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6956 some callers set that themselves.
6958 2011-10-12 Eli Zaretskii <eliz@gnu.org>
6960 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6961 display string and the previous row comes from the same string and
6962 is empty. (Bug#9739) (Bug#9738)
6964 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6966 * doc.c (get_doc_string): Encode file name (bug#9735).
6968 2011-10-12 Eli Zaretskii <eliz@gnu.org>
6970 * bidi.c (bidi_level_of_next_char):
6971 * xdisp.c (get_visually_first_element): Remove old incorrect
6972 comments regarding the Unicode Line Separator character.
6974 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6976 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6978 * alloc.c (Fgc_status): Do not access beyond zombies array
6979 boundary if nzombies > MAX_ZOMBIES.
6980 * alloc.c (dump_zombies): Add missing format specifier.
6982 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6984 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6985 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6987 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6988 Some packages use them to denote characters with modifiers.
6990 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6992 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6993 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6994 matching a pp-number. Rename parameter var to var1.
6996 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6998 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
7000 2011-10-08 Glenn Morris <rgm@gnu.org>
7002 * callint.c (Fcall_interactively): Give a more explicit error for the
7003 'c' case with a non-character input. (Bug#8479)
7005 2011-10-08 Eli Zaretskii <eliz@gnu.org>
7007 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
7009 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
7010 lines that are hscrolled on the left.
7012 * dispnew.c (buffer_posn_from_coords): Account for a possible
7013 presence of header-line. (Bug#4426)
7015 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
7017 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
7018 Don't advertise functionality which we discourage or doesn't work.
7020 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
7022 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
7023 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
7024 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
7025 this makes Emacs dump core during garbage collection on rare
7026 occasions. sizeof is obviously inferior to offsetof here, so
7027 stick with offsetof.
7028 (GC_POINTER_ALIGNMENT): New macro.
7029 (mark_memory): Omit 3rd (offset) arg; caller changed.
7030 Don't assume EMACS_INT alignment is the same as pointer alignment.
7032 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
7034 * keyboard.c (read_key_sequence_remapped): New var.
7035 (read_key_sequence): Compute remapping in the right buffer.
7036 (command_loop_1): Use read_key_sequence's remapping directly.
7038 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
7040 * dired.c (file_name_completion): Don't expand file name.
7041 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
7042 before checking file name handler.
7044 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
7045 they've been requested explicitly (bug#9591).
7047 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
7049 * keymap.c (Fsingle_key_description): Use make_specified_string
7050 instead of build_string to build string from push_key_description.
7053 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7055 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
7056 This fixes a Y2038 bug on 64-bit hosts.
7057 * buffer.c (reset_buffer):
7058 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
7059 (Fclear_buffer_auto_save_failure):
7060 Use 0, not -1, to represent an unset failure time, since time_t
7061 might not be signed.
7063 Remove dependency on glibc malloc internals.
7064 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7065 Move back here from lisp.h, but with their new implementations.
7066 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7067 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
7068 * charset.c (charset_table_init): New static var.
7069 (syms_of_charset): Use it instead of xmalloc. This removes a
7070 dependency on glibc malloc internals. See Eli Zaretskii's comment in
7071 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
7072 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7073 Move back to alloc.c.
7074 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7075 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
7077 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
7079 * nsterm.m (windowDidResize): Call x_set_window_size only when
7080 ns_in_resize is true. Otherwise set pixelwidth/height and
7081 call change_frame_size (Bug#9628).
7083 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7085 Port --enable-checking=all to Fedora 14 x86-64.
7086 * charset.c (syms_of_charset): Also account for glibc malloc's
7087 internal overhead when calculating the initial malloc maximum.
7089 Port --enable-checking=all to Fedora 14 x86.
7090 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7092 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
7093 (overrun_check_realloc, overrun_check_free):
7094 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
7095 That way, xmalloc returns a properly-aligned pointer even if
7096 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
7097 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
7098 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
7099 into account when calculating the initial malloc maximum.
7100 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7101 Move here from alloc.c, so that charset.c can use it too.
7102 Properly align; the old code wasn't right for common 32-bit hosts
7103 when configured with --enable-checking=all.
7104 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7105 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
7107 2011-09-29 Eli Zaretskii <eliz@gnu.org>
7109 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
7112 2011-09-28 Eli Zaretskii <eliz@gnu.org>
7114 * xdisp.c (compute_display_string_end): If there's no display
7115 string at CHARPOS, return -1.
7117 * bidi.c (bidi_fetch_char): When compute_display_string_end
7118 returns a negative value, treat the character as a normal
7119 character not covered by a display string. (Bug#9624)
7121 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
7123 * lread.c (Fread_from_string): Fix typo in docstring.
7125 2011-09-27 Eli Zaretskii <eliz@gnu.org>
7127 * xdisp.c (handle_invisible_prop): If invisible text ends on a
7128 newline, reseat the iterator instead of bidi-iterating there one
7129 character at a time. (Bug#9610)
7130 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
7131 TO_CHARPOS if the bidi iterator is at base embedding level.
7133 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
7135 * lread.c (readevalloop): Use correct code for NBSP.
7136 (read1): Likewise. (Bug#9608)
7138 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
7140 * dbusbind.c (Fdbus_register_signal): When service is not
7141 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
7143 2011-09-25 Glenn Morris <rgm@gnu.org>
7145 * buffer.c (truncate-lines): Doc fix.
7147 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
7149 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
7150 (Fset_window_next_buffers): Doc fix.
7152 2011-09-24 Glenn Morris <rgm@gnu.org>
7154 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
7156 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
7158 Fix minor problems found by static checking.
7159 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
7160 * indent.c (Fvertical_motion): Fix == vs = typo.
7162 2011-09-24 Eli Zaretskii <eliz@gnu.org>
7164 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
7165 Default value is now t. Doc fix.
7167 * indent.c (Fvertical_motion): Compute and apply the overshoot
7168 logic when moving up, not only when moving down. Fix the
7169 confusing name and values of the it_overshoot_expected variable;
7170 logic changes accordingly. (Bug#9254) (Bug#9549)
7172 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
7173 CHARPOS is covered by a display string which includes newlines.
7174 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7175 is covered by a display string with embedded newlines.
7177 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
7179 * dbusbind.c (Fdbus_register_signal): Add match rule to
7180 Vdbus_registered_objects_table. (Bug#9581)
7181 (Fdbus_register_method, Vdbus_registered_objects_table):
7184 2011-09-24 Jim Meyering <meyering@redhat.com>
7186 do not ignore write error for any output size
7187 The previous change was incomplete.
7188 While it makes emacs --batch detect the vast majority of stdout
7189 write failures, errors were still ignored whenever the output size is
7190 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7191 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7192 && echo FAIL: ignored write error
7193 FAIL: ignored write error
7194 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7195 && echo FAIL: ignored write error
7196 FAIL: ignored write error
7197 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7199 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7201 * emacs.c (Fkill_emacs): In noninteractive mode exit
7202 non-successfully if a write error occurred on stdout. (Bug#9574)
7204 2011-09-21 Eli Zaretskii <eliz@gnu.org>
7206 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7209 * dispextern.h (struct it): Update the comment documenting what
7212 2011-09-20 Eli Zaretskii <eliz@gnu.org>
7214 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7215 a display string, extend search for cursor position to end of row.
7216 (find_row_edges): If the row ends in a newline from a display
7217 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7218 Handle the case of a display string with multiple newlines.
7219 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7220 non-empty line. Fixes confusing cursor motion with arrow keys at
7221 the beginning of a line that starts with whitespace.
7223 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7225 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7228 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
7230 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7233 2011-09-18 Eli Zaretskii <eliz@gnu.org>
7235 * xdisp.c (display_line): Record maximum and minimum buffer
7236 positions even if no glyphs were produced (e.g., by a zero-width
7237 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7238 buffer positions that will be removed from the glyph row because
7240 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7241 column is beyond frame width: don't subtract 1 "pixel" when
7242 computing width of the stretch.
7243 (reseat_at_next_visible_line_start): Undo the change made on
7244 2011-09-17 that saved paragraph information and restored it after
7245 the call to `reseat'. (Bug#9545)
7247 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7249 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7250 and turn window cursor on if cleared (Bug#9415).
7252 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
7254 * search.c (boyer_moore): Take unibyte characters from pattern
7255 literally. (Bug#9458)
7257 2011-09-18 Eli Zaretskii <eliz@gnu.org>
7259 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7261 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7263 Fix minor problem found by static checking.
7264 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7265 initialized, to pacify gcc -Wuninitialized.
7267 * fileio.c: Report proper errno when syscall falls.
7268 (Finsert_file_contents): Save and restore errno,
7269 so that report_file_error outputs the correct diagnostic.
7270 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7272 2011-09-18 Eli Zaretskii <eliz@gnu.org>
7274 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7276 2011-09-17 Eli Zaretskii <eliz@gnu.org>
7278 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7279 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7281 2011-09-17 Eli Zaretskii <eliz@gnu.org>
7283 * xdisp.c (reseat_at_next_visible_line_start): Keep information
7284 about the current paragraph and restore it after the call to reseat.
7286 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7287 (bidi_find_paragraph_start): Search back for paragraph beginning
7288 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7289 (bidi_move_to_visually_next): Only trigger paragraph-related
7290 computations when the last character is a newline or at EOB, not
7291 just any NEUTRAL_B. (Bug#9470)
7293 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7294 truncated lines if point is covered by a display string. (Bug#9524)
7296 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7298 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7299 (cons_to_x_long): New function.
7300 (lisp_data_to_selection_data): Use it. Correct the test for
7301 short-versus-long data; it was negated. Break out of vector
7302 loop, for efficiency, when a long datum is discovered.
7304 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7306 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7308 2011-09-16 Eli Zaretskii <eliz@gnu.org>
7310 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7311 GCC PR/17406) by declaring this function with external scope.
7313 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7315 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7316 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7318 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7320 * editfns.c (Fformat): Correctly handle text properties on "%%".
7322 2011-09-15 Eli Zaretskii <eliz@gnu.org>
7324 * xterm.c (x_draw_composite_glyph_string_foreground):
7325 * w32term.c (x_draw_composite_glyph_string_foreground):
7326 * term.c (encode_terminal_code):
7327 * composite.c (composition_update_it, get_composition_id):
7328 * xdisp.c (get_next_display_element)
7329 (fill_composite_glyph_string): Add comments about special meaning
7330 of TAB characters in a composition.
7332 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7334 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
7335 This occurs when processing a multibyte format.
7336 Problem reported by Wolfgang Jenker.
7338 2011-09-15 Johan Bockgård <bojohan@gnu.org>
7340 * xdisp.c (try_cursor_movement): Only check for exact match if
7341 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7343 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7345 Remove unused external symbols.
7346 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7347 * xdisp.c (calc_pixel_width_or_height): Now static.
7348 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7349 * indent.c (check_display_width):
7350 * w32term.c: Fix comment to match code.
7351 * xterm.c, xterm.h (x_catching_errors): Remove.
7353 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7355 * xselect.c: Use signed conversions more consistently (Bug#9498).
7356 (selection_data_to_lisp_data): Assume incoming selection data are
7357 signed integers, not unsigned. This is to be consistent with
7358 outgoing selection data, which was modified to use signed integers
7359 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7360 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7361 expects long, not unsigned long.
7363 2011-09-14 Eli Zaretskii <eliz@gnu.org>
7365 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7366 computation of loop end. Reported by Johan Bockgård
7369 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
7371 * frame.c (Fother_visible_frames_p): Function deleted.
7373 2011-09-12 Eli Zaretskii <eliz@gnu.org>
7375 * indent.c (compute_motion): Process display vector front to back
7376 rather than the other way around. (Bug#2496)
7378 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7380 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7382 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
7384 * minibuf.c (Fread_from_minibuffer): Doc fix.
7386 2011-09-11 Eli Zaretskii <eliz@gnu.org>
7388 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7389 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7391 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7393 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7394 value for non-existent files.
7396 2011-09-11 Eli Zaretskii <eliz@gnu.org>
7398 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7399 set its "size" to -1. This will set the modtime_size field of
7400 the corresponding buffer to -1, which is what
7401 verify-visited-file-modtime expects for files that do not exist.
7404 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7406 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7408 * lisp.h: ... from here. push_key_description is no longer
7409 defined in keyboard.c, so its declaration should not be in
7410 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7411 logically belongs with push_key_description.
7413 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7415 * buffer.h: Include <sys/types.h> instead of <time.h>.
7416 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7417 Problem reported by Herbert J. Skuhra.
7419 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7421 * xml.c (parse_region): Make the parsing work for
7422 non-comment-starting XML files again (bug#9144).
7424 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7426 * image.c (gif_load): Fix calculation of bottom and right corner.
7429 2011-09-10 Eli Zaretskii <eliz@gnu.org>
7431 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7432 redisplay in small windows.
7434 2011-09-09 Eli Zaretskii <eliz@gnu.org>
7436 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7438 2011-09-08 Martin Rudalics <rudalics@gmx.at>
7440 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7441 Operate on live windows only.
7443 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
7445 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7447 2011-09-07 Eli Zaretskii <eliz@gnu.org>
7449 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7450 only under bidi iteration.
7452 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7454 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7456 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7458 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7459 Without this fix, the command to link temacs failed due to an
7460 undefined symbol __builtin_isnan. This is because
7461 /usr/include/iso/math_c99.h #defines isnan(x) to
7462 __builtin_isnan(x), but the bundled gcc, which identifies itself
7463 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7465 * floatfns.c (isnan): #undef, and then #define to a clone of
7467 (Fisnan): Always define, since it's always available now.
7468 (syms_of_floatfns): Always define isnan at the Lisp level.
7470 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7472 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7474 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7476 * fileio.c: Fix bugs with large file offsets (Bug#9428).
7477 The previous code assumed that file offsets (off_t values) fit in
7478 EMACS_INT variables, which is not true on typical 32-bit hosts.
7479 The code messed up by falsely reporting buffer overflow in cases
7480 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7481 when "big" contains more than 2**29 bytes, even though this
7482 inserts just one byte and does not overflow the buffer.
7483 (Finsert_file_contents): Store file offsets as off_t
7484 values, not as EMACS_INT values. Check for overflow when
7485 converting between EMACS_INT and off_t. When checking for
7486 buffer overflow or for overlap, take the offsets into account.
7487 Don't use EMACS_INT for small values where int suffices.
7488 When checking for overlap, fix a typo: ZV was used where
7489 ZV_BYTE was intended.
7490 (Fwrite_region): Don't assume off_t fits into 'long'.
7491 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7493 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
7495 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7497 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7499 sprintf-related integer and memory overflow issues (Bug#9412).
7501 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
7502 (esprintf, exprintf, evxprintf): New functions.
7503 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
7504 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
7505 (modify_event_symbol): Do not assume that the length of
7506 name_alist_or_stem is safe to alloca and fits in int.
7507 (Fexecute_extended_command): Likewise for function name and binding.
7508 (Frecursion_depth): Wrap around reliably on integer overflow.
7509 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7510 since some callers pass EMACS_INT values.
7511 (Fsingle_key_description): Don't crash if symbol name contains more
7512 than MAX_ALLOCA bytes.
7513 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7514 (get_minibuffer): Arg is now EMACS_INT, not int.
7515 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
7516 (esprintf, exprintf, evxprintf): New decls.
7517 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7519 * dbusbind.c (signature_cat): New function.
7520 (xd_signature, Fdbus_register_signal):
7521 Do not overrun buffer; instead, report string overflow.
7523 * dispnew.c (add_window_display_history): Don't overrun buffer.
7524 Truncate instead; this is OK since it's just a log.
7526 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7527 even if the time zone offset is outlandishly large.
7528 Don't mishandle offset == INT_MIN.
7530 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7531 when creating daemon; the previous buffer-overflow check was incorrect.
7533 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7534 which has the guts of the old verror function.
7536 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7537 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7539 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7540 (font_unparse_xlfd): Don't blindly alloca long strings.
7541 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
7542 fits in int, when using sprintf. Use single snprintf to count
7543 length of string rather than counting it via multiple sprintfs;
7544 that's simpler and more reliable.
7545 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7546 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7547 sprintf, in case result does not fit in int.
7549 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7550 (fontset_from_font): Print it.
7552 * frame.c (tty_frame_count): Now printmax_t, not int.
7553 (make_terminal_frame, set_term_frame_name): Print it.
7554 (x_report_frame_params): In X, window IDs are unsigned long,
7555 not signed long, so print them as unsigned.
7556 (validate_x_resource_name): Check for implausibly long names,
7557 and don't assume name length fits in 'int'.
7558 (x_get_resource_string): Don't blindly alloca invocation name;
7559 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7562 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7563 (xg_check_special_colors, xg_set_geometry):
7564 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7566 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7567 Use esprintf, not sprintf, in case result does not fit in int.
7569 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7570 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7571 it as a large positive number.
7572 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7573 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7575 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7576 in case result does not fit in int.
7578 * print.c (float_to_string): Detect width overflow more reliably.
7579 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7580 buffer overrun. Don't assume list length fits in 'int'. Treat
7581 print length of 0 as 0, not as infinity; to be consistent with other
7582 uses of print length in this function. Don't overflow print length
7583 index. Don't assume hash table size fits in 'long', or that
7584 vectorlike size fits in 'unsigned long'.
7586 * process.c (make_process): Use printmax_t, not int, to format
7587 process-name gensyms.
7589 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7591 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7592 to avoid potential buffer overrun.
7594 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7595 if X resource line is longer than 512 bytes.
7597 * xfns.c (x_window): Make sprintf buffer a bit bigger
7598 to avoid potential buffer overrun.
7600 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7602 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7604 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7606 Integer overflow fixes for scrolling, etc.
7607 Without these, Emacs silently mishandles large integers sometimes.
7608 For example, "C-u 4294967297 M-x recenter" was treated as if
7609 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7611 * xdisp.c (try_window_id): Check Emacs fixnum range before
7612 converting to 'int'.
7614 * window.c (window_scroll_line_based, Frecenter):
7615 Check that an Emacs fixnum is in range before assigning it to 'int'.
7616 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7617 values converted from Emacs fixnums.
7618 (Frecenter): Don't wrap around a line count if it is out of 'int'
7619 range; instead, treat it as an extreme value.
7620 (Fset_window_configuration, compare_window_configurations):
7621 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7623 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7624 that can exceed INT_MAX. Check that EMACS_INT value is in range
7625 before assigning it to the (possibly-narrower) index.
7626 (match_limit): Don't assume that a fixnum can fit in 'int'.
7628 * print.c (print_object): Use ptrdiff_t, not int, for index that can
7631 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
7632 (Fvertical_motion): Don't wrap around LINES values that don't fit
7633 in 'int'. Instead, treat them as extreme values. This is good
7634 enough for windows, which can't have more than INT_MAX lines anyway.
7636 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7638 * Require libxml/parser.h to avoid compilation warning.
7640 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7642 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7643 since this reportedly can destroy thread storage.
7645 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
7647 * syntax.c (find_defun_start): Update all cache variables if
7648 exiting early (Bug#9401).
7650 2011-08-30 Eli Zaretskii <eliz@gnu.org>
7652 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7654 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7655 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7656 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7658 * term.c (tty_append_glyph): New function.
7659 (produce_stretch_glyph): Static function and its prototype deleted.
7661 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7664 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7666 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7667 when checking :margin (Bug#9390).
7668 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
7669 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
7670 so that the name doesn't mislead. All uses changed.
7672 2011-08-28 Johan Bockgård <bojohan@gnu.org>
7674 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7677 2011-08-27 Eli Zaretskii <eliz@gnu.org>
7679 * xdisp.c (move_it_to): Don't bail out early when reaching
7680 position beyond to_charpos, if we are scanning backwards.
7681 (move_it_vertically_backward): When DY == 0, make sure we get to
7682 the first character in the line after the newline.
7684 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7686 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7687 (ccl_driver): Do not generate an out-of-range pointer.
7688 (Fccl_execute_on_string): Remove unnecessary check for
7689 integer overflow, noted by Stefan Monnier in
7690 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7691 Remove a FIXME that didn't need fixing.
7692 Simplify the newly-introduced buffer reallocation code.
7694 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
7696 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7698 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
7700 Integer and memory overflow issues (Bug#9196).
7702 * doc.c (get_doc_string): Rework so that
7703 get_doc_string_buffer_size is the actual buffer size, rather than
7704 being 1 less than the actual buffer size; this makes xpalloc more
7707 * image.c (x_allocate_bitmap_record, cache_image):
7708 * xselect.c (Fx_register_dnd_atom):
7709 Simplify previous changes by using xpalloc.
7711 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7712 since either will do and ptrdiff_t is convenient with xpalloc.
7714 * charset.c (charset_table_size)
7715 (struct charset_sort_data.priority): Now ptrdiff_t.
7716 (charset_compare): Don't overflow if priorities differ greatly.
7717 (Fsort_charsets): Don't assume list length fits in int.
7718 Check for size-calculation overflow when allocating sort data.
7719 (syms_of_charset): Allocate an initial charset table that is
7720 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7722 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7724 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7725 The actual value is always <= INT_MAX, and leaving it unsigned made
7726 overflow checking harder.
7728 * dispextern.h (struct glyph_matrix.rows_allocated)
7729 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7730 with xpalloc. The values are still always <= INT_MAX.
7732 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7734 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7735 (SAFE_NALLOCA): New macro.
7737 * region-cache.c (struct boundary.pos, find_cache_boundary)
7738 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7739 (set_cache_region, invalidate_region_cache)
7740 (revalidate_region_cache, know_region_cache, region_cache_forward)
7741 (region_cache_backward, pp_cache):
7742 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7743 so that ptrdiff_t * can be passed to xpalloc.
7744 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7745 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7746 (pp_cache): Don't assume cache_len fits in int.
7747 * region-cache.h: Adjust extern decls to match.
7749 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7750 EMACS_INT, since either will do, for xpalloc.
7752 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7753 (xnmalloc, xnrealloc, xpalloc): New functions.
7755 * bidi.c (bidi_shelve_header_size): New constant.
7756 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7757 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7759 * bidi.c (bidi_cache_shrink):
7760 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7762 Don't update size of array until after memory allocation succeeds,
7763 because xmalloc/xrealloc may not return.
7764 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7765 now that we have proper integer overflow checking.
7766 (record_overlay_string, overlay_strings): Catch overflows when
7767 calculating size of overlay_str_buf.
7769 * callproc.c (Fcall_process): Check for size overflow when
7770 calculating size of args2.
7771 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7772 Normally we prefer signed values, but sticking with ptrdiff_t would
7773 require adding more-complicated checks.
7775 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7776 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7777 Redo buffer-overflow calculations to avoid integer overflow.
7778 Add a FIXME comment where memory seems to be over-allocated.
7780 * character.c (Fstring): Check for size-calculation overflow.
7782 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7783 unnecessary integer overflow. Check for size overflow.
7784 (encode_coding_object): Don't update size until xmalloc succeeds.
7786 * composite.c (get_composition_id): Check for overflow in glyph
7787 length calculations.
7789 Integer and memory overflow fixes for display code.
7790 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7791 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7792 (scrolling_window): Check for overflow in size calculations.
7793 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7794 Don't assume glyph table len fits in int.
7795 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7796 (row_table_size): Now ptrdiff_t, not int.
7797 (scrolling_window): Avoid overflow in size calculations.
7798 Don't update size until allocation succeeds.
7799 * fns.c (concat): Check for overflow in size calculations.
7800 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7801 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7802 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7804 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7805 (get_doc_string): Check for size calculation overflow.
7806 Don't update size until allocation succeeds.
7807 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7808 EMACS_INT, where ptrdiff_t will do.
7809 (Fsubstitute_command_keys): Check for string overflow.
7811 * editfns.c (set_time_zone_rule): Don't assume environment length
7813 (message_length): Now ptrdiff_t, not int.
7814 (Fmessage_box): Don't update size until allocation succeeds.
7815 Don't assume message length fits in int.
7816 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7818 * emacs.c (main): Do not reallocate argv, since there is a null at
7819 the end that can be overwritten, and this way there's no need to
7820 worry about size-calculation overflow.
7821 (sort_args): Check for size-calculation overflow.
7823 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7825 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7827 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7828 (x_set_scroll_bar_width, x_figure_window_size):
7829 Check for integer overflow.
7830 (x_set_alpha): Do not assume XINT fits in int.
7832 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7833 This is for the members text_lines, text_cols, total_lines, total_cols,
7834 where the system imposes an 'int' limit.
7836 * fringe.c (Fdefine_fringe_bitmap):
7837 Don't update size until alloc works.
7839 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7840 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7842 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7843 Check for size-calculation overflow.
7844 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7845 do, as we prefer signed integers.
7846 (id_to_widget.max_size, id_to_widget.used)
7847 (xg_store_widget_in_map, xg_remove_widget_from_map)
7848 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7849 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7850 Use and return ptrdiff_t, not int.
7851 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7852 * gtkutil.h: Change prototypes to match the above.
7854 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7855 are duplicate now that they've been promoted to lisp.h.
7856 (x_allocate_bitmap_record, x_alloc_image_color)
7857 (make_image_cache, cache_image, xpm_load):
7858 Don't update size until alloc is done.
7859 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7861 Check for size calculation overflow.
7862 (ct_colors_allocated_max): New constant.
7863 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7866 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7867 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7868 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7869 Use ptrdiff_t, not int, to count maps.
7870 (read_char_minibuf_menu_prompt): Check for overflow in size
7871 calculations. Don't update size until allocation succeeds.
7872 Redo calculations to avoid overflow.
7873 * keyboard.h: Change prototypes to match the above.
7875 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7877 (current_minor_maps): Check for size calculation overflow.
7878 * keymap.h: Change prototypes to match the above.
7880 * lread.c (read1, init_obarray): Don't update size until alloc done.
7882 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7883 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7885 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7886 Now ptrdiff_t, not int.
7887 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7888 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7890 * process.c (Fnetwork_interface_list): Check for overflow
7891 in size calculation.
7893 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7895 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7896 overflow. Don't bother calling xmalloc when xrealloc will do.
7898 * search.c (Freplace_match): Check for size calculation overflow.
7899 (Fset_match_data): Don't assume list lengths fit in 'int'.
7901 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7902 for command line length. Do not attempt to address one before the
7903 beginning of an array, as that's not portable.
7905 * term.c (max_frame_lines): Remove; unused.
7906 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7908 (encode_terminal_code, calculate_costs): Check for size
7909 calculation overflow.
7910 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7911 table lengths and related sizes. Don't update size until alloc
7912 done. Redo calculations to avoid overflow.
7913 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7915 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7916 subtracting pointers.
7917 (gobble_line): Check for overflow more carefully. Don't update size
7920 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7921 Don't update size until alloc done.
7922 Redo size calculations to avoid overflow.
7923 Check for size calculation overflow.
7924 (main) [DEBUG]: Fix typo in invoking tparam1.
7926 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7927 Use ptrdiff_t, not int, for sizes.
7928 (store_mode_line_noprop_char): Don't update size until alloc done.
7930 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7931 Use ptrdiff_t, not int, for sizes.
7932 (Finternal_make_lisp_face, cache_face):
7933 Check for size calculation overflow.
7934 (cache_face): Treat size calculation overflows as if they were
7935 memory exhaustion (the usual treatment), rather than aborting.
7937 * xfns.c (x_encode_text, x_set_name_internal)
7938 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7939 sizes, since they can exceed INT_MAX in size. Check for size
7940 calculation overflow.
7942 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7943 (xg_select): Check for size calculation overflow.
7944 Don't update size until alloc done.
7946 * xrdb.c (get_environ_db): Don't assume path length fits in int,
7947 as sprintf is limited to int lengths.
7949 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7950 (X_LONG_MIN): New macros.
7951 Use them to make the following changes clearer.
7952 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7953 This change doesn't affect the value now, but it may help remind
7954 future maintainers not to raise the value too much later.
7955 (SELECTION_QUANTUM): Remove, replacing with ...
7956 (selection_quantum): ... new function, which avoids overflow.
7958 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7959 assumption that selection length fits in 'int'.
7960 (x_reply_selection_request, x_handle_selection_request)
7961 (x_get_window_property, receive_incremental_selection)
7962 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7963 (lisp_data_to_selection_data, clean_local_selection_data):
7964 Use ptrdiff_t, not int, to record length of selection.
7965 (x_reply_selection_request, x_get_window_property)
7966 (receive_incremental_selection, x_property_data_to_lisp):
7967 Redo calculations to avoid overflow.
7968 (x_reply_selection_request): When sending hint, ceiling it at
7969 X_LONG_MAX rather than relying on wraparound overflow to send
7971 (x_get_window_property, receive_incremental_selection)
7972 (lisp_data_to_selection_data, x_property_data_to_lisp):
7973 Check for size-calculation overflow.
7974 (x_get_window_property, receive_incremental_selection)
7975 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7976 Don't store size until memory allocation succeeds.
7977 (x_get_window_property): Plug memory leak on memory exhaustion.
7978 Don't double-block input; malloc is safe here. Don't assume 2**34
7979 - 4 fits in unsigned long. Add an xassert to check
7980 XGetWindowProperty overflow. Be more careful about overflow
7981 calculations, and distinguish size from memory overflow better.
7982 (receive_incremental_selection): When tracing, don't assume
7983 unsigned int is less than INT_MAX.
7984 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7985 harmful) conversions of unsigned short to int.
7986 (lisp_data_to_selection_data): Don't assume that integers
7987 in the range -65535 through -1 fit in an X unsigned short.
7988 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7989 result parameters unless successful. Rely on cons_to_unsigned
7990 to report problems with elements; the old code wasn't right anyway.
7991 (x_check_property_data): Check for int overflow; we cannot use
7992 a wider type due to X limits.
7993 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7995 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
7997 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7998 (x_term_init): Check for size calculation overflow.
7999 (x_color_cells): Don't store size until memory allocation succeeds.
8000 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
8001 Don't assume alloca size is less than MAX_ALLOCA.
8002 (x_term_init): Don't assume length fits in int (sprintf is limited
8005 Use ptrdiff_t for composition IDs.
8006 * character.c (lisp_string_width):
8007 * composite.c (composition_table_size, n_compositions)
8008 (get_composition_id, composition_gstring_from_id):
8009 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
8010 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
8011 * window.c (Frecenter):
8012 Use ptrdiff_t, not int, for composition IDs.
8013 * composite.c (get_composition_id): Check for integer overflow.
8014 * composite.h: Adjust prototypes to match the above changes.
8016 Use ptrdiff_t for hash table indexes.
8017 * category.c (hash_get_category_set):
8018 * ccl.c (ccl_driver):
8019 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
8020 * coding.c (coding_system_charset_list, detect_coding_system):
8021 * coding.h (struct coding_system.id):
8022 * composite.c (get_composition_id, gstring_lookup_cache):
8023 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
8024 * image.c (xpm_get_color_table_h):
8025 * lisp.h (hash_lookup, hash_put):
8026 * minibuf.c (Ftest_completion):
8027 Use ptrdiff_t for hash table indexes, not int (which is too
8028 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
8029 32-bit --with-wide-int hosts).
8031 * charset.c (Fdefine_charset_internal): Check for integer overflow.
8032 Add a FIXME comment about memory leaks.
8033 (syms_of_charset): Don't assume xmalloc returns.
8035 Don't assume that stated character widths fit in int.
8036 * character.c (Fchar_width, c_string_width, lisp_string_width):
8037 * character.h (CHAR_WIDTH):
8038 * indent.c (MULTIBYTE_BYTES_WIDTH):
8039 Use sanitize_char_width to avoid undefined and/or bad behavior
8040 with outlandish widths.
8041 * character.h (sanitize_tab_width): Rename from sanitize_width,
8042 now that we have two such functions. All uses changed.
8043 (sanitize_char_width): New inline function.
8045 Don't assume that tab-width fits in int.
8046 * character.h (sanitize_width): New inline function.
8047 (SANE_TAB_WIDTH): New macro.
8048 (ASCII_CHAR_WIDTH): Use it.
8049 * indent.c (sane_tab_width): Remove. All uses replaced by
8050 SANE_TAB_WIDTH (current_buffer).
8051 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
8053 * fileio.c: Integer overflow issues with file modes.
8054 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
8056 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
8057 Remove unreachable code.
8058 (read_hex, load_charset_map_from_file): Check for integer overflow.
8060 * xterm.c: Don't go over XClientMessageEvent limit.
8061 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
8062 (x_send_scroll_bar_event): Likewise. Check that the size does not
8063 exceed limits imposed by XClientMessageEvent, as well as the usual
8064 ptrdiff_t and size_t limits.
8066 * keyboard.c: Overflow, signedness and related fixes.
8067 (make_lispy_movement): Use same integer type in forward decl
8068 that is used in the definition.
8069 (read_key_sequence, keyremap_step):
8070 Change bufsize argument back to int, undoing my 2011-03-30 change.
8071 We prefer signed types, and int is wide enough here.
8072 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
8073 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
8074 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
8075 length, not size_t. Use ptrdiff_t for index, not int.
8076 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
8077 possibility of integer overflow.
8079 Overflow, signedness and related fixes for images.
8081 * dispextern.h (struct it.stack[0].u.image.image_id)
8082 (struct_it.image_id, struct image.id, struct image_cache.size)
8083 (struct image_cache.used, struct image_cache.ref_count):
8084 * gtkutil.c (update_frame_tool_bar):
8085 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
8086 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
8087 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
8088 * nsmenu.m (update_frame_tool_bar):
8089 * xdisp.c (calc_pixel_width_or_height):
8090 * xfns.c (image_cache_refcount):
8091 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
8092 on typical 64-bit hosts.
8094 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8095 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
8096 Omit unnecessary casts to int.
8097 (parse_image_spec): Check that integers fall into 'int' range
8098 when the callers expect that.
8099 (image_ascent): Redo ascent calculation to avoid int overflow.
8100 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
8101 (lookup_image): Remove unnecessary tests.
8102 (xbm_image_p): Locals are now of int, not EMACS_INT,
8103 since parse_image_check makes sure they fit into int.
8104 (png_load, gif_load, svg_load_image):
8105 Prefer int to unsigned where either will do.
8106 (tiff_handler): New function, combining the cores of the
8107 old tiff_error_handler and tiff_warning_handler.
8108 This function is rewritten to use vsnprintf and thereby avoid
8109 stack buffer overflows. It uses only the features of vsnprintf
8110 that are common to both POSIX and native Microsoft.
8111 (tiff_error_handler, tiff_warning_handler): Use it.
8112 (tiff_load, gif_load, imagemagick_load_image):
8113 Don't assume :index value fits in 'int'.
8114 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
8115 (imagemagick_load_image): Check that crop parameters fit into
8116 the integer types that MagickCropImage accepts. Don't assume
8117 Vimagemagick_render_type has a nonnegative value. Don't assume
8118 size_t fits in 'long'.
8119 (gs_load): Use printmax_t to print the widest integers possible.
8120 Check for integer overflow when computing image height and width.
8122 2011-08-26 Eli Zaretskii <eliz@gnu.org>
8124 * xdisp.c (redisplay_window): Don't force window start if point
8125 will be invisible in the resulting window. (Bug#9324)
8127 2011-08-25 Eli Zaretskii <eliz@gnu.org>
8129 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
8130 the display spec is of the form `(space ...)'.
8131 (handle_display_spec): Return the value returned by
8132 handle_single_display_spec, not just 1 or zero.
8133 (handle_single_display_spec): If the display spec is of the form
8134 `(space ...)', and specifies display in the text area, return 2
8136 (try_cursor_movement): Check for the need to scroll more
8137 accurately, and prefer exact match for point under bidi.
8138 Don't advance `row' beyond the last row of the window.
8140 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
8141 into disp_prop; all users changed.
8143 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
8144 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
8145 for the text covered by the display property.
8147 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
8149 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
8150 Change return value to nil.
8151 (Frecord_buffer): Delete unused function.
8153 2011-08-24 Eli Zaretskii <eliz@gnu.org>
8155 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
8156 buffers, return left-to-right.
8157 (set_cursor_from_row): Consider candidate row a win if its glyph
8158 represents a newline and point is on that newline. Fixes cursor
8159 positioning on the newline at EOL of R2L text within L2R
8160 paragraph, and vice versa.
8161 (try_cursor_movement): Check continued rows, in addition to
8162 continuation rows. Fixes unwarranted scroll when point enters a
8163 continued line of R2L text within an L2R paragraph, or vice versa.
8164 (cursor_row_p): Consider the case of point being equal to
8165 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
8166 from the end of a short line to the beginning of a continued line
8167 of R2L text within L2R paragraph.
8168 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
8169 composed characters.
8171 * bidi.c (bidi_check_type): Use xassert.
8172 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8175 2011-08-23 Eli Zaretskii <eliz@gnu.org>
8177 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8180 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
8182 * nsfont.m (ns_otf_to_script): Fix typo.
8184 2011-08-22 Kenichi Handa <handa@m17n.org>
8186 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8187 extra slot even if the purpose is char-code-property-table.
8189 2011-08-23 Eli Zaretskii <eliz@gnu.org>
8191 * xdisp.c (redisplay_window): When computing centering_position,
8192 account for the height of the header line. (Bug#8874)
8194 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8195 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8196 candidate is selected by the mouse, and that candidate has a
8197 composed character under the mouse.
8199 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8200 coordinates reported by pos-visible-in-window-p for a composed
8201 character in column zero.
8203 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8205 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8207 2011-08-22 Eli Zaretskii <eliz@gnu.org>
8209 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8210 consider it a hit if to_charpos is anywhere in the range of the
8211 composed buffer positions.
8213 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
8215 * image.c (gif_load): Don't assume that each subimage has the same
8216 dimensions as the base image. Handle disposal method that is
8217 "undefined" by the gif spec (Bug#9335).
8219 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
8221 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
8222 (Fcondition_case): Document `debug' symbol in error handler.
8224 2011-08-19 Eli Zaretskii <eliz@gnu.org>
8226 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8227 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8228 from an Org mode buffer to a Speedbar frame.
8230 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8231 a composition, take its buffer position from IT->cmp_it.charpos.
8232 Fixes cursor positioning at the beginning of a line that begins
8233 with a composed character.
8235 2011-08-18 Eli Zaretskii <eliz@gnu.org>
8237 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8238 character bidirectional type, use STRONG_L instead. Fixes crashes
8239 in a buffer produced by `describe-categories'.
8241 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8242 members before the level stack, so they would be saved and
8243 restored when copying iterator state. Fixes incorrect reordering
8244 around TABs covered by display properties.
8246 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8248 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
8250 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
8252 * eval.c (internal_condition_case, internal_condition_case_1)
8253 (internal_condition_case_2, internal_condition_case_n):
8254 Remove unnecessary aborts (Bug#9081).
8256 2011-08-17 Eli Zaretskii <eliz@gnu.org>
8258 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8259 has no `load' handler, try opening the file locally. (Bug#9311)
8261 2011-08-16 Ken Brown <kbrown@cornell.edu>
8263 * gmalloc.c: Expand comment.
8265 2011-08-16 Eli Zaretskii <eliz@gnu.org>
8267 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8268 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8270 2011-08-16 Ken Brown <kbrown@cornell.edu>
8272 Fix memory allocation problems in Cygwin build (Bug#9273).
8274 * unexcw.c ( __malloc_initialized): Declare external variable.
8275 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8277 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8279 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8281 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8283 [CYGWIN] (special_realloc): New function.
8284 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8285 requests to realloc storage in the static heap.
8287 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8289 * bidi.c (bidi_initialize): Remove unused local.
8291 2011-08-15 Eli Zaretskii <eliz@gnu.org>
8294 * biditype.h: Remove file.
8295 * makefile.w32-in ($(BLD)/bidi.$(O)):
8296 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
8298 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8300 * chartab.c: Improve commentary for the uniprop_table API.
8302 * bidi.c (bidi_paragraph_init): Support zero value of
8303 bidi_ignore_explicit_marks_for_paragraph_level.
8304 (bidi_initialize): Use uniprop_table instead of including
8305 biditype.h and bidimirror.h.
8307 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8308 coordinates of the iterator when restoring from ppos_it.
8311 2011-08-14 Kenichi Handa <handa@m17n.org>
8313 * process.c (create_process): Call setup_process_coding_systems
8314 after the pid of the process is set to -1 (Bug#8162).
8316 2011-08-14 Eli Zaretskii <eliz@gnu.org>
8318 * xdisp.c (move_it_in_display_line_to): Don't invoke
8319 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8320 ppos_it. Fixes vertical cursor motion when line beginning is
8321 covered by an image. (Bug#9296)
8323 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8325 * nsterm.h (ns_run_ascript): Declare.
8326 (NSAPP_DATA2_RUNASSCRIPT): Define.
8328 * nsfns.m (as_script, as_result, as_status): New static variables.
8329 (ns_run_ascript): New function.
8330 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
8331 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8332 the event loop. Get status from as_status (Bug#7276).
8334 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8335 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8336 the event loop (Bug#7276).
8338 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8340 * gnutls.c (QCgnutls_bootprop_priority)
8341 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8342 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8343 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8344 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8345 (QCgnutls_bootprop_verify_hostname_error)
8346 (QCgnutls_bootprop_callbacks_verify): Rename from
8347 Qgnutls_bootprop_..., all uses changed.
8349 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8352 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8354 * xfaces.c (Qframe_set_background_mode): Now static.
8355 * dispextern.h (Qframe_set_background_mode): Remove decl.
8357 * process.c (Fnetwork_interface_info): Declare local only if needed.
8359 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8361 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8362 (Fnetwork_interface_list): Allocate in increments of bytes instead
8363 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8364 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8366 (struct ifflag_def): notrailers is smart on OSX.
8367 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8368 Get hardware address with getifaddrs if available.
8370 2011-08-12 Eli Zaretskii <eliz@gnu.org>
8372 * xdisp.c (iterate_out_of_display_property): xassert that
8373 IT->position is set to within IT->object's boundaries. Break from
8374 the loop as soon as EOB is reached; avoids infloops in redisplay
8375 when IT->position is set up wrongly due to some bug.
8376 Set IT->current to match the bidi iterator unconditionally.
8377 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8378 entry. Force push_it to save on the stack the current
8379 buffer/string position, to be restored by pop_it. Fix flags in
8380 the iterator structure wrt the object coming from a display
8381 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8382 properties. (Bug#9284)
8384 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
8386 * fontset.c (fontset_get_font_group): Add proper type checks.
8389 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8391 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8392 and LC_VERSION_MIN_MACOSX.
8393 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8394 (dump_it) [LC_FUNCTION_STARTS]: Use it.
8396 2011-08-08 Eli Zaretskii <eliz@gnu.org>
8398 * xdisp.c (forward_to_next_line_start): Allow to use the
8399 no-display-properties-and-no-overlays under bidi display.
8400 Set disp_pos in the bidi iterator to avoid searches for display
8401 properties and overlays.
8403 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
8405 * editfns.c (Fset_time_zone_rule): Document relationship with the
8408 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8409 the font entity extracted from the cache (Bug#8109).
8411 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
8413 * composite.c (autocmp_chars): Don't reset point. That is done by
8414 restore_point_unwind (Bug#5984).
8416 2011-08-07 Juri Linkov <juri@jurta.org>
8418 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8419 to show the arg `TIME' instead of `TIMEVAL'.
8421 2011-08-06 Eli Zaretskii <eliz@gnu.org>
8423 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8424 display property strides EOL and includes a newline, as in
8425 longlines-mode. (Bug#9254)
8426 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8427 word-wrap under bidirectional display. (Bug#9224)
8429 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8430 is non-zero, even if the data buffer is NULL. Fixes a crash in
8431 vertical-motion with longlines-mode. (Bug#9254)
8433 2011-08-05 Eli Zaretskii <eliz@gnu.org>
8435 * bidi.c <bidi_cache_total_alloc>: Now static.
8436 (bidi_initialize): Initialize bidi_cache_total_alloc.
8438 * xdisp.c (display_line): Release buffer allocated for shelved bidi
8441 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8442 amount allocated this far in `bidi_cache_total_alloc'.
8443 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8444 non-zero, only free the data buffer without restoring the cache
8445 contents. All callers changed.
8447 * dispextern.h (bidi_unshelve_cache): Update prototype.
8449 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8450 (move_it_in_display_line, move_it_to)
8451 (move_it_vertically_backward, move_it_by_lines): Replace the call
8452 to xfree to an equivalent call to bidi_unshelve_cache.
8453 (move_it_in_display_line_to): Fix logic of returning
8454 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
8456 2011-08-05 Eli Zaretskii <eliz@gnu.org>
8458 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8459 came from a string character with a `cursor' property. (Bug#9229)
8461 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8463 * Makefile.in (LIB_PTHREAD): New variable.
8464 (LIBES): Add LIB_PTHREAD (Bug#9216).
8466 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8467 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8469 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8471 * regex.c (re_iswctype): Remove some redundant boolean conversions.
8473 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8475 * xterm.c (x_find_topmost_parent): New function.
8476 (x_set_frame_alpha): Find topmost parent window with
8477 x_find_topmost_parent and set the property there also (bug#9181).
8478 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8480 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8482 * callproc.c (Fcall_process): Avoid vfork clobbering
8483 the local vars buffer, coding_systems, current_dir.
8485 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8487 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8489 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8491 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8492 so that it is not optimized away.
8494 * xdisp.c (compute_display_string_pos): Remove unused local.
8496 2011-08-02 Eli Zaretskii <eliz@gnu.org>
8498 Fix slow cursor motion and scrolling in large buffers with
8499 selective display, like Org Mode buffers. (Bug#9218)
8501 * dispextern.h (struct bidi_it): New member disp_prop_p.
8503 * xdisp.c: Remove one-slot cache of display string positions.
8504 (compute_display_string_pos): Accept an additional argument
8505 DISP_PROP_P; callers changed. Scan at most 5K characters forward
8506 for a display string or property. If found, set DISP_PROP_P
8509 * bidi.c (bidi_fetch_char): Accept an additional argument
8510 DISP_PROP_P, and pass it to compute_display_string_pos.
8511 Only handle text covered by a display string if DISP_PROP_P is returned
8512 non-zero. All callers of bidi_fetch_char changed.
8514 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8516 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8518 2010-12-03 Don March <don@ohspite.net>
8520 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8521 last character M-[char] is translated to ESC [char] (bug#7541).
8523 2011-08-02 Kenichi Handa <handa@m17n.org>
8525 * lisp.h (uniprop_table): Extern it.
8527 * chartab.c (uniprop_table): Make it non-static.
8529 2011-08-01 Eli Zaretskii <eliz@gnu.org>
8531 * xdisp.c (forward_to_next_line_start): Accept additional argument
8532 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8534 (reseat_at_next_visible_line_start): Use the bidi iterator state
8535 returned by forward_to_next_line_start to restore the state of
8536 it->bidi_it after backing up to previous newline. (Bug#9212)
8538 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8540 * regex.c (re_comp): Protoize.
8541 (re_exec): Fix return type.
8542 (regexec): Fix type of `ret'. (Bug#9203)
8544 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8546 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8547 This is needed if max-image-size is a floating-point number.
8549 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8551 * print.c (print_object): Print empty symbol as ##.
8553 * lread.c (read1): Read ## as empty symbol.
8555 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8557 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8558 setting frame foreground color (Bug#9175).
8559 (x_set_background_color): Likewise.
8561 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8562 contents (Bug#9176).
8563 (EmacsTooltip -init): Remove bezels and add shadows to
8566 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8567 or scroll bar (Bug#8470).
8569 * nsfont.m (nsfont_open): Remove assignment to voffset and
8570 unnecessary vars hshink, expand, hd, full_height, min_height.
8571 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8573 * nsterm.h (nsfont_info): Remove voffset field.
8575 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8577 Implement strike-through and overline on NextStep (Bug#8863).
8579 * nsfont.m (nsfont_open): Use underline position provided by font,
8580 instead of hard-coded value of 2.
8581 (nsfont_draw): Call ns_draw_text_decoration instead.
8583 * nsterm.h: Add declaration for ns_draw_text_decoration.
8585 * nsterm.m (ns_draw_text_decoration): New function for drawing
8586 underline, overline, and strike-through.
8587 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8588 ns_draw_text_decoration. Change treatment of cursor drawing to
8589 accommodate underlining, etc.
8591 2011-07-28 Eli Zaretskii <eliz@gnu.org>
8593 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8596 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8598 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8599 Without this fix, if a signal arrives just after memory fills up,
8600 'malloc' might be invoked reentrantly.
8602 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8603 In other words, assume that every image size is allowed, on non-X
8604 hosts. This assumption is probably wrong, but it lets Emacs compile.
8606 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8608 * regex.c (re_iswctype): Convert return values to boolean.
8610 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8612 * xdisp.c (compute_display_string_pos): Don't use cached display
8613 string position if the buffer had its restriction changed.
8616 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8618 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8620 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8622 Integer signedness and overflow and related fixes. (Bug#9079)
8624 * bidi.c: Integer size and overflow fixes.
8625 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8626 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8627 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8628 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8629 (bidi_find_other_level_edge):
8630 Use ptrdiff_t instead of EMACS_INT where either will do.
8631 This works better on 32-bit hosts configured --with-wide-int.
8632 (bidi_cache_ensure_space): Check for size-calculation overflow.
8633 Use % rather than repeated addition, for better worst-case speed.
8634 Don't set bidi_cache_size until after xrealloc returns, because it
8636 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
8637 (bidi_cache_ensure_space): Also check that the bidi cache size
8638 does not exceed that of the largest Lisp string or buffer. See Eli
8639 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
8641 * alloc.c (__malloc_size_t): Remove.
8642 All uses replaced by size_t. See Andreas Schwab's note
8643 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8645 * image.c: Improve checking for integer overflow.
8646 (check_image_size): Assume that f is nonnull, since
8647 it is always nonnull in practice. This is one less thing to
8648 worry about when checking for integer overflow later.
8649 (x_check_image_size): New function, which checks for integer
8650 overflow issues inside X.
8651 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8652 This removes the need for a memory_full check.
8653 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8654 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8655 (xbm_read_bitmap_data): Change locals back to 'int', since
8656 their values must fit in 'int'.
8657 (xpm_load_image, png_load, tiff_load):
8658 Invoke x_create_x_image_and_pixmap earlier,
8659 to avoid much needless work if the image is too large.
8660 (tiff_load): Treat overly large images as if
8661 x_create_x_image_and_pixmap failed, not as malloc failures.
8662 (gs_load): Use x_check_image_size.
8664 * gtkutil.c: Omit integer casts.
8665 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8666 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8668 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8670 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8671 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8672 would wrongly return t on a 64-bit host.
8674 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8675 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8676 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8677 and therefore cause GCC to emit a bogus diagnostic in some cases.
8679 * image.c: Integer signedness and overflow and related fixes.
8680 This is not an exhaustive set of fixes, but it's time to
8681 record what I've got.
8682 (lookup_pixel_color, check_image_size): Remove redundant decls.
8683 (check_image_size): Don't assume that arbitrary EMACS_INT values
8684 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8685 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8686 (tiff_load, imagemagick_load_image):
8687 Check for overflow in size calculations.
8688 (x_create_x_image_and_pixmap): Remove unnecessary test for
8689 xmalloc returning NULL; that can't happen.
8690 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8691 (xpm_color_bucket): Use better integer hashing function.
8692 (xpm_cache_color): Don't possibly over-allocate memory.
8693 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8694 (gif_memory_source):
8695 Use ptrdiff_t, not int or size_t, to record sizes.
8696 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8697 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8698 either works, as we prefer signed integers.
8699 (tiff_read_from_memory, tiff_write_from_memory):
8700 Return tsize_t, not size_t, since that's what the TIFF API wants.
8701 (tiff_read_from_memory): Don't fail simply because the read would
8702 go past EOF; instead, return a short read.
8703 (tiff_load): Omit no-longer-needed casts.
8704 (Fimagemagick_types): Don't assume size fits into 'int'.
8706 Improve hashing quality when configured --with-wide-int.
8707 * fns.c (hash_string): New function, taken from sxhash_string.
8708 Do not discard information about ASCII character case; this
8709 discarding is no longer needed.
8710 (sxhash-string): Use it. Change sig to match it. Caller changed.
8711 * lisp.h: Declare it.
8712 * lread.c (hash_string): Remove, since we now use fns.c's version.
8713 The fns.c version returns a wider integer if --with-wide-int is
8714 specified, so this should help the quality of the hashing a bit.
8716 * emacs.c: Integer overflow minor fix.
8717 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8718 Define only if GNU_LINUX.
8719 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8721 * dispnew.c: Integer signedness and overflow fixes.
8722 Remove unnecessary forward decls, that were a maintenance hassle.
8723 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8725 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8726 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8727 (prepare_desired_row, line_draw_cost):
8728 Use int, not unsigned, where either works.
8729 (save_current_matrix, restore_current_matrix):
8730 Use ptrdiff_t, not size_t, where either works.
8731 (init_display): Check for overflow more accurately, and without
8732 relying on undefined behavior.
8734 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8735 Remove, replacing with the new symbols in lisp.h. All uses changed.
8736 * fileio.c (make_temp_name):
8737 * filelock.c (lock_file_1, lock_file):
8738 * xdisp.c (message_dolog):
8739 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8740 Use pMd etc. instead.
8741 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8742 replacing the pWIDE etc. symbols removed from editfns.c.
8744 * keyboard.h (num_input_events): Now uintmax_t.
8745 This is (very slightly) less likely to mess up due to wraparound.
8748 * buffer.c: Integer signedness fixes.
8749 (alloc_buffer_text, enlarge_buffer_text):
8750 Use ptrdiff_t rather than size_t when either will do, as we prefer
8753 * alloc.c: Integer signedness and overflow fixes.
8754 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8755 (__malloc_size_t): Default to size_t, not to int.
8756 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8757 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8758 Prefer ptrdiff_t to size_t when either would do, as we prefer
8760 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8761 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8762 Now const. Initialize with values that are in range even if char
8764 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8765 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8766 These functions do the right thing with sizes > 2**32.
8767 (check_depth): Now ptrdiff_t, not int.
8768 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8769 Adjust to new way of storing sizes. Check for size overflow bugs
8771 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8772 slightly wrong anyway, as it missed one instance of
8773 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8774 (refill_memory_reserve): Omit needless cast to size_t.
8775 (mark_object_loop_halt): Mark as externally visible.
8777 * xselect.c: Integer signedness and overflow fixes.
8778 (Fx_register_dnd_atom, x_handle_dnd_message):
8779 Use ptrdiff_t, not size_t, since we prefer signed.
8780 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8781 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8782 x_dnd_atoms_size and x_dnd_atoms_length.
8784 * doprnt.c: Prefer signed to unsigned when either works.
8786 * doprnt.c (doprnt):
8788 * xdisp.c (vmessage):
8789 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8790 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8791 prefer signed arithmetic to avoid comparison confusion.
8792 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8793 but is a bit tricky.
8795 Assume freestanding C89 headers, string.h, stdlib.h.
8796 * data.c, doprnt.c, floatfns.c, print.c:
8797 Include float.h unconditionally.
8798 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8799 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8800 * regex.c: Likewise for stddef.h, string.h.
8801 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8802 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8803 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8804 (STDC_HEADERS): Remove obsolete defines.
8805 * sysdep.c: Include limits.h unconditionally.
8807 Assume support for memcmp, memcpy, memmove, memset.
8808 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8809 * regex.c (memcmp, memcpy):
8810 Remove; we assume C89 now.
8812 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8813 (__malloc_safe_bcopy): Remove; no longer needed.
8815 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
8816 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8817 well either way, and we prefer signed to unsigned.
8819 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8821 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8822 closes the connection while we're reading (bug#9182).
8824 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
8826 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8827 are specified (Bug#9168).
8829 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8831 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8832 Found by GCC static checking and --with-wide-int on a 32-bit host.
8834 2011-07-25 Eli Zaretskii <eliz@gnu.org>
8836 * xdisp.c (compute_display_string_pos): Fix logic of caching
8837 previous display string position. Initialize cached_prev_pos to
8838 -1. Fixes slow-down at the beginning of a buffer.
8840 2011-07-24 Eli Zaretskii <eliz@gnu.org>
8842 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8843 for attrs[LFACE_FONTSET_INDEX].
8845 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8847 * xml.c (parse_region): Remove unused local
8848 that was recently introduced.
8850 2011-07-23 Eli Zaretskii <eliz@gnu.org>
8852 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8853 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8855 * xdisp.c (move_it_in_display_line_to): Record the best matching
8856 position for TO_CHARPOS while scanning the line, and restore it on
8857 exit if none of the characters scanned was an exact match.
8858 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
8859 when exact match is impossible due to invisible text, and the
8860 lines are truncated.
8862 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8864 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8867 2011-07-22 Eli Zaretskii <eliz@gnu.org>
8869 Fix a significant slow-down of cursor motion with C-n, C-p,
8870 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8871 auto-repeat under bidi redisplay in fontified buffers.
8872 * xdisp.c (compute_stop_pos_backwards): New function.
8873 (next_element_from_buffer): Call compute_stop_pos_backwards to
8874 find a suitable prev_stop when we find ourselves before
8876 (reseat): Don't look for prev_stop, as that could mean a very long
8878 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8879 <cached_disp_overlay_modiff>: Cache for last found display string
8881 (compute_display_string_pos): Return the cached position if asked
8882 about the same buffer in the same area of character positions, and
8883 the buffer wasn't changed since the time the display string
8884 position was cached.
8886 2011-07-22 Eli Zaretskii <eliz@gnu.org>
8888 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8889 is an integer, which is important for empty lines. (Bug#9149)
8891 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
8893 * frame.c (Fmodify_frame_parameters): In tty case, update the
8894 default face if necessary (Bug#4238).
8896 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
8898 * editfns.c (Fstring_to_char): No need to explain what a character
8899 is in the docstring (Bug#6576).
8901 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8903 * xml.c (parse_region): Make sure we always return a tree.
8905 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8907 * xml.c (parse_region): If a document contains only comments,
8910 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8912 * xml.c (make_dom): Return comments, too.
8914 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8917 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8918 and the surrounding thread.
8919 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8920 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8921 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8923 * s/openbsd.h (BROKEN_SIGIO): Define.
8924 * unexelf.c (unexec) [__OpenBSD__]:
8925 Don't update the .mdebug section of the Alpha COFF symbol table.
8927 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8929 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8932 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8934 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8935 This fixes some race conditions on the permissions of any newly
8938 * alloc.c (valid_pointer_p): Use pipe, not open.
8939 This fixes some permissions issues when debugging.
8941 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8942 If fchown fails to set both uid and gid, try to set just gid,
8943 as that is sometimes allowed. Adjust the file's mode to eliminate
8944 setuid or setgid bits that are inappropriate if fchown fails.
8946 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8948 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8949 to compare Lisp_Objects.
8950 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8951 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8952 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8954 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8956 * lread.c (read_integer): Unread even EOF character.
8957 (read1): Likewise. Properly record start position of symbol.
8959 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8960 symbol character follows.
8962 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8964 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8965 This works around a problem with the previous change to Fcopy_file.
8966 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8967 and without this change, GCC might complain about discarding
8968 fchown's return value.
8970 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
8972 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8974 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8976 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8978 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8980 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8981 it's used from the C level.
8983 * process.c: Use the same condition for POLL_FOR_INPUT in both
8984 keyboard.c and process.c (bug#1858).
8986 2011-07-09 Lawrence Mitchell <wence@gmx.li>
8988 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8989 (Fgnutls_boot): Use it.
8991 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8993 * doc.c (Fsubstitute_command_keys): Revert last change.
8995 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8997 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8998 quotes the next character, and doesn't affect other longer
8999 sequences (bug#8935).
9001 * lread.c (syms_of_lread): Clarify that is isn't only
9002 `eval-buffer' and `eval-defun' that's affected by
9003 `lexical-binding' (bug#8460).
9005 2011-07-15 Eli Zaretskii <eliz@gnu.org>
9007 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
9008 bidi redisplay when a line includes both an image and is truncated.
9010 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
9012 Fix minor problems found by static checking.
9013 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
9014 (elsz): Now a signed constant, not a size_t var. We prefer signed
9015 types to unsigned, to avoid integer comparison confusion. Without
9016 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
9017 "cannot optimize loop, the loop counter may overflow", a symptom
9019 * indent.c (Fvertical_motion): Mark locals as initialized.
9020 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
9022 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9024 * search.c (Fre_search_backward): Mention `case-fold-search' in
9025 all the re_search_* functions (bug#8138).
9027 * keyboard.c (Fopen_dribble_file): Document when the file is
9030 2011-07-14 Eli Zaretskii <eliz@gnu.org>
9032 * bidi.c (bidi_dump_cached_states): Fix format of displaying
9035 Support bidi reordering of display and overlay strings.
9036 * xdisp.c (compute_display_string_pos)
9037 (compute_display_string_end): Accept additional argument STRING.
9038 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
9039 (reseat_to_string): Initialize bidi_it->string.s and
9040 bidi_it->string.schars.
9041 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
9042 NULL (avoids a crash in bidi_paragraph_init).
9043 Initialize itb.string.lstring.
9044 (init_iterator): Call bidi_init_it only of a valid
9045 buffer position was specified. Initialize paragraph_embedding to
9047 (reseat_to_string): Initialize the bidi iterator.
9048 (display_string): If we need to ignore text properties of
9049 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
9050 original value of -1 will not work with bidi.)
9051 (compute_display_string_pos): First arg is now struct
9052 `text_pos *'; all callers changed. Support display properties on
9054 (compute_display_string_end): Support display properties on Lisp
9056 (init_iterator, reseat_1, reseat_to_string): Initialize the
9057 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
9058 when iterating on a string not from display properties).
9059 (compute_display_string_pos, compute_display_string_end):
9060 Fix calculation of the object to scan. Fixes an error when using
9062 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
9063 base_level_stop; instead, set base_level_stop to BEGV.
9064 Fixes crashes in vertical-motion.
9065 (next_element_from_buffer): Improve commentary for when
9066 the iterator is before prev_stop.
9067 (init_iterator): Initialize bidi_p from the default value of
9068 bidi-display-reordering, not from buffer-local value. Use the
9069 buffer-local value only if initializing for buffer iteration.
9070 (handle_invisible_prop): Support invisible properties on strings
9071 that are being bidi-reordered.
9072 (set_iterator_to_next): Support bidi reordering of C strings and
9074 (next_element_from_string): Support bidi reordering of Lisp
9076 (handle_stop_backwards): Support Lisp strings as well.
9077 (display_string): Support display of R2L glyph rows.
9078 Use IT_STRING_CHARPOS when displaying from a Lisp string.
9079 (init_iterator): Don't initialize it->bidi_p for strings
9081 (reseat_to_string): Initialize it->bidi_p for strings here.
9082 (next_element_from_string, next_element_from_c_string)
9083 (next_element_from_buffer): Add xassert's for correspondence
9084 between IT's object being iterated and it->bidi_it.string
9086 (face_before_or_after_it_pos): Support bidi iteration.
9087 (next_element_from_c_string): Handle the case of the first string
9088 character that is not the first one in the visual order.
9089 (get_visually_first_element): New function, refactored from common
9090 parts of next_element_from_buffer, next_element_from_string, and
9091 next_element_from_c_string.
9092 (tool_bar_lines_needed, redisplay_tool_bar)
9093 (display_menu_bar): Force left-to-right direction. Add a FIXME
9094 comment for making that be controlled by a user option.
9095 (push_it, pop_it): Save and restore the state of the
9096 bidi iterator. Save and restore the bidi_p flag.
9097 (pop_it): Iterate out of display property for string iteration as
9099 (iterate_out_of_display_property): Support iteration over strings.
9100 (handle_single_display_spec): Set up it->bidi_it for iteration
9101 over a display string, and call bidi_init_it.
9102 (handle_single_display_spec, next_overlay_string)
9103 (get_overlay_strings_1, push_display_prop): Set up the bidi
9104 iterator for displaying display or overlay strings.
9105 (forward_to_next_line_start): Don't use the shortcut if
9107 (back_to_previous_visible_line_start): If handle_display_prop
9108 pushed the iterator stack, restore the internal state of the bidi
9109 iterator by calling bidi_pop_it same number of times.
9110 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
9111 and we are bidi-iterating, don't decrement the iterator position;
9112 instead, set the first_elt flag in the bidi iterator, to produce
9114 (reseat_1): Remove redundant setting of string_from_display_prop_p.
9115 (push_display_prop): xassert that we are iterating a buffer.
9116 (push_it, pop_it): Save and restore paragraph_embedding member.
9117 (handle_single_display_spec, next_overlay_string)
9118 (get_overlay_strings_1, reseat_1, reseat_to_string)
9119 (push_display_prop): Set up the `unibyte' member of bidi_it.string
9120 correctly. Don't assume unibyte strings are not bidi-reordered.
9121 (compute_display_string_pos)
9122 (compute_display_string_end): Fix handling the case of C string.
9123 (push_it, pop_it): Save and restore from_disp_prop_p.
9124 (handle_single_display_spec, push_display_prop): Set the
9125 from_disp_prop_p flag.
9126 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
9127 (pop_it): Call iterate_out_of_display_property only if we are
9128 popping after iteration over a string that came from a display
9129 property. Fix a typo in popping stretch info. Add an assertion
9130 for verifying that the iterator position is in sync with the bidi
9132 (handle_single_display_spec, get_overlay_strings_1)
9133 (push_display_prop): Fix initialization of paragraph direction for
9134 string when that of the parent object is not yet determined.
9135 (reseat_1): Call bidi_init_it to resync the bidi
9136 iterator with IT's position. (Bug#7616)
9137 (find_row_edges): If ROW->start.pos gives position
9138 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
9139 (handle_stop, back_to_previous_visible_line_start, reseat_1):
9140 Reset the from_disp_prop_p flag.
9141 (SAVE_IT, RESTORE_IT): New macros.
9142 (pos_visible_p, face_before_or_after_it_pos)
9143 (back_to_previous_visible_line_start)
9144 (move_it_in_display_line_to, move_it_in_display_line)
9145 (move_it_to, move_it_vertically_backward, move_it_by_lines)
9146 (try_scrolling, redisplay_window, display_line): Use them when
9147 saving a temporary copy of the iterator and restoring it back.
9148 (back_to_previous_visible_line_start, reseat_1)
9149 (init_iterator): Empty the bidi cache "stack".
9150 (move_it_in_display_line_to): If iterator ended up at
9151 EOL, but we never saw any buffer positions smaller than
9152 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
9153 motion in bidi-reordered lines.
9154 (move_it_in_display_line_to): Record prev_method and prev_pos
9155 immediately before the call to set_iterator_to_next. Fixes cursor
9156 motion in bidi-reordered lines with stretch glyphs and strings
9157 displayed in margins. (Bug#8133) (Bug#8867)
9158 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
9160 (pos_visible_p): Support positions in bidi-reordered lines.
9161 Save and restore bidi cache.
9163 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
9164 (bidi_paragraph_info): Delete unused struct.
9165 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
9166 (bidi_cache_start): New variable.
9167 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
9169 (bidi_cache_fetch_state, bidi_cache_search)
9170 (bidi_cache_find_level_change, bidi_cache_iterator_state)
9171 (bidi_cache_find, bidi_peek_at_next_level)
9172 (bidi_level_of_next_char, bidi_find_other_level_edge)
9173 (bidi_move_to_visually_next): Compare cache index with
9174 bidi_cache_start rather than with zero.
9175 (bidi_fetch_char): Accept new argument STRING; all callers
9176 changed. Support iteration over a string. Support strings with
9177 display properties. Support unibyte strings. Fix the type of
9178 `len' according to what STRING_CHAR_AND_LENGTH expects.
9179 (bidi_paragraph_init, bidi_resolve_explicit_1)
9180 (bidi_resolve_explicit, bidi_resolve_weak)
9181 (bidi_level_of_next_char, bidi_move_to_visually_next):
9182 Support iteration over a string.
9183 (bidi_set_sor_type, bidi_resolve_explicit_1)
9184 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9185 can now be zero (for strings); special values 0 and -1 were
9186 changed to -1 and -2, respectively.
9187 (bidi_char_at_pos): New function.
9188 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9189 Call it instead of FETCH_MULTIBYTE_CHAR.
9190 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9191 initialized to valid values.
9192 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9194 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9195 the test for valid cached positions. Fix the logic for looking up
9196 the sentinel state in the cache. GCPRO the Lisp string we are
9198 (bidi_push_it, bidi_pop_it): New functions.
9199 (bidi_initialize): Initialize the bidi cache start stack pointer.
9200 (bidi_cache_ensure_space): New function, refactored from part of
9201 bidi_cache_iterator_state. Don't assume the required size is just
9202 one BIDI_CACHE_CHUNK away.
9203 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9204 (bidi_count_bytes, bidi_char_at_pos): New functions.
9205 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9206 always valid if bidi_cache_idx is valid.
9207 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9208 is valid if it's going to be used.
9209 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9210 (bidi_cache_fetch_state, bidi_cache_search)
9211 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9212 (bidi_cache_iterator_state, bidi_cache_find)
9213 (bidi_find_other_level_edge, bidi_cache_start_stack):
9214 All variables related to cache indices are now EMACS_INT.
9216 * dispextern.h (struct bidi_string_data): New structure.
9217 (struct bidi_it): New member `string'. Make flag members be 1-bit
9218 fields, and put them last in the struct.
9219 (compute_display_string_pos, compute_display_string_end):
9221 (bidi_push_it, bidi_pop_it): Add prototypes.
9222 (struct iterator_stack_entry): New members bidi_p,
9223 paragraph_embedding, and from_disp_prop_p.
9224 (struct it): Member bidi_p is now a bit field 1 bit wide.
9225 (bidi_shelve_cache, bidi_unshelve_cache):
9228 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9229 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9230 and vector-like objects.
9232 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9233 cache around display iteration.
9235 * window.c (Fwindow_end, window_scroll_pixel_based)
9236 (displayed_window_lines, Frecenter): Save and restore the bidi
9237 cache around display iteration.
9239 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9241 * editfns.c (Fdelete_region): Clarify the use of the named
9242 parameters (bug#6788).
9244 2011-07-14 Martin Rudalics <rudalics@gmx.at>
9246 * indent.c (Fvertical_motion): Set and restore w->pointm when
9247 saving and restoring the window's buffer (Bug#9006).
9249 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9251 * editfns.c (Fstring_to_char): Clarify just what is returned
9252 (bug#6576). Text by Eli Zaretskii.
9254 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
9256 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9258 2011-07-13 Eli Zaretskii <eliz@gnu.org>
9260 * buffer.c (mmap_find): Fix a typo.
9262 2011-07-13 Johan Bockgård <bojohan@gnu.org>
9264 Fix execution of x selection hooks.
9265 * xselect.c (Qx_lost_selection_functions)
9266 (Qx_sent_selection_functions): New vars.
9267 (syms_of_xselect): DEFSYM them.
9268 (x_handle_selection_request): Pass Qx_sent_selection_functions
9269 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9270 (x_handle_selection_clear,x_clear_frame_selections):
9271 Pass Qx_lost_selection_functions rather than
9272 Vx_lost_selection_functions to Frun_hook_with_args.
9274 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9276 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
9277 The old code sometimes used this field without initializing it.
9279 * alloc.c (gc_sweep): Don't read past end of array.
9280 In theory, the old code could also have corrupted Emacs internals,
9281 though it'd be very unlikely.
9283 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9285 * character.c (Fcharacterp): Don't advertise optional ignored
9286 argument. (Bug#4026)
9288 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9290 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9293 * window.c (Fset_window_start): Doc fix (bug#4199).
9294 (Fset_window_hscroll): Ditto.
9296 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9298 Fix minor new problems caught by GCC 4.6.1.
9299 * term.c (init_tty): Remove unused local.
9300 * xsettings.c (store_monospaced_changed): Define this function only
9301 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
9304 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
9306 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9308 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9310 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9311 are the mini-buffer and the echo area (bug#3320).
9313 * term.c (init_tty): Remove support for supdup, c10 and perq
9314 terminals, which are no longer supported (bug#1482).
9316 2011-07-10 Johan Bockgård <bojohan@gnu.org>
9318 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9320 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9322 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9323 for non-popups (Bug#3642).
9325 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9327 * alloc.c (reset_malloc_hooks): Protoize.
9328 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
9329 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9330 * cm.c (losecursor): Likewise.
9331 * data.c (fmod): Likewise.
9332 * dispnew.c (swap_glyphs_in_rows): Likewise.
9333 * emacs.c (memory_warning_signal): Likewise.
9334 * floatfns.c (float_error): Likewise.
9335 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9336 (otf_open, font_otf_capability, generate_otf_features)
9337 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9339 * image.c (pbm_read_file): Likewise.
9340 * indent.c (string_display_width): Likewise.
9341 * intervals.c (check_for_interval, search_for_interval)
9342 (inc_interval_count, count_intervals, root_interval)
9343 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9344 * lread.c (defalias): Likewise.
9345 * ralloc.c (r_alloc_check): Likewise.
9346 * regex.c (set_image_of_range_1, set_image_of_range)
9347 (regex_grow_registers): Likewise.
9348 * sysdep.c (strerror): Likewise.
9349 * termcap.c (valid_filename_p, tprint, main): Likewise.
9350 * tparam.c (main): Likewise.
9351 * unexhp9k800.c (run_time_remap, save_data_space)
9352 (update_file_ptrs, read_header, write_header, calculate_checksum)
9353 (copy_file, copy_rest, display_header): Likewise.
9354 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9356 * xdisp.c (check_it): Likewise.
9357 * xfaces.c (register_color, unregister_color, unregister_colors):
9359 * xfns.c (print_fontset_result): Likewise.
9360 * xrdb.c (member, fatal, main): Likewise.
9362 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9364 Fix minor problems found by static checking (Bug#9031).
9365 * chartab.c (char_table_set_range, map_sub_char_table):
9366 Remove unused locals.
9367 (uniprop_table): Now static.
9368 * composite.c (_work_char): Remove unused static var.
9370 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
9372 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9374 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9376 * gtkutil.c (qttip_cb): Remove code without function.
9378 2011-07-09 Eli Zaretskii <eliz@gnu.org>
9380 * w32.c (pthread_sigmask): New stub.
9382 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
9384 Use pthread_sigmask, not sigprocmask (Bug#9010).
9385 sigprocmask is portable only for single-threaded applications, and
9386 Emacs can be multi-threaded when it uses GTK.
9387 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9389 * callproc.c (Fcall_process):
9390 * process.c (create_process):
9391 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9392 Use pthread_sigmask, not sigprocmask.
9394 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9396 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9397 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9400 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9402 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9403 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9404 (xg_hide_tooltip): Fix comment.
9406 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9407 in registerServicesMenuSendTypes.
9408 (validRequestorForSendType): Don't check ns_return_types.
9410 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9413 2011-07-08 Jason Rumney <jasonr@gnu.org>
9415 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9416 SH_SHOW for hidden windows (Bug#5482).
9418 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9419 frame struct members of non-existent frames (Bug#6284).
9421 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9423 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9424 variable firstTime not needed on OSX >= 10.6.
9425 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9426 >= 10.5. Use setKnobProportion, setDoubleValue.
9428 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9429 (MAC_OS_X_VERSION_10_5): Define if not defined.
9430 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9431 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9432 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9434 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
9435 cString and lossyCString on OSX >= 10.4.
9437 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
9438 sizeToFit on OSX >= 10.2.
9440 * nsimage.m (allocInitFromFile): Don't use deprecated method
9441 bestRepresentationForDevice on OSX >= 10.6.
9443 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9446 * emacs.c: Declare unexec_init_emacs_zone.
9448 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9450 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9452 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9453 on svcsMenu (Bug#8842).
9455 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9457 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9459 * nsterm.m (QUTF8_STRING): Declare.
9460 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9461 (validRequestorForSendType): Return type is (id).
9462 Change indexOfObjectIdenticalTo to indexOfObject.
9463 Check if we have local selection before returning self (Bug#8842).
9464 (writeSelectionToPasteboard): Put local selection into paste board
9465 if we have a local selection (Bug#8842).
9466 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9468 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9469 (ns_get_local_selection): Declare.
9471 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9473 * keymap.c (describe_map_tree): Don't insert a double newline at
9474 the end of the buffer (bug#1169) and return whether we inserted
9477 * callint.c (Fcall_interactively): Change "reading args" to
9478 "providing args" to try to clarify what it does (bug#1010).
9480 2011-07-07 Kenichi Handa <handa@m17n.org>
9482 * composite.c (composition_compute_stop_pos): Ignore a static
9483 composition starting before CHARPOS (Bug#8915).
9485 * xdisp.c (handle_composition_prop): Likewise.
9487 2011-07-07 Eli Zaretskii <eliz@gnu.org>
9489 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9492 2011-07-07 Kenichi Handa <handa@m17n.org>
9494 * character.h (unicode_category_t): New enum type.
9496 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9497 (Qchar_code_property_table): New variable.
9498 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9499 (UNIPROP_COMPRESSED_FORM_P): New macros.
9500 (char_table_ascii): Uncompress the compressed values.
9501 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9502 Uncompress the compressed values.
9503 (sub_char_table_ref_and_range): Likewise.
9504 (char_table_ref_and_range): Uncompress the compressed values.
9505 (sub_char_table_set): New arg is_uniprop. Callers changed.
9506 Uncompress the compressed values.
9507 (sub_char_table_set_range): Args changed. Callers changed.
9508 (char_table_set_range): Adjuted for the above change.
9509 (map_sub_char_table): Delete args default_val and parent. Add arg
9510 top. Give decoded values to a Lisp function.
9511 (map_char_table): Adjust for the above change. Give decoded
9512 values to a Lisp function. Gcpro more variables.
9513 (uniprop_table_uncompress)
9514 (uniprop_decode_value_run_length): New functions.
9515 (uniprop_decoder, uniprop_decoder_count): New variables.
9516 (uniprop_get_decoder, uniprop_encode_value_character)
9517 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9519 (uniprop_encoder, uniprop_encoder_count): New variables.
9520 (uniprop_get_encoder, uniprop_table)
9521 (Funicode_property_table_internal, Fget_unicode_property_internal)
9522 (Fput_unicode_property_internal): New functions.
9523 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9524 Sunicode_property_table_internal, Sget_unicode_property_internal,
9525 and Sput_unicode_property_internal. Defvar_lisp
9526 char-code-property-alist.
9528 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
9529 Vunicode_category_table.
9531 * font.c (font_range): Adjust for the change of
9532 Vunicode_category_table.
9534 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9536 * m/iris4d.h: Remove file, move contents ...
9537 * s/irix6-5.h: ... here.
9539 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9541 Remove unportable assumption about struct layout (Bug#8884).
9542 * alloc.c (mark_buffer):
9543 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9544 (clone_per_buffer_values): Don't assume that
9545 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9546 This isn't true in general, and it's particularly not true
9547 if Emacs is configured with --with-wide-int.
9548 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9549 New macros, used in the buffer.c change.
9551 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9553 * xsettings.c: Use both GConf and GSettings if both are available.
9554 (store_config_changed_event): Add comment.
9555 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9556 (store_tool_bar_style_changed): New functions.
9557 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
9558 (struct xsettings): Move font inside HAVE_XFT.
9559 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
9560 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
9561 Move inside HAVE_XFT.
9562 (something_changed_gsettingsCB): Rename from something_changedCB.
9563 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9565 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
9566 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
9567 (something_changed_gconfCB): Rename from something_changedCB.
9568 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9569 (parse_settings): Move check for font inside HAVE_XFT.
9570 (read_settings, apply_xft_settings): Add comment.
9571 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9572 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9573 call store_font_name_changed.
9574 (xft_settings_event): Add comment.
9575 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9576 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9577 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9578 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9579 (xsettings_initialize): Call init_gsettings last.
9580 (xsettings_get_system_font, xsettings_get_system_normal_font):
9583 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9585 Random fixes. E.g., (random) never returned negative values.
9586 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9587 subseconds part to the entropy, as that's a bit more random.
9588 Prefer signed to unsigned, since the signedness doesn't matter and
9589 in general we prefer signed. When given a limit, use a
9590 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9591 latter isn't right if USE_2_TAGS_FOR_INTS.
9592 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9593 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9595 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9597 * textprop.c (text_property_stickiness):
9598 Obey Vtext_property_default_nonsticky.
9599 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9600 * w32fns.c (syms_of_w32fns):
9601 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9603 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9605 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9606 This is more efficient than Ffile_directory_p and avoids a minor race.
9608 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9610 * buffer.c (Foverlay_put): Say what the return value is
9613 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9614 is a directory before asking whether to use the file name
9616 (barf_or_query_if_file_exists): Make the "File is a directory"
9617 error be more correct.
9619 * fns.c (Frequire): Remove the mention of the .gz files, since
9620 that's installation-specific, but keep the mention of
9621 `get-load-suffixes'.
9623 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9625 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9626 Report string overflow if the output is too long.
9628 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
9630 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9631 (syms_of_gnutls): Remove duplicate DEFSYM for
9632 Qgnutls_bootprop_verify_hostname_error, an error for
9633 Qgnutls_bootprop_verify_error (which is no longer used).
9635 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9636 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9637 Also (re)move comments that are misplaced or no longer relevant.
9639 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9641 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9643 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
9645 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9646 and background color parameters if they have been changed.
9648 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9650 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9652 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9654 * xsettings.c (SYSTEM_FONT): Define only when used.
9655 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9657 * keymap.c (access_keymap_1): Now static.
9659 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
9661 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9662 leave any prefix arg for the up event (Bug#1586).
9664 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9666 * lread.c (syms_of_lread): Mention single symbols defined by
9667 `defvar' or `defconst' (bug#7154).
9669 * fns.c (Frequire): Mention .el.gz files (bug#7314).
9670 (Frequire): Mention get-load-suffixes.
9672 2011-07-02 Martin Rudalics <rudalics@gmx.at>
9674 * window.h (window): Remove clone_number slot.
9675 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9677 (make_parent_window, make_window, saved_window)
9678 (Fset_window_configuration, save_window_save): Don't deal with
9680 * buffer.c (Qclone_number): Remove declaration.
9681 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9683 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9685 Add multiple inheritance to keymaps.
9686 * keymap.c (Fmake_composed_keymap): New function.
9687 (Fset_keymap_parent): Simplify.
9688 (fix_submap_inheritance): Remove.
9689 (access_keymap_1): New function extracted from access_keymap to handle
9690 embedded parents and handle lists of maps.
9691 (access_keymap): Use it.
9692 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9693 (Fcopy_keymap): Handle embedded parents.
9694 (Fcommand_remapping, define_as_prefix): Simplify.
9695 (Fkey_binding): Simplify.
9696 (syms_of_keymap): Move minibuffer-local-completion-map,
9697 minibuffer-local-filename-completion-map,
9698 minibuffer-local-must-match-map, and
9699 minibuffer-local-filename-must-match-map to Elisp.
9700 (syms_of_keymap): Defsubr make-composed-keymap.
9701 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9702 (parse_menu_item): Trivial simplification.
9704 2011-07-01 Glenn Morris <rgm@gnu.org>
9706 * Makefile.in (SETTINGS_LIBS): Fix typo.
9708 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9710 * coding.c (Fencode_coding_string): Record the last coding system
9711 used, as the function doc string says (bug#8738).
9713 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9715 * xsettings.c (store_monospaced_changed): Take new font as arg and
9716 check for change against current_mono_font.
9717 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9718 (emacs_settings_constructor, emacs_settings_get_property)
9719 (emacs_settings_set_property, emacs_settings_class_init)
9720 (emacs_settings_init, gsettings_obj): Remove.
9721 (something_changedCB): New function for HAVE_GSETTINGS.
9722 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9723 with value as argument.
9724 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9725 g_settings_new (Bug#8967). Do not create gsettings_obj.
9726 Remove calls to g_settings_bind. Connect something_changedCB to
9729 * xgselect.c: Add defined (HAVE_GSETTINGS).
9730 (xgselect_initialize): Ditto.
9732 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9733 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9736 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9738 * eval.c (struct backtrace): Simplify and port the data structure.
9739 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9740 signed bit field, as this assumption is not portable and it makes
9741 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9742 "char debug_on_exit : 1" as this is not portable either; instead,
9743 use the portable "unsigned int debug_on_exit : 1". Remove unused
9744 member evalargs. Remove obsolete comments about cc bombing out.
9746 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9748 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9749 Let HAVE_GSETTINGS override HAVE_GCONF.
9750 (store_monospaced_changed): New function.
9751 (EMACS_SETTINGS): A new type derived from GObject to handle
9752 GSettings notifications.
9753 (emacs_settings_constructor, emacs_settings_get_property)
9754 (emacs_settings_set_property, emacs_settings_class_init):
9756 (gsettings_client, gsettings_obj): New variables.
9757 (GSETTINGS_SCHEMA): New define.
9758 (something_changedCB): Call store_monospaced_changed.
9759 (init_gsettings): New function.
9760 (xsettings_initialize): Call init_gsettings.
9761 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9764 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9767 2011-06-29 Martin Rudalics <rudalics@gmx.at>
9769 * window.c (resize_root_window, grow_mini_window)
9770 (shrink_mini_window): Rename Qresize_root_window to
9771 Qwindow_resize_root_window and Qresize_root_window_vertically to
9772 Qwindow_resize_root_window_vertically.
9774 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9776 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9778 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
9780 * makefile.w32-in: Redesign dependencies so they reflect more
9781 clearly which files are directly included by each source file,
9782 and not through other includes.
9784 2011-06-27 Martin Rudalics <rudalics@gmx.at>
9786 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9787 (sort_overlays, overlay_strings): When an overlay's clone number
9788 matches the window's clone number process the overlay even if
9789 the overlay's window property doesn't match the current window.
9791 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9792 (Fwindow_hchild): Rename to Fwindow_left_child.
9793 (Fwindow_next): Rename to Fwindow_next_sibling.
9794 (Fwindow_prev): Rename to Fwindow_prev_sibling.
9795 (resize_window_check): Rename to window_resize_check.
9796 (resize_window_apply): Rename to window_resize_apply.
9797 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9798 (Fdelete_other_windows_internal, resize_frame_windows)
9799 (Fsplit_window_internal, Fdelete_window_internal)
9800 (grow_mini_window, shrink_mini_window)
9801 (Fresize_mini_window_internal): Fix callers accordingly.
9803 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9805 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9806 (emacs_fixed_set_min_size): Remove.
9807 (emacs_fixed_new): Take frame as argument.
9809 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9810 (_EmacsFixedPrivate): Remove minwidth/height.
9811 Add struct frame *f.
9812 (emacs_fixed_init): Initialize priv->f.
9813 (get_parent_class, emacs_fixed_set_min_size): Remove.
9814 (emacs_fixed_new): Set priv->f to argument.
9815 (emacs_fixed_get_preferred_width)
9816 (emacs_fixed_get_preferred_height): Use min_width/height from
9817 frames size_hint to set minimum and natural (Bug#8919).
9818 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9819 and use min_width/height from frames size_hint to set
9820 min_width/height (Bug#8919).
9822 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9823 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9826 2011-06-26 Eli Zaretskii <eliz@gnu.org>
9828 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9829 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9832 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
9834 * process.c (wait_reading_process_output): Bypass select if
9835 waiting for a cell while ignoring keyboard input, and input is
9836 pending. Suggested by Jan Djärv (Bug#8869).
9838 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9840 Use gnulib's dup2 module instead of rolling our own.
9841 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9843 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9845 * dispnew.c (scrolling_window): Before scrolling, turn off a
9846 mouse-highlight in the window being scrolled.
9848 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
9850 Move DEFSYM to lisp.h and use everywhere.
9852 * character.h (DEFSYM): Move declaration...
9853 * lisp.h (DEFSYM): ...here.
9859 * w32select.c: Don't include character.h.
9861 * alloc.c (syms_of_alloc):
9862 * buffer.c (syms_of_buffer):
9863 * bytecode.c (syms_of_bytecode):
9864 * callint.c (syms_of_callint):
9865 * casefiddle.c (syms_of_casefiddle):
9866 * casetab.c (init_casetab_once):
9867 * category.c (init_category_once, syms_of_category):
9868 * ccl.c (syms_of_ccl):
9869 * cmds.c (syms_of_cmds):
9870 * composite.c (syms_of_composite):
9871 * dbusbind.c (syms_of_dbusbind):
9872 * dired.c (syms_of_dired):
9873 * dispnew.c (syms_of_display):
9874 * doc.c (syms_of_doc):
9875 * editfns.c (syms_of_editfns):
9876 * emacs.c (syms_of_emacs):
9877 * eval.c (syms_of_eval):
9878 * fileio.c (syms_of_fileio):
9879 * fns.c (syms_of_fns):
9880 * frame.c (syms_of_frame):
9881 * fringe.c (syms_of_fringe):
9882 * insdel.c (syms_of_insdel):
9883 * keymap.c (syms_of_keymap):
9884 * lread.c (init_obarray, syms_of_lread):
9885 * macros.c (syms_of_macros):
9886 * msdos.c (syms_of_msdos):
9887 * print.c (syms_of_print):
9888 * process.c (syms_of_process):
9889 * search.c (syms_of_search):
9890 * sound.c (syms_of_sound):
9891 * syntax.c (init_syntax_once, syms_of_syntax):
9892 * terminal.c (syms_of_terminal):
9893 * textprop.c (syms_of_textprop):
9894 * undo.c (syms_of_undo):
9895 * w32.c (globals_of_w32):
9896 * window.c (syms_of_window):
9897 * xdisp.c (syms_of_xdisp):
9898 * xfaces.c (syms_of_xfaces):
9899 * xfns.c (syms_of_xfns):
9900 * xmenu.c (syms_of_xmenu):
9901 * xsettings.c (syms_of_xsettings):
9902 * xterm.c (syms_of_xterm): Use DEFSYM.
9904 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9906 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
9908 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9910 Integer and buffer overflow fixes (Bug#8873).
9912 * print.c (printchar, strout): Check for string overflow.
9913 (PRINTPREPARE, printchar, strout):
9914 Don't set size unless allocation succeeds.
9916 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9917 for sizes. Check for string overflow more accurately.
9918 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9920 * macros.c: Integer and buffer overflow fixes.
9921 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9922 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9923 Use ptrdiff_t, not int, for sizes.
9924 Don't increment bufsize until after realloc succeeds.
9925 Check for size-calculation overflow.
9926 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9928 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9930 * lread.c: Integer overflow fixes.
9931 (read_integer): Radix is now EMACS_INT, not int,
9932 to improve quality of diagnostics for out-of-range radices.
9933 Calculate buffer size correctly for out-of-range radices.
9934 (read1): Check for integer overflow in radices, and in
9935 read-circle numbers.
9936 (read_escape): Avoid int overflow.
9937 (Fload, openp, read_buffer_size, read1)
9938 (substitute_object_recurse, read_vector, read_list, map_obarray):
9939 Use ptrdiff_t, not int, for sizes.
9940 (read1): Use EMACS_INT, not int, for sizes.
9941 Check for size overflow.
9943 * image.c (cache_image): Check for size arithmetic overflow.
9945 * lread.c: Integer overflow issues.
9946 (saved_doc_string_size, saved_doc_string_length)
9947 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9948 Now ptrdiff_t, not int.
9949 (read1): Don't assume doc string length fits in int. Check for
9950 out-of-range doc string lengths.
9951 (read_list): Don't assume file position fits in int.
9952 (read_escape): Check for hex character overflow.
9954 2011-06-22 Leo Liu <sdl.web@gmail.com>
9956 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9957 Move to minibuffer.el.
9959 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9961 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
9962 The following patches are for when GLYPH_DEBUG && !XASSERT.
9963 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9964 * dispnew.c (flush_stdout):
9965 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9966 Mark as externally visible.
9967 * dispnew.c (check_window_matrix_pointers): Now static.
9968 * dispnew.c (window_to_frame_vpos):
9969 * xfns.c (unwind_create_frame):
9970 * xterm.c (x_check_font): Remove unused local.
9971 * scroll.c (CHECK_BOUNDS):
9972 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9973 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9974 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9975 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9976 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9978 (debug_method_add): Use va_list and vsprintf rather than relying
9979 on undefined behavior with wrong number of arguments.
9980 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9981 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9982 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9983 since we're not interested in debugging glyphs with old libraries.
9984 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9985 GCC 4.6.0's static checking.
9987 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9989 Integer overflow and signedness fixes (Bug#8873).
9990 A few related buffer overrun fixes, too.
9992 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9994 * dispextern.h (struct face.stipple):
9995 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9996 (x_bitmap_mask, x_allocate_bitmap_record)
9997 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9998 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9999 (x_create_bitmap_from_xpm_data):
10000 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
10001 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
10003 * xfaces.c (load_pixmap):
10004 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
10005 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
10006 (.bitmaps_last, struct x_output.icon_bitmap):
10007 Use ptrdiff_t, not int, for bitmap indexes.
10008 (x_allocate_bitmap_record): Check for size overflow.
10009 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
10011 Use ptrdiff_t, not int, for overlay counts.
10012 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
10013 * editfns.c (overlays_around, get_pos_property):
10014 * textprop.c (get_char_property_and_overlay):
10015 * xdisp.c (next_overlay_change, note_mouse_highlight):
10016 * xfaces.c (face_at_buffer_position):
10017 * buffer.c (OVERLAY_COUNT_MAX): New macro.
10018 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
10019 (Fnext_overlay_change, Fprevious_overlay_change)
10020 (mouse_face_overlay_overlaps, Foverlays_in):
10021 Use ptrdiff_t, not int, for sizes.
10022 (overlays_at, overlays_in): Check for size-calculation overflow.
10024 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
10026 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
10027 (x_session_initialize): Do not assume string length fits in int.
10029 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
10030 This is unlikely, but can occur if DPI is outlandish.
10032 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
10033 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
10035 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
10036 * xrdb.c (magic_file_p, search_magic_path):
10037 Omit last arg SUFFIX; it was always 0. All callers changed.
10038 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
10040 * xfont.c (xfont_match): Avoid need for strlen.
10042 * xfns.c: Don't assume strlen fits in int.
10043 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
10045 * xdisp.c (message_log_check_duplicate): Return intmax_t,
10046 not unsigned long, as we prefer signed integers. All callers changed.
10047 Detect integer overflow in repeat count.
10048 (message_dolog): Don't assume print length fits in 39 bytes.
10049 (display_mode_element): Don't assume strlen fits in int.
10051 * termcap.c: Don't assume sizes fit in int and never overflow.
10052 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
10053 (gobble_line): Check for size-calculation overflow.
10055 * minibuf.c (Fread_buffer):
10056 * lread.c (intern, intern_c_string):
10057 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
10058 Don't assume string length fits in int.
10060 * keyboard.c (parse_tool_bar_item):
10061 * gtkutil.c (style_changed_cb): Avoid need for strlen.
10063 * font.c: Don't assume string length fits in int.
10064 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
10065 Use ptrdiff_t, not int.
10066 (font_intern_prop): Don't assume string length fits in int.
10067 Don't assume integer property fits in fixnum.
10068 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
10070 * filelock.c: Fix some buffer overrun and integer overflow issues.
10071 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
10072 Reformulate so as not to need the command string.
10073 Invoke gzip -cd rather than gunzip, as it's more portable.
10074 (lock_info_type, lock_file_1, lock_file):
10075 Don't assume pid_t and time_t fit in unsigned long.
10076 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
10077 (current_lock_owner): Prefer signed type for sizes.
10078 Use memcpy, not strncpy, where memcpy is what is really wanted.
10079 Don't assume (via atoi) that time_t and pid_t fit in int.
10080 Check for time_t and/or pid_t out of range, e.g., via a network share.
10081 Don't alloca where an auto var works fine.
10083 * fileio.c: Fix some integer overflow issues.
10084 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
10085 Don't assume string length fits in int.
10086 (directory_file_name): Don't assume string length fits in long.
10087 (make_temp_name): Don't assume pid fits in int, or that its print
10088 length is less than 20.
10090 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
10092 * coding.c (make_subsidiaries): Don't assume string length fits in int.
10094 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
10096 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
10097 We prefer signed integers, even for size calculations.
10099 * emacs.c: Don't assume string length fits in 'int'.
10100 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
10101 (main): Don't invoke strlen when not needed.
10103 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
10104 (XD_DEBUG_MESSAGE): Don't waste a byte.
10106 * callproc.c (getenv_internal_1, getenv_internal)
10107 (Fgetenv_internal):
10108 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
10110 * lread.c (invalid_syntax): Omit length argument.
10111 All uses changed. This doesn't fix a bug, but it simplifies the
10112 code away from its former Hollerith-constant appearance, and it's
10113 one less 'int' to worry about when looking at integer-overflow issues.
10114 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
10116 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
10117 This didn't break anything, but it didn't help either.
10118 It's confusing to put a bogus integer in a place where the actual
10119 value does not matter.
10120 (LIST_END_P): Remove unused macro and its bogus comment.
10121 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
10123 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
10124 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
10126 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
10127 We prefer signed types, and the value cannot exceed the EMACS_INT
10128 range anyway (because otherwise the length would not be representable).
10129 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
10130 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
10131 This avoids a GCC warning when WIDE_EMACS_INT.
10133 * indent.c (sane_tab_width): New function.
10134 (current_column, scan_for_column, Findent_to, position_indentation)
10135 (compute_motion): Use it. This is just for clarity.
10136 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
10138 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
10140 * lisp.h (lint_assume): New macro.
10141 * composite.c (composition_gstring_put_cache):
10142 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
10144 * editfns.c, insdel.c:
10145 Omit unnecessary forward decls, to simplify future changes.
10147 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
10149 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
10151 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
10152 Use much-faster test for byte-length change.
10153 Don't assume string byte-length fits in 'int'.
10154 Check that character arg fits in 'int'.
10155 (mapcar1): Declare byte as byte, for clarity.
10157 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10159 * fns.c (concat): Catch string overflow earlier.
10160 Do not rely on integer wraparound.
10162 * dispextern.h (struct it.overlay_strings_charpos)
10163 (struct it.selective): Now EMACS_INT, not int.
10164 * xdisp.c (forward_to_next_line_start)
10165 (back_to_previous_visible_line_start)
10166 (reseat_at_next_visible_line_start, next_element_from_buffer):
10167 Don't arbitrarily truncate the value of 'selective' to int.
10169 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
10171 * composite.c: Don't truncate sizes to 'int'.
10172 (composition_gstring_p, composition_reseat_it)
10173 (composition_adjust_point): Use EMACS_INT, not int.
10174 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10175 not EMACS_UINT, for indexes.
10177 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10179 * buffer.c: Include <verify.h>.
10180 (struct sortvec.priority, struct sortstr.priority):
10181 Now EMACS_INT, not int.
10182 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
10183 (struct sortstr.size, record_overlay_string)
10184 (struct sortstrlist.size, struct sortlist.used):
10185 Don't truncate size to int.
10186 (record_overlay_string): Check for size-calculation overflow.
10187 (init_buffer_once): Check at compile-time, not run-time.
10189 2011-06-22 Jim Meyering <meyering@redhat.com>
10191 Don't leak an XBM-image-sized buffer
10192 * image.c (xbm_load): Free the image buffer after using it.
10194 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10197 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10198 that Sun C diagnosed.
10199 * fns.c (secure_hash): Fix pointer signedness issue.
10200 * intervals.c (static_offset_intervals): New function.
10201 (offset_intervals): Use it.
10203 2011-06-21 Leo Liu <sdl.web@gmail.com>
10206 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10209 * fns.c (secure_hash): Rename from crypto_hash_function and change
10210 the first arg to accept symbols.
10211 (Fsecure_hash): New primitive.
10212 (syms_of_fns): New symbols.
10214 2011-06-20 Deniz Dogan <deniz@dogan.se>
10216 * process.c (Fset_process_buffer): Clarify return value in
10219 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
10221 * dispnew.c (add_window_display_history): Use BVAR.
10223 * xdisp.c (debug_method_add): Use BVAR.
10224 (check_window_end, dump_glyph_matrix, dump_glyph)
10225 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10227 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10230 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10231 check till after the cache is created in init_frame_faces.
10233 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10235 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10237 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10239 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10240 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10241 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10243 Improve buffer-overflow checking (Bug#8873).
10244 * fileio.c (Finsert_file_contents):
10245 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10246 Remove the old (too-loose) buffer overflow checks.
10247 They weren't needed, since make_gap checks for buffer overflow.
10248 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10249 The old code merely checked for Emacs fixnum overflow, and relied
10250 on undefined (wraparound) behavior. The new code avoids undefined
10251 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10253 * editfns.c (Finsert_char): Don't dump core with very negative counts.
10254 Tune. Don't use wider integers than needed. Don't use alloca.
10255 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
10257 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10259 * insdel.c, lisp.h (buffer_overflow): New function.
10260 (insert_from_buffer_1, replace_range, replace_range_2):
10261 * insdel.c (make_gap_larger):
10262 * editfns.c (Finsert_char):
10263 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10265 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10267 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10269 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
10271 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10272 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10274 * fileio.c: Don't assume EMACS_INT fits in off_t.
10275 (emacs_lseek): New static function.
10276 (Finsert_file_contents, Fwrite_region): Use it.
10277 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10279 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10281 * fns.c: Don't overflow int when computing a list length.
10282 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10283 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10284 truncation on 64-bit hosts. Check for QUIT every
10285 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10286 faster and is responsive enough.
10287 (Flength): Report an error instead of overflowing an integer.
10288 (Fsafe_length): Return a float if the value is not representable
10289 as a fixnum. This shouldn't happen except in contrived situations.
10290 (Fnthcdr, Fsort): Don't assume list length fits in int.
10291 (Fcopy_sequence): Don't assume vector length fits in int.
10293 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10294 (header_size, word_size): New constants.
10295 (allocate_vectorlike): Don't check size overflow here.
10296 (allocate_vector): Check it here instead, since this is the only
10297 caller of allocate_vectorlike that could cause overflow.
10298 Check that the new vector's length is representable as a fixnum.
10300 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10301 The previous code was bogus. For example, next_almost_prime (32)
10302 returned 39, which is undesirable as it is a multiple of 3; and
10303 next_almost_prime (24) returned 25, which is a multiple of 5 so
10304 why was the code bothering to check for multiples of 7?
10306 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10308 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10310 Variadic C functions now count arguments with ptrdiff_t.
10311 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10312 Back then I didn't know that the Emacs coding style prefers signed int.
10313 Also, in the meantime I found a few more instances where arguments
10314 were being counted with int, which may truncate counts on 64-bit
10315 machines, or EMACS_INT, which may be unnecessarily wide.
10316 * lisp.h (struct Lisp_Subr.function.aMANY)
10317 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10318 Arg counts are now ptrdiff_t, not size_t.
10319 All variadic functions and their callers changed accordingly.
10320 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10321 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10322 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10323 * callint.c (Fcall_interactively): Check arg count for overflow,
10324 to avoid potential buffer overrun. Use signed char, not 'int',
10325 for 'varies' array, so that we needn't bother to check its size
10326 calculation for overflow.
10327 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10328 * eval.c (apply_lambda):
10329 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10330 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10331 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10333 * callint.c (Fcall_interactively): Don't use index var as event count.
10335 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10336 * mem-limits.h (SIZE): Remove; no longer used.
10338 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
10340 Remove unnecessary casts.
10341 * xterm.c (x_term_init):
10342 * xfns.c (x_set_border_pixel):
10343 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10344 These aren't needed now that we assume ANSI C.
10346 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10347 It's more likely to cause problems (due to unsigned overflow)
10350 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10352 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10354 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10356 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10358 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10360 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10362 GLYPH_CODE_FACE returns EMACS_INT, not int.
10363 * dispextern.h (merge_faces):
10364 * xfaces.c (merge_faces):
10365 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10366 Don't assume EMACS_INT fits in int.
10368 * character.h (CHAR_VALID_P): Remove unused parameter.
10369 * fontset.c, lisp.h, xdisp.c: All uses changed.
10371 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10373 * fns.c (concat): Minor tuning based on overflow analysis.
10374 This doesn't fix any bugs. Use int to hold character, instead
10375 of constantly refetching from Emacs object. Use XFASTINT, not
10376 XINT, for value known to be a character. Don't bother comparing
10377 a single byte to 0400, as it's always less.
10379 * floatfns.c (Fexpt):
10380 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10382 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10385 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10387 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10388 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10389 incorrectly succeed when S was a string, because 4294967386 was
10390 truncated before it was used.
10392 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10393 Otherwise, an out-of-range integer could cause undefined behavior
10396 * composite.c: Use int, not EMACS_INT, for characters.
10397 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10398 EMACS_INT, for values that are known to be in character range.
10399 This doesn't fix any bugs but is the usual style inside Emacs and
10400 may generate better code on 32-bit machines.
10402 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10403 This is for reasons similar to the recent CHAR_STRING fix.
10404 * charset.c (Fencode_char): Check that character arg is actually
10405 a character. Pass an int to ENCODE_CHAR.
10406 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10407 wider than 'int', as a compile-time check to prevent future regressions
10410 * character.c (char_string): Remove unnecessary casts.
10412 Make sure a 64-bit char is never passed to CHAR_STRING.
10413 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10414 by silently ignoring the top 32 bits, allowing some values
10415 that were far too large to be valid characters.
10416 * character.h: Include <verify.h>.
10417 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10418 arguments are no wider than unsigned, as a compile-time check
10419 to prevent future regressions in this area.
10421 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
10422 (Fsubst_char_in_region):
10424 * xdisp.c (decode_mode_spec_coding):
10425 Adjust to CHAR_STRING's new requirement.
10426 * editfns.c (Finsert_char, Fsubst_char_in_region):
10427 * fns.c (concat): Check that character args are actually
10428 characters. Without this test, these functions did the wrong
10429 thing with wildly out-of-range values on 64-bit hosts.
10431 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10432 These casts should not be needed on 32-bit hosts, either.
10433 * keyboard.c (read_char):
10434 * lread.c (Fload): Remove casts to unsigned.
10436 * lisp.h (UNSIGNED_CMP): New macro.
10437 This fixes comparison bugs on 64-bit hosts.
10438 (ASCII_CHAR_P): Use it.
10439 * casefiddle.c (casify_object):
10440 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
10441 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10442 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10443 * dispextern.h (FACE_FROM_ID):
10444 * keyboard.c (read_char): Use UNSIGNED_CMP.
10446 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10447 not to EMACS_INT, to avoid GCC warning.
10449 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10451 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10452 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10453 isn't needed on 32-bit machines.
10455 * buffer.c (Fgenerate_new_buffer_name):
10456 Use EMACS_INT for count, not int.
10457 (advance_to_char_boundary): Return EMACS_INT, not int.
10459 * data.c (Qcompiled_function): Now static.
10461 * window.c (window_body_lines): Now static.
10463 * image.c (gif_load): Rename local to avoid shadowing.
10465 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10466 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10467 * alloc.c (make_save_value): Integer argument is now of type
10468 ptrdiff_t, not int.
10469 (mark_object): Use ptrdiff_t, not int.
10470 * lisp.h (pD): New macro.
10471 * print.c (print_object): Use it.
10473 * alloc.c: Use EMACS_INT, not int, to count objects.
10474 (total_conses, total_markers, total_symbols, total_vector_size)
10475 (total_free_conses, total_free_markers, total_free_symbols)
10476 (total_free_floats, total_floats, total_free_intervals)
10477 (total_intervals, total_strings, total_free_strings):
10478 Now EMACS_INT, not int. All uses changed.
10479 (Fgarbage_collect): Compute overall total using a double, so that
10480 integer overflow is less likely to be a problem. Check for overflow
10481 when converting back to an integer.
10482 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10483 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10484 These were 'int' variables that could overflow on 64-bit hosts;
10485 they were never used, so remove them instead of repairing them.
10486 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
10487 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10488 Previously, this ceilinged at INT_MAX, but that doesn't work on
10490 (allocate_pseudovector): Don't use EMACS_INT when int would do.
10492 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
10493 (allocate_vectorlike): Check for ptrdiff_t overflow.
10494 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10495 when a (possibly-narrower) signed value would do just as well.
10496 We prefer using signed arithmetic, to avoid comparison confusion.
10498 * alloc.c: Catch some string size overflows that we were missing.
10499 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10500 for convenience in STRING_BYTES_MAX.
10501 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10502 The definition here is exact; the one in lisp.h was approximate.
10503 (allocate_string_data): Check for string overflow. This catches
10504 some instances we weren't catching before. Also, it catches
10505 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10506 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10507 and ptrdiff_t and EMACS_INT are both 64 bits.
10509 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10510 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
10511 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
10513 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10515 * alloc.c (Fmake_string): Check for out-of-range init.
10517 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10519 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10521 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10523 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10524 xg_get_default_scrollbar_width.
10526 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10527 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10528 (style_changed_cb): Call update_theme_scrollbar_width and call
10529 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10530 all frames (Bug#8505).
10531 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10532 Call gtk_window_set_resizable if HAVE_GTK3.
10533 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10534 and height if HAVE_GTK3 (Bug#8505).
10535 (scroll_bar_width_for_theme): New variable.
10536 (update_theme_scrollbar_width): New function.
10537 (xg_get_default_scrollbar_width): Move code to
10538 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10539 (xg_initialize): Call update_theme_scrollbar_width.
10541 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10543 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10545 2011-06-12 Martin Rudalics <rudalics@gmx.at>
10547 * frame.c (make_frame): Call other_buffer_safely instead of
10550 * window.c (temp_output_buffer_show): Call display_buffer with
10551 second argument Vtemp_buffer_show_specifiers and reset latter
10552 immediately after the call.
10553 (Vtemp_buffer_show_specifiers): New variable.
10554 (auto_window_vscroll_p, next_screen_context_lines)
10555 (Vscroll_preserve_screen_position): Remove leading asterisks from
10558 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
10560 Fix minor problems found by GCC 4.6.0 static checking.
10561 * buffer.c (Qclone_number): Remove for now, as it's unused.
10562 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10563 (record_buffer): Remove unused local.
10564 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10565 (set_frame_buffer_list): Remove; unused.
10566 * frame.h (other_visible_frames): Remove decl.
10567 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10568 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10569 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10571 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10572 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10573 Define only if HAVE_GPM.
10574 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10575 (update_hints_inhibit): Remove; never set. All uses removed.
10576 * widgetprv.h (emacsFrameClassRec): Remove decl.
10577 * window.c (delete_deletable_window): Now returns void, since it
10578 wasn't returning anything.
10579 (compare_window_configurations): Remove unused locals.
10580 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10581 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
10582 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10583 the same widths as pointers. This follows up on the 2011-05-06 patch.
10584 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10585 * xterm.h: Likewise.
10586 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10588 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
10590 * makefile.w32-in: Update dependencies.
10591 (LISP_H): Add lib/intprops.h.
10593 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
10595 * image.c (gif_load): Add animation frame delay to the metadata.
10596 (syms_of_image): Use DEFSYM. New symbol `delay'.
10598 2011-06-11 Martin Rudalics <rudalics@gmx.at>
10600 * window.c (delete_deletable_window): Re-add.
10601 (Fset_window_configuration): Rewrite to handle dead buffers and
10602 consequently deletable windows.
10603 (window_tree, Fwindow_tree): Remove. Supply functionality in
10605 (compare_window_configurations): Simplify code.
10607 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10609 * image.c (imagemagick_load_image): Fix type mismatch.
10610 (Fimagemagick_types): Likewise.
10612 * window.h (replace_buffer_in_windows): Declare.
10614 2011-06-11 Martin Rudalics <rudalics@gmx.at>
10616 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10617 Qclone_number. Remove external declaration of Qdelete_window.
10618 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10620 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10621 Run Qbuffer_list_update_hook if allowed.
10622 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10623 buffer list implementation.
10624 (other_buffer_safely): New function.
10625 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10626 calls to replace_buffer_in_windows and
10627 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10629 (record_buffer): Inhibit quitting and rewrite using quittable
10630 functions. Run Qbuffer_list_update_hook if allowed.
10631 (Frecord_buffer, Funrecord_buffer): New functions.
10632 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10633 Move switch-to-buffer to window.el.
10634 (bury-buffer): Move to window.el.
10635 (Vbuffer_list_update_hook): New variable.
10637 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10640 * window.h (resize_frame_windows): Move up in code.
10641 (Fwindow_frame): Remove EXFUN.
10642 (replace_buffer_in_all_windows): Remove prototype.
10643 (replace_buffer_in_windows_safely): Add prototype.
10645 * window.c: Declare Qdelete_window static again. Move down
10646 declaration of select_count.
10647 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10648 (Fother_window): Move to window.el.
10649 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10650 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10651 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10653 (replace_buffer_in_windows): Implement by calling
10654 Qreplace_buffer_in_windows.
10655 (replace_buffer_in_all_windows): Remove with some functionality
10656 moved into replace_buffer_in_windows_safely.
10657 (replace_buffer_in_windows_safely): New function.
10658 (select_window_norecord, select_frame_norecord): Move in front
10659 of run_window_configuration_change_hook. Remove now obsolete
10661 (Fset_window_buffer): Rewrite doc-string.
10662 Call Qrecord_window_buffer.
10663 (keys_of_window): Move binding for other-window to window.el.
10665 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
10667 * dispextern.h (struct image): Replace data member, whose int_val
10668 and ptr_val fields were not used by anything, with a single
10671 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10672 (gif_clear_image, gif_load, imagemagick_load_image)
10673 (gs_clear_image, gs_load): Callers changed.
10675 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10677 * buffer.h: Include <time.h>, for time_t.
10678 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10680 Fix minor problems found by static checking.
10682 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10684 Make identifiers static if they are not used in other modules.
10685 * data.c (Qcompiled_function, Qframe, Qvector):
10686 * image.c (QimageMagick, Qsvg):
10687 * minibuf.c (Qmetadata):
10688 * window.c (resize_window_check, resize_root_window): Now static.
10689 * window.h (resize_window_check, resize_root_window): Remove decls.
10691 * window.c (window_deletion_count, delete_deletable_window):
10693 (window_body_lines): Now static.
10694 (Fdelete_other_windows_internal): Mark vars as initialized.
10695 Make sure 'resize_failed' is initialized.
10696 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10697 (resize_window_apply): Remove unused local.
10698 * window.h (delete_deletable_window): Remove decl.
10700 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
10701 (imagemagick_load_image): Fix pointer signedness problem by changing
10702 last arg from unsigned char * to char *. All uses changed.
10703 Also, fix a local for similar reasons.
10704 Remove unused locals. Remove locals to avoid shadowing.
10705 (fn_rsvg_handle_free): Remove; unused.
10706 (svg_load, svg_load_image): Fix pointer signedness problem.
10707 (imagemagick_load_image): Don't use garbage pointer image_wand.
10709 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10711 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
10713 * image.c (gif_load): Fix omitted cast error introduced by
10716 2011-06-10 Martin Rudalics <rudalics@gmx.at>
10718 * window.h (resize_proportionally, orig_total_lines)
10719 (orig_top_line): Remove from window structure.
10720 (set_window_height, set_window_width, change_window_heights)
10721 (Fdelete_window): Remove prototypes.
10722 (resize_frame_windows): Remove duplicate declaration.
10724 2011-06-10 Eli Zaretskii <eliz@gnu.org>
10726 * window.h (resize_frame_windows, resize_window_check)
10727 (delete_deletable_window, resize_root_window)
10728 (resize_frame_windows): Declare prototypes.
10730 * window.c (resize_window_apply): Make definition be "static" to
10731 match the prototype.
10733 2011-06-10 Martin Rudalics <rudalics@gmx.at>
10735 * window.c: Remove declarations of Qwindow_size_fixed,
10736 window_min_size_1, window_min_size_2, window_min_size,
10737 size_window, window_fixed_size_p, enlarge_window, delete_window.
10738 Remove static from declaration of Qdelete_window, it's
10739 temporarily needed by Fbury_buffer.
10740 (replace_window): Don't assign orig_top_line and
10742 (Fdelete_window, delete_window): Remove. Window deletion is
10743 handled by window.el.
10744 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10745 Replace Fdelete_window calls with calls to Qdelete_window.
10746 (Fdelete_other_windows): Remove. Deleting other windows is
10747 handled by window.el.
10748 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10749 handled in window.el.
10750 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10751 Window minimum sizes are handled in window.el.
10752 (shrink_windows, size_window, set_window_height)
10753 (set_window_width, change_window_heights, window_height)
10754 (window_width, CURBEG, CURSIZE, enlarge_window)
10755 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10756 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10757 handled in window.el.
10758 (make_dummy_parent): Rename to make_parent_window and give it a
10759 second argument horflag.
10760 (make_window): Don't set resize_proportionally any more.
10761 (Fsplit_window): Remove. Windows are split in window.el.
10762 (save_restore_action, save_restore_orig_size)
10763 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10764 Resize mini windows in window.el.
10765 (grow_mini_window, shrink_mini_window): Implement by calling
10766 Qresize_root_window_vertically, resize_window_check and
10767 resize_window_apply.
10768 (saved_window, Fset_window_configuration, save_window_save):
10769 Do not handle orig_top_line, orig_total_lines, and
10770 resize_proportionally.
10771 (window_min_height, window_min_width): Move to window.el.
10772 (keys_of_window): Move bindings for delete-other-windows,
10773 split-window, delete-window and enlarge-window to window.el.
10775 * buffer.c: Temporarily extern Qdelete_window.
10776 (Fbury_buffer): Temporarily call Qdelete_window instead of
10777 Fdelete_window (Fbury_buffer will move to window.el soon).
10779 * frame.c (set_menu_bar_lines_1): Remove code handling
10780 orig_top_line and orig_total_lines.
10782 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10783 set_window_height but set heights directly.
10784 (change_frame_size_1): Use resize_frame_windows.
10786 * xdisp.c (init_xdisp): Don't use set_window_height but set
10789 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10790 Use resize_frame_windows instead of change_window_heights and run
10791 run_window_configuration_change_hook.
10793 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10794 instead of change_window_heights and run
10795 run_window_configuration_change_hook.
10797 2011-06-09 Martin Rudalics <rudalics@gmx.at>
10799 * window.c (replace_window): Rename second argument REPLACEMENT to
10800 NEW. New third argument SETFLAG. Rewrite.
10801 (delete_window, make_dummy_parent): Call replace_window with
10803 (window_list_1): Move down in code.
10804 (run_window_configuration_change_hook): Move set_buffer part
10805 before select_frame_norecord part in order to unwind correctly.
10806 Rename count1 to count.
10807 (recombine_windows, delete_deletable_window, resize_root_window)
10808 (Fdelete_other_windows_internal)
10809 (Frun_window_configuration_change_hook, make_parent_window)
10810 (resize_window_check, resize_window_apply, Fresize_window_apply)
10811 (resize_frame_windows, Fsplit_window_internal)
10812 (Fdelete_window_internal, Fresize_mini_window_internal):
10814 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10816 2011-06-08 Martin Rudalics <rudalics@gmx.at>
10818 * window.h (window): Add some new members to window structure -
10819 normal_lines, normal_cols, new_total, new_normal, clone_number,
10820 splits, nest, prev_buffers, next_buffers.
10821 (WINDOW_TOTAL_SIZE): Move here from window.c.
10822 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
10824 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10826 (make_dummy_parent): Set new members of windows structure.
10827 (make_window): Move down in code. Handle new members of window
10829 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10830 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10831 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10832 (Fset_window_prev_buffers, Fwindow_next_buffers)
10833 (Fset_window_next_buffers, Fset_window_clone_number):
10835 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10836 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10838 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10839 Argument WINDOW can be now internal window too.
10840 (Fwindow_use_time): Move up in code.
10841 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10842 Rewrite doc-string.
10843 (Fset_window_configuration, saved_window)
10844 (Fcurrent_window_configuration, save_window_save): Handle new
10845 members of window structure.
10846 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10847 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10848 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10849 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10850 Qget_mru_window, Qresize_root_window,
10851 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10852 Qauto_buffer_name; staticpro them.
10854 2011-06-07 Martin Rudalics <rudalics@gmx.at>
10856 * window.c (Fwindow_total_size, Fwindow_left_column)
10857 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10858 (Fwindow_list_1): New functions.
10859 (window_box_text_cols): Replace with window_body_cols.
10860 (Fwindow_width, Fscroll_left, Fscroll_right):
10861 Use window_body_cols instead of window_box_text_cols.
10862 (delete_window, Fset_window_configuration):
10863 Call delete_all_subwindows with window as argument.
10864 (delete_all_subwindows): Take a window as argument and not a
10865 structure. Rewrite.
10866 (window_loop): Remove handling of GET_LRU_WINDOW and
10867 GET_LARGEST_WINDOW.
10868 (Fget_lru_window, Fget_largest_window): Move to window.el.
10870 * window.h: Extern window_body_cols instead of
10871 window_box_text_cols. delete_all_subwindows now takes a
10872 Lisp_Object as argument.
10874 * indent.c (compute_motion, Fcompute_motion):
10875 Use window_body_cols instead of window_box_text_cols.
10877 * frame.c (delete_frame): Call delete_all_subwindows with root
10878 window as argument.
10880 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10882 * fns.c (Fputhash): Document return value.
10884 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
10886 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10888 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10890 Cons<->int and similar integer overflow fixes (Bug#8794).
10892 Check for overflow when converting integer to cons and back.
10893 * charset.c (Fdefine_charset_internal, Fdecode_char):
10894 Use cons_to_unsigned to catch overflow.
10895 (Fencode_char): Use INTEGER_TO_CONS.
10896 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10897 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10898 * data.c (long_to_cons, cons_to_long): Remove.
10899 (cons_to_unsigned, cons_to_signed): New functions.
10900 These signal an error for invalid or out-of-range values.
10901 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10902 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10903 * font.c (Ffont_variation_glyphs):
10904 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10905 * lisp.h: Include <intprops.h>.
10906 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10907 (cons_to_signed, cons_to_unsigned): New decls.
10908 (long_to_cons, cons_to_long): Remove decls.
10909 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10910 (Fprimitive_undo): Use CONS_TO_INTEGER.
10911 * xfns.c (Fx_window_property): Likewise.
10912 * xselect.c: Include <limits.h>.
10913 (x_own_selection, selection_data_to_lisp_data):
10914 Use INTEGER_TO_CONS.
10915 (x_handle_selection_request, x_handle_selection_clear)
10916 (x_get_foreign_selection, Fx_disown_selection_internal)
10917 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10918 (lisp_data_to_selection_data): Use cons_to_unsigned.
10919 (x_fill_property_data): Use cons_to_signed.
10920 Report values out of range.
10922 Check for buffer and string overflow more precisely.
10923 * buffer.h (BUF_BYTES_MAX): New macro.
10924 * lisp.h (STRING_BYTES_MAX): New macro.
10925 * alloc.c (Fmake_string):
10926 * character.c (string_escape_byte8):
10927 * coding.c (coding_alloc_by_realloc):
10928 * doprnt.c (doprnt):
10929 * editfns.c (Fformat):
10931 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10932 since they may not be the same number.
10933 * editfns.c (Finsert_char):
10934 * fileio.c (Finsert_file_contents):
10935 Likewise for BUF_BYTES_MAX.
10937 * image.c: Use ptrdiff_t, not int, for sizes.
10938 (slurp_file): Switch from int to ptrdiff_t.
10940 (slurp_file): Check that file size fits in both size_t (for
10941 malloc) and ptrdiff_t (for sanity and safety).
10943 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10944 if b->modtime has its maximal value.
10946 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10948 Don't assume time_t can fit into int.
10949 * buffer.h (struct buffer.modtime): Now time_t, not int.
10950 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10951 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10953 Minor fixes for signed vs unsigned integers.
10954 * character.h (MAYBE_UNIFY_CHAR):
10955 * charset.c (maybe_unify_char):
10956 * keyboard.c (read_char, reorder_modifiers):
10957 XINT -> XFASTINT, since the integer must be nonnegative.
10958 * ftfont.c (ftfont_spec_pattern):
10959 * keymap.c (access_keymap, silly_event_symbol_error):
10960 XUINT -> XFASTINT, since the integer must be nonnegative.
10961 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10962 since it makes no difference and we prefer signed.
10963 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10964 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10967 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10969 * window.h (Fwindow_frame): Declare.
10971 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10973 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10974 (SPARE_MEMORY): Always define.
10975 (LARGE_REQUEST): Remove.
10976 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10978 2011-06-06 Martin Rudalics <rudalics@gmx.at>
10980 * lisp.h: Move EXFUNS for Fframe_root_window,
10981 Fframe_first_window and Fset_frame_selected_window to window.h.
10983 * window.h: Move EXFUNS for Fframe_root_window,
10984 Fframe_first_window and Fset_frame_selected_window here from
10987 * frame.c (Fwindow_frame, Fframe_first_window)
10988 (Fframe_root_window, Fframe_selected_window)
10989 (Fset_frame_selected_window): Move to window.c.
10990 (Factive_minibuffer_window): Move to minibuf.c.
10991 (Fother_visible_frames_p): New function.
10993 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10995 * window.c (decode_window, decode_any_window): Move up in code.
10996 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10997 (inhibit_frame_unsplittable): Remove unused variable.
10998 (Fwindow_buffer): Move up and rewrite doc-string.
10999 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
11000 (Fwindow_prev): New functions.
11001 (Fwindow_frame): Move here from frame.c. Accept any window as
11003 (Fframe_root_window, Fframe_first_window)
11004 (Fframe_selected_window): Move here from frame.c. Accept frame
11005 or arbitrary window as argument. Update doc-strings.
11006 (Fminibuffer_window): Move up in code.
11007 (Fwindow_minibuffer_p): Move up in code and simplify.
11008 (Fset_frame_selected_window): Move here from frame.c.
11010 (Fselected_window, select_window, Fselect_window): Move up in
11011 code. Minor doc-string fixes.
11013 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11015 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
11016 Do not assume that spare memory exists; that assumption is valid
11017 only if SYSTEM_MALLOC.
11018 (LARGE_REQUEST): New macro, so that the issue of large requests
11019 is separated from the issue of spare memory.
11021 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
11023 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
11026 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
11028 * xfns.c (x_set_scroll_bar_default_width): Move declarations
11031 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
11033 * gtkutil.c (xg_get_default_scrollbar_width): New function.
11035 * gtkutil.h: Declare xg_get_default_scrollbar_width.
11037 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
11038 min width by calling x_set_scroll_bar_default_width (Bug#8505).
11040 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
11042 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
11044 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
11046 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
11047 (x_clipboard_manager_save): Add return value.
11048 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
11049 New error handlers.
11050 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
11051 Obey Vx_select_enable_clipboard_manager. Catch errors in
11052 x_clipboard_manager_save (Bug#8779).
11053 (Vx_select_enable_clipboard_manager): New variable.
11054 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
11056 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
11058 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
11060 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11062 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
11063 in the current matrix if keep_current_p is non-zero.
11065 2011-06-04 Eli Zaretskii <eliz@gnu.org>
11067 * bidi.c (bidi_level_of_next_char): Fix last change.
11069 2011-06-03 Eli Zaretskii <eliz@gnu.org>
11071 Support bidi reordering of text covered by display properties.
11073 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
11074 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
11075 (bidi_cache_search, bidi_cache_iterator_state)
11076 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
11077 (bidi_level_of_next_char, bidi_move_to_visually_next):
11078 Support character positions inside a run of characters covered by a
11080 (bidi_paragraph_init, bidi_resolve_explicit_1)
11081 (bidi_level_of_next_char): Call bidi_fetch_char and
11082 bidi_fetch_char_advance instead of FETCH_CHAR and
11083 FETCH_CHAR_ADVANCE.
11084 (bidi_init_it): Initialize new members.
11085 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
11087 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
11088 instead of using explicit *_CHAR codes.
11089 (bidi_resolve_explicit, bidi_resolve_weak):
11090 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
11091 bidirectional text is supported only in multibyte buffers.
11092 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
11093 it to initialize the frame_window_p member of struct bidi_it.
11094 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
11095 (bidi_resolve_explicit, bidi_resolve_weak)
11096 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
11097 bidi_it->nchars is non-positive.
11098 (bidi_level_of_next_char): Don't try to lookup the cache for the
11099 next/previous character if nothing is cached there yet, or if we
11100 were just reseat()'ed to a new position.
11102 * xdisp.c (set_cursor_from_row): Set start and stop points
11103 according to the row's direction when priming the loop that looks
11104 for the glyph on which to display cursor.
11105 (single_display_spec_intangible_p): Function deleted.
11106 (display_prop_intangible_p): Reimplement to call
11107 handle_display_spec instead of single_display_spec_intangible_p.
11108 Accept 3 additional arguments needed by handle_display_spec.
11109 This fixes incorrect cursor motion across display property with complex
11110 values: lists, `(when COND...)' forms, etc.
11111 (single_display_spec_string_p): Support property values that are
11112 lists with the argument STRING its top-level element.
11113 (display_prop_string_p): Fix the condition for processing a
11114 property that is a list to be consistent with handle_display_spec.
11115 (handle_display_spec): New function, refactored from the
11116 last portion of handle_display_prop.
11117 (compute_display_string_pos): Accept additional argument
11118 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
11119 value of a `display' property is a "replacing spec".
11120 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
11121 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
11122 the display property, but just return a value indicating whether
11123 the display property will replace the characters it covers.
11124 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
11125 frame_window_p members of struct bidi_it.
11126 (compute_display_string_pos, compute_display_string_end):
11128 (push_it): Accept second argument POSITION, where pop_it should
11129 jump to continue iteration.
11130 (reseat_1): Initialize bidi_it.disp_pos.
11132 * keyboard.c (adjust_point_for_property): Adjust the call to
11133 display_prop_intangible_p to its new signature.
11135 * dispextern.h (struct bidi_it): New member frame_window_p.
11136 (bidi_init_it): Update prototypes.
11137 (display_prop_intangible_p): Update prototype.
11138 (compute_display_string_pos, compute_display_string_end):
11139 Declare prototypes.
11140 (struct bidi_it): New members nchars and disp_pos. ch_len is now
11143 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
11145 Malloc failure behavior now depends on size of allocation.
11146 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
11147 * lisp.h: Change signatures accordingly.
11148 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
11149 All callers changed. (Bug#8762)
11151 * gnutls.c: Use Emacs's memory allocators.
11152 Without this change, the gnutls library would invoke malloc etc.
11153 directly, which causes problems on non-SYNC_INPUT hosts, and which
11154 runs afoul of improving memory_full behavior. (Bug#8761)
11155 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
11156 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
11157 xfree instead of the default malloc, realloc, free.
11158 (Fgnutls_boot): No need to check for memory allocation failure,
11159 since xmalloc does that for us.
11161 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
11162 * category.c (hash_get_category_set):
11163 * ccl.c (ccl_driver):
11164 * charset.c (Fdefine_charset_internal):
11165 * charset.h (struct charset.hash_index):
11166 * composite.c (get_composition_id, gstring_lookup_cache)
11167 (composition_gstring_put_cache):
11168 * composite.h (struct composition.hash_index):
11169 * dispextern.h (struct image.hash):
11170 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
11171 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
11172 (hashfn_equal, hashfn_user_defined, make_hash_table)
11173 (maybe_resize_hash_table, hash_lookup, hash_put)
11174 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11175 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11176 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11177 * image.c (make_image, search_image_cache, lookup_image)
11178 (xpm_put_color_table_h):
11179 * lisp.h (struct Lisp_Hash_Table):
11180 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
11181 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
11182 for hashes and hash indexes, instead of 'unsigned' and 'int'.
11183 * alloc.c (allocate_vectorlike):
11184 Check for overflow in vector size calculations.
11185 * ccl.c (ccl_driver):
11186 Check for overflow when converting EMACS_INT to int.
11187 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11188 need to be updated by these changes.
11189 * fns.c (make_hash_table, maybe_resize_hash_table):
11190 Check for integer overflow with large hash tables.
11191 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11192 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11193 (SXHASH_REDUCE): New macro.
11194 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11195 Use it instead of discarding useful hash info with large hash values.
11196 (sxhash_float): New function.
11197 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11198 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
11199 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11200 Rewrite to use FIXNUM_BITS, as this simplifies things.
11201 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11202 Adjust signatures to match updated version of code.
11203 (consing_since_gc): Now EMACS_INT, since a single hash table can
11204 use more than INT_MAX bytes.
11206 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11208 Make it possible to build with GCC-4.6+ -O2 -flto.
11210 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11212 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11214 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11215 Call minibuffer-inactive-mode.
11217 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
11219 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11220 Update dependencies.
11222 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11224 * data.c (init_data): Remove code for UTS, this system is not
11227 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11229 Don't force ./temacs to start in terminal mode.
11231 * frame.c (make_initial_frame): Initialize faces in all cases, not
11232 only when CANNOT_DUMP is defined.
11233 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11235 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11237 * dispnew.c (add_window_display_history): Use const for the string
11238 pointer. Remove declaration, not needed.
11240 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11242 Use 'inline', not 'INLINE'.
11243 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
11244 * alloc.c, fontset.c (INLINE): Remove.
11245 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11246 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11247 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11248 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11249 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11251 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11253 Make it possible to run ./temacs.
11255 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11256 syms_of_callproc does the same thing. Remove test for
11257 "initialized", do it in the caller.
11258 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11260 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11262 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11263 (read_minibuf): Use get_minibuffer.
11264 (syms_of_minibuf): Use DEFSYM.
11265 (Qmetadata): New var.
11266 * data.c (Qbuffer): Don't make it static.
11267 (syms_of_data): Use DEFSYM.
11269 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11271 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11272 (CCL_CODE_MIN): New macro.
11274 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11276 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11278 * eval.c (Qdebug): Now static.
11279 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11280 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11281 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11283 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
11285 * image.c: Various fixes to ImageMagick code comments.
11286 (Fimagemagick_types): Doc fix.
11288 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11290 Minor fixes prompted by GCC 4.6.0 warnings.
11292 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11294 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11295 (x_clipboard_manager_save_all): Move extern decl to ...
11296 * xterm.h: ... here, so that it can be checked for consistency.
11298 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
11300 * xselect.c (x_clipboard_manager_save_frame)
11301 (x_clipboard_manager_save_all): New functions.
11302 (Fx_clipboard_manager_save): Lisp function deleted.
11304 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11305 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11307 * xterm.h: Update prototype.
11309 2011-05-28 William Xu <william.xwl@gmail.com>
11311 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11312 exiting (Bug#8239).
11314 2011-05-28 Jim Meyering <meyering@redhat.com>
11316 Avoid a sign-extension bug in crypto_hash_function.
11317 * fns.c (to_uchar): Define.
11318 (crypto_hash_function): Use it to convert some newly-signed
11319 variables to unsigned, to avoid sign-extension bugs. For example,
11320 without this change, (md5 "truc") would evaluate to
11321 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11322 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
11323 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
11325 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11327 Integer overflow fixes.
11329 * dbusbind.c: Serial number integer overflow fixes.
11330 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
11331 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11332 to hold a serial number that is too large for a fixnum.
11333 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11334 Check for serial numbers out of range. Decode any serial number
11335 that was so large that it became a float. (Bug#8722)
11337 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11338 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11339 Use XFASTINT rather than XUINT when numbers are nonnegative.
11340 (xd_append_arg, Fdbus_method_return_internal):
11341 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11342 arguments, check that Lisp number is nonnegative, rather than
11343 silently wrapping negative numbers around. (Bug#8722)
11344 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
11347 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11349 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11351 ccl: Add integer overflow checks.
11352 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11353 (IN_INT_RANGE): New macros.
11354 (ccl_driver): Use them to check for integer overflow when
11355 decoding a CCL program. Many of the new checks are whether XINT (x)
11356 fits in int; it doesn't always, on 64-bit hosts. The new version
11357 doesn't catch all possible integer overflows, but it's an
11358 improvement. (Bug#8719)
11360 * alloc.c (make_event_array): Use XINT, not XUINT.
11361 There's no need for unsigned here.
11363 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11364 This follows up to the 2011-05-06 change that substituted uintptr_t
11365 for EMACS_INT. This case wasn't caught back then.
11367 Rework Fformat to avoid integer overflow issues.
11368 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11369 now (part of C89). Include <verify.h>.
11370 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11371 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11372 (Fformat): Avoid the prepass trying to compute sizes; it was only
11373 approximate and thus did not catch overflow reliably. Instead, walk
11374 through the format just once, formatting and computing sizes as we go,
11375 checking for integer overflow at every step, and allocating a larger
11376 buffer as needed. Keep track separately whether the format is
11377 multibyte. Keep only the most-recently calculated precision, rather
11378 than them all. Record whether each argument has been converted to
11379 string. Use EMACS_INT, not int, for byte and char and arg counts.
11380 Support field widths and precisions larger than INT_MAX. Avoid
11381 sprintf's undefined behavior with conversion specifications such as %#d
11382 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11383 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11384 formatting out-of-range floating point numbers with int
11385 formats. (Bug#8668)
11387 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11389 * data.c: Avoid integer truncation in expressions involving floats.
11390 * data.c: Include <intprops.h>.
11391 (arith_driver): When there's an integer overflow in an expression
11392 involving floating point, convert the integers to floating point
11393 so that the resulting value does not suffer from catastrophic
11394 integer truncation. For example, on a 64-bit host (* 4
11395 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11396 Do not rely on undefined behavior after integer overflow.
11398 merge count_size_as_multibyte, parse_str_to_multibyte
11399 * character.c, character.h (count_size_as_multibyte):
11400 Rename from parse_str_to_multibyte; all uses changed.
11401 Check for integer overflow.
11402 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11403 since it's now a duplicate of the other. This is more of
11404 a character than a buffer op, so better that it's in character.c.
11405 * fns.c, print.c: Adjust to above changes.
11407 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11409 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11411 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11413 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11414 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11415 (x_clipboard_manager_save): Now static.
11416 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11418 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11419 (crypto_hash_function): Now static.
11420 Fix pointer signedness problems. Avoid unnecessary initializations.
11422 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
11424 * termhooks.h (Vselection_alist): Make it terminal-local.
11426 * terminal.c (create_terminal): Initialize it.
11428 * xselect.c: Support for clipboard managers.
11429 (Vselection_alist): Move to termhooks.h as terminal-local var.
11430 (LOCAL_SELECTION): New macro.
11431 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11432 (symbol_to_x_atom): Remove gratuitous arg.
11433 (x_handle_selection_request, lisp_data_to_selection_data)
11434 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
11435 (x_own_selection, x_get_local_selection, x_convert_selection):
11436 New arg, specifying work frame. Use terminal-local Vselection_alist.
11437 (some_frame_on_display): Delete unused function.
11438 (Fx_own_selection_internal, Fx_get_selection_internal)
11439 (Fx_disown_selection_internal, Fx_selection_owner_p)
11440 (Fx_selection_exists_p): New optional frame arg.
11441 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11442 (x_handle_selection_clear): Don't treat other terminals with the
11443 same keyboard specially. Use the terminal-local Vselection_alist.
11444 (x_clear_frame_selections): Use Frun_hook_with_args.
11446 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11448 * xterm.h: Add support for those atoms.
11450 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
11452 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11453 (converted_selections, conversion_fail_tag): New global variables.
11454 (x_selection_request_lisp_error): Free the above.
11455 (x_get_local_selection): Remove unnecessary code.
11456 (x_reply_selection_request): Args changed; handle arbitrary array
11457 of converted selections stored in converted_selections.
11458 Separate the XChangeProperty and SelectionNotify steps.
11459 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11460 (x_convert_selection): New function.
11461 (x_handle_selection_event): Simplify.
11462 (x_get_foreign_selection): Don't ignore incoming requests while
11463 waiting for an answer; this will fail when we implement
11464 SAVE_TARGETS, and seems unnecessary anyway.
11465 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11466 (Vx_sent_selection_functions): Doc fix.
11468 2011-05-26 Leo Liu <sdl.web@gmail.com>
11470 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11472 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11474 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11476 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11477 for fringe update if it has periodic bitmap.
11478 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
11479 and fringe_bitmap_periodic_p.
11481 * fringe.c (get_fringe_bitmap_data): New function.
11482 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11483 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11484 row. Mark glyph row for fringe update if periodicity changed.
11486 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11487 for fringe update unless it has periodic bitmap.
11489 2011-05-25 Kenichi Handa <handa@m17n.org>
11491 * xdisp.c (get_next_display_element): Set correct it->face_id for
11492 a static composition.
11494 2011-05-24 Leo Liu <sdl.web@gmail.com>
11497 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11499 * fns.c (crypto_hash_function, Fsha1): New function.
11500 (Fmd5): Use crypto_hash_function.
11501 (syms_of_fns): Add Ssha1.
11503 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11505 * gnutls.c: Remove unused macros.
11506 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11507 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11508 Remove macros that are defined and never used.
11509 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11511 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
11513 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11514 (Fx_get_selection_internal): Minor cleanup.
11515 (Fx_own_selection_internal): Rename arguments for consistency with
11518 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11520 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11522 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
11524 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11526 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11528 * dispnew.c (scrolling_window): Don't exclude the case that the
11529 last enabled row in the desired matrix touches the bottom boundary.
11531 2011-05-21 Glenn Morris <rgm@gnu.org>
11533 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
11534 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11535 and add some more files.
11537 2011-05-20 Eli Zaretskii <eliz@gnu.org>
11539 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11540 report_file_error introduced by the change from 2011-05-07.
11542 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11544 * systime.h (Time): Define only if emacs is defined.
11545 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11546 where the include path doesn't have X11/X.h by default. See
11547 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11549 2011-05-20 Kenichi Handa <handa@m17n.org>
11551 * composite.c (find_automatic_composition): Fix previous change.
11553 2011-05-20 Glenn Morris <rgm@gnu.org>
11555 * lisp.mk: New file, split from Makefile.in.
11556 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11557 (shortlisp): Remove.
11558 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11560 2011-05-19 Glenn Morris <rgm@gnu.org>
11562 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11563 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11564 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11565 (lisp): Set the order to that of loadup.el.
11566 (shortlisp): Make it a copy of $lisp.
11567 (SOME_MACHINE_LISP): Remove.
11568 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11569 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11571 2011-05-18 Kenichi Handa <handa@m17n.org>
11573 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11574 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11575 (find_automatic_composition): Mostly rewrite for efficiency.
11577 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
11579 * makefile.w32-in: Update dependencies.
11581 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11583 * menu.c: Include limits.h (fixes the MS-Windows build broken by
11584 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
11586 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
11588 Fix some integer overflow issues, such as string length overflow.
11590 * insdel.c (count_size_as_multibyte): Check for string overflow.
11592 * character.c (lisp_string_width): Check for string overflow.
11593 Use EMACS_INT, not int, for string indexes and lengths; in
11594 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11595 the resulting string length overflows an EMACS_INT; instead,
11596 report a string overflow if no precision given. When checking for
11597 precision exhaustion, use a check that cannot possibly have
11598 integer overflow. (Bug#8675)
11599 * character.h (lisp_string_width): Adjust to new signature.
11601 * alloc.c (string_overflow): New function.
11602 (Fmake_string): Use it. This doesn't change behavior, but saves
11603 a few bytes and will simplify future changes.
11604 * character.c (string_escape_byte8): Likewise.
11605 * lisp.h (string_overflow): New decl.
11607 Fixups, following up to the user-interface timestamp change.
11608 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11609 for UI timestamps, instead of unsigned long.
11610 * msdos.c (mouse_get_pos): Likewise.
11611 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
11612 * w32gui.h (Time): Define by including "systime.h" rather than by
11613 declaring it ourselves. (Bug#8664)
11615 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11616 * image.c (clear_image_cache): Likewise.
11618 * term.c (term_mouse_position): Don't assume time_t wraparound.
11620 Be more systematic about user-interface timestamps.
11621 Before, the code sometimes used 'Time', sometimes 'unsigned long',
11622 and sometimes 'EMACS_UINT', to represent these timestamps.
11623 This change causes it to use 'Time' uniformly, as that's what X uses.
11624 This makes the code easier to follow, and makes it easier to catch
11625 integer overflow bugs such as Bug#8664.
11626 * frame.c (Fmouse_position, Fmouse_pixel_position):
11627 Use Time, not unsigned long, for user-interface timestamps.
11628 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11629 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11630 * keyboard.h (last_event_timestamp): Likewise.
11631 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11632 * menu.h (xmenu_show): Likewise.
11633 * term.c (term_mouse_position): Likewise.
11634 * termhooks.h (struct input_event.timestamp): Likewise.
11635 (struct terminal.mouse_position_hook): Likewise.
11636 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11637 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11638 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11639 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11640 what it was before.
11641 * menu.h, termhooks.h: Include "systime.h", for Time.
11643 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11644 Don't assume that the difference between two unsigned long values
11645 can fit into an integer. At this point, we know button_down_time
11646 <= event->timestamp, so the difference must be nonnegative, so
11647 there's no need to cast the result if double-click-time is
11648 nonnegative, as it should be; check that it's nonnegative, just in
11649 case. This bug is triggered when events are more than 2**31 ms
11650 apart (about 25 days). (Bug#8664)
11652 * xselect.c (last_event_timestamp): Remove duplicate decl.
11653 (x_own_selection): Remove needless cast to unsigned long.
11655 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11656 that always fit in int. Use a sentinel instead of a counter, to
11657 avoid a temp and to allay GCC's concerns about possible int overflow.
11658 * frame.h (struct frame): Use int for menu_bar_items_used
11659 instead of EMACS_INT, since it always fits in int.
11661 * menu.c (grow_menu_items): Check for int overflow.
11663 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11665 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11666 Before, the code was not consistent. These values cannot exceed
11667 2**31 - 1 so there's no need to make them unsigned.
11668 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11669 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11670 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11672 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11674 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11675 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11676 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11677 presumably because the widths might not match.
11679 * window.c (size_window): Avoid needless test at loop start.
11681 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11683 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11685 2011-05-12 Drew Adams <drew.adams@oracle.com>
11687 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11689 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11691 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11692 `width' to `bar_area_x' and `bar_area_width', respectively.
11693 (x_scroll_run): Take account of fringe background extension.
11695 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11696 Rename local vars `left' and `width' to `bar_area_x' and
11697 `bar_area_width', respectively.
11698 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11699 background extension.
11701 2011-05-10 Jim Meyering <meyering@redhat.com>
11703 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11705 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
11707 * image.c (Finit_image_library): Return t for built-in image types,
11708 like pbm and xbm. (Bug#8640)
11710 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11712 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11714 2011-05-07 Eli Zaretskii <eliz@gnu.org>
11716 * w32console.c (Fset_screen_color): Doc fix.
11717 (Fget_screen_color): New function.
11718 (syms_of_ntterm): Defsubr it.
11720 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11721 unlink the temporary file if Fcall_process didn't create it in the
11723 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11724 child process will be redirected to a file specified with `:file'.
11725 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11726 cue to call_process_cleanup not to close that handle.
11728 2011-05-07 Ben Key <bkey76@gmail.com>
11730 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11731 one of two shell specific rules, either bootstrap-temacs-CMD or
11732 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11733 to the previous implementation of the bootstrap-temacs rule.
11734 The bootstrap-temacs-CMD rule is similar to the previous
11735 implementation of the bootstrap-temacs rule except that it
11736 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11739 These changes, along with some changes to nt/configure.bat,
11740 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11741 earlier fix to add support for --cflags and --ldflags options
11742 that include quotes so that it works whether make uses cmd or
11745 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
11747 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11748 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11750 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11751 a string. Handle both cases.
11752 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11753 (Fdbus_register_method): Use Qinvalid_function.
11755 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
11757 * makefile.w32-in: Update dependencies.
11758 (LISP_H): Add inttypes.h and stdin.h.
11759 (PROCESS_H): Add unistd.h.
11761 2011-05-06 Eli Zaretskii <eliz@gnu.org>
11763 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11764 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11766 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
11768 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11770 * term.c (vfatal): Remove stray call to va_end.
11771 It's not needed and the C Standard doesn't allow it here anyway.
11773 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11774 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11776 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11779 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11781 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11783 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11785 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11787 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11789 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11790 * charset.c (Fdefine_charset_internal): Don't initialize
11791 charset.code_space[15]. The value was garbage, on hosts with
11792 32-bit int (Bug#8600).
11794 * lread.c (read_integer): Be more consistent with string-to-number.
11795 Use string_to_number to do the actual conversion; this avoids
11796 rounding errors and fixes some other screwups. Without this fix,
11797 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11798 (digit_to_number): Move earlier, for benefit of read_integer.
11799 Return -1 if the digit is out of range for the base, -2 if it is
11800 not a digit in any supported base. (Bug#8602)
11802 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11804 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11805 to match comment at start of function. This also removes a
11806 GCC warning about overflow in a 32+64-bit port.
11808 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11810 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11811 Reported by Stefan Monnier in
11812 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
11813 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11814 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
11816 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11817 (EMACS_UINTPTR): Likewise, with uintptr_t.
11819 * lisp.h: Prefer 64-bit EMACS_INT if available.
11820 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11821 on 32-bit hosts that have 64-bit int, so that they can access
11823 However, temporarily disable this change unless the temporary
11824 symbol WIDE_EMACS_INT is defined.
11826 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11828 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11829 This removes an assumption that EMACS_INT and long are the same
11830 width as pointers. The assumption is true for Emacs porting targets
11831 now, but we want to make other targets possible.
11832 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11833 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11834 In the rest of the code, change types of integers that hold casted
11835 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11836 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11837 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11838 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11839 No need to cast type when ORing.
11840 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11841 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11842 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11843 assume EMACS_INT is the same width as char *.
11844 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11845 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11846 Remove no-longer-needed casts.
11847 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11848 (xg_tool_bar_help_callback, xg_make_tool_item):
11849 Use EMACS_INTPTR to hold an integer
11850 that will be cast to void *; this can avoid a GCC warning
11851 if EMACS_INT is not the same width as void *.
11852 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11853 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11854 (current_message_1, set_message_1):
11855 Use a local to convert to proper width without a cast.
11856 * xmenu.c (dialog_selection_callback): Likewise.
11858 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11859 Also, don't assume VALBITS / RAND_BITS is less than 5,
11860 and don't rely on undefined behavior when shifting a 1 left into
11862 * lisp.h (get_random): Change signature to match.
11864 * lread.c (hash_string): Use size_t, not int, for hash computation.
11865 Normally we prefer signed values; but hashing is special, because
11866 it's better to use unsigned division on hash table sizes so that
11867 the remainder is nonnegative. Also, size_t is the natural width
11868 for hashing into memory. The previous code used 'int', which doesn't
11869 retain enough info to hash well into very large tables.
11870 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11872 * dbusbind.c: Don't possibly lose pointer info when converting.
11873 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11874 Use XPNTR rather than XHASH, so that the high-order bits of
11875 the pointer aren't lost when converting through void *.
11877 * eval.c (Fautoload): Don't double-shift a pointer.
11879 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11881 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
11883 * gnutls.c (DEF_GNUTLS_FN):
11884 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11886 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11888 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11891 2011-05-05 Eli Zaretskii <eliz@gnu.org>
11893 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11894 New version that can reserve upto 2GB of heap space.
11896 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
11898 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11900 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11902 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11903 `gnutls_certificate_set_x509_key_file'.
11905 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
11907 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11908 Update dependencies.
11910 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11912 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11913 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11914 Remove unused parameter `fildes'.
11915 * process.c (read_process_output, send_process): Don't pass it.
11917 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11919 Fix previous change: the library cache is defined in w32.c.
11920 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11921 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11923 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11925 Implement dynamic loading of GnuTLS on Windows.
11927 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11928 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11929 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11932 * gnutls.c (Qgnutls_dll): Define.
11933 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11934 (gnutls_*): Declare function pointers.
11935 (init_gnutls_functions): New function to initialize function pointers.
11936 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11937 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11938 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11939 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11940 (emacs_gnutls_write, emacs_gnutls_read)
11941 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11942 (Fgnutls_available_p): New function.
11943 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11944 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11945 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11947 * image.c: Include w32.h.
11948 (Vimage_type_cache): Delete.
11949 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11950 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11951 (w32_delayed_load): Move to w32.c.
11953 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11955 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11956 (w32_delayed_load): Move from image.c. When loading a library, record
11957 its filename in the :loaded-from property of the library id.
11958 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11959 Initialize and staticpro them.
11960 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11962 * process.c: Include lisp.h before w32.h, not after.
11963 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11964 instead of gnutls_record_check_pending.
11966 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11968 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11970 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11971 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11974 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11976 * xterm.c (x_set_frame_alpha): Do not set property on anything
11977 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11979 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11981 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11983 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11985 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11986 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11987 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11988 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11989 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11990 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11991 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11992 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11993 (Qgnutls_bootprop_callbacks_verify): Make static.
11995 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11997 * callproc.c: Indentation fixup.
11999 * sysdep.c (wait_for_termination_1): Make static.
12000 (wait_for_termination, interruptible_wait_for_termination):
12001 Move after wait_for_termination_1.
12003 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
12005 * sysdep.c (interruptible_wait_for_termination): New function
12006 which is like wait_for_termination, but allows keyboard
12009 * callproc.c (Fcall_process): Add (:file "file") as an option for
12011 (Fcall_process_region): Ditto.
12013 2011-04-30 Eli Zaretskii <eliz@gnu.org>
12015 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
12016 rather than `XVECTOR (FOO)->size'.
12018 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
12019 inttypes.h, as a gnulib replacement is used if it not available in
12022 2011-04-21 Eli Zaretskii <eliz@gnu.org>
12024 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
12025 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
12026 of MOST_POSITIVE_FIXNUM. (Bug#8528)
12028 * coding.c (coding_alloc_by_realloc): Error out if destination
12029 will grow beyond MOST_POSITIVE_FIXNUM.
12030 (decode_coding_emacs_mule): Abort if there isn't enough place in
12031 charbuf for the composition carryover bytes. Reserve an extra
12032 space for up to 2 characters produced in a loop.
12033 (decode_coding_iso_2022): Abort if there isn't enough place in
12034 charbuf for the composition carryover bytes.
12036 2011-04-21 Eli Zaretskii <eliz@gnu.org>
12038 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
12039 aborting when %lld or %lll format is passed.
12040 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
12041 %llo or %llx format is passed. (Bug#8545)
12043 * window.c (window_scroll_line_based): Use a marker instead of
12044 simple variables to record original value of point. (Bug#7952)
12046 * doprnt.c (doprnt): Fix the case where a multibyte sequence
12047 produced by %s or %c overflows available buffer space. (Bug#8545)
12049 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
12051 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
12052 (SIZE_MAX): Move defn after all includes, as they might #define it.
12054 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
12056 * w32.c (init_environment): Warn about defaulting HOME to C:\.
12058 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
12060 * keyboard.c (Qdelayed_warnings_hook): Define.
12061 (command_loop_1): Run `delayed-warnings-hook'
12062 if Vdelayed_warnings_list is non-nil.
12063 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
12064 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
12066 2011-04-28 Eli Zaretskii <eliz@gnu.org>
12068 * doprnt.c (doprnt): Don't return value smaller than the buffer
12069 size if the message was truncated. (Bug#8545).
12071 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
12073 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
12074 (Fx_window_property): #if-0 the whole functions, not just the bodies.
12076 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12078 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
12080 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
12082 * makefile.w32-in: Update dependencies.
12084 2011-04-27 Eli Zaretskii <eliz@gnu.org>
12086 Improve `doprnt' and its usage. (Bug#8545)
12087 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
12088 `format_end'. Remove support for %l as a conversion specifier.
12089 Don't use xrealloc. Improve diagnostics when the %l size modifier
12090 is used. Update the commentary.
12092 * eval.c (verror): Simplify calculation of size_t.
12094 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
12097 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
12099 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
12102 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12104 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
12105 This makes this file independent of the recent pseudovector change.
12107 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
12109 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
12111 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
12112 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
12113 Remove unused local.
12114 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
12116 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
12117 GCC 4.6.0 optimizes based on type-based alias analysis.
12118 For example, if b is of type struct buffer * and v of type struct
12119 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
12120 != &v->size, and therefore "v->size = 1; b->size = 2; return
12121 v->size;" must therefore return 1. This assumption is incorrect
12122 for Emacs, since it type-puns struct Lisp_Vector * with many other
12123 types. To fix this problem, this patch adds a new type struct
12124 vectorlike_header that documents the constraints on layout of vectors
12125 and pseudovectors, and helps optimizing compilers not get fooled
12126 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
12127 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
12128 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
12130 (XSETPVECTYPE): Rewrite in terms of new macro.
12131 (XSETPVECTYPESIZE): New macro, specifying both type and size.
12132 This is a bit clearer, and further avoids the possibility of
12133 undesirable aliasing.
12134 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
12135 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
12136 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
12137 since Lisp_Subr is a special case (no "next" field).
12138 (ASIZE): Now uses header.size rather than size.
12139 All previous uses of XVECTOR (foo)->size replaced to use this macro,
12140 to avoid the hassle of writing XVECTOR (foo)->header.size.
12141 (struct vectorlike_header): New type.
12142 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
12143 object, to help avoid aliasing.
12144 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
12145 (SUBRP): Likewise, since Lisp_Subr is a special case.
12146 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
12147 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
12148 (struct Lisp_Hash_Table): Combine first two members into a single
12149 struct vectorlike_header member. All uses of "size" and "next" members
12150 changed to be "header.size" and "header.next".
12151 * buffer.h (struct buffer): Likewise.
12152 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
12153 * frame.h (struct frame): Likewise.
12154 * process.h (struct Lisp_Process): Likewise.
12155 * termhooks.h (struct terminal): Likewise.
12156 * window.c (struct save_window_data, struct saved_window): Likewise.
12157 * window.h (struct window): Likewise.
12158 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
12159 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
12160 * buffer.c (init_buffer_once): Likewise.
12161 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
12163 * process.c (Fformat_network_address): Use local var for size,
12166 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
12168 Make the Lisp reader and string-to-float more consistent (Bug#8525)
12169 * data.c (atof): Remove decl; no longer used or needed.
12170 (digit_to_number): Move to lread.c.
12171 (Fstring_to_number): Use new string_to_number function, to be
12172 consistent with how the Lisp reader treats infinities and NaNs.
12173 Do not assume that floating-point numbers represent EMACS_INT
12174 without losing information; this is not true on most 64-bit hosts.
12175 Avoid double-rounding errors, by insisting on integers when
12176 parsing non-base-10 numbers, as the documentation specifies.
12177 * lisp.h (string_to_number): New decl, replacing ...
12178 (isfloat_string): Remove.
12179 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
12180 (read1): Do not accept +. and -. as integers; this
12181 appears to have been a coding error. Similarly, do not accept
12182 strings like +-1e0 as floating point numbers. Do not report
12183 overflow for integer overflows unless the base is not 10 which
12184 means we have no simple and reliable way to continue.
12185 Break out the floating-point parsing into a new
12186 function string_to_number, so that Fstring_to_number parses
12187 floating point numbers consistently with the Lisp reader.
12188 (digit_to_number): Move here from data.c. Make it static inline.
12189 (E_CHAR, EXP_INT): Remove, replacing with ...
12190 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12191 (string_to_number): New function, replacing isfloat_string.
12192 This function checks for valid syntax and produces the resulting
12193 Lisp float number too. Rework it so that string-to-number
12194 no longer mishandles examples like "1.0e+". Use strtoumax,
12195 so that overflow for non-base-10 numbers is reported only when
12196 there's no portable and simple way to convert to floating point.
12198 * textprop.c (set_text_properties_1): Rewrite for clarity,
12199 and to avoid GCC warning about integer overflow.
12201 * intervals.h (struct interval): Use EMACS_INT for members
12202 where EMACS_UINT might cause problems. See
12203 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12204 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12205 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12207 (offset_intervals): Tell GCC not to worry about length overflow
12208 when negating a negative length.
12210 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12211 (overrun_check_free): Likewise.
12213 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12214 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12217 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12218 (gnutls_make_error): Rename local to avoid shadowing.
12219 (gnutls_emacs_global_deinit): ifdef out; not used.
12220 (Fgnutls_boot): Use const for pointer to readonly storage.
12221 Comment out unused local. Fix pointer signedness problems.
12223 * lread.c (openp): Don't stuff size_t into an 'int'.
12224 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12225 about possible signed overflow.
12227 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12228 (GDK_KEY_g): Don't define if already defined.
12229 (xg_prepare_tooltip): Avoid pointer signedness problem.
12230 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12232 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12233 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12235 * xfns.c (Fx_window_property): Simplify a bit,
12236 to make a bit faster and to avoid GCC 4.6.0 warning.
12237 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12239 * fns.c (internal_equal): Don't assume size_t fits in int.
12241 * alloc.c (compact_small_strings): Tighten assertion a little.
12243 Replace pEd with more-general pI, and fix some printf arg casts.
12244 * lisp.h (pI): New macro, generalizing old pEd macro to other
12245 conversion specifiers. For example, use "...%"pI"d..." rather
12246 than "...%"pEd"...".
12247 (pEd): Remove. All uses replaced with similar uses of pI.
12248 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
12249 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12250 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12251 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12252 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12253 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12254 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12256 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12257 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12258 * print.c (safe_debug_print, print_object): Likewise.
12259 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12261 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12262 avoiding the 0 flag, which is not portable.
12263 * process.c (Fmake_network_process): Use pI to avoid cast.
12264 * region-cache.c (pp_cache): Likewise.
12265 * xdisp.c (decode_mode_spec): Likewise.
12266 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12267 behavior on 64-bit hosts with printf arg.
12268 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
12269 (x_stop_queuing_selection_requests): Likewise.
12270 (x_get_window_property): Don't truncate byte count to an 'int'
12273 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12274 here, since it parses constructs like leading '-' and spaces,
12275 which are not wanted; and it overflows with large numbers.
12276 Instead, simply match F[0-9]+, which is what is wanted anyway.
12278 * alloc.c: Remove unportable assumptions about struct layout.
12279 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12280 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12281 (allocate_vectorlike, make_pure_vector): Use the new macros,
12282 plus offsetof, to remove unportable assumptions about struct layout.
12283 These assumptions hold on all porting targets that I know of, but
12284 they are not guaranteed, they're easy to remove, and removing them
12285 makes further changes easier.
12287 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12288 This doesn't fix a bug but makes the code clearer.
12289 (string_overrun_cookie): Now const. Use initializers that
12290 don't formally overflow signed char, to avoid warnings.
12291 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12292 can cause Emacs to crash when string overrun checking is enabled.
12293 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12294 multiple of sizeof (EMACS_INT); it need not be, if
12295 alignof(EMACS_INT) < sizeof (EMACS_INT).
12296 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
12298 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
12300 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12302 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12304 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
12305 supposed to be handshaking. (Bug#8556)
12306 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12308 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
12310 * lisp.h (Qdebug): List symbol.
12311 * eval.c (Qdebug): Restore global linkage.
12312 * keyboard.c (debug-on-event): New variable.
12313 (handle_user_signal): Break into debugger when debug-on-event
12314 matches the current signal symbol.
12316 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12318 * alloc.c (check_sblock, check_string_bytes)
12319 (check_string_free_list): Convert to standard C.
12321 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12323 * w32.c (emacs_gnutls_push): Fix typo.
12325 2011-04-25 Eli Zaretskii <eliz@gnu.org>
12327 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12328 "cast to pointer from integer of different size".
12330 Improve doprnt and its use in verror. (Bug#8545)
12331 * doprnt.c (doprnt): Document the set of format control sequences
12332 supported by the function. Use SAFE_ALLOCA instead of always
12335 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12336 is one byte too soon. Don't use xrealloc; instead xfree and
12339 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12341 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12344 * gnutls.c: Renamed global_initialized to
12345 gnutls_global_initialized. Added internals for the
12346 :verify-hostname-error, :verify-error, and :verify-flags
12347 parameters of `gnutls-boot' and documented those parameters in the
12348 docstring. Start callback support.
12349 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12350 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12351 on error. Return error code.
12352 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12353 (emacs_gnutls_read): Likewise.
12354 (Fgnutls_boot): Return handshake error code.
12355 (emacs_gnutls_handle_error): New function.
12356 (wsaerror_to_errno): Likewise.
12358 * w32.h (emacs_gnutls_pull): Add prototype.
12359 (emacs_gnutls_push): Likewise.
12361 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12362 (emacs_gnutls_push): Likewise.
12364 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12366 * process.c (wait_reading_process_output): Check if GnuTLS
12367 buffered some data internally if no FDs are set for TLS
12370 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12371 (LIBS): Link to USER_LIBS.
12372 ($(BLD)/gnutls.$(0)): New target.
12374 2011-04-24 Eli Zaretskii <eliz@gnu.org>
12376 * xdisp.c (handle_single_display_spec): Rename the
12377 display_replaced_before_p argument into display_replaced_p, to
12378 make it consistent with the commentary. Fix typos in the
12381 * textprop.c (syms_of_textprop): Remove dead code.
12382 (copy_text_properties): Delete obsolete commentary about an
12383 interface that was deleted long ago. Fix typos in the description
12386 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12387 to changes in oldXMenu/XMenu.h from 2011-04-16.
12388 <menu_help_message, prev_menu_help_message>: Constify.
12389 (IT_menu_make_room): menu->help_text is now `const char **';
12392 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12393 to changes in oldXMenu/XMenu.h from 2011-04-16.
12394 (struct XMenu): Declare `help_text' `const char **'.
12396 * xfaces.c <Qunspecified>: Make extern again.
12398 * syntax.c: Include sys/types.h before including regex.h, as
12401 * doc.c (get_doc_string): Improve the format passed to `error'.
12403 * doprnt.c (doprnt): Improve commentary.
12405 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12407 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12410 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12411 changes in globals.h immediately force recompilation.
12412 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12413 $(CURDIR)/s/ms-w32.h.
12414 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
12416 * character.c (Fchar_direction): Function deleted.
12417 (syms_of_character): Don't defsubr it.
12418 <char-direction-table>: Deleted.
12420 2011-04-23 Eli Zaretskii <eliz@gnu.org>
12422 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12423 * doprnt.c: Include limits.h.
12424 (SIZE_MAX): New macro.
12425 (doprnt): Return a size_t value. 2nd arg is now size_t.
12426 Many local variables are now size_t instead of int or unsigned.
12427 Improve overflow protection. Support `l' modifier for integer
12428 conversions. Support %l conversion. Don't assume an EMACS_INT
12429 argument for integer conversions and for %c.
12431 * lisp.h (doprnt): Restore prototype.
12433 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12434 $(SRC)/character.h.
12436 * Makefile.in (base_obj): Add back doprnt.o.
12438 * deps.mk (doprnt.o): Add back prerequisites.
12439 (callint.o): Depend on character.h.
12441 * eval.c (internal_lisp_condition_case): Include the handler
12442 representation in the error message.
12443 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12444 when breaking from the loop.
12446 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12448 * callint.c (Fcall_interactively): When displaying error message
12449 about invalid control letter, pass the character's codepoint, not
12450 a pointer to its multibyte form. Improve display of the character
12451 in octal and display also its hex code.
12453 * character.c (char_string): Use %x to display the (unsigned)
12454 codepoint of an invalid character, to avoid displaying a bogus
12457 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12458 `error', not SYMBOL_NAME itself.
12460 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12461 character arguments to `error'.
12463 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12464 to `error' in error message about FINAL_CHAR argument. Make sure
12465 FINAL_CHAR is a character, and use %c when it is passed as
12466 argument to `error'.
12468 2011-04-23 Eli Zaretskii <eliz@gnu.org>
12470 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12472 * w32.c: Include <time.h>.
12473 (sys_localtime): New function.
12475 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
12477 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12479 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
12481 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
12483 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12484 zombies (Bug#8467).
12486 2011-04-19 Eli Zaretskii <eliz@gnu.org>
12488 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12489 gl_state.e_property when gl_state.object is Qt.
12491 * insdel.c (make_gap_larger): Remove limitation of buffer size
12494 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
12496 * xdisp.c (lookup_glyphless_char_display)
12497 (produce_glyphless_glyph): Handle cons cell entry in
12498 glyphless-char-display.
12499 (Vglyphless_char_display): Document it.
12501 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12502 glyphless-char-display.
12504 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
12506 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12508 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12510 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12511 definition for no-X builds.
12513 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
12515 Static checks with GCC 4.6.0 and non-default toolkits.
12517 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12519 * process.c (keyboard_bit_set): Define only if SIGIO.
12520 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12521 (send_process): Repair possible setjmp clobbering.
12523 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12525 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12527 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12529 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12530 Define only if needed.
12532 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12533 by pacifying GCC about it. Maybe it's time to retire it?
12534 * xfaces.c (USG, __TIMEVAL__): Likewise.
12536 * dispextern.h (struct redisplay_interface): Rename param
12537 to avoid shadowing.
12538 * termhooks.h (struct terminal): Likewise.
12539 * xterm.c (xembed_send_message): Likewise.
12541 * insdel.c (make_gap_smaller): Define only if
12542 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12544 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12547 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12548 so that we aren't warned about unused symbols.
12550 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12552 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
12554 * xfns.c (x_real_positions): Mark locals as initialized.
12556 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12558 * xterm.c: Fix problems found by static analysis with other toolkits.
12559 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
12560 (x_dispatch_event): Declare static if USE_GTK, and
12561 define if USE_GTK || USE_X_TOOLKIT.
12562 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
12563 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
12564 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12565 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
12567 * xmenu.c (menu_help_callback): Pointer type fixes.
12568 Use const pointers when pointing at readonly data. Avoid pointer
12569 signedness clashes.
12570 (FALSE): Remove unused macro.
12571 (update_frame_menubar): Remove unused decl.
12573 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12575 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12576 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12577 (single_menu_item): Rename local to avoid shadowing.
12579 * keyboard.c (make_lispy_event): Remove unused local var.
12581 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12582 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12584 * bitmaps: Change bitmaps from unsigned char back to the X11
12585 compatible char. Avoid the old compiler warnings about
12586 out-of-range initializers by using, for example, '\xab' rather
12589 * xgselect.c (xgselect_initialize): Check vs interface
12590 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12592 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12594 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12595 to read-only memory.
12597 * fns.c (vector): Remove; this old hack is no longer needed.
12599 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
12601 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
12603 * xrdb.c (x_load_resources): Omit unused local.
12605 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
12606 (x_window): Rename locals to avoid shadowing.
12607 (USG): Use the kludged USG macro, to pacify gcc.
12609 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
12610 (x_term_init): Remove local to avoid shadowing.
12612 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
12614 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12615 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12617 2011-04-16 Eli Zaretskii <eliz@gnu.org>
12619 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12621 Fix regex.c, syntax.c and friends for buffers > 2GB.
12622 * syntax.h (struct gl_state_s): Declare character position members
12625 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12627 * textprop.c (verify_interval_modification, interval_of):
12628 Declare arguments EMACS_INT.
12630 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12633 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12635 * indent.c (Fvertical_motion): Local variable it_start is now
12638 * regex.c (re_match, re_match_2, re_match_2_internal)
12639 (bcmp_translate, regcomp, regexec, print_double_string)
12640 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12641 (re_compile_pattern, re_exec): Declare arguments and local
12642 variables `size_t' and `ssize_t' and return values `regoff_t', as
12644 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12645 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12646 <compile_stack_type>: `size' and `avail' are now `size_t'.
12648 * regex.h <regoff_t>: Use ssize_t, not int.
12649 (re_search, re_search_2, re_match, re_match_2): Arguments that
12650 specify buffer/string position and length are now ssize_t and
12651 size_t. Return type is regoff_t.
12653 2011-04-16 Ben Key <bkey76@gmail.com>
12655 * nsfont.m: Fixed bugs in ns_get_family and
12656 ns_descriptor_to_entity that were caused by using free to
12657 deallocate memory blocks that were allocated by xmalloc (via
12658 xstrdup). This caused Emacs to crash when compiled with
12659 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12660 --enable-checking=xmallocoverrun). xfree is now used to
12661 deallocate these memory blocks.
12663 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
12665 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12667 emacs_write: Accept and return EMACS_INT for sizes.
12668 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12670 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12671 Accept and return EMACS_INT.
12672 (emacs_gnutls_write): Return the number of bytes written on
12674 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
12675 (emacs_read, emacs_write): Remove check for negative size, as the
12676 Emacs source code has been audited now.
12677 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12678 (emacs_read, emacs_write): Use it.
12679 * process.c (send_process): Adjust to the new signatures of
12680 emacs_write and emacs_gnutls_write. Do not attempt to store
12681 a byte offset into an 'int'; it might overflow.
12682 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
12684 * sound.c: Don't assume sizes fit in 'int'.
12685 (struct sound_device.period_size, alsa_period_size):
12686 Return EMACS_INT, not int.
12687 (struct sound_device.write, vox_write, alsa_write):
12688 Accept EMACS_INT, not int.
12689 (wav_play, au_play): Use EMACS_INT to store sizes and to
12690 record read return values.
12692 2011-04-15 Ben Key <bkey76@gmail.com>
12694 * keyboard.c (Qundefined): Don't declare static since it is used
12696 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12697 static since they are used in nsfont.m.
12699 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12701 * process.c (Qprocessp): Don't declare static.
12702 * lisp.h (Qprocessp): Declare again.
12704 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
12706 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12708 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12710 Improve C-level modularity by making more things 'static'.
12712 Don't publish debugger-only interfaces to other modules.
12713 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12714 (verify_bytepos, count_markers): Move decls to the only modules
12716 * region-cache.h (pp_cache): Likewise.
12717 * window.h (check_all_windows): Likewise.
12718 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12720 * sysdep.c (croak): Now static, if
12721 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12722 * syssignal.h (croak): Declare only if not static.
12724 * alloc.c (refill_memory_reserve): Now static if
12725 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12726 * lisp.h (refill_memory_reserve): Declare only if not static.
12728 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12729 Define only if USE_LUCID.
12731 * xrdb.c (x_customization_string, x_rm_string): Now static.
12733 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12734 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12736 * xdisp.c (draw_row_with_mouse_face): Now static.
12737 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12739 * window.h (check_all_windows): Mark externally visible.
12741 * window.c (window_deletion_count): Now static.
12743 * undo.c: Make symbols static if they're not exported.
12744 (last_undo_buffer, last_boundary_position, pending_boundary):
12747 * textprop.c (interval_insert_behind_hooks): Now static.
12748 (interval_insert_in_front_hooks): Likewise.
12750 * term.c: Make symbols static if they're not exported.
12751 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12752 (max_frame_lines, tty_set_terminal_modes):
12753 (tty_reset_terminal_modes, tty_turn_off_highlight):
12754 (get_tty_terminal): Now static.
12755 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12756 * termhooks.h (term_mouse_moveto): Do not declare if
12757 HAVE_WINDOW_SYSTEM.
12758 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12759 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12761 * sysdep.c: Make symbols static if they're not exported.
12762 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12764 (sigprocmask_set, full_mask): Remove; unused.
12765 (wait_debugging): Mark as visible.
12766 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12767 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12769 * syntax.c (syntax_temp): Define only if !__GNUC__.
12771 * sound.c (current_sound_device, current_sound): Now static.
12773 * search.c (searchbufs, searchbuf_head): Now static.
12775 * scroll.c (scroll_cost): Remove; unused.
12776 * dispextern.h (scroll_cost): Remove decl.
12778 * region-cache.h (pp_cache): Mark as externally visible.
12780 * process.c: Make symbols static if they're not exported.
12781 (process_tick, update_tick, create_process, chan_process):
12782 (Vprocess_alist, proc_buffered_char, datagram_access):
12783 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12784 (deactivate_process): Mark defn as static, as well as decl.
12785 * lisp.h (create_process): Remove decl.
12786 * process.h (chan_process, Vprocess_alist): Remove decls.
12788 * print.c: Make symbols static if they're not exported.
12789 (print_depth, new_backquote_output, being_printed, print_buffer):
12790 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12791 (print_interval, print_number_index, initial_stderr_stream):
12793 * lisp.h (Fprinc): Remove decl.
12794 (debug_output_compilation_hack): Mark as externally visible.
12796 * sysdep.c (croak): Move decl from here to syssignal.h.
12797 * syssignal.h (croak): Put it here, so the API can be checked when
12798 'croak' is called from dissociate_if_controlling_tty.
12800 * minibuf.c: Make symbols static if they're not exported.
12801 (minibuf_save_list, choose_minibuf_frame): Now static.
12802 * lisp.h (choose_minibuf_frame): Remove decl.
12804 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12806 * lread.c: Make symbols static if they're not exported.
12807 (read_objects, initial_obarray, oblookup_last_bucket_number):
12809 (make_symbol): Remove; unused.
12810 * lisp.h (initial_obarray, make_symbol): Remove decls.
12812 * keyboard.c: Make symbols static if they're not exported.
12813 (single_kboard, recent_keys_index, total_keys, recent_keys):
12814 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12815 (this_single_command_key_start, echoing, last_auto_save):
12816 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12817 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12818 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12819 (Vlispy_mouse_stem, double_click_count):
12821 (force_auto_save_soon): Define only if SIGDANGER.
12822 (ignore_mouse_drag_p): Now static if
12823 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12824 (print_help): Remove; unused.
12825 (stop_character, last_timer_event): Mark as externally visible.
12826 * keyboard.h (ignore_mouse_drag_p): Declare only if
12827 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12828 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12829 * lisp.h (echoing): Remove decl.
12830 (force_auto_save_soon): Declare only if SIGDANGER.
12831 * xdisp.c (redisplay_window): Simplify code, to make it more
12832 obvious that ignore_mouse_drag_p is not accessed if !defined
12833 USE_GTK && !defined HAVE_NS.
12835 * intervals.c: Make symbols static if they're not exported.
12836 (merge_properties_sticky, merge_interval_right, delete_interval):
12838 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12840 * insdel.c: Make symbols static if they're not exported.
12841 However, leave prepare_to_modify_buffer alone. It's never
12842 called from outside this function, but that appears to be a bug.
12843 (combine_after_change_list, combine_after_change_buffer):
12844 (adjust_after_replace, signal_before_change): Now static.
12845 (adjust_after_replace_noundo): Remove; unused.
12846 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
12847 (signal_before_change): Remove decls.
12849 * indent.c (val_compute_motion, val_vmotion): Now static.
12851 * image.c: Make symbols static if they're not exported.
12852 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12854 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12855 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12857 * fringe.c (standard_bitmaps): Now static.
12858 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12860 * frame.c: Make symbols static if they're not exported.
12861 (x_report_frame_params, make_terminal_frame): Now static.
12862 (get_frame_param): Now static, unless HAVE_NS.
12863 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12864 (x_get_resource_string): Remove; not used.
12865 * frame.h (make_terminal_frame, x_report_frame_params):
12866 (x_get_resource_string); Remove decls.
12867 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12868 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12870 * font.c, fontset.c: Make symbols static if they're not exported.
12871 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12872 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12873 * font.c (font_close_object): Now static.
12874 * font.h (font_close_object): Remove.
12875 * fontset.c (FONTSET_OBJLIST): Remove.
12876 (free_realized_fontset) #if-0 the body, which does nothing.
12877 (face_suitable_for_char_p): #if-0, as it's never called.
12878 * fontset.h (face_suitable_for_char_p): Remove decl.
12879 * xfaces.c (face_at_string_position):
12880 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
12881 since 0 is always ASCII.
12883 * fns.c (weak_hash_tables): Now static.
12885 * fileio.c: Make symbols static if they're not exported.
12886 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12887 (Vwrite_region_annotation_buffers): Now static.
12889 * eval.c: Make symbols static if they're not exported.
12890 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12891 * lisp.h (backtrace_list): Remove decl.
12893 * emacs.c: Make symbols static if they're not exported.
12894 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12895 (fatal_error_code, fatal_error_signal_hook, standard_args):
12897 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12898 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12899 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12900 * lisp.h (fatal_error_signal_hook): Remove decl.
12901 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12903 * editfns.c: Move a (normally-unused) function to its only use.
12904 * editfns.c, lisp.h (get_operating_system_release): Remove.
12905 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12906 worth the hassle of breaking this out.
12908 * xterm.c: Make symbols static if they're not exported.
12909 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12910 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12911 (x_destroy_window, x_delete_display):
12913 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12914 (x_mouse_leave): Remove; unused.
12915 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12916 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12917 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12919 (x_mouse_leave): Declare only if WINDOWSNT.
12920 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12921 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12924 * ftxfont.c: Make symbols static if they're not exported.
12925 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12927 * font.h (ftxfont_driver): Likewise.
12929 * xfns.c: Make symbols static if they're not exported.
12930 (x_last_font_name, x_display_info_for_name):
12931 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12932 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12933 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12934 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12935 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12936 (last_show_tip_args): Now static.
12937 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12938 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12939 (x_screen_planes): Remove; unused.
12940 * dispextern.h (x_screen_planes): Remove decl.
12942 * dispnew.c: Make symbols static if they're not exported.
12943 * dispextern.h (redraw_garbaged_frames, scrolling):
12944 (increment_row_positions): Remove.
12945 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12946 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12948 (redraw_garbaged_frames): Remove; unused.
12950 * xfaces.c: Make symbols static if they're not exported.
12951 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12953 * xterm.h (defined_color): Remove decls.
12954 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12955 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12956 (menu_face_changed_default, defined_color, free_realized_face):
12957 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12958 (ascii_face_of_lisp_face): Remove; unused.
12960 * xdisp.c: Make symbols static if they're not exported.
12961 * dispextern.h (scratch_glyph_row, window_box_edges):
12962 (glyph_to_pixel_coords, set_cursor_from_row):
12963 (get_next_display_element, set_iterator_to_next):
12964 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12965 (show_mouse_face): Remove decls
12966 * frame.h (message_buf_print): Likewise.
12967 * lisp.h (pop_message, set_message, check_point_in_composition):
12969 * xterm.h (set_vertical_scroll_bar): Likewise.
12970 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12971 (message_buf_print, scratch_glyph_row, displayed_buffer):
12972 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12973 (get_next_display_element, show_mouse_face, window_box_edges):
12974 (frame_to_window_pixel_xy, check_point_in_composition):
12975 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12976 (glyph_to_pixel_coords): Remove; unused.
12978 * dired.c (file_name_completion): Now static.
12980 * dbusbind.c (xd_in_read_queued_messages): Now static.
12982 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12983 * data.c (circular_list_error): Remove.
12985 * commands.h (last_point_position, last_point_position_buffer):
12986 (last_point_position_window): Remove decls.
12987 * keyboard.c: Make these variables static.
12989 * coding.h (coding, code_convert_region, encode_coding_gap):
12991 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12992 (iso_code_class, detect_coding, code_convert_region): Now static.
12993 (encode_coding_gap): Remove; unused.
12995 * chartab.c (chartab_chars, chartab_bits): Now static.
12997 * charset.h (charset_iso_8859_1): Remove decl.
12998 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
13001 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
13002 * ccl.c (Vccl_program_table): Now static.
13003 (check_ccl_update): Remove; unused.
13005 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
13006 * category.h: ... from here.
13007 * category.c (check_category_table, set_category_set): Now static.
13009 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
13010 * lisp.h: Remove these decls.
13012 * buffer.c (buffer_count): Remove unused var.
13014 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
13015 so that it's not optimized away.
13016 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
13017 * dispextern.h (bidi_dump_cached_states): Remove, since it's
13018 exported only to the debugger.
13020 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
13021 * atimer.h (run_all_atimers): Remove; not exported.
13023 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
13024 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
13025 was inaccessible from Lisp.
13026 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
13027 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
13029 alloc.c: Import and export fewer symbols, and remove unused items.
13030 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
13032 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
13033 it's not optimized away by whole-program optimization.
13034 (message_enable_multibyte, free_misc): Remove.
13035 (catchlist, handlerlist, mark_backtrace):
13036 Declare only if BYTE_MARK_STACK.
13037 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
13038 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
13039 (message_enable_multibyte): Remove decl.
13040 (free_misc, interval_free_list, float_block, float_block_index):
13041 (n_float_blocks, float_free_list, cons_block, cons_block_index):
13042 (cons_free_list, last_marked_index):
13044 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
13045 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
13046 (mark_backtrace): Define only if BYTE_MARK_STACK.
13047 * xdisp.c (message_enable_multibyte): Now static.
13049 Declare Lisp_Object Q* variables to be 'static' if not exported.
13050 This makes it easier for human readers (and static analyzers)
13051 to see whether these variables are used from other modules.
13052 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
13053 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
13054 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
13055 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
13056 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
13057 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
13058 * xmenu.c, xselect.c:
13059 Declare Q* vars static if they are not used in other modules.
13060 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
13061 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
13062 Remove decls of unexported vars.
13063 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
13065 * lisp.h (DEFINE_FUNC): Make sname 'static'.
13067 Make Emacs functions such as Fatom 'static' by default.
13068 This makes it easier for human readers (and static analyzers)
13069 to see whether these functions can be called from other modules.
13070 DEFUN now defines a static function. To make the function external
13071 so that it can be used in other C modules, use the new macro DEFUE.
13072 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
13073 (Finit_image_library):
13074 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
13075 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
13076 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
13077 Remove decls, since these functions are now static.
13078 (Funintern, Fget_internal_run_time): New decls, since these functions
13079 were already external.
13081 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
13082 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
13083 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
13084 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
13085 * keyboard.c, keymap.c, lread.c:
13086 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
13087 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
13088 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
13089 Mark functions with DEFUE instead of DEFUN,
13090 if they are used in other modules.
13091 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
13092 decls for now-static functions.
13093 * buffer.h (Fdelete_overlay): Remove decl.
13094 * callproc.c (Fgetenv_internal): Mark as internal.
13095 * composite.c (Fremove_list_of_text_properties): Remove decl.
13096 (Fcomposition_get_gstring): New forward static decl.
13097 * composite.h (Fcomposite_get_gstring): Remove decl.
13098 * dired.c (Ffile_attributes): New forward static decl.
13099 * doc.c (Fdocumntation_property): New forward static decl.
13100 * eval.c (Ffetch_bytecode): New forward static decl.
13101 (Funintern): Remove extern decl; now in .h file where it belongs.
13102 * fileio.c (Fmake_symbolic_link): New forward static decl.
13103 * image.c (Finit_image_library): New forward static decl.
13104 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
13105 * intervals.h (Fprevious_property_change):
13106 (Fremove_list_of_text_properties): Remove decls.
13107 * keyboard.c (Fthis_command_keys): Remove decl.
13108 (Fcommand_execute): New forward static decl.
13109 * keymap.c (Flookup_key): New forward static decl.
13110 (Fcopy_keymap): Now static.
13111 * keymap.h (Flookup_key): Remove decl.
13112 * process.c (Fget_process): New forward static decl.
13113 (Fprocess_datagram_address): Mark as internal.
13114 * syntax.c (Fsyntax_table_p): New forward static decl.
13115 (skip_chars): Remove duplicate decl.
13116 * textprop.c (Fprevious_property_change): New forward static decl.
13117 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
13119 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
13120 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
13122 * editfns.c (Fformat): Remove unreachable code.
13124 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
13126 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
13129 2011-04-13 Eli Zaretskii <eliz@gnu.org>
13131 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
13132 when at ZV. (Bug#8487)
13134 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
13136 * charset.c (Fclear_charset_maps): Use xfree instead of free.
13138 * keyboard.c (parse_tool_bar_item): Likewise.
13139 * sound.c (sound_cleanup, alsa_close): Likewise.
13140 * termcap.c (tgetent): Likewise.
13141 * xfns.c (x_default_font_parameter): Likewise.
13142 * xsettings.c (read_and_apply_settings): Likewise.
13144 * alloc.c (overrun_check_malloc, overrun_check_realloc)
13145 (overrun_check_free): Protoize.
13147 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
13149 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
13150 since callers should never pass a negative size.
13151 Change the signature to match that of plain 'read' and 'write'; see
13152 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
13153 * lisp.h: Update prototypes of emacs_write and emacs_read.
13155 2011-04-11 Eli Zaretskii <eliz@gnu.org>
13157 * xdisp.c (redisplay_window): Don't try to determine the character
13158 position of the scroll margin if the window start point w->startp
13159 is outside the buffer's accessible region. (Bug#8468)
13161 2011-04-10 Eli Zaretskii <eliz@gnu.org>
13163 Fix write-region and its subroutines for buffers > 2GB.
13164 * fileio.c (a_write, e_write): Modify declaration of arguments and
13165 local variables to support buffers larger than 2GB.
13166 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
13168 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
13169 argument, local variables, and return value.
13171 * lisp.h: Update prototypes of emacs_write and emacs_read.
13173 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
13175 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
13177 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13179 Fix more problems found by GCC 4.6.0's static checks.
13181 * xdisp.c (vmessage): Use a better test for character truncation.
13183 * charset.c (load_charset_map): <, not <=, for optimization,
13184 and to avoid potential problems with integer overflow.
13185 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
13186 * casetab.c (set_identity, shuffle): Likewise.
13187 * editfns.c (Fformat): Likewise.
13188 * syntax.c (skip_chars): Likewise.
13190 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13191 This also lets GCC 4.6.0 generate slightly better loop code.
13193 * callint.c (Fcall_interactively): <, not <=, for optimization.
13194 (Fcall_interactively): Count the number of arguments produced,
13195 not the number of arguments given. This is simpler and lets GCC
13196 4.6.0 generate slightly better code.
13198 * ftfont.c: Distingish more carefully between FcChar8 and char.
13199 The previous code passed unsigned char * to a functions like
13200 strlen and xstrcasecmp that expect char *, which does not
13201 conform to the C standard.
13202 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13203 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13204 char * when the C standard requires it.
13206 * keyboard.c (read_char): Remove unused var.
13208 * eval.c: Port to Windows vsnprintf (Bug#8435).
13209 Include <limits.h>.
13210 (SIZE_MAX): Define if the headers do not.
13211 (verror): Do not give up if vsnprintf returns a negative count.
13212 Instead, grow the buffer. This ports to Windows vsnprintf, which
13213 does not conform to C99. Problem reported by Eli Zaretskii.
13214 Also, simplify the allocation scheme, by avoiding the need for
13215 calling realloc, and removing the ALLOCATED variable.
13217 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13219 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13220 But keep the doprint source code for now, as we might revamp it
13221 and use it again (Bug#8435).
13222 * lisp.h (doprnt): Remove.
13223 * Makefile.in (base_obj): Remove doprnt.o.
13224 * deps.mk (doprnt.o): Remove.
13226 error: Print 32- and 64-bit integers portably (Bug#8435).
13227 Without this change, on typical 64-bit hosts error ("...%d...", N)
13228 was used to print both 32- and 64-bit integers N, which relied on
13229 undefined behavior.
13230 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
13231 * lisp.h (error, verror): Mark as printf-like functions.
13232 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13233 Report overflow in size calculations when allocating printf buffer.
13234 Do not truncate output string at its first null byte.
13235 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13236 Truncate the output at a character boundary, since vsnprintf does not
13238 * charset.c (check_iso_charset_parameter): Convert internal
13239 character to string before calling 'error', since %c now has the
13241 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13242 overflow when computing char to be passed to 'error'. Do not
13243 pass Lisp_Object to 'error'; pass the integer instead.
13244 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13245 formatted with plain %d.
13247 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13249 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13251 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13253 * xterm.c (x_catch_errors): Remove duplicate declaration.
13255 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13257 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13259 2011-04-10 Jim Meyering <meyering@redhat.com>
13261 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13262 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13263 return ssize_t not "int", and use size_t as the buffer length.
13264 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13265 * gnutls.h: Update declarations.
13266 * process.c (read_process_output): Use ssize_t, to match.
13267 (send_process): Likewise.
13269 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
13271 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13273 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
13275 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13276 Use unsigned char, to match FcChar8 type definition.
13278 * xterm.c (handle_one_xevent):
13279 * xmenu.c (create_and_show_popup_menu):
13280 * xselect.c (x_decline_selection_request)
13281 (x_reply_selection_request): Avoid type-punned deref of X events.
13283 2011-04-09 Eli Zaretskii <eliz@gnu.org>
13285 Fix some uses of `int' instead of EMACS_INT.
13286 * search.c (string_match_1, fast_string_match)
13287 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13288 (scan_buffer, find_next_newline_no_quit)
13289 (find_before_next_newline, search_command, Freplace_match)
13290 (Fmatch_data): Make some `int' variables be EMACS_INT.
13292 * xdisp.c (display_count_lines): 3rd argument and return value now
13293 EMACS_INT. All callers changed.
13294 (pint2hrstr): Last argument is now EMACS_INT.
13296 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13297 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13298 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13299 (decode_coding_utf_16, decode_coding_emacs_mule)
13300 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13301 (decode_coding_ccl, decode_coding_charset)
13302 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13303 (decode_coding_iso_2022, decode_coding_emacs_mule)
13304 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13305 <char_offset, last_offset>: Declare EMACS_INT.
13306 (encode_coding_utf_8, encode_coding_utf_16)
13307 (encode_coding_emacs_mule, encode_invocation_designation)
13308 (encode_designation_at_bol, encode_coding_iso_2022)
13309 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13310 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13312 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13313 (encode_invocation_designation): Last argument P_NCHARS is now
13315 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13316 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13318 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13321 * ccl.c (Fccl_execute_on_string): Declare some variables
13324 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
13326 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13328 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13330 * process.c (Fformat_network_address): Doc fix.
13332 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13334 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
13336 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
13338 * keyboard.c (read_char): Call Lisp function help-form-show,
13339 instead of using internal_with_output_to_temp_buffer.
13340 (Qhelp_form_show): New var.
13341 (syms_of_keyboard): Use DEFSYM macro.
13343 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13345 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13347 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
13349 * process.c (Flist_processes): Remove to Lisp.
13350 (list_processes_1): Delete.
13352 2011-04-06 Eli Zaretskii <eliz@gnu.org>
13354 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13356 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13358 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
13360 Fix more problems found by GCC 4.6.0's static checks.
13362 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13364 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13366 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
13368 * xdisp.c (vmessage): Mark as a printf-like function.
13370 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13372 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13374 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13375 printf-like functions.
13376 (tiff_load): Add casts to remove these marks before passing them
13377 to system-supplied API.
13379 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13381 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13382 This avoids several warnings with gcc -Wstrict-overflow.
13383 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13384 directly, rather than having caller test rule sign. This avoids
13385 some unnecessary tests.
13386 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13387 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13388 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
13390 * xfont.c (xfont_text_extents): Remove var that was set but not used.
13391 (xfont_open): Avoid unnecessary tests.
13393 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13395 * composite.h, composite.c (composition_gstring_put_cache):
13396 Use EMACS_INT, not int, for length.
13398 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13399 breaking out part of COMPOSITION_DECODE_RULE.
13400 (COMPOSITION_DECODE_RULE): Use it.
13401 * composite.c (get_composition_id): Remove unused local vars,
13402 by using the new macro.
13404 * textprop.c (set_text_properties_1): Change while to do-while,
13405 since the condition is always true at first.
13407 * intervals.c (graft_intervals_into_buffer): Mark var as used.
13408 (interval_deletion_adjustment): Return unsigned value.
13411 * process.c (list_processes_1, create_pty, read_process_output):
13412 (exec_sentinel): Remove vars that were set but not used.
13413 (create_pty): Remove unnecessary "volatile"s.
13414 (Fnetwork_interface_info): Avoid possibility of int overflow.
13415 (read_process_output): Do adaptive read buffering even if carryover.
13416 (read_process_output): Simplify nbytes computation if buffered.
13418 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13420 * syntax.c (scan_words): Remove var that was set but not used.
13421 (update_syntax_table): Use unsigned instead of int.
13423 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
13424 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
13425 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
13427 * print.c (print_error_message): Avoid int overflow.
13429 * font.c (font_list_entities): Redo for clarity,
13430 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13432 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
13433 (font_score): Avoid potential overflow in diff calculation.
13435 * fns.c (substring_both): Remove var that is set but not used.
13436 (sxhash): Redo loop for clarity and to avoid wraparound warning.
13438 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13440 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13441 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13442 can always succeed if overflow has undefined behavior.
13444 * search.c (boyer_moore, wordify): Remove vars set but not used.
13445 (wordify): Omit three unnecessary tests.
13447 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13448 All callers changed. This avoids the need for an unused var.
13450 * casefiddle.c (casify_region): Remove var that is set but not used.
13452 * dired.c (file_name_completion): Remove var that is set but not used.
13454 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13456 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
13457 (Finsert_file_contents): Remove unnecessary code checking fd.
13459 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13460 Check for integer overflow on size calculations.
13462 * buffer.c (Fprevious_overlay_change): Remove var that is set
13465 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13466 Remove vars that are set but not used.
13467 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
13468 (timer_check_2): Mark vars as initialized.
13470 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13472 * image.c (lookup_image): Remove var that is set but not used.
13473 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
13475 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13476 that are set but not used.
13478 * xfns.c (make_invisible_cursor): Don't return garbage
13479 if XCreateBitmapFromData fails (Bug#8410).
13481 * xselect.c (x_get_local_selection, x_handle_property_notify):
13482 Remove vars that are set but not used.
13484 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
13485 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
13487 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13488 Remove var that is set but not used.
13489 (scroll_bar_windows_size): Now size_t, not int.
13490 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13491 Check for overflow.
13493 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13494 (map_tty_color) [!defined MSDOS]: Likewise.
13496 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13498 * coding.c: Remove vars that are set but not used.
13499 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13500 All callers changed.
13501 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13502 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13503 (decode_coding_charset): Remove vars that are set but not used.
13505 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13506 that is set but not used.
13508 * print.c (print_object): Remove var that is set but not used.
13510 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
13511 The gnulib version avoids calling malloc in the usual case,
13512 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13513 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13514 * filelock.c (current_lock_owner): Likewise.
13515 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13516 * sysdep.c: Include allocator.h, careadlinkat.h.
13517 (emacs_no_realloc_allocator): New static constant.
13518 (emacs_readlink): New function.
13519 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13520 ../lib/careadlinkat.h.
13522 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13524 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13525 first non-nil return value).
13527 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13529 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13530 if not defined (Bug#8403).
13532 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
13534 * xdisp.c (display_count_lines): Remove parameter `start',
13535 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13536 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13537 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13538 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13539 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13540 and thereabouts. All callers changed.
13541 (get_per_char_metric): Remove parameter `f', unused since
13542 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13544 2011-04-02 Jim Meyering <meyering@redhat.com>
13546 do not dereference NULL upon failed strdup
13547 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13548 (ns_get_family): Likewise.
13550 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
13552 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13554 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13556 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13559 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13561 Add lexical binding.
13563 * window.c (Ftemp_output_buffer_show): New fun.
13564 (Fsave_window_excursion):
13565 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13567 * lread.c (lisp_file_lexically_bound_p): New function.
13568 (Fload): Bind Qlexical_binding.
13569 (readevalloop): Remove `evalfun' arg.
13570 Bind Qinternal_interpreter_environment.
13571 (Feval_buffer): Bind Qlexical_binding.
13572 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13574 (syms_of_lread): Declare `lexical-binding'.
13576 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13578 * keyboard.c (eval_dyn): New fun.
13579 (menu_item_eval_property): Use it.
13581 * image.c (parse_image_spec): Use Ffunctionp.
13583 * fns.c (concat, mapcar1): Accept byte-code-functions.
13585 * eval.c (Fsetq): Handle lexical vars.
13586 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13587 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13588 (FletX, Flet): Obey lexical binding.
13589 (Fcommandp): Handle closures.
13590 (Feval): New `lexical' arg.
13591 (eval_sub): New function extracted from Feval. Use it almost
13592 everywhere where Feval was used. Look up vars in lexical env.
13594 (Ffunctionp): Move from subr.el.
13595 (Ffuncall): Handle closures.
13596 (apply_lambda): Remove `eval_flags'.
13597 (funcall_lambda): Handle closures and new byte-code-functions.
13598 (Fspecial_variable_p): New function.
13599 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13600 but without exporting it to Lisp.
13602 * doc.c (Fdocumentation, store_function_docstring):
13603 * data.c (Finteractive_form): Handle closures.
13605 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13608 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13610 (exec_byte_code): New function extracted from Fbyte_code to handle new
13611 calling convention for byte-code-functions. Add new byte-codes.
13613 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
13615 * alloc.c (Fmake_symbol): Init new `declared_special' field.
13617 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
13619 * xdisp.c (redisplay_internal): Fix prototype.
13621 2011-03-31 Eli Zaretskii <eliz@gnu.org>
13623 * xdisp.c (SCROLL_LIMIT): New macro.
13624 (try_scrolling): Use it when setting scroll_limit.
13625 Limit scrolling to 100 screen lines.
13626 (redisplay_window): Even when falling back on "recentering",
13627 position point in the window according to scroll-conservatively,
13628 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13630 (try_scrolling): When point is above the window, allow searching
13631 as far as scroll_max, or one screenful, to compute vertical
13632 distance from PT to the scroll margin position. This prevents
13633 try_scrolling from unnecessarily failing when
13634 scroll-conservatively is set to a value slightly larger than the
13635 window height. Clean up the case of PT below the margin at bottom
13636 of window: scroll_max can no longer be INT_MAX. When aggressive
13637 scrolling is in use, don't let point enter the opposite scroll
13638 margin as result of the scroll.
13639 (syms_of_xdisp) <scroll-conservatively>: Document the
13640 threshold of 100 lines for never-recentering scrolling.
13642 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
13644 * dispextern.h (move_it_by_lines):
13645 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13646 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13647 (message_log_check_duplicate): Remove parameters `prev_bol' and
13648 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13649 (redisplay_internal): Remove parameter `preserve_echo_area',
13650 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13652 * indent.c (Fvertical_motion):
13653 * window.c (window_scroll_pixel_based, Frecenter):
13654 Don't pass `need_y_p' to `move_it_by_lines'.
13656 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13658 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13659 steal a few bits to be more compact.
13660 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13661 Remove unneeded casts.
13663 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13665 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13667 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13668 binding" message (bug#7967).
13670 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13672 Fix more problems found by GCC 4.6.0's static checks.
13674 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13675 Remove unused local var.
13677 * editfns.c (Fmessage_box): Remove unused local var.
13679 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13680 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13681 Omit unused local vars.
13682 * window.c (shrink_windows): Omit unused local var.
13683 * menu.c (digest_single_submenu): Omit unused local var.
13684 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13685 Omit unused local var.
13687 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13688 Don't assume string length fits in int.
13689 (keyremap_step, read_key_sequence): Use size_t for sizes.
13690 (read_key_sequence): Don't check last_real_key_start redundantly.
13692 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13693 instead of alloca (Bug#8344).
13695 * eval.c (Fbacktrace): Don't assume nargs fits in int.
13696 (Fbacktrace_frame): Don't assume nframes fits in int.
13698 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13700 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13703 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13705 * cm.c (calccost): Turn while-do into do-while, for clarity.
13707 * keyboard.c (syms_of_keyboard): Use the same style as later
13708 in this function when indexing through an array. This also
13709 works around GCC bug 48267.
13711 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13713 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13715 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13716 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13718 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13719 This avoids undefined behavior on integer overflow, and is a bit
13720 more convenient anyway since it is compared to a size_t variable.
13722 Variadic C functions now count arguments with size_t, not int.
13723 This avoids an unnecessary limitation on 64-bit machines, which
13724 caused (substring ...) to crash on large vectors (Bug#8344).
13725 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13726 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
13727 All variadic functions and their callers changed accordingly.
13728 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13729 * data.c (arith_driver, float_arith_driver): Likewise.
13730 * editfns.c (general_insert_function): Likewise.
13731 * eval.c (struct backtrace.nargs, interactive_p)
13732 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13733 (funcall_lambda, mark_backtrace): Likewise.
13734 * fns.c (concat): Likewise.
13735 * frame.c (x_set_frame_parameters): Likewise.
13736 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13737 0 if not found, not -1. All callers changed.
13739 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13740 (stack_copy_size): Now size_t, not int.
13741 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13743 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
13745 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13746 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13747 All callers changed.
13749 * lisp.h (multibyte_char_to_unibyte):
13750 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13751 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13752 * character.h (CHAR_TO_BYTE8):
13753 * cmds.c (internal_self_insert):
13754 * editfns.c (general_insert_function):
13755 * keymap.c (push_key_description):
13756 * search.c (Freplace_match):
13757 * xdisp.c (message_dolog, set_message_1): All callers changed.
13759 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13761 * keyboard.c (safe_run_hook_funcall): New function.
13762 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13763 don't set the hook to nil, but remove the offending function instead.
13764 (Qcommand_hook_internal): Remove, unused.
13765 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13766 Vcommand_hook_internal.
13768 * eval.c (enum run_hooks_condition): Remove.
13769 (funcall_nil, funcall_not): New functions.
13770 (run_hook_with_args): Call each function through a `funcall' argument.
13771 Remove `cond' argument, now redundant.
13772 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13773 (Frun_hook_with_args_until_failure): Adjust accordingly.
13774 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13776 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
13778 * dispextern.h (string_buffer_position): Remove declaration.
13780 * print.c (strout): Remove parameter `multibyte', unused since
13781 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13783 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13784 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13785 All callers changed.
13787 * w32.c (_wsa_errlist): Use braces for struct initializers.
13789 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13790 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13791 All callers changed.
13792 (string_buffer_position): Likewise. Also, make static (it's never
13793 used outside xdisp.c).
13794 (cursor_row_p): Remove parameter `w', unused since
13795 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13796 (decode_mode_spec): Remove parameter `precision', introduced during
13797 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13798 All callers changed.
13800 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13802 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13804 2011-03-27 Anders Lindgren <andlind@gmail.com>
13806 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13807 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13808 (ns_update_auto_hide_menu_bar): New functions.
13809 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13810 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13811 ns_constrain_all_frames.
13812 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13813 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13815 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13817 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13819 2011-03-27 Glenn Morris <rgm@gnu.org>
13821 * syssignal.h: Replace RETSIGTYPE with void.
13822 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13823 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13824 Replace SIGTYPE with void everywhere.
13825 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13826 * s/template.h (SIGTYPE): Remove commented out definition.
13828 2011-03-26 Eli Zaretskii <eliz@gnu.org>
13830 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13831 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13833 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
13835 * w32.c (read_unc_volume): Use parameter `henum', instead of
13836 global variable `wget_enum_handle'.
13838 * keymap.c (describe_vector): Remove parameters `indices' and
13839 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13840 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13842 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13844 * keyboard.c (timer_check): Remove parameter `do_it_now',
13845 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13846 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13847 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13849 * keyboard.c (read_char):
13850 * w32menu.c (w32_menu_display_help):
13851 * xmenu.c (show_help_event, menu_help_callback):
13852 Adjust calls to `show_help_echo'.
13854 * gtkutil.c (xg_maybe_add_timer):
13855 * keyboard.c (readable_events):
13856 * process.c (wait_reading_process_output):
13857 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13859 * insdel.c (adjust_markers_gap_motion):
13860 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13861 (gap_left, gap_right): Don't call it.
13863 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
13865 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13866 incurred during fontification.
13868 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
13870 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13871 (DEFVAR_PER_BUFFER): Don't pass it.
13873 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13874 (scrolling_window): Don't pass it.
13876 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
13878 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13880 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13882 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13883 of variables specific to SELinux and computation of `encoded_absname'.
13885 * image.c (XPutPixel): Remove unused variable `height'.
13887 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13889 * unexw32.c (get_section_info): Remove unused variable `section'.
13891 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13892 (system_process_attributes): Remove unused variable `sess'.
13893 (sys_read): Remove unused variable `err'.
13895 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13896 (w32_wnd_proc): Remove unused variable `isdead'.
13897 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13898 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13899 (x_create_tip_frame): Remove unused variable `tem'.
13901 * w32inevt.c (w32_console_read_socket):
13902 Remove unused variable `no_events'.
13904 * w32term.c (x_draw_composite_glyph_string_foreground):
13905 Remove unused variable `width'.
13907 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
13909 * w32term.c (x_set_glyph_string_clipping):
13910 Don't pass uninitialized region to CombineRgn.
13912 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
13914 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13915 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13916 (Fx_close_connection): Remove unused variable `i'.
13918 * w32font.c (w32font_draw): Return number of glyphs.
13919 (w32font_open_internal): Remove unused variable `i'.
13920 (w32font_driver): Add missing initializer.
13922 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13923 (fill_in_menu): Remove unused variable `items_added'.
13925 * w32term.c (last_mouse_press_frame): Remove static global variable.
13926 (w32_clip_to_row): Remove unused variable `f'.
13927 (x_delete_terminal): Remove unused variable `i'.
13929 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13930 (NOTHING): Remove unused static global variable.
13931 (uniscribe_check_otf): Remove unused variable `table'.
13932 (uniscribe_font_driver): Add missing initializers.
13934 2011-03-23 Julien Danjou <julien@danjou.info>
13936 * term.c (Fsuspend_tty, Fresume_tty):
13937 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13938 * window.c (temp_output_buffer_show):
13939 * insdel.c (signal_before_change):
13940 * frame.c (Fhandle_switch_frame):
13941 * fileio.c (Fdo_auto_save):
13942 * emacs.c (Fkill_emacs):
13943 * editfns.c (save_excursion_restore):
13944 * cmds.c (internal_self_insert):
13945 * callint.c (Fcall_interactively):
13946 * buffer.c (Fkill_all_local_variables):
13947 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13949 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
13950 unconditionally since it does the check itself.
13952 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
13954 Fix more problems found by GCC 4.5.2's static checks.
13956 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13957 the first time through the loop, since we know p0 < p1 then.
13958 This also avoids a gcc -Wstrict-overflow warning.
13960 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13961 leading to a memory leak, possible in functions like
13962 load_charset_map_from_file that can allocate an unbounded number
13963 of objects (Bug#8318).
13965 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13966 that could (at least in theory) be that large.
13968 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13969 This is less likely to overflow, and avoids undefined behavior if
13970 overflow does occur. All callers changed. Use strtoul to scan
13971 for the unsigned long integer.
13972 (pint2hrstr): Simplify and tune code slightly.
13973 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
13975 * scroll.c (do_scrolling): Work around GCC bug 48228.
13976 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13978 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13979 This also avoids a warning with gcc -Wstrict-overflow.
13980 (validate_x_resource_name): Simplify count usage.
13981 This also avoids a warning with gcc -Wstrict-overflow.
13983 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13986 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
13988 * process.c (Fmake_network_process): Use socklen_t, not int,
13989 where POSIX says socklen_t is required in portable programs.
13990 This fixes a porting bug on hosts like 64-bit HP-UX, where
13991 socklen_t is wider than int (Bug#8277).
13992 (Fmake_network_process, server_accept_connection):
13993 (wait_reading_process_output, read_process_output):
13996 * process.c: Rename or move locals to avoid shadowing.
13997 (list_processes_1, Fmake_network_process):
13998 (read_process_output_error_handler, exec_sentinel_error_handler):
13999 Rename or move locals.
14000 (Fmake_network_process): Define label "retry_connect" only if needed.
14001 (Fnetwork_interface_info): Fix pointer signedness.
14002 (process_send_signal): Add cast to avoid pointer signedness problem.
14003 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
14004 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
14006 Make tparam.h and terminfo.c consistent.
14007 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
14008 Include tparam.h instead, since it declares them.
14009 * cm.h (PC): Remove extern decl; tparam.h now does this.
14010 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
14011 * terminfo.c: Include tparam.h, to check interfaces.
14012 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
14013 (tparam): Adjust signature to match interface in tparam.h;
14014 this removes some undefined behavior. Check that outstring and len
14015 are zero, which they always are with Emacs.
14016 * tparam.h (PC, BC, UP): New extern decls.
14018 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
14019 (xftfont_open): Rename locals to avoid shadowing.
14021 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
14022 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
14023 (OTF_TAG_SYM): Omit macro if not needed.
14024 (ftfont_list): Remove unused local.
14025 (get_adstyle_property, ftfont_pattern_entity):
14026 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
14027 Rename locals to avoid shadowing.
14029 * xfont.c (xfont_list_family): Mark var as initialized.
14031 * xml.c (make_dom): Now static.
14033 * composite.c (composition_compute_stop_pos): Rename local to
14035 (composition_reseat_it): Remove unused locals.
14036 (find_automatic_composition, composition_adjust_point): Likewise.
14037 (composition_update_it): Mark var as initialized.
14038 (find_automatic_composition): Mark vars as initialized,
14039 with a FIXME (Bug#8290).
14041 character.h: Rename locals to avoid shadowing.
14042 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
14043 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
14044 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
14045 (BUF_DEC_POS): Be more systematic about renaming local temporaries
14046 to avoid shadowing.
14048 * textprop.c (property_change_between_p): Remove; unused.
14050 * intervals.c (interval_start_pos): Now static.
14052 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
14054 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
14055 Rename locals to avoid shadowing.
14057 * sound.c (wav_play, au_play, Fplay_sound_internal):
14058 Fix pointer signedness.
14059 (alsa_choose_format): Remove unused local var.
14060 (wav_play): Initialize a variable to 0, to prevent undefined
14061 behavior (Bug#8278).
14063 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
14065 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
14067 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
14068 clobbering (Bug#8298).
14069 * sysdep.c (sys_subshell): Likewise.
14070 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
14072 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
14073 This should get cleaned up, so that child_setup has the
14074 same signature on all platforms.
14076 * callproc.c (call_process_cleanup): Now static.
14077 (relocate_fd): Rename locals to avoid shadowing.
14079 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
14081 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
14082 not to be necessary, and produces flickering.
14084 2011-03-20 Glenn Morris <rgm@gnu.org>
14086 * config.in: Remove file.
14088 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
14090 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
14091 are now in src/globals.h.
14092 (syms_of_minibuf): Remove spurious & from previous change.
14094 2011-03-20 Leo Liu <sdl.web@gmail.com>
14096 * minibuf.c (completing-read-function): New variable.
14097 (completing-read-default): Rename from completing-read.
14098 (completing-read): Call completing-read-function.
14100 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
14102 * xfaces.c (Fx_load_color_file):
14103 Read color file from absolute filename (bug#8250).
14105 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
14107 * makefile.w32-in: Update dependencies.
14109 2011-03-17 Eli Zaretskii <eliz@gnu.org>
14111 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
14113 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
14115 Fix more problems found by GCC 4.5.2's static checks.
14117 * process.c (make_serial_process_unwind, send_process_trap):
14118 (sigchld_handler): Now static.
14120 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
14121 That way, the code declares only the vars that it needs.
14122 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
14123 * s/cygwin.h (PTY_ITERATION): Likewise.
14124 * s/darwin.h (PTY_ITERATION): Likewise.
14125 * s/gnu-linux.h (PTY_ITERATION): Likewise.
14127 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
14128 * process.c (allocate_pty): Don't declare stb unless it's needed.
14130 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
14131 (CONSTANTLIM): Remove; unused.
14132 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
14133 Define only if needed.
14135 * unexelf.c (unexec): Name an expression,
14136 to avoid gcc -Wbad-function-cast warning.
14137 Use a different way to cause a compilation error if anyone uses
14138 n rather than nn, a way that does not involve shadowing.
14139 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
14141 * deps.mk (unexalpha.o): Remove; unused.
14143 New file unexec.h, the (simple) interface for unexec (Bug#8267).
14144 * unexec.h: New file.
14145 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
14146 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
14147 Depend on unexec.h.
14148 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
14149 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
14150 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
14151 Change as necessary to match prototype in unexec.h.
14153 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
14155 (back_comment, skip_chars): Mark vars as initialized.
14157 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
14158 Rename locals to avoid shadowing.
14160 * lread.c (read1): Rewrite so as not to use empty "else".
14161 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
14163 * print.c (Fredirect_debugging_output): Fix pointer signedess.
14165 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
14166 warning when compiling print.c.
14168 * font.c (font_unparse_fcname): Abort in an "impossible" situation
14169 instead of using an uninitialized var.
14170 (font_sort_entities): Mark var as initialized.
14172 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
14174 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14175 pointers to constants.
14176 (font_parse_fcname): Remove unused vars.
14177 (font_delete_unmatched): Now static.
14178 (font_get_spec): Remove; unused.
14179 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14180 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14181 Rename or move locals to avoid shadowing.
14183 * fns.c (require_nesting_list, require_unwind): Now static.
14184 (Ffillarray): Rename locals to avoid shadowing.
14186 * floatfns.c (domain_error2): Define only if needed.
14187 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
14189 * alloc.c (mark_backtrace): Move decl from here ...
14190 * lisp.h: ... to here, so that it can be checked.
14192 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
14193 (Fdefvar): Rewrite so as not to use empty "else".
14194 (lisp_indirect_variable): Name an expression,
14195 to avoid gcc -Wbad-function-cast warning.
14196 (Fdefvar): Rename locals to avoid shadowing.
14198 * callint.c (quotify_arg, quotify_args): Now static.
14199 (Fcall_interactively): Rename locals to avoid shadowing.
14200 Use const pointer when appropriate.
14202 * lisp.h (get_system_name, get_operating_system_release):
14203 Move decls here, to check interfaces.
14204 * process.c (get_operating_system_release): Move decl to lisp.h.
14205 * xrdb.c (get_system_name): Likewise.
14206 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14207 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14208 some of which prompt warnings from gcc -Wbad-function-cast.
14209 (Fformat_time_string, Fencode_time, Finsert_char):
14210 (Ftranslate_region_internal, Fformat):
14211 Rename or remove local vars to avoid shadowing.
14212 (Ftranslate_region_internal): Mark var as initialized.
14214 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14217 * lisp.h (eassert): Check that the argument compiles, even if
14218 ENABLE_CHECKING is not defined.
14220 * data.c (Findirect_variable): Name an expression, to avoid
14221 gcc -Wbad-function-cast warning.
14222 (default_value, arithcompare, arith_driver, arith_error): Now static.
14223 (store_symval_forwarding): Rename local to avoid shadowing.
14224 (Fmake_variable_buffer_local, Fmake_local_variable):
14225 Mark variables as initialized.
14226 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
14228 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
14229 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14230 Rename locals to avoid shadowing.
14231 (mark_stack): Move local variables into the #ifdef region where
14233 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14234 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14236 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14237 (GC_STRING_CHARS): Remove; not used.
14238 (Fmemory_limit): Cast sbrk's returned value to char *.
14240 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14241 avoids undefined behavior in theory.
14243 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14245 Use functions, not macros, for up- and down-casing (Bug#8254).
14246 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14247 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14248 to use the following functions instead of these macros.
14249 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14250 EMACS_INT, since callers assume the returned value fits in int.
14251 (upcase1): Likewise, for UPCASE_TABLE.
14252 (uppercasep, lowercasep, upcase): New static inline functions.
14253 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
14254 the race-condition problem in the old DOWNCASE.
14256 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14257 Rename locals to avoid shadowing.
14258 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
14259 (regex_compile, re_search_2, re_match_2_internal):
14260 Remove unused local vars.
14261 (FREE_VAR): Rewrite so as not to use empty "else",
14262 which gcc can warn about.
14263 (regex_compile, re_match_2_internal): Mark locals as initialized.
14264 (RETALLOC_IF): Define only if needed.
14265 (WORDCHAR_P): Likewise. This one is never needed, but is used
14266 only in a comment talking about a compiler bug, so put inside
14267 the #if 0 of that comment.
14268 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14269 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14272 * search.c (boyer_moore): Rename locals to avoid shadowing.
14273 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14274 (PREV_CHAR_BOUNDARY): Likewise.
14276 * search.c (simple_search): Remove unused var.
14278 * dired.c (compile_pattern): Move decl from here ...
14279 * lisp.h: ... to here, so that it can be checked.
14280 (struct re_registers): New forward decl.
14282 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14284 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14286 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14287 Rename locals to avoid shadowing.
14288 (Fvertical_motion): Mark locals as initialized.
14290 * casefiddle.c (casify_object, casify_region): Now static.
14291 (casify_region): Mark local as initialized.
14293 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14295 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14296 New macros, so that the caller can use some names other than
14297 gcpro1, gcpro2, etc.
14298 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14300 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14301 argument, for consistency with GCPRO2_VAR, etc: it is now the
14302 prefix of the variable, not the variable itself. All uses
14304 * dired.c (directory_files_internal, file_name_completion):
14305 Rename locals to avoid shadowing.
14307 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14308 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14309 dired.c's scmp function, had undefined behavior.
14310 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14311 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14312 * buffer.h: ... to here, because these macros use current_buffer,
14313 and the new implementation with inline functions needs to have
14314 current_buffer in scope now, rather than later when the macros
14316 (downcase, upcase1): New static inline functions.
14317 (DOWNCASE, UPCASE1): Reimplement using these functions.
14318 This avoids undefined behavior in expressions like
14319 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14320 from race conditions in accessing the global variables
14321 case_temp1 and case_temp2.
14322 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14323 * lisp.h (case_temp1, case_temp2): Remove their decls.
14324 * character.h (ASCII_CHAR_P): Move from here ...
14325 * lisp.h: ... to here, so that the inline functions mentioned
14326 above can use them.
14328 * dired.c (directory_files_internal_unwind): Now static.
14330 * fileio.c (file_name_as_directory, directory_file_name):
14331 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14333 (file_name_as_directory): Use const pointers when appropriate.
14334 (Fexpand_file_name): Likewise. In particular, newdir might
14335 point at constant storage, so make it a const pointer.
14336 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
14337 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14339 (Fset_file_times, Finsert_file_contents, auto_save_error):
14340 Rename locals to avoid shadowing.
14342 * minibuf.c (choose_minibuf_frame_1): Now static.
14343 (Ftry_completion, Fall_completions): Rename or remove locals
14344 to avoid shadowing.
14346 * marker.c (bytepos_to_charpos): Remove; unused.
14348 * lisp.h (verify_bytepos, count_markers): New decls,
14349 so that gcc does not warn that these functions aren't declared.
14351 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14352 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
14353 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
14354 (copy_text): Remove unused local var.
14356 * filelock.c (within_one_second): Now static.
14357 (lock_file_1): Rename local to avoid shadowing.
14359 * buffer.c (fix_overlays_before): Mark locals as initialized.
14360 (fix_start_end_in_overlays): Likewise. This function should be
14361 simplified by using pointers-to-pointers, but that's a different
14363 (switch_to_buffer_1): Now static.
14364 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14365 (report_overlay_modification): Rename locals to avoid shadowing.
14367 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
14368 Fix pointer signedness issue.
14369 (sys_subshell): Mark local as volatile if checking for lint,
14370 to suppress a gcc -Wclobbered warning that does not seem to be right.
14371 (MAXPATHLEN): Define only if needed.
14373 * process.c (serial_open, serial_configure): Move decls from here ...
14374 * systty.h: ... to here, so that they can be checked.
14376 * fns.c (get_random, seed_random): Move extern decls from here ...
14377 * lisp.h: ... to here, so that they can be checked.
14379 * sysdep.c (reset_io): Now static.
14380 (wait_for_termination_signal): Remove; unused.
14382 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14383 (copy_keymap_item, append_key, push_text_char_description):
14385 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
14386 (DENSE_TABLE_SIZE): Remove; unused.
14387 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14388 (describe_map_tree):
14389 Rename locals to avoid shadowing.
14391 * keyboard.c: Declare functions static if they are not used elsewhere.
14392 (echo_char, echo_dash, cmd_error, top_level_2):
14393 (poll_for_input, handle_async_input): Now static.
14394 (read_char, kbd_buffer_get_event, make_lispy_position):
14395 (make_lispy_event, make_lispy_movement, apply_modifiers):
14396 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14397 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14398 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
14399 (read_key_sequence, read_char): Mark locals as initialized.
14400 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
14402 * keyboard.h (make_ctrl_char): New decl.
14403 (mark_kboards): Move decl here ...
14404 * alloc.c (mark_kboards): ... from here.
14406 * lisp.h (force_auto_save_soon): New decl.
14408 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
14409 (DEFINE_DUMMY_FUNCTION): New macro.
14410 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14412 (main): Add casts to avoid warnings
14413 if GCC considers string literals to be constants.
14415 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14417 * dbusbind.c: Pointer signedness fixes.
14418 (xd_signature, xd_append_arg, xd_initialize):
14419 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14420 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14421 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14422 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14424 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14425 if GCC considers string literals to be constants.
14426 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
14428 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14430 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14431 (print_preprocess, print_object): New macro to fix last change.
14433 * print.c (print_preprocess): Don't forget font objects.
14435 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
14437 * emacs.c (USAGE3): Doc fixes.
14439 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14441 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14444 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
14446 * lisp.h (VWindow_system, Qfile_name_history):
14447 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14448 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14449 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14451 * w32select.c: Don't #include "keyboard.h".
14452 (run_protected): Add extern declaration for waiting_for_input.
14454 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14455 * w32console.c (detect_input_pending, read_input_pending)
14456 (encode_terminal_code):
14457 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14458 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14459 (w32_system_caret_y, Qfile_name_history):
14460 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14461 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14462 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14463 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14464 * w32proc.c (Qlocal, report_file_error):
14465 * w32term.c (Vwindow_system, updating_frame):
14466 * w32uniscribe.c (initialized, uniscribe_font_driver):
14467 Remove unneeded extern declarations.
14469 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
14471 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
14473 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
14475 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14476 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14477 These macros can no longer be used for assignment.
14479 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14480 Assign struct members directly, instead of using BUF_BEGV etc.
14481 (record_buffer_markers, fetch_buffer_markers): New functions for
14482 recording and fetching special buffer markers.
14483 (set_buffer_internal_1, set_buffer_temp): Use them.
14485 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14487 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14489 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14490 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14492 * xdisp.c (hscroll_window_tree):
14493 (reconsider_clip_changes): Use PT instead of BUF_PT.
14495 2011-03-13 Eli Zaretskii <eliz@gnu.org>
14497 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14498 $(EMACS_ROOT)/lib/intprops.h.
14500 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14502 Fix more problems found by GCC 4.5.2's static checks.
14504 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14505 to unsigned char * to avoid compiler diagnostic.
14506 (xg_free_frame_widgets): Make it clear that a local variable is
14507 needed only if USE_GTK_TOOLTIP.
14508 (gdk_window_get_screen): Make it clear that this macro is needed
14509 only if USE_GTK_TOOLTIP.
14510 (int_gtk_range_get_value): New function, which avoids a diagnostic
14511 from gcc -Wbad-function-cast.
14512 (xg_set_toolkit_scroll_bar_thumb): Use it.
14513 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14514 diagnostic from gcc -Wbad-function-cast.
14515 (get_utf8_string, xg_get_file_with_chooser):
14516 Rename locals to avoid shadowing.
14517 (create_dialog): Move locals to avoid shadowing.
14519 * xgselect.c (xg_select): Remove unused var.
14521 * image.c (four_corners_best): Mark locals as initialized.
14522 (gif_load): Initialize transparent_p to zero (Bug#8238).
14523 Mark another local as initialized.
14524 (my_png_error, my_error_exit): Mark with NO_RETURN.
14526 * image.c (clear_image_cache): Now static.
14527 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
14528 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
14529 (x_edge_detection): Remove unnecessary cast that
14530 gcc -Wbad-function-cast diagnoses.
14531 (gif_load): Fix pointer signedness.
14532 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14533 (jpeg_load, gif_load): Rename locals to avoid shadowing.
14535 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
14537 Improve quality of tests for time stamp overflow.
14538 For example, without this patch (encode-time 0 0 0 1 1
14539 1152921504606846976) returns the obviously-bogus value (-948597
14540 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14541 reports time overflow. See
14542 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
14543 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14544 * editfns.c: Include limits.h and intprops.h.
14545 (TIME_T_MIN, TIME_T_MAX): New macros.
14546 (time_overflow): Move earlier, to before first use.
14547 (hi_time, lo_time): New functions, for an accurate test for
14548 out-of-range times.
14549 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14550 (Fget_internal_run_time): Don't assume time_t fits in int.
14551 (make_time): Use list2 instead of Fcons twice.
14552 (Fdecode_time): More accurate test for out-of-range times.
14553 (check_tm_member): New function.
14554 (Fencode_time): Use it, to test for out-of-range times.
14555 (lisp_time_argument): Don't rely on undefined left-shift and
14556 right-shift behavior when checking for time stamp overflow.
14558 * editfns.c (time_overflow): New function, refactoring common code.
14559 (Fformat_time_string, Fdecode_time, Fencode_time):
14560 (Fcurrent_time_string): Use it.
14562 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14563 * dired.c (make_time): Move to ...
14564 * editfns.c (make_time): ... here.
14565 * systime.h: Note the move.
14567 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14569 * fringe.c (update_window_fringes): Remove unused variables.
14571 * unexmacosx.c (copy_data_segment): Also copy __got section.
14574 2011-03-12 Eli Zaretskii <eliz@gnu.org>
14576 * termcap.c [MSDOS]: Include "msdos.h".
14577 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14578 Constify `char *' arguments and their references according to
14579 prototypes in tparam.h.
14581 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
14583 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14584 Adapt all references accordingly.
14586 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14588 2011-03-11 Tom Tromey <tromey@redhat.com>
14590 * buffer.c (syms_of_buffer): Remove obsolete comment.
14592 2011-03-11 Eli Zaretskii <eliz@gnu.org>
14594 * termhooks.h (encode_terminal_code): Declare prototype.
14596 * msdos.c (encode_terminal_code): Don't declare prototype.
14598 * term.c (encode_terminal_code): Now external again, used by
14599 w32console.c and msdos.c.
14601 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14602 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
14604 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
14606 Fix some minor problems found by GCC 4.5.2's static checks.
14608 * fringe.c (update_window_fringes): Mark locals as initialized
14610 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
14612 * alloc.c (mark_fringe_data): Move decl from here ...
14613 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14614 to check its interface.
14615 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14617 * fontset.c (free_realized_fontset): Now static.
14618 (Fset_fontset_font): Rename local to avoid shadowing.
14619 (fontset_font): Mark local as initialized.
14620 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
14622 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14624 * xselect.c (x_disown_buffer_selections): Remove; not used.
14625 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
14626 (x_own_selection, Fx_disown_selection_internal): Rename locals
14627 to avoid shadowing.
14628 (x_handle_dnd_message): Remove local to avoid shadowing.
14630 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14631 so that the caller can use some name other than gcpro1.
14632 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
14633 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14634 (Fx_backspace_delete_keys_p):
14635 Use them to avoid shadowing, and rename vars to avoid shadowing.
14636 (x_decode_color, x_set_name, x_window): Now static.
14637 (Fx_create_frame): Add braces to silence GCC warning.
14638 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
14639 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14640 Remove unused locals.
14641 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14642 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14643 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14646 * xterm.h (x_mouse_leave): New decl.
14648 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14649 Remove unused functions.
14650 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14651 (x_calc_absolute_position): Now static.
14652 (XTread_socket): Don't define label "out" unless it's used.
14653 Don't declare local "event" unless it's used.
14654 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14655 unless they are used.
14656 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14657 (x_fatal_error_signal): Remove; not used.
14658 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14659 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14660 (x_error_catcher, x_connection_closed, x_error_handler):
14661 (x_error_quitter, xembed_send_message, x_iconify_frame):
14662 (my_log_handler): Rename locals to avoid shadowing.
14663 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
14664 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
14666 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14667 Rename or move locals to avoid shadowing.
14668 (tty_defined_color, merge_face_heights): Now static.
14669 (free_realized_faces_for_fontset): Remove; not used.
14670 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14671 does not deduce is never used uninitialized.
14672 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14673 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
14675 * terminal.c (store_terminal_param): Now static.
14677 * xmenu.c (menu_highlight_callback): Now static.
14678 (set_frame_menubar): Remove unused local.
14679 (xmenu_show): Rename parameter to avoid shadowing.
14680 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14681 since they might point to immutable storage.
14682 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14683 since it's unused otherwise.
14685 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
14686 Add a FIXME, since the code still doesn't look right. (Bug#8215)
14687 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14688 avoids a gcc -Wuninitialized diagnostic.
14689 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
14690 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14691 does not deduce are never used uninitialized.
14693 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14695 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
14696 * window.c (window_loop, size_window):
14697 (run_window_configuration_change_hook, enlarge_window): Likewise.
14699 * window.c (display_buffer): Now static.
14700 (size_window): Mark variables that gcc -Wuninitialized
14701 does not deduce are never used uninitialized.
14702 * window.h (check_all_windows): New decl, to forestall
14703 gcc -Wmissing-prototypes diagnostic.
14704 * dispextern.h (bidi_dump_cached_states): Likewise.
14706 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14708 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
14709 Include <limits.h>.
14710 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14711 and to avoid gcc -Wuninitialized warning.
14712 (load_charset_map): Mark variables that gcc -Wuninitialized
14713 does not deduce are never used uninitialized.
14714 (load_charset): Abort instead of using uninitialized var (Bug#8229).
14716 * coding.c (coding_set_source, coding_set_destination):
14717 Use "else { /* comment */ }" rather than "else /* comment */;"
14718 for clarity, and to avoid gcc -Wempty-body warning.
14719 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14720 a block, when the outer 'i' will do.
14721 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14722 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14723 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14724 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14725 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14726 Rename locals to avoid shadowing.
14727 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
14728 * coding.c (emacs_mule_char, encode_invocation_designation):
14729 Now static, since they're not used elsewhere.
14730 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
14731 (decode_coding_object, encode_coding_object, detect_coding_system):
14732 (decode_coding_emacs_mule): Mark variables that gcc
14733 -Wuninitialized does not deduce are never used uninitialized.
14734 (detect_coding_iso_2022): Initialize a local variable that might
14735 be used uninitialized. Leave a FIXME because it's not clear that
14736 this initialization is needed. (Bug#8211)
14737 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14738 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14739 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14740 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14741 Remove unused macros.
14743 * category.c (hash_get_category_set): Remove unused local var.
14744 (copy_category_table): Now static, since it's not used elsewhere.
14745 * character.c (string_count_byte8): Likewise.
14747 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14748 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14750 * chartab.c (copy_sub_char_table): Now static, since it's not used
14752 (sub_char_table_ref_and_range, char_table_ref_and_range):
14753 Rename locals to avoid shadowing.
14754 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
14756 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
14757 (BIDI_BOB): Remove unused macro.
14759 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14760 deduce are never used uninitialized.
14761 * term.c (encode_terminal_code): Likewise.
14763 * term.c (encode_terminal_code): Now static. Remove unused local.
14765 * tparam.h: New file.
14766 * term.c, tparam.h: Include it.
14767 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14768 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14769 Move these decls to tparam.h, and make them agree with what
14770 is actually in tparam.c. The previous trick of using incompatible
14771 decls in different modules does not conform to the C standard.
14772 All callers of tparam changed to use tparam's actual API.
14773 * tparam.c (tparam1, tparam, tgoto):
14774 Use const pointers where appropriate.
14776 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14777 * cm.h (struct cm): Likewise.
14778 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14779 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14780 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14781 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14782 (turn_on_face, init_tty): Likewise.
14783 * termchar.h (struct tty_display_info): Likewise.
14785 * term.c (term_mouse_position): Rename local to avoid shadowing.
14787 * alloc.c (mark_ttys): Move decl from here ...
14788 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14790 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14792 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14794 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
14796 * search.c (compile_pattern_1): Remove argument regp, unused since
14797 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14798 (compile_pattern): Don't pass it.
14800 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14802 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14803 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14805 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14807 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14809 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14810 gdk_window_get_screen, gdk_window_get_geometry,
14811 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14812 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14813 (xg_get_pixbuf_from_pixmap): New function.
14814 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14815 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14816 Call xg_get_pixbuf_from_pixmap instead of
14817 gdk_pixbuf_get_from_drawable.
14818 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14819 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14820 (xg_check_special_colors): Use GtkStyleContext and its functions
14822 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14823 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14824 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
14825 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14826 Call gtk_widget_get_preferred_size.
14827 (xg_frame_resized): gdk_window_get_geometry only takes 5
14829 (xg_win_to_widget, xg_event_is_for_menubar):
14830 Call gdk_x11_window_lookup_for_display.
14831 (xg_set_widget_bg): New function.
14832 (delete_cb): New function.
14833 (xg_create_frame_widgets): Connect delete-event to delete_cb.
14834 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
14835 (xg_set_background_color): Call xg_set_widget_bg.
14836 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14837 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14838 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14839 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14841 (update_frame_tool_bar): Call gtk_widget_hide.
14842 (xg_initialize): Use GDK_KEY_g.
14844 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14846 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14848 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14849 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14850 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14852 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
14854 * w32xfns.c (select_palette): Check success of RealizePalette against
14855 GDI_ERROR, not zero.
14857 See ChangeLog.11 for earlier changes.
14859 ;; Local Variables:
14863 Copyright (C) 2011-2012 Free Software Foundation, Inc.
14865 This file is part of GNU Emacs.
14867 GNU Emacs is free software: you can redistribute it and/or modify
14868 it under the terms of the GNU General Public License as published by
14869 the Free Software Foundation, either version 3 of the License, or
14870 (at your option) any later version.
14872 GNU Emacs is distributed in the hope that it will be useful,
14873 but WITHOUT ANY WARRANTY; without even the implied warranty of
14874 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14875 GNU General Public License for more details.
14877 You should have received a copy of the GNU General Public License
14878 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.