1 2011-08-28 Johan Bockgård <bojohan@gnu.org>
3 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6 2011-08-27 Eli Zaretskii <eliz@gnu.org>
8 * xdisp.c (move_it_to): Don't bail out early when reaching
9 position beyond to_charpos, if we are scanning backwards.
10 (move_it_vertically_backward): When DY == 0, make sure we get to
11 the first character in the line after the newline.
13 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
15 * ccl.c: Improve and simplify overflow checking (Bug#9196).
16 (ccl_driver): Do not generate an out-of-range pointer.
17 (Fccl_execute_on_string): Remove unnecessary check for
18 integer overflow, noted by Stefan Monnier in
19 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
20 Remove a FIXME that didn't need fixing.
21 Simplify the newly-introduced buffer reallocation code.
23 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
25 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
27 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
29 Integer and memory overflow issues (Bug#9196).
31 * doc.c (get_doc_string): Rework so that
32 get_doc_string_buffer_size is the actual buffer size, rather than
33 being 1 less than the actual buffer size; this makes xpalloc more
36 * image.c (x_allocate_bitmap_record, cache_image):
37 * xselect.c (Fx_register_dnd_atom):
38 Simplify previous changes by using xpalloc.
40 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
41 since either will do and ptrdiff_t is convenient with xpalloc.
43 * charset.c (charset_table_size)
44 (struct charset_sort_data.priority): Now ptrdiff_t.
45 (charset_compare): Don't overflow if priorities differ greatly.
46 (Fsort_charsets): Don't assume list length fits in int.
47 Check for size-calculation overflow when allocating sort data.
48 (syms_of_charset): Allocate an initial charset table that is
49 just under 64 KiB, to avoid problems with glibc malloc and mmap.
51 * cmds.c (internal_self_insert): Check for size-calculation overflow.
53 * composite.h (struct composition.glyph_len): Now int, not unsigned.
54 The actual value is always <= INT_MAX, and leaving it unsigned made
55 overflow checking harder.
57 * dispextern.h (struct glyph_matrix.rows_allocated)
58 (struct face_cache.size): Now ptrdiff_t, for convenience in use
59 with xpalloc. The values are still always <= INT_MAX.
61 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
63 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
64 (SAFE_NALLOCA): New macro.
66 * region-cache.c (struct boundary.pos, find_cache_boundary)
67 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
68 (set_cache_region, invalidate_region_cache)
69 (revalidate_region_cache, know_region_cache, region_cache_forward)
70 (region_cache_backward, pp_cache):
71 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
72 so that ptrdiff_t * can be passed to xpalloc.
73 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
74 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
75 (pp_cache): Don't assume cache_len fits in int.
76 * region-cache.h: Adjust extern decls to match.
78 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
79 EMACS_INT, since either will do, for xpalloc.
81 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
82 (xnmalloc, xnrealloc, xpalloc): New functions.
84 * bidi.c (bidi_shelve_header_size): New constant.
85 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
86 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
88 * bidi.c (bidi_cache_shrink):
89 * buffer.c (overlays_at, overlays_in, record_overlay_string)
91 Don't update size of array until after memory allocation succeeds,
92 because xmalloc/xrealloc may not return.
93 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
94 now that we have proper integer overflow checking.
95 (record_overlay_string, overlay_strings): Catch overflows when
96 calculating size of overlay_str_buf.
98 * callproc.c (Fcall_process): Check for size overflow when
99 calculating size of args2.
100 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
101 Normally we prefer signed values, but sticking with ptrdiff_t would
102 require adding more-complicated checks.
104 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
105 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
106 Redo buffer-overflow calculations to avoid integer overflow.
107 Add a FIXME comment where memory seems to be over-allocated.
109 * character.c (Fstring): Check for size-calculation overflow.
111 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
112 unnecessary integer overflow. Check for size overflow.
113 (encode_coding_object): Don't update size until xmalloc succeeds.
115 * composite.c (get_composition_id): Check for overflow in glyph
118 Integer and memory overflow fixes for display code.
119 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
120 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
121 (scrolling_window): Check for overflow in size calculations.
122 (line_draw_cost, realloc_glyph_pool, add_row_entry):
123 Don't assume glyph table len fits in int.
124 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
125 (row_table_size): Now ptrdiff_t, not int.
126 (scrolling_window): Avoid overflow in size calculations.
127 Don't update size until allocation succeeds.
128 * fns.c (concat): Check for overflow in size calculations.
129 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
130 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
131 (NEXT_ALMOST_PRIME_LIMIT): New constant.
133 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
134 (get_doc_string): Check for size calculation overflow.
135 Don't update size until allocation succeeds.
136 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
137 EMACS_INT, where ptrdiff_t will do.
138 (Fsubstitute_command_keys): Check for string overflow.
140 * editfns.c (set_time_zone_rule): Don't assume environment length
142 (message_length): Now ptrdiff_t, not int.
143 (Fmessage_box): Don't update size until allocation succeeds.
144 Don't assume message length fits in int.
145 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
147 * emacs.c (main): Do not reallocate argv, since there is a null at
148 the end that can be overwritten, and this way there's no need to
149 worry about size-calculation overflow.
150 (sort_args): Check for size-calculation overflow.
152 * eval.c (init_eval_once, grow_specpdl): Don't update size until
154 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
156 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
157 (x_set_scroll_bar_width, x_figure_window_size):
158 Check for integer overflow.
159 (x_set_alpha): Do not assume XINT fits in int.
161 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
162 This is for the members text_lines, text_cols, total_lines, total_cols,
163 where the system imposes an 'int' limit.
165 * fringe.c (Fdefine_fringe_bitmap):
166 Don't update size until alloc works.
168 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
169 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
171 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
172 Check for size-calculation overflow.
173 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
174 do, as we prefer signed integers.
175 (id_to_widget.max_size, id_to_widget.used)
176 (xg_store_widget_in_map, xg_remove_widget_from_map)
177 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
178 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
179 Use and return ptrdiff_t, not int.
180 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
181 * gtkutil.h: Change prototypes to match the above.
183 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
184 are duplicate now that they've been promoted to lisp.h.
185 (x_allocate_bitmap_record, x_alloc_image_color)
186 (make_image_cache, cache_image, xpm_load):
187 Don't update size until alloc is done.
188 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
190 Check for size calculation overflow.
191 (ct_colors_allocated_max): New constant.
192 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
195 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
196 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
197 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
198 Use ptrdiff_t, not int, to count maps.
199 (read_char_minibuf_menu_prompt): Check for overflow in size
200 calculations. Don't update size until allocation succeeds. Redo
201 calculations to avoid overflow.
202 * keyboard.h: Change prototypes to match the above.
204 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
206 (current_minor_maps): Check for size calculation overflow.
207 * keymap.h: Change prototypes to match the above.
209 * lread.c (read1, init_obarray): Don't update size until alloc done.
211 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
212 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
214 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
215 Now ptrdiff_t, not int.
216 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
217 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
219 * process.c (Fnetwork_interface_list): Check for overflow
222 * region-cache.c (move_cache_gap): Check for size calculation overflow.
224 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
225 overflow. Don't bother calling xmalloc when xrealloc will do.
227 * search.c (Freplace_match): Check for size calculation overflow.
228 (Fset_match_data): Don't assume list lengths fit in 'int'.
230 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
231 for command line length. Do not attempt to address one before the
232 beginning of an array, as that's not portable.
234 * term.c (max_frame_lines): Remove; unused.
235 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
237 (encode_terminal_code, calculate_costs): Check for size
238 calculation overflow.
239 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
240 table lengths and related sizes. Don't update size until alloc
241 done. Redo calculations to avoid overflow.
242 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
244 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
245 subtracting pointers.
246 (gobble_line): Check for overflow more carefully. Don't update size
249 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
250 Don't update size until alloc done.
251 Redo size calculations to avoid overflow.
252 Check for size calculation overflow.
253 (main) [DEBUG]: Fix typo in invoking tparam1.
255 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
256 Use ptrdiff_t, not int, for sizes.
257 (store_mode_line_noprop_char): Don't update size until alloc done.
259 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
260 Use ptrdiff_t, not int, for sizes.
261 (Finternal_make_lisp_face, cache_face):
262 Check for size calculation overflow.
263 (cache_face): Treat size calculation overflows as if they were
264 memory exhaustion (the usual treatment), rather than aborting.
266 * xfns.c (x_encode_text, x_set_name_internal)
267 (Fx_change_window_property): Use ptrdiff_t, not int, to count
268 sizes, since they can exceed INT_MAX in size. Check for size
269 calculation overflow.
271 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
272 (xg_select): Check for size calculation overflow.
273 Don't update size until alloc done.
275 * xrdb.c (get_environ_db): Don't assume path length fits in int,
276 as sprintf is limited to int lengths.
278 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
279 (X_LONG_MIN): New macros.
280 Use them to make the following changes clearer.
281 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
282 This change doesn't affect the value now, but it may help remind
283 future maintainers not to raise the value too much later.
284 (SELECTION_QUANTUM): Remove, replacing with ...
285 (selection_quantum): ... new function, which avoids overflow.
287 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
288 assumption that selection length fits in 'int'.
289 (x_reply_selection_request, x_handle_selection_request)
290 (x_get_window_property, receive_incremental_selection)
291 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
292 (lisp_data_to_selection_data, clean_local_selection_data):
293 Use ptrdiff_t, not int, to record length of selection.
294 (x_reply_selection_request, x_get_window_property)
295 (receive_incremental_selection, x_property_data_to_lisp):
296 Redo calculations to avoid overflow.
297 (x_reply_selection_request): When sending hint, ceiling it at
298 X_LONG_MAX rather than relying on wraparound overflow to send
300 (x_get_window_property, receive_incremental_selection)
301 (lisp_data_to_selection_data, x_property_data_to_lisp):
302 Check for size-calculation overflow.
303 (x_get_window_property, receive_incremental_selection)
304 (lisp_data_to_selection_data, Fx_register_dnd_atom):
305 Don't store size until memory allocation succeeds.
306 (x_get_window_property): Plug memory leak on memory exhaustion.
307 Don't double-block input; malloc is safe here. Don't assume 2**34
308 - 4 fits in unsigned long. Add an xassert to check
309 XGetWindowProperty overflow. Be more careful about overflow
310 calculations, and distinguish size from memory overflow better.
311 (receive_incremental_selection): When tracing, don't assume
312 unsigned int is less than INT_MAX.
313 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
314 harmful) conversions of unsigned short to int.
315 (lisp_data_to_selection_data): Don't assume that integers
316 in the range -65535 through -1 fit in an X unsigned short.
317 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
318 result parameters unless successful. Rely on cons_to_unsigned
319 to report problems with elements; the old code wasn't right anyway.
320 (x_check_property_data): Check for int overflow; we cannot use
321 a wider type due to X limits.
322 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
324 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
326 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
327 (x_term_init): Check for size calculation overflow.
328 (x_color_cells): Don't store size until memory allocation succeeds.
329 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
330 Don't assume alloca size is less than MAX_ALLOCA.
331 (x_term_init): Don't assume length fits in int (sprintf is limited
334 Use ptrdiff_t for composition IDs.
335 * character.c (lisp_string_width):
336 * composite.c (composition_table_size, n_compositions)
337 (get_composition_id, composition_gstring_from_id):
338 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
339 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
340 * window.c (Frecenter):
341 Use ptrdiff_t, not int, for composition IDs.
342 * composite.c (get_composition_id): Check for integer overflow.
343 * composite.h: Adjust prototypes to match the above changes.
345 Use ptrdiff_t for hash table indexes.
346 * category.c (hash_get_category_set):
347 * ccl.c (ccl_driver):
348 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
349 * coding.c (coding_system_charset_list, detect_coding_system):
350 * coding.h (struct coding_system.id):
351 * composite.c (get_composition_id, gstring_lookup_cache):
352 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
353 * image.c (xpm_get_color_table_h):
354 * lisp.h (hash_lookup, hash_put):
355 * minibuf.c (Ftest_completion):
356 Use ptrdiff_t for hash table indexes, not int (which is too
357 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
358 32-bit --with-wide-int hosts).
360 * charset.c (Fdefine_charset_internal): Check for integer overflow.
361 Add a FIXME comment about memory leaks.
362 (syms_of_charset): Don't assume xmalloc returns.
364 Don't assume that stated character widths fit in int.
365 * character.c (Fchar_width, c_string_width, lisp_string_width):
366 * character.h (CHAR_WIDTH):
367 * indent.c (MULTIBYTE_BYTES_WIDTH):
368 Use sanitize_char_width to avoid undefined and/or bad behavior
369 with outlandish widths.
370 * character.h (sanitize_tab_width): Renamed from sanitize_width,
371 now that we have two such functions. All uses changed.
372 (sanitize_char_width): New inline function.
374 Don't assume that tab-width fits in int.
375 * character.h (sanitize_width): New inline function.
376 (SANE_TAB_WIDTH): New macro.
377 (ASCII_CHAR_WIDTH): Use it.
378 * indent.c (sane_tab_width): Remove. All uses replaced by
379 SANE_TAB_WIDTH (current_buffer).
380 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
382 * fileio.c: Integer overflow issues with file modes.
383 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
385 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
386 Remove unreachable code.
387 (read_hex, load_charset_map_from_file): Check for integer overflow.
389 * xterm.c: don't go over XClientMessageEvent limit
390 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
391 (x_send_scroll_bar_event): Likewise. Check that the size does not
392 exceed limits imposed by XClientMessageEvent, as well as the usual
393 ptrdiff_t and size_t limits.
395 * keyboard.c: Overflow, signedness and related fixes.
396 (make_lispy_movement): Use same integer type in forward decl
397 that is used in the definition.
398 (read_key_sequence, keyremap_step):
399 Change bufsize argument back to int, undoing my 2011-03-30 change.
400 We prefer signed types, and int is wide enough here.
401 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
402 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
403 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
404 length, not size_t. Use ptrdiff_t for index, not int.
405 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
406 possibility of integer overflow.
408 Overflow, signedness and related fixes for images.
410 * dispextern.h (struct it.stack[0].u.image.image_id)
411 (struct_it.image_id, struct image.id, struct image_cache.size)
412 (struct image_cache.used, struct image_cache.ref_count):
413 * gtkutil.c (update_frame_tool_bar):
414 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
415 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
416 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
417 * nsmenu.m (update_frame_tool_bar):
418 * xdisp.c (calc_pixel_width_or_height):
419 * xfns.c (image_cache_refcount):
420 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
421 on typical 64-bit hosts.
423 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
424 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
425 Omit unnecessary casts to int.
426 (parse_image_spec): Check that integers fall into 'int' range
427 when the callers expect that.
428 (image_ascent): Redo ascent calculation to avoid int overflow.
429 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
430 (lookup_image): Remove unnecessary tests.
431 (xbm_image_p): Locals are now of int, not EMACS_INT,
432 since parse_image_check makes sure they fit into int.
433 (png_load, gif_load, svg_load_image):
434 Prefer int to unsigned where either will do.
435 (tiff_handler): New function, combining the cores of the
436 old tiff_error_handler and tiff_warning_handler. This
437 function is rewritten to use vsnprintf and thereby avoid
438 stack buffer overflows. It uses only the features of vsnprintf
439 that are common to both POSIX and native Microsoft.
440 (tiff_error_handler, tiff_warning_handler): Use it.
441 (tiff_load, gif_load, imagemagick_load_image):
442 Don't assume :index value fits in 'int'.
443 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
444 (imagemagick_load_image): Check that crop parameters fit into
445 the integer types that MagickCropImage accepts. Don't assume
446 Vimagemagick_render_type has a nonnegative value. Don't assume
447 size_t fits in 'long'.
448 (gs_load): Use printmax_t to print the widest integers possible.
449 Check for integer overflow when computing image height and width.
451 2011-08-26 Eli Zaretskii <eliz@gnu.org>
453 * xdisp.c (redisplay_window): Don't force window start if point
454 will be invisible in the resulting window. (Bug#9324)
456 2011-08-25 Eli Zaretskii <eliz@gnu.org>
458 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
459 the display spec is of the form `(space ...)'.
460 (handle_display_spec): Return the value returned by
461 handle_single_display_spec, not just 1 or zero.
462 (handle_single_display_spec): If the display spec is of the form
463 `(space ...)', and specifies display in the text area, return 2
465 (try_cursor_movement): Check for the need to scroll more
466 accurately, and prefer exact match for point under bidi. Don't
467 advance `row' beyond the last row of the window.
469 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
470 into disp_prop; all users changed.
472 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
473 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
474 for the text covered by the display property.
476 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
478 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
479 Change return value to nil.
480 (Frecord_buffer): Delete unused function.
482 2011-08-24 Eli Zaretskii <eliz@gnu.org>
484 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
485 buffers, return left-to-right.
486 (set_cursor_from_row): Consider candidate row a win if its glyph
487 represents a newline and point is on that newline. Fixes cursor
488 positioning on the newline at EOL of R2L text within L2R
489 paragraph, and vice versa.
490 (try_cursor_movement): Check continued rows, in addition to
491 continuation rows. Fixes unwarranted scroll when point enters a
492 continued line of R2L text within an L2R paragraph, or vice versa.
493 (cursor_row_p): Consider the case of point being equal to
494 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
495 from the end of a short line to the beginning of a continued line
496 of R2L text within L2R paragraph.
497 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
500 * bidi.c (bidi_check_type): Use xassert.
501 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
504 2011-08-23 Eli Zaretskii <eliz@gnu.org>
506 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
509 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
511 * nsfont.m (ns_otf_to_script): Fix typo.
513 2011-08-22 Kenichi Handa <handa@m17n.org>
515 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
516 extra slot even if the purpose is char-code-property-table.
518 2011-08-23 Eli Zaretskii <eliz@gnu.org>
520 * xdisp.c (redisplay_window): When computing centering_position,
521 account for the height of the header line. (Bug#8874)
523 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
524 instead of CHAR_TO_BYTE. Fixes a crash when a completion
525 candidate is selected by the mouse, and that candidate has a
526 composed character under the mouse.
528 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
529 coordinates reported by pos-visible-in-window-p for a composed
530 character in column zero.
532 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
534 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
536 2011-08-22 Eli Zaretskii <eliz@gnu.org>
538 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
539 consider it a hit if to_charpos is anywhere in the range of the
540 composed buffer positions.
542 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
544 * image.c (gif_load): Don't assume that each subimage has the same
545 dimensions as the base image. Handle disposal method that is
546 "undefined" by the gif spec (Bug#9335).
548 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
550 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
551 (Fcondition_case): Document `debug' symbol in error handler.
553 2011-08-19 Eli Zaretskii <eliz@gnu.org>
555 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
556 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
557 from an Org mode buffer to a Speedbar frame.
559 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
560 a composition, take its buffer position from IT->cmp_it.charpos.
561 Fixes cursor positioning at the beginning of a line that begins
562 with a composed character.
564 2011-08-18 Eli Zaretskii <eliz@gnu.org>
566 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
567 character bidirectional type, use STRONG_L instead. Fixes crashes
568 in a buffer produced by `describe-categories'.
570 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
571 members before the level stack, so they would be saved and
572 restored when copying iterator state. Fixes incorrect reordering
573 around TABs covered by display properties.
575 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
577 * process.c (Fnetwork_interface_list): Correctly determine buffer
580 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
582 * eval.c (internal_condition_case, internal_condition_case_1)
583 (internal_condition_case_2, internal_condition_case_n):
584 Remove unnecessary aborts (Bug#9081).
586 2011-08-17 Eli Zaretskii <eliz@gnu.org>
588 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
589 has no `load' handler, try opening the file locally. (Bug#9311)
591 2011-08-16 Ken Brown <kbrown@cornell.edu>
593 * gmalloc.c: Expand comment.
595 2011-08-16 Eli Zaretskii <eliz@gnu.org>
597 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
598 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
600 2011-08-16 Ken Brown <kbrown@cornell.edu>
602 Fix memory allocation problems in Cygwin build (Bug#9273).
604 * unexcw.c ( __malloc_initialized): Declare external variable.
605 (fixup_executable): Force the dumped emacs to reinitialize malloc.
607 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
609 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
611 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
613 [CYGWIN] (special_realloc): New function.
614 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
615 requests to realloc storage in the static heap.
617 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
619 * bidi.c (bidi_initialize): Remove unused local.
621 2011-08-15 Eli Zaretskii <eliz@gnu.org>
623 * biditype.h: File removed.
625 * bidimirror.h: File removed.
627 * deps.mk (bidi.o): Remove biditype.h and
630 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
633 * dispextern.h: Fix a typo in the comment to bidi_type_t.
635 * chartab.c: Improve commentary for the uniprop_table API.
637 * bidi.c (bidi_paragraph_init): Support zero value of
638 bidi_ignore_explicit_marks_for_paragraph_level.
639 (bidi_initialize): Use uniprop_table instead of including
640 biditype.h and bidimirror.h.
642 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
643 coordinates of the iterator when restoring from ppos_it.
646 2011-08-14 Kenichi Handa <handa@m17n.org>
648 * process.c (create_process): Call setup_process_coding_systems
649 after the pid of the process is set to -1 (Bug#8162).
651 2011-08-14 Eli Zaretskii <eliz@gnu.org>
653 * xdisp.c (move_it_in_display_line_to): Don't invoke
654 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
655 ppos_it. Fixes vertical cursor motion when line beginning is
656 covered by an image. (Bug#9296)
658 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
660 * nsterm.h (ns_run_ascript): Declare.
661 (NSAPP_DATA2_RUNASSCRIPT): Define.
663 * nsfns.m (as_script, as_result, as_status): New static variables.
664 (ns_run_ascript): New function.
665 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
666 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
667 the event loop. Get status from as_status (Bug#7276).
669 * nsterm.m (sendEvent): If event is NSApplicationDefined and
670 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
671 the event loop (Bug#7276).
673 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
675 * gnutls.c (QCgnutls_bootprop_priority)
676 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
677 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
678 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
679 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
680 (QCgnutls_bootprop_verify_hostname_error)
681 (QCgnutls_bootprop_callbacks_verify): Rename from
682 Qgnutls_bootprop_..., all uses changed.
684 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
687 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
689 * xfaces.c (Qframe_set_background_mode): Now static.
690 * dispextern.h (Qframe_set_background_mode): Remove decl.
692 * process.c (Fnetwork_interface_info): Declare local only if needed.
694 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
696 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
697 (Fnetwork_interface_list): Allocate in increments of bytes instead
698 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
699 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
701 (struct ifflag_def): notrailers is smart on OSX.
702 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
703 Get hardware address with getifaddrs if available.
705 2011-08-12 Eli Zaretskii <eliz@gnu.org>
707 * xdisp.c (iterate_out_of_display_property): xassert that
708 IT->position is set to within IT->object's boundaries. Break from
709 the loop as soon as EOB is reached; avoids infloops in redisplay
710 when IT->position is set up wrongly due to some bug.
711 Set IT->current to match the bidi iterator unconditionally.
712 (push_display_prop): Allow GET_FROM_STRING as IT->method on
713 entry. Force push_it to save on the stack the current
714 buffer/string position, to be restored by pop_it. Fix flags in
715 the iterator structure wrt the object coming from a display
716 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
717 properties. (Bug#9284)
719 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
721 * fontset.c (fontset_get_font_group): Add proper type checks.
724 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
726 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
727 and LC_VERSION_MIN_MACOSX.
728 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
729 (dump_it) [LC_FUNCTION_STARTS]: Use it.
731 2011-08-08 Eli Zaretskii <eliz@gnu.org>
733 * xdisp.c (forward_to_next_line_start): Allow to use the
734 no-display-properties-and-no-overlays under bidi display.
735 Set disp_pos in the bidi iterator to avoid searches for display
736 properties and overlays.
738 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
740 * editfns.c (Fset_time_zone_rule): Document relationship with the
743 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
744 the font entity extracted from the cache (Bug#8109).
746 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
748 * composite.c (autocmp_chars): Don't reset point. That is done by
749 restore_point_unwind (Bug#5984).
751 2011-08-07 Juri Linkov <juri@jurta.org>
753 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
754 to show the arg `TIME' instead of `TIMEVAL'.
756 2011-08-06 Eli Zaretskii <eliz@gnu.org>
758 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
759 display property strides EOL and includes a newline, as in
760 longlines-mode. (Bug#9254)
761 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
762 word-wrap under bidirectional display. (Bug#9224)
764 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
765 is non-zero, even if the data buffer is NULL. Fixes a crash in
766 vertical-motion with longlines-mode. (Bug#9254)
768 2011-08-05 Eli Zaretskii <eliz@gnu.org>
770 * bidi.c <bidi_cache_total_alloc>: Now static.
771 (bidi_initialize): Initialize bidi_cache_total_alloc.
773 * xdisp.c (display_line): Release buffer allocated for shelved bidi
776 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
777 amount allocated this far in `bidi_cache_total_alloc'.
778 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
779 non-zero, only free the data buffer without restoring the cache
780 contents. All callers changed.
782 * dispextern.h (bidi_unshelve_cache): Update prototype.
784 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
785 (move_it_in_display_line, move_it_to)
786 (move_it_vertically_backward, move_it_by_lines): Replace the call
787 to xfree to an equivalent call to bidi_unshelve_cache.
788 (move_it_in_display_line_to): Fix logic of returning
789 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
791 2011-08-05 Eli Zaretskii <eliz@gnu.org>
793 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
794 came from a string character with a `cursor' property. (Bug#9229)
796 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
798 * Makefile.in (LIB_PTHREAD): New variable.
799 (LIBES): Add LIB_PTHREAD (Bug#9216).
801 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
802 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
804 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
806 * regex.c (re_iswctype): Remove some redundant boolean
809 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
811 * xterm.c (x_find_topmost_parent): New function.
812 (x_set_frame_alpha): Find topmost parent window with
813 x_find_topmost_parent and set the property there also (bug#9181).
814 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
816 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
818 * callproc.c (Fcall_process): Avoid vfork clobbering
819 the local vars buffer, coding_systems, current_dir.
821 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
823 * keymap.c (Fmake_composed_keymap): Move to subr.el.
825 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
827 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
828 so that it is not optimized away.
830 * xdisp.c (compute_display_string_pos): Remove unused local.
832 2011-08-02 Eli Zaretskii <eliz@gnu.org>
834 Fix slow cursor motion and scrolling in large buffers with
835 selective display, like Org Mode buffers. (Bug#9218)
837 * dispextern.h (struct bidi_it): New member disp_prop_p.
839 * xdisp.c: Remove one-slot cache of display string positions.
840 (compute_display_string_pos): Accept an additional argument
841 DISP_PROP_P; callers changed. Scan at most 5K characters forward
842 for a display string or property. If found, set DISP_PROP_P
845 * bidi.c (bidi_fetch_char): Accept an additional argument
846 DISP_PROP_P, and pass it to compute_display_string_pos.
847 Only handle text covered by a display string if DISP_PROP_P is returned
848 non-zero. All callers of bidi_fetch_char changed.
850 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
852 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
854 2010-12-03 Don March <don@ohspite.net>
856 * keymap.c (Fdefine_key): Fix non-prefix key error message when
857 last character M-[char] is translated to ESC [char] (bug#7541).
859 2011-08-02 Kenichi Handa <handa@m17n.org>
861 * lisp.h (uniprop_table): Extern it.
863 * chartab.c (uniprop_table): Make it non-static.
865 2011-08-01 Eli Zaretskii <eliz@gnu.org>
867 * xdisp.c (forward_to_next_line_start): Accept additional argument
868 BIDI_IT_PREV, and store into it the state of the bidi iterator had
870 (reseat_at_next_visible_line_start): Use the bidi iterator state
871 returned by forward_to_next_line_start to restore the state of
872 it->bidi_it after backing up to previous newline. (Bug#9212)
874 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
876 * regex.c (re_comp): Protoize.
877 (re_exec): Fix return type.
878 (regexec): Fix type of `ret'. (Bug#9203)
880 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
882 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
883 This is needed if max-image-size is a floating-point number.
885 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
887 * print.c (print_object): Print empty symbol as ##.
889 * lread.c (read1): Read ## as empty symbol.
891 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
893 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
894 setting frame foreground color (Bug#9175).
895 (x_set_background_color): Likewise.
897 * nsmenu.m (-setText): Size tooltip dimensions precisely to
899 (EmacsTooltip -init): Remove bezels and add shadows to
902 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
903 or scroll bar (Bug#8470).
905 * nsfont.m (nsfont_open): Remove assignment to voffset and
906 unnecessary vars hshink, expand, hd, full_height, min_height.
907 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
909 * nsterm.h (nsfont_info): Remove voffset field.
911 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
913 Implement strike-through and overline on NextStep (Bug#8863).
915 * nsfont.m (nsfont_open): Use underline position provided by font,
916 instead of hard-coded value of 2.
917 (nsfont_draw): Call ns_draw_text_decoration instead.
919 * nsterm.h: Add declaration for ns_draw_text_decoration.
921 * nsterm.m (ns_draw_text_decoration): New function for drawing
922 underline, overline, and strike-through.
923 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
924 ns_draw_text_decoration. Change treatment of cursor drawing to
925 accomodate underlining, etc.
927 2011-07-28 Eli Zaretskii <eliz@gnu.org>
929 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
932 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
934 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
935 Without this fix, if a signal arrives just after memory fills up,
936 'malloc' might be invoked reentrantly.
938 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
939 In other words, assume that every image size is allowed, on non-X
940 hosts. This assumption is probably wrong, but it lets Emacs compile.
942 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
944 * regex.c (re_iswctype): Convert return values to boolean.
946 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
948 * xdisp.c (compute_display_string_pos): Don't use cached display
949 string position if the buffer had its restriction changed.
952 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
954 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
956 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
958 Integer signedness and overflow and related fixes. (Bug#9079)
960 * bidi.c: Integer size and overflow fixes.
961 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
962 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
963 (bidi_cache_find_level_change, bidi_cache_ensure_space)
964 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
965 (bidi_find_other_level_edge):
966 Use ptrdiff_t instead of EMACS_INT where either will do.
967 This works better on 32-bit hosts configured --with-wide-int.
968 (bidi_cache_ensure_space): Check for size-calculation overflow.
969 Use % rather than repeated addition, for better worst-case speed.
970 Don't set bidi_cache_size until after xrealloc returns, because it
972 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
973 (bidi_cache_ensure_space): Also check that the bidi cache size
974 does not exceed that of the largest Lisp string or buffer. See Eli
975 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
977 * alloc.c (__malloc_size_t): Remove.
978 All uses replaced by size_t. See Andreas Schwab's note
979 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
981 * image.c: Improve checking for integer overflow.
982 (check_image_size): Assume that f is nonnull, since
983 it is always nonnull in practice. This is one less thing to
984 worry about when checking for integer overflow later.
985 (x_check_image_size): New function, which checks for integer
986 overflow issues inside X.
987 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
988 This removes the need for a memory_full check.
989 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
990 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
991 (xbm_read_bitmap_data): Change locals back to 'int', since
992 their values must fit in 'int'.
993 (xpm_load_image, png_load, tiff_load):
994 Invoke x_create_x_image_and_pixmap earlier,
995 to avoid much needless work if the image is too large.
996 (tiff_load): Treat overly large images as if
997 x_create_x_image_and_pixmap failed, not as malloc failures.
998 (gs_load): Use x_check_image_size.
1000 * gtkutil.c: Omit integer casts.
1001 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1002 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1004 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1006 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1007 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1008 would wrongly return t on a 64-bit host.
1010 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1011 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1012 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1013 and therefore cause GCC to emit a bogus diagnostic in some cases.
1015 * image.c: Integer signedness and overflow and related fixes.
1016 This is not an exhaustive set of fixes, but it's time to
1017 record what I've got.
1018 (lookup_pixel_color, check_image_size): Remove redundant decls.
1019 (check_image_size): Don't assume that arbitrary EMACS_INT values
1020 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1021 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1022 (tiff_load, imagemagick_load_image):
1023 Check for overflow in size calculations.
1024 (x_create_x_image_and_pixmap): Remove unnecessary test for
1025 xmalloc returning NULL; that can't happen.
1026 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1027 (xpm_color_bucket): Use better integer hashing function.
1028 (xpm_cache_color): Don't possibly over-allocate memory.
1029 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1030 (gif_memory_source):
1031 Use ptrdiff_t, not int or size_t, to record sizes.
1032 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1033 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1034 either works, as we prefer signed integers.
1035 (tiff_read_from_memory, tiff_write_from_memory):
1036 Return tsize_t, not size_t, since that's what the TIFF API wants.
1037 (tiff_read_from_memory): Don't fail simply because the read would
1038 go past EOF; instead, return a short read.
1039 (tiff_load): Omit no-longer-needed casts.
1040 (Fimagemagick_types): Don't assume size fits into 'int'.
1042 Improve hashing quality when configured --with-wide-int.
1043 * fns.c (hash_string): New function, taken from sxhash_string.
1044 Do not discard information about ASCII character case; this
1045 discarding is no longer needed.
1046 (sxhash-string): Use it. Change sig to match it. Caller changed.
1047 * lisp.h: Declare it.
1048 * lread.c (hash_string): Remove, since we now use fns.c's version.
1049 The fns.c version returns a wider integer if --with-wide-int is
1050 specified, so this should help the quality of the hashing a bit.
1052 * emacs.c: Integer overflow minor fix.
1053 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1054 Define only if GNU_LINUX.
1055 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1057 * dispnew.c: Integer signedness and overflow fixes.
1058 Remove unnecessary forward decls, that were a maintenance hassle.
1059 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1061 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1062 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1063 (prepare_desired_row, line_draw_cost):
1064 Use int, not unsigned, where either works.
1065 (save_current_matrix, restore_current_matrix):
1066 Use ptrdiff_t, not size_t, where either works.
1067 (init_display): Check for overflow more accurately, and without
1068 relying on undefined behavior.
1070 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1071 Remove, replacing with the new symbols in lisp.h. All uses changed.
1072 * fileio.c (make_temp_name):
1073 * filelock.c (lock_file_1, lock_file):
1074 * xdisp.c (message_dolog):
1075 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1076 Use pMd etc. instead.
1077 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1078 replacing the pWIDE etc. symbols removed from editfns.c.
1080 * keyboard.h (num_input_events): Now uintmax_t.
1081 This is (very slightly) less likely to mess up due to wraparound.
1084 * buffer.c: Integer signedness fixes.
1085 (alloc_buffer_text, enlarge_buffer_text):
1086 Use ptrdiff_t rather than size_t when either will do, as we prefer
1089 * alloc.c: Integer signedness and overflow fixes.
1090 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1091 (__malloc_size_t): Default to size_t, not to int.
1092 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1093 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1094 Prefer ptrdiff_t to size_t when either would do, as we prefer
1096 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1097 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1098 Now const. Initialize with values that are in range even if char
1100 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1101 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1102 These functions do the right thing with sizes > 2**32.
1103 (check_depth): Now ptrdiff_t, not int.
1104 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1105 Adjust to new way of storing sizes. Check for size overflow bugs
1107 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1108 slightly wrong anyway, as it missed one instance of
1109 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1110 (refill_memory_reserve): Omit needless cast to size_t.
1111 (mark_object_loop_halt): Mark as externally visible.
1113 * xselect.c: Integer signedness and overflow fixes.
1114 (Fx_register_dnd_atom, x_handle_dnd_message):
1115 Use ptrdiff_t, not size_t, since we prefer signed.
1116 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1117 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1118 x_dnd_atoms_size and x_dnd_atoms_length.
1120 * doprnt.c: Prefer signed to unsigned when either works.
1122 * doprnt.c (doprnt):
1124 * xdisp.c (vmessage):
1125 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1126 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1127 prefer signed arithmetic to avoid comparison confusion.
1128 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1129 but is a bit tricky.
1131 Assume freestanding C89 headers, string.h, stdlib.h.
1132 * data.c, doprnt.c, floatfns.c, print.c:
1133 Include float.h unconditionally.
1134 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1135 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1136 * regex.c: Likewise for stddef.h, string.h.
1137 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1138 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1139 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1140 (STDC_HEADERS): Remove obsolete defines.
1141 * sysdep.c: Include limits.h unconditionally.
1143 Assume support for memcmp, memcpy, memmove, memset.
1144 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1145 * regex.c (memcmp, memcpy):
1146 Remove; we assume C89 now.
1148 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1149 (__malloc_safe_bcopy): Remove; no longer needed.
1151 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1152 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1153 well either way, and we prefer signed to unsigned.
1155 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1157 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1158 closes the connection while we're reading (bug#9182).
1160 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1162 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1163 are specified (Bug#9168).
1165 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1167 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1168 Found by GCC static checking and --with-wide-int on a 32-bit host.
1170 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1172 * xdisp.c (compute_display_string_pos): Fix logic of caching
1173 previous display string position. Initialize cached_prev_pos to
1174 -1. Fixes slow-down at the beginning of a buffer.
1176 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1178 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1179 for attrs[LFACE_FONTSET_INDEX].
1181 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1183 * xml.c (parse_region): Remove unused local
1184 that was recently introduced.
1186 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1188 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1189 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1191 * xdisp.c (move_it_in_display_line_to): Record the best matching
1192 position for TO_CHARPOS while scanning the line, and restore it on
1193 exit if none of the characters scanned was an exact match.
1194 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1195 when exact match is impossible due to invisible text, and the
1196 lines are truncated.
1198 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1200 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1203 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1205 Fix a significant slow-down of cursor motion with C-n, C-p,
1206 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1207 auto-repeat under bidi redisplay in fontified buffers.
1208 * xdisp.c (compute_stop_pos_backwards): New function.
1209 (next_element_from_buffer): Call compute_stop_pos_backwards to
1210 find a suitable prev_stop when we find ourselves before
1212 (reseat): Don't look for prev_stop, as that could mean a very long
1214 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1215 <cached_disp_overlay_modiff>: Cache for last found display string
1217 (compute_display_string_pos): Return the cached position if asked
1218 about the same buffer in the same area of character positions, and
1219 the buffer wasn't changed since the time the display string
1220 position was cached.
1222 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1224 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1225 is an integer, which is important for empty lines. (Bug#9149)
1227 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1229 * frame.c (Fmodify_frame_parameters): In tty case, update the
1230 default face if necessary (Bug#4238).
1232 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1234 * editfns.c (Fstring_to_char): No need to explain what a character
1235 is in the docstring (Bug#6576).
1237 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1239 * xml.c (parse_region): Make sure we always return a tree.
1241 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1243 * xml.c (parse_region): If a document contains only comments,
1246 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1248 * xml.c (make_dom): Return comments, too.
1250 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1253 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1254 and the surrounding thread.
1255 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1256 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1257 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1259 * s/openbsd.h (BROKEN_SIGIO): Define.
1260 * unexelf.c (unexec) [__OpenBSD__]:
1261 Don't update the .mdebug section of the Alpha COFF symbol table.
1263 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1265 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1268 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1270 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1271 This fixes some race conditions on the permissions of any newly
1274 * alloc.c (valid_pointer_p): Use pipe, not open.
1275 This fixes some permissions issues when debugging.
1277 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1278 If fchown fails to set both uid and gid, try to set just gid,
1279 as that is sometimes allowed. Adjust the file's mode to eliminate
1280 setuid or setgid bits that are inappropriate if fchown fails.
1282 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1284 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1285 to compare Lisp_Objects.
1286 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1287 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1288 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1290 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1292 * lread.c (read_integer): Unread even EOF character.
1293 (read1): Likewise. Properly record start position of symbol.
1295 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1296 symbol character follows.
1298 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1300 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1301 This works around a problem with the previous change to Fcopy_file.
1302 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1303 and without this change, GCC might complain about discarding
1304 fchown's return value.
1306 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1308 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1310 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1312 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1314 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1316 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1317 it's used from the C level.
1319 * process.c: Use the same condition for POLL_FOR_INPUT in both
1320 keyboard.c and process.c (bug#1858).
1322 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1324 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1325 (Fgnutls_boot): Use it.
1327 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1329 * doc.c (Fsubstitute_command_keys): Revert last change.
1331 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1333 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1334 quotes the next character, and doesn't affect other longer
1335 sequences (bug#8935).
1337 * lread.c (syms_of_lread): Clarify that is isn't only
1338 `eval-buffer' and `eval-defun' that's affected by
1339 `lexical-binding' (bug#8460).
1341 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1343 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1344 bidi redisplay when a line includes both an image and is
1347 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1349 Fix minor problems found by static checking.
1350 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1351 (elsz): Now a signed constant, not a size_t var. We prefer signed
1352 types to unsigned, to avoid integer comparison confusion. Without
1353 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1354 "cannot optimize loop, the loop counter may overflow", a symptom
1356 * indent.c (Fvertical_motion): Mark locals as initialized.
1357 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1359 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1361 * search.c (Fre_search_backward): Mention `case-fold-search' in
1362 all the re_search_* functions (bug#8138).
1364 * keyboard.c (Fopen_dribble_file): Document when the file is
1367 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1369 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1372 Support bidi reordering of display and overlay strings.
1373 * xdisp.c (compute_display_string_pos)
1374 (compute_display_string_end): Accept additional argument STRING.
1375 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1376 (reseat_to_string): Initialize bidi_it->string.s and
1377 bidi_it->string.schars.
1378 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1379 NULL (avoids a crash in bidi_paragraph_init).
1380 Initialize itb.string.lstring.
1381 (init_iterator): Call bidi_init_it only of a valid
1382 buffer position was specified. Initialize paragraph_embedding to
1384 (reseat_to_string): Initialize the bidi iterator.
1385 (display_string): If we need to ignore text properties of
1386 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1387 original value of -1 will not work with bidi.)
1388 (compute_display_string_pos): First arg is now struct
1389 `text_pos *'; all callers changed. Support display properties on
1391 (compute_display_string_end): Support display properties on Lisp
1393 (init_iterator, reseat_1, reseat_to_string): Initialize the
1394 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1395 when iterating on a string not from display properties).
1396 (compute_display_string_pos, compute_display_string_end):
1397 Fix calculation of the object to scan. Fixes an error when using
1399 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1400 base_level_stop; instead, set base_level_stop to BEGV.
1401 Fixes crashes in vertical-motion.
1402 (next_element_from_buffer): Improve commentary for when
1403 the iterator is before prev_stop.
1404 (init_iterator): Initialize bidi_p from the default value of
1405 bidi-display-reordering, not from buffer-local value. Use the
1406 buffer-local value only if initializing for buffer iteration.
1407 (handle_invisible_prop): Support invisible properties on strings
1408 that are being bidi-reordered.
1409 (set_iterator_to_next): Support bidi reordering of C strings and
1411 (next_element_from_string): Support bidi reordering of Lisp
1413 (handle_stop_backwards): Support Lisp strings as well.
1414 (display_string): Support display of R2L glyph rows.
1415 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1416 (init_iterator): Don't initialize it->bidi_p for strings
1418 (reseat_to_string): Initialize it->bidi_p for strings here.
1419 (next_element_from_string, next_element_from_c_string)
1420 (next_element_from_buffer): Add xassert's for correspondence
1421 between IT's object being iterated and it->bidi_it.string
1423 (face_before_or_after_it_pos): Support bidi iteration.
1424 (next_element_from_c_string): Handle the case of the first string
1425 character that is not the first one in the visual order.
1426 (get_visually_first_element): New function, refactored from common
1427 parts of next_element_from_buffer, next_element_from_string, and
1428 next_element_from_c_string.
1429 (tool_bar_lines_needed, redisplay_tool_bar)
1430 (display_menu_bar): Force left-to-right direction. Add a FIXME
1431 comment for making that be controlled by a user option.
1432 (push_it, pop_it): Save and restore the state of the
1433 bidi iterator. Save and restore the bidi_p flag.
1434 (pop_it): Iterate out of display property for string iteration as
1436 (iterate_out_of_display_property): Support iteration over strings.
1437 (handle_single_display_spec): Set up it->bidi_it for iteration
1438 over a display string, and call bidi_init_it.
1439 (handle_single_display_spec, next_overlay_string)
1440 (get_overlay_strings_1, push_display_prop): Set up the bidi
1441 iterator for displaying display or overlay strings.
1442 (forward_to_next_line_start): Don't use the shortcut if
1444 (back_to_previous_visible_line_start): If handle_display_prop
1445 pushed the iterator stack, restore the internal state of the bidi
1446 iterator by calling bidi_pop_it same number of times.
1447 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1448 and we are bidi-iterating, don't decrement the iterator position;
1449 instead, set the first_elt flag in the bidi iterator, to produce
1451 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1452 (push_display_prop): xassert that we are iterating a buffer.
1453 (push_it, pop_it): Save and restore paragraph_embedding member.
1454 (handle_single_display_spec, next_overlay_string)
1455 (get_overlay_strings_1, reseat_1, reseat_to_string)
1456 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1457 correctly. Don't assume unibyte strings are not bidi-reordered.
1458 (compute_display_string_pos)
1459 (compute_display_string_end): Fix handling the case of C string.
1460 (push_it, pop_it): Save and restore from_disp_prop_p.
1461 (handle_single_display_spec, push_display_prop): Set the
1462 from_disp_prop_p flag.
1463 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1464 (pop_it): Call iterate_out_of_display_property only if we are
1465 popping after iteration over a string that came from a display
1466 property. Fix a typo in popping stretch info. Add an assertion
1467 for verifying that the iterator position is in sync with the bidi
1469 (handle_single_display_spec, get_overlay_strings_1)
1470 (push_display_prop): Fix initialization of paragraph direction for
1471 string when that of the parent object is not yet determined.
1472 (reseat_1): Call bidi_init_it to resync the bidi
1473 iterator with IT's position. (Bug#7616)
1474 (find_row_edges): If ROW->start.pos gives position
1475 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1476 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1477 Reset the from_disp_prop_p flag.
1478 (SAVE_IT, RESTORE_IT): New macros.
1479 (pos_visible_p, face_before_or_after_it_pos)
1480 (back_to_previous_visible_line_start)
1481 (move_it_in_display_line_to, move_it_in_display_line)
1482 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1483 (try_scrolling, redisplay_window, display_line): Use them when
1484 saving a temporary copy of the iterator and restoring it back.
1485 (back_to_previous_visible_line_start, reseat_1)
1486 (init_iterator): Empty the bidi cache "stack".
1487 (move_it_in_display_line_to): If iterator ended up at
1488 EOL, but we never saw any buffer positions smaller than
1489 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1490 motion in bidi-reordered lines.
1491 (move_it_in_display_line_to): Record prev_method and prev_pos
1492 immediately before the call to set_iterator_to_next. Fixes cursor
1493 motion in bidi-reordered lines with stretch glyphs and strings
1494 displayed in margins. (Bug#8133) (Bug#8867)
1495 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1497 (pos_visible_p): Support positions in bidi-reordered lines.
1498 Save and restore bidi cache.
1500 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1501 (bidi_paragraph_info): Delete unused struct.
1502 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1503 (bidi_cache_start): New variable.
1504 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1506 (bidi_cache_fetch_state, bidi_cache_search)
1507 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1508 (bidi_cache_find, bidi_peek_at_next_level)
1509 (bidi_level_of_next_char, bidi_find_other_level_edge)
1510 (bidi_move_to_visually_next): Compare cache index with
1511 bidi_cache_start rather than with zero.
1512 (bidi_fetch_char): Accept new argument STRING; all callers
1513 changed. Support iteration over a string. Support strings with
1514 display properties. Support unibyte strings. Fix the type of
1515 `len' according to what STRING_CHAR_AND_LENGTH expects.
1516 (bidi_paragraph_init, bidi_resolve_explicit_1)
1517 (bidi_resolve_explicit, bidi_resolve_weak)
1518 (bidi_level_of_next_char, bidi_move_to_visually_next):
1519 Support iteration over a string.
1520 (bidi_set_sor_type, bidi_resolve_explicit_1)
1521 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1522 can now be zero (for strings); special values 0 and -1 were
1523 changed to -1 and -2, respectively.
1524 (bidi_char_at_pos): New function.
1525 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1526 Call it instead of FETCH_MULTIBYTE_CHAR.
1527 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1528 initialized to valid values.
1529 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1531 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1532 the test for valid cached positions. Fix the logic for looking up
1533 the sentinel state in the cache. GCPRO the Lisp string we are
1535 (bidi_push_it, bidi_pop_it): New functions.
1536 (bidi_initialize): Initialize the bidi cache start stack pointer.
1537 (bidi_cache_ensure_space): New function, refactored from part of
1538 bidi_cache_iterator_state. Don't assume the required size is just
1539 one BIDI_CACHE_CHUNK away.
1540 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1541 (bidi_count_bytes, bidi_char_at_pos): New functions.
1542 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1543 always valid if bidi_cache_idx is valid.
1544 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1545 is valid if it's going to be used.
1546 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1547 (bidi_cache_fetch_state, bidi_cache_search)
1548 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1549 (bidi_cache_iterator_state, bidi_cache_find)
1550 (bidi_find_other_level_edge, bidi_cache_start_stack):
1551 All variables related to cache indices are now EMACS_INT.
1553 * dispextern.h (struct bidi_string_data): New structure.
1554 (struct bidi_it): New member `string'. Make flag members be 1-bit
1555 fields, and put them last in the struct.
1556 (compute_display_string_pos, compute_display_string_end):
1558 (bidi_push_it, bidi_pop_it): Add prototypes.
1559 (struct iterator_stack_entry): New members bidi_p,
1560 paragraph_embedding, and from_disp_prop_p.
1561 (struct it): Member bidi_p is now a bit field 1 bit wide.
1562 (bidi_shelve_cache, bidi_unshelve_cache):
1565 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1566 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1567 and vector-like objects.
1569 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1570 cache around display iteration.
1572 * window.c (Fwindow_end, window_scroll_pixel_based)
1573 (displayed_window_lines, Frecenter): Save and restore the bidi
1574 cache around display iteration.
1576 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1578 * editfns.c (Fdelete_region): Clarify the use of the named
1579 parameters (bug#6788).
1581 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1583 * indent.c (Fvertical_motion): Set and restore w->pointm when
1584 saving and restoring the window's buffer (Bug#9006).
1586 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1588 * editfns.c (Fstring_to_char): Clarify just what is returned
1589 (bug#6576). Text by Eli Zaretskii.
1591 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1593 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1595 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1597 * buffer.c (mmap_find): Fix a typo.
1599 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1601 Fix execution of x selection hooks.
1602 * xselect.c (Qx_lost_selection_functions)
1603 (Qx_sent_selection_functions): New vars.
1604 (syms_of_xselect): DEFSYM them.
1605 (x_handle_selection_request): Pass Qx_sent_selection_functions
1606 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1607 (x_handle_selection_clear,x_clear_frame_selections):
1608 Pass Qx_lost_selection_functions rather than
1609 Vx_lost_selection_functions to Frun_hook_with_args.
1611 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1613 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1614 The old code sometimes used this field without initializing it.
1616 * alloc.c (gc_sweep): Don't read past end of array.
1617 In theory, the old code could also have corrupted Emacs internals,
1618 though it'd be very unlikely.
1620 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1622 * character.c (Fcharacterp): Don't advertise optional ignored
1623 argument. (Bug#4026)
1625 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1627 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1630 * window.c (Fset_window_start): Doc fix (bug#4199).
1631 (Fset_window_hscroll): Ditto.
1633 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1635 Fix minor new problems caught by GCC 4.6.1.
1636 * term.c (init_tty): Remove unused local.
1637 * xsettings.c (store_monospaced_changed): Define this function only
1638 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1641 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1643 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1645 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1647 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1648 are the mini-buffer and the echo area (bug#3320).
1650 * term.c (init_tty): Remove support for supdup, c10 and perq
1651 terminals, which are no longer supported (bug#1482).
1653 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1655 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1657 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1659 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1660 for non-popups (Bug#3642).
1662 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1664 * alloc.c (reset_malloc_hooks): Protoize.
1665 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1666 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1667 * cm.c (losecursor): Likewise.
1668 * data.c (fmod): Likewise.
1669 * dispnew.c (swap_glyphs_in_rows): Likewise.
1670 * emacs.c (memory_warning_signal): Likewise.
1671 * floatfns.c (float_error): Likewise.
1672 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1673 (otf_open, font_otf_capability, generate_otf_features)
1674 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1676 * image.c (pbm_read_file): Likewise.
1677 * indent.c (string_display_width): Likewise.
1678 * intervals.c (check_for_interval, search_for_interval)
1679 (inc_interval_count, count_intervals, root_interval)
1680 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1681 * lread.c (defalias): Likewise.
1682 * ralloc.c (r_alloc_check): Likewise.
1683 * regex.c (set_image_of_range_1, set_image_of_range)
1684 (regex_grow_registers): Likewise.
1685 * sysdep.c (strerror): Likewise.
1686 * termcap.c (valid_filename_p, tprint, main): Likewise.
1687 * tparam.c (main): Likewise.
1688 * unexhp9k800.c (run_time_remap, save_data_space)
1689 (update_file_ptrs, read_header, write_header, calculate_checksum)
1690 (copy_file, copy_rest, display_header): Likewise.
1691 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1693 * xdisp.c (check_it): Likewise.
1694 * xfaces.c (register_color, unregister_color, unregister_colors):
1696 * xfns.c (print_fontset_result): Likewise.
1697 * xrdb.c (member, fatal, main): Likewise.
1699 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1701 Fix minor problems found by static checking (Bug#9031).
1702 * chartab.c (char_table_set_range, map_sub_char_table):
1703 Remove unused locals.
1704 (uniprop_table): Now static.
1705 * composite.c (_work_char): Remove unused static var.
1707 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1709 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1711 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1713 * gtkutil.c (qttip_cb): Remove code without function.
1715 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1717 * w32.c (pthread_sigmask): New stub.
1719 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1721 Use pthread_sigmask, not sigprocmask (Bug#9010).
1722 sigprocmask is portable only for single-threaded applications, and
1723 Emacs can be multi-threaded when it uses GTK.
1724 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1726 * callproc.c (Fcall_process):
1727 * process.c (create_process):
1728 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1729 Use pthread_sigmask, not sigprocmask.
1731 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1733 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1734 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1737 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1739 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1740 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1741 (xg_hide_tooltip): Fix comment.
1743 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1744 in registerServicesMenuSendTypes.
1745 (validRequestorForSendType): Don't check ns_return_types.
1747 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1750 2011-07-08 Jason Rumney <jasonr@gnu.org>
1752 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1753 frame struct members of non-existent frames (Bug#6284).
1755 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1757 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1758 variable firstTime not needed on OSX >= 10.6.
1759 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1760 >= 10.5. Use setKnobProportion, setDoubleValue.
1762 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1763 (MAC_OS_X_VERSION_10_5): Define if not defined.
1764 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1765 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1766 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1768 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1769 cString and lossyCString on OSX >= 10.4
1771 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1772 sizeToFit on OSX >= 10.2.
1774 * nsimage.m (allocInitFromFile): Don't use deprecated method
1775 bestRepresentationForDevice on OSX >= 10.6.
1777 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1780 * emacs.c: Declare unexec_init_emacs_zone.
1782 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1784 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1786 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1787 on svcsMenu (Bug#8842).
1789 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1791 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1793 * nsterm.m (QUTF8_STRING): Declare.
1794 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1795 (validRequestorForSendType): Return type is (id).
1796 Change indexOfObjectIdenticalTo to indexOfObject.
1797 Check if we have local selection before returning self (Bug#8842).
1798 (writeSelectionToPasteboard): Put local selection into paste board
1799 if we have a local selection (Bug#8842).
1800 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1802 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1803 (ns_get_local_selection): Declare.
1805 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1807 * keymap.c (describe_map_tree): Don't insert a double newline at
1808 the end of the buffer (bug#1169) and return whether we inserted
1811 * callint.c (Fcall_interactively): Change "reading args" to
1812 "providing args" to try to clarify what it does (bug#1010).
1814 2011-07-07 Kenichi Handa <handa@m17n.org>
1816 * composite.c (composition_compute_stop_pos): Ignore a static
1817 composition starting before CHARPOS (Bug#8915).
1819 * xdisp.c (handle_composition_prop): Likewise.
1821 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1823 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1826 2011-07-07 Kenichi Handa <handa@m17n.org>
1828 * character.h (unicode_category_t): New enum type.
1830 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1831 (Qchar_code_property_table): New variable.
1832 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1833 (UNIPROP_COMPRESSED_FORM_P): New macros.
1834 (char_table_ascii): Uncompress the compressed values.
1835 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1836 Uncompress the compressed values.
1837 (sub_char_table_ref_and_range): Likewise.
1838 (char_table_ref_and_range): Uncompress the compressed values.
1839 (sub_char_table_set): New arg is_uniprop. Callers changed.
1840 Uncompress the compressed values.
1841 (sub_char_table_set_range): Args changed. Callers changed.
1842 (char_table_set_range): Adjuted for the above change.
1843 (map_sub_char_table): Delete args default_val and parent. Add arg
1844 top. Give decoded values to a Lisp function.
1845 (map_char_table): Adjust for the above change. Give decoded
1846 values to a Lisp function. Gcpro more variables.
1847 (uniprop_table_uncompress)
1848 (uniprop_decode_value_run_length): New functions.
1849 (uniprop_decoder, uniprop_decoder_count): New variables.
1850 (uniprop_get_decoder, uniprop_encode_value_character)
1851 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1853 (uniprop_encoder, uniprop_encoder_count): New variables.
1854 (uniprop_get_encoder, uniprop_table)
1855 (Funicode_property_table_internal, Fget_unicode_property_internal)
1856 (Fput_unicode_property_internal): New functions.
1857 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1858 Sunicode_property_table_internal, Sget_unicode_property_internal,
1859 and Sput_unicode_property_internal. Defvar_lisp
1860 char-code-property-alist.
1862 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
1863 Vunicode_category_table.
1865 * font.c (font_range): Adjust for the change of
1866 Vunicode_category_table.
1868 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1870 * m/iris4d.h: Remove file, move contents ...
1871 * s/irix6-5.h: ... here.
1873 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1875 Remove unportable assumption about struct layout (Bug#8884).
1876 * alloc.c (mark_buffer):
1877 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1878 (clone_per_buffer_values): Don't assume that
1879 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1880 This isn't true in general, and it's particularly not true
1881 if Emacs is configured with --with-wide-int.
1882 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1883 New macros, used in the buffer.c change.
1885 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1887 * xsettings.c: Use both GConf and GSettings if both are available.
1888 (store_config_changed_event): Add comment.
1889 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1890 (store_tool_bar_style_changed): New functions.
1891 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1892 (struct xsettings): Move font inside HAVE_XFT.
1893 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1894 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
1895 Move inside HAVE_XFT.
1896 (something_changed_gsettingsCB): Rename from something_changedCB.
1897 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1899 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1900 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1901 (something_changed_gconfCB): Rename from something_changedCB.
1902 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1903 (parse_settings): Move check for font inside HAVE_XFT.
1904 (read_settings, apply_xft_settings): Add comment.
1905 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1906 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1907 call store_font_name_changed.
1908 (xft_settings_event): Add comment.
1909 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1910 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1911 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1912 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1913 (xsettings_initialize): Call init_gsettings last.
1914 (xsettings_get_system_font, xsettings_get_system_normal_font):
1917 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1919 Random fixes. E.g., (random) never returned negative values.
1920 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1921 subseconds part to the entropy, as that's a bit more random.
1922 Prefer signed to unsigned, since the signedness doesn't matter and
1923 in general we prefer signed. When given a limit, use a
1924 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1925 latter isn't right if USE_2_TAGS_FOR_INTS.
1926 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1927 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1929 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1931 * textprop.c (text_property_stickiness):
1932 Obey Vtext_property_default_nonsticky.
1933 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1934 * w32fns.c (syms_of_w32fns):
1935 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1937 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1939 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1940 This is more efficient than Ffile_directory_p and avoids a minor race.
1942 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1944 * buffer.c (Foverlay_put): Say what the return value is
1947 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1948 is a directory before asking whether to use the file name
1950 (barf_or_query_if_file_exists): Make the "File is a directory"
1951 error be more correct.
1953 * fns.c (Frequire): Remove the mention of the .gz files, since
1954 that's installation-specific, but keep the mention of
1955 `get-load-suffixes'.
1957 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1959 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1960 Report string overflow if the output is too long.
1962 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1964 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1965 (syms_of_gnutls): Remove duplicate DEFSYM for
1966 Qgnutls_bootprop_verify_hostname_error, an error for
1967 Qgnutls_bootprop_verify_error (which is no longer used).
1969 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1970 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1971 Also (re)move comments that are misplaced or no longer relevant.
1973 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1975 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1977 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1979 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1980 and background color parameters if they have been changed.
1982 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1984 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1986 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1988 * xsettings.c (SYSTEM_FONT): Define only when used.
1989 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1991 * keymap.c (access_keymap_1): Now static.
1993 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1995 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1996 leave any prefix arg for the up event (Bug#1586).
1998 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2000 * lread.c (syms_of_lread): Mention single symbols defined by
2001 `defvar' or `defconst' (bug#7154).
2003 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2004 (Frequire): Mention get-load-suffixes.
2006 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2008 * window.h (window): Remove clone_number slot.
2009 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2011 (make_parent_window, make_window, saved_window)
2012 (Fset_window_configuration, save_window_save): Don't deal with
2014 * buffer.c (Qclone_number): Remove declaration.
2015 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2017 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2019 Add multiple inheritance to keymaps.
2020 * keymap.c (Fmake_composed_keymap): New function.
2021 (Fset_keymap_parent): Simplify.
2022 (fix_submap_inheritance): Remove.
2023 (access_keymap_1): New function extracted from access_keymap to handle
2024 embedded parents and handle lists of maps.
2025 (access_keymap): Use it.
2026 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2027 (Fcopy_keymap): Handle embedded parents.
2028 (Fcommand_remapping, define_as_prefix): Simplify.
2029 (Fkey_binding): Simplify.
2030 (syms_of_keymap): Move minibuffer-local-completion-map,
2031 minibuffer-local-filename-completion-map,
2032 minibuffer-local-must-match-map, and
2033 minibuffer-local-filename-must-match-map to Elisp.
2034 (syms_of_keymap): Defsubr make-composed-keymap.
2035 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2036 (parse_menu_item): Trivial simplification.
2038 2011-07-01 Glenn Morris <rgm@gnu.org>
2040 * Makefile.in (SETTINGS_LIBS): Fix typo.
2042 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2044 * coding.c (Fencode_coding_string): Record the last coding system
2045 used, as the function doc string says (bug#8738).
2047 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2049 * xsettings.c (store_monospaced_changed): Take new font as arg and
2050 check for change against current_mono_font.
2051 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2052 (emacs_settings_constructor, emacs_settings_get_property)
2053 (emacs_settings_set_property, emacs_settings_class_init)
2054 (emacs_settings_init, gsettings_obj): Remove.
2055 (something_changedCB): New function for HAVE_GSETTINGS.
2056 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2057 with value as argument.
2058 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2059 g_settings_new (Bug#8967). Do not create gsettings_obj.
2060 Remove calls to g_settings_bind. Connect something_changedCB to
2063 * xgselect.c: Add defined (HAVE_GSETTINGS).
2064 (xgselect_initialize): Ditto.
2066 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2067 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2070 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2072 * eval.c (struct backtrace): Simplify and port the data structure.
2073 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2074 signed bit field, as this assumption is not portable and it makes
2075 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2076 "char debug_on_exit : 1" as this is not portable either; instead,
2077 use the portable "unsigned int debug_on_exit : 1". Remove unused
2078 member evalargs. Remove obsolete comments about cc bombing out.
2080 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2082 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2083 Let HAVE_GSETTINGS override HAVE_GCONF.
2084 (store_monospaced_changed): New function.
2085 (EMACS_SETTINGS): A new type derived from GObject to handle
2086 GSettings notifications.
2087 (emacs_settings_constructor, emacs_settings_get_property)
2088 (emacs_settings_set_property, emacs_settings_class_init):
2090 (gsettings_client, gsettings_obj): New variables.
2091 (GSETTINGS_SCHEMA): New define.
2092 (something_changedCB): Call store_monospaced_changed.
2093 (init_gsettings): New function.
2094 (xsettings_initialize): Call init_gsettings.
2095 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2098 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2101 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2103 * window.c (resize_root_window, grow_mini_window)
2104 (shrink_mini_window): Rename Qresize_root_window to
2105 Qwindow_resize_root_window and Qresize_root_window_vertically to
2106 Qwindow_resize_root_window_vertically.
2108 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2110 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2112 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2114 * makefile.w32-in: Redesign dependencies so they reflect more
2115 clearly which files are directly included by each source file,
2116 and not through other includes.
2118 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2120 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2121 (sort_overlays, overlay_strings): When an overlay's clone number
2122 matches the window's clone number process the overlay even if
2123 the overlay's window property doesn't match the current window.
2125 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2126 (Fwindow_hchild): Rename to Fwindow_left_child.
2127 (Fwindow_next): Rename to Fwindow_next_sibling.
2128 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2129 (resize_window_check): Rename to window_resize_check.
2130 (resize_window_apply): Rename to window_resize_apply.
2131 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2132 (Fdelete_other_windows_internal, resize_frame_windows)
2133 (Fsplit_window_internal, Fdelete_window_internal)
2134 (grow_mini_window, shrink_mini_window)
2135 (Fresize_mini_window_internal): Fix callers accordingly.
2137 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2139 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2140 (emacs_fixed_set_min_size): Remove.
2141 (emacs_fixed_new): Take frame as argument.
2143 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2144 (_EmacsFixedPrivate): Remove minwidth/height.
2145 Add struct frame *f.
2146 (emacs_fixed_init): Initialize priv->f.
2147 (get_parent_class, emacs_fixed_set_min_size): Remove.
2148 (emacs_fixed_new): Set priv->f to argument.
2149 (emacs_fixed_get_preferred_width)
2150 (emacs_fixed_get_preferred_height): Use min_width/height from
2151 frames size_hint to set minimum and natural (Bug#8919).
2152 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2153 and use min_width/height from frames size_hint to set
2154 min_width/height (Bug#8919).
2156 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2157 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2160 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2162 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2163 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2166 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2168 * process.c (wait_reading_process_output): Bypass select if
2169 waiting for a cell while ignoring keyboard input, and input is
2170 pending. Suggested by Jan Djärv (Bug#8869).
2172 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2174 Use gnulib's dup2 module instead of rolling our own.
2175 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2177 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2179 * dispnew.c (scrolling_window): Before scrolling, turn off a
2180 mouse-highlight in the window being scrolled.
2182 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2184 Move DEFSYM to lisp.h and use everywhere.
2186 * character.h (DEFSYM): Move declaration...
2187 * lisp.h (DEFSYM): ...here.
2193 * w32select.c: Don't include character.h.
2195 * alloc.c (syms_of_alloc):
2196 * buffer.c (syms_of_buffer):
2197 * bytecode.c (syms_of_bytecode):
2198 * callint.c (syms_of_callint):
2199 * casefiddle.c (syms_of_casefiddle):
2200 * casetab.c (init_casetab_once):
2201 * category.c (init_category_once, syms_of_category):
2202 * ccl.c (syms_of_ccl):
2203 * cmds.c (syms_of_cmds):
2204 * composite.c (syms_of_composite):
2205 * dbusbind.c (syms_of_dbusbind):
2206 * dired.c (syms_of_dired):
2207 * dispnew.c (syms_of_display):
2208 * doc.c (syms_of_doc):
2209 * editfns.c (syms_of_editfns):
2210 * emacs.c (syms_of_emacs):
2211 * eval.c (syms_of_eval):
2212 * fileio.c (syms_of_fileio):
2213 * fns.c (syms_of_fns):
2214 * frame.c (syms_of_frame):
2215 * fringe.c (syms_of_fringe):
2216 * insdel.c (syms_of_insdel):
2217 * keymap.c (syms_of_keymap):
2218 * lread.c (init_obarray, syms_of_lread):
2219 * macros.c (syms_of_macros):
2220 * msdos.c (syms_of_msdos):
2221 * print.c (syms_of_print):
2222 * process.c (syms_of_process):
2223 * search.c (syms_of_search):
2224 * sound.c (syms_of_sound):
2225 * syntax.c (init_syntax_once, syms_of_syntax):
2226 * terminal.c (syms_of_terminal):
2227 * textprop.c (syms_of_textprop):
2228 * undo.c (syms_of_undo):
2229 * w32.c (globals_of_w32):
2230 * window.c (syms_of_window):
2231 * xdisp.c (syms_of_xdisp):
2232 * xfaces.c (syms_of_xfaces):
2233 * xfns.c (syms_of_xfns):
2234 * xmenu.c (syms_of_xmenu):
2235 * xsettings.c (syms_of_xsettings):
2236 * xterm.c (syms_of_xterm): Use DEFSYM.
2238 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2240 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2242 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2244 Integer and buffer overflow fixes (Bug#8873).
2246 * print.c (printchar, strout): Check for string overflow.
2247 (PRINTPREPARE, printchar, strout):
2248 Don't set size unless allocation succeeds.
2250 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2251 for sizes. Check for string overflow more accurately.
2252 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2254 * macros.c: Integer and buffer overflow fixes.
2255 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2256 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2257 Use ptrdiff_t, not int, for sizes.
2258 Don't increment bufsize until after realloc succeeds.
2259 Check for size-calculation overflow.
2260 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2262 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2264 * lread.c: Integer overflow fixes.
2265 (read_integer): Radix is now EMACS_INT, not int,
2266 to improve quality of diagnostics for out-of-range radices.
2267 Calculate buffer size correctly for out-of-range radices.
2268 (read1): Check for integer overflow in radices, and in
2269 read-circle numbers.
2270 (read_escape): Avoid int overflow.
2271 (Fload, openp, read_buffer_size, read1)
2272 (substitute_object_recurse, read_vector, read_list, map_obarray):
2273 Use ptrdiff_t, not int, for sizes.
2274 (read1): Use EMACS_INT, not int, for sizes.
2275 Check for size overflow.
2277 * image.c (cache_image): Check for size arithmetic overflow.
2279 * lread.c: Integer overflow issues.
2280 (saved_doc_string_size, saved_doc_string_length)
2281 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2282 Now ptrdiff_t, not int.
2283 (read1): Don't assume doc string length fits in int. Check for
2284 out-of-range doc string lengths.
2285 (read_list): Don't assume file position fits in int.
2286 (read_escape): Check for hex character overflow.
2288 2011-06-22 Leo Liu <sdl.web@gmail.com>
2290 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2291 Move to minibuffer.el.
2293 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2295 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2296 The following patches are for when GLYPH_DEBUG && !XASSERT.
2297 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2298 * dispnew.c (flush_stdout):
2299 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2300 Mark as externally visible.
2301 * dispnew.c (check_window_matrix_pointers): Now static.
2302 * dispnew.c (window_to_frame_vpos):
2303 * xfns.c (unwind_create_frame):
2304 * xterm.c (x_check_font): Remove unused local.
2305 * scroll.c (CHECK_BOUNDS):
2306 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2307 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2308 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2309 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2310 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2312 (debug_method_add): Use va_list and vsprintf rather than relying
2313 on undefined behavior with wrong number of arguments.
2314 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2315 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2316 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2317 since we're not interested in debugging glyphs with old libraries.
2318 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2319 GCC 4.6.0's static checking.
2321 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2323 Integer overflow and signedness fixes (Bug#8873).
2324 A few related buffer overrun fixes, too.
2326 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2328 * dispextern.h (struct face.stipple):
2329 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2330 (x_bitmap_mask, x_allocate_bitmap_record)
2331 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2332 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2333 (x_create_bitmap_from_xpm_data):
2334 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2335 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2337 * xfaces.c (load_pixmap):
2338 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2339 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2340 (.bitmaps_last, struct x_output.icon_bitmap):
2341 Use ptrdiff_t, not int, for bitmap indexes.
2342 (x_allocate_bitmap_record): Check for size overflow.
2343 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2345 Use ptrdiff_t, not int, for overlay counts.
2346 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2347 * editfns.c (overlays_around, get_pos_property):
2348 * textprop.c (get_char_property_and_overlay):
2349 * xdisp.c (next_overlay_change, note_mouse_highlight):
2350 * xfaces.c (face_at_buffer_position):
2351 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2352 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2353 (Fnext_overlay_change, Fprevious_overlay_change)
2354 (mouse_face_overlay_overlaps, Foverlays_in):
2355 Use ptrdiff_t, not int, for sizes.
2356 (overlays_at, overlays_in): Check for size-calculation overflow.
2358 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2360 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2361 (x_session_initialize): Do not assume string length fits in int.
2363 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2364 This is unlikely, but can occur if DPI is outlandish.
2366 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2367 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2369 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2370 * xrdb.c (magic_file_p, search_magic_path):
2371 Omit last arg SUFFIX; it was always 0. All callers changed.
2372 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2374 * xfont.c (xfont_match): Avoid need for strlen.
2376 * xfns.c: Don't assume strlen fits in int.
2377 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2379 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2380 not unsigned long, as we prefer signed integers. All callers changed.
2381 Detect integer overflow in repeat count.
2382 (message_dolog): Don't assume print length fits in 39 bytes.
2383 (display_mode_element): Don't assume strlen fits in int.
2385 * termcap.c: Don't assume sizes fit in int and never overflow.
2386 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2387 (gobble_line): Check for size-calculation overflow.
2389 * minibuf.c (Fread_buffer):
2390 * lread.c (intern, intern_c_string):
2391 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2392 Don't assume string length fits in int.
2394 * keyboard.c (parse_tool_bar_item):
2395 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2397 * font.c: Don't assume string length fits in int.
2398 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2399 Use ptrdiff_t, not int.
2400 (font_intern_prop): Don't assume string length fits in int.
2401 Don't assume integer property fits in fixnum.
2402 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2404 * filelock.c: Fix some buffer overrun and integer overflow issues.
2405 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2406 Reformulate so as not to need the command string.
2407 Invoke gzip -cd rather than gunzip, as it's more portable.
2408 (lock_info_type, lock_file_1, lock_file):
2409 Don't assume pid_t and time_t fit in unsigned long.
2410 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2411 (current_lock_owner): Prefer signed type for sizes.
2412 Use memcpy, not strncpy, where memcpy is what is really wanted.
2413 Don't assume (via atoi) that time_t and pid_t fit in int.
2414 Check for time_t and/or pid_t out of range, e.g., via a network share.
2415 Don't alloca where an auto var works fine.
2417 * fileio.c: Fix some integer overflow issues.
2418 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2419 Don't assume string length fits in int.
2420 (directory_file_name): Don't assume string length fits in long.
2421 (make_temp_name): Don't assume pid fits in int, or that its print
2422 length is less than 20.
2424 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2426 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2428 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2430 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2431 We prefer signed integers, even for size calculations.
2433 * emacs.c: Don't assume string length fits in 'int'.
2434 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2435 (main): Don't invoke strlen when not needed.
2437 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2438 (XD_DEBUG_MESSAGE): Don't waste a byte.
2440 * callproc.c (getenv_internal_1, getenv_internal)
2442 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2444 * lread.c (invalid_syntax): Omit length argument.
2445 All uses changed. This doesn't fix a bug, but it simplifies the
2446 code away from its former Hollerith-constant appearance, and it's
2447 one less 'int' to worry about when looking at integer-overflow issues.
2448 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2450 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2451 This didn't break anything, but it didn't help either.
2452 It's confusing to put a bogus integer in a place where the actual
2453 value does not matter.
2454 (LIST_END_P): Remove unused macro and its bogus comment.
2455 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2457 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2458 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2460 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2461 We prefer signed types, and the value cannot exceed the EMACS_INT
2462 range anyway (because otherwise the length would not be representable).
2463 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2464 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2465 This avoids a GCC warning when WIDE_EMACS_INT.
2467 * indent.c (sane_tab_width): New function.
2468 (current_column, scan_for_column, Findent_to, position_indentation)
2469 (compute_motion): Use it. This is just for clarity.
2470 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2472 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2474 * lisp.h (lint_assume): New macro.
2475 * composite.c (composition_gstring_put_cache):
2476 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2478 * editfns.c, insdel.c:
2479 Omit unnecessary forward decls, to simplify future changes.
2481 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2483 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2485 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2486 Use much-faster test for byte-length change.
2487 Don't assume string byte-length fits in 'int'.
2488 Check that character arg fits in 'int'.
2489 (mapcar1): Declare byte as byte, for clarity.
2491 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2493 * fns.c (concat): Catch string overflow earlier.
2494 Do not rely on integer wraparound.
2496 * dispextern.h (struct it.overlay_strings_charpos)
2497 (struct it.selective): Now EMACS_INT, not int.
2498 * xdisp.c (forward_to_next_line_start)
2499 (back_to_previous_visible_line_start)
2500 (reseat_at_next_visible_line_start, next_element_from_buffer):
2501 Don't arbitrarily truncate the value of 'selective' to int.
2503 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2505 * composite.c: Don't truncate sizes to 'int'.
2506 (composition_gstring_p, composition_reseat_it)
2507 (composition_adjust_point): Use EMACS_INT, not int.
2508 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2509 not EMACS_UINT, for indexes.
2511 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2513 * buffer.c: Include <verify.h>.
2514 (struct sortvec.priority, struct sortstr.priority):
2515 Now EMACS_INT, not int.
2516 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2517 (struct sortstr.size, record_overlay_string)
2518 (struct sortstrlist.size, struct sortlist.used):
2519 Don't truncate size to int.
2520 (record_overlay_string): Check for size-calculation overflow.
2521 (init_buffer_once): Check at compile-time, not run-time.
2523 2011-06-22 Jim Meyering <meyering@redhat.com>
2525 Don't leak an XBM-image-sized buffer
2526 * image.c (xbm_load): Free the image buffer after using it.
2528 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2531 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2532 that Sun C diagnosed.
2533 * fns.c (secure_hash): Fix pointer signedness issue.
2534 * intervals.c (static_offset_intervals): New function.
2535 (offset_intervals): Use it.
2537 2011-06-21 Leo Liu <sdl.web@gmail.com>
2540 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2543 * fns.c (secure_hash): Rename from crypto_hash_function and change
2544 the first arg to accept symbols.
2545 (Fsecure_hash): New primitive.
2546 (syms_of_fns): New symbols.
2548 2011-06-20 Deniz Dogan <deniz@dogan.se>
2550 * process.c (Fset_process_buffer): Clarify return value in
2553 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2555 * dispnew.c (add_window_display_history): Use BVAR.
2557 * xdisp.c (debug_method_add): Use BVAR.
2558 (check_window_end, dump_glyph_matrix, dump_glyph)
2559 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2561 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2564 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2565 check till after the cache is created in init_frame_faces.
2567 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2569 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2571 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2573 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2574 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2575 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2577 Improve buffer-overflow checking (Bug#8873).
2578 * fileio.c (Finsert_file_contents):
2579 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2580 Remove the old (too-loose) buffer overflow checks.
2581 They weren't needed, since make_gap checks for buffer overflow.
2582 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2583 The old code merely checked for Emacs fixnum overflow, and relied
2584 on undefined (wraparound) behavior. The new code avoids undefined
2585 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2587 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2588 Tune. Don't use wider integers than needed. Don't use alloca.
2589 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2591 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2593 * insdel.c, lisp.h (buffer_overflow): New function.
2594 (insert_from_buffer_1, replace_range, replace_range_2):
2595 * insdel.c (make_gap_larger):
2596 * editfns.c (Finsert_char):
2597 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2599 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2601 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2603 Integer overflow and signedness fixes (Bug#8873).
2605 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2606 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2608 * fileio.c: Don't assume EMACS_INT fits in off_t.
2609 (emacs_lseek): New static function.
2610 (Finsert_file_contents, Fwrite_region): Use it.
2611 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2613 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2615 * fns.c: Don't overflow int when computing a list length.
2616 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2617 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2618 truncation on 64-bit hosts. Check for QUIT every
2619 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2620 faster and is responsive enough.
2621 (Flength): Report an error instead of overflowing an integer.
2622 (Fsafe_length): Return a float if the value is not representable
2623 as a fixnum. This shouldn't happen except in contrived situations.
2624 (Fnthcdr, Fsort): Don't assume list length fits in int.
2625 (Fcopy_sequence): Don't assume vector length fits in int.
2627 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2628 (header_size, word_size): New constants.
2629 (allocate_vectorlike): Don't check size overflow here.
2630 (allocate_vector): Check it here instead, since this is the only
2631 caller of allocate_vectorlike that could cause overflow.
2632 Check that the new vector's length is representable as a fixnum.
2634 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2635 The previous code was bogus. For example, next_almost_prime (32)
2636 returned 39, which is undesirable as it is a multiple of 3; and
2637 next_almost_prime (24) returned 25, which is a multiple of 5 so
2638 why was the code bothering to check for multiples of 7?
2640 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2642 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2644 Variadic C functions now count arguments with ptrdiff_t.
2645 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2646 Back then I didn't know that the Emacs coding style prefers signed int.
2647 Also, in the meantime I found a few more instances where arguments
2648 were being counted with int, which may truncate counts on 64-bit
2649 machines, or EMACS_INT, which may be unnecessarily wide.
2650 * lisp.h (struct Lisp_Subr.function.aMANY)
2651 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2652 Arg counts are now ptrdiff_t, not size_t.
2653 All variadic functions and their callers changed accordingly.
2654 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2655 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2656 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2657 * callint.c (Fcall_interactively): Check arg count for overflow,
2658 to avoid potential buffer overrun. Use signed char, not 'int',
2659 for 'varies' array, so that we needn't bother to check its size
2660 calculation for overflow.
2661 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2662 * eval.c (apply_lambda):
2663 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2664 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2665 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2667 * callint.c (Fcall_interactively): Don't use index var as event count.
2669 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2670 * mem-limits.h (SIZE): Remove; no longer used.
2672 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2674 Remove unnecessary casts.
2675 * xterm.c (x_term_init):
2676 * xfns.c (x_set_border_pixel):
2677 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2678 These aren't needed now that we assume ANSI C.
2680 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2681 It's more likely to cause problems (due to unsigned overflow)
2684 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2686 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2688 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2690 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2692 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2694 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2696 GLYPH_CODE_FACE returns EMACS_INT, not int.
2697 * dispextern.h (merge_faces):
2698 * xfaces.c (merge_faces):
2699 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2700 Don't assume EMACS_INT fits in int.
2702 * character.h (CHAR_VALID_P): Remove unused parameter.
2703 * fontset.c, lisp.h, xdisp.c: All uses changed.
2705 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2707 * fns.c (concat): Minor tuning based on overflow analysis.
2708 This doesn't fix any bugs. Use int to hold character, instead
2709 of constantly refetching from Emacs object. Use XFASTINT, not
2710 XINT, for value known to be a character. Don't bother comparing
2711 a single byte to 0400, as it's always less.
2713 * floatfns.c (Fexpt):
2714 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2716 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2719 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2721 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2722 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2723 incorrectly succeed when S was a string, because 4294967386 was
2724 truncated before it was used.
2726 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2727 Otherwise, an out-of-range integer could cause undefined behavior
2730 * composite.c: Use int, not EMACS_INT, for characters.
2731 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2732 EMACS_INT, for values that are known to be in character range.
2733 This doesn't fix any bugs but is the usual style inside Emacs and
2734 may generate better code on 32-bit machines.
2736 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2737 This is for reasons similar to the recent CHAR_STRING fix.
2738 * charset.c (Fencode_char): Check that character arg is actually
2739 a character. Pass an int to ENCODE_CHAR.
2740 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2741 wider than 'int', as a compile-time check to prevent future regressions
2744 * character.c (char_string): Remove unnecessary casts.
2746 Make sure a 64-bit char is never passed to CHAR_STRING.
2747 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2748 by silently ignoring the top 32 bits, allowing some values
2749 that were far too large to be valid characters.
2750 * character.h: Include <verify.h>.
2751 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2752 arguments are no wider than unsigned, as a compile-time check
2753 to prevent future regressions in this area.
2755 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2756 (Fsubst_char_in_region):
2758 * xdisp.c (decode_mode_spec_coding):
2759 Adjust to CHAR_STRING's new requirement.
2760 * editfns.c (Finsert_char, Fsubst_char_in_region):
2761 * fns.c (concat): Check that character args are actually
2762 characters. Without this test, these functions did the wrong
2763 thing with wildly out-of-range values on 64-bit hosts.
2765 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2766 These casts should not be needed on 32-bit hosts, either.
2767 * keyboard.c (read_char):
2768 * lread.c (Fload): Remove casts to unsigned.
2770 * lisp.h (UNSIGNED_CMP): New macro.
2771 This fixes comparison bugs on 64-bit hosts.
2772 (ASCII_CHAR_P): Use it.
2773 * casefiddle.c (casify_object):
2774 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2775 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2776 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2777 * dispextern.h (FACE_FROM_ID):
2778 * keyboard.c (read_char): Use UNSIGNED_CMP.
2780 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2781 not to EMACS_INT, to avoid GCC warning.
2783 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2785 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2786 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2787 isn't needed on 32-bit machines.
2789 * buffer.c (Fgenerate_new_buffer_name):
2790 Use EMACS_INT for count, not int.
2791 (advance_to_char_boundary): Return EMACS_INT, not int.
2793 * data.c (Qcompiled_function): Now static.
2795 * window.c (window_body_lines): Now static.
2797 * image.c (gif_load): Rename local to avoid shadowing.
2799 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2800 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2801 * alloc.c (make_save_value): Integer argument is now of type
2803 (mark_object): Use ptrdiff_t, not int.
2804 * lisp.h (pD): New macro.
2805 * print.c (print_object): Use it.
2807 * alloc.c: Use EMACS_INT, not int, to count objects.
2808 (total_conses, total_markers, total_symbols, total_vector_size)
2809 (total_free_conses, total_free_markers, total_free_symbols)
2810 (total_free_floats, total_floats, total_free_intervals)
2811 (total_intervals, total_strings, total_free_strings):
2812 Now EMACS_INT, not int. All uses changed.
2813 (Fgarbage_collect): Compute overall total using a double, so that
2814 integer overflow is less likely to be a problem. Check for overflow
2815 when converting back to an integer.
2816 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2817 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2818 These were 'int' variables that could overflow on 64-bit hosts;
2819 they were never used, so remove them instead of repairing them.
2820 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2821 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2822 Previously, this ceilinged at INT_MAX, but that doesn't work on
2824 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2826 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2827 (allocate_vectorlike): Check for ptrdiff_t overflow.
2828 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2829 when a (possibly-narrower) signed value would do just as well.
2830 We prefer using signed arithmetic, to avoid comparison confusion.
2832 * alloc.c: Catch some string size overflows that we were missing.
2833 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2834 for convenience in STRING_BYTES_MAX.
2835 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2836 The definition here is exact; the one in lisp.h was approximate.
2837 (allocate_string_data): Check for string overflow. This catches
2838 some instances we weren't catching before. Also, it catches
2839 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2840 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2841 and ptrdiff_t and EMACS_INT are both 64 bits.
2843 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2844 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2845 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2847 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2849 * alloc.c (Fmake_string): Check for out-of-range init.
2851 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2853 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2855 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2857 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2858 xg_get_default_scrollbar_width.
2860 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2861 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2862 (style_changed_cb): Call update_theme_scrollbar_width and call
2863 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2864 all frames (Bug#8505).
2865 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2866 Call gtk_window_set_resizable if HAVE_GTK3.
2867 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2868 and height if HAVE_GTK3 (Bug#8505).
2869 (scroll_bar_width_for_theme): New variable.
2870 (update_theme_scrollbar_width): New function.
2871 (xg_get_default_scrollbar_width): Move code to
2872 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2873 (xg_initialize): Call update_theme_scrollbar_width.
2875 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2877 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2879 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2881 * frame.c (make_frame): Call other_buffer_safely instead of
2884 * window.c (temp_output_buffer_show): Call display_buffer with
2885 second argument Vtemp_buffer_show_specifiers and reset latter
2886 immediately after the call.
2887 (Vtemp_buffer_show_specifiers): New variable.
2888 (auto_window_vscroll_p, next_screen_context_lines)
2889 (Vscroll_preserve_screen_position): Remove leading asterisks from
2892 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2894 Fix minor problems found by GCC 4.6.0 static checking.
2895 * buffer.c (Qclone_number): Remove for now, as it's unused.
2896 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2897 (record_buffer): Remove unused local.
2898 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2899 (set_frame_buffer_list): Remove; unused.
2900 * frame.h (other_visible_frames): Remove decl.
2901 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2902 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2903 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2905 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2906 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2907 Define only if HAVE_GPM.
2908 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2909 (update_hints_inhibit): Remove; never set. All uses removed.
2910 * widgetprv.h (emacsFrameClassRec): Remove decl.
2911 * window.c (delete_deletable_window): Now returns void, since it
2912 wasn't returning anything.
2913 (compare_window_configurations): Remove unused locals.
2914 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2915 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2916 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2917 the same widths as pointers. This follows up on the 2011-05-06 patch.
2918 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2919 * xterm.h: Likewise.
2920 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2922 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2924 * makefile.w32-in: Update dependencies.
2925 (LISP_H): Add lib/intprops.h.
2927 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2929 * image.c (gif_load): Add animation frame delay to the metadata.
2930 (syms_of_image): Use DEFSYM. New symbol `delay'.
2932 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2934 * window.c (delete_deletable_window): Re-add.
2935 (Fset_window_configuration): Rewrite to handle dead buffers and
2936 consequently deletable windows.
2937 (window_tree, Fwindow_tree): Remove. Supply functionality in
2939 (compare_window_configurations): Simplify code.
2941 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2943 * image.c (imagemagick_load_image): Fix type mismatch.
2944 (Fimagemagick_types): Likewise.
2946 * window.h (replace_buffer_in_windows): Declare.
2948 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2950 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2951 Qclone_number. Remove external declaration of Qdelete_window.
2952 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2954 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2955 Run Qbuffer_list_update_hook if allowed.
2956 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2957 buffer list implementation.
2958 (other_buffer_safely): New function.
2959 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2960 calls to replace_buffer_in_windows and
2961 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2963 (record_buffer): Inhibit quitting and rewrite using quittable
2964 functions. Run Qbuffer_list_update_hook if allowed.
2965 (Frecord_buffer, Funrecord_buffer): New functions.
2966 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2967 Move switch-to-buffer to window.el.
2968 (bury-buffer): Move to window.el.
2969 (Vbuffer_list_update_hook): New variable.
2971 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2974 * window.h (resize_frame_windows): Move up in code.
2975 (Fwindow_frame): Remove EXFUN.
2976 (replace_buffer_in_all_windows): Remove prototype.
2977 (replace_buffer_in_windows_safely): Add prototype.
2979 * window.c: Declare Qdelete_window static again. Move down
2980 declaration of select_count.
2981 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2982 (Fother_window): Move to window.el.
2983 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2984 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2985 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2987 (replace_buffer_in_windows): Implement by calling
2988 Qreplace_buffer_in_windows.
2989 (replace_buffer_in_all_windows): Remove with some functionality
2990 moved into replace_buffer_in_windows_safely.
2991 (replace_buffer_in_windows_safely): New function.
2992 (select_window_norecord, select_frame_norecord): Move in front
2993 of run_window_configuration_change_hook. Remove now obsolete
2995 (Fset_window_buffer): Rewrite doc-string.
2996 Call Qrecord_window_buffer.
2997 (keys_of_window): Move binding for other-window to window.el.
2999 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3001 * dispextern.h (struct image): Replace data member, whose int_val
3002 and ptr_val fields were not used by anything, with a single
3005 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3006 (gif_clear_image, gif_load, imagemagick_load_image)
3007 (gs_clear_image, gs_load): Callers changed.
3009 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3011 * buffer.h: Include <time.h>, for time_t.
3012 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3014 Fix minor problems found by static checking.
3016 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3018 Make identifiers static if they are not used in other modules.
3019 * data.c (Qcompiled_function, Qframe, Qvector):
3020 * image.c (QimageMagick, Qsvg):
3021 * minibuf.c (Qmetadata):
3022 * window.c (resize_window_check, resize_root_window): Now static.
3023 * window.h (resize_window_check, resize_root_window): Remove decls.
3025 * window.c (window_deletion_count, delete_deletable_window):
3027 (window_body_lines): Now static.
3028 (Fdelete_other_windows_internal): Mark vars as initialized.
3029 Make sure 'resize_failed' is initialized.
3030 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3031 (resize_window_apply): Remove unused local.
3032 * window.h (delete_deletable_window): Remove decl.
3034 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3035 (imagemagick_load_image): Fix pointer signedness problem by changing
3036 last arg from unsigned char * to char *. All uses changed.
3037 Also, fix a local for similar reasons.
3038 Remove unused locals. Remove locals to avoid shadowing.
3039 (fn_rsvg_handle_free): Remove; unused.
3040 (svg_load, svg_load_image): Fix pointer signedness problem.
3041 (imagemagick_load_image): Don't use garbage pointer image_wand.
3043 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3045 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3047 * image.c (gif_load): Fix omitted cast error introduced by
3050 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3052 * window.h (resize_proportionally, orig_total_lines)
3053 (orig_top_line): Remove from window structure.
3054 (set_window_height, set_window_width, change_window_heights)
3055 (Fdelete_window): Remove prototypes.
3056 (resize_frame_windows): Remove duplicate declaration.
3058 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3060 * window.h (resize_frame_windows, resize_window_check)
3061 (delete_deletable_window, resize_root_window)
3062 (resize_frame_windows): Declare prototypes.
3064 * window.c (resize_window_apply): Make definition be "static" to
3065 match the prototype.
3067 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3069 * window.c: Remove declarations of Qwindow_size_fixed,
3070 window_min_size_1, window_min_size_2, window_min_size,
3071 size_window, window_fixed_size_p, enlarge_window, delete_window.
3072 Remove static from declaration of Qdelete_window, it's
3073 temporarily needed by Fbury_buffer.
3074 (replace_window): Don't assign orig_top_line and
3076 (Fdelete_window, delete_window): Remove. Window deletion is
3077 handled by window.el.
3078 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3079 Replace Fdelete_window calls with calls to Qdelete_window.
3080 (Fdelete_other_windows): Remove. Deleting other windows is
3081 handled by window.el.
3082 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3083 handled in window.el.
3084 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3085 Window minimum sizes are handled in window.el.
3086 (shrink_windows, size_window, set_window_height)
3087 (set_window_width, change_window_heights, window_height)
3088 (window_width, CURBEG, CURSIZE, enlarge_window)
3089 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3090 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3091 handled in window.el.
3092 (make_dummy_parent): Rename to make_parent_window and give it a
3093 second argument horflag.
3094 (make_window): Don't set resize_proportionally any more.
3095 (Fsplit_window): Remove. Windows are split in window.el.
3096 (save_restore_action, save_restore_orig_size)
3097 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3098 Resize mini windows in window.el.
3099 (grow_mini_window, shrink_mini_window): Implement by calling
3100 Qresize_root_window_vertically, resize_window_check and
3101 resize_window_apply.
3102 (saved_window, Fset_window_configuration, save_window_save):
3103 Do not handle orig_top_line, orig_total_lines, and
3104 resize_proportionally.
3105 (window_min_height, window_min_width): Move to window.el.
3106 (keys_of_window): Move bindings for delete-other-windows,
3107 split-window, delete-window and enlarge-window to window.el.
3109 * buffer.c: Temporarily extern Qdelete_window.
3110 (Fbury_buffer): Temporarily call Qdelete_window instead of
3111 Fdelete_window (Fbury_buffer will move to window.el soon).
3113 * frame.c (set_menu_bar_lines_1): Remove code handling
3114 orig_top_line and orig_total_lines.
3116 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3117 set_window_height but set heights directly.
3118 (change_frame_size_1): Use resize_frame_windows.
3120 * xdisp.c (init_xdisp): Don't use set_window_height but set
3123 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3124 Use resize_frame_windows instead of change_window_heights and run
3125 run_window_configuration_change_hook.
3127 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3128 instead of change_window_heights and run
3129 run_window_configuration_change_hook.
3131 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3133 * window.c (replace_window): Rename second argument REPLACEMENT to
3134 NEW. New third argument SETFLAG. Rewrite.
3135 (delete_window, make_dummy_parent): Call replace_window with
3137 (window_list_1): Move down in code.
3138 (run_window_configuration_change_hook): Move set_buffer part
3139 before select_frame_norecord part in order to unwind correctly.
3140 Rename count1 to count.
3141 (recombine_windows, delete_deletable_window, resize_root_window)
3142 (Fdelete_other_windows_internal)
3143 (Frun_window_configuration_change_hook, make_parent_window)
3144 (resize_window_check, resize_window_apply, Fresize_window_apply)
3145 (resize_frame_windows, Fsplit_window_internal)
3146 (Fdelete_window_internal, Fresize_mini_window_internal):
3148 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3150 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3152 * window.h (window): Add some new members to window structure -
3153 normal_lines, normal_cols, new_total, new_normal, clone_number,
3154 splits, nest, prev_buffers, next_buffers.
3155 (WINDOW_TOTAL_SIZE): Move here from window.c.
3156 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3158 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3160 (make_dummy_parent): Set new members of windows structure.
3161 (make_window): Move down in code. Handle new members of window
3163 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3164 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3165 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3166 (Fset_window_prev_buffers, Fwindow_next_buffers)
3167 (Fset_window_next_buffers, Fset_window_clone_number):
3169 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3170 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3172 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3173 Argument WINDOW can be now internal window too.
3174 (Fwindow_use_time): Move up in code.
3175 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3177 (Fset_window_configuration, saved_window)
3178 (Fcurrent_window_configuration, save_window_save): Handle new
3179 members of window structure.
3180 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3181 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3182 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3183 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3184 Qget_mru_window, Qresize_root_window,
3185 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3186 Qauto_buffer_name; staticpro them.
3188 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3190 * window.c (Fwindow_total_size, Fwindow_left_column)
3191 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3192 (Fwindow_list_1): New functions.
3193 (window_box_text_cols): Replace with window_body_cols.
3194 (Fwindow_width, Fscroll_left, Fscroll_right):
3195 Use window_body_cols instead of window_box_text_cols.
3196 (delete_window, Fset_window_configuration):
3197 Call delete_all_subwindows with window as argument.
3198 (delete_all_subwindows): Take a window as argument and not a
3200 (window_loop): Remove handling of GET_LRU_WINDOW and
3202 (Fget_lru_window, Fget_largest_window): Move to window.el.
3204 * window.h: Extern window_body_cols instead of
3205 window_box_text_cols. delete_all_subwindows now takes a
3206 Lisp_Object as argument.
3208 * indent.c (compute_motion, Fcompute_motion):
3209 Use window_body_cols instead of window_box_text_cols.
3211 * frame.c (delete_frame): Call delete_all_subwindows with root
3214 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3216 * fns.c (Fputhash): Document return value.
3218 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3220 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3222 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3224 Cons<->int and similar integer overflow fixes (Bug#8794).
3226 Check for overflow when converting integer to cons and back.
3227 * charset.c (Fdefine_charset_internal, Fdecode_char):
3228 Use cons_to_unsigned to catch overflow.
3229 (Fencode_char): Use INTEGER_TO_CONS.
3230 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3231 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3232 * data.c (long_to_cons, cons_to_long): Remove.
3233 (cons_to_unsigned, cons_to_signed): New functions.
3234 These signal an error for invalid or out-of-range values.
3235 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3236 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3237 * font.c (Ffont_variation_glyphs):
3238 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3239 * lisp.h: Include <intprops.h>.
3240 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3241 (cons_to_signed, cons_to_unsigned): New decls.
3242 (long_to_cons, cons_to_long): Remove decls.
3243 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3244 (Fprimitive_undo): Use CONS_TO_INTEGER.
3245 * xfns.c (Fx_window_property): Likewise.
3246 * xselect.c: Include <limits.h>.
3247 (x_own_selection, selection_data_to_lisp_data):
3248 Use INTEGER_TO_CONS.
3249 (x_handle_selection_request, x_handle_selection_clear)
3250 (x_get_foreign_selection, Fx_disown_selection_internal)
3251 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3252 (lisp_data_to_selection_data): Use cons_to_unsigned.
3253 (x_fill_property_data): Use cons_to_signed.
3254 Report values out of range.
3256 Check for buffer and string overflow more precisely.
3257 * buffer.h (BUF_BYTES_MAX): New macro.
3258 * lisp.h (STRING_BYTES_MAX): New macro.
3259 * alloc.c (Fmake_string):
3260 * character.c (string_escape_byte8):
3261 * coding.c (coding_alloc_by_realloc):
3262 * doprnt.c (doprnt):
3263 * editfns.c (Fformat):
3265 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3266 since they may not be the same number.
3267 * editfns.c (Finsert_char):
3268 * fileio.c (Finsert_file_contents):
3269 Likewise for BUF_BYTES_MAX.
3271 * image.c: Use ptrdiff_t, not int, for sizes.
3272 (slurp_file): Switch from int to ptrdiff_t.
3274 (slurp_file): Check that file size fits in both size_t (for
3275 malloc) and ptrdiff_t (for sanity and safety).
3277 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3278 if b->modtime has its maximal value.
3280 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3282 Don't assume time_t can fit into int.
3283 * buffer.h (struct buffer.modtime): Now time_t, not int.
3284 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3285 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3287 Minor fixes for signed vs unsigned integers.
3288 * character.h (MAYBE_UNIFY_CHAR):
3289 * charset.c (maybe_unify_char):
3290 * keyboard.c (read_char, reorder_modifiers):
3291 XINT -> XFASTINT, since the integer must be nonnegative.
3292 * ftfont.c (ftfont_spec_pattern):
3293 * keymap.c (access_keymap, silly_event_symbol_error):
3294 XUINT -> XFASTINT, since the integer must be nonnegative.
3295 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3296 since it makes no difference and we prefer signed.
3297 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3298 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3301 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3303 * window.h (Fwindow_frame): Declare.
3305 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3307 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3308 (SPARE_MEMORY): Always define.
3309 (LARGE_REQUEST): Remove.
3310 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3312 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3314 * lisp.h: Move EXFUNS for Fframe_root_window,
3315 Fframe_first_window and Fset_frame_selected_window to window.h.
3317 * window.h: Move EXFUNS for Fframe_root_window,
3318 Fframe_first_window and Fset_frame_selected_window here from
3321 * frame.c (Fwindow_frame, Fframe_first_window)
3322 (Fframe_root_window, Fframe_selected_window)
3323 (Fset_frame_selected_window): Move to window.c.
3324 (Factive_minibuffer_window): Move to minibuf.c.
3325 (Fother_visible_frames_p): New function.
3327 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3329 * window.c (decode_window, decode_any_window): Move up in code.
3330 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3331 (inhibit_frame_unsplittable): Remove unused variable.
3332 (Fwindow_buffer): Move up and rewrite doc-string.
3333 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3334 (Fwindow_prev): New functions.
3335 (Fwindow_frame): Move here from frame.c. Accept any window as
3337 (Fframe_root_window, Fframe_first_window)
3338 (Fframe_selected_window): Move here from frame.c. Accept frame
3339 or arbitrary window as argument. Update doc-strings.
3340 (Fminibuffer_window): Move up in code.
3341 (Fwindow_minibuffer_p): Move up in code and simplify.
3342 (Fset_frame_selected_window): Move here from frame.c.
3344 (Fselected_window, select_window, Fselect_window): Move up in
3345 code. Minor doc-string fixes.
3347 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3349 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3350 Do not assume that spare memory exists; that assumption is valid
3351 only if SYSTEM_MALLOC.
3352 (LARGE_REQUEST): New macro, so that the issue of large requests
3353 is separated from the issue of spare memory.
3355 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3357 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3360 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3362 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3365 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3367 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3369 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3371 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3372 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3374 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3376 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3378 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3380 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3381 (x_clipboard_manager_save): Add return value.
3382 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3384 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3385 Obey Vx_select_enable_clipboard_manager. Catch errors in
3386 x_clipboard_manager_save (Bug#8779).
3387 (Vx_select_enable_clipboard_manager): New variable.
3388 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3390 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3392 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3394 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3396 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3397 in the current matrix if keep_current_p is non-zero.
3399 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3401 * bidi.c (bidi_level_of_next_char): Fix last change.
3403 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3405 Support bidi reordering of text covered by display properties.
3407 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3408 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3409 (bidi_cache_search, bidi_cache_iterator_state)
3410 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3411 (bidi_level_of_next_char, bidi_move_to_visually_next):
3412 Support character positions inside a run of characters covered by a
3414 (bidi_paragraph_init, bidi_resolve_explicit_1)
3415 (bidi_level_of_next_char): Call bidi_fetch_char and
3416 bidi_fetch_char_advance instead of FETCH_CHAR and
3418 (bidi_init_it): Initialize new members.
3419 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3421 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3422 instead of using explicit *_CHAR codes.
3423 (bidi_resolve_explicit, bidi_resolve_weak):
3424 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3425 bidirectional text is supported only in multibyte buffers.
3426 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3427 it to initialize the frame_window_p member of struct bidi_it.
3428 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3429 (bidi_resolve_explicit, bidi_resolve_weak)
3430 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3431 bidi_it->nchars is non-positive.
3432 (bidi_level_of_next_char): Don't try to lookup the cache for the
3433 next/previous character if nothing is cached there yet, or if we
3434 were just reseat()'ed to a new position.
3436 * xdisp.c (set_cursor_from_row): Set start and stop points
3437 according to the row's direction when priming the loop that looks
3438 for the glyph on which to display cursor.
3439 (single_display_spec_intangible_p): Function deleted.
3440 (display_prop_intangible_p): Reimplement to call
3441 handle_display_spec instead of single_display_spec_intangible_p.
3442 Accept 3 additional arguments needed by handle_display_spec.
3443 This fixes incorrect cursor motion across display property with complex
3444 values: lists, `(when COND...)' forms, etc.
3445 (single_display_spec_string_p): Support property values that are
3446 lists with the argument STRING its top-level element.
3447 (display_prop_string_p): Fix the condition for processing a
3448 property that is a list to be consistent with handle_display_spec.
3449 (handle_display_spec): New function, refactored from the
3450 last portion of handle_display_prop.
3451 (compute_display_string_pos): Accept additional argument
3452 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3453 value of a `display' property is a "replacing spec".
3454 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3455 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3456 the display property, but just return a value indicating whether
3457 the display property will replace the characters it covers.
3458 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3459 frame_window_p members of struct bidi_it.
3460 (compute_display_string_pos, compute_display_string_end):
3462 (push_it): Accept second argument POSITION, where pop_it should
3463 jump to continue iteration.
3464 (reseat_1): Initialize bidi_it.disp_pos.
3466 * keyboard.c (adjust_point_for_property): Adjust the call to
3467 display_prop_intangible_p to its new signature.
3469 * dispextern.h (struct bidi_it): New member frame_window_p.
3470 (bidi_init_it): Update prototypes.
3471 (display_prop_intangible_p): Update prototype.
3472 (compute_display_string_pos, compute_display_string_end):
3474 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3477 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3479 Malloc failure behavior now depends on size of allocation.
3480 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3481 * lisp.h: Change signatures accordingly.
3482 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3483 All callers changed. (Bug#8762)
3485 * gnutls.c: Use Emacs's memory allocators.
3486 Without this change, the gnutls library would invoke malloc etc.
3487 directly, which causes problems on non-SYNC_INPUT hosts, and which
3488 runs afoul of improving memory_full behavior. (Bug#8761)
3489 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3490 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3491 xfree instead of the default malloc, realloc, free.
3492 (Fgnutls_boot): No need to check for memory allocation failure,
3493 since xmalloc does that for us.
3495 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3496 * category.c (hash_get_category_set):
3497 * ccl.c (ccl_driver):
3498 * charset.c (Fdefine_charset_internal):
3499 * charset.h (struct charset.hash_index):
3500 * composite.c (get_composition_id, gstring_lookup_cache)
3501 (composition_gstring_put_cache):
3502 * composite.h (struct composition.hash_index):
3503 * dispextern.h (struct image.hash):
3504 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3505 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3506 (hashfn_equal, hashfn_user_defined, make_hash_table)
3507 (maybe_resize_hash_table, hash_lookup, hash_put)
3508 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3509 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3510 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3511 * image.c (make_image, search_image_cache, lookup_image)
3512 (xpm_put_color_table_h):
3513 * lisp.h (struct Lisp_Hash_Table):
3514 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3515 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3516 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3517 * alloc.c (allocate_vectorlike):
3518 Check for overflow in vector size calculations.
3519 * ccl.c (ccl_driver):
3520 Check for overflow when converting EMACS_INT to int.
3521 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3522 need to be updated by these changes.
3523 * fns.c (make_hash_table, maybe_resize_hash_table):
3524 Check for integer overflow with large hash tables.
3525 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3526 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3527 (SXHASH_REDUCE): New macro.
3528 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3529 Use it instead of discarding useful hash info with large hash values.
3530 (sxhash_float): New function.
3531 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3532 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3533 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3534 Rewrite to use FIXNUM_BITS, as this simplifies things.
3535 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3536 Adjust signatures to match updated version of code.
3537 (consing_since_gc): Now EMACS_INT, since a single hash table can
3538 use more than INT_MAX bytes.
3540 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3542 Make it possible to build with GCC-4.6+ -O2 -flto.
3544 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3546 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3548 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3549 Call minibuffer-inactive-mode.
3551 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3553 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3554 Update dependencies.
3556 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3558 * data.c (init_data): Remove code for UTS, this system is not
3561 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3563 Don't force ./temacs to start in terminal mode.
3565 * frame.c (make_initial_frame): Initialize faces in all cases, not
3566 only when CANNOT_DUMP is defined.
3567 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3569 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3571 * dispnew.c (add_window_display_history): Use const for the string
3572 pointer. Remove declaration, not needed.
3574 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3576 Use 'inline', not 'INLINE'.
3577 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3578 * alloc.c, fontset.c (INLINE): Remove.
3579 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3580 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3581 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3582 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3583 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3585 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3587 Make it possible to run ./temacs.
3589 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3590 syms_of_callproc does the same thing. Remove test for
3591 "initialized", do it in the caller.
3592 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3594 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3596 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3597 (read_minibuf): Use get_minibuffer.
3598 (syms_of_minibuf): Use DEFSYM.
3599 (Qmetadata): New var.
3600 * data.c (Qbuffer): Don't make it static.
3601 (syms_of_data): Use DEFSYM.
3603 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3605 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3606 (CCL_CODE_MIN): New macro.
3608 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3610 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3612 * eval.c (Qdebug): Now static.
3613 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3614 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3615 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3617 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3619 * image.c: Various fixes to ImageMagick code comments.
3620 (Fimagemagick_types): Doc fix.
3622 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3624 Minor fixes prompted by GCC 4.6.0 warnings.
3626 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3628 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3629 (x_clipboard_manager_save_all): Move extern decl to ...
3630 * xterm.h: ... here, so that it can be checked for consistency.
3632 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3634 * xselect.c (x_clipboard_manager_save_frame)
3635 (x_clipboard_manager_save_all): New functions.
3636 (Fx_clipboard_manager_save): Lisp function deleted.
3638 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3639 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3641 * xterm.h: Update prototype.
3643 2011-05-28 William Xu <william.xwl@gmail.com>
3645 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3648 2011-05-28 Jim Meyering <meyering@redhat.com>
3650 Avoid a sign-extension bug in crypto_hash_function.
3651 * fns.c (to_uchar): Define.
3652 (crypto_hash_function): Use it to convert some newly-signed
3653 variables to unsigned, to avoid sign-extension bugs. For example,
3654 without this change, (md5 "truc") would evaluate to
3655 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3656 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3657 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3659 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3661 Integer overflow fixes.
3663 * dbusbind.c: Serial number integer overflow fixes.
3664 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3665 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3666 to hold a serial number that is too large for a fixnum.
3667 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3668 Check for serial numbers out of range. Decode any serial number
3669 that was so large that it became a float. (Bug#8722)
3671 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3672 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3673 Use XFASTINT rather than XUINT when numbers are nonnegative.
3674 (xd_append_arg, Fdbus_method_return_internal):
3675 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3676 arguments, check that Lisp number is nonnegative, rather than
3677 silently wrapping negative numbers around. (Bug#8722)
3678 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3681 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3683 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3685 ccl: add integer overflow checks
3686 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3687 (IN_INT_RANGE): New macros.
3688 (ccl_driver): Use them to check for integer overflow when
3689 decoding a CCL program. Many of the new checks are whether XINT (x)
3690 fits in int; it doesn't always, on 64-bit hosts. The new version
3691 doesn't catch all possible integer overflows, but it's an
3692 improvement. (Bug#8719)
3694 * alloc.c (make_event_array): Use XINT, not XUINT.
3695 There's no need for unsigned here.
3697 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3698 This follows up to the 2011-05-06 change that substituted uintptr_t
3699 for EMACS_INT. This case wasn't caught back then.
3701 Rework Fformat to avoid integer overflow issues.
3702 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3703 now (part of C89). Include <verify.h>.
3704 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3705 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3706 (Fformat): Avoid the prepass trying to compute sizes; it was only
3707 approximate and thus did not catch overflow reliably. Instead, walk
3708 through the format just once, formatting and computing sizes as we go,
3709 checking for integer overflow at every step, and allocating a larger
3710 buffer as needed. Keep track separately whether the format is
3711 multibyte. Keep only the most-recently calculated precision, rather
3712 than them all. Record whether each argument has been converted to
3713 string. Use EMACS_INT, not int, for byte and char and arg counts.
3714 Support field widths and precisions larger than INT_MAX. Avoid
3715 sprintf's undefined behavior with conversion specifications such as %#d
3716 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3717 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3718 formatting out-of-range floating point numbers with int
3721 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3723 * data.c: Avoid integer truncation in expressions involving floats.
3724 * data.c: Include <intprops.h>.
3725 (arith_driver): When there's an integer overflow in an expression
3726 involving floating point, convert the integers to floating point
3727 so that the resulting value does not suffer from catastrophic
3728 integer truncation. For example, on a 64-bit host (* 4
3729 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3730 Do not rely on undefined behavior after integer overflow.
3732 merge count_size_as_multibyte, parse_str_to_multibyte
3733 * character.c, character.h (count_size_as_multibyte):
3734 Rename from parse_str_to_multibyte; all uses changed.
3735 Check for integer overflow.
3736 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3737 since it's now a duplicate of the other. This is more of
3738 a character than a buffer op, so better that it's in character.c.
3739 * fns.c, print.c: Adjust to above changes.
3741 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3743 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3745 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3747 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3748 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3749 (x_clipboard_manager_save): Now static.
3750 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3752 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3753 (crypto_hash_function): Now static.
3754 Fix pointer signedness problems. Avoid unnecessary initializations.
3756 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3758 * termhooks.h (Vselection_alist): Make it terminal-local.
3760 * terminal.c (create_terminal): Initialize it.
3762 * xselect.c: Support for clipboard managers.
3763 (Vselection_alist): Move to termhooks.h as terminal-local var.
3764 (LOCAL_SELECTION): New macro.
3765 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3766 (symbol_to_x_atom): Remove gratuitous arg.
3767 (x_handle_selection_request, lisp_data_to_selection_data)
3768 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3769 (x_own_selection, x_get_local_selection, x_convert_selection):
3770 New arg, specifying work frame. Use terminal-local Vselection_alist.
3771 (some_frame_on_display): Delete unused function.
3772 (Fx_own_selection_internal, Fx_get_selection_internal)
3773 (Fx_disown_selection_internal, Fx_selection_owner_p)
3774 (Fx_selection_exists_p): New optional frame arg.
3775 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3776 (x_handle_selection_clear): Don't treat other terminals with the
3777 same keyboard specially. Use the terminal-local Vselection_alist.
3778 (x_clear_frame_selections): Use Frun_hook_with_args.
3780 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3782 * xterm.h: Add support for those atoms.
3784 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3786 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3787 (converted_selections, conversion_fail_tag): New global variables.
3788 (x_selection_request_lisp_error): Free the above.
3789 (x_get_local_selection): Remove unnecessary code.
3790 (x_reply_selection_request): Args changed; handle arbitrary array
3791 of converted selections stored in converted_selections.
3792 Separate the XChangeProperty and SelectionNotify steps.
3793 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3794 (x_convert_selection): New function.
3795 (x_handle_selection_event): Simplify.
3796 (x_get_foreign_selection): Don't ignore incoming requests while
3797 waiting for an answer; this will fail when we implement
3798 SAVE_TARGETS, and seems unnecessary anyway.
3799 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3800 (Vx_sent_selection_functions): Doc fix.
3802 2011-05-26 Leo Liu <sdl.web@gmail.com>
3804 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3806 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3808 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3810 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3811 for fringe update if it has periodic bitmap.
3812 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3813 and fringe_bitmap_periodic_p.
3815 * fringe.c (get_fringe_bitmap_data): New function.
3816 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3817 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3818 row. Mark glyph row for fringe update if periodicity changed.
3820 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3821 for fringe update unless it has periodic bitmap.
3823 2011-05-25 Kenichi Handa <handa@m17n.org>
3825 * xdisp.c (get_next_display_element): Set correct it->face_id for
3826 a static composition.
3828 2011-05-24 Leo Liu <sdl.web@gmail.com>
3831 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3833 * fns.c (crypto_hash_function, Fsha1): New function.
3834 (Fmd5): Use crypto_hash_function.
3835 (syms_of_fns): Add Ssha1.
3837 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3839 * gnutls.c: Remove unused macros.
3840 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3841 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3842 Remove macros that are defined and never used.
3843 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3845 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3847 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3848 (Fx_get_selection_internal): Minor cleanup.
3849 (Fx_own_selection_internal): Rename arguments for consistency with
3852 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3854 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3856 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3858 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3860 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3862 * dispnew.c (scrolling_window): Don't exclude the case that the
3863 last enabled row in the desired matrix touches the bottom boundary.
3865 2011-05-21 Glenn Morris <rgm@gnu.org>
3867 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3868 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3869 and add some more files.
3871 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3873 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3874 report_file_error introduced by the change from 2011-05-07.
3876 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3878 * systime.h (Time): Define only if emacs is defined.
3879 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3880 where the include path doesn't have X11/X.h by default. See
3881 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3883 2011-05-20 Kenichi Handa <handa@m17n.org>
3885 * composite.c (find_automatic_composition): Fix previous change.
3887 2011-05-20 Glenn Morris <rgm@gnu.org>
3889 * lisp.mk: New file, split from Makefile.in.
3890 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3891 (shortlisp): Remove.
3892 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3894 2011-05-19 Glenn Morris <rgm@gnu.org>
3896 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3897 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3898 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3899 (lisp): Set the order to that of loadup.el.
3900 (shortlisp): Make it a copy of $lisp.
3901 (SOME_MACHINE_LISP): Remove.
3902 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3903 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3905 2011-05-18 Kenichi Handa <handa@m17n.org>
3907 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3908 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3909 (find_automatic_composition): Mostly rewrite for efficiency.
3911 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3913 * makefile.w32-in: Update dependencies.
3915 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3917 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3918 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3920 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3922 Fix some integer overflow issues, such as string length overflow.
3924 * insdel.c (count_size_as_multibyte): Check for string overflow.
3926 * character.c (lisp_string_width): Check for string overflow.
3927 Use EMACS_INT, not int, for string indexes and lengths; in
3928 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3929 the resulting string length overflows an EMACS_INT; instead,
3930 report a string overflow if no precision given. When checking for
3931 precision exhaustion, use a check that cannot possibly have
3932 integer overflow. (Bug#8675)
3933 * character.h (lisp_string_width): Adjust to new signature.
3935 * alloc.c (string_overflow): New function.
3936 (Fmake_string): Use it. This doesn't change behavior, but saves
3937 a few bytes and will simplify future changes.
3938 * character.c (string_escape_byte8): Likewise.
3939 * lisp.h (string_overflow): New decl.
3941 Fixups, following up to the user-interface timestamp change.
3942 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3943 for UI timestamps, instead of unsigned long.
3944 * msdos.c (mouse_get_pos): Likewise.
3945 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3946 * w32gui.h (Time): Define by including "systime.h" rather than by
3947 declaring it ourselves. (Bug#8664)
3949 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3950 * image.c (clear_image_cache): Likewise.
3952 * term.c (term_mouse_position): Don't assume time_t wraparound.
3954 Be more systematic about user-interface timestamps.
3955 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3956 and sometimes 'EMACS_UINT', to represent these timestamps.
3957 This change causes it to use 'Time' uniformly, as that's what X uses.
3958 This makes the code easier to follow, and makes it easier to catch
3959 integer overflow bugs such as Bug#8664.
3960 * frame.c (Fmouse_position, Fmouse_pixel_position):
3961 Use Time, not unsigned long, for user-interface timestamps.
3962 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3963 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3964 * keyboard.h (last_event_timestamp): Likewise.
3965 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3966 * menu.h (xmenu_show): Likewise.
3967 * term.c (term_mouse_position): Likewise.
3968 * termhooks.h (struct input_event.timestamp): Likewise.
3969 (struct terminal.mouse_position_hook): Likewise.
3970 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3971 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3972 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3973 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3975 * menu.h, termhooks.h: Include "systime.h", for Time.
3977 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3978 Don't assume that the difference between two unsigned long values
3979 can fit into an integer. At this point, we know button_down_time
3980 <= event->timestamp, so the difference must be nonnegative, so
3981 there's no need to cast the result if double-click-time is
3982 nonnegative, as it should be; check that it's nonnegative, just in
3983 case. This bug is triggered when events are more than 2**31 ms
3984 apart (about 25 days). (Bug#8664)
3986 * xselect.c (last_event_timestamp): Remove duplicate decl.
3987 (x_own_selection): Remove needless cast to unsigned long.
3989 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3990 that always fit in int. Use a sentinel instead of a counter, to
3991 avoid a temp and to allay GCC's concerns about possible int overflow.
3992 * frame.h (struct frame): Use int for menu_bar_items_used
3993 instead of EMACS_INT, since it always fits in int.
3995 * menu.c (grow_menu_items): Check for int overflow.
3997 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3999 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4000 Before, the code was not consistent. These values cannot exceed
4001 2**31 - 1 so there's no need to make them unsigned.
4002 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4003 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4004 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4006 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4008 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4009 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4010 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4011 presumably because the widths might not match.
4013 * window.c (size_window): Avoid needless test at loop start.
4015 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4017 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4019 2011-05-12 Drew Adams <drew.adams@oracle.com>
4021 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4023 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4025 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4026 `width' to `bar_area_x' and `bar_area_width', respectively.
4027 (x_scroll_run): Take account of fringe background extension.
4029 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4030 Rename local vars `left' and `width' to `bar_area_x' and
4031 `bar_area_width', respectively.
4032 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4033 background extension.
4035 2011-05-10 Jim Meyering <meyering@redhat.com>
4037 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4039 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4041 * image.c (Finit_image_library): Return t for built-in image types,
4042 like pbm and xbm. (Bug#8640)
4044 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4046 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4048 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4050 * w32console.c (Fset_screen_color): Doc fix.
4051 (Fget_screen_color): New function.
4052 (syms_of_ntterm): Defsubr it.
4054 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4055 unlink the temporary file if Fcall_process didn't create it in the
4057 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4058 child process will be redirected to a file specified with `:file'.
4059 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4060 cue to call_process_cleanup not to close that handle.
4062 2011-05-07 Ben Key <bkey76@gmail.com>
4064 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4065 one of two shell specific rules, either bootstrap-temacs-CMD or
4066 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4067 to the previous implementation of the bootstrap-temacs rule.
4068 The bootstrap-temacs-CMD rule is similar to the previous
4069 implementation of the bootstrap-temacs rule except that it
4070 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4073 These changes, along with some changes to nt/configure.bat,
4074 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4075 earlier fix to add support for --cflags and --ldflags options
4076 that include quotes so that it works whether make uses cmd or
4079 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4081 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4082 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4084 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4085 a string. Handle both cases.
4086 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4087 (Fdbus_register_method): Use Qinvalid_function.
4089 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4091 * makefile.w32-in: Update dependencies.
4092 (LISP_H): Add inttypes.h and stdin.h.
4093 (PROCESS_H): Add unistd.h.
4095 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4097 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4098 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4100 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4102 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4104 * term.c (vfatal): Remove stray call to va_end.
4105 It's not needed and the C Standard doesn't allow it here anyway.
4107 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4108 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4110 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4113 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4115 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4117 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4119 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4121 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4123 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4124 * charset.c (Fdefine_charset_internal): Don't initialize
4125 charset.code_space[15]. The value was garbage, on hosts with
4126 32-bit int (Bug#8600).
4128 * lread.c (read_integer): Be more consistent with string-to-number.
4129 Use string_to_number to do the actual conversion; this avoids
4130 rounding errors and fixes some other screwups. Without this fix,
4131 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4132 (digit_to_number): Move earlier, for benefit of read_integer.
4133 Return -1 if the digit is out of range for the base, -2 if it is
4134 not a digit in any supported base. (Bug#8602)
4136 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4138 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4139 to match comment at start of function. This also removes a
4140 GCC warning about overflow in a 32+64-bit port.
4142 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4144 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4145 Reported by Stefan Monnier in
4146 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4147 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4148 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4150 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4151 (EMACS_UINTPTR): Likewise, with uintptr_t.
4153 * lisp.h: Prefer 64-bit EMACS_INT if available.
4154 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4155 on 32-bit hosts that have 64-bit int, so that they can access
4157 However, temporarily disable this change unless the temporary
4158 symbol WIDE_EMACS_INT is defined.
4160 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4162 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4163 This removes an assumption that EMACS_INT and long are the same
4164 width as pointers. The assumption is true for Emacs porting targets
4165 now, but we want to make other targets possible.
4166 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4167 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4168 In the rest of the code, change types of integers that hold casted
4169 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4170 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4171 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4172 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4173 No need to cast type when ORing.
4174 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4175 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4176 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4177 assume EMACS_INT is the same width as char *.
4178 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4179 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4180 Remove no-longer-needed casts.
4181 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4182 (xg_tool_bar_help_callback, xg_make_tool_item):
4183 Use EMACS_INTPTR to hold an integer
4184 that will be cast to void *; this can avoid a GCC warning
4185 if EMACS_INT is not the same width as void *.
4186 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4187 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4188 (current_message_1, set_message_1):
4189 Use a local to convert to proper width without a cast.
4190 * xmenu.c (dialog_selection_callback): Likewise.
4192 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4193 Also, don't assume VALBITS / RAND_BITS is less than 5,
4194 and don't rely on undefined behavior when shifting a 1 left into
4196 * lisp.h (get_random): Change signature to match.
4198 * lread.c (hash_string): Use size_t, not int, for hash computation.
4199 Normally we prefer signed values; but hashing is special, because
4200 it's better to use unsigned division on hash table sizes so that
4201 the remainder is nonnegative. Also, size_t is the natural width
4202 for hashing into memory. The previous code used 'int', which doesn't
4203 retain enough info to hash well into very large tables.
4204 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4206 * dbusbind.c: Don't possibly lose pointer info when converting.
4207 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4208 Use XPNTR rather than XHASH, so that the high-order bits of
4209 the pointer aren't lost when converting through void *.
4211 * eval.c (Fautoload): Don't double-shift a pointer.
4213 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4215 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4217 * gnutls.c (DEF_GNUTLS_FN):
4218 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4220 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4222 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4225 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4227 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4228 New version that can reserve upto 2GB of heap space.
4230 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4232 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4234 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4236 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4237 `gnutls_certificate_set_x509_key_file'.
4239 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4241 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4242 Update dependencies.
4244 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4246 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4247 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4248 Remove unused parameter `fildes'.
4249 * process.c (read_process_output, send_process): Don't pass it.
4251 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4253 Fix previous change: the library cache is defined in w32.c.
4254 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4255 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4257 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4259 Implement dynamic loading of GnuTLS on Windows.
4261 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4262 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4263 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4266 * gnutls.c (Qgnutls_dll): Define.
4267 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4268 (gnutls_*): Declare function pointers.
4269 (init_gnutls_functions): New function to initialize function pointers.
4270 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4271 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4272 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4273 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4274 (emacs_gnutls_write, emacs_gnutls_read)
4275 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4276 (Fgnutls_available_p): New function.
4277 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4278 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4279 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4281 * image.c: Include w32.h.
4282 (Vimage_type_cache): Delete.
4283 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4284 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4285 (w32_delayed_load): Move to w32.c.
4287 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4289 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4290 (w32_delayed_load): Move from image.c. When loading a library, record
4291 its filename in the :loaded-from property of the library id.
4292 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4293 Initialize and staticpro them.
4294 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4296 * process.c: Include lisp.h before w32.h, not after.
4297 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4298 instead of gnutls_record_check_pending.
4300 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4302 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4304 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4305 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4308 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4310 * xterm.c (x_set_frame_alpha): Do not set property on anything
4311 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4313 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4315 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4317 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4319 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4320 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4321 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4322 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4323 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4324 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4325 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4326 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4327 (Qgnutls_bootprop_callbacks_verify): Make static.
4329 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4331 * callproc.c: Indentation fixup.
4333 * sysdep.c (wait_for_termination_1): Make static.
4334 (wait_for_termination, interruptible_wait_for_termination):
4335 Move after wait_for_termination_1.
4337 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4339 * sysdep.c (interruptible_wait_for_termination): New function
4340 which is like wait_for_termination, but allows keyboard
4343 * callproc.c (Fcall_process): Add (:file "file") as an option for
4345 (Fcall_process_region): Ditto.
4347 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4349 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4350 rather than `XVECTOR (FOO)->size'.
4352 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4353 inttypes.h, as a gnulib replacement is used if it not available in
4356 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4358 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4359 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4360 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4362 * coding.c (coding_alloc_by_realloc): Error out if destination
4363 will grow beyond MOST_POSITIVE_FIXNUM.
4364 (decode_coding_emacs_mule): Abort if there isn't enough place in
4365 charbuf for the composition carryover bytes. Reserve an extra
4366 space for up to 2 characters produced in a loop.
4367 (decode_coding_iso_2022): Abort if there isn't enough place in
4368 charbuf for the composition carryover bytes.
4370 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4372 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4373 aborting when %lld or %lll format is passed.
4374 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4375 %llo or %llx format is passed. (Bug#8545)
4377 * window.c (window_scroll_line_based): Use a marker instead of
4378 simple variables to record original value of point. (Bug#7952)
4380 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4381 produced by %s or %c overflows available buffer space. (Bug#8545)
4383 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4385 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4386 (SIZE_MAX): Move defn after all includes, as they might #define it.
4388 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4390 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4392 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4394 * keyboard.c (Qdelayed_warnings_hook): Define.
4395 (command_loop_1): Run `delayed-warnings-hook'
4396 if Vdelayed_warnings_list is non-nil.
4397 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4398 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4400 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4402 * doprnt.c (doprnt): Don't return value smaller than the buffer
4403 size if the message was truncated. (Bug#8545).
4405 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4407 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4408 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4410 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4412 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4414 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4416 * makefile.w32-in: Update dependencies.
4418 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4420 Improve `doprnt' and its usage. (Bug#8545)
4421 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4422 `format_end'. Remove support for %l as a conversion specifier.
4423 Don't use xrealloc. Improve diagnostics when the %l size modifier
4424 is used. Update the commentary.
4426 * eval.c (verror): Simplify calculation of size_t.
4428 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4431 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4433 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4436 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4438 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4439 This makes this file independent of the recent pseudovector change.
4441 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4443 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4445 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4446 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4447 Remove unused local.
4448 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4450 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4451 GCC 4.6.0 optimizes based on type-based alias analysis.
4452 For example, if b is of type struct buffer * and v of type struct
4453 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4454 != &v->size, and therefore "v->size = 1; b->size = 2; return
4455 v->size;" must therefore return 1. This assumption is incorrect
4456 for Emacs, since it type-puns struct Lisp_Vector * with many other
4457 types. To fix this problem, this patch adds a new type struct
4458 vectorlike_header that documents the constraints on layout of vectors
4459 and pseudovectors, and helps optimizing compilers not get fooled
4460 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4461 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4462 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4464 (XSETPVECTYPE): Rewrite in terms of new macro.
4465 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4466 This is a bit clearer, and further avoids the possibility of
4467 undesirable aliasing.
4468 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4469 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4470 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4471 since Lisp_Subr is a special case (no "next" field).
4472 (ASIZE): Now uses header.size rather than size.
4473 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4474 to avoid the hassle of writing XVECTOR (foo)->header.size.
4475 (struct vectorlike_header): New type.
4476 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4477 object, to help avoid aliasing.
4478 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4479 (SUBRP): Likewise, since Lisp_Subr is a special case.
4480 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4481 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4482 (struct Lisp_Hash_Table): Combine first two members into a single
4483 struct vectorlike_header member. All uses of "size" and "next" members
4484 changed to be "header.size" and "header.next".
4485 * buffer.h (struct buffer): Likewise.
4486 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4487 * frame.h (struct frame): Likewise.
4488 * process.h (struct Lisp_Process): Likewise.
4489 * termhooks.h (struct terminal): Likewise.
4490 * window.c (struct save_window_data, struct saved_window): Likewise.
4491 * window.h (struct window): Likewise.
4492 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4493 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4494 * buffer.c (init_buffer_once): Likewise.
4495 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4497 * process.c (Fformat_network_address): Use local var for size,
4500 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4502 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4503 * data.c (atof): Remove decl; no longer used or needed.
4504 (digit_to_number): Move to lread.c.
4505 (Fstring_to_number): Use new string_to_number function, to be
4506 consistent with how the Lisp reader treats infinities and NaNs.
4507 Do not assume that floating-point numbers represent EMACS_INT
4508 without losing information; this is not true on most 64-bit hosts.
4509 Avoid double-rounding errors, by insisting on integers when
4510 parsing non-base-10 numbers, as the documentation specifies.
4511 * lisp.h (string_to_number): New decl, replacing ...
4512 (isfloat_string): Remove.
4513 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4514 (read1): Do not accept +. and -. as integers; this
4515 appears to have been a coding error. Similarly, do not accept
4516 strings like +-1e0 as floating point numbers. Do not report
4517 overflow for integer overflows unless the base is not 10 which
4518 means we have no simple and reliable way to continue.
4519 Break out the floating-point parsing into a new
4520 function string_to_number, so that Fstring_to_number parses
4521 floating point numbers consistently with the Lisp reader.
4522 (digit_to_number): Move here from data.c. Make it static inline.
4523 (E_CHAR, EXP_INT): Remove, replacing with ...
4524 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4525 (string_to_number): New function, replacing isfloat_string.
4526 This function checks for valid syntax and produces the resulting
4527 Lisp float number too. Rework it so that string-to-number
4528 no longer mishandles examples like "1.0e+". Use strtoumax,
4529 so that overflow for non-base-10 numbers is reported only when
4530 there's no portable and simple way to convert to floating point.
4532 * textprop.c (set_text_properties_1): Rewrite for clarity,
4533 and to avoid GCC warning about integer overflow.
4535 * intervals.h (struct interval): Use EMACS_INT for members
4536 where EMACS_UINT might cause problems. See
4537 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4538 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4539 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4541 (offset_intervals): Tell GCC not to worry about length overflow
4542 when negating a negative length.
4544 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4545 (overrun_check_free): Likewise.
4547 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4548 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4551 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4552 (gnutls_make_error): Rename local to avoid shadowing.
4553 (gnutls_emacs_global_deinit): ifdef out; not used.
4554 (Fgnutls_boot): Use const for pointer to readonly storage.
4555 Comment out unused local. Fix pointer signedness problems.
4557 * lread.c (openp): Don't stuff size_t into an 'int'.
4558 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4559 about possible signed overflow.
4561 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4562 (GDK_KEY_g): Don't define if already defined.
4563 (xg_prepare_tooltip): Avoid pointer signedness problem.
4564 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4566 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4567 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4569 * xfns.c (Fx_window_property): Simplify a bit,
4570 to make a bit faster and to avoid GCC 4.6.0 warning.
4571 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4573 * fns.c (internal_equal): Don't assume size_t fits in int.
4575 * alloc.c (compact_small_strings): Tighten assertion a little.
4577 Replace pEd with more-general pI, and fix some printf arg casts.
4578 * lisp.h (pI): New macro, generalizing old pEd macro to other
4579 conversion specifiers. For example, use "...%"pI"d..." rather
4580 than "...%"pEd"...".
4581 (pEd): Remove. All uses replaced with similar uses of pI.
4582 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4583 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4584 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4585 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4586 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4587 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4588 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4590 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4591 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4592 * print.c (safe_debug_print, print_object): Likewise.
4593 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4595 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4596 avoiding the 0 flag, which is not portable.
4597 * process.c (Fmake_network_process): Use pI to avoid cast.
4598 * region-cache.c (pp_cache): Likewise.
4599 * xdisp.c (decode_mode_spec): Likewise.
4600 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4601 behavior on 64-bit hosts with printf arg.
4602 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4603 (x_stop_queuing_selection_requests): Likewise.
4604 (x_get_window_property): Don't truncate byte count to an 'int'
4607 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4608 here, since it parses constructs like leading '-' and spaces,
4609 which are not wanted; and it overflows with large numbers.
4610 Instead, simply match F[0-9]+, which is what is wanted anyway.
4612 * alloc.c: Remove unportable assumptions about struct layout.
4613 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4614 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4615 (allocate_vectorlike, make_pure_vector): Use the new macros,
4616 plus offsetof, to remove unportable assumptions about struct layout.
4617 These assumptions hold on all porting targets that I know of, but
4618 they are not guaranteed, they're easy to remove, and removing them
4619 makes further changes easier.
4621 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4622 This doesn't fix a bug but makes the code clearer.
4623 (string_overrun_cookie): Now const. Use initializers that
4624 don't formally overflow signed char, to avoid warnings.
4625 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4626 can cause Emacs to crash when string overrun checking is enabled.
4627 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4628 multiple of sizeof (EMACS_INT); it need not be, if
4629 alignof(EMACS_INT) < sizeof (EMACS_INT).
4630 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4632 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4634 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4636 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4638 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4639 supposed to be handshaking. (Bug#8556)
4640 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4642 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4644 * lisp.h (Qdebug): List symbol.
4645 * eval.c (Qdebug): Restore global linkage.
4646 * keyboard.c (debug-on-event): New variable.
4647 (handle_user_signal): Break into debugger when debug-on-event
4648 matches the current signal symbol.
4650 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4652 * alloc.c (check_sblock, check_string_bytes)
4653 (check_string_free_list): Convert to standard C.
4655 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4657 * w32.c (emacs_gnutls_push): Fix typo.
4659 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4661 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4662 "cast to pointer from integer of different size".
4664 Improve doprnt and its use in verror. (Bug#8545)
4665 * doprnt.c (doprnt): Document the set of format control sequences
4666 supported by the function. Use SAFE_ALLOCA instead of always
4669 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4670 is one byte too soon. Don't use xrealloc; instead xfree and
4673 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4675 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4678 * gnutls.c: Renamed global_initialized to
4679 gnutls_global_initialized. Added internals for the
4680 :verify-hostname-error, :verify-error, and :verify-flags
4681 parameters of `gnutls-boot' and documented those parameters in the
4682 docstring. Start callback support.
4683 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4684 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4685 on error. Return error code.
4686 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4687 (emacs_gnutls_read): Likewise.
4688 (Fgnutls_boot): Return handshake error code.
4689 (emacs_gnutls_handle_error): New function.
4690 (wsaerror_to_errno): Likewise.
4692 * w32.h (emacs_gnutls_pull): Add prototype.
4693 (emacs_gnutls_push): Likewise.
4695 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4696 (emacs_gnutls_push): Likewise.
4698 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4700 * process.c (wait_reading_process_output): Check if GnuTLS
4701 buffered some data internally if no FDs are set for TLS
4704 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4705 (LIBS): Link to USER_LIBS.
4706 ($(BLD)/gnutls.$(0)): New target.
4708 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4710 * xdisp.c (handle_single_display_spec): Rename the
4711 display_replaced_before_p argument into display_replaced_p, to
4712 make it consistent with the commentary. Fix typos in the
4715 * textprop.c (syms_of_textprop): Remove dead code.
4716 (copy_text_properties): Delete obsolete commentary about an
4717 interface that was deleted long ago. Fix typos in the description
4720 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4721 to changes in oldXMenu/XMenu.h from 2011-04-16.
4722 <menu_help_message, prev_menu_help_message>: Constify.
4723 (IT_menu_make_room): menu->help_text is now `const char **';
4726 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4727 to changes in oldXMenu/XMenu.h from 2011-04-16.
4728 (struct XMenu): Declare `help_text' `const char **'.
4730 * xfaces.c <Qunspecified>: Make extern again.
4732 * syntax.c: Include sys/types.h before including regex.h, as
4735 * doc.c (get_doc_string): Improve the format passed to `error'.
4737 * doprnt.c (doprnt): Improve commentary.
4739 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4741 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4744 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4745 changes in globals.h immediately force recompilation.
4746 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4747 $(CURDIR)/s/ms-w32.h.
4748 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4750 * character.c (Fchar_direction): Function deleted.
4751 (syms_of_character): Don't defsubr it.
4752 <char-direction-table>: Deleted.
4754 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4756 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4757 * doprnt.c: Include limits.h.
4758 (SIZE_MAX): New macro.
4759 (doprnt): Return a size_t value. 2nd arg is now size_t.
4760 Many local variables are now size_t instead of int or unsigned.
4761 Improve overflow protection. Support `l' modifier for integer
4762 conversions. Support %l conversion. Don't assume an EMACS_INT
4763 argument for integer conversions and for %c.
4765 * lisp.h (doprnt): Restore prototype.
4767 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4770 * Makefile.in (base_obj): Add back doprnt.o.
4772 * deps.mk (doprnt.o): Add back prerequisites.
4773 (callint.o): Depend on character.h.
4775 * eval.c (internal_lisp_condition_case): Include the handler
4776 representation in the error message.
4777 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4778 when breaking from the loop.
4780 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4782 * callint.c (Fcall_interactively): When displaying error message
4783 about invalid control letter, pass the character's codepoint, not
4784 a pointer to its multibyte form. Improve display of the character
4785 in octal and display also its hex code.
4787 * character.c (char_string): Use %x to display the (unsigned)
4788 codepoint of an invalid character, to avoid displaying a bogus
4791 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4792 `error', not SYMBOL_NAME itself.
4794 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4795 character arguments to `error'.
4797 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4798 to `error' in error message about FINAL_CHAR argument. Make sure
4799 FINAL_CHAR is a character, and use %c when it is passed as
4800 argument to `error'.
4802 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4804 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4806 * w32.c: Include <time.h>.
4807 (sys_localtime): New function.
4809 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4811 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4813 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4815 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4817 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4820 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4822 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4823 gl_state.e_property when gl_state.object is Qt.
4825 * insdel.c (make_gap_larger): Remove limitation of buffer size
4828 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4830 * xdisp.c (lookup_glyphless_char_display)
4831 (produce_glyphless_glyph): Handle cons cell entry in
4832 glyphless-char-display.
4833 (Vglyphless_char_display): Document it.
4835 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4836 glyphless-char-display.
4838 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4840 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4842 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4844 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4845 definition for no-X builds.
4847 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4849 Static checks with GCC 4.6.0 and non-default toolkits.
4851 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4853 * process.c (keyboard_bit_set): Define only if SIGIO.
4854 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4855 (send_process): Repair possible setjmp clobbering.
4857 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4859 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4861 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4863 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4864 Define only if needed.
4866 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4867 by pacifying GCC about it. Maybe it's time to retire it?
4868 * xfaces.c (USG, __TIMEVAL__): Likewise.
4870 * dispextern.h (struct redisplay_interface): Rename param
4872 * termhooks.h (struct terminal): Likewise.
4873 * xterm.c (xembed_send_message): Likewise.
4875 * insdel.c (make_gap_smaller): Define only if
4876 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4878 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4881 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4882 so that we aren't warned about unused symbols.
4884 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4886 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4888 * xfns.c (x_real_positions): Mark locals as initialized.
4890 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4892 * xterm.c: Fix problems found by static analysis with other toolkits.
4893 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4894 (x_dispatch_event): Declare static if USE_GTK, and
4895 define if USE_GTK || USE_X_TOOLKIT.
4896 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4897 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4898 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4899 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4901 * xmenu.c (menu_help_callback): Pointer type fixes.
4902 Use const pointers when pointing at readonly data. Avoid pointer
4904 (FALSE): Remove unused macro.
4905 (update_frame_menubar): Remove unused decl.
4907 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4909 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4910 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4911 (single_menu_item): Rename local to avoid shadowing.
4913 * keyboard.c (make_lispy_event): Remove unused local var.
4915 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4916 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4918 * bitmaps: Change bitmaps from unsigned char back to the X11
4919 compatible char. Avoid the old compiler warnings about
4920 out-of-range initializers by using, for example, '\xab' rather
4923 * xgselect.c (xgselect_initialize): Check vs interface
4924 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4926 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4928 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4929 to read-only memory.
4931 * fns.c (vector): Remove; this old hack is no longer needed.
4933 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4935 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4937 * xrdb.c (x_load_resources): Omit unused local.
4939 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4940 (x_window): Rename locals to avoid shadowing.
4941 (USG): Use the kludged USG macro, to pacify gcc.
4943 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4944 (x_term_init): Remove local to avoid shadowing.
4946 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4948 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4949 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4951 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4953 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4955 Fix regex.c, syntax.c and friends for buffers > 2GB.
4956 * syntax.h (struct gl_state_s): Declare character position members
4959 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4961 * textprop.c (verify_interval_modification, interval_of):
4962 Declare arguments EMACS_INT.
4964 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4967 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4969 * indent.c (Fvertical_motion): Local variable it_start is now
4972 * regex.c (re_match, re_match_2, re_match_2_internal)
4973 (bcmp_translate, regcomp, regexec, print_double_string)
4974 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4975 (re_compile_pattern, re_exec): Declare arguments and local
4976 variables `size_t' and `ssize_t' and return values `regoff_t', as
4978 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4979 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4980 <compile_stack_type>: `size' and `avail' are now `size_t'.
4982 * regex.h <regoff_t>: Use ssize_t, not int.
4983 (re_search, re_search_2, re_match, re_match_2): Arguments that
4984 specify buffer/string position and length are now ssize_t and
4985 size_t. Return type is regoff_t.
4987 2011-04-16 Ben Key <bkey76@gmail.com>
4989 * nsfont.m: Fixed bugs in ns_get_family and
4990 ns_descriptor_to_entity that were caused by using free to
4991 deallocate memory blocks that were allocated by xmalloc (via
4992 xstrdup). This caused Emacs to crash when compiled with
4993 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4994 --enable-checking=xmallocoverrun). xfree is now used to
4995 deallocate these memory blocks.
4997 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4999 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5001 emacs_write: Accept and return EMACS_INT for sizes.
5002 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5004 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5005 Accept and return EMACS_INT.
5006 (emacs_gnutls_write): Return the number of bytes written on
5008 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5009 (emacs_read, emacs_write): Remove check for negative size, as the
5010 Emacs source code has been audited now.
5011 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5012 (emacs_read, emacs_write): Use it.
5013 * process.c (send_process): Adjust to the new signatures of
5014 emacs_write and emacs_gnutls_write. Do not attempt to store
5015 a byte offset into an 'int'; it might overflow.
5016 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5018 * sound.c: Don't assume sizes fit in 'int'.
5019 (struct sound_device.period_size, alsa_period_size):
5020 Return EMACS_INT, not int.
5021 (struct sound_device.write, vox_write, alsa_write):
5022 Accept EMACS_INT, not int.
5023 (wav_play, au_play): Use EMACS_INT to store sizes and to
5024 record read return values.
5026 2011-04-15 Ben Key <bkey76@gmail.com>
5028 * keyboard.c (Qundefined): Don't declare static since it is used
5030 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5031 static since they are used in nsfont.m.
5033 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5035 * process.c (Qprocessp): Don't declare static.
5036 * lisp.h (Qprocessp): Declare again.
5038 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5040 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5042 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5044 Improve C-level modularity by making more things 'static'.
5046 Don't publish debugger-only interfaces to other modules.
5047 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5048 (verify_bytepos, count_markers): Move decls to the only modules
5050 * region-cache.h (pp_cache): Likewise.
5051 * window.h (check_all_windows): Likewise.
5052 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5054 * sysdep.c (croak): Now static, if
5055 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5056 * syssignal.h (croak): Declare only if not static.
5058 * alloc.c (refill_memory_reserve): Now static if
5059 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5060 * lisp.h (refill_memory_reserve): Declare only if not static.
5062 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5063 Define only if USE_LUCID.
5065 * xrdb.c (x_customization_string, x_rm_string): Now static.
5067 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5068 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5070 * xdisp.c (draw_row_with_mouse_face): Now static.
5071 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5073 * window.h (check_all_windows): Mark externally visible.
5075 * window.c (window_deletion_count): Now static.
5077 * undo.c: Make symbols static if they're not exported.
5078 (last_undo_buffer, last_boundary_position, pending_boundary):
5081 * textprop.c (interval_insert_behind_hooks): Now static.
5082 (interval_insert_in_front_hooks): Likewise.
5084 * term.c: Make symbols static if they're not exported.
5085 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5086 (max_frame_lines, tty_set_terminal_modes):
5087 (tty_reset_terminal_modes, tty_turn_off_highlight):
5088 (get_tty_terminal): Now static.
5089 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5090 * termhooks.h (term_mouse_moveto): Do not declare if
5092 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5093 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5095 * sysdep.c: Make symbols static if they're not exported.
5096 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5098 (sigprocmask_set, full_mask): Remove; unused.
5099 (wait_debugging): Mark as visible.
5100 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5101 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5103 * syntax.c (syntax_temp): Define only if !__GNUC__.
5105 * sound.c (current_sound_device, current_sound): Now static.
5107 * search.c (searchbufs, searchbuf_head): Now static.
5109 * scroll.c (scroll_cost): Remove; unused.
5110 * dispextern.h (scroll_cost): Remove decl.
5112 * region-cache.h (pp_cache): Mark as externally visible.
5114 * process.c: Make symbols static if they're not exported.
5115 (process_tick, update_tick, create_process, chan_process):
5116 (Vprocess_alist, proc_buffered_char, datagram_access):
5117 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5118 (deactivate_process): Mark defn as static, as well as decl.
5119 * lisp.h (create_process): Remove decl.
5120 * process.h (chan_process, Vprocess_alist): Remove decls.
5122 * print.c: Make symbols static if they're not exported.
5123 (print_depth, new_backquote_output, being_printed, print_buffer):
5124 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5125 (print_interval, print_number_index, initial_stderr_stream):
5127 * lisp.h (Fprinc): Remove decl.
5128 (debug_output_compilation_hack): Mark as externally visible.
5130 * sysdep.c (croak): Move decl from here to syssignal.h.
5131 * syssignal.h (croak): Put it here, so the API can be checked when
5132 'croak' is called from dissociate_if_controlling_tty.
5134 * minibuf.c: Make symbols static if they're not exported.
5135 (minibuf_save_list, choose_minibuf_frame): Now static.
5136 * lisp.h (choose_minibuf_frame): Remove decl.
5138 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5140 * lread.c: Make symbols static if they're not exported.
5141 (read_objects, initial_obarray, oblookup_last_bucket_number):
5143 (make_symbol): Remove; unused.
5144 * lisp.h (initial_obarray, make_symbol): Remove decls.
5146 * keyboard.c: Make symbols static if they're not exported.
5147 (single_kboard, recent_keys_index, total_keys, recent_keys):
5148 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5149 (this_single_command_key_start, echoing, last_auto_save):
5150 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5151 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5152 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5153 (Vlispy_mouse_stem, double_click_count):
5155 (force_auto_save_soon): Define only if SIGDANGER.
5156 (ignore_mouse_drag_p): Now static if
5157 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5158 (print_help): Remove; unused.
5159 (stop_character, last_timer_event): Mark as externally visible.
5160 * keyboard.h (ignore_mouse_drag_p): Declare only if
5161 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5162 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5163 * lisp.h (echoing): Remove decl.
5164 (force_auto_save_soon): Declare only if SIGDANGER.
5165 * xdisp.c (redisplay_window): Simplify code, to make it more
5166 obvious that ignore_mouse_drag_p is not accessed if !defined
5167 USE_GTK && !defined HAVE_NS.
5169 * intervals.c: Make symbols static if they're not exported.
5170 (merge_properties_sticky, merge_interval_right, delete_interval):
5172 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5174 * insdel.c: Make symbols static if they're not exported.
5175 However, leave prepare_to_modify_buffer alone. It's never
5176 called from outside this function, but that appears to be a bug.
5177 (combine_after_change_list, combine_after_change_buffer):
5178 (adjust_after_replace, signal_before_change): Now static.
5179 (adjust_after_replace_noundo): Remove; unused.
5180 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5181 (signal_before_change): Remove decls.
5183 * indent.c (val_compute_motion, val_vmotion): Now static.
5185 * image.c: Make symbols static if they're not exported.
5186 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5188 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5189 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5191 * fringe.c (standard_bitmaps): Now static.
5192 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5194 * frame.c: Make symbols static if they're not exported.
5195 (x_report_frame_params, make_terminal_frame): Now static.
5196 (get_frame_param): Now static, unless HAVE_NS.
5197 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5198 (x_get_resource_string): Remove; not used.
5199 * frame.h (make_terminal_frame, x_report_frame_params):
5200 (x_get_resource_string); Remove decls.
5201 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5202 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5204 * font.c, fontset.c: Make symbols static if they're not exported.
5205 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5206 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5207 * font.c (font_close_object): Now static.
5208 * font.h (font_close_object): Remove.
5209 * fontset.c (FONTSET_OBJLIST): Remove.
5210 (free_realized_fontset) #if-0 the body, which does nothing.
5211 (face_suitable_for_char_p): #if-0, as it's never called.
5212 * fontset.h (face_suitable_for_char_p): Remove decl.
5213 * xfaces.c (face_at_string_position):
5214 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5215 since 0 is always ASCII.
5217 * fns.c (weak_hash_tables): Now static.
5219 * fileio.c: Make symbols static if they're not exported.
5220 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5221 (Vwrite_region_annotation_buffers): Now static.
5223 * eval.c: Make symbols static if they're not exported.
5224 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5225 * lisp.h (backtrace_list): Remove decl.
5227 * emacs.c: Make symbols static if they're not exported.
5228 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5229 (fatal_error_code, fatal_error_signal_hook, standard_args):
5231 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5232 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5233 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5234 * lisp.h (fatal_error_signal_hook): Remove decl.
5235 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5237 * editfns.c: Move a (normally-unused) function to its only use.
5238 * editfns.c, lisp.h (get_operating_system_release): Remove.
5239 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5240 worth the hassle of breaking this out.
5242 * xterm.c: Make symbols static if they're not exported.
5243 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5244 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5245 (x_destroy_window, x_delete_display):
5247 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5248 (x_mouse_leave): Remove; unused.
5249 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5250 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5251 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5253 (x_mouse_leave): Declare only if WINDOWSNT.
5254 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5255 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5258 * ftxfont.c: Make symbols static if they're not exported.
5259 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5261 * font.h (ftxfont_driver): Likewise.
5263 * xfns.c: Make symbols static if they're not exported.
5264 (x_last_font_name, x_display_info_for_name):
5265 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5266 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5267 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5268 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5269 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5270 (last_show_tip_args): Now static.
5271 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5272 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5273 (x_screen_planes): Remove; unused.
5274 * dispextern.h (x_screen_planes): Remove decl.
5276 * dispnew.c: Make symbols static if they're not exported.
5277 * dispextern.h (redraw_garbaged_frames, scrolling):
5278 (increment_row_positions): Remove.
5279 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5280 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5282 (redraw_garbaged_frames): Remove; unused.
5284 * xfaces.c: Make symbols static if they're not exported.
5285 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5287 * xterm.h (defined_color): Remove decls.
5288 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5289 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5290 (menu_face_changed_default, defined_color, free_realized_face):
5291 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5292 (ascii_face_of_lisp_face): Remove; unused.
5294 * xdisp.c: Make symbols static if they're not exported.
5295 * dispextern.h (scratch_glyph_row, window_box_edges):
5296 (glyph_to_pixel_coords, set_cursor_from_row):
5297 (get_next_display_element, set_iterator_to_next):
5298 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5299 (show_mouse_face): Remove decls
5300 * frame.h (message_buf_print): Likewise.
5301 * lisp.h (pop_message, set_message, check_point_in_composition):
5303 * xterm.h (set_vertical_scroll_bar): Likewise.
5304 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5305 (message_buf_print, scratch_glyph_row, displayed_buffer):
5306 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5307 (get_next_display_element, show_mouse_face, window_box_edges):
5308 (frame_to_window_pixel_xy, check_point_in_composition):
5309 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5310 (glyph_to_pixel_coords): Remove; unused.
5312 * dired.c (file_name_completion): Now static.
5314 * dbusbind.c (xd_in_read_queued_messages): Now static.
5316 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5317 * data.c (circular_list_error): Remove.
5319 * commands.h (last_point_position, last_point_position_buffer):
5320 (last_point_position_window): Remove decls.
5321 * keyboard.c: Make these variables static.
5323 * coding.h (coding, code_convert_region, encode_coding_gap):
5325 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5326 (iso_code_class, detect_coding, code_convert_region): Now static.
5327 (encode_coding_gap): Remove; unused.
5329 * chartab.c (chartab_chars, chartab_bits): Now static.
5331 * charset.h (charset_iso_8859_1): Remove decl.
5332 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5335 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5336 * ccl.c (Vccl_program_table): Now static.
5337 (check_ccl_update): Remove; unused.
5339 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5340 * category.h: ... from here.
5341 * category.c (check_category_table, set_category_set): Now static.
5343 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5344 * lisp.h: Remove these decls.
5346 * buffer.c (buffer_count): Remove unused var.
5348 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5349 so that it's not optimized away.
5350 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5351 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5352 exported only to the debugger.
5354 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5355 * atimer.h (run_all_atimers): Remove; not exported.
5357 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5358 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5359 was inaccessible from Lisp.
5360 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5361 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5363 alloc.c: Import and export fewer symbols, and remove unused items.
5364 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5366 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5367 it's not optimized away by whole-program optimization.
5368 (message_enable_multibyte, free_misc): Remove.
5369 (catchlist, handlerlist, mark_backtrace):
5370 Declare only if BYTE_MARK_STACK.
5371 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5372 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5373 (message_enable_multibyte): Remove decl.
5374 (free_misc, interval_free_list, float_block, float_block_index):
5375 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5376 (cons_free_list, last_marked_index):
5378 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5379 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5380 (mark_backtrace): Define only if BYTE_MARK_STACK.
5381 * xdisp.c (message_enable_multibyte): Now static.
5383 Declare Lisp_Object Q* variables to be 'static' if not exported.
5384 This makes it easier for human readers (and static analyzers)
5385 to see whether these variables are used from other modules.
5386 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5387 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5388 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5389 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5390 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5391 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5392 * xmenu.c, xselect.c:
5393 Declare Q* vars static if they are not used in other modules.
5394 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5395 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5396 Remove decls of unexported vars.
5397 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5399 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5401 Make Emacs functions such as Fatom 'static' by default.
5402 This makes it easier for human readers (and static analyzers)
5403 to see whether these functions can be called from other modules.
5404 DEFUN now defines a static function. To make the function external
5405 so that it can be used in other C modules, use the new macro DEFUE.
5406 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5407 (Finit_image_library):
5408 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5409 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5410 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5411 Remove decls, since these functions are now static.
5412 (Funintern, Fget_internal_run_time): New decls, since these functions
5413 were already external.
5415 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5416 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5417 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5418 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5419 * keyboard.c, keymap.c, lread.c:
5420 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5421 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5422 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5423 Mark functions with DEFUE instead of DEFUN,
5424 if they are used in other modules.
5425 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5426 decls for now-static functions.
5427 * buffer.h (Fdelete_overlay): Remove decl.
5428 * callproc.c (Fgetenv_internal): Mark as internal.
5429 * composite.c (Fremove_list_of_text_properties): Remove decl.
5430 (Fcomposition_get_gstring): New forward static decl.
5431 * composite.h (Fcomposite_get_gstring): Remove decl.
5432 * dired.c (Ffile_attributes): New forward static decl.
5433 * doc.c (Fdocumntation_property): New forward static decl.
5434 * eval.c (Ffetch_bytecode): New forward static decl.
5435 (Funintern): Remove extern decl; now in .h file where it belongs.
5436 * fileio.c (Fmake_symbolic_link): New forward static decl.
5437 * image.c (Finit_image_library): New forward static decl.
5438 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5439 * intervals.h (Fprevious_property_change):
5440 (Fremove_list_of_text_properties): Remove decls.
5441 * keyboard.c (Fthis_command_keys): Remove decl.
5442 (Fcommand_execute): New forward static decl.
5443 * keymap.c (Flookup_key): New forward static decl.
5444 (Fcopy_keymap): Now static.
5445 * keymap.h (Flookup_key): Remove decl.
5446 * process.c (Fget_process): New forward static decl.
5447 (Fprocess_datagram_address): Mark as internal.
5448 * syntax.c (Fsyntax_table_p): New forward static decl.
5449 (skip_chars): Remove duplicate decl.
5450 * textprop.c (Fprevious_property_change): New forward static decl.
5451 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5453 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5454 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5456 * editfns.c (Fformat): Remove unreachable code.
5458 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5460 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5463 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5465 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5466 when at ZV. (Bug#8487)
5468 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5470 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5472 * keyboard.c (parse_tool_bar_item): Likewise.
5473 * sound.c (sound_cleanup, alsa_close): Likewise.
5474 * termcap.c (tgetent): Likewise.
5475 * xfns.c (x_default_font_parameter): Likewise.
5476 * xsettings.c (read_and_apply_settings): Likewise.
5478 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5479 (overrun_check_free): Protoize.
5481 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5483 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5484 since callers should never pass a negative size.
5485 Change the signature to match that of plain 'read' and 'write'; see
5486 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5487 * lisp.h: Update prototypes of emacs_write and emacs_read.
5489 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5491 * xdisp.c (redisplay_window): Don't try to determine the character
5492 position of the scroll margin if the window start point w->startp
5493 is outside the buffer's accessible region. (Bug#8468)
5495 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5497 Fix write-region and its subroutines for buffers > 2GB.
5498 * fileio.c (a_write, e_write): Modify declaration of arguments and
5499 local variables to support buffers larger than 2GB.
5500 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5502 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5503 argument, local variables, and return value.
5505 * lisp.h: Update prototypes of emacs_write and emacs_read.
5507 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5509 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5511 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5513 Fix more problems found by GCC 4.6.0's static checks.
5515 * xdisp.c (vmessage): Use a better test for character truncation.
5517 * charset.c (load_charset_map): <, not <=, for optimization,
5518 and to avoid potential problems with integer overflow.
5519 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5520 * casetab.c (set_identity, shuffle): Likewise.
5521 * editfns.c (Fformat): Likewise.
5522 * syntax.c (skip_chars): Likewise.
5524 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5525 This also lets GCC 4.6.0 generate slightly better loop code.
5527 * callint.c (Fcall_interactively): <, not <=, for optimization.
5528 (Fcall_interactively): Count the number of arguments produced,
5529 not the number of arguments given. This is simpler and lets GCC
5530 4.6.0 generate slightly better code.
5532 * ftfont.c: Distingish more carefully between FcChar8 and char.
5533 The previous code passed unsigned char * to a functions like
5534 strlen and xstrcasecmp that expect char *, which does not
5535 conform to the C standard.
5536 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5537 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5538 char * when the C standard requires it.
5540 * keyboard.c (read_char): Remove unused var.
5542 * eval.c: Port to Windows vsnprintf (Bug#8435).
5544 (SIZE_MAX): Define if the headers do not.
5545 (verror): Do not give up if vsnprintf returns a negative count.
5546 Instead, grow the buffer. This ports to Windows vsnprintf, which
5547 does not conform to C99. Problem reported by Eli Zaretskii.
5548 Also, simplify the allocation scheme, by avoiding the need for
5549 calling realloc, and removing the ALLOCATED variable.
5551 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5553 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5554 But keep the doprint source code for now, as we might revamp it
5555 and use it again (Bug#8435).
5556 * lisp.h (doprnt): Remove.
5557 * Makefile.in (base_obj): Remove doprnt.o.
5558 * deps.mk (doprnt.o): Remove.
5560 error: Print 32- and 64-bit integers portably (Bug#8435).
5561 Without this change, on typical 64-bit hosts error ("...%d...", N)
5562 was used to print both 32- and 64-bit integers N, which relied on
5564 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5566 * lisp.h (error, verror): Mark as printf-like functions.
5567 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5568 Report overflow in size calculations when allocating printf buffer.
5569 Do not truncate output string at its first null byte.
5570 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5571 Truncate the output at a character boundary, since vsnprintf does not
5573 * charset.c (check_iso_charset_parameter): Convert internal
5574 character to string before calling 'error', since %c now has the
5576 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5577 overflow when computing char to be passed to 'error'. Do not
5578 pass Lisp_Object to 'error'; pass the integer instead.
5579 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5580 formatted with plain %d.
5582 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5584 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5586 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5588 * xterm.c (x_catch_errors): Remove duplicate declaration.
5590 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5592 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5594 2011-04-10 Jim Meyering <meyering@redhat.com>
5596 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5597 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5598 return ssize_t not "int", and use size_t as the buffer length.
5599 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5600 * gnutls.h: Update declarations.
5601 * process.c (read_process_output): Use ssize_t, to match.
5602 (send_process): Likewise.
5604 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5606 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5608 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5610 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5611 Use unsigned char, to match FcChar8 type definition.
5613 * xterm.c (handle_one_xevent):
5614 * xmenu.c (create_and_show_popup_menu):
5615 * xselect.c (x_decline_selection_request)
5616 (x_reply_selection_request): Avoid type-punned deref of X events.
5618 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5620 Fix some uses of `int' instead of EMACS_INT.
5621 * search.c (string_match_1, fast_string_match)
5622 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5623 (scan_buffer, find_next_newline_no_quit)
5624 (find_before_next_newline, search_command, Freplace_match)
5625 (Fmatch_data): Make some `int' variables be EMACS_INT.
5627 * xdisp.c (display_count_lines): 3rd argument and return value now
5628 EMACS_INT. All callers changed.
5629 (pint2hrstr): Last argument is now EMACS_INT.
5631 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5632 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5633 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5634 (decode_coding_utf_16, decode_coding_emacs_mule)
5635 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5636 (decode_coding_ccl, decode_coding_charset)
5637 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5638 (decode_coding_iso_2022, decode_coding_emacs_mule)
5639 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5640 <char_offset, last_offset>: Declare EMACS_INT.
5641 (encode_coding_utf_8, encode_coding_utf_16)
5642 (encode_coding_emacs_mule, encode_invocation_designation)
5643 (encode_designation_at_bol, encode_coding_iso_2022)
5644 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5645 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5647 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5648 (encode_invocation_designation): Last argument P_NCHARS is now
5650 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5651 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5653 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5656 * ccl.c (Fccl_execute_on_string): Declare some variables
5659 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5661 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5663 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5665 * process.c (Fformat_network_address): Doc fix.
5667 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5669 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5671 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5673 * keyboard.c (read_char): Call Lisp function help-form-show,
5674 instead of using internal_with_output_to_temp_buffer.
5675 (Qhelp_form_show): New var.
5676 (syms_of_keyboard): Use DEFSYM macro.
5678 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5680 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5682 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5684 * process.c (Flist_processes): Remove to Lisp.
5685 (list_processes_1): Delete.
5687 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5689 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5691 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5693 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5695 Fix more problems found by GCC 4.6.0's static checks.
5697 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5699 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5701 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5703 * xdisp.c (vmessage): Mark as a printf-like function.
5705 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5707 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5709 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5710 printf-like functions.
5711 (tiff_load): Add casts to remove these marks before passing them
5712 to system-supplied API.
5714 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5716 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5717 This avoids several warnings with gcc -Wstrict-overflow.
5718 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5719 directly, rather than having caller test rule sign. This avoids
5720 some unnecessary tests.
5721 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5722 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5723 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5725 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5726 (xfont_open): Avoid unnecessary tests.
5728 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5730 * composite.h, composite.c (composition_gstring_put_cache):
5731 Use EMACS_INT, not int, for length.
5733 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5734 breaking out part of COMPOSITION_DECODE_RULE.
5735 (COMPOSITION_DECODE_RULE): Use it.
5736 * composite.c (get_composition_id): Remove unused local vars,
5737 by using the new macro.
5739 * textprop.c (set_text_properties_1): Change while to do-while,
5740 since the condition is always true at first.
5742 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5743 (interval_deletion_adjustment): Return unsigned value.
5746 * process.c (list_processes_1, create_pty, read_process_output):
5747 (exec_sentinel): Remove vars that were set but not used.
5748 (create_pty): Remove unnecessary "volatile"s.
5749 (Fnetwork_interface_info): Avoid possibility of int overflow.
5750 (read_process_output): Do adaptive read buffering even if carryover.
5751 (read_process_output): Simplify nbytes computation if buffered.
5753 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5755 * syntax.c (scan_words): Remove var that was set but not used.
5756 (update_syntax_table): Use unsigned instead of int.
5758 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5759 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5760 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5762 * print.c (print_error_message): Avoid int overflow.
5764 * font.c (font_list_entities): Redo for clarity,
5765 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5767 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5768 (font_score): Avoid potential overflow in diff calculation.
5770 * fns.c (substring_both): Remove var that is set but not used.
5771 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5773 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5775 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5776 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5777 can always succeed if overflow has undefined behavior.
5779 * search.c (boyer_moore, wordify): Remove vars set but not used.
5780 (wordify): Omit three unnecessary tests.
5782 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5783 All callers changed. This avoids the need for an unused var.
5785 * casefiddle.c (casify_region): Remove var that is set but not used.
5787 * dired.c (file_name_completion): Remove var that is set but not used.
5789 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5791 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5792 (Finsert_file_contents): Remove unnecessary code checking fd.
5794 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5795 Check for integer overflow on size calculations.
5797 * buffer.c (Fprevious_overlay_change): Remove var that is set
5800 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5801 Remove vars that are set but not used.
5802 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5803 (timer_check_2): Mark vars as initialized.
5805 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5807 * image.c (lookup_image): Remove var that is set but not used.
5808 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5810 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5811 that are set but not used.
5813 * xfns.c (make_invisible_cursor): Don't return garbage
5814 if XCreateBitmapFromData fails (Bug#8410).
5816 * xselect.c (x_get_local_selection, x_handle_property_notify):
5817 Remove vars that are set but not used.
5819 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5820 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5822 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5823 Remove var that is set but not used.
5824 (scroll_bar_windows_size): Now size_t, not int.
5825 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5828 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5829 (map_tty_color) [!defined MSDOS]: Likewise.
5831 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5833 * coding.c: Remove vars that are set but not used.
5834 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5835 All callers changed.
5836 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5837 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5838 (decode_coding_charset): Remove vars that are set but not used.
5840 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5841 that is set but not used.
5843 * print.c (print_object): Remove var that is set but not used.
5845 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5846 The gnulib version avoids calling malloc in the usual case,
5847 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5848 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5849 * filelock.c (current_lock_owner): Likewise.
5850 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5851 * sysdep.c: Include allocator.h, careadlinkat.h.
5852 (emacs_no_realloc_allocator): New static constant.
5853 (emacs_readlink): New function.
5854 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5855 ../lib/careadlinkat.h.
5857 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5859 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5860 first non-nil return value).
5862 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5864 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5865 if not defined (Bug#8403).
5867 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5869 * xdisp.c (display_count_lines): Remove parameter `start',
5870 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5871 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5872 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5873 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5874 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5875 and thereabouts. All callers changed.
5876 (get_per_char_metric): Remove parameter `f', unused since
5877 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5879 2011-04-02 Jim Meyering <meyering@redhat.com>
5881 do not dereference NULL upon failed strdup
5882 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5883 (ns_get_family): Likewise.
5885 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5887 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5889 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5891 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5894 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5896 Add lexical binding.
5898 * window.c (Ftemp_output_buffer_show): New fun.
5899 (Fsave_window_excursion):
5900 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5902 * lread.c (lisp_file_lexically_bound_p): New function.
5903 (Fload): Bind Qlexical_binding.
5904 (readevalloop): Remove `evalfun' arg.
5905 Bind Qinternal_interpreter_environment.
5906 (Feval_buffer): Bind Qlexical_binding.
5907 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5909 (syms_of_lread): Declare `lexical-binding'.
5911 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5913 * keyboard.c (eval_dyn): New fun.
5914 (menu_item_eval_property): Use it.
5916 * image.c (parse_image_spec): Use Ffunctionp.
5918 * fns.c (concat, mapcar1): Accept byte-code-functions.
5920 * eval.c (Fsetq): Handle lexical vars.
5921 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5922 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5923 (FletX, Flet): Obey lexical binding.
5924 (Fcommandp): Handle closures.
5925 (Feval): New `lexical' arg.
5926 (eval_sub): New function extracted from Feval. Use it almost
5927 everywhere where Feval was used. Look up vars in lexical env.
5929 (Ffunctionp): Move from subr.el.
5930 (Ffuncall): Handle closures.
5931 (apply_lambda): Remove `eval_flags'.
5932 (funcall_lambda): Handle closures and new byte-code-functions.
5933 (Fspecial_variable_p): New function.
5934 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5935 but without exporting it to Lisp.
5937 * doc.c (Fdocumentation, store_function_docstring):
5938 * data.c (Finteractive_form): Handle closures.
5940 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5943 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5945 (exec_byte_code): New function extracted from Fbyte_code to handle new
5946 calling convention for byte-code-functions. Add new byte-codes.
5948 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5950 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5952 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5954 * xdisp.c (redisplay_internal): Fix prototype.
5956 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5958 * xdisp.c (SCROLL_LIMIT): New macro.
5959 (try_scrolling): Use it when setting scroll_limit.
5960 Limit scrolling to 100 screen lines.
5961 (redisplay_window): Even when falling back on "recentering",
5962 position point in the window according to scroll-conservatively,
5963 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5965 (try_scrolling): When point is above the window, allow searching
5966 as far as scroll_max, or one screenful, to compute vertical
5967 distance from PT to the scroll margin position. This prevents
5968 try_scrolling from unnecessarily failing when
5969 scroll-conservatively is set to a value slightly larger than the
5970 window height. Clean up the case of PT below the margin at bottom
5971 of window: scroll_max can no longer be INT_MAX. When aggressive
5972 scrolling is in use, don't let point enter the opposite scroll
5973 margin as result of the scroll.
5974 (syms_of_xdisp) <scroll-conservatively>: Document the
5975 threshold of 100 lines for never-recentering scrolling.
5977 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5979 * dispextern.h (move_it_by_lines):
5980 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5981 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5982 (message_log_check_duplicate): Remove parameters `prev_bol' and
5983 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5984 (redisplay_internal): Remove parameter `preserve_echo_area',
5985 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5987 * indent.c (Fvertical_motion):
5988 * window.c (window_scroll_pixel_based, Frecenter):
5989 Don't pass `need_y_p' to `move_it_by_lines'.
5991 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5993 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5994 steal a few bits to be more compact.
5995 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5996 Remove unneeded casts.
5998 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6000 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6002 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6003 binding" message (bug#7967).
6005 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6007 Fix more problems found by GCC 4.6.0's static checks.
6009 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6010 Remove unused local var.
6012 * editfns.c (Fmessage_box): Remove unused local var.
6014 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6015 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6016 Omit unused local vars.
6017 * window.c (shrink_windows): Omit unused local var.
6018 * menu.c (digest_single_submenu): Omit unused local var.
6019 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6020 Omit unused local var.
6022 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6023 Don't assume string length fits in int.
6024 (keyremap_step, read_key_sequence): Use size_t for sizes.
6025 (read_key_sequence): Don't check last_real_key_start redundantly.
6027 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6028 instead of alloca (Bug#8344).
6030 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6031 (Fbacktrace_frame): Don't assume nframes fits in int.
6033 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6035 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6038 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6040 * cm.c (calccost): Turn while-do into do-while, for clarity.
6042 * keyboard.c (syms_of_keyboard): Use the same style as later
6043 in this function when indexing through an array. This also
6044 works around GCC bug 48267.
6046 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6048 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6050 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6051 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6053 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6054 This avoids undefined behavior on integer overflow, and is a bit
6055 more convenient anyway since it is compared to a size_t variable.
6057 Variadic C functions now count arguments with size_t, not int.
6058 This avoids an unnecessary limitation on 64-bit machines, which
6059 caused (substring ...) to crash on large vectors (Bug#8344).
6060 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6061 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6062 All variadic functions and their callers changed accordingly.
6063 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6064 * data.c (arith_driver, float_arith_driver): Likewise.
6065 * editfns.c (general_insert_function): Likewise.
6066 * eval.c (struct backtrace.nargs, interactive_p)
6067 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6068 (funcall_lambda, mark_backtrace): Likewise.
6069 * fns.c (concat): Likewise.
6070 * frame.c (x_set_frame_parameters): Likewise.
6071 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6072 0 if not found, not -1. All callers changed.
6074 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6075 (stack_copy_size): Now size_t, not int.
6076 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6078 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6080 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6081 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6082 All callers changed.
6084 * lisp.h (multibyte_char_to_unibyte):
6085 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6086 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6087 * character.h (CHAR_TO_BYTE8):
6088 * cmds.c (internal_self_insert):
6089 * editfns.c (general_insert_function):
6090 * keymap.c (push_key_description):
6091 * search.c (Freplace_match):
6092 * xdisp.c (message_dolog, set_message_1): All callers changed.
6094 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6096 * keyboard.c (safe_run_hook_funcall): New function.
6097 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6098 don't set the hook to nil, but remove the offending function instead.
6099 (Qcommand_hook_internal): Remove, unused.
6100 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6101 Vcommand_hook_internal.
6103 * eval.c (enum run_hooks_condition): Remove.
6104 (funcall_nil, funcall_not): New functions.
6105 (run_hook_with_args): Call each function through a `funcall' argument.
6106 Remove `cond' argument, now redundant.
6107 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6108 (Frun_hook_with_args_until_failure): Adjust accordingly.
6109 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6111 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6113 * dispextern.h (string_buffer_position): Remove declaration.
6115 * print.c (strout): Remove parameter `multibyte', unused since
6116 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6118 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6119 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6120 All callers changed.
6122 * w32.c (_wsa_errlist): Use braces for struct initializers.
6124 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6125 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6126 All callers changed.
6127 (string_buffer_position): Likewise. Also, make static (it's never
6128 used outside xdisp.c).
6129 (cursor_row_p): Remove parameter `w', unused since
6130 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6131 (decode_mode_spec): Remove parameter `precision', introduced during
6132 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6133 All callers changed.
6135 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6137 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6139 2011-03-27 Anders Lindgren <andlind@gmail.com>
6141 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6142 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6143 (ns_update_auto_hide_menu_bar): New functions.
6144 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6145 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6146 ns_constrain_all_frames.
6147 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6148 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6150 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6152 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6154 2011-03-27 Glenn Morris <rgm@gnu.org>
6156 * syssignal.h: Replace RETSIGTYPE with void.
6157 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6158 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6159 Replace SIGTYPE with void everywhere.
6160 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6161 * s/template.h (SIGTYPE): Remove commented out definition.
6163 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6165 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6166 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6168 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6170 * w32.c (read_unc_volume): Use parameter `henum', instead of
6171 global variable `wget_enum_handle'.
6173 * keymap.c (describe_vector): Remove parameters `indices' and
6174 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6175 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6177 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6179 * keyboard.c (timer_check): Remove parameter `do_it_now',
6180 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6181 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6182 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6184 * keyboard.c (read_char):
6185 * w32menu.c (w32_menu_display_help):
6186 * xmenu.c (show_help_event, menu_help_callback):
6187 Adjust calls to `show_help_echo'.
6189 * gtkutil.c (xg_maybe_add_timer):
6190 * keyboard.c (readable_events):
6191 * process.c (wait_reading_process_output):
6192 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6194 * insdel.c (adjust_markers_gap_motion):
6195 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6196 (gap_left, gap_right): Don't call it.
6198 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6200 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6201 incurred during fontification.
6203 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6205 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6206 (DEFVAR_PER_BUFFER): Don't pass it.
6208 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6209 (scrolling_window): Don't pass it.
6211 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6213 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6215 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6217 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6218 of variables specific to SELinux and computation of `encoded_absname'.
6220 * image.c (XPutPixel): Remove unused variable `height'.
6222 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6224 * unexw32.c (get_section_info): Remove unused variable `section'.
6226 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6227 (system_process_attributes): Remove unused variable `sess'.
6228 (sys_read): Remove unused variable `err'.
6230 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6231 (w32_wnd_proc): Remove unused variable `isdead'.
6232 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6233 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6234 (x_create_tip_frame): Remove unused variable `tem'.
6236 * w32inevt.c (w32_console_read_socket):
6237 Remove unused variable `no_events'.
6239 * w32term.c (x_draw_composite_glyph_string_foreground):
6240 Remove unused variable `width'.
6242 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6244 * w32term.c (x_set_glyph_string_clipping):
6245 Don't pass uninitialized region to CombineRgn.
6247 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6249 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6250 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6251 (Fx_close_connection): Remove unused variable `i'.
6253 * w32font.c (w32font_draw): Return number of glyphs.
6254 (w32font_open_internal): Remove unused variable `i'.
6255 (w32font_driver): Add missing initializer.
6257 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6258 (fill_in_menu): Remove unused variable `items_added'.
6260 * w32term.c (last_mouse_press_frame): Remove static global variable.
6261 (w32_clip_to_row): Remove unused variable `f'.
6262 (x_delete_terminal): Remove unused variable `i'.
6264 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6265 (NOTHING): Remove unused static global variable.
6266 (uniscribe_check_otf): Remove unused variable `table'.
6267 (uniscribe_font_driver): Add missing initializers.
6269 2011-03-23 Julien Danjou <julien@danjou.info>
6271 * term.c (Fsuspend_tty, Fresume_tty):
6272 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6273 * window.c (temp_output_buffer_show):
6274 * insdel.c (signal_before_change):
6275 * frame.c (Fhandle_switch_frame):
6276 * fileio.c (Fdo_auto_save):
6277 * emacs.c (Fkill_emacs):
6278 * editfns.c (save_excursion_restore):
6279 * cmds.c (internal_self_insert):
6280 * callint.c (Fcall_interactively):
6281 * buffer.c (Fkill_all_local_variables):
6282 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6284 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6285 unconditionnaly since it does the check itself.
6287 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6289 Fix more problems found by GCC 4.5.2's static checks.
6291 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6292 the first time through the loop, since we know p0 < p1 then.
6293 This also avoids a gcc -Wstrict-overflow warning.
6295 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6296 leading to a memory leak, possible in functions like
6297 load_charset_map_from_file that can allocate an unbounded number
6298 of objects (Bug#8318).
6300 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6301 that could (at least in theory) be that large.
6303 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6304 This is less likely to overflow, and avoids undefined behavior if
6305 overflow does occur. All callers changed. Use strtoul to scan
6306 for the unsigned long integer.
6307 (pint2hrstr): Simplify and tune code slightly.
6308 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6310 * scroll.c (do_scrolling): Work around GCC bug 48228.
6311 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6313 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6314 This also avoids a warning with gcc -Wstrict-overflow.
6315 (validate_x_resource_name): Simplify count usage.
6316 This also avoids a warning with gcc -Wstrict-overflow.
6318 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6321 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6323 * process.c (Fmake_network_process): Use socklen_t, not int,
6324 where POSIX says socklen_t is required in portable programs.
6325 This fixes a porting bug on hosts like 64-bit HP-UX, where
6326 socklen_t is wider than int (Bug#8277).
6327 (Fmake_network_process, server_accept_connection):
6328 (wait_reading_process_output, read_process_output):
6331 * process.c: Rename or move locals to avoid shadowing.
6332 (list_processes_1, Fmake_network_process):
6333 (read_process_output_error_handler, exec_sentinel_error_handler):
6334 Rename or move locals.
6335 (Fmake_network_process): Define label "retry_connect" only if needed.
6336 (Fnetwork_interface_info): Fix pointer signedness.
6337 (process_send_signal): Add cast to avoid pointer signedness problem.
6338 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6339 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6341 Make tparam.h and terminfo.c consistent.
6342 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6343 Include tparam.h instead, since it declares them.
6344 * cm.h (PC): Remove extern decl; tparam.h now does this.
6345 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6346 * terminfo.c: Include tparam.h, to check interfaces.
6347 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6348 (tparam): Adjust signature to match interface in tparam.h;
6349 this removes some undefined behavior. Check that outstring and len
6350 are zero, which they always are with Emacs.
6351 * tparam.h (PC, BC, UP): New extern decls.
6353 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6354 (xftfont_open): Rename locals to avoid shadowing.
6356 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6357 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6358 (OTF_TAG_SYM): Omit macro if not needed.
6359 (ftfont_list): Remove unused local.
6360 (get_adstyle_property, ftfont_pattern_entity):
6361 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6362 Rename locals to avoid shadowing.
6364 * xfont.c (xfont_list_family): Mark var as initialized.
6366 * xml.c (make_dom): Now static.
6368 * composite.c (composition_compute_stop_pos): Rename local to
6370 (composition_reseat_it): Remove unused locals.
6371 (find_automatic_composition, composition_adjust_point): Likewise.
6372 (composition_update_it): Mark var as initialized.
6373 (find_automatic_composition): Mark vars as initialized,
6374 with a FIXME (Bug#8290).
6376 character.h: Rename locals to avoid shadowing.
6377 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6378 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6379 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6380 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6383 * textprop.c (property_change_between_p): Remove; unused.
6385 * intervals.c (interval_start_pos): Now static.
6387 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6389 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6390 Rename locals to avoid shadowing.
6392 * sound.c (wav_play, au_play, Fplay_sound_internal):
6393 Fix pointer signedness.
6394 (alsa_choose_format): Remove unused local var.
6395 (wav_play): Initialize a variable to 0, to prevent undefined
6396 behavior (Bug#8278).
6398 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6400 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6402 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6403 clobbering (Bug#8298).
6404 * sysdep.c (sys_subshell): Likewise.
6405 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6407 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6408 This should get cleaned up, so that child_setup has the
6409 same signature on all platforms.
6411 * callproc.c (call_process_cleanup): Now static.
6412 (relocate_fd): Rename locals to avoid shadowing.
6414 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6416 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6417 not to be necessary, and produces flickering.
6419 2011-03-20 Glenn Morris <rgm@gnu.org>
6421 * config.in: Remove file.
6423 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6425 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6426 are now in src/globals.h.
6427 (syms_of_minibuf): Remove spurious & from previous change.
6429 2011-03-20 Leo <sdl.web@gmail.com>
6431 * minibuf.c (completing-read-function): New variable.
6432 (completing-read-default): Rename from completing-read.
6433 (completing-read): Call completing-read-function.
6435 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6437 * xfaces.c (Fx_load_color_file):
6438 Read color file from absolute filename (bug#8250).
6440 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6442 * makefile.w32-in: Update dependencies.
6444 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6446 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6448 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6450 Fix more problems found by GCC 4.5.2's static checks.
6452 * process.c (make_serial_process_unwind, send_process_trap):
6453 (sigchld_handler): Now static.
6455 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6456 That way, the code declares only the vars that it needs.
6457 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6458 * s/cygwin.h (PTY_ITERATION): Likewise.
6459 * s/darwin.h (PTY_ITERATION): Likewise.
6460 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6462 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6463 * process.c (allocate_pty): Don't declare stb unless it's needed.
6465 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6466 (CONSTANTLIM): Remove; unused.
6467 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6468 Define only if needed.
6470 * unexelf.c (unexec): Name an expression,
6471 to avoid gcc -Wbad-function-cast warning.
6472 Use a different way to cause a compilation error if anyone uses
6473 n rather than nn, a way that does not involve shadowing.
6474 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6476 * deps.mk (unexalpha.o): Remove; unused.
6478 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6479 * unexec.h: New file.
6480 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6481 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6483 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6484 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6485 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6486 Change as necessary to match prototype in unexec.h.
6488 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6490 (back_comment, skip_chars): Mark vars as initialized.
6492 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6493 Rename locals to avoid shadowing.
6495 * lread.c (read1): Rewrite so as not to use empty "else".
6496 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6498 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6500 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6501 warning when compiling print.c.
6503 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6504 instead of using an uninitialized var.
6505 (font_sort_entities): Mark var as initialized.
6507 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6509 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6510 pointers to constants.
6511 (font_parse_fcname): Remove unused vars.
6512 (font_delete_unmatched): Now static.
6513 (font_get_spec): Remove; unused.
6514 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6515 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6516 Rename or move locals to avoid shadowing.
6518 * fns.c (require_nesting_list, require_unwind): Now static.
6519 (Ffillarray): Rename locals to avoid shadowing.
6521 * floatfns.c (domain_error2): Define only if needed.
6522 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6524 * alloc.c (mark_backtrace): Move decl from here ...
6525 * lisp.h: ... to here, so that it can be checked.
6527 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6528 (Fdefvar): Rewrite so as not to use empty "else".
6529 (lisp_indirect_variable): Name an expression,
6530 to avoid gcc -Wbad-function-cast warning.
6531 (Fdefvar): Rename locals to avoid shadowing.
6533 * callint.c (quotify_arg, quotify_args): Now static.
6534 (Fcall_interactively): Rename locals to avoid shadowing.
6535 Use const pointer when appropriate.
6537 * lisp.h (get_system_name, get_operating_system_release):
6538 Move decls here, to check interfaces.
6539 * process.c (get_operating_system_release): Move decl to lisp.h.
6540 * xrdb.c (get_system_name): Likewise.
6541 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6542 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6543 some of which prompt warnings from gcc -Wbad-function-cast.
6544 (Fformat_time_string, Fencode_time, Finsert_char):
6545 (Ftranslate_region_internal, Fformat):
6546 Rename or remove local vars to avoid shadowing.
6547 (Ftranslate_region_internal): Mark var as initialized.
6549 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6552 * lisp.h (eassert): Check that the argument compiles, even if
6553 ENABLE_CHECKING is not defined.
6555 * data.c (Findirect_variable): Name an expression, to avoid
6556 gcc -Wbad-function-cast warning.
6557 (default_value, arithcompare, arith_driver, arith_error): Now static.
6558 (store_symval_forwarding): Rename local to avoid shadowing.
6559 (Fmake_variable_buffer_local, Fmake_local_variable):
6560 Mark variables as initialized.
6561 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6563 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6564 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6565 Rename locals to avoid shadowing.
6566 (mark_stack): Move local variables into the #ifdef region where
6568 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6569 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6571 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6572 (GC_STRING_CHARS): Remove; not used.
6573 (Fmemory_limit): Cast sbrk's returned value to char *.
6575 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6576 avoids undefined behavior in theory.
6578 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6580 Use functions, not macros, for up- and down-casing (Bug#8254).
6581 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6582 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6583 to use the following functions instead of these macros.
6584 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6585 EMACS_INT, since callers assume the returned value fits in int.
6586 (upcase1): Likewise, for UPCASE_TABLE.
6587 (uppercasep, lowercasep, upcase): New static inline functions.
6588 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6589 the race-condition problem in the old DOWNCASE.
6591 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6592 Rename locals to avoid shadowing.
6593 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6594 (regex_compile, re_search_2, re_match_2_internal):
6595 Remove unused local vars.
6596 (FREE_VAR): Rewrite so as not to use empty "else",
6597 which gcc can warn about.
6598 (regex_compile, re_match_2_internal): Mark locals as initialized.
6599 (RETALLOC_IF): Define only if needed.
6600 (WORDCHAR_P): Likewise. This one is never needed, but is used
6601 only in a comment talking about a compiler bug, so put inside
6602 the #if 0 of that comment.
6603 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6604 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6607 * search.c (boyer_moore): Rename locals to avoid shadowing.
6608 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6609 (PREV_CHAR_BOUNDARY): Likewise.
6611 * search.c (simple_search): Remove unused var.
6613 * dired.c (compile_pattern): Move decl from here ...
6614 * lisp.h: ... to here, so that it can be checked.
6615 (struct re_registers): New forward decl.
6617 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6619 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6621 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6622 Rename locals to avoid shadowing.
6623 (Fvertical_motion): Mark locals as initialized.
6625 * casefiddle.c (casify_object, casify_region): Now static.
6626 (casify_region): Mark local as initialized.
6628 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6630 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6631 New macros, so that the caller can use some names other than
6632 gcpro1, gcpro2, etc.
6633 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6635 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6636 argument, for consistency with GCPRO2_VAR, etc: it is now the
6637 prefix of the variable, not the variable itself. All uses
6639 * dired.c (directory_files_internal, file_name_completion):
6640 Rename locals to avoid shadowing.
6642 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6643 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6644 dired.c's scmp function, had undefined behavior.
6645 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6646 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6647 * buffer.h: ... to here, because these macros use current_buffer,
6648 and the new implementation with inline functions needs to have
6649 current_buffer in scope now, rather than later when the macros
6651 (downcase, upcase1): New static inline functions.
6652 (DOWNCASE, UPCASE1): Reimplement using these functions.
6653 This avoids undefined behavior in expressions like
6654 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6655 from race conditions in accessing the global variables
6656 case_temp1 and case_temp2.
6657 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6658 * lisp.h (case_temp1, case_temp2): Remove their decls.
6659 * character.h (ASCII_CHAR_P): Move from here ...
6660 * lisp.h: ... to here, so that the inline functions mentioned
6663 * dired.c (directory_files_internal_unwind): Now static.
6665 * fileio.c (file_name_as_directory, directory_file_name):
6666 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6668 (file_name_as_directory): Use const pointers when appropriate.
6669 (Fexpand_file_name): Likewise. In particular, newdir might
6670 point at constant storage, so make it a const pointer.
6671 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6672 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6674 (Fset_file_times, Finsert_file_contents, auto_save_error):
6675 Rename locals to avoid shadowing.
6677 * minibuf.c (choose_minibuf_frame_1): Now static.
6678 (Ftry_completion, Fall_completions): Rename or remove locals
6681 * marker.c (bytepos_to_charpos): Remove; unused.
6683 * lisp.h (verify_bytepos, count_markers): New decls,
6684 so that gcc does not warn that these functions aren't declared.
6686 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6687 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6688 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6689 (copy_text): Remove unused local var.
6691 * filelock.c (within_one_second): Now static.
6692 (lock_file_1): Rename local to avoid shadowing.
6694 * buffer.c (fix_overlays_before): Mark locals as initialized.
6695 (fix_start_end_in_overlays): Likewise. This function should be
6696 simplified by using pointers-to-pointers, but that's a different
6698 (switch_to_buffer_1): Now static.
6699 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6700 (report_overlay_modification): Rename locals to avoid shadowing.
6702 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6703 Fix pointer signedness issue.
6704 (sys_subshell): Mark local as volatile if checking for lint,
6705 to suppress a gcc -Wclobbered warning that does not seem to be right.
6706 (MAXPATHLEN): Define only if needed.
6708 * process.c (serial_open, serial_configure): Move decls from here ...
6709 * systty.h: ... to here, so that they can be checked.
6711 * fns.c (get_random, seed_random): Move extern decls from here ...
6712 * lisp.h: ... to here, so that they can be checked.
6714 * sysdep.c (reset_io): Now static.
6715 (wait_for_termination_signal): Remove; unused.
6717 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6718 (copy_keymap_item, append_key, push_text_char_description):
6720 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6721 (DENSE_TABLE_SIZE): Remove; unused.
6722 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6723 (describe_map_tree):
6724 Rename locals to avoid shadowing.
6726 * keyboard.c: Declare functions static if they are not used elsewhere.
6727 (echo_char, echo_dash, cmd_error, top_level_2):
6728 (poll_for_input, handle_async_input): Now static.
6729 (read_char, kbd_buffer_get_event, make_lispy_position):
6730 (make_lispy_event, make_lispy_movement, apply_modifiers):
6731 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6732 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6733 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6734 (read_key_sequence, read_char): Mark locals as initialized.
6735 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6737 * keyboard.h (make_ctrl_char): New decl.
6738 (mark_kboards): Move decl here ...
6739 * alloc.c (mark_kboards): ... from here.
6741 * lisp.h (force_auto_save_soon): New decl.
6743 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6744 (DEFINE_DUMMY_FUNCTION): New macro.
6745 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6747 (main): Add casts to avoid warnings
6748 if GCC considers string literals to be constants.
6750 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6752 * dbusbind.c: Pointer signedness fixes.
6753 (xd_signature, xd_append_arg, xd_initialize):
6754 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6755 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6756 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6757 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6759 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6760 if GCC considers string literals to be constants.
6761 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6763 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6765 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6766 (print_preprocess, print_object): New macro to fix last change.
6768 * print.c (print_preprocess): Don't forget font objects.
6770 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6772 * emacs.c (USAGE3): Doc fixes.
6774 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6776 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6779 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6781 * lisp.h (VWindow_system, Qfile_name_history):
6782 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6783 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6784 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6786 * w32select.c: Don't #include "keyboard.h".
6787 (run_protected): Add extern declaration for waiting_for_input.
6789 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6790 * w32console.c (detect_input_pending, read_input_pending)
6791 (encode_terminal_code):
6792 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6793 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6794 (w32_system_caret_y, Qfile_name_history):
6795 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6796 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6797 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6798 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6799 * w32proc.c (Qlocal, report_file_error):
6800 * w32term.c (Vwindow_system, updating_frame):
6801 * w32uniscribe.c (initialized, uniscribe_font_driver):
6802 Remove unneeded extern declarations.
6804 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6806 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6808 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6810 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6811 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6812 These macros can no longer be used for assignment.
6814 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6815 Assign struct members directly, instead of using BUF_BEGV etc.
6816 (record_buffer_markers, fetch_buffer_markers): New functions for
6817 recording and fetching special buffer markers.
6818 (set_buffer_internal_1, set_buffer_temp): Use them.
6820 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6822 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6824 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6825 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6827 * xdisp.c (hscroll_window_tree):
6828 (reconsider_clip_changes): Use PT instead of BUF_PT.
6830 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6832 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6833 $(EMACS_ROOT)/lib/intprops.h.
6835 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6837 Fix more problems found by GCC 4.5.2's static checks.
6839 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6840 to unsigned char * to avoid compiler diagnostic.
6841 (xg_free_frame_widgets): Make it clear that a local variable is
6842 needed only if USE_GTK_TOOLTIP.
6843 (gdk_window_get_screen): Make it clear that this macro is needed
6844 only if USE_GTK_TOOLTIP.
6845 (int_gtk_range_get_value): New function, which avoids a diagnostic
6846 from gcc -Wbad-function-cast.
6847 (xg_set_toolkit_scroll_bar_thumb): Use it.
6848 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6849 diagnostic from gcc -Wbad-function-cast.
6850 (get_utf8_string, xg_get_file_with_chooser):
6851 Rename locals to avoid shadowing.
6852 (create_dialog): Move locals to avoid shadowing.
6854 * xgselect.c (xg_select): Remove unused var.
6856 * image.c (four_corners_best): Mark locals as initialized.
6857 (gif_load): Initialize transparent_p to zero (Bug#8238).
6858 Mark another local as initialized.
6859 (my_png_error, my_error_exit): Mark with NO_RETURN.
6861 * image.c (clear_image_cache): Now static.
6862 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6863 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6864 (x_edge_detection): Remove unnecessary cast that
6865 gcc -Wbad-function-cast diagnoses.
6866 (gif_load): Fix pointer signedness.
6867 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6868 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6870 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6872 Improve quality of tests for time stamp overflow.
6873 For example, without this patch (encode-time 0 0 0 1 1
6874 1152921504606846976) returns the obviously-bogus value (-948597
6875 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6876 reports time overflow. See
6877 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6878 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6879 * editfns.c: Include limits.h and intprops.h.
6880 (TIME_T_MIN, TIME_T_MAX): New macros.
6881 (time_overflow): Move earlier, to before first use.
6882 (hi_time, lo_time): New functions, for an accurate test for
6884 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6885 (Fget_internal_run_time): Don't assume time_t fits in int.
6886 (make_time): Use list2 instead of Fcons twice.
6887 (Fdecode_time): More accurate test for out-of-range times.
6888 (check_tm_member): New function.
6889 (Fencode_time): Use it, to test for out-of-range times.
6890 (lisp_time_argument): Don't rely on undefined left-shift and
6891 right-shift behavior when checking for time stamp overflow.
6893 * editfns.c (time_overflow): New function, refactoring common code.
6894 (Fformat_time_string, Fdecode_time, Fencode_time):
6895 (Fcurrent_time_string): Use it.
6897 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6898 * dired.c (make_time): Move to ...
6899 * editfns.c (make_time): ... here.
6900 * systime.h: Note the move.
6902 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6904 * fringe.c (update_window_fringes): Remove unused variables.
6906 * unexmacosx.c (copy_data_segment): Also copy __got section.
6909 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6911 * termcap.c [MSDOS]: Include "msdos.h".
6912 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6913 Constify `char *' arguments and their references according to
6914 prototypes in tparam.h.
6916 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6918 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6919 Adapt all references accordingly.
6921 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6923 2011-03-11 Tom Tromey <tromey@redhat.com>
6925 * buffer.c (syms_of_buffer): Remove obsolete comment.
6927 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6929 * termhooks.h (encode_terminal_code): Declare prototype.
6931 * msdos.c (encode_terminal_code): Don't declare prototype.
6933 * term.c (encode_terminal_code): Now external again, used by
6934 w32console.c and msdos.c.
6936 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6937 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6939 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6941 Fix some minor problems found by GCC 4.5.2's static checks.
6943 * fringe.c (update_window_fringes): Mark locals as initialized
6945 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6947 * alloc.c (mark_fringe_data): Move decl from here ...
6948 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6949 to check its interface.
6950 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6952 * fontset.c (free_realized_fontset): Now static.
6953 (Fset_fontset_font): Rename local to avoid shadowing.
6954 (fontset_font): Mark local as initialized.
6955 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6957 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6959 * xselect.c (x_disown_buffer_selections): Remove; not used.
6960 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6961 (x_own_selection, Fx_disown_selection_internal): Rename locals
6963 (x_handle_dnd_message): Remove local to avoid shadowing.
6965 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6966 so that the caller can use some name other than gcpro1.
6967 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6968 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6969 (Fx_backspace_delete_keys_p):
6970 Use them to avoid shadowing, and rename vars to avoid shadowing.
6971 (x_decode_color, x_set_name, x_window): Now static.
6972 (Fx_create_frame): Add braces to silence GCC warning.
6973 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6974 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6975 Remove unused locals.
6976 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6977 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6978 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6981 * xterm.h (x_mouse_leave): New decl.
6983 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6984 Remove unused functions.
6985 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6986 (x_calc_absolute_position): Now static.
6987 (XTread_socket): Don't define label "out" unless it's used.
6988 Don't declare local "event" unless it's used.
6989 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6990 unless they are used.
6991 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6992 (x_fatal_error_signal): Remove; not used.
6993 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6994 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6995 (x_error_catcher, x_connection_closed, x_error_handler):
6996 (x_error_quitter, xembed_send_message, x_iconify_frame):
6997 (my_log_handler): Rename locals to avoid shadowing.
6998 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6999 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7001 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7002 Rename or move locals to avoid shadowing.
7003 (tty_defined_color, merge_face_heights): Now static.
7004 (free_realized_faces_for_fontset): Remove; not used.
7005 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7006 does not deduce is never used uninitialized.
7007 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7008 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7010 * terminal.c (store_terminal_param): Now static.
7012 * xmenu.c (menu_highlight_callback): Now static.
7013 (set_frame_menubar): Remove unused local.
7014 (xmenu_show): Rename parameter to avoid shadowing.
7015 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7016 since they might point to immutable storage.
7017 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7018 since it's unused otherwise.
7020 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7021 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7022 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7023 avoids a gcc -Wuninitialized diagnostic.
7024 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7025 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7026 does not deduce are never used uninitialized.
7028 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7030 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7031 * window.c (window_loop, size_window):
7032 (run_window_configuration_change_hook, enlarge_window): Likewise.
7034 * window.c (display_buffer): Now static.
7035 (size_window): Mark variables that gcc -Wuninitialized
7036 does not deduce are never used uninitialized.
7037 * window.h (check_all_windows): New decl, to forestall
7038 gcc -Wmissing-prototypes diagnostic.
7039 * dispextern.h (bidi_dump_cached_states): Likewise.
7041 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7043 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7045 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7046 and to avoid gcc -Wuninitialized warning.
7047 (load_charset_map): Mark variables that gcc -Wuninitialized
7048 does not deduce are never used uninitialized.
7049 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7051 * coding.c (coding_set_source, coding_set_destination):
7052 Use "else { /* comment */ }" rather than "else /* comment */;"
7053 for clarity, and to avoid gcc -Wempty-body warning.
7054 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7055 a block, when the outer 'i' will do.
7056 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7057 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7058 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7059 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7060 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7061 Rename locals to avoid shadowing.
7062 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7063 * coding.c (emacs_mule_char, encode_invocation_designation):
7064 Now static, since they're not used elsewhere.
7065 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7066 (decode_coding_object, encode_coding_object, detect_coding_system):
7067 (decode_coding_emacs_mule): Mark variables that gcc
7068 -Wuninitialized does not deduce are never used uninitialized.
7069 (detect_coding_iso_2022): Initialize a local variable that might
7070 be used uninitialized. Leave a FIXME because it's not clear that
7071 this initialization is needed. (Bug#8211)
7072 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7073 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7074 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7075 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7076 Remove unused macros.
7078 * category.c (hash_get_category_set): Remove unused local var.
7079 (copy_category_table): Now static, since it's not used elsewhere.
7080 * character.c (string_count_byte8): Likewise.
7082 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7083 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7085 * chartab.c (copy_sub_char_table): Now static, since it's not used
7087 (sub_char_table_ref_and_range, char_table_ref_and_range):
7088 Rename locals to avoid shadowing.
7089 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7091 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7092 (BIDI_BOB): Remove unused macro.
7094 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7095 deduce are never used uninitialized.
7096 * term.c (encode_terminal_code): Likewise.
7098 * term.c (encode_terminal_code): Now static. Remove unused local.
7100 * tparam.h: New file.
7101 * term.c, tparam.h: Include it.
7102 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7103 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7104 Move these decls to tparam.h, and make them agree with what
7105 is actually in tparam.c. The previous trick of using incompatible
7106 decls in different modules does not conform to the C standard.
7107 All callers of tparam changed to use tparam's actual API.
7108 * tparam.c (tparam1, tparam, tgoto):
7109 Use const pointers where appropriate.
7111 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7112 * cm.h (struct cm): Likewise.
7113 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7114 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7115 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7116 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7117 (turn_on_face, init_tty): Likewise.
7118 * termchar.h (struct tty_display_info): Likewise.
7120 * term.c (term_mouse_position): Rename local to avoid shadowing.
7122 * alloc.c (mark_ttys): Move decl from here ...
7123 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7125 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7127 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7129 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7131 * search.c (compile_pattern_1): Remove argument regp, unused since
7132 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7133 (compile_pattern): Don't pass it.
7135 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7137 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7138 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7140 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7142 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7144 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7145 gdk_window_get_screen, gdk_window_get_geometry,
7146 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7147 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7148 (xg_get_pixbuf_from_pixmap): New function.
7149 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7150 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7151 Call xg_get_pixbuf_from_pixmap instead of
7152 gdk_pixbuf_get_from_drawable.
7153 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7154 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7155 (xg_check_special_colors): Use GtkStyleContext and its functions
7157 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7158 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7159 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7160 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7161 Call gtk_widget_get_preferred_size.
7162 (xg_frame_resized): gdk_window_get_geometry only takes 5
7164 (xg_win_to_widget, xg_event_is_for_menubar):
7165 Call gdk_x11_window_lookup_for_display.
7166 (xg_set_widget_bg): New function.
7167 (delete_cb): New function.
7168 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7169 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7170 (xg_set_background_color): Call xg_set_widget_bg.
7171 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7172 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7173 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7174 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7176 (update_frame_tool_bar): Call gtk_widget_hide.
7177 (xg_initialize): Use GDK_KEY_g.
7179 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7181 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7183 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7184 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7185 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7187 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7189 * w32xfns.c (select_palette): Check success of RealizePalette against
7190 GDI_ERROR, not zero.
7192 See ChangeLog.11 for earlier changes.
7198 Copyright (C) 2011 Free Software Foundation, Inc.
7200 This file is part of GNU Emacs.
7202 GNU Emacs is free software: you can redistribute it and/or modify
7203 it under the terms of the GNU General Public License as published by
7204 the Free Software Foundation, either version 3 of the License, or
7205 (at your option) any later version.
7207 GNU Emacs is distributed in the hope that it will be useful,
7208 but WITHOUT ANY WARRANTY; without even the implied warranty of
7209 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7210 GNU General Public License for more details.
7212 You should have received a copy of the GNU General Public License
7213 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.