1 2011-11-18 Eli Zaretskii <eliz@gnu.org>
3 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4 hash values of the two rows.
5 (copy_row_except_pointers): Preserve the used[] arrays and the
6 hash values of the two rows. (Bug#10035)
7 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
9 * xdisp.c (row_hash): New function, body extracted from
11 (compute_line_metrics): Call row_hash, instead of computing the
14 * dispnew.c (verify_row_hash): Call row_hash for computing the
15 hash code of a row, instead of duplicating code from xdisp.c.
17 * dispextern.h (row_hash): Add prototype.
19 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
21 * frame.c (delete_frame): Don't delete the terminal when the last
22 X frame is closed if emacs is built with GTK toolkit.
24 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
26 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
28 2011-11-17 Martin Rudalics <rudalics@gmx.at>
30 * window.c (Vwindow_splits): Rename to
31 Vwindow_combination_resize. Suggested by Juri Linkov.
32 (Fsplit_window_internal): Use Vwindow_combination_resize instead
35 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
37 * nsfns.m (Fns_font_name):
38 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
40 2011-11-16 Martin Rudalics <rudalics@gmx.at>
42 * window.h (window): Rename slot "nest" to "combination_limit".
43 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
44 (Fset_window_nest): Rename to Fset_window_combination_limit.
45 (Vwindow_nest): Rename to Vwindow_combination_limit.
46 (recombine_windows, make_parent_window, make_window)
47 (Fsplit_window_internal, saved_window)
48 (Fset_window_configuration, save_window_save): Rename all
49 occurrences of window_nest to window_combination_limit.
51 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
53 * image.c (imagemagick_load_image): Fix typo.
55 2011-11-14 Eli Zaretskii <eliz@gnu.org>
57 * xdisp.c (display_line): Move the call to
58 highlight_trailing_whitespace before the call to
59 compute_line_metrics, since the latter needs to see the final
60 faces of all the glyphs to compute ROW's hash value. Fixes
61 assertion violations in row_equal_p. (Bug#10035)
63 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
65 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
66 just return (bug#10044).
68 2011-11-12 Eli Zaretskii <eliz@gnu.org>
70 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
71 with user-defined heap size. Bump the default size of the temacs
72 heap to 27MB, to avoid memory warning when running temacs.
73 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
75 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
76 current_matrix and desired_matrix. (Bug#9990)
77 (verify_row_hash) [XASSERTS]: New function.
78 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
79 that the hash value of glyph rows is correct.
81 2011-11-12 Martin Rudalics <rudalics@gmx.at>
83 * window.h (window): Remove splits slot.
84 * window.c (Fwindow_splits, Fset_window_splits): Remove.
85 (Fdelete_other_windows_internal, make_parent_window)
86 (make_window, Fsplit_window_internal, Fdelete_window_internal)
87 (Fset_window_configuration, save_window_save): Don't deal with
88 split status of windows.
89 (saved_window): Remove splits slot.
90 (Vwindow_splits): Rewrite doc-string.
92 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
94 * xfns.c (unwind_create_frame):
95 * nsfns.m (unwind_create_frame):
96 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
97 Vframe_list (Bug#9999).
99 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
101 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
103 2011-11-11 Kenichi Handa <handa@m17n.org>
105 * callproc.c (Fcall_process): Set the member dst_multibyte of
108 2011-11-11 Johan Bockgård <bojohan@gnu.org>
110 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
111 avoid a crash (bug#9496).
113 2011-11-09 Chong Yidong <cyd@gnu.org>
115 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
116 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
118 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
120 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
122 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
124 Avoid some portability problems by eschewing 'extern inline' functions.
125 The trivial performance wins aren't worth the portability hassles; see
126 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
128 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
129 (window_box_width, window_box_left, window_box_left_offset)
130 (window_box_right, window_box_right_offset): Undo previous change,
131 by removing the "extern"s.
132 * intervals.c (adjust_intervals_for_insertion)
133 (adjust_intervals_for_deletion): Undo previous change,
134 making these static again.
135 (offset_intervals, temp_set_point_both, temp_set_point)
136 (copy_intervals_to_string): No longer inline.
137 * xdisp.c (window_text_bottom_y, window_box_width)
138 (window_box_height, window_box_left_offset)
139 (window_box_right_offset, window_box_left, window_box_right)
140 (window_box): No longer inline.
142 2011-11-08 Chong Yidong <cyd@gnu.org>
144 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
145 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
146 an error if not a live window.
147 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
148 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
150 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
152 * lisp.h (syms_of_abbrev): Remove declaration.
153 Reported by CHENG Gao <chenggao@royau.me>.
155 2011-11-07 Eli Zaretskii <eliz@gnu.org>
157 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
158 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
159 of temacs in GUI mode.
161 2011-11-07 Martin Rudalics <rudalics@gmx.at>
163 * window.h: Declare delete_all_child_windows instead of
164 delete_all_subwindows.
165 * window.c (Fwindow_nest, Fset_window_nest)
166 (Fset_window_new_total, Fset_window_new_normal)
167 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
168 (delete_all_subwindows): Rename to delete_all_child_windows.
169 (Fdelete_other_windows_internal, Fset_window_configuration):
170 Call delete_all_child_windows instead of delete_all_subwindows.
171 * frame.c (delete_frame): Call delete_all_child_windows instead
172 of delete_all_subwindows.
174 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
176 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
177 This is also needed for porting to any host where GC_MARK_STACK is
178 not GC_MAKE_GCPROS_NOOPS.
179 (which_symbols): Use it.
181 2011-11-07 Kenichi Handa <handa@m17n.org>
183 * coding.c (coding_set_destination): Check coding->src_pos only
184 when coding->src_object is a buffer (bug#9910).
186 * process.c (send_process): Set the member src_multibyte of coding
187 to 0 (bug#9911) when sending a unibyte text.
189 * callproc.c (Fcall_process): Set the member src_multibyte of
190 process_coding to 0 (bug#9912).
192 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
194 * xmenu.c (cleanup_widget_value_tree): New function.
195 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
196 calling free_menubar_widget_value_tree directly (Bug#9830).
198 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
200 Fix some portability problems with 'inline'.
201 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
202 (window_box_width, window_box_left, window_box_left_offset)
203 (window_box_right, window_box_right_offset): Declare extern.
204 Otherwise, these inline functions do not conform to C99 and
205 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
206 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
207 * intervals.c (adjust_intervals_for_insertion)
208 (adjust_intervals_for_deletion): Now extern, because otherwise the
209 extern inline functions 'offset_intervals' couldn't refer to it.
210 (static_offset_intervals): Remove.
211 (offset_intervals): Rewrite using the old contents of
212 static_offset_intervals. The old version didn't conform to C99
213 because an extern inline function contained a reference to an
214 identifier with static linkage.
216 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
218 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
221 2011-11-06 Eli Zaretskii <eliz@gnu.org>
223 * xdisp.c (init_iterator, reseat_to_string): Don't set the
224 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
225 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
226 return Qleft_to_right.
228 2011-11-06 Chong Yidong <cyd@gnu.org>
230 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
231 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
232 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
233 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
234 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
235 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
236 (Fwindow_vscroll): Doc fix.
237 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
238 argument, since it makes no sense to pass a live window and for
239 consistency with window-child.
241 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
243 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
246 2011-11-05 Jason Rumney <jasonr@gnu.org>
248 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
249 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
251 (add_font_entity_to_list): Fix logic errors in mixed boolean and
252 bitwise arithmetic preventing use of unicode-sip and non-truetype
255 2011-11-05 Eli Zaretskii <eliz@gnu.org>
257 * s/ms-w32.h (fstat, stat, utime): Move redirections to
260 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
261 initialization code to keep similarity to xfns.c after changes
264 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
266 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
267 (unwind_create_frame): New function (Bug#9943).
268 (Fx_create_frame): Restructure code to be more similar to the one in
269 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
270 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
271 Move terminal->reference_count++ just before making the frame official
274 * nsterm.m (x_free_frame_resources): New function.
275 (x_destroy_window): Move code to x_free_frame_resources.
277 * xfns.c (unwind_create_frame): Fix comment.
278 (Fx_create_frame, x_create_tip_frame): Move
279 terminal->reference_count++ just before making the frame
280 official. Move initialization of image_cache_refcount and
281 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
283 2011-11-05 Eli Zaretskii <eliz@gnu.org>
285 Support MSVC build with newer versions of Visual Studio.
286 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
287 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
290 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
291 which are not supported by MSVC.
292 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
293 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
295 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
297 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
299 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
301 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
303 Support MSVC build with newer versions of Visual Studio.
304 * w32.c: Don't include w32api.h for MSVC.
305 (init_environment) [_MSC_VER]: Call sys_access, not _access.
307 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
308 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
309 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
310 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
312 (alloca) [_MSC_VER]: Define to _alloca.
314 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
316 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
318 2011-11-04 Eli Zaretskii <eliz@gnu.org>
320 * xdisp.c (note_mouse_highlight): If either of
321 previous/next-single-property-change returns nil, treat that as
322 the beginning or the end of the buffer. (Bug#9955)
324 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
326 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
327 label is not null (Bug#9951).
328 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
331 2011-11-04 Eli Zaretskii <eliz@gnu.org>
333 * window.c (Fwindow_body_size): Mention in the doc string that the
334 return value is in frame's canonical units. (Bug#9949)
336 2011-11-03 Eli Zaretskii <eliz@gnu.org>
338 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
340 * w32fns.c (unwind_create_frame): If needed, free the glyph
341 matrices of the partially constructed frame. (Bug#9943)
342 * xfns.c (unwind_create_frame): Likewise.
344 2011-11-01 Eli Zaretskii <eliz@gnu.org>
346 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
347 Don't stop backward scan on the continuation glyph, even though
348 its CHARPOS is positive.
349 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
350 cover_string to disp_string.
352 2011-11-01 Martin Rudalics <rudalics@gmx.at>
354 * window.c (temp_output_buffer_show): Don't use
355 Vtemp_buffer_show_specifiers.
356 (Vtemp_buffer_show_specifiers): Remove unused variable.
358 2011-10-30 Eli Zaretskii <eliz@gnu.org>
360 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
361 past the beginning of the current glyph matrix.
363 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
365 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
366 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
367 HAVE_GTK3 (Bug#9869).
369 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
370 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
372 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
374 * xterm.c: Declare x_handle_net_wm_state to return int.
375 (handle_one_xevent): Check if we are iconified but don't have
376 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
377 (get_current_wm_state): Return non-zero if not hidden,
378 check for _NET_WM_STATE_HIDDEN (Bug#9893).
379 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
380 (x_handle_net_wm_state): Return what get_current_wm_state returns.
381 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
383 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
385 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
386 so that this new function doesn't get optimized away by a
387 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
389 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
391 * frame.h (MOUSE_HL_INFO): Remove excess parens.
393 2011-10-29 Eli Zaretskii <eliz@gnu.org>
395 Fix the `xbytecode' command.
396 * .gdbinit (xprintbytestr): New command.
397 (xwhichsymbols): Renamed from `which'; all callers changed.
398 (xbytecode): Print the byte-code string as well.
400 2011-10-29 Kim Storm <storm@cua.dk>
402 * alloc.c (which_symbols): New function.
404 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
406 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
409 2011-10-29 Glenn Morris <rgm@gnu.org>
411 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
412 Not clear what it was for, and it causes various bugs. (Bug#9839)
414 2011-10-28 Eli Zaretskii <eliz@gnu.org>
416 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
417 possible random value that matches one of those tested as
418 condition to clear the mouse face.
420 2011-10-28 Chong Yidong <cyd@gnu.org>
422 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
424 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
426 * window.c (make_window): Initialize phys_cursor_on_p.
428 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
430 * lisp.h (struct Lisp_Symbol): Update comments.
432 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
434 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
436 2011-10-28 Eli Zaretskii <eliz@gnu.org>
438 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
439 <oslsachem@gmail.com> for helping to debug this.
441 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
442 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
443 (g_b_init_get_glyph_outline_w): New static variables.
444 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
445 (GetGlyphOutlineW_Proc): New typedefs.
446 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
447 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
449 (w32font_open_internal, compute_metrics):
450 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
451 instead of calling the "wide" APIs directly.
453 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
455 * w32.h (syms_of_w32font): Add prototype.
457 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
459 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
460 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
461 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
462 (Fmove_to_window_line): Doc fix.
464 2011-10-27 Chong Yidong <cyd@gnu.org>
466 * process.c (make_process): Set gnutls_state to NULL.
468 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
469 non-NULL, regardless of GNUTLS_INITSTAGE.
470 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
471 an error. Set process slots as soon as we allocate them.
473 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
475 2011-10-27 Chong Yidong <cyd@gnu.org>
477 * gnutls.c (emacs_gnutls_deinit): New function.
478 Deallocate credentials structures as well as calling gnutls_deinit.
479 (Fgnutls_deinit, Fgnutls_boot): Use it.
481 * process.c (make_process): Initialize GnuTLS credentials to NULL.
482 (deactivate_process): Call emacs_gnutls_deinit.
484 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
486 * image.c (x_create_x_image_and_pixmap):
487 * w32.c (sys_rename, w32_delayed_load):
488 * w32font.c (fill_in_logfont):
489 * w32reg.c (x_get_string_resource): Silence compiler warnings.
491 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
493 * w32fns.c (w32_default_color_map): New function,
494 extracted from Fw32_default_color_map.
495 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
497 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
499 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
501 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
503 * keyboard.c (test_undefined): New function (bug#9751).
504 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
506 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
508 * sysdep.c (init_sys_modes): Fix the check for the controlling
511 2011-10-20 Eli Zaretskii <eliz@gnu.org>
513 * dispextern.h (struct bidi_it): New member next_en_type.
515 * bidi.c (bidi_line_init): Initialize the next_en_type member.
516 (bidi_resolve_explicit_1): When next_en_pos is valid for the
517 current character, check also for next_en_type being WEAK_EN.
518 (bidi_resolve_weak): Don't enter the expensive loop if the current
519 position is before next_en_pos. Record the bidi type of the first
520 non-ET, non-BN character we find, in addition to its position.
521 (bidi_level_of_next_char): Invalidate next_en_type when
522 next_en_pos is over-stepped.
524 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
526 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
527 * editfns.c: Rewrite current-time-zone so that it invokes
528 the equivalent of (format-time-string "%Z") to get the time zone name.
529 This fixes a bug when the time zone name contains characters that
530 need converting from the system time locale to Emacs internal format.
531 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
532 that patch fixed format-time-string to do the conversion, but
533 I forgot to fix current-time-zone.
534 (format_time_string): New function, containing most of
535 what Fformat_time_string used to contain.
536 (Fformat_time_string): Rewrite in terms of format_time_string.
537 This doesn't change this function's behavior.
538 (current-time-zone): Rewrite to use format_time_string.
539 This fixes the bug reported by Michael Schierl in
540 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
541 Jason Rumney's 2007-06-07 change worked around this bug, but
543 * systime.h (tzname, timezone): Remove no-longer-used declarations.
545 2011-10-19 Eli Zaretskii <eliz@gnu.org>
547 * xdisp.c (start_display): If the character at POS is displayed
548 via a display vector, reset IT->current.dpvec_index to zero.
549 (try_window_reusing_current_matrix): If a line ends in a display
550 vector or the next line starts in a display vector, continue
551 redrawing the window even though the character position of
552 start_row was reached.
555 2011-10-18 Chong Yidong <cyd@gnu.org>
557 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
558 with nobreak-char-display too.
560 2011-10-18 Eli Zaretskii <eliz@gnu.org>
562 Fix part 3 of bug#9771.
563 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
564 (bidi_resolve_neutral): Don't enter the expensive loop looking for
565 non-neutral characters if the current character is a paragraph
566 separator (a.k.a. Newline). This avoids running the same
567 expensive loop twice, once when we consume the preceding newline
568 and the other time when the line actually needs to be displayed.
569 Avoid the loop when we see neutrals on the base embedding level
570 following a character whose directionality is the same as the
571 paragraph's. This avoids running the expensive loop when a line
572 ends in a long sequence of neutrals, like control characters.
573 Add assertion against STRONG_AL type. Slightly rearrange code
574 that determines the type of a neutral given the first non-neutral
576 (bidi_level_of_next_char): Set next_en_pos to zero when
577 invalidating its info.
579 2011-10-17 Eli Zaretskii <eliz@gnu.org>
581 * xdisp.c (push_display_prop): Determine whether to record string
582 or buffer position by IT->string, not by IT->method. Allow
583 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
584 (move_it_vertically_backward): Don't look for character position
585 immediately after the newline when in a continuation line.
588 2011-10-15 Martin Rudalics <rudalics@gmx.at>
590 * window.c (coordinates_in_window): Rewrite and delabelize
591 vertical border check. (Bug#5357) (Bug#9618)
593 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
595 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
596 errors in XSetWindowBorder (bug#9310).
598 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
600 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
601 avoid crash when xmalloc overrun checking is enabled.
603 2011-10-13 Eli Zaretskii <eliz@gnu.org>
605 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
606 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
607 cursor motion with <left> and <right> arrow keys.
609 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
610 some callers set that themselves.
612 2011-10-12 Eli Zaretskii <eliz@gnu.org>
614 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
615 display string and the previous row comes from the same string and
616 is empty. (Bug#9739) (Bug#9738)
618 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
620 * doc.c (get_doc_string): Encode file name (bug#9735).
622 2011-10-12 Eli Zaretskii <eliz@gnu.org>
624 * bidi.c (bidi_level_of_next_char):
625 * xdisp.c (get_visually_first_element): Remove old incorrect
626 comments regarding the Unicode Line Separator character.
628 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
630 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
632 * alloc.c (Fgc_status): Do not access beyond zombies array
633 boundary if nzombies > MAX_ZOMBIES.
634 * alloc.c (dump_zombies): Add missing format specifier.
636 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
638 * xdisp.c (set_cursor_from_row): Simplify conditionals,
639 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
641 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
642 Some packages use them to denote characters with modifiers.
644 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
646 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
647 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
648 matching a pp-number. Rename parameter var to var1.
650 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
652 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
654 2011-10-08 Glenn Morris <rgm@gnu.org>
656 * callint.c (Fcall_interactively): Give a more explicit error for the
657 'c' case with a non-character input. (Bug#8479)
659 2011-10-08 Eli Zaretskii <eliz@gnu.org>
661 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
663 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
664 lines that are hscrolled on the left.
666 * dispnew.c (buffer_posn_from_coords): Account for a possible
667 presence of header-line. (Bug#4426)
669 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
671 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
672 Don't advertise functionality which we discourage or doesn't work.
674 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
676 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
677 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
678 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
679 this makes Emacs dump core during garbage collection on rare
680 occasions. sizeof is obviously inferior to offsetof here, so
682 (GC_POINTER_ALIGNMENT): New macro.
683 (mark_memory): Omit 3rd (offset) arg; caller changed.
684 Don't assume EMACS_INT alignment is the same as pointer alignment.
686 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
688 * keyboard.c (read_key_sequence_remapped): New var.
689 (read_key_sequence): Compute remapping in the right buffer.
690 (command_loop_1): Use read_key_sequence's remapping directly.
692 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
694 * dired.c (file_name_completion): Don't expand file name.
695 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
696 before checking file name handler.
698 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
699 they've been requested explicitly (bug#9591).
701 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
703 * keymap.c (Fsingle_key_description): Use make_specified_string
704 instead of build_string to build string from push_key_description.
707 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
709 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
710 This fixes a Y2038 bug on 64-bit hosts.
711 * buffer.c (reset_buffer):
712 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
713 (Fclear_buffer_auto_save_failure):
714 Use 0, not -1, to represent an unset failure time, since time_t
717 Remove dependency on glibc malloc internals.
718 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
719 Move back here from lisp.h, but with their new implementations.
720 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
721 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
722 * charset.c (charset_table_init): New static var.
723 (syms_of_charset): Use it instead of xmalloc. This removes a
724 dependency on glibc malloc internals. See Eli Zaretskii's comment in
725 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
726 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
727 Move back to alloc.c.
728 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
729 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
731 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
733 * nsterm.m (windowDidResize): Call x_set_window_size only when
734 ns_in_resize is true. Otherwise set pixelwidth/height and
735 call change_frame_size (Bug#9628).
737 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
739 Port --enable-checking=all to Fedora 14 x86-64.
740 * charset.c (syms_of_charset): Also account for glibc malloc's
741 internal overhead when calculating the initial malloc maximum.
743 Port --enable-checking=all to Fedora 14 x86.
744 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
746 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
747 (overrun_check_realloc, overrun_check_free):
748 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
749 That way, xmalloc returns a properly-aligned pointer even if
750 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
751 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
752 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
753 into account when calculating the initial malloc maximum.
754 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
755 Move here from alloc.c, so that charset.c can use it too.
756 Properly align; the old code wasn't right for common 32-bit hosts
757 when configured with --enable-checking=all.
758 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
759 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
761 2011-09-29 Eli Zaretskii <eliz@gnu.org>
763 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
766 2011-09-28 Eli Zaretskii <eliz@gnu.org>
768 * xdisp.c (compute_display_string_end): If there's no display
769 string at CHARPOS, return -1.
771 * bidi.c (bidi_fetch_char): When compute_display_string_end
772 returns a negative value, treat the character as a normal
773 character not covered by a display string. (Bug#9624)
775 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
777 * lread.c (Fread_from_string): Fix typo in docstring.
779 2011-09-27 Eli Zaretskii <eliz@gnu.org>
781 * xdisp.c (handle_invisible_prop): If invisible text ends on a
782 newline, reseat the iterator instead of bidi-iterating there one
783 character at a time. (Bug#9610)
784 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
785 TO_CHARPOS if the bidi iterator is at base embedding level.
787 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
789 * lread.c (readevalloop): Use correct code for NBSP.
790 (read1): Likewise. (Bug#9608)
792 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
794 * dbusbind.c (Fdbus_register_signal): When service is not
795 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
797 2011-09-25 Glenn Morris <rgm@gnu.org>
799 * buffer.c (truncate-lines): Doc fix.
801 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
803 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
804 (Fset_window_next_buffers): Doc fix.
806 2011-09-24 Glenn Morris <rgm@gnu.org>
808 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
810 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
812 Fix minor problems found by static checking.
813 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
814 * indent.c (Fvertical_motion): Fix == vs = typo.
816 2011-09-24 Eli Zaretskii <eliz@gnu.org>
818 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
819 Default value is now t. Doc fix.
821 * indent.c (Fvertical_motion): Compute and apply the overshoot
822 logic when moving up, not only when moving down. Fix the
823 confusing name and values of the it_overshoot_expected variable;
824 logic changes accordingly. (Bug#9254) (Bug#9549)
826 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
827 CHARPOS is covered by a display string which includes newlines.
828 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
829 is covered by a display string with embedded newlines.
831 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
833 * dbusbind.c (Fdbus_register_signal): Add match rule to
834 Vdbus_registered_objects_table. (Bug#9581)
835 (Fdbus_register_method, Vdbus_registered_objects_table):
838 2011-09-24 Jim Meyering <meyering@redhat.com>
840 do not ignore write error for any output size
841 The previous change was incomplete.
842 While it makes emacs --batch detect the vast majority of stdout
843 write failures, errors were still ignored whenever the output size is
844 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
845 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
846 && echo FAIL: ignored write error
847 FAIL: ignored write error
848 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
849 && echo FAIL: ignored write error
850 FAIL: ignored write error
851 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
853 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
855 * emacs.c (Fkill_emacs): In noninteractive mode exit
856 non-successfully if a write error occurred on stdout. (Bug#9574)
858 2011-09-21 Eli Zaretskii <eliz@gnu.org>
860 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
863 * dispextern.h (struct it): Update the comment documenting what
866 2011-09-20 Eli Zaretskii <eliz@gnu.org>
868 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
869 a display string, extend search for cursor position to end of row.
870 (find_row_edges): If the row ends in a newline from a display
871 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
872 Handle the case of a display string with multiple newlines.
873 (Fcurrent_bidi_paragraph_direction): Fix search for previous
874 non-empty line. Fixes confusing cursor motion with arrow keys at
875 the beginning of a line that starts with whitespace.
877 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
879 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
882 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
884 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
887 2011-09-18 Eli Zaretskii <eliz@gnu.org>
889 * xdisp.c (display_line): Record maximum and minimum buffer
890 positions even if no glyphs were produced (e.g., by a zero-width
891 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
892 buffer positions that will be removed from the glyph row because
894 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
895 column is beyond frame width: don't subtract 1 "pixel" when
896 computing width of the stretch.
897 (reseat_at_next_visible_line_start): Undo the change made on
898 2011-09-17 that saved paragraph information and restored it after
899 the call to `reseat'. (Bug#9545)
901 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
903 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
904 and turn window cursor on if cleared (Bug#9415).
906 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
908 * search.c (boyer_moore): Take unibyte characters from pattern
909 literally. (Bug#9458)
911 2011-09-18 Eli Zaretskii <eliz@gnu.org>
913 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
915 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
917 Fix minor problem found by static checking.
918 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
919 initialized, to pacify gcc -Wuninitialized.
921 * fileio.c: Report proper errno when syscall falls.
922 (Finsert_file_contents): Save and restore errno,
923 so that report_file_error outputs the correct diagnostic.
924 (Fwrite_region) [CLASH_DETECTION]: Likewise.
926 2011-09-18 Eli Zaretskii <eliz@gnu.org>
928 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
930 2011-09-17 Eli Zaretskii <eliz@gnu.org>
932 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
933 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
935 2011-09-17 Eli Zaretskii <eliz@gnu.org>
937 * xdisp.c (reseat_at_next_visible_line_start): Keep information
938 about the current paragraph and restore it after the call to reseat.
940 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
941 (bidi_find_paragraph_start): Search back for paragraph beginning
942 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
943 (bidi_move_to_visually_next): Only trigger paragraph-related
944 computations when the last character is a newline or at EOB, not
945 just any NEUTRAL_B. (Bug#9470)
947 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
948 truncated lines if point is covered by a display string. (Bug#9524)
950 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
952 * xselect.c: Relax test for outgoing X longs (Bug#9498).
953 (cons_to_x_long): New function.
954 (lisp_data_to_selection_data): Use it. Correct the test for
955 short-versus-long data; it was negated. Break out of vector
956 loop, for efficiency, when a long datum is discovered.
958 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
960 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
962 2011-09-16 Eli Zaretskii <eliz@gnu.org>
964 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
965 GCC PR/17406) by declaring this function with external scope.
967 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
969 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
970 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
972 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
974 * editfns.c (Fformat): Correctly handle text properties on "%%".
976 2011-09-15 Eli Zaretskii <eliz@gnu.org>
978 * xterm.c (x_draw_composite_glyph_string_foreground):
979 * w32term.c (x_draw_composite_glyph_string_foreground):
980 * term.c (encode_terminal_code):
981 * composite.c (composition_update_it, get_composition_id):
982 * xdisp.c (get_next_display_element)
983 (fill_composite_glyph_string): Add comments about special meaning
984 of TAB characters in a composition.
986 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
988 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
989 This occurs when processing a multibyte format.
990 Problem reported by Wolfgang Jenker.
992 2011-09-15 Johan Bockgård <bojohan@gnu.org>
994 * xdisp.c (try_cursor_movement): Only check for exact match if
995 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
997 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
999 Remove unused external symbols.
1000 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1001 * xdisp.c (calc_pixel_width_or_height): Now static.
1002 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1003 * indent.c (check_display_width):
1004 * w32term.c: Fix comment to match code.
1005 * xterm.c, xterm.h (x_catching_errors): Remove.
1007 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1009 * xselect.c: Use signed conversions more consistently (Bug#9498).
1010 (selection_data_to_lisp_data): Assume incoming selection data are
1011 signed integers, not unsigned. This is to be consistent with
1012 outgoing selection data, which was modified to use signed integers
1013 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1014 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1015 expects long, not unsigned long.
1017 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1019 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1020 computation of loop end. Reported by Johan Bockgård
1023 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1025 * frame.c (Fother_visible_frames_p): Function deleted.
1027 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1029 * indent.c (compute_motion): Process display vector front to back
1030 rather than the other way around. (Bug#2496)
1032 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1034 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1036 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1038 * minibuf.c (Fread_from_minibuffer): Doc fix.
1040 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1042 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1043 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1045 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1047 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1048 value for non-existent files.
1050 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1052 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1053 set its "size" to -1. This will set the modtime_size field of
1054 the corresponding buffer to -1, which is what
1055 verify-visited-file-modtime expects for files that do not exist.
1058 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1060 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1062 * lisp.h: ... from here. push_key_description is no longer
1063 defined in keyboard.c, so its declaration should not be in
1064 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1065 logically belongs with push_key_description.
1067 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1069 * buffer.h: Include <sys/types.h> instead of <time.h>.
1070 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1071 Problem reported by Herbert J. Skuhra.
1073 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1075 * xml.c (parse_region): Make the parsing work for
1076 non-comment-starting XML files again (bug#9144).
1078 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1080 * image.c (gif_load): Fix calculation of bottom and right corner.
1083 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1085 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1086 redisplay in small windows.
1088 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1090 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1092 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1094 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1095 Operate on live windows only.
1097 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1099 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1101 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1103 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1104 only under bidi iteration.
1106 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1108 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1110 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1112 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1113 Without this fix, the command to link temacs failed due to an
1114 undefined symbol __builtin_isnan. This is because
1115 /usr/include/iso/math_c99.h #defines isnan(x) to
1116 __builtin_isnan(x), but the bundled gcc, which identifies itself
1117 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1119 * floatfns.c (isnan): #undef, and then #define to a clone of
1121 (Fisnan): Always define, since it's always available now.
1122 (syms_of_floatfns): Always define isnan at the Lisp level.
1124 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1126 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1128 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1130 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1131 The previous code assumed that file offsets (off_t values) fit in
1132 EMACS_INT variables, which is not true on typical 32-bit hosts.
1133 The code messed up by falsely reporting buffer overflow in cases
1134 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1135 when "big" contains more than 2**29 bytes, even though this
1136 inserts just one byte and does not overflow the buffer.
1137 (Finsert_file_contents): Store file offsets as off_t
1138 values, not as EMACS_INT values. Check for overflow when
1139 converting between EMACS_INT and off_t. When checking for
1140 buffer overflow or for overlap, take the offsets into account.
1141 Don't use EMACS_INT for small values where int suffices.
1142 When checking for overlap, fix a typo: ZV was used where
1143 ZV_BYTE was intended.
1144 (Fwrite_region): Don't assume off_t fits into 'long'.
1145 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1147 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1149 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1151 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1153 sprintf-related integer and memory overflow issues (Bug#9412).
1155 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1156 (esprintf, exprintf, evxprintf): New functions.
1157 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1158 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1159 (modify_event_symbol): Do not assume that the length of
1160 name_alist_or_stem is safe to alloca and fits in int.
1161 (Fexecute_extended_command): Likewise for function name and binding.
1162 (Frecursion_depth): Wrap around reliably on integer overflow.
1163 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1164 since some callers pass EMACS_INT values.
1165 (Fsingle_key_description): Don't crash if symbol name contains more
1166 than MAX_ALLOCA bytes.
1167 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1168 (get_minibuffer): Arg is now EMACS_INT, not int.
1169 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1170 (esprintf, exprintf, evxprintf): New decls.
1171 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1173 * dbusbind.c (signature_cat): New function.
1174 (xd_signature, Fdbus_register_signal):
1175 Do not overrun buffer; instead, report string overflow.
1177 * dispnew.c (add_window_display_history): Don't overrun buffer.
1178 Truncate instead; this is OK since it's just a log.
1180 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1181 even if the time zone offset is outlandishly large.
1182 Don't mishandle offset == INT_MIN.
1184 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1185 when creating daemon; the previous buffer-overflow check was incorrect.
1187 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1188 which has the guts of the old verror function.
1190 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1191 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1193 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1194 (font_unparse_xlfd): Don't blindly alloca long strings.
1195 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1196 fits in int, when using sprintf. Use single snprintf to count
1197 length of string rather than counting it via multiple sprintfs;
1198 that's simpler and more reliable.
1199 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1200 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1201 sprintf, in case result does not fit in int.
1203 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1204 (fontset_from_font): Print it.
1206 * frame.c (tty_frame_count): Now printmax_t, not int.
1207 (make_terminal_frame, set_term_frame_name): Print it.
1208 (x_report_frame_params): In X, window IDs are unsigned long,
1209 not signed long, so print them as unsigned.
1210 (validate_x_resource_name): Check for implausibly long names,
1211 and don't assume name length fits in 'int'.
1212 (x_get_resource_string): Don't blindly alloca invocation name;
1213 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1216 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1217 (xg_check_special_colors, xg_set_geometry):
1218 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1220 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1221 Use esprintf, not sprintf, in case result does not fit in int.
1223 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1224 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1225 it as a large positive number.
1226 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1227 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1229 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1230 in case result does not fit in int.
1232 * print.c (float_to_string): Detect width overflow more reliably.
1233 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1234 buffer overrun. Don't assume list length fits in 'int'. Treat
1235 print length of 0 as 0, not as infinity; to be consistent with other
1236 uses of print length in this function. Don't overflow print length
1237 index. Don't assume hash table size fits in 'long', or that
1238 vectorlike size fits in 'unsigned long'.
1240 * process.c (make_process): Use printmax_t, not int, to format
1241 process-name gensyms.
1243 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1245 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1246 to avoid potential buffer overrun.
1248 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1249 if X resource line is longer than 512 bytes.
1251 * xfns.c (x_window): Make sprintf buffer a bit bigger
1252 to avoid potential buffer overrun.
1254 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1256 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1258 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1260 Integer overflow fixes for scrolling, etc.
1261 Without these, Emacs silently mishandles large integers sometimes.
1262 For example, "C-u 4294967297 M-x recenter" was treated as if
1263 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1265 * xdisp.c (try_window_id): Check Emacs fixnum range before
1266 converting to 'int'.
1268 * window.c (window_scroll_line_based, Frecenter):
1269 Check that an Emacs fixnum is in range before assigning it to 'int'.
1270 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1271 values converted from Emacs fixnums.
1272 (Frecenter): Don't wrap around a line count if it is out of 'int'
1273 range; instead, treat it as an extreme value.
1274 (Fset_window_configuration, compare_window_configurations):
1275 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1277 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1278 that can exceed INT_MAX. Check that EMACS_INT value is in range
1279 before assigning it to the (possibly-narrower) index.
1280 (match_limit): Don't assume that a fixnum can fit in 'int'.
1282 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1285 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1286 (Fvertical_motion): Don't wrap around LINES values that don't fit
1287 in 'int'. Instead, treat them as extreme values. This is good
1288 enough for windows, which can't have more than INT_MAX lines anyway.
1290 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1292 * Require libxml/parser.h to avoid compilation warning.
1294 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1296 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1297 since this reportedly can destroy thread storage.
1299 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1301 * syntax.c (find_defun_start): Update all cache variables if
1302 exiting early (Bug#9401).
1304 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1306 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1308 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1309 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1310 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1312 * term.c (tty_append_glyph): New function.
1313 (produce_stretch_glyph): Static function and its prototype deleted.
1315 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1318 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1320 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1321 when checking :margin (Bug#9390).
1322 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1323 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1324 so that the name doesn't mislead. All uses changed.
1326 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1328 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1331 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1333 * xdisp.c (move_it_to): Don't bail out early when reaching
1334 position beyond to_charpos, if we are scanning backwards.
1335 (move_it_vertically_backward): When DY == 0, make sure we get to
1336 the first character in the line after the newline.
1338 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1340 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1341 (ccl_driver): Do not generate an out-of-range pointer.
1342 (Fccl_execute_on_string): Remove unnecessary check for
1343 integer overflow, noted by Stefan Monnier in
1344 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1345 Remove a FIXME that didn't need fixing.
1346 Simplify the newly-introduced buffer reallocation code.
1348 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1350 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1352 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1354 Integer and memory overflow issues (Bug#9196).
1356 * doc.c (get_doc_string): Rework so that
1357 get_doc_string_buffer_size is the actual buffer size, rather than
1358 being 1 less than the actual buffer size; this makes xpalloc more
1361 * image.c (x_allocate_bitmap_record, cache_image):
1362 * xselect.c (Fx_register_dnd_atom):
1363 Simplify previous changes by using xpalloc.
1365 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1366 since either will do and ptrdiff_t is convenient with xpalloc.
1368 * charset.c (charset_table_size)
1369 (struct charset_sort_data.priority): Now ptrdiff_t.
1370 (charset_compare): Don't overflow if priorities differ greatly.
1371 (Fsort_charsets): Don't assume list length fits in int.
1372 Check for size-calculation overflow when allocating sort data.
1373 (syms_of_charset): Allocate an initial charset table that is
1374 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1376 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1378 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1379 The actual value is always <= INT_MAX, and leaving it unsigned made
1380 overflow checking harder.
1382 * dispextern.h (struct glyph_matrix.rows_allocated)
1383 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1384 with xpalloc. The values are still always <= INT_MAX.
1386 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1388 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1389 (SAFE_NALLOCA): New macro.
1391 * region-cache.c (struct boundary.pos, find_cache_boundary)
1392 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1393 (set_cache_region, invalidate_region_cache)
1394 (revalidate_region_cache, know_region_cache, region_cache_forward)
1395 (region_cache_backward, pp_cache):
1396 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1397 so that ptrdiff_t * can be passed to xpalloc.
1398 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1399 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1400 (pp_cache): Don't assume cache_len fits in int.
1401 * region-cache.h: Adjust extern decls to match.
1403 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1404 EMACS_INT, since either will do, for xpalloc.
1406 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1407 (xnmalloc, xnrealloc, xpalloc): New functions.
1409 * bidi.c (bidi_shelve_header_size): New constant.
1410 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1411 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1413 * bidi.c (bidi_cache_shrink):
1414 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1416 Don't update size of array until after memory allocation succeeds,
1417 because xmalloc/xrealloc may not return.
1418 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1419 now that we have proper integer overflow checking.
1420 (record_overlay_string, overlay_strings): Catch overflows when
1421 calculating size of overlay_str_buf.
1423 * callproc.c (Fcall_process): Check for size overflow when
1424 calculating size of args2.
1425 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1426 Normally we prefer signed values, but sticking with ptrdiff_t would
1427 require adding more-complicated checks.
1429 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1430 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1431 Redo buffer-overflow calculations to avoid integer overflow.
1432 Add a FIXME comment where memory seems to be over-allocated.
1434 * character.c (Fstring): Check for size-calculation overflow.
1436 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1437 unnecessary integer overflow. Check for size overflow.
1438 (encode_coding_object): Don't update size until xmalloc succeeds.
1440 * composite.c (get_composition_id): Check for overflow in glyph
1441 length calculations.
1443 Integer and memory overflow fixes for display code.
1444 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1445 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1446 (scrolling_window): Check for overflow in size calculations.
1447 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1448 Don't assume glyph table len fits in int.
1449 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1450 (row_table_size): Now ptrdiff_t, not int.
1451 (scrolling_window): Avoid overflow in size calculations.
1452 Don't update size until allocation succeeds.
1453 * fns.c (concat): Check for overflow in size calculations.
1454 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1455 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1456 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1458 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1459 (get_doc_string): Check for size calculation overflow.
1460 Don't update size until allocation succeeds.
1461 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1462 EMACS_INT, where ptrdiff_t will do.
1463 (Fsubstitute_command_keys): Check for string overflow.
1465 * editfns.c (set_time_zone_rule): Don't assume environment length
1467 (message_length): Now ptrdiff_t, not int.
1468 (Fmessage_box): Don't update size until allocation succeeds.
1469 Don't assume message length fits in int.
1470 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1472 * emacs.c (main): Do not reallocate argv, since there is a null at
1473 the end that can be overwritten, and this way there's no need to
1474 worry about size-calculation overflow.
1475 (sort_args): Check for size-calculation overflow.
1477 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1479 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1481 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1482 (x_set_scroll_bar_width, x_figure_window_size):
1483 Check for integer overflow.
1484 (x_set_alpha): Do not assume XINT fits in int.
1486 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1487 This is for the members text_lines, text_cols, total_lines, total_cols,
1488 where the system imposes an 'int' limit.
1490 * fringe.c (Fdefine_fringe_bitmap):
1491 Don't update size until alloc works.
1493 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1494 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1496 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1497 Check for size-calculation overflow.
1498 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1499 do, as we prefer signed integers.
1500 (id_to_widget.max_size, id_to_widget.used)
1501 (xg_store_widget_in_map, xg_remove_widget_from_map)
1502 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1503 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1504 Use and return ptrdiff_t, not int.
1505 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1506 * gtkutil.h: Change prototypes to match the above.
1508 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1509 are duplicate now that they've been promoted to lisp.h.
1510 (x_allocate_bitmap_record, x_alloc_image_color)
1511 (make_image_cache, cache_image, xpm_load):
1512 Don't update size until alloc is done.
1513 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1515 Check for size calculation overflow.
1516 (ct_colors_allocated_max): New constant.
1517 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1520 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1521 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1522 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1523 Use ptrdiff_t, not int, to count maps.
1524 (read_char_minibuf_menu_prompt): Check for overflow in size
1525 calculations. Don't update size until allocation succeeds.
1526 Redo calculations to avoid overflow.
1527 * keyboard.h: Change prototypes to match the above.
1529 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1531 (current_minor_maps): Check for size calculation overflow.
1532 * keymap.h: Change prototypes to match the above.
1534 * lread.c (read1, init_obarray): Don't update size until alloc done.
1536 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1537 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1539 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1540 Now ptrdiff_t, not int.
1541 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1542 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1544 * process.c (Fnetwork_interface_list): Check for overflow
1545 in size calculation.
1547 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1549 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1550 overflow. Don't bother calling xmalloc when xrealloc will do.
1552 * search.c (Freplace_match): Check for size calculation overflow.
1553 (Fset_match_data): Don't assume list lengths fit in 'int'.
1555 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1556 for command line length. Do not attempt to address one before the
1557 beginning of an array, as that's not portable.
1559 * term.c (max_frame_lines): Remove; unused.
1560 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1562 (encode_terminal_code, calculate_costs): Check for size
1563 calculation overflow.
1564 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1565 table lengths and related sizes. Don't update size until alloc
1566 done. Redo calculations to avoid overflow.
1567 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1569 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1570 subtracting pointers.
1571 (gobble_line): Check for overflow more carefully. Don't update size
1574 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1575 Don't update size until alloc done.
1576 Redo size calculations to avoid overflow.
1577 Check for size calculation overflow.
1578 (main) [DEBUG]: Fix typo in invoking tparam1.
1580 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1581 Use ptrdiff_t, not int, for sizes.
1582 (store_mode_line_noprop_char): Don't update size until alloc done.
1584 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1585 Use ptrdiff_t, not int, for sizes.
1586 (Finternal_make_lisp_face, cache_face):
1587 Check for size calculation overflow.
1588 (cache_face): Treat size calculation overflows as if they were
1589 memory exhaustion (the usual treatment), rather than aborting.
1591 * xfns.c (x_encode_text, x_set_name_internal)
1592 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1593 sizes, since they can exceed INT_MAX in size. Check for size
1594 calculation overflow.
1596 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1597 (xg_select): Check for size calculation overflow.
1598 Don't update size until alloc done.
1600 * xrdb.c (get_environ_db): Don't assume path length fits in int,
1601 as sprintf is limited to int lengths.
1603 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1604 (X_LONG_MIN): New macros.
1605 Use them to make the following changes clearer.
1606 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1607 This change doesn't affect the value now, but it may help remind
1608 future maintainers not to raise the value too much later.
1609 (SELECTION_QUANTUM): Remove, replacing with ...
1610 (selection_quantum): ... new function, which avoids overflow.
1612 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1613 assumption that selection length fits in 'int'.
1614 (x_reply_selection_request, x_handle_selection_request)
1615 (x_get_window_property, receive_incremental_selection)
1616 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1617 (lisp_data_to_selection_data, clean_local_selection_data):
1618 Use ptrdiff_t, not int, to record length of selection.
1619 (x_reply_selection_request, x_get_window_property)
1620 (receive_incremental_selection, x_property_data_to_lisp):
1621 Redo calculations to avoid overflow.
1622 (x_reply_selection_request): When sending hint, ceiling it at
1623 X_LONG_MAX rather than relying on wraparound overflow to send
1625 (x_get_window_property, receive_incremental_selection)
1626 (lisp_data_to_selection_data, x_property_data_to_lisp):
1627 Check for size-calculation overflow.
1628 (x_get_window_property, receive_incremental_selection)
1629 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1630 Don't store size until memory allocation succeeds.
1631 (x_get_window_property): Plug memory leak on memory exhaustion.
1632 Don't double-block input; malloc is safe here. Don't assume 2**34
1633 - 4 fits in unsigned long. Add an xassert to check
1634 XGetWindowProperty overflow. Be more careful about overflow
1635 calculations, and distinguish size from memory overflow better.
1636 (receive_incremental_selection): When tracing, don't assume
1637 unsigned int is less than INT_MAX.
1638 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1639 harmful) conversions of unsigned short to int.
1640 (lisp_data_to_selection_data): Don't assume that integers
1641 in the range -65535 through -1 fit in an X unsigned short.
1642 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1643 result parameters unless successful. Rely on cons_to_unsigned
1644 to report problems with elements; the old code wasn't right anyway.
1645 (x_check_property_data): Check for int overflow; we cannot use
1646 a wider type due to X limits.
1647 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1649 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
1651 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1652 (x_term_init): Check for size calculation overflow.
1653 (x_color_cells): Don't store size until memory allocation succeeds.
1654 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
1655 Don't assume alloca size is less than MAX_ALLOCA.
1656 (x_term_init): Don't assume length fits in int (sprintf is limited
1659 Use ptrdiff_t for composition IDs.
1660 * character.c (lisp_string_width):
1661 * composite.c (composition_table_size, n_compositions)
1662 (get_composition_id, composition_gstring_from_id):
1663 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1664 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1665 * window.c (Frecenter):
1666 Use ptrdiff_t, not int, for composition IDs.
1667 * composite.c (get_composition_id): Check for integer overflow.
1668 * composite.h: Adjust prototypes to match the above changes.
1670 Use ptrdiff_t for hash table indexes.
1671 * category.c (hash_get_category_set):
1672 * ccl.c (ccl_driver):
1673 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1674 * coding.c (coding_system_charset_list, detect_coding_system):
1675 * coding.h (struct coding_system.id):
1676 * composite.c (get_composition_id, gstring_lookup_cache):
1677 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1678 * image.c (xpm_get_color_table_h):
1679 * lisp.h (hash_lookup, hash_put):
1680 * minibuf.c (Ftest_completion):
1681 Use ptrdiff_t for hash table indexes, not int (which is too
1682 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1683 32-bit --with-wide-int hosts).
1685 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1686 Add a FIXME comment about memory leaks.
1687 (syms_of_charset): Don't assume xmalloc returns.
1689 Don't assume that stated character widths fit in int.
1690 * character.c (Fchar_width, c_string_width, lisp_string_width):
1691 * character.h (CHAR_WIDTH):
1692 * indent.c (MULTIBYTE_BYTES_WIDTH):
1693 Use sanitize_char_width to avoid undefined and/or bad behavior
1694 with outlandish widths.
1695 * character.h (sanitize_tab_width): Rename from sanitize_width,
1696 now that we have two such functions. All uses changed.
1697 (sanitize_char_width): New inline function.
1699 Don't assume that tab-width fits in int.
1700 * character.h (sanitize_width): New inline function.
1701 (SANE_TAB_WIDTH): New macro.
1702 (ASCII_CHAR_WIDTH): Use it.
1703 * indent.c (sane_tab_width): Remove. All uses replaced by
1704 SANE_TAB_WIDTH (current_buffer).
1705 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1707 * fileio.c: Integer overflow issues with file modes.
1708 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1710 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1711 Remove unreachable code.
1712 (read_hex, load_charset_map_from_file): Check for integer overflow.
1714 * xterm.c: don't go over XClientMessageEvent limit
1715 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1716 (x_send_scroll_bar_event): Likewise. Check that the size does not
1717 exceed limits imposed by XClientMessageEvent, as well as the usual
1718 ptrdiff_t and size_t limits.
1720 * keyboard.c: Overflow, signedness and related fixes.
1721 (make_lispy_movement): Use same integer type in forward decl
1722 that is used in the definition.
1723 (read_key_sequence, keyremap_step):
1724 Change bufsize argument back to int, undoing my 2011-03-30 change.
1725 We prefer signed types, and int is wide enough here.
1726 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1727 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1728 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1729 length, not size_t. Use ptrdiff_t for index, not int.
1730 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1731 possibility of integer overflow.
1733 Overflow, signedness and related fixes for images.
1735 * dispextern.h (struct it.stack[0].u.image.image_id)
1736 (struct_it.image_id, struct image.id, struct image_cache.size)
1737 (struct image_cache.used, struct image_cache.ref_count):
1738 * gtkutil.c (update_frame_tool_bar):
1739 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1740 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1741 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1742 * nsmenu.m (update_frame_tool_bar):
1743 * xdisp.c (calc_pixel_width_or_height):
1744 * xfns.c (image_cache_refcount):
1745 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1746 on typical 64-bit hosts.
1748 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1749 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1750 Omit unnecessary casts to int.
1751 (parse_image_spec): Check that integers fall into 'int' range
1752 when the callers expect that.
1753 (image_ascent): Redo ascent calculation to avoid int overflow.
1754 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1755 (lookup_image): Remove unnecessary tests.
1756 (xbm_image_p): Locals are now of int, not EMACS_INT,
1757 since parse_image_check makes sure they fit into int.
1758 (png_load, gif_load, svg_load_image):
1759 Prefer int to unsigned where either will do.
1760 (tiff_handler): New function, combining the cores of the
1761 old tiff_error_handler and tiff_warning_handler.
1762 This function is rewritten to use vsnprintf and thereby avoid
1763 stack buffer overflows. It uses only the features of vsnprintf
1764 that are common to both POSIX and native Microsoft.
1765 (tiff_error_handler, tiff_warning_handler): Use it.
1766 (tiff_load, gif_load, imagemagick_load_image):
1767 Don't assume :index value fits in 'int'.
1768 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1769 (imagemagick_load_image): Check that crop parameters fit into
1770 the integer types that MagickCropImage accepts. Don't assume
1771 Vimagemagick_render_type has a nonnegative value. Don't assume
1772 size_t fits in 'long'.
1773 (gs_load): Use printmax_t to print the widest integers possible.
1774 Check for integer overflow when computing image height and width.
1776 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1778 * xdisp.c (redisplay_window): Don't force window start if point
1779 will be invisible in the resulting window. (Bug#9324)
1781 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1783 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1784 the display spec is of the form `(space ...)'.
1785 (handle_display_spec): Return the value returned by
1786 handle_single_display_spec, not just 1 or zero.
1787 (handle_single_display_spec): If the display spec is of the form
1788 `(space ...)', and specifies display in the text area, return 2
1790 (try_cursor_movement): Check for the need to scroll more
1791 accurately, and prefer exact match for point under bidi.
1792 Don't advance `row' beyond the last row of the window.
1794 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1795 into disp_prop; all users changed.
1797 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1798 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1799 for the text covered by the display property.
1801 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1803 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1804 Change return value to nil.
1805 (Frecord_buffer): Delete unused function.
1807 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1809 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1810 buffers, return left-to-right.
1811 (set_cursor_from_row): Consider candidate row a win if its glyph
1812 represents a newline and point is on that newline. Fixes cursor
1813 positioning on the newline at EOL of R2L text within L2R
1814 paragraph, and vice versa.
1815 (try_cursor_movement): Check continued rows, in addition to
1816 continuation rows. Fixes unwarranted scroll when point enters a
1817 continued line of R2L text within an L2R paragraph, or vice versa.
1818 (cursor_row_p): Consider the case of point being equal to
1819 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1820 from the end of a short line to the beginning of a continued line
1821 of R2L text within L2R paragraph.
1822 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1823 composed characters.
1825 * bidi.c (bidi_check_type): Use xassert.
1826 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1829 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1831 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1834 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1836 * nsfont.m (ns_otf_to_script): Fix typo.
1838 2011-08-22 Kenichi Handa <handa@m17n.org>
1840 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1841 extra slot even if the purpose is char-code-property-table.
1843 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1845 * xdisp.c (redisplay_window): When computing centering_position,
1846 account for the height of the header line. (Bug#8874)
1848 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1849 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1850 candidate is selected by the mouse, and that candidate has a
1851 composed character under the mouse.
1853 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1854 coordinates reported by pos-visible-in-window-p for a composed
1855 character in column zero.
1857 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1859 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1861 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1863 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1864 consider it a hit if to_charpos is anywhere in the range of the
1865 composed buffer positions.
1867 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1869 * image.c (gif_load): Don't assume that each subimage has the same
1870 dimensions as the base image. Handle disposal method that is
1871 "undefined" by the gif spec (Bug#9335).
1873 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1875 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1876 (Fcondition_case): Document `debug' symbol in error handler.
1878 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1880 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1881 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1882 from an Org mode buffer to a Speedbar frame.
1884 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1885 a composition, take its buffer position from IT->cmp_it.charpos.
1886 Fixes cursor positioning at the beginning of a line that begins
1887 with a composed character.
1889 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1891 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1892 character bidirectional type, use STRONG_L instead. Fixes crashes
1893 in a buffer produced by `describe-categories'.
1895 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1896 members before the level stack, so they would be saved and
1897 restored when copying iterator state. Fixes incorrect reordering
1898 around TABs covered by display properties.
1900 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1902 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
1904 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1906 * eval.c (internal_condition_case, internal_condition_case_1)
1907 (internal_condition_case_2, internal_condition_case_n):
1908 Remove unnecessary aborts (Bug#9081).
1910 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1912 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1913 has no `load' handler, try opening the file locally. (Bug#9311)
1915 2011-08-16 Ken Brown <kbrown@cornell.edu>
1917 * gmalloc.c: Expand comment.
1919 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1921 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1922 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1924 2011-08-16 Ken Brown <kbrown@cornell.edu>
1926 Fix memory allocation problems in Cygwin build (Bug#9273).
1928 * unexcw.c ( __malloc_initialized): Declare external variable.
1929 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1931 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1933 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1935 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1937 [CYGWIN] (special_realloc): New function.
1938 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1939 requests to realloc storage in the static heap.
1941 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1943 * bidi.c (bidi_initialize): Remove unused local.
1945 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1948 * biditype.h: Remove file.
1949 * makefile.w32-in ($(BLD)/bidi.$(O)):
1950 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
1952 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1954 * chartab.c: Improve commentary for the uniprop_table API.
1956 * bidi.c (bidi_paragraph_init): Support zero value of
1957 bidi_ignore_explicit_marks_for_paragraph_level.
1958 (bidi_initialize): Use uniprop_table instead of including
1959 biditype.h and bidimirror.h.
1961 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1962 coordinates of the iterator when restoring from ppos_it.
1965 2011-08-14 Kenichi Handa <handa@m17n.org>
1967 * process.c (create_process): Call setup_process_coding_systems
1968 after the pid of the process is set to -1 (Bug#8162).
1970 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1972 * xdisp.c (move_it_in_display_line_to): Don't invoke
1973 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1974 ppos_it. Fixes vertical cursor motion when line beginning is
1975 covered by an image. (Bug#9296)
1977 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1979 * nsterm.h (ns_run_ascript): Declare.
1980 (NSAPP_DATA2_RUNASSCRIPT): Define.
1982 * nsfns.m (as_script, as_result, as_status): New static variables.
1983 (ns_run_ascript): New function.
1984 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1985 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1986 the event loop. Get status from as_status (Bug#7276).
1988 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1989 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1990 the event loop (Bug#7276).
1992 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1994 * gnutls.c (QCgnutls_bootprop_priority)
1995 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1996 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1997 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1998 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1999 (QCgnutls_bootprop_verify_hostname_error)
2000 (QCgnutls_bootprop_callbacks_verify): Rename from
2001 Qgnutls_bootprop_..., all uses changed.
2003 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2006 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2008 * xfaces.c (Qframe_set_background_mode): Now static.
2009 * dispextern.h (Qframe_set_background_mode): Remove decl.
2011 * process.c (Fnetwork_interface_info): Declare local only if needed.
2013 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2015 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2016 (Fnetwork_interface_list): Allocate in increments of bytes instead
2017 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2018 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2020 (struct ifflag_def): notrailers is smart on OSX.
2021 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2022 Get hardware address with getifaddrs if available.
2024 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2026 * xdisp.c (iterate_out_of_display_property): xassert that
2027 IT->position is set to within IT->object's boundaries. Break from
2028 the loop as soon as EOB is reached; avoids infloops in redisplay
2029 when IT->position is set up wrongly due to some bug.
2030 Set IT->current to match the bidi iterator unconditionally.
2031 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2032 entry. Force push_it to save on the stack the current
2033 buffer/string position, to be restored by pop_it. Fix flags in
2034 the iterator structure wrt the object coming from a display
2035 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2036 properties. (Bug#9284)
2038 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2040 * fontset.c (fontset_get_font_group): Add proper type checks.
2043 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2045 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2046 and LC_VERSION_MIN_MACOSX.
2047 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2048 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2050 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2052 * xdisp.c (forward_to_next_line_start): Allow to use the
2053 no-display-properties-and-no-overlays under bidi display.
2054 Set disp_pos in the bidi iterator to avoid searches for display
2055 properties and overlays.
2057 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2059 * editfns.c (Fset_time_zone_rule): Document relationship with the
2062 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2063 the font entity extracted from the cache (Bug#8109).
2065 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2067 * composite.c (autocmp_chars): Don't reset point. That is done by
2068 restore_point_unwind (Bug#5984).
2070 2011-08-07 Juri Linkov <juri@jurta.org>
2072 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2073 to show the arg `TIME' instead of `TIMEVAL'.
2075 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2077 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2078 display property strides EOL and includes a newline, as in
2079 longlines-mode. (Bug#9254)
2080 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2081 word-wrap under bidirectional display. (Bug#9224)
2083 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2084 is non-zero, even if the data buffer is NULL. Fixes a crash in
2085 vertical-motion with longlines-mode. (Bug#9254)
2087 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2089 * bidi.c <bidi_cache_total_alloc>: Now static.
2090 (bidi_initialize): Initialize bidi_cache_total_alloc.
2092 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2095 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2096 amount allocated this far in `bidi_cache_total_alloc'.
2097 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2098 non-zero, only free the data buffer without restoring the cache
2099 contents. All callers changed.
2101 * dispextern.h (bidi_unshelve_cache): Update prototype.
2103 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2104 (move_it_in_display_line, move_it_to)
2105 (move_it_vertically_backward, move_it_by_lines): Replace the call
2106 to xfree to an equivalent call to bidi_unshelve_cache.
2107 (move_it_in_display_line_to): Fix logic of returning
2108 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2110 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2112 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2113 came from a string character with a `cursor' property. (Bug#9229)
2115 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2117 * Makefile.in (LIB_PTHREAD): New variable.
2118 (LIBES): Add LIB_PTHREAD (Bug#9216).
2120 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2121 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2123 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2125 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2127 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2129 * xterm.c (x_find_topmost_parent): New function.
2130 (x_set_frame_alpha): Find topmost parent window with
2131 x_find_topmost_parent and set the property there also (bug#9181).
2132 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2134 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2136 * callproc.c (Fcall_process): Avoid vfork clobbering
2137 the local vars buffer, coding_systems, current_dir.
2139 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2141 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2143 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2145 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2146 so that it is not optimized away.
2148 * xdisp.c (compute_display_string_pos): Remove unused local.
2150 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2152 Fix slow cursor motion and scrolling in large buffers with
2153 selective display, like Org Mode buffers. (Bug#9218)
2155 * dispextern.h (struct bidi_it): New member disp_prop_p.
2157 * xdisp.c: Remove one-slot cache of display string positions.
2158 (compute_display_string_pos): Accept an additional argument
2159 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2160 for a display string or property. If found, set DISP_PROP_P
2163 * bidi.c (bidi_fetch_char): Accept an additional argument
2164 DISP_PROP_P, and pass it to compute_display_string_pos.
2165 Only handle text covered by a display string if DISP_PROP_P is returned
2166 non-zero. All callers of bidi_fetch_char changed.
2168 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2170 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2172 2010-12-03 Don March <don@ohspite.net>
2174 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2175 last character M-[char] is translated to ESC [char] (bug#7541).
2177 2011-08-02 Kenichi Handa <handa@m17n.org>
2179 * lisp.h (uniprop_table): Extern it.
2181 * chartab.c (uniprop_table): Make it non-static.
2183 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2185 * xdisp.c (forward_to_next_line_start): Accept additional argument
2186 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2188 (reseat_at_next_visible_line_start): Use the bidi iterator state
2189 returned by forward_to_next_line_start to restore the state of
2190 it->bidi_it after backing up to previous newline. (Bug#9212)
2192 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2194 * regex.c (re_comp): Protoize.
2195 (re_exec): Fix return type.
2196 (regexec): Fix type of `ret'. (Bug#9203)
2198 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2200 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2201 This is needed if max-image-size is a floating-point number.
2203 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2205 * print.c (print_object): Print empty symbol as ##.
2207 * lread.c (read1): Read ## as empty symbol.
2209 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2211 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2212 setting frame foreground color (Bug#9175).
2213 (x_set_background_color): Likewise.
2215 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2216 contents (Bug#9176).
2217 (EmacsTooltip -init): Remove bezels and add shadows to
2220 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2221 or scroll bar (Bug#8470).
2223 * nsfont.m (nsfont_open): Remove assignment to voffset and
2224 unnecessary vars hshink, expand, hd, full_height, min_height.
2225 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2227 * nsterm.h (nsfont_info): Remove voffset field.
2229 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2231 Implement strike-through and overline on NextStep (Bug#8863).
2233 * nsfont.m (nsfont_open): Use underline position provided by font,
2234 instead of hard-coded value of 2.
2235 (nsfont_draw): Call ns_draw_text_decoration instead.
2237 * nsterm.h: Add declaration for ns_draw_text_decoration.
2239 * nsterm.m (ns_draw_text_decoration): New function for drawing
2240 underline, overline, and strike-through.
2241 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2242 ns_draw_text_decoration. Change treatment of cursor drawing to
2243 accommodate underlining, etc.
2245 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2247 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2250 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2252 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2253 Without this fix, if a signal arrives just after memory fills up,
2254 'malloc' might be invoked reentrantly.
2256 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2257 In other words, assume that every image size is allowed, on non-X
2258 hosts. This assumption is probably wrong, but it lets Emacs compile.
2260 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2262 * regex.c (re_iswctype): Convert return values to boolean.
2264 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2266 * xdisp.c (compute_display_string_pos): Don't use cached display
2267 string position if the buffer had its restriction changed.
2270 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2272 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2274 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2276 Integer signedness and overflow and related fixes. (Bug#9079)
2278 * bidi.c: Integer size and overflow fixes.
2279 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2280 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2281 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2282 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2283 (bidi_find_other_level_edge):
2284 Use ptrdiff_t instead of EMACS_INT where either will do.
2285 This works better on 32-bit hosts configured --with-wide-int.
2286 (bidi_cache_ensure_space): Check for size-calculation overflow.
2287 Use % rather than repeated addition, for better worst-case speed.
2288 Don't set bidi_cache_size until after xrealloc returns, because it
2290 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2291 (bidi_cache_ensure_space): Also check that the bidi cache size
2292 does not exceed that of the largest Lisp string or buffer. See Eli
2293 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2295 * alloc.c (__malloc_size_t): Remove.
2296 All uses replaced by size_t. See Andreas Schwab's note
2297 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2299 * image.c: Improve checking for integer overflow.
2300 (check_image_size): Assume that f is nonnull, since
2301 it is always nonnull in practice. This is one less thing to
2302 worry about when checking for integer overflow later.
2303 (x_check_image_size): New function, which checks for integer
2304 overflow issues inside X.
2305 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2306 This removes the need for a memory_full check.
2307 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2308 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2309 (xbm_read_bitmap_data): Change locals back to 'int', since
2310 their values must fit in 'int'.
2311 (xpm_load_image, png_load, tiff_load):
2312 Invoke x_create_x_image_and_pixmap earlier,
2313 to avoid much needless work if the image is too large.
2314 (tiff_load): Treat overly large images as if
2315 x_create_x_image_and_pixmap failed, not as malloc failures.
2316 (gs_load): Use x_check_image_size.
2318 * gtkutil.c: Omit integer casts.
2319 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2320 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2322 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2324 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2325 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2326 would wrongly return t on a 64-bit host.
2328 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2329 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2330 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2331 and therefore cause GCC to emit a bogus diagnostic in some cases.
2333 * image.c: Integer signedness and overflow and related fixes.
2334 This is not an exhaustive set of fixes, but it's time to
2335 record what I've got.
2336 (lookup_pixel_color, check_image_size): Remove redundant decls.
2337 (check_image_size): Don't assume that arbitrary EMACS_INT values
2338 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2339 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2340 (tiff_load, imagemagick_load_image):
2341 Check for overflow in size calculations.
2342 (x_create_x_image_and_pixmap): Remove unnecessary test for
2343 xmalloc returning NULL; that can't happen.
2344 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2345 (xpm_color_bucket): Use better integer hashing function.
2346 (xpm_cache_color): Don't possibly over-allocate memory.
2347 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2348 (gif_memory_source):
2349 Use ptrdiff_t, not int or size_t, to record sizes.
2350 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2351 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2352 either works, as we prefer signed integers.
2353 (tiff_read_from_memory, tiff_write_from_memory):
2354 Return tsize_t, not size_t, since that's what the TIFF API wants.
2355 (tiff_read_from_memory): Don't fail simply because the read would
2356 go past EOF; instead, return a short read.
2357 (tiff_load): Omit no-longer-needed casts.
2358 (Fimagemagick_types): Don't assume size fits into 'int'.
2360 Improve hashing quality when configured --with-wide-int.
2361 * fns.c (hash_string): New function, taken from sxhash_string.
2362 Do not discard information about ASCII character case; this
2363 discarding is no longer needed.
2364 (sxhash-string): Use it. Change sig to match it. Caller changed.
2365 * lisp.h: Declare it.
2366 * lread.c (hash_string): Remove, since we now use fns.c's version.
2367 The fns.c version returns a wider integer if --with-wide-int is
2368 specified, so this should help the quality of the hashing a bit.
2370 * emacs.c: Integer overflow minor fix.
2371 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2372 Define only if GNU_LINUX.
2373 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2375 * dispnew.c: Integer signedness and overflow fixes.
2376 Remove unnecessary forward decls, that were a maintenance hassle.
2377 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2379 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2380 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2381 (prepare_desired_row, line_draw_cost):
2382 Use int, not unsigned, where either works.
2383 (save_current_matrix, restore_current_matrix):
2384 Use ptrdiff_t, not size_t, where either works.
2385 (init_display): Check for overflow more accurately, and without
2386 relying on undefined behavior.
2388 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2389 Remove, replacing with the new symbols in lisp.h. All uses changed.
2390 * fileio.c (make_temp_name):
2391 * filelock.c (lock_file_1, lock_file):
2392 * xdisp.c (message_dolog):
2393 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2394 Use pMd etc. instead.
2395 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2396 replacing the pWIDE etc. symbols removed from editfns.c.
2398 * keyboard.h (num_input_events): Now uintmax_t.
2399 This is (very slightly) less likely to mess up due to wraparound.
2402 * buffer.c: Integer signedness fixes.
2403 (alloc_buffer_text, enlarge_buffer_text):
2404 Use ptrdiff_t rather than size_t when either will do, as we prefer
2407 * alloc.c: Integer signedness and overflow fixes.
2408 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2409 (__malloc_size_t): Default to size_t, not to int.
2410 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2411 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2412 Prefer ptrdiff_t to size_t when either would do, as we prefer
2414 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2415 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2416 Now const. Initialize with values that are in range even if char
2418 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2419 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2420 These functions do the right thing with sizes > 2**32.
2421 (check_depth): Now ptrdiff_t, not int.
2422 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2423 Adjust to new way of storing sizes. Check for size overflow bugs
2425 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2426 slightly wrong anyway, as it missed one instance of
2427 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2428 (refill_memory_reserve): Omit needless cast to size_t.
2429 (mark_object_loop_halt): Mark as externally visible.
2431 * xselect.c: Integer signedness and overflow fixes.
2432 (Fx_register_dnd_atom, x_handle_dnd_message):
2433 Use ptrdiff_t, not size_t, since we prefer signed.
2434 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2435 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2436 x_dnd_atoms_size and x_dnd_atoms_length.
2438 * doprnt.c: Prefer signed to unsigned when either works.
2440 * doprnt.c (doprnt):
2442 * xdisp.c (vmessage):
2443 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2444 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2445 prefer signed arithmetic to avoid comparison confusion.
2446 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2447 but is a bit tricky.
2449 Assume freestanding C89 headers, string.h, stdlib.h.
2450 * data.c, doprnt.c, floatfns.c, print.c:
2451 Include float.h unconditionally.
2452 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2453 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2454 * regex.c: Likewise for stddef.h, string.h.
2455 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2456 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2457 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2458 (STDC_HEADERS): Remove obsolete defines.
2459 * sysdep.c: Include limits.h unconditionally.
2461 Assume support for memcmp, memcpy, memmove, memset.
2462 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2463 * regex.c (memcmp, memcpy):
2464 Remove; we assume C89 now.
2466 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2467 (__malloc_safe_bcopy): Remove; no longer needed.
2469 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
2470 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2471 well either way, and we prefer signed to unsigned.
2473 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2475 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2476 closes the connection while we're reading (bug#9182).
2478 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
2480 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2481 are specified (Bug#9168).
2483 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2485 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2486 Found by GCC static checking and --with-wide-int on a 32-bit host.
2488 2011-07-25 Eli Zaretskii <eliz@gnu.org>
2490 * xdisp.c (compute_display_string_pos): Fix logic of caching
2491 previous display string position. Initialize cached_prev_pos to
2492 -1. Fixes slow-down at the beginning of a buffer.
2494 2011-07-24 Eli Zaretskii <eliz@gnu.org>
2496 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2497 for attrs[LFACE_FONTSET_INDEX].
2499 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2501 * xml.c (parse_region): Remove unused local
2502 that was recently introduced.
2504 2011-07-23 Eli Zaretskii <eliz@gnu.org>
2506 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2507 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2509 * xdisp.c (move_it_in_display_line_to): Record the best matching
2510 position for TO_CHARPOS while scanning the line, and restore it on
2511 exit if none of the characters scanned was an exact match.
2512 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
2513 when exact match is impossible due to invisible text, and the
2514 lines are truncated.
2516 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2518 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2521 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2523 Fix a significant slow-down of cursor motion with C-n, C-p,
2524 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2525 auto-repeat under bidi redisplay in fontified buffers.
2526 * xdisp.c (compute_stop_pos_backwards): New function.
2527 (next_element_from_buffer): Call compute_stop_pos_backwards to
2528 find a suitable prev_stop when we find ourselves before
2530 (reseat): Don't look for prev_stop, as that could mean a very long
2532 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2533 <cached_disp_overlay_modiff>: Cache for last found display string
2535 (compute_display_string_pos): Return the cached position if asked
2536 about the same buffer in the same area of character positions, and
2537 the buffer wasn't changed since the time the display string
2538 position was cached.
2540 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2542 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2543 is an integer, which is important for empty lines. (Bug#9149)
2545 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
2547 * frame.c (Fmodify_frame_parameters): In tty case, update the
2548 default face if necessary (Bug#4238).
2550 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
2552 * editfns.c (Fstring_to_char): No need to explain what a character
2553 is in the docstring (Bug#6576).
2555 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2557 * xml.c (parse_region): Make sure we always return a tree.
2559 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2561 * xml.c (parse_region): If a document contains only comments,
2564 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2566 * xml.c (make_dom): Return comments, too.
2568 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2571 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2572 and the surrounding thread.
2573 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2574 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2575 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2577 * s/openbsd.h (BROKEN_SIGIO): Define.
2578 * unexelf.c (unexec) [__OpenBSD__]:
2579 Don't update the .mdebug section of the Alpha COFF symbol table.
2581 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2583 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2586 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2588 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2589 This fixes some race conditions on the permissions of any newly
2592 * alloc.c (valid_pointer_p): Use pipe, not open.
2593 This fixes some permissions issues when debugging.
2595 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2596 If fchown fails to set both uid and gid, try to set just gid,
2597 as that is sometimes allowed. Adjust the file's mode to eliminate
2598 setuid or setgid bits that are inappropriate if fchown fails.
2600 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2602 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2603 to compare Lisp_Objects.
2604 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2605 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2606 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2608 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2610 * lread.c (read_integer): Unread even EOF character.
2611 (read1): Likewise. Properly record start position of symbol.
2613 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2614 symbol character follows.
2616 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2618 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2619 This works around a problem with the previous change to Fcopy_file.
2620 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2621 and without this change, GCC might complain about discarding
2622 fchown's return value.
2624 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
2626 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2628 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2630 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2632 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2634 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2635 it's used from the C level.
2637 * process.c: Use the same condition for POLL_FOR_INPUT in both
2638 keyboard.c and process.c (bug#1858).
2640 2011-07-09 Lawrence Mitchell <wence@gmx.li>
2642 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2643 (Fgnutls_boot): Use it.
2645 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2647 * doc.c (Fsubstitute_command_keys): Revert last change.
2649 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2651 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2652 quotes the next character, and doesn't affect other longer
2653 sequences (bug#8935).
2655 * lread.c (syms_of_lread): Clarify that is isn't only
2656 `eval-buffer' and `eval-defun' that's affected by
2657 `lexical-binding' (bug#8460).
2659 2011-07-15 Eli Zaretskii <eliz@gnu.org>
2661 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2662 bidi redisplay when a line includes both an image and is truncated.
2664 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2666 Fix minor problems found by static checking.
2667 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2668 (elsz): Now a signed constant, not a size_t var. We prefer signed
2669 types to unsigned, to avoid integer comparison confusion. Without
2670 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2671 "cannot optimize loop, the loop counter may overflow", a symptom
2673 * indent.c (Fvertical_motion): Mark locals as initialized.
2674 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2676 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2678 * search.c (Fre_search_backward): Mention `case-fold-search' in
2679 all the re_search_* functions (bug#8138).
2681 * keyboard.c (Fopen_dribble_file): Document when the file is
2684 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2686 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2689 Support bidi reordering of display and overlay strings.
2690 * xdisp.c (compute_display_string_pos)
2691 (compute_display_string_end): Accept additional argument STRING.
2692 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2693 (reseat_to_string): Initialize bidi_it->string.s and
2694 bidi_it->string.schars.
2695 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2696 NULL (avoids a crash in bidi_paragraph_init).
2697 Initialize itb.string.lstring.
2698 (init_iterator): Call bidi_init_it only of a valid
2699 buffer position was specified. Initialize paragraph_embedding to
2701 (reseat_to_string): Initialize the bidi iterator.
2702 (display_string): If we need to ignore text properties of
2703 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2704 original value of -1 will not work with bidi.)
2705 (compute_display_string_pos): First arg is now struct
2706 `text_pos *'; all callers changed. Support display properties on
2708 (compute_display_string_end): Support display properties on Lisp
2710 (init_iterator, reseat_1, reseat_to_string): Initialize the
2711 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2712 when iterating on a string not from display properties).
2713 (compute_display_string_pos, compute_display_string_end):
2714 Fix calculation of the object to scan. Fixes an error when using
2716 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2717 base_level_stop; instead, set base_level_stop to BEGV.
2718 Fixes crashes in vertical-motion.
2719 (next_element_from_buffer): Improve commentary for when
2720 the iterator is before prev_stop.
2721 (init_iterator): Initialize bidi_p from the default value of
2722 bidi-display-reordering, not from buffer-local value. Use the
2723 buffer-local value only if initializing for buffer iteration.
2724 (handle_invisible_prop): Support invisible properties on strings
2725 that are being bidi-reordered.
2726 (set_iterator_to_next): Support bidi reordering of C strings and
2728 (next_element_from_string): Support bidi reordering of Lisp
2730 (handle_stop_backwards): Support Lisp strings as well.
2731 (display_string): Support display of R2L glyph rows.
2732 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2733 (init_iterator): Don't initialize it->bidi_p for strings
2735 (reseat_to_string): Initialize it->bidi_p for strings here.
2736 (next_element_from_string, next_element_from_c_string)
2737 (next_element_from_buffer): Add xassert's for correspondence
2738 between IT's object being iterated and it->bidi_it.string
2740 (face_before_or_after_it_pos): Support bidi iteration.
2741 (next_element_from_c_string): Handle the case of the first string
2742 character that is not the first one in the visual order.
2743 (get_visually_first_element): New function, refactored from common
2744 parts of next_element_from_buffer, next_element_from_string, and
2745 next_element_from_c_string.
2746 (tool_bar_lines_needed, redisplay_tool_bar)
2747 (display_menu_bar): Force left-to-right direction. Add a FIXME
2748 comment for making that be controlled by a user option.
2749 (push_it, pop_it): Save and restore the state of the
2750 bidi iterator. Save and restore the bidi_p flag.
2751 (pop_it): Iterate out of display property for string iteration as
2753 (iterate_out_of_display_property): Support iteration over strings.
2754 (handle_single_display_spec): Set up it->bidi_it for iteration
2755 over a display string, and call bidi_init_it.
2756 (handle_single_display_spec, next_overlay_string)
2757 (get_overlay_strings_1, push_display_prop): Set up the bidi
2758 iterator for displaying display or overlay strings.
2759 (forward_to_next_line_start): Don't use the shortcut if
2761 (back_to_previous_visible_line_start): If handle_display_prop
2762 pushed the iterator stack, restore the internal state of the bidi
2763 iterator by calling bidi_pop_it same number of times.
2764 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2765 and we are bidi-iterating, don't decrement the iterator position;
2766 instead, set the first_elt flag in the bidi iterator, to produce
2768 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2769 (push_display_prop): xassert that we are iterating a buffer.
2770 (push_it, pop_it): Save and restore paragraph_embedding member.
2771 (handle_single_display_spec, next_overlay_string)
2772 (get_overlay_strings_1, reseat_1, reseat_to_string)
2773 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2774 correctly. Don't assume unibyte strings are not bidi-reordered.
2775 (compute_display_string_pos)
2776 (compute_display_string_end): Fix handling the case of C string.
2777 (push_it, pop_it): Save and restore from_disp_prop_p.
2778 (handle_single_display_spec, push_display_prop): Set the
2779 from_disp_prop_p flag.
2780 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2781 (pop_it): Call iterate_out_of_display_property only if we are
2782 popping after iteration over a string that came from a display
2783 property. Fix a typo in popping stretch info. Add an assertion
2784 for verifying that the iterator position is in sync with the bidi
2786 (handle_single_display_spec, get_overlay_strings_1)
2787 (push_display_prop): Fix initialization of paragraph direction for
2788 string when that of the parent object is not yet determined.
2789 (reseat_1): Call bidi_init_it to resync the bidi
2790 iterator with IT's position. (Bug#7616)
2791 (find_row_edges): If ROW->start.pos gives position
2792 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2793 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2794 Reset the from_disp_prop_p flag.
2795 (SAVE_IT, RESTORE_IT): New macros.
2796 (pos_visible_p, face_before_or_after_it_pos)
2797 (back_to_previous_visible_line_start)
2798 (move_it_in_display_line_to, move_it_in_display_line)
2799 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2800 (try_scrolling, redisplay_window, display_line): Use them when
2801 saving a temporary copy of the iterator and restoring it back.
2802 (back_to_previous_visible_line_start, reseat_1)
2803 (init_iterator): Empty the bidi cache "stack".
2804 (move_it_in_display_line_to): If iterator ended up at
2805 EOL, but we never saw any buffer positions smaller than
2806 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2807 motion in bidi-reordered lines.
2808 (move_it_in_display_line_to): Record prev_method and prev_pos
2809 immediately before the call to set_iterator_to_next. Fixes cursor
2810 motion in bidi-reordered lines with stretch glyphs and strings
2811 displayed in margins. (Bug#8133) (Bug#8867)
2812 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2814 (pos_visible_p): Support positions in bidi-reordered lines.
2815 Save and restore bidi cache.
2817 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2818 (bidi_paragraph_info): Delete unused struct.
2819 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2820 (bidi_cache_start): New variable.
2821 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2823 (bidi_cache_fetch_state, bidi_cache_search)
2824 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2825 (bidi_cache_find, bidi_peek_at_next_level)
2826 (bidi_level_of_next_char, bidi_find_other_level_edge)
2827 (bidi_move_to_visually_next): Compare cache index with
2828 bidi_cache_start rather than with zero.
2829 (bidi_fetch_char): Accept new argument STRING; all callers
2830 changed. Support iteration over a string. Support strings with
2831 display properties. Support unibyte strings. Fix the type of
2832 `len' according to what STRING_CHAR_AND_LENGTH expects.
2833 (bidi_paragraph_init, bidi_resolve_explicit_1)
2834 (bidi_resolve_explicit, bidi_resolve_weak)
2835 (bidi_level_of_next_char, bidi_move_to_visually_next):
2836 Support iteration over a string.
2837 (bidi_set_sor_type, bidi_resolve_explicit_1)
2838 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2839 can now be zero (for strings); special values 0 and -1 were
2840 changed to -1 and -2, respectively.
2841 (bidi_char_at_pos): New function.
2842 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2843 Call it instead of FETCH_MULTIBYTE_CHAR.
2844 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2845 initialized to valid values.
2846 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2848 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2849 the test for valid cached positions. Fix the logic for looking up
2850 the sentinel state in the cache. GCPRO the Lisp string we are
2852 (bidi_push_it, bidi_pop_it): New functions.
2853 (bidi_initialize): Initialize the bidi cache start stack pointer.
2854 (bidi_cache_ensure_space): New function, refactored from part of
2855 bidi_cache_iterator_state. Don't assume the required size is just
2856 one BIDI_CACHE_CHUNK away.
2857 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2858 (bidi_count_bytes, bidi_char_at_pos): New functions.
2859 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2860 always valid if bidi_cache_idx is valid.
2861 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2862 is valid if it's going to be used.
2863 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2864 (bidi_cache_fetch_state, bidi_cache_search)
2865 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2866 (bidi_cache_iterator_state, bidi_cache_find)
2867 (bidi_find_other_level_edge, bidi_cache_start_stack):
2868 All variables related to cache indices are now EMACS_INT.
2870 * dispextern.h (struct bidi_string_data): New structure.
2871 (struct bidi_it): New member `string'. Make flag members be 1-bit
2872 fields, and put them last in the struct.
2873 (compute_display_string_pos, compute_display_string_end):
2875 (bidi_push_it, bidi_pop_it): Add prototypes.
2876 (struct iterator_stack_entry): New members bidi_p,
2877 paragraph_embedding, and from_disp_prop_p.
2878 (struct it): Member bidi_p is now a bit field 1 bit wide.
2879 (bidi_shelve_cache, bidi_unshelve_cache):
2882 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2883 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2884 and vector-like objects.
2886 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2887 cache around display iteration.
2889 * window.c (Fwindow_end, window_scroll_pixel_based)
2890 (displayed_window_lines, Frecenter): Save and restore the bidi
2891 cache around display iteration.
2893 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2895 * editfns.c (Fdelete_region): Clarify the use of the named
2896 parameters (bug#6788).
2898 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2900 * indent.c (Fvertical_motion): Set and restore w->pointm when
2901 saving and restoring the window's buffer (Bug#9006).
2903 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2905 * editfns.c (Fstring_to_char): Clarify just what is returned
2906 (bug#6576). Text by Eli Zaretskii.
2908 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2910 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2912 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2914 * buffer.c (mmap_find): Fix a typo.
2916 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2918 Fix execution of x selection hooks.
2919 * xselect.c (Qx_lost_selection_functions)
2920 (Qx_sent_selection_functions): New vars.
2921 (syms_of_xselect): DEFSYM them.
2922 (x_handle_selection_request): Pass Qx_sent_selection_functions
2923 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2924 (x_handle_selection_clear,x_clear_frame_selections):
2925 Pass Qx_lost_selection_functions rather than
2926 Vx_lost_selection_functions to Frun_hook_with_args.
2928 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2930 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2931 The old code sometimes used this field without initializing it.
2933 * alloc.c (gc_sweep): Don't read past end of array.
2934 In theory, the old code could also have corrupted Emacs internals,
2935 though it'd be very unlikely.
2937 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2939 * character.c (Fcharacterp): Don't advertise optional ignored
2940 argument. (Bug#4026)
2942 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2944 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2947 * window.c (Fset_window_start): Doc fix (bug#4199).
2948 (Fset_window_hscroll): Ditto.
2950 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2952 Fix minor new problems caught by GCC 4.6.1.
2953 * term.c (init_tty): Remove unused local.
2954 * xsettings.c (store_monospaced_changed): Define this function only
2955 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2958 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2960 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2962 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2964 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2965 are the mini-buffer and the echo area (bug#3320).
2967 * term.c (init_tty): Remove support for supdup, c10 and perq
2968 terminals, which are no longer supported (bug#1482).
2970 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2972 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2974 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2976 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2977 for non-popups (Bug#3642).
2979 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2981 * alloc.c (reset_malloc_hooks): Protoize.
2982 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2983 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2984 * cm.c (losecursor): Likewise.
2985 * data.c (fmod): Likewise.
2986 * dispnew.c (swap_glyphs_in_rows): Likewise.
2987 * emacs.c (memory_warning_signal): Likewise.
2988 * floatfns.c (float_error): Likewise.
2989 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2990 (otf_open, font_otf_capability, generate_otf_features)
2991 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2993 * image.c (pbm_read_file): Likewise.
2994 * indent.c (string_display_width): Likewise.
2995 * intervals.c (check_for_interval, search_for_interval)
2996 (inc_interval_count, count_intervals, root_interval)
2997 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2998 * lread.c (defalias): Likewise.
2999 * ralloc.c (r_alloc_check): Likewise.
3000 * regex.c (set_image_of_range_1, set_image_of_range)
3001 (regex_grow_registers): Likewise.
3002 * sysdep.c (strerror): Likewise.
3003 * termcap.c (valid_filename_p, tprint, main): Likewise.
3004 * tparam.c (main): Likewise.
3005 * unexhp9k800.c (run_time_remap, save_data_space)
3006 (update_file_ptrs, read_header, write_header, calculate_checksum)
3007 (copy_file, copy_rest, display_header): Likewise.
3008 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3010 * xdisp.c (check_it): Likewise.
3011 * xfaces.c (register_color, unregister_color, unregister_colors):
3013 * xfns.c (print_fontset_result): Likewise.
3014 * xrdb.c (member, fatal, main): Likewise.
3016 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3018 Fix minor problems found by static checking (Bug#9031).
3019 * chartab.c (char_table_set_range, map_sub_char_table):
3020 Remove unused locals.
3021 (uniprop_table): Now static.
3022 * composite.c (_work_char): Remove unused static var.
3024 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3026 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3028 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3030 * gtkutil.c (qttip_cb): Remove code without function.
3032 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3034 * w32.c (pthread_sigmask): New stub.
3036 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3038 Use pthread_sigmask, not sigprocmask (Bug#9010).
3039 sigprocmask is portable only for single-threaded applications, and
3040 Emacs can be multi-threaded when it uses GTK.
3041 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3043 * callproc.c (Fcall_process):
3044 * process.c (create_process):
3045 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3046 Use pthread_sigmask, not sigprocmask.
3048 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3050 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3051 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3054 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3056 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3057 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3058 (xg_hide_tooltip): Fix comment.
3060 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3061 in registerServicesMenuSendTypes.
3062 (validRequestorForSendType): Don't check ns_return_types.
3064 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3067 2011-07-08 Jason Rumney <jasonr@gnu.org>
3069 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3070 SH_SHOW for hidden windows (Bug#5482).
3072 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3073 frame struct members of non-existent frames (Bug#6284).
3075 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3077 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3078 variable firstTime not needed on OSX >= 10.6.
3079 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3080 >= 10.5. Use setKnobProportion, setDoubleValue.
3082 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3083 (MAC_OS_X_VERSION_10_5): Define if not defined.
3084 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3085 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3086 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3088 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3089 cString and lossyCString on OSX >= 10.4
3091 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3092 sizeToFit on OSX >= 10.2.
3094 * nsimage.m (allocInitFromFile): Don't use deprecated method
3095 bestRepresentationForDevice on OSX >= 10.6.
3097 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3100 * emacs.c: Declare unexec_init_emacs_zone.
3102 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3104 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3106 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3107 on svcsMenu (Bug#8842).
3109 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3111 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3113 * nsterm.m (QUTF8_STRING): Declare.
3114 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3115 (validRequestorForSendType): Return type is (id).
3116 Change indexOfObjectIdenticalTo to indexOfObject.
3117 Check if we have local selection before returning self (Bug#8842).
3118 (writeSelectionToPasteboard): Put local selection into paste board
3119 if we have a local selection (Bug#8842).
3120 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3122 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3123 (ns_get_local_selection): Declare.
3125 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3127 * keymap.c (describe_map_tree): Don't insert a double newline at
3128 the end of the buffer (bug#1169) and return whether we inserted
3131 * callint.c (Fcall_interactively): Change "reading args" to
3132 "providing args" to try to clarify what it does (bug#1010).
3134 2011-07-07 Kenichi Handa <handa@m17n.org>
3136 * composite.c (composition_compute_stop_pos): Ignore a static
3137 composition starting before CHARPOS (Bug#8915).
3139 * xdisp.c (handle_composition_prop): Likewise.
3141 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3143 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3146 2011-07-07 Kenichi Handa <handa@m17n.org>
3148 * character.h (unicode_category_t): New enum type.
3150 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3151 (Qchar_code_property_table): New variable.
3152 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3153 (UNIPROP_COMPRESSED_FORM_P): New macros.
3154 (char_table_ascii): Uncompress the compressed values.
3155 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3156 Uncompress the compressed values.
3157 (sub_char_table_ref_and_range): Likewise.
3158 (char_table_ref_and_range): Uncompress the compressed values.
3159 (sub_char_table_set): New arg is_uniprop. Callers changed.
3160 Uncompress the compressed values.
3161 (sub_char_table_set_range): Args changed. Callers changed.
3162 (char_table_set_range): Adjuted for the above change.
3163 (map_sub_char_table): Delete args default_val and parent. Add arg
3164 top. Give decoded values to a Lisp function.
3165 (map_char_table): Adjust for the above change. Give decoded
3166 values to a Lisp function. Gcpro more variables.
3167 (uniprop_table_uncompress)
3168 (uniprop_decode_value_run_length): New functions.
3169 (uniprop_decoder, uniprop_decoder_count): New variables.
3170 (uniprop_get_decoder, uniprop_encode_value_character)
3171 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3173 (uniprop_encoder, uniprop_encoder_count): New variables.
3174 (uniprop_get_encoder, uniprop_table)
3175 (Funicode_property_table_internal, Fget_unicode_property_internal)
3176 (Fput_unicode_property_internal): New functions.
3177 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3178 Sunicode_property_table_internal, Sget_unicode_property_internal,
3179 and Sput_unicode_property_internal. Defvar_lisp
3180 char-code-property-alist.
3182 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3183 Vunicode_category_table.
3185 * font.c (font_range): Adjust for the change of
3186 Vunicode_category_table.
3188 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3190 * m/iris4d.h: Remove file, move contents ...
3191 * s/irix6-5.h: ... here.
3193 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3195 Remove unportable assumption about struct layout (Bug#8884).
3196 * alloc.c (mark_buffer):
3197 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3198 (clone_per_buffer_values): Don't assume that
3199 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3200 This isn't true in general, and it's particularly not true
3201 if Emacs is configured with --with-wide-int.
3202 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3203 New macros, used in the buffer.c change.
3205 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3207 * xsettings.c: Use both GConf and GSettings if both are available.
3208 (store_config_changed_event): Add comment.
3209 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3210 (store_tool_bar_style_changed): New functions.
3211 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3212 (struct xsettings): Move font inside HAVE_XFT.
3213 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3214 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3215 Move inside HAVE_XFT.
3216 (something_changed_gsettingsCB): Rename from something_changedCB.
3217 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3219 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3220 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3221 (something_changed_gconfCB): Rename from something_changedCB.
3222 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3223 (parse_settings): Move check for font inside HAVE_XFT.
3224 (read_settings, apply_xft_settings): Add comment.
3225 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3226 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3227 call store_font_name_changed.
3228 (xft_settings_event): Add comment.
3229 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3230 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3231 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3232 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3233 (xsettings_initialize): Call init_gsettings last.
3234 (xsettings_get_system_font, xsettings_get_system_normal_font):
3237 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3239 Random fixes. E.g., (random) never returned negative values.
3240 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3241 subseconds part to the entropy, as that's a bit more random.
3242 Prefer signed to unsigned, since the signedness doesn't matter and
3243 in general we prefer signed. When given a limit, use a
3244 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3245 latter isn't right if USE_2_TAGS_FOR_INTS.
3246 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3247 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3249 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3251 * textprop.c (text_property_stickiness):
3252 Obey Vtext_property_default_nonsticky.
3253 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3254 * w32fns.c (syms_of_w32fns):
3255 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3257 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3259 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3260 This is more efficient than Ffile_directory_p and avoids a minor race.
3262 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3264 * buffer.c (Foverlay_put): Say what the return value is
3267 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3268 is a directory before asking whether to use the file name
3270 (barf_or_query_if_file_exists): Make the "File is a directory"
3271 error be more correct.
3273 * fns.c (Frequire): Remove the mention of the .gz files, since
3274 that's installation-specific, but keep the mention of
3275 `get-load-suffixes'.
3277 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3279 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3280 Report string overflow if the output is too long.
3282 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3284 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3285 (syms_of_gnutls): Remove duplicate DEFSYM for
3286 Qgnutls_bootprop_verify_hostname_error, an error for
3287 Qgnutls_bootprop_verify_error (which is no longer used).
3289 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3290 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3291 Also (re)move comments that are misplaced or no longer relevant.
3293 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3295 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3297 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3299 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3300 and background color parameters if they have been changed.
3302 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3304 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3306 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3308 * xsettings.c (SYSTEM_FONT): Define only when used.
3309 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3311 * keymap.c (access_keymap_1): Now static.
3313 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3315 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3316 leave any prefix arg for the up event (Bug#1586).
3318 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3320 * lread.c (syms_of_lread): Mention single symbols defined by
3321 `defvar' or `defconst' (bug#7154).
3323 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3324 (Frequire): Mention get-load-suffixes.
3326 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3328 * window.h (window): Remove clone_number slot.
3329 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3331 (make_parent_window, make_window, saved_window)
3332 (Fset_window_configuration, save_window_save): Don't deal with
3334 * buffer.c (Qclone_number): Remove declaration.
3335 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3337 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3339 Add multiple inheritance to keymaps.
3340 * keymap.c (Fmake_composed_keymap): New function.
3341 (Fset_keymap_parent): Simplify.
3342 (fix_submap_inheritance): Remove.
3343 (access_keymap_1): New function extracted from access_keymap to handle
3344 embedded parents and handle lists of maps.
3345 (access_keymap): Use it.
3346 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3347 (Fcopy_keymap): Handle embedded parents.
3348 (Fcommand_remapping, define_as_prefix): Simplify.
3349 (Fkey_binding): Simplify.
3350 (syms_of_keymap): Move minibuffer-local-completion-map,
3351 minibuffer-local-filename-completion-map,
3352 minibuffer-local-must-match-map, and
3353 minibuffer-local-filename-must-match-map to Elisp.
3354 (syms_of_keymap): Defsubr make-composed-keymap.
3355 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3356 (parse_menu_item): Trivial simplification.
3358 2011-07-01 Glenn Morris <rgm@gnu.org>
3360 * Makefile.in (SETTINGS_LIBS): Fix typo.
3362 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3364 * coding.c (Fencode_coding_string): Record the last coding system
3365 used, as the function doc string says (bug#8738).
3367 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3369 * xsettings.c (store_monospaced_changed): Take new font as arg and
3370 check for change against current_mono_font.
3371 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3372 (emacs_settings_constructor, emacs_settings_get_property)
3373 (emacs_settings_set_property, emacs_settings_class_init)
3374 (emacs_settings_init, gsettings_obj): Remove.
3375 (something_changedCB): New function for HAVE_GSETTINGS.
3376 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3377 with value as argument.
3378 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3379 g_settings_new (Bug#8967). Do not create gsettings_obj.
3380 Remove calls to g_settings_bind. Connect something_changedCB to
3383 * xgselect.c: Add defined (HAVE_GSETTINGS).
3384 (xgselect_initialize): Ditto.
3386 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3387 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3390 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3392 * eval.c (struct backtrace): Simplify and port the data structure.
3393 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3394 signed bit field, as this assumption is not portable and it makes
3395 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3396 "char debug_on_exit : 1" as this is not portable either; instead,
3397 use the portable "unsigned int debug_on_exit : 1". Remove unused
3398 member evalargs. Remove obsolete comments about cc bombing out.
3400 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3402 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3403 Let HAVE_GSETTINGS override HAVE_GCONF.
3404 (store_monospaced_changed): New function.
3405 (EMACS_SETTINGS): A new type derived from GObject to handle
3406 GSettings notifications.
3407 (emacs_settings_constructor, emacs_settings_get_property)
3408 (emacs_settings_set_property, emacs_settings_class_init):
3410 (gsettings_client, gsettings_obj): New variables.
3411 (GSETTINGS_SCHEMA): New define.
3412 (something_changedCB): Call store_monospaced_changed.
3413 (init_gsettings): New function.
3414 (xsettings_initialize): Call init_gsettings.
3415 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3418 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
3421 2011-06-29 Martin Rudalics <rudalics@gmx.at>
3423 * window.c (resize_root_window, grow_mini_window)
3424 (shrink_mini_window): Rename Qresize_root_window to
3425 Qwindow_resize_root_window and Qresize_root_window_vertically to
3426 Qwindow_resize_root_window_vertically.
3428 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3430 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3432 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
3434 * makefile.w32-in: Redesign dependencies so they reflect more
3435 clearly which files are directly included by each source file,
3436 and not through other includes.
3438 2011-06-27 Martin Rudalics <rudalics@gmx.at>
3440 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3441 (sort_overlays, overlay_strings): When an overlay's clone number
3442 matches the window's clone number process the overlay even if
3443 the overlay's window property doesn't match the current window.
3445 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3446 (Fwindow_hchild): Rename to Fwindow_left_child.
3447 (Fwindow_next): Rename to Fwindow_next_sibling.
3448 (Fwindow_prev): Rename to Fwindow_prev_sibling.
3449 (resize_window_check): Rename to window_resize_check.
3450 (resize_window_apply): Rename to window_resize_apply.
3451 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3452 (Fdelete_other_windows_internal, resize_frame_windows)
3453 (Fsplit_window_internal, Fdelete_window_internal)
3454 (grow_mini_window, shrink_mini_window)
3455 (Fresize_mini_window_internal): Fix callers accordingly.
3457 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3459 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3460 (emacs_fixed_set_min_size): Remove.
3461 (emacs_fixed_new): Take frame as argument.
3463 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3464 (_EmacsFixedPrivate): Remove minwidth/height.
3465 Add struct frame *f.
3466 (emacs_fixed_init): Initialize priv->f.
3467 (get_parent_class, emacs_fixed_set_min_size): Remove.
3468 (emacs_fixed_new): Set priv->f to argument.
3469 (emacs_fixed_get_preferred_width)
3470 (emacs_fixed_get_preferred_height): Use min_width/height from
3471 frames size_hint to set minimum and natural (Bug#8919).
3472 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3473 and use min_width/height from frames size_hint to set
3474 min_width/height (Bug#8919).
3476 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
3477 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3480 2011-06-26 Eli Zaretskii <eliz@gnu.org>
3482 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3483 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3486 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
3488 * process.c (wait_reading_process_output): Bypass select if
3489 waiting for a cell while ignoring keyboard input, and input is
3490 pending. Suggested by Jan Djärv (Bug#8869).
3492 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3494 Use gnulib's dup2 module instead of rolling our own.
3495 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3497 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3499 * dispnew.c (scrolling_window): Before scrolling, turn off a
3500 mouse-highlight in the window being scrolled.
3502 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
3504 Move DEFSYM to lisp.h and use everywhere.
3506 * character.h (DEFSYM): Move declaration...
3507 * lisp.h (DEFSYM): ...here.
3513 * w32select.c: Don't include character.h.
3515 * alloc.c (syms_of_alloc):
3516 * buffer.c (syms_of_buffer):
3517 * bytecode.c (syms_of_bytecode):
3518 * callint.c (syms_of_callint):
3519 * casefiddle.c (syms_of_casefiddle):
3520 * casetab.c (init_casetab_once):
3521 * category.c (init_category_once, syms_of_category):
3522 * ccl.c (syms_of_ccl):
3523 * cmds.c (syms_of_cmds):
3524 * composite.c (syms_of_composite):
3525 * dbusbind.c (syms_of_dbusbind):
3526 * dired.c (syms_of_dired):
3527 * dispnew.c (syms_of_display):
3528 * doc.c (syms_of_doc):
3529 * editfns.c (syms_of_editfns):
3530 * emacs.c (syms_of_emacs):
3531 * eval.c (syms_of_eval):
3532 * fileio.c (syms_of_fileio):
3533 * fns.c (syms_of_fns):
3534 * frame.c (syms_of_frame):
3535 * fringe.c (syms_of_fringe):
3536 * insdel.c (syms_of_insdel):
3537 * keymap.c (syms_of_keymap):
3538 * lread.c (init_obarray, syms_of_lread):
3539 * macros.c (syms_of_macros):
3540 * msdos.c (syms_of_msdos):
3541 * print.c (syms_of_print):
3542 * process.c (syms_of_process):
3543 * search.c (syms_of_search):
3544 * sound.c (syms_of_sound):
3545 * syntax.c (init_syntax_once, syms_of_syntax):
3546 * terminal.c (syms_of_terminal):
3547 * textprop.c (syms_of_textprop):
3548 * undo.c (syms_of_undo):
3549 * w32.c (globals_of_w32):
3550 * window.c (syms_of_window):
3551 * xdisp.c (syms_of_xdisp):
3552 * xfaces.c (syms_of_xfaces):
3553 * xfns.c (syms_of_xfns):
3554 * xmenu.c (syms_of_xmenu):
3555 * xsettings.c (syms_of_xsettings):
3556 * xterm.c (syms_of_xterm): Use DEFSYM.
3558 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3560 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
3562 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3564 Integer and buffer overflow fixes (Bug#8873).
3566 * print.c (printchar, strout): Check for string overflow.
3567 (PRINTPREPARE, printchar, strout):
3568 Don't set size unless allocation succeeds.
3570 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3571 for sizes. Check for string overflow more accurately.
3572 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3574 * macros.c: Integer and buffer overflow fixes.
3575 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3576 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3577 Use ptrdiff_t, not int, for sizes.
3578 Don't increment bufsize until after realloc succeeds.
3579 Check for size-calculation overflow.
3580 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3582 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3584 * lread.c: Integer overflow fixes.
3585 (read_integer): Radix is now EMACS_INT, not int,
3586 to improve quality of diagnostics for out-of-range radices.
3587 Calculate buffer size correctly for out-of-range radices.
3588 (read1): Check for integer overflow in radices, and in
3589 read-circle numbers.
3590 (read_escape): Avoid int overflow.
3591 (Fload, openp, read_buffer_size, read1)
3592 (substitute_object_recurse, read_vector, read_list, map_obarray):
3593 Use ptrdiff_t, not int, for sizes.
3594 (read1): Use EMACS_INT, not int, for sizes.
3595 Check for size overflow.
3597 * image.c (cache_image): Check for size arithmetic overflow.
3599 * lread.c: Integer overflow issues.
3600 (saved_doc_string_size, saved_doc_string_length)
3601 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3602 Now ptrdiff_t, not int.
3603 (read1): Don't assume doc string length fits in int. Check for
3604 out-of-range doc string lengths.
3605 (read_list): Don't assume file position fits in int.
3606 (read_escape): Check for hex character overflow.
3608 2011-06-22 Leo Liu <sdl.web@gmail.com>
3610 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3611 Move to minibuffer.el.
3613 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3615 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
3616 The following patches are for when GLYPH_DEBUG && !XASSERT.
3617 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3618 * dispnew.c (flush_stdout):
3619 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3620 Mark as externally visible.
3621 * dispnew.c (check_window_matrix_pointers): Now static.
3622 * dispnew.c (window_to_frame_vpos):
3623 * xfns.c (unwind_create_frame):
3624 * xterm.c (x_check_font): Remove unused local.
3625 * scroll.c (CHECK_BOUNDS):
3626 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3627 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3628 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3629 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3630 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3632 (debug_method_add): Use va_list and vsprintf rather than relying
3633 on undefined behavior with wrong number of arguments.
3634 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3635 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3636 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3637 since we're not interested in debugging glyphs with old libraries.
3638 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3639 GCC 4.6.0's static checking.
3641 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3643 Integer overflow and signedness fixes (Bug#8873).
3644 A few related buffer overrun fixes, too.
3646 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3648 * dispextern.h (struct face.stipple):
3649 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3650 (x_bitmap_mask, x_allocate_bitmap_record)
3651 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3652 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3653 (x_create_bitmap_from_xpm_data):
3654 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3655 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3657 * xfaces.c (load_pixmap):
3658 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3659 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3660 (.bitmaps_last, struct x_output.icon_bitmap):
3661 Use ptrdiff_t, not int, for bitmap indexes.
3662 (x_allocate_bitmap_record): Check for size overflow.
3663 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3665 Use ptrdiff_t, not int, for overlay counts.
3666 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3667 * editfns.c (overlays_around, get_pos_property):
3668 * textprop.c (get_char_property_and_overlay):
3669 * xdisp.c (next_overlay_change, note_mouse_highlight):
3670 * xfaces.c (face_at_buffer_position):
3671 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3672 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3673 (Fnext_overlay_change, Fprevious_overlay_change)
3674 (mouse_face_overlay_overlaps, Foverlays_in):
3675 Use ptrdiff_t, not int, for sizes.
3676 (overlays_at, overlays_in): Check for size-calculation overflow.
3678 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3680 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3681 (x_session_initialize): Do not assume string length fits in int.
3683 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3684 This is unlikely, but can occur if DPI is outlandish.
3686 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3687 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3689 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3690 * xrdb.c (magic_file_p, search_magic_path):
3691 Omit last arg SUFFIX; it was always 0. All callers changed.
3692 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3694 * xfont.c (xfont_match): Avoid need for strlen.
3696 * xfns.c: Don't assume strlen fits in int.
3697 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3699 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3700 not unsigned long, as we prefer signed integers. All callers changed.
3701 Detect integer overflow in repeat count.
3702 (message_dolog): Don't assume print length fits in 39 bytes.
3703 (display_mode_element): Don't assume strlen fits in int.
3705 * termcap.c: Don't assume sizes fit in int and never overflow.
3706 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3707 (gobble_line): Check for size-calculation overflow.
3709 * minibuf.c (Fread_buffer):
3710 * lread.c (intern, intern_c_string):
3711 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3712 Don't assume string length fits in int.
3714 * keyboard.c (parse_tool_bar_item):
3715 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3717 * font.c: Don't assume string length fits in int.
3718 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3719 Use ptrdiff_t, not int.
3720 (font_intern_prop): Don't assume string length fits in int.
3721 Don't assume integer property fits in fixnum.
3722 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3724 * filelock.c: Fix some buffer overrun and integer overflow issues.
3725 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3726 Reformulate so as not to need the command string.
3727 Invoke gzip -cd rather than gunzip, as it's more portable.
3728 (lock_info_type, lock_file_1, lock_file):
3729 Don't assume pid_t and time_t fit in unsigned long.
3730 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3731 (current_lock_owner): Prefer signed type for sizes.
3732 Use memcpy, not strncpy, where memcpy is what is really wanted.
3733 Don't assume (via atoi) that time_t and pid_t fit in int.
3734 Check for time_t and/or pid_t out of range, e.g., via a network share.
3735 Don't alloca where an auto var works fine.
3737 * fileio.c: Fix some integer overflow issues.
3738 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3739 Don't assume string length fits in int.
3740 (directory_file_name): Don't assume string length fits in long.
3741 (make_temp_name): Don't assume pid fits in int, or that its print
3742 length is less than 20.
3744 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3746 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3748 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3750 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3751 We prefer signed integers, even for size calculations.
3753 * emacs.c: Don't assume string length fits in 'int'.
3754 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3755 (main): Don't invoke strlen when not needed.
3757 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3758 (XD_DEBUG_MESSAGE): Don't waste a byte.
3760 * callproc.c (getenv_internal_1, getenv_internal)
3762 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3764 * lread.c (invalid_syntax): Omit length argument.
3765 All uses changed. This doesn't fix a bug, but it simplifies the
3766 code away from its former Hollerith-constant appearance, and it's
3767 one less 'int' to worry about when looking at integer-overflow issues.
3768 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3770 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3771 This didn't break anything, but it didn't help either.
3772 It's confusing to put a bogus integer in a place where the actual
3773 value does not matter.
3774 (LIST_END_P): Remove unused macro and its bogus comment.
3775 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3777 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3778 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3780 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3781 We prefer signed types, and the value cannot exceed the EMACS_INT
3782 range anyway (because otherwise the length would not be representable).
3783 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3784 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3785 This avoids a GCC warning when WIDE_EMACS_INT.
3787 * indent.c (sane_tab_width): New function.
3788 (current_column, scan_for_column, Findent_to, position_indentation)
3789 (compute_motion): Use it. This is just for clarity.
3790 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3792 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3794 * lisp.h (lint_assume): New macro.
3795 * composite.c (composition_gstring_put_cache):
3796 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3798 * editfns.c, insdel.c:
3799 Omit unnecessary forward decls, to simplify future changes.
3801 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3803 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3805 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3806 Use much-faster test for byte-length change.
3807 Don't assume string byte-length fits in 'int'.
3808 Check that character arg fits in 'int'.
3809 (mapcar1): Declare byte as byte, for clarity.
3811 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3813 * fns.c (concat): Catch string overflow earlier.
3814 Do not rely on integer wraparound.
3816 * dispextern.h (struct it.overlay_strings_charpos)
3817 (struct it.selective): Now EMACS_INT, not int.
3818 * xdisp.c (forward_to_next_line_start)
3819 (back_to_previous_visible_line_start)
3820 (reseat_at_next_visible_line_start, next_element_from_buffer):
3821 Don't arbitrarily truncate the value of 'selective' to int.
3823 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3825 * composite.c: Don't truncate sizes to 'int'.
3826 (composition_gstring_p, composition_reseat_it)
3827 (composition_adjust_point): Use EMACS_INT, not int.
3828 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3829 not EMACS_UINT, for indexes.
3831 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3833 * buffer.c: Include <verify.h>.
3834 (struct sortvec.priority, struct sortstr.priority):
3835 Now EMACS_INT, not int.
3836 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3837 (struct sortstr.size, record_overlay_string)
3838 (struct sortstrlist.size, struct sortlist.used):
3839 Don't truncate size to int.
3840 (record_overlay_string): Check for size-calculation overflow.
3841 (init_buffer_once): Check at compile-time, not run-time.
3843 2011-06-22 Jim Meyering <meyering@redhat.com>
3845 Don't leak an XBM-image-sized buffer
3846 * image.c (xbm_load): Free the image buffer after using it.
3848 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3851 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3852 that Sun C diagnosed.
3853 * fns.c (secure_hash): Fix pointer signedness issue.
3854 * intervals.c (static_offset_intervals): New function.
3855 (offset_intervals): Use it.
3857 2011-06-21 Leo Liu <sdl.web@gmail.com>
3860 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3863 * fns.c (secure_hash): Rename from crypto_hash_function and change
3864 the first arg to accept symbols.
3865 (Fsecure_hash): New primitive.
3866 (syms_of_fns): New symbols.
3868 2011-06-20 Deniz Dogan <deniz@dogan.se>
3870 * process.c (Fset_process_buffer): Clarify return value in
3873 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3875 * dispnew.c (add_window_display_history): Use BVAR.
3877 * xdisp.c (debug_method_add): Use BVAR.
3878 (check_window_end, dump_glyph_matrix, dump_glyph)
3879 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3881 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3884 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3885 check till after the cache is created in init_frame_faces.
3887 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3889 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3891 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3893 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3894 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3895 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3897 Improve buffer-overflow checking (Bug#8873).
3898 * fileio.c (Finsert_file_contents):
3899 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3900 Remove the old (too-loose) buffer overflow checks.
3901 They weren't needed, since make_gap checks for buffer overflow.
3902 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3903 The old code merely checked for Emacs fixnum overflow, and relied
3904 on undefined (wraparound) behavior. The new code avoids undefined
3905 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3907 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3908 Tune. Don't use wider integers than needed. Don't use alloca.
3909 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3911 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3913 * insdel.c, lisp.h (buffer_overflow): New function.
3914 (insert_from_buffer_1, replace_range, replace_range_2):
3915 * insdel.c (make_gap_larger):
3916 * editfns.c (Finsert_char):
3917 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3919 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3921 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3923 Integer overflow and signedness fixes (Bug#8873).
3925 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3926 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3928 * fileio.c: Don't assume EMACS_INT fits in off_t.
3929 (emacs_lseek): New static function.
3930 (Finsert_file_contents, Fwrite_region): Use it.
3931 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3933 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3935 * fns.c: Don't overflow int when computing a list length.
3936 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3937 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3938 truncation on 64-bit hosts. Check for QUIT every
3939 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3940 faster and is responsive enough.
3941 (Flength): Report an error instead of overflowing an integer.
3942 (Fsafe_length): Return a float if the value is not representable
3943 as a fixnum. This shouldn't happen except in contrived situations.
3944 (Fnthcdr, Fsort): Don't assume list length fits in int.
3945 (Fcopy_sequence): Don't assume vector length fits in int.
3947 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3948 (header_size, word_size): New constants.
3949 (allocate_vectorlike): Don't check size overflow here.
3950 (allocate_vector): Check it here instead, since this is the only
3951 caller of allocate_vectorlike that could cause overflow.
3952 Check that the new vector's length is representable as a fixnum.
3954 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3955 The previous code was bogus. For example, next_almost_prime (32)
3956 returned 39, which is undesirable as it is a multiple of 3; and
3957 next_almost_prime (24) returned 25, which is a multiple of 5 so
3958 why was the code bothering to check for multiples of 7?
3960 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3962 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3964 Variadic C functions now count arguments with ptrdiff_t.
3965 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3966 Back then I didn't know that the Emacs coding style prefers signed int.
3967 Also, in the meantime I found a few more instances where arguments
3968 were being counted with int, which may truncate counts on 64-bit
3969 machines, or EMACS_INT, which may be unnecessarily wide.
3970 * lisp.h (struct Lisp_Subr.function.aMANY)
3971 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3972 Arg counts are now ptrdiff_t, not size_t.
3973 All variadic functions and their callers changed accordingly.
3974 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3975 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3976 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3977 * callint.c (Fcall_interactively): Check arg count for overflow,
3978 to avoid potential buffer overrun. Use signed char, not 'int',
3979 for 'varies' array, so that we needn't bother to check its size
3980 calculation for overflow.
3981 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3982 * eval.c (apply_lambda):
3983 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3984 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3985 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3987 * callint.c (Fcall_interactively): Don't use index var as event count.
3989 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3990 * mem-limits.h (SIZE): Remove; no longer used.
3992 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3994 Remove unnecessary casts.
3995 * xterm.c (x_term_init):
3996 * xfns.c (x_set_border_pixel):
3997 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3998 These aren't needed now that we assume ANSI C.
4000 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4001 It's more likely to cause problems (due to unsigned overflow)
4004 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4006 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4008 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4010 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4012 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4014 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4016 GLYPH_CODE_FACE returns EMACS_INT, not int.
4017 * dispextern.h (merge_faces):
4018 * xfaces.c (merge_faces):
4019 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4020 Don't assume EMACS_INT fits in int.
4022 * character.h (CHAR_VALID_P): Remove unused parameter.
4023 * fontset.c, lisp.h, xdisp.c: All uses changed.
4025 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4027 * fns.c (concat): Minor tuning based on overflow analysis.
4028 This doesn't fix any bugs. Use int to hold character, instead
4029 of constantly refetching from Emacs object. Use XFASTINT, not
4030 XINT, for value known to be a character. Don't bother comparing
4031 a single byte to 0400, as it's always less.
4033 * floatfns.c (Fexpt):
4034 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4036 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4039 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4041 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4042 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4043 incorrectly succeed when S was a string, because 4294967386 was
4044 truncated before it was used.
4046 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4047 Otherwise, an out-of-range integer could cause undefined behavior
4050 * composite.c: Use int, not EMACS_INT, for characters.
4051 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4052 EMACS_INT, for values that are known to be in character range.
4053 This doesn't fix any bugs but is the usual style inside Emacs and
4054 may generate better code on 32-bit machines.
4056 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4057 This is for reasons similar to the recent CHAR_STRING fix.
4058 * charset.c (Fencode_char): Check that character arg is actually
4059 a character. Pass an int to ENCODE_CHAR.
4060 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4061 wider than 'int', as a compile-time check to prevent future regressions
4064 * character.c (char_string): Remove unnecessary casts.
4066 Make sure a 64-bit char is never passed to CHAR_STRING.
4067 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4068 by silently ignoring the top 32 bits, allowing some values
4069 that were far too large to be valid characters.
4070 * character.h: Include <verify.h>.
4071 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4072 arguments are no wider than unsigned, as a compile-time check
4073 to prevent future regressions in this area.
4075 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4076 (Fsubst_char_in_region):
4078 * xdisp.c (decode_mode_spec_coding):
4079 Adjust to CHAR_STRING's new requirement.
4080 * editfns.c (Finsert_char, Fsubst_char_in_region):
4081 * fns.c (concat): Check that character args are actually
4082 characters. Without this test, these functions did the wrong
4083 thing with wildly out-of-range values on 64-bit hosts.
4085 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4086 These casts should not be needed on 32-bit hosts, either.
4087 * keyboard.c (read_char):
4088 * lread.c (Fload): Remove casts to unsigned.
4090 * lisp.h (UNSIGNED_CMP): New macro.
4091 This fixes comparison bugs on 64-bit hosts.
4092 (ASCII_CHAR_P): Use it.
4093 * casefiddle.c (casify_object):
4094 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4095 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4096 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4097 * dispextern.h (FACE_FROM_ID):
4098 * keyboard.c (read_char): Use UNSIGNED_CMP.
4100 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4101 not to EMACS_INT, to avoid GCC warning.
4103 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4105 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4106 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4107 isn't needed on 32-bit machines.
4109 * buffer.c (Fgenerate_new_buffer_name):
4110 Use EMACS_INT for count, not int.
4111 (advance_to_char_boundary): Return EMACS_INT, not int.
4113 * data.c (Qcompiled_function): Now static.
4115 * window.c (window_body_lines): Now static.
4117 * image.c (gif_load): Rename local to avoid shadowing.
4119 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4120 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4121 * alloc.c (make_save_value): Integer argument is now of type
4123 (mark_object): Use ptrdiff_t, not int.
4124 * lisp.h (pD): New macro.
4125 * print.c (print_object): Use it.
4127 * alloc.c: Use EMACS_INT, not int, to count objects.
4128 (total_conses, total_markers, total_symbols, total_vector_size)
4129 (total_free_conses, total_free_markers, total_free_symbols)
4130 (total_free_floats, total_floats, total_free_intervals)
4131 (total_intervals, total_strings, total_free_strings):
4132 Now EMACS_INT, not int. All uses changed.
4133 (Fgarbage_collect): Compute overall total using a double, so that
4134 integer overflow is less likely to be a problem. Check for overflow
4135 when converting back to an integer.
4136 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4137 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4138 These were 'int' variables that could overflow on 64-bit hosts;
4139 they were never used, so remove them instead of repairing them.
4140 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4141 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4142 Previously, this ceilinged at INT_MAX, but that doesn't work on
4144 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4146 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4147 (allocate_vectorlike): Check for ptrdiff_t overflow.
4148 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4149 when a (possibly-narrower) signed value would do just as well.
4150 We prefer using signed arithmetic, to avoid comparison confusion.
4152 * alloc.c: Catch some string size overflows that we were missing.
4153 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4154 for convenience in STRING_BYTES_MAX.
4155 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4156 The definition here is exact; the one in lisp.h was approximate.
4157 (allocate_string_data): Check for string overflow. This catches
4158 some instances we weren't catching before. Also, it catches
4159 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4160 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4161 and ptrdiff_t and EMACS_INT are both 64 bits.
4163 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4164 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4165 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4167 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4169 * alloc.c (Fmake_string): Check for out-of-range init.
4171 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4173 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4175 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4177 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4178 xg_get_default_scrollbar_width.
4180 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4181 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4182 (style_changed_cb): Call update_theme_scrollbar_width and call
4183 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4184 all frames (Bug#8505).
4185 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4186 Call gtk_window_set_resizable if HAVE_GTK3.
4187 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4188 and height if HAVE_GTK3 (Bug#8505).
4189 (scroll_bar_width_for_theme): New variable.
4190 (update_theme_scrollbar_width): New function.
4191 (xg_get_default_scrollbar_width): Move code to
4192 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4193 (xg_initialize): Call update_theme_scrollbar_width.
4195 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4197 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4199 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4201 * frame.c (make_frame): Call other_buffer_safely instead of
4204 * window.c (temp_output_buffer_show): Call display_buffer with
4205 second argument Vtemp_buffer_show_specifiers and reset latter
4206 immediately after the call.
4207 (Vtemp_buffer_show_specifiers): New variable.
4208 (auto_window_vscroll_p, next_screen_context_lines)
4209 (Vscroll_preserve_screen_position): Remove leading asterisks from
4212 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4214 Fix minor problems found by GCC 4.6.0 static checking.
4215 * buffer.c (Qclone_number): Remove for now, as it's unused.
4216 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4217 (record_buffer): Remove unused local.
4218 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4219 (set_frame_buffer_list): Remove; unused.
4220 * frame.h (other_visible_frames): Remove decl.
4221 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4222 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4223 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4225 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4226 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4227 Define only if HAVE_GPM.
4228 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4229 (update_hints_inhibit): Remove; never set. All uses removed.
4230 * widgetprv.h (emacsFrameClassRec): Remove decl.
4231 * window.c (delete_deletable_window): Now returns void, since it
4232 wasn't returning anything.
4233 (compare_window_configurations): Remove unused locals.
4234 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4235 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4236 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4237 the same widths as pointers. This follows up on the 2011-05-06 patch.
4238 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4239 * xterm.h: Likewise.
4240 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4242 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4244 * makefile.w32-in: Update dependencies.
4245 (LISP_H): Add lib/intprops.h.
4247 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4249 * image.c (gif_load): Add animation frame delay to the metadata.
4250 (syms_of_image): Use DEFSYM. New symbol `delay'.
4252 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4254 * window.c (delete_deletable_window): Re-add.
4255 (Fset_window_configuration): Rewrite to handle dead buffers and
4256 consequently deletable windows.
4257 (window_tree, Fwindow_tree): Remove. Supply functionality in
4259 (compare_window_configurations): Simplify code.
4261 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4263 * image.c (imagemagick_load_image): Fix type mismatch.
4264 (Fimagemagick_types): Likewise.
4266 * window.h (replace_buffer_in_windows): Declare.
4268 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4270 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4271 Qclone_number. Remove external declaration of Qdelete_window.
4272 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4274 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4275 Run Qbuffer_list_update_hook if allowed.
4276 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4277 buffer list implementation.
4278 (other_buffer_safely): New function.
4279 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4280 calls to replace_buffer_in_windows and
4281 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4283 (record_buffer): Inhibit quitting and rewrite using quittable
4284 functions. Run Qbuffer_list_update_hook if allowed.
4285 (Frecord_buffer, Funrecord_buffer): New functions.
4286 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4287 Move switch-to-buffer to window.el.
4288 (bury-buffer): Move to window.el.
4289 (Vbuffer_list_update_hook): New variable.
4291 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4294 * window.h (resize_frame_windows): Move up in code.
4295 (Fwindow_frame): Remove EXFUN.
4296 (replace_buffer_in_all_windows): Remove prototype.
4297 (replace_buffer_in_windows_safely): Add prototype.
4299 * window.c: Declare Qdelete_window static again. Move down
4300 declaration of select_count.
4301 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4302 (Fother_window): Move to window.el.
4303 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4304 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4305 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4307 (replace_buffer_in_windows): Implement by calling
4308 Qreplace_buffer_in_windows.
4309 (replace_buffer_in_all_windows): Remove with some functionality
4310 moved into replace_buffer_in_windows_safely.
4311 (replace_buffer_in_windows_safely): New function.
4312 (select_window_norecord, select_frame_norecord): Move in front
4313 of run_window_configuration_change_hook. Remove now obsolete
4315 (Fset_window_buffer): Rewrite doc-string.
4316 Call Qrecord_window_buffer.
4317 (keys_of_window): Move binding for other-window to window.el.
4319 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4321 * dispextern.h (struct image): Replace data member, whose int_val
4322 and ptr_val fields were not used by anything, with a single
4325 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4326 (gif_clear_image, gif_load, imagemagick_load_image)
4327 (gs_clear_image, gs_load): Callers changed.
4329 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4331 * buffer.h: Include <time.h>, for time_t.
4332 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4334 Fix minor problems found by static checking.
4336 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4338 Make identifiers static if they are not used in other modules.
4339 * data.c (Qcompiled_function, Qframe, Qvector):
4340 * image.c (QimageMagick, Qsvg):
4341 * minibuf.c (Qmetadata):
4342 * window.c (resize_window_check, resize_root_window): Now static.
4343 * window.h (resize_window_check, resize_root_window): Remove decls.
4345 * window.c (window_deletion_count, delete_deletable_window):
4347 (window_body_lines): Now static.
4348 (Fdelete_other_windows_internal): Mark vars as initialized.
4349 Make sure 'resize_failed' is initialized.
4350 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4351 (resize_window_apply): Remove unused local.
4352 * window.h (delete_deletable_window): Remove decl.
4354 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4355 (imagemagick_load_image): Fix pointer signedness problem by changing
4356 last arg from unsigned char * to char *. All uses changed.
4357 Also, fix a local for similar reasons.
4358 Remove unused locals. Remove locals to avoid shadowing.
4359 (fn_rsvg_handle_free): Remove; unused.
4360 (svg_load, svg_load_image): Fix pointer signedness problem.
4361 (imagemagick_load_image): Don't use garbage pointer image_wand.
4363 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4365 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4367 * image.c (gif_load): Fix omitted cast error introduced by
4370 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4372 * window.h (resize_proportionally, orig_total_lines)
4373 (orig_top_line): Remove from window structure.
4374 (set_window_height, set_window_width, change_window_heights)
4375 (Fdelete_window): Remove prototypes.
4376 (resize_frame_windows): Remove duplicate declaration.
4378 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4380 * window.h (resize_frame_windows, resize_window_check)
4381 (delete_deletable_window, resize_root_window)
4382 (resize_frame_windows): Declare prototypes.
4384 * window.c (resize_window_apply): Make definition be "static" to
4385 match the prototype.
4387 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4389 * window.c: Remove declarations of Qwindow_size_fixed,
4390 window_min_size_1, window_min_size_2, window_min_size,
4391 size_window, window_fixed_size_p, enlarge_window, delete_window.
4392 Remove static from declaration of Qdelete_window, it's
4393 temporarily needed by Fbury_buffer.
4394 (replace_window): Don't assign orig_top_line and
4396 (Fdelete_window, delete_window): Remove. Window deletion is
4397 handled by window.el.
4398 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4399 Replace Fdelete_window calls with calls to Qdelete_window.
4400 (Fdelete_other_windows): Remove. Deleting other windows is
4401 handled by window.el.
4402 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4403 handled in window.el.
4404 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4405 Window minimum sizes are handled in window.el.
4406 (shrink_windows, size_window, set_window_height)
4407 (set_window_width, change_window_heights, window_height)
4408 (window_width, CURBEG, CURSIZE, enlarge_window)
4409 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4410 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4411 handled in window.el.
4412 (make_dummy_parent): Rename to make_parent_window and give it a
4413 second argument horflag.
4414 (make_window): Don't set resize_proportionally any more.
4415 (Fsplit_window): Remove. Windows are split in window.el.
4416 (save_restore_action, save_restore_orig_size)
4417 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4418 Resize mini windows in window.el.
4419 (grow_mini_window, shrink_mini_window): Implement by calling
4420 Qresize_root_window_vertically, resize_window_check and
4421 resize_window_apply.
4422 (saved_window, Fset_window_configuration, save_window_save):
4423 Do not handle orig_top_line, orig_total_lines, and
4424 resize_proportionally.
4425 (window_min_height, window_min_width): Move to window.el.
4426 (keys_of_window): Move bindings for delete-other-windows,
4427 split-window, delete-window and enlarge-window to window.el.
4429 * buffer.c: Temporarily extern Qdelete_window.
4430 (Fbury_buffer): Temporarily call Qdelete_window instead of
4431 Fdelete_window (Fbury_buffer will move to window.el soon).
4433 * frame.c (set_menu_bar_lines_1): Remove code handling
4434 orig_top_line and orig_total_lines.
4436 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4437 set_window_height but set heights directly.
4438 (change_frame_size_1): Use resize_frame_windows.
4440 * xdisp.c (init_xdisp): Don't use set_window_height but set
4443 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4444 Use resize_frame_windows instead of change_window_heights and run
4445 run_window_configuration_change_hook.
4447 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4448 instead of change_window_heights and run
4449 run_window_configuration_change_hook.
4451 2011-06-09 Martin Rudalics <rudalics@gmx.at>
4453 * window.c (replace_window): Rename second argument REPLACEMENT to
4454 NEW. New third argument SETFLAG. Rewrite.
4455 (delete_window, make_dummy_parent): Call replace_window with
4457 (window_list_1): Move down in code.
4458 (run_window_configuration_change_hook): Move set_buffer part
4459 before select_frame_norecord part in order to unwind correctly.
4460 Rename count1 to count.
4461 (recombine_windows, delete_deletable_window, resize_root_window)
4462 (Fdelete_other_windows_internal)
4463 (Frun_window_configuration_change_hook, make_parent_window)
4464 (resize_window_check, resize_window_apply, Fresize_window_apply)
4465 (resize_frame_windows, Fsplit_window_internal)
4466 (Fdelete_window_internal, Fresize_mini_window_internal):
4468 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4470 2011-06-08 Martin Rudalics <rudalics@gmx.at>
4472 * window.h (window): Add some new members to window structure -
4473 normal_lines, normal_cols, new_total, new_normal, clone_number,
4474 splits, nest, prev_buffers, next_buffers.
4475 (WINDOW_TOTAL_SIZE): Move here from window.c.
4476 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
4478 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4480 (make_dummy_parent): Set new members of windows structure.
4481 (make_window): Move down in code. Handle new members of window
4483 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4484 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4485 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4486 (Fset_window_prev_buffers, Fwindow_next_buffers)
4487 (Fset_window_next_buffers, Fset_window_clone_number):
4489 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4490 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4492 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4493 Argument WINDOW can be now internal window too.
4494 (Fwindow_use_time): Move up in code.
4495 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4497 (Fset_window_configuration, saved_window)
4498 (Fcurrent_window_configuration, save_window_save): Handle new
4499 members of window structure.
4500 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4501 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4502 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4503 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4504 Qget_mru_window, Qresize_root_window,
4505 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4506 Qauto_buffer_name; staticpro them.
4508 2011-06-07 Martin Rudalics <rudalics@gmx.at>
4510 * window.c (Fwindow_total_size, Fwindow_left_column)
4511 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4512 (Fwindow_list_1): New functions.
4513 (window_box_text_cols): Replace with window_body_cols.
4514 (Fwindow_width, Fscroll_left, Fscroll_right):
4515 Use window_body_cols instead of window_box_text_cols.
4516 (delete_window, Fset_window_configuration):
4517 Call delete_all_subwindows with window as argument.
4518 (delete_all_subwindows): Take a window as argument and not a
4520 (window_loop): Remove handling of GET_LRU_WINDOW and
4522 (Fget_lru_window, Fget_largest_window): Move to window.el.
4524 * window.h: Extern window_body_cols instead of
4525 window_box_text_cols. delete_all_subwindows now takes a
4526 Lisp_Object as argument.
4528 * indent.c (compute_motion, Fcompute_motion):
4529 Use window_body_cols instead of window_box_text_cols.
4531 * frame.c (delete_frame): Call delete_all_subwindows with root
4534 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4536 * fns.c (Fputhash): Document return value.
4538 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
4540 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4542 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4544 Cons<->int and similar integer overflow fixes (Bug#8794).
4546 Check for overflow when converting integer to cons and back.
4547 * charset.c (Fdefine_charset_internal, Fdecode_char):
4548 Use cons_to_unsigned to catch overflow.
4549 (Fencode_char): Use INTEGER_TO_CONS.
4550 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4551 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4552 * data.c (long_to_cons, cons_to_long): Remove.
4553 (cons_to_unsigned, cons_to_signed): New functions.
4554 These signal an error for invalid or out-of-range values.
4555 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4556 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4557 * font.c (Ffont_variation_glyphs):
4558 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4559 * lisp.h: Include <intprops.h>.
4560 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4561 (cons_to_signed, cons_to_unsigned): New decls.
4562 (long_to_cons, cons_to_long): Remove decls.
4563 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4564 (Fprimitive_undo): Use CONS_TO_INTEGER.
4565 * xfns.c (Fx_window_property): Likewise.
4566 * xselect.c: Include <limits.h>.
4567 (x_own_selection, selection_data_to_lisp_data):
4568 Use INTEGER_TO_CONS.
4569 (x_handle_selection_request, x_handle_selection_clear)
4570 (x_get_foreign_selection, Fx_disown_selection_internal)
4571 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4572 (lisp_data_to_selection_data): Use cons_to_unsigned.
4573 (x_fill_property_data): Use cons_to_signed.
4574 Report values out of range.
4576 Check for buffer and string overflow more precisely.
4577 * buffer.h (BUF_BYTES_MAX): New macro.
4578 * lisp.h (STRING_BYTES_MAX): New macro.
4579 * alloc.c (Fmake_string):
4580 * character.c (string_escape_byte8):
4581 * coding.c (coding_alloc_by_realloc):
4582 * doprnt.c (doprnt):
4583 * editfns.c (Fformat):
4585 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4586 since they may not be the same number.
4587 * editfns.c (Finsert_char):
4588 * fileio.c (Finsert_file_contents):
4589 Likewise for BUF_BYTES_MAX.
4591 * image.c: Use ptrdiff_t, not int, for sizes.
4592 (slurp_file): Switch from int to ptrdiff_t.
4594 (slurp_file): Check that file size fits in both size_t (for
4595 malloc) and ptrdiff_t (for sanity and safety).
4597 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4598 if b->modtime has its maximal value.
4600 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4602 Don't assume time_t can fit into int.
4603 * buffer.h (struct buffer.modtime): Now time_t, not int.
4604 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4605 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4607 Minor fixes for signed vs unsigned integers.
4608 * character.h (MAYBE_UNIFY_CHAR):
4609 * charset.c (maybe_unify_char):
4610 * keyboard.c (read_char, reorder_modifiers):
4611 XINT -> XFASTINT, since the integer must be nonnegative.
4612 * ftfont.c (ftfont_spec_pattern):
4613 * keymap.c (access_keymap, silly_event_symbol_error):
4614 XUINT -> XFASTINT, since the integer must be nonnegative.
4615 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4616 since it makes no difference and we prefer signed.
4617 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4618 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4621 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4623 * window.h (Fwindow_frame): Declare.
4625 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4627 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4628 (SPARE_MEMORY): Always define.
4629 (LARGE_REQUEST): Remove.
4630 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4632 2011-06-06 Martin Rudalics <rudalics@gmx.at>
4634 * lisp.h: Move EXFUNS for Fframe_root_window,
4635 Fframe_first_window and Fset_frame_selected_window to window.h.
4637 * window.h: Move EXFUNS for Fframe_root_window,
4638 Fframe_first_window and Fset_frame_selected_window here from
4641 * frame.c (Fwindow_frame, Fframe_first_window)
4642 (Fframe_root_window, Fframe_selected_window)
4643 (Fset_frame_selected_window): Move to window.c.
4644 (Factive_minibuffer_window): Move to minibuf.c.
4645 (Fother_visible_frames_p): New function.
4647 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4649 * window.c (decode_window, decode_any_window): Move up in code.
4650 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4651 (inhibit_frame_unsplittable): Remove unused variable.
4652 (Fwindow_buffer): Move up and rewrite doc-string.
4653 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4654 (Fwindow_prev): New functions.
4655 (Fwindow_frame): Move here from frame.c. Accept any window as
4657 (Fframe_root_window, Fframe_first_window)
4658 (Fframe_selected_window): Move here from frame.c. Accept frame
4659 or arbitrary window as argument. Update doc-strings.
4660 (Fminibuffer_window): Move up in code.
4661 (Fwindow_minibuffer_p): Move up in code and simplify.
4662 (Fset_frame_selected_window): Move here from frame.c.
4664 (Fselected_window, select_window, Fselect_window): Move up in
4665 code. Minor doc-string fixes.
4667 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4669 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4670 Do not assume that spare memory exists; that assumption is valid
4671 only if SYSTEM_MALLOC.
4672 (LARGE_REQUEST): New macro, so that the issue of large requests
4673 is separated from the issue of spare memory.
4675 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4677 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4680 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4682 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4685 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4687 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4689 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4691 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4692 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4694 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
4696 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4698 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
4700 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4701 (x_clipboard_manager_save): Add return value.
4702 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4704 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4705 Obey Vx_select_enable_clipboard_manager. Catch errors in
4706 x_clipboard_manager_save (Bug#8779).
4707 (Vx_select_enable_clipboard_manager): New variable.
4708 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4710 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4712 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4714 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4716 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4717 in the current matrix if keep_current_p is non-zero.
4719 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4721 * bidi.c (bidi_level_of_next_char): Fix last change.
4723 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4725 Support bidi reordering of text covered by display properties.
4727 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4728 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4729 (bidi_cache_search, bidi_cache_iterator_state)
4730 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4731 (bidi_level_of_next_char, bidi_move_to_visually_next):
4732 Support character positions inside a run of characters covered by a
4734 (bidi_paragraph_init, bidi_resolve_explicit_1)
4735 (bidi_level_of_next_char): Call bidi_fetch_char and
4736 bidi_fetch_char_advance instead of FETCH_CHAR and
4738 (bidi_init_it): Initialize new members.
4739 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4741 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4742 instead of using explicit *_CHAR codes.
4743 (bidi_resolve_explicit, bidi_resolve_weak):
4744 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4745 bidirectional text is supported only in multibyte buffers.
4746 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4747 it to initialize the frame_window_p member of struct bidi_it.
4748 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4749 (bidi_resolve_explicit, bidi_resolve_weak)
4750 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4751 bidi_it->nchars is non-positive.
4752 (bidi_level_of_next_char): Don't try to lookup the cache for the
4753 next/previous character if nothing is cached there yet, or if we
4754 were just reseat()'ed to a new position.
4756 * xdisp.c (set_cursor_from_row): Set start and stop points
4757 according to the row's direction when priming the loop that looks
4758 for the glyph on which to display cursor.
4759 (single_display_spec_intangible_p): Function deleted.
4760 (display_prop_intangible_p): Reimplement to call
4761 handle_display_spec instead of single_display_spec_intangible_p.
4762 Accept 3 additional arguments needed by handle_display_spec.
4763 This fixes incorrect cursor motion across display property with complex
4764 values: lists, `(when COND...)' forms, etc.
4765 (single_display_spec_string_p): Support property values that are
4766 lists with the argument STRING its top-level element.
4767 (display_prop_string_p): Fix the condition for processing a
4768 property that is a list to be consistent with handle_display_spec.
4769 (handle_display_spec): New function, refactored from the
4770 last portion of handle_display_prop.
4771 (compute_display_string_pos): Accept additional argument
4772 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4773 value of a `display' property is a "replacing spec".
4774 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4775 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4776 the display property, but just return a value indicating whether
4777 the display property will replace the characters it covers.
4778 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4779 frame_window_p members of struct bidi_it.
4780 (compute_display_string_pos, compute_display_string_end):
4782 (push_it): Accept second argument POSITION, where pop_it should
4783 jump to continue iteration.
4784 (reseat_1): Initialize bidi_it.disp_pos.
4786 * keyboard.c (adjust_point_for_property): Adjust the call to
4787 display_prop_intangible_p to its new signature.
4789 * dispextern.h (struct bidi_it): New member frame_window_p.
4790 (bidi_init_it): Update prototypes.
4791 (display_prop_intangible_p): Update prototype.
4792 (compute_display_string_pos, compute_display_string_end):
4794 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4797 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4799 Malloc failure behavior now depends on size of allocation.
4800 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4801 * lisp.h: Change signatures accordingly.
4802 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4803 All callers changed. (Bug#8762)
4805 * gnutls.c: Use Emacs's memory allocators.
4806 Without this change, the gnutls library would invoke malloc etc.
4807 directly, which causes problems on non-SYNC_INPUT hosts, and which
4808 runs afoul of improving memory_full behavior. (Bug#8761)
4809 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4810 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4811 xfree instead of the default malloc, realloc, free.
4812 (Fgnutls_boot): No need to check for memory allocation failure,
4813 since xmalloc does that for us.
4815 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4816 * category.c (hash_get_category_set):
4817 * ccl.c (ccl_driver):
4818 * charset.c (Fdefine_charset_internal):
4819 * charset.h (struct charset.hash_index):
4820 * composite.c (get_composition_id, gstring_lookup_cache)
4821 (composition_gstring_put_cache):
4822 * composite.h (struct composition.hash_index):
4823 * dispextern.h (struct image.hash):
4824 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4825 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4826 (hashfn_equal, hashfn_user_defined, make_hash_table)
4827 (maybe_resize_hash_table, hash_lookup, hash_put)
4828 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4829 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4830 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4831 * image.c (make_image, search_image_cache, lookup_image)
4832 (xpm_put_color_table_h):
4833 * lisp.h (struct Lisp_Hash_Table):
4834 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4835 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4836 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4837 * alloc.c (allocate_vectorlike):
4838 Check for overflow in vector size calculations.
4839 * ccl.c (ccl_driver):
4840 Check for overflow when converting EMACS_INT to int.
4841 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4842 need to be updated by these changes.
4843 * fns.c (make_hash_table, maybe_resize_hash_table):
4844 Check for integer overflow with large hash tables.
4845 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4846 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4847 (SXHASH_REDUCE): New macro.
4848 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4849 Use it instead of discarding useful hash info with large hash values.
4850 (sxhash_float): New function.
4851 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4852 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4853 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4854 Rewrite to use FIXNUM_BITS, as this simplifies things.
4855 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4856 Adjust signatures to match updated version of code.
4857 (consing_since_gc): Now EMACS_INT, since a single hash table can
4858 use more than INT_MAX bytes.
4860 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4862 Make it possible to build with GCC-4.6+ -O2 -flto.
4864 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4866 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4868 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4869 Call minibuffer-inactive-mode.
4871 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4873 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4874 Update dependencies.
4876 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4878 * data.c (init_data): Remove code for UTS, this system is not
4881 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4883 Don't force ./temacs to start in terminal mode.
4885 * frame.c (make_initial_frame): Initialize faces in all cases, not
4886 only when CANNOT_DUMP is defined.
4887 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4889 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4891 * dispnew.c (add_window_display_history): Use const for the string
4892 pointer. Remove declaration, not needed.
4894 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4896 Use 'inline', not 'INLINE'.
4897 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4898 * alloc.c, fontset.c (INLINE): Remove.
4899 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4900 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4901 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4902 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4903 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4905 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4907 Make it possible to run ./temacs.
4909 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4910 syms_of_callproc does the same thing. Remove test for
4911 "initialized", do it in the caller.
4912 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4914 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4916 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4917 (read_minibuf): Use get_minibuffer.
4918 (syms_of_minibuf): Use DEFSYM.
4919 (Qmetadata): New var.
4920 * data.c (Qbuffer): Don't make it static.
4921 (syms_of_data): Use DEFSYM.
4923 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4925 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4926 (CCL_CODE_MIN): New macro.
4928 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4930 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4932 * eval.c (Qdebug): Now static.
4933 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4934 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4935 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4937 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4939 * image.c: Various fixes to ImageMagick code comments.
4940 (Fimagemagick_types): Doc fix.
4942 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4944 Minor fixes prompted by GCC 4.6.0 warnings.
4946 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4948 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4949 (x_clipboard_manager_save_all): Move extern decl to ...
4950 * xterm.h: ... here, so that it can be checked for consistency.
4952 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4954 * xselect.c (x_clipboard_manager_save_frame)
4955 (x_clipboard_manager_save_all): New functions.
4956 (Fx_clipboard_manager_save): Lisp function deleted.
4958 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4959 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4961 * xterm.h: Update prototype.
4963 2011-05-28 William Xu <william.xwl@gmail.com>
4965 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4968 2011-05-28 Jim Meyering <meyering@redhat.com>
4970 Avoid a sign-extension bug in crypto_hash_function.
4971 * fns.c (to_uchar): Define.
4972 (crypto_hash_function): Use it to convert some newly-signed
4973 variables to unsigned, to avoid sign-extension bugs. For example,
4974 without this change, (md5 "truc") would evaluate to
4975 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4976 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4977 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4979 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4981 Integer overflow fixes.
4983 * dbusbind.c: Serial number integer overflow fixes.
4984 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4985 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4986 to hold a serial number that is too large for a fixnum.
4987 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4988 Check for serial numbers out of range. Decode any serial number
4989 that was so large that it became a float. (Bug#8722)
4991 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4992 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4993 Use XFASTINT rather than XUINT when numbers are nonnegative.
4994 (xd_append_arg, Fdbus_method_return_internal):
4995 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4996 arguments, check that Lisp number is nonnegative, rather than
4997 silently wrapping negative numbers around. (Bug#8722)
4998 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5001 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5003 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5005 ccl: add integer overflow checks
5006 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5007 (IN_INT_RANGE): New macros.
5008 (ccl_driver): Use them to check for integer overflow when
5009 decoding a CCL program. Many of the new checks are whether XINT (x)
5010 fits in int; it doesn't always, on 64-bit hosts. The new version
5011 doesn't catch all possible integer overflows, but it's an
5012 improvement. (Bug#8719)
5014 * alloc.c (make_event_array): Use XINT, not XUINT.
5015 There's no need for unsigned here.
5017 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5018 This follows up to the 2011-05-06 change that substituted uintptr_t
5019 for EMACS_INT. This case wasn't caught back then.
5021 Rework Fformat to avoid integer overflow issues.
5022 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5023 now (part of C89). Include <verify.h>.
5024 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5025 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5026 (Fformat): Avoid the prepass trying to compute sizes; it was only
5027 approximate and thus did not catch overflow reliably. Instead, walk
5028 through the format just once, formatting and computing sizes as we go,
5029 checking for integer overflow at every step, and allocating a larger
5030 buffer as needed. Keep track separately whether the format is
5031 multibyte. Keep only the most-recently calculated precision, rather
5032 than them all. Record whether each argument has been converted to
5033 string. Use EMACS_INT, not int, for byte and char and arg counts.
5034 Support field widths and precisions larger than INT_MAX. Avoid
5035 sprintf's undefined behavior with conversion specifications such as %#d
5036 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5037 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5038 formatting out-of-range floating point numbers with int
5041 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5043 * data.c: Avoid integer truncation in expressions involving floats.
5044 * data.c: Include <intprops.h>.
5045 (arith_driver): When there's an integer overflow in an expression
5046 involving floating point, convert the integers to floating point
5047 so that the resulting value does not suffer from catastrophic
5048 integer truncation. For example, on a 64-bit host (* 4
5049 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5050 Do not rely on undefined behavior after integer overflow.
5052 merge count_size_as_multibyte, parse_str_to_multibyte
5053 * character.c, character.h (count_size_as_multibyte):
5054 Rename from parse_str_to_multibyte; all uses changed.
5055 Check for integer overflow.
5056 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5057 since it's now a duplicate of the other. This is more of
5058 a character than a buffer op, so better that it's in character.c.
5059 * fns.c, print.c: Adjust to above changes.
5061 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5063 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5065 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5067 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5068 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5069 (x_clipboard_manager_save): Now static.
5070 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5072 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5073 (crypto_hash_function): Now static.
5074 Fix pointer signedness problems. Avoid unnecessary initializations.
5076 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5078 * termhooks.h (Vselection_alist): Make it terminal-local.
5080 * terminal.c (create_terminal): Initialize it.
5082 * xselect.c: Support for clipboard managers.
5083 (Vselection_alist): Move to termhooks.h as terminal-local var.
5084 (LOCAL_SELECTION): New macro.
5085 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5086 (symbol_to_x_atom): Remove gratuitous arg.
5087 (x_handle_selection_request, lisp_data_to_selection_data)
5088 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5089 (x_own_selection, x_get_local_selection, x_convert_selection):
5090 New arg, specifying work frame. Use terminal-local Vselection_alist.
5091 (some_frame_on_display): Delete unused function.
5092 (Fx_own_selection_internal, Fx_get_selection_internal)
5093 (Fx_disown_selection_internal, Fx_selection_owner_p)
5094 (Fx_selection_exists_p): New optional frame arg.
5095 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5096 (x_handle_selection_clear): Don't treat other terminals with the
5097 same keyboard specially. Use the terminal-local Vselection_alist.
5098 (x_clear_frame_selections): Use Frun_hook_with_args.
5100 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5102 * xterm.h: Add support for those atoms.
5104 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5106 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5107 (converted_selections, conversion_fail_tag): New global variables.
5108 (x_selection_request_lisp_error): Free the above.
5109 (x_get_local_selection): Remove unnecessary code.
5110 (x_reply_selection_request): Args changed; handle arbitrary array
5111 of converted selections stored in converted_selections.
5112 Separate the XChangeProperty and SelectionNotify steps.
5113 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5114 (x_convert_selection): New function.
5115 (x_handle_selection_event): Simplify.
5116 (x_get_foreign_selection): Don't ignore incoming requests while
5117 waiting for an answer; this will fail when we implement
5118 SAVE_TARGETS, and seems unnecessary anyway.
5119 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5120 (Vx_sent_selection_functions): Doc fix.
5122 2011-05-26 Leo Liu <sdl.web@gmail.com>
5124 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5126 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5128 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5130 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5131 for fringe update if it has periodic bitmap.
5132 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5133 and fringe_bitmap_periodic_p.
5135 * fringe.c (get_fringe_bitmap_data): New function.
5136 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5137 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5138 row. Mark glyph row for fringe update if periodicity changed.
5140 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5141 for fringe update unless it has periodic bitmap.
5143 2011-05-25 Kenichi Handa <handa@m17n.org>
5145 * xdisp.c (get_next_display_element): Set correct it->face_id for
5146 a static composition.
5148 2011-05-24 Leo Liu <sdl.web@gmail.com>
5151 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5153 * fns.c (crypto_hash_function, Fsha1): New function.
5154 (Fmd5): Use crypto_hash_function.
5155 (syms_of_fns): Add Ssha1.
5157 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5159 * gnutls.c: Remove unused macros.
5160 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5161 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5162 Remove macros that are defined and never used.
5163 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5165 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5167 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5168 (Fx_get_selection_internal): Minor cleanup.
5169 (Fx_own_selection_internal): Rename arguments for consistency with
5172 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5174 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5176 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5178 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5180 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5182 * dispnew.c (scrolling_window): Don't exclude the case that the
5183 last enabled row in the desired matrix touches the bottom boundary.
5185 2011-05-21 Glenn Morris <rgm@gnu.org>
5187 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5188 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5189 and add some more files.
5191 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5193 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5194 report_file_error introduced by the change from 2011-05-07.
5196 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5198 * systime.h (Time): Define only if emacs is defined.
5199 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5200 where the include path doesn't have X11/X.h by default. See
5201 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5203 2011-05-20 Kenichi Handa <handa@m17n.org>
5205 * composite.c (find_automatic_composition): Fix previous change.
5207 2011-05-20 Glenn Morris <rgm@gnu.org>
5209 * lisp.mk: New file, split from Makefile.in.
5210 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5211 (shortlisp): Remove.
5212 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5214 2011-05-19 Glenn Morris <rgm@gnu.org>
5216 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5217 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5218 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5219 (lisp): Set the order to that of loadup.el.
5220 (shortlisp): Make it a copy of $lisp.
5221 (SOME_MACHINE_LISP): Remove.
5222 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5223 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5225 2011-05-18 Kenichi Handa <handa@m17n.org>
5227 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5228 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5229 (find_automatic_composition): Mostly rewrite for efficiency.
5231 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5233 * makefile.w32-in: Update dependencies.
5235 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5237 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5238 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5240 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5242 Fix some integer overflow issues, such as string length overflow.
5244 * insdel.c (count_size_as_multibyte): Check for string overflow.
5246 * character.c (lisp_string_width): Check for string overflow.
5247 Use EMACS_INT, not int, for string indexes and lengths; in
5248 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5249 the resulting string length overflows an EMACS_INT; instead,
5250 report a string overflow if no precision given. When checking for
5251 precision exhaustion, use a check that cannot possibly have
5252 integer overflow. (Bug#8675)
5253 * character.h (lisp_string_width): Adjust to new signature.
5255 * alloc.c (string_overflow): New function.
5256 (Fmake_string): Use it. This doesn't change behavior, but saves
5257 a few bytes and will simplify future changes.
5258 * character.c (string_escape_byte8): Likewise.
5259 * lisp.h (string_overflow): New decl.
5261 Fixups, following up to the user-interface timestamp change.
5262 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5263 for UI timestamps, instead of unsigned long.
5264 * msdos.c (mouse_get_pos): Likewise.
5265 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5266 * w32gui.h (Time): Define by including "systime.h" rather than by
5267 declaring it ourselves. (Bug#8664)
5269 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5270 * image.c (clear_image_cache): Likewise.
5272 * term.c (term_mouse_position): Don't assume time_t wraparound.
5274 Be more systematic about user-interface timestamps.
5275 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5276 and sometimes 'EMACS_UINT', to represent these timestamps.
5277 This change causes it to use 'Time' uniformly, as that's what X uses.
5278 This makes the code easier to follow, and makes it easier to catch
5279 integer overflow bugs such as Bug#8664.
5280 * frame.c (Fmouse_position, Fmouse_pixel_position):
5281 Use Time, not unsigned long, for user-interface timestamps.
5282 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5283 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5284 * keyboard.h (last_event_timestamp): Likewise.
5285 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5286 * menu.h (xmenu_show): Likewise.
5287 * term.c (term_mouse_position): Likewise.
5288 * termhooks.h (struct input_event.timestamp): Likewise.
5289 (struct terminal.mouse_position_hook): Likewise.
5290 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5291 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5292 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5293 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5295 * menu.h, termhooks.h: Include "systime.h", for Time.
5297 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5298 Don't assume that the difference between two unsigned long values
5299 can fit into an integer. At this point, we know button_down_time
5300 <= event->timestamp, so the difference must be nonnegative, so
5301 there's no need to cast the result if double-click-time is
5302 nonnegative, as it should be; check that it's nonnegative, just in
5303 case. This bug is triggered when events are more than 2**31 ms
5304 apart (about 25 days). (Bug#8664)
5306 * xselect.c (last_event_timestamp): Remove duplicate decl.
5307 (x_own_selection): Remove needless cast to unsigned long.
5309 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5310 that always fit in int. Use a sentinel instead of a counter, to
5311 avoid a temp and to allay GCC's concerns about possible int overflow.
5312 * frame.h (struct frame): Use int for menu_bar_items_used
5313 instead of EMACS_INT, since it always fits in int.
5315 * menu.c (grow_menu_items): Check for int overflow.
5317 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5319 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5320 Before, the code was not consistent. These values cannot exceed
5321 2**31 - 1 so there's no need to make them unsigned.
5322 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5323 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5324 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5326 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5328 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5329 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5330 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5331 presumably because the widths might not match.
5333 * window.c (size_window): Avoid needless test at loop start.
5335 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5337 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5339 2011-05-12 Drew Adams <drew.adams@oracle.com>
5341 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5343 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5345 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5346 `width' to `bar_area_x' and `bar_area_width', respectively.
5347 (x_scroll_run): Take account of fringe background extension.
5349 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5350 Rename local vars `left' and `width' to `bar_area_x' and
5351 `bar_area_width', respectively.
5352 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5353 background extension.
5355 2011-05-10 Jim Meyering <meyering@redhat.com>
5357 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5359 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5361 * image.c (Finit_image_library): Return t for built-in image types,
5362 like pbm and xbm. (Bug#8640)
5364 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5366 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5368 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5370 * w32console.c (Fset_screen_color): Doc fix.
5371 (Fget_screen_color): New function.
5372 (syms_of_ntterm): Defsubr it.
5374 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5375 unlink the temporary file if Fcall_process didn't create it in the
5377 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5378 child process will be redirected to a file specified with `:file'.
5379 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5380 cue to call_process_cleanup not to close that handle.
5382 2011-05-07 Ben Key <bkey76@gmail.com>
5384 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5385 one of two shell specific rules, either bootstrap-temacs-CMD or
5386 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5387 to the previous implementation of the bootstrap-temacs rule.
5388 The bootstrap-temacs-CMD rule is similar to the previous
5389 implementation of the bootstrap-temacs rule except that it
5390 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5393 These changes, along with some changes to nt/configure.bat,
5394 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5395 earlier fix to add support for --cflags and --ldflags options
5396 that include quotes so that it works whether make uses cmd or
5399 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
5401 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5402 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5404 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5405 a string. Handle both cases.
5406 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5407 (Fdbus_register_method): Use Qinvalid_function.
5409 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5411 * makefile.w32-in: Update dependencies.
5412 (LISP_H): Add inttypes.h and stdin.h.
5413 (PROCESS_H): Add unistd.h.
5415 2011-05-06 Eli Zaretskii <eliz@gnu.org>
5417 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5418 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5420 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
5422 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5424 * term.c (vfatal): Remove stray call to va_end.
5425 It's not needed and the C Standard doesn't allow it here anyway.
5427 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5428 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5430 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5433 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5435 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5437 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5439 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5441 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5443 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5444 * charset.c (Fdefine_charset_internal): Don't initialize
5445 charset.code_space[15]. The value was garbage, on hosts with
5446 32-bit int (Bug#8600).
5448 * lread.c (read_integer): Be more consistent with string-to-number.
5449 Use string_to_number to do the actual conversion; this avoids
5450 rounding errors and fixes some other screwups. Without this fix,
5451 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5452 (digit_to_number): Move earlier, for benefit of read_integer.
5453 Return -1 if the digit is out of range for the base, -2 if it is
5454 not a digit in any supported base. (Bug#8602)
5456 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5458 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5459 to match comment at start of function. This also removes a
5460 GCC warning about overflow in a 32+64-bit port.
5462 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5464 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5465 Reported by Stefan Monnier in
5466 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
5467 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5468 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
5470 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5471 (EMACS_UINTPTR): Likewise, with uintptr_t.
5473 * lisp.h: Prefer 64-bit EMACS_INT if available.
5474 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5475 on 32-bit hosts that have 64-bit int, so that they can access
5477 However, temporarily disable this change unless the temporary
5478 symbol WIDE_EMACS_INT is defined.
5480 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5482 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5483 This removes an assumption that EMACS_INT and long are the same
5484 width as pointers. The assumption is true for Emacs porting targets
5485 now, but we want to make other targets possible.
5486 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5487 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5488 In the rest of the code, change types of integers that hold casted
5489 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5490 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5491 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5492 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5493 No need to cast type when ORing.
5494 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5495 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5496 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5497 assume EMACS_INT is the same width as char *.
5498 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5499 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5500 Remove no-longer-needed casts.
5501 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5502 (xg_tool_bar_help_callback, xg_make_tool_item):
5503 Use EMACS_INTPTR to hold an integer
5504 that will be cast to void *; this can avoid a GCC warning
5505 if EMACS_INT is not the same width as void *.
5506 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5507 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5508 (current_message_1, set_message_1):
5509 Use a local to convert to proper width without a cast.
5510 * xmenu.c (dialog_selection_callback): Likewise.
5512 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5513 Also, don't assume VALBITS / RAND_BITS is less than 5,
5514 and don't rely on undefined behavior when shifting a 1 left into
5516 * lisp.h (get_random): Change signature to match.
5518 * lread.c (hash_string): Use size_t, not int, for hash computation.
5519 Normally we prefer signed values; but hashing is special, because
5520 it's better to use unsigned division on hash table sizes so that
5521 the remainder is nonnegative. Also, size_t is the natural width
5522 for hashing into memory. The previous code used 'int', which doesn't
5523 retain enough info to hash well into very large tables.
5524 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5526 * dbusbind.c: Don't possibly lose pointer info when converting.
5527 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5528 Use XPNTR rather than XHASH, so that the high-order bits of
5529 the pointer aren't lost when converting through void *.
5531 * eval.c (Fautoload): Don't double-shift a pointer.
5533 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5535 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5537 * gnutls.c (DEF_GNUTLS_FN):
5538 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5540 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5542 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5545 2011-05-05 Eli Zaretskii <eliz@gnu.org>
5547 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5548 New version that can reserve upto 2GB of heap space.
5550 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
5552 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5554 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5556 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5557 `gnutls_certificate_set_x509_key_file'.
5559 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
5561 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5562 Update dependencies.
5564 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5566 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5567 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5568 Remove unused parameter `fildes'.
5569 * process.c (read_process_output, send_process): Don't pass it.
5571 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5573 Fix previous change: the library cache is defined in w32.c.
5574 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5575 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5577 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5579 Implement dynamic loading of GnuTLS on Windows.
5581 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5582 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5583 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5586 * gnutls.c (Qgnutls_dll): Define.
5587 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5588 (gnutls_*): Declare function pointers.
5589 (init_gnutls_functions): New function to initialize function pointers.
5590 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5591 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5592 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5593 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5594 (emacs_gnutls_write, emacs_gnutls_read)
5595 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5596 (Fgnutls_available_p): New function.
5597 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5598 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5599 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5601 * image.c: Include w32.h.
5602 (Vimage_type_cache): Delete.
5603 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5604 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5605 (w32_delayed_load): Move to w32.c.
5607 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5609 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5610 (w32_delayed_load): Move from image.c. When loading a library, record
5611 its filename in the :loaded-from property of the library id.
5612 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5613 Initialize and staticpro them.
5614 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5616 * process.c: Include lisp.h before w32.h, not after.
5617 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5618 instead of gnutls_record_check_pending.
5620 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5622 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5624 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5625 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5628 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5630 * xterm.c (x_set_frame_alpha): Do not set property on anything
5631 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5633 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5635 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5637 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5639 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5640 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5641 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5642 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5643 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5644 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5645 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5646 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5647 (Qgnutls_bootprop_callbacks_verify): Make static.
5649 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5651 * callproc.c: Indentation fixup.
5653 * sysdep.c (wait_for_termination_1): Make static.
5654 (wait_for_termination, interruptible_wait_for_termination):
5655 Move after wait_for_termination_1.
5657 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5659 * sysdep.c (interruptible_wait_for_termination): New function
5660 which is like wait_for_termination, but allows keyboard
5663 * callproc.c (Fcall_process): Add (:file "file") as an option for
5665 (Fcall_process_region): Ditto.
5667 2011-04-30 Eli Zaretskii <eliz@gnu.org>
5669 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5670 rather than `XVECTOR (FOO)->size'.
5672 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5673 inttypes.h, as a gnulib replacement is used if it not available in
5676 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5678 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5679 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5680 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5682 * coding.c (coding_alloc_by_realloc): Error out if destination
5683 will grow beyond MOST_POSITIVE_FIXNUM.
5684 (decode_coding_emacs_mule): Abort if there isn't enough place in
5685 charbuf for the composition carryover bytes. Reserve an extra
5686 space for up to 2 characters produced in a loop.
5687 (decode_coding_iso_2022): Abort if there isn't enough place in
5688 charbuf for the composition carryover bytes.
5690 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5692 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5693 aborting when %lld or %lll format is passed.
5694 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5695 %llo or %llx format is passed. (Bug#8545)
5697 * window.c (window_scroll_line_based): Use a marker instead of
5698 simple variables to record original value of point. (Bug#7952)
5700 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5701 produced by %s or %c overflows available buffer space. (Bug#8545)
5703 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5705 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5706 (SIZE_MAX): Move defn after all includes, as they might #define it.
5708 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5710 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5712 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5714 * keyboard.c (Qdelayed_warnings_hook): Define.
5715 (command_loop_1): Run `delayed-warnings-hook'
5716 if Vdelayed_warnings_list is non-nil.
5717 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5718 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5720 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5722 * doprnt.c (doprnt): Don't return value smaller than the buffer
5723 size if the message was truncated. (Bug#8545).
5725 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5727 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5728 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5730 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5732 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5734 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5736 * makefile.w32-in: Update dependencies.
5738 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5740 Improve `doprnt' and its usage. (Bug#8545)
5741 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5742 `format_end'. Remove support for %l as a conversion specifier.
5743 Don't use xrealloc. Improve diagnostics when the %l size modifier
5744 is used. Update the commentary.
5746 * eval.c (verror): Simplify calculation of size_t.
5748 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5751 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5753 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5756 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5758 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5759 This makes this file independent of the recent pseudovector change.
5761 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5763 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5765 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5766 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5767 Remove unused local.
5768 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5770 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5771 GCC 4.6.0 optimizes based on type-based alias analysis.
5772 For example, if b is of type struct buffer * and v of type struct
5773 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5774 != &v->size, and therefore "v->size = 1; b->size = 2; return
5775 v->size;" must therefore return 1. This assumption is incorrect
5776 for Emacs, since it type-puns struct Lisp_Vector * with many other
5777 types. To fix this problem, this patch adds a new type struct
5778 vectorlike_header that documents the constraints on layout of vectors
5779 and pseudovectors, and helps optimizing compilers not get fooled
5780 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5781 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5782 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5784 (XSETPVECTYPE): Rewrite in terms of new macro.
5785 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5786 This is a bit clearer, and further avoids the possibility of
5787 undesirable aliasing.
5788 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5789 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5790 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5791 since Lisp_Subr is a special case (no "next" field).
5792 (ASIZE): Now uses header.size rather than size.
5793 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5794 to avoid the hassle of writing XVECTOR (foo)->header.size.
5795 (struct vectorlike_header): New type.
5796 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5797 object, to help avoid aliasing.
5798 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5799 (SUBRP): Likewise, since Lisp_Subr is a special case.
5800 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5801 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5802 (struct Lisp_Hash_Table): Combine first two members into a single
5803 struct vectorlike_header member. All uses of "size" and "next" members
5804 changed to be "header.size" and "header.next".
5805 * buffer.h (struct buffer): Likewise.
5806 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5807 * frame.h (struct frame): Likewise.
5808 * process.h (struct Lisp_Process): Likewise.
5809 * termhooks.h (struct terminal): Likewise.
5810 * window.c (struct save_window_data, struct saved_window): Likewise.
5811 * window.h (struct window): Likewise.
5812 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5813 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5814 * buffer.c (init_buffer_once): Likewise.
5815 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5817 * process.c (Fformat_network_address): Use local var for size,
5820 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5822 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5823 * data.c (atof): Remove decl; no longer used or needed.
5824 (digit_to_number): Move to lread.c.
5825 (Fstring_to_number): Use new string_to_number function, to be
5826 consistent with how the Lisp reader treats infinities and NaNs.
5827 Do not assume that floating-point numbers represent EMACS_INT
5828 without losing information; this is not true on most 64-bit hosts.
5829 Avoid double-rounding errors, by insisting on integers when
5830 parsing non-base-10 numbers, as the documentation specifies.
5831 * lisp.h (string_to_number): New decl, replacing ...
5832 (isfloat_string): Remove.
5833 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5834 (read1): Do not accept +. and -. as integers; this
5835 appears to have been a coding error. Similarly, do not accept
5836 strings like +-1e0 as floating point numbers. Do not report
5837 overflow for integer overflows unless the base is not 10 which
5838 means we have no simple and reliable way to continue.
5839 Break out the floating-point parsing into a new
5840 function string_to_number, so that Fstring_to_number parses
5841 floating point numbers consistently with the Lisp reader.
5842 (digit_to_number): Move here from data.c. Make it static inline.
5843 (E_CHAR, EXP_INT): Remove, replacing with ...
5844 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5845 (string_to_number): New function, replacing isfloat_string.
5846 This function checks for valid syntax and produces the resulting
5847 Lisp float number too. Rework it so that string-to-number
5848 no longer mishandles examples like "1.0e+". Use strtoumax,
5849 so that overflow for non-base-10 numbers is reported only when
5850 there's no portable and simple way to convert to floating point.
5852 * textprop.c (set_text_properties_1): Rewrite for clarity,
5853 and to avoid GCC warning about integer overflow.
5855 * intervals.h (struct interval): Use EMACS_INT for members
5856 where EMACS_UINT might cause problems. See
5857 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5858 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5859 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5861 (offset_intervals): Tell GCC not to worry about length overflow
5862 when negating a negative length.
5864 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5865 (overrun_check_free): Likewise.
5867 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5868 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5871 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5872 (gnutls_make_error): Rename local to avoid shadowing.
5873 (gnutls_emacs_global_deinit): ifdef out; not used.
5874 (Fgnutls_boot): Use const for pointer to readonly storage.
5875 Comment out unused local. Fix pointer signedness problems.
5877 * lread.c (openp): Don't stuff size_t into an 'int'.
5878 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5879 about possible signed overflow.
5881 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5882 (GDK_KEY_g): Don't define if already defined.
5883 (xg_prepare_tooltip): Avoid pointer signedness problem.
5884 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5886 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5887 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5889 * xfns.c (Fx_window_property): Simplify a bit,
5890 to make a bit faster and to avoid GCC 4.6.0 warning.
5891 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5893 * fns.c (internal_equal): Don't assume size_t fits in int.
5895 * alloc.c (compact_small_strings): Tighten assertion a little.
5897 Replace pEd with more-general pI, and fix some printf arg casts.
5898 * lisp.h (pI): New macro, generalizing old pEd macro to other
5899 conversion specifiers. For example, use "...%"pI"d..." rather
5900 than "...%"pEd"...".
5901 (pEd): Remove. All uses replaced with similar uses of pI.
5902 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5903 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5904 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5905 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5906 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5907 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5908 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5910 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5911 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5912 * print.c (safe_debug_print, print_object): Likewise.
5913 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5915 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5916 avoiding the 0 flag, which is not portable.
5917 * process.c (Fmake_network_process): Use pI to avoid cast.
5918 * region-cache.c (pp_cache): Likewise.
5919 * xdisp.c (decode_mode_spec): Likewise.
5920 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5921 behavior on 64-bit hosts with printf arg.
5922 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5923 (x_stop_queuing_selection_requests): Likewise.
5924 (x_get_window_property): Don't truncate byte count to an 'int'
5927 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5928 here, since it parses constructs like leading '-' and spaces,
5929 which are not wanted; and it overflows with large numbers.
5930 Instead, simply match F[0-9]+, which is what is wanted anyway.
5932 * alloc.c: Remove unportable assumptions about struct layout.
5933 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5934 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5935 (allocate_vectorlike, make_pure_vector): Use the new macros,
5936 plus offsetof, to remove unportable assumptions about struct layout.
5937 These assumptions hold on all porting targets that I know of, but
5938 they are not guaranteed, they're easy to remove, and removing them
5939 makes further changes easier.
5941 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5942 This doesn't fix a bug but makes the code clearer.
5943 (string_overrun_cookie): Now const. Use initializers that
5944 don't formally overflow signed char, to avoid warnings.
5945 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5946 can cause Emacs to crash when string overrun checking is enabled.
5947 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5948 multiple of sizeof (EMACS_INT); it need not be, if
5949 alignof(EMACS_INT) < sizeof (EMACS_INT).
5950 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5952 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5954 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5956 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5958 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5959 supposed to be handshaking. (Bug#8556)
5960 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5962 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5964 * lisp.h (Qdebug): List symbol.
5965 * eval.c (Qdebug): Restore global linkage.
5966 * keyboard.c (debug-on-event): New variable.
5967 (handle_user_signal): Break into debugger when debug-on-event
5968 matches the current signal symbol.
5970 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5972 * alloc.c (check_sblock, check_string_bytes)
5973 (check_string_free_list): Convert to standard C.
5975 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5977 * w32.c (emacs_gnutls_push): Fix typo.
5979 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5981 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5982 "cast to pointer from integer of different size".
5984 Improve doprnt and its use in verror. (Bug#8545)
5985 * doprnt.c (doprnt): Document the set of format control sequences
5986 supported by the function. Use SAFE_ALLOCA instead of always
5989 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5990 is one byte too soon. Don't use xrealloc; instead xfree and
5993 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5995 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5998 * gnutls.c: Renamed global_initialized to
5999 gnutls_global_initialized. Added internals for the
6000 :verify-hostname-error, :verify-error, and :verify-flags
6001 parameters of `gnutls-boot' and documented those parameters in the
6002 docstring. Start callback support.
6003 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6004 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6005 on error. Return error code.
6006 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6007 (emacs_gnutls_read): Likewise.
6008 (Fgnutls_boot): Return handshake error code.
6009 (emacs_gnutls_handle_error): New function.
6010 (wsaerror_to_errno): Likewise.
6012 * w32.h (emacs_gnutls_pull): Add prototype.
6013 (emacs_gnutls_push): Likewise.
6015 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6016 (emacs_gnutls_push): Likewise.
6018 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6020 * process.c (wait_reading_process_output): Check if GnuTLS
6021 buffered some data internally if no FDs are set for TLS
6024 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6025 (LIBS): Link to USER_LIBS.
6026 ($(BLD)/gnutls.$(0)): New target.
6028 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6030 * xdisp.c (handle_single_display_spec): Rename the
6031 display_replaced_before_p argument into display_replaced_p, to
6032 make it consistent with the commentary. Fix typos in the
6035 * textprop.c (syms_of_textprop): Remove dead code.
6036 (copy_text_properties): Delete obsolete commentary about an
6037 interface that was deleted long ago. Fix typos in the description
6040 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6041 to changes in oldXMenu/XMenu.h from 2011-04-16.
6042 <menu_help_message, prev_menu_help_message>: Constify.
6043 (IT_menu_make_room): menu->help_text is now `const char **';
6046 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6047 to changes in oldXMenu/XMenu.h from 2011-04-16.
6048 (struct XMenu): Declare `help_text' `const char **'.
6050 * xfaces.c <Qunspecified>: Make extern again.
6052 * syntax.c: Include sys/types.h before including regex.h, as
6055 * doc.c (get_doc_string): Improve the format passed to `error'.
6057 * doprnt.c (doprnt): Improve commentary.
6059 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6061 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6064 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6065 changes in globals.h immediately force recompilation.
6066 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6067 $(CURDIR)/s/ms-w32.h.
6068 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6070 * character.c (Fchar_direction): Function deleted.
6071 (syms_of_character): Don't defsubr it.
6072 <char-direction-table>: Deleted.
6074 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6076 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6077 * doprnt.c: Include limits.h.
6078 (SIZE_MAX): New macro.
6079 (doprnt): Return a size_t value. 2nd arg is now size_t.
6080 Many local variables are now size_t instead of int or unsigned.
6081 Improve overflow protection. Support `l' modifier for integer
6082 conversions. Support %l conversion. Don't assume an EMACS_INT
6083 argument for integer conversions and for %c.
6085 * lisp.h (doprnt): Restore prototype.
6087 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6090 * Makefile.in (base_obj): Add back doprnt.o.
6092 * deps.mk (doprnt.o): Add back prerequisites.
6093 (callint.o): Depend on character.h.
6095 * eval.c (internal_lisp_condition_case): Include the handler
6096 representation in the error message.
6097 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6098 when breaking from the loop.
6100 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6102 * callint.c (Fcall_interactively): When displaying error message
6103 about invalid control letter, pass the character's codepoint, not
6104 a pointer to its multibyte form. Improve display of the character
6105 in octal and display also its hex code.
6107 * character.c (char_string): Use %x to display the (unsigned)
6108 codepoint of an invalid character, to avoid displaying a bogus
6111 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6112 `error', not SYMBOL_NAME itself.
6114 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6115 character arguments to `error'.
6117 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6118 to `error' in error message about FINAL_CHAR argument. Make sure
6119 FINAL_CHAR is a character, and use %c when it is passed as
6120 argument to `error'.
6122 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6124 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6126 * w32.c: Include <time.h>.
6127 (sys_localtime): New function.
6129 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6131 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6133 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6135 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6137 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6140 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6142 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6143 gl_state.e_property when gl_state.object is Qt.
6145 * insdel.c (make_gap_larger): Remove limitation of buffer size
6148 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6150 * xdisp.c (lookup_glyphless_char_display)
6151 (produce_glyphless_glyph): Handle cons cell entry in
6152 glyphless-char-display.
6153 (Vglyphless_char_display): Document it.
6155 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6156 glyphless-char-display.
6158 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6160 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6162 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6164 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6165 definition for no-X builds.
6167 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6169 Static checks with GCC 4.6.0 and non-default toolkits.
6171 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6173 * process.c (keyboard_bit_set): Define only if SIGIO.
6174 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6175 (send_process): Repair possible setjmp clobbering.
6177 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6179 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6181 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6183 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6184 Define only if needed.
6186 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6187 by pacifying GCC about it. Maybe it's time to retire it?
6188 * xfaces.c (USG, __TIMEVAL__): Likewise.
6190 * dispextern.h (struct redisplay_interface): Rename param
6192 * termhooks.h (struct terminal): Likewise.
6193 * xterm.c (xembed_send_message): Likewise.
6195 * insdel.c (make_gap_smaller): Define only if
6196 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6198 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6201 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6202 so that we aren't warned about unused symbols.
6204 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6206 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6208 * xfns.c (x_real_positions): Mark locals as initialized.
6210 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6212 * xterm.c: Fix problems found by static analysis with other toolkits.
6213 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6214 (x_dispatch_event): Declare static if USE_GTK, and
6215 define if USE_GTK || USE_X_TOOLKIT.
6216 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6217 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6218 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6219 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6221 * xmenu.c (menu_help_callback): Pointer type fixes.
6222 Use const pointers when pointing at readonly data. Avoid pointer
6224 (FALSE): Remove unused macro.
6225 (update_frame_menubar): Remove unused decl.
6227 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6229 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6230 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6231 (single_menu_item): Rename local to avoid shadowing.
6233 * keyboard.c (make_lispy_event): Remove unused local var.
6235 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6236 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6238 * bitmaps: Change bitmaps from unsigned char back to the X11
6239 compatible char. Avoid the old compiler warnings about
6240 out-of-range initializers by using, for example, '\xab' rather
6243 * xgselect.c (xgselect_initialize): Check vs interface
6244 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6246 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6248 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6249 to read-only memory.
6251 * fns.c (vector): Remove; this old hack is no longer needed.
6253 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6255 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6257 * xrdb.c (x_load_resources): Omit unused local.
6259 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6260 (x_window): Rename locals to avoid shadowing.
6261 (USG): Use the kludged USG macro, to pacify gcc.
6263 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6264 (x_term_init): Remove local to avoid shadowing.
6266 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6268 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6269 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6271 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6273 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6275 Fix regex.c, syntax.c and friends for buffers > 2GB.
6276 * syntax.h (struct gl_state_s): Declare character position members
6279 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6281 * textprop.c (verify_interval_modification, interval_of):
6282 Declare arguments EMACS_INT.
6284 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6287 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6289 * indent.c (Fvertical_motion): Local variable it_start is now
6292 * regex.c (re_match, re_match_2, re_match_2_internal)
6293 (bcmp_translate, regcomp, regexec, print_double_string)
6294 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6295 (re_compile_pattern, re_exec): Declare arguments and local
6296 variables `size_t' and `ssize_t' and return values `regoff_t', as
6298 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6299 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6300 <compile_stack_type>: `size' and `avail' are now `size_t'.
6302 * regex.h <regoff_t>: Use ssize_t, not int.
6303 (re_search, re_search_2, re_match, re_match_2): Arguments that
6304 specify buffer/string position and length are now ssize_t and
6305 size_t. Return type is regoff_t.
6307 2011-04-16 Ben Key <bkey76@gmail.com>
6309 * nsfont.m: Fixed bugs in ns_get_family and
6310 ns_descriptor_to_entity that were caused by using free to
6311 deallocate memory blocks that were allocated by xmalloc (via
6312 xstrdup). This caused Emacs to crash when compiled with
6313 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6314 --enable-checking=xmallocoverrun). xfree is now used to
6315 deallocate these memory blocks.
6317 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6319 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6321 emacs_write: Accept and return EMACS_INT for sizes.
6322 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6324 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6325 Accept and return EMACS_INT.
6326 (emacs_gnutls_write): Return the number of bytes written on
6328 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6329 (emacs_read, emacs_write): Remove check for negative size, as the
6330 Emacs source code has been audited now.
6331 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6332 (emacs_read, emacs_write): Use it.
6333 * process.c (send_process): Adjust to the new signatures of
6334 emacs_write and emacs_gnutls_write. Do not attempt to store
6335 a byte offset into an 'int'; it might overflow.
6336 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6338 * sound.c: Don't assume sizes fit in 'int'.
6339 (struct sound_device.period_size, alsa_period_size):
6340 Return EMACS_INT, not int.
6341 (struct sound_device.write, vox_write, alsa_write):
6342 Accept EMACS_INT, not int.
6343 (wav_play, au_play): Use EMACS_INT to store sizes and to
6344 record read return values.
6346 2011-04-15 Ben Key <bkey76@gmail.com>
6348 * keyboard.c (Qundefined): Don't declare static since it is used
6350 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6351 static since they are used in nsfont.m.
6353 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6355 * process.c (Qprocessp): Don't declare static.
6356 * lisp.h (Qprocessp): Declare again.
6358 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6360 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6362 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6364 Improve C-level modularity by making more things 'static'.
6366 Don't publish debugger-only interfaces to other modules.
6367 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6368 (verify_bytepos, count_markers): Move decls to the only modules
6370 * region-cache.h (pp_cache): Likewise.
6371 * window.h (check_all_windows): Likewise.
6372 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6374 * sysdep.c (croak): Now static, if
6375 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6376 * syssignal.h (croak): Declare only if not static.
6378 * alloc.c (refill_memory_reserve): Now static if
6379 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6380 * lisp.h (refill_memory_reserve): Declare only if not static.
6382 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6383 Define only if USE_LUCID.
6385 * xrdb.c (x_customization_string, x_rm_string): Now static.
6387 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6388 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6390 * xdisp.c (draw_row_with_mouse_face): Now static.
6391 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6393 * window.h (check_all_windows): Mark externally visible.
6395 * window.c (window_deletion_count): Now static.
6397 * undo.c: Make symbols static if they're not exported.
6398 (last_undo_buffer, last_boundary_position, pending_boundary):
6401 * textprop.c (interval_insert_behind_hooks): Now static.
6402 (interval_insert_in_front_hooks): Likewise.
6404 * term.c: Make symbols static if they're not exported.
6405 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6406 (max_frame_lines, tty_set_terminal_modes):
6407 (tty_reset_terminal_modes, tty_turn_off_highlight):
6408 (get_tty_terminal): Now static.
6409 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6410 * termhooks.h (term_mouse_moveto): Do not declare if
6412 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6413 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6415 * sysdep.c: Make symbols static if they're not exported.
6416 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6418 (sigprocmask_set, full_mask): Remove; unused.
6419 (wait_debugging): Mark as visible.
6420 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6421 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6423 * syntax.c (syntax_temp): Define only if !__GNUC__.
6425 * sound.c (current_sound_device, current_sound): Now static.
6427 * search.c (searchbufs, searchbuf_head): Now static.
6429 * scroll.c (scroll_cost): Remove; unused.
6430 * dispextern.h (scroll_cost): Remove decl.
6432 * region-cache.h (pp_cache): Mark as externally visible.
6434 * process.c: Make symbols static if they're not exported.
6435 (process_tick, update_tick, create_process, chan_process):
6436 (Vprocess_alist, proc_buffered_char, datagram_access):
6437 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6438 (deactivate_process): Mark defn as static, as well as decl.
6439 * lisp.h (create_process): Remove decl.
6440 * process.h (chan_process, Vprocess_alist): Remove decls.
6442 * print.c: Make symbols static if they're not exported.
6443 (print_depth, new_backquote_output, being_printed, print_buffer):
6444 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6445 (print_interval, print_number_index, initial_stderr_stream):
6447 * lisp.h (Fprinc): Remove decl.
6448 (debug_output_compilation_hack): Mark as externally visible.
6450 * sysdep.c (croak): Move decl from here to syssignal.h.
6451 * syssignal.h (croak): Put it here, so the API can be checked when
6452 'croak' is called from dissociate_if_controlling_tty.
6454 * minibuf.c: Make symbols static if they're not exported.
6455 (minibuf_save_list, choose_minibuf_frame): Now static.
6456 * lisp.h (choose_minibuf_frame): Remove decl.
6458 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6460 * lread.c: Make symbols static if they're not exported.
6461 (read_objects, initial_obarray, oblookup_last_bucket_number):
6463 (make_symbol): Remove; unused.
6464 * lisp.h (initial_obarray, make_symbol): Remove decls.
6466 * keyboard.c: Make symbols static if they're not exported.
6467 (single_kboard, recent_keys_index, total_keys, recent_keys):
6468 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6469 (this_single_command_key_start, echoing, last_auto_save):
6470 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6471 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6472 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6473 (Vlispy_mouse_stem, double_click_count):
6475 (force_auto_save_soon): Define only if SIGDANGER.
6476 (ignore_mouse_drag_p): Now static if
6477 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6478 (print_help): Remove; unused.
6479 (stop_character, last_timer_event): Mark as externally visible.
6480 * keyboard.h (ignore_mouse_drag_p): Declare only if
6481 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6482 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6483 * lisp.h (echoing): Remove decl.
6484 (force_auto_save_soon): Declare only if SIGDANGER.
6485 * xdisp.c (redisplay_window): Simplify code, to make it more
6486 obvious that ignore_mouse_drag_p is not accessed if !defined
6487 USE_GTK && !defined HAVE_NS.
6489 * intervals.c: Make symbols static if they're not exported.
6490 (merge_properties_sticky, merge_interval_right, delete_interval):
6492 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6494 * insdel.c: Make symbols static if they're not exported.
6495 However, leave prepare_to_modify_buffer alone. It's never
6496 called from outside this function, but that appears to be a bug.
6497 (combine_after_change_list, combine_after_change_buffer):
6498 (adjust_after_replace, signal_before_change): Now static.
6499 (adjust_after_replace_noundo): Remove; unused.
6500 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
6501 (signal_before_change): Remove decls.
6503 * indent.c (val_compute_motion, val_vmotion): Now static.
6505 * image.c: Make symbols static if they're not exported.
6506 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6508 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6509 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6511 * fringe.c (standard_bitmaps): Now static.
6512 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6514 * frame.c: Make symbols static if they're not exported.
6515 (x_report_frame_params, make_terminal_frame): Now static.
6516 (get_frame_param): Now static, unless HAVE_NS.
6517 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6518 (x_get_resource_string): Remove; not used.
6519 * frame.h (make_terminal_frame, x_report_frame_params):
6520 (x_get_resource_string); Remove decls.
6521 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6522 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6524 * font.c, fontset.c: Make symbols static if they're not exported.
6525 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6526 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6527 * font.c (font_close_object): Now static.
6528 * font.h (font_close_object): Remove.
6529 * fontset.c (FONTSET_OBJLIST): Remove.
6530 (free_realized_fontset) #if-0 the body, which does nothing.
6531 (face_suitable_for_char_p): #if-0, as it's never called.
6532 * fontset.h (face_suitable_for_char_p): Remove decl.
6533 * xfaces.c (face_at_string_position):
6534 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
6535 since 0 is always ASCII.
6537 * fns.c (weak_hash_tables): Now static.
6539 * fileio.c: Make symbols static if they're not exported.
6540 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6541 (Vwrite_region_annotation_buffers): Now static.
6543 * eval.c: Make symbols static if they're not exported.
6544 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6545 * lisp.h (backtrace_list): Remove decl.
6547 * emacs.c: Make symbols static if they're not exported.
6548 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6549 (fatal_error_code, fatal_error_signal_hook, standard_args):
6551 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6552 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6553 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6554 * lisp.h (fatal_error_signal_hook): Remove decl.
6555 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6557 * editfns.c: Move a (normally-unused) function to its only use.
6558 * editfns.c, lisp.h (get_operating_system_release): Remove.
6559 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6560 worth the hassle of breaking this out.
6562 * xterm.c: Make symbols static if they're not exported.
6563 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6564 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6565 (x_destroy_window, x_delete_display):
6567 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6568 (x_mouse_leave): Remove; unused.
6569 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6570 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6571 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6573 (x_mouse_leave): Declare only if WINDOWSNT.
6574 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6575 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6578 * ftxfont.c: Make symbols static if they're not exported.
6579 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6581 * font.h (ftxfont_driver): Likewise.
6583 * xfns.c: Make symbols static if they're not exported.
6584 (x_last_font_name, x_display_info_for_name):
6585 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6586 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6587 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6588 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6589 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6590 (last_show_tip_args): Now static.
6591 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6592 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6593 (x_screen_planes): Remove; unused.
6594 * dispextern.h (x_screen_planes): Remove decl.
6596 * dispnew.c: Make symbols static if they're not exported.
6597 * dispextern.h (redraw_garbaged_frames, scrolling):
6598 (increment_row_positions): Remove.
6599 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6600 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6602 (redraw_garbaged_frames): Remove; unused.
6604 * xfaces.c: Make symbols static if they're not exported.
6605 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6607 * xterm.h (defined_color): Remove decls.
6608 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6609 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6610 (menu_face_changed_default, defined_color, free_realized_face):
6611 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6612 (ascii_face_of_lisp_face): Remove; unused.
6614 * xdisp.c: Make symbols static if they're not exported.
6615 * dispextern.h (scratch_glyph_row, window_box_edges):
6616 (glyph_to_pixel_coords, set_cursor_from_row):
6617 (get_next_display_element, set_iterator_to_next):
6618 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6619 (show_mouse_face): Remove decls
6620 * frame.h (message_buf_print): Likewise.
6621 * lisp.h (pop_message, set_message, check_point_in_composition):
6623 * xterm.h (set_vertical_scroll_bar): Likewise.
6624 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6625 (message_buf_print, scratch_glyph_row, displayed_buffer):
6626 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6627 (get_next_display_element, show_mouse_face, window_box_edges):
6628 (frame_to_window_pixel_xy, check_point_in_composition):
6629 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6630 (glyph_to_pixel_coords): Remove; unused.
6632 * dired.c (file_name_completion): Now static.
6634 * dbusbind.c (xd_in_read_queued_messages): Now static.
6636 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6637 * data.c (circular_list_error): Remove.
6639 * commands.h (last_point_position, last_point_position_buffer):
6640 (last_point_position_window): Remove decls.
6641 * keyboard.c: Make these variables static.
6643 * coding.h (coding, code_convert_region, encode_coding_gap):
6645 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6646 (iso_code_class, detect_coding, code_convert_region): Now static.
6647 (encode_coding_gap): Remove; unused.
6649 * chartab.c (chartab_chars, chartab_bits): Now static.
6651 * charset.h (charset_iso_8859_1): Remove decl.
6652 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6655 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6656 * ccl.c (Vccl_program_table): Now static.
6657 (check_ccl_update): Remove; unused.
6659 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6660 * category.h: ... from here.
6661 * category.c (check_category_table, set_category_set): Now static.
6663 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6664 * lisp.h: Remove these decls.
6666 * buffer.c (buffer_count): Remove unused var.
6668 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6669 so that it's not optimized away.
6670 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6671 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6672 exported only to the debugger.
6674 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
6675 * atimer.h (run_all_atimers): Remove; not exported.
6677 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6678 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6679 was inaccessible from Lisp.
6680 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6681 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6683 alloc.c: Import and export fewer symbols, and remove unused items.
6684 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6686 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6687 it's not optimized away by whole-program optimization.
6688 (message_enable_multibyte, free_misc): Remove.
6689 (catchlist, handlerlist, mark_backtrace):
6690 Declare only if BYTE_MARK_STACK.
6691 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6692 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6693 (message_enable_multibyte): Remove decl.
6694 (free_misc, interval_free_list, float_block, float_block_index):
6695 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6696 (cons_free_list, last_marked_index):
6698 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6699 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6700 (mark_backtrace): Define only if BYTE_MARK_STACK.
6701 * xdisp.c (message_enable_multibyte): Now static.
6703 Declare Lisp_Object Q* variables to be 'static' if not exported.
6704 This makes it easier for human readers (and static analyzers)
6705 to see whether these variables are used from other modules.
6706 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6707 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6708 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6709 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6710 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6711 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6712 * xmenu.c, xselect.c:
6713 Declare Q* vars static if they are not used in other modules.
6714 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6715 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6716 Remove decls of unexported vars.
6717 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6719 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6721 Make Emacs functions such as Fatom 'static' by default.
6722 This makes it easier for human readers (and static analyzers)
6723 to see whether these functions can be called from other modules.
6724 DEFUN now defines a static function. To make the function external
6725 so that it can be used in other C modules, use the new macro DEFUE.
6726 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6727 (Finit_image_library):
6728 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6729 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6730 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6731 Remove decls, since these functions are now static.
6732 (Funintern, Fget_internal_run_time): New decls, since these functions
6733 were already external.
6735 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6736 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6737 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6738 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6739 * keyboard.c, keymap.c, lread.c:
6740 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6741 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6742 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6743 Mark functions with DEFUE instead of DEFUN,
6744 if they are used in other modules.
6745 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6746 decls for now-static functions.
6747 * buffer.h (Fdelete_overlay): Remove decl.
6748 * callproc.c (Fgetenv_internal): Mark as internal.
6749 * composite.c (Fremove_list_of_text_properties): Remove decl.
6750 (Fcomposition_get_gstring): New forward static decl.
6751 * composite.h (Fcomposite_get_gstring): Remove decl.
6752 * dired.c (Ffile_attributes): New forward static decl.
6753 * doc.c (Fdocumntation_property): New forward static decl.
6754 * eval.c (Ffetch_bytecode): New forward static decl.
6755 (Funintern): Remove extern decl; now in .h file where it belongs.
6756 * fileio.c (Fmake_symbolic_link): New forward static decl.
6757 * image.c (Finit_image_library): New forward static decl.
6758 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6759 * intervals.h (Fprevious_property_change):
6760 (Fremove_list_of_text_properties): Remove decls.
6761 * keyboard.c (Fthis_command_keys): Remove decl.
6762 (Fcommand_execute): New forward static decl.
6763 * keymap.c (Flookup_key): New forward static decl.
6764 (Fcopy_keymap): Now static.
6765 * keymap.h (Flookup_key): Remove decl.
6766 * process.c (Fget_process): New forward static decl.
6767 (Fprocess_datagram_address): Mark as internal.
6768 * syntax.c (Fsyntax_table_p): New forward static decl.
6769 (skip_chars): Remove duplicate decl.
6770 * textprop.c (Fprevious_property_change): New forward static decl.
6771 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6773 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6774 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6776 * editfns.c (Fformat): Remove unreachable code.
6778 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6780 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6783 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6785 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6786 when at ZV. (Bug#8487)
6788 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6790 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6792 * keyboard.c (parse_tool_bar_item): Likewise.
6793 * sound.c (sound_cleanup, alsa_close): Likewise.
6794 * termcap.c (tgetent): Likewise.
6795 * xfns.c (x_default_font_parameter): Likewise.
6796 * xsettings.c (read_and_apply_settings): Likewise.
6798 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6799 (overrun_check_free): Protoize.
6801 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6803 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6804 since callers should never pass a negative size.
6805 Change the signature to match that of plain 'read' and 'write'; see
6806 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6807 * lisp.h: Update prototypes of emacs_write and emacs_read.
6809 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6811 * xdisp.c (redisplay_window): Don't try to determine the character
6812 position of the scroll margin if the window start point w->startp
6813 is outside the buffer's accessible region. (Bug#8468)
6815 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6817 Fix write-region and its subroutines for buffers > 2GB.
6818 * fileio.c (a_write, e_write): Modify declaration of arguments and
6819 local variables to support buffers larger than 2GB.
6820 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6822 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6823 argument, local variables, and return value.
6825 * lisp.h: Update prototypes of emacs_write and emacs_read.
6827 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6829 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6831 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6833 Fix more problems found by GCC 4.6.0's static checks.
6835 * xdisp.c (vmessage): Use a better test for character truncation.
6837 * charset.c (load_charset_map): <, not <=, for optimization,
6838 and to avoid potential problems with integer overflow.
6839 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6840 * casetab.c (set_identity, shuffle): Likewise.
6841 * editfns.c (Fformat): Likewise.
6842 * syntax.c (skip_chars): Likewise.
6844 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6845 This also lets GCC 4.6.0 generate slightly better loop code.
6847 * callint.c (Fcall_interactively): <, not <=, for optimization.
6848 (Fcall_interactively): Count the number of arguments produced,
6849 not the number of arguments given. This is simpler and lets GCC
6850 4.6.0 generate slightly better code.
6852 * ftfont.c: Distingish more carefully between FcChar8 and char.
6853 The previous code passed unsigned char * to a functions like
6854 strlen and xstrcasecmp that expect char *, which does not
6855 conform to the C standard.
6856 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6857 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6858 char * when the C standard requires it.
6860 * keyboard.c (read_char): Remove unused var.
6862 * eval.c: Port to Windows vsnprintf (Bug#8435).
6864 (SIZE_MAX): Define if the headers do not.
6865 (verror): Do not give up if vsnprintf returns a negative count.
6866 Instead, grow the buffer. This ports to Windows vsnprintf, which
6867 does not conform to C99. Problem reported by Eli Zaretskii.
6868 Also, simplify the allocation scheme, by avoiding the need for
6869 calling realloc, and removing the ALLOCATED variable.
6871 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6873 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6874 But keep the doprint source code for now, as we might revamp it
6875 and use it again (Bug#8435).
6876 * lisp.h (doprnt): Remove.
6877 * Makefile.in (base_obj): Remove doprnt.o.
6878 * deps.mk (doprnt.o): Remove.
6880 error: Print 32- and 64-bit integers portably (Bug#8435).
6881 Without this change, on typical 64-bit hosts error ("...%d...", N)
6882 was used to print both 32- and 64-bit integers N, which relied on
6884 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6886 * lisp.h (error, verror): Mark as printf-like functions.
6887 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6888 Report overflow in size calculations when allocating printf buffer.
6889 Do not truncate output string at its first null byte.
6890 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6891 Truncate the output at a character boundary, since vsnprintf does not
6893 * charset.c (check_iso_charset_parameter): Convert internal
6894 character to string before calling 'error', since %c now has the
6896 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6897 overflow when computing char to be passed to 'error'. Do not
6898 pass Lisp_Object to 'error'; pass the integer instead.
6899 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6900 formatted with plain %d.
6902 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6904 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6906 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6908 * xterm.c (x_catch_errors): Remove duplicate declaration.
6910 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6912 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6914 2011-04-10 Jim Meyering <meyering@redhat.com>
6916 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6917 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6918 return ssize_t not "int", and use size_t as the buffer length.
6919 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6920 * gnutls.h: Update declarations.
6921 * process.c (read_process_output): Use ssize_t, to match.
6922 (send_process): Likewise.
6924 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6926 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6928 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6930 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6931 Use unsigned char, to match FcChar8 type definition.
6933 * xterm.c (handle_one_xevent):
6934 * xmenu.c (create_and_show_popup_menu):
6935 * xselect.c (x_decline_selection_request)
6936 (x_reply_selection_request): Avoid type-punned deref of X events.
6938 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6940 Fix some uses of `int' instead of EMACS_INT.
6941 * search.c (string_match_1, fast_string_match)
6942 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6943 (scan_buffer, find_next_newline_no_quit)
6944 (find_before_next_newline, search_command, Freplace_match)
6945 (Fmatch_data): Make some `int' variables be EMACS_INT.
6947 * xdisp.c (display_count_lines): 3rd argument and return value now
6948 EMACS_INT. All callers changed.
6949 (pint2hrstr): Last argument is now EMACS_INT.
6951 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6952 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6953 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6954 (decode_coding_utf_16, decode_coding_emacs_mule)
6955 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6956 (decode_coding_ccl, decode_coding_charset)
6957 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6958 (decode_coding_iso_2022, decode_coding_emacs_mule)
6959 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6960 <char_offset, last_offset>: Declare EMACS_INT.
6961 (encode_coding_utf_8, encode_coding_utf_16)
6962 (encode_coding_emacs_mule, encode_invocation_designation)
6963 (encode_designation_at_bol, encode_coding_iso_2022)
6964 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6965 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6967 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6968 (encode_invocation_designation): Last argument P_NCHARS is now
6970 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6971 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6973 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6976 * ccl.c (Fccl_execute_on_string): Declare some variables
6979 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6981 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6983 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6985 * process.c (Fformat_network_address): Doc fix.
6987 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6989 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6991 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6993 * keyboard.c (read_char): Call Lisp function help-form-show,
6994 instead of using internal_with_output_to_temp_buffer.
6995 (Qhelp_form_show): New var.
6996 (syms_of_keyboard): Use DEFSYM macro.
6998 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7000 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7002 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7004 * process.c (Flist_processes): Remove to Lisp.
7005 (list_processes_1): Delete.
7007 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7009 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7011 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7013 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7015 Fix more problems found by GCC 4.6.0's static checks.
7017 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7019 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7021 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7023 * xdisp.c (vmessage): Mark as a printf-like function.
7025 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7027 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7029 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7030 printf-like functions.
7031 (tiff_load): Add casts to remove these marks before passing them
7032 to system-supplied API.
7034 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7036 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7037 This avoids several warnings with gcc -Wstrict-overflow.
7038 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7039 directly, rather than having caller test rule sign. This avoids
7040 some unnecessary tests.
7041 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7042 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7043 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7045 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7046 (xfont_open): Avoid unnecessary tests.
7048 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7050 * composite.h, composite.c (composition_gstring_put_cache):
7051 Use EMACS_INT, not int, for length.
7053 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7054 breaking out part of COMPOSITION_DECODE_RULE.
7055 (COMPOSITION_DECODE_RULE): Use it.
7056 * composite.c (get_composition_id): Remove unused local vars,
7057 by using the new macro.
7059 * textprop.c (set_text_properties_1): Change while to do-while,
7060 since the condition is always true at first.
7062 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7063 (interval_deletion_adjustment): Return unsigned value.
7066 * process.c (list_processes_1, create_pty, read_process_output):
7067 (exec_sentinel): Remove vars that were set but not used.
7068 (create_pty): Remove unnecessary "volatile"s.
7069 (Fnetwork_interface_info): Avoid possibility of int overflow.
7070 (read_process_output): Do adaptive read buffering even if carryover.
7071 (read_process_output): Simplify nbytes computation if buffered.
7073 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7075 * syntax.c (scan_words): Remove var that was set but not used.
7076 (update_syntax_table): Use unsigned instead of int.
7078 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7079 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7080 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7082 * print.c (print_error_message): Avoid int overflow.
7084 * font.c (font_list_entities): Redo for clarity,
7085 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7087 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7088 (font_score): Avoid potential overflow in diff calculation.
7090 * fns.c (substring_both): Remove var that is set but not used.
7091 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7093 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7095 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7096 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7097 can always succeed if overflow has undefined behavior.
7099 * search.c (boyer_moore, wordify): Remove vars set but not used.
7100 (wordify): Omit three unnecessary tests.
7102 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7103 All callers changed. This avoids the need for an unused var.
7105 * casefiddle.c (casify_region): Remove var that is set but not used.
7107 * dired.c (file_name_completion): Remove var that is set but not used.
7109 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7111 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7112 (Finsert_file_contents): Remove unnecessary code checking fd.
7114 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7115 Check for integer overflow on size calculations.
7117 * buffer.c (Fprevious_overlay_change): Remove var that is set
7120 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7121 Remove vars that are set but not used.
7122 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7123 (timer_check_2): Mark vars as initialized.
7125 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7127 * image.c (lookup_image): Remove var that is set but not used.
7128 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7130 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7131 that are set but not used.
7133 * xfns.c (make_invisible_cursor): Don't return garbage
7134 if XCreateBitmapFromData fails (Bug#8410).
7136 * xselect.c (x_get_local_selection, x_handle_property_notify):
7137 Remove vars that are set but not used.
7139 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7140 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7142 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7143 Remove var that is set but not used.
7144 (scroll_bar_windows_size): Now size_t, not int.
7145 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7148 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7149 (map_tty_color) [!defined MSDOS]: Likewise.
7151 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7153 * coding.c: Remove vars that are set but not used.
7154 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7155 All callers changed.
7156 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7157 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7158 (decode_coding_charset): Remove vars that are set but not used.
7160 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7161 that is set but not used.
7163 * print.c (print_object): Remove var that is set but not used.
7165 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7166 The gnulib version avoids calling malloc in the usual case,
7167 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7168 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7169 * filelock.c (current_lock_owner): Likewise.
7170 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7171 * sysdep.c: Include allocator.h, careadlinkat.h.
7172 (emacs_no_realloc_allocator): New static constant.
7173 (emacs_readlink): New function.
7174 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7175 ../lib/careadlinkat.h.
7177 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7179 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7180 first non-nil return value).
7182 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7184 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7185 if not defined (Bug#8403).
7187 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7189 * xdisp.c (display_count_lines): Remove parameter `start',
7190 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7191 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7192 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7193 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7194 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7195 and thereabouts. All callers changed.
7196 (get_per_char_metric): Remove parameter `f', unused since
7197 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7199 2011-04-02 Jim Meyering <meyering@redhat.com>
7201 do not dereference NULL upon failed strdup
7202 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7203 (ns_get_family): Likewise.
7205 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7207 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7209 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7211 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7214 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7216 Add lexical binding.
7218 * window.c (Ftemp_output_buffer_show): New fun.
7219 (Fsave_window_excursion):
7220 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7222 * lread.c (lisp_file_lexically_bound_p): New function.
7223 (Fload): Bind Qlexical_binding.
7224 (readevalloop): Remove `evalfun' arg.
7225 Bind Qinternal_interpreter_environment.
7226 (Feval_buffer): Bind Qlexical_binding.
7227 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7229 (syms_of_lread): Declare `lexical-binding'.
7231 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7233 * keyboard.c (eval_dyn): New fun.
7234 (menu_item_eval_property): Use it.
7236 * image.c (parse_image_spec): Use Ffunctionp.
7238 * fns.c (concat, mapcar1): Accept byte-code-functions.
7240 * eval.c (Fsetq): Handle lexical vars.
7241 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7242 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7243 (FletX, Flet): Obey lexical binding.
7244 (Fcommandp): Handle closures.
7245 (Feval): New `lexical' arg.
7246 (eval_sub): New function extracted from Feval. Use it almost
7247 everywhere where Feval was used. Look up vars in lexical env.
7249 (Ffunctionp): Move from subr.el.
7250 (Ffuncall): Handle closures.
7251 (apply_lambda): Remove `eval_flags'.
7252 (funcall_lambda): Handle closures and new byte-code-functions.
7253 (Fspecial_variable_p): New function.
7254 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7255 but without exporting it to Lisp.
7257 * doc.c (Fdocumentation, store_function_docstring):
7258 * data.c (Finteractive_form): Handle closures.
7260 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7263 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7265 (exec_byte_code): New function extracted from Fbyte_code to handle new
7266 calling convention for byte-code-functions. Add new byte-codes.
7268 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7270 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7272 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7274 * xdisp.c (redisplay_internal): Fix prototype.
7276 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7278 * xdisp.c (SCROLL_LIMIT): New macro.
7279 (try_scrolling): Use it when setting scroll_limit.
7280 Limit scrolling to 100 screen lines.
7281 (redisplay_window): Even when falling back on "recentering",
7282 position point in the window according to scroll-conservatively,
7283 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7285 (try_scrolling): When point is above the window, allow searching
7286 as far as scroll_max, or one screenful, to compute vertical
7287 distance from PT to the scroll margin position. This prevents
7288 try_scrolling from unnecessarily failing when
7289 scroll-conservatively is set to a value slightly larger than the
7290 window height. Clean up the case of PT below the margin at bottom
7291 of window: scroll_max can no longer be INT_MAX. When aggressive
7292 scrolling is in use, don't let point enter the opposite scroll
7293 margin as result of the scroll.
7294 (syms_of_xdisp) <scroll-conservatively>: Document the
7295 threshold of 100 lines for never-recentering scrolling.
7297 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7299 * dispextern.h (move_it_by_lines):
7300 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7301 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7302 (message_log_check_duplicate): Remove parameters `prev_bol' and
7303 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7304 (redisplay_internal): Remove parameter `preserve_echo_area',
7305 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7307 * indent.c (Fvertical_motion):
7308 * window.c (window_scroll_pixel_based, Frecenter):
7309 Don't pass `need_y_p' to `move_it_by_lines'.
7311 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7313 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7314 steal a few bits to be more compact.
7315 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7316 Remove unneeded casts.
7318 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7320 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7322 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7323 binding" message (bug#7967).
7325 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7327 Fix more problems found by GCC 4.6.0's static checks.
7329 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7330 Remove unused local var.
7332 * editfns.c (Fmessage_box): Remove unused local var.
7334 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7335 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7336 Omit unused local vars.
7337 * window.c (shrink_windows): Omit unused local var.
7338 * menu.c (digest_single_submenu): Omit unused local var.
7339 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7340 Omit unused local var.
7342 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7343 Don't assume string length fits in int.
7344 (keyremap_step, read_key_sequence): Use size_t for sizes.
7345 (read_key_sequence): Don't check last_real_key_start redundantly.
7347 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7348 instead of alloca (Bug#8344).
7350 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7351 (Fbacktrace_frame): Don't assume nframes fits in int.
7353 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7355 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7358 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7360 * cm.c (calccost): Turn while-do into do-while, for clarity.
7362 * keyboard.c (syms_of_keyboard): Use the same style as later
7363 in this function when indexing through an array. This also
7364 works around GCC bug 48267.
7366 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7368 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7370 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7371 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7373 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7374 This avoids undefined behavior on integer overflow, and is a bit
7375 more convenient anyway since it is compared to a size_t variable.
7377 Variadic C functions now count arguments with size_t, not int.
7378 This avoids an unnecessary limitation on 64-bit machines, which
7379 caused (substring ...) to crash on large vectors (Bug#8344).
7380 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7381 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7382 All variadic functions and their callers changed accordingly.
7383 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7384 * data.c (arith_driver, float_arith_driver): Likewise.
7385 * editfns.c (general_insert_function): Likewise.
7386 * eval.c (struct backtrace.nargs, interactive_p)
7387 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7388 (funcall_lambda, mark_backtrace): Likewise.
7389 * fns.c (concat): Likewise.
7390 * frame.c (x_set_frame_parameters): Likewise.
7391 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7392 0 if not found, not -1. All callers changed.
7394 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7395 (stack_copy_size): Now size_t, not int.
7396 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7398 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7400 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7401 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7402 All callers changed.
7404 * lisp.h (multibyte_char_to_unibyte):
7405 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7406 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7407 * character.h (CHAR_TO_BYTE8):
7408 * cmds.c (internal_self_insert):
7409 * editfns.c (general_insert_function):
7410 * keymap.c (push_key_description):
7411 * search.c (Freplace_match):
7412 * xdisp.c (message_dolog, set_message_1): All callers changed.
7414 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7416 * keyboard.c (safe_run_hook_funcall): New function.
7417 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7418 don't set the hook to nil, but remove the offending function instead.
7419 (Qcommand_hook_internal): Remove, unused.
7420 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7421 Vcommand_hook_internal.
7423 * eval.c (enum run_hooks_condition): Remove.
7424 (funcall_nil, funcall_not): New functions.
7425 (run_hook_with_args): Call each function through a `funcall' argument.
7426 Remove `cond' argument, now redundant.
7427 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7428 (Frun_hook_with_args_until_failure): Adjust accordingly.
7429 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7431 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7433 * dispextern.h (string_buffer_position): Remove declaration.
7435 * print.c (strout): Remove parameter `multibyte', unused since
7436 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7438 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7439 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7440 All callers changed.
7442 * w32.c (_wsa_errlist): Use braces for struct initializers.
7444 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7445 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7446 All callers changed.
7447 (string_buffer_position): Likewise. Also, make static (it's never
7448 used outside xdisp.c).
7449 (cursor_row_p): Remove parameter `w', unused since
7450 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7451 (decode_mode_spec): Remove parameter `precision', introduced during
7452 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7453 All callers changed.
7455 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7457 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7459 2011-03-27 Anders Lindgren <andlind@gmail.com>
7461 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7462 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7463 (ns_update_auto_hide_menu_bar): New functions.
7464 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7465 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7466 ns_constrain_all_frames.
7467 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7468 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7470 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7472 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7474 2011-03-27 Glenn Morris <rgm@gnu.org>
7476 * syssignal.h: Replace RETSIGTYPE with void.
7477 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7478 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7479 Replace SIGTYPE with void everywhere.
7480 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7481 * s/template.h (SIGTYPE): Remove commented out definition.
7483 2011-03-26 Eli Zaretskii <eliz@gnu.org>
7485 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7486 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7488 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
7490 * w32.c (read_unc_volume): Use parameter `henum', instead of
7491 global variable `wget_enum_handle'.
7493 * keymap.c (describe_vector): Remove parameters `indices' and
7494 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7495 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7497 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7499 * keyboard.c (timer_check): Remove parameter `do_it_now',
7500 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7501 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7502 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7504 * keyboard.c (read_char):
7505 * w32menu.c (w32_menu_display_help):
7506 * xmenu.c (show_help_event, menu_help_callback):
7507 Adjust calls to `show_help_echo'.
7509 * gtkutil.c (xg_maybe_add_timer):
7510 * keyboard.c (readable_events):
7511 * process.c (wait_reading_process_output):
7512 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7514 * insdel.c (adjust_markers_gap_motion):
7515 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7516 (gap_left, gap_right): Don't call it.
7518 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
7520 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7521 incurred during fontification.
7523 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7525 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7526 (DEFVAR_PER_BUFFER): Don't pass it.
7528 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7529 (scrolling_window): Don't pass it.
7531 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7533 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7535 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7537 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7538 of variables specific to SELinux and computation of `encoded_absname'.
7540 * image.c (XPutPixel): Remove unused variable `height'.
7542 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7544 * unexw32.c (get_section_info): Remove unused variable `section'.
7546 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7547 (system_process_attributes): Remove unused variable `sess'.
7548 (sys_read): Remove unused variable `err'.
7550 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7551 (w32_wnd_proc): Remove unused variable `isdead'.
7552 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7553 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7554 (x_create_tip_frame): Remove unused variable `tem'.
7556 * w32inevt.c (w32_console_read_socket):
7557 Remove unused variable `no_events'.
7559 * w32term.c (x_draw_composite_glyph_string_foreground):
7560 Remove unused variable `width'.
7562 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
7564 * w32term.c (x_set_glyph_string_clipping):
7565 Don't pass uninitialized region to CombineRgn.
7567 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
7569 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7570 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7571 (Fx_close_connection): Remove unused variable `i'.
7573 * w32font.c (w32font_draw): Return number of glyphs.
7574 (w32font_open_internal): Remove unused variable `i'.
7575 (w32font_driver): Add missing initializer.
7577 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7578 (fill_in_menu): Remove unused variable `items_added'.
7580 * w32term.c (last_mouse_press_frame): Remove static global variable.
7581 (w32_clip_to_row): Remove unused variable `f'.
7582 (x_delete_terminal): Remove unused variable `i'.
7584 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7585 (NOTHING): Remove unused static global variable.
7586 (uniscribe_check_otf): Remove unused variable `table'.
7587 (uniscribe_font_driver): Add missing initializers.
7589 2011-03-23 Julien Danjou <julien@danjou.info>
7591 * term.c (Fsuspend_tty, Fresume_tty):
7592 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7593 * window.c (temp_output_buffer_show):
7594 * insdel.c (signal_before_change):
7595 * frame.c (Fhandle_switch_frame):
7596 * fileio.c (Fdo_auto_save):
7597 * emacs.c (Fkill_emacs):
7598 * editfns.c (save_excursion_restore):
7599 * cmds.c (internal_self_insert):
7600 * callint.c (Fcall_interactively):
7601 * buffer.c (Fkill_all_local_variables):
7602 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7604 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
7605 unconditionnaly since it does the check itself.
7607 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
7609 Fix more problems found by GCC 4.5.2's static checks.
7611 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7612 the first time through the loop, since we know p0 < p1 then.
7613 This also avoids a gcc -Wstrict-overflow warning.
7615 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7616 leading to a memory leak, possible in functions like
7617 load_charset_map_from_file that can allocate an unbounded number
7618 of objects (Bug#8318).
7620 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7621 that could (at least in theory) be that large.
7623 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7624 This is less likely to overflow, and avoids undefined behavior if
7625 overflow does occur. All callers changed. Use strtoul to scan
7626 for the unsigned long integer.
7627 (pint2hrstr): Simplify and tune code slightly.
7628 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
7630 * scroll.c (do_scrolling): Work around GCC bug 48228.
7631 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7633 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7634 This also avoids a warning with gcc -Wstrict-overflow.
7635 (validate_x_resource_name): Simplify count usage.
7636 This also avoids a warning with gcc -Wstrict-overflow.
7638 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7641 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
7643 * process.c (Fmake_network_process): Use socklen_t, not int,
7644 where POSIX says socklen_t is required in portable programs.
7645 This fixes a porting bug on hosts like 64-bit HP-UX, where
7646 socklen_t is wider than int (Bug#8277).
7647 (Fmake_network_process, server_accept_connection):
7648 (wait_reading_process_output, read_process_output):
7651 * process.c: Rename or move locals to avoid shadowing.
7652 (list_processes_1, Fmake_network_process):
7653 (read_process_output_error_handler, exec_sentinel_error_handler):
7654 Rename or move locals.
7655 (Fmake_network_process): Define label "retry_connect" only if needed.
7656 (Fnetwork_interface_info): Fix pointer signedness.
7657 (process_send_signal): Add cast to avoid pointer signedness problem.
7658 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7659 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7661 Make tparam.h and terminfo.c consistent.
7662 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7663 Include tparam.h instead, since it declares them.
7664 * cm.h (PC): Remove extern decl; tparam.h now does this.
7665 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7666 * terminfo.c: Include tparam.h, to check interfaces.
7667 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7668 (tparam): Adjust signature to match interface in tparam.h;
7669 this removes some undefined behavior. Check that outstring and len
7670 are zero, which they always are with Emacs.
7671 * tparam.h (PC, BC, UP): New extern decls.
7673 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
7674 (xftfont_open): Rename locals to avoid shadowing.
7676 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
7677 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7678 (OTF_TAG_SYM): Omit macro if not needed.
7679 (ftfont_list): Remove unused local.
7680 (get_adstyle_property, ftfont_pattern_entity):
7681 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7682 Rename locals to avoid shadowing.
7684 * xfont.c (xfont_list_family): Mark var as initialized.
7686 * xml.c (make_dom): Now static.
7688 * composite.c (composition_compute_stop_pos): Rename local to
7690 (composition_reseat_it): Remove unused locals.
7691 (find_automatic_composition, composition_adjust_point): Likewise.
7692 (composition_update_it): Mark var as initialized.
7693 (find_automatic_composition): Mark vars as initialized,
7694 with a FIXME (Bug#8290).
7696 character.h: Rename locals to avoid shadowing.
7697 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7698 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7699 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7700 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7703 * textprop.c (property_change_between_p): Remove; unused.
7705 * intervals.c (interval_start_pos): Now static.
7707 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7709 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7710 Rename locals to avoid shadowing.
7712 * sound.c (wav_play, au_play, Fplay_sound_internal):
7713 Fix pointer signedness.
7714 (alsa_choose_format): Remove unused local var.
7715 (wav_play): Initialize a variable to 0, to prevent undefined
7716 behavior (Bug#8278).
7718 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7720 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7722 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7723 clobbering (Bug#8298).
7724 * sysdep.c (sys_subshell): Likewise.
7725 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7727 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7728 This should get cleaned up, so that child_setup has the
7729 same signature on all platforms.
7731 * callproc.c (call_process_cleanup): Now static.
7732 (relocate_fd): Rename locals to avoid shadowing.
7734 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7736 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7737 not to be necessary, and produces flickering.
7739 2011-03-20 Glenn Morris <rgm@gnu.org>
7741 * config.in: Remove file.
7743 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7745 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7746 are now in src/globals.h.
7747 (syms_of_minibuf): Remove spurious & from previous change.
7749 2011-03-20 Leo <sdl.web@gmail.com>
7751 * minibuf.c (completing-read-function): New variable.
7752 (completing-read-default): Rename from completing-read.
7753 (completing-read): Call completing-read-function.
7755 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7757 * xfaces.c (Fx_load_color_file):
7758 Read color file from absolute filename (bug#8250).
7760 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7762 * makefile.w32-in: Update dependencies.
7764 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7766 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7768 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7770 Fix more problems found by GCC 4.5.2's static checks.
7772 * process.c (make_serial_process_unwind, send_process_trap):
7773 (sigchld_handler): Now static.
7775 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7776 That way, the code declares only the vars that it needs.
7777 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7778 * s/cygwin.h (PTY_ITERATION): Likewise.
7779 * s/darwin.h (PTY_ITERATION): Likewise.
7780 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7782 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7783 * process.c (allocate_pty): Don't declare stb unless it's needed.
7785 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7786 (CONSTANTLIM): Remove; unused.
7787 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7788 Define only if needed.
7790 * unexelf.c (unexec): Name an expression,
7791 to avoid gcc -Wbad-function-cast warning.
7792 Use a different way to cause a compilation error if anyone uses
7793 n rather than nn, a way that does not involve shadowing.
7794 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7796 * deps.mk (unexalpha.o): Remove; unused.
7798 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7799 * unexec.h: New file.
7800 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7801 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7803 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7804 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7805 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7806 Change as necessary to match prototype in unexec.h.
7808 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7810 (back_comment, skip_chars): Mark vars as initialized.
7812 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7813 Rename locals to avoid shadowing.
7815 * lread.c (read1): Rewrite so as not to use empty "else".
7816 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7818 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7820 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7821 warning when compiling print.c.
7823 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7824 instead of using an uninitialized var.
7825 (font_sort_entities): Mark var as initialized.
7827 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7829 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7830 pointers to constants.
7831 (font_parse_fcname): Remove unused vars.
7832 (font_delete_unmatched): Now static.
7833 (font_get_spec): Remove; unused.
7834 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7835 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7836 Rename or move locals to avoid shadowing.
7838 * fns.c (require_nesting_list, require_unwind): Now static.
7839 (Ffillarray): Rename locals to avoid shadowing.
7841 * floatfns.c (domain_error2): Define only if needed.
7842 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7844 * alloc.c (mark_backtrace): Move decl from here ...
7845 * lisp.h: ... to here, so that it can be checked.
7847 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7848 (Fdefvar): Rewrite so as not to use empty "else".
7849 (lisp_indirect_variable): Name an expression,
7850 to avoid gcc -Wbad-function-cast warning.
7851 (Fdefvar): Rename locals to avoid shadowing.
7853 * callint.c (quotify_arg, quotify_args): Now static.
7854 (Fcall_interactively): Rename locals to avoid shadowing.
7855 Use const pointer when appropriate.
7857 * lisp.h (get_system_name, get_operating_system_release):
7858 Move decls here, to check interfaces.
7859 * process.c (get_operating_system_release): Move decl to lisp.h.
7860 * xrdb.c (get_system_name): Likewise.
7861 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7862 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7863 some of which prompt warnings from gcc -Wbad-function-cast.
7864 (Fformat_time_string, Fencode_time, Finsert_char):
7865 (Ftranslate_region_internal, Fformat):
7866 Rename or remove local vars to avoid shadowing.
7867 (Ftranslate_region_internal): Mark var as initialized.
7869 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7872 * lisp.h (eassert): Check that the argument compiles, even if
7873 ENABLE_CHECKING is not defined.
7875 * data.c (Findirect_variable): Name an expression, to avoid
7876 gcc -Wbad-function-cast warning.
7877 (default_value, arithcompare, arith_driver, arith_error): Now static.
7878 (store_symval_forwarding): Rename local to avoid shadowing.
7879 (Fmake_variable_buffer_local, Fmake_local_variable):
7880 Mark variables as initialized.
7881 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7883 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7884 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7885 Rename locals to avoid shadowing.
7886 (mark_stack): Move local variables into the #ifdef region where
7888 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7889 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7891 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7892 (GC_STRING_CHARS): Remove; not used.
7893 (Fmemory_limit): Cast sbrk's returned value to char *.
7895 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7896 avoids undefined behavior in theory.
7898 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7900 Use functions, not macros, for up- and down-casing (Bug#8254).
7901 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7902 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7903 to use the following functions instead of these macros.
7904 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7905 EMACS_INT, since callers assume the returned value fits in int.
7906 (upcase1): Likewise, for UPCASE_TABLE.
7907 (uppercasep, lowercasep, upcase): New static inline functions.
7908 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7909 the race-condition problem in the old DOWNCASE.
7911 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7912 Rename locals to avoid shadowing.
7913 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7914 (regex_compile, re_search_2, re_match_2_internal):
7915 Remove unused local vars.
7916 (FREE_VAR): Rewrite so as not to use empty "else",
7917 which gcc can warn about.
7918 (regex_compile, re_match_2_internal): Mark locals as initialized.
7919 (RETALLOC_IF): Define only if needed.
7920 (WORDCHAR_P): Likewise. This one is never needed, but is used
7921 only in a comment talking about a compiler bug, so put inside
7922 the #if 0 of that comment.
7923 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7924 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7927 * search.c (boyer_moore): Rename locals to avoid shadowing.
7928 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7929 (PREV_CHAR_BOUNDARY): Likewise.
7931 * search.c (simple_search): Remove unused var.
7933 * dired.c (compile_pattern): Move decl from here ...
7934 * lisp.h: ... to here, so that it can be checked.
7935 (struct re_registers): New forward decl.
7937 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7939 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7941 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7942 Rename locals to avoid shadowing.
7943 (Fvertical_motion): Mark locals as initialized.
7945 * casefiddle.c (casify_object, casify_region): Now static.
7946 (casify_region): Mark local as initialized.
7948 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7950 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7951 New macros, so that the caller can use some names other than
7952 gcpro1, gcpro2, etc.
7953 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7955 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7956 argument, for consistency with GCPRO2_VAR, etc: it is now the
7957 prefix of the variable, not the variable itself. All uses
7959 * dired.c (directory_files_internal, file_name_completion):
7960 Rename locals to avoid shadowing.
7962 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7963 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7964 dired.c's scmp function, had undefined behavior.
7965 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7966 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7967 * buffer.h: ... to here, because these macros use current_buffer,
7968 and the new implementation with inline functions needs to have
7969 current_buffer in scope now, rather than later when the macros
7971 (downcase, upcase1): New static inline functions.
7972 (DOWNCASE, UPCASE1): Reimplement using these functions.
7973 This avoids undefined behavior in expressions like
7974 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7975 from race conditions in accessing the global variables
7976 case_temp1 and case_temp2.
7977 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7978 * lisp.h (case_temp1, case_temp2): Remove their decls.
7979 * character.h (ASCII_CHAR_P): Move from here ...
7980 * lisp.h: ... to here, so that the inline functions mentioned
7983 * dired.c (directory_files_internal_unwind): Now static.
7985 * fileio.c (file_name_as_directory, directory_file_name):
7986 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7988 (file_name_as_directory): Use const pointers when appropriate.
7989 (Fexpand_file_name): Likewise. In particular, newdir might
7990 point at constant storage, so make it a const pointer.
7991 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7992 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7994 (Fset_file_times, Finsert_file_contents, auto_save_error):
7995 Rename locals to avoid shadowing.
7997 * minibuf.c (choose_minibuf_frame_1): Now static.
7998 (Ftry_completion, Fall_completions): Rename or remove locals
8001 * marker.c (bytepos_to_charpos): Remove; unused.
8003 * lisp.h (verify_bytepos, count_markers): New decls,
8004 so that gcc does not warn that these functions aren't declared.
8006 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8007 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8008 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8009 (copy_text): Remove unused local var.
8011 * filelock.c (within_one_second): Now static.
8012 (lock_file_1): Rename local to avoid shadowing.
8014 * buffer.c (fix_overlays_before): Mark locals as initialized.
8015 (fix_start_end_in_overlays): Likewise. This function should be
8016 simplified by using pointers-to-pointers, but that's a different
8018 (switch_to_buffer_1): Now static.
8019 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8020 (report_overlay_modification): Rename locals to avoid shadowing.
8022 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8023 Fix pointer signedness issue.
8024 (sys_subshell): Mark local as volatile if checking for lint,
8025 to suppress a gcc -Wclobbered warning that does not seem to be right.
8026 (MAXPATHLEN): Define only if needed.
8028 * process.c (serial_open, serial_configure): Move decls from here ...
8029 * systty.h: ... to here, so that they can be checked.
8031 * fns.c (get_random, seed_random): Move extern decls from here ...
8032 * lisp.h: ... to here, so that they can be checked.
8034 * sysdep.c (reset_io): Now static.
8035 (wait_for_termination_signal): Remove; unused.
8037 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8038 (copy_keymap_item, append_key, push_text_char_description):
8040 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8041 (DENSE_TABLE_SIZE): Remove; unused.
8042 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8043 (describe_map_tree):
8044 Rename locals to avoid shadowing.
8046 * keyboard.c: Declare functions static if they are not used elsewhere.
8047 (echo_char, echo_dash, cmd_error, top_level_2):
8048 (poll_for_input, handle_async_input): Now static.
8049 (read_char, kbd_buffer_get_event, make_lispy_position):
8050 (make_lispy_event, make_lispy_movement, apply_modifiers):
8051 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8052 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8053 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8054 (read_key_sequence, read_char): Mark locals as initialized.
8055 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8057 * keyboard.h (make_ctrl_char): New decl.
8058 (mark_kboards): Move decl here ...
8059 * alloc.c (mark_kboards): ... from here.
8061 * lisp.h (force_auto_save_soon): New decl.
8063 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8064 (DEFINE_DUMMY_FUNCTION): New macro.
8065 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8067 (main): Add casts to avoid warnings
8068 if GCC considers string literals to be constants.
8070 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8072 * dbusbind.c: Pointer signedness fixes.
8073 (xd_signature, xd_append_arg, xd_initialize):
8074 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8075 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8076 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8077 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8079 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8080 if GCC considers string literals to be constants.
8081 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8083 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8085 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8086 (print_preprocess, print_object): New macro to fix last change.
8088 * print.c (print_preprocess): Don't forget font objects.
8090 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8092 * emacs.c (USAGE3): Doc fixes.
8094 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8096 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8099 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8101 * lisp.h (VWindow_system, Qfile_name_history):
8102 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8103 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8104 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8106 * w32select.c: Don't #include "keyboard.h".
8107 (run_protected): Add extern declaration for waiting_for_input.
8109 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8110 * w32console.c (detect_input_pending, read_input_pending)
8111 (encode_terminal_code):
8112 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8113 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8114 (w32_system_caret_y, Qfile_name_history):
8115 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8116 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8117 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8118 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8119 * w32proc.c (Qlocal, report_file_error):
8120 * w32term.c (Vwindow_system, updating_frame):
8121 * w32uniscribe.c (initialized, uniscribe_font_driver):
8122 Remove unneeded extern declarations.
8124 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8126 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8128 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8130 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8131 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8132 These macros can no longer be used for assignment.
8134 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8135 Assign struct members directly, instead of using BUF_BEGV etc.
8136 (record_buffer_markers, fetch_buffer_markers): New functions for
8137 recording and fetching special buffer markers.
8138 (set_buffer_internal_1, set_buffer_temp): Use them.
8140 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8142 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8144 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8145 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8147 * xdisp.c (hscroll_window_tree):
8148 (reconsider_clip_changes): Use PT instead of BUF_PT.
8150 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8152 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8153 $(EMACS_ROOT)/lib/intprops.h.
8155 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8157 Fix more problems found by GCC 4.5.2's static checks.
8159 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8160 to unsigned char * to avoid compiler diagnostic.
8161 (xg_free_frame_widgets): Make it clear that a local variable is
8162 needed only if USE_GTK_TOOLTIP.
8163 (gdk_window_get_screen): Make it clear that this macro is needed
8164 only if USE_GTK_TOOLTIP.
8165 (int_gtk_range_get_value): New function, which avoids a diagnostic
8166 from gcc -Wbad-function-cast.
8167 (xg_set_toolkit_scroll_bar_thumb): Use it.
8168 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8169 diagnostic from gcc -Wbad-function-cast.
8170 (get_utf8_string, xg_get_file_with_chooser):
8171 Rename locals to avoid shadowing.
8172 (create_dialog): Move locals to avoid shadowing.
8174 * xgselect.c (xg_select): Remove unused var.
8176 * image.c (four_corners_best): Mark locals as initialized.
8177 (gif_load): Initialize transparent_p to zero (Bug#8238).
8178 Mark another local as initialized.
8179 (my_png_error, my_error_exit): Mark with NO_RETURN.
8181 * image.c (clear_image_cache): Now static.
8182 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8183 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8184 (x_edge_detection): Remove unnecessary cast that
8185 gcc -Wbad-function-cast diagnoses.
8186 (gif_load): Fix pointer signedness.
8187 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8188 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8190 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8192 Improve quality of tests for time stamp overflow.
8193 For example, without this patch (encode-time 0 0 0 1 1
8194 1152921504606846976) returns the obviously-bogus value (-948597
8195 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8196 reports time overflow. See
8197 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8198 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8199 * editfns.c: Include limits.h and intprops.h.
8200 (TIME_T_MIN, TIME_T_MAX): New macros.
8201 (time_overflow): Move earlier, to before first use.
8202 (hi_time, lo_time): New functions, for an accurate test for
8204 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8205 (Fget_internal_run_time): Don't assume time_t fits in int.
8206 (make_time): Use list2 instead of Fcons twice.
8207 (Fdecode_time): More accurate test for out-of-range times.
8208 (check_tm_member): New function.
8209 (Fencode_time): Use it, to test for out-of-range times.
8210 (lisp_time_argument): Don't rely on undefined left-shift and
8211 right-shift behavior when checking for time stamp overflow.
8213 * editfns.c (time_overflow): New function, refactoring common code.
8214 (Fformat_time_string, Fdecode_time, Fencode_time):
8215 (Fcurrent_time_string): Use it.
8217 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8218 * dired.c (make_time): Move to ...
8219 * editfns.c (make_time): ... here.
8220 * systime.h: Note the move.
8222 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8224 * fringe.c (update_window_fringes): Remove unused variables.
8226 * unexmacosx.c (copy_data_segment): Also copy __got section.
8229 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8231 * termcap.c [MSDOS]: Include "msdos.h".
8232 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8233 Constify `char *' arguments and their references according to
8234 prototypes in tparam.h.
8236 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8238 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8239 Adapt all references accordingly.
8241 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8243 2011-03-11 Tom Tromey <tromey@redhat.com>
8245 * buffer.c (syms_of_buffer): Remove obsolete comment.
8247 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8249 * termhooks.h (encode_terminal_code): Declare prototype.
8251 * msdos.c (encode_terminal_code): Don't declare prototype.
8253 * term.c (encode_terminal_code): Now external again, used by
8254 w32console.c and msdos.c.
8256 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8257 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8259 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8261 Fix some minor problems found by GCC 4.5.2's static checks.
8263 * fringe.c (update_window_fringes): Mark locals as initialized
8265 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8267 * alloc.c (mark_fringe_data): Move decl from here ...
8268 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8269 to check its interface.
8270 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8272 * fontset.c (free_realized_fontset): Now static.
8273 (Fset_fontset_font): Rename local to avoid shadowing.
8274 (fontset_font): Mark local as initialized.
8275 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8277 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8279 * xselect.c (x_disown_buffer_selections): Remove; not used.
8280 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8281 (x_own_selection, Fx_disown_selection_internal): Rename locals
8283 (x_handle_dnd_message): Remove local to avoid shadowing.
8285 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8286 so that the caller can use some name other than gcpro1.
8287 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8288 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8289 (Fx_backspace_delete_keys_p):
8290 Use them to avoid shadowing, and rename vars to avoid shadowing.
8291 (x_decode_color, x_set_name, x_window): Now static.
8292 (Fx_create_frame): Add braces to silence GCC warning.
8293 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8294 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8295 Remove unused locals.
8296 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8297 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8298 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8301 * xterm.h (x_mouse_leave): New decl.
8303 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8304 Remove unused functions.
8305 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8306 (x_calc_absolute_position): Now static.
8307 (XTread_socket): Don't define label "out" unless it's used.
8308 Don't declare local "event" unless it's used.
8309 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8310 unless they are used.
8311 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8312 (x_fatal_error_signal): Remove; not used.
8313 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8314 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8315 (x_error_catcher, x_connection_closed, x_error_handler):
8316 (x_error_quitter, xembed_send_message, x_iconify_frame):
8317 (my_log_handler): Rename locals to avoid shadowing.
8318 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8319 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8321 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8322 Rename or move locals to avoid shadowing.
8323 (tty_defined_color, merge_face_heights): Now static.
8324 (free_realized_faces_for_fontset): Remove; not used.
8325 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8326 does not deduce is never used uninitialized.
8327 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8328 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8330 * terminal.c (store_terminal_param): Now static.
8332 * xmenu.c (menu_highlight_callback): Now static.
8333 (set_frame_menubar): Remove unused local.
8334 (xmenu_show): Rename parameter to avoid shadowing.
8335 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8336 since they might point to immutable storage.
8337 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8338 since it's unused otherwise.
8340 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8341 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8342 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8343 avoids a gcc -Wuninitialized diagnostic.
8344 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8345 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8346 does not deduce are never used uninitialized.
8348 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8350 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8351 * window.c (window_loop, size_window):
8352 (run_window_configuration_change_hook, enlarge_window): Likewise.
8354 * window.c (display_buffer): Now static.
8355 (size_window): Mark variables that gcc -Wuninitialized
8356 does not deduce are never used uninitialized.
8357 * window.h (check_all_windows): New decl, to forestall
8358 gcc -Wmissing-prototypes diagnostic.
8359 * dispextern.h (bidi_dump_cached_states): Likewise.
8361 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8363 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8365 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8366 and to avoid gcc -Wuninitialized warning.
8367 (load_charset_map): Mark variables that gcc -Wuninitialized
8368 does not deduce are never used uninitialized.
8369 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8371 * coding.c (coding_set_source, coding_set_destination):
8372 Use "else { /* comment */ }" rather than "else /* comment */;"
8373 for clarity, and to avoid gcc -Wempty-body warning.
8374 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8375 a block, when the outer 'i' will do.
8376 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8377 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8378 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8379 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8380 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8381 Rename locals to avoid shadowing.
8382 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8383 * coding.c (emacs_mule_char, encode_invocation_designation):
8384 Now static, since they're not used elsewhere.
8385 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8386 (decode_coding_object, encode_coding_object, detect_coding_system):
8387 (decode_coding_emacs_mule): Mark variables that gcc
8388 -Wuninitialized does not deduce are never used uninitialized.
8389 (detect_coding_iso_2022): Initialize a local variable that might
8390 be used uninitialized. Leave a FIXME because it's not clear that
8391 this initialization is needed. (Bug#8211)
8392 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8393 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8394 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8395 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8396 Remove unused macros.
8398 * category.c (hash_get_category_set): Remove unused local var.
8399 (copy_category_table): Now static, since it's not used elsewhere.
8400 * character.c (string_count_byte8): Likewise.
8402 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8403 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8405 * chartab.c (copy_sub_char_table): Now static, since it's not used
8407 (sub_char_table_ref_and_range, char_table_ref_and_range):
8408 Rename locals to avoid shadowing.
8409 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8411 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8412 (BIDI_BOB): Remove unused macro.
8414 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8415 deduce are never used uninitialized.
8416 * term.c (encode_terminal_code): Likewise.
8418 * term.c (encode_terminal_code): Now static. Remove unused local.
8420 * tparam.h: New file.
8421 * term.c, tparam.h: Include it.
8422 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8423 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8424 Move these decls to tparam.h, and make them agree with what
8425 is actually in tparam.c. The previous trick of using incompatible
8426 decls in different modules does not conform to the C standard.
8427 All callers of tparam changed to use tparam's actual API.
8428 * tparam.c (tparam1, tparam, tgoto):
8429 Use const pointers where appropriate.
8431 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8432 * cm.h (struct cm): Likewise.
8433 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8434 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8435 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8436 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8437 (turn_on_face, init_tty): Likewise.
8438 * termchar.h (struct tty_display_info): Likewise.
8440 * term.c (term_mouse_position): Rename local to avoid shadowing.
8442 * alloc.c (mark_ttys): Move decl from here ...
8443 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8445 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8447 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8449 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
8451 * search.c (compile_pattern_1): Remove argument regp, unused since
8452 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8453 (compile_pattern): Don't pass it.
8455 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8457 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8458 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8460 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8462 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8464 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8465 gdk_window_get_screen, gdk_window_get_geometry,
8466 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8467 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8468 (xg_get_pixbuf_from_pixmap): New function.
8469 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8470 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8471 Call xg_get_pixbuf_from_pixmap instead of
8472 gdk_pixbuf_get_from_drawable.
8473 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8474 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8475 (xg_check_special_colors): Use GtkStyleContext and its functions
8477 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8478 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8479 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
8480 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8481 Call gtk_widget_get_preferred_size.
8482 (xg_frame_resized): gdk_window_get_geometry only takes 5
8484 (xg_win_to_widget, xg_event_is_for_menubar):
8485 Call gdk_x11_window_lookup_for_display.
8486 (xg_set_widget_bg): New function.
8487 (delete_cb): New function.
8488 (xg_create_frame_widgets): Connect delete-event to delete_cb.
8489 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8490 (xg_set_background_color): Call xg_set_widget_bg.
8491 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8492 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8493 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8494 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8496 (update_frame_tool_bar): Call gtk_widget_hide.
8497 (xg_initialize): Use GDK_KEY_g.
8499 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8501 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8503 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8504 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8505 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8507 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
8509 * w32xfns.c (select_palette): Check success of RealizePalette against
8510 GDI_ERROR, not zero.
8512 See ChangeLog.11 for earlier changes.
8518 Copyright (C) 2011 Free Software Foundation, Inc.
8520 This file is part of GNU Emacs.
8522 GNU Emacs is free software: you can redistribute it and/or modify
8523 it under the terms of the GNU General Public License as published by
8524 the Free Software Foundation, either version 3 of the License, or
8525 (at your option) any later version.
8527 GNU Emacs is distributed in the hope that it will be useful,
8528 but WITHOUT ANY WARRANTY; without even the implied warranty of
8529 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8530 GNU General Public License for more details.
8532 You should have received a copy of the GNU General Public License
8533 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.