1 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3 * alloc.c (allocate_window): Zero out non-Lisp part of newly
5 (allocate_process): Likewise for new process.
6 (allocate_terminal): Changed to use offsetof.
7 (allocate_frame): Likewise.
8 * frame.c (make_frame): Omit redundant initialization.
9 * window.c (make_parent_window): Use memset.
10 (make_window): Omit redundant initialization.
11 * process.c (make_process): Omit redundant initialization.
12 * terminal.c (create_terminal): Likewise.
14 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
16 * term.c (delete_tty): Remove redundant call to memset.
18 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
20 * alloc.c: Remove build_string.
21 * lisp.h: Define build_string as static inline. This provides
22 a better opportunity to optimize away calls to strlen when the
23 function is called with compile-time constant argument.
24 * image.c (imagemagick_error): Convert to build_string.
25 * w32proc.c (sys_spawnve): Likewise.
26 * xterm.c (x_term_init): Likewise.
28 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
30 Use sprintf return value instead of invoking strlen on result.
31 In the old days this wasn't portable, since some sprintf
32 implementations returned char *. But they died out years ago and
33 Emacs already assumes sprintf returns int.
34 Similarly for float_to_string.
35 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
37 * character.c (string_escape_byte8):
38 * data.c (Fnumber_to_string):
40 * print.c (print_object):
41 * xdisp.c (message_dolog):
42 * xfns.c (syms_of_xfns):
43 Use sprintf or float_to_string result to avoid need to call strlen.
44 * data.c (Fnumber_to_string):
45 Use make_unibyte_string, since the string must be ASCII.
46 * lisp.h, print.c (float_to_string): Now returns int length.
47 * term.c (produce_glyphless_glyph):
48 Use sprintf result rather than recomputing it.
50 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
51 * Makefile.in (ALL_CFLAGS):
52 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
53 * gmalloc.c, regex.c: Include <config.h> unconditionally.
55 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
57 * dispextern.h (xstrcasecmp): Define to library function
58 strcasecmp if available.
59 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
61 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
63 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
65 * menu.c (push_submenu_start, push_submenu_end)
66 (push_left_right_boundary, push_menu_pane): Likewise.
67 * msdos.c (dos_rawgetc): Likewise.
69 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
71 * xfns.c (xic_create_fontsetname): Remove redundant calls
74 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
76 * gtkutil.c (get_utf8_string): Remove redundant assignment.
77 sprintf already null-terminates its output.
79 * xfns.c (x_window): Remove redundant cast.
81 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
83 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
84 `const char *' to `char *' to avoid compiler warning.
86 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
88 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
89 instead of truncating it to 63 (admittedly a generous limit).
91 * process.c: Fix spelling and caps in comments.
93 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
95 * emacs.c (setpgrp): Remove definition, unused.
96 * sysdep.c (setpgrp): Remove definition, not used in this file.
98 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
100 * makefile.w32-in: Update dependencies.
102 2012-06-24 Eli Zaretskii <eliz@gnu.org>
104 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
105 (SYSTIME_H): Add nt/inc/sys/time.h.
107 * systime.h [WINDOWSNT]: Include sys/time.h.
109 * s/ms-w32.h (struct timespec): Definition moved from
110 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
112 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
114 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
115 * buffer.h (buffer_slot_type_mismatch):
116 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
117 * eval.c (unwind_to_catch):
118 * image.c (my_png_error, my_error_exit):
119 * keyboard.c (quit_throw_to_read_char, user_error)
120 (Fexit_recursive_edit, Fabort_recursive_edit):
121 * lisp.h (die, args_out_of_range, args_out_of_range_3)
122 (wrong_type_argument, buffer_overflow, __executable_start)
123 (memory_full, buffer_memory_full, string_overflow, Fthrow)
124 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
125 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
127 (child_setup) [!DOS_NT]:
128 * lread.c (end_of_file_error, invalid_syntax):
129 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
130 * puresize.h (pure_write_error):
131 * search.c (matcher_overflow):
132 * sound.c (sound_perror, alsa_sound_perror):
133 * sysdep.c, syssignal.h (croak):
134 * term.c (maybe_fatal, vfatal):
135 * textprop.c (text_read_only):
136 * undo.c (user_error):
137 * unexmacosx.c (unexec_error):
138 * xterm.c (x_ins_del_lines, x_delete_glyphs):
139 Use _Noreturn rather than NO_RETURN.
140 No need for separate decl merely because of _Noreturn.
141 * sound.c (sound_warning, parse_sound):
142 Remove unnecessary forward decls.
144 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
146 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
147 * lisp.h (WAIT_READING_MAX): New macro.
148 * dispnew.c (Fsleep_for, sit_for):
149 * keyboard.c (kbd_buffer_get_event):
150 * process.c (Faccept_process_output):
151 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
152 This improves on the previous patch, which introduced a bug
153 when time_t is unsigned and as wide as intmax_t.
154 See <http://bugs.gnu.org/9000#51>.
156 2012-06-23 Eli Zaretskii <eliz@gnu.org>
158 * dispnew.c (sit_for, Fsleep_for):
159 * keyboard.c (kbd_buffer_get_event):
160 * process.c (Faccept_process_output): Avoid compiler warnings when
161 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
163 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
165 * makefile.w32-in: Update dependencies.
167 * w32.c (ltime): Add return type and declare static.
168 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
170 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
172 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
173 Privately reported by Herbert J. Skuhra.
174 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
176 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
177 not make_lisp_timeval, when the argument is of type EMACS_TIME.
179 2012-06-23 Eli Zaretskii <eliz@gnu.org>
181 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
182 last argument of make_unibyte_string.
184 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
185 language ID in the event parameters.
187 * w32term.c (w32_read_socket): Put the new keyboard codepage into
188 event.code, not the obscure "character set ID".
190 2012-06-23 Chong Yidong <cyd@gnu.org>
192 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
194 2012-06-23 Eli Zaretskii <eliz@gnu.org>
196 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
197 * w32.c (fdutimens): New function.
199 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
201 * s/ms-w32.h (pselect): Redirect to sys_select.
203 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
205 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
206 in the logic of incrementing and decrementing the value of
207 use_relocatable_buffers.
209 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
211 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
212 Privately reported by Herbert J. Skuhra.
213 [__FreeBSD__]: Remove "*/" typo after "#include".
214 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
215 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
216 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
217 Don't assume EMACS_TIME and struct timeval are the same type.
219 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
221 Support higher-resolution time stamps (Bug#9000).
222 The time stamps are only nanosecond-resolution at the C level,
223 since that's the best that any real-world system supports now.
224 But they are picosecond-resolution at the Lisp level, as that's
225 easy, and leaves room for future OS improvements.
227 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
230 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
231 Don't get current time unless it's needed.
233 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
234 now provides it if it's absent.
235 (start_atimer): Port to higher-res time stamps.
236 Check for time stamp overflow. Don't get current time more
237 often than is needed.
239 * buffer.h (struct buffer): Buffer modtime now has high resolution.
240 Include systime.h, not time.h.
241 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
243 * dired.c: Include stat-time.h.
244 (Ffile-attributes): File times now have higher resolution.
246 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
247 (struct image): Timestamp now has higher resolution.
249 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
250 has at least microseconds now. All uses removed.
251 (update_frame, update_single_window, update_window, update_frame_1)
252 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
254 * editfns.c (time_overflow): Now extern.
255 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
256 (float-time, Fformat_time_string, Fcurrent_time_string)
257 (Fcurrent_time_zone): Accept and generate higher-resolution
259 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
260 (decode_time_components, lisp_seconds_argument): New functions.
261 (make_time): Now static.
262 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
263 Report an error if the time is invalid, rather than having the caller
266 * fileio.c: Include <stat-time.h>
267 (Fcopy_file): Copy higher-resolution time stamps.
268 Prefer to set the time stamp via a file descriptor if that works.
269 (Fset_file_times, Finsert_file_contents, Fwrite_region)
270 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
271 (Fvisited_file_modtime, Fset_visited_file_modtime):
272 Support higher-resolution time stamps.
274 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
276 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
278 * image.c (prepare_image_for_display, clear_image_cache)
279 (lookup_image): Port to higer-resolution time stamps.
281 * keyboard.c (start_polling, bind_polling_period):
282 Check for time stamp overflow.
283 (read_char, kbd_buffer_get_event, timer_start_idle)
284 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
285 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
286 Port to higher-resolution time stamps. Do not assume time_t is signed.
287 (decode_timer): New function. Timers are now vectors of length 9,
288 not 8, to accommodate the picosecond component.
289 (timer_check_2): Use it.
291 * nsterm.m (select_timeout, timeval_subtract): Remove.
292 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
293 as they're a bit more accurate and handle overflow better.
294 (ns_select): Change prototype to be compatible with pselect.
295 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
296 * nsterm.h (ns_select): Adjust prototype.
298 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
299 us-resolution time stamps.
300 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
302 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
304 * lisp.h (time_overflow): New decl.
305 (wait_reading_process_output): First arg is now intmax_t, not int,
306 to accommodate larger waits.
308 * process.h (struct Lisp_Process.read_output_delay):
309 Now counts nanoseconds, not microseconds.
310 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
312 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
313 (wait_reading_process_output):
314 Port to ns-resolution time stamps.
315 (Faccept_process_output, wait_reading_process_output):
316 Check for time stamp overflow. Do not assume time_t is signed.
317 (select_wrapper): Remove; we now use pselect.
318 (Fprocess_attributes): Now generates ns-resolution time stamps.
320 * sysdep.c: Include utimens.h. Don't include utime.h
321 or worry about struct utimbuf; gnulib does that for us now.
322 (gettimeofday): Remove; gnulib provides a substitute.
323 (make_timeval): New function.
324 (set_file_times): Now sets ns-resolution time stamps.
325 New arg FD; all uses changed.
326 (time_from_jiffies, ltime_from_jiffies, get_up_time)
327 (system_process_attributes):
328 Now returns ns-resolution time stamp. All uses changed.
329 Check for time stamp overflow.
331 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
332 provides a substitute now.
334 * systime.h: Include timespec.h rather than sys/time.h and time.h,
335 since it guarantees struct timespec.
336 (EMACS_TIME): Now struct timespec, so that we can support
337 ns-resolution time stamps.
338 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
339 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
340 (EMACS_USECS): Remove.
341 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
342 so multiply the arg by 1000 before storing it.
343 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
345 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
346 Port to ns-resolution time stamps.
347 (EMACS_TIME_NEG_P): Remove; replaced by....
348 (EMACS_TIME_SIGN): New macro.
349 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
350 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
351 (set_file_times, make_time, lisp_time_argument): Adjust signature.
352 (make_timeval, make_lisp_time, decode_time_components): New decls.
353 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
354 that it mishandled time_t overflow. You can't compare by subtracting!
355 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
356 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
358 * term.c: Include <sys/time.h>.
359 (timeval_to_Time): New function, for proper overflow wraparound.
360 (term_mouse_position, term_mouse_click): Use it.
362 * undo.c (record_first_change): Support higher-resolution time stamps
364 (Fprimitive_undo): Use them when restoring time stamps.
366 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
367 (w32_get_internal_run_time):
368 Port to higher-resolution Emacs time stamps.
369 (ltime): Now accepts single 64-bit integer, as that's more convenient
372 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
374 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
375 for compatibility with pselect. Support ns-resolution time stamps.
377 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
379 * xselect.c (wait_for_property_change, x_get_foreign_selection):
380 Check for time stamp overflow, and support ns-resolution time stamps.
382 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
383 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
384 (timeval_subtract): Remove; no longer needed.
385 (XTflash, XTring_bell, x_wait_for_event):
386 Port to ns-resolution time stamps. Don't assume time_t is signed.
388 2012-06-22 Chong Yidong <cyd@gnu.org>
390 * xdisp.c (x_consider_frame_title): Revert last change.
392 2012-06-22 Eli Zaretskii <eliz@gnu.org>
394 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
395 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
396 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
397 staticidx goes up to 1597 out of 1600 = 0x640.)
399 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
401 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
402 Otherwise, the umask might be mistakenly 0 while handling input signals.
404 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
406 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
408 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
410 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
411 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
412 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
413 access to `contents' member of Lisp_Vector objects with AREF and ASET
416 2012-06-19 Chong Yidong <cyd@gnu.org>
418 * frame.c (delete_frame): When selecting a frame on a different
419 text terminal, do not alter the terminal's top-frame.
421 * xdisp.c (format_mode_line_unwind_data): Record the target
422 frame's selected window and its terminal's top-frame.
423 (unwind_format_mode_line): Restore them.
424 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
426 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
427 since tty frames can be explicitly named.
428 (prepare_menu_bars): Likewise.
430 * term.c (Ftty_top_frame): New function.
432 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
434 Port byte-code-meter to modern targets.
435 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
436 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
437 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
438 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
439 (METER_1, METER_2): Simplify.
441 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
443 * data.c (Fdefalias): Return `symbol' (bug#11686).
445 2012-06-18 Martin Rudalics <rudalics@gmx.at>
447 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
448 gets killed during executing of this function (Bug#11665).
449 Try to always return Qt when the buffer has been actually killed.
450 (Vkill_buffer_query_functions): In doc-string say that functions
451 run by this hook should not change the current buffer.
453 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
455 Fix recently-introduced process.c problems found by static checking.
456 * process.c (write_queue_push, write_queue_pop, send_process):
457 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
458 (write_queue_pop): Fix pointer signedness problem.
459 (send_process): Remove unused local.
461 2012-06-17 Chong Yidong <cyd@gnu.org>
463 * xdisp.c (redisplay_internal): No need to redisplay terminal
464 frames that are not on top.
466 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
468 * process.c (make_process): Initialize write_queue.
469 (write_queue_push, write_queue_pop): New functions.
470 (send_process): Use them to maintain correct ordering of process
473 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
475 * lisp.h (eassert): Assume C89 or later.
476 This removes the need for CHECK.
477 (CHECK): Remove. Its comments about always evaluating its
478 argument were confusing, as 'eassert' typically does not evaluate
481 * coding.c (produce_chars): Use ptrdiff_t, not int.
483 * xterm.c (x_draw_underwave): Check for integer overflow.
484 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
486 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
488 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
489 referenced (Bug#11583).
491 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
493 Implement wave-style variant of underlining.
494 * dispextern.h (face_underline_type): New enum.
495 (face): Add field for underline type.
496 * nsterm.m (ns_draw_underwave): New function.
497 (ns_draw_text_decoration): Use it.
498 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
500 (x_draw_glyph_string): Use them.
501 * xfaces.c (Qline, Qwave): New Lisp objects.
502 (check_lface_attrs, merge_face_ref)
503 (Finternal_set_lisp_face_attribute, realize_x_face):
504 Handle wave-style underline face attributes.
505 * xterm.c (x_draw_underwave): New function.
506 (x_draw_glyph_string): Use it.
508 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
510 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
511 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
512 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
513 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
514 ($(BLD)/w32select.$(O)): Update dependencies.
516 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
518 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
519 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
520 * character.c (_fetch_multibyte_char_p): Remove.
521 * alloc.c: Include "character.h" before "buffer.h".
523 * buffer.c: Likewise.
524 * bytecode.c: Likewise.
525 * callint.c: Likewise.
526 * callproc.c: Likewise.
527 * casefiddle.c: Likewise.
528 * casetab.c: Likewise.
529 * category.c: Likewise.
531 * coding.c: Likewise.
532 * composite.c: Likewise.
534 * dispnew.c: Likewise.
536 * dosfns.c: Likewise.
537 * editfns.c: Likewise.
539 * fileio.c: Likewise.
540 * filelock.c: Likewise.
542 * fontset.c: Likewise.
543 * fringe.c: Likewise.
544 * indent.c: Likewise.
545 * insdel.c: Likewise.
546 * intervals.c: Likewise.
547 * keyboard.c: Likewise.
548 * keymap.c: Likewise.
550 * macros.c: Likewise.
551 * marker.c: Likewise.
552 * minibuf.c: Likewise.
554 * nsmenu.m: Likewise.
556 * process.c: Likewise.
558 * region-cache.c: Likewise.
559 * search.c: Likewise.
560 * syntax.c: Likewise.
562 * textprop.c: Likewise.
564 * unexsol.c: Likewise.
565 * w16select.c: Likewise.
566 * w32fns.c: Likewise.
567 * w32menu.c: Likewise.
568 * window.c: Likewise.
573 * xselect.c: Likewise.
575 2012-06-16 Eli Zaretskii <eliz@gnu.org>
577 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
578 If all the glyphs of the glyph row came from strings, and we have no
579 cursor positioning clues, put the cursor on the first glyph of the
581 (handle_face_prop): Use chunk-relative overlay string index when
582 indexing into it->string_overlays array. (Bug#11653)
583 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
584 the rightmost. (Bug#11720)
586 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
588 * category.h (CHAR_HAS_CATEGORY): Define as inline.
589 (CATEGORY_MEMBER): Enforce 1/0 value.
590 * category.c (_temp_category_set): Remove.
592 2012-06-16 Eli Zaretskii <eliz@gnu.org>
594 * window.c (Fdelete_other_windows_internal)
595 (Fdelete_window_internal): Don't access frame's mouse highlight
596 info of the initial frame. (Bug#11677)
598 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
600 * .gdbinit (xgetint): Fix recently-introduced paren typo.
601 Assume USE_2_TAGS_FOR_INTS.
602 (xreload): Adjust $tagmask width to match recent lisp.h change.
604 Simplify lisp.h in minor ways that should not affect code.
605 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
606 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
607 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
608 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
609 (INTTYPEBITS): New macro, for clarity.
610 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
611 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
612 Simplify now that USE_LSB_TAG is always defined.
613 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
614 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
616 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
618 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
620 2012-06-13 Glenn Morris <rgm@gnu.org>
622 * s/bsd-common.h (BSD4_3):
623 * s/usg5-4-common.h (USG5_4): No longer define; unused.
625 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
627 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
630 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
632 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
633 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
634 * alloc.c (widen_to_Lisp_Object): Remove.
635 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
636 * frame.c (delete_frame): Remove outdated comment.
637 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
639 (Fw32_unregister_hot_key): Likewise.
640 (Fw32_toggle_lock_key): Likewise.
641 * w32menu.c (add_menu_item): Likewise.
642 (w32_menu_display_help): Use XIL instead of checking
644 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
645 (init_heap): Likewise.
646 * w32term.c (w32_read_socket): Update comment.
648 2012-06-13 Glenn Morris <rgm@gnu.org>
650 * s/usg5-4-common.h, src/s/unixware.h:
651 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
653 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
655 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
657 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
658 * alloc.c (make_number) [!defined make_number]:
659 Remove, as lisp.h always defines this now.
660 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
661 (roundup_size): Verify that it is a power of 2.
662 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
663 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
664 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
665 -DUSE_LSB_TAG=0, to override the automatically-selected default.
666 USE_LSB_TAG now is always defined to be either 0 or 1.
668 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
669 code works fine either way, and efficiency is not a concern here,
670 as the union type is for debugging, not for production.
671 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
672 Use an inline function on all platforms when using the union type,
673 since this is simpler and 'static inline' can be used portably
675 (LISP_INITIALLY_ZERO): New macro.
676 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
677 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
679 2012-06-12 Glenn Morris <rgm@gnu.org>
681 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
683 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
685 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
686 Move BROKEN_SIGIO to configure.
688 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
689 Move NO_TERMIO to configure.
691 2012-06-12 Chong Yidong <cyd@gnu.org>
693 * image.c (imagemagick_load_image): Use MagickFlattenImage if
694 MagickMergeImageLayers is undefined. Use pixel pusher loop if
695 MagickExportImagePixels is undefined.
697 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
699 * image.c (imagemagick_load_image): Remove unused label.
701 2012-06-11 Glenn Morris <rgm@gnu.org>
703 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
704 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
705 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
706 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
708 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
710 * alloc.c (make_byte_code): New function.
711 (Fmake_byte_code): Use it. Don't purify here.
712 * lread.c (read1): Use it as well to avoid extra allocation.
714 2012-06-11 Chong Yidong <cyd@gnu.org>
716 * image.c (imagemagick_load_image): Implement transparency.
718 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
720 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
721 account for preceding backslashes. (Bug#11663)
723 2012-06-09 Chong Yidong <cyd@gnu.org>
725 * term.c: Support italics in capable terminals (Bug#9652).
726 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
727 (turn_on_face): Output using TS_enter_italic_mode if available.
728 Don't handle unused blinking and alt-charset cases.
729 (turn_off_face): Handle italic case; discard unused tty_blinking_p
730 and tty_alt_charset_p cases.
731 (tty_capable_p, init_tty): Support italics.
733 * termchar.h (struct tty_display_info): Add field for italics.
734 Remove unused blink field.
736 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
739 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
740 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
741 tty_alt_charset_p. Add tty_italic_p.
743 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
745 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
746 dbus_type_is_basic if available.
747 (xd_extract_signed, xd_extract_unsigned): Rename from
748 extract_signed and extract_unsigned, respectively. Adapt callers.
750 2012-06-09 Chong Yidong <cyd@gnu.org>
752 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
754 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
757 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
759 * xdisp.c (vmessage): Treat frame message as multibyte.
760 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
761 would generate the diagnostic "Making \302\247 buffer-local while
764 2012-06-08 Eli Zaretskii <eliz@gnu.org>
766 * dispnew.c (showing_window_margins_p): Undo last change, which
767 was done due to an inadvertent commit.
768 (adjust_frame_glyphs_for_frame_redisplay): Do call
769 showing_window_margins_p.
771 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
773 * eval.c (Fmake_var_non_special): New primitive.
774 (syms_of_eval): Defsubr it.
775 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
777 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
779 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
780 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
782 2012-06-08 Eli Zaretskii <eliz@gnu.org>
784 * alloc.c (allocate_vectorlike): Fix last change.
786 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
788 Block-based vector allocation of small vectors.
789 * lisp.h (struct vectorlike_header): New field `nbytes',
790 adjust comment accordingly.
791 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
792 to denote vector blocks. Adjust users (live_vector_p,
793 mark_maybe_pointer, valid_lisp_object_p) accordingly.
794 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
795 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
796 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
797 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
798 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
799 (roundup_size): New constant.
800 (struct vector_block): New data type.
801 (vector_blocks, vector_free_lists, zero_vector): New variables.
802 (all_vectors): Rename to `large_vectors'.
803 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
804 (sweep_vectors): New functions.
805 (allocate_vectorlike): Return `zero_vector' as the only vector of
806 0 items. Allocate new vector from block if vector size is less than
807 or equal to VBLOCK_BYTES_MAX.
808 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
809 (init_alloc_once): Add call to init_vectors.
811 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
813 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
815 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
817 * doprnt.c (doprnt): Truncate multibyte char correctly.
818 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
819 would mishandle a string argument "Xc" if X was a multibyte
820 character of length 2: it would truncate after X's first byte
821 rather than including all of X.
823 2012-06-06 Chong Yidong <cyd@gnu.org>
825 * buffer.c (word_wrap): Doc fix.
827 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
829 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
831 2012-06-03 Glenn Morris <rgm@gnu.org>
833 * xdisp.c (tool-bar-style): Doc fix.
835 2012-06-03 Ulrich Müller <ulm@gentoo.org>
837 * Makefile.in (PAXCTL): Define.
838 (temacs$(EXEEXT)): Disable memory randomization for the temacs
839 binary via PaX flags if the paxctl utility is available.
840 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
841 Restore PaX flags to their default. (Bug#11398)
843 2012-06-03 Chong Yidong <cyd@gnu.org>
845 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
848 2012-06-03 Chong Yidong <cyd@gnu.org>
850 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
851 (note_mode_line_or_margin_highlight): If there is no help echo,
852 use mode-line-default-help-echo. Handle the case where the mouse
853 position is past the end of the mode line string.
855 * buffer.c (buffer_local_value_1): New function, split from
856 Fbuffer_local_value; can return Qunbound.
857 (Fbuffer_local_value): Use it.
858 (Vmode_line_format): Docstring tweaks.
860 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
862 * sysdep.c (system_process_attributes): Improve comment.
864 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
866 * keyboard.c: Export real-this-command to Elisp.
867 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
868 and DEFVAR it. Update all users.
870 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
872 * minibuf.c (Fassoc_string): Remove duplicate declaration.
874 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
875 Convert pctcpu and pctmem to Lisp float properly.
876 Let the compiler fold better, as 100.0/0x8000 is exact.
878 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
880 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
883 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
885 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
887 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
889 For a 'struct window', replace some Lisp_Object fields to
890 bitfields where appropriate, remove unused fields.
891 * window.h (struct window): Remove unused 'last_mark_x' and
892 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
893 change it's type from Lisp_Object to bitfield.
894 Change type of 'force_start', 'optional_new_start',
895 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
896 fields from Lisp_Object to bitfield. Adjust users accordingly.
898 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
900 Pacify gcc -Wdouble-precision when using Xaw.
901 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
902 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
903 Use 'float' consistently, rather than 'float' in most places
904 and 'double' in a couple of places.
906 2012-05-31 Eli Zaretskii <eliz@gnu.org>
908 * xdisp.c (handle_stop): Detect whether we have overlay strings
909 loaded by testing it->current.overlay_string_index to be
910 non-negative, instead of checking whether n_overlay_strings is
911 positive. (Bug#11587)
913 2012-05-31 Chong Yidong <cyd@gnu.org>
915 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
917 * doc.c (Fsubstitute_command_keys): Doc fix.
919 2012-05-31 Eli Zaretskii <eliz@gnu.org>
921 * search.c (search_buffer): Remove calls to
922 r_alloc_inhibit_buffer_relocation, as it is now called by
923 maybe_unify_char, which was the cause of relocation of buffer text
926 2012-05-31 Eli Zaretskii <eliz@gnu.org>
928 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
929 for the duration of call to load_charset, to avoid problems with
930 callers of maybe_unify_char that access buffer text through C
933 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
934 decrement the inhibition flag, instead of just setting or
937 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
939 Remove obsolete '#define static' cruft.
940 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
941 This #undef was "temporary" in 2000; it is no longer needed
942 now that '#define static' has gone away.
943 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
944 (gray_bitmap_bits): Remove; no longer needed.
945 All uses replaced with definiens.
946 * xterm.c: Include "bitmaps/gray.xbm".
948 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
950 Clean up __executable_start, monstartup when --enable-profiling.
951 The following changes affect the code only when profiling.
952 * dispnew.c (__executable_start): Rename from safe_bcopy.
953 Define only on platforms that need it.
954 * emacs.c: Include <sys/gmon.h> when profiling.
955 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
956 (__executable_start): Remove decl, since lisp.h does it now.
957 (safe_bcopy): Remove decl; no longer has that name.
958 (main): Coalesce #if into single bit of code, for simplicity.
959 Cast pointers to uintptr_t, since standard libraries want integers
961 * lisp.h (__executable_start): New decl.
963 2012-05-31 Glenn Morris <rgm@gnu.org>
965 * image.c (Fimagemagick_types): Doc fix.
967 2012-05-30 Jim Meyering <meyering@redhat.com>
969 * callproc.c (Fcall_process_region): Include directory component
970 in mkstemp error message (Bug#11586).
972 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
974 * alloc.c, lisp.h (make_pure_vector): Now static.
976 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
978 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
980 (Fautoload): Do the hash-doc more carefully.
981 * data.c (Fdefalias): Purify definition, except for keymaps.
982 (Qdefun): Move from eval.c.
983 * lisp.h (Qdefun): Remove.
984 * lread.c (read1): Tiny simplification.
986 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
988 Do not create empty overlays with the evaporate property (Bug#9642).
989 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
990 Bug#9642, but explicitly check that the buffer the overlay would
991 be moved to is live and rearrange lines to make sure that errors
992 will not put the overlay in an inconsistent state.
993 (Fdelete_overlay): Cosmetics.
995 2012-05-28 Eli Zaretskii <eliz@gnu.org>
997 * w32term.c (my_bring_window_to_top): New function.
998 (x_raise_frame): Use handle returned by DeferWindowPos, which
999 could be different from the original one.
1000 Call my_bring_window_to_top instead of my_set_foreground_window.
1003 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1004 by calling BringWindowToTop.
1006 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1007 (WM_EMACS_END): Increase by one.
1009 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1011 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1012 This avoids undefined behavior that might cause the eassert
1013 to not catch an out-of-range value.
1015 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
1017 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1018 Update dependencies.
1020 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1022 * bidi.c (bidi_mirror_char): Fix last change.
1024 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1026 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1027 when referring to sectname field in printf format.
1029 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1031 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1032 Only r_alloc_inhibit_buffer_relocation needed to be added;
1033 the others were already declared.
1035 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1036 before checking whether it's out of range. Put the check inside
1038 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1040 2012-05-27 Ken Brown <kbrown@cornell.edu>
1042 * callproc.c (Fcall_process): Restore a line that was accidentally
1043 commented out in the 2011-02-13 change (bug#11547).
1045 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1047 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1048 defined on ralloc.c.
1050 * buffer.c [REL_ALLOC]: Remove prototypes of
1051 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1052 they are now on lisp.h.
1054 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1056 * search.c (search_buffer): Use it to inhibit relocation of buffer
1057 text while re_search_2 is doing its job, because re_search_2 is
1058 passed C pointers to buffer text. (Bug#11519)
1060 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1063 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1064 state after an additional call to move_it_in_display_line_to, keep
1065 the values of it->max_ascent and it->max_descent found for the
1067 (pos_visible_p): Revert the comparison against bottom_y to what it
1068 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1071 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1073 Fix coding-related core dumps with gcc -ftrapv.
1074 The code was computing A - B, where A and B are pointers, and B is
1075 random garbage. This can lead to core dumps on platforms that
1076 have special pointer registers, and it also leads to core dumps on
1077 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1078 A - B only when B is initialized properly.
1079 * coding.c (coding_set_source, coding_set_destination): Return void.
1080 (coding_change_source, coding_change_destinations): New functions,
1081 with the old behaviors of coding_set_source and coding_set_destination.
1082 All callers that need an offset changed to use these new functions.
1084 2012-05-26 Glenn Morris <rgm@gnu.org>
1086 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1088 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1090 Extend mouse support on W32 text-mode console.
1091 * xdisp.c (draw_row_with_mouse_face):
1092 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
1094 * w32console.c: Include window.h.
1095 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1097 (initialize_w32_display): Initialize mouse-highlight data.
1099 * w32inevt.c: Include termchar.h and window.h.
1100 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1101 moves, call note_mouse_highlight. If help_echo changed, call
1102 gen_help_event to produce help-echo message in the echo area.
1103 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1106 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1108 * lread.c (read1): Simplify slightly to avoid an overflow warning
1109 with GCC 4.7.0 on x86-64.
1111 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1113 * bidi.c (bidi_mirror_char): Revert last change: an int is
1114 definitely wide enough here.
1116 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
1118 Fix integer width and related bugs (Bug#9874).
1119 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
1120 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1121 (string_bytes, check_sblock, allocate_string_data):
1122 (compact_small_strings, Fmake_bool_vector, make_string)
1123 (make_unibyte_string, make_multibyte_string)
1124 (make_string_from_bytes, make_specified_string)
1125 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1126 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1128 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1129 (allocate_pseudovector):
1130 Use int, not EMACS_INT, where int is wide enough.
1131 (inhibit_garbage_collection, Fgarbage_collect):
1132 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1133 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1134 int might not be wide enough.
1135 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1136 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1137 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1138 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1139 (bidi_level_of_next_char, bidi_move_to_visually_next):
1140 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1141 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1142 (Fkill_buffer, Fset_buffer_major_mode)
1143 (advance_to_char_boundary, Fbuffer_swap_text)
1144 (Fset_buffer_multibyte, overlays_at, overlays_in)
1145 (overlay_touches_p, struct sortvec, record_overlay_string)
1146 (overlay_strings, recenter_overlay_lists)
1147 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1148 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1149 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1150 (Foverlay_recenter, last_overlay_modification_hooks_used)
1151 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1152 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1153 (validate_region): Omit unnecessary test for b <= e,
1154 since that's guaranteed by the previous test.
1155 (adjust_overlays_for_delete): Avoid pos + length overflow.
1156 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1157 (report_overlay_modification):
1158 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1159 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1160 Omit pointer cast, which isn't needed anyway, and doesn't work
1161 after the EMACS_INT -> ptrdiff_t change.
1162 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
1163 * buffer.h: Adjust decls to match defn changes elsewhere.
1164 (struct buffer_text, struct buffer):
1165 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1166 Use EMACS_INT, not int, where int might not be wide enough.
1167 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1168 not int, to avoid needless 32-bit limit on 64-bit hosts.
1169 (exec_byte_code): Use tighter memory-full test, one that checks
1170 for alloca overflow. Don't compute the address of the object just
1171 before an array, as that's not portable. Use EMACS_INT, not
1172 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
1173 * callint.c (Fcall_interactively):
1174 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1175 * callproc.c (call_process_kill, Fcall_process):
1176 Don't assume pid_t fits into an Emacs fixnum.
1177 (call_process_cleanup, Fcall_process, child_setup):
1178 Don't assume pid_t fits into int.
1179 (call_process_cleanup, Fcall_process, delete_temp_file)
1180 (Fcall_process_region):
1181 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1182 (Fcall_process): Simplify handling of volatile integers.
1183 Use int, not EMACS_INT, where int will do.
1184 * casefiddle.c (casify_object, casify_region, operate_on_word)
1185 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1186 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1187 (casify_object): Avoid integer overflow when overallocating buffer.
1188 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
1189 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
1190 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1191 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1192 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1193 integers are now checked earlier. All uses replaced with XINT.
1195 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1196 For CCL_MapSingle, check that content and value are in int range.
1197 (ccl_driver, Fregister_code_conversion_map):
1198 Check that Vcode_version_map_vector is a vector.
1199 (resolve_symbol_ccl_program): Check that vector header is in range.
1200 Always copy the vector, so that we can check its contents reliably
1201 now rather than having to recheck each instruction as it's being
1202 executed. Check that vector words fit in 'int'.
1203 (ccl_get_compiled_code, Fregister_ccl_program)
1204 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1205 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1206 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1207 contents are in range.
1208 (Fccl_execute_on_string): Check that status is in range.
1209 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1210 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1211 Accept and return EMACS_INT, not int, because callers can pass values
1213 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1214 (multibyte_chars_in_text, parse_str_as_multibyte)
1215 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1216 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1217 (string_escape_byte8, Fget_byte):
1218 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1219 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
1220 avoid mishandling large integers.
1221 * character.h: Adjust decls to match defn changes elsewhere.
1222 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1223 (Ffind_charset_region):
1224 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1225 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1226 (load_charset_map_from_vector, Fdefine_charset_internal):
1227 Don't assume fixnum fits in int.
1228 (load_charset_map_from_vector, Fmap_charset_chars):
1229 Remove now-unnecessary CHECK_NATNUMs.
1230 (Fdefine_charset_internal): Check ranges here, more carefully.
1231 Don't rely on undefined behavior with signed left shift overflow.
1232 Don't assume unsigned int fits into fixnum, or that fixnum fits
1233 into unsigned int. Don't require max_code to be a valid fixnum;
1234 that's not true for gb10830 4-byte on a 32-bit host. Allow
1235 invalid_code to be a cons, for the same reason. Require code_offset
1236 to be a character. Avoid int overflow if max_char is close
1238 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1239 this is intended anyway and avoids some undefined behavior.
1240 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1241 INDEX_TO_CODE_POINT, as that's what it expects.
1242 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
1243 * charset.h (DECODE_CHAR): Return int, not unsigned;
1244 this is what was intended anyway, and it avoids undefined behavior.
1245 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1246 integer-overflow issues.
1247 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1248 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1249 where the argument is EMACS_INT, and this behavior is not intended.
1250 * chartab.c (Fmake_char_table, Fset_char_table_range)
1251 (uniprop_get_decoder, uniprop_get_encoder):
1252 Don't assume fixnum fits in int.
1253 * cmds.c (move_point): New function, that does the gist of
1254 Fforward_char and Fbackward_char, but does so while checking
1255 for integer overflow more accurately.
1256 (Fforward_char, Fbackward_char): Use it.
1257 (Fforward_line, Fend_of_line, internal_self_insert)
1258 (internal_self_insert):
1259 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1260 Fix a FIXME, by checking for integer overflow when calculating
1261 target_clm and actual_clm.
1262 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
1263 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
1264 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1265 (coding_alloc_by_making_gap, alloc_destination)
1266 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1267 (encode_coding_utf_16, detect_coding_emacs_mule)
1268 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1269 (detect_coding_iso_2022, decode_coding_iso_2022)
1270 (encode_invocation_designation, encode_designation_at_bol)
1271 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1272 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1273 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1274 (encode_coding_ccl, encode_coding_raw_text)
1275 (detect_coding_charset, decode_coding_charset)
1276 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1277 (produce_composition, produce_charset, produce_annotation)
1278 (decode_coding, handle_composition_annotation)
1279 (handle_charset_annotation, consume_chars, decode_coding_gap)
1280 (decode_coding_object, encode_coding_object, detect_coding_system)
1281 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1282 (code_convert_region, code_convert_string)
1283 (Fdefine_coding_system_internal)
1284 (coding_set_source, coding_set_destination):
1285 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1286 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1287 (Fdefine_coding_system_internal):
1288 Don't assume fixnums fit in int.
1289 (decode_coding_gap, decode_coding_object, encode_coding_object)
1290 (Fread_coding_system, Fdetect_coding_region)
1291 (Funencodable_char_position, Fcheck_coding_systems_region)
1292 (get_translation, handle_composition_annotation, consume_chars):
1293 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1294 (consume_chars): Rewrite to not calculate an address outside buffer.
1295 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
1296 Don't access memory outside of the args array.
1297 (Fdefine_coding_system_internal): Check for charset-id overflow.
1298 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1299 result of ENCODE_CHAR.
1300 * coding.h: Adjust decls to match defn changes elsewhere.
1301 (struct coding_system):
1302 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1303 * composite.c (get_composition_id, find_composition)
1304 (run_composition_function, update_compositions)
1305 (compose_text, composition_gstring_put_cache)
1306 (composition_gstring_p, composition_gstring_width)
1307 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1308 (composition_compute_stop_pos, composition_reseat_it)
1309 (composition_update_it, struct position_record)
1310 (find_automatic_composition, composition_adjust_point)
1311 (Fcomposition_get_gstring, Ffind_composition_internal):
1312 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1313 (update_compositions):
1314 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1315 * composite.h: Adjust decls to match defn changes elsewhere.
1316 (struct composition):
1317 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1318 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1319 Do not attempt to compute the address of the object just before a
1320 buffer; this is not portable.
1322 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1323 (Faset): Use int, not EMACS_INT, where int is wide enough.
1324 (Fstring_to_number): Don't assume fixnums fit in int.
1325 (Frem): Don't assume arg is nonnegative.
1326 * dbusbind.c (xd_append_arg): Check for integers out of range.
1327 (Fdbus_call_method): Don't overflow the timeout int.
1328 (extract_signed, extract_unsigned): New functions.
1329 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1330 (xd_get_connection_references): Return ptrdiff_t, not int.
1332 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1333 (xd_read_message_1):
1334 Use int, not unsigned, where the dbus API uses int.
1335 (Fdbus_message_internal): Don't overflow mtype.
1336 (syms_of_dbusbind): Allocate right-sized buffer for integers.
1337 * dired.c (directory_files_internal, file_name_completion, scmp)
1338 (file_name_completion_stat):
1339 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1340 (file_name_completion): Don't overflow matchcount.
1341 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1342 * dispextern.h: Adjust decls to match defn changes elsewhere.
1343 (struct text_pos, struct glyph, struct bidi_saved_info)
1344 (struct bidi_string_data, struct bidi_it, struct composition_it)
1346 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1347 (struct display_pos, struct composition_it, struct it):
1348 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1349 * dispnew.c (increment_matrix_positions)
1350 (increment_row_positions, mode_line_string)
1351 (marginal_area_string):
1352 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1353 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
1354 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1355 (duration_to_sec_usec): New function, to check for overflow better.
1356 (Fsleep_for, sit_for): Use it.
1357 * doc.c (get_doc_string, store_function_docstring):
1358 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1359 (get_doc_string, Fsnarf_documentation):
1360 Use int, not EMACS_INT, where int is wide enough.
1362 Use SAFE_ALLOCA, not alloca.
1363 Check for overflow when converting EMACS_INT to off_t.
1364 * doprnt.c (doprnt):
1365 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1366 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1367 Don't assume uid_t fits into fixnum.
1368 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1369 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1370 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1371 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1372 (general_insert_function)
1373 (Finsert_char, make_buffer_string, make_buffer_string_both)
1374 (update_buffer_properties, Fbuffer_substring)
1375 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1376 (Fsubst_char_in_region, check_translation)
1377 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1378 (transpose_markers, Ftranspose_regions):
1379 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1380 (clip_to_bounds): Move to lisp.h as an inline function).
1381 (Fconstrain_to_field): Don't assume integers are nonnegative.
1382 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1383 (Fsubst_char_in_region, Fsave_restriction):
1384 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1385 (Femacs_pid): Don't assume pid_t fits into fixnum.
1386 (lo_time): Use int, not EMACS_INT, when int suffices.
1387 (lisp_time_argument): Check for usec out of range.
1388 (Fencode_time): Don't assume fixnum fits in int.
1389 (Fuser_login_name, Fuser_full_name): Signal an error
1390 if a uid argument is out of range, rather than relying on
1392 (Fformat_time_string): Remove now-unnecessary check.
1393 lisp_time_argument checks for out-of-range usec now.
1394 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
1395 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1396 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1397 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1398 (init_cmdargs, Fdump_emacs):
1399 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1400 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1401 the bottom (typically) 32 bits of the fixnum.
1402 * eval.c (specpdl_size, call_debugger):
1403 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1404 (when_entered_debugger, Fbacktrace_debug):
1405 Don't assume fixnum can fit in int.
1406 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1407 the object just before a buffer; this is not portable.
1408 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1409 (grow_specpdl, unbind_to):
1410 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1411 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1412 (grow_specpdl): Simplify allocation by using xpalloc.
1413 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
1414 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1415 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1416 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1417 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1419 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1420 (Fcopy_file, non_regular_nbytes, read_non_regular)
1421 (Finsert_file_contents):
1422 Use int, not EMACS_INT, where int is wide enough.
1423 (READ_BUF_SIZE): Verify that it fits in int.
1424 (Finsert_file_contents): Check that counts are in proper range,
1425 rather than assuming fixnums fit into ptrdiff_t etc.
1426 Don't assume fixnums fit into int.
1427 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
1428 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1429 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
1430 (string_char_to_byte, string_byte_to_char)
1431 (string_make_multibyte, string_to_multibyte)
1432 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1433 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1434 (substring_both, Fdelete, internal_equal, Ffillarray)
1435 (Fclear_string, mapcar1)
1436 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1437 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1438 (larger_vector, make_hash_table, maybe_resize_hash_table)
1439 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1440 (Fmaphash, secure_hash):
1441 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1442 (concat): Check for string index and length overflow.
1443 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1445 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1446 (larger_vector): New API (vec, incr_min, size_max) replaces old
1447 one (vec, new_size, init). This catches size overflow.
1448 INIT was removed because it was always Qnil.
1449 All callers changed.
1450 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1451 the upper bound on a hash table index size.
1452 (make_hash_table, maybe_resize_hash_table): Use it.
1453 (secure_hash): Computer start_byte and end_byte only after
1454 they're known to be in ptrdiff_t range.
1455 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1456 (Ffont_get_glyphs, Ffont_at):
1457 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1458 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1459 (Flist_fonts, Fopen_font):
1460 Don't assume fixnum can fit in int.
1461 (check_gstring): Don't assume index can fit in int.
1462 (font_match_p): Check that fixnum is a character, not a nonnegative
1463 fixnum, since the later code needs to stuff it into an int.
1464 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1465 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1466 conversion overflow issues.
1467 (Fopen_font): Check for integer out of range.
1468 (Ffont_get_glyphs): Don't assume index can fit in int.
1469 * font.h: Adjust decls to match defn changes elsewhere.
1470 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1472 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1473 printmax_t, where ptrdiff_t is wide enough.
1474 (Finternal_char_font):
1475 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1476 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1477 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1478 (Fset_frame_position, x_set_frame_parameters)
1479 (x_set_line_spacing, x_set_border_width)
1480 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1481 Check that fixnums are in proper range for system types.
1482 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1483 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1484 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1485 Use SAFE_ALLOCA_LISP, not alloca.
1486 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1487 intptr_t is wide enough.
1488 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1489 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1490 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1491 Check for fixnum out of range.
1492 * ftfont.c (ftfont_list): Don't assume index fits in int.
1493 Check that fixnums are in proper range for system types.
1494 (ftfont_shape_by_flt):
1495 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1496 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1497 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1498 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1499 Check that fixnums are in proper range for system types.
1500 * gnutls.h: Adjust decls to match defn changes elsewhere.
1501 * gtkutil.c (xg_dialog_run):
1502 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1503 (update_frame_tool_bar):
1504 Check that fixnums are in proper range for system types.
1505 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
1506 (lookup_image): Check that fixnums are in range for system types.
1507 * indent.c (last_known_column, last_known_column_point):
1508 (current_column_bol_cache):
1509 (skip_invisible, current_column, check_display_width):
1510 (check_display_width, scan_for_column, current_column_1)
1511 (Findent_to, Fcurrent_indentation, position_indentation)
1512 (indented_beyond_p, Fmove_to_column, compute_motion):
1513 (Fcompute_motion, Fvertical_motion):
1514 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1515 (last_known_column_modified): Use EMACS_INT, not int.
1516 (check_display_width):
1518 Check that fixnums and floats are in proper range for system types.
1519 (compute_motion): Don't assume index or fixnum fits in int.
1520 (compute_motion, Fcompute_motion):
1521 Use int, not EMACS_INT, when it is wide enough.
1522 (vmotion): Omit local var start_hpos that is always 0; that way
1523 we don't need to worry about overflow in expressions involving it.
1524 * indent.h: Adjust decls to match defn changes elsewhere.
1526 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1527 Use int, not EMACS_INT, where int is wide enough.
1528 Remove unused members ovstring_chars_done and tab_offset;
1530 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1531 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1532 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1533 (make_gap, copy_text, insert, insert_and_inherit)
1534 (insert_before_markers, insert_before_markers_and_inherit)
1535 (insert_1, count_combining_before, count_combining_after)
1536 (insert_1_both, insert_from_string)
1537 (insert_from_string_before_markers, insert_from_string_1)
1538 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1539 (adjust_after_replace, adjust_after_insert, replace_range)
1540 (replace_range_2, del_range, del_range_1, del_range_byte)
1541 (del_range_both, del_range_2, modify_region)
1542 (prepare_to_modify_buffer, signal_before_change)
1543 (signal_after_change, Fcombine_after_change_execute):
1544 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1545 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1546 (balance_an_interval, split_interval_right, split_interval_left)
1547 (find_interval, next_interval, update_interval)
1548 (adjust_intervals_for_insertion, delete_node, delete_interval)
1549 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1550 (static_offset_intervals, offset_intervals)
1551 (merge_interval_right, merge_interval_left, make_new_interval)
1552 (graft_intervals_into_buffer, temp_set_point_both)
1553 (temp_set_point, set_point, adjust_for_invis_intang)
1554 (set_point_both, move_if_not_intangible, get_property_and_range)
1555 (get_local_map, copy_intervals, copy_intervals_to_string)
1556 (compare_string_intervals, set_intervals_multibyte_1):
1557 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1558 * intervals.h: Adjust decls to match defn changes elsewhere.
1560 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1561 * keyboard.c (this_command_key_count, this_single_command_key_start)
1562 (before_command_key_count, before_command_echo_length, echo_now)
1563 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1564 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1565 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1566 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1567 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1568 (last_non_minibuf_size, last_point_position, echo_truncate)
1569 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1570 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1571 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1572 (stuff_buffered_input):
1573 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1574 (last_auto_save, command_loop_1, read_char):
1575 Use EMACS_INT, not int, to avoid integer overflow.
1576 (record_char): Avoid overflow in total_keys computation.
1577 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1578 * keyboard.h: Adjust decls to match defn changes elsewhere.
1579 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1580 (Fkey_description, Fdescribe_vector, Flookup_key):
1581 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1582 (click_position): New function, to check that positions are in range.
1583 (Fcurrent_active_maps):
1585 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1586 (Faccessible_keymaps, Fkey_description):
1587 (preferred_sequence_p):
1588 Don't assume fixnum can fit into int.
1589 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1590 Check for integer overflow in size calculations.
1591 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1592 avoid mishandling large integers.
1593 * lisp.h: Adjust decls to match defn changes elsewhere.
1594 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1595 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1596 (struct Lisp_Marker):
1597 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1598 (clip_to_bounds): Now an inline function, moved here from editfns.c.
1599 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1600 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1601 All callers changed.
1602 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1603 Assume the arg has valid form, since it always does.
1604 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1605 unsigned integer system type.
1606 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1607 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1608 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1609 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1610 (duration_to_sec_usec): New decl.
1611 * lread.c (read_from_string_index, read_from_string_index_byte)
1612 (read_from_string_limit, readchar, unreadchar, openp)
1613 (read_internal_start, read1, oblookup):
1614 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1615 (Fload, readevalloop, Feval_buffer, Feval_region):
1616 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1617 (openp): Check for out-of-range argument to 'access'.
1618 (read1): Use int, not EMACS_INT, where int is wide enough.
1619 Don't assume fixnum fits into int.
1620 Fix off-by-one error that can read outside a buffer.
1621 (read_filtered_event): Use duration_to_sec_usec
1622 to do proper overflow checking on durations.
1623 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1624 in size calculation.
1625 (Fexecute_kbd_macro):
1626 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1627 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1628 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1629 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1630 (set_marker_both, set_marker_restricted_both, marker_position)
1631 (marker_byte_position, Fbuffer_has_markers_at):
1632 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1633 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
1634 * menu.c (ensure_menu_items): Rename from grow_menu_items.
1635 It now merely ensures that the menu is large enough, without
1636 necessarily growing it, as this avoids some integer overflow issues.
1637 All callers changed.
1638 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1639 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1640 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1641 Use SAFE_ALLOCA_LISP, not alloca.
1642 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1643 to EMACS_INT. Check that fixnums are in proper range for system types.
1644 * minibuf.c (minibuf_prompt_width, string_to_object)
1645 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1646 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1647 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1648 (get_minibuffer, read_minibuf_unwind):
1649 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1650 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1651 this simplifies overflow checking. All callers changed.
1652 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1654 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1655 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1656 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1657 Check that fixnums are in proper range for system types.
1658 (Fx_create_frame, Fx_show_tip):
1659 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1660 * nsfont.m (ns_findfonts, nsfont_list_family):
1661 Don't assume fixnum fits in long.
1662 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1663 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1664 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1666 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
1667 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1668 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1669 (PRINTDECLARE, PRINTPREPARE):
1670 (strout, print_string):
1671 (print, print_preprocess, print_check_string_charset_prop)
1673 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1675 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1676 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1677 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
1678 (printchar, strout): Use xpalloc to catch size calculation overflow.
1679 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
1680 (print_error_message): Use SAFE_ALLOCA, not alloca.
1681 (print_object): Use int, not EMACS_INT, where int is wide enough.
1682 (print_depth, new_backquote_output, print_number_index):
1683 Use ptrdiff_t, not int, where int might not be wide enough.
1684 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1685 (Fset_process_window_size, Fformat_network_address)
1686 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
1688 Check that fixnums are in proper range for system types.
1689 (Fsignal_process): Simplify by avoiding a goto.
1690 Check for process-ids out of pid_t range rather than relying on
1692 (process_tick, update_tick): Use EMACS_INT, not int.
1693 (Fformat_network_address, read_process_output, send_process)
1694 (Fprocess_send_region, status_notify):
1695 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1696 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1697 (wait_reading_process_output, read_process_output, exec_sentinel):
1698 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1699 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1700 (Faccept_process_output): Use duration_to_sec_usec to do proper
1701 overflow checking on durations.
1702 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1703 Don't assume pid_t fits in int.
1704 * process.h (struct Lisp_Process): Members tick and update_tick
1705 are now of type EMACS_INT, not int.
1706 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1707 configured --with-wide-int.
1708 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1709 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1710 * search.c (looking_at_1, string_match_1):
1711 (fast_string_match, fast_c_string_match_ignore_case)
1712 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1713 (scan_newline, find_before_next_newline, search_command)
1714 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1715 (set_search_regs, wordify):
1718 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1719 (string_match_1, search_buffer, set_search_regs):
1721 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1722 (wordify): Check for overflow in size calculation.
1723 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1724 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1725 Check that fixnums are in proper range for system types.
1726 * sound.c (struct sound_device)
1727 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1728 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1729 (Fplay_sound_internal):
1730 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1731 * syntax.c (struct lisp_parse_state, find_start_modiff)
1732 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1733 (Fparse_partial_sexp):
1734 Don't assume fixnums can fit in int.
1735 (struct lisp_parse_state, find_start_pos, find_start_value)
1736 (find_start_value_byte, find_start_begv)
1737 (update_syntax_table, char_quoted, dec_bytepos)
1738 (find_defun_start, prev_char_comend_first, back_comment):
1739 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1740 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1741 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1742 (Finternal_describe_syntax_value): Check that match_lisp is a
1743 character, not an integer, since the code stuffs it into int.
1744 (scan_words, scan_sexps_forward):
1745 Check that fixnums are in proper range for system types.
1747 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1748 (scan_sexps_forward):
1749 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1750 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1751 * syntax.h: Adjust decls to match defn changes elsewhere.
1752 (struct gl_state_s):
1753 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1754 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1755 MOST_POSITIVE_FIXNUM.
1756 * sysdep.c (wait_for_termination_1, wait_for_termination)
1757 (interruptible_wait_for_termination, mkdir):
1758 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1759 (emacs_read, emacs_write):
1760 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1761 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1762 and double all fit in int.
1763 * term.c (set_tty_color_mode):
1764 Check that fixnums are in proper range for system types.
1765 * termhooks.h (struct input_event):
1766 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1767 * textprop.c (validate_interval_range, interval_of)
1768 (Fadd_text_properties, set_text_properties_1)
1769 (Fremove_text_properties, Fremove_list_of_text_properties)
1770 (Ftext_property_any, Ftext_property_not_all)
1771 (copy_text_properties, text_property_list, extend_property_ranges)
1772 (verify_interval_modification):
1773 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1774 (Fnext_single_char_property_change)
1775 (Fprevious_single_char_property_change):
1776 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1777 (copy_text_properties):
1778 Check for integer overflow in index calculation.
1779 * undo.c (last_boundary_position, record_point, record_insert)
1780 (record_delete, record_marker_adjustment, record_change)
1781 (record_property_change):
1782 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1783 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1784 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1785 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1786 (Fx_hide_tip, Fx_file_dialog):
1787 * w32menu.c (set_frame_menubar):
1788 Use ptrdiff_t, not int, for consistency with rest of code.
1789 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1790 (select_window, Fdelete_other_windows_internal)
1791 (window_scroll_pixel_based, window_scroll_line_based)
1792 (Frecenter, Fset_window_configuration):
1793 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1794 (Fset_window_hscroll, run_window_configuration_change_hook)
1795 (set_window_buffer, temp_output_buffer_show, scroll_command)
1796 (Fscroll_other_window, Frecenter):
1797 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1798 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1799 Don't assume fixnum fits in int.
1800 (Fset_window_scroll_bars):
1801 Check that fixnums are in proper range for system types.
1802 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1803 (string_pos, c_string_pos, number_of_chars, init_iterator)
1804 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1805 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1806 (compute_display_string_end, handle_face_prop)
1807 (face_before_or_after_it_pos, handle_invisible_prop)
1808 (handle_display_prop, handle_display_spec, handle_single_display_spec)
1809 (display_prop_intangible_p, string_buffer_position_lim)
1810 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1811 (get_overlay_strings_1, get_overlay_strings)
1812 (iterate_out_of_display_property, forward_to_next_line_start)
1813 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1814 (get_next_display_element, set_iterator_to_next)
1815 (get_visually_first_element, compute_stop_pos_backwards)
1816 (handle_stop_backwards, next_element_from_buffer)
1817 (move_it_in_display_line_to, move_it_in_display_line)
1818 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1819 (add_to_log, message_dolog, message_log_check_duplicate)
1820 (message2, message2_nolog, message3, message3_nolog
1821 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1822 (current_message_1, truncate_echo_area, truncate_message_1)
1823 (set_message, set_message_1, store_mode_line_noprop)
1824 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1825 (text_outside_line_unchanged_p, check_point_in_composition)
1826 (reconsider_clip_changes)
1827 (redisplay_internal, set_cursor_from_row, try_scrolling)
1828 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1829 (redisplay_window, find_last_unchanged_at_beg_row)
1830 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1831 (trailing_whitespace_p, find_row_edges, display_line)
1832 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1833 (display_mode_element, store_mode_line_string)
1834 (pint2str, pint2hrstr, decode_mode_spec)
1835 (display_count_lines, display_string, draw_glyphs)
1836 (x_produce_glyphs, x_insert_glyphs)
1837 (rows_from_pos_range, mouse_face_from_buffer_pos)
1838 (fast_find_string_pos, mouse_face_from_string_pos)
1839 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1840 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1841 (safe_call, init_from_display_pos, handle_fontified_prop)
1842 (handle_single_display_spec, load_overlay_strings)
1843 (with_echo_area_buffer, setup_echo_area_for_printing)
1844 (display_echo_area, echo_area_display)
1845 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1846 (update_tool_bar, hscroll_window_tree, redisplay_internal)
1847 (redisplay_window, dump_glyph_row, display_mode_line)
1848 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
1849 (handle_display_spec, display_prop_string_p):
1850 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1851 (handle_single_display_spec, build_desired_tool_bar_string)
1852 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1853 (get_specified_cursor_type):
1854 Check that fixnums are in proper range for system types.
1855 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1856 (Flookup_image_map):
1857 Don't assume fixnums fit in int.
1858 (compare_overlay_entries):
1859 Avoid mishandling comparisons due to subtraction overflow.
1860 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1861 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1862 (handle_tool_bar_click):
1863 Use int, not unsigned, since we prefer signed and the signedness
1864 doesn't matter here.
1865 (get_next_display_element, next_element_from_display_vector):
1866 Use int, not EMACS_INT, when int is wide enough.
1867 (start_hourglass): Use duration_to_sec_usec to do proper
1868 overflow checking on durations.
1869 * xfaces.c (Fbitmap_spec_p):
1870 Check that fixnums are in proper range for system types.
1871 (compare_fonts_by_sort_order):
1872 Avoid mishandling comparisons due to subtraction overflow.
1873 (Fx_family_fonts, realize_basic_faces):
1874 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1876 Don't assume fixnum fits in int.
1877 Use SAFE_ALLOCA_LISP, not alloca.
1878 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1879 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1880 (face_at_buffer_position, face_for_overlay_string)
1881 (face_at_string_position):
1882 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1883 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1884 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1886 Check that fixnums are in proper range for system types.
1887 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1888 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1889 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1890 (Fx_change_window_property): Don't assume fixnums fit in int.
1891 * xfont.c (xfont_chars_supported):
1892 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1893 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1894 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1895 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1896 * xml.c (parse_region):
1897 * xrdb.c (magic_file_p):
1898 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1899 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1900 (x_get_local_selection, x_reply_selection_request)
1901 (x_handle_selection_request, wait_for_property_change):
1902 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1903 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1904 short is wide enough.
1905 (x_send_client_event): Don't assume fixnum fits in int.
1906 * xterm.c (x_x_to_emacs_modifiers):
1907 Don't assume EMACS_INT overflows nicely into int.
1908 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1910 (handle_one_xevent): NATNUMP can eval its arg twice.
1911 (x_connection_closed):
1912 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1913 * xterm.h: Adjust decls to match defn changes elsewhere.
1914 (struct scroll_bar): Use struct vectorlike_header
1915 rather than rolling our own approximation.
1916 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1918 2012-05-25 Glenn Morris <rgm@gnu.org>
1920 * lisp.mk (lisp): Update for more files being compiled now.
1922 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1924 * lread.c: Remove `read_pure' which makes no difference.
1925 (read_pure): Remove var.
1926 (unreadpure): Remove function.
1927 (readevalloop): Don't call read_list with -1 flag.
1928 (read1, read_vector): Don't test read_pure any more.
1929 (read_list): Simplify.
1931 * fileio.c, character.h: Minor style tweaks.
1933 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1935 * window.h (clip_changed): Remove useless declaration.
1937 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
1939 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1940 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1942 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1945 This directory predates autoconf and is no longer needed nowadays.
1946 Move its few remaining bits of functionality to where they're needed.
1947 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1948 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1949 * m/template.h: Remove.
1950 * Makefile.in (M_FILE): Remove. All uses removed.
1951 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1952 * lisp.h (USE_LSB_TAG):
1953 * mem-limits.h (EXCEEDS_LISP_PTR):
1954 Use VAL_MAX, not VALBITS, in #if.
1955 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1956 (EMACS_UINT): Define unconditionally now.
1957 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1958 (BITS_PER_EMACS_INT): New constants, replacing
1959 what used to be in config.h, but not useful in #if.
1960 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1961 define them any more.
1962 (VAL_MAX): New macro.
1964 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1965 BITS_PER_EMACS_INT, in #if.
1966 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1967 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1968 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1969 * s/ms-w32.h (DATA_START):
1970 Move here from removed file m/intel386.h.
1971 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1972 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1974 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1976 Assume C89 or later.
1977 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1978 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1980 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1981 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1982 * textprop.c, tparam.c (NULL): Remove.
1983 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1984 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1985 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1986 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1987 * xterm.c (input_signal_count): Assume volatile works.
1989 2012-05-21 Ken Brown <kbrown@cornell.edu>
1991 * xgselect.c (xg_select): Fix first argument in call to 'select'
1994 2012-05-20 Ken Brown <kbrown@cornell.edu>
1996 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
1997 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1999 2012-05-19 Ken Brown <kbrown@cornell.edu>
2001 * xfns.c (x_in_use): Remove `static' qualifier.
2002 * xterm.h (x_in_use): Declare.
2003 * xgselect.c: Include xterm.h.
2004 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2005 and `display_arg' (bug#9754).
2007 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2009 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2011 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2012 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2014 2012-05-18 Eli Zaretskii <eliz@gnu.org>
2016 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2018 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2019 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2021 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2022 reference to image_cache->refcount.
2023 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2025 2012-05-17 Juri Linkov <juri@jurta.org>
2027 * search.c (Fword_search_regexp, Fword_search_backward)
2028 (Fword_search_forward, Fword_search_backward_lax)
2029 (Fword_search_forward_lax): Move functions to isearch.el
2030 (bug#10145, bug#11381).
2032 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2034 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2036 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2038 * lread.c (init_obarray): Declare Qt and Qnil as special.
2040 2012-05-14 Glenn Morris <rgm@gnu.org>
2042 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
2043 Put "libexec" before "bin", for the sake of init_callproc_1.
2045 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2047 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2049 * unexaix.c: Port to more-recent AIX compilers.
2050 (report_error, report_error_1, make_hdr, copy_sym)
2051 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2052 Make arguments const char *, not char *, to avoid violations of C
2053 standard and to fix some AIX warnings reported by Gilles Pion.
2055 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2057 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2058 already have overlays loaded.
2059 (handle_single_display_spec): Before returning without displaying
2060 fringe bitmap, synchronize the bidi iterator with the main display
2061 iterator, by calling iterate_out_of_display_property.
2062 (iterate_out_of_display_property): Detect buffer iteration by
2063 testing that it->string is a Lisp string.
2064 (get_next_display_element): When the current object is exhausted,
2065 and there's something on it->stack, call set_iterator_to_next to
2066 proceed with what's on the stack, instead of returning zero.
2067 (set_iterator_to_next): If called at the end of a Lisp string,
2068 proceed to consider_string_end without incrementing string
2069 position. Don't increment display vector index past the end of
2070 the display vector. (Bug#11417)
2071 (pos_visible_p): Don't report a position visible when move_it_to
2072 stopped at the last line of window, which happens to be scanned
2073 backwards by the bidi iteration. (Bug#11464)
2075 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2077 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2078 and right-margin display specs even if the spec is invalid or we
2079 are on a TTY, and thus unable to display on the fringes.
2080 That's because the text with the property will not be displayed anyway,
2081 so we need to signal to the caller that this is a "replacing"
2082 display spec. This fixes display when the spec is invalid or we
2085 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2087 * unexaix.c (make_hdr): Fix typo in prototype.
2088 This bug broke the build on AIX. Problem reported by Gilles Pion.
2090 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
2092 * keyboard.c (kbd_buffer_get_event): Read special events also in
2093 batch mode. (Bug#11415)
2095 2012-05-12 Glenn Morris <rgm@gnu.org>
2097 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2099 2012-05-12 Eli Zaretskii <eliz@gnu.org>
2101 * lisp.mk (lisp): Add newcomment.elc.
2103 2012-05-12 Glenn Morris <rgm@gnu.org>
2105 * Makefile.in (MKDIR_P): New, set by configure.
2106 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2108 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2110 Remove unused function hourglass_started.
2111 * dispextern.h (hourglass_started):
2112 * w32fns.c (hourglass_started):
2113 * xdisp.c (hourglass_started): Remove.
2115 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
2117 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2118 Update dependencies.
2120 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2122 * xgselect.c (xg_select): Put maxfds+1 into a var.
2123 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2125 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2127 2012-05-10 Dave Abrahams <dave@boostpro.com>
2129 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2130 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2132 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
2134 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2135 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2136 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2137 Initialize xd_registered_buses.
2139 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2141 Untag more efficiently if USE_LSB_TAG.
2142 This is based on a proposal by YAMAMOTO Mitsuharu in
2143 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2144 For an admittedly artificial (nth 8000 longlist) benchmark on
2145 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2146 Emacs's overall text size by 1%.
2147 * lisp.h (XUNTAG): New macro.
2148 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2149 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2150 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2151 * eval.c (Fautoload):
2152 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2153 * frame.h (XFRAME): Use XUNTAG.
2155 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2156 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2157 Remove unportable assumptions about print widths of types like
2159 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2160 intptr_t when converting between pointer and integer, to avoid GCC
2161 warnings about wrong width.
2163 2012-05-09 Eli Zaretskii <eliz@gnu.org>
2165 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2166 stack for each reader_thread, instead of defaulting to 8MB
2167 determined by the linker. This avoids failures in creating
2168 subprocesses on Windows 7, see the discussion in this thread:
2169 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2171 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2173 Fix up display of the *Minibuf-0* buffer in the mini window.
2174 * keyboard.c (read_char): Don't clear the echo area if there's no
2176 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2177 contents of *Minibuf-0*) if there's no message displayed in its stead.
2179 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
2181 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2184 2012-05-06 Chong Yidong <cyd@gnu.org>
2186 * lisp.mk (lisp): Update.
2188 2012-05-05 Jim Meyering <meyering@redhat.com>
2190 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2192 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2194 * data.c (PUT_ERROR): New macro.
2195 (syms_of_data): Use it. Add new error type `user-error'.
2196 * undo.c (user_error): New function.
2197 (Fprimitive_undo): Use it.
2198 * print.c (print_error_message): Adjust print style for `user-error'.
2199 * keyboard.c (user_error): New function.
2200 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2202 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2204 Do not limit current-time-string to years 1000..9999.
2205 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2206 (Fcurrent_time_string): Support any year that is supported by the
2207 underlying localtime representation. Don't use asctime, as it
2208 has undefined behavior for years outside the range -999..9999.
2210 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2212 Fix race conditions involving setenv, gmtime, localtime, asctime.
2213 Without this fix, interrupts could mess up code that uses these
2214 nonreentrant functions, since setting TZ invalidates existing
2215 tm_zone or tzname values, and since most of these functions return
2216 pointers to static storage.
2217 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2218 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2219 Grow the critical sections to include not just invoking
2220 localtime/gmtime, but also accessing these functions' results
2221 including their tm_zone values if any, and any related TZ setting.
2222 (format_time_string): Last arg is now struct tm *, not struct tm **,
2223 so that the struct tm is saved in the critical section.
2224 All callers changed. Simplify allocation of initial buffer, partly
2225 motivated by the fact that memory allocation needs to be outside
2226 the critical section.
2228 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2230 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2231 with RESET_INTERVAL.
2233 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2234 Remove duplicated buffer name initialization.
2236 2012-05-02 Jim Meyering <jim@meyering.net>
2238 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2240 * xfns.c (x_window): Use xstrdup (Bug#11375).
2242 2012-05-02 Eli Zaretskii <eliz@gnu.org>
2244 * xdisp.c (pos_visible_p): If already at a newline from the
2245 display string before the 'while' loop, don't walk back the glyphs
2246 from it3.glyph_row. Solves assertion violation when the display
2247 string begins with a newline (egg.el). (Bug#11367)
2249 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2251 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2254 2012-05-01 Glenn Morris <rgm@gnu.org>
2256 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2257 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2258 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2259 All were removed before 23.1.
2261 * dispnew.c: Remove HAVE_LIBNCURSES test;
2262 it is always true on relevant platforms.
2264 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2265 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2267 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2269 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2271 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2272 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2275 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2277 Do not avoid creating empty evaporating overlays (Bug#9642).
2278 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2279 That is, do not delete an evaporating overlay if it becomes
2280 empty after its bounds are adjusted to fit within its buffer.
2281 This fix caused other problems, and I'm reverting it until we get
2282 to the bottom of them.
2284 2012-04-27 Chong Yidong <cyd@gnu.org>
2286 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2288 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2290 * xdisp.c (pos_visible_p): If the window start position is beyond
2291 ZV, start the display from buffer beginning. Prevents assertion
2292 violation in init_iterator when the minibuffer window is scrolled
2295 * window.c (window_scroll_pixel_based): Likewise.
2297 2012-04-27 Chong Yidong <cyd@gnu.org>
2299 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2301 2012-04-27 Glenn Morris <rgm@gnu.org>
2303 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2304 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2306 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2308 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2309 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
2311 2012-04-26 Eli Zaretskii <eliz@gnu.org>
2313 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2314 display element, check also the underlying string or buffer
2315 character. (Bug#11341)
2317 * w32menu.c: Include w32heap.h.
2318 (add_menu_item): If the call to AppendMenuW (via
2319 unicode_append_menu) fails, disable Unicode menus only if we are
2320 running on Windows 9X/Me.
2322 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2324 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2325 (xgetint): Add missing shift for LSB tags.
2327 2012-04-24 Martin Rudalics <rudalics@gmx.at>
2329 * keyboard.c (read_char): Don't wipe echo area for select window
2330 events: These might get delayed via `mouse-autoselect-window'
2333 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
2335 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2336 manipulation of :loaded-from data.
2338 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
2340 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2341 now a cons (bug#11311).
2343 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2345 Do not create empty overlays with the evaporate property (Bug#9642).
2346 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2347 if it becomes empty after its bounds are adjusted to fit within
2348 its buffer. Without this fix, in a nonempty buffer (let ((o
2349 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2350 yields an empty overlay that has the evaporate property, which is
2351 not supposed to happen.
2353 Fix minor GTK3 problems found by static checking.
2354 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2355 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2356 (struct _EmacsFixedClass, emacs_fixed_get_type):
2357 Move decls here from emacsgtkfixed.h, since they needn't be public.
2358 (emacs_fixed_get_type): Now static.
2359 (emacs_fixed_class_init): Omit unused local.
2360 (emacs_fixed_child_type): Remove; unused.
2361 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2362 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2363 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2364 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2365 (EMACS_FIXED_GET_CLASS): Remove; unused.
2366 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2368 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2369 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2371 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2373 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
2374 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
2375 (__malloc_size_t, __malloc_ptrdiff_t):
2376 Remove. All uses removed, replaced by the definiens if needed,
2377 since we can assume C89 or better now.
2378 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2379 (protect_malloc_state, align, get_contiguous_space)
2380 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2381 (malloc_atfork_handler_child, malloc_enable_thread)
2382 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2383 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2384 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2385 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2386 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2387 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2388 Define using prototypes, not old style.
2389 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2390 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2391 (align): Don't assume that signed integer overflow wraps around.
2392 Omit unused local var.
2393 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2394 (_free_internal_nolock, memalign, mallochook, reallochook):
2395 Omit no-longer-needed casts.
2396 (valloc): Use getpagesize, not __getpagesize.
2397 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2398 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2400 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2402 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
2404 Move functions from C to Lisp. Make non-blocking method calls
2405 the default. Implement further D-Bus standard interfaces.
2407 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2408 (QCdbus_request_name_allow_replacement)
2409 (QCdbus_request_name_replace_existing)
2410 (QCdbus_request_name_do_not_queue)
2411 (QCdbus_request_name_reply_primary_owner)
2412 (QCdbus_request_name_reply_in_queue)
2413 (QCdbus_request_name_reply_exists)
2414 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2415 (QCdbus_registered_serial, QCdbus_registered_method)
2416 (QCdbus_registered_signal): New Lisp objects.
2417 (XD_DEBUG_MESSAGE): Use sizeof.
2418 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2419 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2420 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2421 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2422 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2423 (xd_signature, xd_append_arg): Allow float for integer types.
2424 (xd_get_connection_references): New function.
2425 (xd_get_connection_address): Rename from xd_initialize.
2426 Return cached address.
2427 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2428 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2430 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
2431 Return number of refcounts.
2432 (Fdbus_get_unique_name): Make stronger parameter check.
2433 (Fdbus_message_internal): New defun.
2434 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2435 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2436 (Fdbus_send_signal, Fdbus_register_service)
2437 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2438 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2439 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2440 (Vdbus_compiled_version, Vdbus_runtime_version)
2441 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2442 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2443 (Vdbus_message_type_signal): New defvars.
2444 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2447 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2449 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2450 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2451 Do not assume ptrdiff_t is the same width as 'int'.
2453 * alloc.c: Handle unusual debugging option combinations.
2454 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2455 since the two debugging options are incompatible.
2456 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2458 (mem_init, mem_insert, mem_insert_fixup):
2459 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2460 (NEED_MEM_INSERT): Remove; no longer needed.
2462 2012-04-22 Leo Liu <sdl.web@gmail.com>
2464 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2466 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2468 * sysdep.c [__FreeBSD__]: Minor cleanups.
2469 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2470 Use Emacs indenting style more consistently. Avoid some casts.
2471 Use 'double' consistently rather than mixing 'float' and 'double'.
2473 2012-04-21 Eduard Wiebe <usenet@pusto.de>
2475 * sysdep.c (list_system_processes, system_process_attributes):
2476 Add implementation for FreeBSD (Bug#5243).
2478 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2480 * lisp.mk (lisp): Update.
2482 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2484 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2485 It is never used otherwise.
2487 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2489 * print.c (print_preprocess): Only check print_depth if print-circle
2491 (print_object): Check for cycles even when print-circle is nil and
2492 print-gensym is t, but only check print_depth if print-circle is nil.
2494 2012-04-20 Chong Yidong <cyd@gnu.org>
2496 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2497 set the status to "failed" and ensure that sentinel is run.
2499 2012-04-20 Glenn Morris <rgm@gnu.org>
2501 * process.c (Fset_process_inherit_coding_system_flag)
2502 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
2503 (Fmake_network_process, Fmake_serial_process): Doc fix.
2505 2012-04-20 Eli Zaretskii <eliz@gnu.org>
2507 * xdisp.c (string_buffer_position_lim): Limit starting position to
2509 (set_cursor_from_row): If called for a mode-line or header-line
2510 row, return zero immediately.
2511 (try_cursor_movement): If inside continuation line, don't back up
2512 farther than the first row after the header line, if any.
2513 Don't consider the header-line row as "partially visible", even if
2514 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2516 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2518 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2521 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
2522 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
2524 configure: new option --enable-gcc-warnings (Bug#11207)
2525 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2526 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2527 (ALL_CFLAGS): Use new macros rather than old.
2528 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2529 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2530 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2531 -Wunused-result, -Wunused-variable. This should go away once
2532 the Emacs and Gnulib regex code is merged.
2533 (xmalloc, xrealloc): Now static.
2535 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2537 * dired.c (Fsystem_groups): Remove unused local.
2539 2012-04-17 Glenn Morris <rgm@gnu.org>
2541 * dired.c (Fsystem_users): Doc fix.
2543 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2545 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2546 (syms_of_dired): Add them.
2548 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2550 Fix minor alloc.c problems found by static checking.
2551 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2552 New extern decls, to avoid calling undeclared functions.
2553 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2554 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2555 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2556 (NEED_MEM_INSERT): New macro.
2557 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
2558 Remove one incorrect comment and fix another.
2560 Fix minor ralloc.c problems found by static checking.
2561 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2562 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2563 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2564 (r_alloc_sbrk): Now static.
2566 Improve ralloc.c interface checking.
2567 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2568 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2569 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2570 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2571 [REL_ALLOC]: ... to here, to check interface.
2572 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2573 Remove decls. This fixes an "It stinks!".
2575 * alloc.c (which_symbols): Fix alignment issue / type clash.
2577 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2579 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2580 (struct Lisp_Misc_Any): Likewise.
2581 (struct Lisp_Free): Likewise.
2582 * alloc.c (union aligned_Lisp_Symbol): Define.
2583 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2584 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2585 (union aligned_Lisp_Misc): Define.
2586 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2587 aligned_Lisp_Misc instead of union Lisp_Misc.
2588 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
2590 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2592 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2593 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2594 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2595 * s/netbsd.h, s/sol2-6.h:
2596 Remove definition of GC_MARK_STACK, since the default now works.
2597 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2598 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2599 no longer the default.
2600 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2602 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2604 * lread.c (lisp_file_lexically_bound_p):
2605 Fix hang at ";-*-\n" (bug#11238).
2607 2012-04-14 Eli Zaretskii <eliz@gnu.org>
2609 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2610 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2612 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2614 * nsterm.m (constrainFrameRect): Always constrain when there is only
2615 one screen (Bug#10962).
2617 2012-04-13 Ken Brown <kbrown@cornell.edu>
2619 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2621 2012-04-13 Reuben Thomas <rrt@sc3d.org>
2623 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2625 2012-04-11 Daniel Colascione <dancol@dancol.org>
2627 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2628 against is gone. It's better to use vfork now so that when Cygwin
2629 gains a new, working vfork, we use it automatically (bug#10398).
2631 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2633 * window.c (save_window_save): Obey window-point-insertion-type.
2635 2012-04-11 Glenn Morris <rgm@gnu.org>
2637 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2639 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2641 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2643 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
2645 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2646 (force_quit_count): New var.
2647 (handle_interrupt): Use it.
2649 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
2651 * w32.c (w32_delayed_load): Record the full path of the library
2652 being loaded (bug#10424).
2654 2012-04-09 Glenn Morris <rgm@gnu.org>
2656 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2657 not just in the obarray, before snarfing them. (Bug#11036)
2659 * Makefile.in ($(leimdir)/leim-list.el):
2660 Pass EMACS rather than BUILT_EMACS.
2662 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2664 * process.c (make_process):
2665 * process.h: Add integer `gnutls_handshakes_tried' member to
2668 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2669 Add convenience `GNUTLS_LOG2i' macro.
2671 * gnutls.c (gnutls_log_function2i): Convenience log function.
2672 (emacs_gnutls_read): Use new log functions,
2673 `gnutls_handshakes_tried' process member, and
2674 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2675 attempts per process (connection).
2677 2012-04-09 Chong Yidong <cyd@gnu.org>
2679 * eval.c (Fuser_variable_p, user_variable_p_eh)
2680 (lisp_indirect_variable): Functions deleted.
2681 (Fdefvar): Caller changed.
2683 * callint.c (Finteractive, Fcall_interactively):
2684 * minibuf.c (Fread_variable): Callers changed.
2686 2012-04-09 Eli Zaretskii <eliz@gnu.org>
2688 * xdisp.c (set_cursor_from_row): If the display string appears in
2689 the buffer at position that is closer to point than the position
2690 after the display string, display the cursor on the first glyph of
2691 the display string. Fixes cursor display when a 'display' text
2692 property immediately follows invisible text. (Bug#11094)
2694 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2696 composite.c: use 'double' consistently
2697 * composite.c (get_composition_id): Use 'double' consistently
2698 instead of converting 'float' to 'double' and vice versa; this is
2699 easier to understand and avoids a GCC warning.
2701 2012-04-09 Glenn Morris <rgm@gnu.org>
2703 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2704 preparation for dumping it with emacs. (Bug#4789)
2705 (leimdir): New variable.
2706 ($(leimdir)/leim-list.el): New rule.
2707 (emacs$(EXEEXT)): Depend on leim-list.el.
2709 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2710 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2711 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2713 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2715 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2718 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
2720 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2721 Remove unused local variable.
2723 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2725 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2726 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2727 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2728 objects, as mark_maybe_pointer will catch them otherwise.
2729 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2730 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2732 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2734 Fix typo that broke non-Windows builds.
2735 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2737 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2739 Support building on MS-Windows with libxml2.
2741 * makefile.w32-in (OBJ2): Add xml.$(O).
2742 (GLOBAL_SOURCES): Add xml.c.
2743 ($(BLD)/xml.$(O)): New dependency list.
2745 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2746 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2747 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2748 [!WINDOWSNT]: New macros.
2749 (init_libxml2_functions, libxml2_loaded_p): New functions.
2750 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2751 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2752 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2753 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2755 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2756 Call init_libxml2_functions before calling libxml2 functions.
2757 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2759 * emacs.c: Don't include libxml/parser.h.
2760 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2761 xmlCleanupParser directly.
2763 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2765 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2767 * indent.c (Fvertical_motion): If there is a display string at
2768 point, use it.vpos to compute how many lines to backtrack after
2769 move_it_to point. (Bug#11133)
2771 2012-04-06 Eli Zaretskii <eliz@gnu.org>
2773 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2774 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2775 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2776 macros related to unification of CJK characters. For the details,
2777 see the discussion following the message here:
2778 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2780 2012-04-04 Chong Yidong <cyd@gnu.org>
2782 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2784 2012-04-01 Eli Zaretskii <eliz@gnu.org>
2786 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2787 instead of alloca. (Bug#11138)
2789 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2791 * w32menu.c (is_simple_dialog): Properly check lisp types.
2794 2012-03-31 Eli Zaretskii <eliz@gnu.org>
2796 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2797 position we get to after a call to move_it_to fails the
2798 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2799 only if we wind up in a string from display property. (Bug#11063)
2801 * window.c (Fdelete_other_windows_internal): Invalidate the row
2802 and column information about mouse highlight, so that redisplay
2803 restores it after reallocating the glyph matrices. (Bug#7464)
2805 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2806 string comes from a `display' text property, use the buffer
2807 position of that property as if we actually saw that position in
2809 (move_it_by_lines): Remove the assertion that
2810 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2811 violated when there's a before-string at the beginning of a line.
2814 2012-03-30 Eli Zaretskii <eliz@gnu.org>
2816 * xdisp.c (append_space_for_newline): If the default face was
2817 remapped, use the remapped face for the appended newline.
2818 (extend_face_to_end_of_line): Use the remapped default face for
2819 extending the face to the end of the line.
2820 (display_line): Call extend_face_to_end_of_line when the default
2821 face was remapped. (Bug#11068)
2823 2012-03-29 Eli Zaretskii <eliz@gnu.org>
2825 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2827 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2829 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2831 2012-03-27 Glenn Morris <rgm@gnu.org>
2833 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2836 2012-03-26 Kenichi Handa <handa@m17n.org>
2838 * dispextern.h (struct glyph): Fix previous change. Change the
2839 bit length of glyphless.ch to 25 (Bug#11082).
2841 2012-03-26 Chong Yidong <cyd@gnu.org>
2843 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2844 (command_loop_1): Use it; inhibit selection update for
2845 handle-select-window too (Bug#8996).
2847 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2849 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
2851 2012-03-25 Kenichi Handa <handa@m17n.org>
2853 * dispextern.h (struct glyph): Change the bit length of
2854 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2856 2012-03-24 Eli Zaretskii <eliz@gnu.org>
2858 * s/ms-w32.h (tzname): Include time.h before redirecting to
2859 _tzname. Fixes the MSVC build. (Bug#9960)
2861 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2863 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2866 * xterm.c (XTread_socket): Only modify handling_signal if
2867 !SYNC_INPUT. (Bug#11080)
2869 2012-03-23 Eli Zaretskii <eliz@gnu.org>
2871 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2872 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2873 when fetching a multibyte character consumes more bytes than
2874 CHAR_BYTES returns, due to unification of CJK characters in
2875 string_char. (Bug#11073)
2877 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2879 * process.c (wait_reading_process_output): Handle pty disconnect
2880 by refraining from sending oneself a SIGCHLD (bug#10933).
2882 2012-03-22 Chong Yidong <cyd@gnu.org>
2884 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2886 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
2887 Mark string as coming from a prefix property.
2888 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2889 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2891 2012-03-21 Chong Yidong <cyd@gnu.org>
2893 * xfaces.c (Vface_remapping_alist): Doc fix.
2895 2012-03-20 Eli Zaretskii <eliz@gnu.org>
2897 * w32proc.c (Fw32_set_console_codepage)
2898 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2901 2012-03-20 Chong Yidong <cyd@gnu.org>
2903 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2904 to reflect default non-nil value of redisplay-dont-pause.
2906 2012-03-19 Kenichi Handa <handa@m17n.org>
2908 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2909 it fit in a valid range (Bug#11003).
2911 2012-03-18 Eli Zaretskii <eliz@gnu.org>
2913 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2914 that is not from display property, accept the row as a "cursor
2915 row" if one of the string's character has a non-nil `cursor'
2916 property. Fixes cursor positioning when there are newlines in
2917 overlay strings, e.g. in icomplete.el. (Bug#11035)
2919 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2921 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2923 2012-03-12 Chong Yidong <cyd@gnu.org>
2925 * eval.c (inhibit_lisp_code): Rename from
2926 inhibit_window_configuration_change_hook; move from window.c.
2928 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2929 * window.c (run_window_configuration_change_hook)
2930 (syms_of_window): Callers changed.
2932 2012-03-11 Chong Yidong <cyd@gnu.org>
2934 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2936 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2938 2012-03-10 Chong Yidong <cyd@gnu.org>
2940 * frame.c (other_visible_frames): Don't assume the selected frame
2941 is visible (Bug#10955).
2943 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2945 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2947 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2949 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2950 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2953 2012-03-03 Glenn Morris <rgm@gnu.org>
2955 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
2957 2012-03-02 Eli Zaretskii <eliz@gnu.org>
2959 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2960 position past the first glyph_row that ends at ZV. (Bug#10902)
2961 (redisplay_window, next_element_from_string): Fix typos in
2963 (redisplay_window): Pass to move_it_vertically the margin in
2964 pixels, not in screen lines.
2966 2012-03-02 Glenn Morris <rgm@gnu.org>
2968 * buffer.c (buffer-list-update-hook): Doc fix.
2970 2012-02-29 Eli Zaretskii <eliz@gnu.org>
2972 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2973 push_it before setting up the iterator for the first overlay
2974 string, even if we have an empty string loaded.
2975 (next_overlay_string): If there's an empty string on the iterator
2976 stack, pop the stack. (Bug#10903)
2978 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2980 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2981 Suggested by Stefan Monnier in
2982 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2983 * alloc.c (widen_to_Lisp_Object): New static function.
2984 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2985 and widening them to Lisp_Objects. This would work even if
2986 USE_LSB_TAG is defined and wide integers are used, which might
2987 happen in a future version of Emacs.
2989 2012-02-25 Chong Yidong <cyd@gnu.org>
2991 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2994 * xselect.c (Fx_selection_exists_p): Doc fix.
2995 (x_clipboard_manager_save_all): Print an informative message
2996 before saving to clipboard manager.
2998 2012-02-24 Chong Yidong <cyd@gnu.org>
3000 * keyboard.c (process_special_events): Handle all X selection
3001 requests in kbd_buffer, not just the next one (Bug#8869).
3003 2012-02-23 Chong Yidong <cyd@gnu.org>
3005 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3006 call when setting menu-bar-lines and tool-bar-lines parameters.
3007 (unwind_create_frame_1): New helper function.
3009 * window.c (inhibit_window_configuration_change_hook): New var.
3010 (run_window_configuration_change_hook): Obey it.
3011 (syms_of_window): Initialize it.
3013 2012-02-22 Chong Yidong <cyd@gnu.org>
3015 * xterm.c (x_draw_image_relief): Add missing type check for
3016 Vtool_bar_button_margin (Bug#10743).
3018 2012-02-21 Chong Yidong <cyd@gnu.org>
3020 * fileio.c (Vfile_name_handler_alist): Doc fix.
3022 * buffer.c (Fget_file_buffer): Protect against invalid file
3023 handler return value.
3025 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3027 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3028 when computing $valmask.
3030 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3031 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3032 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3033 It's useless in that case, and it can cause problems on hosts
3034 that allocate halves of EMACS_INT values separately.
3035 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3036 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3037 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3038 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3039 it avoids undefined behavior on hosts where shifting right by more
3040 than the word width has undefined behavior.
3042 2012-02-19 Chong Yidong <cyd@gnu.org>
3044 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3045 (Funhandled_file_name_directory, Ffile_name_as_directory)
3046 (Fdirectory_file_name, Fexpand_file_name)
3047 (Fsubstitute_in_file_name): Protect against invalid file handler
3048 return values (Bug#10845).
3050 2012-02-18 Eli Zaretskii <eliz@gnu.org>
3052 * .gdbinit (pitx): Fix incorrect references to fields of the
3055 2012-02-17 Chong Yidong <cyd@gnu.org>
3057 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3059 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3061 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3062 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3064 2012-02-15 Chong Yidong <cyd@gnu.org>
3066 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3067 marked as special. Also, starting docstrings with * is obsolete.
3069 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3071 * gnutls.c (emacs_gnutls_write): Fix last change.
3073 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3075 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3078 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3080 * keymap.c (Fsingle_key_description): Handle char ranges.
3082 2012-02-12 Chong Yidong <cyd@gnu.org>
3084 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3085 as that creates a dangerous corner case.
3087 * window.c (Fdelete_window_internal): Invalidate the mouse
3088 highlight (Bug#9904).
3090 2012-02-12 Glenn Morris <rgm@gnu.org>
3092 * xselect.c (Fx_own_selection_internal)
3093 (Fx_get_selection_internal, Fx_disown_selection_internal)
3094 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3095 * nsselect.m (Fx_own_selection_internal)
3096 (Fx_disown_selection_internal, Fx_selection_exists_p)
3097 (Fx_selection_owner_p, Fx_get_selection_internal):
3098 Sync docs and argument specs with the xselect.c versions.
3100 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3102 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3104 2012-02-11 Eli Zaretskii <eliz@gnu.org>
3106 * w32select.c (Fx_selection_exists_p): Sync doc string and
3107 argument list with xselect.c. (Bug#10783)
3109 * w16select.c (Fx_selection_exists_p): Sync doc string and
3110 argument list with xselect.c. (Bug#10783)
3112 2012-02-10 Glenn Morris <rgm@gnu.org>
3114 * fns.c (Fsecure_hash): Doc fix.
3116 2012-02-09 Kenichi Handa <handa@m17n.org>
3118 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3120 2012-02-07 Chong Yidong <cyd@gnu.org>
3122 * buffer.c (Fbuffer_local_variables)
3123 (buffer_lisp_local_variables): Handle unbound vars correctly;
3124 don't let Qunbound leak into Lisp.
3126 2012-02-07 Glenn Morris <rgm@gnu.org>
3128 * image.c (Fimagemagick_types): Doc fix.
3130 * image.c (imagemagick-render-type): Change it from a lisp object
3131 to an integer. Move the doc here from the lisp manual.
3132 Treat all values not equal to 0 the same.
3134 2012-02-06 Chong Yidong <cyd@gnu.org>
3136 * doc.c (store_function_docstring): Avoid applying docstring of
3137 alias to base function (Bug#2603).
3139 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3141 * .gdbinit (pp1, pv1): Remove redundant defines.
3144 2012-02-04 Chong Yidong <cyd@gnu.org>
3146 * nsterm.m: Declare a global (Bug#10694).
3148 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3150 * w32.c (get_emacs_configuration_options):
3151 Include --enable-checking, if specified, in the return value.
3153 2012-02-04 Martin Rudalics <rudalics@gmx.at>
3155 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3156 after rounding frame sizes. (Bug#9723)
3158 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3160 * keyboard.c (adjust_point_for_property): Don't position point
3161 before BEGV. (Bug#10696)
3163 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3165 Handle overflow when computing char display width (Bug#9496).
3166 * character.c (char_width): Return EMACS_INT, not int.
3167 (char_width, c_string_width): Check for overflow when
3168 computing the width; this is possible now that individual
3169 characters can have unbounded width. Problem introduced
3170 by merge from Emacs 23 on 2012-01-19.
3172 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
3174 * dbusbind.c (Fdbus_register_method): Mention the return value
3175 :ignore in the docstring.
3177 2012-02-02 Glenn Morris <rgm@gnu.org>
3179 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3181 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3182 Unconditionally set to t. (Bug#10673)
3183 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3184 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3185 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3187 2012-02-02 Kenichi Handa <handa@m17n.org>
3189 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3190 0, do not call append_composite_glyph.
3192 2012-02-02 Kenichi Handa <handa@m17n.org>
3194 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3196 (x_produce_glyphs): If the component of a composition is a null
3197 string, set it->pixel_width to 1 to avoid zero-width glyph.
3199 2012-02-01 Eli Zaretskii <eliz@gnu.org>
3201 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3202 first 2 arguments are identical. This makes inserting large
3203 output from a subprocess an order of magnitude faster on
3204 MS-Windows, where all sbrk'ed memory is always contiguous.
3206 2012-01-31 Glenn Morris <rgm@gnu.org>
3208 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3209 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3210 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3212 2012-01-29 Glenn Morris <rgm@gnu.org>
3214 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3216 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3218 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3220 2012-01-28 Chong Yidong <cyd@gnu.org>
3222 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3224 2012-01-26 Chong Yidong <cyd@gnu.org>
3226 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3228 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3229 repeat counts (Bug#10507).
3231 2012-01-26 Glenn Morris <rgm@gnu.org>
3233 * lread.c (syms_of_lread): Doc fix.
3235 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3237 * coding.c (encode_designation_at_bol): Change return value to
3240 2012-01-25 Chong Yidong <cyd@gnu.org>
3242 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3244 2012-01-21 Chong Yidong <cyd@gnu.org>
3246 * floatfns.c (Fcopysign): Make the second argument non-optional,
3247 since nil is not allowed anyway.
3249 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3251 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3252 (send_process): Likewise.
3254 2012-01-19 Martin Rudalics <rudalics@gmx.at>
3256 * window.c (save_window_save, Fcurrent_window_configuration)
3257 (Vwindow_persistent_parameters): Do not use Qstate.
3258 Rewrite doc-strings.
3260 2012-01-19 Kenichi Handa <handa@m17n.org>
3262 * character.c (char_width): New function.
3263 (Fchar_width, c_string_width, lisp_string_width):
3264 Use char_width (Bug#9496).
3266 2012-01-16 Martin Rudalics <rudalics@gmx.at>
3268 * window.c (Vwindow_persistent_parameters): New variable.
3269 (Fset_window_configuration, save_window_save): Handle persistent
3272 2012-01-14 Eli Zaretskii <eliz@gnu.org>
3274 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3275 thrashing the stack of the thread. (Bug#9087)
3277 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3279 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3281 2012-01-11 Eli Zaretskii <eliz@gnu.org>
3283 * xdisp.c (rows_from_pos_range): Handle the case where the
3284 highlight ends on a newline. (Bug#10464)
3285 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3286 he end column for display of highlight that ends on a newline
3289 2012-01-11 Glenn Morris <rgm@gnu.org>
3291 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3292 from load-path also when installation-directory is nil. (Bug#10208)
3294 2012-01-10 Glenn Morris <rgm@gnu.org>
3296 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3298 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3299 Update template values to be closer to their typical values these days.
3301 2012-01-09 Eli Zaretskii <eliz@gnu.org>
3303 * xdisp.c (rows_from_pos_range): Accept additional argument
3304 DISP_STRING, and accept any glyph in a row whose object is that
3305 string as eligible for mouse highlight. Fixes mouse highlight of
3306 display strings from overlays. (Bug#10464)
3308 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
3310 emacs: fix an auto-save permissions race condition (Bug#10400)
3311 * fileio.c (auto_saving_dir_umask): New static var.
3312 (Fmake_directory_internal): Use it.
3313 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3314 creating the directory. The old code temporarily assigns
3315 too-generous permissions to the directory.
3316 (do_auto_save_eh): Clear it.
3317 (Fdo_auto_save): Catch all errors, not just file errors, so
3318 that the var is always cleared.
3320 2012-01-07 Eli Zaretskii <eliz@gnu.org>
3322 * search.c (scan_buffer): Pass character positions to
3323 know_region_cache, not byte positions. (Bug#6540)
3325 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
3327 * w32.c (sys_rename): Report EXDEV when rename of a directory
3328 fails because the target is on another logical disk. (Bug#10284)
3330 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3332 * xterm.c (x_embed_request_focus): New function.
3334 * xterm.h: Add prototype.
3336 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3338 2012-01-05 Glenn Morris <rgm@gnu.org>
3340 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3342 2012-01-01 Eli Zaretskii <eliz@gnu.org>
3344 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3345 Load gnutls_transport_set_lowat only if GnuTLS version is below
3347 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3348 GnuTLS versions below 2.11.1.
3350 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3352 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3353 to the doc string advising against its use for altering the way
3354 windows are scrolled.
3356 2011-12-28 Kenichi Handa <handa@m17n.org>
3358 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3359 coding-system ASCII compatible only when it does not produce BOM
3360 on encoding (Bug#10383).
3362 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3364 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3366 (create_and_show_popup_menu): Always use menu_position_func for
3369 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3371 * callint.c (Fcall_interactively): Don't truncate prompt string.
3373 2011-12-23 Eli Zaretskii <eliz@gnu.org>
3375 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3376 property that ends at ZV, so that the bidi iteration could be
3377 resumed from there (after widening). (Bug#10360)
3379 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3381 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3383 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3385 * nsterm.m (x_free_frame_resources):
3386 Release f->output_data.ns->miniimage.
3387 (ns_index_color): Fix indentation. Do not retain
3388 color_table->colors[i].
3390 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3393 * nsfns.m (x_set_background_color): Assign return value from
3394 ns_index_color to face-background instead of NSColor*.
3395 (ns_implicitly_set_icon_type): Fix indentation.
3396 Change assignment in for loop to comparison.
3398 * emacs.c (ns_pool): New variable.
3399 (main): Assign ns_pool.
3400 (Fkill_emacs): Call ns_release_autorelease_pool.
3402 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3403 autorelease fdesc, release fdAttrs and tdict.
3404 (ns_get_covering_families): Release charset.
3405 (ns_findfonts): Release NSFontDescriptor created with new.
3406 (ns_uni_to_glyphs): Fix indentation.
3407 (setString): Release attrStr before assigning new value.
3409 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3411 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3413 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3414 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3416 2011-12-18 David Reitter <reitter@cmu.edu>
3418 * nsterm.m (ns_term_init): Subscribe for notifications
3419 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3420 to method trackingNotification in EmacsMenu.
3422 * nsmenu.m (trackingMenu): New variable.
3423 (trackingNotification): New method (from Aquamacs).
3424 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3425 from Aquamacs (Bug#7030).
3427 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3429 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3430 (symbol_to_nsstring): Fix indentation.
3431 (ns_symbol_to_pb): New function.
3432 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3433 (Fns_rotate_cut_buffers_internal): Remove.
3434 (Fns_store_selection_internal): Rename from
3435 Fns_store_cut_buffer_internal.
3436 (ns_get_foreign_selection, Fx_own_selection_internal)
3437 (Fx_disown_selection_internal, Fx_selection_exists_p)
3438 (Fns_get_selection_internal, Fns_store_selection_internal):
3439 Use ns_symbol_to_pb and check if return value is nil.
3440 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3441 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
3442 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3443 renamed to Sns_store_selection_internal.
3444 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3445 and remove this function.
3446 (ns_handle_selection_clear): Remove, never used.
3447 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3450 2011-12-17 Ken Brown <kbrown@cornell.edu>
3452 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3453 GID is unknown (Bug#10257).
3455 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3457 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3458 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3459 which caused a build failure on GNU/Linux IA-64. This problem was
3460 introduced by my 2011-10-07 patch.
3462 2011-12-15 Juri Linkov <juri@jurta.org>
3464 * image.c (imagemagick_error): New function. (Bug#10112)
3465 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3466 Use `imagemagick_error' where ImageMagick functions return
3468 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3471 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3473 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3474 fill background (Bug#8992).
3476 2011-12-13 Martin Rudalics <rudalics@gmx.at>
3478 * window.c (Vwindow_combination_resize)
3479 (Vwindow_combination_limit): Use t instead of non-nil in
3481 (Vrecenter_redisplay): Add first sentence of doc-string on
3483 (Frecenter): Fix doc-string typo.
3485 2011-12-11 Kenichi Handa <handa@m17n.org>
3487 * coding.c (Funencodable_char_position): Pay attention to the
3488 buffer text relocation (Bug#9389).
3490 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3492 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3493 gtk_init (Bug#10100).
3495 2011-12-10 Eli Zaretskii <eliz@gnu.org>
3497 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3498 IT->string is nil. (Bug#10263)
3500 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3502 * nsterm.h (x_free_frame_resources): Declare.
3504 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3505 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3507 * nsterm.h (ns_get_defaults_value): Declare.
3509 * nsterm.m (ns_default): Call ns_get_defaults_value.
3511 2011-12-09 Eli Zaretskii <eliz@gnu.org>
3513 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3516 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3518 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3519 that where the value of an _OBJC_* symbol points to is in the .bss
3520 section (Bug#10240).
3522 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3524 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
3525 after the loop to call ccl_driver at least once (Bug#8619).
3527 2011-12-08 Kenichi Handa <handa@m17n.org>
3529 * ftfont.c (get_adstyle_property): Fix previous change
3532 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
3534 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3535 dirs from the default value of EMACSLOADPATH (bug#10208).
3537 2011-12-07 Glenn Morris <rgm@gnu.org>
3539 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3540 installation and source directories as well. (Bug#10208)
3542 2011-12-06 Chong Yidong <cyd@gnu.org>
3544 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3546 2011-12-06 Glenn Morris <rgm@gnu.org>
3548 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3549 as an error, not just -1. (Bug#10217)
3551 2011-12-05 Chong Yidong <cyd@gnu.org>
3553 * keyboard.c (process_special_events): New function.
3554 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3556 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3558 * coding.c (encode_designation_at_bol): Don't use uninitialized
3559 local variable (Bug#9318).
3561 2011-12-05 Kenichi Handa <handa@m17n.org>
3563 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3564 return Qnil (Bug#8046, Bug#10193).
3566 2011-12-05 Kenichi Handa <handa@m17n.org>
3568 * coding.c (encode_designation_at_bol): New args charbuf_end and
3569 dst. Return the number of produced bytes. Callers changed.
3570 (coding_set_source): Return how many bytes coding->source was
3572 (coding_set_destination): Return how many bytes
3573 coding->destination was relocated.
3574 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
3575 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
3577 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3579 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3580 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3583 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3585 The following changes are to fix Bug#9318.
3587 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
3588 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3589 (encode_coding_iso_2022, encode_coding_sjis)
3590 (encode_coding_big5, encode_coding_charset): Use the above macros.
3592 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
3594 * lisp.h (process_quit_flag): Fix external declaration.
3596 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3598 Don't macro-inline non-performance-critical code.
3599 * eval.c (process_quit_flag): New function.
3600 * lisp.h (QUIT): Use it.
3602 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3604 * nsfns.m (get_geometry_from_preferences): New function.
3605 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3607 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3609 * emacs.c (Qkill_emacs): Define.
3610 (syms_of_emacs): Initialize it.
3611 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3612 Qquit_flag to `kill-emacs' instead.
3613 (quit_throw_to_read_char): Add parameter `from_signal'.
3614 All callers changed. Call Fkill_emacs if requested and safe.
3615 * lisp.h (QUIT): Call Fkill_emacs if requested.
3617 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3619 * widget.c (update_wm_hints): Return if wmshell is null.
3620 (widget_update_wm_size_hints): New function.
3622 * widget.h (widget_update_wm_size_hints): Declare.
3624 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3625 widget_update_wm_size_hints (Bug#10104).
3627 2011-12-03 Eli Zaretskii <eliz@gnu.org>
3629 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3630 before a newline, prepare the bidi iterator for consuming the
3631 newline, and keep the current paragraph direction. (Bug#10183)
3632 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
3634 2011-12-02 Juri Linkov <juri@jurta.org>
3636 * search.c (Fword_search_regexp): New Lisp function created from
3637 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3638 (Fword_search_backward, Fword_search_forward)
3639 (Fword_search_backward_lax, Fword_search_forward_lax):
3640 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3641 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3643 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3645 * fileio.c (Finsert_file_contents): Move after-change-function call
3646 to before the "handled:" label, since all "goto handled" appear in
3647 cases where the *-change-functions have already been properly called
3650 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3652 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3653 waiting for input. (Bug#10169)
3655 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3657 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3658 verifies glyph row's hash code--we have just reallocated the
3659 glyphs, so their contents can be complete garbage. (Bug#10164)
3661 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
3663 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3665 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3667 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3668 attributes are tested _before_ calling verify_row_hash, to protect
3669 against GCC re-ordering of the tests. (Bug#10164)
3671 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3673 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3675 * xterm.c (handle_one_xevent): Only set async_visible and friends
3676 if net_wm_state_hidden_seen is non-zero (Bug#10002)
3677 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
3678 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3680 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3682 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3683 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3684 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3685 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3686 All uses changed to use GCPRO1 etc.
3687 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3688 Revert to old implementation (i.e., before 2011-03-11).
3690 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3692 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3693 of scroll runs so as to avoid assigning disabled bogus rows and
3694 unnecessary graphics copy operations.
3696 2011-11-27 Eli Zaretskii <eliz@gnu.org>
3698 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3699 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3700 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3701 (malloc, free, realloc, calloc): Redirect to e_* only when
3704 * lisp.h (GCTYPEBITS): Move before first use.
3705 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3706 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3707 this macro definition.
3709 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3712 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3714 * gtkutil.c (xg_create_frame_widgets):
3715 Call gtk_window_set_has_resize_grip (FALSE) if that function is
3716 present with Gtk+ 2.0.
3718 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3720 * fileio.c (Finsert_file_contents): Undo previous change; see
3721 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3723 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3725 Rename locals to avoid shadowing.
3726 * fileio.c (Finsert_file_contents):
3727 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3728 * process.c (wait_reading_process_output):
3729 Rename inner 'proc' to 'p' to avoid shadowing.
3730 Indent for consistency with usual Emacs style.
3732 2011-11-25 Eli Zaretskii <eliz@gnu.org>
3734 * xdisp.c (redisplay_window): If cursor row is not fully visible
3735 after recentering, and scroll-conservatively is set to a large
3736 number, scroll window by a few more lines to make the cursor fully
3737 visible and out of scroll-margin. (Bug#10105)
3738 (start_display): Don't move to the next line if the display should
3739 start at a newline that is part of a display vector or an overlay
3742 2011-11-24 Juri Linkov <juri@jurta.org>
3744 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3745 after the `MagickPingImage' call. (Bug#10112)
3747 2011-11-23 Chong Yidong <cyd@gnu.org>
3749 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3751 2011-11-23 Martin Rudalics <rudalics@gmx.at>
3753 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3754 making another buffer current. (Bug#10114)
3756 2011-11-23 Glenn Morris <rgm@gnu.org>
3758 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3760 2011-11-23 Chong Yidong <cyd@gnu.org>
3762 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3763 using it (Bug#5984).
3765 2011-11-22 Eli Zaretskii <eliz@gnu.org>
3767 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3768 and header-lines, as they don't have one computed for them.
3771 * .gdbinit (prow): Make displayed values more self-explaining.
3772 Add row's hash code.
3774 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3776 * process.c (wait_reading_process_output): Fix asynchrounous
3777 GnuTLS socket handling on some versions of the GnuTLS library.
3778 (wait_reading_process_output): Add comment and URL.
3780 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3782 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3784 2011-11-21 Chong Yidong <cyd@gnu.org>
3786 * window.c (Fnext_window, Fprevious_window): Doc fix.
3788 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3790 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3792 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3794 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3796 2011-11-20 Martin Rudalics <rudalics@gmx.at>
3798 * window.c (Fset_window_combination_limit): Rename argument
3800 (Vwindow_combination_limit): Remove "status" from doc-string.
3802 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3804 * m/ibms390.h: Remove.
3805 * m/ibms390x.h: Don't include "ibms390.h".
3807 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3809 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3810 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3812 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3814 * casetab.c (Fset_case_table):
3815 * charset.c (Fcharset_after): Fix typos.
3817 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
3819 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3820 Otherwise, valgrind does not work on some platforms.
3821 Problem reported by Andreas Schwab in
3822 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3823 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3824 is set, removing the need for VIRT_ADDRESS_VARIES.
3825 (PURE_P): Use a more-efficient implementation that needs just one
3826 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3827 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3828 to 4 (xorl, subq, cmpq, setbe).
3829 * alloc.c (pure): Always extern now, since that's the
3830 VIRT_ADDR_VARIES behavior.
3831 (PURE_POINTER_P): Use a single comparison, not two, for
3832 consistency with the new puresize.h.
3833 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3834 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3835 Remove VIRT_ADDR_VARIES no longer needed.
3837 2011-11-19 Eli Zaretskii <eliz@gnu.org>
3839 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3840 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3841 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3842 behave as if the cursor position were at the window margin.
3844 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3845 and the cursor position is out of bounds, behave as if the cursor
3846 position were at the window margin. (Bug#10075)
3848 2011-11-18 Chong Yidong <cyd@gnu.org>
3850 * window.c (Fwindow_combination_limit): Make first argument
3851 non-optional, since it is meaningless for live windows like the
3854 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3856 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3858 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3860 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3861 (graft_intervals_into_buffer): Simplify.
3863 2011-11-18 Eli Zaretskii <eliz@gnu.org>
3865 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3866 hash values of the two rows.
3867 (copy_row_except_pointers): Preserve the used[] arrays and the
3868 hash values of the two rows. (Bug#10035)
3869 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
3871 * xdisp.c (row_hash): New function, body extracted from
3872 compute_line_metrics.
3873 (compute_line_metrics): Call row_hash, instead of computing the
3876 * dispnew.c (verify_row_hash): Call row_hash for computing the
3877 hash code of a row, instead of duplicating code from xdisp.c.
3879 * dispextern.h (row_hash): Add prototype.
3881 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3883 * frame.c (delete_frame): Don't delete the terminal when the last
3884 X frame is closed if emacs is built with GTK toolkit.
3886 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
3888 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3890 2011-11-17 Martin Rudalics <rudalics@gmx.at>
3892 * window.c (Vwindow_splits): Rename to
3893 Vwindow_combination_resize. Suggested by Juri Linkov.
3894 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3897 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
3899 * nsfns.m (Fns_font_name):
3900 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
3902 2011-11-16 Martin Rudalics <rudalics@gmx.at>
3904 * window.h (window): Rename slot "nest" to "combination_limit".
3905 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3906 (Fset_window_nest): Rename to Fset_window_combination_limit.
3907 (Vwindow_nest): Rename to Vwindow_combination_limit.
3908 (recombine_windows, make_parent_window, make_window)
3909 (Fsplit_window_internal, saved_window)
3910 (Fset_window_configuration, save_window_save): Rename all
3911 occurrences of window_nest to window_combination_limit.
3913 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
3915 * image.c (imagemagick_load_image): Fix typo.
3917 2011-11-14 Eli Zaretskii <eliz@gnu.org>
3919 * xdisp.c (display_line): Move the call to
3920 highlight_trailing_whitespace before the call to
3921 compute_line_metrics, since the latter needs to see the final
3922 faces of all the glyphs to compute ROW's hash value.
3923 Fixes assertion violations in row_equal_p. (Bug#10035)
3925 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
3927 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3928 just return (bug#10044).
3930 2011-11-12 Eli Zaretskii <eliz@gnu.org>
3932 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3933 with user-defined heap size. Bump the default size of the temacs
3934 heap to 27MB, to avoid memory warning when running temacs.
3935 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3937 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3938 current_matrix and desired_matrix. (Bug#9990)
3939 (verify_row_hash) [XASSERTS]: New function.
3940 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3941 that the hash value of glyph rows is correct.
3943 2011-11-12 Martin Rudalics <rudalics@gmx.at>
3945 * window.h (window): Remove splits slot.
3946 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3947 (Fdelete_other_windows_internal, make_parent_window)
3948 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3949 (Fset_window_configuration, save_window_save): Don't deal with
3950 split status of windows.
3951 (saved_window): Remove splits slot.
3952 (Vwindow_splits): Rewrite doc-string.
3954 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3956 * xfns.c (unwind_create_frame):
3957 * nsfns.m (unwind_create_frame):
3958 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3959 Vframe_list (Bug#9999).
3961 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3963 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
3965 2011-11-11 Kenichi Handa <handa@m17n.org>
3967 * callproc.c (Fcall_process): Set the member dst_multibyte of
3970 2011-11-11 Johan Bockgård <bojohan@gnu.org>
3972 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3973 avoid a crash (bug#9496).
3975 2011-11-09 Chong Yidong <cyd@gnu.org>
3977 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3978 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3980 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3982 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3984 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3986 Avoid some portability problems by eschewing 'extern inline' functions.
3987 The trivial performance wins aren't worth the portability hassles; see
3988 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3990 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3991 (window_box_width, window_box_left, window_box_left_offset)
3992 (window_box_right, window_box_right_offset): Undo previous change,
3993 by removing the "extern"s.
3994 * intervals.c (adjust_intervals_for_insertion)
3995 (adjust_intervals_for_deletion): Undo previous change,
3996 making these static again.
3997 (offset_intervals, temp_set_point_both, temp_set_point)
3998 (copy_intervals_to_string): No longer inline.
3999 * xdisp.c (window_text_bottom_y, window_box_width)
4000 (window_box_height, window_box_left_offset)
4001 (window_box_right_offset, window_box_left, window_box_right)
4002 (window_box): No longer inline.
4004 2011-11-08 Chong Yidong <cyd@gnu.org>
4006 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
4007 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4008 Signal an error if not a live window.
4009 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4010 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4012 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
4014 * lisp.h (syms_of_abbrev): Remove declaration.
4015 Reported by CHENG Gao <chenggao@royau.me>.
4017 2011-11-07 Eli Zaretskii <eliz@gnu.org>
4019 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4020 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4021 of temacs in GUI mode.
4023 2011-11-07 Martin Rudalics <rudalics@gmx.at>
4025 * window.h: Declare delete_all_child_windows instead of
4026 delete_all_subwindows.
4027 * window.c (Fwindow_nest, Fset_window_nest)
4028 (Fset_window_new_total, Fset_window_new_normal)
4029 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4030 (delete_all_subwindows): Rename to delete_all_child_windows.
4031 (Fdelete_other_windows_internal, Fset_window_configuration):
4032 Call delete_all_child_windows instead of delete_all_subwindows.
4033 * frame.c (delete_frame): Call delete_all_child_windows instead
4034 of delete_all_subwindows.
4036 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4038 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4039 This is also needed for porting to any host where GC_MARK_STACK is
4040 not GC_MAKE_GCPROS_NOOPS.
4041 (which_symbols): Use it.
4043 2011-11-07 Kenichi Handa <handa@m17n.org>
4045 * coding.c (coding_set_destination): Check coding->src_pos only
4046 when coding->src_object is a buffer (bug#9910).
4048 * process.c (send_process): Set the member src_multibyte of coding
4049 to 0 (bug#9911) when sending a unibyte text.
4051 * callproc.c (Fcall_process): Set the member src_multibyte of
4052 process_coding to 0 (bug#9912).
4054 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4056 * xmenu.c (cleanup_widget_value_tree): New function.
4057 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4058 calling free_menubar_widget_value_tree directly (Bug#9830).
4060 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4062 Fix some portability problems with 'inline'.
4063 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4064 (window_box_width, window_box_left, window_box_left_offset)
4065 (window_box_right, window_box_right_offset): Declare extern.
4066 Otherwise, these inline functions do not conform to C99 and
4067 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4068 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4069 * intervals.c (adjust_intervals_for_insertion)
4070 (adjust_intervals_for_deletion): Now extern, because otherwise the
4071 extern inline functions 'offset_intervals' couldn't refer to it.
4072 (static_offset_intervals): Remove.
4073 (offset_intervals): Rewrite using the old contents of
4074 static_offset_intervals. The old version didn't conform to C99
4075 because an extern inline function contained a reference to an
4076 identifier with static linkage.
4078 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4080 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4083 2011-11-06 Eli Zaretskii <eliz@gnu.org>
4085 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4086 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4087 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4088 return Qleft_to_right.
4090 2011-11-06 Chong Yidong <cyd@gnu.org>
4092 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4093 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4094 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4095 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4096 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4097 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4098 (Fwindow_vscroll): Doc fix.
4099 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4100 argument, since it makes no sense to pass a live window and for
4101 consistency with window-child.
4103 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4105 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4108 2011-11-05 Jason Rumney <jasonr@gnu.org>
4110 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4111 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4113 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4114 bitwise arithmetic preventing use of unicode-sip and non-truetype
4117 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4119 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4122 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4123 initialization code to keep similarity to xfns.c after changes
4126 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4128 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4129 (unwind_create_frame): New function (Bug#9943).
4130 (Fx_create_frame): Restructure code to be more similar to the one in
4131 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4132 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4133 Move terminal->reference_count++ just before making the frame official
4136 * nsterm.m (x_free_frame_resources): New function.
4137 (x_destroy_window): Move code to x_free_frame_resources.
4139 * xfns.c (unwind_create_frame): Fix comment.
4140 (Fx_create_frame, x_create_tip_frame):
4141 Move terminal->reference_count++ just before making the frame
4142 official. Move initialization of image_cache_refcount and
4143 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4145 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4147 Support MSVC build with newer versions of Visual Studio.
4148 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4149 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4152 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4153 which are not supported by MSVC.
4154 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4155 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4157 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4159 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4161 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4163 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
4165 Support MSVC build with newer versions of Visual Studio.
4166 * w32.c: Don't include w32api.h for MSVC.
4167 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4169 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4170 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4171 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4172 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4174 (alloca) [_MSC_VER]: Define to _alloca.
4176 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4178 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4180 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4182 * xdisp.c (note_mouse_highlight): If either of
4183 previous/next-single-property-change returns nil, treat that as
4184 the beginning or the end of the buffer. (Bug#9955)
4186 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4188 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
4189 label is not null (Bug#9951).
4190 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4193 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4195 * window.c (Fwindow_body_size): Mention in the doc string that the
4196 return value is in frame's canonical units. (Bug#9949)
4198 2011-11-03 Eli Zaretskii <eliz@gnu.org>
4200 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4202 * w32fns.c (unwind_create_frame): If needed, free the glyph
4203 matrices of the partially constructed frame. (Bug#9943)
4204 * xfns.c (unwind_create_frame): Likewise.
4206 2011-11-01 Eli Zaretskii <eliz@gnu.org>
4208 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4209 Don't stop backward scan on the continuation glyph, even though
4210 its CHARPOS is positive.
4211 (mouse_face_from_buffer_pos, note_mouse_highlight):
4212 Rename cover_string to disp_string.
4214 2011-11-01 Martin Rudalics <rudalics@gmx.at>
4216 * window.c (temp_output_buffer_show): Don't use
4217 Vtemp_buffer_show_specifiers.
4218 (Vtemp_buffer_show_specifiers): Remove unused variable.
4220 2011-10-30 Eli Zaretskii <eliz@gnu.org>
4222 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4223 past the beginning of the current glyph matrix.
4225 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
4227 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4228 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4229 HAVE_GTK3 (Bug#9869).
4231 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4232 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4234 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4236 * xterm.c: Declare x_handle_net_wm_state to return int.
4237 (handle_one_xevent): Check if we are iconified but don't have
4238 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4239 (get_current_wm_state): Return non-zero if not hidden,
4240 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4241 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4242 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4243 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4245 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4247 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4248 so that this new function doesn't get optimized away by a
4249 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4251 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4253 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4255 2011-10-29 Eli Zaretskii <eliz@gnu.org>
4257 Fix the `xbytecode' command.
4258 * .gdbinit (xprintbytestr): New command.
4259 (xwhichsymbols): Rename from `which'; all callers changed.
4260 (xbytecode): Print the byte-code string as well.
4262 2011-10-29 Kim Storm <storm@cua.dk>
4264 * alloc.c (which_symbols): New function.
4266 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4268 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4271 2011-10-29 Glenn Morris <rgm@gnu.org>
4273 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4274 Not clear what it was for, and it causes various bugs. (Bug#9839)
4276 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4278 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4279 possible random value that matches one of those tested as
4280 condition to clear the mouse face.
4282 2011-10-28 Chong Yidong <cyd@gnu.org>
4284 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4286 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4288 * window.c (make_window): Initialize phys_cursor_on_p.
4290 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4292 * lisp.h (struct Lisp_Symbol): Update comments.
4294 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
4296 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4298 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4300 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4301 <oslsachem@gmail.com> for helping to debug this.
4303 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4304 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4305 (g_b_init_get_glyph_outline_w): New static variables.
4306 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4307 (GetGlyphOutlineW_Proc): New typedefs.
4308 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
4309 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4311 (w32font_open_internal, compute_metrics):
4312 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
4313 instead of calling the "wide" APIs directly.
4315 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4317 * w32.h (syms_of_w32font): Add prototype.
4319 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
4321 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4322 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4323 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4324 (Fmove_to_window_line): Doc fix.
4326 2011-10-27 Chong Yidong <cyd@gnu.org>
4328 * process.c (make_process): Set gnutls_state to NULL.
4330 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4331 non-NULL, regardless of GNUTLS_INITSTAGE.
4332 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4333 an error. Set process slots as soon as we allocate them.
4335 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4337 2011-10-27 Chong Yidong <cyd@gnu.org>
4339 * gnutls.c (emacs_gnutls_deinit): New function.
4340 Deallocate credentials structures as well as calling gnutls_deinit.
4341 (Fgnutls_deinit, Fgnutls_boot): Use it.
4343 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4344 (deactivate_process): Call emacs_gnutls_deinit.
4346 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
4348 * image.c (x_create_x_image_and_pixmap):
4349 * w32.c (sys_rename, w32_delayed_load):
4350 * w32font.c (fill_in_logfont):
4351 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4353 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
4355 * w32fns.c (w32_default_color_map): New function,
4356 extracted from Fw32_default_color_map.
4357 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
4359 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4361 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4363 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4365 * keyboard.c (test_undefined): New function (bug#9751).
4366 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4368 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4370 * sysdep.c (init_sys_modes): Fix the check for the controlling
4371 terminal (Bug#6649).
4373 2011-10-20 Eli Zaretskii <eliz@gnu.org>
4375 * dispextern.h (struct bidi_it): New member next_en_type.
4377 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4378 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4379 current character, check also for next_en_type being WEAK_EN.
4380 (bidi_resolve_weak): Don't enter the expensive loop if the current
4381 position is before next_en_pos. Record the bidi type of the first
4382 non-ET, non-BN character we find, in addition to its position.
4383 (bidi_level_of_next_char): Invalidate next_en_type when
4384 next_en_pos is over-stepped.
4386 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4388 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4389 * editfns.c: Rewrite current-time-zone so that it invokes
4390 the equivalent of (format-time-string "%Z") to get the time zone name.
4391 This fixes a bug when the time zone name contains characters that
4392 need converting from the system time locale to Emacs internal format.
4393 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4394 that patch fixed format-time-string to do the conversion, but
4395 I forgot to fix current-time-zone.
4396 (format_time_string): New function, containing most of
4397 what Fformat_time_string used to contain.
4398 (Fformat_time_string): Rewrite in terms of format_time_string.
4399 This doesn't change this function's behavior.
4400 (current-time-zone): Rewrite to use format_time_string.
4401 This fixes the bug reported by Michael Schierl in
4402 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4403 Jason Rumney's 2007-06-07 change worked around this bug, but
4405 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4407 2011-10-19 Eli Zaretskii <eliz@gnu.org>
4409 * xdisp.c (start_display): If the character at POS is displayed
4410 via a display vector, reset IT->current.dpvec_index to zero.
4411 (try_window_reusing_current_matrix): If a line ends in a display
4412 vector or the next line starts in a display vector, continue
4413 redrawing the window even though the character position of
4414 start_row was reached.
4417 2011-10-18 Chong Yidong <cyd@gnu.org>
4419 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4420 with nobreak-char-display too.
4422 2011-10-18 Eli Zaretskii <eliz@gnu.org>
4424 Fix part 3 of bug#9771.
4425 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4426 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4427 non-neutral characters if the current character is a paragraph
4428 separator (a.k.a. Newline). This avoids running the same
4429 expensive loop twice, once when we consume the preceding newline
4430 and the other time when the line actually needs to be displayed.
4431 Avoid the loop when we see neutrals on the base embedding level
4432 following a character whose directionality is the same as the
4433 paragraph's. This avoids running the expensive loop when a line
4434 ends in a long sequence of neutrals, like control characters.
4435 Add assertion against STRONG_AL type. Slightly rearrange code
4436 that determines the type of a neutral given the first non-neutral
4438 (bidi_level_of_next_char): Set next_en_pos to zero when
4439 invalidating its info.
4441 2011-10-17 Eli Zaretskii <eliz@gnu.org>
4443 * xdisp.c (push_display_prop): Determine whether to record string
4444 or buffer position by IT->string, not by IT->method. Allow
4445 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
4446 (move_it_vertically_backward): Don't look for character position
4447 immediately after the newline when in a continuation line.
4450 2011-10-15 Martin Rudalics <rudalics@gmx.at>
4452 * window.c (coordinates_in_window): Rewrite and delabelize
4453 vertical border check. (Bug#5357) (Bug#9618)
4455 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4457 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4458 errors in XSetWindowBorder (bug#9310).
4460 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4462 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4463 avoid crash when xmalloc overrun checking is enabled.
4465 2011-10-13 Eli Zaretskii <eliz@gnu.org>
4467 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4468 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4469 cursor motion with <left> and <right> arrow keys.
4471 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4472 some callers set that themselves.
4474 2011-10-12 Eli Zaretskii <eliz@gnu.org>
4476 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4477 display string and the previous row comes from the same string and
4478 is empty. (Bug#9739) (Bug#9738)
4480 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4482 * doc.c (get_doc_string): Encode file name (bug#9735).
4484 2011-10-12 Eli Zaretskii <eliz@gnu.org>
4486 * bidi.c (bidi_level_of_next_char):
4487 * xdisp.c (get_visually_first_element): Remove old incorrect
4488 comments regarding the Unicode Line Separator character.
4490 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4492 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4494 * alloc.c (Fgc_status): Do not access beyond zombies array
4495 boundary if nzombies > MAX_ZOMBIES.
4496 * alloc.c (dump_zombies): Add missing format specifier.
4498 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4500 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4501 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4503 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4504 Some packages use them to denote characters with modifiers.
4506 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4508 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4509 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4510 matching a pp-number. Rename parameter var to var1.
4512 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4514 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4516 2011-10-08 Glenn Morris <rgm@gnu.org>
4518 * callint.c (Fcall_interactively): Give a more explicit error for the
4519 'c' case with a non-character input. (Bug#8479)
4521 2011-10-08 Eli Zaretskii <eliz@gnu.org>
4523 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4525 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4526 lines that are hscrolled on the left.
4528 * dispnew.c (buffer_posn_from_coords): Account for a possible
4529 presence of header-line. (Bug#4426)
4531 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4533 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4534 Don't advertise functionality which we discourage or doesn't work.
4536 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4538 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4539 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4540 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4541 this makes Emacs dump core during garbage collection on rare
4542 occasions. sizeof is obviously inferior to offsetof here, so
4543 stick with offsetof.
4544 (GC_POINTER_ALIGNMENT): New macro.
4545 (mark_memory): Omit 3rd (offset) arg; caller changed.
4546 Don't assume EMACS_INT alignment is the same as pointer alignment.
4548 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4550 * keyboard.c (read_key_sequence_remapped): New var.
4551 (read_key_sequence): Compute remapping in the right buffer.
4552 (command_loop_1): Use read_key_sequence's remapping directly.
4554 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4556 * dired.c (file_name_completion): Don't expand file name.
4557 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4558 before checking file name handler.
4560 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4561 they've been requested explicitly (bug#9591).
4563 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
4565 * keymap.c (Fsingle_key_description): Use make_specified_string
4566 instead of build_string to build string from push_key_description.
4569 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4571 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4572 This fixes a Y2038 bug on 64-bit hosts.
4573 * buffer.c (reset_buffer):
4574 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4575 (Fclear_buffer_auto_save_failure):
4576 Use 0, not -1, to represent an unset failure time, since time_t
4577 might not be signed.
4579 Remove dependency on glibc malloc internals.
4580 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4581 Move back here from lisp.h, but with their new implementations.
4582 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4583 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4584 * charset.c (charset_table_init): New static var.
4585 (syms_of_charset): Use it instead of xmalloc. This removes a
4586 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4587 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4588 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4589 Move back to alloc.c.
4590 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4591 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4593 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4595 * nsterm.m (windowDidResize): Call x_set_window_size only when
4596 ns_in_resize is true. Otherwise set pixelwidth/height and
4597 call change_frame_size (Bug#9628).
4599 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4601 Port --enable-checking=all to Fedora 14 x86-64.
4602 * charset.c (syms_of_charset): Also account for glibc malloc's
4603 internal overhead when calculating the initial malloc maximum.
4605 Port --enable-checking=all to Fedora 14 x86.
4606 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4608 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4609 (overrun_check_realloc, overrun_check_free):
4610 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4611 That way, xmalloc returns a properly-aligned pointer even if
4612 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4613 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4614 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4615 into account when calculating the initial malloc maximum.
4616 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4617 Move here from alloc.c, so that charset.c can use it too.
4618 Properly align; the old code wasn't right for common 32-bit hosts
4619 when configured with --enable-checking=all.
4620 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4621 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4623 2011-09-29 Eli Zaretskii <eliz@gnu.org>
4625 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
4628 2011-09-28 Eli Zaretskii <eliz@gnu.org>
4630 * xdisp.c (compute_display_string_end): If there's no display
4631 string at CHARPOS, return -1.
4633 * bidi.c (bidi_fetch_char): When compute_display_string_end
4634 returns a negative value, treat the character as a normal
4635 character not covered by a display string. (Bug#9624)
4637 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
4639 * lread.c (Fread_from_string): Fix typo in docstring.
4641 2011-09-27 Eli Zaretskii <eliz@gnu.org>
4643 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4644 newline, reseat the iterator instead of bidi-iterating there one
4645 character at a time. (Bug#9610)
4646 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4647 TO_CHARPOS if the bidi iterator is at base embedding level.
4649 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4651 * lread.c (readevalloop): Use correct code for NBSP.
4652 (read1): Likewise. (Bug#9608)
4654 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
4656 * dbusbind.c (Fdbus_register_signal): When service is not
4657 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4659 2011-09-25 Glenn Morris <rgm@gnu.org>
4661 * buffer.c (truncate-lines): Doc fix.
4663 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
4665 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4666 (Fset_window_next_buffers): Doc fix.
4668 2011-09-24 Glenn Morris <rgm@gnu.org>
4670 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4672 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4674 Fix minor problems found by static checking.
4675 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
4676 * indent.c (Fvertical_motion): Fix == vs = typo.
4678 2011-09-24 Eli Zaretskii <eliz@gnu.org>
4680 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4681 Default value is now t. Doc fix.
4683 * indent.c (Fvertical_motion): Compute and apply the overshoot
4684 logic when moving up, not only when moving down. Fix the
4685 confusing name and values of the it_overshoot_expected variable;
4686 logic changes accordingly. (Bug#9254) (Bug#9549)
4688 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4689 CHARPOS is covered by a display string which includes newlines.
4690 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4691 is covered by a display string with embedded newlines.
4693 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
4695 * dbusbind.c (Fdbus_register_signal): Add match rule to
4696 Vdbus_registered_objects_table. (Bug#9581)
4697 (Fdbus_register_method, Vdbus_registered_objects_table):
4700 2011-09-24 Jim Meyering <meyering@redhat.com>
4702 do not ignore write error for any output size
4703 The previous change was incomplete.
4704 While it makes emacs --batch detect the vast majority of stdout
4705 write failures, errors were still ignored whenever the output size is
4706 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4707 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4708 && echo FAIL: ignored write error
4709 FAIL: ignored write error
4710 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4711 && echo FAIL: ignored write error
4712 FAIL: ignored write error
4713 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4715 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4717 * emacs.c (Fkill_emacs): In noninteractive mode exit
4718 non-successfully if a write error occurred on stdout. (Bug#9574)
4720 2011-09-21 Eli Zaretskii <eliz@gnu.org>
4722 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4725 * dispextern.h (struct it): Update the comment documenting what
4728 2011-09-20 Eli Zaretskii <eliz@gnu.org>
4730 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4731 a display string, extend search for cursor position to end of row.
4732 (find_row_edges): If the row ends in a newline from a display
4733 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4734 Handle the case of a display string with multiple newlines.
4735 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4736 non-empty line. Fixes confusing cursor motion with arrow keys at
4737 the beginning of a line that starts with whitespace.
4739 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4741 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4744 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
4746 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4749 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4751 * xdisp.c (display_line): Record maximum and minimum buffer
4752 positions even if no glyphs were produced (e.g., by a zero-width
4753 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4754 buffer positions that will be removed from the glyph row because
4756 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4757 column is beyond frame width: don't subtract 1 "pixel" when
4758 computing width of the stretch.
4759 (reseat_at_next_visible_line_start): Undo the change made on
4760 2011-09-17 that saved paragraph information and restored it after
4761 the call to `reseat'. (Bug#9545)
4763 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4765 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4766 and turn window cursor on if cleared (Bug#9415).
4768 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
4770 * search.c (boyer_moore): Take unibyte characters from pattern
4771 literally. (Bug#9458)
4773 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4775 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4777 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4779 Fix minor problem found by static checking.
4780 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4781 initialized, to pacify gcc -Wuninitialized.
4783 * fileio.c: Report proper errno when syscall falls.
4784 (Finsert_file_contents): Save and restore errno,
4785 so that report_file_error outputs the correct diagnostic.
4786 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4788 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4790 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4792 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4794 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4795 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4797 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4799 * xdisp.c (reseat_at_next_visible_line_start): Keep information
4800 about the current paragraph and restore it after the call to reseat.
4802 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4803 (bidi_find_paragraph_start): Search back for paragraph beginning
4804 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4805 (bidi_move_to_visually_next): Only trigger paragraph-related
4806 computations when the last character is a newline or at EOB, not
4807 just any NEUTRAL_B. (Bug#9470)
4809 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4810 truncated lines if point is covered by a display string. (Bug#9524)
4812 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4814 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4815 (cons_to_x_long): New function.
4816 (lisp_data_to_selection_data): Use it. Correct the test for
4817 short-versus-long data; it was negated. Break out of vector
4818 loop, for efficiency, when a long datum is discovered.
4820 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4822 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4824 2011-09-16 Eli Zaretskii <eliz@gnu.org>
4826 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4827 GCC PR/17406) by declaring this function with external scope.
4829 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4831 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4832 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4834 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4836 * editfns.c (Fformat): Correctly handle text properties on "%%".
4838 2011-09-15 Eli Zaretskii <eliz@gnu.org>
4840 * xterm.c (x_draw_composite_glyph_string_foreground):
4841 * w32term.c (x_draw_composite_glyph_string_foreground):
4842 * term.c (encode_terminal_code):
4843 * composite.c (composition_update_it, get_composition_id):
4844 * xdisp.c (get_next_display_element)
4845 (fill_composite_glyph_string): Add comments about special meaning
4846 of TAB characters in a composition.
4848 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4850 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4851 This occurs when processing a multibyte format.
4852 Problem reported by Wolfgang Jenker.
4854 2011-09-15 Johan Bockgård <bojohan@gnu.org>
4856 * xdisp.c (try_cursor_movement): Only check for exact match if
4857 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4859 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4861 Remove unused external symbols.
4862 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4863 * xdisp.c (calc_pixel_width_or_height): Now static.
4864 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4865 * indent.c (check_display_width):
4866 * w32term.c: Fix comment to match code.
4867 * xterm.c, xterm.h (x_catching_errors): Remove.
4869 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4871 * xselect.c: Use signed conversions more consistently (Bug#9498).
4872 (selection_data_to_lisp_data): Assume incoming selection data are
4873 signed integers, not unsigned. This is to be consistent with
4874 outgoing selection data, which was modified to use signed integers
4875 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4876 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4877 expects long, not unsigned long.
4879 2011-09-14 Eli Zaretskii <eliz@gnu.org>
4881 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4882 computation of loop end. Reported by Johan Bockgård
4885 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
4887 * frame.c (Fother_visible_frames_p): Function deleted.
4889 2011-09-12 Eli Zaretskii <eliz@gnu.org>
4891 * indent.c (compute_motion): Process display vector front to back
4892 rather than the other way around. (Bug#2496)
4894 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4896 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4898 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
4900 * minibuf.c (Fread_from_minibuffer): Doc fix.
4902 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4904 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4905 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4907 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4909 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4910 value for non-existent files.
4912 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4914 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4915 set its "size" to -1. This will set the modtime_size field of
4916 the corresponding buffer to -1, which is what
4917 verify-visited-file-modtime expects for files that do not exist.
4920 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4922 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4924 * lisp.h: ... from here. push_key_description is no longer
4925 defined in keyboard.c, so its declaration should not be in
4926 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4927 logically belongs with push_key_description.
4929 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4931 * buffer.h: Include <sys/types.h> instead of <time.h>.
4932 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4933 Problem reported by Herbert J. Skuhra.
4935 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4937 * xml.c (parse_region): Make the parsing work for
4938 non-comment-starting XML files again (bug#9144).
4940 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4942 * image.c (gif_load): Fix calculation of bottom and right corner.
4945 2011-09-10 Eli Zaretskii <eliz@gnu.org>
4947 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4948 redisplay in small windows.
4950 2011-09-09 Eli Zaretskii <eliz@gnu.org>
4952 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4954 2011-09-08 Martin Rudalics <rudalics@gmx.at>
4956 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4957 Operate on live windows only.
4959 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
4961 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4963 2011-09-07 Eli Zaretskii <eliz@gnu.org>
4965 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4966 only under bidi iteration.
4968 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4970 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4972 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4974 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4975 Without this fix, the command to link temacs failed due to an
4976 undefined symbol __builtin_isnan. This is because
4977 /usr/include/iso/math_c99.h #defines isnan(x) to
4978 __builtin_isnan(x), but the bundled gcc, which identifies itself
4979 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4981 * floatfns.c (isnan): #undef, and then #define to a clone of
4983 (Fisnan): Always define, since it's always available now.
4984 (syms_of_floatfns): Always define isnan at the Lisp level.
4986 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4988 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4990 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4992 * fileio.c: Fix bugs with large file offsets (Bug#9428).
4993 The previous code assumed that file offsets (off_t values) fit in
4994 EMACS_INT variables, which is not true on typical 32-bit hosts.
4995 The code messed up by falsely reporting buffer overflow in cases
4996 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4997 when "big" contains more than 2**29 bytes, even though this
4998 inserts just one byte and does not overflow the buffer.
4999 (Finsert_file_contents): Store file offsets as off_t
5000 values, not as EMACS_INT values. Check for overflow when
5001 converting between EMACS_INT and off_t. When checking for
5002 buffer overflow or for overlap, take the offsets into account.
5003 Don't use EMACS_INT for small values where int suffices.
5004 When checking for overlap, fix a typo: ZV was used where
5005 ZV_BYTE was intended.
5006 (Fwrite_region): Don't assume off_t fits into 'long'.
5007 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5009 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
5011 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5013 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5015 sprintf-related integer and memory overflow issues (Bug#9412).
5017 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
5018 (esprintf, exprintf, evxprintf): New functions.
5019 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
5020 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
5021 (modify_event_symbol): Do not assume that the length of
5022 name_alist_or_stem is safe to alloca and fits in int.
5023 (Fexecute_extended_command): Likewise for function name and binding.
5024 (Frecursion_depth): Wrap around reliably on integer overflow.
5025 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5026 since some callers pass EMACS_INT values.
5027 (Fsingle_key_description): Don't crash if symbol name contains more
5028 than MAX_ALLOCA bytes.
5029 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5030 (get_minibuffer): Arg is now EMACS_INT, not int.
5031 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
5032 (esprintf, exprintf, evxprintf): New decls.
5033 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5035 * dbusbind.c (signature_cat): New function.
5036 (xd_signature, Fdbus_register_signal):
5037 Do not overrun buffer; instead, report string overflow.
5039 * dispnew.c (add_window_display_history): Don't overrun buffer.
5040 Truncate instead; this is OK since it's just a log.
5042 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5043 even if the time zone offset is outlandishly large.
5044 Don't mishandle offset == INT_MIN.
5046 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5047 when creating daemon; the previous buffer-overflow check was incorrect.
5049 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5050 which has the guts of the old verror function.
5052 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5053 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5055 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5056 (font_unparse_xlfd): Don't blindly alloca long strings.
5057 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
5058 fits in int, when using sprintf. Use single snprintf to count
5059 length of string rather than counting it via multiple sprintfs;
5060 that's simpler and more reliable.
5061 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5062 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5063 sprintf, in case result does not fit in int.
5065 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5066 (fontset_from_font): Print it.
5068 * frame.c (tty_frame_count): Now printmax_t, not int.
5069 (make_terminal_frame, set_term_frame_name): Print it.
5070 (x_report_frame_params): In X, window IDs are unsigned long,
5071 not signed long, so print them as unsigned.
5072 (validate_x_resource_name): Check for implausibly long names,
5073 and don't assume name length fits in 'int'.
5074 (x_get_resource_string): Don't blindly alloca invocation name;
5075 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5078 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5079 (xg_check_special_colors, xg_set_geometry):
5080 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5082 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5083 Use esprintf, not sprintf, in case result does not fit in int.
5085 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5086 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5087 it as a large positive number.
5088 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5089 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5091 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5092 in case result does not fit in int.
5094 * print.c (float_to_string): Detect width overflow more reliably.
5095 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5096 buffer overrun. Don't assume list length fits in 'int'. Treat
5097 print length of 0 as 0, not as infinity; to be consistent with other
5098 uses of print length in this function. Don't overflow print length
5099 index. Don't assume hash table size fits in 'long', or that
5100 vectorlike size fits in 'unsigned long'.
5102 * process.c (make_process): Use printmax_t, not int, to format
5103 process-name gensyms.
5105 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5107 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5108 to avoid potential buffer overrun.
5110 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5111 if X resource line is longer than 512 bytes.
5113 * xfns.c (x_window): Make sprintf buffer a bit bigger
5114 to avoid potential buffer overrun.
5116 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5118 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5120 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5122 Integer overflow fixes for scrolling, etc.
5123 Without these, Emacs silently mishandles large integers sometimes.
5124 For example, "C-u 4294967297 M-x recenter" was treated as if
5125 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5127 * xdisp.c (try_window_id): Check Emacs fixnum range before
5128 converting to 'int'.
5130 * window.c (window_scroll_line_based, Frecenter):
5131 Check that an Emacs fixnum is in range before assigning it to 'int'.
5132 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5133 values converted from Emacs fixnums.
5134 (Frecenter): Don't wrap around a line count if it is out of 'int'
5135 range; instead, treat it as an extreme value.
5136 (Fset_window_configuration, compare_window_configurations):
5137 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5139 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5140 that can exceed INT_MAX. Check that EMACS_INT value is in range
5141 before assigning it to the (possibly-narrower) index.
5142 (match_limit): Don't assume that a fixnum can fit in 'int'.
5144 * print.c (print_object): Use ptrdiff_t, not int, for index that can
5147 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
5148 (Fvertical_motion): Don't wrap around LINES values that don't fit
5149 in 'int'. Instead, treat them as extreme values. This is good
5150 enough for windows, which can't have more than INT_MAX lines anyway.
5152 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5154 * Require libxml/parser.h to avoid compilation warning.
5156 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5158 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5159 since this reportedly can destroy thread storage.
5161 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
5163 * syntax.c (find_defun_start): Update all cache variables if
5164 exiting early (Bug#9401).
5166 2011-08-30 Eli Zaretskii <eliz@gnu.org>
5168 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5170 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5171 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5172 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5174 * term.c (tty_append_glyph): New function.
5175 (produce_stretch_glyph): Static function and its prototype deleted.
5177 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5180 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5182 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5183 when checking :margin (Bug#9390).
5184 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
5185 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
5186 so that the name doesn't mislead. All uses changed.
5188 2011-08-28 Johan Bockgård <bojohan@gnu.org>
5190 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5193 2011-08-27 Eli Zaretskii <eliz@gnu.org>
5195 * xdisp.c (move_it_to): Don't bail out early when reaching
5196 position beyond to_charpos, if we are scanning backwards.
5197 (move_it_vertically_backward): When DY == 0, make sure we get to
5198 the first character in the line after the newline.
5200 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5202 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5203 (ccl_driver): Do not generate an out-of-range pointer.
5204 (Fccl_execute_on_string): Remove unnecessary check for
5205 integer overflow, noted by Stefan Monnier in
5206 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5207 Remove a FIXME that didn't need fixing.
5208 Simplify the newly-introduced buffer reallocation code.
5210 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
5212 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5214 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
5216 Integer and memory overflow issues (Bug#9196).
5218 * doc.c (get_doc_string): Rework so that
5219 get_doc_string_buffer_size is the actual buffer size, rather than
5220 being 1 less than the actual buffer size; this makes xpalloc more
5223 * image.c (x_allocate_bitmap_record, cache_image):
5224 * xselect.c (Fx_register_dnd_atom):
5225 Simplify previous changes by using xpalloc.
5227 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5228 since either will do and ptrdiff_t is convenient with xpalloc.
5230 * charset.c (charset_table_size)
5231 (struct charset_sort_data.priority): Now ptrdiff_t.
5232 (charset_compare): Don't overflow if priorities differ greatly.
5233 (Fsort_charsets): Don't assume list length fits in int.
5234 Check for size-calculation overflow when allocating sort data.
5235 (syms_of_charset): Allocate an initial charset table that is
5236 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5238 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5240 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5241 The actual value is always <= INT_MAX, and leaving it unsigned made
5242 overflow checking harder.
5244 * dispextern.h (struct glyph_matrix.rows_allocated)
5245 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5246 with xpalloc. The values are still always <= INT_MAX.
5248 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5250 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5251 (SAFE_NALLOCA): New macro.
5253 * region-cache.c (struct boundary.pos, find_cache_boundary)
5254 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5255 (set_cache_region, invalidate_region_cache)
5256 (revalidate_region_cache, know_region_cache, region_cache_forward)
5257 (region_cache_backward, pp_cache):
5258 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5259 so that ptrdiff_t * can be passed to xpalloc.
5260 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5261 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5262 (pp_cache): Don't assume cache_len fits in int.
5263 * region-cache.h: Adjust extern decls to match.
5265 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5266 EMACS_INT, since either will do, for xpalloc.
5268 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5269 (xnmalloc, xnrealloc, xpalloc): New functions.
5271 * bidi.c (bidi_shelve_header_size): New constant.
5272 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5273 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5275 * bidi.c (bidi_cache_shrink):
5276 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5278 Don't update size of array until after memory allocation succeeds,
5279 because xmalloc/xrealloc may not return.
5280 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5281 now that we have proper integer overflow checking.
5282 (record_overlay_string, overlay_strings): Catch overflows when
5283 calculating size of overlay_str_buf.
5285 * callproc.c (Fcall_process): Check for size overflow when
5286 calculating size of args2.
5287 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5288 Normally we prefer signed values, but sticking with ptrdiff_t would
5289 require adding more-complicated checks.
5291 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5292 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5293 Redo buffer-overflow calculations to avoid integer overflow.
5294 Add a FIXME comment where memory seems to be over-allocated.
5296 * character.c (Fstring): Check for size-calculation overflow.
5298 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5299 unnecessary integer overflow. Check for size overflow.
5300 (encode_coding_object): Don't update size until xmalloc succeeds.
5302 * composite.c (get_composition_id): Check for overflow in glyph
5303 length calculations.
5305 Integer and memory overflow fixes for display code.
5306 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5307 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5308 (scrolling_window): Check for overflow in size calculations.
5309 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5310 Don't assume glyph table len fits in int.
5311 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5312 (row_table_size): Now ptrdiff_t, not int.
5313 (scrolling_window): Avoid overflow in size calculations.
5314 Don't update size until allocation succeeds.
5315 * fns.c (concat): Check for overflow in size calculations.
5316 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5317 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5318 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5320 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5321 (get_doc_string): Check for size calculation overflow.
5322 Don't update size until allocation succeeds.
5323 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5324 EMACS_INT, where ptrdiff_t will do.
5325 (Fsubstitute_command_keys): Check for string overflow.
5327 * editfns.c (set_time_zone_rule): Don't assume environment length
5329 (message_length): Now ptrdiff_t, not int.
5330 (Fmessage_box): Don't update size until allocation succeeds.
5331 Don't assume message length fits in int.
5332 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5334 * emacs.c (main): Do not reallocate argv, since there is a null at
5335 the end that can be overwritten, and this way there's no need to
5336 worry about size-calculation overflow.
5337 (sort_args): Check for size-calculation overflow.
5339 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5341 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5343 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5344 (x_set_scroll_bar_width, x_figure_window_size):
5345 Check for integer overflow.
5346 (x_set_alpha): Do not assume XINT fits in int.
5348 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5349 This is for the members text_lines, text_cols, total_lines, total_cols,
5350 where the system imposes an 'int' limit.
5352 * fringe.c (Fdefine_fringe_bitmap):
5353 Don't update size until alloc works.
5355 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5356 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5358 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5359 Check for size-calculation overflow.
5360 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5361 do, as we prefer signed integers.
5362 (id_to_widget.max_size, id_to_widget.used)
5363 (xg_store_widget_in_map, xg_remove_widget_from_map)
5364 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5365 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5366 Use and return ptrdiff_t, not int.
5367 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5368 * gtkutil.h: Change prototypes to match the above.
5370 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5371 are duplicate now that they've been promoted to lisp.h.
5372 (x_allocate_bitmap_record, x_alloc_image_color)
5373 (make_image_cache, cache_image, xpm_load):
5374 Don't update size until alloc is done.
5375 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5377 Check for size calculation overflow.
5378 (ct_colors_allocated_max): New constant.
5379 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5382 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5383 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5384 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5385 Use ptrdiff_t, not int, to count maps.
5386 (read_char_minibuf_menu_prompt): Check for overflow in size
5387 calculations. Don't update size until allocation succeeds.
5388 Redo calculations to avoid overflow.
5389 * keyboard.h: Change prototypes to match the above.
5391 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5393 (current_minor_maps): Check for size calculation overflow.
5394 * keymap.h: Change prototypes to match the above.
5396 * lread.c (read1, init_obarray): Don't update size until alloc done.
5398 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5399 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5401 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5402 Now ptrdiff_t, not int.
5403 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5404 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5406 * process.c (Fnetwork_interface_list): Check for overflow
5407 in size calculation.
5409 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5411 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5412 overflow. Don't bother calling xmalloc when xrealloc will do.
5414 * search.c (Freplace_match): Check for size calculation overflow.
5415 (Fset_match_data): Don't assume list lengths fit in 'int'.
5417 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5418 for command line length. Do not attempt to address one before the
5419 beginning of an array, as that's not portable.
5421 * term.c (max_frame_lines): Remove; unused.
5422 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5424 (encode_terminal_code, calculate_costs): Check for size
5425 calculation overflow.
5426 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5427 table lengths and related sizes. Don't update size until alloc
5428 done. Redo calculations to avoid overflow.
5429 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5431 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5432 subtracting pointers.
5433 (gobble_line): Check for overflow more carefully. Don't update size
5436 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5437 Don't update size until alloc done.
5438 Redo size calculations to avoid overflow.
5439 Check for size calculation overflow.
5440 (main) [DEBUG]: Fix typo in invoking tparam1.
5442 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5443 Use ptrdiff_t, not int, for sizes.
5444 (store_mode_line_noprop_char): Don't update size until alloc done.
5446 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5447 Use ptrdiff_t, not int, for sizes.
5448 (Finternal_make_lisp_face, cache_face):
5449 Check for size calculation overflow.
5450 (cache_face): Treat size calculation overflows as if they were
5451 memory exhaustion (the usual treatment), rather than aborting.
5453 * xfns.c (x_encode_text, x_set_name_internal)
5454 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5455 sizes, since they can exceed INT_MAX in size. Check for size
5456 calculation overflow.
5458 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5459 (xg_select): Check for size calculation overflow.
5460 Don't update size until alloc done.
5462 * xrdb.c (get_environ_db): Don't assume path length fits in int,
5463 as sprintf is limited to int lengths.
5465 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5466 (X_LONG_MIN): New macros.
5467 Use them to make the following changes clearer.
5468 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5469 This change doesn't affect the value now, but it may help remind
5470 future maintainers not to raise the value too much later.
5471 (SELECTION_QUANTUM): Remove, replacing with ...
5472 (selection_quantum): ... new function, which avoids overflow.
5474 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5475 assumption that selection length fits in 'int'.
5476 (x_reply_selection_request, x_handle_selection_request)
5477 (x_get_window_property, receive_incremental_selection)
5478 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5479 (lisp_data_to_selection_data, clean_local_selection_data):
5480 Use ptrdiff_t, not int, to record length of selection.
5481 (x_reply_selection_request, x_get_window_property)
5482 (receive_incremental_selection, x_property_data_to_lisp):
5483 Redo calculations to avoid overflow.
5484 (x_reply_selection_request): When sending hint, ceiling it at
5485 X_LONG_MAX rather than relying on wraparound overflow to send
5487 (x_get_window_property, receive_incremental_selection)
5488 (lisp_data_to_selection_data, x_property_data_to_lisp):
5489 Check for size-calculation overflow.
5490 (x_get_window_property, receive_incremental_selection)
5491 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5492 Don't store size until memory allocation succeeds.
5493 (x_get_window_property): Plug memory leak on memory exhaustion.
5494 Don't double-block input; malloc is safe here. Don't assume 2**34
5495 - 4 fits in unsigned long. Add an xassert to check
5496 XGetWindowProperty overflow. Be more careful about overflow
5497 calculations, and distinguish size from memory overflow better.
5498 (receive_incremental_selection): When tracing, don't assume
5499 unsigned int is less than INT_MAX.
5500 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5501 harmful) conversions of unsigned short to int.
5502 (lisp_data_to_selection_data): Don't assume that integers
5503 in the range -65535 through -1 fit in an X unsigned short.
5504 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5505 result parameters unless successful. Rely on cons_to_unsigned
5506 to report problems with elements; the old code wasn't right anyway.
5507 (x_check_property_data): Check for int overflow; we cannot use
5508 a wider type due to X limits.
5509 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5511 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
5513 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5514 (x_term_init): Check for size calculation overflow.
5515 (x_color_cells): Don't store size until memory allocation succeeds.
5516 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
5517 Don't assume alloca size is less than MAX_ALLOCA.
5518 (x_term_init): Don't assume length fits in int (sprintf is limited
5521 Use ptrdiff_t for composition IDs.
5522 * character.c (lisp_string_width):
5523 * composite.c (composition_table_size, n_compositions)
5524 (get_composition_id, composition_gstring_from_id):
5525 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5526 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5527 * window.c (Frecenter):
5528 Use ptrdiff_t, not int, for composition IDs.
5529 * composite.c (get_composition_id): Check for integer overflow.
5530 * composite.h: Adjust prototypes to match the above changes.
5532 Use ptrdiff_t for hash table indexes.
5533 * category.c (hash_get_category_set):
5534 * ccl.c (ccl_driver):
5535 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5536 * coding.c (coding_system_charset_list, detect_coding_system):
5537 * coding.h (struct coding_system.id):
5538 * composite.c (get_composition_id, gstring_lookup_cache):
5539 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5540 * image.c (xpm_get_color_table_h):
5541 * lisp.h (hash_lookup, hash_put):
5542 * minibuf.c (Ftest_completion):
5543 Use ptrdiff_t for hash table indexes, not int (which is too
5544 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5545 32-bit --with-wide-int hosts).
5547 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5548 Add a FIXME comment about memory leaks.
5549 (syms_of_charset): Don't assume xmalloc returns.
5551 Don't assume that stated character widths fit in int.
5552 * character.c (Fchar_width, c_string_width, lisp_string_width):
5553 * character.h (CHAR_WIDTH):
5554 * indent.c (MULTIBYTE_BYTES_WIDTH):
5555 Use sanitize_char_width to avoid undefined and/or bad behavior
5556 with outlandish widths.
5557 * character.h (sanitize_tab_width): Rename from sanitize_width,
5558 now that we have two such functions. All uses changed.
5559 (sanitize_char_width): New inline function.
5561 Don't assume that tab-width fits in int.
5562 * character.h (sanitize_width): New inline function.
5563 (SANE_TAB_WIDTH): New macro.
5564 (ASCII_CHAR_WIDTH): Use it.
5565 * indent.c (sane_tab_width): Remove. All uses replaced by
5566 SANE_TAB_WIDTH (current_buffer).
5567 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5569 * fileio.c: Integer overflow issues with file modes.
5570 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5572 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5573 Remove unreachable code.
5574 (read_hex, load_charset_map_from_file): Check for integer overflow.
5576 * xterm.c: Don't go over XClientMessageEvent limit.
5577 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5578 (x_send_scroll_bar_event): Likewise. Check that the size does not
5579 exceed limits imposed by XClientMessageEvent, as well as the usual
5580 ptrdiff_t and size_t limits.
5582 * keyboard.c: Overflow, signedness and related fixes.
5583 (make_lispy_movement): Use same integer type in forward decl
5584 that is used in the definition.
5585 (read_key_sequence, keyremap_step):
5586 Change bufsize argument back to int, undoing my 2011-03-30 change.
5587 We prefer signed types, and int is wide enough here.
5588 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5589 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5590 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5591 length, not size_t. Use ptrdiff_t for index, not int.
5592 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5593 possibility of integer overflow.
5595 Overflow, signedness and related fixes for images.
5597 * dispextern.h (struct it.stack[0].u.image.image_id)
5598 (struct_it.image_id, struct image.id, struct image_cache.size)
5599 (struct image_cache.used, struct image_cache.ref_count):
5600 * gtkutil.c (update_frame_tool_bar):
5601 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5602 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5603 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5604 * nsmenu.m (update_frame_tool_bar):
5605 * xdisp.c (calc_pixel_width_or_height):
5606 * xfns.c (image_cache_refcount):
5607 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5608 on typical 64-bit hosts.
5610 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5611 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5612 Omit unnecessary casts to int.
5613 (parse_image_spec): Check that integers fall into 'int' range
5614 when the callers expect that.
5615 (image_ascent): Redo ascent calculation to avoid int overflow.
5616 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5617 (lookup_image): Remove unnecessary tests.
5618 (xbm_image_p): Locals are now of int, not EMACS_INT,
5619 since parse_image_check makes sure they fit into int.
5620 (png_load, gif_load, svg_load_image):
5621 Prefer int to unsigned where either will do.
5622 (tiff_handler): New function, combining the cores of the
5623 old tiff_error_handler and tiff_warning_handler.
5624 This function is rewritten to use vsnprintf and thereby avoid
5625 stack buffer overflows. It uses only the features of vsnprintf
5626 that are common to both POSIX and native Microsoft.
5627 (tiff_error_handler, tiff_warning_handler): Use it.
5628 (tiff_load, gif_load, imagemagick_load_image):
5629 Don't assume :index value fits in 'int'.
5630 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5631 (imagemagick_load_image): Check that crop parameters fit into
5632 the integer types that MagickCropImage accepts. Don't assume
5633 Vimagemagick_render_type has a nonnegative value. Don't assume
5634 size_t fits in 'long'.
5635 (gs_load): Use printmax_t to print the widest integers possible.
5636 Check for integer overflow when computing image height and width.
5638 2011-08-26 Eli Zaretskii <eliz@gnu.org>
5640 * xdisp.c (redisplay_window): Don't force window start if point
5641 will be invisible in the resulting window. (Bug#9324)
5643 2011-08-25 Eli Zaretskii <eliz@gnu.org>
5645 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5646 the display spec is of the form `(space ...)'.
5647 (handle_display_spec): Return the value returned by
5648 handle_single_display_spec, not just 1 or zero.
5649 (handle_single_display_spec): If the display spec is of the form
5650 `(space ...)', and specifies display in the text area, return 2
5652 (try_cursor_movement): Check for the need to scroll more
5653 accurately, and prefer exact match for point under bidi.
5654 Don't advance `row' beyond the last row of the window.
5656 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5657 into disp_prop; all users changed.
5659 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5660 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5661 for the text covered by the display property.
5663 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
5665 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5666 Change return value to nil.
5667 (Frecord_buffer): Delete unused function.
5669 2011-08-24 Eli Zaretskii <eliz@gnu.org>
5671 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5672 buffers, return left-to-right.
5673 (set_cursor_from_row): Consider candidate row a win if its glyph
5674 represents a newline and point is on that newline. Fixes cursor
5675 positioning on the newline at EOL of R2L text within L2R
5676 paragraph, and vice versa.
5677 (try_cursor_movement): Check continued rows, in addition to
5678 continuation rows. Fixes unwarranted scroll when point enters a
5679 continued line of R2L text within an L2R paragraph, or vice versa.
5680 (cursor_row_p): Consider the case of point being equal to
5681 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5682 from the end of a short line to the beginning of a continued line
5683 of R2L text within L2R paragraph.
5684 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5685 composed characters.
5687 * bidi.c (bidi_check_type): Use xassert.
5688 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5691 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5693 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5696 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
5698 * nsfont.m (ns_otf_to_script): Fix typo.
5700 2011-08-22 Kenichi Handa <handa@m17n.org>
5702 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5703 extra slot even if the purpose is char-code-property-table.
5705 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5707 * xdisp.c (redisplay_window): When computing centering_position,
5708 account for the height of the header line. (Bug#8874)
5710 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5711 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5712 candidate is selected by the mouse, and that candidate has a
5713 composed character under the mouse.
5715 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5716 coordinates reported by pos-visible-in-window-p for a composed
5717 character in column zero.
5719 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5721 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5723 2011-08-22 Eli Zaretskii <eliz@gnu.org>
5725 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5726 consider it a hit if to_charpos is anywhere in the range of the
5727 composed buffer positions.
5729 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
5731 * image.c (gif_load): Don't assume that each subimage has the same
5732 dimensions as the base image. Handle disposal method that is
5733 "undefined" by the gif spec (Bug#9335).
5735 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
5737 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
5738 (Fcondition_case): Document `debug' symbol in error handler.
5740 2011-08-19 Eli Zaretskii <eliz@gnu.org>
5742 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5743 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5744 from an Org mode buffer to a Speedbar frame.
5746 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5747 a composition, take its buffer position from IT->cmp_it.charpos.
5748 Fixes cursor positioning at the beginning of a line that begins
5749 with a composed character.
5751 2011-08-18 Eli Zaretskii <eliz@gnu.org>
5753 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5754 character bidirectional type, use STRONG_L instead. Fixes crashes
5755 in a buffer produced by `describe-categories'.
5757 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5758 members before the level stack, so they would be saved and
5759 restored when copying iterator state. Fixes incorrect reordering
5760 around TABs covered by display properties.
5762 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5764 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
5766 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
5768 * eval.c (internal_condition_case, internal_condition_case_1)
5769 (internal_condition_case_2, internal_condition_case_n):
5770 Remove unnecessary aborts (Bug#9081).
5772 2011-08-17 Eli Zaretskii <eliz@gnu.org>
5774 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5775 has no `load' handler, try opening the file locally. (Bug#9311)
5777 2011-08-16 Ken Brown <kbrown@cornell.edu>
5779 * gmalloc.c: Expand comment.
5781 2011-08-16 Eli Zaretskii <eliz@gnu.org>
5783 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5784 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5786 2011-08-16 Ken Brown <kbrown@cornell.edu>
5788 Fix memory allocation problems in Cygwin build (Bug#9273).
5790 * unexcw.c ( __malloc_initialized): Declare external variable.
5791 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5793 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5795 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5797 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5799 [CYGWIN] (special_realloc): New function.
5800 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5801 requests to realloc storage in the static heap.
5803 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5805 * bidi.c (bidi_initialize): Remove unused local.
5807 2011-08-15 Eli Zaretskii <eliz@gnu.org>
5810 * biditype.h: Remove file.
5811 * makefile.w32-in ($(BLD)/bidi.$(O)):
5812 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
5814 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5816 * chartab.c: Improve commentary for the uniprop_table API.
5818 * bidi.c (bidi_paragraph_init): Support zero value of
5819 bidi_ignore_explicit_marks_for_paragraph_level.
5820 (bidi_initialize): Use uniprop_table instead of including
5821 biditype.h and bidimirror.h.
5823 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5824 coordinates of the iterator when restoring from ppos_it.
5827 2011-08-14 Kenichi Handa <handa@m17n.org>
5829 * process.c (create_process): Call setup_process_coding_systems
5830 after the pid of the process is set to -1 (Bug#8162).
5832 2011-08-14 Eli Zaretskii <eliz@gnu.org>
5834 * xdisp.c (move_it_in_display_line_to): Don't invoke
5835 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5836 ppos_it. Fixes vertical cursor motion when line beginning is
5837 covered by an image. (Bug#9296)
5839 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5841 * nsterm.h (ns_run_ascript): Declare.
5842 (NSAPP_DATA2_RUNASSCRIPT): Define.
5844 * nsfns.m (as_script, as_result, as_status): New static variables.
5845 (ns_run_ascript): New function.
5846 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
5847 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5848 the event loop. Get status from as_status (Bug#7276).
5850 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5851 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5852 the event loop (Bug#7276).
5854 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5856 * gnutls.c (QCgnutls_bootprop_priority)
5857 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5858 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5859 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5860 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5861 (QCgnutls_bootprop_verify_hostname_error)
5862 (QCgnutls_bootprop_callbacks_verify): Rename from
5863 Qgnutls_bootprop_..., all uses changed.
5865 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5868 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5870 * xfaces.c (Qframe_set_background_mode): Now static.
5871 * dispextern.h (Qframe_set_background_mode): Remove decl.
5873 * process.c (Fnetwork_interface_info): Declare local only if needed.
5875 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5877 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5878 (Fnetwork_interface_list): Allocate in increments of bytes instead
5879 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5880 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5882 (struct ifflag_def): notrailers is smart on OSX.
5883 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5884 Get hardware address with getifaddrs if available.
5886 2011-08-12 Eli Zaretskii <eliz@gnu.org>
5888 * xdisp.c (iterate_out_of_display_property): xassert that
5889 IT->position is set to within IT->object's boundaries. Break from
5890 the loop as soon as EOB is reached; avoids infloops in redisplay
5891 when IT->position is set up wrongly due to some bug.
5892 Set IT->current to match the bidi iterator unconditionally.
5893 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5894 entry. Force push_it to save on the stack the current
5895 buffer/string position, to be restored by pop_it. Fix flags in
5896 the iterator structure wrt the object coming from a display
5897 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5898 properties. (Bug#9284)
5900 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
5902 * fontset.c (fontset_get_font_group): Add proper type checks.
5905 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5907 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5908 and LC_VERSION_MIN_MACOSX.
5909 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5910 (dump_it) [LC_FUNCTION_STARTS]: Use it.
5912 2011-08-08 Eli Zaretskii <eliz@gnu.org>
5914 * xdisp.c (forward_to_next_line_start): Allow to use the
5915 no-display-properties-and-no-overlays under bidi display.
5916 Set disp_pos in the bidi iterator to avoid searches for display
5917 properties and overlays.
5919 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
5921 * editfns.c (Fset_time_zone_rule): Document relationship with the
5924 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5925 the font entity extracted from the cache (Bug#8109).
5927 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
5929 * composite.c (autocmp_chars): Don't reset point. That is done by
5930 restore_point_unwind (Bug#5984).
5932 2011-08-07 Juri Linkov <juri@jurta.org>
5934 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5935 to show the arg `TIME' instead of `TIMEVAL'.
5937 2011-08-06 Eli Zaretskii <eliz@gnu.org>
5939 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5940 display property strides EOL and includes a newline, as in
5941 longlines-mode. (Bug#9254)
5942 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5943 word-wrap under bidirectional display. (Bug#9224)
5945 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5946 is non-zero, even if the data buffer is NULL. Fixes a crash in
5947 vertical-motion with longlines-mode. (Bug#9254)
5949 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5951 * bidi.c <bidi_cache_total_alloc>: Now static.
5952 (bidi_initialize): Initialize bidi_cache_total_alloc.
5954 * xdisp.c (display_line): Release buffer allocated for shelved bidi
5957 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5958 amount allocated this far in `bidi_cache_total_alloc'.
5959 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5960 non-zero, only free the data buffer without restoring the cache
5961 contents. All callers changed.
5963 * dispextern.h (bidi_unshelve_cache): Update prototype.
5965 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5966 (move_it_in_display_line, move_it_to)
5967 (move_it_vertically_backward, move_it_by_lines): Replace the call
5968 to xfree to an equivalent call to bidi_unshelve_cache.
5969 (move_it_in_display_line_to): Fix logic of returning
5970 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
5972 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5974 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5975 came from a string character with a `cursor' property. (Bug#9229)
5977 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5979 * Makefile.in (LIB_PTHREAD): New variable.
5980 (LIBES): Add LIB_PTHREAD (Bug#9216).
5982 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5983 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5985 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5987 * regex.c (re_iswctype): Remove some redundant boolean conversions.
5989 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5991 * xterm.c (x_find_topmost_parent): New function.
5992 (x_set_frame_alpha): Find topmost parent window with
5993 x_find_topmost_parent and set the property there also (bug#9181).
5994 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5996 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5998 * callproc.c (Fcall_process): Avoid vfork clobbering
5999 the local vars buffer, coding_systems, current_dir.
6001 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6003 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6005 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6007 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6008 so that it is not optimized away.
6010 * xdisp.c (compute_display_string_pos): Remove unused local.
6012 2011-08-02 Eli Zaretskii <eliz@gnu.org>
6014 Fix slow cursor motion and scrolling in large buffers with
6015 selective display, like Org Mode buffers. (Bug#9218)
6017 * dispextern.h (struct bidi_it): New member disp_prop_p.
6019 * xdisp.c: Remove one-slot cache of display string positions.
6020 (compute_display_string_pos): Accept an additional argument
6021 DISP_PROP_P; callers changed. Scan at most 5K characters forward
6022 for a display string or property. If found, set DISP_PROP_P
6025 * bidi.c (bidi_fetch_char): Accept an additional argument
6026 DISP_PROP_P, and pass it to compute_display_string_pos.
6027 Only handle text covered by a display string if DISP_PROP_P is returned
6028 non-zero. All callers of bidi_fetch_char changed.
6030 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6032 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6034 2010-12-03 Don March <don@ohspite.net>
6036 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6037 last character M-[char] is translated to ESC [char] (bug#7541).
6039 2011-08-02 Kenichi Handa <handa@m17n.org>
6041 * lisp.h (uniprop_table): Extern it.
6043 * chartab.c (uniprop_table): Make it non-static.
6045 2011-08-01 Eli Zaretskii <eliz@gnu.org>
6047 * xdisp.c (forward_to_next_line_start): Accept additional argument
6048 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6050 (reseat_at_next_visible_line_start): Use the bidi iterator state
6051 returned by forward_to_next_line_start to restore the state of
6052 it->bidi_it after backing up to previous newline. (Bug#9212)
6054 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6056 * regex.c (re_comp): Protoize.
6057 (re_exec): Fix return type.
6058 (regexec): Fix type of `ret'. (Bug#9203)
6060 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6062 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6063 This is needed if max-image-size is a floating-point number.
6065 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6067 * print.c (print_object): Print empty symbol as ##.
6069 * lread.c (read1): Read ## as empty symbol.
6071 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6073 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6074 setting frame foreground color (Bug#9175).
6075 (x_set_background_color): Likewise.
6077 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6078 contents (Bug#9176).
6079 (EmacsTooltip -init): Remove bezels and add shadows to
6082 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6083 or scroll bar (Bug#8470).
6085 * nsfont.m (nsfont_open): Remove assignment to voffset and
6086 unnecessary vars hshink, expand, hd, full_height, min_height.
6087 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6089 * nsterm.h (nsfont_info): Remove voffset field.
6091 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6093 Implement strike-through and overline on NextStep (Bug#8863).
6095 * nsfont.m (nsfont_open): Use underline position provided by font,
6096 instead of hard-coded value of 2.
6097 (nsfont_draw): Call ns_draw_text_decoration instead.
6099 * nsterm.h: Add declaration for ns_draw_text_decoration.
6101 * nsterm.m (ns_draw_text_decoration): New function for drawing
6102 underline, overline, and strike-through.
6103 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6104 ns_draw_text_decoration. Change treatment of cursor drawing to
6105 accommodate underlining, etc.
6107 2011-07-28 Eli Zaretskii <eliz@gnu.org>
6109 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6112 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6114 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6115 Without this fix, if a signal arrives just after memory fills up,
6116 'malloc' might be invoked reentrantly.
6118 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6119 In other words, assume that every image size is allowed, on non-X
6120 hosts. This assumption is probably wrong, but it lets Emacs compile.
6122 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6124 * regex.c (re_iswctype): Convert return values to boolean.
6126 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6128 * xdisp.c (compute_display_string_pos): Don't use cached display
6129 string position if the buffer had its restriction changed.
6132 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6134 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6136 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6138 Integer signedness and overflow and related fixes. (Bug#9079)
6140 * bidi.c: Integer size and overflow fixes.
6141 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6142 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6143 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6144 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6145 (bidi_find_other_level_edge):
6146 Use ptrdiff_t instead of EMACS_INT where either will do.
6147 This works better on 32-bit hosts configured --with-wide-int.
6148 (bidi_cache_ensure_space): Check for size-calculation overflow.
6149 Use % rather than repeated addition, for better worst-case speed.
6150 Don't set bidi_cache_size until after xrealloc returns, because it
6152 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
6153 (bidi_cache_ensure_space): Also check that the bidi cache size
6154 does not exceed that of the largest Lisp string or buffer. See Eli
6155 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
6157 * alloc.c (__malloc_size_t): Remove.
6158 All uses replaced by size_t. See Andreas Schwab's note
6159 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6161 * image.c: Improve checking for integer overflow.
6162 (check_image_size): Assume that f is nonnull, since
6163 it is always nonnull in practice. This is one less thing to
6164 worry about when checking for integer overflow later.
6165 (x_check_image_size): New function, which checks for integer
6166 overflow issues inside X.
6167 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6168 This removes the need for a memory_full check.
6169 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6170 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6171 (xbm_read_bitmap_data): Change locals back to 'int', since
6172 their values must fit in 'int'.
6173 (xpm_load_image, png_load, tiff_load):
6174 Invoke x_create_x_image_and_pixmap earlier,
6175 to avoid much needless work if the image is too large.
6176 (tiff_load): Treat overly large images as if
6177 x_create_x_image_and_pixmap failed, not as malloc failures.
6178 (gs_load): Use x_check_image_size.
6180 * gtkutil.c: Omit integer casts.
6181 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6182 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6184 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6186 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6187 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6188 would wrongly return t on a 64-bit host.
6190 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6191 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6192 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6193 and therefore cause GCC to emit a bogus diagnostic in some cases.
6195 * image.c: Integer signedness and overflow and related fixes.
6196 This is not an exhaustive set of fixes, but it's time to
6197 record what I've got.
6198 (lookup_pixel_color, check_image_size): Remove redundant decls.
6199 (check_image_size): Don't assume that arbitrary EMACS_INT values
6200 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6201 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6202 (tiff_load, imagemagick_load_image):
6203 Check for overflow in size calculations.
6204 (x_create_x_image_and_pixmap): Remove unnecessary test for
6205 xmalloc returning NULL; that can't happen.
6206 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6207 (xpm_color_bucket): Use better integer hashing function.
6208 (xpm_cache_color): Don't possibly over-allocate memory.
6209 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6210 (gif_memory_source):
6211 Use ptrdiff_t, not int or size_t, to record sizes.
6212 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6213 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6214 either works, as we prefer signed integers.
6215 (tiff_read_from_memory, tiff_write_from_memory):
6216 Return tsize_t, not size_t, since that's what the TIFF API wants.
6217 (tiff_read_from_memory): Don't fail simply because the read would
6218 go past EOF; instead, return a short read.
6219 (tiff_load): Omit no-longer-needed casts.
6220 (Fimagemagick_types): Don't assume size fits into 'int'.
6222 Improve hashing quality when configured --with-wide-int.
6223 * fns.c (hash_string): New function, taken from sxhash_string.
6224 Do not discard information about ASCII character case; this
6225 discarding is no longer needed.
6226 (sxhash-string): Use it. Change sig to match it. Caller changed.
6227 * lisp.h: Declare it.
6228 * lread.c (hash_string): Remove, since we now use fns.c's version.
6229 The fns.c version returns a wider integer if --with-wide-int is
6230 specified, so this should help the quality of the hashing a bit.
6232 * emacs.c: Integer overflow minor fix.
6233 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6234 Define only if GNU_LINUX.
6235 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6237 * dispnew.c: Integer signedness and overflow fixes.
6238 Remove unnecessary forward decls, that were a maintenance hassle.
6239 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6241 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6242 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6243 (prepare_desired_row, line_draw_cost):
6244 Use int, not unsigned, where either works.
6245 (save_current_matrix, restore_current_matrix):
6246 Use ptrdiff_t, not size_t, where either works.
6247 (init_display): Check for overflow more accurately, and without
6248 relying on undefined behavior.
6250 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6251 Remove, replacing with the new symbols in lisp.h. All uses changed.
6252 * fileio.c (make_temp_name):
6253 * filelock.c (lock_file_1, lock_file):
6254 * xdisp.c (message_dolog):
6255 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6256 Use pMd etc. instead.
6257 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6258 replacing the pWIDE etc. symbols removed from editfns.c.
6260 * keyboard.h (num_input_events): Now uintmax_t.
6261 This is (very slightly) less likely to mess up due to wraparound.
6264 * buffer.c: Integer signedness fixes.
6265 (alloc_buffer_text, enlarge_buffer_text):
6266 Use ptrdiff_t rather than size_t when either will do, as we prefer
6269 * alloc.c: Integer signedness and overflow fixes.
6270 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6271 (__malloc_size_t): Default to size_t, not to int.
6272 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6273 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6274 Prefer ptrdiff_t to size_t when either would do, as we prefer
6276 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6277 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6278 Now const. Initialize with values that are in range even if char
6280 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6281 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6282 These functions do the right thing with sizes > 2**32.
6283 (check_depth): Now ptrdiff_t, not int.
6284 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6285 Adjust to new way of storing sizes. Check for size overflow bugs
6287 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6288 slightly wrong anyway, as it missed one instance of
6289 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6290 (refill_memory_reserve): Omit needless cast to size_t.
6291 (mark_object_loop_halt): Mark as externally visible.
6293 * xselect.c: Integer signedness and overflow fixes.
6294 (Fx_register_dnd_atom, x_handle_dnd_message):
6295 Use ptrdiff_t, not size_t, since we prefer signed.
6296 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6297 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6298 x_dnd_atoms_size and x_dnd_atoms_length.
6300 * doprnt.c: Prefer signed to unsigned when either works.
6302 * doprnt.c (doprnt):
6304 * xdisp.c (vmessage):
6305 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6306 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6307 prefer signed arithmetic to avoid comparison confusion.
6308 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6309 but is a bit tricky.
6311 Assume freestanding C89 headers, string.h, stdlib.h.
6312 * data.c, doprnt.c, floatfns.c, print.c:
6313 Include float.h unconditionally.
6314 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6315 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6316 * regex.c: Likewise for stddef.h, string.h.
6317 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6318 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6319 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6320 (STDC_HEADERS): Remove obsolete defines.
6321 * sysdep.c: Include limits.h unconditionally.
6323 Assume support for memcmp, memcpy, memmove, memset.
6324 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6325 * regex.c (memcmp, memcpy):
6326 Remove; we assume C89 now.
6328 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6329 (__malloc_safe_bcopy): Remove; no longer needed.
6331 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6332 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6333 well either way, and we prefer signed to unsigned.
6335 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6337 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6338 closes the connection while we're reading (bug#9182).
6340 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
6342 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6343 are specified (Bug#9168).
6345 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6347 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6348 Found by GCC static checking and --with-wide-int on a 32-bit host.
6350 2011-07-25 Eli Zaretskii <eliz@gnu.org>
6352 * xdisp.c (compute_display_string_pos): Fix logic of caching
6353 previous display string position. Initialize cached_prev_pos to
6354 -1. Fixes slow-down at the beginning of a buffer.
6356 2011-07-24 Eli Zaretskii <eliz@gnu.org>
6358 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6359 for attrs[LFACE_FONTSET_INDEX].
6361 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6363 * xml.c (parse_region): Remove unused local
6364 that was recently introduced.
6366 2011-07-23 Eli Zaretskii <eliz@gnu.org>
6368 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6369 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6371 * xdisp.c (move_it_in_display_line_to): Record the best matching
6372 position for TO_CHARPOS while scanning the line, and restore it on
6373 exit if none of the characters scanned was an exact match.
6374 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
6375 when exact match is impossible due to invisible text, and the
6376 lines are truncated.
6378 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6380 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6383 2011-07-22 Eli Zaretskii <eliz@gnu.org>
6385 Fix a significant slow-down of cursor motion with C-n, C-p,
6386 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6387 auto-repeat under bidi redisplay in fontified buffers.
6388 * xdisp.c (compute_stop_pos_backwards): New function.
6389 (next_element_from_buffer): Call compute_stop_pos_backwards to
6390 find a suitable prev_stop when we find ourselves before
6392 (reseat): Don't look for prev_stop, as that could mean a very long
6394 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6395 <cached_disp_overlay_modiff>: Cache for last found display string
6397 (compute_display_string_pos): Return the cached position if asked
6398 about the same buffer in the same area of character positions, and
6399 the buffer wasn't changed since the time the display string
6400 position was cached.
6402 2011-07-22 Eli Zaretskii <eliz@gnu.org>
6404 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6405 is an integer, which is important for empty lines. (Bug#9149)
6407 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
6409 * frame.c (Fmodify_frame_parameters): In tty case, update the
6410 default face if necessary (Bug#4238).
6412 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
6414 * editfns.c (Fstring_to_char): No need to explain what a character
6415 is in the docstring (Bug#6576).
6417 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6419 * xml.c (parse_region): Make sure we always return a tree.
6421 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6423 * xml.c (parse_region): If a document contains only comments,
6426 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6428 * xml.c (make_dom): Return comments, too.
6430 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6433 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6434 and the surrounding thread.
6435 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6436 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6437 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6439 * s/openbsd.h (BROKEN_SIGIO): Define.
6440 * unexelf.c (unexec) [__OpenBSD__]:
6441 Don't update the .mdebug section of the Alpha COFF symbol table.
6443 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6445 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6448 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6450 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6451 This fixes some race conditions on the permissions of any newly
6454 * alloc.c (valid_pointer_p): Use pipe, not open.
6455 This fixes some permissions issues when debugging.
6457 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6458 If fchown fails to set both uid and gid, try to set just gid,
6459 as that is sometimes allowed. Adjust the file's mode to eliminate
6460 setuid or setgid bits that are inappropriate if fchown fails.
6462 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6464 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6465 to compare Lisp_Objects.
6466 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6467 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6468 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6470 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6472 * lread.c (read_integer): Unread even EOF character.
6473 (read1): Likewise. Properly record start position of symbol.
6475 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6476 symbol character follows.
6478 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6480 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6481 This works around a problem with the previous change to Fcopy_file.
6482 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6483 and without this change, GCC might complain about discarding
6484 fchown's return value.
6486 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
6488 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6490 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6492 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6494 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6496 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6497 it's used from the C level.
6499 * process.c: Use the same condition for POLL_FOR_INPUT in both
6500 keyboard.c and process.c (bug#1858).
6502 2011-07-09 Lawrence Mitchell <wence@gmx.li>
6504 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6505 (Fgnutls_boot): Use it.
6507 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6509 * doc.c (Fsubstitute_command_keys): Revert last change.
6511 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6513 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6514 quotes the next character, and doesn't affect other longer
6515 sequences (bug#8935).
6517 * lread.c (syms_of_lread): Clarify that is isn't only
6518 `eval-buffer' and `eval-defun' that's affected by
6519 `lexical-binding' (bug#8460).
6521 2011-07-15 Eli Zaretskii <eliz@gnu.org>
6523 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6524 bidi redisplay when a line includes both an image and is truncated.
6526 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6528 Fix minor problems found by static checking.
6529 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6530 (elsz): Now a signed constant, not a size_t var. We prefer signed
6531 types to unsigned, to avoid integer comparison confusion. Without
6532 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6533 "cannot optimize loop, the loop counter may overflow", a symptom
6535 * indent.c (Fvertical_motion): Mark locals as initialized.
6536 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6538 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6540 * search.c (Fre_search_backward): Mention `case-fold-search' in
6541 all the re_search_* functions (bug#8138).
6543 * keyboard.c (Fopen_dribble_file): Document when the file is
6546 2011-07-14 Eli Zaretskii <eliz@gnu.org>
6548 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6551 Support bidi reordering of display and overlay strings.
6552 * xdisp.c (compute_display_string_pos)
6553 (compute_display_string_end): Accept additional argument STRING.
6554 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6555 (reseat_to_string): Initialize bidi_it->string.s and
6556 bidi_it->string.schars.
6557 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
6558 NULL (avoids a crash in bidi_paragraph_init).
6559 Initialize itb.string.lstring.
6560 (init_iterator): Call bidi_init_it only of a valid
6561 buffer position was specified. Initialize paragraph_embedding to
6563 (reseat_to_string): Initialize the bidi iterator.
6564 (display_string): If we need to ignore text properties of
6565 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6566 original value of -1 will not work with bidi.)
6567 (compute_display_string_pos): First arg is now struct
6568 `text_pos *'; all callers changed. Support display properties on
6570 (compute_display_string_end): Support display properties on Lisp
6572 (init_iterator, reseat_1, reseat_to_string): Initialize the
6573 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6574 when iterating on a string not from display properties).
6575 (compute_display_string_pos, compute_display_string_end):
6576 Fix calculation of the object to scan. Fixes an error when using
6578 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
6579 base_level_stop; instead, set base_level_stop to BEGV.
6580 Fixes crashes in vertical-motion.
6581 (next_element_from_buffer): Improve commentary for when
6582 the iterator is before prev_stop.
6583 (init_iterator): Initialize bidi_p from the default value of
6584 bidi-display-reordering, not from buffer-local value. Use the
6585 buffer-local value only if initializing for buffer iteration.
6586 (handle_invisible_prop): Support invisible properties on strings
6587 that are being bidi-reordered.
6588 (set_iterator_to_next): Support bidi reordering of C strings and
6590 (next_element_from_string): Support bidi reordering of Lisp
6592 (handle_stop_backwards): Support Lisp strings as well.
6593 (display_string): Support display of R2L glyph rows.
6594 Use IT_STRING_CHARPOS when displaying from a Lisp string.
6595 (init_iterator): Don't initialize it->bidi_p for strings
6597 (reseat_to_string): Initialize it->bidi_p for strings here.
6598 (next_element_from_string, next_element_from_c_string)
6599 (next_element_from_buffer): Add xassert's for correspondence
6600 between IT's object being iterated and it->bidi_it.string
6602 (face_before_or_after_it_pos): Support bidi iteration.
6603 (next_element_from_c_string): Handle the case of the first string
6604 character that is not the first one in the visual order.
6605 (get_visually_first_element): New function, refactored from common
6606 parts of next_element_from_buffer, next_element_from_string, and
6607 next_element_from_c_string.
6608 (tool_bar_lines_needed, redisplay_tool_bar)
6609 (display_menu_bar): Force left-to-right direction. Add a FIXME
6610 comment for making that be controlled by a user option.
6611 (push_it, pop_it): Save and restore the state of the
6612 bidi iterator. Save and restore the bidi_p flag.
6613 (pop_it): Iterate out of display property for string iteration as
6615 (iterate_out_of_display_property): Support iteration over strings.
6616 (handle_single_display_spec): Set up it->bidi_it for iteration
6617 over a display string, and call bidi_init_it.
6618 (handle_single_display_spec, next_overlay_string)
6619 (get_overlay_strings_1, push_display_prop): Set up the bidi
6620 iterator for displaying display or overlay strings.
6621 (forward_to_next_line_start): Don't use the shortcut if
6623 (back_to_previous_visible_line_start): If handle_display_prop
6624 pushed the iterator stack, restore the internal state of the bidi
6625 iterator by calling bidi_pop_it same number of times.
6626 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6627 and we are bidi-iterating, don't decrement the iterator position;
6628 instead, set the first_elt flag in the bidi iterator, to produce
6630 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6631 (push_display_prop): xassert that we are iterating a buffer.
6632 (push_it, pop_it): Save and restore paragraph_embedding member.
6633 (handle_single_display_spec, next_overlay_string)
6634 (get_overlay_strings_1, reseat_1, reseat_to_string)
6635 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6636 correctly. Don't assume unibyte strings are not bidi-reordered.
6637 (compute_display_string_pos)
6638 (compute_display_string_end): Fix handling the case of C string.
6639 (push_it, pop_it): Save and restore from_disp_prop_p.
6640 (handle_single_display_spec, push_display_prop): Set the
6641 from_disp_prop_p flag.
6642 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6643 (pop_it): Call iterate_out_of_display_property only if we are
6644 popping after iteration over a string that came from a display
6645 property. Fix a typo in popping stretch info. Add an assertion
6646 for verifying that the iterator position is in sync with the bidi
6648 (handle_single_display_spec, get_overlay_strings_1)
6649 (push_display_prop): Fix initialization of paragraph direction for
6650 string when that of the parent object is not yet determined.
6651 (reseat_1): Call bidi_init_it to resync the bidi
6652 iterator with IT's position. (Bug#7616)
6653 (find_row_edges): If ROW->start.pos gives position
6654 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6655 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6656 Reset the from_disp_prop_p flag.
6657 (SAVE_IT, RESTORE_IT): New macros.
6658 (pos_visible_p, face_before_or_after_it_pos)
6659 (back_to_previous_visible_line_start)
6660 (move_it_in_display_line_to, move_it_in_display_line)
6661 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6662 (try_scrolling, redisplay_window, display_line): Use them when
6663 saving a temporary copy of the iterator and restoring it back.
6664 (back_to_previous_visible_line_start, reseat_1)
6665 (init_iterator): Empty the bidi cache "stack".
6666 (move_it_in_display_line_to): If iterator ended up at
6667 EOL, but we never saw any buffer positions smaller than
6668 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6669 motion in bidi-reordered lines.
6670 (move_it_in_display_line_to): Record prev_method and prev_pos
6671 immediately before the call to set_iterator_to_next. Fixes cursor
6672 motion in bidi-reordered lines with stretch glyphs and strings
6673 displayed in margins. (Bug#8133) (Bug#8867)
6674 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6676 (pos_visible_p): Support positions in bidi-reordered lines.
6677 Save and restore bidi cache.
6679 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6680 (bidi_paragraph_info): Delete unused struct.
6681 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6682 (bidi_cache_start): New variable.
6683 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6685 (bidi_cache_fetch_state, bidi_cache_search)
6686 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6687 (bidi_cache_find, bidi_peek_at_next_level)
6688 (bidi_level_of_next_char, bidi_find_other_level_edge)
6689 (bidi_move_to_visually_next): Compare cache index with
6690 bidi_cache_start rather than with zero.
6691 (bidi_fetch_char): Accept new argument STRING; all callers
6692 changed. Support iteration over a string. Support strings with
6693 display properties. Support unibyte strings. Fix the type of
6694 `len' according to what STRING_CHAR_AND_LENGTH expects.
6695 (bidi_paragraph_init, bidi_resolve_explicit_1)
6696 (bidi_resolve_explicit, bidi_resolve_weak)
6697 (bidi_level_of_next_char, bidi_move_to_visually_next):
6698 Support iteration over a string.
6699 (bidi_set_sor_type, bidi_resolve_explicit_1)
6700 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6701 can now be zero (for strings); special values 0 and -1 were
6702 changed to -1 and -2, respectively.
6703 (bidi_char_at_pos): New function.
6704 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6705 Call it instead of FETCH_MULTIBYTE_CHAR.
6706 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6707 initialized to valid values.
6708 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6710 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6711 the test for valid cached positions. Fix the logic for looking up
6712 the sentinel state in the cache. GCPRO the Lisp string we are
6714 (bidi_push_it, bidi_pop_it): New functions.
6715 (bidi_initialize): Initialize the bidi cache start stack pointer.
6716 (bidi_cache_ensure_space): New function, refactored from part of
6717 bidi_cache_iterator_state. Don't assume the required size is just
6718 one BIDI_CACHE_CHUNK away.
6719 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6720 (bidi_count_bytes, bidi_char_at_pos): New functions.
6721 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6722 always valid if bidi_cache_idx is valid.
6723 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6724 is valid if it's going to be used.
6725 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6726 (bidi_cache_fetch_state, bidi_cache_search)
6727 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6728 (bidi_cache_iterator_state, bidi_cache_find)
6729 (bidi_find_other_level_edge, bidi_cache_start_stack):
6730 All variables related to cache indices are now EMACS_INT.
6732 * dispextern.h (struct bidi_string_data): New structure.
6733 (struct bidi_it): New member `string'. Make flag members be 1-bit
6734 fields, and put them last in the struct.
6735 (compute_display_string_pos, compute_display_string_end):
6737 (bidi_push_it, bidi_pop_it): Add prototypes.
6738 (struct iterator_stack_entry): New members bidi_p,
6739 paragraph_embedding, and from_disp_prop_p.
6740 (struct it): Member bidi_p is now a bit field 1 bit wide.
6741 (bidi_shelve_cache, bidi_unshelve_cache):
6744 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6745 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6746 and vector-like objects.
6748 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6749 cache around display iteration.
6751 * window.c (Fwindow_end, window_scroll_pixel_based)
6752 (displayed_window_lines, Frecenter): Save and restore the bidi
6753 cache around display iteration.
6755 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6757 * editfns.c (Fdelete_region): Clarify the use of the named
6758 parameters (bug#6788).
6760 2011-07-14 Martin Rudalics <rudalics@gmx.at>
6762 * indent.c (Fvertical_motion): Set and restore w->pointm when
6763 saving and restoring the window's buffer (Bug#9006).
6765 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6767 * editfns.c (Fstring_to_char): Clarify just what is returned
6768 (bug#6576). Text by Eli Zaretskii.
6770 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
6772 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6774 2011-07-13 Eli Zaretskii <eliz@gnu.org>
6776 * buffer.c (mmap_find): Fix a typo.
6778 2011-07-13 Johan Bockgård <bojohan@gnu.org>
6780 Fix execution of x selection hooks.
6781 * xselect.c (Qx_lost_selection_functions)
6782 (Qx_sent_selection_functions): New vars.
6783 (syms_of_xselect): DEFSYM them.
6784 (x_handle_selection_request): Pass Qx_sent_selection_functions
6785 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6786 (x_handle_selection_clear,x_clear_frame_selections):
6787 Pass Qx_lost_selection_functions rather than
6788 Vx_lost_selection_functions to Frun_hook_with_args.
6790 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6792 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
6793 The old code sometimes used this field without initializing it.
6795 * alloc.c (gc_sweep): Don't read past end of array.
6796 In theory, the old code could also have corrupted Emacs internals,
6797 though it'd be very unlikely.
6799 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6801 * character.c (Fcharacterp): Don't advertise optional ignored
6802 argument. (Bug#4026)
6804 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6806 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6809 * window.c (Fset_window_start): Doc fix (bug#4199).
6810 (Fset_window_hscroll): Ditto.
6812 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6814 Fix minor new problems caught by GCC 4.6.1.
6815 * term.c (init_tty): Remove unused local.
6816 * xsettings.c (store_monospaced_changed): Define this function only
6817 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
6820 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
6822 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6824 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6826 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6827 are the mini-buffer and the echo area (bug#3320).
6829 * term.c (init_tty): Remove support for supdup, c10 and perq
6830 terminals, which are no longer supported (bug#1482).
6832 2011-07-10 Johan Bockgård <bojohan@gnu.org>
6834 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6836 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6838 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6839 for non-popups (Bug#3642).
6841 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6843 * alloc.c (reset_malloc_hooks): Protoize.
6844 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
6845 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6846 * cm.c (losecursor): Likewise.
6847 * data.c (fmod): Likewise.
6848 * dispnew.c (swap_glyphs_in_rows): Likewise.
6849 * emacs.c (memory_warning_signal): Likewise.
6850 * floatfns.c (float_error): Likewise.
6851 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6852 (otf_open, font_otf_capability, generate_otf_features)
6853 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6855 * image.c (pbm_read_file): Likewise.
6856 * indent.c (string_display_width): Likewise.
6857 * intervals.c (check_for_interval, search_for_interval)
6858 (inc_interval_count, count_intervals, root_interval)
6859 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6860 * lread.c (defalias): Likewise.
6861 * ralloc.c (r_alloc_check): Likewise.
6862 * regex.c (set_image_of_range_1, set_image_of_range)
6863 (regex_grow_registers): Likewise.
6864 * sysdep.c (strerror): Likewise.
6865 * termcap.c (valid_filename_p, tprint, main): Likewise.
6866 * tparam.c (main): Likewise.
6867 * unexhp9k800.c (run_time_remap, save_data_space)
6868 (update_file_ptrs, read_header, write_header, calculate_checksum)
6869 (copy_file, copy_rest, display_header): Likewise.
6870 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6872 * xdisp.c (check_it): Likewise.
6873 * xfaces.c (register_color, unregister_color, unregister_colors):
6875 * xfns.c (print_fontset_result): Likewise.
6876 * xrdb.c (member, fatal, main): Likewise.
6878 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6880 Fix minor problems found by static checking (Bug#9031).
6881 * chartab.c (char_table_set_range, map_sub_char_table):
6882 Remove unused locals.
6883 (uniprop_table): Now static.
6884 * composite.c (_work_char): Remove unused static var.
6886 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
6888 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6890 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6892 * gtkutil.c (qttip_cb): Remove code without function.
6894 2011-07-09 Eli Zaretskii <eliz@gnu.org>
6896 * w32.c (pthread_sigmask): New stub.
6898 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
6900 Use pthread_sigmask, not sigprocmask (Bug#9010).
6901 sigprocmask is portable only for single-threaded applications, and
6902 Emacs can be multi-threaded when it uses GTK.
6903 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6905 * callproc.c (Fcall_process):
6906 * process.c (create_process):
6907 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6908 Use pthread_sigmask, not sigprocmask.
6910 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6912 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6913 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6916 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6918 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6919 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6920 (xg_hide_tooltip): Fix comment.
6922 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6923 in registerServicesMenuSendTypes.
6924 (validRequestorForSendType): Don't check ns_return_types.
6926 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6929 2011-07-08 Jason Rumney <jasonr@gnu.org>
6931 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6932 SH_SHOW for hidden windows (Bug#5482).
6934 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6935 frame struct members of non-existent frames (Bug#6284).
6937 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6939 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6940 variable firstTime not needed on OSX >= 10.6.
6941 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6942 >= 10.5. Use setKnobProportion, setDoubleValue.
6944 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6945 (MAC_OS_X_VERSION_10_5): Define if not defined.
6946 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6947 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6948 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6950 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6951 cString and lossyCString on OSX >= 10.4
6953 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
6954 sizeToFit on OSX >= 10.2.
6956 * nsimage.m (allocInitFromFile): Don't use deprecated method
6957 bestRepresentationForDevice on OSX >= 10.6.
6959 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6962 * emacs.c: Declare unexec_init_emacs_zone.
6964 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6966 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6968 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6969 on svcsMenu (Bug#8842).
6971 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6973 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6975 * nsterm.m (QUTF8_STRING): Declare.
6976 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6977 (validRequestorForSendType): Return type is (id).
6978 Change indexOfObjectIdenticalTo to indexOfObject.
6979 Check if we have local selection before returning self (Bug#8842).
6980 (writeSelectionToPasteboard): Put local selection into paste board
6981 if we have a local selection (Bug#8842).
6982 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6984 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6985 (ns_get_local_selection): Declare.
6987 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6989 * keymap.c (describe_map_tree): Don't insert a double newline at
6990 the end of the buffer (bug#1169) and return whether we inserted
6993 * callint.c (Fcall_interactively): Change "reading args" to
6994 "providing args" to try to clarify what it does (bug#1010).
6996 2011-07-07 Kenichi Handa <handa@m17n.org>
6998 * composite.c (composition_compute_stop_pos): Ignore a static
6999 composition starting before CHARPOS (Bug#8915).
7001 * xdisp.c (handle_composition_prop): Likewise.
7003 2011-07-07 Eli Zaretskii <eliz@gnu.org>
7005 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7008 2011-07-07 Kenichi Handa <handa@m17n.org>
7010 * character.h (unicode_category_t): New enum type.
7012 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7013 (Qchar_code_property_table): New variable.
7014 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7015 (UNIPROP_COMPRESSED_FORM_P): New macros.
7016 (char_table_ascii): Uncompress the compressed values.
7017 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7018 Uncompress the compressed values.
7019 (sub_char_table_ref_and_range): Likewise.
7020 (char_table_ref_and_range): Uncompress the compressed values.
7021 (sub_char_table_set): New arg is_uniprop. Callers changed.
7022 Uncompress the compressed values.
7023 (sub_char_table_set_range): Args changed. Callers changed.
7024 (char_table_set_range): Adjuted for the above change.
7025 (map_sub_char_table): Delete args default_val and parent. Add arg
7026 top. Give decoded values to a Lisp function.
7027 (map_char_table): Adjust for the above change. Give decoded
7028 values to a Lisp function. Gcpro more variables.
7029 (uniprop_table_uncompress)
7030 (uniprop_decode_value_run_length): New functions.
7031 (uniprop_decoder, uniprop_decoder_count): New variables.
7032 (uniprop_get_decoder, uniprop_encode_value_character)
7033 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7035 (uniprop_encoder, uniprop_encoder_count): New variables.
7036 (uniprop_get_encoder, uniprop_table)
7037 (Funicode_property_table_internal, Fget_unicode_property_internal)
7038 (Fput_unicode_property_internal): New functions.
7039 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7040 Sunicode_property_table_internal, Sget_unicode_property_internal,
7041 and Sput_unicode_property_internal. Defvar_lisp
7042 char-code-property-alist.
7044 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
7045 Vunicode_category_table.
7047 * font.c (font_range): Adjust for the change of
7048 Vunicode_category_table.
7050 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7052 * m/iris4d.h: Remove file, move contents ...
7053 * s/irix6-5.h: ... here.
7055 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7057 Remove unportable assumption about struct layout (Bug#8884).
7058 * alloc.c (mark_buffer):
7059 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7060 (clone_per_buffer_values): Don't assume that
7061 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7062 This isn't true in general, and it's particularly not true
7063 if Emacs is configured with --with-wide-int.
7064 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7065 New macros, used in the buffer.c change.
7067 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7069 * xsettings.c: Use both GConf and GSettings if both are available.
7070 (store_config_changed_event): Add comment.
7071 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7072 (store_tool_bar_style_changed): New functions.
7073 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
7074 (struct xsettings): Move font inside HAVE_XFT.
7075 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
7076 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
7077 Move inside HAVE_XFT.
7078 (something_changed_gsettingsCB): Rename from something_changedCB.
7079 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7081 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
7082 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
7083 (something_changed_gconfCB): Rename from something_changedCB.
7084 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7085 (parse_settings): Move check for font inside HAVE_XFT.
7086 (read_settings, apply_xft_settings): Add comment.
7087 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7088 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7089 call store_font_name_changed.
7090 (xft_settings_event): Add comment.
7091 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7092 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7093 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7094 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7095 (xsettings_initialize): Call init_gsettings last.
7096 (xsettings_get_system_font, xsettings_get_system_normal_font):
7099 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7101 Random fixes. E.g., (random) never returned negative values.
7102 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7103 subseconds part to the entropy, as that's a bit more random.
7104 Prefer signed to unsigned, since the signedness doesn't matter and
7105 in general we prefer signed. When given a limit, use a
7106 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7107 latter isn't right if USE_2_TAGS_FOR_INTS.
7108 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7109 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7111 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7113 * textprop.c (text_property_stickiness):
7114 Obey Vtext_property_default_nonsticky.
7115 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7116 * w32fns.c (syms_of_w32fns):
7117 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7119 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7121 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7122 This is more efficient than Ffile_directory_p and avoids a minor race.
7124 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7126 * buffer.c (Foverlay_put): Say what the return value is
7129 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7130 is a directory before asking whether to use the file name
7132 (barf_or_query_if_file_exists): Make the "File is a directory"
7133 error be more correct.
7135 * fns.c (Frequire): Remove the mention of the .gz files, since
7136 that's installation-specific, but keep the mention of
7137 `get-load-suffixes'.
7139 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7141 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7142 Report string overflow if the output is too long.
7144 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
7146 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7147 (syms_of_gnutls): Remove duplicate DEFSYM for
7148 Qgnutls_bootprop_verify_hostname_error, an error for
7149 Qgnutls_bootprop_verify_error (which is no longer used).
7151 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7152 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7153 Also (re)move comments that are misplaced or no longer relevant.
7155 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7157 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7159 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
7161 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7162 and background color parameters if they have been changed.
7164 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7166 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7168 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7170 * xsettings.c (SYSTEM_FONT): Define only when used.
7171 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7173 * keymap.c (access_keymap_1): Now static.
7175 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
7177 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7178 leave any prefix arg for the up event (Bug#1586).
7180 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7182 * lread.c (syms_of_lread): Mention single symbols defined by
7183 `defvar' or `defconst' (bug#7154).
7185 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7186 (Frequire): Mention get-load-suffixes.
7188 2011-07-02 Martin Rudalics <rudalics@gmx.at>
7190 * window.h (window): Remove clone_number slot.
7191 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7193 (make_parent_window, make_window, saved_window)
7194 (Fset_window_configuration, save_window_save): Don't deal with
7196 * buffer.c (Qclone_number): Remove declaration.
7197 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7199 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7201 Add multiple inheritance to keymaps.
7202 * keymap.c (Fmake_composed_keymap): New function.
7203 (Fset_keymap_parent): Simplify.
7204 (fix_submap_inheritance): Remove.
7205 (access_keymap_1): New function extracted from access_keymap to handle
7206 embedded parents and handle lists of maps.
7207 (access_keymap): Use it.
7208 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7209 (Fcopy_keymap): Handle embedded parents.
7210 (Fcommand_remapping, define_as_prefix): Simplify.
7211 (Fkey_binding): Simplify.
7212 (syms_of_keymap): Move minibuffer-local-completion-map,
7213 minibuffer-local-filename-completion-map,
7214 minibuffer-local-must-match-map, and
7215 minibuffer-local-filename-must-match-map to Elisp.
7216 (syms_of_keymap): Defsubr make-composed-keymap.
7217 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7218 (parse_menu_item): Trivial simplification.
7220 2011-07-01 Glenn Morris <rgm@gnu.org>
7222 * Makefile.in (SETTINGS_LIBS): Fix typo.
7224 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7226 * coding.c (Fencode_coding_string): Record the last coding system
7227 used, as the function doc string says (bug#8738).
7229 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7231 * xsettings.c (store_monospaced_changed): Take new font as arg and
7232 check for change against current_mono_font.
7233 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7234 (emacs_settings_constructor, emacs_settings_get_property)
7235 (emacs_settings_set_property, emacs_settings_class_init)
7236 (emacs_settings_init, gsettings_obj): Remove.
7237 (something_changedCB): New function for HAVE_GSETTINGS.
7238 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7239 with value as argument.
7240 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7241 g_settings_new (Bug#8967). Do not create gsettings_obj.
7242 Remove calls to g_settings_bind. Connect something_changedCB to
7245 * xgselect.c: Add defined (HAVE_GSETTINGS).
7246 (xgselect_initialize): Ditto.
7248 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7249 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7252 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7254 * eval.c (struct backtrace): Simplify and port the data structure.
7255 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7256 signed bit field, as this assumption is not portable and it makes
7257 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7258 "char debug_on_exit : 1" as this is not portable either; instead,
7259 use the portable "unsigned int debug_on_exit : 1". Remove unused
7260 member evalargs. Remove obsolete comments about cc bombing out.
7262 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7264 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
7265 Let HAVE_GSETTINGS override HAVE_GCONF.
7266 (store_monospaced_changed): New function.
7267 (EMACS_SETTINGS): A new type derived from GObject to handle
7268 GSettings notifications.
7269 (emacs_settings_constructor, emacs_settings_get_property)
7270 (emacs_settings_set_property, emacs_settings_class_init):
7272 (gsettings_client, gsettings_obj): New variables.
7273 (GSETTINGS_SCHEMA): New define.
7274 (something_changedCB): Call store_monospaced_changed.
7275 (init_gsettings): New function.
7276 (xsettings_initialize): Call init_gsettings.
7277 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7280 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
7283 2011-06-29 Martin Rudalics <rudalics@gmx.at>
7285 * window.c (resize_root_window, grow_mini_window)
7286 (shrink_mini_window): Rename Qresize_root_window to
7287 Qwindow_resize_root_window and Qresize_root_window_vertically to
7288 Qwindow_resize_root_window_vertically.
7290 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7292 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7294 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
7296 * makefile.w32-in: Redesign dependencies so they reflect more
7297 clearly which files are directly included by each source file,
7298 and not through other includes.
7300 2011-06-27 Martin Rudalics <rudalics@gmx.at>
7302 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7303 (sort_overlays, overlay_strings): When an overlay's clone number
7304 matches the window's clone number process the overlay even if
7305 the overlay's window property doesn't match the current window.
7307 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7308 (Fwindow_hchild): Rename to Fwindow_left_child.
7309 (Fwindow_next): Rename to Fwindow_next_sibling.
7310 (Fwindow_prev): Rename to Fwindow_prev_sibling.
7311 (resize_window_check): Rename to window_resize_check.
7312 (resize_window_apply): Rename to window_resize_apply.
7313 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7314 (Fdelete_other_windows_internal, resize_frame_windows)
7315 (Fsplit_window_internal, Fdelete_window_internal)
7316 (grow_mini_window, shrink_mini_window)
7317 (Fresize_mini_window_internal): Fix callers accordingly.
7319 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7321 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7322 (emacs_fixed_set_min_size): Remove.
7323 (emacs_fixed_new): Take frame as argument.
7325 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7326 (_EmacsFixedPrivate): Remove minwidth/height.
7327 Add struct frame *f.
7328 (emacs_fixed_init): Initialize priv->f.
7329 (get_parent_class, emacs_fixed_set_min_size): Remove.
7330 (emacs_fixed_new): Set priv->f to argument.
7331 (emacs_fixed_get_preferred_width)
7332 (emacs_fixed_get_preferred_height): Use min_width/height from
7333 frames size_hint to set minimum and natural (Bug#8919).
7334 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7335 and use min_width/height from frames size_hint to set
7336 min_width/height (Bug#8919).
7338 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
7339 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7342 2011-06-26 Eli Zaretskii <eliz@gnu.org>
7344 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7345 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7348 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
7350 * process.c (wait_reading_process_output): Bypass select if
7351 waiting for a cell while ignoring keyboard input, and input is
7352 pending. Suggested by Jan Djärv (Bug#8869).
7354 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7356 Use gnulib's dup2 module instead of rolling our own.
7357 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7359 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7361 * dispnew.c (scrolling_window): Before scrolling, turn off a
7362 mouse-highlight in the window being scrolled.
7364 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
7366 Move DEFSYM to lisp.h and use everywhere.
7368 * character.h (DEFSYM): Move declaration...
7369 * lisp.h (DEFSYM): ...here.
7375 * w32select.c: Don't include character.h.
7377 * alloc.c (syms_of_alloc):
7378 * buffer.c (syms_of_buffer):
7379 * bytecode.c (syms_of_bytecode):
7380 * callint.c (syms_of_callint):
7381 * casefiddle.c (syms_of_casefiddle):
7382 * casetab.c (init_casetab_once):
7383 * category.c (init_category_once, syms_of_category):
7384 * ccl.c (syms_of_ccl):
7385 * cmds.c (syms_of_cmds):
7386 * composite.c (syms_of_composite):
7387 * dbusbind.c (syms_of_dbusbind):
7388 * dired.c (syms_of_dired):
7389 * dispnew.c (syms_of_display):
7390 * doc.c (syms_of_doc):
7391 * editfns.c (syms_of_editfns):
7392 * emacs.c (syms_of_emacs):
7393 * eval.c (syms_of_eval):
7394 * fileio.c (syms_of_fileio):
7395 * fns.c (syms_of_fns):
7396 * frame.c (syms_of_frame):
7397 * fringe.c (syms_of_fringe):
7398 * insdel.c (syms_of_insdel):
7399 * keymap.c (syms_of_keymap):
7400 * lread.c (init_obarray, syms_of_lread):
7401 * macros.c (syms_of_macros):
7402 * msdos.c (syms_of_msdos):
7403 * print.c (syms_of_print):
7404 * process.c (syms_of_process):
7405 * search.c (syms_of_search):
7406 * sound.c (syms_of_sound):
7407 * syntax.c (init_syntax_once, syms_of_syntax):
7408 * terminal.c (syms_of_terminal):
7409 * textprop.c (syms_of_textprop):
7410 * undo.c (syms_of_undo):
7411 * w32.c (globals_of_w32):
7412 * window.c (syms_of_window):
7413 * xdisp.c (syms_of_xdisp):
7414 * xfaces.c (syms_of_xfaces):
7415 * xfns.c (syms_of_xfns):
7416 * xmenu.c (syms_of_xmenu):
7417 * xsettings.c (syms_of_xsettings):
7418 * xterm.c (syms_of_xterm): Use DEFSYM.
7420 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7422 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
7424 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7426 Integer and buffer overflow fixes (Bug#8873).
7428 * print.c (printchar, strout): Check for string overflow.
7429 (PRINTPREPARE, printchar, strout):
7430 Don't set size unless allocation succeeds.
7432 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7433 for sizes. Check for string overflow more accurately.
7434 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7436 * macros.c: Integer and buffer overflow fixes.
7437 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7438 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7439 Use ptrdiff_t, not int, for sizes.
7440 Don't increment bufsize until after realloc succeeds.
7441 Check for size-calculation overflow.
7442 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7444 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7446 * lread.c: Integer overflow fixes.
7447 (read_integer): Radix is now EMACS_INT, not int,
7448 to improve quality of diagnostics for out-of-range radices.
7449 Calculate buffer size correctly for out-of-range radices.
7450 (read1): Check for integer overflow in radices, and in
7451 read-circle numbers.
7452 (read_escape): Avoid int overflow.
7453 (Fload, openp, read_buffer_size, read1)
7454 (substitute_object_recurse, read_vector, read_list, map_obarray):
7455 Use ptrdiff_t, not int, for sizes.
7456 (read1): Use EMACS_INT, not int, for sizes.
7457 Check for size overflow.
7459 * image.c (cache_image): Check for size arithmetic overflow.
7461 * lread.c: Integer overflow issues.
7462 (saved_doc_string_size, saved_doc_string_length)
7463 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7464 Now ptrdiff_t, not int.
7465 (read1): Don't assume doc string length fits in int. Check for
7466 out-of-range doc string lengths.
7467 (read_list): Don't assume file position fits in int.
7468 (read_escape): Check for hex character overflow.
7470 2011-06-22 Leo Liu <sdl.web@gmail.com>
7472 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7473 Move to minibuffer.el.
7475 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7477 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
7478 The following patches are for when GLYPH_DEBUG && !XASSERT.
7479 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7480 * dispnew.c (flush_stdout):
7481 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7482 Mark as externally visible.
7483 * dispnew.c (check_window_matrix_pointers): Now static.
7484 * dispnew.c (window_to_frame_vpos):
7485 * xfns.c (unwind_create_frame):
7486 * xterm.c (x_check_font): Remove unused local.
7487 * scroll.c (CHECK_BOUNDS):
7488 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7489 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7490 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7491 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7492 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7494 (debug_method_add): Use va_list and vsprintf rather than relying
7495 on undefined behavior with wrong number of arguments.
7496 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7497 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7498 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7499 since we're not interested in debugging glyphs with old libraries.
7500 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7501 GCC 4.6.0's static checking.
7503 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7505 Integer overflow and signedness fixes (Bug#8873).
7506 A few related buffer overrun fixes, too.
7508 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7510 * dispextern.h (struct face.stipple):
7511 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7512 (x_bitmap_mask, x_allocate_bitmap_record)
7513 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7514 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7515 (x_create_bitmap_from_xpm_data):
7516 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7517 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7519 * xfaces.c (load_pixmap):
7520 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7521 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7522 (.bitmaps_last, struct x_output.icon_bitmap):
7523 Use ptrdiff_t, not int, for bitmap indexes.
7524 (x_allocate_bitmap_record): Check for size overflow.
7525 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7527 Use ptrdiff_t, not int, for overlay counts.
7528 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7529 * editfns.c (overlays_around, get_pos_property):
7530 * textprop.c (get_char_property_and_overlay):
7531 * xdisp.c (next_overlay_change, note_mouse_highlight):
7532 * xfaces.c (face_at_buffer_position):
7533 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7534 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7535 (Fnext_overlay_change, Fprevious_overlay_change)
7536 (mouse_face_overlay_overlaps, Foverlays_in):
7537 Use ptrdiff_t, not int, for sizes.
7538 (overlays_at, overlays_in): Check for size-calculation overflow.
7540 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7542 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7543 (x_session_initialize): Do not assume string length fits in int.
7545 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7546 This is unlikely, but can occur if DPI is outlandish.
7548 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
7549 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7551 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7552 * xrdb.c (magic_file_p, search_magic_path):
7553 Omit last arg SUFFIX; it was always 0. All callers changed.
7554 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7556 * xfont.c (xfont_match): Avoid need for strlen.
7558 * xfns.c: Don't assume strlen fits in int.
7559 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7561 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7562 not unsigned long, as we prefer signed integers. All callers changed.
7563 Detect integer overflow in repeat count.
7564 (message_dolog): Don't assume print length fits in 39 bytes.
7565 (display_mode_element): Don't assume strlen fits in int.
7567 * termcap.c: Don't assume sizes fit in int and never overflow.
7568 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7569 (gobble_line): Check for size-calculation overflow.
7571 * minibuf.c (Fread_buffer):
7572 * lread.c (intern, intern_c_string):
7573 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7574 Don't assume string length fits in int.
7576 * keyboard.c (parse_tool_bar_item):
7577 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7579 * font.c: Don't assume string length fits in int.
7580 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7581 Use ptrdiff_t, not int.
7582 (font_intern_prop): Don't assume string length fits in int.
7583 Don't assume integer property fits in fixnum.
7584 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
7586 * filelock.c: Fix some buffer overrun and integer overflow issues.
7587 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
7588 Reformulate so as not to need the command string.
7589 Invoke gzip -cd rather than gunzip, as it's more portable.
7590 (lock_info_type, lock_file_1, lock_file):
7591 Don't assume pid_t and time_t fit in unsigned long.
7592 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7593 (current_lock_owner): Prefer signed type for sizes.
7594 Use memcpy, not strncpy, where memcpy is what is really wanted.
7595 Don't assume (via atoi) that time_t and pid_t fit in int.
7596 Check for time_t and/or pid_t out of range, e.g., via a network share.
7597 Don't alloca where an auto var works fine.
7599 * fileio.c: Fix some integer overflow issues.
7600 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7601 Don't assume string length fits in int.
7602 (directory_file_name): Don't assume string length fits in long.
7603 (make_temp_name): Don't assume pid fits in int, or that its print
7604 length is less than 20.
7606 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7608 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7610 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7612 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7613 We prefer signed integers, even for size calculations.
7615 * emacs.c: Don't assume string length fits in 'int'.
7616 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7617 (main): Don't invoke strlen when not needed.
7619 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7620 (XD_DEBUG_MESSAGE): Don't waste a byte.
7622 * callproc.c (getenv_internal_1, getenv_internal)
7624 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7626 * lread.c (invalid_syntax): Omit length argument.
7627 All uses changed. This doesn't fix a bug, but it simplifies the
7628 code away from its former Hollerith-constant appearance, and it's
7629 one less 'int' to worry about when looking at integer-overflow issues.
7630 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
7632 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7633 This didn't break anything, but it didn't help either.
7634 It's confusing to put a bogus integer in a place where the actual
7635 value does not matter.
7636 (LIST_END_P): Remove unused macro and its bogus comment.
7637 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
7639 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7640 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7642 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7643 We prefer signed types, and the value cannot exceed the EMACS_INT
7644 range anyway (because otherwise the length would not be representable).
7645 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7646 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7647 This avoids a GCC warning when WIDE_EMACS_INT.
7649 * indent.c (sane_tab_width): New function.
7650 (current_column, scan_for_column, Findent_to, position_indentation)
7651 (compute_motion): Use it. This is just for clarity.
7652 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
7654 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
7656 * lisp.h (lint_assume): New macro.
7657 * composite.c (composition_gstring_put_cache):
7658 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7660 * editfns.c, insdel.c:
7661 Omit unnecessary forward decls, to simplify future changes.
7663 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7665 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7667 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
7668 Use much-faster test for byte-length change.
7669 Don't assume string byte-length fits in 'int'.
7670 Check that character arg fits in 'int'.
7671 (mapcar1): Declare byte as byte, for clarity.
7673 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7675 * fns.c (concat): Catch string overflow earlier.
7676 Do not rely on integer wraparound.
7678 * dispextern.h (struct it.overlay_strings_charpos)
7679 (struct it.selective): Now EMACS_INT, not int.
7680 * xdisp.c (forward_to_next_line_start)
7681 (back_to_previous_visible_line_start)
7682 (reseat_at_next_visible_line_start, next_element_from_buffer):
7683 Don't arbitrarily truncate the value of 'selective' to int.
7685 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7687 * composite.c: Don't truncate sizes to 'int'.
7688 (composition_gstring_p, composition_reseat_it)
7689 (composition_adjust_point): Use EMACS_INT, not int.
7690 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7691 not EMACS_UINT, for indexes.
7693 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7695 * buffer.c: Include <verify.h>.
7696 (struct sortvec.priority, struct sortstr.priority):
7697 Now EMACS_INT, not int.
7698 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
7699 (struct sortstr.size, record_overlay_string)
7700 (struct sortstrlist.size, struct sortlist.used):
7701 Don't truncate size to int.
7702 (record_overlay_string): Check for size-calculation overflow.
7703 (init_buffer_once): Check at compile-time, not run-time.
7705 2011-06-22 Jim Meyering <meyering@redhat.com>
7707 Don't leak an XBM-image-sized buffer
7708 * image.c (xbm_load): Free the image buffer after using it.
7710 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7713 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7714 that Sun C diagnosed.
7715 * fns.c (secure_hash): Fix pointer signedness issue.
7716 * intervals.c (static_offset_intervals): New function.
7717 (offset_intervals): Use it.
7719 2011-06-21 Leo Liu <sdl.web@gmail.com>
7722 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7725 * fns.c (secure_hash): Rename from crypto_hash_function and change
7726 the first arg to accept symbols.
7727 (Fsecure_hash): New primitive.
7728 (syms_of_fns): New symbols.
7730 2011-06-20 Deniz Dogan <deniz@dogan.se>
7732 * process.c (Fset_process_buffer): Clarify return value in
7735 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
7737 * dispnew.c (add_window_display_history): Use BVAR.
7739 * xdisp.c (debug_method_add): Use BVAR.
7740 (check_window_end, dump_glyph_matrix, dump_glyph)
7741 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7743 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7746 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7747 check till after the cache is created in init_frame_faces.
7749 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7751 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7753 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7755 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7756 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7757 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7759 Improve buffer-overflow checking (Bug#8873).
7760 * fileio.c (Finsert_file_contents):
7761 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7762 Remove the old (too-loose) buffer overflow checks.
7763 They weren't needed, since make_gap checks for buffer overflow.
7764 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7765 The old code merely checked for Emacs fixnum overflow, and relied
7766 on undefined (wraparound) behavior. The new code avoids undefined
7767 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7769 * editfns.c (Finsert_char): Don't dump core with very negative counts.
7770 Tune. Don't use wider integers than needed. Don't use alloca.
7771 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
7773 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7775 * insdel.c, lisp.h (buffer_overflow): New function.
7776 (insert_from_buffer_1, replace_range, replace_range_2):
7777 * insdel.c (make_gap_larger):
7778 * editfns.c (Finsert_char):
7779 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7781 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7783 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7785 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
7787 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7788 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7790 * fileio.c: Don't assume EMACS_INT fits in off_t.
7791 (emacs_lseek): New static function.
7792 (Finsert_file_contents, Fwrite_region): Use it.
7793 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7795 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7797 * fns.c: Don't overflow int when computing a list length.
7798 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7799 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7800 truncation on 64-bit hosts. Check for QUIT every
7801 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7802 faster and is responsive enough.
7803 (Flength): Report an error instead of overflowing an integer.
7804 (Fsafe_length): Return a float if the value is not representable
7805 as a fixnum. This shouldn't happen except in contrived situations.
7806 (Fnthcdr, Fsort): Don't assume list length fits in int.
7807 (Fcopy_sequence): Don't assume vector length fits in int.
7809 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7810 (header_size, word_size): New constants.
7811 (allocate_vectorlike): Don't check size overflow here.
7812 (allocate_vector): Check it here instead, since this is the only
7813 caller of allocate_vectorlike that could cause overflow.
7814 Check that the new vector's length is representable as a fixnum.
7816 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7817 The previous code was bogus. For example, next_almost_prime (32)
7818 returned 39, which is undesirable as it is a multiple of 3; and
7819 next_almost_prime (24) returned 25, which is a multiple of 5 so
7820 why was the code bothering to check for multiples of 7?
7822 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7824 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7826 Variadic C functions now count arguments with ptrdiff_t.
7827 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7828 Back then I didn't know that the Emacs coding style prefers signed int.
7829 Also, in the meantime I found a few more instances where arguments
7830 were being counted with int, which may truncate counts on 64-bit
7831 machines, or EMACS_INT, which may be unnecessarily wide.
7832 * lisp.h (struct Lisp_Subr.function.aMANY)
7833 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7834 Arg counts are now ptrdiff_t, not size_t.
7835 All variadic functions and their callers changed accordingly.
7836 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7837 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7838 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7839 * callint.c (Fcall_interactively): Check arg count for overflow,
7840 to avoid potential buffer overrun. Use signed char, not 'int',
7841 for 'varies' array, so that we needn't bother to check its size
7842 calculation for overflow.
7843 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7844 * eval.c (apply_lambda):
7845 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7846 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7847 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7849 * callint.c (Fcall_interactively): Don't use index var as event count.
7851 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7852 * mem-limits.h (SIZE): Remove; no longer used.
7854 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
7856 Remove unnecessary casts.
7857 * xterm.c (x_term_init):
7858 * xfns.c (x_set_border_pixel):
7859 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7860 These aren't needed now that we assume ANSI C.
7862 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7863 It's more likely to cause problems (due to unsigned overflow)
7866 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7868 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7870 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7872 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7874 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7876 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7878 GLYPH_CODE_FACE returns EMACS_INT, not int.
7879 * dispextern.h (merge_faces):
7880 * xfaces.c (merge_faces):
7881 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7882 Don't assume EMACS_INT fits in int.
7884 * character.h (CHAR_VALID_P): Remove unused parameter.
7885 * fontset.c, lisp.h, xdisp.c: All uses changed.
7887 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7889 * fns.c (concat): Minor tuning based on overflow analysis.
7890 This doesn't fix any bugs. Use int to hold character, instead
7891 of constantly refetching from Emacs object. Use XFASTINT, not
7892 XINT, for value known to be a character. Don't bother comparing
7893 a single byte to 0400, as it's always less.
7895 * floatfns.c (Fexpt):
7896 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7898 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7901 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7903 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7904 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7905 incorrectly succeed when S was a string, because 4294967386 was
7906 truncated before it was used.
7908 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7909 Otherwise, an out-of-range integer could cause undefined behavior
7912 * composite.c: Use int, not EMACS_INT, for characters.
7913 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7914 EMACS_INT, for values that are known to be in character range.
7915 This doesn't fix any bugs but is the usual style inside Emacs and
7916 may generate better code on 32-bit machines.
7918 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7919 This is for reasons similar to the recent CHAR_STRING fix.
7920 * charset.c (Fencode_char): Check that character arg is actually
7921 a character. Pass an int to ENCODE_CHAR.
7922 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7923 wider than 'int', as a compile-time check to prevent future regressions
7926 * character.c (char_string): Remove unnecessary casts.
7928 Make sure a 64-bit char is never passed to CHAR_STRING.
7929 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7930 by silently ignoring the top 32 bits, allowing some values
7931 that were far too large to be valid characters.
7932 * character.h: Include <verify.h>.
7933 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7934 arguments are no wider than unsigned, as a compile-time check
7935 to prevent future regressions in this area.
7937 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
7938 (Fsubst_char_in_region):
7940 * xdisp.c (decode_mode_spec_coding):
7941 Adjust to CHAR_STRING's new requirement.
7942 * editfns.c (Finsert_char, Fsubst_char_in_region):
7943 * fns.c (concat): Check that character args are actually
7944 characters. Without this test, these functions did the wrong
7945 thing with wildly out-of-range values on 64-bit hosts.
7947 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7948 These casts should not be needed on 32-bit hosts, either.
7949 * keyboard.c (read_char):
7950 * lread.c (Fload): Remove casts to unsigned.
7952 * lisp.h (UNSIGNED_CMP): New macro.
7953 This fixes comparison bugs on 64-bit hosts.
7954 (ASCII_CHAR_P): Use it.
7955 * casefiddle.c (casify_object):
7956 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
7957 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7958 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7959 * dispextern.h (FACE_FROM_ID):
7960 * keyboard.c (read_char): Use UNSIGNED_CMP.
7962 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7963 not to EMACS_INT, to avoid GCC warning.
7965 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7967 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7968 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7969 isn't needed on 32-bit machines.
7971 * buffer.c (Fgenerate_new_buffer_name):
7972 Use EMACS_INT for count, not int.
7973 (advance_to_char_boundary): Return EMACS_INT, not int.
7975 * data.c (Qcompiled_function): Now static.
7977 * window.c (window_body_lines): Now static.
7979 * image.c (gif_load): Rename local to avoid shadowing.
7981 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7982 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7983 * alloc.c (make_save_value): Integer argument is now of type
7985 (mark_object): Use ptrdiff_t, not int.
7986 * lisp.h (pD): New macro.
7987 * print.c (print_object): Use it.
7989 * alloc.c: Use EMACS_INT, not int, to count objects.
7990 (total_conses, total_markers, total_symbols, total_vector_size)
7991 (total_free_conses, total_free_markers, total_free_symbols)
7992 (total_free_floats, total_floats, total_free_intervals)
7993 (total_intervals, total_strings, total_free_strings):
7994 Now EMACS_INT, not int. All uses changed.
7995 (Fgarbage_collect): Compute overall total using a double, so that
7996 integer overflow is less likely to be a problem. Check for overflow
7997 when converting back to an integer.
7998 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7999 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8000 These were 'int' variables that could overflow on 64-bit hosts;
8001 they were never used, so remove them instead of repairing them.
8002 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
8003 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8004 Previously, this ceilinged at INT_MAX, but that doesn't work on
8006 (allocate_pseudovector): Don't use EMACS_INT when int would do.
8008 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
8009 (allocate_vectorlike): Check for ptrdiff_t overflow.
8010 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8011 when a (possibly-narrower) signed value would do just as well.
8012 We prefer using signed arithmetic, to avoid comparison confusion.
8014 * alloc.c: Catch some string size overflows that we were missing.
8015 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8016 for convenience in STRING_BYTES_MAX.
8017 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8018 The definition here is exact; the one in lisp.h was approximate.
8019 (allocate_string_data): Check for string overflow. This catches
8020 some instances we weren't catching before. Also, it catches
8021 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8022 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8023 and ptrdiff_t and EMACS_INT are both 64 bits.
8025 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8026 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
8027 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
8029 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8031 * alloc.c (Fmake_string): Check for out-of-range init.
8033 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8035 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8037 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8039 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8040 xg_get_default_scrollbar_width.
8042 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8043 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8044 (style_changed_cb): Call update_theme_scrollbar_width and call
8045 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8046 all frames (Bug#8505).
8047 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8048 Call gtk_window_set_resizable if HAVE_GTK3.
8049 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8050 and height if HAVE_GTK3 (Bug#8505).
8051 (scroll_bar_width_for_theme): New variable.
8052 (update_theme_scrollbar_width): New function.
8053 (xg_get_default_scrollbar_width): Move code to
8054 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8055 (xg_initialize): Call update_theme_scrollbar_width.
8057 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8059 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8061 2011-06-12 Martin Rudalics <rudalics@gmx.at>
8063 * frame.c (make_frame): Call other_buffer_safely instead of
8066 * window.c (temp_output_buffer_show): Call display_buffer with
8067 second argument Vtemp_buffer_show_specifiers and reset latter
8068 immediately after the call.
8069 (Vtemp_buffer_show_specifiers): New variable.
8070 (auto_window_vscroll_p, next_screen_context_lines)
8071 (Vscroll_preserve_screen_position): Remove leading asterisks from
8074 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
8076 Fix minor problems found by GCC 4.6.0 static checking.
8077 * buffer.c (Qclone_number): Remove for now, as it's unused.
8078 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8079 (record_buffer): Remove unused local.
8080 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8081 (set_frame_buffer_list): Remove; unused.
8082 * frame.h (other_visible_frames): Remove decl.
8083 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8084 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8085 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8087 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8088 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8089 Define only if HAVE_GPM.
8090 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8091 (update_hints_inhibit): Remove; never set. All uses removed.
8092 * widgetprv.h (emacsFrameClassRec): Remove decl.
8093 * window.c (delete_deletable_window): Now returns void, since it
8094 wasn't returning anything.
8095 (compare_window_configurations): Remove unused locals.
8096 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8097 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
8098 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8099 the same widths as pointers. This follows up on the 2011-05-06 patch.
8100 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8101 * xterm.h: Likewise.
8102 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8104 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
8106 * makefile.w32-in: Update dependencies.
8107 (LISP_H): Add lib/intprops.h.
8109 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8111 * image.c (gif_load): Add animation frame delay to the metadata.
8112 (syms_of_image): Use DEFSYM. New symbol `delay'.
8114 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8116 * window.c (delete_deletable_window): Re-add.
8117 (Fset_window_configuration): Rewrite to handle dead buffers and
8118 consequently deletable windows.
8119 (window_tree, Fwindow_tree): Remove. Supply functionality in
8121 (compare_window_configurations): Simplify code.
8123 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8125 * image.c (imagemagick_load_image): Fix type mismatch.
8126 (Fimagemagick_types): Likewise.
8128 * window.h (replace_buffer_in_windows): Declare.
8130 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8132 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8133 Qclone_number. Remove external declaration of Qdelete_window.
8134 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8136 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8137 Run Qbuffer_list_update_hook if allowed.
8138 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8139 buffer list implementation.
8140 (other_buffer_safely): New function.
8141 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8142 calls to replace_buffer_in_windows and
8143 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8145 (record_buffer): Inhibit quitting and rewrite using quittable
8146 functions. Run Qbuffer_list_update_hook if allowed.
8147 (Frecord_buffer, Funrecord_buffer): New functions.
8148 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8149 Move switch-to-buffer to window.el.
8150 (bury-buffer): Move to window.el.
8151 (Vbuffer_list_update_hook): New variable.
8153 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8156 * window.h (resize_frame_windows): Move up in code.
8157 (Fwindow_frame): Remove EXFUN.
8158 (replace_buffer_in_all_windows): Remove prototype.
8159 (replace_buffer_in_windows_safely): Add prototype.
8161 * window.c: Declare Qdelete_window static again. Move down
8162 declaration of select_count.
8163 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8164 (Fother_window): Move to window.el.
8165 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8166 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8167 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8169 (replace_buffer_in_windows): Implement by calling
8170 Qreplace_buffer_in_windows.
8171 (replace_buffer_in_all_windows): Remove with some functionality
8172 moved into replace_buffer_in_windows_safely.
8173 (replace_buffer_in_windows_safely): New function.
8174 (select_window_norecord, select_frame_norecord): Move in front
8175 of run_window_configuration_change_hook. Remove now obsolete
8177 (Fset_window_buffer): Rewrite doc-string.
8178 Call Qrecord_window_buffer.
8179 (keys_of_window): Move binding for other-window to window.el.
8181 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8183 * dispextern.h (struct image): Replace data member, whose int_val
8184 and ptr_val fields were not used by anything, with a single
8187 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8188 (gif_clear_image, gif_load, imagemagick_load_image)
8189 (gs_clear_image, gs_load): Callers changed.
8191 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8193 * buffer.h: Include <time.h>, for time_t.
8194 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8196 Fix minor problems found by static checking.
8198 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8200 Make identifiers static if they are not used in other modules.
8201 * data.c (Qcompiled_function, Qframe, Qvector):
8202 * image.c (QimageMagick, Qsvg):
8203 * minibuf.c (Qmetadata):
8204 * window.c (resize_window_check, resize_root_window): Now static.
8205 * window.h (resize_window_check, resize_root_window): Remove decls.
8207 * window.c (window_deletion_count, delete_deletable_window):
8209 (window_body_lines): Now static.
8210 (Fdelete_other_windows_internal): Mark vars as initialized.
8211 Make sure 'resize_failed' is initialized.
8212 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8213 (resize_window_apply): Remove unused local.
8214 * window.h (delete_deletable_window): Remove decl.
8216 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
8217 (imagemagick_load_image): Fix pointer signedness problem by changing
8218 last arg from unsigned char * to char *. All uses changed.
8219 Also, fix a local for similar reasons.
8220 Remove unused locals. Remove locals to avoid shadowing.
8221 (fn_rsvg_handle_free): Remove; unused.
8222 (svg_load, svg_load_image): Fix pointer signedness problem.
8223 (imagemagick_load_image): Don't use garbage pointer image_wand.
8225 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8227 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
8229 * image.c (gif_load): Fix omitted cast error introduced by
8232 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8234 * window.h (resize_proportionally, orig_total_lines)
8235 (orig_top_line): Remove from window structure.
8236 (set_window_height, set_window_width, change_window_heights)
8237 (Fdelete_window): Remove prototypes.
8238 (resize_frame_windows): Remove duplicate declaration.
8240 2011-06-10 Eli Zaretskii <eliz@gnu.org>
8242 * window.h (resize_frame_windows, resize_window_check)
8243 (delete_deletable_window, resize_root_window)
8244 (resize_frame_windows): Declare prototypes.
8246 * window.c (resize_window_apply): Make definition be "static" to
8247 match the prototype.
8249 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8251 * window.c: Remove declarations of Qwindow_size_fixed,
8252 window_min_size_1, window_min_size_2, window_min_size,
8253 size_window, window_fixed_size_p, enlarge_window, delete_window.
8254 Remove static from declaration of Qdelete_window, it's
8255 temporarily needed by Fbury_buffer.
8256 (replace_window): Don't assign orig_top_line and
8258 (Fdelete_window, delete_window): Remove. Window deletion is
8259 handled by window.el.
8260 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8261 Replace Fdelete_window calls with calls to Qdelete_window.
8262 (Fdelete_other_windows): Remove. Deleting other windows is
8263 handled by window.el.
8264 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8265 handled in window.el.
8266 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8267 Window minimum sizes are handled in window.el.
8268 (shrink_windows, size_window, set_window_height)
8269 (set_window_width, change_window_heights, window_height)
8270 (window_width, CURBEG, CURSIZE, enlarge_window)
8271 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8272 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8273 handled in window.el.
8274 (make_dummy_parent): Rename to make_parent_window and give it a
8275 second argument horflag.
8276 (make_window): Don't set resize_proportionally any more.
8277 (Fsplit_window): Remove. Windows are split in window.el.
8278 (save_restore_action, save_restore_orig_size)
8279 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8280 Resize mini windows in window.el.
8281 (grow_mini_window, shrink_mini_window): Implement by calling
8282 Qresize_root_window_vertically, resize_window_check and
8283 resize_window_apply.
8284 (saved_window, Fset_window_configuration, save_window_save):
8285 Do not handle orig_top_line, orig_total_lines, and
8286 resize_proportionally.
8287 (window_min_height, window_min_width): Move to window.el.
8288 (keys_of_window): Move bindings for delete-other-windows,
8289 split-window, delete-window and enlarge-window to window.el.
8291 * buffer.c: Temporarily extern Qdelete_window.
8292 (Fbury_buffer): Temporarily call Qdelete_window instead of
8293 Fdelete_window (Fbury_buffer will move to window.el soon).
8295 * frame.c (set_menu_bar_lines_1): Remove code handling
8296 orig_top_line and orig_total_lines.
8298 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8299 set_window_height but set heights directly.
8300 (change_frame_size_1): Use resize_frame_windows.
8302 * xdisp.c (init_xdisp): Don't use set_window_height but set
8305 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8306 Use resize_frame_windows instead of change_window_heights and run
8307 run_window_configuration_change_hook.
8309 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8310 instead of change_window_heights and run
8311 run_window_configuration_change_hook.
8313 2011-06-09 Martin Rudalics <rudalics@gmx.at>
8315 * window.c (replace_window): Rename second argument REPLACEMENT to
8316 NEW. New third argument SETFLAG. Rewrite.
8317 (delete_window, make_dummy_parent): Call replace_window with
8319 (window_list_1): Move down in code.
8320 (run_window_configuration_change_hook): Move set_buffer part
8321 before select_frame_norecord part in order to unwind correctly.
8322 Rename count1 to count.
8323 (recombine_windows, delete_deletable_window, resize_root_window)
8324 (Fdelete_other_windows_internal)
8325 (Frun_window_configuration_change_hook, make_parent_window)
8326 (resize_window_check, resize_window_apply, Fresize_window_apply)
8327 (resize_frame_windows, Fsplit_window_internal)
8328 (Fdelete_window_internal, Fresize_mini_window_internal):
8330 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8332 2011-06-08 Martin Rudalics <rudalics@gmx.at>
8334 * window.h (window): Add some new members to window structure -
8335 normal_lines, normal_cols, new_total, new_normal, clone_number,
8336 splits, nest, prev_buffers, next_buffers.
8337 (WINDOW_TOTAL_SIZE): Move here from window.c.
8338 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
8340 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8342 (make_dummy_parent): Set new members of windows structure.
8343 (make_window): Move down in code. Handle new members of window
8345 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8346 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8347 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8348 (Fset_window_prev_buffers, Fwindow_next_buffers)
8349 (Fset_window_next_buffers, Fset_window_clone_number):
8351 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8352 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8354 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8355 Argument WINDOW can be now internal window too.
8356 (Fwindow_use_time): Move up in code.
8357 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8359 (Fset_window_configuration, saved_window)
8360 (Fcurrent_window_configuration, save_window_save): Handle new
8361 members of window structure.
8362 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8363 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8364 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8365 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8366 Qget_mru_window, Qresize_root_window,
8367 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8368 Qauto_buffer_name; staticpro them.
8370 2011-06-07 Martin Rudalics <rudalics@gmx.at>
8372 * window.c (Fwindow_total_size, Fwindow_left_column)
8373 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8374 (Fwindow_list_1): New functions.
8375 (window_box_text_cols): Replace with window_body_cols.
8376 (Fwindow_width, Fscroll_left, Fscroll_right):
8377 Use window_body_cols instead of window_box_text_cols.
8378 (delete_window, Fset_window_configuration):
8379 Call delete_all_subwindows with window as argument.
8380 (delete_all_subwindows): Take a window as argument and not a
8382 (window_loop): Remove handling of GET_LRU_WINDOW and
8384 (Fget_lru_window, Fget_largest_window): Move to window.el.
8386 * window.h: Extern window_body_cols instead of
8387 window_box_text_cols. delete_all_subwindows now takes a
8388 Lisp_Object as argument.
8390 * indent.c (compute_motion, Fcompute_motion):
8391 Use window_body_cols instead of window_box_text_cols.
8393 * frame.c (delete_frame): Call delete_all_subwindows with root
8396 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8398 * fns.c (Fputhash): Document return value.
8400 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
8402 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8404 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8406 Cons<->int and similar integer overflow fixes (Bug#8794).
8408 Check for overflow when converting integer to cons and back.
8409 * charset.c (Fdefine_charset_internal, Fdecode_char):
8410 Use cons_to_unsigned to catch overflow.
8411 (Fencode_char): Use INTEGER_TO_CONS.
8412 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8413 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8414 * data.c (long_to_cons, cons_to_long): Remove.
8415 (cons_to_unsigned, cons_to_signed): New functions.
8416 These signal an error for invalid or out-of-range values.
8417 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8418 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8419 * font.c (Ffont_variation_glyphs):
8420 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8421 * lisp.h: Include <intprops.h>.
8422 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8423 (cons_to_signed, cons_to_unsigned): New decls.
8424 (long_to_cons, cons_to_long): Remove decls.
8425 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8426 (Fprimitive_undo): Use CONS_TO_INTEGER.
8427 * xfns.c (Fx_window_property): Likewise.
8428 * xselect.c: Include <limits.h>.
8429 (x_own_selection, selection_data_to_lisp_data):
8430 Use INTEGER_TO_CONS.
8431 (x_handle_selection_request, x_handle_selection_clear)
8432 (x_get_foreign_selection, Fx_disown_selection_internal)
8433 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8434 (lisp_data_to_selection_data): Use cons_to_unsigned.
8435 (x_fill_property_data): Use cons_to_signed.
8436 Report values out of range.
8438 Check for buffer and string overflow more precisely.
8439 * buffer.h (BUF_BYTES_MAX): New macro.
8440 * lisp.h (STRING_BYTES_MAX): New macro.
8441 * alloc.c (Fmake_string):
8442 * character.c (string_escape_byte8):
8443 * coding.c (coding_alloc_by_realloc):
8444 * doprnt.c (doprnt):
8445 * editfns.c (Fformat):
8447 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8448 since they may not be the same number.
8449 * editfns.c (Finsert_char):
8450 * fileio.c (Finsert_file_contents):
8451 Likewise for BUF_BYTES_MAX.
8453 * image.c: Use ptrdiff_t, not int, for sizes.
8454 (slurp_file): Switch from int to ptrdiff_t.
8456 (slurp_file): Check that file size fits in both size_t (for
8457 malloc) and ptrdiff_t (for sanity and safety).
8459 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8460 if b->modtime has its maximal value.
8462 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8464 Don't assume time_t can fit into int.
8465 * buffer.h (struct buffer.modtime): Now time_t, not int.
8466 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8467 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8469 Minor fixes for signed vs unsigned integers.
8470 * character.h (MAYBE_UNIFY_CHAR):
8471 * charset.c (maybe_unify_char):
8472 * keyboard.c (read_char, reorder_modifiers):
8473 XINT -> XFASTINT, since the integer must be nonnegative.
8474 * ftfont.c (ftfont_spec_pattern):
8475 * keymap.c (access_keymap, silly_event_symbol_error):
8476 XUINT -> XFASTINT, since the integer must be nonnegative.
8477 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8478 since it makes no difference and we prefer signed.
8479 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8480 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8483 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8485 * window.h (Fwindow_frame): Declare.
8487 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8489 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8490 (SPARE_MEMORY): Always define.
8491 (LARGE_REQUEST): Remove.
8492 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8494 2011-06-06 Martin Rudalics <rudalics@gmx.at>
8496 * lisp.h: Move EXFUNS for Fframe_root_window,
8497 Fframe_first_window and Fset_frame_selected_window to window.h.
8499 * window.h: Move EXFUNS for Fframe_root_window,
8500 Fframe_first_window and Fset_frame_selected_window here from
8503 * frame.c (Fwindow_frame, Fframe_first_window)
8504 (Fframe_root_window, Fframe_selected_window)
8505 (Fset_frame_selected_window): Move to window.c.
8506 (Factive_minibuffer_window): Move to minibuf.c.
8507 (Fother_visible_frames_p): New function.
8509 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8511 * window.c (decode_window, decode_any_window): Move up in code.
8512 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8513 (inhibit_frame_unsplittable): Remove unused variable.
8514 (Fwindow_buffer): Move up and rewrite doc-string.
8515 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8516 (Fwindow_prev): New functions.
8517 (Fwindow_frame): Move here from frame.c. Accept any window as
8519 (Fframe_root_window, Fframe_first_window)
8520 (Fframe_selected_window): Move here from frame.c. Accept frame
8521 or arbitrary window as argument. Update doc-strings.
8522 (Fminibuffer_window): Move up in code.
8523 (Fwindow_minibuffer_p): Move up in code and simplify.
8524 (Fset_frame_selected_window): Move here from frame.c.
8526 (Fselected_window, select_window, Fselect_window): Move up in
8527 code. Minor doc-string fixes.
8529 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8531 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8532 Do not assume that spare memory exists; that assumption is valid
8533 only if SYSTEM_MALLOC.
8534 (LARGE_REQUEST): New macro, so that the issue of large requests
8535 is separated from the issue of spare memory.
8537 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8539 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8542 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8544 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8547 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8549 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8551 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8553 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8554 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8556 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
8558 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8560 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
8562 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8563 (x_clipboard_manager_save): Add return value.
8564 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8566 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8567 Obey Vx_select_enable_clipboard_manager. Catch errors in
8568 x_clipboard_manager_save (Bug#8779).
8569 (Vx_select_enable_clipboard_manager): New variable.
8570 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
8572 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8574 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8576 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8578 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8579 in the current matrix if keep_current_p is non-zero.
8581 2011-06-04 Eli Zaretskii <eliz@gnu.org>
8583 * bidi.c (bidi_level_of_next_char): Fix last change.
8585 2011-06-03 Eli Zaretskii <eliz@gnu.org>
8587 Support bidi reordering of text covered by display properties.
8589 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8590 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8591 (bidi_cache_search, bidi_cache_iterator_state)
8592 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
8593 (bidi_level_of_next_char, bidi_move_to_visually_next):
8594 Support character positions inside a run of characters covered by a
8596 (bidi_paragraph_init, bidi_resolve_explicit_1)
8597 (bidi_level_of_next_char): Call bidi_fetch_char and
8598 bidi_fetch_char_advance instead of FETCH_CHAR and
8600 (bidi_init_it): Initialize new members.
8601 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8603 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8604 instead of using explicit *_CHAR codes.
8605 (bidi_resolve_explicit, bidi_resolve_weak):
8606 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
8607 bidirectional text is supported only in multibyte buffers.
8608 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8609 it to initialize the frame_window_p member of struct bidi_it.
8610 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8611 (bidi_resolve_explicit, bidi_resolve_weak)
8612 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8613 bidi_it->nchars is non-positive.
8614 (bidi_level_of_next_char): Don't try to lookup the cache for the
8615 next/previous character if nothing is cached there yet, or if we
8616 were just reseat()'ed to a new position.
8618 * xdisp.c (set_cursor_from_row): Set start and stop points
8619 according to the row's direction when priming the loop that looks
8620 for the glyph on which to display cursor.
8621 (single_display_spec_intangible_p): Function deleted.
8622 (display_prop_intangible_p): Reimplement to call
8623 handle_display_spec instead of single_display_spec_intangible_p.
8624 Accept 3 additional arguments needed by handle_display_spec.
8625 This fixes incorrect cursor motion across display property with complex
8626 values: lists, `(when COND...)' forms, etc.
8627 (single_display_spec_string_p): Support property values that are
8628 lists with the argument STRING its top-level element.
8629 (display_prop_string_p): Fix the condition for processing a
8630 property that is a list to be consistent with handle_display_spec.
8631 (handle_display_spec): New function, refactored from the
8632 last portion of handle_display_prop.
8633 (compute_display_string_pos): Accept additional argument
8634 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8635 value of a `display' property is a "replacing spec".
8636 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8637 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8638 the display property, but just return a value indicating whether
8639 the display property will replace the characters it covers.
8640 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8641 frame_window_p members of struct bidi_it.
8642 (compute_display_string_pos, compute_display_string_end):
8644 (push_it): Accept second argument POSITION, where pop_it should
8645 jump to continue iteration.
8646 (reseat_1): Initialize bidi_it.disp_pos.
8648 * keyboard.c (adjust_point_for_property): Adjust the call to
8649 display_prop_intangible_p to its new signature.
8651 * dispextern.h (struct bidi_it): New member frame_window_p.
8652 (bidi_init_it): Update prototypes.
8653 (display_prop_intangible_p): Update prototype.
8654 (compute_display_string_pos, compute_display_string_end):
8656 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8659 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
8661 Malloc failure behavior now depends on size of allocation.
8662 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8663 * lisp.h: Change signatures accordingly.
8664 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8665 All callers changed. (Bug#8762)
8667 * gnutls.c: Use Emacs's memory allocators.
8668 Without this change, the gnutls library would invoke malloc etc.
8669 directly, which causes problems on non-SYNC_INPUT hosts, and which
8670 runs afoul of improving memory_full behavior. (Bug#8761)
8671 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8672 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8673 xfree instead of the default malloc, realloc, free.
8674 (Fgnutls_boot): No need to check for memory allocation failure,
8675 since xmalloc does that for us.
8677 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
8678 * category.c (hash_get_category_set):
8679 * ccl.c (ccl_driver):
8680 * charset.c (Fdefine_charset_internal):
8681 * charset.h (struct charset.hash_index):
8682 * composite.c (get_composition_id, gstring_lookup_cache)
8683 (composition_gstring_put_cache):
8684 * composite.h (struct composition.hash_index):
8685 * dispextern.h (struct image.hash):
8686 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8687 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8688 (hashfn_equal, hashfn_user_defined, make_hash_table)
8689 (maybe_resize_hash_table, hash_lookup, hash_put)
8690 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8691 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8692 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8693 * image.c (make_image, search_image_cache, lookup_image)
8694 (xpm_put_color_table_h):
8695 * lisp.h (struct Lisp_Hash_Table):
8696 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
8697 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
8698 for hashes and hash indexes, instead of 'unsigned' and 'int'.
8699 * alloc.c (allocate_vectorlike):
8700 Check for overflow in vector size calculations.
8701 * ccl.c (ccl_driver):
8702 Check for overflow when converting EMACS_INT to int.
8703 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8704 need to be updated by these changes.
8705 * fns.c (make_hash_table, maybe_resize_hash_table):
8706 Check for integer overflow with large hash tables.
8707 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8708 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8709 (SXHASH_REDUCE): New macro.
8710 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8711 Use it instead of discarding useful hash info with large hash values.
8712 (sxhash_float): New function.
8713 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8714 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
8715 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8716 Rewrite to use FIXNUM_BITS, as this simplifies things.
8717 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8718 Adjust signatures to match updated version of code.
8719 (consing_since_gc): Now EMACS_INT, since a single hash table can
8720 use more than INT_MAX bytes.
8722 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8724 Make it possible to build with GCC-4.6+ -O2 -flto.
8726 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8728 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8730 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8731 Call minibuffer-inactive-mode.
8733 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
8735 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8736 Update dependencies.
8738 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8740 * data.c (init_data): Remove code for UTS, this system is not
8743 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8745 Don't force ./temacs to start in terminal mode.
8747 * frame.c (make_initial_frame): Initialize faces in all cases, not
8748 only when CANNOT_DUMP is defined.
8749 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8751 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8753 * dispnew.c (add_window_display_history): Use const for the string
8754 pointer. Remove declaration, not needed.
8756 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8758 Use 'inline', not 'INLINE'.
8759 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
8760 * alloc.c, fontset.c (INLINE): Remove.
8761 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8762 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8763 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8764 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8765 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8767 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8769 Make it possible to run ./temacs.
8771 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8772 syms_of_callproc does the same thing. Remove test for
8773 "initialized", do it in the caller.
8774 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8776 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8778 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8779 (read_minibuf): Use get_minibuffer.
8780 (syms_of_minibuf): Use DEFSYM.
8781 (Qmetadata): New var.
8782 * data.c (Qbuffer): Don't make it static.
8783 (syms_of_data): Use DEFSYM.
8785 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8787 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8788 (CCL_CODE_MIN): New macro.
8790 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8792 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8794 * eval.c (Qdebug): Now static.
8795 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8796 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8797 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8799 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8801 * image.c: Various fixes to ImageMagick code comments.
8802 (Fimagemagick_types): Doc fix.
8804 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8806 Minor fixes prompted by GCC 4.6.0 warnings.
8808 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8810 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8811 (x_clipboard_manager_save_all): Move extern decl to ...
8812 * xterm.h: ... here, so that it can be checked for consistency.
8814 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8816 * xselect.c (x_clipboard_manager_save_frame)
8817 (x_clipboard_manager_save_all): New functions.
8818 (Fx_clipboard_manager_save): Lisp function deleted.
8820 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8821 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8823 * xterm.h: Update prototype.
8825 2011-05-28 William Xu <william.xwl@gmail.com>
8827 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8830 2011-05-28 Jim Meyering <meyering@redhat.com>
8832 Avoid a sign-extension bug in crypto_hash_function.
8833 * fns.c (to_uchar): Define.
8834 (crypto_hash_function): Use it to convert some newly-signed
8835 variables to unsigned, to avoid sign-extension bugs. For example,
8836 without this change, (md5 "truc") would evaluate to
8837 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8838 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
8839 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
8841 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8843 Integer overflow fixes.
8845 * dbusbind.c: Serial number integer overflow fixes.
8846 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
8847 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8848 to hold a serial number that is too large for a fixnum.
8849 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8850 Check for serial numbers out of range. Decode any serial number
8851 that was so large that it became a float. (Bug#8722)
8853 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8854 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8855 Use XFASTINT rather than XUINT when numbers are nonnegative.
8856 (xd_append_arg, Fdbus_method_return_internal):
8857 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8858 arguments, check that Lisp number is nonnegative, rather than
8859 silently wrapping negative numbers around. (Bug#8722)
8860 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
8863 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8865 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8867 ccl: Add integer overflow checks.
8868 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8869 (IN_INT_RANGE): New macros.
8870 (ccl_driver): Use them to check for integer overflow when
8871 decoding a CCL program. Many of the new checks are whether XINT (x)
8872 fits in int; it doesn't always, on 64-bit hosts. The new version
8873 doesn't catch all possible integer overflows, but it's an
8874 improvement. (Bug#8719)
8876 * alloc.c (make_event_array): Use XINT, not XUINT.
8877 There's no need for unsigned here.
8879 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8880 This follows up to the 2011-05-06 change that substituted uintptr_t
8881 for EMACS_INT. This case wasn't caught back then.
8883 Rework Fformat to avoid integer overflow issues.
8884 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8885 now (part of C89). Include <verify.h>.
8886 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8887 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8888 (Fformat): Avoid the prepass trying to compute sizes; it was only
8889 approximate and thus did not catch overflow reliably. Instead, walk
8890 through the format just once, formatting and computing sizes as we go,
8891 checking for integer overflow at every step, and allocating a larger
8892 buffer as needed. Keep track separately whether the format is
8893 multibyte. Keep only the most-recently calculated precision, rather
8894 than them all. Record whether each argument has been converted to
8895 string. Use EMACS_INT, not int, for byte and char and arg counts.
8896 Support field widths and precisions larger than INT_MAX. Avoid
8897 sprintf's undefined behavior with conversion specifications such as %#d
8898 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8899 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8900 formatting out-of-range floating point numbers with int
8903 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8905 * data.c: Avoid integer truncation in expressions involving floats.
8906 * data.c: Include <intprops.h>.
8907 (arith_driver): When there's an integer overflow in an expression
8908 involving floating point, convert the integers to floating point
8909 so that the resulting value does not suffer from catastrophic
8910 integer truncation. For example, on a 64-bit host (* 4
8911 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8912 Do not rely on undefined behavior after integer overflow.
8914 merge count_size_as_multibyte, parse_str_to_multibyte
8915 * character.c, character.h (count_size_as_multibyte):
8916 Rename from parse_str_to_multibyte; all uses changed.
8917 Check for integer overflow.
8918 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8919 since it's now a duplicate of the other. This is more of
8920 a character than a buffer op, so better that it's in character.c.
8921 * fns.c, print.c: Adjust to above changes.
8923 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8925 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8927 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8929 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8930 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8931 (x_clipboard_manager_save): Now static.
8932 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8934 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8935 (crypto_hash_function): Now static.
8936 Fix pointer signedness problems. Avoid unnecessary initializations.
8938 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
8940 * termhooks.h (Vselection_alist): Make it terminal-local.
8942 * terminal.c (create_terminal): Initialize it.
8944 * xselect.c: Support for clipboard managers.
8945 (Vselection_alist): Move to termhooks.h as terminal-local var.
8946 (LOCAL_SELECTION): New macro.
8947 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8948 (symbol_to_x_atom): Remove gratuitous arg.
8949 (x_handle_selection_request, lisp_data_to_selection_data)
8950 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
8951 (x_own_selection, x_get_local_selection, x_convert_selection):
8952 New arg, specifying work frame. Use terminal-local Vselection_alist.
8953 (some_frame_on_display): Delete unused function.
8954 (Fx_own_selection_internal, Fx_get_selection_internal)
8955 (Fx_disown_selection_internal, Fx_selection_owner_p)
8956 (Fx_selection_exists_p): New optional frame arg.
8957 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8958 (x_handle_selection_clear): Don't treat other terminals with the
8959 same keyboard specially. Use the terminal-local Vselection_alist.
8960 (x_clear_frame_selections): Use Frun_hook_with_args.
8962 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8964 * xterm.h: Add support for those atoms.
8966 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
8968 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8969 (converted_selections, conversion_fail_tag): New global variables.
8970 (x_selection_request_lisp_error): Free the above.
8971 (x_get_local_selection): Remove unnecessary code.
8972 (x_reply_selection_request): Args changed; handle arbitrary array
8973 of converted selections stored in converted_selections.
8974 Separate the XChangeProperty and SelectionNotify steps.
8975 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8976 (x_convert_selection): New function.
8977 (x_handle_selection_event): Simplify.
8978 (x_get_foreign_selection): Don't ignore incoming requests while
8979 waiting for an answer; this will fail when we implement
8980 SAVE_TARGETS, and seems unnecessary anyway.
8981 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8982 (Vx_sent_selection_functions): Doc fix.
8984 2011-05-26 Leo Liu <sdl.web@gmail.com>
8986 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8988 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8990 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8992 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8993 for fringe update if it has periodic bitmap.
8994 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
8995 and fringe_bitmap_periodic_p.
8997 * fringe.c (get_fringe_bitmap_data): New function.
8998 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8999 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9000 row. Mark glyph row for fringe update if periodicity changed.
9002 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9003 for fringe update unless it has periodic bitmap.
9005 2011-05-25 Kenichi Handa <handa@m17n.org>
9007 * xdisp.c (get_next_display_element): Set correct it->face_id for
9008 a static composition.
9010 2011-05-24 Leo Liu <sdl.web@gmail.com>
9013 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9015 * fns.c (crypto_hash_function, Fsha1): New function.
9016 (Fmd5): Use crypto_hash_function.
9017 (syms_of_fns): Add Ssha1.
9019 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9021 * gnutls.c: Remove unused macros.
9022 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9023 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9024 Remove macros that are defined and never used.
9025 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9027 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9029 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9030 (Fx_get_selection_internal): Minor cleanup.
9031 (Fx_own_selection_internal): Rename arguments for consistency with
9034 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9036 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9038 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9040 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9042 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9044 * dispnew.c (scrolling_window): Don't exclude the case that the
9045 last enabled row in the desired matrix touches the bottom boundary.
9047 2011-05-21 Glenn Morris <rgm@gnu.org>
9049 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
9050 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9051 and add some more files.
9053 2011-05-20 Eli Zaretskii <eliz@gnu.org>
9055 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9056 report_file_error introduced by the change from 2011-05-07.
9058 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9060 * systime.h (Time): Define only if emacs is defined.
9061 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9062 where the include path doesn't have X11/X.h by default. See
9063 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9065 2011-05-20 Kenichi Handa <handa@m17n.org>
9067 * composite.c (find_automatic_composition): Fix previous change.
9069 2011-05-20 Glenn Morris <rgm@gnu.org>
9071 * lisp.mk: New file, split from Makefile.in.
9072 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9073 (shortlisp): Remove.
9074 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9076 2011-05-19 Glenn Morris <rgm@gnu.org>
9078 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9079 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9080 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9081 (lisp): Set the order to that of loadup.el.
9082 (shortlisp): Make it a copy of $lisp.
9083 (SOME_MACHINE_LISP): Remove.
9084 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9085 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9087 2011-05-18 Kenichi Handa <handa@m17n.org>
9089 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9090 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9091 (find_automatic_composition): Mostly rewrite for efficiency.
9093 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
9095 * makefile.w32-in: Update dependencies.
9097 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9099 * menu.c: Include limits.h (fixes the MS-Windows build broken by
9100 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
9102 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
9104 Fix some integer overflow issues, such as string length overflow.
9106 * insdel.c (count_size_as_multibyte): Check for string overflow.
9108 * character.c (lisp_string_width): Check for string overflow.
9109 Use EMACS_INT, not int, for string indexes and lengths; in
9110 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9111 the resulting string length overflows an EMACS_INT; instead,
9112 report a string overflow if no precision given. When checking for
9113 precision exhaustion, use a check that cannot possibly have
9114 integer overflow. (Bug#8675)
9115 * character.h (lisp_string_width): Adjust to new signature.
9117 * alloc.c (string_overflow): New function.
9118 (Fmake_string): Use it. This doesn't change behavior, but saves
9119 a few bytes and will simplify future changes.
9120 * character.c (string_escape_byte8): Likewise.
9121 * lisp.h (string_overflow): New decl.
9123 Fixups, following up to the user-interface timestamp change.
9124 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9125 for UI timestamps, instead of unsigned long.
9126 * msdos.c (mouse_get_pos): Likewise.
9127 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
9128 * w32gui.h (Time): Define by including "systime.h" rather than by
9129 declaring it ourselves. (Bug#8664)
9131 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9132 * image.c (clear_image_cache): Likewise.
9134 * term.c (term_mouse_position): Don't assume time_t wraparound.
9136 Be more systematic about user-interface timestamps.
9137 Before, the code sometimes used 'Time', sometimes 'unsigned long',
9138 and sometimes 'EMACS_UINT', to represent these timestamps.
9139 This change causes it to use 'Time' uniformly, as that's what X uses.
9140 This makes the code easier to follow, and makes it easier to catch
9141 integer overflow bugs such as Bug#8664.
9142 * frame.c (Fmouse_position, Fmouse_pixel_position):
9143 Use Time, not unsigned long, for user-interface timestamps.
9144 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9145 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9146 * keyboard.h (last_event_timestamp): Likewise.
9147 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9148 * menu.h (xmenu_show): Likewise.
9149 * term.c (term_mouse_position): Likewise.
9150 * termhooks.h (struct input_event.timestamp): Likewise.
9151 (struct terminal.mouse_position_hook): Likewise.
9152 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9153 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9154 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9155 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9157 * menu.h, termhooks.h: Include "systime.h", for Time.
9159 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9160 Don't assume that the difference between two unsigned long values
9161 can fit into an integer. At this point, we know button_down_time
9162 <= event->timestamp, so the difference must be nonnegative, so
9163 there's no need to cast the result if double-click-time is
9164 nonnegative, as it should be; check that it's nonnegative, just in
9165 case. This bug is triggered when events are more than 2**31 ms
9166 apart (about 25 days). (Bug#8664)
9168 * xselect.c (last_event_timestamp): Remove duplicate decl.
9169 (x_own_selection): Remove needless cast to unsigned long.
9171 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9172 that always fit in int. Use a sentinel instead of a counter, to
9173 avoid a temp and to allay GCC's concerns about possible int overflow.
9174 * frame.h (struct frame): Use int for menu_bar_items_used
9175 instead of EMACS_INT, since it always fits in int.
9177 * menu.c (grow_menu_items): Check for int overflow.
9179 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9181 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9182 Before, the code was not consistent. These values cannot exceed
9183 2**31 - 1 so there's no need to make them unsigned.
9184 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9185 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9186 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9188 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9190 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9191 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9192 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9193 presumably because the widths might not match.
9195 * window.c (size_window): Avoid needless test at loop start.
9197 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9199 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9201 2011-05-12 Drew Adams <drew.adams@oracle.com>
9203 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9205 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9207 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9208 `width' to `bar_area_x' and `bar_area_width', respectively.
9209 (x_scroll_run): Take account of fringe background extension.
9211 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9212 Rename local vars `left' and `width' to `bar_area_x' and
9213 `bar_area_width', respectively.
9214 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9215 background extension.
9217 2011-05-10 Jim Meyering <meyering@redhat.com>
9219 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9221 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
9223 * image.c (Finit_image_library): Return t for built-in image types,
9224 like pbm and xbm. (Bug#8640)
9226 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9228 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9230 2011-05-07 Eli Zaretskii <eliz@gnu.org>
9232 * w32console.c (Fset_screen_color): Doc fix.
9233 (Fget_screen_color): New function.
9234 (syms_of_ntterm): Defsubr it.
9236 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9237 unlink the temporary file if Fcall_process didn't create it in the
9239 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9240 child process will be redirected to a file specified with `:file'.
9241 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9242 cue to call_process_cleanup not to close that handle.
9244 2011-05-07 Ben Key <bkey76@gmail.com>
9246 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9247 one of two shell specific rules, either bootstrap-temacs-CMD or
9248 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9249 to the previous implementation of the bootstrap-temacs rule.
9250 The bootstrap-temacs-CMD rule is similar to the previous
9251 implementation of the bootstrap-temacs rule except that it
9252 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9255 These changes, along with some changes to nt/configure.bat,
9256 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9257 earlier fix to add support for --cflags and --ldflags options
9258 that include quotes so that it works whether make uses cmd or
9261 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
9263 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9264 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9266 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9267 a string. Handle both cases.
9268 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9269 (Fdbus_register_method): Use Qinvalid_function.
9271 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
9273 * makefile.w32-in: Update dependencies.
9274 (LISP_H): Add inttypes.h and stdin.h.
9275 (PROCESS_H): Add unistd.h.
9277 2011-05-06 Eli Zaretskii <eliz@gnu.org>
9279 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9280 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9282 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
9284 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9286 * term.c (vfatal): Remove stray call to va_end.
9287 It's not needed and the C Standard doesn't allow it here anyway.
9289 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9290 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9292 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9295 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9297 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9299 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9301 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9303 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9305 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9306 * charset.c (Fdefine_charset_internal): Don't initialize
9307 charset.code_space[15]. The value was garbage, on hosts with
9308 32-bit int (Bug#8600).
9310 * lread.c (read_integer): Be more consistent with string-to-number.
9311 Use string_to_number to do the actual conversion; this avoids
9312 rounding errors and fixes some other screwups. Without this fix,
9313 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9314 (digit_to_number): Move earlier, for benefit of read_integer.
9315 Return -1 if the digit is out of range for the base, -2 if it is
9316 not a digit in any supported base. (Bug#8602)
9318 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9320 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9321 to match comment at start of function. This also removes a
9322 GCC warning about overflow in a 32+64-bit port.
9324 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9326 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9327 Reported by Stefan Monnier in
9328 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
9329 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9330 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
9332 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9333 (EMACS_UINTPTR): Likewise, with uintptr_t.
9335 * lisp.h: Prefer 64-bit EMACS_INT if available.
9336 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9337 on 32-bit hosts that have 64-bit int, so that they can access
9339 However, temporarily disable this change unless the temporary
9340 symbol WIDE_EMACS_INT is defined.
9342 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9344 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9345 This removes an assumption that EMACS_INT and long are the same
9346 width as pointers. The assumption is true for Emacs porting targets
9347 now, but we want to make other targets possible.
9348 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9349 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9350 In the rest of the code, change types of integers that hold casted
9351 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9352 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9353 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9354 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9355 No need to cast type when ORing.
9356 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9357 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9358 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9359 assume EMACS_INT is the same width as char *.
9360 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9361 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9362 Remove no-longer-needed casts.
9363 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9364 (xg_tool_bar_help_callback, xg_make_tool_item):
9365 Use EMACS_INTPTR to hold an integer
9366 that will be cast to void *; this can avoid a GCC warning
9367 if EMACS_INT is not the same width as void *.
9368 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9369 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9370 (current_message_1, set_message_1):
9371 Use a local to convert to proper width without a cast.
9372 * xmenu.c (dialog_selection_callback): Likewise.
9374 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9375 Also, don't assume VALBITS / RAND_BITS is less than 5,
9376 and don't rely on undefined behavior when shifting a 1 left into
9378 * lisp.h (get_random): Change signature to match.
9380 * lread.c (hash_string): Use size_t, not int, for hash computation.
9381 Normally we prefer signed values; but hashing is special, because
9382 it's better to use unsigned division on hash table sizes so that
9383 the remainder is nonnegative. Also, size_t is the natural width
9384 for hashing into memory. The previous code used 'int', which doesn't
9385 retain enough info to hash well into very large tables.
9386 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9388 * dbusbind.c: Don't possibly lose pointer info when converting.
9389 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9390 Use XPNTR rather than XHASH, so that the high-order bits of
9391 the pointer aren't lost when converting through void *.
9393 * eval.c (Fautoload): Don't double-shift a pointer.
9395 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9397 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
9399 * gnutls.c (DEF_GNUTLS_FN):
9400 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9402 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9404 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9407 2011-05-05 Eli Zaretskii <eliz@gnu.org>
9409 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9410 New version that can reserve upto 2GB of heap space.
9412 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
9414 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9416 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9418 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9419 `gnutls_certificate_set_x509_key_file'.
9421 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
9423 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9424 Update dependencies.
9426 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9428 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9429 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9430 Remove unused parameter `fildes'.
9431 * process.c (read_process_output, send_process): Don't pass it.
9433 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9435 Fix previous change: the library cache is defined in w32.c.
9436 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9437 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9439 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9441 Implement dynamic loading of GnuTLS on Windows.
9443 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9444 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9445 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9448 * gnutls.c (Qgnutls_dll): Define.
9449 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9450 (gnutls_*): Declare function pointers.
9451 (init_gnutls_functions): New function to initialize function pointers.
9452 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9453 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9454 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9455 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9456 (emacs_gnutls_write, emacs_gnutls_read)
9457 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9458 (Fgnutls_available_p): New function.
9459 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9460 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9461 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9463 * image.c: Include w32.h.
9464 (Vimage_type_cache): Delete.
9465 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9466 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9467 (w32_delayed_load): Move to w32.c.
9469 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9471 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9472 (w32_delayed_load): Move from image.c. When loading a library, record
9473 its filename in the :loaded-from property of the library id.
9474 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9475 Initialize and staticpro them.
9476 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9478 * process.c: Include lisp.h before w32.h, not after.
9479 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9480 instead of gnutls_record_check_pending.
9482 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9484 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9486 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9487 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9490 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9492 * xterm.c (x_set_frame_alpha): Do not set property on anything
9493 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9495 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9497 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9499 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9501 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9502 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9503 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9504 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9505 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9506 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9507 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9508 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9509 (Qgnutls_bootprop_callbacks_verify): Make static.
9511 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9513 * callproc.c: Indentation fixup.
9515 * sysdep.c (wait_for_termination_1): Make static.
9516 (wait_for_termination, interruptible_wait_for_termination):
9517 Move after wait_for_termination_1.
9519 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9521 * sysdep.c (interruptible_wait_for_termination): New function
9522 which is like wait_for_termination, but allows keyboard
9525 * callproc.c (Fcall_process): Add (:file "file") as an option for
9527 (Fcall_process_region): Ditto.
9529 2011-04-30 Eli Zaretskii <eliz@gnu.org>
9531 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9532 rather than `XVECTOR (FOO)->size'.
9534 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9535 inttypes.h, as a gnulib replacement is used if it not available in
9538 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9540 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9541 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9542 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9544 * coding.c (coding_alloc_by_realloc): Error out if destination
9545 will grow beyond MOST_POSITIVE_FIXNUM.
9546 (decode_coding_emacs_mule): Abort if there isn't enough place in
9547 charbuf for the composition carryover bytes. Reserve an extra
9548 space for up to 2 characters produced in a loop.
9549 (decode_coding_iso_2022): Abort if there isn't enough place in
9550 charbuf for the composition carryover bytes.
9552 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9554 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9555 aborting when %lld or %lll format is passed.
9556 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9557 %llo or %llx format is passed. (Bug#8545)
9559 * window.c (window_scroll_line_based): Use a marker instead of
9560 simple variables to record original value of point. (Bug#7952)
9562 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9563 produced by %s or %c overflows available buffer space. (Bug#8545)
9565 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9567 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
9568 (SIZE_MAX): Move defn after all includes, as they might #define it.
9570 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9572 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9574 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9576 * keyboard.c (Qdelayed_warnings_hook): Define.
9577 (command_loop_1): Run `delayed-warnings-hook'
9578 if Vdelayed_warnings_list is non-nil.
9579 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9580 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9582 2011-04-28 Eli Zaretskii <eliz@gnu.org>
9584 * doprnt.c (doprnt): Don't return value smaller than the buffer
9585 size if the message was truncated. (Bug#8545).
9587 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9589 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9590 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9592 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9594 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9596 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
9598 * makefile.w32-in: Update dependencies.
9600 2011-04-27 Eli Zaretskii <eliz@gnu.org>
9602 Improve `doprnt' and its usage. (Bug#8545)
9603 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9604 `format_end'. Remove support for %l as a conversion specifier.
9605 Don't use xrealloc. Improve diagnostics when the %l size modifier
9606 is used. Update the commentary.
9608 * eval.c (verror): Simplify calculation of size_t.
9610 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9613 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9615 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9618 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9620 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9621 This makes this file independent of the recent pseudovector change.
9623 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
9625 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9627 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
9628 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
9629 Remove unused local.
9630 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
9632 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
9633 GCC 4.6.0 optimizes based on type-based alias analysis.
9634 For example, if b is of type struct buffer * and v of type struct
9635 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9636 != &v->size, and therefore "v->size = 1; b->size = 2; return
9637 v->size;" must therefore return 1. This assumption is incorrect
9638 for Emacs, since it type-puns struct Lisp_Vector * with many other
9639 types. To fix this problem, this patch adds a new type struct
9640 vectorlike_header that documents the constraints on layout of vectors
9641 and pseudovectors, and helps optimizing compilers not get fooled
9642 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9643 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
9644 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9646 (XSETPVECTYPE): Rewrite in terms of new macro.
9647 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9648 This is a bit clearer, and further avoids the possibility of
9649 undesirable aliasing.
9650 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
9651 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
9652 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9653 since Lisp_Subr is a special case (no "next" field).
9654 (ASIZE): Now uses header.size rather than size.
9655 All previous uses of XVECTOR (foo)->size replaced to use this macro,
9656 to avoid the hassle of writing XVECTOR (foo)->header.size.
9657 (struct vectorlike_header): New type.
9658 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9659 object, to help avoid aliasing.
9660 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9661 (SUBRP): Likewise, since Lisp_Subr is a special case.
9662 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9663 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9664 (struct Lisp_Hash_Table): Combine first two members into a single
9665 struct vectorlike_header member. All uses of "size" and "next" members
9666 changed to be "header.size" and "header.next".
9667 * buffer.h (struct buffer): Likewise.
9668 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9669 * frame.h (struct frame): Likewise.
9670 * process.h (struct Lisp_Process): Likewise.
9671 * termhooks.h (struct terminal): Likewise.
9672 * window.c (struct save_window_data, struct saved_window): Likewise.
9673 * window.h (struct window): Likewise.
9674 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9675 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9676 * buffer.c (init_buffer_once): Likewise.
9677 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9679 * process.c (Fformat_network_address): Use local var for size,
9682 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9684 Make the Lisp reader and string-to-float more consistent (Bug#8525)
9685 * data.c (atof): Remove decl; no longer used or needed.
9686 (digit_to_number): Move to lread.c.
9687 (Fstring_to_number): Use new string_to_number function, to be
9688 consistent with how the Lisp reader treats infinities and NaNs.
9689 Do not assume that floating-point numbers represent EMACS_INT
9690 without losing information; this is not true on most 64-bit hosts.
9691 Avoid double-rounding errors, by insisting on integers when
9692 parsing non-base-10 numbers, as the documentation specifies.
9693 * lisp.h (string_to_number): New decl, replacing ...
9694 (isfloat_string): Remove.
9695 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
9696 (read1): Do not accept +. and -. as integers; this
9697 appears to have been a coding error. Similarly, do not accept
9698 strings like +-1e0 as floating point numbers. Do not report
9699 overflow for integer overflows unless the base is not 10 which
9700 means we have no simple and reliable way to continue.
9701 Break out the floating-point parsing into a new
9702 function string_to_number, so that Fstring_to_number parses
9703 floating point numbers consistently with the Lisp reader.
9704 (digit_to_number): Move here from data.c. Make it static inline.
9705 (E_CHAR, EXP_INT): Remove, replacing with ...
9706 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9707 (string_to_number): New function, replacing isfloat_string.
9708 This function checks for valid syntax and produces the resulting
9709 Lisp float number too. Rework it so that string-to-number
9710 no longer mishandles examples like "1.0e+". Use strtoumax,
9711 so that overflow for non-base-10 numbers is reported only when
9712 there's no portable and simple way to convert to floating point.
9714 * textprop.c (set_text_properties_1): Rewrite for clarity,
9715 and to avoid GCC warning about integer overflow.
9717 * intervals.h (struct interval): Use EMACS_INT for members
9718 where EMACS_UINT might cause problems. See
9719 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9720 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9721 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9723 (offset_intervals): Tell GCC not to worry about length overflow
9724 when negating a negative length.
9726 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9727 (overrun_check_free): Likewise.
9729 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9730 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9733 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9734 (gnutls_make_error): Rename local to avoid shadowing.
9735 (gnutls_emacs_global_deinit): ifdef out; not used.
9736 (Fgnutls_boot): Use const for pointer to readonly storage.
9737 Comment out unused local. Fix pointer signedness problems.
9739 * lread.c (openp): Don't stuff size_t into an 'int'.
9740 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9741 about possible signed overflow.
9743 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9744 (GDK_KEY_g): Don't define if already defined.
9745 (xg_prepare_tooltip): Avoid pointer signedness problem.
9746 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9748 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9749 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9751 * xfns.c (Fx_window_property): Simplify a bit,
9752 to make a bit faster and to avoid GCC 4.6.0 warning.
9753 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9755 * fns.c (internal_equal): Don't assume size_t fits in int.
9757 * alloc.c (compact_small_strings): Tighten assertion a little.
9759 Replace pEd with more-general pI, and fix some printf arg casts.
9760 * lisp.h (pI): New macro, generalizing old pEd macro to other
9761 conversion specifiers. For example, use "...%"pI"d..." rather
9762 than "...%"pEd"...".
9763 (pEd): Remove. All uses replaced with similar uses of pI.
9764 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
9765 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9766 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9767 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9768 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9769 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9770 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9772 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9773 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9774 * print.c (safe_debug_print, print_object): Likewise.
9775 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9777 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9778 avoiding the 0 flag, which is not portable.
9779 * process.c (Fmake_network_process): Use pI to avoid cast.
9780 * region-cache.c (pp_cache): Likewise.
9781 * xdisp.c (decode_mode_spec): Likewise.
9782 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9783 behavior on 64-bit hosts with printf arg.
9784 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
9785 (x_stop_queuing_selection_requests): Likewise.
9786 (x_get_window_property): Don't truncate byte count to an 'int'
9789 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9790 here, since it parses constructs like leading '-' and spaces,
9791 which are not wanted; and it overflows with large numbers.
9792 Instead, simply match F[0-9]+, which is what is wanted anyway.
9794 * alloc.c: Remove unportable assumptions about struct layout.
9795 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9796 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9797 (allocate_vectorlike, make_pure_vector): Use the new macros,
9798 plus offsetof, to remove unportable assumptions about struct layout.
9799 These assumptions hold on all porting targets that I know of, but
9800 they are not guaranteed, they're easy to remove, and removing them
9801 makes further changes easier.
9803 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9804 This doesn't fix a bug but makes the code clearer.
9805 (string_overrun_cookie): Now const. Use initializers that
9806 don't formally overflow signed char, to avoid warnings.
9807 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9808 can cause Emacs to crash when string overrun checking is enabled.
9809 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9810 multiple of sizeof (EMACS_INT); it need not be, if
9811 alignof(EMACS_INT) < sizeof (EMACS_INT).
9812 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
9814 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
9816 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9818 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9820 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
9821 supposed to be handshaking. (Bug#8556)
9822 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9824 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
9826 * lisp.h (Qdebug): List symbol.
9827 * eval.c (Qdebug): Restore global linkage.
9828 * keyboard.c (debug-on-event): New variable.
9829 (handle_user_signal): Break into debugger when debug-on-event
9830 matches the current signal symbol.
9832 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9834 * alloc.c (check_sblock, check_string_bytes)
9835 (check_string_free_list): Convert to standard C.
9837 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9839 * w32.c (emacs_gnutls_push): Fix typo.
9841 2011-04-25 Eli Zaretskii <eliz@gnu.org>
9843 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9844 "cast to pointer from integer of different size".
9846 Improve doprnt and its use in verror. (Bug#8545)
9847 * doprnt.c (doprnt): Document the set of format control sequences
9848 supported by the function. Use SAFE_ALLOCA instead of always
9851 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9852 is one byte too soon. Don't use xrealloc; instead xfree and
9855 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9857 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9860 * gnutls.c: Renamed global_initialized to
9861 gnutls_global_initialized. Added internals for the
9862 :verify-hostname-error, :verify-error, and :verify-flags
9863 parameters of `gnutls-boot' and documented those parameters in the
9864 docstring. Start callback support.
9865 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9866 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9867 on error. Return error code.
9868 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9869 (emacs_gnutls_read): Likewise.
9870 (Fgnutls_boot): Return handshake error code.
9871 (emacs_gnutls_handle_error): New function.
9872 (wsaerror_to_errno): Likewise.
9874 * w32.h (emacs_gnutls_pull): Add prototype.
9875 (emacs_gnutls_push): Likewise.
9877 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9878 (emacs_gnutls_push): Likewise.
9880 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9882 * process.c (wait_reading_process_output): Check if GnuTLS
9883 buffered some data internally if no FDs are set for TLS
9886 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9887 (LIBS): Link to USER_LIBS.
9888 ($(BLD)/gnutls.$(0)): New target.
9890 2011-04-24 Eli Zaretskii <eliz@gnu.org>
9892 * xdisp.c (handle_single_display_spec): Rename the
9893 display_replaced_before_p argument into display_replaced_p, to
9894 make it consistent with the commentary. Fix typos in the
9897 * textprop.c (syms_of_textprop): Remove dead code.
9898 (copy_text_properties): Delete obsolete commentary about an
9899 interface that was deleted long ago. Fix typos in the description
9902 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9903 to changes in oldXMenu/XMenu.h from 2011-04-16.
9904 <menu_help_message, prev_menu_help_message>: Constify.
9905 (IT_menu_make_room): menu->help_text is now `const char **';
9908 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9909 to changes in oldXMenu/XMenu.h from 2011-04-16.
9910 (struct XMenu): Declare `help_text' `const char **'.
9912 * xfaces.c <Qunspecified>: Make extern again.
9914 * syntax.c: Include sys/types.h before including regex.h, as
9917 * doc.c (get_doc_string): Improve the format passed to `error'.
9919 * doprnt.c (doprnt): Improve commentary.
9921 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9923 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9926 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9927 changes in globals.h immediately force recompilation.
9928 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9929 $(CURDIR)/s/ms-w32.h.
9930 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
9932 * character.c (Fchar_direction): Function deleted.
9933 (syms_of_character): Don't defsubr it.
9934 <char-direction-table>: Deleted.
9936 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9938 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9939 * doprnt.c: Include limits.h.
9940 (SIZE_MAX): New macro.
9941 (doprnt): Return a size_t value. 2nd arg is now size_t.
9942 Many local variables are now size_t instead of int or unsigned.
9943 Improve overflow protection. Support `l' modifier for integer
9944 conversions. Support %l conversion. Don't assume an EMACS_INT
9945 argument for integer conversions and for %c.
9947 * lisp.h (doprnt): Restore prototype.
9949 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9952 * Makefile.in (base_obj): Add back doprnt.o.
9954 * deps.mk (doprnt.o): Add back prerequisites.
9955 (callint.o): Depend on character.h.
9957 * eval.c (internal_lisp_condition_case): Include the handler
9958 representation in the error message.
9959 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9960 when breaking from the loop.
9962 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9964 * callint.c (Fcall_interactively): When displaying error message
9965 about invalid control letter, pass the character's codepoint, not
9966 a pointer to its multibyte form. Improve display of the character
9967 in octal and display also its hex code.
9969 * character.c (char_string): Use %x to display the (unsigned)
9970 codepoint of an invalid character, to avoid displaying a bogus
9973 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9974 `error', not SYMBOL_NAME itself.
9976 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9977 character arguments to `error'.
9979 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9980 to `error' in error message about FINAL_CHAR argument. Make sure
9981 FINAL_CHAR is a character, and use %c when it is passed as
9982 argument to `error'.
9984 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9986 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9988 * w32.c: Include <time.h>.
9989 (sys_localtime): New function.
9991 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
9993 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9995 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
9997 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
9999 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10000 zombies (Bug#8467).
10002 2011-04-19 Eli Zaretskii <eliz@gnu.org>
10004 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10005 gl_state.e_property when gl_state.object is Qt.
10007 * insdel.c (make_gap_larger): Remove limitation of buffer size
10010 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
10012 * xdisp.c (lookup_glyphless_char_display)
10013 (produce_glyphless_glyph): Handle cons cell entry in
10014 glyphless-char-display.
10015 (Vglyphless_char_display): Document it.
10017 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10018 glyphless-char-display.
10020 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
10022 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10024 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10026 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10027 definition for no-X builds.
10029 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
10031 Static checks with GCC 4.6.0 and non-default toolkits.
10033 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10035 * process.c (keyboard_bit_set): Define only if SIGIO.
10036 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10037 (send_process): Repair possible setjmp clobbering.
10039 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10041 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10043 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10045 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10046 Define only if needed.
10048 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10049 by pacifying GCC about it. Maybe it's time to retire it?
10050 * xfaces.c (USG, __TIMEVAL__): Likewise.
10052 * dispextern.h (struct redisplay_interface): Rename param
10053 to avoid shadowing.
10054 * termhooks.h (struct terminal): Likewise.
10055 * xterm.c (xembed_send_message): Likewise.
10057 * insdel.c (make_gap_smaller): Define only if
10058 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10060 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10063 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10064 so that we aren't warned about unused symbols.
10066 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10068 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
10070 * xfns.c (x_real_positions): Mark locals as initialized.
10072 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10074 * xterm.c: Fix problems found by static analysis with other toolkits.
10075 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
10076 (x_dispatch_event): Declare static if USE_GTK, and
10077 define if USE_GTK || USE_X_TOOLKIT.
10078 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
10079 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
10080 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10081 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
10083 * xmenu.c (menu_help_callback): Pointer type fixes.
10084 Use const pointers when pointing at readonly data. Avoid pointer
10085 signedness clashes.
10086 (FALSE): Remove unused macro.
10087 (update_frame_menubar): Remove unused decl.
10089 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10091 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10092 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10093 (single_menu_item): Rename local to avoid shadowing.
10095 * keyboard.c (make_lispy_event): Remove unused local var.
10097 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10098 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10100 * bitmaps: Change bitmaps from unsigned char back to the X11
10101 compatible char. Avoid the old compiler warnings about
10102 out-of-range initializers by using, for example, '\xab' rather
10105 * xgselect.c (xgselect_initialize): Check vs interface
10106 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10108 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10110 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10111 to read-only memory.
10113 * fns.c (vector): Remove; this old hack is no longer needed.
10115 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
10117 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
10119 * xrdb.c (x_load_resources): Omit unused local.
10121 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
10122 (x_window): Rename locals to avoid shadowing.
10123 (USG): Use the kludged USG macro, to pacify gcc.
10125 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
10126 (x_term_init): Remove local to avoid shadowing.
10128 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
10130 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10131 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10133 2011-04-16 Eli Zaretskii <eliz@gnu.org>
10135 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10137 Fix regex.c, syntax.c and friends for buffers > 2GB.
10138 * syntax.h (struct gl_state_s): Declare character position members
10141 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10143 * textprop.c (verify_interval_modification, interval_of):
10144 Declare arguments EMACS_INT.
10146 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10149 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10151 * indent.c (Fvertical_motion): Local variable it_start is now
10154 * regex.c (re_match, re_match_2, re_match_2_internal)
10155 (bcmp_translate, regcomp, regexec, print_double_string)
10156 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10157 (re_compile_pattern, re_exec): Declare arguments and local
10158 variables `size_t' and `ssize_t' and return values `regoff_t', as
10160 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10161 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10162 <compile_stack_type>: `size' and `avail' are now `size_t'.
10164 * regex.h <regoff_t>: Use ssize_t, not int.
10165 (re_search, re_search_2, re_match, re_match_2): Arguments that
10166 specify buffer/string position and length are now ssize_t and
10167 size_t. Return type is regoff_t.
10169 2011-04-16 Ben Key <bkey76@gmail.com>
10171 * nsfont.m: Fixed bugs in ns_get_family and
10172 ns_descriptor_to_entity that were caused by using free to
10173 deallocate memory blocks that were allocated by xmalloc (via
10174 xstrdup). This caused Emacs to crash when compiled with
10175 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10176 --enable-checking=xmallocoverrun). xfree is now used to
10177 deallocate these memory blocks.
10179 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
10181 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10183 emacs_write: Accept and return EMACS_INT for sizes.
10184 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10186 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10187 Accept and return EMACS_INT.
10188 (emacs_gnutls_write): Return the number of bytes written on
10190 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
10191 (emacs_read, emacs_write): Remove check for negative size, as the
10192 Emacs source code has been audited now.
10193 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10194 (emacs_read, emacs_write): Use it.
10195 * process.c (send_process): Adjust to the new signatures of
10196 emacs_write and emacs_gnutls_write. Do not attempt to store
10197 a byte offset into an 'int'; it might overflow.
10198 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
10200 * sound.c: Don't assume sizes fit in 'int'.
10201 (struct sound_device.period_size, alsa_period_size):
10202 Return EMACS_INT, not int.
10203 (struct sound_device.write, vox_write, alsa_write):
10204 Accept EMACS_INT, not int.
10205 (wav_play, au_play): Use EMACS_INT to store sizes and to
10206 record read return values.
10208 2011-04-15 Ben Key <bkey76@gmail.com>
10210 * keyboard.c (Qundefined): Don't declare static since it is used
10212 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10213 static since they are used in nsfont.m.
10215 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10217 * process.c (Qprocessp): Don't declare static.
10218 * lisp.h (Qprocessp): Declare again.
10220 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
10222 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10224 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10226 Improve C-level modularity by making more things 'static'.
10228 Don't publish debugger-only interfaces to other modules.
10229 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10230 (verify_bytepos, count_markers): Move decls to the only modules
10232 * region-cache.h (pp_cache): Likewise.
10233 * window.h (check_all_windows): Likewise.
10234 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10236 * sysdep.c (croak): Now static, if
10237 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10238 * syssignal.h (croak): Declare only if not static.
10240 * alloc.c (refill_memory_reserve): Now static if
10241 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10242 * lisp.h (refill_memory_reserve): Declare only if not static.
10244 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10245 Define only if USE_LUCID.
10247 * xrdb.c (x_customization_string, x_rm_string): Now static.
10249 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10250 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10252 * xdisp.c (draw_row_with_mouse_face): Now static.
10253 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10255 * window.h (check_all_windows): Mark externally visible.
10257 * window.c (window_deletion_count): Now static.
10259 * undo.c: Make symbols static if they're not exported.
10260 (last_undo_buffer, last_boundary_position, pending_boundary):
10263 * textprop.c (interval_insert_behind_hooks): Now static.
10264 (interval_insert_in_front_hooks): Likewise.
10266 * term.c: Make symbols static if they're not exported.
10267 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10268 (max_frame_lines, tty_set_terminal_modes):
10269 (tty_reset_terminal_modes, tty_turn_off_highlight):
10270 (get_tty_terminal): Now static.
10271 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10272 * termhooks.h (term_mouse_moveto): Do not declare if
10273 HAVE_WINDOW_SYSTEM.
10274 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10275 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10277 * sysdep.c: Make symbols static if they're not exported.
10278 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10280 (sigprocmask_set, full_mask): Remove; unused.
10281 (wait_debugging): Mark as visible.
10282 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10283 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10285 * syntax.c (syntax_temp): Define only if !__GNUC__.
10287 * sound.c (current_sound_device, current_sound): Now static.
10289 * search.c (searchbufs, searchbuf_head): Now static.
10291 * scroll.c (scroll_cost): Remove; unused.
10292 * dispextern.h (scroll_cost): Remove decl.
10294 * region-cache.h (pp_cache): Mark as externally visible.
10296 * process.c: Make symbols static if they're not exported.
10297 (process_tick, update_tick, create_process, chan_process):
10298 (Vprocess_alist, proc_buffered_char, datagram_access):
10299 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10300 (deactivate_process): Mark defn as static, as well as decl.
10301 * lisp.h (create_process): Remove decl.
10302 * process.h (chan_process, Vprocess_alist): Remove decls.
10304 * print.c: Make symbols static if they're not exported.
10305 (print_depth, new_backquote_output, being_printed, print_buffer):
10306 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10307 (print_interval, print_number_index, initial_stderr_stream):
10309 * lisp.h (Fprinc): Remove decl.
10310 (debug_output_compilation_hack): Mark as externally visible.
10312 * sysdep.c (croak): Move decl from here to syssignal.h.
10313 * syssignal.h (croak): Put it here, so the API can be checked when
10314 'croak' is called from dissociate_if_controlling_tty.
10316 * minibuf.c: Make symbols static if they're not exported.
10317 (minibuf_save_list, choose_minibuf_frame): Now static.
10318 * lisp.h (choose_minibuf_frame): Remove decl.
10320 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10322 * lread.c: Make symbols static if they're not exported.
10323 (read_objects, initial_obarray, oblookup_last_bucket_number):
10325 (make_symbol): Remove; unused.
10326 * lisp.h (initial_obarray, make_symbol): Remove decls.
10328 * keyboard.c: Make symbols static if they're not exported.
10329 (single_kboard, recent_keys_index, total_keys, recent_keys):
10330 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10331 (this_single_command_key_start, echoing, last_auto_save):
10332 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10333 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10334 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10335 (Vlispy_mouse_stem, double_click_count):
10337 (force_auto_save_soon): Define only if SIGDANGER.
10338 (ignore_mouse_drag_p): Now static if
10339 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10340 (print_help): Remove; unused.
10341 (stop_character, last_timer_event): Mark as externally visible.
10342 * keyboard.h (ignore_mouse_drag_p): Declare only if
10343 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10344 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10345 * lisp.h (echoing): Remove decl.
10346 (force_auto_save_soon): Declare only if SIGDANGER.
10347 * xdisp.c (redisplay_window): Simplify code, to make it more
10348 obvious that ignore_mouse_drag_p is not accessed if !defined
10349 USE_GTK && !defined HAVE_NS.
10351 * intervals.c: Make symbols static if they're not exported.
10352 (merge_properties_sticky, merge_interval_right, delete_interval):
10354 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10356 * insdel.c: Make symbols static if they're not exported.
10357 However, leave prepare_to_modify_buffer alone. It's never
10358 called from outside this function, but that appears to be a bug.
10359 (combine_after_change_list, combine_after_change_buffer):
10360 (adjust_after_replace, signal_before_change): Now static.
10361 (adjust_after_replace_noundo): Remove; unused.
10362 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
10363 (signal_before_change): Remove decls.
10365 * indent.c (val_compute_motion, val_vmotion): Now static.
10367 * image.c: Make symbols static if they're not exported.
10368 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10370 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10371 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10373 * fringe.c (standard_bitmaps): Now static.
10374 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10376 * frame.c: Make symbols static if they're not exported.
10377 (x_report_frame_params, make_terminal_frame): Now static.
10378 (get_frame_param): Now static, unless HAVE_NS.
10379 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10380 (x_get_resource_string): Remove; not used.
10381 * frame.h (make_terminal_frame, x_report_frame_params):
10382 (x_get_resource_string); Remove decls.
10383 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10384 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10386 * font.c, fontset.c: Make symbols static if they're not exported.
10387 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10388 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10389 * font.c (font_close_object): Now static.
10390 * font.h (font_close_object): Remove.
10391 * fontset.c (FONTSET_OBJLIST): Remove.
10392 (free_realized_fontset) #if-0 the body, which does nothing.
10393 (face_suitable_for_char_p): #if-0, as it's never called.
10394 * fontset.h (face_suitable_for_char_p): Remove decl.
10395 * xfaces.c (face_at_string_position):
10396 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
10397 since 0 is always ASCII.
10399 * fns.c (weak_hash_tables): Now static.
10401 * fileio.c: Make symbols static if they're not exported.
10402 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10403 (Vwrite_region_annotation_buffers): Now static.
10405 * eval.c: Make symbols static if they're not exported.
10406 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10407 * lisp.h (backtrace_list): Remove decl.
10409 * emacs.c: Make symbols static if they're not exported.
10410 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10411 (fatal_error_code, fatal_error_signal_hook, standard_args):
10413 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10414 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10415 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10416 * lisp.h (fatal_error_signal_hook): Remove decl.
10417 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10419 * editfns.c: Move a (normally-unused) function to its only use.
10420 * editfns.c, lisp.h (get_operating_system_release): Remove.
10421 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10422 worth the hassle of breaking this out.
10424 * xterm.c: Make symbols static if they're not exported.
10425 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10426 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10427 (x_destroy_window, x_delete_display):
10429 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10430 (x_mouse_leave): Remove; unused.
10431 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10432 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10433 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10435 (x_mouse_leave): Declare only if WINDOWSNT.
10436 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10437 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10440 * ftxfont.c: Make symbols static if they're not exported.
10441 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10443 * font.h (ftxfont_driver): Likewise.
10445 * xfns.c: Make symbols static if they're not exported.
10446 (x_last_font_name, x_display_info_for_name):
10447 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10448 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10449 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10450 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10451 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10452 (last_show_tip_args): Now static.
10453 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10454 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10455 (x_screen_planes): Remove; unused.
10456 * dispextern.h (x_screen_planes): Remove decl.
10458 * dispnew.c: Make symbols static if they're not exported.
10459 * dispextern.h (redraw_garbaged_frames, scrolling):
10460 (increment_row_positions): Remove.
10461 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10462 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10464 (redraw_garbaged_frames): Remove; unused.
10466 * xfaces.c: Make symbols static if they're not exported.
10467 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10469 * xterm.h (defined_color): Remove decls.
10470 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10471 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10472 (menu_face_changed_default, defined_color, free_realized_face):
10473 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10474 (ascii_face_of_lisp_face): Remove; unused.
10476 * xdisp.c: Make symbols static if they're not exported.
10477 * dispextern.h (scratch_glyph_row, window_box_edges):
10478 (glyph_to_pixel_coords, set_cursor_from_row):
10479 (get_next_display_element, set_iterator_to_next):
10480 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10481 (show_mouse_face): Remove decls
10482 * frame.h (message_buf_print): Likewise.
10483 * lisp.h (pop_message, set_message, check_point_in_composition):
10485 * xterm.h (set_vertical_scroll_bar): Likewise.
10486 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10487 (message_buf_print, scratch_glyph_row, displayed_buffer):
10488 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10489 (get_next_display_element, show_mouse_face, window_box_edges):
10490 (frame_to_window_pixel_xy, check_point_in_composition):
10491 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10492 (glyph_to_pixel_coords): Remove; unused.
10494 * dired.c (file_name_completion): Now static.
10496 * dbusbind.c (xd_in_read_queued_messages): Now static.
10498 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10499 * data.c (circular_list_error): Remove.
10501 * commands.h (last_point_position, last_point_position_buffer):
10502 (last_point_position_window): Remove decls.
10503 * keyboard.c: Make these variables static.
10505 * coding.h (coding, code_convert_region, encode_coding_gap):
10507 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10508 (iso_code_class, detect_coding, code_convert_region): Now static.
10509 (encode_coding_gap): Remove; unused.
10511 * chartab.c (chartab_chars, chartab_bits): Now static.
10513 * charset.h (charset_iso_8859_1): Remove decl.
10514 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10517 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10518 * ccl.c (Vccl_program_table): Now static.
10519 (check_ccl_update): Remove; unused.
10521 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10522 * category.h: ... from here.
10523 * category.c (check_category_table, set_category_set): Now static.
10525 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10526 * lisp.h: Remove these decls.
10528 * buffer.c (buffer_count): Remove unused var.
10530 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10531 so that it's not optimized away.
10532 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10533 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10534 exported only to the debugger.
10536 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
10537 * atimer.h (run_all_atimers): Remove; not exported.
10539 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10540 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10541 was inaccessible from Lisp.
10542 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10543 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10545 alloc.c: Import and export fewer symbols, and remove unused items.
10546 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10548 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10549 it's not optimized away by whole-program optimization.
10550 (message_enable_multibyte, free_misc): Remove.
10551 (catchlist, handlerlist, mark_backtrace):
10552 Declare only if BYTE_MARK_STACK.
10553 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10554 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10555 (message_enable_multibyte): Remove decl.
10556 (free_misc, interval_free_list, float_block, float_block_index):
10557 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10558 (cons_free_list, last_marked_index):
10560 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10561 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10562 (mark_backtrace): Define only if BYTE_MARK_STACK.
10563 * xdisp.c (message_enable_multibyte): Now static.
10565 Declare Lisp_Object Q* variables to be 'static' if not exported.
10566 This makes it easier for human readers (and static analyzers)
10567 to see whether these variables are used from other modules.
10568 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10569 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10570 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10571 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10572 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10573 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10574 * xmenu.c, xselect.c:
10575 Declare Q* vars static if they are not used in other modules.
10576 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10577 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10578 Remove decls of unexported vars.
10579 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10581 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10583 Make Emacs functions such as Fatom 'static' by default.
10584 This makes it easier for human readers (and static analyzers)
10585 to see whether these functions can be called from other modules.
10586 DEFUN now defines a static function. To make the function external
10587 so that it can be used in other C modules, use the new macro DEFUE.
10588 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10589 (Finit_image_library):
10590 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10591 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10592 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10593 Remove decls, since these functions are now static.
10594 (Funintern, Fget_internal_run_time): New decls, since these functions
10595 were already external.
10597 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10598 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10599 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10600 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10601 * keyboard.c, keymap.c, lread.c:
10602 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10603 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10604 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10605 Mark functions with DEFUE instead of DEFUN,
10606 if they are used in other modules.
10607 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10608 decls for now-static functions.
10609 * buffer.h (Fdelete_overlay): Remove decl.
10610 * callproc.c (Fgetenv_internal): Mark as internal.
10611 * composite.c (Fremove_list_of_text_properties): Remove decl.
10612 (Fcomposition_get_gstring): New forward static decl.
10613 * composite.h (Fcomposite_get_gstring): Remove decl.
10614 * dired.c (Ffile_attributes): New forward static decl.
10615 * doc.c (Fdocumntation_property): New forward static decl.
10616 * eval.c (Ffetch_bytecode): New forward static decl.
10617 (Funintern): Remove extern decl; now in .h file where it belongs.
10618 * fileio.c (Fmake_symbolic_link): New forward static decl.
10619 * image.c (Finit_image_library): New forward static decl.
10620 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10621 * intervals.h (Fprevious_property_change):
10622 (Fremove_list_of_text_properties): Remove decls.
10623 * keyboard.c (Fthis_command_keys): Remove decl.
10624 (Fcommand_execute): New forward static decl.
10625 * keymap.c (Flookup_key): New forward static decl.
10626 (Fcopy_keymap): Now static.
10627 * keymap.h (Flookup_key): Remove decl.
10628 * process.c (Fget_process): New forward static decl.
10629 (Fprocess_datagram_address): Mark as internal.
10630 * syntax.c (Fsyntax_table_p): New forward static decl.
10631 (skip_chars): Remove duplicate decl.
10632 * textprop.c (Fprevious_property_change): New forward static decl.
10633 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10635 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10636 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10638 * editfns.c (Fformat): Remove unreachable code.
10640 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10642 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10645 2011-04-13 Eli Zaretskii <eliz@gnu.org>
10647 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10648 when at ZV. (Bug#8487)
10650 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10652 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10654 * keyboard.c (parse_tool_bar_item): Likewise.
10655 * sound.c (sound_cleanup, alsa_close): Likewise.
10656 * termcap.c (tgetent): Likewise.
10657 * xfns.c (x_default_font_parameter): Likewise.
10658 * xsettings.c (read_and_apply_settings): Likewise.
10660 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10661 (overrun_check_free): Protoize.
10663 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10665 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10666 since callers should never pass a negative size.
10667 Change the signature to match that of plain 'read' and 'write'; see
10668 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10669 * lisp.h: Update prototypes of emacs_write and emacs_read.
10671 2011-04-11 Eli Zaretskii <eliz@gnu.org>
10673 * xdisp.c (redisplay_window): Don't try to determine the character
10674 position of the scroll margin if the window start point w->startp
10675 is outside the buffer's accessible region. (Bug#8468)
10677 2011-04-10 Eli Zaretskii <eliz@gnu.org>
10679 Fix write-region and its subroutines for buffers > 2GB.
10680 * fileio.c (a_write, e_write): Modify declaration of arguments and
10681 local variables to support buffers larger than 2GB.
10682 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10684 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10685 argument, local variables, and return value.
10687 * lisp.h: Update prototypes of emacs_write and emacs_read.
10689 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10691 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
10693 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10695 Fix more problems found by GCC 4.6.0's static checks.
10697 * xdisp.c (vmessage): Use a better test for character truncation.
10699 * charset.c (load_charset_map): <, not <=, for optimization,
10700 and to avoid potential problems with integer overflow.
10701 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
10702 * casetab.c (set_identity, shuffle): Likewise.
10703 * editfns.c (Fformat): Likewise.
10704 * syntax.c (skip_chars): Likewise.
10706 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10707 This also lets GCC 4.6.0 generate slightly better loop code.
10709 * callint.c (Fcall_interactively): <, not <=, for optimization.
10710 (Fcall_interactively): Count the number of arguments produced,
10711 not the number of arguments given. This is simpler and lets GCC
10712 4.6.0 generate slightly better code.
10714 * ftfont.c: Distingish more carefully between FcChar8 and char.
10715 The previous code passed unsigned char * to a functions like
10716 strlen and xstrcasecmp that expect char *, which does not
10717 conform to the C standard.
10718 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10719 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10720 char * when the C standard requires it.
10722 * keyboard.c (read_char): Remove unused var.
10724 * eval.c: Port to Windows vsnprintf (Bug#8435).
10725 Include <limits.h>.
10726 (SIZE_MAX): Define if the headers do not.
10727 (verror): Do not give up if vsnprintf returns a negative count.
10728 Instead, grow the buffer. This ports to Windows vsnprintf, which
10729 does not conform to C99. Problem reported by Eli Zaretskii.
10730 Also, simplify the allocation scheme, by avoiding the need for
10731 calling realloc, and removing the ALLOCATED variable.
10733 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10735 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10736 But keep the doprint source code for now, as we might revamp it
10737 and use it again (Bug#8435).
10738 * lisp.h (doprnt): Remove.
10739 * Makefile.in (base_obj): Remove doprnt.o.
10740 * deps.mk (doprnt.o): Remove.
10742 error: Print 32- and 64-bit integers portably (Bug#8435).
10743 Without this change, on typical 64-bit hosts error ("...%d...", N)
10744 was used to print both 32- and 64-bit integers N, which relied on
10745 undefined behavior.
10746 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
10747 * lisp.h (error, verror): Mark as printf-like functions.
10748 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10749 Report overflow in size calculations when allocating printf buffer.
10750 Do not truncate output string at its first null byte.
10751 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10752 Truncate the output at a character boundary, since vsnprintf does not
10754 * charset.c (check_iso_charset_parameter): Convert internal
10755 character to string before calling 'error', since %c now has the
10757 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10758 overflow when computing char to be passed to 'error'. Do not
10759 pass Lisp_Object to 'error'; pass the integer instead.
10760 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10761 formatted with plain %d.
10763 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10765 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10767 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10769 * xterm.c (x_catch_errors): Remove duplicate declaration.
10771 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10773 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10775 2011-04-10 Jim Meyering <meyering@redhat.com>
10777 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10778 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10779 return ssize_t not "int", and use size_t as the buffer length.
10780 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10781 * gnutls.h: Update declarations.
10782 * process.c (read_process_output): Use ssize_t, to match.
10783 (send_process): Likewise.
10785 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10787 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10789 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10791 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10792 Use unsigned char, to match FcChar8 type definition.
10794 * xterm.c (handle_one_xevent):
10795 * xmenu.c (create_and_show_popup_menu):
10796 * xselect.c (x_decline_selection_request)
10797 (x_reply_selection_request): Avoid type-punned deref of X events.
10799 2011-04-09 Eli Zaretskii <eliz@gnu.org>
10801 Fix some uses of `int' instead of EMACS_INT.
10802 * search.c (string_match_1, fast_string_match)
10803 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10804 (scan_buffer, find_next_newline_no_quit)
10805 (find_before_next_newline, search_command, Freplace_match)
10806 (Fmatch_data): Make some `int' variables be EMACS_INT.
10808 * xdisp.c (display_count_lines): 3rd argument and return value now
10809 EMACS_INT. All callers changed.
10810 (pint2hrstr): Last argument is now EMACS_INT.
10812 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10813 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10814 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10815 (decode_coding_utf_16, decode_coding_emacs_mule)
10816 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10817 (decode_coding_ccl, decode_coding_charset)
10818 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10819 (decode_coding_iso_2022, decode_coding_emacs_mule)
10820 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10821 <char_offset, last_offset>: Declare EMACS_INT.
10822 (encode_coding_utf_8, encode_coding_utf_16)
10823 (encode_coding_emacs_mule, encode_invocation_designation)
10824 (encode_designation_at_bol, encode_coding_iso_2022)
10825 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10826 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10828 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10829 (encode_invocation_designation): Last argument P_NCHARS is now
10831 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10832 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10834 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10837 * ccl.c (Fccl_execute_on_string): Declare some variables
10840 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
10842 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10844 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10846 * process.c (Fformat_network_address): Doc fix.
10848 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10850 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
10852 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
10854 * keyboard.c (read_char): Call Lisp function help-form-show,
10855 instead of using internal_with_output_to_temp_buffer.
10856 (Qhelp_form_show): New var.
10857 (syms_of_keyboard): Use DEFSYM macro.
10859 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10861 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10863 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
10865 * process.c (Flist_processes): Remove to Lisp.
10866 (list_processes_1): Delete.
10868 2011-04-06 Eli Zaretskii <eliz@gnu.org>
10870 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10872 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10874 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
10876 Fix more problems found by GCC 4.6.0's static checks.
10878 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10880 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10882 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
10884 * xdisp.c (vmessage): Mark as a printf-like function.
10886 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10888 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10890 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10891 printf-like functions.
10892 (tiff_load): Add casts to remove these marks before passing them
10893 to system-supplied API.
10895 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10897 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10898 This avoids several warnings with gcc -Wstrict-overflow.
10899 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10900 directly, rather than having caller test rule sign. This avoids
10901 some unnecessary tests.
10902 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10903 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10904 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
10906 * xfont.c (xfont_text_extents): Remove var that was set but not used.
10907 (xfont_open): Avoid unnecessary tests.
10909 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10911 * composite.h, composite.c (composition_gstring_put_cache):
10912 Use EMACS_INT, not int, for length.
10914 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10915 breaking out part of COMPOSITION_DECODE_RULE.
10916 (COMPOSITION_DECODE_RULE): Use it.
10917 * composite.c (get_composition_id): Remove unused local vars,
10918 by using the new macro.
10920 * textprop.c (set_text_properties_1): Change while to do-while,
10921 since the condition is always true at first.
10923 * intervals.c (graft_intervals_into_buffer): Mark var as used.
10924 (interval_deletion_adjustment): Return unsigned value.
10927 * process.c (list_processes_1, create_pty, read_process_output):
10928 (exec_sentinel): Remove vars that were set but not used.
10929 (create_pty): Remove unnecessary "volatile"s.
10930 (Fnetwork_interface_info): Avoid possibility of int overflow.
10931 (read_process_output): Do adaptive read buffering even if carryover.
10932 (read_process_output): Simplify nbytes computation if buffered.
10934 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10936 * syntax.c (scan_words): Remove var that was set but not used.
10937 (update_syntax_table): Use unsigned instead of int.
10939 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
10940 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
10941 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
10943 * print.c (print_error_message): Avoid int overflow.
10945 * font.c (font_list_entities): Redo for clarity,
10946 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10948 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
10949 (font_score): Avoid potential overflow in diff calculation.
10951 * fns.c (substring_both): Remove var that is set but not used.
10952 (sxhash): Redo loop for clarity and to avoid wraparound warning.
10954 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10956 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10957 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10958 can always succeed if overflow has undefined behavior.
10960 * search.c (boyer_moore, wordify): Remove vars set but not used.
10961 (wordify): Omit three unnecessary tests.
10963 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10964 All callers changed. This avoids the need for an unused var.
10966 * casefiddle.c (casify_region): Remove var that is set but not used.
10968 * dired.c (file_name_completion): Remove var that is set but not used.
10970 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10972 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
10973 (Finsert_file_contents): Remove unnecessary code checking fd.
10975 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10976 Check for integer overflow on size calculations.
10978 * buffer.c (Fprevious_overlay_change): Remove var that is set
10981 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10982 Remove vars that are set but not used.
10983 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
10984 (timer_check_2): Mark vars as initialized.
10986 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10988 * image.c (lookup_image): Remove var that is set but not used.
10989 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
10991 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10992 that are set but not used.
10994 * xfns.c (make_invisible_cursor): Don't return garbage
10995 if XCreateBitmapFromData fails (Bug#8410).
10997 * xselect.c (x_get_local_selection, x_handle_property_notify):
10998 Remove vars that are set but not used.
11000 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
11001 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
11003 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11004 Remove var that is set but not used.
11005 (scroll_bar_windows_size): Now size_t, not int.
11006 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11007 Check for overflow.
11009 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11010 (map_tty_color) [!defined MSDOS]: Likewise.
11012 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11014 * coding.c: Remove vars that are set but not used.
11015 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11016 All callers changed.
11017 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11018 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11019 (decode_coding_charset): Remove vars that are set but not used.
11021 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11022 that is set but not used.
11024 * print.c (print_object): Remove var that is set but not used.
11026 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
11027 The gnulib version avoids calling malloc in the usual case,
11028 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11029 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11030 * filelock.c (current_lock_owner): Likewise.
11031 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11032 * sysdep.c: Include allocator.h, careadlinkat.h.
11033 (emacs_no_realloc_allocator): New static constant.
11034 (emacs_readlink): New function.
11035 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11036 ../lib/careadlinkat.h.
11038 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11040 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11041 first non-nil return value).
11043 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11045 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11046 if not defined (Bug#8403).
11048 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11050 * xdisp.c (display_count_lines): Remove parameter `start',
11051 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11052 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11053 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11054 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11055 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11056 and thereabouts. All callers changed.
11057 (get_per_char_metric): Remove parameter `f', unused since
11058 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11060 2011-04-02 Jim Meyering <meyering@redhat.com>
11062 do not dereference NULL upon failed strdup
11063 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11064 (ns_get_family): Likewise.
11066 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11068 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11070 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11072 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11075 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11077 Add lexical binding.
11079 * window.c (Ftemp_output_buffer_show): New fun.
11080 (Fsave_window_excursion):
11081 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11083 * lread.c (lisp_file_lexically_bound_p): New function.
11084 (Fload): Bind Qlexical_binding.
11085 (readevalloop): Remove `evalfun' arg.
11086 Bind Qinternal_interpreter_environment.
11087 (Feval_buffer): Bind Qlexical_binding.
11088 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11090 (syms_of_lread): Declare `lexical-binding'.
11092 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11094 * keyboard.c (eval_dyn): New fun.
11095 (menu_item_eval_property): Use it.
11097 * image.c (parse_image_spec): Use Ffunctionp.
11099 * fns.c (concat, mapcar1): Accept byte-code-functions.
11101 * eval.c (Fsetq): Handle lexical vars.
11102 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11103 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11104 (FletX, Flet): Obey lexical binding.
11105 (Fcommandp): Handle closures.
11106 (Feval): New `lexical' arg.
11107 (eval_sub): New function extracted from Feval. Use it almost
11108 everywhere where Feval was used. Look up vars in lexical env.
11110 (Ffunctionp): Move from subr.el.
11111 (Ffuncall): Handle closures.
11112 (apply_lambda): Remove `eval_flags'.
11113 (funcall_lambda): Handle closures and new byte-code-functions.
11114 (Fspecial_variable_p): New function.
11115 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11116 but without exporting it to Lisp.
11118 * doc.c (Fdocumentation, store_function_docstring):
11119 * data.c (Finteractive_form): Handle closures.
11121 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11124 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11126 (exec_byte_code): New function extracted from Fbyte_code to handle new
11127 calling convention for byte-code-functions. Add new byte-codes.
11129 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
11131 * alloc.c (Fmake_symbol): Init new `declared_special' field.
11133 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11135 * xdisp.c (redisplay_internal): Fix prototype.
11137 2011-03-31 Eli Zaretskii <eliz@gnu.org>
11139 * xdisp.c (SCROLL_LIMIT): New macro.
11140 (try_scrolling): Use it when setting scroll_limit.
11141 Limit scrolling to 100 screen lines.
11142 (redisplay_window): Even when falling back on "recentering",
11143 position point in the window according to scroll-conservatively,
11144 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11146 (try_scrolling): When point is above the window, allow searching
11147 as far as scroll_max, or one screenful, to compute vertical
11148 distance from PT to the scroll margin position. This prevents
11149 try_scrolling from unnecessarily failing when
11150 scroll-conservatively is set to a value slightly larger than the
11151 window height. Clean up the case of PT below the margin at bottom
11152 of window: scroll_max can no longer be INT_MAX. When aggressive
11153 scrolling is in use, don't let point enter the opposite scroll
11154 margin as result of the scroll.
11155 (syms_of_xdisp) <scroll-conservatively>: Document the
11156 threshold of 100 lines for never-recentering scrolling.
11158 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11160 * dispextern.h (move_it_by_lines):
11161 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11162 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11163 (message_log_check_duplicate): Remove parameters `prev_bol' and
11164 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11165 (redisplay_internal): Remove parameter `preserve_echo_area',
11166 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11168 * indent.c (Fvertical_motion):
11169 * window.c (window_scroll_pixel_based, Frecenter):
11170 Don't pass `need_y_p' to `move_it_by_lines'.
11172 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11174 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11175 steal a few bits to be more compact.
11176 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11177 Remove unneeded casts.
11179 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11181 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11183 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11184 binding" message (bug#7967).
11186 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11188 Fix more problems found by GCC 4.6.0's static checks.
11190 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11191 Remove unused local var.
11193 * editfns.c (Fmessage_box): Remove unused local var.
11195 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11196 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11197 Omit unused local vars.
11198 * window.c (shrink_windows): Omit unused local var.
11199 * menu.c (digest_single_submenu): Omit unused local var.
11200 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11201 Omit unused local var.
11203 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11204 Don't assume string length fits in int.
11205 (keyremap_step, read_key_sequence): Use size_t for sizes.
11206 (read_key_sequence): Don't check last_real_key_start redundantly.
11208 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11209 instead of alloca (Bug#8344).
11211 * eval.c (Fbacktrace): Don't assume nargs fits in int.
11212 (Fbacktrace_frame): Don't assume nframes fits in int.
11214 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11216 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11219 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11221 * cm.c (calccost): Turn while-do into do-while, for clarity.
11223 * keyboard.c (syms_of_keyboard): Use the same style as later
11224 in this function when indexing through an array. This also
11225 works around GCC bug 48267.
11227 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11229 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11231 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11232 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11234 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11235 This avoids undefined behavior on integer overflow, and is a bit
11236 more convenient anyway since it is compared to a size_t variable.
11238 Variadic C functions now count arguments with size_t, not int.
11239 This avoids an unnecessary limitation on 64-bit machines, which
11240 caused (substring ...) to crash on large vectors (Bug#8344).
11241 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11242 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
11243 All variadic functions and their callers changed accordingly.
11244 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11245 * data.c (arith_driver, float_arith_driver): Likewise.
11246 * editfns.c (general_insert_function): Likewise.
11247 * eval.c (struct backtrace.nargs, interactive_p)
11248 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11249 (funcall_lambda, mark_backtrace): Likewise.
11250 * fns.c (concat): Likewise.
11251 * frame.c (x_set_frame_parameters): Likewise.
11252 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11253 0 if not found, not -1. All callers changed.
11255 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11256 (stack_copy_size): Now size_t, not int.
11257 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11259 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11261 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11262 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11263 All callers changed.
11265 * lisp.h (multibyte_char_to_unibyte):
11266 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11267 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11268 * character.h (CHAR_TO_BYTE8):
11269 * cmds.c (internal_self_insert):
11270 * editfns.c (general_insert_function):
11271 * keymap.c (push_key_description):
11272 * search.c (Freplace_match):
11273 * xdisp.c (message_dolog, set_message_1): All callers changed.
11275 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11277 * keyboard.c (safe_run_hook_funcall): New function.
11278 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11279 don't set the hook to nil, but remove the offending function instead.
11280 (Qcommand_hook_internal): Remove, unused.
11281 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11282 Vcommand_hook_internal.
11284 * eval.c (enum run_hooks_condition): Remove.
11285 (funcall_nil, funcall_not): New functions.
11286 (run_hook_with_args): Call each function through a `funcall' argument.
11287 Remove `cond' argument, now redundant.
11288 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11289 (Frun_hook_with_args_until_failure): Adjust accordingly.
11290 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11292 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11294 * dispextern.h (string_buffer_position): Remove declaration.
11296 * print.c (strout): Remove parameter `multibyte', unused since
11297 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11299 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11300 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11301 All callers changed.
11303 * w32.c (_wsa_errlist): Use braces for struct initializers.
11305 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11306 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11307 All callers changed.
11308 (string_buffer_position): Likewise. Also, make static (it's never
11309 used outside xdisp.c).
11310 (cursor_row_p): Remove parameter `w', unused since
11311 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11312 (decode_mode_spec): Remove parameter `precision', introduced during
11313 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11314 All callers changed.
11316 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11318 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11320 2011-03-27 Anders Lindgren <andlind@gmail.com>
11322 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11323 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11324 (ns_update_auto_hide_menu_bar): New functions.
11325 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11326 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11327 ns_constrain_all_frames.
11328 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11329 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11331 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11333 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11335 2011-03-27 Glenn Morris <rgm@gnu.org>
11337 * syssignal.h: Replace RETSIGTYPE with void.
11338 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11339 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11340 Replace SIGTYPE with void everywhere.
11341 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11342 * s/template.h (SIGTYPE): Remove commented out definition.
11344 2011-03-26 Eli Zaretskii <eliz@gnu.org>
11346 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11347 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11349 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
11351 * w32.c (read_unc_volume): Use parameter `henum', instead of
11352 global variable `wget_enum_handle'.
11354 * keymap.c (describe_vector): Remove parameters `indices' and
11355 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11356 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11358 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11360 * keyboard.c (timer_check): Remove parameter `do_it_now',
11361 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11362 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11363 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11365 * keyboard.c (read_char):
11366 * w32menu.c (w32_menu_display_help):
11367 * xmenu.c (show_help_event, menu_help_callback):
11368 Adjust calls to `show_help_echo'.
11370 * gtkutil.c (xg_maybe_add_timer):
11371 * keyboard.c (readable_events):
11372 * process.c (wait_reading_process_output):
11373 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11375 * insdel.c (adjust_markers_gap_motion):
11376 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11377 (gap_left, gap_right): Don't call it.
11379 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
11381 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11382 incurred during fontification.
11384 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
11386 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11387 (DEFVAR_PER_BUFFER): Don't pass it.
11389 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11390 (scrolling_window): Don't pass it.
11392 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
11394 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11396 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11398 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11399 of variables specific to SELinux and computation of `encoded_absname'.
11401 * image.c (XPutPixel): Remove unused variable `height'.
11403 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11405 * unexw32.c (get_section_info): Remove unused variable `section'.
11407 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11408 (system_process_attributes): Remove unused variable `sess'.
11409 (sys_read): Remove unused variable `err'.
11411 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11412 (w32_wnd_proc): Remove unused variable `isdead'.
11413 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11414 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11415 (x_create_tip_frame): Remove unused variable `tem'.
11417 * w32inevt.c (w32_console_read_socket):
11418 Remove unused variable `no_events'.
11420 * w32term.c (x_draw_composite_glyph_string_foreground):
11421 Remove unused variable `width'.
11423 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
11425 * w32term.c (x_set_glyph_string_clipping):
11426 Don't pass uninitialized region to CombineRgn.
11428 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
11430 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11431 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11432 (Fx_close_connection): Remove unused variable `i'.
11434 * w32font.c (w32font_draw): Return number of glyphs.
11435 (w32font_open_internal): Remove unused variable `i'.
11436 (w32font_driver): Add missing initializer.
11438 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11439 (fill_in_menu): Remove unused variable `items_added'.
11441 * w32term.c (last_mouse_press_frame): Remove static global variable.
11442 (w32_clip_to_row): Remove unused variable `f'.
11443 (x_delete_terminal): Remove unused variable `i'.
11445 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11446 (NOTHING): Remove unused static global variable.
11447 (uniscribe_check_otf): Remove unused variable `table'.
11448 (uniscribe_font_driver): Add missing initializers.
11450 2011-03-23 Julien Danjou <julien@danjou.info>
11452 * term.c (Fsuspend_tty, Fresume_tty):
11453 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11454 * window.c (temp_output_buffer_show):
11455 * insdel.c (signal_before_change):
11456 * frame.c (Fhandle_switch_frame):
11457 * fileio.c (Fdo_auto_save):
11458 * emacs.c (Fkill_emacs):
11459 * editfns.c (save_excursion_restore):
11460 * cmds.c (internal_self_insert):
11461 * callint.c (Fcall_interactively):
11462 * buffer.c (Fkill_all_local_variables):
11463 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11465 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
11466 unconditionally since it does the check itself.
11468 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
11470 Fix more problems found by GCC 4.5.2's static checks.
11472 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11473 the first time through the loop, since we know p0 < p1 then.
11474 This also avoids a gcc -Wstrict-overflow warning.
11476 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11477 leading to a memory leak, possible in functions like
11478 load_charset_map_from_file that can allocate an unbounded number
11479 of objects (Bug#8318).
11481 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11482 that could (at least in theory) be that large.
11484 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11485 This is less likely to overflow, and avoids undefined behavior if
11486 overflow does occur. All callers changed. Use strtoul to scan
11487 for the unsigned long integer.
11488 (pint2hrstr): Simplify and tune code slightly.
11489 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
11491 * scroll.c (do_scrolling): Work around GCC bug 48228.
11492 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11494 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11495 This also avoids a warning with gcc -Wstrict-overflow.
11496 (validate_x_resource_name): Simplify count usage.
11497 This also avoids a warning with gcc -Wstrict-overflow.
11499 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11502 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
11504 * process.c (Fmake_network_process): Use socklen_t, not int,
11505 where POSIX says socklen_t is required in portable programs.
11506 This fixes a porting bug on hosts like 64-bit HP-UX, where
11507 socklen_t is wider than int (Bug#8277).
11508 (Fmake_network_process, server_accept_connection):
11509 (wait_reading_process_output, read_process_output):
11512 * process.c: Rename or move locals to avoid shadowing.
11513 (list_processes_1, Fmake_network_process):
11514 (read_process_output_error_handler, exec_sentinel_error_handler):
11515 Rename or move locals.
11516 (Fmake_network_process): Define label "retry_connect" only if needed.
11517 (Fnetwork_interface_info): Fix pointer signedness.
11518 (process_send_signal): Add cast to avoid pointer signedness problem.
11519 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
11520 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
11522 Make tparam.h and terminfo.c consistent.
11523 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11524 Include tparam.h instead, since it declares them.
11525 * cm.h (PC): Remove extern decl; tparam.h now does this.
11526 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11527 * terminfo.c: Include tparam.h, to check interfaces.
11528 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11529 (tparam): Adjust signature to match interface in tparam.h;
11530 this removes some undefined behavior. Check that outstring and len
11531 are zero, which they always are with Emacs.
11532 * tparam.h (PC, BC, UP): New extern decls.
11534 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
11535 (xftfont_open): Rename locals to avoid shadowing.
11537 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
11538 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11539 (OTF_TAG_SYM): Omit macro if not needed.
11540 (ftfont_list): Remove unused local.
11541 (get_adstyle_property, ftfont_pattern_entity):
11542 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11543 Rename locals to avoid shadowing.
11545 * xfont.c (xfont_list_family): Mark var as initialized.
11547 * xml.c (make_dom): Now static.
11549 * composite.c (composition_compute_stop_pos): Rename local to
11551 (composition_reseat_it): Remove unused locals.
11552 (find_automatic_composition, composition_adjust_point): Likewise.
11553 (composition_update_it): Mark var as initialized.
11554 (find_automatic_composition): Mark vars as initialized,
11555 with a FIXME (Bug#8290).
11557 character.h: Rename locals to avoid shadowing.
11558 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11559 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11560 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11561 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11562 to avoid shadowing.
11564 * textprop.c (property_change_between_p): Remove; unused.
11566 * intervals.c (interval_start_pos): Now static.
11568 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11570 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11571 Rename locals to avoid shadowing.
11573 * sound.c (wav_play, au_play, Fplay_sound_internal):
11574 Fix pointer signedness.
11575 (alsa_choose_format): Remove unused local var.
11576 (wav_play): Initialize a variable to 0, to prevent undefined
11577 behavior (Bug#8278).
11579 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11581 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11583 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11584 clobbering (Bug#8298).
11585 * sysdep.c (sys_subshell): Likewise.
11586 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
11588 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11589 This should get cleaned up, so that child_setup has the
11590 same signature on all platforms.
11592 * callproc.c (call_process_cleanup): Now static.
11593 (relocate_fd): Rename locals to avoid shadowing.
11595 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
11597 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11598 not to be necessary, and produces flickering.
11600 2011-03-20 Glenn Morris <rgm@gnu.org>
11602 * config.in: Remove file.
11604 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
11606 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11607 are now in src/globals.h.
11608 (syms_of_minibuf): Remove spurious & from previous change.
11610 2011-03-20 Leo Liu <sdl.web@gmail.com>
11612 * minibuf.c (completing-read-function): New variable.
11613 (completing-read-default): Rename from completing-read.
11614 (completing-read): Call completing-read-function.
11616 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11618 * xfaces.c (Fx_load_color_file):
11619 Read color file from absolute filename (bug#8250).
11621 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11623 * makefile.w32-in: Update dependencies.
11625 2011-03-17 Eli Zaretskii <eliz@gnu.org>
11627 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11629 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11631 Fix more problems found by GCC 4.5.2's static checks.
11633 * process.c (make_serial_process_unwind, send_process_trap):
11634 (sigchld_handler): Now static.
11636 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11637 That way, the code declares only the vars that it needs.
11638 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11639 * s/cygwin.h (PTY_ITERATION): Likewise.
11640 * s/darwin.h (PTY_ITERATION): Likewise.
11641 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11643 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11644 * process.c (allocate_pty): Don't declare stb unless it's needed.
11646 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
11647 (CONSTANTLIM): Remove; unused.
11648 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11649 Define only if needed.
11651 * unexelf.c (unexec): Name an expression,
11652 to avoid gcc -Wbad-function-cast warning.
11653 Use a different way to cause a compilation error if anyone uses
11654 n rather than nn, a way that does not involve shadowing.
11655 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
11657 * deps.mk (unexalpha.o): Remove; unused.
11659 New file unexec.h, the (simple) interface for unexec (Bug#8267).
11660 * unexec.h: New file.
11661 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11662 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11663 Depend on unexec.h.
11664 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11665 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11666 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
11667 Change as necessary to match prototype in unexec.h.
11669 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11671 (back_comment, skip_chars): Mark vars as initialized.
11673 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11674 Rename locals to avoid shadowing.
11676 * lread.c (read1): Rewrite so as not to use empty "else".
11677 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
11679 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11681 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11682 warning when compiling print.c.
11684 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11685 instead of using an uninitialized var.
11686 (font_sort_entities): Mark var as initialized.
11688 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11690 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11691 pointers to constants.
11692 (font_parse_fcname): Remove unused vars.
11693 (font_delete_unmatched): Now static.
11694 (font_get_spec): Remove; unused.
11695 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11696 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11697 Rename or move locals to avoid shadowing.
11699 * fns.c (require_nesting_list, require_unwind): Now static.
11700 (Ffillarray): Rename locals to avoid shadowing.
11702 * floatfns.c (domain_error2): Define only if needed.
11703 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
11705 * alloc.c (mark_backtrace): Move decl from here ...
11706 * lisp.h: ... to here, so that it can be checked.
11708 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
11709 (Fdefvar): Rewrite so as not to use empty "else".
11710 (lisp_indirect_variable): Name an expression,
11711 to avoid gcc -Wbad-function-cast warning.
11712 (Fdefvar): Rename locals to avoid shadowing.
11714 * callint.c (quotify_arg, quotify_args): Now static.
11715 (Fcall_interactively): Rename locals to avoid shadowing.
11716 Use const pointer when appropriate.
11718 * lisp.h (get_system_name, get_operating_system_release):
11719 Move decls here, to check interfaces.
11720 * process.c (get_operating_system_release): Move decl to lisp.h.
11721 * xrdb.c (get_system_name): Likewise.
11722 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11723 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11724 some of which prompt warnings from gcc -Wbad-function-cast.
11725 (Fformat_time_string, Fencode_time, Finsert_char):
11726 (Ftranslate_region_internal, Fformat):
11727 Rename or remove local vars to avoid shadowing.
11728 (Ftranslate_region_internal): Mark var as initialized.
11730 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11733 * lisp.h (eassert): Check that the argument compiles, even if
11734 ENABLE_CHECKING is not defined.
11736 * data.c (Findirect_variable): Name an expression, to avoid
11737 gcc -Wbad-function-cast warning.
11738 (default_value, arithcompare, arith_driver, arith_error): Now static.
11739 (store_symval_forwarding): Rename local to avoid shadowing.
11740 (Fmake_variable_buffer_local, Fmake_local_variable):
11741 Mark variables as initialized.
11742 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
11744 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
11745 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11746 Rename locals to avoid shadowing.
11747 (mark_stack): Move local variables into the #ifdef region where
11749 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11750 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11752 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11753 (GC_STRING_CHARS): Remove; not used.
11754 (Fmemory_limit): Cast sbrk's returned value to char *.
11756 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11757 avoids undefined behavior in theory.
11759 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11761 Use functions, not macros, for up- and down-casing (Bug#8254).
11762 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11763 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11764 to use the following functions instead of these macros.
11765 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11766 EMACS_INT, since callers assume the returned value fits in int.
11767 (upcase1): Likewise, for UPCASE_TABLE.
11768 (uppercasep, lowercasep, upcase): New static inline functions.
11769 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
11770 the race-condition problem in the old DOWNCASE.
11772 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11773 Rename locals to avoid shadowing.
11774 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
11775 (regex_compile, re_search_2, re_match_2_internal):
11776 Remove unused local vars.
11777 (FREE_VAR): Rewrite so as not to use empty "else",
11778 which gcc can warn about.
11779 (regex_compile, re_match_2_internal): Mark locals as initialized.
11780 (RETALLOC_IF): Define only if needed.
11781 (WORDCHAR_P): Likewise. This one is never needed, but is used
11782 only in a comment talking about a compiler bug, so put inside
11783 the #if 0 of that comment.
11784 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11785 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11788 * search.c (boyer_moore): Rename locals to avoid shadowing.
11789 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11790 (PREV_CHAR_BOUNDARY): Likewise.
11792 * search.c (simple_search): Remove unused var.
11794 * dired.c (compile_pattern): Move decl from here ...
11795 * lisp.h: ... to here, so that it can be checked.
11796 (struct re_registers): New forward decl.
11798 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11800 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11802 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11803 Rename locals to avoid shadowing.
11804 (Fvertical_motion): Mark locals as initialized.
11806 * casefiddle.c (casify_object, casify_region): Now static.
11807 (casify_region): Mark local as initialized.
11809 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11811 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11812 New macros, so that the caller can use some names other than
11813 gcpro1, gcpro2, etc.
11814 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11816 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11817 argument, for consistency with GCPRO2_VAR, etc: it is now the
11818 prefix of the variable, not the variable itself. All uses
11820 * dired.c (directory_files_internal, file_name_completion):
11821 Rename locals to avoid shadowing.
11823 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11824 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11825 dired.c's scmp function, had undefined behavior.
11826 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11827 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11828 * buffer.h: ... to here, because these macros use current_buffer,
11829 and the new implementation with inline functions needs to have
11830 current_buffer in scope now, rather than later when the macros
11832 (downcase, upcase1): New static inline functions.
11833 (DOWNCASE, UPCASE1): Reimplement using these functions.
11834 This avoids undefined behavior in expressions like
11835 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11836 from race conditions in accessing the global variables
11837 case_temp1 and case_temp2.
11838 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11839 * lisp.h (case_temp1, case_temp2): Remove their decls.
11840 * character.h (ASCII_CHAR_P): Move from here ...
11841 * lisp.h: ... to here, so that the inline functions mentioned
11842 above can use them.
11844 * dired.c (directory_files_internal_unwind): Now static.
11846 * fileio.c (file_name_as_directory, directory_file_name):
11847 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11849 (file_name_as_directory): Use const pointers when appropriate.
11850 (Fexpand_file_name): Likewise. In particular, newdir might
11851 point at constant storage, so make it a const pointer.
11852 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
11853 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11855 (Fset_file_times, Finsert_file_contents, auto_save_error):
11856 Rename locals to avoid shadowing.
11858 * minibuf.c (choose_minibuf_frame_1): Now static.
11859 (Ftry_completion, Fall_completions): Rename or remove locals
11860 to avoid shadowing.
11862 * marker.c (bytepos_to_charpos): Remove; unused.
11864 * lisp.h (verify_bytepos, count_markers): New decls,
11865 so that gcc does not warn that these functions aren't declared.
11867 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11868 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
11869 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
11870 (copy_text): Remove unused local var.
11872 * filelock.c (within_one_second): Now static.
11873 (lock_file_1): Rename local to avoid shadowing.
11875 * buffer.c (fix_overlays_before): Mark locals as initialized.
11876 (fix_start_end_in_overlays): Likewise. This function should be
11877 simplified by using pointers-to-pointers, but that's a different
11879 (switch_to_buffer_1): Now static.
11880 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11881 (report_overlay_modification): Rename locals to avoid shadowing.
11883 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
11884 Fix pointer signedness issue.
11885 (sys_subshell): Mark local as volatile if checking for lint,
11886 to suppress a gcc -Wclobbered warning that does not seem to be right.
11887 (MAXPATHLEN): Define only if needed.
11889 * process.c (serial_open, serial_configure): Move decls from here ...
11890 * systty.h: ... to here, so that they can be checked.
11892 * fns.c (get_random, seed_random): Move extern decls from here ...
11893 * lisp.h: ... to here, so that they can be checked.
11895 * sysdep.c (reset_io): Now static.
11896 (wait_for_termination_signal): Remove; unused.
11898 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11899 (copy_keymap_item, append_key, push_text_char_description):
11901 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
11902 (DENSE_TABLE_SIZE): Remove; unused.
11903 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11904 (describe_map_tree):
11905 Rename locals to avoid shadowing.
11907 * keyboard.c: Declare functions static if they are not used elsewhere.
11908 (echo_char, echo_dash, cmd_error, top_level_2):
11909 (poll_for_input, handle_async_input): Now static.
11910 (read_char, kbd_buffer_get_event, make_lispy_position):
11911 (make_lispy_event, make_lispy_movement, apply_modifiers):
11912 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11913 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11914 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
11915 (read_key_sequence, read_char): Mark locals as initialized.
11916 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
11918 * keyboard.h (make_ctrl_char): New decl.
11919 (mark_kboards): Move decl here ...
11920 * alloc.c (mark_kboards): ... from here.
11922 * lisp.h (force_auto_save_soon): New decl.
11924 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
11925 (DEFINE_DUMMY_FUNCTION): New macro.
11926 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11928 (main): Add casts to avoid warnings
11929 if GCC considers string literals to be constants.
11931 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11933 * dbusbind.c: Pointer signedness fixes.
11934 (xd_signature, xd_append_arg, xd_initialize):
11935 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11936 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11937 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11938 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11940 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11941 if GCC considers string literals to be constants.
11942 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
11944 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11946 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11947 (print_preprocess, print_object): New macro to fix last change.
11949 * print.c (print_preprocess): Don't forget font objects.
11951 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
11953 * emacs.c (USAGE3): Doc fixes.
11955 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11957 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11960 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
11962 * lisp.h (VWindow_system, Qfile_name_history):
11963 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11964 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11965 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11967 * w32select.c: Don't #include "keyboard.h".
11968 (run_protected): Add extern declaration for waiting_for_input.
11970 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11971 * w32console.c (detect_input_pending, read_input_pending)
11972 (encode_terminal_code):
11973 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11974 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11975 (w32_system_caret_y, Qfile_name_history):
11976 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11977 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11978 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11979 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11980 * w32proc.c (Qlocal, report_file_error):
11981 * w32term.c (Vwindow_system, updating_frame):
11982 * w32uniscribe.c (initialized, uniscribe_font_driver):
11983 Remove unneeded extern declarations.
11985 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
11987 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
11989 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
11991 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11992 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11993 These macros can no longer be used for assignment.
11995 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11996 Assign struct members directly, instead of using BUF_BEGV etc.
11997 (record_buffer_markers, fetch_buffer_markers): New functions for
11998 recording and fetching special buffer markers.
11999 (set_buffer_internal_1, set_buffer_temp): Use them.
12001 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12003 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12005 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12006 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12008 * xdisp.c (hscroll_window_tree):
12009 (reconsider_clip_changes): Use PT instead of BUF_PT.
12011 2011-03-13 Eli Zaretskii <eliz@gnu.org>
12013 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12014 $(EMACS_ROOT)/lib/intprops.h.
12016 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12018 Fix more problems found by GCC 4.5.2's static checks.
12020 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12021 to unsigned char * to avoid compiler diagnostic.
12022 (xg_free_frame_widgets): Make it clear that a local variable is
12023 needed only if USE_GTK_TOOLTIP.
12024 (gdk_window_get_screen): Make it clear that this macro is needed
12025 only if USE_GTK_TOOLTIP.
12026 (int_gtk_range_get_value): New function, which avoids a diagnostic
12027 from gcc -Wbad-function-cast.
12028 (xg_set_toolkit_scroll_bar_thumb): Use it.
12029 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12030 diagnostic from gcc -Wbad-function-cast.
12031 (get_utf8_string, xg_get_file_with_chooser):
12032 Rename locals to avoid shadowing.
12033 (create_dialog): Move locals to avoid shadowing.
12035 * xgselect.c (xg_select): Remove unused var.
12037 * image.c (four_corners_best): Mark locals as initialized.
12038 (gif_load): Initialize transparent_p to zero (Bug#8238).
12039 Mark another local as initialized.
12040 (my_png_error, my_error_exit): Mark with NO_RETURN.
12042 * image.c (clear_image_cache): Now static.
12043 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
12044 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
12045 (x_edge_detection): Remove unnecessary cast that
12046 gcc -Wbad-function-cast diagnoses.
12047 (gif_load): Fix pointer signedness.
12048 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12049 (jpeg_load, gif_load): Rename locals to avoid shadowing.
12051 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
12053 Improve quality of tests for time stamp overflow.
12054 For example, without this patch (encode-time 0 0 0 1 1
12055 1152921504606846976) returns the obviously-bogus value (-948597
12056 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12057 reports time overflow. See
12058 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
12059 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12060 * editfns.c: Include limits.h and intprops.h.
12061 (TIME_T_MIN, TIME_T_MAX): New macros.
12062 (time_overflow): Move earlier, to before first use.
12063 (hi_time, lo_time): New functions, for an accurate test for
12064 out-of-range times.
12065 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12066 (Fget_internal_run_time): Don't assume time_t fits in int.
12067 (make_time): Use list2 instead of Fcons twice.
12068 (Fdecode_time): More accurate test for out-of-range times.
12069 (check_tm_member): New function.
12070 (Fencode_time): Use it, to test for out-of-range times.
12071 (lisp_time_argument): Don't rely on undefined left-shift and
12072 right-shift behavior when checking for time stamp overflow.
12074 * editfns.c (time_overflow): New function, refactoring common code.
12075 (Fformat_time_string, Fdecode_time, Fencode_time):
12076 (Fcurrent_time_string): Use it.
12078 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12079 * dired.c (make_time): Move to ...
12080 * editfns.c (make_time): ... here.
12081 * systime.h: Note the move.
12083 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12085 * fringe.c (update_window_fringes): Remove unused variables.
12087 * unexmacosx.c (copy_data_segment): Also copy __got section.
12090 2011-03-12 Eli Zaretskii <eliz@gnu.org>
12092 * termcap.c [MSDOS]: Include "msdos.h".
12093 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12094 Constify `char *' arguments and their references according to
12095 prototypes in tparam.h.
12097 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
12099 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12100 Adapt all references accordingly.
12102 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12104 2011-03-11 Tom Tromey <tromey@redhat.com>
12106 * buffer.c (syms_of_buffer): Remove obsolete comment.
12108 2011-03-11 Eli Zaretskii <eliz@gnu.org>
12110 * termhooks.h (encode_terminal_code): Declare prototype.
12112 * msdos.c (encode_terminal_code): Don't declare prototype.
12114 * term.c (encode_terminal_code): Now external again, used by
12115 w32console.c and msdos.c.
12117 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12118 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
12120 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
12122 Fix some minor problems found by GCC 4.5.2's static checks.
12124 * fringe.c (update_window_fringes): Mark locals as initialized
12126 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
12128 * alloc.c (mark_fringe_data): Move decl from here ...
12129 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12130 to check its interface.
12131 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12133 * fontset.c (free_realized_fontset): Now static.
12134 (Fset_fontset_font): Rename local to avoid shadowing.
12135 (fontset_font): Mark local as initialized.
12136 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
12138 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12140 * xselect.c (x_disown_buffer_selections): Remove; not used.
12141 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
12142 (x_own_selection, Fx_disown_selection_internal): Rename locals
12143 to avoid shadowing.
12144 (x_handle_dnd_message): Remove local to avoid shadowing.
12146 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12147 so that the caller can use some name other than gcpro1.
12148 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
12149 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12150 (Fx_backspace_delete_keys_p):
12151 Use them to avoid shadowing, and rename vars to avoid shadowing.
12152 (x_decode_color, x_set_name, x_window): Now static.
12153 (Fx_create_frame): Add braces to silence GCC warning.
12154 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
12155 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12156 Remove unused locals.
12157 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12158 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12159 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12162 * xterm.h (x_mouse_leave): New decl.
12164 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12165 Remove unused functions.
12166 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12167 (x_calc_absolute_position): Now static.
12168 (XTread_socket): Don't define label "out" unless it's used.
12169 Don't declare local "event" unless it's used.
12170 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12171 unless they are used.
12172 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12173 (x_fatal_error_signal): Remove; not used.
12174 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12175 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12176 (x_error_catcher, x_connection_closed, x_error_handler):
12177 (x_error_quitter, xembed_send_message, x_iconify_frame):
12178 (my_log_handler): Rename locals to avoid shadowing.
12179 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
12180 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
12182 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12183 Rename or move locals to avoid shadowing.
12184 (tty_defined_color, merge_face_heights): Now static.
12185 (free_realized_faces_for_fontset): Remove; not used.
12186 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12187 does not deduce is never used uninitialized.
12188 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12189 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
12191 * terminal.c (store_terminal_param): Now static.
12193 * xmenu.c (menu_highlight_callback): Now static.
12194 (set_frame_menubar): Remove unused local.
12195 (xmenu_show): Rename parameter to avoid shadowing.
12196 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12197 since they might point to immutable storage.
12198 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12199 since it's unused otherwise.
12201 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
12202 Add a FIXME, since the code still doesn't look right. (Bug#8215)
12203 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12204 avoids a gcc -Wuninitialized diagnostic.
12205 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
12206 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12207 does not deduce are never used uninitialized.
12209 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12211 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
12212 * window.c (window_loop, size_window):
12213 (run_window_configuration_change_hook, enlarge_window): Likewise.
12215 * window.c (display_buffer): Now static.
12216 (size_window): Mark variables that gcc -Wuninitialized
12217 does not deduce are never used uninitialized.
12218 * window.h (check_all_windows): New decl, to forestall
12219 gcc -Wmissing-prototypes diagnostic.
12220 * dispextern.h (bidi_dump_cached_states): Likewise.
12222 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12224 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
12225 Include <limits.h>.
12226 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12227 and to avoid gcc -Wuninitialized warning.
12228 (load_charset_map): Mark variables that gcc -Wuninitialized
12229 does not deduce are never used uninitialized.
12230 (load_charset): Abort instead of using uninitialized var (Bug#8229).
12232 * coding.c (coding_set_source, coding_set_destination):
12233 Use "else { /* comment */ }" rather than "else /* comment */;"
12234 for clarity, and to avoid gcc -Wempty-body warning.
12235 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12236 a block, when the outer 'i' will do.
12237 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12238 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12239 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12240 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12241 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12242 Rename locals to avoid shadowing.
12243 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
12244 * coding.c (emacs_mule_char, encode_invocation_designation):
12245 Now static, since they're not used elsewhere.
12246 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
12247 (decode_coding_object, encode_coding_object, detect_coding_system):
12248 (decode_coding_emacs_mule): Mark variables that gcc
12249 -Wuninitialized does not deduce are never used uninitialized.
12250 (detect_coding_iso_2022): Initialize a local variable that might
12251 be used uninitialized. Leave a FIXME because it's not clear that
12252 this initialization is needed. (Bug#8211)
12253 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12254 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12255 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12256 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12257 Remove unused macros.
12259 * category.c (hash_get_category_set): Remove unused local var.
12260 (copy_category_table): Now static, since it's not used elsewhere.
12261 * character.c (string_count_byte8): Likewise.
12263 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12264 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12266 * chartab.c (copy_sub_char_table): Now static, since it's not used
12268 (sub_char_table_ref_and_range, char_table_ref_and_range):
12269 Rename locals to avoid shadowing.
12270 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
12272 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
12273 (BIDI_BOB): Remove unused macro.
12275 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12276 deduce are never used uninitialized.
12277 * term.c (encode_terminal_code): Likewise.
12279 * term.c (encode_terminal_code): Now static. Remove unused local.
12281 * tparam.h: New file.
12282 * term.c, tparam.h: Include it.
12283 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12284 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12285 Move these decls to tparam.h, and make them agree with what
12286 is actually in tparam.c. The previous trick of using incompatible
12287 decls in different modules does not conform to the C standard.
12288 All callers of tparam changed to use tparam's actual API.
12289 * tparam.c (tparam1, tparam, tgoto):
12290 Use const pointers where appropriate.
12292 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12293 * cm.h (struct cm): Likewise.
12294 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12295 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12296 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12297 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12298 (turn_on_face, init_tty): Likewise.
12299 * termchar.h (struct tty_display_info): Likewise.
12301 * term.c (term_mouse_position): Rename local to avoid shadowing.
12303 * alloc.c (mark_ttys): Move decl from here ...
12304 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12306 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12308 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12310 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
12312 * search.c (compile_pattern_1): Remove argument regp, unused since
12313 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12314 (compile_pattern): Don't pass it.
12316 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12318 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12319 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12321 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12323 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12325 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12326 gdk_window_get_screen, gdk_window_get_geometry,
12327 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12328 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12329 (xg_get_pixbuf_from_pixmap): New function.
12330 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12331 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12332 Call xg_get_pixbuf_from_pixmap instead of
12333 gdk_pixbuf_get_from_drawable.
12334 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12335 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12336 (xg_check_special_colors): Use GtkStyleContext and its functions
12338 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12339 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12340 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
12341 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12342 Call gtk_widget_get_preferred_size.
12343 (xg_frame_resized): gdk_window_get_geometry only takes 5
12345 (xg_win_to_widget, xg_event_is_for_menubar):
12346 Call gdk_x11_window_lookup_for_display.
12347 (xg_set_widget_bg): New function.
12348 (delete_cb): New function.
12349 (xg_create_frame_widgets): Connect delete-event to delete_cb.
12350 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
12351 (xg_set_background_color): Call xg_set_widget_bg.
12352 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12353 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12354 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12355 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12357 (update_frame_tool_bar): Call gtk_widget_hide.
12358 (xg_initialize): Use GDK_KEY_g.
12360 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12362 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12364 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12365 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12366 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12368 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
12370 * w32xfns.c (select_palette): Check success of RealizePalette against
12371 GDI_ERROR, not zero.
12373 See ChangeLog.11 for earlier changes.
12375 ;; Local Variables:
12379 Copyright (C) 2011-2012 Free Software Foundation, Inc.
12381 This file is part of GNU Emacs.
12383 GNU Emacs is free software: you can redistribute it and/or modify
12384 it under the terms of the GNU General Public License as published by
12385 the Free Software Foundation, either version 3 of the License, or
12386 (at your option) any later version.
12388 GNU Emacs is distributed in the hope that it will be useful,
12389 but WITHOUT ANY WARRANTY; without even the implied warranty of
12390 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12391 GNU General Public License for more details.
12393 You should have received a copy of the GNU General Public License
12394 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.