1 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5 Make identifiers static if they are not used in other modules.
6 * data.c (Qcompiled_function, Qframe, Qvector):
7 * image.c (QimageMagick, Qsvg):
8 * minibuf.c (Qmetadata):
9 * window.c (resize_window_check, resize_root_window): Now static.
10 * window.h (resize_window_check, resize_root_window): Remove decls.
12 * window.c: Fix minor problems reported by GCC 4.6.0.
13 (window_deletion_count, delete_deletable_window): Remove; unused.
14 (window_body_lines): Now static.
15 (Fdelete_other_windows_internal): Mark vars as initialized.
16 Make sure 'resize_failed' is initialized.
17 (run_window_configuration_change_hook): Rename local to avoid shadowing.
18 (resize_window_apply): Remove unused local.
19 * window.h (delete_deletable_window): Remove decl.
21 * image.c: Fix minor problems reported by GCC 4.6.0.
22 (gif_load, svg_load_image): Rename locals to avoid shadowing.
23 (imagemagick_load_image): Fix pointer signedness problem by changing
24 last arg from unsigned char * to char *. All uses changed.
25 Also, fix a local for similar reasons.
26 Remove unused locals. Remove locals to avoid shadowing.
27 (fn_rsvg_handle_free): Remove; unused.
28 (svg_load, svg_load_image): Fix pointer signedness problem.
29 (imagemagick_load_image): Don't use garbage pointer image_wand.
31 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
33 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
35 * image.c (gif_load): Fix omitted cast error introduced by
38 2011-06-10 Martin Rudalics <rudalics@gmx.at>
40 * window.h (resize_proportionally, orig_total_lines)
41 (orig_top_line): Remove from window structure.
42 (set_window_height, set_window_width, change_window_heights)
43 (Fdelete_window): Remove prototypes.
44 (resize_frame_windows): Remove duplicate declaration.
46 2011-06-10 Eli Zaretskii <eliz@gnu.org>
48 * window.h (resize_frame_windows, resize_window_check)
49 (delete_deletable_window, resize_root_window)
50 (resize_frame_windows): Declare prototypes.
52 * window.c (resize_window_apply): Make definition be "static" to
55 2011-06-10 Martin Rudalics <rudalics@gmx.at>
57 * window.c: Remove declarations of Qwindow_size_fixed,
58 window_min_size_1, window_min_size_2, window_min_size,
59 size_window, window_fixed_size_p, enlarge_window, delete_window.
60 Remove static from declaration of Qdelete_window, it's
61 temporarily needed by Fbury_buffer.
62 (replace_window): Don't assign orig_top_line and
64 (Fdelete_window, delete_window): Remove. Window deletion is
66 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
67 Fdelete_window calls with calls to Qdelete_window.
68 (Fdelete_other_windows): Remove. Deleting other windows is
70 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
72 (window_min_size_2, window_min_size_1, window_min_size): Remove.
73 Window minimum sizes are handled in window.el.
74 (shrink_windows, size_window, set_window_height)
75 (set_window_width, change_window_heights, window_height)
76 (window_width, CURBEG, CURSIZE, enlarge_window)
77 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
78 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
80 (make_dummy_parent): Rename to make_parent_window and give it a
81 second argument horflag.
82 (make_window): Don't set resize_proportionally any more.
83 (Fsplit_window): Remove. Windows are split in window.el.
84 (save_restore_action, save_restore_orig_size)
85 (shrink_window_lowest_first, save_restore_orig_size): Remove.
86 Resize mini windows in window.el.
87 (grow_mini_window, shrink_mini_window): Implement by calling
88 Qresize_root_window_vertically, resize_window_check and
90 (saved_window, Fset_window_configuration, save_window_save): Do
91 not handle orig_top_line, orig_total_lines, and
92 resize_proportionally.
93 (window_min_height, window_min_width): Move to window.el.
94 (keys_of_window): Move bindings for delete-other-windows,
95 split-window, delete-window and enlarge-window to window.el.
97 * buffer.c: Temporarily extern Qdelete_window.
98 (Fbury_buffer): Temporarily call Qdelete_window instead of
99 Fdelete_window (Fbury_buffer will move to window.el soon).
101 * frame.c (set_menu_bar_lines_1): Remove code handling
102 orig_top_line and orig_total_lines.
104 * dispnew.c (adjust_frame_glyphs_initially): Don't use
105 set_window_height but set heights directly.
106 (change_frame_size_1): Use resize_frame_windows.
108 * xdisp.c (init_xdisp): Don't use set_window_height but set
111 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
112 resize_frame_windows instead of change_window_heights and run
113 run_window_configuration_change_hook.
115 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
116 instead of change_window_heights and run
117 run_window_configuration_change_hook.
119 2011-06-09 Martin Rudalics <rudalics@gmx.at>
121 * window.c (replace_window): Rename second argument REPLACEMENT to
122 NEW. New third argument SETFLAG. Rewrite.
123 (delete_window, make_dummy_parent): Call replace_window with
125 (window_list_1): Move down in code.
126 (run_window_configuration_change_hook): Move set_buffer part
127 before select_frame_norecord part in order to unwind correctly.
128 Rename count1 to count.
129 (recombine_windows, delete_deletable_window, resize_root_window)
130 (Fdelete_other_windows_internal)
131 (Frun_window_configuration_change_hook, make_parent_window)
132 (resize_window_check, resize_window_apply, Fresize_window_apply)
133 (resize_frame_windows, Fsplit_window_internal)
134 (Fdelete_window_internal, Fresize_mini_window_internal): New
136 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
138 2011-06-08 Martin Rudalics <rudalics@gmx.at>
140 * window.h (window): Add some new members to window structure -
141 normal_lines, normal_cols, new_total, new_normal, clone_number,
142 splits, nest, prev_buffers, next_buffers.
143 (WINDOW_TOTAL_SIZE): Move here from window.c.
144 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
146 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
148 (make_dummy_parent): Set new members of windows structure.
149 (make_window): Move down in code. Handle new members of window
151 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
152 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
153 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
154 (Fset_window_prev_buffers, Fwindow_next_buffers)
155 (Fset_window_next_buffers, Fset_window_clone_number): New
157 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
158 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
160 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
161 Argument WINDOW can be now internal window too.
162 (Fwindow_use_time): Move up in code.
163 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
165 (Fset_window_configuration, saved_window)
166 (Fcurrent_window_configuration, save_window_save): Handle new
167 members of window structure.
168 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
169 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
170 (syms_of_window): New Lisp objects Qrecord_window_buffer,
171 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
172 Qget_mru_window, Qresize_root_window,
173 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
174 Qauto_buffer_name; staticpro them.
176 2011-06-07 Martin Rudalics <rudalics@gmx.at>
178 * window.c (Fwindow_total_size, Fwindow_left_column)
179 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
180 (Fwindow_list_1): New functions.
181 (window_box_text_cols): Replace with window_body_cols.
182 (Fwindow_width, Fscroll_left, Fscroll_right): Use
183 window_body_cols instead of window_box_text_cols.
184 (delete_window, Fset_window_configuration): Call
185 delete_all_subwindows with window as argument.
186 (delete_all_subwindows): Take a window as argument and not a
188 (window_loop): Remove handling of GET_LRU_WINDOW and
190 (Fget_lru_window, Fget_largest_window): Move to window.el.
192 * window.h: Extern window_body_cols instead of
193 window_box_text_cols. delete_all_subwindows now takes a
194 Lisp_Object as argument.
196 * indent.c (compute_motion, Fcompute_motion): Use
197 window_body_cols instead of window_box_text_cols.
199 * frame.c (delete_frame): Call delete_all_subwindows with root
202 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
204 * fns.c (Fputhash): Document return value.
206 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
208 * image.c (gif_load): Implement gif89a spec "no disposal" method.
210 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
212 Cons<->int and similar integer overflow fixes (Bug#8794).
214 Check for overflow when converting integer to cons and back.
215 * charset.c (Fdefine_charset_internal, Fdecode_char):
216 Use cons_to_unsigned to catch overflow.
217 (Fencode_char): Use INTEGER_TO_CONS.
218 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
219 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
220 * data.c (long_to_cons, cons_to_long): Remove.
221 (cons_to_unsigned, cons_to_signed): New functions.
222 These signal an error for invalid or out-of-range values.
223 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
224 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
225 * font.c (Ffont_variation_glyphs):
226 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
227 * lisp.h: Include <intprops.h>.
228 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
229 (cons_to_signed, cons_to_unsigned): New decls.
230 (long_to_cons, cons_to_long): Remove decls.
231 * undo.c (record_first_change): Use INTEGER_TO_CONS.
232 (Fprimitive_undo): Use CONS_TO_INTEGER.
233 * xfns.c (Fx_window_property): Likewise.
234 * xselect.c: Include <limits.h>.
235 (x_own_selection, selection_data_to_lisp_data):
237 (x_handle_selection_request, x_handle_selection_clear)
238 (x_get_foreign_selection, Fx_disown_selection_internal)
239 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
240 (lisp_data_to_selection_data): Use cons_to_unsigned.
241 (x_fill_property_data): Use cons_to_signed.
242 Report values out of range.
244 Check for buffer and string overflow more precisely.
245 * buffer.h (BUF_BYTES_MAX): New macro.
246 * lisp.h (STRING_BYTES_MAX): New macro.
247 * alloc.c (Fmake_string):
248 * character.c (string_escape_byte8):
249 * coding.c (coding_alloc_by_realloc):
251 * editfns.c (Fformat):
253 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
254 since they may not be the same number.
255 * editfns.c (Finsert_char):
256 * fileio.c (Finsert_file_contents):
257 Likewise for BUF_BYTES_MAX.
259 * image.c: Use ptrdiff_t, not int, for sizes.
260 (slurp_file): Switch from int to ptrdiff_t.
262 (slurp_file): Check that file size fits in both size_t (for
263 malloc) and ptrdiff_t (for sanity and safety).
265 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
266 if b->modtime has its maximal value.
268 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
270 Don't assume time_t can fit into int.
271 * buffer.h (struct buffer.modtime): Now time_t, not int.
272 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
273 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
275 Minor fixes for signed vs unsigned integers.
276 * character.h (MAYBE_UNIFY_CHAR):
277 * charset.c (maybe_unify_char):
278 * keyboard.c (read_char, reorder_modifiers):
279 XINT -> XFASTINT, since the integer must be nonnegative.
280 * ftfont.c (ftfont_spec_pattern):
281 * keymap.c (access_keymap, silly_event_symbol_error):
282 XUINT -> XFASTINT, since the integer must be nonnegative.
283 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
284 since it makes no difference and we prefer signed.
285 * keyboard.c (record_char): Use XUINT when all the neighbors do.
286 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
289 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
291 * window.h (Fwindow_frame): Declare.
293 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
295 * alloc.c: Simplify handling of large-request failures (Bug#8800).
296 (SPARE_MEMORY): Always define.
297 (LARGE_REQUEST): Remove.
298 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
300 2011-06-06 Martin Rudalics <rudalics@gmx.at>
302 * lisp.h: Move EXFUNS for Fframe_root_window,
303 Fframe_first_window and Fset_frame_selected_window to window.h.
305 * window.h: Move EXFUNS for Fframe_root_window,
306 Fframe_first_window and Fset_frame_selected_window here from
309 * frame.c (Fwindow_frame, Fframe_first_window)
310 (Fframe_root_window, Fframe_selected_window)
311 (Fset_frame_selected_window): Move to window.c.
312 (Factive_minibuffer_window): Move to minibuf.c.
313 (Fother_visible_frames_p): New function.
315 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
317 * window.c (decode_window, decode_any_window): Move up in code.
318 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
319 (inhibit_frame_unsplittable): Remove unused variable.
320 (Fwindow_buffer): Move up and rewrite doc-string.
321 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
322 (Fwindow_prev): New functions.
323 (Fwindow_frame): Move here from frame.c. Accept any window as
325 (Fframe_root_window, Fframe_first_window)
326 (Fframe_selected_window): Move here from frame.c. Accept frame
327 or arbitrary window as argument. Update doc-strings.
328 (Fminibuffer_window): Move up in code.
329 (Fwindow_minibuffer_p): Move up in code and simplify.
330 (Fset_frame_selected_window): Move here from frame.c.
332 (Fselected_window, select_window, Fselect_window): Move up in
333 code. Minor doc-string fixes.
335 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
337 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
338 Do not assume that spare memory exists; that assumption is valid
339 only if SYSTEM_MALLOC.
340 (LARGE_REQUEST): New macro, so that the issue of large requests
341 is separated from the issue of spare memory.
343 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
345 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
348 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
350 * xfns.c (x_set_scroll_bar_default_width): Move declarations
353 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
355 * gtkutil.c (xg_get_default_scrollbar_width): New function.
357 * gtkutil.h: Declare xg_get_default_scrollbar_width.
359 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
360 min width by calling x_set_scroll_bar_default_width (Bug#8505).
362 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
364 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
366 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
368 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
369 (x_clipboard_manager_save): Add return value.
370 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
372 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
373 Obey Vx_select_enable_clipboard_manager. Catch errors in
374 x_clipboard_manager_save (Bug#8779).
375 (Vx_select_enable_clipboard_manager): New variable.
376 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
378 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
380 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
382 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
384 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
385 in the current matrix if keep_current_p is non-zero.
387 2011-06-04 Eli Zaretskii <eliz@gnu.org>
389 * bidi.c (bidi_level_of_next_char): Fix last change.
391 2011-06-03 Eli Zaretskii <eliz@gnu.org>
393 Support bidi reordering of text covered by display properties.
395 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
396 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
397 (bidi_cache_search, bidi_cache_iterator_state)
398 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
399 (bidi_level_of_next_char, bidi_move_to_visually_next):
400 Support character positions inside a run of characters covered by a
402 (bidi_paragraph_init, bidi_resolve_explicit_1)
403 (bidi_level_of_next_char): Call bidi_fetch_char and
404 bidi_fetch_char_advance instead of FETCH_CHAR and
406 (bidi_init_it): Initialize new members.
407 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
409 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
410 instead of using explicit *_CHAR codes.
411 (bidi_resolve_explicit, bidi_resolve_weak):
412 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
413 bidirectional text is supported only in multibyte buffers.
414 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
415 it to initialize the frame_window_p member of struct bidi_it.
416 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
417 (bidi_resolve_explicit, bidi_resolve_weak)
418 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
419 bidi_it->nchars is non-positive.
420 (bidi_level_of_next_char): Don't try to lookup the cache for the
421 next/previous character if nothing is cached there yet, or if we
422 were just reseat()'ed to a new position.
424 * xdisp.c (set_cursor_from_row): Set start and stop points
425 according to the row's direction when priming the loop that looks
426 for the glyph on which to display cursor.
427 (single_display_spec_intangible_p): Function deleted.
428 (display_prop_intangible_p): Reimplement to call
429 handle_display_spec instead of single_display_spec_intangible_p.
430 Accept 3 additional arguments needed by handle_display_spec.
431 This fixes incorrect cursor motion across display property with complex
432 values: lists, `(when COND...)' forms, etc.
433 (single_display_spec_string_p): Support property values that are
434 lists with the argument STRING its top-level element.
435 (display_prop_string_p): Fix the condition for processing a
436 property that is a list to be consistent with handle_display_spec.
437 (handle_display_spec): New function, refactored from the
438 last portion of handle_display_prop.
439 (compute_display_string_pos): Accept additional argument
440 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
441 value of a `display' property is a "replacing spec".
442 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
443 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
444 the display property, but just return a value indicating whether
445 the display property will replace the characters it covers.
446 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
447 frame_window_p members of struct bidi_it.
448 (compute_display_string_pos, compute_display_string_end):
450 (push_it): Accept second argument POSITION, where pop_it should
451 jump to continue iteration.
452 (reseat_1): Initialize bidi_it.disp_pos.
454 * keyboard.c (adjust_point_for_property): Adjust the call to
455 display_prop_intangible_p to its new signature.
457 * dispextern.h (struct bidi_it): New member frame_window_p.
458 (bidi_init_it): Update prototypes.
459 (display_prop_intangible_p): Update prototype.
460 (compute_display_string_pos, compute_display_string_end):
462 (struct bidi_it): New members nchars and disp_pos. ch_len is now
465 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
467 Malloc failure behavior now depends on size of allocation.
468 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
469 * lisp.h: Change signatures accordingly.
470 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
471 All callers changed. (Bug#8762)
473 * gnutls.c: Use Emacs's memory allocators.
474 Without this change, the gnutls library would invoke malloc etc.
475 directly, which causes problems on non-SYNC_INPUT hosts, and which
476 runs afoul of improving memory_full behavior. (Bug#8761)
477 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
478 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
479 xfree instead of the default malloc, realloc, free.
480 (Fgnutls_boot): No need to check for memory allocation failure,
481 since xmalloc does that for us.
483 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
484 * category.c (hash_get_category_set):
485 * ccl.c (ccl_driver):
486 * charset.c (Fdefine_charset_internal):
487 * charset.h (struct charset.hash_index):
488 * composite.c (get_composition_id, gstring_lookup_cache)
489 (composition_gstring_put_cache):
490 * composite.h (struct composition.hash_index):
491 * dispextern.h (struct image.hash):
492 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
493 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
494 (hashfn_equal, hashfn_user_defined, make_hash_table)
495 (maybe_resize_hash_table, hash_lookup, hash_put)
496 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
497 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
498 (Fsxhash, Fgethash, Fputhash, Fmaphash):
499 * image.c (make_image, search_image_cache, lookup_image)
500 (xpm_put_color_table_h):
501 * lisp.h (struct Lisp_Hash_Table):
502 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
503 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
504 for hashes and hash indexes, instead of 'unsigned' and 'int'.
505 * alloc.c (allocate_vectorlike):
506 Check for overflow in vector size calculations.
507 * ccl.c (ccl_driver):
508 Check for overflow when converting EMACS_INT to int.
509 * fns.c, image.c: Remove unnecessary static decls that would otherwise
510 need to be updated by these changes.
511 * fns.c (make_hash_table, maybe_resize_hash_table):
512 Check for integer overflow with large hash tables.
513 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
514 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
515 (SXHASH_REDUCE): New macro.
516 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
517 Use it instead of discarding useful hash info with large hash values.
518 (sxhash_float): New function.
519 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
520 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
521 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
522 Rewrite to use FIXNUM_BITS, as this simplifies things.
523 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
524 Adjust signatures to match updated version of code.
525 (consing_since_gc): Now EMACS_INT, since a single hash table can
526 use more than INT_MAX bytes.
528 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
530 Make it possible to build with GCC-4.6+ -O2 -flto.
532 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
534 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
536 * minibuf.c (get_minibuffer, read_minibuf_unwind):
537 Call minibuffer-inactive-mode.
539 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
541 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
544 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
546 * data.c (init_data): Remove code for UTS, this system is not
549 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
551 Don't force ./temacs to start in terminal mode.
553 * frame.c (make_initial_frame): Initialize faces in all cases, not
554 only when CANNOT_DUMP is defined.
555 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
557 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
559 * dispnew.c (add_window_display_history): Use const for the string
560 pointer. Remove declaration, not needed.
562 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
564 Use 'inline', not 'INLINE'.
565 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
566 * alloc.c, fontset.c (INLINE): Remove.
567 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
568 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
569 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
570 * gmalloc.c (register_heapinfo): Use inline unconditionally.
571 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
573 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
575 Make it possible to run ./temacs.
577 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
578 syms_of_callproc does the same thing. Remove test for
579 "initialized", do it in the caller.
580 * emacs.c (main): Avoid calling set_initial_environment when dumping.
582 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
584 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
585 (read_minibuf): Use get_minibuffer.
586 (syms_of_minibuf): Use DEFSYM.
587 (Qmetadata): New var.
588 * data.c (Qbuffer): Don't make it static.
589 (syms_of_data): Use DEFSYM.
591 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
593 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
594 (CCL_CODE_MIN): New macro.
596 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
598 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
600 * eval.c (Qdebug): Now static.
601 * lisp.h (Qdebug): Remove decl. This reverts a part of the
602 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
603 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
605 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
607 * image.c: Various fixes to ImageMagick code comments.
608 (Fimagemagick_types): Doc fix.
610 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
612 Minor fixes prompted by GCC 4.6.0 warnings.
614 * xselect.c (converted_selections, conversion_fail_tag): Now static.
616 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
617 (x_clipboard_manager_save_all): Move extern decl to ...
618 * xterm.h: ... here, so that it can be checked for consistency.
620 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
622 * xselect.c (x_clipboard_manager_save_frame)
623 (x_clipboard_manager_save_all): New functions.
624 (Fx_clipboard_manager_save): Lisp function deleted.
626 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
627 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
629 * xterm.h: Update prototype.
631 2011-05-28 William Xu <william.xwl@gmail.com>
633 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
636 2011-05-28 Jim Meyering <meyering@redhat.com>
638 Avoid a sign-extension bug in crypto_hash_function.
639 * fns.c (to_uchar): Define.
640 (crypto_hash_function): Use it to convert some newly-signed
641 variables to unsigned, to avoid sign-extension bugs. For example,
642 without this change, (md5 "truc") would evaluate to
643 45723a2aff78ff4fff7fff1114760e62 rather than the expected
644 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
645 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
647 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
649 Integer overflow fixes.
651 * dbusbind.c: Serial number integer overflow fixes.
652 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
653 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
654 to hold a serial number that is too large for a fixnum.
655 (Fdbus_method_return_internal, Fdbus_method_error_internal):
656 Check for serial numbers out of range. Decode any serial number
657 that was so large that it became a float. (Bug#8722)
659 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
660 (Fdbus_call_method, Fdbus_call_method_asynchronously):
661 Use XFASTINT rather than XUINT when numbers are nonnegative.
662 (xd_append_arg, Fdbus_method_return_internal):
663 (Fdbus_method_error_internal): Likewise. Also, for unsigned
664 arguments, check that Lisp number is nonnegative, rather than
665 silently wrapping negative numbers around. (Bug#8722)
666 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
669 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
671 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
673 ccl: add integer overflow checks
674 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
675 (IN_INT_RANGE): New macros.
676 (ccl_driver): Use them to check for integer overflow when
677 decoding a CCL program. Many of the new checks are whether XINT (x)
678 fits in int; it doesn't always, on 64-bit hosts. The new version
679 doesn't catch all possible integer overflows, but it's an
680 improvement. (Bug#8719)
682 * alloc.c (make_event_array): Use XINT, not XUINT.
683 There's no need for unsigned here.
685 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
686 This follows up to the 2011-05-06 change that substituted uintptr_t
687 for EMACS_INT. This case wasn't caught back then.
689 Rework Fformat to avoid integer overflow issues.
690 * editfns.c: Include <float.h> unconditionally, as it's everywhere
691 now (part of C89). Include <verify.h>.
692 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
693 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
694 (Fformat): Avoid the prepass trying to compute sizes; it was only
695 approximate and thus did not catch overflow reliably. Instead, walk
696 through the format just once, formatting and computing sizes as we go,
697 checking for integer overflow at every step, and allocating a larger
698 buffer as needed. Keep track separately whether the format is
699 multibyte. Keep only the most-recently calculated precision, rather
700 than them all. Record whether each argument has been converted to
701 string. Use EMACS_INT, not int, for byte and char and arg counts.
702 Support field widths and precisions larger than INT_MAX. Avoid
703 sprintf's undefined behavior with conversion specifications such as %#d
704 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
705 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
706 formatting out-of-range floating point numbers with int
709 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
711 * data.c: Avoid integer truncation in expressions involving floats.
712 * data.c: Include <intprops.h>.
713 (arith_driver): When there's an integer overflow in an expression
714 involving floating point, convert the integers to floating point
715 so that the resulting value does not suffer from catastrophic
716 integer truncation. For example, on a 64-bit host (* 4
717 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
718 Do not rely on undefined behavior after integer overflow.
720 merge count_size_as_multibyte, parse_str_to_multibyte
721 * character.c, character.h (count_size_as_multibyte):
722 Rename from parse_str_to_multibyte; all uses changed.
723 Check for integer overflow.
724 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
725 since it's now a duplicate of the other. This is more of
726 a character than a buffer op, so better that it's in character.c.
727 * fns.c, print.c: Adjust to above changes.
729 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
731 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
733 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
735 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
736 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
737 (x_clipboard_manager_save): Now static.
738 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
740 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
741 (crypto_hash_function): Now static.
742 Fix pointer signedness problems. Avoid unnecessary initializations.
744 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
746 * termhooks.h (Vselection_alist): Make it terminal-local.
748 * terminal.c (create_terminal): Initialize it.
750 * xselect.c: Support for clipboard managers.
751 (Vselection_alist): Move to termhooks.h as terminal-local var.
752 (LOCAL_SELECTION): New macro.
753 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
754 (symbol_to_x_atom): Remove gratuitous arg.
755 (x_handle_selection_request, lisp_data_to_selection_data)
756 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
757 (x_own_selection, x_get_local_selection, x_convert_selection):
758 New arg, specifying work frame. Use terminal-local Vselection_alist.
759 (some_frame_on_display): Delete unused function.
760 (Fx_own_selection_internal, Fx_get_selection_internal)
761 (Fx_disown_selection_internal, Fx_selection_owner_p)
762 (Fx_selection_exists_p): New optional frame arg.
763 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
764 (x_handle_selection_clear): Don't treat other terminals with the
765 same keyboard specially. Use the terminal-local Vselection_alist.
766 (x_clear_frame_selections): Use Frun_hook_with_args.
768 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
770 * xterm.h: Add support for those atoms.
772 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
774 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
775 (converted_selections, conversion_fail_tag): New global variables.
776 (x_selection_request_lisp_error): Free the above.
777 (x_get_local_selection): Remove unnecessary code.
778 (x_reply_selection_request): Args changed; handle arbitrary array
779 of converted selections stored in converted_selections.
780 Separate the XChangeProperty and SelectionNotify steps.
781 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
782 (x_convert_selection): New function.
783 (x_handle_selection_event): Simplify.
784 (x_get_foreign_selection): Don't ignore incoming requests while
785 waiting for an answer; this will fail when we implement
786 SAVE_TARGETS, and seems unnecessary anyway.
787 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
788 (Vx_sent_selection_functions): Doc fix.
790 2011-05-26 Leo Liu <sdl.web@gmail.com>
792 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
794 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
796 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
798 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
799 for fringe update if it has periodic bitmap.
800 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
801 and fringe_bitmap_periodic_p.
803 * fringe.c (get_fringe_bitmap_data): New function.
804 (draw_fringe_bitmap_1, update_window_fringes): Use it.
805 (update_window_fringes): Record periodicity of fringe bitmap in glyph
806 row. Mark glyph row for fringe update if periodicity changed.
808 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
809 for fringe update unless it has periodic bitmap.
811 2011-05-25 Kenichi Handa <handa@m17n.org>
813 * xdisp.c (get_next_display_element): Set correct it->face_id for
814 a static composition.
816 2011-05-24 Leo Liu <sdl.web@gmail.com>
819 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
821 * fns.c (crypto_hash_function, Fsha1): New function.
822 (Fmd5): Use crypto_hash_function.
823 (syms_of_fns): Add Ssha1.
825 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
827 * gnutls.c: Remove unused macros.
828 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
829 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
830 Remove macros that are defined and never used.
831 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
833 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
835 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
836 (Fx_get_selection_internal): Minor cleanup.
837 (Fx_own_selection_internal): Rename arguments for consistency with
840 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
842 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
844 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
846 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
848 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
850 * dispnew.c (scrolling_window): Don't exclude the case that the
851 last enabled row in the desired matrix touches the bottom boundary.
853 2011-05-21 Glenn Morris <rgm@gnu.org>
855 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
856 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
857 and add some more files.
859 2011-05-20 Eli Zaretskii <eliz@gnu.org>
861 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
862 report_file_error introduced by the change from 2011-05-07.
864 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
866 * systime.h (Time): Define only if emacs is defined.
867 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
868 where the include path doesn't have X11/X.h by default. See
869 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
871 2011-05-20 Kenichi Handa <handa@m17n.org>
873 * composite.c (find_automatic_composition): Fix previous change.
875 2011-05-20 Glenn Morris <rgm@gnu.org>
877 * lisp.mk: New file, split from Makefile.in.
878 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
880 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
882 2011-05-19 Glenn Morris <rgm@gnu.org>
884 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
885 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
886 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
887 (lisp): Set the order to that of loadup.el.
888 (shortlisp): Make it a copy of $lisp.
889 (SOME_MACHINE_LISP): Remove.
890 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
891 Use just $shortlisp, not $SOME_MACHINE_LISP too.
893 2011-05-18 Kenichi Handa <handa@m17n.org>
895 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
896 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
897 (find_automatic_composition): Mostly rewrite for efficiency.
899 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
901 * makefile.w32-in: Update dependencies.
903 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
905 * menu.c: Include limits.h (fixes the MS-Windows build broken by
908 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
910 Fix some integer overflow issues, such as string length overflow.
912 * insdel.c (count_size_as_multibyte): Check for string overflow.
914 * character.c (lisp_string_width): Check for string overflow.
915 Use EMACS_INT, not int, for string indexes and lengths; in
916 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
917 the resulting string length overflows an EMACS_INT; instead,
918 report a string overflow if no precision given. When checking for
919 precision exhaustion, use a check that cannot possibly have
920 integer overflow. (Bug#8675)
921 * character.h (lisp_string_width): Adjust to new signature.
923 * alloc.c (string_overflow): New function.
924 (Fmake_string): Use it. This doesn't change behavior, but saves
925 a few bytes and will simplify future changes.
926 * character.c (string_escape_byte8): Likewise.
927 * lisp.h (string_overflow): New decl.
929 Fixups, following up to the user-interface timestamp change.
930 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
931 for UI timestamps, instead of unsigned long.
932 * msdos.c (mouse_get_pos): Likewise.
933 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
934 * w32gui.h (Time): Define by including "systime.h" rather than by
935 declaring it ourselves. (Bug#8664)
937 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
938 * image.c (clear_image_cache): Likewise.
940 * term.c (term_mouse_position): Don't assume time_t wraparound.
942 Be more systematic about user-interface timestamps.
943 Before, the code sometimes used 'Time', sometimes 'unsigned long',
944 and sometimes 'EMACS_UINT', to represent these timestamps.
945 This change causes it to use 'Time' uniformly, as that's what X uses.
946 This makes the code easier to follow, and makes it easier to catch
947 integer overflow bugs such as Bug#8664.
948 * frame.c (Fmouse_position, Fmouse_pixel_position):
949 Use Time, not unsigned long, for user-interface timestamps.
950 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
951 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
952 * keyboard.h (last_event_timestamp): Likewise.
953 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
954 * menu.h (xmenu_show): Likewise.
955 * term.c (term_mouse_position): Likewise.
956 * termhooks.h (struct input_event.timestamp): Likewise.
957 (struct terminal.mouse_position_hook): Likewise.
958 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
959 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
960 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
961 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
963 * menu.h, termhooks.h: Include "systime.h", for Time.
965 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
966 Don't assume that the difference between two unsigned long values
967 can fit into an integer. At this point, we know button_down_time
968 <= event->timestamp, so the difference must be nonnegative, so
969 there's no need to cast the result if double-click-time is
970 nonnegative, as it should be; check that it's nonnegative, just in
971 case. This bug is triggered when events are more than 2**31 ms
972 apart (about 25 days). (Bug#8664)
974 * xselect.c (last_event_timestamp): Remove duplicate decl.
975 (x_own_selection): Remove needless cast to unsigned long.
977 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
978 that always fit in int. Use a sentinel instead of a counter, to
979 avoid a temp and to allay GCC's concerns about possible int overflow.
980 * frame.h (struct frame): Use int for menu_bar_items_used
981 instead of EMACS_INT, since it always fits in int.
983 * menu.c (grow_menu_items): Check for int overflow.
985 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
987 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
988 Before, the code was not consistent. These values cannot exceed
989 2**31 - 1 so there's no need to make them unsigned.
990 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
991 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
992 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
994 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
996 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
997 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
998 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
999 presumably because the widths might not match.
1001 * window.c (size_window): Avoid needless test at loop start.
1003 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1005 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1007 2011-05-12 Drew Adams <drew.adams@oracle.com>
1009 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1011 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1013 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1014 `width' to `bar_area_x' and `bar_area_width', respectively.
1015 (x_scroll_run): Take account of fringe background extension.
1017 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1018 Rename local vars `left' and `width' to `bar_area_x' and
1019 `bar_area_width', respectively.
1020 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1021 background extension.
1023 2011-05-10 Jim Meyering <meyering@redhat.com>
1025 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1027 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1029 * image.c (Finit_image_library): Return t for built-in image types,
1030 like pbm and xbm. (Bug#8640)
1032 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1034 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1036 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1038 * w32console.c (Fset_screen_color): Doc fix.
1039 (Fget_screen_color): New function.
1040 (syms_of_ntterm): Defsubr it.
1042 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1043 unlink the temporary file if Fcall_process didn't create it in the
1045 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1046 child process will be redirected to a file specified with `:file'.
1047 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1048 cue to call_process_cleanup not to close that handle.
1050 2011-05-07 Ben Key <bkey76@gmail.com>
1052 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1053 one of two shell specific rules, either bootstrap-temacs-CMD or
1054 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1055 to the previous implementation of the bootstrap-temacs rule.
1056 The bootstrap-temacs-CMD rule is similar to the previous
1057 implementation of the bootstrap-temacs rule except that it
1058 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1061 These changes, along with some changes to nt/configure.bat,
1062 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1063 earlier fix to add support for --cflags and --ldflags options
1064 that include quotes so that it works whether make uses cmd or
1067 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1069 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1070 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1072 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1073 a string. Handle both cases.
1074 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1075 (Fdbus_register_method): Use Qinvalid_function.
1077 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1079 * makefile.w32-in: Update dependencies.
1080 (LISP_H): Add inttypes.h and stdin.h.
1081 (PROCESS_H): Add unistd.h.
1083 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1085 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1086 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1088 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1090 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1092 * term.c (vfatal): Remove stray call to va_end.
1093 It's not needed and the C Standard doesn't allow it here anyway.
1095 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1096 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1098 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1101 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1103 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1105 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1107 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1109 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1111 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1112 * charset.c (Fdefine_charset_internal): Don't initialize
1113 charset.code_space[15]. The value was garbage, on hosts with
1114 32-bit int (Bug#8600).
1116 * lread.c (read_integer): Be more consistent with string-to-number.
1117 Use string_to_number to do the actual conversion; this avoids
1118 rounding errors and fixes some other screwups. Without this fix,
1119 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1120 (digit_to_number): Move earlier, for benefit of read_integer.
1121 Return -1 if the digit is out of range for the base, -2 if it is
1122 not a digit in any supported base. (Bug#8602)
1124 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1126 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1127 to match comment at start of function. This also removes a
1128 GCC warning about overflow in a 32+64-bit port.
1130 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1132 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1133 Reported by Stefan Monnier in
1134 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1135 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1136 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1138 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1139 (EMACS_UINTPTR): Likewise, with uintptr_t.
1141 * lisp.h: Prefer 64-bit EMACS_INT if available.
1142 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1143 on 32-bit hosts that have 64-bit int, so that they can access
1145 However, temporarily disable this change unless the temporary
1146 symbol WIDE_EMACS_INT is defined.
1148 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1150 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1151 This removes an assumption that EMACS_INT and long are the same
1152 width as pointers. The assumption is true for Emacs porting targets
1153 now, but we want to make other targets possible.
1154 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1155 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1156 In the rest of the code, change types of integers that hold casted
1157 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1158 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1159 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1160 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1161 No need to cast type when ORing.
1162 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1163 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1164 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1165 assume EMACS_INT is the same width as char *.
1166 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1167 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1168 Remove no-longer-needed casts.
1169 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1170 (xg_tool_bar_help_callback, xg_make_tool_item):
1171 Use EMACS_INTPTR to hold an integer
1172 that will be cast to void *; this can avoid a GCC warning
1173 if EMACS_INT is not the same width as void *.
1174 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1175 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1176 (current_message_1, set_message_1):
1177 Use a local to convert to proper width without a cast.
1178 * xmenu.c (dialog_selection_callback): Likewise.
1180 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1181 Also, don't assume VALBITS / RAND_BITS is less than 5,
1182 and don't rely on undefined behavior when shifting a 1 left into
1184 * lisp.h (get_random): Change signature to match.
1186 * lread.c (hash_string): Use size_t, not int, for hash computation.
1187 Normally we prefer signed values; but hashing is special, because
1188 it's better to use unsigned division on hash table sizes so that
1189 the remainder is nonnegative. Also, size_t is the natural width
1190 for hashing into memory. The previous code used 'int', which doesn't
1191 retain enough info to hash well into very large tables.
1192 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1194 * dbusbind.c: Don't possibly lose pointer info when converting.
1195 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1196 Use XPNTR rather than XHASH, so that the high-order bits of
1197 the pointer aren't lost when converting through void *.
1199 * eval.c (Fautoload): Don't double-shift a pointer.
1201 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1203 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1205 * gnutls.c (DEF_GNUTLS_FN):
1206 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1208 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1210 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1213 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1215 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1216 New version that can reserve upto 2GB of heap space.
1218 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1220 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1222 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1224 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1225 `gnutls_certificate_set_x509_key_file'.
1227 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1229 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1230 Update dependencies.
1232 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1234 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1235 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1236 Remove unused parameter `fildes'.
1237 * process.c (read_process_output, send_process): Don't pass it.
1239 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1241 Fix previous change: the library cache is defined in w32.c.
1242 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1243 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1245 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1247 Implement dynamic loading of GnuTLS on Windows.
1249 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1250 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1251 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1254 * gnutls.c (Qgnutls_dll): Define.
1255 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1256 (gnutls_*): Declare function pointers.
1257 (init_gnutls_functions): New function to initialize function pointers.
1258 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1259 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1260 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1261 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1262 (emacs_gnutls_write, emacs_gnutls_read)
1263 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1264 (Fgnutls_available_p): New function.
1265 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1266 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1267 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1269 * image.c: Include w32.h.
1270 (Vimage_type_cache): Delete.
1271 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1272 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1273 (w32_delayed_load): Move to w32.c.
1275 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1277 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1278 (w32_delayed_load): Move from image.c. When loading a library, record
1279 its filename in the :loaded-from property of the library id.
1280 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1281 Initialize and staticpro them.
1282 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1284 * process.c: Include lisp.h before w32.h, not after.
1285 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1286 instead of gnutls_record_check_pending.
1288 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1290 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1292 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1293 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1296 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1298 * xterm.c (x_set_frame_alpha): Do not set property on anything
1299 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1301 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1303 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1305 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1307 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1308 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1309 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1310 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1311 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1312 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1313 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1314 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1315 (Qgnutls_bootprop_callbacks_verify): Make static.
1317 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1319 * callproc.c: Indentation fixup.
1321 * sysdep.c (wait_for_termination_1): Make static.
1322 (wait_for_termination, interruptible_wait_for_termination):
1323 Move after wait_for_termination_1.
1325 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1327 * sysdep.c (interruptible_wait_for_termination): New function
1328 which is like wait_for_termination, but allows keyboard
1331 * callproc.c (Fcall_process): Add (:file "file") as an option for
1333 (Fcall_process_region): Ditto.
1335 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1337 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1338 rather than `XVECTOR (FOO)->size'.
1340 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1341 inttypes.h, as a gnulib replacement is used if it not available in
1344 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1346 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1347 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1348 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1350 * coding.c (coding_alloc_by_realloc): Error out if destination
1351 will grow beyond MOST_POSITIVE_FIXNUM.
1352 (decode_coding_emacs_mule): Abort if there isn't enough place in
1353 charbuf for the composition carryover bytes. Reserve an extra
1354 space for up to 2 characters produced in a loop.
1355 (decode_coding_iso_2022): Abort if there isn't enough place in
1356 charbuf for the composition carryover bytes.
1358 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1360 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1361 aborting when %lld or %lll format is passed.
1362 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1363 %llo or %llx format is passed. (Bug#8545)
1365 * window.c (window_scroll_line_based): Use a marker instead of
1366 simple variables to record original value of point. (Bug#7952)
1368 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1369 produced by %s or %c overflows available buffer space. (Bug#8545)
1371 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1373 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1374 (SIZE_MAX): Move defn after all includes, as they might #define it.
1376 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1378 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1380 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1382 * keyboard.c (Qdelayed_warnings_hook): Define.
1383 (command_loop_1): Run `delayed-warnings-hook'
1384 if Vdelayed_warnings_list is non-nil.
1385 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1386 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1388 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1390 * doprnt.c (doprnt): Don't return value smaller than the buffer
1391 size if the message was truncated. (Bug#8545).
1393 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1395 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1396 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1398 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1400 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1402 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1404 * makefile.w32-in: Update dependencies.
1406 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1408 Improve `doprnt' and its usage. (Bug#8545)
1409 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1410 `format_end'. Remove support for %l as a conversion specifier.
1411 Don't use xrealloc. Improve diagnostics when the %l size modifier
1412 is used. Update the commentary.
1414 * eval.c (verror): Simplify calculation of size_t.
1416 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1419 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1421 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1424 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1426 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1427 This makes this file independent of the recent pseudovector change.
1429 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1431 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1433 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1434 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1435 Remove unused local.
1436 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1438 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1439 GCC 4.6.0 optimizes based on type-based alias analysis.
1440 For example, if b is of type struct buffer * and v of type struct
1441 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1442 != &v->size, and therefore "v->size = 1; b->size = 2; return
1443 v->size;" must therefore return 1. This assumption is incorrect
1444 for Emacs, since it type-puns struct Lisp_Vector * with many other
1445 types. To fix this problem, this patch adds a new type struct
1446 vectorlike_header that documents the constraints on layout of vectors
1447 and pseudovectors, and helps optimizing compilers not get fooled
1448 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1449 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1450 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1452 (XSETPVECTYPE): Rewrite in terms of new macro.
1453 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1454 This is a bit clearer, and further avoids the possibility of
1455 undesirable aliasing.
1456 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1457 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1458 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1459 since Lisp_Subr is a special case (no "next" field).
1460 (ASIZE): Now uses header.size rather than size.
1461 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1462 to avoid the hassle of writing XVECTOR (foo)->header.size.
1463 (struct vectorlike_header): New type.
1464 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1465 object, to help avoid aliasing.
1466 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1467 (SUBRP): Likewise, since Lisp_Subr is a special case.
1468 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1469 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1470 (struct Lisp_Hash_Table): Combine first two members into a single
1471 struct vectorlike_header member. All uses of "size" and "next" members
1472 changed to be "header.size" and "header.next".
1473 * buffer.h (struct buffer): Likewise.
1474 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1475 * frame.h (struct frame): Likewise.
1476 * process.h (struct Lisp_Process): Likewise.
1477 * termhooks.h (struct terminal): Likewise.
1478 * window.c (struct save_window_data, struct saved_window): Likewise.
1479 * window.h (struct window): Likewise.
1480 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1481 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1482 * buffer.c (init_buffer_once): Likewise.
1483 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1485 * process.c (Fformat_network_address): Use local var for size,
1488 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1490 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1491 * data.c (atof): Remove decl; no longer used or needed.
1492 (digit_to_number): Move to lread.c.
1493 (Fstring_to_number): Use new string_to_number function, to be
1494 consistent with how the Lisp reader treats infinities and NaNs.
1495 Do not assume that floating-point numbers represent EMACS_INT
1496 without losing information; this is not true on most 64-bit hosts.
1497 Avoid double-rounding errors, by insisting on integers when
1498 parsing non-base-10 numbers, as the documentation specifies.
1499 * lisp.h (string_to_number): New decl, replacing ...
1500 (isfloat_string): Remove.
1501 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1502 (read1): Do not accept +. and -. as integers; this
1503 appears to have been a coding error. Similarly, do not accept
1504 strings like +-1e0 as floating point numbers. Do not report
1505 overflow for integer overflows unless the base is not 10 which
1506 means we have no simple and reliable way to continue.
1507 Break out the floating-point parsing into a new
1508 function string_to_number, so that Fstring_to_number parses
1509 floating point numbers consistently with the Lisp reader.
1510 (digit_to_number): Move here from data.c. Make it static inline.
1511 (E_CHAR, EXP_INT): Remove, replacing with ...
1512 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1513 (string_to_number): New function, replacing isfloat_string.
1514 This function checks for valid syntax and produces the resulting
1515 Lisp float number too. Rework it so that string-to-number
1516 no longer mishandles examples like "1.0e+". Use strtoumax,
1517 so that overflow for non-base-10 numbers is reported only when
1518 there's no portable and simple way to convert to floating point.
1520 * textprop.c (set_text_properties_1): Rewrite for clarity,
1521 and to avoid GCC warning about integer overflow.
1523 * intervals.h (struct interval): Use EMACS_INT for members
1524 where EMACS_UINT might cause problems. See
1525 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1526 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1527 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1529 (offset_intervals): Tell GCC not to worry about length overflow
1530 when negating a negative length.
1532 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1533 (overrun_check_free): Likewise.
1535 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1536 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1539 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1540 (gnutls_make_error): Rename local to avoid shadowing.
1541 (gnutls_emacs_global_deinit): ifdef out; not used.
1542 (Fgnutls_boot): Use const for pointer to readonly storage.
1543 Comment out unused local. Fix pointer signedness problems.
1545 * lread.c (openp): Don't stuff size_t into an 'int'.
1546 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1547 about possible signed overflow.
1549 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1550 (GDK_KEY_g): Don't define if already defined.
1551 (xg_prepare_tooltip): Avoid pointer signedness problem.
1552 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1554 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1555 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1557 * xfns.c (Fx_window_property): Simplify a bit,
1558 to make a bit faster and to avoid GCC 4.6.0 warning.
1559 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1561 * fns.c (internal_equal): Don't assume size_t fits in int.
1563 * alloc.c (compact_small_strings): Tighten assertion a little.
1565 Replace pEd with more-general pI, and fix some printf arg casts.
1566 * lisp.h (pI): New macro, generalizing old pEd macro to other
1567 conversion specifiers. For example, use "...%"pI"d..." rather
1568 than "...%"pEd"...".
1569 (pEd): Remove. All uses replaced with similar uses of pI.
1570 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1571 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1572 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1573 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1574 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1575 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1576 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1578 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1579 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1580 * print.c (safe_debug_print, print_object): Likewise.
1581 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1583 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1584 avoiding the 0 flag, which is not portable.
1585 * process.c (Fmake_network_process): Use pI to avoid cast.
1586 * region-cache.c (pp_cache): Likewise.
1587 * xdisp.c (decode_mode_spec): Likewise.
1588 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1589 behavior on 64-bit hosts with printf arg.
1590 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
1591 (x_stop_queuing_selection_requests): Likewise.
1592 (x_get_window_property): Don't truncate byte count to an 'int'
1595 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1596 here, since it parses constructs like leading '-' and spaces,
1597 which are not wanted; and it overflows with large numbers.
1598 Instead, simply match F[0-9]+, which is what is wanted anyway.
1600 * alloc.c: Remove unportable assumptions about struct layout.
1601 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1602 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1603 (allocate_vectorlike, make_pure_vector): Use the new macros,
1604 plus offsetof, to remove unportable assumptions about struct layout.
1605 These assumptions hold on all porting targets that I know of, but
1606 they are not guaranteed, they're easy to remove, and removing them
1607 makes further changes easier.
1609 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1610 This doesn't fix a bug but makes the code clearer.
1611 (string_overrun_cookie): Now const. Use initializers that
1612 don't formally overflow signed char, to avoid warnings.
1613 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1614 can cause Emacs to crash when string overrun checking is enabled.
1615 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1616 multiple of sizeof (EMACS_INT); it need not be, if
1617 alignof(EMACS_INT) < sizeof (EMACS_INT).
1618 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1620 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
1622 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1624 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1626 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1627 supposed to be handshaking. (Bug#8556)
1628 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1630 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1632 * lisp.h (Qdebug): List symbol.
1633 * eval.c (Qdebug): Restore global linkage.
1634 * keyboard.c (debug-on-event): New variable.
1635 (handle_user_signal): Break into debugger when debug-on-event
1636 matches the current signal symbol.
1638 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1640 * alloc.c (check_sblock, check_string_bytes)
1641 (check_string_free_list): Convert to standard C.
1643 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1645 * w32.c (emacs_gnutls_push): Fix typo.
1647 2011-04-25 Eli Zaretskii <eliz@gnu.org>
1649 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1650 "cast to pointer from integer of different size".
1652 Improve doprnt and its use in verror. (Bug#8545)
1653 * doprnt.c (doprnt): Document the set of format control sequences
1654 supported by the function. Use SAFE_ALLOCA instead of always
1657 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1658 is one byte too soon. Don't use xrealloc; instead xfree and
1661 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1663 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1666 * gnutls.c: Renamed global_initialized to
1667 gnutls_global_initialized. Added internals for the
1668 :verify-hostname-error, :verify-error, and :verify-flags
1669 parameters of `gnutls-boot' and documented those parameters in the
1670 docstring. Start callback support.
1671 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1672 unless a fatal error occured. Call gnutls_alert_send_appropriate
1673 on error. Return error code.
1674 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1675 (emacs_gnutls_read): Likewise.
1676 (Fgnutls_boot): Return handshake error code.
1677 (emacs_gnutls_handle_error): New function.
1678 (wsaerror_to_errno): Likewise.
1680 * w32.h (emacs_gnutls_pull): Add prototype.
1681 (emacs_gnutls_push): Likewise.
1683 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1684 (emacs_gnutls_push): Likewise.
1686 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1688 * process.c (wait_reading_process_output): Check if GnuTLS
1689 buffered some data internally if no FDs are set for TLS
1692 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1693 (LIBS): Link to USER_LIBS.
1694 ($(BLD)/gnutls.$(0)): New target.
1696 2011-04-24 Eli Zaretskii <eliz@gnu.org>
1698 * xdisp.c (handle_single_display_spec): Rename the
1699 display_replaced_before_p argument into display_replaced_p, to
1700 make it consistent with the commentary. Fix typos in the
1703 * textprop.c (syms_of_textprop): Remove dead code.
1704 (copy_text_properties): Delete obsolete commentary about an
1705 interface that was deleted long ago. Fix typos in the description
1708 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1709 to changes in oldXMenu/XMenu.h from 2011-04-16.
1710 <menu_help_message, prev_menu_help_message>: Constify.
1711 (IT_menu_make_room): menu->help_text is now `const char **';
1714 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1715 to changes in oldXMenu/XMenu.h from 2011-04-16.
1716 (struct XMenu): Declare `help_text' `const char **'.
1718 * xfaces.c <Qunspecified>: Make extern again.
1720 * syntax.c: Include sys/types.h before including regex.h, as
1723 * doc.c (get_doc_string): Improve the format passed to `error'.
1725 * doprnt.c (doprnt): Improve commentary.
1727 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1729 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1732 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1733 changes in globals.h immediately force recompilation.
1734 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1735 $(CURDIR)/s/ms-w32.h.
1736 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1738 * character.c (Fchar_direction): Function deleted.
1739 (syms_of_character): Don't defsubr it.
1740 <char-direction-table>: Deleted.
1742 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1744 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1745 * doprnt.c: Include limits.h.
1746 (SIZE_MAX): New macro.
1747 (doprnt): Return a size_t value. 2nd arg is now size_t.
1748 Many local variables are now size_t instead of int or unsigned.
1749 Improve overflow protection. Support `l' modifier for integer
1750 conversions. Support %l conversion. Don't assume an EMACS_INT
1751 argument for integer conversions and for %c.
1753 * lisp.h (doprnt): Restore prototype.
1755 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1758 * Makefile.in (base_obj): Add back doprnt.o.
1760 * deps.mk (doprnt.o): Add back prerequisites.
1761 (callint.o): Depend on character.h.
1763 * eval.c (internal_lisp_condition_case): Include the handler
1764 representation in the error message.
1765 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1766 when breaking from the loop.
1768 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1770 * callint.c (Fcall_interactively): When displaying error message
1771 about invalid control letter, pass the character's codepoint, not
1772 a pointer to its multibyte form. Improve display of the character
1773 in octal and display also its hex code.
1775 * character.c (char_string): Use %x to display the (unsigned)
1776 codepoint of an invalid character, to avoid displaying a bogus
1779 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1780 `error', not SYMBOL_NAME itself.
1782 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1783 character arguments to `error'.
1785 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1786 to `error' in error message about FINAL_CHAR argument. Make sure
1787 FINAL_CHAR is a character, and use %c when it is passed as
1788 argument to `error'.
1790 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1792 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1794 * w32.c: Include <time.h>.
1795 (sys_localtime): New function.
1797 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
1799 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1801 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1803 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1805 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1808 2011-04-19 Eli Zaretskii <eliz@gnu.org>
1810 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1811 gl_state.e_property when gl_state.object is Qt.
1813 * insdel.c (make_gap_larger): Remove limitation of buffer size
1816 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
1818 * xdisp.c (lookup_glyphless_char_display)
1819 (produce_glyphless_glyph): Handle cons cell entry in
1820 glyphless-char-display.
1821 (Vglyphless_char_display): Document it.
1823 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1824 glyphless-char-display.
1826 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
1828 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1830 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1832 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1833 definition for no-X builds.
1835 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1837 Static checks with GCC 4.6.0 and non-default toolkits.
1839 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1841 * process.c (keyboard_bit_set): Define only if SIGIO.
1842 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1843 (send_process): Repair possible setjmp clobbering.
1845 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1847 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1849 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1851 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1852 Define only if needed.
1854 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1855 by pacifying GCC about it. Maybe it's time to retire it?
1856 * xfaces.c (USG, __TIMEVAL__): Likewise.
1858 * dispextern.h (struct redisplay_interface): Rename param
1860 * termhooks.h (struct terminal): Likewise.
1861 * xterm.c (xembed_send_message): Likewise.
1863 * insdel.c (make_gap_smaller): Define only if
1864 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1866 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1869 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1870 so that we aren't warned about unused symbols.
1872 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1874 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1876 * xfns.c (x_real_positions): Mark locals as initialized.
1878 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1880 * xterm.c: Fix problems found by static analysis with other toolkits.
1881 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1882 (x_dispatch_event): Declare static if USE_GTK, and
1883 define if USE_GTK || USE_X_TOOLKIT.
1884 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1885 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1886 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1887 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1889 * xmenu.c (menu_help_callback): Pointer type fixes.
1890 Use const pointers when pointing at readonly data. Avoid pointer
1892 (FALSE): Remove unused macro.
1893 (update_frame_menubar): Remove unused decl.
1895 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1897 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1898 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1899 (single_menu_item): Rename local to avoid shadowing.
1901 * keyboard.c (make_lispy_event): Remove unused local var.
1903 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1904 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1906 * bitmaps: Change bitmaps from unsigned char back to the X11
1907 compatible char. Avoid the old compiler warnings about
1908 out-of-range initializers by using, for example, '\xab' rather
1911 * xgselect.c (xgselect_initialize): Check vs interface
1912 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1914 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1916 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1917 to read-only memory.
1919 * fns.c (vector): Remove; this old hack is no longer needed.
1921 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1923 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1925 * xrdb.c (x_load_resources): Omit unused local.
1927 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1928 (x_window): Rename locals to avoid shadowing.
1929 (USG): Use the kludged USG macro, to pacify gcc.
1931 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1932 (x_term_init): Remove local to avoid shadowing.
1934 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1936 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1937 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1939 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1941 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1943 Fix regex.c, syntax.c and friends for buffers > 2GB.
1944 * syntax.h (struct gl_state_s): Declare character position members
1947 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1949 * textprop.c (verify_interval_modification, interval_of):
1950 Declare arguments EMACS_INT.
1952 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1955 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1957 * indent.c (Fvertical_motion): Local variable it_start is now
1960 * regex.c (re_match, re_match_2, re_match_2_internal)
1961 (bcmp_translate, regcomp, regexec, print_double_string)
1962 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1963 (re_compile_pattern, re_exec): Declare arguments and local
1964 variables `size_t' and `ssize_t' and return values `regoff_t', as
1966 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1967 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1968 <compile_stack_type>: `size' and `avail' are now `size_t'.
1970 * regex.h <regoff_t>: Use ssize_t, not int.
1971 (re_search, re_search_2, re_match, re_match_2): Arguments that
1972 specify buffer/string position and length are now ssize_t and
1973 size_t. Return type is regoff_t.
1975 2011-04-16 Ben Key <bkey76@gmail.com>
1977 * nsfont.m: Fixed bugs in ns_get_family and
1978 ns_descriptor_to_entity that were caused by using free to
1979 deallocate memory blocks that were allocated by xmalloc (via
1980 xstrdup). This caused Emacs to crash when compiled with
1981 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1982 --enable-checking=xmallocoverrun). xfree is now used to
1983 deallocate these memory blocks.
1985 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1987 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1989 emacs_write: Accept and return EMACS_INT for sizes.
1990 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1992 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1993 Accept and return EMACS_INT.
1994 (emacs_gnutls_write): Return the number of bytes written on
1996 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1997 (emacs_read, emacs_write): Remove check for negative size, as the
1998 Emacs source code has been audited now.
1999 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2000 (emacs_read, emacs_write): Use it.
2001 * process.c (send_process): Adjust to the new signatures of
2002 emacs_write and emacs_gnutls_write. Do not attempt to store
2003 a byte offset into an 'int'; it might overflow.
2004 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2006 * sound.c: Don't assume sizes fit in 'int'.
2007 (struct sound_device.period_size, alsa_period_size):
2008 Return EMACS_INT, not int.
2009 (struct sound_device.write, vox_write, alsa_write):
2010 Accept EMACS_INT, not int.
2011 (wav_play, au_play): Use EMACS_INT to store sizes and to
2012 record read return values.
2014 2011-04-15 Ben Key <bkey76@gmail.com>
2016 * keyboard.c (Qundefined): Don't declare static since it is used
2018 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2019 static since they are used in nsfont.m.
2021 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2023 * process.c (Qprocessp): Don't declare static.
2024 * lisp.h (Qprocessp): Declare again.
2026 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
2028 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2030 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2032 Improve C-level modularity by making more things 'static'.
2034 Don't publish debugger-only interfaces to other modules.
2035 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2036 (verify_bytepos, count_markers): Move decls to the only modules
2038 * region-cache.h (pp_cache): Likewise.
2039 * window.h (check_all_windows): Likewise.
2040 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2042 * sysdep.c (croak): Now static, if
2043 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2044 * syssignal.h (croak): Declare only if not static.
2046 * alloc.c (refill_memory_reserve): Now static if
2047 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2048 * lisp.h (refill_memory_reserve): Declare only if not static.
2050 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2051 Define only if USE_LUCID.
2053 * xrdb.c (x_customization_string, x_rm_string): Now static.
2055 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2056 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2058 * xdisp.c (draw_row_with_mouse_face): Now static.
2059 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2061 * window.h (check_all_windows): Mark externally visible.
2063 * window.c (window_deletion_count): Now static.
2065 * undo.c: Make symbols static if they're not exported.
2066 (last_undo_buffer, last_boundary_position, pending_boundary):
2069 * textprop.c (interval_insert_behind_hooks): Now static.
2070 (interval_insert_in_front_hooks): Likewise.
2072 * term.c: Make symbols static if they're not exported.
2073 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2074 (max_frame_lines, tty_set_terminal_modes):
2075 (tty_reset_terminal_modes, tty_turn_off_highlight):
2076 (get_tty_terminal): Now static.
2077 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2078 * termhooks.h (term_mouse_moveto): Do not declare if
2080 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2081 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2083 * sysdep.c: Make symbols static if they're not exported.
2084 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2086 (sigprocmask_set, full_mask): Remove; unused.
2087 (wait_debugging): Mark as visible.
2088 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2089 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2091 * syntax.c (syntax_temp): Define only if !__GNUC__.
2093 * sound.c (current_sound_device, current_sound): Now static.
2095 * search.c (searchbufs, searchbuf_head): Now static.
2097 * scroll.c (scroll_cost): Remove; unused.
2098 * dispextern.h (scroll_cost): Remove decl.
2100 * region-cache.h (pp_cache): Mark as externally visible.
2102 * process.c: Make symbols static if they're not exported.
2103 (process_tick, update_tick, create_process, chan_process):
2104 (Vprocess_alist, proc_buffered_char, datagram_access):
2105 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2106 (deactivate_process): Mark defn as static, as well as decl.
2107 * lisp.h (create_process): Remove decl.
2108 * process.h (chan_process, Vprocess_alist): Remove decls.
2110 * print.c: Make symbols static if they're not exported.
2111 (print_depth, new_backquote_output, being_printed, print_buffer):
2112 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2113 (print_interval, print_number_index, initial_stderr_stream):
2115 * lisp.h (Fprinc): Remove decl.
2116 (debug_output_compilation_hack): Mark as externally visible.
2118 * sysdep.c (croak): Move decl from here to syssignal.h.
2119 * syssignal.h (croak): Put it here, so the API can be checked when
2120 'croak' is called from dissociate_if_controlling_tty.
2122 * minibuf.c: Make symbols static if they're not exported.
2123 (minibuf_save_list, choose_minibuf_frame): Now static.
2124 * lisp.h (choose_minibuf_frame): Remove decl.
2126 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2128 * lread.c: Make symbols static if they're not exported.
2129 (read_objects, initial_obarray, oblookup_last_bucket_number):
2131 (make_symbol): Remove; unused.
2132 * lisp.h (initial_obarray, make_symbol): Remove decls.
2134 * keyboard.c: Make symbols static if they're not exported.
2135 (single_kboard, recent_keys_index, total_keys, recent_keys):
2136 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2137 (this_single_command_key_start, echoing, last_auto_save):
2138 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2139 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2140 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2141 (Vlispy_mouse_stem, double_click_count):
2143 (force_auto_save_soon): Define only if SIGDANGER.
2144 (ignore_mouse_drag_p): Now static if
2145 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2146 (print_help): Remove; unused.
2147 (stop_character, last_timer_event): Mark as externally visible.
2148 * keyboard.h (ignore_mouse_drag_p): Declare only if
2149 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2150 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2151 * lisp.h (echoing): Remove decl.
2152 (force_auto_save_soon): Declare only if SIGDANGER.
2153 * xdisp.c (redisplay_window): Simplify code, to make it more
2154 obvious that ignore_mouse_drag_p is not accessed if !defined
2155 USE_GTK && !defined HAVE_NS.
2157 * intervals.c: Make symbols static if they're not exported.
2158 (merge_properties_sticky, merge_interval_right, delete_interval):
2160 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2162 * insdel.c: Make symbols static if they're not exported.
2163 However, leave prepare_to_modify_buffer alone. It's never
2164 called from outside this function, but that appears to be a bug.
2165 (combine_after_change_list, combine_after_change_buffer):
2166 (adjust_after_replace, signal_before_change): Now static.
2167 (adjust_after_replace_noundo): Remove; unused.
2168 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2169 (signal_before_change): Remove decls.
2171 * indent.c (val_compute_motion, val_vmotion): Now static.
2173 * image.c: Make symbols static if they're not exported.
2174 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2176 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2177 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2179 * fringe.c (standard_bitmaps): Now static.
2180 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2182 * frame.c: Make symbols static if they're not exported.
2183 (x_report_frame_params, make_terminal_frame): Now static.
2184 (get_frame_param): Now static, unless HAVE_NS.
2185 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2186 (x_get_resource_string): Remove; not used.
2187 * frame.h (make_terminal_frame, x_report_frame_params):
2188 (x_get_resource_string); Remove decls.
2189 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2190 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2192 * font.c, fontset.c: Make symbols static if they're not exported.
2193 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2194 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2195 * font.c (font_close_object): Now static.
2196 * font.h (font_close_object): Remove.
2197 * fontset.c (FONTSET_OBJLIST): Remove.
2198 (free_realized_fontset) #if-0 the body, which does nothing.
2199 (face_suitable_for_char_p): #if-0, as it's never called.
2200 * fontset.h (face_suitable_for_char_p): Remove decl.
2201 * xfaces.c (face_at_string_position):
2202 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2203 since 0 is always ASCII.
2205 * fns.c (weak_hash_tables): Now static.
2207 * fileio.c: Make symbols static if they're not exported.
2208 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2209 (Vwrite_region_annotation_buffers): Now static.
2211 * eval.c: Make symbols static if they're not exported.
2212 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2213 * lisp.h (backtrace_list): Remove decl.
2215 * emacs.c: Make symbols static if they're not exported.
2216 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2217 (fatal_error_code, fatal_error_signal_hook, standard_args):
2219 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2220 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2221 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2222 * lisp.h (fatal_error_signal_hook): Remove decl.
2223 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2225 * editfns.c: Move a (normally-unused) function to its only use.
2226 * editfns.c, lisp.h (get_operating_system_release): Remove.
2227 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2228 worth the hassle of breaking this out.
2230 * xterm.c: Make symbols static if they're not exported.
2231 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2232 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2233 (x_destroy_window, x_delete_display):
2235 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2236 (x_mouse_leave): Remove; unused.
2237 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2238 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2239 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2241 (x_mouse_leave): Declare only if WINDOWSNT.
2242 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2243 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2246 * ftxfont.c: Make symbols static if they're not exported.
2247 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2249 * font.h (ftxfont_driver): Likewise.
2251 * xfns.c: Make symbols static if they're not exported.
2252 (x_last_font_name, x_display_info_for_name):
2253 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2254 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2255 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2256 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2257 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2258 (last_show_tip_args): Now static.
2259 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2260 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2261 (x_screen_planes): Remove; unused.
2262 * dispextern.h (x_screen_planes): Remove decl.
2264 * dispnew.c: Make symbols static if they're not exported.
2265 * dispextern.h (redraw_garbaged_frames, scrolling):
2266 (increment_row_positions): Remove.
2267 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2268 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2270 (redraw_garbaged_frames): Remove; unused.
2272 * xfaces.c: Make symbols static if they're not exported.
2273 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2275 * xterm.h (defined_color): Remove decls.
2276 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2277 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2278 (menu_face_changed_default, defined_color, free_realized_face):
2279 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2280 (ascii_face_of_lisp_face): Remove; unused.
2282 * xdisp.c: Make symbols static if they're not exported.
2283 * dispextern.h (scratch_glyph_row, window_box_edges):
2284 (glyph_to_pixel_coords, set_cursor_from_row):
2285 (get_next_display_element, set_iterator_to_next):
2286 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2287 (show_mouse_face): Remove decls
2288 * frame.h (message_buf_print): Likewise.
2289 * lisp.h (pop_message, set_message, check_point_in_composition):
2291 * xterm.h (set_vertical_scroll_bar): Likewise.
2292 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2293 (message_buf_print, scratch_glyph_row, displayed_buffer):
2294 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2295 (get_next_display_element, show_mouse_face, window_box_edges):
2296 (frame_to_window_pixel_xy, check_point_in_composition):
2297 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2298 (glyph_to_pixel_coords): Remove; unused.
2300 * dired.c (file_name_completion): Now static.
2302 * dbusbind.c (xd_in_read_queued_messages): Now static.
2304 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2305 * data.c (circular_list_error): Remove.
2307 * commands.h (last_point_position, last_point_position_buffer):
2308 (last_point_position_window): Remove decls.
2309 * keyboard.c: Make these variables static.
2311 * coding.h (coding, code_convert_region, encode_coding_gap):
2313 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2314 (iso_code_class, detect_coding, code_convert_region): Now static.
2315 (encode_coding_gap): Remove; unused.
2317 * chartab.c (chartab_chars, chartab_bits): Now static.
2319 * charset.h (charset_iso_8859_1): Remove decl.
2320 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2323 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2324 * ccl.c (Vccl_program_table): Now static.
2325 (check_ccl_update): Remove; unused.
2327 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2328 * category.h: ... from here.
2329 * category.c (check_category_table, set_category_set): Now static.
2331 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2332 * lisp.h: Remove these decls.
2334 * buffer.c (buffer_count): Remove unused var.
2336 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2337 so that it's not optimized away.
2338 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2339 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2340 exported only to the debugger.
2342 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2343 * atimer.h (run_all_atimers): Remove; not exported.
2345 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2346 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2347 was inaccessible from Lisp.
2348 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2349 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2351 alloc.c: Import and export fewer symbols, and remove unused items.
2352 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2354 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2355 it's not optimized away by whole-program optimization.
2356 (message_enable_multibyte, free_misc): Remove.
2357 (catchlist, handlerlist, mark_backtrace):
2358 Declare only if BYTE_MARK_STACK.
2359 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2360 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2361 (message_enable_multibyte): Remove decl.
2362 (free_misc, interval_free_list, float_block, float_block_index):
2363 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2364 (cons_free_list, last_marked_index):
2366 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2367 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2368 (mark_backtrace): Define only if BYTE_MARK_STACK.
2369 * xdisp.c (message_enable_multibyte): Now static.
2371 Declare Lisp_Object Q* variables to be 'static' if not exported.
2372 This makes it easier for human readers (and static analyzers)
2373 to see whether these variables are used from other modules.
2374 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2375 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2376 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2377 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2378 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2379 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2380 * xmenu.c, xselect.c:
2381 Declare Q* vars static if they are not used in other modules.
2382 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2383 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2384 Remove decls of unexported vars.
2385 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2387 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2389 Make Emacs functions such as Fatom 'static' by default.
2390 This makes it easier for human readers (and static analyzers)
2391 to see whether these functions can be called from other modules.
2392 DEFUN now defines a static function. To make the function external
2393 so that it can be used in other C modules, use the new macro DEFUE.
2394 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2395 (Finit_image_library):
2396 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2397 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2398 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2399 Remove decls, since these functions are now static.
2400 (Funintern, Fget_internal_run_time): New decls, since these functions
2401 were already external.
2403 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2404 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2405 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2406 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2407 * keyboard.c, keymap.c, lread.c:
2408 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2409 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2410 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2411 Mark functions with DEFUE instead of DEFUN,
2412 if they are used in other modules.
2413 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2414 decls for now-static functions.
2415 * buffer.h (Fdelete_overlay): Remove decl.
2416 * callproc.c (Fgetenv_internal): Mark as internal.
2417 * composite.c (Fremove_list_of_text_properties): Remove decl.
2418 (Fcomposition_get_gstring): New forward static decl.
2419 * composite.h (Fcomposite_get_gstring): Remove decl.
2420 * dired.c (Ffile_attributes): New forward static decl.
2421 * doc.c (Fdocumntation_property): New forward static decl.
2422 * eval.c (Ffetch_bytecode): New forward static decl.
2423 (Funintern): Remove extern decl; now in .h file where it belongs.
2424 * fileio.c (Fmake_symbolic_link): New forward static decl.
2425 * image.c (Finit_image_library): New forward static decl.
2426 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2427 * intervals.h (Fprevious_property_change):
2428 (Fremove_list_of_text_properties): Remove decls.
2429 * keyboard.c (Fthis_command_keys): Remove decl.
2430 (Fcommand_execute): New forward static decl.
2431 * keymap.c (Flookup_key): New forward static decl.
2432 (Fcopy_keymap): Now static.
2433 * keymap.h (Flookup_key): Remove decl.
2434 * process.c (Fget_process): New forward static decl.
2435 (Fprocess_datagram_address): Mark as internal.
2436 * syntax.c (Fsyntax_table_p): New forward static decl.
2437 (skip_chars): Remove duplicate decl.
2438 * textprop.c (Fprevious_property_change): New forward static decl.
2439 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2441 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2442 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2444 * editfns.c (Fformat): Remove unreachable code.
2446 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2448 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2451 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2453 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2454 when at ZV. (Bug#8487)
2456 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2458 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2460 * keyboard.c (parse_tool_bar_item): Likewise.
2461 * sound.c (sound_cleanup, alsa_close): Likewise.
2462 * termcap.c (tgetent): Likewise.
2463 * xfns.c (x_default_font_parameter): Likewise.
2464 * xsettings.c (read_and_apply_settings): Likewise.
2466 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2467 (overrun_check_free): Protoize.
2469 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2471 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2472 since callers should never pass a negative size.
2473 Change the signature to match that of plain 'read' and 'write'; see
2474 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2475 * lisp.h: Update prototypes of emacs_write and emacs_read.
2477 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2479 * xdisp.c (redisplay_window): Don't try to determine the character
2480 position of the scroll margin if the window start point w->startp
2481 is outside the buffer's accessible region. (Bug#8468)
2483 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2485 Fix write-region and its subroutines for buffers > 2GB.
2486 * fileio.c (a_write, e_write): Modify declaration of arguments and
2487 local variables to support buffers larger than 2GB.
2488 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2490 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2491 argument, local variables, and return value.
2493 * lisp.h: Update prototypes of emacs_write and emacs_read.
2495 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2497 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2499 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2501 Fix more problems found by GCC 4.6.0's static checks.
2503 * xdisp.c (vmessage): Use a better test for character truncation.
2505 * charset.c (load_charset_map): <, not <=, for optimization,
2506 and to avoid potential problems with integer overflow.
2507 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2508 * casetab.c (set_identity, shuffle): Likewise.
2509 * editfns.c (Fformat): Likewise.
2510 * syntax.c (skip_chars): Likewise.
2512 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2513 This also lets GCC 4.6.0 generate slightly better loop code.
2515 * callint.c (Fcall_interactively): <, not <=, for optimization.
2516 (Fcall_interactively): Count the number of arguments produced,
2517 not the number of arguments given. This is simpler and lets GCC
2518 4.6.0 generate slightly better code.
2520 * ftfont.c: Distingish more carefully between FcChar8 and char.
2521 The previous code passed unsigned char * to a functions like
2522 strlen and xstrcasecmp that expect char *, which does not
2523 conform to the C standard.
2524 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2525 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2526 char * when the C standard requires it.
2528 * keyboard.c (read_char): Remove unused var.
2530 * eval.c: Port to Windows vsnprintf (Bug#8435).
2532 (SIZE_MAX): Define if the headers do not.
2533 (verror): Do not give up if vsnprintf returns a negative count.
2534 Instead, grow the buffer. This ports to Windows vsnprintf, which
2535 does not conform to C99. Problem reported by Eli Zaretskii.
2536 Also, simplify the allocation scheme, by avoiding the need for
2537 calling realloc, and removing the ALLOCATED variable.
2539 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2541 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2542 But keep the doprint source code for now, as we might revamp it
2543 and use it again (Bug#8435).
2544 * lisp.h (doprnt): Remove.
2545 * Makefile.in (base_obj): Remove doprnt.o.
2546 * deps.mk (doprnt.o): Remove.
2548 error: Print 32- and 64-bit integers portably (Bug#8435).
2549 Without this change, on typical 64-bit hosts error ("...%d...", N)
2550 was used to print both 32- and 64-bit integers N, which relied on
2552 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2554 * lisp.h (error, verror): Mark as printf-like functions.
2555 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2556 Report overflow in size calculations when allocating printf buffer.
2557 Do not truncate output string at its first null byte.
2558 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2559 Truncate the output at a character boundary, since vsnprintf does not
2561 * charset.c (check_iso_charset_parameter): Convert internal
2562 character to string before calling 'error', since %c now has the
2564 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2565 overflow when computing char to be passed to 'error'. Do not
2566 pass Lisp_Object to 'error'; pass the integer instead.
2567 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2568 formatted with plain %d.
2570 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2572 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2574 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2576 * xterm.c (x_catch_errors): Remove duplicate declaration.
2578 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2580 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2582 2011-04-10 Jim Meyering <meyering@redhat.com>
2584 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2585 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2586 return ssize_t not "int", and use size_t as the buffer length.
2587 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2588 * gnutls.h: Update declarations.
2589 * process.c (read_process_output): Use ssize_t, to match.
2590 (send_process): Likewise.
2592 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2594 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2596 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2598 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2599 Use unsigned char, to match FcChar8 type definition.
2601 * xterm.c (handle_one_xevent):
2602 * xmenu.c (create_and_show_popup_menu):
2603 * xselect.c (x_decline_selection_request)
2604 (x_reply_selection_request): Avoid type-punned deref of X events.
2606 2011-04-09 Eli Zaretskii <eliz@gnu.org>
2608 Fix some uses of `int' instead of EMACS_INT.
2609 * search.c (string_match_1, fast_string_match)
2610 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2611 (scan_buffer, find_next_newline_no_quit)
2612 (find_before_next_newline, search_command, Freplace_match)
2613 (Fmatch_data): Make some `int' variables be EMACS_INT.
2615 * xdisp.c (display_count_lines): 3rd argument and return value now
2616 EMACS_INT. All callers changed.
2617 (pint2hrstr): Last argument is now EMACS_INT.
2619 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2620 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2621 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2622 (decode_coding_utf_16, decode_coding_emacs_mule)
2623 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2624 (decode_coding_ccl, decode_coding_charset)
2625 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2626 (decode_coding_iso_2022, decode_coding_emacs_mule)
2627 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2628 <char_offset, last_offset>: Declare EMACS_INT.
2629 (encode_coding_utf_8, encode_coding_utf_16)
2630 (encode_coding_emacs_mule, encode_invocation_designation)
2631 (encode_designation_at_bol, encode_coding_iso_2022)
2632 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2633 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2635 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2636 (encode_invocation_designation): Last argument P_NCHARS is now
2638 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2639 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2641 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2644 * ccl.c (Fccl_execute_on_string): Declare some variables
2647 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
2649 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2651 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2653 * process.c (Fformat_network_address): Doc fix.
2655 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2657 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2659 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
2661 * keyboard.c (read_char): Call Lisp function help-form-show,
2662 instead of using internal_with_output_to_temp_buffer.
2663 (Qhelp_form_show): New var.
2664 (syms_of_keyboard): Use DEFSYM macro.
2666 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2668 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2670 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
2672 * process.c (Flist_processes): Remove to Lisp.
2673 (list_processes_1): Delete.
2675 2011-04-06 Eli Zaretskii <eliz@gnu.org>
2677 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2679 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2681 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
2683 Fix more problems found by GCC 4.6.0's static checks.
2685 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2687 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2689 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
2691 * xdisp.c (vmessage): Mark as a printf-like function.
2693 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2695 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2697 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2698 printf-like functions.
2699 (tiff_load): Add casts to remove these marks before passing them
2700 to system-supplied API.
2702 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2704 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2705 This avoids several warnings with gcc -Wstrict-overflow.
2706 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2707 directly, rather than having caller test rule sign. This avoids
2708 some unnecessary tests.
2709 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2710 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2711 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
2713 * xfont.c (xfont_text_extents): Remove var that was set but not used.
2714 (xfont_open): Avoid unnecessary tests.
2716 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2718 * composite.h, composite.c (composition_gstring_put_cache):
2719 Use EMACS_INT, not int, for length.
2721 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2722 breaking out part of COMPOSITION_DECODE_RULE.
2723 (COMPOSITION_DECODE_RULE): Use it.
2724 * composite.c (get_composition_id): Remove unused local vars,
2725 by using the new macro.
2727 * textprop.c (set_text_properties_1): Change while to do-while,
2728 since the condition is always true at first.
2730 * intervals.c (graft_intervals_into_buffer): Mark var as used.
2731 (interval_deletion_adjustment): Return unsigned value.
2734 * process.c (list_processes_1, create_pty, read_process_output):
2735 (exec_sentinel): Remove vars that were set but not used.
2736 (create_pty): Remove unnecessary "volatile"s.
2737 (Fnetwork_interface_info): Avoid possibility of int overflow.
2738 (read_process_output): Do adaptive read buffering even if carryover.
2739 (read_process_output): Simplify nbytes computation if buffered.
2741 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2743 * syntax.c (scan_words): Remove var that was set but not used.
2744 (update_syntax_table): Use unsigned instead of int.
2746 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
2747 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
2748 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
2750 * print.c (print_error_message): Avoid int overflow.
2752 * font.c (font_list_entities): Redo for clarity,
2753 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2755 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
2756 (font_score): Avoid potential overflow in diff calculation.
2758 * fns.c (substring_both): Remove var that is set but not used.
2759 (sxhash): Redo loop for clarity and to avoid wraparound warning.
2761 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2763 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2764 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2765 can always succeed if overflow has undefined behavior.
2767 * search.c (boyer_moore, wordify): Remove vars set but not used.
2768 (wordify): Omit three unnecessary tests.
2770 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2771 All callers changed. This avoids the need for an unused var.
2773 * casefiddle.c (casify_region): Remove var that is set but not used.
2775 * dired.c (file_name_completion): Remove var that is set but not used.
2777 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2779 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2780 (Finsert_file_contents): Remove unnecessary code checking fd.
2782 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2783 Check for integer overflow on size calculations.
2785 * buffer.c (Fprevious_overlay_change): Remove var that is set
2788 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2789 Remove vars that are set but not used.
2790 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2791 (timer_check_2): Mark vars as initialized.
2793 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2795 * image.c (lookup_image): Remove var that is set but not used.
2796 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2798 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2799 that are set but not used.
2801 * xfns.c (make_invisible_cursor): Don't return garbage
2802 if XCreateBitmapFromData fails (Bug#8410).
2804 * xselect.c (x_get_local_selection, x_handle_property_notify):
2805 Remove vars that are set but not used.
2807 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2808 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2810 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2811 Remove var that is set but not used.
2812 (scroll_bar_windows_size): Now size_t, not int.
2813 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2816 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2817 (map_tty_color) [!defined MSDOS]: Likewise.
2819 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2821 * coding.c: Remove vars that are set but not used.
2822 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2823 All callers changed.
2824 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2825 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2826 (decode_coding_charset): Remove vars that are set but not used.
2828 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2829 that is set but not used.
2831 * print.c (print_object): Remove var that is set but not used.
2833 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2834 The gnulib version avoids calling malloc in the usual case,
2835 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2836 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2837 * filelock.c (current_lock_owner): Likewise.
2838 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2839 * sysdep.c: Include allocator.h, careadlinkat.h.
2840 (emacs_no_realloc_allocator): New static constant.
2841 (emacs_readlink): New function.
2842 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2843 ../lib/careadlinkat.h.
2845 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2847 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2848 first non-nil return value).
2850 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2852 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2853 if not defined (Bug#8403).
2855 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2857 * xdisp.c (display_count_lines): Remove parameter `start',
2858 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2859 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2860 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2861 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2862 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2863 and thereabouts. All callers changed.
2864 (get_per_char_metric): Remove parameter `f', unused since
2865 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2867 2011-04-02 Jim Meyering <meyering@redhat.com>
2869 do not dereference NULL upon failed strdup
2870 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2871 (ns_get_family): Likewise.
2873 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2875 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2877 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2879 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2882 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2884 Add lexical binding.
2886 * window.c (Ftemp_output_buffer_show): New fun.
2887 (Fsave_window_excursion):
2888 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2890 * lread.c (lisp_file_lexically_bound_p): New function.
2891 (Fload): Bind Qlexical_binding.
2892 (readevalloop): Remove `evalfun' arg.
2893 Bind Qinternal_interpreter_environment.
2894 (Feval_buffer): Bind Qlexical_binding.
2895 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2897 (syms_of_lread): Declare `lexical-binding'.
2899 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2901 * keyboard.c (eval_dyn): New fun.
2902 (menu_item_eval_property): Use it.
2904 * image.c (parse_image_spec): Use Ffunctionp.
2906 * fns.c (concat, mapcar1): Accept byte-code-functions.
2908 * eval.c (Fsetq): Handle lexical vars.
2909 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2910 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2911 (FletX, Flet): Obey lexical binding.
2912 (Fcommandp): Handle closures.
2913 (Feval): New `lexical' arg.
2914 (eval_sub): New function extracted from Feval. Use it almost
2915 everywhere where Feval was used. Look up vars in lexical env.
2917 (Ffunctionp): Move from subr.el.
2918 (Ffuncall): Handle closures.
2919 (apply_lambda): Remove `eval_flags'.
2920 (funcall_lambda): Handle closures and new byte-code-functions.
2921 (Fspecial_variable_p): New function.
2922 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2923 but without exporting it to Lisp.
2925 * doc.c (Fdocumentation, store_function_docstring):
2926 * data.c (Finteractive_form): Handle closures.
2928 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2931 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2933 (exec_byte_code): New function extracted from Fbyte_code to handle new
2934 calling convention for byte-code-functions. Add new byte-codes.
2936 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2938 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2940 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2942 * xdisp.c (redisplay_internal): Fix prototype.
2944 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2946 * xdisp.c (SCROLL_LIMIT): New macro.
2947 (try_scrolling): Use it when setting scroll_limit.
2948 Limit scrolling to 100 screen lines.
2949 (redisplay_window): Even when falling back on "recentering",
2950 position point in the window according to scroll-conservatively,
2951 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2953 (try_scrolling): When point is above the window, allow searching
2954 as far as scroll_max, or one screenful, to compute vertical
2955 distance from PT to the scroll margin position. This prevents
2956 try_scrolling from unnecessarily failing when
2957 scroll-conservatively is set to a value slightly larger than the
2958 window height. Clean up the case of PT below the margin at bottom
2959 of window: scroll_max can no longer be INT_MAX. When aggressive
2960 scrolling is in use, don't let point enter the opposite scroll
2961 margin as result of the scroll.
2962 (syms_of_xdisp) <scroll-conservatively>: Document the
2963 threshold of 100 lines for never-recentering scrolling.
2965 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2967 * dispextern.h (move_it_by_lines):
2968 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2969 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2970 (message_log_check_duplicate): Remove parameters `prev_bol' and
2971 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2972 (redisplay_internal): Remove parameter `preserve_echo_area',
2973 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2975 * indent.c (Fvertical_motion):
2976 * window.c (window_scroll_pixel_based, Frecenter):
2977 Don't pass `need_y_p' to `move_it_by_lines'.
2979 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2981 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2982 steal a few bits to be more compact.
2983 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2984 Remove unneeded casts.
2986 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2988 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2990 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2991 binding" message (bug#7967).
2993 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2995 Fix more problems found by GCC 4.6.0's static checks.
2997 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2998 Remove unused local var.
3000 * editfns.c (Fmessage_box): Remove unused local var.
3002 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3003 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3004 Omit unused local vars.
3005 * window.c (shrink_windows): Omit unused local var.
3006 * menu.c (digest_single_submenu): Omit unused local var.
3007 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3008 Omit unused local var.
3010 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3011 Don't assume string length fits in int.
3012 (keyremap_step, read_key_sequence): Use size_t for sizes.
3013 (read_key_sequence): Don't check last_real_key_start redundantly.
3015 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3016 instead of alloca (Bug#8344).
3018 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3019 (Fbacktrace_frame): Don't assume nframes fits in int.
3021 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3023 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3026 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3028 * cm.c (calccost): Turn while-do into do-while, for clarity.
3030 * keyboard.c (syms_of_keyboard): Use the same style as later
3031 in this function when indexing through an array. This also
3032 works around GCC bug 48267.
3034 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3036 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3038 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3039 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3041 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3042 This avoids undefined behavior on integer overflow, and is a bit
3043 more convenient anyway since it is compared to a size_t variable.
3045 Variadic C functions now count arguments with size_t, not int.
3046 This avoids an unnecessary limitation on 64-bit machines, which
3047 caused (substring ...) to crash on large vectors (Bug#8344).
3048 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3049 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3050 All variadic functions and their callers changed accordingly.
3051 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3052 * data.c (arith_driver, float_arith_driver): Likewise.
3053 * editfns.c (general_insert_function): Likewise.
3054 * eval.c (struct backtrace.nargs, interactive_p)
3055 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3056 (funcall_lambda, mark_backtrace): Likewise.
3057 * fns.c (concat): Likewise.
3058 * frame.c (x_set_frame_parameters): Likewise.
3059 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3060 0 if not found, not -1. All callers changed.
3062 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3063 (stack_copy_size): Now size_t, not int.
3064 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3066 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3068 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3069 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3070 All callers changed.
3072 * lisp.h (multibyte_char_to_unibyte):
3073 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3074 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3075 * character.h (CHAR_TO_BYTE8):
3076 * cmds.c (internal_self_insert):
3077 * editfns.c (general_insert_function):
3078 * keymap.c (push_key_description):
3079 * search.c (Freplace_match):
3080 * xdisp.c (message_dolog, set_message_1): All callers changed.
3082 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3084 * keyboard.c (safe_run_hook_funcall): New function.
3085 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3086 don't set the hook to nil, but remove the offending function instead.
3087 (Qcommand_hook_internal): Remove, unused.
3088 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3089 Vcommand_hook_internal.
3091 * eval.c (enum run_hooks_condition): Remove.
3092 (funcall_nil, funcall_not): New functions.
3093 (run_hook_with_args): Call each function through a `funcall' argument.
3094 Remove `cond' argument, now redundant.
3095 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3096 (Frun_hook_with_args_until_failure): Adjust accordingly.
3097 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3099 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3101 * dispextern.h (string_buffer_position): Remove declaration.
3103 * print.c (strout): Remove parameter `multibyte', unused since
3104 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3106 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3107 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3108 All callers changed.
3110 * w32.c (_wsa_errlist): Use braces for struct initializers.
3112 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3113 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3114 All callers changed.
3115 (string_buffer_position): Likewise. Also, make static (it's never
3116 used outside xdisp.c).
3117 (cursor_row_p): Remove parameter `w', unused since
3118 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3119 (decode_mode_spec): Remove parameter `precision', introduced during
3120 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3121 All callers changed.
3123 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3125 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3127 2011-03-27 Anders Lindgren <andlind@gmail.com>
3129 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3130 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3131 (ns_update_auto_hide_menu_bar): New functions.
3132 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3133 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3134 ns_constrain_all_frames.
3135 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3136 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3138 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3140 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3142 2011-03-27 Glenn Morris <rgm@gnu.org>
3144 * syssignal.h: Replace RETSIGTYPE with void.
3145 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3146 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3147 Replace SIGTYPE with void everywhere.
3148 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3149 * s/template.h (SIGTYPE): Remove commented out definition.
3151 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3153 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3154 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3156 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3158 * w32.c (read_unc_volume): Use parameter `henum', instead of
3159 global variable `wget_enum_handle'.
3161 * keymap.c (describe_vector): Remove parameters `indices' and
3162 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3163 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3165 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3167 * keyboard.c (timer_check): Remove parameter `do_it_now',
3168 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3169 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3170 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3172 * keyboard.c (read_char):
3173 * w32menu.c (w32_menu_display_help):
3174 * xmenu.c (show_help_event, menu_help_callback):
3175 Adjust calls to `show_help_echo'.
3177 * gtkutil.c (xg_maybe_add_timer):
3178 * keyboard.c (readable_events):
3179 * process.c (wait_reading_process_output):
3180 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3182 * insdel.c (adjust_markers_gap_motion):
3183 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3184 (gap_left, gap_right): Don't call it.
3186 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3188 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3189 incurred during fontification.
3191 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3193 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3194 (DEFVAR_PER_BUFFER): Don't pass it.
3196 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3197 (scrolling_window): Don't pass it.
3199 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3201 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3203 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3205 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3206 of variables specific to SELinux and computation of `encoded_absname'.
3208 * image.c (XPutPixel): Remove unused variable `height'.
3210 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3212 * unexw32.c (get_section_info): Remove unused variable `section'.
3214 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3215 (system_process_attributes): Remove unused variable `sess'.
3216 (sys_read): Remove unused variable `err'.
3218 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3219 (w32_wnd_proc): Remove unused variable `isdead'.
3220 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3221 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3222 (x_create_tip_frame): Remove unused variable `tem'.
3224 * w32inevt.c (w32_console_read_socket):
3225 Remove unused variable `no_events'.
3227 * w32term.c (x_draw_composite_glyph_string_foreground):
3228 Remove unused variable `width'.
3230 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3232 * w32term.c (x_set_glyph_string_clipping):
3233 Don't pass uninitialized region to CombineRgn.
3235 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3237 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3238 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3239 (Fx_close_connection): Remove unused variable `i'.
3241 * w32font.c (w32font_draw): Return number of glyphs.
3242 (w32font_open_internal): Remove unused variable `i'.
3243 (w32font_driver): Add missing initializer.
3245 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3246 (fill_in_menu): Remove unused variable `items_added'.
3248 * w32term.c (last_mouse_press_frame): Remove static global variable.
3249 (w32_clip_to_row): Remove unused variable `f'.
3250 (x_delete_terminal): Remove unused variable `i'.
3252 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3253 (NOTHING): Remove unused static global variable.
3254 (uniscribe_check_otf): Remove unused variable `table'.
3255 (uniscribe_font_driver): Add missing initializers.
3257 2011-03-23 Julien Danjou <julien@danjou.info>
3259 * term.c (Fsuspend_tty, Fresume_tty):
3260 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3261 * window.c (temp_output_buffer_show):
3262 * insdel.c (signal_before_change):
3263 * frame.c (Fhandle_switch_frame):
3264 * fileio.c (Fdo_auto_save):
3265 * emacs.c (Fkill_emacs):
3266 * editfns.c (save_excursion_restore):
3267 * cmds.c (internal_self_insert):
3268 * callint.c (Fcall_interactively):
3269 * buffer.c (Fkill_all_local_variables):
3270 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3272 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3273 unconditionnaly since it does the check itself.
3275 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3277 Fix more problems found by GCC 4.5.2's static checks.
3279 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3280 the first time through the loop, since we know p0 < p1 then.
3281 This also avoids a gcc -Wstrict-overflow warning.
3283 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3284 leading to a memory leak, possible in functions like
3285 load_charset_map_from_file that can allocate an unbounded number
3286 of objects (Bug#8318).
3288 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3289 that could (at least in theory) be that large.
3291 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3292 This is less likely to overflow, and avoids undefined behavior if
3293 overflow does occur. All callers changed. Use strtoul to scan
3294 for the unsigned long integer.
3295 (pint2hrstr): Simplify and tune code slightly.
3296 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3298 * scroll.c (do_scrolling): Work around GCC bug 48228.
3299 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3301 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3302 This also avoids a warning with gcc -Wstrict-overflow.
3303 (validate_x_resource_name): Simplify count usage.
3304 This also avoids a warning with gcc -Wstrict-overflow.
3306 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3309 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3311 * process.c (Fmake_network_process): Use socklen_t, not int,
3312 where POSIX says socklen_t is required in portable programs.
3313 This fixes a porting bug on hosts like 64-bit HP-UX, where
3314 socklen_t is wider than int (Bug#8277).
3315 (Fmake_network_process, server_accept_connection):
3316 (wait_reading_process_output, read_process_output):
3319 * process.c: Rename or move locals to avoid shadowing.
3320 (list_processes_1, Fmake_network_process):
3321 (read_process_output_error_handler, exec_sentinel_error_handler):
3322 Rename or move locals.
3323 (Fmake_network_process): Define label "retry_connect" only if needed.
3324 (Fnetwork_interface_info): Fix pointer signedness.
3325 (process_send_signal): Add cast to avoid pointer signedness problem.
3326 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3327 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3329 Make tparam.h and terminfo.c consistent.
3330 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3331 Include tparam.h instead, since it declares them.
3332 * cm.h (PC): Remove extern decl; tparam.h now does this.
3333 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3334 * terminfo.c: Include tparam.h, to check interfaces.
3335 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3336 (tparam): Adjust signature to match interface in tparam.h;
3337 this removes some undefined behavior. Check that outstring and len
3338 are zero, which they always are with Emacs.
3339 * tparam.h (PC, BC, UP): New extern decls.
3341 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3342 (xftfont_open): Rename locals to avoid shadowing.
3344 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3345 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3346 (OTF_TAG_SYM): Omit macro if not needed.
3347 (ftfont_list): Remove unused local.
3348 (get_adstyle_property, ftfont_pattern_entity):
3349 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3350 Rename locals to avoid shadowing.
3352 * xfont.c (xfont_list_family): Mark var as initialized.
3354 * xml.c (make_dom): Now static.
3356 * composite.c (composition_compute_stop_pos): Rename local to
3358 (composition_reseat_it): Remove unused locals.
3359 (find_automatic_composition, composition_adjust_point): Likewise.
3360 (composition_update_it): Mark var as initialized.
3361 (find_automatic_composition): Mark vars as initialized,
3362 with a FIXME (Bug#8290).
3364 character.h: Rename locals to avoid shadowing.
3365 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3366 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3367 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3368 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3371 * textprop.c (property_change_between_p): Remove; unused.
3373 * intervals.c (interval_start_pos): Now static.
3375 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3377 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3378 Rename locals to avoid shadowing.
3380 * sound.c (wav_play, au_play, Fplay_sound_internal):
3381 Fix pointer signedness.
3382 (alsa_choose_format): Remove unused local var.
3383 (wav_play): Initialize a variable to 0, to prevent undefined
3384 behavior (Bug#8278).
3386 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3388 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3390 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3391 clobbering (Bug#8298).
3392 * sysdep.c (sys_subshell): Likewise.
3393 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3395 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3396 This should get cleaned up, so that child_setup has the
3397 same signature on all platforms.
3399 * callproc.c (call_process_cleanup): Now static.
3400 (relocate_fd): Rename locals to avoid shadowing.
3402 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3404 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3405 not to be necessary, and produces flickering.
3407 2011-03-20 Glenn Morris <rgm@gnu.org>
3409 * config.in: Remove file.
3411 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3413 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3414 are now in src/globals.h.
3415 (syms_of_minibuf): Remove spurious & from previous change.
3417 2011-03-20 Leo <sdl.web@gmail.com>
3419 * minibuf.c (completing-read-function): New variable.
3420 (completing-read-default): Rename from completing-read.
3421 (completing-read): Call completing-read-function.
3423 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3425 * xfaces.c (Fx_load_color_file):
3426 Read color file from absolute filename (bug#8250).
3428 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3430 * makefile.w32-in: Update dependencies.
3432 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3434 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3436 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3438 Fix more problems found by GCC 4.5.2's static checks.
3440 * process.c (make_serial_process_unwind, send_process_trap):
3441 (sigchld_handler): Now static.
3443 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3444 That way, the code declares only the vars that it needs.
3445 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3446 * s/cygwin.h (PTY_ITERATION): Likewise.
3447 * s/darwin.h (PTY_ITERATION): Likewise.
3448 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3450 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3451 * process.c (allocate_pty): Don't declare stb unless it's needed.
3453 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3454 (CONSTANTLIM): Remove; unused.
3455 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3456 Define only if needed.
3458 * unexelf.c (unexec): Name an expression,
3459 to avoid gcc -Wbad-function-cast warning.
3460 Use a different way to cause a compilation error if anyone uses
3461 n rather than nn, a way that does not involve shadowing.
3462 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3464 * deps.mk (unexalpha.o): Remove; unused.
3466 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3467 * unexec.h: New file.
3468 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3469 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3471 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3472 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3473 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3474 Change as necessary to match prototype in unexec.h.
3476 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3478 (back_comment, skip_chars): Mark vars as initialized.
3480 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3481 Rename locals to avoid shadowing.
3483 * lread.c (read1): Rewrite so as not to use empty "else".
3484 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3486 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3488 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3489 warning when compiling print.c.
3491 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3492 instead of using an uninitialized var.
3493 (font_sort_entities): Mark var as initialized.
3495 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3497 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3498 pointers to constants.
3499 (font_parse_fcname): Remove unused vars.
3500 (font_delete_unmatched): Now static.
3501 (font_get_spec): Remove; unused.
3502 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3503 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3504 Rename or move locals to avoid shadowing.
3506 * fns.c (require_nesting_list, require_unwind): Now static.
3507 (Ffillarray): Rename locals to avoid shadowing.
3509 * floatfns.c (domain_error2): Define only if needed.
3510 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3512 * alloc.c (mark_backtrace): Move decl from here ...
3513 * lisp.h: ... to here, so that it can be checked.
3515 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3516 (Fdefvar): Rewrite so as not to use empty "else".
3517 (lisp_indirect_variable): Name an expression,
3518 to avoid gcc -Wbad-function-cast warning.
3519 (Fdefvar): Rename locals to avoid shadowing.
3521 * callint.c (quotify_arg, quotify_args): Now static.
3522 (Fcall_interactively): Rename locals to avoid shadowing.
3523 Use const pointer when appropriate.
3525 * lisp.h (get_system_name, get_operating_system_release):
3526 Move decls here, to check interfaces.
3527 * process.c (get_operating_system_release): Move decl to lisp.h.
3528 * xrdb.c (get_system_name): Likewise.
3529 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3530 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3531 some of which prompt warnings from gcc -Wbad-function-cast.
3532 (Fformat_time_string, Fencode_time, Finsert_char):
3533 (Ftranslate_region_internal, Fformat):
3534 Rename or remove local vars to avoid shadowing.
3535 (Ftranslate_region_internal): Mark var as initialized.
3537 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3540 * lisp.h (eassert): Check that the argument compiles, even if
3541 ENABLE_CHECKING is not defined.
3543 * data.c (Findirect_variable): Name an expression, to avoid
3544 gcc -Wbad-function-cast warning.
3545 (default_value, arithcompare, arith_driver, arith_error): Now static.
3546 (store_symval_forwarding): Rename local to avoid shadowing.
3547 (Fmake_variable_buffer_local, Fmake_local_variable):
3548 Mark variables as initialized.
3549 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
3551 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
3552 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3553 Rename locals to avoid shadowing.
3554 (mark_stack): Move local variables into the #ifdef region where
3556 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3557 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3559 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3560 (GC_STRING_CHARS): Remove; not used.
3561 (Fmemory_limit): Cast sbrk's returned value to char *.
3563 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3564 avoids undefined behavior in theory.
3566 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3568 Use functions, not macros, for up- and down-casing (Bug#8254).
3569 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3570 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3571 to use the following functions instead of these macros.
3572 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3573 EMACS_INT, since callers assume the returned value fits in int.
3574 (upcase1): Likewise, for UPCASE_TABLE.
3575 (uppercasep, lowercasep, upcase): New static inline functions.
3576 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
3577 the race-condition problem in the old DOWNCASE.
3579 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3580 Rename locals to avoid shadowing.
3581 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
3582 (regex_compile, re_search_2, re_match_2_internal):
3583 Remove unused local vars.
3584 (FREE_VAR): Rewrite so as not to use empty "else",
3585 which gcc can warn about.
3586 (regex_compile, re_match_2_internal): Mark locals as initialized.
3587 (RETALLOC_IF): Define only if needed.
3588 (WORDCHAR_P): Likewise. This one is never needed, but is used
3589 only in a comment talking about a compiler bug, so put inside
3590 the #if 0 of that comment.
3591 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3592 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3595 * search.c (boyer_moore): Rename locals to avoid shadowing.
3596 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3597 (PREV_CHAR_BOUNDARY): Likewise.
3599 * search.c (simple_search): Remove unused var.
3601 * dired.c (compile_pattern): Move decl from here ...
3602 * lisp.h: ... to here, so that it can be checked.
3603 (struct re_registers): New forward decl.
3605 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3607 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3609 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3610 Rename locals to avoid shadowing.
3611 (Fvertical_motion): Mark locals as initialized.
3613 * casefiddle.c (casify_object, casify_region): Now static.
3614 (casify_region): Mark local as initialized.
3616 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3618 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3619 New macros, so that the caller can use some names other than
3620 gcpro1, gcpro2, etc.
3621 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3623 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3624 argument, for consistency with GCPRO2_VAR, etc: it is now the
3625 prefix of the variable, not the variable itself. All uses
3627 * dired.c (directory_files_internal, file_name_completion):
3628 Rename locals to avoid shadowing.
3630 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3631 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3632 dired.c's scmp function, had undefined behavior.
3633 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3634 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3635 * buffer.h: ... to here, because these macros use current_buffer,
3636 and the new implementation with inline functions needs to have
3637 current_buffer in scope now, rather than later when the macros
3639 (downcase, upcase1): New static inline functions.
3640 (DOWNCASE, UPCASE1): Reimplement using these functions.
3641 This avoids undefined behavior in expressions like
3642 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3643 from race conditions in accessing the global variables
3644 case_temp1 and case_temp2.
3645 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3646 * lisp.h (case_temp1, case_temp2): Remove their decls.
3647 * character.h (ASCII_CHAR_P): Move from here ...
3648 * lisp.h: ... to here, so that the inline functions mentioned
3651 * dired.c (directory_files_internal_unwind): Now static.
3653 * fileio.c (file_name_as_directory, directory_file_name):
3654 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3656 (file_name_as_directory): Use const pointers when appropriate.
3657 (Fexpand_file_name): Likewise. In particular, newdir might
3658 point at constant storage, so make it a const pointer.
3659 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
3660 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3662 (Fset_file_times, Finsert_file_contents, auto_save_error):
3663 Rename locals to avoid shadowing.
3665 * minibuf.c (choose_minibuf_frame_1): Now static.
3666 (Ftry_completion, Fall_completions): Rename or remove locals
3669 * marker.c (bytepos_to_charpos): Remove; unused.
3671 * lisp.h (verify_bytepos, count_markers): New decls,
3672 so that gcc does not warn that these functions aren't declared.
3674 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3675 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
3676 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
3677 (copy_text): Remove unused local var.
3679 * filelock.c (within_one_second): Now static.
3680 (lock_file_1): Rename local to avoid shadowing.
3682 * buffer.c (fix_overlays_before): Mark locals as initialized.
3683 (fix_start_end_in_overlays): Likewise. This function should be
3684 simplified by using pointers-to-pointers, but that's a different
3686 (switch_to_buffer_1): Now static.
3687 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3688 (report_overlay_modification): Rename locals to avoid shadowing.
3690 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
3691 Fix pointer signedness issue.
3692 (sys_subshell): Mark local as volatile if checking for lint,
3693 to suppress a gcc -Wclobbered warning that does not seem to be right.
3694 (MAXPATHLEN): Define only if needed.
3696 * process.c (serial_open, serial_configure): Move decls from here ...
3697 * systty.h: ... to here, so that they can be checked.
3699 * fns.c (get_random, seed_random): Move extern decls from here ...
3700 * lisp.h: ... to here, so that they can be checked.
3702 * sysdep.c (reset_io): Now static.
3703 (wait_for_termination_signal): Remove; unused.
3705 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3706 (copy_keymap_item, append_key, push_text_char_description):
3708 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
3709 (DENSE_TABLE_SIZE): Remove; unused.
3710 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3711 (describe_map_tree):
3712 Rename locals to avoid shadowing.
3714 * keyboard.c: Declare functions static if they are not used elsewhere.
3715 (echo_char, echo_dash, cmd_error, top_level_2):
3716 (poll_for_input, handle_async_input): Now static.
3717 (read_char, kbd_buffer_get_event, make_lispy_position):
3718 (make_lispy_event, make_lispy_movement, apply_modifiers):
3719 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3720 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3721 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
3722 (read_key_sequence, read_char): Mark locals as initialized.
3723 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
3725 * keyboard.h (make_ctrl_char): New decl.
3726 (mark_kboards): Move decl here ...
3727 * alloc.c (mark_kboards): ... from here.
3729 * lisp.h (force_auto_save_soon): New decl.
3731 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
3732 (DEFINE_DUMMY_FUNCTION): New macro.
3733 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3735 (main): Add casts to avoid warnings
3736 if GCC considers string literals to be constants.
3738 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3740 * dbusbind.c: Pointer signedness fixes.
3741 (xd_signature, xd_append_arg, xd_initialize):
3742 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3743 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3744 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3745 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3747 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3748 if GCC considers string literals to be constants.
3749 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
3751 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3753 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3754 (print_preprocess, print_object): New macro to fix last change.
3756 * print.c (print_preprocess): Don't forget font objects.
3758 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
3760 * emacs.c (USAGE3): Doc fixes.
3762 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3764 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3767 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
3769 * lisp.h (VWindow_system, Qfile_name_history):
3770 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3771 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3772 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3774 * w32select.c: Don't #include "keyboard.h".
3775 (run_protected): Add extern declaration for waiting_for_input.
3777 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3778 * w32console.c (detect_input_pending, read_input_pending)
3779 (encode_terminal_code):
3780 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3781 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3782 (w32_system_caret_y, Qfile_name_history):
3783 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3784 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3785 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3786 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3787 * w32proc.c (Qlocal, report_file_error):
3788 * w32term.c (Vwindow_system, updating_frame):
3789 * w32uniscribe.c (initialized, uniscribe_font_driver):
3790 Remove unneeded extern declarations.
3792 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
3794 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3796 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
3798 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3799 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3800 These macros can no longer be used for assignment.
3802 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3803 Assign struct members directly, instead of using BUF_BEGV etc.
3804 (record_buffer_markers, fetch_buffer_markers): New functions for
3805 recording and fetching special buffer markers.
3806 (set_buffer_internal_1, set_buffer_temp): Use them.
3808 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3810 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3812 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3813 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3815 * xdisp.c (hscroll_window_tree):
3816 (reconsider_clip_changes): Use PT instead of BUF_PT.
3818 2011-03-13 Eli Zaretskii <eliz@gnu.org>
3820 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3821 $(EMACS_ROOT)/lib/intprops.h.
3823 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3825 Fix more problems found by GCC 4.5.2's static checks.
3827 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3828 to unsigned char * to avoid compiler diagnostic.
3829 (xg_free_frame_widgets): Make it clear that a local variable is
3830 needed only if USE_GTK_TOOLTIP.
3831 (gdk_window_get_screen): Make it clear that this macro is needed
3832 only if USE_GTK_TOOLTIP.
3833 (int_gtk_range_get_value): New function, which avoids a diagnostic
3834 from gcc -Wbad-function-cast.
3835 (xg_set_toolkit_scroll_bar_thumb): Use it.
3836 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3837 diagnostic from gcc -Wbad-function-cast.
3838 (get_utf8_string, xg_get_file_with_chooser):
3839 Rename locals to avoid shadowing.
3840 (create_dialog): Move locals to avoid shadowing.
3842 * xgselect.c (xg_select): Remove unused var.
3844 * image.c (four_corners_best): Mark locals as initialized.
3845 (gif_load): Initialize transparent_p to zero (Bug#8238).
3846 Mark another local as initialized.
3847 (my_png_error, my_error_exit): Mark with NO_RETURN.
3849 * image.c (clear_image_cache): Now static.
3850 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3851 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3852 (x_edge_detection): Remove unnecessary cast that
3853 gcc -Wbad-function-cast diagnoses.
3854 (gif_load): Fix pointer signedness.
3855 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3856 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3858 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3860 Improve quality of tests for time stamp overflow.
3861 For example, without this patch (encode-time 0 0 0 1 1
3862 1152921504606846976) returns the obviously-bogus value (-948597
3863 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3864 reports time overflow. See
3865 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3866 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3867 * editfns.c: Include limits.h and intprops.h.
3868 (TIME_T_MIN, TIME_T_MAX): New macros.
3869 (time_overflow): Move earlier, to before first use.
3870 (hi_time, lo_time): New functions, for an accurate test for
3872 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3873 (Fget_internal_run_time): Don't assume time_t fits in int.
3874 (make_time): Use list2 instead of Fcons twice.
3875 (Fdecode_time): More accurate test for out-of-range times.
3876 (check_tm_member): New function.
3877 (Fencode_time): Use it, to test for out-of-range times.
3878 (lisp_time_argument): Don't rely on undefined left-shift and
3879 right-shift behavior when checking for time stamp overflow.
3881 * editfns.c (time_overflow): New function, refactoring common code.
3882 (Fformat_time_string, Fdecode_time, Fencode_time):
3883 (Fcurrent_time_string): Use it.
3885 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3886 * dired.c (make_time): Move to ...
3887 * editfns.c (make_time): ... here.
3888 * systime.h: Note the move.
3890 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3892 * fringe.c (update_window_fringes): Remove unused variables.
3894 * unexmacosx.c (copy_data_segment): Also copy __got section.
3897 2011-03-12 Eli Zaretskii <eliz@gnu.org>
3899 * termcap.c [MSDOS]: Include "msdos.h".
3900 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3901 Constify `char *' arguments and their references according to
3902 prototypes in tparam.h.
3904 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3906 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3907 Adapt all references accordingly.
3909 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3911 2011-03-11 Tom Tromey <tromey@redhat.com>
3913 * buffer.c (syms_of_buffer): Remove obsolete comment.
3915 2011-03-11 Eli Zaretskii <eliz@gnu.org>
3917 * termhooks.h (encode_terminal_code): Declare prototype.
3919 * msdos.c (encode_terminal_code): Don't declare prototype.
3921 * term.c (encode_terminal_code): Now external again, used by
3922 w32console.c and msdos.c.
3924 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3925 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3927 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3929 Fix some minor problems found by GCC 4.5.2's static checks.
3931 * fringe.c (update_window_fringes): Mark locals as initialized
3933 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3935 * alloc.c (mark_fringe_data): Move decl from here ...
3936 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3937 to check its interface.
3938 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3940 * fontset.c (free_realized_fontset): Now static.
3941 (Fset_fontset_font): Rename local to avoid shadowing.
3942 (fontset_font): Mark local as initialized.
3943 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3945 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3947 * xselect.c (x_disown_buffer_selections): Remove; not used.
3948 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3949 (x_own_selection, Fx_disown_selection_internal): Rename locals
3951 (x_handle_dnd_message): Remove local to avoid shadowing.
3953 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3954 so that the caller can use some name other than gcpro1.
3955 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3956 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3957 (Fx_backspace_delete_keys_p):
3958 Use them to avoid shadowing, and rename vars to avoid shadowing.
3959 (x_decode_color, x_set_name, x_window): Now static.
3960 (Fx_create_frame): Add braces to silence GCC warning.
3961 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3962 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3963 Remove unused locals.
3964 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3965 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3966 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3969 * xterm.h (x_mouse_leave): New decl.
3971 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3972 Remove unused functions.
3973 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3974 (x_calc_absolute_position): Now static.
3975 (XTread_socket): Don't define label "out" unless it's used.
3976 Don't declare local "event" unless it's used.
3977 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3978 unless they are used.
3979 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3980 (x_fatal_error_signal): Remove; not used.
3981 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3982 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3983 (x_error_catcher, x_connection_closed, x_error_handler):
3984 (x_error_quitter, xembed_send_message, x_iconify_frame):
3985 (my_log_handler): Rename locals to avoid shadowing.
3986 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3987 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3989 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3990 Rename or move locals to avoid shadowing.
3991 (tty_defined_color, merge_face_heights): Now static.
3992 (free_realized_faces_for_fontset): Remove; not used.
3993 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3994 does not deduce is never used uninitialized.
3995 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3996 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3998 * terminal.c (store_terminal_param): Now static.
4000 * xmenu.c (menu_highlight_callback): Now static.
4001 (set_frame_menubar): Remove unused local.
4002 (xmenu_show): Rename parameter to avoid shadowing.
4003 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4004 since they might point to immutable storage.
4005 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4006 since it's unused otherwise.
4008 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4009 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4010 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4011 avoids a gcc -Wuninitialized diagnostic.
4012 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4013 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4014 does not deduce are never used uninitialized.
4016 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4018 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4019 * window.c (window_loop, size_window):
4020 (run_window_configuration_change_hook, enlarge_window): Likewise.
4022 * window.c (display_buffer): Now static.
4023 (size_window): Mark variables that gcc -Wuninitialized
4024 does not deduce are never used uninitialized.
4025 * window.h (check_all_windows): New decl, to forestall
4026 gcc -Wmissing-prototypes diagnostic.
4027 * dispextern.h (bidi_dump_cached_states): Likewise.
4029 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4031 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4033 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4034 and to avoid gcc -Wuninitialized warning.
4035 (load_charset_map): Mark variables that gcc -Wuninitialized
4036 does not deduce are never used uninitialized.
4037 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4039 * coding.c (coding_set_source, coding_set_destination):
4040 Use "else { /* comment */ }" rather than "else /* comment */;"
4041 for clarity, and to avoid gcc -Wempty-body warning.
4042 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4043 a block, when the outer 'i' will do.
4044 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4045 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4046 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4047 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4048 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4049 Rename locals to avoid shadowing.
4050 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4051 * coding.c (emacs_mule_char, encode_invocation_designation):
4052 Now static, since they're not used elsewhere.
4053 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4054 (decode_coding_object, encode_coding_object, detect_coding_system):
4055 (decode_coding_emacs_mule): Mark variables that gcc
4056 -Wuninitialized does not deduce are never used uninitialized.
4057 (detect_coding_iso_2022): Initialize a local variable that might
4058 be used uninitialized. Leave a FIXME because it's not clear that
4059 this initialization is needed. (Bug#8211)
4060 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4061 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4062 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4063 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4064 Remove unused macros.
4066 * category.c (hash_get_category_set): Remove unused local var.
4067 (copy_category_table): Now static, since it's not used elsewhere.
4068 * character.c (string_count_byte8): Likewise.
4070 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4071 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4073 * chartab.c (copy_sub_char_table): Now static, since it's not used
4075 (sub_char_table_ref_and_range, char_table_ref_and_range):
4076 Rename locals to avoid shadowing.
4077 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4079 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4080 (BIDI_BOB): Remove unused macro.
4082 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4083 deduce are never used uninitialized.
4084 * term.c (encode_terminal_code): Likewise.
4086 * term.c (encode_terminal_code): Now static. Remove unused local.
4088 * tparam.h: New file.
4089 * term.c, tparam.h: Include it.
4090 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4091 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4092 Move these decls to tparam.h, and make them agree with what
4093 is actually in tparam.c. The previous trick of using incompatible
4094 decls in different modules does not conform to the C standard.
4095 All callers of tparam changed to use tparam's actual API.
4096 * tparam.c (tparam1, tparam, tgoto):
4097 Use const pointers where appropriate.
4099 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4100 * cm.h (struct cm): Likewise.
4101 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4102 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4103 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4104 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4105 (turn_on_face, init_tty): Likewise.
4106 * termchar.h (struct tty_display_info): Likewise.
4108 * term.c (term_mouse_position): Rename local to avoid shadowing.
4110 * alloc.c (mark_ttys): Move decl from here ...
4111 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4113 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4115 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4117 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4119 * search.c (compile_pattern_1): Remove argument regp, unused since
4120 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4121 (compile_pattern): Don't pass it.
4123 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4125 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4126 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4128 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4130 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4132 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4133 gdk_window_get_screen, gdk_window_get_geometry,
4134 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4135 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4136 (xg_get_pixbuf_from_pixmap): New function.
4137 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4138 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4139 Call xg_get_pixbuf_from_pixmap instead of
4140 gdk_pixbuf_get_from_drawable.
4141 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4142 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4143 (xg_check_special_colors): Use GtkStyleContext and its functions
4145 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4146 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4147 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4148 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4149 Call gtk_widget_get_preferred_size.
4150 (xg_frame_resized): gdk_window_get_geometry only takes 5
4152 (xg_win_to_widget, xg_event_is_for_menubar):
4153 Call gdk_x11_window_lookup_for_display.
4154 (xg_set_widget_bg): New function.
4155 (delete_cb): New function.
4156 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4157 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4158 (xg_set_background_color): Call xg_set_widget_bg.
4159 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4160 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4161 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4162 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4164 (update_frame_tool_bar): Call gtk_widget_hide.
4165 (xg_initialize): Use GDK_KEY_g.
4167 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4169 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4171 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4172 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4173 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4175 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4177 * w32xfns.c (select_palette): Check success of RealizePalette against
4178 GDI_ERROR, not zero.
4180 See ChangeLog.11 for earlier changes.
4186 Copyright (C) 2011 Free Software Foundation, Inc.
4188 This file is part of GNU Emacs.
4190 GNU Emacs is free software: you can redistribute it and/or modify
4191 it under the terms of the GNU General Public License as published by
4192 the Free Software Foundation, either version 3 of the License, or
4193 (at your option) any later version.
4195 GNU Emacs is distributed in the hope that it will be useful,
4196 but WITHOUT ANY WARRANTY; without even the implied warranty of
4197 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4198 GNU General Public License for more details.
4200 You should have received a copy of the GNU General Public License
4201 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.