1 2011-06-08 Paul Eggert <eggert@cs.ucla.edu>
3 * alloc.c: Use EMACS_INT, not int, to count objects.
4 (total_conses, total_markers, total_symbols, total_vector_size)
5 (total_free_conses, total_free_markers, total_free_symbols)
6 (total_free_floats, total_floats, total_free_intervals, total_intervals)
7 (total_strings, total_free_strings):
8 Now EMACS_INT, not int. All uses changed.
9 (Fgarbage_collect): Compute overall total using a double, so that
10 integer overflow is less likely to be a problem. Check for overflow
11 when converting back to an integer.
12 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
13 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
14 These were 'int' variables that could overflow on 64-bit hosts;
15 they were never used, so remove them instead of repairing them.
17 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
18 (allocate_vectorlike): Check for ptrdiff_t overflow.
19 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
20 when a (possibly-narrower) signed value would do just as well.
21 We prefer using signed arithmetic, to avoid comparison confusion.
23 * alloc.c: Catch some string size overflows that we were missing.
24 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
25 for convenience in STRING_BYTES_MAX.
26 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
27 The definition here is exact; the one in lisp.h was approximate.
28 (allocate_string_data): Check for string overflow. This catches
29 some instances we weren't catching before. Also, it catches
30 size_t overflow on (unusual) hosts where SIZE_MAX <= min
31 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
32 and ptrdiff_t and EMACS_INT are both 64 bits.
34 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
35 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
36 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
38 2011-06-07 Paul Eggert <eggert@cs.ucla.edu>
40 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
42 * alloc.c (Fmake_string): Check for out-of-range init.
44 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
46 * fns.c (Fputhash): Document return value.
48 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
50 * image.c (gif_load): Implement gif89a spec "no disposal" method.
52 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
54 Cons<->int and similar integer overflow fixes (Bug#8794).
56 Check for overflow when converting integer to cons and back.
57 * charset.c (Fdefine_charset_internal, Fdecode_char):
58 Use cons_to_unsigned to catch overflow.
59 (Fencode_char): Use INTEGER_TO_CONS.
60 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
61 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
62 * data.c (long_to_cons, cons_to_long): Remove.
63 (cons_to_unsigned, cons_to_signed): New functions.
64 These signal an error for invalid or out-of-range values.
65 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
66 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
67 * font.c (Ffont_variation_glyphs):
68 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
69 * lisp.h: Include <intprops.h>.
70 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
71 (cons_to_signed, cons_to_unsigned): New decls.
72 (long_to_cons, cons_to_long): Remove decls.
73 * undo.c (record_first_change): Use INTEGER_TO_CONS.
74 (Fprimitive_undo): Use CONS_TO_INTEGER.
75 * xfns.c (Fx_window_property): Likewise.
76 * xselect.c: Include <limits.h>.
77 (x_own_selection, selection_data_to_lisp_data):
79 (x_handle_selection_request, x_handle_selection_clear)
80 (x_get_foreign_selection, Fx_disown_selection_internal)
81 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
82 (lisp_data_to_selection_data): Use cons_to_unsigned.
83 (x_fill_property_data): Use cons_to_signed.
84 Report values out of range.
86 Check for buffer and string overflow more precisely.
87 * buffer.h (BUF_BYTES_MAX): New macro.
88 * lisp.h (STRING_BYTES_MAX): New macro.
89 * alloc.c (Fmake_string):
90 * character.c (string_escape_byte8):
91 * coding.c (coding_alloc_by_realloc):
93 * editfns.c (Fformat):
95 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
96 since they may not be the same number.
97 * editfns.c (Finsert_char):
98 * fileio.c (Finsert_file_contents):
99 Likewise for BUF_BYTES_MAX.
101 * image.c: Use ptrdiff_t, not int, for sizes.
102 (slurp_file): Switch from int to ptrdiff_t.
104 (slurp_file): Check that file size fits in both size_t (for
105 malloc) and ptrdiff_t (for sanity and safety).
107 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
108 if b->modtime has its maximal value.
110 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
112 Don't assume time_t can fit into int.
113 * buffer.h (struct buffer.modtime): Now time_t, not int.
114 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
115 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
117 Minor fixes for signed vs unsigned integers.
118 * character.h (MAYBE_UNIFY_CHAR):
119 * charset.c (maybe_unify_char):
120 * keyboard.c (read_char, reorder_modifiers):
121 XINT -> XFASTINT, since the integer must be nonnegative.
122 * ftfont.c (ftfont_spec_pattern):
123 * keymap.c (access_keymap, silly_event_symbol_error):
124 XUINT -> XFASTINT, since the integer must be nonnegative.
125 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
126 since it makes no difference and we prefer signed.
127 * keyboard.c (record_char): Use XUINT when all the neighbors do.
128 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
131 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
133 * window.h (Fwindow_frame): Declare.
135 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
137 * alloc.c: Simplify handling of large-request failures (Bug#8800).
138 (SPARE_MEMORY): Always define.
139 (LARGE_REQUEST): Remove.
140 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
142 2011-06-06 Martin Rudalics <rudalics@gmx.at>
144 * lisp.h: Move EXFUNS for Fframe_root_window,
145 Fframe_first_window and Fset_frame_selected_window to window.h.
147 * window.h: Move EXFUNS for Fframe_root_window,
148 Fframe_first_window and Fset_frame_selected_window here from
151 * frame.c (Fwindow_frame, Fframe_first_window)
152 (Fframe_root_window, Fframe_selected_window)
153 (Fset_frame_selected_window): Move to window.c.
154 (Factive_minibuffer_window): Move to minibuf.c.
155 (Fother_visible_frames_p): New function.
157 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
159 * window.c (decode_window, decode_any_window): Move up in code.
160 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
161 (inhibit_frame_unsplittable): Remove unused variable.
162 (Fwindow_buffer): Move up and rewrite doc-string.
163 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
164 (Fwindow_prev): New functions.
165 (Fwindow_frame): Move here from frame.c. Accept any window as
167 (Fframe_root_window, Fframe_first_window)
168 (Fframe_selected_window): Move here from frame.c. Accept frame
169 or arbitrary window as argument. Update doc-strings.
170 (Fminibuffer_window): Move up in code.
171 (Fwindow_minibuffer_p): Move up in code and simplify.
172 (Fset_frame_selected_window): Move here from frame.c.
174 (Fselected_window, select_window, Fselect_window): Move up in
175 code. Minor doc-string fixes.
177 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
179 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
180 Do not assume that spare memory exists; that assumption is valid
181 only if SYSTEM_MALLOC.
182 (LARGE_REQUEST): New macro, so that the issue of large requests
183 is separated from the issue of spare memory.
185 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
187 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
190 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
192 * xfns.c (x_set_scroll_bar_default_width): Move declarations
195 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
197 * gtkutil.c (xg_get_default_scrollbar_width): New function.
199 * gtkutil.h: Declare xg_get_default_scrollbar_width.
201 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
202 min width by calling x_set_scroll_bar_default_width (Bug#8505).
204 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
206 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
208 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
210 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
211 (x_clipboard_manager_save): Add return value.
212 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
214 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
215 Obey Vx_select_enable_clipboard_manager. Catch errors in
216 x_clipboard_manager_save (Bug#8779).
217 (Vx_select_enable_clipboard_manager): New variable.
218 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
220 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
222 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
224 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
226 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
227 in the current matrix if keep_current_p is non-zero.
229 2011-06-04 Eli Zaretskii <eliz@gnu.org>
231 * bidi.c (bidi_level_of_next_char): Fix last change.
233 2011-06-03 Eli Zaretskii <eliz@gnu.org>
235 Support bidi reordering of text covered by display properties.
237 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
238 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
239 (bidi_cache_search, bidi_cache_iterator_state)
240 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
241 (bidi_level_of_next_char, bidi_move_to_visually_next):
242 Support character positions inside a run of characters covered by a
244 (bidi_paragraph_init, bidi_resolve_explicit_1)
245 (bidi_level_of_next_char): Call bidi_fetch_char and
246 bidi_fetch_char_advance instead of FETCH_CHAR and
248 (bidi_init_it): Initialize new members.
249 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
251 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
252 instead of using explicit *_CHAR codes.
253 (bidi_resolve_explicit, bidi_resolve_weak):
254 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
255 bidirectional text is supported only in multibyte buffers.
256 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
257 it to initialize the frame_window_p member of struct bidi_it.
258 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
259 (bidi_resolve_explicit, bidi_resolve_weak)
260 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
261 bidi_it->nchars is non-positive.
262 (bidi_level_of_next_char): Don't try to lookup the cache for the
263 next/previous character if nothing is cached there yet, or if we
264 were just reseat()'ed to a new position.
266 * xdisp.c (set_cursor_from_row): Set start and stop points
267 according to the row's direction when priming the loop that looks
268 for the glyph on which to display cursor.
269 (single_display_spec_intangible_p): Function deleted.
270 (display_prop_intangible_p): Reimplement to call
271 handle_display_spec instead of single_display_spec_intangible_p.
272 Accept 3 additional arguments needed by handle_display_spec.
273 This fixes incorrect cursor motion across display property with complex
274 values: lists, `(when COND...)' forms, etc.
275 (single_display_spec_string_p): Support property values that are
276 lists with the argument STRING its top-level element.
277 (display_prop_string_p): Fix the condition for processing a
278 property that is a list to be consistent with handle_display_spec.
279 (handle_display_spec): New function, refactored from the
280 last portion of handle_display_prop.
281 (compute_display_string_pos): Accept additional argument
282 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
283 value of a `display' property is a "replacing spec".
284 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
285 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
286 the display property, but just return a value indicating whether
287 the display property will replace the characters it covers.
288 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
289 frame_window_p members of struct bidi_it.
290 (compute_display_string_pos, compute_display_string_end):
292 (push_it): Accept second argument POSITION, where pop_it should
293 jump to continue iteration.
294 (reseat_1): Initialize bidi_it.disp_pos.
296 * keyboard.c (adjust_point_for_property): Adjust the call to
297 display_prop_intangible_p to its new signature.
299 * dispextern.h (struct bidi_it): New member frame_window_p.
300 (bidi_init_it): Update prototypes.
301 (display_prop_intangible_p): Update prototype.
302 (compute_display_string_pos, compute_display_string_end):
304 (struct bidi_it): New members nchars and disp_pos. ch_len is now
307 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
309 Malloc failure behavior now depends on size of allocation.
310 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
311 * lisp.h: Change signatures accordingly.
312 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
313 All callers changed. (Bug#8762)
315 * gnutls.c: Use Emacs's memory allocators.
316 Without this change, the gnutls library would invoke malloc etc.
317 directly, which causes problems on non-SYNC_INPUT hosts, and which
318 runs afoul of improving memory_full behavior. (Bug#8761)
319 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
320 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
321 xfree instead of the default malloc, realloc, free.
322 (Fgnutls_boot): No need to check for memory allocation failure,
323 since xmalloc does that for us.
325 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
326 * category.c (hash_get_category_set):
327 * ccl.c (ccl_driver):
328 * charset.c (Fdefine_charset_internal):
329 * charset.h (struct charset.hash_index):
330 * composite.c (get_composition_id, gstring_lookup_cache)
331 (composition_gstring_put_cache):
332 * composite.h (struct composition.hash_index):
333 * dispextern.h (struct image.hash):
334 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
335 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
336 (hashfn_equal, hashfn_user_defined, make_hash_table)
337 (maybe_resize_hash_table, hash_lookup, hash_put)
338 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
339 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
340 (Fsxhash, Fgethash, Fputhash, Fmaphash):
341 * image.c (make_image, search_image_cache, lookup_image)
342 (xpm_put_color_table_h):
343 * lisp.h (struct Lisp_Hash_Table):
344 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
345 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
346 for hashes and hash indexes, instead of 'unsigned' and 'int'.
347 * alloc.c (allocate_vectorlike):
348 Check for overflow in vector size calculations.
349 * ccl.c (ccl_driver):
350 Check for overflow when converting EMACS_INT to int.
351 * fns.c, image.c: Remove unnecessary static decls that would otherwise
352 need to be updated by these changes.
353 * fns.c (make_hash_table, maybe_resize_hash_table):
354 Check for integer overflow with large hash tables.
355 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
356 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
357 (SXHASH_REDUCE): New macro.
358 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
359 Use it instead of discarding useful hash info with large hash values.
360 (sxhash_float): New function.
361 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
362 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
363 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
364 Rewrite to use FIXNUM_BITS, as this simplifies things.
365 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
366 Adjust signatures to match updated version of code.
367 (consing_since_gc): Now EMACS_INT, since a single hash table can
368 use more than INT_MAX bytes.
370 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
372 Make it possible to build with GCC-4.6+ -O2 -flto.
374 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
376 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
378 * minibuf.c (get_minibuffer, read_minibuf_unwind):
379 Call minibuffer-inactive-mode.
381 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
383 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
386 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
388 * data.c (init_data): Remove code for UTS, this system is not
391 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
393 Don't force ./temacs to start in terminal mode.
395 * frame.c (make_initial_frame): Initialize faces in all cases, not
396 only when CANNOT_DUMP is defined.
397 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
399 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
401 * dispnew.c (add_window_display_history): Use const for the string
402 pointer. Remove declaration, not needed.
404 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
406 Use 'inline', not 'INLINE'.
407 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
408 * alloc.c, fontset.c (INLINE): Remove.
409 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
410 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
411 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
412 * gmalloc.c (register_heapinfo): Use inline unconditionally.
413 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
415 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
417 Make it possible to run ./temacs.
419 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
420 syms_of_callproc does the same thing. Remove test for
421 "initialized", do it in the caller.
422 * emacs.c (main): Avoid calling set_initial_environment when dumping.
424 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
426 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
427 (read_minibuf): Use get_minibuffer.
428 (syms_of_minibuf): Use DEFSYM.
429 (Qmetadata): New var.
430 * data.c (Qbuffer): Don't make it static.
431 (syms_of_data): Use DEFSYM.
433 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
435 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
436 (CCL_CODE_MIN): New macro.
438 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
440 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
442 * eval.c (Qdebug): Now static.
443 * lisp.h (Qdebug): Remove decl. This reverts a part of the
444 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
445 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
447 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
449 * image.c: Various fixes to ImageMagick code comments.
450 (Fimagemagick_types): Doc fix.
452 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
454 Minor fixes prompted by GCC 4.6.0 warnings.
456 * xselect.c (converted_selections, conversion_fail_tag): Now static.
458 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
459 (x_clipboard_manager_save_all): Move extern decl to ...
460 * xterm.h: ... here, so that it can be checked for consistency.
462 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
464 * xselect.c (x_clipboard_manager_save_frame)
465 (x_clipboard_manager_save_all): New functions.
466 (Fx_clipboard_manager_save): Lisp function deleted.
468 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
469 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
471 * xterm.h: Update prototype.
473 2011-05-28 William Xu <william.xwl@gmail.com>
475 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
478 2011-05-28 Jim Meyering <meyering@redhat.com>
480 Avoid a sign-extension bug in crypto_hash_function.
481 * fns.c (to_uchar): Define.
482 (crypto_hash_function): Use it to convert some newly-signed
483 variables to unsigned, to avoid sign-extension bugs. For example,
484 without this change, (md5 "truc") would evaluate to
485 45723a2aff78ff4fff7fff1114760e62 rather than the expected
486 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
487 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
489 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
491 Integer overflow fixes.
493 * dbusbind.c: Serial number integer overflow fixes.
494 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
495 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
496 to hold a serial number that is too large for a fixnum.
497 (Fdbus_method_return_internal, Fdbus_method_error_internal):
498 Check for serial numbers out of range. Decode any serial number
499 that was so large that it became a float. (Bug#8722)
501 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
502 (Fdbus_call_method, Fdbus_call_method_asynchronously):
503 Use XFASTINT rather than XUINT when numbers are nonnegative.
504 (xd_append_arg, Fdbus_method_return_internal):
505 (Fdbus_method_error_internal): Likewise. Also, for unsigned
506 arguments, check that Lisp number is nonnegative, rather than
507 silently wrapping negative numbers around. (Bug#8722)
508 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
511 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
513 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
515 ccl: add integer overflow checks
516 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
517 (IN_INT_RANGE): New macros.
518 (ccl_driver): Use them to check for integer overflow when
519 decoding a CCL program. Many of the new checks are whether XINT (x)
520 fits in int; it doesn't always, on 64-bit hosts. The new version
521 doesn't catch all possible integer overflows, but it's an
522 improvement. (Bug#8719)
524 * alloc.c (make_event_array): Use XINT, not XUINT.
525 There's no need for unsigned here.
527 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
528 This follows up to the 2011-05-06 change that substituted uintptr_t
529 for EMACS_INT. This case wasn't caught back then.
531 Rework Fformat to avoid integer overflow issues.
532 * editfns.c: Include <float.h> unconditionally, as it's everywhere
533 now (part of C89). Include <verify.h>.
534 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
535 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
536 (Fformat): Avoid the prepass trying to compute sizes; it was only
537 approximate and thus did not catch overflow reliably. Instead, walk
538 through the format just once, formatting and computing sizes as we go,
539 checking for integer overflow at every step, and allocating a larger
540 buffer as needed. Keep track separately whether the format is
541 multibyte. Keep only the most-recently calculated precision, rather
542 than them all. Record whether each argument has been converted to
543 string. Use EMACS_INT, not int, for byte and char and arg counts.
544 Support field widths and precisions larger than INT_MAX. Avoid
545 sprintf's undefined behavior with conversion specifications such as %#d
546 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
547 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
548 formatting out-of-range floating point numbers with int
551 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
553 * data.c: Avoid integer truncation in expressions involving floats.
554 * data.c: Include <intprops.h>.
555 (arith_driver): When there's an integer overflow in an expression
556 involving floating point, convert the integers to floating point
557 so that the resulting value does not suffer from catastrophic
558 integer truncation. For example, on a 64-bit host (* 4
559 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
560 Do not rely on undefined behavior after integer overflow.
562 merge count_size_as_multibyte, parse_str_to_multibyte
563 * character.c, character.h (count_size_as_multibyte):
564 Rename from parse_str_to_multibyte; all uses changed.
565 Check for integer overflow.
566 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
567 since it's now a duplicate of the other. This is more of
568 a character than a buffer op, so better that it's in character.c.
569 * fns.c, print.c: Adjust to above changes.
571 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
573 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
575 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
577 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
578 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
579 (x_clipboard_manager_save): Now static.
580 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
582 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
583 (crypto_hash_function): Now static.
584 Fix pointer signedness problems. Avoid unnecessary initializations.
586 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
588 * termhooks.h (Vselection_alist): Make it terminal-local.
590 * terminal.c (create_terminal): Initialize it.
592 * xselect.c: Support for clipboard managers.
593 (Vselection_alist): Move to termhooks.h as terminal-local var.
594 (LOCAL_SELECTION): New macro.
595 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
596 (symbol_to_x_atom): Remove gratuitous arg.
597 (x_handle_selection_request, lisp_data_to_selection_data)
598 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
599 (x_own_selection, x_get_local_selection, x_convert_selection):
600 New arg, specifying work frame. Use terminal-local Vselection_alist.
601 (some_frame_on_display): Delete unused function.
602 (Fx_own_selection_internal, Fx_get_selection_internal)
603 (Fx_disown_selection_internal, Fx_selection_owner_p)
604 (Fx_selection_exists_p): New optional frame arg.
605 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
606 (x_handle_selection_clear): Don't treat other terminals with the
607 same keyboard specially. Use the terminal-local Vselection_alist.
608 (x_clear_frame_selections): Use Frun_hook_with_args.
610 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
612 * xterm.h: Add support for those atoms.
614 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
616 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
617 (converted_selections, conversion_fail_tag): New global variables.
618 (x_selection_request_lisp_error): Free the above.
619 (x_get_local_selection): Remove unnecessary code.
620 (x_reply_selection_request): Args changed; handle arbitrary array
621 of converted selections stored in converted_selections.
622 Separate the XChangeProperty and SelectionNotify steps.
623 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
624 (x_convert_selection): New function.
625 (x_handle_selection_event): Simplify.
626 (x_get_foreign_selection): Don't ignore incoming requests while
627 waiting for an answer; this will fail when we implement
628 SAVE_TARGETS, and seems unnecessary anyway.
629 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
630 (Vx_sent_selection_functions): Doc fix.
632 2011-05-26 Leo Liu <sdl.web@gmail.com>
634 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
636 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
638 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
640 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
641 for fringe update if it has periodic bitmap.
642 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
643 and fringe_bitmap_periodic_p.
645 * fringe.c (get_fringe_bitmap_data): New function.
646 (draw_fringe_bitmap_1, update_window_fringes): Use it.
647 (update_window_fringes): Record periodicity of fringe bitmap in glyph
648 row. Mark glyph row for fringe update if periodicity changed.
650 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
651 for fringe update unless it has periodic bitmap.
653 2011-05-25 Kenichi Handa <handa@m17n.org>
655 * xdisp.c (get_next_display_element): Set correct it->face_id for
656 a static composition.
658 2011-05-24 Leo Liu <sdl.web@gmail.com>
661 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
663 * fns.c (crypto_hash_function, Fsha1): New function.
664 (Fmd5): Use crypto_hash_function.
665 (syms_of_fns): Add Ssha1.
667 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
669 * gnutls.c: Remove unused macros.
670 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
671 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
672 Remove macros that are defined and never used.
673 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
675 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
677 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
678 (Fx_get_selection_internal): Minor cleanup.
679 (Fx_own_selection_internal): Rename arguments for consistency with
682 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
684 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
686 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
688 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
690 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
692 * dispnew.c (scrolling_window): Don't exclude the case that the
693 last enabled row in the desired matrix touches the bottom boundary.
695 2011-05-21 Glenn Morris <rgm@gnu.org>
697 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
698 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
699 and add some more files.
701 2011-05-20 Eli Zaretskii <eliz@gnu.org>
703 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
704 report_file_error introduced by the change from 2011-05-07.
706 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
708 * systime.h (Time): Define only if emacs is defined.
709 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
710 where the include path doesn't have X11/X.h by default. See
711 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
713 2011-05-20 Kenichi Handa <handa@m17n.org>
715 * composite.c (find_automatic_composition): Fix previous change.
717 2011-05-20 Glenn Morris <rgm@gnu.org>
719 * lisp.mk: New file, split from Makefile.in.
720 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
722 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
724 2011-05-19 Glenn Morris <rgm@gnu.org>
726 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
727 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
728 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
729 (lisp): Set the order to that of loadup.el.
730 (shortlisp): Make it a copy of $lisp.
731 (SOME_MACHINE_LISP): Remove.
732 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
733 Use just $shortlisp, not $SOME_MACHINE_LISP too.
735 2011-05-18 Kenichi Handa <handa@m17n.org>
737 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
738 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
739 (find_automatic_composition): Mostly rewrite for efficiency.
741 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
743 * makefile.w32-in: Update dependencies.
745 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
747 * menu.c: Include limits.h (fixes the MS-Windows build broken by
750 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
752 Fix some integer overflow issues, such as string length overflow.
754 * insdel.c (count_size_as_multibyte): Check for string overflow.
756 * character.c (lisp_string_width): Check for string overflow.
757 Use EMACS_INT, not int, for string indexes and lengths; in
758 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
759 the resulting string length overflows an EMACS_INT; instead,
760 report a string overflow if no precision given. When checking for
761 precision exhaustion, use a check that cannot possibly have
762 integer overflow. (Bug#8675)
763 * character.h (lisp_string_width): Adjust to new signature.
765 * alloc.c (string_overflow): New function.
766 (Fmake_string): Use it. This doesn't change behavior, but saves
767 a few bytes and will simplify future changes.
768 * character.c (string_escape_byte8): Likewise.
769 * lisp.h (string_overflow): New decl.
771 Fixups, following up to the user-interface timestamp change.
772 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
773 for UI timestamps, instead of unsigned long.
774 * msdos.c (mouse_get_pos): Likewise.
775 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
776 * w32gui.h (Time): Define by including "systime.h" rather than by
777 declaring it ourselves. (Bug#8664)
779 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
780 * image.c (clear_image_cache): Likewise.
782 * term.c (term_mouse_position): Don't assume time_t wraparound.
784 Be more systematic about user-interface timestamps.
785 Before, the code sometimes used 'Time', sometimes 'unsigned long',
786 and sometimes 'EMACS_UINT', to represent these timestamps.
787 This change causes it to use 'Time' uniformly, as that's what X uses.
788 This makes the code easier to follow, and makes it easier to catch
789 integer overflow bugs such as Bug#8664.
790 * frame.c (Fmouse_position, Fmouse_pixel_position):
791 Use Time, not unsigned long, for user-interface timestamps.
792 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
793 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
794 * keyboard.h (last_event_timestamp): Likewise.
795 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
796 * menu.h (xmenu_show): Likewise.
797 * term.c (term_mouse_position): Likewise.
798 * termhooks.h (struct input_event.timestamp): Likewise.
799 (struct terminal.mouse_position_hook): Likewise.
800 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
801 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
802 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
803 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
805 * menu.h, termhooks.h: Include "systime.h", for Time.
807 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
808 Don't assume that the difference between two unsigned long values
809 can fit into an integer. At this point, we know button_down_time
810 <= event->timestamp, so the difference must be nonnegative, so
811 there's no need to cast the result if double-click-time is
812 nonnegative, as it should be; check that it's nonnegative, just in
813 case. This bug is triggered when events are more than 2**31 ms
814 apart (about 25 days). (Bug#8664)
816 * xselect.c (last_event_timestamp): Remove duplicate decl.
817 (x_own_selection): Remove needless cast to unsigned long.
819 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
820 that always fit in int. Use a sentinel instead of a counter, to
821 avoid a temp and to allay GCC's concerns about possible int overflow.
822 * frame.h (struct frame): Use int for menu_bar_items_used
823 instead of EMACS_INT, since it always fits in int.
825 * menu.c (grow_menu_items): Check for int overflow.
827 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
829 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
830 Before, the code was not consistent. These values cannot exceed
831 2**31 - 1 so there's no need to make them unsigned.
832 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
833 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
834 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
836 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
838 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
839 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
840 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
841 presumably because the widths might not match.
843 * window.c (size_window): Avoid needless test at loop start.
845 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
847 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
849 2011-05-12 Drew Adams <drew.adams@oracle.com>
851 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
853 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
855 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
856 `width' to `bar_area_x' and `bar_area_width', respectively.
857 (x_scroll_run): Take account of fringe background extension.
859 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
860 Rename local vars `left' and `width' to `bar_area_x' and
861 `bar_area_width', respectively.
862 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
863 background extension.
865 2011-05-10 Jim Meyering <meyering@redhat.com>
867 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
869 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
871 * image.c (Finit_image_library): Return t for built-in image types,
872 like pbm and xbm. (Bug#8640)
874 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
876 * w32menu.c (set_frame_menubar): Fix submenu allocation.
878 2011-05-07 Eli Zaretskii <eliz@gnu.org>
880 * w32console.c (Fset_screen_color): Doc fix.
881 (Fget_screen_color): New function.
882 (syms_of_ntterm): Defsubr it.
884 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
885 unlink the temporary file if Fcall_process didn't create it in the
887 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
888 child process will be redirected to a file specified with `:file'.
889 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
890 cue to call_process_cleanup not to close that handle.
892 2011-05-07 Ben Key <bkey76@gmail.com>
894 * makefile.w32-in: The bootstrap-temacs rule now makes use of
895 one of two shell specific rules, either bootstrap-temacs-CMD or
896 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
897 to the previous implementation of the bootstrap-temacs rule.
898 The bootstrap-temacs-CMD rule is similar to the previous
899 implementation of the bootstrap-temacs rule except that it
900 makes use of the ESC_CFLAGS variable instead of the CFLAGS
903 These changes, along with some changes to nt/configure.bat,
904 nt/gmake.defs, and nt/nmake.defs, are required to extend my
905 earlier fix to add support for --cflags and --ldflags options
906 that include quotes so that it works whether make uses cmd or
909 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
911 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
912 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
914 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
915 a string. Handle both cases.
916 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
917 (Fdbus_register_method): Use Qinvalid_function.
919 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
921 * makefile.w32-in: Update dependencies.
922 (LISP_H): Add inttypes.h and stdin.h.
923 (PROCESS_H): Add unistd.h.
925 2011-05-06 Eli Zaretskii <eliz@gnu.org>
927 * lread.c: Include limits.h (fixes the MS-Windows build broken by
928 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
930 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
932 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
934 * term.c (vfatal): Remove stray call to va_end.
935 It's not needed and the C Standard doesn't allow it here anyway.
937 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
938 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
940 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
943 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
945 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
947 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
949 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
951 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
953 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
954 * charset.c (Fdefine_charset_internal): Don't initialize
955 charset.code_space[15]. The value was garbage, on hosts with
956 32-bit int (Bug#8600).
958 * lread.c (read_integer): Be more consistent with string-to-number.
959 Use string_to_number to do the actual conversion; this avoids
960 rounding errors and fixes some other screwups. Without this fix,
961 for example, #x1fffffffffffffff was misread as -2305843009213693952.
962 (digit_to_number): Move earlier, for benefit of read_integer.
963 Return -1 if the digit is out of range for the base, -2 if it is
964 not a digit in any supported base. (Bug#8602)
966 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
968 * dispnew.c (scrolling_window): Return 1 if we scrolled,
969 to match comment at start of function. This also removes a
970 GCC warning about overflow in a 32+64-bit port.
972 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
974 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
975 Reported by Stefan Monnier in
976 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
977 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
978 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
980 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
981 (EMACS_UINTPTR): Likewise, with uintptr_t.
983 * lisp.h: Prefer 64-bit EMACS_INT if available.
984 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
985 on 32-bit hosts that have 64-bit int, so that they can access
987 However, temporarily disable this change unless the temporary
988 symbol WIDE_EMACS_INT is defined.
990 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
992 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
993 This removes an assumption that EMACS_INT and long are the same
994 width as pointers. The assumption is true for Emacs porting targets
995 now, but we want to make other targets possible.
996 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
997 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
998 In the rest of the code, change types of integers that hold casted
999 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1000 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1001 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1002 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1003 No need to cast type when ORing.
1004 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1005 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1006 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1007 assume EMACS_INT is the same width as char *.
1008 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1009 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1010 Remove no-longer-needed casts.
1011 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1012 (xg_tool_bar_help_callback, xg_make_tool_item):
1013 Use EMACS_INTPTR to hold an integer
1014 that will be cast to void *; this can avoid a GCC warning
1015 if EMACS_INT is not the same width as void *.
1016 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1017 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1018 (current_message_1, set_message_1):
1019 Use a local to convert to proper width without a cast.
1020 * xmenu.c (dialog_selection_callback): Likewise.
1022 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1023 Also, don't assume VALBITS / RAND_BITS is less than 5,
1024 and don't rely on undefined behavior when shifting a 1 left into
1026 * lisp.h (get_random): Change signature to match.
1028 * lread.c (hash_string): Use size_t, not int, for hash computation.
1029 Normally we prefer signed values; but hashing is special, because
1030 it's better to use unsigned division on hash table sizes so that
1031 the remainder is nonnegative. Also, size_t is the natural width
1032 for hashing into memory. The previous code used 'int', which doesn't
1033 retain enough info to hash well into very large tables.
1034 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1036 * dbusbind.c: Don't possibly lose pointer info when converting.
1037 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1038 Use XPNTR rather than XHASH, so that the high-order bits of
1039 the pointer aren't lost when converting through void *.
1041 * eval.c (Fautoload): Don't double-shift a pointer.
1043 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1045 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1047 * gnutls.c (DEF_GNUTLS_FN):
1048 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1050 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1052 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1055 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1057 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1058 New version that can reserve upto 2GB of heap space.
1060 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1062 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1064 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1066 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1067 `gnutls_certificate_set_x509_key_file'.
1069 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1071 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1072 Update dependencies.
1074 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1076 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1077 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1078 Remove unused parameter `fildes'.
1079 * process.c (read_process_output, send_process): Don't pass it.
1081 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1083 Fix previous change: the library cache is defined in w32.c.
1084 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1085 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1087 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1089 Implement dynamic loading of GnuTLS on Windows.
1091 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1092 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1093 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1096 * gnutls.c (Qgnutls_dll): Define.
1097 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1098 (gnutls_*): Declare function pointers.
1099 (init_gnutls_functions): New function to initialize function pointers.
1100 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1101 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1102 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1103 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1104 (emacs_gnutls_write, emacs_gnutls_read)
1105 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1106 (Fgnutls_available_p): New function.
1107 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1108 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1109 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1111 * image.c: Include w32.h.
1112 (Vimage_type_cache): Delete.
1113 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1114 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1115 (w32_delayed_load): Move to w32.c.
1117 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1119 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1120 (w32_delayed_load): Move from image.c. When loading a library, record
1121 its filename in the :loaded-from property of the library id.
1122 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1123 Initialize and staticpro them.
1124 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1126 * process.c: Include lisp.h before w32.h, not after.
1127 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1128 instead of gnutls_record_check_pending.
1130 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1132 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1134 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1135 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1138 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1140 * xterm.c (x_set_frame_alpha): Do not set property on anything
1141 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1143 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1145 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1147 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1149 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1150 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1151 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1152 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1153 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1154 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1155 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1156 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1157 (Qgnutls_bootprop_callbacks_verify): Make static.
1159 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1161 * callproc.c: Indentation fixup.
1163 * sysdep.c (wait_for_termination_1): Make static.
1164 (wait_for_termination, interruptible_wait_for_termination):
1165 Move after wait_for_termination_1.
1167 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1169 * sysdep.c (interruptible_wait_for_termination): New function
1170 which is like wait_for_termination, but allows keyboard
1173 * callproc.c (Fcall_process): Add (:file "file") as an option for
1175 (Fcall_process_region): Ditto.
1177 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1179 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1180 rather than `XVECTOR (FOO)->size'.
1182 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1183 inttypes.h, as a gnulib replacement is used if it not available in
1186 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1188 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1189 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1190 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1192 * coding.c (coding_alloc_by_realloc): Error out if destination
1193 will grow beyond MOST_POSITIVE_FIXNUM.
1194 (decode_coding_emacs_mule): Abort if there isn't enough place in
1195 charbuf for the composition carryover bytes. Reserve an extra
1196 space for up to 2 characters produced in a loop.
1197 (decode_coding_iso_2022): Abort if there isn't enough place in
1198 charbuf for the composition carryover bytes.
1200 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1202 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1203 aborting when %lld or %lll format is passed.
1204 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1205 %llo or %llx format is passed. (Bug#8545)
1207 * window.c (window_scroll_line_based): Use a marker instead of
1208 simple variables to record original value of point. (Bug#7952)
1210 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1211 produced by %s or %c overflows available buffer space. (Bug#8545)
1213 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1215 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1216 (SIZE_MAX): Move defn after all includes, as they might #define it.
1218 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1220 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1222 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1224 * keyboard.c (Qdelayed_warnings_hook): Define.
1225 (command_loop_1): Run `delayed-warnings-hook'
1226 if Vdelayed_warnings_list is non-nil.
1227 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1228 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1230 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1232 * doprnt.c (doprnt): Don't return value smaller than the buffer
1233 size if the message was truncated. (Bug#8545).
1235 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1237 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1238 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1240 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1242 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1244 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1246 * makefile.w32-in: Update dependencies.
1248 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1250 Improve `doprnt' and its usage. (Bug#8545)
1251 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1252 `format_end'. Remove support for %l as a conversion specifier.
1253 Don't use xrealloc. Improve diagnostics when the %l size modifier
1254 is used. Update the commentary.
1256 * eval.c (verror): Simplify calculation of size_t.
1258 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1261 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1263 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1266 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1268 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1269 This makes this file independent of the recent pseudovector change.
1271 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1273 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1275 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1276 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1277 Remove unused local.
1278 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1280 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1281 GCC 4.6.0 optimizes based on type-based alias analysis.
1282 For example, if b is of type struct buffer * and v of type struct
1283 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1284 != &v->size, and therefore "v->size = 1; b->size = 2; return
1285 v->size;" must therefore return 1. This assumption is incorrect
1286 for Emacs, since it type-puns struct Lisp_Vector * with many other
1287 types. To fix this problem, this patch adds a new type struct
1288 vectorlike_header that documents the constraints on layout of vectors
1289 and pseudovectors, and helps optimizing compilers not get fooled
1290 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1291 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1292 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1294 (XSETPVECTYPE): Rewrite in terms of new macro.
1295 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1296 This is a bit clearer, and further avoids the possibility of
1297 undesirable aliasing.
1298 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1299 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1300 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1301 since Lisp_Subr is a special case (no "next" field).
1302 (ASIZE): Now uses header.size rather than size.
1303 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1304 to avoid the hassle of writing XVECTOR (foo)->header.size.
1305 (struct vectorlike_header): New type.
1306 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1307 object, to help avoid aliasing.
1308 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1309 (SUBRP): Likewise, since Lisp_Subr is a special case.
1310 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1311 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1312 (struct Lisp_Hash_Table): Combine first two members into a single
1313 struct vectorlike_header member. All uses of "size" and "next" members
1314 changed to be "header.size" and "header.next".
1315 * buffer.h (struct buffer): Likewise.
1316 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1317 * frame.h (struct frame): Likewise.
1318 * process.h (struct Lisp_Process): Likewise.
1319 * termhooks.h (struct terminal): Likewise.
1320 * window.c (struct save_window_data, struct saved_window): Likewise.
1321 * window.h (struct window): Likewise.
1322 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1323 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1324 * buffer.c (init_buffer_once): Likewise.
1325 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1327 * process.c (Fformat_network_address): Use local var for size,
1330 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1332 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1333 * data.c (atof): Remove decl; no longer used or needed.
1334 (digit_to_number): Move to lread.c.
1335 (Fstring_to_number): Use new string_to_number function, to be
1336 consistent with how the Lisp reader treats infinities and NaNs.
1337 Do not assume that floating-point numbers represent EMACS_INT
1338 without losing information; this is not true on most 64-bit hosts.
1339 Avoid double-rounding errors, by insisting on integers when
1340 parsing non-base-10 numbers, as the documentation specifies.
1341 * lisp.h (string_to_number): New decl, replacing ...
1342 (isfloat_string): Remove.
1343 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1344 (read1): Do not accept +. and -. as integers; this
1345 appears to have been a coding error. Similarly, do not accept
1346 strings like +-1e0 as floating point numbers. Do not report
1347 overflow for integer overflows unless the base is not 10 which
1348 means we have no simple and reliable way to continue.
1349 Break out the floating-point parsing into a new
1350 function string_to_number, so that Fstring_to_number parses
1351 floating point numbers consistently with the Lisp reader.
1352 (digit_to_number): Move here from data.c. Make it static inline.
1353 (E_CHAR, EXP_INT): Remove, replacing with ...
1354 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1355 (string_to_number): New function, replacing isfloat_string.
1356 This function checks for valid syntax and produces the resulting
1357 Lisp float number too. Rework it so that string-to-number
1358 no longer mishandles examples like "1.0e+". Use strtoumax,
1359 so that overflow for non-base-10 numbers is reported only when
1360 there's no portable and simple way to convert to floating point.
1362 * textprop.c (set_text_properties_1): Rewrite for clarity,
1363 and to avoid GCC warning about integer overflow.
1365 * intervals.h (struct interval): Use EMACS_INT for members
1366 where EMACS_UINT might cause problems. See
1367 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1368 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1369 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1371 (offset_intervals): Tell GCC not to worry about length overflow
1372 when negating a negative length.
1374 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1375 (overrun_check_free): Likewise.
1377 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1378 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1381 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1382 (gnutls_make_error): Rename local to avoid shadowing.
1383 (gnutls_emacs_global_deinit): ifdef out; not used.
1384 (Fgnutls_boot): Use const for pointer to readonly storage.
1385 Comment out unused local. Fix pointer signedness problems.
1387 * lread.c (openp): Don't stuff size_t into an 'int'.
1388 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1389 about possible signed overflow.
1391 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1392 (GDK_KEY_g): Don't define if already defined.
1393 (xg_prepare_tooltip): Avoid pointer signedness problem.
1394 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1396 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1397 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1399 * xfns.c (Fx_window_property): Simplify a bit,
1400 to make a bit faster and to avoid GCC 4.6.0 warning.
1401 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1403 * fns.c (internal_equal): Don't assume size_t fits in int.
1405 * alloc.c (compact_small_strings): Tighten assertion a little.
1407 Replace pEd with more-general pI, and fix some printf arg casts.
1408 * lisp.h (pI): New macro, generalizing old pEd macro to other
1409 conversion specifiers. For example, use "...%"pI"d..." rather
1410 than "...%"pEd"...".
1411 (pEd): Remove. All uses replaced with similar uses of pI.
1412 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1413 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1414 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1415 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1416 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1417 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1418 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1420 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1421 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1422 * print.c (safe_debug_print, print_object): Likewise.
1423 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1425 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1426 avoiding the 0 flag, which is not portable.
1427 * process.c (Fmake_network_process): Use pI to avoid cast.
1428 * region-cache.c (pp_cache): Likewise.
1429 * xdisp.c (decode_mode_spec): Likewise.
1430 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1431 behavior on 64-bit hosts with printf arg.
1432 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
1433 (x_stop_queuing_selection_requests): Likewise.
1434 (x_get_window_property): Don't truncate byte count to an 'int'
1437 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1438 here, since it parses constructs like leading '-' and spaces,
1439 which are not wanted; and it overflows with large numbers.
1440 Instead, simply match F[0-9]+, which is what is wanted anyway.
1442 * alloc.c: Remove unportable assumptions about struct layout.
1443 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1444 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1445 (allocate_vectorlike, make_pure_vector): Use the new macros,
1446 plus offsetof, to remove unportable assumptions about struct layout.
1447 These assumptions hold on all porting targets that I know of, but
1448 they are not guaranteed, they're easy to remove, and removing them
1449 makes further changes easier.
1451 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1452 This doesn't fix a bug but makes the code clearer.
1453 (string_overrun_cookie): Now const. Use initializers that
1454 don't formally overflow signed char, to avoid warnings.
1455 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1456 can cause Emacs to crash when string overrun checking is enabled.
1457 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1458 multiple of sizeof (EMACS_INT); it need not be, if
1459 alignof(EMACS_INT) < sizeof (EMACS_INT).
1460 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1462 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
1464 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1466 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1468 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1469 supposed to be handshaking. (Bug#8556)
1470 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1472 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1474 * lisp.h (Qdebug): List symbol.
1475 * eval.c (Qdebug): Restore global linkage.
1476 * keyboard.c (debug-on-event): New variable.
1477 (handle_user_signal): Break into debugger when debug-on-event
1478 matches the current signal symbol.
1480 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1482 * alloc.c (check_sblock, check_string_bytes)
1483 (check_string_free_list): Convert to standard C.
1485 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1487 * w32.c (emacs_gnutls_push): Fix typo.
1489 2011-04-25 Eli Zaretskii <eliz@gnu.org>
1491 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1492 "cast to pointer from integer of different size".
1494 Improve doprnt and its use in verror. (Bug#8545)
1495 * doprnt.c (doprnt): Document the set of format control sequences
1496 supported by the function. Use SAFE_ALLOCA instead of always
1499 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1500 is one byte too soon. Don't use xrealloc; instead xfree and
1503 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1505 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1508 * gnutls.c: Renamed global_initialized to
1509 gnutls_global_initialized. Added internals for the
1510 :verify-hostname-error, :verify-error, and :verify-flags
1511 parameters of `gnutls-boot' and documented those parameters in the
1512 docstring. Start callback support.
1513 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1514 unless a fatal error occured. Call gnutls_alert_send_appropriate
1515 on error. Return error code.
1516 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1517 (emacs_gnutls_read): Likewise.
1518 (Fgnutls_boot): Return handshake error code.
1519 (emacs_gnutls_handle_error): New function.
1520 (wsaerror_to_errno): Likewise.
1522 * w32.h (emacs_gnutls_pull): Add prototype.
1523 (emacs_gnutls_push): Likewise.
1525 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1526 (emacs_gnutls_push): Likewise.
1528 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1530 * process.c (wait_reading_process_output): Check if GnuTLS
1531 buffered some data internally if no FDs are set for TLS
1534 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1535 (LIBS): Link to USER_LIBS.
1536 ($(BLD)/gnutls.$(0)): New target.
1538 2011-04-24 Eli Zaretskii <eliz@gnu.org>
1540 * xdisp.c (handle_single_display_spec): Rename the
1541 display_replaced_before_p argument into display_replaced_p, to
1542 make it consistent with the commentary. Fix typos in the
1545 * textprop.c (syms_of_textprop): Remove dead code.
1546 (copy_text_properties): Delete obsolete commentary about an
1547 interface that was deleted long ago. Fix typos in the description
1550 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1551 to changes in oldXMenu/XMenu.h from 2011-04-16.
1552 <menu_help_message, prev_menu_help_message>: Constify.
1553 (IT_menu_make_room): menu->help_text is now `const char **';
1556 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1557 to changes in oldXMenu/XMenu.h from 2011-04-16.
1558 (struct XMenu): Declare `help_text' `const char **'.
1560 * xfaces.c <Qunspecified>: Make extern again.
1562 * syntax.c: Include sys/types.h before including regex.h, as
1565 * doc.c (get_doc_string): Improve the format passed to `error'.
1567 * doprnt.c (doprnt): Improve commentary.
1569 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1571 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1574 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1575 changes in globals.h immediately force recompilation.
1576 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1577 $(CURDIR)/s/ms-w32.h.
1578 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1580 * character.c (Fchar_direction): Function deleted.
1581 (syms_of_character): Don't defsubr it.
1582 <char-direction-table>: Deleted.
1584 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1586 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1587 * doprnt.c: Include limits.h.
1588 (SIZE_MAX): New macro.
1589 (doprnt): Return a size_t value. 2nd arg is now size_t.
1590 Many local variables are now size_t instead of int or unsigned.
1591 Improve overflow protection. Support `l' modifier for integer
1592 conversions. Support %l conversion. Don't assume an EMACS_INT
1593 argument for integer conversions and for %c.
1595 * lisp.h (doprnt): Restore prototype.
1597 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1600 * Makefile.in (base_obj): Add back doprnt.o.
1602 * deps.mk (doprnt.o): Add back prerequisites.
1603 (callint.o): Depend on character.h.
1605 * eval.c (internal_lisp_condition_case): Include the handler
1606 representation in the error message.
1607 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1608 when breaking from the loop.
1610 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1612 * callint.c (Fcall_interactively): When displaying error message
1613 about invalid control letter, pass the character's codepoint, not
1614 a pointer to its multibyte form. Improve display of the character
1615 in octal and display also its hex code.
1617 * character.c (char_string): Use %x to display the (unsigned)
1618 codepoint of an invalid character, to avoid displaying a bogus
1621 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1622 `error', not SYMBOL_NAME itself.
1624 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1625 character arguments to `error'.
1627 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1628 to `error' in error message about FINAL_CHAR argument. Make sure
1629 FINAL_CHAR is a character, and use %c when it is passed as
1630 argument to `error'.
1632 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1634 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1636 * w32.c: Include <time.h>.
1637 (sys_localtime): New function.
1639 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
1641 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1643 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1645 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1647 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1650 2011-04-19 Eli Zaretskii <eliz@gnu.org>
1652 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1653 gl_state.e_property when gl_state.object is Qt.
1655 * insdel.c (make_gap_larger): Remove limitation of buffer size
1658 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
1660 * xdisp.c (lookup_glyphless_char_display)
1661 (produce_glyphless_glyph): Handle cons cell entry in
1662 glyphless-char-display.
1663 (Vglyphless_char_display): Document it.
1665 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1666 glyphless-char-display.
1668 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
1670 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1672 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1674 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1675 definition for no-X builds.
1677 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1679 Static checks with GCC 4.6.0 and non-default toolkits.
1681 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1683 * process.c (keyboard_bit_set): Define only if SIGIO.
1684 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1685 (send_process): Repair possible setjmp clobbering.
1687 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1689 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1691 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1693 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1694 Define only if needed.
1696 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1697 by pacifying GCC about it. Maybe it's time to retire it?
1698 * xfaces.c (USG, __TIMEVAL__): Likewise.
1700 * dispextern.h (struct redisplay_interface): Rename param
1702 * termhooks.h (struct terminal): Likewise.
1703 * xterm.c (xembed_send_message): Likewise.
1705 * insdel.c (make_gap_smaller): Define only if
1706 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1708 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1711 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1712 so that we aren't warned about unused symbols.
1714 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1716 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1718 * xfns.c (x_real_positions): Mark locals as initialized.
1720 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1722 * xterm.c: Fix problems found by static analysis with other toolkits.
1723 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1724 (x_dispatch_event): Declare static if USE_GTK, and
1725 define if USE_GTK || USE_X_TOOLKIT.
1726 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1727 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1728 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1729 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1731 * xmenu.c (menu_help_callback): Pointer type fixes.
1732 Use const pointers when pointing at readonly data. Avoid pointer
1734 (FALSE): Remove unused macro.
1735 (update_frame_menubar): Remove unused decl.
1737 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1739 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1740 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1741 (single_menu_item): Rename local to avoid shadowing.
1743 * keyboard.c (make_lispy_event): Remove unused local var.
1745 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1746 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1748 * bitmaps: Change bitmaps from unsigned char back to the X11
1749 compatible char. Avoid the old compiler warnings about
1750 out-of-range initializers by using, for example, '\xab' rather
1753 * xgselect.c (xgselect_initialize): Check vs interface
1754 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1756 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1758 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1759 to read-only memory.
1761 * fns.c (vector): Remove; this old hack is no longer needed.
1763 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1765 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1767 * xrdb.c (x_load_resources): Omit unused local.
1769 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1770 (x_window): Rename locals to avoid shadowing.
1771 (USG): Use the kludged USG macro, to pacify gcc.
1773 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1774 (x_term_init): Remove local to avoid shadowing.
1776 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1778 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1779 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1781 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1783 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1785 Fix regex.c, syntax.c and friends for buffers > 2GB.
1786 * syntax.h (struct gl_state_s): Declare character position members
1789 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1791 * textprop.c (verify_interval_modification, interval_of):
1792 Declare arguments EMACS_INT.
1794 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1797 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1799 * indent.c (Fvertical_motion): Local variable it_start is now
1802 * regex.c (re_match, re_match_2, re_match_2_internal)
1803 (bcmp_translate, regcomp, regexec, print_double_string)
1804 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1805 (re_compile_pattern, re_exec): Declare arguments and local
1806 variables `size_t' and `ssize_t' and return values `regoff_t', as
1808 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1809 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1810 <compile_stack_type>: `size' and `avail' are now `size_t'.
1812 * regex.h <regoff_t>: Use ssize_t, not int.
1813 (re_search, re_search_2, re_match, re_match_2): Arguments that
1814 specify buffer/string position and length are now ssize_t and
1815 size_t. Return type is regoff_t.
1817 2011-04-16 Ben Key <bkey76@gmail.com>
1819 * nsfont.m: Fixed bugs in ns_get_family and
1820 ns_descriptor_to_entity that were caused by using free to
1821 deallocate memory blocks that were allocated by xmalloc (via
1822 xstrdup). This caused Emacs to crash when compiled with
1823 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1824 --enable-checking=xmallocoverrun). xfree is now used to
1825 deallocate these memory blocks.
1827 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1829 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1831 emacs_write: Accept and return EMACS_INT for sizes.
1832 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1834 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1835 Accept and return EMACS_INT.
1836 (emacs_gnutls_write): Return the number of bytes written on
1838 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1839 (emacs_read, emacs_write): Remove check for negative size, as the
1840 Emacs source code has been audited now.
1841 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1842 (emacs_read, emacs_write): Use it.
1843 * process.c (send_process): Adjust to the new signatures of
1844 emacs_write and emacs_gnutls_write. Do not attempt to store
1845 a byte offset into an 'int'; it might overflow.
1846 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1848 * sound.c: Don't assume sizes fit in 'int'.
1849 (struct sound_device.period_size, alsa_period_size):
1850 Return EMACS_INT, not int.
1851 (struct sound_device.write, vox_write, alsa_write):
1852 Accept EMACS_INT, not int.
1853 (wav_play, au_play): Use EMACS_INT to store sizes and to
1854 record read return values.
1856 2011-04-15 Ben Key <bkey76@gmail.com>
1858 * keyboard.c (Qundefined): Don't declare static since it is used
1860 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1861 static since they are used in nsfont.m.
1863 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1865 * process.c (Qprocessp): Don't declare static.
1866 * lisp.h (Qprocessp): Declare again.
1868 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
1870 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1872 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1874 Improve C-level modularity by making more things 'static'.
1876 Don't publish debugger-only interfaces to other modules.
1877 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1878 (verify_bytepos, count_markers): Move decls to the only modules
1880 * region-cache.h (pp_cache): Likewise.
1881 * window.h (check_all_windows): Likewise.
1882 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1884 * sysdep.c (croak): Now static, if
1885 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1886 * syssignal.h (croak): Declare only if not static.
1888 * alloc.c (refill_memory_reserve): Now static if
1889 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1890 * lisp.h (refill_memory_reserve): Declare only if not static.
1892 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1893 Define only if USE_LUCID.
1895 * xrdb.c (x_customization_string, x_rm_string): Now static.
1897 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1898 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1900 * xdisp.c (draw_row_with_mouse_face): Now static.
1901 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1903 * window.h (check_all_windows): Mark externally visible.
1905 * window.c (window_deletion_count): Now static.
1907 * undo.c: Make symbols static if they're not exported.
1908 (last_undo_buffer, last_boundary_position, pending_boundary):
1911 * textprop.c (interval_insert_behind_hooks): Now static.
1912 (interval_insert_in_front_hooks): Likewise.
1914 * term.c: Make symbols static if they're not exported.
1915 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1916 (max_frame_lines, tty_set_terminal_modes):
1917 (tty_reset_terminal_modes, tty_turn_off_highlight):
1918 (get_tty_terminal): Now static.
1919 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1920 * termhooks.h (term_mouse_moveto): Do not declare if
1922 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1923 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1925 * sysdep.c: Make symbols static if they're not exported.
1926 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1928 (sigprocmask_set, full_mask): Remove; unused.
1929 (wait_debugging): Mark as visible.
1930 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1931 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1933 * syntax.c (syntax_temp): Define only if !__GNUC__.
1935 * sound.c (current_sound_device, current_sound): Now static.
1937 * search.c (searchbufs, searchbuf_head): Now static.
1939 * scroll.c (scroll_cost): Remove; unused.
1940 * dispextern.h (scroll_cost): Remove decl.
1942 * region-cache.h (pp_cache): Mark as externally visible.
1944 * process.c: Make symbols static if they're not exported.
1945 (process_tick, update_tick, create_process, chan_process):
1946 (Vprocess_alist, proc_buffered_char, datagram_access):
1947 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1948 (deactivate_process): Mark defn as static, as well as decl.
1949 * lisp.h (create_process): Remove decl.
1950 * process.h (chan_process, Vprocess_alist): Remove decls.
1952 * print.c: Make symbols static if they're not exported.
1953 (print_depth, new_backquote_output, being_printed, print_buffer):
1954 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1955 (print_interval, print_number_index, initial_stderr_stream):
1957 * lisp.h (Fprinc): Remove decl.
1958 (debug_output_compilation_hack): Mark as externally visible.
1960 * sysdep.c (croak): Move decl from here to syssignal.h.
1961 * syssignal.h (croak): Put it here, so the API can be checked when
1962 'croak' is called from dissociate_if_controlling_tty.
1964 * minibuf.c: Make symbols static if they're not exported.
1965 (minibuf_save_list, choose_minibuf_frame): Now static.
1966 * lisp.h (choose_minibuf_frame): Remove decl.
1968 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1970 * lread.c: Make symbols static if they're not exported.
1971 (read_objects, initial_obarray, oblookup_last_bucket_number):
1973 (make_symbol): Remove; unused.
1974 * lisp.h (initial_obarray, make_symbol): Remove decls.
1976 * keyboard.c: Make symbols static if they're not exported.
1977 (single_kboard, recent_keys_index, total_keys, recent_keys):
1978 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1979 (this_single_command_key_start, echoing, last_auto_save):
1980 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1981 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1982 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1983 (Vlispy_mouse_stem, double_click_count):
1985 (force_auto_save_soon): Define only if SIGDANGER.
1986 (ignore_mouse_drag_p): Now static if
1987 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1988 (print_help): Remove; unused.
1989 (stop_character, last_timer_event): Mark as externally visible.
1990 * keyboard.h (ignore_mouse_drag_p): Declare only if
1991 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1992 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1993 * lisp.h (echoing): Remove decl.
1994 (force_auto_save_soon): Declare only if SIGDANGER.
1995 * xdisp.c (redisplay_window): Simplify code, to make it more
1996 obvious that ignore_mouse_drag_p is not accessed if !defined
1997 USE_GTK && !defined HAVE_NS.
1999 * intervals.c: Make symbols static if they're not exported.
2000 (merge_properties_sticky, merge_interval_right, delete_interval):
2002 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2004 * insdel.c: Make symbols static if they're not exported.
2005 However, leave prepare_to_modify_buffer alone. It's never
2006 called from outside this function, but that appears to be a bug.
2007 (combine_after_change_list, combine_after_change_buffer):
2008 (adjust_after_replace, signal_before_change): Now static.
2009 (adjust_after_replace_noundo): Remove; unused.
2010 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2011 (signal_before_change): Remove decls.
2013 * indent.c (val_compute_motion, val_vmotion): Now static.
2015 * image.c: Make symbols static if they're not exported.
2016 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2018 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2019 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2021 * fringe.c (standard_bitmaps): Now static.
2022 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2024 * frame.c: Make symbols static if they're not exported.
2025 (x_report_frame_params, make_terminal_frame): Now static.
2026 (get_frame_param): Now static, unless HAVE_NS.
2027 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2028 (x_get_resource_string): Remove; not used.
2029 * frame.h (make_terminal_frame, x_report_frame_params):
2030 (x_get_resource_string); Remove decls.
2031 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2032 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2034 * font.c, fontset.c: Make symbols static if they're not exported.
2035 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2036 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2037 * font.c (font_close_object): Now static.
2038 * font.h (font_close_object): Remove.
2039 * fontset.c (FONTSET_OBJLIST): Remove.
2040 (free_realized_fontset) #if-0 the body, which does nothing.
2041 (face_suitable_for_char_p): #if-0, as it's never called.
2042 * fontset.h (face_suitable_for_char_p): Remove decl.
2043 * xfaces.c (face_at_string_position):
2044 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2045 since 0 is always ASCII.
2047 * fns.c (weak_hash_tables): Now static.
2049 * fileio.c: Make symbols static if they're not exported.
2050 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2051 (Vwrite_region_annotation_buffers): Now static.
2053 * eval.c: Make symbols static if they're not exported.
2054 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2055 * lisp.h (backtrace_list): Remove decl.
2057 * emacs.c: Make symbols static if they're not exported.
2058 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2059 (fatal_error_code, fatal_error_signal_hook, standard_args):
2061 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2062 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2063 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2064 * lisp.h (fatal_error_signal_hook): Remove decl.
2065 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2067 * editfns.c: Move a (normally-unused) function to its only use.
2068 * editfns.c, lisp.h (get_operating_system_release): Remove.
2069 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2070 worth the hassle of breaking this out.
2072 * xterm.c: Make symbols static if they're not exported.
2073 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2074 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2075 (x_destroy_window, x_delete_display):
2077 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2078 (x_mouse_leave): Remove; unused.
2079 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2080 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2081 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2083 (x_mouse_leave): Declare only if WINDOWSNT.
2084 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2085 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2088 * ftxfont.c: Make symbols static if they're not exported.
2089 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2091 * font.h (ftxfont_driver): Likewise.
2093 * xfns.c: Make symbols static if they're not exported.
2094 (x_last_font_name, x_display_info_for_name):
2095 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2096 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2097 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2098 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2099 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2100 (last_show_tip_args): Now static.
2101 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2102 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2103 (x_screen_planes): Remove; unused.
2104 * dispextern.h (x_screen_planes): Remove decl.
2106 * dispnew.c: Make symbols static if they're not exported.
2107 * dispextern.h (redraw_garbaged_frames, scrolling):
2108 (increment_row_positions): Remove.
2109 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2110 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2112 (redraw_garbaged_frames): Remove; unused.
2114 * xfaces.c: Make symbols static if they're not exported.
2115 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2117 * xterm.h (defined_color): Remove decls.
2118 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2119 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2120 (menu_face_changed_default, defined_color, free_realized_face):
2121 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2122 (ascii_face_of_lisp_face): Remove; unused.
2124 * xdisp.c: Make symbols static if they're not exported.
2125 * dispextern.h (scratch_glyph_row, window_box_edges):
2126 (glyph_to_pixel_coords, set_cursor_from_row):
2127 (get_next_display_element, set_iterator_to_next):
2128 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2129 (show_mouse_face): Remove decls
2130 * frame.h (message_buf_print): Likewise.
2131 * lisp.h (pop_message, set_message, check_point_in_composition):
2133 * xterm.h (set_vertical_scroll_bar): Likewise.
2134 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2135 (message_buf_print, scratch_glyph_row, displayed_buffer):
2136 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2137 (get_next_display_element, show_mouse_face, window_box_edges):
2138 (frame_to_window_pixel_xy, check_point_in_composition):
2139 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2140 (glyph_to_pixel_coords): Remove; unused.
2142 * dired.c (file_name_completion): Now static.
2144 * dbusbind.c (xd_in_read_queued_messages): Now static.
2146 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2147 * data.c (circular_list_error): Remove.
2149 * commands.h (last_point_position, last_point_position_buffer):
2150 (last_point_position_window): Remove decls.
2151 * keyboard.c: Make these variables static.
2153 * coding.h (coding, code_convert_region, encode_coding_gap):
2155 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2156 (iso_code_class, detect_coding, code_convert_region): Now static.
2157 (encode_coding_gap): Remove; unused.
2159 * chartab.c (chartab_chars, chartab_bits): Now static.
2161 * charset.h (charset_iso_8859_1): Remove decl.
2162 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2165 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2166 * ccl.c (Vccl_program_table): Now static.
2167 (check_ccl_update): Remove; unused.
2169 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2170 * category.h: ... from here.
2171 * category.c (check_category_table, set_category_set): Now static.
2173 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2174 * lisp.h: Remove these decls.
2176 * buffer.c (buffer_count): Remove unused var.
2178 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2179 so that it's not optimized away.
2180 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2181 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2182 exported only to the debugger.
2184 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2185 * atimer.h (run_all_atimers): Remove; not exported.
2187 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2188 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2189 was inaccessible from Lisp.
2190 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2191 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2193 alloc.c: Import and export fewer symbols, and remove unused items.
2194 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2196 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2197 it's not optimized away by whole-program optimization.
2198 (message_enable_multibyte, free_misc): Remove.
2199 (catchlist, handlerlist, mark_backtrace):
2200 Declare only if BYTE_MARK_STACK.
2201 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2202 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2203 (message_enable_multibyte): Remove decl.
2204 (free_misc, interval_free_list, float_block, float_block_index):
2205 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2206 (cons_free_list, last_marked_index):
2208 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2209 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2210 (mark_backtrace): Define only if BYTE_MARK_STACK.
2211 * xdisp.c (message_enable_multibyte): Now static.
2213 Declare Lisp_Object Q* variables to be 'static' if not exported.
2214 This makes it easier for human readers (and static analyzers)
2215 to see whether these variables are used from other modules.
2216 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2217 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2218 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2219 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2220 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2221 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2222 * xmenu.c, xselect.c:
2223 Declare Q* vars static if they are not used in other modules.
2224 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2225 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2226 Remove decls of unexported vars.
2227 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2229 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2231 Make Emacs functions such as Fatom 'static' by default.
2232 This makes it easier for human readers (and static analyzers)
2233 to see whether these functions can be called from other modules.
2234 DEFUN now defines a static function. To make the function external
2235 so that it can be used in other C modules, use the new macro DEFUE.
2236 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2237 (Finit_image_library):
2238 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2239 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2240 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2241 Remove decls, since these functions are now static.
2242 (Funintern, Fget_internal_run_time): New decls, since these functions
2243 were already external.
2245 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2246 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2247 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2248 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2249 * keyboard.c, keymap.c, lread.c:
2250 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2251 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2252 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2253 Mark functions with DEFUE instead of DEFUN,
2254 if they are used in other modules.
2255 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2256 decls for now-static functions.
2257 * buffer.h (Fdelete_overlay): Remove decl.
2258 * callproc.c (Fgetenv_internal): Mark as internal.
2259 * composite.c (Fremove_list_of_text_properties): Remove decl.
2260 (Fcomposition_get_gstring): New forward static decl.
2261 * composite.h (Fcomposite_get_gstring): Remove decl.
2262 * dired.c (Ffile_attributes): New forward static decl.
2263 * doc.c (Fdocumntation_property): New forward static decl.
2264 * eval.c (Ffetch_bytecode): New forward static decl.
2265 (Funintern): Remove extern decl; now in .h file where it belongs.
2266 * fileio.c (Fmake_symbolic_link): New forward static decl.
2267 * image.c (Finit_image_library): New forward static decl.
2268 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2269 * intervals.h (Fprevious_property_change):
2270 (Fremove_list_of_text_properties): Remove decls.
2271 * keyboard.c (Fthis_command_keys): Remove decl.
2272 (Fcommand_execute): New forward static decl.
2273 * keymap.c (Flookup_key): New forward static decl.
2274 (Fcopy_keymap): Now static.
2275 * keymap.h (Flookup_key): Remove decl.
2276 * process.c (Fget_process): New forward static decl.
2277 (Fprocess_datagram_address): Mark as internal.
2278 * syntax.c (Fsyntax_table_p): New forward static decl.
2279 (skip_chars): Remove duplicate decl.
2280 * textprop.c (Fprevious_property_change): New forward static decl.
2281 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2283 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2284 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2286 * editfns.c (Fformat): Remove unreachable code.
2288 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2290 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2293 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2295 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2296 when at ZV. (Bug#8487)
2298 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2300 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2302 * keyboard.c (parse_tool_bar_item): Likewise.
2303 * sound.c (sound_cleanup, alsa_close): Likewise.
2304 * termcap.c (tgetent): Likewise.
2305 * xfns.c (x_default_font_parameter): Likewise.
2306 * xsettings.c (read_and_apply_settings): Likewise.
2308 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2309 (overrun_check_free): Protoize.
2311 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2313 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2314 since callers should never pass a negative size.
2315 Change the signature to match that of plain 'read' and 'write'; see
2316 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2317 * lisp.h: Update prototypes of emacs_write and emacs_read.
2319 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2321 * xdisp.c (redisplay_window): Don't try to determine the character
2322 position of the scroll margin if the window start point w->startp
2323 is outside the buffer's accessible region. (Bug#8468)
2325 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2327 Fix write-region and its subroutines for buffers > 2GB.
2328 * fileio.c (a_write, e_write): Modify declaration of arguments and
2329 local variables to support buffers larger than 2GB.
2330 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2332 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2333 argument, local variables, and return value.
2335 * lisp.h: Update prototypes of emacs_write and emacs_read.
2337 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2339 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2341 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2343 Fix more problems found by GCC 4.6.0's static checks.
2345 * xdisp.c (vmessage): Use a better test for character truncation.
2347 * charset.c (load_charset_map): <, not <=, for optimization,
2348 and to avoid potential problems with integer overflow.
2349 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2350 * casetab.c (set_identity, shuffle): Likewise.
2351 * editfns.c (Fformat): Likewise.
2352 * syntax.c (skip_chars): Likewise.
2354 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2355 This also lets GCC 4.6.0 generate slightly better loop code.
2357 * callint.c (Fcall_interactively): <, not <=, for optimization.
2358 (Fcall_interactively): Count the number of arguments produced,
2359 not the number of arguments given. This is simpler and lets GCC
2360 4.6.0 generate slightly better code.
2362 * ftfont.c: Distingish more carefully between FcChar8 and char.
2363 The previous code passed unsigned char * to a functions like
2364 strlen and xstrcasecmp that expect char *, which does not
2365 conform to the C standard.
2366 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2367 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2368 char * when the C standard requires it.
2370 * keyboard.c (read_char): Remove unused var.
2372 * eval.c: Port to Windows vsnprintf (Bug#8435).
2374 (SIZE_MAX): Define if the headers do not.
2375 (verror): Do not give up if vsnprintf returns a negative count.
2376 Instead, grow the buffer. This ports to Windows vsnprintf, which
2377 does not conform to C99. Problem reported by Eli Zaretskii.
2378 Also, simplify the allocation scheme, by avoiding the need for
2379 calling realloc, and removing the ALLOCATED variable.
2381 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2383 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2384 But keep the doprint source code for now, as we might revamp it
2385 and use it again (Bug#8435).
2386 * lisp.h (doprnt): Remove.
2387 * Makefile.in (base_obj): Remove doprnt.o.
2388 * deps.mk (doprnt.o): Remove.
2390 error: Print 32- and 64-bit integers portably (Bug#8435).
2391 Without this change, on typical 64-bit hosts error ("...%d...", N)
2392 was used to print both 32- and 64-bit integers N, which relied on
2394 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2396 * lisp.h (error, verror): Mark as printf-like functions.
2397 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2398 Report overflow in size calculations when allocating printf buffer.
2399 Do not truncate output string at its first null byte.
2400 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2401 Truncate the output at a character boundary, since vsnprintf does not
2403 * charset.c (check_iso_charset_parameter): Convert internal
2404 character to string before calling 'error', since %c now has the
2406 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2407 overflow when computing char to be passed to 'error'. Do not
2408 pass Lisp_Object to 'error'; pass the integer instead.
2409 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2410 formatted with plain %d.
2412 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2414 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2416 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2418 * xterm.c (x_catch_errors): Remove duplicate declaration.
2420 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2422 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2424 2011-04-10 Jim Meyering <meyering@redhat.com>
2426 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2427 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2428 return ssize_t not "int", and use size_t as the buffer length.
2429 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2430 * gnutls.h: Update declarations.
2431 * process.c (read_process_output): Use ssize_t, to match.
2432 (send_process): Likewise.
2434 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2436 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2438 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2440 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2441 Use unsigned char, to match FcChar8 type definition.
2443 * xterm.c (handle_one_xevent):
2444 * xmenu.c (create_and_show_popup_menu):
2445 * xselect.c (x_decline_selection_request)
2446 (x_reply_selection_request): Avoid type-punned deref of X events.
2448 2011-04-09 Eli Zaretskii <eliz@gnu.org>
2450 Fix some uses of `int' instead of EMACS_INT.
2451 * search.c (string_match_1, fast_string_match)
2452 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2453 (scan_buffer, find_next_newline_no_quit)
2454 (find_before_next_newline, search_command, Freplace_match)
2455 (Fmatch_data): Make some `int' variables be EMACS_INT.
2457 * xdisp.c (display_count_lines): 3rd argument and return value now
2458 EMACS_INT. All callers changed.
2459 (pint2hrstr): Last argument is now EMACS_INT.
2461 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2462 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2463 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2464 (decode_coding_utf_16, decode_coding_emacs_mule)
2465 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2466 (decode_coding_ccl, decode_coding_charset)
2467 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2468 (decode_coding_iso_2022, decode_coding_emacs_mule)
2469 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2470 <char_offset, last_offset>: Declare EMACS_INT.
2471 (encode_coding_utf_8, encode_coding_utf_16)
2472 (encode_coding_emacs_mule, encode_invocation_designation)
2473 (encode_designation_at_bol, encode_coding_iso_2022)
2474 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2475 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2477 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2478 (encode_invocation_designation): Last argument P_NCHARS is now
2480 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2481 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2483 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2486 * ccl.c (Fccl_execute_on_string): Declare some variables
2489 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
2491 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2493 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2495 * process.c (Fformat_network_address): Doc fix.
2497 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2499 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2501 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
2503 * keyboard.c (read_char): Call Lisp function help-form-show,
2504 instead of using internal_with_output_to_temp_buffer.
2505 (Qhelp_form_show): New var.
2506 (syms_of_keyboard): Use DEFSYM macro.
2508 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2510 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2512 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
2514 * process.c (Flist_processes): Remove to Lisp.
2515 (list_processes_1): Delete.
2517 2011-04-06 Eli Zaretskii <eliz@gnu.org>
2519 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2521 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2523 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
2525 Fix more problems found by GCC 4.6.0's static checks.
2527 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2529 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2531 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
2533 * xdisp.c (vmessage): Mark as a printf-like function.
2535 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2537 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2539 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2540 printf-like functions.
2541 (tiff_load): Add casts to remove these marks before passing them
2542 to system-supplied API.
2544 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2546 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2547 This avoids several warnings with gcc -Wstrict-overflow.
2548 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2549 directly, rather than having caller test rule sign. This avoids
2550 some unnecessary tests.
2551 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2552 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2553 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
2555 * xfont.c (xfont_text_extents): Remove var that was set but not used.
2556 (xfont_open): Avoid unnecessary tests.
2558 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2560 * composite.h, composite.c (composition_gstring_put_cache):
2561 Use EMACS_INT, not int, for length.
2563 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2564 breaking out part of COMPOSITION_DECODE_RULE.
2565 (COMPOSITION_DECODE_RULE): Use it.
2566 * composite.c (get_composition_id): Remove unused local vars,
2567 by using the new macro.
2569 * textprop.c (set_text_properties_1): Change while to do-while,
2570 since the condition is always true at first.
2572 * intervals.c (graft_intervals_into_buffer): Mark var as used.
2573 (interval_deletion_adjustment): Return unsigned value.
2576 * process.c (list_processes_1, create_pty, read_process_output):
2577 (exec_sentinel): Remove vars that were set but not used.
2578 (create_pty): Remove unnecessary "volatile"s.
2579 (Fnetwork_interface_info): Avoid possibility of int overflow.
2580 (read_process_output): Do adaptive read buffering even if carryover.
2581 (read_process_output): Simplify nbytes computation if buffered.
2583 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2585 * syntax.c (scan_words): Remove var that was set but not used.
2586 (update_syntax_table): Use unsigned instead of int.
2588 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
2589 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
2590 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
2592 * print.c (print_error_message): Avoid int overflow.
2594 * font.c (font_list_entities): Redo for clarity,
2595 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2597 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
2598 (font_score): Avoid potential overflow in diff calculation.
2600 * fns.c (substring_both): Remove var that is set but not used.
2601 (sxhash): Redo loop for clarity and to avoid wraparound warning.
2603 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2605 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2606 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2607 can always succeed if overflow has undefined behavior.
2609 * search.c (boyer_moore, wordify): Remove vars set but not used.
2610 (wordify): Omit three unnecessary tests.
2612 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2613 All callers changed. This avoids the need for an unused var.
2615 * casefiddle.c (casify_region): Remove var that is set but not used.
2617 * dired.c (file_name_completion): Remove var that is set but not used.
2619 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2621 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2622 (Finsert_file_contents): Remove unnecessary code checking fd.
2624 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2625 Check for integer overflow on size calculations.
2627 * buffer.c (Fprevious_overlay_change): Remove var that is set
2630 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2631 Remove vars that are set but not used.
2632 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2633 (timer_check_2): Mark vars as initialized.
2635 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2637 * image.c (lookup_image): Remove var that is set but not used.
2638 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2640 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2641 that are set but not used.
2643 * xfns.c (make_invisible_cursor): Don't return garbage
2644 if XCreateBitmapFromData fails (Bug#8410).
2646 * xselect.c (x_get_local_selection, x_handle_property_notify):
2647 Remove vars that are set but not used.
2649 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2650 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2652 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2653 Remove var that is set but not used.
2654 (scroll_bar_windows_size): Now size_t, not int.
2655 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2658 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2659 (map_tty_color) [!defined MSDOS]: Likewise.
2661 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2663 * coding.c: Remove vars that are set but not used.
2664 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2665 All callers changed.
2666 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2667 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2668 (decode_coding_charset): Remove vars that are set but not used.
2670 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2671 that is set but not used.
2673 * print.c (print_object): Remove var that is set but not used.
2675 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2676 The gnulib version avoids calling malloc in the usual case,
2677 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2678 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2679 * filelock.c (current_lock_owner): Likewise.
2680 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2681 * sysdep.c: Include allocator.h, careadlinkat.h.
2682 (emacs_no_realloc_allocator): New static constant.
2683 (emacs_readlink): New function.
2684 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2685 ../lib/careadlinkat.h.
2687 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2689 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2690 first non-nil return value).
2692 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2694 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2695 if not defined (Bug#8403).
2697 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2699 * xdisp.c (display_count_lines): Remove parameter `start',
2700 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2701 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2702 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2703 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2704 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2705 and thereabouts. All callers changed.
2706 (get_per_char_metric): Remove parameter `f', unused since
2707 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2709 2011-04-02 Jim Meyering <meyering@redhat.com>
2711 do not dereference NULL upon failed strdup
2712 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2713 (ns_get_family): Likewise.
2715 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2717 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2719 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2721 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2724 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2726 Add lexical binding.
2728 * window.c (Ftemp_output_buffer_show): New fun.
2729 (Fsave_window_excursion):
2730 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2732 * lread.c (lisp_file_lexically_bound_p): New function.
2733 (Fload): Bind Qlexical_binding.
2734 (readevalloop): Remove `evalfun' arg.
2735 Bind Qinternal_interpreter_environment.
2736 (Feval_buffer): Bind Qlexical_binding.
2737 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2739 (syms_of_lread): Declare `lexical-binding'.
2741 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2743 * keyboard.c (eval_dyn): New fun.
2744 (menu_item_eval_property): Use it.
2746 * image.c (parse_image_spec): Use Ffunctionp.
2748 * fns.c (concat, mapcar1): Accept byte-code-functions.
2750 * eval.c (Fsetq): Handle lexical vars.
2751 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2752 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2753 (FletX, Flet): Obey lexical binding.
2754 (Fcommandp): Handle closures.
2755 (Feval): New `lexical' arg.
2756 (eval_sub): New function extracted from Feval. Use it almost
2757 everywhere where Feval was used. Look up vars in lexical env.
2759 (Ffunctionp): Move from subr.el.
2760 (Ffuncall): Handle closures.
2761 (apply_lambda): Remove `eval_flags'.
2762 (funcall_lambda): Handle closures and new byte-code-functions.
2763 (Fspecial_variable_p): New function.
2764 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2765 but without exporting it to Lisp.
2767 * doc.c (Fdocumentation, store_function_docstring):
2768 * data.c (Finteractive_form): Handle closures.
2770 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2773 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2775 (exec_byte_code): New function extracted from Fbyte_code to handle new
2776 calling convention for byte-code-functions. Add new byte-codes.
2778 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2780 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2782 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2784 * xdisp.c (redisplay_internal): Fix prototype.
2786 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2788 * xdisp.c (SCROLL_LIMIT): New macro.
2789 (try_scrolling): Use it when setting scroll_limit.
2790 Limit scrolling to 100 screen lines.
2791 (redisplay_window): Even when falling back on "recentering",
2792 position point in the window according to scroll-conservatively,
2793 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2795 (try_scrolling): When point is above the window, allow searching
2796 as far as scroll_max, or one screenful, to compute vertical
2797 distance from PT to the scroll margin position. This prevents
2798 try_scrolling from unnecessarily failing when
2799 scroll-conservatively is set to a value slightly larger than the
2800 window height. Clean up the case of PT below the margin at bottom
2801 of window: scroll_max can no longer be INT_MAX. When aggressive
2802 scrolling is in use, don't let point enter the opposite scroll
2803 margin as result of the scroll.
2804 (syms_of_xdisp) <scroll-conservatively>: Document the
2805 threshold of 100 lines for never-recentering scrolling.
2807 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2809 * dispextern.h (move_it_by_lines):
2810 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2811 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2812 (message_log_check_duplicate): Remove parameters `prev_bol' and
2813 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2814 (redisplay_internal): Remove parameter `preserve_echo_area',
2815 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2817 * indent.c (Fvertical_motion):
2818 * window.c (window_scroll_pixel_based, Frecenter):
2819 Don't pass `need_y_p' to `move_it_by_lines'.
2821 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2823 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2824 steal a few bits to be more compact.
2825 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2826 Remove unneeded casts.
2828 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2830 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2832 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2833 binding" message (bug#7967).
2835 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2837 Fix more problems found by GCC 4.6.0's static checks.
2839 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2840 Remove unused local var.
2842 * editfns.c (Fmessage_box): Remove unused local var.
2844 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2845 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2846 Omit unused local vars.
2847 * window.c (shrink_windows): Omit unused local var.
2848 * menu.c (digest_single_submenu): Omit unused local var.
2849 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2850 Omit unused local var.
2852 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2853 Don't assume string length fits in int.
2854 (keyremap_step, read_key_sequence): Use size_t for sizes.
2855 (read_key_sequence): Don't check last_real_key_start redundantly.
2857 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2858 instead of alloca (Bug#8344).
2860 * eval.c (Fbacktrace): Don't assume nargs fits in int.
2861 (Fbacktrace_frame): Don't assume nframes fits in int.
2863 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2865 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2868 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2870 * cm.c (calccost): Turn while-do into do-while, for clarity.
2872 * keyboard.c (syms_of_keyboard): Use the same style as later
2873 in this function when indexing through an array. This also
2874 works around GCC bug 48267.
2876 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2878 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2880 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2881 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2883 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2884 This avoids undefined behavior on integer overflow, and is a bit
2885 more convenient anyway since it is compared to a size_t variable.
2887 Variadic C functions now count arguments with size_t, not int.
2888 This avoids an unnecessary limitation on 64-bit machines, which
2889 caused (substring ...) to crash on large vectors (Bug#8344).
2890 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2891 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
2892 All variadic functions and their callers changed accordingly.
2893 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2894 * data.c (arith_driver, float_arith_driver): Likewise.
2895 * editfns.c (general_insert_function): Likewise.
2896 * eval.c (struct backtrace.nargs, interactive_p)
2897 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2898 (funcall_lambda, mark_backtrace): Likewise.
2899 * fns.c (concat): Likewise.
2900 * frame.c (x_set_frame_parameters): Likewise.
2901 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2902 0 if not found, not -1. All callers changed.
2904 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2905 (stack_copy_size): Now size_t, not int.
2906 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2908 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2910 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2911 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2912 All callers changed.
2914 * lisp.h (multibyte_char_to_unibyte):
2915 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2916 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2917 * character.h (CHAR_TO_BYTE8):
2918 * cmds.c (internal_self_insert):
2919 * editfns.c (general_insert_function):
2920 * keymap.c (push_key_description):
2921 * search.c (Freplace_match):
2922 * xdisp.c (message_dolog, set_message_1): All callers changed.
2924 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2926 * keyboard.c (safe_run_hook_funcall): New function.
2927 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2928 don't set the hook to nil, but remove the offending function instead.
2929 (Qcommand_hook_internal): Remove, unused.
2930 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2931 Vcommand_hook_internal.
2933 * eval.c (enum run_hooks_condition): Remove.
2934 (funcall_nil, funcall_not): New functions.
2935 (run_hook_with_args): Call each function through a `funcall' argument.
2936 Remove `cond' argument, now redundant.
2937 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2938 (Frun_hook_with_args_until_failure): Adjust accordingly.
2939 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2941 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2943 * dispextern.h (string_buffer_position): Remove declaration.
2945 * print.c (strout): Remove parameter `multibyte', unused since
2946 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2948 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2949 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2950 All callers changed.
2952 * w32.c (_wsa_errlist): Use braces for struct initializers.
2954 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2955 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2956 All callers changed.
2957 (string_buffer_position): Likewise. Also, make static (it's never
2958 used outside xdisp.c).
2959 (cursor_row_p): Remove parameter `w', unused since
2960 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2961 (decode_mode_spec): Remove parameter `precision', introduced during
2962 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2963 All callers changed.
2965 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2967 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2969 2011-03-27 Anders Lindgren <andlind@gmail.com>
2971 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2972 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2973 (ns_update_auto_hide_menu_bar): New functions.
2974 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2975 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2976 ns_constrain_all_frames.
2977 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2978 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2980 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2982 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2984 2011-03-27 Glenn Morris <rgm@gnu.org>
2986 * syssignal.h: Replace RETSIGTYPE with void.
2987 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2988 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2989 Replace SIGTYPE with void everywhere.
2990 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2991 * s/template.h (SIGTYPE): Remove commented out definition.
2993 2011-03-26 Eli Zaretskii <eliz@gnu.org>
2995 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2996 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2998 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3000 * w32.c (read_unc_volume): Use parameter `henum', instead of
3001 global variable `wget_enum_handle'.
3003 * keymap.c (describe_vector): Remove parameters `indices' and
3004 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3005 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3007 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3009 * keyboard.c (timer_check): Remove parameter `do_it_now',
3010 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3011 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3012 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3014 * keyboard.c (read_char):
3015 * w32menu.c (w32_menu_display_help):
3016 * xmenu.c (show_help_event, menu_help_callback):
3017 Adjust calls to `show_help_echo'.
3019 * gtkutil.c (xg_maybe_add_timer):
3020 * keyboard.c (readable_events):
3021 * process.c (wait_reading_process_output):
3022 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3024 * insdel.c (adjust_markers_gap_motion):
3025 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3026 (gap_left, gap_right): Don't call it.
3028 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3030 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3031 incurred during fontification.
3033 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3035 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3036 (DEFVAR_PER_BUFFER): Don't pass it.
3038 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3039 (scrolling_window): Don't pass it.
3041 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3043 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3045 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3047 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3048 of variables specific to SELinux and computation of `encoded_absname'.
3050 * image.c (XPutPixel): Remove unused variable `height'.
3052 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3054 * unexw32.c (get_section_info): Remove unused variable `section'.
3056 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3057 (system_process_attributes): Remove unused variable `sess'.
3058 (sys_read): Remove unused variable `err'.
3060 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3061 (w32_wnd_proc): Remove unused variable `isdead'.
3062 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3063 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3064 (x_create_tip_frame): Remove unused variable `tem'.
3066 * w32inevt.c (w32_console_read_socket):
3067 Remove unused variable `no_events'.
3069 * w32term.c (x_draw_composite_glyph_string_foreground):
3070 Remove unused variable `width'.
3072 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3074 * w32term.c (x_set_glyph_string_clipping):
3075 Don't pass uninitialized region to CombineRgn.
3077 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3079 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3080 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3081 (Fx_close_connection): Remove unused variable `i'.
3083 * w32font.c (w32font_draw): Return number of glyphs.
3084 (w32font_open_internal): Remove unused variable `i'.
3085 (w32font_driver): Add missing initializer.
3087 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3088 (fill_in_menu): Remove unused variable `items_added'.
3090 * w32term.c (last_mouse_press_frame): Remove static global variable.
3091 (w32_clip_to_row): Remove unused variable `f'.
3092 (x_delete_terminal): Remove unused variable `i'.
3094 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3095 (NOTHING): Remove unused static global variable.
3096 (uniscribe_check_otf): Remove unused variable `table'.
3097 (uniscribe_font_driver): Add missing initializers.
3099 2011-03-23 Julien Danjou <julien@danjou.info>
3101 * term.c (Fsuspend_tty, Fresume_tty):
3102 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3103 * window.c (temp_output_buffer_show):
3104 * insdel.c (signal_before_change):
3105 * frame.c (Fhandle_switch_frame):
3106 * fileio.c (Fdo_auto_save):
3107 * emacs.c (Fkill_emacs):
3108 * editfns.c (save_excursion_restore):
3109 * cmds.c (internal_self_insert):
3110 * callint.c (Fcall_interactively):
3111 * buffer.c (Fkill_all_local_variables):
3112 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3114 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3115 unconditionnaly since it does the check itself.
3117 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3119 Fix more problems found by GCC 4.5.2's static checks.
3121 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3122 the first time through the loop, since we know p0 < p1 then.
3123 This also avoids a gcc -Wstrict-overflow warning.
3125 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3126 leading to a memory leak, possible in functions like
3127 load_charset_map_from_file that can allocate an unbounded number
3128 of objects (Bug#8318).
3130 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3131 that could (at least in theory) be that large.
3133 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3134 This is less likely to overflow, and avoids undefined behavior if
3135 overflow does occur. All callers changed. Use strtoul to scan
3136 for the unsigned long integer.
3137 (pint2hrstr): Simplify and tune code slightly.
3138 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3140 * scroll.c (do_scrolling): Work around GCC bug 48228.
3141 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3143 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3144 This also avoids a warning with gcc -Wstrict-overflow.
3145 (validate_x_resource_name): Simplify count usage.
3146 This also avoids a warning with gcc -Wstrict-overflow.
3148 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3151 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3153 * process.c (Fmake_network_process): Use socklen_t, not int,
3154 where POSIX says socklen_t is required in portable programs.
3155 This fixes a porting bug on hosts like 64-bit HP-UX, where
3156 socklen_t is wider than int (Bug#8277).
3157 (Fmake_network_process, server_accept_connection):
3158 (wait_reading_process_output, read_process_output):
3161 * process.c: Rename or move locals to avoid shadowing.
3162 (list_processes_1, Fmake_network_process):
3163 (read_process_output_error_handler, exec_sentinel_error_handler):
3164 Rename or move locals.
3165 (Fmake_network_process): Define label "retry_connect" only if needed.
3166 (Fnetwork_interface_info): Fix pointer signedness.
3167 (process_send_signal): Add cast to avoid pointer signedness problem.
3168 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3169 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3171 Make tparam.h and terminfo.c consistent.
3172 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3173 Include tparam.h instead, since it declares them.
3174 * cm.h (PC): Remove extern decl; tparam.h now does this.
3175 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3176 * terminfo.c: Include tparam.h, to check interfaces.
3177 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3178 (tparam): Adjust signature to match interface in tparam.h;
3179 this removes some undefined behavior. Check that outstring and len
3180 are zero, which they always are with Emacs.
3181 * tparam.h (PC, BC, UP): New extern decls.
3183 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3184 (xftfont_open): Rename locals to avoid shadowing.
3186 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3187 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3188 (OTF_TAG_SYM): Omit macro if not needed.
3189 (ftfont_list): Remove unused local.
3190 (get_adstyle_property, ftfont_pattern_entity):
3191 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3192 Rename locals to avoid shadowing.
3194 * xfont.c (xfont_list_family): Mark var as initialized.
3196 * xml.c (make_dom): Now static.
3198 * composite.c (composition_compute_stop_pos): Rename local to
3200 (composition_reseat_it): Remove unused locals.
3201 (find_automatic_composition, composition_adjust_point): Likewise.
3202 (composition_update_it): Mark var as initialized.
3203 (find_automatic_composition): Mark vars as initialized,
3204 with a FIXME (Bug#8290).
3206 character.h: Rename locals to avoid shadowing.
3207 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3208 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3209 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3210 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3213 * textprop.c (property_change_between_p): Remove; unused.
3215 * intervals.c (interval_start_pos): Now static.
3217 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3219 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3220 Rename locals to avoid shadowing.
3222 * sound.c (wav_play, au_play, Fplay_sound_internal):
3223 Fix pointer signedness.
3224 (alsa_choose_format): Remove unused local var.
3225 (wav_play): Initialize a variable to 0, to prevent undefined
3226 behavior (Bug#8278).
3228 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3230 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3232 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3233 clobbering (Bug#8298).
3234 * sysdep.c (sys_subshell): Likewise.
3235 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3237 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3238 This should get cleaned up, so that child_setup has the
3239 same signature on all platforms.
3241 * callproc.c (call_process_cleanup): Now static.
3242 (relocate_fd): Rename locals to avoid shadowing.
3244 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3246 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3247 not to be necessary, and produces flickering.
3249 2011-03-20 Glenn Morris <rgm@gnu.org>
3251 * config.in: Remove file.
3253 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3255 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3256 are now in src/globals.h.
3257 (syms_of_minibuf): Remove spurious & from previous change.
3259 2011-03-20 Leo <sdl.web@gmail.com>
3261 * minibuf.c (completing-read-function): New variable.
3262 (completing-read-default): Rename from completing-read.
3263 (completing-read): Call completing-read-function.
3265 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3267 * xfaces.c (Fx_load_color_file):
3268 Read color file from absolute filename (bug#8250).
3270 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3272 * makefile.w32-in: Update dependencies.
3274 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3276 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3278 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3280 Fix more problems found by GCC 4.5.2's static checks.
3282 * process.c (make_serial_process_unwind, send_process_trap):
3283 (sigchld_handler): Now static.
3285 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3286 That way, the code declares only the vars that it needs.
3287 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3288 * s/cygwin.h (PTY_ITERATION): Likewise.
3289 * s/darwin.h (PTY_ITERATION): Likewise.
3290 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3292 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3293 * process.c (allocate_pty): Don't declare stb unless it's needed.
3295 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3296 (CONSTANTLIM): Remove; unused.
3297 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3298 Define only if needed.
3300 * unexelf.c (unexec): Name an expression,
3301 to avoid gcc -Wbad-function-cast warning.
3302 Use a different way to cause a compilation error if anyone uses
3303 n rather than nn, a way that does not involve shadowing.
3304 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3306 * deps.mk (unexalpha.o): Remove; unused.
3308 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3309 * unexec.h: New file.
3310 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3311 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3313 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3314 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3315 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3316 Change as necessary to match prototype in unexec.h.
3318 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3320 (back_comment, skip_chars): Mark vars as initialized.
3322 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3323 Rename locals to avoid shadowing.
3325 * lread.c (read1): Rewrite so as not to use empty "else".
3326 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3328 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3330 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3331 warning when compiling print.c.
3333 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3334 instead of using an uninitialized var.
3335 (font_sort_entities): Mark var as initialized.
3337 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3339 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3340 pointers to constants.
3341 (font_parse_fcname): Remove unused vars.
3342 (font_delete_unmatched): Now static.
3343 (font_get_spec): Remove; unused.
3344 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3345 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3346 Rename or move locals to avoid shadowing.
3348 * fns.c (require_nesting_list, require_unwind): Now static.
3349 (Ffillarray): Rename locals to avoid shadowing.
3351 * floatfns.c (domain_error2): Define only if needed.
3352 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3354 * alloc.c (mark_backtrace): Move decl from here ...
3355 * lisp.h: ... to here, so that it can be checked.
3357 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3358 (Fdefvar): Rewrite so as not to use empty "else".
3359 (lisp_indirect_variable): Name an expression,
3360 to avoid gcc -Wbad-function-cast warning.
3361 (Fdefvar): Rename locals to avoid shadowing.
3363 * callint.c (quotify_arg, quotify_args): Now static.
3364 (Fcall_interactively): Rename locals to avoid shadowing.
3365 Use const pointer when appropriate.
3367 * lisp.h (get_system_name, get_operating_system_release):
3368 Move decls here, to check interfaces.
3369 * process.c (get_operating_system_release): Move decl to lisp.h.
3370 * xrdb.c (get_system_name): Likewise.
3371 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3372 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3373 some of which prompt warnings from gcc -Wbad-function-cast.
3374 (Fformat_time_string, Fencode_time, Finsert_char):
3375 (Ftranslate_region_internal, Fformat):
3376 Rename or remove local vars to avoid shadowing.
3377 (Ftranslate_region_internal): Mark var as initialized.
3379 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3382 * lisp.h (eassert): Check that the argument compiles, even if
3383 ENABLE_CHECKING is not defined.
3385 * data.c (Findirect_variable): Name an expression, to avoid
3386 gcc -Wbad-function-cast warning.
3387 (default_value, arithcompare, arith_driver, arith_error): Now static.
3388 (store_symval_forwarding): Rename local to avoid shadowing.
3389 (Fmake_variable_buffer_local, Fmake_local_variable):
3390 Mark variables as initialized.
3391 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
3393 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
3394 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3395 Rename locals to avoid shadowing.
3396 (mark_stack): Move local variables into the #ifdef region where
3398 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3399 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3401 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3402 (GC_STRING_CHARS): Remove; not used.
3403 (Fmemory_limit): Cast sbrk's returned value to char *.
3405 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3406 avoids undefined behavior in theory.
3408 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3410 Use functions, not macros, for up- and down-casing (Bug#8254).
3411 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3412 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3413 to use the following functions instead of these macros.
3414 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3415 EMACS_INT, since callers assume the returned value fits in int.
3416 (upcase1): Likewise, for UPCASE_TABLE.
3417 (uppercasep, lowercasep, upcase): New static inline functions.
3418 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
3419 the race-condition problem in the old DOWNCASE.
3421 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3422 Rename locals to avoid shadowing.
3423 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
3424 (regex_compile, re_search_2, re_match_2_internal):
3425 Remove unused local vars.
3426 (FREE_VAR): Rewrite so as not to use empty "else",
3427 which gcc can warn about.
3428 (regex_compile, re_match_2_internal): Mark locals as initialized.
3429 (RETALLOC_IF): Define only if needed.
3430 (WORDCHAR_P): Likewise. This one is never needed, but is used
3431 only in a comment talking about a compiler bug, so put inside
3432 the #if 0 of that comment.
3433 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3434 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3437 * search.c (boyer_moore): Rename locals to avoid shadowing.
3438 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3439 (PREV_CHAR_BOUNDARY): Likewise.
3441 * search.c (simple_search): Remove unused var.
3443 * dired.c (compile_pattern): Move decl from here ...
3444 * lisp.h: ... to here, so that it can be checked.
3445 (struct re_registers): New forward decl.
3447 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3449 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3451 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3452 Rename locals to avoid shadowing.
3453 (Fvertical_motion): Mark locals as initialized.
3455 * casefiddle.c (casify_object, casify_region): Now static.
3456 (casify_region): Mark local as initialized.
3458 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3460 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3461 New macros, so that the caller can use some names other than
3462 gcpro1, gcpro2, etc.
3463 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3465 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3466 argument, for consistency with GCPRO2_VAR, etc: it is now the
3467 prefix of the variable, not the variable itself. All uses
3469 * dired.c (directory_files_internal, file_name_completion):
3470 Rename locals to avoid shadowing.
3472 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3473 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3474 dired.c's scmp function, had undefined behavior.
3475 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3476 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3477 * buffer.h: ... to here, because these macros use current_buffer,
3478 and the new implementation with inline functions needs to have
3479 current_buffer in scope now, rather than later when the macros
3481 (downcase, upcase1): New static inline functions.
3482 (DOWNCASE, UPCASE1): Reimplement using these functions.
3483 This avoids undefined behavior in expressions like
3484 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3485 from race conditions in accessing the global variables
3486 case_temp1 and case_temp2.
3487 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3488 * lisp.h (case_temp1, case_temp2): Remove their decls.
3489 * character.h (ASCII_CHAR_P): Move from here ...
3490 * lisp.h: ... to here, so that the inline functions mentioned
3493 * dired.c (directory_files_internal_unwind): Now static.
3495 * fileio.c (file_name_as_directory, directory_file_name):
3496 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3498 (file_name_as_directory): Use const pointers when appropriate.
3499 (Fexpand_file_name): Likewise. In particular, newdir might
3500 point at constant storage, so make it a const pointer.
3501 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
3502 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3504 (Fset_file_times, Finsert_file_contents, auto_save_error):
3505 Rename locals to avoid shadowing.
3507 * minibuf.c (choose_minibuf_frame_1): Now static.
3508 (Ftry_completion, Fall_completions): Rename or remove locals
3511 * marker.c (bytepos_to_charpos): Remove; unused.
3513 * lisp.h (verify_bytepos, count_markers): New decls,
3514 so that gcc does not warn that these functions aren't declared.
3516 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3517 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
3518 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
3519 (copy_text): Remove unused local var.
3521 * filelock.c (within_one_second): Now static.
3522 (lock_file_1): Rename local to avoid shadowing.
3524 * buffer.c (fix_overlays_before): Mark locals as initialized.
3525 (fix_start_end_in_overlays): Likewise. This function should be
3526 simplified by using pointers-to-pointers, but that's a different
3528 (switch_to_buffer_1): Now static.
3529 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3530 (report_overlay_modification): Rename locals to avoid shadowing.
3532 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
3533 Fix pointer signedness issue.
3534 (sys_subshell): Mark local as volatile if checking for lint,
3535 to suppress a gcc -Wclobbered warning that does not seem to be right.
3536 (MAXPATHLEN): Define only if needed.
3538 * process.c (serial_open, serial_configure): Move decls from here ...
3539 * systty.h: ... to here, so that they can be checked.
3541 * fns.c (get_random, seed_random): Move extern decls from here ...
3542 * lisp.h: ... to here, so that they can be checked.
3544 * sysdep.c (reset_io): Now static.
3545 (wait_for_termination_signal): Remove; unused.
3547 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3548 (copy_keymap_item, append_key, push_text_char_description):
3550 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
3551 (DENSE_TABLE_SIZE): Remove; unused.
3552 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3553 (describe_map_tree):
3554 Rename locals to avoid shadowing.
3556 * keyboard.c: Declare functions static if they are not used elsewhere.
3557 (echo_char, echo_dash, cmd_error, top_level_2):
3558 (poll_for_input, handle_async_input): Now static.
3559 (read_char, kbd_buffer_get_event, make_lispy_position):
3560 (make_lispy_event, make_lispy_movement, apply_modifiers):
3561 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3562 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3563 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
3564 (read_key_sequence, read_char): Mark locals as initialized.
3565 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
3567 * keyboard.h (make_ctrl_char): New decl.
3568 (mark_kboards): Move decl here ...
3569 * alloc.c (mark_kboards): ... from here.
3571 * lisp.h (force_auto_save_soon): New decl.
3573 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
3574 (DEFINE_DUMMY_FUNCTION): New macro.
3575 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3577 (main): Add casts to avoid warnings
3578 if GCC considers string literals to be constants.
3580 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3582 * dbusbind.c: Pointer signedness fixes.
3583 (xd_signature, xd_append_arg, xd_initialize):
3584 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3585 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3586 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3587 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3589 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3590 if GCC considers string literals to be constants.
3591 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
3593 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3595 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3596 (print_preprocess, print_object): New macro to fix last change.
3598 * print.c (print_preprocess): Don't forget font objects.
3600 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
3602 * emacs.c (USAGE3): Doc fixes.
3604 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3606 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3609 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
3611 * lisp.h (VWindow_system, Qfile_name_history):
3612 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3613 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3614 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3616 * w32select.c: Don't #include "keyboard.h".
3617 (run_protected): Add extern declaration for waiting_for_input.
3619 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3620 * w32console.c (detect_input_pending, read_input_pending)
3621 (encode_terminal_code):
3622 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3623 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3624 (w32_system_caret_y, Qfile_name_history):
3625 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3626 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3627 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3628 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3629 * w32proc.c (Qlocal, report_file_error):
3630 * w32term.c (Vwindow_system, updating_frame):
3631 * w32uniscribe.c (initialized, uniscribe_font_driver):
3632 Remove unneeded extern declarations.
3634 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
3636 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3638 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
3640 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3641 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3642 These macros can no longer be used for assignment.
3644 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3645 Assign struct members directly, instead of using BUF_BEGV etc.
3646 (record_buffer_markers, fetch_buffer_markers): New functions for
3647 recording and fetching special buffer markers.
3648 (set_buffer_internal_1, set_buffer_temp): Use them.
3650 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3652 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3654 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3655 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3657 * xdisp.c (hscroll_window_tree):
3658 (reconsider_clip_changes): Use PT instead of BUF_PT.
3660 2011-03-13 Eli Zaretskii <eliz@gnu.org>
3662 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3663 $(EMACS_ROOT)/lib/intprops.h.
3665 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3667 Fix more problems found by GCC 4.5.2's static checks.
3669 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3670 to unsigned char * to avoid compiler diagnostic.
3671 (xg_free_frame_widgets): Make it clear that a local variable is
3672 needed only if USE_GTK_TOOLTIP.
3673 (gdk_window_get_screen): Make it clear that this macro is needed
3674 only if USE_GTK_TOOLTIP.
3675 (int_gtk_range_get_value): New function, which avoids a diagnostic
3676 from gcc -Wbad-function-cast.
3677 (xg_set_toolkit_scroll_bar_thumb): Use it.
3678 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3679 diagnostic from gcc -Wbad-function-cast.
3680 (get_utf8_string, xg_get_file_with_chooser):
3681 Rename locals to avoid shadowing.
3682 (create_dialog): Move locals to avoid shadowing.
3684 * xgselect.c (xg_select): Remove unused var.
3686 * image.c (four_corners_best): Mark locals as initialized.
3687 (gif_load): Initialize transparent_p to zero (Bug#8238).
3688 Mark another local as initialized.
3689 (my_png_error, my_error_exit): Mark with NO_RETURN.
3691 * image.c (clear_image_cache): Now static.
3692 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3693 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3694 (x_edge_detection): Remove unnecessary cast that
3695 gcc -Wbad-function-cast diagnoses.
3696 (gif_load): Fix pointer signedness.
3697 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3698 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3700 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3702 Improve quality of tests for time stamp overflow.
3703 For example, without this patch (encode-time 0 0 0 1 1
3704 1152921504606846976) returns the obviously-bogus value (-948597
3705 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3706 reports time overflow. See
3707 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3708 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3709 * editfns.c: Include limits.h and intprops.h.
3710 (TIME_T_MIN, TIME_T_MAX): New macros.
3711 (time_overflow): Move earlier, to before first use.
3712 (hi_time, lo_time): New functions, for an accurate test for
3714 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3715 (Fget_internal_run_time): Don't assume time_t fits in int.
3716 (make_time): Use list2 instead of Fcons twice.
3717 (Fdecode_time): More accurate test for out-of-range times.
3718 (check_tm_member): New function.
3719 (Fencode_time): Use it, to test for out-of-range times.
3720 (lisp_time_argument): Don't rely on undefined left-shift and
3721 right-shift behavior when checking for time stamp overflow.
3723 * editfns.c (time_overflow): New function, refactoring common code.
3724 (Fformat_time_string, Fdecode_time, Fencode_time):
3725 (Fcurrent_time_string): Use it.
3727 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3728 * dired.c (make_time): Move to ...
3729 * editfns.c (make_time): ... here.
3730 * systime.h: Note the move.
3732 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3734 * fringe.c (update_window_fringes): Remove unused variables.
3736 * unexmacosx.c (copy_data_segment): Also copy __got section.
3739 2011-03-12 Eli Zaretskii <eliz@gnu.org>
3741 * termcap.c [MSDOS]: Include "msdos.h".
3742 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3743 Constify `char *' arguments and their references according to
3744 prototypes in tparam.h.
3746 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3748 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3749 Adapt all references accordingly.
3751 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3753 2011-03-11 Tom Tromey <tromey@redhat.com>
3755 * buffer.c (syms_of_buffer): Remove obsolete comment.
3757 2011-03-11 Eli Zaretskii <eliz@gnu.org>
3759 * termhooks.h (encode_terminal_code): Declare prototype.
3761 * msdos.c (encode_terminal_code): Don't declare prototype.
3763 * term.c (encode_terminal_code): Now external again, used by
3764 w32console.c and msdos.c.
3766 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3767 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3769 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3771 Fix some minor problems found by GCC 4.5.2's static checks.
3773 * fringe.c (update_window_fringes): Mark locals as initialized
3775 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3777 * alloc.c (mark_fringe_data): Move decl from here ...
3778 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3779 to check its interface.
3780 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3782 * fontset.c (free_realized_fontset): Now static.
3783 (Fset_fontset_font): Rename local to avoid shadowing.
3784 (fontset_font): Mark local as initialized.
3785 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3787 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3789 * xselect.c (x_disown_buffer_selections): Remove; not used.
3790 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3791 (x_own_selection, Fx_disown_selection_internal): Rename locals
3793 (x_handle_dnd_message): Remove local to avoid shadowing.
3795 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3796 so that the caller can use some name other than gcpro1.
3797 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3798 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3799 (Fx_backspace_delete_keys_p):
3800 Use them to avoid shadowing, and rename vars to avoid shadowing.
3801 (x_decode_color, x_set_name, x_window): Now static.
3802 (Fx_create_frame): Add braces to silence GCC warning.
3803 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3804 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3805 Remove unused locals.
3806 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3807 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3808 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3811 * xterm.h (x_mouse_leave): New decl.
3813 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3814 Remove unused functions.
3815 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3816 (x_calc_absolute_position): Now static.
3817 (XTread_socket): Don't define label "out" unless it's used.
3818 Don't declare local "event" unless it's used.
3819 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3820 unless they are used.
3821 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3822 (x_fatal_error_signal): Remove; not used.
3823 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3824 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3825 (x_error_catcher, x_connection_closed, x_error_handler):
3826 (x_error_quitter, xembed_send_message, x_iconify_frame):
3827 (my_log_handler): Rename locals to avoid shadowing.
3828 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3829 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3831 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3832 Rename or move locals to avoid shadowing.
3833 (tty_defined_color, merge_face_heights): Now static.
3834 (free_realized_faces_for_fontset): Remove; not used.
3835 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3836 does not deduce is never used uninitialized.
3837 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3838 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3840 * terminal.c (store_terminal_param): Now static.
3842 * xmenu.c (menu_highlight_callback): Now static.
3843 (set_frame_menubar): Remove unused local.
3844 (xmenu_show): Rename parameter to avoid shadowing.
3845 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3846 since they might point to immutable storage.
3847 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3848 since it's unused otherwise.
3850 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3851 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3852 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3853 avoids a gcc -Wuninitialized diagnostic.
3854 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3855 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3856 does not deduce are never used uninitialized.
3858 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3860 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
3861 * window.c (window_loop, size_window):
3862 (run_window_configuration_change_hook, enlarge_window): Likewise.
3864 * window.c (display_buffer): Now static.
3865 (size_window): Mark variables that gcc -Wuninitialized
3866 does not deduce are never used uninitialized.
3867 * window.h (check_all_windows): New decl, to forestall
3868 gcc -Wmissing-prototypes diagnostic.
3869 * dispextern.h (bidi_dump_cached_states): Likewise.
3871 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3873 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
3875 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3876 and to avoid gcc -Wuninitialized warning.
3877 (load_charset_map): Mark variables that gcc -Wuninitialized
3878 does not deduce are never used uninitialized.
3879 (load_charset): Abort instead of using uninitialized var (Bug#8229).
3881 * coding.c (coding_set_source, coding_set_destination):
3882 Use "else { /* comment */ }" rather than "else /* comment */;"
3883 for clarity, and to avoid gcc -Wempty-body warning.
3884 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3885 a block, when the outer 'i' will do.
3886 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3887 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3888 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3889 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3890 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3891 Rename locals to avoid shadowing.
3892 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
3893 * coding.c (emacs_mule_char, encode_invocation_designation):
3894 Now static, since they're not used elsewhere.
3895 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
3896 (decode_coding_object, encode_coding_object, detect_coding_system):
3897 (decode_coding_emacs_mule): Mark variables that gcc
3898 -Wuninitialized does not deduce are never used uninitialized.
3899 (detect_coding_iso_2022): Initialize a local variable that might
3900 be used uninitialized. Leave a FIXME because it's not clear that
3901 this initialization is needed. (Bug#8211)
3902 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3903 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3904 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3905 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3906 Remove unused macros.
3908 * category.c (hash_get_category_set): Remove unused local var.
3909 (copy_category_table): Now static, since it's not used elsewhere.
3910 * character.c (string_count_byte8): Likewise.
3912 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3913 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3915 * chartab.c (copy_sub_char_table): Now static, since it's not used
3917 (sub_char_table_ref_and_range, char_table_ref_and_range):
3918 Rename locals to avoid shadowing.
3919 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
3921 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
3922 (BIDI_BOB): Remove unused macro.
3924 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3925 deduce are never used uninitialized.
3926 * term.c (encode_terminal_code): Likewise.
3928 * term.c (encode_terminal_code): Now static. Remove unused local.
3930 * tparam.h: New file.
3931 * term.c, tparam.h: Include it.
3932 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3933 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3934 Move these decls to tparam.h, and make them agree with what
3935 is actually in tparam.c. The previous trick of using incompatible
3936 decls in different modules does not conform to the C standard.
3937 All callers of tparam changed to use tparam's actual API.
3938 * tparam.c (tparam1, tparam, tgoto):
3939 Use const pointers where appropriate.
3941 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3942 * cm.h (struct cm): Likewise.
3943 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3944 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3945 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3946 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3947 (turn_on_face, init_tty): Likewise.
3948 * termchar.h (struct tty_display_info): Likewise.
3950 * term.c (term_mouse_position): Rename local to avoid shadowing.
3952 * alloc.c (mark_ttys): Move decl from here ...
3953 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3955 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3957 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3959 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
3961 * search.c (compile_pattern_1): Remove argument regp, unused since
3962 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3963 (compile_pattern): Don't pass it.
3965 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3967 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3968 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3970 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3972 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3974 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3975 gdk_window_get_screen, gdk_window_get_geometry,
3976 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3977 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3978 (xg_get_pixbuf_from_pixmap): New function.
3979 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3980 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3981 Call xg_get_pixbuf_from_pixmap instead of
3982 gdk_pixbuf_get_from_drawable.
3983 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3984 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3985 (xg_check_special_colors): Use GtkStyleContext and its functions
3987 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3988 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3989 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
3990 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3991 Call gtk_widget_get_preferred_size.
3992 (xg_frame_resized): gdk_window_get_geometry only takes 5
3994 (xg_win_to_widget, xg_event_is_for_menubar):
3995 Call gdk_x11_window_lookup_for_display.
3996 (xg_set_widget_bg): New function.
3997 (delete_cb): New function.
3998 (xg_create_frame_widgets): Connect delete-event to delete_cb.
3999 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4000 (xg_set_background_color): Call xg_set_widget_bg.
4001 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4002 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4003 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4004 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4006 (update_frame_tool_bar): Call gtk_widget_hide.
4007 (xg_initialize): Use GDK_KEY_g.
4009 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4011 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4013 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4014 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4015 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4017 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4019 * w32xfns.c (select_palette): Check success of RealizePalette against
4020 GDI_ERROR, not zero.
4022 See ChangeLog.11 for earlier changes.
4028 Copyright (C) 2011 Free Software Foundation, Inc.
4030 This file is part of GNU Emacs.
4032 GNU Emacs is free software: you can redistribute it and/or modify
4033 it under the terms of the GNU General Public License as published by
4034 the Free Software Foundation, either version 3 of the License, or
4035 (at your option) any later version.
4037 GNU Emacs is distributed in the hope that it will be useful,
4038 but WITHOUT ANY WARRANTY; without even the implied warranty of
4039 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4040 GNU General Public License for more details.
4042 You should have received a copy of the GNU General Public License
4043 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.