1 2012-06-28 Andreas Schwab <schwab@linux-m68k.org>
3 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
4 to make the loop interruptible.
6 2012-06-26 Andreas Schwab <schwab@linux-m68k.org>
8 * gnutls.c (emacs_gnutls_handshake): Only retry if
11 2012-06-23 Eli Zaretskii <eliz@gnu.org>
13 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
14 in the logic of incrementing and decrementing the value of
15 use_relocatable_buffers.
17 2012-06-21 Glenn Morris <rgm@gnu.org>
19 * charset.c (init_charset): Make lack of etc/charsets fatal.
21 2012-06-11 Jan Djärv <jan.h.d@swipnet.se>
23 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
24 referenced (Bug#11583).
26 2012-06-01 Chong Yidong <cyd@gnu.org>
28 * Version 24.1 released.
30 2012-05-30 Eli Zaretskii <eliz@gnu.org>
32 * xdisp.c (handle_stop): Detect whether we have overlay strings
33 loaded by testing it->current.overlay_string_index to be
34 non-negative, instead of checking whether n_overlay_strings is
37 2012-05-30 Chong Yidong <cyd@gnu.org>
39 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
41 * doc.c (Fsubstitute_command_keys): Doc fix.
43 2012-05-29 Eli Zaretskii <eliz@gnu.org>
45 * search.c (search_buffer): Remove calls to
46 r_alloc_inhibit_buffer_relocation, as it is now called by
47 maybe_unify_char, which was the cause of relocation of buffer text
50 2012-05-23 Eli Zaretskii <eliz@gnu.org>
52 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
53 for the duration of call to load_charset, to avoid problems with
54 callers of maybe_unify_char that access buffer text through C
57 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
58 decrement the inhibition flag, instead of just setting or
61 2012-05-24 Ken Brown <kbrown@cornell.edu>
63 * callproc.c (Fcall_process): Restore a line that was accidentally
64 commented out in the 2011-02-13 change (bug#11547).
66 2012-05-23 Eli Zaretskii <eliz@gnu.org>
68 * lisp.h [REL_ALLOC]: Add prototypes for external functions
71 * buffer.c [REL_ALLOC]: Remove prototypes of
72 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
73 they are now on lisp.h.
75 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
77 * search.c (search_buffer): Use it to inhibit relocation of buffer
78 text while re_search_2 is doing its job, because re_search_2 is
79 passed C pointers to buffer text. (Bug#11519)
81 2012-05-21 Eli Zaretskii <eliz@gnu.org>
83 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
86 2012-05-19 Eli Zaretskii <eliz@gnu.org>
88 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
89 state after an additional call to move_it_in_display_line_to, keep
90 the values of it->max_ascent and it->max_descent found for the
92 (pos_visible_p): Revert the comparison against bottom_y to what it
93 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
96 2012-05-15 Eli Zaretskii <eliz@gnu.org>
98 * xdisp.c (pos_visible_p): Fix last change. (Bug#11464)
100 2012-05-13 Eli Zaretskii <eliz@gnu.org>
102 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
103 already have overlays loaded.
104 (handle_single_display_spec): Before returning without displaying
105 fringe bitmap, synchronize the bidi iterator with the main display
106 iterator, by calling iterate_out_of_display_property.
107 (iterate_out_of_display_property): Detect buffer iteration by
108 testing that it->string is a Lisp string.
109 (get_next_display_element): When the current object is exhausted,
110 and there's something on it->stack, call set_iterator_to_next to
111 proceed with what's on the stack, instead of returning zero.
112 (set_iterator_to_next): If called at the end of a Lisp string,
113 proceed to consider_string_end without incrementing string
114 position. Don't increment display vector index past the end of
115 the display vector. (Bug#11417)
116 (pos_visible_p): Don't report a position visible when move_it_to
117 stopped at the last line of window, which happens to be scanned
118 backwards by the bidi iteration. (Bug#11464)
120 2012-05-11 Eli Zaretskii <eliz@gnu.org>
122 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
123 and right-margin display specs even if the spec is invalid or we
124 are on a TTY, and thus unable to display on the fringes. That's
125 because the text with the property will not be displayed anyway,
126 so we need to signal to the caller that this is a "replacing"
127 display spec. This fixes display when the spec is invalid or we
130 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
132 * unexaix.c (make_hdr): Fix typo in prototype.
133 This bug broke the build on AIX. Problem reported by Gilles Pion.
135 2012-05-05 Eli Zaretskii <eliz@gnu.org>
137 * w32proc.c (new_child): Force Windows to reserve only 64KB of
138 stack for each reader_thread, instead of defaulting to 8MB
139 determined by the linker. This avoids failures in creating
140 subprocesses on Windows 7, see the discussion in this thread:
141 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
143 2012-05-02 Jim Meyering <meyering@redhat.com>
145 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
147 2012-04-29 Eli Zaretskii <eliz@gnu.org>
149 * xdisp.c (pos_visible_p): If already at a newline from the
150 display string before the 'while' loop, don't walk back the glyphs
151 from it3.glyph_row. Solves assertion violation when the display
152 string begins with a newline (egg.el). (Bug#11367)
154 2012-04-24 Chong Yidong <cyd@gnu.org>
156 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
158 2012-04-23 Eli Zaretskii <eliz@gnu.org>
160 * xdisp.c (pos_visible_p): If the window start position is beyond
161 ZV, start the display from buffer beginning. Prevents assertion
162 violation in init_iterator when the minibuffer window is scrolled
165 * window.c (window_scroll_pixel_based): Likewise.
167 2012-04-23 Chong Yidong <cyd@gnu.org>
169 * keymap.c (where_is_internal): Doc fix (Bug#10872).
171 2012-04-20 Glenn Morris <rgm@gnu.org>
173 * fileio.c (Fcopy_file, Fset_file_selinux_context):
174 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
176 2012-04-20 Eli Zaretskii <eliz@gnu.org>
178 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers): Don't
179 overrun array limits of glyph row's used[] array. (Bug#11288)
181 2012-04-20 Chong Yidong <cyd@gnu.org>
183 * process.c (wait_reading_process_output): If EIO occurs on a pty,
184 set the status to "failed" and ensure that sentinel is run.
186 2012-04-18 Glenn Morris <rgm@gnu.org>
188 * process.c (Fset_process_inherit_coding_system_flag)
189 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
190 (Fmake_network_process, Fmake_serial_process): Doc fix.
192 2012-04-17 Eli Zaretskii <eliz@gnu.org>
194 * xdisp.c (string_buffer_position_lim): Limit starting position to
196 (set_cursor_from_row): If called for a mode-line or header-line
197 row, return zero immediately.
198 (try_cursor_movement): If inside continuation line, don't back up
199 farther than the first row after the header line, if any. Don't
200 consider the header-line row as "partially visible", even if
201 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
203 2012-04-13 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
205 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n" (bug#11238).
207 2012-04-10 Teodor Zlatanov <tzz@lifelogs.com>
209 * process.c (make_process):
210 * process.h: Add integer `gnutls_handshakes_tried' member to
213 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
214 Add convenience `GNUTLS_LOG2i' macro.
216 * gnutls.c (gnutls_log_function2i): Convenience log function.
217 (emacs_gnutls_read): Use new log functions,
218 `gnutls_handshakes_tried' process member, and
219 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
220 attempts per process (connection).
222 2012-04-09 Eli Zaretskii <eliz@gnu.org>
224 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
225 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
227 2012-04-09 Jan Djärv <jan.h.d@swipnet.se>
229 * nsterm.m (constrainFrameRect): Always constrain when there is only
230 one screen (Bug#10962).
232 2012-04-06 Eli Zaretskii <eliz@gnu.org>
234 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
235 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
236 about subtle differences between FETCH_CHAR* and STRING_CHAR*
237 macros related to unification of CJK characters. For the details,
238 see the discussion following the message here:
239 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
241 2012-04-04 Chong Yidong <cyd@gnu.org>
243 * keyboard.c (Vdelayed_warnings_list): Doc fix.
245 2012-04-01 Eli Zaretskii <eliz@gnu.org>
247 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
248 instead of alloca. (Bug#11138)
250 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
252 * w32menu.c (is_simple_dialog): Properly check lisp types.
255 2012-03-31 Eli Zaretskii <eliz@gnu.org>
257 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
258 position we get to after a call to move_it_to fails the
259 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
260 only if we wind up in a string from display property. (Bug#11063)
262 * window.c (Fdelete_other_windows_internal): Invalidate the row
263 and column information about mouse highlight, so that redisplay
264 restores it after reallocating the glyph matrices. (Bug#7464)
266 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
267 string comes from a `display' text property, use the buffer
268 position of that property as if we actually saw that position in
270 (move_it_by_lines): Remove the assertion that
271 "it->current_x == 0 && it->hpos == 0" which can be legitimately
272 violated when there's a before-string at the beginning of a line.
275 2012-03-30 Eli Zaretskii <eliz@gnu.org>
277 * xdisp.c (append_space_for_newline): If the default face was
278 remapped, use the remapped face for the appended newline.
279 (extend_face_to_end_of_line): Use the remapped default face for
280 extending the face to the end of the line.
281 (display_line): Call extend_face_to_end_of_line when the default
282 face was remapped. (Bug#11068)
284 2012-03-29 Eli Zaretskii <eliz@gnu.org>
286 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
288 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
290 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
292 2012-03-27 Glenn Morris <rgm@gnu.org>
294 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
297 2012-03-26 Kenichi Handa <handa@m17n.org>
299 * dispextern.h (struct glyph): Fix previous change. Change the
300 bit length of glyphless.ch to 25 (Bug#11082).
302 2012-03-26 Chong Yidong <cyd@gnu.org>
304 * keyboard.c (Vselection_inhibit_update_commands): New variable.
305 (command_loop_1): Use it; inhibit selection update for
306 handle-select-window too (Bug#8996).
308 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
310 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
312 2012-03-25 Kenichi Handa <handa@m17n.org>
314 * dispextern.h (struct glyph): Change the bit length of
315 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
317 2012-03-24 Eli Zaretskii <eliz@gnu.org>
319 * s/ms-w32.h (tzname): Include time.h before redirecting to
320 _tzname. Fixes the MSVC build. (Bug#9960)
322 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
324 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
327 * xterm.c (XTread_socket): Only modify handling_signal if
328 !SYNC_INPUT. (Bug#11080)
330 2012-03-23 Eli Zaretskii <eliz@gnu.org>
332 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
333 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
334 when fetching a multibyte character consumes more bytes than
335 CHAR_BYTES returns, due to unification of CJK characters in
336 string_char. (Bug#11073)
338 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
340 * process.c (wait_reading_process_output): Handle pty disconnect
341 by refraining from sending oneself a SIGCHLD (bug#10933).
343 2012-03-22 Chong Yidong <cyd@gnu.org>
345 * dispextern.h (struct it): New member string_from_prefix_prop_p.
347 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
348 Mark string as coming from a prefix property.
349 (handle_face_prop): Use default face for prefix strings (Bug#4281).
350 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
352 2012-03-21 Chong Yidong <cyd@gnu.org>
354 * xfaces.c (Vface_remapping_alist): Doc fix.
356 2012-03-20 Eli Zaretskii <eliz@gnu.org>
358 * w32proc.c (Fw32_set_console_codepage)
359 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
362 2012-03-20 Chong Yidong <cyd@gnu.org>
364 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
365 to reflect default non-nil value of redisplay-dont-pause.
367 2012-03-19 Kenichi Handa <handa@m17n.org>
369 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
370 it fit in a valid range (Bug#11003).
372 2012-03-18 Eli Zaretskii <eliz@gnu.org>
374 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
375 that is not from display property, accept the row as a "cursor
376 row" if one of the string's character has a non-nil `cursor'
377 property. Fixes cursor positioning when there are newlines in
378 overlay strings, e.g. in icomplete.el. (Bug#11035)
380 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
382 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
384 2012-03-12 Chong Yidong <cyd@gnu.org>
386 * eval.c (inhibit_lisp_code): Rename from
387 inhibit_window_configuration_change_hook; move from window.c.
389 * xfns.c (unwind_create_frame_1, Fx_create_frame):
390 * window.c (run_window_configuration_change_hook)
391 (syms_of_window): Callers changed.
393 2012-03-11 Chong Yidong <cyd@gnu.org>
395 * keymap.c (Fkey_description): Doc fix (Bug#9700).
397 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
399 2012-03-10 Chong Yidong <cyd@gnu.org>
401 * frame.c (other_visible_frames): Don't assume the selected frame
402 is visible (Bug#10955).
404 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
406 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
408 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
410 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
411 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
414 2012-03-03 Glenn Morris <rgm@gnu.org>
416 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
418 2012-03-02 Eli Zaretskii <eliz@gnu.org>
420 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
421 position past the first glyph_row that ends at ZV. (Bug#10902)
422 (redisplay_window, next_element_from_string): Fix typos in
424 (redisplay_window): Pass to move_it_vertically the margin in
425 pixels, not in screen lines.
427 2012-03-02 Glenn Morris <rgm@gnu.org>
429 * buffer.c (buffer-list-update-hook): Doc fix.
431 2012-02-29 Eli Zaretskii <eliz@gnu.org>
433 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
434 push_it before setting up the iterator for the first overlay
435 string, even if we have an empty string loaded.
436 (next_overlay_string): If there's an empty string on the iterator
437 stack, pop the stack. (Bug#10903)
439 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
441 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
442 Suggested by Stefan Monnier in
443 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
444 * alloc.c (widen_to_Lisp_Object): New static function.
445 (mark_memory): Also mark Lisp_Objects by fetching pointer words
446 and widening them to Lisp_Objects. This would work even if
447 USE_LSB_TAG is defined and wide integers are used, which might
448 happen in a future version of Emacs.
450 2012-02-25 Chong Yidong <cyd@gnu.org>
452 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
455 * xselect.c (Fx_selection_exists_p): Doc fix.
456 (x_clipboard_manager_save_all): Print an informative message
457 before saving to clipboard manager.
459 2012-02-24 Chong Yidong <cyd@gnu.org>
461 * keyboard.c (process_special_events): Handle all X selection
462 requests in kbd_buffer, not just the next one (Bug#8869).
464 2012-02-23 Chong Yidong <cyd@gnu.org>
466 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
467 call when setting menu-bar-lines and tool-bar-lines parameters.
468 (unwind_create_frame_1): New helper function.
470 * window.c (inhibit_window_configuration_change_hook): New var.
471 (run_window_configuration_change_hook): Obey it.
472 (syms_of_window): Initialize it.
474 2012-02-22 Chong Yidong <cyd@gnu.org>
476 * xterm.c (x_draw_image_relief): Add missing type check for
477 Vtool_bar_button_margin (Bug#10743).
479 2012-02-21 Chong Yidong <cyd@gnu.org>
481 * fileio.c (Vfile_name_handler_alist): Doc fix.
483 * buffer.c (Fget_file_buffer): Protect against invalid file
484 handler return value.
486 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
488 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
489 when computing $valmask.
491 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
492 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
493 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
494 It's useless in that case, and it can cause problems on hosts
495 that allocate halves of EMACS_INT values separately.
496 Reported by Dan Horák. Diagnosed by Andreas Schwab in
497 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
498 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
499 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
500 it avoids undefined behavior on hosts where shifting right by more
501 than the word width has undefined behavior.
503 2012-02-19 Chong Yidong <cyd@gnu.org>
505 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
506 (Funhandled_file_name_directory, Ffile_name_as_directory)
507 (Fdirectory_file_name, Fexpand_file_name)
508 (Fsubstitute_in_file_name): Protect against invalid file handler
509 return values (Bug#10845).
511 2012-02-18 Eli Zaretskii <eliz@gnu.org>
513 * .gdbinit (pitx): Fix incorrect references to fields of the
516 2012-02-17 Chong Yidong <cyd@gnu.org>
518 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
520 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
522 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
523 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
525 2012-02-15 Chong Yidong <cyd@gnu.org>
527 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
528 marked as special. Also, starting docstrings with * is obsolete.
530 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
532 * gnutls.c (emacs_gnutls_write): Fix last change.
534 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
536 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
539 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
541 * keymap.c (Fsingle_key_description): Handle char ranges.
543 2012-02-12 Chong Yidong <cyd@gnu.org>
545 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
546 as that creates a dangerous corner case.
548 * window.c (Fdelete_window_internal): Invalidate the mouse
549 highlight (Bug#9904).
551 2012-02-12 Glenn Morris <rgm@gnu.org>
553 * xselect.c (Fx_own_selection_internal)
554 (Fx_get_selection_internal, Fx_disown_selection_internal)
555 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
556 * nsselect.m (Fx_own_selection_internal)
557 (Fx_disown_selection_internal, Fx_selection_exists_p)
558 (Fx_selection_owner_p, Fx_get_selection_internal):
559 Sync docs and argument specs with the xselect.c versions.
561 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
563 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
565 2012-02-11 Eli Zaretskii <eliz@gnu.org>
567 * w32select.c (Fx_selection_exists_p): Sync doc string and
568 argument list with xselect.c. (Bug#10783)
570 * w16select.c (Fx_selection_exists_p): Sync doc string and
571 argument list with xselect.c. (Bug#10783)
573 2012-02-10 Glenn Morris <rgm@gnu.org>
575 * fns.c (Fsecure_hash): Doc fix.
577 2012-02-09 Kenichi Handa <handa@m17n.org>
579 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
581 2012-02-07 Chong Yidong <cyd@gnu.org>
583 * buffer.c (Fbuffer_local_variables)
584 (buffer_lisp_local_variables): Handle unbound vars correctly;
585 don't let Qunbound leak into Lisp.
587 2012-02-07 Glenn Morris <rgm@gnu.org>
589 * image.c (Fimagemagick_types): Doc fix.
591 * image.c (imagemagick-render-type): Change it from a lisp object
592 to an integer. Move the doc here from the lisp manual.
593 Treat all values not equal to 0 the same.
595 2012-02-06 Chong Yidong <cyd@gnu.org>
597 * doc.c (store_function_docstring): Avoid applying docstring of
598 alias to base function (Bug#2603).
600 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
602 * .gdbinit (pp1, pv1): Remove redundant defines.
605 2012-02-04 Chong Yidong <cyd@gnu.org>
607 * nsterm.m: Declare a global (Bug#10694).
609 2012-02-04 Eli Zaretskii <eliz@gnu.org>
611 * w32.c (get_emacs_configuration_options):
612 Include --enable-checking, if specified, in the return value.
614 2012-02-04 Martin Rudalics <rudalics@gmx.at>
616 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
617 after rounding frame sizes. (Bug#9723)
619 2012-02-04 Eli Zaretskii <eliz@gnu.org>
621 * keyboard.c (adjust_point_for_property): Don't position point
622 before BEGV. (Bug#10696)
624 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
626 Handle overflow when computing char display width (Bug#9496).
627 * character.c (char_width): Return EMACS_INT, not int.
628 (char_width, c_string_width): Check for overflow when
629 computing the width; this is possible now that individual
630 characters can have unbounded width. Problem introduced
631 by merge from Emacs 23 on 2012-01-19.
633 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
635 * dbusbind.c (Fdbus_register_method): Mention the return value
636 :ignore in the docstring.
638 2012-02-02 Glenn Morris <rgm@gnu.org>
640 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
642 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
643 Unconditionally set to t. (Bug#10673)
644 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
645 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
646 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
648 2012-02-02 Kenichi Handa <handa@m17n.org>
650 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
651 0, do not call append_composite_glyph.
653 2012-02-02 Kenichi Handa <handa@m17n.org>
655 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
657 (x_produce_glyphs): If the component of a composition is a null
658 string, set it->pixel_width to 1 to avoid zero-width glyph.
660 2012-02-01 Eli Zaretskii <eliz@gnu.org>
662 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
663 first 2 arguments are identical. This makes inserting large
664 output from a subprocess an order of magnitude faster on
665 MS-Windows, where all sbrk'ed memory is always contiguous.
667 2012-01-31 Glenn Morris <rgm@gnu.org>
669 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
670 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
671 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
673 2012-01-29 Glenn Morris <rgm@gnu.org>
675 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
677 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
679 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
681 2012-01-28 Chong Yidong <cyd@gnu.org>
683 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
685 2012-01-26 Chong Yidong <cyd@gnu.org>
687 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
689 * search.c (Fsearch_forward, Fsearch_backward): Document negative
690 repeat counts (Bug#10507).
692 2012-01-26 Glenn Morris <rgm@gnu.org>
694 * lread.c (syms_of_lread): Doc fix.
696 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
698 * coding.c (encode_designation_at_bol): Change return value to
701 2012-01-25 Chong Yidong <cyd@gnu.org>
703 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
705 2012-01-21 Chong Yidong <cyd@gnu.org>
707 * floatfns.c (Fcopysign): Make the second argument non-optional,
708 since nil is not allowed anyway.
710 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
712 * process.c (read_process_output): Use p instead of XPROCESS (proc).
713 (send_process): Likewise.
715 2012-01-19 Martin Rudalics <rudalics@gmx.at>
717 * window.c (save_window_save, Fcurrent_window_configuration)
718 (Vwindow_persistent_parameters): Do not use Qstate.
721 2012-01-19 Kenichi Handa <handa@m17n.org>
723 * character.c (char_width): New function.
724 (Fchar_width, c_string_width, lisp_string_width):
725 Use char_width (Bug#9496).
727 2012-01-16 Martin Rudalics <rudalics@gmx.at>
729 * window.c (Vwindow_persistent_parameters): New variable.
730 (Fset_window_configuration, save_window_save): Handle persistent
733 2012-01-14 Eli Zaretskii <eliz@gnu.org>
735 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
736 thrashing the stack of the thread. (Bug#9087)
738 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
740 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
742 2012-01-11 Eli Zaretskii <eliz@gnu.org>
744 * xdisp.c (rows_from_pos_range): Handle the case where the
745 highlight ends on a newline. (Bug#10464)
746 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
747 he end column for display of highlight that ends on a newline
750 2012-01-11 Glenn Morris <rgm@gnu.org>
752 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
753 from load-path also when installation-directory is nil. (Bug#10208)
755 2012-01-10 Glenn Morris <rgm@gnu.org>
757 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
759 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
760 Update template values to be closer to their typical values these days.
762 2012-01-09 Eli Zaretskii <eliz@gnu.org>
764 * xdisp.c (rows_from_pos_range): Accept additional argument
765 DISP_STRING, and accept any glyph in a row whose object is that
766 string as eligible for mouse highlight. Fixes mouse highlight of
767 display strings from overlays. (Bug#10464)
769 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
771 emacs: fix an auto-save permissions race condition (Bug#10400)
772 * fileio.c (auto_saving_dir_umask): New static var.
773 (Fmake_directory_internal): Use it.
774 (do_auto_save_make_dir): Set it, instead of invoking chmod after
775 creating the directory. The old code temporarily assigns
776 too-generous permissions to the directory.
777 (do_auto_save_eh): Clear it.
778 (Fdo_auto_save): Catch all errors, not just file errors, so
779 that the var is always cleared.
781 2012-01-07 Eli Zaretskii <eliz@gnu.org>
783 * search.c (scan_buffer): Pass character positions to
784 know_region_cache, not byte positions. (Bug#6540)
786 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
788 * w32.c (sys_rename): Report EXDEV when rename of a directory
789 fails because the target is on another logical disk. (Bug#10284)
791 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
793 * xterm.c (x_embed_request_focus): New function.
795 * xterm.h: Add prototype.
797 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
799 2012-01-05 Glenn Morris <rgm@gnu.org>
801 * emacs.c (emacs_copyright): Update short copyright year to 2012.
803 2012-01-01 Eli Zaretskii <eliz@gnu.org>
805 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
806 Load gnutls_transport_set_lowat only if GnuTLS version is below
808 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
809 GnuTLS versions below 2.11.1.
811 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
813 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
814 to the doc string advising against its use for altering the way
815 windows are scrolled.
817 2011-12-28 Kenichi Handa <handa@m17n.org>
819 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
820 coding-system ASCII compatible only when it does not produce BOM
821 on encoding (Bug#10383).
823 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
825 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
827 (create_and_show_popup_menu): Always use menu_position_func for
830 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
832 * callint.c (Fcall_interactively): Don't truncate prompt string.
834 2011-12-23 Eli Zaretskii <eliz@gnu.org>
836 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
837 property that ends at ZV, so that the bidi iteration could be
838 resumed from there (after widening). (Bug#10360)
840 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
842 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
844 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
846 * nsterm.m (x_free_frame_resources):
847 Release f->output_data.ns->miniimage.
848 (ns_index_color): Fix indentation. Do not retain
849 color_table->colors[i].
851 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
854 * nsfns.m (x_set_background_color): Assign return value from
855 ns_index_color to face-background instead of NSColor*.
856 (ns_implicitly_set_icon_type): Fix indentation.
857 Change assignment in for loop to comparison.
859 * emacs.c (ns_pool): New variable.
860 (main): Assign ns_pool.
861 (Fkill_emacs): Call ns_release_autorelease_pool.
863 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
864 autorelease fdesc, release fdAttrs and tdict.
865 (ns_get_covering_families): Release charset.
866 (ns_findfonts): Release NSFontDescriptor created with new.
867 (ns_uni_to_glyphs): Fix indentation.
868 (setString): Release attrStr before assigning new value.
870 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
872 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
874 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
875 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
877 2011-12-18 David Reitter <reitter@cmu.edu>
879 * nsterm.m (ns_term_init): Subscribe for notifications
880 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
881 to method trackingNotification in EmacsMenu.
883 * nsmenu.m (trackingMenu): New variable.
884 (trackingNotification): New method (from Aquamacs).
885 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
886 from Aquamacs (Bug#7030).
888 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
890 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
891 (symbol_to_nsstring): Fix indentation.
892 (ns_symbol_to_pb): New function.
893 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
894 (Fns_rotate_cut_buffers_internal): Remove.
895 (Fns_store_selection_internal): Rename from
896 Fns_store_cut_buffer_internal.
897 (ns_get_foreign_selection, Fx_own_selection_internal)
898 (Fx_disown_selection_internal, Fx_selection_exists_p)
899 (Fns_get_selection_internal, Fns_store_selection_internal):
900 Use ns_symbol_to_pb and check if return value is nil.
901 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
902 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
903 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
904 renamed to Sns_store_selection_internal.
905 (ns_handle_selection_request): Move code to Fx_own_selection_internal
906 and remove this function.
907 (ns_handle_selection_clear): Remove, never used.
908 (Fx_own_selection_internal): Move code from ns_handle_selection_request
911 2011-12-17 Ken Brown <kbrown@cornell.edu>
913 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
914 GID is unknown (Bug#10257).
916 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
918 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
919 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
920 which caused a build failure on GNU/Linux IA-64. This problem was
921 introduced by my 2011-10-07 patch.
923 2011-12-15 Juri Linkov <juri@jurta.org>
925 * image.c (imagemagick_error): New function. (Bug#10112)
926 (imagemagick_load_image): Comment out `MagickSetResolution' call.
927 Use `imagemagick_error' where ImageMagick functions return
929 (Fimagemagick_types): Add `Fnreverse' to return the list in the
932 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
934 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
935 fill background (Bug#8992).
937 2011-12-13 Martin Rudalics <rudalics@gmx.at>
939 * window.c (Vwindow_combination_resize)
940 (Vwindow_combination_limit): Use t instead of non-nil in
942 (Vrecenter_redisplay): Add first sentence of doc-string on
944 (Frecenter): Fix doc-string typo.
946 2011-12-11 Kenichi Handa <handa@m17n.org>
948 * coding.c (Funencodable_char_position): Pay attention to the
949 buffer text relocation (Bug#9389).
951 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
953 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
954 gtk_init (Bug#10100).
956 2011-12-10 Eli Zaretskii <eliz@gnu.org>
958 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
959 IT->string is nil. (Bug#10263)
961 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
963 * nsterm.h (x_free_frame_resources): Declare.
965 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
966 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
968 * nsterm.h (ns_get_defaults_value): Declare.
970 * nsterm.m (ns_default): Call ns_get_defaults_value.
972 2011-12-09 Eli Zaretskii <eliz@gnu.org>
974 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
977 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
979 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
980 that where the value of an _OBJC_* symbol points to is in the .bss
983 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
985 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
986 after the loop to call ccl_driver at least once (Bug#8619).
988 2011-12-08 Kenichi Handa <handa@m17n.org>
990 * ftfont.c (get_adstyle_property): Fix previous change
993 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
995 * w32.c (init_environment): If no_site_lisp, remove site-lisp
996 dirs from the default value of EMACSLOADPATH (bug#10208).
998 2011-12-07 Glenn Morris <rgm@gnu.org>
1000 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1001 installation and source directories as well. (Bug#10208)
1003 2011-12-06 Chong Yidong <cyd@gnu.org>
1005 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1007 2011-12-06 Glenn Morris <rgm@gnu.org>
1009 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1010 as an error, not just -1. (Bug#10217)
1012 2011-12-05 Chong Yidong <cyd@gnu.org>
1014 * keyboard.c (process_special_events): New function.
1015 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1017 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1019 * coding.c (encode_designation_at_bol): Don't use uninitialized
1020 local variable (Bug#9318).
1022 2011-12-05 Kenichi Handa <handa@m17n.org>
1024 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1025 return Qnil (Bug#8046, Bug#10193).
1027 2011-12-05 Kenichi Handa <handa@m17n.org>
1029 * coding.c (encode_designation_at_bol): New args charbuf_end and
1030 dst. Return the number of produced bytes. Callers changed.
1031 (coding_set_source): Return how many bytes coding->source was
1033 (coding_set_destination): Return how many bytes
1034 coding->destination was relocated.
1035 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1036 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1038 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1040 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1041 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1044 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1046 The following changes are to fix Bug#9318.
1048 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1049 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1050 (encode_coding_iso_2022, encode_coding_sjis)
1051 (encode_coding_big5, encode_coding_charset): Use the above macros.
1053 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1055 * lisp.h (process_quit_flag): Fix external declaration.
1057 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1059 Don't macro-inline non-performance-critical code.
1060 * eval.c (process_quit_flag): New function.
1061 * lisp.h (QUIT): Use it.
1063 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1065 * nsfns.m (get_geometry_from_preferences): New function.
1066 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1068 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1070 * emacs.c (Qkill_emacs): Define.
1071 (syms_of_emacs): Initialize it.
1072 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1073 Qquit_flag to `kill-emacs' instead.
1074 (quit_throw_to_read_char): Add parameter `from_signal'.
1075 All callers changed. Call Fkill_emacs if requested and safe.
1076 * lisp.h (QUIT): Call Fkill_emacs if requested.
1078 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1080 * widget.c (update_wm_hints): Return if wmshell is null.
1081 (widget_update_wm_size_hints): New function.
1083 * widget.h (widget_update_wm_size_hints): Declare.
1085 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1086 widget_update_wm_size_hints (Bug#10104).
1088 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1090 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1091 before a newline, prepare the bidi iterator for consuming the
1092 newline, and keep the current paragraph direction. (Bug#10183)
1093 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1095 2011-12-02 Juri Linkov <juri@jurta.org>
1097 * search.c (Fword_search_regexp): New Lisp function created from
1098 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1099 (Fword_search_backward, Fword_search_forward)
1100 (Fword_search_backward_lax, Fword_search_forward_lax):
1101 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1102 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1104 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1106 * fileio.c (Finsert_file_contents): Move after-change-function call
1107 to before the "handled:" label, since all "goto handled" appear in
1108 cases where the *-change-functions have already been properly called
1111 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1113 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1114 waiting for input. (Bug#10169)
1116 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1118 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1119 verifies glyph row's hash code--we have just reallocated the
1120 glyphs, so their contents can be complete garbage. (Bug#10164)
1122 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1124 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1126 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1128 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1129 attributes are tested _before_ calling verify_row_hash, to protect
1130 against GCC re-ordering of the tests. (Bug#10164)
1132 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1134 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1136 * xterm.c (handle_one_xevent): Only set async_visible and friends
1137 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1138 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1139 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1141 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1143 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1144 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1145 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1146 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1147 All uses changed to use GCPRO1 etc.
1148 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1149 Revert to old implementation (i.e., before 2011-03-11).
1151 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1153 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1154 of scroll runs so as to avoid assigning disabled bogus rows and
1155 unnecessary graphics copy operations.
1157 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1159 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1160 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1161 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1162 (malloc, free, realloc, calloc): Redirect to e_* only when
1165 * lisp.h (GCTYPEBITS): Move before first use.
1166 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1167 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1168 this macro definition.
1170 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1173 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1175 * gtkutil.c (xg_create_frame_widgets):
1176 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1177 present with Gtk+ 2.0.
1179 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1181 * fileio.c (Finsert_file_contents): Undo previous change; see
1182 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1184 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1186 Rename locals to avoid shadowing.
1187 * fileio.c (Finsert_file_contents):
1188 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1189 * process.c (wait_reading_process_output):
1190 Rename inner 'proc' to 'p' to avoid shadowing.
1191 Indent for consistency with usual Emacs style.
1193 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1195 * xdisp.c (redisplay_window): If cursor row is not fully visible
1196 after recentering, and scroll-conservatively is set to a large
1197 number, scroll window by a few more lines to make the cursor fully
1198 visible and out of scroll-margin. (Bug#10105)
1199 (start_display): Don't move to the next line if the display should
1200 start at a newline that is part of a display vector or an overlay
1203 2011-11-24 Juri Linkov <juri@jurta.org>
1205 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1206 after the `MagickPingImage' call. (Bug#10112)
1208 2011-11-23 Chong Yidong <cyd@gnu.org>
1210 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1212 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1214 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1215 making another buffer current. (Bug#10114)
1217 2011-11-23 Glenn Morris <rgm@gnu.org>
1219 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1221 2011-11-23 Chong Yidong <cyd@gnu.org>
1223 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1224 using it (Bug#5984).
1226 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1228 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1229 and header-lines, as they don't have one computed for them.
1232 * .gdbinit (prow): Make displayed values more self-explaining.
1233 Add row's hash code.
1235 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1237 * process.c (wait_reading_process_output): Fix asynchrounous
1238 GnuTLS socket handling on some versions of the GnuTLS library.
1239 (wait_reading_process_output): Add comment and URL.
1241 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1243 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1245 2011-11-21 Chong Yidong <cyd@gnu.org>
1247 * window.c (Fnext_window, Fprevious_window): Doc fix.
1249 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1251 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1253 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1255 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1257 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1259 * window.c (Fset_window_combination_limit): Rename argument
1261 (Vwindow_combination_limit): Remove "status" from doc-string.
1263 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1265 * m/ibms390.h: Remove.
1266 * m/ibms390x.h: Don't include "ibms390.h".
1268 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1270 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1271 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1273 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1275 * casetab.c (Fset_case_table):
1276 * charset.c (Fcharset_after): Fix typos.
1278 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1280 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1281 Otherwise, valgrind does not work on some platforms.
1282 Problem reported by Andreas Schwab in
1283 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1284 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1285 is set, removing the need for VIRT_ADDRESS_VARIES.
1286 (PURE_P): Use a more-efficient implementation that needs just one
1287 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1288 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1289 to 4 (xorl, subq, cmpq, setbe).
1290 * alloc.c (pure): Always extern now, since that's the
1291 VIRT_ADDR_VARIES behavior.
1292 (PURE_POINTER_P): Use a single comparison, not two, for
1293 consistency with the new puresize.h.
1294 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1295 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1296 Remove VIRT_ADDR_VARIES no longer needed.
1298 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1300 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1301 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1302 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1303 behave as if the cursor position were at the window margin.
1305 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1306 and the cursor position is out of bounds, behave as if the cursor
1307 position were at the window margin. (Bug#10075)
1309 2011-11-18 Chong Yidong <cyd@gnu.org>
1311 * window.c (Fwindow_combination_limit): Make first argument
1312 non-optional, since it is meaningless for live windows like the
1315 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1317 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1319 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1321 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1322 (graft_intervals_into_buffer): Simplify.
1324 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1326 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1327 hash values of the two rows.
1328 (copy_row_except_pointers): Preserve the used[] arrays and the
1329 hash values of the two rows. (Bug#10035)
1330 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1332 * xdisp.c (row_hash): New function, body extracted from
1333 compute_line_metrics.
1334 (compute_line_metrics): Call row_hash, instead of computing the
1337 * dispnew.c (verify_row_hash): Call row_hash for computing the
1338 hash code of a row, instead of duplicating code from xdisp.c.
1340 * dispextern.h (row_hash): Add prototype.
1342 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1344 * frame.c (delete_frame): Don't delete the terminal when the last
1345 X frame is closed if emacs is built with GTK toolkit.
1347 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1349 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1351 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1353 * window.c (Vwindow_splits): Rename to
1354 Vwindow_combination_resize. Suggested by Juri Linkov.
1355 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1358 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1360 * nsfns.m (Fns_font_name):
1361 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1363 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1365 * window.h (window): Rename slot "nest" to "combination_limit".
1366 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1367 (Fset_window_nest): Rename to Fset_window_combination_limit.
1368 (Vwindow_nest): Rename to Vwindow_combination_limit.
1369 (recombine_windows, make_parent_window, make_window)
1370 (Fsplit_window_internal, saved_window)
1371 (Fset_window_configuration, save_window_save): Rename all
1372 occurrences of window_nest to window_combination_limit.
1374 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1376 * image.c (imagemagick_load_image): Fix typo.
1378 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1380 * xdisp.c (display_line): Move the call to
1381 highlight_trailing_whitespace before the call to
1382 compute_line_metrics, since the latter needs to see the final
1383 faces of all the glyphs to compute ROW's hash value.
1384 Fixes assertion violations in row_equal_p. (Bug#10035)
1386 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1388 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1389 just return (bug#10044).
1391 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1393 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1394 with user-defined heap size. Bump the default size of the temacs
1395 heap to 27MB, to avoid memory warning when running temacs.
1396 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1398 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1399 current_matrix and desired_matrix. (Bug#9990)
1400 (verify_row_hash) [XASSERTS]: New function.
1401 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1402 that the hash value of glyph rows is correct.
1404 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1406 * window.h (window): Remove splits slot.
1407 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1408 (Fdelete_other_windows_internal, make_parent_window)
1409 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1410 (Fset_window_configuration, save_window_save): Don't deal with
1411 split status of windows.
1412 (saved_window): Remove splits slot.
1413 (Vwindow_splits): Rewrite doc-string.
1415 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1417 * xfns.c (unwind_create_frame):
1418 * nsfns.m (unwind_create_frame):
1419 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1420 Vframe_list (Bug#9999).
1422 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1424 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1426 2011-11-11 Kenichi Handa <handa@m17n.org>
1428 * callproc.c (Fcall_process): Set the member dst_multibyte of
1431 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1433 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1434 avoid a crash (bug#9496).
1436 2011-11-09 Chong Yidong <cyd@gnu.org>
1438 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1439 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1441 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1443 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1445 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1447 Avoid some portability problems by eschewing 'extern inline' functions.
1448 The trivial performance wins aren't worth the portability hassles; see
1449 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1451 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1452 (window_box_width, window_box_left, window_box_left_offset)
1453 (window_box_right, window_box_right_offset): Undo previous change,
1454 by removing the "extern"s.
1455 * intervals.c (adjust_intervals_for_insertion)
1456 (adjust_intervals_for_deletion): Undo previous change,
1457 making these static again.
1458 (offset_intervals, temp_set_point_both, temp_set_point)
1459 (copy_intervals_to_string): No longer inline.
1460 * xdisp.c (window_text_bottom_y, window_box_width)
1461 (window_box_height, window_box_left_offset)
1462 (window_box_right_offset, window_box_left, window_box_right)
1463 (window_box): No longer inline.
1465 2011-11-08 Chong Yidong <cyd@gnu.org>
1467 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1468 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1469 Signal an error if not a live window.
1470 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1471 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1473 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1475 * lisp.h (syms_of_abbrev): Remove declaration.
1476 Reported by CHENG Gao <chenggao@royau.me>.
1478 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1480 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1481 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1482 of temacs in GUI mode.
1484 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1486 * window.h: Declare delete_all_child_windows instead of
1487 delete_all_subwindows.
1488 * window.c (Fwindow_nest, Fset_window_nest)
1489 (Fset_window_new_total, Fset_window_new_normal)
1490 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1491 (delete_all_subwindows): Rename to delete_all_child_windows.
1492 (Fdelete_other_windows_internal, Fset_window_configuration):
1493 Call delete_all_child_windows instead of delete_all_subwindows.
1494 * frame.c (delete_frame): Call delete_all_child_windows instead
1495 of delete_all_subwindows.
1497 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1499 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1500 This is also needed for porting to any host where GC_MARK_STACK is
1501 not GC_MAKE_GCPROS_NOOPS.
1502 (which_symbols): Use it.
1504 2011-11-07 Kenichi Handa <handa@m17n.org>
1506 * coding.c (coding_set_destination): Check coding->src_pos only
1507 when coding->src_object is a buffer (bug#9910).
1509 * process.c (send_process): Set the member src_multibyte of coding
1510 to 0 (bug#9911) when sending a unibyte text.
1512 * callproc.c (Fcall_process): Set the member src_multibyte of
1513 process_coding to 0 (bug#9912).
1515 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1517 * xmenu.c (cleanup_widget_value_tree): New function.
1518 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1519 calling free_menubar_widget_value_tree directly (Bug#9830).
1521 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1523 Fix some portability problems with 'inline'.
1524 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1525 (window_box_width, window_box_left, window_box_left_offset)
1526 (window_box_right, window_box_right_offset): Declare extern.
1527 Otherwise, these inline functions do not conform to C99 and
1528 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1529 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1530 * intervals.c (adjust_intervals_for_insertion)
1531 (adjust_intervals_for_deletion): Now extern, because otherwise the
1532 extern inline functions 'offset_intervals' couldn't refer to it.
1533 (static_offset_intervals): Remove.
1534 (offset_intervals): Rewrite using the old contents of
1535 static_offset_intervals. The old version didn't conform to C99
1536 because an extern inline function contained a reference to an
1537 identifier with static linkage.
1539 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1541 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1544 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1546 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1547 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1548 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1549 return Qleft_to_right.
1551 2011-11-06 Chong Yidong <cyd@gnu.org>
1553 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1554 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1555 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1556 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1557 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1558 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1559 (Fwindow_vscroll): Doc fix.
1560 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1561 argument, since it makes no sense to pass a live window and for
1562 consistency with window-child.
1564 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1566 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1569 2011-11-05 Jason Rumney <jasonr@gnu.org>
1571 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1572 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1574 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1575 bitwise arithmetic preventing use of unicode-sip and non-truetype
1578 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1580 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1583 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1584 initialization code to keep similarity to xfns.c after changes
1587 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1589 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1590 (unwind_create_frame): New function (Bug#9943).
1591 (Fx_create_frame): Restructure code to be more similar to the one in
1592 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1593 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1594 Move terminal->reference_count++ just before making the frame official
1597 * nsterm.m (x_free_frame_resources): New function.
1598 (x_destroy_window): Move code to x_free_frame_resources.
1600 * xfns.c (unwind_create_frame): Fix comment.
1601 (Fx_create_frame, x_create_tip_frame):
1602 Move terminal->reference_count++ just before making the frame
1603 official. Move initialization of image_cache_refcount and
1604 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1606 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1608 Support MSVC build with newer versions of Visual Studio.
1609 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1610 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1613 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1614 which are not supported by MSVC.
1615 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1616 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1618 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1620 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1622 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1624 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1626 Support MSVC build with newer versions of Visual Studio.
1627 * w32.c: Don't include w32api.h for MSVC.
1628 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1630 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1631 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1632 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1633 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1635 (alloca) [_MSC_VER]: Define to _alloca.
1637 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1639 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1641 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1643 * xdisp.c (note_mouse_highlight): If either of
1644 previous/next-single-property-change returns nil, treat that as
1645 the beginning or the end of the buffer. (Bug#9955)
1647 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1649 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1650 label is not null (Bug#9951).
1651 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1654 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1656 * window.c (Fwindow_body_size): Mention in the doc string that the
1657 return value is in frame's canonical units. (Bug#9949)
1659 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1661 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1663 * w32fns.c (unwind_create_frame): If needed, free the glyph
1664 matrices of the partially constructed frame. (Bug#9943)
1665 * xfns.c (unwind_create_frame): Likewise.
1667 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1669 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1670 Don't stop backward scan on the continuation glyph, even though
1671 its CHARPOS is positive.
1672 (mouse_face_from_buffer_pos, note_mouse_highlight):
1673 Rename cover_string to disp_string.
1675 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1677 * window.c (temp_output_buffer_show): Don't use
1678 Vtemp_buffer_show_specifiers.
1679 (Vtemp_buffer_show_specifiers): Remove unused variable.
1681 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1683 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1684 past the beginning of the current glyph matrix.
1686 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1688 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1689 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1690 HAVE_GTK3 (Bug#9869).
1692 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1693 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1695 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1697 * xterm.c: Declare x_handle_net_wm_state to return int.
1698 (handle_one_xevent): Check if we are iconified but don't have
1699 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1700 (get_current_wm_state): Return non-zero if not hidden,
1701 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1702 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1703 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1704 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1706 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1708 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1709 so that this new function doesn't get optimized away by a
1710 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1712 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1714 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1716 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1718 Fix the `xbytecode' command.
1719 * .gdbinit (xprintbytestr): New command.
1720 (xwhichsymbols): Rename from `which'; all callers changed.
1721 (xbytecode): Print the byte-code string as well.
1723 2011-10-29 Kim Storm <storm@cua.dk>
1725 * alloc.c (which_symbols): New function.
1727 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1729 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1732 2011-10-29 Glenn Morris <rgm@gnu.org>
1734 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1735 Not clear what it was for, and it causes various bugs. (Bug#9839)
1737 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1739 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1740 possible random value that matches one of those tested as
1741 condition to clear the mouse face.
1743 2011-10-28 Chong Yidong <cyd@gnu.org>
1745 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1747 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1749 * window.c (make_window): Initialize phys_cursor_on_p.
1751 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1753 * lisp.h (struct Lisp_Symbol): Update comments.
1755 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1757 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1759 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1761 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1762 <oslsachem@gmail.com> for helping to debug this.
1764 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1765 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1766 (g_b_init_get_glyph_outline_w): New static variables.
1767 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1768 (GetGlyphOutlineW_Proc): New typedefs.
1769 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1770 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1772 (w32font_open_internal, compute_metrics):
1773 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1774 instead of calling the "wide" APIs directly.
1776 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1778 * w32.h (syms_of_w32font): Add prototype.
1780 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1782 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1783 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1784 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1785 (Fmove_to_window_line): Doc fix.
1787 2011-10-27 Chong Yidong <cyd@gnu.org>
1789 * process.c (make_process): Set gnutls_state to NULL.
1791 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1792 non-NULL, regardless of GNUTLS_INITSTAGE.
1793 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1794 an error. Set process slots as soon as we allocate them.
1796 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1798 2011-10-27 Chong Yidong <cyd@gnu.org>
1800 * gnutls.c (emacs_gnutls_deinit): New function.
1801 Deallocate credentials structures as well as calling gnutls_deinit.
1802 (Fgnutls_deinit, Fgnutls_boot): Use it.
1804 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1805 (deactivate_process): Call emacs_gnutls_deinit.
1807 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1809 * image.c (x_create_x_image_and_pixmap):
1810 * w32.c (sys_rename, w32_delayed_load):
1811 * w32font.c (fill_in_logfont):
1812 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1814 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1816 * w32fns.c (w32_default_color_map): New function,
1817 extracted from Fw32_default_color_map.
1818 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1820 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1822 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1824 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1826 * keyboard.c (test_undefined): New function (bug#9751).
1827 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1829 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1831 * sysdep.c (init_sys_modes): Fix the check for the controlling
1832 terminal (Bug#6649).
1834 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1836 * dispextern.h (struct bidi_it): New member next_en_type.
1838 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1839 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1840 current character, check also for next_en_type being WEAK_EN.
1841 (bidi_resolve_weak): Don't enter the expensive loop if the current
1842 position is before next_en_pos. Record the bidi type of the first
1843 non-ET, non-BN character we find, in addition to its position.
1844 (bidi_level_of_next_char): Invalidate next_en_type when
1845 next_en_pos is over-stepped.
1847 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1849 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1850 * editfns.c: Rewrite current-time-zone so that it invokes
1851 the equivalent of (format-time-string "%Z") to get the time zone name.
1852 This fixes a bug when the time zone name contains characters that
1853 need converting from the system time locale to Emacs internal format.
1854 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1855 that patch fixed format-time-string to do the conversion, but
1856 I forgot to fix current-time-zone.
1857 (format_time_string): New function, containing most of
1858 what Fformat_time_string used to contain.
1859 (Fformat_time_string): Rewrite in terms of format_time_string.
1860 This doesn't change this function's behavior.
1861 (current-time-zone): Rewrite to use format_time_string.
1862 This fixes the bug reported by Michael Schierl in
1863 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1864 Jason Rumney's 2007-06-07 change worked around this bug, but
1866 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1868 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1870 * xdisp.c (start_display): If the character at POS is displayed
1871 via a display vector, reset IT->current.dpvec_index to zero.
1872 (try_window_reusing_current_matrix): If a line ends in a display
1873 vector or the next line starts in a display vector, continue
1874 redrawing the window even though the character position of
1875 start_row was reached.
1878 2011-10-18 Chong Yidong <cyd@gnu.org>
1880 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1881 with nobreak-char-display too.
1883 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1885 Fix part 3 of bug#9771.
1886 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1887 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1888 non-neutral characters if the current character is a paragraph
1889 separator (a.k.a. Newline). This avoids running the same
1890 expensive loop twice, once when we consume the preceding newline
1891 and the other time when the line actually needs to be displayed.
1892 Avoid the loop when we see neutrals on the base embedding level
1893 following a character whose directionality is the same as the
1894 paragraph's. This avoids running the expensive loop when a line
1895 ends in a long sequence of neutrals, like control characters.
1896 Add assertion against STRONG_AL type. Slightly rearrange code
1897 that determines the type of a neutral given the first non-neutral
1899 (bidi_level_of_next_char): Set next_en_pos to zero when
1900 invalidating its info.
1902 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1904 * xdisp.c (push_display_prop): Determine whether to record string
1905 or buffer position by IT->string, not by IT->method. Allow
1906 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1907 (move_it_vertically_backward): Don't look for character position
1908 immediately after the newline when in a continuation line.
1911 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1913 * window.c (coordinates_in_window): Rewrite and delabelize
1914 vertical border check. (Bug#5357) (Bug#9618)
1916 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1918 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1919 errors in XSetWindowBorder (bug#9310).
1921 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1923 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1924 avoid crash when xmalloc overrun checking is enabled.
1926 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1928 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1929 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1930 cursor motion with <left> and <right> arrow keys.
1932 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1933 some callers set that themselves.
1935 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1937 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1938 display string and the previous row comes from the same string and
1939 is empty. (Bug#9739) (Bug#9738)
1941 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1943 * doc.c (get_doc_string): Encode file name (bug#9735).
1945 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1947 * bidi.c (bidi_level_of_next_char):
1948 * xdisp.c (get_visually_first_element): Remove old incorrect
1949 comments regarding the Unicode Line Separator character.
1951 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1953 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1955 * alloc.c (Fgc_status): Do not access beyond zombies array
1956 boundary if nzombies > MAX_ZOMBIES.
1957 * alloc.c (dump_zombies): Add missing format specifier.
1959 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1961 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1962 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1964 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1965 Some packages use them to denote characters with modifiers.
1967 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1969 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1970 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1971 matching a pp-number. Rename parameter var to var1.
1973 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1975 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1977 2011-10-08 Glenn Morris <rgm@gnu.org>
1979 * callint.c (Fcall_interactively): Give a more explicit error for the
1980 'c' case with a non-character input. (Bug#8479)
1982 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1984 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1986 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1987 lines that are hscrolled on the left.
1989 * dispnew.c (buffer_posn_from_coords): Account for a possible
1990 presence of header-line. (Bug#4426)
1992 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1994 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1995 Don't advertise functionality which we discourage or doesn't work.
1997 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1999 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2000 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2001 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2002 this makes Emacs dump core during garbage collection on rare
2003 occasions. sizeof is obviously inferior to offsetof here, so
2004 stick with offsetof.
2005 (GC_POINTER_ALIGNMENT): New macro.
2006 (mark_memory): Omit 3rd (offset) arg; caller changed.
2007 Don't assume EMACS_INT alignment is the same as pointer alignment.
2009 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2011 * keyboard.c (read_key_sequence_remapped): New var.
2012 (read_key_sequence): Compute remapping in the right buffer.
2013 (command_loop_1): Use read_key_sequence's remapping directly.
2015 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2017 * dired.c (file_name_completion): Don't expand file name.
2018 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2019 before checking file name handler.
2021 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2022 they've been requested explicitly (bug#9591).
2024 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
2026 * keymap.c (Fsingle_key_description): Use make_specified_string
2027 instead of build_string to build string from push_key_description.
2030 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2032 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2033 This fixes a Y2038 bug on 64-bit hosts.
2034 * buffer.c (reset_buffer):
2035 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2036 (Fclear_buffer_auto_save_failure):
2037 Use 0, not -1, to represent an unset failure time, since time_t
2038 might not be signed.
2040 Remove dependency on glibc malloc internals.
2041 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2042 Move back here from lisp.h, but with their new implementations.
2043 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2044 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2045 * charset.c (charset_table_init): New static var.
2046 (syms_of_charset): Use it instead of xmalloc. This removes a
2047 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2048 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2049 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2050 Move back to alloc.c.
2051 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2052 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2054 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2056 * nsterm.m (windowDidResize): Call x_set_window_size only when
2057 ns_in_resize is true. Otherwise set pixelwidth/height and
2058 call change_frame_size (Bug#9628).
2060 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2062 Port --enable-checking=all to Fedora 14 x86-64.
2063 * charset.c (syms_of_charset): Also account for glibc malloc's
2064 internal overhead when calculating the initial malloc maximum.
2066 Port --enable-checking=all to Fedora 14 x86.
2067 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2069 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2070 (overrun_check_realloc, overrun_check_free):
2071 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2072 That way, xmalloc returns a properly-aligned pointer even if
2073 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2074 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2075 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2076 into account when calculating the initial malloc maximum.
2077 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2078 Move here from alloc.c, so that charset.c can use it too.
2079 Properly align; the old code wasn't right for common 32-bit hosts
2080 when configured with --enable-checking=all.
2081 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2082 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2084 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2086 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2089 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2091 * xdisp.c (compute_display_string_end): If there's no display
2092 string at CHARPOS, return -1.
2094 * bidi.c (bidi_fetch_char): When compute_display_string_end
2095 returns a negative value, treat the character as a normal
2096 character not covered by a display string. (Bug#9624)
2098 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2100 * lread.c (Fread_from_string): Fix typo in docstring.
2102 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2104 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2105 newline, reseat the iterator instead of bidi-iterating there one
2106 character at a time. (Bug#9610)
2107 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2108 TO_CHARPOS if the bidi iterator is at base embedding level.
2110 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2112 * lread.c (readevalloop): Use correct code for NBSP.
2113 (read1): Likewise. (Bug#9608)
2115 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2117 * dbusbind.c (Fdbus_register_signal): When service is not
2118 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2120 2011-09-25 Glenn Morris <rgm@gnu.org>
2122 * buffer.c (truncate-lines): Doc fix.
2124 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2126 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2127 (Fset_window_next_buffers): Doc fix.
2129 2011-09-24 Glenn Morris <rgm@gnu.org>
2131 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2133 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2135 Fix minor problems found by static checking.
2136 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2137 * indent.c (Fvertical_motion): Fix == vs = typo.
2139 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2141 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2142 Default value is now t. Doc fix.
2144 * indent.c (Fvertical_motion): Compute and apply the overshoot
2145 logic when moving up, not only when moving down. Fix the
2146 confusing name and values of the it_overshoot_expected variable;
2147 logic changes accordingly. (Bug#9254) (Bug#9549)
2149 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2150 CHARPOS is covered by a display string which includes newlines.
2151 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2152 is covered by a display string with embedded newlines.
2154 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2156 * dbusbind.c (Fdbus_register_signal): Add match rule to
2157 Vdbus_registered_objects_table. (Bug#9581)
2158 (Fdbus_register_method, Vdbus_registered_objects_table):
2161 2011-09-24 Jim Meyering <meyering@redhat.com>
2163 do not ignore write error for any output size
2164 The previous change was incomplete.
2165 While it makes emacs --batch detect the vast majority of stdout
2166 write failures, errors were still ignored whenever the output size is
2167 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2168 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2169 && echo FAIL: ignored write error
2170 FAIL: ignored write error
2171 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2172 && echo FAIL: ignored write error
2173 FAIL: ignored write error
2174 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2176 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2178 * emacs.c (Fkill_emacs): In noninteractive mode exit
2179 non-successfully if a write error occurred on stdout. (Bug#9574)
2181 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2183 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2186 * dispextern.h (struct it): Update the comment documenting what
2189 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2191 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2192 a display string, extend search for cursor position to end of row.
2193 (find_row_edges): If the row ends in a newline from a display
2194 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2195 Handle the case of a display string with multiple newlines.
2196 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2197 non-empty line. Fixes confusing cursor motion with arrow keys at
2198 the beginning of a line that starts with whitespace.
2200 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2202 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2205 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2207 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2210 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2212 * xdisp.c (display_line): Record maximum and minimum buffer
2213 positions even if no glyphs were produced (e.g., by a zero-width
2214 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2215 buffer positions that will be removed from the glyph row because
2217 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2218 column is beyond frame width: don't subtract 1 "pixel" when
2219 computing width of the stretch.
2220 (reseat_at_next_visible_line_start): Undo the change made on
2221 2011-09-17 that saved paragraph information and restored it after
2222 the call to `reseat'. (Bug#9545)
2224 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2226 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2227 and turn window cursor on if cleared (Bug#9415).
2229 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2231 * search.c (boyer_moore): Take unibyte characters from pattern
2232 literally. (Bug#9458)
2234 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2236 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2238 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2240 Fix minor problem found by static checking.
2241 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2242 initialized, to pacify gcc -Wuninitialized.
2244 * fileio.c: Report proper errno when syscall falls.
2245 (Finsert_file_contents): Save and restore errno,
2246 so that report_file_error outputs the correct diagnostic.
2247 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2249 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2251 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2253 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2255 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2256 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2258 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2260 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2261 about the current paragraph and restore it after the call to reseat.
2263 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2264 (bidi_find_paragraph_start): Search back for paragraph beginning
2265 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2266 (bidi_move_to_visually_next): Only trigger paragraph-related
2267 computations when the last character is a newline or at EOB, not
2268 just any NEUTRAL_B. (Bug#9470)
2270 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2271 truncated lines if point is covered by a display string. (Bug#9524)
2273 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2275 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2276 (cons_to_x_long): New function.
2277 (lisp_data_to_selection_data): Use it. Correct the test for
2278 short-versus-long data; it was negated. Break out of vector
2279 loop, for efficiency, when a long datum is discovered.
2281 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2283 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2285 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2287 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2288 GCC PR/17406) by declaring this function with external scope.
2290 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2292 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2293 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2295 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2297 * editfns.c (Fformat): Correctly handle text properties on "%%".
2299 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2301 * xterm.c (x_draw_composite_glyph_string_foreground):
2302 * w32term.c (x_draw_composite_glyph_string_foreground):
2303 * term.c (encode_terminal_code):
2304 * composite.c (composition_update_it, get_composition_id):
2305 * xdisp.c (get_next_display_element)
2306 (fill_composite_glyph_string): Add comments about special meaning
2307 of TAB characters in a composition.
2309 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2311 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2312 This occurs when processing a multibyte format.
2313 Problem reported by Wolfgang Jenker.
2315 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2317 * xdisp.c (try_cursor_movement): Only check for exact match if
2318 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2320 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2322 Remove unused external symbols.
2323 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2324 * xdisp.c (calc_pixel_width_or_height): Now static.
2325 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2326 * indent.c (check_display_width):
2327 * w32term.c: Fix comment to match code.
2328 * xterm.c, xterm.h (x_catching_errors): Remove.
2330 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2332 * xselect.c: Use signed conversions more consistently (Bug#9498).
2333 (selection_data_to_lisp_data): Assume incoming selection data are
2334 signed integers, not unsigned. This is to be consistent with
2335 outgoing selection data, which was modified to use signed integers
2336 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2337 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2338 expects long, not unsigned long.
2340 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2342 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2343 computation of loop end. Reported by Johan Bockgård
2346 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2348 * frame.c (Fother_visible_frames_p): Function deleted.
2350 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2352 * indent.c (compute_motion): Process display vector front to back
2353 rather than the other way around. (Bug#2496)
2355 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2357 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2359 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2361 * minibuf.c (Fread_from_minibuffer): Doc fix.
2363 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2365 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2366 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2368 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2370 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2371 value for non-existent files.
2373 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2375 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2376 set its "size" to -1. This will set the modtime_size field of
2377 the corresponding buffer to -1, which is what
2378 verify-visited-file-modtime expects for files that do not exist.
2381 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2383 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2385 * lisp.h: ... from here. push_key_description is no longer
2386 defined in keyboard.c, so its declaration should not be in
2387 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2388 logically belongs with push_key_description.
2390 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2392 * buffer.h: Include <sys/types.h> instead of <time.h>.
2393 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2394 Problem reported by Herbert J. Skuhra.
2396 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2398 * xml.c (parse_region): Make the parsing work for
2399 non-comment-starting XML files again (bug#9144).
2401 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2403 * image.c (gif_load): Fix calculation of bottom and right corner.
2406 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2408 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2409 redisplay in small windows.
2411 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2413 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2415 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2417 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2418 Operate on live windows only.
2420 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2422 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2424 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2426 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2427 only under bidi iteration.
2429 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2431 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2433 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2435 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2436 Without this fix, the command to link temacs failed due to an
2437 undefined symbol __builtin_isnan. This is because
2438 /usr/include/iso/math_c99.h #defines isnan(x) to
2439 __builtin_isnan(x), but the bundled gcc, which identifies itself
2440 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2442 * floatfns.c (isnan): #undef, and then #define to a clone of
2444 (Fisnan): Always define, since it's always available now.
2445 (syms_of_floatfns): Always define isnan at the Lisp level.
2447 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2449 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2451 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2453 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2454 The previous code assumed that file offsets (off_t values) fit in
2455 EMACS_INT variables, which is not true on typical 32-bit hosts.
2456 The code messed up by falsely reporting buffer overflow in cases
2457 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2458 when "big" contains more than 2**29 bytes, even though this
2459 inserts just one byte and does not overflow the buffer.
2460 (Finsert_file_contents): Store file offsets as off_t
2461 values, not as EMACS_INT values. Check for overflow when
2462 converting between EMACS_INT and off_t. When checking for
2463 buffer overflow or for overlap, take the offsets into account.
2464 Don't use EMACS_INT for small values where int suffices.
2465 When checking for overlap, fix a typo: ZV was used where
2466 ZV_BYTE was intended.
2467 (Fwrite_region): Don't assume off_t fits into 'long'.
2468 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2470 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2472 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2474 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2476 sprintf-related integer and memory overflow issues (Bug#9412).
2478 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2479 (esprintf, exprintf, evxprintf): New functions.
2480 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2481 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2482 (modify_event_symbol): Do not assume that the length of
2483 name_alist_or_stem is safe to alloca and fits in int.
2484 (Fexecute_extended_command): Likewise for function name and binding.
2485 (Frecursion_depth): Wrap around reliably on integer overflow.
2486 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2487 since some callers pass EMACS_INT values.
2488 (Fsingle_key_description): Don't crash if symbol name contains more
2489 than MAX_ALLOCA bytes.
2490 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2491 (get_minibuffer): Arg is now EMACS_INT, not int.
2492 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2493 (esprintf, exprintf, evxprintf): New decls.
2494 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2496 * dbusbind.c (signature_cat): New function.
2497 (xd_signature, Fdbus_register_signal):
2498 Do not overrun buffer; instead, report string overflow.
2500 * dispnew.c (add_window_display_history): Don't overrun buffer.
2501 Truncate instead; this is OK since it's just a log.
2503 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2504 even if the time zone offset is outlandishly large.
2505 Don't mishandle offset == INT_MIN.
2507 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2508 when creating daemon; the previous buffer-overflow check was incorrect.
2510 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2511 which has the guts of the old verror function.
2513 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2514 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2516 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2517 (font_unparse_xlfd): Don't blindly alloca long strings.
2518 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2519 fits in int, when using sprintf. Use single snprintf to count
2520 length of string rather than counting it via multiple sprintfs;
2521 that's simpler and more reliable.
2522 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2523 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2524 sprintf, in case result does not fit in int.
2526 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2527 (fontset_from_font): Print it.
2529 * frame.c (tty_frame_count): Now printmax_t, not int.
2530 (make_terminal_frame, set_term_frame_name): Print it.
2531 (x_report_frame_params): In X, window IDs are unsigned long,
2532 not signed long, so print them as unsigned.
2533 (validate_x_resource_name): Check for implausibly long names,
2534 and don't assume name length fits in 'int'.
2535 (x_get_resource_string): Don't blindly alloca invocation name;
2536 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2539 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2540 (xg_check_special_colors, xg_set_geometry):
2541 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2543 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2544 Use esprintf, not sprintf, in case result does not fit in int.
2546 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2547 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2548 it as a large positive number.
2549 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2550 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2552 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2553 in case result does not fit in int.
2555 * print.c (float_to_string): Detect width overflow more reliably.
2556 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2557 buffer overrun. Don't assume list length fits in 'int'. Treat
2558 print length of 0 as 0, not as infinity; to be consistent with other
2559 uses of print length in this function. Don't overflow print length
2560 index. Don't assume hash table size fits in 'long', or that
2561 vectorlike size fits in 'unsigned long'.
2563 * process.c (make_process): Use printmax_t, not int, to format
2564 process-name gensyms.
2566 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2568 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2569 to avoid potential buffer overrun.
2571 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2572 if X resource line is longer than 512 bytes.
2574 * xfns.c (x_window): Make sprintf buffer a bit bigger
2575 to avoid potential buffer overrun.
2577 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2579 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2581 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2583 Integer overflow fixes for scrolling, etc.
2584 Without these, Emacs silently mishandles large integers sometimes.
2585 For example, "C-u 4294967297 M-x recenter" was treated as if
2586 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2588 * xdisp.c (try_window_id): Check Emacs fixnum range before
2589 converting to 'int'.
2591 * window.c (window_scroll_line_based, Frecenter):
2592 Check that an Emacs fixnum is in range before assigning it to 'int'.
2593 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2594 values converted from Emacs fixnums.
2595 (Frecenter): Don't wrap around a line count if it is out of 'int'
2596 range; instead, treat it as an extreme value.
2597 (Fset_window_configuration, compare_window_configurations):
2598 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2600 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2601 that can exceed INT_MAX. Check that EMACS_INT value is in range
2602 before assigning it to the (possibly-narrower) index.
2603 (match_limit): Don't assume that a fixnum can fit in 'int'.
2605 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2608 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2609 (Fvertical_motion): Don't wrap around LINES values that don't fit
2610 in 'int'. Instead, treat them as extreme values. This is good
2611 enough for windows, which can't have more than INT_MAX lines anyway.
2613 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2615 * Require libxml/parser.h to avoid compilation warning.
2617 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2619 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2620 since this reportedly can destroy thread storage.
2622 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2624 * syntax.c (find_defun_start): Update all cache variables if
2625 exiting early (Bug#9401).
2627 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2629 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2631 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2632 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2633 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2635 * term.c (tty_append_glyph): New function.
2636 (produce_stretch_glyph): Static function and its prototype deleted.
2638 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2641 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2643 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2644 when checking :margin (Bug#9390).
2645 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2646 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2647 so that the name doesn't mislead. All uses changed.
2649 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2651 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2654 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2656 * xdisp.c (move_it_to): Don't bail out early when reaching
2657 position beyond to_charpos, if we are scanning backwards.
2658 (move_it_vertically_backward): When DY == 0, make sure we get to
2659 the first character in the line after the newline.
2661 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2663 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2664 (ccl_driver): Do not generate an out-of-range pointer.
2665 (Fccl_execute_on_string): Remove unnecessary check for
2666 integer overflow, noted by Stefan Monnier in
2667 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2668 Remove a FIXME that didn't need fixing.
2669 Simplify the newly-introduced buffer reallocation code.
2671 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2673 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2675 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2677 Integer and memory overflow issues (Bug#9196).
2679 * doc.c (get_doc_string): Rework so that
2680 get_doc_string_buffer_size is the actual buffer size, rather than
2681 being 1 less than the actual buffer size; this makes xpalloc more
2684 * image.c (x_allocate_bitmap_record, cache_image):
2685 * xselect.c (Fx_register_dnd_atom):
2686 Simplify previous changes by using xpalloc.
2688 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2689 since either will do and ptrdiff_t is convenient with xpalloc.
2691 * charset.c (charset_table_size)
2692 (struct charset_sort_data.priority): Now ptrdiff_t.
2693 (charset_compare): Don't overflow if priorities differ greatly.
2694 (Fsort_charsets): Don't assume list length fits in int.
2695 Check for size-calculation overflow when allocating sort data.
2696 (syms_of_charset): Allocate an initial charset table that is
2697 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2699 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2701 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2702 The actual value is always <= INT_MAX, and leaving it unsigned made
2703 overflow checking harder.
2705 * dispextern.h (struct glyph_matrix.rows_allocated)
2706 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2707 with xpalloc. The values are still always <= INT_MAX.
2709 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2711 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2712 (SAFE_NALLOCA): New macro.
2714 * region-cache.c (struct boundary.pos, find_cache_boundary)
2715 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2716 (set_cache_region, invalidate_region_cache)
2717 (revalidate_region_cache, know_region_cache, region_cache_forward)
2718 (region_cache_backward, pp_cache):
2719 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2720 so that ptrdiff_t * can be passed to xpalloc.
2721 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2722 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2723 (pp_cache): Don't assume cache_len fits in int.
2724 * region-cache.h: Adjust extern decls to match.
2726 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2727 EMACS_INT, since either will do, for xpalloc.
2729 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2730 (xnmalloc, xnrealloc, xpalloc): New functions.
2732 * bidi.c (bidi_shelve_header_size): New constant.
2733 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2734 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2736 * bidi.c (bidi_cache_shrink):
2737 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2739 Don't update size of array until after memory allocation succeeds,
2740 because xmalloc/xrealloc may not return.
2741 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2742 now that we have proper integer overflow checking.
2743 (record_overlay_string, overlay_strings): Catch overflows when
2744 calculating size of overlay_str_buf.
2746 * callproc.c (Fcall_process): Check for size overflow when
2747 calculating size of args2.
2748 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2749 Normally we prefer signed values, but sticking with ptrdiff_t would
2750 require adding more-complicated checks.
2752 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2753 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2754 Redo buffer-overflow calculations to avoid integer overflow.
2755 Add a FIXME comment where memory seems to be over-allocated.
2757 * character.c (Fstring): Check for size-calculation overflow.
2759 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2760 unnecessary integer overflow. Check for size overflow.
2761 (encode_coding_object): Don't update size until xmalloc succeeds.
2763 * composite.c (get_composition_id): Check for overflow in glyph
2764 length calculations.
2766 Integer and memory overflow fixes for display code.
2767 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2768 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2769 (scrolling_window): Check for overflow in size calculations.
2770 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2771 Don't assume glyph table len fits in int.
2772 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2773 (row_table_size): Now ptrdiff_t, not int.
2774 (scrolling_window): Avoid overflow in size calculations.
2775 Don't update size until allocation succeeds.
2776 * fns.c (concat): Check for overflow in size calculations.
2777 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2778 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2779 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2781 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2782 (get_doc_string): Check for size calculation overflow.
2783 Don't update size until allocation succeeds.
2784 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2785 EMACS_INT, where ptrdiff_t will do.
2786 (Fsubstitute_command_keys): Check for string overflow.
2788 * editfns.c (set_time_zone_rule): Don't assume environment length
2790 (message_length): Now ptrdiff_t, not int.
2791 (Fmessage_box): Don't update size until allocation succeeds.
2792 Don't assume message length fits in int.
2793 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2795 * emacs.c (main): Do not reallocate argv, since there is a null at
2796 the end that can be overwritten, and this way there's no need to
2797 worry about size-calculation overflow.
2798 (sort_args): Check for size-calculation overflow.
2800 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2802 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2804 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2805 (x_set_scroll_bar_width, x_figure_window_size):
2806 Check for integer overflow.
2807 (x_set_alpha): Do not assume XINT fits in int.
2809 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2810 This is for the members text_lines, text_cols, total_lines, total_cols,
2811 where the system imposes an 'int' limit.
2813 * fringe.c (Fdefine_fringe_bitmap):
2814 Don't update size until alloc works.
2816 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2817 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2819 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2820 Check for size-calculation overflow.
2821 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2822 do, as we prefer signed integers.
2823 (id_to_widget.max_size, id_to_widget.used)
2824 (xg_store_widget_in_map, xg_remove_widget_from_map)
2825 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2826 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2827 Use and return ptrdiff_t, not int.
2828 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2829 * gtkutil.h: Change prototypes to match the above.
2831 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2832 are duplicate now that they've been promoted to lisp.h.
2833 (x_allocate_bitmap_record, x_alloc_image_color)
2834 (make_image_cache, cache_image, xpm_load):
2835 Don't update size until alloc is done.
2836 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2838 Check for size calculation overflow.
2839 (ct_colors_allocated_max): New constant.
2840 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2843 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2844 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2845 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2846 Use ptrdiff_t, not int, to count maps.
2847 (read_char_minibuf_menu_prompt): Check for overflow in size
2848 calculations. Don't update size until allocation succeeds.
2849 Redo calculations to avoid overflow.
2850 * keyboard.h: Change prototypes to match the above.
2852 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2854 (current_minor_maps): Check for size calculation overflow.
2855 * keymap.h: Change prototypes to match the above.
2857 * lread.c (read1, init_obarray): Don't update size until alloc done.
2859 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2860 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2862 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2863 Now ptrdiff_t, not int.
2864 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2865 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2867 * process.c (Fnetwork_interface_list): Check for overflow
2868 in size calculation.
2870 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2872 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2873 overflow. Don't bother calling xmalloc when xrealloc will do.
2875 * search.c (Freplace_match): Check for size calculation overflow.
2876 (Fset_match_data): Don't assume list lengths fit in 'int'.
2878 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2879 for command line length. Do not attempt to address one before the
2880 beginning of an array, as that's not portable.
2882 * term.c (max_frame_lines): Remove; unused.
2883 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2885 (encode_terminal_code, calculate_costs): Check for size
2886 calculation overflow.
2887 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2888 table lengths and related sizes. Don't update size until alloc
2889 done. Redo calculations to avoid overflow.
2890 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2892 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2893 subtracting pointers.
2894 (gobble_line): Check for overflow more carefully. Don't update size
2897 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2898 Don't update size until alloc done.
2899 Redo size calculations to avoid overflow.
2900 Check for size calculation overflow.
2901 (main) [DEBUG]: Fix typo in invoking tparam1.
2903 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2904 Use ptrdiff_t, not int, for sizes.
2905 (store_mode_line_noprop_char): Don't update size until alloc done.
2907 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2908 Use ptrdiff_t, not int, for sizes.
2909 (Finternal_make_lisp_face, cache_face):
2910 Check for size calculation overflow.
2911 (cache_face): Treat size calculation overflows as if they were
2912 memory exhaustion (the usual treatment), rather than aborting.
2914 * xfns.c (x_encode_text, x_set_name_internal)
2915 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2916 sizes, since they can exceed INT_MAX in size. Check for size
2917 calculation overflow.
2919 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2920 (xg_select): Check for size calculation overflow.
2921 Don't update size until alloc done.
2923 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2924 as sprintf is limited to int lengths.
2926 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2927 (X_LONG_MIN): New macros.
2928 Use them to make the following changes clearer.
2929 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2930 This change doesn't affect the value now, but it may help remind
2931 future maintainers not to raise the value too much later.
2932 (SELECTION_QUANTUM): Remove, replacing with ...
2933 (selection_quantum): ... new function, which avoids overflow.
2935 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2936 assumption that selection length fits in 'int'.
2937 (x_reply_selection_request, x_handle_selection_request)
2938 (x_get_window_property, receive_incremental_selection)
2939 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2940 (lisp_data_to_selection_data, clean_local_selection_data):
2941 Use ptrdiff_t, not int, to record length of selection.
2942 (x_reply_selection_request, x_get_window_property)
2943 (receive_incremental_selection, x_property_data_to_lisp):
2944 Redo calculations to avoid overflow.
2945 (x_reply_selection_request): When sending hint, ceiling it at
2946 X_LONG_MAX rather than relying on wraparound overflow to send
2948 (x_get_window_property, receive_incremental_selection)
2949 (lisp_data_to_selection_data, x_property_data_to_lisp):
2950 Check for size-calculation overflow.
2951 (x_get_window_property, receive_incremental_selection)
2952 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2953 Don't store size until memory allocation succeeds.
2954 (x_get_window_property): Plug memory leak on memory exhaustion.
2955 Don't double-block input; malloc is safe here. Don't assume 2**34
2956 - 4 fits in unsigned long. Add an xassert to check
2957 XGetWindowProperty overflow. Be more careful about overflow
2958 calculations, and distinguish size from memory overflow better.
2959 (receive_incremental_selection): When tracing, don't assume
2960 unsigned int is less than INT_MAX.
2961 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2962 harmful) conversions of unsigned short to int.
2963 (lisp_data_to_selection_data): Don't assume that integers
2964 in the range -65535 through -1 fit in an X unsigned short.
2965 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2966 result parameters unless successful. Rely on cons_to_unsigned
2967 to report problems with elements; the old code wasn't right anyway.
2968 (x_check_property_data): Check for int overflow; we cannot use
2969 a wider type due to X limits.
2970 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2972 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2974 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2975 (x_term_init): Check for size calculation overflow.
2976 (x_color_cells): Don't store size until memory allocation succeeds.
2977 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2978 Don't assume alloca size is less than MAX_ALLOCA.
2979 (x_term_init): Don't assume length fits in int (sprintf is limited
2982 Use ptrdiff_t for composition IDs.
2983 * character.c (lisp_string_width):
2984 * composite.c (composition_table_size, n_compositions)
2985 (get_composition_id, composition_gstring_from_id):
2986 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2987 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2988 * window.c (Frecenter):
2989 Use ptrdiff_t, not int, for composition IDs.
2990 * composite.c (get_composition_id): Check for integer overflow.
2991 * composite.h: Adjust prototypes to match the above changes.
2993 Use ptrdiff_t for hash table indexes.
2994 * category.c (hash_get_category_set):
2995 * ccl.c (ccl_driver):
2996 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2997 * coding.c (coding_system_charset_list, detect_coding_system):
2998 * coding.h (struct coding_system.id):
2999 * composite.c (get_composition_id, gstring_lookup_cache):
3000 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3001 * image.c (xpm_get_color_table_h):
3002 * lisp.h (hash_lookup, hash_put):
3003 * minibuf.c (Ftest_completion):
3004 Use ptrdiff_t for hash table indexes, not int (which is too
3005 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3006 32-bit --with-wide-int hosts).
3008 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3009 Add a FIXME comment about memory leaks.
3010 (syms_of_charset): Don't assume xmalloc returns.
3012 Don't assume that stated character widths fit in int.
3013 * character.c (Fchar_width, c_string_width, lisp_string_width):
3014 * character.h (CHAR_WIDTH):
3015 * indent.c (MULTIBYTE_BYTES_WIDTH):
3016 Use sanitize_char_width to avoid undefined and/or bad behavior
3017 with outlandish widths.
3018 * character.h (sanitize_tab_width): Rename from sanitize_width,
3019 now that we have two such functions. All uses changed.
3020 (sanitize_char_width): New inline function.
3022 Don't assume that tab-width fits in int.
3023 * character.h (sanitize_width): New inline function.
3024 (SANE_TAB_WIDTH): New macro.
3025 (ASCII_CHAR_WIDTH): Use it.
3026 * indent.c (sane_tab_width): Remove. All uses replaced by
3027 SANE_TAB_WIDTH (current_buffer).
3028 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3030 * fileio.c: Integer overflow issues with file modes.
3031 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3033 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3034 Remove unreachable code.
3035 (read_hex, load_charset_map_from_file): Check for integer overflow.
3037 * xterm.c: Don't go over XClientMessageEvent limit.
3038 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3039 (x_send_scroll_bar_event): Likewise. Check that the size does not
3040 exceed limits imposed by XClientMessageEvent, as well as the usual
3041 ptrdiff_t and size_t limits.
3043 * keyboard.c: Overflow, signedness and related fixes.
3044 (make_lispy_movement): Use same integer type in forward decl
3045 that is used in the definition.
3046 (read_key_sequence, keyremap_step):
3047 Change bufsize argument back to int, undoing my 2011-03-30 change.
3048 We prefer signed types, and int is wide enough here.
3049 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3050 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3051 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3052 length, not size_t. Use ptrdiff_t for index, not int.
3053 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3054 possibility of integer overflow.
3056 Overflow, signedness and related fixes for images.
3058 * dispextern.h (struct it.stack[0].u.image.image_id)
3059 (struct_it.image_id, struct image.id, struct image_cache.size)
3060 (struct image_cache.used, struct image_cache.ref_count):
3061 * gtkutil.c (update_frame_tool_bar):
3062 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3063 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3064 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3065 * nsmenu.m (update_frame_tool_bar):
3066 * xdisp.c (calc_pixel_width_or_height):
3067 * xfns.c (image_cache_refcount):
3068 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3069 on typical 64-bit hosts.
3071 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3072 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3073 Omit unnecessary casts to int.
3074 (parse_image_spec): Check that integers fall into 'int' range
3075 when the callers expect that.
3076 (image_ascent): Redo ascent calculation to avoid int overflow.
3077 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3078 (lookup_image): Remove unnecessary tests.
3079 (xbm_image_p): Locals are now of int, not EMACS_INT,
3080 since parse_image_check makes sure they fit into int.
3081 (png_load, gif_load, svg_load_image):
3082 Prefer int to unsigned where either will do.
3083 (tiff_handler): New function, combining the cores of the
3084 old tiff_error_handler and tiff_warning_handler.
3085 This function is rewritten to use vsnprintf and thereby avoid
3086 stack buffer overflows. It uses only the features of vsnprintf
3087 that are common to both POSIX and native Microsoft.
3088 (tiff_error_handler, tiff_warning_handler): Use it.
3089 (tiff_load, gif_load, imagemagick_load_image):
3090 Don't assume :index value fits in 'int'.
3091 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3092 (imagemagick_load_image): Check that crop parameters fit into
3093 the integer types that MagickCropImage accepts. Don't assume
3094 Vimagemagick_render_type has a nonnegative value. Don't assume
3095 size_t fits in 'long'.
3096 (gs_load): Use printmax_t to print the widest integers possible.
3097 Check for integer overflow when computing image height and width.
3099 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3101 * xdisp.c (redisplay_window): Don't force window start if point
3102 will be invisible in the resulting window. (Bug#9324)
3104 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3106 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3107 the display spec is of the form `(space ...)'.
3108 (handle_display_spec): Return the value returned by
3109 handle_single_display_spec, not just 1 or zero.
3110 (handle_single_display_spec): If the display spec is of the form
3111 `(space ...)', and specifies display in the text area, return 2
3113 (try_cursor_movement): Check for the need to scroll more
3114 accurately, and prefer exact match for point under bidi.
3115 Don't advance `row' beyond the last row of the window.
3117 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3118 into disp_prop; all users changed.
3120 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3121 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3122 for the text covered by the display property.
3124 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3126 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3127 Change return value to nil.
3128 (Frecord_buffer): Delete unused function.
3130 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3132 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3133 buffers, return left-to-right.
3134 (set_cursor_from_row): Consider candidate row a win if its glyph
3135 represents a newline and point is on that newline. Fixes cursor
3136 positioning on the newline at EOL of R2L text within L2R
3137 paragraph, and vice versa.
3138 (try_cursor_movement): Check continued rows, in addition to
3139 continuation rows. Fixes unwarranted scroll when point enters a
3140 continued line of R2L text within an L2R paragraph, or vice versa.
3141 (cursor_row_p): Consider the case of point being equal to
3142 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3143 from the end of a short line to the beginning of a continued line
3144 of R2L text within L2R paragraph.
3145 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3146 composed characters.
3148 * bidi.c (bidi_check_type): Use xassert.
3149 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3152 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3154 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3157 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3159 * nsfont.m (ns_otf_to_script): Fix typo.
3161 2011-08-22 Kenichi Handa <handa@m17n.org>
3163 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3164 extra slot even if the purpose is char-code-property-table.
3166 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3168 * xdisp.c (redisplay_window): When computing centering_position,
3169 account for the height of the header line. (Bug#8874)
3171 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3172 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3173 candidate is selected by the mouse, and that candidate has a
3174 composed character under the mouse.
3176 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3177 coordinates reported by pos-visible-in-window-p for a composed
3178 character in column zero.
3180 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3182 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3184 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3186 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3187 consider it a hit if to_charpos is anywhere in the range of the
3188 composed buffer positions.
3190 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3192 * image.c (gif_load): Don't assume that each subimage has the same
3193 dimensions as the base image. Handle disposal method that is
3194 "undefined" by the gif spec (Bug#9335).
3196 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3198 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3199 (Fcondition_case): Document `debug' symbol in error handler.
3201 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3203 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3204 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3205 from an Org mode buffer to a Speedbar frame.
3207 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3208 a composition, take its buffer position from IT->cmp_it.charpos.
3209 Fixes cursor positioning at the beginning of a line that begins
3210 with a composed character.
3212 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3214 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3215 character bidirectional type, use STRONG_L instead. Fixes crashes
3216 in a buffer produced by `describe-categories'.
3218 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3219 members before the level stack, so they would be saved and
3220 restored when copying iterator state. Fixes incorrect reordering
3221 around TABs covered by display properties.
3223 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3225 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3227 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3229 * eval.c (internal_condition_case, internal_condition_case_1)
3230 (internal_condition_case_2, internal_condition_case_n):
3231 Remove unnecessary aborts (Bug#9081).
3233 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3235 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3236 has no `load' handler, try opening the file locally. (Bug#9311)
3238 2011-08-16 Ken Brown <kbrown@cornell.edu>
3240 * gmalloc.c: Expand comment.
3242 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3244 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3245 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3247 2011-08-16 Ken Brown <kbrown@cornell.edu>
3249 Fix memory allocation problems in Cygwin build (Bug#9273).
3251 * unexcw.c ( __malloc_initialized): Declare external variable.
3252 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3254 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3256 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3258 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3260 [CYGWIN] (special_realloc): New function.
3261 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3262 requests to realloc storage in the static heap.
3264 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3266 * bidi.c (bidi_initialize): Remove unused local.
3268 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3271 * biditype.h: Remove file.
3272 * makefile.w32-in ($(BLD)/bidi.$(O)):
3273 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3275 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3277 * chartab.c: Improve commentary for the uniprop_table API.
3279 * bidi.c (bidi_paragraph_init): Support zero value of
3280 bidi_ignore_explicit_marks_for_paragraph_level.
3281 (bidi_initialize): Use uniprop_table instead of including
3282 biditype.h and bidimirror.h.
3284 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3285 coordinates of the iterator when restoring from ppos_it.
3288 2011-08-14 Kenichi Handa <handa@m17n.org>
3290 * process.c (create_process): Call setup_process_coding_systems
3291 after the pid of the process is set to -1 (Bug#8162).
3293 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3295 * xdisp.c (move_it_in_display_line_to): Don't invoke
3296 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3297 ppos_it. Fixes vertical cursor motion when line beginning is
3298 covered by an image. (Bug#9296)
3300 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3302 * nsterm.h (ns_run_ascript): Declare.
3303 (NSAPP_DATA2_RUNASSCRIPT): Define.
3305 * nsfns.m (as_script, as_result, as_status): New static variables.
3306 (ns_run_ascript): New function.
3307 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3308 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3309 the event loop. Get status from as_status (Bug#7276).
3311 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3312 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3313 the event loop (Bug#7276).
3315 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3317 * gnutls.c (QCgnutls_bootprop_priority)
3318 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3319 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3320 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3321 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3322 (QCgnutls_bootprop_verify_hostname_error)
3323 (QCgnutls_bootprop_callbacks_verify): Rename from
3324 Qgnutls_bootprop_..., all uses changed.
3326 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3329 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3331 * xfaces.c (Qframe_set_background_mode): Now static.
3332 * dispextern.h (Qframe_set_background_mode): Remove decl.
3334 * process.c (Fnetwork_interface_info): Declare local only if needed.
3336 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3338 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3339 (Fnetwork_interface_list): Allocate in increments of bytes instead
3340 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3341 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3343 (struct ifflag_def): notrailers is smart on OSX.
3344 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3345 Get hardware address with getifaddrs if available.
3347 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3349 * xdisp.c (iterate_out_of_display_property): xassert that
3350 IT->position is set to within IT->object's boundaries. Break from
3351 the loop as soon as EOB is reached; avoids infloops in redisplay
3352 when IT->position is set up wrongly due to some bug.
3353 Set IT->current to match the bidi iterator unconditionally.
3354 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3355 entry. Force push_it to save on the stack the current
3356 buffer/string position, to be restored by pop_it. Fix flags in
3357 the iterator structure wrt the object coming from a display
3358 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3359 properties. (Bug#9284)
3361 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3363 * fontset.c (fontset_get_font_group): Add proper type checks.
3366 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3368 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3369 and LC_VERSION_MIN_MACOSX.
3370 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3371 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3373 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3375 * xdisp.c (forward_to_next_line_start): Allow to use the
3376 no-display-properties-and-no-overlays under bidi display.
3377 Set disp_pos in the bidi iterator to avoid searches for display
3378 properties and overlays.
3380 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3382 * editfns.c (Fset_time_zone_rule): Document relationship with the
3385 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3386 the font entity extracted from the cache (Bug#8109).
3388 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3390 * composite.c (autocmp_chars): Don't reset point. That is done by
3391 restore_point_unwind (Bug#5984).
3393 2011-08-07 Juri Linkov <juri@jurta.org>
3395 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3396 to show the arg `TIME' instead of `TIMEVAL'.
3398 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3400 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3401 display property strides EOL and includes a newline, as in
3402 longlines-mode. (Bug#9254)
3403 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3404 word-wrap under bidirectional display. (Bug#9224)
3406 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3407 is non-zero, even if the data buffer is NULL. Fixes a crash in
3408 vertical-motion with longlines-mode. (Bug#9254)
3410 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3412 * bidi.c <bidi_cache_total_alloc>: Now static.
3413 (bidi_initialize): Initialize bidi_cache_total_alloc.
3415 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3418 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3419 amount allocated this far in `bidi_cache_total_alloc'.
3420 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3421 non-zero, only free the data buffer without restoring the cache
3422 contents. All callers changed.
3424 * dispextern.h (bidi_unshelve_cache): Update prototype.
3426 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3427 (move_it_in_display_line, move_it_to)
3428 (move_it_vertically_backward, move_it_by_lines): Replace the call
3429 to xfree to an equivalent call to bidi_unshelve_cache.
3430 (move_it_in_display_line_to): Fix logic of returning
3431 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3433 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3435 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3436 came from a string character with a `cursor' property. (Bug#9229)
3438 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3440 * Makefile.in (LIB_PTHREAD): New variable.
3441 (LIBES): Add LIB_PTHREAD (Bug#9216).
3443 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3444 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3446 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3448 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3450 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3452 * xterm.c (x_find_topmost_parent): New function.
3453 (x_set_frame_alpha): Find topmost parent window with
3454 x_find_topmost_parent and set the property there also (bug#9181).
3455 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3457 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3459 * callproc.c (Fcall_process): Avoid vfork clobbering
3460 the local vars buffer, coding_systems, current_dir.
3462 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3464 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3466 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3468 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3469 so that it is not optimized away.
3471 * xdisp.c (compute_display_string_pos): Remove unused local.
3473 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3475 Fix slow cursor motion and scrolling in large buffers with
3476 selective display, like Org Mode buffers. (Bug#9218)
3478 * dispextern.h (struct bidi_it): New member disp_prop_p.
3480 * xdisp.c: Remove one-slot cache of display string positions.
3481 (compute_display_string_pos): Accept an additional argument
3482 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3483 for a display string or property. If found, set DISP_PROP_P
3486 * bidi.c (bidi_fetch_char): Accept an additional argument
3487 DISP_PROP_P, and pass it to compute_display_string_pos.
3488 Only handle text covered by a display string if DISP_PROP_P is returned
3489 non-zero. All callers of bidi_fetch_char changed.
3491 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3493 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3495 2010-12-03 Don March <don@ohspite.net>
3497 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3498 last character M-[char] is translated to ESC [char] (bug#7541).
3500 2011-08-02 Kenichi Handa <handa@m17n.org>
3502 * lisp.h (uniprop_table): Extern it.
3504 * chartab.c (uniprop_table): Make it non-static.
3506 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3508 * xdisp.c (forward_to_next_line_start): Accept additional argument
3509 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3511 (reseat_at_next_visible_line_start): Use the bidi iterator state
3512 returned by forward_to_next_line_start to restore the state of
3513 it->bidi_it after backing up to previous newline. (Bug#9212)
3515 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3517 * regex.c (re_comp): Protoize.
3518 (re_exec): Fix return type.
3519 (regexec): Fix type of `ret'. (Bug#9203)
3521 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3523 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3524 This is needed if max-image-size is a floating-point number.
3526 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3528 * print.c (print_object): Print empty symbol as ##.
3530 * lread.c (read1): Read ## as empty symbol.
3532 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3534 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3535 setting frame foreground color (Bug#9175).
3536 (x_set_background_color): Likewise.
3538 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3539 contents (Bug#9176).
3540 (EmacsTooltip -init): Remove bezels and add shadows to
3543 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3544 or scroll bar (Bug#8470).
3546 * nsfont.m (nsfont_open): Remove assignment to voffset and
3547 unnecessary vars hshink, expand, hd, full_height, min_height.
3548 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3550 * nsterm.h (nsfont_info): Remove voffset field.
3552 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3554 Implement strike-through and overline on NextStep (Bug#8863).
3556 * nsfont.m (nsfont_open): Use underline position provided by font,
3557 instead of hard-coded value of 2.
3558 (nsfont_draw): Call ns_draw_text_decoration instead.
3560 * nsterm.h: Add declaration for ns_draw_text_decoration.
3562 * nsterm.m (ns_draw_text_decoration): New function for drawing
3563 underline, overline, and strike-through.
3564 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3565 ns_draw_text_decoration. Change treatment of cursor drawing to
3566 accommodate underlining, etc.
3568 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3570 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3573 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3575 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3576 Without this fix, if a signal arrives just after memory fills up,
3577 'malloc' might be invoked reentrantly.
3579 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3580 In other words, assume that every image size is allowed, on non-X
3581 hosts. This assumption is probably wrong, but it lets Emacs compile.
3583 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3585 * regex.c (re_iswctype): Convert return values to boolean.
3587 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3589 * xdisp.c (compute_display_string_pos): Don't use cached display
3590 string position if the buffer had its restriction changed.
3593 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3595 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3597 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3599 Integer signedness and overflow and related fixes. (Bug#9079)
3601 * bidi.c: Integer size and overflow fixes.
3602 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3603 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3604 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3605 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3606 (bidi_find_other_level_edge):
3607 Use ptrdiff_t instead of EMACS_INT where either will do.
3608 This works better on 32-bit hosts configured --with-wide-int.
3609 (bidi_cache_ensure_space): Check for size-calculation overflow.
3610 Use % rather than repeated addition, for better worst-case speed.
3611 Don't set bidi_cache_size until after xrealloc returns, because it
3613 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3614 (bidi_cache_ensure_space): Also check that the bidi cache size
3615 does not exceed that of the largest Lisp string or buffer. See Eli
3616 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3618 * alloc.c (__malloc_size_t): Remove.
3619 All uses replaced by size_t. See Andreas Schwab's note
3620 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3622 * image.c: Improve checking for integer overflow.
3623 (check_image_size): Assume that f is nonnull, since
3624 it is always nonnull in practice. This is one less thing to
3625 worry about when checking for integer overflow later.
3626 (x_check_image_size): New function, which checks for integer
3627 overflow issues inside X.
3628 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3629 This removes the need for a memory_full check.
3630 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3631 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3632 (xbm_read_bitmap_data): Change locals back to 'int', since
3633 their values must fit in 'int'.
3634 (xpm_load_image, png_load, tiff_load):
3635 Invoke x_create_x_image_and_pixmap earlier,
3636 to avoid much needless work if the image is too large.
3637 (tiff_load): Treat overly large images as if
3638 x_create_x_image_and_pixmap failed, not as malloc failures.
3639 (gs_load): Use x_check_image_size.
3641 * gtkutil.c: Omit integer casts.
3642 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3643 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3645 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3647 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3648 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3649 would wrongly return t on a 64-bit host.
3651 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3652 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3653 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3654 and therefore cause GCC to emit a bogus diagnostic in some cases.
3656 * image.c: Integer signedness and overflow and related fixes.
3657 This is not an exhaustive set of fixes, but it's time to
3658 record what I've got.
3659 (lookup_pixel_color, check_image_size): Remove redundant decls.
3660 (check_image_size): Don't assume that arbitrary EMACS_INT values
3661 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3662 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3663 (tiff_load, imagemagick_load_image):
3664 Check for overflow in size calculations.
3665 (x_create_x_image_and_pixmap): Remove unnecessary test for
3666 xmalloc returning NULL; that can't happen.
3667 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3668 (xpm_color_bucket): Use better integer hashing function.
3669 (xpm_cache_color): Don't possibly over-allocate memory.
3670 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3671 (gif_memory_source):
3672 Use ptrdiff_t, not int or size_t, to record sizes.
3673 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3674 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3675 either works, as we prefer signed integers.
3676 (tiff_read_from_memory, tiff_write_from_memory):
3677 Return tsize_t, not size_t, since that's what the TIFF API wants.
3678 (tiff_read_from_memory): Don't fail simply because the read would
3679 go past EOF; instead, return a short read.
3680 (tiff_load): Omit no-longer-needed casts.
3681 (Fimagemagick_types): Don't assume size fits into 'int'.
3683 Improve hashing quality when configured --with-wide-int.
3684 * fns.c (hash_string): New function, taken from sxhash_string.
3685 Do not discard information about ASCII character case; this
3686 discarding is no longer needed.
3687 (sxhash-string): Use it. Change sig to match it. Caller changed.
3688 * lisp.h: Declare it.
3689 * lread.c (hash_string): Remove, since we now use fns.c's version.
3690 The fns.c version returns a wider integer if --with-wide-int is
3691 specified, so this should help the quality of the hashing a bit.
3693 * emacs.c: Integer overflow minor fix.
3694 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3695 Define only if GNU_LINUX.
3696 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3698 * dispnew.c: Integer signedness and overflow fixes.
3699 Remove unnecessary forward decls, that were a maintenance hassle.
3700 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3702 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3703 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3704 (prepare_desired_row, line_draw_cost):
3705 Use int, not unsigned, where either works.
3706 (save_current_matrix, restore_current_matrix):
3707 Use ptrdiff_t, not size_t, where either works.
3708 (init_display): Check for overflow more accurately, and without
3709 relying on undefined behavior.
3711 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3712 Remove, replacing with the new symbols in lisp.h. All uses changed.
3713 * fileio.c (make_temp_name):
3714 * filelock.c (lock_file_1, lock_file):
3715 * xdisp.c (message_dolog):
3716 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3717 Use pMd etc. instead.
3718 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3719 replacing the pWIDE etc. symbols removed from editfns.c.
3721 * keyboard.h (num_input_events): Now uintmax_t.
3722 This is (very slightly) less likely to mess up due to wraparound.
3725 * buffer.c: Integer signedness fixes.
3726 (alloc_buffer_text, enlarge_buffer_text):
3727 Use ptrdiff_t rather than size_t when either will do, as we prefer
3730 * alloc.c: Integer signedness and overflow fixes.
3731 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3732 (__malloc_size_t): Default to size_t, not to int.
3733 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3734 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3735 Prefer ptrdiff_t to size_t when either would do, as we prefer
3737 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3738 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3739 Now const. Initialize with values that are in range even if char
3741 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3742 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3743 These functions do the right thing with sizes > 2**32.
3744 (check_depth): Now ptrdiff_t, not int.
3745 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3746 Adjust to new way of storing sizes. Check for size overflow bugs
3748 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3749 slightly wrong anyway, as it missed one instance of
3750 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3751 (refill_memory_reserve): Omit needless cast to size_t.
3752 (mark_object_loop_halt): Mark as externally visible.
3754 * xselect.c: Integer signedness and overflow fixes.
3755 (Fx_register_dnd_atom, x_handle_dnd_message):
3756 Use ptrdiff_t, not size_t, since we prefer signed.
3757 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3758 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3759 x_dnd_atoms_size and x_dnd_atoms_length.
3761 * doprnt.c: Prefer signed to unsigned when either works.
3763 * doprnt.c (doprnt):
3765 * xdisp.c (vmessage):
3766 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3767 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3768 prefer signed arithmetic to avoid comparison confusion.
3769 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3770 but is a bit tricky.
3772 Assume freestanding C89 headers, string.h, stdlib.h.
3773 * data.c, doprnt.c, floatfns.c, print.c:
3774 Include float.h unconditionally.
3775 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3776 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3777 * regex.c: Likewise for stddef.h, string.h.
3778 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3779 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3780 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3781 (STDC_HEADERS): Remove obsolete defines.
3782 * sysdep.c: Include limits.h unconditionally.
3784 Assume support for memcmp, memcpy, memmove, memset.
3785 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3786 * regex.c (memcmp, memcpy):
3787 Remove; we assume C89 now.
3789 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3790 (__malloc_safe_bcopy): Remove; no longer needed.
3792 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3793 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3794 well either way, and we prefer signed to unsigned.
3796 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3798 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3799 closes the connection while we're reading (bug#9182).
3801 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3803 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3804 are specified (Bug#9168).
3806 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3808 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3809 Found by GCC static checking and --with-wide-int on a 32-bit host.
3811 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3813 * xdisp.c (compute_display_string_pos): Fix logic of caching
3814 previous display string position. Initialize cached_prev_pos to
3815 -1. Fixes slow-down at the beginning of a buffer.
3817 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3819 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3820 for attrs[LFACE_FONTSET_INDEX].
3822 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3824 * xml.c (parse_region): Remove unused local
3825 that was recently introduced.
3827 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3829 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3830 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3832 * xdisp.c (move_it_in_display_line_to): Record the best matching
3833 position for TO_CHARPOS while scanning the line, and restore it on
3834 exit if none of the characters scanned was an exact match.
3835 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3836 when exact match is impossible due to invisible text, and the
3837 lines are truncated.
3839 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3841 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3844 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3846 Fix a significant slow-down of cursor motion with C-n, C-p,
3847 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3848 auto-repeat under bidi redisplay in fontified buffers.
3849 * xdisp.c (compute_stop_pos_backwards): New function.
3850 (next_element_from_buffer): Call compute_stop_pos_backwards to
3851 find a suitable prev_stop when we find ourselves before
3853 (reseat): Don't look for prev_stop, as that could mean a very long
3855 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3856 <cached_disp_overlay_modiff>: Cache for last found display string
3858 (compute_display_string_pos): Return the cached position if asked
3859 about the same buffer in the same area of character positions, and
3860 the buffer wasn't changed since the time the display string
3861 position was cached.
3863 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3865 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3866 is an integer, which is important for empty lines. (Bug#9149)
3868 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3870 * frame.c (Fmodify_frame_parameters): In tty case, update the
3871 default face if necessary (Bug#4238).
3873 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3875 * editfns.c (Fstring_to_char): No need to explain what a character
3876 is in the docstring (Bug#6576).
3878 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3880 * xml.c (parse_region): Make sure we always return a tree.
3882 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3884 * xml.c (parse_region): If a document contains only comments,
3887 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3889 * xml.c (make_dom): Return comments, too.
3891 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3894 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3895 and the surrounding thread.
3896 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3897 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3898 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3900 * s/openbsd.h (BROKEN_SIGIO): Define.
3901 * unexelf.c (unexec) [__OpenBSD__]:
3902 Don't update the .mdebug section of the Alpha COFF symbol table.
3904 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3906 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3909 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3911 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3912 This fixes some race conditions on the permissions of any newly
3915 * alloc.c (valid_pointer_p): Use pipe, not open.
3916 This fixes some permissions issues when debugging.
3918 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3919 If fchown fails to set both uid and gid, try to set just gid,
3920 as that is sometimes allowed. Adjust the file's mode to eliminate
3921 setuid or setgid bits that are inappropriate if fchown fails.
3923 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3925 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3926 to compare Lisp_Objects.
3927 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3928 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3929 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3931 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3933 * lread.c (read_integer): Unread even EOF character.
3934 (read1): Likewise. Properly record start position of symbol.
3936 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3937 symbol character follows.
3939 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3941 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3942 This works around a problem with the previous change to Fcopy_file.
3943 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3944 and without this change, GCC might complain about discarding
3945 fchown's return value.
3947 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3949 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3951 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3953 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3955 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3957 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3958 it's used from the C level.
3960 * process.c: Use the same condition for POLL_FOR_INPUT in both
3961 keyboard.c and process.c (bug#1858).
3963 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3965 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3966 (Fgnutls_boot): Use it.
3968 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3970 * doc.c (Fsubstitute_command_keys): Revert last change.
3972 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3974 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3975 quotes the next character, and doesn't affect other longer
3976 sequences (bug#8935).
3978 * lread.c (syms_of_lread): Clarify that is isn't only
3979 `eval-buffer' and `eval-defun' that's affected by
3980 `lexical-binding' (bug#8460).
3982 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3984 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3985 bidi redisplay when a line includes both an image and is truncated.
3987 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3989 Fix minor problems found by static checking.
3990 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3991 (elsz): Now a signed constant, not a size_t var. We prefer signed
3992 types to unsigned, to avoid integer comparison confusion. Without
3993 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3994 "cannot optimize loop, the loop counter may overflow", a symptom
3996 * indent.c (Fvertical_motion): Mark locals as initialized.
3997 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3999 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4001 * search.c (Fre_search_backward): Mention `case-fold-search' in
4002 all the re_search_* functions (bug#8138).
4004 * keyboard.c (Fopen_dribble_file): Document when the file is
4007 2011-07-14 Eli Zaretskii <eliz@gnu.org>
4009 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4012 Support bidi reordering of display and overlay strings.
4013 * xdisp.c (compute_display_string_pos)
4014 (compute_display_string_end): Accept additional argument STRING.
4015 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4016 (reseat_to_string): Initialize bidi_it->string.s and
4017 bidi_it->string.schars.
4018 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
4019 NULL (avoids a crash in bidi_paragraph_init).
4020 Initialize itb.string.lstring.
4021 (init_iterator): Call bidi_init_it only of a valid
4022 buffer position was specified. Initialize paragraph_embedding to
4024 (reseat_to_string): Initialize the bidi iterator.
4025 (display_string): If we need to ignore text properties of
4026 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4027 original value of -1 will not work with bidi.)
4028 (compute_display_string_pos): First arg is now struct
4029 `text_pos *'; all callers changed. Support display properties on
4031 (compute_display_string_end): Support display properties on Lisp
4033 (init_iterator, reseat_1, reseat_to_string): Initialize the
4034 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4035 when iterating on a string not from display properties).
4036 (compute_display_string_pos, compute_display_string_end):
4037 Fix calculation of the object to scan. Fixes an error when using
4039 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4040 base_level_stop; instead, set base_level_stop to BEGV.
4041 Fixes crashes in vertical-motion.
4042 (next_element_from_buffer): Improve commentary for when
4043 the iterator is before prev_stop.
4044 (init_iterator): Initialize bidi_p from the default value of
4045 bidi-display-reordering, not from buffer-local value. Use the
4046 buffer-local value only if initializing for buffer iteration.
4047 (handle_invisible_prop): Support invisible properties on strings
4048 that are being bidi-reordered.
4049 (set_iterator_to_next): Support bidi reordering of C strings and
4051 (next_element_from_string): Support bidi reordering of Lisp
4053 (handle_stop_backwards): Support Lisp strings as well.
4054 (display_string): Support display of R2L glyph rows.
4055 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4056 (init_iterator): Don't initialize it->bidi_p for strings
4058 (reseat_to_string): Initialize it->bidi_p for strings here.
4059 (next_element_from_string, next_element_from_c_string)
4060 (next_element_from_buffer): Add xassert's for correspondence
4061 between IT's object being iterated and it->bidi_it.string
4063 (face_before_or_after_it_pos): Support bidi iteration.
4064 (next_element_from_c_string): Handle the case of the first string
4065 character that is not the first one in the visual order.
4066 (get_visually_first_element): New function, refactored from common
4067 parts of next_element_from_buffer, next_element_from_string, and
4068 next_element_from_c_string.
4069 (tool_bar_lines_needed, redisplay_tool_bar)
4070 (display_menu_bar): Force left-to-right direction. Add a FIXME
4071 comment for making that be controlled by a user option.
4072 (push_it, pop_it): Save and restore the state of the
4073 bidi iterator. Save and restore the bidi_p flag.
4074 (pop_it): Iterate out of display property for string iteration as
4076 (iterate_out_of_display_property): Support iteration over strings.
4077 (handle_single_display_spec): Set up it->bidi_it for iteration
4078 over a display string, and call bidi_init_it.
4079 (handle_single_display_spec, next_overlay_string)
4080 (get_overlay_strings_1, push_display_prop): Set up the bidi
4081 iterator for displaying display or overlay strings.
4082 (forward_to_next_line_start): Don't use the shortcut if
4084 (back_to_previous_visible_line_start): If handle_display_prop
4085 pushed the iterator stack, restore the internal state of the bidi
4086 iterator by calling bidi_pop_it same number of times.
4087 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4088 and we are bidi-iterating, don't decrement the iterator position;
4089 instead, set the first_elt flag in the bidi iterator, to produce
4091 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4092 (push_display_prop): xassert that we are iterating a buffer.
4093 (push_it, pop_it): Save and restore paragraph_embedding member.
4094 (handle_single_display_spec, next_overlay_string)
4095 (get_overlay_strings_1, reseat_1, reseat_to_string)
4096 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4097 correctly. Don't assume unibyte strings are not bidi-reordered.
4098 (compute_display_string_pos)
4099 (compute_display_string_end): Fix handling the case of C string.
4100 (push_it, pop_it): Save and restore from_disp_prop_p.
4101 (handle_single_display_spec, push_display_prop): Set the
4102 from_disp_prop_p flag.
4103 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4104 (pop_it): Call iterate_out_of_display_property only if we are
4105 popping after iteration over a string that came from a display
4106 property. Fix a typo in popping stretch info. Add an assertion
4107 for verifying that the iterator position is in sync with the bidi
4109 (handle_single_display_spec, get_overlay_strings_1)
4110 (push_display_prop): Fix initialization of paragraph direction for
4111 string when that of the parent object is not yet determined.
4112 (reseat_1): Call bidi_init_it to resync the bidi
4113 iterator with IT's position. (Bug#7616)
4114 (find_row_edges): If ROW->start.pos gives position
4115 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4116 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4117 Reset the from_disp_prop_p flag.
4118 (SAVE_IT, RESTORE_IT): New macros.
4119 (pos_visible_p, face_before_or_after_it_pos)
4120 (back_to_previous_visible_line_start)
4121 (move_it_in_display_line_to, move_it_in_display_line)
4122 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4123 (try_scrolling, redisplay_window, display_line): Use them when
4124 saving a temporary copy of the iterator and restoring it back.
4125 (back_to_previous_visible_line_start, reseat_1)
4126 (init_iterator): Empty the bidi cache "stack".
4127 (move_it_in_display_line_to): If iterator ended up at
4128 EOL, but we never saw any buffer positions smaller than
4129 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4130 motion in bidi-reordered lines.
4131 (move_it_in_display_line_to): Record prev_method and prev_pos
4132 immediately before the call to set_iterator_to_next. Fixes cursor
4133 motion in bidi-reordered lines with stretch glyphs and strings
4134 displayed in margins. (Bug#8133) (Bug#8867)
4135 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4137 (pos_visible_p): Support positions in bidi-reordered lines.
4138 Save and restore bidi cache.
4140 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4141 (bidi_paragraph_info): Delete unused struct.
4142 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4143 (bidi_cache_start): New variable.
4144 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4146 (bidi_cache_fetch_state, bidi_cache_search)
4147 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4148 (bidi_cache_find, bidi_peek_at_next_level)
4149 (bidi_level_of_next_char, bidi_find_other_level_edge)
4150 (bidi_move_to_visually_next): Compare cache index with
4151 bidi_cache_start rather than with zero.
4152 (bidi_fetch_char): Accept new argument STRING; all callers
4153 changed. Support iteration over a string. Support strings with
4154 display properties. Support unibyte strings. Fix the type of
4155 `len' according to what STRING_CHAR_AND_LENGTH expects.
4156 (bidi_paragraph_init, bidi_resolve_explicit_1)
4157 (bidi_resolve_explicit, bidi_resolve_weak)
4158 (bidi_level_of_next_char, bidi_move_to_visually_next):
4159 Support iteration over a string.
4160 (bidi_set_sor_type, bidi_resolve_explicit_1)
4161 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4162 can now be zero (for strings); special values 0 and -1 were
4163 changed to -1 and -2, respectively.
4164 (bidi_char_at_pos): New function.
4165 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4166 Call it instead of FETCH_MULTIBYTE_CHAR.
4167 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4168 initialized to valid values.
4169 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4171 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4172 the test for valid cached positions. Fix the logic for looking up
4173 the sentinel state in the cache. GCPRO the Lisp string we are
4175 (bidi_push_it, bidi_pop_it): New functions.
4176 (bidi_initialize): Initialize the bidi cache start stack pointer.
4177 (bidi_cache_ensure_space): New function, refactored from part of
4178 bidi_cache_iterator_state. Don't assume the required size is just
4179 one BIDI_CACHE_CHUNK away.
4180 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4181 (bidi_count_bytes, bidi_char_at_pos): New functions.
4182 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4183 always valid if bidi_cache_idx is valid.
4184 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4185 is valid if it's going to be used.
4186 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4187 (bidi_cache_fetch_state, bidi_cache_search)
4188 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4189 (bidi_cache_iterator_state, bidi_cache_find)
4190 (bidi_find_other_level_edge, bidi_cache_start_stack):
4191 All variables related to cache indices are now EMACS_INT.
4193 * dispextern.h (struct bidi_string_data): New structure.
4194 (struct bidi_it): New member `string'. Make flag members be 1-bit
4195 fields, and put them last in the struct.
4196 (compute_display_string_pos, compute_display_string_end):
4198 (bidi_push_it, bidi_pop_it): Add prototypes.
4199 (struct iterator_stack_entry): New members bidi_p,
4200 paragraph_embedding, and from_disp_prop_p.
4201 (struct it): Member bidi_p is now a bit field 1 bit wide.
4202 (bidi_shelve_cache, bidi_unshelve_cache):
4205 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4206 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4207 and vector-like objects.
4209 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4210 cache around display iteration.
4212 * window.c (Fwindow_end, window_scroll_pixel_based)
4213 (displayed_window_lines, Frecenter): Save and restore the bidi
4214 cache around display iteration.
4216 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4218 * editfns.c (Fdelete_region): Clarify the use of the named
4219 parameters (bug#6788).
4221 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4223 * indent.c (Fvertical_motion): Set and restore w->pointm when
4224 saving and restoring the window's buffer (Bug#9006).
4226 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4228 * editfns.c (Fstring_to_char): Clarify just what is returned
4229 (bug#6576). Text by Eli Zaretskii.
4231 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4233 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4235 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4237 * buffer.c (mmap_find): Fix a typo.
4239 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4241 Fix execution of x selection hooks.
4242 * xselect.c (Qx_lost_selection_functions)
4243 (Qx_sent_selection_functions): New vars.
4244 (syms_of_xselect): DEFSYM them.
4245 (x_handle_selection_request): Pass Qx_sent_selection_functions
4246 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4247 (x_handle_selection_clear,x_clear_frame_selections):
4248 Pass Qx_lost_selection_functions rather than
4249 Vx_lost_selection_functions to Frun_hook_with_args.
4251 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4253 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4254 The old code sometimes used this field without initializing it.
4256 * alloc.c (gc_sweep): Don't read past end of array.
4257 In theory, the old code could also have corrupted Emacs internals,
4258 though it'd be very unlikely.
4260 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4262 * character.c (Fcharacterp): Don't advertise optional ignored
4263 argument. (Bug#4026)
4265 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4267 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4270 * window.c (Fset_window_start): Doc fix (bug#4199).
4271 (Fset_window_hscroll): Ditto.
4273 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4275 Fix minor new problems caught by GCC 4.6.1.
4276 * term.c (init_tty): Remove unused local.
4277 * xsettings.c (store_monospaced_changed): Define this function only
4278 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4281 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4283 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4285 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4287 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4288 are the mini-buffer and the echo area (bug#3320).
4290 * term.c (init_tty): Remove support for supdup, c10 and perq
4291 terminals, which are no longer supported (bug#1482).
4293 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4295 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4297 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4299 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4300 for non-popups (Bug#3642).
4302 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4304 * alloc.c (reset_malloc_hooks): Protoize.
4305 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4306 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4307 * cm.c (losecursor): Likewise.
4308 * data.c (fmod): Likewise.
4309 * dispnew.c (swap_glyphs_in_rows): Likewise.
4310 * emacs.c (memory_warning_signal): Likewise.
4311 * floatfns.c (float_error): Likewise.
4312 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4313 (otf_open, font_otf_capability, generate_otf_features)
4314 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4316 * image.c (pbm_read_file): Likewise.
4317 * indent.c (string_display_width): Likewise.
4318 * intervals.c (check_for_interval, search_for_interval)
4319 (inc_interval_count, count_intervals, root_interval)
4320 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4321 * lread.c (defalias): Likewise.
4322 * ralloc.c (r_alloc_check): Likewise.
4323 * regex.c (set_image_of_range_1, set_image_of_range)
4324 (regex_grow_registers): Likewise.
4325 * sysdep.c (strerror): Likewise.
4326 * termcap.c (valid_filename_p, tprint, main): Likewise.
4327 * tparam.c (main): Likewise.
4328 * unexhp9k800.c (run_time_remap, save_data_space)
4329 (update_file_ptrs, read_header, write_header, calculate_checksum)
4330 (copy_file, copy_rest, display_header): Likewise.
4331 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4333 * xdisp.c (check_it): Likewise.
4334 * xfaces.c (register_color, unregister_color, unregister_colors):
4336 * xfns.c (print_fontset_result): Likewise.
4337 * xrdb.c (member, fatal, main): Likewise.
4339 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4341 Fix minor problems found by static checking (Bug#9031).
4342 * chartab.c (char_table_set_range, map_sub_char_table):
4343 Remove unused locals.
4344 (uniprop_table): Now static.
4345 * composite.c (_work_char): Remove unused static var.
4347 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4349 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4351 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4353 * gtkutil.c (qttip_cb): Remove code without function.
4355 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4357 * w32.c (pthread_sigmask): New stub.
4359 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4361 Use pthread_sigmask, not sigprocmask (Bug#9010).
4362 sigprocmask is portable only for single-threaded applications, and
4363 Emacs can be multi-threaded when it uses GTK.
4364 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4366 * callproc.c (Fcall_process):
4367 * process.c (create_process):
4368 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4369 Use pthread_sigmask, not sigprocmask.
4371 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4373 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4374 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4377 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4379 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4380 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4381 (xg_hide_tooltip): Fix comment.
4383 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4384 in registerServicesMenuSendTypes.
4385 (validRequestorForSendType): Don't check ns_return_types.
4387 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4390 2011-07-08 Jason Rumney <jasonr@gnu.org>
4392 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4393 SH_SHOW for hidden windows (Bug#5482).
4395 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4396 frame struct members of non-existent frames (Bug#6284).
4398 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4400 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4401 variable firstTime not needed on OSX >= 10.6.
4402 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4403 >= 10.5. Use setKnobProportion, setDoubleValue.
4405 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4406 (MAC_OS_X_VERSION_10_5): Define if not defined.
4407 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4408 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4409 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4411 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4412 cString and lossyCString on OSX >= 10.4
4414 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4415 sizeToFit on OSX >= 10.2.
4417 * nsimage.m (allocInitFromFile): Don't use deprecated method
4418 bestRepresentationForDevice on OSX >= 10.6.
4420 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4423 * emacs.c: Declare unexec_init_emacs_zone.
4425 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4427 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4429 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4430 on svcsMenu (Bug#8842).
4432 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4434 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4436 * nsterm.m (QUTF8_STRING): Declare.
4437 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4438 (validRequestorForSendType): Return type is (id).
4439 Change indexOfObjectIdenticalTo to indexOfObject.
4440 Check if we have local selection before returning self (Bug#8842).
4441 (writeSelectionToPasteboard): Put local selection into paste board
4442 if we have a local selection (Bug#8842).
4443 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4445 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4446 (ns_get_local_selection): Declare.
4448 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4450 * keymap.c (describe_map_tree): Don't insert a double newline at
4451 the end of the buffer (bug#1169) and return whether we inserted
4454 * callint.c (Fcall_interactively): Change "reading args" to
4455 "providing args" to try to clarify what it does (bug#1010).
4457 2011-07-07 Kenichi Handa <handa@m17n.org>
4459 * composite.c (composition_compute_stop_pos): Ignore a static
4460 composition starting before CHARPOS (Bug#8915).
4462 * xdisp.c (handle_composition_prop): Likewise.
4464 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4466 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4469 2011-07-07 Kenichi Handa <handa@m17n.org>
4471 * character.h (unicode_category_t): New enum type.
4473 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4474 (Qchar_code_property_table): New variable.
4475 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4476 (UNIPROP_COMPRESSED_FORM_P): New macros.
4477 (char_table_ascii): Uncompress the compressed values.
4478 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4479 Uncompress the compressed values.
4480 (sub_char_table_ref_and_range): Likewise.
4481 (char_table_ref_and_range): Uncompress the compressed values.
4482 (sub_char_table_set): New arg is_uniprop. Callers changed.
4483 Uncompress the compressed values.
4484 (sub_char_table_set_range): Args changed. Callers changed.
4485 (char_table_set_range): Adjuted for the above change.
4486 (map_sub_char_table): Delete args default_val and parent. Add arg
4487 top. Give decoded values to a Lisp function.
4488 (map_char_table): Adjust for the above change. Give decoded
4489 values to a Lisp function. Gcpro more variables.
4490 (uniprop_table_uncompress)
4491 (uniprop_decode_value_run_length): New functions.
4492 (uniprop_decoder, uniprop_decoder_count): New variables.
4493 (uniprop_get_decoder, uniprop_encode_value_character)
4494 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4496 (uniprop_encoder, uniprop_encoder_count): New variables.
4497 (uniprop_get_encoder, uniprop_table)
4498 (Funicode_property_table_internal, Fget_unicode_property_internal)
4499 (Fput_unicode_property_internal): New functions.
4500 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4501 Sunicode_property_table_internal, Sget_unicode_property_internal,
4502 and Sput_unicode_property_internal. Defvar_lisp
4503 char-code-property-alist.
4505 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4506 Vunicode_category_table.
4508 * font.c (font_range): Adjust for the change of
4509 Vunicode_category_table.
4511 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4513 * m/iris4d.h: Remove file, move contents ...
4514 * s/irix6-5.h: ... here.
4516 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4518 Remove unportable assumption about struct layout (Bug#8884).
4519 * alloc.c (mark_buffer):
4520 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4521 (clone_per_buffer_values): Don't assume that
4522 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4523 This isn't true in general, and it's particularly not true
4524 if Emacs is configured with --with-wide-int.
4525 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4526 New macros, used in the buffer.c change.
4528 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4530 * xsettings.c: Use both GConf and GSettings if both are available.
4531 (store_config_changed_event): Add comment.
4532 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4533 (store_tool_bar_style_changed): New functions.
4534 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4535 (struct xsettings): Move font inside HAVE_XFT.
4536 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4537 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4538 Move inside HAVE_XFT.
4539 (something_changed_gsettingsCB): Rename from something_changedCB.
4540 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4542 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4543 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4544 (something_changed_gconfCB): Rename from something_changedCB.
4545 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4546 (parse_settings): Move check for font inside HAVE_XFT.
4547 (read_settings, apply_xft_settings): Add comment.
4548 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4549 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4550 call store_font_name_changed.
4551 (xft_settings_event): Add comment.
4552 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4553 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4554 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4555 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4556 (xsettings_initialize): Call init_gsettings last.
4557 (xsettings_get_system_font, xsettings_get_system_normal_font):
4560 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4562 Random fixes. E.g., (random) never returned negative values.
4563 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4564 subseconds part to the entropy, as that's a bit more random.
4565 Prefer signed to unsigned, since the signedness doesn't matter and
4566 in general we prefer signed. When given a limit, use a
4567 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4568 latter isn't right if USE_2_TAGS_FOR_INTS.
4569 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4570 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4572 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4574 * textprop.c (text_property_stickiness):
4575 Obey Vtext_property_default_nonsticky.
4576 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4577 * w32fns.c (syms_of_w32fns):
4578 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4580 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4582 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4583 This is more efficient than Ffile_directory_p and avoids a minor race.
4585 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4587 * buffer.c (Foverlay_put): Say what the return value is
4590 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4591 is a directory before asking whether to use the file name
4593 (barf_or_query_if_file_exists): Make the "File is a directory"
4594 error be more correct.
4596 * fns.c (Frequire): Remove the mention of the .gz files, since
4597 that's installation-specific, but keep the mention of
4598 `get-load-suffixes'.
4600 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4602 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4603 Report string overflow if the output is too long.
4605 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4607 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4608 (syms_of_gnutls): Remove duplicate DEFSYM for
4609 Qgnutls_bootprop_verify_hostname_error, an error for
4610 Qgnutls_bootprop_verify_error (which is no longer used).
4612 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4613 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4614 Also (re)move comments that are misplaced or no longer relevant.
4616 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4618 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4620 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4622 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4623 and background color parameters if they have been changed.
4625 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4627 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4629 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4631 * xsettings.c (SYSTEM_FONT): Define only when used.
4632 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4634 * keymap.c (access_keymap_1): Now static.
4636 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4638 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4639 leave any prefix arg for the up event (Bug#1586).
4641 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4643 * lread.c (syms_of_lread): Mention single symbols defined by
4644 `defvar' or `defconst' (bug#7154).
4646 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4647 (Frequire): Mention get-load-suffixes.
4649 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4651 * window.h (window): Remove clone_number slot.
4652 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4654 (make_parent_window, make_window, saved_window)
4655 (Fset_window_configuration, save_window_save): Don't deal with
4657 * buffer.c (Qclone_number): Remove declaration.
4658 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4660 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4662 Add multiple inheritance to keymaps.
4663 * keymap.c (Fmake_composed_keymap): New function.
4664 (Fset_keymap_parent): Simplify.
4665 (fix_submap_inheritance): Remove.
4666 (access_keymap_1): New function extracted from access_keymap to handle
4667 embedded parents and handle lists of maps.
4668 (access_keymap): Use it.
4669 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4670 (Fcopy_keymap): Handle embedded parents.
4671 (Fcommand_remapping, define_as_prefix): Simplify.
4672 (Fkey_binding): Simplify.
4673 (syms_of_keymap): Move minibuffer-local-completion-map,
4674 minibuffer-local-filename-completion-map,
4675 minibuffer-local-must-match-map, and
4676 minibuffer-local-filename-must-match-map to Elisp.
4677 (syms_of_keymap): Defsubr make-composed-keymap.
4678 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4679 (parse_menu_item): Trivial simplification.
4681 2011-07-01 Glenn Morris <rgm@gnu.org>
4683 * Makefile.in (SETTINGS_LIBS): Fix typo.
4685 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4687 * coding.c (Fencode_coding_string): Record the last coding system
4688 used, as the function doc string says (bug#8738).
4690 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4692 * xsettings.c (store_monospaced_changed): Take new font as arg and
4693 check for change against current_mono_font.
4694 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4695 (emacs_settings_constructor, emacs_settings_get_property)
4696 (emacs_settings_set_property, emacs_settings_class_init)
4697 (emacs_settings_init, gsettings_obj): Remove.
4698 (something_changedCB): New function for HAVE_GSETTINGS.
4699 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4700 with value as argument.
4701 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4702 g_settings_new (Bug#8967). Do not create gsettings_obj.
4703 Remove calls to g_settings_bind. Connect something_changedCB to
4706 * xgselect.c: Add defined (HAVE_GSETTINGS).
4707 (xgselect_initialize): Ditto.
4709 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4710 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4713 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4715 * eval.c (struct backtrace): Simplify and port the data structure.
4716 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4717 signed bit field, as this assumption is not portable and it makes
4718 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4719 "char debug_on_exit : 1" as this is not portable either; instead,
4720 use the portable "unsigned int debug_on_exit : 1". Remove unused
4721 member evalargs. Remove obsolete comments about cc bombing out.
4723 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4725 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4726 Let HAVE_GSETTINGS override HAVE_GCONF.
4727 (store_monospaced_changed): New function.
4728 (EMACS_SETTINGS): A new type derived from GObject to handle
4729 GSettings notifications.
4730 (emacs_settings_constructor, emacs_settings_get_property)
4731 (emacs_settings_set_property, emacs_settings_class_init):
4733 (gsettings_client, gsettings_obj): New variables.
4734 (GSETTINGS_SCHEMA): New define.
4735 (something_changedCB): Call store_monospaced_changed.
4736 (init_gsettings): New function.
4737 (xsettings_initialize): Call init_gsettings.
4738 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4741 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4744 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4746 * window.c (resize_root_window, grow_mini_window)
4747 (shrink_mini_window): Rename Qresize_root_window to
4748 Qwindow_resize_root_window and Qresize_root_window_vertically to
4749 Qwindow_resize_root_window_vertically.
4751 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4753 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4755 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4757 * makefile.w32-in: Redesign dependencies so they reflect more
4758 clearly which files are directly included by each source file,
4759 and not through other includes.
4761 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4763 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4764 (sort_overlays, overlay_strings): When an overlay's clone number
4765 matches the window's clone number process the overlay even if
4766 the overlay's window property doesn't match the current window.
4768 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4769 (Fwindow_hchild): Rename to Fwindow_left_child.
4770 (Fwindow_next): Rename to Fwindow_next_sibling.
4771 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4772 (resize_window_check): Rename to window_resize_check.
4773 (resize_window_apply): Rename to window_resize_apply.
4774 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4775 (Fdelete_other_windows_internal, resize_frame_windows)
4776 (Fsplit_window_internal, Fdelete_window_internal)
4777 (grow_mini_window, shrink_mini_window)
4778 (Fresize_mini_window_internal): Fix callers accordingly.
4780 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4782 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4783 (emacs_fixed_set_min_size): Remove.
4784 (emacs_fixed_new): Take frame as argument.
4786 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4787 (_EmacsFixedPrivate): Remove minwidth/height.
4788 Add struct frame *f.
4789 (emacs_fixed_init): Initialize priv->f.
4790 (get_parent_class, emacs_fixed_set_min_size): Remove.
4791 (emacs_fixed_new): Set priv->f to argument.
4792 (emacs_fixed_get_preferred_width)
4793 (emacs_fixed_get_preferred_height): Use min_width/height from
4794 frames size_hint to set minimum and natural (Bug#8919).
4795 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4796 and use min_width/height from frames size_hint to set
4797 min_width/height (Bug#8919).
4799 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4800 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4803 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4805 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4806 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4809 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4811 * process.c (wait_reading_process_output): Bypass select if
4812 waiting for a cell while ignoring keyboard input, and input is
4813 pending. Suggested by Jan Djärv (Bug#8869).
4815 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4817 Use gnulib's dup2 module instead of rolling our own.
4818 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4820 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4822 * dispnew.c (scrolling_window): Before scrolling, turn off a
4823 mouse-highlight in the window being scrolled.
4825 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4827 Move DEFSYM to lisp.h and use everywhere.
4829 * character.h (DEFSYM): Move declaration...
4830 * lisp.h (DEFSYM): ...here.
4836 * w32select.c: Don't include character.h.
4838 * alloc.c (syms_of_alloc):
4839 * buffer.c (syms_of_buffer):
4840 * bytecode.c (syms_of_bytecode):
4841 * callint.c (syms_of_callint):
4842 * casefiddle.c (syms_of_casefiddle):
4843 * casetab.c (init_casetab_once):
4844 * category.c (init_category_once, syms_of_category):
4845 * ccl.c (syms_of_ccl):
4846 * cmds.c (syms_of_cmds):
4847 * composite.c (syms_of_composite):
4848 * dbusbind.c (syms_of_dbusbind):
4849 * dired.c (syms_of_dired):
4850 * dispnew.c (syms_of_display):
4851 * doc.c (syms_of_doc):
4852 * editfns.c (syms_of_editfns):
4853 * emacs.c (syms_of_emacs):
4854 * eval.c (syms_of_eval):
4855 * fileio.c (syms_of_fileio):
4856 * fns.c (syms_of_fns):
4857 * frame.c (syms_of_frame):
4858 * fringe.c (syms_of_fringe):
4859 * insdel.c (syms_of_insdel):
4860 * keymap.c (syms_of_keymap):
4861 * lread.c (init_obarray, syms_of_lread):
4862 * macros.c (syms_of_macros):
4863 * msdos.c (syms_of_msdos):
4864 * print.c (syms_of_print):
4865 * process.c (syms_of_process):
4866 * search.c (syms_of_search):
4867 * sound.c (syms_of_sound):
4868 * syntax.c (init_syntax_once, syms_of_syntax):
4869 * terminal.c (syms_of_terminal):
4870 * textprop.c (syms_of_textprop):
4871 * undo.c (syms_of_undo):
4872 * w32.c (globals_of_w32):
4873 * window.c (syms_of_window):
4874 * xdisp.c (syms_of_xdisp):
4875 * xfaces.c (syms_of_xfaces):
4876 * xfns.c (syms_of_xfns):
4877 * xmenu.c (syms_of_xmenu):
4878 * xsettings.c (syms_of_xsettings):
4879 * xterm.c (syms_of_xterm): Use DEFSYM.
4881 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4883 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4885 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4887 Integer and buffer overflow fixes (Bug#8873).
4889 * print.c (printchar, strout): Check for string overflow.
4890 (PRINTPREPARE, printchar, strout):
4891 Don't set size unless allocation succeeds.
4893 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4894 for sizes. Check for string overflow more accurately.
4895 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4897 * macros.c: Integer and buffer overflow fixes.
4898 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4899 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4900 Use ptrdiff_t, not int, for sizes.
4901 Don't increment bufsize until after realloc succeeds.
4902 Check for size-calculation overflow.
4903 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4905 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4907 * lread.c: Integer overflow fixes.
4908 (read_integer): Radix is now EMACS_INT, not int,
4909 to improve quality of diagnostics for out-of-range radices.
4910 Calculate buffer size correctly for out-of-range radices.
4911 (read1): Check for integer overflow in radices, and in
4912 read-circle numbers.
4913 (read_escape): Avoid int overflow.
4914 (Fload, openp, read_buffer_size, read1)
4915 (substitute_object_recurse, read_vector, read_list, map_obarray):
4916 Use ptrdiff_t, not int, for sizes.
4917 (read1): Use EMACS_INT, not int, for sizes.
4918 Check for size overflow.
4920 * image.c (cache_image): Check for size arithmetic overflow.
4922 * lread.c: Integer overflow issues.
4923 (saved_doc_string_size, saved_doc_string_length)
4924 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4925 Now ptrdiff_t, not int.
4926 (read1): Don't assume doc string length fits in int. Check for
4927 out-of-range doc string lengths.
4928 (read_list): Don't assume file position fits in int.
4929 (read_escape): Check for hex character overflow.
4931 2011-06-22 Leo Liu <sdl.web@gmail.com>
4933 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4934 Move to minibuffer.el.
4936 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4938 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4939 The following patches are for when GLYPH_DEBUG && !XASSERT.
4940 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4941 * dispnew.c (flush_stdout):
4942 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4943 Mark as externally visible.
4944 * dispnew.c (check_window_matrix_pointers): Now static.
4945 * dispnew.c (window_to_frame_vpos):
4946 * xfns.c (unwind_create_frame):
4947 * xterm.c (x_check_font): Remove unused local.
4948 * scroll.c (CHECK_BOUNDS):
4949 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4950 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4951 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4952 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4953 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4955 (debug_method_add): Use va_list and vsprintf rather than relying
4956 on undefined behavior with wrong number of arguments.
4957 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4958 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4959 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4960 since we're not interested in debugging glyphs with old libraries.
4961 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4962 GCC 4.6.0's static checking.
4964 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4966 Integer overflow and signedness fixes (Bug#8873).
4967 A few related buffer overrun fixes, too.
4969 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4971 * dispextern.h (struct face.stipple):
4972 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4973 (x_bitmap_mask, x_allocate_bitmap_record)
4974 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4975 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4976 (x_create_bitmap_from_xpm_data):
4977 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4978 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4980 * xfaces.c (load_pixmap):
4981 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4982 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4983 (.bitmaps_last, struct x_output.icon_bitmap):
4984 Use ptrdiff_t, not int, for bitmap indexes.
4985 (x_allocate_bitmap_record): Check for size overflow.
4986 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4988 Use ptrdiff_t, not int, for overlay counts.
4989 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4990 * editfns.c (overlays_around, get_pos_property):
4991 * textprop.c (get_char_property_and_overlay):
4992 * xdisp.c (next_overlay_change, note_mouse_highlight):
4993 * xfaces.c (face_at_buffer_position):
4994 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4995 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4996 (Fnext_overlay_change, Fprevious_overlay_change)
4997 (mouse_face_overlay_overlaps, Foverlays_in):
4998 Use ptrdiff_t, not int, for sizes.
4999 (overlays_at, overlays_in): Check for size-calculation overflow.
5001 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5003 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5004 (x_session_initialize): Do not assume string length fits in int.
5006 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5007 This is unlikely, but can occur if DPI is outlandish.
5009 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
5010 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5012 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5013 * xrdb.c (magic_file_p, search_magic_path):
5014 Omit last arg SUFFIX; it was always 0. All callers changed.
5015 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5017 * xfont.c (xfont_match): Avoid need for strlen.
5019 * xfns.c: Don't assume strlen fits in int.
5020 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5022 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5023 not unsigned long, as we prefer signed integers. All callers changed.
5024 Detect integer overflow in repeat count.
5025 (message_dolog): Don't assume print length fits in 39 bytes.
5026 (display_mode_element): Don't assume strlen fits in int.
5028 * termcap.c: Don't assume sizes fit in int and never overflow.
5029 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5030 (gobble_line): Check for size-calculation overflow.
5032 * minibuf.c (Fread_buffer):
5033 * lread.c (intern, intern_c_string):
5034 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5035 Don't assume string length fits in int.
5037 * keyboard.c (parse_tool_bar_item):
5038 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5040 * font.c: Don't assume string length fits in int.
5041 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5042 Use ptrdiff_t, not int.
5043 (font_intern_prop): Don't assume string length fits in int.
5044 Don't assume integer property fits in fixnum.
5045 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5047 * filelock.c: Fix some buffer overrun and integer overflow issues.
5048 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5049 Reformulate so as not to need the command string.
5050 Invoke gzip -cd rather than gunzip, as it's more portable.
5051 (lock_info_type, lock_file_1, lock_file):
5052 Don't assume pid_t and time_t fit in unsigned long.
5053 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5054 (current_lock_owner): Prefer signed type for sizes.
5055 Use memcpy, not strncpy, where memcpy is what is really wanted.
5056 Don't assume (via atoi) that time_t and pid_t fit in int.
5057 Check for time_t and/or pid_t out of range, e.g., via a network share.
5058 Don't alloca where an auto var works fine.
5060 * fileio.c: Fix some integer overflow issues.
5061 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5062 Don't assume string length fits in int.
5063 (directory_file_name): Don't assume string length fits in long.
5064 (make_temp_name): Don't assume pid fits in int, or that its print
5065 length is less than 20.
5067 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5069 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5071 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5073 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5074 We prefer signed integers, even for size calculations.
5076 * emacs.c: Don't assume string length fits in 'int'.
5077 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5078 (main): Don't invoke strlen when not needed.
5080 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5081 (XD_DEBUG_MESSAGE): Don't waste a byte.
5083 * callproc.c (getenv_internal_1, getenv_internal)
5085 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5087 * lread.c (invalid_syntax): Omit length argument.
5088 All uses changed. This doesn't fix a bug, but it simplifies the
5089 code away from its former Hollerith-constant appearance, and it's
5090 one less 'int' to worry about when looking at integer-overflow issues.
5091 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5093 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5094 This didn't break anything, but it didn't help either.
5095 It's confusing to put a bogus integer in a place where the actual
5096 value does not matter.
5097 (LIST_END_P): Remove unused macro and its bogus comment.
5098 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5100 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5101 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5103 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5104 We prefer signed types, and the value cannot exceed the EMACS_INT
5105 range anyway (because otherwise the length would not be representable).
5106 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5107 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5108 This avoids a GCC warning when WIDE_EMACS_INT.
5110 * indent.c (sane_tab_width): New function.
5111 (current_column, scan_for_column, Findent_to, position_indentation)
5112 (compute_motion): Use it. This is just for clarity.
5113 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5115 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5117 * lisp.h (lint_assume): New macro.
5118 * composite.c (composition_gstring_put_cache):
5119 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5121 * editfns.c, insdel.c:
5122 Omit unnecessary forward decls, to simplify future changes.
5124 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5126 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5128 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5129 Use much-faster test for byte-length change.
5130 Don't assume string byte-length fits in 'int'.
5131 Check that character arg fits in 'int'.
5132 (mapcar1): Declare byte as byte, for clarity.
5134 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5136 * fns.c (concat): Catch string overflow earlier.
5137 Do not rely on integer wraparound.
5139 * dispextern.h (struct it.overlay_strings_charpos)
5140 (struct it.selective): Now EMACS_INT, not int.
5141 * xdisp.c (forward_to_next_line_start)
5142 (back_to_previous_visible_line_start)
5143 (reseat_at_next_visible_line_start, next_element_from_buffer):
5144 Don't arbitrarily truncate the value of 'selective' to int.
5146 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5148 * composite.c: Don't truncate sizes to 'int'.
5149 (composition_gstring_p, composition_reseat_it)
5150 (composition_adjust_point): Use EMACS_INT, not int.
5151 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5152 not EMACS_UINT, for indexes.
5154 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5156 * buffer.c: Include <verify.h>.
5157 (struct sortvec.priority, struct sortstr.priority):
5158 Now EMACS_INT, not int.
5159 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5160 (struct sortstr.size, record_overlay_string)
5161 (struct sortstrlist.size, struct sortlist.used):
5162 Don't truncate size to int.
5163 (record_overlay_string): Check for size-calculation overflow.
5164 (init_buffer_once): Check at compile-time, not run-time.
5166 2011-06-22 Jim Meyering <meyering@redhat.com>
5168 Don't leak an XBM-image-sized buffer
5169 * image.c (xbm_load): Free the image buffer after using it.
5171 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5174 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5175 that Sun C diagnosed.
5176 * fns.c (secure_hash): Fix pointer signedness issue.
5177 * intervals.c (static_offset_intervals): New function.
5178 (offset_intervals): Use it.
5180 2011-06-21 Leo Liu <sdl.web@gmail.com>
5183 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5186 * fns.c (secure_hash): Rename from crypto_hash_function and change
5187 the first arg to accept symbols.
5188 (Fsecure_hash): New primitive.
5189 (syms_of_fns): New symbols.
5191 2011-06-20 Deniz Dogan <deniz@dogan.se>
5193 * process.c (Fset_process_buffer): Clarify return value in
5196 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5198 * dispnew.c (add_window_display_history): Use BVAR.
5200 * xdisp.c (debug_method_add): Use BVAR.
5201 (check_window_end, dump_glyph_matrix, dump_glyph)
5202 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5204 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5207 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5208 check till after the cache is created in init_frame_faces.
5210 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5212 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5214 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5216 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5217 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5218 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5220 Improve buffer-overflow checking (Bug#8873).
5221 * fileio.c (Finsert_file_contents):
5222 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5223 Remove the old (too-loose) buffer overflow checks.
5224 They weren't needed, since make_gap checks for buffer overflow.
5225 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5226 The old code merely checked for Emacs fixnum overflow, and relied
5227 on undefined (wraparound) behavior. The new code avoids undefined
5228 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5230 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5231 Tune. Don't use wider integers than needed. Don't use alloca.
5232 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5234 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5236 * insdel.c, lisp.h (buffer_overflow): New function.
5237 (insert_from_buffer_1, replace_range, replace_range_2):
5238 * insdel.c (make_gap_larger):
5239 * editfns.c (Finsert_char):
5240 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5242 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5244 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5246 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5248 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5249 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5251 * fileio.c: Don't assume EMACS_INT fits in off_t.
5252 (emacs_lseek): New static function.
5253 (Finsert_file_contents, Fwrite_region): Use it.
5254 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5256 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5258 * fns.c: Don't overflow int when computing a list length.
5259 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5260 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5261 truncation on 64-bit hosts. Check for QUIT every
5262 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5263 faster and is responsive enough.
5264 (Flength): Report an error instead of overflowing an integer.
5265 (Fsafe_length): Return a float if the value is not representable
5266 as a fixnum. This shouldn't happen except in contrived situations.
5267 (Fnthcdr, Fsort): Don't assume list length fits in int.
5268 (Fcopy_sequence): Don't assume vector length fits in int.
5270 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5271 (header_size, word_size): New constants.
5272 (allocate_vectorlike): Don't check size overflow here.
5273 (allocate_vector): Check it here instead, since this is the only
5274 caller of allocate_vectorlike that could cause overflow.
5275 Check that the new vector's length is representable as a fixnum.
5277 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5278 The previous code was bogus. For example, next_almost_prime (32)
5279 returned 39, which is undesirable as it is a multiple of 3; and
5280 next_almost_prime (24) returned 25, which is a multiple of 5 so
5281 why was the code bothering to check for multiples of 7?
5283 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5285 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5287 Variadic C functions now count arguments with ptrdiff_t.
5288 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5289 Back then I didn't know that the Emacs coding style prefers signed int.
5290 Also, in the meantime I found a few more instances where arguments
5291 were being counted with int, which may truncate counts on 64-bit
5292 machines, or EMACS_INT, which may be unnecessarily wide.
5293 * lisp.h (struct Lisp_Subr.function.aMANY)
5294 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5295 Arg counts are now ptrdiff_t, not size_t.
5296 All variadic functions and their callers changed accordingly.
5297 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5298 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5299 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5300 * callint.c (Fcall_interactively): Check arg count for overflow,
5301 to avoid potential buffer overrun. Use signed char, not 'int',
5302 for 'varies' array, so that we needn't bother to check its size
5303 calculation for overflow.
5304 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5305 * eval.c (apply_lambda):
5306 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5307 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5308 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5310 * callint.c (Fcall_interactively): Don't use index var as event count.
5312 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5313 * mem-limits.h (SIZE): Remove; no longer used.
5315 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5317 Remove unnecessary casts.
5318 * xterm.c (x_term_init):
5319 * xfns.c (x_set_border_pixel):
5320 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5321 These aren't needed now that we assume ANSI C.
5323 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5324 It's more likely to cause problems (due to unsigned overflow)
5327 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5329 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5331 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5333 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5335 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5337 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5339 GLYPH_CODE_FACE returns EMACS_INT, not int.
5340 * dispextern.h (merge_faces):
5341 * xfaces.c (merge_faces):
5342 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5343 Don't assume EMACS_INT fits in int.
5345 * character.h (CHAR_VALID_P): Remove unused parameter.
5346 * fontset.c, lisp.h, xdisp.c: All uses changed.
5348 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5350 * fns.c (concat): Minor tuning based on overflow analysis.
5351 This doesn't fix any bugs. Use int to hold character, instead
5352 of constantly refetching from Emacs object. Use XFASTINT, not
5353 XINT, for value known to be a character. Don't bother comparing
5354 a single byte to 0400, as it's always less.
5356 * floatfns.c (Fexpt):
5357 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5359 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5362 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5364 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5365 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5366 incorrectly succeed when S was a string, because 4294967386 was
5367 truncated before it was used.
5369 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5370 Otherwise, an out-of-range integer could cause undefined behavior
5373 * composite.c: Use int, not EMACS_INT, for characters.
5374 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5375 EMACS_INT, for values that are known to be in character range.
5376 This doesn't fix any bugs but is the usual style inside Emacs and
5377 may generate better code on 32-bit machines.
5379 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5380 This is for reasons similar to the recent CHAR_STRING fix.
5381 * charset.c (Fencode_char): Check that character arg is actually
5382 a character. Pass an int to ENCODE_CHAR.
5383 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5384 wider than 'int', as a compile-time check to prevent future regressions
5387 * character.c (char_string): Remove unnecessary casts.
5389 Make sure a 64-bit char is never passed to CHAR_STRING.
5390 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5391 by silently ignoring the top 32 bits, allowing some values
5392 that were far too large to be valid characters.
5393 * character.h: Include <verify.h>.
5394 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5395 arguments are no wider than unsigned, as a compile-time check
5396 to prevent future regressions in this area.
5398 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5399 (Fsubst_char_in_region):
5401 * xdisp.c (decode_mode_spec_coding):
5402 Adjust to CHAR_STRING's new requirement.
5403 * editfns.c (Finsert_char, Fsubst_char_in_region):
5404 * fns.c (concat): Check that character args are actually
5405 characters. Without this test, these functions did the wrong
5406 thing with wildly out-of-range values on 64-bit hosts.
5408 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5409 These casts should not be needed on 32-bit hosts, either.
5410 * keyboard.c (read_char):
5411 * lread.c (Fload): Remove casts to unsigned.
5413 * lisp.h (UNSIGNED_CMP): New macro.
5414 This fixes comparison bugs on 64-bit hosts.
5415 (ASCII_CHAR_P): Use it.
5416 * casefiddle.c (casify_object):
5417 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5418 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5419 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5420 * dispextern.h (FACE_FROM_ID):
5421 * keyboard.c (read_char): Use UNSIGNED_CMP.
5423 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5424 not to EMACS_INT, to avoid GCC warning.
5426 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5428 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5429 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5430 isn't needed on 32-bit machines.
5432 * buffer.c (Fgenerate_new_buffer_name):
5433 Use EMACS_INT for count, not int.
5434 (advance_to_char_boundary): Return EMACS_INT, not int.
5436 * data.c (Qcompiled_function): Now static.
5438 * window.c (window_body_lines): Now static.
5440 * image.c (gif_load): Rename local to avoid shadowing.
5442 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5443 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5444 * alloc.c (make_save_value): Integer argument is now of type
5446 (mark_object): Use ptrdiff_t, not int.
5447 * lisp.h (pD): New macro.
5448 * print.c (print_object): Use it.
5450 * alloc.c: Use EMACS_INT, not int, to count objects.
5451 (total_conses, total_markers, total_symbols, total_vector_size)
5452 (total_free_conses, total_free_markers, total_free_symbols)
5453 (total_free_floats, total_floats, total_free_intervals)
5454 (total_intervals, total_strings, total_free_strings):
5455 Now EMACS_INT, not int. All uses changed.
5456 (Fgarbage_collect): Compute overall total using a double, so that
5457 integer overflow is less likely to be a problem. Check for overflow
5458 when converting back to an integer.
5459 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5460 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5461 These were 'int' variables that could overflow on 64-bit hosts;
5462 they were never used, so remove them instead of repairing them.
5463 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5464 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5465 Previously, this ceilinged at INT_MAX, but that doesn't work on
5467 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5469 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5470 (allocate_vectorlike): Check for ptrdiff_t overflow.
5471 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5472 when a (possibly-narrower) signed value would do just as well.
5473 We prefer using signed arithmetic, to avoid comparison confusion.
5475 * alloc.c: Catch some string size overflows that we were missing.
5476 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5477 for convenience in STRING_BYTES_MAX.
5478 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5479 The definition here is exact; the one in lisp.h was approximate.
5480 (allocate_string_data): Check for string overflow. This catches
5481 some instances we weren't catching before. Also, it catches
5482 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5483 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5484 and ptrdiff_t and EMACS_INT are both 64 bits.
5486 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5487 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5488 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5490 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5492 * alloc.c (Fmake_string): Check for out-of-range init.
5494 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5496 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5498 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5500 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5501 xg_get_default_scrollbar_width.
5503 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5504 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5505 (style_changed_cb): Call update_theme_scrollbar_width and call
5506 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5507 all frames (Bug#8505).
5508 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5509 Call gtk_window_set_resizable if HAVE_GTK3.
5510 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5511 and height if HAVE_GTK3 (Bug#8505).
5512 (scroll_bar_width_for_theme): New variable.
5513 (update_theme_scrollbar_width): New function.
5514 (xg_get_default_scrollbar_width): Move code to
5515 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5516 (xg_initialize): Call update_theme_scrollbar_width.
5518 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5520 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5522 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5524 * frame.c (make_frame): Call other_buffer_safely instead of
5527 * window.c (temp_output_buffer_show): Call display_buffer with
5528 second argument Vtemp_buffer_show_specifiers and reset latter
5529 immediately after the call.
5530 (Vtemp_buffer_show_specifiers): New variable.
5531 (auto_window_vscroll_p, next_screen_context_lines)
5532 (Vscroll_preserve_screen_position): Remove leading asterisks from
5535 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5537 Fix minor problems found by GCC 4.6.0 static checking.
5538 * buffer.c (Qclone_number): Remove for now, as it's unused.
5539 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5540 (record_buffer): Remove unused local.
5541 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5542 (set_frame_buffer_list): Remove; unused.
5543 * frame.h (other_visible_frames): Remove decl.
5544 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5545 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5546 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5548 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5549 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5550 Define only if HAVE_GPM.
5551 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5552 (update_hints_inhibit): Remove; never set. All uses removed.
5553 * widgetprv.h (emacsFrameClassRec): Remove decl.
5554 * window.c (delete_deletable_window): Now returns void, since it
5555 wasn't returning anything.
5556 (compare_window_configurations): Remove unused locals.
5557 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5558 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5559 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5560 the same widths as pointers. This follows up on the 2011-05-06 patch.
5561 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5562 * xterm.h: Likewise.
5563 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5565 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5567 * makefile.w32-in: Update dependencies.
5568 (LISP_H): Add lib/intprops.h.
5570 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5572 * image.c (gif_load): Add animation frame delay to the metadata.
5573 (syms_of_image): Use DEFSYM. New symbol `delay'.
5575 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5577 * window.c (delete_deletable_window): Re-add.
5578 (Fset_window_configuration): Rewrite to handle dead buffers and
5579 consequently deletable windows.
5580 (window_tree, Fwindow_tree): Remove. Supply functionality in
5582 (compare_window_configurations): Simplify code.
5584 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5586 * image.c (imagemagick_load_image): Fix type mismatch.
5587 (Fimagemagick_types): Likewise.
5589 * window.h (replace_buffer_in_windows): Declare.
5591 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5593 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5594 Qclone_number. Remove external declaration of Qdelete_window.
5595 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5597 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5598 Run Qbuffer_list_update_hook if allowed.
5599 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5600 buffer list implementation.
5601 (other_buffer_safely): New function.
5602 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5603 calls to replace_buffer_in_windows and
5604 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5606 (record_buffer): Inhibit quitting and rewrite using quittable
5607 functions. Run Qbuffer_list_update_hook if allowed.
5608 (Frecord_buffer, Funrecord_buffer): New functions.
5609 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5610 Move switch-to-buffer to window.el.
5611 (bury-buffer): Move to window.el.
5612 (Vbuffer_list_update_hook): New variable.
5614 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5617 * window.h (resize_frame_windows): Move up in code.
5618 (Fwindow_frame): Remove EXFUN.
5619 (replace_buffer_in_all_windows): Remove prototype.
5620 (replace_buffer_in_windows_safely): Add prototype.
5622 * window.c: Declare Qdelete_window static again. Move down
5623 declaration of select_count.
5624 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5625 (Fother_window): Move to window.el.
5626 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5627 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5628 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5630 (replace_buffer_in_windows): Implement by calling
5631 Qreplace_buffer_in_windows.
5632 (replace_buffer_in_all_windows): Remove with some functionality
5633 moved into replace_buffer_in_windows_safely.
5634 (replace_buffer_in_windows_safely): New function.
5635 (select_window_norecord, select_frame_norecord): Move in front
5636 of run_window_configuration_change_hook. Remove now obsolete
5638 (Fset_window_buffer): Rewrite doc-string.
5639 Call Qrecord_window_buffer.
5640 (keys_of_window): Move binding for other-window to window.el.
5642 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5644 * dispextern.h (struct image): Replace data member, whose int_val
5645 and ptr_val fields were not used by anything, with a single
5648 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5649 (gif_clear_image, gif_load, imagemagick_load_image)
5650 (gs_clear_image, gs_load): Callers changed.
5652 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5654 * buffer.h: Include <time.h>, for time_t.
5655 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5657 Fix minor problems found by static checking.
5659 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5661 Make identifiers static if they are not used in other modules.
5662 * data.c (Qcompiled_function, Qframe, Qvector):
5663 * image.c (QimageMagick, Qsvg):
5664 * minibuf.c (Qmetadata):
5665 * window.c (resize_window_check, resize_root_window): Now static.
5666 * window.h (resize_window_check, resize_root_window): Remove decls.
5668 * window.c (window_deletion_count, delete_deletable_window):
5670 (window_body_lines): Now static.
5671 (Fdelete_other_windows_internal): Mark vars as initialized.
5672 Make sure 'resize_failed' is initialized.
5673 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5674 (resize_window_apply): Remove unused local.
5675 * window.h (delete_deletable_window): Remove decl.
5677 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5678 (imagemagick_load_image): Fix pointer signedness problem by changing
5679 last arg from unsigned char * to char *. All uses changed.
5680 Also, fix a local for similar reasons.
5681 Remove unused locals. Remove locals to avoid shadowing.
5682 (fn_rsvg_handle_free): Remove; unused.
5683 (svg_load, svg_load_image): Fix pointer signedness problem.
5684 (imagemagick_load_image): Don't use garbage pointer image_wand.
5686 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5688 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5690 * image.c (gif_load): Fix omitted cast error introduced by
5693 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5695 * window.h (resize_proportionally, orig_total_lines)
5696 (orig_top_line): Remove from window structure.
5697 (set_window_height, set_window_width, change_window_heights)
5698 (Fdelete_window): Remove prototypes.
5699 (resize_frame_windows): Remove duplicate declaration.
5701 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5703 * window.h (resize_frame_windows, resize_window_check)
5704 (delete_deletable_window, resize_root_window)
5705 (resize_frame_windows): Declare prototypes.
5707 * window.c (resize_window_apply): Make definition be "static" to
5708 match the prototype.
5710 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5712 * window.c: Remove declarations of Qwindow_size_fixed,
5713 window_min_size_1, window_min_size_2, window_min_size,
5714 size_window, window_fixed_size_p, enlarge_window, delete_window.
5715 Remove static from declaration of Qdelete_window, it's
5716 temporarily needed by Fbury_buffer.
5717 (replace_window): Don't assign orig_top_line and
5719 (Fdelete_window, delete_window): Remove. Window deletion is
5720 handled by window.el.
5721 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5722 Replace Fdelete_window calls with calls to Qdelete_window.
5723 (Fdelete_other_windows): Remove. Deleting other windows is
5724 handled by window.el.
5725 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5726 handled in window.el.
5727 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5728 Window minimum sizes are handled in window.el.
5729 (shrink_windows, size_window, set_window_height)
5730 (set_window_width, change_window_heights, window_height)
5731 (window_width, CURBEG, CURSIZE, enlarge_window)
5732 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5733 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5734 handled in window.el.
5735 (make_dummy_parent): Rename to make_parent_window and give it a
5736 second argument horflag.
5737 (make_window): Don't set resize_proportionally any more.
5738 (Fsplit_window): Remove. Windows are split in window.el.
5739 (save_restore_action, save_restore_orig_size)
5740 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5741 Resize mini windows in window.el.
5742 (grow_mini_window, shrink_mini_window): Implement by calling
5743 Qresize_root_window_vertically, resize_window_check and
5744 resize_window_apply.
5745 (saved_window, Fset_window_configuration, save_window_save):
5746 Do not handle orig_top_line, orig_total_lines, and
5747 resize_proportionally.
5748 (window_min_height, window_min_width): Move to window.el.
5749 (keys_of_window): Move bindings for delete-other-windows,
5750 split-window, delete-window and enlarge-window to window.el.
5752 * buffer.c: Temporarily extern Qdelete_window.
5753 (Fbury_buffer): Temporarily call Qdelete_window instead of
5754 Fdelete_window (Fbury_buffer will move to window.el soon).
5756 * frame.c (set_menu_bar_lines_1): Remove code handling
5757 orig_top_line and orig_total_lines.
5759 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5760 set_window_height but set heights directly.
5761 (change_frame_size_1): Use resize_frame_windows.
5763 * xdisp.c (init_xdisp): Don't use set_window_height but set
5766 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5767 Use resize_frame_windows instead of change_window_heights and run
5768 run_window_configuration_change_hook.
5770 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5771 instead of change_window_heights and run
5772 run_window_configuration_change_hook.
5774 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5776 * window.c (replace_window): Rename second argument REPLACEMENT to
5777 NEW. New third argument SETFLAG. Rewrite.
5778 (delete_window, make_dummy_parent): Call replace_window with
5780 (window_list_1): Move down in code.
5781 (run_window_configuration_change_hook): Move set_buffer part
5782 before select_frame_norecord part in order to unwind correctly.
5783 Rename count1 to count.
5784 (recombine_windows, delete_deletable_window, resize_root_window)
5785 (Fdelete_other_windows_internal)
5786 (Frun_window_configuration_change_hook, make_parent_window)
5787 (resize_window_check, resize_window_apply, Fresize_window_apply)
5788 (resize_frame_windows, Fsplit_window_internal)
5789 (Fdelete_window_internal, Fresize_mini_window_internal):
5791 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5793 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5795 * window.h (window): Add some new members to window structure -
5796 normal_lines, normal_cols, new_total, new_normal, clone_number,
5797 splits, nest, prev_buffers, next_buffers.
5798 (WINDOW_TOTAL_SIZE): Move here from window.c.
5799 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5801 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5803 (make_dummy_parent): Set new members of windows structure.
5804 (make_window): Move down in code. Handle new members of window
5806 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5807 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5808 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5809 (Fset_window_prev_buffers, Fwindow_next_buffers)
5810 (Fset_window_next_buffers, Fset_window_clone_number):
5812 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5813 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5815 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5816 Argument WINDOW can be now internal window too.
5817 (Fwindow_use_time): Move up in code.
5818 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5820 (Fset_window_configuration, saved_window)
5821 (Fcurrent_window_configuration, save_window_save): Handle new
5822 members of window structure.
5823 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5824 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5825 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5826 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5827 Qget_mru_window, Qresize_root_window,
5828 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5829 Qauto_buffer_name; staticpro them.
5831 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5833 * window.c (Fwindow_total_size, Fwindow_left_column)
5834 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5835 (Fwindow_list_1): New functions.
5836 (window_box_text_cols): Replace with window_body_cols.
5837 (Fwindow_width, Fscroll_left, Fscroll_right):
5838 Use window_body_cols instead of window_box_text_cols.
5839 (delete_window, Fset_window_configuration):
5840 Call delete_all_subwindows with window as argument.
5841 (delete_all_subwindows): Take a window as argument and not a
5843 (window_loop): Remove handling of GET_LRU_WINDOW and
5845 (Fget_lru_window, Fget_largest_window): Move to window.el.
5847 * window.h: Extern window_body_cols instead of
5848 window_box_text_cols. delete_all_subwindows now takes a
5849 Lisp_Object as argument.
5851 * indent.c (compute_motion, Fcompute_motion):
5852 Use window_body_cols instead of window_box_text_cols.
5854 * frame.c (delete_frame): Call delete_all_subwindows with root
5857 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5859 * fns.c (Fputhash): Document return value.
5861 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5863 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5865 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5867 Cons<->int and similar integer overflow fixes (Bug#8794).
5869 Check for overflow when converting integer to cons and back.
5870 * charset.c (Fdefine_charset_internal, Fdecode_char):
5871 Use cons_to_unsigned to catch overflow.
5872 (Fencode_char): Use INTEGER_TO_CONS.
5873 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5874 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5875 * data.c (long_to_cons, cons_to_long): Remove.
5876 (cons_to_unsigned, cons_to_signed): New functions.
5877 These signal an error for invalid or out-of-range values.
5878 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5879 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5880 * font.c (Ffont_variation_glyphs):
5881 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5882 * lisp.h: Include <intprops.h>.
5883 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5884 (cons_to_signed, cons_to_unsigned): New decls.
5885 (long_to_cons, cons_to_long): Remove decls.
5886 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5887 (Fprimitive_undo): Use CONS_TO_INTEGER.
5888 * xfns.c (Fx_window_property): Likewise.
5889 * xselect.c: Include <limits.h>.
5890 (x_own_selection, selection_data_to_lisp_data):
5891 Use INTEGER_TO_CONS.
5892 (x_handle_selection_request, x_handle_selection_clear)
5893 (x_get_foreign_selection, Fx_disown_selection_internal)
5894 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5895 (lisp_data_to_selection_data): Use cons_to_unsigned.
5896 (x_fill_property_data): Use cons_to_signed.
5897 Report values out of range.
5899 Check for buffer and string overflow more precisely.
5900 * buffer.h (BUF_BYTES_MAX): New macro.
5901 * lisp.h (STRING_BYTES_MAX): New macro.
5902 * alloc.c (Fmake_string):
5903 * character.c (string_escape_byte8):
5904 * coding.c (coding_alloc_by_realloc):
5905 * doprnt.c (doprnt):
5906 * editfns.c (Fformat):
5908 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5909 since they may not be the same number.
5910 * editfns.c (Finsert_char):
5911 * fileio.c (Finsert_file_contents):
5912 Likewise for BUF_BYTES_MAX.
5914 * image.c: Use ptrdiff_t, not int, for sizes.
5915 (slurp_file): Switch from int to ptrdiff_t.
5917 (slurp_file): Check that file size fits in both size_t (for
5918 malloc) and ptrdiff_t (for sanity and safety).
5920 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5921 if b->modtime has its maximal value.
5923 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5925 Don't assume time_t can fit into int.
5926 * buffer.h (struct buffer.modtime): Now time_t, not int.
5927 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5928 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5930 Minor fixes for signed vs unsigned integers.
5931 * character.h (MAYBE_UNIFY_CHAR):
5932 * charset.c (maybe_unify_char):
5933 * keyboard.c (read_char, reorder_modifiers):
5934 XINT -> XFASTINT, since the integer must be nonnegative.
5935 * ftfont.c (ftfont_spec_pattern):
5936 * keymap.c (access_keymap, silly_event_symbol_error):
5937 XUINT -> XFASTINT, since the integer must be nonnegative.
5938 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5939 since it makes no difference and we prefer signed.
5940 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5941 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5944 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5946 * window.h (Fwindow_frame): Declare.
5948 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5950 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5951 (SPARE_MEMORY): Always define.
5952 (LARGE_REQUEST): Remove.
5953 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5955 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5957 * lisp.h: Move EXFUNS for Fframe_root_window,
5958 Fframe_first_window and Fset_frame_selected_window to window.h.
5960 * window.h: Move EXFUNS for Fframe_root_window,
5961 Fframe_first_window and Fset_frame_selected_window here from
5964 * frame.c (Fwindow_frame, Fframe_first_window)
5965 (Fframe_root_window, Fframe_selected_window)
5966 (Fset_frame_selected_window): Move to window.c.
5967 (Factive_minibuffer_window): Move to minibuf.c.
5968 (Fother_visible_frames_p): New function.
5970 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5972 * window.c (decode_window, decode_any_window): Move up in code.
5973 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5974 (inhibit_frame_unsplittable): Remove unused variable.
5975 (Fwindow_buffer): Move up and rewrite doc-string.
5976 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5977 (Fwindow_prev): New functions.
5978 (Fwindow_frame): Move here from frame.c. Accept any window as
5980 (Fframe_root_window, Fframe_first_window)
5981 (Fframe_selected_window): Move here from frame.c. Accept frame
5982 or arbitrary window as argument. Update doc-strings.
5983 (Fminibuffer_window): Move up in code.
5984 (Fwindow_minibuffer_p): Move up in code and simplify.
5985 (Fset_frame_selected_window): Move here from frame.c.
5987 (Fselected_window, select_window, Fselect_window): Move up in
5988 code. Minor doc-string fixes.
5990 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5992 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5993 Do not assume that spare memory exists; that assumption is valid
5994 only if SYSTEM_MALLOC.
5995 (LARGE_REQUEST): New macro, so that the issue of large requests
5996 is separated from the issue of spare memory.
5998 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6000 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6003 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6005 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6008 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6010 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6012 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6014 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6015 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6017 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
6019 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6021 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
6023 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6024 (x_clipboard_manager_save): Add return value.
6025 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6027 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6028 Obey Vx_select_enable_clipboard_manager. Catch errors in
6029 x_clipboard_manager_save (Bug#8779).
6030 (Vx_select_enable_clipboard_manager): New variable.
6031 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
6033 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
6035 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6037 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6039 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6040 in the current matrix if keep_current_p is non-zero.
6042 2011-06-04 Eli Zaretskii <eliz@gnu.org>
6044 * bidi.c (bidi_level_of_next_char): Fix last change.
6046 2011-06-03 Eli Zaretskii <eliz@gnu.org>
6048 Support bidi reordering of text covered by display properties.
6050 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6051 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6052 (bidi_cache_search, bidi_cache_iterator_state)
6053 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6054 (bidi_level_of_next_char, bidi_move_to_visually_next):
6055 Support character positions inside a run of characters covered by a
6057 (bidi_paragraph_init, bidi_resolve_explicit_1)
6058 (bidi_level_of_next_char): Call bidi_fetch_char and
6059 bidi_fetch_char_advance instead of FETCH_CHAR and
6061 (bidi_init_it): Initialize new members.
6062 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6064 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6065 instead of using explicit *_CHAR codes.
6066 (bidi_resolve_explicit, bidi_resolve_weak):
6067 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6068 bidirectional text is supported only in multibyte buffers.
6069 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6070 it to initialize the frame_window_p member of struct bidi_it.
6071 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6072 (bidi_resolve_explicit, bidi_resolve_weak)
6073 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6074 bidi_it->nchars is non-positive.
6075 (bidi_level_of_next_char): Don't try to lookup the cache for the
6076 next/previous character if nothing is cached there yet, or if we
6077 were just reseat()'ed to a new position.
6079 * xdisp.c (set_cursor_from_row): Set start and stop points
6080 according to the row's direction when priming the loop that looks
6081 for the glyph on which to display cursor.
6082 (single_display_spec_intangible_p): Function deleted.
6083 (display_prop_intangible_p): Reimplement to call
6084 handle_display_spec instead of single_display_spec_intangible_p.
6085 Accept 3 additional arguments needed by handle_display_spec.
6086 This fixes incorrect cursor motion across display property with complex
6087 values: lists, `(when COND...)' forms, etc.
6088 (single_display_spec_string_p): Support property values that are
6089 lists with the argument STRING its top-level element.
6090 (display_prop_string_p): Fix the condition for processing a
6091 property that is a list to be consistent with handle_display_spec.
6092 (handle_display_spec): New function, refactored from the
6093 last portion of handle_display_prop.
6094 (compute_display_string_pos): Accept additional argument
6095 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6096 value of a `display' property is a "replacing spec".
6097 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6098 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6099 the display property, but just return a value indicating whether
6100 the display property will replace the characters it covers.
6101 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6102 frame_window_p members of struct bidi_it.
6103 (compute_display_string_pos, compute_display_string_end):
6105 (push_it): Accept second argument POSITION, where pop_it should
6106 jump to continue iteration.
6107 (reseat_1): Initialize bidi_it.disp_pos.
6109 * keyboard.c (adjust_point_for_property): Adjust the call to
6110 display_prop_intangible_p to its new signature.
6112 * dispextern.h (struct bidi_it): New member frame_window_p.
6113 (bidi_init_it): Update prototypes.
6114 (display_prop_intangible_p): Update prototype.
6115 (compute_display_string_pos, compute_display_string_end):
6117 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6120 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6122 Malloc failure behavior now depends on size of allocation.
6123 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6124 * lisp.h: Change signatures accordingly.
6125 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6126 All callers changed. (Bug#8762)
6128 * gnutls.c: Use Emacs's memory allocators.
6129 Without this change, the gnutls library would invoke malloc etc.
6130 directly, which causes problems on non-SYNC_INPUT hosts, and which
6131 runs afoul of improving memory_full behavior. (Bug#8761)
6132 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6133 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6134 xfree instead of the default malloc, realloc, free.
6135 (Fgnutls_boot): No need to check for memory allocation failure,
6136 since xmalloc does that for us.
6138 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6139 * category.c (hash_get_category_set):
6140 * ccl.c (ccl_driver):
6141 * charset.c (Fdefine_charset_internal):
6142 * charset.h (struct charset.hash_index):
6143 * composite.c (get_composition_id, gstring_lookup_cache)
6144 (composition_gstring_put_cache):
6145 * composite.h (struct composition.hash_index):
6146 * dispextern.h (struct image.hash):
6147 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6148 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6149 (hashfn_equal, hashfn_user_defined, make_hash_table)
6150 (maybe_resize_hash_table, hash_lookup, hash_put)
6151 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6152 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6153 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6154 * image.c (make_image, search_image_cache, lookup_image)
6155 (xpm_put_color_table_h):
6156 * lisp.h (struct Lisp_Hash_Table):
6157 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6158 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6159 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6160 * alloc.c (allocate_vectorlike):
6161 Check for overflow in vector size calculations.
6162 * ccl.c (ccl_driver):
6163 Check for overflow when converting EMACS_INT to int.
6164 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6165 need to be updated by these changes.
6166 * fns.c (make_hash_table, maybe_resize_hash_table):
6167 Check for integer overflow with large hash tables.
6168 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6169 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6170 (SXHASH_REDUCE): New macro.
6171 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6172 Use it instead of discarding useful hash info with large hash values.
6173 (sxhash_float): New function.
6174 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6175 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6176 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6177 Rewrite to use FIXNUM_BITS, as this simplifies things.
6178 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6179 Adjust signatures to match updated version of code.
6180 (consing_since_gc): Now EMACS_INT, since a single hash table can
6181 use more than INT_MAX bytes.
6183 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6185 Make it possible to build with GCC-4.6+ -O2 -flto.
6187 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6189 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6191 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6192 Call minibuffer-inactive-mode.
6194 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6196 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6197 Update dependencies.
6199 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6201 * data.c (init_data): Remove code for UTS, this system is not
6204 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6206 Don't force ./temacs to start in terminal mode.
6208 * frame.c (make_initial_frame): Initialize faces in all cases, not
6209 only when CANNOT_DUMP is defined.
6210 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6212 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6214 * dispnew.c (add_window_display_history): Use const for the string
6215 pointer. Remove declaration, not needed.
6217 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6219 Use 'inline', not 'INLINE'.
6220 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6221 * alloc.c, fontset.c (INLINE): Remove.
6222 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6223 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6224 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6225 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6226 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6228 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6230 Make it possible to run ./temacs.
6232 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6233 syms_of_callproc does the same thing. Remove test for
6234 "initialized", do it in the caller.
6235 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6237 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6239 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6240 (read_minibuf): Use get_minibuffer.
6241 (syms_of_minibuf): Use DEFSYM.
6242 (Qmetadata): New var.
6243 * data.c (Qbuffer): Don't make it static.
6244 (syms_of_data): Use DEFSYM.
6246 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6248 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6249 (CCL_CODE_MIN): New macro.
6251 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6253 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6255 * eval.c (Qdebug): Now static.
6256 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6257 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6258 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6260 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6262 * image.c: Various fixes to ImageMagick code comments.
6263 (Fimagemagick_types): Doc fix.
6265 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6267 Minor fixes prompted by GCC 4.6.0 warnings.
6269 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6271 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6272 (x_clipboard_manager_save_all): Move extern decl to ...
6273 * xterm.h: ... here, so that it can be checked for consistency.
6275 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6277 * xselect.c (x_clipboard_manager_save_frame)
6278 (x_clipboard_manager_save_all): New functions.
6279 (Fx_clipboard_manager_save): Lisp function deleted.
6281 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6282 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6284 * xterm.h: Update prototype.
6286 2011-05-28 William Xu <william.xwl@gmail.com>
6288 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6291 2011-05-28 Jim Meyering <meyering@redhat.com>
6293 Avoid a sign-extension bug in crypto_hash_function.
6294 * fns.c (to_uchar): Define.
6295 (crypto_hash_function): Use it to convert some newly-signed
6296 variables to unsigned, to avoid sign-extension bugs. For example,
6297 without this change, (md5 "truc") would evaluate to
6298 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6299 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6300 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6302 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6304 Integer overflow fixes.
6306 * dbusbind.c: Serial number integer overflow fixes.
6307 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6308 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6309 to hold a serial number that is too large for a fixnum.
6310 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6311 Check for serial numbers out of range. Decode any serial number
6312 that was so large that it became a float. (Bug#8722)
6314 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6315 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6316 Use XFASTINT rather than XUINT when numbers are nonnegative.
6317 (xd_append_arg, Fdbus_method_return_internal):
6318 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6319 arguments, check that Lisp number is nonnegative, rather than
6320 silently wrapping negative numbers around. (Bug#8722)
6321 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6324 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6326 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6328 ccl: Add integer overflow checks.
6329 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6330 (IN_INT_RANGE): New macros.
6331 (ccl_driver): Use them to check for integer overflow when
6332 decoding a CCL program. Many of the new checks are whether XINT (x)
6333 fits in int; it doesn't always, on 64-bit hosts. The new version
6334 doesn't catch all possible integer overflows, but it's an
6335 improvement. (Bug#8719)
6337 * alloc.c (make_event_array): Use XINT, not XUINT.
6338 There's no need for unsigned here.
6340 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6341 This follows up to the 2011-05-06 change that substituted uintptr_t
6342 for EMACS_INT. This case wasn't caught back then.
6344 Rework Fformat to avoid integer overflow issues.
6345 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6346 now (part of C89). Include <verify.h>.
6347 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6348 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6349 (Fformat): Avoid the prepass trying to compute sizes; it was only
6350 approximate and thus did not catch overflow reliably. Instead, walk
6351 through the format just once, formatting and computing sizes as we go,
6352 checking for integer overflow at every step, and allocating a larger
6353 buffer as needed. Keep track separately whether the format is
6354 multibyte. Keep only the most-recently calculated precision, rather
6355 than them all. Record whether each argument has been converted to
6356 string. Use EMACS_INT, not int, for byte and char and arg counts.
6357 Support field widths and precisions larger than INT_MAX. Avoid
6358 sprintf's undefined behavior with conversion specifications such as %#d
6359 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6360 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6361 formatting out-of-range floating point numbers with int
6364 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6366 * data.c: Avoid integer truncation in expressions involving floats.
6367 * data.c: Include <intprops.h>.
6368 (arith_driver): When there's an integer overflow in an expression
6369 involving floating point, convert the integers to floating point
6370 so that the resulting value does not suffer from catastrophic
6371 integer truncation. For example, on a 64-bit host (* 4
6372 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6373 Do not rely on undefined behavior after integer overflow.
6375 merge count_size_as_multibyte, parse_str_to_multibyte
6376 * character.c, character.h (count_size_as_multibyte):
6377 Rename from parse_str_to_multibyte; all uses changed.
6378 Check for integer overflow.
6379 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6380 since it's now a duplicate of the other. This is more of
6381 a character than a buffer op, so better that it's in character.c.
6382 * fns.c, print.c: Adjust to above changes.
6384 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6386 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6388 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6390 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6391 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6392 (x_clipboard_manager_save): Now static.
6393 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6395 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6396 (crypto_hash_function): Now static.
6397 Fix pointer signedness problems. Avoid unnecessary initializations.
6399 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6401 * termhooks.h (Vselection_alist): Make it terminal-local.
6403 * terminal.c (create_terminal): Initialize it.
6405 * xselect.c: Support for clipboard managers.
6406 (Vselection_alist): Move to termhooks.h as terminal-local var.
6407 (LOCAL_SELECTION): New macro.
6408 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6409 (symbol_to_x_atom): Remove gratuitous arg.
6410 (x_handle_selection_request, lisp_data_to_selection_data)
6411 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6412 (x_own_selection, x_get_local_selection, x_convert_selection):
6413 New arg, specifying work frame. Use terminal-local Vselection_alist.
6414 (some_frame_on_display): Delete unused function.
6415 (Fx_own_selection_internal, Fx_get_selection_internal)
6416 (Fx_disown_selection_internal, Fx_selection_owner_p)
6417 (Fx_selection_exists_p): New optional frame arg.
6418 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6419 (x_handle_selection_clear): Don't treat other terminals with the
6420 same keyboard specially. Use the terminal-local Vselection_alist.
6421 (x_clear_frame_selections): Use Frun_hook_with_args.
6423 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6425 * xterm.h: Add support for those atoms.
6427 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6429 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6430 (converted_selections, conversion_fail_tag): New global variables.
6431 (x_selection_request_lisp_error): Free the above.
6432 (x_get_local_selection): Remove unnecessary code.
6433 (x_reply_selection_request): Args changed; handle arbitrary array
6434 of converted selections stored in converted_selections.
6435 Separate the XChangeProperty and SelectionNotify steps.
6436 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6437 (x_convert_selection): New function.
6438 (x_handle_selection_event): Simplify.
6439 (x_get_foreign_selection): Don't ignore incoming requests while
6440 waiting for an answer; this will fail when we implement
6441 SAVE_TARGETS, and seems unnecessary anyway.
6442 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6443 (Vx_sent_selection_functions): Doc fix.
6445 2011-05-26 Leo Liu <sdl.web@gmail.com>
6447 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6449 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6451 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6453 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6454 for fringe update if it has periodic bitmap.
6455 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6456 and fringe_bitmap_periodic_p.
6458 * fringe.c (get_fringe_bitmap_data): New function.
6459 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6460 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6461 row. Mark glyph row for fringe update if periodicity changed.
6463 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6464 for fringe update unless it has periodic bitmap.
6466 2011-05-25 Kenichi Handa <handa@m17n.org>
6468 * xdisp.c (get_next_display_element): Set correct it->face_id for
6469 a static composition.
6471 2011-05-24 Leo Liu <sdl.web@gmail.com>
6474 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6476 * fns.c (crypto_hash_function, Fsha1): New function.
6477 (Fmd5): Use crypto_hash_function.
6478 (syms_of_fns): Add Ssha1.
6480 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6482 * gnutls.c: Remove unused macros.
6483 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6484 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6485 Remove macros that are defined and never used.
6486 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6488 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6490 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6491 (Fx_get_selection_internal): Minor cleanup.
6492 (Fx_own_selection_internal): Rename arguments for consistency with
6495 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6497 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6499 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6501 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6503 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6505 * dispnew.c (scrolling_window): Don't exclude the case that the
6506 last enabled row in the desired matrix touches the bottom boundary.
6508 2011-05-21 Glenn Morris <rgm@gnu.org>
6510 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6511 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6512 and add some more files.
6514 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6516 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6517 report_file_error introduced by the change from 2011-05-07.
6519 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6521 * systime.h (Time): Define only if emacs is defined.
6522 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6523 where the include path doesn't have X11/X.h by default. See
6524 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6526 2011-05-20 Kenichi Handa <handa@m17n.org>
6528 * composite.c (find_automatic_composition): Fix previous change.
6530 2011-05-20 Glenn Morris <rgm@gnu.org>
6532 * lisp.mk: New file, split from Makefile.in.
6533 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6534 (shortlisp): Remove.
6535 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6537 2011-05-19 Glenn Morris <rgm@gnu.org>
6539 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6540 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6541 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6542 (lisp): Set the order to that of loadup.el.
6543 (shortlisp): Make it a copy of $lisp.
6544 (SOME_MACHINE_LISP): Remove.
6545 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6546 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6548 2011-05-18 Kenichi Handa <handa@m17n.org>
6550 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6551 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6552 (find_automatic_composition): Mostly rewrite for efficiency.
6554 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6556 * makefile.w32-in: Update dependencies.
6558 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6560 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6561 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6563 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6565 Fix some integer overflow issues, such as string length overflow.
6567 * insdel.c (count_size_as_multibyte): Check for string overflow.
6569 * character.c (lisp_string_width): Check for string overflow.
6570 Use EMACS_INT, not int, for string indexes and lengths; in
6571 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6572 the resulting string length overflows an EMACS_INT; instead,
6573 report a string overflow if no precision given. When checking for
6574 precision exhaustion, use a check that cannot possibly have
6575 integer overflow. (Bug#8675)
6576 * character.h (lisp_string_width): Adjust to new signature.
6578 * alloc.c (string_overflow): New function.
6579 (Fmake_string): Use it. This doesn't change behavior, but saves
6580 a few bytes and will simplify future changes.
6581 * character.c (string_escape_byte8): Likewise.
6582 * lisp.h (string_overflow): New decl.
6584 Fixups, following up to the user-interface timestamp change.
6585 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6586 for UI timestamps, instead of unsigned long.
6587 * msdos.c (mouse_get_pos): Likewise.
6588 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6589 * w32gui.h (Time): Define by including "systime.h" rather than by
6590 declaring it ourselves. (Bug#8664)
6592 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6593 * image.c (clear_image_cache): Likewise.
6595 * term.c (term_mouse_position): Don't assume time_t wraparound.
6597 Be more systematic about user-interface timestamps.
6598 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6599 and sometimes 'EMACS_UINT', to represent these timestamps.
6600 This change causes it to use 'Time' uniformly, as that's what X uses.
6601 This makes the code easier to follow, and makes it easier to catch
6602 integer overflow bugs such as Bug#8664.
6603 * frame.c (Fmouse_position, Fmouse_pixel_position):
6604 Use Time, not unsigned long, for user-interface timestamps.
6605 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6606 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6607 * keyboard.h (last_event_timestamp): Likewise.
6608 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6609 * menu.h (xmenu_show): Likewise.
6610 * term.c (term_mouse_position): Likewise.
6611 * termhooks.h (struct input_event.timestamp): Likewise.
6612 (struct terminal.mouse_position_hook): Likewise.
6613 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6614 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6615 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6616 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6618 * menu.h, termhooks.h: Include "systime.h", for Time.
6620 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6621 Don't assume that the difference between two unsigned long values
6622 can fit into an integer. At this point, we know button_down_time
6623 <= event->timestamp, so the difference must be nonnegative, so
6624 there's no need to cast the result if double-click-time is
6625 nonnegative, as it should be; check that it's nonnegative, just in
6626 case. This bug is triggered when events are more than 2**31 ms
6627 apart (about 25 days). (Bug#8664)
6629 * xselect.c (last_event_timestamp): Remove duplicate decl.
6630 (x_own_selection): Remove needless cast to unsigned long.
6632 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6633 that always fit in int. Use a sentinel instead of a counter, to
6634 avoid a temp and to allay GCC's concerns about possible int overflow.
6635 * frame.h (struct frame): Use int for menu_bar_items_used
6636 instead of EMACS_INT, since it always fits in int.
6638 * menu.c (grow_menu_items): Check for int overflow.
6640 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6642 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6643 Before, the code was not consistent. These values cannot exceed
6644 2**31 - 1 so there's no need to make them unsigned.
6645 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6646 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6647 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6649 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6651 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6652 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6653 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6654 presumably because the widths might not match.
6656 * window.c (size_window): Avoid needless test at loop start.
6658 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6660 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6662 2011-05-12 Drew Adams <drew.adams@oracle.com>
6664 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6666 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6668 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6669 `width' to `bar_area_x' and `bar_area_width', respectively.
6670 (x_scroll_run): Take account of fringe background extension.
6672 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6673 Rename local vars `left' and `width' to `bar_area_x' and
6674 `bar_area_width', respectively.
6675 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6676 background extension.
6678 2011-05-10 Jim Meyering <meyering@redhat.com>
6680 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6682 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6684 * image.c (Finit_image_library): Return t for built-in image types,
6685 like pbm and xbm. (Bug#8640)
6687 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6689 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6691 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6693 * w32console.c (Fset_screen_color): Doc fix.
6694 (Fget_screen_color): New function.
6695 (syms_of_ntterm): Defsubr it.
6697 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6698 unlink the temporary file if Fcall_process didn't create it in the
6700 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6701 child process will be redirected to a file specified with `:file'.
6702 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6703 cue to call_process_cleanup not to close that handle.
6705 2011-05-07 Ben Key <bkey76@gmail.com>
6707 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6708 one of two shell specific rules, either bootstrap-temacs-CMD or
6709 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6710 to the previous implementation of the bootstrap-temacs rule.
6711 The bootstrap-temacs-CMD rule is similar to the previous
6712 implementation of the bootstrap-temacs rule except that it
6713 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6716 These changes, along with some changes to nt/configure.bat,
6717 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6718 earlier fix to add support for --cflags and --ldflags options
6719 that include quotes so that it works whether make uses cmd or
6722 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6724 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6725 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6727 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6728 a string. Handle both cases.
6729 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6730 (Fdbus_register_method): Use Qinvalid_function.
6732 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6734 * makefile.w32-in: Update dependencies.
6735 (LISP_H): Add inttypes.h and stdin.h.
6736 (PROCESS_H): Add unistd.h.
6738 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6740 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6741 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6743 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6745 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6747 * term.c (vfatal): Remove stray call to va_end.
6748 It's not needed and the C Standard doesn't allow it here anyway.
6750 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6751 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6753 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6756 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6758 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6760 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6762 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6764 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6766 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6767 * charset.c (Fdefine_charset_internal): Don't initialize
6768 charset.code_space[15]. The value was garbage, on hosts with
6769 32-bit int (Bug#8600).
6771 * lread.c (read_integer): Be more consistent with string-to-number.
6772 Use string_to_number to do the actual conversion; this avoids
6773 rounding errors and fixes some other screwups. Without this fix,
6774 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6775 (digit_to_number): Move earlier, for benefit of read_integer.
6776 Return -1 if the digit is out of range for the base, -2 if it is
6777 not a digit in any supported base. (Bug#8602)
6779 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6781 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6782 to match comment at start of function. This also removes a
6783 GCC warning about overflow in a 32+64-bit port.
6785 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6787 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6788 Reported by Stefan Monnier in
6789 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6790 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6791 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6793 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6794 (EMACS_UINTPTR): Likewise, with uintptr_t.
6796 * lisp.h: Prefer 64-bit EMACS_INT if available.
6797 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6798 on 32-bit hosts that have 64-bit int, so that they can access
6800 However, temporarily disable this change unless the temporary
6801 symbol WIDE_EMACS_INT is defined.
6803 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6805 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6806 This removes an assumption that EMACS_INT and long are the same
6807 width as pointers. The assumption is true for Emacs porting targets
6808 now, but we want to make other targets possible.
6809 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6810 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6811 In the rest of the code, change types of integers that hold casted
6812 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6813 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6814 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6815 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6816 No need to cast type when ORing.
6817 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6818 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6819 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6820 assume EMACS_INT is the same width as char *.
6821 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6822 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6823 Remove no-longer-needed casts.
6824 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6825 (xg_tool_bar_help_callback, xg_make_tool_item):
6826 Use EMACS_INTPTR to hold an integer
6827 that will be cast to void *; this can avoid a GCC warning
6828 if EMACS_INT is not the same width as void *.
6829 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6830 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6831 (current_message_1, set_message_1):
6832 Use a local to convert to proper width without a cast.
6833 * xmenu.c (dialog_selection_callback): Likewise.
6835 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6836 Also, don't assume VALBITS / RAND_BITS is less than 5,
6837 and don't rely on undefined behavior when shifting a 1 left into
6839 * lisp.h (get_random): Change signature to match.
6841 * lread.c (hash_string): Use size_t, not int, for hash computation.
6842 Normally we prefer signed values; but hashing is special, because
6843 it's better to use unsigned division on hash table sizes so that
6844 the remainder is nonnegative. Also, size_t is the natural width
6845 for hashing into memory. The previous code used 'int', which doesn't
6846 retain enough info to hash well into very large tables.
6847 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6849 * dbusbind.c: Don't possibly lose pointer info when converting.
6850 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6851 Use XPNTR rather than XHASH, so that the high-order bits of
6852 the pointer aren't lost when converting through void *.
6854 * eval.c (Fautoload): Don't double-shift a pointer.
6856 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6858 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6860 * gnutls.c (DEF_GNUTLS_FN):
6861 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6863 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6865 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6868 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6870 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6871 New version that can reserve upto 2GB of heap space.
6873 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6875 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6877 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6879 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6880 `gnutls_certificate_set_x509_key_file'.
6882 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6884 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6885 Update dependencies.
6887 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6889 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6890 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6891 Remove unused parameter `fildes'.
6892 * process.c (read_process_output, send_process): Don't pass it.
6894 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6896 Fix previous change: the library cache is defined in w32.c.
6897 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6898 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6900 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6902 Implement dynamic loading of GnuTLS on Windows.
6904 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6905 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6906 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6909 * gnutls.c (Qgnutls_dll): Define.
6910 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6911 (gnutls_*): Declare function pointers.
6912 (init_gnutls_functions): New function to initialize function pointers.
6913 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6914 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6915 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6916 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6917 (emacs_gnutls_write, emacs_gnutls_read)
6918 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6919 (Fgnutls_available_p): New function.
6920 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6921 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6922 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6924 * image.c: Include w32.h.
6925 (Vimage_type_cache): Delete.
6926 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6927 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6928 (w32_delayed_load): Move to w32.c.
6930 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6932 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6933 (w32_delayed_load): Move from image.c. When loading a library, record
6934 its filename in the :loaded-from property of the library id.
6935 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6936 Initialize and staticpro them.
6937 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6939 * process.c: Include lisp.h before w32.h, not after.
6940 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6941 instead of gnutls_record_check_pending.
6943 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6945 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6947 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6948 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6951 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6953 * xterm.c (x_set_frame_alpha): Do not set property on anything
6954 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6956 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6958 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6960 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6962 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6963 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6964 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6965 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6966 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6967 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6968 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6969 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6970 (Qgnutls_bootprop_callbacks_verify): Make static.
6972 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6974 * callproc.c: Indentation fixup.
6976 * sysdep.c (wait_for_termination_1): Make static.
6977 (wait_for_termination, interruptible_wait_for_termination):
6978 Move after wait_for_termination_1.
6980 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6982 * sysdep.c (interruptible_wait_for_termination): New function
6983 which is like wait_for_termination, but allows keyboard
6986 * callproc.c (Fcall_process): Add (:file "file") as an option for
6988 (Fcall_process_region): Ditto.
6990 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6992 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6993 rather than `XVECTOR (FOO)->size'.
6995 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6996 inttypes.h, as a gnulib replacement is used if it not available in
6999 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7001 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7002 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7003 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7005 * coding.c (coding_alloc_by_realloc): Error out if destination
7006 will grow beyond MOST_POSITIVE_FIXNUM.
7007 (decode_coding_emacs_mule): Abort if there isn't enough place in
7008 charbuf for the composition carryover bytes. Reserve an extra
7009 space for up to 2 characters produced in a loop.
7010 (decode_coding_iso_2022): Abort if there isn't enough place in
7011 charbuf for the composition carryover bytes.
7013 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7015 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7016 aborting when %lld or %lll format is passed.
7017 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7018 %llo or %llx format is passed. (Bug#8545)
7020 * window.c (window_scroll_line_based): Use a marker instead of
7021 simple variables to record original value of point. (Bug#7952)
7023 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7024 produced by %s or %c overflows available buffer space. (Bug#8545)
7026 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7028 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
7029 (SIZE_MAX): Move defn after all includes, as they might #define it.
7031 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7033 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7035 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7037 * keyboard.c (Qdelayed_warnings_hook): Define.
7038 (command_loop_1): Run `delayed-warnings-hook'
7039 if Vdelayed_warnings_list is non-nil.
7040 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7041 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7043 2011-04-28 Eli Zaretskii <eliz@gnu.org>
7045 * doprnt.c (doprnt): Don't return value smaller than the buffer
7046 size if the message was truncated. (Bug#8545).
7048 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7050 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7051 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7053 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7055 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7057 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7059 * makefile.w32-in: Update dependencies.
7061 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7063 Improve `doprnt' and its usage. (Bug#8545)
7064 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7065 `format_end'. Remove support for %l as a conversion specifier.
7066 Don't use xrealloc. Improve diagnostics when the %l size modifier
7067 is used. Update the commentary.
7069 * eval.c (verror): Simplify calculation of size_t.
7071 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7074 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7076 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7079 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7081 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7082 This makes this file independent of the recent pseudovector change.
7084 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7086 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7088 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7089 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7090 Remove unused local.
7091 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7093 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7094 GCC 4.6.0 optimizes based on type-based alias analysis.
7095 For example, if b is of type struct buffer * and v of type struct
7096 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7097 != &v->size, and therefore "v->size = 1; b->size = 2; return
7098 v->size;" must therefore return 1. This assumption is incorrect
7099 for Emacs, since it type-puns struct Lisp_Vector * with many other
7100 types. To fix this problem, this patch adds a new type struct
7101 vectorlike_header that documents the constraints on layout of vectors
7102 and pseudovectors, and helps optimizing compilers not get fooled
7103 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7104 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7105 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7107 (XSETPVECTYPE): Rewrite in terms of new macro.
7108 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7109 This is a bit clearer, and further avoids the possibility of
7110 undesirable aliasing.
7111 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7112 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7113 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7114 since Lisp_Subr is a special case (no "next" field).
7115 (ASIZE): Now uses header.size rather than size.
7116 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7117 to avoid the hassle of writing XVECTOR (foo)->header.size.
7118 (struct vectorlike_header): New type.
7119 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7120 object, to help avoid aliasing.
7121 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7122 (SUBRP): Likewise, since Lisp_Subr is a special case.
7123 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7124 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7125 (struct Lisp_Hash_Table): Combine first two members into a single
7126 struct vectorlike_header member. All uses of "size" and "next" members
7127 changed to be "header.size" and "header.next".
7128 * buffer.h (struct buffer): Likewise.
7129 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7130 * frame.h (struct frame): Likewise.
7131 * process.h (struct Lisp_Process): Likewise.
7132 * termhooks.h (struct terminal): Likewise.
7133 * window.c (struct save_window_data, struct saved_window): Likewise.
7134 * window.h (struct window): Likewise.
7135 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7136 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7137 * buffer.c (init_buffer_once): Likewise.
7138 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7140 * process.c (Fformat_network_address): Use local var for size,
7143 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7145 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7146 * data.c (atof): Remove decl; no longer used or needed.
7147 (digit_to_number): Move to lread.c.
7148 (Fstring_to_number): Use new string_to_number function, to be
7149 consistent with how the Lisp reader treats infinities and NaNs.
7150 Do not assume that floating-point numbers represent EMACS_INT
7151 without losing information; this is not true on most 64-bit hosts.
7152 Avoid double-rounding errors, by insisting on integers when
7153 parsing non-base-10 numbers, as the documentation specifies.
7154 * lisp.h (string_to_number): New decl, replacing ...
7155 (isfloat_string): Remove.
7156 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7157 (read1): Do not accept +. and -. as integers; this
7158 appears to have been a coding error. Similarly, do not accept
7159 strings like +-1e0 as floating point numbers. Do not report
7160 overflow for integer overflows unless the base is not 10 which
7161 means we have no simple and reliable way to continue.
7162 Break out the floating-point parsing into a new
7163 function string_to_number, so that Fstring_to_number parses
7164 floating point numbers consistently with the Lisp reader.
7165 (digit_to_number): Move here from data.c. Make it static inline.
7166 (E_CHAR, EXP_INT): Remove, replacing with ...
7167 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7168 (string_to_number): New function, replacing isfloat_string.
7169 This function checks for valid syntax and produces the resulting
7170 Lisp float number too. Rework it so that string-to-number
7171 no longer mishandles examples like "1.0e+". Use strtoumax,
7172 so that overflow for non-base-10 numbers is reported only when
7173 there's no portable and simple way to convert to floating point.
7175 * textprop.c (set_text_properties_1): Rewrite for clarity,
7176 and to avoid GCC warning about integer overflow.
7178 * intervals.h (struct interval): Use EMACS_INT for members
7179 where EMACS_UINT might cause problems. See
7180 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7181 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7182 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7184 (offset_intervals): Tell GCC not to worry about length overflow
7185 when negating a negative length.
7187 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7188 (overrun_check_free): Likewise.
7190 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7191 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7194 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7195 (gnutls_make_error): Rename local to avoid shadowing.
7196 (gnutls_emacs_global_deinit): ifdef out; not used.
7197 (Fgnutls_boot): Use const for pointer to readonly storage.
7198 Comment out unused local. Fix pointer signedness problems.
7200 * lread.c (openp): Don't stuff size_t into an 'int'.
7201 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7202 about possible signed overflow.
7204 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7205 (GDK_KEY_g): Don't define if already defined.
7206 (xg_prepare_tooltip): Avoid pointer signedness problem.
7207 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7209 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7210 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7212 * xfns.c (Fx_window_property): Simplify a bit,
7213 to make a bit faster and to avoid GCC 4.6.0 warning.
7214 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7216 * fns.c (internal_equal): Don't assume size_t fits in int.
7218 * alloc.c (compact_small_strings): Tighten assertion a little.
7220 Replace pEd with more-general pI, and fix some printf arg casts.
7221 * lisp.h (pI): New macro, generalizing old pEd macro to other
7222 conversion specifiers. For example, use "...%"pI"d..." rather
7223 than "...%"pEd"...".
7224 (pEd): Remove. All uses replaced with similar uses of pI.
7225 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7226 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7227 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7228 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7229 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7230 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7231 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7233 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7234 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7235 * print.c (safe_debug_print, print_object): Likewise.
7236 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7238 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7239 avoiding the 0 flag, which is not portable.
7240 * process.c (Fmake_network_process): Use pI to avoid cast.
7241 * region-cache.c (pp_cache): Likewise.
7242 * xdisp.c (decode_mode_spec): Likewise.
7243 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7244 behavior on 64-bit hosts with printf arg.
7245 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7246 (x_stop_queuing_selection_requests): Likewise.
7247 (x_get_window_property): Don't truncate byte count to an 'int'
7250 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7251 here, since it parses constructs like leading '-' and spaces,
7252 which are not wanted; and it overflows with large numbers.
7253 Instead, simply match F[0-9]+, which is what is wanted anyway.
7255 * alloc.c: Remove unportable assumptions about struct layout.
7256 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7257 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7258 (allocate_vectorlike, make_pure_vector): Use the new macros,
7259 plus offsetof, to remove unportable assumptions about struct layout.
7260 These assumptions hold on all porting targets that I know of, but
7261 they are not guaranteed, they're easy to remove, and removing them
7262 makes further changes easier.
7264 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7265 This doesn't fix a bug but makes the code clearer.
7266 (string_overrun_cookie): Now const. Use initializers that
7267 don't formally overflow signed char, to avoid warnings.
7268 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7269 can cause Emacs to crash when string overrun checking is enabled.
7270 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7271 multiple of sizeof (EMACS_INT); it need not be, if
7272 alignof(EMACS_INT) < sizeof (EMACS_INT).
7273 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7275 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7277 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7279 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7281 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7282 supposed to be handshaking. (Bug#8556)
7283 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7285 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7287 * lisp.h (Qdebug): List symbol.
7288 * eval.c (Qdebug): Restore global linkage.
7289 * keyboard.c (debug-on-event): New variable.
7290 (handle_user_signal): Break into debugger when debug-on-event
7291 matches the current signal symbol.
7293 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7295 * alloc.c (check_sblock, check_string_bytes)
7296 (check_string_free_list): Convert to standard C.
7298 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7300 * w32.c (emacs_gnutls_push): Fix typo.
7302 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7304 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7305 "cast to pointer from integer of different size".
7307 Improve doprnt and its use in verror. (Bug#8545)
7308 * doprnt.c (doprnt): Document the set of format control sequences
7309 supported by the function. Use SAFE_ALLOCA instead of always
7312 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7313 is one byte too soon. Don't use xrealloc; instead xfree and
7316 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7318 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7321 * gnutls.c: Renamed global_initialized to
7322 gnutls_global_initialized. Added internals for the
7323 :verify-hostname-error, :verify-error, and :verify-flags
7324 parameters of `gnutls-boot' and documented those parameters in the
7325 docstring. Start callback support.
7326 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7327 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7328 on error. Return error code.
7329 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7330 (emacs_gnutls_read): Likewise.
7331 (Fgnutls_boot): Return handshake error code.
7332 (emacs_gnutls_handle_error): New function.
7333 (wsaerror_to_errno): Likewise.
7335 * w32.h (emacs_gnutls_pull): Add prototype.
7336 (emacs_gnutls_push): Likewise.
7338 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7339 (emacs_gnutls_push): Likewise.
7341 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7343 * process.c (wait_reading_process_output): Check if GnuTLS
7344 buffered some data internally if no FDs are set for TLS
7347 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7348 (LIBS): Link to USER_LIBS.
7349 ($(BLD)/gnutls.$(0)): New target.
7351 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7353 * xdisp.c (handle_single_display_spec): Rename the
7354 display_replaced_before_p argument into display_replaced_p, to
7355 make it consistent with the commentary. Fix typos in the
7358 * textprop.c (syms_of_textprop): Remove dead code.
7359 (copy_text_properties): Delete obsolete commentary about an
7360 interface that was deleted long ago. Fix typos in the description
7363 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7364 to changes in oldXMenu/XMenu.h from 2011-04-16.
7365 <menu_help_message, prev_menu_help_message>: Constify.
7366 (IT_menu_make_room): menu->help_text is now `const char **';
7369 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7370 to changes in oldXMenu/XMenu.h from 2011-04-16.
7371 (struct XMenu): Declare `help_text' `const char **'.
7373 * xfaces.c <Qunspecified>: Make extern again.
7375 * syntax.c: Include sys/types.h before including regex.h, as
7378 * doc.c (get_doc_string): Improve the format passed to `error'.
7380 * doprnt.c (doprnt): Improve commentary.
7382 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7384 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7387 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7388 changes in globals.h immediately force recompilation.
7389 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7390 $(CURDIR)/s/ms-w32.h.
7391 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7393 * character.c (Fchar_direction): Function deleted.
7394 (syms_of_character): Don't defsubr it.
7395 <char-direction-table>: Deleted.
7397 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7399 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7400 * doprnt.c: Include limits.h.
7401 (SIZE_MAX): New macro.
7402 (doprnt): Return a size_t value. 2nd arg is now size_t.
7403 Many local variables are now size_t instead of int or unsigned.
7404 Improve overflow protection. Support `l' modifier for integer
7405 conversions. Support %l conversion. Don't assume an EMACS_INT
7406 argument for integer conversions and for %c.
7408 * lisp.h (doprnt): Restore prototype.
7410 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7413 * Makefile.in (base_obj): Add back doprnt.o.
7415 * deps.mk (doprnt.o): Add back prerequisites.
7416 (callint.o): Depend on character.h.
7418 * eval.c (internal_lisp_condition_case): Include the handler
7419 representation in the error message.
7420 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7421 when breaking from the loop.
7423 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7425 * callint.c (Fcall_interactively): When displaying error message
7426 about invalid control letter, pass the character's codepoint, not
7427 a pointer to its multibyte form. Improve display of the character
7428 in octal and display also its hex code.
7430 * character.c (char_string): Use %x to display the (unsigned)
7431 codepoint of an invalid character, to avoid displaying a bogus
7434 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7435 `error', not SYMBOL_NAME itself.
7437 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7438 character arguments to `error'.
7440 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7441 to `error' in error message about FINAL_CHAR argument. Make sure
7442 FINAL_CHAR is a character, and use %c when it is passed as
7443 argument to `error'.
7445 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7447 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7449 * w32.c: Include <time.h>.
7450 (sys_localtime): New function.
7452 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7454 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7456 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7458 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7460 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7463 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7465 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7466 gl_state.e_property when gl_state.object is Qt.
7468 * insdel.c (make_gap_larger): Remove limitation of buffer size
7471 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7473 * xdisp.c (lookup_glyphless_char_display)
7474 (produce_glyphless_glyph): Handle cons cell entry in
7475 glyphless-char-display.
7476 (Vglyphless_char_display): Document it.
7478 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7479 glyphless-char-display.
7481 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7483 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7485 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7487 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7488 definition for no-X builds.
7490 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7492 Static checks with GCC 4.6.0 and non-default toolkits.
7494 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7496 * process.c (keyboard_bit_set): Define only if SIGIO.
7497 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7498 (send_process): Repair possible setjmp clobbering.
7500 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7502 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7504 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7506 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7507 Define only if needed.
7509 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7510 by pacifying GCC about it. Maybe it's time to retire it?
7511 * xfaces.c (USG, __TIMEVAL__): Likewise.
7513 * dispextern.h (struct redisplay_interface): Rename param
7515 * termhooks.h (struct terminal): Likewise.
7516 * xterm.c (xembed_send_message): Likewise.
7518 * insdel.c (make_gap_smaller): Define only if
7519 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7521 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7524 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7525 so that we aren't warned about unused symbols.
7527 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7529 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7531 * xfns.c (x_real_positions): Mark locals as initialized.
7533 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7535 * xterm.c: Fix problems found by static analysis with other toolkits.
7536 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7537 (x_dispatch_event): Declare static if USE_GTK, and
7538 define if USE_GTK || USE_X_TOOLKIT.
7539 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7540 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7541 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7542 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7544 * xmenu.c (menu_help_callback): Pointer type fixes.
7545 Use const pointers when pointing at readonly data. Avoid pointer
7547 (FALSE): Remove unused macro.
7548 (update_frame_menubar): Remove unused decl.
7550 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7552 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7553 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7554 (single_menu_item): Rename local to avoid shadowing.
7556 * keyboard.c (make_lispy_event): Remove unused local var.
7558 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7559 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7561 * bitmaps: Change bitmaps from unsigned char back to the X11
7562 compatible char. Avoid the old compiler warnings about
7563 out-of-range initializers by using, for example, '\xab' rather
7566 * xgselect.c (xgselect_initialize): Check vs interface
7567 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7569 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7571 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7572 to read-only memory.
7574 * fns.c (vector): Remove; this old hack is no longer needed.
7576 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7578 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7580 * xrdb.c (x_load_resources): Omit unused local.
7582 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7583 (x_window): Rename locals to avoid shadowing.
7584 (USG): Use the kludged USG macro, to pacify gcc.
7586 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7587 (x_term_init): Remove local to avoid shadowing.
7589 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7591 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7592 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7594 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7596 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7598 Fix regex.c, syntax.c and friends for buffers > 2GB.
7599 * syntax.h (struct gl_state_s): Declare character position members
7602 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7604 * textprop.c (verify_interval_modification, interval_of):
7605 Declare arguments EMACS_INT.
7607 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7610 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7612 * indent.c (Fvertical_motion): Local variable it_start is now
7615 * regex.c (re_match, re_match_2, re_match_2_internal)
7616 (bcmp_translate, regcomp, regexec, print_double_string)
7617 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7618 (re_compile_pattern, re_exec): Declare arguments and local
7619 variables `size_t' and `ssize_t' and return values `regoff_t', as
7621 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7622 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7623 <compile_stack_type>: `size' and `avail' are now `size_t'.
7625 * regex.h <regoff_t>: Use ssize_t, not int.
7626 (re_search, re_search_2, re_match, re_match_2): Arguments that
7627 specify buffer/string position and length are now ssize_t and
7628 size_t. Return type is regoff_t.
7630 2011-04-16 Ben Key <bkey76@gmail.com>
7632 * nsfont.m: Fixed bugs in ns_get_family and
7633 ns_descriptor_to_entity that were caused by using free to
7634 deallocate memory blocks that were allocated by xmalloc (via
7635 xstrdup). This caused Emacs to crash when compiled with
7636 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7637 --enable-checking=xmallocoverrun). xfree is now used to
7638 deallocate these memory blocks.
7640 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7642 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7644 emacs_write: Accept and return EMACS_INT for sizes.
7645 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7647 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7648 Accept and return EMACS_INT.
7649 (emacs_gnutls_write): Return the number of bytes written on
7651 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7652 (emacs_read, emacs_write): Remove check for negative size, as the
7653 Emacs source code has been audited now.
7654 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7655 (emacs_read, emacs_write): Use it.
7656 * process.c (send_process): Adjust to the new signatures of
7657 emacs_write and emacs_gnutls_write. Do not attempt to store
7658 a byte offset into an 'int'; it might overflow.
7659 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7661 * sound.c: Don't assume sizes fit in 'int'.
7662 (struct sound_device.period_size, alsa_period_size):
7663 Return EMACS_INT, not int.
7664 (struct sound_device.write, vox_write, alsa_write):
7665 Accept EMACS_INT, not int.
7666 (wav_play, au_play): Use EMACS_INT to store sizes and to
7667 record read return values.
7669 2011-04-15 Ben Key <bkey76@gmail.com>
7671 * keyboard.c (Qundefined): Don't declare static since it is used
7673 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7674 static since they are used in nsfont.m.
7676 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7678 * process.c (Qprocessp): Don't declare static.
7679 * lisp.h (Qprocessp): Declare again.
7681 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7683 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7685 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7687 Improve C-level modularity by making more things 'static'.
7689 Don't publish debugger-only interfaces to other modules.
7690 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7691 (verify_bytepos, count_markers): Move decls to the only modules
7693 * region-cache.h (pp_cache): Likewise.
7694 * window.h (check_all_windows): Likewise.
7695 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7697 * sysdep.c (croak): Now static, if
7698 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7699 * syssignal.h (croak): Declare only if not static.
7701 * alloc.c (refill_memory_reserve): Now static if
7702 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7703 * lisp.h (refill_memory_reserve): Declare only if not static.
7705 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7706 Define only if USE_LUCID.
7708 * xrdb.c (x_customization_string, x_rm_string): Now static.
7710 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7711 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7713 * xdisp.c (draw_row_with_mouse_face): Now static.
7714 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7716 * window.h (check_all_windows): Mark externally visible.
7718 * window.c (window_deletion_count): Now static.
7720 * undo.c: Make symbols static if they're not exported.
7721 (last_undo_buffer, last_boundary_position, pending_boundary):
7724 * textprop.c (interval_insert_behind_hooks): Now static.
7725 (interval_insert_in_front_hooks): Likewise.
7727 * term.c: Make symbols static if they're not exported.
7728 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7729 (max_frame_lines, tty_set_terminal_modes):
7730 (tty_reset_terminal_modes, tty_turn_off_highlight):
7731 (get_tty_terminal): Now static.
7732 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7733 * termhooks.h (term_mouse_moveto): Do not declare if
7735 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7736 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7738 * sysdep.c: Make symbols static if they're not exported.
7739 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7741 (sigprocmask_set, full_mask): Remove; unused.
7742 (wait_debugging): Mark as visible.
7743 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7744 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7746 * syntax.c (syntax_temp): Define only if !__GNUC__.
7748 * sound.c (current_sound_device, current_sound): Now static.
7750 * search.c (searchbufs, searchbuf_head): Now static.
7752 * scroll.c (scroll_cost): Remove; unused.
7753 * dispextern.h (scroll_cost): Remove decl.
7755 * region-cache.h (pp_cache): Mark as externally visible.
7757 * process.c: Make symbols static if they're not exported.
7758 (process_tick, update_tick, create_process, chan_process):
7759 (Vprocess_alist, proc_buffered_char, datagram_access):
7760 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7761 (deactivate_process): Mark defn as static, as well as decl.
7762 * lisp.h (create_process): Remove decl.
7763 * process.h (chan_process, Vprocess_alist): Remove decls.
7765 * print.c: Make symbols static if they're not exported.
7766 (print_depth, new_backquote_output, being_printed, print_buffer):
7767 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7768 (print_interval, print_number_index, initial_stderr_stream):
7770 * lisp.h (Fprinc): Remove decl.
7771 (debug_output_compilation_hack): Mark as externally visible.
7773 * sysdep.c (croak): Move decl from here to syssignal.h.
7774 * syssignal.h (croak): Put it here, so the API can be checked when
7775 'croak' is called from dissociate_if_controlling_tty.
7777 * minibuf.c: Make symbols static if they're not exported.
7778 (minibuf_save_list, choose_minibuf_frame): Now static.
7779 * lisp.h (choose_minibuf_frame): Remove decl.
7781 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7783 * lread.c: Make symbols static if they're not exported.
7784 (read_objects, initial_obarray, oblookup_last_bucket_number):
7786 (make_symbol): Remove; unused.
7787 * lisp.h (initial_obarray, make_symbol): Remove decls.
7789 * keyboard.c: Make symbols static if they're not exported.
7790 (single_kboard, recent_keys_index, total_keys, recent_keys):
7791 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7792 (this_single_command_key_start, echoing, last_auto_save):
7793 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7794 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7795 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7796 (Vlispy_mouse_stem, double_click_count):
7798 (force_auto_save_soon): Define only if SIGDANGER.
7799 (ignore_mouse_drag_p): Now static if
7800 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7801 (print_help): Remove; unused.
7802 (stop_character, last_timer_event): Mark as externally visible.
7803 * keyboard.h (ignore_mouse_drag_p): Declare only if
7804 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7805 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7806 * lisp.h (echoing): Remove decl.
7807 (force_auto_save_soon): Declare only if SIGDANGER.
7808 * xdisp.c (redisplay_window): Simplify code, to make it more
7809 obvious that ignore_mouse_drag_p is not accessed if !defined
7810 USE_GTK && !defined HAVE_NS.
7812 * intervals.c: Make symbols static if they're not exported.
7813 (merge_properties_sticky, merge_interval_right, delete_interval):
7815 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7817 * insdel.c: Make symbols static if they're not exported.
7818 However, leave prepare_to_modify_buffer alone. It's never
7819 called from outside this function, but that appears to be a bug.
7820 (combine_after_change_list, combine_after_change_buffer):
7821 (adjust_after_replace, signal_before_change): Now static.
7822 (adjust_after_replace_noundo): Remove; unused.
7823 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7824 (signal_before_change): Remove decls.
7826 * indent.c (val_compute_motion, val_vmotion): Now static.
7828 * image.c: Make symbols static if they're not exported.
7829 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7831 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7832 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7834 * fringe.c (standard_bitmaps): Now static.
7835 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7837 * frame.c: Make symbols static if they're not exported.
7838 (x_report_frame_params, make_terminal_frame): Now static.
7839 (get_frame_param): Now static, unless HAVE_NS.
7840 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7841 (x_get_resource_string): Remove; not used.
7842 * frame.h (make_terminal_frame, x_report_frame_params):
7843 (x_get_resource_string); Remove decls.
7844 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7845 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7847 * font.c, fontset.c: Make symbols static if they're not exported.
7848 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7849 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7850 * font.c (font_close_object): Now static.
7851 * font.h (font_close_object): Remove.
7852 * fontset.c (FONTSET_OBJLIST): Remove.
7853 (free_realized_fontset) #if-0 the body, which does nothing.
7854 (face_suitable_for_char_p): #if-0, as it's never called.
7855 * fontset.h (face_suitable_for_char_p): Remove decl.
7856 * xfaces.c (face_at_string_position):
7857 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7858 since 0 is always ASCII.
7860 * fns.c (weak_hash_tables): Now static.
7862 * fileio.c: Make symbols static if they're not exported.
7863 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7864 (Vwrite_region_annotation_buffers): Now static.
7866 * eval.c: Make symbols static if they're not exported.
7867 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7868 * lisp.h (backtrace_list): Remove decl.
7870 * emacs.c: Make symbols static if they're not exported.
7871 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7872 (fatal_error_code, fatal_error_signal_hook, standard_args):
7874 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7875 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7876 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7877 * lisp.h (fatal_error_signal_hook): Remove decl.
7878 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7880 * editfns.c: Move a (normally-unused) function to its only use.
7881 * editfns.c, lisp.h (get_operating_system_release): Remove.
7882 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7883 worth the hassle of breaking this out.
7885 * xterm.c: Make symbols static if they're not exported.
7886 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7887 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7888 (x_destroy_window, x_delete_display):
7890 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7891 (x_mouse_leave): Remove; unused.
7892 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7893 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7894 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7896 (x_mouse_leave): Declare only if WINDOWSNT.
7897 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7898 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7901 * ftxfont.c: Make symbols static if they're not exported.
7902 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7904 * font.h (ftxfont_driver): Likewise.
7906 * xfns.c: Make symbols static if they're not exported.
7907 (x_last_font_name, x_display_info_for_name):
7908 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7909 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7910 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7911 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7912 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7913 (last_show_tip_args): Now static.
7914 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7915 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7916 (x_screen_planes): Remove; unused.
7917 * dispextern.h (x_screen_planes): Remove decl.
7919 * dispnew.c: Make symbols static if they're not exported.
7920 * dispextern.h (redraw_garbaged_frames, scrolling):
7921 (increment_row_positions): Remove.
7922 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7923 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7925 (redraw_garbaged_frames): Remove; unused.
7927 * xfaces.c: Make symbols static if they're not exported.
7928 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7930 * xterm.h (defined_color): Remove decls.
7931 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7932 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7933 (menu_face_changed_default, defined_color, free_realized_face):
7934 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7935 (ascii_face_of_lisp_face): Remove; unused.
7937 * xdisp.c: Make symbols static if they're not exported.
7938 * dispextern.h (scratch_glyph_row, window_box_edges):
7939 (glyph_to_pixel_coords, set_cursor_from_row):
7940 (get_next_display_element, set_iterator_to_next):
7941 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7942 (show_mouse_face): Remove decls
7943 * frame.h (message_buf_print): Likewise.
7944 * lisp.h (pop_message, set_message, check_point_in_composition):
7946 * xterm.h (set_vertical_scroll_bar): Likewise.
7947 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7948 (message_buf_print, scratch_glyph_row, displayed_buffer):
7949 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7950 (get_next_display_element, show_mouse_face, window_box_edges):
7951 (frame_to_window_pixel_xy, check_point_in_composition):
7952 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7953 (glyph_to_pixel_coords): Remove; unused.
7955 * dired.c (file_name_completion): Now static.
7957 * dbusbind.c (xd_in_read_queued_messages): Now static.
7959 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7960 * data.c (circular_list_error): Remove.
7962 * commands.h (last_point_position, last_point_position_buffer):
7963 (last_point_position_window): Remove decls.
7964 * keyboard.c: Make these variables static.
7966 * coding.h (coding, code_convert_region, encode_coding_gap):
7968 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7969 (iso_code_class, detect_coding, code_convert_region): Now static.
7970 (encode_coding_gap): Remove; unused.
7972 * chartab.c (chartab_chars, chartab_bits): Now static.
7974 * charset.h (charset_iso_8859_1): Remove decl.
7975 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7978 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7979 * ccl.c (Vccl_program_table): Now static.
7980 (check_ccl_update): Remove; unused.
7982 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7983 * category.h: ... from here.
7984 * category.c (check_category_table, set_category_set): Now static.
7986 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7987 * lisp.h: Remove these decls.
7989 * buffer.c (buffer_count): Remove unused var.
7991 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7992 so that it's not optimized away.
7993 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7994 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7995 exported only to the debugger.
7997 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7998 * atimer.h (run_all_atimers): Remove; not exported.
8000 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8001 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8002 was inaccessible from Lisp.
8003 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8004 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8006 alloc.c: Import and export fewer symbols, and remove unused items.
8007 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8009 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8010 it's not optimized away by whole-program optimization.
8011 (message_enable_multibyte, free_misc): Remove.
8012 (catchlist, handlerlist, mark_backtrace):
8013 Declare only if BYTE_MARK_STACK.
8014 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8015 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8016 (message_enable_multibyte): Remove decl.
8017 (free_misc, interval_free_list, float_block, float_block_index):
8018 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8019 (cons_free_list, last_marked_index):
8021 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8022 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8023 (mark_backtrace): Define only if BYTE_MARK_STACK.
8024 * xdisp.c (message_enable_multibyte): Now static.
8026 Declare Lisp_Object Q* variables to be 'static' if not exported.
8027 This makes it easier for human readers (and static analyzers)
8028 to see whether these variables are used from other modules.
8029 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8030 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8031 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8032 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8033 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8034 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8035 * xmenu.c, xselect.c:
8036 Declare Q* vars static if they are not used in other modules.
8037 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8038 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8039 Remove decls of unexported vars.
8040 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8042 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8044 Make Emacs functions such as Fatom 'static' by default.
8045 This makes it easier for human readers (and static analyzers)
8046 to see whether these functions can be called from other modules.
8047 DEFUN now defines a static function. To make the function external
8048 so that it can be used in other C modules, use the new macro DEFUE.
8049 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8050 (Finit_image_library):
8051 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8052 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8053 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8054 Remove decls, since these functions are now static.
8055 (Funintern, Fget_internal_run_time): New decls, since these functions
8056 were already external.
8058 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8059 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8060 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8061 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8062 * keyboard.c, keymap.c, lread.c:
8063 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8064 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8065 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8066 Mark functions with DEFUE instead of DEFUN,
8067 if they are used in other modules.
8068 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8069 decls for now-static functions.
8070 * buffer.h (Fdelete_overlay): Remove decl.
8071 * callproc.c (Fgetenv_internal): Mark as internal.
8072 * composite.c (Fremove_list_of_text_properties): Remove decl.
8073 (Fcomposition_get_gstring): New forward static decl.
8074 * composite.h (Fcomposite_get_gstring): Remove decl.
8075 * dired.c (Ffile_attributes): New forward static decl.
8076 * doc.c (Fdocumntation_property): New forward static decl.
8077 * eval.c (Ffetch_bytecode): New forward static decl.
8078 (Funintern): Remove extern decl; now in .h file where it belongs.
8079 * fileio.c (Fmake_symbolic_link): New forward static decl.
8080 * image.c (Finit_image_library): New forward static decl.
8081 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8082 * intervals.h (Fprevious_property_change):
8083 (Fremove_list_of_text_properties): Remove decls.
8084 * keyboard.c (Fthis_command_keys): Remove decl.
8085 (Fcommand_execute): New forward static decl.
8086 * keymap.c (Flookup_key): New forward static decl.
8087 (Fcopy_keymap): Now static.
8088 * keymap.h (Flookup_key): Remove decl.
8089 * process.c (Fget_process): New forward static decl.
8090 (Fprocess_datagram_address): Mark as internal.
8091 * syntax.c (Fsyntax_table_p): New forward static decl.
8092 (skip_chars): Remove duplicate decl.
8093 * textprop.c (Fprevious_property_change): New forward static decl.
8094 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8096 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8097 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8099 * editfns.c (Fformat): Remove unreachable code.
8101 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8103 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8106 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8108 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8109 when at ZV. (Bug#8487)
8111 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8113 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8115 * keyboard.c (parse_tool_bar_item): Likewise.
8116 * sound.c (sound_cleanup, alsa_close): Likewise.
8117 * termcap.c (tgetent): Likewise.
8118 * xfns.c (x_default_font_parameter): Likewise.
8119 * xsettings.c (read_and_apply_settings): Likewise.
8121 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8122 (overrun_check_free): Protoize.
8124 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8126 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8127 since callers should never pass a negative size.
8128 Change the signature to match that of plain 'read' and 'write'; see
8129 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8130 * lisp.h: Update prototypes of emacs_write and emacs_read.
8132 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8134 * xdisp.c (redisplay_window): Don't try to determine the character
8135 position of the scroll margin if the window start point w->startp
8136 is outside the buffer's accessible region. (Bug#8468)
8138 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8140 Fix write-region and its subroutines for buffers > 2GB.
8141 * fileio.c (a_write, e_write): Modify declaration of arguments and
8142 local variables to support buffers larger than 2GB.
8143 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8145 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8146 argument, local variables, and return value.
8148 * lisp.h: Update prototypes of emacs_write and emacs_read.
8150 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8152 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8154 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8156 Fix more problems found by GCC 4.6.0's static checks.
8158 * xdisp.c (vmessage): Use a better test for character truncation.
8160 * charset.c (load_charset_map): <, not <=, for optimization,
8161 and to avoid potential problems with integer overflow.
8162 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8163 * casetab.c (set_identity, shuffle): Likewise.
8164 * editfns.c (Fformat): Likewise.
8165 * syntax.c (skip_chars): Likewise.
8167 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8168 This also lets GCC 4.6.0 generate slightly better loop code.
8170 * callint.c (Fcall_interactively): <, not <=, for optimization.
8171 (Fcall_interactively): Count the number of arguments produced,
8172 not the number of arguments given. This is simpler and lets GCC
8173 4.6.0 generate slightly better code.
8175 * ftfont.c: Distingish more carefully between FcChar8 and char.
8176 The previous code passed unsigned char * to a functions like
8177 strlen and xstrcasecmp that expect char *, which does not
8178 conform to the C standard.
8179 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8180 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8181 char * when the C standard requires it.
8183 * keyboard.c (read_char): Remove unused var.
8185 * eval.c: Port to Windows vsnprintf (Bug#8435).
8187 (SIZE_MAX): Define if the headers do not.
8188 (verror): Do not give up if vsnprintf returns a negative count.
8189 Instead, grow the buffer. This ports to Windows vsnprintf, which
8190 does not conform to C99. Problem reported by Eli Zaretskii.
8191 Also, simplify the allocation scheme, by avoiding the need for
8192 calling realloc, and removing the ALLOCATED variable.
8194 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8196 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8197 But keep the doprint source code for now, as we might revamp it
8198 and use it again (Bug#8435).
8199 * lisp.h (doprnt): Remove.
8200 * Makefile.in (base_obj): Remove doprnt.o.
8201 * deps.mk (doprnt.o): Remove.
8203 error: Print 32- and 64-bit integers portably (Bug#8435).
8204 Without this change, on typical 64-bit hosts error ("...%d...", N)
8205 was used to print both 32- and 64-bit integers N, which relied on
8207 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8208 * lisp.h (error, verror): Mark as printf-like functions.
8209 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8210 Report overflow in size calculations when allocating printf buffer.
8211 Do not truncate output string at its first null byte.
8212 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8213 Truncate the output at a character boundary, since vsnprintf does not
8215 * charset.c (check_iso_charset_parameter): Convert internal
8216 character to string before calling 'error', since %c now has the
8218 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8219 overflow when computing char to be passed to 'error'. Do not
8220 pass Lisp_Object to 'error'; pass the integer instead.
8221 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8222 formatted with plain %d.
8224 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8226 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8228 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8230 * xterm.c (x_catch_errors): Remove duplicate declaration.
8232 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8234 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8236 2011-04-10 Jim Meyering <meyering@redhat.com>
8238 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8239 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8240 return ssize_t not "int", and use size_t as the buffer length.
8241 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8242 * gnutls.h: Update declarations.
8243 * process.c (read_process_output): Use ssize_t, to match.
8244 (send_process): Likewise.
8246 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8248 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8250 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8252 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8253 Use unsigned char, to match FcChar8 type definition.
8255 * xterm.c (handle_one_xevent):
8256 * xmenu.c (create_and_show_popup_menu):
8257 * xselect.c (x_decline_selection_request)
8258 (x_reply_selection_request): Avoid type-punned deref of X events.
8260 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8262 Fix some uses of `int' instead of EMACS_INT.
8263 * search.c (string_match_1, fast_string_match)
8264 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8265 (scan_buffer, find_next_newline_no_quit)
8266 (find_before_next_newline, search_command, Freplace_match)
8267 (Fmatch_data): Make some `int' variables be EMACS_INT.
8269 * xdisp.c (display_count_lines): 3rd argument and return value now
8270 EMACS_INT. All callers changed.
8271 (pint2hrstr): Last argument is now EMACS_INT.
8273 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8274 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8275 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8276 (decode_coding_utf_16, decode_coding_emacs_mule)
8277 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8278 (decode_coding_ccl, decode_coding_charset)
8279 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8280 (decode_coding_iso_2022, decode_coding_emacs_mule)
8281 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8282 <char_offset, last_offset>: Declare EMACS_INT.
8283 (encode_coding_utf_8, encode_coding_utf_16)
8284 (encode_coding_emacs_mule, encode_invocation_designation)
8285 (encode_designation_at_bol, encode_coding_iso_2022)
8286 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8287 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8289 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8290 (encode_invocation_designation): Last argument P_NCHARS is now
8292 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8293 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8295 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8298 * ccl.c (Fccl_execute_on_string): Declare some variables
8301 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8303 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8305 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8307 * process.c (Fformat_network_address): Doc fix.
8309 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8311 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8313 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8315 * keyboard.c (read_char): Call Lisp function help-form-show,
8316 instead of using internal_with_output_to_temp_buffer.
8317 (Qhelp_form_show): New var.
8318 (syms_of_keyboard): Use DEFSYM macro.
8320 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8322 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8324 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8326 * process.c (Flist_processes): Remove to Lisp.
8327 (list_processes_1): Delete.
8329 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8331 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8333 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8335 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8337 Fix more problems found by GCC 4.6.0's static checks.
8339 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8341 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8343 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8345 * xdisp.c (vmessage): Mark as a printf-like function.
8347 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8349 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8351 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8352 printf-like functions.
8353 (tiff_load): Add casts to remove these marks before passing them
8354 to system-supplied API.
8356 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8358 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8359 This avoids several warnings with gcc -Wstrict-overflow.
8360 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8361 directly, rather than having caller test rule sign. This avoids
8362 some unnecessary tests.
8363 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8364 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8365 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8367 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8368 (xfont_open): Avoid unnecessary tests.
8370 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8372 * composite.h, composite.c (composition_gstring_put_cache):
8373 Use EMACS_INT, not int, for length.
8375 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8376 breaking out part of COMPOSITION_DECODE_RULE.
8377 (COMPOSITION_DECODE_RULE): Use it.
8378 * composite.c (get_composition_id): Remove unused local vars,
8379 by using the new macro.
8381 * textprop.c (set_text_properties_1): Change while to do-while,
8382 since the condition is always true at first.
8384 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8385 (interval_deletion_adjustment): Return unsigned value.
8388 * process.c (list_processes_1, create_pty, read_process_output):
8389 (exec_sentinel): Remove vars that were set but not used.
8390 (create_pty): Remove unnecessary "volatile"s.
8391 (Fnetwork_interface_info): Avoid possibility of int overflow.
8392 (read_process_output): Do adaptive read buffering even if carryover.
8393 (read_process_output): Simplify nbytes computation if buffered.
8395 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8397 * syntax.c (scan_words): Remove var that was set but not used.
8398 (update_syntax_table): Use unsigned instead of int.
8400 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8401 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8402 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8404 * print.c (print_error_message): Avoid int overflow.
8406 * font.c (font_list_entities): Redo for clarity,
8407 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8409 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8410 (font_score): Avoid potential overflow in diff calculation.
8412 * fns.c (substring_both): Remove var that is set but not used.
8413 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8415 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8417 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8418 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8419 can always succeed if overflow has undefined behavior.
8421 * search.c (boyer_moore, wordify): Remove vars set but not used.
8422 (wordify): Omit three unnecessary tests.
8424 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8425 All callers changed. This avoids the need for an unused var.
8427 * casefiddle.c (casify_region): Remove var that is set but not used.
8429 * dired.c (file_name_completion): Remove var that is set but not used.
8431 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8433 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8434 (Finsert_file_contents): Remove unnecessary code checking fd.
8436 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8437 Check for integer overflow on size calculations.
8439 * buffer.c (Fprevious_overlay_change): Remove var that is set
8442 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8443 Remove vars that are set but not used.
8444 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8445 (timer_check_2): Mark vars as initialized.
8447 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8449 * image.c (lookup_image): Remove var that is set but not used.
8450 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8452 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8453 that are set but not used.
8455 * xfns.c (make_invisible_cursor): Don't return garbage
8456 if XCreateBitmapFromData fails (Bug#8410).
8458 * xselect.c (x_get_local_selection, x_handle_property_notify):
8459 Remove vars that are set but not used.
8461 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8462 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8464 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8465 Remove var that is set but not used.
8466 (scroll_bar_windows_size): Now size_t, not int.
8467 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8470 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8471 (map_tty_color) [!defined MSDOS]: Likewise.
8473 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8475 * coding.c: Remove vars that are set but not used.
8476 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8477 All callers changed.
8478 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8479 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8480 (decode_coding_charset): Remove vars that are set but not used.
8482 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8483 that is set but not used.
8485 * print.c (print_object): Remove var that is set but not used.
8487 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8488 The gnulib version avoids calling malloc in the usual case,
8489 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8490 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8491 * filelock.c (current_lock_owner): Likewise.
8492 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8493 * sysdep.c: Include allocator.h, careadlinkat.h.
8494 (emacs_no_realloc_allocator): New static constant.
8495 (emacs_readlink): New function.
8496 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8497 ../lib/careadlinkat.h.
8499 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8501 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8502 first non-nil return value).
8504 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8506 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8507 if not defined (Bug#8403).
8509 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8511 * xdisp.c (display_count_lines): Remove parameter `start',
8512 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8513 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8514 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8515 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8516 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8517 and thereabouts. All callers changed.
8518 (get_per_char_metric): Remove parameter `f', unused since
8519 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8521 2011-04-02 Jim Meyering <meyering@redhat.com>
8523 do not dereference NULL upon failed strdup
8524 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8525 (ns_get_family): Likewise.
8527 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8529 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8531 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8533 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8536 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8538 Add lexical binding.
8540 * window.c (Ftemp_output_buffer_show): New fun.
8541 (Fsave_window_excursion):
8542 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8544 * lread.c (lisp_file_lexically_bound_p): New function.
8545 (Fload): Bind Qlexical_binding.
8546 (readevalloop): Remove `evalfun' arg.
8547 Bind Qinternal_interpreter_environment.
8548 (Feval_buffer): Bind Qlexical_binding.
8549 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8551 (syms_of_lread): Declare `lexical-binding'.
8553 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8555 * keyboard.c (eval_dyn): New fun.
8556 (menu_item_eval_property): Use it.
8558 * image.c (parse_image_spec): Use Ffunctionp.
8560 * fns.c (concat, mapcar1): Accept byte-code-functions.
8562 * eval.c (Fsetq): Handle lexical vars.
8563 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8564 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8565 (FletX, Flet): Obey lexical binding.
8566 (Fcommandp): Handle closures.
8567 (Feval): New `lexical' arg.
8568 (eval_sub): New function extracted from Feval. Use it almost
8569 everywhere where Feval was used. Look up vars in lexical env.
8571 (Ffunctionp): Move from subr.el.
8572 (Ffuncall): Handle closures.
8573 (apply_lambda): Remove `eval_flags'.
8574 (funcall_lambda): Handle closures and new byte-code-functions.
8575 (Fspecial_variable_p): New function.
8576 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8577 but without exporting it to Lisp.
8579 * doc.c (Fdocumentation, store_function_docstring):
8580 * data.c (Finteractive_form): Handle closures.
8582 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8585 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8587 (exec_byte_code): New function extracted from Fbyte_code to handle new
8588 calling convention for byte-code-functions. Add new byte-codes.
8590 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8592 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8594 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8596 * xdisp.c (redisplay_internal): Fix prototype.
8598 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8600 * xdisp.c (SCROLL_LIMIT): New macro.
8601 (try_scrolling): Use it when setting scroll_limit.
8602 Limit scrolling to 100 screen lines.
8603 (redisplay_window): Even when falling back on "recentering",
8604 position point in the window according to scroll-conservatively,
8605 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8607 (try_scrolling): When point is above the window, allow searching
8608 as far as scroll_max, or one screenful, to compute vertical
8609 distance from PT to the scroll margin position. This prevents
8610 try_scrolling from unnecessarily failing when
8611 scroll-conservatively is set to a value slightly larger than the
8612 window height. Clean up the case of PT below the margin at bottom
8613 of window: scroll_max can no longer be INT_MAX. When aggressive
8614 scrolling is in use, don't let point enter the opposite scroll
8615 margin as result of the scroll.
8616 (syms_of_xdisp) <scroll-conservatively>: Document the
8617 threshold of 100 lines for never-recentering scrolling.
8619 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8621 * dispextern.h (move_it_by_lines):
8622 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8623 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8624 (message_log_check_duplicate): Remove parameters `prev_bol' and
8625 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8626 (redisplay_internal): Remove parameter `preserve_echo_area',
8627 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8629 * indent.c (Fvertical_motion):
8630 * window.c (window_scroll_pixel_based, Frecenter):
8631 Don't pass `need_y_p' to `move_it_by_lines'.
8633 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8635 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8636 steal a few bits to be more compact.
8637 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8638 Remove unneeded casts.
8640 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8642 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8644 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8645 binding" message (bug#7967).
8647 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8649 Fix more problems found by GCC 4.6.0's static checks.
8651 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8652 Remove unused local var.
8654 * editfns.c (Fmessage_box): Remove unused local var.
8656 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8657 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8658 Omit unused local vars.
8659 * window.c (shrink_windows): Omit unused local var.
8660 * menu.c (digest_single_submenu): Omit unused local var.
8661 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8662 Omit unused local var.
8664 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8665 Don't assume string length fits in int.
8666 (keyremap_step, read_key_sequence): Use size_t for sizes.
8667 (read_key_sequence): Don't check last_real_key_start redundantly.
8669 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8670 instead of alloca (Bug#8344).
8672 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8673 (Fbacktrace_frame): Don't assume nframes fits in int.
8675 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8677 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8680 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8682 * cm.c (calccost): Turn while-do into do-while, for clarity.
8684 * keyboard.c (syms_of_keyboard): Use the same style as later
8685 in this function when indexing through an array. This also
8686 works around GCC bug 48267.
8688 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8690 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8692 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8693 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8695 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8696 This avoids undefined behavior on integer overflow, and is a bit
8697 more convenient anyway since it is compared to a size_t variable.
8699 Variadic C functions now count arguments with size_t, not int.
8700 This avoids an unnecessary limitation on 64-bit machines, which
8701 caused (substring ...) to crash on large vectors (Bug#8344).
8702 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8703 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8704 All variadic functions and their callers changed accordingly.
8705 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8706 * data.c (arith_driver, float_arith_driver): Likewise.
8707 * editfns.c (general_insert_function): Likewise.
8708 * eval.c (struct backtrace.nargs, interactive_p)
8709 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8710 (funcall_lambda, mark_backtrace): Likewise.
8711 * fns.c (concat): Likewise.
8712 * frame.c (x_set_frame_parameters): Likewise.
8713 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8714 0 if not found, not -1. All callers changed.
8716 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8717 (stack_copy_size): Now size_t, not int.
8718 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8720 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8722 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8723 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8724 All callers changed.
8726 * lisp.h (multibyte_char_to_unibyte):
8727 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8728 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8729 * character.h (CHAR_TO_BYTE8):
8730 * cmds.c (internal_self_insert):
8731 * editfns.c (general_insert_function):
8732 * keymap.c (push_key_description):
8733 * search.c (Freplace_match):
8734 * xdisp.c (message_dolog, set_message_1): All callers changed.
8736 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8738 * keyboard.c (safe_run_hook_funcall): New function.
8739 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8740 don't set the hook to nil, but remove the offending function instead.
8741 (Qcommand_hook_internal): Remove, unused.
8742 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8743 Vcommand_hook_internal.
8745 * eval.c (enum run_hooks_condition): Remove.
8746 (funcall_nil, funcall_not): New functions.
8747 (run_hook_with_args): Call each function through a `funcall' argument.
8748 Remove `cond' argument, now redundant.
8749 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8750 (Frun_hook_with_args_until_failure): Adjust accordingly.
8751 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8753 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8755 * dispextern.h (string_buffer_position): Remove declaration.
8757 * print.c (strout): Remove parameter `multibyte', unused since
8758 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8760 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8761 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8762 All callers changed.
8764 * w32.c (_wsa_errlist): Use braces for struct initializers.
8766 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8767 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8768 All callers changed.
8769 (string_buffer_position): Likewise. Also, make static (it's never
8770 used outside xdisp.c).
8771 (cursor_row_p): Remove parameter `w', unused since
8772 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8773 (decode_mode_spec): Remove parameter `precision', introduced during
8774 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8775 All callers changed.
8777 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8779 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8781 2011-03-27 Anders Lindgren <andlind@gmail.com>
8783 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8784 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8785 (ns_update_auto_hide_menu_bar): New functions.
8786 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8787 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8788 ns_constrain_all_frames.
8789 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8790 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8792 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8794 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8796 2011-03-27 Glenn Morris <rgm@gnu.org>
8798 * syssignal.h: Replace RETSIGTYPE with void.
8799 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8800 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8801 Replace SIGTYPE with void everywhere.
8802 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8803 * s/template.h (SIGTYPE): Remove commented out definition.
8805 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8807 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8808 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8810 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8812 * w32.c (read_unc_volume): Use parameter `henum', instead of
8813 global variable `wget_enum_handle'.
8815 * keymap.c (describe_vector): Remove parameters `indices' and
8816 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8817 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8819 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8821 * keyboard.c (timer_check): Remove parameter `do_it_now',
8822 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8823 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8824 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8826 * keyboard.c (read_char):
8827 * w32menu.c (w32_menu_display_help):
8828 * xmenu.c (show_help_event, menu_help_callback):
8829 Adjust calls to `show_help_echo'.
8831 * gtkutil.c (xg_maybe_add_timer):
8832 * keyboard.c (readable_events):
8833 * process.c (wait_reading_process_output):
8834 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8836 * insdel.c (adjust_markers_gap_motion):
8837 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8838 (gap_left, gap_right): Don't call it.
8840 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8842 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8843 incurred during fontification.
8845 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8847 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8848 (DEFVAR_PER_BUFFER): Don't pass it.
8850 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8851 (scrolling_window): Don't pass it.
8853 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8855 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8857 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8859 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8860 of variables specific to SELinux and computation of `encoded_absname'.
8862 * image.c (XPutPixel): Remove unused variable `height'.
8864 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8866 * unexw32.c (get_section_info): Remove unused variable `section'.
8868 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8869 (system_process_attributes): Remove unused variable `sess'.
8870 (sys_read): Remove unused variable `err'.
8872 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8873 (w32_wnd_proc): Remove unused variable `isdead'.
8874 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8875 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8876 (x_create_tip_frame): Remove unused variable `tem'.
8878 * w32inevt.c (w32_console_read_socket):
8879 Remove unused variable `no_events'.
8881 * w32term.c (x_draw_composite_glyph_string_foreground):
8882 Remove unused variable `width'.
8884 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8886 * w32term.c (x_set_glyph_string_clipping):
8887 Don't pass uninitialized region to CombineRgn.
8889 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8891 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8892 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8893 (Fx_close_connection): Remove unused variable `i'.
8895 * w32font.c (w32font_draw): Return number of glyphs.
8896 (w32font_open_internal): Remove unused variable `i'.
8897 (w32font_driver): Add missing initializer.
8899 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8900 (fill_in_menu): Remove unused variable `items_added'.
8902 * w32term.c (last_mouse_press_frame): Remove static global variable.
8903 (w32_clip_to_row): Remove unused variable `f'.
8904 (x_delete_terminal): Remove unused variable `i'.
8906 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8907 (NOTHING): Remove unused static global variable.
8908 (uniscribe_check_otf): Remove unused variable `table'.
8909 (uniscribe_font_driver): Add missing initializers.
8911 2011-03-23 Julien Danjou <julien@danjou.info>
8913 * term.c (Fsuspend_tty, Fresume_tty):
8914 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8915 * window.c (temp_output_buffer_show):
8916 * insdel.c (signal_before_change):
8917 * frame.c (Fhandle_switch_frame):
8918 * fileio.c (Fdo_auto_save):
8919 * emacs.c (Fkill_emacs):
8920 * editfns.c (save_excursion_restore):
8921 * cmds.c (internal_self_insert):
8922 * callint.c (Fcall_interactively):
8923 * buffer.c (Fkill_all_local_variables):
8924 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8926 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8927 unconditionally since it does the check itself.
8929 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8931 Fix more problems found by GCC 4.5.2's static checks.
8933 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8934 the first time through the loop, since we know p0 < p1 then.
8935 This also avoids a gcc -Wstrict-overflow warning.
8937 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8938 leading to a memory leak, possible in functions like
8939 load_charset_map_from_file that can allocate an unbounded number
8940 of objects (Bug#8318).
8942 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8943 that could (at least in theory) be that large.
8945 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8946 This is less likely to overflow, and avoids undefined behavior if
8947 overflow does occur. All callers changed. Use strtoul to scan
8948 for the unsigned long integer.
8949 (pint2hrstr): Simplify and tune code slightly.
8950 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8952 * scroll.c (do_scrolling): Work around GCC bug 48228.
8953 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8955 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8956 This also avoids a warning with gcc -Wstrict-overflow.
8957 (validate_x_resource_name): Simplify count usage.
8958 This also avoids a warning with gcc -Wstrict-overflow.
8960 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8963 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8965 * process.c (Fmake_network_process): Use socklen_t, not int,
8966 where POSIX says socklen_t is required in portable programs.
8967 This fixes a porting bug on hosts like 64-bit HP-UX, where
8968 socklen_t is wider than int (Bug#8277).
8969 (Fmake_network_process, server_accept_connection):
8970 (wait_reading_process_output, read_process_output):
8973 * process.c: Rename or move locals to avoid shadowing.
8974 (list_processes_1, Fmake_network_process):
8975 (read_process_output_error_handler, exec_sentinel_error_handler):
8976 Rename or move locals.
8977 (Fmake_network_process): Define label "retry_connect" only if needed.
8978 (Fnetwork_interface_info): Fix pointer signedness.
8979 (process_send_signal): Add cast to avoid pointer signedness problem.
8980 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8981 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8983 Make tparam.h and terminfo.c consistent.
8984 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8985 Include tparam.h instead, since it declares them.
8986 * cm.h (PC): Remove extern decl; tparam.h now does this.
8987 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8988 * terminfo.c: Include tparam.h, to check interfaces.
8989 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8990 (tparam): Adjust signature to match interface in tparam.h;
8991 this removes some undefined behavior. Check that outstring and len
8992 are zero, which they always are with Emacs.
8993 * tparam.h (PC, BC, UP): New extern decls.
8995 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8996 (xftfont_open): Rename locals to avoid shadowing.
8998 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8999 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9000 (OTF_TAG_SYM): Omit macro if not needed.
9001 (ftfont_list): Remove unused local.
9002 (get_adstyle_property, ftfont_pattern_entity):
9003 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9004 Rename locals to avoid shadowing.
9006 * xfont.c (xfont_list_family): Mark var as initialized.
9008 * xml.c (make_dom): Now static.
9010 * composite.c (composition_compute_stop_pos): Rename local to
9012 (composition_reseat_it): Remove unused locals.
9013 (find_automatic_composition, composition_adjust_point): Likewise.
9014 (composition_update_it): Mark var as initialized.
9015 (find_automatic_composition): Mark vars as initialized,
9016 with a FIXME (Bug#8290).
9018 character.h: Rename locals to avoid shadowing.
9019 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9020 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9021 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9022 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9025 * textprop.c (property_change_between_p): Remove; unused.
9027 * intervals.c (interval_start_pos): Now static.
9029 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9031 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9032 Rename locals to avoid shadowing.
9034 * sound.c (wav_play, au_play, Fplay_sound_internal):
9035 Fix pointer signedness.
9036 (alsa_choose_format): Remove unused local var.
9037 (wav_play): Initialize a variable to 0, to prevent undefined
9038 behavior (Bug#8278).
9040 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9042 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9044 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9045 clobbering (Bug#8298).
9046 * sysdep.c (sys_subshell): Likewise.
9047 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9049 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9050 This should get cleaned up, so that child_setup has the
9051 same signature on all platforms.
9053 * callproc.c (call_process_cleanup): Now static.
9054 (relocate_fd): Rename locals to avoid shadowing.
9056 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9058 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9059 not to be necessary, and produces flickering.
9061 2011-03-20 Glenn Morris <rgm@gnu.org>
9063 * config.in: Remove file.
9065 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9067 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9068 are now in src/globals.h.
9069 (syms_of_minibuf): Remove spurious & from previous change.
9071 2011-03-20 Leo Liu <sdl.web@gmail.com>
9073 * minibuf.c (completing-read-function): New variable.
9074 (completing-read-default): Rename from completing-read.
9075 (completing-read): Call completing-read-function.
9077 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9079 * xfaces.c (Fx_load_color_file):
9080 Read color file from absolute filename (bug#8250).
9082 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9084 * makefile.w32-in: Update dependencies.
9086 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9088 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9090 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9092 Fix more problems found by GCC 4.5.2's static checks.
9094 * process.c (make_serial_process_unwind, send_process_trap):
9095 (sigchld_handler): Now static.
9097 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9098 That way, the code declares only the vars that it needs.
9099 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9100 * s/cygwin.h (PTY_ITERATION): Likewise.
9101 * s/darwin.h (PTY_ITERATION): Likewise.
9102 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9104 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9105 * process.c (allocate_pty): Don't declare stb unless it's needed.
9107 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9108 (CONSTANTLIM): Remove; unused.
9109 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9110 Define only if needed.
9112 * unexelf.c (unexec): Name an expression,
9113 to avoid gcc -Wbad-function-cast warning.
9114 Use a different way to cause a compilation error if anyone uses
9115 n rather than nn, a way that does not involve shadowing.
9116 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9118 * deps.mk (unexalpha.o): Remove; unused.
9120 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9121 * unexec.h: New file.
9122 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9123 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9125 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9126 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9127 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9128 Change as necessary to match prototype in unexec.h.
9130 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9132 (back_comment, skip_chars): Mark vars as initialized.
9134 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9135 Rename locals to avoid shadowing.
9137 * lread.c (read1): Rewrite so as not to use empty "else".
9138 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9140 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9142 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9143 warning when compiling print.c.
9145 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9146 instead of using an uninitialized var.
9147 (font_sort_entities): Mark var as initialized.
9149 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9151 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9152 pointers to constants.
9153 (font_parse_fcname): Remove unused vars.
9154 (font_delete_unmatched): Now static.
9155 (font_get_spec): Remove; unused.
9156 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9157 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9158 Rename or move locals to avoid shadowing.
9160 * fns.c (require_nesting_list, require_unwind): Now static.
9161 (Ffillarray): Rename locals to avoid shadowing.
9163 * floatfns.c (domain_error2): Define only if needed.
9164 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9166 * alloc.c (mark_backtrace): Move decl from here ...
9167 * lisp.h: ... to here, so that it can be checked.
9169 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9170 (Fdefvar): Rewrite so as not to use empty "else".
9171 (lisp_indirect_variable): Name an expression,
9172 to avoid gcc -Wbad-function-cast warning.
9173 (Fdefvar): Rename locals to avoid shadowing.
9175 * callint.c (quotify_arg, quotify_args): Now static.
9176 (Fcall_interactively): Rename locals to avoid shadowing.
9177 Use const pointer when appropriate.
9179 * lisp.h (get_system_name, get_operating_system_release):
9180 Move decls here, to check interfaces.
9181 * process.c (get_operating_system_release): Move decl to lisp.h.
9182 * xrdb.c (get_system_name): Likewise.
9183 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9184 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9185 some of which prompt warnings from gcc -Wbad-function-cast.
9186 (Fformat_time_string, Fencode_time, Finsert_char):
9187 (Ftranslate_region_internal, Fformat):
9188 Rename or remove local vars to avoid shadowing.
9189 (Ftranslate_region_internal): Mark var as initialized.
9191 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9194 * lisp.h (eassert): Check that the argument compiles, even if
9195 ENABLE_CHECKING is not defined.
9197 * data.c (Findirect_variable): Name an expression, to avoid
9198 gcc -Wbad-function-cast warning.
9199 (default_value, arithcompare, arith_driver, arith_error): Now static.
9200 (store_symval_forwarding): Rename local to avoid shadowing.
9201 (Fmake_variable_buffer_local, Fmake_local_variable):
9202 Mark variables as initialized.
9203 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9205 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9206 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9207 Rename locals to avoid shadowing.
9208 (mark_stack): Move local variables into the #ifdef region where
9210 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9211 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9213 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9214 (GC_STRING_CHARS): Remove; not used.
9215 (Fmemory_limit): Cast sbrk's returned value to char *.
9217 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9218 avoids undefined behavior in theory.
9220 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9222 Use functions, not macros, for up- and down-casing (Bug#8254).
9223 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9224 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9225 to use the following functions instead of these macros.
9226 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9227 EMACS_INT, since callers assume the returned value fits in int.
9228 (upcase1): Likewise, for UPCASE_TABLE.
9229 (uppercasep, lowercasep, upcase): New static inline functions.
9230 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9231 the race-condition problem in the old DOWNCASE.
9233 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9234 Rename locals to avoid shadowing.
9235 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9236 (regex_compile, re_search_2, re_match_2_internal):
9237 Remove unused local vars.
9238 (FREE_VAR): Rewrite so as not to use empty "else",
9239 which gcc can warn about.
9240 (regex_compile, re_match_2_internal): Mark locals as initialized.
9241 (RETALLOC_IF): Define only if needed.
9242 (WORDCHAR_P): Likewise. This one is never needed, but is used
9243 only in a comment talking about a compiler bug, so put inside
9244 the #if 0 of that comment.
9245 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9246 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9249 * search.c (boyer_moore): Rename locals to avoid shadowing.
9250 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9251 (PREV_CHAR_BOUNDARY): Likewise.
9253 * search.c (simple_search): Remove unused var.
9255 * dired.c (compile_pattern): Move decl from here ...
9256 * lisp.h: ... to here, so that it can be checked.
9257 (struct re_registers): New forward decl.
9259 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9261 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9263 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9264 Rename locals to avoid shadowing.
9265 (Fvertical_motion): Mark locals as initialized.
9267 * casefiddle.c (casify_object, casify_region): Now static.
9268 (casify_region): Mark local as initialized.
9270 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9272 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9273 New macros, so that the caller can use some names other than
9274 gcpro1, gcpro2, etc.
9275 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9277 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9278 argument, for consistency with GCPRO2_VAR, etc: it is now the
9279 prefix of the variable, not the variable itself. All uses
9281 * dired.c (directory_files_internal, file_name_completion):
9282 Rename locals to avoid shadowing.
9284 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9285 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9286 dired.c's scmp function, had undefined behavior.
9287 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9288 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9289 * buffer.h: ... to here, because these macros use current_buffer,
9290 and the new implementation with inline functions needs to have
9291 current_buffer in scope now, rather than later when the macros
9293 (downcase, upcase1): New static inline functions.
9294 (DOWNCASE, UPCASE1): Reimplement using these functions.
9295 This avoids undefined behavior in expressions like
9296 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9297 from race conditions in accessing the global variables
9298 case_temp1 and case_temp2.
9299 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9300 * lisp.h (case_temp1, case_temp2): Remove their decls.
9301 * character.h (ASCII_CHAR_P): Move from here ...
9302 * lisp.h: ... to here, so that the inline functions mentioned
9305 * dired.c (directory_files_internal_unwind): Now static.
9307 * fileio.c (file_name_as_directory, directory_file_name):
9308 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9310 (file_name_as_directory): Use const pointers when appropriate.
9311 (Fexpand_file_name): Likewise. In particular, newdir might
9312 point at constant storage, so make it a const pointer.
9313 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9314 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9316 (Fset_file_times, Finsert_file_contents, auto_save_error):
9317 Rename locals to avoid shadowing.
9319 * minibuf.c (choose_minibuf_frame_1): Now static.
9320 (Ftry_completion, Fall_completions): Rename or remove locals
9323 * marker.c (bytepos_to_charpos): Remove; unused.
9325 * lisp.h (verify_bytepos, count_markers): New decls,
9326 so that gcc does not warn that these functions aren't declared.
9328 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9329 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9330 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9331 (copy_text): Remove unused local var.
9333 * filelock.c (within_one_second): Now static.
9334 (lock_file_1): Rename local to avoid shadowing.
9336 * buffer.c (fix_overlays_before): Mark locals as initialized.
9337 (fix_start_end_in_overlays): Likewise. This function should be
9338 simplified by using pointers-to-pointers, but that's a different
9340 (switch_to_buffer_1): Now static.
9341 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9342 (report_overlay_modification): Rename locals to avoid shadowing.
9344 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9345 Fix pointer signedness issue.
9346 (sys_subshell): Mark local as volatile if checking for lint,
9347 to suppress a gcc -Wclobbered warning that does not seem to be right.
9348 (MAXPATHLEN): Define only if needed.
9350 * process.c (serial_open, serial_configure): Move decls from here ...
9351 * systty.h: ... to here, so that they can be checked.
9353 * fns.c (get_random, seed_random): Move extern decls from here ...
9354 * lisp.h: ... to here, so that they can be checked.
9356 * sysdep.c (reset_io): Now static.
9357 (wait_for_termination_signal): Remove; unused.
9359 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9360 (copy_keymap_item, append_key, push_text_char_description):
9362 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9363 (DENSE_TABLE_SIZE): Remove; unused.
9364 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9365 (describe_map_tree):
9366 Rename locals to avoid shadowing.
9368 * keyboard.c: Declare functions static if they are not used elsewhere.
9369 (echo_char, echo_dash, cmd_error, top_level_2):
9370 (poll_for_input, handle_async_input): Now static.
9371 (read_char, kbd_buffer_get_event, make_lispy_position):
9372 (make_lispy_event, make_lispy_movement, apply_modifiers):
9373 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9374 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9375 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9376 (read_key_sequence, read_char): Mark locals as initialized.
9377 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9379 * keyboard.h (make_ctrl_char): New decl.
9380 (mark_kboards): Move decl here ...
9381 * alloc.c (mark_kboards): ... from here.
9383 * lisp.h (force_auto_save_soon): New decl.
9385 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9386 (DEFINE_DUMMY_FUNCTION): New macro.
9387 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9389 (main): Add casts to avoid warnings
9390 if GCC considers string literals to be constants.
9392 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9394 * dbusbind.c: Pointer signedness fixes.
9395 (xd_signature, xd_append_arg, xd_initialize):
9396 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9397 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9398 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9399 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9401 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9402 if GCC considers string literals to be constants.
9403 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9405 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9407 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9408 (print_preprocess, print_object): New macro to fix last change.
9410 * print.c (print_preprocess): Don't forget font objects.
9412 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9414 * emacs.c (USAGE3): Doc fixes.
9416 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9418 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9421 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9423 * lisp.h (VWindow_system, Qfile_name_history):
9424 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9425 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9426 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9428 * w32select.c: Don't #include "keyboard.h".
9429 (run_protected): Add extern declaration for waiting_for_input.
9431 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9432 * w32console.c (detect_input_pending, read_input_pending)
9433 (encode_terminal_code):
9434 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9435 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9436 (w32_system_caret_y, Qfile_name_history):
9437 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9438 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9439 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9440 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9441 * w32proc.c (Qlocal, report_file_error):
9442 * w32term.c (Vwindow_system, updating_frame):
9443 * w32uniscribe.c (initialized, uniscribe_font_driver):
9444 Remove unneeded extern declarations.
9446 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9448 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9450 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9452 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9453 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9454 These macros can no longer be used for assignment.
9456 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9457 Assign struct members directly, instead of using BUF_BEGV etc.
9458 (record_buffer_markers, fetch_buffer_markers): New functions for
9459 recording and fetching special buffer markers.
9460 (set_buffer_internal_1, set_buffer_temp): Use them.
9462 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9464 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9466 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9467 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9469 * xdisp.c (hscroll_window_tree):
9470 (reconsider_clip_changes): Use PT instead of BUF_PT.
9472 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9474 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9475 $(EMACS_ROOT)/lib/intprops.h.
9477 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9479 Fix more problems found by GCC 4.5.2's static checks.
9481 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9482 to unsigned char * to avoid compiler diagnostic.
9483 (xg_free_frame_widgets): Make it clear that a local variable is
9484 needed only if USE_GTK_TOOLTIP.
9485 (gdk_window_get_screen): Make it clear that this macro is needed
9486 only if USE_GTK_TOOLTIP.
9487 (int_gtk_range_get_value): New function, which avoids a diagnostic
9488 from gcc -Wbad-function-cast.
9489 (xg_set_toolkit_scroll_bar_thumb): Use it.
9490 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9491 diagnostic from gcc -Wbad-function-cast.
9492 (get_utf8_string, xg_get_file_with_chooser):
9493 Rename locals to avoid shadowing.
9494 (create_dialog): Move locals to avoid shadowing.
9496 * xgselect.c (xg_select): Remove unused var.
9498 * image.c (four_corners_best): Mark locals as initialized.
9499 (gif_load): Initialize transparent_p to zero (Bug#8238).
9500 Mark another local as initialized.
9501 (my_png_error, my_error_exit): Mark with NO_RETURN.
9503 * image.c (clear_image_cache): Now static.
9504 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9505 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9506 (x_edge_detection): Remove unnecessary cast that
9507 gcc -Wbad-function-cast diagnoses.
9508 (gif_load): Fix pointer signedness.
9509 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9510 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9512 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9514 Improve quality of tests for time stamp overflow.
9515 For example, without this patch (encode-time 0 0 0 1 1
9516 1152921504606846976) returns the obviously-bogus value (-948597
9517 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9518 reports time overflow. See
9519 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9520 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9521 * editfns.c: Include limits.h and intprops.h.
9522 (TIME_T_MIN, TIME_T_MAX): New macros.
9523 (time_overflow): Move earlier, to before first use.
9524 (hi_time, lo_time): New functions, for an accurate test for
9526 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9527 (Fget_internal_run_time): Don't assume time_t fits in int.
9528 (make_time): Use list2 instead of Fcons twice.
9529 (Fdecode_time): More accurate test for out-of-range times.
9530 (check_tm_member): New function.
9531 (Fencode_time): Use it, to test for out-of-range times.
9532 (lisp_time_argument): Don't rely on undefined left-shift and
9533 right-shift behavior when checking for time stamp overflow.
9535 * editfns.c (time_overflow): New function, refactoring common code.
9536 (Fformat_time_string, Fdecode_time, Fencode_time):
9537 (Fcurrent_time_string): Use it.
9539 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9540 * dired.c (make_time): Move to ...
9541 * editfns.c (make_time): ... here.
9542 * systime.h: Note the move.
9544 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9546 * fringe.c (update_window_fringes): Remove unused variables.
9548 * unexmacosx.c (copy_data_segment): Also copy __got section.
9551 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9553 * termcap.c [MSDOS]: Include "msdos.h".
9554 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9555 Constify `char *' arguments and their references according to
9556 prototypes in tparam.h.
9558 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9560 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9561 Adapt all references accordingly.
9563 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9565 2011-03-11 Tom Tromey <tromey@redhat.com>
9567 * buffer.c (syms_of_buffer): Remove obsolete comment.
9569 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9571 * termhooks.h (encode_terminal_code): Declare prototype.
9573 * msdos.c (encode_terminal_code): Don't declare prototype.
9575 * term.c (encode_terminal_code): Now external again, used by
9576 w32console.c and msdos.c.
9578 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9579 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9581 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9583 Fix some minor problems found by GCC 4.5.2's static checks.
9585 * fringe.c (update_window_fringes): Mark locals as initialized
9587 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9589 * alloc.c (mark_fringe_data): Move decl from here ...
9590 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9591 to check its interface.
9592 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9594 * fontset.c (free_realized_fontset): Now static.
9595 (Fset_fontset_font): Rename local to avoid shadowing.
9596 (fontset_font): Mark local as initialized.
9597 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9599 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9601 * xselect.c (x_disown_buffer_selections): Remove; not used.
9602 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9603 (x_own_selection, Fx_disown_selection_internal): Rename locals
9605 (x_handle_dnd_message): Remove local to avoid shadowing.
9607 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9608 so that the caller can use some name other than gcpro1.
9609 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9610 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9611 (Fx_backspace_delete_keys_p):
9612 Use them to avoid shadowing, and rename vars to avoid shadowing.
9613 (x_decode_color, x_set_name, x_window): Now static.
9614 (Fx_create_frame): Add braces to silence GCC warning.
9615 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9616 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9617 Remove unused locals.
9618 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9619 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9620 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9623 * xterm.h (x_mouse_leave): New decl.
9625 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9626 Remove unused functions.
9627 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9628 (x_calc_absolute_position): Now static.
9629 (XTread_socket): Don't define label "out" unless it's used.
9630 Don't declare local "event" unless it's used.
9631 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9632 unless they are used.
9633 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9634 (x_fatal_error_signal): Remove; not used.
9635 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9636 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9637 (x_error_catcher, x_connection_closed, x_error_handler):
9638 (x_error_quitter, xembed_send_message, x_iconify_frame):
9639 (my_log_handler): Rename locals to avoid shadowing.
9640 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9641 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9643 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9644 Rename or move locals to avoid shadowing.
9645 (tty_defined_color, merge_face_heights): Now static.
9646 (free_realized_faces_for_fontset): Remove; not used.
9647 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9648 does not deduce is never used uninitialized.
9649 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9650 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9652 * terminal.c (store_terminal_param): Now static.
9654 * xmenu.c (menu_highlight_callback): Now static.
9655 (set_frame_menubar): Remove unused local.
9656 (xmenu_show): Rename parameter to avoid shadowing.
9657 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9658 since they might point to immutable storage.
9659 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9660 since it's unused otherwise.
9662 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9663 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9664 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9665 avoids a gcc -Wuninitialized diagnostic.
9666 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9667 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9668 does not deduce are never used uninitialized.
9670 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9672 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9673 * window.c (window_loop, size_window):
9674 (run_window_configuration_change_hook, enlarge_window): Likewise.
9676 * window.c (display_buffer): Now static.
9677 (size_window): Mark variables that gcc -Wuninitialized
9678 does not deduce are never used uninitialized.
9679 * window.h (check_all_windows): New decl, to forestall
9680 gcc -Wmissing-prototypes diagnostic.
9681 * dispextern.h (bidi_dump_cached_states): Likewise.
9683 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9685 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9687 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9688 and to avoid gcc -Wuninitialized warning.
9689 (load_charset_map): Mark variables that gcc -Wuninitialized
9690 does not deduce are never used uninitialized.
9691 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9693 * coding.c (coding_set_source, coding_set_destination):
9694 Use "else { /* comment */ }" rather than "else /* comment */;"
9695 for clarity, and to avoid gcc -Wempty-body warning.
9696 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9697 a block, when the outer 'i' will do.
9698 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9699 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9700 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9701 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9702 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9703 Rename locals to avoid shadowing.
9704 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9705 * coding.c (emacs_mule_char, encode_invocation_designation):
9706 Now static, since they're not used elsewhere.
9707 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9708 (decode_coding_object, encode_coding_object, detect_coding_system):
9709 (decode_coding_emacs_mule): Mark variables that gcc
9710 -Wuninitialized does not deduce are never used uninitialized.
9711 (detect_coding_iso_2022): Initialize a local variable that might
9712 be used uninitialized. Leave a FIXME because it's not clear that
9713 this initialization is needed. (Bug#8211)
9714 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9715 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9716 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9717 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9718 Remove unused macros.
9720 * category.c (hash_get_category_set): Remove unused local var.
9721 (copy_category_table): Now static, since it's not used elsewhere.
9722 * character.c (string_count_byte8): Likewise.
9724 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9725 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9727 * chartab.c (copy_sub_char_table): Now static, since it's not used
9729 (sub_char_table_ref_and_range, char_table_ref_and_range):
9730 Rename locals to avoid shadowing.
9731 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9733 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9734 (BIDI_BOB): Remove unused macro.
9736 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9737 deduce are never used uninitialized.
9738 * term.c (encode_terminal_code): Likewise.
9740 * term.c (encode_terminal_code): Now static. Remove unused local.
9742 * tparam.h: New file.
9743 * term.c, tparam.h: Include it.
9744 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9745 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9746 Move these decls to tparam.h, and make them agree with what
9747 is actually in tparam.c. The previous trick of using incompatible
9748 decls in different modules does not conform to the C standard.
9749 All callers of tparam changed to use tparam's actual API.
9750 * tparam.c (tparam1, tparam, tgoto):
9751 Use const pointers where appropriate.
9753 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9754 * cm.h (struct cm): Likewise.
9755 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9756 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9757 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9758 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9759 (turn_on_face, init_tty): Likewise.
9760 * termchar.h (struct tty_display_info): Likewise.
9762 * term.c (term_mouse_position): Rename local to avoid shadowing.
9764 * alloc.c (mark_ttys): Move decl from here ...
9765 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9767 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9769 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9771 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9773 * search.c (compile_pattern_1): Remove argument regp, unused since
9774 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9775 (compile_pattern): Don't pass it.
9777 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9779 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9780 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9782 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9784 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9786 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9787 gdk_window_get_screen, gdk_window_get_geometry,
9788 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9789 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9790 (xg_get_pixbuf_from_pixmap): New function.
9791 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9792 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9793 Call xg_get_pixbuf_from_pixmap instead of
9794 gdk_pixbuf_get_from_drawable.
9795 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9796 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9797 (xg_check_special_colors): Use GtkStyleContext and its functions
9799 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9800 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9801 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9802 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9803 Call gtk_widget_get_preferred_size.
9804 (xg_frame_resized): gdk_window_get_geometry only takes 5
9806 (xg_win_to_widget, xg_event_is_for_menubar):
9807 Call gdk_x11_window_lookup_for_display.
9808 (xg_set_widget_bg): New function.
9809 (delete_cb): New function.
9810 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9811 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9812 (xg_set_background_color): Call xg_set_widget_bg.
9813 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9814 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9815 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9816 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9818 (update_frame_tool_bar): Call gtk_widget_hide.
9819 (xg_initialize): Use GDK_KEY_g.
9821 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9823 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9825 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9826 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9827 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9829 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9831 * w32xfns.c (select_palette): Check success of RealizePalette against
9832 GDI_ERROR, not zero.
9834 See ChangeLog.11 for earlier changes.
9840 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9842 This file is part of GNU Emacs.
9844 GNU Emacs is free software: you can redistribute it and/or modify
9845 it under the terms of the GNU General Public License as published by
9846 the Free Software Foundation, either version 3 of the License, or
9847 (at your option) any later version.
9849 GNU Emacs is distributed in the hope that it will be useful,
9850 but WITHOUT ANY WARRANTY; without even the implied warranty of
9851 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9852 GNU General Public License for more details.
9854 You should have received a copy of the GNU General Public License
9855 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.